gdb/ChangeLog

   1 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
   4
   5 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
   6
   7         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
   8
   9 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  10             Tom Tromey  <tromey@adacore.com>
  11
  12         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
  13
  14 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  15
  16         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
  17         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
  18         method to compute the bounds of range types. Also print "[evaluated]"
  19         if the bounds' values come from a dynamic evaluation.
  20
  21 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
  22
  23         * cp-valprint.c (cp_print_value_fields): Don't print trailing
  24         whitespace when pretty printing is on.
  25
  26 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  27
  28         * ppc-linux-nat.c: Add include.
  29
  30 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  31
  32         * NEWS: Mention AArch64 Pointer Authentication.
  33
  34 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  35
  36         * arm-linux-nat.c: Add include.
  37
  38 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
  39
  40         * source-cache.c (source_cache::get_source_lines): Re-read
  41         fullname after calling open_source_file.
  42
  43 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
  44
  45         * NEWS: Mention TLS support for FreeBSD.
  46
  47 2019-03-25  Tom Tromey  <tromey@adacore.com>
  48
  49         * minsyms.c (BUNCH_SIZE): Update comment.
  50         (~minimal_symbol_reader): Remove old comment.
  51         (compact_minimal_symbols): Update comment.
  52         (minimal_symbol_reader::install): Remove old comment.  Update
  53         other comments.
  54
  55 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  56
  57         * s390-linux-nat.c: Add include.
  58
  59 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  60
  61         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  62         Call linux_get_hwcap.
  63         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
  64         Likewise.
  65         (aarch64_linux_get_hwcap): Remove function.
  66         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
  67         declaration.
  68         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
  69         linux_get_hwcap.
  70         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  71         * linux-tdep.c (linux_get_hwcap): Add function.
  72         (linux_get_hwcap2): Likewise.
  73         * linux-tdep.h (linux_get_hwcap): Add declaration.
  74         (linux_get_hwcap2): Likewise.
  75         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
  76         (ppc_linux_get_hwcap2): Likewise.
  77         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
  78         linux_get_hwcap.
  79         (ppc_linux_nat_target::insert_watchpoint): Likewise.
  80         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
  81         (ppc_linux_nat_target::read_description): Likewise.
  82         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
  83         * s390-linux-nat.c: Likewise.
  84         * s390-linux-tdep.c (s390_core_read_description): Likewise.
  85
  86 2019-03-24  Tom Tromey  <tom@tromey.com>
  87
  88         * ada-lang.c (standard_lookup): Simplify initialization.
  89         (ada_lookup_symbol_nonlocal): Simplify return.
  90         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
  91         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
  92         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
  93         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
  94         initialization.
  95         * solib.c (solib_global_lookup): Simplify.
  96         * symtab.c (null_block_symbol): Remove.
  97         (symbol_cache_lookup): Simplify returns.
  98         (lookup_language_this): Simplify returns.
  99         (lookup_symbol_aux): Simplify return.
 100         (lookup_local_symbol): Simplify returns.
 101         (lookup_global_symbol_from_objfile): Simplify return.
 102         (lookup_symbol_in_objfile_symtabs)
 103         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 104         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 105         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 106         * cp-namespace.c (cp_lookup_bare_symbol)
 107         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 108         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 109         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 110         (cp_lookup_symbol_via_imports): Simplify initialization.
 111         (find_symbol_in_baseclass): Likewise.
 112         * symtab.h (null_block_symbol): Remove.
 113         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 114         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 115         (d_lookup_symbol_module): Likewise.
 116         (find_symbol_in_baseclass): Simplify initialization.
 117
 118 2019-03-24  Tom Tromey  <tom@tromey.com>
 119
 120         * expression.h: Don't include symtab.h.
 121         (struct block): Forward declare.
 122
 123 2019-03-24  Tom Tromey  <tom@tromey.com>
 124
 125         * c-exp.y (typebase): Remove casts.
 126         * gdbtypes.c (lookup_unsigned_typename, )
 127         (lookup_signed_typename): Remove cast.
 128         * eval.c (parse_to_comma_and_eval): Remove cast.
 129         * parse.c (write_dollar_variable): Remove cast.
 130         * block.h (struct block) <superblock>: Now const.
 131         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 132         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 133         (map_block): Make "block" const.
 134         * symfile.h (struct quick_symbol_functions)
 135         <map_matching_symbols>: Constify block argument to "callback".
 136         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 137         const.
 138         (find_pc_sect_compunit_symtab): Make "b" const.
 139         (find_symbol_at_address): Likewise.
 140         (search_symbols): Likewise.
 141         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 142         (dw2_debug_names_lookup_symbol): Likewise.
 143         (dw2_map_matching_symbols): Update.
 144         * p-valprint.c (pascal_val_print): Remove "block".
 145         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 146         (aux_add_nonlocal_symbols): Make "block" const.
 147         (resolve_subexp): Remove cast.
 148         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 149         const.
 150         (iterate_over_file_blocks): Likewise.
 151         * f-exp.y (%union) <bval>: Remove.
 152         * coffread.c (patch_opaque_types): Make "b" const.
 153         * spu-tdep.c (spu_catch_start): Make "block" const.
 154         * c-valprint.c (print_unpacked_pointer): Remove "block".
 155         * symmisc.c (dump_symtab_1): Make "b" const.
 156         (block_depth): Make "block" const.
 157         * d-exp.y (%union) <bval>: Remove.
 158         * cp-support.h (cp_lookup_rtti_type): Update.
 159         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 160         * psymtab.c (psym_lookup_symbol): Make "block" const.
 161         (maintenance_check_psymtabs): Make "b" const.
 162         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 163         (enumerate_locals, enumerate_args): Update.
 164         * python/py-symtab.c (stpy_global_block): Make "block" const.
 165         (stpy_static_block): Likewise.
 166         * inline-frame.c (block_starting_point_at): Make "new_block"
 167         const.
 168         * block.c (find_block_in_blockvector): Make return type const.
 169         (blockvector_for_pc_sect): Make "b" const.
 170         (find_block_in_blockvector): Make "b" const.
 171
 172 2019-03-23  Tom Tromey  <tom@tromey.com>
 173
 174         * varobj.c (varobj_create): Update.
 175         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 176         * printcmd.c (display_command, do_one_display): Don't reset
 177         innermost_block.
 178         * parser-defs.h (enum innermost_block_tracker_type): Move to
 179         expression.h.
 180         (innermost_block): Update comment.
 181         * parse.c (parse_exp_1): Add tracker_types parameter.
 182         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 183         tracker_types parameter.  Reset innermost_block.
 184         (parse_exp_in_context): Remove.
 185         (parse_expression_for_completion): Update.
 186         * objfiles.c (~objfile): Don't reset expression_context_block or
 187         innermost_block.
 188         * expression.h (enum innermost_block_tracker_type): Move from
 189         parser-defs.h.
 190         (parse_exp_1): Add tracker_types parameter.
 191         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 192         reset innermost_block.
 193
 194 2019-03-23  Tom Tromey  <tom@tromey.com>
 195
 196         * objfiles.h: Include bcache.h.
 197
 198 2019-03-23  Tom Tromey  <tom@tromey.com>
 199
 200         * linespec.c (get_current_search_block): Use
 201         scoped_restore_current_language.
 202         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 203
 204 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 205             Jiong Wang  <jiong.wang@arm.com>
 206
 207         * aarch64-linux-tdep.c
 208         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 209         section.
 210         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 211
 212 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 213             Jiong Wang  <jiong.wang@arm.com>
 214
 215         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 216         instructions.
 217         (aarch64_analyze_prologue_test): Add PACIASP test.
 218         (aarch64_prologue_prev_register): Unmask PC value.
 219
 220 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 221             Jiong Wang  <jiong.wang@arm.com>
 222
 223         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 224         (aarch64_dwarf2_prev_register): Unmask PC value.
 225         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 226         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 227         DW_CFA_AARCH64_negate_ra_state.
 228         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 229
 230 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 231             Jiong Wang  <jiong.wang@arm.com>
 232
 233         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 234         registers.
 235         (aarch64_pseudo_register_name): Likewise.
 236         (aarch64_pseudo_register_type): Likewise.
 237         (aarch64_pseudo_register_reggroup_p): Likewise.
 238         (aarch64_gdbarch_init): Add pauth registers.
 239         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 240         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 241         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 242         (struct gdbarch_tdep): Add regnum for ra_state.
 243
 244 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 245             Jiong Wang  <jiong.wang@arm.com>
 246
 247         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 248
 249 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 250             Jiong Wang  <jiong.wang@arm.com>
 251
 252         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 253         function.
 254         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 255         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 256         (aarch64_gdbarch_init): Add puth registers.
 257         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 258         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 259         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 260
 261 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 262             Jiong Wang  <jiong.wang@arm.com>
 263
 264         * aarch64-linux-nat.c
 265         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 266         * aarch64-linux-tdep.c
 267         (aarch64_linux_core_read_description): Likewise.
 268         (aarch64_linux_get_hwcap): New function.
 269         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 270         (aarch64_linux_get_hwcap): New declaration.
 271
 272 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 273             Jiong Wang  <jiong.wang@arm.com>
 274
 275         * aarch64-linux-nat.c
 276         (aarch64_linux_nat_target::read_description): Add pauth param.
 277         * aarch64-linux-tdep.c
 278         (aarch64_linux_core_read_description): Likewise.
 279         * aarch64-tdep.c (struct target_desc): Add in pauth.
 280         (aarch64_read_description): Add pauth param.
 281         (aarch64_gdbarch_init): Likewise.
 282         * aarch64-tdep.h (aarch64_read_description): Likewise.
 283         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 284         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 285         * features/Makefile: Add new files.
 286         * features/aarch64-pauth.c: New file.
 287         * features/aarch64-pauth.xml: New file.
 288
 289 2019-03-20  Tom Tromey  <tromey@adacore.com>
 290
 291         * infrun.c (handle_inferior_event): Rename from
 292         handle_inferior_event_1.  Create a scoped_value_mark.
 293         (handle_inferior_event): Remove.
 294
 295 2019-03-19  Tom Tromey  <tromey@adacore.com>
 296
 297         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 298         * infrun.h (print_stop_event): Add "displays" parameter.
 299         * infrun.c (print_stop_event): Add "displays" parameter.
 300
 301 2019-03-19  Pedro Alves  <palves@redhat.com>
 302
 303         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 304         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 305         to -1.  Fix TABs vs spaces.
 306         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 307         * tui/tui-out.h (tui_ui_out) Add intro comments.
 308         <m_line, m_start_of_line>: In-class initialize, and add describing
 309         comment.
 310
 311 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 312
 313         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 314         variable names.
 315         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 316
 317 2019-03-18  Pedro Alves  <palves@redhat.com>
 318             Eli Zaretskii <eliz@gnu.org>
 319
 320         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 321         m_line and m_start_of_line.
 322
 323 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 324
 325         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 326         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 327         it returns a newline.  This fixes a regression in TU mode, whereby
 328         the next line is output on the same screen line as the user input.
 329
 330 2019-03-18  Tom Tromey  <tromey@adacore.com>
 331
 332         * minsyms.c (minimal_symbol_reader::install): Remove call to
 333         obstack_blank.
 334
 335 2019-03-18  Pedro Alves  <palves@redhat.com>
 336
 337         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 338         New globals.
 339         (apply_style): New, factored out from ...
 340         (apply_ansi_escape): ... this.  Handle reverse video mode.
 341         (tui_set_reverse_mode): New function.
 342         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 343         * tui/tui-winsource.c (tui_show_source_line): Use
 344         tui_set_reverse_mode instead of setting A_STANDOUT.
 345         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 346         New setter methods.
 347
 348 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 349
 350         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 351         Handle tabs.
 352
 353 2019-03-18  Tom Tromey  <tromey@adacore.com>
 354
 355         * ada-lang.c (empty_array): Add "high" parameter.
 356         (ada_evaluate_subexp): Update.
 357
 358 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 359
 360         * unittests/string_view-selftests.c: Define
 361         _initialize_string_view_selftests unconditionally.
 362
 363 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 364
 365         PR gdb/24350
 366         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 367
 368 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 369
 370         PR gdb/24351
 371         * windows-nat.c (display_selector): Fix format specifiers.
 372
 373 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 374
 375         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 376         tui_refill_source_window instead of tui_refresh_win, to update the
 377         current execution line.  This fixes redisplay of the current line
 378         when stepping through the code with "next" or "step".
 379
 380 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 381
 382         * source-cache.c (source_cache::get_source_lines): Call
 383         find_source_lines to initialize s->nlines.  This fixes vertical
 384         scrolling of TUI source window when the DOWN arrow is pressed.
 385
 386 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 387
 388         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 389         linux-thread-db.c (_initialize_thread_db): Likewise.
 390
 391 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 392
 393         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 394         wclrtoeol in tui_show_source_line".  This reverts changes made in
 395         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 396
 397 2019-03-15  Tom Tromey  <tom@tromey.com>
 398
 399         * symtab.h (struct minimal_symbol): Derive from
 400         general_symbol_info.
 401         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 402         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 403         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 404         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 405         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 406         (MSYMBOL_SEARCH_NAME): Update.
 407         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 408         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 409         * minsyms.c (minimal_symbol_reader::record_full): Update.
 410
 411 2019-03-15  Tom Tromey  <tom@tromey.com>
 412
 413         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 414
 415 2019-03-15  Tom Tromey  <tom@tromey.com>
 416
 417         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 418         unique_xmalloc_ptr.
 419         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 420         Update.
 421         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 422         (build_minimal_symbol_hash_tables)
 423         (minimal_symbol_reader::install): Update.
 424
 425 2019-03-15  Tom Tromey  <tom@tromey.com>
 426
 427         * symtab.c (create_demangled_names_hash): Update.
 428         (symbol_set_names): Update.
 429         * objfiles.h (struct objfile_per_bfd_storage)
 430         <demangled_names_hash>: Now an htab_up.
 431         * objfiles.c (objfile_per_bfd_storage): Simplify.
 432
 433 2019-03-15  Tom Tromey  <tom@tromey.com>
 434
 435         * objfiles.h (struct objfile_per_bfd_storage): Declare
 436         destructor.
 437         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 438         New.
 439         (get_objfile_bfd_data): Use new.  Don't initialize
 440         language_of_main.
 441         (free_objfile_per_bfd_storage): Remove.
 442         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 443
 444 2019-03-15  Tom Tromey  <tom@tromey.com>
 445
 446         * symfile.c (reread_symbols): Update.
 447         * objfiles.c (objfile::objfile): Update.
 448         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 449         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 450         comment.
 451         (minimal_symbol_reader::install): Update.
 452         (terminate_minimal_symbol_table): Remove.
 453         * jit.c (jit_object_close_impl): Update.
 454
 455 2019-03-15  Tom Tromey  <tom@tromey.com>
 456
 457         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 458         initializations.
 459
 460 2019-03-15  Tom Tromey  <tom@tromey.com>
 461
 462         * objfiles.h (struct objfile_per_bfd_storage)
 463         <demangled_hash_languages>: Now a bitset.
 464         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 465         (lookup_minimal_symbol): Update.
 466
 467 2019-03-15  Tom Tromey  <tom@tromey.com>
 468
 469         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 470         Don't return the symbol.
 471         * coffread.c (record_minimal_symbol): Use record_full.
 472
 473 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 474
 475         The MS-Windows port of ncurses fails to switch to a color pair if
 476         one or both of the colors are the implicit default colors.  This
 477         change records the default colors when TUI is initialized, and
 478         then specifies them explicitly when a color pair uses the default
 479         colors.  This allows color styling in TUI mode on MS-Windows.
 480
 481         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 482         ncurses_norm_attr.
 483         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 484         colors in ncurses_norm_attr.
 485         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 486         "none", replace it with the default color recorded in
 487         ncurses_norm_attr.
 488
 489 2019-03-14  Tom Tromey  <tromey@adacore.com>
 490
 491         * source-cache.h (class source_cache) <get_source_lines>: Return
 492         std::string.
 493         * source-cache.c (source_cache::extract_lines): Handle case where
 494         first_pos==npos.  Return std::string.
 495         (source_cache::get_source_lines): Update.
 496
 497 2019-03-14  Tom Tromey  <tromey@adacore.com>
 498
 499         * NEWS: Add item for "style sources" commands.
 500         * source-cache.c (source_cache::get_source_lines): Check
 501         source_styling.
 502         * cli/cli-style.c (source_styling): New global.
 503         (_initialize_cli_style): Add "style sources" commands.
 504         (show_style_sources): New function.
 505         * cli/cli-style.h (source_styling): Declare.
 506
 507 2019-03-14  Pedro Alves  <palves@redhat.com>
 508             Tom Tromey  <tromey@adacore.com>
 509
 510         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 511         * tui/tui-winsource.c (tui_refill_source_window): New function,
 512         from...
 513         (tui_horizontal_source_scroll): ... here.  Move some logic.
 514         * cli/cli-style.c (set_style_enabled): Notify new observable.
 515         * tui/tui-hooks.c (tui_redisplay_source): New function.
 516         (tui_attach_detach_observers): Attach or detach
 517         tui_redisplay_source.
 518         * observable.h (source_styling_changed): New observable.
 519         * observable.c: Define source_styling_changed observable.
 520
 521 2019-03-13  Tom Tromey  <tromey@adacore.com>
 522
 523         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 524         (i386_gnu_nat_target::store_registers): Update.
 525         * target-debug.h (target_debug_print_std_string): New macro.
 526         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 527         * windows-tdep.c (display_one_tib): Update.
 528         * tui/tui-stack.c (tui_make_status_line): Update.
 529         * top.c (print_inferior_quit_action): Update.
 530         * thread.c (thr_try_catch_cmd): Update.
 531         (add_thread_with_info): Update.
 532         (thread_target_id_str): Update.
 533         (thr_try_catch_cmd): Update.
 534         (thread_command): Update.
 535         (thread_find_command): Update.
 536         * record-btrace.c (record_btrace_target::info_record)
 537         (record_btrace_resume_thread, record_btrace_target::resume)
 538         (record_btrace_cancel_resume, record_btrace_step_thread)
 539         (record_btrace_target::wait, record_btrace_target::wait)
 540         (record_btrace_target::wait, record_btrace_target::stop): Update.
 541         * progspace.c (print_program_space): Update.
 542         * process-stratum-target.c
 543         (process_stratum_target::thread_address_space): Update.
 544         * linux-fork.c (linux_fork_mourn_inferior)
 545         (detach_checkpoint_command, info_checkpoints_command)
 546         (linux_fork_context): Update.
 547         (linux_fork_detach): Update.
 548         (class scoped_switch_fork_info): Update.
 549         (delete_checkpoint_command): Update.
 550         * infrun.c (follow_fork_inferior): Update.
 551         (follow_fork_inferior): Update.
 552         (proceed_after_vfork_done): Update.
 553         (handle_vfork_child_exec_or_exit): Update.
 554         (follow_exec): Update.
 555         (displaced_step_prepare_throw): Update.
 556         (displaced_step_restore): Update.
 557         (start_step_over): Update.
 558         (resume_1): Update.
 559         (clear_proceed_status_thread): Update.
 560         (proceed): Update.
 561         (print_target_wait_results): Update.
 562         (do_target_wait): Update.
 563         (context_switch): Update.
 564         (stop_all_threads): Update.
 565         (restart_threads): Update.
 566         (finish_step_over): Update.
 567         (handle_signal_stop): Update.
 568         (switch_back_to_stepped_thread): Update.
 569         (keep_going_pass_signal): Update.
 570         (print_exited_reason): Update.
 571         (normal_stop): Update.
 572         * inferior.c (inferior_pid_to_str): Change return type.
 573         (print_selected_inferior): Update.
 574         (add_inferior): Update.
 575         (detach_inferior): Update.
 576         * dummy-frame.c (fprint_dummy_frames): Update.
 577         * dcache.c (dcache_info_1): Update.
 578         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 579         (btrace_fetch, btrace_clear): Update.
 580         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 581         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 582         type.
 583         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 584         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 585         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 586         * gdbarch.c, gdbarch.h: Rebuild.
 587         * gdbarch.sh (core_pid_to_str): Change return type.
 588         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 589         return type.
 590         (windows_nat_target::pid_to_str): Change return type.
 591         (windows_delete_thread): Update.
 592         (windows_nat_target::attach): Update.
 593         (windows_nat_target::files_info): Update.
 594         * target-delegates.c: Rebuild.
 595         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 596         return type.
 597         (sol_thread_target::pid_to_str): Change return type.
 598         * remote.c (class remote_target) <pid_to_str>: Change return
 599         type.
 600         (remote_target::pid_to_str): Change return type.
 601         (extended_remote_target::attach, remote_target::remote_stop_ns)
 602         (remote_target::remote_notif_remove_queued_reply)
 603         (remote_target::push_stop_reply, remote_target::disable_btrace):
 604         Update.
 605         (extended_remote_target::attach): Update.
 606         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 607         type.
 608         (gdbsim_target::pid_to_str): Change return type.
 609         * ravenscar-thread.c (struct ravenscar_thread_target)
 610         <pid_to_str>: Change return type.
 611         (ravenscar_thread_target::pid_to_str): Change return type.
 612         * procfs.c (class procfs_target) <pid_to_str>: Change return
 613         type.
 614         (procfs_target::pid_to_str): Change return type.
 615         (procfs_target::attach): Update.
 616         (procfs_target::detach): Update.
 617         (procfs_target::fetch_registers): Update.
 618         (procfs_target::store_registers): Update.
 619         (procfs_target::wait): Update.
 620         (procfs_target::files_info): Update.
 621         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 622         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 623         return type.
 624         (nto_procfs_target::pid_to_str): Change return type.
 625         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 626         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 627         return type.
 628         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 629         (exit_lwp): Update.
 630         (attach_proc_task_lwp_callback, get_detach_signal)
 631         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 632         (linux_nat_target::resume, wait_lwp, stop_callback)
 633         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 634         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 635         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 636         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 637         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 638         type.
 639         (inf_ptrace_target::attach): Update.
 640         (inf_ptrace_target::files_info): Update.
 641         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 642         type.
 643         (go32_nat_target::pid_to_str): Change return type.
 644         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 645         (gnu_nat_target::wait): Update.
 646         (gnu_nat_target::wait): Update.
 647         (gnu_nat_target::resume): Update.
 648         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 649         (fbsd_nat_target::wait): Update.
 650         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 651         type.
 652         (darwin_nat_target::attach): Update.
 653         * corelow.c (class core_target) <pid_to_str>: Change return type.
 654         (core_target::pid_to_str): Change return type.
 655         * target.c (normal_pid_to_str): Change return type.
 656         (default_pid_to_str): Likewise.
 657         (target_pid_to_str): Change return type.
 658         (target_translate_tls_address): Update.
 659         (target_announce_detach): Update.
 660         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 661         return type.
 662         (bsd_uthread_target::pid_to_str): Change return type.
 663         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 664         type.
 665         (bsd_kvm_target::pid_to_str): Change return type.
 666         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 667         return type.
 668         (aix_thread_target::pid_to_str): Change return type.
 669         * target.h (struct target_ops) <pid_to_str>: Change return type.
 670         (target_pid_to_str, normal_pid_to_str): Likewise.
 671         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 672         type.
 673         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 674         type.
 675         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 676         return type.
 677         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 678         type.
 679         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 680         type.
 681         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 682         return type.
 683
 684 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 685
 686         * NEWS: Mention that the new default MI version is 3.  Mention
 687         changes to the output of commands and events that deal with
 688         multi-location breakpoints.
 689         * breakpoint.c: Include "mi/mi-out.h".
 690         (print_one_breakpoint): Change output syntax if using MI version
 691         >= 3.
 692         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 693         New.
 694         (mi_multi_location_breakpoint_output_fixed): New.
 695         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 696         (mi_cmd_fix_multi_location_breakpoint_output): New.
 697         (mi_multi_location_breakpoint_output_fixed): New.
 698         * mi/mi-cmds.c (mi_cmds): Register command
 699         -fix-multi-location-breakpoint-output.
 700         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 701         interpreter "mi".
 702
 703 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 704
 705         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 706         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 707         instantiate mi_ui_out based on interpreter name.
 708         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 709         * mi/mi-main.c (mi_load_progress): Likewise.
 710
 711 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 712
 713         * NEWS: Combine separate "New targets" sections for 8.3.
 714
 715 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 716
 717         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 718         (ppcfbsd_init_abi): Install gdbarch
 719         "fetch_tls_load_module_address" and "get_thread_local_address"
 720         methods.
 721
 722 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 723
 724         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 725         (riscv_fbsd_init_abi): Install gdbarch
 726         "fetch_tls_load_module_address" and "get_thread_local_address"
 727         methods.
 728
 729 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 730
 731         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 732         (i386fbsd_init_abi): Install gdbarch
 733         "fetch_tls_load_module_address" and "get_thread_local_address"
 734         methods.
 735
 736 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 737
 738         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 739         (amd64fbsd_init_abi): Install gdbarch
 740         "fetch_tls_load_module_address" and "get_thread_local_address"
 741         methods.
 742
 743 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 744
 745         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 746         (struct fbsd_pspace_data): New type.
 747         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 748         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 749         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 750         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 751         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 752
 753 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 754
 755         * gdbtypes.c (lookup_struct_elt): New function.
 756         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 757         * gdbtypes.h (struct struct_elt): New type.
 758         (lookup_struct_elt): New prototype.
 759
 760 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 761
 762         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 763         remove disabled code block.
 764
 765 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 766
 767         * gdbarch.sh (get_thread_local_address): New method.
 768         * gdbarch.h, gdbarch.c: Regenerate.
 769         * target.c (target_translate_tls_address): Use
 770         gdbarch_get_thread_local_address if present instead of
 771         target::get_thread_local_address.
 772
 773 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 774
 775         * target.h (target::get_thread_local_address): Update comment.
 776
 777 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 778
 779         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 780         objfile->separate_debug_objfile_backlink if not NULL.
 781
 782 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 783
 784         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 785         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 786         (amd64bsd_store_inferior_registers): Likewise.
 787         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 788         Enable segment base registers.
 789         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 790         PT_GETFSBASE and PT_GETGSBASE.
 791         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 792         PT_SETGSBASE.
 793         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 794         segment base registers.
 795         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 796
 797 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 798
 799         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 800         Update calls to i386_target_description to add 'segments'
 801         parameter.
 802         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 803         add segment base registers.
 804         * arch/i386.c (i386_create_target_description): Add 'segments'
 805         parameter to enable segment base registers.
 806         * arch/i386.h (i386_create_target_description): Likewise.
 807         * features/i386/32bit-segments.xml: New file.
 808         * features/i386/32bit-segments.c: Generate.
 809         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 810         call to i386_target_description to add 'segments' parameter.
 811         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 812         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 813         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 814         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 815         if feature is present.
 816         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 817         Add 'segments' parameter to call to i386_target_description.
 818         (i386_target_description): Add 'segments' parameter to enable
 819         segment base registers.
 820         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 821         to call to i386_target_description.
 822         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 823         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 824         Define I386_NUM_REGS.
 825         (i386_target_description): Add 'segments' parameter to enable
 826         segment base registers.
 827
 828 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 829
 830         PR/24325
 831         * source-cache.c: #undef open and close, to avoid unresolved
 832         externals during linking.
 833
 834 2019-03-12  Tom Tromey  <tromey@adacore.com>
 835
 836         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 837         const.  Add initializers.
 838         (_initialize_remote): Don't initialize ptid globals.
 839
 840 2019-03-12  Pedro Alves  <palves@redhat.com>
 841
 842         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 843
 844 2019-03-12  Pedro Alves  <palves@redhat.com>
 845
 846         * cp-name-parser.y (main): Remove unused 'len' variable.
 847
 848 2019-03-12  Tom Tromey  <tromey@adacore.com>
 849
 850         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 851         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 852
 853 2019-03-12  Tom Tromey  <tromey@adacore.com>
 854
 855         * linux-nat.c (iterate_over_lwps): Update.
 856         (stop_callback): Remove parameter.
 857         (stop_wait_callback, detach_callback, resume_set_callback)
 858         (select_singlestep_lwp_callback, set_ignore_sigint)
 859         (status_callback, resumed_callback, resume_clear_callback)
 860         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 861         data parameter.
 862         (linux_nat_target::detach, linux_nat_target::resume)
 863         (linux_stop_and_wait_all_lwps, select_event_lwp)
 864         (linux_nat_filter_event, linux_nat_wait_1)
 865         (linux_nat_target::kill, linux_nat_target::stop)
 866         (linux_nat_target::stop): Update.
 867         (linux_nat_resume_callback): Change type.
 868         (resume_stopped_resumed_lwps, count_events_callback)
 869         (select_event_lwp_callback): Likewise.
 870         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 871         * arm-linux-nat.c (struct update_registers_data): Remove.
 872         (update_registers_callback): Change type.
 873         (arm_linux_insert_hw_breakpoint1): Update.
 874         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 875         parameter.
 876         (x86_linux_dr_set_addr): Update.
 877         (x86_linux_dr_set_control): Update.
 878         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 879         (iterate_over_lwps): Use gdb::function_view.
 880         * nat/aarch64-linux-hw-point.c (struct
 881         aarch64_dr_update_callback_param): Remove.
 882         (debug_reg_change_callback): Change type.
 883         (aarch64_notify_debug_reg_change): Update.
 884         * s390-linux-nat.c (s390_refresh_per_info): Update.
 885
 886 2019-03-11  Tom Tromey  <tromey@adacore.com>
 887
 888         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 889         redundant assignment to "this_cu".
 890
 891 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 892
 893         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 894
 895 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 896
 897         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 898         from...
 899         (rank_one_type): ... this.
 900
 901 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 902
 903         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 904         from...
 905         (rank_one_type): ... this.
 906
 907 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 908
 909         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 910         from...
 911         (rank_one_type): ... this.
 912
 913 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 914
 915         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 916         from...
 917         (rank_one_type): ... this.
 918
 919 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 920
 921         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 922         from...
 923         (rank_one_type): ... this.
 924
 925 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 926
 927         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 928         from...
 929         (rank_one_type): ... this.
 930
 931 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 932
 933         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 934         from...
 935         (rank_one_type): ... this.
 936
 937 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 938
 939         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 940         from...
 941         (rank_one_type): ... this.
 942
 943 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 944
 945         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 946         from...
 947         (rank_one_type): ... this.
 948
 949 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 950
 951         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 952         from...
 953         (rank_one_type): ... this.
 954
 955 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 956
 957         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 958         from...
 959         (rank_one_type): ... this.
 960
 961 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 962
 963         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 964         from...
 965         (rank_one_type): ... this.
 966
 967 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 968
 969         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 970         inferior-events' shows the example events.
 971
 972 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 973
 974         Support styling on native MS-Windows console
 975
 976         PR/24315
 977         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 978         on MS-Windows if $TERM is not defined.
 979
 980         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 981
 982         * posix-hdep.c (gdb_console_fputs):
 983         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 984         functions.
 985         * ui-file.h (gdb_console_fputs): Add prototype.
 986
 987         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 988         back to fputs only if the former returns zero.
 989
 990 2019-03-07  Tom Tromey  <tom@tromey.com>
 991
 992         * symmisc.c (print_symbol_bcache_statistics): Update.
 993         (print_objfile_statistics): Update.
 994         * symfile.c (allocate_symtab): Update.
 995         * stabsread.c: Don't include bcache.h.
 996         * psymtab.h (struct psymbol_bcache): Don't declare.
 997         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 998         (psymbol_bcache_init, psymbol_bcache_free)
 999         (psymbol_bcache_get_bcache): Don't declare.
1000         * psymtab.c (struct psymbol_bcache): Remove.
1001         (psymtab_storage::psymtab_storage): Update.
1002         (psymtab_storage::~psymtab_storage): Update.
1003         (psymbol_bcache_init, psymbol_bcache_free)
1004         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1005         (add_psymbol_to_bcache): Update.
1006         (allocate_psymtab): Update.
1007         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1008         macro_cache>: No longer pointers.
1009         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1010         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1011         * macrotab.c (macro_bcache): Update.
1012         * macroexp.c: Don't include bcache.h.
1013         * gdbtypes.c (check_types_worklist): Update.
1014         (types_deeply_equal): Remove TRY/CATCH.  Update.
1015         * elfread.c (elf_symtab_read): Update.
1016         * dwarf2read.c: Don't include bcache.h.
1017         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1018         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1019         (print_bcache_statistics, bcache_memory_used): Don't declare.
1020         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1021         methods.  Rename all data members.
1022         * bcache.c (struct bcache): Move to bcache.h.
1023         (bcache::expand_hash_table): Rename from expand_hash_table.
1024         (bcache): Remove.
1025         (bcache::insert): Rename from bcache_full.
1026         (bcache::compare): Rename from bcache_compare.
1027         (bcache_xmalloc): Remove.
1028         (bcache::~bcache): Rename from bcache_xfree.
1029         (bcache::print_statistics): Rename from print_bcache_statistics.
1030         (bcache::memory_used): Rename from bcache_memory_used.
1031
1032 2019-03-07  Pedro Alves  <palves@redhat.com>
1033
1034         * infrun.c (normal_stop): Also check for
1035         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1036
1037 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1038
1039         * f-lang.c (value_from_host_double): Moved to...
1040         * value.c (value_from_host_double): ...here.
1041         * value.h (value_from_host_double): Declare.
1042         * guile/scm-math.c (vlscm_convert_typed_number): Use
1043         value_from_host_double.
1044         (vlscm_convert_number): Likewise.
1045         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1046         * python/py-value.c (convert_value_from_python): Likewise.
1047
1048 2019-03-06  Tom Tromey  <tom@tromey.com>
1049
1050         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1051
1052 2019-03-06  Tom Tromey  <tom@tromey.com>
1053
1054         * utils.h (free_current_contents): Don't declare.
1055         * utils.c (free_current_contents): Remove.
1056
1057 2019-03-06  Tom Tromey  <tom@tromey.com>
1058
1059         * top.c (quit_force): Update.
1060         * main.c (captured_command_loop): Update.
1061         * common/new-op.c (operator new): Update.
1062         * common/common-exceptions.c (struct catcher)
1063         <save_cleanup_chain>: Remove member.
1064         (exceptions_state_mc_init): Update.
1065         (exception_try_scope_entry): Return nullptr.
1066         (exception_try_scope_exit, exception_rethrow)
1067         (throw_exception_sjlj, throw_exception_cxx): Update.
1068         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1069         (all_cleanups, do_cleanups, discard_cleanups)
1070         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1071         (restore_cleanups, restore_final_cleanups): Don't declare.
1072         (do_final_cleanups): Remove parameter.
1073         * common/cleanups.c (cleanup_chain, make_cleanup)
1074         (make_cleanup_dtor, all_cleanups, do_cleanups)
1075         (discard_my_cleanups, discard_cleanups)
1076         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1077         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1078         (null_cleanup): Remove.
1079         (do_final_cleanups): Remove parameter.
1080
1081 2019-03-06  Tom Tromey  <tom@tromey.com>
1082
1083         * remote.c (remote_target::remote_parse_stop_reply): Use
1084         unique_xmalloc_ptr.
1085
1086 2019-03-06  Tom Tromey  <tom@tromey.com>
1087
1088         * stabsread.c (struct stabs_field_info): Rename from field_info.
1089         <list, fnlist>: Add initializers.
1090         <obstack>: New member.
1091         (read_member_functions, read_struct_fields, read_baseclasses):
1092         Allocate on obstack.  Don't use cleanups.
1093         (read_one_struct_field, read_member_functions, read_struct_fields)
1094         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1095         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1096         (read_struct_type): Update.
1097
1098 2019-03-06  Tom Tromey  <tom@tromey.com>
1099
1100         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1101         * common/filestuff.h (make_cleanup_close): Don't declare.
1102         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1103         Remove.
1104
1105 2019-03-06  Tom Tromey  <tom@tromey.com>
1106
1107         * solib-aix.c: Use make_scope_exit.
1108
1109 2019-03-06  Tom Tromey  <tom@tromey.com>
1110
1111         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1112         Use make_scope_exit.
1113
1114 2019-03-06  Tom Tromey  <tom@tromey.com>
1115
1116         * solib-svr4.c (disable_probes_interface): Remove parameter.
1117         (svr4_handle_solib_event): Use make_scope_exit.
1118
1119 2019-03-06  Tom Tromey  <tom@tromey.com>
1120
1121         * remote.c (struct stop_reply_deleter): Remove.
1122         (stop_reply_up): Update.
1123         (struct stop_reply): Derive from notif_event.  Don't typedef.
1124         <regcache>: Now a std::vector.
1125         (stop_reply_xfree): Remove.
1126         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1127         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1128         (remote_target::discard_pending_stop_replies): Use delete.
1129         (remote_target::remote_parse_stop_reply): Update.
1130         (remote_target::process_stop_reply): Update.
1131         * remote-notif.h (struct notif_event): Add virtual destructor.
1132         Remove "dtr" member.
1133         (struct notif_client) <alloc_event>: Return a unique_ptr.
1134         (notif_event_xfree): Don't declare.
1135         (notif_event_up): New typedef.
1136         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1137         (notif_event_xfree, do_notif_event_xfree): Remove.
1138         (remote_notif_state_xfree): Update.
1139
1140 2019-03-06  Tom Tromey  <tom@tromey.com>
1141
1142         * infrun.c (displaced_step_clear_cleanup): Now a
1143         forward_scope_exit type.
1144         (displaced_step_prepare_throw): Update.
1145         (displaced_step_fixup): Update.
1146
1147 2019-03-06  Tom Tromey  <tom@tromey.com>
1148
1149         * inferior.h (class inferior): Update comment.
1150         * gdbthread.h (class thread_info): Update comment.
1151
1152 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1153             Tom Tromey  <tom@tromey.com>
1154
1155         * stabsread.h (struct stab_section_list): Remove.
1156         (coffstab_build_psymtabs): Update.
1157         * dbxread.c (symbuf_sections): Now a std::vector.
1158         (sect_idx): New global.
1159         (fill_symbuf): Update.
1160         (coffstab_build_psymtabs): Change type of stabsects parameter.
1161         Update.
1162         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1163         std::vector.
1164         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1165         (coff_locate_sections): Update.
1166         (coff_symfile_read): Remove cleanups.  Update.
1167         (init_stringtab): Add storage parameter.
1168         (free_stringtab, free_stringtab_cleanup): Remove.
1169         (init_lineno): Add storage parameter.
1170         (free_linetab, free_linetab_cleanup): Remove.
1171
1172 2019-03-06  Pedro Alves  <palves@redhat.com>
1173
1174         * linux-fork.c (fork_info::clobber_regs): Delete.
1175         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1176         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1177         comment.  Adjust.
1178         (scoped_switch_fork_info::scoped_switch_fork_info)
1179         (checkpoint_command, linux_fork_context): Adjust
1180         fork_save_infrun_state calls.
1181
1182 2019-03-06  Pedro Alves  <palves@redhat.com>
1183
1184         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1185         (inf_has_multiple_threads): Return 'bool' and rewrite using
1186         inferior_info::threads().
1187
1188 2019-03-06  Pedro Alves  <palves@redhat.com>
1189
1190         * linux-fork.c: Include <list>.
1191         (fork_list): Now a std::list instance.
1192         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1193         (forks_exist_p, find_last_fork): Adjust.
1194         (new_fork): Delete.
1195         (one_fork_p): New.
1196         (add_fork): Adjust.
1197         (free_fork): Delete, folded into fork_info::~fork_info().
1198         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1199         Adjust.
1200         (init_fork_list): Delete.
1201         (linux_fork_killall, linux_fork_mourn_inferior)
1202         (linux_fork_detach, info_checkpoints_command): Adjust.
1203         (_initialize_linux_fork): No longer call init_fork_list.
1204
1205 2019-03-06  Pedro Alves  <palves@redhat.com>
1206
1207         * linux-fork.c (new_fork): New, split out of ...
1208         (add_fork): ... this.  Return void.  Move "first fork" special
1209         case from here, to ...
1210         (checkpoint_command): ... here.
1211         * linux-linux.h (add_fork): Return void.
1212
1213 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1214
1215         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1216
1217 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1218             Chris January  <chris.january@arm.com>
1219             David Lecomber  <david.lecomber@arm.com>
1220
1221         * f-exp.y: New token, UNOP_INTRINSIC.
1222         (exp): New pattern using UNOP_INTRINSIC token.
1223         (f77_keywords): Add 'abs' keyword.
1224         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1225         (value_from_host_double): New function.
1226         (evaluate_subexp_f): Support UNOP_ABS.
1227
1228 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1229
1230         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1231         types.
1232
1233 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1234
1235         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1236         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1237         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1238
1239 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1240
1241         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1242
1243 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1244             Chris January  <chris.january@arm.com>
1245
1246         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1247         * f-exp.y: Define 'KIND' token.
1248         (exp): New pattern for KIND expressions.
1249         (ptype): Handle types with a kind extension.
1250         (direct_abs_decl): Extend to spot kind extensions.
1251         (f77_keywords): Add 'kind' to the list.
1252         (push_kind_type): New function.
1253         (convert_to_kind_type): New function.
1254         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1255         * parse.c (operator_length_standard): Likewise.
1256         * parser-defs.h (enum type_pieces): Add tp_kind.
1257         * std-operator.def: Add UNOP_KIND.
1258
1259 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1260
1261         * f-exp.y (f_parse): Set yydebug.
1262
1263 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1264
1265         * f-lang.c (evaluate_subexp_f): New function.
1266         (exp_descriptor_f): New global.
1267         (f_language_defn): Use exp_descriptor_f instead of
1268         exp_descriptor_standard.
1269
1270 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1271
1272         * f-exp.y (struct token): Add comments.
1273         (dot_ops): Remove uppercase versions and the end marker.
1274         (f77_keywords): Likewise.
1275         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1276         entries in the dot_ops array are case insensitive, and use
1277         strncasecmp to compare strings.  Also some whitespace cleanup in
1278         this area.  Similar for the f77_keywords array, except entries in
1279         this list might be case sensitive.
1280
1281 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1282
1283         * f-exp.y (struct f77_boolean_val): Add comments.
1284         (boolean_values): Remove uppercase versions, and end marker.
1285         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1286         and use strncasecmp to achieve case insensitivity.  Additionally,
1287         perform whitespace cleanup around this code.
1288
1289 2019-03-06  Tom Tromey  <tromey@adacore.com>
1290
1291         * remote-sim.c (gdbsim_target_open): Use result of
1292         gdb_argv::release.
1293
1294 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1295         Dirk Schubert  <dirk.schubert@arm.com>
1296         Chris January  <chris.january@arm.com>
1297
1298         * eval.c (evaluate_subexp_standard): Call Fortran argument
1299         wrapping logic.
1300         * f-lang.c (struct value): A value which can be passed into a
1301         Fortran function call.
1302         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1303         where appropriate.
1304         (struct type): Value ready for a Fortran function call.
1305         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1306         is needed.
1307         * f-lang.h (fortran_argument_convert): Declaration.
1308         (fortran_preserve_arg_pointer): Declaration.
1309         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1310
1311 2019-03-05  Tom Tromey  <tromey@adacore.com>
1312
1313         * python/py-prettyprint.c (print_string_repr): Remove #if.
1314         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1315
1316 2019-03-05  Tom Tromey  <tromey@adacore.com>
1317
1318         * target.c (the_dummy_target): Move later.  Change type to
1319         "dummy_target".
1320         (initialize_targets): Don't initialize the_dummy_target.
1321
1322 2019-03-05  Tom Tromey  <tromey@adacore.com>
1323
1324         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1325         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1326
1327 2019-03-05  Tom Tromey  <tromey@adacore.com>
1328
1329         * windows-nat.c (windows_nat_target::attach)
1330         (windows_nat_target::detach): Don't call gdb_flush.
1331         * valprint.c (generic_val_print, val_print, val_print_string):
1332         Don't call gdb_flush.
1333         * utils.c (defaulted_query): Don't call gdb_flush.
1334         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1335         * target.c (target_announce_detach): Don't call gdb_flush.
1336         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1337         * remote.c (extended_remote_target::attach): Don't call
1338         gdb_flush.
1339         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1340         * printcmd.c (do_examine): Don't call gdb_flush.
1341         (info_display_command): Don't call gdb_flush.
1342         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1343         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1344         * memattr.c (info_mem_command): Don't call gdb_flush.
1345         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1346         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1347         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1348         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1349         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1350         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1351         (gnu_nat_target::detach): Don't call gdb_flush.
1352         * f-valprint.c (f_val_print): Don't call gdb_flush.
1353         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1354         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1355         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1356         gdb_flush.
1357         * c-valprint.c (c_val_print): Don't call gdb_flush.
1358         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1359
1360 2019-03-05  Tom Tromey  <tromey@adacore.com>
1361
1362         * varobj.c (update_dynamic_varobj_children): Update.
1363         (install_default_visualizer): Use reset, not release.
1364         * value.c (set_internalvar): Update.
1365         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1366         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1367         ATTRIBUTE_UNUSED_RESULT.
1368
1369 2019-03-05  Tom Tromey  <tromey@adacore.com>
1370
1371         * remote.c (class scoped_remote_fd) <release>: Add
1372         ATTRIBUTE_UNUSED_RESULT.
1373
1374 2019-03-05  Tom Tromey  <tromey@adacore.com>
1375
1376         * macroexp.c (struct macro_buffer) <release>: Add
1377         ATTRIBUTE_UNUSED_RESULT.
1378
1379 2019-03-05  Tom Tromey  <tromey@adacore.com>
1380
1381         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1382         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1383         ATTRIBUTE_UNUSED_RESULT.
1384
1385 2019-03-05  Tom Tromey  <tromey@adacore.com>
1386
1387         * common/scoped_fd.h (class scoped_fd) <release>: Add
1388         ATTRIBUTE_UNUSED_RESULT.
1389
1390 2019-03-05  Tom Tromey  <tromey@adacore.com>
1391
1392         * parser-defs.h (struct parser_state) <release>: Add
1393         ATTRIBUTE_UNUSED_RESULT.
1394
1395 2019-03-05  Tom Tromey  <tromey@adacore.com>
1396
1397         * utils.h (class gdb_argv) <release>: Add
1398         ATTRIBUTE_UNUSED_RESULT.
1399         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1400
1401 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1402
1403         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1404         for-loop range, to avoid compiler warnings.
1405
1406         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1407         avoid compiler warnings about unused variables.
1408
1409         * NEWS: Mention end of support for native debugging on MS-Windows
1410         before XP.
1411
1412         PR gdb/24292
1413         * common/netstuff.c:
1414         * gdbserver/gdbreplay.c
1415         * gdbserver/remote-utils.c:
1416         * ser-tcp.c:
1417         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1418         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1419         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1420         'getaddrinfo' and 'freeaddrinfo' were not available before
1421         Windows XP, and mingw.org's MinGW headers by default define
1422         _WIN32_WINNT to 0x500.
1423
1424 2019-03-01  Gary Benson <gbenson@redhat.com>
1425
1426         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1427
1428 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1429             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1430
1431         PR gdb/8527
1432         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1433         set_sigint_trap, clear_sigint_trap.
1434
1435 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1436
1437         * target.c (target_detach): Clear the regcache and the
1438         frame cache.
1439
1440 2019-02-27  Pedro Alves  <palves@redhat.com>
1441
1442         * utils.c (set_screen_size): When we cap the height/width sizes,
1443         tweak the corresponding command variable to show "unlimited":
1444
1445 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1446             Pedro Alves  <palves@redhat.com>
1447
1448         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1449         before calling rl_set_screen_size.
1450
1451 2019-02-27  Tom Tromey  <tromey@adacore.com>
1452
1453         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1454         define.
1455         * python/py-value.c: Remove Python 2.4 workaround.
1456         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1457         workaround.
1458         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1459         Python 2.4 workaround.
1460         * python/python-internal.h: Remove Python 2.4 comment.
1461         (Py_ssize_t): Don't define.
1462         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1463         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1464         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1465         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1466         * python/python.c (do_start_initialization): Remove Python 2.4
1467         workaround.
1468         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1469         (print_children): Remove Python 2.4 workaround.
1470         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1471         workaround.
1472         (CHARBUFFERPROC_NAME): Remove.
1473         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1474         Python 2.4 workaround.
1475
1476 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1477
1478         * NEWS: Note minimum Python version.
1479
1480 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1481
1482         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1483         code from these functions.  Remove corresponding ifdefs.  Use
1484         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1485         Remove gotos and target of gotos.
1486         (infpy_search_memory): Likewise.
1487
1488 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1489
1490         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1491         (hppa_gdbarch_init): Don't register deleted functions with
1492         gdbarch.
1493
1494 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1495
1496         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1497         (h8300_unwind_sp): Delete.
1498         (h8300_dummy_id): Delete.
1499         (h8300_gdbarch_init): Don't register deleted functions with
1500         gdbarch.
1501
1502 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1503
1504         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1505         (ft32_unwind_pc): Delete.
1506         (ft32_unwind_sp): Delete.
1507         (ft32_gdbarch_init): Don't register deleted functions with
1508         gdbarch.
1509
1510 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1511
1512         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1513         (frv_unwind_pc): Delete.
1514         (frv_unwind_sp): Delete.
1515         (frv_gdbarch_init): Don't register deleted functions with
1516         gdbarch.
1517
1518 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1519
1520         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1521         (riscv_unwind_pc): Delete.
1522         (riscv_unwind_sp): Delete.
1523         (riscv_gdbarch_init): Don't register deleted functions with
1524         gdbarch.
1525
1526 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1527
1528         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1529         (csky_unwind_pc): Delete.
1530         (csky_unwind_sp): Delete.
1531         (csky_gdbarch_init): Don't register deleted functions with
1532         gdbarch.
1533
1534 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1535
1536         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1537         (cris_unwind_pc): Delete.
1538         (cris_unwind_sp): Delete.
1539         (cris_gdbarch_init): Don't register deleted functions with
1540         gdbarch.
1541
1542 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1543
1544         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1545         (bfin_unwind_pc): Delete.
1546         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1547
1548 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1549
1550         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1551         (arm_unwind_pc): Delete.
1552         (arm_unwind_sp): Delete.
1553         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1554
1555 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1556
1557         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1558         (arc_unwind_pc): Delete.
1559         (arc_unwind_sp): Delete.
1560         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1561
1562 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1563
1564         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1565         (alpha_unwind_pc): Delete.
1566         (alpha_gdbarch_init): Don't register deleted functions with
1567         gdbarch.
1568
1569 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1570
1571         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1572         (aarch64_unwind_pc): Delete.
1573         (aarch64_unwind_sp): Delete.
1574         (aarch64_gdbarch_init): Don't register deleted functions with
1575         gdbarch.
1576
1577 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1578
1579         * gdbtypes.c (type_align): Don't consider static members when
1580         computing structure alignment.
1581
1582 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1583
1584         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1585         return 0 for other types.
1586         * arch-utils.c (default_type_align): Always return 0.
1587         * gdbarch.h: Regenerate.
1588         * gdbarch.sh (type_align): Extend comment.
1589         * gdbtypes.c (type_align): Add additional comments, always call
1590         gdbarch_type_align before applying the default rules.
1591         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1592         generic code will then apply a suitable default.
1593         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1594         types, return 0 for other types.
1595
1596 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1597
1598         * NEWS: Create a new section for the next release branch.
1599         Rename the section of the current branch, now that it has
1600         been cut.
1601
1602 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1603
1604         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1605         * version.in: Bump version to 8.3.50.DATE-git.
1606
1607 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1608
1609         * aix-thread.c (ptid_cmp): Remove unused variable.
1610         (get_signaled_thread): Likewise.
1611         (store_regs_user_thread): Likewise.
1612         (store_regs_kernel_thread): Likewise.
1613         (fetch_regs_kernel_thread): Remove shadowed variable.
1614
1615 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1616
1617         * features/riscv/32bit-cpu.xml: Add register numbers.
1618         * features/riscv/32bit-fpu.c: Regenerate.
1619         * features/riscv/32bit-fpu.xml: Add register numbers.
1620         * features/riscv/64bit-cpu.xml: Add register numbers.
1621         * features/riscv/64bit-fpu.c: Regenerate.
1622         * features/riscv/64bit-fpu.xml: Add register numbers.
1623
1624 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1625
1626         * NEWS: Mention two argument form of gdb.Value constructor.
1627         * python/py-value.c (convert_buffer_and_type_to_value): New
1628         function.
1629         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1630         Add support for handling an optional second argument.  Call
1631         convert_buffer_and_type_to_value as appropriate.
1632         * python/python-internal.h (Py_buffer_deleter): New struct.
1633         (Py_buffer_up): New typedef.
1634
1635 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1636
1637         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1638         instead of releasing ownership.
1639
1640 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1641
1642         * dwarf2read.c (open_and_init_dwp_file): Call
1643         elf_numsections instead of bfd_count_sections to initialize
1644         dwp_file->num_sections.
1645
1646 2019-02-25  Tom Tromey  <tromey@adacore.com>
1647
1648         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1649
1650 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1651
1652         * gcore.in: Add '--readnever' option when invoking GDB.
1653
1654 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1655
1656         * MAINTAINERS: Update my email address.
1657
1658 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1659
1660         * build-id.c (build_id_to_debug_bfd_1): New function.
1661         (build_id_to_debug_bfd): Look for separate debug file in
1662         sysroot.
1663
1664 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1665
1666         * gdbarch.sh: Update the copyright year range that is placed into
1667         generated files.
1668
1669 2019-02-22  Keith Seitz  <keiths@redhat.com>
1670
1671         PR symtab/23853
1672         * linespec.c (create_sals_line_offset): Search for the default
1673         symtab's filename instead of its fullname.
1674
1675 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1676
1677         * NEWS: Update style defaults.
1678
1679 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1680
1681         * main.c (captured_main_1): Disable styling in batch mode.
1682
1683 2019-02-20  Tom Tromey  <tom@tromey.com>
1684
1685         * symtab.c (symtab_symbol_info): Fix typos.
1686
1687 2019-02-20  Tom Tromey  <tromey@adacore.com>
1688
1689         * findcmd.c (_initialize_mem_search): Use upper case for
1690         metasyntactic variables.
1691
1692 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1693
1694         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1695         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1696
1697 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1698
1699         * top.h (source_file_name): Change to std::string.
1700         * top.c (source_file_name): Likewise.
1701         (command_line_input): Adjust.
1702         * cli/cli-script.c (script_from_file): Adjust.
1703
1704 2019-02-19  Tom Tromey  <tromey@adacore.com>
1705
1706         * ravenscar-thread.c
1707         (ravenscar_thread_target::update_thread_list): Don't call
1708         ada_build_task_list.
1709         * ada-lang.h (ada_build_task_list): Don't declare.
1710         * ada-tasks.c (struct ada_tasks_inferior_data)
1711         <task_list_valid_p>: Now bool.
1712         (read_known_tasks, ada_task_list_changed)
1713         (ada_tasks_invalidate_inferior_data): Update.
1714         (read_known_tasks_array): Return bool.
1715         (read_known_tasks_list): Likewise.
1716         (read_known_tasks): Return void.
1717         (ada_build_task_list): Now static.
1718
1719 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1720
1721         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1722         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1723
1724 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1725
1726         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1727         variant for ada_tasks_pspace_data_handle and
1728         ada_tasks_inferior_data_handle.
1729         (ada_tasks_pspace_data_cleanup): New function.
1730         (ada_tasks_inferior_data_cleanup): New function.
1731
1732 2019-02-17  Tom Tromey  <tom@tromey.com>
1733
1734         * macrotab.h (macro_source_fullname): Return a std::string.
1735         * macrotab.c (macro_include, check_for_redefinition)
1736         (macro_undef, macro_lookup_definition, foreach_macro)
1737         (foreach_macro_in_scope): Update.
1738         (macro_source_fullname): Return a std::string.
1739         * macrocmd.c (show_pp_source_pos): Update.
1740
1741 2019-02-17  Tom Tromey  <tom@tromey.com>
1742
1743         * macrocmd.c (show_pp_source_pos): Style the file names.
1744
1745 2019-02-17  Tom Tromey  <tom@tromey.com>
1746
1747         PR tui/24197:
1748         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1749
1750 2019-02-17  Tom Tromey  <tom@tromey.com>
1751
1752         * ada-lang.c (user_select_syms): Use filtered printing.
1753         * utils.c (wrap_style): New global.
1754         (desired_style): Remove.
1755         (emit_style_escape): Add stream parameter.
1756         (set_output_style, reset_terminal_style, prompt_for_continue):
1757         Update.
1758         (flush_wrap_buffer): Only flush gdb_stdout.
1759         (wrap_here): Set wrap_style.
1760         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1761         treat escape sequences as a character.  Change when wrap buffer is
1762         flushed.
1763         (fputs_styled): Do not set the output style when the default is
1764         requested.
1765         * ui-style.h (struct ui_file_style) <is_default>: New method.
1766         * source.c (print_source_lines_base): Emit escape sequences in one
1767         piece.
1768
1769 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1770
1771         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1772         integers and enumeration types.
1773
1774 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1775
1776         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1777         instead of lookup_symbol_in_language
1778         (do_exact_match): New function.
1779         (ada_get_symbol_name_matcher): Return do_exact_match when
1780         doing a verbatim match.
1781
1782 2019-02-15  Tom Tromey  <tromey@adacore.com>
1783
1784         * ravenscar-thread.c (ravenscar_thread_target::resume)
1785         (ravenscar_thread_target::wait): Special case wildcard requests.
1786
1787 2019-02-15  Tom Tromey  <tromey@adacore.com>
1788
1789         * ravenscar-thread.c (base_ptid): Remove.
1790         (struct ravenscar_thread_target) <close>: New method.
1791         <m_base_ptid>: New member.
1792         <update_inferior_ptid, active_task, task_is_currently_active,
1793         runtime_initialized>: Declare methods.
1794         <ravenscar_thread_target>: Add constructor.
1795         (ravenscar_thread_target::task_is_currently_active)
1796         (ravenscar_thread_target::update_inferior_ptid)
1797         (ravenscar_runtime_initialized): Rename.  Now methods.
1798         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1799         (ravenscar_thread_target::update_thread_list): Update.
1800         (ravenscar_thread_target::active_task): Now method.
1801         (ravenscar_thread_target::store_registers)
1802         (ravenscar_thread_target::prepare_to_store)
1803         (ravenscar_thread_target::prepare_to_store)
1804         (ravenscar_thread_target::mourn_inferior): Update.
1805         (ravenscar_inferior_created): Use "new" to create target.
1806         (ravenscar_thread_target::get_ada_task_ptid): Update.
1807         (_initialize_ravenscar): Don't initialize base_ptid.
1808         (ravenscar_ops): Remove global.
1809
1810 2019-02-15  Tom Tromey  <tromey@adacore.com>
1811
1812         * target.h (push_target): Declare new overload.
1813         * target.c (push_target): New overload, taking an rvalue reference.
1814         * remote.c (remote_target::open_1): Use push_target overload.
1815         * corelow.c (core_target_open): Use push_target overload.
1816
1817 2019-02-15  Tom Tromey  <tromey@adacore.com>
1818
1819         * ravenscar-thread.c (is_ravenscar_task)
1820         (ravenscar_task_is_currently_active): Return bool.
1821         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1822         (_initialize_ravenscar): Remove "(void)".
1823         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1824         Return bool.
1825
1826 2019-02-15  Tom Tromey  <tromey@adacore.com>
1827
1828         * ravenscar-thread.c (ravenscar_runtime_initializer)
1829         (has_ravenscar_runtime, get_running_thread_id)
1830         (ravenscar_thread_target::resume): Fix indentation.
1831
1832 2019-02-15  Tom Tromey  <tromey@adacore.com>
1833
1834         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1835         from ravenscar_arch_ops.
1836         (sparc_ravenscar_ops::fetch_registers)
1837         (sparc_ravenscar_ops::store_registers): Now methods.
1838         (sparc_ravenscar_prepare_to_store): Remove.
1839         (sparc_ravenscar_ops): Redefine.
1840         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1841         methods and destructor.  Remove members.
1842         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1843         (ravenscar_thread_target::store_registers)
1844         (ravenscar_thread_target::prepare_to_store): Update.
1845         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1846         Remove.
1847         (struct ppc_ravenscar_powerpc_ops): Derive from
1848         ravenscar_arch_ops.
1849         (ppc_ravenscar_powerpc_ops::fetch_registers)
1850         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1851         (ppc_ravenscar_powerpc_ops): Redefine.
1852         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1853         (ppc_ravenscar_e500_ops::fetch_registers)
1854         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1855         (ppc_ravenscar_e500_ops): Redefine.
1856         * aarch64-ravenscar-thread.c
1857         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1858         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1859         (aarch64_ravenscar_fetch_registers)
1860         (aarch64_ravenscar_store_registers): Now methods.
1861         (aarch64_ravenscar_ops): Redefine.
1862
1863 2019-02-15  Tom Tromey  <tromey@adacore.com>
1864
1865         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1866         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1867         (ravenscar_thread_target::stopped_by_watchpoint)
1868         (ravenscar_thread_target::stopped_data_address)
1869         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1870
1871 2019-02-15  Tom Tromey  <tromey@adacore.com>
1872
1873         * ravenscar-thread.c: Fix some typos.
1874
1875 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1876             Tom Tromey  <tromey@adacore.com>
1877
1878         * ada-lang.c (ada_exception_sal): Change addr_string to a
1879         std::string.
1880         (create_ada_exception_catchpoint): Update.
1881
1882 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1883             Tom Tromey  <tromey@adacore.com>
1884
1885         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1886         (bp_location_ops): Remove.
1887         (base_breakpoint_allocate_location): Update.
1888         (free_bp_location): Update.
1889         * ada-lang.c (class ada_catchpoint_location)
1890         <ada_catchpoint_location>: Remove ops parameter.
1891         (ada_catchpoint_location_dtor): Remove.
1892         (ada_catchpoint_location_ops): Remove.
1893         (allocate_location_exception): Update.
1894         * breakpoint.h (struct bp_location_ops): Remove.
1895         (class bp_location) <bp_location>: Remove bp_location_ops
1896         parameter.
1897         <~bp_location>: Add destructor.
1898         <ops>: Remove.
1899
1900 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1901             Pedro Alves  <palves@redhat.com>
1902
1903         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1904         'PATH_MAX'.
1905
1906 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1907             Samuel Thibault  <samuel.thibault@gnu.org>
1908             Thomas Schwinge  <thomas@codesourcery.com>
1909
1910         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1911         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1912
1913 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1914
1915         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1916         (check_empty): Use "const char *".
1917
1918         * gnu-nat.c (gnu_nat_target::detach): Instead of
1919         'detach_inferior (pid)' call
1920         'detach_inferior (find_inferior_pid (pid))'.
1921
1922         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1923         'nat/fork-inferior.o'.
1924         * gnu-nat.c: #include "nat/fork-inferior.h".
1925
1926         * gnu-nat.c (gnu_nat_target::detach): Instead of
1927         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1928         * gnu-nat.h: #include "inf-child.h".
1929         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1930         'i386_gnu_nat_target::fetch_registers'.
1931         (gnu_store_registers): Rename/move to
1932         'i386_gnu_nat_target::store_registers'.
1933
1934         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1935         * gnu-nat.h (mach_thread_info): New function.
1936         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1937
1938         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1939
1940 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1941
1942         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1943
1944 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1945
1946         * windows-nat.c (windows_add_thread): Add new parameter
1947         "main_thread_p" with default value set to false.  Update
1948         function documentation as well as all callers.
1949         (windows_delete_thread): Likewise.
1950         (fake_create_process): Update call to windows_add_thread.
1951         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1952         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1953         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1954         call to windows_delete_thread.
1955
1956 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1957
1958         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1959
1960 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1961
1962         * symfile.c (find_separate_debug_file): Use canonical path of
1963         sysroot with child_path instead of gdb_sysroot if it is valid.
1964
1965 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1966
1967         * symfile.c (find_separate_debug_file): Use child_path to
1968         determine if an object file is under a sysroot.
1969
1970 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1971
1972         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1973         unittests/child-path-selftests.c.
1974         * common/pathstuff.c (child_path): New function.
1975         * common/pathstuff.h (child_path): New prototype.
1976         * unittests/child-path-selftests.c: New file.
1977
1978 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1979
1980         * symfile.c (find_separate_debug_file): Look for separate debug
1981         files in debug directories under the sysroot.
1982
1983 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1984
1985         * symtab.h (struct minimal_symbol data_p): New const method.
1986         (struct minimal_symbol text_p): Likewise.
1987         * symtab.c (output_source_filename): Use file name style
1988         to print file name.
1989         (print_symbol_info): Likewise.
1990         (print_msymbol_info): Use address style to print addresses.
1991         Use function name style to print executable text symbols.
1992         (expand_symtab_containing_pc): Use data_p.
1993         (find_pc_sect_compunit_symtab): Likewise.
1994
1995 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1996
1997         * breakpoint.c (describe_other_breakpoints): Use address style
1998         to print addresses.
1999         (say_where): Likewise.
2000
2001 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2002
2003         * ada-typeprint.c (print_func_type): Print function name
2004         style to print function name.
2005         * c-typeprint.c (c_print_type_1): Likewise.
2006
2007 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2008
2009         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2010         for execve.
2011
2012 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2013
2014         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2015         type_stack.
2016
2017 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2018
2019         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2020         TYPE_CODE_REF types.
2021
2022 2019-02-08  Jim Wilson  <jimw@sifive.com>
2023
2024         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2025         (riscv_linux_fregset): New.
2026         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2027
2028 2019-02-07  Tom Tromey  <tom@tromey.com>
2029
2030         * thread.c (thread_cancel_execution_command): Update.
2031         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2032         methods.
2033         (struct thread_fsm_ops): Remove.
2034         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2035         (thread_fsm_should_stop, thread_fsm_return_value)
2036         (thread_fsm_set_finished, thread_fsm_finished_p)
2037         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2038         Don't declare.
2039         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2040         * infrun.c (clear_proceed_status_thread)
2041         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2042         (print_stop_event): Update.
2043         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2044         Add constructor.
2045         (step_command_fsm_ops): Remove.
2046         (new_step_command_fsm): Remove.
2047         (step_1): Update.
2048         (step_command_fsm::should_stop): Rename from
2049         step_command_fsm_should_stop.
2050         (step_command_fsm::clean_up): Rename from
2051         step_command_fsm_clean_up.
2052         (step_command_fsm::do_async_reply_reason): Rename from
2053         step_command_fsm_async_reply_reason.
2054         (struct until_next_fsm): Inherit from thread_fsm.  Add
2055         constructor.
2056         (until_next_fsm_ops): Remove.
2057         (new_until_next_fsm): Remove.
2058         (until_next_fsm::should_stop): Rename from
2059         until_next_fsm_should_stop.
2060         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2061         (until_next_fsm::do_async_reply_reason): Rename from
2062         until_next_fsm_async_reply_reason.
2063         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2064         constructor.  Change type of breakpoint.
2065         (finish_command_fsm_ops): Remove.
2066         (new_finish_command_fsm): Remove.
2067         (finish_command_fsm::should_stop): Rename from
2068         finish_command_fsm_should_stop.
2069         (finish_command_fsm::clean_up): Rename from
2070         finish_command_fsm_clean_up.
2071         (finish_command_fsm::return_value): Rename from
2072         finish_command_fsm_return_value.
2073         (finish_command_fsm::do_async_reply_reason): Rename from
2074         finish_command_fsm_async_reply_reason.
2075         (finish_command): Update.
2076         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2077         Add constructor.
2078         (call_thread_fsm_ops): Remove.
2079         (call_thread_fsm::call_thread_fsm): Rename from
2080         new_call_thread_fsm.
2081         (call_thread_fsm::should_stop): Rename from
2082         call_thread_fsm_should_stop.
2083         (call_thread_fsm::should_notify_stop): Rename from
2084         call_thread_fsm_should_notify_stop.
2085         (run_inferior_call, call_function_by_hand_dummy): Update.
2086         * cli/cli-interp.c (should_print_stop_to_console): Update.
2087         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2088         Add constructor.  Change type of location_breakpoint,
2089         caller_breakpoint.
2090         (until_break_fsm_ops): Remove.
2091         (new_until_break_fsm): Remove.
2092         (until_break_fsm::should_stop): Rename from
2093         until_break_fsm_should_stop.
2094         (until_break_fsm::clean_up): Rename from
2095         until_break_fsm_clean_up.
2096         (until_break_fsm::do_async_reply_reason): Rename from
2097         until_break_fsm_async_reply_reason.
2098         (until_break_command): Update.
2099         * thread-fsm.c: Remove.
2100         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2101
2102 2019-02-07  Tom Tromey  <tom@tromey.com>
2103
2104         * yy-remap.h: Add include guard.
2105         * xtensa-tdep.h: Add include guard.
2106         * xcoffread.h: Rename include guard.
2107         * varobj-iter.h: Add include guard.
2108         * tui/tui.h: Rename include guard.
2109         * tui/tui-winsource.h: Rename include guard.
2110         * tui/tui-wingeneral.h: Rename include guard.
2111         * tui/tui-windata.h: Rename include guard.
2112         * tui/tui-win.h: Rename include guard.
2113         * tui/tui-stack.h: Rename include guard.
2114         * tui/tui-source.h: Rename include guard.
2115         * tui/tui-regs.h: Rename include guard.
2116         * tui/tui-out.h: Rename include guard.
2117         * tui/tui-layout.h: Rename include guard.
2118         * tui/tui-io.h: Rename include guard.
2119         * tui/tui-hooks.h: Rename include guard.
2120         * tui/tui-file.h: Rename include guard.
2121         * tui/tui-disasm.h: Rename include guard.
2122         * tui/tui-data.h: Rename include guard.
2123         * tui/tui-command.h: Rename include guard.
2124         * tic6x-tdep.h: Add include guard.
2125         * target/waitstatus.h: Rename include guard.
2126         * target/wait.h: Rename include guard.
2127         * target/target.h: Rename include guard.
2128         * target/resume.h: Rename include guard.
2129         * target-float.h: Rename include guard.
2130         * stabsread.h: Add include guard.
2131         * rs6000-tdep.h: Add include guard.
2132         * riscv-fbsd-tdep.h: Add include guard.
2133         * regformats/regdef.h: Rename include guard.
2134         * record.h: Rename include guard.
2135         * python/python.h: Rename include guard.
2136         * python/python-internal.h: Rename include guard.
2137         * python/py-stopevent.h: Rename include guard.
2138         * python/py-ref.h: Rename include guard.
2139         * python/py-record.h: Rename include guard.
2140         * python/py-record-full.h: Rename include guard.
2141         * python/py-record-btrace.h: Rename include guard.
2142         * python/py-instruction.h: Rename include guard.
2143         * python/py-events.h: Rename include guard.
2144         * python/py-event.h: Rename include guard.
2145         * procfs.h: Add include guard.
2146         * proc-utils.h: Add include guard.
2147         * p-lang.h: Add include guard.
2148         * or1k-tdep.h: Rename include guard.
2149         * observable.h: Rename include guard.
2150         * nto-tdep.h: Rename include guard.
2151         * nat/x86-linux.h: Rename include guard.
2152         * nat/x86-linux-dregs.h: Rename include guard.
2153         * nat/x86-gcc-cpuid.h: Add include guard.
2154         * nat/x86-dregs.h: Rename include guard.
2155         * nat/x86-cpuid.h: Rename include guard.
2156         * nat/ppc-linux.h: Rename include guard.
2157         * nat/mips-linux-watch.h: Rename include guard.
2158         * nat/linux-waitpid.h: Rename include guard.
2159         * nat/linux-ptrace.h: Rename include guard.
2160         * nat/linux-procfs.h: Rename include guard.
2161         * nat/linux-osdata.h: Rename include guard.
2162         * nat/linux-nat.h: Rename include guard.
2163         * nat/linux-namespaces.h: Rename include guard.
2164         * nat/linux-btrace.h: Rename include guard.
2165         * nat/glibc_thread_db.h: Rename include guard.
2166         * nat/gdb_thread_db.h: Rename include guard.
2167         * nat/gdb_ptrace.h: Rename include guard.
2168         * nat/fork-inferior.h: Rename include guard.
2169         * nat/amd64-linux-siginfo.h: Rename include guard.
2170         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2171         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2172         * nat/aarch64-linux.h: Rename include guard.
2173         * nat/aarch64-linux-hw-point.h: Rename include guard.
2174         * mn10300-tdep.h: Add include guard.
2175         * mips-linux-tdep.h: Add include guard.
2176         * mi/mi-parse.h: Rename include guard.
2177         * mi/mi-out.h: Rename include guard.
2178         * mi/mi-main.h: Rename include guard.
2179         * mi/mi-interp.h: Rename include guard.
2180         * mi/mi-getopt.h: Rename include guard.
2181         * mi/mi-console.h: Rename include guard.
2182         * mi/mi-common.h: Rename include guard.
2183         * mi/mi-cmds.h: Rename include guard.
2184         * mi/mi-cmd-break.h: Rename include guard.
2185         * m2-lang.h: Add include guard.
2186         * location.h: Rename include guard.
2187         * linux-record.h: Rename include guard.
2188         * linux-nat.h: Add include guard.
2189         * linux-fork.h: Add include guard.
2190         * i386-darwin-tdep.h: Rename include guard.
2191         * hppa-linux-offsets.h: Add include guard.
2192         * guile/guile.h: Rename include guard.
2193         * guile/guile-internal.h: Rename include guard.
2194         * gnu-nat.h: Rename include guard.
2195         * gdb-stabs.h: Rename include guard.
2196         * frv-tdep.h: Add include guard.
2197         * f-lang.h: Add include guard.
2198         * event-loop.h: Add include guard.
2199         * darwin-nat.h: Rename include guard.
2200         * cp-abi.h: Rename include guard.
2201         * config/sparc/nm-sol2.h: Rename include guard.
2202         * config/nm-nto.h: Rename include guard.
2203         * config/nm-linux.h: Add include guard.
2204         * config/i386/nm-i386gnu.h: Rename include guard.
2205         * config/djgpp/nl_types.h: Rename include guard.
2206         * config/djgpp/langinfo.h: Rename include guard.
2207         * compile/gcc-cp-plugin.h: Add include guard.
2208         * compile/gcc-c-plugin.h: Add include guard.
2209         * compile/compile.h: Rename include guard.
2210         * compile/compile-object-run.h: Rename include guard.
2211         * compile/compile-object-load.h: Rename include guard.
2212         * compile/compile-internal.h: Rename include guard.
2213         * compile/compile-cplus.h: Rename include guard.
2214         * compile/compile-c.h: Rename include guard.
2215         * common/xml-utils.h: Rename include guard.
2216         * common/x86-xstate.h: Rename include guard.
2217         * common/version.h: Rename include guard.
2218         * common/vec.h: Rename include guard.
2219         * common/tdesc.h: Rename include guard.
2220         * common/selftest.h: Rename include guard.
2221         * common/scoped_restore.h: Rename include guard.
2222         * common/scoped_mmap.h: Rename include guard.
2223         * common/scoped_fd.h: Rename include guard.
2224         * common/safe-iterator.h: Rename include guard.
2225         * common/run-time-clock.h: Rename include guard.
2226         * common/refcounted-object.h: Rename include guard.
2227         * common/queue.h: Rename include guard.
2228         * common/ptid.h: Rename include guard.
2229         * common/print-utils.h: Rename include guard.
2230         * common/preprocessor.h: Rename include guard.
2231         * common/pathstuff.h: Rename include guard.
2232         * common/observable.h: Rename include guard.
2233         * common/netstuff.h: Rename include guard.
2234         * common/job-control.h: Rename include guard.
2235         * common/host-defs.h: Rename include guard.
2236         * common/gdb_wait.h: Rename include guard.
2237         * common/gdb_vecs.h: Rename include guard.
2238         * common/gdb_unlinker.h: Rename include guard.
2239         * common/gdb_unique_ptr.h: Rename include guard.
2240         * common/gdb_tilde_expand.h: Rename include guard.
2241         * common/gdb_sys_time.h: Rename include guard.
2242         * common/gdb_string_view.h: Rename include guard.
2243         * common/gdb_splay_tree.h: Rename include guard.
2244         * common/gdb_setjmp.h: Rename include guard.
2245         * common/gdb_ref_ptr.h: Rename include guard.
2246         * common/gdb_optional.h: Rename include guard.
2247         * common/gdb_locale.h: Rename include guard.
2248         * common/gdb_assert.h: Rename include guard.
2249         * common/filtered-iterator.h: Rename include guard.
2250         * common/filestuff.h: Rename include guard.
2251         * common/fileio.h: Rename include guard.
2252         * common/environ.h: Rename include guard.
2253         * common/common-utils.h: Rename include guard.
2254         * common/common-types.h: Rename include guard.
2255         * common/common-regcache.h: Rename include guard.
2256         * common/common-inferior.h: Rename include guard.
2257         * common/common-gdbthread.h: Rename include guard.
2258         * common/common-exceptions.h: Rename include guard.
2259         * common/common-defs.h: Rename include guard.
2260         * common/common-debug.h: Rename include guard.
2261         * common/cleanups.h: Rename include guard.
2262         * common/buffer.h: Rename include guard.
2263         * common/btrace-common.h: Rename include guard.
2264         * common/break-common.h: Rename include guard.
2265         * cli/cli-utils.h: Rename include guard.
2266         * cli/cli-style.h: Rename include guard.
2267         * cli/cli-setshow.h: Rename include guard.
2268         * cli/cli-script.h: Rename include guard.
2269         * cli/cli-interp.h: Rename include guard.
2270         * cli/cli-decode.h: Rename include guard.
2271         * cli/cli-cmds.h: Rename include guard.
2272         * charset-list.h: Add include guard.
2273         * buildsym-legacy.h: Rename include guard.
2274         * bfin-tdep.h: Add include guard.
2275         * ax.h: Rename include guard.
2276         * arm-linux-tdep.h: Add include guard.
2277         * arm-fbsd-tdep.h: Add include guard.
2278         * arch/xtensa.h: Rename include guard.
2279         * arch/tic6x.h: Add include guard.
2280         * arch/i386.h: Add include guard.
2281         * arch/arm.h: Rename include guard.
2282         * arch/arm-linux.h: Rename include guard.
2283         * arch/arm-get-next-pcs.h: Rename include guard.
2284         * arch/amd64.h: Add include guard.
2285         * arch/aarch64-insn.h: Rename include guard.
2286         * arch-utils.h: Rename include guard.
2287         * annotate.h: Add include guard.
2288         * amd64-darwin-tdep.h: Rename include guard.
2289         * aarch64-linux-tdep.h: Add include guard.
2290         * aarch64-fbsd-tdep.h: Add include guard.
2291         * aarch32-linux-nat.h: Add include guard.
2292
2293 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2294
2295         * macrotab.c (macro_define_internal): New function that
2296         factorizes macro_define_object_internal and macro_define_function
2297         code.
2298         (macro_define_object_internal): Use macro_define_internal.
2299         (macro_define_function): Likewise.
2300
2301 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2302
2303         * macrocmd.c (extract_identifier): Return
2304         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2305         callers.
2306
2307 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2308
2309         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2310
2311 2019-02-05  Tom Tromey  <tom@tromey.com>
2312
2313         * target.c (target_stack::unpush): Move assertion earlier.
2314
2315 2019-01-30  Tom Tromey  <tom@tromey.com>
2316
2317         PR python/23615:
2318         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2319         (gdbpy_parse_and_eval): Likewise.
2320         * python/python-internal.h (gdbpy_allow_threads): New class.
2321
2322 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2323
2324         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2325         (aarch64_fbsd_fpregmap): Move earlier.
2326         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2327         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2328         instead of individual calls to trad_frame_set_reg_addr.
2329         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2330         earlier.
2331         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2332         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2333         instead of individual calls to trad_frame_set_reg_addr.
2334
2335 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2336
2337         * CONTRIBUTE: Replace contribution list with wiki link.
2338
2339 2019-01-25  Tom Tromey  <tom@tromey.com>
2340
2341         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2342
2343 2019-01-25  Tom Tromey  <tom@tromey.com>
2344
2345         * xtensa-linux-nat.c: Fix common/ includes.
2346         * xml-support.h: Fix common/ includes.
2347         * xml-support.c: Fix common/ includes.
2348         * x86-linux-nat.c: Fix common/ includes.
2349         * windows-nat.c: Fix common/ includes.
2350         * varobj.h: Fix common/ includes.
2351         * varobj.c: Fix common/ includes.
2352         * value.c: Fix common/ includes.
2353         * valops.c: Fix common/ includes.
2354         * utils.c: Fix common/ includes.
2355         * unittests/xml-utils-selftests.c: Fix common/ includes.
2356         * unittests/utils-selftests.c: Fix common/ includes.
2357         * unittests/unpack-selftests.c: Fix common/ includes.
2358         * unittests/tracepoint-selftests.c: Fix common/ includes.
2359         * unittests/style-selftests.c: Fix common/ includes.
2360         * unittests/string_view-selftests.c: Fix common/ includes.
2361         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2362         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2363         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2364         * unittests/rsp-low-selftests.c: Fix common/ includes.
2365         * unittests/parse-connection-spec-selftests.c: Fix common/
2366         includes.
2367         * unittests/optional-selftests.c: Fix common/ includes.
2368         * unittests/offset-type-selftests.c: Fix common/ includes.
2369         * unittests/observable-selftests.c: Fix common/ includes.
2370         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2371         * unittests/memrange-selftests.c: Fix common/ includes.
2372         * unittests/memory-map-selftests.c: Fix common/ includes.
2373         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2374         * unittests/function-view-selftests.c: Fix common/ includes.
2375         * unittests/environ-selftests.c: Fix common/ includes.
2376         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2377         * unittests/common-utils-selftests.c: Fix common/ includes.
2378         * unittests/cli-utils-selftests.c: Fix common/ includes.
2379         * unittests/array-view-selftests.c: Fix common/ includes.
2380         * ui-file.c: Fix common/ includes.
2381         * tui/tui-io.c: Fix common/ includes.
2382         * tracepoint.h: Fix common/ includes.
2383         * tracepoint.c: Fix common/ includes.
2384         * tracefile-tfile.c: Fix common/ includes.
2385         * top.h: Fix common/ includes.
2386         * top.c: Fix common/ includes.
2387         * thread.c: Fix common/ includes.
2388         * target/waitstatus.h: Fix common/ includes.
2389         * target/waitstatus.c: Fix common/ includes.
2390         * target.h: Fix common/ includes.
2391         * target.c: Fix common/ includes.
2392         * target-memory.c: Fix common/ includes.
2393         * target-descriptions.c: Fix common/ includes.
2394         * symtab.h: Fix common/ includes.
2395         * symfile.c: Fix common/ includes.
2396         * stap-probe.c: Fix common/ includes.
2397         * spu-linux-nat.c: Fix common/ includes.
2398         * sparc-nat.c: Fix common/ includes.
2399         * source.c: Fix common/ includes.
2400         * solib.c: Fix common/ includes.
2401         * solib-target.c: Fix common/ includes.
2402         * ser-unix.c: Fix common/ includes.
2403         * ser-tcp.c: Fix common/ includes.
2404         * ser-pipe.c: Fix common/ includes.
2405         * ser-base.c: Fix common/ includes.
2406         * selftest-arch.c: Fix common/ includes.
2407         * s12z-tdep.c: Fix common/ includes.
2408         * rust-exp.y: Fix common/ includes.
2409         * rs6000-aix-tdep.c: Fix common/ includes.
2410         * riscv-tdep.c: Fix common/ includes.
2411         * remote.c: Fix common/ includes.
2412         * remote-notif.h: Fix common/ includes.
2413         * remote-fileio.h: Fix common/ includes.
2414         * remote-fileio.c: Fix common/ includes.
2415         * regcache.h: Fix common/ includes.
2416         * regcache.c: Fix common/ includes.
2417         * record-btrace.c: Fix common/ includes.
2418         * python/python.c: Fix common/ includes.
2419         * python/py-type.c: Fix common/ includes.
2420         * python/py-inferior.c: Fix common/ includes.
2421         * progspace.h: Fix common/ includes.
2422         * producer.c: Fix common/ includes.
2423         * procfs.c: Fix common/ includes.
2424         * proc-api.c: Fix common/ includes.
2425         * printcmd.c: Fix common/ includes.
2426         * ppc-linux-nat.c: Fix common/ includes.
2427         * parser-defs.h: Fix common/ includes.
2428         * osdata.c: Fix common/ includes.
2429         * obsd-nat.c: Fix common/ includes.
2430         * nat/x86-linux.c: Fix common/ includes.
2431         * nat/x86-linux-dregs.c: Fix common/ includes.
2432         * nat/x86-dregs.h: Fix common/ includes.
2433         * nat/x86-dregs.c: Fix common/ includes.
2434         * nat/ppc-linux.c: Fix common/ includes.
2435         * nat/mips-linux-watch.h: Fix common/ includes.
2436         * nat/mips-linux-watch.c: Fix common/ includes.
2437         * nat/linux-waitpid.c: Fix common/ includes.
2438         * nat/linux-ptrace.h: Fix common/ includes.
2439         * nat/linux-ptrace.c: Fix common/ includes.
2440         * nat/linux-procfs.c: Fix common/ includes.
2441         * nat/linux-personality.c: Fix common/ includes.
2442         * nat/linux-osdata.c: Fix common/ includes.
2443         * nat/linux-namespaces.c: Fix common/ includes.
2444         * nat/linux-btrace.h: Fix common/ includes.
2445         * nat/linux-btrace.c: Fix common/ includes.
2446         * nat/fork-inferior.c: Fix common/ includes.
2447         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2448         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2449         * nat/aarch64-linux.c: Fix common/ includes.
2450         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2451         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2452         * namespace.h: Fix common/ includes.
2453         * mips-linux-tdep.c: Fix common/ includes.
2454         * minsyms.c: Fix common/ includes.
2455         * mi/mi-parse.h: Fix common/ includes.
2456         * mi/mi-main.c: Fix common/ includes.
2457         * mi/mi-cmd-env.c: Fix common/ includes.
2458         * memrange.h: Fix common/ includes.
2459         * memattr.c: Fix common/ includes.
2460         * maint.h: Fix common/ includes.
2461         * maint.c: Fix common/ includes.
2462         * main.c: Fix common/ includes.
2463         * machoread.c: Fix common/ includes.
2464         * location.c: Fix common/ includes.
2465         * linux-thread-db.c: Fix common/ includes.
2466         * linux-nat.c: Fix common/ includes.
2467         * linux-fork.c: Fix common/ includes.
2468         * inline-frame.c: Fix common/ includes.
2469         * infrun.c: Fix common/ includes.
2470         * inflow.c: Fix common/ includes.
2471         * inferior.h: Fix common/ includes.
2472         * inferior.c: Fix common/ includes.
2473         * infcmd.c: Fix common/ includes.
2474         * inf-ptrace.c: Fix common/ includes.
2475         * inf-child.c: Fix common/ includes.
2476         * ia64-linux-nat.c: Fix common/ includes.
2477         * i387-tdep.c: Fix common/ includes.
2478         * i386-tdep.c: Fix common/ includes.
2479         * i386-linux-tdep.c: Fix common/ includes.
2480         * i386-linux-nat.c: Fix common/ includes.
2481         * i386-go32-tdep.c: Fix common/ includes.
2482         * i386-fbsd-tdep.c: Fix common/ includes.
2483         * i386-fbsd-nat.c: Fix common/ includes.
2484         * guile/scm-type.c: Fix common/ includes.
2485         * guile/guile.c: Fix common/ includes.
2486         * go32-nat.c: Fix common/ includes.
2487         * gnu-nat.c: Fix common/ includes.
2488         * gdbthread.h: Fix common/ includes.
2489         * gdbarch-selftests.c: Fix common/ includes.
2490         * gdb_usleep.c: Fix common/ includes.
2491         * gdb_select.h: Fix common/ includes.
2492         * gdb_bfd.c: Fix common/ includes.
2493         * gcore.c: Fix common/ includes.
2494         * fork-child.c: Fix common/ includes.
2495         * findvar.c: Fix common/ includes.
2496         * fbsd-nat.c: Fix common/ includes.
2497         * event-top.c: Fix common/ includes.
2498         * event-loop.c: Fix common/ includes.
2499         * dwarf2read.c: Fix common/ includes.
2500         * dwarf2loc.c: Fix common/ includes.
2501         * dwarf2-frame.c: Fix common/ includes.
2502         * dwarf-index-cache.c: Fix common/ includes.
2503         * dtrace-probe.c: Fix common/ includes.
2504         * disasm-selftests.c: Fix common/ includes.
2505         * defs.h: Fix common/ includes.
2506         * csky-tdep.c: Fix common/ includes.
2507         * cp-valprint.c: Fix common/ includes.
2508         * cp-support.h: Fix common/ includes.
2509         * cp-support.c: Fix common/ includes.
2510         * corelow.c: Fix common/ includes.
2511         * completer.h: Fix common/ includes.
2512         * completer.c: Fix common/ includes.
2513         * compile/compile.c: Fix common/ includes.
2514         * compile/compile-loc2c.c: Fix common/ includes.
2515         * compile/compile-cplus-types.c: Fix common/ includes.
2516         * compile/compile-cplus-symbols.c: Fix common/ includes.
2517         * command.h: Fix common/ includes.
2518         * cli/cli-dump.c: Fix common/ includes.
2519         * cli/cli-cmds.c: Fix common/ includes.
2520         * charset.c: Fix common/ includes.
2521         * build-id.c: Fix common/ includes.
2522         * btrace.h: Fix common/ includes.
2523         * btrace.c: Fix common/ includes.
2524         * breakpoint.h: Fix common/ includes.
2525         * breakpoint.c: Fix common/ includes.
2526         * ax.h:
2527         (enum agent_op): Fix common/ includes.
2528         * ax-general.c (struct aop_map): Fix common/ includes.
2529         * ax-gdb.c: Fix common/ includes.
2530         * auxv.c: Fix common/ includes.
2531         * auto-load.c: Fix common/ includes.
2532         * arm-tdep.c: Fix common/ includes.
2533         * arch/riscv.c: Fix common/ includes.
2534         * arch/ppc-linux-common.c: Fix common/ includes.
2535         * arch/i386.c: Fix common/ includes.
2536         * arch/arm.c: Fix common/ includes.
2537         * arch/arm-linux.c: Fix common/ includes.
2538         * arch/arm-get-next-pcs.c: Fix common/ includes.
2539         * arch/amd64.c: Fix common/ includes.
2540         * arch/aarch64.c: Fix common/ includes.
2541         * arch/aarch64-insn.c: Fix common/ includes.
2542         * arch-utils.c: Fix common/ includes.
2543         * amd64-windows-tdep.c: Fix common/ includes.
2544         * amd64-tdep.c: Fix common/ includes.
2545         * amd64-sol2-tdep.c: Fix common/ includes.
2546         * amd64-obsd-tdep.c: Fix common/ includes.
2547         * amd64-nbsd-tdep.c: Fix common/ includes.
2548         * amd64-linux-tdep.c: Fix common/ includes.
2549         * amd64-linux-nat.c: Fix common/ includes.
2550         * amd64-fbsd-tdep.c: Fix common/ includes.
2551         * amd64-fbsd-nat.c: Fix common/ includes.
2552         * amd64-dicos-tdep.c: Fix common/ includes.
2553         * amd64-darwin-tdep.c: Fix common/ includes.
2554         * agent.c: Fix common/ includes.
2555         * ada-lang.h: Fix common/ includes.
2556         * ada-lang.c: Fix common/ includes.
2557         * aarch64-tdep.c: Fix common/ includes.
2558
2559 2019-01-25  Tom Tromey  <tom@tromey.com>
2560
2561         * common/create-version.sh: Use common/version.h.
2562
2563 2019-01-24  Pedro Alves  <palves@redhat.com>
2564
2565         * infrun.c (signal_stop, signal_print, signal_program)
2566         (signal_catch, signal_pass): Now arrays instead of pointers.
2567         (update_signals_program_target, do_target_resume)
2568         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2569         * linux-nat.c (linux_nat_target::pass_signals)
2570         (linux_nat_target::create_inferior, linux_nat_target::attach):
2571         Adjust.
2572         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2573         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2574         * procfs.c (procfs_target::pass_signals): Adjust.
2575         * record-full.c (record_full_target::resume): Adjust.
2576         * remote.c (remote_target::pass_signals)
2577         (remote_target::program_signals): Adjust.
2578         * target-debug.h (target_debug_print_signals): Now takes a
2579         gdb::array_view as parameter.  Adjust.
2580         * target.h (target_ops) <pass_signals, program_signals>: Replace
2581         pointer and length parameters with gdb::array_view.
2582         (target_pass_signals, target_program_signals): Likewise.
2583         * target-delegates.c: Regenerate.
2584
2585 2019-01-24  Pedro Alves  <palves@redhat.com>
2586
2587         * common/forward-scope-exit.h
2588         (forward_scope_exit::forward_scope_exit): Pass arguments to
2589         m_bind_function directly, instead of creating a std::bind and
2590         copying that.
2591
2592 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2593
2594         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2595         for static members.
2596         (pass_in_v_vfp_candidate): Likewise.
2597
2598 2019-01-23  Tom Tromey  <tom@tromey.com>
2599             Pedro Alves  <palves@redhat.com>
2600
2601         * regcache.c (class regcache_invalidator): Remove.
2602         (regcache::raw_write): Use make_scope_exit.
2603
2604 2019-01-23  Tom Tromey  <tom@tromey.com>
2605
2606         * ui-out.h (class ui_out_emit_type): Update comment.
2607
2608 2019-01-23  Tom Tromey  <tom@tromey.com>
2609
2610         * infrun.c (fetch_inferior_event): Update comment.
2611
2612 2019-01-23  Tom Tromey  <tom@tromey.com>
2613             Pedro Alves  <palves@redhat.com>
2614
2615         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2616         parameter.
2617         (fetch_inferior_event): Use SCOPE_EXIT.
2618
2619
2620 2019-01-23  Tom Tromey  <tom@tromey.com>
2621             Pedro Alves  <palves@redhat.com>
2622
2623         * infrun.c (disable_thread_events): Delete.
2624         (stop_all_threads): Use SCOPE_EXIT.
2625
2626 2019-01-23  Tom Tromey  <tom@tromey.com>
2627             Pedro Alves  <palves@redhat.com>
2628
2629         * symfile.c: Include forward-scope-exit.h.
2630         (clear_symtab_users_cleanup): Replace forward declaration with
2631         a FORWARD_SCOPE_EXIT.
2632         (syms_from_objfile_1): Use the forward_scope_exit and
2633         gdb::optional instead of cleanup_function.
2634         (reread_symbols): Use the forward_scope_exit instead of
2635         cleanup_function.
2636         (clear_symtab_users_cleanup): Remove function.
2637
2638 2019-01-23  Tom Tromey  <tom@tromey.com>
2639             Pedro Alves  <palves@redhat.com>
2640
2641         * linux-nat.c: Include scope-exit.h.
2642         (cleanup_target_stop): Remove.
2643         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2644         SCOPE_EXIT.
2645
2646 2019-01-23  Tom Tromey  <tom@tromey.com>
2647             Pedro Alves  <palves@redhat.com>
2648
2649         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2650         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2651
2652 2019-01-23  Tom Tromey  <tom@tromey.com>
2653             Andrew Burgess  <andrew.burgess@embecosm.com>
2654             Pedro Alves  <palves@redhat.com>
2655
2656         * infrun.c (fetch_inferior_event): Use scope_exit.
2657         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2658         * top.c (execute_command): Use scope_exit.
2659         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2660         * utils.c (do_bpstat_clear_actions_cleanup)
2661         (make_bpstat_clear_actions_cleanup): Remove.
2662
2663 2019-01-23  Tom Tromey  <tom@tromey.com>
2664             Pedro Alves  <palves@redhat.com>
2665
2666         * infrun.c: Include "common/scope-exit.h"
2667         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2668         (wait_for_inferior): Use SCOPE_EXIT.
2669         (fetch_inferior_event): Use scope_exit.
2670
2671 2019-01-23  Tom Tromey  <tom@tromey.com>
2672             Pedro Alves  <palves@redhat.com>
2673
2674         * breakpoint.c (create_breakpoint): Remove cleanup.
2675
2676 2019-01-23  Tom Tromey  <tom@tromey.com>
2677             Andrew Burgess  <andrew.burgess@embecosm.com>
2678             Pedro Alves  <palves@redhat.com>
2679
2680 2019-01-23  Pedro Alves  <palves@redhat.com>
2681
2682         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2683
2684 2019-01-23  Pedro Alves  <palves@redhat.com>
2685             Andrew Burgess  <andrew.burgess@embecosm.com>
2686
2687         * gdbthread.h: Include "common/forward-scope-exit.h".
2688         (scoped_finish_thread_state): Redefine custom class in terms of
2689         forward_scope_exit.
2690
2691 2019-01-23  Pedro Alves  <palves@redhat.com>
2692             Andrew Burgess  <andrew.burgess@embecosm.com>
2693
2694         * common/forward-scope-exit.h: New file.
2695
2696 2019-01-23  Pedro Alves  <palves@redhat.com>
2697             Andrew Burgess  <andrew.burgess@embecosm.com>
2698             Tom Tromey  <tom@tromey.com>
2699
2700         * common/scope-exit.h: New file.
2701
2702 2019-01-23  Pedro Alves  <palves@redhat.com>
2703
2704         * common/preprocessor.h (ESC): Rename to ...
2705         (ESC_PARENS): ... this.
2706         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2707         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2708
2709 2019-01-23  Tom Tromey  <tom@tromey.com>
2710
2711         * language.h (class scoped_switch_to_sym_language_if_auto):
2712         Initialize m_lang in both cases.
2713
2714 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2715
2716         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2717         with XCNEW.
2718
2719 2019-01-22  Tom Tromey  <tom@tromey.com>
2720
2721         * corelow.c: Do not include sys/file.h.
2722
2723 2019-01-22  Tom Tromey  <tom@tromey.com>
2724
2725         * tui/tui-wingeneral.h: Include gdb_curses.h.
2726
2727 2019-01-22  Tom Tromey  <tom@tromey.com>
2728
2729         * source-cache.h (class source_cache) <get_source_lines,
2730         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2731
2732 2019-01-22  Tom Tromey  <tom@tromey.com>
2733
2734         * remote-fileio.h (struct remote_target): Declare.
2735
2736 2019-01-22  Tom Tromey  <tom@tromey.com>
2737
2738         * python/py-arch.c: Do not include py-ref.h.
2739         * python/py-bpevent.c: Do not include py-ref.h.
2740         * python/py-cmd.c: Do not include py-ref.h.
2741         * python/py-continueevent.c: Do not include py-ref.h.
2742         * python/py-event.h: Do not include py-ref.h.
2743         * python/py-evtregistry.c: Do not include py-ref.h.
2744         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2745         * python/py-frame.c: Do not include py-ref.h.
2746         * python/py-framefilter.c: Do not include py-ref.h.
2747         * python/py-function.c: Do not include py-ref.h.
2748         * python/py-infevents.c: Do not include py-ref.h.
2749         * python/py-linetable.c: Do not include py-ref.h.
2750         * python/py-objfile.c: Do not include py-ref.h.
2751         * python/py-param.c: Do not include py-ref.h.
2752         * python/py-prettyprint.c: Do not include py-ref.h.
2753         * python/py-progspace.c: Do not include py-ref.h.
2754         * python/py-symbol.c: Do not include py-ref.h.
2755         * python/py-symtab.c: Do not include py-ref.h.
2756         * python/py-type.c: Do not include py-ref.h.
2757         * python/py-unwind.c: Do not include py-ref.h.
2758         * python/py-utils.c: Do not include py-ref.h.
2759         * python/py-value.c: Do not include py-ref.h.
2760         * python/py-varobj.c: Do not include py-ref.h.
2761         * python/py-xmethods.c: Do not include py-ref.h.
2762         * python/python.c: Do not include py-ref.h.
2763         * varobj.c: Do not include py-ref.h.
2764
2765 2019-01-22  Tom Tromey  <tom@tromey.com>
2766
2767         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2768         keyword for bcache.
2769
2770 2019-01-22  Tom Tromey  <tom@tromey.com>
2771
2772         * compile/compile-cplus-types.c: Remove a comment by #include.
2773
2774 2019-01-22  Tom Tromey  <tom@tromey.com>
2775
2776         * compile/gcc-c-plugin.h: Include compile-internal.h.
2777
2778 2019-01-22  Tom Tromey  <tom@tromey.com>
2779
2780         * stabsread.c (EXTERN): Do not define.
2781         (symnum, next_symbol_text_func, processing_gcc_compilation)
2782         (within_function, global_sym_chain, global_stabs)
2783         (previous_stab_code, this_object_header_files)
2784         (n_this_object_header_files)
2785         (n_allocated_this_object_header_files): Define.
2786         * stabsread.h (EXTERN): Never define.  Use "extern".
2787
2788 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2789
2790         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2791         history_value.
2792
2793 2019-01-21  Tom Tromey  <tom@tromey.com>
2794
2795         * ui-out.c: Fix includes.
2796         * tui/tui-source.c: Fix includes.
2797         * target.c: Fix includes.
2798         * remote.c: Fix includes.
2799         * regcache.c: Fix includes.
2800         * python/py-block.c: Fix includes.
2801         * printcmd.c: Fix includes.
2802         * or1k-tdep.c: Fix includes.
2803         * mi/mi-main.c: Fix includes.
2804         * m32r-tdep.c: Fix includes.
2805         * csky-tdep.c: Fix includes.
2806         * compile/compile-cplus-types.c: Fix includes.
2807         * cli/cli-interp.c: Fix includes.
2808
2809 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2810
2811         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2812         for padding.
2813
2814 2019-01-16  Tom Tromey  <tom@tromey.com>
2815
2816         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2817         earlier.
2818         (struct objfile) <msymbols_range>: Move from top level.
2819         <msymbols>: New method.
2820         (class objfile_msymbols): Remove.
2821         * symtab.c (default_collect_symbol_completion_matches_break_on):
2822         Update.
2823         * symmisc.c (dump_msymbols): Update.
2824         * stabsread.c (scan_file_globals): Update.
2825         * objc-lang.c (info_selectors_command, info_classes_command)
2826         (find_methods): Update.
2827         * minsyms.c (find_solib_trampoline_target): Update.
2828         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2829         * coffread.c (coff_symfile_read): Update.
2830         * ada-lang.c (ada_lookup_simple_minsym)
2831         (ada_collect_symbol_completion_matches): Update.
2832
2833 2019-01-16  Tom Tromey  <tom@tromey.com>
2834
2835         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2836         type.  Remove no-argument constructor.
2837         <iterator::operator++>: Simplify.
2838         <begin>: Update.
2839         <end>: Use minimal_symbol_count.
2840
2841 2019-01-16  Tom Tromey  <tom@tromey.com>
2842
2843         * objfiles.h (struct objfile) <psymtabs>: New method.
2844         (class objfile_psymtabs): Remove.
2845         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2846         typedef.
2847         <range>: New method.
2848         (require_partial_symbols): Change return type.
2849         * psymtab.c (require_partial_symbols)
2850         (psym_expand_symtabs_matching): Update.
2851         * mdebugread.c (parse_partial_symbols): Update.
2852         * dbxread.c (dbx_end_psymtab): Update.
2853
2854 2019-01-15  Tom Tromey  <tom@tromey.com>
2855
2856         * symtab.c (lookup_objfile_from_block)
2857         (lookup_symbol_in_objfile_symtabs)
2858         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2859         (find_line_symtab, info_sources_command)
2860         (default_collect_symbol_completion_matches_break_on)
2861         (make_source_files_completion_list): Update.
2862         * symmisc.c (print_objfile_statistics, dump_objfile)
2863         (maintenance_print_symbols, maintenance_info_symtabs)
2864         (maintenance_check_symtabs, maintenance_info_line_tables):
2865         Update.
2866         * source.c (select_source_symtab)
2867         (forget_cached_source_info_for_objfile): Update.
2868         * objfiles.h (class objfile_compunits): Remove.
2869         (struct objfile) <compunits_range>: New typedef.
2870         (compunits): New method.
2871         * objfiles.c (objfile_relocate1): Update.
2872         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2873         * maint.c (count_symtabs_and_blocks): Update.
2874         * linespec.c (iterate_over_all_matching_symtabs): Update.
2875         * cp-support.c (add_symbol_overload_list_qualified): Update.
2876         * coffread.c (coff_symtab_read): Update.
2877         * ada-lang.c (add_nonlocal_symbols)
2878         (ada_collect_symbol_completion_matches)
2879         (ada_add_global_exceptions): Update.
2880
2881 2019-01-15  Tom Tromey  <tom@tromey.com>
2882
2883         * progspace.h (program_space) <objfiles_safe_range>: New
2884         typedef.
2885         <objfiles_safe>: New method.
2886         * objfiles.h (class all_objfiles_safe): Remove.
2887         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2888         * jit.c (jit_inferior_exit_hook): Update.
2889
2890 2019-01-17  Tom Tromey  <tom@tromey.com>
2891
2892         * progspace.h (program_space) <objfiles_range>: New typedef.
2893         <objfiles>: New method.
2894         <objfiles_head>: Rename from objfiles.
2895         (object_files): Update.
2896         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2897         * guile/scm-pretty-print.c
2898         (ppscm_find_pretty_printer_from_objfiles): Update.
2899         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2900         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2901         Update.
2902         * python/py-progspace.c (pspy_get_objfiles): Update.
2903         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2904         Update.
2905         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2906         (objfpy_lookup_objfile_by_build_id): Update.
2907         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2908         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2909         Update.
2910         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2911         (expand_symtab_containing_pc, lookup_objfile_from_block)
2912         (lookup_static_symbol, basic_lookup_transparent_type)
2913         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2914         (find_line_symtab, info_sources_command)
2915         (default_collect_symbol_completion_matches_break_on)
2916         (make_source_files_completion_list, find_main_name): Update.
2917         * symmisc.c (print_symbol_bcache_statistics)
2918         (print_objfile_statistics, maintenance_print_symbols)
2919         (maintenance_print_msymbols, maintenance_print_objfiles)
2920         (maintenance_info_symtabs, maintenance_check_symtabs)
2921         (maintenance_expand_symtabs, maintenance_info_line_tables):
2922         Update.
2923         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2924         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2925         (map_overlay_command, unmap_overlay_command)
2926         (simple_overlay_update, expand_symtabs_matching)
2927         (map_symbol_filenames): Update.
2928         * symfile-debug.c (set_debug_symfile): Update.
2929         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2930         Update.
2931         * source.c (select_source_symtab, forget_cached_source_info):
2932         Update.
2933         * solib.c (solib_read_symbols): Update.
2934         * solib-spu.c (append_ocl_sos): Update.
2935         * psymtab.c (maintenance_print_psymbols)
2936         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2937         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2938         * printcmd.c (info_symbol_command): Update.
2939         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2940         Update.
2941         * objfiles.h (class all_objfiles): Remove.
2942         * objfiles.c (have_partial_symbols, have_full_symbols)
2943         (have_minimal_symbols, qsort_cmp, update_section_map)
2944         (shared_objfile_contains_address_p)
2945         (default_iterate_over_objfiles_in_search_order): Update.
2946         * objc-lang.c (info_selectors_command, info_classes_command)
2947         (find_methods): Update.
2948         * minsyms.c (find_solib_trampoline_target): Update.
2949         * maint.c (maintenance_info_sections)
2950         (maintenance_translate_address, count_symtabs_and_blocks):
2951         Update.
2952         * main.c (captured_main_1): Update.
2953         * linux-thread-db.c (try_thread_db_load_from_pdir)
2954         (has_libpthread): Update.
2955         * linespec.c (iterate_over_all_matching_symtabs)
2956         (search_minsyms_for_name): Update.
2957         * jit.c (jit_find_objf_with_entry_addr): Update.
2958         * hppa-tdep.c (find_unwind_entry)
2959         (hppa_lookup_stub_minimal_symbol): Update.
2960         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2961         Update.
2962         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2963         (elf_gnu_ifunc_resolve_by_got): Update.
2964         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2965         * dwarf-index-write.c (save_gdb_index_command): Update.
2966         * cp-support.c (add_symbol_overload_list_qualified): Update.
2967         * breakpoint.c (create_overlay_event_breakpoint)
2968         (create_longjmp_master_breakpoint)
2969         (create_std_terminate_master_breakpoint)
2970         (create_exception_master_breakpoint): Update.
2971         * blockframe.c (find_pc_partial_function): Update.
2972         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2973         (ada_collect_symbol_completion_matches)
2974         (ada_add_global_exceptions): Update.
2975
2976 2019-01-17  Tom Tromey  <tom@tromey.com>
2977
2978         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2979         declare VEC.
2980         (solib_target_parse_libraries): Change return type.
2981         (library_list_start_segment, library_list_start_section)
2982         (library_list_end_library, library_list_start_library); Update.
2983         (solib_target_free_library_list): Remove.
2984         (solib_target_parse_libraries): Remove cleanup.  Change return
2985         type.
2986         (solib_target_current_sos): Update.
2987
2988 2019-01-17  Tom Tromey  <tromey@bapiya>
2989
2990         * valprint.c: Replace "the the" with "the".
2991         * symtab.c: Replace "the the" with "the".
2992         * solib.c: Replace "the the" with "the".
2993         * solib-dsbt.c: Replace "the the" with "the".
2994         * linespec.c: Replace "the the" with "the".
2995         * dwarf2loc.h: Replace "the the" with "the".
2996         * amd64-windows-tdep.c: Replace "the the" with "the".
2997         * aarch64-tdep.c: Replace "the the" with "the".
2998
2999 2019-01-16  Keith Seitz  <keiths@redhat.com>
3000
3001         PR gdb/23773
3002         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3003         <builder>: Rename to ..
3004         <m_builder>: ... this and make private.
3005         (dwarf2_cu::get_builder): New method.  Change all users of
3006         `builder' to use this method.
3007         (dwarf2_start_symtab): Move to ...
3008         (dwarf2_cu::start_symtab): ... here.  Update all callers
3009         (setup_type_unit_groups): Move to ...
3010         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3011         callers.
3012         (dwarf2_cu::reset_builder): New method.
3013         (process_full_compunit, process_full_type_unit): Use
3014         dwarf2_cu::reset_builder.
3015         (follow_die_offset): Record the ancestor CU if it is different
3016         from the followed DIE's CU.
3017         (follow_die_sig_1): Likewise.
3018
3019 2019-01-15  Tom Tromey  <tom@tromey.com>
3020
3021         * remote.c (class remote_state) <buf>: Now a char_vector.
3022         <buf_size>: Remove.
3023         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3024         parameter.
3025         (remote_target::getpkt_or_notif_sane_1)
3026         (remote_target::getpkt_sane)
3027         (remote_target::getpkt_or_notif_sane): Likewise.
3028         (class remote_target) <putpkt>: New overload.
3029         (remote_target::read_frame): Change type of "buf_p".  Remove
3030         sizeof_p parameter.
3031         (packet_ok): New overload.
3032         (packet_check_result): New overload.
3033         Update all uses.
3034
3035 2019-01-14  Tom Tromey  <tom@tromey.com>
3036
3037         * remote-notif.c (handle_notification, remote_notif_ack)
3038         (remote_notif_parse): Make "buf" const.
3039         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3040         const.
3041         (remote_notif_parse, remote_notif_ack, handle_notification):
3042         Likewise.
3043         * remote.c (remote_notif_stop_parse): Make "buf" const.
3044         (remote_target::remote_parse_stop_reply): Make "buf" const.
3045         (remote_notif_stop_ack): Make "buf" const.
3046
3047 2019-01-14  Tom Tromey  <tom@tromey.com>
3048
3049         * remote.c (remote_console_output): Make parameter const.
3050
3051 2019-01-14  Tom Tromey  <tom@tromey.com>
3052
3053         * target-debug.h (target_debug_print_signals): Constify.
3054         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3055         * procfs.c (procfs_target::pass_signals): Update.
3056         * linux-nat.c (linux_nat_target::pass_signals): Update.
3057         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3058         * target-delegates.c: Rebuild.
3059         * remote.c (remote_target::program_signals): Update.
3060         (remote_target::pass_signals): Update.
3061         * target.c (target_pass_signals): Constify argument.
3062         (target_program_signals): Likewise.
3063         * target.h (struct target_ops) <pass_signals, program_signals>:
3064         Constify argument.
3065         (target_pass_signals, target_program_signals): Constify argument.
3066
3067 2019-01-14  Tom Tromey  <tom@tromey.com>
3068
3069         PR tui/28819:
3070         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3071
3072 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3073
3074         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3075         field.
3076         * rs6000-tdep.c: Include reggroups.h.
3077         (IS_V_ALIAS_PSEUDOREG): Define.
3078         (rs6000_register_name): Return names for the "vX" aliases.
3079         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3080         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3081         aliases.  Call default_register_reggroup_p for all other
3082         pseudo-registers.
3083         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3084         New functions.
3085         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3086         Handle "vX" aliases.
3087         (v_alias_pseudo_register_collect): New function.
3088         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3089         (rs6000_gdbarch_init): Initialize "vX" aliases as
3090         pseudo-registers.  Restore registration of
3091         rs6000_pseudo_register_reggroup_p with
3092         set_tdesc_pseudo_register_reggroup_p.
3093
3094 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3095
3096         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3097         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3098         set_gdbarch_num_pseudo_regs.
3099
3100 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3101
3102         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3103         Remove arg prefixname, add do_set and do_show.
3104         Add member functions set_list and show_list.
3105         * cli/cli-style.c (class cli_style_option): Update accordingly.
3106         (style_set_list): Move to file scope.
3107         (style_show_list): Likewise.
3108         (set_style): Call help_list.
3109         (show_style): Call cmd_show_list.
3110         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3111         Update to use the new macro.
3112
3113 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3114
3115         * ada-lang.c (_initialize_ada_language): Expand the help text
3116         for the "catch exception" command.
3117
3118 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3119
3120         * symtab.c (matching_obj_sections): Initialize obj,
3121         declare it closer to its usage.
3122
3123 2019-01-10  Tom Tromey  <tom@tromey.com>
3124
3125         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3126         (basic_inf_threads_range): Remove.
3127         (inf_threads_range, inf_non_exited_threads_range)
3128         (safe_inf_threads_range): Use next_adapter.
3129
3130 2019-01-10  Keith Seitz  <keiths@redhat.com>
3131
3132         PR gdb/23712
3133         PR symtab/23010
3134         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3135         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3136
3137 2019-01-10  Keith Seitz  <keiths@redhat.com>
3138
3139         PR gdb/23712
3140         PR symtab/23010
3141         * dictionary.c (pending_to_vector): Remove.
3142         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3143         Remove _1 suffix, replacing functions of the same name.  Update
3144         all callers.
3145         (dict_create_hashed, dict_create_hashed_expandable)
3146         (dict_create_linear, dict_create_linear_expandable, dict_free)
3147         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3148         Make functions static.
3149
3150 2019-01-10  Keith Seitz  <keiths@redhat.com>
3151
3152         PR gdb/23712
3153         PR symtab/23010
3154         * dictionary.h (struct dictionary): Replace declaration with
3155         multidictionary.
3156         (dict_create_hashed, dict_create_hashed_expandable)
3157         (dict_create_linear, dict_create_linear_expandable)
3158         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3159         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3160         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3161         taking multidictionary argument.
3162         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3163         * block.h (struct block) <dict>: Change to multidictionary
3164         and rename `multidict'.
3165         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3166         symmisc.c: Update all dictionary references to multidictionary.
3167
3168 2019-01-10  Keith Seitz  <keiths@redhat.com>
3169
3170         PR gdb/23712
3171         PR symtab/23010
3172         * dictionary.c: Include unordered_map.
3173         (pending_to_vector): New function.
3174         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3175         Rewrite the non-"_1" functions to take vector instead
3176         of linked list.
3177         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3178         "new" _1 versions of the same name.
3179         (multidictionary): Define.
3180         (std::hash<enum language): New definition.
3181         (collate_pending_symbols_by_language, mdict_create_hashed)
3182         (mdict_create_hashed_expandable, mdict_create_linear)
3183         (mdict_create_linear_expandable, mdict_free)
3184         (find_language_dictionary, create_new_language_dictionary)
3185         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3186         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3187         (mdict_size, mdict_empty): New functions.
3188         * dictionary.h (mdict_iterator): Define.
3189
3190 2019-01-10  Pedro Alves  <palves@redhat.com>
3191
3192         * breakpoint.c (read_uploaded_action)
3193         (create_tracepoint_from_upload): Adjust to use
3194         gdb::unique_xmalloc_ptr.
3195         * ctf.c (ctf_write_uploaded_tp):
3196         (SET_ARRAY_FIELD): Use emplace_back.
3197         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3198         * tracefile-tfile.c (tfile_write_uploaded_tp):
3199         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3200         gdb::unique_xmalloc_ptr.
3201         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3202         at_string, cond_string, cmd_strings>: Replace char pointers
3203         with gdb::unique_xmalloc_ptr.
3204
3205 2019-01-10  Pedro Alves  <palves@redhat.com>
3206
3207         * solib-target.c (library_list_start_library): Don't xstrdup name.
3208
3209 2019-01-10  Pedro Alves  <palves@redhat.com>
3210
3211         * mdebugread.c (parse_partial_symbols): Use
3212         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3213
3214 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3215
3216         * linux-fork.c (scoped_switch_fork_info)
3217         <~scoped_switch_fork_info>: Fix incorrect variable name.
3218
3219 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3220
3221         * linux-fork.c (scoped_switch_fork_info)
3222         <scoped_switch_fork_info>: Make explicit.
3223         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3224
3225 2019-01-10  Tom Tromey  <tom@tromey.com>
3226
3227         * objfiles.h (objfile::reset_psymtabs): Update.
3228         * objfiles.c (objfile::objfile): Update.
3229         * psymtab.h (psymtab_storage::obstack): Update.
3230         (psymtab_storage::m_obstack): Use gdb::optional.
3231         (class psymtab_storage): Update comment.  Remove objfile
3232         parameter.
3233         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3234
3235 2019-01-10  Tom Tromey  <tom@tromey.com>
3236
3237         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3238         <free_psymtabs>: Now private.
3239         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3240         (allocate_psymtab): Use new method.
3241
3242 2019-01-10  Tom Tromey  <tom@tromey.com>
3243
3244         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3245         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3246         * mdebugread.c (parse_partial_symbols): Use
3247         allocate_dependencies.
3248         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3249         allocate_dependencies.
3250         (process_psymtab_comp_unit_reader)
3251         (build_type_psymtab_dependencies): Likewise.
3252         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3253
3254 2019-01-10  Tom Tromey  <tom@tromey.com>
3255
3256         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3257         PSYMBOL_SET_LANGUAGE.
3258         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3259
3260 2019-01-10  Tom Tromey  <tom@tromey.com>
3261
3262         * psymtab.h (psymtab_storage::obstack): New method.
3263         <m_obstack>: Rename from obstack; now private.
3264         * psymtab.c (psymtab_storage): Update.
3265         * dwarf2read.c (create_addrmap_from_index)
3266         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3267         Update.
3268
3269 2019-01-10  Tom Tromey  <tom@tromey.com>
3270
3271         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3272         * objfiles.h (objfile::reset_psymtabs): New method.
3273
3274 2019-01-10  Tom Tromey  <tom@tromey.com>
3275
3276         * symmisc.c (print_symbol_bcache_statistics): Update.
3277         (print_objfile_statistics): Update.
3278         * symfile.c (reread_symbols): Update.
3279         * psymtab.h (class psymtab_storage): New.
3280         * psymtab.c (psymtab_storage): New constructor.
3281         (~psymtab_storage): New destructor.
3282         (require_partial_symbols): Update.
3283         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3284         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3285         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3286         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3287         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3288         (start_psymtab_common, end_psymtab_common)
3289         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3290         (allocate_psymtab): Update.
3291         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3292         Update.
3293         (dump_psymtab_addrmap, maintenance_print_psymbols)
3294         (maintenance_check_psymtabs): Update.
3295         (class objfile_psymtabs): Move to objfiles.h.
3296         * psympriv.h (discard_psymtab): Now inline.
3297         (psymtab_discarder::psymtab_discarder): Update.
3298         (psymtab_discarder::~psymtab_discarder): Update.
3299         (ALL_OBJFILE_PSYMTABS): Rewrite.
3300         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3301         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3302         Remove fields.
3303         <partial_symtabs>: New field.
3304         (class objfile_psymtabs): Move from psymtab.h.  Update.
3305         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3306         psymbol_cache.
3307         (objfile::~objfile): Don't destroy psymbol_cache.
3308         * mdebugread.c (parse_partial_symbols): Update.
3309         * dwarf2read.c (create_addrmap_from_index)
3310         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3311         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3312         (add_partial_subprogram, dwarf2_ranges_read): Update.
3313         * dwarf-index-write.c (write_address_map)
3314         (write_one_signatured_type, recursively_write_psymbols)
3315         (class debug_names, class debug_names, write_psymtabs_to_index):
3316         Update.
3317
3318 2019-01-10  Tom Tromey  <tom@tromey.com>
3319
3320         * symtab.h (SYMBOL_SET_NAMES): Update.
3321         (symbol_set_names): Update.
3322         (MSYMBOL_SET_NAMES): Update.
3323         * symtab.c (symbol_set_names): Change argument to be an
3324         objfile_per_bfd_storage.
3325         * psymtab.c (add_psymbol_to_bcache): Update.
3326         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3327
3328 2019-01-10  Tom Tromey  <tom@tromey.com>
3329
3330         * symtab.c (create_demangled_names_hash): Change argument to be an
3331         objfile_per_bfd_storage.
3332         (symbol_set_names): Update.
3333
3334 2019-01-10  Tom Tromey  <tom@tromey.com>
3335
3336         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3337         init_psymbol_list.
3338         * psymtab.c (init_psymbol_list): Do nothing if already called.
3339         * psympriv.h (init_psymbol_list): Add comment.
3340         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3341         init_psymbol_list.
3342         * dbxread.c (dbx_symfile_read): Unconditionally call
3343         init_psymbol_list.
3344
3345 2019-01-10  Tom Tromey  <tom@tromey.com>
3346
3347         * xcoffread.c (scan_xcoff_symtab): Update.
3348         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3349         "where".
3350         * mdebugread.c (parse_partial_symbols)
3351         (handle_psymbol_enumerators): Update.
3352         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3353         * dbxread.c (read_dbx_symtab): Update.
3354         * psympriv.h (psymbol_placement): New enum.
3355         (add_psymbol_to_list): Update.
3356
3357 2019-01-10  Tom Tromey  <tom@tromey.com>
3358
3359         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3360         static_psymbols parameters.
3361         (scan_xcoff_symtab): Update.
3362         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3363         static_psymbols parameters.
3364         * psympriv.h (start_psymtab_common): Update.
3365         * mdebugread.c (parse_partial_symbols): Update.
3366         * dwarf2read.c (create_partial_symtab): Update.
3367         * dbxread.c (read_dbx_symtab): Update.
3368         (start_psymtab): Remove global_psymbols and static_psymbols
3369         parameters.
3370
3371 2019-01-10  Tom Tromey  <tom@tromey.com>
3372
3373         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3374         * psymtab.c (allocate_psymtab): Add comment.
3375         * psympriv.h (allocate_psymtab): Add comment.
3376         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3377         initializations.
3378         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3379
3380 2019-01-10  Tom Tromey  <tom@tromey.com>
3381
3382         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3383         Don't declare.
3384         * mipsread.c: Include mdebugread.h.
3385         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3386         Declare.
3387         * elfread.c: Include mdebugread.h.
3388
3389 2019-01-09  Tom Tromey  <tom@tromey.com>
3390
3391         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3392         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3393         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3394         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3395         (psym_lookup_symbol, psym_find_last_source_symtab)
3396         (psym_forget_cached_source_info, psym_print_stats)
3397         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3398         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3399         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3400         (psym_find_compunit_symtab_by_address)
3401         (maintenance_print_psymbols, maintenance_info_psymtabs)
3402         (maintenance_check_psymtabs): Use ranged for.
3403         * psymtab.h (class objfile_psymtabs): New.
3404         (require_partial_symbols): Return objfile_psymtabs.
3405         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3406
3407 2019-01-09  Tom Tromey  <tom@tromey.com>
3408
3409         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3410         (find_pc_mapped_section, list_overlays_command)
3411         (map_overlay_command, unmap_overlay_command)
3412         (simple_overlay_update): Use all_objfiles.
3413         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3414         * printcmd.c (info_symbol_command): Use all_objfiles.
3415         * objfiles.h (ALL_OBJSECTIONS): Remove.
3416         * maint.c (maintenance_translate_address): Use all_objfiles.
3417         * gcore.c (gcore_create_callback): Use all_objfiles.
3418         (objfile_find_memory_regions): Likewise.
3419
3420 2019-01-09  Tom Tromey  <tom@tromey.com>
3421
3422         * symtab.c (find_line_symtab, info_sources_command)
3423         (make_source_files_completion_list): Use objfile_compunits.
3424         * source.c (select_source_symtab): Use objfile_compunits.
3425         * objfiles.h (struct objfile): Update comment.
3426         (ALL_OBJFILES): Remove.
3427         (ALL_FILETABS): Remove.
3428         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3429         objfile_compunits.
3430
3431 2019-01-09  Tom Tromey  <tom@tromey.com>
3432
3433         * symmisc.c (print_objfile_statistics, dump_objfile)
3434         (maintenance_print_symbols): Use compunit_filetabs.
3435         * source.c (forget_cached_source_info_for_objfile): Use
3436         compunit_filetabs.
3437         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3438         (ALL_FILETABS): Use compunit_filetabs.
3439         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3440         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3441
3442 2019-01-09  Tom Tromey  <tom@tromey.com>
3443
3444         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3445         (compunit_filetabs): New.
3446         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3447         compunit_filetabs.
3448         (info_sources_command, make_source_files_completion_list): Remove
3449         declaration.
3450         * symmisc.c (print_objfile_statistics, dump_objfile)
3451         (maintenance_print_symbols): Remove declaration.
3452         (maintenance_info_symtabs): Use compunit_filetabs.
3453         (maintenance_info_line_tables): Likewise.
3454         * source.c (select_source_symtab): Change local variable name.
3455         (forget_cached_source_info_for_objfile): Remove declaration.
3456         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3457         * objfiles.c (objfile_relocate1): Remove declaration.
3458         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3459         declaration.
3460         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3461         * coffread.c (coff_symtab_read): Remove declaration.
3462         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3463         compunit_filetabs.
3464
3465 2019-01-09  Tom Tromey  <tom@tromey.com>
3466
3467         * symtab.c (lookup_objfile_from_block)
3468         (find_pc_sect_compunit_symtab, search_symbols)
3469         (default_collect_symbol_completion_matches_break_on): Use
3470         objfile_compunits.
3471         * objfiles.h (ALL_COMPUNITS): Remove.
3472         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3473         * cp-support.c (add_symbol_overload_list_qualified): Use
3474         objfile_compunits.
3475         * ada-lang.c (ada_collect_symbol_completion_matches)
3476         (ada_add_global_exceptions): Use objfile_compunits.
3477
3478 2019-01-09  Tom Tromey  <tom@tromey.com>
3479
3480         * source.c (select_source_symtab)
3481         (forget_cached_source_info_for_objfile): Remove declaration.
3482         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3483         declaration.
3484         * maint.c (count_symtabs_and_blocks): Remove declaration.
3485         * cp-support.c (add_symbol_overload_list_qualified): Remove
3486         declaration.
3487         * coffread.c (coff_symtab_read): Remove declaration.
3488         * symtab.c (lookup_symbol_in_objfile_symtabs)
3489         (basic_lookup_transparent_type_1): Use objfile_compunits.
3490         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3491         (info_sources_command, search_symbols)
3492         (default_collect_symbol_completion_matches_break_on)
3493         (make_source_files_completion_list): Remove declaration.
3494         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3495         (ada_collect_symbol_completion_matches)
3496         (ada_add_global_exceptions): Remove declaration.
3497         * linespec.c (iterate_over_all_matching_symtabs): Use
3498         objfile_compunits.
3499         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3500         (class objfile_compunits): New.
3501         (ALL_COMPUNITS): Use objfile_compunits.
3502         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3503         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3504         objfile_compunits.
3505         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3506
3507 2019-01-09  Tom Tromey  <tom@tromey.com>
3508
3509         * symtab.c (search_symbols)
3510         (default_collect_symbol_completion_matches_break_on): Use
3511         objfile_msymbols.
3512         * ada-lang.c (ada_lookup_simple_minsym)
3513         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3514         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3515         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3516         objfile_msymbols.
3517         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3518         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3519         * objc-lang.c (find_methods): Use objfile_msymbols.
3520         (info_selectors_command, info_classes_command): Likewise.
3521         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3522         * objfiles.h (class objfile_msymbols): New.
3523         (ALL_OBJFILE_MSYMBOLS): Remove.
3524         (ALL_MSYMBOLS): Remove.
3525
3526 2019-01-09  Tom Tromey  <tom@tromey.com>
3527
3528         * common/next-iterator.h (next_adapter): Add Iterator template
3529         parameter.
3530         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3531         (class all_objfiles_safe): New.
3532         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3533         * objfiles.c (put_objfile_before): Update comment.
3534         (add_separate_debug_objfile): Likewise.
3535         (free_all_objfiles): Use all_objfiles_safe.
3536         (objfile_purge_solibs): Likewise.
3537
3538 2019-01-09  Tom Tromey  <tom@tromey.com>
3539
3540         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3541         (expand_symtab_containing_pc, lookup_static_symbol)
3542         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3543         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3544         all_objfiles.
3545         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3546         * breakpoint.c (create_overlay_event_breakpoint)
3547         (create_longjmp_master_breakpoint)
3548         (create_std_terminate_master_breakpoint)
3549         (create_exception_master_breakpoint): Use all_objfiles.
3550         * linux-thread-db.c (try_thread_db_load_from_pdir)
3551         (has_libpthread): Use all_objfiles.
3552         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3553         * linespec.c (iterate_over_all_matching_symtabs)
3554         (search_minsyms_for_name): Use all_objfiles.
3555         * maint.c (maintenance_info_sections): Use all_objfiles.
3556         * main.c (captured_main_1): Use all_objfiles.
3557         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3558         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3559         * guile/scm-pretty-print.c
3560         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3561         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3562         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3563         (maintenance_print_msymbols): Use all_objfiles.
3564         * source.c (select_source_symtab): Use all_objfiles.
3565         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3566         * symfile.c (remove_symbol_file_command)
3567         (expand_symtabs_matching, map_symbol_filenames): Use
3568         all_objfiles.
3569         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3570         all_objfiles.
3571         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3572         * objc-lang.c (find_methods): Use all_objfiles.
3573         * objfiles.c (have_partial_symbols, have_full_symbols)
3574         (have_minimal_symbols, qsort_cmp)
3575         (default_iterate_over_objfiles_in_search_order): Use
3576         all_objfiles.
3577         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3578         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3579         (maintenance_check_psymtabs): Use all_objfiles.
3580         (ALL_PSYMTABS): Remove.
3581         * compile/compile-object-run.c (do_module_cleanup): Use
3582         all_objfiles.
3583         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3584         * cp-support.c (add_symbol_overload_list_qualified): Use
3585         all_objfiles.
3586         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3587         Use all_objfiles.
3588         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3589         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3590         all_objfiles.
3591         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3592         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3593         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3594         Uses all_objfiles.
3595         * solib.c (solib_read_symbols): Use all_objfiles
3596
3597 2019-01-09  Tom Tromey  <tom@tromey.com>
3598
3599         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3600         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3601         all_objfiles.
3602         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3603         * symmisc.c (print_symbol_bcache_statistics)
3604         (print_objfile_statistics, maintenance_print_objfiles)
3605         (maintenance_info_symtabs, maintenance_check_symtabs)
3606         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3607         all_objfiles.
3608         * source.c (forget_cached_source_info): Use all_objfiles.
3609         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3610         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3611         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3612         * objfiles.c (update_section_map): Use all_objfiles.
3613         (shared_objfile_contains_address_p): Likewise.
3614         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3615         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3616
3617 2019-01-09  Tom Tromey  <tom@tromey.com>
3618
3619         * common/next-iterator.h: New file.
3620         * objfiles.h (class all_objfiles): New.
3621         (struct objfile_iterator): New.
3622
3623 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3624
3625         * NEWS: Move the description of the changed "frame", "select-frame",
3626          and "info frame" commands to the Changed commands section.
3627
3628 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3629
3630         * gdbtypes.c (check_stub_method_group): Remove handling of old
3631         mangling schemes.
3632         * linespec.c (find_methods): Likewise.
3633         * stabsread.c (read_member_functions): Likewise.
3634         * valops.c (search_struct_method): Likewise.
3635         (value_struct_elt_for_reference): Likewise.
3636         * NEWS: Mention this change.
3637
3638 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3639
3640         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3641         print_source_lines.
3642         * source.c (print_source_lines_base): Update line number check.
3643         (print_source_lines): New function.
3644         (source_lines_range::source_lines_range): New function.
3645         * source.h (class source_lines_range): New class.
3646         (print_source_lines): New declaration.
3647
3648 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3649
3650         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3651
3652 2019-01-08  Tom Tromey  <tom@tromey.com>
3653             Simon Marchi  <simon.marchi@ericsson.com>
3654
3655         PR gdb/24060
3656         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3657         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3658         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3659         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3660         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3661         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3662
3663 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3664
3665         * source.c (select_source_symtab): Move header comment to
3666         declaration in source.h.
3667         (forget_cached_source_info_for_objfile): Likewise.
3668         (forget_cached_source_info): Likewise.
3669         (identify_source_line): Likewise.
3670         * source.h (identify_source_line): Move declaration from symtab.h
3671         and add comment from source.c
3672         (print_source_lines): Likewise.
3673         (forget_cached_source_info_for_objfile): Likewise.
3674         (forget_cached_source_info): Likewise.
3675         (select_source_symtab): Likewise.
3676         (enum print_source_lines_flag): Move definition from symtab.h.
3677         * symtab.h (identify_source_line): Move declaration to source.h.
3678         (print_source_lines): Likewise.
3679         (forget_cached_source_info_for_objfile): Likewise.
3680         (forget_cached_source_info): Likewise.
3681         (select_source_symtab): Likewise.
3682         (enum print_source_lines_flag): Move definition to source.h.
3683         * tui/tui-hooks.c: Add 'source.h' include.
3684
3685 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3686
3687         * source.c (print_source_lines_base): Handle requests to print
3688         reverse line number sequences, and guard against empty lines
3689         string.
3690
3691 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3692
3693         * source.c (print_source_lines_base): Fix skip of '\r' if next
3694         character is '\n'.
3695
3696 2019-01-06  Tom Tromey  <tom@tromey.com>
3697
3698         * c-exp.y (struct c_parse_state) <macro_original_text,
3699         expansion_obstack>: New member.
3700         (macro_original_text, expansion_obstack): Remove globals.
3701         (scan_macro_expansion, scanning_macro_expansion)
3702         (finished_macro_expansion): Update.
3703         (scan_macro_cleanup): Remove.
3704         (yylex, c_parse): Update.
3705
3706 2019-01-06  Tom Tromey  <tom@tromey.com>
3707
3708         * c-exp.y (struct c_parse_state) <strings>: New member.
3709         (operator_stoken): Update.
3710
3711 2019-01-06  Tom Tromey  <tom@tromey.com>
3712
3713         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3714         (union type_stack_elt) <typelist_val>: Now a pointer to
3715         std::vector.
3716         (type_stack_cleanup): Don't declare.
3717         (push_typelist): Update.
3718         * parse.c (pop_typelist): Return a std::vector.
3719         (push_typelist): Take a std::vector.
3720         (follow_types): Update.  Do not free args.
3721         (type_stack_cleanup): Remove.
3722         * c-exp.y (struct c_parse_state): New.
3723         (cpstate): New global.
3724         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3725         (nonempty_typelist): Update.
3726         (func_mod): Create a new vector.
3727         (c_parse): Create a c_parse_state.
3728         (check_parameter_typelist): Do not delete params.
3729         (function_method): Update.  Do not delete type_list.
3730
3731 2019-01-06  Tom Tromey  <tom@tromey.com>
3732
3733         PR gdb/28155:
3734         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3735         check_typedef.
3736         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3737         (print_return_value): Likewise.
3738
3739 2019-01-05  Tom Tromey  <tom@tromey.com>
3740
3741         * contrib/cleanup_check.py: Remove.
3742         * contrib/gcc-with-excheck: Remove.
3743         * contrib/exsummary.py: Remove.
3744         * contrib/excheck.py: Remove.
3745
3746 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3747
3748         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3749         NULL. Initialize tpprev to NULL instead of assigning it
3750         to NULL on the next statement.
3751         * windows-nat.c (windows_delete_thread): Remove check for
3752         main_thread_id before printing thread exit notifications.
3753         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3754         Remove thread ID check against main_thread_id.
3755         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3756         windows_delete_thread.
3757         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3758
3759 2019-01-04  Tom Tromey  <tom@tromey.com>
3760
3761         * compile/compile.c (_initialize_compile): Use upper case for
3762         metasyntactic variables.
3763         * symmisc.c (_initialize_symmisc): Use upper case for
3764         metasyntactic variables.
3765         * psymtab.c (_initialize_psymtab): Use upper case for
3766         metasyntactic variables.
3767         * demangle.c (demangle_command): Use upper case for metasyntactic
3768         variables.
3769         (_initialize_demangler): Likewise.
3770         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3771         variables.
3772
3773 2019-01-03  Tom Tromey  <tom@tromey.com>
3774
3775         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3776
3777 2019-01-03  Tom Tromey  <tom@tromey.com>
3778
3779         * python/py-symtab.c (salpy_str): Update.
3780         (struct salpy_sal_object) <symtab>: Now a PyObject.
3781         (salpy_dealloc): Update.
3782         (del_objfile_sal): Use gdbpy_ref.
3783
3784 2019-01-03  Tom Tromey  <tom@tromey.com>
3785
3786         * python/py-type.c (convert_field): Use new_reference.  Return
3787         gdbpy_ref.
3788         (make_fielditem): Return gdbpy_ref.
3789         (typy_fields): Update.
3790         (typy_getitem): Update.
3791         (field_name): Return gdbpy_ref.  Use new_reference.
3792         (typy_iterator_iternext): Update.
3793
3794 2019-01-03  Tom Tromey  <tom@tromey.com>
3795
3796         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3797
3798 2019-01-03  Tom Tromey  <tom@tromey.com>
3799
3800         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3801         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3802         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3803         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3804         (pspy_set_type_printers): Likewise.
3805         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3806         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3807         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3808         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3809         (objfpy_set_type_printers): Likewise.
3810
3811 2019-01-03  Tom Tromey  <tom@tromey.com>
3812
3813         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3814         (gdbpy_print_stack): Use gdbpy_err_fetch.
3815         * python/python-internal.h (class gdbpy_err_fetch): New class.
3816         (class gdbpy_enter) <m_error_type, m_error_value,
3817         m_error_traceback>: Remove.
3818         <m_error>: New member.
3819         (gdbpy_exception_to_string): Don't declare.
3820         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3821         * python/py-value.c (convert_value_from_python): Use
3822         gdbpy_err_fetch.
3823         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3824         gdbpy_exception_to_string.
3825         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3826         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3827         gdbpy_err_fetch.
3828
3829 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3830
3831         * linux-nat.c (delete_lwp_cleanup): Delete.
3832         (struct lwp_deleter): New struct.
3833         (lwp_info_up): New typedef.
3834         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3835         lwp_info_up.
3836
3837 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3838
3839         * linux-fork.c (class scoped_switch_fork_info): New class.
3840         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3841
3842 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3843
3844         * valops.c (find_overload_match): Remove use of null_cleanup, and
3845         calls to do_cleanups.
3846
3847 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3848
3849         * compile/compile-cplus-types.c
3850         (compile_cplus_instance::decl_name): Handle changes to
3851         cp_func_name.
3852         * cp-support.c (cp_func_name): Update header comment, update
3853         return type.
3854         * cp-support.h (cp_func_name): Update return type in declaration.
3855         * valops.c (find_overload_match): Move temp_func local to top
3856         level of function and change its type.  Use temp_func to hold and
3857         delete temporary string obtained from cp_func_name.
3858
3859 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3860
3861         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3862         gdb::char_vector, remove cleanup, and update uses of `msg`.
3863
3864 2019-01-03  Jim Wilson  <jimw@sifive.com>
3865
3866         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3867
3868 2019-01-02  Tom Tromey  <tom@tromey.com>
3869
3870         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3871         (tdesc_parse_xml): Remove cleanups.
3872         * target-descriptions.h (make_cleanup_free_target_description):
3873         Don't declare.
3874         (target_desc_deleter): New struct.
3875         (target_desc_up): New typedef.
3876         * target-descriptions.c (target_desc_deleter::operator()): Rename
3877         from free_target_description.
3878         (make_cleanup_free_target_description): Remove.
3879
3880 2019-01-02  Tom Tromey  <tom@tromey.com>
3881
3882         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3883         constructor, destructor.
3884         (linespec_parser): Remove typedef.
3885         (~linespec_parser): Rename from linespec_parser_delete.
3886         (linespec_lex_to_end, linespec_complete_label)
3887         (linespec_complete): Update.
3888         (decode_line_full): Remove cleanups.
3889         (decode_line_1): Update.
3890
3891 2019-01-02  Tom Tromey  <tom@tromey.com>
3892
3893         * python/python-internal.h (inferior_to_inferior_object): Change
3894         return type.
3895         * python/py-exitedevent.c (create_exited_event_object): Update.
3896         * python/py-inferior.c (inferior_to_inferior_object): Return
3897         gdbpy_ref.
3898         (python_new_inferior, python_inferior_deleted)
3899         (thread_to_thread_object, delete_thread_object)
3900         (build_inferior_list, gdbpy_selected_inferior): Update.
3901         * python/py-infthread.c (create_thread_object): Update.  Also fail
3902         if inferior_to_inferior_object fails.
3903
3904 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3905
3906         * inferior.h (class inferior) <displaced_step_state>: New field.
3907         * infrun.h (struct displaced_step_state): Move here from
3908         infrun.c.  Initialize fields, add constructor.
3909         <inf>: Remove field.
3910         <reset>: New method.
3911         * infrun.c (struct displaced_step_inferior_state): Move to
3912         infrun.h.
3913         (displaced_step_inferior_states): Remove.
3914         (get_displaced_stepping_state): Adust.
3915         (displaced_step_in_progress_any_inferior): Adjust.
3916         (displaced_step_in_progress_thread): Adjust.
3917         (displaced_step_in_progress): Adjust.
3918         (add_displaced_stepping_state): Remove.
3919         (get_displaced_step_closure_by_addr): Adjust.
3920         (remove_displaced_stepping_state): Remove.
3921         (infrun_inferior_exit): Call displaced_step_state.reset.
3922         (use_displaced_stepping): Don't check for NULL.
3923         (displaced_step_prepare_throw): Call
3924         get_displaced_stepping_state.
3925         (displaced_step_fixup): Don't check for NULL.
3926         (prepare_for_detach): Don't check for NULL.
3927
3928 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3929
3930         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3931          in case of call that did not complete.
3932
3933 2019-01-02  Andrey Utkin  <autkin@undo.io>
3934
3935         * symfile.c (find_separate_debug_file): Fix search of debug files for
3936         remote debuggee.
3937
3938 2019-01-02  Tom Tromey  <tom@tromey.com>
3939
3940         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3941         indentation.
3942         * python/py-frame.c (frapy_older): Remove cast.
3943         (frapy_newer): Likewise.
3944         * python/py-breakpoint.c (local_setattro): Remove cast.
3945         * python/py-arch.c (archpy_name): Remove local variable.
3946         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3947
3948 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3949
3950         * unittests/basic_string_view/element_access/char/empty.cc:
3951         Fix year range in copyright header.
3952
3953 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3954
3955         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3956         Delete.
3957         <operator==>: Update with for removed field.
3958         <hash>: Likewise.
3959         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3960         <isa_features>: ...this.
3961         <abi_features>: New field.
3962         (riscv_isa_flen): Update comment.
3963         (riscv_abi_xlen): New declaration.
3964         (riscv_abi_flen): New declaration.
3965         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3966         isa_features.
3967         (riscv_abi_xlen): New function.
3968         (riscv_isa_flen): Update to get answer from isa_features.
3969         (riscv_abi_flen): New function.
3970         (riscv_has_fp_abi): Update to get answer from abi_features.
3971         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3972         xlen and flen.
3973         (riscv_call_info) <xlen, flen>: Update comment.
3974         (riscv_call_arg_struct): Remove invalid assertions
3975         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3976         is removed.
3977         (riscv_gdbarch_init): Gather isa features and abi features
3978         separately, ensure both match on the gdbarch when reusing an old
3979         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3980         a target with 64-bit float hardware.
3981
3982 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3983
3984         * source.c (search_command_helper): Stop reverse search
3985         when line 1 has been searched.
3986
3987 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3988
3989         * record-full.c (record_full_base_target::close): Rewrite
3990         record_full_core_buf_list free logic.
3991
3992 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3993
3994         * break-catch-syscall.c (print_one_catch_syscall): xfree
3995         the last text.
3996
3997 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3998
3999         * top.c (print_gdb_version): Update Copyright year in version
4000         message.
4001
4002 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4003
4004         Update copyright year range in all GDB files.
4005
4006 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4007
4008         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4009
4010 For older changes see ChangeLog-2018.
4011 \f
4012 Local Variables:
4013 mode: change-log
4014 left-margin: 8
4015 fill-column: 74
4016 version-control: never
4017 coding: utf-8
4018 End:
4019