gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui.c: Update.
   4         * tui/tui-source.h (struct tui_source_window): Move from
   5         tui-data.h.
   6         * tui/tui-layout.c: Update.
   7         * tui/tui-disasm.c: Update.
   8         * tui/tui-data.h (struct tui_source_window): Move to
   9         tui-source.h.
  10
  11 2019-07-17  Tom Tromey  <tom@tromey.com>
  12
  13         * tui/tui-disasm.h (struct tui_disasm_window): Move from
  14         tui-data.h.
  15         * tui/tui-data.h (struct tui_disasm_window): Move to
  16         tui-disasm.h.
  17
  18 2019-07-17  Tom Tromey  <tom@tromey.com>
  19
  20         * tui/tui-regs.h (struct tui_data_item_window): Move from
  21         tui-data.h.
  22         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
  23         * tui/tui-data.h (struct tui_data_item_window): Move to
  24         tui-regs.h.
  25         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
  26
  27 2019-07-17  Tom Tromey  <tom@tromey.com>
  28
  29         * tui/tui.c: Update.
  30         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
  31         (tui_cmd_window::max_height): Move to tui-command.c.
  32         * tui/tui-layout.c: Update.
  33         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
  34         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
  35         tui-command.c.
  36         * tui/tui-command.h (struct tui_cmd_window): Move from
  37         tui-data.h.
  38         * tui/tui-command.c: Remove "structuring" comments.
  39         (tui_cmd_window::clear_detail)
  40         (tui_cmd_window::do_make_visible_with_new_height)
  41         (tui_cmd_window::max_height): Move from elsewhere.
  42
  43 2019-07-17  Tom Tromey  <tom@tromey.com>
  44
  45         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
  46         Now static.
  47         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
  48         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
  49
  50 2019-07-17  Tom Tromey  <tom@tromey.com>
  51
  52         * tui/tui.c: Update.
  53         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
  54         tui-regs.c.
  55         * tui/tui-windata.h: Remove file.
  56         * tui/tui-windata.c: Remove file.
  57         * tui/tui-win.c (tui_data_window::set_new_height)
  58         (tui_data_window::do_make_visible_with_new_height): Move to
  59         tui-regs.c.
  60         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
  61         * tui/tui-regs.c: Remove "structuring" comments.
  62         (tui_data_window::first_data_item_displayed)
  63         (tui_data_window::delete_data_content_windows)
  64         (tui_data_window::erase_data_content)
  65         (tui_data_window::display_all_data)
  66         (tui_data_window::refresh_all)
  67         (tui_data_window::do_scroll_vertical)
  68         (tui_data_window::clear_detail, tui_data_window::set_new_height)
  69         (tui_data_window::do_make_visible_with_new_height)
  70         (tui_data_window::refresh_window): Move from elsewhere.
  71         (_initialize_tui_regs): Move to end of file.
  72         * tui/tui-layout.c: Update.
  73         * tui/tui-hooks.c: Update.
  74         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
  75         * tui/tui-data.c (tui_data_window::clear_detail): Move to
  76         tui-regs.c.
  77         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
  78
  79 2019-07-17  Tom Tromey  <tom@tromey.com>
  80
  81         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
  82         seen.
  83
  84 2019-07-17  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-win.c (tui_source_window_base::set_new_height)
  87         (tui_source_window_base::do_make_visible_with_new_height): Use
  88         m_has_locator field directly.
  89         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
  90         method.
  91         (struct tui_source_window_base) <has_locator>: Likewise.
  92
  93 2019-07-17  Tom Tromey  <tom@tromey.com>
  94
  95         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
  96         Don't declare.
  97         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
  98         Remove.
  99         * tui/tui-win.c (tui_source_window_base::set_new_height)
 100         (tui_source_window_base::set_new_height)
 101         (make_invisible_and_set_new_height)
 102         (tui_source_window_base::do_make_visible_with_new_height)
 103         (tui_source_window_base::do_make_visible_with_new_height):
 104         Update.
 105         * tui/tui-layout.c (show_source_disasm_command, show_data)
 106         (show_source_or_disasm_and_command): Update.
 107         * tui/tui-layout.c (show_layout): Update.
 108
 109 2019-07-17  Tom Tromey  <tom@tromey.com>
 110
 111         * tui/tui-layout.c (make_data_window): Remove.
 112         (show_data): Unify creation and re-initialization cases.
 113
 114 2019-07-17  Tom Tromey  <tom@tromey.com>
 115
 116         * tui/tui-layout.c (make_source_window, make_disasm_window):
 117         Remove.
 118         (show_data): Unify creation and re-initialization cases.
 119
 120 2019-07-17  Tom Tromey  <tom@tromey.com>
 121
 122         * tui/tui-layout.c (make_command_window): Remove.
 123         (show_source_disasm_command, show_source_or_disasm_and_command):
 124         Unify creation and re-initialization cases.
 125
 126 2019-07-17  Tom Tromey  <tom@tromey.com>
 127
 128         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 129         creation and re-initialization cases.
 130
 131 2019-07-17  Tom Tromey  <tom@tromey.com>
 132
 133         * tui/tui-regs.c (tui_get_register): Return void.
 134
 135 2019-07-17  Tom Tromey  <tom@tromey.com>
 136
 137         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 138         Simplify.
 139
 140 2019-07-17  Tom Tromey  <tom@tromey.com>
 141
 142         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 143         resetting.
 144
 145 2019-07-17  Tom Tromey  <tom@tromey.com>
 146
 147         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 148         * tui/tui-regs.c (tui_reg_layout): New function.
 149         (tui_show_registers, tui_reg_command): Use it.
 150         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 151         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 152         parameters.
 153         (tui_layout_command): Remove.
 154
 155 2019-07-17  Tom Tromey  <tom@tromey.com>
 156
 157         * tui/tui-layout.h (tui/tui-layout): Return void.
 158         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 159
 160 2019-07-17  Tom Tromey  <tom@tromey.com>
 161
 162         * tui/tui-layout.c (show_source_disasm_command, show_data):
 163         Update.
 164         (reset_locator): Remove.
 165         (show_source_or_disasm_and_command): Update.
 166
 167 2019-07-17  Tom Tromey  <tom@tromey.com>
 168
 169         * tui/tui-source.c (tui_source_window_base::reset): Remove
 170         win_type parameter.
 171         * tui/tui-layout.c (make_command_window, make_source_window)
 172         (make_disasm_window, make_data_window)
 173         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 174         (reset_locator, show_source_or_disasm_and_command): Update.
 175         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 176         win_type parameter.
 177         (struct tui_source_window_base) <reset>: Likewise.
 178
 179 2019-07-17  Tom Tromey  <tom@tromey.com>
 180
 181         * tui/tui-layout.c (show_source_disasm_command): Use
 182         reset_locator.
 183         (reset_locator): New function.
 184         (init_and_make_win): Remove.
 185         (show_source_or_disasm_and_command): Use reset_locator.
 186
 187 2019-07-17  Tom Tromey  <tom@tromey.com>
 188
 189         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 190         condition.
 191         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 192         Remove condition.
 193         * tui/tui-source.c (tui_source_window_base::reset): New method.
 194         * tui/tui-layout.c (make_command_window): Don't call
 195         init_and_make_win.
 196         (make_source_window, make_disasm_window): Don't call
 197         make_source_or_disasm_window.
 198         (make_data_window): Don't call init_and_make_win.  Change calling
 199         convention.
 200         (show_source_disasm_command, show_data): Simplify.
 201         (make_source_or_disasm_window): Remove.
 202         (show_source_or_disasm_and_command): Simplify.
 203         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 204         (struct tui_source_window_base) <reset>: Likewise.
 205         <execution_info>: Remove initializer.
 206         * tui/tui-data.c (tui_source_window_base): Initialize
 207         execution_info.
 208
 209 2019-07-17  Tom Tromey  <tom@tromey.com>
 210
 211         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 212         variable.
 213
 214 2019-07-17  Tom Tromey  <tom@tromey.com>
 215
 216         * tui/tui.c (tui_rl_other_window): Update.
 217         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 218         superclass method first.  Always iterate over regs_content.
 219         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 220         method.
 221         * tui/tui-win.c (tui_set_focus_command): Update.
 222
 223 2019-07-17  Tom Tromey  <tom@tromey.com>
 224
 225         * tui/tui-win.c (tui_set_focus_command): Rename from
 226         tui_set_focus.  Call tui_enable.
 227         (tui_set_focus_command): Remove.
 228
 229 2019-07-17  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 232         refresh_window.
 233         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 234         touchwin.
 235         (tui_data_window::refresh_window): Call refresh_window on data
 236         items.  Always call superclass refresh_window.
 237         (tui_win_info::refresh): Remove.
 238         (tui_source_window_base::refresh_window): Update.
 239         (tui_refresh_all): Update.
 240         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 241         refresh_window.
 242         (show_source_or_disasm_and_command): Likewise.
 243         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 244         (struct tui_source_window_base) <refresh>: Likewise.
 245
 246 2019-07-17  Tom Tromey  <tom@tromey.com>
 247
 248         * tui/tui-winsource.c (tui_clear_source_content)
 249         (tui_show_source_content): Update.
 250         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 251         whether content is empty.
 252         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 253         Remove.
 254
 255 2019-07-17  Tom Tromey  <tom@tromey.com>
 256
 257         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 258         window's contents.
 259         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 260         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 261
 262 2019-07-17  Tom Tromey  <tom@tromey.com>
 263
 264         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 265         (struct tui_data_item_window): Update.
 266
 267 2019-07-17  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 270         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 271         defines.
 272
 273 2019-07-17  Tom Tromey  <tom@tromey.com>
 274
 275         * tui/tui-winsource.h (tui_erase_source_content)
 276         (tui_clear_source_content): Remove "display_prompt" parameter.
 277         * tui/tui-winsource.c (tui_update_source_window_as_is)
 278         (tui_update_source_windows_with_addr): Update.
 279         (tui_clear_source_content): Remove "display_prompt" parameter.
 280         (tui_erase_source_content): Likewise.  Simplify.
 281         (tui_show_source_content): Update.
 282         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 283         * tui/tui-stack.c (tui_show_frame_info): Update.
 284         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 285         Remove defines.
 286
 287 2019-07-17  Tom Tromey  <tom@tromey.com>
 288
 289         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 290         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 291         parameter.
 292         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 293         parameter.
 294
 295 2019-07-17  Tom Tromey  <tom@tromey.com>
 296
 297         * tui/tui-winsource.c (tui_clear_source_content)
 298         (tui_show_source_content, tui_show_exec_info_content)
 299         (tui_clear_exec_info_content): Update.
 300         * tui/tui-stack.c (tui_show_locator_content): Update.
 301         (tui_show_frame_info): Update.
 302         * tui/tui-source.h (tui_source_window): Don't declare.
 303         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 304         from tui_source_is_displayed.
 305         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 306         Remove field.
 307         (struct tui_source_window_base) <content_in_use>: New field.  Now
 308         bool.
 309         (struct tui_source_window) <showing_source_p>: New method.
 310         (TUI_SRC_WIN): Change cast.
 311         * tui/tui-data.c (tui_initialize_static_data): Update.
 312
 313 2019-07-17  Tom Tromey  <tom@tromey.com>
 314
 315         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 316         location_matches_p.
 317         * tui/tui-source.c (tui_source_window::location_matches_p): New
 318         method.
 319         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 320         method.
 321         * tui/tui-data.h (struct tui_source_window_base)
 322         <location_matches_p>: New method.
 323         (struct tui_source_window, struct tui_disasm_window)
 324         <location_matches_p>: Likewise.
 325
 326 2019-07-17  Tom Tromey  <tom@tromey.com>
 327
 328         * tui/tui-win.c (tui_set_win_height_command): Rename from
 329         tui_set_win_height.
 330         (tui_set_win_height_command): Remove.
 331
 332 2019-07-17  Tom Tromey  <tom@tromey.com>
 333
 334         * tui/tui-source.c (tui_source_window): New constructor.  Add
 335         observer.
 336         (~tui_source_window): New destructor.
 337         (tui_source_window::style_changed): New method.
 338         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 339         (tui_attach_detach_observers): Update.
 340         * tui/tui-data.h (struct tui_source_window): Make constructor not
 341         inline.  Add destructor.
 342         (struct tui_source_window) <style_changed>: New method.
 343         <m_observable>: New member.
 344
 345 2019-07-17  Tom Tromey  <tom@tromey.com>
 346
 347         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 348         * tui/tui-win.c (tui_resize_all): Fix typo.
 349
 350 2019-07-17  Tom Tromey  <tom@tromey.com>
 351
 352         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 353         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 354         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 355         * tui/tui-win.c (window_name_completer): Use foreach.
 356         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 357         (update_tab_width): Likewise.
 358         * tui/tui-layout.c (show_layout): Update.
 359         * tui/tui-data.h (class tui_window_iterator): New.
 360         (struct all_tui_windows): New.
 361         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 362
 363 2019-07-17  Tom Tromey  <tom@tromey.com>
 364
 365         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 366         parameter.  Don't reference globals.
 367         (tui_reg_command): Update.
 368
 369 2019-07-17  Tom Tromey  <tom@tromey.com>
 370
 371         * tui/tui-regs.c (tui_show_registers): Simplify.
 372
 373 2019-07-17  Tom Tromey  <tom@tromey.com>
 374
 375         * tui/tui-regs.c (tui_show_registers): Update.
 376         (tui_show_register_group): Add win_info parameter.
 377
 378 2019-07-17  Tom Tromey  <tom@tromey.com>
 379
 380         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 381         Rename from tui_display_reg_element_at_line.
 382         (tui_data_window::display_registers_from_line): Update.
 383         * tui/tui-data.h (struct tui_data_window)
 384         <display_reg_element_at_line>: New method.
 385
 386 2019-07-17  Tom Tromey  <tom@tromey.com>
 387
 388         * tui/tui-regs.h (tui_display_registers_from)
 389         (tui_display_registers_from_line): Don't declare.
 390         * tui/tui-windata.c (tui_data_window::display_all_data)
 391         (tui_data_window::refresh_all)
 392         (tui_data_window::do_scroll_vertical): Update.
 393         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 394         from tui_display_registers_from.
 395         (tui_display_reg_element_at_line): Update.
 396         (tui_data_window::display_registers_from_line): Rename from
 397         tui_display_registers_from_line.
 398         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 399         display_registers_from_line>: New methods.
 400
 401 2019-07-17  Tom Tromey  <tom@tromey.com>
 402
 403         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 404         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 405         from tui_erase_data_content.
 406         (tui_data_window::display_all_data)
 407         (tui_data_window::refresh_all)
 408         (tui_data_window::do_scroll_vertical): Update.
 409         * tui/tui-regs.c (tui_show_registers): Update.
 410         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 411         New method.
 412
 413 2019-07-17  Tom Tromey  <tom@tromey.com>
 414
 415         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 416         declare.
 417         * tui/tui-windata.c
 418         (tui_data_window::delete_data_content_windows): Rename from
 419         tui_delete_data_content_windows.
 420         (tui_data_window::display_all_data)
 421         (tui_data_window::do_scroll_vertical): Update.
 422         * tui/tui-data.h (struct tui_data_window)
 423         <delete_data_content_windows>: New method.
 424
 425 2019-07-17  Tom Tromey  <tom@tromey.com>
 426
 427         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 428         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 429
 430 2019-07-17  Tom Tromey  <tom@tromey.com>
 431
 432         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 433         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 434         from tui_display_all_data.
 435         * tui/tui-win.c
 436         (tui_data_window::do_make_visible_with_new_height): Update.
 437         * tui/tui-regs.c (tui_show_registers): Update.
 438         * tui/tui-layout.c (tui_set_layout): Update.
 439         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 440         method.
 441
 442 2019-07-17  Tom Tromey  <tom@tromey.com>
 443
 444         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 445         * tui/tui-windata.c (tui_display_data_from): Remove.
 446         (tui_data_window::refresh_all): Update.
 447
 448 2019-07-17  Tom Tromey  <tom@tromey.com>
 449
 450         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 451         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 452         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 453         tui_display_registers_from_line.
 454         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 455         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 456         "force_display" parameter.
 457
 458 2019-07-17  Tom Tromey  <tom@tromey.com>
 459
 460         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 461         declare.
 462         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 463         Rename from tui_first_reg_element_no_inline.
 464         (tui_display_reg_element_at_line)
 465         (tui_display_registers_from_line): Update.
 466         * tui/tui-data.h (struct tui_data_window)
 467         <first_reg_element_no_inline>: New method.
 468
 469 2019-07-17  Tom Tromey  <tom@tromey.com>
 470
 471         * tui/tui-windata.c (tui_display_data_from)
 472         (tui_data_window::do_scroll_vertical): Update.
 473         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 474         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 475         Rename from tui_line_from_reg_element_no.
 476         (tui_display_registers_from_line): Update.
 477         * tui/tui-data.h (struct tui_data_window)
 478         <line_from_reg_element_no>: New method.
 479
 480 2019-07-17  Tom Tromey  <tom@tromey.com>
 481
 482         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 483         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 484         tui_last_regs_line_no.
 485         (tui_display_reg_element_at_line)
 486         (tui_display_registers_from_line): Update.
 487         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 488         method.
 489
 490 2019-07-17  Tom Tromey  <tom@tromey.com>
 491
 492         PR tui/24722:
 493         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 494         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 495         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 496         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 497         (tui_update_breakpoint_info): Likewise.
 498         * tui/tui-hooks.c (tui_event_create_breakpoint)
 499         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 500         Update.
 501
 502 2019-07-17  Tom Tromey  <tom@tromey.com>
 503
 504         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 505
 506 2019-07-17  Tom Tromey  <tom@tromey.com>
 507
 508         * tui/tui-winsource.c (tui_update_source_window_as_is)
 509         (tui_update_source_windows_with_addr): Update.
 510         * tui/tui-source.h (tui_set_source_content)
 511         (tui_show_symtab_source): Add "win_info" parameter.
 512         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 513         parameter.
 514         (tui_show_symtab_source): Likewise.
 515
 516 2019-07-17  Tom Tromey  <tom@tromey.com>
 517
 518         * tui/tui-wingeneral.c
 519         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 520
 521 2019-07-17  Tom Tromey  <tom@tromey.com>
 522
 523         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 524         (struct tui_cmd_window) <can_scroll>: New method.
 525         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 526         method.
 527
 528 2019-07-17  Tom Tromey  <tromey@adacore.com>
 529
 530         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 531         do_field_signed>: Rename.  Change type of "value".
 532         * ui-out.c (ui_out::field_signed): Rename from field_int.
 533         Change type of "value".
 534         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 535         type of "value".
 536         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 537         do_field_int.  Change type of "value".
 538         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 539         do_field_int.  Change type of "value".
 540         * tracepoint.c (trace_status_mi, tfind_1)
 541         (print_one_static_tracepoint_marker): Update.
 542         * thread.c (print_thread_info_1, print_selected_thread_frame):
 543         Update.
 544         * stack.c (print_frame, print_frame_info): Update.
 545         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 546         Update.
 547         * source.c (print_source_lines_base): Update.
 548         * skip.c (info_skip_command): Update.
 549         * record-btrace.c (btrace_ui_out_decode_error)
 550         (btrace_call_history_src_line): Update.
 551         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 552         Update.
 553         * progspace.c (print_program_space): Update.
 554         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 555         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 556         do_field_int.  Change type of "value".
 557         * mi/mi-out.c (mi_ui_out::do_table_begin)
 558         (mi_ui_out::do_table_header): Update.
 559         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 560         type of "value".
 561         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 562         (mi_cmd_data_list_changed_registers, output_register)
 563         (mi_cmd_data_read_memory, mi_load_progress)
 564         (mi_cmd_trace_frame_collected): Update.
 565         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 566         Update.
 567         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 568         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 569         (mi_cmd_var_list_children, varobj_update_one): Update.
 570         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 571         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 572         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 573         * inferior.c (print_inferior): Update.
 574         * gdb_bfd.c (print_one_bfd): Update.
 575         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 576         Update.
 577         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 578         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 579         do_field_int.  Change type of "value".
 580         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 581         do_field_int.  Change type of "value".
 582         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 583         (print_one_breakpoint_location, print_it_catch_fork)
 584         (print_one_catch_fork, print_it_catch_vfork)
 585         (print_one_catch_vfork, print_it_catch_solib)
 586         (print_it_catch_exec, print_it_ranged_breakpoint)
 587         (print_mention_watchpoint, print_mention_masked_watchpoint)
 588         (bkpt_print_it, update_static_tracepoint): Update.
 589         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 590         * break-catch-syscall.c (print_it_catch_syscall): Update.
 591         * ada-tasks.c (print_ada_task_info): Update.
 592         * ada-lang.c (print_it_exception, print_mention_exception):
 593         Update.
 594
 595 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 596
 597         PR breakpoints/24541
 598         * gdbarch.c: Regenerate.
 599         * gdbarch.h: Regenerate.
 600         * gdbarch.sh: Adjust return type and parameter types for
 601         'stap_adjust_register'.
 602         (i386_stap_adjust_register): Adjust signature and return new
 603         register name.
 604         * stap-probe.c (stap_parse_register_operand): Adjust use of
 605         'gdbarch_stap_adjust_register'.
 606
 607 2019-07-17  Tom Tromey  <tromey@adacore.com>
 608
 609         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 610         declare VEC.
 611         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 612         std::vector.
 613         (struct s390_process_info): Add initializers.
 614         (s390_add_process): Use new.
 615         (s390_linux_nat_target::low_forget_process): Use delete.
 616         (s390_linux_nat_target::low_new_fork)
 617         (s390_linux_nat_target::stopped_by_watchpoint)
 618         (s390_linux_nat_target::low_prepare_to_resume)
 619         (s390_linux_nat_target::insert_watchpoint)
 620         (s390_linux_nat_target::insert_hw_breakpoint)
 621         (s390_linux_nat_target::remove_watchpoint)
 622         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 623
 624 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 625
 626         * aarch64-fbsd-nat.c: Include regcache.h.
 627         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 628         argument.
 629         (aarch64_fbsd_nat_target::fetch_registers)
 630         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 631         variable.
 632         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 633
 634 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 635
 636         * fbsd-nat.c: Include gdbarch.h.
 637
 638 2019-07-15  Tom Tromey  <tromey@adacore.com>
 639
 640         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 641
 642 2019-07-15  Tom Tromey  <tromey@adacore.com>
 643
 644         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 645         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 646         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 647         * cli-out.c (cli_ui_out::do_field_int): New method.
 648         * ui-out.c (ui_out::field_unsigned): New method.
 649         * symfile.c (generic_load): Use field_unsigned.
 650         (print_transfer_performance): Likewise.
 651         * record-btrace.c (ui_out_field_uint): Remove.
 652         (btrace_call_history_insn_range, btrace_call_history): Use
 653         field_unsigned.
 654         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 655         field_unsigned.
 656         * ui-out.h (class ui_out) <field_unsigned>: New method.
 657         <do_field_unsigned>: Likewise.
 658
 659 2019-07-15  Tom Tromey  <tromey@adacore.com>
 660
 661         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 662         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 663         * target.c (flash_erase_command): Use field_string.
 664         * infrun.c (print_signal_received_reason): Use field_string.
 665         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 666         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 667         field_string.
 668         * ada-tasks.c (print_ada_task_info): Use field_string.
 669
 670 2019-07-15  Tom Tromey  <tromey@adacore.com>
 671
 672         * target.c (flash_erase_command): Use field_core_addr.
 673         * symfile.c (generic_load): Use field_core_addr.
 674         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 675         Use field_core_addr.
 676         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 677         field_core_addr.
 678
 679 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 680
 681         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 682         value if its desired type is smaller than a CORE_ADDR and signed.
 683
 684 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 685
 686         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 687         of changes to field names, and use new is_reference field to
 688         decide if a property is a reference or not.
 689         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 690         field.
 691         (struct dwarf2_property_baton): Update header comment, rename
 692         'referenced_type' to 'property_type' and update comments.
 693         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 694         default property type, store in property baton, update to take
 695         accound of renamed field.
 696         (read_func_scope): Update call to attr_to_dynamic_prop.
 697         (read_array_type): Likewise.
 698         (dwarf2_per_cu_addr_sized_int_type): New function.
 699         (read_subrange_index_type): Move type finding code to
 700         dwarf2_per_cu_addr_sized_int_type.
 701         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 702         (dwarf2_per_cu_addr_type): New function.
 703         (set_die_type): Update calls to attr_to_dynamic_prop.
 704
 705 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 706
 707         * dwarf2read.c (read_subrange_index_type): New function.
 708         (read_subrange_type): Move code into new function and call it.
 709         * gdbtypes.c (create_range_type): Add some asserts.
 710
 711 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 712
 713         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 714         update return statements.
 715         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 716         declaration, and update comment to match.
 717         * gdbtypes.c (resolve_dynamic_array): Update call to
 718         dwarf2_evaluate_property to match new return type.
 719
 720 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 721
 722         * valarith.c (value_subscripted_rvalue): Change lowerbound
 723         parameter type from int to LONGEST.
 724         * value.h (value_subscripted_rvalue): Likewise in declaration.
 725
 726 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 727
 728         * cli/cli-utils.c (info_print_command_completer): New function.
 729         * cli/cli-utils.h: Add 'completer.h' include, and forward
 730         declaration for 'struct cmd_list_element'.
 731         (info_print_command_completer): Declare.
 732         * stack.c (_initialize_stack): Add completer for 'info locals' and
 733         'info args'.
 734         * symtab.c (_initialize_symtab): Add completer for 'info
 735         variables' and 'info functions'.
 736         * NEWS: Mention completion for additional info commands.
 737
 738 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 739
 740         * cli/cli-utils.c (extract_info_print_args): Delete.
 741         (extract_arg_maybe_quoted): Delete.
 742         (info_print_options_defs): New variable.
 743         (make_info_print_options_def_group): New function.
 744         (extract_info_print_options): Define new function.
 745         * cli/cli-utils.h (extract_info_print_args): Delete.
 746         (struct info_print_options): New structure.
 747         (extract_info_print_options): Declare new function.
 748         * stack.c (info_locals_command): Update to use new
 749         extract_info_print_options, also add a header comment.
 750         (info_args_command): Likewise.
 751         * symtab.c (info_variables_command): Likewise.
 752         (info_functions_command): Likewise.
 753
 754 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 755
 756         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 757         to extract string arguments.
 758         * common/common-utils.c (extract_string_maybe_quoted): New function.
 759         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 760
 761 2019-07-11  Tom Tromey  <tromey@adacore.com>
 762
 763         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 764         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 765         * top.h (gdbinit): Don't declare.
 766         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 767         into...
 768         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 769         * top.c (gdb_init): Don't call init_cli_cmds.
 770         (gdbinit): Remove.
 771         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 772
 773 2019-07-11  Tom Tromey  <tromey@adacore.com>
 774
 775         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 776         after it has been moved.
 777
 778 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 779
 780         * valops.c (value_must_coerce_to_target): Change return type to
 781         bool.
 782         * value.h (value_must_coerce_to_target): Likewise.
 783
 784 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 785
 786         * breakpoint.c (is_hardware_watchpoint): Remove
 787         forward-declaration.
 788         (is_masked_watchpoint): Change return type to bool.
 789         (is_tracepoint): Likewise.
 790         (is_breakpoint): Likewise.
 791         (is_hardware_watchpoint): Likewise.
 792         (is_watchpoint): Likewise.
 793         (is_no_memory_software_watchpoint): Likewise.
 794         (is_catchpoint): Likewise.
 795         (breakpoint_1): Make FILTER parameter's return type bool.
 796         is_masked_watchpoint): Change return type to bool.
 797         (save_breakpoints): Make FILTER parameter's return type bool.
 798         * breakpoint.h (is_breakpoint): Change return type to bool.
 799         (is_watchpoint): Likewise.
 800         (is_catchpoint): Likewise.
 801         (is_tracepoint): Likewise.
 802
 803 2019-07-10  Tom Tromey  <tom@tromey.com>
 804
 805         * defs.h: Don't include gdbarch.h.
 806         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 807         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 808         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 809         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 810         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 811         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 812         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 813         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 814         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 815         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 816         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 817         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 818         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 819         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 820         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 821         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 822         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 823         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 824         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 825         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 826         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 827         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 828         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 829         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 830         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 831         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 832         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 833
 834 2019-07-10  Tom Tromey  <tromey@adacore.com>
 835
 836         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 837         * breakpoint.c (init_ada_exception_breakpoint): Register as
 838         bp_catchpoint.
 839         (print_one_breakpoint_location, print_one_breakpoint): Use
 840         is_ada_exception_catchpoint.
 841         * ada-lang.c (class ada_catchpoint_location): Pass
 842         bp_loc_software_breakpoint to bp_location constructor.
 843         (is_ada_exception_catchpoint): New function.
 844
 845 2019-07-10  Tom Tromey  <tromey@adacore.com>
 846
 847         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 848         VEC.
 849         (struct arm_exidx_entry): New method operator<.
 850         (struct arm_exidx_data) <section_maps>: Change type.
 851         (arm_exidx_data_free): Remove.
 852         (arm_exidx_data_key): Change type.  Move lower.
 853         (arm_exidx_new_objfile): Update.
 854         (arm_compare_exidx_entries): Remove.
 855         (arm_find_exidx_entry, _initialize_arm_tdep)
 856
 857 2019-07-10  Tom Tromey  <tromey@adacore.com>
 858
 859         * solib-spu.c (ocl_program_data_key): Change type.
 860         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 861         Update.
 862
 863 2019-07-10  Tom Tromey  <tromey@adacore.com>
 864
 865         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 866         (struct solib_aix_inferior_data) <library_list>: Change type.
 867         (solib_aix_inferior_data_handle): Change type.
 868         (get_solib_aix_inferior_data): Update.
 869         (solib_aix_free_library_list): Remove.
 870         (library_list_start_library): Update.
 871         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 872         return type.
 873         (solib_aix_get_library_list)
 874         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 875         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 876
 877 2019-07-10  Tom Tromey  <tromey@adacore.com>
 878
 879         * solib-dsbt.c (struct dsbt_info): Add initializers.
 880         (solib_dsbt_pspace_data): Change type.
 881         (dsbt_pspace_data_cleanup): Remove.
 882         (get_dsbt_info, _initialize_dsbt_solib): Update.
 883
 884 2019-07-10  Tom Tromey  <tromey@adacore.com>
 885
 886         * spu-tdep.c (spu_overlay_data): Change type.
 887         (spu_get_overlay_table, spu_overlay_new_objfile)
 888         (_initialize_spu_tdep): Update.
 889
 890 2019-07-10  Tom Tromey  <tromey@adacore.com>
 891
 892         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 893         destructor.
 894         (dbx_objfile_data_key): Change type and declare later.
 895         (DBX_SYMFILE_INFO): Rewrite.
 896         * dbxread.c (dbx_objfile_data_key): Change type.
 897         (dbx_symfile_init): Update.
 898         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 899         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 900         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 901
 902 2019-07-10  Tom Tromey  <tromey@adacore.com>
 903
 904         * jit.c (jit_program_space_key): Change type.  Move lower.
 905         (get_jit_program_space_data): Update.
 906         (jit_program_space_data_cleanup): Remove.
 907         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 908         Update.
 909         (struct jit_program_space_data): Add initializers.
 910
 911 2019-07-10  Tom Tromey  <tromey@adacore.com>
 912
 913         * solib-darwin.c (struct darwin_info): Add initializers.
 914         (solib_darwin_pspace_data): Change type.
 915         (darwin_pspace_data_cleanup): Remove.
 916         (get_darwin_info, _initialize_darwin_solib): Update.
 917
 918 2019-07-10  Tom Tromey  <tromey@adacore.com>
 919
 920         * remote-sim.c (struct sim_inferior_data): Add initializers,
 921         constructor, and destructor.
 922         (sim_inferior_data_key): Change type.  Move lower.
 923         (check_for_duplicate_sim_descriptor): Update.
 924         (get_sim_inferior_data): Use new.  Update.
 925         (~sim_inferior_data_cleanup): Rename from
 926         sim_inferior_data_cleanup.  Simplify.
 927         (gdbsim_close_inferior, simulator_command)
 928         (sim_command_completer, _initialize_remote_sim): Update.
 929         (next_pid, INITIAL_PID): Move earlier.
 930
 931 2019-07-10  Tom Tromey  <tromey@adacore.com>
 932
 933         * python/python-internal.h (create_thread_object): Return
 934         gdbpy_ref.
 935         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 936         * python/py-inferior.c (struct threadlist_entry): Add
 937         constructor.
 938         <thread_obj>: Now a gdbpy_ref.
 939         (thread_to_thread_object): Update.
 940         (add_thread_object): Use new.
 941         (delete_thread_object): Use delete.
 942         (infpy_threads): Update.
 943         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 944         GIL.
 945
 946 2019-07-10  Tom Tromey  <tromey@adacore.com>
 947
 948         * valops.c (value_cast): Specialize error message for Ada.
 949
 950 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 951
 952         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 953
 954 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 955
 956         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 957         bpstat_should_step): Return bool, adjust comments.
 958         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 959         bpstat_should_step): Likewise.
 960
 961 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 962
 963         * features/Makefile: Use feature target descriptions for Arm.
 964         * features/arm/arm-core.c: Generate new file.
 965         * features/arm/arm-fpa.c: Likewise.
 966         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 967         * features/arm/arm-m-profile.c: Likewise.
 968         * features/arm/arm-vfpv2.c: Likewise.
 969         * features/arm/arm-vfpv3.c: Likewise.
 970         * features/arm/xscale-iwmmxt.c: Likewise.
 971         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 972
 973 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 974
 975         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 976         ptrace earlier.
 977
 978 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 979
 980         * features/aarch64-pauth.c: Regenerate.
 981
 982 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 983
 984         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 985         bool.
 986         (bpstat_what): Use false instead of 0.
 987
 988 2019-07-09  Pedro Alves  <palves@redhat.com>
 989
 990         * break-catch-throw.c (is_exception_catchpoint): New.
 991         * breakpoint.c (print_one_breakpoint_location): New parameter
 992         'raw_loc'.  Handle it.  Use
 993         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 994         looking at the breakpoint's type.
 995         (print_one_breakpoint): If handling "maint info breakpoints", also
 996         print locations of exception catchpoints.
 997         * breakpoint.h (is_exception_catchpoint): Declare.
 998
 999 2019-07-09  Pedro Alves  <palves@redhat.com>
1000
1001         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1002         "addr" field.
1003         (allocate_location_exception_catchpoint): New.
1004         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1005         (initialize_throw_catchpoint_ops): Install
1006         allocate_location_exception_catchpoint as allocate_location
1007         method.
1008         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1009         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1010         bp_loc_other.
1011         (breakpoint_address_is_meaningful): Delete.
1012         (bl_address_is_meaningful): New.
1013         (breakpoint_locations_match): Adjust comment.
1014         (bp_location_from_bp_type): New, factored out of...
1015         (bp_location::bp_location(breakpoint *)): ... this.
1016         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1017         factored out of...
1018         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1019         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1020         breakpoint_address_is_meaningful.
1021         (bp_locations_compare): Adjust comment.
1022         (update_global_location_list): Use bl_address_is_meaningful
1023         instead of breakpoint_address_is_meaningful.
1024         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1025         explicit.
1026         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1027         * python/py-breakpoint.c (bppy_get_location): No longer check
1028         whether location is null.
1029
1030 2019-07-09  Pedro Alves  <palves@redhat.com>
1031
1032         PR c++/15468
1033         * breakpoint.c (print_one_breakpoint_location): Remove
1034         single-location assert.
1035
1036 2019-07-09  Tom Tromey  <tom@tromey.com>
1037
1038         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1039         * configure: Rebuild.
1040         * configure.ac: Change common to gdbsupport.
1041         * gdbsupport: Rename from common.
1042         * acinclude.m4: Change common to gdbsupport.
1043         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1044         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1045         gdbsupport.
1046         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1047         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1048         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1049         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1050         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1051         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1052         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1053         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1054         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1055         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1056         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1057         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1058         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1059         coff-pe-read.c, command.h, compile/compile-c-support.c,
1060         compile/compile-c.h, compile/compile-cplus-symbols.c,
1061         compile/compile-cplus-types.c, compile/compile-cplus.h,
1062         compile/compile-loc2c.c, compile/compile.c, completer.c,
1063         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1064         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1065         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1066         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1067         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1068         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1069         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1070         features/aarch64-core.c, features/aarch64-fpu.c,
1071         features/aarch64-pauth.c, features/aarch64-sve.c,
1072         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1073         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1074         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1075         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1076         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1077         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1078         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1079         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1080         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1081         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1082         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1083         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1084         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1085         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1086         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1087         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1088         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1089         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1090         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1091         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1092         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1093         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1094         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1095         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1096         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1097         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1098         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1099         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1100         minsyms.c, mips-linux-tdep.c, namespace.h,
1101         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1102         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1103         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1104         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1105         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1106         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1107         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1108         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1109         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1110         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1111         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1112         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1113         procfs.c, producer.c, progspace.h, psymtab.h,
1114         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1115         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1116         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1117         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1118         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1119         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1120         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1121         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1122         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1123         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1124         target-memory.c, target.c, target.h, target/waitstatus.c,
1125         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1126         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1127         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1128         unittests/array-view-selftests.c,
1129         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1130         unittests/common-utils-selftests.c,
1131         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1132         unittests/format_pieces-selftests.c,
1133         unittests/function-view-selftests.c,
1134         unittests/lookup_name_info-selftests.c,
1135         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1136         unittests/mkdir-recursive-selftests.c,
1137         unittests/observable-selftests.c,
1138         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1139         unittests/parse-connection-spec-selftests.c,
1140         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1141         unittests/scoped_fd-selftests.c,
1142         unittests/scoped_mmap-selftests.c,
1143         unittests/scoped_restore-selftests.c,
1144         unittests/string_view-selftests.c, unittests/style-selftests.c,
1145         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1146         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1147         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1148         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1149         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1150         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1151
1152 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1153
1154         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1155         bool value.
1156         (decode_digits_ordinary): Set explicit_line field in sal.
1157         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1158         symtab_and_line that was set on an explicit line number in
1159         assembler code.  Do always update the recorded symtab and line if
1160         we do skip the prologue.
1161
1162 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1163
1164         * breakpoint.c (set_breakpoint_location_function): Remove
1165         explicit_loc parameter.
1166         (momentary_breakpoint_from_master): Update call to
1167         set_breakpoint_location_function.
1168         (add_location_to_breakpoint): Likewise.
1169
1170 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1171
1172         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1173         required features based on default bfd type when no specific bfd
1174         is present.
1175
1176 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1177
1178         * NEWS: Mention that GDB printf and eval commands can now print
1179         C-style and Ada-style convenience var strings without
1180         calling the inferior.
1181         * printcmd.c (printf_c_string): Locally print GDB internal var
1182         instead of transiting via the inferior.
1183         (printf_wide_c_string): Likewise.
1184
1185 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1186
1187         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1188
1189 2019-07-04  Tom Tromey  <tom@tromey.com>
1190
1191         PR tui/24724:
1192         * tui/tui-winsource.c (tui_clear_source_content): Update.
1193         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1194         (tui_update_breakpoint_info): Update.
1195         (tui_set_exec_info_content): Update.
1196         * tui/tui-source.c (tui_set_source_content_nil): Update.
1197         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1198         has_break.
1199         * tui/tui-data.h (enum tui_bp_flag): New.
1200         (tui_bp_flags): New enum flags type.
1201         (struct tui_source_element) <break_mode>: Change type.  Rename
1202         from has_break.
1203         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1204         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1205         constants.
1206         * tui/tui-winsource.h: Fix comment.
1207
1208 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1209
1210         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1211         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1212         (store_fpregs_to_thread)
1213         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1214         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1215         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1216         (IWMMXT_REGS_SIZE): Add define.
1217         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1218         (fetch_vfp_regs, store_vfp_regs)
1219         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1220         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1221
1222 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1223
1224         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1225         defines.
1226         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1227         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1228         (ARM_INT_REGISTER_SIZE): ...to this.
1229         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1230         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1231         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1232         (arm_linux_collect_gregset, supply_nwfpe_register)
1233         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1234         defines.
1235         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1236         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1237         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1238         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1239         (arm_return_in_memory, arm_store_return_value)
1240         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1241         (arm_record_ld_st_multiple): Likewise.
1242         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1243         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1244
1245 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1246
1247         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1248         AARCH64_DISPLACED_MODIFIED_INSNS.
1249         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1250         (aarch64_displaced_step_copy_insn): Likewise.
1251         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1252         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1253         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1254         ARM_DISPLACED_MODIFIED_INSNS.
1255         * arm-tdep.c (arm_gdbarch_init): Likewise.
1256         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1257         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1258         (struct arm_displaced_step_closure): Use
1259         ARM_DISPLACED_MODIFIED_INSNS.
1260
1261 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1262
1263         * features/Makefile: Remove unused xml files.
1264         * features/aarch64.xml: Remove.
1265         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1266         * features/i386/amd64-avx-avx512.xml: Remove.
1267         * features/i386/amd64-avx-linux.xml: Remove.
1268         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1269         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1270         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1271         * features/i386/amd64-avx-mpx.xml: Remove.
1272         * features/i386/amd64-avx.xml: Remove.
1273         * features/i386/amd64-linux.xml: Remove.
1274         * features/i386/amd64-mpx-linux.xml: Remove.
1275         * features/i386/amd64-mpx.xml: Remove.
1276         * features/i386/amd64.xml: Remove.
1277         * features/i386/i386-avx-avx512-linux.xml: Remove.
1278         * features/i386/i386-avx-avx512.xml: Remove.
1279         * features/i386/i386-avx-linux.xml: Remove.
1280         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1281         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1282         * features/i386/i386-avx-mpx-linux.xml: Remove.
1283         * features/i386/i386-avx-mpx.xml: Remove.
1284         * features/i386/i386-avx.xml: Remove.
1285         * features/i386/i386-linux.xml: Remove.
1286         * features/i386/i386-mmx-linux.xml: Remove.
1287         * features/i386/i386-mmx.xml: Remove.
1288         * features/i386/i386-mpx-linux.xml: Remove.
1289         * features/i386/i386-mpx.xml: Remove.
1290         * features/i386/i386.xml: Remove.
1291         * features/i386/x32-avx-avx512-linux.xml: Remove.
1292         * features/i386/x32-avx-linux.xml: Remove.
1293         * features/i386/x32-linux.xml: Remove.
1294
1295 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1296
1297         * regformats/aarch64.dat: Remove.
1298         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1299         * regformats/i386/amd64-avx-linux.dat: Remove.
1300         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1301         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1302         * regformats/i386/amd64-linux.dat: Remove.
1303         * regformats/i386/amd64-mpx-linux.dat: Remove.
1304         * regformats/i386/amd64.dat: Remove.
1305         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1306         * regformats/i386/i386-avx-linux.dat: Remove.
1307         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1308         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1309         * regformats/i386/i386-linux.dat: Remove.
1310         * regformats/i386/i386-mmx-linux.dat: Remove.
1311         * regformats/i386/i386-mpx-linux.dat: Remove.
1312         * regformats/i386/i386.dat: Remove.
1313         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1314         * regformats/i386/x32-avx-linux.dat: Remove.
1315         * regformats/i386/x32-linux.dat: Remove.
1316
1317 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1318
1319         * aarch64-tdep.c: Remove xml self tests.
1320         * amd64-linux-tdep.c: Likewise.
1321         * amd64-tdep.c: Likewise.
1322         * i386-linux-tdep.c: Likewise.
1323         * i386-tdep.c: Likewise.
1324
1325 2019-07-03  Pedro Alves  <palves@redhat.com>
1326
1327         PR cli/24732
1328         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1329         (pipe_cmd_option_defs): New.
1330         (make_pipe_cmd_options_def_group): New.
1331         (pipe_command): Use gdb::option::process_options.
1332         (pipe_command_completer): New function.
1333         (_initialize_cli_cmds): Install completer for "pipe" command.
1334
1335 2019-07-03  Pedro Alves  <palves@redhat.com>
1336
1337         * cli/cli-option.c (union option_value) <string>: New field.
1338         (struct option_def_and_value): Add ctor, move ctor, dtor and
1339         use DISABLE_COPY_AND_ASSIGN.
1340         (option_def_and_value::clear_value): New.
1341         (parse_option, save_option_value_in_ctx, get_val_type_str)
1342         (add_setshow_cmds_for_options): Handle var_string.
1343         * cli-option.h (union option_def::var_address) <string>: New
1344         field.
1345         (struct string_option_def): New.
1346         * maint-test-options.c (struct test_options_opts): Add default
1347         ctor and use DISABLE_COPY_AND_ASSIGN.
1348         <string_opt>: New field.
1349         (test_options_opts::~test_options_opts): New.
1350         (test_options_opts::dump): Also dump "-string".
1351         (test_options_option_defs): Install "string.
1352
1353 2019-07-03  Pedro Alves  <palves@redhat.com>
1354
1355         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1356         option_value with a null enumeration.
1357         (complete_options): Save the option values in the context.
1358         (save_option_value_in_ctx): New, factored out from ...
1359         (process_options): ... here.
1360         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1361         of the function.
1362         * maint-test-options.c (test_options_opts::dump): New, factored
1363         out from ...
1364         (maintenance_test_options_command_mode): ... here.
1365         (maintenance_test_options_command_completion_result): Delete.
1366         (maintenance_test_options_command_completion_text): Update
1367         comment.
1368         (maintenance_show_test_options_completion_result): Change
1369         prototype.  Just print
1370         maintenance_test_options_command_completion_text.
1371         (save_completion_result): New.
1372         (maintenance_test_options_completer_mode): Pass options context to
1373         complete_options, and then save a dump.
1374         (_initialize_maint_test_options): Use add_cmd to install "maint
1375         show test-options-completion-result".
1376
1377 2019-07-03  Pedro Alves  <palves@redhat.com>
1378
1379         * NEWS (New commands): Mention "with" and "maint with".
1380         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1381         (with_command, with_command_completer): New.
1382         (pipe_command): Adjust to new repeat_previous
1383         interface.
1384         (_initialize_cli_cmds): Install the "with" command and its "w"
1385         alias.
1386         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1387         declarations.
1388         * cli/cli-setshow.c (parse_cli_var_uinteger)
1389         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1390         argument strings for all var_types.
1391         (get_setshow_command_value_string): New, factored out from ...
1392         (do_show_command): ... this.
1393         * cli/cli-setshow.h: Include <string>.
1394         (get_setshow_command_value_string): Declare.
1395         * command.h (repeat_previous): Now returns const char *.  Adjust
1396         comment.
1397         * maint.c: Include "cli/cli-cmds.h".
1398         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1399         (_initialize_maint_cmds): Register the "maintenance with" command.
1400         * top.c (repeat_previous): Move bits from pipe_command here:
1401         Return the saved command line, if any; error out if there's no
1402         command to relaunch.
1403
1404 2019-07-03  Pedro Alves  <palves@redhat.com>
1405
1406         * NEWS (New commands): Mention "maint set/show test-settings"
1407         instead of "maint test-settings".
1408         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1409         (maintenance_test_settings_set_list): Rename to ...
1410         (maintenance_set_test_settings_list): ... this.
1411         (maintenance_test_settings_show_list): Rename to  ...
1412         (maintenance_show_test_settings_list): ... this.
1413         (maintenance_test_settings_cmd): Delete.
1414         (maintenance_test_settings_set_cmd): ...
1415         (maintenance_set_test_settings_cmd): ... this.
1416         (maintenance_test_settings_show_cmd): ...
1417         (maintenance_show_test_settings_cmd): ... this.
1418         (maintenance_test_settings_show_value_cmd):
1419         (maintenance_show_test_settings_value_cmd): ... this.
1420         (_initialize_maint_test_settings): No longer install the "maint
1421         test-settings" prefix command.  Rename "maint test-settings set"
1422         to "maint set test-settings", and "maint test-settings show" to
1423         "maint show test-settings".  Adjust all subcommands.
1424
1425 2019-07-03  Pedro Alves  <palves@redhat.com>
1426
1427         * maint-test-settings.c: Fix file's intro comment.  Replace all
1428         references to "test-options" with references to "test-settings",
1429         in comments.
1430
1431 2019-07-03  Pedro Alves  <palves@redhat.com>
1432
1433         * maint-test-settings.c (maintenance_test_settings_xxx)
1434         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1435         New.
1436         (maintenance_test_settings_enums): Use them.
1437         (maintenance_test_settings_enum): Default to
1438         maintenance_test_settings_xxx.
1439         (_initialize_maint_test_settings): Initialize
1440         MAINTENANCE_TEST_SETTINGS_FILENAME.
1441
1442 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1443
1444         * breakpoint.h (remove_breakpoints_inf): Change return type to
1445         void, move function documentation here.
1446         * breakpoint.c (remove_breakpoints_inf): Change return type to
1447         void, move function documentation to header.
1448
1449 2019-07-02  Pedro Alves  <palves@redhat.com>
1450
1451         * NEWS (Completion improvements): Mention "info threads".
1452         * thread.c (struct info_threads_opts, info_threads_option_defs)
1453         (make_info_threads_options_def_group): New.
1454         (info_threads_command): Use gdb::option::process_options.
1455         (info_threads_command_completer): New.
1456         (_initialize_thread): Use gdb::option::build_help to build the
1457         help text for "info threads".
1458
1459 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1460
1461         * defs.h (generic_load): Move from here...
1462         * symfile.h (generic_load): ... to here.  Rename name parameter
1463         to args.
1464         * symfile.c (generic_load): Add comment.
1465
1466 2019-07-01  Tom Tromey  <tromey@adacore.com>
1467
1468         * dwarf2read.c
1469         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1470         declaration of without_params.  Fix formatting.
1471
1472 2019-07-01  Tom Tromey  <tromey@adacore.com>
1473
1474         * ada-exp.y (find_primitive_type): Update.
1475         * ada-lang.h (ada_lookup_symbol): Update.
1476         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1477         parameter.
1478         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1479
1480 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1481
1482         PR breakpoints/24541
1483         * gdbarch.c: Regenerate.
1484         * gdbarch.h: Regenerate.
1485         * gdbarch.sh: Add 'stap_adjust_register'.
1486         * i386-tdep.c: Include '<unordered_set>'.
1487         (i386_stap_adjust_register): New function.
1488         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1489         * stap-probe.c (stap_parse_register_operand): Call
1490         'gdbarch_stap_adjust_register'.
1491
1492 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1493
1494         PR python/24742
1495         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1496         * python/python.c (do_start_initialization): Use 'xmalloc'
1497         instead of 'PyMem_Malloc'.
1498
1499 2019-06-28  Tom Tromey  <tromey@adacore.com>
1500
1501         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1502         for Ada.
1503
1504 2019-06-27  Tom Tromey  <tromey@adacore.com>
1505
1506         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1507         objfile_key.
1508         (arm_find_mapping_symbol, arm_record_special_symbol)
1509         (_initialize_arm_tdep): Update.
1510         (arm_objfile_data_free): Remove.
1511
1512 2019-06-27  Tom Tromey  <tromey@adacore.com>
1513
1514         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1515         to cp_print_static_field.
1516
1517 2019-06-26  Tom Tromey  <tromey@adacore.com>
1518
1519         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1520         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1521         declare.
1522
1523 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1524
1525         * features/aarch64-core.c (create_feature_aarch64_core):
1526         Regenerate.
1527         * features/aarch64-core.xml: Add cpsr flags.
1528
1529 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1530
1531         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1532         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1533
1534 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1535
1536         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1537         field.
1538         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1539         use.
1540         (arm_record_special_symbol): Don't insert new symbol in sorted
1541         position, push it at the end.
1542
1543 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1544
1545         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1546         (arm_mapping_symbol_s): Remove.
1547         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1548         (arm_mapping_symbol_vec): New typedef.
1549         (struct arm_per_objfile): Add constructor.
1550         <section_maps>: Change type to
1551         std::unique_ptr<arm_mapping_symbol_vec[]>.
1552         (arm_compare_mapping_symbols): Remove.
1553         (arm_find_mapping_symbol): Adjust to section_maps type change.
1554         (arm_objfile_data_free): Call delete on arm_per_objfile.
1555         (arm_record_special_symbol): Adjust to section_maps type change.
1556         Allocate arm_per_objfile with new.
1557
1558 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1559
1560         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1561         with the command prefix.
1562
1563 2019-06-25  Tom Tromey  <tom@tromey.com>
1564
1565         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1566         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1567
1568 2019-06-25  Tom Tromey  <tom@tromey.com>
1569
1570         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1571         type.
1572         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1573         protected.
1574
1575 2019-06-25  Tom Tromey  <tom@tromey.com>
1576
1577         * tui/tui-winsource.c
1578         (tui_source_window_base::set_is_exec_point_at): Add check against
1579         LOA_ADDRESS.
1580
1581 2019-06-25  Tom Tromey  <tom@tromey.com>
1582
1583         * tui/tui-source.c (tui_set_source_content): Don't check before
1584         xfree.
1585         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1586
1587 2019-06-25  Tom Tromey  <tom@tromey.com>
1588
1589         * tui/tui-winsource.h (tui_update_source_window_as_is)
1590         (tui_alloc_source_buffer, tui_line_is_displayed)
1591         (tui_addr_is_displayed): Change type of win_info.
1592         * tui/tui-winsource.c (tui_update_source_window_as_is)
1593         (tui_clear_source_content, tui_show_source_line)
1594         (tui_show_source_content, tui_source_window_base::refill)
1595         (tui_source_window_base::set_is_exec_point_at)
1596         (tui_source_window_base::set_is_exec_point_at)
1597         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1598         (tui_alloc_source_buffer, tui_line_is_displayed)
1599         (tui_addr_is_displayed): Change type of win_info.  Update.
1600         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1601         (tui_source_window_base::do_make_visible_with_new_height):
1602         Update.
1603         * tui/tui-source.c (tui_set_source_content)
1604         (tui_set_source_content_nil)
1605         (tui_source_window::do_scroll_vertical): Update.
1606         * tui/tui-layout.c (show_layout): Update.
1607         * tui/tui-disasm.c (tui_set_disassem_content)
1608         (tui_disasm_window::do_scroll_vertical): Update.
1609         * tui/tui-data.h (tui_win_content): Remove.
1610         (struct tui_gen_win_info) <content, content_size>: Remove.
1611         (struct tui_source_element): Add initializers and destructor.
1612         (union tui_which_element, struct tui_win_element): Remove.
1613         (struct tui_source_window_base) <content>: New field.
1614         (struct tui_data_window): Remove destructor.
1615         (tui_alloc_content, tui_free_win_content)
1616         (tui_free_all_source_wins_content): Don't declare.
1617         * tui/tui-data.c (tui_initialize_static_data): Update.
1618         (init_content_element, tui_alloc_content): Remove.
1619         (~tui_gen_win_info): Update.
1620         (~tui_data_window, tui_free_all_source_wins_content)
1621         (tui_free_win_content, free_content, free_content_elements):
1622         Remove.
1623
1624 2019-06-25  Tom Tromey  <tom@tromey.com>
1625
1626         * tui/tui-winsource.h (tui_clear_source_content)
1627         (tui_erase_source_content, tui_show_source_content): Change type
1628         of win_info.
1629         * tui/tui-winsource.c (tui_clear_source_content)
1630         (tui_erase_source_content, tui_show_source_content): Change type
1631         of win_info.
1632         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1633         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1634         win_info.
1635         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1636         win_info.
1637         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1638
1639 2019-06-25  Tom Tromey  <tom@tromey.com>
1640
1641         * tui/tui-winsource.c (tui_clear_source_content)
1642         (tui_source_window_base::set_is_exec_point_at): Update.
1643         * tui/tui-source.c (tui_set_source_content_nil): Update.
1644         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1645         a bool.
1646         * tui/tui-data.c (init_content_element): Update.
1647
1648 2019-06-25  Tom Tromey  <tom@tromey.com>
1649
1650         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1651         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1652         * tui/tui-layout.c (init_and_make_win): Update.
1653         * tui/tui.h (enum tui_win_type): Update.
1654         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1655         tui_win_is_auxillary.
1656         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1657         tui_win_is_auxillary.
1658
1659 2019-06-25  Tom Tromey  <tom@tromey.com>
1660
1661         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1662         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1663         (tui_delete_data_content_windows, tui_display_all_data)
1664         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1665         Update.
1666         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1667         * tui/tui-regs.c (tui_last_regs_line_no)
1668         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1669         (tui_show_registers): Update.
1670         (tui_show_register_group): Return void.  Update.
1671         (tui_display_registers_from, tui_display_reg_element_at_line)
1672         (tui_display_registers_from_line, tui_check_register_values):
1673         Update.
1674         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1675         member.
1676         (struct tui_data_window) <regs_content>: Now a std::vector.
1677         <regs_content_count>: Remove.
1678         (tui_add_content_elements, tui_free_data_content): Don't declare.
1679         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1680         (init_content_element): Remove DATA_WIN case.  Add assert.
1681         (tui_add_content_elements): Remove.
1682         (tui_data_window): Update.
1683         (tui_free_data_content): Remove.
1684         (free_content_elements): Remove DATA_WIN case.
1685
1686 2019-06-25  Tom Tromey  <tom@tromey.com>
1687
1688         * tui/tui-data.c (tui_data_item_window): Update.
1689         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1690         * tui/tui-windata.c (tui_display_all_data)
1691         (tui_display_data_from_line): Update.
1692         (tui_check_data_values): Remove.
1693         * tui/tui-regs.c (tui_show_register_group)
1694         (tui_display_reg_element_at_line): Update.
1695         * tui/tui-hooks.c (tui_register_changed)
1696         (tui_refresh_frame_and_register_information): Call
1697         tui_check_register_values.
1698         * tui/tui-data.h (struct tui_data_window) <data_content,
1699         data_content_count, data_type>: Remove.
1700         (enum tui_data_type): Remove.
1701
1702         * tui/tui-data.c (tui_data_window::clear_detail)
1703         (~tui_data_window): Update.
1704
1705 2019-06-25  Tom Tromey  <tom@tromey.com>
1706
1707         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1708         declare.
1709         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1710         Rename from tui_first_data_item_displayed.  Update.
1711         (tui_data_window::refresh_all)
1712         (tui_data_window::do_scroll_vertical): Update.
1713         * tui/tui-data.h (struct tui_data_window)
1714         <first_data_item_displayed>: Declare new method.
1715
1716 2019-06-25  Tom Tromey  <tom@tromey.com>
1717
1718         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1719         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1720         contents...
1721         (tui_initialize_static_data): ...here.
1722
1723 2019-06-25  Tom Tromey  <tom@tromey.com>
1724
1725         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1726         (tui_display_registers_from, tui_check_register_values): Update.
1727         (tui_display_register): Remove win_info parameter; update.
1728         (tui_get_register): Change type of parameters.
1729         * tui/tui-data.h (struct tui_data_element): Remove.
1730         (union tui_which_element) <data>: Remove.
1731         <data_window>: Change type.
1732         (struct tui_data_item_window): New.
1733         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1734         case.  Add assert.
1735         (~tui_data_item_window): New destructor.
1736         (free_content_elements): Remove DATA_ITEM_WIN case.
1737
1738 2019-06-25  Tom Tromey  <tom@tromey.com>
1739
1740         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1741         Remove.
1742
1743 2019-06-25  Tom Tromey  <tom@tromey.com>
1744
1745         * tui/tui-data.h (struct tui_command_element): Remove.
1746         (union tui_which_element) <command>: Remove.
1747         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1748         assert.
1749         (free_content_elements): Remove CMD_WIN case.
1750
1751 2019-06-25  Tom Tromey  <tom@tromey.com>
1752
1753         * tui/tui-layout.c (tui_set_layout): Update.
1754         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1755         * tui/tui-data.c (layout_def): Update.
1756
1757 2019-06-25  Tom Tromey  <tom@tromey.com>
1758
1759         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1760         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1761         (tui_source_window_base::set_new_height): Update.
1762         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1763         Update.
1764         (tui_set_locator_fullname, tui_set_locator_info)
1765         (tui_show_frame_info): Update.
1766         * tui/tui-source.c (tui_set_source_content)
1767         (tui_source_is_displayed): Update.
1768         * tui/tui-layout.c (show_source_disasm_command, show_data)
1769         (show_source_or_disasm_and_command): Update.
1770         * tui/tui-disasm.c (tui_set_disassem_content)
1771         (tui_get_begin_asm_address): Update.
1772         * tui/tui-data.h (struct tui_locator_element): Remove.
1773         (union tui_which_element) <locator>: Remove.
1774         (struct tui_locator_window): New.
1775         (tui_locator_win_info_ptr): Change return type.
1776         * tui/tui-data.c (_locator): Change type.
1777         (tui_locator_win_info_ptr): Change return type.
1778         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1779         (tui_alloc_content): Add assert.
1780
1781 2019-06-25  Tom Tromey  <tom@tromey.com>
1782
1783         * tui/tui-winsource.c
1784         (tui_exec_info_window::maybe_allocate_content): New method.
1785         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1786         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1787         (make_source_or_disasm_window): Add cast.
1788         * tui/tui-data.h (union tui_which_element) <simple_string>:
1789         Remove.
1790         (struct tui_source_info): New.
1791         (struct tui_source_window_base) <execution_info>: Change type.
1792         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1793         case, and add assert.
1794         (tui_alloc_content): Add assert.
1795
1796 2019-06-25  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1799         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1800         * tui/tui-data.c (tui_alloc_win_info): Remove.
1801
1802 2019-06-25  Tom Tromey  <tom@tromey.com>
1803
1804         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1805         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1806         can_highlight.
1807
1808 2019-06-25  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1811         make_visible_with_new_height method.
1812         (tui_win_info::make_visible_with_new_height): New method.
1813         (tui_source_window_base::do_make_visible_with_new_height)
1814         (tui_data_window::do_make_visible_with_new_height)
1815         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1816         (make_visible_with_new_height): Remove.
1817         (tui_resize_all, tui_adjust_win_heights): Use
1818         make_visible_with_new_height method.
1819         * tui/tui-data.h (struct tui_win_info)
1820         <do_make_visible_with_new_height, make_visible_with_new_height>:
1821         New methods.
1822         (struct tui_source_window_base, struct tui_data_window)
1823         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1824         methods.
1825
1826 2019-06-25  Tom Tromey  <tom@tromey.com>
1827
1828         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1829         method.
1830         (update_tab_width): Call update_tab_width method.
1831         * tui/tui-data.h (struct tui_win_info)
1832         (struct tui_source_window_base) <update_tab_width>: New methods.
1833
1834 2019-06-25  Tom Tromey  <tom@tromey.com>
1835
1836         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1837         parameter.
1838         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1839         parameter.
1840         (tui_gen_win_info::make_visible): Update.
1841         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1842         parameter.
1843         * tui/tui-data.h (enum tui_box): New enum.
1844         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1845
1846 2019-06-25  Tom Tromey  <tom@tromey.com>
1847
1848         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1849         init_and_make_win for EXEC_INFO_WIN.
1850         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1851         longer inline.
1852         (struct tui_win_info) <~tui_win_info>: Inline.
1853         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1854         Don't declare.
1855         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1856         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1857         Remove.
1858         (tui_initialize_static_data): Update.
1859         (~tui_gen_win_info): Handle more cleanup here.
1860         (~tui_source_window_base): Delete "execution_info".
1861         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1862
1863 2019-06-25  Tom Tromey  <tom@tromey.com>
1864
1865         * tui/tui-layout.c (make_command_window): Don't set
1866         can_highlight.
1867         (show_source_disasm_command): Call the reset method.
1868         (show_data): Don't set can_highlight.  Call the reset method.
1869         (tui_gen_win_info::reset): Rename from init_gen_win_info
1870         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1871         (show_source_or_disasm_and_command): Call the reset method.
1872         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1873         (struct tui_cmd_window): Set can_highlight.
1874
1875 2019-06-25  Tom Tromey  <tom@tromey.com>
1876
1877         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1878         from make_visible.
1879         (tui_make_visible, tui_make_invisible): Rewrite.
1880         (tui_win_info::make_visible): Remove.
1881         (tui_source_window_base::make_visible): Update.
1882         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1883         method.  Moved from...
1884         (struct tui_win_info) <make_visible>: ...here.
1885
1886 2019-06-25  Tom Tromey  <tom@tromey.com>
1887
1888         * tui/tui-winsource.c
1889         (tui_source_window_base::do_scroll_horizontal): Remove direction
1890         parameter.
1891         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1892         direction parameter.
1893         * tui/tui-win.c (tui_win_info::forward_scroll)
1894         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1895         (tui_win_info::right_scroll): Update.
1896         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1897         direction parameter.
1898         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1899         direction parameter.
1900         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1901         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1902         Remove direction parameter.
1903         (struct tui_source_window_base, struct tui_source_window)
1904         (struct tui_disasm_window, struct tui_data_window)
1905         (struct tui_cmd_window): Update.
1906
1907 2019-06-25  Tom Tromey  <tom@tromey.com>
1908
1909         * tui/tui-winsource.h (tui_set_exec_info_content)
1910         (tui_show_exec_info_content, tui_erase_exec_info_content)
1911         (tui_clear_exec_info_content, tui_update_exec_info): Change
1912         argument to tui_source_window_base.
1913         * tui/tui-winsource.c (tui_set_exec_info_content)
1914         (tui_show_exec_info_content, tui_erase_exec_info_content)
1915         (tui_clear_exec_info_content, tui_update_exec_info): Change
1916         argument to tui_source_window_base.
1917
1918 2019-06-25  Tom Tromey  <tom@tromey.com>
1919
1920         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1921         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1922
1923 2019-06-25  Tom Tromey  <tom@tromey.com>
1924
1925         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1926         check.
1927
1928 2019-06-25  Tom Tromey  <tom@tromey.com>
1929
1930         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1931         type to void.
1932         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1933         type to void.
1934         * tui/tui-source.c (tui_set_source_content): Update.
1935         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1936
1937 2019-06-25  Tom Tromey  <tom@tromey.com>
1938
1939         * tui/tui-win.c (window_name_completer, tui_set_focus)
1940         (tui_all_windows_info): Use name method.
1941         * tui/tui-data.h (struct tui_gen_win_info)
1942         (struct tui_source_window, struct tui_disasm_window)
1943         (struct tui_data_window, struct tui_cmd_window) <name>: New
1944         method.
1945         (tui_win_name): Don't declare.
1946         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1947         (tui_win_name): Remove.
1948
1949 2019-06-25  Tom Tromey  <tom@tromey.com>
1950
1951         * tui/tui-winsource.h (tui_update_source_window)
1952         (tui_update_source_window_as_is): Change parameter type.
1953         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1954         to be a tui_source_window_base.
1955         (tui_update_source_window_as_is): Likewise.
1956         * tui/tui-win.c (make_visible_with_new_height): Update.
1957
1958 2019-06-25  Tom Tromey  <tom@tromey.com>
1959
1960         * tui/tui-winsource.c (tui_erase_source_content)
1961         (tui_show_source_content, tui_show_exec_info_content)
1962         (tui_erase_exec_info_content): Use refresh_window method.
1963         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1964         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1965         from tui_refresh_win.
1966         (tui_data_window::refresh_window): New method.
1967         (tui_win_info::refresh, tui_source_window_base::refresh)
1968         (tui_refresh_all): Use refresh_window method.
1969         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1970         method.
1971         * tui/tui-regs.c (tui_display_register): Call refresh_window
1972         method.
1973         * tui/tui-layout.c (show_source_disasm_command)
1974         (show_source_or_disasm_and_command): Call refresh_window method.
1975         * tui/tui-data.h (struct tui_gen_win_info)
1976         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1977         New method.
1978
1979 2019-06-25  Tom Tromey  <tom@tromey.com>
1980
1981         * tui/tui.c (tui_rl_other_window, tui_enable)
1982         (tui_is_window_visible, tui_get_command_dimension): Update.
1983         * tui/tui-winsource.c (tui_update_source_window_as_is)
1984         (tui_clear_source_content, tui_erase_source_content)
1985         (tui_show_source_line, tui_source_window_base::refill)
1986         (tui_source_window_base::do_scroll_horizontal)
1987         (tui_source_window_base::set_is_exec_point_at)
1988         (tui_update_breakpoint_info, tui_set_exec_info_content)
1989         (tui_alloc_source_buffer, tui_line_is_displayed)
1990         (tui_addr_is_displayed): Update.
1991         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1992         (tui_check_and_display_highlight_if_needed)
1993         (tui_win_info::make_visible, tui_win_info::refresh)
1994         (tui_refresh_all): Update.
1995         * tui/tui-windata.c (tui_first_data_item_displayed)
1996         (tui_delete_data_content_windows, tui_erase_data_content)
1997         (tui_display_all_data, tui_data_window::refresh_all)
1998         (tui_check_data_values): Update.
1999         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2000         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2001         (tui_win_info::backward_scroll, tui_refresh_all_win)
2002         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2003         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2004         (tui_source_window_base::set_new_height)
2005         (tui_data_window::set_new_height)
2006         (make_invisible_and_set_new_height)
2007         (make_visible_with_new_height, new_height_ok)
2008         (parse_scrolling_args): Update.
2009         * tui/tui-stack.c (tui_show_frame_info): Update.
2010         * tui/tui-source.c (tui_set_source_content)
2011         (tui_set_source_content_nil, tui_source_is_displayed)
2012         (tui_source_window::do_scroll_vertical): Update.
2013         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2014         (tui_display_registers_from, tui_display_reg_element_at_line)
2015         (tui_check_register_values, tui_reg_command): Update.
2016         * tui/tui-layout.c (tui_default_win_height)
2017         (show_source_disasm_command, show_data, init_and_make_win)
2018         (show_source_or_disasm_and_command): Update.
2019         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2020         (tui_redisplay_readline, tui_mld_flush)
2021         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2022         (tui_getc): Update.
2023         * tui/tui-disasm.c (tui_set_disassem_content)
2024         (tui_disasm_window::do_scroll_vertical): Update.
2025         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2026         Now virtual.
2027         (struct tui_win_info): Derive from tui_gen_win_info.
2028         <~tui_win_info>: Mark as override.
2029         <generic>: Remove member.
2030         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2031         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2032         (~tui_data_window, ~tui_win_info)
2033         (tui_free_all_source_wins_content): Update.
2034         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2035
2036 2019-06-25  Tom Tromey  <tom@tromey.com>
2037
2038         * tui/tui-layout.c (init_and_make_win): Use new.
2039         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2040         destructor, initializers.
2041         (tui_alloc_generic_win_info): Don't declare.
2042         * tui/tui-data.c (_locator): Add argument to constructor.
2043         (source_win, disasm_win): New globals.
2044         (exec_info): Remove.
2045         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2046         Update.
2047         (tui_alloc_generic_win_info): Remove.
2048         (init_content_element): Use new.
2049         (tui_win_info::tui_win_info): Update.
2050         (free_content_elements) <case DATA_WIN>: Use delete.
2051
2052 2019-06-25  Tom Tromey  <tom@tromey.com>
2053
2054         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2055         * tui/tui-windata.c (tui_first_data_item_displayed)
2056         (tui_delete_data_content_windows): Update.
2057         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2058         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2059         (tui_display_registers_from, tui_check_register_values): Update.
2060         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2061         pointer.
2062         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2063         window.
2064         (tui_free_data_content): Update.
2065         (free_content_elements) <case DATA_WIN>: Free the window.
2066
2067 2019-06-25  Tom Tromey  <tom@tromey.com>
2068
2069         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2070         Update.
2071         * tui/tui-layout.c (make_command_window)
2072         (show_source_disasm_command, show_data, init_and_make_win)
2073         (show_source_or_disasm_and_command): Update.
2074         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2075         method.
2076         <can_highight, is_highlighted>: Now bool.
2077         (tui_set_win_highlight): Don't declare.
2078         * tui/tui-data.c (tui_set_win_highlight): Remove.
2079
2080 2019-06-25  Tom Tromey  <tom@tromey.com>
2081
2082         * tui/tui-wingeneral.c (make_visible): Remove check of window
2083         type.
2084
2085 2019-06-25  Tom Tromey  <tom@tromey.com>
2086
2087         * tui/tui-win.c (tui_win_info::max_height)
2088         (tui_cmd_window::max_height): New methods.
2089         (new_height_ok): Call max_height.
2090         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2091         <max_height>: New method.
2092
2093 2019-06-25  Tom Tromey  <tom@tromey.com>
2094
2095         * tui/tui-win.c (tui_source_window_base::set_new_height)
2096         (tui_data_window::set_new_height): New methods.
2097         (make_invisible_and_set_new_height): Call set_new_height method.
2098         * tui/tui-data.h (struct tui_win_info)
2099         (struct tui_source_window_base, struct tui_data_window)
2100         <set_new_height>: New method.
2101
2102 2019-06-25  Tom Tromey  <tom@tromey.com>
2103
2104         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2105         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2106         tui_refresh_data_win.
2107         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2108         method.
2109         (tui_refresh_all_win): Call the refresh_all method.
2110         (tui_set_focus): Likewise.
2111         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2112         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2113         Likewise.
2114
2115 2019-06-25  Tom Tromey  <tom@tromey.com>
2116
2117         * tui/tui-winsource.h (tui_refill_source_window)
2118         (tui_set_is_exec_point_at): Don't declare.
2119         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2120         (tui_source_window_base::refill): Rename from
2121         tui_refill_source_window.
2122         (tui_source_window_base::do_scroll_horizontal): Update.
2123         (tui_source_window_base::set_is_exec_point_at): Rename from
2124         tui_set_is_exec_point_at.
2125         (tui_update_all_breakpoint_info): Update.
2126         * tui/tui-stack.c (tui_show_frame_info): Update.
2127         * tui/tui-layout.c (show_data): Add cast.
2128         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2129         * tui/tui-data.h (struct tui_source_window_base) <refill,
2130         set_is_exec_point_at>: New methods.
2131         (tui_source_windows, tui_add_to_source_windows): Update types.
2132         (tui_add_to_source_windows): Remove redundant declaration.
2133         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2134         (tui_source_windows): Change return type.
2135         (tui_clear_source_windows_detail): Update.
2136         (tui_add_to_source_windows): Change type of parameter.
2137         (tui_free_all_source_wins_content): Update.
2138
2139 2019-06-25  Tom Tromey  <tom@tromey.com>
2140
2141         * tui/tui-wingeneral.c (tui_win_info::refresh)
2142         (tui_source_window_base::refresh): New methods.
2143         (tui_refresh_all): Call the refresh method.
2144         * tui/tui-data.h (struct tui_win_info)
2145         (struct tui_source_window_base) <refresh>: New method.
2146
2147 2019-06-25  Tom Tromey  <tom@tromey.com>
2148
2149         * tui/tui.h (tui_is_window_visible): Return bool.
2150         * tui/tui.c (tui_is_window_visible): Return bool.
2151         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2152         (tui_make_visible, tui_make_invisible)
2153         (tui_win_info::make_visible)
2154         (tui_source_window_base::make_visible, make_all_visible)
2155         (tui_make_all_visible, tui_make_all_invisible): Update.
2156         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2157         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2158         bool.
2159         (struct tui_win_info, struct tui_source_window_base)
2160         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2161         * tui/tui-data.c (tui_init_generic_part): Update.
2162
2163 2019-06-25  Tom Tromey  <tom@tromey.com>
2164
2165         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2166         (tui_source_window_base::make_visible): New methods.
2167         (make_all_visible): Make method call.
2168         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2169         (struct tui_source_window_base, struct tui_cmd_window): Override
2170         make_visible.
2171         (tui_win_is_source_type): Don't declare.
2172         * tui/tui-data.c (tui_win_is_source_type): Remove.
2173
2174 2019-06-25  Tom Tromey  <tom@tromey.com>
2175
2176         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2177         NULL check.
2178
2179 2019-06-25  Tom Tromey  <tom@tromey.com>
2180
2181         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2182         Inline constructor.  Add initializers for members.
2183         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2184         constructors; now inline in class.
2185
2186 2019-06-25  Tom Tromey  <tom@tromey.com>
2187
2188         * tui/tui-regs.c (tui_show_registers): Update.
2189         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2190         bool.
2191         * tui/tui-data.c (tui_data_window::clear_detail)
2192         (tui_data_window): Update.
2193
2194 2019-06-25  Tom Tromey  <tom@tromey.com>
2195
2196         * tui/tui-windata.c (tui_display_all_data)
2197         (tui_display_data_from_line, tui_display_data_from)
2198         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2199         Update.
2200         * tui/tui-regs.c (tui_last_regs_line_no)
2201         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2202         (tui_show_registers, tui_show_register_group)
2203         (tui_display_registers_from, tui_display_reg_element_at_line)
2204         (tui_display_registers_from_line, tui_check_register_values)
2205         (tui_reg_next, tui_reg_prev): Update.
2206         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2207         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2208         tui_data_window.
2209         (struct tui_win_info) <detail>: Remove.  Add new fields from
2210         tui_data_info.
2211         (TUI_DATA_WIN): Add cast.
2212         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2213         (~tui_data_window): Simplify.
2214
2215 2019-06-25  Tom Tromey  <tom@tromey.com>
2216
2217         * tui/tui-layout.c (show_source_disasm_command)
2218         (show_source_or_disasm_and_command): Update.
2219         * tui/tui-io.c (update_cmdwin_start_line)
2220         (tui_redisplay_readline): Update.
2221         * tui/tui-data.h (struct tui_command_info): Remove.
2222         (struct tui_win_info) <detail>: Remove command_info member.
2223         (struct tui_data_window) <start_line>: New member, from
2224         tui_command_info.
2225         (TUI_CMD_WIN): Add casts.
2226
2227 2019-06-25  Tom Tromey  <tom@tromey.com>
2228
2229         * tui/tui-winsource.c (tui_update_source_window)
2230         (tui_refill_source_window)
2231         (tui_source_window_base::do_scroll_horizontal)
2232         (tui_update_breakpoint_info, tui_set_exec_info_content)
2233         (tui_show_exec_info_content, tui_erase_exec_info_content)
2234         (tui_clear_exec_info_content): Update.
2235         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2236         Update.
2237         * tui/tui-win.c (make_invisible_and_set_new_height)
2238         (make_visible_with_new_height): Update.
2239         * tui/tui-source.c (tui_set_source_content)
2240         (tui_show_symtab_source): Update.
2241         * tui/tui-layout.c (extract_display_start_addr)
2242         (show_source_disasm_command, show_data)
2243         (make_source_or_disasm_window)
2244         (show_source_or_disasm_and_command): Update.
2245         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2246         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2247         "gdbarch".
2248         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2249         to tui_source_window_base.
2250         (struct tui_win_info) <detail>: Remove source_info member.
2251         (struct tui_source_window_base) <has_locator>: Inline.
2252         Move contents from tui_source_info; rename has_locator member to
2253         m_has_locator.
2254         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2255         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2256         header file.
2257         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2258         Simplify.
2259         (tui_free_all_source_wins_content): Cast to
2260         tui_source_window_base.
2261
2262 2019-06-25  Tom Tromey  <tom@tromey.com>
2263
2264         * tui/tui-win.c (make_invisible_and_set_new_height)
2265         (make_visible_with_new_height): Call has_locator method.
2266         * tui/tui-layout.c (show_source_disasm_command, show_data)
2267         (show_source_or_disasm_and_command): Update for bool change.
2268         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2269         (tui_win_info) <has_locator>: New method.
2270         (struct tui_source_window_base) <has_locator>: New method.
2271         (tui_win_has_locator): Don't declare.
2272         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2273         from tui_win_has_locator.
2274         (tui_source_window_base): Use false, not FALSE.
2275
2276 2019-06-25  Tom Tromey  <tom@tromey.com>
2277
2278         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2279         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2280         clear_detail method directly.
2281         (tui_clear_win_detail): Remove.
2282
2283 2019-06-25  Tom Tromey  <tom@tromey.com>
2284
2285         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2286         "this", not TUI_DISASM_WIN.
2287
2288 2019-06-25  Tom Tromey  <tom@tromey.com>
2289
2290         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2291         declare.
2292         * tui/tui-winsource.c
2293         (tui_source_window_base::do_scroll_horizontal): Rename from
2294         tui_horizontal_source_scroll.
2295         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2296         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2297         from tui_vertical_data_scroll.
2298         * tui/tui-win.h (tui_scroll): Don't declare.
2299         * tui/tui-win.c (tui_win_info::forward_scroll)
2300         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2301         (tui_win_info::right_scroll): Rename and update.
2302         (tui_scroll_forward_command, tui_scroll_backward_command)
2303         (tui_scroll_left_command, tui_scroll_right_command): Update.
2304         (tui_scroll): Remove.
2305         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2306         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2307         from tui_vertical_source_scroll.
2308         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2309         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2310         from tui_vertical_disassem_scroll.
2311         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2312         do_scroll_horizontal>: New methods.
2313         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2314         Likewise.
2315         (struct tui_source_window_base): Add do_scroll_horizontal.
2316         (struct tui_source_window, struct tui_disasm_window): Add
2317         do_scroll_vertical.
2318         (struct tui_data_window, struct tui_cmd_window): Add
2319         do_scroll_horizontal and do_scroll_vertical.
2320         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2321
2322 2019-06-25  Tom Tromey  <tom@tromey.com>
2323
2324         * tui/tui-data.h (struct tui_source_window_base): New struct.
2325         (struct tui_source_window): Derive from tui_source_window_base.
2326         (struct tui_disasm_window): New struct.
2327         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2328         from tui_source_window::clear_detail.
2329         (tui_source_window_base): Rename from tui_source_window.
2330         (~tui_source_window_base): Rename from ~tui_source_window.
2331         (tui_alloc_win_info): Create a tui_disasm_window.
2332
2333 2019-06-25  Tom Tromey  <tom@tromey.com>
2334
2335         * tui/tui-data.h (struct tui_source_window)
2336         (struct tui_data_window): Declare destructors.
2337         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2338         destructors.
2339         (tui_win_info): Simplify.
2340
2341 2019-06-25  Tom Tromey  <tom@tromey.com>
2342
2343         * tui/tui-winsource.c (tui_display_main)
2344         (tui_update_source_windows_with_addr)
2345         (tui_update_all_breakpoint_info): Update.
2346         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2347         (new_height_ok, parse_scrolling_args): Update.
2348         * tui/tui-stack.c (tui_show_frame_info): Update.
2349         * tui/tui-data.h (struct tui_list): Remove.
2350         (tui_source_windows): Return a reference to a std::vector.
2351         * tui/tui-data.c (source_windows): Now a std::vector.
2352         (tui_source_windows): Change return type.
2353         (tui_clear_source_windows): Rewrite.
2354         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2355         (tui_free_all_source_wins_content): Rewrite.
2356
2357 2019-06-25  Tom Tromey  <tom@tromey.com>
2358
2359         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2360         (struct tui_data_window, struct tui_cmd_window): Declare
2361         clear_detail method.
2362         * tui/tui-data.c (tui_source_window::clear_detail)
2363         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2364         methods.
2365         (tui_clear_win_detail): Simplify.
2366
2367 2019-06-25  Tom Tromey  <tom@tromey.com>
2368
2369         * tui/tui-layout.c (make_source_window, make_disasm_window)
2370         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2371         Return the new window.
2372         (show_source_disasm_command, show_data)
2373         (show_source_or_disasm_and_command): Update.
2374
2375 2019-06-25  Tom Tromey  <tom@tromey.com>
2376
2377         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2378         parameter.  Return the new window.
2379         (show_source_disasm_command): Update and remove NULL check.
2380         (show_source_or_disasm_and_command): Update.
2381
2382 2019-06-25  Tom Tromey  <tom@tromey.com>
2383
2384         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2385
2386 2019-06-25  Tom Tromey  <tom@tromey.com>
2387
2388         * tui/tui-data.h (struct tui_win_info): Make constructor
2389         protected.  Make destructor virtual.  Add initializers.
2390         (tui_source_window, tui_data_window, tui_cmd_window): New
2391         classes.
2392         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2393         constructor.  Add "type" parameter.
2394         (tui_source_window, tui_data_window, tui_cmd_window): New
2395         constructors.
2396         (tui_alloc_win_info): Instantiate the appropriate subclass.
2397
2398 2019-06-25  Tom Tromey  <tom@tromey.com>
2399
2400         * tui/tui-win.c (tui_resize_all): Use delete.
2401         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2402         destructor.
2403         (tui_free_window): Don't declare.
2404         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2405         Update.
2406
2407 2019-06-25  Tom Tromey  <tom@tromey.com>
2408
2409         * tui/tui-data.h (struct tui_win_info): Add constructor.
2410         * tui/tui-data.c (tui_alloc_win_info): Use new.
2411         (tui_free_window): Use delete.
2412
2413 2019-06-22  Tom Tromey  <tom@tromey.com>
2414
2415         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2416         declare.
2417         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2418
2419 2019-06-22  Tom Tromey  <tom@tromey.com>
2420
2421         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2422         declare.
2423         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2424
2425 2019-06-22  Tom de Vries  <tdevries@suse.de>
2426
2427         * dwarf2read.c (create_addrmap_from_aranges)
2428         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2429         instead of '%zu'.
2430
2431 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2432
2433         * dwarf2read.h (dwarf2_section_info_def): Remove.
2434         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2435         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2436         std::vector<dwarf2_section_info>.
2437         (struct dwo_file) <~dwo_file>: Remove.
2438         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2439         types field.
2440         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2441         (dwarf2_read_debug_names): Likewise.
2442         (create_debug_types_hash_table): Change parameter type to
2443         array_view, adjust code accordingly.
2444         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2445         (partial_die_info::fixup): Likewise.
2446         (determine_prefix): Likewise.
2447         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2448
2449 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2450
2451         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2452         gdb_bfd_ref_ptr.
2453         <~dwo_file>: Remove call to gdb_bfd_unref.
2454         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2455         gdb_bfd_ref_ptr::get.
2456
2457 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2458
2459         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2460         type to htab_up.
2461         * dwarf2read.c (struct dwo_file): Initialize fields.
2462         <~dwo_file>: New.
2463         (free_dwo_file): Remove, move content to ~dwo_file.
2464         (struct dwo_file_deleter): Remove.
2465         (dwo_file_up>: Remove custom deleter.
2466         (free_dwo_files): Remove.
2467         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2468         dwo_files.
2469         (process_skeletonless_type_units): Call unique_ptr::get.
2470         (allocate_dwo_file_hash_table): Add deleter to created hash
2471         table.  Change return type to htab_up.
2472         (lookup_dwo_file_slot): Don't memset dwo_file, call
2473         unique_ptr::get.
2474         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2475         (create_dwo_unit_in_dwp_v2): Likewise.
2476         (open_and_init_dwo_file): Likewise.
2477         (free_dwo_file_from_slot): Remove.
2478
2479 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2480
2481         * dwarf2read.h (struct dwarf2_section_info) <readin,
2482         is_virtual>: Change type to bool.
2483         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2484         true instead of 1.
2485
2486 2019-06-19  Tom Tromey  <tom@tromey.com>
2487
2488         * tui/tui-data.h (tui_init_content_element): Don't declare.
2489
2490 2019-06-19  Tom Tromey  <tom@tromey.com>
2491
2492         * tui/tui-data.h (tui_init_win_info): Don't declare.
2493
2494 2019-06-19  Tom de Vries  <tdevries@suse.de>
2495
2496         * dwarf2read.h (abstract_to_concrete): Change type to
2497         std::unordered_map<sect_offset, std::vector<sect_offset>,
2498         gdb::hash_enum<sect_offset>>.
2499
2500 2019-06-19  Tom Tromey  <tromey@adacore.com>
2501
2502         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2503         EVAL_AVOID_SIDE_EFFECTS specially.
2504
2505 2019-06-19  Tom Tromey  <tromey@adacore.com>
2506
2507         * source-cache.c (highlighter): New global.
2508         (source_cache::get_source_lines): Create a highlighter on demand.
2509
2510 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2511
2512         * defs.h (deprecated_interactive_hook): Delete declaration.
2513         * interps.c (clear_interpreter_hooks): Remove use of
2514         deprecated_interactive_hook.
2515         * top.c (deprecated_interactive_hook): Delete definition.
2516         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2517
2518 2019-06-18  Tom de Vries  <tdevries@suse.de>
2519
2520         PR gdb/24515
2521         * dwarf2read.h (abstract_to_concrete): Change type from
2522         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2523         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2524         * dwarf2read.c (read_variable): Update.
2525         (dwarf2_fetch_die_loc_sect_off): Update.
2526
2527 2019-06-17  Tom de Vries  <tdevries@suse.de>
2528
2529         PR gdb/24617
2530         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2531         accessing parent[parent_len - 1].
2532
2533 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2534
2535         PR gdb/24364
2536         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2537         call dtrace_process_dof with NULL dof.
2538
2539 2019-06-16  Tom de Vries  <tdevries@suse.de>
2540
2541         PR gdb/24445
2542         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2543
2544 2019-06-16  Tom Tromey  <tom@tromey.com>
2545
2546         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2547         (make_all_visible): Use address of member.
2548
2549 2019-06-16  Tom Tromey  <tom@tromey.com>
2550
2551         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2552         (tui_free_window, free_content, free_content_elements): Remove
2553         unnecessary cast.
2554         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2555         cast.
2556         * tui/tui-regs.c (tui_show_register_group)
2557         (tui_display_registers_from, tui_display_reg_element_at_line):
2558         Remove unnecessary cast.
2559
2560 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2561
2562         * linux-nat.c (normal_mask): Delete.
2563         (_initialize_linux_nat): Don't initialise normal_mask.
2564
2565 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2566
2567         PR gdb/24445
2568         * dwarf-index-write.h (write_psymtabs_to_index): Add
2569         dwz_basename parameter.
2570         * dwarf-index-write.c (write_gdbindex): Move file writing to
2571         write_gdbindex_1.  Change return type void.
2572         (assert_file_size): Move up, remove filename parameter.
2573         (write_gdbindex_1): New function.
2574         (write_debug_names): Change return type to void, call
2575         assert_file_size.
2576         (struct index_wip_file): New struct.
2577         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2578         file logic to index_wip_file.  Write index for dwz file if
2579         needed.
2580         (save_gdb_index_command): Pass basename of dwz file, if present.
2581         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2582         build-id of dwz file, if present.
2583         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2584         (dwarf2_get_dwz_file): Likewise.
2585         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2586         (dwarf2_get_dwz_file): Likewise.
2587
2588 2019-06-16  Tom Tromey  <tom@tromey.com>
2589
2590         * coffread.c (process_coff_symbol): Use xstrdup.
2591         * value.c (create_internalvar): Use xstrdup.
2592
2593 2019-06-16  Tom Tromey  <tom@tromey.com>
2594
2595         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2596         * breakpoint.c (stopin_command, stopat_command)
2597         (until_break_command, decode_location_default): Remove unnecessary
2598         cast.
2599         * utils.c (subset_compare): Remove unnecessary cast.
2600         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2601         cast.
2602         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2603         cast.
2604         * infcmd.c (path_command): Remove unnecessary cast.
2605         * coffread.c (decode_type): Remove unnecessary cast.
2606         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2607         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2608         * tui/tui-stack.c (tui_show_locator_content)
2609         (tui_show_frame_info): Remove unnecessary cast.
2610         * tui/tui-win.c (tui_scroll_forward_command)
2611         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2612         (parse_scrolling_args): Remove unnecessary cast.
2613         * tui/tui-data.c (init_win_info, tui_del_window)
2614         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2615         (free_content_elements): Remove unnecessary cast.
2616         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2617         unnecessary cast.
2618         * tui/tui-source.c (tui_set_source_content)
2619         (tui_vertical_source_scroll): Remove unnecessary cast.
2620         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2621         cast.
2622         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2623         * tui/tui-regs.c (tui_display_registers_from)
2624         (tui_display_register): Remove unnecessary cast.
2625         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2626         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2627         (make_visible): Remove unnecessary cast.
2628         * tui/tui-winsource.c (tui_erase_source_content)
2629         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2630         unnecessary cast.
2631         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2632         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2633         * stabsread.c (read_type, read_array_type, read_range_type):
2634         Remove unnecessary cast.
2635         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2636         (parse_symbol, parse_type, upgrade_type, parse_external)
2637         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2638         unnecessary cast.
2639         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2640
2641 2019-06-16  Tom Tromey  <tom@tromey.com>
2642
2643         * tui/tui-data.c (tui_alloc_generic_win_info)
2644         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2645         checks.
2646
2647 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2648             Andrew Burgess  <andrew.burgess@embecosm.com>
2649
2650         * f-typeprint.c (f_print_type): Don't return early for not
2651         associated or not allocated types.
2652         (f_type_print_varspec_suffix): Add print_rank parameter and print
2653         ranks of array types in case they dangling.
2654         (f_type_print_base): Add print_rank parameter.
2655
2656 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2657
2658         * NEWS: Mention new MI commands.
2659         * break-catch-throw.c (enum exception_event_kind): Move to
2660         breakpoint.h.
2661         (print_mention_exception_catchpoint): Output text as a single
2662         message.
2663         (catch_exception_command_1): Rename to...
2664         (catch_exception_event): ...this, make non-static, update header
2665         command, and change some parameter types.
2666         (catch_catch_command): Update for changes to
2667         catch_exception_command_1.
2668         (catch_throw_command): Likewise.
2669         (catch_rethrow_command): Likewise.
2670         * breakpoint.c (enum exception_event_kind): Delete.
2671         * breakpoint.h (enum exception_event_kind): Moved here from
2672         break-catch-throw.c.
2673         (catch_exception_event): Declare.
2674         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2675         (mi_cmd_catch_throw): New function.
2676         (mi_cmd_catch_rethrow): New function.
2677         (mi_cmd_catch_catch): New function.
2678         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2679         'catch-catch' entries.
2680         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2681         (mi_cmd_catch_rethrow): Declare.
2682         (mi_cmd_catch_catch): Declare.
2683
2684 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2685
2686         * annotate.c (annotate_source_line): Change return type to void,
2687         update implementation to match.
2688         * annotate.h (annotate_source_line): Change return type to void,
2689         update header comment.
2690         * stack.c (print_frame_info): Don't change what frame information
2691         is printed based on whether annotations are on or not.
2692
2693 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2694
2695         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2696         (annotate_source): Make static.
2697         (annotate_source_line): Moved from source.c and renamed from
2698         identify_source_line.  Update the return type.
2699         * annotate.h (annotate_source): Delete declaration.
2700         (annotate_source_line): Declaration moved from source.h, and
2701         renamed from identify_source_line.  Return type updated.
2702         * source.c (identify_source_line): Moved to annotate.c and renamed
2703         to annotate_source_line.
2704         (info_line_command): Remove check of annotation_level.
2705         * source.h (identify_source_line): Move declaration to annotate.h
2706         and rename to annotate_source_line.
2707         * stack.c: Add 'annotate.h' include.
2708         (print_frame_info): Remove check of annotation_level before
2709         calling annotate_source_line.
2710
2711 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2712
2713         * source-cache.c (source_cache::get_plain_source_lines): Use
2714         open_source_file_with_line_charpos instead of just
2715         open_source_file, remove call to find_source_lines.
2716         (source_cache::get_source_lines): Likewise.
2717         * source.c (find_source_lines): Make static.
2718         (get_filename_and_charpos): Renamed into...
2719         (open_source_file_with_line_charpos): ..this along with changes to
2720         return a scoped_fd, and some other minor clean ups.
2721         (identify_source_line): Use open_source_file_with_line_charpos.
2722         (search_command_helper): Use open_source_file_with_line_charpos
2723         instead of just open_source_file, remove call to
2724         find_source_lines.
2725         * source.h (open_source_file_with_line_charpos): Declare new
2726         function.
2727         (find_source_lines): Delete declaration.
2728
2729 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2730
2731         * source.c (get_filename_and_charpos): Remove fullname
2732         parameter.
2733         (identify_source_line): Update call to get_filename_and_charpos.
2734
2735 2019-06-14  Tom Tromey  <tromey@adacore.com>
2736
2737         PR gdb/24502:
2738         * ui-style.h (skip_ansi_escape): Update comment.
2739         * ui-file.h (class no_terminal_escape_file): New class.
2740         * ui-file.c (no_terminal_escape_file::write)
2741         (no_terminal_escape_file::puts): New methods.
2742         * cli/cli-logging.c (handle_redirections): Use
2743         no_terminal_escape_file.
2744
2745 2019-06-14  Tom Tromey  <tromey@adacore.com>
2746
2747         * NEWS: Move convenience variable news above Python news.
2748
2749 2019-06-14  Tom Tromey  <tom@tromey.com>
2750
2751         * gnulib: Move directory to top-level.
2752         * configure.ac: Don't configure gnulib.
2753         * configure: Rebuild.
2754         * common/common-defs.h: Use new path to gnulib.
2755         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2756         (GNULIB_H): Remove.
2757         (INCGNU): Look in new gnulib location.
2758         (HFILES_NO_SRCDIR): Remove gnulib files.
2759         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2760         (generated_files): Remove GNULIB_H.
2761         ($(LIBGNU), all-lib): Remove targets.
2762         (distclean): Don't mention GNULIB_BUILDDIR.
2763         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2764
2765 2019-06-14  Tom Tromey  <tromey@adacore.com>
2766
2767         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2768         Warn if symbol file does not provide any symbols.
2769
2770 2019-06-14  Tom Tromey  <tromey@adacore.com>
2771
2772         * source.c (find_and_open_source): Respect basenames_may_differ.
2773
2774 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2775
2776         * annotate.c (annotate_breakpoints_invalid): Make use of
2777         scoped_restore_terminal_state.
2778         (annotate_frames_invalid): Likewise.
2779
2780 2019-06-14  Tom Tromey  <tromey@adacore.com>
2781
2782         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2783         allow assignment to an internalvar.
2784
2785 2019-06-14  Tom Tromey  <tromey@adacore.com>
2786
2787         * ada-lex.l: Allow "_" in attribute names.
2788
2789 2019-06-14  Tom Tromey  <tromey@adacore.com>
2790
2791         PR gdb/24653:
2792         * regcache.c (registers_changed): Don't call alloca.
2793         * top.c (execute_command): Don't call alloca.
2794
2795 2019-06-13  Pedro Alves  <palves@redhat.com>
2796
2797         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2798         'expression'.  When parsing an expression, error out if there's
2799         junk after "unlimited".
2800         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2801         (do_set_command): Adjust calls to is_unlimited_literal.
2802
2803 2019-06-13  Pedro Alves  <palves@redhat.com>
2804
2805         * compile/compile.c (make_compile_options_def_group): Add braces
2806         around array_view initializer.
2807         * thread.c (make_thread_apply_all_options_def_group)
2808         (make_thread_apply_all_options_def_group): Likewise.
2809
2810 2019-06-13  Pedro Alves  <palves@redhat.com>
2811
2812         * NEWS (New commands): Mention "maint test-options
2813         require-delimiter", "maint test-options unknown-is-error", "maint
2814         test-options unknown-is-operand" and "maint show
2815         test-options-completion-result".
2816         (New command options, command completion): New section.
2817         (Completion improvements): New section.
2818         Mention that you can abbreviate "unlimited".
2819
2820 2019-06-13  Pedro Alves  <palves@redhat.com>
2821
2822         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2823         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2824         * unittests/cli-utils-selftests.c (test_parse_flags)
2825         (test_parse_flags_qcs): Delete.
2826         (test_cli_utils): Don't call deleted functions.
2827
2828 2019-06-13  Pedro Alves  <palves@redhat.com>
2829
2830         * thread.c: Include "cli/cli-option.h".
2831         (tp_array_compar_ascending): Global.
2832         (tp_array_compar): Delete function.
2833         (tp_array_compar_ascending, tp_array_compar_descending): New
2834         functions.
2835         (ascending_option_def, qcs_flag_option_def)
2836         (thr_qcs_flags_option_defs)
2837         (make_thread_apply_all_options_def_group)
2838         (make_thread_apply_options_def_group): New.
2839         (thread_apply_all_command): Use gdb::option::process_options.
2840         (thread_apply_command_completer)
2841         (thread_apply_all_command_completer): New.
2842         (thread_apply_command): Use gdb::option::process_options.
2843         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2844         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2845         to generate help text of "thread apply".  Adjust "taas"'s help.
2846         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2847         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2848
2849 2019-06-13  Pedro Alves  <palves@redhat.com>
2850
2851         * thread.c (thread_apply_command): Check for invalid TID with
2852         isdigit instead of !isalpha.
2853
2854 2019-06-13  Pedro Alves  <palves@redhat.com>
2855
2856         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2857         (validate_flags_qcs): New.
2858         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2859         (validate_flags_qcs): Declare.
2860         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2861         (make_frame_apply_options_def_group): New.
2862         (frame_apply_command_count): Process options with
2863         gdb::option::process_options.
2864         (frame_apply_completer): New.
2865         (frame_apply_level_completer, frame_apply_all_completer)
2866         (frame_apply_completer): New.
2867         (_initialize_stack): Update help of "frame apply", "frame apply
2868         level", "frame apply all" and "faas" to mention supported options
2869         and install command completers.
2870         * stack.h (frame_apply_all_completer): Declare.
2871         * thread.c: Include "stack.h".
2872         (tfaas_command): Add "--".
2873         (_initialize_thread): Update help "tfaas" to mention supported
2874         options and install command completer.
2875
2876 2019-06-13  Pedro Alves  <palves@redhat.com>
2877
2878         * completer.c (complete_nested_command_line): New.
2879         (gdb_completion_word_break_characters_throw): Add assertion.
2880         * completer.h (complete_nested_command_line): Declare.
2881
2882 2019-06-13  Pedro Alves  <palves@redhat.com>
2883
2884         * stack.c (parse_backtrace_qualifiers): New.
2885         (backtrace_command): Use it.
2886         (backtrace_command_completer): Complete on qualifiers.
2887
2888 2019-06-13  Pedro Alves  <palves@redhat.com>
2889
2890         * frame.c: Include "cli/cli-option.h.
2891         (user_set_backtrace_options): New.
2892         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2893         Delete.
2894         (get_prev_frame): Adjust.
2895         (boolean_option_def, uinteger_option_def)
2896         (set_backtrace_option_defs): New.
2897         (_initialize_frame): Adjust and use
2898         gdb::option::add_setshow_cmds_for_options to install "set
2899         backtrace past-main" and "set backtrace past-entry".
2900         * frame.h: Include "cli/cli-option.h".
2901         (struct frame_print_options): Forward declare.
2902         (print_frame_arguments_all, print_frame_arguments_scalars)
2903         (print_frame_arguments_none): Declare.
2904         (print_entry_values): Delete declaration.
2905         (struct frame_print_options, user_frame_print_options): New.
2906         (struct set_backtrace_options): New.
2907         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2908         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2909         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2910         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2911         (list_args_or_locals): Add frame_print_options parameter.
2912         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2913         * python/py-framefilter.c (enumerate_args): Pass down
2914         USER_FRAME_PRINT_OPTIONS.
2915         * stack.c: Include "cli/cli-option.h".
2916         (print_frame_arguments_all, print_frame_arguments_scalars)
2917         (print_frame_arguments_none): Declare.
2918         (print_raw_frame_arguments, print_entry_values): Delete.
2919         (user_frame_print_options): New.
2920         (boolean_option_def, enum_option_def, frame_print_option_defs):
2921         New.
2922         (struct backtrace_cmd_options): New.
2923         (bt_flag_option_def): New.
2924         (backtrace_command_option_defs): New.
2925         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2926         (print_frame_arg, read_frame_arg, print_frame_args)
2927         (print_frame_info, print_frame): Add frame_print_options parameter
2928         and use it.
2929         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2930         (backtrace_command_1): Add frame_print_options and
2931         backtrace_cmd_options parameters and use them.
2932         (make_backtrace_options_def_group): New.
2933         (backtrace_command): Process command options with
2934         gdb::option::process_options.
2935         (backtrace_command_completer): New.
2936         (_initialize_stack): Extend "backtrace"'s help to mention
2937         supported options.  Install completer for "backtrace".
2938         Install some settings commands with add_setshow_cmds_for_options.
2939
2940 2019-06-13  Pedro Alves  <palves@redhat.com>
2941
2942         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2943         and that "set/show print raw frame-arguments" are now deprecated.
2944
2945         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2946         command.
2947         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2948         * stack.c (_initialize_stack): Install "set/show print
2949         raw-frame-arguments", and deprecate "set/show print raw
2950         frame-arguments".
2951         * valprint.c (_initialize_valprint): Deprecate "set/show print
2952         raw".
2953
2954 2019-06-13  Pedro Alves  <palves@redhat.com>
2955
2956         * compile/compile.c (struct compile_options): New.
2957         (compile_flag_option_def, compile_command_option_defs)
2958         (make_compile_options_def_group): New.
2959         (compile_file_command): Handle options with
2960         gdb::option::process_options.
2961         (compile_file_command_completer): New function.
2962         (compile_code_command): Handle options with
2963         gdb::option::process_options.
2964         (compile_code_command_completer): New function.
2965         (_initialize_compiler): Install completers for "compile code" and
2966         "compile file".  Mention available options in "compile code" and
2967         "compile code"'s help.
2968         * completer.c (advance_to_completion_word): New, factored out from
2969         ...
2970         (advance_to_expression_complete_word_point): ... this.
2971         (advance_to_filename_complete_word_point): New.
2972         * completer.h (advance_to_filename_complete_word_point): New
2973         declaration.
2974
2975 2019-06-13  Pedro Alves  <palves@redhat.com>
2976
2977         * compile/compile.c: Include "cli/cli-option.h".
2978         (compile_print_value): Scope data pointer is now a
2979         value_print_options pointer; adjust.
2980         (compile_print_command): Process options.  Scope data pointer is
2981         now a value_print_options pointer; adjust.
2982         (_initialize_compile): Update "compile print"'s help to include
2983         supported options.  Install a completer for "compile print".
2984         * cp-valprint.c (show_vtblprint, show_objectprint)
2985         (show_static_field_print): Delete.
2986         (_initialize_cp_valprint): Don't install "set print
2987         static-members", "set print vtbl", "set print object" here.
2988         * printcmd.c: Include "cli/cli-option.h" and
2989         "common/gdb_optional.h".
2990         (print_command_parse_format): Rework to fill in a
2991         value_print_options instead of a format_data.
2992         (print_value): Change parameter type from format_data pointer to
2993         value_print_options reference.  Adjust.
2994         (print_command_1): Process options.  Adjust to pass down a
2995         value_print_options.
2996         (print_command_completer): New.
2997         (_initialize_printcmd): Install print_command_completer as
2998         handle_brkchars completer for the "print" command.  Update
2999         "print"'s help to include supported options.
3000         * valprint.c: Include "cli/cli-option.h".
3001         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3002         here from cp-valprint.c.
3003         (boolean_option_def, uinteger_option_def)
3004         (value_print_option_defs, make_value_print_options_def_group):
3005         New.  Use gdb::option::add_setshow_cmds_for_options to install
3006         "set print elements", "set print null-stop", "set print repeats",
3007         "set print pretty", "set print union", "set print array", "set
3008         print address", "set print symbol", "set print array-indexes".
3009         * valprint.h: Include <string> and "cli/cli-option.h".
3010         (make_value_print_options_def_group): Declare.
3011         (print_value): Change parameter type from format_data pointer to
3012         value_print_options reference.
3013         (print_command_completer): Declare.
3014
3015 2019-06-13  Pedro Alves  <palves@redhat.com>
3016
3017         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3018         (COMMON_SFILES): Add maint-test-settings.c.
3019         * cli/cli-decode.c (boolean_enums): New global, factored out from
3020         ...
3021         (add_setshow_boolean_cmd): ... here.
3022         * cli/cli-decode.h (boolean_enums): Declare.
3023         * cli/cli-option.c: New file.
3024         * cli/cli-option.h: New file.
3025         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3026         factored out from ...
3027         (parse_cli_boolean_value(const char *)): ... this.
3028         (is_unlimited_literal): Change parameter type to pointer to
3029         pointer.  Adjust and advance ARG pointer.
3030         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3031         (parse_cli_var_enum): New, factored out from ...
3032         (do_set_command): ... this.  Adjust.
3033         * cli/cli-setshow.h (parse_cli_boolean_value)
3034         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3035         (parse_cli_var_enum): Declare.
3036         * cli/cli-utils.c: Include "cli/cli-option.h".
3037         (get_ulongest): New.
3038         * cli/cli-utils.h (get_ulongest): Declare.
3039         (check_for_argument): New overloads.
3040         * maint-test-options.c: New file.
3041
3042 2019-06-13  Pedro Alves  <palves@redhat.com>
3043
3044         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3045         parse a range if "-" is at the end of the string.
3046
3047 2019-06-13  Pedro Alves  <palves@redhat.com>
3048
3049         * cli/cli-setshow.c (parse_auto_binary_operation)
3050         (parse_cli_boolean_value): Don't allow "o".
3051
3052 2019-06-13  Pedro Alves  <palves@redhat.com>
3053
3054         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3055         * NEWS: Mention maint test-settings KIND.
3056         * maint-test-settings.c: New file.
3057
3058 2019-06-13  Pedro Alves  <palves@redhat.com>
3059
3060         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3061         completer.
3062         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3063         "set" completers.
3064
3065 2019-06-13  Pedro Alves  <palves@redhat.com>
3066
3067         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3068         after item.
3069
3070 2019-06-13  Pedro Alves  <palves@redhat.com>
3071
3072         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3073
3074 2019-06-13  Pedro Alves <palves@redhat.com>
3075
3076         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3077         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3078         call.
3079         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3080         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3081         calls.
3082         (check_for_argument): Skip spaces after argument.
3083
3084 2019-06-13  Pedro Alves  <palves@redhat.com>
3085
3086         * thread.c (thread_apply_command): Adjust TID parsing.
3087         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3088         detected before end of string.
3089         (tid_is_in_list): Error out if LIST is invalid.
3090
3091 2019-06-13  Pedro Alves  <palves@redhat.com>
3092
3093         * completer.c (complete_line_internal_1): Rewind completion word
3094         point.
3095         (completion_tracker::advance_custom_word_point_by): Change
3096         parameter type to int.
3097         * completer.h (completion_tracker::advance_custom_word_point_by):
3098         Likewise.
3099
3100 2019-06-13  Pedro Alves  <palves@redhat.com>
3101
3102         * completer.c (advance_to_completion_word): Handle delimiters.
3103
3104 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3105
3106         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3107
3108 2019-06-11  Tom Tromey  <tom@tromey.com>
3109
3110         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3111         (xmalloc_failed): Move to alloc.c.
3112         * alloc.c: New file.
3113         * Makefile.in (COMMON_SFILES): Add alloc.c.
3114
3115 2019-06-11  Tom Tromey  <tom@tromey.com>
3116
3117         * nat/linux-waitpid.c: Don't include server.h.
3118         (linux_debug): Remove.
3119         (my_waitpid): Update.
3120
3121 2019-06-11  Tom Tromey  <tromey@adacore.com>
3122
3123         * infcall.c (_initialize_infcall): Remove trailing newline from
3124         help.
3125         * user-regs.c (_initialize_user_regs): Remove trailing newline
3126         from help.
3127         * typeprint.c (_initialize_typeprint): Remove trailing newline
3128         from help.
3129         * reverse.c (_initialize_reverse): Remove trailing newlines from
3130         help.
3131         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3132         from help.
3133         * language.c (add_set_language_command): Remove trailing newline
3134         from help.
3135         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3136         help.
3137         * disasm.c (_initialize_disasm): Remove trailing newline from
3138         help.
3139         * top.c (init_main): Remove trailing newline from help.
3140         * interps.c (_initialize_interpreter): Remove trailing newline
3141         from help.
3142         * btrace.c (_initialize_btrace): Remove trailing newlines from
3143         help.
3144         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3145         from help.
3146         * python/python.c (_initialize_python): Remove trailing newline
3147         from help.
3148         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3149         help.
3150         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3151         from help.  Reformat some text.
3152         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3153         from help.
3154         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3155         newline from help.
3156
3157 2019-06-11  Tom Tromey  <tromey@adacore.com>
3158
3159         * darwin-nat.c (darwin_decode_exception_message)
3160         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3161
3162 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3163
3164         * valops.c (value_slice): Check for not allocated or not
3165         associated values.
3166
3167 2019-06-10  Tom de Vries  <tdevries@suse.de>
3168
3169         PR gdb/24618
3170         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3171         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3172         invalid.
3173
3174 2019-06-10  Tom de Vries  <tdevries@suse.de>
3175
3176         PR gdb/24611
3177         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3178         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3179
3180 2019-06-10  Tom de Vries  <tdevries@suse.de>
3181
3182         PR symtab/24545
3183         * symtab.c (struct demangled_name_entry): Add language field.
3184         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3185         static minimal symbol".  Set and use language field.
3186
3187 2019-06-10  Tom Tromey  <tromey@adacore.com>
3188
3189         * ada-lang.c (_initialize_ada_language): Update help text.
3190
3191 2019-06-10  Tom Tromey  <tromey@adacore.com>
3192
3193         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3194         with a newline.
3195         * guile/guile.c (handle_boot_error): Don't end warning with a
3196         newline.
3197         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3198         warning with a newline.
3199         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3200         newline.
3201         (s12z_frame_cache): Likewise.
3202         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3203         a newline.
3204         * solib-svr4.c (disable_probes_interface): Don't end warning with
3205         a newline.
3206         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3207         newline.
3208         * python/python.c (do_finish_initialization): Don't end warning
3209         with a newline.
3210
3211 2019-06-10  Tom Tromey  <tom@tromey.com>
3212
3213         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3214         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3215         gdbpy_enter.
3216
3217 2019-06-10  Tom Tromey  <tromey@adacore.com>
3218
3219         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3220         data.
3221         (elf_new_init): Don't call stabsread_new_init.
3222         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3223         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3224         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3225
3226 2019-06-10  Tom de Vries  <tdevries@suse.de>
3227
3228         PR symtab/16264
3229         PR symtab/24517
3230         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3231
3232 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3233
3234         * source.c (find_and_open_source): Also rewrite relative file
3235         names.
3236
3237 2019-04-26  Amos Bird  <amosbird@gmail.com>
3238
3239         * annotate.c (annotate_thread_exited): Add "thread-exited"
3240         annotation.
3241
3242 2019-06-06  Tom Tromey  <tromey@adacore.com>
3243
3244         * maint.h (class scoped_command_stats): Use
3245         DISABLE_COPY_AND_ASSIGN.
3246         <print_time>: New method.
3247         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3248         print_time.
3249         (scoped_command_stats::print_time): New method.
3250
3251 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3252
3253         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3254         instructions of lengths 6 or 8 bytes.
3255
3256 2019-06-04  Pedro Alves  <palves@redhat.com>
3257
3258         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3259
3260         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3261         * breakpoint.c (condition_completer): Likewise.
3262         * cli/cli-dump.c (scan_expression): Likewise.
3263         * common/filestuff.c (mkdir_recursive): Likewise.
3264         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3265         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3266         (gdb_abspath): Likewise.
3267         * compile/compile-cplus-types.c
3268         (compile_cplus_instance::decl_name): Likewise.
3269         * completer.c (complete_explicit_location):
3270         (signal_completer, reg_or_group_completer_1): Likewise.
3271         * cp-support.c (cp_remove_params_if_any): Likewise.
3272         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3273         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3274         * infcmd.c (strip_bg_char): Likewise.
3275         * linespec.c (copy_token_string): Likewise.
3276         * mi/mi-main.c (output_cores): Likewise.
3277         * psymtab.c (psymtab_search_name):
3278         * symfile.c (test_set_ext_lang_command): Likewise.
3279         * target.c (target_fileio_read_stralloc): Likewise.
3280         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3281         * value.c (complete_internalvar): Likewise.
3282
3283 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3284
3285         Add objfile property to gdb.Type.
3286         * NEWS: Mention Python API addition.
3287         * python/py-type.c (typy_get_objfile): New method.
3288
3289 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3290
3291         * NEWS: Mention the new set|show style [title|highlight].
3292         Mention changes to "show style", "help" and "apropos".
3293
3294 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3295
3296         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3297         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3298         instead of print_help_for_command.
3299         (print_doc_of_command): New function.
3300         (help_list): Add 'apropos -v word' suggestion.
3301         (print_help_for_command): Style the command name using title style.
3302         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3303         (_initialize_cli_cmds): Describe -v in apropos_command help.
3304
3305 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3306
3307         * cli/cli-style.h (cli_style_option): Add name in constructor,
3308         add m_name class member, add constructor with intensity,
3309         add name class function.
3310         (cli_style_option::add_setshow_commands): Remove name argument.
3311         (highlight_style, title_style): New styles.
3312         * cli/cli-style.c (do_show): New function that shows a style
3313         characteristic styling the style name with itself.
3314         (set_style_name): New function.
3315         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3316         Update all callers according to the changes in cli/cli-style.h.
3317         * utils.h (fputs_highlighted): New function.
3318         * utils.c (fputs_highlighted): Likewise.
3319
3320 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3321
3322         * NEWS: Mention new pipe command and new convenience variables.
3323
3324 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3325
3326         * cli/cli-cmds.c (pipe_command): New function.
3327         (_initialize_cli_cmds): Call add_com for pipe_command.
3328         Define | as an alias for pipe.
3329         (exit_status_set_internal_vars): New function.
3330         (shell_escape): Call exit_status_set_internal_vars.
3331         cli/cli-decode.c (find_command_name_length): Recognize | as
3332         a single character command.
3333
3334 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3335
3336         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3337         top.c (execute_command_to_ui_file): New function, mostly a copy
3338         of execute_command_to_string.
3339         (execute_command_to_string): Implement by calling
3340         execute_command_to_ui_file.
3341
3342 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3343
3344         * top.h (saved_command_line): Remove declaration.
3345         * top.c (previous_saved_command_line, previous_repeat_arguments):
3346         New variables.
3347         (saved_command_line): Make static, define together with other
3348         'repeat variables'.
3349         (dont_repeat): Clear repeat_arguments.
3350         (repeat_previous, get_saved_command_line, save_command_line):
3351         New functions.
3352         (gdb_init): Initialize saved_command_line
3353         and previous_saved_command_line.
3354         * main.c (captured_main_1): Remove saved_command_line initialization.
3355         * event-top.c (handle_line_of_input): Update to use
3356         the new 'repeat' related functions instead of direct access to
3357         saved_command_line.
3358         * command.h (repeat_previous, get_saved_command_line,
3359         save_command_line): New declarations.
3360         (dont_repeat): Add comment.
3361
3362 2019-05-30  Tom Tromey  <tromey@adacore.com>
3363
3364         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3365         Fix comment.
3366         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3367
3368 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3369
3370         PR cli/24587
3371         * completer.c (complete): Initialize variable word.
3372
3373 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3374
3375         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3376         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3377         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3378         'body' is NULL to the outter 'if', protecting the '!is_define'
3379         situation as well.
3380
3381 2019-05-29  Tom Tromey  <tromey@adacore.com>
3382
3383         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3384         (dwarf_unknown): New function.
3385         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3386         (dwarf_type_encoding_name): Use dwarf_unknown.
3387
3388 2019-05-29  Tom Tromey  <tromey@adacore.com>
3389
3390         PR c++/20020:
3391         * cp-valprint.c (cp_print_value_fields): Call
3392         cp_print_static_field inside "try".
3393
3394 2019-05-29  Tom Tromey  <tromey@adacore.com>
3395
3396         * inflow.c (struct terminal_info): Add default operator=.
3397         * configure: Rebuild.
3398         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3399         -Wdeprecated-copy-dtor, -Wredundant-move.
3400
3401 2019-05-29  Tom Tromey  <tromey@adacore.com>
3402
3403         * NEWS: Add entry.
3404         * infcmd.c (print_return_value_1): Handle finish_print
3405         option.
3406         (show_print_finish): New function.
3407         (_initialize_infcmd): Add "set/show print finish" commands.
3408         * valprint.c (user_print_options): Initialize new member.
3409         * valprint.h (struct value_print_options) <finish_print>: New
3410         member.
3411
3412 2019-05-28  Tom Tromey  <tromey@adacore.com>
3413
3414         * ada-lang.c (ada_remove_Xbn_suffix)
3415         (find_old_style_renaming_symbol)
3416         (parse_old_style_renaming): Remove.
3417         (ada_find_renaming_symbol): Don't call
3418         find_old_style_renaming_symbol.
3419         (ada_is_renaming_symbol): Rename from
3420         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3421         bool.  Now static.
3422         (ada_read_var_value): Update and simplify.
3423         * ada-exp.y (write_var_or_type): Remove old code.
3424
3425 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3426
3427         * event-top.c: Remove include comment.
3428         * inflow.c (class scoped_ignore_sigttou): Move from here...
3429         * inflow.h (class scoped_ignore_sigttou): ...to here.
3430         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3431         * top.c:  Remove include comment.
3432
3433 2019-05-27  Tom Tromey  <tom@tromey.com>
3434
3435         * NEWS: Fix typo.
3436
3437 2019-05-22  Tom Tromey  <tromey@adacore.com>
3438
3439         * target.c (target_follow_exec): Constify parameter.
3440         * target-delegates.c: Rebuild.
3441         * remote.c (remote_target::follow_exec): Constify parameter.
3442         * infrun.c (follow_exec): Constify parameter.
3443         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3444         (target_follow_exec): Likewise.
3445
3446 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3447
3448         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3449         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3450
3451 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3452
3453         * NEWS: Add debugredirect and testsuite sections.
3454
3455 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3456
3457         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3458         target descriptions using exclusively floating point register name
3459         aliases.
3460
3461 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3462
3463         PR gdb/18644:
3464         * f-lang.c (build_fortran_types): Handle the case where
3465         gdbarch_floatformat_for_type returns a nullptr.
3466
3467 2019-05-21  Tom de Vries  <tdevries@suse.de>
3468
3469         PR cli/24587
3470         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3471
3472 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3473
3474         PR gdb/18644:
3475         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3476         16-byte floats.
3477         * i386-tdep.c (i386_floatformat_for_type): Use
3478         floatformats_ia64_quad for the 16-byte floating point component
3479         within a fortran 32-byte complex number.
3480
3481 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3482
3483         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3484         delete default constructor.
3485         (find_partial_die): Update to return const struct.
3486         (partial_die_parent_scope): Move variable declaration into scope
3487         of its use and change its type to auto.
3488         (guess_partial_die_structure_name): Likewise.
3489         (partial_die_info::fixup): Likewise.
3490
3491 2019-05-17  Tom Tromey  <tromey@adacore.com>
3492
3493         * source.c (find_and_open_source): Remove cast.
3494
3495 2019-05-17  Tom Tromey  <tromey@adacore.com>
3496
3497         * annotate.c (annotate_source): Make "filename" const.
3498         * annotate.h (annotate_source): Use const.
3499
3500 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3501
3502         * disasm.c (set_disassembler_options): Send errors to stderr.
3503
3504 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3505
3506         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3507         (cli_interp_base::set_logging): Check debug_redirect.
3508         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3509         * cli/cli-logging.c (debug_redirect): Add static variable.
3510         (pop_output_files): Add default param.
3511         (handle_redirections): Print debug setting.
3512         (show_logging_command): Likewise.
3513         (_initialize_cli_logging): Add debugredirect command.
3514         * interps.c (current_interp_set_logging): Add debug_redirect
3515         parameter.
3516         * interps.h (set_logging): Add debug_redirect parameter.
3517         (current_interp_set_logging): Likewise.
3518         * mi/mi-common.h: Likewise.
3519         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3520
3521 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3522             Tom Tromey  <tromey@adacore.com>
3523
3524         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3525         directly.
3526         * cli/cli-interp.h (make_logging_output): Remove declaration.
3527         * cli/cli-logging.c (make_logging_output): Remove function.
3528         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3529         directly.
3530         * ui-file.c (tee_file::tee_file): Remove bools.
3531         (tee_file::~tee_file): Remove deletes.
3532         * ui-file.h (tee_file): Remove bools.
3533
3534 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3535
3536         * mi/mi-cmds.h (mi_cmd_complete): New function.
3537         * mi/mi-main.c (mi_cmd_complete): Likewise.
3538         * mi/mi-cmds.c: Define new MI command -complete.
3539         * NEWS: Mention new -complete command.
3540
3541 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3542
3543         * completer.h (complete): New function.
3544         * completer.c (complete): Likewise.
3545         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3546         function defined in completer.h.
3547
3548 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3549
3550         * MAINTAINERS (Write After Approval): Add myself.
3551
3552 2019-05-17  Tom de Vries  <tdevries@suse.de>
3553
3554         PR gdb/24094
3555         * dwarf2read.c (struct cu_partial_die_info): New struct.
3556         (find_partial_die): Return cu_partial_die_info.
3557         (partial_die_parent_scope, guess_partial_die_structure_name)
3558         (partial_die_info::fixup): Handle new return type of find_partial_die.
3559
3560 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3561
3562         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3563         "std::string", simplifying the algorithm.
3564
3565 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3566
3567         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3568         (stap_static_probe_ops::get_probes): Likewise.
3569
3570 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3571
3572         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3573         '-')" and "else if".
3574         (stap_parse_single_operand): Join checks for
3575         "gdbarch_stap_parse_special_token_p" and
3576         "gdbarch_stap_parse_special_token" in the same "if" statement.
3577         Invert check when verifying for operation on register
3578         displacement.
3579
3580 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3581
3582         * stap-probe.c (stap_get_opcode): Update comment.
3583         (stap_get_expected_argument_type): Likewise.
3584         (handle_stap_probe): Likewise.
3585
3586 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3587
3588         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3589         return type to 'bool'.  Adjust comment.  Use 'bool' when
3590         appropriate.
3591         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3592         * stap-probe.c (stap_parse_argument_1): Likewise.
3593         (stap_is_operator): Likewise.
3594         (stap_is_generic_prefix): Likewise.
3595         (stap_is_register_prefix): Likewise.
3596         (stap_is_register_indirection_prefix): Likewise.
3597         (stap_is_integer_prefix): Likewise.
3598         (stap_generic_check_suffix): Likewise.
3599         (stap_check_integer_suffix): Likewise.
3600         (stap_check_register_suffix): Likewise.
3601         (stap_check_register_indirection_suffix): Likewise.
3602         (stap_parse_register_operand): Likewise.
3603         (stap_parse_single_operand): Likewise.
3604         (stap_parse_argument_1): Likewise.
3605         (stap_probe::get_argument_count): Likewise.
3606         (stap_is_operator): Likewise.
3607
3608 2019-05-16  Tom Tromey  <tromey@adacore.com>
3609
3610         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3611         keyword to foreach.
3612
3613 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3614
3615         * linux-thread-db.c (try_thread_db_load_1): Change return type
3616         to bool.
3617         (try_thread_db_load): Likewise.
3618         (try_thread_db_load_from_pdir_1): Likewise.
3619         (try_thread_db_load_from_pdir): Likewise.
3620         (try_thread_db_load_from_sdir): Likewise.
3621         (try_thread_db_load_from_dir): Likewise.
3622         (thread_db_load_search): Likewise.
3623         (has_libpthread): Likewise.
3624         (thread_db_load): Likewise.
3625
3626 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3627
3628         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3629         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3630         NULL, and complain/return if that's the case.
3631
3632 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3633
3634         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3635         (advance, posn, abstract_read_memory): New functions.
3636         [struct mem_read_abstraction]: New struct.
3637         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3638
3639 2019-05-14  Tom Tromey  <tromey@adacore.com>
3640
3641         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3642         value is not lval_memory.
3643
3644 2019-05-14  Tom Tromey  <tromey@adacore.com>
3645
3646         * solib.c (info_sharedlibrary_command): Style the file name.
3647
3648 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3649
3650         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3651         (aarch64_vnv_type): Likewise.
3652         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3653         * common/tdesc.c: Likewise.
3654         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3655         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3656         * features/aarch64-fpu.xml: Add ieee half view.
3657         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3658         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3659         * gdbtypes.h (struct builtin_type): Likewise.
3660         (struct objfile_type): Likewise.
3661
3662 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3663
3664         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3665         typo.
3666         * location.h (string_to_event_location): Likewise.
3667
3668 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3669
3670         GDB 8.3 released.
3671
3672 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3673
3674         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3675         New variable declaration.
3676         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3677         New variable.
3678         (print_one_breakpoint): Use ui_out::test_flags and new global
3679         variable to compute use_fixed_output.
3680         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3681         Remove.
3682         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3683         (mi_multi_location_breakpoint_output_fixed): Remove.
3684         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3685         new variable.
3686         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3687         fix_multi_location_breakpoint_output flag if version >= 3.
3688         * ui-out.h (enum ui_out_flag)
3689         <fix_multi_location_breakpoint_output>: New enumerator.
3690
3691 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3692
3693         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3694
3695 2019-05-10  Tom Tromey  <tromey@adacore.com>
3696
3697         * ada-lang.c (catch_ada_completer): New function.
3698         (_initialize_ada_language): Use it.
3699
3700 2019-05-10  Tom Tromey  <tromey@adacore.com>
3701
3702         * thread.c (print_thread_info): Make "requested_threads" const.
3703         * gdbthread.h (print_thread_info): Make "requested_threads"
3704         const.
3705         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3706         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3707
3708 2019-05-08  Tom Tromey  <tom@tromey.com>
3709
3710         * gdbtypes.c (objfile_type_data): Change type.
3711         (objfile_type, _initialize_gdbtypes): Update.
3712
3713 2019-05-08  Tom Tromey  <tom@tromey.com>
3714
3715         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3716         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3717         (_initialize_dwarf2_frame): Update.
3718
3719 2019-05-08  Tom Tromey  <tom@tromey.com>
3720
3721         * objc-lang.c (objc_objfile_data): Change type.
3722         (find_methods): Update.
3723         (_initialize_objc_lang): Remove.
3724
3725 2019-05-08  Tom Tromey  <tom@tromey.com>
3726
3727         * stabsread.c (rs6000_builtin_type_data): Change type.
3728         (rs6000_builtin_type, _initialize_stabsread): Update.
3729
3730 2019-05-08  Tom Tromey  <tom@tromey.com>
3731
3732         * mips-tdep.c (mips_pdr_data): Remove.
3733         (_initialize_mips_tdep): Update.
3734
3735 2019-05-08  Tom Tromey  <tom@tromey.com>
3736
3737         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3738         (hppa_init_objfile_priv_data, read_unwind_info)
3739         (find_unwind_entry, _initialize_hppa_tdep): Update.
3740
3741 2019-05-08  Tom Tromey  <tom@tromey.com>
3742
3743         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3744         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3745         on obstack.
3746         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3747
3748 2019-05-08  Tom Tromey  <tom@tromey.com>
3749
3750         * mdebugread.c (basic_type_data): Change type.
3751         (basic_type, _initialize_mdebugread): Update.
3752
3753 2019-05-08  Tom Tromey  <tom@tromey.com>
3754
3755         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3756
3757 2019-05-08  Tom Tromey  <tom@tromey.com>
3758
3759         * nto-tdep.c (nto_inferior_data_reg): Change type.
3760         (nto_inferior_data): Update.
3761         (nto_inferior_data_cleanup, nto_new_inferior_data)
3762         (_initialize_nto_tdep): Remove.
3763         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3764
3765 2019-05-08  Tom Tromey  <tom@tromey.com>
3766
3767         * ada-lang.c (struct ada_inferior_data): Add initializers.
3768         (ada_inferior_data): Change type.
3769         (ada_inferior_data_cleanup): Remove.
3770         (get_ada_inferior_data, ada_inferior_exit)
3771         (struct ada_pspace_data): Add initializers, destructor.
3772         (ada_pspace_data_handle): Change type.
3773         (get_ada_pspace_data): Update.
3774         (ada_pspace_data_cleanup): Remove.
3775
3776 2019-05-08  Tom Tromey  <tom@tromey.com>
3777
3778         * coffread.c (struct coff_symfile_info): Add initializers.
3779         (coff_objfile_data_key): Move lower.  Change type.
3780         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3781         Update.
3782         (coff_free_info): Remove.
3783
3784 2019-05-08  Tom Tromey  <tom@tromey.com>
3785
3786         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3787         (fbsd_pspace_data_handle): Move lower.  Change type.
3788         (get_fbsd_pspace_data): Update.
3789         (fbsd_pspace_data_cleanup): Remove.
3790         (_initialize_fbsd_tdep): Update.
3791
3792 2019-05-08  Tom Tromey  <tom@tromey.com>
3793
3794         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3795         (get_ada_tasks_pspace_data): Update.
3796         (ada_tasks_pspace_data_cleanup): Remove.
3797         (_initialize_tasks): Update.
3798         (ada_tasks_inferior_data_handle): Change type.
3799         (get_ada_tasks_inferior_data): Update.
3800         (ada_tasks_inferior_data_cleanup): Remove.
3801         (struct ada_tasks_pspace_data): Add initializers.
3802
3803 2019-05-08  Tom Tromey  <tom@tromey.com>
3804
3805         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3806         * symfile-debug.c (debug_sym_get_probes): Change type.
3807         * stap-probe.c (handle_stap_probe):
3808         (stap_static_probe_ops::get_probes): Change type.
3809         * probe.h (class static_probe_ops) <get_probes>: Change type.
3810         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3811         (parse_probes_in_pspace): Update.
3812         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3813         Update.
3814         (any_static_probe_ops::get_probes): Change type.
3815         * elfread.c (elfread_data): New typedef.
3816         (probe_key): Change type.
3817         (elf_get_probes): Likewise.  Update.
3818         (probe_key_free): Remove.
3819         (_initialize_elfread): Update.
3820         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3821         Change type.
3822         (dtrace_process_dof_probe, dtrace_process_dof)
3823         (dtrace_static_probe_ops::get_probe): Change type.
3824
3825 2019-05-08  Tom Tromey  <tom@tromey.com>
3826
3827         * xcoffread.c (struct xcoff_symfile_info): Rename from
3828         coff_symfile_info.  Add initializers.
3829         (xcoff_objfile_data_key): Move lower.  Change type.
3830         (XCOFF_DATA): Rewrite.
3831         (xcoff_free_info): Remove.
3832         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3833         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3834         (xcoff_initial_scan): Update.
3835
3836 2019-05-08  Tom Tromey  <tom@tromey.com>
3837
3838         * solib-svr4.c (struct svr4_info): Add initializers and
3839         destructor.
3840         <probes_table>: Now an htab_up.
3841         (solib_svr4_pspace_data): Change type.
3842         (free_probes_table): Simplify.
3843         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3844         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3845         (probes_table_remove_objfile_probes, register_solib_event_probe)
3846         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3847         (_initialize_svr4_solib): Update.
3848
3849 2019-05-08  Tom Tromey  <tom@tromey.com>
3850
3851         * remote.c (remote_pspace_data): Change type.
3852         (remote_pspace_data_cleanup): Remove.
3853         (get_remote_exec_file, set_pspace_remote_exec_file)
3854         (_initialize_remote): Update.
3855
3856 2019-05-08  Tom Tromey  <tom@tromey.com>
3857
3858         * breakpoint.c (breakpoint_objfile_key): Change type.
3859         (get_breakpoint_objfile_data): Update.
3860         (free_breakpoint_objfile_data): Remove.
3861         (_initialize_breakpoint): Update.
3862
3863 2019-05-08  Tom Tromey  <tom@tromey.com>
3864
3865         * linux-tdep.c (struct linux_info): Add initializers.
3866         (linux_inferior_data): Move.  Change type.
3867         (invalidate_linux_cache_inf): Update.
3868         (linux_inferior_data_cleanup): Remove.
3869         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3870
3871 2019-05-08  Tom Tromey  <tom@tromey.com>
3872
3873         * auxv.c (auxv_inferior_data): Move.  Change type.
3874         (auxv_inferior_data_cleanup): Remove.
3875         (invalidate_auxv_cache_inf): Rewrite.
3876         (get_auxv_inferior_data, _initialize_auxv): Update.
3877
3878 2019-05-08  Tom Tromey  <tom@tromey.com>
3879
3880         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3881         (symfile_debug_objfile_data_key): Change type.
3882         (symfile_debug_installed, debug_qf_has_symbols)
3883         (debug_qf_find_last_source_symtab)
3884         (debug_qf_forget_cached_source_info)
3885         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3886         (debug_qf_print_stats, debug_qf_dump)
3887         (debug_qf_expand_symtabs_for_function)
3888         (debug_qf_expand_all_symtabs)
3889         (debug_qf_expand_symtabs_with_fullname)
3890         (debug_qf_map_matching_symbols)
3891         (debug_qf_expand_symtabs_matching)
3892         (debug_qf_find_pc_sect_compunit_symtab)
3893         (debug_qf_map_symbol_filenames)
3894         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3895         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3896         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3897         (debug_sym_read_linetable, debug_sym_relocate): Update.
3898         (symfile_debug_free_objfile): Remove.
3899         (install_symfile_debug_logging, _initialize_symfile_debug):
3900         Update.
3901
3902 2019-05-08  Tom Tromey  <tom@tromey.com>
3903
3904         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3905         allocate_on_obstack.
3906         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3907         (get_dwarf2_per_objfile): Update.
3908         (set_dwarf2_per_objfile): Remove.
3909         (dwarf2_has_info, dwarf2_get_section_info): Update.
3910         (dwarf2_free_objfile): Remove.
3911         (_initialize_dwarf2_read): Update.
3912
3913 2019-05-08  Tom Tromey  <tom@tromey.com>
3914
3915         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3916         initializers.
3917         <unsupported_script_warning_printed,
3918         script_not_found_warning_printed>: Now bool.
3919         (auto_load_pspace_data): Change type.
3920         (~auto_load_pspace_info): Rename from
3921         auto_load_pspace_data_cleanup.
3922         (get_auto_load_pspace_data, init_loaded_scripts_info)
3923         (clear_section_scripts, maybe_print_unsupported_script_warning)
3924         (maybe_print_script_not_found_warning, _initialize_auto_load):
3925         Update.
3926
3927 2019-05-08  Tom Tromey  <tom@tromey.com>
3928
3929         * objfiles.c (objfile_pspace_info): Add destructor and
3930         initializers.
3931         (objfiles_pspace_data): Change type.
3932         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3933         (get_objfile_pspace_data): Update.
3934         (objfiles_bfd_data): Change type.
3935         (get_objfile_bfd_data): Update.
3936         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3937
3938 2019-05-08  Tom Tromey  <tom@tromey.com>
3939
3940         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3941         Change type.
3942         (get_catch_syscall_inferior_data): Update.
3943         (catch_syscall_inferior_data_cleanup): Remove.
3944         (_initialize_break_catch_syscall): Update.
3945
3946 2019-05-08  Tom Tromey  <tom@tromey.com>
3947
3948         * inflow.c (struct terminal_info): Add destructor and
3949         initializers.
3950         (inflow_inferior_data): Change type.
3951         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3952         (get_inflow_inferior_data, inflow_inferior_exit)
3953         (swap_terminal_info, _initialize_inflow): Update.
3954
3955 2019-05-08  Tom Tromey  <tom@tromey.com>
3956
3957         * target-dcache.c (target_dcache_cleanup): Remove.
3958         (target_dcache_aspace_key): Change type.
3959         (target_dcache_init_p, target_dcache_invalidate)
3960         (target_dcache_get, target_dcache_get_or_init)
3961         (_initialize_target_dcache): Update.
3962         * dcache.h (struct dcache_deleter): New.
3963
3964 2019-05-08  Tom Tromey  <tom@tromey.com>
3965
3966         * symtab.c (struct symbol_cache): Add destructor and
3967         initializers.
3968         (symbol_cache_key): Move.  Change type.
3969         (make_symbol_cache, free_symbol_cache): Remove.
3970         (get_symbol_cache): Update.
3971         (symbol_cache_cleanup): Remove.
3972         (ALL_PSPACES, symbol_cache_flush)
3973         (maintenance_print_symbol_cache)
3974         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3975         Update.
3976
3977 2019-05-08  Tom Tromey  <tom@tromey.com>
3978
3979         * symtab.c (struct main_info): Add destructor and initializers.
3980         (main_progspace_key): Move.  Change type.
3981         (get_main_info): Update.
3982         (main_info_cleanup): Remove.
3983         (_initialize_symtab): Update.
3984
3985 2019-05-08  Tom Tromey  <tom@tromey.com>
3986
3987         * registry.h (DECLARE_REGISTRY): Define the _key class.
3988
3989 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3990
3991         * NEWS: Merge two 'New commands' sections.
3992
3993 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3994
3995         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3996         parameter and use Ada language definition instead.
3997         (ada_val_print_ptr): Remove unused language parameter.
3998         (ada_val_print_num): Remove language parameter and use Ada language
3999         definition instead.
4000         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4001         parameter.
4002         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4003         parameter and use Ada language definition instead.
4004         (ada_val_print_1): Update all ada_val_print_xxx calls.
4005         Remove language parameter.
4006         (ada_val_print): Update ada_val_print_1 call.
4007
4008 2019-05-08  Tom Tromey  <tromey@adacore.com>
4009
4010         * remote.c (remote_hw_watchpoint_limit)
4011         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4012         Now static.
4013
4014 2019-05-08  Tom Tromey  <tromey@adacore.com>
4015
4016         * maint.c (_initialize_maint_cmds): Move initialization code to
4017         remote.c.
4018         (watchdog, show_watchdog): Move to remote.c.
4019         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4020         "watchdog" static.
4021         (_initialize_remote): Move initialization code from maint.c.
4022         * defs.h (watchdog): Don't declare.
4023
4024 2019-05-08  Tom Tromey  <tromey@adacore.com>
4025
4026         * tui/tui-interp.c: Include main.h.
4027         * interps.c: Include main.h.
4028         * main.h (interpreter_p): Declare.
4029         * defs.h (interpreter_p): Don't declare.
4030
4031 2019-05-08  Tom Tromey  <tromey@adacore.com>
4032
4033         * dwarf2loc.c: Include dwarf2read.h.
4034         * defs.h (read_unsigned_leb128): Don't declare.
4035         * dwarf2read.h (read_unsigned_leb128): Declare.
4036
4037 2019-05-08  Tom Tromey  <tromey@adacore.com>
4038
4039         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4040         method.
4041
4042 2019-05-08  Tom Tromey  <tromey@adacore.com>
4043
4044         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4045         when no wrap column is set.
4046
4047 2019-05-08  Tom Tromey  <tromey@adacore.com>
4048
4049         * c-lang.c (c_get_string): Handle non-C-style arrays.
4050
4051 2019-05-08  Tom Tromey  <tromey@adacore.com>
4052
4053         * typeprint.c (print_offset_data::update): Print the bit offset,
4054         not the number of bits remaining.
4055
4056 2019-05-08  Tom Tromey  <tromey@adacore.com>
4057
4058         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4059         padding at end of comment.
4060
4061 2019-05-08  Tom Tromey  <tromey@adacore.com>
4062
4063         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4064         Compare main types.
4065
4066 2019-05-06  Tom Tromey  <tom@tromey.com>
4067
4068         * common/scoped_mmap.c: Include common-defs.h.
4069         * common/scoped_mmap.h: Don't include config.h.
4070
4071 2019-05-04  Tom Tromey  <tom@tromey.com>
4072
4073         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4074         (struct aarch64_call_info): Add initializers.
4075         <si>: Now a std::vector.
4076         (pass_on_stack, aarch64_push_dummy_call): Update.
4077
4078 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4079             Tom Tromey  <tom@tromey.com>
4080
4081         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4082         (ppc_threads): Now a std::vector.  Now static.
4083         (hwdebug_find_thread_points_by_tid)
4084         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4085         Update.
4086
4087 2019-05-04  Tom Tromey  <tom@tromey.com>
4088
4089         * arc-tdep.c (arc_tdesc_init): Return bool.
4090
4091 2019-05-04  Tom Tromey  <tom@tromey.com>
4092
4093         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4094         Use gdb_assert_not_reached.
4095
4096 2019-05-04  Tom Tromey  <tom@tromey.com>
4097
4098         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4099         "false".
4100
4101 2019-05-04  Tom Tromey  <tom@tromey.com>
4102
4103         * arc-tdep.c (arc_tdesc_init): Use bool.
4104
4105 2019-05-04  Tom Tromey  <tom@tromey.com>
4106
4107         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4108
4109 2019-05-04  Tom Tromey  <tom@tromey.com>
4110
4111         * cli/cli-cmds.c (valid_command_p): Return bool.
4112
4113 2019-05-04  Tom Tromey  <tom@tromey.com>
4114
4115         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4116         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4117
4118 2019-05-04  Raul Tambre  <raul@tambre.ee>
4119
4120         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4121         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4122         operator for comparison.
4123
4124 2019-05-04  Tom Tromey  <tom@tromey.com>
4125
4126         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4127         (lookup_partial_symbol, print_partial_symbols)
4128         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4129         (psymbol_compare): Update.
4130         (add_psymbol_to_bcache): Clear the entire psymbol.
4131         (maintenance_check_psymtabs): Update.
4132         * psympriv.h (struct partial_symbol): Don't derive from
4133         general_symbol_info.
4134         <obj_section, unrelocated_address, address,
4135         set_unrelocated_address>: Update.
4136         <ginfo>: New member.
4137         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4138         (debug_names::write_psymbols): Update.
4139
4140 2019-05-04  Tom de Vries  <tdevries@suse.de>
4141
4142         * contrib/cc-with-tweaks.sh: Support -n arg.
4143
4144 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4145
4146         * corelow.c (core_target::detach): Ensure frame cache and
4147         register caches are cleared.
4148         inferior.c (exit_inferior_1): Likewise.
4149
4150 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4151             Tom Tromey  <tom@tromey.com>
4152
4153         * dictionary.c (collate_pending_symbols_by_language): Remove
4154         "struct" from foreach.
4155         * symtab.c (lookup_global_symbol_from_objfile)
4156         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4157         foreach.
4158         * ser-tcp.c (net_open): Remove "struct" from foreach.
4159         * objfiles.c (objfile_relocate, objfile_rebase)
4160         (objfile_has_symbols): Remove "struct" from foreach.
4161         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4162         from foreach.
4163         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4164         foreach.
4165         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4166         "struct" from foreach.
4167         * ada-lang.c (create_excep_cond_exprs)
4168         (ada_exception_catchpoint_cond_string): Remove "struct" from
4169         foreach.
4170
4171 2019-05-03  Tom Tromey  <tromey@adacore.com>
4172
4173         * ada-exp.y (convert_char_literal): Check suffix of each
4174         enumerator.
4175
4176 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4177
4178         PR ada/21406:
4179         * ada-exp.y (yywrap): Don't define.
4180         * ada-lex.l (%option): Add noyywrap
4181         (yywrap): Remove.
4182
4183 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4184
4185         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4186         _WIN32_WINNT to the XP level, unless already defined to a higher
4187         level.
4188
4189         * unittests/parse-connection-spec-selftests.c:
4190         * ser-tcp.c:
4191         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4192         override.
4193
4194         * symfile.c (find_separate_debug_file): Remove colon from the
4195         drive spec of DOS/Windows file names of the target, so that the
4196         file name produced from DEBUGDIR and the target's directory will
4197         be valid on DOS/Windows systems.
4198
4199 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4200
4201         * rust-lang.c (val_print_struct): Handle printing structures
4202         containing strings.
4203
4204 2019-05-02  Tom Tromey  <tromey@adacore.com>
4205
4206         * valarith.c (_initialize_valarith): Remove.
4207
4208 2019-05-01  Tom Tromey  <tromey@adacore.com>
4209
4210         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4211         bitfields.
4212
4213 2019-05-01  Tom Tromey  <tromey@adacore.com>
4214
4215         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4216         for big-endian copies.
4217
4218 2019-04-30  Ali Tamur  <tamur@google.com>
4219         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4220         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4221         (read_3_bytes): New function.
4222
4223 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4224
4225         * windows-nat.c (main_thread_id): Delete.
4226         (handle_output_debug_string): Replace main_thread_id by
4227         current_event.dwThreadId.
4228         (fake_create_process): Likewise.
4229         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4230         Do not set main_thread_id.
4231         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4232         current_event.dwThreadId.
4233         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4234
4235 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4236
4237         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4238         Use current_event.dwThreadId instead of main_thread_id.
4239
4240 2019-04-30  Tom Tromey  <tromey@adacore.com>
4241
4242         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4243         (create_excep_cond_exprs): Iterate over program spaces.
4244         (ada_exception_catchpoint_cond_string): Examine all minimal
4245         symbols for exception types.
4246
4247 2019-04-30  Tom Tromey  <tromey@adacore.com>
4248
4249         PR c++/24470:
4250         * dwarf2read.c (process_structure_scope): Handle case where type
4251         has template parameters but no symbol was created.
4252
4253 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4254             Chris January  <chris.january@arm.com>
4255
4256         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4257         qualifier.
4258         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4259
4260 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4261
4262         * f-typeprint.c (f_print_type): Update rules for printing
4263         whitespace.
4264         (f_type_print_varspec_suffix): Likewise.
4265
4266 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4267             Chris January  <chris.january@arm.com>
4268
4269         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4270         function arguments.
4271
4272 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4273
4274         * f-lang.c (build_fortran_types): Change name of void type to
4275         lower case.
4276         * f-typeprint.c (f_type_print_base): Print the name of the void
4277         type, rather than a fixed string.
4278         * f-valprint.c (f_decorations): Use lower case void string.
4279
4280 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4281             Chris January  <chris.january@arm.com>
4282
4283         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4284         types for Fortran.
4285
4286 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4287             Chris January  <chris.january@arm.com>
4288             David Lecomber  <david.lecomber@arm.com>
4289
4290         * f-exp.y (BINOP_INTRINSIC): New token.
4291         (exp): New parser rule handling BINOP_INTRINSIC.
4292         (f77_keywords): Add new builtin procedures.
4293         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4294         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4295         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4296         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4297         (print_unop_subexp_f): New function.
4298         (print_binop_subexp_f): New function.
4299         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4300         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4301         (dump_subexp_body_f): Likewise.
4302         (operator_check_f): Likewise.
4303         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4304         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4305
4306 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4307
4308         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4309         UNOP_KIND.
4310         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4311         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4312         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4313         (operator_length_f): New fuction.
4314         (print_subexp_f): New function.
4315         (op_name_f): New function.
4316         (dump_subexp_body_f): New function.
4317         (operator_check_f): New function.
4318         (exp_descriptor_f): Replace standard expression handling functions
4319         with new functions.
4320         * gdb/fortran-operator.def: New file.
4321         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4322         * gdb/std-operator.def: Remove UNOP_KIND.
4323
4324 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4325
4326         * std-operator.def: Remove unbalanced, stray double quote
4327         character.
4328
4329 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4330             Chris January  <chris.january@arm.com>
4331             Daniel Everett  <daniel.everett@arm.com>
4332             Nick Forrington  <nick.forrington@arm.com>
4333             Richard Bunt  <richard.bunt@arm.com>
4334
4335         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4336         of depth when printing anonymous structs or unions.
4337         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4338         Don't print either the top-level value, or the children if the
4339         max-depth is exceeded.
4340         (ppscm_print_children): When printing the key of a map, allow one
4341         extra level of depth.
4342         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4343         print either the top-level value, or the children if the max-depth
4344         is exceeded.
4345         (print_children): When printing the key of a map, allow one extra
4346         level of depth.
4347         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4348         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4349         (user_print_options): Initialise max_depth field.
4350         (val_print_scalar_or_string_type_p): New function.
4351         (val_print): Check to see if the max depth has been reached.
4352         (val_print_check_max_depth): Define new function.
4353         (show_print_max_depth): New function.
4354         (_initialize_valprint): Add 'print max-depth' option.
4355         * valprint.h (struct value_print_options) <max_depth>: New field.
4356         (val_print_check_max_depth): Declare new function.
4357         * NEWS: Document new feature.
4358
4359 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4360
4361         * ada-lang.c (ada_language_defn): Initialise new field.
4362         * c-lang.c (c_is_string_type_p): New function.
4363         (c_language_defn): Initialise new field.
4364         (cplus_language_defn): Initialise new field.
4365         (asm_language_defn): Initialise new field.
4366         (minimal_language_defn): Initialise new field.
4367         * c-lang.h (c_is_string_type_p): Declare new function.
4368         * d-lang.c (d_language_defn): Initialise new field.
4369         * f-lang.c (f_is_string_type_p): New function.
4370         (f_language_defn): Initialise new field.
4371         * go-lang.c (go_is_string_type_p): New function.
4372         (go_language_defn): Initialise new field.
4373         * language.c (default_is_string_type_p): New function.
4374         (unknown_language_defn): Initialise new field.
4375         (auto_language_defn): Initialise new field.
4376         * language.h (struct language_defn) <la_is_string_type_p>: New
4377         member variable.
4378         (default_is_string_type_p): Declare new function.
4379         * m2-lang.c (m2_language_defn): Initialise new field.
4380         * objc-lang.c (objc_language_defn): Initialise new field.
4381         * opencl-lang.c (opencl_language_defn): Initialise new field.
4382         * p-lang.c (pascal_is_string_type_p): New function.
4383         (pascal_language_defn): Initialise new field.
4384         * rust-lang.c (rust_is_string_type_p): New function.
4385         (rust_language_defn): Initialise new field.
4386
4387 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4388
4389         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4390         New field.
4391         * ada-lang.c (ada_language_defn): Initialise new field.
4392         * c-lang.c (c_language_defn): Likewise.
4393         (cplus_language_defn): Likewise.
4394         (asm_language_defn): Likewise.
4395         (minimal_language_defn): Likewise.
4396         * d-lang.c (d_language_defn): Likewise.
4397         * f-lang.c (f_language_defn): Likewise.
4398         * go-lang.c (go_language_defn): Likewise.
4399         * language.c (unknown_language_defn): Likewise.
4400         (auto_language_defn): Likewise.
4401         * m2-lang.c (m2_language_defn): Likewise.
4402         * objc-lang.c (objc_language_defn): Likewise.
4403         * opencl-lang.c (opencl_language_defn): Likewise.
4404         * p-lang.c (pascal_language_defn): Likewise.
4405         * rust-lang.c (rust_language_defn): Likewise.
4406
4407 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4408
4409         * ada-lang.c (ada_is_character_type): Change return type to bool.
4410         (ada_is_string_type): Likewise.
4411         * ada-lang.h (ada_is_character_type): Update declaration
4412         (ada_is_string_type): Likewise.
4413
4414 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4415
4416         Support style in 'frame|thread apply'
4417
4418         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4419         * record.c (record_start, record_stop): Update callers of
4420         execute_command_to_string with false.
4421         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4422         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4423         methods.
4424         (class string_file): New constructor with term_out parameter.
4425         Override methods term_out and can_emit_style_escape.  New member
4426         term_out.
4427         (class stdio_file): Override can_emit_style_escape.
4428         (class tee_file): Override term_out and can_emit_style_escape.
4429         * utils.h (can_emit_style_escape): Remove.
4430         * utils.c (can_emit_style_escape): Likewise.
4431         Update all callers of can_emit_style_escape (SOMESTREAM) to
4432         SOMESTREAM->can_emit_style_escape.
4433         * source-cache.c (source_cache::get_source_lines): Likewise.
4434         * stack.c (frame_apply_command_count): Call execute_command_to_string
4435         passing the term_out characteristic of the current gdb_stdout.
4436         * thread.c (thr_try_catch_cmd): Likewise.
4437         * top.c (execute_command_to_string): pass term_out parameter
4438         to construct the string_file for the command output.
4439         * ui-file.c (term_cli_styling): New function (most code moved
4440         from utils.c can_emit_style_escape).
4441         (string_file::string_file, string_file::can_emit_style_escape,
4442         stdio_file::can_emit_style_escape, tee_file::term_out,
4443         tee_file::can_emit_style_escape): New functions.
4444
4445 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4446
4447         * NEWS: Mention the new set|show may-call-functions.
4448         * infcall.c (may_call_functions_p): New variable.
4449         (show_may_call_functions_p): New function.
4450         (call_function_by_hand_dummy): Throws an error if not
4451         may-call-functions.
4452         (_initialize_infcall): Call add_setshow_boolean_cmd for
4453         may-call-functions.
4454
4455 2019-04-25  Keith Seitz  <keiths@redhat.com>
4456
4457         PR c++/24367
4458         * cp-support.c (inspect_type): Don't attempt substitutions
4459         of symbol with the same name.
4460
4461 2019-04-25  Tom Tromey  <tromey@adacore.com>
4462
4463         PR gdb/24475:
4464         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4465         static.
4466
4467 2019-04-25  Tom Tromey  <tromey@adacore.com>
4468
4469         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4470         rvalue reference.
4471         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4472         (gdb_xml_parser::parse): Use std::move.
4473         * python/python-internal.h (gdbpy_convert_exception): Take a const
4474         reference.
4475         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4476         std::move.
4477         * python/py-utils.c (gdbpy_convert_exception): Take a const
4478         reference.
4479         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4480         Use std::move.
4481         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4482         Use std::move.
4483         * mi/mi-main.c (mi_print_exception): Take a const reference.
4484         * main.c (handle_command_errors): Take a const reference.
4485         * linespec.c (parse_linespec): Use std::move.
4486         * infcall.c (run_inferior_call): Use std::move.
4487         (call_function_by_hand_dummy): Use std::move.
4488         * exec.c (try_open_exec_file): Use std::move.
4489         * exceptions.h (exception_print, exception_fprintf)
4490         (exception_print_same): Update.
4491         * exceptions.c (print_exception, exception_print)
4492         (exception_fprintf, exception_print_same): Change parameters to
4493         const reference.
4494         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4495         * common/new-op.c: Use std::move.
4496         * common/common-exceptions.h (struct gdb_exception): Add move
4497         constructor.
4498         (struct gdb_exception_error, struct gdb_exception_quit, struct
4499         gdb_quit_bad_alloc): Change constructor to move constructor.
4500         (throw_exception): Change parameter to rvalue reference.
4501         * common/common-exceptions.c (throw_exception): Take rvalue
4502         reference.
4503         * cli/cli-interp.c (safe_execute_command): Use std::move.
4504         * breakpoint.c (insert_bp_location, location_to_sals): Use
4505         std::move.
4506
4507 2019-04-25  Tom Tromey  <tromey@adacore.com>
4508
4509         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4510         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4511         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4512         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4513         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4514         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4515         guile/scm-value.c: Use unpack.
4516         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4517         gdbscm_gdb_exception.
4518         (gdbscm_throw_gdb_exception): Likewise.
4519         (struct gdbscm_gdb_exception): New.
4520         (unpack): New function.
4521         (gdbscm_wrap): Use unpack.
4522
4523 2019-04-25  Tom Tromey  <tromey@adacore.com>
4524
4525         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4526         (gdb_rl_callback_handler): Use std::move.
4527         * common/common-exceptions.h (struct gdb_exception): Add move
4528         assignment operator.
4529         (throw_exception_sjlj): Change "exception" to const reference.
4530         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4531         (throw_exception_sjlj): Change "exception" to const reference.
4532
4533 2019-04-25  Tom Tromey  <tromey@adacore.com>
4534
4535         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4536         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4537         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4538         Update.
4539         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4540         Update.
4541         * mi/mi-interp.c (mi_interp::exec): Update.
4542         * linespec.c (parse_linespec): Update.
4543         * infcall.c (run_inferior_call): Update.
4544         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4545         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4546         (gdbscm_lookup_global_symbol): Update.
4547         * guile/scm-param.c (gdbscm_parameter_value): Update.
4548         * guile/scm-frame.c (gdbscm_frame_read_register)
4549         (gdbscm_frame_read_var): Update.
4550         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4551         * exec.c (try_open_exec_file): Update.
4552         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4553         (gdb_rl_callback_handler): Update.
4554         * common/common-exceptions.h (exception_none): Don't declare.
4555         * common/common-exceptions.c (exception_none): Don't define.
4556         (struct catcher) <exception>: Update.
4557         * cli/cli-interp.c (safe_execute_command): Update.
4558         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4559
4560 2019-04-25  Ali Tamur  <tamur@google.com>
4561
4562         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4563         (read_attribute_value): Likewise.
4564         (dwarf2_read_addr_index): Update comment.
4565         (read_str_index): Add DW_FORM_strx.
4566         (dwarf2_string_attr): Likewise.
4567         (dwarf2_const_value_attr): Likewise.
4568         (dump_die_shallow): Likewise.
4569         (dwarf2_fetch_constant_bytes): Likewise.
4570         (skip_form_bytes): Likewise.
4571         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4572
4573 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4574
4575         PR corefiles/11608
4576         PR corefiles/18187
4577         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4578         OFFSET.  Verify if current mapping contains an ELF header.
4579         (linux_find_memory_regions_full): Adjust call to
4580         dump_mapping_p.
4581
4582 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4583             Kang Li <kanglictf@gmail.com>
4584
4585         PR gdb/21600
4586
4587         * dwarf2-frame.c (read_initial_length): Be consistent about using
4588         unsigned representation of length.
4589         (decode_frame_entry_1): Likewise.  Check for wraparound of
4590         end pointer as well as buffer overflow.
4591
4592 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4593
4594         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4595         "vq".
4596
4597 2019-04-24  Tom Tromey  <tromey@adacore.com>
4598
4599         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4600
4601 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4602
4603         * s12z-tdep.c (s12z_unwind_pc): Delete.
4604         (s12z_unwind_sp): Delete.
4605         (s12z_gdbarch_init): Don't register deleted functions with
4606         gdbarch.
4607
4608 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4609
4610         * rl78-tdep.c (rl78_unwind_sp): Delete.
4611         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4612
4613 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4614
4615         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4616         (xstormy16_unwind_pc): Delete.
4617         (xstormy16_dummy_id): Delete.
4618         (xstormy16_gdbarch_init): Don't register deleted functions with
4619         gdbarch.
4620
4621 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4622
4623         * vax-tdep.c (vax_unwind_pc): Delete.
4624         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4625
4626 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4627
4628         * v850-tdep.c (v850_unwind_sp): Delete.
4629         (v850_unwind_pc): Delete.
4630         (v850_dummy_id): Delete.
4631         (v850_gdbarch_init): Don't register deleted functions with
4632         gdbarch.
4633
4634 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4635
4636         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4637         (tilegx_unwind_pc): Delete.
4638         (tilegx_unwind_dummy_id): Delete.
4639         (tilegx_gdbarch_init): Don't register deleted functions with
4640         gdbarch.
4641
4642 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4643
4644         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4645         (tic6x_dummy_id): Delete.
4646         (tic6x_gdbarch_init): Don't register deleted functions with
4647         gdbarch.
4648
4649 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4650
4651         * sparc-tdep.c (sparc_unwind_pc): Delete.
4652         (sparc32_gdbarch_init): Don't register deleted function with
4653         gdbarch.
4654
4655 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4656
4657         * sh-tdep.c (sh_unwind_sp): Delete.
4658         (sh_unwind_pc): Delete.
4659         (sh_dummy_id): Delete.
4660         (sh_gdbarch_init): Don't register deleted functions with
4661         gdbarch.
4662
4663 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4664
4665         * score-tdep.c (score_unwind_sp): Delete.
4666         (score_unwind_pc): Delete.
4667         (score_dummy_id): Delete.
4668         (score_gdbarch_init): Don't register deleted functions with
4669         gdbarch.
4670
4671 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4672
4673         * rx-tdep.c (rx_unwind_pc): Delete.
4674         (rx_unwind_sp): Delete.
4675         (rx_dummy_id): Delete.
4676         (rx_gdbarch_init): Don't register deleted functions with
4677         gdbarch.  Update comment.
4678
4679 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4680
4681         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4682         (rs6000_dummy_id): Delete.
4683         (rs6000_gdbarch_init): Don't register deleted functions with
4684         gdbarch.
4685
4686 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4687
4688         * or1k-tdep.c (or1k_dummy_id): Delete.
4689         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4690
4691 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4692
4693         * nios2-tdep.c (nios2_dummy_id): Delete.
4694         (nios2_unwind_sp): Delete.
4695         (nios2_gdbarch_init): Don't register deleted functions with
4696         gdbarch.
4697
4698 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4699
4700         * nds32-tdep.c (nds32_dummy_id): Delete.
4701         (nds32_unwind_pc): Delete.
4702         (nds32_unwind_sp): Delete.
4703         (nds32_gdbarch_init): Don't register deleted functions with
4704         gdbarch.
4705
4706 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4707
4708         * msp430-tdep.c (msp430_unwind_pc): Delete.
4709         (msp430_unwind_sp): Delete.
4710         (msp430_dummy_id): Delete.
4711         (msp430_gdbarch_init): Don't register deleted functions with
4712         gdbarch.
4713
4714 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4715
4716         * moxie-tdep.c (moxie_unwind_sp): Delete.
4717         (moxie_unwind_pc): Delete.
4718         (moxie_dummy_id): Delete.
4719         (moxie_gdbarch_init): Don't register deleted functions with
4720         gdbarch.
4721
4722 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4723
4724         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4725         (mn10300_unwind_pc): Delete.
4726         (mn10300_unwind_sp): Delete.
4727         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4728         mn10300_unwind_sp.
4729         (mn10300_frame_unwind_init): Don't register deleted functions with
4730         gdbarch.
4731
4732 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4733
4734         * mep-tdep.c (mep_unwind_pc): Delete.
4735         (mep_unwind_sp): Delete.
4736         (mep_dummy_id): Delete.
4737         (mep_gdbarch_init): Don't register deleted functions with
4738         gdbarch.
4739
4740 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4741
4742         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4743         (m68hc11_unwind_sp): Delete.
4744         (m68hc11_gdbarch_init): Don't register deleted functions with
4745         gdbarch.
4746
4747 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4748
4749         * m32r-tdep.c (m32r_unwind_sp): Delete.
4750         (m32r_unwind_pc): Delete.
4751         (m32r_dummy_id): Delete.
4752         (m32r_gdbarch_init): Don't register deleted functions with
4753         gdbarch.
4754
4755 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4756
4757         * m32c-tdep.c (m32c_unwind_pc): Delete.
4758         (m32c_unwind_sp): Delete.
4759         (m32c_dummy_id): Delete.
4760         (m32c_gdbarch_init): Don't register deleted functions with
4761         gdbarch.
4762
4763 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4764
4765         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4766         (lm32_unwind_pc): Delete.
4767         (lm32_dummy_id): Delete.
4768         (lm32_gdbarch_init): Don't register deleted functions with
4769         gdbarch.
4770
4771 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4772
4773         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4774         (iq2000_unwind_pc): Delete.
4775         (iq2000_dummy_id): Delete.
4776         (iq2000_gdbarch_init): Don't register deleted functions with
4777         gdbarch.
4778
4779 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4780
4781         * nds32-tdep.c (nds32_type_align): Delete.
4782         (nds32_push_dummy_call): Use type_align instead.
4783
4784 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4785
4786         * arm-tdep.c (arm_type_align): Only handle vector override case.
4787         (arm_push_dummy_call): Use type_align.
4788         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4789
4790 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4791
4792         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4793         case.
4794         (pass_on_stack): Use type_align.
4795         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4796         function.
4797
4798 2019-04-23  Tom Tromey  <tromey@adacore.com>
4799
4800         * dwarf2read.c (line_header::file_name_at): Remove unused
4801         overload.
4802
4803 2019-04-23  Tom de Vries  <tdevries@suse.de>
4804
4805         PR gdb/24438
4806         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4807         invocation.
4808
4809
4810 2019-03-27  Ali Tamur  <tamur@google.com>
4811
4812         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4813         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4814         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4815         (dwarf_expr_context::get_addr_index): Likewise
4816         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4817         (symbol_needs_eval_context::get_addr_index): Likewise
4818         (disassemble_dwarf_expression): Add DW_OP_addrx
4819         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4820         (read_cutu_die_from_dwo): Update comment
4821         (skip_one_die): Add DW_FORM_addrx
4822         (read_attribute_value): Likewise
4823         (var_decode_location): Add DW_OP_addrx
4824         (dwarf2_const_value_attr): Add DW_FORM_addrx
4825         (dump_die_shallow): Likewise
4826         (dwarf2_fetch_constant_bytes): Likewise
4827         (decode_locdesc): Add DW_OP_addrx
4828         (skip_form_bytes): Add DW_FORM_addrx
4829
4830 2019-04-22  Ali Tamur  <tamur@google.com>
4831
4832         * MAINTAINERS (Write After Approval): Add self.
4833
4834 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4835
4836         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4837         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4838         (open_symbol_file_object): Likewise.
4839         (svr4_default_sos): Add info parameter.
4840         (svr4_read_so_list): Likewise.
4841         (svr4_current_sos_direct): Adjust functions calls to pass down
4842         info.
4843         (svr4_current_sos_1): Add info parameter.
4844         (svr4_current_sos): Call get_svr4_info, pass info down to
4845         svr4_current_sos_1.
4846         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4847         get_svr4_info.
4848         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4849         get_svr4_info.
4850         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4851         to get_svr4_info.
4852         (probes_table_remove_objfile_probes): Likewise.
4853         (register_solib_event_probe): Add info parameter.
4854         (solist_update_incremental): Pass info parameter down to
4855         svr4_read_so_list.
4856         (disable_probes_interface): Add info parameter.
4857         (svr4_handle_solib_event): Pass current_program_space to
4858         get_svr4_info.  Adjust disable_probes_interface cleanup.
4859         (svr4_create_probe_breakpoints): Add info parameter, pass it
4860         down to register_solib_event_probe.
4861         (svr4_create_solib_event_breakpoints): Add info parameter,
4862         pass it down to svr4_create_probe_breakpoints.
4863         (enable_break): Pass info down to
4864         svr4_create_solib_event_breakpoints.
4865         (svr4_solib_create_inferior_hook): Pass current_program_space to
4866         get_svr4_info.
4867         (svr4_clear_solib): Likewise.
4868
4869 2019-04-22  Pedro Alves  <palves@redhat.com>
4870
4871         * solib-svr4.c (svr4_free_objfile_observer): New.
4872         (probe_and_action::objfile): New field.
4873         (probes_table_htab_remove_objfile_probes)
4874         (probes_table_remove_objfile_probes): New functions.
4875         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4876         in the new probe_and_action.  Don't store the probe in 'lookup'.
4877         (svr4_create_probe_breakpoints): Pass objfile to
4878         register_solib_event_probe.
4879         (_initialize_svr4_solib): Register a free_objfile observer.
4880
4881 2019-04-19  Tom Tromey  <tom@tromey.com>
4882
4883         * common/queue.h: Remove.
4884
4885 2019-04-19  Tom Tromey  <tom@tromey.com>
4886
4887         * event-loop.c: Don't include "common/queue.h".
4888
4889 2019-04-19  Tom Tromey  <tom@tromey.com>
4890
4891         * remote.c (remote_target): Use delete.
4892         * remote-notif.h: Include <list>, not "common/queue.h".
4893         (notif_client_p): Remove typedef.
4894         (remote_notif_state): Add constructor, destructor, initializer.
4895         <notif_queue>: Now a std::list.
4896         (remote_notif_state_xfree): Don't declare.
4897         * remote-notif.c (remote_notif_process, handle_notification)
4898         (remote_notif_state_allocate): Update.
4899         (~remote_notif_state): Rename from remote_notif_state_xfree.
4900
4901 2019-04-19  Tom Tromey  <tom@tromey.com>
4902
4903         * symfile.c (reread_symbols): Update.
4904         * objfiles.c (objfile_register_static_link)
4905         (objfile_lookup_static_link): Update
4906         (~objfile) Don't delete static_links.
4907         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4908
4909 2019-04-19  Tom Tromey  <tom@tromey.com>
4910
4911         * type-stack.h (struct type_stack) <insert>: Constify string.
4912         * type-stack.c (type_stack::insert): Constify string.
4913         * gdbtypes.h (lookup_template_type): Update.
4914         (address_space_name_to_int): Update.
4915         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4916         const.
4917         (lookup_template_type): Make name const.
4918         * c-exp.y: Update rules.
4919         (lex_one_token, classify_name, classify_inner_name)
4920         (c_print_token): Update.
4921         * p-exp.y: Update rules.
4922         (yylex): Update.
4923         * f-exp.y: Update rules.
4924         (yylex): Update.
4925         * d-exp.y: Update rules.
4926         (lex_one_token, classify_name, classify_inner_name): Update.
4927         * parse.c (write_dollar_variable, copy_name): Return std::string.
4928         * parser-defs.h (copy_name): Change return type.
4929         * m2-exp.y: Update rules.
4930         (yylex): Update.
4931         * go-exp.y (lex_one_token): Update.
4932         Update rules.
4933         (classify_unsafe_function, classify_packaged_name)
4934         (classify_name, yylex): Update.
4935
4936 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4937
4938         * configure.ac: add --enable-source-highlight switch.
4939         * configure: Regenerate.
4940         * top.c (print_gdb_version): plumb --enable-source-highlight
4941         status to "show configuration".
4942
4943 2019-04-19  Tom Tromey  <tromey@adacore.com>
4944
4945         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4946         Check ADA_TYPE_P.
4947         (empty_record, ada_template_to_fixed_record_type_1)
4948         (template_to_static_fixed_type)
4949         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4950         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4951         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4952         macros.
4953
4954 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4955
4956         PR symtab/24423:
4957         * source.c (print_source_lines_base): Advance "iter" when a
4958         control character is seen.
4959
4960 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4961
4962         * inferior.h (struct infcall_suspend_state_deleter):
4963         Catch exception in destructor to avoid crash.
4964
4965 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4966
4967         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4968         close to the add_com "shell".
4969
4970 2019-04-18  Tom Tromey  <tromey@adacore.com>
4971
4972         * process-stratum-target.h (class process_stratum_target)
4973         <stratum>: Add "final".
4974
4975 2019-04-17  Tom Tromey  <tromey@adacore.com>
4976
4977         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4978         against nullptr before use.
4979
4980 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4981
4982         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4983
4984 2019-04-17  Jim Wilson  <jimw@sifive.com>
4985             Andrew Burgess  <andrew.burgess@embecosm.com>
4986
4987         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4988         code read might fail, assume 4-byte breakpoint in that case.
4989
4990 2019-04-15  Leszek Swirski  <leszeks@google.com>
4991
4992         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4993         rather than a hand-rolled POD check when checking for forced MEMORY
4994         classification.
4995
4996 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4997
4998         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4999         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5000         function.
5001         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5002         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5003         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5004         declaration.
5005
5006 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5007
5008         * aarch64-linux-nat.c
5009         (aarch64_linux_nat_target::thread_architecture): Add override.
5010         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5011         each VQ.
5012
5013 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5014
5015         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5016
5017 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5018
5019         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5020         target types of size 96-bits, add some additional comments, and
5021         check that the builtin type we found was the correct size.
5022
5023 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5024
5025         * utils.c (prompt_for_continue): Don't restore the styling at the
5026         end, as applied_style has the wrong value.  This fixes styling in
5027         long lists of file names that are interrupted by the "Continue?"
5028         prompt.
5029
5030 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5031
5032         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5033         * c-lang.c (c_language_defn): Likewise.
5034         (cplus_language_defn): Likewise.
5035         (asm_language_defn): Likewise.
5036         (minimal_language_defn): Likewise.
5037         * d-lang.c (d_language_defn): Likewise.
5038         * f-lang.c (f_language_defn): Likewise.
5039         * go-lang.c (go_language_defn): Likewise.
5040         * language.c (unknown_language_defn): Likewise.
5041         (auto_language_defn): Likewise.
5042         * language.h (struct language_defn): Remove la_magic field.
5043         (LANG_MAGIC): Delete.
5044         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5045         * objc-lang.c (objc_language_defn): Likewise.
5046         * opencl-lang.c (opencl_language_defn): Likewise.
5047         * p-lang.c (pascal_language_defn): Likewise.
5048         * rust-lang.c (rust_language_defn): Likewise.
5049
5050 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5051
5052         * riscv-tdep.c (riscv_type_align): New function.
5053         (riscv_type_alignment): Delete.
5054         (riscv_arg_location): Use 'type_align'.
5055         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5056
5057 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5058
5059         * gdbtypes.c (type_align): A struct with no non-static fields also
5060         has alignment of 1.
5061
5062 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5063
5064         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5065         component to 0.
5066         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5067         member.
5068         (riscv_struct_info::analyse): New implementation using new
5069         analyse_inner member function.
5070         (riscv_struct_info::field_offset): New member function.
5071         (riscv_struct_info::m_offsets): New member variable.
5072         (riscv_struct_info::analyse_inner): New private member function,
5073         takes the old implementation of riscv_struct_info::analyse but
5074         extended to track field offsets.
5075         (riscv_call_arg_struct): Update the struct folding special cases
5076         to handle cases where empty C++ structs, which are non-zero
5077         length, are found.
5078         (riscv_arg_location): Initialise the length of each location, a
5079         non-zero length now indicates the location is in use.
5080         (riscv_push_dummy_call): Allow for the first location having a
5081         non-zero offset when setting up arguments.
5082         (riscv_return_value): Likewise, but for return values.
5083
5084 2019-04-11  Tom Tromey  <tromey@adacore.com>
5085
5086         * utils.c (internal_vproblem): Make "msg" const.
5087
5088 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5089
5090         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5091         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5092         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5093         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5094
5095 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5096
5097         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5098         function.
5099         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5100         of amd64_collect_native_gregset.
5101         (amd64_linux_nat_target::store_registers): Likewise.
5102
5103 2019-04-10  Tom Tromey  <tom@tromey.com>
5104
5105         * symtab.c (lookup_global_symbol_from_objfile)
5106         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5107         * objfiles.h (class separate_debug_iterator): New.
5108         (class separate_debug_range): New.
5109         (struct objfile) <separate_debug_objfiles>: New method.
5110         (objfile_separate_debug_iterate): Don't declare.
5111         * objfiles.c (separate_debug_iterator::operator++): Rename from
5112         objfile_separate_debug_iterate.
5113         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5114         iterator.
5115         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5116         iterator.
5117
5118 2019-04-10  Tom Tromey  <tom@tromey.com>
5119
5120         * symfile.c (reread_symbols): Remove old comment.
5121         * objfiles.c (free_all_objfiles): Fix a typo.
5122
5123 2019-04-10  Tom Tromey  <tom@tromey.com>
5124
5125         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5126         * minsyms.c (lookup_minimal_symbol): Use foreach.
5127         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5128         (lookup_minimal_symbol_solib_trampoline): Likewise.
5129         * symfile.c (reread_symbols): Use foreach.
5130
5131 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5132             Tom Tromey  <tromey@adacore.com>
5133
5134         PR rust/24414:
5135         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5136         (rust_lex_int_test): Change "value" to be LONGEST.
5137         (rust_lex_tests): Add test for long integer literal.
5138
5139 2019-04-09  Tom Tromey  <tromey@adacore.com>
5140
5141         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5142         to bool.
5143         (extended_remote_target::attach): Update.
5144         (remote_target::remote_notice_new_inferior): Update.
5145         (remote_target::add_current_inferior_and_thread): Update.
5146         * inferior.c (exit_inferior_1): Use "false".
5147         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5148
5149 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5150
5151         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5152         the "start" command.
5153
5154 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5155
5156         * python/py-inferior.c (infpy_thread_from_thread_handle):
5157         Adjust comments to reflect renaming of thread_from_thread_handle
5158         to thread_from_handle.  Adjust keywords.  Fix type error message.
5159         (inferior_object_methods): Add thread_from_handle.  Retain
5160         thread_from_thread_handle, but mark it as deprecated.
5161
5162 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5163
5164         * gdbthread.h (find_thread_by_handle): Revise declaration.
5165         * thread.c (find_thread_by_handle): Likewise.  Adjust
5166         implementation too.
5167         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5168         support for buffer objects as handles.
5169
5170 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5171
5172         * python/py-infthread.c (thpy_thread_handle): New function.
5173         (thread_object_methods): Register thpy_thread_handle.
5174
5175 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5176
5177         * gdbthread.h (thread_to_thread_handle): Declare.
5178         * thread.c (gdbtypes.h): Include.
5179         (thread_to_thread_handle): New function.
5180
5181         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5182         (target_thread_info_to_thread_handle): Declare.
5183         * target.c (target_thread_info_to_thread_handle): New function.
5184         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5185         * target-delegates.c: Regenerate.
5186
5187         * linux-thread-db.c (class thread_db_target): Add method
5188         thread_info_to_thread_handle.
5189         (thread_db_target::thread_info_to_thread_handle): Define.
5190         * remote.c (class remote_target): Add new method
5191         thread_info_to_thread_handle.
5192         (remote_target::thread_info_to_thread_handle): Define.
5193
5194 2019-04-08  Pedro Alves  <palves@redhat.com>
5195
5196         * common/common-exceptions.c (throw_exception): Don't create
5197         named object to throw; throw directly.
5198         (throw_it): Likewise.  Don't initialize gdb_exception::message
5199         here, with new; pass FMT and AP to the ctor instead.
5200         * common/common-exceptions.h: Include <string>.
5201         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5202         const char *, va_list)): New ctor.  Use std::make_shared.
5203         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5204         errors)): Delete.
5205         (gdb_exception_error::gdb_exception_error(enum errors, const char
5206         *, va_list)): New.
5207         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5208         Add assertion.
5209         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5210         errors)): Delete.
5211         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5212         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5213         Add assertion.
5214
5215 2019-04-08  Tom Tromey  <tom@tromey.com>
5216
5217         * valops.c (value_rtti_indirect_type): Replace throw_exception
5218         with throw.
5219         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5220         with throw.
5221         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5222         throw.
5223         * target.c (target_translate_tls_address): Replace throw_exception
5224         with throw.
5225         * stack.c (frame_apply_command_count): Replace throw_exception
5226         with throw.
5227         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5228         throw.
5229         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5230         with throw.
5231         * rs6000-tdep.c (rs6000_frame_cache)
5232         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5233         * remote.c: Replace throw_exception with throw.
5234         * record-full.c (record_full_message, record_full_wait_1)
5235         (record_full_restore): Replace throw_exception with throw.
5236         * record-btrace.c:
5237         (get_thread_current_frame_id, record_btrace_start_replaying)
5238         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5239         (cmd_record_btrace_start): Replace throw_exception with throw.
5240         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5241         throw.
5242         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5243         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5244         * linespec.c:
5245         (find_linespec_symbols): Replace throw_exception with throw.
5246         * infrun.c (displaced_step_prepare, resume): Replace
5247         throw_exception with throw.
5248         * infcmd.c (post_create_inferior): Replace throw_exception with
5249         throw.
5250         * inf-loop.c (inferior_event_handler): Replace throw_exception
5251         with throw.
5252         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5253         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5254         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5255         (get_prev_frame_always, get_frame_pc_if_available)
5256         (get_frame_address_in_block_if_available, get_frame_language):
5257         Replace throw_exception with throw.
5258         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5259         throw_exception with throw.
5260         * eval.c (fetch_subexp_value, evaluate_var_value)
5261         (evaluate_funcall, evaluate_subexp_standard): Replace
5262         throw_exception with throw.
5263         * dwarf2loc.c (call_site_find_chain)
5264         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5265         Replace throw_exception with throw.
5266         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5267         with throw.
5268         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5269         throw.
5270         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5271         * completer.c (complete_line_internal): Replace throw_exception
5272         with throw.
5273         * compile/compile-object-run.c (compile_object_run): Replace
5274         throw_exception with throw.
5275         * cli/cli-script.c (process_next_line): Replace throw_exception
5276         with throw.
5277         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5278         (btrace_enable, btrace_maint_update_pt_packets): Replace
5279         throw_exception with throw.
5280         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5281         throw_exception with throw.
5282         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5283         throw_exception with throw.
5284         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5285         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5286         * aarch64-tdep.c (aarch64_make_prologue_cache)
5287         (aarch64_make_stub_cache): Replace throw_exception with throw.
5288
5289 2019-04-08  Tom Tromey  <tom@tromey.com>
5290
5291         * common/common-exceptions.c (throw_exception): Rename from
5292         throw_exception_cxx.  Remove old copy.  Make argument const.
5293         (throw_it): Create and throw exception objects directly.
5294         * common/common-exceptions.h (throw_exception): Make argument
5295         const.
5296         (struct gdb_exception_error): Add constructor.
5297         (struct gdb_exception_quit): Add constructor.
5298
5299 2019-04-08  Tom Tromey  <tom@tromey.com>
5300
5301         * common/common-exceptions.h (exception_rethrow): Don't declare.
5302         (TRY_SJLJ): Update comment.
5303         (TRY, CATCH, END_CATCH): Remove.
5304         * common/common-exceptions.c (exception_rethrow): Remove.
5305
5306 2019-04-08  Tom Tromey  <tom@tromey.com>
5307
5308         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5309         Remove.
5310         (gdb_exception_error): Rename from
5311         gdb_exception_RETURN_MASK_ERROR.
5312         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5313         (gdb_quit_bad_alloc): Update.
5314         * aarch64-tdep.c: Update.
5315         * ada-lang.c: Update.
5316         * ada-typeprint.c: Update.
5317         * ada-valprint.c: Update.
5318         * amd64-tdep.c: Update.
5319         * arch-utils.c: Update.
5320         * break-catch-throw.c: Update.
5321         * breakpoint.c: Update.
5322         * btrace.c: Update.
5323         * c-varobj.c: Update.
5324         * cli/cli-cmds.c: Update.
5325         * cli/cli-interp.c: Update.
5326         * cli/cli-script.c: Update.
5327         * common/common-exceptions.c: Update.
5328         * common/new-op.c: Update.
5329         * common/selftest.c: Update.
5330         * compile/compile-c-symbols.c: Update.
5331         * compile/compile-cplus-symbols.c: Update.
5332         * compile/compile-object-load.c: Update.
5333         * compile/compile-object-run.c: Update.
5334         * completer.c: Update.
5335         * corelow.c: Update.
5336         * cp-abi.c: Update.
5337         * cp-support.c: Update.
5338         * cp-valprint.c: Update.
5339         * darwin-nat.c: Update.
5340         * disasm-selftests.c: Update.
5341         * dtrace-probe.c: Update.
5342         * dwarf-index-cache.c: Update.
5343         * dwarf-index-write.c: Update.
5344         * dwarf2-frame-tailcall.c: Update.
5345         * dwarf2-frame.c: Update.
5346         * dwarf2loc.c: Update.
5347         * dwarf2read.c: Update.
5348         * eval.c: Update.
5349         * event-loop.c: Update.
5350         * event-top.c: Update.
5351         * exec.c: Update.
5352         * f-valprint.c: Update.
5353         * fbsd-tdep.c: Update.
5354         * frame-unwind.c: Update.
5355         * frame.c: Update.
5356         * gdbtypes.c: Update.
5357         * gnu-v3-abi.c: Update.
5358         * guile/guile-internal.h: Update.
5359         * guile/scm-block.c: Update.
5360         * guile/scm-breakpoint.c: Update.
5361         * guile/scm-cmd.c: Update.
5362         * guile/scm-disasm.c: Update.
5363         * guile/scm-frame.c: Update.
5364         * guile/scm-lazy-string.c: Update.
5365         * guile/scm-math.c: Update.
5366         * guile/scm-param.c: Update.
5367         * guile/scm-ports.c: Update.
5368         * guile/scm-pretty-print.c: Update.
5369         * guile/scm-symbol.c: Update.
5370         * guile/scm-symtab.c: Update.
5371         * guile/scm-type.c: Update.
5372         * guile/scm-value.c: Update.
5373         * i386-linux-tdep.c: Update.
5374         * i386-tdep.c: Update.
5375         * inf-loop.c: Update.
5376         * infcall.c: Update.
5377         * infcmd.c: Update.
5378         * infrun.c: Update.
5379         * jit.c: Update.
5380         * language.c: Update.
5381         * linespec.c: Update.
5382         * linux-fork.c: Update.
5383         * linux-nat.c: Update.
5384         * linux-tdep.c: Update.
5385         * linux-thread-db.c: Update.
5386         * main.c: Update.
5387         * mi/mi-cmd-break.c: Update.
5388         * mi/mi-cmd-stack.c: Update.
5389         * mi/mi-interp.c: Update.
5390         * mi/mi-main.c: Update.
5391         * objc-lang.c: Update.
5392         * p-valprint.c: Update.
5393         * parse.c: Update.
5394         * ppc-linux-tdep.c: Update.
5395         * printcmd.c: Update.
5396         * python/py-arch.c: Update.
5397         * python/py-breakpoint.c: Update.
5398         * python/py-cmd.c: Update.
5399         * python/py-finishbreakpoint.c: Update.
5400         * python/py-frame.c: Update.
5401         * python/py-framefilter.c: Update.
5402         * python/py-gdb-readline.c: Update.
5403         * python/py-inferior.c: Update.
5404         * python/py-infthread.c: Update.
5405         * python/py-lazy-string.c: Update.
5406         * python/py-linetable.c: Update.
5407         * python/py-objfile.c: Update.
5408         * python/py-param.c: Update.
5409         * python/py-prettyprint.c: Update.
5410         * python/py-progspace.c: Update.
5411         * python/py-record-btrace.c: Update.
5412         * python/py-record.c: Update.
5413         * python/py-symbol.c: Update.
5414         * python/py-type.c: Update.
5415         * python/py-unwind.c: Update.
5416         * python/py-utils.c: Update.
5417         * python/py-value.c: Update.
5418         * python/python.c: Update.
5419         * record-btrace.c: Update.
5420         * record-full.c: Update.
5421         * remote-fileio.c: Update.
5422         * remote.c: Update.
5423         * riscv-tdep.c: Update.
5424         * rs6000-aix-tdep.c: Update.
5425         * rs6000-tdep.c: Update.
5426         * rust-exp.y: Update.
5427         * rust-lang.c: Update.
5428         * s390-tdep.c: Update.
5429         * selftest-arch.c: Update.
5430         * solib-dsbt.c: Update.
5431         * solib-frv.c: Update.
5432         * solib-spu.c: Update.
5433         * solib-svr4.c: Update.
5434         * solib.c: Update.
5435         * sparc64-linux-tdep.c: Update.
5436         * stack.c: Update.
5437         * symfile-mem.c: Update.
5438         * symmisc.c: Update.
5439         * target.c: Update.
5440         * thread.c: Update.
5441         * top.c: Update.
5442         * tracefile-tfile.c: Update.
5443         * tui/tui.c: Update.
5444         * typeprint.c: Update.
5445         * unittests/cli-utils-selftests.c: Update.
5446         * unittests/parse-connection-spec-selftests.c: Update.
5447         * valops.c: Update.
5448         * valprint.c: Update.
5449         * value.c: Update.
5450         * varobj.c: Update.
5451         * windows-nat.c: Update.
5452         * x86-linux-nat.c: Update.
5453         * xml-support.c: Update.
5454
5455 2019-04-08  Tom Tromey  <tom@tromey.com>
5456
5457         * xml-support.c: Use C++ exception handling.
5458         * x86-linux-nat.c: Use C++ exception handling.
5459         * windows-nat.c: Use C++ exception handling.
5460         * varobj.c: Use C++ exception handling.
5461         * value.c: Use C++ exception handling.
5462         * valprint.c: Use C++ exception handling.
5463         * valops.c: Use C++ exception handling.
5464         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5465         handling.
5466         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5467         * typeprint.c: Use C++ exception handling.
5468         * tui/tui.c: Use C++ exception handling.
5469         * tracefile-tfile.c: Use C++ exception handling.
5470         * top.c: Use C++ exception handling.
5471         * thread.c: Use C++ exception handling.
5472         * target.c: Use C++ exception handling.
5473         * symmisc.c: Use C++ exception handling.
5474         * symfile-mem.c: Use C++ exception handling.
5475         * stack.c: Use C++ exception handling.
5476         * sparc64-linux-tdep.c: Use C++ exception handling.
5477         * solib.c: Use C++ exception handling.
5478         * solib-svr4.c: Use C++ exception handling.
5479         * solib-spu.c: Use C++ exception handling.
5480         * solib-frv.c: Use C++ exception handling.
5481         * solib-dsbt.c: Use C++ exception handling.
5482         * selftest-arch.c: Use C++ exception handling.
5483         * s390-tdep.c: Use C++ exception handling.
5484         * rust-lang.c: Use C++ exception handling.
5485         * rust-exp.y: Use C++ exception handling.
5486         * rs6000-tdep.c: Use C++ exception handling.
5487         * rs6000-aix-tdep.c: Use C++ exception handling.
5488         * riscv-tdep.c: Use C++ exception handling.
5489         * remote.c: Use C++ exception handling.
5490         * remote-fileio.c: Use C++ exception handling.
5491         * record-full.c: Use C++ exception handling.
5492         * record-btrace.c: Use C++ exception handling.
5493         * python/python.c: Use C++ exception handling.
5494         * python/py-value.c: Use C++ exception handling.
5495         * python/py-utils.c: Use C++ exception handling.
5496         * python/py-unwind.c: Use C++ exception handling.
5497         * python/py-type.c: Use C++ exception handling.
5498         * python/py-symbol.c: Use C++ exception handling.
5499         * python/py-record.c: Use C++ exception handling.
5500         * python/py-record-btrace.c: Use C++ exception handling.
5501         * python/py-progspace.c: Use C++ exception handling.
5502         * python/py-prettyprint.c: Use C++ exception handling.
5503         * python/py-param.c: Use C++ exception handling.
5504         * python/py-objfile.c: Use C++ exception handling.
5505         * python/py-linetable.c: Use C++ exception handling.
5506         * python/py-lazy-string.c: Use C++ exception handling.
5507         * python/py-infthread.c: Use C++ exception handling.
5508         * python/py-inferior.c: Use C++ exception handling.
5509         * python/py-gdb-readline.c: Use C++ exception handling.
5510         * python/py-framefilter.c: Use C++ exception handling.
5511         * python/py-frame.c: Use C++ exception handling.
5512         * python/py-finishbreakpoint.c: Use C++ exception handling.
5513         * python/py-cmd.c: Use C++ exception handling.
5514         * python/py-breakpoint.c: Use C++ exception handling.
5515         * python/py-arch.c: Use C++ exception handling.
5516         * printcmd.c: Use C++ exception handling.
5517         * ppc-linux-tdep.c: Use C++ exception handling.
5518         * parse.c: Use C++ exception handling.
5519         * p-valprint.c: Use C++ exception handling.
5520         * objc-lang.c: Use C++ exception handling.
5521         * mi/mi-main.c: Use C++ exception handling.
5522         * mi/mi-interp.c: Use C++ exception handling.
5523         * mi/mi-cmd-stack.c: Use C++ exception handling.
5524         * mi/mi-cmd-break.c: Use C++ exception handling.
5525         * main.c: Use C++ exception handling.
5526         * linux-thread-db.c: Use C++ exception handling.
5527         * linux-tdep.c: Use C++ exception handling.
5528         * linux-nat.c: Use C++ exception handling.
5529         * linux-fork.c: Use C++ exception handling.
5530         * linespec.c: Use C++ exception handling.
5531         * language.c: Use C++ exception handling.
5532         * jit.c: Use C++ exception handling.
5533         * infrun.c: Use C++ exception handling.
5534         * infcmd.c: Use C++ exception handling.
5535         * infcall.c: Use C++ exception handling.
5536         * inf-loop.c: Use C++ exception handling.
5537         * i386-tdep.c: Use C++ exception handling.
5538         * i386-linux-tdep.c: Use C++ exception handling.
5539         * guile/scm-value.c: Use C++ exception handling.
5540         * guile/scm-type.c: Use C++ exception handling.
5541         * guile/scm-symtab.c: Use C++ exception handling.
5542         * guile/scm-symbol.c: Use C++ exception handling.
5543         * guile/scm-pretty-print.c: Use C++ exception handling.
5544         * guile/scm-ports.c: Use C++ exception handling.
5545         * guile/scm-param.c: Use C++ exception handling.
5546         * guile/scm-math.c: Use C++ exception handling.
5547         * guile/scm-lazy-string.c: Use C++ exception handling.
5548         * guile/scm-frame.c: Use C++ exception handling.
5549         * guile/scm-disasm.c: Use C++ exception handling.
5550         * guile/scm-cmd.c: Use C++ exception handling.
5551         * guile/scm-breakpoint.c: Use C++ exception handling.
5552         * guile/scm-block.c: Use C++ exception handling.
5553         * guile/guile-internal.h: Use C++ exception handling.
5554         * gnu-v3-abi.c: Use C++ exception handling.
5555         * gdbtypes.c: Use C++ exception handling.
5556         * frame.c: Use C++ exception handling.
5557         * frame-unwind.c: Use C++ exception handling.
5558         * fbsd-tdep.c: Use C++ exception handling.
5559         * f-valprint.c: Use C++ exception handling.
5560         * exec.c: Use C++ exception handling.
5561         * event-top.c: Use C++ exception handling.
5562         * event-loop.c: Use C++ exception handling.
5563         * eval.c: Use C++ exception handling.
5564         * dwarf2read.c: Use C++ exception handling.
5565         * dwarf2loc.c: Use C++ exception handling.
5566         * dwarf2-frame.c: Use C++ exception handling.
5567         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5568         * dwarf-index-write.c: Use C++ exception handling.
5569         * dwarf-index-cache.c: Use C++ exception handling.
5570         * dtrace-probe.c: Use C++ exception handling.
5571         * disasm-selftests.c: Use C++ exception handling.
5572         * darwin-nat.c: Use C++ exception handling.
5573         * cp-valprint.c: Use C++ exception handling.
5574         * cp-support.c: Use C++ exception handling.
5575         * cp-abi.c: Use C++ exception handling.
5576         * corelow.c: Use C++ exception handling.
5577         * completer.c: Use C++ exception handling.
5578         * compile/compile-object-run.c: Use C++ exception handling.
5579         * compile/compile-object-load.c: Use C++ exception handling.
5580         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5581         * compile/compile-c-symbols.c: Use C++ exception handling.
5582         * common/selftest.c: Use C++ exception handling.
5583         * common/new-op.c: Use C++ exception handling.
5584         * cli/cli-script.c: Use C++ exception handling.
5585         * cli/cli-interp.c: Use C++ exception handling.
5586         * cli/cli-cmds.c: Use C++ exception handling.
5587         * c-varobj.c: Use C++ exception handling.
5588         * btrace.c: Use C++ exception handling.
5589         * breakpoint.c: Use C++ exception handling.
5590         * break-catch-throw.c: Use C++ exception handling.
5591         * arch-utils.c: Use C++ exception handling.
5592         * amd64-tdep.c: Use C++ exception handling.
5593         * ada-valprint.c: Use C++ exception handling.
5594         * ada-typeprint.c: Use C++ exception handling.
5595         * ada-lang.c: Use C++ exception handling.
5596         * aarch64-tdep.c: Use C++ exception handling.
5597
5598 2019-04-08  Tom Tromey  <tom@tromey.com>
5599
5600         * xml-support.c (gdb_xml_parser::parse): Update.
5601         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5602         * value.c (show_convenience): Update.
5603         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5604         (test_parse_flags_qcs): Update.
5605         * thread.c (thr_try_catch_cmd): Update.
5606         * target.c (target_translate_tls_address): Update.
5607         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5608         (info_frame_command_core, frame_apply_command_count): Update.
5609         * rust-exp.y (rust_lex_exception_test): Update.
5610         * riscv-tdep.c (riscv_print_one_register_info): Update.
5611         * remote.c (remote_target::enable_btrace): Update.
5612         * record-btrace.c (record_btrace_enable_warn): Update.
5613         * python/py-utils.c (gdbpy_convert_exception): Update.
5614         * printcmd.c (do_one_display, print_variable_and_value): Update.
5615         * mi/mi-main.c (mi_print_exception): Update.
5616         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5617         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5618         * linux-nat.c (linux_nat_target::attach): Update.
5619         * linux-fork.c (class scoped_switch_fork_info): Update.
5620         * infrun.c (displaced_step_prepare): Update.
5621         * infcall.c (call_function_by_hand_dummy): Update.
5622         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5623         * gnu-v3-abi.c (print_one_vtable): Update.
5624         * frame.c (get_prev_frame_always): Update.
5625         * f-valprint.c (info_common_command_for_block): Update.
5626         * exec.c (try_open_exec_file): Update.
5627         * exceptions.c (print_exception, exception_print)
5628         (exception_fprintf, exception_print_same): Update.
5629         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5630         * dwarf-index-cache.c (index_cache::store)
5631         (index_cache::lookup_gdb_index): Update.
5632         * darwin-nat.c (maybe_cache_shell): Update.
5633         * cp-valprint.c (cp_print_value_fields): Update.
5634         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5635         (gcc_cplus_symbol_address): Update.
5636         * compile/compile-c-symbols.c (gcc_convert_symbol)
5637         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5638         * common/selftest.c: Update.
5639         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5640         a std::string.
5641         (exception_try_scope_entry, exception_try_scope_exit): Don't
5642         declare.
5643         (struct exception_try_scope): Remove.
5644         (TRY): Don't use exception_try_scope.
5645         (struct gdb_exception): Add constructor, operator=.
5646         <what>: New method.
5647         (struct gdb_exception_RETURN_MASK_ALL)
5648         (struct gdb_exception_RETURN_MASK_ERROR)
5649         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5650         (struct gdb_quit_bad_alloc): Update.
5651         * common/common-exceptions.c (exception_none): Change
5652         initializer.
5653         (struct catcher) <state, exception>: Initialize inline.
5654         <prev>: Remove member.
5655         (current_catcher): Remove.
5656         (catchers): New global.
5657         (exceptions_state_mc_init): Simplify.
5658         (catcher_pop): Remove.
5659         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5660         (try_scope_depth, exception_try_scope_entry)
5661         (exception_try_scope_exit): Remove.
5662         (throw_exception_sjlj): Update.
5663         (exception_messages, exception_messages_size): Remove.
5664         (throw_it): Simplify.
5665         (gdb_exception_sliced_copy): Remove.
5666         (throw_exception_cxx): Update.
5667         * cli/cli-script.c (script_from_file): Update.
5668         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5669         Update.
5670         * ada-valprint.c (ada_val_print): Update.
5671         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5672         (create_excep_cond_exprs): Update.
5673
5674 2019-04-08  Tom Tromey  <tom@tromey.com>
5675
5676         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5677         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5678         (TRY, CATCH, END_CATCH): Remove some definitions.
5679         * common/common-exceptions.c: Don't use GDB_XCPT.
5680         (catcher_list_size): Remove.
5681         (throw_exception, throw_it): Simplify.
5682
5683 2019-04-05  Tom Tromey  <tom@tromey.com>
5684
5685         Revert the header-sorting patch.
5686         * ft32-tdep.c: Revert.
5687         * frv-tdep.c: Revert.
5688         * frv-linux-tdep.c: Revert.
5689         * frame.c: Revert.
5690         * frame-unwind.c: Revert.
5691         * frame-base.c: Revert.
5692         * fork-child.c: Revert.
5693         * findvar.c: Revert.
5694         * findcmd.c: Revert.
5695         * filesystem.c: Revert.
5696         * filename-seen-cache.h: Revert.
5697         * filename-seen-cache.c: Revert.
5698         * fbsd-tdep.c: Revert.
5699         * fbsd-nat.h: Revert.
5700         * fbsd-nat.c: Revert.
5701         * f-valprint.c: Revert.
5702         * f-typeprint.c: Revert.
5703         * f-lang.c: Revert.
5704         * extension.h: Revert.
5705         * extension.c: Revert.
5706         * extension-priv.h: Revert.
5707         * expprint.c: Revert.
5708         * exec.h: Revert.
5709         * exec.c: Revert.
5710         * exceptions.c: Revert.
5711         * event-top.c: Revert.
5712         * event-loop.c: Revert.
5713         * eval.c: Revert.
5714         * elfread.c: Revert.
5715         * dwarf2read.h: Revert.
5716         * dwarf2read.c: Revert.
5717         * dwarf2loc.c: Revert.
5718         * dwarf2expr.h: Revert.
5719         * dwarf2expr.c: Revert.
5720         * dwarf2-frame.c: Revert.
5721         * dwarf2-frame-tailcall.c: Revert.
5722         * dwarf-index-write.h: Revert.
5723         * dwarf-index-write.c: Revert.
5724         * dwarf-index-common.c: Revert.
5725         * dwarf-index-cache.h: Revert.
5726         * dwarf-index-cache.c: Revert.
5727         * dummy-frame.c: Revert.
5728         * dtrace-probe.c: Revert.
5729         * disasm.h: Revert.
5730         * disasm.c: Revert.
5731         * disasm-selftests.c: Revert.
5732         * dictionary.c: Revert.
5733         * dicos-tdep.c: Revert.
5734         * demangle.c: Revert.
5735         * dcache.h: Revert.
5736         * dcache.c: Revert.
5737         * darwin-nat.h: Revert.
5738         * darwin-nat.c: Revert.
5739         * darwin-nat-info.c: Revert.
5740         * d-valprint.c: Revert.
5741         * d-namespace.c: Revert.
5742         * d-lang.c: Revert.
5743         * ctf.c: Revert.
5744         * csky-tdep.c: Revert.
5745         * csky-linux-tdep.c: Revert.
5746         * cris-tdep.c: Revert.
5747         * cris-linux-tdep.c: Revert.
5748         * cp-valprint.c: Revert.
5749         * cp-support.c: Revert.
5750         * cp-namespace.c: Revert.
5751         * cp-abi.c: Revert.
5752         * corelow.c: Revert.
5753         * corefile.c: Revert.
5754         * continuations.c: Revert.
5755         * completer.h: Revert.
5756         * completer.c: Revert.
5757         * complaints.c: Revert.
5758         * coffread.c: Revert.
5759         * coff-pe-read.c: Revert.
5760         * cli-out.h: Revert.
5761         * cli-out.c: Revert.
5762         * charset.c: Revert.
5763         * c-varobj.c: Revert.
5764         * c-valprint.c: Revert.
5765         * c-typeprint.c: Revert.
5766         * c-lang.c: Revert.
5767         * buildsym.c: Revert.
5768         * buildsym-legacy.c: Revert.
5769         * build-id.h: Revert.
5770         * build-id.c: Revert.
5771         * btrace.c: Revert.
5772         * bsd-uthread.c: Revert.
5773         * breakpoint.h: Revert.
5774         * breakpoint.c: Revert.
5775         * break-catch-throw.c: Revert.
5776         * break-catch-syscall.c: Revert.
5777         * break-catch-sig.c: Revert.
5778         * blockframe.c: Revert.
5779         * block.c: Revert.
5780         * bfin-tdep.c: Revert.
5781         * bfin-linux-tdep.c: Revert.
5782         * bfd-target.c: Revert.
5783         * bcache.c: Revert.
5784         * ax-general.c: Revert.
5785         * ax-gdb.h: Revert.
5786         * ax-gdb.c: Revert.
5787         * avr-tdep.c: Revert.
5788         * auxv.c: Revert.
5789         * auto-load.c: Revert.
5790         * arm-wince-tdep.c: Revert.
5791         * arm-tdep.c: Revert.
5792         * arm-symbian-tdep.c: Revert.
5793         * arm-pikeos-tdep.c: Revert.
5794         * arm-obsd-tdep.c: Revert.
5795         * arm-nbsd-tdep.c: Revert.
5796         * arm-nbsd-nat.c: Revert.
5797         * arm-linux-tdep.c: Revert.
5798         * arm-linux-nat.c: Revert.
5799         * arm-fbsd-tdep.c: Revert.
5800         * arm-fbsd-nat.c: Revert.
5801         * arm-bsd-tdep.c: Revert.
5802         * arch-utils.c: Revert.
5803         * arc-tdep.c: Revert.
5804         * arc-newlib-tdep.c: Revert.
5805         * annotate.h: Revert.
5806         * annotate.c: Revert.
5807         * amd64-windows-tdep.c: Revert.
5808         * amd64-windows-nat.c: Revert.
5809         * amd64-tdep.c: Revert.
5810         * amd64-sol2-tdep.c: Revert.
5811         * amd64-obsd-tdep.c: Revert.
5812         * amd64-obsd-nat.c: Revert.
5813         * amd64-nbsd-tdep.c: Revert.
5814         * amd64-nbsd-nat.c: Revert.
5815         * amd64-nat.c: Revert.
5816         * amd64-linux-tdep.c: Revert.
5817         * amd64-linux-nat.c: Revert.
5818         * amd64-fbsd-tdep.c: Revert.
5819         * amd64-fbsd-nat.c: Revert.
5820         * amd64-dicos-tdep.c: Revert.
5821         * amd64-darwin-tdep.c: Revert.
5822         * amd64-bsd-nat.c: Revert.
5823         * alpha-tdep.c: Revert.
5824         * alpha-obsd-tdep.c: Revert.
5825         * alpha-nbsd-tdep.c: Revert.
5826         * alpha-mdebug-tdep.c: Revert.
5827         * alpha-linux-tdep.c: Revert.
5828         * alpha-linux-nat.c: Revert.
5829         * alpha-bsd-tdep.c: Revert.
5830         * alpha-bsd-nat.c: Revert.
5831         * aix-thread.c: Revert.
5832         * agent.c: Revert.
5833         * addrmap.c: Revert.
5834         * ada-varobj.c: Revert.
5835         * ada-valprint.c: Revert.
5836         * ada-typeprint.c: Revert.
5837         * ada-tasks.c: Revert.
5838         * ada-lang.c: Revert.
5839         * aarch64-tdep.c: Revert.
5840         * aarch64-ravenscar-thread.c: Revert.
5841         * aarch64-newlib-tdep.c: Revert.
5842         * aarch64-linux-tdep.c: Revert.
5843         * aarch64-linux-nat.c: Revert.
5844         * aarch64-fbsd-tdep.c: Revert.
5845         * aarch64-fbsd-nat.c: Revert.
5846         * aarch32-linux-nat.c: Revert.
5847
5848 2019-04-05  Tom Tromey  <tom@tromey.com>
5849
5850         * ft32-tdep.c: Sort headers.
5851         * frv-tdep.c: Sort headers.
5852         * frv-linux-tdep.c: Sort headers.
5853         * frame.c: Sort headers.
5854         * frame-unwind.c: Sort headers.
5855         * frame-base.c: Sort headers.
5856         * fork-child.c: Sort headers.
5857         * findvar.c: Sort headers.
5858         * findcmd.c: Sort headers.
5859         * filesystem.c: Sort headers.
5860         * filename-seen-cache.h: Sort headers.
5861         * filename-seen-cache.c: Sort headers.
5862         * fbsd-tdep.c: Sort headers.
5863         * fbsd-nat.h: Sort headers.
5864         * fbsd-nat.c: Sort headers.
5865         * f-valprint.c: Sort headers.
5866         * f-typeprint.c: Sort headers.
5867         * f-lang.c: Sort headers.
5868         * extension.h: Sort headers.
5869         * extension.c: Sort headers.
5870         * extension-priv.h: Sort headers.
5871         * expprint.c: Sort headers.
5872         * exec.h: Sort headers.
5873         * exec.c: Sort headers.
5874         * exceptions.c: Sort headers.
5875         * event-top.c: Sort headers.
5876         * event-loop.c: Sort headers.
5877         * eval.c: Sort headers.
5878         * elfread.c: Sort headers.
5879         * dwarf2read.h: Sort headers.
5880         * dwarf2read.c: Sort headers.
5881         * dwarf2loc.c: Sort headers.
5882         * dwarf2expr.h: Sort headers.
5883         * dwarf2expr.c: Sort headers.
5884         * dwarf2-frame.c: Sort headers.
5885         * dwarf2-frame-tailcall.c: Sort headers.
5886         * dwarf-index-write.h: Sort headers.
5887         * dwarf-index-write.c: Sort headers.
5888         * dwarf-index-common.c: Sort headers.
5889         * dwarf-index-cache.h: Sort headers.
5890         * dwarf-index-cache.c: Sort headers.
5891         * dummy-frame.c: Sort headers.
5892         * dtrace-probe.c: Sort headers.
5893         * disasm.h: Sort headers.
5894         * disasm.c: Sort headers.
5895         * disasm-selftests.c: Sort headers.
5896         * dictionary.c: Sort headers.
5897         * dicos-tdep.c: Sort headers.
5898         * demangle.c: Sort headers.
5899         * dcache.h: Sort headers.
5900         * dcache.c: Sort headers.
5901         * darwin-nat.h: Sort headers.
5902         * darwin-nat.c: Sort headers.
5903         * darwin-nat-info.c: Sort headers.
5904         * d-valprint.c: Sort headers.
5905         * d-namespace.c: Sort headers.
5906         * d-lang.c: Sort headers.
5907         * ctf.c: Sort headers.
5908         * csky-tdep.c: Sort headers.
5909         * csky-linux-tdep.c: Sort headers.
5910         * cris-tdep.c: Sort headers.
5911         * cris-linux-tdep.c: Sort headers.
5912         * cp-valprint.c: Sort headers.
5913         * cp-support.c: Sort headers.
5914         * cp-namespace.c: Sort headers.
5915         * cp-abi.c: Sort headers.
5916         * corelow.c: Sort headers.
5917         * corefile.c: Sort headers.
5918         * continuations.c: Sort headers.
5919         * completer.h: Sort headers.
5920         * completer.c: Sort headers.
5921         * complaints.c: Sort headers.
5922         * coffread.c: Sort headers.
5923         * coff-pe-read.c: Sort headers.
5924         * cli-out.h: Sort headers.
5925         * cli-out.c: Sort headers.
5926         * charset.c: Sort headers.
5927         * c-varobj.c: Sort headers.
5928         * c-valprint.c: Sort headers.
5929         * c-typeprint.c: Sort headers.
5930         * c-lang.c: Sort headers.
5931         * buildsym.c: Sort headers.
5932         * buildsym-legacy.c: Sort headers.
5933         * build-id.h: Sort headers.
5934         * build-id.c: Sort headers.
5935         * btrace.c: Sort headers.
5936         * bsd-uthread.c: Sort headers.
5937         * breakpoint.h: Sort headers.
5938         * breakpoint.c: Sort headers.
5939         * break-catch-throw.c: Sort headers.
5940         * break-catch-syscall.c: Sort headers.
5941         * break-catch-sig.c: Sort headers.
5942         * blockframe.c: Sort headers.
5943         * block.c: Sort headers.
5944         * bfin-tdep.c: Sort headers.
5945         * bfin-linux-tdep.c: Sort headers.
5946         * bfd-target.c: Sort headers.
5947         * bcache.c: Sort headers.
5948         * ax-general.c: Sort headers.
5949         * ax-gdb.h: Sort headers.
5950         * ax-gdb.c: Sort headers.
5951         * avr-tdep.c: Sort headers.
5952         * auxv.c: Sort headers.
5953         * auto-load.c: Sort headers.
5954         * arm-wince-tdep.c: Sort headers.
5955         * arm-tdep.c: Sort headers.
5956         * arm-symbian-tdep.c: Sort headers.
5957         * arm-pikeos-tdep.c: Sort headers.
5958         * arm-obsd-tdep.c: Sort headers.
5959         * arm-nbsd-tdep.c: Sort headers.
5960         * arm-nbsd-nat.c: Sort headers.
5961         * arm-linux-tdep.c: Sort headers.
5962         * arm-linux-nat.c: Sort headers.
5963         * arm-fbsd-tdep.c: Sort headers.
5964         * arm-fbsd-nat.c: Sort headers.
5965         * arm-bsd-tdep.c: Sort headers.
5966         * arch-utils.c: Sort headers.
5967         * arc-tdep.c: Sort headers.
5968         * arc-newlib-tdep.c: Sort headers.
5969         * annotate.h: Sort headers.
5970         * annotate.c: Sort headers.
5971         * amd64-windows-tdep.c: Sort headers.
5972         * amd64-windows-nat.c: Sort headers.
5973         * amd64-tdep.c: Sort headers.
5974         * amd64-sol2-tdep.c: Sort headers.
5975         * amd64-obsd-tdep.c: Sort headers.
5976         * amd64-obsd-nat.c: Sort headers.
5977         * amd64-nbsd-tdep.c: Sort headers.
5978         * amd64-nbsd-nat.c: Sort headers.
5979         * amd64-nat.c: Sort headers.
5980         * amd64-linux-tdep.c: Sort headers.
5981         * amd64-linux-nat.c: Sort headers.
5982         * amd64-fbsd-tdep.c: Sort headers.
5983         * amd64-fbsd-nat.c: Sort headers.
5984         * amd64-dicos-tdep.c: Sort headers.
5985         * amd64-darwin-tdep.c: Sort headers.
5986         * amd64-bsd-nat.c: Sort headers.
5987         * alpha-tdep.c: Sort headers.
5988         * alpha-obsd-tdep.c: Sort headers.
5989         * alpha-nbsd-tdep.c: Sort headers.
5990         * alpha-mdebug-tdep.c: Sort headers.
5991         * alpha-linux-tdep.c: Sort headers.
5992         * alpha-linux-nat.c: Sort headers.
5993         * alpha-bsd-tdep.c: Sort headers.
5994         * alpha-bsd-nat.c: Sort headers.
5995         * aix-thread.c: Sort headers.
5996         * agent.c: Sort headers.
5997         * addrmap.c: Sort headers.
5998         * ada-varobj.c: Sort headers.
5999         * ada-valprint.c: Sort headers.
6000         * ada-typeprint.c: Sort headers.
6001         * ada-tasks.c: Sort headers.
6002         * ada-lang.c: Sort headers.
6003         * aarch64-tdep.c: Sort headers.
6004         * aarch64-ravenscar-thread.c: Sort headers.
6005         * aarch64-newlib-tdep.c: Sort headers.
6006         * aarch64-linux-tdep.c: Sort headers.
6007         * aarch64-linux-nat.c: Sort headers.
6008         * aarch64-fbsd-tdep.c: Sort headers.
6009         * aarch64-fbsd-nat.c: Sort headers.
6010         * aarch32-linux-nat.c: Sort headers.
6011
6012 2019-04-04  Tom Tromey  <tom@tromey.com>
6013
6014         * varobj.c (varobj_create): Update.
6015         * rust-exp.y (struct rust_parser) <update_innermost_block,
6016         lookup_symbol>: New methods.
6017         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6018         Rename.
6019         (rust_parser::rust_lookup_type)
6020         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6021         * printcmd.c (display_command, do_one_display): Update.
6022         * parser-defs.h (struct parser_state) <parser_state>: Add
6023         "tracker" parameter.
6024         (block_tracker): New member.
6025         (class innermost_block_tracker) <innermost_block_tracker>: Add
6026         "types" parameter.
6027         <reset>: Remove method.
6028         (innermost_block): Don't declare.
6029         (null_post_parser): Update.
6030         * parse.c (innermost_block): Remove global.
6031         (write_dollar_variable): Update.
6032         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6033         Remove "tracker_types" parameter.
6034         (parse_expression): Add "tracker" parameter.
6035         (parse_expression_for_completion): Update.
6036         (null_post_parser): Add "tracker" parameter.
6037         * p-exp.y: Update rules.
6038         * m2-exp.y: Update rules.
6039         * language.h (struct language_defn) <la_post_parser>: Add
6040         "tracker" parameter.
6041         * go-exp.y: Update rules.
6042         * f-exp.y: Update rules.
6043         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6044         parameter.
6045         * d-exp.y: Update rules.
6046         * c-exp.y: Update rules.
6047         * breakpoint.c (set_breakpoint_condition): Create an
6048         innermost_block_tracker.
6049         (watch_command_1): Likewise.
6050         * ada-lang.c (resolve): Add "tracker" parameter.
6051         (resolve_subexp): Likewise.
6052         * ada-exp.y (write_var_from_sym): Update.
6053
6054 2019-04-04  Tom Tromey  <tom@tromey.com>
6055
6056         * type-stack.h: New file.
6057         * type-stack.c: New file.
6058         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6059         type-stack.h.
6060         (insert_into_type_stack, insert_type, push_type, push_type_int)
6061         (insert_type_address_space, pop_type, pop_type_int)
6062         (pop_typelist, pop_type_stack, append_type_stack)
6063         (push_type_stack, get_type_stack, push_typelist)
6064         (follow_type_instance_flags, follow_types): Don't declare.
6065         * parse.c (type_stack): Remove global.
6066         (parse_exp_in_context): Update.
6067         (insert_into_type_stack, insert_type, push_type, push_type_int)
6068         (insert_type_address_space, pop_type, pop_type_int)
6069         (pop_typelist, pop_type_stack, append_type_stack)
6070         (push_type_stack, get_type_stack, push_typelist)
6071         (follow_type_instance_flags, follow_types): Remove (moved to
6072         type-stack.c).
6073         * f-exp.y (type_stack): New global.
6074         Update rules.
6075         (push_kind_type, f_parse): Update.
6076         * d-exp.y (type_stack): New global.
6077         Update rules.
6078         (d_parse): Update.
6079         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6080         Update rules.
6081         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6082         (HFILES_NO_SRCDIR): Add type-stack.h.
6083
6084 2019-04-04  Tom Tromey  <tom@tromey.com>
6085
6086         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6087         (rust_parser::convert_ast_to_expression, rust_parse)
6088         (rust_lex_test_completion, rust_lex_tests): Update.
6089         * parser-defs.h (struct expr_completion_state): New.
6090         (struct parser_state) <parser_state>: Add completion parameter.
6091         <mark_struct_expression, mark_completion_tag>: New methods.
6092         <parse_completion, m_completion_state>: New members.
6093         (prefixify_expression, null_post_parser): Update.
6094         (mark_struct_expression, mark_completion_tag): Don't declare.
6095         * parse.c (parse_completion, expout_last_struct)
6096         (expout_tag_completion_type, expout_completion_name): Remove
6097         globals.
6098         (parser_state::mark_struct_expression)
6099         (parser_state::mark_completion_tag): Now methods.
6100         (prefixify_expression): Add last_struct parameter.
6101         (prefixify_subexp): Likewise.
6102         (parse_exp_1): Update.
6103         (parse_exp_in_context): Add cstate parameter.  Update.
6104         (parse_expression_for_completion): Create an
6105         expr_completion_state.
6106         (null_post_parser): Add "completion" parameter.
6107         * p-exp.y: Update rules.
6108         (yylex): Update.
6109         * language.h (struct language_defn) <la_post_parser>: Add
6110         "completing" parameter.
6111         * go-exp.y: Update rules.
6112         (lex_one_token): Update.
6113         * expression.h (parse_completion): Don't declare.
6114         * d-exp.y: Update rules.
6115         (lex_one_token): Update rules.
6116         * c-exp.y: Update rules.
6117         (lex_one_token): Update.
6118         * ada-lang.c (resolve): Add "parse_completion" parameter.
6119         (resolve_subexp): Likewise.
6120         (ada_resolve_function): Likewise.
6121
6122 2019-04-04  Tom Tromey  <tom@tromey.com>
6123
6124         * parser-defs.h (struct parser_state) <start_arglist,
6125         end_arglist>: New methods.
6126         <arglist_len, m_funcall_chain>: New members.
6127         (arglist_len, start_arglist, end_arglist): Don't declare.
6128         * parse.c (arglist_len, funcall_chain): Remove global.
6129         (start_arglist, end_arglist): Remove functions.
6130         (parse_exp_in_context): Update.
6131         * p-exp.y: Update rules.
6132         * m2-exp.y: Update rules.
6133         * go-exp.y: Update rules.
6134         * f-exp.y: Update rules.
6135         * d-exp.y: Update rules.
6136         * c-exp.y: Update rules.
6137
6138 2019-04-04  Tom Tromey  <tom@tromey.com>
6139
6140         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6141         lex_operator, push_back>: New methods.
6142         Update all rules.
6143         (rust_parser::lex_hex, lex_escape): Rename and update.
6144         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6145         (rust_parser::lex_operator): Rename and update.
6146         (rust_parser::lex_number, rustyylex, rustyyerror)
6147         (rust_lex_test_init, rust_lex_test_sequence)
6148         (rust_lex_test_push_back, rust_lex_tests): Update.
6149         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6150         parameter.
6151         <lexptr, prev_lexptr>: New members.
6152         (lexptr, prev_lexptr): Don't declare.
6153         * parse.c (lexptr, prev_lexptr): Remove globals.
6154         (parse_exp_in_context): Update.
6155         * p-exp.y (yylex, yyerror): Update.
6156         * m2-exp.y (parse_number, yylex, yyerror): Update.
6157         * go-exp.y (lex_one_token, yyerror): Update.
6158         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6159         * d-exp.y (lex_one_token, yyerror): Update.
6160         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6161         (lex_one_token, yyerror): Update.
6162         * ada-lex.l (YY_INPUT): Update.
6163         (rewind_to_char): Update.
6164         * ada-exp.y (yyerror): Update.
6165
6166 2019-04-04  Tom Tromey  <tom@tromey.com>
6167
6168         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6169         * parser-defs.h (struct parser_state) <parser_state>: Add new
6170         parameter.
6171         <comma_terminates>: New member.
6172         (comma_terminates): Don't declare global.
6173         * parse.c (comma_terminates): Remove global.
6174         (parse_exp_in_context): Update.
6175         * p-exp.y (yylex): Update.
6176         * m2-exp.y (yylex): Update.
6177         * go-exp.y (lex_one_token): Update.
6178         * f-exp.y (yylex): Update.
6179         * d-exp.y (lex_one_token): Update.
6180         * c-exp.y (lex_one_token): Update.
6181         * ada-lex.l: Update.
6182
6183 2019-04-04  Tom Tromey  <tom@tromey.com>
6184
6185         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6186         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6187         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6188         * parser-defs.h (paren_depth): Don't declare.
6189         * parse.c (paren_depth): Remove global.
6190         (parse_exp_in_context): Update.
6191         * p-exp.y (paren_depth): New global.
6192         (pascal_parse): Initialize it.
6193         * m2-exp.y (paren_depth): New global.
6194         (m2_parse): Initialize it.
6195         * go-exp.y (paren_depth): New global.
6196         (go_parse): Initialize it.
6197         * f-exp.y (paren_depth): New global.
6198         (f_parse): Initialize it.
6199         * d-exp.y (paren_depth): New global.
6200         (d_parse): Initialize it.
6201         * c-exp.y (paren_depth): New global.
6202         (c_parse): Initialize it.
6203         * ada-lex.l (paren_depth): New global.
6204         (lexer_init): Initialize it.
6205
6206 2019-04-04  Tom Tromey  <tom@tromey.com>
6207
6208         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6209         (rust_parser::convert_ast_to_type)
6210         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6211         * parser-defs.h (struct parser_state) <parser_state>: Add
6212         parameters.  Initialize new members.
6213         <expression_context_block, expression_context_pc>: New members.
6214         * parse.c (expression_context_block, expression_context_pc):
6215         Remove globals.
6216         (parse_exp_in_context): Update.
6217         * p-exp.y: Update all rules.
6218         (yylex): Update.
6219         * m2-exp.y: Update all rules.
6220         (yylex): Update.
6221         * go-exp.y (yylex): Update.
6222         * f-exp.y (yylex): Update.
6223         * d-exp.y: Update all rules.
6224         (yylex): Update.
6225         * c-exp.y: Update all rules.
6226         (lex_one_token, classify_name, yylex, c_parse): Update.
6227         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6228
6229 2019-04-04  Tom Tromey  <tom@tromey.com>
6230
6231         * gdbarch.h, gdbarch.c: Rebuild.
6232         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6233         * stap-probe.h:
6234         (struct stap_parse_info): Replace "parser_state" with
6235         "expr_builder".
6236         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6237         (parser_state): New class.
6238         * parse.c (expr_builder): Rename.
6239         (expr_builder::release): Rename.
6240         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6241         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6242         (write_exp_elt_longcst, write_exp_elt_floatcst)
6243         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6244         (write_exp_string_vector, write_exp_bitstring)
6245         (write_exp_msymbol, mark_struct_expression)
6246         (write_dollar_variable)
6247         (insert_type_address_space, increase_expout_size): Replace
6248         "parser_state" with "expr_builder".
6249         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6250         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6251         "parser_state" with "expr_builder".
6252
6253 2019-04-04  Tom Tromey  <tom@tromey.com>
6254
6255         * rust-exp.y: Replace "parse_language" with method call.
6256         * p-exp.y:
6257         (yylex): Replace "parse_language" with method call.
6258         * m2-exp.y:
6259         (yylex): Replace "parse_language" with method call.
6260         * go-exp.y (classify_name): Replace "parse_language" with method
6261         call.
6262         * f-exp.y (yylex): Replace "parse_language" with method call.
6263         * d-exp.y (lex_one_token): Replace "parse_language" with method
6264         call.
6265         * c-exp.y:
6266         (lex_one_token, classify_name, yylex): Replace "parse_language"
6267         with method call.
6268         * ada-exp.y (find_primitive_type, type_char)
6269         (type_system_address): Replace "parse_language" with method call.
6270
6271 2019-04-04  Tom Tromey  <tom@tromey.com>
6272
6273         * rust-exp.y: Replace "parse_gdbarch" with method call.
6274         * parse.c (write_dollar_variable, insert_type_address_space):
6275         Replace "parse_gdbarch" with method call.
6276         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6277         call.
6278         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6279         call.
6280         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6281         "parse_gdbarch" with method call.
6282         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6283         with method call.
6284         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6285         "parse_gdbarch" with method call.
6286         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6287         "parse_gdbarch" with method call.
6288         * c-exp.y (parse_type, parse_number, classify_name): Replace
6289         "parse_gdbarch" with method call.
6290         * ada-lex.l: Replace "parse_gdbarch" with method call.
6291         * ada-exp.y (parse_type, find_primitive_type, type_char)
6292         (type_system_address): Replace "parse_gdbarch" with method call.
6293
6294 2019-04-04  Tom Tromey  <tom@tromey.com>
6295
6296         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6297         * stap-probe.c (stap_parse_argument): Update.
6298         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6299         initial_size parameter.
6300         * rust-exp.y (rust_lex_tests): Update.
6301         * parse.c (parser_state): Update.
6302         (parse_exp_in_context): Update.
6303         * parser-defs.h (struct parser_state) <parser_state>: Remove
6304         "initial_size" parameter.
6305
6306 2019-04-04  Tom Tromey  <tom@tromey.com>
6307
6308         * parser-defs.h (increase_expout_size): Don't declare.
6309         * parse.c (increase_expout_size): Now static.
6310
6311 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6312
6313         * gnu-nat.c (gnu_nat_target::wait): Fix
6314         target_waitstatus_to_string call.
6315
6316 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6317
6318         * eval.c (evaluate_subexp_standard): Handle internal functions
6319         during Fortran function call handling.
6320
6321 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6322
6323         * NEWS: Mention new internal functions.
6324         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6325         (read_base_type): Use dwarf2_init_complex_target_type.
6326         * value.c (creal_internal_fn): New function.
6327         (cimag_internal_fn): New function.
6328         (_initialize_values): Register new internal functions.
6329
6330 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6331
6332         * infrun.c (stop_all_threads): If debug_infrun, always
6333         trace the wait status after wait_one, using
6334         target_waitstatus_to_string and target_pid_to_str.
6335         (handle_inferior_event): Replace various trace of
6336         wait status kind by a single trace.
6337         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6338         wait status kind image by target_waitstatus_to_string.
6339         * target/waitstatus.c (target_waitstatus_to_string): Fix
6340         obsolete comment.
6341
6342 2019-04-01  Tom Tromey  <tromey@adacore.com>
6343
6344         PR symtab/23331:
6345         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6346
6347 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6348             Pedro Alves  <palves@redhat.com>
6349
6350         * top.c (quit_force): Call 'finalize_values'.
6351         * value.c (finalize_values): New function.
6352         * value.h (finalize_values): Declare.
6353
6354 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6355
6356         * NEWS: Announce $_gdb_major and $_gdb_minor.
6357
6358         * top.c (init_gdb_version_vars): New function.
6359         (gdb_init): Call init_gdb_version_vars.
6360
6361 2019-03-29  Tom Tromey  <tromey@adacore.com>
6362
6363         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6364         help text.  Remove dead code.
6365
6366 2019-03-29  Keith Seitz  <keiths@redhat.com>
6367
6368         From Siddhesh Poyarekar:
6369         * f-lang.h (f77_get_upperbound): Return LONGEST.
6370         (f77_get_lowerbound): Likewise.
6371         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6372         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6373         print them.
6374         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6375         plongest to format print it.
6376         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6377         (f77_get_upperbound): Likewise.
6378         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6379         LOWER_BOUND to LONGEST.
6380         (f77_create_arrayprint_offset_tbl): Likewise.
6381
6382 2019-03-29  Keith Seitz  <keiths@redhat.com>
6383
6384         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6385         %s/pulongest for TYPE_LENGTH instead of %d in format
6386         strings.
6387         * ada-typerint.c (ada_print_type): Likewise.
6388         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6389         * compile/compile-c-support.c (generate_register_struct): Likewise.
6390         * gdbtypes.c (recursive_dump_type): Likewise.
6391         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6392         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6393         instead of %d in format strings.
6394         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6395         to std::min to ULONGEST.
6396         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6397         instead of %d in format strings.
6398         * tracepoint.c (info_scope_command): Likewise.
6399         * typeprint.c (print_offset_data::update)
6400         (print_offset_data::finish): Likewise.
6401         * xtensa-tdep.c (xtensa_store_return_value)
6402         (xtensa_push_dummy_call): Likewise.
6403
6404 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6405
6406         * windows-nat.c (display_selector): Fixed format specifications
6407         for 64-bit Cygwin.
6408
6409 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6410
6411         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6412
6413 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6414
6415         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6416         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6417         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6418         (nios2_linux_init_abi): Install it.
6419
6420 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6421
6422         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6423
6424 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6425
6426         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6427
6428 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6429             Tom Tromey  <tromey@adacore.com>
6430
6431         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6432
6433 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6434
6435         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6436         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6437         method to compute the bounds of range types. Also print "[evaluated]"
6438         if the bounds' values come from a dynamic evaluation.
6439
6440 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6441
6442         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6443         whitespace when pretty printing is on.
6444
6445 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6446
6447         * ppc-linux-nat.c: Add include.
6448
6449 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6450
6451         * NEWS: Mention AArch64 Pointer Authentication.
6452
6453 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6454
6455         * arm-linux-nat.c: Add include.
6456
6457 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6458
6459         * source-cache.c (source_cache::get_source_lines): Re-read
6460         fullname after calling open_source_file.
6461
6462 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6463
6464         * NEWS: Mention TLS support for FreeBSD.
6465
6466 2019-03-25  Tom Tromey  <tromey@adacore.com>
6467
6468         * minsyms.c (BUNCH_SIZE): Update comment.
6469         (~minimal_symbol_reader): Remove old comment.
6470         (compact_minimal_symbols): Update comment.
6471         (minimal_symbol_reader::install): Remove old comment.  Update
6472         other comments.
6473
6474 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6475
6476         * s390-linux-nat.c: Add include.
6477
6478 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6479
6480         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6481         Call linux_get_hwcap.
6482         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6483         Likewise.
6484         (aarch64_linux_get_hwcap): Remove function.
6485         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6486         declaration.
6487         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6488         linux_get_hwcap.
6489         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6490         * linux-tdep.c (linux_get_hwcap): Add function.
6491         (linux_get_hwcap2): Likewise.
6492         * linux-tdep.h (linux_get_hwcap): Add declaration.
6493         (linux_get_hwcap2): Likewise.
6494         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6495         (ppc_linux_get_hwcap2): Likewise.
6496         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6497         linux_get_hwcap.
6498         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6499         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6500         (ppc_linux_nat_target::read_description): Likewise.
6501         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6502         * s390-linux-nat.c: Likewise.
6503         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6504
6505 2019-03-24  Tom Tromey  <tom@tromey.com>
6506
6507         * ada-lang.c (standard_lookup): Simplify initialization.
6508         (ada_lookup_symbol_nonlocal): Simplify return.
6509         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6510         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6511         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6512         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6513         initialization.
6514         * solib.c (solib_global_lookup): Simplify.
6515         * symtab.c (null_block_symbol): Remove.
6516         (symbol_cache_lookup): Simplify returns.
6517         (lookup_language_this): Simplify returns.
6518         (lookup_symbol_aux): Simplify return.
6519         (lookup_local_symbol): Simplify returns.
6520         (lookup_global_symbol_from_objfile): Simplify return.
6521         (lookup_symbol_in_objfile_symtabs)
6522         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6523         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6524         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6525         * cp-namespace.c (cp_lookup_bare_symbol)
6526         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6527         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6528         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6529         (cp_lookup_symbol_via_imports): Simplify initialization.
6530         (find_symbol_in_baseclass): Likewise.
6531         * symtab.h (null_block_symbol): Remove.
6532         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6533         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6534         (d_lookup_symbol_module): Likewise.
6535         (find_symbol_in_baseclass): Simplify initialization.
6536
6537 2019-03-24  Tom Tromey  <tom@tromey.com>
6538
6539         * expression.h: Don't include symtab.h.
6540         (struct block): Forward declare.
6541
6542 2019-03-24  Tom Tromey  <tom@tromey.com>
6543
6544         * c-exp.y (typebase): Remove casts.
6545         * gdbtypes.c (lookup_unsigned_typename, )
6546         (lookup_signed_typename): Remove cast.
6547         * eval.c (parse_to_comma_and_eval): Remove cast.
6548         * parse.c (write_dollar_variable): Remove cast.
6549         * block.h (struct block) <superblock>: Now const.
6550         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6551         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6552         (map_block): Make "block" const.
6553         * symfile.h (struct quick_symbol_functions)
6554         <map_matching_symbols>: Constify block argument to "callback".
6555         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6556         const.
6557         (find_pc_sect_compunit_symtab): Make "b" const.
6558         (find_symbol_at_address): Likewise.
6559         (search_symbols): Likewise.
6560         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6561         (dw2_debug_names_lookup_symbol): Likewise.
6562         (dw2_map_matching_symbols): Update.
6563         * p-valprint.c (pascal_val_print): Remove "block".
6564         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6565         (aux_add_nonlocal_symbols): Make "block" const.
6566         (resolve_subexp): Remove cast.
6567         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6568         const.
6569         (iterate_over_file_blocks): Likewise.
6570         * f-exp.y (%union) <bval>: Remove.
6571         * coffread.c (patch_opaque_types): Make "b" const.
6572         * spu-tdep.c (spu_catch_start): Make "block" const.
6573         * c-valprint.c (print_unpacked_pointer): Remove "block".
6574         * symmisc.c (dump_symtab_1): Make "b" const.
6575         (block_depth): Make "block" const.
6576         * d-exp.y (%union) <bval>: Remove.
6577         * cp-support.h (cp_lookup_rtti_type): Update.
6578         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6579         * psymtab.c (psym_lookup_symbol): Make "block" const.
6580         (maintenance_check_psymtabs): Make "b" const.
6581         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6582         (enumerate_locals, enumerate_args): Update.
6583         * python/py-symtab.c (stpy_global_block): Make "block" const.
6584         (stpy_static_block): Likewise.
6585         * inline-frame.c (block_starting_point_at): Make "new_block"
6586         const.
6587         * block.c (find_block_in_blockvector): Make return type const.
6588         (blockvector_for_pc_sect): Make "b" const.
6589         (find_block_in_blockvector): Make "b" const.
6590
6591 2019-03-23  Tom Tromey  <tom@tromey.com>
6592
6593         * varobj.c (varobj_create): Update.
6594         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6595         * printcmd.c (display_command, do_one_display): Don't reset
6596         innermost_block.
6597         * parser-defs.h (enum innermost_block_tracker_type): Move to
6598         expression.h.
6599         (innermost_block): Update comment.
6600         * parse.c (parse_exp_1): Add tracker_types parameter.
6601         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6602         tracker_types parameter.  Reset innermost_block.
6603         (parse_exp_in_context): Remove.
6604         (parse_expression_for_completion): Update.
6605         * objfiles.c (~objfile): Don't reset expression_context_block or
6606         innermost_block.
6607         * expression.h (enum innermost_block_tracker_type): Move from
6608         parser-defs.h.
6609         (parse_exp_1): Add tracker_types parameter.
6610         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6611         reset innermost_block.
6612
6613 2019-03-23  Tom Tromey  <tom@tromey.com>
6614
6615         * objfiles.h: Include bcache.h.
6616
6617 2019-03-23  Tom Tromey  <tom@tromey.com>
6618
6619         * linespec.c (get_current_search_block): Use
6620         scoped_restore_current_language.
6621         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6622
6623 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6624             Jiong Wang  <jiong.wang@arm.com>
6625
6626         * aarch64-linux-tdep.c
6627         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6628         section.
6629         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6630
6631 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6632             Jiong Wang  <jiong.wang@arm.com>
6633
6634         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6635         instructions.
6636         (aarch64_analyze_prologue_test): Add PACIASP test.
6637         (aarch64_prologue_prev_register): Unmask PC value.
6638
6639 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6640             Jiong Wang  <jiong.wang@arm.com>
6641
6642         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6643         (aarch64_dwarf2_prev_register): Unmask PC value.
6644         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6645         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6646         DW_CFA_AARCH64_negate_ra_state.
6647         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6648
6649 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6650             Jiong Wang  <jiong.wang@arm.com>
6651
6652         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6653         registers.
6654         (aarch64_pseudo_register_name): Likewise.
6655         (aarch64_pseudo_register_type): Likewise.
6656         (aarch64_pseudo_register_reggroup_p): Likewise.
6657         (aarch64_gdbarch_init): Add pauth registers.
6658         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6659         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6660         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6661         (struct gdbarch_tdep): Add regnum for ra_state.
6662
6663 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6664             Jiong Wang  <jiong.wang@arm.com>
6665
6666         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6667
6668 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6669             Jiong Wang  <jiong.wang@arm.com>
6670
6671         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6672         function.
6673         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6674         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6675         (aarch64_gdbarch_init): Add puth registers.
6676         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6677         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6678         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6679
6680 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6681             Jiong Wang  <jiong.wang@arm.com>
6682
6683         * aarch64-linux-nat.c
6684         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6685         * aarch64-linux-tdep.c
6686         (aarch64_linux_core_read_description): Likewise.
6687         (aarch64_linux_get_hwcap): New function.
6688         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6689         (aarch64_linux_get_hwcap): New declaration.
6690
6691 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6692             Jiong Wang  <jiong.wang@arm.com>
6693
6694         * aarch64-linux-nat.c
6695         (aarch64_linux_nat_target::read_description): Add pauth param.
6696         * aarch64-linux-tdep.c
6697         (aarch64_linux_core_read_description): Likewise.
6698         * aarch64-tdep.c (struct target_desc): Add in pauth.
6699         (aarch64_read_description): Add pauth param.
6700         (aarch64_gdbarch_init): Likewise.
6701         * aarch64-tdep.h (aarch64_read_description): Likewise.
6702         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6703         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6704         * features/Makefile: Add new files.
6705         * features/aarch64-pauth.c: New file.
6706         * features/aarch64-pauth.xml: New file.
6707
6708 2019-03-20  Tom Tromey  <tromey@adacore.com>
6709
6710         * infrun.c (handle_inferior_event): Rename from
6711         handle_inferior_event_1.  Create a scoped_value_mark.
6712         (handle_inferior_event): Remove.
6713
6714 2019-03-19  Tom Tromey  <tromey@adacore.com>
6715
6716         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6717         * infrun.h (print_stop_event): Add "displays" parameter.
6718         * infrun.c (print_stop_event): Add "displays" parameter.
6719
6720 2019-03-19  Pedro Alves  <palves@redhat.com>
6721
6722         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6723         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6724         to -1.  Fix TABs vs spaces.
6725         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6726         * tui/tui-out.h (tui_ui_out) Add intro comments.
6727         <m_line, m_start_of_line>: In-class initialize, and add describing
6728         comment.
6729
6730 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6731
6732         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6733         variable names.
6734         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6735
6736 2019-03-18  Pedro Alves  <palves@redhat.com>
6737             Eli Zaretskii <eliz@gnu.org>
6738
6739         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6740         m_line and m_start_of_line.
6741
6742 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6743
6744         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6745         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6746         it returns a newline.  This fixes a regression in TU mode, whereby
6747         the next line is output on the same screen line as the user input.
6748
6749 2019-03-18  Tom Tromey  <tromey@adacore.com>
6750
6751         * minsyms.c (minimal_symbol_reader::install): Remove call to
6752         obstack_blank.
6753
6754 2019-03-18  Pedro Alves  <palves@redhat.com>
6755
6756         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6757         New globals.
6758         (apply_style): New, factored out from ...
6759         (apply_ansi_escape): ... this.  Handle reverse video mode.
6760         (tui_set_reverse_mode): New function.
6761         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6762         * tui/tui-winsource.c (tui_show_source_line): Use
6763         tui_set_reverse_mode instead of setting A_STANDOUT.
6764         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6765         New setter methods.
6766
6767 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6768
6769         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6770         Handle tabs.
6771
6772 2019-03-18  Tom Tromey  <tromey@adacore.com>
6773
6774         * ada-lang.c (empty_array): Add "high" parameter.
6775         (ada_evaluate_subexp): Update.
6776
6777 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6778
6779         * unittests/string_view-selftests.c: Define
6780         _initialize_string_view_selftests unconditionally.
6781
6782 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6783
6784         PR gdb/24350
6785         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6786
6787 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6788
6789         PR gdb/24351
6790         * windows-nat.c (display_selector): Fix format specifiers.
6791
6792 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6793
6794         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6795         tui_refill_source_window instead of tui_refresh_win, to update the
6796         current execution line.  This fixes redisplay of the current line
6797         when stepping through the code with "next" or "step".
6798
6799 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6800
6801         * source-cache.c (source_cache::get_source_lines): Call
6802         find_source_lines to initialize s->nlines.  This fixes vertical
6803         scrolling of TUI source window when the DOWN arrow is pressed.
6804
6805 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6806
6807         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6808         linux-thread-db.c (_initialize_thread_db): Likewise.
6809
6810 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6811
6812         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6813         wclrtoeol in tui_show_source_line".  This reverts changes made in
6814         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6815
6816 2019-03-15  Tom Tromey  <tom@tromey.com>
6817
6818         * symtab.h (struct minimal_symbol): Derive from
6819         general_symbol_info.
6820         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6821         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6822         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6823         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6824         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6825         (MSYMBOL_SEARCH_NAME): Update.
6826         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6827         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6828         * minsyms.c (minimal_symbol_reader::record_full): Update.
6829
6830 2019-03-15  Tom Tromey  <tom@tromey.com>
6831
6832         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6833
6834 2019-03-15  Tom Tromey  <tom@tromey.com>
6835
6836         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6837         unique_xmalloc_ptr.
6838         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6839         Update.
6840         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6841         (build_minimal_symbol_hash_tables)
6842         (minimal_symbol_reader::install): Update.
6843
6844 2019-03-15  Tom Tromey  <tom@tromey.com>
6845
6846         * symtab.c (create_demangled_names_hash): Update.
6847         (symbol_set_names): Update.
6848         * objfiles.h (struct objfile_per_bfd_storage)
6849         <demangled_names_hash>: Now an htab_up.
6850         * objfiles.c (objfile_per_bfd_storage): Simplify.
6851
6852 2019-03-15  Tom Tromey  <tom@tromey.com>
6853
6854         * objfiles.h (struct objfile_per_bfd_storage): Declare
6855         destructor.
6856         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6857         New.
6858         (get_objfile_bfd_data): Use new.  Don't initialize
6859         language_of_main.
6860         (free_objfile_per_bfd_storage): Remove.
6861         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6862
6863 2019-03-15  Tom Tromey  <tom@tromey.com>
6864
6865         * symfile.c (reread_symbols): Update.
6866         * objfiles.c (objfile::objfile): Update.
6867         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6868         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6869         comment.
6870         (minimal_symbol_reader::install): Update.
6871         (terminate_minimal_symbol_table): Remove.
6872         * jit.c (jit_object_close_impl): Update.
6873
6874 2019-03-15  Tom Tromey  <tom@tromey.com>
6875
6876         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6877         initializations.
6878
6879 2019-03-15  Tom Tromey  <tom@tromey.com>
6880
6881         * objfiles.h (struct objfile_per_bfd_storage)
6882         <demangled_hash_languages>: Now a bitset.
6883         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6884         (lookup_minimal_symbol): Update.
6885
6886 2019-03-15  Tom Tromey  <tom@tromey.com>
6887
6888         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6889         Don't return the symbol.
6890         * coffread.c (record_minimal_symbol): Use record_full.
6891
6892 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6893
6894         The MS-Windows port of ncurses fails to switch to a color pair if
6895         one or both of the colors are the implicit default colors.  This
6896         change records the default colors when TUI is initialized, and
6897         then specifies them explicitly when a color pair uses the default
6898         colors.  This allows color styling in TUI mode on MS-Windows.
6899
6900         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6901         ncurses_norm_attr.
6902         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6903         colors in ncurses_norm_attr.
6904         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6905         "none", replace it with the default color recorded in
6906         ncurses_norm_attr.
6907
6908 2019-03-14  Tom Tromey  <tromey@adacore.com>
6909
6910         * source-cache.h (class source_cache) <get_source_lines>: Return
6911         std::string.
6912         * source-cache.c (source_cache::extract_lines): Handle case where
6913         first_pos==npos.  Return std::string.
6914         (source_cache::get_source_lines): Update.
6915
6916 2019-03-14  Tom Tromey  <tromey@adacore.com>
6917
6918         * NEWS: Add item for "style sources" commands.
6919         * source-cache.c (source_cache::get_source_lines): Check
6920         source_styling.
6921         * cli/cli-style.c (source_styling): New global.
6922         (_initialize_cli_style): Add "style sources" commands.
6923         (show_style_sources): New function.
6924         * cli/cli-style.h (source_styling): Declare.
6925
6926 2019-03-14  Pedro Alves  <palves@redhat.com>
6927             Tom Tromey  <tromey@adacore.com>
6928
6929         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6930         * tui/tui-winsource.c (tui_refill_source_window): New function,
6931         from...
6932         (tui_horizontal_source_scroll): ... here.  Move some logic.
6933         * cli/cli-style.c (set_style_enabled): Notify new observable.
6934         * tui/tui-hooks.c (tui_redisplay_source): New function.
6935         (tui_attach_detach_observers): Attach or detach
6936         tui_redisplay_source.
6937         * observable.h (source_styling_changed): New observable.
6938         * observable.c: Define source_styling_changed observable.
6939
6940 2019-03-13  Tom Tromey  <tromey@adacore.com>
6941
6942         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6943         (i386_gnu_nat_target::store_registers): Update.
6944         * target-debug.h (target_debug_print_std_string): New macro.
6945         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6946         * windows-tdep.c (display_one_tib): Update.
6947         * tui/tui-stack.c (tui_make_status_line): Update.
6948         * top.c (print_inferior_quit_action): Update.
6949         * thread.c (thr_try_catch_cmd): Update.
6950         (add_thread_with_info): Update.
6951         (thread_target_id_str): Update.
6952         (thr_try_catch_cmd): Update.
6953         (thread_command): Update.
6954         (thread_find_command): Update.
6955         * record-btrace.c (record_btrace_target::info_record)
6956         (record_btrace_resume_thread, record_btrace_target::resume)
6957         (record_btrace_cancel_resume, record_btrace_step_thread)
6958         (record_btrace_target::wait, record_btrace_target::wait)
6959         (record_btrace_target::wait, record_btrace_target::stop): Update.
6960         * progspace.c (print_program_space): Update.
6961         * process-stratum-target.c
6962         (process_stratum_target::thread_address_space): Update.
6963         * linux-fork.c (linux_fork_mourn_inferior)
6964         (detach_checkpoint_command, info_checkpoints_command)
6965         (linux_fork_context): Update.
6966         (linux_fork_detach): Update.
6967         (class scoped_switch_fork_info): Update.
6968         (delete_checkpoint_command): Update.
6969         * infrun.c (follow_fork_inferior): Update.
6970         (follow_fork_inferior): Update.
6971         (proceed_after_vfork_done): Update.
6972         (handle_vfork_child_exec_or_exit): Update.
6973         (follow_exec): Update.
6974         (displaced_step_prepare_throw): Update.
6975         (displaced_step_restore): Update.
6976         (start_step_over): Update.
6977         (resume_1): Update.
6978         (clear_proceed_status_thread): Update.
6979         (proceed): Update.
6980         (print_target_wait_results): Update.
6981         (do_target_wait): Update.
6982         (context_switch): Update.
6983         (stop_all_threads): Update.
6984         (restart_threads): Update.
6985         (finish_step_over): Update.
6986         (handle_signal_stop): Update.
6987         (switch_back_to_stepped_thread): Update.
6988         (keep_going_pass_signal): Update.
6989         (print_exited_reason): Update.
6990         (normal_stop): Update.
6991         * inferior.c (inferior_pid_to_str): Change return type.
6992         (print_selected_inferior): Update.
6993         (add_inferior): Update.
6994         (detach_inferior): Update.
6995         * dummy-frame.c (fprint_dummy_frames): Update.
6996         * dcache.c (dcache_info_1): Update.
6997         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6998         (btrace_fetch, btrace_clear): Update.
6999         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7000         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7001         type.
7002         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7003         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7004         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7005         * gdbarch.c, gdbarch.h: Rebuild.
7006         * gdbarch.sh (core_pid_to_str): Change return type.
7007         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7008         return type.
7009         (windows_nat_target::pid_to_str): Change return type.
7010         (windows_delete_thread): Update.
7011         (windows_nat_target::attach): Update.
7012         (windows_nat_target::files_info): Update.
7013         * target-delegates.c: Rebuild.
7014         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7015         return type.
7016         (sol_thread_target::pid_to_str): Change return type.
7017         * remote.c (class remote_target) <pid_to_str>: Change return
7018         type.
7019         (remote_target::pid_to_str): Change return type.
7020         (extended_remote_target::attach, remote_target::remote_stop_ns)
7021         (remote_target::remote_notif_remove_queued_reply)
7022         (remote_target::push_stop_reply, remote_target::disable_btrace):
7023         Update.
7024         (extended_remote_target::attach): Update.
7025         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7026         type.
7027         (gdbsim_target::pid_to_str): Change return type.
7028         * ravenscar-thread.c (struct ravenscar_thread_target)
7029         <pid_to_str>: Change return type.
7030         (ravenscar_thread_target::pid_to_str): Change return type.
7031         * procfs.c (class procfs_target) <pid_to_str>: Change return
7032         type.
7033         (procfs_target::pid_to_str): Change return type.
7034         (procfs_target::attach): Update.
7035         (procfs_target::detach): Update.
7036         (procfs_target::fetch_registers): Update.
7037         (procfs_target::store_registers): Update.
7038         (procfs_target::wait): Update.
7039         (procfs_target::files_info): Update.
7040         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7041         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7042         return type.
7043         (nto_procfs_target::pid_to_str): Change return type.
7044         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7045         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7046         return type.
7047         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7048         (exit_lwp): Update.
7049         (attach_proc_task_lwp_callback, get_detach_signal)
7050         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7051         (linux_nat_target::resume, wait_lwp, stop_callback)
7052         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7053         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7054         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7055         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7056         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7057         type.
7058         (inf_ptrace_target::attach): Update.
7059         (inf_ptrace_target::files_info): Update.
7060         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7061         type.
7062         (go32_nat_target::pid_to_str): Change return type.
7063         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7064         (gnu_nat_target::wait): Update.
7065         (gnu_nat_target::wait): Update.
7066         (gnu_nat_target::resume): Update.
7067         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7068         (fbsd_nat_target::wait): Update.
7069         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7070         type.
7071         (darwin_nat_target::attach): Update.
7072         * corelow.c (class core_target) <pid_to_str>: Change return type.
7073         (core_target::pid_to_str): Change return type.
7074         * target.c (normal_pid_to_str): Change return type.
7075         (default_pid_to_str): Likewise.
7076         (target_pid_to_str): Change return type.
7077         (target_translate_tls_address): Update.
7078         (target_announce_detach): Update.
7079         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7080         return type.
7081         (bsd_uthread_target::pid_to_str): Change return type.
7082         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7083         type.
7084         (bsd_kvm_target::pid_to_str): Change return type.
7085         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7086         return type.
7087         (aix_thread_target::pid_to_str): Change return type.
7088         * target.h (struct target_ops) <pid_to_str>: Change return type.
7089         (target_pid_to_str, normal_pid_to_str): Likewise.
7090         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7091         type.
7092         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7093         type.
7094         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7095         return type.
7096         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7097         type.
7098         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7099         type.
7100         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7101         return type.
7102
7103 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7104
7105         * NEWS: Mention that the new default MI version is 3.  Mention
7106         changes to the output of commands and events that deal with
7107         multi-location breakpoints.
7108         * breakpoint.c: Include "mi/mi-out.h".
7109         (print_one_breakpoint): Change output syntax if using MI version
7110         >= 3.
7111         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7112         New.
7113         (mi_multi_location_breakpoint_output_fixed): New.
7114         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7115         (mi_cmd_fix_multi_location_breakpoint_output): New.
7116         (mi_multi_location_breakpoint_output_fixed): New.
7117         * mi/mi-cmds.c (mi_cmds): Register command
7118         -fix-multi-location-breakpoint-output.
7119         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7120         interpreter "mi".
7121
7122 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7123
7124         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7125         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7126         instantiate mi_ui_out based on interpreter name.
7127         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7128         * mi/mi-main.c (mi_load_progress): Likewise.
7129
7130 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7131
7132         * NEWS: Combine separate "New targets" sections for 8.3.
7133
7134 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7135
7136         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7137         (ppcfbsd_init_abi): Install gdbarch
7138         "fetch_tls_load_module_address" and "get_thread_local_address"
7139         methods.
7140
7141 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7142
7143         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7144         (riscv_fbsd_init_abi): Install gdbarch
7145         "fetch_tls_load_module_address" and "get_thread_local_address"
7146         methods.
7147
7148 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7149
7150         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7151         (i386fbsd_init_abi): Install gdbarch
7152         "fetch_tls_load_module_address" and "get_thread_local_address"
7153         methods.
7154
7155 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7156
7157         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7158         (amd64fbsd_init_abi): Install gdbarch
7159         "fetch_tls_load_module_address" and "get_thread_local_address"
7160         methods.
7161
7162 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7163
7164         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7165         (struct fbsd_pspace_data): New type.
7166         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7167         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7168         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7169         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7170         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7171
7172 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7173
7174         * gdbtypes.c (lookup_struct_elt): New function.
7175         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7176         * gdbtypes.h (struct struct_elt): New type.
7177         (lookup_struct_elt): New prototype.
7178
7179 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7180
7181         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7182         remove disabled code block.
7183
7184 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7185
7186         * gdbarch.sh (get_thread_local_address): New method.
7187         * gdbarch.h, gdbarch.c: Regenerate.
7188         * target.c (target_translate_tls_address): Use
7189         gdbarch_get_thread_local_address if present instead of
7190         target::get_thread_local_address.
7191
7192 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7193
7194         * target.h (target::get_thread_local_address): Update comment.
7195
7196 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7197
7198         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7199         objfile->separate_debug_objfile_backlink if not NULL.
7200
7201 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7202
7203         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7204         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7205         (amd64bsd_store_inferior_registers): Likewise.
7206         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7207         Enable segment base registers.
7208         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7209         PT_GETFSBASE and PT_GETGSBASE.
7210         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7211         PT_SETGSBASE.
7212         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7213         segment base registers.
7214         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7215
7216 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7217
7218         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7219         Update calls to i386_target_description to add 'segments'
7220         parameter.
7221         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7222         add segment base registers.
7223         * arch/i386.c (i386_create_target_description): Add 'segments'
7224         parameter to enable segment base registers.
7225         * arch/i386.h (i386_create_target_description): Likewise.
7226         * features/i386/32bit-segments.xml: New file.
7227         * features/i386/32bit-segments.c: Generate.
7228         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7229         call to i386_target_description to add 'segments' parameter.
7230         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7231         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7232         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7233         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7234         if feature is present.
7235         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7236         Add 'segments' parameter to call to i386_target_description.
7237         (i386_target_description): Add 'segments' parameter to enable
7238         segment base registers.
7239         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7240         to call to i386_target_description.
7241         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7242         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7243         Define I386_NUM_REGS.
7244         (i386_target_description): Add 'segments' parameter to enable
7245         segment base registers.
7246
7247 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7248
7249         PR/24325
7250         * source-cache.c: #undef open and close, to avoid unresolved
7251         externals during linking.
7252
7253 2019-03-12  Tom Tromey  <tromey@adacore.com>
7254
7255         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7256         const.  Add initializers.
7257         (_initialize_remote): Don't initialize ptid globals.
7258
7259 2019-03-12  Pedro Alves  <palves@redhat.com>
7260
7261         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7262
7263 2019-03-12  Pedro Alves  <palves@redhat.com>
7264
7265         * cp-name-parser.y (main): Remove unused 'len' variable.
7266
7267 2019-03-12  Tom Tromey  <tromey@adacore.com>
7268
7269         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7270         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7271
7272 2019-03-12  Tom Tromey  <tromey@adacore.com>
7273
7274         * linux-nat.c (iterate_over_lwps): Update.
7275         (stop_callback): Remove parameter.
7276         (stop_wait_callback, detach_callback, resume_set_callback)
7277         (select_singlestep_lwp_callback, set_ignore_sigint)
7278         (status_callback, resumed_callback, resume_clear_callback)
7279         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7280         data parameter.
7281         (linux_nat_target::detach, linux_nat_target::resume)
7282         (linux_stop_and_wait_all_lwps, select_event_lwp)
7283         (linux_nat_filter_event, linux_nat_wait_1)
7284         (linux_nat_target::kill, linux_nat_target::stop)
7285         (linux_nat_target::stop): Update.
7286         (linux_nat_resume_callback): Change type.
7287         (resume_stopped_resumed_lwps, count_events_callback)
7288         (select_event_lwp_callback): Likewise.
7289         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7290         * arm-linux-nat.c (struct update_registers_data): Remove.
7291         (update_registers_callback): Change type.
7292         (arm_linux_insert_hw_breakpoint1): Update.
7293         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7294         parameter.
7295         (x86_linux_dr_set_addr): Update.
7296         (x86_linux_dr_set_control): Update.
7297         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7298         (iterate_over_lwps): Use gdb::function_view.
7299         * nat/aarch64-linux-hw-point.c (struct
7300         aarch64_dr_update_callback_param): Remove.
7301         (debug_reg_change_callback): Change type.
7302         (aarch64_notify_debug_reg_change): Update.
7303         * s390-linux-nat.c (s390_refresh_per_info): Update.
7304
7305 2019-03-11  Tom Tromey  <tromey@adacore.com>
7306
7307         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7308         redundant assignment to "this_cu".
7309
7310 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7311
7312         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7313
7314 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7315
7316         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7317         from...
7318         (rank_one_type): ... this.
7319
7320 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7321
7322         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7323         from...
7324         (rank_one_type): ... this.
7325
7326 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7327
7328         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7329         from...
7330         (rank_one_type): ... this.
7331
7332 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7333
7334         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7335         from...
7336         (rank_one_type): ... this.
7337
7338 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7339
7340         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7341         from...
7342         (rank_one_type): ... this.
7343
7344 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7345
7346         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7347         from...
7348         (rank_one_type): ... this.
7349
7350 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7351
7352         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7353         from...
7354         (rank_one_type): ... this.
7355
7356 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7357
7358         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7359         from...
7360         (rank_one_type): ... this.
7361
7362 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7363
7364         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7365         from...
7366         (rank_one_type): ... this.
7367
7368 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7369
7370         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7371         from...
7372         (rank_one_type): ... this.
7373
7374 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7375
7376         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7377         from...
7378         (rank_one_type): ... this.
7379
7380 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7381
7382         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7383         from...
7384         (rank_one_type): ... this.
7385
7386 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7387
7388         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7389         inferior-events' shows the example events.
7390
7391 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7392
7393         Support styling on native MS-Windows console
7394
7395         PR/24315
7396         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7397         on MS-Windows if $TERM is not defined.
7398
7399         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7400
7401         * posix-hdep.c (gdb_console_fputs):
7402         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7403         functions.
7404         * ui-file.h (gdb_console_fputs): Add prototype.
7405
7406         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7407         back to fputs only if the former returns zero.
7408
7409 2019-03-07  Tom Tromey  <tom@tromey.com>
7410
7411         * symmisc.c (print_symbol_bcache_statistics): Update.
7412         (print_objfile_statistics): Update.
7413         * symfile.c (allocate_symtab): Update.
7414         * stabsread.c: Don't include bcache.h.
7415         * psymtab.h (struct psymbol_bcache): Don't declare.
7416         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7417         (psymbol_bcache_init, psymbol_bcache_free)
7418         (psymbol_bcache_get_bcache): Don't declare.
7419         * psymtab.c (struct psymbol_bcache): Remove.
7420         (psymtab_storage::psymtab_storage): Update.
7421         (psymtab_storage::~psymtab_storage): Update.
7422         (psymbol_bcache_init, psymbol_bcache_free)
7423         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7424         (add_psymbol_to_bcache): Update.
7425         (allocate_psymtab): Update.
7426         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7427         macro_cache>: No longer pointers.
7428         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7429         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7430         * macrotab.c (macro_bcache): Update.
7431         * macroexp.c: Don't include bcache.h.
7432         * gdbtypes.c (check_types_worklist): Update.
7433         (types_deeply_equal): Remove TRY/CATCH.  Update.
7434         * elfread.c (elf_symtab_read): Update.
7435         * dwarf2read.c: Don't include bcache.h.
7436         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7437         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7438         (print_bcache_statistics, bcache_memory_used): Don't declare.
7439         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7440         methods.  Rename all data members.
7441         * bcache.c (struct bcache): Move to bcache.h.
7442         (bcache::expand_hash_table): Rename from expand_hash_table.
7443         (bcache): Remove.
7444         (bcache::insert): Rename from bcache_full.
7445         (bcache::compare): Rename from bcache_compare.
7446         (bcache_xmalloc): Remove.
7447         (bcache::~bcache): Rename from bcache_xfree.
7448         (bcache::print_statistics): Rename from print_bcache_statistics.
7449         (bcache::memory_used): Rename from bcache_memory_used.
7450
7451 2019-03-07  Pedro Alves  <palves@redhat.com>
7452
7453         * infrun.c (normal_stop): Also check for
7454         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7455
7456 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7457
7458         * f-lang.c (value_from_host_double): Moved to...
7459         * value.c (value_from_host_double): ...here.
7460         * value.h (value_from_host_double): Declare.
7461         * guile/scm-math.c (vlscm_convert_typed_number): Use
7462         value_from_host_double.
7463         (vlscm_convert_number): Likewise.
7464         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7465         * python/py-value.c (convert_value_from_python): Likewise.
7466
7467 2019-03-06  Tom Tromey  <tom@tromey.com>
7468
7469         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7470
7471 2019-03-06  Tom Tromey  <tom@tromey.com>
7472
7473         * utils.h (free_current_contents): Don't declare.
7474         * utils.c (free_current_contents): Remove.
7475
7476 2019-03-06  Tom Tromey  <tom@tromey.com>
7477
7478         * top.c (quit_force): Update.
7479         * main.c (captured_command_loop): Update.
7480         * common/new-op.c (operator new): Update.
7481         * common/common-exceptions.c (struct catcher)
7482         <save_cleanup_chain>: Remove member.
7483         (exceptions_state_mc_init): Update.
7484         (exception_try_scope_entry): Return nullptr.
7485         (exception_try_scope_exit, exception_rethrow)
7486         (throw_exception_sjlj, throw_exception_cxx): Update.
7487         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7488         (all_cleanups, do_cleanups, discard_cleanups)
7489         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7490         (restore_cleanups, restore_final_cleanups): Don't declare.
7491         (do_final_cleanups): Remove parameter.
7492         * common/cleanups.c (cleanup_chain, make_cleanup)
7493         (make_cleanup_dtor, all_cleanups, do_cleanups)
7494         (discard_my_cleanups, discard_cleanups)
7495         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7496         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7497         (null_cleanup): Remove.
7498         (do_final_cleanups): Remove parameter.
7499
7500 2019-03-06  Tom Tromey  <tom@tromey.com>
7501
7502         * remote.c (remote_target::remote_parse_stop_reply): Use
7503         unique_xmalloc_ptr.
7504
7505 2019-03-06  Tom Tromey  <tom@tromey.com>
7506
7507         * stabsread.c (struct stabs_field_info): Rename from field_info.
7508         <list, fnlist>: Add initializers.
7509         <obstack>: New member.
7510         (read_member_functions, read_struct_fields, read_baseclasses):
7511         Allocate on obstack.  Don't use cleanups.
7512         (read_one_struct_field, read_member_functions, read_struct_fields)
7513         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7514         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7515         (read_struct_type): Update.
7516
7517 2019-03-06  Tom Tromey  <tom@tromey.com>
7518
7519         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7520         * common/filestuff.h (make_cleanup_close): Don't declare.
7521         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7522         Remove.
7523
7524 2019-03-06  Tom Tromey  <tom@tromey.com>
7525
7526         * solib-aix.c: Use make_scope_exit.
7527
7528 2019-03-06  Tom Tromey  <tom@tromey.com>
7529
7530         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7531         Use make_scope_exit.
7532
7533 2019-03-06  Tom Tromey  <tom@tromey.com>
7534
7535         * solib-svr4.c (disable_probes_interface): Remove parameter.
7536         (svr4_handle_solib_event): Use make_scope_exit.
7537
7538 2019-03-06  Tom Tromey  <tom@tromey.com>
7539
7540         * remote.c (struct stop_reply_deleter): Remove.
7541         (stop_reply_up): Update.
7542         (struct stop_reply): Derive from notif_event.  Don't typedef.
7543         <regcache>: Now a std::vector.
7544         (stop_reply_xfree): Remove.
7545         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7546         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7547         (remote_target::discard_pending_stop_replies): Use delete.
7548         (remote_target::remote_parse_stop_reply): Update.
7549         (remote_target::process_stop_reply): Update.
7550         * remote-notif.h (struct notif_event): Add virtual destructor.
7551         Remove "dtr" member.
7552         (struct notif_client) <alloc_event>: Return a unique_ptr.
7553         (notif_event_xfree): Don't declare.
7554         (notif_event_up): New typedef.
7555         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7556         (notif_event_xfree, do_notif_event_xfree): Remove.
7557         (remote_notif_state_xfree): Update.
7558
7559 2019-03-06  Tom Tromey  <tom@tromey.com>
7560
7561         * infrun.c (displaced_step_clear_cleanup): Now a
7562         forward_scope_exit type.
7563         (displaced_step_prepare_throw): Update.
7564         (displaced_step_fixup): Update.
7565
7566 2019-03-06  Tom Tromey  <tom@tromey.com>
7567
7568         * inferior.h (class inferior): Update comment.
7569         * gdbthread.h (class thread_info): Update comment.
7570
7571 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7572             Tom Tromey  <tom@tromey.com>
7573
7574         * stabsread.h (struct stab_section_list): Remove.
7575         (coffstab_build_psymtabs): Update.
7576         * dbxread.c (symbuf_sections): Now a std::vector.
7577         (sect_idx): New global.
7578         (fill_symbuf): Update.
7579         (coffstab_build_psymtabs): Change type of stabsects parameter.
7580         Update.
7581         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7582         std::vector.
7583         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7584         (coff_locate_sections): Update.
7585         (coff_symfile_read): Remove cleanups.  Update.
7586         (init_stringtab): Add storage parameter.
7587         (free_stringtab, free_stringtab_cleanup): Remove.
7588         (init_lineno): Add storage parameter.
7589         (free_linetab, free_linetab_cleanup): Remove.
7590
7591 2019-03-06  Pedro Alves  <palves@redhat.com>
7592
7593         * linux-fork.c (fork_info::clobber_regs): Delete.
7594         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7595         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7596         comment.  Adjust.
7597         (scoped_switch_fork_info::scoped_switch_fork_info)
7598         (checkpoint_command, linux_fork_context): Adjust
7599         fork_save_infrun_state calls.
7600
7601 2019-03-06  Pedro Alves  <palves@redhat.com>
7602
7603         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7604         (inf_has_multiple_threads): Return 'bool' and rewrite using
7605         inferior_info::threads().
7606
7607 2019-03-06  Pedro Alves  <palves@redhat.com>
7608
7609         * linux-fork.c: Include <list>.
7610         (fork_list): Now a std::list instance.
7611         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7612         (forks_exist_p, find_last_fork): Adjust.
7613         (new_fork): Delete.
7614         (one_fork_p): New.
7615         (add_fork): Adjust.
7616         (free_fork): Delete, folded into fork_info::~fork_info().
7617         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7618         Adjust.
7619         (init_fork_list): Delete.
7620         (linux_fork_killall, linux_fork_mourn_inferior)
7621         (linux_fork_detach, info_checkpoints_command): Adjust.
7622         (_initialize_linux_fork): No longer call init_fork_list.
7623
7624 2019-03-06  Pedro Alves  <palves@redhat.com>
7625
7626         * linux-fork.c (new_fork): New, split out of ...
7627         (add_fork): ... this.  Return void.  Move "first fork" special
7628         case from here, to ...
7629         (checkpoint_command): ... here.
7630         * linux-linux.h (add_fork): Return void.
7631
7632 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7633
7634         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7635
7636 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7637             Chris January  <chris.january@arm.com>
7638             David Lecomber  <david.lecomber@arm.com>
7639
7640         * f-exp.y: New token, UNOP_INTRINSIC.
7641         (exp): New pattern using UNOP_INTRINSIC token.
7642         (f77_keywords): Add 'abs' keyword.
7643         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7644         (value_from_host_double): New function.
7645         (evaluate_subexp_f): Support UNOP_ABS.
7646
7647 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7648
7649         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7650         types.
7651
7652 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7653
7654         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7655         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7656         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7657
7658 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7659
7660         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7661
7662 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7663             Chris January  <chris.january@arm.com>
7664
7665         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7666         * f-exp.y: Define 'KIND' token.
7667         (exp): New pattern for KIND expressions.
7668         (ptype): Handle types with a kind extension.
7669         (direct_abs_decl): Extend to spot kind extensions.
7670         (f77_keywords): Add 'kind' to the list.
7671         (push_kind_type): New function.
7672         (convert_to_kind_type): New function.
7673         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7674         * parse.c (operator_length_standard): Likewise.
7675         * parser-defs.h (enum type_pieces): Add tp_kind.
7676         * std-operator.def: Add UNOP_KIND.
7677
7678 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7679
7680         * f-exp.y (f_parse): Set yydebug.
7681
7682 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7683
7684         * f-lang.c (evaluate_subexp_f): New function.
7685         (exp_descriptor_f): New global.
7686         (f_language_defn): Use exp_descriptor_f instead of
7687         exp_descriptor_standard.
7688
7689 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7690
7691         * f-exp.y (struct token): Add comments.
7692         (dot_ops): Remove uppercase versions and the end marker.
7693         (f77_keywords): Likewise.
7694         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7695         entries in the dot_ops array are case insensitive, and use
7696         strncasecmp to compare strings.  Also some whitespace cleanup in
7697         this area.  Similar for the f77_keywords array, except entries in
7698         this list might be case sensitive.
7699
7700 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7701
7702         * f-exp.y (struct f77_boolean_val): Add comments.
7703         (boolean_values): Remove uppercase versions, and end marker.
7704         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7705         and use strncasecmp to achieve case insensitivity.  Additionally,
7706         perform whitespace cleanup around this code.
7707
7708 2019-03-06  Tom Tromey  <tromey@adacore.com>
7709
7710         * remote-sim.c (gdbsim_target_open): Use result of
7711         gdb_argv::release.
7712
7713 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7714         Dirk Schubert  <dirk.schubert@arm.com>
7715         Chris January  <chris.january@arm.com>
7716
7717         * eval.c (evaluate_subexp_standard): Call Fortran argument
7718         wrapping logic.
7719         * f-lang.c (struct value): A value which can be passed into a
7720         Fortran function call.
7721         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7722         where appropriate.
7723         (struct type): Value ready for a Fortran function call.
7724         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7725         is needed.
7726         * f-lang.h (fortran_argument_convert): Declaration.
7727         (fortran_preserve_arg_pointer): Declaration.
7728         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7729
7730 2019-03-05  Tom Tromey  <tromey@adacore.com>
7731
7732         * python/py-prettyprint.c (print_string_repr): Remove #if.
7733         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7734
7735 2019-03-05  Tom Tromey  <tromey@adacore.com>
7736
7737         * target.c (the_dummy_target): Move later.  Change type to
7738         "dummy_target".
7739         (initialize_targets): Don't initialize the_dummy_target.
7740
7741 2019-03-05  Tom Tromey  <tromey@adacore.com>
7742
7743         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7744         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7745
7746 2019-03-05  Tom Tromey  <tromey@adacore.com>
7747
7748         * windows-nat.c (windows_nat_target::attach)
7749         (windows_nat_target::detach): Don't call gdb_flush.
7750         * valprint.c (generic_val_print, val_print, val_print_string):
7751         Don't call gdb_flush.
7752         * utils.c (defaulted_query): Don't call gdb_flush.
7753         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7754         * target.c (target_announce_detach): Don't call gdb_flush.
7755         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7756         * remote.c (extended_remote_target::attach): Don't call
7757         gdb_flush.
7758         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7759         * printcmd.c (do_examine): Don't call gdb_flush.
7760         (info_display_command): Don't call gdb_flush.
7761         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7762         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7763         * memattr.c (info_mem_command): Don't call gdb_flush.
7764         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7765         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7766         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7767         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7768         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7769         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7770         (gnu_nat_target::detach): Don't call gdb_flush.
7771         * f-valprint.c (f_val_print): Don't call gdb_flush.
7772         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7773         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7774         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7775         gdb_flush.
7776         * c-valprint.c (c_val_print): Don't call gdb_flush.
7777         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7778
7779 2019-03-05  Tom Tromey  <tromey@adacore.com>
7780
7781         * varobj.c (update_dynamic_varobj_children): Update.
7782         (install_default_visualizer): Use reset, not release.
7783         * value.c (set_internalvar): Update.
7784         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7785         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7786         ATTRIBUTE_UNUSED_RESULT.
7787
7788 2019-03-05  Tom Tromey  <tromey@adacore.com>
7789
7790         * remote.c (class scoped_remote_fd) <release>: Add
7791         ATTRIBUTE_UNUSED_RESULT.
7792
7793 2019-03-05  Tom Tromey  <tromey@adacore.com>
7794
7795         * macroexp.c (struct macro_buffer) <release>: Add
7796         ATTRIBUTE_UNUSED_RESULT.
7797
7798 2019-03-05  Tom Tromey  <tromey@adacore.com>
7799
7800         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7801         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7802         ATTRIBUTE_UNUSED_RESULT.
7803
7804 2019-03-05  Tom Tromey  <tromey@adacore.com>
7805
7806         * common/scoped_fd.h (class scoped_fd) <release>: Add
7807         ATTRIBUTE_UNUSED_RESULT.
7808
7809 2019-03-05  Tom Tromey  <tromey@adacore.com>
7810
7811         * parser-defs.h (struct parser_state) <release>: Add
7812         ATTRIBUTE_UNUSED_RESULT.
7813
7814 2019-03-05  Tom Tromey  <tromey@adacore.com>
7815
7816         * utils.h (class gdb_argv) <release>: Add
7817         ATTRIBUTE_UNUSED_RESULT.
7818         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7819
7820 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7821
7822         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7823         for-loop range, to avoid compiler warnings.
7824
7825         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7826         avoid compiler warnings about unused variables.
7827
7828         * NEWS: Mention end of support for native debugging on MS-Windows
7829         before XP.
7830
7831         PR gdb/24292
7832         * common/netstuff.c:
7833         * gdbserver/gdbreplay.c
7834         * gdbserver/remote-utils.c:
7835         * ser-tcp.c:
7836         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7837         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7838         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7839         'getaddrinfo' and 'freeaddrinfo' were not available before
7840         Windows XP, and mingw.org's MinGW headers by default define
7841         _WIN32_WINNT to 0x500.
7842
7843 2019-03-01  Gary Benson <gbenson@redhat.com>
7844
7845         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7846
7847 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7848             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7849
7850         PR gdb/8527
7851         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7852         set_sigint_trap, clear_sigint_trap.
7853
7854 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7855
7856         * target.c (target_detach): Clear the regcache and the
7857         frame cache.
7858
7859 2019-02-27  Pedro Alves  <palves@redhat.com>
7860
7861         * utils.c (set_screen_size): When we cap the height/width sizes,
7862         tweak the corresponding command variable to show "unlimited":
7863
7864 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7865             Pedro Alves  <palves@redhat.com>
7866
7867         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7868         before calling rl_set_screen_size.
7869
7870 2019-02-27  Tom Tromey  <tromey@adacore.com>
7871
7872         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7873         define.
7874         * python/py-value.c: Remove Python 2.4 workaround.
7875         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7876         workaround.
7877         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7878         Python 2.4 workaround.
7879         * python/python-internal.h: Remove Python 2.4 comment.
7880         (Py_ssize_t): Don't define.
7881         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7882         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7883         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7884         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7885         * python/python.c (do_start_initialization): Remove Python 2.4
7886         workaround.
7887         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7888         (print_children): Remove Python 2.4 workaround.
7889         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7890         workaround.
7891         (CHARBUFFERPROC_NAME): Remove.
7892         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7893         Python 2.4 workaround.
7894
7895 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7896
7897         * NEWS: Note minimum Python version.
7898
7899 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7900
7901         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7902         code from these functions.  Remove corresponding ifdefs.  Use
7903         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7904         Remove gotos and target of gotos.
7905         (infpy_search_memory): Likewise.
7906
7907 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7908
7909         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7910         (hppa_gdbarch_init): Don't register deleted functions with
7911         gdbarch.
7912
7913 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7914
7915         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7916         (h8300_unwind_sp): Delete.
7917         (h8300_dummy_id): Delete.
7918         (h8300_gdbarch_init): Don't register deleted functions with
7919         gdbarch.
7920
7921 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7922
7923         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7924         (ft32_unwind_pc): Delete.
7925         (ft32_unwind_sp): Delete.
7926         (ft32_gdbarch_init): Don't register deleted functions with
7927         gdbarch.
7928
7929 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7930
7931         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7932         (frv_unwind_pc): Delete.
7933         (frv_unwind_sp): Delete.
7934         (frv_gdbarch_init): Don't register deleted functions with
7935         gdbarch.
7936
7937 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7938
7939         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7940         (riscv_unwind_pc): Delete.
7941         (riscv_unwind_sp): Delete.
7942         (riscv_gdbarch_init): Don't register deleted functions with
7943         gdbarch.
7944
7945 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7946
7947         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7948         (csky_unwind_pc): Delete.
7949         (csky_unwind_sp): Delete.
7950         (csky_gdbarch_init): Don't register deleted functions with
7951         gdbarch.
7952
7953 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7954
7955         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7956         (cris_unwind_pc): Delete.
7957         (cris_unwind_sp): Delete.
7958         (cris_gdbarch_init): Don't register deleted functions with
7959         gdbarch.
7960
7961 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7962
7963         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7964         (bfin_unwind_pc): Delete.
7965         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7966
7967 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7968
7969         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7970         (arm_unwind_pc): Delete.
7971         (arm_unwind_sp): Delete.
7972         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7973
7974 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7975
7976         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7977         (arc_unwind_pc): Delete.
7978         (arc_unwind_sp): Delete.
7979         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7980
7981 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7982
7983         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7984         (alpha_unwind_pc): Delete.
7985         (alpha_gdbarch_init): Don't register deleted functions with
7986         gdbarch.
7987
7988 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7989
7990         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7991         (aarch64_unwind_pc): Delete.
7992         (aarch64_unwind_sp): Delete.
7993         (aarch64_gdbarch_init): Don't register deleted functions with
7994         gdbarch.
7995
7996 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7997
7998         * gdbtypes.c (type_align): Don't consider static members when
7999         computing structure alignment.
8000
8001 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8002
8003         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8004         return 0 for other types.
8005         * arch-utils.c (default_type_align): Always return 0.
8006         * gdbarch.h: Regenerate.
8007         * gdbarch.sh (type_align): Extend comment.
8008         * gdbtypes.c (type_align): Add additional comments, always call
8009         gdbarch_type_align before applying the default rules.
8010         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8011         generic code will then apply a suitable default.
8012         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8013         types, return 0 for other types.
8014
8015 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8016
8017         * NEWS: Create a new section for the next release branch.
8018         Rename the section of the current branch, now that it has
8019         been cut.
8020
8021 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8022
8023         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8024         * version.in: Bump version to 8.3.50.DATE-git.
8025
8026 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8027
8028         * aix-thread.c (ptid_cmp): Remove unused variable.
8029         (get_signaled_thread): Likewise.
8030         (store_regs_user_thread): Likewise.
8031         (store_regs_kernel_thread): Likewise.
8032         (fetch_regs_kernel_thread): Remove shadowed variable.
8033
8034 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8035
8036         * features/riscv/32bit-cpu.xml: Add register numbers.
8037         * features/riscv/32bit-fpu.c: Regenerate.
8038         * features/riscv/32bit-fpu.xml: Add register numbers.
8039         * features/riscv/64bit-cpu.xml: Add register numbers.
8040         * features/riscv/64bit-fpu.c: Regenerate.
8041         * features/riscv/64bit-fpu.xml: Add register numbers.
8042
8043 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8044
8045         * NEWS: Mention two argument form of gdb.Value constructor.
8046         * python/py-value.c (convert_buffer_and_type_to_value): New
8047         function.
8048         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8049         Add support for handling an optional second argument.  Call
8050         convert_buffer_and_type_to_value as appropriate.
8051         * python/python-internal.h (Py_buffer_deleter): New struct.
8052         (Py_buffer_up): New typedef.
8053
8054 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8055
8056         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8057         instead of releasing ownership.
8058
8059 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8060
8061         * dwarf2read.c (open_and_init_dwp_file): Call
8062         elf_numsections instead of bfd_count_sections to initialize
8063         dwp_file->num_sections.
8064
8065 2019-02-25  Tom Tromey  <tromey@adacore.com>
8066
8067         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8068
8069 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8070
8071         * gcore.in: Add '--readnever' option when invoking GDB.
8072
8073 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8074
8075         * MAINTAINERS: Update my email address.
8076
8077 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8078
8079         * build-id.c (build_id_to_debug_bfd_1): New function.
8080         (build_id_to_debug_bfd): Look for separate debug file in
8081         sysroot.
8082
8083 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8084
8085         * gdbarch.sh: Update the copyright year range that is placed into
8086         generated files.
8087
8088 2019-02-22  Keith Seitz  <keiths@redhat.com>
8089
8090         PR symtab/23853
8091         * linespec.c (create_sals_line_offset): Search for the default
8092         symtab's filename instead of its fullname.
8093
8094 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8095
8096         * NEWS: Update style defaults.
8097
8098 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8099
8100         * main.c (captured_main_1): Disable styling in batch mode.
8101
8102 2019-02-20  Tom Tromey  <tom@tromey.com>
8103
8104         * symtab.c (symtab_symbol_info): Fix typos.
8105
8106 2019-02-20  Tom Tromey  <tromey@adacore.com>
8107
8108         * findcmd.c (_initialize_mem_search): Use upper case for
8109         metasyntactic variables.
8110
8111 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8112
8113         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8114         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8115
8116 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8117
8118         * top.h (source_file_name): Change to std::string.
8119         * top.c (source_file_name): Likewise.
8120         (command_line_input): Adjust.
8121         * cli/cli-script.c (script_from_file): Adjust.
8122
8123 2019-02-19  Tom Tromey  <tromey@adacore.com>
8124
8125         * ravenscar-thread.c
8126         (ravenscar_thread_target::update_thread_list): Don't call
8127         ada_build_task_list.
8128         * ada-lang.h (ada_build_task_list): Don't declare.
8129         * ada-tasks.c (struct ada_tasks_inferior_data)
8130         <task_list_valid_p>: Now bool.
8131         (read_known_tasks, ada_task_list_changed)
8132         (ada_tasks_invalidate_inferior_data): Update.
8133         (read_known_tasks_array): Return bool.
8134         (read_known_tasks_list): Likewise.
8135         (read_known_tasks): Return void.
8136         (ada_build_task_list): Now static.
8137
8138 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8139
8140         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8141         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8142
8143 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8144
8145         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8146         variant for ada_tasks_pspace_data_handle and
8147         ada_tasks_inferior_data_handle.
8148         (ada_tasks_pspace_data_cleanup): New function.
8149         (ada_tasks_inferior_data_cleanup): New function.
8150
8151 2019-02-17  Tom Tromey  <tom@tromey.com>
8152
8153         * macrotab.h (macro_source_fullname): Return a std::string.
8154         * macrotab.c (macro_include, check_for_redefinition)
8155         (macro_undef, macro_lookup_definition, foreach_macro)
8156         (foreach_macro_in_scope): Update.
8157         (macro_source_fullname): Return a std::string.
8158         * macrocmd.c (show_pp_source_pos): Update.
8159
8160 2019-02-17  Tom Tromey  <tom@tromey.com>
8161
8162         * macrocmd.c (show_pp_source_pos): Style the file names.
8163
8164 2019-02-17  Tom Tromey  <tom@tromey.com>
8165
8166         PR tui/24197:
8167         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8168
8169 2019-02-17  Tom Tromey  <tom@tromey.com>
8170
8171         * ada-lang.c (user_select_syms): Use filtered printing.
8172         * utils.c (wrap_style): New global.
8173         (desired_style): Remove.
8174         (emit_style_escape): Add stream parameter.
8175         (set_output_style, reset_terminal_style, prompt_for_continue):
8176         Update.
8177         (flush_wrap_buffer): Only flush gdb_stdout.
8178         (wrap_here): Set wrap_style.
8179         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8180         treat escape sequences as a character.  Change when wrap buffer is
8181         flushed.
8182         (fputs_styled): Do not set the output style when the default is
8183         requested.
8184         * ui-style.h (struct ui_file_style) <is_default>: New method.
8185         * source.c (print_source_lines_base): Emit escape sequences in one
8186         piece.
8187
8188 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8189
8190         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8191         integers and enumeration types.
8192
8193 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8194
8195         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8196         instead of lookup_symbol_in_language
8197         (do_exact_match): New function.
8198         (ada_get_symbol_name_matcher): Return do_exact_match when
8199         doing a verbatim match.
8200
8201 2019-02-15  Tom Tromey  <tromey@adacore.com>
8202
8203         * ravenscar-thread.c (ravenscar_thread_target::resume)
8204         (ravenscar_thread_target::wait): Special case wildcard requests.
8205
8206 2019-02-15  Tom Tromey  <tromey@adacore.com>
8207
8208         * ravenscar-thread.c (base_ptid): Remove.
8209         (struct ravenscar_thread_target) <close>: New method.
8210         <m_base_ptid>: New member.
8211         <update_inferior_ptid, active_task, task_is_currently_active,
8212         runtime_initialized>: Declare methods.
8213         <ravenscar_thread_target>: Add constructor.
8214         (ravenscar_thread_target::task_is_currently_active)
8215         (ravenscar_thread_target::update_inferior_ptid)
8216         (ravenscar_runtime_initialized): Rename.  Now methods.
8217         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8218         (ravenscar_thread_target::update_thread_list): Update.
8219         (ravenscar_thread_target::active_task): Now method.
8220         (ravenscar_thread_target::store_registers)
8221         (ravenscar_thread_target::prepare_to_store)
8222         (ravenscar_thread_target::prepare_to_store)
8223         (ravenscar_thread_target::mourn_inferior): Update.
8224         (ravenscar_inferior_created): Use "new" to create target.
8225         (ravenscar_thread_target::get_ada_task_ptid): Update.
8226         (_initialize_ravenscar): Don't initialize base_ptid.
8227         (ravenscar_ops): Remove global.
8228
8229 2019-02-15  Tom Tromey  <tromey@adacore.com>
8230
8231         * target.h (push_target): Declare new overload.
8232         * target.c (push_target): New overload, taking an rvalue reference.
8233         * remote.c (remote_target::open_1): Use push_target overload.
8234         * corelow.c (core_target_open): Use push_target overload.
8235
8236 2019-02-15  Tom Tromey  <tromey@adacore.com>
8237
8238         * ravenscar-thread.c (is_ravenscar_task)
8239         (ravenscar_task_is_currently_active): Return bool.
8240         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8241         (_initialize_ravenscar): Remove "(void)".
8242         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8243         Return bool.
8244
8245 2019-02-15  Tom Tromey  <tromey@adacore.com>
8246
8247         * ravenscar-thread.c (ravenscar_runtime_initializer)
8248         (has_ravenscar_runtime, get_running_thread_id)
8249         (ravenscar_thread_target::resume): Fix indentation.
8250
8251 2019-02-15  Tom Tromey  <tromey@adacore.com>
8252
8253         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8254         from ravenscar_arch_ops.
8255         (sparc_ravenscar_ops::fetch_registers)
8256         (sparc_ravenscar_ops::store_registers): Now methods.
8257         (sparc_ravenscar_prepare_to_store): Remove.
8258         (sparc_ravenscar_ops): Redefine.
8259         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8260         methods and destructor.  Remove members.
8261         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8262         (ravenscar_thread_target::store_registers)
8263         (ravenscar_thread_target::prepare_to_store): Update.
8264         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8265         Remove.
8266         (struct ppc_ravenscar_powerpc_ops): Derive from
8267         ravenscar_arch_ops.
8268         (ppc_ravenscar_powerpc_ops::fetch_registers)
8269         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8270         (ppc_ravenscar_powerpc_ops): Redefine.
8271         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8272         (ppc_ravenscar_e500_ops::fetch_registers)
8273         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8274         (ppc_ravenscar_e500_ops): Redefine.
8275         * aarch64-ravenscar-thread.c
8276         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8277         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8278         (aarch64_ravenscar_fetch_registers)
8279         (aarch64_ravenscar_store_registers): Now methods.
8280         (aarch64_ravenscar_ops): Redefine.
8281
8282 2019-02-15  Tom Tromey  <tromey@adacore.com>
8283
8284         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8285         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8286         (ravenscar_thread_target::stopped_by_watchpoint)
8287         (ravenscar_thread_target::stopped_data_address)
8288         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8289
8290 2019-02-15  Tom Tromey  <tromey@adacore.com>
8291
8292         * ravenscar-thread.c: Fix some typos.
8293
8294 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8295             Tom Tromey  <tromey@adacore.com>
8296
8297         * ada-lang.c (ada_exception_sal): Change addr_string to a
8298         std::string.
8299         (create_ada_exception_catchpoint): Update.
8300
8301 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8302             Tom Tromey  <tromey@adacore.com>
8303
8304         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8305         (bp_location_ops): Remove.
8306         (base_breakpoint_allocate_location): Update.
8307         (free_bp_location): Update.
8308         * ada-lang.c (class ada_catchpoint_location)
8309         <ada_catchpoint_location>: Remove ops parameter.
8310         (ada_catchpoint_location_dtor): Remove.
8311         (ada_catchpoint_location_ops): Remove.
8312         (allocate_location_exception): Update.
8313         * breakpoint.h (struct bp_location_ops): Remove.
8314         (class bp_location) <bp_location>: Remove bp_location_ops
8315         parameter.
8316         <~bp_location>: Add destructor.
8317         <ops>: Remove.
8318
8319 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8320             Pedro Alves  <palves@redhat.com>
8321
8322         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8323         'PATH_MAX'.
8324
8325 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8326             Samuel Thibault  <samuel.thibault@gnu.org>
8327             Thomas Schwinge  <thomas@codesourcery.com>
8328
8329         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8330         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8331
8332 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8333
8334         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8335         (check_empty): Use "const char *".
8336
8337         * gnu-nat.c (gnu_nat_target::detach): Instead of
8338         'detach_inferior (pid)' call
8339         'detach_inferior (find_inferior_pid (pid))'.
8340
8341         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8342         'nat/fork-inferior.o'.
8343         * gnu-nat.c: #include "nat/fork-inferior.h".
8344
8345         * gnu-nat.c (gnu_nat_target::detach): Instead of
8346         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8347         * gnu-nat.h: #include "inf-child.h".
8348         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8349         'i386_gnu_nat_target::fetch_registers'.
8350         (gnu_store_registers): Rename/move to
8351         'i386_gnu_nat_target::store_registers'.
8352
8353         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8354         * gnu-nat.h (mach_thread_info): New function.
8355         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8356
8357         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8358
8359 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8360
8361         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8362
8363 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8364
8365         * windows-nat.c (windows_add_thread): Add new parameter
8366         "main_thread_p" with default value set to false.  Update
8367         function documentation as well as all callers.
8368         (windows_delete_thread): Likewise.
8369         (fake_create_process): Update call to windows_add_thread.
8370         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8371         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8372         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8373         call to windows_delete_thread.
8374
8375 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8376
8377         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8378
8379 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8380
8381         * symfile.c (find_separate_debug_file): Use canonical path of
8382         sysroot with child_path instead of gdb_sysroot if it is valid.
8383
8384 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8385
8386         * symfile.c (find_separate_debug_file): Use child_path to
8387         determine if an object file is under a sysroot.
8388
8389 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8390
8391         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8392         unittests/child-path-selftests.c.
8393         * common/pathstuff.c (child_path): New function.
8394         * common/pathstuff.h (child_path): New prototype.
8395         * unittests/child-path-selftests.c: New file.
8396
8397 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8398
8399         * symfile.c (find_separate_debug_file): Look for separate debug
8400         files in debug directories under the sysroot.
8401
8402 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8403
8404         * symtab.h (struct minimal_symbol data_p): New const method.
8405         (struct minimal_symbol text_p): Likewise.
8406         * symtab.c (output_source_filename): Use file name style
8407         to print file name.
8408         (print_symbol_info): Likewise.
8409         (print_msymbol_info): Use address style to print addresses.
8410         Use function name style to print executable text symbols.
8411         (expand_symtab_containing_pc): Use data_p.
8412         (find_pc_sect_compunit_symtab): Likewise.
8413
8414 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8415
8416         * breakpoint.c (describe_other_breakpoints): Use address style
8417         to print addresses.
8418         (say_where): Likewise.
8419
8420 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8421
8422         * ada-typeprint.c (print_func_type): Print function name
8423         style to print function name.
8424         * c-typeprint.c (c_print_type_1): Likewise.
8425
8426 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8427
8428         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8429         for execve.
8430
8431 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8432
8433         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8434         type_stack.
8435
8436 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8437
8438         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8439         TYPE_CODE_REF types.
8440
8441 2019-02-08  Jim Wilson  <jimw@sifive.com>
8442
8443         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8444         (riscv_linux_fregset): New.
8445         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8446
8447 2019-02-07  Tom Tromey  <tom@tromey.com>
8448
8449         * thread.c (thread_cancel_execution_command): Update.
8450         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8451         methods.
8452         (struct thread_fsm_ops): Remove.
8453         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8454         (thread_fsm_should_stop, thread_fsm_return_value)
8455         (thread_fsm_set_finished, thread_fsm_finished_p)
8456         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8457         Don't declare.
8458         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8459         * infrun.c (clear_proceed_status_thread)
8460         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8461         (print_stop_event): Update.
8462         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8463         Add constructor.
8464         (step_command_fsm_ops): Remove.
8465         (new_step_command_fsm): Remove.
8466         (step_1): Update.
8467         (step_command_fsm::should_stop): Rename from
8468         step_command_fsm_should_stop.
8469         (step_command_fsm::clean_up): Rename from
8470         step_command_fsm_clean_up.
8471         (step_command_fsm::do_async_reply_reason): Rename from
8472         step_command_fsm_async_reply_reason.
8473         (struct until_next_fsm): Inherit from thread_fsm.  Add
8474         constructor.
8475         (until_next_fsm_ops): Remove.
8476         (new_until_next_fsm): Remove.
8477         (until_next_fsm::should_stop): Rename from
8478         until_next_fsm_should_stop.
8479         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8480         (until_next_fsm::do_async_reply_reason): Rename from
8481         until_next_fsm_async_reply_reason.
8482         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8483         constructor.  Change type of breakpoint.
8484         (finish_command_fsm_ops): Remove.
8485         (new_finish_command_fsm): Remove.
8486         (finish_command_fsm::should_stop): Rename from
8487         finish_command_fsm_should_stop.
8488         (finish_command_fsm::clean_up): Rename from
8489         finish_command_fsm_clean_up.
8490         (finish_command_fsm::return_value): Rename from
8491         finish_command_fsm_return_value.
8492         (finish_command_fsm::do_async_reply_reason): Rename from
8493         finish_command_fsm_async_reply_reason.
8494         (finish_command): Update.
8495         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8496         Add constructor.
8497         (call_thread_fsm_ops): Remove.
8498         (call_thread_fsm::call_thread_fsm): Rename from
8499         new_call_thread_fsm.
8500         (call_thread_fsm::should_stop): Rename from
8501         call_thread_fsm_should_stop.
8502         (call_thread_fsm::should_notify_stop): Rename from
8503         call_thread_fsm_should_notify_stop.
8504         (run_inferior_call, call_function_by_hand_dummy): Update.
8505         * cli/cli-interp.c (should_print_stop_to_console): Update.
8506         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8507         Add constructor.  Change type of location_breakpoint,
8508         caller_breakpoint.
8509         (until_break_fsm_ops): Remove.
8510         (new_until_break_fsm): Remove.
8511         (until_break_fsm::should_stop): Rename from
8512         until_break_fsm_should_stop.
8513         (until_break_fsm::clean_up): Rename from
8514         until_break_fsm_clean_up.
8515         (until_break_fsm::do_async_reply_reason): Rename from
8516         until_break_fsm_async_reply_reason.
8517         (until_break_command): Update.
8518         * thread-fsm.c: Remove.
8519         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8520
8521 2019-02-07  Tom Tromey  <tom@tromey.com>
8522
8523         * yy-remap.h: Add include guard.
8524         * xtensa-tdep.h: Add include guard.
8525         * xcoffread.h: Rename include guard.
8526         * varobj-iter.h: Add include guard.
8527         * tui/tui.h: Rename include guard.
8528         * tui/tui-winsource.h: Rename include guard.
8529         * tui/tui-wingeneral.h: Rename include guard.
8530         * tui/tui-windata.h: Rename include guard.
8531         * tui/tui-win.h: Rename include guard.
8532         * tui/tui-stack.h: Rename include guard.
8533         * tui/tui-source.h: Rename include guard.
8534         * tui/tui-regs.h: Rename include guard.
8535         * tui/tui-out.h: Rename include guard.
8536         * tui/tui-layout.h: Rename include guard.
8537         * tui/tui-io.h: Rename include guard.
8538         * tui/tui-hooks.h: Rename include guard.
8539         * tui/tui-file.h: Rename include guard.
8540         * tui/tui-disasm.h: Rename include guard.
8541         * tui/tui-data.h: Rename include guard.
8542         * tui/tui-command.h: Rename include guard.
8543         * tic6x-tdep.h: Add include guard.
8544         * target/waitstatus.h: Rename include guard.
8545         * target/wait.h: Rename include guard.
8546         * target/target.h: Rename include guard.
8547         * target/resume.h: Rename include guard.
8548         * target-float.h: Rename include guard.
8549         * stabsread.h: Add include guard.
8550         * rs6000-tdep.h: Add include guard.
8551         * riscv-fbsd-tdep.h: Add include guard.
8552         * regformats/regdef.h: Rename include guard.
8553         * record.h: Rename include guard.
8554         * python/python.h: Rename include guard.
8555         * python/python-internal.h: Rename include guard.
8556         * python/py-stopevent.h: Rename include guard.
8557         * python/py-ref.h: Rename include guard.
8558         * python/py-record.h: Rename include guard.
8559         * python/py-record-full.h: Rename include guard.
8560         * python/py-record-btrace.h: Rename include guard.
8561         * python/py-instruction.h: Rename include guard.
8562         * python/py-events.h: Rename include guard.
8563         * python/py-event.h: Rename include guard.
8564         * procfs.h: Add include guard.
8565         * proc-utils.h: Add include guard.
8566         * p-lang.h: Add include guard.
8567         * or1k-tdep.h: Rename include guard.
8568         * observable.h: Rename include guard.
8569         * nto-tdep.h: Rename include guard.
8570         * nat/x86-linux.h: Rename include guard.
8571         * nat/x86-linux-dregs.h: Rename include guard.
8572         * nat/x86-gcc-cpuid.h: Add include guard.
8573         * nat/x86-dregs.h: Rename include guard.
8574         * nat/x86-cpuid.h: Rename include guard.
8575         * nat/ppc-linux.h: Rename include guard.
8576         * nat/mips-linux-watch.h: Rename include guard.
8577         * nat/linux-waitpid.h: Rename include guard.
8578         * nat/linux-ptrace.h: Rename include guard.
8579         * nat/linux-procfs.h: Rename include guard.
8580         * nat/linux-osdata.h: Rename include guard.
8581         * nat/linux-nat.h: Rename include guard.
8582         * nat/linux-namespaces.h: Rename include guard.
8583         * nat/linux-btrace.h: Rename include guard.
8584         * nat/glibc_thread_db.h: Rename include guard.
8585         * nat/gdb_thread_db.h: Rename include guard.
8586         * nat/gdb_ptrace.h: Rename include guard.
8587         * nat/fork-inferior.h: Rename include guard.
8588         * nat/amd64-linux-siginfo.h: Rename include guard.
8589         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8590         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8591         * nat/aarch64-linux.h: Rename include guard.
8592         * nat/aarch64-linux-hw-point.h: Rename include guard.
8593         * mn10300-tdep.h: Add include guard.
8594         * mips-linux-tdep.h: Add include guard.
8595         * mi/mi-parse.h: Rename include guard.
8596         * mi/mi-out.h: Rename include guard.
8597         * mi/mi-main.h: Rename include guard.
8598         * mi/mi-interp.h: Rename include guard.
8599         * mi/mi-getopt.h: Rename include guard.
8600         * mi/mi-console.h: Rename include guard.
8601         * mi/mi-common.h: Rename include guard.
8602         * mi/mi-cmds.h: Rename include guard.
8603         * mi/mi-cmd-break.h: Rename include guard.
8604         * m2-lang.h: Add include guard.
8605         * location.h: Rename include guard.
8606         * linux-record.h: Rename include guard.
8607         * linux-nat.h: Add include guard.
8608         * linux-fork.h: Add include guard.
8609         * i386-darwin-tdep.h: Rename include guard.
8610         * hppa-linux-offsets.h: Add include guard.
8611         * guile/guile.h: Rename include guard.
8612         * guile/guile-internal.h: Rename include guard.
8613         * gnu-nat.h: Rename include guard.
8614         * gdb-stabs.h: Rename include guard.
8615         * frv-tdep.h: Add include guard.
8616         * f-lang.h: Add include guard.
8617         * event-loop.h: Add include guard.
8618         * darwin-nat.h: Rename include guard.
8619         * cp-abi.h: Rename include guard.
8620         * config/sparc/nm-sol2.h: Rename include guard.
8621         * config/nm-nto.h: Rename include guard.
8622         * config/nm-linux.h: Add include guard.
8623         * config/i386/nm-i386gnu.h: Rename include guard.
8624         * config/djgpp/nl_types.h: Rename include guard.
8625         * config/djgpp/langinfo.h: Rename include guard.
8626         * compile/gcc-cp-plugin.h: Add include guard.
8627         * compile/gcc-c-plugin.h: Add include guard.
8628         * compile/compile.h: Rename include guard.
8629         * compile/compile-object-run.h: Rename include guard.
8630         * compile/compile-object-load.h: Rename include guard.
8631         * compile/compile-internal.h: Rename include guard.
8632         * compile/compile-cplus.h: Rename include guard.
8633         * compile/compile-c.h: Rename include guard.
8634         * common/xml-utils.h: Rename include guard.
8635         * common/x86-xstate.h: Rename include guard.
8636         * common/version.h: Rename include guard.
8637         * common/vec.h: Rename include guard.
8638         * common/tdesc.h: Rename include guard.
8639         * common/selftest.h: Rename include guard.
8640         * common/scoped_restore.h: Rename include guard.
8641         * common/scoped_mmap.h: Rename include guard.
8642         * common/scoped_fd.h: Rename include guard.
8643         * common/safe-iterator.h: Rename include guard.
8644         * common/run-time-clock.h: Rename include guard.
8645         * common/refcounted-object.h: Rename include guard.
8646         * common/queue.h: Rename include guard.
8647         * common/ptid.h: Rename include guard.
8648         * common/print-utils.h: Rename include guard.
8649         * common/preprocessor.h: Rename include guard.
8650         * common/pathstuff.h: Rename include guard.
8651         * common/observable.h: Rename include guard.
8652         * common/netstuff.h: Rename include guard.
8653         * common/job-control.h: Rename include guard.
8654         * common/host-defs.h: Rename include guard.
8655         * common/gdb_wait.h: Rename include guard.
8656         * common/gdb_vecs.h: Rename include guard.
8657         * common/gdb_unlinker.h: Rename include guard.
8658         * common/gdb_unique_ptr.h: Rename include guard.
8659         * common/gdb_tilde_expand.h: Rename include guard.
8660         * common/gdb_sys_time.h: Rename include guard.
8661         * common/gdb_string_view.h: Rename include guard.
8662         * common/gdb_splay_tree.h: Rename include guard.
8663         * common/gdb_setjmp.h: Rename include guard.
8664         * common/gdb_ref_ptr.h: Rename include guard.
8665         * common/gdb_optional.h: Rename include guard.
8666         * common/gdb_locale.h: Rename include guard.
8667         * common/gdb_assert.h: Rename include guard.
8668         * common/filtered-iterator.h: Rename include guard.
8669         * common/filestuff.h: Rename include guard.
8670         * common/fileio.h: Rename include guard.
8671         * common/environ.h: Rename include guard.
8672         * common/common-utils.h: Rename include guard.
8673         * common/common-types.h: Rename include guard.
8674         * common/common-regcache.h: Rename include guard.
8675         * common/common-inferior.h: Rename include guard.
8676         * common/common-gdbthread.h: Rename include guard.
8677         * common/common-exceptions.h: Rename include guard.
8678         * common/common-defs.h: Rename include guard.
8679         * common/common-debug.h: Rename include guard.
8680         * common/cleanups.h: Rename include guard.
8681         * common/buffer.h: Rename include guard.
8682         * common/btrace-common.h: Rename include guard.
8683         * common/break-common.h: Rename include guard.
8684         * cli/cli-utils.h: Rename include guard.
8685         * cli/cli-style.h: Rename include guard.
8686         * cli/cli-setshow.h: Rename include guard.
8687         * cli/cli-script.h: Rename include guard.
8688         * cli/cli-interp.h: Rename include guard.
8689         * cli/cli-decode.h: Rename include guard.
8690         * cli/cli-cmds.h: Rename include guard.
8691         * charset-list.h: Add include guard.
8692         * buildsym-legacy.h: Rename include guard.
8693         * bfin-tdep.h: Add include guard.
8694         * ax.h: Rename include guard.
8695         * arm-linux-tdep.h: Add include guard.
8696         * arm-fbsd-tdep.h: Add include guard.
8697         * arch/xtensa.h: Rename include guard.
8698         * arch/tic6x.h: Add include guard.
8699         * arch/i386.h: Add include guard.
8700         * arch/arm.h: Rename include guard.
8701         * arch/arm-linux.h: Rename include guard.
8702         * arch/arm-get-next-pcs.h: Rename include guard.
8703         * arch/amd64.h: Add include guard.
8704         * arch/aarch64-insn.h: Rename include guard.
8705         * arch-utils.h: Rename include guard.
8706         * annotate.h: Add include guard.
8707         * amd64-darwin-tdep.h: Rename include guard.
8708         * aarch64-linux-tdep.h: Add include guard.
8709         * aarch64-fbsd-tdep.h: Add include guard.
8710         * aarch32-linux-nat.h: Add include guard.
8711
8712 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8713
8714         * macrotab.c (macro_define_internal): New function that
8715         factorizes macro_define_object_internal and macro_define_function
8716         code.
8717         (macro_define_object_internal): Use macro_define_internal.
8718         (macro_define_function): Likewise.
8719
8720 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8721
8722         * macrocmd.c (extract_identifier): Return
8723         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8724         callers.
8725
8726 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8727
8728         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8729
8730 2019-02-05  Tom Tromey  <tom@tromey.com>
8731
8732         * target.c (target_stack::unpush): Move assertion earlier.
8733
8734 2019-01-30  Tom Tromey  <tom@tromey.com>
8735
8736         PR python/23615:
8737         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8738         (gdbpy_parse_and_eval): Likewise.
8739         * python/python-internal.h (gdbpy_allow_threads): New class.
8740
8741 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8742
8743         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8744         (aarch64_fbsd_fpregmap): Move earlier.
8745         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8746         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8747         instead of individual calls to trad_frame_set_reg_addr.
8748         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8749         earlier.
8750         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8751         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8752         instead of individual calls to trad_frame_set_reg_addr.
8753
8754 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8755
8756         * CONTRIBUTE: Replace contribution list with wiki link.
8757
8758 2019-01-25  Tom Tromey  <tom@tromey.com>
8759
8760         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8761
8762 2019-01-25  Tom Tromey  <tom@tromey.com>
8763
8764         * xtensa-linux-nat.c: Fix common/ includes.
8765         * xml-support.h: Fix common/ includes.
8766         * xml-support.c: Fix common/ includes.
8767         * x86-linux-nat.c: Fix common/ includes.
8768         * windows-nat.c: Fix common/ includes.
8769         * varobj.h: Fix common/ includes.
8770         * varobj.c: Fix common/ includes.
8771         * value.c: Fix common/ includes.
8772         * valops.c: Fix common/ includes.
8773         * utils.c: Fix common/ includes.
8774         * unittests/xml-utils-selftests.c: Fix common/ includes.
8775         * unittests/utils-selftests.c: Fix common/ includes.
8776         * unittests/unpack-selftests.c: Fix common/ includes.
8777         * unittests/tracepoint-selftests.c: Fix common/ includes.
8778         * unittests/style-selftests.c: Fix common/ includes.
8779         * unittests/string_view-selftests.c: Fix common/ includes.
8780         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8781         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8782         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8783         * unittests/rsp-low-selftests.c: Fix common/ includes.
8784         * unittests/parse-connection-spec-selftests.c: Fix common/
8785         includes.
8786         * unittests/optional-selftests.c: Fix common/ includes.
8787         * unittests/offset-type-selftests.c: Fix common/ includes.
8788         * unittests/observable-selftests.c: Fix common/ includes.
8789         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8790         * unittests/memrange-selftests.c: Fix common/ includes.
8791         * unittests/memory-map-selftests.c: Fix common/ includes.
8792         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8793         * unittests/function-view-selftests.c: Fix common/ includes.
8794         * unittests/environ-selftests.c: Fix common/ includes.
8795         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8796         * unittests/common-utils-selftests.c: Fix common/ includes.
8797         * unittests/cli-utils-selftests.c: Fix common/ includes.
8798         * unittests/array-view-selftests.c: Fix common/ includes.
8799         * ui-file.c: Fix common/ includes.
8800         * tui/tui-io.c: Fix common/ includes.
8801         * tracepoint.h: Fix common/ includes.
8802         * tracepoint.c: Fix common/ includes.
8803         * tracefile-tfile.c: Fix common/ includes.
8804         * top.h: Fix common/ includes.
8805         * top.c: Fix common/ includes.
8806         * thread.c: Fix common/ includes.
8807         * target/waitstatus.h: Fix common/ includes.
8808         * target/waitstatus.c: Fix common/ includes.
8809         * target.h: Fix common/ includes.
8810         * target.c: Fix common/ includes.
8811         * target-memory.c: Fix common/ includes.
8812         * target-descriptions.c: Fix common/ includes.
8813         * symtab.h: Fix common/ includes.
8814         * symfile.c: Fix common/ includes.
8815         * stap-probe.c: Fix common/ includes.
8816         * spu-linux-nat.c: Fix common/ includes.
8817         * sparc-nat.c: Fix common/ includes.
8818         * source.c: Fix common/ includes.
8819         * solib.c: Fix common/ includes.
8820         * solib-target.c: Fix common/ includes.
8821         * ser-unix.c: Fix common/ includes.
8822         * ser-tcp.c: Fix common/ includes.
8823         * ser-pipe.c: Fix common/ includes.
8824         * ser-base.c: Fix common/ includes.
8825         * selftest-arch.c: Fix common/ includes.
8826         * s12z-tdep.c: Fix common/ includes.
8827         * rust-exp.y: Fix common/ includes.
8828         * rs6000-aix-tdep.c: Fix common/ includes.
8829         * riscv-tdep.c: Fix common/ includes.
8830         * remote.c: Fix common/ includes.
8831         * remote-notif.h: Fix common/ includes.
8832         * remote-fileio.h: Fix common/ includes.
8833         * remote-fileio.c: Fix common/ includes.
8834         * regcache.h: Fix common/ includes.
8835         * regcache.c: Fix common/ includes.
8836         * record-btrace.c: Fix common/ includes.
8837         * python/python.c: Fix common/ includes.
8838         * python/py-type.c: Fix common/ includes.
8839         * python/py-inferior.c: Fix common/ includes.
8840         * progspace.h: Fix common/ includes.
8841         * producer.c: Fix common/ includes.
8842         * procfs.c: Fix common/ includes.
8843         * proc-api.c: Fix common/ includes.
8844         * printcmd.c: Fix common/ includes.
8845         * ppc-linux-nat.c: Fix common/ includes.
8846         * parser-defs.h: Fix common/ includes.
8847         * osdata.c: Fix common/ includes.
8848         * obsd-nat.c: Fix common/ includes.
8849         * nat/x86-linux.c: Fix common/ includes.
8850         * nat/x86-linux-dregs.c: Fix common/ includes.
8851         * nat/x86-dregs.h: Fix common/ includes.
8852         * nat/x86-dregs.c: Fix common/ includes.
8853         * nat/ppc-linux.c: Fix common/ includes.
8854         * nat/mips-linux-watch.h: Fix common/ includes.
8855         * nat/mips-linux-watch.c: Fix common/ includes.
8856         * nat/linux-waitpid.c: Fix common/ includes.
8857         * nat/linux-ptrace.h: Fix common/ includes.
8858         * nat/linux-ptrace.c: Fix common/ includes.
8859         * nat/linux-procfs.c: Fix common/ includes.
8860         * nat/linux-personality.c: Fix common/ includes.
8861         * nat/linux-osdata.c: Fix common/ includes.
8862         * nat/linux-namespaces.c: Fix common/ includes.
8863         * nat/linux-btrace.h: Fix common/ includes.
8864         * nat/linux-btrace.c: Fix common/ includes.
8865         * nat/fork-inferior.c: Fix common/ includes.
8866         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8867         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8868         * nat/aarch64-linux.c: Fix common/ includes.
8869         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8870         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8871         * namespace.h: Fix common/ includes.
8872         * mips-linux-tdep.c: Fix common/ includes.
8873         * minsyms.c: Fix common/ includes.
8874         * mi/mi-parse.h: Fix common/ includes.
8875         * mi/mi-main.c: Fix common/ includes.
8876         * mi/mi-cmd-env.c: Fix common/ includes.
8877         * memrange.h: Fix common/ includes.
8878         * memattr.c: Fix common/ includes.
8879         * maint.h: Fix common/ includes.
8880         * maint.c: Fix common/ includes.
8881         * main.c: Fix common/ includes.
8882         * machoread.c: Fix common/ includes.
8883         * location.c: Fix common/ includes.
8884         * linux-thread-db.c: Fix common/ includes.
8885         * linux-nat.c: Fix common/ includes.
8886         * linux-fork.c: Fix common/ includes.
8887         * inline-frame.c: Fix common/ includes.
8888         * infrun.c: Fix common/ includes.
8889         * inflow.c: Fix common/ includes.
8890         * inferior.h: Fix common/ includes.
8891         * inferior.c: Fix common/ includes.
8892         * infcmd.c: Fix common/ includes.
8893         * inf-ptrace.c: Fix common/ includes.
8894         * inf-child.c: Fix common/ includes.
8895         * ia64-linux-nat.c: Fix common/ includes.
8896         * i387-tdep.c: Fix common/ includes.
8897         * i386-tdep.c: Fix common/ includes.
8898         * i386-linux-tdep.c: Fix common/ includes.
8899         * i386-linux-nat.c: Fix common/ includes.
8900         * i386-go32-tdep.c: Fix common/ includes.
8901         * i386-fbsd-tdep.c: Fix common/ includes.
8902         * i386-fbsd-nat.c: Fix common/ includes.
8903         * guile/scm-type.c: Fix common/ includes.
8904         * guile/guile.c: Fix common/ includes.
8905         * go32-nat.c: Fix common/ includes.
8906         * gnu-nat.c: Fix common/ includes.
8907         * gdbthread.h: Fix common/ includes.
8908         * gdbarch-selftests.c: Fix common/ includes.
8909         * gdb_usleep.c: Fix common/ includes.
8910         * gdb_select.h: Fix common/ includes.
8911         * gdb_bfd.c: Fix common/ includes.
8912         * gcore.c: Fix common/ includes.
8913         * fork-child.c: Fix common/ includes.
8914         * findvar.c: Fix common/ includes.
8915         * fbsd-nat.c: Fix common/ includes.
8916         * event-top.c: Fix common/ includes.
8917         * event-loop.c: Fix common/ includes.
8918         * dwarf2read.c: Fix common/ includes.
8919         * dwarf2loc.c: Fix common/ includes.
8920         * dwarf2-frame.c: Fix common/ includes.
8921         * dwarf-index-cache.c: Fix common/ includes.
8922         * dtrace-probe.c: Fix common/ includes.
8923         * disasm-selftests.c: Fix common/ includes.
8924         * defs.h: Fix common/ includes.
8925         * csky-tdep.c: Fix common/ includes.
8926         * cp-valprint.c: Fix common/ includes.
8927         * cp-support.h: Fix common/ includes.
8928         * cp-support.c: Fix common/ includes.
8929         * corelow.c: Fix common/ includes.
8930         * completer.h: Fix common/ includes.
8931         * completer.c: Fix common/ includes.
8932         * compile/compile.c: Fix common/ includes.
8933         * compile/compile-loc2c.c: Fix common/ includes.
8934         * compile/compile-cplus-types.c: Fix common/ includes.
8935         * compile/compile-cplus-symbols.c: Fix common/ includes.
8936         * command.h: Fix common/ includes.
8937         * cli/cli-dump.c: Fix common/ includes.
8938         * cli/cli-cmds.c: Fix common/ includes.
8939         * charset.c: Fix common/ includes.
8940         * build-id.c: Fix common/ includes.
8941         * btrace.h: Fix common/ includes.
8942         * btrace.c: Fix common/ includes.
8943         * breakpoint.h: Fix common/ includes.
8944         * breakpoint.c: Fix common/ includes.
8945         * ax.h:
8946         (enum agent_op): Fix common/ includes.
8947         * ax-general.c (struct aop_map): Fix common/ includes.
8948         * ax-gdb.c: Fix common/ includes.
8949         * auxv.c: Fix common/ includes.
8950         * auto-load.c: Fix common/ includes.
8951         * arm-tdep.c: Fix common/ includes.
8952         * arch/riscv.c: Fix common/ includes.
8953         * arch/ppc-linux-common.c: Fix common/ includes.
8954         * arch/i386.c: Fix common/ includes.
8955         * arch/arm.c: Fix common/ includes.
8956         * arch/arm-linux.c: Fix common/ includes.
8957         * arch/arm-get-next-pcs.c: Fix common/ includes.
8958         * arch/amd64.c: Fix common/ includes.
8959         * arch/aarch64.c: Fix common/ includes.
8960         * arch/aarch64-insn.c: Fix common/ includes.
8961         * arch-utils.c: Fix common/ includes.
8962         * amd64-windows-tdep.c: Fix common/ includes.
8963         * amd64-tdep.c: Fix common/ includes.
8964         * amd64-sol2-tdep.c: Fix common/ includes.
8965         * amd64-obsd-tdep.c: Fix common/ includes.
8966         * amd64-nbsd-tdep.c: Fix common/ includes.
8967         * amd64-linux-tdep.c: Fix common/ includes.
8968         * amd64-linux-nat.c: Fix common/ includes.
8969         * amd64-fbsd-tdep.c: Fix common/ includes.
8970         * amd64-fbsd-nat.c: Fix common/ includes.
8971         * amd64-dicos-tdep.c: Fix common/ includes.
8972         * amd64-darwin-tdep.c: Fix common/ includes.
8973         * agent.c: Fix common/ includes.
8974         * ada-lang.h: Fix common/ includes.
8975         * ada-lang.c: Fix common/ includes.
8976         * aarch64-tdep.c: Fix common/ includes.
8977
8978 2019-01-25  Tom Tromey  <tom@tromey.com>
8979
8980         * common/create-version.sh: Use common/version.h.
8981
8982 2019-01-24  Pedro Alves  <palves@redhat.com>
8983
8984         * infrun.c (signal_stop, signal_print, signal_program)
8985         (signal_catch, signal_pass): Now arrays instead of pointers.
8986         (update_signals_program_target, do_target_resume)
8987         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8988         * linux-nat.c (linux_nat_target::pass_signals)
8989         (linux_nat_target::create_inferior, linux_nat_target::attach):
8990         Adjust.
8991         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8992         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8993         * procfs.c (procfs_target::pass_signals): Adjust.
8994         * record-full.c (record_full_target::resume): Adjust.
8995         * remote.c (remote_target::pass_signals)
8996         (remote_target::program_signals): Adjust.
8997         * target-debug.h (target_debug_print_signals): Now takes a
8998         gdb::array_view as parameter.  Adjust.
8999         * target.h (target_ops) <pass_signals, program_signals>: Replace
9000         pointer and length parameters with gdb::array_view.
9001         (target_pass_signals, target_program_signals): Likewise.
9002         * target-delegates.c: Regenerate.
9003
9004 2019-01-24  Pedro Alves  <palves@redhat.com>
9005
9006         * common/forward-scope-exit.h
9007         (forward_scope_exit::forward_scope_exit): Pass arguments to
9008         m_bind_function directly, instead of creating a std::bind and
9009         copying that.
9010
9011 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9012
9013         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9014         for static members.
9015         (pass_in_v_vfp_candidate): Likewise.
9016
9017 2019-01-23  Tom Tromey  <tom@tromey.com>
9018             Pedro Alves  <palves@redhat.com>
9019
9020         * regcache.c (class regcache_invalidator): Remove.
9021         (regcache::raw_write): Use make_scope_exit.
9022
9023 2019-01-23  Tom Tromey  <tom@tromey.com>
9024
9025         * ui-out.h (class ui_out_emit_type): Update comment.
9026
9027 2019-01-23  Tom Tromey  <tom@tromey.com>
9028
9029         * infrun.c (fetch_inferior_event): Update comment.
9030
9031 2019-01-23  Tom Tromey  <tom@tromey.com>
9032             Pedro Alves  <palves@redhat.com>
9033
9034         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9035         parameter.
9036         (fetch_inferior_event): Use SCOPE_EXIT.
9037
9038
9039 2019-01-23  Tom Tromey  <tom@tromey.com>
9040             Pedro Alves  <palves@redhat.com>
9041
9042         * infrun.c (disable_thread_events): Delete.
9043         (stop_all_threads): Use SCOPE_EXIT.
9044
9045 2019-01-23  Tom Tromey  <tom@tromey.com>
9046             Pedro Alves  <palves@redhat.com>
9047
9048         * symfile.c: Include forward-scope-exit.h.
9049         (clear_symtab_users_cleanup): Replace forward declaration with
9050         a FORWARD_SCOPE_EXIT.
9051         (syms_from_objfile_1): Use the forward_scope_exit and
9052         gdb::optional instead of cleanup_function.
9053         (reread_symbols): Use the forward_scope_exit instead of
9054         cleanup_function.
9055         (clear_symtab_users_cleanup): Remove function.
9056
9057 2019-01-23  Tom Tromey  <tom@tromey.com>
9058             Pedro Alves  <palves@redhat.com>
9059
9060         * linux-nat.c: Include scope-exit.h.
9061         (cleanup_target_stop): Remove.
9062         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9063         SCOPE_EXIT.
9064
9065 2019-01-23  Tom Tromey  <tom@tromey.com>
9066             Pedro Alves  <palves@redhat.com>
9067
9068         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9069         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9070
9071 2019-01-23  Tom Tromey  <tom@tromey.com>
9072             Andrew Burgess  <andrew.burgess@embecosm.com>
9073             Pedro Alves  <palves@redhat.com>
9074
9075         * infrun.c (fetch_inferior_event): Use scope_exit.
9076         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9077         * top.c (execute_command): Use scope_exit.
9078         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9079         * utils.c (do_bpstat_clear_actions_cleanup)
9080         (make_bpstat_clear_actions_cleanup): Remove.
9081
9082 2019-01-23  Tom Tromey  <tom@tromey.com>
9083             Pedro Alves  <palves@redhat.com>
9084
9085         * infrun.c: Include "common/scope-exit.h"
9086         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9087         (wait_for_inferior): Use SCOPE_EXIT.
9088         (fetch_inferior_event): Use scope_exit.
9089
9090 2019-01-23  Tom Tromey  <tom@tromey.com>
9091             Pedro Alves  <palves@redhat.com>
9092
9093         * breakpoint.c (create_breakpoint): Remove cleanup.
9094
9095 2019-01-23  Tom Tromey  <tom@tromey.com>
9096             Andrew Burgess  <andrew.burgess@embecosm.com>
9097             Pedro Alves  <palves@redhat.com>
9098
9099 2019-01-23  Pedro Alves  <palves@redhat.com>
9100
9101         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9102
9103 2019-01-23  Pedro Alves  <palves@redhat.com>
9104             Andrew Burgess  <andrew.burgess@embecosm.com>
9105
9106         * gdbthread.h: Include "common/forward-scope-exit.h".
9107         (scoped_finish_thread_state): Redefine custom class in terms of
9108         forward_scope_exit.
9109
9110 2019-01-23  Pedro Alves  <palves@redhat.com>
9111             Andrew Burgess  <andrew.burgess@embecosm.com>
9112
9113         * common/forward-scope-exit.h: New file.
9114
9115 2019-01-23  Pedro Alves  <palves@redhat.com>
9116             Andrew Burgess  <andrew.burgess@embecosm.com>
9117             Tom Tromey  <tom@tromey.com>
9118
9119         * common/scope-exit.h: New file.
9120
9121 2019-01-23  Pedro Alves  <palves@redhat.com>
9122
9123         * common/preprocessor.h (ESC): Rename to ...
9124         (ESC_PARENS): ... this.
9125         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9126         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9127
9128 2019-01-23  Tom Tromey  <tom@tromey.com>
9129
9130         * language.h (class scoped_switch_to_sym_language_if_auto):
9131         Initialize m_lang in both cases.
9132
9133 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9134
9135         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9136         with XCNEW.
9137
9138 2019-01-22  Tom Tromey  <tom@tromey.com>
9139
9140         * corelow.c: Do not include sys/file.h.
9141
9142 2019-01-22  Tom Tromey  <tom@tromey.com>
9143
9144         * tui/tui-wingeneral.h: Include gdb_curses.h.
9145
9146 2019-01-22  Tom Tromey  <tom@tromey.com>
9147
9148         * source-cache.h (class source_cache) <get_source_lines,
9149         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9150
9151 2019-01-22  Tom Tromey  <tom@tromey.com>
9152
9153         * remote-fileio.h (struct remote_target): Declare.
9154
9155 2019-01-22  Tom Tromey  <tom@tromey.com>
9156
9157         * python/py-arch.c: Do not include py-ref.h.
9158         * python/py-bpevent.c: Do not include py-ref.h.
9159         * python/py-cmd.c: Do not include py-ref.h.
9160         * python/py-continueevent.c: Do not include py-ref.h.
9161         * python/py-event.h: Do not include py-ref.h.
9162         * python/py-evtregistry.c: Do not include py-ref.h.
9163         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9164         * python/py-frame.c: Do not include py-ref.h.
9165         * python/py-framefilter.c: Do not include py-ref.h.
9166         * python/py-function.c: Do not include py-ref.h.
9167         * python/py-infevents.c: Do not include py-ref.h.
9168         * python/py-linetable.c: Do not include py-ref.h.
9169         * python/py-objfile.c: Do not include py-ref.h.
9170         * python/py-param.c: Do not include py-ref.h.
9171         * python/py-prettyprint.c: Do not include py-ref.h.
9172         * python/py-progspace.c: Do not include py-ref.h.
9173         * python/py-symbol.c: Do not include py-ref.h.
9174         * python/py-symtab.c: Do not include py-ref.h.
9175         * python/py-type.c: Do not include py-ref.h.
9176         * python/py-unwind.c: Do not include py-ref.h.
9177         * python/py-utils.c: Do not include py-ref.h.
9178         * python/py-value.c: Do not include py-ref.h.
9179         * python/py-varobj.c: Do not include py-ref.h.
9180         * python/py-xmethods.c: Do not include py-ref.h.
9181         * python/python.c: Do not include py-ref.h.
9182         * varobj.c: Do not include py-ref.h.
9183
9184 2019-01-22  Tom Tromey  <tom@tromey.com>
9185
9186         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9187         keyword for bcache.
9188
9189 2019-01-22  Tom Tromey  <tom@tromey.com>
9190
9191         * compile/compile-cplus-types.c: Remove a comment by #include.
9192
9193 2019-01-22  Tom Tromey  <tom@tromey.com>
9194
9195         * compile/gcc-c-plugin.h: Include compile-internal.h.
9196
9197 2019-01-22  Tom Tromey  <tom@tromey.com>
9198
9199         * stabsread.c (EXTERN): Do not define.
9200         (symnum, next_symbol_text_func, processing_gcc_compilation)
9201         (within_function, global_sym_chain, global_stabs)
9202         (previous_stab_code, this_object_header_files)
9203         (n_this_object_header_files)
9204         (n_allocated_this_object_header_files): Define.
9205         * stabsread.h (EXTERN): Never define.  Use "extern".
9206
9207 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9208
9209         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9210         history_value.
9211
9212 2019-01-21  Tom Tromey  <tom@tromey.com>
9213
9214         * ui-out.c: Fix includes.
9215         * tui/tui-source.c: Fix includes.
9216         * target.c: Fix includes.
9217         * remote.c: Fix includes.
9218         * regcache.c: Fix includes.
9219         * python/py-block.c: Fix includes.
9220         * printcmd.c: Fix includes.
9221         * or1k-tdep.c: Fix includes.
9222         * mi/mi-main.c: Fix includes.
9223         * m32r-tdep.c: Fix includes.
9224         * csky-tdep.c: Fix includes.
9225         * compile/compile-cplus-types.c: Fix includes.
9226         * cli/cli-interp.c: Fix includes.
9227
9228 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9229
9230         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9231         for padding.
9232
9233 2019-01-16  Tom Tromey  <tom@tromey.com>
9234
9235         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9236         earlier.
9237         (struct objfile) <msymbols_range>: Move from top level.
9238         <msymbols>: New method.
9239         (class objfile_msymbols): Remove.
9240         * symtab.c (default_collect_symbol_completion_matches_break_on):
9241         Update.
9242         * symmisc.c (dump_msymbols): Update.
9243         * stabsread.c (scan_file_globals): Update.
9244         * objc-lang.c (info_selectors_command, info_classes_command)
9245         (find_methods): Update.
9246         * minsyms.c (find_solib_trampoline_target): Update.
9247         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9248         * coffread.c (coff_symfile_read): Update.
9249         * ada-lang.c (ada_lookup_simple_minsym)
9250         (ada_collect_symbol_completion_matches): Update.
9251
9252 2019-01-16  Tom Tromey  <tom@tromey.com>
9253
9254         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9255         type.  Remove no-argument constructor.
9256         <iterator::operator++>: Simplify.
9257         <begin>: Update.
9258         <end>: Use minimal_symbol_count.
9259
9260 2019-01-16  Tom Tromey  <tom@tromey.com>
9261
9262         * objfiles.h (struct objfile) <psymtabs>: New method.
9263         (class objfile_psymtabs): Remove.
9264         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9265         typedef.
9266         <range>: New method.
9267         (require_partial_symbols): Change return type.
9268         * psymtab.c (require_partial_symbols)
9269         (psym_expand_symtabs_matching): Update.
9270         * mdebugread.c (parse_partial_symbols): Update.
9271         * dbxread.c (dbx_end_psymtab): Update.
9272
9273 2019-01-15  Tom Tromey  <tom@tromey.com>
9274
9275         * symtab.c (lookup_objfile_from_block)
9276         (lookup_symbol_in_objfile_symtabs)
9277         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9278         (find_line_symtab, info_sources_command)
9279         (default_collect_symbol_completion_matches_break_on)
9280         (make_source_files_completion_list): Update.
9281         * symmisc.c (print_objfile_statistics, dump_objfile)
9282         (maintenance_print_symbols, maintenance_info_symtabs)
9283         (maintenance_check_symtabs, maintenance_info_line_tables):
9284         Update.
9285         * source.c (select_source_symtab)
9286         (forget_cached_source_info_for_objfile): Update.
9287         * objfiles.h (class objfile_compunits): Remove.
9288         (struct objfile) <compunits_range>: New typedef.
9289         (compunits): New method.
9290         * objfiles.c (objfile_relocate1): Update.
9291         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9292         * maint.c (count_symtabs_and_blocks): Update.
9293         * linespec.c (iterate_over_all_matching_symtabs): Update.
9294         * cp-support.c (add_symbol_overload_list_qualified): Update.
9295         * coffread.c (coff_symtab_read): Update.
9296         * ada-lang.c (add_nonlocal_symbols)
9297         (ada_collect_symbol_completion_matches)
9298         (ada_add_global_exceptions): Update.
9299
9300 2019-01-15  Tom Tromey  <tom@tromey.com>
9301
9302         * progspace.h (program_space) <objfiles_safe_range>: New
9303         typedef.
9304         <objfiles_safe>: New method.
9305         * objfiles.h (class all_objfiles_safe): Remove.
9306         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9307         * jit.c (jit_inferior_exit_hook): Update.
9308
9309 2019-01-17  Tom Tromey  <tom@tromey.com>
9310
9311         * progspace.h (program_space) <objfiles_range>: New typedef.
9312         <objfiles>: New method.
9313         <objfiles_head>: Rename from objfiles.
9314         (object_files): Update.
9315         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9316         * guile/scm-pretty-print.c
9317         (ppscm_find_pretty_printer_from_objfiles): Update.
9318         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9319         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9320         Update.
9321         * python/py-progspace.c (pspy_get_objfiles): Update.
9322         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9323         Update.
9324         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9325         (objfpy_lookup_objfile_by_build_id): Update.
9326         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9327         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9328         Update.
9329         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9330         (expand_symtab_containing_pc, lookup_objfile_from_block)
9331         (lookup_static_symbol, basic_lookup_transparent_type)
9332         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9333         (find_line_symtab, info_sources_command)
9334         (default_collect_symbol_completion_matches_break_on)
9335         (make_source_files_completion_list, find_main_name): Update.
9336         * symmisc.c (print_symbol_bcache_statistics)
9337         (print_objfile_statistics, maintenance_print_symbols)
9338         (maintenance_print_msymbols, maintenance_print_objfiles)
9339         (maintenance_info_symtabs, maintenance_check_symtabs)
9340         (maintenance_expand_symtabs, maintenance_info_line_tables):
9341         Update.
9342         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9343         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9344         (map_overlay_command, unmap_overlay_command)
9345         (simple_overlay_update, expand_symtabs_matching)
9346         (map_symbol_filenames): Update.
9347         * symfile-debug.c (set_debug_symfile): Update.
9348         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9349         Update.
9350         * source.c (select_source_symtab, forget_cached_source_info):
9351         Update.
9352         * solib.c (solib_read_symbols): Update.
9353         * solib-spu.c (append_ocl_sos): Update.
9354         * psymtab.c (maintenance_print_psymbols)
9355         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9356         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9357         * printcmd.c (info_symbol_command): Update.
9358         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9359         Update.
9360         * objfiles.h (class all_objfiles): Remove.
9361         * objfiles.c (have_partial_symbols, have_full_symbols)
9362         (have_minimal_symbols, qsort_cmp, update_section_map)
9363         (shared_objfile_contains_address_p)
9364         (default_iterate_over_objfiles_in_search_order): Update.
9365         * objc-lang.c (info_selectors_command, info_classes_command)
9366         (find_methods): Update.
9367         * minsyms.c (find_solib_trampoline_target): Update.
9368         * maint.c (maintenance_info_sections)
9369         (maintenance_translate_address, count_symtabs_and_blocks):
9370         Update.
9371         * main.c (captured_main_1): Update.
9372         * linux-thread-db.c (try_thread_db_load_from_pdir)
9373         (has_libpthread): Update.
9374         * linespec.c (iterate_over_all_matching_symtabs)
9375         (search_minsyms_for_name): Update.
9376         * jit.c (jit_find_objf_with_entry_addr): Update.
9377         * hppa-tdep.c (find_unwind_entry)
9378         (hppa_lookup_stub_minimal_symbol): Update.
9379         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9380         Update.
9381         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9382         (elf_gnu_ifunc_resolve_by_got): Update.
9383         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9384         * dwarf-index-write.c (save_gdb_index_command): Update.
9385         * cp-support.c (add_symbol_overload_list_qualified): Update.
9386         * breakpoint.c (create_overlay_event_breakpoint)
9387         (create_longjmp_master_breakpoint)
9388         (create_std_terminate_master_breakpoint)
9389         (create_exception_master_breakpoint): Update.
9390         * blockframe.c (find_pc_partial_function): Update.
9391         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9392         (ada_collect_symbol_completion_matches)
9393         (ada_add_global_exceptions): Update.
9394
9395 2019-01-17  Tom Tromey  <tom@tromey.com>
9396
9397         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9398         declare VEC.
9399         (solib_target_parse_libraries): Change return type.
9400         (library_list_start_segment, library_list_start_section)
9401         (library_list_end_library, library_list_start_library); Update.
9402         (solib_target_free_library_list): Remove.
9403         (solib_target_parse_libraries): Remove cleanup.  Change return
9404         type.
9405         (solib_target_current_sos): Update.
9406
9407 2019-01-17  Tom Tromey  <tromey@bapiya>
9408
9409         * valprint.c: Replace "the the" with "the".
9410         * symtab.c: Replace "the the" with "the".
9411         * solib.c: Replace "the the" with "the".
9412         * solib-dsbt.c: Replace "the the" with "the".
9413         * linespec.c: Replace "the the" with "the".
9414         * dwarf2loc.h: Replace "the the" with "the".
9415         * amd64-windows-tdep.c: Replace "the the" with "the".
9416         * aarch64-tdep.c: Replace "the the" with "the".
9417
9418 2019-01-16  Keith Seitz  <keiths@redhat.com>
9419
9420         PR gdb/23773
9421         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9422         <builder>: Rename to ..
9423         <m_builder>: ... this and make private.
9424         (dwarf2_cu::get_builder): New method.  Change all users of
9425         `builder' to use this method.
9426         (dwarf2_start_symtab): Move to ...
9427         (dwarf2_cu::start_symtab): ... here.  Update all callers
9428         (setup_type_unit_groups): Move to ...
9429         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9430         callers.
9431         (dwarf2_cu::reset_builder): New method.
9432         (process_full_compunit, process_full_type_unit): Use
9433         dwarf2_cu::reset_builder.
9434         (follow_die_offset): Record the ancestor CU if it is different
9435         from the followed DIE's CU.
9436         (follow_die_sig_1): Likewise.
9437
9438 2019-01-15  Tom Tromey  <tom@tromey.com>
9439
9440         * remote.c (class remote_state) <buf>: Now a char_vector.
9441         <buf_size>: Remove.
9442         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9443         parameter.
9444         (remote_target::getpkt_or_notif_sane_1)
9445         (remote_target::getpkt_sane)
9446         (remote_target::getpkt_or_notif_sane): Likewise.
9447         (class remote_target) <putpkt>: New overload.
9448         (remote_target::read_frame): Change type of "buf_p".  Remove
9449         sizeof_p parameter.
9450         (packet_ok): New overload.
9451         (packet_check_result): New overload.
9452         Update all uses.
9453
9454 2019-01-14  Tom Tromey  <tom@tromey.com>
9455
9456         * remote-notif.c (handle_notification, remote_notif_ack)
9457         (remote_notif_parse): Make "buf" const.
9458         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9459         const.
9460         (remote_notif_parse, remote_notif_ack, handle_notification):
9461         Likewise.
9462         * remote.c (remote_notif_stop_parse): Make "buf" const.
9463         (remote_target::remote_parse_stop_reply): Make "buf" const.
9464         (remote_notif_stop_ack): Make "buf" const.
9465
9466 2019-01-14  Tom Tromey  <tom@tromey.com>
9467
9468         * remote.c (remote_console_output): Make parameter const.
9469
9470 2019-01-14  Tom Tromey  <tom@tromey.com>
9471
9472         * target-debug.h (target_debug_print_signals): Constify.
9473         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9474         * procfs.c (procfs_target::pass_signals): Update.
9475         * linux-nat.c (linux_nat_target::pass_signals): Update.
9476         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9477         * target-delegates.c: Rebuild.
9478         * remote.c (remote_target::program_signals): Update.
9479         (remote_target::pass_signals): Update.
9480         * target.c (target_pass_signals): Constify argument.
9481         (target_program_signals): Likewise.
9482         * target.h (struct target_ops) <pass_signals, program_signals>:
9483         Constify argument.
9484         (target_pass_signals, target_program_signals): Constify argument.
9485
9486 2019-01-14  Tom Tromey  <tom@tromey.com>
9487
9488         PR tui/28819:
9489         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9490
9491 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9492
9493         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9494         field.
9495         * rs6000-tdep.c: Include reggroups.h.
9496         (IS_V_ALIAS_PSEUDOREG): Define.
9497         (rs6000_register_name): Return names for the "vX" aliases.
9498         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9499         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9500         aliases.  Call default_register_reggroup_p for all other
9501         pseudo-registers.
9502         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9503         New functions.
9504         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9505         Handle "vX" aliases.
9506         (v_alias_pseudo_register_collect): New function.
9507         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9508         (rs6000_gdbarch_init): Initialize "vX" aliases as
9509         pseudo-registers.  Restore registration of
9510         rs6000_pseudo_register_reggroup_p with
9511         set_tdesc_pseudo_register_reggroup_p.
9512
9513 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9514
9515         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9516         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9517         set_gdbarch_num_pseudo_regs.
9518
9519 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9520
9521         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9522         Remove arg prefixname, add do_set and do_show.
9523         Add member functions set_list and show_list.
9524         * cli/cli-style.c (class cli_style_option): Update accordingly.
9525         (style_set_list): Move to file scope.
9526         (style_show_list): Likewise.
9527         (set_style): Call help_list.
9528         (show_style): Call cmd_show_list.
9529         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9530         Update to use the new macro.
9531
9532 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9533
9534         * ada-lang.c (_initialize_ada_language): Expand the help text
9535         for the "catch exception" command.
9536
9537 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9538
9539         * symtab.c (matching_obj_sections): Initialize obj,
9540         declare it closer to its usage.
9541
9542 2019-01-10  Tom Tromey  <tom@tromey.com>
9543
9544         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9545         (basic_inf_threads_range): Remove.
9546         (inf_threads_range, inf_non_exited_threads_range)
9547         (safe_inf_threads_range): Use next_adapter.
9548
9549 2019-01-10  Keith Seitz  <keiths@redhat.com>
9550
9551         PR gdb/23712
9552         PR symtab/23010
9553         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9554         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9555
9556 2019-01-10  Keith Seitz  <keiths@redhat.com>
9557
9558         PR gdb/23712
9559         PR symtab/23010
9560         * dictionary.c (pending_to_vector): Remove.
9561         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9562         Remove _1 suffix, replacing functions of the same name.  Update
9563         all callers.
9564         (dict_create_hashed, dict_create_hashed_expandable)
9565         (dict_create_linear, dict_create_linear_expandable, dict_free)
9566         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9567         Make functions static.
9568
9569 2019-01-10  Keith Seitz  <keiths@redhat.com>
9570
9571         PR gdb/23712
9572         PR symtab/23010
9573         * dictionary.h (struct dictionary): Replace declaration with
9574         multidictionary.
9575         (dict_create_hashed, dict_create_hashed_expandable)
9576         (dict_create_linear, dict_create_linear_expandable)
9577         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9578         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9579         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9580         taking multidictionary argument.
9581         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9582         * block.h (struct block) <dict>: Change to multidictionary
9583         and rename `multidict'.
9584         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9585         symmisc.c: Update all dictionary references to multidictionary.
9586
9587 2019-01-10  Keith Seitz  <keiths@redhat.com>
9588
9589         PR gdb/23712
9590         PR symtab/23010
9591         * dictionary.c: Include unordered_map.
9592         (pending_to_vector): New function.
9593         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9594         Rewrite the non-"_1" functions to take vector instead
9595         of linked list.
9596         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9597         "new" _1 versions of the same name.
9598         (multidictionary): Define.
9599         (std::hash<enum language): New definition.
9600         (collate_pending_symbols_by_language, mdict_create_hashed)
9601         (mdict_create_hashed_expandable, mdict_create_linear)
9602         (mdict_create_linear_expandable, mdict_free)
9603         (find_language_dictionary, create_new_language_dictionary)
9604         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9605         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9606         (mdict_size, mdict_empty): New functions.
9607         * dictionary.h (mdict_iterator): Define.
9608
9609 2019-01-10  Pedro Alves  <palves@redhat.com>
9610
9611         * breakpoint.c (read_uploaded_action)
9612         (create_tracepoint_from_upload): Adjust to use
9613         gdb::unique_xmalloc_ptr.
9614         * ctf.c (ctf_write_uploaded_tp):
9615         (SET_ARRAY_FIELD): Use emplace_back.
9616         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9617         * tracefile-tfile.c (tfile_write_uploaded_tp):
9618         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9619         gdb::unique_xmalloc_ptr.
9620         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9621         at_string, cond_string, cmd_strings>: Replace char pointers
9622         with gdb::unique_xmalloc_ptr.
9623
9624 2019-01-10  Pedro Alves  <palves@redhat.com>
9625
9626         * solib-target.c (library_list_start_library): Don't xstrdup name.
9627
9628 2019-01-10  Pedro Alves  <palves@redhat.com>
9629
9630         * mdebugread.c (parse_partial_symbols): Use
9631         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9632
9633 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9634
9635         * linux-fork.c (scoped_switch_fork_info)
9636         <~scoped_switch_fork_info>: Fix incorrect variable name.
9637
9638 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9639
9640         * linux-fork.c (scoped_switch_fork_info)
9641         <scoped_switch_fork_info>: Make explicit.
9642         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9643
9644 2019-01-10  Tom Tromey  <tom@tromey.com>
9645
9646         * objfiles.h (objfile::reset_psymtabs): Update.
9647         * objfiles.c (objfile::objfile): Update.
9648         * psymtab.h (psymtab_storage::obstack): Update.
9649         (psymtab_storage::m_obstack): Use gdb::optional.
9650         (class psymtab_storage): Update comment.  Remove objfile
9651         parameter.
9652         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9653
9654 2019-01-10  Tom Tromey  <tom@tromey.com>
9655
9656         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9657         <free_psymtabs>: Now private.
9658         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9659         (allocate_psymtab): Use new method.
9660
9661 2019-01-10  Tom Tromey  <tom@tromey.com>
9662
9663         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9664         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9665         * mdebugread.c (parse_partial_symbols): Use
9666         allocate_dependencies.
9667         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9668         allocate_dependencies.
9669         (process_psymtab_comp_unit_reader)
9670         (build_type_psymtab_dependencies): Likewise.
9671         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9672
9673 2019-01-10  Tom Tromey  <tom@tromey.com>
9674
9675         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9676         PSYMBOL_SET_LANGUAGE.
9677         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9678
9679 2019-01-10  Tom Tromey  <tom@tromey.com>
9680
9681         * psymtab.h (psymtab_storage::obstack): New method.
9682         <m_obstack>: Rename from obstack; now private.
9683         * psymtab.c (psymtab_storage): Update.
9684         * dwarf2read.c (create_addrmap_from_index)
9685         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9686         Update.
9687
9688 2019-01-10  Tom Tromey  <tom@tromey.com>
9689
9690         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9691         * objfiles.h (objfile::reset_psymtabs): New method.
9692
9693 2019-01-10  Tom Tromey  <tom@tromey.com>
9694
9695         * symmisc.c (print_symbol_bcache_statistics): Update.
9696         (print_objfile_statistics): Update.
9697         * symfile.c (reread_symbols): Update.
9698         * psymtab.h (class psymtab_storage): New.
9699         * psymtab.c (psymtab_storage): New constructor.
9700         (~psymtab_storage): New destructor.
9701         (require_partial_symbols): Update.
9702         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9703         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9704         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9705         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9706         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9707         (start_psymtab_common, end_psymtab_common)
9708         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9709         (allocate_psymtab): Update.
9710         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9711         Update.
9712         (dump_psymtab_addrmap, maintenance_print_psymbols)
9713         (maintenance_check_psymtabs): Update.
9714         (class objfile_psymtabs): Move to objfiles.h.
9715         * psympriv.h (discard_psymtab): Now inline.
9716         (psymtab_discarder::psymtab_discarder): Update.
9717         (psymtab_discarder::~psymtab_discarder): Update.
9718         (ALL_OBJFILE_PSYMTABS): Rewrite.
9719         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9720         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9721         Remove fields.
9722         <partial_symtabs>: New field.
9723         (class objfile_psymtabs): Move from psymtab.h.  Update.
9724         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9725         psymbol_cache.
9726         (objfile::~objfile): Don't destroy psymbol_cache.
9727         * mdebugread.c (parse_partial_symbols): Update.
9728         * dwarf2read.c (create_addrmap_from_index)
9729         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9730         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9731         (add_partial_subprogram, dwarf2_ranges_read): Update.
9732         * dwarf-index-write.c (write_address_map)
9733         (write_one_signatured_type, recursively_write_psymbols)
9734         (class debug_names, class debug_names, write_psymtabs_to_index):
9735         Update.
9736
9737 2019-01-10  Tom Tromey  <tom@tromey.com>
9738
9739         * symtab.h (SYMBOL_SET_NAMES): Update.
9740         (symbol_set_names): Update.
9741         (MSYMBOL_SET_NAMES): Update.
9742         * symtab.c (symbol_set_names): Change argument to be an
9743         objfile_per_bfd_storage.
9744         * psymtab.c (add_psymbol_to_bcache): Update.
9745         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9746
9747 2019-01-10  Tom Tromey  <tom@tromey.com>
9748
9749         * symtab.c (create_demangled_names_hash): Change argument to be an
9750         objfile_per_bfd_storage.
9751         (symbol_set_names): Update.
9752
9753 2019-01-10  Tom Tromey  <tom@tromey.com>
9754
9755         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9756         init_psymbol_list.
9757         * psymtab.c (init_psymbol_list): Do nothing if already called.
9758         * psympriv.h (init_psymbol_list): Add comment.
9759         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9760         init_psymbol_list.
9761         * dbxread.c (dbx_symfile_read): Unconditionally call
9762         init_psymbol_list.
9763
9764 2019-01-10  Tom Tromey  <tom@tromey.com>
9765
9766         * xcoffread.c (scan_xcoff_symtab): Update.
9767         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9768         "where".
9769         * mdebugread.c (parse_partial_symbols)
9770         (handle_psymbol_enumerators): Update.
9771         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9772         * dbxread.c (read_dbx_symtab): Update.
9773         * psympriv.h (psymbol_placement): New enum.
9774         (add_psymbol_to_list): Update.
9775
9776 2019-01-10  Tom Tromey  <tom@tromey.com>
9777
9778         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9779         static_psymbols parameters.
9780         (scan_xcoff_symtab): Update.
9781         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9782         static_psymbols parameters.
9783         * psympriv.h (start_psymtab_common): Update.
9784         * mdebugread.c (parse_partial_symbols): Update.
9785         * dwarf2read.c (create_partial_symtab): Update.
9786         * dbxread.c (read_dbx_symtab): Update.
9787         (start_psymtab): Remove global_psymbols and static_psymbols
9788         parameters.
9789
9790 2019-01-10  Tom Tromey  <tom@tromey.com>
9791
9792         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9793         * psymtab.c (allocate_psymtab): Add comment.
9794         * psympriv.h (allocate_psymtab): Add comment.
9795         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9796         initializations.
9797         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9798
9799 2019-01-10  Tom Tromey  <tom@tromey.com>
9800
9801         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9802         Don't declare.
9803         * mipsread.c: Include mdebugread.h.
9804         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9805         Declare.
9806         * elfread.c: Include mdebugread.h.
9807
9808 2019-01-09  Tom Tromey  <tom@tromey.com>
9809
9810         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9811         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9812         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9813         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9814         (psym_lookup_symbol, psym_find_last_source_symtab)
9815         (psym_forget_cached_source_info, psym_print_stats)
9816         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9817         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9818         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9819         (psym_find_compunit_symtab_by_address)
9820         (maintenance_print_psymbols, maintenance_info_psymtabs)
9821         (maintenance_check_psymtabs): Use ranged for.
9822         * psymtab.h (class objfile_psymtabs): New.
9823         (require_partial_symbols): Return objfile_psymtabs.
9824         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9825
9826 2019-01-09  Tom Tromey  <tom@tromey.com>
9827
9828         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9829         (find_pc_mapped_section, list_overlays_command)
9830         (map_overlay_command, unmap_overlay_command)
9831         (simple_overlay_update): Use all_objfiles.
9832         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9833         * printcmd.c (info_symbol_command): Use all_objfiles.
9834         * objfiles.h (ALL_OBJSECTIONS): Remove.
9835         * maint.c (maintenance_translate_address): Use all_objfiles.
9836         * gcore.c (gcore_create_callback): Use all_objfiles.
9837         (objfile_find_memory_regions): Likewise.
9838
9839 2019-01-09  Tom Tromey  <tom@tromey.com>
9840
9841         * symtab.c (find_line_symtab, info_sources_command)
9842         (make_source_files_completion_list): Use objfile_compunits.
9843         * source.c (select_source_symtab): Use objfile_compunits.
9844         * objfiles.h (struct objfile): Update comment.
9845         (ALL_OBJFILES): Remove.
9846         (ALL_FILETABS): Remove.
9847         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9848         objfile_compunits.
9849
9850 2019-01-09  Tom Tromey  <tom@tromey.com>
9851
9852         * symmisc.c (print_objfile_statistics, dump_objfile)
9853         (maintenance_print_symbols): Use compunit_filetabs.
9854         * source.c (forget_cached_source_info_for_objfile): Use
9855         compunit_filetabs.
9856         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9857         (ALL_FILETABS): Use compunit_filetabs.
9858         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9859         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9860
9861 2019-01-09  Tom Tromey  <tom@tromey.com>
9862
9863         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9864         (compunit_filetabs): New.
9865         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9866         compunit_filetabs.
9867         (info_sources_command, make_source_files_completion_list): Remove
9868         declaration.
9869         * symmisc.c (print_objfile_statistics, dump_objfile)
9870         (maintenance_print_symbols): Remove declaration.
9871         (maintenance_info_symtabs): Use compunit_filetabs.
9872         (maintenance_info_line_tables): Likewise.
9873         * source.c (select_source_symtab): Change local variable name.
9874         (forget_cached_source_info_for_objfile): Remove declaration.
9875         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9876         * objfiles.c (objfile_relocate1): Remove declaration.
9877         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9878         declaration.
9879         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9880         * coffread.c (coff_symtab_read): Remove declaration.
9881         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9882         compunit_filetabs.
9883
9884 2019-01-09  Tom Tromey  <tom@tromey.com>
9885
9886         * symtab.c (lookup_objfile_from_block)
9887         (find_pc_sect_compunit_symtab, search_symbols)
9888         (default_collect_symbol_completion_matches_break_on): Use
9889         objfile_compunits.
9890         * objfiles.h (ALL_COMPUNITS): Remove.
9891         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9892         * cp-support.c (add_symbol_overload_list_qualified): Use
9893         objfile_compunits.
9894         * ada-lang.c (ada_collect_symbol_completion_matches)
9895         (ada_add_global_exceptions): Use objfile_compunits.
9896
9897 2019-01-09  Tom Tromey  <tom@tromey.com>
9898
9899         * source.c (select_source_symtab)
9900         (forget_cached_source_info_for_objfile): Remove declaration.
9901         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9902         declaration.
9903         * maint.c (count_symtabs_and_blocks): Remove declaration.
9904         * cp-support.c (add_symbol_overload_list_qualified): Remove
9905         declaration.
9906         * coffread.c (coff_symtab_read): Remove declaration.
9907         * symtab.c (lookup_symbol_in_objfile_symtabs)
9908         (basic_lookup_transparent_type_1): Use objfile_compunits.
9909         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9910         (info_sources_command, search_symbols)
9911         (default_collect_symbol_completion_matches_break_on)
9912         (make_source_files_completion_list): Remove declaration.
9913         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9914         (ada_collect_symbol_completion_matches)
9915         (ada_add_global_exceptions): Remove declaration.
9916         * linespec.c (iterate_over_all_matching_symtabs): Use
9917         objfile_compunits.
9918         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9919         (class objfile_compunits): New.
9920         (ALL_COMPUNITS): Use objfile_compunits.
9921         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9922         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9923         objfile_compunits.
9924         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9925
9926 2019-01-09  Tom Tromey  <tom@tromey.com>
9927
9928         * symtab.c (search_symbols)
9929         (default_collect_symbol_completion_matches_break_on): Use
9930         objfile_msymbols.
9931         * ada-lang.c (ada_lookup_simple_minsym)
9932         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9933         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9934         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9935         objfile_msymbols.
9936         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9937         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9938         * objc-lang.c (find_methods): Use objfile_msymbols.
9939         (info_selectors_command, info_classes_command): Likewise.
9940         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9941         * objfiles.h (class objfile_msymbols): New.
9942         (ALL_OBJFILE_MSYMBOLS): Remove.
9943         (ALL_MSYMBOLS): Remove.
9944
9945 2019-01-09  Tom Tromey  <tom@tromey.com>
9946
9947         * common/next-iterator.h (next_adapter): Add Iterator template
9948         parameter.
9949         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9950         (class all_objfiles_safe): New.
9951         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9952         * objfiles.c (put_objfile_before): Update comment.
9953         (add_separate_debug_objfile): Likewise.
9954         (free_all_objfiles): Use all_objfiles_safe.
9955         (objfile_purge_solibs): Likewise.
9956
9957 2019-01-09  Tom Tromey  <tom@tromey.com>
9958
9959         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9960         (expand_symtab_containing_pc, lookup_static_symbol)
9961         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9962         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9963         all_objfiles.
9964         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9965         * breakpoint.c (create_overlay_event_breakpoint)
9966         (create_longjmp_master_breakpoint)
9967         (create_std_terminate_master_breakpoint)
9968         (create_exception_master_breakpoint): Use all_objfiles.
9969         * linux-thread-db.c (try_thread_db_load_from_pdir)
9970         (has_libpthread): Use all_objfiles.
9971         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9972         * linespec.c (iterate_over_all_matching_symtabs)
9973         (search_minsyms_for_name): Use all_objfiles.
9974         * maint.c (maintenance_info_sections): Use all_objfiles.
9975         * main.c (captured_main_1): Use all_objfiles.
9976         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9977         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9978         * guile/scm-pretty-print.c
9979         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9980         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9981         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9982         (maintenance_print_msymbols): Use all_objfiles.
9983         * source.c (select_source_symtab): Use all_objfiles.
9984         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9985         * symfile.c (remove_symbol_file_command)
9986         (expand_symtabs_matching, map_symbol_filenames): Use
9987         all_objfiles.
9988         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9989         all_objfiles.
9990         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9991         * objc-lang.c (find_methods): Use all_objfiles.
9992         * objfiles.c (have_partial_symbols, have_full_symbols)
9993         (have_minimal_symbols, qsort_cmp)
9994         (default_iterate_over_objfiles_in_search_order): Use
9995         all_objfiles.
9996         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9997         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9998         (maintenance_check_psymtabs): Use all_objfiles.
9999         (ALL_PSYMTABS): Remove.
10000         * compile/compile-object-run.c (do_module_cleanup): Use
10001         all_objfiles.
10002         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10003         * cp-support.c (add_symbol_overload_list_qualified): Use
10004         all_objfiles.
10005         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10006         Use all_objfiles.
10007         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10008         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10009         all_objfiles.
10010         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10011         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10012         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10013         Uses all_objfiles.
10014         * solib.c (solib_read_symbols): Use all_objfiles
10015
10016 2019-01-09  Tom Tromey  <tom@tromey.com>
10017
10018         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10019         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10020         all_objfiles.
10021         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10022         * symmisc.c (print_symbol_bcache_statistics)
10023         (print_objfile_statistics, maintenance_print_objfiles)
10024         (maintenance_info_symtabs, maintenance_check_symtabs)
10025         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10026         all_objfiles.
10027         * source.c (forget_cached_source_info): Use all_objfiles.
10028         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10029         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10030         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10031         * objfiles.c (update_section_map): Use all_objfiles.
10032         (shared_objfile_contains_address_p): Likewise.
10033         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10034         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10035
10036 2019-01-09  Tom Tromey  <tom@tromey.com>
10037
10038         * common/next-iterator.h: New file.
10039         * objfiles.h (class all_objfiles): New.
10040         (struct objfile_iterator): New.
10041
10042 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10043
10044         * NEWS: Move the description of the changed "frame", "select-frame",
10045          and "info frame" commands to the Changed commands section.
10046
10047 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10048
10049         * gdbtypes.c (check_stub_method_group): Remove handling of old
10050         mangling schemes.
10051         * linespec.c (find_methods): Likewise.
10052         * stabsread.c (read_member_functions): Likewise.
10053         * valops.c (search_struct_method): Likewise.
10054         (value_struct_elt_for_reference): Likewise.
10055         * NEWS: Mention this change.
10056
10057 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10058
10059         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10060         print_source_lines.
10061         * source.c (print_source_lines_base): Update line number check.
10062         (print_source_lines): New function.
10063         (source_lines_range::source_lines_range): New function.
10064         * source.h (class source_lines_range): New class.
10065         (print_source_lines): New declaration.
10066
10067 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10068
10069         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10070
10071 2019-01-08  Tom Tromey  <tom@tromey.com>
10072             Simon Marchi  <simon.marchi@ericsson.com>
10073
10074         PR gdb/24060
10075         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10076         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10077         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10078         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10079         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10080         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10081
10082 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10083
10084         * source.c (select_source_symtab): Move header comment to
10085         declaration in source.h.
10086         (forget_cached_source_info_for_objfile): Likewise.
10087         (forget_cached_source_info): Likewise.
10088         (identify_source_line): Likewise.
10089         * source.h (identify_source_line): Move declaration from symtab.h
10090         and add comment from source.c
10091         (print_source_lines): Likewise.
10092         (forget_cached_source_info_for_objfile): Likewise.
10093         (forget_cached_source_info): Likewise.
10094         (select_source_symtab): Likewise.
10095         (enum print_source_lines_flag): Move definition from symtab.h.
10096         * symtab.h (identify_source_line): Move declaration to source.h.
10097         (print_source_lines): Likewise.
10098         (forget_cached_source_info_for_objfile): Likewise.
10099         (forget_cached_source_info): Likewise.
10100         (select_source_symtab): Likewise.
10101         (enum print_source_lines_flag): Move definition to source.h.
10102         * tui/tui-hooks.c: Add 'source.h' include.
10103
10104 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10105
10106         * source.c (print_source_lines_base): Handle requests to print
10107         reverse line number sequences, and guard against empty lines
10108         string.
10109
10110 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10111
10112         * source.c (print_source_lines_base): Fix skip of '\r' if next
10113         character is '\n'.
10114
10115 2019-01-06  Tom Tromey  <tom@tromey.com>
10116
10117         * c-exp.y (struct c_parse_state) <macro_original_text,
10118         expansion_obstack>: New member.
10119         (macro_original_text, expansion_obstack): Remove globals.
10120         (scan_macro_expansion, scanning_macro_expansion)
10121         (finished_macro_expansion): Update.
10122         (scan_macro_cleanup): Remove.
10123         (yylex, c_parse): Update.
10124
10125 2019-01-06  Tom Tromey  <tom@tromey.com>
10126
10127         * c-exp.y (struct c_parse_state) <strings>: New member.
10128         (operator_stoken): Update.
10129
10130 2019-01-06  Tom Tromey  <tom@tromey.com>
10131
10132         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10133         (union type_stack_elt) <typelist_val>: Now a pointer to
10134         std::vector.
10135         (type_stack_cleanup): Don't declare.
10136         (push_typelist): Update.
10137         * parse.c (pop_typelist): Return a std::vector.
10138         (push_typelist): Take a std::vector.
10139         (follow_types): Update.  Do not free args.
10140         (type_stack_cleanup): Remove.
10141         * c-exp.y (struct c_parse_state): New.
10142         (cpstate): New global.
10143         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10144         (nonempty_typelist): Update.
10145         (func_mod): Create a new vector.
10146         (c_parse): Create a c_parse_state.
10147         (check_parameter_typelist): Do not delete params.
10148         (function_method): Update.  Do not delete type_list.
10149
10150 2019-01-06  Tom Tromey  <tom@tromey.com>
10151
10152         PR gdb/28155:
10153         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10154         check_typedef.
10155         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10156         (print_return_value): Likewise.
10157
10158 2019-01-05  Tom Tromey  <tom@tromey.com>
10159
10160         * contrib/cleanup_check.py: Remove.
10161         * contrib/gcc-with-excheck: Remove.
10162         * contrib/exsummary.py: Remove.
10163         * contrib/excheck.py: Remove.
10164
10165 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10166
10167         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10168         NULL. Initialize tpprev to NULL instead of assigning it
10169         to NULL on the next statement.
10170         * windows-nat.c (windows_delete_thread): Remove check for
10171         main_thread_id before printing thread exit notifications.
10172         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10173         Remove thread ID check against main_thread_id.
10174         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10175         windows_delete_thread.
10176         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10177
10178 2019-01-04  Tom Tromey  <tom@tromey.com>
10179
10180         * compile/compile.c (_initialize_compile): Use upper case for
10181         metasyntactic variables.
10182         * symmisc.c (_initialize_symmisc): Use upper case for
10183         metasyntactic variables.
10184         * psymtab.c (_initialize_psymtab): Use upper case for
10185         metasyntactic variables.
10186         * demangle.c (demangle_command): Use upper case for metasyntactic
10187         variables.
10188         (_initialize_demangler): Likewise.
10189         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10190         variables.
10191
10192 2019-01-03  Tom Tromey  <tom@tromey.com>
10193
10194         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10195
10196 2019-01-03  Tom Tromey  <tom@tromey.com>
10197
10198         * python/py-symtab.c (salpy_str): Update.
10199         (struct salpy_sal_object) <symtab>: Now a PyObject.
10200         (salpy_dealloc): Update.
10201         (del_objfile_sal): Use gdbpy_ref.
10202
10203 2019-01-03  Tom Tromey  <tom@tromey.com>
10204
10205         * python/py-type.c (convert_field): Use new_reference.  Return
10206         gdbpy_ref.
10207         (make_fielditem): Return gdbpy_ref.
10208         (typy_fields): Update.
10209         (typy_getitem): Update.
10210         (field_name): Return gdbpy_ref.  Use new_reference.
10211         (typy_iterator_iternext): Update.
10212
10213 2019-01-03  Tom Tromey  <tom@tromey.com>
10214
10215         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10216
10217 2019-01-03  Tom Tromey  <tom@tromey.com>
10218
10219         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10220         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10221         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10222         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10223         (pspy_set_type_printers): Likewise.
10224         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10225         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10226         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10227         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10228         (objfpy_set_type_printers): Likewise.
10229
10230 2019-01-03  Tom Tromey  <tom@tromey.com>
10231
10232         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10233         (gdbpy_print_stack): Use gdbpy_err_fetch.
10234         * python/python-internal.h (class gdbpy_err_fetch): New class.
10235         (class gdbpy_enter) <m_error_type, m_error_value,
10236         m_error_traceback>: Remove.
10237         <m_error>: New member.
10238         (gdbpy_exception_to_string): Don't declare.
10239         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10240         * python/py-value.c (convert_value_from_python): Use
10241         gdbpy_err_fetch.
10242         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10243         gdbpy_exception_to_string.
10244         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10245         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10246         gdbpy_err_fetch.
10247
10248 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10249
10250         * linux-nat.c (delete_lwp_cleanup): Delete.
10251         (struct lwp_deleter): New struct.
10252         (lwp_info_up): New typedef.
10253         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10254         lwp_info_up.
10255
10256 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10257
10258         * linux-fork.c (class scoped_switch_fork_info): New class.
10259         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10260
10261 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10262
10263         * valops.c (find_overload_match): Remove use of null_cleanup, and
10264         calls to do_cleanups.
10265
10266 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10267
10268         * compile/compile-cplus-types.c
10269         (compile_cplus_instance::decl_name): Handle changes to
10270         cp_func_name.
10271         * cp-support.c (cp_func_name): Update header comment, update
10272         return type.
10273         * cp-support.h (cp_func_name): Update return type in declaration.
10274         * valops.c (find_overload_match): Move temp_func local to top
10275         level of function and change its type.  Use temp_func to hold and
10276         delete temporary string obtained from cp_func_name.
10277
10278 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10279
10280         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10281         gdb::char_vector, remove cleanup, and update uses of `msg`.
10282
10283 2019-01-03  Jim Wilson  <jimw@sifive.com>
10284
10285         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10286
10287 2019-01-02  Tom Tromey  <tom@tromey.com>
10288
10289         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10290         (tdesc_parse_xml): Remove cleanups.
10291         * target-descriptions.h (make_cleanup_free_target_description):
10292         Don't declare.
10293         (target_desc_deleter): New struct.
10294         (target_desc_up): New typedef.
10295         * target-descriptions.c (target_desc_deleter::operator()): Rename
10296         from free_target_description.
10297         (make_cleanup_free_target_description): Remove.
10298
10299 2019-01-02  Tom Tromey  <tom@tromey.com>
10300
10301         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10302         constructor, destructor.
10303         (linespec_parser): Remove typedef.
10304         (~linespec_parser): Rename from linespec_parser_delete.
10305         (linespec_lex_to_end, linespec_complete_label)
10306         (linespec_complete): Update.
10307         (decode_line_full): Remove cleanups.
10308         (decode_line_1): Update.
10309
10310 2019-01-02  Tom Tromey  <tom@tromey.com>
10311
10312         * python/python-internal.h (inferior_to_inferior_object): Change
10313         return type.
10314         * python/py-exitedevent.c (create_exited_event_object): Update.
10315         * python/py-inferior.c (inferior_to_inferior_object): Return
10316         gdbpy_ref.
10317         (python_new_inferior, python_inferior_deleted)
10318         (thread_to_thread_object, delete_thread_object)
10319         (build_inferior_list, gdbpy_selected_inferior): Update.
10320         * python/py-infthread.c (create_thread_object): Update.  Also fail
10321         if inferior_to_inferior_object fails.
10322
10323 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10324
10325         * inferior.h (class inferior) <displaced_step_state>: New field.
10326         * infrun.h (struct displaced_step_state): Move here from
10327         infrun.c.  Initialize fields, add constructor.
10328         <inf>: Remove field.
10329         <reset>: New method.
10330         * infrun.c (struct displaced_step_inferior_state): Move to
10331         infrun.h.
10332         (displaced_step_inferior_states): Remove.
10333         (get_displaced_stepping_state): Adust.
10334         (displaced_step_in_progress_any_inferior): Adjust.
10335         (displaced_step_in_progress_thread): Adjust.
10336         (displaced_step_in_progress): Adjust.
10337         (add_displaced_stepping_state): Remove.
10338         (get_displaced_step_closure_by_addr): Adjust.
10339         (remove_displaced_stepping_state): Remove.
10340         (infrun_inferior_exit): Call displaced_step_state.reset.
10341         (use_displaced_stepping): Don't check for NULL.
10342         (displaced_step_prepare_throw): Call
10343         get_displaced_stepping_state.
10344         (displaced_step_fixup): Don't check for NULL.
10345         (prepare_for_detach): Don't check for NULL.
10346
10347 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10348
10349         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10350          in case of call that did not complete.
10351
10352 2019-01-02  Andrey Utkin  <autkin@undo.io>
10353
10354         * symfile.c (find_separate_debug_file): Fix search of debug files for
10355         remote debuggee.
10356
10357 2019-01-02  Tom Tromey  <tom@tromey.com>
10358
10359         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10360         indentation.
10361         * python/py-frame.c (frapy_older): Remove cast.
10362         (frapy_newer): Likewise.
10363         * python/py-breakpoint.c (local_setattro): Remove cast.
10364         * python/py-arch.c (archpy_name): Remove local variable.
10365         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10366
10367 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10368
10369         * unittests/basic_string_view/element_access/char/empty.cc:
10370         Fix year range in copyright header.
10371
10372 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10373
10374         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10375         Delete.
10376         <operator==>: Update with for removed field.
10377         <hash>: Likewise.
10378         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10379         <isa_features>: ...this.
10380         <abi_features>: New field.
10381         (riscv_isa_flen): Update comment.
10382         (riscv_abi_xlen): New declaration.
10383         (riscv_abi_flen): New declaration.
10384         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10385         isa_features.
10386         (riscv_abi_xlen): New function.
10387         (riscv_isa_flen): Update to get answer from isa_features.
10388         (riscv_abi_flen): New function.
10389         (riscv_has_fp_abi): Update to get answer from abi_features.
10390         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10391         xlen and flen.
10392         (riscv_call_info) <xlen, flen>: Update comment.
10393         (riscv_call_arg_struct): Remove invalid assertions
10394         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10395         is removed.
10396         (riscv_gdbarch_init): Gather isa features and abi features
10397         separately, ensure both match on the gdbarch when reusing an old
10398         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10399         a target with 64-bit float hardware.
10400
10401 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10402
10403         * source.c (search_command_helper): Stop reverse search
10404         when line 1 has been searched.
10405
10406 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10407
10408         * record-full.c (record_full_base_target::close): Rewrite
10409         record_full_core_buf_list free logic.
10410
10411 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10412
10413         * break-catch-syscall.c (print_one_catch_syscall): xfree
10414         the last text.
10415
10416 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10417
10418         * top.c (print_gdb_version): Update Copyright year in version
10419         message.
10420
10421 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10422
10423         Update copyright year range in all GDB files.
10424
10425 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10426
10427         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10428
10429 For older changes see ChangeLog-2018.
10430 \f
10431 Local Variables:
10432 mode: change-log
10433 left-margin: 8
10434 fill-column: 74
10435 version-control: never
10436 coding: utf-8
10437 End:
10438