gdb/ChangeLog

   1 2019-07-22  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
   4         Don't self-assign.
   5
   6 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
   7
   8         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
   9         type_print.
  10
  11 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  12
  13         * symtab.c (search_symbols): Adjust msymbol matching type arrays
  14         so that GDB doesn't match any msymbols when searching in the
  15         TYPES_DOMAIN.
  16         (print_symbol_info): Print using typedef_print or type_print based
  17         on the type of the symbol.  Add updated FIXME comment moved from...
  18         (_initialize_symtab): ... move and update FIXME comment to above.
  19
  20 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  21
  22         * NEWS: Mention adding -q option to "info types".
  23         * symtab.c (struct info_types_options): New struct.
  24         (info_types_options_defs): New variable.
  25         (make_info_types_options_def_group): New function.
  26         (info_types_command): Use gdb::option framework to parse options.
  27         (info_types_command_completer): New function.
  28         (_initialize_symtab): Extend the help text on "info types" and
  29         register command completer.
  30
  31 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
  32
  33         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
  34         (lookup_symbol_in_objfile): Change int to block_enum and add a
  35         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
  36
  37 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
  38
  39         * MAINTAINERS (Write After Approval): Add self.
  40
  41 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
  42
  43         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
  44         instruction to the dummy code region.
  45
  46 2019-07-19  Tom Tromey  <tromey@adacore.com>
  47
  48         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
  49         (ARGSUSED, PARAMS, __func__): Remove rules.
  50
  51 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  52
  53         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
  54         * features/arm/arm-with-iwmmxt.c: Remove.
  55         * features/arm/arm-with-iwmmxt.xml: Remove.
  56         * features/arm/arm-with-m-fpa-layout.c: Remove.
  57         * features/arm/arm-with-m-fpa-layout.xml: Remove.
  58         * features/arm/arm-with-m-vfp-d16.c: Remove.
  59         * features/arm/arm-with-m-vfp-d16.xml: Remove.
  60         * features/arm/arm-with-m.c: Remove.
  61         * features/arm/arm-with-m.xml: Remove.
  62         * features/arm/arm-with-neon.c: Remove.
  63         * features/arm/arm-with-neon.xml: Remove.
  64         * features/arm/arm-with-vfpv2.c: Remove.
  65         * features/arm/arm-with-vfpv2.xml: Remove.
  66         * features/arm/arm-with-vfpv3.c: Remove.
  67         * features/arm/arm-with-vfpv3.xml: Remove.
  68
  69 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  70
  71         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
  72
  73 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  74
  75         * arch/aarch32.c (aarch32_create_target_description): Create
  76         target descriptions using features.
  77         * arch/arm.c (arm_create_target_description)
  78         (arm_create_mprofile_target_description): Likewise.
  79         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
  80
  81 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  82
  83         * Makefile.in: Add new files.
  84         * aarch32-tdep.c: New file.
  85         * aarch32-tdep.h: New file.
  86         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  87         Call aarch32_read_description.
  88         * arch/aarch32.c: New file.
  89         * arch/aarch32.h: New file.
  90         * arch/arm.c (arm_create_target_description)
  91         (arm_create_mprofile_target_description): New function.
  92         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
  93         (arm_create_target_description)
  94         (arm_create_mprofile_target_description): New declaration.
  95         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
  96         read_description functions.
  97         * arm-linux-nat.c (arm_linux_nat_target::read_description):
  98         Likewise.
  99         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 100         * arm-tdep.c (tdesc_arm_list): New variable.
 101         (arm_register_g_packet_guesses): Call create description functions.
 102         (arm_read_description) (arm_read_mprofile_description): New
 103         function.
 104         * arm-tdep.h (arm_read_description)
 105         (arm_read_mprofile_description): Add declaration.
 106         * configure.tgt: Add new files.
 107
 108 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 109
 110         * top.c (new_ui_command): Open specified terminal just once.
 111
 112 2019-07-18  Tom Tromey  <tromey@adacore.com>
 113
 114         * symtab.c (main_name): Constify return type.
 115         * symfile.c (set_initial_language): Update.
 116         * symtab.h (main_name): Constify return type.
 117
 118 2019-07-17  Tom Tromey  <tom@tromey.com>
 119
 120         * tui/tui-winsource.c (tui_update_source_window)
 121         (tui_update_source_window_as_is)
 122         (tui_update_source_windows_with_line): Remove return.
 123         * tui/tui-disasm.c (tui_show_disassem)
 124         (tui_show_disassem_and_update_source): Remove return.
 125         * tui/tui.c (tui_reset): Remove return.
 126         * tui/tui-wingeneral.c
 127         (tui_check_and_display_highlight_if_needed): Remove return.
 128
 129 2019-07-17  Tom Tromey  <tom@tromey.com>
 130
 131         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 132
 133 2019-07-17  Tom Tromey  <tom@tromey.com>
 134
 135         * tui/tui-winsource.h (struct tui_exec_info_window)
 136         (struct tui_source_window_base): Move from tui-data.h.
 137         * tui/tui-winsource.c: Move many method definitions from
 138         elsewhere.  Remove "structuring" comments.
 139         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 140         (tui_source_window_base::refresh_window): Move to
 141         tui-winsource.c.
 142         * tui/tui-win.c (tui_source_window_base::refresh_all)
 143         (tui_source_window_base::update_tab_width)
 144         (tui_source_window_base::set_new_height)
 145         (tui_source_window_base::do_make_visible_with_new_height): Move to
 146         tui-winsource.c.
 147         * tui/tui-source.h: Update.
 148         * tui/tui-source.c (tui_source_window_base::reset): Move to
 149         tui-winsource.c.
 150         * tui/tui-disasm.h: Update.
 151         * tui/tui-data.h (struct tui_exec_info_window): Move to
 152         tui-winsource.h.
 153         (struct tui_source_window_base): Likewise.
 154         * tui/tui-data.c (tui_source_window_base::clear_detail)
 155         (tui_source_window_base, ~tui_source_window_base): Move to
 156         tui-winsource.c.
 157
 158 2019-07-17  Tom Tromey  <tom@tromey.com>
 159
 160         * tui/tui-win.c (tui_resize_all)
 161         (tui_source_window_base::update_tab_width)
 162         (tui_adjust_win_heights): Update.
 163         (tui_win_info::make_invisible_and_set_new_height): Rename from
 164         make_invisible_and_set_new_height.
 165         * tui/tui-data.h (struct tui_win_info)
 166         <make_invisible_and_set_new_height>: New method.
 167
 168 2019-07-17  Tom Tromey  <tom@tromey.com>
 169
 170         * tui/tui.c: Update.
 171         * tui/tui-source.h (struct tui_source_window): Move from
 172         tui-data.h.
 173         * tui/tui-layout.c: Update.
 174         * tui/tui-disasm.c: Update.
 175         * tui/tui-data.h (struct tui_source_window): Move to
 176         tui-source.h.
 177
 178 2019-07-17  Tom Tromey  <tom@tromey.com>
 179
 180         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 181         tui-data.h.
 182         * tui/tui-data.h (struct tui_disasm_window): Move to
 183         tui-disasm.h.
 184
 185 2019-07-17  Tom Tromey  <tom@tromey.com>
 186
 187         * tui/tui-regs.h (struct tui_data_item_window): Move from
 188         tui-data.h.
 189         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 190         * tui/tui-data.h (struct tui_data_item_window): Move to
 191         tui-regs.h.
 192         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 193
 194 2019-07-17  Tom Tromey  <tom@tromey.com>
 195
 196         * tui/tui.c: Update.
 197         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 198         (tui_cmd_window::max_height): Move to tui-command.c.
 199         * tui/tui-layout.c: Update.
 200         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 201         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 202         tui-command.c.
 203         * tui/tui-command.h (struct tui_cmd_window): Move from
 204         tui-data.h.
 205         * tui/tui-command.c: Remove "structuring" comments.
 206         (tui_cmd_window::clear_detail)
 207         (tui_cmd_window::do_make_visible_with_new_height)
 208         (tui_cmd_window::max_height): Move from elsewhere.
 209
 210 2019-07-17  Tom Tromey  <tom@tromey.com>
 211
 212         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 213         Now static.
 214         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 215         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 216
 217 2019-07-17  Tom Tromey  <tom@tromey.com>
 218
 219         * tui/tui.c: Update.
 220         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 221         tui-regs.c.
 222         * tui/tui-windata.h: Remove file.
 223         * tui/tui-windata.c: Remove file.
 224         * tui/tui-win.c (tui_data_window::set_new_height)
 225         (tui_data_window::do_make_visible_with_new_height): Move to
 226         tui-regs.c.
 227         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 228         * tui/tui-regs.c: Remove "structuring" comments.
 229         (tui_data_window::first_data_item_displayed)
 230         (tui_data_window::delete_data_content_windows)
 231         (tui_data_window::erase_data_content)
 232         (tui_data_window::display_all_data)
 233         (tui_data_window::refresh_all)
 234         (tui_data_window::do_scroll_vertical)
 235         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 236         (tui_data_window::do_make_visible_with_new_height)
 237         (tui_data_window::refresh_window): Move from elsewhere.
 238         (_initialize_tui_regs): Move to end of file.
 239         * tui/tui-layout.c: Update.
 240         * tui/tui-hooks.c: Update.
 241         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 242         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 243         tui-regs.c.
 244         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 245
 246 2019-07-17  Tom Tromey  <tom@tromey.com>
 247
 248         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 249         seen.
 250
 251 2019-07-17  Tom Tromey  <tom@tromey.com>
 252
 253         * tui/tui-win.c (tui_source_window_base::set_new_height)
 254         (tui_source_window_base::do_make_visible_with_new_height): Use
 255         m_has_locator field directly.
 256         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 257         method.
 258         (struct tui_source_window_base) <has_locator>: Likewise.
 259
 260 2019-07-17  Tom Tromey  <tom@tromey.com>
 261
 262         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 263         Don't declare.
 264         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 265         Remove.
 266         * tui/tui-win.c (tui_source_window_base::set_new_height)
 267         (tui_source_window_base::set_new_height)
 268         (make_invisible_and_set_new_height)
 269         (tui_source_window_base::do_make_visible_with_new_height)
 270         (tui_source_window_base::do_make_visible_with_new_height):
 271         Update.
 272         * tui/tui-layout.c (show_source_disasm_command, show_data)
 273         (show_source_or_disasm_and_command): Update.
 274         * tui/tui-layout.c (show_layout): Update.
 275
 276 2019-07-17  Tom Tromey  <tom@tromey.com>
 277
 278         * tui/tui-layout.c (make_data_window): Remove.
 279         (show_data): Unify creation and re-initialization cases.
 280
 281 2019-07-17  Tom Tromey  <tom@tromey.com>
 282
 283         * tui/tui-layout.c (make_source_window, make_disasm_window):
 284         Remove.
 285         (show_data): Unify creation and re-initialization cases.
 286
 287 2019-07-17  Tom Tromey  <tom@tromey.com>
 288
 289         * tui/tui-layout.c (make_command_window): Remove.
 290         (show_source_disasm_command, show_source_or_disasm_and_command):
 291         Unify creation and re-initialization cases.
 292
 293 2019-07-17  Tom Tromey  <tom@tromey.com>
 294
 295         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 296         creation and re-initialization cases.
 297
 298 2019-07-17  Tom Tromey  <tom@tromey.com>
 299
 300         * tui/tui-regs.c (tui_get_register): Return void.
 301
 302 2019-07-17  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 305         Simplify.
 306
 307 2019-07-17  Tom Tromey  <tom@tromey.com>
 308
 309         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 310         resetting.
 311
 312 2019-07-17  Tom Tromey  <tom@tromey.com>
 313
 314         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 315         * tui/tui-regs.c (tui_reg_layout): New function.
 316         (tui_show_registers, tui_reg_command): Use it.
 317         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 318         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 319         parameters.
 320         (tui_layout_command): Remove.
 321
 322 2019-07-17  Tom Tromey  <tom@tromey.com>
 323
 324         * tui/tui-layout.h (tui/tui-layout): Return void.
 325         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 326
 327 2019-07-17  Tom Tromey  <tom@tromey.com>
 328
 329         * tui/tui-layout.c (show_source_disasm_command, show_data):
 330         Update.
 331         (reset_locator): Remove.
 332         (show_source_or_disasm_and_command): Update.
 333
 334 2019-07-17  Tom Tromey  <tom@tromey.com>
 335
 336         * tui/tui-source.c (tui_source_window_base::reset): Remove
 337         win_type parameter.
 338         * tui/tui-layout.c (make_command_window, make_source_window)
 339         (make_disasm_window, make_data_window)
 340         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 341         (reset_locator, show_source_or_disasm_and_command): Update.
 342         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 343         win_type parameter.
 344         (struct tui_source_window_base) <reset>: Likewise.
 345
 346 2019-07-17  Tom Tromey  <tom@tromey.com>
 347
 348         * tui/tui-layout.c (show_source_disasm_command): Use
 349         reset_locator.
 350         (reset_locator): New function.
 351         (init_and_make_win): Remove.
 352         (show_source_or_disasm_and_command): Use reset_locator.
 353
 354 2019-07-17  Tom Tromey  <tom@tromey.com>
 355
 356         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 357         condition.
 358         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 359         Remove condition.
 360         * tui/tui-source.c (tui_source_window_base::reset): New method.
 361         * tui/tui-layout.c (make_command_window): Don't call
 362         init_and_make_win.
 363         (make_source_window, make_disasm_window): Don't call
 364         make_source_or_disasm_window.
 365         (make_data_window): Don't call init_and_make_win.  Change calling
 366         convention.
 367         (show_source_disasm_command, show_data): Simplify.
 368         (make_source_or_disasm_window): Remove.
 369         (show_source_or_disasm_and_command): Simplify.
 370         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 371         (struct tui_source_window_base) <reset>: Likewise.
 372         <execution_info>: Remove initializer.
 373         * tui/tui-data.c (tui_source_window_base): Initialize
 374         execution_info.
 375
 376 2019-07-17  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 379         variable.
 380
 381 2019-07-17  Tom Tromey  <tom@tromey.com>
 382
 383         * tui/tui.c (tui_rl_other_window): Update.
 384         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 385         superclass method first.  Always iterate over regs_content.
 386         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 387         method.
 388         * tui/tui-win.c (tui_set_focus_command): Update.
 389
 390 2019-07-17  Tom Tromey  <tom@tromey.com>
 391
 392         * tui/tui-win.c (tui_set_focus_command): Rename from
 393         tui_set_focus.  Call tui_enable.
 394         (tui_set_focus_command): Remove.
 395
 396 2019-07-17  Tom Tromey  <tom@tromey.com>
 397
 398         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 399         refresh_window.
 400         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 401         touchwin.
 402         (tui_data_window::refresh_window): Call refresh_window on data
 403         items.  Always call superclass refresh_window.
 404         (tui_win_info::refresh): Remove.
 405         (tui_source_window_base::refresh_window): Update.
 406         (tui_refresh_all): Update.
 407         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 408         refresh_window.
 409         (show_source_or_disasm_and_command): Likewise.
 410         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 411         (struct tui_source_window_base) <refresh>: Likewise.
 412
 413 2019-07-17  Tom Tromey  <tom@tromey.com>
 414
 415         * tui/tui-winsource.c (tui_clear_source_content)
 416         (tui_show_source_content): Update.
 417         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 418         whether content is empty.
 419         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 420         Remove.
 421
 422 2019-07-17  Tom Tromey  <tom@tromey.com>
 423
 424         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 425         window's contents.
 426         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 427         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 428
 429 2019-07-17  Tom Tromey  <tom@tromey.com>
 430
 431         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 432         (struct tui_data_item_window): Update.
 433
 434 2019-07-17  Tom Tromey  <tom@tromey.com>
 435
 436         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 437         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 438         defines.
 439
 440 2019-07-17  Tom Tromey  <tom@tromey.com>
 441
 442         * tui/tui-winsource.h (tui_erase_source_content)
 443         (tui_clear_source_content): Remove "display_prompt" parameter.
 444         * tui/tui-winsource.c (tui_update_source_window_as_is)
 445         (tui_update_source_windows_with_addr): Update.
 446         (tui_clear_source_content): Remove "display_prompt" parameter.
 447         (tui_erase_source_content): Likewise.  Simplify.
 448         (tui_show_source_content): Update.
 449         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 450         * tui/tui-stack.c (tui_show_frame_info): Update.
 451         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 452         Remove defines.
 453
 454 2019-07-17  Tom Tromey  <tom@tromey.com>
 455
 456         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 457         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 458         parameter.
 459         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 460         parameter.
 461
 462 2019-07-17  Tom Tromey  <tom@tromey.com>
 463
 464         * tui/tui-winsource.c (tui_clear_source_content)
 465         (tui_show_source_content, tui_show_exec_info_content)
 466         (tui_clear_exec_info_content): Update.
 467         * tui/tui-stack.c (tui_show_locator_content): Update.
 468         (tui_show_frame_info): Update.
 469         * tui/tui-source.h (tui_source_window): Don't declare.
 470         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 471         from tui_source_is_displayed.
 472         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 473         Remove field.
 474         (struct tui_source_window_base) <content_in_use>: New field.  Now
 475         bool.
 476         (struct tui_source_window) <showing_source_p>: New method.
 477         (TUI_SRC_WIN): Change cast.
 478         * tui/tui-data.c (tui_initialize_static_data): Update.
 479
 480 2019-07-17  Tom Tromey  <tom@tromey.com>
 481
 482         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 483         location_matches_p.
 484         * tui/tui-source.c (tui_source_window::location_matches_p): New
 485         method.
 486         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 487         method.
 488         * tui/tui-data.h (struct tui_source_window_base)
 489         <location_matches_p>: New method.
 490         (struct tui_source_window, struct tui_disasm_window)
 491         <location_matches_p>: Likewise.
 492
 493 2019-07-17  Tom Tromey  <tom@tromey.com>
 494
 495         * tui/tui-win.c (tui_set_win_height_command): Rename from
 496         tui_set_win_height.
 497         (tui_set_win_height_command): Remove.
 498
 499 2019-07-17  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-source.c (tui_source_window): New constructor.  Add
 502         observer.
 503         (~tui_source_window): New destructor.
 504         (tui_source_window::style_changed): New method.
 505         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 506         (tui_attach_detach_observers): Update.
 507         * tui/tui-data.h (struct tui_source_window): Make constructor not
 508         inline.  Add destructor.
 509         (struct tui_source_window) <style_changed>: New method.
 510         <m_observable>: New member.
 511
 512 2019-07-17  Tom Tromey  <tom@tromey.com>
 513
 514         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 515         * tui/tui-win.c (tui_resize_all): Fix typo.
 516
 517 2019-07-17  Tom Tromey  <tom@tromey.com>
 518
 519         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 520         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 521         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 522         * tui/tui-win.c (window_name_completer): Use foreach.
 523         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 524         (update_tab_width): Likewise.
 525         * tui/tui-layout.c (show_layout): Update.
 526         * tui/tui-data.h (class tui_window_iterator): New.
 527         (struct all_tui_windows): New.
 528         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 529
 530 2019-07-17  Tom Tromey  <tom@tromey.com>
 531
 532         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 533         parameter.  Don't reference globals.
 534         (tui_reg_command): Update.
 535
 536 2019-07-17  Tom Tromey  <tom@tromey.com>
 537
 538         * tui/tui-regs.c (tui_show_registers): Simplify.
 539
 540 2019-07-17  Tom Tromey  <tom@tromey.com>
 541
 542         * tui/tui-regs.c (tui_show_registers): Update.
 543         (tui_show_register_group): Add win_info parameter.
 544
 545 2019-07-17  Tom Tromey  <tom@tromey.com>
 546
 547         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 548         Rename from tui_display_reg_element_at_line.
 549         (tui_data_window::display_registers_from_line): Update.
 550         * tui/tui-data.h (struct tui_data_window)
 551         <display_reg_element_at_line>: New method.
 552
 553 2019-07-17  Tom Tromey  <tom@tromey.com>
 554
 555         * tui/tui-regs.h (tui_display_registers_from)
 556         (tui_display_registers_from_line): Don't declare.
 557         * tui/tui-windata.c (tui_data_window::display_all_data)
 558         (tui_data_window::refresh_all)
 559         (tui_data_window::do_scroll_vertical): Update.
 560         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 561         from tui_display_registers_from.
 562         (tui_display_reg_element_at_line): Update.
 563         (tui_data_window::display_registers_from_line): Rename from
 564         tui_display_registers_from_line.
 565         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 566         display_registers_from_line>: New methods.
 567
 568 2019-07-17  Tom Tromey  <tom@tromey.com>
 569
 570         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 571         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 572         from tui_erase_data_content.
 573         (tui_data_window::display_all_data)
 574         (tui_data_window::refresh_all)
 575         (tui_data_window::do_scroll_vertical): Update.
 576         * tui/tui-regs.c (tui_show_registers): Update.
 577         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 578         New method.
 579
 580 2019-07-17  Tom Tromey  <tom@tromey.com>
 581
 582         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 583         declare.
 584         * tui/tui-windata.c
 585         (tui_data_window::delete_data_content_windows): Rename from
 586         tui_delete_data_content_windows.
 587         (tui_data_window::display_all_data)
 588         (tui_data_window::do_scroll_vertical): Update.
 589         * tui/tui-data.h (struct tui_data_window)
 590         <delete_data_content_windows>: New method.
 591
 592 2019-07-17  Tom Tromey  <tom@tromey.com>
 593
 594         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 595         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 596
 597 2019-07-17  Tom Tromey  <tom@tromey.com>
 598
 599         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 600         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 601         from tui_display_all_data.
 602         * tui/tui-win.c
 603         (tui_data_window::do_make_visible_with_new_height): Update.
 604         * tui/tui-regs.c (tui_show_registers): Update.
 605         * tui/tui-layout.c (tui_set_layout): Update.
 606         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 607         method.
 608
 609 2019-07-17  Tom Tromey  <tom@tromey.com>
 610
 611         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 612         * tui/tui-windata.c (tui_display_data_from): Remove.
 613         (tui_data_window::refresh_all): Update.
 614
 615 2019-07-17  Tom Tromey  <tom@tromey.com>
 616
 617         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 618         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 619         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 620         tui_display_registers_from_line.
 621         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 622         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 623         "force_display" parameter.
 624
 625 2019-07-17  Tom Tromey  <tom@tromey.com>
 626
 627         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 628         declare.
 629         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 630         Rename from tui_first_reg_element_no_inline.
 631         (tui_display_reg_element_at_line)
 632         (tui_display_registers_from_line): Update.
 633         * tui/tui-data.h (struct tui_data_window)
 634         <first_reg_element_no_inline>: New method.
 635
 636 2019-07-17  Tom Tromey  <tom@tromey.com>
 637
 638         * tui/tui-windata.c (tui_display_data_from)
 639         (tui_data_window::do_scroll_vertical): Update.
 640         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 641         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 642         Rename from tui_line_from_reg_element_no.
 643         (tui_display_registers_from_line): Update.
 644         * tui/tui-data.h (struct tui_data_window)
 645         <line_from_reg_element_no>: New method.
 646
 647 2019-07-17  Tom Tromey  <tom@tromey.com>
 648
 649         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 650         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 651         tui_last_regs_line_no.
 652         (tui_display_reg_element_at_line)
 653         (tui_display_registers_from_line): Update.
 654         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 655         method.
 656
 657 2019-07-17  Tom Tromey  <tom@tromey.com>
 658
 659         PR tui/24722:
 660         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 661         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 662         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 663         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 664         (tui_update_breakpoint_info): Likewise.
 665         * tui/tui-hooks.c (tui_event_create_breakpoint)
 666         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 667         Update.
 668
 669 2019-07-17  Tom Tromey  <tom@tromey.com>
 670
 671         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 672
 673 2019-07-17  Tom Tromey  <tom@tromey.com>
 674
 675         * tui/tui-winsource.c (tui_update_source_window_as_is)
 676         (tui_update_source_windows_with_addr): Update.
 677         * tui/tui-source.h (tui_set_source_content)
 678         (tui_show_symtab_source): Add "win_info" parameter.
 679         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 680         parameter.
 681         (tui_show_symtab_source): Likewise.
 682
 683 2019-07-17  Tom Tromey  <tom@tromey.com>
 684
 685         * tui/tui-wingeneral.c
 686         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 687
 688 2019-07-17  Tom Tromey  <tom@tromey.com>
 689
 690         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 691         (struct tui_cmd_window) <can_scroll>: New method.
 692         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 693         method.
 694
 695 2019-07-17  Tom Tromey  <tromey@adacore.com>
 696
 697         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 698         do_field_signed>: Rename.  Change type of "value".
 699         * ui-out.c (ui_out::field_signed): Rename from field_int.
 700         Change type of "value".
 701         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 702         type of "value".
 703         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 704         do_field_int.  Change type of "value".
 705         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 706         do_field_int.  Change type of "value".
 707         * tracepoint.c (trace_status_mi, tfind_1)
 708         (print_one_static_tracepoint_marker): Update.
 709         * thread.c (print_thread_info_1, print_selected_thread_frame):
 710         Update.
 711         * stack.c (print_frame, print_frame_info): Update.
 712         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 713         Update.
 714         * source.c (print_source_lines_base): Update.
 715         * skip.c (info_skip_command): Update.
 716         * record-btrace.c (btrace_ui_out_decode_error)
 717         (btrace_call_history_src_line): Update.
 718         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 719         Update.
 720         * progspace.c (print_program_space): Update.
 721         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 722         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 723         do_field_int.  Change type of "value".
 724         * mi/mi-out.c (mi_ui_out::do_table_begin)
 725         (mi_ui_out::do_table_header): Update.
 726         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 727         type of "value".
 728         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 729         (mi_cmd_data_list_changed_registers, output_register)
 730         (mi_cmd_data_read_memory, mi_load_progress)
 731         (mi_cmd_trace_frame_collected): Update.
 732         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 733         Update.
 734         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 735         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 736         (mi_cmd_var_list_children, varobj_update_one): Update.
 737         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 738         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 739         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 740         * inferior.c (print_inferior): Update.
 741         * gdb_bfd.c (print_one_bfd): Update.
 742         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 743         Update.
 744         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 745         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 746         do_field_int.  Change type of "value".
 747         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 748         do_field_int.  Change type of "value".
 749         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 750         (print_one_breakpoint_location, print_it_catch_fork)
 751         (print_one_catch_fork, print_it_catch_vfork)
 752         (print_one_catch_vfork, print_it_catch_solib)
 753         (print_it_catch_exec, print_it_ranged_breakpoint)
 754         (print_mention_watchpoint, print_mention_masked_watchpoint)
 755         (bkpt_print_it, update_static_tracepoint): Update.
 756         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 757         * break-catch-syscall.c (print_it_catch_syscall): Update.
 758         * ada-tasks.c (print_ada_task_info): Update.
 759         * ada-lang.c (print_it_exception, print_mention_exception):
 760         Update.
 761
 762 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 763
 764         PR breakpoints/24541
 765         * gdbarch.c: Regenerate.
 766         * gdbarch.h: Regenerate.
 767         * gdbarch.sh: Adjust return type and parameter types for
 768         'stap_adjust_register'.
 769         (i386_stap_adjust_register): Adjust signature and return new
 770         register name.
 771         * stap-probe.c (stap_parse_register_operand): Adjust use of
 772         'gdbarch_stap_adjust_register'.
 773
 774 2019-07-17  Tom Tromey  <tromey@adacore.com>
 775
 776         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 777         declare VEC.
 778         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 779         std::vector.
 780         (struct s390_process_info): Add initializers.
 781         (s390_add_process): Use new.
 782         (s390_linux_nat_target::low_forget_process): Use delete.
 783         (s390_linux_nat_target::low_new_fork)
 784         (s390_linux_nat_target::stopped_by_watchpoint)
 785         (s390_linux_nat_target::low_prepare_to_resume)
 786         (s390_linux_nat_target::insert_watchpoint)
 787         (s390_linux_nat_target::insert_hw_breakpoint)
 788         (s390_linux_nat_target::remove_watchpoint)
 789         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 790
 791 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 792
 793         * aarch64-fbsd-nat.c: Include regcache.h.
 794         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 795         argument.
 796         (aarch64_fbsd_nat_target::fetch_registers)
 797         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 798         variable.
 799         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 800
 801 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 802
 803         * fbsd-nat.c: Include gdbarch.h.
 804
 805 2019-07-15  Tom Tromey  <tromey@adacore.com>
 806
 807         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 808
 809 2019-07-15  Tom Tromey  <tromey@adacore.com>
 810
 811         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 812         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 813         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 814         * cli-out.c (cli_ui_out::do_field_int): New method.
 815         * ui-out.c (ui_out::field_unsigned): New method.
 816         * symfile.c (generic_load): Use field_unsigned.
 817         (print_transfer_performance): Likewise.
 818         * record-btrace.c (ui_out_field_uint): Remove.
 819         (btrace_call_history_insn_range, btrace_call_history): Use
 820         field_unsigned.
 821         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 822         field_unsigned.
 823         * ui-out.h (class ui_out) <field_unsigned>: New method.
 824         <do_field_unsigned>: Likewise.
 825
 826 2019-07-15  Tom Tromey  <tromey@adacore.com>
 827
 828         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 829         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 830         * target.c (flash_erase_command): Use field_string.
 831         * infrun.c (print_signal_received_reason): Use field_string.
 832         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 833         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 834         field_string.
 835         * ada-tasks.c (print_ada_task_info): Use field_string.
 836
 837 2019-07-15  Tom Tromey  <tromey@adacore.com>
 838
 839         * target.c (flash_erase_command): Use field_core_addr.
 840         * symfile.c (generic_load): Use field_core_addr.
 841         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 842         Use field_core_addr.
 843         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 844         field_core_addr.
 845
 846 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 847
 848         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 849         value if its desired type is smaller than a CORE_ADDR and signed.
 850
 851 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 852
 853         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 854         of changes to field names, and use new is_reference field to
 855         decide if a property is a reference or not.
 856         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 857         field.
 858         (struct dwarf2_property_baton): Update header comment, rename
 859         'referenced_type' to 'property_type' and update comments.
 860         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 861         default property type, store in property baton, update to take
 862         accound of renamed field.
 863         (read_func_scope): Update call to attr_to_dynamic_prop.
 864         (read_array_type): Likewise.
 865         (dwarf2_per_cu_addr_sized_int_type): New function.
 866         (read_subrange_index_type): Move type finding code to
 867         dwarf2_per_cu_addr_sized_int_type.
 868         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 869         (dwarf2_per_cu_addr_type): New function.
 870         (set_die_type): Update calls to attr_to_dynamic_prop.
 871
 872 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 873
 874         * dwarf2read.c (read_subrange_index_type): New function.
 875         (read_subrange_type): Move code into new function and call it.
 876         * gdbtypes.c (create_range_type): Add some asserts.
 877
 878 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 879
 880         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 881         update return statements.
 882         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 883         declaration, and update comment to match.
 884         * gdbtypes.c (resolve_dynamic_array): Update call to
 885         dwarf2_evaluate_property to match new return type.
 886
 887 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 888
 889         * valarith.c (value_subscripted_rvalue): Change lowerbound
 890         parameter type from int to LONGEST.
 891         * value.h (value_subscripted_rvalue): Likewise in declaration.
 892
 893 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 894
 895         * cli/cli-utils.c (info_print_command_completer): New function.
 896         * cli/cli-utils.h: Add 'completer.h' include, and forward
 897         declaration for 'struct cmd_list_element'.
 898         (info_print_command_completer): Declare.
 899         * stack.c (_initialize_stack): Add completer for 'info locals' and
 900         'info args'.
 901         * symtab.c (_initialize_symtab): Add completer for 'info
 902         variables' and 'info functions'.
 903         * NEWS: Mention completion for additional info commands.
 904
 905 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 906
 907         * cli/cli-utils.c (extract_info_print_args): Delete.
 908         (extract_arg_maybe_quoted): Delete.
 909         (info_print_options_defs): New variable.
 910         (make_info_print_options_def_group): New function.
 911         (extract_info_print_options): Define new function.
 912         * cli/cli-utils.h (extract_info_print_args): Delete.
 913         (struct info_print_options): New structure.
 914         (extract_info_print_options): Declare new function.
 915         * stack.c (info_locals_command): Update to use new
 916         extract_info_print_options, also add a header comment.
 917         (info_args_command): Likewise.
 918         * symtab.c (info_variables_command): Likewise.
 919         (info_functions_command): Likewise.
 920
 921 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 922
 923         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 924         to extract string arguments.
 925         * common/common-utils.c (extract_string_maybe_quoted): New function.
 926         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 927
 928 2019-07-11  Tom Tromey  <tromey@adacore.com>
 929
 930         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 931         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 932         * top.h (gdbinit): Don't declare.
 933         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 934         into...
 935         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 936         * top.c (gdb_init): Don't call init_cli_cmds.
 937         (gdbinit): Remove.
 938         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 939
 940 2019-07-11  Tom Tromey  <tromey@adacore.com>
 941
 942         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 943         after it has been moved.
 944
 945 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 946
 947         * valops.c (value_must_coerce_to_target): Change return type to
 948         bool.
 949         * value.h (value_must_coerce_to_target): Likewise.
 950
 951 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 952
 953         * breakpoint.c (is_hardware_watchpoint): Remove
 954         forward-declaration.
 955         (is_masked_watchpoint): Change return type to bool.
 956         (is_tracepoint): Likewise.
 957         (is_breakpoint): Likewise.
 958         (is_hardware_watchpoint): Likewise.
 959         (is_watchpoint): Likewise.
 960         (is_no_memory_software_watchpoint): Likewise.
 961         (is_catchpoint): Likewise.
 962         (breakpoint_1): Make FILTER parameter's return type bool.
 963         is_masked_watchpoint): Change return type to bool.
 964         (save_breakpoints): Make FILTER parameter's return type bool.
 965         * breakpoint.h (is_breakpoint): Change return type to bool.
 966         (is_watchpoint): Likewise.
 967         (is_catchpoint): Likewise.
 968         (is_tracepoint): Likewise.
 969
 970 2019-07-10  Tom Tromey  <tom@tromey.com>
 971
 972         * defs.h: Don't include gdbarch.h.
 973         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 974         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 975         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 976         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 977         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 978         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 979         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 980         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 981         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 982         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 983         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 984         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 985         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 986         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 987         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 988         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 989         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 990         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 991         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 992         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 993         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 994         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 995         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 996         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 997         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 998         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 999         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1000
1001 2019-07-10  Tom Tromey  <tromey@adacore.com>
1002
1003         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1004         * breakpoint.c (init_ada_exception_breakpoint): Register as
1005         bp_catchpoint.
1006         (print_one_breakpoint_location, print_one_breakpoint): Use
1007         is_ada_exception_catchpoint.
1008         * ada-lang.c (class ada_catchpoint_location): Pass
1009         bp_loc_software_breakpoint to bp_location constructor.
1010         (is_ada_exception_catchpoint): New function.
1011
1012 2019-07-10  Tom Tromey  <tromey@adacore.com>
1013
1014         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1015         VEC.
1016         (struct arm_exidx_entry): New method operator<.
1017         (struct arm_exidx_data) <section_maps>: Change type.
1018         (arm_exidx_data_free): Remove.
1019         (arm_exidx_data_key): Change type.  Move lower.
1020         (arm_exidx_new_objfile): Update.
1021         (arm_compare_exidx_entries): Remove.
1022         (arm_find_exidx_entry, _initialize_arm_tdep)
1023
1024 2019-07-10  Tom Tromey  <tromey@adacore.com>
1025
1026         * solib-spu.c (ocl_program_data_key): Change type.
1027         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1028         Update.
1029
1030 2019-07-10  Tom Tromey  <tromey@adacore.com>
1031
1032         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1033         (struct solib_aix_inferior_data) <library_list>: Change type.
1034         (solib_aix_inferior_data_handle): Change type.
1035         (get_solib_aix_inferior_data): Update.
1036         (solib_aix_free_library_list): Remove.
1037         (library_list_start_library): Update.
1038         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1039         return type.
1040         (solib_aix_get_library_list)
1041         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1042         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1043
1044 2019-07-10  Tom Tromey  <tromey@adacore.com>
1045
1046         * solib-dsbt.c (struct dsbt_info): Add initializers.
1047         (solib_dsbt_pspace_data): Change type.
1048         (dsbt_pspace_data_cleanup): Remove.
1049         (get_dsbt_info, _initialize_dsbt_solib): Update.
1050
1051 2019-07-10  Tom Tromey  <tromey@adacore.com>
1052
1053         * spu-tdep.c (spu_overlay_data): Change type.
1054         (spu_get_overlay_table, spu_overlay_new_objfile)
1055         (_initialize_spu_tdep): Update.
1056
1057 2019-07-10  Tom Tromey  <tromey@adacore.com>
1058
1059         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1060         destructor.
1061         (dbx_objfile_data_key): Change type and declare later.
1062         (DBX_SYMFILE_INFO): Rewrite.
1063         * dbxread.c (dbx_objfile_data_key): Change type.
1064         (dbx_symfile_init): Update.
1065         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1066         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1067         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1068
1069 2019-07-10  Tom Tromey  <tromey@adacore.com>
1070
1071         * jit.c (jit_program_space_key): Change type.  Move lower.
1072         (get_jit_program_space_data): Update.
1073         (jit_program_space_data_cleanup): Remove.
1074         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1075         Update.
1076         (struct jit_program_space_data): Add initializers.
1077
1078 2019-07-10  Tom Tromey  <tromey@adacore.com>
1079
1080         * solib-darwin.c (struct darwin_info): Add initializers.
1081         (solib_darwin_pspace_data): Change type.
1082         (darwin_pspace_data_cleanup): Remove.
1083         (get_darwin_info, _initialize_darwin_solib): Update.
1084
1085 2019-07-10  Tom Tromey  <tromey@adacore.com>
1086
1087         * remote-sim.c (struct sim_inferior_data): Add initializers,
1088         constructor, and destructor.
1089         (sim_inferior_data_key): Change type.  Move lower.
1090         (check_for_duplicate_sim_descriptor): Update.
1091         (get_sim_inferior_data): Use new.  Update.
1092         (~sim_inferior_data_cleanup): Rename from
1093         sim_inferior_data_cleanup.  Simplify.
1094         (gdbsim_close_inferior, simulator_command)
1095         (sim_command_completer, _initialize_remote_sim): Update.
1096         (next_pid, INITIAL_PID): Move earlier.
1097
1098 2019-07-10  Tom Tromey  <tromey@adacore.com>
1099
1100         * python/python-internal.h (create_thread_object): Return
1101         gdbpy_ref.
1102         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1103         * python/py-inferior.c (struct threadlist_entry): Add
1104         constructor.
1105         <thread_obj>: Now a gdbpy_ref.
1106         (thread_to_thread_object): Update.
1107         (add_thread_object): Use new.
1108         (delete_thread_object): Use delete.
1109         (infpy_threads): Update.
1110         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1111         GIL.
1112
1113 2019-07-10  Tom Tromey  <tromey@adacore.com>
1114
1115         * valops.c (value_cast): Specialize error message for Ada.
1116
1117 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1118
1119         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1120
1121 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1122
1123         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1124         bpstat_should_step): Return bool, adjust comments.
1125         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1126         bpstat_should_step): Likewise.
1127
1128 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1129
1130         * features/Makefile: Use feature target descriptions for Arm.
1131         * features/arm/arm-core.c: Generate new file.
1132         * features/arm/arm-fpa.c: Likewise.
1133         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1134         * features/arm/arm-m-profile.c: Likewise.
1135         * features/arm/arm-vfpv2.c: Likewise.
1136         * features/arm/arm-vfpv3.c: Likewise.
1137         * features/arm/xscale-iwmmxt.c: Likewise.
1138         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1139
1140 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1141
1142         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1143         ptrace earlier.
1144
1145 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1146
1147         * features/aarch64-pauth.c: Regenerate.
1148
1149 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1150
1151         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1152         bool.
1153         (bpstat_what): Use false instead of 0.
1154
1155 2019-07-09  Pedro Alves  <palves@redhat.com>
1156
1157         * break-catch-throw.c (is_exception_catchpoint): New.
1158         * breakpoint.c (print_one_breakpoint_location): New parameter
1159         'raw_loc'.  Handle it.  Use
1160         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1161         looking at the breakpoint's type.
1162         (print_one_breakpoint): If handling "maint info breakpoints", also
1163         print locations of exception catchpoints.
1164         * breakpoint.h (is_exception_catchpoint): Declare.
1165
1166 2019-07-09  Pedro Alves  <palves@redhat.com>
1167
1168         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1169         "addr" field.
1170         (allocate_location_exception_catchpoint): New.
1171         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1172         (initialize_throw_catchpoint_ops): Install
1173         allocate_location_exception_catchpoint as allocate_location
1174         method.
1175         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1176         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1177         bp_loc_other.
1178         (breakpoint_address_is_meaningful): Delete.
1179         (bl_address_is_meaningful): New.
1180         (breakpoint_locations_match): Adjust comment.
1181         (bp_location_from_bp_type): New, factored out of...
1182         (bp_location::bp_location(breakpoint *)): ... this.
1183         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1184         factored out of...
1185         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1186         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1187         breakpoint_address_is_meaningful.
1188         (bp_locations_compare): Adjust comment.
1189         (update_global_location_list): Use bl_address_is_meaningful
1190         instead of breakpoint_address_is_meaningful.
1191         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1192         explicit.
1193         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1194         * python/py-breakpoint.c (bppy_get_location): No longer check
1195         whether location is null.
1196
1197 2019-07-09  Pedro Alves  <palves@redhat.com>
1198
1199         PR c++/15468
1200         * breakpoint.c (print_one_breakpoint_location): Remove
1201         single-location assert.
1202
1203 2019-07-09  Tom Tromey  <tom@tromey.com>
1204
1205         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1206         * configure: Rebuild.
1207         * configure.ac: Change common to gdbsupport.
1208         * gdbsupport: Rename from common.
1209         * acinclude.m4: Change common to gdbsupport.
1210         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1211         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1212         gdbsupport.
1213         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1214         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1215         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1216         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1217         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1218         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1219         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1220         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1221         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1222         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1223         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1224         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1225         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1226         coff-pe-read.c, command.h, compile/compile-c-support.c,
1227         compile/compile-c.h, compile/compile-cplus-symbols.c,
1228         compile/compile-cplus-types.c, compile/compile-cplus.h,
1229         compile/compile-loc2c.c, compile/compile.c, completer.c,
1230         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1231         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1232         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1233         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1234         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1235         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1236         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1237         features/aarch64-core.c, features/aarch64-fpu.c,
1238         features/aarch64-pauth.c, features/aarch64-sve.c,
1239         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1240         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1241         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1242         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1243         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1244         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1245         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1246         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1247         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1248         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1249         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1250         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1251         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1252         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1253         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1254         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1255         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1256         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1257         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1258         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1259         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1260         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1261         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1262         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1263         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1264         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1265         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1266         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1267         minsyms.c, mips-linux-tdep.c, namespace.h,
1268         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1269         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1270         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1271         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1272         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1273         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1274         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1275         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1276         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1277         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1278         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1279         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1280         procfs.c, producer.c, progspace.h, psymtab.h,
1281         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1282         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1283         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1284         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1285         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1286         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1287         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1288         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1289         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1290         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1291         target-memory.c, target.c, target.h, target/waitstatus.c,
1292         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1293         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1294         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1295         unittests/array-view-selftests.c,
1296         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1297         unittests/common-utils-selftests.c,
1298         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1299         unittests/format_pieces-selftests.c,
1300         unittests/function-view-selftests.c,
1301         unittests/lookup_name_info-selftests.c,
1302         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1303         unittests/mkdir-recursive-selftests.c,
1304         unittests/observable-selftests.c,
1305         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1306         unittests/parse-connection-spec-selftests.c,
1307         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1308         unittests/scoped_fd-selftests.c,
1309         unittests/scoped_mmap-selftests.c,
1310         unittests/scoped_restore-selftests.c,
1311         unittests/string_view-selftests.c, unittests/style-selftests.c,
1312         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1313         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1314         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1315         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1316         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1317         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1318
1319 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1320
1321         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1322         bool value.
1323         (decode_digits_ordinary): Set explicit_line field in sal.
1324         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1325         symtab_and_line that was set on an explicit line number in
1326         assembler code.  Do always update the recorded symtab and line if
1327         we do skip the prologue.
1328
1329 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1330
1331         * breakpoint.c (set_breakpoint_location_function): Remove
1332         explicit_loc parameter.
1333         (momentary_breakpoint_from_master): Update call to
1334         set_breakpoint_location_function.
1335         (add_location_to_breakpoint): Likewise.
1336
1337 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1338
1339         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1340         required features based on default bfd type when no specific bfd
1341         is present.
1342
1343 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1344
1345         * NEWS: Mention that GDB printf and eval commands can now print
1346         C-style and Ada-style convenience var strings without
1347         calling the inferior.
1348         * printcmd.c (printf_c_string): Locally print GDB internal var
1349         instead of transiting via the inferior.
1350         (printf_wide_c_string): Likewise.
1351
1352 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1353
1354         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1355
1356 2019-07-04  Tom Tromey  <tom@tromey.com>
1357
1358         PR tui/24724:
1359         * tui/tui-winsource.c (tui_clear_source_content): Update.
1360         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1361         (tui_update_breakpoint_info): Update.
1362         (tui_set_exec_info_content): Update.
1363         * tui/tui-source.c (tui_set_source_content_nil): Update.
1364         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1365         has_break.
1366         * tui/tui-data.h (enum tui_bp_flag): New.
1367         (tui_bp_flags): New enum flags type.
1368         (struct tui_source_element) <break_mode>: Change type.  Rename
1369         from has_break.
1370         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1371         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1372         constants.
1373         * tui/tui-winsource.h: Fix comment.
1374
1375 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1376
1377         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1378         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1379         (store_fpregs_to_thread)
1380         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1381         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1382         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1383         (IWMMXT_REGS_SIZE): Add define.
1384         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1385         (fetch_vfp_regs, store_vfp_regs)
1386         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1387         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1388
1389 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1390
1391         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1392         defines.
1393         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1394         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1395         (ARM_INT_REGISTER_SIZE): ...to this.
1396         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1397         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1398         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1399         (arm_linux_collect_gregset, supply_nwfpe_register)
1400         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1401         defines.
1402         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1403         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1404         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1405         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1406         (arm_return_in_memory, arm_store_return_value)
1407         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1408         (arm_record_ld_st_multiple): Likewise.
1409         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1410         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1411
1412 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1413
1414         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1415         AARCH64_DISPLACED_MODIFIED_INSNS.
1416         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1417         (aarch64_displaced_step_copy_insn): Likewise.
1418         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1419         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1420         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1421         ARM_DISPLACED_MODIFIED_INSNS.
1422         * arm-tdep.c (arm_gdbarch_init): Likewise.
1423         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1424         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1425         (struct arm_displaced_step_closure): Use
1426         ARM_DISPLACED_MODIFIED_INSNS.
1427
1428 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1429
1430         * features/Makefile: Remove unused xml files.
1431         * features/aarch64.xml: Remove.
1432         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1433         * features/i386/amd64-avx-avx512.xml: Remove.
1434         * features/i386/amd64-avx-linux.xml: Remove.
1435         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1436         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1437         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1438         * features/i386/amd64-avx-mpx.xml: Remove.
1439         * features/i386/amd64-avx.xml: Remove.
1440         * features/i386/amd64-linux.xml: Remove.
1441         * features/i386/amd64-mpx-linux.xml: Remove.
1442         * features/i386/amd64-mpx.xml: Remove.
1443         * features/i386/amd64.xml: Remove.
1444         * features/i386/i386-avx-avx512-linux.xml: Remove.
1445         * features/i386/i386-avx-avx512.xml: Remove.
1446         * features/i386/i386-avx-linux.xml: Remove.
1447         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1448         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1449         * features/i386/i386-avx-mpx-linux.xml: Remove.
1450         * features/i386/i386-avx-mpx.xml: Remove.
1451         * features/i386/i386-avx.xml: Remove.
1452         * features/i386/i386-linux.xml: Remove.
1453         * features/i386/i386-mmx-linux.xml: Remove.
1454         * features/i386/i386-mmx.xml: Remove.
1455         * features/i386/i386-mpx-linux.xml: Remove.
1456         * features/i386/i386-mpx.xml: Remove.
1457         * features/i386/i386.xml: Remove.
1458         * features/i386/x32-avx-avx512-linux.xml: Remove.
1459         * features/i386/x32-avx-linux.xml: Remove.
1460         * features/i386/x32-linux.xml: Remove.
1461
1462 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1463
1464         * regformats/aarch64.dat: Remove.
1465         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1466         * regformats/i386/amd64-avx-linux.dat: Remove.
1467         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1468         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1469         * regformats/i386/amd64-linux.dat: Remove.
1470         * regformats/i386/amd64-mpx-linux.dat: Remove.
1471         * regformats/i386/amd64.dat: Remove.
1472         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1473         * regformats/i386/i386-avx-linux.dat: Remove.
1474         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1475         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1476         * regformats/i386/i386-linux.dat: Remove.
1477         * regformats/i386/i386-mmx-linux.dat: Remove.
1478         * regformats/i386/i386-mpx-linux.dat: Remove.
1479         * regformats/i386/i386.dat: Remove.
1480         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1481         * regformats/i386/x32-avx-linux.dat: Remove.
1482         * regformats/i386/x32-linux.dat: Remove.
1483
1484 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1485
1486         * aarch64-tdep.c: Remove xml self tests.
1487         * amd64-linux-tdep.c: Likewise.
1488         * amd64-tdep.c: Likewise.
1489         * i386-linux-tdep.c: Likewise.
1490         * i386-tdep.c: Likewise.
1491
1492 2019-07-03  Pedro Alves  <palves@redhat.com>
1493
1494         PR cli/24732
1495         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1496         (pipe_cmd_option_defs): New.
1497         (make_pipe_cmd_options_def_group): New.
1498         (pipe_command): Use gdb::option::process_options.
1499         (pipe_command_completer): New function.
1500         (_initialize_cli_cmds): Install completer for "pipe" command.
1501
1502 2019-07-03  Pedro Alves  <palves@redhat.com>
1503
1504         * cli/cli-option.c (union option_value) <string>: New field.
1505         (struct option_def_and_value): Add ctor, move ctor, dtor and
1506         use DISABLE_COPY_AND_ASSIGN.
1507         (option_def_and_value::clear_value): New.
1508         (parse_option, save_option_value_in_ctx, get_val_type_str)
1509         (add_setshow_cmds_for_options): Handle var_string.
1510         * cli-option.h (union option_def::var_address) <string>: New
1511         field.
1512         (struct string_option_def): New.
1513         * maint-test-options.c (struct test_options_opts): Add default
1514         ctor and use DISABLE_COPY_AND_ASSIGN.
1515         <string_opt>: New field.
1516         (test_options_opts::~test_options_opts): New.
1517         (test_options_opts::dump): Also dump "-string".
1518         (test_options_option_defs): Install "string.
1519
1520 2019-07-03  Pedro Alves  <palves@redhat.com>
1521
1522         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1523         option_value with a null enumeration.
1524         (complete_options): Save the option values in the context.
1525         (save_option_value_in_ctx): New, factored out from ...
1526         (process_options): ... here.
1527         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1528         of the function.
1529         * maint-test-options.c (test_options_opts::dump): New, factored
1530         out from ...
1531         (maintenance_test_options_command_mode): ... here.
1532         (maintenance_test_options_command_completion_result): Delete.
1533         (maintenance_test_options_command_completion_text): Update
1534         comment.
1535         (maintenance_show_test_options_completion_result): Change
1536         prototype.  Just print
1537         maintenance_test_options_command_completion_text.
1538         (save_completion_result): New.
1539         (maintenance_test_options_completer_mode): Pass options context to
1540         complete_options, and then save a dump.
1541         (_initialize_maint_test_options): Use add_cmd to install "maint
1542         show test-options-completion-result".
1543
1544 2019-07-03  Pedro Alves  <palves@redhat.com>
1545
1546         * NEWS (New commands): Mention "with" and "maint with".
1547         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1548         (with_command, with_command_completer): New.
1549         (pipe_command): Adjust to new repeat_previous
1550         interface.
1551         (_initialize_cli_cmds): Install the "with" command and its "w"
1552         alias.
1553         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1554         declarations.
1555         * cli/cli-setshow.c (parse_cli_var_uinteger)
1556         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1557         argument strings for all var_types.
1558         (get_setshow_command_value_string): New, factored out from ...
1559         (do_show_command): ... this.
1560         * cli/cli-setshow.h: Include <string>.
1561         (get_setshow_command_value_string): Declare.
1562         * command.h (repeat_previous): Now returns const char *.  Adjust
1563         comment.
1564         * maint.c: Include "cli/cli-cmds.h".
1565         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1566         (_initialize_maint_cmds): Register the "maintenance with" command.
1567         * top.c (repeat_previous): Move bits from pipe_command here:
1568         Return the saved command line, if any; error out if there's no
1569         command to relaunch.
1570
1571 2019-07-03  Pedro Alves  <palves@redhat.com>
1572
1573         * NEWS (New commands): Mention "maint set/show test-settings"
1574         instead of "maint test-settings".
1575         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1576         (maintenance_test_settings_set_list): Rename to ...
1577         (maintenance_set_test_settings_list): ... this.
1578         (maintenance_test_settings_show_list): Rename to  ...
1579         (maintenance_show_test_settings_list): ... this.
1580         (maintenance_test_settings_cmd): Delete.
1581         (maintenance_test_settings_set_cmd): ...
1582         (maintenance_set_test_settings_cmd): ... this.
1583         (maintenance_test_settings_show_cmd): ...
1584         (maintenance_show_test_settings_cmd): ... this.
1585         (maintenance_test_settings_show_value_cmd):
1586         (maintenance_show_test_settings_value_cmd): ... this.
1587         (_initialize_maint_test_settings): No longer install the "maint
1588         test-settings" prefix command.  Rename "maint test-settings set"
1589         to "maint set test-settings", and "maint test-settings show" to
1590         "maint show test-settings".  Adjust all subcommands.
1591
1592 2019-07-03  Pedro Alves  <palves@redhat.com>
1593
1594         * maint-test-settings.c: Fix file's intro comment.  Replace all
1595         references to "test-options" with references to "test-settings",
1596         in comments.
1597
1598 2019-07-03  Pedro Alves  <palves@redhat.com>
1599
1600         * maint-test-settings.c (maintenance_test_settings_xxx)
1601         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1602         New.
1603         (maintenance_test_settings_enums): Use them.
1604         (maintenance_test_settings_enum): Default to
1605         maintenance_test_settings_xxx.
1606         (_initialize_maint_test_settings): Initialize
1607         MAINTENANCE_TEST_SETTINGS_FILENAME.
1608
1609 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1610
1611         * breakpoint.h (remove_breakpoints_inf): Change return type to
1612         void, move function documentation here.
1613         * breakpoint.c (remove_breakpoints_inf): Change return type to
1614         void, move function documentation to header.
1615
1616 2019-07-02  Pedro Alves  <palves@redhat.com>
1617
1618         * NEWS (Completion improvements): Mention "info threads".
1619         * thread.c (struct info_threads_opts, info_threads_option_defs)
1620         (make_info_threads_options_def_group): New.
1621         (info_threads_command): Use gdb::option::process_options.
1622         (info_threads_command_completer): New.
1623         (_initialize_thread): Use gdb::option::build_help to build the
1624         help text for "info threads".
1625
1626 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1627
1628         * defs.h (generic_load): Move from here...
1629         * symfile.h (generic_load): ... to here.  Rename name parameter
1630         to args.
1631         * symfile.c (generic_load): Add comment.
1632
1633 2019-07-01  Tom Tromey  <tromey@adacore.com>
1634
1635         * dwarf2read.c
1636         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1637         declaration of without_params.  Fix formatting.
1638
1639 2019-07-01  Tom Tromey  <tromey@adacore.com>
1640
1641         * ada-exp.y (find_primitive_type): Update.
1642         * ada-lang.h (ada_lookup_symbol): Update.
1643         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1644         parameter.
1645         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1646
1647 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1648
1649         PR breakpoints/24541
1650         * gdbarch.c: Regenerate.
1651         * gdbarch.h: Regenerate.
1652         * gdbarch.sh: Add 'stap_adjust_register'.
1653         * i386-tdep.c: Include '<unordered_set>'.
1654         (i386_stap_adjust_register): New function.
1655         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1656         * stap-probe.c (stap_parse_register_operand): Call
1657         'gdbarch_stap_adjust_register'.
1658
1659 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1660
1661         PR python/24742
1662         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1663         * python/python.c (do_start_initialization): Use 'xmalloc'
1664         instead of 'PyMem_Malloc'.
1665
1666 2019-06-28  Tom Tromey  <tromey@adacore.com>
1667
1668         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1669         for Ada.
1670
1671 2019-06-27  Tom Tromey  <tromey@adacore.com>
1672
1673         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1674         objfile_key.
1675         (arm_find_mapping_symbol, arm_record_special_symbol)
1676         (_initialize_arm_tdep): Update.
1677         (arm_objfile_data_free): Remove.
1678
1679 2019-06-27  Tom Tromey  <tromey@adacore.com>
1680
1681         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1682         to cp_print_static_field.
1683
1684 2019-06-26  Tom Tromey  <tromey@adacore.com>
1685
1686         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1687         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1688         declare.
1689
1690 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1691
1692         * features/aarch64-core.c (create_feature_aarch64_core):
1693         Regenerate.
1694         * features/aarch64-core.xml: Add cpsr flags.
1695
1696 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1697
1698         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1699         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1700
1701 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1702
1703         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1704         field.
1705         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1706         use.
1707         (arm_record_special_symbol): Don't insert new symbol in sorted
1708         position, push it at the end.
1709
1710 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1711
1712         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1713         (arm_mapping_symbol_s): Remove.
1714         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1715         (arm_mapping_symbol_vec): New typedef.
1716         (struct arm_per_objfile): Add constructor.
1717         <section_maps>: Change type to
1718         std::unique_ptr<arm_mapping_symbol_vec[]>.
1719         (arm_compare_mapping_symbols): Remove.
1720         (arm_find_mapping_symbol): Adjust to section_maps type change.
1721         (arm_objfile_data_free): Call delete on arm_per_objfile.
1722         (arm_record_special_symbol): Adjust to section_maps type change.
1723         Allocate arm_per_objfile with new.
1724
1725 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1726
1727         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1728         with the command prefix.
1729
1730 2019-06-25  Tom Tromey  <tom@tromey.com>
1731
1732         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1733         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1734
1735 2019-06-25  Tom Tromey  <tom@tromey.com>
1736
1737         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1738         type.
1739         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1740         protected.
1741
1742 2019-06-25  Tom Tromey  <tom@tromey.com>
1743
1744         * tui/tui-winsource.c
1745         (tui_source_window_base::set_is_exec_point_at): Add check against
1746         LOA_ADDRESS.
1747
1748 2019-06-25  Tom Tromey  <tom@tromey.com>
1749
1750         * tui/tui-source.c (tui_set_source_content): Don't check before
1751         xfree.
1752         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1753
1754 2019-06-25  Tom Tromey  <tom@tromey.com>
1755
1756         * tui/tui-winsource.h (tui_update_source_window_as_is)
1757         (tui_alloc_source_buffer, tui_line_is_displayed)
1758         (tui_addr_is_displayed): Change type of win_info.
1759         * tui/tui-winsource.c (tui_update_source_window_as_is)
1760         (tui_clear_source_content, tui_show_source_line)
1761         (tui_show_source_content, tui_source_window_base::refill)
1762         (tui_source_window_base::set_is_exec_point_at)
1763         (tui_source_window_base::set_is_exec_point_at)
1764         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1765         (tui_alloc_source_buffer, tui_line_is_displayed)
1766         (tui_addr_is_displayed): Change type of win_info.  Update.
1767         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1768         (tui_source_window_base::do_make_visible_with_new_height):
1769         Update.
1770         * tui/tui-source.c (tui_set_source_content)
1771         (tui_set_source_content_nil)
1772         (tui_source_window::do_scroll_vertical): Update.
1773         * tui/tui-layout.c (show_layout): Update.
1774         * tui/tui-disasm.c (tui_set_disassem_content)
1775         (tui_disasm_window::do_scroll_vertical): Update.
1776         * tui/tui-data.h (tui_win_content): Remove.
1777         (struct tui_gen_win_info) <content, content_size>: Remove.
1778         (struct tui_source_element): Add initializers and destructor.
1779         (union tui_which_element, struct tui_win_element): Remove.
1780         (struct tui_source_window_base) <content>: New field.
1781         (struct tui_data_window): Remove destructor.
1782         (tui_alloc_content, tui_free_win_content)
1783         (tui_free_all_source_wins_content): Don't declare.
1784         * tui/tui-data.c (tui_initialize_static_data): Update.
1785         (init_content_element, tui_alloc_content): Remove.
1786         (~tui_gen_win_info): Update.
1787         (~tui_data_window, tui_free_all_source_wins_content)
1788         (tui_free_win_content, free_content, free_content_elements):
1789         Remove.
1790
1791 2019-06-25  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui-winsource.h (tui_clear_source_content)
1794         (tui_erase_source_content, tui_show_source_content): Change type
1795         of win_info.
1796         * tui/tui-winsource.c (tui_clear_source_content)
1797         (tui_erase_source_content, tui_show_source_content): Change type
1798         of win_info.
1799         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1800         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1801         win_info.
1802         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1803         win_info.
1804         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1805
1806 2019-06-25  Tom Tromey  <tom@tromey.com>
1807
1808         * tui/tui-winsource.c (tui_clear_source_content)
1809         (tui_source_window_base::set_is_exec_point_at): Update.
1810         * tui/tui-source.c (tui_set_source_content_nil): Update.
1811         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1812         a bool.
1813         * tui/tui-data.c (init_content_element): Update.
1814
1815 2019-06-25  Tom Tromey  <tom@tromey.com>
1816
1817         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1818         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1819         * tui/tui-layout.c (init_and_make_win): Update.
1820         * tui/tui.h (enum tui_win_type): Update.
1821         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1822         tui_win_is_auxillary.
1823         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1824         tui_win_is_auxillary.
1825
1826 2019-06-25  Tom Tromey  <tom@tromey.com>
1827
1828         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1829         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1830         (tui_delete_data_content_windows, tui_display_all_data)
1831         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1832         Update.
1833         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1834         * tui/tui-regs.c (tui_last_regs_line_no)
1835         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1836         (tui_show_registers): Update.
1837         (tui_show_register_group): Return void.  Update.
1838         (tui_display_registers_from, tui_display_reg_element_at_line)
1839         (tui_display_registers_from_line, tui_check_register_values):
1840         Update.
1841         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1842         member.
1843         (struct tui_data_window) <regs_content>: Now a std::vector.
1844         <regs_content_count>: Remove.
1845         (tui_add_content_elements, tui_free_data_content): Don't declare.
1846         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1847         (init_content_element): Remove DATA_WIN case.  Add assert.
1848         (tui_add_content_elements): Remove.
1849         (tui_data_window): Update.
1850         (tui_free_data_content): Remove.
1851         (free_content_elements): Remove DATA_WIN case.
1852
1853 2019-06-25  Tom Tromey  <tom@tromey.com>
1854
1855         * tui/tui-data.c (tui_data_item_window): Update.
1856         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1857         * tui/tui-windata.c (tui_display_all_data)
1858         (tui_display_data_from_line): Update.
1859         (tui_check_data_values): Remove.
1860         * tui/tui-regs.c (tui_show_register_group)
1861         (tui_display_reg_element_at_line): Update.
1862         * tui/tui-hooks.c (tui_register_changed)
1863         (tui_refresh_frame_and_register_information): Call
1864         tui_check_register_values.
1865         * tui/tui-data.h (struct tui_data_window) <data_content,
1866         data_content_count, data_type>: Remove.
1867         (enum tui_data_type): Remove.
1868
1869         * tui/tui-data.c (tui_data_window::clear_detail)
1870         (~tui_data_window): Update.
1871
1872 2019-06-25  Tom Tromey  <tom@tromey.com>
1873
1874         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1875         declare.
1876         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1877         Rename from tui_first_data_item_displayed.  Update.
1878         (tui_data_window::refresh_all)
1879         (tui_data_window::do_scroll_vertical): Update.
1880         * tui/tui-data.h (struct tui_data_window)
1881         <first_data_item_displayed>: Declare new method.
1882
1883 2019-06-25  Tom Tromey  <tom@tromey.com>
1884
1885         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1886         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1887         contents...
1888         (tui_initialize_static_data): ...here.
1889
1890 2019-06-25  Tom Tromey  <tom@tromey.com>
1891
1892         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1893         (tui_display_registers_from, tui_check_register_values): Update.
1894         (tui_display_register): Remove win_info parameter; update.
1895         (tui_get_register): Change type of parameters.
1896         * tui/tui-data.h (struct tui_data_element): Remove.
1897         (union tui_which_element) <data>: Remove.
1898         <data_window>: Change type.
1899         (struct tui_data_item_window): New.
1900         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1901         case.  Add assert.
1902         (~tui_data_item_window): New destructor.
1903         (free_content_elements): Remove DATA_ITEM_WIN case.
1904
1905 2019-06-25  Tom Tromey  <tom@tromey.com>
1906
1907         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1908         Remove.
1909
1910 2019-06-25  Tom Tromey  <tom@tromey.com>
1911
1912         * tui/tui-data.h (struct tui_command_element): Remove.
1913         (union tui_which_element) <command>: Remove.
1914         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1915         assert.
1916         (free_content_elements): Remove CMD_WIN case.
1917
1918 2019-06-25  Tom Tromey  <tom@tromey.com>
1919
1920         * tui/tui-layout.c (tui_set_layout): Update.
1921         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1922         * tui/tui-data.c (layout_def): Update.
1923
1924 2019-06-25  Tom Tromey  <tom@tromey.com>
1925
1926         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1927         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1928         (tui_source_window_base::set_new_height): Update.
1929         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1930         Update.
1931         (tui_set_locator_fullname, tui_set_locator_info)
1932         (tui_show_frame_info): Update.
1933         * tui/tui-source.c (tui_set_source_content)
1934         (tui_source_is_displayed): Update.
1935         * tui/tui-layout.c (show_source_disasm_command, show_data)
1936         (show_source_or_disasm_and_command): Update.
1937         * tui/tui-disasm.c (tui_set_disassem_content)
1938         (tui_get_begin_asm_address): Update.
1939         * tui/tui-data.h (struct tui_locator_element): Remove.
1940         (union tui_which_element) <locator>: Remove.
1941         (struct tui_locator_window): New.
1942         (tui_locator_win_info_ptr): Change return type.
1943         * tui/tui-data.c (_locator): Change type.
1944         (tui_locator_win_info_ptr): Change return type.
1945         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1946         (tui_alloc_content): Add assert.
1947
1948 2019-06-25  Tom Tromey  <tom@tromey.com>
1949
1950         * tui/tui-winsource.c
1951         (tui_exec_info_window::maybe_allocate_content): New method.
1952         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1953         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1954         (make_source_or_disasm_window): Add cast.
1955         * tui/tui-data.h (union tui_which_element) <simple_string>:
1956         Remove.
1957         (struct tui_source_info): New.
1958         (struct tui_source_window_base) <execution_info>: Change type.
1959         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1960         case, and add assert.
1961         (tui_alloc_content): Add assert.
1962
1963 2019-06-25  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1966         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1967         * tui/tui-data.c (tui_alloc_win_info): Remove.
1968
1969 2019-06-25  Tom Tromey  <tom@tromey.com>
1970
1971         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1972         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1973         can_highlight.
1974
1975 2019-06-25  Tom Tromey  <tom@tromey.com>
1976
1977         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1978         make_visible_with_new_height method.
1979         (tui_win_info::make_visible_with_new_height): New method.
1980         (tui_source_window_base::do_make_visible_with_new_height)
1981         (tui_data_window::do_make_visible_with_new_height)
1982         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1983         (make_visible_with_new_height): Remove.
1984         (tui_resize_all, tui_adjust_win_heights): Use
1985         make_visible_with_new_height method.
1986         * tui/tui-data.h (struct tui_win_info)
1987         <do_make_visible_with_new_height, make_visible_with_new_height>:
1988         New methods.
1989         (struct tui_source_window_base, struct tui_data_window)
1990         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1991         methods.
1992
1993 2019-06-25  Tom Tromey  <tom@tromey.com>
1994
1995         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1996         method.
1997         (update_tab_width): Call update_tab_width method.
1998         * tui/tui-data.h (struct tui_win_info)
1999         (struct tui_source_window_base) <update_tab_width>: New methods.
2000
2001 2019-06-25  Tom Tromey  <tom@tromey.com>
2002
2003         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2004         parameter.
2005         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2006         parameter.
2007         (tui_gen_win_info::make_visible): Update.
2008         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2009         parameter.
2010         * tui/tui-data.h (enum tui_box): New enum.
2011         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2012
2013 2019-06-25  Tom Tromey  <tom@tromey.com>
2014
2015         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2016         init_and_make_win for EXEC_INFO_WIN.
2017         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2018         longer inline.
2019         (struct tui_win_info) <~tui_win_info>: Inline.
2020         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2021         Don't declare.
2022         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2023         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2024         Remove.
2025         (tui_initialize_static_data): Update.
2026         (~tui_gen_win_info): Handle more cleanup here.
2027         (~tui_source_window_base): Delete "execution_info".
2028         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2029
2030 2019-06-25  Tom Tromey  <tom@tromey.com>
2031
2032         * tui/tui-layout.c (make_command_window): Don't set
2033         can_highlight.
2034         (show_source_disasm_command): Call the reset method.
2035         (show_data): Don't set can_highlight.  Call the reset method.
2036         (tui_gen_win_info::reset): Rename from init_gen_win_info
2037         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2038         (show_source_or_disasm_and_command): Call the reset method.
2039         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2040         (struct tui_cmd_window): Set can_highlight.
2041
2042 2019-06-25  Tom Tromey  <tom@tromey.com>
2043
2044         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2045         from make_visible.
2046         (tui_make_visible, tui_make_invisible): Rewrite.
2047         (tui_win_info::make_visible): Remove.
2048         (tui_source_window_base::make_visible): Update.
2049         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2050         method.  Moved from...
2051         (struct tui_win_info) <make_visible>: ...here.
2052
2053 2019-06-25  Tom Tromey  <tom@tromey.com>
2054
2055         * tui/tui-winsource.c
2056         (tui_source_window_base::do_scroll_horizontal): Remove direction
2057         parameter.
2058         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2059         direction parameter.
2060         * tui/tui-win.c (tui_win_info::forward_scroll)
2061         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2062         (tui_win_info::right_scroll): Update.
2063         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2064         direction parameter.
2065         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2066         direction parameter.
2067         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2068         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2069         Remove direction parameter.
2070         (struct tui_source_window_base, struct tui_source_window)
2071         (struct tui_disasm_window, struct tui_data_window)
2072         (struct tui_cmd_window): Update.
2073
2074 2019-06-25  Tom Tromey  <tom@tromey.com>
2075
2076         * tui/tui-winsource.h (tui_set_exec_info_content)
2077         (tui_show_exec_info_content, tui_erase_exec_info_content)
2078         (tui_clear_exec_info_content, tui_update_exec_info): Change
2079         argument to tui_source_window_base.
2080         * tui/tui-winsource.c (tui_set_exec_info_content)
2081         (tui_show_exec_info_content, tui_erase_exec_info_content)
2082         (tui_clear_exec_info_content, tui_update_exec_info): Change
2083         argument to tui_source_window_base.
2084
2085 2019-06-25  Tom Tromey  <tom@tromey.com>
2086
2087         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2088         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2089
2090 2019-06-25  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2093         check.
2094
2095 2019-06-25  Tom Tromey  <tom@tromey.com>
2096
2097         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2098         type to void.
2099         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2100         type to void.
2101         * tui/tui-source.c (tui_set_source_content): Update.
2102         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2103
2104 2019-06-25  Tom Tromey  <tom@tromey.com>
2105
2106         * tui/tui-win.c (window_name_completer, tui_set_focus)
2107         (tui_all_windows_info): Use name method.
2108         * tui/tui-data.h (struct tui_gen_win_info)
2109         (struct tui_source_window, struct tui_disasm_window)
2110         (struct tui_data_window, struct tui_cmd_window) <name>: New
2111         method.
2112         (tui_win_name): Don't declare.
2113         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2114         (tui_win_name): Remove.
2115
2116 2019-06-25  Tom Tromey  <tom@tromey.com>
2117
2118         * tui/tui-winsource.h (tui_update_source_window)
2119         (tui_update_source_window_as_is): Change parameter type.
2120         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2121         to be a tui_source_window_base.
2122         (tui_update_source_window_as_is): Likewise.
2123         * tui/tui-win.c (make_visible_with_new_height): Update.
2124
2125 2019-06-25  Tom Tromey  <tom@tromey.com>
2126
2127         * tui/tui-winsource.c (tui_erase_source_content)
2128         (tui_show_source_content, tui_show_exec_info_content)
2129         (tui_erase_exec_info_content): Use refresh_window method.
2130         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2131         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2132         from tui_refresh_win.
2133         (tui_data_window::refresh_window): New method.
2134         (tui_win_info::refresh, tui_source_window_base::refresh)
2135         (tui_refresh_all): Use refresh_window method.
2136         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2137         method.
2138         * tui/tui-regs.c (tui_display_register): Call refresh_window
2139         method.
2140         * tui/tui-layout.c (show_source_disasm_command)
2141         (show_source_or_disasm_and_command): Call refresh_window method.
2142         * tui/tui-data.h (struct tui_gen_win_info)
2143         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2144         New method.
2145
2146 2019-06-25  Tom Tromey  <tom@tromey.com>
2147
2148         * tui/tui.c (tui_rl_other_window, tui_enable)
2149         (tui_is_window_visible, tui_get_command_dimension): Update.
2150         * tui/tui-winsource.c (tui_update_source_window_as_is)
2151         (tui_clear_source_content, tui_erase_source_content)
2152         (tui_show_source_line, tui_source_window_base::refill)
2153         (tui_source_window_base::do_scroll_horizontal)
2154         (tui_source_window_base::set_is_exec_point_at)
2155         (tui_update_breakpoint_info, tui_set_exec_info_content)
2156         (tui_alloc_source_buffer, tui_line_is_displayed)
2157         (tui_addr_is_displayed): Update.
2158         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2159         (tui_check_and_display_highlight_if_needed)
2160         (tui_win_info::make_visible, tui_win_info::refresh)
2161         (tui_refresh_all): Update.
2162         * tui/tui-windata.c (tui_first_data_item_displayed)
2163         (tui_delete_data_content_windows, tui_erase_data_content)
2164         (tui_display_all_data, tui_data_window::refresh_all)
2165         (tui_check_data_values): Update.
2166         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2167         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2168         (tui_win_info::backward_scroll, tui_refresh_all_win)
2169         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2170         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2171         (tui_source_window_base::set_new_height)
2172         (tui_data_window::set_new_height)
2173         (make_invisible_and_set_new_height)
2174         (make_visible_with_new_height, new_height_ok)
2175         (parse_scrolling_args): Update.
2176         * tui/tui-stack.c (tui_show_frame_info): Update.
2177         * tui/tui-source.c (tui_set_source_content)
2178         (tui_set_source_content_nil, tui_source_is_displayed)
2179         (tui_source_window::do_scroll_vertical): Update.
2180         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2181         (tui_display_registers_from, tui_display_reg_element_at_line)
2182         (tui_check_register_values, tui_reg_command): Update.
2183         * tui/tui-layout.c (tui_default_win_height)
2184         (show_source_disasm_command, show_data, init_and_make_win)
2185         (show_source_or_disasm_and_command): Update.
2186         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2187         (tui_redisplay_readline, tui_mld_flush)
2188         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2189         (tui_getc): Update.
2190         * tui/tui-disasm.c (tui_set_disassem_content)
2191         (tui_disasm_window::do_scroll_vertical): Update.
2192         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2193         Now virtual.
2194         (struct tui_win_info): Derive from tui_gen_win_info.
2195         <~tui_win_info>: Mark as override.
2196         <generic>: Remove member.
2197         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2198         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2199         (~tui_data_window, ~tui_win_info)
2200         (tui_free_all_source_wins_content): Update.
2201         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2202
2203 2019-06-25  Tom Tromey  <tom@tromey.com>
2204
2205         * tui/tui-layout.c (init_and_make_win): Use new.
2206         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2207         destructor, initializers.
2208         (tui_alloc_generic_win_info): Don't declare.
2209         * tui/tui-data.c (_locator): Add argument to constructor.
2210         (source_win, disasm_win): New globals.
2211         (exec_info): Remove.
2212         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2213         Update.
2214         (tui_alloc_generic_win_info): Remove.
2215         (init_content_element): Use new.
2216         (tui_win_info::tui_win_info): Update.
2217         (free_content_elements) <case DATA_WIN>: Use delete.
2218
2219 2019-06-25  Tom Tromey  <tom@tromey.com>
2220
2221         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2222         * tui/tui-windata.c (tui_first_data_item_displayed)
2223         (tui_delete_data_content_windows): Update.
2224         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2225         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2226         (tui_display_registers_from, tui_check_register_values): Update.
2227         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2228         pointer.
2229         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2230         window.
2231         (tui_free_data_content): Update.
2232         (free_content_elements) <case DATA_WIN>: Free the window.
2233
2234 2019-06-25  Tom Tromey  <tom@tromey.com>
2235
2236         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2237         Update.
2238         * tui/tui-layout.c (make_command_window)
2239         (show_source_disasm_command, show_data, init_and_make_win)
2240         (show_source_or_disasm_and_command): Update.
2241         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2242         method.
2243         <can_highight, is_highlighted>: Now bool.
2244         (tui_set_win_highlight): Don't declare.
2245         * tui/tui-data.c (tui_set_win_highlight): Remove.
2246
2247 2019-06-25  Tom Tromey  <tom@tromey.com>
2248
2249         * tui/tui-wingeneral.c (make_visible): Remove check of window
2250         type.
2251
2252 2019-06-25  Tom Tromey  <tom@tromey.com>
2253
2254         * tui/tui-win.c (tui_win_info::max_height)
2255         (tui_cmd_window::max_height): New methods.
2256         (new_height_ok): Call max_height.
2257         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2258         <max_height>: New method.
2259
2260 2019-06-25  Tom Tromey  <tom@tromey.com>
2261
2262         * tui/tui-win.c (tui_source_window_base::set_new_height)
2263         (tui_data_window::set_new_height): New methods.
2264         (make_invisible_and_set_new_height): Call set_new_height method.
2265         * tui/tui-data.h (struct tui_win_info)
2266         (struct tui_source_window_base, struct tui_data_window)
2267         <set_new_height>: New method.
2268
2269 2019-06-25  Tom Tromey  <tom@tromey.com>
2270
2271         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2272         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2273         tui_refresh_data_win.
2274         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2275         method.
2276         (tui_refresh_all_win): Call the refresh_all method.
2277         (tui_set_focus): Likewise.
2278         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2279         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2280         Likewise.
2281
2282 2019-06-25  Tom Tromey  <tom@tromey.com>
2283
2284         * tui/tui-winsource.h (tui_refill_source_window)
2285         (tui_set_is_exec_point_at): Don't declare.
2286         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2287         (tui_source_window_base::refill): Rename from
2288         tui_refill_source_window.
2289         (tui_source_window_base::do_scroll_horizontal): Update.
2290         (tui_source_window_base::set_is_exec_point_at): Rename from
2291         tui_set_is_exec_point_at.
2292         (tui_update_all_breakpoint_info): Update.
2293         * tui/tui-stack.c (tui_show_frame_info): Update.
2294         * tui/tui-layout.c (show_data): Add cast.
2295         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2296         * tui/tui-data.h (struct tui_source_window_base) <refill,
2297         set_is_exec_point_at>: New methods.
2298         (tui_source_windows, tui_add_to_source_windows): Update types.
2299         (tui_add_to_source_windows): Remove redundant declaration.
2300         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2301         (tui_source_windows): Change return type.
2302         (tui_clear_source_windows_detail): Update.
2303         (tui_add_to_source_windows): Change type of parameter.
2304         (tui_free_all_source_wins_content): Update.
2305
2306 2019-06-25  Tom Tromey  <tom@tromey.com>
2307
2308         * tui/tui-wingeneral.c (tui_win_info::refresh)
2309         (tui_source_window_base::refresh): New methods.
2310         (tui_refresh_all): Call the refresh method.
2311         * tui/tui-data.h (struct tui_win_info)
2312         (struct tui_source_window_base) <refresh>: New method.
2313
2314 2019-06-25  Tom Tromey  <tom@tromey.com>
2315
2316         * tui/tui.h (tui_is_window_visible): Return bool.
2317         * tui/tui.c (tui_is_window_visible): Return bool.
2318         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2319         (tui_make_visible, tui_make_invisible)
2320         (tui_win_info::make_visible)
2321         (tui_source_window_base::make_visible, make_all_visible)
2322         (tui_make_all_visible, tui_make_all_invisible): Update.
2323         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2324         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2325         bool.
2326         (struct tui_win_info, struct tui_source_window_base)
2327         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2328         * tui/tui-data.c (tui_init_generic_part): Update.
2329
2330 2019-06-25  Tom Tromey  <tom@tromey.com>
2331
2332         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2333         (tui_source_window_base::make_visible): New methods.
2334         (make_all_visible): Make method call.
2335         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2336         (struct tui_source_window_base, struct tui_cmd_window): Override
2337         make_visible.
2338         (tui_win_is_source_type): Don't declare.
2339         * tui/tui-data.c (tui_win_is_source_type): Remove.
2340
2341 2019-06-25  Tom Tromey  <tom@tromey.com>
2342
2343         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2344         NULL check.
2345
2346 2019-06-25  Tom Tromey  <tom@tromey.com>
2347
2348         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2349         Inline constructor.  Add initializers for members.
2350         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2351         constructors; now inline in class.
2352
2353 2019-06-25  Tom Tromey  <tom@tromey.com>
2354
2355         * tui/tui-regs.c (tui_show_registers): Update.
2356         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2357         bool.
2358         * tui/tui-data.c (tui_data_window::clear_detail)
2359         (tui_data_window): Update.
2360
2361 2019-06-25  Tom Tromey  <tom@tromey.com>
2362
2363         * tui/tui-windata.c (tui_display_all_data)
2364         (tui_display_data_from_line, tui_display_data_from)
2365         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2366         Update.
2367         * tui/tui-regs.c (tui_last_regs_line_no)
2368         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2369         (tui_show_registers, tui_show_register_group)
2370         (tui_display_registers_from, tui_display_reg_element_at_line)
2371         (tui_display_registers_from_line, tui_check_register_values)
2372         (tui_reg_next, tui_reg_prev): Update.
2373         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2374         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2375         tui_data_window.
2376         (struct tui_win_info) <detail>: Remove.  Add new fields from
2377         tui_data_info.
2378         (TUI_DATA_WIN): Add cast.
2379         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2380         (~tui_data_window): Simplify.
2381
2382 2019-06-25  Tom Tromey  <tom@tromey.com>
2383
2384         * tui/tui-layout.c (show_source_disasm_command)
2385         (show_source_or_disasm_and_command): Update.
2386         * tui/tui-io.c (update_cmdwin_start_line)
2387         (tui_redisplay_readline): Update.
2388         * tui/tui-data.h (struct tui_command_info): Remove.
2389         (struct tui_win_info) <detail>: Remove command_info member.
2390         (struct tui_data_window) <start_line>: New member, from
2391         tui_command_info.
2392         (TUI_CMD_WIN): Add casts.
2393
2394 2019-06-25  Tom Tromey  <tom@tromey.com>
2395
2396         * tui/tui-winsource.c (tui_update_source_window)
2397         (tui_refill_source_window)
2398         (tui_source_window_base::do_scroll_horizontal)
2399         (tui_update_breakpoint_info, tui_set_exec_info_content)
2400         (tui_show_exec_info_content, tui_erase_exec_info_content)
2401         (tui_clear_exec_info_content): Update.
2402         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2403         Update.
2404         * tui/tui-win.c (make_invisible_and_set_new_height)
2405         (make_visible_with_new_height): Update.
2406         * tui/tui-source.c (tui_set_source_content)
2407         (tui_show_symtab_source): Update.
2408         * tui/tui-layout.c (extract_display_start_addr)
2409         (show_source_disasm_command, show_data)
2410         (make_source_or_disasm_window)
2411         (show_source_or_disasm_and_command): Update.
2412         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2413         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2414         "gdbarch".
2415         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2416         to tui_source_window_base.
2417         (struct tui_win_info) <detail>: Remove source_info member.
2418         (struct tui_source_window_base) <has_locator>: Inline.
2419         Move contents from tui_source_info; rename has_locator member to
2420         m_has_locator.
2421         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2422         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2423         header file.
2424         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2425         Simplify.
2426         (tui_free_all_source_wins_content): Cast to
2427         tui_source_window_base.
2428
2429 2019-06-25  Tom Tromey  <tom@tromey.com>
2430
2431         * tui/tui-win.c (make_invisible_and_set_new_height)
2432         (make_visible_with_new_height): Call has_locator method.
2433         * tui/tui-layout.c (show_source_disasm_command, show_data)
2434         (show_source_or_disasm_and_command): Update for bool change.
2435         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2436         (tui_win_info) <has_locator>: New method.
2437         (struct tui_source_window_base) <has_locator>: New method.
2438         (tui_win_has_locator): Don't declare.
2439         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2440         from tui_win_has_locator.
2441         (tui_source_window_base): Use false, not FALSE.
2442
2443 2019-06-25  Tom Tromey  <tom@tromey.com>
2444
2445         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2446         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2447         clear_detail method directly.
2448         (tui_clear_win_detail): Remove.
2449
2450 2019-06-25  Tom Tromey  <tom@tromey.com>
2451
2452         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2453         "this", not TUI_DISASM_WIN.
2454
2455 2019-06-25  Tom Tromey  <tom@tromey.com>
2456
2457         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2458         declare.
2459         * tui/tui-winsource.c
2460         (tui_source_window_base::do_scroll_horizontal): Rename from
2461         tui_horizontal_source_scroll.
2462         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2463         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2464         from tui_vertical_data_scroll.
2465         * tui/tui-win.h (tui_scroll): Don't declare.
2466         * tui/tui-win.c (tui_win_info::forward_scroll)
2467         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2468         (tui_win_info::right_scroll): Rename and update.
2469         (tui_scroll_forward_command, tui_scroll_backward_command)
2470         (tui_scroll_left_command, tui_scroll_right_command): Update.
2471         (tui_scroll): Remove.
2472         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2473         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2474         from tui_vertical_source_scroll.
2475         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2476         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2477         from tui_vertical_disassem_scroll.
2478         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2479         do_scroll_horizontal>: New methods.
2480         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2481         Likewise.
2482         (struct tui_source_window_base): Add do_scroll_horizontal.
2483         (struct tui_source_window, struct tui_disasm_window): Add
2484         do_scroll_vertical.
2485         (struct tui_data_window, struct tui_cmd_window): Add
2486         do_scroll_horizontal and do_scroll_vertical.
2487         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2488
2489 2019-06-25  Tom Tromey  <tom@tromey.com>
2490
2491         * tui/tui-data.h (struct tui_source_window_base): New struct.
2492         (struct tui_source_window): Derive from tui_source_window_base.
2493         (struct tui_disasm_window): New struct.
2494         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2495         from tui_source_window::clear_detail.
2496         (tui_source_window_base): Rename from tui_source_window.
2497         (~tui_source_window_base): Rename from ~tui_source_window.
2498         (tui_alloc_win_info): Create a tui_disasm_window.
2499
2500 2019-06-25  Tom Tromey  <tom@tromey.com>
2501
2502         * tui/tui-data.h (struct tui_source_window)
2503         (struct tui_data_window): Declare destructors.
2504         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2505         destructors.
2506         (tui_win_info): Simplify.
2507
2508 2019-06-25  Tom Tromey  <tom@tromey.com>
2509
2510         * tui/tui-winsource.c (tui_display_main)
2511         (tui_update_source_windows_with_addr)
2512         (tui_update_all_breakpoint_info): Update.
2513         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2514         (new_height_ok, parse_scrolling_args): Update.
2515         * tui/tui-stack.c (tui_show_frame_info): Update.
2516         * tui/tui-data.h (struct tui_list): Remove.
2517         (tui_source_windows): Return a reference to a std::vector.
2518         * tui/tui-data.c (source_windows): Now a std::vector.
2519         (tui_source_windows): Change return type.
2520         (tui_clear_source_windows): Rewrite.
2521         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2522         (tui_free_all_source_wins_content): Rewrite.
2523
2524 2019-06-25  Tom Tromey  <tom@tromey.com>
2525
2526         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2527         (struct tui_data_window, struct tui_cmd_window): Declare
2528         clear_detail method.
2529         * tui/tui-data.c (tui_source_window::clear_detail)
2530         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2531         methods.
2532         (tui_clear_win_detail): Simplify.
2533
2534 2019-06-25  Tom Tromey  <tom@tromey.com>
2535
2536         * tui/tui-layout.c (make_source_window, make_disasm_window)
2537         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2538         Return the new window.
2539         (show_source_disasm_command, show_data)
2540         (show_source_or_disasm_and_command): Update.
2541
2542 2019-06-25  Tom Tromey  <tom@tromey.com>
2543
2544         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2545         parameter.  Return the new window.
2546         (show_source_disasm_command): Update and remove NULL check.
2547         (show_source_or_disasm_and_command): Update.
2548
2549 2019-06-25  Tom Tromey  <tom@tromey.com>
2550
2551         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2552
2553 2019-06-25  Tom Tromey  <tom@tromey.com>
2554
2555         * tui/tui-data.h (struct tui_win_info): Make constructor
2556         protected.  Make destructor virtual.  Add initializers.
2557         (tui_source_window, tui_data_window, tui_cmd_window): New
2558         classes.
2559         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2560         constructor.  Add "type" parameter.
2561         (tui_source_window, tui_data_window, tui_cmd_window): New
2562         constructors.
2563         (tui_alloc_win_info): Instantiate the appropriate subclass.
2564
2565 2019-06-25  Tom Tromey  <tom@tromey.com>
2566
2567         * tui/tui-win.c (tui_resize_all): Use delete.
2568         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2569         destructor.
2570         (tui_free_window): Don't declare.
2571         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2572         Update.
2573
2574 2019-06-25  Tom Tromey  <tom@tromey.com>
2575
2576         * tui/tui-data.h (struct tui_win_info): Add constructor.
2577         * tui/tui-data.c (tui_alloc_win_info): Use new.
2578         (tui_free_window): Use delete.
2579
2580 2019-06-22  Tom Tromey  <tom@tromey.com>
2581
2582         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2583         declare.
2584         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2585
2586 2019-06-22  Tom Tromey  <tom@tromey.com>
2587
2588         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2589         declare.
2590         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2591
2592 2019-06-22  Tom de Vries  <tdevries@suse.de>
2593
2594         * dwarf2read.c (create_addrmap_from_aranges)
2595         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2596         instead of '%zu'.
2597
2598 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2599
2600         * dwarf2read.h (dwarf2_section_info_def): Remove.
2601         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2602         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2603         std::vector<dwarf2_section_info>.
2604         (struct dwo_file) <~dwo_file>: Remove.
2605         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2606         types field.
2607         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2608         (dwarf2_read_debug_names): Likewise.
2609         (create_debug_types_hash_table): Change parameter type to
2610         array_view, adjust code accordingly.
2611         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2612         (partial_die_info::fixup): Likewise.
2613         (determine_prefix): Likewise.
2614         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2615
2616 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2617
2618         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2619         gdb_bfd_ref_ptr.
2620         <~dwo_file>: Remove call to gdb_bfd_unref.
2621         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2622         gdb_bfd_ref_ptr::get.
2623
2624 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2625
2626         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2627         type to htab_up.
2628         * dwarf2read.c (struct dwo_file): Initialize fields.
2629         <~dwo_file>: New.
2630         (free_dwo_file): Remove, move content to ~dwo_file.
2631         (struct dwo_file_deleter): Remove.
2632         (dwo_file_up>: Remove custom deleter.
2633         (free_dwo_files): Remove.
2634         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2635         dwo_files.
2636         (process_skeletonless_type_units): Call unique_ptr::get.
2637         (allocate_dwo_file_hash_table): Add deleter to created hash
2638         table.  Change return type to htab_up.
2639         (lookup_dwo_file_slot): Don't memset dwo_file, call
2640         unique_ptr::get.
2641         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2642         (create_dwo_unit_in_dwp_v2): Likewise.
2643         (open_and_init_dwo_file): Likewise.
2644         (free_dwo_file_from_slot): Remove.
2645
2646 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2647
2648         * dwarf2read.h (struct dwarf2_section_info) <readin,
2649         is_virtual>: Change type to bool.
2650         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2651         true instead of 1.
2652
2653 2019-06-19  Tom Tromey  <tom@tromey.com>
2654
2655         * tui/tui-data.h (tui_init_content_element): Don't declare.
2656
2657 2019-06-19  Tom Tromey  <tom@tromey.com>
2658
2659         * tui/tui-data.h (tui_init_win_info): Don't declare.
2660
2661 2019-06-19  Tom de Vries  <tdevries@suse.de>
2662
2663         * dwarf2read.h (abstract_to_concrete): Change type to
2664         std::unordered_map<sect_offset, std::vector<sect_offset>,
2665         gdb::hash_enum<sect_offset>>.
2666
2667 2019-06-19  Tom Tromey  <tromey@adacore.com>
2668
2669         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2670         EVAL_AVOID_SIDE_EFFECTS specially.
2671
2672 2019-06-19  Tom Tromey  <tromey@adacore.com>
2673
2674         * source-cache.c (highlighter): New global.
2675         (source_cache::get_source_lines): Create a highlighter on demand.
2676
2677 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2678
2679         * defs.h (deprecated_interactive_hook): Delete declaration.
2680         * interps.c (clear_interpreter_hooks): Remove use of
2681         deprecated_interactive_hook.
2682         * top.c (deprecated_interactive_hook): Delete definition.
2683         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2684
2685 2019-06-18  Tom de Vries  <tdevries@suse.de>
2686
2687         PR gdb/24515
2688         * dwarf2read.h (abstract_to_concrete): Change type from
2689         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2690         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2691         * dwarf2read.c (read_variable): Update.
2692         (dwarf2_fetch_die_loc_sect_off): Update.
2693
2694 2019-06-17  Tom de Vries  <tdevries@suse.de>
2695
2696         PR gdb/24617
2697         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2698         accessing parent[parent_len - 1].
2699
2700 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2701
2702         PR gdb/24364
2703         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2704         call dtrace_process_dof with NULL dof.
2705
2706 2019-06-16  Tom de Vries  <tdevries@suse.de>
2707
2708         PR gdb/24445
2709         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2710
2711 2019-06-16  Tom Tromey  <tom@tromey.com>
2712
2713         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2714         (make_all_visible): Use address of member.
2715
2716 2019-06-16  Tom Tromey  <tom@tromey.com>
2717
2718         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2719         (tui_free_window, free_content, free_content_elements): Remove
2720         unnecessary cast.
2721         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2722         cast.
2723         * tui/tui-regs.c (tui_show_register_group)
2724         (tui_display_registers_from, tui_display_reg_element_at_line):
2725         Remove unnecessary cast.
2726
2727 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2728
2729         * linux-nat.c (normal_mask): Delete.
2730         (_initialize_linux_nat): Don't initialise normal_mask.
2731
2732 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2733
2734         PR gdb/24445
2735         * dwarf-index-write.h (write_psymtabs_to_index): Add
2736         dwz_basename parameter.
2737         * dwarf-index-write.c (write_gdbindex): Move file writing to
2738         write_gdbindex_1.  Change return type void.
2739         (assert_file_size): Move up, remove filename parameter.
2740         (write_gdbindex_1): New function.
2741         (write_debug_names): Change return type to void, call
2742         assert_file_size.
2743         (struct index_wip_file): New struct.
2744         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2745         file logic to index_wip_file.  Write index for dwz file if
2746         needed.
2747         (save_gdb_index_command): Pass basename of dwz file, if present.
2748         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2749         build-id of dwz file, if present.
2750         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2751         (dwarf2_get_dwz_file): Likewise.
2752         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2753         (dwarf2_get_dwz_file): Likewise.
2754
2755 2019-06-16  Tom Tromey  <tom@tromey.com>
2756
2757         * coffread.c (process_coff_symbol): Use xstrdup.
2758         * value.c (create_internalvar): Use xstrdup.
2759
2760 2019-06-16  Tom Tromey  <tom@tromey.com>
2761
2762         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2763         * breakpoint.c (stopin_command, stopat_command)
2764         (until_break_command, decode_location_default): Remove unnecessary
2765         cast.
2766         * utils.c (subset_compare): Remove unnecessary cast.
2767         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2768         cast.
2769         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2770         cast.
2771         * infcmd.c (path_command): Remove unnecessary cast.
2772         * coffread.c (decode_type): Remove unnecessary cast.
2773         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2774         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2775         * tui/tui-stack.c (tui_show_locator_content)
2776         (tui_show_frame_info): Remove unnecessary cast.
2777         * tui/tui-win.c (tui_scroll_forward_command)
2778         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2779         (parse_scrolling_args): Remove unnecessary cast.
2780         * tui/tui-data.c (init_win_info, tui_del_window)
2781         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2782         (free_content_elements): Remove unnecessary cast.
2783         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2784         unnecessary cast.
2785         * tui/tui-source.c (tui_set_source_content)
2786         (tui_vertical_source_scroll): Remove unnecessary cast.
2787         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2788         cast.
2789         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2790         * tui/tui-regs.c (tui_display_registers_from)
2791         (tui_display_register): Remove unnecessary cast.
2792         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2793         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2794         (make_visible): Remove unnecessary cast.
2795         * tui/tui-winsource.c (tui_erase_source_content)
2796         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2797         unnecessary cast.
2798         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2799         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2800         * stabsread.c (read_type, read_array_type, read_range_type):
2801         Remove unnecessary cast.
2802         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2803         (parse_symbol, parse_type, upgrade_type, parse_external)
2804         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2805         unnecessary cast.
2806         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2807
2808 2019-06-16  Tom Tromey  <tom@tromey.com>
2809
2810         * tui/tui-data.c (tui_alloc_generic_win_info)
2811         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2812         checks.
2813
2814 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2815             Andrew Burgess  <andrew.burgess@embecosm.com>
2816
2817         * f-typeprint.c (f_print_type): Don't return early for not
2818         associated or not allocated types.
2819         (f_type_print_varspec_suffix): Add print_rank parameter and print
2820         ranks of array types in case they dangling.
2821         (f_type_print_base): Add print_rank parameter.
2822
2823 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2824
2825         * NEWS: Mention new MI commands.
2826         * break-catch-throw.c (enum exception_event_kind): Move to
2827         breakpoint.h.
2828         (print_mention_exception_catchpoint): Output text as a single
2829         message.
2830         (catch_exception_command_1): Rename to...
2831         (catch_exception_event): ...this, make non-static, update header
2832         command, and change some parameter types.
2833         (catch_catch_command): Update for changes to
2834         catch_exception_command_1.
2835         (catch_throw_command): Likewise.
2836         (catch_rethrow_command): Likewise.
2837         * breakpoint.c (enum exception_event_kind): Delete.
2838         * breakpoint.h (enum exception_event_kind): Moved here from
2839         break-catch-throw.c.
2840         (catch_exception_event): Declare.
2841         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2842         (mi_cmd_catch_throw): New function.
2843         (mi_cmd_catch_rethrow): New function.
2844         (mi_cmd_catch_catch): New function.
2845         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2846         'catch-catch' entries.
2847         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2848         (mi_cmd_catch_rethrow): Declare.
2849         (mi_cmd_catch_catch): Declare.
2850
2851 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2852
2853         * annotate.c (annotate_source_line): Change return type to void,
2854         update implementation to match.
2855         * annotate.h (annotate_source_line): Change return type to void,
2856         update header comment.
2857         * stack.c (print_frame_info): Don't change what frame information
2858         is printed based on whether annotations are on or not.
2859
2860 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2861
2862         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2863         (annotate_source): Make static.
2864         (annotate_source_line): Moved from source.c and renamed from
2865         identify_source_line.  Update the return type.
2866         * annotate.h (annotate_source): Delete declaration.
2867         (annotate_source_line): Declaration moved from source.h, and
2868         renamed from identify_source_line.  Return type updated.
2869         * source.c (identify_source_line): Moved to annotate.c and renamed
2870         to annotate_source_line.
2871         (info_line_command): Remove check of annotation_level.
2872         * source.h (identify_source_line): Move declaration to annotate.h
2873         and rename to annotate_source_line.
2874         * stack.c: Add 'annotate.h' include.
2875         (print_frame_info): Remove check of annotation_level before
2876         calling annotate_source_line.
2877
2878 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2879
2880         * source-cache.c (source_cache::get_plain_source_lines): Use
2881         open_source_file_with_line_charpos instead of just
2882         open_source_file, remove call to find_source_lines.
2883         (source_cache::get_source_lines): Likewise.
2884         * source.c (find_source_lines): Make static.
2885         (get_filename_and_charpos): Renamed into...
2886         (open_source_file_with_line_charpos): ..this along with changes to
2887         return a scoped_fd, and some other minor clean ups.
2888         (identify_source_line): Use open_source_file_with_line_charpos.
2889         (search_command_helper): Use open_source_file_with_line_charpos
2890         instead of just open_source_file, remove call to
2891         find_source_lines.
2892         * source.h (open_source_file_with_line_charpos): Declare new
2893         function.
2894         (find_source_lines): Delete declaration.
2895
2896 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2897
2898         * source.c (get_filename_and_charpos): Remove fullname
2899         parameter.
2900         (identify_source_line): Update call to get_filename_and_charpos.
2901
2902 2019-06-14  Tom Tromey  <tromey@adacore.com>
2903
2904         PR gdb/24502:
2905         * ui-style.h (skip_ansi_escape): Update comment.
2906         * ui-file.h (class no_terminal_escape_file): New class.
2907         * ui-file.c (no_terminal_escape_file::write)
2908         (no_terminal_escape_file::puts): New methods.
2909         * cli/cli-logging.c (handle_redirections): Use
2910         no_terminal_escape_file.
2911
2912 2019-06-14  Tom Tromey  <tromey@adacore.com>
2913
2914         * NEWS: Move convenience variable news above Python news.
2915
2916 2019-06-14  Tom Tromey  <tom@tromey.com>
2917
2918         * gnulib: Move directory to top-level.
2919         * configure.ac: Don't configure gnulib.
2920         * configure: Rebuild.
2921         * common/common-defs.h: Use new path to gnulib.
2922         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2923         (GNULIB_H): Remove.
2924         (INCGNU): Look in new gnulib location.
2925         (HFILES_NO_SRCDIR): Remove gnulib files.
2926         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2927         (generated_files): Remove GNULIB_H.
2928         ($(LIBGNU), all-lib): Remove targets.
2929         (distclean): Don't mention GNULIB_BUILDDIR.
2930         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2931
2932 2019-06-14  Tom Tromey  <tromey@adacore.com>
2933
2934         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2935         Warn if symbol file does not provide any symbols.
2936
2937 2019-06-14  Tom Tromey  <tromey@adacore.com>
2938
2939         * source.c (find_and_open_source): Respect basenames_may_differ.
2940
2941 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2942
2943         * annotate.c (annotate_breakpoints_invalid): Make use of
2944         scoped_restore_terminal_state.
2945         (annotate_frames_invalid): Likewise.
2946
2947 2019-06-14  Tom Tromey  <tromey@adacore.com>
2948
2949         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2950         allow assignment to an internalvar.
2951
2952 2019-06-14  Tom Tromey  <tromey@adacore.com>
2953
2954         * ada-lex.l: Allow "_" in attribute names.
2955
2956 2019-06-14  Tom Tromey  <tromey@adacore.com>
2957
2958         PR gdb/24653:
2959         * regcache.c (registers_changed): Don't call alloca.
2960         * top.c (execute_command): Don't call alloca.
2961
2962 2019-06-13  Pedro Alves  <palves@redhat.com>
2963
2964         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2965         'expression'.  When parsing an expression, error out if there's
2966         junk after "unlimited".
2967         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2968         (do_set_command): Adjust calls to is_unlimited_literal.
2969
2970 2019-06-13  Pedro Alves  <palves@redhat.com>
2971
2972         * compile/compile.c (make_compile_options_def_group): Add braces
2973         around array_view initializer.
2974         * thread.c (make_thread_apply_all_options_def_group)
2975         (make_thread_apply_all_options_def_group): Likewise.
2976
2977 2019-06-13  Pedro Alves  <palves@redhat.com>
2978
2979         * NEWS (New commands): Mention "maint test-options
2980         require-delimiter", "maint test-options unknown-is-error", "maint
2981         test-options unknown-is-operand" and "maint show
2982         test-options-completion-result".
2983         (New command options, command completion): New section.
2984         (Completion improvements): New section.
2985         Mention that you can abbreviate "unlimited".
2986
2987 2019-06-13  Pedro Alves  <palves@redhat.com>
2988
2989         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2990         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2991         * unittests/cli-utils-selftests.c (test_parse_flags)
2992         (test_parse_flags_qcs): Delete.
2993         (test_cli_utils): Don't call deleted functions.
2994
2995 2019-06-13  Pedro Alves  <palves@redhat.com>
2996
2997         * thread.c: Include "cli/cli-option.h".
2998         (tp_array_compar_ascending): Global.
2999         (tp_array_compar): Delete function.
3000         (tp_array_compar_ascending, tp_array_compar_descending): New
3001         functions.
3002         (ascending_option_def, qcs_flag_option_def)
3003         (thr_qcs_flags_option_defs)
3004         (make_thread_apply_all_options_def_group)
3005         (make_thread_apply_options_def_group): New.
3006         (thread_apply_all_command): Use gdb::option::process_options.
3007         (thread_apply_command_completer)
3008         (thread_apply_all_command_completer): New.
3009         (thread_apply_command): Use gdb::option::process_options.
3010         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3011         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3012         to generate help text of "thread apply".  Adjust "taas"'s help.
3013         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3014         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3015
3016 2019-06-13  Pedro Alves  <palves@redhat.com>
3017
3018         * thread.c (thread_apply_command): Check for invalid TID with
3019         isdigit instead of !isalpha.
3020
3021 2019-06-13  Pedro Alves  <palves@redhat.com>
3022
3023         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3024         (validate_flags_qcs): New.
3025         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3026         (validate_flags_qcs): Declare.
3027         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3028         (make_frame_apply_options_def_group): New.
3029         (frame_apply_command_count): Process options with
3030         gdb::option::process_options.
3031         (frame_apply_completer): New.
3032         (frame_apply_level_completer, frame_apply_all_completer)
3033         (frame_apply_completer): New.
3034         (_initialize_stack): Update help of "frame apply", "frame apply
3035         level", "frame apply all" and "faas" to mention supported options
3036         and install command completers.
3037         * stack.h (frame_apply_all_completer): Declare.
3038         * thread.c: Include "stack.h".
3039         (tfaas_command): Add "--".
3040         (_initialize_thread): Update help "tfaas" to mention supported
3041         options and install command completer.
3042
3043 2019-06-13  Pedro Alves  <palves@redhat.com>
3044
3045         * completer.c (complete_nested_command_line): New.
3046         (gdb_completion_word_break_characters_throw): Add assertion.
3047         * completer.h (complete_nested_command_line): Declare.
3048
3049 2019-06-13  Pedro Alves  <palves@redhat.com>
3050
3051         * stack.c (parse_backtrace_qualifiers): New.
3052         (backtrace_command): Use it.
3053         (backtrace_command_completer): Complete on qualifiers.
3054
3055 2019-06-13  Pedro Alves  <palves@redhat.com>
3056
3057         * frame.c: Include "cli/cli-option.h.
3058         (user_set_backtrace_options): New.
3059         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3060         Delete.
3061         (get_prev_frame): Adjust.
3062         (boolean_option_def, uinteger_option_def)
3063         (set_backtrace_option_defs): New.
3064         (_initialize_frame): Adjust and use
3065         gdb::option::add_setshow_cmds_for_options to install "set
3066         backtrace past-main" and "set backtrace past-entry".
3067         * frame.h: Include "cli/cli-option.h".
3068         (struct frame_print_options): Forward declare.
3069         (print_frame_arguments_all, print_frame_arguments_scalars)
3070         (print_frame_arguments_none): Declare.
3071         (print_entry_values): Delete declaration.
3072         (struct frame_print_options, user_frame_print_options): New.
3073         (struct set_backtrace_options): New.
3074         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3075         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3076         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3077         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3078         (list_args_or_locals): Add frame_print_options parameter.
3079         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3080         * python/py-framefilter.c (enumerate_args): Pass down
3081         USER_FRAME_PRINT_OPTIONS.
3082         * stack.c: Include "cli/cli-option.h".
3083         (print_frame_arguments_all, print_frame_arguments_scalars)
3084         (print_frame_arguments_none): Declare.
3085         (print_raw_frame_arguments, print_entry_values): Delete.
3086         (user_frame_print_options): New.
3087         (boolean_option_def, enum_option_def, frame_print_option_defs):
3088         New.
3089         (struct backtrace_cmd_options): New.
3090         (bt_flag_option_def): New.
3091         (backtrace_command_option_defs): New.
3092         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3093         (print_frame_arg, read_frame_arg, print_frame_args)
3094         (print_frame_info, print_frame): Add frame_print_options parameter
3095         and use it.
3096         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3097         (backtrace_command_1): Add frame_print_options and
3098         backtrace_cmd_options parameters and use them.
3099         (make_backtrace_options_def_group): New.
3100         (backtrace_command): Process command options with
3101         gdb::option::process_options.
3102         (backtrace_command_completer): New.
3103         (_initialize_stack): Extend "backtrace"'s help to mention
3104         supported options.  Install completer for "backtrace".
3105         Install some settings commands with add_setshow_cmds_for_options.
3106
3107 2019-06-13  Pedro Alves  <palves@redhat.com>
3108
3109         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3110         and that "set/show print raw frame-arguments" are now deprecated.
3111
3112         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3113         command.
3114         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3115         * stack.c (_initialize_stack): Install "set/show print
3116         raw-frame-arguments", and deprecate "set/show print raw
3117         frame-arguments".
3118         * valprint.c (_initialize_valprint): Deprecate "set/show print
3119         raw".
3120
3121 2019-06-13  Pedro Alves  <palves@redhat.com>
3122
3123         * compile/compile.c (struct compile_options): New.
3124         (compile_flag_option_def, compile_command_option_defs)
3125         (make_compile_options_def_group): New.
3126         (compile_file_command): Handle options with
3127         gdb::option::process_options.
3128         (compile_file_command_completer): New function.
3129         (compile_code_command): Handle options with
3130         gdb::option::process_options.
3131         (compile_code_command_completer): New function.
3132         (_initialize_compiler): Install completers for "compile code" and
3133         "compile file".  Mention available options in "compile code" and
3134         "compile code"'s help.
3135         * completer.c (advance_to_completion_word): New, factored out from
3136         ...
3137         (advance_to_expression_complete_word_point): ... this.
3138         (advance_to_filename_complete_word_point): New.
3139         * completer.h (advance_to_filename_complete_word_point): New
3140         declaration.
3141
3142 2019-06-13  Pedro Alves  <palves@redhat.com>
3143
3144         * compile/compile.c: Include "cli/cli-option.h".
3145         (compile_print_value): Scope data pointer is now a
3146         value_print_options pointer; adjust.
3147         (compile_print_command): Process options.  Scope data pointer is
3148         now a value_print_options pointer; adjust.
3149         (_initialize_compile): Update "compile print"'s help to include
3150         supported options.  Install a completer for "compile print".
3151         * cp-valprint.c (show_vtblprint, show_objectprint)
3152         (show_static_field_print): Delete.
3153         (_initialize_cp_valprint): Don't install "set print
3154         static-members", "set print vtbl", "set print object" here.
3155         * printcmd.c: Include "cli/cli-option.h" and
3156         "common/gdb_optional.h".
3157         (print_command_parse_format): Rework to fill in a
3158         value_print_options instead of a format_data.
3159         (print_value): Change parameter type from format_data pointer to
3160         value_print_options reference.  Adjust.
3161         (print_command_1): Process options.  Adjust to pass down a
3162         value_print_options.
3163         (print_command_completer): New.
3164         (_initialize_printcmd): Install print_command_completer as
3165         handle_brkchars completer for the "print" command.  Update
3166         "print"'s help to include supported options.
3167         * valprint.c: Include "cli/cli-option.h".
3168         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3169         here from cp-valprint.c.
3170         (boolean_option_def, uinteger_option_def)
3171         (value_print_option_defs, make_value_print_options_def_group):
3172         New.  Use gdb::option::add_setshow_cmds_for_options to install
3173         "set print elements", "set print null-stop", "set print repeats",
3174         "set print pretty", "set print union", "set print array", "set
3175         print address", "set print symbol", "set print array-indexes".
3176         * valprint.h: Include <string> and "cli/cli-option.h".
3177         (make_value_print_options_def_group): Declare.
3178         (print_value): Change parameter type from format_data pointer to
3179         value_print_options reference.
3180         (print_command_completer): Declare.
3181
3182 2019-06-13  Pedro Alves  <palves@redhat.com>
3183
3184         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3185         (COMMON_SFILES): Add maint-test-settings.c.
3186         * cli/cli-decode.c (boolean_enums): New global, factored out from
3187         ...
3188         (add_setshow_boolean_cmd): ... here.
3189         * cli/cli-decode.h (boolean_enums): Declare.
3190         * cli/cli-option.c: New file.
3191         * cli/cli-option.h: New file.
3192         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3193         factored out from ...
3194         (parse_cli_boolean_value(const char *)): ... this.
3195         (is_unlimited_literal): Change parameter type to pointer to
3196         pointer.  Adjust and advance ARG pointer.
3197         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3198         (parse_cli_var_enum): New, factored out from ...
3199         (do_set_command): ... this.  Adjust.
3200         * cli/cli-setshow.h (parse_cli_boolean_value)
3201         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3202         (parse_cli_var_enum): Declare.
3203         * cli/cli-utils.c: Include "cli/cli-option.h".
3204         (get_ulongest): New.
3205         * cli/cli-utils.h (get_ulongest): Declare.
3206         (check_for_argument): New overloads.
3207         * maint-test-options.c: New file.
3208
3209 2019-06-13  Pedro Alves  <palves@redhat.com>
3210
3211         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3212         parse a range if "-" is at the end of the string.
3213
3214 2019-06-13  Pedro Alves  <palves@redhat.com>
3215
3216         * cli/cli-setshow.c (parse_auto_binary_operation)
3217         (parse_cli_boolean_value): Don't allow "o".
3218
3219 2019-06-13  Pedro Alves  <palves@redhat.com>
3220
3221         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3222         * NEWS: Mention maint test-settings KIND.
3223         * maint-test-settings.c: New file.
3224
3225 2019-06-13  Pedro Alves  <palves@redhat.com>
3226
3227         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3228         completer.
3229         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3230         "set" completers.
3231
3232 2019-06-13  Pedro Alves  <palves@redhat.com>
3233
3234         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3235         after item.
3236
3237 2019-06-13  Pedro Alves  <palves@redhat.com>
3238
3239         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3240
3241 2019-06-13  Pedro Alves <palves@redhat.com>
3242
3243         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3244         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3245         call.
3246         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3247         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3248         calls.
3249         (check_for_argument): Skip spaces after argument.
3250
3251 2019-06-13  Pedro Alves  <palves@redhat.com>
3252
3253         * thread.c (thread_apply_command): Adjust TID parsing.
3254         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3255         detected before end of string.
3256         (tid_is_in_list): Error out if LIST is invalid.
3257
3258 2019-06-13  Pedro Alves  <palves@redhat.com>
3259
3260         * completer.c (complete_line_internal_1): Rewind completion word
3261         point.
3262         (completion_tracker::advance_custom_word_point_by): Change
3263         parameter type to int.
3264         * completer.h (completion_tracker::advance_custom_word_point_by):
3265         Likewise.
3266
3267 2019-06-13  Pedro Alves  <palves@redhat.com>
3268
3269         * completer.c (advance_to_completion_word): Handle delimiters.
3270
3271 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3272
3273         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3274
3275 2019-06-11  Tom Tromey  <tom@tromey.com>
3276
3277         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3278         (xmalloc_failed): Move to alloc.c.
3279         * alloc.c: New file.
3280         * Makefile.in (COMMON_SFILES): Add alloc.c.
3281
3282 2019-06-11  Tom Tromey  <tom@tromey.com>
3283
3284         * nat/linux-waitpid.c: Don't include server.h.
3285         (linux_debug): Remove.
3286         (my_waitpid): Update.
3287
3288 2019-06-11  Tom Tromey  <tromey@adacore.com>
3289
3290         * infcall.c (_initialize_infcall): Remove trailing newline from
3291         help.
3292         * user-regs.c (_initialize_user_regs): Remove trailing newline
3293         from help.
3294         * typeprint.c (_initialize_typeprint): Remove trailing newline
3295         from help.
3296         * reverse.c (_initialize_reverse): Remove trailing newlines from
3297         help.
3298         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3299         from help.
3300         * language.c (add_set_language_command): Remove trailing newline
3301         from help.
3302         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3303         help.
3304         * disasm.c (_initialize_disasm): Remove trailing newline from
3305         help.
3306         * top.c (init_main): Remove trailing newline from help.
3307         * interps.c (_initialize_interpreter): Remove trailing newline
3308         from help.
3309         * btrace.c (_initialize_btrace): Remove trailing newlines from
3310         help.
3311         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3312         from help.
3313         * python/python.c (_initialize_python): Remove trailing newline
3314         from help.
3315         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3316         help.
3317         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3318         from help.  Reformat some text.
3319         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3320         from help.
3321         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3322         newline from help.
3323
3324 2019-06-11  Tom Tromey  <tromey@adacore.com>
3325
3326         * darwin-nat.c (darwin_decode_exception_message)
3327         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3328
3329 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3330
3331         * valops.c (value_slice): Check for not allocated or not
3332         associated values.
3333
3334 2019-06-10  Tom de Vries  <tdevries@suse.de>
3335
3336         PR gdb/24618
3337         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3338         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3339         invalid.
3340
3341 2019-06-10  Tom de Vries  <tdevries@suse.de>
3342
3343         PR gdb/24611
3344         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3345         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3346
3347 2019-06-10  Tom de Vries  <tdevries@suse.de>
3348
3349         PR symtab/24545
3350         * symtab.c (struct demangled_name_entry): Add language field.
3351         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3352         static minimal symbol".  Set and use language field.
3353
3354 2019-06-10  Tom Tromey  <tromey@adacore.com>
3355
3356         * ada-lang.c (_initialize_ada_language): Update help text.
3357
3358 2019-06-10  Tom Tromey  <tromey@adacore.com>
3359
3360         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3361         with a newline.
3362         * guile/guile.c (handle_boot_error): Don't end warning with a
3363         newline.
3364         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3365         warning with a newline.
3366         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3367         newline.
3368         (s12z_frame_cache): Likewise.
3369         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3370         a newline.
3371         * solib-svr4.c (disable_probes_interface): Don't end warning with
3372         a newline.
3373         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3374         newline.
3375         * python/python.c (do_finish_initialization): Don't end warning
3376         with a newline.
3377
3378 2019-06-10  Tom Tromey  <tom@tromey.com>
3379
3380         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3381         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3382         gdbpy_enter.
3383
3384 2019-06-10  Tom Tromey  <tromey@adacore.com>
3385
3386         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3387         data.
3388         (elf_new_init): Don't call stabsread_new_init.
3389         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3390         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3391         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3392
3393 2019-06-10  Tom de Vries  <tdevries@suse.de>
3394
3395         PR symtab/16264
3396         PR symtab/24517
3397         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3398
3399 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3400
3401         * source.c (find_and_open_source): Also rewrite relative file
3402         names.
3403
3404 2019-04-26  Amos Bird  <amosbird@gmail.com>
3405
3406         * annotate.c (annotate_thread_exited): Add "thread-exited"
3407         annotation.
3408
3409 2019-06-06  Tom Tromey  <tromey@adacore.com>
3410
3411         * maint.h (class scoped_command_stats): Use
3412         DISABLE_COPY_AND_ASSIGN.
3413         <print_time>: New method.
3414         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3415         print_time.
3416         (scoped_command_stats::print_time): New method.
3417
3418 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3419
3420         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3421         instructions of lengths 6 or 8 bytes.
3422
3423 2019-06-04  Pedro Alves  <palves@redhat.com>
3424
3425         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3426
3427         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3428         * breakpoint.c (condition_completer): Likewise.
3429         * cli/cli-dump.c (scan_expression): Likewise.
3430         * common/filestuff.c (mkdir_recursive): Likewise.
3431         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3432         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3433         (gdb_abspath): Likewise.
3434         * compile/compile-cplus-types.c
3435         (compile_cplus_instance::decl_name): Likewise.
3436         * completer.c (complete_explicit_location):
3437         (signal_completer, reg_or_group_completer_1): Likewise.
3438         * cp-support.c (cp_remove_params_if_any): Likewise.
3439         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3440         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3441         * infcmd.c (strip_bg_char): Likewise.
3442         * linespec.c (copy_token_string): Likewise.
3443         * mi/mi-main.c (output_cores): Likewise.
3444         * psymtab.c (psymtab_search_name):
3445         * symfile.c (test_set_ext_lang_command): Likewise.
3446         * target.c (target_fileio_read_stralloc): Likewise.
3447         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3448         * value.c (complete_internalvar): Likewise.
3449
3450 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3451
3452         Add objfile property to gdb.Type.
3453         * NEWS: Mention Python API addition.
3454         * python/py-type.c (typy_get_objfile): New method.
3455
3456 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3457
3458         * NEWS: Mention the new set|show style [title|highlight].
3459         Mention changes to "show style", "help" and "apropos".
3460
3461 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3462
3463         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3464         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3465         instead of print_help_for_command.
3466         (print_doc_of_command): New function.
3467         (help_list): Add 'apropos -v word' suggestion.
3468         (print_help_for_command): Style the command name using title style.
3469         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3470         (_initialize_cli_cmds): Describe -v in apropos_command help.
3471
3472 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3473
3474         * cli/cli-style.h (cli_style_option): Add name in constructor,
3475         add m_name class member, add constructor with intensity,
3476         add name class function.
3477         (cli_style_option::add_setshow_commands): Remove name argument.
3478         (highlight_style, title_style): New styles.
3479         * cli/cli-style.c (do_show): New function that shows a style
3480         characteristic styling the style name with itself.
3481         (set_style_name): New function.
3482         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3483         Update all callers according to the changes in cli/cli-style.h.
3484         * utils.h (fputs_highlighted): New function.
3485         * utils.c (fputs_highlighted): Likewise.
3486
3487 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3488
3489         * NEWS: Mention new pipe command and new convenience variables.
3490
3491 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3492
3493         * cli/cli-cmds.c (pipe_command): New function.
3494         (_initialize_cli_cmds): Call add_com for pipe_command.
3495         Define | as an alias for pipe.
3496         (exit_status_set_internal_vars): New function.
3497         (shell_escape): Call exit_status_set_internal_vars.
3498         cli/cli-decode.c (find_command_name_length): Recognize | as
3499         a single character command.
3500
3501 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3502
3503         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3504         top.c (execute_command_to_ui_file): New function, mostly a copy
3505         of execute_command_to_string.
3506         (execute_command_to_string): Implement by calling
3507         execute_command_to_ui_file.
3508
3509 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3510
3511         * top.h (saved_command_line): Remove declaration.
3512         * top.c (previous_saved_command_line, previous_repeat_arguments):
3513         New variables.
3514         (saved_command_line): Make static, define together with other
3515         'repeat variables'.
3516         (dont_repeat): Clear repeat_arguments.
3517         (repeat_previous, get_saved_command_line, save_command_line):
3518         New functions.
3519         (gdb_init): Initialize saved_command_line
3520         and previous_saved_command_line.
3521         * main.c (captured_main_1): Remove saved_command_line initialization.
3522         * event-top.c (handle_line_of_input): Update to use
3523         the new 'repeat' related functions instead of direct access to
3524         saved_command_line.
3525         * command.h (repeat_previous, get_saved_command_line,
3526         save_command_line): New declarations.
3527         (dont_repeat): Add comment.
3528
3529 2019-05-30  Tom Tromey  <tromey@adacore.com>
3530
3531         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3532         Fix comment.
3533         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3534
3535 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3536
3537         PR cli/24587
3538         * completer.c (complete): Initialize variable word.
3539
3540 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3541
3542         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3543         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3544         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3545         'body' is NULL to the outter 'if', protecting the '!is_define'
3546         situation as well.
3547
3548 2019-05-29  Tom Tromey  <tromey@adacore.com>
3549
3550         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3551         (dwarf_unknown): New function.
3552         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3553         (dwarf_type_encoding_name): Use dwarf_unknown.
3554
3555 2019-05-29  Tom Tromey  <tromey@adacore.com>
3556
3557         PR c++/20020:
3558         * cp-valprint.c (cp_print_value_fields): Call
3559         cp_print_static_field inside "try".
3560
3561 2019-05-29  Tom Tromey  <tromey@adacore.com>
3562
3563         * inflow.c (struct terminal_info): Add default operator=.
3564         * configure: Rebuild.
3565         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3566         -Wdeprecated-copy-dtor, -Wredundant-move.
3567
3568 2019-05-29  Tom Tromey  <tromey@adacore.com>
3569
3570         * NEWS: Add entry.
3571         * infcmd.c (print_return_value_1): Handle finish_print
3572         option.
3573         (show_print_finish): New function.
3574         (_initialize_infcmd): Add "set/show print finish" commands.
3575         * valprint.c (user_print_options): Initialize new member.
3576         * valprint.h (struct value_print_options) <finish_print>: New
3577         member.
3578
3579 2019-05-28  Tom Tromey  <tromey@adacore.com>
3580
3581         * ada-lang.c (ada_remove_Xbn_suffix)
3582         (find_old_style_renaming_symbol)
3583         (parse_old_style_renaming): Remove.
3584         (ada_find_renaming_symbol): Don't call
3585         find_old_style_renaming_symbol.
3586         (ada_is_renaming_symbol): Rename from
3587         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3588         bool.  Now static.
3589         (ada_read_var_value): Update and simplify.
3590         * ada-exp.y (write_var_or_type): Remove old code.
3591
3592 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3593
3594         * event-top.c: Remove include comment.
3595         * inflow.c (class scoped_ignore_sigttou): Move from here...
3596         * inflow.h (class scoped_ignore_sigttou): ...to here.
3597         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3598         * top.c:  Remove include comment.
3599
3600 2019-05-27  Tom Tromey  <tom@tromey.com>
3601
3602         * NEWS: Fix typo.
3603
3604 2019-05-22  Tom Tromey  <tromey@adacore.com>
3605
3606         * target.c (target_follow_exec): Constify parameter.
3607         * target-delegates.c: Rebuild.
3608         * remote.c (remote_target::follow_exec): Constify parameter.
3609         * infrun.c (follow_exec): Constify parameter.
3610         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3611         (target_follow_exec): Likewise.
3612
3613 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3614
3615         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3616         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3617
3618 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3619
3620         * NEWS: Add debugredirect and testsuite sections.
3621
3622 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3623
3624         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3625         target descriptions using exclusively floating point register name
3626         aliases.
3627
3628 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3629
3630         PR gdb/18644:
3631         * f-lang.c (build_fortran_types): Handle the case where
3632         gdbarch_floatformat_for_type returns a nullptr.
3633
3634 2019-05-21  Tom de Vries  <tdevries@suse.de>
3635
3636         PR cli/24587
3637         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3638
3639 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3640
3641         PR gdb/18644:
3642         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3643         16-byte floats.
3644         * i386-tdep.c (i386_floatformat_for_type): Use
3645         floatformats_ia64_quad for the 16-byte floating point component
3646         within a fortran 32-byte complex number.
3647
3648 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3649
3650         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3651         delete default constructor.
3652         (find_partial_die): Update to return const struct.
3653         (partial_die_parent_scope): Move variable declaration into scope
3654         of its use and change its type to auto.
3655         (guess_partial_die_structure_name): Likewise.
3656         (partial_die_info::fixup): Likewise.
3657
3658 2019-05-17  Tom Tromey  <tromey@adacore.com>
3659
3660         * source.c (find_and_open_source): Remove cast.
3661
3662 2019-05-17  Tom Tromey  <tromey@adacore.com>
3663
3664         * annotate.c (annotate_source): Make "filename" const.
3665         * annotate.h (annotate_source): Use const.
3666
3667 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3668
3669         * disasm.c (set_disassembler_options): Send errors to stderr.
3670
3671 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3672
3673         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3674         (cli_interp_base::set_logging): Check debug_redirect.
3675         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3676         * cli/cli-logging.c (debug_redirect): Add static variable.
3677         (pop_output_files): Add default param.
3678         (handle_redirections): Print debug setting.
3679         (show_logging_command): Likewise.
3680         (_initialize_cli_logging): Add debugredirect command.
3681         * interps.c (current_interp_set_logging): Add debug_redirect
3682         parameter.
3683         * interps.h (set_logging): Add debug_redirect parameter.
3684         (current_interp_set_logging): Likewise.
3685         * mi/mi-common.h: Likewise.
3686         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3687
3688 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3689             Tom Tromey  <tromey@adacore.com>
3690
3691         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3692         directly.
3693         * cli/cli-interp.h (make_logging_output): Remove declaration.
3694         * cli/cli-logging.c (make_logging_output): Remove function.
3695         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3696         directly.
3697         * ui-file.c (tee_file::tee_file): Remove bools.
3698         (tee_file::~tee_file): Remove deletes.
3699         * ui-file.h (tee_file): Remove bools.
3700
3701 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3702
3703         * mi/mi-cmds.h (mi_cmd_complete): New function.
3704         * mi/mi-main.c (mi_cmd_complete): Likewise.
3705         * mi/mi-cmds.c: Define new MI command -complete.
3706         * NEWS: Mention new -complete command.
3707
3708 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3709
3710         * completer.h (complete): New function.
3711         * completer.c (complete): Likewise.
3712         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3713         function defined in completer.h.
3714
3715 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3716
3717         * MAINTAINERS (Write After Approval): Add myself.
3718
3719 2019-05-17  Tom de Vries  <tdevries@suse.de>
3720
3721         PR gdb/24094
3722         * dwarf2read.c (struct cu_partial_die_info): New struct.
3723         (find_partial_die): Return cu_partial_die_info.
3724         (partial_die_parent_scope, guess_partial_die_structure_name)
3725         (partial_die_info::fixup): Handle new return type of find_partial_die.
3726
3727 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3728
3729         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3730         "std::string", simplifying the algorithm.
3731
3732 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3733
3734         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3735         (stap_static_probe_ops::get_probes): Likewise.
3736
3737 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3738
3739         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3740         '-')" and "else if".
3741         (stap_parse_single_operand): Join checks for
3742         "gdbarch_stap_parse_special_token_p" and
3743         "gdbarch_stap_parse_special_token" in the same "if" statement.
3744         Invert check when verifying for operation on register
3745         displacement.
3746
3747 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3748
3749         * stap-probe.c (stap_get_opcode): Update comment.
3750         (stap_get_expected_argument_type): Likewise.
3751         (handle_stap_probe): Likewise.
3752
3753 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3754
3755         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3756         return type to 'bool'.  Adjust comment.  Use 'bool' when
3757         appropriate.
3758         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3759         * stap-probe.c (stap_parse_argument_1): Likewise.
3760         (stap_is_operator): Likewise.
3761         (stap_is_generic_prefix): Likewise.
3762         (stap_is_register_prefix): Likewise.
3763         (stap_is_register_indirection_prefix): Likewise.
3764         (stap_is_integer_prefix): Likewise.
3765         (stap_generic_check_suffix): Likewise.
3766         (stap_check_integer_suffix): Likewise.
3767         (stap_check_register_suffix): Likewise.
3768         (stap_check_register_indirection_suffix): Likewise.
3769         (stap_parse_register_operand): Likewise.
3770         (stap_parse_single_operand): Likewise.
3771         (stap_parse_argument_1): Likewise.
3772         (stap_probe::get_argument_count): Likewise.
3773         (stap_is_operator): Likewise.
3774
3775 2019-05-16  Tom Tromey  <tromey@adacore.com>
3776
3777         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3778         keyword to foreach.
3779
3780 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3781
3782         * linux-thread-db.c (try_thread_db_load_1): Change return type
3783         to bool.
3784         (try_thread_db_load): Likewise.
3785         (try_thread_db_load_from_pdir_1): Likewise.
3786         (try_thread_db_load_from_pdir): Likewise.
3787         (try_thread_db_load_from_sdir): Likewise.
3788         (try_thread_db_load_from_dir): Likewise.
3789         (thread_db_load_search): Likewise.
3790         (has_libpthread): Likewise.
3791         (thread_db_load): Likewise.
3792
3793 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3794
3795         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3796         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3797         NULL, and complain/return if that's the case.
3798
3799 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3800
3801         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3802         (advance, posn, abstract_read_memory): New functions.
3803         [struct mem_read_abstraction]: New struct.
3804         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3805
3806 2019-05-14  Tom Tromey  <tromey@adacore.com>
3807
3808         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3809         value is not lval_memory.
3810
3811 2019-05-14  Tom Tromey  <tromey@adacore.com>
3812
3813         * solib.c (info_sharedlibrary_command): Style the file name.
3814
3815 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3816
3817         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3818         (aarch64_vnv_type): Likewise.
3819         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3820         * common/tdesc.c: Likewise.
3821         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3822         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3823         * features/aarch64-fpu.xml: Add ieee half view.
3824         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3825         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3826         * gdbtypes.h (struct builtin_type): Likewise.
3827         (struct objfile_type): Likewise.
3828
3829 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3830
3831         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3832         typo.
3833         * location.h (string_to_event_location): Likewise.
3834
3835 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3836
3837         GDB 8.3 released.
3838
3839 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3840
3841         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3842         New variable declaration.
3843         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3844         New variable.
3845         (print_one_breakpoint): Use ui_out::test_flags and new global
3846         variable to compute use_fixed_output.
3847         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3848         Remove.
3849         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3850         (mi_multi_location_breakpoint_output_fixed): Remove.
3851         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3852         new variable.
3853         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3854         fix_multi_location_breakpoint_output flag if version >= 3.
3855         * ui-out.h (enum ui_out_flag)
3856         <fix_multi_location_breakpoint_output>: New enumerator.
3857
3858 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3859
3860         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3861
3862 2019-05-10  Tom Tromey  <tromey@adacore.com>
3863
3864         * ada-lang.c (catch_ada_completer): New function.
3865         (_initialize_ada_language): Use it.
3866
3867 2019-05-10  Tom Tromey  <tromey@adacore.com>
3868
3869         * thread.c (print_thread_info): Make "requested_threads" const.
3870         * gdbthread.h (print_thread_info): Make "requested_threads"
3871         const.
3872         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3873         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3874
3875 2019-05-08  Tom Tromey  <tom@tromey.com>
3876
3877         * gdbtypes.c (objfile_type_data): Change type.
3878         (objfile_type, _initialize_gdbtypes): Update.
3879
3880 2019-05-08  Tom Tromey  <tom@tromey.com>
3881
3882         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3883         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3884         (_initialize_dwarf2_frame): Update.
3885
3886 2019-05-08  Tom Tromey  <tom@tromey.com>
3887
3888         * objc-lang.c (objc_objfile_data): Change type.
3889         (find_methods): Update.
3890         (_initialize_objc_lang): Remove.
3891
3892 2019-05-08  Tom Tromey  <tom@tromey.com>
3893
3894         * stabsread.c (rs6000_builtin_type_data): Change type.
3895         (rs6000_builtin_type, _initialize_stabsread): Update.
3896
3897 2019-05-08  Tom Tromey  <tom@tromey.com>
3898
3899         * mips-tdep.c (mips_pdr_data): Remove.
3900         (_initialize_mips_tdep): Update.
3901
3902 2019-05-08  Tom Tromey  <tom@tromey.com>
3903
3904         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3905         (hppa_init_objfile_priv_data, read_unwind_info)
3906         (find_unwind_entry, _initialize_hppa_tdep): Update.
3907
3908 2019-05-08  Tom Tromey  <tom@tromey.com>
3909
3910         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3911         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3912         on obstack.
3913         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3914
3915 2019-05-08  Tom Tromey  <tom@tromey.com>
3916
3917         * mdebugread.c (basic_type_data): Change type.
3918         (basic_type, _initialize_mdebugread): Update.
3919
3920 2019-05-08  Tom Tromey  <tom@tromey.com>
3921
3922         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3923
3924 2019-05-08  Tom Tromey  <tom@tromey.com>
3925
3926         * nto-tdep.c (nto_inferior_data_reg): Change type.
3927         (nto_inferior_data): Update.
3928         (nto_inferior_data_cleanup, nto_new_inferior_data)
3929         (_initialize_nto_tdep): Remove.
3930         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3931
3932 2019-05-08  Tom Tromey  <tom@tromey.com>
3933
3934         * ada-lang.c (struct ada_inferior_data): Add initializers.
3935         (ada_inferior_data): Change type.
3936         (ada_inferior_data_cleanup): Remove.
3937         (get_ada_inferior_data, ada_inferior_exit)
3938         (struct ada_pspace_data): Add initializers, destructor.
3939         (ada_pspace_data_handle): Change type.
3940         (get_ada_pspace_data): Update.
3941         (ada_pspace_data_cleanup): Remove.
3942
3943 2019-05-08  Tom Tromey  <tom@tromey.com>
3944
3945         * coffread.c (struct coff_symfile_info): Add initializers.
3946         (coff_objfile_data_key): Move lower.  Change type.
3947         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3948         Update.
3949         (coff_free_info): Remove.
3950
3951 2019-05-08  Tom Tromey  <tom@tromey.com>
3952
3953         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3954         (fbsd_pspace_data_handle): Move lower.  Change type.
3955         (get_fbsd_pspace_data): Update.
3956         (fbsd_pspace_data_cleanup): Remove.
3957         (_initialize_fbsd_tdep): Update.
3958
3959 2019-05-08  Tom Tromey  <tom@tromey.com>
3960
3961         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3962         (get_ada_tasks_pspace_data): Update.
3963         (ada_tasks_pspace_data_cleanup): Remove.
3964         (_initialize_tasks): Update.
3965         (ada_tasks_inferior_data_handle): Change type.
3966         (get_ada_tasks_inferior_data): Update.
3967         (ada_tasks_inferior_data_cleanup): Remove.
3968         (struct ada_tasks_pspace_data): Add initializers.
3969
3970 2019-05-08  Tom Tromey  <tom@tromey.com>
3971
3972         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3973         * symfile-debug.c (debug_sym_get_probes): Change type.
3974         * stap-probe.c (handle_stap_probe):
3975         (stap_static_probe_ops::get_probes): Change type.
3976         * probe.h (class static_probe_ops) <get_probes>: Change type.
3977         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3978         (parse_probes_in_pspace): Update.
3979         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3980         Update.
3981         (any_static_probe_ops::get_probes): Change type.
3982         * elfread.c (elfread_data): New typedef.
3983         (probe_key): Change type.
3984         (elf_get_probes): Likewise.  Update.
3985         (probe_key_free): Remove.
3986         (_initialize_elfread): Update.
3987         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3988         Change type.
3989         (dtrace_process_dof_probe, dtrace_process_dof)
3990         (dtrace_static_probe_ops::get_probe): Change type.
3991
3992 2019-05-08  Tom Tromey  <tom@tromey.com>
3993
3994         * xcoffread.c (struct xcoff_symfile_info): Rename from
3995         coff_symfile_info.  Add initializers.
3996         (xcoff_objfile_data_key): Move lower.  Change type.
3997         (XCOFF_DATA): Rewrite.
3998         (xcoff_free_info): Remove.
3999         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4000         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4001         (xcoff_initial_scan): Update.
4002
4003 2019-05-08  Tom Tromey  <tom@tromey.com>
4004
4005         * solib-svr4.c (struct svr4_info): Add initializers and
4006         destructor.
4007         <probes_table>: Now an htab_up.
4008         (solib_svr4_pspace_data): Change type.
4009         (free_probes_table): Simplify.
4010         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4011         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4012         (probes_table_remove_objfile_probes, register_solib_event_probe)
4013         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4014         (_initialize_svr4_solib): Update.
4015
4016 2019-05-08  Tom Tromey  <tom@tromey.com>
4017
4018         * remote.c (remote_pspace_data): Change type.
4019         (remote_pspace_data_cleanup): Remove.
4020         (get_remote_exec_file, set_pspace_remote_exec_file)
4021         (_initialize_remote): Update.
4022
4023 2019-05-08  Tom Tromey  <tom@tromey.com>
4024
4025         * breakpoint.c (breakpoint_objfile_key): Change type.
4026         (get_breakpoint_objfile_data): Update.
4027         (free_breakpoint_objfile_data): Remove.
4028         (_initialize_breakpoint): Update.
4029
4030 2019-05-08  Tom Tromey  <tom@tromey.com>
4031
4032         * linux-tdep.c (struct linux_info): Add initializers.
4033         (linux_inferior_data): Move.  Change type.
4034         (invalidate_linux_cache_inf): Update.
4035         (linux_inferior_data_cleanup): Remove.
4036         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4037
4038 2019-05-08  Tom Tromey  <tom@tromey.com>
4039
4040         * auxv.c (auxv_inferior_data): Move.  Change type.
4041         (auxv_inferior_data_cleanup): Remove.
4042         (invalidate_auxv_cache_inf): Rewrite.
4043         (get_auxv_inferior_data, _initialize_auxv): Update.
4044
4045 2019-05-08  Tom Tromey  <tom@tromey.com>
4046
4047         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4048         (symfile_debug_objfile_data_key): Change type.
4049         (symfile_debug_installed, debug_qf_has_symbols)
4050         (debug_qf_find_last_source_symtab)
4051         (debug_qf_forget_cached_source_info)
4052         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4053         (debug_qf_print_stats, debug_qf_dump)
4054         (debug_qf_expand_symtabs_for_function)
4055         (debug_qf_expand_all_symtabs)
4056         (debug_qf_expand_symtabs_with_fullname)
4057         (debug_qf_map_matching_symbols)
4058         (debug_qf_expand_symtabs_matching)
4059         (debug_qf_find_pc_sect_compunit_symtab)
4060         (debug_qf_map_symbol_filenames)
4061         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4062         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4063         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4064         (debug_sym_read_linetable, debug_sym_relocate): Update.
4065         (symfile_debug_free_objfile): Remove.
4066         (install_symfile_debug_logging, _initialize_symfile_debug):
4067         Update.
4068
4069 2019-05-08  Tom Tromey  <tom@tromey.com>
4070
4071         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4072         allocate_on_obstack.
4073         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4074         (get_dwarf2_per_objfile): Update.
4075         (set_dwarf2_per_objfile): Remove.
4076         (dwarf2_has_info, dwarf2_get_section_info): Update.
4077         (dwarf2_free_objfile): Remove.
4078         (_initialize_dwarf2_read): Update.
4079
4080 2019-05-08  Tom Tromey  <tom@tromey.com>
4081
4082         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4083         initializers.
4084         <unsupported_script_warning_printed,
4085         script_not_found_warning_printed>: Now bool.
4086         (auto_load_pspace_data): Change type.
4087         (~auto_load_pspace_info): Rename from
4088         auto_load_pspace_data_cleanup.
4089         (get_auto_load_pspace_data, init_loaded_scripts_info)
4090         (clear_section_scripts, maybe_print_unsupported_script_warning)
4091         (maybe_print_script_not_found_warning, _initialize_auto_load):
4092         Update.
4093
4094 2019-05-08  Tom Tromey  <tom@tromey.com>
4095
4096         * objfiles.c (objfile_pspace_info): Add destructor and
4097         initializers.
4098         (objfiles_pspace_data): Change type.
4099         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4100         (get_objfile_pspace_data): Update.
4101         (objfiles_bfd_data): Change type.
4102         (get_objfile_bfd_data): Update.
4103         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4104
4105 2019-05-08  Tom Tromey  <tom@tromey.com>
4106
4107         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4108         Change type.
4109         (get_catch_syscall_inferior_data): Update.
4110         (catch_syscall_inferior_data_cleanup): Remove.
4111         (_initialize_break_catch_syscall): Update.
4112
4113 2019-05-08  Tom Tromey  <tom@tromey.com>
4114
4115         * inflow.c (struct terminal_info): Add destructor and
4116         initializers.
4117         (inflow_inferior_data): Change type.
4118         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4119         (get_inflow_inferior_data, inflow_inferior_exit)
4120         (swap_terminal_info, _initialize_inflow): Update.
4121
4122 2019-05-08  Tom Tromey  <tom@tromey.com>
4123
4124         * target-dcache.c (target_dcache_cleanup): Remove.
4125         (target_dcache_aspace_key): Change type.
4126         (target_dcache_init_p, target_dcache_invalidate)
4127         (target_dcache_get, target_dcache_get_or_init)
4128         (_initialize_target_dcache): Update.
4129         * dcache.h (struct dcache_deleter): New.
4130
4131 2019-05-08  Tom Tromey  <tom@tromey.com>
4132
4133         * symtab.c (struct symbol_cache): Add destructor and
4134         initializers.
4135         (symbol_cache_key): Move.  Change type.
4136         (make_symbol_cache, free_symbol_cache): Remove.
4137         (get_symbol_cache): Update.
4138         (symbol_cache_cleanup): Remove.
4139         (ALL_PSPACES, symbol_cache_flush)
4140         (maintenance_print_symbol_cache)
4141         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4142         Update.
4143
4144 2019-05-08  Tom Tromey  <tom@tromey.com>
4145
4146         * symtab.c (struct main_info): Add destructor and initializers.
4147         (main_progspace_key): Move.  Change type.
4148         (get_main_info): Update.
4149         (main_info_cleanup): Remove.
4150         (_initialize_symtab): Update.
4151
4152 2019-05-08  Tom Tromey  <tom@tromey.com>
4153
4154         * registry.h (DECLARE_REGISTRY): Define the _key class.
4155
4156 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4157
4158         * NEWS: Merge two 'New commands' sections.
4159
4160 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4161
4162         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4163         parameter and use Ada language definition instead.
4164         (ada_val_print_ptr): Remove unused language parameter.
4165         (ada_val_print_num): Remove language parameter and use Ada language
4166         definition instead.
4167         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4168         parameter.
4169         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4170         parameter and use Ada language definition instead.
4171         (ada_val_print_1): Update all ada_val_print_xxx calls.
4172         Remove language parameter.
4173         (ada_val_print): Update ada_val_print_1 call.
4174
4175 2019-05-08  Tom Tromey  <tromey@adacore.com>
4176
4177         * remote.c (remote_hw_watchpoint_limit)
4178         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4179         Now static.
4180
4181 2019-05-08  Tom Tromey  <tromey@adacore.com>
4182
4183         * maint.c (_initialize_maint_cmds): Move initialization code to
4184         remote.c.
4185         (watchdog, show_watchdog): Move to remote.c.
4186         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4187         "watchdog" static.
4188         (_initialize_remote): Move initialization code from maint.c.
4189         * defs.h (watchdog): Don't declare.
4190
4191 2019-05-08  Tom Tromey  <tromey@adacore.com>
4192
4193         * tui/tui-interp.c: Include main.h.
4194         * interps.c: Include main.h.
4195         * main.h (interpreter_p): Declare.
4196         * defs.h (interpreter_p): Don't declare.
4197
4198 2019-05-08  Tom Tromey  <tromey@adacore.com>
4199
4200         * dwarf2loc.c: Include dwarf2read.h.
4201         * defs.h (read_unsigned_leb128): Don't declare.
4202         * dwarf2read.h (read_unsigned_leb128): Declare.
4203
4204 2019-05-08  Tom Tromey  <tromey@adacore.com>
4205
4206         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4207         method.
4208
4209 2019-05-08  Tom Tromey  <tromey@adacore.com>
4210
4211         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4212         when no wrap column is set.
4213
4214 2019-05-08  Tom Tromey  <tromey@adacore.com>
4215
4216         * c-lang.c (c_get_string): Handle non-C-style arrays.
4217
4218 2019-05-08  Tom Tromey  <tromey@adacore.com>
4219
4220         * typeprint.c (print_offset_data::update): Print the bit offset,
4221         not the number of bits remaining.
4222
4223 2019-05-08  Tom Tromey  <tromey@adacore.com>
4224
4225         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4226         padding at end of comment.
4227
4228 2019-05-08  Tom Tromey  <tromey@adacore.com>
4229
4230         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4231         Compare main types.
4232
4233 2019-05-06  Tom Tromey  <tom@tromey.com>
4234
4235         * common/scoped_mmap.c: Include common-defs.h.
4236         * common/scoped_mmap.h: Don't include config.h.
4237
4238 2019-05-04  Tom Tromey  <tom@tromey.com>
4239
4240         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4241         (struct aarch64_call_info): Add initializers.
4242         <si>: Now a std::vector.
4243         (pass_on_stack, aarch64_push_dummy_call): Update.
4244
4245 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4246             Tom Tromey  <tom@tromey.com>
4247
4248         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4249         (ppc_threads): Now a std::vector.  Now static.
4250         (hwdebug_find_thread_points_by_tid)
4251         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4252         Update.
4253
4254 2019-05-04  Tom Tromey  <tom@tromey.com>
4255
4256         * arc-tdep.c (arc_tdesc_init): Return bool.
4257
4258 2019-05-04  Tom Tromey  <tom@tromey.com>
4259
4260         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4261         Use gdb_assert_not_reached.
4262
4263 2019-05-04  Tom Tromey  <tom@tromey.com>
4264
4265         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4266         "false".
4267
4268 2019-05-04  Tom Tromey  <tom@tromey.com>
4269
4270         * arc-tdep.c (arc_tdesc_init): Use bool.
4271
4272 2019-05-04  Tom Tromey  <tom@tromey.com>
4273
4274         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4275
4276 2019-05-04  Tom Tromey  <tom@tromey.com>
4277
4278         * cli/cli-cmds.c (valid_command_p): Return bool.
4279
4280 2019-05-04  Tom Tromey  <tom@tromey.com>
4281
4282         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4283         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4284
4285 2019-05-04  Raul Tambre  <raul@tambre.ee>
4286
4287         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4288         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4289         operator for comparison.
4290
4291 2019-05-04  Tom Tromey  <tom@tromey.com>
4292
4293         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4294         (lookup_partial_symbol, print_partial_symbols)
4295         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4296         (psymbol_compare): Update.
4297         (add_psymbol_to_bcache): Clear the entire psymbol.
4298         (maintenance_check_psymtabs): Update.
4299         * psympriv.h (struct partial_symbol): Don't derive from
4300         general_symbol_info.
4301         <obj_section, unrelocated_address, address,
4302         set_unrelocated_address>: Update.
4303         <ginfo>: New member.
4304         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4305         (debug_names::write_psymbols): Update.
4306
4307 2019-05-04  Tom de Vries  <tdevries@suse.de>
4308
4309         * contrib/cc-with-tweaks.sh: Support -n arg.
4310
4311 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4312
4313         * corelow.c (core_target::detach): Ensure frame cache and
4314         register caches are cleared.
4315         inferior.c (exit_inferior_1): Likewise.
4316
4317 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4318             Tom Tromey  <tom@tromey.com>
4319
4320         * dictionary.c (collate_pending_symbols_by_language): Remove
4321         "struct" from foreach.
4322         * symtab.c (lookup_global_symbol_from_objfile)
4323         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4324         foreach.
4325         * ser-tcp.c (net_open): Remove "struct" from foreach.
4326         * objfiles.c (objfile_relocate, objfile_rebase)
4327         (objfile_has_symbols): Remove "struct" from foreach.
4328         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4329         from foreach.
4330         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4331         foreach.
4332         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4333         "struct" from foreach.
4334         * ada-lang.c (create_excep_cond_exprs)
4335         (ada_exception_catchpoint_cond_string): Remove "struct" from
4336         foreach.
4337
4338 2019-05-03  Tom Tromey  <tromey@adacore.com>
4339
4340         * ada-exp.y (convert_char_literal): Check suffix of each
4341         enumerator.
4342
4343 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4344
4345         PR ada/21406:
4346         * ada-exp.y (yywrap): Don't define.
4347         * ada-lex.l (%option): Add noyywrap
4348         (yywrap): Remove.
4349
4350 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4351
4352         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4353         _WIN32_WINNT to the XP level, unless already defined to a higher
4354         level.
4355
4356         * unittests/parse-connection-spec-selftests.c:
4357         * ser-tcp.c:
4358         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4359         override.
4360
4361         * symfile.c (find_separate_debug_file): Remove colon from the
4362         drive spec of DOS/Windows file names of the target, so that the
4363         file name produced from DEBUGDIR and the target's directory will
4364         be valid on DOS/Windows systems.
4365
4366 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4367
4368         * rust-lang.c (val_print_struct): Handle printing structures
4369         containing strings.
4370
4371 2019-05-02  Tom Tromey  <tromey@adacore.com>
4372
4373         * valarith.c (_initialize_valarith): Remove.
4374
4375 2019-05-01  Tom Tromey  <tromey@adacore.com>
4376
4377         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4378         bitfields.
4379
4380 2019-05-01  Tom Tromey  <tromey@adacore.com>
4381
4382         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4383         for big-endian copies.
4384
4385 2019-04-30  Ali Tamur  <tamur@google.com>
4386         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4387         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4388         (read_3_bytes): New function.
4389
4390 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4391
4392         * windows-nat.c (main_thread_id): Delete.
4393         (handle_output_debug_string): Replace main_thread_id by
4394         current_event.dwThreadId.
4395         (fake_create_process): Likewise.
4396         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4397         Do not set main_thread_id.
4398         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4399         current_event.dwThreadId.
4400         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4401
4402 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4403
4404         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4405         Use current_event.dwThreadId instead of main_thread_id.
4406
4407 2019-04-30  Tom Tromey  <tromey@adacore.com>
4408
4409         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4410         (create_excep_cond_exprs): Iterate over program spaces.
4411         (ada_exception_catchpoint_cond_string): Examine all minimal
4412         symbols for exception types.
4413
4414 2019-04-30  Tom Tromey  <tromey@adacore.com>
4415
4416         PR c++/24470:
4417         * dwarf2read.c (process_structure_scope): Handle case where type
4418         has template parameters but no symbol was created.
4419
4420 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4421             Chris January  <chris.january@arm.com>
4422
4423         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4424         qualifier.
4425         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4426
4427 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4428
4429         * f-typeprint.c (f_print_type): Update rules for printing
4430         whitespace.
4431         (f_type_print_varspec_suffix): Likewise.
4432
4433 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4434             Chris January  <chris.january@arm.com>
4435
4436         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4437         function arguments.
4438
4439 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4440
4441         * f-lang.c (build_fortran_types): Change name of void type to
4442         lower case.
4443         * f-typeprint.c (f_type_print_base): Print the name of the void
4444         type, rather than a fixed string.
4445         * f-valprint.c (f_decorations): Use lower case void string.
4446
4447 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4448             Chris January  <chris.january@arm.com>
4449
4450         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4451         types for Fortran.
4452
4453 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4454             Chris January  <chris.january@arm.com>
4455             David Lecomber  <david.lecomber@arm.com>
4456
4457         * f-exp.y (BINOP_INTRINSIC): New token.
4458         (exp): New parser rule handling BINOP_INTRINSIC.
4459         (f77_keywords): Add new builtin procedures.
4460         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4461         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4462         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4463         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4464         (print_unop_subexp_f): New function.
4465         (print_binop_subexp_f): New function.
4466         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4467         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4468         (dump_subexp_body_f): Likewise.
4469         (operator_check_f): Likewise.
4470         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4471         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4472
4473 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4474
4475         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4476         UNOP_KIND.
4477         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4478         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4479         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4480         (operator_length_f): New fuction.
4481         (print_subexp_f): New function.
4482         (op_name_f): New function.
4483         (dump_subexp_body_f): New function.
4484         (operator_check_f): New function.
4485         (exp_descriptor_f): Replace standard expression handling functions
4486         with new functions.
4487         * gdb/fortran-operator.def: New file.
4488         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4489         * gdb/std-operator.def: Remove UNOP_KIND.
4490
4491 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4492
4493         * std-operator.def: Remove unbalanced, stray double quote
4494         character.
4495
4496 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4497             Chris January  <chris.january@arm.com>
4498             Daniel Everett  <daniel.everett@arm.com>
4499             Nick Forrington  <nick.forrington@arm.com>
4500             Richard Bunt  <richard.bunt@arm.com>
4501
4502         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4503         of depth when printing anonymous structs or unions.
4504         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4505         Don't print either the top-level value, or the children if the
4506         max-depth is exceeded.
4507         (ppscm_print_children): When printing the key of a map, allow one
4508         extra level of depth.
4509         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4510         print either the top-level value, or the children if the max-depth
4511         is exceeded.
4512         (print_children): When printing the key of a map, allow one extra
4513         level of depth.
4514         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4515         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4516         (user_print_options): Initialise max_depth field.
4517         (val_print_scalar_or_string_type_p): New function.
4518         (val_print): Check to see if the max depth has been reached.
4519         (val_print_check_max_depth): Define new function.
4520         (show_print_max_depth): New function.
4521         (_initialize_valprint): Add 'print max-depth' option.
4522         * valprint.h (struct value_print_options) <max_depth>: New field.
4523         (val_print_check_max_depth): Declare new function.
4524         * NEWS: Document new feature.
4525
4526 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4527
4528         * ada-lang.c (ada_language_defn): Initialise new field.
4529         * c-lang.c (c_is_string_type_p): New function.
4530         (c_language_defn): Initialise new field.
4531         (cplus_language_defn): Initialise new field.
4532         (asm_language_defn): Initialise new field.
4533         (minimal_language_defn): Initialise new field.
4534         * c-lang.h (c_is_string_type_p): Declare new function.
4535         * d-lang.c (d_language_defn): Initialise new field.
4536         * f-lang.c (f_is_string_type_p): New function.
4537         (f_language_defn): Initialise new field.
4538         * go-lang.c (go_is_string_type_p): New function.
4539         (go_language_defn): Initialise new field.
4540         * language.c (default_is_string_type_p): New function.
4541         (unknown_language_defn): Initialise new field.
4542         (auto_language_defn): Initialise new field.
4543         * language.h (struct language_defn) <la_is_string_type_p>: New
4544         member variable.
4545         (default_is_string_type_p): Declare new function.
4546         * m2-lang.c (m2_language_defn): Initialise new field.
4547         * objc-lang.c (objc_language_defn): Initialise new field.
4548         * opencl-lang.c (opencl_language_defn): Initialise new field.
4549         * p-lang.c (pascal_is_string_type_p): New function.
4550         (pascal_language_defn): Initialise new field.
4551         * rust-lang.c (rust_is_string_type_p): New function.
4552         (rust_language_defn): Initialise new field.
4553
4554 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4555
4556         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4557         New field.
4558         * ada-lang.c (ada_language_defn): Initialise new field.
4559         * c-lang.c (c_language_defn): Likewise.
4560         (cplus_language_defn): Likewise.
4561         (asm_language_defn): Likewise.
4562         (minimal_language_defn): Likewise.
4563         * d-lang.c (d_language_defn): Likewise.
4564         * f-lang.c (f_language_defn): Likewise.
4565         * go-lang.c (go_language_defn): Likewise.
4566         * language.c (unknown_language_defn): Likewise.
4567         (auto_language_defn): Likewise.
4568         * m2-lang.c (m2_language_defn): Likewise.
4569         * objc-lang.c (objc_language_defn): Likewise.
4570         * opencl-lang.c (opencl_language_defn): Likewise.
4571         * p-lang.c (pascal_language_defn): Likewise.
4572         * rust-lang.c (rust_language_defn): Likewise.
4573
4574 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4575
4576         * ada-lang.c (ada_is_character_type): Change return type to bool.
4577         (ada_is_string_type): Likewise.
4578         * ada-lang.h (ada_is_character_type): Update declaration
4579         (ada_is_string_type): Likewise.
4580
4581 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4582
4583         Support style in 'frame|thread apply'
4584
4585         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4586         * record.c (record_start, record_stop): Update callers of
4587         execute_command_to_string with false.
4588         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4589         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4590         methods.
4591         (class string_file): New constructor with term_out parameter.
4592         Override methods term_out and can_emit_style_escape.  New member
4593         term_out.
4594         (class stdio_file): Override can_emit_style_escape.
4595         (class tee_file): Override term_out and can_emit_style_escape.
4596         * utils.h (can_emit_style_escape): Remove.
4597         * utils.c (can_emit_style_escape): Likewise.
4598         Update all callers of can_emit_style_escape (SOMESTREAM) to
4599         SOMESTREAM->can_emit_style_escape.
4600         * source-cache.c (source_cache::get_source_lines): Likewise.
4601         * stack.c (frame_apply_command_count): Call execute_command_to_string
4602         passing the term_out characteristic of the current gdb_stdout.
4603         * thread.c (thr_try_catch_cmd): Likewise.
4604         * top.c (execute_command_to_string): pass term_out parameter
4605         to construct the string_file for the command output.
4606         * ui-file.c (term_cli_styling): New function (most code moved
4607         from utils.c can_emit_style_escape).
4608         (string_file::string_file, string_file::can_emit_style_escape,
4609         stdio_file::can_emit_style_escape, tee_file::term_out,
4610         tee_file::can_emit_style_escape): New functions.
4611
4612 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4613
4614         * NEWS: Mention the new set|show may-call-functions.
4615         * infcall.c (may_call_functions_p): New variable.
4616         (show_may_call_functions_p): New function.
4617         (call_function_by_hand_dummy): Throws an error if not
4618         may-call-functions.
4619         (_initialize_infcall): Call add_setshow_boolean_cmd for
4620         may-call-functions.
4621
4622 2019-04-25  Keith Seitz  <keiths@redhat.com>
4623
4624         PR c++/24367
4625         * cp-support.c (inspect_type): Don't attempt substitutions
4626         of symbol with the same name.
4627
4628 2019-04-25  Tom Tromey  <tromey@adacore.com>
4629
4630         PR gdb/24475:
4631         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4632         static.
4633
4634 2019-04-25  Tom Tromey  <tromey@adacore.com>
4635
4636         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4637         rvalue reference.
4638         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4639         (gdb_xml_parser::parse): Use std::move.
4640         * python/python-internal.h (gdbpy_convert_exception): Take a const
4641         reference.
4642         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4643         std::move.
4644         * python/py-utils.c (gdbpy_convert_exception): Take a const
4645         reference.
4646         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4647         Use std::move.
4648         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4649         Use std::move.
4650         * mi/mi-main.c (mi_print_exception): Take a const reference.
4651         * main.c (handle_command_errors): Take a const reference.
4652         * linespec.c (parse_linespec): Use std::move.
4653         * infcall.c (run_inferior_call): Use std::move.
4654         (call_function_by_hand_dummy): Use std::move.
4655         * exec.c (try_open_exec_file): Use std::move.
4656         * exceptions.h (exception_print, exception_fprintf)
4657         (exception_print_same): Update.
4658         * exceptions.c (print_exception, exception_print)
4659         (exception_fprintf, exception_print_same): Change parameters to
4660         const reference.
4661         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4662         * common/new-op.c: Use std::move.
4663         * common/common-exceptions.h (struct gdb_exception): Add move
4664         constructor.
4665         (struct gdb_exception_error, struct gdb_exception_quit, struct
4666         gdb_quit_bad_alloc): Change constructor to move constructor.
4667         (throw_exception): Change parameter to rvalue reference.
4668         * common/common-exceptions.c (throw_exception): Take rvalue
4669         reference.
4670         * cli/cli-interp.c (safe_execute_command): Use std::move.
4671         * breakpoint.c (insert_bp_location, location_to_sals): Use
4672         std::move.
4673
4674 2019-04-25  Tom Tromey  <tromey@adacore.com>
4675
4676         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4677         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4678         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4679         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4680         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4681         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4682         guile/scm-value.c: Use unpack.
4683         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4684         gdbscm_gdb_exception.
4685         (gdbscm_throw_gdb_exception): Likewise.
4686         (struct gdbscm_gdb_exception): New.
4687         (unpack): New function.
4688         (gdbscm_wrap): Use unpack.
4689
4690 2019-04-25  Tom Tromey  <tromey@adacore.com>
4691
4692         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4693         (gdb_rl_callback_handler): Use std::move.
4694         * common/common-exceptions.h (struct gdb_exception): Add move
4695         assignment operator.
4696         (throw_exception_sjlj): Change "exception" to const reference.
4697         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4698         (throw_exception_sjlj): Change "exception" to const reference.
4699
4700 2019-04-25  Tom Tromey  <tromey@adacore.com>
4701
4702         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4703         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4704         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4705         Update.
4706         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4707         Update.
4708         * mi/mi-interp.c (mi_interp::exec): Update.
4709         * linespec.c (parse_linespec): Update.
4710         * infcall.c (run_inferior_call): Update.
4711         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4712         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4713         (gdbscm_lookup_global_symbol): Update.
4714         * guile/scm-param.c (gdbscm_parameter_value): Update.
4715         * guile/scm-frame.c (gdbscm_frame_read_register)
4716         (gdbscm_frame_read_var): Update.
4717         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4718         * exec.c (try_open_exec_file): Update.
4719         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4720         (gdb_rl_callback_handler): Update.
4721         * common/common-exceptions.h (exception_none): Don't declare.
4722         * common/common-exceptions.c (exception_none): Don't define.
4723         (struct catcher) <exception>: Update.
4724         * cli/cli-interp.c (safe_execute_command): Update.
4725         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4726
4727 2019-04-25  Ali Tamur  <tamur@google.com>
4728
4729         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4730         (read_attribute_value): Likewise.
4731         (dwarf2_read_addr_index): Update comment.
4732         (read_str_index): Add DW_FORM_strx.
4733         (dwarf2_string_attr): Likewise.
4734         (dwarf2_const_value_attr): Likewise.
4735         (dump_die_shallow): Likewise.
4736         (dwarf2_fetch_constant_bytes): Likewise.
4737         (skip_form_bytes): Likewise.
4738         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4739
4740 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4741
4742         PR corefiles/11608
4743         PR corefiles/18187
4744         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4745         OFFSET.  Verify if current mapping contains an ELF header.
4746         (linux_find_memory_regions_full): Adjust call to
4747         dump_mapping_p.
4748
4749 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4750             Kang Li <kanglictf@gmail.com>
4751
4752         PR gdb/21600
4753
4754         * dwarf2-frame.c (read_initial_length): Be consistent about using
4755         unsigned representation of length.
4756         (decode_frame_entry_1): Likewise.  Check for wraparound of
4757         end pointer as well as buffer overflow.
4758
4759 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4760
4761         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4762         "vq".
4763
4764 2019-04-24  Tom Tromey  <tromey@adacore.com>
4765
4766         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4767
4768 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4769
4770         * s12z-tdep.c (s12z_unwind_pc): Delete.
4771         (s12z_unwind_sp): Delete.
4772         (s12z_gdbarch_init): Don't register deleted functions with
4773         gdbarch.
4774
4775 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4776
4777         * rl78-tdep.c (rl78_unwind_sp): Delete.
4778         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4779
4780 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4781
4782         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4783         (xstormy16_unwind_pc): Delete.
4784         (xstormy16_dummy_id): Delete.
4785         (xstormy16_gdbarch_init): Don't register deleted functions with
4786         gdbarch.
4787
4788 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4789
4790         * vax-tdep.c (vax_unwind_pc): Delete.
4791         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4792
4793 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4794
4795         * v850-tdep.c (v850_unwind_sp): Delete.
4796         (v850_unwind_pc): Delete.
4797         (v850_dummy_id): Delete.
4798         (v850_gdbarch_init): Don't register deleted functions with
4799         gdbarch.
4800
4801 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4802
4803         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4804         (tilegx_unwind_pc): Delete.
4805         (tilegx_unwind_dummy_id): Delete.
4806         (tilegx_gdbarch_init): Don't register deleted functions with
4807         gdbarch.
4808
4809 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4810
4811         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4812         (tic6x_dummy_id): Delete.
4813         (tic6x_gdbarch_init): Don't register deleted functions with
4814         gdbarch.
4815
4816 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4817
4818         * sparc-tdep.c (sparc_unwind_pc): Delete.
4819         (sparc32_gdbarch_init): Don't register deleted function with
4820         gdbarch.
4821
4822 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4823
4824         * sh-tdep.c (sh_unwind_sp): Delete.
4825         (sh_unwind_pc): Delete.
4826         (sh_dummy_id): Delete.
4827         (sh_gdbarch_init): Don't register deleted functions with
4828         gdbarch.
4829
4830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4831
4832         * score-tdep.c (score_unwind_sp): Delete.
4833         (score_unwind_pc): Delete.
4834         (score_dummy_id): Delete.
4835         (score_gdbarch_init): Don't register deleted functions with
4836         gdbarch.
4837
4838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4839
4840         * rx-tdep.c (rx_unwind_pc): Delete.
4841         (rx_unwind_sp): Delete.
4842         (rx_dummy_id): Delete.
4843         (rx_gdbarch_init): Don't register deleted functions with
4844         gdbarch.  Update comment.
4845
4846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4847
4848         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4849         (rs6000_dummy_id): Delete.
4850         (rs6000_gdbarch_init): Don't register deleted functions with
4851         gdbarch.
4852
4853 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4854
4855         * or1k-tdep.c (or1k_dummy_id): Delete.
4856         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4857
4858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4859
4860         * nios2-tdep.c (nios2_dummy_id): Delete.
4861         (nios2_unwind_sp): Delete.
4862         (nios2_gdbarch_init): Don't register deleted functions with
4863         gdbarch.
4864
4865 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4866
4867         * nds32-tdep.c (nds32_dummy_id): Delete.
4868         (nds32_unwind_pc): Delete.
4869         (nds32_unwind_sp): Delete.
4870         (nds32_gdbarch_init): Don't register deleted functions with
4871         gdbarch.
4872
4873 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4874
4875         * msp430-tdep.c (msp430_unwind_pc): Delete.
4876         (msp430_unwind_sp): Delete.
4877         (msp430_dummy_id): Delete.
4878         (msp430_gdbarch_init): Don't register deleted functions with
4879         gdbarch.
4880
4881 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4882
4883         * moxie-tdep.c (moxie_unwind_sp): Delete.
4884         (moxie_unwind_pc): Delete.
4885         (moxie_dummy_id): Delete.
4886         (moxie_gdbarch_init): Don't register deleted functions with
4887         gdbarch.
4888
4889 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4890
4891         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4892         (mn10300_unwind_pc): Delete.
4893         (mn10300_unwind_sp): Delete.
4894         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4895         mn10300_unwind_sp.
4896         (mn10300_frame_unwind_init): Don't register deleted functions with
4897         gdbarch.
4898
4899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4900
4901         * mep-tdep.c (mep_unwind_pc): Delete.
4902         (mep_unwind_sp): Delete.
4903         (mep_dummy_id): Delete.
4904         (mep_gdbarch_init): Don't register deleted functions with
4905         gdbarch.
4906
4907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4908
4909         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4910         (m68hc11_unwind_sp): Delete.
4911         (m68hc11_gdbarch_init): Don't register deleted functions with
4912         gdbarch.
4913
4914 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4915
4916         * m32r-tdep.c (m32r_unwind_sp): Delete.
4917         (m32r_unwind_pc): Delete.
4918         (m32r_dummy_id): Delete.
4919         (m32r_gdbarch_init): Don't register deleted functions with
4920         gdbarch.
4921
4922 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4923
4924         * m32c-tdep.c (m32c_unwind_pc): Delete.
4925         (m32c_unwind_sp): Delete.
4926         (m32c_dummy_id): Delete.
4927         (m32c_gdbarch_init): Don't register deleted functions with
4928         gdbarch.
4929
4930 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4931
4932         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4933         (lm32_unwind_pc): Delete.
4934         (lm32_dummy_id): Delete.
4935         (lm32_gdbarch_init): Don't register deleted functions with
4936         gdbarch.
4937
4938 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4939
4940         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4941         (iq2000_unwind_pc): Delete.
4942         (iq2000_dummy_id): Delete.
4943         (iq2000_gdbarch_init): Don't register deleted functions with
4944         gdbarch.
4945
4946 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4947
4948         * nds32-tdep.c (nds32_type_align): Delete.
4949         (nds32_push_dummy_call): Use type_align instead.
4950
4951 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4952
4953         * arm-tdep.c (arm_type_align): Only handle vector override case.
4954         (arm_push_dummy_call): Use type_align.
4955         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4956
4957 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4958
4959         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4960         case.
4961         (pass_on_stack): Use type_align.
4962         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4963         function.
4964
4965 2019-04-23  Tom Tromey  <tromey@adacore.com>
4966
4967         * dwarf2read.c (line_header::file_name_at): Remove unused
4968         overload.
4969
4970 2019-04-23  Tom de Vries  <tdevries@suse.de>
4971
4972         PR gdb/24438
4973         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4974         invocation.
4975
4976
4977 2019-03-27  Ali Tamur  <tamur@google.com>
4978
4979         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4980         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4981         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4982         (dwarf_expr_context::get_addr_index): Likewise
4983         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4984         (symbol_needs_eval_context::get_addr_index): Likewise
4985         (disassemble_dwarf_expression): Add DW_OP_addrx
4986         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4987         (read_cutu_die_from_dwo): Update comment
4988         (skip_one_die): Add DW_FORM_addrx
4989         (read_attribute_value): Likewise
4990         (var_decode_location): Add DW_OP_addrx
4991         (dwarf2_const_value_attr): Add DW_FORM_addrx
4992         (dump_die_shallow): Likewise
4993         (dwarf2_fetch_constant_bytes): Likewise
4994         (decode_locdesc): Add DW_OP_addrx
4995         (skip_form_bytes): Add DW_FORM_addrx
4996
4997 2019-04-22  Ali Tamur  <tamur@google.com>
4998
4999         * MAINTAINERS (Write After Approval): Add self.
5000
5001 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5002
5003         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5004         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5005         (open_symbol_file_object): Likewise.
5006         (svr4_default_sos): Add info parameter.
5007         (svr4_read_so_list): Likewise.
5008         (svr4_current_sos_direct): Adjust functions calls to pass down
5009         info.
5010         (svr4_current_sos_1): Add info parameter.
5011         (svr4_current_sos): Call get_svr4_info, pass info down to
5012         svr4_current_sos_1.
5013         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5014         get_svr4_info.
5015         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5016         get_svr4_info.
5017         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5018         to get_svr4_info.
5019         (probes_table_remove_objfile_probes): Likewise.
5020         (register_solib_event_probe): Add info parameter.
5021         (solist_update_incremental): Pass info parameter down to
5022         svr4_read_so_list.
5023         (disable_probes_interface): Add info parameter.
5024         (svr4_handle_solib_event): Pass current_program_space to
5025         get_svr4_info.  Adjust disable_probes_interface cleanup.
5026         (svr4_create_probe_breakpoints): Add info parameter, pass it
5027         down to register_solib_event_probe.
5028         (svr4_create_solib_event_breakpoints): Add info parameter,
5029         pass it down to svr4_create_probe_breakpoints.
5030         (enable_break): Pass info down to
5031         svr4_create_solib_event_breakpoints.
5032         (svr4_solib_create_inferior_hook): Pass current_program_space to
5033         get_svr4_info.
5034         (svr4_clear_solib): Likewise.
5035
5036 2019-04-22  Pedro Alves  <palves@redhat.com>
5037
5038         * solib-svr4.c (svr4_free_objfile_observer): New.
5039         (probe_and_action::objfile): New field.
5040         (probes_table_htab_remove_objfile_probes)
5041         (probes_table_remove_objfile_probes): New functions.
5042         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5043         in the new probe_and_action.  Don't store the probe in 'lookup'.
5044         (svr4_create_probe_breakpoints): Pass objfile to
5045         register_solib_event_probe.
5046         (_initialize_svr4_solib): Register a free_objfile observer.
5047
5048 2019-04-19  Tom Tromey  <tom@tromey.com>
5049
5050         * common/queue.h: Remove.
5051
5052 2019-04-19  Tom Tromey  <tom@tromey.com>
5053
5054         * event-loop.c: Don't include "common/queue.h".
5055
5056 2019-04-19  Tom Tromey  <tom@tromey.com>
5057
5058         * remote.c (remote_target): Use delete.
5059         * remote-notif.h: Include <list>, not "common/queue.h".
5060         (notif_client_p): Remove typedef.
5061         (remote_notif_state): Add constructor, destructor, initializer.
5062         <notif_queue>: Now a std::list.
5063         (remote_notif_state_xfree): Don't declare.
5064         * remote-notif.c (remote_notif_process, handle_notification)
5065         (remote_notif_state_allocate): Update.
5066         (~remote_notif_state): Rename from remote_notif_state_xfree.
5067
5068 2019-04-19  Tom Tromey  <tom@tromey.com>
5069
5070         * symfile.c (reread_symbols): Update.
5071         * objfiles.c (objfile_register_static_link)
5072         (objfile_lookup_static_link): Update
5073         (~objfile) Don't delete static_links.
5074         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5075
5076 2019-04-19  Tom Tromey  <tom@tromey.com>
5077
5078         * type-stack.h (struct type_stack) <insert>: Constify string.
5079         * type-stack.c (type_stack::insert): Constify string.
5080         * gdbtypes.h (lookup_template_type): Update.
5081         (address_space_name_to_int): Update.
5082         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5083         const.
5084         (lookup_template_type): Make name const.
5085         * c-exp.y: Update rules.
5086         (lex_one_token, classify_name, classify_inner_name)
5087         (c_print_token): Update.
5088         * p-exp.y: Update rules.
5089         (yylex): Update.
5090         * f-exp.y: Update rules.
5091         (yylex): Update.
5092         * d-exp.y: Update rules.
5093         (lex_one_token, classify_name, classify_inner_name): Update.
5094         * parse.c (write_dollar_variable, copy_name): Return std::string.
5095         * parser-defs.h (copy_name): Change return type.
5096         * m2-exp.y: Update rules.
5097         (yylex): Update.
5098         * go-exp.y (lex_one_token): Update.
5099         Update rules.
5100         (classify_unsafe_function, classify_packaged_name)
5101         (classify_name, yylex): Update.
5102
5103 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5104
5105         * configure.ac: add --enable-source-highlight switch.
5106         * configure: Regenerate.
5107         * top.c (print_gdb_version): plumb --enable-source-highlight
5108         status to "show configuration".
5109
5110 2019-04-19  Tom Tromey  <tromey@adacore.com>
5111
5112         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5113         Check ADA_TYPE_P.
5114         (empty_record, ada_template_to_fixed_record_type_1)
5115         (template_to_static_fixed_type)
5116         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5117         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5118         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5119         macros.
5120
5121 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5122
5123         PR symtab/24423:
5124         * source.c (print_source_lines_base): Advance "iter" when a
5125         control character is seen.
5126
5127 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5128
5129         * inferior.h (struct infcall_suspend_state_deleter):
5130         Catch exception in destructor to avoid crash.
5131
5132 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5133
5134         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5135         close to the add_com "shell".
5136
5137 2019-04-18  Tom Tromey  <tromey@adacore.com>
5138
5139         * process-stratum-target.h (class process_stratum_target)
5140         <stratum>: Add "final".
5141
5142 2019-04-17  Tom Tromey  <tromey@adacore.com>
5143
5144         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5145         against nullptr before use.
5146
5147 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5148
5149         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5150
5151 2019-04-17  Jim Wilson  <jimw@sifive.com>
5152             Andrew Burgess  <andrew.burgess@embecosm.com>
5153
5154         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5155         code read might fail, assume 4-byte breakpoint in that case.
5156
5157 2019-04-15  Leszek Swirski  <leszeks@google.com>
5158
5159         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5160         rather than a hand-rolled POD check when checking for forced MEMORY
5161         classification.
5162
5163 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5164
5165         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5166         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5167         function.
5168         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5169         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5170         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5171         declaration.
5172
5173 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5174
5175         * aarch64-linux-nat.c
5176         (aarch64_linux_nat_target::thread_architecture): Add override.
5177         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5178         each VQ.
5179
5180 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5181
5182         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5183
5184 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5185
5186         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5187         target types of size 96-bits, add some additional comments, and
5188         check that the builtin type we found was the correct size.
5189
5190 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5191
5192         * utils.c (prompt_for_continue): Don't restore the styling at the
5193         end, as applied_style has the wrong value.  This fixes styling in
5194         long lists of file names that are interrupted by the "Continue?"
5195         prompt.
5196
5197 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5198
5199         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5200         * c-lang.c (c_language_defn): Likewise.
5201         (cplus_language_defn): Likewise.
5202         (asm_language_defn): Likewise.
5203         (minimal_language_defn): Likewise.
5204         * d-lang.c (d_language_defn): Likewise.
5205         * f-lang.c (f_language_defn): Likewise.
5206         * go-lang.c (go_language_defn): Likewise.
5207         * language.c (unknown_language_defn): Likewise.
5208         (auto_language_defn): Likewise.
5209         * language.h (struct language_defn): Remove la_magic field.
5210         (LANG_MAGIC): Delete.
5211         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5212         * objc-lang.c (objc_language_defn): Likewise.
5213         * opencl-lang.c (opencl_language_defn): Likewise.
5214         * p-lang.c (pascal_language_defn): Likewise.
5215         * rust-lang.c (rust_language_defn): Likewise.
5216
5217 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5218
5219         * riscv-tdep.c (riscv_type_align): New function.
5220         (riscv_type_alignment): Delete.
5221         (riscv_arg_location): Use 'type_align'.
5222         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5223
5224 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5225
5226         * gdbtypes.c (type_align): A struct with no non-static fields also
5227         has alignment of 1.
5228
5229 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5230
5231         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5232         component to 0.
5233         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5234         member.
5235         (riscv_struct_info::analyse): New implementation using new
5236         analyse_inner member function.
5237         (riscv_struct_info::field_offset): New member function.
5238         (riscv_struct_info::m_offsets): New member variable.
5239         (riscv_struct_info::analyse_inner): New private member function,
5240         takes the old implementation of riscv_struct_info::analyse but
5241         extended to track field offsets.
5242         (riscv_call_arg_struct): Update the struct folding special cases
5243         to handle cases where empty C++ structs, which are non-zero
5244         length, are found.
5245         (riscv_arg_location): Initialise the length of each location, a
5246         non-zero length now indicates the location is in use.
5247         (riscv_push_dummy_call): Allow for the first location having a
5248         non-zero offset when setting up arguments.
5249         (riscv_return_value): Likewise, but for return values.
5250
5251 2019-04-11  Tom Tromey  <tromey@adacore.com>
5252
5253         * utils.c (internal_vproblem): Make "msg" const.
5254
5255 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5256
5257         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5258         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5259         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5260         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5261
5262 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5263
5264         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5265         function.
5266         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5267         of amd64_collect_native_gregset.
5268         (amd64_linux_nat_target::store_registers): Likewise.
5269
5270 2019-04-10  Tom Tromey  <tom@tromey.com>
5271
5272         * symtab.c (lookup_global_symbol_from_objfile)
5273         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5274         * objfiles.h (class separate_debug_iterator): New.
5275         (class separate_debug_range): New.
5276         (struct objfile) <separate_debug_objfiles>: New method.
5277         (objfile_separate_debug_iterate): Don't declare.
5278         * objfiles.c (separate_debug_iterator::operator++): Rename from
5279         objfile_separate_debug_iterate.
5280         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5281         iterator.
5282         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5283         iterator.
5284
5285 2019-04-10  Tom Tromey  <tom@tromey.com>
5286
5287         * symfile.c (reread_symbols): Remove old comment.
5288         * objfiles.c (free_all_objfiles): Fix a typo.
5289
5290 2019-04-10  Tom Tromey  <tom@tromey.com>
5291
5292         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5293         * minsyms.c (lookup_minimal_symbol): Use foreach.
5294         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5295         (lookup_minimal_symbol_solib_trampoline): Likewise.
5296         * symfile.c (reread_symbols): Use foreach.
5297
5298 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5299             Tom Tromey  <tromey@adacore.com>
5300
5301         PR rust/24414:
5302         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5303         (rust_lex_int_test): Change "value" to be LONGEST.
5304         (rust_lex_tests): Add test for long integer literal.
5305
5306 2019-04-09  Tom Tromey  <tromey@adacore.com>
5307
5308         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5309         to bool.
5310         (extended_remote_target::attach): Update.
5311         (remote_target::remote_notice_new_inferior): Update.
5312         (remote_target::add_current_inferior_and_thread): Update.
5313         * inferior.c (exit_inferior_1): Use "false".
5314         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5315
5316 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5317
5318         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5319         the "start" command.
5320
5321 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5322
5323         * python/py-inferior.c (infpy_thread_from_thread_handle):
5324         Adjust comments to reflect renaming of thread_from_thread_handle
5325         to thread_from_handle.  Adjust keywords.  Fix type error message.
5326         (inferior_object_methods): Add thread_from_handle.  Retain
5327         thread_from_thread_handle, but mark it as deprecated.
5328
5329 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5330
5331         * gdbthread.h (find_thread_by_handle): Revise declaration.
5332         * thread.c (find_thread_by_handle): Likewise.  Adjust
5333         implementation too.
5334         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5335         support for buffer objects as handles.
5336
5337 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5338
5339         * python/py-infthread.c (thpy_thread_handle): New function.
5340         (thread_object_methods): Register thpy_thread_handle.
5341
5342 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5343
5344         * gdbthread.h (thread_to_thread_handle): Declare.
5345         * thread.c (gdbtypes.h): Include.
5346         (thread_to_thread_handle): New function.
5347
5348         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5349         (target_thread_info_to_thread_handle): Declare.
5350         * target.c (target_thread_info_to_thread_handle): New function.
5351         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5352         * target-delegates.c: Regenerate.
5353
5354         * linux-thread-db.c (class thread_db_target): Add method
5355         thread_info_to_thread_handle.
5356         (thread_db_target::thread_info_to_thread_handle): Define.
5357         * remote.c (class remote_target): Add new method
5358         thread_info_to_thread_handle.
5359         (remote_target::thread_info_to_thread_handle): Define.
5360
5361 2019-04-08  Pedro Alves  <palves@redhat.com>
5362
5363         * common/common-exceptions.c (throw_exception): Don't create
5364         named object to throw; throw directly.
5365         (throw_it): Likewise.  Don't initialize gdb_exception::message
5366         here, with new; pass FMT and AP to the ctor instead.
5367         * common/common-exceptions.h: Include <string>.
5368         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5369         const char *, va_list)): New ctor.  Use std::make_shared.
5370         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5371         errors)): Delete.
5372         (gdb_exception_error::gdb_exception_error(enum errors, const char
5373         *, va_list)): New.
5374         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5375         Add assertion.
5376         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5377         errors)): Delete.
5378         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5379         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5380         Add assertion.
5381
5382 2019-04-08  Tom Tromey  <tom@tromey.com>
5383
5384         * valops.c (value_rtti_indirect_type): Replace throw_exception
5385         with throw.
5386         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5387         with throw.
5388         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5389         throw.
5390         * target.c (target_translate_tls_address): Replace throw_exception
5391         with throw.
5392         * stack.c (frame_apply_command_count): Replace throw_exception
5393         with throw.
5394         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5395         throw.
5396         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5397         with throw.
5398         * rs6000-tdep.c (rs6000_frame_cache)
5399         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5400         * remote.c: Replace throw_exception with throw.
5401         * record-full.c (record_full_message, record_full_wait_1)
5402         (record_full_restore): Replace throw_exception with throw.
5403         * record-btrace.c:
5404         (get_thread_current_frame_id, record_btrace_start_replaying)
5405         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5406         (cmd_record_btrace_start): Replace throw_exception with throw.
5407         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5408         throw.
5409         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5410         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5411         * linespec.c:
5412         (find_linespec_symbols): Replace throw_exception with throw.
5413         * infrun.c (displaced_step_prepare, resume): Replace
5414         throw_exception with throw.
5415         * infcmd.c (post_create_inferior): Replace throw_exception with
5416         throw.
5417         * inf-loop.c (inferior_event_handler): Replace throw_exception
5418         with throw.
5419         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5420         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5421         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5422         (get_prev_frame_always, get_frame_pc_if_available)
5423         (get_frame_address_in_block_if_available, get_frame_language):
5424         Replace throw_exception with throw.
5425         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5426         throw_exception with throw.
5427         * eval.c (fetch_subexp_value, evaluate_var_value)
5428         (evaluate_funcall, evaluate_subexp_standard): Replace
5429         throw_exception with throw.
5430         * dwarf2loc.c (call_site_find_chain)
5431         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5432         Replace throw_exception with throw.
5433         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5434         with throw.
5435         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5436         throw.
5437         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5438         * completer.c (complete_line_internal): Replace throw_exception
5439         with throw.
5440         * compile/compile-object-run.c (compile_object_run): Replace
5441         throw_exception with throw.
5442         * cli/cli-script.c (process_next_line): Replace throw_exception
5443         with throw.
5444         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5445         (btrace_enable, btrace_maint_update_pt_packets): Replace
5446         throw_exception with throw.
5447         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5448         throw_exception with throw.
5449         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5450         throw_exception with throw.
5451         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5452         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5453         * aarch64-tdep.c (aarch64_make_prologue_cache)
5454         (aarch64_make_stub_cache): Replace throw_exception with throw.
5455
5456 2019-04-08  Tom Tromey  <tom@tromey.com>
5457
5458         * common/common-exceptions.c (throw_exception): Rename from
5459         throw_exception_cxx.  Remove old copy.  Make argument const.
5460         (throw_it): Create and throw exception objects directly.
5461         * common/common-exceptions.h (throw_exception): Make argument
5462         const.
5463         (struct gdb_exception_error): Add constructor.
5464         (struct gdb_exception_quit): Add constructor.
5465
5466 2019-04-08  Tom Tromey  <tom@tromey.com>
5467
5468         * common/common-exceptions.h (exception_rethrow): Don't declare.
5469         (TRY_SJLJ): Update comment.
5470         (TRY, CATCH, END_CATCH): Remove.
5471         * common/common-exceptions.c (exception_rethrow): Remove.
5472
5473 2019-04-08  Tom Tromey  <tom@tromey.com>
5474
5475         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5476         Remove.
5477         (gdb_exception_error): Rename from
5478         gdb_exception_RETURN_MASK_ERROR.
5479         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5480         (gdb_quit_bad_alloc): Update.
5481         * aarch64-tdep.c: Update.
5482         * ada-lang.c: Update.
5483         * ada-typeprint.c: Update.
5484         * ada-valprint.c: Update.
5485         * amd64-tdep.c: Update.
5486         * arch-utils.c: Update.
5487         * break-catch-throw.c: Update.
5488         * breakpoint.c: Update.
5489         * btrace.c: Update.
5490         * c-varobj.c: Update.
5491         * cli/cli-cmds.c: Update.
5492         * cli/cli-interp.c: Update.
5493         * cli/cli-script.c: Update.
5494         * common/common-exceptions.c: Update.
5495         * common/new-op.c: Update.
5496         * common/selftest.c: Update.
5497         * compile/compile-c-symbols.c: Update.
5498         * compile/compile-cplus-symbols.c: Update.
5499         * compile/compile-object-load.c: Update.
5500         * compile/compile-object-run.c: Update.
5501         * completer.c: Update.
5502         * corelow.c: Update.
5503         * cp-abi.c: Update.
5504         * cp-support.c: Update.
5505         * cp-valprint.c: Update.
5506         * darwin-nat.c: Update.
5507         * disasm-selftests.c: Update.
5508         * dtrace-probe.c: Update.
5509         * dwarf-index-cache.c: Update.
5510         * dwarf-index-write.c: Update.
5511         * dwarf2-frame-tailcall.c: Update.
5512         * dwarf2-frame.c: Update.
5513         * dwarf2loc.c: Update.
5514         * dwarf2read.c: Update.
5515         * eval.c: Update.
5516         * event-loop.c: Update.
5517         * event-top.c: Update.
5518         * exec.c: Update.
5519         * f-valprint.c: Update.
5520         * fbsd-tdep.c: Update.
5521         * frame-unwind.c: Update.
5522         * frame.c: Update.
5523         * gdbtypes.c: Update.
5524         * gnu-v3-abi.c: Update.
5525         * guile/guile-internal.h: Update.
5526         * guile/scm-block.c: Update.
5527         * guile/scm-breakpoint.c: Update.
5528         * guile/scm-cmd.c: Update.
5529         * guile/scm-disasm.c: Update.
5530         * guile/scm-frame.c: Update.
5531         * guile/scm-lazy-string.c: Update.
5532         * guile/scm-math.c: Update.
5533         * guile/scm-param.c: Update.
5534         * guile/scm-ports.c: Update.
5535         * guile/scm-pretty-print.c: Update.
5536         * guile/scm-symbol.c: Update.
5537         * guile/scm-symtab.c: Update.
5538         * guile/scm-type.c: Update.
5539         * guile/scm-value.c: Update.
5540         * i386-linux-tdep.c: Update.
5541         * i386-tdep.c: Update.
5542         * inf-loop.c: Update.
5543         * infcall.c: Update.
5544         * infcmd.c: Update.
5545         * infrun.c: Update.
5546         * jit.c: Update.
5547         * language.c: Update.
5548         * linespec.c: Update.
5549         * linux-fork.c: Update.
5550         * linux-nat.c: Update.
5551         * linux-tdep.c: Update.
5552         * linux-thread-db.c: Update.
5553         * main.c: Update.
5554         * mi/mi-cmd-break.c: Update.
5555         * mi/mi-cmd-stack.c: Update.
5556         * mi/mi-interp.c: Update.
5557         * mi/mi-main.c: Update.
5558         * objc-lang.c: Update.
5559         * p-valprint.c: Update.
5560         * parse.c: Update.
5561         * ppc-linux-tdep.c: Update.
5562         * printcmd.c: Update.
5563         * python/py-arch.c: Update.
5564         * python/py-breakpoint.c: Update.
5565         * python/py-cmd.c: Update.
5566         * python/py-finishbreakpoint.c: Update.
5567         * python/py-frame.c: Update.
5568         * python/py-framefilter.c: Update.
5569         * python/py-gdb-readline.c: Update.
5570         * python/py-inferior.c: Update.
5571         * python/py-infthread.c: Update.
5572         * python/py-lazy-string.c: Update.
5573         * python/py-linetable.c: Update.
5574         * python/py-objfile.c: Update.
5575         * python/py-param.c: Update.
5576         * python/py-prettyprint.c: Update.
5577         * python/py-progspace.c: Update.
5578         * python/py-record-btrace.c: Update.
5579         * python/py-record.c: Update.
5580         * python/py-symbol.c: Update.
5581         * python/py-type.c: Update.
5582         * python/py-unwind.c: Update.
5583         * python/py-utils.c: Update.
5584         * python/py-value.c: Update.
5585         * python/python.c: Update.
5586         * record-btrace.c: Update.
5587         * record-full.c: Update.
5588         * remote-fileio.c: Update.
5589         * remote.c: Update.
5590         * riscv-tdep.c: Update.
5591         * rs6000-aix-tdep.c: Update.
5592         * rs6000-tdep.c: Update.
5593         * rust-exp.y: Update.
5594         * rust-lang.c: Update.
5595         * s390-tdep.c: Update.
5596         * selftest-arch.c: Update.
5597         * solib-dsbt.c: Update.
5598         * solib-frv.c: Update.
5599         * solib-spu.c: Update.
5600         * solib-svr4.c: Update.
5601         * solib.c: Update.
5602         * sparc64-linux-tdep.c: Update.
5603         * stack.c: Update.
5604         * symfile-mem.c: Update.
5605         * symmisc.c: Update.
5606         * target.c: Update.
5607         * thread.c: Update.
5608         * top.c: Update.
5609         * tracefile-tfile.c: Update.
5610         * tui/tui.c: Update.
5611         * typeprint.c: Update.
5612         * unittests/cli-utils-selftests.c: Update.
5613         * unittests/parse-connection-spec-selftests.c: Update.
5614         * valops.c: Update.
5615         * valprint.c: Update.
5616         * value.c: Update.
5617         * varobj.c: Update.
5618         * windows-nat.c: Update.
5619         * x86-linux-nat.c: Update.
5620         * xml-support.c: Update.
5621
5622 2019-04-08  Tom Tromey  <tom@tromey.com>
5623
5624         * xml-support.c: Use C++ exception handling.
5625         * x86-linux-nat.c: Use C++ exception handling.
5626         * windows-nat.c: Use C++ exception handling.
5627         * varobj.c: Use C++ exception handling.
5628         * value.c: Use C++ exception handling.
5629         * valprint.c: Use C++ exception handling.
5630         * valops.c: Use C++ exception handling.
5631         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5632         handling.
5633         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5634         * typeprint.c: Use C++ exception handling.
5635         * tui/tui.c: Use C++ exception handling.
5636         * tracefile-tfile.c: Use C++ exception handling.
5637         * top.c: Use C++ exception handling.
5638         * thread.c: Use C++ exception handling.
5639         * target.c: Use C++ exception handling.
5640         * symmisc.c: Use C++ exception handling.
5641         * symfile-mem.c: Use C++ exception handling.
5642         * stack.c: Use C++ exception handling.
5643         * sparc64-linux-tdep.c: Use C++ exception handling.
5644         * solib.c: Use C++ exception handling.
5645         * solib-svr4.c: Use C++ exception handling.
5646         * solib-spu.c: Use C++ exception handling.
5647         * solib-frv.c: Use C++ exception handling.
5648         * solib-dsbt.c: Use C++ exception handling.
5649         * selftest-arch.c: Use C++ exception handling.
5650         * s390-tdep.c: Use C++ exception handling.
5651         * rust-lang.c: Use C++ exception handling.
5652         * rust-exp.y: Use C++ exception handling.
5653         * rs6000-tdep.c: Use C++ exception handling.
5654         * rs6000-aix-tdep.c: Use C++ exception handling.
5655         * riscv-tdep.c: Use C++ exception handling.
5656         * remote.c: Use C++ exception handling.
5657         * remote-fileio.c: Use C++ exception handling.
5658         * record-full.c: Use C++ exception handling.
5659         * record-btrace.c: Use C++ exception handling.
5660         * python/python.c: Use C++ exception handling.
5661         * python/py-value.c: Use C++ exception handling.
5662         * python/py-utils.c: Use C++ exception handling.
5663         * python/py-unwind.c: Use C++ exception handling.
5664         * python/py-type.c: Use C++ exception handling.
5665         * python/py-symbol.c: Use C++ exception handling.
5666         * python/py-record.c: Use C++ exception handling.
5667         * python/py-record-btrace.c: Use C++ exception handling.
5668         * python/py-progspace.c: Use C++ exception handling.
5669         * python/py-prettyprint.c: Use C++ exception handling.
5670         * python/py-param.c: Use C++ exception handling.
5671         * python/py-objfile.c: Use C++ exception handling.
5672         * python/py-linetable.c: Use C++ exception handling.
5673         * python/py-lazy-string.c: Use C++ exception handling.
5674         * python/py-infthread.c: Use C++ exception handling.
5675         * python/py-inferior.c: Use C++ exception handling.
5676         * python/py-gdb-readline.c: Use C++ exception handling.
5677         * python/py-framefilter.c: Use C++ exception handling.
5678         * python/py-frame.c: Use C++ exception handling.
5679         * python/py-finishbreakpoint.c: Use C++ exception handling.
5680         * python/py-cmd.c: Use C++ exception handling.
5681         * python/py-breakpoint.c: Use C++ exception handling.
5682         * python/py-arch.c: Use C++ exception handling.
5683         * printcmd.c: Use C++ exception handling.
5684         * ppc-linux-tdep.c: Use C++ exception handling.
5685         * parse.c: Use C++ exception handling.
5686         * p-valprint.c: Use C++ exception handling.
5687         * objc-lang.c: Use C++ exception handling.
5688         * mi/mi-main.c: Use C++ exception handling.
5689         * mi/mi-interp.c: Use C++ exception handling.
5690         * mi/mi-cmd-stack.c: Use C++ exception handling.
5691         * mi/mi-cmd-break.c: Use C++ exception handling.
5692         * main.c: Use C++ exception handling.
5693         * linux-thread-db.c: Use C++ exception handling.
5694         * linux-tdep.c: Use C++ exception handling.
5695         * linux-nat.c: Use C++ exception handling.
5696         * linux-fork.c: Use C++ exception handling.
5697         * linespec.c: Use C++ exception handling.
5698         * language.c: Use C++ exception handling.
5699         * jit.c: Use C++ exception handling.
5700         * infrun.c: Use C++ exception handling.
5701         * infcmd.c: Use C++ exception handling.
5702         * infcall.c: Use C++ exception handling.
5703         * inf-loop.c: Use C++ exception handling.
5704         * i386-tdep.c: Use C++ exception handling.
5705         * i386-linux-tdep.c: Use C++ exception handling.
5706         * guile/scm-value.c: Use C++ exception handling.
5707         * guile/scm-type.c: Use C++ exception handling.
5708         * guile/scm-symtab.c: Use C++ exception handling.
5709         * guile/scm-symbol.c: Use C++ exception handling.
5710         * guile/scm-pretty-print.c: Use C++ exception handling.
5711         * guile/scm-ports.c: Use C++ exception handling.
5712         * guile/scm-param.c: Use C++ exception handling.
5713         * guile/scm-math.c: Use C++ exception handling.
5714         * guile/scm-lazy-string.c: Use C++ exception handling.
5715         * guile/scm-frame.c: Use C++ exception handling.
5716         * guile/scm-disasm.c: Use C++ exception handling.
5717         * guile/scm-cmd.c: Use C++ exception handling.
5718         * guile/scm-breakpoint.c: Use C++ exception handling.
5719         * guile/scm-block.c: Use C++ exception handling.
5720         * guile/guile-internal.h: Use C++ exception handling.
5721         * gnu-v3-abi.c: Use C++ exception handling.
5722         * gdbtypes.c: Use C++ exception handling.
5723         * frame.c: Use C++ exception handling.
5724         * frame-unwind.c: Use C++ exception handling.
5725         * fbsd-tdep.c: Use C++ exception handling.
5726         * f-valprint.c: Use C++ exception handling.
5727         * exec.c: Use C++ exception handling.
5728         * event-top.c: Use C++ exception handling.
5729         * event-loop.c: Use C++ exception handling.
5730         * eval.c: Use C++ exception handling.
5731         * dwarf2read.c: Use C++ exception handling.
5732         * dwarf2loc.c: Use C++ exception handling.
5733         * dwarf2-frame.c: Use C++ exception handling.
5734         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5735         * dwarf-index-write.c: Use C++ exception handling.
5736         * dwarf-index-cache.c: Use C++ exception handling.
5737         * dtrace-probe.c: Use C++ exception handling.
5738         * disasm-selftests.c: Use C++ exception handling.
5739         * darwin-nat.c: Use C++ exception handling.
5740         * cp-valprint.c: Use C++ exception handling.
5741         * cp-support.c: Use C++ exception handling.
5742         * cp-abi.c: Use C++ exception handling.
5743         * corelow.c: Use C++ exception handling.
5744         * completer.c: Use C++ exception handling.
5745         * compile/compile-object-run.c: Use C++ exception handling.
5746         * compile/compile-object-load.c: Use C++ exception handling.
5747         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5748         * compile/compile-c-symbols.c: Use C++ exception handling.
5749         * common/selftest.c: Use C++ exception handling.
5750         * common/new-op.c: Use C++ exception handling.
5751         * cli/cli-script.c: Use C++ exception handling.
5752         * cli/cli-interp.c: Use C++ exception handling.
5753         * cli/cli-cmds.c: Use C++ exception handling.
5754         * c-varobj.c: Use C++ exception handling.
5755         * btrace.c: Use C++ exception handling.
5756         * breakpoint.c: Use C++ exception handling.
5757         * break-catch-throw.c: Use C++ exception handling.
5758         * arch-utils.c: Use C++ exception handling.
5759         * amd64-tdep.c: Use C++ exception handling.
5760         * ada-valprint.c: Use C++ exception handling.
5761         * ada-typeprint.c: Use C++ exception handling.
5762         * ada-lang.c: Use C++ exception handling.
5763         * aarch64-tdep.c: Use C++ exception handling.
5764
5765 2019-04-08  Tom Tromey  <tom@tromey.com>
5766
5767         * xml-support.c (gdb_xml_parser::parse): Update.
5768         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5769         * value.c (show_convenience): Update.
5770         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5771         (test_parse_flags_qcs): Update.
5772         * thread.c (thr_try_catch_cmd): Update.
5773         * target.c (target_translate_tls_address): Update.
5774         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5775         (info_frame_command_core, frame_apply_command_count): Update.
5776         * rust-exp.y (rust_lex_exception_test): Update.
5777         * riscv-tdep.c (riscv_print_one_register_info): Update.
5778         * remote.c (remote_target::enable_btrace): Update.
5779         * record-btrace.c (record_btrace_enable_warn): Update.
5780         * python/py-utils.c (gdbpy_convert_exception): Update.
5781         * printcmd.c (do_one_display, print_variable_and_value): Update.
5782         * mi/mi-main.c (mi_print_exception): Update.
5783         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5784         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5785         * linux-nat.c (linux_nat_target::attach): Update.
5786         * linux-fork.c (class scoped_switch_fork_info): Update.
5787         * infrun.c (displaced_step_prepare): Update.
5788         * infcall.c (call_function_by_hand_dummy): Update.
5789         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5790         * gnu-v3-abi.c (print_one_vtable): Update.
5791         * frame.c (get_prev_frame_always): Update.
5792         * f-valprint.c (info_common_command_for_block): Update.
5793         * exec.c (try_open_exec_file): Update.
5794         * exceptions.c (print_exception, exception_print)
5795         (exception_fprintf, exception_print_same): Update.
5796         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5797         * dwarf-index-cache.c (index_cache::store)
5798         (index_cache::lookup_gdb_index): Update.
5799         * darwin-nat.c (maybe_cache_shell): Update.
5800         * cp-valprint.c (cp_print_value_fields): Update.
5801         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5802         (gcc_cplus_symbol_address): Update.
5803         * compile/compile-c-symbols.c (gcc_convert_symbol)
5804         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5805         * common/selftest.c: Update.
5806         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5807         a std::string.
5808         (exception_try_scope_entry, exception_try_scope_exit): Don't
5809         declare.
5810         (struct exception_try_scope): Remove.
5811         (TRY): Don't use exception_try_scope.
5812         (struct gdb_exception): Add constructor, operator=.
5813         <what>: New method.
5814         (struct gdb_exception_RETURN_MASK_ALL)
5815         (struct gdb_exception_RETURN_MASK_ERROR)
5816         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5817         (struct gdb_quit_bad_alloc): Update.
5818         * common/common-exceptions.c (exception_none): Change
5819         initializer.
5820         (struct catcher) <state, exception>: Initialize inline.
5821         <prev>: Remove member.
5822         (current_catcher): Remove.
5823         (catchers): New global.
5824         (exceptions_state_mc_init): Simplify.
5825         (catcher_pop): Remove.
5826         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5827         (try_scope_depth, exception_try_scope_entry)
5828         (exception_try_scope_exit): Remove.
5829         (throw_exception_sjlj): Update.
5830         (exception_messages, exception_messages_size): Remove.
5831         (throw_it): Simplify.
5832         (gdb_exception_sliced_copy): Remove.
5833         (throw_exception_cxx): Update.
5834         * cli/cli-script.c (script_from_file): Update.
5835         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5836         Update.
5837         * ada-valprint.c (ada_val_print): Update.
5838         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5839         (create_excep_cond_exprs): Update.
5840
5841 2019-04-08  Tom Tromey  <tom@tromey.com>
5842
5843         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5844         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5845         (TRY, CATCH, END_CATCH): Remove some definitions.
5846         * common/common-exceptions.c: Don't use GDB_XCPT.
5847         (catcher_list_size): Remove.
5848         (throw_exception, throw_it): Simplify.
5849
5850 2019-04-05  Tom Tromey  <tom@tromey.com>
5851
5852         Revert the header-sorting patch.
5853         * ft32-tdep.c: Revert.
5854         * frv-tdep.c: Revert.
5855         * frv-linux-tdep.c: Revert.
5856         * frame.c: Revert.
5857         * frame-unwind.c: Revert.
5858         * frame-base.c: Revert.
5859         * fork-child.c: Revert.
5860         * findvar.c: Revert.
5861         * findcmd.c: Revert.
5862         * filesystem.c: Revert.
5863         * filename-seen-cache.h: Revert.
5864         * filename-seen-cache.c: Revert.
5865         * fbsd-tdep.c: Revert.
5866         * fbsd-nat.h: Revert.
5867         * fbsd-nat.c: Revert.
5868         * f-valprint.c: Revert.
5869         * f-typeprint.c: Revert.
5870         * f-lang.c: Revert.
5871         * extension.h: Revert.
5872         * extension.c: Revert.
5873         * extension-priv.h: Revert.
5874         * expprint.c: Revert.
5875         * exec.h: Revert.
5876         * exec.c: Revert.
5877         * exceptions.c: Revert.
5878         * event-top.c: Revert.
5879         * event-loop.c: Revert.
5880         * eval.c: Revert.
5881         * elfread.c: Revert.
5882         * dwarf2read.h: Revert.
5883         * dwarf2read.c: Revert.
5884         * dwarf2loc.c: Revert.
5885         * dwarf2expr.h: Revert.
5886         * dwarf2expr.c: Revert.
5887         * dwarf2-frame.c: Revert.
5888         * dwarf2-frame-tailcall.c: Revert.
5889         * dwarf-index-write.h: Revert.
5890         * dwarf-index-write.c: Revert.
5891         * dwarf-index-common.c: Revert.
5892         * dwarf-index-cache.h: Revert.
5893         * dwarf-index-cache.c: Revert.
5894         * dummy-frame.c: Revert.
5895         * dtrace-probe.c: Revert.
5896         * disasm.h: Revert.
5897         * disasm.c: Revert.
5898         * disasm-selftests.c: Revert.
5899         * dictionary.c: Revert.
5900         * dicos-tdep.c: Revert.
5901         * demangle.c: Revert.
5902         * dcache.h: Revert.
5903         * dcache.c: Revert.
5904         * darwin-nat.h: Revert.
5905         * darwin-nat.c: Revert.
5906         * darwin-nat-info.c: Revert.
5907         * d-valprint.c: Revert.
5908         * d-namespace.c: Revert.
5909         * d-lang.c: Revert.
5910         * ctf.c: Revert.
5911         * csky-tdep.c: Revert.
5912         * csky-linux-tdep.c: Revert.
5913         * cris-tdep.c: Revert.
5914         * cris-linux-tdep.c: Revert.
5915         * cp-valprint.c: Revert.
5916         * cp-support.c: Revert.
5917         * cp-namespace.c: Revert.
5918         * cp-abi.c: Revert.
5919         * corelow.c: Revert.
5920         * corefile.c: Revert.
5921         * continuations.c: Revert.
5922         * completer.h: Revert.
5923         * completer.c: Revert.
5924         * complaints.c: Revert.
5925         * coffread.c: Revert.
5926         * coff-pe-read.c: Revert.
5927         * cli-out.h: Revert.
5928         * cli-out.c: Revert.
5929         * charset.c: Revert.
5930         * c-varobj.c: Revert.
5931         * c-valprint.c: Revert.
5932         * c-typeprint.c: Revert.
5933         * c-lang.c: Revert.
5934         * buildsym.c: Revert.
5935         * buildsym-legacy.c: Revert.
5936         * build-id.h: Revert.
5937         * build-id.c: Revert.
5938         * btrace.c: Revert.
5939         * bsd-uthread.c: Revert.
5940         * breakpoint.h: Revert.
5941         * breakpoint.c: Revert.
5942         * break-catch-throw.c: Revert.
5943         * break-catch-syscall.c: Revert.
5944         * break-catch-sig.c: Revert.
5945         * blockframe.c: Revert.
5946         * block.c: Revert.
5947         * bfin-tdep.c: Revert.
5948         * bfin-linux-tdep.c: Revert.
5949         * bfd-target.c: Revert.
5950         * bcache.c: Revert.
5951         * ax-general.c: Revert.
5952         * ax-gdb.h: Revert.
5953         * ax-gdb.c: Revert.
5954         * avr-tdep.c: Revert.
5955         * auxv.c: Revert.
5956         * auto-load.c: Revert.
5957         * arm-wince-tdep.c: Revert.
5958         * arm-tdep.c: Revert.
5959         * arm-symbian-tdep.c: Revert.
5960         * arm-pikeos-tdep.c: Revert.
5961         * arm-obsd-tdep.c: Revert.
5962         * arm-nbsd-tdep.c: Revert.
5963         * arm-nbsd-nat.c: Revert.
5964         * arm-linux-tdep.c: Revert.
5965         * arm-linux-nat.c: Revert.
5966         * arm-fbsd-tdep.c: Revert.
5967         * arm-fbsd-nat.c: Revert.
5968         * arm-bsd-tdep.c: Revert.
5969         * arch-utils.c: Revert.
5970         * arc-tdep.c: Revert.
5971         * arc-newlib-tdep.c: Revert.
5972         * annotate.h: Revert.
5973         * annotate.c: Revert.
5974         * amd64-windows-tdep.c: Revert.
5975         * amd64-windows-nat.c: Revert.
5976         * amd64-tdep.c: Revert.
5977         * amd64-sol2-tdep.c: Revert.
5978         * amd64-obsd-tdep.c: Revert.
5979         * amd64-obsd-nat.c: Revert.
5980         * amd64-nbsd-tdep.c: Revert.
5981         * amd64-nbsd-nat.c: Revert.
5982         * amd64-nat.c: Revert.
5983         * amd64-linux-tdep.c: Revert.
5984         * amd64-linux-nat.c: Revert.
5985         * amd64-fbsd-tdep.c: Revert.
5986         * amd64-fbsd-nat.c: Revert.
5987         * amd64-dicos-tdep.c: Revert.
5988         * amd64-darwin-tdep.c: Revert.
5989         * amd64-bsd-nat.c: Revert.
5990         * alpha-tdep.c: Revert.
5991         * alpha-obsd-tdep.c: Revert.
5992         * alpha-nbsd-tdep.c: Revert.
5993         * alpha-mdebug-tdep.c: Revert.
5994         * alpha-linux-tdep.c: Revert.
5995         * alpha-linux-nat.c: Revert.
5996         * alpha-bsd-tdep.c: Revert.
5997         * alpha-bsd-nat.c: Revert.
5998         * aix-thread.c: Revert.
5999         * agent.c: Revert.
6000         * addrmap.c: Revert.
6001         * ada-varobj.c: Revert.
6002         * ada-valprint.c: Revert.
6003         * ada-typeprint.c: Revert.
6004         * ada-tasks.c: Revert.
6005         * ada-lang.c: Revert.
6006         * aarch64-tdep.c: Revert.
6007         * aarch64-ravenscar-thread.c: Revert.
6008         * aarch64-newlib-tdep.c: Revert.
6009         * aarch64-linux-tdep.c: Revert.
6010         * aarch64-linux-nat.c: Revert.
6011         * aarch64-fbsd-tdep.c: Revert.
6012         * aarch64-fbsd-nat.c: Revert.
6013         * aarch32-linux-nat.c: Revert.
6014
6015 2019-04-05  Tom Tromey  <tom@tromey.com>
6016
6017         * ft32-tdep.c: Sort headers.
6018         * frv-tdep.c: Sort headers.
6019         * frv-linux-tdep.c: Sort headers.
6020         * frame.c: Sort headers.
6021         * frame-unwind.c: Sort headers.
6022         * frame-base.c: Sort headers.
6023         * fork-child.c: Sort headers.
6024         * findvar.c: Sort headers.
6025         * findcmd.c: Sort headers.
6026         * filesystem.c: Sort headers.
6027         * filename-seen-cache.h: Sort headers.
6028         * filename-seen-cache.c: Sort headers.
6029         * fbsd-tdep.c: Sort headers.
6030         * fbsd-nat.h: Sort headers.
6031         * fbsd-nat.c: Sort headers.
6032         * f-valprint.c: Sort headers.
6033         * f-typeprint.c: Sort headers.
6034         * f-lang.c: Sort headers.
6035         * extension.h: Sort headers.
6036         * extension.c: Sort headers.
6037         * extension-priv.h: Sort headers.
6038         * expprint.c: Sort headers.
6039         * exec.h: Sort headers.
6040         * exec.c: Sort headers.
6041         * exceptions.c: Sort headers.
6042         * event-top.c: Sort headers.
6043         * event-loop.c: Sort headers.
6044         * eval.c: Sort headers.
6045         * elfread.c: Sort headers.
6046         * dwarf2read.h: Sort headers.
6047         * dwarf2read.c: Sort headers.
6048         * dwarf2loc.c: Sort headers.
6049         * dwarf2expr.h: Sort headers.
6050         * dwarf2expr.c: Sort headers.
6051         * dwarf2-frame.c: Sort headers.
6052         * dwarf2-frame-tailcall.c: Sort headers.
6053         * dwarf-index-write.h: Sort headers.
6054         * dwarf-index-write.c: Sort headers.
6055         * dwarf-index-common.c: Sort headers.
6056         * dwarf-index-cache.h: Sort headers.
6057         * dwarf-index-cache.c: Sort headers.
6058         * dummy-frame.c: Sort headers.
6059         * dtrace-probe.c: Sort headers.
6060         * disasm.h: Sort headers.
6061         * disasm.c: Sort headers.
6062         * disasm-selftests.c: Sort headers.
6063         * dictionary.c: Sort headers.
6064         * dicos-tdep.c: Sort headers.
6065         * demangle.c: Sort headers.
6066         * dcache.h: Sort headers.
6067         * dcache.c: Sort headers.
6068         * darwin-nat.h: Sort headers.
6069         * darwin-nat.c: Sort headers.
6070         * darwin-nat-info.c: Sort headers.
6071         * d-valprint.c: Sort headers.
6072         * d-namespace.c: Sort headers.
6073         * d-lang.c: Sort headers.
6074         * ctf.c: Sort headers.
6075         * csky-tdep.c: Sort headers.
6076         * csky-linux-tdep.c: Sort headers.
6077         * cris-tdep.c: Sort headers.
6078         * cris-linux-tdep.c: Sort headers.
6079         * cp-valprint.c: Sort headers.
6080         * cp-support.c: Sort headers.
6081         * cp-namespace.c: Sort headers.
6082         * cp-abi.c: Sort headers.
6083         * corelow.c: Sort headers.
6084         * corefile.c: Sort headers.
6085         * continuations.c: Sort headers.
6086         * completer.h: Sort headers.
6087         * completer.c: Sort headers.
6088         * complaints.c: Sort headers.
6089         * coffread.c: Sort headers.
6090         * coff-pe-read.c: Sort headers.
6091         * cli-out.h: Sort headers.
6092         * cli-out.c: Sort headers.
6093         * charset.c: Sort headers.
6094         * c-varobj.c: Sort headers.
6095         * c-valprint.c: Sort headers.
6096         * c-typeprint.c: Sort headers.
6097         * c-lang.c: Sort headers.
6098         * buildsym.c: Sort headers.
6099         * buildsym-legacy.c: Sort headers.
6100         * build-id.h: Sort headers.
6101         * build-id.c: Sort headers.
6102         * btrace.c: Sort headers.
6103         * bsd-uthread.c: Sort headers.
6104         * breakpoint.h: Sort headers.
6105         * breakpoint.c: Sort headers.
6106         * break-catch-throw.c: Sort headers.
6107         * break-catch-syscall.c: Sort headers.
6108         * break-catch-sig.c: Sort headers.
6109         * blockframe.c: Sort headers.
6110         * block.c: Sort headers.
6111         * bfin-tdep.c: Sort headers.
6112         * bfin-linux-tdep.c: Sort headers.
6113         * bfd-target.c: Sort headers.
6114         * bcache.c: Sort headers.
6115         * ax-general.c: Sort headers.
6116         * ax-gdb.h: Sort headers.
6117         * ax-gdb.c: Sort headers.
6118         * avr-tdep.c: Sort headers.
6119         * auxv.c: Sort headers.
6120         * auto-load.c: Sort headers.
6121         * arm-wince-tdep.c: Sort headers.
6122         * arm-tdep.c: Sort headers.
6123         * arm-symbian-tdep.c: Sort headers.
6124         * arm-pikeos-tdep.c: Sort headers.
6125         * arm-obsd-tdep.c: Sort headers.
6126         * arm-nbsd-tdep.c: Sort headers.
6127         * arm-nbsd-nat.c: Sort headers.
6128         * arm-linux-tdep.c: Sort headers.
6129         * arm-linux-nat.c: Sort headers.
6130         * arm-fbsd-tdep.c: Sort headers.
6131         * arm-fbsd-nat.c: Sort headers.
6132         * arm-bsd-tdep.c: Sort headers.
6133         * arch-utils.c: Sort headers.
6134         * arc-tdep.c: Sort headers.
6135         * arc-newlib-tdep.c: Sort headers.
6136         * annotate.h: Sort headers.
6137         * annotate.c: Sort headers.
6138         * amd64-windows-tdep.c: Sort headers.
6139         * amd64-windows-nat.c: Sort headers.
6140         * amd64-tdep.c: Sort headers.
6141         * amd64-sol2-tdep.c: Sort headers.
6142         * amd64-obsd-tdep.c: Sort headers.
6143         * amd64-obsd-nat.c: Sort headers.
6144         * amd64-nbsd-tdep.c: Sort headers.
6145         * amd64-nbsd-nat.c: Sort headers.
6146         * amd64-nat.c: Sort headers.
6147         * amd64-linux-tdep.c: Sort headers.
6148         * amd64-linux-nat.c: Sort headers.
6149         * amd64-fbsd-tdep.c: Sort headers.
6150         * amd64-fbsd-nat.c: Sort headers.
6151         * amd64-dicos-tdep.c: Sort headers.
6152         * amd64-darwin-tdep.c: Sort headers.
6153         * amd64-bsd-nat.c: Sort headers.
6154         * alpha-tdep.c: Sort headers.
6155         * alpha-obsd-tdep.c: Sort headers.
6156         * alpha-nbsd-tdep.c: Sort headers.
6157         * alpha-mdebug-tdep.c: Sort headers.
6158         * alpha-linux-tdep.c: Sort headers.
6159         * alpha-linux-nat.c: Sort headers.
6160         * alpha-bsd-tdep.c: Sort headers.
6161         * alpha-bsd-nat.c: Sort headers.
6162         * aix-thread.c: Sort headers.
6163         * agent.c: Sort headers.
6164         * addrmap.c: Sort headers.
6165         * ada-varobj.c: Sort headers.
6166         * ada-valprint.c: Sort headers.
6167         * ada-typeprint.c: Sort headers.
6168         * ada-tasks.c: Sort headers.
6169         * ada-lang.c: Sort headers.
6170         * aarch64-tdep.c: Sort headers.
6171         * aarch64-ravenscar-thread.c: Sort headers.
6172         * aarch64-newlib-tdep.c: Sort headers.
6173         * aarch64-linux-tdep.c: Sort headers.
6174         * aarch64-linux-nat.c: Sort headers.
6175         * aarch64-fbsd-tdep.c: Sort headers.
6176         * aarch64-fbsd-nat.c: Sort headers.
6177         * aarch32-linux-nat.c: Sort headers.
6178
6179 2019-04-04  Tom Tromey  <tom@tromey.com>
6180
6181         * varobj.c (varobj_create): Update.
6182         * rust-exp.y (struct rust_parser) <update_innermost_block,
6183         lookup_symbol>: New methods.
6184         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6185         Rename.
6186         (rust_parser::rust_lookup_type)
6187         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6188         * printcmd.c (display_command, do_one_display): Update.
6189         * parser-defs.h (struct parser_state) <parser_state>: Add
6190         "tracker" parameter.
6191         (block_tracker): New member.
6192         (class innermost_block_tracker) <innermost_block_tracker>: Add
6193         "types" parameter.
6194         <reset>: Remove method.
6195         (innermost_block): Don't declare.
6196         (null_post_parser): Update.
6197         * parse.c (innermost_block): Remove global.
6198         (write_dollar_variable): Update.
6199         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6200         Remove "tracker_types" parameter.
6201         (parse_expression): Add "tracker" parameter.
6202         (parse_expression_for_completion): Update.
6203         (null_post_parser): Add "tracker" parameter.
6204         * p-exp.y: Update rules.
6205         * m2-exp.y: Update rules.
6206         * language.h (struct language_defn) <la_post_parser>: Add
6207         "tracker" parameter.
6208         * go-exp.y: Update rules.
6209         * f-exp.y: Update rules.
6210         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6211         parameter.
6212         * d-exp.y: Update rules.
6213         * c-exp.y: Update rules.
6214         * breakpoint.c (set_breakpoint_condition): Create an
6215         innermost_block_tracker.
6216         (watch_command_1): Likewise.
6217         * ada-lang.c (resolve): Add "tracker" parameter.
6218         (resolve_subexp): Likewise.
6219         * ada-exp.y (write_var_from_sym): Update.
6220
6221 2019-04-04  Tom Tromey  <tom@tromey.com>
6222
6223         * type-stack.h: New file.
6224         * type-stack.c: New file.
6225         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6226         type-stack.h.
6227         (insert_into_type_stack, insert_type, push_type, push_type_int)
6228         (insert_type_address_space, pop_type, pop_type_int)
6229         (pop_typelist, pop_type_stack, append_type_stack)
6230         (push_type_stack, get_type_stack, push_typelist)
6231         (follow_type_instance_flags, follow_types): Don't declare.
6232         * parse.c (type_stack): Remove global.
6233         (parse_exp_in_context): Update.
6234         (insert_into_type_stack, insert_type, push_type, push_type_int)
6235         (insert_type_address_space, pop_type, pop_type_int)
6236         (pop_typelist, pop_type_stack, append_type_stack)
6237         (push_type_stack, get_type_stack, push_typelist)
6238         (follow_type_instance_flags, follow_types): Remove (moved to
6239         type-stack.c).
6240         * f-exp.y (type_stack): New global.
6241         Update rules.
6242         (push_kind_type, f_parse): Update.
6243         * d-exp.y (type_stack): New global.
6244         Update rules.
6245         (d_parse): Update.
6246         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6247         Update rules.
6248         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6249         (HFILES_NO_SRCDIR): Add type-stack.h.
6250
6251 2019-04-04  Tom Tromey  <tom@tromey.com>
6252
6253         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6254         (rust_parser::convert_ast_to_expression, rust_parse)
6255         (rust_lex_test_completion, rust_lex_tests): Update.
6256         * parser-defs.h (struct expr_completion_state): New.
6257         (struct parser_state) <parser_state>: Add completion parameter.
6258         <mark_struct_expression, mark_completion_tag>: New methods.
6259         <parse_completion, m_completion_state>: New members.
6260         (prefixify_expression, null_post_parser): Update.
6261         (mark_struct_expression, mark_completion_tag): Don't declare.
6262         * parse.c (parse_completion, expout_last_struct)
6263         (expout_tag_completion_type, expout_completion_name): Remove
6264         globals.
6265         (parser_state::mark_struct_expression)
6266         (parser_state::mark_completion_tag): Now methods.
6267         (prefixify_expression): Add last_struct parameter.
6268         (prefixify_subexp): Likewise.
6269         (parse_exp_1): Update.
6270         (parse_exp_in_context): Add cstate parameter.  Update.
6271         (parse_expression_for_completion): Create an
6272         expr_completion_state.
6273         (null_post_parser): Add "completion" parameter.
6274         * p-exp.y: Update rules.
6275         (yylex): Update.
6276         * language.h (struct language_defn) <la_post_parser>: Add
6277         "completing" parameter.
6278         * go-exp.y: Update rules.
6279         (lex_one_token): Update.
6280         * expression.h (parse_completion): Don't declare.
6281         * d-exp.y: Update rules.
6282         (lex_one_token): Update rules.
6283         * c-exp.y: Update rules.
6284         (lex_one_token): Update.
6285         * ada-lang.c (resolve): Add "parse_completion" parameter.
6286         (resolve_subexp): Likewise.
6287         (ada_resolve_function): Likewise.
6288
6289 2019-04-04  Tom Tromey  <tom@tromey.com>
6290
6291         * parser-defs.h (struct parser_state) <start_arglist,
6292         end_arglist>: New methods.
6293         <arglist_len, m_funcall_chain>: New members.
6294         (arglist_len, start_arglist, end_arglist): Don't declare.
6295         * parse.c (arglist_len, funcall_chain): Remove global.
6296         (start_arglist, end_arglist): Remove functions.
6297         (parse_exp_in_context): Update.
6298         * p-exp.y: Update rules.
6299         * m2-exp.y: Update rules.
6300         * go-exp.y: Update rules.
6301         * f-exp.y: Update rules.
6302         * d-exp.y: Update rules.
6303         * c-exp.y: Update rules.
6304
6305 2019-04-04  Tom Tromey  <tom@tromey.com>
6306
6307         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6308         lex_operator, push_back>: New methods.
6309         Update all rules.
6310         (rust_parser::lex_hex, lex_escape): Rename and update.
6311         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6312         (rust_parser::lex_operator): Rename and update.
6313         (rust_parser::lex_number, rustyylex, rustyyerror)
6314         (rust_lex_test_init, rust_lex_test_sequence)
6315         (rust_lex_test_push_back, rust_lex_tests): Update.
6316         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6317         parameter.
6318         <lexptr, prev_lexptr>: New members.
6319         (lexptr, prev_lexptr): Don't declare.
6320         * parse.c (lexptr, prev_lexptr): Remove globals.
6321         (parse_exp_in_context): Update.
6322         * p-exp.y (yylex, yyerror): Update.
6323         * m2-exp.y (parse_number, yylex, yyerror): Update.
6324         * go-exp.y (lex_one_token, yyerror): Update.
6325         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6326         * d-exp.y (lex_one_token, yyerror): Update.
6327         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6328         (lex_one_token, yyerror): Update.
6329         * ada-lex.l (YY_INPUT): Update.
6330         (rewind_to_char): Update.
6331         * ada-exp.y (yyerror): Update.
6332
6333 2019-04-04  Tom Tromey  <tom@tromey.com>
6334
6335         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6336         * parser-defs.h (struct parser_state) <parser_state>: Add new
6337         parameter.
6338         <comma_terminates>: New member.
6339         (comma_terminates): Don't declare global.
6340         * parse.c (comma_terminates): Remove global.
6341         (parse_exp_in_context): Update.
6342         * p-exp.y (yylex): Update.
6343         * m2-exp.y (yylex): Update.
6344         * go-exp.y (lex_one_token): Update.
6345         * f-exp.y (yylex): Update.
6346         * d-exp.y (lex_one_token): Update.
6347         * c-exp.y (lex_one_token): Update.
6348         * ada-lex.l: Update.
6349
6350 2019-04-04  Tom Tromey  <tom@tromey.com>
6351
6352         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6353         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6354         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6355         * parser-defs.h (paren_depth): Don't declare.
6356         * parse.c (paren_depth): Remove global.
6357         (parse_exp_in_context): Update.
6358         * p-exp.y (paren_depth): New global.
6359         (pascal_parse): Initialize it.
6360         * m2-exp.y (paren_depth): New global.
6361         (m2_parse): Initialize it.
6362         * go-exp.y (paren_depth): New global.
6363         (go_parse): Initialize it.
6364         * f-exp.y (paren_depth): New global.
6365         (f_parse): Initialize it.
6366         * d-exp.y (paren_depth): New global.
6367         (d_parse): Initialize it.
6368         * c-exp.y (paren_depth): New global.
6369         (c_parse): Initialize it.
6370         * ada-lex.l (paren_depth): New global.
6371         (lexer_init): Initialize it.
6372
6373 2019-04-04  Tom Tromey  <tom@tromey.com>
6374
6375         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6376         (rust_parser::convert_ast_to_type)
6377         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6378         * parser-defs.h (struct parser_state) <parser_state>: Add
6379         parameters.  Initialize new members.
6380         <expression_context_block, expression_context_pc>: New members.
6381         * parse.c (expression_context_block, expression_context_pc):
6382         Remove globals.
6383         (parse_exp_in_context): Update.
6384         * p-exp.y: Update all rules.
6385         (yylex): Update.
6386         * m2-exp.y: Update all rules.
6387         (yylex): Update.
6388         * go-exp.y (yylex): Update.
6389         * f-exp.y (yylex): Update.
6390         * d-exp.y: Update all rules.
6391         (yylex): Update.
6392         * c-exp.y: Update all rules.
6393         (lex_one_token, classify_name, yylex, c_parse): Update.
6394         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6395
6396 2019-04-04  Tom Tromey  <tom@tromey.com>
6397
6398         * gdbarch.h, gdbarch.c: Rebuild.
6399         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6400         * stap-probe.h:
6401         (struct stap_parse_info): Replace "parser_state" with
6402         "expr_builder".
6403         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6404         (parser_state): New class.
6405         * parse.c (expr_builder): Rename.
6406         (expr_builder::release): Rename.
6407         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6408         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6409         (write_exp_elt_longcst, write_exp_elt_floatcst)
6410         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6411         (write_exp_string_vector, write_exp_bitstring)
6412         (write_exp_msymbol, mark_struct_expression)
6413         (write_dollar_variable)
6414         (insert_type_address_space, increase_expout_size): Replace
6415         "parser_state" with "expr_builder".
6416         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6417         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6418         "parser_state" with "expr_builder".
6419
6420 2019-04-04  Tom Tromey  <tom@tromey.com>
6421
6422         * rust-exp.y: Replace "parse_language" with method call.
6423         * p-exp.y:
6424         (yylex): Replace "parse_language" with method call.
6425         * m2-exp.y:
6426         (yylex): Replace "parse_language" with method call.
6427         * go-exp.y (classify_name): Replace "parse_language" with method
6428         call.
6429         * f-exp.y (yylex): Replace "parse_language" with method call.
6430         * d-exp.y (lex_one_token): Replace "parse_language" with method
6431         call.
6432         * c-exp.y:
6433         (lex_one_token, classify_name, yylex): Replace "parse_language"
6434         with method call.
6435         * ada-exp.y (find_primitive_type, type_char)
6436         (type_system_address): Replace "parse_language" with method call.
6437
6438 2019-04-04  Tom Tromey  <tom@tromey.com>
6439
6440         * rust-exp.y: Replace "parse_gdbarch" with method call.
6441         * parse.c (write_dollar_variable, insert_type_address_space):
6442         Replace "parse_gdbarch" with method call.
6443         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6444         call.
6445         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6446         call.
6447         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6448         "parse_gdbarch" with method call.
6449         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6450         with method call.
6451         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6452         "parse_gdbarch" with method call.
6453         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6454         "parse_gdbarch" with method call.
6455         * c-exp.y (parse_type, parse_number, classify_name): Replace
6456         "parse_gdbarch" with method call.
6457         * ada-lex.l: Replace "parse_gdbarch" with method call.
6458         * ada-exp.y (parse_type, find_primitive_type, type_char)
6459         (type_system_address): Replace "parse_gdbarch" with method call.
6460
6461 2019-04-04  Tom Tromey  <tom@tromey.com>
6462
6463         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6464         * stap-probe.c (stap_parse_argument): Update.
6465         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6466         initial_size parameter.
6467         * rust-exp.y (rust_lex_tests): Update.
6468         * parse.c (parser_state): Update.
6469         (parse_exp_in_context): Update.
6470         * parser-defs.h (struct parser_state) <parser_state>: Remove
6471         "initial_size" parameter.
6472
6473 2019-04-04  Tom Tromey  <tom@tromey.com>
6474
6475         * parser-defs.h (increase_expout_size): Don't declare.
6476         * parse.c (increase_expout_size): Now static.
6477
6478 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6479
6480         * gnu-nat.c (gnu_nat_target::wait): Fix
6481         target_waitstatus_to_string call.
6482
6483 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6484
6485         * eval.c (evaluate_subexp_standard): Handle internal functions
6486         during Fortran function call handling.
6487
6488 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6489
6490         * NEWS: Mention new internal functions.
6491         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6492         (read_base_type): Use dwarf2_init_complex_target_type.
6493         * value.c (creal_internal_fn): New function.
6494         (cimag_internal_fn): New function.
6495         (_initialize_values): Register new internal functions.
6496
6497 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6498
6499         * infrun.c (stop_all_threads): If debug_infrun, always
6500         trace the wait status after wait_one, using
6501         target_waitstatus_to_string and target_pid_to_str.
6502         (handle_inferior_event): Replace various trace of
6503         wait status kind by a single trace.
6504         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6505         wait status kind image by target_waitstatus_to_string.
6506         * target/waitstatus.c (target_waitstatus_to_string): Fix
6507         obsolete comment.
6508
6509 2019-04-01  Tom Tromey  <tromey@adacore.com>
6510
6511         PR symtab/23331:
6512         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6513
6514 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6515             Pedro Alves  <palves@redhat.com>
6516
6517         * top.c (quit_force): Call 'finalize_values'.
6518         * value.c (finalize_values): New function.
6519         * value.h (finalize_values): Declare.
6520
6521 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6522
6523         * NEWS: Announce $_gdb_major and $_gdb_minor.
6524
6525         * top.c (init_gdb_version_vars): New function.
6526         (gdb_init): Call init_gdb_version_vars.
6527
6528 2019-03-29  Tom Tromey  <tromey@adacore.com>
6529
6530         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6531         help text.  Remove dead code.
6532
6533 2019-03-29  Keith Seitz  <keiths@redhat.com>
6534
6535         From Siddhesh Poyarekar:
6536         * f-lang.h (f77_get_upperbound): Return LONGEST.
6537         (f77_get_lowerbound): Likewise.
6538         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6539         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6540         print them.
6541         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6542         plongest to format print it.
6543         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6544         (f77_get_upperbound): Likewise.
6545         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6546         LOWER_BOUND to LONGEST.
6547         (f77_create_arrayprint_offset_tbl): Likewise.
6548
6549 2019-03-29  Keith Seitz  <keiths@redhat.com>
6550
6551         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6552         %s/pulongest for TYPE_LENGTH instead of %d in format
6553         strings.
6554         * ada-typerint.c (ada_print_type): Likewise.
6555         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6556         * compile/compile-c-support.c (generate_register_struct): Likewise.
6557         * gdbtypes.c (recursive_dump_type): Likewise.
6558         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6559         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6560         instead of %d in format strings.
6561         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6562         to std::min to ULONGEST.
6563         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6564         instead of %d in format strings.
6565         * tracepoint.c (info_scope_command): Likewise.
6566         * typeprint.c (print_offset_data::update)
6567         (print_offset_data::finish): Likewise.
6568         * xtensa-tdep.c (xtensa_store_return_value)
6569         (xtensa_push_dummy_call): Likewise.
6570
6571 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6572
6573         * windows-nat.c (display_selector): Fixed format specifications
6574         for 64-bit Cygwin.
6575
6576 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6577
6578         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6579
6580 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6581
6582         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6583         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6584         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6585         (nios2_linux_init_abi): Install it.
6586
6587 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6588
6589         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6590
6591 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6592
6593         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6594
6595 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6596             Tom Tromey  <tromey@adacore.com>
6597
6598         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6599
6600 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6601
6602         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6603         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6604         method to compute the bounds of range types. Also print "[evaluated]"
6605         if the bounds' values come from a dynamic evaluation.
6606
6607 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6608
6609         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6610         whitespace when pretty printing is on.
6611
6612 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6613
6614         * ppc-linux-nat.c: Add include.
6615
6616 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6617
6618         * NEWS: Mention AArch64 Pointer Authentication.
6619
6620 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6621
6622         * arm-linux-nat.c: Add include.
6623
6624 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6625
6626         * source-cache.c (source_cache::get_source_lines): Re-read
6627         fullname after calling open_source_file.
6628
6629 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6630
6631         * NEWS: Mention TLS support for FreeBSD.
6632
6633 2019-03-25  Tom Tromey  <tromey@adacore.com>
6634
6635         * minsyms.c (BUNCH_SIZE): Update comment.
6636         (~minimal_symbol_reader): Remove old comment.
6637         (compact_minimal_symbols): Update comment.
6638         (minimal_symbol_reader::install): Remove old comment.  Update
6639         other comments.
6640
6641 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6642
6643         * s390-linux-nat.c: Add include.
6644
6645 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6646
6647         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6648         Call linux_get_hwcap.
6649         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6650         Likewise.
6651         (aarch64_linux_get_hwcap): Remove function.
6652         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6653         declaration.
6654         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6655         linux_get_hwcap.
6656         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6657         * linux-tdep.c (linux_get_hwcap): Add function.
6658         (linux_get_hwcap2): Likewise.
6659         * linux-tdep.h (linux_get_hwcap): Add declaration.
6660         (linux_get_hwcap2): Likewise.
6661         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6662         (ppc_linux_get_hwcap2): Likewise.
6663         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6664         linux_get_hwcap.
6665         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6666         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6667         (ppc_linux_nat_target::read_description): Likewise.
6668         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6669         * s390-linux-nat.c: Likewise.
6670         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6671
6672 2019-03-24  Tom Tromey  <tom@tromey.com>
6673
6674         * ada-lang.c (standard_lookup): Simplify initialization.
6675         (ada_lookup_symbol_nonlocal): Simplify return.
6676         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6677         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6678         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6679         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6680         initialization.
6681         * solib.c (solib_global_lookup): Simplify.
6682         * symtab.c (null_block_symbol): Remove.
6683         (symbol_cache_lookup): Simplify returns.
6684         (lookup_language_this): Simplify returns.
6685         (lookup_symbol_aux): Simplify return.
6686         (lookup_local_symbol): Simplify returns.
6687         (lookup_global_symbol_from_objfile): Simplify return.
6688         (lookup_symbol_in_objfile_symtabs)
6689         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6690         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6691         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6692         * cp-namespace.c (cp_lookup_bare_symbol)
6693         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6694         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6695         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6696         (cp_lookup_symbol_via_imports): Simplify initialization.
6697         (find_symbol_in_baseclass): Likewise.
6698         * symtab.h (null_block_symbol): Remove.
6699         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6700         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6701         (d_lookup_symbol_module): Likewise.
6702         (find_symbol_in_baseclass): Simplify initialization.
6703
6704 2019-03-24  Tom Tromey  <tom@tromey.com>
6705
6706         * expression.h: Don't include symtab.h.
6707         (struct block): Forward declare.
6708
6709 2019-03-24  Tom Tromey  <tom@tromey.com>
6710
6711         * c-exp.y (typebase): Remove casts.
6712         * gdbtypes.c (lookup_unsigned_typename, )
6713         (lookup_signed_typename): Remove cast.
6714         * eval.c (parse_to_comma_and_eval): Remove cast.
6715         * parse.c (write_dollar_variable): Remove cast.
6716         * block.h (struct block) <superblock>: Now const.
6717         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6718         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6719         (map_block): Make "block" const.
6720         * symfile.h (struct quick_symbol_functions)
6721         <map_matching_symbols>: Constify block argument to "callback".
6722         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6723         const.
6724         (find_pc_sect_compunit_symtab): Make "b" const.
6725         (find_symbol_at_address): Likewise.
6726         (search_symbols): Likewise.
6727         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6728         (dw2_debug_names_lookup_symbol): Likewise.
6729         (dw2_map_matching_symbols): Update.
6730         * p-valprint.c (pascal_val_print): Remove "block".
6731         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6732         (aux_add_nonlocal_symbols): Make "block" const.
6733         (resolve_subexp): Remove cast.
6734         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6735         const.
6736         (iterate_over_file_blocks): Likewise.
6737         * f-exp.y (%union) <bval>: Remove.
6738         * coffread.c (patch_opaque_types): Make "b" const.
6739         * spu-tdep.c (spu_catch_start): Make "block" const.
6740         * c-valprint.c (print_unpacked_pointer): Remove "block".
6741         * symmisc.c (dump_symtab_1): Make "b" const.
6742         (block_depth): Make "block" const.
6743         * d-exp.y (%union) <bval>: Remove.
6744         * cp-support.h (cp_lookup_rtti_type): Update.
6745         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6746         * psymtab.c (psym_lookup_symbol): Make "block" const.
6747         (maintenance_check_psymtabs): Make "b" const.
6748         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6749         (enumerate_locals, enumerate_args): Update.
6750         * python/py-symtab.c (stpy_global_block): Make "block" const.
6751         (stpy_static_block): Likewise.
6752         * inline-frame.c (block_starting_point_at): Make "new_block"
6753         const.
6754         * block.c (find_block_in_blockvector): Make return type const.
6755         (blockvector_for_pc_sect): Make "b" const.
6756         (find_block_in_blockvector): Make "b" const.
6757
6758 2019-03-23  Tom Tromey  <tom@tromey.com>
6759
6760         * varobj.c (varobj_create): Update.
6761         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6762         * printcmd.c (display_command, do_one_display): Don't reset
6763         innermost_block.
6764         * parser-defs.h (enum innermost_block_tracker_type): Move to
6765         expression.h.
6766         (innermost_block): Update comment.
6767         * parse.c (parse_exp_1): Add tracker_types parameter.
6768         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6769         tracker_types parameter.  Reset innermost_block.
6770         (parse_exp_in_context): Remove.
6771         (parse_expression_for_completion): Update.
6772         * objfiles.c (~objfile): Don't reset expression_context_block or
6773         innermost_block.
6774         * expression.h (enum innermost_block_tracker_type): Move from
6775         parser-defs.h.
6776         (parse_exp_1): Add tracker_types parameter.
6777         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6778         reset innermost_block.
6779
6780 2019-03-23  Tom Tromey  <tom@tromey.com>
6781
6782         * objfiles.h: Include bcache.h.
6783
6784 2019-03-23  Tom Tromey  <tom@tromey.com>
6785
6786         * linespec.c (get_current_search_block): Use
6787         scoped_restore_current_language.
6788         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6789
6790 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6791             Jiong Wang  <jiong.wang@arm.com>
6792
6793         * aarch64-linux-tdep.c
6794         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6795         section.
6796         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6797
6798 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6799             Jiong Wang  <jiong.wang@arm.com>
6800
6801         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6802         instructions.
6803         (aarch64_analyze_prologue_test): Add PACIASP test.
6804         (aarch64_prologue_prev_register): Unmask PC value.
6805
6806 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6807             Jiong Wang  <jiong.wang@arm.com>
6808
6809         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6810         (aarch64_dwarf2_prev_register): Unmask PC value.
6811         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6812         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6813         DW_CFA_AARCH64_negate_ra_state.
6814         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6815
6816 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6817             Jiong Wang  <jiong.wang@arm.com>
6818
6819         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6820         registers.
6821         (aarch64_pseudo_register_name): Likewise.
6822         (aarch64_pseudo_register_type): Likewise.
6823         (aarch64_pseudo_register_reggroup_p): Likewise.
6824         (aarch64_gdbarch_init): Add pauth registers.
6825         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6826         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6827         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6828         (struct gdbarch_tdep): Add regnum for ra_state.
6829
6830 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6831             Jiong Wang  <jiong.wang@arm.com>
6832
6833         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6834
6835 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6836             Jiong Wang  <jiong.wang@arm.com>
6837
6838         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6839         function.
6840         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6841         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6842         (aarch64_gdbarch_init): Add puth registers.
6843         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6844         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6845         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6846
6847 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6848             Jiong Wang  <jiong.wang@arm.com>
6849
6850         * aarch64-linux-nat.c
6851         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6852         * aarch64-linux-tdep.c
6853         (aarch64_linux_core_read_description): Likewise.
6854         (aarch64_linux_get_hwcap): New function.
6855         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6856         (aarch64_linux_get_hwcap): New declaration.
6857
6858 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6859             Jiong Wang  <jiong.wang@arm.com>
6860
6861         * aarch64-linux-nat.c
6862         (aarch64_linux_nat_target::read_description): Add pauth param.
6863         * aarch64-linux-tdep.c
6864         (aarch64_linux_core_read_description): Likewise.
6865         * aarch64-tdep.c (struct target_desc): Add in pauth.
6866         (aarch64_read_description): Add pauth param.
6867         (aarch64_gdbarch_init): Likewise.
6868         * aarch64-tdep.h (aarch64_read_description): Likewise.
6869         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6870         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6871         * features/Makefile: Add new files.
6872         * features/aarch64-pauth.c: New file.
6873         * features/aarch64-pauth.xml: New file.
6874
6875 2019-03-20  Tom Tromey  <tromey@adacore.com>
6876
6877         * infrun.c (handle_inferior_event): Rename from
6878         handle_inferior_event_1.  Create a scoped_value_mark.
6879         (handle_inferior_event): Remove.
6880
6881 2019-03-19  Tom Tromey  <tromey@adacore.com>
6882
6883         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6884         * infrun.h (print_stop_event): Add "displays" parameter.
6885         * infrun.c (print_stop_event): Add "displays" parameter.
6886
6887 2019-03-19  Pedro Alves  <palves@redhat.com>
6888
6889         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6890         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6891         to -1.  Fix TABs vs spaces.
6892         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6893         * tui/tui-out.h (tui_ui_out) Add intro comments.
6894         <m_line, m_start_of_line>: In-class initialize, and add describing
6895         comment.
6896
6897 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6898
6899         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6900         variable names.
6901         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6902
6903 2019-03-18  Pedro Alves  <palves@redhat.com>
6904             Eli Zaretskii <eliz@gnu.org>
6905
6906         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6907         m_line and m_start_of_line.
6908
6909 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6910
6911         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6912         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6913         it returns a newline.  This fixes a regression in TU mode, whereby
6914         the next line is output on the same screen line as the user input.
6915
6916 2019-03-18  Tom Tromey  <tromey@adacore.com>
6917
6918         * minsyms.c (minimal_symbol_reader::install): Remove call to
6919         obstack_blank.
6920
6921 2019-03-18  Pedro Alves  <palves@redhat.com>
6922
6923         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6924         New globals.
6925         (apply_style): New, factored out from ...
6926         (apply_ansi_escape): ... this.  Handle reverse video mode.
6927         (tui_set_reverse_mode): New function.
6928         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6929         * tui/tui-winsource.c (tui_show_source_line): Use
6930         tui_set_reverse_mode instead of setting A_STANDOUT.
6931         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6932         New setter methods.
6933
6934 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6935
6936         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6937         Handle tabs.
6938
6939 2019-03-18  Tom Tromey  <tromey@adacore.com>
6940
6941         * ada-lang.c (empty_array): Add "high" parameter.
6942         (ada_evaluate_subexp): Update.
6943
6944 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6945
6946         * unittests/string_view-selftests.c: Define
6947         _initialize_string_view_selftests unconditionally.
6948
6949 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6950
6951         PR gdb/24350
6952         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6953
6954 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6955
6956         PR gdb/24351
6957         * windows-nat.c (display_selector): Fix format specifiers.
6958
6959 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6960
6961         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6962         tui_refill_source_window instead of tui_refresh_win, to update the
6963         current execution line.  This fixes redisplay of the current line
6964         when stepping through the code with "next" or "step".
6965
6966 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6967
6968         * source-cache.c (source_cache::get_source_lines): Call
6969         find_source_lines to initialize s->nlines.  This fixes vertical
6970         scrolling of TUI source window when the DOWN arrow is pressed.
6971
6972 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6973
6974         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6975         linux-thread-db.c (_initialize_thread_db): Likewise.
6976
6977 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6978
6979         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6980         wclrtoeol in tui_show_source_line".  This reverts changes made in
6981         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6982
6983 2019-03-15  Tom Tromey  <tom@tromey.com>
6984
6985         * symtab.h (struct minimal_symbol): Derive from
6986         general_symbol_info.
6987         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6988         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6989         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6990         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6991         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6992         (MSYMBOL_SEARCH_NAME): Update.
6993         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6994         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6995         * minsyms.c (minimal_symbol_reader::record_full): Update.
6996
6997 2019-03-15  Tom Tromey  <tom@tromey.com>
6998
6999         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7000
7001 2019-03-15  Tom Tromey  <tom@tromey.com>
7002
7003         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7004         unique_xmalloc_ptr.
7005         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7006         Update.
7007         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7008         (build_minimal_symbol_hash_tables)
7009         (minimal_symbol_reader::install): Update.
7010
7011 2019-03-15  Tom Tromey  <tom@tromey.com>
7012
7013         * symtab.c (create_demangled_names_hash): Update.
7014         (symbol_set_names): Update.
7015         * objfiles.h (struct objfile_per_bfd_storage)
7016         <demangled_names_hash>: Now an htab_up.
7017         * objfiles.c (objfile_per_bfd_storage): Simplify.
7018
7019 2019-03-15  Tom Tromey  <tom@tromey.com>
7020
7021         * objfiles.h (struct objfile_per_bfd_storage): Declare
7022         destructor.
7023         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7024         New.
7025         (get_objfile_bfd_data): Use new.  Don't initialize
7026         language_of_main.
7027         (free_objfile_per_bfd_storage): Remove.
7028         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7029
7030 2019-03-15  Tom Tromey  <tom@tromey.com>
7031
7032         * symfile.c (reread_symbols): Update.
7033         * objfiles.c (objfile::objfile): Update.
7034         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7035         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7036         comment.
7037         (minimal_symbol_reader::install): Update.
7038         (terminate_minimal_symbol_table): Remove.
7039         * jit.c (jit_object_close_impl): Update.
7040
7041 2019-03-15  Tom Tromey  <tom@tromey.com>
7042
7043         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7044         initializations.
7045
7046 2019-03-15  Tom Tromey  <tom@tromey.com>
7047
7048         * objfiles.h (struct objfile_per_bfd_storage)
7049         <demangled_hash_languages>: Now a bitset.
7050         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7051         (lookup_minimal_symbol): Update.
7052
7053 2019-03-15  Tom Tromey  <tom@tromey.com>
7054
7055         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7056         Don't return the symbol.
7057         * coffread.c (record_minimal_symbol): Use record_full.
7058
7059 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7060
7061         The MS-Windows port of ncurses fails to switch to a color pair if
7062         one or both of the colors are the implicit default colors.  This
7063         change records the default colors when TUI is initialized, and
7064         then specifies them explicitly when a color pair uses the default
7065         colors.  This allows color styling in TUI mode on MS-Windows.
7066
7067         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7068         ncurses_norm_attr.
7069         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7070         colors in ncurses_norm_attr.
7071         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7072         "none", replace it with the default color recorded in
7073         ncurses_norm_attr.
7074
7075 2019-03-14  Tom Tromey  <tromey@adacore.com>
7076
7077         * source-cache.h (class source_cache) <get_source_lines>: Return
7078         std::string.
7079         * source-cache.c (source_cache::extract_lines): Handle case where
7080         first_pos==npos.  Return std::string.
7081         (source_cache::get_source_lines): Update.
7082
7083 2019-03-14  Tom Tromey  <tromey@adacore.com>
7084
7085         * NEWS: Add item for "style sources" commands.
7086         * source-cache.c (source_cache::get_source_lines): Check
7087         source_styling.
7088         * cli/cli-style.c (source_styling): New global.
7089         (_initialize_cli_style): Add "style sources" commands.
7090         (show_style_sources): New function.
7091         * cli/cli-style.h (source_styling): Declare.
7092
7093 2019-03-14  Pedro Alves  <palves@redhat.com>
7094             Tom Tromey  <tromey@adacore.com>
7095
7096         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7097         * tui/tui-winsource.c (tui_refill_source_window): New function,
7098         from...
7099         (tui_horizontal_source_scroll): ... here.  Move some logic.
7100         * cli/cli-style.c (set_style_enabled): Notify new observable.
7101         * tui/tui-hooks.c (tui_redisplay_source): New function.
7102         (tui_attach_detach_observers): Attach or detach
7103         tui_redisplay_source.
7104         * observable.h (source_styling_changed): New observable.
7105         * observable.c: Define source_styling_changed observable.
7106
7107 2019-03-13  Tom Tromey  <tromey@adacore.com>
7108
7109         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7110         (i386_gnu_nat_target::store_registers): Update.
7111         * target-debug.h (target_debug_print_std_string): New macro.
7112         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7113         * windows-tdep.c (display_one_tib): Update.
7114         * tui/tui-stack.c (tui_make_status_line): Update.
7115         * top.c (print_inferior_quit_action): Update.
7116         * thread.c (thr_try_catch_cmd): Update.
7117         (add_thread_with_info): Update.
7118         (thread_target_id_str): Update.
7119         (thr_try_catch_cmd): Update.
7120         (thread_command): Update.
7121         (thread_find_command): Update.
7122         * record-btrace.c (record_btrace_target::info_record)
7123         (record_btrace_resume_thread, record_btrace_target::resume)
7124         (record_btrace_cancel_resume, record_btrace_step_thread)
7125         (record_btrace_target::wait, record_btrace_target::wait)
7126         (record_btrace_target::wait, record_btrace_target::stop): Update.
7127         * progspace.c (print_program_space): Update.
7128         * process-stratum-target.c
7129         (process_stratum_target::thread_address_space): Update.
7130         * linux-fork.c (linux_fork_mourn_inferior)
7131         (detach_checkpoint_command, info_checkpoints_command)
7132         (linux_fork_context): Update.
7133         (linux_fork_detach): Update.
7134         (class scoped_switch_fork_info): Update.
7135         (delete_checkpoint_command): Update.
7136         * infrun.c (follow_fork_inferior): Update.
7137         (follow_fork_inferior): Update.
7138         (proceed_after_vfork_done): Update.
7139         (handle_vfork_child_exec_or_exit): Update.
7140         (follow_exec): Update.
7141         (displaced_step_prepare_throw): Update.
7142         (displaced_step_restore): Update.
7143         (start_step_over): Update.
7144         (resume_1): Update.
7145         (clear_proceed_status_thread): Update.
7146         (proceed): Update.
7147         (print_target_wait_results): Update.
7148         (do_target_wait): Update.
7149         (context_switch): Update.
7150         (stop_all_threads): Update.
7151         (restart_threads): Update.
7152         (finish_step_over): Update.
7153         (handle_signal_stop): Update.
7154         (switch_back_to_stepped_thread): Update.
7155         (keep_going_pass_signal): Update.
7156         (print_exited_reason): Update.
7157         (normal_stop): Update.
7158         * inferior.c (inferior_pid_to_str): Change return type.
7159         (print_selected_inferior): Update.
7160         (add_inferior): Update.
7161         (detach_inferior): Update.
7162         * dummy-frame.c (fprint_dummy_frames): Update.
7163         * dcache.c (dcache_info_1): Update.
7164         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7165         (btrace_fetch, btrace_clear): Update.
7166         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7167         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7168         type.
7169         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7170         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7171         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7172         * gdbarch.c, gdbarch.h: Rebuild.
7173         * gdbarch.sh (core_pid_to_str): Change return type.
7174         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7175         return type.
7176         (windows_nat_target::pid_to_str): Change return type.
7177         (windows_delete_thread): Update.
7178         (windows_nat_target::attach): Update.
7179         (windows_nat_target::files_info): Update.
7180         * target-delegates.c: Rebuild.
7181         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7182         return type.
7183         (sol_thread_target::pid_to_str): Change return type.
7184         * remote.c (class remote_target) <pid_to_str>: Change return
7185         type.
7186         (remote_target::pid_to_str): Change return type.
7187         (extended_remote_target::attach, remote_target::remote_stop_ns)
7188         (remote_target::remote_notif_remove_queued_reply)
7189         (remote_target::push_stop_reply, remote_target::disable_btrace):
7190         Update.
7191         (extended_remote_target::attach): Update.
7192         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7193         type.
7194         (gdbsim_target::pid_to_str): Change return type.
7195         * ravenscar-thread.c (struct ravenscar_thread_target)
7196         <pid_to_str>: Change return type.
7197         (ravenscar_thread_target::pid_to_str): Change return type.
7198         * procfs.c (class procfs_target) <pid_to_str>: Change return
7199         type.
7200         (procfs_target::pid_to_str): Change return type.
7201         (procfs_target::attach): Update.
7202         (procfs_target::detach): Update.
7203         (procfs_target::fetch_registers): Update.
7204         (procfs_target::store_registers): Update.
7205         (procfs_target::wait): Update.
7206         (procfs_target::files_info): Update.
7207         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7208         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7209         return type.
7210         (nto_procfs_target::pid_to_str): Change return type.
7211         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7212         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7213         return type.
7214         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7215         (exit_lwp): Update.
7216         (attach_proc_task_lwp_callback, get_detach_signal)
7217         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7218         (linux_nat_target::resume, wait_lwp, stop_callback)
7219         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7220         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7221         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7222         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7223         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7224         type.
7225         (inf_ptrace_target::attach): Update.
7226         (inf_ptrace_target::files_info): Update.
7227         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7228         type.
7229         (go32_nat_target::pid_to_str): Change return type.
7230         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7231         (gnu_nat_target::wait): Update.
7232         (gnu_nat_target::wait): Update.
7233         (gnu_nat_target::resume): Update.
7234         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7235         (fbsd_nat_target::wait): Update.
7236         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7237         type.
7238         (darwin_nat_target::attach): Update.
7239         * corelow.c (class core_target) <pid_to_str>: Change return type.
7240         (core_target::pid_to_str): Change return type.
7241         * target.c (normal_pid_to_str): Change return type.
7242         (default_pid_to_str): Likewise.
7243         (target_pid_to_str): Change return type.
7244         (target_translate_tls_address): Update.
7245         (target_announce_detach): Update.
7246         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7247         return type.
7248         (bsd_uthread_target::pid_to_str): Change return type.
7249         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7250         type.
7251         (bsd_kvm_target::pid_to_str): Change return type.
7252         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7253         return type.
7254         (aix_thread_target::pid_to_str): Change return type.
7255         * target.h (struct target_ops) <pid_to_str>: Change return type.
7256         (target_pid_to_str, normal_pid_to_str): Likewise.
7257         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7258         type.
7259         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7260         type.
7261         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7262         return type.
7263         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7264         type.
7265         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7266         type.
7267         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7268         return type.
7269
7270 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7271
7272         * NEWS: Mention that the new default MI version is 3.  Mention
7273         changes to the output of commands and events that deal with
7274         multi-location breakpoints.
7275         * breakpoint.c: Include "mi/mi-out.h".
7276         (print_one_breakpoint): Change output syntax if using MI version
7277         >= 3.
7278         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7279         New.
7280         (mi_multi_location_breakpoint_output_fixed): New.
7281         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7282         (mi_cmd_fix_multi_location_breakpoint_output): New.
7283         (mi_multi_location_breakpoint_output_fixed): New.
7284         * mi/mi-cmds.c (mi_cmds): Register command
7285         -fix-multi-location-breakpoint-output.
7286         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7287         interpreter "mi".
7288
7289 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7290
7291         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7292         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7293         instantiate mi_ui_out based on interpreter name.
7294         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7295         * mi/mi-main.c (mi_load_progress): Likewise.
7296
7297 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7298
7299         * NEWS: Combine separate "New targets" sections for 8.3.
7300
7301 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7302
7303         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7304         (ppcfbsd_init_abi): Install gdbarch
7305         "fetch_tls_load_module_address" and "get_thread_local_address"
7306         methods.
7307
7308 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7309
7310         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7311         (riscv_fbsd_init_abi): Install gdbarch
7312         "fetch_tls_load_module_address" and "get_thread_local_address"
7313         methods.
7314
7315 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7316
7317         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7318         (i386fbsd_init_abi): Install gdbarch
7319         "fetch_tls_load_module_address" and "get_thread_local_address"
7320         methods.
7321
7322 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7323
7324         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7325         (amd64fbsd_init_abi): Install gdbarch
7326         "fetch_tls_load_module_address" and "get_thread_local_address"
7327         methods.
7328
7329 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7330
7331         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7332         (struct fbsd_pspace_data): New type.
7333         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7334         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7335         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7336         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7337         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7338
7339 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7340
7341         * gdbtypes.c (lookup_struct_elt): New function.
7342         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7343         * gdbtypes.h (struct struct_elt): New type.
7344         (lookup_struct_elt): New prototype.
7345
7346 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7347
7348         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7349         remove disabled code block.
7350
7351 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7352
7353         * gdbarch.sh (get_thread_local_address): New method.
7354         * gdbarch.h, gdbarch.c: Regenerate.
7355         * target.c (target_translate_tls_address): Use
7356         gdbarch_get_thread_local_address if present instead of
7357         target::get_thread_local_address.
7358
7359 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7360
7361         * target.h (target::get_thread_local_address): Update comment.
7362
7363 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7364
7365         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7366         objfile->separate_debug_objfile_backlink if not NULL.
7367
7368 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7369
7370         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7371         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7372         (amd64bsd_store_inferior_registers): Likewise.
7373         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7374         Enable segment base registers.
7375         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7376         PT_GETFSBASE and PT_GETGSBASE.
7377         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7378         PT_SETGSBASE.
7379         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7380         segment base registers.
7381         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7382
7383 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7384
7385         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7386         Update calls to i386_target_description to add 'segments'
7387         parameter.
7388         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7389         add segment base registers.
7390         * arch/i386.c (i386_create_target_description): Add 'segments'
7391         parameter to enable segment base registers.
7392         * arch/i386.h (i386_create_target_description): Likewise.
7393         * features/i386/32bit-segments.xml: New file.
7394         * features/i386/32bit-segments.c: Generate.
7395         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7396         call to i386_target_description to add 'segments' parameter.
7397         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7398         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7399         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7400         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7401         if feature is present.
7402         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7403         Add 'segments' parameter to call to i386_target_description.
7404         (i386_target_description): Add 'segments' parameter to enable
7405         segment base registers.
7406         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7407         to call to i386_target_description.
7408         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7409         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7410         Define I386_NUM_REGS.
7411         (i386_target_description): Add 'segments' parameter to enable
7412         segment base registers.
7413
7414 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7415
7416         PR/24325
7417         * source-cache.c: #undef open and close, to avoid unresolved
7418         externals during linking.
7419
7420 2019-03-12  Tom Tromey  <tromey@adacore.com>
7421
7422         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7423         const.  Add initializers.
7424         (_initialize_remote): Don't initialize ptid globals.
7425
7426 2019-03-12  Pedro Alves  <palves@redhat.com>
7427
7428         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7429
7430 2019-03-12  Pedro Alves  <palves@redhat.com>
7431
7432         * cp-name-parser.y (main): Remove unused 'len' variable.
7433
7434 2019-03-12  Tom Tromey  <tromey@adacore.com>
7435
7436         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7437         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7438
7439 2019-03-12  Tom Tromey  <tromey@adacore.com>
7440
7441         * linux-nat.c (iterate_over_lwps): Update.
7442         (stop_callback): Remove parameter.
7443         (stop_wait_callback, detach_callback, resume_set_callback)
7444         (select_singlestep_lwp_callback, set_ignore_sigint)
7445         (status_callback, resumed_callback, resume_clear_callback)
7446         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7447         data parameter.
7448         (linux_nat_target::detach, linux_nat_target::resume)
7449         (linux_stop_and_wait_all_lwps, select_event_lwp)
7450         (linux_nat_filter_event, linux_nat_wait_1)
7451         (linux_nat_target::kill, linux_nat_target::stop)
7452         (linux_nat_target::stop): Update.
7453         (linux_nat_resume_callback): Change type.
7454         (resume_stopped_resumed_lwps, count_events_callback)
7455         (select_event_lwp_callback): Likewise.
7456         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7457         * arm-linux-nat.c (struct update_registers_data): Remove.
7458         (update_registers_callback): Change type.
7459         (arm_linux_insert_hw_breakpoint1): Update.
7460         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7461         parameter.
7462         (x86_linux_dr_set_addr): Update.
7463         (x86_linux_dr_set_control): Update.
7464         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7465         (iterate_over_lwps): Use gdb::function_view.
7466         * nat/aarch64-linux-hw-point.c (struct
7467         aarch64_dr_update_callback_param): Remove.
7468         (debug_reg_change_callback): Change type.
7469         (aarch64_notify_debug_reg_change): Update.
7470         * s390-linux-nat.c (s390_refresh_per_info): Update.
7471
7472 2019-03-11  Tom Tromey  <tromey@adacore.com>
7473
7474         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7475         redundant assignment to "this_cu".
7476
7477 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7478
7479         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7480
7481 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7482
7483         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7484         from...
7485         (rank_one_type): ... this.
7486
7487 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7488
7489         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7490         from...
7491         (rank_one_type): ... this.
7492
7493 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7494
7495         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7496         from...
7497         (rank_one_type): ... this.
7498
7499 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7500
7501         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7502         from...
7503         (rank_one_type): ... this.
7504
7505 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7506
7507         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7508         from...
7509         (rank_one_type): ... this.
7510
7511 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7512
7513         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7514         from...
7515         (rank_one_type): ... this.
7516
7517 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7518
7519         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7520         from...
7521         (rank_one_type): ... this.
7522
7523 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7524
7525         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7526         from...
7527         (rank_one_type): ... this.
7528
7529 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7530
7531         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7532         from...
7533         (rank_one_type): ... this.
7534
7535 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7536
7537         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7538         from...
7539         (rank_one_type): ... this.
7540
7541 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7542
7543         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7544         from...
7545         (rank_one_type): ... this.
7546
7547 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7548
7549         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7550         from...
7551         (rank_one_type): ... this.
7552
7553 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7554
7555         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7556         inferior-events' shows the example events.
7557
7558 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7559
7560         Support styling on native MS-Windows console
7561
7562         PR/24315
7563         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7564         on MS-Windows if $TERM is not defined.
7565
7566         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7567
7568         * posix-hdep.c (gdb_console_fputs):
7569         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7570         functions.
7571         * ui-file.h (gdb_console_fputs): Add prototype.
7572
7573         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7574         back to fputs only if the former returns zero.
7575
7576 2019-03-07  Tom Tromey  <tom@tromey.com>
7577
7578         * symmisc.c (print_symbol_bcache_statistics): Update.
7579         (print_objfile_statistics): Update.
7580         * symfile.c (allocate_symtab): Update.
7581         * stabsread.c: Don't include bcache.h.
7582         * psymtab.h (struct psymbol_bcache): Don't declare.
7583         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7584         (psymbol_bcache_init, psymbol_bcache_free)
7585         (psymbol_bcache_get_bcache): Don't declare.
7586         * psymtab.c (struct psymbol_bcache): Remove.
7587         (psymtab_storage::psymtab_storage): Update.
7588         (psymtab_storage::~psymtab_storage): Update.
7589         (psymbol_bcache_init, psymbol_bcache_free)
7590         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7591         (add_psymbol_to_bcache): Update.
7592         (allocate_psymtab): Update.
7593         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7594         macro_cache>: No longer pointers.
7595         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7596         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7597         * macrotab.c (macro_bcache): Update.
7598         * macroexp.c: Don't include bcache.h.
7599         * gdbtypes.c (check_types_worklist): Update.
7600         (types_deeply_equal): Remove TRY/CATCH.  Update.
7601         * elfread.c (elf_symtab_read): Update.
7602         * dwarf2read.c: Don't include bcache.h.
7603         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7604         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7605         (print_bcache_statistics, bcache_memory_used): Don't declare.
7606         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7607         methods.  Rename all data members.
7608         * bcache.c (struct bcache): Move to bcache.h.
7609         (bcache::expand_hash_table): Rename from expand_hash_table.
7610         (bcache): Remove.
7611         (bcache::insert): Rename from bcache_full.
7612         (bcache::compare): Rename from bcache_compare.
7613         (bcache_xmalloc): Remove.
7614         (bcache::~bcache): Rename from bcache_xfree.
7615         (bcache::print_statistics): Rename from print_bcache_statistics.
7616         (bcache::memory_used): Rename from bcache_memory_used.
7617
7618 2019-03-07  Pedro Alves  <palves@redhat.com>
7619
7620         * infrun.c (normal_stop): Also check for
7621         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7622
7623 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7624
7625         * f-lang.c (value_from_host_double): Moved to...
7626         * value.c (value_from_host_double): ...here.
7627         * value.h (value_from_host_double): Declare.
7628         * guile/scm-math.c (vlscm_convert_typed_number): Use
7629         value_from_host_double.
7630         (vlscm_convert_number): Likewise.
7631         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7632         * python/py-value.c (convert_value_from_python): Likewise.
7633
7634 2019-03-06  Tom Tromey  <tom@tromey.com>
7635
7636         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7637
7638 2019-03-06  Tom Tromey  <tom@tromey.com>
7639
7640         * utils.h (free_current_contents): Don't declare.
7641         * utils.c (free_current_contents): Remove.
7642
7643 2019-03-06  Tom Tromey  <tom@tromey.com>
7644
7645         * top.c (quit_force): Update.
7646         * main.c (captured_command_loop): Update.
7647         * common/new-op.c (operator new): Update.
7648         * common/common-exceptions.c (struct catcher)
7649         <save_cleanup_chain>: Remove member.
7650         (exceptions_state_mc_init): Update.
7651         (exception_try_scope_entry): Return nullptr.
7652         (exception_try_scope_exit, exception_rethrow)
7653         (throw_exception_sjlj, throw_exception_cxx): Update.
7654         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7655         (all_cleanups, do_cleanups, discard_cleanups)
7656         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7657         (restore_cleanups, restore_final_cleanups): Don't declare.
7658         (do_final_cleanups): Remove parameter.
7659         * common/cleanups.c (cleanup_chain, make_cleanup)
7660         (make_cleanup_dtor, all_cleanups, do_cleanups)
7661         (discard_my_cleanups, discard_cleanups)
7662         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7663         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7664         (null_cleanup): Remove.
7665         (do_final_cleanups): Remove parameter.
7666
7667 2019-03-06  Tom Tromey  <tom@tromey.com>
7668
7669         * remote.c (remote_target::remote_parse_stop_reply): Use
7670         unique_xmalloc_ptr.
7671
7672 2019-03-06  Tom Tromey  <tom@tromey.com>
7673
7674         * stabsread.c (struct stabs_field_info): Rename from field_info.
7675         <list, fnlist>: Add initializers.
7676         <obstack>: New member.
7677         (read_member_functions, read_struct_fields, read_baseclasses):
7678         Allocate on obstack.  Don't use cleanups.
7679         (read_one_struct_field, read_member_functions, read_struct_fields)
7680         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7681         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7682         (read_struct_type): Update.
7683
7684 2019-03-06  Tom Tromey  <tom@tromey.com>
7685
7686         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7687         * common/filestuff.h (make_cleanup_close): Don't declare.
7688         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7689         Remove.
7690
7691 2019-03-06  Tom Tromey  <tom@tromey.com>
7692
7693         * solib-aix.c: Use make_scope_exit.
7694
7695 2019-03-06  Tom Tromey  <tom@tromey.com>
7696
7697         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7698         Use make_scope_exit.
7699
7700 2019-03-06  Tom Tromey  <tom@tromey.com>
7701
7702         * solib-svr4.c (disable_probes_interface): Remove parameter.
7703         (svr4_handle_solib_event): Use make_scope_exit.
7704
7705 2019-03-06  Tom Tromey  <tom@tromey.com>
7706
7707         * remote.c (struct stop_reply_deleter): Remove.
7708         (stop_reply_up): Update.
7709         (struct stop_reply): Derive from notif_event.  Don't typedef.
7710         <regcache>: Now a std::vector.
7711         (stop_reply_xfree): Remove.
7712         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7713         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7714         (remote_target::discard_pending_stop_replies): Use delete.
7715         (remote_target::remote_parse_stop_reply): Update.
7716         (remote_target::process_stop_reply): Update.
7717         * remote-notif.h (struct notif_event): Add virtual destructor.
7718         Remove "dtr" member.
7719         (struct notif_client) <alloc_event>: Return a unique_ptr.
7720         (notif_event_xfree): Don't declare.
7721         (notif_event_up): New typedef.
7722         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7723         (notif_event_xfree, do_notif_event_xfree): Remove.
7724         (remote_notif_state_xfree): Update.
7725
7726 2019-03-06  Tom Tromey  <tom@tromey.com>
7727
7728         * infrun.c (displaced_step_clear_cleanup): Now a
7729         forward_scope_exit type.
7730         (displaced_step_prepare_throw): Update.
7731         (displaced_step_fixup): Update.
7732
7733 2019-03-06  Tom Tromey  <tom@tromey.com>
7734
7735         * inferior.h (class inferior): Update comment.
7736         * gdbthread.h (class thread_info): Update comment.
7737
7738 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7739             Tom Tromey  <tom@tromey.com>
7740
7741         * stabsread.h (struct stab_section_list): Remove.
7742         (coffstab_build_psymtabs): Update.
7743         * dbxread.c (symbuf_sections): Now a std::vector.
7744         (sect_idx): New global.
7745         (fill_symbuf): Update.
7746         (coffstab_build_psymtabs): Change type of stabsects parameter.
7747         Update.
7748         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7749         std::vector.
7750         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7751         (coff_locate_sections): Update.
7752         (coff_symfile_read): Remove cleanups.  Update.
7753         (init_stringtab): Add storage parameter.
7754         (free_stringtab, free_stringtab_cleanup): Remove.
7755         (init_lineno): Add storage parameter.
7756         (free_linetab, free_linetab_cleanup): Remove.
7757
7758 2019-03-06  Pedro Alves  <palves@redhat.com>
7759
7760         * linux-fork.c (fork_info::clobber_regs): Delete.
7761         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7762         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7763         comment.  Adjust.
7764         (scoped_switch_fork_info::scoped_switch_fork_info)
7765         (checkpoint_command, linux_fork_context): Adjust
7766         fork_save_infrun_state calls.
7767
7768 2019-03-06  Pedro Alves  <palves@redhat.com>
7769
7770         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7771         (inf_has_multiple_threads): Return 'bool' and rewrite using
7772         inferior_info::threads().
7773
7774 2019-03-06  Pedro Alves  <palves@redhat.com>
7775
7776         * linux-fork.c: Include <list>.
7777         (fork_list): Now a std::list instance.
7778         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7779         (forks_exist_p, find_last_fork): Adjust.
7780         (new_fork): Delete.
7781         (one_fork_p): New.
7782         (add_fork): Adjust.
7783         (free_fork): Delete, folded into fork_info::~fork_info().
7784         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7785         Adjust.
7786         (init_fork_list): Delete.
7787         (linux_fork_killall, linux_fork_mourn_inferior)
7788         (linux_fork_detach, info_checkpoints_command): Adjust.
7789         (_initialize_linux_fork): No longer call init_fork_list.
7790
7791 2019-03-06  Pedro Alves  <palves@redhat.com>
7792
7793         * linux-fork.c (new_fork): New, split out of ...
7794         (add_fork): ... this.  Return void.  Move "first fork" special
7795         case from here, to ...
7796         (checkpoint_command): ... here.
7797         * linux-linux.h (add_fork): Return void.
7798
7799 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7800
7801         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7802
7803 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7804             Chris January  <chris.january@arm.com>
7805             David Lecomber  <david.lecomber@arm.com>
7806
7807         * f-exp.y: New token, UNOP_INTRINSIC.
7808         (exp): New pattern using UNOP_INTRINSIC token.
7809         (f77_keywords): Add 'abs' keyword.
7810         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7811         (value_from_host_double): New function.
7812         (evaluate_subexp_f): Support UNOP_ABS.
7813
7814 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7815
7816         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7817         types.
7818
7819 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7820
7821         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7822         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7823         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7824
7825 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7826
7827         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7828
7829 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7830             Chris January  <chris.january@arm.com>
7831
7832         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7833         * f-exp.y: Define 'KIND' token.
7834         (exp): New pattern for KIND expressions.
7835         (ptype): Handle types with a kind extension.
7836         (direct_abs_decl): Extend to spot kind extensions.
7837         (f77_keywords): Add 'kind' to the list.
7838         (push_kind_type): New function.
7839         (convert_to_kind_type): New function.
7840         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7841         * parse.c (operator_length_standard): Likewise.
7842         * parser-defs.h (enum type_pieces): Add tp_kind.
7843         * std-operator.def: Add UNOP_KIND.
7844
7845 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7846
7847         * f-exp.y (f_parse): Set yydebug.
7848
7849 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7850
7851         * f-lang.c (evaluate_subexp_f): New function.
7852         (exp_descriptor_f): New global.
7853         (f_language_defn): Use exp_descriptor_f instead of
7854         exp_descriptor_standard.
7855
7856 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7857
7858         * f-exp.y (struct token): Add comments.
7859         (dot_ops): Remove uppercase versions and the end marker.
7860         (f77_keywords): Likewise.
7861         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7862         entries in the dot_ops array are case insensitive, and use
7863         strncasecmp to compare strings.  Also some whitespace cleanup in
7864         this area.  Similar for the f77_keywords array, except entries in
7865         this list might be case sensitive.
7866
7867 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7868
7869         * f-exp.y (struct f77_boolean_val): Add comments.
7870         (boolean_values): Remove uppercase versions, and end marker.
7871         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7872         and use strncasecmp to achieve case insensitivity.  Additionally,
7873         perform whitespace cleanup around this code.
7874
7875 2019-03-06  Tom Tromey  <tromey@adacore.com>
7876
7877         * remote-sim.c (gdbsim_target_open): Use result of
7878         gdb_argv::release.
7879
7880 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7881         Dirk Schubert  <dirk.schubert@arm.com>
7882         Chris January  <chris.january@arm.com>
7883
7884         * eval.c (evaluate_subexp_standard): Call Fortran argument
7885         wrapping logic.
7886         * f-lang.c (struct value): A value which can be passed into a
7887         Fortran function call.
7888         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7889         where appropriate.
7890         (struct type): Value ready for a Fortran function call.
7891         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7892         is needed.
7893         * f-lang.h (fortran_argument_convert): Declaration.
7894         (fortran_preserve_arg_pointer): Declaration.
7895         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7896
7897 2019-03-05  Tom Tromey  <tromey@adacore.com>
7898
7899         * python/py-prettyprint.c (print_string_repr): Remove #if.
7900         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7901
7902 2019-03-05  Tom Tromey  <tromey@adacore.com>
7903
7904         * target.c (the_dummy_target): Move later.  Change type to
7905         "dummy_target".
7906         (initialize_targets): Don't initialize the_dummy_target.
7907
7908 2019-03-05  Tom Tromey  <tromey@adacore.com>
7909
7910         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7911         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7912
7913 2019-03-05  Tom Tromey  <tromey@adacore.com>
7914
7915         * windows-nat.c (windows_nat_target::attach)
7916         (windows_nat_target::detach): Don't call gdb_flush.
7917         * valprint.c (generic_val_print, val_print, val_print_string):
7918         Don't call gdb_flush.
7919         * utils.c (defaulted_query): Don't call gdb_flush.
7920         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7921         * target.c (target_announce_detach): Don't call gdb_flush.
7922         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7923         * remote.c (extended_remote_target::attach): Don't call
7924         gdb_flush.
7925         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7926         * printcmd.c (do_examine): Don't call gdb_flush.
7927         (info_display_command): Don't call gdb_flush.
7928         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7929         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7930         * memattr.c (info_mem_command): Don't call gdb_flush.
7931         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7932         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7933         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7934         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7935         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7936         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7937         (gnu_nat_target::detach): Don't call gdb_flush.
7938         * f-valprint.c (f_val_print): Don't call gdb_flush.
7939         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7940         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7941         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7942         gdb_flush.
7943         * c-valprint.c (c_val_print): Don't call gdb_flush.
7944         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7945
7946 2019-03-05  Tom Tromey  <tromey@adacore.com>
7947
7948         * varobj.c (update_dynamic_varobj_children): Update.
7949         (install_default_visualizer): Use reset, not release.
7950         * value.c (set_internalvar): Update.
7951         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7952         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7953         ATTRIBUTE_UNUSED_RESULT.
7954
7955 2019-03-05  Tom Tromey  <tromey@adacore.com>
7956
7957         * remote.c (class scoped_remote_fd) <release>: Add
7958         ATTRIBUTE_UNUSED_RESULT.
7959
7960 2019-03-05  Tom Tromey  <tromey@adacore.com>
7961
7962         * macroexp.c (struct macro_buffer) <release>: Add
7963         ATTRIBUTE_UNUSED_RESULT.
7964
7965 2019-03-05  Tom Tromey  <tromey@adacore.com>
7966
7967         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7968         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7969         ATTRIBUTE_UNUSED_RESULT.
7970
7971 2019-03-05  Tom Tromey  <tromey@adacore.com>
7972
7973         * common/scoped_fd.h (class scoped_fd) <release>: Add
7974         ATTRIBUTE_UNUSED_RESULT.
7975
7976 2019-03-05  Tom Tromey  <tromey@adacore.com>
7977
7978         * parser-defs.h (struct parser_state) <release>: Add
7979         ATTRIBUTE_UNUSED_RESULT.
7980
7981 2019-03-05  Tom Tromey  <tromey@adacore.com>
7982
7983         * utils.h (class gdb_argv) <release>: Add
7984         ATTRIBUTE_UNUSED_RESULT.
7985         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7986
7987 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7988
7989         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7990         for-loop range, to avoid compiler warnings.
7991
7992         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7993         avoid compiler warnings about unused variables.
7994
7995         * NEWS: Mention end of support for native debugging on MS-Windows
7996         before XP.
7997
7998         PR gdb/24292
7999         * common/netstuff.c:
8000         * gdbserver/gdbreplay.c
8001         * gdbserver/remote-utils.c:
8002         * ser-tcp.c:
8003         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8004         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8005         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8006         'getaddrinfo' and 'freeaddrinfo' were not available before
8007         Windows XP, and mingw.org's MinGW headers by default define
8008         _WIN32_WINNT to 0x500.
8009
8010 2019-03-01  Gary Benson <gbenson@redhat.com>
8011
8012         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8013
8014 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8015             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8016
8017         PR gdb/8527
8018         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8019         set_sigint_trap, clear_sigint_trap.
8020
8021 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8022
8023         * target.c (target_detach): Clear the regcache and the
8024         frame cache.
8025
8026 2019-02-27  Pedro Alves  <palves@redhat.com>
8027
8028         * utils.c (set_screen_size): When we cap the height/width sizes,
8029         tweak the corresponding command variable to show "unlimited":
8030
8031 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8032             Pedro Alves  <palves@redhat.com>
8033
8034         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8035         before calling rl_set_screen_size.
8036
8037 2019-02-27  Tom Tromey  <tromey@adacore.com>
8038
8039         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8040         define.
8041         * python/py-value.c: Remove Python 2.4 workaround.
8042         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8043         workaround.
8044         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8045         Python 2.4 workaround.
8046         * python/python-internal.h: Remove Python 2.4 comment.
8047         (Py_ssize_t): Don't define.
8048         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8049         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8050         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8051         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8052         * python/python.c (do_start_initialization): Remove Python 2.4
8053         workaround.
8054         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8055         (print_children): Remove Python 2.4 workaround.
8056         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8057         workaround.
8058         (CHARBUFFERPROC_NAME): Remove.
8059         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8060         Python 2.4 workaround.
8061
8062 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8063
8064         * NEWS: Note minimum Python version.
8065
8066 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8067
8068         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8069         code from these functions.  Remove corresponding ifdefs.  Use
8070         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8071         Remove gotos and target of gotos.
8072         (infpy_search_memory): Likewise.
8073
8074 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8075
8076         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8077         (hppa_gdbarch_init): Don't register deleted functions with
8078         gdbarch.
8079
8080 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8081
8082         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8083         (h8300_unwind_sp): Delete.
8084         (h8300_dummy_id): Delete.
8085         (h8300_gdbarch_init): Don't register deleted functions with
8086         gdbarch.
8087
8088 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8089
8090         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8091         (ft32_unwind_pc): Delete.
8092         (ft32_unwind_sp): Delete.
8093         (ft32_gdbarch_init): Don't register deleted functions with
8094         gdbarch.
8095
8096 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8097
8098         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8099         (frv_unwind_pc): Delete.
8100         (frv_unwind_sp): Delete.
8101         (frv_gdbarch_init): Don't register deleted functions with
8102         gdbarch.
8103
8104 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8105
8106         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8107         (riscv_unwind_pc): Delete.
8108         (riscv_unwind_sp): Delete.
8109         (riscv_gdbarch_init): Don't register deleted functions with
8110         gdbarch.
8111
8112 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8113
8114         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8115         (csky_unwind_pc): Delete.
8116         (csky_unwind_sp): Delete.
8117         (csky_gdbarch_init): Don't register deleted functions with
8118         gdbarch.
8119
8120 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8121
8122         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8123         (cris_unwind_pc): Delete.
8124         (cris_unwind_sp): Delete.
8125         (cris_gdbarch_init): Don't register deleted functions with
8126         gdbarch.
8127
8128 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8129
8130         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8131         (bfin_unwind_pc): Delete.
8132         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8133
8134 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8135
8136         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8137         (arm_unwind_pc): Delete.
8138         (arm_unwind_sp): Delete.
8139         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8140
8141 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8142
8143         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8144         (arc_unwind_pc): Delete.
8145         (arc_unwind_sp): Delete.
8146         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8147
8148 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8149
8150         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8151         (alpha_unwind_pc): Delete.
8152         (alpha_gdbarch_init): Don't register deleted functions with
8153         gdbarch.
8154
8155 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8156
8157         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8158         (aarch64_unwind_pc): Delete.
8159         (aarch64_unwind_sp): Delete.
8160         (aarch64_gdbarch_init): Don't register deleted functions with
8161         gdbarch.
8162
8163 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8164
8165         * gdbtypes.c (type_align): Don't consider static members when
8166         computing structure alignment.
8167
8168 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8169
8170         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8171         return 0 for other types.
8172         * arch-utils.c (default_type_align): Always return 0.
8173         * gdbarch.h: Regenerate.
8174         * gdbarch.sh (type_align): Extend comment.
8175         * gdbtypes.c (type_align): Add additional comments, always call
8176         gdbarch_type_align before applying the default rules.
8177         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8178         generic code will then apply a suitable default.
8179         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8180         types, return 0 for other types.
8181
8182 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8183
8184         * NEWS: Create a new section for the next release branch.
8185         Rename the section of the current branch, now that it has
8186         been cut.
8187
8188 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8189
8190         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8191         * version.in: Bump version to 8.3.50.DATE-git.
8192
8193 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8194
8195         * aix-thread.c (ptid_cmp): Remove unused variable.
8196         (get_signaled_thread): Likewise.
8197         (store_regs_user_thread): Likewise.
8198         (store_regs_kernel_thread): Likewise.
8199         (fetch_regs_kernel_thread): Remove shadowed variable.
8200
8201 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8202
8203         * features/riscv/32bit-cpu.xml: Add register numbers.
8204         * features/riscv/32bit-fpu.c: Regenerate.
8205         * features/riscv/32bit-fpu.xml: Add register numbers.
8206         * features/riscv/64bit-cpu.xml: Add register numbers.
8207         * features/riscv/64bit-fpu.c: Regenerate.
8208         * features/riscv/64bit-fpu.xml: Add register numbers.
8209
8210 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8211
8212         * NEWS: Mention two argument form of gdb.Value constructor.
8213         * python/py-value.c (convert_buffer_and_type_to_value): New
8214         function.
8215         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8216         Add support for handling an optional second argument.  Call
8217         convert_buffer_and_type_to_value as appropriate.
8218         * python/python-internal.h (Py_buffer_deleter): New struct.
8219         (Py_buffer_up): New typedef.
8220
8221 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8222
8223         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8224         instead of releasing ownership.
8225
8226 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8227
8228         * dwarf2read.c (open_and_init_dwp_file): Call
8229         elf_numsections instead of bfd_count_sections to initialize
8230         dwp_file->num_sections.
8231
8232 2019-02-25  Tom Tromey  <tromey@adacore.com>
8233
8234         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8235
8236 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8237
8238         * gcore.in: Add '--readnever' option when invoking GDB.
8239
8240 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8241
8242         * MAINTAINERS: Update my email address.
8243
8244 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8245
8246         * build-id.c (build_id_to_debug_bfd_1): New function.
8247         (build_id_to_debug_bfd): Look for separate debug file in
8248         sysroot.
8249
8250 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8251
8252         * gdbarch.sh: Update the copyright year range that is placed into
8253         generated files.
8254
8255 2019-02-22  Keith Seitz  <keiths@redhat.com>
8256
8257         PR symtab/23853
8258         * linespec.c (create_sals_line_offset): Search for the default
8259         symtab's filename instead of its fullname.
8260
8261 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8262
8263         * NEWS: Update style defaults.
8264
8265 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8266
8267         * main.c (captured_main_1): Disable styling in batch mode.
8268
8269 2019-02-20  Tom Tromey  <tom@tromey.com>
8270
8271         * symtab.c (symtab_symbol_info): Fix typos.
8272
8273 2019-02-20  Tom Tromey  <tromey@adacore.com>
8274
8275         * findcmd.c (_initialize_mem_search): Use upper case for
8276         metasyntactic variables.
8277
8278 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8279
8280         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8281         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8282
8283 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8284
8285         * top.h (source_file_name): Change to std::string.
8286         * top.c (source_file_name): Likewise.
8287         (command_line_input): Adjust.
8288         * cli/cli-script.c (script_from_file): Adjust.
8289
8290 2019-02-19  Tom Tromey  <tromey@adacore.com>
8291
8292         * ravenscar-thread.c
8293         (ravenscar_thread_target::update_thread_list): Don't call
8294         ada_build_task_list.
8295         * ada-lang.h (ada_build_task_list): Don't declare.
8296         * ada-tasks.c (struct ada_tasks_inferior_data)
8297         <task_list_valid_p>: Now bool.
8298         (read_known_tasks, ada_task_list_changed)
8299         (ada_tasks_invalidate_inferior_data): Update.
8300         (read_known_tasks_array): Return bool.
8301         (read_known_tasks_list): Likewise.
8302         (read_known_tasks): Return void.
8303         (ada_build_task_list): Now static.
8304
8305 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8306
8307         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8308         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8309
8310 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8311
8312         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8313         variant for ada_tasks_pspace_data_handle and
8314         ada_tasks_inferior_data_handle.
8315         (ada_tasks_pspace_data_cleanup): New function.
8316         (ada_tasks_inferior_data_cleanup): New function.
8317
8318 2019-02-17  Tom Tromey  <tom@tromey.com>
8319
8320         * macrotab.h (macro_source_fullname): Return a std::string.
8321         * macrotab.c (macro_include, check_for_redefinition)
8322         (macro_undef, macro_lookup_definition, foreach_macro)
8323         (foreach_macro_in_scope): Update.
8324         (macro_source_fullname): Return a std::string.
8325         * macrocmd.c (show_pp_source_pos): Update.
8326
8327 2019-02-17  Tom Tromey  <tom@tromey.com>
8328
8329         * macrocmd.c (show_pp_source_pos): Style the file names.
8330
8331 2019-02-17  Tom Tromey  <tom@tromey.com>
8332
8333         PR tui/24197:
8334         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8335
8336 2019-02-17  Tom Tromey  <tom@tromey.com>
8337
8338         * ada-lang.c (user_select_syms): Use filtered printing.
8339         * utils.c (wrap_style): New global.
8340         (desired_style): Remove.
8341         (emit_style_escape): Add stream parameter.
8342         (set_output_style, reset_terminal_style, prompt_for_continue):
8343         Update.
8344         (flush_wrap_buffer): Only flush gdb_stdout.
8345         (wrap_here): Set wrap_style.
8346         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8347         treat escape sequences as a character.  Change when wrap buffer is
8348         flushed.
8349         (fputs_styled): Do not set the output style when the default is
8350         requested.
8351         * ui-style.h (struct ui_file_style) <is_default>: New method.
8352         * source.c (print_source_lines_base): Emit escape sequences in one
8353         piece.
8354
8355 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8356
8357         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8358         integers and enumeration types.
8359
8360 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8361
8362         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8363         instead of lookup_symbol_in_language
8364         (do_exact_match): New function.
8365         (ada_get_symbol_name_matcher): Return do_exact_match when
8366         doing a verbatim match.
8367
8368 2019-02-15  Tom Tromey  <tromey@adacore.com>
8369
8370         * ravenscar-thread.c (ravenscar_thread_target::resume)
8371         (ravenscar_thread_target::wait): Special case wildcard requests.
8372
8373 2019-02-15  Tom Tromey  <tromey@adacore.com>
8374
8375         * ravenscar-thread.c (base_ptid): Remove.
8376         (struct ravenscar_thread_target) <close>: New method.
8377         <m_base_ptid>: New member.
8378         <update_inferior_ptid, active_task, task_is_currently_active,
8379         runtime_initialized>: Declare methods.
8380         <ravenscar_thread_target>: Add constructor.
8381         (ravenscar_thread_target::task_is_currently_active)
8382         (ravenscar_thread_target::update_inferior_ptid)
8383         (ravenscar_runtime_initialized): Rename.  Now methods.
8384         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8385         (ravenscar_thread_target::update_thread_list): Update.
8386         (ravenscar_thread_target::active_task): Now method.
8387         (ravenscar_thread_target::store_registers)
8388         (ravenscar_thread_target::prepare_to_store)
8389         (ravenscar_thread_target::prepare_to_store)
8390         (ravenscar_thread_target::mourn_inferior): Update.
8391         (ravenscar_inferior_created): Use "new" to create target.
8392         (ravenscar_thread_target::get_ada_task_ptid): Update.
8393         (_initialize_ravenscar): Don't initialize base_ptid.
8394         (ravenscar_ops): Remove global.
8395
8396 2019-02-15  Tom Tromey  <tromey@adacore.com>
8397
8398         * target.h (push_target): Declare new overload.
8399         * target.c (push_target): New overload, taking an rvalue reference.
8400         * remote.c (remote_target::open_1): Use push_target overload.
8401         * corelow.c (core_target_open): Use push_target overload.
8402
8403 2019-02-15  Tom Tromey  <tromey@adacore.com>
8404
8405         * ravenscar-thread.c (is_ravenscar_task)
8406         (ravenscar_task_is_currently_active): Return bool.
8407         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8408         (_initialize_ravenscar): Remove "(void)".
8409         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8410         Return bool.
8411
8412 2019-02-15  Tom Tromey  <tromey@adacore.com>
8413
8414         * ravenscar-thread.c (ravenscar_runtime_initializer)
8415         (has_ravenscar_runtime, get_running_thread_id)
8416         (ravenscar_thread_target::resume): Fix indentation.
8417
8418 2019-02-15  Tom Tromey  <tromey@adacore.com>
8419
8420         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8421         from ravenscar_arch_ops.
8422         (sparc_ravenscar_ops::fetch_registers)
8423         (sparc_ravenscar_ops::store_registers): Now methods.
8424         (sparc_ravenscar_prepare_to_store): Remove.
8425         (sparc_ravenscar_ops): Redefine.
8426         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8427         methods and destructor.  Remove members.
8428         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8429         (ravenscar_thread_target::store_registers)
8430         (ravenscar_thread_target::prepare_to_store): Update.
8431         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8432         Remove.
8433         (struct ppc_ravenscar_powerpc_ops): Derive from
8434         ravenscar_arch_ops.
8435         (ppc_ravenscar_powerpc_ops::fetch_registers)
8436         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8437         (ppc_ravenscar_powerpc_ops): Redefine.
8438         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8439         (ppc_ravenscar_e500_ops::fetch_registers)
8440         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8441         (ppc_ravenscar_e500_ops): Redefine.
8442         * aarch64-ravenscar-thread.c
8443         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8444         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8445         (aarch64_ravenscar_fetch_registers)
8446         (aarch64_ravenscar_store_registers): Now methods.
8447         (aarch64_ravenscar_ops): Redefine.
8448
8449 2019-02-15  Tom Tromey  <tromey@adacore.com>
8450
8451         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8452         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8453         (ravenscar_thread_target::stopped_by_watchpoint)
8454         (ravenscar_thread_target::stopped_data_address)
8455         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8456
8457 2019-02-15  Tom Tromey  <tromey@adacore.com>
8458
8459         * ravenscar-thread.c: Fix some typos.
8460
8461 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8462             Tom Tromey  <tromey@adacore.com>
8463
8464         * ada-lang.c (ada_exception_sal): Change addr_string to a
8465         std::string.
8466         (create_ada_exception_catchpoint): Update.
8467
8468 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8469             Tom Tromey  <tromey@adacore.com>
8470
8471         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8472         (bp_location_ops): Remove.
8473         (base_breakpoint_allocate_location): Update.
8474         (free_bp_location): Update.
8475         * ada-lang.c (class ada_catchpoint_location)
8476         <ada_catchpoint_location>: Remove ops parameter.
8477         (ada_catchpoint_location_dtor): Remove.
8478         (ada_catchpoint_location_ops): Remove.
8479         (allocate_location_exception): Update.
8480         * breakpoint.h (struct bp_location_ops): Remove.
8481         (class bp_location) <bp_location>: Remove bp_location_ops
8482         parameter.
8483         <~bp_location>: Add destructor.
8484         <ops>: Remove.
8485
8486 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8487             Pedro Alves  <palves@redhat.com>
8488
8489         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8490         'PATH_MAX'.
8491
8492 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8493             Samuel Thibault  <samuel.thibault@gnu.org>
8494             Thomas Schwinge  <thomas@codesourcery.com>
8495
8496         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8497         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8498
8499 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8500
8501         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8502         (check_empty): Use "const char *".
8503
8504         * gnu-nat.c (gnu_nat_target::detach): Instead of
8505         'detach_inferior (pid)' call
8506         'detach_inferior (find_inferior_pid (pid))'.
8507
8508         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8509         'nat/fork-inferior.o'.
8510         * gnu-nat.c: #include "nat/fork-inferior.h".
8511
8512         * gnu-nat.c (gnu_nat_target::detach): Instead of
8513         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8514         * gnu-nat.h: #include "inf-child.h".
8515         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8516         'i386_gnu_nat_target::fetch_registers'.
8517         (gnu_store_registers): Rename/move to
8518         'i386_gnu_nat_target::store_registers'.
8519
8520         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8521         * gnu-nat.h (mach_thread_info): New function.
8522         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8523
8524         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8525
8526 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8527
8528         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8529
8530 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8531
8532         * windows-nat.c (windows_add_thread): Add new parameter
8533         "main_thread_p" with default value set to false.  Update
8534         function documentation as well as all callers.
8535         (windows_delete_thread): Likewise.
8536         (fake_create_process): Update call to windows_add_thread.
8537         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8538         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8539         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8540         call to windows_delete_thread.
8541
8542 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8543
8544         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8545
8546 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8547
8548         * symfile.c (find_separate_debug_file): Use canonical path of
8549         sysroot with child_path instead of gdb_sysroot if it is valid.
8550
8551 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8552
8553         * symfile.c (find_separate_debug_file): Use child_path to
8554         determine if an object file is under a sysroot.
8555
8556 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8557
8558         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8559         unittests/child-path-selftests.c.
8560         * common/pathstuff.c (child_path): New function.
8561         * common/pathstuff.h (child_path): New prototype.
8562         * unittests/child-path-selftests.c: New file.
8563
8564 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8565
8566         * symfile.c (find_separate_debug_file): Look for separate debug
8567         files in debug directories under the sysroot.
8568
8569 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8570
8571         * symtab.h (struct minimal_symbol data_p): New const method.
8572         (struct minimal_symbol text_p): Likewise.
8573         * symtab.c (output_source_filename): Use file name style
8574         to print file name.
8575         (print_symbol_info): Likewise.
8576         (print_msymbol_info): Use address style to print addresses.
8577         Use function name style to print executable text symbols.
8578         (expand_symtab_containing_pc): Use data_p.
8579         (find_pc_sect_compunit_symtab): Likewise.
8580
8581 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8582
8583         * breakpoint.c (describe_other_breakpoints): Use address style
8584         to print addresses.
8585         (say_where): Likewise.
8586
8587 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8588
8589         * ada-typeprint.c (print_func_type): Print function name
8590         style to print function name.
8591         * c-typeprint.c (c_print_type_1): Likewise.
8592
8593 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8594
8595         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8596         for execve.
8597
8598 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8599
8600         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8601         type_stack.
8602
8603 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8604
8605         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8606         TYPE_CODE_REF types.
8607
8608 2019-02-08  Jim Wilson  <jimw@sifive.com>
8609
8610         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8611         (riscv_linux_fregset): New.
8612         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8613
8614 2019-02-07  Tom Tromey  <tom@tromey.com>
8615
8616         * thread.c (thread_cancel_execution_command): Update.
8617         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8618         methods.
8619         (struct thread_fsm_ops): Remove.
8620         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8621         (thread_fsm_should_stop, thread_fsm_return_value)
8622         (thread_fsm_set_finished, thread_fsm_finished_p)
8623         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8624         Don't declare.
8625         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8626         * infrun.c (clear_proceed_status_thread)
8627         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8628         (print_stop_event): Update.
8629         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8630         Add constructor.
8631         (step_command_fsm_ops): Remove.
8632         (new_step_command_fsm): Remove.
8633         (step_1): Update.
8634         (step_command_fsm::should_stop): Rename from
8635         step_command_fsm_should_stop.
8636         (step_command_fsm::clean_up): Rename from
8637         step_command_fsm_clean_up.
8638         (step_command_fsm::do_async_reply_reason): Rename from
8639         step_command_fsm_async_reply_reason.
8640         (struct until_next_fsm): Inherit from thread_fsm.  Add
8641         constructor.
8642         (until_next_fsm_ops): Remove.
8643         (new_until_next_fsm): Remove.
8644         (until_next_fsm::should_stop): Rename from
8645         until_next_fsm_should_stop.
8646         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8647         (until_next_fsm::do_async_reply_reason): Rename from
8648         until_next_fsm_async_reply_reason.
8649         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8650         constructor.  Change type of breakpoint.
8651         (finish_command_fsm_ops): Remove.
8652         (new_finish_command_fsm): Remove.
8653         (finish_command_fsm::should_stop): Rename from
8654         finish_command_fsm_should_stop.
8655         (finish_command_fsm::clean_up): Rename from
8656         finish_command_fsm_clean_up.
8657         (finish_command_fsm::return_value): Rename from
8658         finish_command_fsm_return_value.
8659         (finish_command_fsm::do_async_reply_reason): Rename from
8660         finish_command_fsm_async_reply_reason.
8661         (finish_command): Update.
8662         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8663         Add constructor.
8664         (call_thread_fsm_ops): Remove.
8665         (call_thread_fsm::call_thread_fsm): Rename from
8666         new_call_thread_fsm.
8667         (call_thread_fsm::should_stop): Rename from
8668         call_thread_fsm_should_stop.
8669         (call_thread_fsm::should_notify_stop): Rename from
8670         call_thread_fsm_should_notify_stop.
8671         (run_inferior_call, call_function_by_hand_dummy): Update.
8672         * cli/cli-interp.c (should_print_stop_to_console): Update.
8673         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8674         Add constructor.  Change type of location_breakpoint,
8675         caller_breakpoint.
8676         (until_break_fsm_ops): Remove.
8677         (new_until_break_fsm): Remove.
8678         (until_break_fsm::should_stop): Rename from
8679         until_break_fsm_should_stop.
8680         (until_break_fsm::clean_up): Rename from
8681         until_break_fsm_clean_up.
8682         (until_break_fsm::do_async_reply_reason): Rename from
8683         until_break_fsm_async_reply_reason.
8684         (until_break_command): Update.
8685         * thread-fsm.c: Remove.
8686         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8687
8688 2019-02-07  Tom Tromey  <tom@tromey.com>
8689
8690         * yy-remap.h: Add include guard.
8691         * xtensa-tdep.h: Add include guard.
8692         * xcoffread.h: Rename include guard.
8693         * varobj-iter.h: Add include guard.
8694         * tui/tui.h: Rename include guard.
8695         * tui/tui-winsource.h: Rename include guard.
8696         * tui/tui-wingeneral.h: Rename include guard.
8697         * tui/tui-windata.h: Rename include guard.
8698         * tui/tui-win.h: Rename include guard.
8699         * tui/tui-stack.h: Rename include guard.
8700         * tui/tui-source.h: Rename include guard.
8701         * tui/tui-regs.h: Rename include guard.
8702         * tui/tui-out.h: Rename include guard.
8703         * tui/tui-layout.h: Rename include guard.
8704         * tui/tui-io.h: Rename include guard.
8705         * tui/tui-hooks.h: Rename include guard.
8706         * tui/tui-file.h: Rename include guard.
8707         * tui/tui-disasm.h: Rename include guard.
8708         * tui/tui-data.h: Rename include guard.
8709         * tui/tui-command.h: Rename include guard.
8710         * tic6x-tdep.h: Add include guard.
8711         * target/waitstatus.h: Rename include guard.
8712         * target/wait.h: Rename include guard.
8713         * target/target.h: Rename include guard.
8714         * target/resume.h: Rename include guard.
8715         * target-float.h: Rename include guard.
8716         * stabsread.h: Add include guard.
8717         * rs6000-tdep.h: Add include guard.
8718         * riscv-fbsd-tdep.h: Add include guard.
8719         * regformats/regdef.h: Rename include guard.
8720         * record.h: Rename include guard.
8721         * python/python.h: Rename include guard.
8722         * python/python-internal.h: Rename include guard.
8723         * python/py-stopevent.h: Rename include guard.
8724         * python/py-ref.h: Rename include guard.
8725         * python/py-record.h: Rename include guard.
8726         * python/py-record-full.h: Rename include guard.
8727         * python/py-record-btrace.h: Rename include guard.
8728         * python/py-instruction.h: Rename include guard.
8729         * python/py-events.h: Rename include guard.
8730         * python/py-event.h: Rename include guard.
8731         * procfs.h: Add include guard.
8732         * proc-utils.h: Add include guard.
8733         * p-lang.h: Add include guard.
8734         * or1k-tdep.h: Rename include guard.
8735         * observable.h: Rename include guard.
8736         * nto-tdep.h: Rename include guard.
8737         * nat/x86-linux.h: Rename include guard.
8738         * nat/x86-linux-dregs.h: Rename include guard.
8739         * nat/x86-gcc-cpuid.h: Add include guard.
8740         * nat/x86-dregs.h: Rename include guard.
8741         * nat/x86-cpuid.h: Rename include guard.
8742         * nat/ppc-linux.h: Rename include guard.
8743         * nat/mips-linux-watch.h: Rename include guard.
8744         * nat/linux-waitpid.h: Rename include guard.
8745         * nat/linux-ptrace.h: Rename include guard.
8746         * nat/linux-procfs.h: Rename include guard.
8747         * nat/linux-osdata.h: Rename include guard.
8748         * nat/linux-nat.h: Rename include guard.
8749         * nat/linux-namespaces.h: Rename include guard.
8750         * nat/linux-btrace.h: Rename include guard.
8751         * nat/glibc_thread_db.h: Rename include guard.
8752         * nat/gdb_thread_db.h: Rename include guard.
8753         * nat/gdb_ptrace.h: Rename include guard.
8754         * nat/fork-inferior.h: Rename include guard.
8755         * nat/amd64-linux-siginfo.h: Rename include guard.
8756         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8757         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8758         * nat/aarch64-linux.h: Rename include guard.
8759         * nat/aarch64-linux-hw-point.h: Rename include guard.
8760         * mn10300-tdep.h: Add include guard.
8761         * mips-linux-tdep.h: Add include guard.
8762         * mi/mi-parse.h: Rename include guard.
8763         * mi/mi-out.h: Rename include guard.
8764         * mi/mi-main.h: Rename include guard.
8765         * mi/mi-interp.h: Rename include guard.
8766         * mi/mi-getopt.h: Rename include guard.
8767         * mi/mi-console.h: Rename include guard.
8768         * mi/mi-common.h: Rename include guard.
8769         * mi/mi-cmds.h: Rename include guard.
8770         * mi/mi-cmd-break.h: Rename include guard.
8771         * m2-lang.h: Add include guard.
8772         * location.h: Rename include guard.
8773         * linux-record.h: Rename include guard.
8774         * linux-nat.h: Add include guard.
8775         * linux-fork.h: Add include guard.
8776         * i386-darwin-tdep.h: Rename include guard.
8777         * hppa-linux-offsets.h: Add include guard.
8778         * guile/guile.h: Rename include guard.
8779         * guile/guile-internal.h: Rename include guard.
8780         * gnu-nat.h: Rename include guard.
8781         * gdb-stabs.h: Rename include guard.
8782         * frv-tdep.h: Add include guard.
8783         * f-lang.h: Add include guard.
8784         * event-loop.h: Add include guard.
8785         * darwin-nat.h: Rename include guard.
8786         * cp-abi.h: Rename include guard.
8787         * config/sparc/nm-sol2.h: Rename include guard.
8788         * config/nm-nto.h: Rename include guard.
8789         * config/nm-linux.h: Add include guard.
8790         * config/i386/nm-i386gnu.h: Rename include guard.
8791         * config/djgpp/nl_types.h: Rename include guard.
8792         * config/djgpp/langinfo.h: Rename include guard.
8793         * compile/gcc-cp-plugin.h: Add include guard.
8794         * compile/gcc-c-plugin.h: Add include guard.
8795         * compile/compile.h: Rename include guard.
8796         * compile/compile-object-run.h: Rename include guard.
8797         * compile/compile-object-load.h: Rename include guard.
8798         * compile/compile-internal.h: Rename include guard.
8799         * compile/compile-cplus.h: Rename include guard.
8800         * compile/compile-c.h: Rename include guard.
8801         * common/xml-utils.h: Rename include guard.
8802         * common/x86-xstate.h: Rename include guard.
8803         * common/version.h: Rename include guard.
8804         * common/vec.h: Rename include guard.
8805         * common/tdesc.h: Rename include guard.
8806         * common/selftest.h: Rename include guard.
8807         * common/scoped_restore.h: Rename include guard.
8808         * common/scoped_mmap.h: Rename include guard.
8809         * common/scoped_fd.h: Rename include guard.
8810         * common/safe-iterator.h: Rename include guard.
8811         * common/run-time-clock.h: Rename include guard.
8812         * common/refcounted-object.h: Rename include guard.
8813         * common/queue.h: Rename include guard.
8814         * common/ptid.h: Rename include guard.
8815         * common/print-utils.h: Rename include guard.
8816         * common/preprocessor.h: Rename include guard.
8817         * common/pathstuff.h: Rename include guard.
8818         * common/observable.h: Rename include guard.
8819         * common/netstuff.h: Rename include guard.
8820         * common/job-control.h: Rename include guard.
8821         * common/host-defs.h: Rename include guard.
8822         * common/gdb_wait.h: Rename include guard.
8823         * common/gdb_vecs.h: Rename include guard.
8824         * common/gdb_unlinker.h: Rename include guard.
8825         * common/gdb_unique_ptr.h: Rename include guard.
8826         * common/gdb_tilde_expand.h: Rename include guard.
8827         * common/gdb_sys_time.h: Rename include guard.
8828         * common/gdb_string_view.h: Rename include guard.
8829         * common/gdb_splay_tree.h: Rename include guard.
8830         * common/gdb_setjmp.h: Rename include guard.
8831         * common/gdb_ref_ptr.h: Rename include guard.
8832         * common/gdb_optional.h: Rename include guard.
8833         * common/gdb_locale.h: Rename include guard.
8834         * common/gdb_assert.h: Rename include guard.
8835         * common/filtered-iterator.h: Rename include guard.
8836         * common/filestuff.h: Rename include guard.
8837         * common/fileio.h: Rename include guard.
8838         * common/environ.h: Rename include guard.
8839         * common/common-utils.h: Rename include guard.
8840         * common/common-types.h: Rename include guard.
8841         * common/common-regcache.h: Rename include guard.
8842         * common/common-inferior.h: Rename include guard.
8843         * common/common-gdbthread.h: Rename include guard.
8844         * common/common-exceptions.h: Rename include guard.
8845         * common/common-defs.h: Rename include guard.
8846         * common/common-debug.h: Rename include guard.
8847         * common/cleanups.h: Rename include guard.
8848         * common/buffer.h: Rename include guard.
8849         * common/btrace-common.h: Rename include guard.
8850         * common/break-common.h: Rename include guard.
8851         * cli/cli-utils.h: Rename include guard.
8852         * cli/cli-style.h: Rename include guard.
8853         * cli/cli-setshow.h: Rename include guard.
8854         * cli/cli-script.h: Rename include guard.
8855         * cli/cli-interp.h: Rename include guard.
8856         * cli/cli-decode.h: Rename include guard.
8857         * cli/cli-cmds.h: Rename include guard.
8858         * charset-list.h: Add include guard.
8859         * buildsym-legacy.h: Rename include guard.
8860         * bfin-tdep.h: Add include guard.
8861         * ax.h: Rename include guard.
8862         * arm-linux-tdep.h: Add include guard.
8863         * arm-fbsd-tdep.h: Add include guard.
8864         * arch/xtensa.h: Rename include guard.
8865         * arch/tic6x.h: Add include guard.
8866         * arch/i386.h: Add include guard.
8867         * arch/arm.h: Rename include guard.
8868         * arch/arm-linux.h: Rename include guard.
8869         * arch/arm-get-next-pcs.h: Rename include guard.
8870         * arch/amd64.h: Add include guard.
8871         * arch/aarch64-insn.h: Rename include guard.
8872         * arch-utils.h: Rename include guard.
8873         * annotate.h: Add include guard.
8874         * amd64-darwin-tdep.h: Rename include guard.
8875         * aarch64-linux-tdep.h: Add include guard.
8876         * aarch64-fbsd-tdep.h: Add include guard.
8877         * aarch32-linux-nat.h: Add include guard.
8878
8879 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8880
8881         * macrotab.c (macro_define_internal): New function that
8882         factorizes macro_define_object_internal and macro_define_function
8883         code.
8884         (macro_define_object_internal): Use macro_define_internal.
8885         (macro_define_function): Likewise.
8886
8887 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8888
8889         * macrocmd.c (extract_identifier): Return
8890         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8891         callers.
8892
8893 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8894
8895         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8896
8897 2019-02-05  Tom Tromey  <tom@tromey.com>
8898
8899         * target.c (target_stack::unpush): Move assertion earlier.
8900
8901 2019-01-30  Tom Tromey  <tom@tromey.com>
8902
8903         PR python/23615:
8904         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8905         (gdbpy_parse_and_eval): Likewise.
8906         * python/python-internal.h (gdbpy_allow_threads): New class.
8907
8908 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8909
8910         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8911         (aarch64_fbsd_fpregmap): Move earlier.
8912         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8913         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8914         instead of individual calls to trad_frame_set_reg_addr.
8915         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8916         earlier.
8917         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8918         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8919         instead of individual calls to trad_frame_set_reg_addr.
8920
8921 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8922
8923         * CONTRIBUTE: Replace contribution list with wiki link.
8924
8925 2019-01-25  Tom Tromey  <tom@tromey.com>
8926
8927         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8928
8929 2019-01-25  Tom Tromey  <tom@tromey.com>
8930
8931         * xtensa-linux-nat.c: Fix common/ includes.
8932         * xml-support.h: Fix common/ includes.
8933         * xml-support.c: Fix common/ includes.
8934         * x86-linux-nat.c: Fix common/ includes.
8935         * windows-nat.c: Fix common/ includes.
8936         * varobj.h: Fix common/ includes.
8937         * varobj.c: Fix common/ includes.
8938         * value.c: Fix common/ includes.
8939         * valops.c: Fix common/ includes.
8940         * utils.c: Fix common/ includes.
8941         * unittests/xml-utils-selftests.c: Fix common/ includes.
8942         * unittests/utils-selftests.c: Fix common/ includes.
8943         * unittests/unpack-selftests.c: Fix common/ includes.
8944         * unittests/tracepoint-selftests.c: Fix common/ includes.
8945         * unittests/style-selftests.c: Fix common/ includes.
8946         * unittests/string_view-selftests.c: Fix common/ includes.
8947         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8948         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8949         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8950         * unittests/rsp-low-selftests.c: Fix common/ includes.
8951         * unittests/parse-connection-spec-selftests.c: Fix common/
8952         includes.
8953         * unittests/optional-selftests.c: Fix common/ includes.
8954         * unittests/offset-type-selftests.c: Fix common/ includes.
8955         * unittests/observable-selftests.c: Fix common/ includes.
8956         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8957         * unittests/memrange-selftests.c: Fix common/ includes.
8958         * unittests/memory-map-selftests.c: Fix common/ includes.
8959         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8960         * unittests/function-view-selftests.c: Fix common/ includes.
8961         * unittests/environ-selftests.c: Fix common/ includes.
8962         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8963         * unittests/common-utils-selftests.c: Fix common/ includes.
8964         * unittests/cli-utils-selftests.c: Fix common/ includes.
8965         * unittests/array-view-selftests.c: Fix common/ includes.
8966         * ui-file.c: Fix common/ includes.
8967         * tui/tui-io.c: Fix common/ includes.
8968         * tracepoint.h: Fix common/ includes.
8969         * tracepoint.c: Fix common/ includes.
8970         * tracefile-tfile.c: Fix common/ includes.
8971         * top.h: Fix common/ includes.
8972         * top.c: Fix common/ includes.
8973         * thread.c: Fix common/ includes.
8974         * target/waitstatus.h: Fix common/ includes.
8975         * target/waitstatus.c: Fix common/ includes.
8976         * target.h: Fix common/ includes.
8977         * target.c: Fix common/ includes.
8978         * target-memory.c: Fix common/ includes.
8979         * target-descriptions.c: Fix common/ includes.
8980         * symtab.h: Fix common/ includes.
8981         * symfile.c: Fix common/ includes.
8982         * stap-probe.c: Fix common/ includes.
8983         * spu-linux-nat.c: Fix common/ includes.
8984         * sparc-nat.c: Fix common/ includes.
8985         * source.c: Fix common/ includes.
8986         * solib.c: Fix common/ includes.
8987         * solib-target.c: Fix common/ includes.
8988         * ser-unix.c: Fix common/ includes.
8989         * ser-tcp.c: Fix common/ includes.
8990         * ser-pipe.c: Fix common/ includes.
8991         * ser-base.c: Fix common/ includes.
8992         * selftest-arch.c: Fix common/ includes.
8993         * s12z-tdep.c: Fix common/ includes.
8994         * rust-exp.y: Fix common/ includes.
8995         * rs6000-aix-tdep.c: Fix common/ includes.
8996         * riscv-tdep.c: Fix common/ includes.
8997         * remote.c: Fix common/ includes.
8998         * remote-notif.h: Fix common/ includes.
8999         * remote-fileio.h: Fix common/ includes.
9000         * remote-fileio.c: Fix common/ includes.
9001         * regcache.h: Fix common/ includes.
9002         * regcache.c: Fix common/ includes.
9003         * record-btrace.c: Fix common/ includes.
9004         * python/python.c: Fix common/ includes.
9005         * python/py-type.c: Fix common/ includes.
9006         * python/py-inferior.c: Fix common/ includes.
9007         * progspace.h: Fix common/ includes.
9008         * producer.c: Fix common/ includes.
9009         * procfs.c: Fix common/ includes.
9010         * proc-api.c: Fix common/ includes.
9011         * printcmd.c: Fix common/ includes.
9012         * ppc-linux-nat.c: Fix common/ includes.
9013         * parser-defs.h: Fix common/ includes.
9014         * osdata.c: Fix common/ includes.
9015         * obsd-nat.c: Fix common/ includes.
9016         * nat/x86-linux.c: Fix common/ includes.
9017         * nat/x86-linux-dregs.c: Fix common/ includes.
9018         * nat/x86-dregs.h: Fix common/ includes.
9019         * nat/x86-dregs.c: Fix common/ includes.
9020         * nat/ppc-linux.c: Fix common/ includes.
9021         * nat/mips-linux-watch.h: Fix common/ includes.
9022         * nat/mips-linux-watch.c: Fix common/ includes.
9023         * nat/linux-waitpid.c: Fix common/ includes.
9024         * nat/linux-ptrace.h: Fix common/ includes.
9025         * nat/linux-ptrace.c: Fix common/ includes.
9026         * nat/linux-procfs.c: Fix common/ includes.
9027         * nat/linux-personality.c: Fix common/ includes.
9028         * nat/linux-osdata.c: Fix common/ includes.
9029         * nat/linux-namespaces.c: Fix common/ includes.
9030         * nat/linux-btrace.h: Fix common/ includes.
9031         * nat/linux-btrace.c: Fix common/ includes.
9032         * nat/fork-inferior.c: Fix common/ includes.
9033         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9034         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9035         * nat/aarch64-linux.c: Fix common/ includes.
9036         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9037         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9038         * namespace.h: Fix common/ includes.
9039         * mips-linux-tdep.c: Fix common/ includes.
9040         * minsyms.c: Fix common/ includes.
9041         * mi/mi-parse.h: Fix common/ includes.
9042         * mi/mi-main.c: Fix common/ includes.
9043         * mi/mi-cmd-env.c: Fix common/ includes.
9044         * memrange.h: Fix common/ includes.
9045         * memattr.c: Fix common/ includes.
9046         * maint.h: Fix common/ includes.
9047         * maint.c: Fix common/ includes.
9048         * main.c: Fix common/ includes.
9049         * machoread.c: Fix common/ includes.
9050         * location.c: Fix common/ includes.
9051         * linux-thread-db.c: Fix common/ includes.
9052         * linux-nat.c: Fix common/ includes.
9053         * linux-fork.c: Fix common/ includes.
9054         * inline-frame.c: Fix common/ includes.
9055         * infrun.c: Fix common/ includes.
9056         * inflow.c: Fix common/ includes.
9057         * inferior.h: Fix common/ includes.
9058         * inferior.c: Fix common/ includes.
9059         * infcmd.c: Fix common/ includes.
9060         * inf-ptrace.c: Fix common/ includes.
9061         * inf-child.c: Fix common/ includes.
9062         * ia64-linux-nat.c: Fix common/ includes.
9063         * i387-tdep.c: Fix common/ includes.
9064         * i386-tdep.c: Fix common/ includes.
9065         * i386-linux-tdep.c: Fix common/ includes.
9066         * i386-linux-nat.c: Fix common/ includes.
9067         * i386-go32-tdep.c: Fix common/ includes.
9068         * i386-fbsd-tdep.c: Fix common/ includes.
9069         * i386-fbsd-nat.c: Fix common/ includes.
9070         * guile/scm-type.c: Fix common/ includes.
9071         * guile/guile.c: Fix common/ includes.
9072         * go32-nat.c: Fix common/ includes.
9073         * gnu-nat.c: Fix common/ includes.
9074         * gdbthread.h: Fix common/ includes.
9075         * gdbarch-selftests.c: Fix common/ includes.
9076         * gdb_usleep.c: Fix common/ includes.
9077         * gdb_select.h: Fix common/ includes.
9078         * gdb_bfd.c: Fix common/ includes.
9079         * gcore.c: Fix common/ includes.
9080         * fork-child.c: Fix common/ includes.
9081         * findvar.c: Fix common/ includes.
9082         * fbsd-nat.c: Fix common/ includes.
9083         * event-top.c: Fix common/ includes.
9084         * event-loop.c: Fix common/ includes.
9085         * dwarf2read.c: Fix common/ includes.
9086         * dwarf2loc.c: Fix common/ includes.
9087         * dwarf2-frame.c: Fix common/ includes.
9088         * dwarf-index-cache.c: Fix common/ includes.
9089         * dtrace-probe.c: Fix common/ includes.
9090         * disasm-selftests.c: Fix common/ includes.
9091         * defs.h: Fix common/ includes.
9092         * csky-tdep.c: Fix common/ includes.
9093         * cp-valprint.c: Fix common/ includes.
9094         * cp-support.h: Fix common/ includes.
9095         * cp-support.c: Fix common/ includes.
9096         * corelow.c: Fix common/ includes.
9097         * completer.h: Fix common/ includes.
9098         * completer.c: Fix common/ includes.
9099         * compile/compile.c: Fix common/ includes.
9100         * compile/compile-loc2c.c: Fix common/ includes.
9101         * compile/compile-cplus-types.c: Fix common/ includes.
9102         * compile/compile-cplus-symbols.c: Fix common/ includes.
9103         * command.h: Fix common/ includes.
9104         * cli/cli-dump.c: Fix common/ includes.
9105         * cli/cli-cmds.c: Fix common/ includes.
9106         * charset.c: Fix common/ includes.
9107         * build-id.c: Fix common/ includes.
9108         * btrace.h: Fix common/ includes.
9109         * btrace.c: Fix common/ includes.
9110         * breakpoint.h: Fix common/ includes.
9111         * breakpoint.c: Fix common/ includes.
9112         * ax.h:
9113         (enum agent_op): Fix common/ includes.
9114         * ax-general.c (struct aop_map): Fix common/ includes.
9115         * ax-gdb.c: Fix common/ includes.
9116         * auxv.c: Fix common/ includes.
9117         * auto-load.c: Fix common/ includes.
9118         * arm-tdep.c: Fix common/ includes.
9119         * arch/riscv.c: Fix common/ includes.
9120         * arch/ppc-linux-common.c: Fix common/ includes.
9121         * arch/i386.c: Fix common/ includes.
9122         * arch/arm.c: Fix common/ includes.
9123         * arch/arm-linux.c: Fix common/ includes.
9124         * arch/arm-get-next-pcs.c: Fix common/ includes.
9125         * arch/amd64.c: Fix common/ includes.
9126         * arch/aarch64.c: Fix common/ includes.
9127         * arch/aarch64-insn.c: Fix common/ includes.
9128         * arch-utils.c: Fix common/ includes.
9129         * amd64-windows-tdep.c: Fix common/ includes.
9130         * amd64-tdep.c: Fix common/ includes.
9131         * amd64-sol2-tdep.c: Fix common/ includes.
9132         * amd64-obsd-tdep.c: Fix common/ includes.
9133         * amd64-nbsd-tdep.c: Fix common/ includes.
9134         * amd64-linux-tdep.c: Fix common/ includes.
9135         * amd64-linux-nat.c: Fix common/ includes.
9136         * amd64-fbsd-tdep.c: Fix common/ includes.
9137         * amd64-fbsd-nat.c: Fix common/ includes.
9138         * amd64-dicos-tdep.c: Fix common/ includes.
9139         * amd64-darwin-tdep.c: Fix common/ includes.
9140         * agent.c: Fix common/ includes.
9141         * ada-lang.h: Fix common/ includes.
9142         * ada-lang.c: Fix common/ includes.
9143         * aarch64-tdep.c: Fix common/ includes.
9144
9145 2019-01-25  Tom Tromey  <tom@tromey.com>
9146
9147         * common/create-version.sh: Use common/version.h.
9148
9149 2019-01-24  Pedro Alves  <palves@redhat.com>
9150
9151         * infrun.c (signal_stop, signal_print, signal_program)
9152         (signal_catch, signal_pass): Now arrays instead of pointers.
9153         (update_signals_program_target, do_target_resume)
9154         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9155         * linux-nat.c (linux_nat_target::pass_signals)
9156         (linux_nat_target::create_inferior, linux_nat_target::attach):
9157         Adjust.
9158         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9159         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9160         * procfs.c (procfs_target::pass_signals): Adjust.
9161         * record-full.c (record_full_target::resume): Adjust.
9162         * remote.c (remote_target::pass_signals)
9163         (remote_target::program_signals): Adjust.
9164         * target-debug.h (target_debug_print_signals): Now takes a
9165         gdb::array_view as parameter.  Adjust.
9166         * target.h (target_ops) <pass_signals, program_signals>: Replace
9167         pointer and length parameters with gdb::array_view.
9168         (target_pass_signals, target_program_signals): Likewise.
9169         * target-delegates.c: Regenerate.
9170
9171 2019-01-24  Pedro Alves  <palves@redhat.com>
9172
9173         * common/forward-scope-exit.h
9174         (forward_scope_exit::forward_scope_exit): Pass arguments to
9175         m_bind_function directly, instead of creating a std::bind and
9176         copying that.
9177
9178 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9179
9180         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9181         for static members.
9182         (pass_in_v_vfp_candidate): Likewise.
9183
9184 2019-01-23  Tom Tromey  <tom@tromey.com>
9185             Pedro Alves  <palves@redhat.com>
9186
9187         * regcache.c (class regcache_invalidator): Remove.
9188         (regcache::raw_write): Use make_scope_exit.
9189
9190 2019-01-23  Tom Tromey  <tom@tromey.com>
9191
9192         * ui-out.h (class ui_out_emit_type): Update comment.
9193
9194 2019-01-23  Tom Tromey  <tom@tromey.com>
9195
9196         * infrun.c (fetch_inferior_event): Update comment.
9197
9198 2019-01-23  Tom Tromey  <tom@tromey.com>
9199             Pedro Alves  <palves@redhat.com>
9200
9201         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9202         parameter.
9203         (fetch_inferior_event): Use SCOPE_EXIT.
9204
9205
9206 2019-01-23  Tom Tromey  <tom@tromey.com>
9207             Pedro Alves  <palves@redhat.com>
9208
9209         * infrun.c (disable_thread_events): Delete.
9210         (stop_all_threads): Use SCOPE_EXIT.
9211
9212 2019-01-23  Tom Tromey  <tom@tromey.com>
9213             Pedro Alves  <palves@redhat.com>
9214
9215         * symfile.c: Include forward-scope-exit.h.
9216         (clear_symtab_users_cleanup): Replace forward declaration with
9217         a FORWARD_SCOPE_EXIT.
9218         (syms_from_objfile_1): Use the forward_scope_exit and
9219         gdb::optional instead of cleanup_function.
9220         (reread_symbols): Use the forward_scope_exit instead of
9221         cleanup_function.
9222         (clear_symtab_users_cleanup): Remove function.
9223
9224 2019-01-23  Tom Tromey  <tom@tromey.com>
9225             Pedro Alves  <palves@redhat.com>
9226
9227         * linux-nat.c: Include scope-exit.h.
9228         (cleanup_target_stop): Remove.
9229         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9230         SCOPE_EXIT.
9231
9232 2019-01-23  Tom Tromey  <tom@tromey.com>
9233             Pedro Alves  <palves@redhat.com>
9234
9235         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9236         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9237
9238 2019-01-23  Tom Tromey  <tom@tromey.com>
9239             Andrew Burgess  <andrew.burgess@embecosm.com>
9240             Pedro Alves  <palves@redhat.com>
9241
9242         * infrun.c (fetch_inferior_event): Use scope_exit.
9243         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9244         * top.c (execute_command): Use scope_exit.
9245         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9246         * utils.c (do_bpstat_clear_actions_cleanup)
9247         (make_bpstat_clear_actions_cleanup): Remove.
9248
9249 2019-01-23  Tom Tromey  <tom@tromey.com>
9250             Pedro Alves  <palves@redhat.com>
9251
9252         * infrun.c: Include "common/scope-exit.h"
9253         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9254         (wait_for_inferior): Use SCOPE_EXIT.
9255         (fetch_inferior_event): Use scope_exit.
9256
9257 2019-01-23  Tom Tromey  <tom@tromey.com>
9258             Pedro Alves  <palves@redhat.com>
9259
9260         * breakpoint.c (create_breakpoint): Remove cleanup.
9261
9262 2019-01-23  Tom Tromey  <tom@tromey.com>
9263             Andrew Burgess  <andrew.burgess@embecosm.com>
9264             Pedro Alves  <palves@redhat.com>
9265
9266 2019-01-23  Pedro Alves  <palves@redhat.com>
9267
9268         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9269
9270 2019-01-23  Pedro Alves  <palves@redhat.com>
9271             Andrew Burgess  <andrew.burgess@embecosm.com>
9272
9273         * gdbthread.h: Include "common/forward-scope-exit.h".
9274         (scoped_finish_thread_state): Redefine custom class in terms of
9275         forward_scope_exit.
9276
9277 2019-01-23  Pedro Alves  <palves@redhat.com>
9278             Andrew Burgess  <andrew.burgess@embecosm.com>
9279
9280         * common/forward-scope-exit.h: New file.
9281
9282 2019-01-23  Pedro Alves  <palves@redhat.com>
9283             Andrew Burgess  <andrew.burgess@embecosm.com>
9284             Tom Tromey  <tom@tromey.com>
9285
9286         * common/scope-exit.h: New file.
9287
9288 2019-01-23  Pedro Alves  <palves@redhat.com>
9289
9290         * common/preprocessor.h (ESC): Rename to ...
9291         (ESC_PARENS): ... this.
9292         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9293         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9294
9295 2019-01-23  Tom Tromey  <tom@tromey.com>
9296
9297         * language.h (class scoped_switch_to_sym_language_if_auto):
9298         Initialize m_lang in both cases.
9299
9300 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9301
9302         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9303         with XCNEW.
9304
9305 2019-01-22  Tom Tromey  <tom@tromey.com>
9306
9307         * corelow.c: Do not include sys/file.h.
9308
9309 2019-01-22  Tom Tromey  <tom@tromey.com>
9310
9311         * tui/tui-wingeneral.h: Include gdb_curses.h.
9312
9313 2019-01-22  Tom Tromey  <tom@tromey.com>
9314
9315         * source-cache.h (class source_cache) <get_source_lines,
9316         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9317
9318 2019-01-22  Tom Tromey  <tom@tromey.com>
9319
9320         * remote-fileio.h (struct remote_target): Declare.
9321
9322 2019-01-22  Tom Tromey  <tom@tromey.com>
9323
9324         * python/py-arch.c: Do not include py-ref.h.
9325         * python/py-bpevent.c: Do not include py-ref.h.
9326         * python/py-cmd.c: Do not include py-ref.h.
9327         * python/py-continueevent.c: Do not include py-ref.h.
9328         * python/py-event.h: Do not include py-ref.h.
9329         * python/py-evtregistry.c: Do not include py-ref.h.
9330         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9331         * python/py-frame.c: Do not include py-ref.h.
9332         * python/py-framefilter.c: Do not include py-ref.h.
9333         * python/py-function.c: Do not include py-ref.h.
9334         * python/py-infevents.c: Do not include py-ref.h.
9335         * python/py-linetable.c: Do not include py-ref.h.
9336         * python/py-objfile.c: Do not include py-ref.h.
9337         * python/py-param.c: Do not include py-ref.h.
9338         * python/py-prettyprint.c: Do not include py-ref.h.
9339         * python/py-progspace.c: Do not include py-ref.h.
9340         * python/py-symbol.c: Do not include py-ref.h.
9341         * python/py-symtab.c: Do not include py-ref.h.
9342         * python/py-type.c: Do not include py-ref.h.
9343         * python/py-unwind.c: Do not include py-ref.h.
9344         * python/py-utils.c: Do not include py-ref.h.
9345         * python/py-value.c: Do not include py-ref.h.
9346         * python/py-varobj.c: Do not include py-ref.h.
9347         * python/py-xmethods.c: Do not include py-ref.h.
9348         * python/python.c: Do not include py-ref.h.
9349         * varobj.c: Do not include py-ref.h.
9350
9351 2019-01-22  Tom Tromey  <tom@tromey.com>
9352
9353         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9354         keyword for bcache.
9355
9356 2019-01-22  Tom Tromey  <tom@tromey.com>
9357
9358         * compile/compile-cplus-types.c: Remove a comment by #include.
9359
9360 2019-01-22  Tom Tromey  <tom@tromey.com>
9361
9362         * compile/gcc-c-plugin.h: Include compile-internal.h.
9363
9364 2019-01-22  Tom Tromey  <tom@tromey.com>
9365
9366         * stabsread.c (EXTERN): Do not define.
9367         (symnum, next_symbol_text_func, processing_gcc_compilation)
9368         (within_function, global_sym_chain, global_stabs)
9369         (previous_stab_code, this_object_header_files)
9370         (n_this_object_header_files)
9371         (n_allocated_this_object_header_files): Define.
9372         * stabsread.h (EXTERN): Never define.  Use "extern".
9373
9374 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9375
9376         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9377         history_value.
9378
9379 2019-01-21  Tom Tromey  <tom@tromey.com>
9380
9381         * ui-out.c: Fix includes.
9382         * tui/tui-source.c: Fix includes.
9383         * target.c: Fix includes.
9384         * remote.c: Fix includes.
9385         * regcache.c: Fix includes.
9386         * python/py-block.c: Fix includes.
9387         * printcmd.c: Fix includes.
9388         * or1k-tdep.c: Fix includes.
9389         * mi/mi-main.c: Fix includes.
9390         * m32r-tdep.c: Fix includes.
9391         * csky-tdep.c: Fix includes.
9392         * compile/compile-cplus-types.c: Fix includes.
9393         * cli/cli-interp.c: Fix includes.
9394
9395 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9396
9397         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9398         for padding.
9399
9400 2019-01-16  Tom Tromey  <tom@tromey.com>
9401
9402         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9403         earlier.
9404         (struct objfile) <msymbols_range>: Move from top level.
9405         <msymbols>: New method.
9406         (class objfile_msymbols): Remove.
9407         * symtab.c (default_collect_symbol_completion_matches_break_on):
9408         Update.
9409         * symmisc.c (dump_msymbols): Update.
9410         * stabsread.c (scan_file_globals): Update.
9411         * objc-lang.c (info_selectors_command, info_classes_command)
9412         (find_methods): Update.
9413         * minsyms.c (find_solib_trampoline_target): Update.
9414         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9415         * coffread.c (coff_symfile_read): Update.
9416         * ada-lang.c (ada_lookup_simple_minsym)
9417         (ada_collect_symbol_completion_matches): Update.
9418
9419 2019-01-16  Tom Tromey  <tom@tromey.com>
9420
9421         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9422         type.  Remove no-argument constructor.
9423         <iterator::operator++>: Simplify.
9424         <begin>: Update.
9425         <end>: Use minimal_symbol_count.
9426
9427 2019-01-16  Tom Tromey  <tom@tromey.com>
9428
9429         * objfiles.h (struct objfile) <psymtabs>: New method.
9430         (class objfile_psymtabs): Remove.
9431         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9432         typedef.
9433         <range>: New method.
9434         (require_partial_symbols): Change return type.
9435         * psymtab.c (require_partial_symbols)
9436         (psym_expand_symtabs_matching): Update.
9437         * mdebugread.c (parse_partial_symbols): Update.
9438         * dbxread.c (dbx_end_psymtab): Update.
9439
9440 2019-01-15  Tom Tromey  <tom@tromey.com>
9441
9442         * symtab.c (lookup_objfile_from_block)
9443         (lookup_symbol_in_objfile_symtabs)
9444         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9445         (find_line_symtab, info_sources_command)
9446         (default_collect_symbol_completion_matches_break_on)
9447         (make_source_files_completion_list): Update.
9448         * symmisc.c (print_objfile_statistics, dump_objfile)
9449         (maintenance_print_symbols, maintenance_info_symtabs)
9450         (maintenance_check_symtabs, maintenance_info_line_tables):
9451         Update.
9452         * source.c (select_source_symtab)
9453         (forget_cached_source_info_for_objfile): Update.
9454         * objfiles.h (class objfile_compunits): Remove.
9455         (struct objfile) <compunits_range>: New typedef.
9456         (compunits): New method.
9457         * objfiles.c (objfile_relocate1): Update.
9458         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9459         * maint.c (count_symtabs_and_blocks): Update.
9460         * linespec.c (iterate_over_all_matching_symtabs): Update.
9461         * cp-support.c (add_symbol_overload_list_qualified): Update.
9462         * coffread.c (coff_symtab_read): Update.
9463         * ada-lang.c (add_nonlocal_symbols)
9464         (ada_collect_symbol_completion_matches)
9465         (ada_add_global_exceptions): Update.
9466
9467 2019-01-15  Tom Tromey  <tom@tromey.com>
9468
9469         * progspace.h (program_space) <objfiles_safe_range>: New
9470         typedef.
9471         <objfiles_safe>: New method.
9472         * objfiles.h (class all_objfiles_safe): Remove.
9473         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9474         * jit.c (jit_inferior_exit_hook): Update.
9475
9476 2019-01-17  Tom Tromey  <tom@tromey.com>
9477
9478         * progspace.h (program_space) <objfiles_range>: New typedef.
9479         <objfiles>: New method.
9480         <objfiles_head>: Rename from objfiles.
9481         (object_files): Update.
9482         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9483         * guile/scm-pretty-print.c
9484         (ppscm_find_pretty_printer_from_objfiles): Update.
9485         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9486         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9487         Update.
9488         * python/py-progspace.c (pspy_get_objfiles): Update.
9489         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9490         Update.
9491         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9492         (objfpy_lookup_objfile_by_build_id): Update.
9493         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9494         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9495         Update.
9496         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9497         (expand_symtab_containing_pc, lookup_objfile_from_block)
9498         (lookup_static_symbol, basic_lookup_transparent_type)
9499         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9500         (find_line_symtab, info_sources_command)
9501         (default_collect_symbol_completion_matches_break_on)
9502         (make_source_files_completion_list, find_main_name): Update.
9503         * symmisc.c (print_symbol_bcache_statistics)
9504         (print_objfile_statistics, maintenance_print_symbols)
9505         (maintenance_print_msymbols, maintenance_print_objfiles)
9506         (maintenance_info_symtabs, maintenance_check_symtabs)
9507         (maintenance_expand_symtabs, maintenance_info_line_tables):
9508         Update.
9509         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9510         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9511         (map_overlay_command, unmap_overlay_command)
9512         (simple_overlay_update, expand_symtabs_matching)
9513         (map_symbol_filenames): Update.
9514         * symfile-debug.c (set_debug_symfile): Update.
9515         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9516         Update.
9517         * source.c (select_source_symtab, forget_cached_source_info):
9518         Update.
9519         * solib.c (solib_read_symbols): Update.
9520         * solib-spu.c (append_ocl_sos): Update.
9521         * psymtab.c (maintenance_print_psymbols)
9522         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9523         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9524         * printcmd.c (info_symbol_command): Update.
9525         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9526         Update.
9527         * objfiles.h (class all_objfiles): Remove.
9528         * objfiles.c (have_partial_symbols, have_full_symbols)
9529         (have_minimal_symbols, qsort_cmp, update_section_map)
9530         (shared_objfile_contains_address_p)
9531         (default_iterate_over_objfiles_in_search_order): Update.
9532         * objc-lang.c (info_selectors_command, info_classes_command)
9533         (find_methods): Update.
9534         * minsyms.c (find_solib_trampoline_target): Update.
9535         * maint.c (maintenance_info_sections)
9536         (maintenance_translate_address, count_symtabs_and_blocks):
9537         Update.
9538         * main.c (captured_main_1): Update.
9539         * linux-thread-db.c (try_thread_db_load_from_pdir)
9540         (has_libpthread): Update.
9541         * linespec.c (iterate_over_all_matching_symtabs)
9542         (search_minsyms_for_name): Update.
9543         * jit.c (jit_find_objf_with_entry_addr): Update.
9544         * hppa-tdep.c (find_unwind_entry)
9545         (hppa_lookup_stub_minimal_symbol): Update.
9546         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9547         Update.
9548         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9549         (elf_gnu_ifunc_resolve_by_got): Update.
9550         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9551         * dwarf-index-write.c (save_gdb_index_command): Update.
9552         * cp-support.c (add_symbol_overload_list_qualified): Update.
9553         * breakpoint.c (create_overlay_event_breakpoint)
9554         (create_longjmp_master_breakpoint)
9555         (create_std_terminate_master_breakpoint)
9556         (create_exception_master_breakpoint): Update.
9557         * blockframe.c (find_pc_partial_function): Update.
9558         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9559         (ada_collect_symbol_completion_matches)
9560         (ada_add_global_exceptions): Update.
9561
9562 2019-01-17  Tom Tromey  <tom@tromey.com>
9563
9564         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9565         declare VEC.
9566         (solib_target_parse_libraries): Change return type.
9567         (library_list_start_segment, library_list_start_section)
9568         (library_list_end_library, library_list_start_library); Update.
9569         (solib_target_free_library_list): Remove.
9570         (solib_target_parse_libraries): Remove cleanup.  Change return
9571         type.
9572         (solib_target_current_sos): Update.
9573
9574 2019-01-17  Tom Tromey  <tromey@bapiya>
9575
9576         * valprint.c: Replace "the the" with "the".
9577         * symtab.c: Replace "the the" with "the".
9578         * solib.c: Replace "the the" with "the".
9579         * solib-dsbt.c: Replace "the the" with "the".
9580         * linespec.c: Replace "the the" with "the".
9581         * dwarf2loc.h: Replace "the the" with "the".
9582         * amd64-windows-tdep.c: Replace "the the" with "the".
9583         * aarch64-tdep.c: Replace "the the" with "the".
9584
9585 2019-01-16  Keith Seitz  <keiths@redhat.com>
9586
9587         PR gdb/23773
9588         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9589         <builder>: Rename to ..
9590         <m_builder>: ... this and make private.
9591         (dwarf2_cu::get_builder): New method.  Change all users of
9592         `builder' to use this method.
9593         (dwarf2_start_symtab): Move to ...
9594         (dwarf2_cu::start_symtab): ... here.  Update all callers
9595         (setup_type_unit_groups): Move to ...
9596         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9597         callers.
9598         (dwarf2_cu::reset_builder): New method.
9599         (process_full_compunit, process_full_type_unit): Use
9600         dwarf2_cu::reset_builder.
9601         (follow_die_offset): Record the ancestor CU if it is different
9602         from the followed DIE's CU.
9603         (follow_die_sig_1): Likewise.
9604
9605 2019-01-15  Tom Tromey  <tom@tromey.com>
9606
9607         * remote.c (class remote_state) <buf>: Now a char_vector.
9608         <buf_size>: Remove.
9609         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9610         parameter.
9611         (remote_target::getpkt_or_notif_sane_1)
9612         (remote_target::getpkt_sane)
9613         (remote_target::getpkt_or_notif_sane): Likewise.
9614         (class remote_target) <putpkt>: New overload.
9615         (remote_target::read_frame): Change type of "buf_p".  Remove
9616         sizeof_p parameter.
9617         (packet_ok): New overload.
9618         (packet_check_result): New overload.
9619         Update all uses.
9620
9621 2019-01-14  Tom Tromey  <tom@tromey.com>
9622
9623         * remote-notif.c (handle_notification, remote_notif_ack)
9624         (remote_notif_parse): Make "buf" const.
9625         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9626         const.
9627         (remote_notif_parse, remote_notif_ack, handle_notification):
9628         Likewise.
9629         * remote.c (remote_notif_stop_parse): Make "buf" const.
9630         (remote_target::remote_parse_stop_reply): Make "buf" const.
9631         (remote_notif_stop_ack): Make "buf" const.
9632
9633 2019-01-14  Tom Tromey  <tom@tromey.com>
9634
9635         * remote.c (remote_console_output): Make parameter const.
9636
9637 2019-01-14  Tom Tromey  <tom@tromey.com>
9638
9639         * target-debug.h (target_debug_print_signals): Constify.
9640         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9641         * procfs.c (procfs_target::pass_signals): Update.
9642         * linux-nat.c (linux_nat_target::pass_signals): Update.
9643         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9644         * target-delegates.c: Rebuild.
9645         * remote.c (remote_target::program_signals): Update.
9646         (remote_target::pass_signals): Update.
9647         * target.c (target_pass_signals): Constify argument.
9648         (target_program_signals): Likewise.
9649         * target.h (struct target_ops) <pass_signals, program_signals>:
9650         Constify argument.
9651         (target_pass_signals, target_program_signals): Constify argument.
9652
9653 2019-01-14  Tom Tromey  <tom@tromey.com>
9654
9655         PR tui/28819:
9656         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9657
9658 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9659
9660         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9661         field.
9662         * rs6000-tdep.c: Include reggroups.h.
9663         (IS_V_ALIAS_PSEUDOREG): Define.
9664         (rs6000_register_name): Return names for the "vX" aliases.
9665         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9666         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9667         aliases.  Call default_register_reggroup_p for all other
9668         pseudo-registers.
9669         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9670         New functions.
9671         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9672         Handle "vX" aliases.
9673         (v_alias_pseudo_register_collect): New function.
9674         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9675         (rs6000_gdbarch_init): Initialize "vX" aliases as
9676         pseudo-registers.  Restore registration of
9677         rs6000_pseudo_register_reggroup_p with
9678         set_tdesc_pseudo_register_reggroup_p.
9679
9680 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9681
9682         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9683         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9684         set_gdbarch_num_pseudo_regs.
9685
9686 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9687
9688         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9689         Remove arg prefixname, add do_set and do_show.
9690         Add member functions set_list and show_list.
9691         * cli/cli-style.c (class cli_style_option): Update accordingly.
9692         (style_set_list): Move to file scope.
9693         (style_show_list): Likewise.
9694         (set_style): Call help_list.
9695         (show_style): Call cmd_show_list.
9696         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9697         Update to use the new macro.
9698
9699 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9700
9701         * ada-lang.c (_initialize_ada_language): Expand the help text
9702         for the "catch exception" command.
9703
9704 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9705
9706         * symtab.c (matching_obj_sections): Initialize obj,
9707         declare it closer to its usage.
9708
9709 2019-01-10  Tom Tromey  <tom@tromey.com>
9710
9711         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9712         (basic_inf_threads_range): Remove.
9713         (inf_threads_range, inf_non_exited_threads_range)
9714         (safe_inf_threads_range): Use next_adapter.
9715
9716 2019-01-10  Keith Seitz  <keiths@redhat.com>
9717
9718         PR gdb/23712
9719         PR symtab/23010
9720         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9721         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9722
9723 2019-01-10  Keith Seitz  <keiths@redhat.com>
9724
9725         PR gdb/23712
9726         PR symtab/23010
9727         * dictionary.c (pending_to_vector): Remove.
9728         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9729         Remove _1 suffix, replacing functions of the same name.  Update
9730         all callers.
9731         (dict_create_hashed, dict_create_hashed_expandable)
9732         (dict_create_linear, dict_create_linear_expandable, dict_free)
9733         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9734         Make functions static.
9735
9736 2019-01-10  Keith Seitz  <keiths@redhat.com>
9737
9738         PR gdb/23712
9739         PR symtab/23010
9740         * dictionary.h (struct dictionary): Replace declaration with
9741         multidictionary.
9742         (dict_create_hashed, dict_create_hashed_expandable)
9743         (dict_create_linear, dict_create_linear_expandable)
9744         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9745         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9746         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9747         taking multidictionary argument.
9748         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9749         * block.h (struct block) <dict>: Change to multidictionary
9750         and rename `multidict'.
9751         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9752         symmisc.c: Update all dictionary references to multidictionary.
9753
9754 2019-01-10  Keith Seitz  <keiths@redhat.com>
9755
9756         PR gdb/23712
9757         PR symtab/23010
9758         * dictionary.c: Include unordered_map.
9759         (pending_to_vector): New function.
9760         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9761         Rewrite the non-"_1" functions to take vector instead
9762         of linked list.
9763         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9764         "new" _1 versions of the same name.
9765         (multidictionary): Define.
9766         (std::hash<enum language): New definition.
9767         (collate_pending_symbols_by_language, mdict_create_hashed)
9768         (mdict_create_hashed_expandable, mdict_create_linear)
9769         (mdict_create_linear_expandable, mdict_free)
9770         (find_language_dictionary, create_new_language_dictionary)
9771         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9772         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9773         (mdict_size, mdict_empty): New functions.
9774         * dictionary.h (mdict_iterator): Define.
9775
9776 2019-01-10  Pedro Alves  <palves@redhat.com>
9777
9778         * breakpoint.c (read_uploaded_action)
9779         (create_tracepoint_from_upload): Adjust to use
9780         gdb::unique_xmalloc_ptr.
9781         * ctf.c (ctf_write_uploaded_tp):
9782         (SET_ARRAY_FIELD): Use emplace_back.
9783         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9784         * tracefile-tfile.c (tfile_write_uploaded_tp):
9785         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9786         gdb::unique_xmalloc_ptr.
9787         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9788         at_string, cond_string, cmd_strings>: Replace char pointers
9789         with gdb::unique_xmalloc_ptr.
9790
9791 2019-01-10  Pedro Alves  <palves@redhat.com>
9792
9793         * solib-target.c (library_list_start_library): Don't xstrdup name.
9794
9795 2019-01-10  Pedro Alves  <palves@redhat.com>
9796
9797         * mdebugread.c (parse_partial_symbols): Use
9798         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9799
9800 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9801
9802         * linux-fork.c (scoped_switch_fork_info)
9803         <~scoped_switch_fork_info>: Fix incorrect variable name.
9804
9805 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9806
9807         * linux-fork.c (scoped_switch_fork_info)
9808         <scoped_switch_fork_info>: Make explicit.
9809         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9810
9811 2019-01-10  Tom Tromey  <tom@tromey.com>
9812
9813         * objfiles.h (objfile::reset_psymtabs): Update.
9814         * objfiles.c (objfile::objfile): Update.
9815         * psymtab.h (psymtab_storage::obstack): Update.
9816         (psymtab_storage::m_obstack): Use gdb::optional.
9817         (class psymtab_storage): Update comment.  Remove objfile
9818         parameter.
9819         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9820
9821 2019-01-10  Tom Tromey  <tom@tromey.com>
9822
9823         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9824         <free_psymtabs>: Now private.
9825         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9826         (allocate_psymtab): Use new method.
9827
9828 2019-01-10  Tom Tromey  <tom@tromey.com>
9829
9830         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9831         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9832         * mdebugread.c (parse_partial_symbols): Use
9833         allocate_dependencies.
9834         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9835         allocate_dependencies.
9836         (process_psymtab_comp_unit_reader)
9837         (build_type_psymtab_dependencies): Likewise.
9838         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9839
9840 2019-01-10  Tom Tromey  <tom@tromey.com>
9841
9842         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9843         PSYMBOL_SET_LANGUAGE.
9844         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9845
9846 2019-01-10  Tom Tromey  <tom@tromey.com>
9847
9848         * psymtab.h (psymtab_storage::obstack): New method.
9849         <m_obstack>: Rename from obstack; now private.
9850         * psymtab.c (psymtab_storage): Update.
9851         * dwarf2read.c (create_addrmap_from_index)
9852         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9853         Update.
9854
9855 2019-01-10  Tom Tromey  <tom@tromey.com>
9856
9857         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9858         * objfiles.h (objfile::reset_psymtabs): New method.
9859
9860 2019-01-10  Tom Tromey  <tom@tromey.com>
9861
9862         * symmisc.c (print_symbol_bcache_statistics): Update.
9863         (print_objfile_statistics): Update.
9864         * symfile.c (reread_symbols): Update.
9865         * psymtab.h (class psymtab_storage): New.
9866         * psymtab.c (psymtab_storage): New constructor.
9867         (~psymtab_storage): New destructor.
9868         (require_partial_symbols): Update.
9869         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9870         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9871         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9872         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9873         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9874         (start_psymtab_common, end_psymtab_common)
9875         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9876         (allocate_psymtab): Update.
9877         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9878         Update.
9879         (dump_psymtab_addrmap, maintenance_print_psymbols)
9880         (maintenance_check_psymtabs): Update.
9881         (class objfile_psymtabs): Move to objfiles.h.
9882         * psympriv.h (discard_psymtab): Now inline.
9883         (psymtab_discarder::psymtab_discarder): Update.
9884         (psymtab_discarder::~psymtab_discarder): Update.
9885         (ALL_OBJFILE_PSYMTABS): Rewrite.
9886         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9887         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9888         Remove fields.
9889         <partial_symtabs>: New field.
9890         (class objfile_psymtabs): Move from psymtab.h.  Update.
9891         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9892         psymbol_cache.
9893         (objfile::~objfile): Don't destroy psymbol_cache.
9894         * mdebugread.c (parse_partial_symbols): Update.
9895         * dwarf2read.c (create_addrmap_from_index)
9896         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9897         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9898         (add_partial_subprogram, dwarf2_ranges_read): Update.
9899         * dwarf-index-write.c (write_address_map)
9900         (write_one_signatured_type, recursively_write_psymbols)
9901         (class debug_names, class debug_names, write_psymtabs_to_index):
9902         Update.
9903
9904 2019-01-10  Tom Tromey  <tom@tromey.com>
9905
9906         * symtab.h (SYMBOL_SET_NAMES): Update.
9907         (symbol_set_names): Update.
9908         (MSYMBOL_SET_NAMES): Update.
9909         * symtab.c (symbol_set_names): Change argument to be an
9910         objfile_per_bfd_storage.
9911         * psymtab.c (add_psymbol_to_bcache): Update.
9912         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9913
9914 2019-01-10  Tom Tromey  <tom@tromey.com>
9915
9916         * symtab.c (create_demangled_names_hash): Change argument to be an
9917         objfile_per_bfd_storage.
9918         (symbol_set_names): Update.
9919
9920 2019-01-10  Tom Tromey  <tom@tromey.com>
9921
9922         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9923         init_psymbol_list.
9924         * psymtab.c (init_psymbol_list): Do nothing if already called.
9925         * psympriv.h (init_psymbol_list): Add comment.
9926         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9927         init_psymbol_list.
9928         * dbxread.c (dbx_symfile_read): Unconditionally call
9929         init_psymbol_list.
9930
9931 2019-01-10  Tom Tromey  <tom@tromey.com>
9932
9933         * xcoffread.c (scan_xcoff_symtab): Update.
9934         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9935         "where".
9936         * mdebugread.c (parse_partial_symbols)
9937         (handle_psymbol_enumerators): Update.
9938         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9939         * dbxread.c (read_dbx_symtab): Update.
9940         * psympriv.h (psymbol_placement): New enum.
9941         (add_psymbol_to_list): Update.
9942
9943 2019-01-10  Tom Tromey  <tom@tromey.com>
9944
9945         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9946         static_psymbols parameters.
9947         (scan_xcoff_symtab): Update.
9948         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9949         static_psymbols parameters.
9950         * psympriv.h (start_psymtab_common): Update.
9951         * mdebugread.c (parse_partial_symbols): Update.
9952         * dwarf2read.c (create_partial_symtab): Update.
9953         * dbxread.c (read_dbx_symtab): Update.
9954         (start_psymtab): Remove global_psymbols and static_psymbols
9955         parameters.
9956
9957 2019-01-10  Tom Tromey  <tom@tromey.com>
9958
9959         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9960         * psymtab.c (allocate_psymtab): Add comment.
9961         * psympriv.h (allocate_psymtab): Add comment.
9962         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9963         initializations.
9964         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9965
9966 2019-01-10  Tom Tromey  <tom@tromey.com>
9967
9968         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9969         Don't declare.
9970         * mipsread.c: Include mdebugread.h.
9971         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9972         Declare.
9973         * elfread.c: Include mdebugread.h.
9974
9975 2019-01-09  Tom Tromey  <tom@tromey.com>
9976
9977         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9978         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9979         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9980         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9981         (psym_lookup_symbol, psym_find_last_source_symtab)
9982         (psym_forget_cached_source_info, psym_print_stats)
9983         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9984         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9985         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9986         (psym_find_compunit_symtab_by_address)
9987         (maintenance_print_psymbols, maintenance_info_psymtabs)
9988         (maintenance_check_psymtabs): Use ranged for.
9989         * psymtab.h (class objfile_psymtabs): New.
9990         (require_partial_symbols): Return objfile_psymtabs.
9991         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9992
9993 2019-01-09  Tom Tromey  <tom@tromey.com>
9994
9995         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9996         (find_pc_mapped_section, list_overlays_command)
9997         (map_overlay_command, unmap_overlay_command)
9998         (simple_overlay_update): Use all_objfiles.
9999         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10000         * printcmd.c (info_symbol_command): Use all_objfiles.
10001         * objfiles.h (ALL_OBJSECTIONS): Remove.
10002         * maint.c (maintenance_translate_address): Use all_objfiles.
10003         * gcore.c (gcore_create_callback): Use all_objfiles.
10004         (objfile_find_memory_regions): Likewise.
10005
10006 2019-01-09  Tom Tromey  <tom@tromey.com>
10007
10008         * symtab.c (find_line_symtab, info_sources_command)
10009         (make_source_files_completion_list): Use objfile_compunits.
10010         * source.c (select_source_symtab): Use objfile_compunits.
10011         * objfiles.h (struct objfile): Update comment.
10012         (ALL_OBJFILES): Remove.
10013         (ALL_FILETABS): Remove.
10014         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10015         objfile_compunits.
10016
10017 2019-01-09  Tom Tromey  <tom@tromey.com>
10018
10019         * symmisc.c (print_objfile_statistics, dump_objfile)
10020         (maintenance_print_symbols): Use compunit_filetabs.
10021         * source.c (forget_cached_source_info_for_objfile): Use
10022         compunit_filetabs.
10023         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10024         (ALL_FILETABS): Use compunit_filetabs.
10025         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10026         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10027
10028 2019-01-09  Tom Tromey  <tom@tromey.com>
10029
10030         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10031         (compunit_filetabs): New.
10032         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10033         compunit_filetabs.
10034         (info_sources_command, make_source_files_completion_list): Remove
10035         declaration.
10036         * symmisc.c (print_objfile_statistics, dump_objfile)
10037         (maintenance_print_symbols): Remove declaration.
10038         (maintenance_info_symtabs): Use compunit_filetabs.
10039         (maintenance_info_line_tables): Likewise.
10040         * source.c (select_source_symtab): Change local variable name.
10041         (forget_cached_source_info_for_objfile): Remove declaration.
10042         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10043         * objfiles.c (objfile_relocate1): Remove declaration.
10044         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10045         declaration.
10046         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10047         * coffread.c (coff_symtab_read): Remove declaration.
10048         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10049         compunit_filetabs.
10050
10051 2019-01-09  Tom Tromey  <tom@tromey.com>
10052
10053         * symtab.c (lookup_objfile_from_block)
10054         (find_pc_sect_compunit_symtab, search_symbols)
10055         (default_collect_symbol_completion_matches_break_on): Use
10056         objfile_compunits.
10057         * objfiles.h (ALL_COMPUNITS): Remove.
10058         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10059         * cp-support.c (add_symbol_overload_list_qualified): Use
10060         objfile_compunits.
10061         * ada-lang.c (ada_collect_symbol_completion_matches)
10062         (ada_add_global_exceptions): Use objfile_compunits.
10063
10064 2019-01-09  Tom Tromey  <tom@tromey.com>
10065
10066         * source.c (select_source_symtab)
10067         (forget_cached_source_info_for_objfile): Remove declaration.
10068         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10069         declaration.
10070         * maint.c (count_symtabs_and_blocks): Remove declaration.
10071         * cp-support.c (add_symbol_overload_list_qualified): Remove
10072         declaration.
10073         * coffread.c (coff_symtab_read): Remove declaration.
10074         * symtab.c (lookup_symbol_in_objfile_symtabs)
10075         (basic_lookup_transparent_type_1): Use objfile_compunits.
10076         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10077         (info_sources_command, search_symbols)
10078         (default_collect_symbol_completion_matches_break_on)
10079         (make_source_files_completion_list): Remove declaration.
10080         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10081         (ada_collect_symbol_completion_matches)
10082         (ada_add_global_exceptions): Remove declaration.
10083         * linespec.c (iterate_over_all_matching_symtabs): Use
10084         objfile_compunits.
10085         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10086         (class objfile_compunits): New.
10087         (ALL_COMPUNITS): Use objfile_compunits.
10088         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10089         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10090         objfile_compunits.
10091         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10092
10093 2019-01-09  Tom Tromey  <tom@tromey.com>
10094
10095         * symtab.c (search_symbols)
10096         (default_collect_symbol_completion_matches_break_on): Use
10097         objfile_msymbols.
10098         * ada-lang.c (ada_lookup_simple_minsym)
10099         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10100         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10101         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10102         objfile_msymbols.
10103         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10104         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10105         * objc-lang.c (find_methods): Use objfile_msymbols.
10106         (info_selectors_command, info_classes_command): Likewise.
10107         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10108         * objfiles.h (class objfile_msymbols): New.
10109         (ALL_OBJFILE_MSYMBOLS): Remove.
10110         (ALL_MSYMBOLS): Remove.
10111
10112 2019-01-09  Tom Tromey  <tom@tromey.com>
10113
10114         * common/next-iterator.h (next_adapter): Add Iterator template
10115         parameter.
10116         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10117         (class all_objfiles_safe): New.
10118         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10119         * objfiles.c (put_objfile_before): Update comment.
10120         (add_separate_debug_objfile): Likewise.
10121         (free_all_objfiles): Use all_objfiles_safe.
10122         (objfile_purge_solibs): Likewise.
10123
10124 2019-01-09  Tom Tromey  <tom@tromey.com>
10125
10126         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10127         (expand_symtab_containing_pc, lookup_static_symbol)
10128         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10129         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10130         all_objfiles.
10131         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10132         * breakpoint.c (create_overlay_event_breakpoint)
10133         (create_longjmp_master_breakpoint)
10134         (create_std_terminate_master_breakpoint)
10135         (create_exception_master_breakpoint): Use all_objfiles.
10136         * linux-thread-db.c (try_thread_db_load_from_pdir)
10137         (has_libpthread): Use all_objfiles.
10138         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10139         * linespec.c (iterate_over_all_matching_symtabs)
10140         (search_minsyms_for_name): Use all_objfiles.
10141         * maint.c (maintenance_info_sections): Use all_objfiles.
10142         * main.c (captured_main_1): Use all_objfiles.
10143         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10144         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10145         * guile/scm-pretty-print.c
10146         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10147         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10148         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10149         (maintenance_print_msymbols): Use all_objfiles.
10150         * source.c (select_source_symtab): Use all_objfiles.
10151         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10152         * symfile.c (remove_symbol_file_command)
10153         (expand_symtabs_matching, map_symbol_filenames): Use
10154         all_objfiles.
10155         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10156         all_objfiles.
10157         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10158         * objc-lang.c (find_methods): Use all_objfiles.
10159         * objfiles.c (have_partial_symbols, have_full_symbols)
10160         (have_minimal_symbols, qsort_cmp)
10161         (default_iterate_over_objfiles_in_search_order): Use
10162         all_objfiles.
10163         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10164         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10165         (maintenance_check_psymtabs): Use all_objfiles.
10166         (ALL_PSYMTABS): Remove.
10167         * compile/compile-object-run.c (do_module_cleanup): Use
10168         all_objfiles.
10169         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10170         * cp-support.c (add_symbol_overload_list_qualified): Use
10171         all_objfiles.
10172         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10173         Use all_objfiles.
10174         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10175         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10176         all_objfiles.
10177         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10178         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10179         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10180         Uses all_objfiles.
10181         * solib.c (solib_read_symbols): Use all_objfiles
10182
10183 2019-01-09  Tom Tromey  <tom@tromey.com>
10184
10185         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10186         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10187         all_objfiles.
10188         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10189         * symmisc.c (print_symbol_bcache_statistics)
10190         (print_objfile_statistics, maintenance_print_objfiles)
10191         (maintenance_info_symtabs, maintenance_check_symtabs)
10192         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10193         all_objfiles.
10194         * source.c (forget_cached_source_info): Use all_objfiles.
10195         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10196         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10197         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10198         * objfiles.c (update_section_map): Use all_objfiles.
10199         (shared_objfile_contains_address_p): Likewise.
10200         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10201         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10202
10203 2019-01-09  Tom Tromey  <tom@tromey.com>
10204
10205         * common/next-iterator.h: New file.
10206         * objfiles.h (class all_objfiles): New.
10207         (struct objfile_iterator): New.
10208
10209 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10210
10211         * NEWS: Move the description of the changed "frame", "select-frame",
10212          and "info frame" commands to the Changed commands section.
10213
10214 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10215
10216         * gdbtypes.c (check_stub_method_group): Remove handling of old
10217         mangling schemes.
10218         * linespec.c (find_methods): Likewise.
10219         * stabsread.c (read_member_functions): Likewise.
10220         * valops.c (search_struct_method): Likewise.
10221         (value_struct_elt_for_reference): Likewise.
10222         * NEWS: Mention this change.
10223
10224 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10225
10226         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10227         print_source_lines.
10228         * source.c (print_source_lines_base): Update line number check.
10229         (print_source_lines): New function.
10230         (source_lines_range::source_lines_range): New function.
10231         * source.h (class source_lines_range): New class.
10232         (print_source_lines): New declaration.
10233
10234 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10235
10236         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10237
10238 2019-01-08  Tom Tromey  <tom@tromey.com>
10239             Simon Marchi  <simon.marchi@ericsson.com>
10240
10241         PR gdb/24060
10242         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10243         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10244         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10245         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10246         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10247         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10248
10249 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10250
10251         * source.c (select_source_symtab): Move header comment to
10252         declaration in source.h.
10253         (forget_cached_source_info_for_objfile): Likewise.
10254         (forget_cached_source_info): Likewise.
10255         (identify_source_line): Likewise.
10256         * source.h (identify_source_line): Move declaration from symtab.h
10257         and add comment from source.c
10258         (print_source_lines): Likewise.
10259         (forget_cached_source_info_for_objfile): Likewise.
10260         (forget_cached_source_info): Likewise.
10261         (select_source_symtab): Likewise.
10262         (enum print_source_lines_flag): Move definition from symtab.h.
10263         * symtab.h (identify_source_line): Move declaration to source.h.
10264         (print_source_lines): Likewise.
10265         (forget_cached_source_info_for_objfile): Likewise.
10266         (forget_cached_source_info): Likewise.
10267         (select_source_symtab): Likewise.
10268         (enum print_source_lines_flag): Move definition to source.h.
10269         * tui/tui-hooks.c: Add 'source.h' include.
10270
10271 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10272
10273         * source.c (print_source_lines_base): Handle requests to print
10274         reverse line number sequences, and guard against empty lines
10275         string.
10276
10277 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10278
10279         * source.c (print_source_lines_base): Fix skip of '\r' if next
10280         character is '\n'.
10281
10282 2019-01-06  Tom Tromey  <tom@tromey.com>
10283
10284         * c-exp.y (struct c_parse_state) <macro_original_text,
10285         expansion_obstack>: New member.
10286         (macro_original_text, expansion_obstack): Remove globals.
10287         (scan_macro_expansion, scanning_macro_expansion)
10288         (finished_macro_expansion): Update.
10289         (scan_macro_cleanup): Remove.
10290         (yylex, c_parse): Update.
10291
10292 2019-01-06  Tom Tromey  <tom@tromey.com>
10293
10294         * c-exp.y (struct c_parse_state) <strings>: New member.
10295         (operator_stoken): Update.
10296
10297 2019-01-06  Tom Tromey  <tom@tromey.com>
10298
10299         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10300         (union type_stack_elt) <typelist_val>: Now a pointer to
10301         std::vector.
10302         (type_stack_cleanup): Don't declare.
10303         (push_typelist): Update.
10304         * parse.c (pop_typelist): Return a std::vector.
10305         (push_typelist): Take a std::vector.
10306         (follow_types): Update.  Do not free args.
10307         (type_stack_cleanup): Remove.
10308         * c-exp.y (struct c_parse_state): New.
10309         (cpstate): New global.
10310         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10311         (nonempty_typelist): Update.
10312         (func_mod): Create a new vector.
10313         (c_parse): Create a c_parse_state.
10314         (check_parameter_typelist): Do not delete params.
10315         (function_method): Update.  Do not delete type_list.
10316
10317 2019-01-06  Tom Tromey  <tom@tromey.com>
10318
10319         PR gdb/28155:
10320         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10321         check_typedef.
10322         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10323         (print_return_value): Likewise.
10324
10325 2019-01-05  Tom Tromey  <tom@tromey.com>
10326
10327         * contrib/cleanup_check.py: Remove.
10328         * contrib/gcc-with-excheck: Remove.
10329         * contrib/exsummary.py: Remove.
10330         * contrib/excheck.py: Remove.
10331
10332 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10333
10334         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10335         NULL. Initialize tpprev to NULL instead of assigning it
10336         to NULL on the next statement.
10337         * windows-nat.c (windows_delete_thread): Remove check for
10338         main_thread_id before printing thread exit notifications.
10339         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10340         Remove thread ID check against main_thread_id.
10341         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10342         windows_delete_thread.
10343         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10344
10345 2019-01-04  Tom Tromey  <tom@tromey.com>
10346
10347         * compile/compile.c (_initialize_compile): Use upper case for
10348         metasyntactic variables.
10349         * symmisc.c (_initialize_symmisc): Use upper case for
10350         metasyntactic variables.
10351         * psymtab.c (_initialize_psymtab): Use upper case for
10352         metasyntactic variables.
10353         * demangle.c (demangle_command): Use upper case for metasyntactic
10354         variables.
10355         (_initialize_demangler): Likewise.
10356         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10357         variables.
10358
10359 2019-01-03  Tom Tromey  <tom@tromey.com>
10360
10361         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10362
10363 2019-01-03  Tom Tromey  <tom@tromey.com>
10364
10365         * python/py-symtab.c (salpy_str): Update.
10366         (struct salpy_sal_object) <symtab>: Now a PyObject.
10367         (salpy_dealloc): Update.
10368         (del_objfile_sal): Use gdbpy_ref.
10369
10370 2019-01-03  Tom Tromey  <tom@tromey.com>
10371
10372         * python/py-type.c (convert_field): Use new_reference.  Return
10373         gdbpy_ref.
10374         (make_fielditem): Return gdbpy_ref.
10375         (typy_fields): Update.
10376         (typy_getitem): Update.
10377         (field_name): Return gdbpy_ref.  Use new_reference.
10378         (typy_iterator_iternext): Update.
10379
10380 2019-01-03  Tom Tromey  <tom@tromey.com>
10381
10382         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10383
10384 2019-01-03  Tom Tromey  <tom@tromey.com>
10385
10386         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10387         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10388         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10389         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10390         (pspy_set_type_printers): Likewise.
10391         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10392         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10393         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10394         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10395         (objfpy_set_type_printers): Likewise.
10396
10397 2019-01-03  Tom Tromey  <tom@tromey.com>
10398
10399         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10400         (gdbpy_print_stack): Use gdbpy_err_fetch.
10401         * python/python-internal.h (class gdbpy_err_fetch): New class.
10402         (class gdbpy_enter) <m_error_type, m_error_value,
10403         m_error_traceback>: Remove.
10404         <m_error>: New member.
10405         (gdbpy_exception_to_string): Don't declare.
10406         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10407         * python/py-value.c (convert_value_from_python): Use
10408         gdbpy_err_fetch.
10409         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10410         gdbpy_exception_to_string.
10411         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10412         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10413         gdbpy_err_fetch.
10414
10415 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10416
10417         * linux-nat.c (delete_lwp_cleanup): Delete.
10418         (struct lwp_deleter): New struct.
10419         (lwp_info_up): New typedef.
10420         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10421         lwp_info_up.
10422
10423 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10424
10425         * linux-fork.c (class scoped_switch_fork_info): New class.
10426         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10427
10428 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10429
10430         * valops.c (find_overload_match): Remove use of null_cleanup, and
10431         calls to do_cleanups.
10432
10433 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10434
10435         * compile/compile-cplus-types.c
10436         (compile_cplus_instance::decl_name): Handle changes to
10437         cp_func_name.
10438         * cp-support.c (cp_func_name): Update header comment, update
10439         return type.
10440         * cp-support.h (cp_func_name): Update return type in declaration.
10441         * valops.c (find_overload_match): Move temp_func local to top
10442         level of function and change its type.  Use temp_func to hold and
10443         delete temporary string obtained from cp_func_name.
10444
10445 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10446
10447         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10448         gdb::char_vector, remove cleanup, and update uses of `msg`.
10449
10450 2019-01-03  Jim Wilson  <jimw@sifive.com>
10451
10452         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10453
10454 2019-01-02  Tom Tromey  <tom@tromey.com>
10455
10456         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10457         (tdesc_parse_xml): Remove cleanups.
10458         * target-descriptions.h (make_cleanup_free_target_description):
10459         Don't declare.
10460         (target_desc_deleter): New struct.
10461         (target_desc_up): New typedef.
10462         * target-descriptions.c (target_desc_deleter::operator()): Rename
10463         from free_target_description.
10464         (make_cleanup_free_target_description): Remove.
10465
10466 2019-01-02  Tom Tromey  <tom@tromey.com>
10467
10468         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10469         constructor, destructor.
10470         (linespec_parser): Remove typedef.
10471         (~linespec_parser): Rename from linespec_parser_delete.
10472         (linespec_lex_to_end, linespec_complete_label)
10473         (linespec_complete): Update.
10474         (decode_line_full): Remove cleanups.
10475         (decode_line_1): Update.
10476
10477 2019-01-02  Tom Tromey  <tom@tromey.com>
10478
10479         * python/python-internal.h (inferior_to_inferior_object): Change
10480         return type.
10481         * python/py-exitedevent.c (create_exited_event_object): Update.
10482         * python/py-inferior.c (inferior_to_inferior_object): Return
10483         gdbpy_ref.
10484         (python_new_inferior, python_inferior_deleted)
10485         (thread_to_thread_object, delete_thread_object)
10486         (build_inferior_list, gdbpy_selected_inferior): Update.
10487         * python/py-infthread.c (create_thread_object): Update.  Also fail
10488         if inferior_to_inferior_object fails.
10489
10490 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10491
10492         * inferior.h (class inferior) <displaced_step_state>: New field.
10493         * infrun.h (struct displaced_step_state): Move here from
10494         infrun.c.  Initialize fields, add constructor.
10495         <inf>: Remove field.
10496         <reset>: New method.
10497         * infrun.c (struct displaced_step_inferior_state): Move to
10498         infrun.h.
10499         (displaced_step_inferior_states): Remove.
10500         (get_displaced_stepping_state): Adust.
10501         (displaced_step_in_progress_any_inferior): Adjust.
10502         (displaced_step_in_progress_thread): Adjust.
10503         (displaced_step_in_progress): Adjust.
10504         (add_displaced_stepping_state): Remove.
10505         (get_displaced_step_closure_by_addr): Adjust.
10506         (remove_displaced_stepping_state): Remove.
10507         (infrun_inferior_exit): Call displaced_step_state.reset.
10508         (use_displaced_stepping): Don't check for NULL.
10509         (displaced_step_prepare_throw): Call
10510         get_displaced_stepping_state.
10511         (displaced_step_fixup): Don't check for NULL.
10512         (prepare_for_detach): Don't check for NULL.
10513
10514 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10515
10516         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10517          in case of call that did not complete.
10518
10519 2019-01-02  Andrey Utkin  <autkin@undo.io>
10520
10521         * symfile.c (find_separate_debug_file): Fix search of debug files for
10522         remote debuggee.
10523
10524 2019-01-02  Tom Tromey  <tom@tromey.com>
10525
10526         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10527         indentation.
10528         * python/py-frame.c (frapy_older): Remove cast.
10529         (frapy_newer): Likewise.
10530         * python/py-breakpoint.c (local_setattro): Remove cast.
10531         * python/py-arch.c (archpy_name): Remove local variable.
10532         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10533
10534 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10535
10536         * unittests/basic_string_view/element_access/char/empty.cc:
10537         Fix year range in copyright header.
10538
10539 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10540
10541         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10542         Delete.
10543         <operator==>: Update with for removed field.
10544         <hash>: Likewise.
10545         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10546         <isa_features>: ...this.
10547         <abi_features>: New field.
10548         (riscv_isa_flen): Update comment.
10549         (riscv_abi_xlen): New declaration.
10550         (riscv_abi_flen): New declaration.
10551         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10552         isa_features.
10553         (riscv_abi_xlen): New function.
10554         (riscv_isa_flen): Update to get answer from isa_features.
10555         (riscv_abi_flen): New function.
10556         (riscv_has_fp_abi): Update to get answer from abi_features.
10557         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10558         xlen and flen.
10559         (riscv_call_info) <xlen, flen>: Update comment.
10560         (riscv_call_arg_struct): Remove invalid assertions
10561         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10562         is removed.
10563         (riscv_gdbarch_init): Gather isa features and abi features
10564         separately, ensure both match on the gdbarch when reusing an old
10565         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10566         a target with 64-bit float hardware.
10567
10568 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10569
10570         * source.c (search_command_helper): Stop reverse search
10571         when line 1 has been searched.
10572
10573 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10574
10575         * record-full.c (record_full_base_target::close): Rewrite
10576         record_full_core_buf_list free logic.
10577
10578 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10579
10580         * break-catch-syscall.c (print_one_catch_syscall): xfree
10581         the last text.
10582
10583 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10584
10585         * top.c (print_gdb_version): Update Copyright year in version
10586         message.
10587
10588 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10589
10590         Update copyright year range in all GDB files.
10591
10592 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10593
10594         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10595
10596 For older changes see ChangeLog-2018.
10597 \f
10598 Local Variables:
10599 mode: change-log
10600 left-margin: 8
10601 fill-column: 74
10602 version-control: never
10603 coding: utf-8
10604 End:
10605