Fix GDB 8.3 regression crash when registers cannot be modified.
[external/binutils.git] / gdb / ChangeLog
1 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2
3         * inferior.h (struct infcall_suspend_state_deleter):
4         Catch exception in destructor to avoid crash.
5
6 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7
8         * utils.c (prompt_for_continue): Don't restore the styling at the
9         end, as applied_style has the wrong value.  This fixes styling in
10         long lists of file names that are interrupted by the "Continue?"
11         prompt.
12
13 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
14
15         * version.in: Set GDB version number to 8.2.91.DATE-git.
16
17 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
18
19         GDB 8.2.91 released.
20
21 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
22
23         * version.in: Set GDB version number to 8.2.91.
24
25 2019-03-20  Tom Tromey  <tromey@adacore.com>
26
27         PR gdb/24391
28         * infrun.c (handle_inferior_event): Rename from
29         handle_inferior_event_1.  Create a scoped_value_mark.
30         (handle_inferior_event): Remove.
31
32 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
33
34         * source-cache.c (source_cache::get_source_lines): Re-read
35         fullname after calling open_source_file.
36
37 2019-03-18  Pedro Alves  <palves@redhat.com>
38             Eli Zaretskii <eliz@gnu.org>
39
40         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
41         m_line and m_start_of_line.
42
43 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
44
45         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
46         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
47         it returns a newline.  This fixes a regression in TU mode, whereby
48         the next line is output on the same screen line as the user input.
49
50 2019-03-18  Pedro Alves  <palves@redhat.com>
51
52         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
53         New globals.
54         (apply_style): New, factored out from ...
55         (apply_ansi_escape): ... this.  Handle reverse video mode.
56         (tui_set_reverse_mode): New function.
57         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
58         * tui/tui-winsource.c (tui_show_source_line): Use
59         tui_set_reverse_mode instead of setting A_STANDOUT.
60         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
61         New setter methods.
62
63 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
64
65         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
66         Handle tabs.
67
68 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
69
70         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
71         tui_refill_source_window instead of tui_refresh_win, to update the
72         current execution line.  This fixes redisplay of the current line
73         when stepping through the code with "next" or "step".
74
75 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
76
77         * source-cache.c (source_cache::get_source_lines): Call
78         find_source_lines to initialize s->nlines.  This fixes vertical
79         scrolling of TUI source window when the DOWN arrow is pressed.
80
81 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
82
83         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
84         wclrtoeol in tui_show_source_line".  This reverts changes made in
85         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
86
87 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
88
89         * NEWS: Combine separate "New targets" sections for 8.3.
90
91 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
92
93         The MS-Windows port of ncurses fails to switch to a color pair if
94         one or both of the colors are the implicit default colors.  This
95         change records the default colors when TUI is initialized, and
96         then specifies them explicitly when a color pair uses the default
97         colors.  This allows color styling in TUI mode on MS-Windows.
98
99         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
100         ncurses_norm_attr.
101         (tui_initialize_io) [__MINGW32__]: Record the default terminal
102         colors in ncurses_norm_attr.
103         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
104         "none", replace it with the default color recorded in
105         ncurses_norm_attr.
106
107 2019-03-14  Tom Tromey  <tromey@adacore.com>
108
109         * source-cache.h (class source_cache) <get_source_lines>: Return
110         std::string.
111         * source-cache.c (source_cache::extract_lines): Handle case where
112         first_pos==npos.  Return std::string.
113         (source_cache::get_source_lines): Update.
114
115 2019-03-14  Tom Tromey  <tromey@adacore.com>
116
117         * NEWS: Add item for "style sources" commands.
118         * source-cache.c (source_cache::get_source_lines): Check
119         source_styling.
120         * cli/cli-style.c (source_styling): New global.
121         (_initialize_cli_style): Add "style sources" commands.
122         (show_style_sources): New function.
123         * cli/cli-style.h (source_styling): Declare.
124
125 2019-03-14  Pedro Alves  <palves@redhat.com>
126             Tom Tromey  <tromey@adacore.com>
127
128         * tui/tui-winsource.h (tui_refill_source_window): Declare.
129         * tui/tui-winsource.c (tui_refill_source_window): New function,
130         from...
131         (tui_horizontal_source_scroll): ... here.  Move some logic.
132         * cli/cli-style.c (set_style_enabled): Notify new observable.
133         * tui/tui-hooks.c (tui_redisplay_source): New function.
134         (tui_attach_detach_observers): Attach or detach
135         tui_redisplay_source.
136         * observable.h (source_styling_changed): New observable.
137         * observable.c: Define source_styling_changed observable.
138
139 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
140
141         PR/24325
142         * source-cache.c: #undef open and close, to avoid unresolved
143         externals during linking.
144
145 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
146
147         Support styling on native MS-Windows console
148
149         PR/24315
150         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
151         on MS-Windows if $TERM is not defined.
152
153         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
154
155         * posix-hdep.c (gdb_console_fputs):
156         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
157         functions.
158         * ui-file.h (gdb_console_fputs): Add prototype.
159
160         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
161         back to fputs only if the former returns zero.
162
163 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
164             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
165
166         PR gdb/8527
167         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
168         set_sigint_trap, clear_sigint_trap.
169
170 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
171
172         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
173         for-loop range, to avoid compiler warnings.
174
175         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
176         avoid compiler warnings about unused variables.
177
178 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
179
180         * NEWS: Mention end of support for native debugging on MS-Windows
181         before XP.
182
183 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
184
185         PR gdb/24292
186         * common/netstuff.c:
187         * gdbserver/gdbreplay.c
188         * gdbserver/remote-utils.c:
189         * ser-tcp.c:
190         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
191         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
192         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
193         'getaddrinfo' and 'freeaddrinfo' were not available before
194         Windows XP, and mingw.org's MinGW headers by default define
195         _WIN32_WINNT to 0x500.
196
197 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
198     
199         * NEWS: Note minimum Python version.
200
201 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
202
203         * version.in: Set GDB version number to 8.2.90.DATE-git.
204
205 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
206
207         GDB 8.2.90 released.
208
209 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
210
211         * version.in: Set GDB version number to 8.2.90.
212
213 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
214
215         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
216
217 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
218
219         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
220         * version.in: Bump version to 8.2.90.DATE-git.
221
222 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
223
224         * aix-thread.c (ptid_cmp): Remove unused variable.
225         (get_signaled_thread): Likewise.
226         (store_regs_user_thread): Likewise.
227         (store_regs_kernel_thread): Likewise.
228         (fetch_regs_kernel_thread): Remove shadowed variable.
229
230 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
231
232         * features/riscv/32bit-cpu.xml: Add register numbers.
233         * features/riscv/32bit-fpu.c: Regenerate.
234         * features/riscv/32bit-fpu.xml: Add register numbers.
235         * features/riscv/64bit-cpu.xml: Add register numbers.
236         * features/riscv/64bit-fpu.c: Regenerate.
237         * features/riscv/64bit-fpu.xml: Add register numbers.
238
239 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
240
241         * NEWS: Mention two argument form of gdb.Value constructor.
242         * python/py-value.c (convert_buffer_and_type_to_value): New
243         function.
244         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
245         Add support for handling an optional second argument.  Call
246         convert_buffer_and_type_to_value as appropriate.
247         * python/python-internal.h (Py_buffer_deleter): New struct.
248         (Py_buffer_up): New typedef.
249
250 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
251
252         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
253         instead of releasing ownership.
254
255 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
256
257         * dwarf2read.c (open_and_init_dwp_file): Call
258         elf_numsections instead of bfd_count_sections to initialize
259         dwp_file->num_sections.
260
261 2019-02-25  Tom Tromey  <tromey@adacore.com>
262
263         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
264
265 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
266
267         * gcore.in: Add '--readnever' option when invoking GDB.
268
269 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
270
271         * MAINTAINERS: Update my email address.
272
273 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
274
275         * build-id.c (build_id_to_debug_bfd_1): New function.
276         (build_id_to_debug_bfd): Look for separate debug file in
277         sysroot.
278
279 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
280
281         * gdbarch.sh: Update the copyright year range that is placed into
282         generated files.
283
284 2019-02-22  Keith Seitz  <keiths@redhat.com>
285
286         PR symtab/23853
287         * linespec.c (create_sals_line_offset): Search for the default
288         symtab's filename instead of its fullname.
289
290 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
291
292         * NEWS: Update style defaults.
293
294 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
295
296         * main.c (captured_main_1): Disable styling in batch mode.
297
298 2019-02-20  Tom Tromey  <tom@tromey.com>
299
300         * symtab.c (symtab_symbol_info): Fix typos.
301
302 2019-02-20  Tom Tromey  <tromey@adacore.com>
303
304         * findcmd.c (_initialize_mem_search): Use upper case for
305         metasyntactic variables.
306
307 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
308
309         * aarch64-tdep.c (aarch64_add_reggroups): New function.
310         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
311
312 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
313
314         * top.h (source_file_name): Change to std::string.
315         * top.c (source_file_name): Likewise.
316         (command_line_input): Adjust.
317         * cli/cli-script.c (script_from_file): Adjust.
318
319 2019-02-19  Tom Tromey  <tromey@adacore.com>
320
321         * ravenscar-thread.c
322         (ravenscar_thread_target::update_thread_list): Don't call
323         ada_build_task_list.
324         * ada-lang.h (ada_build_task_list): Don't declare.
325         * ada-tasks.c (struct ada_tasks_inferior_data)
326         <task_list_valid_p>: Now bool.
327         (read_known_tasks, ada_task_list_changed)
328         (ada_tasks_invalidate_inferior_data): Update.
329         (read_known_tasks_array): Return bool.
330         (read_known_tasks_list): Likewise.
331         (read_known_tasks): Return void.
332         (ada_build_task_list): Now static.
333
334 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
335
336         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
337         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
338
339 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
340
341         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
342         variant for ada_tasks_pspace_data_handle and
343         ada_tasks_inferior_data_handle.
344         (ada_tasks_pspace_data_cleanup): New function.
345         (ada_tasks_inferior_data_cleanup): New function.
346
347 2019-02-17  Tom Tromey  <tom@tromey.com>
348
349         * macrotab.h (macro_source_fullname): Return a std::string.
350         * macrotab.c (macro_include, check_for_redefinition)
351         (macro_undef, macro_lookup_definition, foreach_macro)
352         (foreach_macro_in_scope): Update.
353         (macro_source_fullname): Return a std::string.
354         * macrocmd.c (show_pp_source_pos): Update.
355
356 2019-02-17  Tom Tromey  <tom@tromey.com>
357
358         * macrocmd.c (show_pp_source_pos): Style the file names.
359
360 2019-02-17  Tom Tromey  <tom@tromey.com>
361
362         PR tui/24197:
363         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
364
365 2019-02-17  Tom Tromey  <tom@tromey.com>
366
367         * ada-lang.c (user_select_syms): Use filtered printing.
368         * utils.c (wrap_style): New global.
369         (desired_style): Remove.
370         (emit_style_escape): Add stream parameter.
371         (set_output_style, reset_terminal_style, prompt_for_continue):
372         Update.
373         (flush_wrap_buffer): Only flush gdb_stdout.
374         (wrap_here): Set wrap_style.
375         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
376         treat escape sequences as a character.  Change when wrap buffer is
377         flushed.
378         (fputs_styled): Do not set the output style when the default is
379         requested.
380         * ui-style.h (struct ui_file_style) <is_default>: New method.
381         * source.c (print_source_lines_base): Emit escape sequences in one
382         piece.
383
384 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
385
386         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
387         integers and enumeration types.
388
389 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
390
391         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
392         instead of lookup_symbol_in_language
393         (do_exact_match): New function.
394         (ada_get_symbol_name_matcher): Return do_exact_match when
395         doing a verbatim match.
396
397 2019-02-15  Tom Tromey  <tromey@adacore.com>
398
399         * ravenscar-thread.c (ravenscar_thread_target::resume)
400         (ravenscar_thread_target::wait): Special case wildcard requests.
401
402 2019-02-15  Tom Tromey  <tromey@adacore.com>
403
404         * ravenscar-thread.c (base_ptid): Remove.
405         (struct ravenscar_thread_target) <close>: New method.
406         <m_base_ptid>: New member.
407         <update_inferior_ptid, active_task, task_is_currently_active,
408         runtime_initialized>: Declare methods.
409         <ravenscar_thread_target>: Add constructor.
410         (ravenscar_thread_target::task_is_currently_active)
411         (ravenscar_thread_target::update_inferior_ptid)
412         (ravenscar_runtime_initialized): Rename.  Now methods.
413         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
414         (ravenscar_thread_target::update_thread_list): Update.
415         (ravenscar_thread_target::active_task): Now method.
416         (ravenscar_thread_target::store_registers)
417         (ravenscar_thread_target::prepare_to_store)
418         (ravenscar_thread_target::prepare_to_store)
419         (ravenscar_thread_target::mourn_inferior): Update.
420         (ravenscar_inferior_created): Use "new" to create target.
421         (ravenscar_thread_target::get_ada_task_ptid): Update.
422         (_initialize_ravenscar): Don't initialize base_ptid.
423         (ravenscar_ops): Remove global.
424
425 2019-02-15  Tom Tromey  <tromey@adacore.com>
426
427         * target.h (push_target): Declare new overload.
428         * target.c (push_target): New overload, taking an rvalue reference.
429         * remote.c (remote_target::open_1): Use push_target overload.
430         * corelow.c (core_target_open): Use push_target overload.
431
432 2019-02-15  Tom Tromey  <tromey@adacore.com>
433
434         * ravenscar-thread.c (is_ravenscar_task)
435         (ravenscar_task_is_currently_active): Return bool.
436         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
437         (_initialize_ravenscar): Remove "(void)".
438         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
439         Return bool.
440
441 2019-02-15  Tom Tromey  <tromey@adacore.com>
442
443         * ravenscar-thread.c (ravenscar_runtime_initializer)
444         (has_ravenscar_runtime, get_running_thread_id)
445         (ravenscar_thread_target::resume): Fix indentation.
446
447 2019-02-15  Tom Tromey  <tromey@adacore.com>
448
449         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
450         from ravenscar_arch_ops.
451         (sparc_ravenscar_ops::fetch_registers)
452         (sparc_ravenscar_ops::store_registers): Now methods.
453         (sparc_ravenscar_prepare_to_store): Remove.
454         (sparc_ravenscar_ops): Redefine.
455         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
456         methods and destructor.  Remove members.
457         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
458         (ravenscar_thread_target::store_registers)
459         (ravenscar_thread_target::prepare_to_store): Update.
460         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
461         Remove.
462         (struct ppc_ravenscar_powerpc_ops): Derive from
463         ravenscar_arch_ops.
464         (ppc_ravenscar_powerpc_ops::fetch_registers)
465         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
466         (ppc_ravenscar_powerpc_ops): Redefine.
467         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
468         (ppc_ravenscar_e500_ops::fetch_registers)
469         (ppc_ravenscar_e500_ops::store_registers): Now methods.
470         (ppc_ravenscar_e500_ops): Redefine.
471         * aarch64-ravenscar-thread.c
472         (aarch64_ravenscar_generic_prepare_to_store): Remove.
473         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
474         (aarch64_ravenscar_fetch_registers)
475         (aarch64_ravenscar_store_registers): Now methods.
476         (aarch64_ravenscar_ops): Redefine.
477
478 2019-02-15  Tom Tromey  <tromey@adacore.com>
479
480         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
481         (ravenscar_thread_target::stopped_by_hw_breakpoint)
482         (ravenscar_thread_target::stopped_by_watchpoint)
483         (ravenscar_thread_target::stopped_data_address)
484         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
485
486 2019-02-15  Tom Tromey  <tromey@adacore.com>
487
488         * ravenscar-thread.c: Fix some typos.
489
490 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
491             Tom Tromey  <tromey@adacore.com>
492
493         * ada-lang.c (ada_exception_sal): Change addr_string to a
494         std::string.
495         (create_ada_exception_catchpoint): Update.
496
497 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
498             Tom Tromey  <tromey@adacore.com>
499
500         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
501         (bp_location_ops): Remove.
502         (base_breakpoint_allocate_location): Update.
503         (free_bp_location): Update.
504         * ada-lang.c (class ada_catchpoint_location)
505         <ada_catchpoint_location>: Remove ops parameter.
506         (ada_catchpoint_location_dtor): Remove.
507         (ada_catchpoint_location_ops): Remove.
508         (allocate_location_exception): Update.
509         * breakpoint.h (struct bp_location_ops): Remove.
510         (class bp_location) <bp_location>: Remove bp_location_ops
511         parameter.
512         <~bp_location>: Add destructor.
513         <ops>: Remove.
514
515 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
516             Pedro Alves  <palves@redhat.com>
517
518         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
519         'PATH_MAX'.
520
521 2019-02-14  David Michael  <fedora.dm0@gmail.com>
522             Samuel Thibault  <samuel.thibault@gnu.org>
523             Thomas Schwinge  <thomas@codesourcery.com>
524
525         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
526         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
527
528 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
529
530         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
531         (check_empty): Use "const char *".
532
533         * gnu-nat.c (gnu_nat_target::detach): Instead of
534         'detach_inferior (pid)' call
535         'detach_inferior (find_inferior_pid (pid))'.
536
537         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
538         'nat/fork-inferior.o'.
539         * gnu-nat.c: #include "nat/fork-inferior.h".
540
541         * gnu-nat.c (gnu_nat_target::detach): Instead of
542         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
543         * gnu-nat.h: #include "inf-child.h".
544         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
545         'i386_gnu_nat_target::fetch_registers'.
546         (gnu_store_registers): Rename/move to
547         'i386_gnu_nat_target::store_registers'.
548
549         * config/i386/nm-i386gnu.h: Don't "#include" any files.
550         * gnu-nat.h (mach_thread_info): New function.
551         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
552
553         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
554
555 2019-02-14  Frederic Konrad  <konrad@adacore.com>
556
557         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
558
559 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
560
561         * windows-nat.c (windows_add_thread): Add new parameter
562         "main_thread_p" with default value set to false.  Update
563         function documentation as well as all callers.
564         (windows_delete_thread): Likewise.
565         (fake_create_process): Update call to windows_add_thread.
566         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
567         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
568         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
569         call to windows_delete_thread.
570
571 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
572
573         * MAINTAINERS: Add Andrew Burgess as global maintainer.
574
575 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
576
577         * symfile.c (find_separate_debug_file): Use canonical path of
578         sysroot with child_path instead of gdb_sysroot if it is valid.
579
580 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
581
582         * symfile.c (find_separate_debug_file): Use child_path to
583         determine if an object file is under a sysroot.
584
585 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
586
587         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
588         unittests/child-path-selftests.c.
589         * common/pathstuff.c (child_path): New function.
590         * common/pathstuff.h (child_path): New prototype.
591         * unittests/child-path-selftests.c: New file.
592
593 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
594
595         * symfile.c (find_separate_debug_file): Look for separate debug
596         files in debug directories under the sysroot.
597
598 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
599
600         * symtab.h (struct minimal_symbol data_p): New const method.
601         (struct minimal_symbol text_p): Likewise.
602         * symtab.c (output_source_filename): Use file name style
603         to print file name.
604         (print_symbol_info): Likewise.
605         (print_msymbol_info): Use address style to print addresses.
606         Use function name style to print executable text symbols.
607         (expand_symtab_containing_pc): Use data_p.
608         (find_pc_sect_compunit_symtab): Likewise.
609
610 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
611
612         * breakpoint.c (describe_other_breakpoints): Use address style
613         to print addresses.
614         (say_where): Likewise.
615
616 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
617
618         * ada-typeprint.c (print_func_type): Print function name
619         style to print function name.
620         * c-typeprint.c (c_print_type_1): Likewise.
621
622 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
623
624         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
625         for execve.
626
627 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
628
629         * c-exp.y (direct_abs_decl): Use emplace_back to record the
630         type_stack.
631
632 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
633
634         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
635         TYPE_CODE_REF types.
636
637 2019-02-08  Jim Wilson  <jimw@sifive.com>
638
639         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
640         (riscv_linux_fregset): New.
641         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
642
643 2019-02-07  Tom Tromey  <tom@tromey.com>
644
645         * thread.c (thread_cancel_execution_command): Update.
646         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
647         methods.
648         (struct thread_fsm_ops): Remove.
649         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
650         (thread_fsm_should_stop, thread_fsm_return_value)
651         (thread_fsm_set_finished, thread_fsm_finished_p)
652         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
653         Don't declare.
654         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
655         * infrun.c (clear_proceed_status_thread)
656         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
657         (print_stop_event): Update.
658         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
659         Add constructor.
660         (step_command_fsm_ops): Remove.
661         (new_step_command_fsm): Remove.
662         (step_1): Update.
663         (step_command_fsm::should_stop): Rename from
664         step_command_fsm_should_stop.
665         (step_command_fsm::clean_up): Rename from
666         step_command_fsm_clean_up.
667         (step_command_fsm::do_async_reply_reason): Rename from
668         step_command_fsm_async_reply_reason.
669         (struct until_next_fsm): Inherit from thread_fsm.  Add
670         constructor.
671         (until_next_fsm_ops): Remove.
672         (new_until_next_fsm): Remove.
673         (until_next_fsm::should_stop): Rename from
674         until_next_fsm_should_stop.
675         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
676         (until_next_fsm::do_async_reply_reason): Rename from
677         until_next_fsm_async_reply_reason.
678         (struct finish_command_fsm): Inherit from thread_fsm.  Add
679         constructor.  Change type of breakpoint.
680         (finish_command_fsm_ops): Remove.
681         (new_finish_command_fsm): Remove.
682         (finish_command_fsm::should_stop): Rename from
683         finish_command_fsm_should_stop.
684         (finish_command_fsm::clean_up): Rename from
685         finish_command_fsm_clean_up.
686         (finish_command_fsm::return_value): Rename from
687         finish_command_fsm_return_value.
688         (finish_command_fsm::do_async_reply_reason): Rename from
689         finish_command_fsm_async_reply_reason.
690         (finish_command): Update.
691         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
692         Add constructor.
693         (call_thread_fsm_ops): Remove.
694         (call_thread_fsm::call_thread_fsm): Rename from
695         new_call_thread_fsm.
696         (call_thread_fsm::should_stop): Rename from
697         call_thread_fsm_should_stop.
698         (call_thread_fsm::should_notify_stop): Rename from
699         call_thread_fsm_should_notify_stop.
700         (run_inferior_call, call_function_by_hand_dummy): Update.
701         * cli/cli-interp.c (should_print_stop_to_console): Update.
702         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
703         Add constructor.  Change type of location_breakpoint,
704         caller_breakpoint.
705         (until_break_fsm_ops): Remove.
706         (new_until_break_fsm): Remove.
707         (until_break_fsm::should_stop): Rename from
708         until_break_fsm_should_stop.
709         (until_break_fsm::clean_up): Rename from
710         until_break_fsm_clean_up.
711         (until_break_fsm::do_async_reply_reason): Rename from
712         until_break_fsm_async_reply_reason.
713         (until_break_command): Update.
714         * thread-fsm.c: Remove.
715         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
716
717 2019-02-07  Tom Tromey  <tom@tromey.com>
718
719         * yy-remap.h: Add include guard.
720         * xtensa-tdep.h: Add include guard.
721         * xcoffread.h: Rename include guard.
722         * varobj-iter.h: Add include guard.
723         * tui/tui.h: Rename include guard.
724         * tui/tui-winsource.h: Rename include guard.
725         * tui/tui-wingeneral.h: Rename include guard.
726         * tui/tui-windata.h: Rename include guard.
727         * tui/tui-win.h: Rename include guard.
728         * tui/tui-stack.h: Rename include guard.
729         * tui/tui-source.h: Rename include guard.
730         * tui/tui-regs.h: Rename include guard.
731         * tui/tui-out.h: Rename include guard.
732         * tui/tui-layout.h: Rename include guard.
733         * tui/tui-io.h: Rename include guard.
734         * tui/tui-hooks.h: Rename include guard.
735         * tui/tui-file.h: Rename include guard.
736         * tui/tui-disasm.h: Rename include guard.
737         * tui/tui-data.h: Rename include guard.
738         * tui/tui-command.h: Rename include guard.
739         * tic6x-tdep.h: Add include guard.
740         * target/waitstatus.h: Rename include guard.
741         * target/wait.h: Rename include guard.
742         * target/target.h: Rename include guard.
743         * target/resume.h: Rename include guard.
744         * target-float.h: Rename include guard.
745         * stabsread.h: Add include guard.
746         * rs6000-tdep.h: Add include guard.
747         * riscv-fbsd-tdep.h: Add include guard.
748         * regformats/regdef.h: Rename include guard.
749         * record.h: Rename include guard.
750         * python/python.h: Rename include guard.
751         * python/python-internal.h: Rename include guard.
752         * python/py-stopevent.h: Rename include guard.
753         * python/py-ref.h: Rename include guard.
754         * python/py-record.h: Rename include guard.
755         * python/py-record-full.h: Rename include guard.
756         * python/py-record-btrace.h: Rename include guard.
757         * python/py-instruction.h: Rename include guard.
758         * python/py-events.h: Rename include guard.
759         * python/py-event.h: Rename include guard.
760         * procfs.h: Add include guard.
761         * proc-utils.h: Add include guard.
762         * p-lang.h: Add include guard.
763         * or1k-tdep.h: Rename include guard.
764         * observable.h: Rename include guard.
765         * nto-tdep.h: Rename include guard.
766         * nat/x86-linux.h: Rename include guard.
767         * nat/x86-linux-dregs.h: Rename include guard.
768         * nat/x86-gcc-cpuid.h: Add include guard.
769         * nat/x86-dregs.h: Rename include guard.
770         * nat/x86-cpuid.h: Rename include guard.
771         * nat/ppc-linux.h: Rename include guard.
772         * nat/mips-linux-watch.h: Rename include guard.
773         * nat/linux-waitpid.h: Rename include guard.
774         * nat/linux-ptrace.h: Rename include guard.
775         * nat/linux-procfs.h: Rename include guard.
776         * nat/linux-osdata.h: Rename include guard.
777         * nat/linux-nat.h: Rename include guard.
778         * nat/linux-namespaces.h: Rename include guard.
779         * nat/linux-btrace.h: Rename include guard.
780         * nat/glibc_thread_db.h: Rename include guard.
781         * nat/gdb_thread_db.h: Rename include guard.
782         * nat/gdb_ptrace.h: Rename include guard.
783         * nat/fork-inferior.h: Rename include guard.
784         * nat/amd64-linux-siginfo.h: Rename include guard.
785         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
786         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
787         * nat/aarch64-linux.h: Rename include guard.
788         * nat/aarch64-linux-hw-point.h: Rename include guard.
789         * mn10300-tdep.h: Add include guard.
790         * mips-linux-tdep.h: Add include guard.
791         * mi/mi-parse.h: Rename include guard.
792         * mi/mi-out.h: Rename include guard.
793         * mi/mi-main.h: Rename include guard.
794         * mi/mi-interp.h: Rename include guard.
795         * mi/mi-getopt.h: Rename include guard.
796         * mi/mi-console.h: Rename include guard.
797         * mi/mi-common.h: Rename include guard.
798         * mi/mi-cmds.h: Rename include guard.
799         * mi/mi-cmd-break.h: Rename include guard.
800         * m2-lang.h: Add include guard.
801         * location.h: Rename include guard.
802         * linux-record.h: Rename include guard.
803         * linux-nat.h: Add include guard.
804         * linux-fork.h: Add include guard.
805         * i386-darwin-tdep.h: Rename include guard.
806         * hppa-linux-offsets.h: Add include guard.
807         * guile/guile.h: Rename include guard.
808         * guile/guile-internal.h: Rename include guard.
809         * gnu-nat.h: Rename include guard.
810         * gdb-stabs.h: Rename include guard.
811         * frv-tdep.h: Add include guard.
812         * f-lang.h: Add include guard.
813         * event-loop.h: Add include guard.
814         * darwin-nat.h: Rename include guard.
815         * cp-abi.h: Rename include guard.
816         * config/sparc/nm-sol2.h: Rename include guard.
817         * config/nm-nto.h: Rename include guard.
818         * config/nm-linux.h: Add include guard.
819         * config/i386/nm-i386gnu.h: Rename include guard.
820         * config/djgpp/nl_types.h: Rename include guard.
821         * config/djgpp/langinfo.h: Rename include guard.
822         * compile/gcc-cp-plugin.h: Add include guard.
823         * compile/gcc-c-plugin.h: Add include guard.
824         * compile/compile.h: Rename include guard.
825         * compile/compile-object-run.h: Rename include guard.
826         * compile/compile-object-load.h: Rename include guard.
827         * compile/compile-internal.h: Rename include guard.
828         * compile/compile-cplus.h: Rename include guard.
829         * compile/compile-c.h: Rename include guard.
830         * common/xml-utils.h: Rename include guard.
831         * common/x86-xstate.h: Rename include guard.
832         * common/version.h: Rename include guard.
833         * common/vec.h: Rename include guard.
834         * common/tdesc.h: Rename include guard.
835         * common/selftest.h: Rename include guard.
836         * common/scoped_restore.h: Rename include guard.
837         * common/scoped_mmap.h: Rename include guard.
838         * common/scoped_fd.h: Rename include guard.
839         * common/safe-iterator.h: Rename include guard.
840         * common/run-time-clock.h: Rename include guard.
841         * common/refcounted-object.h: Rename include guard.
842         * common/queue.h: Rename include guard.
843         * common/ptid.h: Rename include guard.
844         * common/print-utils.h: Rename include guard.
845         * common/preprocessor.h: Rename include guard.
846         * common/pathstuff.h: Rename include guard.
847         * common/observable.h: Rename include guard.
848         * common/netstuff.h: Rename include guard.
849         * common/job-control.h: Rename include guard.
850         * common/host-defs.h: Rename include guard.
851         * common/gdb_wait.h: Rename include guard.
852         * common/gdb_vecs.h: Rename include guard.
853         * common/gdb_unlinker.h: Rename include guard.
854         * common/gdb_unique_ptr.h: Rename include guard.
855         * common/gdb_tilde_expand.h: Rename include guard.
856         * common/gdb_sys_time.h: Rename include guard.
857         * common/gdb_string_view.h: Rename include guard.
858         * common/gdb_splay_tree.h: Rename include guard.
859         * common/gdb_setjmp.h: Rename include guard.
860         * common/gdb_ref_ptr.h: Rename include guard.
861         * common/gdb_optional.h: Rename include guard.
862         * common/gdb_locale.h: Rename include guard.
863         * common/gdb_assert.h: Rename include guard.
864         * common/filtered-iterator.h: Rename include guard.
865         * common/filestuff.h: Rename include guard.
866         * common/fileio.h: Rename include guard.
867         * common/environ.h: Rename include guard.
868         * common/common-utils.h: Rename include guard.
869         * common/common-types.h: Rename include guard.
870         * common/common-regcache.h: Rename include guard.
871         * common/common-inferior.h: Rename include guard.
872         * common/common-gdbthread.h: Rename include guard.
873         * common/common-exceptions.h: Rename include guard.
874         * common/common-defs.h: Rename include guard.
875         * common/common-debug.h: Rename include guard.
876         * common/cleanups.h: Rename include guard.
877         * common/buffer.h: Rename include guard.
878         * common/btrace-common.h: Rename include guard.
879         * common/break-common.h: Rename include guard.
880         * cli/cli-utils.h: Rename include guard.
881         * cli/cli-style.h: Rename include guard.
882         * cli/cli-setshow.h: Rename include guard.
883         * cli/cli-script.h: Rename include guard.
884         * cli/cli-interp.h: Rename include guard.
885         * cli/cli-decode.h: Rename include guard.
886         * cli/cli-cmds.h: Rename include guard.
887         * charset-list.h: Add include guard.
888         * buildsym-legacy.h: Rename include guard.
889         * bfin-tdep.h: Add include guard.
890         * ax.h: Rename include guard.
891         * arm-linux-tdep.h: Add include guard.
892         * arm-fbsd-tdep.h: Add include guard.
893         * arch/xtensa.h: Rename include guard.
894         * arch/tic6x.h: Add include guard.
895         * arch/i386.h: Add include guard.
896         * arch/arm.h: Rename include guard.
897         * arch/arm-linux.h: Rename include guard.
898         * arch/arm-get-next-pcs.h: Rename include guard.
899         * arch/amd64.h: Add include guard.
900         * arch/aarch64-insn.h: Rename include guard.
901         * arch-utils.h: Rename include guard.
902         * annotate.h: Add include guard.
903         * amd64-darwin-tdep.h: Rename include guard.
904         * aarch64-linux-tdep.h: Add include guard.
905         * aarch64-fbsd-tdep.h: Add include guard.
906         * aarch32-linux-nat.h: Add include guard.
907
908 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
909
910         * macrotab.c (macro_define_internal): New function that
911         factorizes macro_define_object_internal and macro_define_function
912         code.
913         (macro_define_object_internal): Use macro_define_internal.
914         (macro_define_function): Likewise.
915
916 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
917
918         * macrocmd.c (extract_identifier): Return
919         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
920         callers.
921
922 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
923
924         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
925
926 2019-02-05  Tom Tromey  <tom@tromey.com>
927
928         * target.c (target_stack::unpush): Move assertion earlier.
929
930 2019-01-30  Tom Tromey  <tom@tromey.com>
931
932         PR python/23615:
933         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
934         (gdbpy_parse_and_eval): Likewise.
935         * python/python-internal.h (gdbpy_allow_threads): New class.
936
937 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
938
939         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
940         (aarch64_fbsd_fpregmap): Move earlier.
941         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
942         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
943         instead of individual calls to trad_frame_set_reg_addr.
944         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
945         earlier.
946         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
947         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
948         instead of individual calls to trad_frame_set_reg_addr.
949
950 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
951
952         * CONTRIBUTE: Replace contribution list with wiki link.
953
954 2019-01-25  Tom Tromey  <tom@tromey.com>
955
956         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
957
958 2019-01-25  Tom Tromey  <tom@tromey.com>
959
960         * xtensa-linux-nat.c: Fix common/ includes.
961         * xml-support.h: Fix common/ includes.
962         * xml-support.c: Fix common/ includes.
963         * x86-linux-nat.c: Fix common/ includes.
964         * windows-nat.c: Fix common/ includes.
965         * varobj.h: Fix common/ includes.
966         * varobj.c: Fix common/ includes.
967         * value.c: Fix common/ includes.
968         * valops.c: Fix common/ includes.
969         * utils.c: Fix common/ includes.
970         * unittests/xml-utils-selftests.c: Fix common/ includes.
971         * unittests/utils-selftests.c: Fix common/ includes.
972         * unittests/unpack-selftests.c: Fix common/ includes.
973         * unittests/tracepoint-selftests.c: Fix common/ includes.
974         * unittests/style-selftests.c: Fix common/ includes.
975         * unittests/string_view-selftests.c: Fix common/ includes.
976         * unittests/scoped_restore-selftests.c: Fix common/ includes.
977         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
978         * unittests/scoped_fd-selftests.c: Fix common/ includes.
979         * unittests/rsp-low-selftests.c: Fix common/ includes.
980         * unittests/parse-connection-spec-selftests.c: Fix common/
981         includes.
982         * unittests/optional-selftests.c: Fix common/ includes.
983         * unittests/offset-type-selftests.c: Fix common/ includes.
984         * unittests/observable-selftests.c: Fix common/ includes.
985         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
986         * unittests/memrange-selftests.c: Fix common/ includes.
987         * unittests/memory-map-selftests.c: Fix common/ includes.
988         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
989         * unittests/function-view-selftests.c: Fix common/ includes.
990         * unittests/environ-selftests.c: Fix common/ includes.
991         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
992         * unittests/common-utils-selftests.c: Fix common/ includes.
993         * unittests/cli-utils-selftests.c: Fix common/ includes.
994         * unittests/array-view-selftests.c: Fix common/ includes.
995         * ui-file.c: Fix common/ includes.
996         * tui/tui-io.c: Fix common/ includes.
997         * tracepoint.h: Fix common/ includes.
998         * tracepoint.c: Fix common/ includes.
999         * tracefile-tfile.c: Fix common/ includes.
1000         * top.h: Fix common/ includes.
1001         * top.c: Fix common/ includes.
1002         * thread.c: Fix common/ includes.
1003         * target/waitstatus.h: Fix common/ includes.
1004         * target/waitstatus.c: Fix common/ includes.
1005         * target.h: Fix common/ includes.
1006         * target.c: Fix common/ includes.
1007         * target-memory.c: Fix common/ includes.
1008         * target-descriptions.c: Fix common/ includes.
1009         * symtab.h: Fix common/ includes.
1010         * symfile.c: Fix common/ includes.
1011         * stap-probe.c: Fix common/ includes.
1012         * spu-linux-nat.c: Fix common/ includes.
1013         * sparc-nat.c: Fix common/ includes.
1014         * source.c: Fix common/ includes.
1015         * solib.c: Fix common/ includes.
1016         * solib-target.c: Fix common/ includes.
1017         * ser-unix.c: Fix common/ includes.
1018         * ser-tcp.c: Fix common/ includes.
1019         * ser-pipe.c: Fix common/ includes.
1020         * ser-base.c: Fix common/ includes.
1021         * selftest-arch.c: Fix common/ includes.
1022         * s12z-tdep.c: Fix common/ includes.
1023         * rust-exp.y: Fix common/ includes.
1024         * rs6000-aix-tdep.c: Fix common/ includes.
1025         * riscv-tdep.c: Fix common/ includes.
1026         * remote.c: Fix common/ includes.
1027         * remote-notif.h: Fix common/ includes.
1028         * remote-fileio.h: Fix common/ includes.
1029         * remote-fileio.c: Fix common/ includes.
1030         * regcache.h: Fix common/ includes.
1031         * regcache.c: Fix common/ includes.
1032         * record-btrace.c: Fix common/ includes.
1033         * python/python.c: Fix common/ includes.
1034         * python/py-type.c: Fix common/ includes.
1035         * python/py-inferior.c: Fix common/ includes.
1036         * progspace.h: Fix common/ includes.
1037         * producer.c: Fix common/ includes.
1038         * procfs.c: Fix common/ includes.
1039         * proc-api.c: Fix common/ includes.
1040         * printcmd.c: Fix common/ includes.
1041         * ppc-linux-nat.c: Fix common/ includes.
1042         * parser-defs.h: Fix common/ includes.
1043         * osdata.c: Fix common/ includes.
1044         * obsd-nat.c: Fix common/ includes.
1045         * nat/x86-linux.c: Fix common/ includes.
1046         * nat/x86-linux-dregs.c: Fix common/ includes.
1047         * nat/x86-dregs.h: Fix common/ includes.
1048         * nat/x86-dregs.c: Fix common/ includes.
1049         * nat/ppc-linux.c: Fix common/ includes.
1050         * nat/mips-linux-watch.h: Fix common/ includes.
1051         * nat/mips-linux-watch.c: Fix common/ includes.
1052         * nat/linux-waitpid.c: Fix common/ includes.
1053         * nat/linux-ptrace.h: Fix common/ includes.
1054         * nat/linux-ptrace.c: Fix common/ includes.
1055         * nat/linux-procfs.c: Fix common/ includes.
1056         * nat/linux-personality.c: Fix common/ includes.
1057         * nat/linux-osdata.c: Fix common/ includes.
1058         * nat/linux-namespaces.c: Fix common/ includes.
1059         * nat/linux-btrace.h: Fix common/ includes.
1060         * nat/linux-btrace.c: Fix common/ includes.
1061         * nat/fork-inferior.c: Fix common/ includes.
1062         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1063         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1064         * nat/aarch64-linux.c: Fix common/ includes.
1065         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1066         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1067         * namespace.h: Fix common/ includes.
1068         * mips-linux-tdep.c: Fix common/ includes.
1069         * minsyms.c: Fix common/ includes.
1070         * mi/mi-parse.h: Fix common/ includes.
1071         * mi/mi-main.c: Fix common/ includes.
1072         * mi/mi-cmd-env.c: Fix common/ includes.
1073         * memrange.h: Fix common/ includes.
1074         * memattr.c: Fix common/ includes.
1075         * maint.h: Fix common/ includes.
1076         * maint.c: Fix common/ includes.
1077         * main.c: Fix common/ includes.
1078         * machoread.c: Fix common/ includes.
1079         * location.c: Fix common/ includes.
1080         * linux-thread-db.c: Fix common/ includes.
1081         * linux-nat.c: Fix common/ includes.
1082         * linux-fork.c: Fix common/ includes.
1083         * inline-frame.c: Fix common/ includes.
1084         * infrun.c: Fix common/ includes.
1085         * inflow.c: Fix common/ includes.
1086         * inferior.h: Fix common/ includes.
1087         * inferior.c: Fix common/ includes.
1088         * infcmd.c: Fix common/ includes.
1089         * inf-ptrace.c: Fix common/ includes.
1090         * inf-child.c: Fix common/ includes.
1091         * ia64-linux-nat.c: Fix common/ includes.
1092         * i387-tdep.c: Fix common/ includes.
1093         * i386-tdep.c: Fix common/ includes.
1094         * i386-linux-tdep.c: Fix common/ includes.
1095         * i386-linux-nat.c: Fix common/ includes.
1096         * i386-go32-tdep.c: Fix common/ includes.
1097         * i386-fbsd-tdep.c: Fix common/ includes.
1098         * i386-fbsd-nat.c: Fix common/ includes.
1099         * guile/scm-type.c: Fix common/ includes.
1100         * guile/guile.c: Fix common/ includes.
1101         * go32-nat.c: Fix common/ includes.
1102         * gnu-nat.c: Fix common/ includes.
1103         * gdbthread.h: Fix common/ includes.
1104         * gdbarch-selftests.c: Fix common/ includes.
1105         * gdb_usleep.c: Fix common/ includes.
1106         * gdb_select.h: Fix common/ includes.
1107         * gdb_bfd.c: Fix common/ includes.
1108         * gcore.c: Fix common/ includes.
1109         * fork-child.c: Fix common/ includes.
1110         * findvar.c: Fix common/ includes.
1111         * fbsd-nat.c: Fix common/ includes.
1112         * event-top.c: Fix common/ includes.
1113         * event-loop.c: Fix common/ includes.
1114         * dwarf2read.c: Fix common/ includes.
1115         * dwarf2loc.c: Fix common/ includes.
1116         * dwarf2-frame.c: Fix common/ includes.
1117         * dwarf-index-cache.c: Fix common/ includes.
1118         * dtrace-probe.c: Fix common/ includes.
1119         * disasm-selftests.c: Fix common/ includes.
1120         * defs.h: Fix common/ includes.
1121         * csky-tdep.c: Fix common/ includes.
1122         * cp-valprint.c: Fix common/ includes.
1123         * cp-support.h: Fix common/ includes.
1124         * cp-support.c: Fix common/ includes.
1125         * corelow.c: Fix common/ includes.
1126         * completer.h: Fix common/ includes.
1127         * completer.c: Fix common/ includes.
1128         * compile/compile.c: Fix common/ includes.
1129         * compile/compile-loc2c.c: Fix common/ includes.
1130         * compile/compile-cplus-types.c: Fix common/ includes.
1131         * compile/compile-cplus-symbols.c: Fix common/ includes.
1132         * command.h: Fix common/ includes.
1133         * cli/cli-dump.c: Fix common/ includes.
1134         * cli/cli-cmds.c: Fix common/ includes.
1135         * charset.c: Fix common/ includes.
1136         * build-id.c: Fix common/ includes.
1137         * btrace.h: Fix common/ includes.
1138         * btrace.c: Fix common/ includes.
1139         * breakpoint.h: Fix common/ includes.
1140         * breakpoint.c: Fix common/ includes.
1141         * ax.h: 
1142         (enum agent_op): Fix common/ includes.
1143         * ax-general.c (struct aop_map): Fix common/ includes.
1144         * ax-gdb.c: Fix common/ includes.
1145         * auxv.c: Fix common/ includes.
1146         * auto-load.c: Fix common/ includes.
1147         * arm-tdep.c: Fix common/ includes.
1148         * arch/riscv.c: Fix common/ includes.
1149         * arch/ppc-linux-common.c: Fix common/ includes.
1150         * arch/i386.c: Fix common/ includes.
1151         * arch/arm.c: Fix common/ includes.
1152         * arch/arm-linux.c: Fix common/ includes.
1153         * arch/arm-get-next-pcs.c: Fix common/ includes.
1154         * arch/amd64.c: Fix common/ includes.
1155         * arch/aarch64.c: Fix common/ includes.
1156         * arch/aarch64-insn.c: Fix common/ includes.
1157         * arch-utils.c: Fix common/ includes.
1158         * amd64-windows-tdep.c: Fix common/ includes.
1159         * amd64-tdep.c: Fix common/ includes.
1160         * amd64-sol2-tdep.c: Fix common/ includes.
1161         * amd64-obsd-tdep.c: Fix common/ includes.
1162         * amd64-nbsd-tdep.c: Fix common/ includes.
1163         * amd64-linux-tdep.c: Fix common/ includes.
1164         * amd64-linux-nat.c: Fix common/ includes.
1165         * amd64-fbsd-tdep.c: Fix common/ includes.
1166         * amd64-fbsd-nat.c: Fix common/ includes.
1167         * amd64-dicos-tdep.c: Fix common/ includes.
1168         * amd64-darwin-tdep.c: Fix common/ includes.
1169         * agent.c: Fix common/ includes.
1170         * ada-lang.h: Fix common/ includes.
1171         * ada-lang.c: Fix common/ includes.
1172         * aarch64-tdep.c: Fix common/ includes.
1173
1174 2019-01-25  Tom Tromey  <tom@tromey.com>
1175
1176         * common/create-version.sh: Use common/version.h.
1177
1178 2019-01-24  Pedro Alves  <palves@redhat.com>
1179
1180         * infrun.c (signal_stop, signal_print, signal_program)
1181         (signal_catch, signal_pass): Now arrays instead of pointers.
1182         (update_signals_program_target, do_target_resume)
1183         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1184         * linux-nat.c (linux_nat_target::pass_signals)
1185         (linux_nat_target::create_inferior, linux_nat_target::attach):
1186         Adjust.
1187         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1188         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1189         * procfs.c (procfs_target::pass_signals): Adjust.
1190         * record-full.c (record_full_target::resume): Adjust.
1191         * remote.c (remote_target::pass_signals)
1192         (remote_target::program_signals): Adjust.
1193         * target-debug.h (target_debug_print_signals): Now takes a
1194         gdb::array_view as parameter.  Adjust.
1195         * target.h (target_ops) <pass_signals, program_signals>: Replace
1196         pointer and length parameters with gdb::array_view.
1197         (target_pass_signals, target_program_signals): Likewise.
1198         * target-delegates.c: Regenerate.
1199
1200 2019-01-24  Pedro Alves  <palves@redhat.com>
1201
1202         * common/forward-scope-exit.h
1203         (forward_scope_exit::forward_scope_exit): Pass arguments to
1204         m_bind_function directly, instead of creating a std::bind and
1205         copying that.
1206
1207 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1208
1209         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1210         for static members.
1211         (pass_in_v_vfp_candidate): Likewise.
1212
1213 2019-01-23  Tom Tromey  <tom@tromey.com>
1214             Pedro Alves  <palves@redhat.com>
1215
1216         * regcache.c (class regcache_invalidator): Remove.
1217         (regcache::raw_write): Use make_scope_exit.
1218
1219 2019-01-23  Tom Tromey  <tom@tromey.com>
1220
1221         * ui-out.h (class ui_out_emit_type): Update comment.
1222
1223 2019-01-23  Tom Tromey  <tom@tromey.com>
1224
1225         * infrun.c (fetch_inferior_event): Update comment.
1226
1227 2019-01-23  Tom Tromey  <tom@tromey.com>
1228             Pedro Alves  <palves@redhat.com>
1229
1230         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1231         parameter.
1232         (fetch_inferior_event): Use SCOPE_EXIT.
1233
1234
1235 2019-01-23  Tom Tromey  <tom@tromey.com>
1236             Pedro Alves  <palves@redhat.com>
1237
1238         * infrun.c (disable_thread_events): Delete.
1239         (stop_all_threads): Use SCOPE_EXIT.
1240
1241 2019-01-23  Tom Tromey  <tom@tromey.com>
1242             Pedro Alves  <palves@redhat.com>
1243
1244         * symfile.c: Include forward-scope-exit.h.
1245         (clear_symtab_users_cleanup): Replace forward declaration with
1246         a FORWARD_SCOPE_EXIT.
1247         (syms_from_objfile_1): Use the forward_scope_exit and
1248         gdb::optional instead of cleanup_function.
1249         (reread_symbols): Use the forward_scope_exit instead of
1250         cleanup_function.
1251         (clear_symtab_users_cleanup): Remove function.
1252
1253 2019-01-23  Tom Tromey  <tom@tromey.com>
1254             Pedro Alves  <palves@redhat.com>
1255
1256         * linux-nat.c: Include scope-exit.h.
1257         (cleanup_target_stop): Remove.
1258         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1259         SCOPE_EXIT.
1260
1261 2019-01-23  Tom Tromey  <tom@tromey.com>
1262             Pedro Alves  <palves@redhat.com>
1263
1264         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1265         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1266
1267 2019-01-23  Tom Tromey  <tom@tromey.com>
1268             Andrew Burgess  <andrew.burgess@embecosm.com>
1269             Pedro Alves  <palves@redhat.com>
1270
1271         * infrun.c (fetch_inferior_event): Use scope_exit.
1272         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1273         * top.c (execute_command): Use scope_exit.
1274         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1275         * utils.c (do_bpstat_clear_actions_cleanup)
1276         (make_bpstat_clear_actions_cleanup): Remove.
1277
1278 2019-01-23  Tom Tromey  <tom@tromey.com>
1279             Pedro Alves  <palves@redhat.com>
1280
1281         * infrun.c: Include "common/scope-exit.h"
1282         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1283         (wait_for_inferior): Use SCOPE_EXIT.
1284         (fetch_inferior_event): Use scope_exit.
1285
1286 2019-01-23  Tom Tromey  <tom@tromey.com>
1287             Pedro Alves  <palves@redhat.com>
1288
1289         * breakpoint.c (create_breakpoint): Remove cleanup.
1290
1291 2019-01-23  Tom Tromey  <tom@tromey.com>
1292             Andrew Burgess  <andrew.burgess@embecosm.com>
1293             Pedro Alves  <palves@redhat.com>
1294
1295 2019-01-23  Pedro Alves  <palves@redhat.com>
1296
1297         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1298
1299 2019-01-23  Pedro Alves  <palves@redhat.com>
1300             Andrew Burgess  <andrew.burgess@embecosm.com>
1301
1302         * gdbthread.h: Include "common/forward-scope-exit.h".
1303         (scoped_finish_thread_state): Redefine custom class in terms of
1304         forward_scope_exit.
1305
1306 2019-01-23  Pedro Alves  <palves@redhat.com>
1307             Andrew Burgess  <andrew.burgess@embecosm.com>
1308
1309         * common/forward-scope-exit.h: New file.
1310
1311 2019-01-23  Pedro Alves  <palves@redhat.com>
1312             Andrew Burgess  <andrew.burgess@embecosm.com>
1313             Tom Tromey  <tom@tromey.com>
1314
1315         * common/scope-exit.h: New file.
1316
1317 2019-01-23  Pedro Alves  <palves@redhat.com>
1318
1319         * common/preprocessor.h (ESC): Rename to ...
1320         (ESC_PARENS): ... this.
1321         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1322         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1323
1324 2019-01-23  Tom Tromey  <tom@tromey.com>
1325
1326         * language.h (class scoped_switch_to_sym_language_if_auto):
1327         Initialize m_lang in both cases.
1328
1329 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1330
1331         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1332         with XCNEW.
1333
1334 2019-01-22  Tom Tromey  <tom@tromey.com>
1335
1336         * corelow.c: Do not include sys/file.h.
1337
1338 2019-01-22  Tom Tromey  <tom@tromey.com>
1339
1340         * tui/tui-wingeneral.h: Include gdb_curses.h.
1341
1342 2019-01-22  Tom Tromey  <tom@tromey.com>
1343
1344         * source-cache.h (class source_cache) <get_source_lines,
1345         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1346
1347 2019-01-22  Tom Tromey  <tom@tromey.com>
1348
1349         * remote-fileio.h (struct remote_target): Declare.
1350
1351 2019-01-22  Tom Tromey  <tom@tromey.com>
1352
1353         * python/py-arch.c: Do not include py-ref.h.
1354         * python/py-bpevent.c: Do not include py-ref.h.
1355         * python/py-cmd.c: Do not include py-ref.h.
1356         * python/py-continueevent.c: Do not include py-ref.h.
1357         * python/py-event.h: Do not include py-ref.h.
1358         * python/py-evtregistry.c: Do not include py-ref.h.
1359         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1360         * python/py-frame.c: Do not include py-ref.h.
1361         * python/py-framefilter.c: Do not include py-ref.h.
1362         * python/py-function.c: Do not include py-ref.h.
1363         * python/py-infevents.c: Do not include py-ref.h.
1364         * python/py-linetable.c: Do not include py-ref.h.
1365         * python/py-objfile.c: Do not include py-ref.h.
1366         * python/py-param.c: Do not include py-ref.h.
1367         * python/py-prettyprint.c: Do not include py-ref.h.
1368         * python/py-progspace.c: Do not include py-ref.h.
1369         * python/py-symbol.c: Do not include py-ref.h.
1370         * python/py-symtab.c: Do not include py-ref.h.
1371         * python/py-type.c: Do not include py-ref.h.
1372         * python/py-unwind.c: Do not include py-ref.h.
1373         * python/py-utils.c: Do not include py-ref.h.
1374         * python/py-value.c: Do not include py-ref.h.
1375         * python/py-varobj.c: Do not include py-ref.h.
1376         * python/py-xmethods.c: Do not include py-ref.h.
1377         * python/python.c: Do not include py-ref.h.
1378         * varobj.c: Do not include py-ref.h.
1379
1380 2019-01-22  Tom Tromey  <tom@tromey.com>
1381
1382         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1383         keyword for bcache.
1384
1385 2019-01-22  Tom Tromey  <tom@tromey.com>
1386
1387         * compile/compile-cplus-types.c: Remove a comment by #include.
1388
1389 2019-01-22  Tom Tromey  <tom@tromey.com>
1390
1391         * compile/gcc-c-plugin.h: Include compile-internal.h.
1392
1393 2019-01-22  Tom Tromey  <tom@tromey.com>
1394
1395         * stabsread.c (EXTERN): Do not define.
1396         (symnum, next_symbol_text_func, processing_gcc_compilation)
1397         (within_function, global_sym_chain, global_stabs)
1398         (previous_stab_code, this_object_header_files)
1399         (n_this_object_header_files)
1400         (n_allocated_this_object_header_files): Define.
1401         * stabsread.h (EXTERN): Never define.  Use "extern".
1402
1403 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1404
1405         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1406         history_value.
1407
1408 2019-01-21  Tom Tromey  <tom@tromey.com>
1409
1410         * ui-out.c: Fix includes.
1411         * tui/tui-source.c: Fix includes.
1412         * target.c: Fix includes.
1413         * remote.c: Fix includes.
1414         * regcache.c: Fix includes.
1415         * python/py-block.c: Fix includes.
1416         * printcmd.c: Fix includes.
1417         * or1k-tdep.c: Fix includes.
1418         * mi/mi-main.c: Fix includes.
1419         * m32r-tdep.c: Fix includes.
1420         * csky-tdep.c: Fix includes.
1421         * compile/compile-cplus-types.c: Fix includes.
1422         * cli/cli-interp.c: Fix includes.
1423
1424 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1425
1426         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1427         for padding.
1428
1429 2019-01-16  Tom Tromey  <tom@tromey.com>
1430
1431         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1432         earlier.
1433         (struct objfile) <msymbols_range>: Move from top level.
1434         <msymbols>: New method.
1435         (class objfile_msymbols): Remove.
1436         * symtab.c (default_collect_symbol_completion_matches_break_on):
1437         Update.
1438         * symmisc.c (dump_msymbols): Update.
1439         * stabsread.c (scan_file_globals): Update.
1440         * objc-lang.c (info_selectors_command, info_classes_command)
1441         (find_methods): Update.
1442         * minsyms.c (find_solib_trampoline_target): Update.
1443         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1444         * coffread.c (coff_symfile_read): Update.
1445         * ada-lang.c (ada_lookup_simple_minsym)
1446         (ada_collect_symbol_completion_matches): Update.
1447
1448 2019-01-16  Tom Tromey  <tom@tromey.com>
1449
1450         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1451         type.  Remove no-argument constructor.
1452         <iterator::operator++>: Simplify.
1453         <begin>: Update.
1454         <end>: Use minimal_symbol_count.
1455
1456 2019-01-16  Tom Tromey  <tom@tromey.com>
1457
1458         * objfiles.h (struct objfile) <psymtabs>: New method.
1459         (class objfile_psymtabs): Remove.
1460         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1461         typedef.
1462         <range>: New method.
1463         (require_partial_symbols): Change return type.
1464         * psymtab.c (require_partial_symbols)
1465         (psym_expand_symtabs_matching): Update.
1466         * mdebugread.c (parse_partial_symbols): Update.
1467         * dbxread.c (dbx_end_psymtab): Update.
1468
1469 2019-01-15  Tom Tromey  <tom@tromey.com>
1470
1471         * symtab.c (lookup_objfile_from_block)
1472         (lookup_symbol_in_objfile_symtabs)
1473         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1474         (find_line_symtab, info_sources_command)
1475         (default_collect_symbol_completion_matches_break_on)
1476         (make_source_files_completion_list): Update.
1477         * symmisc.c (print_objfile_statistics, dump_objfile)
1478         (maintenance_print_symbols, maintenance_info_symtabs)
1479         (maintenance_check_symtabs, maintenance_info_line_tables):
1480         Update.
1481         * source.c (select_source_symtab)
1482         (forget_cached_source_info_for_objfile): Update.
1483         * objfiles.h (class objfile_compunits): Remove.
1484         (struct objfile) <compunits_range>: New typedef.
1485         (compunits): New method.
1486         * objfiles.c (objfile_relocate1): Update.
1487         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1488         * maint.c (count_symtabs_and_blocks): Update.
1489         * linespec.c (iterate_over_all_matching_symtabs): Update.
1490         * cp-support.c (add_symbol_overload_list_qualified): Update.
1491         * coffread.c (coff_symtab_read): Update.
1492         * ada-lang.c (add_nonlocal_symbols)
1493         (ada_collect_symbol_completion_matches)
1494         (ada_add_global_exceptions): Update.
1495
1496 2019-01-15  Tom Tromey  <tom@tromey.com>
1497
1498         * progspace.h (program_space) <objfiles_safe_range>: New
1499         typedef.
1500         <objfiles_safe>: New method.
1501         * objfiles.h (class all_objfiles_safe): Remove.
1502         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1503         * jit.c (jit_inferior_exit_hook): Update.
1504
1505 2019-01-17  Tom Tromey  <tom@tromey.com>
1506
1507         * progspace.h (program_space) <objfiles_range>: New typedef.
1508         <objfiles>: New method.
1509         <objfiles_head>: Rename from objfiles.
1510         (object_files): Update.
1511         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1512         * guile/scm-pretty-print.c
1513         (ppscm_find_pretty_printer_from_objfiles): Update.
1514         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1515         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1516         Update.
1517         * python/py-progspace.c (pspy_get_objfiles): Update.
1518         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1519         Update.
1520         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1521         (objfpy_lookup_objfile_by_build_id): Update.
1522         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1523         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1524         Update.
1525         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1526         (expand_symtab_containing_pc, lookup_objfile_from_block)
1527         (lookup_static_symbol, basic_lookup_transparent_type)
1528         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1529         (find_line_symtab, info_sources_command)
1530         (default_collect_symbol_completion_matches_break_on)
1531         (make_source_files_completion_list, find_main_name): Update.
1532         * symmisc.c (print_symbol_bcache_statistics)
1533         (print_objfile_statistics, maintenance_print_symbols)
1534         (maintenance_print_msymbols, maintenance_print_objfiles)
1535         (maintenance_info_symtabs, maintenance_check_symtabs)
1536         (maintenance_expand_symtabs, maintenance_info_line_tables):
1537         Update.
1538         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1539         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1540         (map_overlay_command, unmap_overlay_command)
1541         (simple_overlay_update, expand_symtabs_matching)
1542         (map_symbol_filenames): Update.
1543         * symfile-debug.c (set_debug_symfile): Update.
1544         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1545         Update.
1546         * source.c (select_source_symtab, forget_cached_source_info):
1547         Update.
1548         * solib.c (solib_read_symbols): Update.
1549         * solib-spu.c (append_ocl_sos): Update.
1550         * psymtab.c (maintenance_print_psymbols)
1551         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1552         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1553         * printcmd.c (info_symbol_command): Update.
1554         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1555         Update.
1556         * objfiles.h (class all_objfiles): Remove.
1557         * objfiles.c (have_partial_symbols, have_full_symbols)
1558         (have_minimal_symbols, qsort_cmp, update_section_map)
1559         (shared_objfile_contains_address_p)
1560         (default_iterate_over_objfiles_in_search_order): Update.
1561         * objc-lang.c (info_selectors_command, info_classes_command)
1562         (find_methods): Update.
1563         * minsyms.c (find_solib_trampoline_target): Update.
1564         * maint.c (maintenance_info_sections)
1565         (maintenance_translate_address, count_symtabs_and_blocks):
1566         Update.
1567         * main.c (captured_main_1): Update.
1568         * linux-thread-db.c (try_thread_db_load_from_pdir)
1569         (has_libpthread): Update.
1570         * linespec.c (iterate_over_all_matching_symtabs)
1571         (search_minsyms_for_name): Update.
1572         * jit.c (jit_find_objf_with_entry_addr): Update.
1573         * hppa-tdep.c (find_unwind_entry)
1574         (hppa_lookup_stub_minimal_symbol): Update.
1575         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1576         Update.
1577         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1578         (elf_gnu_ifunc_resolve_by_got): Update.
1579         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1580         * dwarf-index-write.c (save_gdb_index_command): Update.
1581         * cp-support.c (add_symbol_overload_list_qualified): Update.
1582         * breakpoint.c (create_overlay_event_breakpoint)
1583         (create_longjmp_master_breakpoint)
1584         (create_std_terminate_master_breakpoint)
1585         (create_exception_master_breakpoint): Update.
1586         * blockframe.c (find_pc_partial_function): Update.
1587         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1588         (ada_collect_symbol_completion_matches)
1589         (ada_add_global_exceptions): Update.
1590
1591 2019-01-17  Tom Tromey  <tom@tromey.com>
1592
1593         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1594         declare VEC.
1595         (solib_target_parse_libraries): Change return type.
1596         (library_list_start_segment, library_list_start_section)
1597         (library_list_end_library, library_list_start_library); Update.
1598         (solib_target_free_library_list): Remove.
1599         (solib_target_parse_libraries): Remove cleanup.  Change return
1600         type.
1601         (solib_target_current_sos): Update.
1602
1603 2019-01-17  Tom Tromey  <tromey@bapiya>
1604
1605         * valprint.c: Replace "the the" with "the".
1606         * symtab.c: Replace "the the" with "the".
1607         * solib.c: Replace "the the" with "the".
1608         * solib-dsbt.c: Replace "the the" with "the".
1609         * linespec.c: Replace "the the" with "the".
1610         * dwarf2loc.h: Replace "the the" with "the".
1611         * amd64-windows-tdep.c: Replace "the the" with "the".
1612         * aarch64-tdep.c: Replace "the the" with "the".
1613
1614 2019-01-16  Keith Seitz  <keiths@redhat.com>
1615
1616         PR gdb/23773
1617         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1618         <builder>: Rename to ..
1619         <m_builder>: ... this and make private.
1620         (dwarf2_cu::get_builder): New method.  Change all users of
1621         `builder' to use this method.
1622         (dwarf2_start_symtab): Move to ...
1623         (dwarf2_cu::start_symtab): ... here.  Update all callers
1624         (setup_type_unit_groups): Move to ...
1625         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1626         callers.
1627         (dwarf2_cu::reset_builder): New method.
1628         (process_full_compunit, process_full_type_unit): Use
1629         dwarf2_cu::reset_builder.
1630         (follow_die_offset): Record the ancestor CU if it is different
1631         from the followed DIE's CU.
1632         (follow_die_sig_1): Likewise.
1633
1634 2019-01-15  Tom Tromey  <tom@tromey.com>
1635
1636         * remote.c (class remote_state) <buf>: Now a char_vector.
1637         <buf_size>: Remove.
1638         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1639         parameter.
1640         (remote_target::getpkt_or_notif_sane_1)
1641         (remote_target::getpkt_sane)
1642         (remote_target::getpkt_or_notif_sane): Likewise.
1643         (class remote_target) <putpkt>: New overload.
1644         (remote_target::read_frame): Change type of "buf_p".  Remove
1645         sizeof_p parameter.
1646         (packet_ok): New overload.
1647         (packet_check_result): New overload.
1648         Update all uses.
1649
1650 2019-01-14  Tom Tromey  <tom@tromey.com>
1651
1652         * remote-notif.c (handle_notification, remote_notif_ack)
1653         (remote_notif_parse): Make "buf" const.
1654         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1655         const.
1656         (remote_notif_parse, remote_notif_ack, handle_notification):
1657         Likewise.
1658         * remote.c (remote_notif_stop_parse): Make "buf" const.
1659         (remote_target::remote_parse_stop_reply): Make "buf" const.
1660         (remote_notif_stop_ack): Make "buf" const.
1661
1662 2019-01-14  Tom Tromey  <tom@tromey.com>
1663
1664         * remote.c (remote_console_output): Make parameter const.
1665
1666 2019-01-14  Tom Tromey  <tom@tromey.com>
1667
1668         * target-debug.h (target_debug_print_signals): Constify.
1669         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1670         * procfs.c (procfs_target::pass_signals): Update.
1671         * linux-nat.c (linux_nat_target::pass_signals): Update.
1672         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1673         * target-delegates.c: Rebuild.
1674         * remote.c (remote_target::program_signals): Update.
1675         (remote_target::pass_signals): Update.
1676         * target.c (target_pass_signals): Constify argument.
1677         (target_program_signals): Likewise.
1678         * target.h (struct target_ops) <pass_signals, program_signals>:
1679         Constify argument.
1680         (target_pass_signals, target_program_signals): Constify argument.
1681
1682 2019-01-14  Tom Tromey  <tom@tromey.com>
1683
1684         PR tui/28819:
1685         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1686
1687 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1688
1689         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1690         field.
1691         * rs6000-tdep.c: Include reggroups.h.
1692         (IS_V_ALIAS_PSEUDOREG): Define.
1693         (rs6000_register_name): Return names for the "vX" aliases.
1694         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1695         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1696         aliases.  Call default_register_reggroup_p for all other
1697         pseudo-registers.
1698         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1699         New functions.
1700         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1701         Handle "vX" aliases.
1702         (v_alias_pseudo_register_collect): New function.
1703         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1704         (rs6000_gdbarch_init): Initialize "vX" aliases as
1705         pseudo-registers.  Restore registration of
1706         rs6000_pseudo_register_reggroup_p with
1707         set_tdesc_pseudo_register_reggroup_p.
1708
1709 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1710
1711         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1712         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1713         set_gdbarch_num_pseudo_regs.
1714
1715 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1716
1717         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1718         Remove arg prefixname, add do_set and do_show.
1719         Add member functions set_list and show_list.
1720         * cli/cli-style.c (class cli_style_option): Update accordingly.
1721         (style_set_list): Move to file scope.
1722         (style_show_list): Likewise.
1723         (set_style): Call help_list.
1724         (show_style): Call cmd_show_list.
1725         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1726         Update to use the new macro.
1727
1728 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1729
1730         * ada-lang.c (_initialize_ada_language): Expand the help text
1731         for the "catch exception" command.
1732
1733 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1734
1735         * symtab.c (matching_obj_sections): Initialize obj,
1736         declare it closer to its usage.
1737
1738 2019-01-10  Tom Tromey  <tom@tromey.com>
1739
1740         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1741         (basic_inf_threads_range): Remove.
1742         (inf_threads_range, inf_non_exited_threads_range)
1743         (safe_inf_threads_range): Use next_adapter.
1744
1745 2019-01-10  Keith Seitz  <keiths@redhat.com>
1746
1747         PR gdb/23712
1748         PR symtab/23010
1749         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1750         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1751
1752 2019-01-10  Keith Seitz  <keiths@redhat.com>
1753
1754         PR gdb/23712
1755         PR symtab/23010
1756         * dictionary.c (pending_to_vector): Remove.
1757         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1758         Remove _1 suffix, replacing functions of the same name.  Update
1759         all callers.
1760         (dict_create_hashed, dict_create_hashed_expandable)
1761         (dict_create_linear, dict_create_linear_expandable, dict_free)
1762         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1763         Make functions static.
1764
1765 2019-01-10  Keith Seitz  <keiths@redhat.com>
1766
1767         PR gdb/23712
1768         PR symtab/23010
1769         * dictionary.h (struct dictionary): Replace declaration with
1770         multidictionary.
1771         (dict_create_hashed, dict_create_hashed_expandable)
1772         (dict_create_linear, dict_create_linear_expandable)
1773         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1774         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1775         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1776         taking multidictionary argument.
1777         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1778         * block.h (struct block) <dict>: Change to multidictionary
1779         and rename `multidict'.
1780         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1781         symmisc.c: Update all dictionary references to multidictionary.
1782
1783 2019-01-10  Keith Seitz  <keiths@redhat.com>
1784
1785         PR gdb/23712
1786         PR symtab/23010
1787         * dictionary.c: Include unordered_map.
1788         (pending_to_vector): New function.
1789         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1790         Rewrite the non-"_1" functions to take vector instead
1791         of linked list.
1792         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1793         "new" _1 versions of the same name.
1794         (multidictionary): Define.
1795         (std::hash<enum language): New definition.
1796         (collate_pending_symbols_by_language, mdict_create_hashed)
1797         (mdict_create_hashed_expandable, mdict_create_linear)
1798         (mdict_create_linear_expandable, mdict_free)
1799         (find_language_dictionary, create_new_language_dictionary)
1800         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1801         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1802         (mdict_size, mdict_empty): New functions.
1803         * dictionary.h (mdict_iterator): Define.
1804
1805 2019-01-10  Pedro Alves  <palves@redhat.com>
1806
1807         * breakpoint.c (read_uploaded_action)
1808         (create_tracepoint_from_upload): Adjust to use
1809         gdb::unique_xmalloc_ptr.
1810         * ctf.c (ctf_write_uploaded_tp):
1811         (SET_ARRAY_FIELD): Use emplace_back.
1812         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1813         * tracefile-tfile.c (tfile_write_uploaded_tp):
1814         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1815         gdb::unique_xmalloc_ptr.
1816         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1817         at_string, cond_string, cmd_strings>: Replace char pointers
1818         with gdb::unique_xmalloc_ptr.
1819
1820 2019-01-10  Pedro Alves  <palves@redhat.com>
1821
1822         * solib-target.c (library_list_start_library): Don't xstrdup name.
1823
1824 2019-01-10  Pedro Alves  <palves@redhat.com>
1825
1826         * mdebugread.c (parse_partial_symbols): Use
1827         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1828
1829 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1830
1831         * linux-fork.c (scoped_switch_fork_info)
1832         <~scoped_switch_fork_info>: Fix incorrect variable name.
1833
1834 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1835
1836         * linux-fork.c (scoped_switch_fork_info)
1837         <scoped_switch_fork_info>: Make explicit.
1838         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1839
1840 2019-01-10  Tom Tromey  <tom@tromey.com>
1841
1842         * objfiles.h (objfile::reset_psymtabs): Update.
1843         * objfiles.c (objfile::objfile): Update.
1844         * psymtab.h (psymtab_storage::obstack): Update.
1845         (psymtab_storage::m_obstack): Use gdb::optional.
1846         (class psymtab_storage): Update comment.  Remove objfile
1847         parameter.
1848         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1849
1850 2019-01-10  Tom Tromey  <tom@tromey.com>
1851
1852         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1853         <free_psymtabs>: Now private.
1854         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1855         (allocate_psymtab): Use new method.
1856
1857 2019-01-10  Tom Tromey  <tom@tromey.com>
1858
1859         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1860         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1861         * mdebugread.c (parse_partial_symbols): Use
1862         allocate_dependencies.
1863         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1864         allocate_dependencies.
1865         (process_psymtab_comp_unit_reader)
1866         (build_type_psymtab_dependencies): Likewise.
1867         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1868
1869 2019-01-10  Tom Tromey  <tom@tromey.com>
1870
1871         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1872         PSYMBOL_SET_LANGUAGE.
1873         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1874
1875 2019-01-10  Tom Tromey  <tom@tromey.com>
1876
1877         * psymtab.h (psymtab_storage::obstack): New method.
1878         <m_obstack>: Rename from obstack; now private.
1879         * psymtab.c (psymtab_storage): Update.
1880         * dwarf2read.c (create_addrmap_from_index)
1881         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1882         Update.
1883
1884 2019-01-10  Tom Tromey  <tom@tromey.com>
1885
1886         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1887         * objfiles.h (objfile::reset_psymtabs): New method.
1888
1889 2019-01-10  Tom Tromey  <tom@tromey.com>
1890
1891         * symmisc.c (print_symbol_bcache_statistics): Update.
1892         (print_objfile_statistics): Update.
1893         * symfile.c (reread_symbols): Update.
1894         * psymtab.h (class psymtab_storage): New.
1895         * psymtab.c (psymtab_storage): New constructor.
1896         (~psymtab_storage): New destructor.
1897         (require_partial_symbols): Update.
1898         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1899         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1900         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1901         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1902         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1903         (start_psymtab_common, end_psymtab_common)
1904         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1905         (allocate_psymtab): Update.
1906         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1907         Update.
1908         (dump_psymtab_addrmap, maintenance_print_psymbols)
1909         (maintenance_check_psymtabs): Update.
1910         (class objfile_psymtabs): Move to objfiles.h.
1911         * psympriv.h (discard_psymtab): Now inline.
1912         (psymtab_discarder::psymtab_discarder): Update.
1913         (psymtab_discarder::~psymtab_discarder): Update.
1914         (ALL_OBJFILE_PSYMTABS): Rewrite.
1915         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1916         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1917         Remove fields.
1918         <partial_symtabs>: New field.
1919         (class objfile_psymtabs): Move from psymtab.h.  Update.
1920         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1921         psymbol_cache.
1922         (objfile::~objfile): Don't destroy psymbol_cache.
1923         * mdebugread.c (parse_partial_symbols): Update.
1924         * dwarf2read.c (create_addrmap_from_index)
1925         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1926         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1927         (add_partial_subprogram, dwarf2_ranges_read): Update.
1928         * dwarf-index-write.c (write_address_map)
1929         (write_one_signatured_type, recursively_write_psymbols)
1930         (class debug_names, class debug_names, write_psymtabs_to_index):
1931         Update.
1932
1933 2019-01-10  Tom Tromey  <tom@tromey.com>
1934
1935         * symtab.h (SYMBOL_SET_NAMES): Update.
1936         (symbol_set_names): Update.
1937         (MSYMBOL_SET_NAMES): Update.
1938         * symtab.c (symbol_set_names): Change argument to be an
1939         objfile_per_bfd_storage.
1940         * psymtab.c (add_psymbol_to_bcache): Update.
1941         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1942
1943 2019-01-10  Tom Tromey  <tom@tromey.com>
1944
1945         * symtab.c (create_demangled_names_hash): Change argument to be an
1946         objfile_per_bfd_storage.
1947         (symbol_set_names): Update.
1948
1949 2019-01-10  Tom Tromey  <tom@tromey.com>
1950
1951         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1952         init_psymbol_list.
1953         * psymtab.c (init_psymbol_list): Do nothing if already called.
1954         * psympriv.h (init_psymbol_list): Add comment.
1955         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1956         init_psymbol_list.
1957         * dbxread.c (dbx_symfile_read): Unconditionally call
1958         init_psymbol_list.
1959
1960 2019-01-10  Tom Tromey  <tom@tromey.com>
1961
1962         * xcoffread.c (scan_xcoff_symtab): Update.
1963         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1964         "where".
1965         * mdebugread.c (parse_partial_symbols)
1966         (handle_psymbol_enumerators): Update.
1967         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1968         * dbxread.c (read_dbx_symtab): Update.
1969         * psympriv.h (psymbol_placement): New enum.
1970         (add_psymbol_to_list): Update.
1971
1972 2019-01-10  Tom Tromey  <tom@tromey.com>
1973
1974         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1975         static_psymbols parameters.
1976         (scan_xcoff_symtab): Update.
1977         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1978         static_psymbols parameters.
1979         * psympriv.h (start_psymtab_common): Update.
1980         * mdebugread.c (parse_partial_symbols): Update.
1981         * dwarf2read.c (create_partial_symtab): Update.
1982         * dbxread.c (read_dbx_symtab): Update.
1983         (start_psymtab): Remove global_psymbols and static_psymbols
1984         parameters.
1985
1986 2019-01-10  Tom Tromey  <tom@tromey.com>
1987
1988         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1989         * psymtab.c (allocate_psymtab): Add comment.
1990         * psympriv.h (allocate_psymtab): Add comment.
1991         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1992         initializations.
1993         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1994
1995 2019-01-10  Tom Tromey  <tom@tromey.com>
1996
1997         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1998         Don't declare.
1999         * mipsread.c: Include mdebugread.h.
2000         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2001         Declare.
2002         * elfread.c: Include mdebugread.h.
2003
2004 2019-01-09  Tom Tromey  <tom@tromey.com>
2005
2006         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2007         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2008         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2009         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2010         (psym_lookup_symbol, psym_find_last_source_symtab)
2011         (psym_forget_cached_source_info, psym_print_stats)
2012         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2013         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2014         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2015         (psym_find_compunit_symtab_by_address)
2016         (maintenance_print_psymbols, maintenance_info_psymtabs)
2017         (maintenance_check_psymtabs): Use ranged for.
2018         * psymtab.h (class objfile_psymtabs): New.
2019         (require_partial_symbols): Return objfile_psymtabs.
2020         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2021
2022 2019-01-09  Tom Tromey  <tom@tromey.com>
2023
2024         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2025         (find_pc_mapped_section, list_overlays_command)
2026         (map_overlay_command, unmap_overlay_command)
2027         (simple_overlay_update): Use all_objfiles.
2028         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2029         * printcmd.c (info_symbol_command): Use all_objfiles.
2030         * objfiles.h (ALL_OBJSECTIONS): Remove.
2031         * maint.c (maintenance_translate_address): Use all_objfiles.
2032         * gcore.c (gcore_create_callback): Use all_objfiles.
2033         (objfile_find_memory_regions): Likewise.
2034
2035 2019-01-09  Tom Tromey  <tom@tromey.com>
2036
2037         * symtab.c (find_line_symtab, info_sources_command)
2038         (make_source_files_completion_list): Use objfile_compunits.
2039         * source.c (select_source_symtab): Use objfile_compunits.
2040         * objfiles.h (struct objfile): Update comment.
2041         (ALL_OBJFILES): Remove.
2042         (ALL_FILETABS): Remove.
2043         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2044         objfile_compunits.
2045
2046 2019-01-09  Tom Tromey  <tom@tromey.com>
2047
2048         * symmisc.c (print_objfile_statistics, dump_objfile)
2049         (maintenance_print_symbols): Use compunit_filetabs.
2050         * source.c (forget_cached_source_info_for_objfile): Use
2051         compunit_filetabs.
2052         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2053         (ALL_FILETABS): Use compunit_filetabs.
2054         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2055         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2056
2057 2019-01-09  Tom Tromey  <tom@tromey.com>
2058
2059         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2060         (compunit_filetabs): New.
2061         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2062         compunit_filetabs.
2063         (info_sources_command, make_source_files_completion_list): Remove
2064         declaration.
2065         * symmisc.c (print_objfile_statistics, dump_objfile)
2066         (maintenance_print_symbols): Remove declaration.
2067         (maintenance_info_symtabs): Use compunit_filetabs.
2068         (maintenance_info_line_tables): Likewise.
2069         * source.c (select_source_symtab): Change local variable name.
2070         (forget_cached_source_info_for_objfile): Remove declaration.
2071         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2072         * objfiles.c (objfile_relocate1): Remove declaration.
2073         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2074         declaration.
2075         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2076         * coffread.c (coff_symtab_read): Remove declaration.
2077         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2078         compunit_filetabs.
2079
2080 2019-01-09  Tom Tromey  <tom@tromey.com>
2081
2082         * symtab.c (lookup_objfile_from_block)
2083         (find_pc_sect_compunit_symtab, search_symbols)
2084         (default_collect_symbol_completion_matches_break_on): Use
2085         objfile_compunits.
2086         * objfiles.h (ALL_COMPUNITS): Remove.
2087         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2088         * cp-support.c (add_symbol_overload_list_qualified): Use
2089         objfile_compunits.
2090         * ada-lang.c (ada_collect_symbol_completion_matches)
2091         (ada_add_global_exceptions): Use objfile_compunits.
2092
2093 2019-01-09  Tom Tromey  <tom@tromey.com>
2094
2095         * source.c (select_source_symtab)
2096         (forget_cached_source_info_for_objfile): Remove declaration.
2097         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2098         declaration.
2099         * maint.c (count_symtabs_and_blocks): Remove declaration.
2100         * cp-support.c (add_symbol_overload_list_qualified): Remove
2101         declaration.
2102         * coffread.c (coff_symtab_read): Remove declaration.
2103         * symtab.c (lookup_symbol_in_objfile_symtabs)
2104         (basic_lookup_transparent_type_1): Use objfile_compunits.
2105         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2106         (info_sources_command, search_symbols)
2107         (default_collect_symbol_completion_matches_break_on)
2108         (make_source_files_completion_list): Remove declaration.
2109         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2110         (ada_collect_symbol_completion_matches)
2111         (ada_add_global_exceptions): Remove declaration.
2112         * linespec.c (iterate_over_all_matching_symtabs): Use
2113         objfile_compunits.
2114         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2115         (class objfile_compunits): New.
2116         (ALL_COMPUNITS): Use objfile_compunits.
2117         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2118         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2119         objfile_compunits.
2120         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2121
2122 2019-01-09  Tom Tromey  <tom@tromey.com>
2123
2124         * symtab.c (search_symbols)
2125         (default_collect_symbol_completion_matches_break_on): Use
2126         objfile_msymbols.
2127         * ada-lang.c (ada_lookup_simple_minsym)
2128         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2129         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2130         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2131         objfile_msymbols.
2132         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2133         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2134         * objc-lang.c (find_methods): Use objfile_msymbols.
2135         (info_selectors_command, info_classes_command): Likewise.
2136         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2137         * objfiles.h (class objfile_msymbols): New.
2138         (ALL_OBJFILE_MSYMBOLS): Remove.
2139         (ALL_MSYMBOLS): Remove.
2140
2141 2019-01-09  Tom Tromey  <tom@tromey.com>
2142
2143         * common/next-iterator.h (next_adapter): Add Iterator template
2144         parameter.
2145         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2146         (class all_objfiles_safe): New.
2147         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2148         * objfiles.c (put_objfile_before): Update comment.
2149         (add_separate_debug_objfile): Likewise.
2150         (free_all_objfiles): Use all_objfiles_safe.
2151         (objfile_purge_solibs): Likewise.
2152
2153 2019-01-09  Tom Tromey  <tom@tromey.com>
2154
2155         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2156         (expand_symtab_containing_pc, lookup_static_symbol)
2157         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2158         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2159         all_objfiles.
2160         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2161         * breakpoint.c (create_overlay_event_breakpoint)
2162         (create_longjmp_master_breakpoint)
2163         (create_std_terminate_master_breakpoint)
2164         (create_exception_master_breakpoint): Use all_objfiles.
2165         * linux-thread-db.c (try_thread_db_load_from_pdir)
2166         (has_libpthread): Use all_objfiles.
2167         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2168         * linespec.c (iterate_over_all_matching_symtabs)
2169         (search_minsyms_for_name): Use all_objfiles.
2170         * maint.c (maintenance_info_sections): Use all_objfiles.
2171         * main.c (captured_main_1): Use all_objfiles.
2172         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2173         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2174         * guile/scm-pretty-print.c
2175         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2176         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2177         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2178         (maintenance_print_msymbols): Use all_objfiles.
2179         * source.c (select_source_symtab): Use all_objfiles.
2180         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2181         * symfile.c (remove_symbol_file_command)
2182         (expand_symtabs_matching, map_symbol_filenames): Use
2183         all_objfiles.
2184         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2185         all_objfiles.
2186         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2187         * objc-lang.c (find_methods): Use all_objfiles.
2188         * objfiles.c (have_partial_symbols, have_full_symbols)
2189         (have_minimal_symbols, qsort_cmp)
2190         (default_iterate_over_objfiles_in_search_order): Use
2191         all_objfiles.
2192         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2193         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2194         (maintenance_check_psymtabs): Use all_objfiles.
2195         (ALL_PSYMTABS): Remove.
2196         * compile/compile-object-run.c (do_module_cleanup): Use
2197         all_objfiles.
2198         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2199         * cp-support.c (add_symbol_overload_list_qualified): Use
2200         all_objfiles.
2201         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2202         Use all_objfiles.
2203         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2204         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2205         all_objfiles.
2206         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2207         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2208         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2209         Uses all_objfiles.
2210         * solib.c (solib_read_symbols): Use all_objfiles
2211
2212 2019-01-09  Tom Tromey  <tom@tromey.com>
2213
2214         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2215         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2216         all_objfiles.
2217         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2218         * symmisc.c (print_symbol_bcache_statistics)
2219         (print_objfile_statistics, maintenance_print_objfiles)
2220         (maintenance_info_symtabs, maintenance_check_symtabs)
2221         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2222         all_objfiles.
2223         * source.c (forget_cached_source_info): Use all_objfiles.
2224         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2225         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2226         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2227         * objfiles.c (update_section_map): Use all_objfiles.
2228         (shared_objfile_contains_address_p): Likewise.
2229         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2230         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2231
2232 2019-01-09  Tom Tromey  <tom@tromey.com>
2233
2234         * common/next-iterator.h: New file.
2235         * objfiles.h (class all_objfiles): New.
2236         (struct objfile_iterator): New.
2237
2238 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2239
2240         * NEWS: Move the description of the changed "frame", "select-frame",
2241          and "info frame" commands to the Changed commands section.
2242
2243 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2244
2245         * gdbtypes.c (check_stub_method_group): Remove handling of old
2246         mangling schemes.
2247         * linespec.c (find_methods): Likewise.
2248         * stabsread.c (read_member_functions): Likewise.
2249         * valops.c (search_struct_method): Likewise.
2250         (value_struct_elt_for_reference): Likewise.
2251         * NEWS: Mention this change.
2252
2253 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2254
2255         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2256         print_source_lines.
2257         * source.c (print_source_lines_base): Update line number check.
2258         (print_source_lines): New function.
2259         (source_lines_range::source_lines_range): New function.
2260         * source.h (class source_lines_range): New class.
2261         (print_source_lines): New declaration.
2262
2263 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2264
2265         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2266
2267 2019-01-08  Tom Tromey  <tom@tromey.com>
2268             Simon Marchi  <simon.marchi@ericsson.com>
2269
2270         PR gdb/24060
2271         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2272         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2273         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2274         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2275         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2276         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2277
2278 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2279
2280         * source.c (select_source_symtab): Move header comment to
2281         declaration in source.h.
2282         (forget_cached_source_info_for_objfile): Likewise.
2283         (forget_cached_source_info): Likewise.
2284         (identify_source_line): Likewise.
2285         * source.h (identify_source_line): Move declaration from symtab.h
2286         and add comment from source.c
2287         (print_source_lines): Likewise.
2288         (forget_cached_source_info_for_objfile): Likewise.
2289         (forget_cached_source_info): Likewise.
2290         (select_source_symtab): Likewise.
2291         (enum print_source_lines_flag): Move definition from symtab.h.
2292         * symtab.h (identify_source_line): Move declaration to source.h.
2293         (print_source_lines): Likewise.
2294         (forget_cached_source_info_for_objfile): Likewise.
2295         (forget_cached_source_info): Likewise.
2296         (select_source_symtab): Likewise.
2297         (enum print_source_lines_flag): Move definition to source.h.
2298         * tui/tui-hooks.c: Add 'source.h' include.
2299
2300 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2301
2302         * source.c (print_source_lines_base): Handle requests to print
2303         reverse line number sequences, and guard against empty lines
2304         string.
2305
2306 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2307
2308         * source.c (print_source_lines_base): Fix skip of '\r' if next
2309         character is '\n'.
2310
2311 2019-01-06  Tom Tromey  <tom@tromey.com>
2312
2313         * c-exp.y (struct c_parse_state) <macro_original_text,
2314         expansion_obstack>: New member.
2315         (macro_original_text, expansion_obstack): Remove globals.
2316         (scan_macro_expansion, scanning_macro_expansion)
2317         (finished_macro_expansion): Update.
2318         (scan_macro_cleanup): Remove.
2319         (yylex, c_parse): Update.
2320
2321 2019-01-06  Tom Tromey  <tom@tromey.com>
2322
2323         * c-exp.y (struct c_parse_state) <strings>: New member.
2324         (operator_stoken): Update.
2325
2326 2019-01-06  Tom Tromey  <tom@tromey.com>
2327
2328         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2329         (union type_stack_elt) <typelist_val>: Now a pointer to
2330         std::vector.
2331         (type_stack_cleanup): Don't declare.
2332         (push_typelist): Update.
2333         * parse.c (pop_typelist): Return a std::vector.
2334         (push_typelist): Take a std::vector.
2335         (follow_types): Update.  Do not free args.
2336         (type_stack_cleanup): Remove.
2337         * c-exp.y (struct c_parse_state): New.
2338         (cpstate): New global.
2339         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2340         (nonempty_typelist): Update.
2341         (func_mod): Create a new vector.
2342         (c_parse): Create a c_parse_state.
2343         (check_parameter_typelist): Do not delete params.
2344         (function_method): Update.  Do not delete type_list.
2345
2346 2019-01-06  Tom Tromey  <tom@tromey.com>
2347
2348         PR gdb/28155:
2349         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2350         check_typedef.
2351         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2352         (print_return_value): Likewise.
2353
2354 2019-01-05  Tom Tromey  <tom@tromey.com>
2355
2356         * contrib/cleanup_check.py: Remove.
2357         * contrib/gcc-with-excheck: Remove.
2358         * contrib/exsummary.py: Remove.
2359         * contrib/excheck.py: Remove.
2360
2361 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2362
2363         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2364         NULL. Initialize tpprev to NULL instead of assigning it
2365         to NULL on the next statement.
2366         * windows-nat.c (windows_delete_thread): Remove check for
2367         main_thread_id before printing thread exit notifications.
2368         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2369         Remove thread ID check against main_thread_id.
2370         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2371         windows_delete_thread.
2372         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2373
2374 2019-01-04  Tom Tromey  <tom@tromey.com>
2375
2376         * compile/compile.c (_initialize_compile): Use upper case for
2377         metasyntactic variables.
2378         * symmisc.c (_initialize_symmisc): Use upper case for
2379         metasyntactic variables.
2380         * psymtab.c (_initialize_psymtab): Use upper case for
2381         metasyntactic variables.
2382         * demangle.c (demangle_command): Use upper case for metasyntactic
2383         variables.
2384         (_initialize_demangler): Likewise.
2385         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2386         variables.
2387
2388 2019-01-03  Tom Tromey  <tom@tromey.com>
2389
2390         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2391
2392 2019-01-03  Tom Tromey  <tom@tromey.com>
2393
2394         * python/py-symtab.c (salpy_str): Update.
2395         (struct salpy_sal_object) <symtab>: Now a PyObject.
2396         (salpy_dealloc): Update.
2397         (del_objfile_sal): Use gdbpy_ref.
2398
2399 2019-01-03  Tom Tromey  <tom@tromey.com>
2400
2401         * python/py-type.c (convert_field): Use new_reference.  Return
2402         gdbpy_ref.
2403         (make_fielditem): Return gdbpy_ref.
2404         (typy_fields): Update.
2405         (typy_getitem): Update.
2406         (field_name): Return gdbpy_ref.  Use new_reference.
2407         (typy_iterator_iternext): Update.
2408
2409 2019-01-03  Tom Tromey  <tom@tromey.com>
2410
2411         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2412
2413 2019-01-03  Tom Tromey  <tom@tromey.com>
2414
2415         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2416         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2417         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2418         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2419         (pspy_set_type_printers): Likewise.
2420         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2421         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2422         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2423         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2424         (objfpy_set_type_printers): Likewise.
2425
2426 2019-01-03  Tom Tromey  <tom@tromey.com>
2427
2428         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2429         (gdbpy_print_stack): Use gdbpy_err_fetch.
2430         * python/python-internal.h (class gdbpy_err_fetch): New class.
2431         (class gdbpy_enter) <m_error_type, m_error_value,
2432         m_error_traceback>: Remove.
2433         <m_error>: New member.
2434         (gdbpy_exception_to_string): Don't declare.
2435         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2436         * python/py-value.c (convert_value_from_python): Use
2437         gdbpy_err_fetch.
2438         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2439         gdbpy_exception_to_string.
2440         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2441         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2442         gdbpy_err_fetch.
2443
2444 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2445
2446         * linux-nat.c (delete_lwp_cleanup): Delete.
2447         (struct lwp_deleter): New struct.
2448         (lwp_info_up): New typedef.
2449         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2450         lwp_info_up.
2451
2452 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2453
2454         * linux-fork.c (class scoped_switch_fork_info): New class.
2455         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2456
2457 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2458
2459         * valops.c (find_overload_match): Remove use of null_cleanup, and
2460         calls to do_cleanups.
2461
2462 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2463
2464         * compile/compile-cplus-types.c
2465         (compile_cplus_instance::decl_name): Handle changes to
2466         cp_func_name.
2467         * cp-support.c (cp_func_name): Update header comment, update
2468         return type.
2469         * cp-support.h (cp_func_name): Update return type in declaration.
2470         * valops.c (find_overload_match): Move temp_func local to top
2471         level of function and change its type.  Use temp_func to hold and
2472         delete temporary string obtained from cp_func_name.
2473
2474 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2475
2476         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2477         gdb::char_vector, remove cleanup, and update uses of `msg`.
2478
2479 2019-01-03  Jim Wilson  <jimw@sifive.com>
2480
2481         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2482
2483 2019-01-02  Tom Tromey  <tom@tromey.com>
2484
2485         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2486         (tdesc_parse_xml): Remove cleanups.
2487         * target-descriptions.h (make_cleanup_free_target_description):
2488         Don't declare.
2489         (target_desc_deleter): New struct.
2490         (target_desc_up): New typedef.
2491         * target-descriptions.c (target_desc_deleter::operator()): Rename
2492         from free_target_description.
2493         (make_cleanup_free_target_description): Remove.
2494
2495 2019-01-02  Tom Tromey  <tom@tromey.com>
2496
2497         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2498         constructor, destructor.
2499         (linespec_parser): Remove typedef.
2500         (~linespec_parser): Rename from linespec_parser_delete.
2501         (linespec_lex_to_end, linespec_complete_label)
2502         (linespec_complete): Update.
2503         (decode_line_full): Remove cleanups.
2504         (decode_line_1): Update.
2505
2506 2019-01-02  Tom Tromey  <tom@tromey.com>
2507
2508         * python/python-internal.h (inferior_to_inferior_object): Change
2509         return type.
2510         * python/py-exitedevent.c (create_exited_event_object): Update.
2511         * python/py-inferior.c (inferior_to_inferior_object): Return
2512         gdbpy_ref.
2513         (python_new_inferior, python_inferior_deleted)
2514         (thread_to_thread_object, delete_thread_object)
2515         (build_inferior_list, gdbpy_selected_inferior): Update.
2516         * python/py-infthread.c (create_thread_object): Update.  Also fail
2517         if inferior_to_inferior_object fails.
2518
2519 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2520
2521         * inferior.h (class inferior) <displaced_step_state>: New field.
2522         * infrun.h (struct displaced_step_state): Move here from
2523         infrun.c.  Initialize fields, add constructor.
2524         <inf>: Remove field.
2525         <reset>: New method.
2526         * infrun.c (struct displaced_step_inferior_state): Move to
2527         infrun.h.
2528         (displaced_step_inferior_states): Remove.
2529         (get_displaced_stepping_state): Adust.
2530         (displaced_step_in_progress_any_inferior): Adjust.
2531         (displaced_step_in_progress_thread): Adjust.
2532         (displaced_step_in_progress): Adjust.
2533         (add_displaced_stepping_state): Remove.
2534         (get_displaced_step_closure_by_addr): Adjust.
2535         (remove_displaced_stepping_state): Remove.
2536         (infrun_inferior_exit): Call displaced_step_state.reset.
2537         (use_displaced_stepping): Don't check for NULL.
2538         (displaced_step_prepare_throw): Call
2539         get_displaced_stepping_state.
2540         (displaced_step_fixup): Don't check for NULL.
2541         (prepare_for_detach): Don't check for NULL.
2542
2543 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2544
2545         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2546          in case of call that did not complete.
2547
2548 2019-01-02  Andrey Utkin  <autkin@undo.io>
2549
2550         * symfile.c (find_separate_debug_file): Fix search of debug files for
2551         remote debuggee.
2552
2553 2019-01-02  Tom Tromey  <tom@tromey.com>
2554
2555         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2556         indentation.
2557         * python/py-frame.c (frapy_older): Remove cast.
2558         (frapy_newer): Likewise.
2559         * python/py-breakpoint.c (local_setattro): Remove cast.
2560         * python/py-arch.c (archpy_name): Remove local variable.
2561         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2562
2563 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2564
2565         * unittests/basic_string_view/element_access/char/empty.cc:
2566         Fix year range in copyright header.
2567
2568 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2569
2570         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2571         Delete.
2572         <operator==>: Update with for removed field.
2573         <hash>: Likewise.
2574         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2575         <isa_features>: ...this.
2576         <abi_features>: New field.
2577         (riscv_isa_flen): Update comment.
2578         (riscv_abi_xlen): New declaration.
2579         (riscv_abi_flen): New declaration.
2580         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2581         isa_features.
2582         (riscv_abi_xlen): New function.
2583         (riscv_isa_flen): Update to get answer from isa_features.
2584         (riscv_abi_flen): New function.
2585         (riscv_has_fp_abi): Update to get answer from abi_features.
2586         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2587         xlen and flen.
2588         (riscv_call_info) <xlen, flen>: Update comment.
2589         (riscv_call_arg_struct): Remove invalid assertions
2590         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2591         is removed.
2592         (riscv_gdbarch_init): Gather isa features and abi features
2593         separately, ensure both match on the gdbarch when reusing an old
2594         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2595         a target with 64-bit float hardware.
2596
2597 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2598
2599         * source.c (search_command_helper): Stop reverse search
2600         when line 1 has been searched.
2601
2602 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2603
2604         * record-full.c (record_full_base_target::close): Rewrite
2605         record_full_core_buf_list free logic.
2606
2607 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2608
2609         * break-catch-syscall.c (print_one_catch_syscall): xfree
2610         the last text.
2611
2612 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2613
2614         * top.c (print_gdb_version): Update Copyright year in version
2615         message.
2616
2617 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2618
2619         Update copyright year range in all GDB files.
2620
2621 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2622
2623         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2624
2625 For older changes see ChangeLog-2018.
2626 \f
2627 Local Variables:
2628 mode: change-log
2629 left-margin: 8
2630 fill-column: 74
2631 version-control: never
2632 coding: utf-8
2633 End:
2634