Remove some uses of "object_files"
[external/binutils.git] / gdb / ChangeLog
1 2019-04-10  Tom Tromey  <tom@tromey.com>
2
3         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4         * minsyms.c (lookup_minimal_symbol): Use foreach.
5         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6         (lookup_minimal_symbol_solib_trampoline): Likewise.
7         * symfile.c (reread_symbols): Use foreach.
8
9 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
10             Tom Tromey  <tromey@adacore.com>
11
12         PR rust/24414:
13         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
14         (rust_lex_int_test): Change "value" to be LONGEST.
15         (rust_lex_tests): Add test for long integer literal.
16
17 2019-04-09  Tom Tromey  <tromey@adacore.com>
18
19         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
20         to bool.
21         (extended_remote_target::attach): Update.
22         (remote_target::remote_notice_new_inferior): Update.
23         (remote_target::add_current_inferior_and_thread): Update.
24         * inferior.c (exit_inferior_1): Use "false".
25         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
26
27 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
28
29         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
30         the "start" command.
31
32 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
33
34         * python/py-inferior.c (infpy_thread_from_thread_handle):
35         Adjust comments to reflect renaming of thread_from_thread_handle
36         to thread_from_handle.  Adjust keywords.  Fix type error message.
37         (inferior_object_methods): Add thread_from_handle.  Retain
38         thread_from_thread_handle, but mark it as deprecated.
39
40 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
41
42         * gdbthread.h (find_thread_by_handle): Revise declaration.
43         * thread.c (find_thread_by_handle): Likewise.  Adjust
44         implementation too.
45         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
46         support for buffer objects as handles.
47
48 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
49
50         * python/py-infthread.c (thpy_thread_handle): New function.
51         (thread_object_methods): Register thpy_thread_handle.
52
53 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
54
55         * gdbthread.h (thread_to_thread_handle): Declare.
56         * thread.c (gdbtypes.h): Include.
57         (thread_to_thread_handle): New function.
58
59         * target.h (struct target_ops): Add thread_info_to_thread_handle.
60         (target_thread_info_to_thread_handle): Declare.
61         * target.c (target_thread_info_to_thread_handle): New function.
62         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
63         * target-delegates.c: Regenerate.
64
65         * linux-thread-db.c (class thread_db_target): Add method
66         thread_info_to_thread_handle.
67         (thread_db_target::thread_info_to_thread_handle): Define.
68         * remote.c (class remote_target): Add new method
69         thread_info_to_thread_handle.
70         (remote_target::thread_info_to_thread_handle): Define.
71
72 2019-04-08  Pedro Alves  <palves@redhat.com>
73
74         * common/common-exceptions.c (throw_exception): Don't create
75         named object to throw; throw directly.
76         (throw_it): Likewise.  Don't initialize gdb_exception::message
77         here, with new; pass FMT and AP to the ctor instead.
78         * common/common-exceptions.h: Include <string>.
79         (gdb_exception::gdb_exception(enum return_reason, enum errors,
80         const char *, va_list)): New ctor.  Use std::make_shared.
81         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
82         errors)): Delete.
83         (gdb_exception_error::gdb_exception_error(enum errors, const char
84         *, va_list)): New.
85         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
86         Add assertion.
87         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
88         errors)): Delete.
89         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
90         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
91         Add assertion.
92
93 2019-04-08  Tom Tromey  <tom@tromey.com>
94
95         * valops.c (value_rtti_indirect_type): Replace throw_exception
96         with throw.
97         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
98         with throw.
99         * thread.c (thr_try_catch_cmd): Replace throw_exception with
100         throw.
101         * target.c (target_translate_tls_address): Replace throw_exception
102         with throw.
103         * stack.c (frame_apply_command_count): Replace throw_exception
104         with throw.
105         * solib-spu.c (append_ocl_sos): Replace throw_exception with
106         throw.
107         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
108         with throw.
109         * rs6000-tdep.c (rs6000_frame_cache)
110         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
111         * remote.c: Replace throw_exception with throw.
112         * record-full.c (record_full_message, record_full_wait_1)
113         (record_full_restore): Replace throw_exception with throw.
114         * record-btrace.c:
115         (get_thread_current_frame_id, record_btrace_start_replaying)
116         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
117         (cmd_record_btrace_start): Replace throw_exception with throw.
118         * parse.c (parse_exp_in_context_1): Replace throw_exception with
119         throw.
120         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
121         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
122         * linespec.c:
123         (find_linespec_symbols): Replace throw_exception with throw.
124         * infrun.c (displaced_step_prepare, resume): Replace
125         throw_exception with throw.
126         * infcmd.c (post_create_inferior): Replace throw_exception with
127         throw.
128         * inf-loop.c (inferior_event_handler): Replace throw_exception
129         with throw.
130         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
131         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
132         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
133         (get_prev_frame_always, get_frame_pc_if_available)
134         (get_frame_address_in_block_if_available, get_frame_language):
135         Replace throw_exception with throw.
136         * frame-unwind.c (frame_unwind_try_unwinder): Replace
137         throw_exception with throw.
138         * eval.c (fetch_subexp_value, evaluate_var_value)
139         (evaluate_funcall, evaluate_subexp_standard): Replace
140         throw_exception with throw.
141         * dwarf2loc.c (call_site_find_chain)
142         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
143         Replace throw_exception with throw.
144         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
145         with throw.
146         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
147         throw.
148         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
149         * completer.c (complete_line_internal): Replace throw_exception
150         with throw.
151         * compile/compile-object-run.c (compile_object_run): Replace
152         throw_exception with throw.
153         * cli/cli-script.c (process_next_line): Replace throw_exception
154         with throw.
155         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
156         (btrace_enable, btrace_maint_update_pt_packets): Replace
157         throw_exception with throw.
158         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
159         throw_exception with throw.
160         * break-catch-throw.c (re_set_exception_catchpoint): Replace
161         throw_exception with throw.
162         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
163         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
164         * aarch64-tdep.c (aarch64_make_prologue_cache)
165         (aarch64_make_stub_cache): Replace throw_exception with throw.
166
167 2019-04-08  Tom Tromey  <tom@tromey.com>
168
169         * common/common-exceptions.c (throw_exception): Rename from
170         throw_exception_cxx.  Remove old copy.  Make argument const.
171         (throw_it): Create and throw exception objects directly.
172         * common/common-exceptions.h (throw_exception): Make argument
173         const.
174         (struct gdb_exception_error): Add constructor.
175         (struct gdb_exception_quit): Add constructor.
176
177 2019-04-08  Tom Tromey  <tom@tromey.com>
178
179         * common/common-exceptions.h (exception_rethrow): Don't declare.
180         (TRY_SJLJ): Update comment.
181         (TRY, CATCH, END_CATCH): Remove.
182         * common/common-exceptions.c (exception_rethrow): Remove.
183
184 2019-04-08  Tom Tromey  <tom@tromey.com>
185
186         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
187         Remove.
188         (gdb_exception_error): Rename from
189         gdb_exception_RETURN_MASK_ERROR.
190         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
191         (gdb_quit_bad_alloc): Update.
192         * aarch64-tdep.c: Update.
193         * ada-lang.c: Update.
194         * ada-typeprint.c: Update.
195         * ada-valprint.c: Update.
196         * amd64-tdep.c: Update.
197         * arch-utils.c: Update.
198         * break-catch-throw.c: Update.
199         * breakpoint.c: Update.
200         * btrace.c: Update.
201         * c-varobj.c: Update.
202         * cli/cli-cmds.c: Update.
203         * cli/cli-interp.c: Update.
204         * cli/cli-script.c: Update.
205         * common/common-exceptions.c: Update.
206         * common/new-op.c: Update.
207         * common/selftest.c: Update.
208         * compile/compile-c-symbols.c: Update.
209         * compile/compile-cplus-symbols.c: Update.
210         * compile/compile-object-load.c: Update.
211         * compile/compile-object-run.c: Update.
212         * completer.c: Update.
213         * corelow.c: Update.
214         * cp-abi.c: Update.
215         * cp-support.c: Update.
216         * cp-valprint.c: Update.
217         * darwin-nat.c: Update.
218         * disasm-selftests.c: Update.
219         * dtrace-probe.c: Update.
220         * dwarf-index-cache.c: Update.
221         * dwarf-index-write.c: Update.
222         * dwarf2-frame-tailcall.c: Update.
223         * dwarf2-frame.c: Update.
224         * dwarf2loc.c: Update.
225         * dwarf2read.c: Update.
226         * eval.c: Update.
227         * event-loop.c: Update.
228         * event-top.c: Update.
229         * exec.c: Update.
230         * f-valprint.c: Update.
231         * fbsd-tdep.c: Update.
232         * frame-unwind.c: Update.
233         * frame.c: Update.
234         * gdbtypes.c: Update.
235         * gnu-v3-abi.c: Update.
236         * guile/guile-internal.h: Update.
237         * guile/scm-block.c: Update.
238         * guile/scm-breakpoint.c: Update.
239         * guile/scm-cmd.c: Update.
240         * guile/scm-disasm.c: Update.
241         * guile/scm-frame.c: Update.
242         * guile/scm-lazy-string.c: Update.
243         * guile/scm-math.c: Update.
244         * guile/scm-param.c: Update.
245         * guile/scm-ports.c: Update.
246         * guile/scm-pretty-print.c: Update.
247         * guile/scm-symbol.c: Update.
248         * guile/scm-symtab.c: Update.
249         * guile/scm-type.c: Update.
250         * guile/scm-value.c: Update.
251         * i386-linux-tdep.c: Update.
252         * i386-tdep.c: Update.
253         * inf-loop.c: Update.
254         * infcall.c: Update.
255         * infcmd.c: Update.
256         * infrun.c: Update.
257         * jit.c: Update.
258         * language.c: Update.
259         * linespec.c: Update.
260         * linux-fork.c: Update.
261         * linux-nat.c: Update.
262         * linux-tdep.c: Update.
263         * linux-thread-db.c: Update.
264         * main.c: Update.
265         * mi/mi-cmd-break.c: Update.
266         * mi/mi-cmd-stack.c: Update.
267         * mi/mi-interp.c: Update.
268         * mi/mi-main.c: Update.
269         * objc-lang.c: Update.
270         * p-valprint.c: Update.
271         * parse.c: Update.
272         * ppc-linux-tdep.c: Update.
273         * printcmd.c: Update.
274         * python/py-arch.c: Update.
275         * python/py-breakpoint.c: Update.
276         * python/py-cmd.c: Update.
277         * python/py-finishbreakpoint.c: Update.
278         * python/py-frame.c: Update.
279         * python/py-framefilter.c: Update.
280         * python/py-gdb-readline.c: Update.
281         * python/py-inferior.c: Update.
282         * python/py-infthread.c: Update.
283         * python/py-lazy-string.c: Update.
284         * python/py-linetable.c: Update.
285         * python/py-objfile.c: Update.
286         * python/py-param.c: Update.
287         * python/py-prettyprint.c: Update.
288         * python/py-progspace.c: Update.
289         * python/py-record-btrace.c: Update.
290         * python/py-record.c: Update.
291         * python/py-symbol.c: Update.
292         * python/py-type.c: Update.
293         * python/py-unwind.c: Update.
294         * python/py-utils.c: Update.
295         * python/py-value.c: Update.
296         * python/python.c: Update.
297         * record-btrace.c: Update.
298         * record-full.c: Update.
299         * remote-fileio.c: Update.
300         * remote.c: Update.
301         * riscv-tdep.c: Update.
302         * rs6000-aix-tdep.c: Update.
303         * rs6000-tdep.c: Update.
304         * rust-exp.y: Update.
305         * rust-lang.c: Update.
306         * s390-tdep.c: Update.
307         * selftest-arch.c: Update.
308         * solib-dsbt.c: Update.
309         * solib-frv.c: Update.
310         * solib-spu.c: Update.
311         * solib-svr4.c: Update.
312         * solib.c: Update.
313         * sparc64-linux-tdep.c: Update.
314         * stack.c: Update.
315         * symfile-mem.c: Update.
316         * symmisc.c: Update.
317         * target.c: Update.
318         * thread.c: Update.
319         * top.c: Update.
320         * tracefile-tfile.c: Update.
321         * tui/tui.c: Update.
322         * typeprint.c: Update.
323         * unittests/cli-utils-selftests.c: Update.
324         * unittests/parse-connection-spec-selftests.c: Update.
325         * valops.c: Update.
326         * valprint.c: Update.
327         * value.c: Update.
328         * varobj.c: Update.
329         * windows-nat.c: Update.
330         * x86-linux-nat.c: Update.
331         * xml-support.c: Update.
332
333 2019-04-08  Tom Tromey  <tom@tromey.com>
334
335         * xml-support.c: Use C++ exception handling.
336         * x86-linux-nat.c: Use C++ exception handling.
337         * windows-nat.c: Use C++ exception handling.
338         * varobj.c: Use C++ exception handling.
339         * value.c: Use C++ exception handling.
340         * valprint.c: Use C++ exception handling.
341         * valops.c: Use C++ exception handling.
342         * unittests/parse-connection-spec-selftests.c: Use C++ exception
343         handling.
344         * unittests/cli-utils-selftests.c: Use C++ exception handling.
345         * typeprint.c: Use C++ exception handling.
346         * tui/tui.c: Use C++ exception handling.
347         * tracefile-tfile.c: Use C++ exception handling.
348         * top.c: Use C++ exception handling.
349         * thread.c: Use C++ exception handling.
350         * target.c: Use C++ exception handling.
351         * symmisc.c: Use C++ exception handling.
352         * symfile-mem.c: Use C++ exception handling.
353         * stack.c: Use C++ exception handling.
354         * sparc64-linux-tdep.c: Use C++ exception handling.
355         * solib.c: Use C++ exception handling.
356         * solib-svr4.c: Use C++ exception handling.
357         * solib-spu.c: Use C++ exception handling.
358         * solib-frv.c: Use C++ exception handling.
359         * solib-dsbt.c: Use C++ exception handling.
360         * selftest-arch.c: Use C++ exception handling.
361         * s390-tdep.c: Use C++ exception handling.
362         * rust-lang.c: Use C++ exception handling.
363         * rust-exp.y: Use C++ exception handling.
364         * rs6000-tdep.c: Use C++ exception handling.
365         * rs6000-aix-tdep.c: Use C++ exception handling.
366         * riscv-tdep.c: Use C++ exception handling.
367         * remote.c: Use C++ exception handling.
368         * remote-fileio.c: Use C++ exception handling.
369         * record-full.c: Use C++ exception handling.
370         * record-btrace.c: Use C++ exception handling.
371         * python/python.c: Use C++ exception handling.
372         * python/py-value.c: Use C++ exception handling.
373         * python/py-utils.c: Use C++ exception handling.
374         * python/py-unwind.c: Use C++ exception handling.
375         * python/py-type.c: Use C++ exception handling.
376         * python/py-symbol.c: Use C++ exception handling.
377         * python/py-record.c: Use C++ exception handling.
378         * python/py-record-btrace.c: Use C++ exception handling.
379         * python/py-progspace.c: Use C++ exception handling.
380         * python/py-prettyprint.c: Use C++ exception handling.
381         * python/py-param.c: Use C++ exception handling.
382         * python/py-objfile.c: Use C++ exception handling.
383         * python/py-linetable.c: Use C++ exception handling.
384         * python/py-lazy-string.c: Use C++ exception handling.
385         * python/py-infthread.c: Use C++ exception handling.
386         * python/py-inferior.c: Use C++ exception handling.
387         * python/py-gdb-readline.c: Use C++ exception handling.
388         * python/py-framefilter.c: Use C++ exception handling.
389         * python/py-frame.c: Use C++ exception handling.
390         * python/py-finishbreakpoint.c: Use C++ exception handling.
391         * python/py-cmd.c: Use C++ exception handling.
392         * python/py-breakpoint.c: Use C++ exception handling.
393         * python/py-arch.c: Use C++ exception handling.
394         * printcmd.c: Use C++ exception handling.
395         * ppc-linux-tdep.c: Use C++ exception handling.
396         * parse.c: Use C++ exception handling.
397         * p-valprint.c: Use C++ exception handling.
398         * objc-lang.c: Use C++ exception handling.
399         * mi/mi-main.c: Use C++ exception handling.
400         * mi/mi-interp.c: Use C++ exception handling.
401         * mi/mi-cmd-stack.c: Use C++ exception handling.
402         * mi/mi-cmd-break.c: Use C++ exception handling.
403         * main.c: Use C++ exception handling.
404         * linux-thread-db.c: Use C++ exception handling.
405         * linux-tdep.c: Use C++ exception handling.
406         * linux-nat.c: Use C++ exception handling.
407         * linux-fork.c: Use C++ exception handling.
408         * linespec.c: Use C++ exception handling.
409         * language.c: Use C++ exception handling.
410         * jit.c: Use C++ exception handling.
411         * infrun.c: Use C++ exception handling.
412         * infcmd.c: Use C++ exception handling.
413         * infcall.c: Use C++ exception handling.
414         * inf-loop.c: Use C++ exception handling.
415         * i386-tdep.c: Use C++ exception handling.
416         * i386-linux-tdep.c: Use C++ exception handling.
417         * guile/scm-value.c: Use C++ exception handling.
418         * guile/scm-type.c: Use C++ exception handling.
419         * guile/scm-symtab.c: Use C++ exception handling.
420         * guile/scm-symbol.c: Use C++ exception handling.
421         * guile/scm-pretty-print.c: Use C++ exception handling.
422         * guile/scm-ports.c: Use C++ exception handling.
423         * guile/scm-param.c: Use C++ exception handling.
424         * guile/scm-math.c: Use C++ exception handling.
425         * guile/scm-lazy-string.c: Use C++ exception handling.
426         * guile/scm-frame.c: Use C++ exception handling.
427         * guile/scm-disasm.c: Use C++ exception handling.
428         * guile/scm-cmd.c: Use C++ exception handling.
429         * guile/scm-breakpoint.c: Use C++ exception handling.
430         * guile/scm-block.c: Use C++ exception handling.
431         * guile/guile-internal.h: Use C++ exception handling.
432         * gnu-v3-abi.c: Use C++ exception handling.
433         * gdbtypes.c: Use C++ exception handling.
434         * frame.c: Use C++ exception handling.
435         * frame-unwind.c: Use C++ exception handling.
436         * fbsd-tdep.c: Use C++ exception handling.
437         * f-valprint.c: Use C++ exception handling.
438         * exec.c: Use C++ exception handling.
439         * event-top.c: Use C++ exception handling.
440         * event-loop.c: Use C++ exception handling.
441         * eval.c: Use C++ exception handling.
442         * dwarf2read.c: Use C++ exception handling.
443         * dwarf2loc.c: Use C++ exception handling.
444         * dwarf2-frame.c: Use C++ exception handling.
445         * dwarf2-frame-tailcall.c: Use C++ exception handling.
446         * dwarf-index-write.c: Use C++ exception handling.
447         * dwarf-index-cache.c: Use C++ exception handling.
448         * dtrace-probe.c: Use C++ exception handling.
449         * disasm-selftests.c: Use C++ exception handling.
450         * darwin-nat.c: Use C++ exception handling.
451         * cp-valprint.c: Use C++ exception handling.
452         * cp-support.c: Use C++ exception handling.
453         * cp-abi.c: Use C++ exception handling.
454         * corelow.c: Use C++ exception handling.
455         * completer.c: Use C++ exception handling.
456         * compile/compile-object-run.c: Use C++ exception handling.
457         * compile/compile-object-load.c: Use C++ exception handling.
458         * compile/compile-cplus-symbols.c: Use C++ exception handling.
459         * compile/compile-c-symbols.c: Use C++ exception handling.
460         * common/selftest.c: Use C++ exception handling.
461         * common/new-op.c: Use C++ exception handling.
462         * cli/cli-script.c: Use C++ exception handling.
463         * cli/cli-interp.c: Use C++ exception handling.
464         * cli/cli-cmds.c: Use C++ exception handling.
465         * c-varobj.c: Use C++ exception handling.
466         * btrace.c: Use C++ exception handling.
467         * breakpoint.c: Use C++ exception handling.
468         * break-catch-throw.c: Use C++ exception handling.
469         * arch-utils.c: Use C++ exception handling.
470         * amd64-tdep.c: Use C++ exception handling.
471         * ada-valprint.c: Use C++ exception handling.
472         * ada-typeprint.c: Use C++ exception handling.
473         * ada-lang.c: Use C++ exception handling.
474         * aarch64-tdep.c: Use C++ exception handling.
475
476 2019-04-08  Tom Tromey  <tom@tromey.com>
477
478         * xml-support.c (gdb_xml_parser::parse): Update.
479         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
480         * value.c (show_convenience): Update.
481         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
482         (test_parse_flags_qcs): Update.
483         * thread.c (thr_try_catch_cmd): Update.
484         * target.c (target_translate_tls_address): Update.
485         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
486         (info_frame_command_core, frame_apply_command_count): Update.
487         * rust-exp.y (rust_lex_exception_test): Update.
488         * riscv-tdep.c (riscv_print_one_register_info): Update.
489         * remote.c (remote_target::enable_btrace): Update.
490         * record-btrace.c (record_btrace_enable_warn): Update.
491         * python/py-utils.c (gdbpy_convert_exception): Update.
492         * printcmd.c (do_one_display, print_variable_and_value): Update.
493         * mi/mi-main.c (mi_print_exception): Update.
494         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
495         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
496         * linux-nat.c (linux_nat_target::attach): Update.
497         * linux-fork.c (class scoped_switch_fork_info): Update.
498         * infrun.c (displaced_step_prepare): Update.
499         * infcall.c (call_function_by_hand_dummy): Update.
500         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
501         * gnu-v3-abi.c (print_one_vtable): Update.
502         * frame.c (get_prev_frame_always): Update.
503         * f-valprint.c (info_common_command_for_block): Update.
504         * exec.c (try_open_exec_file): Update.
505         * exceptions.c (print_exception, exception_print)
506         (exception_fprintf, exception_print_same): Update.
507         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
508         * dwarf-index-cache.c (index_cache::store)
509         (index_cache::lookup_gdb_index): Update.
510         * darwin-nat.c (maybe_cache_shell): Update.
511         * cp-valprint.c (cp_print_value_fields): Update.
512         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
513         (gcc_cplus_symbol_address): Update.
514         * compile/compile-c-symbols.c (gcc_convert_symbol)
515         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
516         * common/selftest.c: Update.
517         * common/common-exceptions.h (struct gdb_exception) <message>: Now
518         a std::string.
519         (exception_try_scope_entry, exception_try_scope_exit): Don't
520         declare.
521         (struct exception_try_scope): Remove.
522         (TRY): Don't use exception_try_scope.
523         (struct gdb_exception): Add constructor, operator=.
524         <what>: New method.
525         (struct gdb_exception_RETURN_MASK_ALL)
526         (struct gdb_exception_RETURN_MASK_ERROR)
527         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
528         (struct gdb_quit_bad_alloc): Update.
529         * common/common-exceptions.c (exception_none): Change
530         initializer.
531         (struct catcher) <state, exception>: Initialize inline.
532         <prev>: Remove member.
533         (current_catcher): Remove.
534         (catchers): New global.
535         (exceptions_state_mc_init): Simplify.
536         (catcher_pop): Remove.
537         (exceptions_state_mc, exceptions_state_mc_catch): Update.
538         (try_scope_depth, exception_try_scope_entry)
539         (exception_try_scope_exit): Remove.
540         (throw_exception_sjlj): Update.
541         (exception_messages, exception_messages_size): Remove.
542         (throw_it): Simplify.
543         (gdb_exception_sliced_copy): Remove.
544         (throw_exception_cxx): Update.
545         * cli/cli-script.c (script_from_file): Update.
546         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
547         Update.
548         * ada-valprint.c (ada_val_print): Update.
549         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
550         (create_excep_cond_exprs): Update.
551
552 2019-04-08  Tom Tromey  <tom@tromey.com>
553
554         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
555         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
556         (TRY, CATCH, END_CATCH): Remove some definitions.
557         * common/common-exceptions.c: Don't use GDB_XCPT.
558         (catcher_list_size): Remove.
559         (throw_exception, throw_it): Simplify.
560
561 2019-04-05  Tom Tromey  <tom@tromey.com>
562
563         Revert the header-sorting patch.
564         * ft32-tdep.c: Revert.
565         * frv-tdep.c: Revert.
566         * frv-linux-tdep.c: Revert.
567         * frame.c: Revert.
568         * frame-unwind.c: Revert.
569         * frame-base.c: Revert.
570         * fork-child.c: Revert.
571         * findvar.c: Revert.
572         * findcmd.c: Revert.
573         * filesystem.c: Revert.
574         * filename-seen-cache.h: Revert.
575         * filename-seen-cache.c: Revert.
576         * fbsd-tdep.c: Revert.
577         * fbsd-nat.h: Revert.
578         * fbsd-nat.c: Revert.
579         * f-valprint.c: Revert.
580         * f-typeprint.c: Revert.
581         * f-lang.c: Revert.
582         * extension.h: Revert.
583         * extension.c: Revert.
584         * extension-priv.h: Revert.
585         * expprint.c: Revert.
586         * exec.h: Revert.
587         * exec.c: Revert.
588         * exceptions.c: Revert.
589         * event-top.c: Revert.
590         * event-loop.c: Revert.
591         * eval.c: Revert.
592         * elfread.c: Revert.
593         * dwarf2read.h: Revert.
594         * dwarf2read.c: Revert.
595         * dwarf2loc.c: Revert.
596         * dwarf2expr.h: Revert.
597         * dwarf2expr.c: Revert.
598         * dwarf2-frame.c: Revert.
599         * dwarf2-frame-tailcall.c: Revert.
600         * dwarf-index-write.h: Revert.
601         * dwarf-index-write.c: Revert.
602         * dwarf-index-common.c: Revert.
603         * dwarf-index-cache.h: Revert.
604         * dwarf-index-cache.c: Revert.
605         * dummy-frame.c: Revert.
606         * dtrace-probe.c: Revert.
607         * disasm.h: Revert.
608         * disasm.c: Revert.
609         * disasm-selftests.c: Revert.
610         * dictionary.c: Revert.
611         * dicos-tdep.c: Revert.
612         * demangle.c: Revert.
613         * dcache.h: Revert.
614         * dcache.c: Revert.
615         * darwin-nat.h: Revert.
616         * darwin-nat.c: Revert.
617         * darwin-nat-info.c: Revert.
618         * d-valprint.c: Revert.
619         * d-namespace.c: Revert.
620         * d-lang.c: Revert.
621         * ctf.c: Revert.
622         * csky-tdep.c: Revert.
623         * csky-linux-tdep.c: Revert.
624         * cris-tdep.c: Revert.
625         * cris-linux-tdep.c: Revert.
626         * cp-valprint.c: Revert.
627         * cp-support.c: Revert.
628         * cp-namespace.c: Revert.
629         * cp-abi.c: Revert.
630         * corelow.c: Revert.
631         * corefile.c: Revert.
632         * continuations.c: Revert.
633         * completer.h: Revert.
634         * completer.c: Revert.
635         * complaints.c: Revert.
636         * coffread.c: Revert.
637         * coff-pe-read.c: Revert.
638         * cli-out.h: Revert.
639         * cli-out.c: Revert.
640         * charset.c: Revert.
641         * c-varobj.c: Revert.
642         * c-valprint.c: Revert.
643         * c-typeprint.c: Revert.
644         * c-lang.c: Revert.
645         * buildsym.c: Revert.
646         * buildsym-legacy.c: Revert.
647         * build-id.h: Revert.
648         * build-id.c: Revert.
649         * btrace.c: Revert.
650         * bsd-uthread.c: Revert.
651         * breakpoint.h: Revert.
652         * breakpoint.c: Revert.
653         * break-catch-throw.c: Revert.
654         * break-catch-syscall.c: Revert.
655         * break-catch-sig.c: Revert.
656         * blockframe.c: Revert.
657         * block.c: Revert.
658         * bfin-tdep.c: Revert.
659         * bfin-linux-tdep.c: Revert.
660         * bfd-target.c: Revert.
661         * bcache.c: Revert.
662         * ax-general.c: Revert.
663         * ax-gdb.h: Revert.
664         * ax-gdb.c: Revert.
665         * avr-tdep.c: Revert.
666         * auxv.c: Revert.
667         * auto-load.c: Revert.
668         * arm-wince-tdep.c: Revert.
669         * arm-tdep.c: Revert.
670         * arm-symbian-tdep.c: Revert.
671         * arm-pikeos-tdep.c: Revert.
672         * arm-obsd-tdep.c: Revert.
673         * arm-nbsd-tdep.c: Revert.
674         * arm-nbsd-nat.c: Revert.
675         * arm-linux-tdep.c: Revert.
676         * arm-linux-nat.c: Revert.
677         * arm-fbsd-tdep.c: Revert.
678         * arm-fbsd-nat.c: Revert.
679         * arm-bsd-tdep.c: Revert.
680         * arch-utils.c: Revert.
681         * arc-tdep.c: Revert.
682         * arc-newlib-tdep.c: Revert.
683         * annotate.h: Revert.
684         * annotate.c: Revert.
685         * amd64-windows-tdep.c: Revert.
686         * amd64-windows-nat.c: Revert.
687         * amd64-tdep.c: Revert.
688         * amd64-sol2-tdep.c: Revert.
689         * amd64-obsd-tdep.c: Revert.
690         * amd64-obsd-nat.c: Revert.
691         * amd64-nbsd-tdep.c: Revert.
692         * amd64-nbsd-nat.c: Revert.
693         * amd64-nat.c: Revert.
694         * amd64-linux-tdep.c: Revert.
695         * amd64-linux-nat.c: Revert.
696         * amd64-fbsd-tdep.c: Revert.
697         * amd64-fbsd-nat.c: Revert.
698         * amd64-dicos-tdep.c: Revert.
699         * amd64-darwin-tdep.c: Revert.
700         * amd64-bsd-nat.c: Revert.
701         * alpha-tdep.c: Revert.
702         * alpha-obsd-tdep.c: Revert.
703         * alpha-nbsd-tdep.c: Revert.
704         * alpha-mdebug-tdep.c: Revert.
705         * alpha-linux-tdep.c: Revert.
706         * alpha-linux-nat.c: Revert.
707         * alpha-bsd-tdep.c: Revert.
708         * alpha-bsd-nat.c: Revert.
709         * aix-thread.c: Revert.
710         * agent.c: Revert.
711         * addrmap.c: Revert.
712         * ada-varobj.c: Revert.
713         * ada-valprint.c: Revert.
714         * ada-typeprint.c: Revert.
715         * ada-tasks.c: Revert.
716         * ada-lang.c: Revert.
717         * aarch64-tdep.c: Revert.
718         * aarch64-ravenscar-thread.c: Revert.
719         * aarch64-newlib-tdep.c: Revert.
720         * aarch64-linux-tdep.c: Revert.
721         * aarch64-linux-nat.c: Revert.
722         * aarch64-fbsd-tdep.c: Revert.
723         * aarch64-fbsd-nat.c: Revert.
724         * aarch32-linux-nat.c: Revert.
725
726 2019-04-05  Tom Tromey  <tom@tromey.com>
727
728         * ft32-tdep.c: Sort headers.
729         * frv-tdep.c: Sort headers.
730         * frv-linux-tdep.c: Sort headers.
731         * frame.c: Sort headers.
732         * frame-unwind.c: Sort headers.
733         * frame-base.c: Sort headers.
734         * fork-child.c: Sort headers.
735         * findvar.c: Sort headers.
736         * findcmd.c: Sort headers.
737         * filesystem.c: Sort headers.
738         * filename-seen-cache.h: Sort headers.
739         * filename-seen-cache.c: Sort headers.
740         * fbsd-tdep.c: Sort headers.
741         * fbsd-nat.h: Sort headers.
742         * fbsd-nat.c: Sort headers.
743         * f-valprint.c: Sort headers.
744         * f-typeprint.c: Sort headers.
745         * f-lang.c: Sort headers.
746         * extension.h: Sort headers.
747         * extension.c: Sort headers.
748         * extension-priv.h: Sort headers.
749         * expprint.c: Sort headers.
750         * exec.h: Sort headers.
751         * exec.c: Sort headers.
752         * exceptions.c: Sort headers.
753         * event-top.c: Sort headers.
754         * event-loop.c: Sort headers.
755         * eval.c: Sort headers.
756         * elfread.c: Sort headers.
757         * dwarf2read.h: Sort headers.
758         * dwarf2read.c: Sort headers.
759         * dwarf2loc.c: Sort headers.
760         * dwarf2expr.h: Sort headers.
761         * dwarf2expr.c: Sort headers.
762         * dwarf2-frame.c: Sort headers.
763         * dwarf2-frame-tailcall.c: Sort headers.
764         * dwarf-index-write.h: Sort headers.
765         * dwarf-index-write.c: Sort headers.
766         * dwarf-index-common.c: Sort headers.
767         * dwarf-index-cache.h: Sort headers.
768         * dwarf-index-cache.c: Sort headers.
769         * dummy-frame.c: Sort headers.
770         * dtrace-probe.c: Sort headers.
771         * disasm.h: Sort headers.
772         * disasm.c: Sort headers.
773         * disasm-selftests.c: Sort headers.
774         * dictionary.c: Sort headers.
775         * dicos-tdep.c: Sort headers.
776         * demangle.c: Sort headers.
777         * dcache.h: Sort headers.
778         * dcache.c: Sort headers.
779         * darwin-nat.h: Sort headers.
780         * darwin-nat.c: Sort headers.
781         * darwin-nat-info.c: Sort headers.
782         * d-valprint.c: Sort headers.
783         * d-namespace.c: Sort headers.
784         * d-lang.c: Sort headers.
785         * ctf.c: Sort headers.
786         * csky-tdep.c: Sort headers.
787         * csky-linux-tdep.c: Sort headers.
788         * cris-tdep.c: Sort headers.
789         * cris-linux-tdep.c: Sort headers.
790         * cp-valprint.c: Sort headers.
791         * cp-support.c: Sort headers.
792         * cp-namespace.c: Sort headers.
793         * cp-abi.c: Sort headers.
794         * corelow.c: Sort headers.
795         * corefile.c: Sort headers.
796         * continuations.c: Sort headers.
797         * completer.h: Sort headers.
798         * completer.c: Sort headers.
799         * complaints.c: Sort headers.
800         * coffread.c: Sort headers.
801         * coff-pe-read.c: Sort headers.
802         * cli-out.h: Sort headers.
803         * cli-out.c: Sort headers.
804         * charset.c: Sort headers.
805         * c-varobj.c: Sort headers.
806         * c-valprint.c: Sort headers.
807         * c-typeprint.c: Sort headers.
808         * c-lang.c: Sort headers.
809         * buildsym.c: Sort headers.
810         * buildsym-legacy.c: Sort headers.
811         * build-id.h: Sort headers.
812         * build-id.c: Sort headers.
813         * btrace.c: Sort headers.
814         * bsd-uthread.c: Sort headers.
815         * breakpoint.h: Sort headers.
816         * breakpoint.c: Sort headers.
817         * break-catch-throw.c: Sort headers.
818         * break-catch-syscall.c: Sort headers.
819         * break-catch-sig.c: Sort headers.
820         * blockframe.c: Sort headers.
821         * block.c: Sort headers.
822         * bfin-tdep.c: Sort headers.
823         * bfin-linux-tdep.c: Sort headers.
824         * bfd-target.c: Sort headers.
825         * bcache.c: Sort headers.
826         * ax-general.c: Sort headers.
827         * ax-gdb.h: Sort headers.
828         * ax-gdb.c: Sort headers.
829         * avr-tdep.c: Sort headers.
830         * auxv.c: Sort headers.
831         * auto-load.c: Sort headers.
832         * arm-wince-tdep.c: Sort headers.
833         * arm-tdep.c: Sort headers.
834         * arm-symbian-tdep.c: Sort headers.
835         * arm-pikeos-tdep.c: Sort headers.
836         * arm-obsd-tdep.c: Sort headers.
837         * arm-nbsd-tdep.c: Sort headers.
838         * arm-nbsd-nat.c: Sort headers.
839         * arm-linux-tdep.c: Sort headers.
840         * arm-linux-nat.c: Sort headers.
841         * arm-fbsd-tdep.c: Sort headers.
842         * arm-fbsd-nat.c: Sort headers.
843         * arm-bsd-tdep.c: Sort headers.
844         * arch-utils.c: Sort headers.
845         * arc-tdep.c: Sort headers.
846         * arc-newlib-tdep.c: Sort headers.
847         * annotate.h: Sort headers.
848         * annotate.c: Sort headers.
849         * amd64-windows-tdep.c: Sort headers.
850         * amd64-windows-nat.c: Sort headers.
851         * amd64-tdep.c: Sort headers.
852         * amd64-sol2-tdep.c: Sort headers.
853         * amd64-obsd-tdep.c: Sort headers.
854         * amd64-obsd-nat.c: Sort headers.
855         * amd64-nbsd-tdep.c: Sort headers.
856         * amd64-nbsd-nat.c: Sort headers.
857         * amd64-nat.c: Sort headers.
858         * amd64-linux-tdep.c: Sort headers.
859         * amd64-linux-nat.c: Sort headers.
860         * amd64-fbsd-tdep.c: Sort headers.
861         * amd64-fbsd-nat.c: Sort headers.
862         * amd64-dicos-tdep.c: Sort headers.
863         * amd64-darwin-tdep.c: Sort headers.
864         * amd64-bsd-nat.c: Sort headers.
865         * alpha-tdep.c: Sort headers.
866         * alpha-obsd-tdep.c: Sort headers.
867         * alpha-nbsd-tdep.c: Sort headers.
868         * alpha-mdebug-tdep.c: Sort headers.
869         * alpha-linux-tdep.c: Sort headers.
870         * alpha-linux-nat.c: Sort headers.
871         * alpha-bsd-tdep.c: Sort headers.
872         * alpha-bsd-nat.c: Sort headers.
873         * aix-thread.c: Sort headers.
874         * agent.c: Sort headers.
875         * addrmap.c: Sort headers.
876         * ada-varobj.c: Sort headers.
877         * ada-valprint.c: Sort headers.
878         * ada-typeprint.c: Sort headers.
879         * ada-tasks.c: Sort headers.
880         * ada-lang.c: Sort headers.
881         * aarch64-tdep.c: Sort headers.
882         * aarch64-ravenscar-thread.c: Sort headers.
883         * aarch64-newlib-tdep.c: Sort headers.
884         * aarch64-linux-tdep.c: Sort headers.
885         * aarch64-linux-nat.c: Sort headers.
886         * aarch64-fbsd-tdep.c: Sort headers.
887         * aarch64-fbsd-nat.c: Sort headers.
888         * aarch32-linux-nat.c: Sort headers.
889
890 2019-04-04  Tom Tromey  <tom@tromey.com>
891
892         * varobj.c (varobj_create): Update.
893         * rust-exp.y (struct rust_parser) <update_innermost_block,
894         lookup_symbol>: New methods.
895         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
896         Rename.
897         (rust_parser::rust_lookup_type)
898         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
899         * printcmd.c (display_command, do_one_display): Update.
900         * parser-defs.h (struct parser_state) <parser_state>: Add
901         "tracker" parameter.
902         (block_tracker): New member.
903         (class innermost_block_tracker) <innermost_block_tracker>: Add
904         "types" parameter.
905         <reset>: Remove method.
906         (innermost_block): Don't declare.
907         (null_post_parser): Update.
908         * parse.c (innermost_block): Remove global.
909         (write_dollar_variable): Update.
910         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
911         Remove "tracker_types" parameter.
912         (parse_expression): Add "tracker" parameter.
913         (parse_expression_for_completion): Update.
914         (null_post_parser): Add "tracker" parameter.
915         * p-exp.y: Update rules.
916         * m2-exp.y: Update rules.
917         * language.h (struct language_defn) <la_post_parser>: Add
918         "tracker" parameter.
919         * go-exp.y: Update rules.
920         * f-exp.y: Update rules.
921         * expression.h (parse_expression, parse_exp_1): Add "tracker"
922         parameter.
923         * d-exp.y: Update rules.
924         * c-exp.y: Update rules.
925         * breakpoint.c (set_breakpoint_condition): Create an
926         innermost_block_tracker.
927         (watch_command_1): Likewise.
928         * ada-lang.c (resolve): Add "tracker" parameter.
929         (resolve_subexp): Likewise.
930         * ada-exp.y (write_var_from_sym): Update.
931
932 2019-04-04  Tom Tromey  <tom@tromey.com>
933
934         * type-stack.h: New file.
935         * type-stack.c: New file.
936         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
937         type-stack.h.
938         (insert_into_type_stack, insert_type, push_type, push_type_int)
939         (insert_type_address_space, pop_type, pop_type_int)
940         (pop_typelist, pop_type_stack, append_type_stack)
941         (push_type_stack, get_type_stack, push_typelist)
942         (follow_type_instance_flags, follow_types): Don't declare.
943         * parse.c (type_stack): Remove global.
944         (parse_exp_in_context): Update.
945         (insert_into_type_stack, insert_type, push_type, push_type_int)
946         (insert_type_address_space, pop_type, pop_type_int)
947         (pop_typelist, pop_type_stack, append_type_stack)
948         (push_type_stack, get_type_stack, push_typelist)
949         (follow_type_instance_flags, follow_types): Remove (moved to
950         type-stack.c).
951         * f-exp.y (type_stack): New global.
952         Update rules.
953         (push_kind_type, f_parse): Update.
954         * d-exp.y (type_stack): New global.
955         Update rules.
956         (d_parse): Update.
957         * c-exp.y (struct c_parse_state) <type_stack>: New member.
958         Update rules.
959         * Makefile.in (COMMON_SFILES): Add type-stack.c.
960         (HFILES_NO_SRCDIR): Add type-stack.h.
961
962 2019-04-04  Tom Tromey  <tom@tromey.com>
963
964         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
965         (rust_parser::convert_ast_to_expression, rust_parse)
966         (rust_lex_test_completion, rust_lex_tests): Update.
967         * parser-defs.h (struct expr_completion_state): New.
968         (struct parser_state) <parser_state>: Add completion parameter.
969         <mark_struct_expression, mark_completion_tag>: New methods.
970         <parse_completion, m_completion_state>: New members.
971         (prefixify_expression, null_post_parser): Update.
972         (mark_struct_expression, mark_completion_tag): Don't declare.
973         * parse.c (parse_completion, expout_last_struct)
974         (expout_tag_completion_type, expout_completion_name): Remove
975         globals.
976         (parser_state::mark_struct_expression)
977         (parser_state::mark_completion_tag): Now methods.
978         (prefixify_expression): Add last_struct parameter.
979         (prefixify_subexp): Likewise.
980         (parse_exp_1): Update.
981         (parse_exp_in_context): Add cstate parameter.  Update.
982         (parse_expression_for_completion): Create an
983         expr_completion_state.
984         (null_post_parser): Add "completion" parameter.
985         * p-exp.y: Update rules.
986         (yylex): Update.
987         * language.h (struct language_defn) <la_post_parser>: Add
988         "completing" parameter.
989         * go-exp.y: Update rules.
990         (lex_one_token): Update.
991         * expression.h (parse_completion): Don't declare.
992         * d-exp.y: Update rules.
993         (lex_one_token): Update rules.
994         * c-exp.y: Update rules.
995         (lex_one_token): Update.
996         * ada-lang.c (resolve): Add "parse_completion" parameter.
997         (resolve_subexp): Likewise.
998         (ada_resolve_function): Likewise.
999
1000 2019-04-04  Tom Tromey  <tom@tromey.com>
1001
1002         * parser-defs.h (struct parser_state) <start_arglist,
1003         end_arglist>: New methods.
1004         <arglist_len, m_funcall_chain>: New members.
1005         (arglist_len, start_arglist, end_arglist): Don't declare.
1006         * parse.c (arglist_len, funcall_chain): Remove global.
1007         (start_arglist, end_arglist): Remove functions.
1008         (parse_exp_in_context): Update.
1009         * p-exp.y: Update rules.
1010         * m2-exp.y: Update rules.
1011         * go-exp.y: Update rules.
1012         * f-exp.y: Update rules.
1013         * d-exp.y: Update rules.
1014         * c-exp.y: Update rules.
1015
1016 2019-04-04  Tom Tromey  <tom@tromey.com>
1017
1018         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1019         lex_operator, push_back>: New methods.
1020         Update all rules.
1021         (rust_parser::lex_hex, lex_escape): Rename and update.
1022         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1023         (rust_parser::lex_operator): Rename and update.
1024         (rust_parser::lex_number, rustyylex, rustyyerror)
1025         (rust_lex_test_init, rust_lex_test_sequence)
1026         (rust_lex_test_push_back, rust_lex_tests): Update.
1027         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1028         parameter.
1029         <lexptr, prev_lexptr>: New members.
1030         (lexptr, prev_lexptr): Don't declare.
1031         * parse.c (lexptr, prev_lexptr): Remove globals.
1032         (parse_exp_in_context): Update.
1033         * p-exp.y (yylex, yyerror): Update.
1034         * m2-exp.y (parse_number, yylex, yyerror): Update.
1035         * go-exp.y (lex_one_token, yyerror): Update.
1036         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1037         * d-exp.y (lex_one_token, yyerror): Update.
1038         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1039         (lex_one_token, yyerror): Update.
1040         * ada-lex.l (YY_INPUT): Update.
1041         (rewind_to_char): Update.
1042         * ada-exp.y (yyerror): Update.
1043
1044 2019-04-04  Tom Tromey  <tom@tromey.com>
1045
1046         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1047         * parser-defs.h (struct parser_state) <parser_state>: Add new
1048         parameter.
1049         <comma_terminates>: New member.
1050         (comma_terminates): Don't declare global.
1051         * parse.c (comma_terminates): Remove global.
1052         (parse_exp_in_context): Update.
1053         * p-exp.y (yylex): Update.
1054         * m2-exp.y (yylex): Update.
1055         * go-exp.y (lex_one_token): Update.
1056         * f-exp.y (yylex): Update.
1057         * d-exp.y (lex_one_token): Update.
1058         * c-exp.y (lex_one_token): Update.
1059         * ada-lex.l: Update.
1060
1061 2019-04-04  Tom Tromey  <tom@tromey.com>
1062
1063         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1064         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1065         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1066         * parser-defs.h (paren_depth): Don't declare.
1067         * parse.c (paren_depth): Remove global.
1068         (parse_exp_in_context): Update.
1069         * p-exp.y (paren_depth): New global.
1070         (pascal_parse): Initialize it.
1071         * m2-exp.y (paren_depth): New global.
1072         (m2_parse): Initialize it.
1073         * go-exp.y (paren_depth): New global.
1074         (go_parse): Initialize it.
1075         * f-exp.y (paren_depth): New global.
1076         (f_parse): Initialize it.
1077         * d-exp.y (paren_depth): New global.
1078         (d_parse): Initialize it.
1079         * c-exp.y (paren_depth): New global.
1080         (c_parse): Initialize it.
1081         * ada-lex.l (paren_depth): New global.
1082         (lexer_init): Initialize it.
1083
1084 2019-04-04  Tom Tromey  <tom@tromey.com>
1085
1086         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1087         (rust_parser::convert_ast_to_type)
1088         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1089         * parser-defs.h (struct parser_state) <parser_state>: Add
1090         parameters.  Initialize new members.
1091         <expression_context_block, expression_context_pc>: New members.
1092         * parse.c (expression_context_block, expression_context_pc):
1093         Remove globals.
1094         (parse_exp_in_context): Update.
1095         * p-exp.y: Update all rules.
1096         (yylex): Update.
1097         * m2-exp.y: Update all rules.
1098         (yylex): Update.
1099         * go-exp.y (yylex): Update.
1100         * f-exp.y (yylex): Update.
1101         * d-exp.y: Update all rules.
1102         (yylex): Update.
1103         * c-exp.y: Update all rules.
1104         (lex_one_token, classify_name, yylex, c_parse): Update.
1105         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1106
1107 2019-04-04  Tom Tromey  <tom@tromey.com>
1108
1109         * gdbarch.h, gdbarch.c: Rebuild.
1110         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1111         * stap-probe.h: 
1112         (struct stap_parse_info): Replace "parser_state" with
1113         "expr_builder".
1114         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1115         (parser_state): New class.
1116         * parse.c (expr_builder): Rename.
1117         (expr_builder::release): Rename.
1118         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1119         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1120         (write_exp_elt_longcst, write_exp_elt_floatcst)
1121         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1122         (write_exp_string_vector, write_exp_bitstring)
1123         (write_exp_msymbol, mark_struct_expression)
1124         (write_dollar_variable)
1125         (insert_type_address_space, increase_expout_size): Replace
1126         "parser_state" with "expr_builder".
1127         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1128         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1129         "parser_state" with "expr_builder".
1130
1131 2019-04-04  Tom Tromey  <tom@tromey.com>
1132
1133         * rust-exp.y: Replace "parse_language" with method call.
1134         * p-exp.y: 
1135         (yylex): Replace "parse_language" with method call.
1136         * m2-exp.y: 
1137         (yylex): Replace "parse_language" with method call.
1138         * go-exp.y (classify_name): Replace "parse_language" with method
1139         call.
1140         * f-exp.y (yylex): Replace "parse_language" with method call.
1141         * d-exp.y (lex_one_token): Replace "parse_language" with method
1142         call.
1143         * c-exp.y: 
1144         (lex_one_token, classify_name, yylex): Replace "parse_language"
1145         with method call.
1146         * ada-exp.y (find_primitive_type, type_char)
1147         (type_system_address): Replace "parse_language" with method call.
1148
1149 2019-04-04  Tom Tromey  <tom@tromey.com>
1150
1151         * rust-exp.y: Replace "parse_gdbarch" with method call.
1152         * parse.c (write_dollar_variable, insert_type_address_space):
1153         Replace "parse_gdbarch" with method call.
1154         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1155         call.
1156         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1157         call.
1158         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1159         "parse_gdbarch" with method call.
1160         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1161         with method call.
1162         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1163         "parse_gdbarch" with method call.
1164         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1165         "parse_gdbarch" with method call.
1166         * c-exp.y (parse_type, parse_number, classify_name): Replace
1167         "parse_gdbarch" with method call.
1168         * ada-lex.l: Replace "parse_gdbarch" with method call.
1169         * ada-exp.y (parse_type, find_primitive_type, type_char)
1170         (type_system_address): Replace "parse_gdbarch" with method call.
1171
1172 2019-04-04  Tom Tromey  <tom@tromey.com>
1173
1174         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1175         * stap-probe.c (stap_parse_argument): Update.
1176         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1177         initial_size parameter.
1178         * rust-exp.y (rust_lex_tests): Update.
1179         * parse.c (parser_state): Update.
1180         (parse_exp_in_context): Update.
1181         * parser-defs.h (struct parser_state) <parser_state>: Remove
1182         "initial_size" parameter.
1183
1184 2019-04-04  Tom Tromey  <tom@tromey.com>
1185
1186         * parser-defs.h (increase_expout_size): Don't declare.
1187         * parse.c (increase_expout_size): Now static.
1188
1189 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1190
1191         * gnu-nat.c (gnu_nat_target::wait): Fix
1192         target_waitstatus_to_string call.
1193
1194 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1195
1196         * eval.c (evaluate_subexp_standard): Handle internal functions
1197         during Fortran function call handling.
1198
1199 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1200
1201         * NEWS: Mention new internal functions.
1202         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1203         (read_base_type): Use dwarf2_init_complex_target_type.
1204         * value.c (creal_internal_fn): New function.
1205         (cimag_internal_fn): New function.
1206         (_initialize_values): Register new internal functions.
1207
1208 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1209
1210         * infrun.c (stop_all_threads): If debug_infrun, always
1211         trace the wait status after wait_one, using
1212         target_waitstatus_to_string and target_pid_to_str.
1213         (handle_inferior_event): Replace various trace of
1214         wait status kind by a single trace.
1215         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1216         wait status kind image by target_waitstatus_to_string.
1217         * target/waitstatus.c (target_waitstatus_to_string): Fix
1218         obsolete comment.
1219
1220 2019-04-01  Tom Tromey  <tromey@adacore.com>
1221
1222         PR symtab/23331:
1223         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1224
1225 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1226             Pedro Alves  <palves@redhat.com>
1227
1228         * top.c (quit_force): Call 'finalize_values'.
1229         * value.c (finalize_values): New function.
1230         * value.h (finalize_values): Declare.
1231
1232 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1233
1234         * NEWS: Announce $_gdb_major and $_gdb_minor.
1235
1236         * top.c (init_gdb_version_vars): New function.
1237         (gdb_init): Call init_gdb_version_vars.
1238
1239 2019-03-29  Tom Tromey  <tromey@adacore.com>
1240
1241         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1242         help text.  Remove dead code.
1243
1244 2019-03-29  Keith Seitz  <keiths@redhat.com>
1245
1246         From Siddhesh Poyarekar:
1247         * f-lang.h (f77_get_upperbound): Return LONGEST.
1248         (f77_get_lowerbound): Likewise.
1249         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1250         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1251         print them.
1252         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1253         plongest to format print it.
1254         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1255         (f77_get_upperbound): Likewise.
1256         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1257         LOWER_BOUND to LONGEST.
1258         (f77_create_arrayprint_offset_tbl): Likewise.
1259
1260 2019-03-29  Keith Seitz  <keiths@redhat.com>
1261
1262         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1263         %s/pulongest for TYPE_LENGTH instead of %d in format
1264         strings.
1265         * ada-typerint.c (ada_print_type): Likewise.
1266         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1267         * compile/compile-c-support.c (generate_register_struct): Likewise.
1268         * gdbtypes.c (recursive_dump_type): Likewise.
1269         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1270         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1271         instead of %d in format strings.
1272         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1273         to std::min to ULONGEST.
1274         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1275         instead of %d in format strings.
1276         * tracepoint.c (info_scope_command): Likewise.
1277         * typeprint.c (print_offset_data::update)
1278         (print_offset_data::finish): Likewise.
1279         * xtensa-tdep.c (xtensa_store_return_value)
1280         (xtensa_push_dummy_call): Likewise.
1281
1282 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1283
1284         * windows-nat.c (display_selector): Fixed format specifications
1285         for 64-bit Cygwin.
1286
1287 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1288
1289         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1290
1291 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1292
1293         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1294         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1295         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1296         (nios2_linux_init_abi): Install it.
1297
1298 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1299
1300         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1301
1302 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1303
1304         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1305
1306 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1307             Tom Tromey  <tromey@adacore.com>
1308
1309         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1310
1311 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1312
1313         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1314         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1315         method to compute the bounds of range types. Also print "[evaluated]"
1316         if the bounds' values come from a dynamic evaluation.
1317
1318 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1319
1320         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1321         whitespace when pretty printing is on.
1322
1323 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1324
1325         * ppc-linux-nat.c: Add include.
1326
1327 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1328
1329         * NEWS: Mention AArch64 Pointer Authentication.
1330
1331 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1332
1333         * arm-linux-nat.c: Add include.
1334
1335 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1336
1337         * source-cache.c (source_cache::get_source_lines): Re-read
1338         fullname after calling open_source_file.
1339
1340 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1341
1342         * NEWS: Mention TLS support for FreeBSD.
1343
1344 2019-03-25  Tom Tromey  <tromey@adacore.com>
1345
1346         * minsyms.c (BUNCH_SIZE): Update comment.
1347         (~minimal_symbol_reader): Remove old comment.
1348         (compact_minimal_symbols): Update comment.
1349         (minimal_symbol_reader::install): Remove old comment.  Update
1350         other comments.
1351
1352 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1353
1354         * s390-linux-nat.c: Add include.
1355
1356 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1357
1358         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1359         Call linux_get_hwcap.
1360         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1361         Likewise.
1362         (aarch64_linux_get_hwcap): Remove function.
1363         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1364         declaration.
1365         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1366         linux_get_hwcap.
1367         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1368         * linux-tdep.c (linux_get_hwcap): Add function.
1369         (linux_get_hwcap2): Likewise.
1370         * linux-tdep.h (linux_get_hwcap): Add declaration.
1371         (linux_get_hwcap2): Likewise.
1372         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1373         (ppc_linux_get_hwcap2): Likewise.
1374         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1375         linux_get_hwcap.
1376         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1377         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1378         (ppc_linux_nat_target::read_description): Likewise.
1379         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1380         * s390-linux-nat.c: Likewise.
1381         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1382
1383 2019-03-24  Tom Tromey  <tom@tromey.com>
1384
1385         * ada-lang.c (standard_lookup): Simplify initialization.
1386         (ada_lookup_symbol_nonlocal): Simplify return.
1387         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1388         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1389         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1390         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1391         initialization.
1392         * solib.c (solib_global_lookup): Simplify.
1393         * symtab.c (null_block_symbol): Remove.
1394         (symbol_cache_lookup): Simplify returns.
1395         (lookup_language_this): Simplify returns.
1396         (lookup_symbol_aux): Simplify return.
1397         (lookup_local_symbol): Simplify returns.
1398         (lookup_global_symbol_from_objfile): Simplify return.
1399         (lookup_symbol_in_objfile_symtabs)
1400         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1401         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1402         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1403         * cp-namespace.c (cp_lookup_bare_symbol)
1404         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1405         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1406         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1407         (cp_lookup_symbol_via_imports): Simplify initialization.
1408         (find_symbol_in_baseclass): Likewise.
1409         * symtab.h (null_block_symbol): Remove.
1410         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1411         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1412         (d_lookup_symbol_module): Likewise.
1413         (find_symbol_in_baseclass): Simplify initialization.
1414
1415 2019-03-24  Tom Tromey  <tom@tromey.com>
1416
1417         * expression.h: Don't include symtab.h.
1418         (struct block): Forward declare.
1419
1420 2019-03-24  Tom Tromey  <tom@tromey.com>
1421
1422         * c-exp.y (typebase): Remove casts.
1423         * gdbtypes.c (lookup_unsigned_typename, )
1424         (lookup_signed_typename): Remove cast.
1425         * eval.c (parse_to_comma_and_eval): Remove cast.
1426         * parse.c (write_dollar_variable): Remove cast.
1427         * block.h (struct block) <superblock>: Now const.
1428         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1429         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1430         (map_block): Make "block" const.
1431         * symfile.h (struct quick_symbol_functions)
1432         <map_matching_symbols>: Constify block argument to "callback".
1433         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1434         const.
1435         (find_pc_sect_compunit_symtab): Make "b" const.
1436         (find_symbol_at_address): Likewise.
1437         (search_symbols): Likewise.
1438         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1439         (dw2_debug_names_lookup_symbol): Likewise.
1440         (dw2_map_matching_symbols): Update.
1441         * p-valprint.c (pascal_val_print): Remove "block".
1442         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1443         (aux_add_nonlocal_symbols): Make "block" const.
1444         (resolve_subexp): Remove cast.
1445         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1446         const.
1447         (iterate_over_file_blocks): Likewise.
1448         * f-exp.y (%union) <bval>: Remove.
1449         * coffread.c (patch_opaque_types): Make "b" const.
1450         * spu-tdep.c (spu_catch_start): Make "block" const.
1451         * c-valprint.c (print_unpacked_pointer): Remove "block".
1452         * symmisc.c (dump_symtab_1): Make "b" const.
1453         (block_depth): Make "block" const.
1454         * d-exp.y (%union) <bval>: Remove.
1455         * cp-support.h (cp_lookup_rtti_type): Update.
1456         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1457         * psymtab.c (psym_lookup_symbol): Make "block" const.
1458         (maintenance_check_psymtabs): Make "b" const.
1459         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1460         (enumerate_locals, enumerate_args): Update.
1461         * python/py-symtab.c (stpy_global_block): Make "block" const.
1462         (stpy_static_block): Likewise.
1463         * inline-frame.c (block_starting_point_at): Make "new_block"
1464         const.
1465         * block.c (find_block_in_blockvector): Make return type const.
1466         (blockvector_for_pc_sect): Make "b" const.
1467         (find_block_in_blockvector): Make "b" const.
1468
1469 2019-03-23  Tom Tromey  <tom@tromey.com>
1470
1471         * varobj.c (varobj_create): Update.
1472         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1473         * printcmd.c (display_command, do_one_display): Don't reset
1474         innermost_block.
1475         * parser-defs.h (enum innermost_block_tracker_type): Move to
1476         expression.h.
1477         (innermost_block): Update comment.
1478         * parse.c (parse_exp_1): Add tracker_types parameter.
1479         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1480         tracker_types parameter.  Reset innermost_block.
1481         (parse_exp_in_context): Remove.
1482         (parse_expression_for_completion): Update.
1483         * objfiles.c (~objfile): Don't reset expression_context_block or
1484         innermost_block.
1485         * expression.h (enum innermost_block_tracker_type): Move from
1486         parser-defs.h.
1487         (parse_exp_1): Add tracker_types parameter.
1488         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1489         reset innermost_block.
1490
1491 2019-03-23  Tom Tromey  <tom@tromey.com>
1492
1493         * objfiles.h: Include bcache.h.
1494
1495 2019-03-23  Tom Tromey  <tom@tromey.com>
1496
1497         * linespec.c (get_current_search_block): Use
1498         scoped_restore_current_language.
1499         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1500
1501 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1502             Jiong Wang  <jiong.wang@arm.com>
1503
1504         * aarch64-linux-tdep.c
1505         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1506         section.
1507         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1508
1509 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1510             Jiong Wang  <jiong.wang@arm.com>
1511
1512         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1513         instructions.
1514         (aarch64_analyze_prologue_test): Add PACIASP test.
1515         (aarch64_prologue_prev_register): Unmask PC value.
1516
1517 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1518             Jiong Wang  <jiong.wang@arm.com>
1519
1520         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1521         (aarch64_dwarf2_prev_register): Unmask PC value.
1522         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1523         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1524         DW_CFA_AARCH64_negate_ra_state.
1525         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1526
1527 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1528             Jiong Wang  <jiong.wang@arm.com>
1529
1530         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1531         registers.
1532         (aarch64_pseudo_register_name): Likewise.
1533         (aarch64_pseudo_register_type): Likewise.
1534         (aarch64_pseudo_register_reggroup_p): Likewise.
1535         (aarch64_gdbarch_init): Add pauth registers.
1536         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1537         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1538         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1539         (struct gdbarch_tdep): Add regnum for ra_state.
1540
1541 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1542             Jiong Wang  <jiong.wang@arm.com>
1543
1544         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1545
1546 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1547             Jiong Wang  <jiong.wang@arm.com>
1548
1549         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1550         function.
1551         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1552         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1553         (aarch64_gdbarch_init): Add puth registers.
1554         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1555         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1556         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1557
1558 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1559             Jiong Wang  <jiong.wang@arm.com>
1560
1561         * aarch64-linux-nat.c
1562         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1563         * aarch64-linux-tdep.c
1564         (aarch64_linux_core_read_description): Likewise.
1565         (aarch64_linux_get_hwcap): New function.
1566         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1567         (aarch64_linux_get_hwcap): New declaration.
1568
1569 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1570             Jiong Wang  <jiong.wang@arm.com>
1571
1572         * aarch64-linux-nat.c
1573         (aarch64_linux_nat_target::read_description): Add pauth param.
1574         * aarch64-linux-tdep.c
1575         (aarch64_linux_core_read_description): Likewise.
1576         * aarch64-tdep.c (struct target_desc): Add in pauth.
1577         (aarch64_read_description): Add pauth param.
1578         (aarch64_gdbarch_init): Likewise.
1579         * aarch64-tdep.h (aarch64_read_description): Likewise.
1580         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1581         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1582         * features/Makefile: Add new files.
1583         * features/aarch64-pauth.c: New file.
1584         * features/aarch64-pauth.xml: New file.
1585
1586 2019-03-20  Tom Tromey  <tromey@adacore.com>
1587
1588         * infrun.c (handle_inferior_event): Rename from
1589         handle_inferior_event_1.  Create a scoped_value_mark.
1590         (handle_inferior_event): Remove.
1591
1592 2019-03-19  Tom Tromey  <tromey@adacore.com>
1593
1594         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1595         * infrun.h (print_stop_event): Add "displays" parameter.
1596         * infrun.c (print_stop_event): Add "displays" parameter.
1597
1598 2019-03-19  Pedro Alves  <palves@redhat.com>
1599
1600         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1601         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1602         to -1.  Fix TABs vs spaces.
1603         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1604         * tui/tui-out.h (tui_ui_out) Add intro comments.
1605         <m_line, m_start_of_line>: In-class initialize, and add describing
1606         comment.
1607
1608 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1609
1610         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1611         variable names.
1612         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1613
1614 2019-03-18  Pedro Alves  <palves@redhat.com>
1615             Eli Zaretskii <eliz@gnu.org>
1616
1617         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1618         m_line and m_start_of_line.
1619
1620 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1621
1622         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1623         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1624         it returns a newline.  This fixes a regression in TU mode, whereby
1625         the next line is output on the same screen line as the user input.
1626
1627 2019-03-18  Tom Tromey  <tromey@adacore.com>
1628
1629         * minsyms.c (minimal_symbol_reader::install): Remove call to
1630         obstack_blank.
1631
1632 2019-03-18  Pedro Alves  <palves@redhat.com>
1633
1634         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1635         New globals.
1636         (apply_style): New, factored out from ...
1637         (apply_ansi_escape): ... this.  Handle reverse video mode.
1638         (tui_set_reverse_mode): New function.
1639         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1640         * tui/tui-winsource.c (tui_show_source_line): Use
1641         tui_set_reverse_mode instead of setting A_STANDOUT.
1642         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1643         New setter methods.
1644
1645 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1646
1647         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1648         Handle tabs.
1649
1650 2019-03-18  Tom Tromey  <tromey@adacore.com>
1651
1652         * ada-lang.c (empty_array): Add "high" parameter.
1653         (ada_evaluate_subexp): Update.
1654
1655 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1656
1657         * unittests/string_view-selftests.c: Define
1658         _initialize_string_view_selftests unconditionally.
1659
1660 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1661
1662         PR gdb/24350
1663         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1664
1665 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1666
1667         PR gdb/24351
1668         * windows-nat.c (display_selector): Fix format specifiers.
1669
1670 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1671
1672         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1673         tui_refill_source_window instead of tui_refresh_win, to update the
1674         current execution line.  This fixes redisplay of the current line
1675         when stepping through the code with "next" or "step".
1676
1677 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1678
1679         * source-cache.c (source_cache::get_source_lines): Call
1680         find_source_lines to initialize s->nlines.  This fixes vertical
1681         scrolling of TUI source window when the DOWN arrow is pressed.
1682
1683 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1684
1685         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1686         linux-thread-db.c (_initialize_thread_db): Likewise.
1687
1688 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1689
1690         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1691         wclrtoeol in tui_show_source_line".  This reverts changes made in
1692         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1693
1694 2019-03-15  Tom Tromey  <tom@tromey.com>
1695
1696         * symtab.h (struct minimal_symbol): Derive from
1697         general_symbol_info.
1698         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1699         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1700         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1701         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1702         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1703         (MSYMBOL_SEARCH_NAME): Update.
1704         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1705         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1706         * minsyms.c (minimal_symbol_reader::record_full): Update.
1707
1708 2019-03-15  Tom Tromey  <tom@tromey.com>
1709
1710         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1711
1712 2019-03-15  Tom Tromey  <tom@tromey.com>
1713
1714         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1715         unique_xmalloc_ptr.
1716         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1717         Update.
1718         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1719         (build_minimal_symbol_hash_tables)
1720         (minimal_symbol_reader::install): Update.
1721
1722 2019-03-15  Tom Tromey  <tom@tromey.com>
1723
1724         * symtab.c (create_demangled_names_hash): Update.
1725         (symbol_set_names): Update.
1726         * objfiles.h (struct objfile_per_bfd_storage)
1727         <demangled_names_hash>: Now an htab_up.
1728         * objfiles.c (objfile_per_bfd_storage): Simplify.
1729
1730 2019-03-15  Tom Tromey  <tom@tromey.com>
1731
1732         * objfiles.h (struct objfile_per_bfd_storage): Declare
1733         destructor.
1734         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1735         New.
1736         (get_objfile_bfd_data): Use new.  Don't initialize
1737         language_of_main.
1738         (free_objfile_per_bfd_storage): Remove.
1739         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1740
1741 2019-03-15  Tom Tromey  <tom@tromey.com>
1742
1743         * symfile.c (reread_symbols): Update.
1744         * objfiles.c (objfile::objfile): Update.
1745         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1746         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1747         comment.
1748         (minimal_symbol_reader::install): Update.
1749         (terminate_minimal_symbol_table): Remove.
1750         * jit.c (jit_object_close_impl): Update.
1751
1752 2019-03-15  Tom Tromey  <tom@tromey.com>
1753
1754         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1755         initializations.
1756
1757 2019-03-15  Tom Tromey  <tom@tromey.com>
1758
1759         * objfiles.h (struct objfile_per_bfd_storage)
1760         <demangled_hash_languages>: Now a bitset.
1761         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1762         (lookup_minimal_symbol): Update.
1763
1764 2019-03-15  Tom Tromey  <tom@tromey.com>
1765
1766         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1767         Don't return the symbol.
1768         * coffread.c (record_minimal_symbol): Use record_full.
1769
1770 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1771
1772         The MS-Windows port of ncurses fails to switch to a color pair if
1773         one or both of the colors are the implicit default colors.  This
1774         change records the default colors when TUI is initialized, and
1775         then specifies them explicitly when a color pair uses the default
1776         colors.  This allows color styling in TUI mode on MS-Windows.
1777
1778         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1779         ncurses_norm_attr.
1780         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1781         colors in ncurses_norm_attr.
1782         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1783         "none", replace it with the default color recorded in
1784         ncurses_norm_attr.
1785
1786 2019-03-14  Tom Tromey  <tromey@adacore.com>
1787
1788         * source-cache.h (class source_cache) <get_source_lines>: Return
1789         std::string.
1790         * source-cache.c (source_cache::extract_lines): Handle case where
1791         first_pos==npos.  Return std::string.
1792         (source_cache::get_source_lines): Update.
1793
1794 2019-03-14  Tom Tromey  <tromey@adacore.com>
1795
1796         * NEWS: Add item for "style sources" commands.
1797         * source-cache.c (source_cache::get_source_lines): Check
1798         source_styling.
1799         * cli/cli-style.c (source_styling): New global.
1800         (_initialize_cli_style): Add "style sources" commands.
1801         (show_style_sources): New function.
1802         * cli/cli-style.h (source_styling): Declare.
1803
1804 2019-03-14  Pedro Alves  <palves@redhat.com>
1805             Tom Tromey  <tromey@adacore.com>
1806
1807         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1808         * tui/tui-winsource.c (tui_refill_source_window): New function,
1809         from...
1810         (tui_horizontal_source_scroll): ... here.  Move some logic.
1811         * cli/cli-style.c (set_style_enabled): Notify new observable.
1812         * tui/tui-hooks.c (tui_redisplay_source): New function.
1813         (tui_attach_detach_observers): Attach or detach
1814         tui_redisplay_source.
1815         * observable.h (source_styling_changed): New observable.
1816         * observable.c: Define source_styling_changed observable.
1817
1818 2019-03-13  Tom Tromey  <tromey@adacore.com>
1819
1820         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1821         (i386_gnu_nat_target::store_registers): Update.
1822         * target-debug.h (target_debug_print_std_string): New macro.
1823         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1824         * windows-tdep.c (display_one_tib): Update.
1825         * tui/tui-stack.c (tui_make_status_line): Update.
1826         * top.c (print_inferior_quit_action): Update.
1827         * thread.c (thr_try_catch_cmd): Update.
1828         (add_thread_with_info): Update.
1829         (thread_target_id_str): Update.
1830         (thr_try_catch_cmd): Update.
1831         (thread_command): Update.
1832         (thread_find_command): Update.
1833         * record-btrace.c (record_btrace_target::info_record)
1834         (record_btrace_resume_thread, record_btrace_target::resume)
1835         (record_btrace_cancel_resume, record_btrace_step_thread)
1836         (record_btrace_target::wait, record_btrace_target::wait)
1837         (record_btrace_target::wait, record_btrace_target::stop): Update.
1838         * progspace.c (print_program_space): Update.
1839         * process-stratum-target.c
1840         (process_stratum_target::thread_address_space): Update.
1841         * linux-fork.c (linux_fork_mourn_inferior)
1842         (detach_checkpoint_command, info_checkpoints_command)
1843         (linux_fork_context): Update.
1844         (linux_fork_detach): Update.
1845         (class scoped_switch_fork_info): Update.
1846         (delete_checkpoint_command): Update.
1847         * infrun.c (follow_fork_inferior): Update.
1848         (follow_fork_inferior): Update.
1849         (proceed_after_vfork_done): Update.
1850         (handle_vfork_child_exec_or_exit): Update.
1851         (follow_exec): Update.
1852         (displaced_step_prepare_throw): Update.
1853         (displaced_step_restore): Update.
1854         (start_step_over): Update.
1855         (resume_1): Update.
1856         (clear_proceed_status_thread): Update.
1857         (proceed): Update.
1858         (print_target_wait_results): Update.
1859         (do_target_wait): Update.
1860         (context_switch): Update.
1861         (stop_all_threads): Update.
1862         (restart_threads): Update.
1863         (finish_step_over): Update.
1864         (handle_signal_stop): Update.
1865         (switch_back_to_stepped_thread): Update.
1866         (keep_going_pass_signal): Update.
1867         (print_exited_reason): Update.
1868         (normal_stop): Update.
1869         * inferior.c (inferior_pid_to_str): Change return type.
1870         (print_selected_inferior): Update.
1871         (add_inferior): Update.
1872         (detach_inferior): Update.
1873         * dummy-frame.c (fprint_dummy_frames): Update.
1874         * dcache.c (dcache_info_1): Update.
1875         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
1876         (btrace_fetch, btrace_clear): Update.
1877         * linux-tdep.c (linux_core_pid_to_str): Change return type.
1878         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
1879         type.
1880         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
1881         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
1882         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
1883         * gdbarch.c, gdbarch.h: Rebuild.
1884         * gdbarch.sh (core_pid_to_str): Change return type.
1885         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
1886         return type.
1887         (windows_nat_target::pid_to_str): Change return type.
1888         (windows_delete_thread): Update.
1889         (windows_nat_target::attach): Update.
1890         (windows_nat_target::files_info): Update.
1891         * target-delegates.c: Rebuild.
1892         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
1893         return type.
1894         (sol_thread_target::pid_to_str): Change return type.
1895         * remote.c (class remote_target) <pid_to_str>: Change return
1896         type.
1897         (remote_target::pid_to_str): Change return type.
1898         (extended_remote_target::attach, remote_target::remote_stop_ns)
1899         (remote_target::remote_notif_remove_queued_reply)
1900         (remote_target::push_stop_reply, remote_target::disable_btrace):
1901         Update.
1902         (extended_remote_target::attach): Update.
1903         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
1904         type.
1905         (gdbsim_target::pid_to_str): Change return type.
1906         * ravenscar-thread.c (struct ravenscar_thread_target)
1907         <pid_to_str>: Change return type.
1908         (ravenscar_thread_target::pid_to_str): Change return type.
1909         * procfs.c (class procfs_target) <pid_to_str>: Change return
1910         type.
1911         (procfs_target::pid_to_str): Change return type.
1912         (procfs_target::attach): Update.
1913         (procfs_target::detach): Update.
1914         (procfs_target::fetch_registers): Update.
1915         (procfs_target::store_registers): Update.
1916         (procfs_target::wait): Update.
1917         (procfs_target::files_info): Update.
1918         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
1919         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
1920         return type.
1921         (nto_procfs_target::pid_to_str): Change return type.
1922         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
1923         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
1924         return type.
1925         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
1926         (exit_lwp): Update.
1927         (attach_proc_task_lwp_callback, get_detach_signal)
1928         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
1929         (linux_nat_target::resume, wait_lwp, stop_callback)
1930         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
1931         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
1932         (linux_nat_wait_1, resume_stopped_resumed_lwps)
1933         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
1934         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
1935         type.
1936         (inf_ptrace_target::attach): Update.
1937         (inf_ptrace_target::files_info): Update.
1938         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
1939         type.
1940         (go32_nat_target::pid_to_str): Change return type.
1941         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
1942         (gnu_nat_target::wait): Update.
1943         (gnu_nat_target::wait): Update.
1944         (gnu_nat_target::resume): Update.
1945         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
1946         (fbsd_nat_target::wait): Update.
1947         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
1948         type.
1949         (darwin_nat_target::attach): Update.
1950         * corelow.c (class core_target) <pid_to_str>: Change return type.
1951         (core_target::pid_to_str): Change return type.
1952         * target.c (normal_pid_to_str): Change return type.
1953         (default_pid_to_str): Likewise.
1954         (target_pid_to_str): Change return type.
1955         (target_translate_tls_address): Update.
1956         (target_announce_detach): Update.
1957         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
1958         return type.
1959         (bsd_uthread_target::pid_to_str): Change return type.
1960         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
1961         type.
1962         (bsd_kvm_target::pid_to_str): Change return type.
1963         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
1964         return type.
1965         (aix_thread_target::pid_to_str): Change return type.
1966         * target.h (struct target_ops) <pid_to_str>: Change return type.
1967         (target_pid_to_str, normal_pid_to_str): Likewise.
1968         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
1969         type.
1970         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
1971         type.
1972         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
1973         return type.
1974         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
1975         type.
1976         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
1977         type.
1978         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
1979         return type.
1980
1981 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
1982
1983         * NEWS: Mention that the new default MI version is 3.  Mention
1984         changes to the output of commands and events that deal with
1985         multi-location breakpoints.
1986         * breakpoint.c: Include "mi/mi-out.h".
1987         (print_one_breakpoint): Change output syntax if using MI version
1988         >= 3.
1989         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
1990         New.
1991         (mi_multi_location_breakpoint_output_fixed): New.
1992         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
1993         (mi_cmd_fix_multi_location_breakpoint_output): New.
1994         (mi_multi_location_breakpoint_output_fixed): New.
1995         * mi/mi-cmds.c (mi_cmds): Register command
1996         -fix-multi-location-breakpoint-output.
1997         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
1998         interpreter "mi".
1999
2000 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2001
2002         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2003         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2004         instantiate mi_ui_out based on interpreter name.
2005         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2006         * mi/mi-main.c (mi_load_progress): Likewise.
2007
2008 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2009
2010         * NEWS: Combine separate "New targets" sections for 8.3.
2011
2012 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2013
2014         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2015         (ppcfbsd_init_abi): Install gdbarch
2016         "fetch_tls_load_module_address" and "get_thread_local_address"
2017         methods.
2018
2019 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2020
2021         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2022         (riscv_fbsd_init_abi): Install gdbarch
2023         "fetch_tls_load_module_address" and "get_thread_local_address"
2024         methods.
2025
2026 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2027
2028         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2029         (i386fbsd_init_abi): Install gdbarch
2030         "fetch_tls_load_module_address" and "get_thread_local_address"
2031         methods.
2032
2033 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2034
2035         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2036         (amd64fbsd_init_abi): Install gdbarch
2037         "fetch_tls_load_module_address" and "get_thread_local_address"
2038         methods.
2039
2040 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2041
2042         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2043         (struct fbsd_pspace_data): New type.
2044         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2045         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2046         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2047         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2048         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2049
2050 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2051
2052         * gdbtypes.c (lookup_struct_elt): New function.
2053         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2054         * gdbtypes.h (struct struct_elt): New type.
2055         (lookup_struct_elt): New prototype.
2056
2057 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2058
2059         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2060         remove disabled code block.
2061
2062 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2063
2064         * gdbarch.sh (get_thread_local_address): New method.
2065         * gdbarch.h, gdbarch.c: Regenerate.
2066         * target.c (target_translate_tls_address): Use
2067         gdbarch_get_thread_local_address if present instead of
2068         target::get_thread_local_address.
2069
2070 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2071
2072         * target.h (target::get_thread_local_address): Update comment.
2073
2074 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2075
2076         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2077         objfile->separate_debug_objfile_backlink if not NULL.
2078
2079 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2080
2081         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2082         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2083         (amd64bsd_store_inferior_registers): Likewise.
2084         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2085         Enable segment base registers.
2086         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2087         PT_GETFSBASE and PT_GETGSBASE.
2088         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2089         PT_SETGSBASE.
2090         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2091         segment base registers.
2092         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2093
2094 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2095
2096         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2097         Update calls to i386_target_description to add 'segments'
2098         parameter.
2099         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2100         add segment base registers.
2101         * arch/i386.c (i386_create_target_description): Add 'segments'
2102         parameter to enable segment base registers.
2103         * arch/i386.h (i386_create_target_description): Likewise.
2104         * features/i386/32bit-segments.xml: New file.
2105         * features/i386/32bit-segments.c: Generate.
2106         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2107         call to i386_target_description to add 'segments' parameter.
2108         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2109         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2110         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2111         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2112         if feature is present.
2113         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2114         Add 'segments' parameter to call to i386_target_description.
2115         (i386_target_description): Add 'segments' parameter to enable
2116         segment base registers.
2117         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2118         to call to i386_target_description.
2119         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2120         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2121         Define I386_NUM_REGS.
2122         (i386_target_description): Add 'segments' parameter to enable
2123         segment base registers.
2124
2125 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2126
2127         PR/24325
2128         * source-cache.c: #undef open and close, to avoid unresolved
2129         externals during linking.
2130
2131 2019-03-12  Tom Tromey  <tromey@adacore.com>
2132
2133         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2134         const.  Add initializers.
2135         (_initialize_remote): Don't initialize ptid globals.
2136
2137 2019-03-12  Pedro Alves  <palves@redhat.com>
2138
2139         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2140
2141 2019-03-12  Pedro Alves  <palves@redhat.com>
2142
2143         * cp-name-parser.y (main): Remove unused 'len' variable.
2144
2145 2019-03-12  Tom Tromey  <tromey@adacore.com>
2146
2147         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2148         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2149
2150 2019-03-12  Tom Tromey  <tromey@adacore.com>
2151
2152         * linux-nat.c (iterate_over_lwps): Update.
2153         (stop_callback): Remove parameter.
2154         (stop_wait_callback, detach_callback, resume_set_callback)
2155         (select_singlestep_lwp_callback, set_ignore_sigint)
2156         (status_callback, resumed_callback, resume_clear_callback)
2157         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2158         data parameter.
2159         (linux_nat_target::detach, linux_nat_target::resume)
2160         (linux_stop_and_wait_all_lwps, select_event_lwp)
2161         (linux_nat_filter_event, linux_nat_wait_1)
2162         (linux_nat_target::kill, linux_nat_target::stop)
2163         (linux_nat_target::stop): Update.
2164         (linux_nat_resume_callback): Change type.
2165         (resume_stopped_resumed_lwps, count_events_callback)
2166         (select_event_lwp_callback): Likewise.
2167         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2168         * arm-linux-nat.c (struct update_registers_data): Remove.
2169         (update_registers_callback): Change type.
2170         (arm_linux_insert_hw_breakpoint1): Update.
2171         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2172         parameter.
2173         (x86_linux_dr_set_addr): Update.
2174         (x86_linux_dr_set_control): Update.
2175         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2176         (iterate_over_lwps): Use gdb::function_view.
2177         * nat/aarch64-linux-hw-point.c (struct
2178         aarch64_dr_update_callback_param): Remove.
2179         (debug_reg_change_callback): Change type.
2180         (aarch64_notify_debug_reg_change): Update.
2181         * s390-linux-nat.c (s390_refresh_per_info): Update.
2182
2183 2019-03-11  Tom Tromey  <tromey@adacore.com>
2184
2185         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2186         redundant assignment to "this_cu".
2187
2188 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2189
2190         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2191
2192 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2193
2194         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2195         from...
2196         (rank_one_type): ... this.
2197
2198 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2199
2200         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2201         from...
2202         (rank_one_type): ... this.
2203
2204 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2205
2206         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2207         from...
2208         (rank_one_type): ... this.
2209
2210 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2211
2212         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2213         from...
2214         (rank_one_type): ... this.
2215
2216 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2217
2218         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2219         from...
2220         (rank_one_type): ... this.
2221
2222 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2223
2224         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2225         from...
2226         (rank_one_type): ... this.
2227
2228 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2229
2230         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2231         from...
2232         (rank_one_type): ... this.
2233
2234 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2235
2236         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2237         from...
2238         (rank_one_type): ... this.
2239
2240 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2241
2242         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2243         from...
2244         (rank_one_type): ... this.
2245
2246 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2247
2248         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2249         from...
2250         (rank_one_type): ... this.
2251
2252 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2253
2254         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2255         from...
2256         (rank_one_type): ... this.
2257
2258 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2259
2260         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2261         from...
2262         (rank_one_type): ... this.
2263
2264 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2265
2266         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2267         inferior-events' shows the example events.
2268
2269 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2270
2271         Support styling on native MS-Windows console
2272
2273         PR/24315
2274         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2275         on MS-Windows if $TERM is not defined.
2276
2277         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2278
2279         * posix-hdep.c (gdb_console_fputs):
2280         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2281         functions.
2282         * ui-file.h (gdb_console_fputs): Add prototype.
2283
2284         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2285         back to fputs only if the former returns zero.
2286
2287 2019-03-07  Tom Tromey  <tom@tromey.com>
2288
2289         * symmisc.c (print_symbol_bcache_statistics): Update.
2290         (print_objfile_statistics): Update.
2291         * symfile.c (allocate_symtab): Update.
2292         * stabsread.c: Don't include bcache.h.
2293         * psymtab.h (struct psymbol_bcache): Don't declare.
2294         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2295         (psymbol_bcache_init, psymbol_bcache_free)
2296         (psymbol_bcache_get_bcache): Don't declare.
2297         * psymtab.c (struct psymbol_bcache): Remove.
2298         (psymtab_storage::psymtab_storage): Update.
2299         (psymtab_storage::~psymtab_storage): Update.
2300         (psymbol_bcache_init, psymbol_bcache_free)
2301         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2302         (add_psymbol_to_bcache): Update.
2303         (allocate_psymtab): Update.
2304         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2305         macro_cache>: No longer pointers.
2306         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2307         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2308         * macrotab.c (macro_bcache): Update.
2309         * macroexp.c: Don't include bcache.h.
2310         * gdbtypes.c (check_types_worklist): Update.
2311         (types_deeply_equal): Remove TRY/CATCH.  Update.
2312         * elfread.c (elf_symtab_read): Update.
2313         * dwarf2read.c: Don't include bcache.h.
2314         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2315         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2316         (print_bcache_statistics, bcache_memory_used): Don't declare.
2317         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2318         methods.  Rename all data members.
2319         * bcache.c (struct bcache): Move to bcache.h.
2320         (bcache::expand_hash_table): Rename from expand_hash_table.
2321         (bcache): Remove.
2322         (bcache::insert): Rename from bcache_full.
2323         (bcache::compare): Rename from bcache_compare.
2324         (bcache_xmalloc): Remove.
2325         (bcache::~bcache): Rename from bcache_xfree.
2326         (bcache::print_statistics): Rename from print_bcache_statistics.
2327         (bcache::memory_used): Rename from bcache_memory_used.
2328
2329 2019-03-07  Pedro Alves  <palves@redhat.com>
2330
2331         * infrun.c (normal_stop): Also check for
2332         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2333
2334 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2335
2336         * f-lang.c (value_from_host_double): Moved to...
2337         * value.c (value_from_host_double): ...here.
2338         * value.h (value_from_host_double): Declare.
2339         * guile/scm-math.c (vlscm_convert_typed_number): Use
2340         value_from_host_double.
2341         (vlscm_convert_number): Likewise.
2342         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2343         * python/py-value.c (convert_value_from_python): Likewise.
2344
2345 2019-03-06  Tom Tromey  <tom@tromey.com>
2346
2347         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2348
2349 2019-03-06  Tom Tromey  <tom@tromey.com>
2350
2351         * utils.h (free_current_contents): Don't declare.
2352         * utils.c (free_current_contents): Remove.
2353
2354 2019-03-06  Tom Tromey  <tom@tromey.com>
2355
2356         * top.c (quit_force): Update.
2357         * main.c (captured_command_loop): Update.
2358         * common/new-op.c (operator new): Update.
2359         * common/common-exceptions.c (struct catcher)
2360         <save_cleanup_chain>: Remove member.
2361         (exceptions_state_mc_init): Update.
2362         (exception_try_scope_entry): Return nullptr.
2363         (exception_try_scope_exit, exception_rethrow)
2364         (throw_exception_sjlj, throw_exception_cxx): Update.
2365         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2366         (all_cleanups, do_cleanups, discard_cleanups)
2367         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2368         (restore_cleanups, restore_final_cleanups): Don't declare.
2369         (do_final_cleanups): Remove parameter.
2370         * common/cleanups.c (cleanup_chain, make_cleanup)
2371         (make_cleanup_dtor, all_cleanups, do_cleanups)
2372         (discard_my_cleanups, discard_cleanups)
2373         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2374         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2375         (null_cleanup): Remove.
2376         (do_final_cleanups): Remove parameter.
2377
2378 2019-03-06  Tom Tromey  <tom@tromey.com>
2379
2380         * remote.c (remote_target::remote_parse_stop_reply): Use
2381         unique_xmalloc_ptr.
2382
2383 2019-03-06  Tom Tromey  <tom@tromey.com>
2384
2385         * stabsread.c (struct stabs_field_info): Rename from field_info.
2386         <list, fnlist>: Add initializers.
2387         <obstack>: New member.
2388         (read_member_functions, read_struct_fields, read_baseclasses):
2389         Allocate on obstack.  Don't use cleanups.
2390         (read_one_struct_field, read_member_functions, read_struct_fields)
2391         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2392         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2393         (read_struct_type): Update.
2394
2395 2019-03-06  Tom Tromey  <tom@tromey.com>
2396
2397         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2398         * common/filestuff.h (make_cleanup_close): Don't declare.
2399         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2400         Remove.
2401
2402 2019-03-06  Tom Tromey  <tom@tromey.com>
2403
2404         * solib-aix.c: Use make_scope_exit.
2405
2406 2019-03-06  Tom Tromey  <tom@tromey.com>
2407
2408         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2409         Use make_scope_exit.
2410
2411 2019-03-06  Tom Tromey  <tom@tromey.com>
2412
2413         * solib-svr4.c (disable_probes_interface): Remove parameter.
2414         (svr4_handle_solib_event): Use make_scope_exit.
2415
2416 2019-03-06  Tom Tromey  <tom@tromey.com>
2417
2418         * remote.c (struct stop_reply_deleter): Remove.
2419         (stop_reply_up): Update.
2420         (struct stop_reply): Derive from notif_event.  Don't typedef.
2421         <regcache>: Now a std::vector.
2422         (stop_reply_xfree): Remove.
2423         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2424         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2425         (remote_target::discard_pending_stop_replies): Use delete.
2426         (remote_target::remote_parse_stop_reply): Update.
2427         (remote_target::process_stop_reply): Update.
2428         * remote-notif.h (struct notif_event): Add virtual destructor.
2429         Remove "dtr" member.
2430         (struct notif_client) <alloc_event>: Return a unique_ptr.
2431         (notif_event_xfree): Don't declare.
2432         (notif_event_up): New typedef.
2433         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2434         (notif_event_xfree, do_notif_event_xfree): Remove.
2435         (remote_notif_state_xfree): Update.
2436
2437 2019-03-06  Tom Tromey  <tom@tromey.com>
2438
2439         * infrun.c (displaced_step_clear_cleanup): Now a
2440         forward_scope_exit type.
2441         (displaced_step_prepare_throw): Update.
2442         (displaced_step_fixup): Update.
2443
2444 2019-03-06  Tom Tromey  <tom@tromey.com>
2445
2446         * inferior.h (class inferior): Update comment.
2447         * gdbthread.h (class thread_info): Update comment.
2448
2449 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2450             Tom Tromey  <tom@tromey.com>
2451
2452         * stabsread.h (struct stab_section_list): Remove.
2453         (coffstab_build_psymtabs): Update.
2454         * dbxread.c (symbuf_sections): Now a std::vector.
2455         (sect_idx): New global.
2456         (fill_symbuf): Update.
2457         (coffstab_build_psymtabs): Change type of stabsects parameter.
2458         Update.
2459         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2460         std::vector.
2461         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2462         (coff_locate_sections): Update.
2463         (coff_symfile_read): Remove cleanups.  Update.
2464         (init_stringtab): Add storage parameter.
2465         (free_stringtab, free_stringtab_cleanup): Remove.
2466         (init_lineno): Add storage parameter.
2467         (free_linetab, free_linetab_cleanup): Remove.
2468
2469 2019-03-06  Pedro Alves  <palves@redhat.com>
2470
2471         * linux-fork.c (fork_info::clobber_regs): Delete.
2472         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2473         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2474         comment.  Adjust.
2475         (scoped_switch_fork_info::scoped_switch_fork_info)
2476         (checkpoint_command, linux_fork_context): Adjust
2477         fork_save_infrun_state calls.
2478
2479 2019-03-06  Pedro Alves  <palves@redhat.com>
2480
2481         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2482         (inf_has_multiple_threads): Return 'bool' and rewrite using
2483         inferior_info::threads().
2484
2485 2019-03-06  Pedro Alves  <palves@redhat.com>
2486
2487         * linux-fork.c: Include <list>.
2488         (fork_list): Now a std::list instance.
2489         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2490         (forks_exist_p, find_last_fork): Adjust.
2491         (new_fork): Delete.
2492         (one_fork_p): New.
2493         (add_fork): Adjust.
2494         (free_fork): Delete, folded into fork_info::~fork_info().
2495         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2496         Adjust.
2497         (init_fork_list): Delete.
2498         (linux_fork_killall, linux_fork_mourn_inferior)
2499         (linux_fork_detach, info_checkpoints_command): Adjust.
2500         (_initialize_linux_fork): No longer call init_fork_list.
2501
2502 2019-03-06  Pedro Alves  <palves@redhat.com>
2503
2504         * linux-fork.c (new_fork): New, split out of ...
2505         (add_fork): ... this.  Return void.  Move "first fork" special
2506         case from here, to ...
2507         (checkpoint_command): ... here.
2508         * linux-linux.h (add_fork): Return void.
2509
2510 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2511
2512         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2513
2514 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2515             Chris January  <chris.january@arm.com>
2516             David Lecomber  <david.lecomber@arm.com>
2517
2518         * f-exp.y: New token, UNOP_INTRINSIC.
2519         (exp): New pattern using UNOP_INTRINSIC token.
2520         (f77_keywords): Add 'abs' keyword.
2521         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2522         (value_from_host_double): New function.
2523         (evaluate_subexp_f): Support UNOP_ABS.
2524
2525 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2526
2527         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2528         types.
2529
2530 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2531
2532         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2533         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2534         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2535
2536 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2537
2538         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2539
2540 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2541             Chris January  <chris.january@arm.com>
2542
2543         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2544         * f-exp.y: Define 'KIND' token.
2545         (exp): New pattern for KIND expressions.
2546         (ptype): Handle types with a kind extension.
2547         (direct_abs_decl): Extend to spot kind extensions.
2548         (f77_keywords): Add 'kind' to the list.
2549         (push_kind_type): New function.
2550         (convert_to_kind_type): New function.
2551         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2552         * parse.c (operator_length_standard): Likewise.
2553         * parser-defs.h (enum type_pieces): Add tp_kind.
2554         * std-operator.def: Add UNOP_KIND.
2555
2556 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2557
2558         * f-exp.y (f_parse): Set yydebug.
2559
2560 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2561
2562         * f-lang.c (evaluate_subexp_f): New function.
2563         (exp_descriptor_f): New global.
2564         (f_language_defn): Use exp_descriptor_f instead of
2565         exp_descriptor_standard.
2566
2567 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2568
2569         * f-exp.y (struct token): Add comments.
2570         (dot_ops): Remove uppercase versions and the end marker.
2571         (f77_keywords): Likewise.
2572         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2573         entries in the dot_ops array are case insensitive, and use
2574         strncasecmp to compare strings.  Also some whitespace cleanup in
2575         this area.  Similar for the f77_keywords array, except entries in
2576         this list might be case sensitive.
2577
2578 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2579
2580         * f-exp.y (struct f77_boolean_val): Add comments.
2581         (boolean_values): Remove uppercase versions, and end marker.
2582         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2583         and use strncasecmp to achieve case insensitivity.  Additionally,
2584         perform whitespace cleanup around this code.
2585
2586 2019-03-06  Tom Tromey  <tromey@adacore.com>
2587
2588         * remote-sim.c (gdbsim_target_open): Use result of
2589         gdb_argv::release.
2590
2591 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2592         Dirk Schubert  <dirk.schubert@arm.com>
2593         Chris January  <chris.january@arm.com>
2594
2595         * eval.c (evaluate_subexp_standard): Call Fortran argument
2596         wrapping logic.
2597         * f-lang.c (struct value): A value which can be passed into a
2598         Fortran function call.
2599         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2600         where appropriate.
2601         (struct type): Value ready for a Fortran function call.
2602         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2603         is needed.
2604         * f-lang.h (fortran_argument_convert): Declaration.
2605         (fortran_preserve_arg_pointer): Declaration.
2606         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2607
2608 2019-03-05  Tom Tromey  <tromey@adacore.com>
2609
2610         * python/py-prettyprint.c (print_string_repr): Remove #if.
2611         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2612
2613 2019-03-05  Tom Tromey  <tromey@adacore.com>
2614
2615         * target.c (the_dummy_target): Move later.  Change type to
2616         "dummy_target".
2617         (initialize_targets): Don't initialize the_dummy_target.
2618
2619 2019-03-05  Tom Tromey  <tromey@adacore.com>
2620
2621         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2622         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2623
2624 2019-03-05  Tom Tromey  <tromey@adacore.com>
2625
2626         * windows-nat.c (windows_nat_target::attach)
2627         (windows_nat_target::detach): Don't call gdb_flush.
2628         * valprint.c (generic_val_print, val_print, val_print_string):
2629         Don't call gdb_flush.
2630         * utils.c (defaulted_query): Don't call gdb_flush.
2631         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2632         * target.c (target_announce_detach): Don't call gdb_flush.
2633         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2634         * remote.c (extended_remote_target::attach): Don't call
2635         gdb_flush.
2636         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2637         * printcmd.c (do_examine): Don't call gdb_flush.
2638         (info_display_command): Don't call gdb_flush.
2639         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2640         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2641         * memattr.c (info_mem_command): Don't call gdb_flush.
2642         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2643         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2644         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2645         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2646         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2647         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2648         (gnu_nat_target::detach): Don't call gdb_flush.
2649         * f-valprint.c (f_val_print): Don't call gdb_flush.
2650         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2651         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2652         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2653         gdb_flush.
2654         * c-valprint.c (c_val_print): Don't call gdb_flush.
2655         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2656
2657 2019-03-05  Tom Tromey  <tromey@adacore.com>
2658
2659         * varobj.c (update_dynamic_varobj_children): Update.
2660         (install_default_visualizer): Use reset, not release.
2661         * value.c (set_internalvar): Update.
2662         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2663         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2664         ATTRIBUTE_UNUSED_RESULT.
2665
2666 2019-03-05  Tom Tromey  <tromey@adacore.com>
2667
2668         * remote.c (class scoped_remote_fd) <release>: Add
2669         ATTRIBUTE_UNUSED_RESULT.
2670
2671 2019-03-05  Tom Tromey  <tromey@adacore.com>
2672
2673         * macroexp.c (struct macro_buffer) <release>: Add
2674         ATTRIBUTE_UNUSED_RESULT.
2675
2676 2019-03-05  Tom Tromey  <tromey@adacore.com>
2677
2678         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2679         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2680         ATTRIBUTE_UNUSED_RESULT.
2681
2682 2019-03-05  Tom Tromey  <tromey@adacore.com>
2683
2684         * common/scoped_fd.h (class scoped_fd) <release>: Add
2685         ATTRIBUTE_UNUSED_RESULT.
2686
2687 2019-03-05  Tom Tromey  <tromey@adacore.com>
2688
2689         * parser-defs.h (struct parser_state) <release>: Add
2690         ATTRIBUTE_UNUSED_RESULT.
2691
2692 2019-03-05  Tom Tromey  <tromey@adacore.com>
2693
2694         * utils.h (class gdb_argv) <release>: Add
2695         ATTRIBUTE_UNUSED_RESULT.
2696         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2697
2698 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2699
2700         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2701         for-loop range, to avoid compiler warnings.
2702
2703         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2704         avoid compiler warnings about unused variables.
2705
2706         * NEWS: Mention end of support for native debugging on MS-Windows
2707         before XP.
2708
2709         PR gdb/24292
2710         * common/netstuff.c:
2711         * gdbserver/gdbreplay.c
2712         * gdbserver/remote-utils.c:
2713         * ser-tcp.c:
2714         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2715         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2716         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2717         'getaddrinfo' and 'freeaddrinfo' were not available before
2718         Windows XP, and mingw.org's MinGW headers by default define
2719         _WIN32_WINNT to 0x500.
2720
2721 2019-03-01  Gary Benson <gbenson@redhat.com>
2722
2723         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2724
2725 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2726             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2727
2728         PR gdb/8527
2729         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2730         set_sigint_trap, clear_sigint_trap.
2731
2732 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2733
2734         * target.c (target_detach): Clear the regcache and the
2735         frame cache.
2736
2737 2019-02-27  Pedro Alves  <palves@redhat.com>
2738
2739         * utils.c (set_screen_size): When we cap the height/width sizes,
2740         tweak the corresponding command variable to show "unlimited":
2741
2742 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2743             Pedro Alves  <palves@redhat.com>
2744
2745         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2746         before calling rl_set_screen_size.
2747
2748 2019-02-27  Tom Tromey  <tromey@adacore.com>
2749
2750         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2751         define.
2752         * python/py-value.c: Remove Python 2.4 workaround.
2753         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2754         workaround.
2755         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2756         Python 2.4 workaround.
2757         * python/python-internal.h: Remove Python 2.4 comment.
2758         (Py_ssize_t): Don't define.
2759         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2760         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2761         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2762         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2763         * python/python.c (do_start_initialization): Remove Python 2.4
2764         workaround.
2765         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2766         (print_children): Remove Python 2.4 workaround.
2767         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2768         workaround.
2769         (CHARBUFFERPROC_NAME): Remove.
2770         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2771         Python 2.4 workaround.
2772
2773 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2774
2775         * NEWS: Note minimum Python version.
2776
2777 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2778
2779         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2780         code from these functions.  Remove corresponding ifdefs.  Use
2781         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2782         Remove gotos and target of gotos.
2783         (infpy_search_memory): Likewise.
2784
2785 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2786
2787         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2788         (hppa_gdbarch_init): Don't register deleted functions with
2789         gdbarch.
2790
2791 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2792
2793         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2794         (h8300_unwind_sp): Delete.
2795         (h8300_dummy_id): Delete.
2796         (h8300_gdbarch_init): Don't register deleted functions with
2797         gdbarch.
2798
2799 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2800
2801         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2802         (ft32_unwind_pc): Delete.
2803         (ft32_unwind_sp): Delete.
2804         (ft32_gdbarch_init): Don't register deleted functions with
2805         gdbarch.
2806
2807 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2808
2809         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2810         (frv_unwind_pc): Delete.
2811         (frv_unwind_sp): Delete.
2812         (frv_gdbarch_init): Don't register deleted functions with
2813         gdbarch.
2814
2815 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2816
2817         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2818         (riscv_unwind_pc): Delete.
2819         (riscv_unwind_sp): Delete.
2820         (riscv_gdbarch_init): Don't register deleted functions with
2821         gdbarch.
2822
2823 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2824
2825         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2826         (csky_unwind_pc): Delete.
2827         (csky_unwind_sp): Delete.
2828         (csky_gdbarch_init): Don't register deleted functions with
2829         gdbarch.
2830
2831 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2832
2833         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2834         (cris_unwind_pc): Delete.
2835         (cris_unwind_sp): Delete.
2836         (cris_gdbarch_init): Don't register deleted functions with
2837         gdbarch.
2838
2839 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2840
2841         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2842         (bfin_unwind_pc): Delete.
2843         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2844
2845 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2846
2847         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2848         (arm_unwind_pc): Delete.
2849         (arm_unwind_sp): Delete.
2850         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2851
2852 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2853
2854         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2855         (arc_unwind_pc): Delete.
2856         (arc_unwind_sp): Delete.
2857         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2858
2859 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2860
2861         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
2862         (alpha_unwind_pc): Delete.
2863         (alpha_gdbarch_init): Don't register deleted functions with
2864         gdbarch.
2865
2866 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2867
2868         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
2869         (aarch64_unwind_pc): Delete.
2870         (aarch64_unwind_sp): Delete.
2871         (aarch64_gdbarch_init): Don't register deleted functions with
2872         gdbarch.
2873
2874 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2875
2876         * gdbtypes.c (type_align): Don't consider static members when
2877         computing structure alignment.
2878
2879 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2880
2881         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
2882         return 0 for other types.
2883         * arch-utils.c (default_type_align): Always return 0.
2884         * gdbarch.h: Regenerate.
2885         * gdbarch.sh (type_align): Extend comment.
2886         * gdbtypes.c (type_align): Add additional comments, always call
2887         gdbarch_type_align before applying the default rules.
2888         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2889         generic code will then apply a suitable default.
2890         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
2891         types, return 0 for other types.
2892
2893 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2894
2895         * NEWS: Create a new section for the next release branch.
2896         Rename the section of the current branch, now that it has
2897         been cut.
2898
2899 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2900
2901         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
2902         * version.in: Bump version to 8.3.50.DATE-git.
2903
2904 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
2905
2906         * aix-thread.c (ptid_cmp): Remove unused variable.
2907         (get_signaled_thread): Likewise.
2908         (store_regs_user_thread): Likewise.
2909         (store_regs_kernel_thread): Likewise.
2910         (fetch_regs_kernel_thread): Remove shadowed variable.
2911
2912 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2913
2914         * features/riscv/32bit-cpu.xml: Add register numbers.
2915         * features/riscv/32bit-fpu.c: Regenerate.
2916         * features/riscv/32bit-fpu.xml: Add register numbers.
2917         * features/riscv/64bit-cpu.xml: Add register numbers.
2918         * features/riscv/64bit-fpu.c: Regenerate.
2919         * features/riscv/64bit-fpu.xml: Add register numbers.
2920
2921 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
2922
2923         * NEWS: Mention two argument form of gdb.Value constructor.
2924         * python/py-value.c (convert_buffer_and_type_to_value): New
2925         function.
2926         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
2927         Add support for handling an optional second argument.  Call
2928         convert_buffer_and_type_to_value as appropriate.
2929         * python/python-internal.h (Py_buffer_deleter): New struct.
2930         (Py_buffer_up): New typedef.
2931
2932 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
2933
2934         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
2935         instead of releasing ownership.
2936
2937 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
2938
2939         * dwarf2read.c (open_and_init_dwp_file): Call
2940         elf_numsections instead of bfd_count_sections to initialize
2941         dwp_file->num_sections.
2942
2943 2019-02-25  Tom Tromey  <tromey@adacore.com>
2944
2945         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
2946
2947 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2948
2949         * gcore.in: Add '--readnever' option when invoking GDB.
2950
2951 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2952
2953         * MAINTAINERS: Update my email address.
2954
2955 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2956
2957         * build-id.c (build_id_to_debug_bfd_1): New function.
2958         (build_id_to_debug_bfd): Look for separate debug file in
2959         sysroot.
2960
2961 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2962
2963         * gdbarch.sh: Update the copyright year range that is placed into
2964         generated files.
2965
2966 2019-02-22  Keith Seitz  <keiths@redhat.com>
2967
2968         PR symtab/23853
2969         * linespec.c (create_sals_line_offset): Search for the default
2970         symtab's filename instead of its fullname.
2971
2972 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2973
2974         * NEWS: Update style defaults.
2975
2976 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2977
2978         * main.c (captured_main_1): Disable styling in batch mode.
2979
2980 2019-02-20  Tom Tromey  <tom@tromey.com>
2981
2982         * symtab.c (symtab_symbol_info): Fix typos.
2983
2984 2019-02-20  Tom Tromey  <tromey@adacore.com>
2985
2986         * findcmd.c (_initialize_mem_search): Use upper case for
2987         metasyntactic variables.
2988
2989 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
2990
2991         * aarch64-tdep.c (aarch64_add_reggroups): New function.
2992         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
2993
2994 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
2995
2996         * top.h (source_file_name): Change to std::string.
2997         * top.c (source_file_name): Likewise.
2998         (command_line_input): Adjust.
2999         * cli/cli-script.c (script_from_file): Adjust.
3000
3001 2019-02-19  Tom Tromey  <tromey@adacore.com>
3002
3003         * ravenscar-thread.c
3004         (ravenscar_thread_target::update_thread_list): Don't call
3005         ada_build_task_list.
3006         * ada-lang.h (ada_build_task_list): Don't declare.
3007         * ada-tasks.c (struct ada_tasks_inferior_data)
3008         <task_list_valid_p>: Now bool.
3009         (read_known_tasks, ada_task_list_changed)
3010         (ada_tasks_invalidate_inferior_data): Update.
3011         (read_known_tasks_array): Return bool.
3012         (read_known_tasks_list): Likewise.
3013         (read_known_tasks): Return void.
3014         (ada_build_task_list): Now static.
3015
3016 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3017
3018         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3019         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3020
3021 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3022
3023         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3024         variant for ada_tasks_pspace_data_handle and
3025         ada_tasks_inferior_data_handle.
3026         (ada_tasks_pspace_data_cleanup): New function.
3027         (ada_tasks_inferior_data_cleanup): New function.
3028
3029 2019-02-17  Tom Tromey  <tom@tromey.com>
3030
3031         * macrotab.h (macro_source_fullname): Return a std::string.
3032         * macrotab.c (macro_include, check_for_redefinition)
3033         (macro_undef, macro_lookup_definition, foreach_macro)
3034         (foreach_macro_in_scope): Update.
3035         (macro_source_fullname): Return a std::string.
3036         * macrocmd.c (show_pp_source_pos): Update.
3037
3038 2019-02-17  Tom Tromey  <tom@tromey.com>
3039
3040         * macrocmd.c (show_pp_source_pos): Style the file names.
3041
3042 2019-02-17  Tom Tromey  <tom@tromey.com>
3043
3044         PR tui/24197:
3045         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3046
3047 2019-02-17  Tom Tromey  <tom@tromey.com>
3048
3049         * ada-lang.c (user_select_syms): Use filtered printing.
3050         * utils.c (wrap_style): New global.
3051         (desired_style): Remove.
3052         (emit_style_escape): Add stream parameter.
3053         (set_output_style, reset_terminal_style, prompt_for_continue):
3054         Update.
3055         (flush_wrap_buffer): Only flush gdb_stdout.
3056         (wrap_here): Set wrap_style.
3057         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3058         treat escape sequences as a character.  Change when wrap buffer is
3059         flushed.
3060         (fputs_styled): Do not set the output style when the default is
3061         requested.
3062         * ui-style.h (struct ui_file_style) <is_default>: New method.
3063         * source.c (print_source_lines_base): Emit escape sequences in one
3064         piece.
3065
3066 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3067
3068         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3069         integers and enumeration types.
3070
3071 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3072
3073         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3074         instead of lookup_symbol_in_language
3075         (do_exact_match): New function.
3076         (ada_get_symbol_name_matcher): Return do_exact_match when
3077         doing a verbatim match.
3078
3079 2019-02-15  Tom Tromey  <tromey@adacore.com>
3080
3081         * ravenscar-thread.c (ravenscar_thread_target::resume)
3082         (ravenscar_thread_target::wait): Special case wildcard requests.
3083
3084 2019-02-15  Tom Tromey  <tromey@adacore.com>
3085
3086         * ravenscar-thread.c (base_ptid): Remove.
3087         (struct ravenscar_thread_target) <close>: New method.
3088         <m_base_ptid>: New member.
3089         <update_inferior_ptid, active_task, task_is_currently_active,
3090         runtime_initialized>: Declare methods.
3091         <ravenscar_thread_target>: Add constructor.
3092         (ravenscar_thread_target::task_is_currently_active)
3093         (ravenscar_thread_target::update_inferior_ptid)
3094         (ravenscar_runtime_initialized): Rename.  Now methods.
3095         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3096         (ravenscar_thread_target::update_thread_list): Update.
3097         (ravenscar_thread_target::active_task): Now method.
3098         (ravenscar_thread_target::store_registers)
3099         (ravenscar_thread_target::prepare_to_store)
3100         (ravenscar_thread_target::prepare_to_store)
3101         (ravenscar_thread_target::mourn_inferior): Update.
3102         (ravenscar_inferior_created): Use "new" to create target.
3103         (ravenscar_thread_target::get_ada_task_ptid): Update.
3104         (_initialize_ravenscar): Don't initialize base_ptid.
3105         (ravenscar_ops): Remove global.
3106
3107 2019-02-15  Tom Tromey  <tromey@adacore.com>
3108
3109         * target.h (push_target): Declare new overload.
3110         * target.c (push_target): New overload, taking an rvalue reference.
3111         * remote.c (remote_target::open_1): Use push_target overload.
3112         * corelow.c (core_target_open): Use push_target overload.
3113
3114 2019-02-15  Tom Tromey  <tromey@adacore.com>
3115
3116         * ravenscar-thread.c (is_ravenscar_task)
3117         (ravenscar_task_is_currently_active): Return bool.
3118         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3119         (_initialize_ravenscar): Remove "(void)".
3120         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3121         Return bool.
3122
3123 2019-02-15  Tom Tromey  <tromey@adacore.com>
3124
3125         * ravenscar-thread.c (ravenscar_runtime_initializer)
3126         (has_ravenscar_runtime, get_running_thread_id)
3127         (ravenscar_thread_target::resume): Fix indentation.
3128
3129 2019-02-15  Tom Tromey  <tromey@adacore.com>
3130
3131         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3132         from ravenscar_arch_ops.
3133         (sparc_ravenscar_ops::fetch_registers)
3134         (sparc_ravenscar_ops::store_registers): Now methods.
3135         (sparc_ravenscar_prepare_to_store): Remove.
3136         (sparc_ravenscar_ops): Redefine.
3137         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3138         methods and destructor.  Remove members.
3139         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3140         (ravenscar_thread_target::store_registers)
3141         (ravenscar_thread_target::prepare_to_store): Update.
3142         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3143         Remove.
3144         (struct ppc_ravenscar_powerpc_ops): Derive from
3145         ravenscar_arch_ops.
3146         (ppc_ravenscar_powerpc_ops::fetch_registers)
3147         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3148         (ppc_ravenscar_powerpc_ops): Redefine.
3149         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3150         (ppc_ravenscar_e500_ops::fetch_registers)
3151         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3152         (ppc_ravenscar_e500_ops): Redefine.
3153         * aarch64-ravenscar-thread.c
3154         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3155         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3156         (aarch64_ravenscar_fetch_registers)
3157         (aarch64_ravenscar_store_registers): Now methods.
3158         (aarch64_ravenscar_ops): Redefine.
3159
3160 2019-02-15  Tom Tromey  <tromey@adacore.com>
3161
3162         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3163         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3164         (ravenscar_thread_target::stopped_by_watchpoint)
3165         (ravenscar_thread_target::stopped_data_address)
3166         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3167
3168 2019-02-15  Tom Tromey  <tromey@adacore.com>
3169
3170         * ravenscar-thread.c: Fix some typos.
3171
3172 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3173             Tom Tromey  <tromey@adacore.com>
3174
3175         * ada-lang.c (ada_exception_sal): Change addr_string to a
3176         std::string.
3177         (create_ada_exception_catchpoint): Update.
3178
3179 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3180             Tom Tromey  <tromey@adacore.com>
3181
3182         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3183         (bp_location_ops): Remove.
3184         (base_breakpoint_allocate_location): Update.
3185         (free_bp_location): Update.
3186         * ada-lang.c (class ada_catchpoint_location)
3187         <ada_catchpoint_location>: Remove ops parameter.
3188         (ada_catchpoint_location_dtor): Remove.
3189         (ada_catchpoint_location_ops): Remove.
3190         (allocate_location_exception): Update.
3191         * breakpoint.h (struct bp_location_ops): Remove.
3192         (class bp_location) <bp_location>: Remove bp_location_ops
3193         parameter.
3194         <~bp_location>: Add destructor.
3195         <ops>: Remove.
3196
3197 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3198             Pedro Alves  <palves@redhat.com>
3199
3200         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3201         'PATH_MAX'.
3202
3203 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3204             Samuel Thibault  <samuel.thibault@gnu.org>
3205             Thomas Schwinge  <thomas@codesourcery.com>
3206
3207         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3208         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3209
3210 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3211
3212         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3213         (check_empty): Use "const char *".
3214
3215         * gnu-nat.c (gnu_nat_target::detach): Instead of
3216         'detach_inferior (pid)' call
3217         'detach_inferior (find_inferior_pid (pid))'.
3218
3219         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3220         'nat/fork-inferior.o'.
3221         * gnu-nat.c: #include "nat/fork-inferior.h".
3222
3223         * gnu-nat.c (gnu_nat_target::detach): Instead of
3224         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3225         * gnu-nat.h: #include "inf-child.h".
3226         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3227         'i386_gnu_nat_target::fetch_registers'.
3228         (gnu_store_registers): Rename/move to
3229         'i386_gnu_nat_target::store_registers'.
3230
3231         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3232         * gnu-nat.h (mach_thread_info): New function.
3233         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3234
3235         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3236
3237 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3238
3239         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3240
3241 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3242
3243         * windows-nat.c (windows_add_thread): Add new parameter
3244         "main_thread_p" with default value set to false.  Update
3245         function documentation as well as all callers.
3246         (windows_delete_thread): Likewise.
3247         (fake_create_process): Update call to windows_add_thread.
3248         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3249         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3250         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3251         call to windows_delete_thread.
3252
3253 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3254
3255         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3256
3257 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3258
3259         * symfile.c (find_separate_debug_file): Use canonical path of
3260         sysroot with child_path instead of gdb_sysroot if it is valid.
3261
3262 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3263
3264         * symfile.c (find_separate_debug_file): Use child_path to
3265         determine if an object file is under a sysroot.
3266
3267 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3268
3269         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3270         unittests/child-path-selftests.c.
3271         * common/pathstuff.c (child_path): New function.
3272         * common/pathstuff.h (child_path): New prototype.
3273         * unittests/child-path-selftests.c: New file.
3274
3275 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3276
3277         * symfile.c (find_separate_debug_file): Look for separate debug
3278         files in debug directories under the sysroot.
3279
3280 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3281
3282         * symtab.h (struct minimal_symbol data_p): New const method.
3283         (struct minimal_symbol text_p): Likewise.
3284         * symtab.c (output_source_filename): Use file name style
3285         to print file name.
3286         (print_symbol_info): Likewise.
3287         (print_msymbol_info): Use address style to print addresses.
3288         Use function name style to print executable text symbols.
3289         (expand_symtab_containing_pc): Use data_p.
3290         (find_pc_sect_compunit_symtab): Likewise.
3291
3292 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3293
3294         * breakpoint.c (describe_other_breakpoints): Use address style
3295         to print addresses.
3296         (say_where): Likewise.
3297
3298 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3299
3300         * ada-typeprint.c (print_func_type): Print function name
3301         style to print function name.
3302         * c-typeprint.c (c_print_type_1): Likewise.
3303
3304 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3305
3306         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3307         for execve.
3308
3309 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3310
3311         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3312         type_stack.
3313
3314 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3315
3316         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3317         TYPE_CODE_REF types.
3318
3319 2019-02-08  Jim Wilson  <jimw@sifive.com>
3320
3321         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3322         (riscv_linux_fregset): New.
3323         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3324
3325 2019-02-07  Tom Tromey  <tom@tromey.com>
3326
3327         * thread.c (thread_cancel_execution_command): Update.
3328         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3329         methods.
3330         (struct thread_fsm_ops): Remove.
3331         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3332         (thread_fsm_should_stop, thread_fsm_return_value)
3333         (thread_fsm_set_finished, thread_fsm_finished_p)
3334         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3335         Don't declare.
3336         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3337         * infrun.c (clear_proceed_status_thread)
3338         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3339         (print_stop_event): Update.
3340         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3341         Add constructor.
3342         (step_command_fsm_ops): Remove.
3343         (new_step_command_fsm): Remove.
3344         (step_1): Update.
3345         (step_command_fsm::should_stop): Rename from
3346         step_command_fsm_should_stop.
3347         (step_command_fsm::clean_up): Rename from
3348         step_command_fsm_clean_up.
3349         (step_command_fsm::do_async_reply_reason): Rename from
3350         step_command_fsm_async_reply_reason.
3351         (struct until_next_fsm): Inherit from thread_fsm.  Add
3352         constructor.
3353         (until_next_fsm_ops): Remove.
3354         (new_until_next_fsm): Remove.
3355         (until_next_fsm::should_stop): Rename from
3356         until_next_fsm_should_stop.
3357         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3358         (until_next_fsm::do_async_reply_reason): Rename from
3359         until_next_fsm_async_reply_reason.
3360         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3361         constructor.  Change type of breakpoint.
3362         (finish_command_fsm_ops): Remove.
3363         (new_finish_command_fsm): Remove.
3364         (finish_command_fsm::should_stop): Rename from
3365         finish_command_fsm_should_stop.
3366         (finish_command_fsm::clean_up): Rename from
3367         finish_command_fsm_clean_up.
3368         (finish_command_fsm::return_value): Rename from
3369         finish_command_fsm_return_value.
3370         (finish_command_fsm::do_async_reply_reason): Rename from
3371         finish_command_fsm_async_reply_reason.
3372         (finish_command): Update.
3373         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3374         Add constructor.
3375         (call_thread_fsm_ops): Remove.
3376         (call_thread_fsm::call_thread_fsm): Rename from
3377         new_call_thread_fsm.
3378         (call_thread_fsm::should_stop): Rename from
3379         call_thread_fsm_should_stop.
3380         (call_thread_fsm::should_notify_stop): Rename from
3381         call_thread_fsm_should_notify_stop.
3382         (run_inferior_call, call_function_by_hand_dummy): Update.
3383         * cli/cli-interp.c (should_print_stop_to_console): Update.
3384         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3385         Add constructor.  Change type of location_breakpoint,
3386         caller_breakpoint.
3387         (until_break_fsm_ops): Remove.
3388         (new_until_break_fsm): Remove.
3389         (until_break_fsm::should_stop): Rename from
3390         until_break_fsm_should_stop.
3391         (until_break_fsm::clean_up): Rename from
3392         until_break_fsm_clean_up.
3393         (until_break_fsm::do_async_reply_reason): Rename from
3394         until_break_fsm_async_reply_reason.
3395         (until_break_command): Update.
3396         * thread-fsm.c: Remove.
3397         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3398
3399 2019-02-07  Tom Tromey  <tom@tromey.com>
3400
3401         * yy-remap.h: Add include guard.
3402         * xtensa-tdep.h: Add include guard.
3403         * xcoffread.h: Rename include guard.
3404         * varobj-iter.h: Add include guard.
3405         * tui/tui.h: Rename include guard.
3406         * tui/tui-winsource.h: Rename include guard.
3407         * tui/tui-wingeneral.h: Rename include guard.
3408         * tui/tui-windata.h: Rename include guard.
3409         * tui/tui-win.h: Rename include guard.
3410         * tui/tui-stack.h: Rename include guard.
3411         * tui/tui-source.h: Rename include guard.
3412         * tui/tui-regs.h: Rename include guard.
3413         * tui/tui-out.h: Rename include guard.
3414         * tui/tui-layout.h: Rename include guard.
3415         * tui/tui-io.h: Rename include guard.
3416         * tui/tui-hooks.h: Rename include guard.
3417         * tui/tui-file.h: Rename include guard.
3418         * tui/tui-disasm.h: Rename include guard.
3419         * tui/tui-data.h: Rename include guard.
3420         * tui/tui-command.h: Rename include guard.
3421         * tic6x-tdep.h: Add include guard.
3422         * target/waitstatus.h: Rename include guard.
3423         * target/wait.h: Rename include guard.
3424         * target/target.h: Rename include guard.
3425         * target/resume.h: Rename include guard.
3426         * target-float.h: Rename include guard.
3427         * stabsread.h: Add include guard.
3428         * rs6000-tdep.h: Add include guard.
3429         * riscv-fbsd-tdep.h: Add include guard.
3430         * regformats/regdef.h: Rename include guard.
3431         * record.h: Rename include guard.
3432         * python/python.h: Rename include guard.
3433         * python/python-internal.h: Rename include guard.
3434         * python/py-stopevent.h: Rename include guard.
3435         * python/py-ref.h: Rename include guard.
3436         * python/py-record.h: Rename include guard.
3437         * python/py-record-full.h: Rename include guard.
3438         * python/py-record-btrace.h: Rename include guard.
3439         * python/py-instruction.h: Rename include guard.
3440         * python/py-events.h: Rename include guard.
3441         * python/py-event.h: Rename include guard.
3442         * procfs.h: Add include guard.
3443         * proc-utils.h: Add include guard.
3444         * p-lang.h: Add include guard.
3445         * or1k-tdep.h: Rename include guard.
3446         * observable.h: Rename include guard.
3447         * nto-tdep.h: Rename include guard.
3448         * nat/x86-linux.h: Rename include guard.
3449         * nat/x86-linux-dregs.h: Rename include guard.
3450         * nat/x86-gcc-cpuid.h: Add include guard.
3451         * nat/x86-dregs.h: Rename include guard.
3452         * nat/x86-cpuid.h: Rename include guard.
3453         * nat/ppc-linux.h: Rename include guard.
3454         * nat/mips-linux-watch.h: Rename include guard.
3455         * nat/linux-waitpid.h: Rename include guard.
3456         * nat/linux-ptrace.h: Rename include guard.
3457         * nat/linux-procfs.h: Rename include guard.
3458         * nat/linux-osdata.h: Rename include guard.
3459         * nat/linux-nat.h: Rename include guard.
3460         * nat/linux-namespaces.h: Rename include guard.
3461         * nat/linux-btrace.h: Rename include guard.
3462         * nat/glibc_thread_db.h: Rename include guard.
3463         * nat/gdb_thread_db.h: Rename include guard.
3464         * nat/gdb_ptrace.h: Rename include guard.
3465         * nat/fork-inferior.h: Rename include guard.
3466         * nat/amd64-linux-siginfo.h: Rename include guard.
3467         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3468         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3469         * nat/aarch64-linux.h: Rename include guard.
3470         * nat/aarch64-linux-hw-point.h: Rename include guard.
3471         * mn10300-tdep.h: Add include guard.
3472         * mips-linux-tdep.h: Add include guard.
3473         * mi/mi-parse.h: Rename include guard.
3474         * mi/mi-out.h: Rename include guard.
3475         * mi/mi-main.h: Rename include guard.
3476         * mi/mi-interp.h: Rename include guard.
3477         * mi/mi-getopt.h: Rename include guard.
3478         * mi/mi-console.h: Rename include guard.
3479         * mi/mi-common.h: Rename include guard.
3480         * mi/mi-cmds.h: Rename include guard.
3481         * mi/mi-cmd-break.h: Rename include guard.
3482         * m2-lang.h: Add include guard.
3483         * location.h: Rename include guard.
3484         * linux-record.h: Rename include guard.
3485         * linux-nat.h: Add include guard.
3486         * linux-fork.h: Add include guard.
3487         * i386-darwin-tdep.h: Rename include guard.
3488         * hppa-linux-offsets.h: Add include guard.
3489         * guile/guile.h: Rename include guard.
3490         * guile/guile-internal.h: Rename include guard.
3491         * gnu-nat.h: Rename include guard.
3492         * gdb-stabs.h: Rename include guard.
3493         * frv-tdep.h: Add include guard.
3494         * f-lang.h: Add include guard.
3495         * event-loop.h: Add include guard.
3496         * darwin-nat.h: Rename include guard.
3497         * cp-abi.h: Rename include guard.
3498         * config/sparc/nm-sol2.h: Rename include guard.
3499         * config/nm-nto.h: Rename include guard.
3500         * config/nm-linux.h: Add include guard.
3501         * config/i386/nm-i386gnu.h: Rename include guard.
3502         * config/djgpp/nl_types.h: Rename include guard.
3503         * config/djgpp/langinfo.h: Rename include guard.
3504         * compile/gcc-cp-plugin.h: Add include guard.
3505         * compile/gcc-c-plugin.h: Add include guard.
3506         * compile/compile.h: Rename include guard.
3507         * compile/compile-object-run.h: Rename include guard.
3508         * compile/compile-object-load.h: Rename include guard.
3509         * compile/compile-internal.h: Rename include guard.
3510         * compile/compile-cplus.h: Rename include guard.
3511         * compile/compile-c.h: Rename include guard.
3512         * common/xml-utils.h: Rename include guard.
3513         * common/x86-xstate.h: Rename include guard.
3514         * common/version.h: Rename include guard.
3515         * common/vec.h: Rename include guard.
3516         * common/tdesc.h: Rename include guard.
3517         * common/selftest.h: Rename include guard.
3518         * common/scoped_restore.h: Rename include guard.
3519         * common/scoped_mmap.h: Rename include guard.
3520         * common/scoped_fd.h: Rename include guard.
3521         * common/safe-iterator.h: Rename include guard.
3522         * common/run-time-clock.h: Rename include guard.
3523         * common/refcounted-object.h: Rename include guard.
3524         * common/queue.h: Rename include guard.
3525         * common/ptid.h: Rename include guard.
3526         * common/print-utils.h: Rename include guard.
3527         * common/preprocessor.h: Rename include guard.
3528         * common/pathstuff.h: Rename include guard.
3529         * common/observable.h: Rename include guard.
3530         * common/netstuff.h: Rename include guard.
3531         * common/job-control.h: Rename include guard.
3532         * common/host-defs.h: Rename include guard.
3533         * common/gdb_wait.h: Rename include guard.
3534         * common/gdb_vecs.h: Rename include guard.
3535         * common/gdb_unlinker.h: Rename include guard.
3536         * common/gdb_unique_ptr.h: Rename include guard.
3537         * common/gdb_tilde_expand.h: Rename include guard.
3538         * common/gdb_sys_time.h: Rename include guard.
3539         * common/gdb_string_view.h: Rename include guard.
3540         * common/gdb_splay_tree.h: Rename include guard.
3541         * common/gdb_setjmp.h: Rename include guard.
3542         * common/gdb_ref_ptr.h: Rename include guard.
3543         * common/gdb_optional.h: Rename include guard.
3544         * common/gdb_locale.h: Rename include guard.
3545         * common/gdb_assert.h: Rename include guard.
3546         * common/filtered-iterator.h: Rename include guard.
3547         * common/filestuff.h: Rename include guard.
3548         * common/fileio.h: Rename include guard.
3549         * common/environ.h: Rename include guard.
3550         * common/common-utils.h: Rename include guard.
3551         * common/common-types.h: Rename include guard.
3552         * common/common-regcache.h: Rename include guard.
3553         * common/common-inferior.h: Rename include guard.
3554         * common/common-gdbthread.h: Rename include guard.
3555         * common/common-exceptions.h: Rename include guard.
3556         * common/common-defs.h: Rename include guard.
3557         * common/common-debug.h: Rename include guard.
3558         * common/cleanups.h: Rename include guard.
3559         * common/buffer.h: Rename include guard.
3560         * common/btrace-common.h: Rename include guard.
3561         * common/break-common.h: Rename include guard.
3562         * cli/cli-utils.h: Rename include guard.
3563         * cli/cli-style.h: Rename include guard.
3564         * cli/cli-setshow.h: Rename include guard.
3565         * cli/cli-script.h: Rename include guard.
3566         * cli/cli-interp.h: Rename include guard.
3567         * cli/cli-decode.h: Rename include guard.
3568         * cli/cli-cmds.h: Rename include guard.
3569         * charset-list.h: Add include guard.
3570         * buildsym-legacy.h: Rename include guard.
3571         * bfin-tdep.h: Add include guard.
3572         * ax.h: Rename include guard.
3573         * arm-linux-tdep.h: Add include guard.
3574         * arm-fbsd-tdep.h: Add include guard.
3575         * arch/xtensa.h: Rename include guard.
3576         * arch/tic6x.h: Add include guard.
3577         * arch/i386.h: Add include guard.
3578         * arch/arm.h: Rename include guard.
3579         * arch/arm-linux.h: Rename include guard.
3580         * arch/arm-get-next-pcs.h: Rename include guard.
3581         * arch/amd64.h: Add include guard.
3582         * arch/aarch64-insn.h: Rename include guard.
3583         * arch-utils.h: Rename include guard.
3584         * annotate.h: Add include guard.
3585         * amd64-darwin-tdep.h: Rename include guard.
3586         * aarch64-linux-tdep.h: Add include guard.
3587         * aarch64-fbsd-tdep.h: Add include guard.
3588         * aarch32-linux-nat.h: Add include guard.
3589
3590 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3591
3592         * macrotab.c (macro_define_internal): New function that
3593         factorizes macro_define_object_internal and macro_define_function
3594         code.
3595         (macro_define_object_internal): Use macro_define_internal.
3596         (macro_define_function): Likewise.
3597
3598 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3599
3600         * macrocmd.c (extract_identifier): Return
3601         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3602         callers.
3603
3604 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3605
3606         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3607
3608 2019-02-05  Tom Tromey  <tom@tromey.com>
3609
3610         * target.c (target_stack::unpush): Move assertion earlier.
3611
3612 2019-01-30  Tom Tromey  <tom@tromey.com>
3613
3614         PR python/23615:
3615         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3616         (gdbpy_parse_and_eval): Likewise.
3617         * python/python-internal.h (gdbpy_allow_threads): New class.
3618
3619 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3620
3621         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3622         (aarch64_fbsd_fpregmap): Move earlier.
3623         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3624         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3625         instead of individual calls to trad_frame_set_reg_addr.
3626         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3627         earlier.
3628         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3629         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3630         instead of individual calls to trad_frame_set_reg_addr.
3631
3632 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3633
3634         * CONTRIBUTE: Replace contribution list with wiki link.
3635
3636 2019-01-25  Tom Tromey  <tom@tromey.com>
3637
3638         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3639
3640 2019-01-25  Tom Tromey  <tom@tromey.com>
3641
3642         * xtensa-linux-nat.c: Fix common/ includes.
3643         * xml-support.h: Fix common/ includes.
3644         * xml-support.c: Fix common/ includes.
3645         * x86-linux-nat.c: Fix common/ includes.
3646         * windows-nat.c: Fix common/ includes.
3647         * varobj.h: Fix common/ includes.
3648         * varobj.c: Fix common/ includes.
3649         * value.c: Fix common/ includes.
3650         * valops.c: Fix common/ includes.
3651         * utils.c: Fix common/ includes.
3652         * unittests/xml-utils-selftests.c: Fix common/ includes.
3653         * unittests/utils-selftests.c: Fix common/ includes.
3654         * unittests/unpack-selftests.c: Fix common/ includes.
3655         * unittests/tracepoint-selftests.c: Fix common/ includes.
3656         * unittests/style-selftests.c: Fix common/ includes.
3657         * unittests/string_view-selftests.c: Fix common/ includes.
3658         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3659         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3660         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3661         * unittests/rsp-low-selftests.c: Fix common/ includes.
3662         * unittests/parse-connection-spec-selftests.c: Fix common/
3663         includes.
3664         * unittests/optional-selftests.c: Fix common/ includes.
3665         * unittests/offset-type-selftests.c: Fix common/ includes.
3666         * unittests/observable-selftests.c: Fix common/ includes.
3667         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3668         * unittests/memrange-selftests.c: Fix common/ includes.
3669         * unittests/memory-map-selftests.c: Fix common/ includes.
3670         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3671         * unittests/function-view-selftests.c: Fix common/ includes.
3672         * unittests/environ-selftests.c: Fix common/ includes.
3673         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3674         * unittests/common-utils-selftests.c: Fix common/ includes.
3675         * unittests/cli-utils-selftests.c: Fix common/ includes.
3676         * unittests/array-view-selftests.c: Fix common/ includes.
3677         * ui-file.c: Fix common/ includes.
3678         * tui/tui-io.c: Fix common/ includes.
3679         * tracepoint.h: Fix common/ includes.
3680         * tracepoint.c: Fix common/ includes.
3681         * tracefile-tfile.c: Fix common/ includes.
3682         * top.h: Fix common/ includes.
3683         * top.c: Fix common/ includes.
3684         * thread.c: Fix common/ includes.
3685         * target/waitstatus.h: Fix common/ includes.
3686         * target/waitstatus.c: Fix common/ includes.
3687         * target.h: Fix common/ includes.
3688         * target.c: Fix common/ includes.
3689         * target-memory.c: Fix common/ includes.
3690         * target-descriptions.c: Fix common/ includes.
3691         * symtab.h: Fix common/ includes.
3692         * symfile.c: Fix common/ includes.
3693         * stap-probe.c: Fix common/ includes.
3694         * spu-linux-nat.c: Fix common/ includes.
3695         * sparc-nat.c: Fix common/ includes.
3696         * source.c: Fix common/ includes.
3697         * solib.c: Fix common/ includes.
3698         * solib-target.c: Fix common/ includes.
3699         * ser-unix.c: Fix common/ includes.
3700         * ser-tcp.c: Fix common/ includes.
3701         * ser-pipe.c: Fix common/ includes.
3702         * ser-base.c: Fix common/ includes.
3703         * selftest-arch.c: Fix common/ includes.
3704         * s12z-tdep.c: Fix common/ includes.
3705         * rust-exp.y: Fix common/ includes.
3706         * rs6000-aix-tdep.c: Fix common/ includes.
3707         * riscv-tdep.c: Fix common/ includes.
3708         * remote.c: Fix common/ includes.
3709         * remote-notif.h: Fix common/ includes.
3710         * remote-fileio.h: Fix common/ includes.
3711         * remote-fileio.c: Fix common/ includes.
3712         * regcache.h: Fix common/ includes.
3713         * regcache.c: Fix common/ includes.
3714         * record-btrace.c: Fix common/ includes.
3715         * python/python.c: Fix common/ includes.
3716         * python/py-type.c: Fix common/ includes.
3717         * python/py-inferior.c: Fix common/ includes.
3718         * progspace.h: Fix common/ includes.
3719         * producer.c: Fix common/ includes.
3720         * procfs.c: Fix common/ includes.
3721         * proc-api.c: Fix common/ includes.
3722         * printcmd.c: Fix common/ includes.
3723         * ppc-linux-nat.c: Fix common/ includes.
3724         * parser-defs.h: Fix common/ includes.
3725         * osdata.c: Fix common/ includes.
3726         * obsd-nat.c: Fix common/ includes.
3727         * nat/x86-linux.c: Fix common/ includes.
3728         * nat/x86-linux-dregs.c: Fix common/ includes.
3729         * nat/x86-dregs.h: Fix common/ includes.
3730         * nat/x86-dregs.c: Fix common/ includes.
3731         * nat/ppc-linux.c: Fix common/ includes.
3732         * nat/mips-linux-watch.h: Fix common/ includes.
3733         * nat/mips-linux-watch.c: Fix common/ includes.
3734         * nat/linux-waitpid.c: Fix common/ includes.
3735         * nat/linux-ptrace.h: Fix common/ includes.
3736         * nat/linux-ptrace.c: Fix common/ includes.
3737         * nat/linux-procfs.c: Fix common/ includes.
3738         * nat/linux-personality.c: Fix common/ includes.
3739         * nat/linux-osdata.c: Fix common/ includes.
3740         * nat/linux-namespaces.c: Fix common/ includes.
3741         * nat/linux-btrace.h: Fix common/ includes.
3742         * nat/linux-btrace.c: Fix common/ includes.
3743         * nat/fork-inferior.c: Fix common/ includes.
3744         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3745         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3746         * nat/aarch64-linux.c: Fix common/ includes.
3747         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3748         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3749         * namespace.h: Fix common/ includes.
3750         * mips-linux-tdep.c: Fix common/ includes.
3751         * minsyms.c: Fix common/ includes.
3752         * mi/mi-parse.h: Fix common/ includes.
3753         * mi/mi-main.c: Fix common/ includes.
3754         * mi/mi-cmd-env.c: Fix common/ includes.
3755         * memrange.h: Fix common/ includes.
3756         * memattr.c: Fix common/ includes.
3757         * maint.h: Fix common/ includes.
3758         * maint.c: Fix common/ includes.
3759         * main.c: Fix common/ includes.
3760         * machoread.c: Fix common/ includes.
3761         * location.c: Fix common/ includes.
3762         * linux-thread-db.c: Fix common/ includes.
3763         * linux-nat.c: Fix common/ includes.
3764         * linux-fork.c: Fix common/ includes.
3765         * inline-frame.c: Fix common/ includes.
3766         * infrun.c: Fix common/ includes.
3767         * inflow.c: Fix common/ includes.
3768         * inferior.h: Fix common/ includes.
3769         * inferior.c: Fix common/ includes.
3770         * infcmd.c: Fix common/ includes.
3771         * inf-ptrace.c: Fix common/ includes.
3772         * inf-child.c: Fix common/ includes.
3773         * ia64-linux-nat.c: Fix common/ includes.
3774         * i387-tdep.c: Fix common/ includes.
3775         * i386-tdep.c: Fix common/ includes.
3776         * i386-linux-tdep.c: Fix common/ includes.
3777         * i386-linux-nat.c: Fix common/ includes.
3778         * i386-go32-tdep.c: Fix common/ includes.
3779         * i386-fbsd-tdep.c: Fix common/ includes.
3780         * i386-fbsd-nat.c: Fix common/ includes.
3781         * guile/scm-type.c: Fix common/ includes.
3782         * guile/guile.c: Fix common/ includes.
3783         * go32-nat.c: Fix common/ includes.
3784         * gnu-nat.c: Fix common/ includes.
3785         * gdbthread.h: Fix common/ includes.
3786         * gdbarch-selftests.c: Fix common/ includes.
3787         * gdb_usleep.c: Fix common/ includes.
3788         * gdb_select.h: Fix common/ includes.
3789         * gdb_bfd.c: Fix common/ includes.
3790         * gcore.c: Fix common/ includes.
3791         * fork-child.c: Fix common/ includes.
3792         * findvar.c: Fix common/ includes.
3793         * fbsd-nat.c: Fix common/ includes.
3794         * event-top.c: Fix common/ includes.
3795         * event-loop.c: Fix common/ includes.
3796         * dwarf2read.c: Fix common/ includes.
3797         * dwarf2loc.c: Fix common/ includes.
3798         * dwarf2-frame.c: Fix common/ includes.
3799         * dwarf-index-cache.c: Fix common/ includes.
3800         * dtrace-probe.c: Fix common/ includes.
3801         * disasm-selftests.c: Fix common/ includes.
3802         * defs.h: Fix common/ includes.
3803         * csky-tdep.c: Fix common/ includes.
3804         * cp-valprint.c: Fix common/ includes.
3805         * cp-support.h: Fix common/ includes.
3806         * cp-support.c: Fix common/ includes.
3807         * corelow.c: Fix common/ includes.
3808         * completer.h: Fix common/ includes.
3809         * completer.c: Fix common/ includes.
3810         * compile/compile.c: Fix common/ includes.
3811         * compile/compile-loc2c.c: Fix common/ includes.
3812         * compile/compile-cplus-types.c: Fix common/ includes.
3813         * compile/compile-cplus-symbols.c: Fix common/ includes.
3814         * command.h: Fix common/ includes.
3815         * cli/cli-dump.c: Fix common/ includes.
3816         * cli/cli-cmds.c: Fix common/ includes.
3817         * charset.c: Fix common/ includes.
3818         * build-id.c: Fix common/ includes.
3819         * btrace.h: Fix common/ includes.
3820         * btrace.c: Fix common/ includes.
3821         * breakpoint.h: Fix common/ includes.
3822         * breakpoint.c: Fix common/ includes.
3823         * ax.h: 
3824         (enum agent_op): Fix common/ includes.
3825         * ax-general.c (struct aop_map): Fix common/ includes.
3826         * ax-gdb.c: Fix common/ includes.
3827         * auxv.c: Fix common/ includes.
3828         * auto-load.c: Fix common/ includes.
3829         * arm-tdep.c: Fix common/ includes.
3830         * arch/riscv.c: Fix common/ includes.
3831         * arch/ppc-linux-common.c: Fix common/ includes.
3832         * arch/i386.c: Fix common/ includes.
3833         * arch/arm.c: Fix common/ includes.
3834         * arch/arm-linux.c: Fix common/ includes.
3835         * arch/arm-get-next-pcs.c: Fix common/ includes.
3836         * arch/amd64.c: Fix common/ includes.
3837         * arch/aarch64.c: Fix common/ includes.
3838         * arch/aarch64-insn.c: Fix common/ includes.
3839         * arch-utils.c: Fix common/ includes.
3840         * amd64-windows-tdep.c: Fix common/ includes.
3841         * amd64-tdep.c: Fix common/ includes.
3842         * amd64-sol2-tdep.c: Fix common/ includes.
3843         * amd64-obsd-tdep.c: Fix common/ includes.
3844         * amd64-nbsd-tdep.c: Fix common/ includes.
3845         * amd64-linux-tdep.c: Fix common/ includes.
3846         * amd64-linux-nat.c: Fix common/ includes.
3847         * amd64-fbsd-tdep.c: Fix common/ includes.
3848         * amd64-fbsd-nat.c: Fix common/ includes.
3849         * amd64-dicos-tdep.c: Fix common/ includes.
3850         * amd64-darwin-tdep.c: Fix common/ includes.
3851         * agent.c: Fix common/ includes.
3852         * ada-lang.h: Fix common/ includes.
3853         * ada-lang.c: Fix common/ includes.
3854         * aarch64-tdep.c: Fix common/ includes.
3855
3856 2019-01-25  Tom Tromey  <tom@tromey.com>
3857
3858         * common/create-version.sh: Use common/version.h.
3859
3860 2019-01-24  Pedro Alves  <palves@redhat.com>
3861
3862         * infrun.c (signal_stop, signal_print, signal_program)
3863         (signal_catch, signal_pass): Now arrays instead of pointers.
3864         (update_signals_program_target, do_target_resume)
3865         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
3866         * linux-nat.c (linux_nat_target::pass_signals)
3867         (linux_nat_target::create_inferior, linux_nat_target::attach):
3868         Adjust.
3869         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
3870         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
3871         * procfs.c (procfs_target::pass_signals): Adjust.
3872         * record-full.c (record_full_target::resume): Adjust.
3873         * remote.c (remote_target::pass_signals)
3874         (remote_target::program_signals): Adjust.
3875         * target-debug.h (target_debug_print_signals): Now takes a
3876         gdb::array_view as parameter.  Adjust.
3877         * target.h (target_ops) <pass_signals, program_signals>: Replace
3878         pointer and length parameters with gdb::array_view.
3879         (target_pass_signals, target_program_signals): Likewise.
3880         * target-delegates.c: Regenerate.
3881
3882 2019-01-24  Pedro Alves  <palves@redhat.com>
3883
3884         * common/forward-scope-exit.h
3885         (forward_scope_exit::forward_scope_exit): Pass arguments to
3886         m_bind_function directly, instead of creating a std::bind and
3887         copying that.
3888
3889 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
3890
3891         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3892         for static members.
3893         (pass_in_v_vfp_candidate): Likewise.
3894
3895 2019-01-23  Tom Tromey  <tom@tromey.com>
3896             Pedro Alves  <palves@redhat.com>
3897
3898         * regcache.c (class regcache_invalidator): Remove.
3899         (regcache::raw_write): Use make_scope_exit.
3900
3901 2019-01-23  Tom Tromey  <tom@tromey.com>
3902
3903         * ui-out.h (class ui_out_emit_type): Update comment.
3904
3905 2019-01-23  Tom Tromey  <tom@tromey.com>
3906
3907         * infrun.c (fetch_inferior_event): Update comment.
3908
3909 2019-01-23  Tom Tromey  <tom@tromey.com>
3910             Pedro Alves  <palves@redhat.com>
3911
3912         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
3913         parameter.
3914         (fetch_inferior_event): Use SCOPE_EXIT.
3915
3916
3917 2019-01-23  Tom Tromey  <tom@tromey.com>
3918             Pedro Alves  <palves@redhat.com>
3919
3920         * infrun.c (disable_thread_events): Delete.
3921         (stop_all_threads): Use SCOPE_EXIT.
3922
3923 2019-01-23  Tom Tromey  <tom@tromey.com>
3924             Pedro Alves  <palves@redhat.com>
3925
3926         * symfile.c: Include forward-scope-exit.h.
3927         (clear_symtab_users_cleanup): Replace forward declaration with
3928         a FORWARD_SCOPE_EXIT.
3929         (syms_from_objfile_1): Use the forward_scope_exit and
3930         gdb::optional instead of cleanup_function.
3931         (reread_symbols): Use the forward_scope_exit instead of
3932         cleanup_function.
3933         (clear_symtab_users_cleanup): Remove function.
3934
3935 2019-01-23  Tom Tromey  <tom@tromey.com>
3936             Pedro Alves  <palves@redhat.com>
3937
3938         * linux-nat.c: Include scope-exit.h.
3939         (cleanup_target_stop): Remove.
3940         (linux_nat_target::static_tracepoint_markers_by_strid): Use
3941         SCOPE_EXIT.
3942
3943 2019-01-23  Tom Tromey  <tom@tromey.com>
3944             Pedro Alves  <palves@redhat.com>
3945
3946         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
3947         (call_function_by_hand_dummy): Use SCOPE_EXIT.
3948
3949 2019-01-23  Tom Tromey  <tom@tromey.com>
3950             Andrew Burgess  <andrew.burgess@embecosm.com>
3951             Pedro Alves  <palves@redhat.com>
3952
3953         * infrun.c (fetch_inferior_event): Use scope_exit.
3954         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
3955         * top.c (execute_command): Use scope_exit.
3956         * breakpoint.c (bpstat_do_actions): Use scope_exit.
3957         * utils.c (do_bpstat_clear_actions_cleanup)
3958         (make_bpstat_clear_actions_cleanup): Remove.
3959
3960 2019-01-23  Tom Tromey  <tom@tromey.com>
3961             Pedro Alves  <palves@redhat.com>
3962
3963         * infrun.c: Include "common/scope-exit.h"
3964         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
3965         (wait_for_inferior): Use SCOPE_EXIT.
3966         (fetch_inferior_event): Use scope_exit.
3967
3968 2019-01-23  Tom Tromey  <tom@tromey.com>
3969             Pedro Alves  <palves@redhat.com>
3970
3971         * breakpoint.c (create_breakpoint): Remove cleanup.
3972
3973 2019-01-23  Tom Tromey  <tom@tromey.com>
3974             Andrew Burgess  <andrew.burgess@embecosm.com>
3975             Pedro Alves  <palves@redhat.com>
3976
3977 2019-01-23  Pedro Alves  <palves@redhat.com>
3978
3979         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
3980
3981 2019-01-23  Pedro Alves  <palves@redhat.com>
3982             Andrew Burgess  <andrew.burgess@embecosm.com>
3983
3984         * gdbthread.h: Include "common/forward-scope-exit.h".
3985         (scoped_finish_thread_state): Redefine custom class in terms of
3986         forward_scope_exit.
3987
3988 2019-01-23  Pedro Alves  <palves@redhat.com>
3989             Andrew Burgess  <andrew.burgess@embecosm.com>
3990
3991         * common/forward-scope-exit.h: New file.
3992
3993 2019-01-23  Pedro Alves  <palves@redhat.com>
3994             Andrew Burgess  <andrew.burgess@embecosm.com>
3995             Tom Tromey  <tom@tromey.com>
3996
3997         * common/scope-exit.h: New file.
3998
3999 2019-01-23  Pedro Alves  <palves@redhat.com>
4000
4001         * common/preprocessor.h (ESC): Rename to ...
4002         (ESC_PARENS): ... this.
4003         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4004         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4005
4006 2019-01-23  Tom Tromey  <tom@tromey.com>
4007
4008         * language.h (class scoped_switch_to_sym_language_if_auto):
4009         Initialize m_lang in both cases.
4010
4011 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4012
4013         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4014         with XCNEW.
4015
4016 2019-01-22  Tom Tromey  <tom@tromey.com>
4017
4018         * corelow.c: Do not include sys/file.h.
4019
4020 2019-01-22  Tom Tromey  <tom@tromey.com>
4021
4022         * tui/tui-wingeneral.h: Include gdb_curses.h.
4023
4024 2019-01-22  Tom Tromey  <tom@tromey.com>
4025
4026         * source-cache.h (class source_cache) <get_source_lines,
4027         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4028
4029 2019-01-22  Tom Tromey  <tom@tromey.com>
4030
4031         * remote-fileio.h (struct remote_target): Declare.
4032
4033 2019-01-22  Tom Tromey  <tom@tromey.com>
4034
4035         * python/py-arch.c: Do not include py-ref.h.
4036         * python/py-bpevent.c: Do not include py-ref.h.
4037         * python/py-cmd.c: Do not include py-ref.h.
4038         * python/py-continueevent.c: Do not include py-ref.h.
4039         * python/py-event.h: Do not include py-ref.h.
4040         * python/py-evtregistry.c: Do not include py-ref.h.
4041         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4042         * python/py-frame.c: Do not include py-ref.h.
4043         * python/py-framefilter.c: Do not include py-ref.h.
4044         * python/py-function.c: Do not include py-ref.h.
4045         * python/py-infevents.c: Do not include py-ref.h.
4046         * python/py-linetable.c: Do not include py-ref.h.
4047         * python/py-objfile.c: Do not include py-ref.h.
4048         * python/py-param.c: Do not include py-ref.h.
4049         * python/py-prettyprint.c: Do not include py-ref.h.
4050         * python/py-progspace.c: Do not include py-ref.h.
4051         * python/py-symbol.c: Do not include py-ref.h.
4052         * python/py-symtab.c: Do not include py-ref.h.
4053         * python/py-type.c: Do not include py-ref.h.
4054         * python/py-unwind.c: Do not include py-ref.h.
4055         * python/py-utils.c: Do not include py-ref.h.
4056         * python/py-value.c: Do not include py-ref.h.
4057         * python/py-varobj.c: Do not include py-ref.h.
4058         * python/py-xmethods.c: Do not include py-ref.h.
4059         * python/python.c: Do not include py-ref.h.
4060         * varobj.c: Do not include py-ref.h.
4061
4062 2019-01-22  Tom Tromey  <tom@tromey.com>
4063
4064         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4065         keyword for bcache.
4066
4067 2019-01-22  Tom Tromey  <tom@tromey.com>
4068
4069         * compile/compile-cplus-types.c: Remove a comment by #include.
4070
4071 2019-01-22  Tom Tromey  <tom@tromey.com>
4072
4073         * compile/gcc-c-plugin.h: Include compile-internal.h.
4074
4075 2019-01-22  Tom Tromey  <tom@tromey.com>
4076
4077         * stabsread.c (EXTERN): Do not define.
4078         (symnum, next_symbol_text_func, processing_gcc_compilation)
4079         (within_function, global_sym_chain, global_stabs)
4080         (previous_stab_code, this_object_header_files)
4081         (n_this_object_header_files)
4082         (n_allocated_this_object_header_files): Define.
4083         * stabsread.h (EXTERN): Never define.  Use "extern".
4084
4085 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4086
4087         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4088         history_value.
4089
4090 2019-01-21  Tom Tromey  <tom@tromey.com>
4091
4092         * ui-out.c: Fix includes.
4093         * tui/tui-source.c: Fix includes.
4094         * target.c: Fix includes.
4095         * remote.c: Fix includes.
4096         * regcache.c: Fix includes.
4097         * python/py-block.c: Fix includes.
4098         * printcmd.c: Fix includes.
4099         * or1k-tdep.c: Fix includes.
4100         * mi/mi-main.c: Fix includes.
4101         * m32r-tdep.c: Fix includes.
4102         * csky-tdep.c: Fix includes.
4103         * compile/compile-cplus-types.c: Fix includes.
4104         * cli/cli-interp.c: Fix includes.
4105
4106 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4107
4108         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4109         for padding.
4110
4111 2019-01-16  Tom Tromey  <tom@tromey.com>
4112
4113         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4114         earlier.
4115         (struct objfile) <msymbols_range>: Move from top level.
4116         <msymbols>: New method.
4117         (class objfile_msymbols): Remove.
4118         * symtab.c (default_collect_symbol_completion_matches_break_on):
4119         Update.
4120         * symmisc.c (dump_msymbols): Update.
4121         * stabsread.c (scan_file_globals): Update.
4122         * objc-lang.c (info_selectors_command, info_classes_command)
4123         (find_methods): Update.
4124         * minsyms.c (find_solib_trampoline_target): Update.
4125         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4126         * coffread.c (coff_symfile_read): Update.
4127         * ada-lang.c (ada_lookup_simple_minsym)
4128         (ada_collect_symbol_completion_matches): Update.
4129
4130 2019-01-16  Tom Tromey  <tom@tromey.com>
4131
4132         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4133         type.  Remove no-argument constructor.
4134         <iterator::operator++>: Simplify.
4135         <begin>: Update.
4136         <end>: Use minimal_symbol_count.
4137
4138 2019-01-16  Tom Tromey  <tom@tromey.com>
4139
4140         * objfiles.h (struct objfile) <psymtabs>: New method.
4141         (class objfile_psymtabs): Remove.
4142         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4143         typedef.
4144         <range>: New method.
4145         (require_partial_symbols): Change return type.
4146         * psymtab.c (require_partial_symbols)
4147         (psym_expand_symtabs_matching): Update.
4148         * mdebugread.c (parse_partial_symbols): Update.
4149         * dbxread.c (dbx_end_psymtab): Update.
4150
4151 2019-01-15  Tom Tromey  <tom@tromey.com>
4152
4153         * symtab.c (lookup_objfile_from_block)
4154         (lookup_symbol_in_objfile_symtabs)
4155         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4156         (find_line_symtab, info_sources_command)
4157         (default_collect_symbol_completion_matches_break_on)
4158         (make_source_files_completion_list): Update.
4159         * symmisc.c (print_objfile_statistics, dump_objfile)
4160         (maintenance_print_symbols, maintenance_info_symtabs)
4161         (maintenance_check_symtabs, maintenance_info_line_tables):
4162         Update.
4163         * source.c (select_source_symtab)
4164         (forget_cached_source_info_for_objfile): Update.
4165         * objfiles.h (class objfile_compunits): Remove.
4166         (struct objfile) <compunits_range>: New typedef.
4167         (compunits): New method.
4168         * objfiles.c (objfile_relocate1): Update.
4169         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4170         * maint.c (count_symtabs_and_blocks): Update.
4171         * linespec.c (iterate_over_all_matching_symtabs): Update.
4172         * cp-support.c (add_symbol_overload_list_qualified): Update.
4173         * coffread.c (coff_symtab_read): Update.
4174         * ada-lang.c (add_nonlocal_symbols)
4175         (ada_collect_symbol_completion_matches)
4176         (ada_add_global_exceptions): Update.
4177
4178 2019-01-15  Tom Tromey  <tom@tromey.com>
4179
4180         * progspace.h (program_space) <objfiles_safe_range>: New
4181         typedef.
4182         <objfiles_safe>: New method.
4183         * objfiles.h (class all_objfiles_safe): Remove.
4184         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4185         * jit.c (jit_inferior_exit_hook): Update.
4186
4187 2019-01-17  Tom Tromey  <tom@tromey.com>
4188
4189         * progspace.h (program_space) <objfiles_range>: New typedef.
4190         <objfiles>: New method.
4191         <objfiles_head>: Rename from objfiles.
4192         (object_files): Update.
4193         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4194         * guile/scm-pretty-print.c
4195         (ppscm_find_pretty_printer_from_objfiles): Update.
4196         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4197         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4198         Update.
4199         * python/py-progspace.c (pspy_get_objfiles): Update.
4200         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4201         Update.
4202         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4203         (objfpy_lookup_objfile_by_build_id): Update.
4204         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4205         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4206         Update.
4207         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4208         (expand_symtab_containing_pc, lookup_objfile_from_block)
4209         (lookup_static_symbol, basic_lookup_transparent_type)
4210         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4211         (find_line_symtab, info_sources_command)
4212         (default_collect_symbol_completion_matches_break_on)
4213         (make_source_files_completion_list, find_main_name): Update.
4214         * symmisc.c (print_symbol_bcache_statistics)
4215         (print_objfile_statistics, maintenance_print_symbols)
4216         (maintenance_print_msymbols, maintenance_print_objfiles)
4217         (maintenance_info_symtabs, maintenance_check_symtabs)
4218         (maintenance_expand_symtabs, maintenance_info_line_tables):
4219         Update.
4220         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4221         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4222         (map_overlay_command, unmap_overlay_command)
4223         (simple_overlay_update, expand_symtabs_matching)
4224         (map_symbol_filenames): Update.
4225         * symfile-debug.c (set_debug_symfile): Update.
4226         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4227         Update.
4228         * source.c (select_source_symtab, forget_cached_source_info):
4229         Update.
4230         * solib.c (solib_read_symbols): Update.
4231         * solib-spu.c (append_ocl_sos): Update.
4232         * psymtab.c (maintenance_print_psymbols)
4233         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4234         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4235         * printcmd.c (info_symbol_command): Update.
4236         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4237         Update.
4238         * objfiles.h (class all_objfiles): Remove.
4239         * objfiles.c (have_partial_symbols, have_full_symbols)
4240         (have_minimal_symbols, qsort_cmp, update_section_map)
4241         (shared_objfile_contains_address_p)
4242         (default_iterate_over_objfiles_in_search_order): Update.
4243         * objc-lang.c (info_selectors_command, info_classes_command)
4244         (find_methods): Update.
4245         * minsyms.c (find_solib_trampoline_target): Update.
4246         * maint.c (maintenance_info_sections)
4247         (maintenance_translate_address, count_symtabs_and_blocks):
4248         Update.
4249         * main.c (captured_main_1): Update.
4250         * linux-thread-db.c (try_thread_db_load_from_pdir)
4251         (has_libpthread): Update.
4252         * linespec.c (iterate_over_all_matching_symtabs)
4253         (search_minsyms_for_name): Update.
4254         * jit.c (jit_find_objf_with_entry_addr): Update.
4255         * hppa-tdep.c (find_unwind_entry)
4256         (hppa_lookup_stub_minimal_symbol): Update.
4257         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4258         Update.
4259         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4260         (elf_gnu_ifunc_resolve_by_got): Update.
4261         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4262         * dwarf-index-write.c (save_gdb_index_command): Update.
4263         * cp-support.c (add_symbol_overload_list_qualified): Update.
4264         * breakpoint.c (create_overlay_event_breakpoint)
4265         (create_longjmp_master_breakpoint)
4266         (create_std_terminate_master_breakpoint)
4267         (create_exception_master_breakpoint): Update.
4268         * blockframe.c (find_pc_partial_function): Update.
4269         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4270         (ada_collect_symbol_completion_matches)
4271         (ada_add_global_exceptions): Update.
4272
4273 2019-01-17  Tom Tromey  <tom@tromey.com>
4274
4275         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4276         declare VEC.
4277         (solib_target_parse_libraries): Change return type.
4278         (library_list_start_segment, library_list_start_section)
4279         (library_list_end_library, library_list_start_library); Update.
4280         (solib_target_free_library_list): Remove.
4281         (solib_target_parse_libraries): Remove cleanup.  Change return
4282         type.
4283         (solib_target_current_sos): Update.
4284
4285 2019-01-17  Tom Tromey  <tromey@bapiya>
4286
4287         * valprint.c: Replace "the the" with "the".
4288         * symtab.c: Replace "the the" with "the".
4289         * solib.c: Replace "the the" with "the".
4290         * solib-dsbt.c: Replace "the the" with "the".
4291         * linespec.c: Replace "the the" with "the".
4292         * dwarf2loc.h: Replace "the the" with "the".
4293         * amd64-windows-tdep.c: Replace "the the" with "the".
4294         * aarch64-tdep.c: Replace "the the" with "the".
4295
4296 2019-01-16  Keith Seitz  <keiths@redhat.com>
4297
4298         PR gdb/23773
4299         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4300         <builder>: Rename to ..
4301         <m_builder>: ... this and make private.
4302         (dwarf2_cu::get_builder): New method.  Change all users of
4303         `builder' to use this method.
4304         (dwarf2_start_symtab): Move to ...
4305         (dwarf2_cu::start_symtab): ... here.  Update all callers
4306         (setup_type_unit_groups): Move to ...
4307         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4308         callers.
4309         (dwarf2_cu::reset_builder): New method.
4310         (process_full_compunit, process_full_type_unit): Use
4311         dwarf2_cu::reset_builder.
4312         (follow_die_offset): Record the ancestor CU if it is different
4313         from the followed DIE's CU.
4314         (follow_die_sig_1): Likewise.
4315
4316 2019-01-15  Tom Tromey  <tom@tromey.com>
4317
4318         * remote.c (class remote_state) <buf>: Now a char_vector.
4319         <buf_size>: Remove.
4320         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4321         parameter.
4322         (remote_target::getpkt_or_notif_sane_1)
4323         (remote_target::getpkt_sane)
4324         (remote_target::getpkt_or_notif_sane): Likewise.
4325         (class remote_target) <putpkt>: New overload.
4326         (remote_target::read_frame): Change type of "buf_p".  Remove
4327         sizeof_p parameter.
4328         (packet_ok): New overload.
4329         (packet_check_result): New overload.
4330         Update all uses.
4331
4332 2019-01-14  Tom Tromey  <tom@tromey.com>
4333
4334         * remote-notif.c (handle_notification, remote_notif_ack)
4335         (remote_notif_parse): Make "buf" const.
4336         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4337         const.
4338         (remote_notif_parse, remote_notif_ack, handle_notification):
4339         Likewise.
4340         * remote.c (remote_notif_stop_parse): Make "buf" const.
4341         (remote_target::remote_parse_stop_reply): Make "buf" const.
4342         (remote_notif_stop_ack): Make "buf" const.
4343
4344 2019-01-14  Tom Tromey  <tom@tromey.com>
4345
4346         * remote.c (remote_console_output): Make parameter const.
4347
4348 2019-01-14  Tom Tromey  <tom@tromey.com>
4349
4350         * target-debug.h (target_debug_print_signals): Constify.
4351         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4352         * procfs.c (procfs_target::pass_signals): Update.
4353         * linux-nat.c (linux_nat_target::pass_signals): Update.
4354         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4355         * target-delegates.c: Rebuild.
4356         * remote.c (remote_target::program_signals): Update.
4357         (remote_target::pass_signals): Update.
4358         * target.c (target_pass_signals): Constify argument.
4359         (target_program_signals): Likewise.
4360         * target.h (struct target_ops) <pass_signals, program_signals>:
4361         Constify argument.
4362         (target_pass_signals, target_program_signals): Constify argument.
4363
4364 2019-01-14  Tom Tromey  <tom@tromey.com>
4365
4366         PR tui/28819:
4367         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4368
4369 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4370
4371         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4372         field.
4373         * rs6000-tdep.c: Include reggroups.h.
4374         (IS_V_ALIAS_PSEUDOREG): Define.
4375         (rs6000_register_name): Return names for the "vX" aliases.
4376         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4377         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4378         aliases.  Call default_register_reggroup_p for all other
4379         pseudo-registers.
4380         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4381         New functions.
4382         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4383         Handle "vX" aliases.
4384         (v_alias_pseudo_register_collect): New function.
4385         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4386         (rs6000_gdbarch_init): Initialize "vX" aliases as
4387         pseudo-registers.  Restore registration of
4388         rs6000_pseudo_register_reggroup_p with
4389         set_tdesc_pseudo_register_reggroup_p.
4390
4391 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4392
4393         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4394         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4395         set_gdbarch_num_pseudo_regs.
4396
4397 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4398
4399         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4400         Remove arg prefixname, add do_set and do_show.
4401         Add member functions set_list and show_list.
4402         * cli/cli-style.c (class cli_style_option): Update accordingly.
4403         (style_set_list): Move to file scope.
4404         (style_show_list): Likewise.
4405         (set_style): Call help_list.
4406         (show_style): Call cmd_show_list.
4407         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4408         Update to use the new macro.
4409
4410 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4411
4412         * ada-lang.c (_initialize_ada_language): Expand the help text
4413         for the "catch exception" command.
4414
4415 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4416
4417         * symtab.c (matching_obj_sections): Initialize obj,
4418         declare it closer to its usage.
4419
4420 2019-01-10  Tom Tromey  <tom@tromey.com>
4421
4422         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4423         (basic_inf_threads_range): Remove.
4424         (inf_threads_range, inf_non_exited_threads_range)
4425         (safe_inf_threads_range): Use next_adapter.
4426
4427 2019-01-10  Keith Seitz  <keiths@redhat.com>
4428
4429         PR gdb/23712
4430         PR symtab/23010
4431         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4432         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4433
4434 2019-01-10  Keith Seitz  <keiths@redhat.com>
4435
4436         PR gdb/23712
4437         PR symtab/23010
4438         * dictionary.c (pending_to_vector): Remove.
4439         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4440         Remove _1 suffix, replacing functions of the same name.  Update
4441         all callers.
4442         (dict_create_hashed, dict_create_hashed_expandable)
4443         (dict_create_linear, dict_create_linear_expandable, dict_free)
4444         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4445         Make functions static.
4446
4447 2019-01-10  Keith Seitz  <keiths@redhat.com>
4448
4449         PR gdb/23712
4450         PR symtab/23010
4451         * dictionary.h (struct dictionary): Replace declaration with
4452         multidictionary.
4453         (dict_create_hashed, dict_create_hashed_expandable)
4454         (dict_create_linear, dict_create_linear_expandable)
4455         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4456         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4457         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4458         taking multidictionary argument.
4459         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4460         * block.h (struct block) <dict>: Change to multidictionary
4461         and rename `multidict'.
4462         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4463         symmisc.c: Update all dictionary references to multidictionary.
4464
4465 2019-01-10  Keith Seitz  <keiths@redhat.com>
4466
4467         PR gdb/23712
4468         PR symtab/23010
4469         * dictionary.c: Include unordered_map.
4470         (pending_to_vector): New function.
4471         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4472         Rewrite the non-"_1" functions to take vector instead
4473         of linked list.
4474         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4475         "new" _1 versions of the same name.
4476         (multidictionary): Define.
4477         (std::hash<enum language): New definition.
4478         (collate_pending_symbols_by_language, mdict_create_hashed)
4479         (mdict_create_hashed_expandable, mdict_create_linear)
4480         (mdict_create_linear_expandable, mdict_free)
4481         (find_language_dictionary, create_new_language_dictionary)
4482         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4483         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4484         (mdict_size, mdict_empty): New functions.
4485         * dictionary.h (mdict_iterator): Define.
4486
4487 2019-01-10  Pedro Alves  <palves@redhat.com>
4488
4489         * breakpoint.c (read_uploaded_action)
4490         (create_tracepoint_from_upload): Adjust to use
4491         gdb::unique_xmalloc_ptr.
4492         * ctf.c (ctf_write_uploaded_tp):
4493         (SET_ARRAY_FIELD): Use emplace_back.
4494         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4495         * tracefile-tfile.c (tfile_write_uploaded_tp):
4496         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4497         gdb::unique_xmalloc_ptr.
4498         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4499         at_string, cond_string, cmd_strings>: Replace char pointers
4500         with gdb::unique_xmalloc_ptr.
4501
4502 2019-01-10  Pedro Alves  <palves@redhat.com>
4503
4504         * solib-target.c (library_list_start_library): Don't xstrdup name.
4505
4506 2019-01-10  Pedro Alves  <palves@redhat.com>
4507
4508         * mdebugread.c (parse_partial_symbols): Use
4509         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4510
4511 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4512
4513         * linux-fork.c (scoped_switch_fork_info)
4514         <~scoped_switch_fork_info>: Fix incorrect variable name.
4515
4516 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4517
4518         * linux-fork.c (scoped_switch_fork_info)
4519         <scoped_switch_fork_info>: Make explicit.
4520         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4521
4522 2019-01-10  Tom Tromey  <tom@tromey.com>
4523
4524         * objfiles.h (objfile::reset_psymtabs): Update.
4525         * objfiles.c (objfile::objfile): Update.
4526         * psymtab.h (psymtab_storage::obstack): Update.
4527         (psymtab_storage::m_obstack): Use gdb::optional.
4528         (class psymtab_storage): Update comment.  Remove objfile
4529         parameter.
4530         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4531
4532 2019-01-10  Tom Tromey  <tom@tromey.com>
4533
4534         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4535         <free_psymtabs>: Now private.
4536         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4537         (allocate_psymtab): Use new method.
4538
4539 2019-01-10  Tom Tromey  <tom@tromey.com>
4540
4541         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4542         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4543         * mdebugread.c (parse_partial_symbols): Use
4544         allocate_dependencies.
4545         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4546         allocate_dependencies.
4547         (process_psymtab_comp_unit_reader)
4548         (build_type_psymtab_dependencies): Likewise.
4549         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4550
4551 2019-01-10  Tom Tromey  <tom@tromey.com>
4552
4553         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4554         PSYMBOL_SET_LANGUAGE.
4555         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4556
4557 2019-01-10  Tom Tromey  <tom@tromey.com>
4558
4559         * psymtab.h (psymtab_storage::obstack): New method.
4560         <m_obstack>: Rename from obstack; now private.
4561         * psymtab.c (psymtab_storage): Update.
4562         * dwarf2read.c (create_addrmap_from_index)
4563         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4564         Update.
4565
4566 2019-01-10  Tom Tromey  <tom@tromey.com>
4567
4568         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4569         * objfiles.h (objfile::reset_psymtabs): New method.
4570
4571 2019-01-10  Tom Tromey  <tom@tromey.com>
4572
4573         * symmisc.c (print_symbol_bcache_statistics): Update.
4574         (print_objfile_statistics): Update.
4575         * symfile.c (reread_symbols): Update.
4576         * psymtab.h (class psymtab_storage): New.
4577         * psymtab.c (psymtab_storage): New constructor.
4578         (~psymtab_storage): New destructor.
4579         (require_partial_symbols): Update.
4580         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4581         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4582         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4583         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4584         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4585         (start_psymtab_common, end_psymtab_common)
4586         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4587         (allocate_psymtab): Update.
4588         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4589         Update.
4590         (dump_psymtab_addrmap, maintenance_print_psymbols)
4591         (maintenance_check_psymtabs): Update.
4592         (class objfile_psymtabs): Move to objfiles.h.
4593         * psympriv.h (discard_psymtab): Now inline.
4594         (psymtab_discarder::psymtab_discarder): Update.
4595         (psymtab_discarder::~psymtab_discarder): Update.
4596         (ALL_OBJFILE_PSYMTABS): Rewrite.
4597         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4598         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4599         Remove fields.
4600         <partial_symtabs>: New field.
4601         (class objfile_psymtabs): Move from psymtab.h.  Update.
4602         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4603         psymbol_cache.
4604         (objfile::~objfile): Don't destroy psymbol_cache.
4605         * mdebugread.c (parse_partial_symbols): Update.
4606         * dwarf2read.c (create_addrmap_from_index)
4607         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4608         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4609         (add_partial_subprogram, dwarf2_ranges_read): Update.
4610         * dwarf-index-write.c (write_address_map)
4611         (write_one_signatured_type, recursively_write_psymbols)
4612         (class debug_names, class debug_names, write_psymtabs_to_index):
4613         Update.
4614
4615 2019-01-10  Tom Tromey  <tom@tromey.com>
4616
4617         * symtab.h (SYMBOL_SET_NAMES): Update.
4618         (symbol_set_names): Update.
4619         (MSYMBOL_SET_NAMES): Update.
4620         * symtab.c (symbol_set_names): Change argument to be an
4621         objfile_per_bfd_storage.
4622         * psymtab.c (add_psymbol_to_bcache): Update.
4623         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4624
4625 2019-01-10  Tom Tromey  <tom@tromey.com>
4626
4627         * symtab.c (create_demangled_names_hash): Change argument to be an
4628         objfile_per_bfd_storage.
4629         (symbol_set_names): Update.
4630
4631 2019-01-10  Tom Tromey  <tom@tromey.com>
4632
4633         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4634         init_psymbol_list.
4635         * psymtab.c (init_psymbol_list): Do nothing if already called.
4636         * psympriv.h (init_psymbol_list): Add comment.
4637         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4638         init_psymbol_list.
4639         * dbxread.c (dbx_symfile_read): Unconditionally call
4640         init_psymbol_list.
4641
4642 2019-01-10  Tom Tromey  <tom@tromey.com>
4643
4644         * xcoffread.c (scan_xcoff_symtab): Update.
4645         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4646         "where".
4647         * mdebugread.c (parse_partial_symbols)
4648         (handle_psymbol_enumerators): Update.
4649         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4650         * dbxread.c (read_dbx_symtab): Update.
4651         * psympriv.h (psymbol_placement): New enum.
4652         (add_psymbol_to_list): Update.
4653
4654 2019-01-10  Tom Tromey  <tom@tromey.com>
4655
4656         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4657         static_psymbols parameters.
4658         (scan_xcoff_symtab): Update.
4659         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4660         static_psymbols parameters.
4661         * psympriv.h (start_psymtab_common): Update.
4662         * mdebugread.c (parse_partial_symbols): Update.
4663         * dwarf2read.c (create_partial_symtab): Update.
4664         * dbxread.c (read_dbx_symtab): Update.
4665         (start_psymtab): Remove global_psymbols and static_psymbols
4666         parameters.
4667
4668 2019-01-10  Tom Tromey  <tom@tromey.com>
4669
4670         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4671         * psymtab.c (allocate_psymtab): Add comment.
4672         * psympriv.h (allocate_psymtab): Add comment.
4673         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4674         initializations.
4675         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4676
4677 2019-01-10  Tom Tromey  <tom@tromey.com>
4678
4679         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4680         Don't declare.
4681         * mipsread.c: Include mdebugread.h.
4682         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4683         Declare.
4684         * elfread.c: Include mdebugread.h.
4685
4686 2019-01-09  Tom Tromey  <tom@tromey.com>
4687
4688         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4689         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4690         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4691         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4692         (psym_lookup_symbol, psym_find_last_source_symtab)
4693         (psym_forget_cached_source_info, psym_print_stats)
4694         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4695         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4696         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4697         (psym_find_compunit_symtab_by_address)
4698         (maintenance_print_psymbols, maintenance_info_psymtabs)
4699         (maintenance_check_psymtabs): Use ranged for.
4700         * psymtab.h (class objfile_psymtabs): New.
4701         (require_partial_symbols): Return objfile_psymtabs.
4702         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4703
4704 2019-01-09  Tom Tromey  <tom@tromey.com>
4705
4706         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4707         (find_pc_mapped_section, list_overlays_command)
4708         (map_overlay_command, unmap_overlay_command)
4709         (simple_overlay_update): Use all_objfiles.
4710         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4711         * printcmd.c (info_symbol_command): Use all_objfiles.
4712         * objfiles.h (ALL_OBJSECTIONS): Remove.
4713         * maint.c (maintenance_translate_address): Use all_objfiles.
4714         * gcore.c (gcore_create_callback): Use all_objfiles.
4715         (objfile_find_memory_regions): Likewise.
4716
4717 2019-01-09  Tom Tromey  <tom@tromey.com>
4718
4719         * symtab.c (find_line_symtab, info_sources_command)
4720         (make_source_files_completion_list): Use objfile_compunits.
4721         * source.c (select_source_symtab): Use objfile_compunits.
4722         * objfiles.h (struct objfile): Update comment.
4723         (ALL_OBJFILES): Remove.
4724         (ALL_FILETABS): Remove.
4725         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4726         objfile_compunits.
4727
4728 2019-01-09  Tom Tromey  <tom@tromey.com>
4729
4730         * symmisc.c (print_objfile_statistics, dump_objfile)
4731         (maintenance_print_symbols): Use compunit_filetabs.
4732         * source.c (forget_cached_source_info_for_objfile): Use
4733         compunit_filetabs.
4734         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4735         (ALL_FILETABS): Use compunit_filetabs.
4736         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4737         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4738
4739 2019-01-09  Tom Tromey  <tom@tromey.com>
4740
4741         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4742         (compunit_filetabs): New.
4743         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4744         compunit_filetabs.
4745         (info_sources_command, make_source_files_completion_list): Remove
4746         declaration.
4747         * symmisc.c (print_objfile_statistics, dump_objfile)
4748         (maintenance_print_symbols): Remove declaration.
4749         (maintenance_info_symtabs): Use compunit_filetabs.
4750         (maintenance_info_line_tables): Likewise.
4751         * source.c (select_source_symtab): Change local variable name.
4752         (forget_cached_source_info_for_objfile): Remove declaration.
4753         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4754         * objfiles.c (objfile_relocate1): Remove declaration.
4755         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4756         declaration.
4757         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4758         * coffread.c (coff_symtab_read): Remove declaration.
4759         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4760         compunit_filetabs.
4761
4762 2019-01-09  Tom Tromey  <tom@tromey.com>
4763
4764         * symtab.c (lookup_objfile_from_block)
4765         (find_pc_sect_compunit_symtab, search_symbols)
4766         (default_collect_symbol_completion_matches_break_on): Use
4767         objfile_compunits.
4768         * objfiles.h (ALL_COMPUNITS): Remove.
4769         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4770         * cp-support.c (add_symbol_overload_list_qualified): Use
4771         objfile_compunits.
4772         * ada-lang.c (ada_collect_symbol_completion_matches)
4773         (ada_add_global_exceptions): Use objfile_compunits.
4774
4775 2019-01-09  Tom Tromey  <tom@tromey.com>
4776
4777         * source.c (select_source_symtab)
4778         (forget_cached_source_info_for_objfile): Remove declaration.
4779         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4780         declaration.
4781         * maint.c (count_symtabs_and_blocks): Remove declaration.
4782         * cp-support.c (add_symbol_overload_list_qualified): Remove
4783         declaration.
4784         * coffread.c (coff_symtab_read): Remove declaration.
4785         * symtab.c (lookup_symbol_in_objfile_symtabs)
4786         (basic_lookup_transparent_type_1): Use objfile_compunits.
4787         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4788         (info_sources_command, search_symbols)
4789         (default_collect_symbol_completion_matches_break_on)
4790         (make_source_files_completion_list): Remove declaration.
4791         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4792         (ada_collect_symbol_completion_matches)
4793         (ada_add_global_exceptions): Remove declaration.
4794         * linespec.c (iterate_over_all_matching_symtabs): Use
4795         objfile_compunits.
4796         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4797         (class objfile_compunits): New.
4798         (ALL_COMPUNITS): Use objfile_compunits.
4799         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4800         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4801         objfile_compunits.
4802         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4803
4804 2019-01-09  Tom Tromey  <tom@tromey.com>
4805
4806         * symtab.c (search_symbols)
4807         (default_collect_symbol_completion_matches_break_on): Use
4808         objfile_msymbols.
4809         * ada-lang.c (ada_lookup_simple_minsym)
4810         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4811         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4812         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4813         objfile_msymbols.
4814         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4815         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4816         * objc-lang.c (find_methods): Use objfile_msymbols.
4817         (info_selectors_command, info_classes_command): Likewise.
4818         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4819         * objfiles.h (class objfile_msymbols): New.
4820         (ALL_OBJFILE_MSYMBOLS): Remove.
4821         (ALL_MSYMBOLS): Remove.
4822
4823 2019-01-09  Tom Tromey  <tom@tromey.com>
4824
4825         * common/next-iterator.h (next_adapter): Add Iterator template
4826         parameter.
4827         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4828         (class all_objfiles_safe): New.
4829         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4830         * objfiles.c (put_objfile_before): Update comment.
4831         (add_separate_debug_objfile): Likewise.
4832         (free_all_objfiles): Use all_objfiles_safe.
4833         (objfile_purge_solibs): Likewise.
4834
4835 2019-01-09  Tom Tromey  <tom@tromey.com>
4836
4837         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4838         (expand_symtab_containing_pc, lookup_static_symbol)
4839         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4840         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4841         all_objfiles.
4842         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4843         * breakpoint.c (create_overlay_event_breakpoint)
4844         (create_longjmp_master_breakpoint)
4845         (create_std_terminate_master_breakpoint)
4846         (create_exception_master_breakpoint): Use all_objfiles.
4847         * linux-thread-db.c (try_thread_db_load_from_pdir)
4848         (has_libpthread): Use all_objfiles.
4849         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4850         * linespec.c (iterate_over_all_matching_symtabs)
4851         (search_minsyms_for_name): Use all_objfiles.
4852         * maint.c (maintenance_info_sections): Use all_objfiles.
4853         * main.c (captured_main_1): Use all_objfiles.
4854         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4855         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4856         * guile/scm-pretty-print.c
4857         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4858         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4859         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4860         (maintenance_print_msymbols): Use all_objfiles.
4861         * source.c (select_source_symtab): Use all_objfiles.
4862         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
4863         * symfile.c (remove_symbol_file_command)
4864         (expand_symtabs_matching, map_symbol_filenames): Use
4865         all_objfiles.
4866         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
4867         all_objfiles.
4868         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
4869         * objc-lang.c (find_methods): Use all_objfiles.
4870         * objfiles.c (have_partial_symbols, have_full_symbols)
4871         (have_minimal_symbols, qsort_cmp)
4872         (default_iterate_over_objfiles_in_search_order): Use
4873         all_objfiles.
4874         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
4875         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
4876         (maintenance_check_psymtabs): Use all_objfiles.
4877         (ALL_PSYMTABS): Remove.
4878         * compile/compile-object-run.c (do_module_cleanup): Use
4879         all_objfiles.
4880         * blockframe.c (find_pc_partial_function): Use all_objfiles.
4881         * cp-support.c (add_symbol_overload_list_qualified): Use
4882         all_objfiles.
4883         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4884         Use all_objfiles.
4885         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
4886         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
4887         all_objfiles.
4888         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4889         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
4890         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4891         Uses all_objfiles.
4892         * solib.c (solib_read_symbols): Use all_objfiles
4893
4894 2019-01-09  Tom Tromey  <tom@tromey.com>
4895
4896         * probe.c (parse_probes_in_pspace): Use all_objfiles.
4897         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
4898         all_objfiles.
4899         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
4900         * symmisc.c (print_symbol_bcache_statistics)
4901         (print_objfile_statistics, maintenance_print_objfiles)
4902         (maintenance_info_symtabs, maintenance_check_symtabs)
4903         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
4904         all_objfiles.
4905         * source.c (forget_cached_source_info): Use all_objfiles.
4906         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
4907         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4908         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
4909         * objfiles.c (update_section_map): Use all_objfiles.
4910         (shared_objfile_contains_address_p): Likewise.
4911         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
4912         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
4913
4914 2019-01-09  Tom Tromey  <tom@tromey.com>
4915
4916         * common/next-iterator.h: New file.
4917         * objfiles.h (class all_objfiles): New.
4918         (struct objfile_iterator): New.
4919
4920 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4921
4922         * NEWS: Move the description of the changed "frame", "select-frame",
4923          and "info frame" commands to the Changed commands section.
4924
4925 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
4926
4927         * gdbtypes.c (check_stub_method_group): Remove handling of old
4928         mangling schemes.
4929         * linespec.c (find_methods): Likewise.
4930         * stabsread.c (read_member_functions): Likewise.
4931         * valops.c (search_struct_method): Likewise.
4932         (value_struct_elt_for_reference): Likewise.
4933         * NEWS: Mention this change.
4934
4935 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4936
4937         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
4938         print_source_lines.
4939         * source.c (print_source_lines_base): Update line number check.
4940         (print_source_lines): New function.
4941         (source_lines_range::source_lines_range): New function.
4942         * source.h (class source_lines_range): New class.
4943         (print_source_lines): New declaration.
4944
4945 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4946
4947         * linespec.c (linespec_state_destructor): Free self->canonical_names.
4948
4949 2019-01-08  Tom Tromey  <tom@tromey.com>
4950             Simon Marchi  <simon.marchi@ericsson.com>
4951
4952         PR gdb/24060
4953         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
4954         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
4955         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4956         * f-exp.y (DOLLAR_VARIABLE): Likewise.
4957         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
4958         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4959
4960 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4961
4962         * source.c (select_source_symtab): Move header comment to
4963         declaration in source.h.
4964         (forget_cached_source_info_for_objfile): Likewise.
4965         (forget_cached_source_info): Likewise.
4966         (identify_source_line): Likewise.
4967         * source.h (identify_source_line): Move declaration from symtab.h
4968         and add comment from source.c
4969         (print_source_lines): Likewise.
4970         (forget_cached_source_info_for_objfile): Likewise.
4971         (forget_cached_source_info): Likewise.
4972         (select_source_symtab): Likewise.
4973         (enum print_source_lines_flag): Move definition from symtab.h.
4974         * symtab.h (identify_source_line): Move declaration to source.h.
4975         (print_source_lines): Likewise.
4976         (forget_cached_source_info_for_objfile): Likewise.
4977         (forget_cached_source_info): Likewise.
4978         (select_source_symtab): Likewise.
4979         (enum print_source_lines_flag): Move definition to source.h.
4980         * tui/tui-hooks.c: Add 'source.h' include.
4981
4982 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4983
4984         * source.c (print_source_lines_base): Handle requests to print
4985         reverse line number sequences, and guard against empty lines
4986         string.
4987
4988 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4989
4990         * source.c (print_source_lines_base): Fix skip of '\r' if next
4991         character is '\n'.
4992
4993 2019-01-06  Tom Tromey  <tom@tromey.com>
4994
4995         * c-exp.y (struct c_parse_state) <macro_original_text,
4996         expansion_obstack>: New member.
4997         (macro_original_text, expansion_obstack): Remove globals.
4998         (scan_macro_expansion, scanning_macro_expansion)
4999         (finished_macro_expansion): Update.
5000         (scan_macro_cleanup): Remove.
5001         (yylex, c_parse): Update.
5002
5003 2019-01-06  Tom Tromey  <tom@tromey.com>
5004
5005         * c-exp.y (struct c_parse_state) <strings>: New member.
5006         (operator_stoken): Update.
5007
5008 2019-01-06  Tom Tromey  <tom@tromey.com>
5009
5010         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5011         (union type_stack_elt) <typelist_val>: Now a pointer to
5012         std::vector.
5013         (type_stack_cleanup): Don't declare.
5014         (push_typelist): Update.
5015         * parse.c (pop_typelist): Return a std::vector.
5016         (push_typelist): Take a std::vector.
5017         (follow_types): Update.  Do not free args.
5018         (type_stack_cleanup): Remove.
5019         * c-exp.y (struct c_parse_state): New.
5020         (cpstate): New global.
5021         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5022         (nonempty_typelist): Update.
5023         (func_mod): Create a new vector.
5024         (c_parse): Create a c_parse_state.
5025         (check_parameter_typelist): Do not delete params.
5026         (function_method): Update.  Do not delete type_list.
5027
5028 2019-01-06  Tom Tromey  <tom@tromey.com>
5029
5030         PR gdb/28155:
5031         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5032         check_typedef.
5033         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5034         (print_return_value): Likewise.
5035
5036 2019-01-05  Tom Tromey  <tom@tromey.com>
5037
5038         * contrib/cleanup_check.py: Remove.
5039         * contrib/gcc-with-excheck: Remove.
5040         * contrib/exsummary.py: Remove.
5041         * contrib/excheck.py: Remove.
5042
5043 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5044
5045         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5046         NULL. Initialize tpprev to NULL instead of assigning it
5047         to NULL on the next statement.
5048         * windows-nat.c (windows_delete_thread): Remove check for
5049         main_thread_id before printing thread exit notifications.
5050         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5051         Remove thread ID check against main_thread_id.
5052         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5053         windows_delete_thread.
5054         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5055
5056 2019-01-04  Tom Tromey  <tom@tromey.com>
5057
5058         * compile/compile.c (_initialize_compile): Use upper case for
5059         metasyntactic variables.
5060         * symmisc.c (_initialize_symmisc): Use upper case for
5061         metasyntactic variables.
5062         * psymtab.c (_initialize_psymtab): Use upper case for
5063         metasyntactic variables.
5064         * demangle.c (demangle_command): Use upper case for metasyntactic
5065         variables.
5066         (_initialize_demangler): Likewise.
5067         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5068         variables.
5069
5070 2019-01-03  Tom Tromey  <tom@tromey.com>
5071
5072         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5073
5074 2019-01-03  Tom Tromey  <tom@tromey.com>
5075
5076         * python/py-symtab.c (salpy_str): Update.
5077         (struct salpy_sal_object) <symtab>: Now a PyObject.
5078         (salpy_dealloc): Update.
5079         (del_objfile_sal): Use gdbpy_ref.
5080
5081 2019-01-03  Tom Tromey  <tom@tromey.com>
5082
5083         * python/py-type.c (convert_field): Use new_reference.  Return
5084         gdbpy_ref.
5085         (make_fielditem): Return gdbpy_ref.
5086         (typy_fields): Update.
5087         (typy_getitem): Update.
5088         (field_name): Return gdbpy_ref.  Use new_reference.
5089         (typy_iterator_iternext): Update.
5090
5091 2019-01-03  Tom Tromey  <tom@tromey.com>
5092
5093         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5094
5095 2019-01-03  Tom Tromey  <tom@tromey.com>
5096
5097         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5098         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5099         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5100         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5101         (pspy_set_type_printers): Likewise.
5102         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5103         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5104         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5105         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5106         (objfpy_set_type_printers): Likewise.
5107
5108 2019-01-03  Tom Tromey  <tom@tromey.com>
5109
5110         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5111         (gdbpy_print_stack): Use gdbpy_err_fetch.
5112         * python/python-internal.h (class gdbpy_err_fetch): New class.
5113         (class gdbpy_enter) <m_error_type, m_error_value,
5114         m_error_traceback>: Remove.
5115         <m_error>: New member.
5116         (gdbpy_exception_to_string): Don't declare.
5117         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5118         * python/py-value.c (convert_value_from_python): Use
5119         gdbpy_err_fetch.
5120         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5121         gdbpy_exception_to_string.
5122         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5123         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5124         gdbpy_err_fetch.
5125
5126 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5127
5128         * linux-nat.c (delete_lwp_cleanup): Delete.
5129         (struct lwp_deleter): New struct.
5130         (lwp_info_up): New typedef.
5131         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5132         lwp_info_up.
5133
5134 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5135
5136         * linux-fork.c (class scoped_switch_fork_info): New class.
5137         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5138
5139 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5140
5141         * valops.c (find_overload_match): Remove use of null_cleanup, and
5142         calls to do_cleanups.
5143
5144 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5145
5146         * compile/compile-cplus-types.c
5147         (compile_cplus_instance::decl_name): Handle changes to
5148         cp_func_name.
5149         * cp-support.c (cp_func_name): Update header comment, update
5150         return type.
5151         * cp-support.h (cp_func_name): Update return type in declaration.
5152         * valops.c (find_overload_match): Move temp_func local to top
5153         level of function and change its type.  Use temp_func to hold and
5154         delete temporary string obtained from cp_func_name.
5155
5156 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5157
5158         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5159         gdb::char_vector, remove cleanup, and update uses of `msg`.
5160
5161 2019-01-03  Jim Wilson  <jimw@sifive.com>
5162
5163         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5164
5165 2019-01-02  Tom Tromey  <tom@tromey.com>
5166
5167         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5168         (tdesc_parse_xml): Remove cleanups.
5169         * target-descriptions.h (make_cleanup_free_target_description):
5170         Don't declare.
5171         (target_desc_deleter): New struct.
5172         (target_desc_up): New typedef.
5173         * target-descriptions.c (target_desc_deleter::operator()): Rename
5174         from free_target_description.
5175         (make_cleanup_free_target_description): Remove.
5176
5177 2019-01-02  Tom Tromey  <tom@tromey.com>
5178
5179         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5180         constructor, destructor.
5181         (linespec_parser): Remove typedef.
5182         (~linespec_parser): Rename from linespec_parser_delete.
5183         (linespec_lex_to_end, linespec_complete_label)
5184         (linespec_complete): Update.
5185         (decode_line_full): Remove cleanups.
5186         (decode_line_1): Update.
5187
5188 2019-01-02  Tom Tromey  <tom@tromey.com>
5189
5190         * python/python-internal.h (inferior_to_inferior_object): Change
5191         return type.
5192         * python/py-exitedevent.c (create_exited_event_object): Update.
5193         * python/py-inferior.c (inferior_to_inferior_object): Return
5194         gdbpy_ref.
5195         (python_new_inferior, python_inferior_deleted)
5196         (thread_to_thread_object, delete_thread_object)
5197         (build_inferior_list, gdbpy_selected_inferior): Update.
5198         * python/py-infthread.c (create_thread_object): Update.  Also fail
5199         if inferior_to_inferior_object fails.
5200
5201 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5202
5203         * inferior.h (class inferior) <displaced_step_state>: New field.
5204         * infrun.h (struct displaced_step_state): Move here from
5205         infrun.c.  Initialize fields, add constructor.
5206         <inf>: Remove field.
5207         <reset>: New method.
5208         * infrun.c (struct displaced_step_inferior_state): Move to
5209         infrun.h.
5210         (displaced_step_inferior_states): Remove.
5211         (get_displaced_stepping_state): Adust.
5212         (displaced_step_in_progress_any_inferior): Adjust.
5213         (displaced_step_in_progress_thread): Adjust.
5214         (displaced_step_in_progress): Adjust.
5215         (add_displaced_stepping_state): Remove.
5216         (get_displaced_step_closure_by_addr): Adjust.
5217         (remove_displaced_stepping_state): Remove.
5218         (infrun_inferior_exit): Call displaced_step_state.reset.
5219         (use_displaced_stepping): Don't check for NULL.
5220         (displaced_step_prepare_throw): Call
5221         get_displaced_stepping_state.
5222         (displaced_step_fixup): Don't check for NULL.
5223         (prepare_for_detach): Don't check for NULL.
5224
5225 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5226
5227         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5228          in case of call that did not complete.
5229
5230 2019-01-02  Andrey Utkin  <autkin@undo.io>
5231
5232         * symfile.c (find_separate_debug_file): Fix search of debug files for
5233         remote debuggee.
5234
5235 2019-01-02  Tom Tromey  <tom@tromey.com>
5236
5237         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5238         indentation.
5239         * python/py-frame.c (frapy_older): Remove cast.
5240         (frapy_newer): Likewise.
5241         * python/py-breakpoint.c (local_setattro): Remove cast.
5242         * python/py-arch.c (archpy_name): Remove local variable.
5243         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5244
5245 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5246
5247         * unittests/basic_string_view/element_access/char/empty.cc:
5248         Fix year range in copyright header.
5249
5250 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5251
5252         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5253         Delete.
5254         <operator==>: Update with for removed field.
5255         <hash>: Likewise.
5256         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5257         <isa_features>: ...this.
5258         <abi_features>: New field.
5259         (riscv_isa_flen): Update comment.
5260         (riscv_abi_xlen): New declaration.
5261         (riscv_abi_flen): New declaration.
5262         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5263         isa_features.
5264         (riscv_abi_xlen): New function.
5265         (riscv_isa_flen): Update to get answer from isa_features.
5266         (riscv_abi_flen): New function.
5267         (riscv_has_fp_abi): Update to get answer from abi_features.
5268         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5269         xlen and flen.
5270         (riscv_call_info) <xlen, flen>: Update comment.
5271         (riscv_call_arg_struct): Remove invalid assertions
5272         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5273         is removed.
5274         (riscv_gdbarch_init): Gather isa features and abi features
5275         separately, ensure both match on the gdbarch when reusing an old
5276         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5277         a target with 64-bit float hardware.
5278
5279 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5280
5281         * source.c (search_command_helper): Stop reverse search
5282         when line 1 has been searched.
5283
5284 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5285
5286         * record-full.c (record_full_base_target::close): Rewrite
5287         record_full_core_buf_list free logic.
5288
5289 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5290
5291         * break-catch-syscall.c (print_one_catch_syscall): xfree
5292         the last text.
5293
5294 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5295
5296         * top.c (print_gdb_version): Update Copyright year in version
5297         message.
5298
5299 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5300
5301         Update copyright year range in all GDB files.
5302
5303 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5304
5305         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5306
5307 For older changes see ChangeLog-2018.
5308 \f
5309 Local Variables:
5310 mode: change-log
5311 left-margin: 8
5312 fill-column: 74
5313 version-control: never
5314 coding: utf-8
5315 End:
5316