gdb/iq2000: Use default gdbarch methods where possible
[external/binutils.git] / gdb / ChangeLog
1 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2
3         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4         (iq2000_unwind_pc): Delete.
5         (iq2000_dummy_id): Delete.
6         (iq2000_gdbarch_init): Don't register deleted functions with
7         gdbarch.
8
9 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10
11         * nds32-tdep.c (nds32_type_align): Delete.
12         (nds32_push_dummy_call): Use type_align instead.
13
14 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
15
16         * arm-tdep.c (arm_type_align): Only handle vector override case.
17         (arm_push_dummy_call): Use type_align.
18         (arm_gdbarch_init): Register arm_type_align gdbarch function.
19
20 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
21
22         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
23         case.
24         (pass_on_stack): Use type_align.
25         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
26         function.
27
28 2019-04-23  Tom Tromey  <tromey@adacore.com>
29
30         * dwarf2read.c (line_header::file_name_at): Remove unused
31         overload.
32
33 2019-04-23  Tom de Vries  <tdevries@suse.de>
34
35         PR gdb/24438
36         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
37         invocation.
38
39
40 2019-03-27  Ali Tamur  <tamur@google.com>
41
42         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
43         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
44         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
45         (dwarf_expr_context::get_addr_index): Likewise
46         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
47         (symbol_needs_eval_context::get_addr_index): Likewise
48         (disassemble_dwarf_expression): Add DW_OP_addrx
49         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
50         (read_cutu_die_from_dwo): Update comment
51         (skip_one_die): Add DW_FORM_addrx
52         (read_attribute_value): Likewise
53         (var_decode_location): Add DW_OP_addrx
54         (dwarf2_const_value_attr): Add DW_FORM_addrx
55         (dump_die_shallow): Likewise
56         (dwarf2_fetch_constant_bytes): Likewise
57         (decode_locdesc): Add DW_OP_addrx
58         (skip_form_bytes): Add DW_FORM_addrx
59
60 2019-04-22  Ali Tamur  <tamur@google.com>
61
62         * MAINTAINERS (Write After Approval): Add self.
63
64 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
65
66         * solib-svr4.c (get_svr4_info): Add pspace parameter.
67         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
68         (open_symbol_file_object): Likewise.
69         (svr4_default_sos): Add info parameter.
70         (svr4_read_so_list): Likewise.
71         (svr4_current_sos_direct): Adjust functions calls to pass down
72         info.
73         (svr4_current_sos_1): Add info parameter.
74         (svr4_current_sos): Call get_svr4_info, pass info down to
75         svr4_current_sos_1.
76         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
77         get_svr4_info.
78         (svr4_in_dynsym_resolve_code): Pass current_program_space to
79         get_svr4_info.
80         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
81         to get_svr4_info.
82         (probes_table_remove_objfile_probes): Likewise.
83         (register_solib_event_probe): Add info parameter.
84         (solist_update_incremental): Pass info parameter down to
85         svr4_read_so_list.
86         (disable_probes_interface): Add info parameter.
87         (svr4_handle_solib_event): Pass current_program_space to
88         get_svr4_info.  Adjust disable_probes_interface cleanup.
89         (svr4_create_probe_breakpoints): Add info parameter, pass it
90         down to register_solib_event_probe.
91         (svr4_create_solib_event_breakpoints): Add info parameter,
92         pass it down to svr4_create_probe_breakpoints.
93         (enable_break): Pass info down to
94         svr4_create_solib_event_breakpoints.
95         (svr4_solib_create_inferior_hook): Pass current_program_space to
96         get_svr4_info.
97         (svr4_clear_solib): Likewise.
98
99 2019-04-22  Pedro Alves  <palves@redhat.com>
100
101         * solib-svr4.c (svr4_free_objfile_observer): New.
102         (probe_and_action::objfile): New field.
103         (probes_table_htab_remove_objfile_probes)
104         (probes_table_remove_objfile_probes): New functions.
105         (register_solib_event_probe): Add 'objfile' parameter.  Store it
106         in the new probe_and_action.  Don't store the probe in 'lookup'.
107         (svr4_create_probe_breakpoints): Pass objfile to
108         register_solib_event_probe.
109         (_initialize_svr4_solib): Register a free_objfile observer.
110
111 2019-04-19  Tom Tromey  <tom@tromey.com>
112
113         * common/queue.h: Remove.
114
115 2019-04-19  Tom Tromey  <tom@tromey.com>
116
117         * event-loop.c: Don't include "common/queue.h".
118
119 2019-04-19  Tom Tromey  <tom@tromey.com>
120
121         * remote.c (remote_target): Use delete.
122         * remote-notif.h: Include <list>, not "common/queue.h".
123         (notif_client_p): Remove typedef.
124         (remote_notif_state): Add constructor, destructor, initializer.
125         <notif_queue>: Now a std::list.
126         (remote_notif_state_xfree): Don't declare.
127         * remote-notif.c (remote_notif_process, handle_notification)
128         (remote_notif_state_allocate): Update.
129         (~remote_notif_state): Rename from remote_notif_state_xfree.
130
131 2019-04-19  Tom Tromey  <tom@tromey.com>
132
133         * symfile.c (reread_symbols): Update.
134         * objfiles.c (objfile_register_static_link)
135         (objfile_lookup_static_link): Update
136         (~objfile) Don't delete static_links.
137         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
138
139 2019-04-19  Tom Tromey  <tom@tromey.com>
140
141         * type-stack.h (struct type_stack) <insert>: Constify string.
142         * type-stack.c (type_stack::insert): Constify string.
143         * gdbtypes.h (lookup_template_type): Update.
144         (address_space_name_to_int): Update.
145         * gdbtypes.c (address_space_name_to_int): Make space_identifier
146         const.
147         (lookup_template_type): Make name const.
148         * c-exp.y: Update rules.
149         (lex_one_token, classify_name, classify_inner_name)
150         (c_print_token): Update.
151         * p-exp.y: Update rules.
152         (yylex): Update.
153         * f-exp.y: Update rules.
154         (yylex): Update.
155         * d-exp.y: Update rules.
156         (lex_one_token, classify_name, classify_inner_name): Update.
157         * parse.c (write_dollar_variable, copy_name): Return std::string.
158         * parser-defs.h (copy_name): Change return type.
159         * m2-exp.y: Update rules.
160         (yylex): Update.
161         * go-exp.y (lex_one_token): Update.
162         Update rules.
163         (classify_unsafe_function, classify_packaged_name)
164         (classify_name, yylex): Update.
165
166 2019-04-19  Sergei Trofimovich <siarheit@google.com>
167
168         * configure.ac: add --enable-source-highlight switch.
169         * configure: Regenerate.
170         * top.c (print_gdb_version): plumb --enable-source-highlight
171         status to "show configuration".
172
173 2019-04-19  Tom Tromey  <tromey@adacore.com>
174
175         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
176         Check ADA_TYPE_P.
177         (empty_record, ada_template_to_fixed_record_type_1)
178         (template_to_static_fixed_type)
179         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
180         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
181         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
182         macros.
183
184 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
185
186         PR symtab/24423:
187         * source.c (print_source_lines_base): Advance "iter" when a
188         control character is seen.
189
190 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
191
192         * inferior.h (struct infcall_suspend_state_deleter):
193         Catch exception in destructor to avoid crash.
194
195 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
196
197         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
198         close to the add_com "shell".
199
200 2019-04-18  Tom Tromey  <tromey@adacore.com>
201
202         * process-stratum-target.h (class process_stratum_target)
203         <stratum>: Add "final".
204
205 2019-04-17  Tom Tromey  <tromey@adacore.com>
206
207         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
208         against nullptr before use.
209
210 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
211
212         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
213
214 2019-04-17  Jim Wilson  <jimw@sifive.com>
215             Andrew Burgess  <andrew.burgess@embecosm.com>
216
217         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
218         code read might fail, assume 4-byte breakpoint in that case.
219
220 2019-04-15  Leszek Swirski  <leszeks@google.com>
221
222         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
223         rather than a hand-rolled POD check when checking for forced MEMORY
224         classification.
225
226 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
227
228         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
229         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
230         function.
231         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
232         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
233         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
234         declaration.
235
236 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
237
238         * aarch64-linux-nat.c
239         (aarch64_linux_nat_target::thread_architecture): Add override.
240         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
241         each VQ.
242
243 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
244
245         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
246
247 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
248
249         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
250         target types of size 96-bits, add some additional comments, and
251         check that the builtin type we found was the correct size.
252
253 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
254
255         * utils.c (prompt_for_continue): Don't restore the styling at the
256         end, as applied_style has the wrong value.  This fixes styling in
257         long lists of file names that are interrupted by the "Continue?"
258         prompt.
259
260 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
261
262         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
263         * c-lang.c (c_language_defn): Likewise.
264         (cplus_language_defn): Likewise.
265         (asm_language_defn): Likewise.
266         (minimal_language_defn): Likewise.
267         * d-lang.c (d_language_defn): Likewise.
268         * f-lang.c (f_language_defn): Likewise.
269         * go-lang.c (go_language_defn): Likewise.
270         * language.c (unknown_language_defn): Likewise.
271         (auto_language_defn): Likewise.
272         * language.h (struct language_defn): Remove la_magic field.
273         (LANG_MAGIC): Delete.
274         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
275         * objc-lang.c (objc_language_defn): Likewise.
276         * opencl-lang.c (opencl_language_defn): Likewise.
277         * p-lang.c (pascal_language_defn): Likewise.
278         * rust-lang.c (rust_language_defn): Likewise.
279
280 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
281
282         * riscv-tdep.c (riscv_type_align): New function.
283         (riscv_type_alignment): Delete.
284         (riscv_arg_location): Use 'type_align'.
285         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
286
287 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
288
289         * gdbtypes.c (type_align): A struct with no non-static fields also
290         has alignment of 1.
291
292 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
293
294         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
295         component to 0.
296         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
297         member.
298         (riscv_struct_info::analyse): New implementation using new
299         analyse_inner member function.
300         (riscv_struct_info::field_offset): New member function.
301         (riscv_struct_info::m_offsets): New member variable.
302         (riscv_struct_info::analyse_inner): New private member function,
303         takes the old implementation of riscv_struct_info::analyse but
304         extended to track field offsets.
305         (riscv_call_arg_struct): Update the struct folding special cases
306         to handle cases where empty C++ structs, which are non-zero
307         length, are found.
308         (riscv_arg_location): Initialise the length of each location, a
309         non-zero length now indicates the location is in use.
310         (riscv_push_dummy_call): Allow for the first location having a
311         non-zero offset when setting up arguments.
312         (riscv_return_value): Likewise, but for return values.
313
314 2019-04-11  Tom Tromey  <tromey@adacore.com>
315
316         * utils.c (internal_vproblem): Make "msg" const.
317
318 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
319
320         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
321         * trad-frame.c (trad_frame_reset_saved_regs): New function.
322         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
323         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
324
325 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
326
327         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
328         function.
329         (fill_gregset): Call amd64_linux_collect_native_gregset instead
330         of amd64_collect_native_gregset.
331         (amd64_linux_nat_target::store_registers): Likewise.
332
333 2019-04-10  Tom Tromey  <tom@tromey.com>
334
335         * symtab.c (lookup_global_symbol_from_objfile)
336         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
337         * objfiles.h (class separate_debug_iterator): New.
338         (class separate_debug_range): New.
339         (struct objfile) <separate_debug_objfiles>: New method.
340         (objfile_separate_debug_iterate): Don't declare.
341         * objfiles.c (separate_debug_iterator::operator++): Rename from
342         objfile_separate_debug_iterate.
343         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
344         iterator.
345         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
346         iterator.
347
348 2019-04-10  Tom Tromey  <tom@tromey.com>
349
350         * symfile.c (reread_symbols): Remove old comment.
351         * objfiles.c (free_all_objfiles): Fix a typo.
352
353 2019-04-10  Tom Tromey  <tom@tromey.com>
354
355         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
356         * minsyms.c (lookup_minimal_symbol): Use foreach.
357         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
358         (lookup_minimal_symbol_solib_trampoline): Likewise.
359         * symfile.c (reread_symbols): Use foreach.
360
361 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
362             Tom Tromey  <tromey@adacore.com>
363
364         PR rust/24414:
365         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
366         (rust_lex_int_test): Change "value" to be LONGEST.
367         (rust_lex_tests): Add test for long integer literal.
368
369 2019-04-09  Tom Tromey  <tromey@adacore.com>
370
371         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
372         to bool.
373         (extended_remote_target::attach): Update.
374         (remote_target::remote_notice_new_inferior): Update.
375         (remote_target::add_current_inferior_and_thread): Update.
376         * inferior.c (exit_inferior_1): Use "false".
377         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
378
379 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
380
381         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
382         the "start" command.
383
384 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
385
386         * python/py-inferior.c (infpy_thread_from_thread_handle):
387         Adjust comments to reflect renaming of thread_from_thread_handle
388         to thread_from_handle.  Adjust keywords.  Fix type error message.
389         (inferior_object_methods): Add thread_from_handle.  Retain
390         thread_from_thread_handle, but mark it as deprecated.
391
392 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
393
394         * gdbthread.h (find_thread_by_handle): Revise declaration.
395         * thread.c (find_thread_by_handle): Likewise.  Adjust
396         implementation too.
397         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
398         support for buffer objects as handles.
399
400 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
401
402         * python/py-infthread.c (thpy_thread_handle): New function.
403         (thread_object_methods): Register thpy_thread_handle.
404
405 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
406
407         * gdbthread.h (thread_to_thread_handle): Declare.
408         * thread.c (gdbtypes.h): Include.
409         (thread_to_thread_handle): New function.
410
411         * target.h (struct target_ops): Add thread_info_to_thread_handle.
412         (target_thread_info_to_thread_handle): Declare.
413         * target.c (target_thread_info_to_thread_handle): New function.
414         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
415         * target-delegates.c: Regenerate.
416
417         * linux-thread-db.c (class thread_db_target): Add method
418         thread_info_to_thread_handle.
419         (thread_db_target::thread_info_to_thread_handle): Define.
420         * remote.c (class remote_target): Add new method
421         thread_info_to_thread_handle.
422         (remote_target::thread_info_to_thread_handle): Define.
423
424 2019-04-08  Pedro Alves  <palves@redhat.com>
425
426         * common/common-exceptions.c (throw_exception): Don't create
427         named object to throw; throw directly.
428         (throw_it): Likewise.  Don't initialize gdb_exception::message
429         here, with new; pass FMT and AP to the ctor instead.
430         * common/common-exceptions.h: Include <string>.
431         (gdb_exception::gdb_exception(enum return_reason, enum errors,
432         const char *, va_list)): New ctor.  Use std::make_shared.
433         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
434         errors)): Delete.
435         (gdb_exception_error::gdb_exception_error(enum errors, const char
436         *, va_list)): New.
437         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
438         Add assertion.
439         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
440         errors)): Delete.
441         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
442         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
443         Add assertion.
444
445 2019-04-08  Tom Tromey  <tom@tromey.com>
446
447         * valops.c (value_rtti_indirect_type): Replace throw_exception
448         with throw.
449         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
450         with throw.
451         * thread.c (thr_try_catch_cmd): Replace throw_exception with
452         throw.
453         * target.c (target_translate_tls_address): Replace throw_exception
454         with throw.
455         * stack.c (frame_apply_command_count): Replace throw_exception
456         with throw.
457         * solib-spu.c (append_ocl_sos): Replace throw_exception with
458         throw.
459         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
460         with throw.
461         * rs6000-tdep.c (rs6000_frame_cache)
462         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
463         * remote.c: Replace throw_exception with throw.
464         * record-full.c (record_full_message, record_full_wait_1)
465         (record_full_restore): Replace throw_exception with throw.
466         * record-btrace.c:
467         (get_thread_current_frame_id, record_btrace_start_replaying)
468         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
469         (cmd_record_btrace_start): Replace throw_exception with throw.
470         * parse.c (parse_exp_in_context_1): Replace throw_exception with
471         throw.
472         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
473         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
474         * linespec.c:
475         (find_linespec_symbols): Replace throw_exception with throw.
476         * infrun.c (displaced_step_prepare, resume): Replace
477         throw_exception with throw.
478         * infcmd.c (post_create_inferior): Replace throw_exception with
479         throw.
480         * inf-loop.c (inferior_event_handler): Replace throw_exception
481         with throw.
482         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
483         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
484         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
485         (get_prev_frame_always, get_frame_pc_if_available)
486         (get_frame_address_in_block_if_available, get_frame_language):
487         Replace throw_exception with throw.
488         * frame-unwind.c (frame_unwind_try_unwinder): Replace
489         throw_exception with throw.
490         * eval.c (fetch_subexp_value, evaluate_var_value)
491         (evaluate_funcall, evaluate_subexp_standard): Replace
492         throw_exception with throw.
493         * dwarf2loc.c (call_site_find_chain)
494         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
495         Replace throw_exception with throw.
496         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
497         with throw.
498         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
499         throw.
500         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
501         * completer.c (complete_line_internal): Replace throw_exception
502         with throw.
503         * compile/compile-object-run.c (compile_object_run): Replace
504         throw_exception with throw.
505         * cli/cli-script.c (process_next_line): Replace throw_exception
506         with throw.
507         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
508         (btrace_enable, btrace_maint_update_pt_packets): Replace
509         throw_exception with throw.
510         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
511         throw_exception with throw.
512         * break-catch-throw.c (re_set_exception_catchpoint): Replace
513         throw_exception with throw.
514         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
515         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
516         * aarch64-tdep.c (aarch64_make_prologue_cache)
517         (aarch64_make_stub_cache): Replace throw_exception with throw.
518
519 2019-04-08  Tom Tromey  <tom@tromey.com>
520
521         * common/common-exceptions.c (throw_exception): Rename from
522         throw_exception_cxx.  Remove old copy.  Make argument const.
523         (throw_it): Create and throw exception objects directly.
524         * common/common-exceptions.h (throw_exception): Make argument
525         const.
526         (struct gdb_exception_error): Add constructor.
527         (struct gdb_exception_quit): Add constructor.
528
529 2019-04-08  Tom Tromey  <tom@tromey.com>
530
531         * common/common-exceptions.h (exception_rethrow): Don't declare.
532         (TRY_SJLJ): Update comment.
533         (TRY, CATCH, END_CATCH): Remove.
534         * common/common-exceptions.c (exception_rethrow): Remove.
535
536 2019-04-08  Tom Tromey  <tom@tromey.com>
537
538         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
539         Remove.
540         (gdb_exception_error): Rename from
541         gdb_exception_RETURN_MASK_ERROR.
542         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
543         (gdb_quit_bad_alloc): Update.
544         * aarch64-tdep.c: Update.
545         * ada-lang.c: Update.
546         * ada-typeprint.c: Update.
547         * ada-valprint.c: Update.
548         * amd64-tdep.c: Update.
549         * arch-utils.c: Update.
550         * break-catch-throw.c: Update.
551         * breakpoint.c: Update.
552         * btrace.c: Update.
553         * c-varobj.c: Update.
554         * cli/cli-cmds.c: Update.
555         * cli/cli-interp.c: Update.
556         * cli/cli-script.c: Update.
557         * common/common-exceptions.c: Update.
558         * common/new-op.c: Update.
559         * common/selftest.c: Update.
560         * compile/compile-c-symbols.c: Update.
561         * compile/compile-cplus-symbols.c: Update.
562         * compile/compile-object-load.c: Update.
563         * compile/compile-object-run.c: Update.
564         * completer.c: Update.
565         * corelow.c: Update.
566         * cp-abi.c: Update.
567         * cp-support.c: Update.
568         * cp-valprint.c: Update.
569         * darwin-nat.c: Update.
570         * disasm-selftests.c: Update.
571         * dtrace-probe.c: Update.
572         * dwarf-index-cache.c: Update.
573         * dwarf-index-write.c: Update.
574         * dwarf2-frame-tailcall.c: Update.
575         * dwarf2-frame.c: Update.
576         * dwarf2loc.c: Update.
577         * dwarf2read.c: Update.
578         * eval.c: Update.
579         * event-loop.c: Update.
580         * event-top.c: Update.
581         * exec.c: Update.
582         * f-valprint.c: Update.
583         * fbsd-tdep.c: Update.
584         * frame-unwind.c: Update.
585         * frame.c: Update.
586         * gdbtypes.c: Update.
587         * gnu-v3-abi.c: Update.
588         * guile/guile-internal.h: Update.
589         * guile/scm-block.c: Update.
590         * guile/scm-breakpoint.c: Update.
591         * guile/scm-cmd.c: Update.
592         * guile/scm-disasm.c: Update.
593         * guile/scm-frame.c: Update.
594         * guile/scm-lazy-string.c: Update.
595         * guile/scm-math.c: Update.
596         * guile/scm-param.c: Update.
597         * guile/scm-ports.c: Update.
598         * guile/scm-pretty-print.c: Update.
599         * guile/scm-symbol.c: Update.
600         * guile/scm-symtab.c: Update.
601         * guile/scm-type.c: Update.
602         * guile/scm-value.c: Update.
603         * i386-linux-tdep.c: Update.
604         * i386-tdep.c: Update.
605         * inf-loop.c: Update.
606         * infcall.c: Update.
607         * infcmd.c: Update.
608         * infrun.c: Update.
609         * jit.c: Update.
610         * language.c: Update.
611         * linespec.c: Update.
612         * linux-fork.c: Update.
613         * linux-nat.c: Update.
614         * linux-tdep.c: Update.
615         * linux-thread-db.c: Update.
616         * main.c: Update.
617         * mi/mi-cmd-break.c: Update.
618         * mi/mi-cmd-stack.c: Update.
619         * mi/mi-interp.c: Update.
620         * mi/mi-main.c: Update.
621         * objc-lang.c: Update.
622         * p-valprint.c: Update.
623         * parse.c: Update.
624         * ppc-linux-tdep.c: Update.
625         * printcmd.c: Update.
626         * python/py-arch.c: Update.
627         * python/py-breakpoint.c: Update.
628         * python/py-cmd.c: Update.
629         * python/py-finishbreakpoint.c: Update.
630         * python/py-frame.c: Update.
631         * python/py-framefilter.c: Update.
632         * python/py-gdb-readline.c: Update.
633         * python/py-inferior.c: Update.
634         * python/py-infthread.c: Update.
635         * python/py-lazy-string.c: Update.
636         * python/py-linetable.c: Update.
637         * python/py-objfile.c: Update.
638         * python/py-param.c: Update.
639         * python/py-prettyprint.c: Update.
640         * python/py-progspace.c: Update.
641         * python/py-record-btrace.c: Update.
642         * python/py-record.c: Update.
643         * python/py-symbol.c: Update.
644         * python/py-type.c: Update.
645         * python/py-unwind.c: Update.
646         * python/py-utils.c: Update.
647         * python/py-value.c: Update.
648         * python/python.c: Update.
649         * record-btrace.c: Update.
650         * record-full.c: Update.
651         * remote-fileio.c: Update.
652         * remote.c: Update.
653         * riscv-tdep.c: Update.
654         * rs6000-aix-tdep.c: Update.
655         * rs6000-tdep.c: Update.
656         * rust-exp.y: Update.
657         * rust-lang.c: Update.
658         * s390-tdep.c: Update.
659         * selftest-arch.c: Update.
660         * solib-dsbt.c: Update.
661         * solib-frv.c: Update.
662         * solib-spu.c: Update.
663         * solib-svr4.c: Update.
664         * solib.c: Update.
665         * sparc64-linux-tdep.c: Update.
666         * stack.c: Update.
667         * symfile-mem.c: Update.
668         * symmisc.c: Update.
669         * target.c: Update.
670         * thread.c: Update.
671         * top.c: Update.
672         * tracefile-tfile.c: Update.
673         * tui/tui.c: Update.
674         * typeprint.c: Update.
675         * unittests/cli-utils-selftests.c: Update.
676         * unittests/parse-connection-spec-selftests.c: Update.
677         * valops.c: Update.
678         * valprint.c: Update.
679         * value.c: Update.
680         * varobj.c: Update.
681         * windows-nat.c: Update.
682         * x86-linux-nat.c: Update.
683         * xml-support.c: Update.
684
685 2019-04-08  Tom Tromey  <tom@tromey.com>
686
687         * xml-support.c: Use C++ exception handling.
688         * x86-linux-nat.c: Use C++ exception handling.
689         * windows-nat.c: Use C++ exception handling.
690         * varobj.c: Use C++ exception handling.
691         * value.c: Use C++ exception handling.
692         * valprint.c: Use C++ exception handling.
693         * valops.c: Use C++ exception handling.
694         * unittests/parse-connection-spec-selftests.c: Use C++ exception
695         handling.
696         * unittests/cli-utils-selftests.c: Use C++ exception handling.
697         * typeprint.c: Use C++ exception handling.
698         * tui/tui.c: Use C++ exception handling.
699         * tracefile-tfile.c: Use C++ exception handling.
700         * top.c: Use C++ exception handling.
701         * thread.c: Use C++ exception handling.
702         * target.c: Use C++ exception handling.
703         * symmisc.c: Use C++ exception handling.
704         * symfile-mem.c: Use C++ exception handling.
705         * stack.c: Use C++ exception handling.
706         * sparc64-linux-tdep.c: Use C++ exception handling.
707         * solib.c: Use C++ exception handling.
708         * solib-svr4.c: Use C++ exception handling.
709         * solib-spu.c: Use C++ exception handling.
710         * solib-frv.c: Use C++ exception handling.
711         * solib-dsbt.c: Use C++ exception handling.
712         * selftest-arch.c: Use C++ exception handling.
713         * s390-tdep.c: Use C++ exception handling.
714         * rust-lang.c: Use C++ exception handling.
715         * rust-exp.y: Use C++ exception handling.
716         * rs6000-tdep.c: Use C++ exception handling.
717         * rs6000-aix-tdep.c: Use C++ exception handling.
718         * riscv-tdep.c: Use C++ exception handling.
719         * remote.c: Use C++ exception handling.
720         * remote-fileio.c: Use C++ exception handling.
721         * record-full.c: Use C++ exception handling.
722         * record-btrace.c: Use C++ exception handling.
723         * python/python.c: Use C++ exception handling.
724         * python/py-value.c: Use C++ exception handling.
725         * python/py-utils.c: Use C++ exception handling.
726         * python/py-unwind.c: Use C++ exception handling.
727         * python/py-type.c: Use C++ exception handling.
728         * python/py-symbol.c: Use C++ exception handling.
729         * python/py-record.c: Use C++ exception handling.
730         * python/py-record-btrace.c: Use C++ exception handling.
731         * python/py-progspace.c: Use C++ exception handling.
732         * python/py-prettyprint.c: Use C++ exception handling.
733         * python/py-param.c: Use C++ exception handling.
734         * python/py-objfile.c: Use C++ exception handling.
735         * python/py-linetable.c: Use C++ exception handling.
736         * python/py-lazy-string.c: Use C++ exception handling.
737         * python/py-infthread.c: Use C++ exception handling.
738         * python/py-inferior.c: Use C++ exception handling.
739         * python/py-gdb-readline.c: Use C++ exception handling.
740         * python/py-framefilter.c: Use C++ exception handling.
741         * python/py-frame.c: Use C++ exception handling.
742         * python/py-finishbreakpoint.c: Use C++ exception handling.
743         * python/py-cmd.c: Use C++ exception handling.
744         * python/py-breakpoint.c: Use C++ exception handling.
745         * python/py-arch.c: Use C++ exception handling.
746         * printcmd.c: Use C++ exception handling.
747         * ppc-linux-tdep.c: Use C++ exception handling.
748         * parse.c: Use C++ exception handling.
749         * p-valprint.c: Use C++ exception handling.
750         * objc-lang.c: Use C++ exception handling.
751         * mi/mi-main.c: Use C++ exception handling.
752         * mi/mi-interp.c: Use C++ exception handling.
753         * mi/mi-cmd-stack.c: Use C++ exception handling.
754         * mi/mi-cmd-break.c: Use C++ exception handling.
755         * main.c: Use C++ exception handling.
756         * linux-thread-db.c: Use C++ exception handling.
757         * linux-tdep.c: Use C++ exception handling.
758         * linux-nat.c: Use C++ exception handling.
759         * linux-fork.c: Use C++ exception handling.
760         * linespec.c: Use C++ exception handling.
761         * language.c: Use C++ exception handling.
762         * jit.c: Use C++ exception handling.
763         * infrun.c: Use C++ exception handling.
764         * infcmd.c: Use C++ exception handling.
765         * infcall.c: Use C++ exception handling.
766         * inf-loop.c: Use C++ exception handling.
767         * i386-tdep.c: Use C++ exception handling.
768         * i386-linux-tdep.c: Use C++ exception handling.
769         * guile/scm-value.c: Use C++ exception handling.
770         * guile/scm-type.c: Use C++ exception handling.
771         * guile/scm-symtab.c: Use C++ exception handling.
772         * guile/scm-symbol.c: Use C++ exception handling.
773         * guile/scm-pretty-print.c: Use C++ exception handling.
774         * guile/scm-ports.c: Use C++ exception handling.
775         * guile/scm-param.c: Use C++ exception handling.
776         * guile/scm-math.c: Use C++ exception handling.
777         * guile/scm-lazy-string.c: Use C++ exception handling.
778         * guile/scm-frame.c: Use C++ exception handling.
779         * guile/scm-disasm.c: Use C++ exception handling.
780         * guile/scm-cmd.c: Use C++ exception handling.
781         * guile/scm-breakpoint.c: Use C++ exception handling.
782         * guile/scm-block.c: Use C++ exception handling.
783         * guile/guile-internal.h: Use C++ exception handling.
784         * gnu-v3-abi.c: Use C++ exception handling.
785         * gdbtypes.c: Use C++ exception handling.
786         * frame.c: Use C++ exception handling.
787         * frame-unwind.c: Use C++ exception handling.
788         * fbsd-tdep.c: Use C++ exception handling.
789         * f-valprint.c: Use C++ exception handling.
790         * exec.c: Use C++ exception handling.
791         * event-top.c: Use C++ exception handling.
792         * event-loop.c: Use C++ exception handling.
793         * eval.c: Use C++ exception handling.
794         * dwarf2read.c: Use C++ exception handling.
795         * dwarf2loc.c: Use C++ exception handling.
796         * dwarf2-frame.c: Use C++ exception handling.
797         * dwarf2-frame-tailcall.c: Use C++ exception handling.
798         * dwarf-index-write.c: Use C++ exception handling.
799         * dwarf-index-cache.c: Use C++ exception handling.
800         * dtrace-probe.c: Use C++ exception handling.
801         * disasm-selftests.c: Use C++ exception handling.
802         * darwin-nat.c: Use C++ exception handling.
803         * cp-valprint.c: Use C++ exception handling.
804         * cp-support.c: Use C++ exception handling.
805         * cp-abi.c: Use C++ exception handling.
806         * corelow.c: Use C++ exception handling.
807         * completer.c: Use C++ exception handling.
808         * compile/compile-object-run.c: Use C++ exception handling.
809         * compile/compile-object-load.c: Use C++ exception handling.
810         * compile/compile-cplus-symbols.c: Use C++ exception handling.
811         * compile/compile-c-symbols.c: Use C++ exception handling.
812         * common/selftest.c: Use C++ exception handling.
813         * common/new-op.c: Use C++ exception handling.
814         * cli/cli-script.c: Use C++ exception handling.
815         * cli/cli-interp.c: Use C++ exception handling.
816         * cli/cli-cmds.c: Use C++ exception handling.
817         * c-varobj.c: Use C++ exception handling.
818         * btrace.c: Use C++ exception handling.
819         * breakpoint.c: Use C++ exception handling.
820         * break-catch-throw.c: Use C++ exception handling.
821         * arch-utils.c: Use C++ exception handling.
822         * amd64-tdep.c: Use C++ exception handling.
823         * ada-valprint.c: Use C++ exception handling.
824         * ada-typeprint.c: Use C++ exception handling.
825         * ada-lang.c: Use C++ exception handling.
826         * aarch64-tdep.c: Use C++ exception handling.
827
828 2019-04-08  Tom Tromey  <tom@tromey.com>
829
830         * xml-support.c (gdb_xml_parser::parse): Update.
831         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
832         * value.c (show_convenience): Update.
833         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
834         (test_parse_flags_qcs): Update.
835         * thread.c (thr_try_catch_cmd): Update.
836         * target.c (target_translate_tls_address): Update.
837         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
838         (info_frame_command_core, frame_apply_command_count): Update.
839         * rust-exp.y (rust_lex_exception_test): Update.
840         * riscv-tdep.c (riscv_print_one_register_info): Update.
841         * remote.c (remote_target::enable_btrace): Update.
842         * record-btrace.c (record_btrace_enable_warn): Update.
843         * python/py-utils.c (gdbpy_convert_exception): Update.
844         * printcmd.c (do_one_display, print_variable_and_value): Update.
845         * mi/mi-main.c (mi_print_exception): Update.
846         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
847         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
848         * linux-nat.c (linux_nat_target::attach): Update.
849         * linux-fork.c (class scoped_switch_fork_info): Update.
850         * infrun.c (displaced_step_prepare): Update.
851         * infcall.c (call_function_by_hand_dummy): Update.
852         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
853         * gnu-v3-abi.c (print_one_vtable): Update.
854         * frame.c (get_prev_frame_always): Update.
855         * f-valprint.c (info_common_command_for_block): Update.
856         * exec.c (try_open_exec_file): Update.
857         * exceptions.c (print_exception, exception_print)
858         (exception_fprintf, exception_print_same): Update.
859         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
860         * dwarf-index-cache.c (index_cache::store)
861         (index_cache::lookup_gdb_index): Update.
862         * darwin-nat.c (maybe_cache_shell): Update.
863         * cp-valprint.c (cp_print_value_fields): Update.
864         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
865         (gcc_cplus_symbol_address): Update.
866         * compile/compile-c-symbols.c (gcc_convert_symbol)
867         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
868         * common/selftest.c: Update.
869         * common/common-exceptions.h (struct gdb_exception) <message>: Now
870         a std::string.
871         (exception_try_scope_entry, exception_try_scope_exit): Don't
872         declare.
873         (struct exception_try_scope): Remove.
874         (TRY): Don't use exception_try_scope.
875         (struct gdb_exception): Add constructor, operator=.
876         <what>: New method.
877         (struct gdb_exception_RETURN_MASK_ALL)
878         (struct gdb_exception_RETURN_MASK_ERROR)
879         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
880         (struct gdb_quit_bad_alloc): Update.
881         * common/common-exceptions.c (exception_none): Change
882         initializer.
883         (struct catcher) <state, exception>: Initialize inline.
884         <prev>: Remove member.
885         (current_catcher): Remove.
886         (catchers): New global.
887         (exceptions_state_mc_init): Simplify.
888         (catcher_pop): Remove.
889         (exceptions_state_mc, exceptions_state_mc_catch): Update.
890         (try_scope_depth, exception_try_scope_entry)
891         (exception_try_scope_exit): Remove.
892         (throw_exception_sjlj): Update.
893         (exception_messages, exception_messages_size): Remove.
894         (throw_it): Simplify.
895         (gdb_exception_sliced_copy): Remove.
896         (throw_exception_cxx): Update.
897         * cli/cli-script.c (script_from_file): Update.
898         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
899         Update.
900         * ada-valprint.c (ada_val_print): Update.
901         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
902         (create_excep_cond_exprs): Update.
903
904 2019-04-08  Tom Tromey  <tom@tromey.com>
905
906         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
907         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
908         (TRY, CATCH, END_CATCH): Remove some definitions.
909         * common/common-exceptions.c: Don't use GDB_XCPT.
910         (catcher_list_size): Remove.
911         (throw_exception, throw_it): Simplify.
912
913 2019-04-05  Tom Tromey  <tom@tromey.com>
914
915         Revert the header-sorting patch.
916         * ft32-tdep.c: Revert.
917         * frv-tdep.c: Revert.
918         * frv-linux-tdep.c: Revert.
919         * frame.c: Revert.
920         * frame-unwind.c: Revert.
921         * frame-base.c: Revert.
922         * fork-child.c: Revert.
923         * findvar.c: Revert.
924         * findcmd.c: Revert.
925         * filesystem.c: Revert.
926         * filename-seen-cache.h: Revert.
927         * filename-seen-cache.c: Revert.
928         * fbsd-tdep.c: Revert.
929         * fbsd-nat.h: Revert.
930         * fbsd-nat.c: Revert.
931         * f-valprint.c: Revert.
932         * f-typeprint.c: Revert.
933         * f-lang.c: Revert.
934         * extension.h: Revert.
935         * extension.c: Revert.
936         * extension-priv.h: Revert.
937         * expprint.c: Revert.
938         * exec.h: Revert.
939         * exec.c: Revert.
940         * exceptions.c: Revert.
941         * event-top.c: Revert.
942         * event-loop.c: Revert.
943         * eval.c: Revert.
944         * elfread.c: Revert.
945         * dwarf2read.h: Revert.
946         * dwarf2read.c: Revert.
947         * dwarf2loc.c: Revert.
948         * dwarf2expr.h: Revert.
949         * dwarf2expr.c: Revert.
950         * dwarf2-frame.c: Revert.
951         * dwarf2-frame-tailcall.c: Revert.
952         * dwarf-index-write.h: Revert.
953         * dwarf-index-write.c: Revert.
954         * dwarf-index-common.c: Revert.
955         * dwarf-index-cache.h: Revert.
956         * dwarf-index-cache.c: Revert.
957         * dummy-frame.c: Revert.
958         * dtrace-probe.c: Revert.
959         * disasm.h: Revert.
960         * disasm.c: Revert.
961         * disasm-selftests.c: Revert.
962         * dictionary.c: Revert.
963         * dicos-tdep.c: Revert.
964         * demangle.c: Revert.
965         * dcache.h: Revert.
966         * dcache.c: Revert.
967         * darwin-nat.h: Revert.
968         * darwin-nat.c: Revert.
969         * darwin-nat-info.c: Revert.
970         * d-valprint.c: Revert.
971         * d-namespace.c: Revert.
972         * d-lang.c: Revert.
973         * ctf.c: Revert.
974         * csky-tdep.c: Revert.
975         * csky-linux-tdep.c: Revert.
976         * cris-tdep.c: Revert.
977         * cris-linux-tdep.c: Revert.
978         * cp-valprint.c: Revert.
979         * cp-support.c: Revert.
980         * cp-namespace.c: Revert.
981         * cp-abi.c: Revert.
982         * corelow.c: Revert.
983         * corefile.c: Revert.
984         * continuations.c: Revert.
985         * completer.h: Revert.
986         * completer.c: Revert.
987         * complaints.c: Revert.
988         * coffread.c: Revert.
989         * coff-pe-read.c: Revert.
990         * cli-out.h: Revert.
991         * cli-out.c: Revert.
992         * charset.c: Revert.
993         * c-varobj.c: Revert.
994         * c-valprint.c: Revert.
995         * c-typeprint.c: Revert.
996         * c-lang.c: Revert.
997         * buildsym.c: Revert.
998         * buildsym-legacy.c: Revert.
999         * build-id.h: Revert.
1000         * build-id.c: Revert.
1001         * btrace.c: Revert.
1002         * bsd-uthread.c: Revert.
1003         * breakpoint.h: Revert.
1004         * breakpoint.c: Revert.
1005         * break-catch-throw.c: Revert.
1006         * break-catch-syscall.c: Revert.
1007         * break-catch-sig.c: Revert.
1008         * blockframe.c: Revert.
1009         * block.c: Revert.
1010         * bfin-tdep.c: Revert.
1011         * bfin-linux-tdep.c: Revert.
1012         * bfd-target.c: Revert.
1013         * bcache.c: Revert.
1014         * ax-general.c: Revert.
1015         * ax-gdb.h: Revert.
1016         * ax-gdb.c: Revert.
1017         * avr-tdep.c: Revert.
1018         * auxv.c: Revert.
1019         * auto-load.c: Revert.
1020         * arm-wince-tdep.c: Revert.
1021         * arm-tdep.c: Revert.
1022         * arm-symbian-tdep.c: Revert.
1023         * arm-pikeos-tdep.c: Revert.
1024         * arm-obsd-tdep.c: Revert.
1025         * arm-nbsd-tdep.c: Revert.
1026         * arm-nbsd-nat.c: Revert.
1027         * arm-linux-tdep.c: Revert.
1028         * arm-linux-nat.c: Revert.
1029         * arm-fbsd-tdep.c: Revert.
1030         * arm-fbsd-nat.c: Revert.
1031         * arm-bsd-tdep.c: Revert.
1032         * arch-utils.c: Revert.
1033         * arc-tdep.c: Revert.
1034         * arc-newlib-tdep.c: Revert.
1035         * annotate.h: Revert.
1036         * annotate.c: Revert.
1037         * amd64-windows-tdep.c: Revert.
1038         * amd64-windows-nat.c: Revert.
1039         * amd64-tdep.c: Revert.
1040         * amd64-sol2-tdep.c: Revert.
1041         * amd64-obsd-tdep.c: Revert.
1042         * amd64-obsd-nat.c: Revert.
1043         * amd64-nbsd-tdep.c: Revert.
1044         * amd64-nbsd-nat.c: Revert.
1045         * amd64-nat.c: Revert.
1046         * amd64-linux-tdep.c: Revert.
1047         * amd64-linux-nat.c: Revert.
1048         * amd64-fbsd-tdep.c: Revert.
1049         * amd64-fbsd-nat.c: Revert.
1050         * amd64-dicos-tdep.c: Revert.
1051         * amd64-darwin-tdep.c: Revert.
1052         * amd64-bsd-nat.c: Revert.
1053         * alpha-tdep.c: Revert.
1054         * alpha-obsd-tdep.c: Revert.
1055         * alpha-nbsd-tdep.c: Revert.
1056         * alpha-mdebug-tdep.c: Revert.
1057         * alpha-linux-tdep.c: Revert.
1058         * alpha-linux-nat.c: Revert.
1059         * alpha-bsd-tdep.c: Revert.
1060         * alpha-bsd-nat.c: Revert.
1061         * aix-thread.c: Revert.
1062         * agent.c: Revert.
1063         * addrmap.c: Revert.
1064         * ada-varobj.c: Revert.
1065         * ada-valprint.c: Revert.
1066         * ada-typeprint.c: Revert.
1067         * ada-tasks.c: Revert.
1068         * ada-lang.c: Revert.
1069         * aarch64-tdep.c: Revert.
1070         * aarch64-ravenscar-thread.c: Revert.
1071         * aarch64-newlib-tdep.c: Revert.
1072         * aarch64-linux-tdep.c: Revert.
1073         * aarch64-linux-nat.c: Revert.
1074         * aarch64-fbsd-tdep.c: Revert.
1075         * aarch64-fbsd-nat.c: Revert.
1076         * aarch32-linux-nat.c: Revert.
1077
1078 2019-04-05  Tom Tromey  <tom@tromey.com>
1079
1080         * ft32-tdep.c: Sort headers.
1081         * frv-tdep.c: Sort headers.
1082         * frv-linux-tdep.c: Sort headers.
1083         * frame.c: Sort headers.
1084         * frame-unwind.c: Sort headers.
1085         * frame-base.c: Sort headers.
1086         * fork-child.c: Sort headers.
1087         * findvar.c: Sort headers.
1088         * findcmd.c: Sort headers.
1089         * filesystem.c: Sort headers.
1090         * filename-seen-cache.h: Sort headers.
1091         * filename-seen-cache.c: Sort headers.
1092         * fbsd-tdep.c: Sort headers.
1093         * fbsd-nat.h: Sort headers.
1094         * fbsd-nat.c: Sort headers.
1095         * f-valprint.c: Sort headers.
1096         * f-typeprint.c: Sort headers.
1097         * f-lang.c: Sort headers.
1098         * extension.h: Sort headers.
1099         * extension.c: Sort headers.
1100         * extension-priv.h: Sort headers.
1101         * expprint.c: Sort headers.
1102         * exec.h: Sort headers.
1103         * exec.c: Sort headers.
1104         * exceptions.c: Sort headers.
1105         * event-top.c: Sort headers.
1106         * event-loop.c: Sort headers.
1107         * eval.c: Sort headers.
1108         * elfread.c: Sort headers.
1109         * dwarf2read.h: Sort headers.
1110         * dwarf2read.c: Sort headers.
1111         * dwarf2loc.c: Sort headers.
1112         * dwarf2expr.h: Sort headers.
1113         * dwarf2expr.c: Sort headers.
1114         * dwarf2-frame.c: Sort headers.
1115         * dwarf2-frame-tailcall.c: Sort headers.
1116         * dwarf-index-write.h: Sort headers.
1117         * dwarf-index-write.c: Sort headers.
1118         * dwarf-index-common.c: Sort headers.
1119         * dwarf-index-cache.h: Sort headers.
1120         * dwarf-index-cache.c: Sort headers.
1121         * dummy-frame.c: Sort headers.
1122         * dtrace-probe.c: Sort headers.
1123         * disasm.h: Sort headers.
1124         * disasm.c: Sort headers.
1125         * disasm-selftests.c: Sort headers.
1126         * dictionary.c: Sort headers.
1127         * dicos-tdep.c: Sort headers.
1128         * demangle.c: Sort headers.
1129         * dcache.h: Sort headers.
1130         * dcache.c: Sort headers.
1131         * darwin-nat.h: Sort headers.
1132         * darwin-nat.c: Sort headers.
1133         * darwin-nat-info.c: Sort headers.
1134         * d-valprint.c: Sort headers.
1135         * d-namespace.c: Sort headers.
1136         * d-lang.c: Sort headers.
1137         * ctf.c: Sort headers.
1138         * csky-tdep.c: Sort headers.
1139         * csky-linux-tdep.c: Sort headers.
1140         * cris-tdep.c: Sort headers.
1141         * cris-linux-tdep.c: Sort headers.
1142         * cp-valprint.c: Sort headers.
1143         * cp-support.c: Sort headers.
1144         * cp-namespace.c: Sort headers.
1145         * cp-abi.c: Sort headers.
1146         * corelow.c: Sort headers.
1147         * corefile.c: Sort headers.
1148         * continuations.c: Sort headers.
1149         * completer.h: Sort headers.
1150         * completer.c: Sort headers.
1151         * complaints.c: Sort headers.
1152         * coffread.c: Sort headers.
1153         * coff-pe-read.c: Sort headers.
1154         * cli-out.h: Sort headers.
1155         * cli-out.c: Sort headers.
1156         * charset.c: Sort headers.
1157         * c-varobj.c: Sort headers.
1158         * c-valprint.c: Sort headers.
1159         * c-typeprint.c: Sort headers.
1160         * c-lang.c: Sort headers.
1161         * buildsym.c: Sort headers.
1162         * buildsym-legacy.c: Sort headers.
1163         * build-id.h: Sort headers.
1164         * build-id.c: Sort headers.
1165         * btrace.c: Sort headers.
1166         * bsd-uthread.c: Sort headers.
1167         * breakpoint.h: Sort headers.
1168         * breakpoint.c: Sort headers.
1169         * break-catch-throw.c: Sort headers.
1170         * break-catch-syscall.c: Sort headers.
1171         * break-catch-sig.c: Sort headers.
1172         * blockframe.c: Sort headers.
1173         * block.c: Sort headers.
1174         * bfin-tdep.c: Sort headers.
1175         * bfin-linux-tdep.c: Sort headers.
1176         * bfd-target.c: Sort headers.
1177         * bcache.c: Sort headers.
1178         * ax-general.c: Sort headers.
1179         * ax-gdb.h: Sort headers.
1180         * ax-gdb.c: Sort headers.
1181         * avr-tdep.c: Sort headers.
1182         * auxv.c: Sort headers.
1183         * auto-load.c: Sort headers.
1184         * arm-wince-tdep.c: Sort headers.
1185         * arm-tdep.c: Sort headers.
1186         * arm-symbian-tdep.c: Sort headers.
1187         * arm-pikeos-tdep.c: Sort headers.
1188         * arm-obsd-tdep.c: Sort headers.
1189         * arm-nbsd-tdep.c: Sort headers.
1190         * arm-nbsd-nat.c: Sort headers.
1191         * arm-linux-tdep.c: Sort headers.
1192         * arm-linux-nat.c: Sort headers.
1193         * arm-fbsd-tdep.c: Sort headers.
1194         * arm-fbsd-nat.c: Sort headers.
1195         * arm-bsd-tdep.c: Sort headers.
1196         * arch-utils.c: Sort headers.
1197         * arc-tdep.c: Sort headers.
1198         * arc-newlib-tdep.c: Sort headers.
1199         * annotate.h: Sort headers.
1200         * annotate.c: Sort headers.
1201         * amd64-windows-tdep.c: Sort headers.
1202         * amd64-windows-nat.c: Sort headers.
1203         * amd64-tdep.c: Sort headers.
1204         * amd64-sol2-tdep.c: Sort headers.
1205         * amd64-obsd-tdep.c: Sort headers.
1206         * amd64-obsd-nat.c: Sort headers.
1207         * amd64-nbsd-tdep.c: Sort headers.
1208         * amd64-nbsd-nat.c: Sort headers.
1209         * amd64-nat.c: Sort headers.
1210         * amd64-linux-tdep.c: Sort headers.
1211         * amd64-linux-nat.c: Sort headers.
1212         * amd64-fbsd-tdep.c: Sort headers.
1213         * amd64-fbsd-nat.c: Sort headers.
1214         * amd64-dicos-tdep.c: Sort headers.
1215         * amd64-darwin-tdep.c: Sort headers.
1216         * amd64-bsd-nat.c: Sort headers.
1217         * alpha-tdep.c: Sort headers.
1218         * alpha-obsd-tdep.c: Sort headers.
1219         * alpha-nbsd-tdep.c: Sort headers.
1220         * alpha-mdebug-tdep.c: Sort headers.
1221         * alpha-linux-tdep.c: Sort headers.
1222         * alpha-linux-nat.c: Sort headers.
1223         * alpha-bsd-tdep.c: Sort headers.
1224         * alpha-bsd-nat.c: Sort headers.
1225         * aix-thread.c: Sort headers.
1226         * agent.c: Sort headers.
1227         * addrmap.c: Sort headers.
1228         * ada-varobj.c: Sort headers.
1229         * ada-valprint.c: Sort headers.
1230         * ada-typeprint.c: Sort headers.
1231         * ada-tasks.c: Sort headers.
1232         * ada-lang.c: Sort headers.
1233         * aarch64-tdep.c: Sort headers.
1234         * aarch64-ravenscar-thread.c: Sort headers.
1235         * aarch64-newlib-tdep.c: Sort headers.
1236         * aarch64-linux-tdep.c: Sort headers.
1237         * aarch64-linux-nat.c: Sort headers.
1238         * aarch64-fbsd-tdep.c: Sort headers.
1239         * aarch64-fbsd-nat.c: Sort headers.
1240         * aarch32-linux-nat.c: Sort headers.
1241
1242 2019-04-04  Tom Tromey  <tom@tromey.com>
1243
1244         * varobj.c (varobj_create): Update.
1245         * rust-exp.y (struct rust_parser) <update_innermost_block,
1246         lookup_symbol>: New methods.
1247         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1248         Rename.
1249         (rust_parser::rust_lookup_type)
1250         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1251         * printcmd.c (display_command, do_one_display): Update.
1252         * parser-defs.h (struct parser_state) <parser_state>: Add
1253         "tracker" parameter.
1254         (block_tracker): New member.
1255         (class innermost_block_tracker) <innermost_block_tracker>: Add
1256         "types" parameter.
1257         <reset>: Remove method.
1258         (innermost_block): Don't declare.
1259         (null_post_parser): Update.
1260         * parse.c (innermost_block): Remove global.
1261         (write_dollar_variable): Update.
1262         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1263         Remove "tracker_types" parameter.
1264         (parse_expression): Add "tracker" parameter.
1265         (parse_expression_for_completion): Update.
1266         (null_post_parser): Add "tracker" parameter.
1267         * p-exp.y: Update rules.
1268         * m2-exp.y: Update rules.
1269         * language.h (struct language_defn) <la_post_parser>: Add
1270         "tracker" parameter.
1271         * go-exp.y: Update rules.
1272         * f-exp.y: Update rules.
1273         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1274         parameter.
1275         * d-exp.y: Update rules.
1276         * c-exp.y: Update rules.
1277         * breakpoint.c (set_breakpoint_condition): Create an
1278         innermost_block_tracker.
1279         (watch_command_1): Likewise.
1280         * ada-lang.c (resolve): Add "tracker" parameter.
1281         (resolve_subexp): Likewise.
1282         * ada-exp.y (write_var_from_sym): Update.
1283
1284 2019-04-04  Tom Tromey  <tom@tromey.com>
1285
1286         * type-stack.h: New file.
1287         * type-stack.c: New file.
1288         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1289         type-stack.h.
1290         (insert_into_type_stack, insert_type, push_type, push_type_int)
1291         (insert_type_address_space, pop_type, pop_type_int)
1292         (pop_typelist, pop_type_stack, append_type_stack)
1293         (push_type_stack, get_type_stack, push_typelist)
1294         (follow_type_instance_flags, follow_types): Don't declare.
1295         * parse.c (type_stack): Remove global.
1296         (parse_exp_in_context): Update.
1297         (insert_into_type_stack, insert_type, push_type, push_type_int)
1298         (insert_type_address_space, pop_type, pop_type_int)
1299         (pop_typelist, pop_type_stack, append_type_stack)
1300         (push_type_stack, get_type_stack, push_typelist)
1301         (follow_type_instance_flags, follow_types): Remove (moved to
1302         type-stack.c).
1303         * f-exp.y (type_stack): New global.
1304         Update rules.
1305         (push_kind_type, f_parse): Update.
1306         * d-exp.y (type_stack): New global.
1307         Update rules.
1308         (d_parse): Update.
1309         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1310         Update rules.
1311         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1312         (HFILES_NO_SRCDIR): Add type-stack.h.
1313
1314 2019-04-04  Tom Tromey  <tom@tromey.com>
1315
1316         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1317         (rust_parser::convert_ast_to_expression, rust_parse)
1318         (rust_lex_test_completion, rust_lex_tests): Update.
1319         * parser-defs.h (struct expr_completion_state): New.
1320         (struct parser_state) <parser_state>: Add completion parameter.
1321         <mark_struct_expression, mark_completion_tag>: New methods.
1322         <parse_completion, m_completion_state>: New members.
1323         (prefixify_expression, null_post_parser): Update.
1324         (mark_struct_expression, mark_completion_tag): Don't declare.
1325         * parse.c (parse_completion, expout_last_struct)
1326         (expout_tag_completion_type, expout_completion_name): Remove
1327         globals.
1328         (parser_state::mark_struct_expression)
1329         (parser_state::mark_completion_tag): Now methods.
1330         (prefixify_expression): Add last_struct parameter.
1331         (prefixify_subexp): Likewise.
1332         (parse_exp_1): Update.
1333         (parse_exp_in_context): Add cstate parameter.  Update.
1334         (parse_expression_for_completion): Create an
1335         expr_completion_state.
1336         (null_post_parser): Add "completion" parameter.
1337         * p-exp.y: Update rules.
1338         (yylex): Update.
1339         * language.h (struct language_defn) <la_post_parser>: Add
1340         "completing" parameter.
1341         * go-exp.y: Update rules.
1342         (lex_one_token): Update.
1343         * expression.h (parse_completion): Don't declare.
1344         * d-exp.y: Update rules.
1345         (lex_one_token): Update rules.
1346         * c-exp.y: Update rules.
1347         (lex_one_token): Update.
1348         * ada-lang.c (resolve): Add "parse_completion" parameter.
1349         (resolve_subexp): Likewise.
1350         (ada_resolve_function): Likewise.
1351
1352 2019-04-04  Tom Tromey  <tom@tromey.com>
1353
1354         * parser-defs.h (struct parser_state) <start_arglist,
1355         end_arglist>: New methods.
1356         <arglist_len, m_funcall_chain>: New members.
1357         (arglist_len, start_arglist, end_arglist): Don't declare.
1358         * parse.c (arglist_len, funcall_chain): Remove global.
1359         (start_arglist, end_arglist): Remove functions.
1360         (parse_exp_in_context): Update.
1361         * p-exp.y: Update rules.
1362         * m2-exp.y: Update rules.
1363         * go-exp.y: Update rules.
1364         * f-exp.y: Update rules.
1365         * d-exp.y: Update rules.
1366         * c-exp.y: Update rules.
1367
1368 2019-04-04  Tom Tromey  <tom@tromey.com>
1369
1370         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1371         lex_operator, push_back>: New methods.
1372         Update all rules.
1373         (rust_parser::lex_hex, lex_escape): Rename and update.
1374         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1375         (rust_parser::lex_operator): Rename and update.
1376         (rust_parser::lex_number, rustyylex, rustyyerror)
1377         (rust_lex_test_init, rust_lex_test_sequence)
1378         (rust_lex_test_push_back, rust_lex_tests): Update.
1379         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1380         parameter.
1381         <lexptr, prev_lexptr>: New members.
1382         (lexptr, prev_lexptr): Don't declare.
1383         * parse.c (lexptr, prev_lexptr): Remove globals.
1384         (parse_exp_in_context): Update.
1385         * p-exp.y (yylex, yyerror): Update.
1386         * m2-exp.y (parse_number, yylex, yyerror): Update.
1387         * go-exp.y (lex_one_token, yyerror): Update.
1388         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1389         * d-exp.y (lex_one_token, yyerror): Update.
1390         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1391         (lex_one_token, yyerror): Update.
1392         * ada-lex.l (YY_INPUT): Update.
1393         (rewind_to_char): Update.
1394         * ada-exp.y (yyerror): Update.
1395
1396 2019-04-04  Tom Tromey  <tom@tromey.com>
1397
1398         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1399         * parser-defs.h (struct parser_state) <parser_state>: Add new
1400         parameter.
1401         <comma_terminates>: New member.
1402         (comma_terminates): Don't declare global.
1403         * parse.c (comma_terminates): Remove global.
1404         (parse_exp_in_context): Update.
1405         * p-exp.y (yylex): Update.
1406         * m2-exp.y (yylex): Update.
1407         * go-exp.y (lex_one_token): Update.
1408         * f-exp.y (yylex): Update.
1409         * d-exp.y (lex_one_token): Update.
1410         * c-exp.y (lex_one_token): Update.
1411         * ada-lex.l: Update.
1412
1413 2019-04-04  Tom Tromey  <tom@tromey.com>
1414
1415         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1416         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1417         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1418         * parser-defs.h (paren_depth): Don't declare.
1419         * parse.c (paren_depth): Remove global.
1420         (parse_exp_in_context): Update.
1421         * p-exp.y (paren_depth): New global.
1422         (pascal_parse): Initialize it.
1423         * m2-exp.y (paren_depth): New global.
1424         (m2_parse): Initialize it.
1425         * go-exp.y (paren_depth): New global.
1426         (go_parse): Initialize it.
1427         * f-exp.y (paren_depth): New global.
1428         (f_parse): Initialize it.
1429         * d-exp.y (paren_depth): New global.
1430         (d_parse): Initialize it.
1431         * c-exp.y (paren_depth): New global.
1432         (c_parse): Initialize it.
1433         * ada-lex.l (paren_depth): New global.
1434         (lexer_init): Initialize it.
1435
1436 2019-04-04  Tom Tromey  <tom@tromey.com>
1437
1438         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1439         (rust_parser::convert_ast_to_type)
1440         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1441         * parser-defs.h (struct parser_state) <parser_state>: Add
1442         parameters.  Initialize new members.
1443         <expression_context_block, expression_context_pc>: New members.
1444         * parse.c (expression_context_block, expression_context_pc):
1445         Remove globals.
1446         (parse_exp_in_context): Update.
1447         * p-exp.y: Update all rules.
1448         (yylex): Update.
1449         * m2-exp.y: Update all rules.
1450         (yylex): Update.
1451         * go-exp.y (yylex): Update.
1452         * f-exp.y (yylex): Update.
1453         * d-exp.y: Update all rules.
1454         (yylex): Update.
1455         * c-exp.y: Update all rules.
1456         (lex_one_token, classify_name, yylex, c_parse): Update.
1457         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1458
1459 2019-04-04  Tom Tromey  <tom@tromey.com>
1460
1461         * gdbarch.h, gdbarch.c: Rebuild.
1462         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1463         * stap-probe.h: 
1464         (struct stap_parse_info): Replace "parser_state" with
1465         "expr_builder".
1466         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1467         (parser_state): New class.
1468         * parse.c (expr_builder): Rename.
1469         (expr_builder::release): Rename.
1470         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1471         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1472         (write_exp_elt_longcst, write_exp_elt_floatcst)
1473         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1474         (write_exp_string_vector, write_exp_bitstring)
1475         (write_exp_msymbol, mark_struct_expression)
1476         (write_dollar_variable)
1477         (insert_type_address_space, increase_expout_size): Replace
1478         "parser_state" with "expr_builder".
1479         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1480         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1481         "parser_state" with "expr_builder".
1482
1483 2019-04-04  Tom Tromey  <tom@tromey.com>
1484
1485         * rust-exp.y: Replace "parse_language" with method call.
1486         * p-exp.y: 
1487         (yylex): Replace "parse_language" with method call.
1488         * m2-exp.y: 
1489         (yylex): Replace "parse_language" with method call.
1490         * go-exp.y (classify_name): Replace "parse_language" with method
1491         call.
1492         * f-exp.y (yylex): Replace "parse_language" with method call.
1493         * d-exp.y (lex_one_token): Replace "parse_language" with method
1494         call.
1495         * c-exp.y: 
1496         (lex_one_token, classify_name, yylex): Replace "parse_language"
1497         with method call.
1498         * ada-exp.y (find_primitive_type, type_char)
1499         (type_system_address): Replace "parse_language" with method call.
1500
1501 2019-04-04  Tom Tromey  <tom@tromey.com>
1502
1503         * rust-exp.y: Replace "parse_gdbarch" with method call.
1504         * parse.c (write_dollar_variable, insert_type_address_space):
1505         Replace "parse_gdbarch" with method call.
1506         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1507         call.
1508         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1509         call.
1510         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1511         "parse_gdbarch" with method call.
1512         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1513         with method call.
1514         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1515         "parse_gdbarch" with method call.
1516         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1517         "parse_gdbarch" with method call.
1518         * c-exp.y (parse_type, parse_number, classify_name): Replace
1519         "parse_gdbarch" with method call.
1520         * ada-lex.l: Replace "parse_gdbarch" with method call.
1521         * ada-exp.y (parse_type, find_primitive_type, type_char)
1522         (type_system_address): Replace "parse_gdbarch" with method call.
1523
1524 2019-04-04  Tom Tromey  <tom@tromey.com>
1525
1526         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1527         * stap-probe.c (stap_parse_argument): Update.
1528         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1529         initial_size parameter.
1530         * rust-exp.y (rust_lex_tests): Update.
1531         * parse.c (parser_state): Update.
1532         (parse_exp_in_context): Update.
1533         * parser-defs.h (struct parser_state) <parser_state>: Remove
1534         "initial_size" parameter.
1535
1536 2019-04-04  Tom Tromey  <tom@tromey.com>
1537
1538         * parser-defs.h (increase_expout_size): Don't declare.
1539         * parse.c (increase_expout_size): Now static.
1540
1541 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1542
1543         * gnu-nat.c (gnu_nat_target::wait): Fix
1544         target_waitstatus_to_string call.
1545
1546 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1547
1548         * eval.c (evaluate_subexp_standard): Handle internal functions
1549         during Fortran function call handling.
1550
1551 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1552
1553         * NEWS: Mention new internal functions.
1554         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1555         (read_base_type): Use dwarf2_init_complex_target_type.
1556         * value.c (creal_internal_fn): New function.
1557         (cimag_internal_fn): New function.
1558         (_initialize_values): Register new internal functions.
1559
1560 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1561
1562         * infrun.c (stop_all_threads): If debug_infrun, always
1563         trace the wait status after wait_one, using
1564         target_waitstatus_to_string and target_pid_to_str.
1565         (handle_inferior_event): Replace various trace of
1566         wait status kind by a single trace.
1567         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1568         wait status kind image by target_waitstatus_to_string.
1569         * target/waitstatus.c (target_waitstatus_to_string): Fix
1570         obsolete comment.
1571
1572 2019-04-01  Tom Tromey  <tromey@adacore.com>
1573
1574         PR symtab/23331:
1575         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1576
1577 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1578             Pedro Alves  <palves@redhat.com>
1579
1580         * top.c (quit_force): Call 'finalize_values'.
1581         * value.c (finalize_values): New function.
1582         * value.h (finalize_values): Declare.
1583
1584 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1585
1586         * NEWS: Announce $_gdb_major and $_gdb_minor.
1587
1588         * top.c (init_gdb_version_vars): New function.
1589         (gdb_init): Call init_gdb_version_vars.
1590
1591 2019-03-29  Tom Tromey  <tromey@adacore.com>
1592
1593         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1594         help text.  Remove dead code.
1595
1596 2019-03-29  Keith Seitz  <keiths@redhat.com>
1597
1598         From Siddhesh Poyarekar:
1599         * f-lang.h (f77_get_upperbound): Return LONGEST.
1600         (f77_get_lowerbound): Likewise.
1601         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1602         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1603         print them.
1604         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1605         plongest to format print it.
1606         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1607         (f77_get_upperbound): Likewise.
1608         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1609         LOWER_BOUND to LONGEST.
1610         (f77_create_arrayprint_offset_tbl): Likewise.
1611
1612 2019-03-29  Keith Seitz  <keiths@redhat.com>
1613
1614         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1615         %s/pulongest for TYPE_LENGTH instead of %d in format
1616         strings.
1617         * ada-typerint.c (ada_print_type): Likewise.
1618         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1619         * compile/compile-c-support.c (generate_register_struct): Likewise.
1620         * gdbtypes.c (recursive_dump_type): Likewise.
1621         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1622         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1623         instead of %d in format strings.
1624         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1625         to std::min to ULONGEST.
1626         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1627         instead of %d in format strings.
1628         * tracepoint.c (info_scope_command): Likewise.
1629         * typeprint.c (print_offset_data::update)
1630         (print_offset_data::finish): Likewise.
1631         * xtensa-tdep.c (xtensa_store_return_value)
1632         (xtensa_push_dummy_call): Likewise.
1633
1634 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1635
1636         * windows-nat.c (display_selector): Fixed format specifications
1637         for 64-bit Cygwin.
1638
1639 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1640
1641         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1642
1643 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1644
1645         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1646         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1647         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1648         (nios2_linux_init_abi): Install it.
1649
1650 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1651
1652         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1653
1654 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1655
1656         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1657
1658 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1659             Tom Tromey  <tromey@adacore.com>
1660
1661         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1662
1663 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1664
1665         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1666         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1667         method to compute the bounds of range types. Also print "[evaluated]"
1668         if the bounds' values come from a dynamic evaluation.
1669
1670 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1671
1672         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1673         whitespace when pretty printing is on.
1674
1675 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1676
1677         * ppc-linux-nat.c: Add include.
1678
1679 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1680
1681         * NEWS: Mention AArch64 Pointer Authentication.
1682
1683 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1684
1685         * arm-linux-nat.c: Add include.
1686
1687 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1688
1689         * source-cache.c (source_cache::get_source_lines): Re-read
1690         fullname after calling open_source_file.
1691
1692 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1693
1694         * NEWS: Mention TLS support for FreeBSD.
1695
1696 2019-03-25  Tom Tromey  <tromey@adacore.com>
1697
1698         * minsyms.c (BUNCH_SIZE): Update comment.
1699         (~minimal_symbol_reader): Remove old comment.
1700         (compact_minimal_symbols): Update comment.
1701         (minimal_symbol_reader::install): Remove old comment.  Update
1702         other comments.
1703
1704 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1705
1706         * s390-linux-nat.c: Add include.
1707
1708 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1709
1710         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1711         Call linux_get_hwcap.
1712         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1713         Likewise.
1714         (aarch64_linux_get_hwcap): Remove function.
1715         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1716         declaration.
1717         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1718         linux_get_hwcap.
1719         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1720         * linux-tdep.c (linux_get_hwcap): Add function.
1721         (linux_get_hwcap2): Likewise.
1722         * linux-tdep.h (linux_get_hwcap): Add declaration.
1723         (linux_get_hwcap2): Likewise.
1724         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1725         (ppc_linux_get_hwcap2): Likewise.
1726         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1727         linux_get_hwcap.
1728         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1729         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1730         (ppc_linux_nat_target::read_description): Likewise.
1731         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1732         * s390-linux-nat.c: Likewise.
1733         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1734
1735 2019-03-24  Tom Tromey  <tom@tromey.com>
1736
1737         * ada-lang.c (standard_lookup): Simplify initialization.
1738         (ada_lookup_symbol_nonlocal): Simplify return.
1739         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1740         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1741         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1742         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1743         initialization.
1744         * solib.c (solib_global_lookup): Simplify.
1745         * symtab.c (null_block_symbol): Remove.
1746         (symbol_cache_lookup): Simplify returns.
1747         (lookup_language_this): Simplify returns.
1748         (lookup_symbol_aux): Simplify return.
1749         (lookup_local_symbol): Simplify returns.
1750         (lookup_global_symbol_from_objfile): Simplify return.
1751         (lookup_symbol_in_objfile_symtabs)
1752         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1753         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1754         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1755         * cp-namespace.c (cp_lookup_bare_symbol)
1756         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1757         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1758         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1759         (cp_lookup_symbol_via_imports): Simplify initialization.
1760         (find_symbol_in_baseclass): Likewise.
1761         * symtab.h (null_block_symbol): Remove.
1762         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1763         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1764         (d_lookup_symbol_module): Likewise.
1765         (find_symbol_in_baseclass): Simplify initialization.
1766
1767 2019-03-24  Tom Tromey  <tom@tromey.com>
1768
1769         * expression.h: Don't include symtab.h.
1770         (struct block): Forward declare.
1771
1772 2019-03-24  Tom Tromey  <tom@tromey.com>
1773
1774         * c-exp.y (typebase): Remove casts.
1775         * gdbtypes.c (lookup_unsigned_typename, )
1776         (lookup_signed_typename): Remove cast.
1777         * eval.c (parse_to_comma_and_eval): Remove cast.
1778         * parse.c (write_dollar_variable): Remove cast.
1779         * block.h (struct block) <superblock>: Now const.
1780         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1781         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1782         (map_block): Make "block" const.
1783         * symfile.h (struct quick_symbol_functions)
1784         <map_matching_symbols>: Constify block argument to "callback".
1785         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1786         const.
1787         (find_pc_sect_compunit_symtab): Make "b" const.
1788         (find_symbol_at_address): Likewise.
1789         (search_symbols): Likewise.
1790         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1791         (dw2_debug_names_lookup_symbol): Likewise.
1792         (dw2_map_matching_symbols): Update.
1793         * p-valprint.c (pascal_val_print): Remove "block".
1794         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1795         (aux_add_nonlocal_symbols): Make "block" const.
1796         (resolve_subexp): Remove cast.
1797         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1798         const.
1799         (iterate_over_file_blocks): Likewise.
1800         * f-exp.y (%union) <bval>: Remove.
1801         * coffread.c (patch_opaque_types): Make "b" const.
1802         * spu-tdep.c (spu_catch_start): Make "block" const.
1803         * c-valprint.c (print_unpacked_pointer): Remove "block".
1804         * symmisc.c (dump_symtab_1): Make "b" const.
1805         (block_depth): Make "block" const.
1806         * d-exp.y (%union) <bval>: Remove.
1807         * cp-support.h (cp_lookup_rtti_type): Update.
1808         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1809         * psymtab.c (psym_lookup_symbol): Make "block" const.
1810         (maintenance_check_psymtabs): Make "b" const.
1811         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1812         (enumerate_locals, enumerate_args): Update.
1813         * python/py-symtab.c (stpy_global_block): Make "block" const.
1814         (stpy_static_block): Likewise.
1815         * inline-frame.c (block_starting_point_at): Make "new_block"
1816         const.
1817         * block.c (find_block_in_blockvector): Make return type const.
1818         (blockvector_for_pc_sect): Make "b" const.
1819         (find_block_in_blockvector): Make "b" const.
1820
1821 2019-03-23  Tom Tromey  <tom@tromey.com>
1822
1823         * varobj.c (varobj_create): Update.
1824         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1825         * printcmd.c (display_command, do_one_display): Don't reset
1826         innermost_block.
1827         * parser-defs.h (enum innermost_block_tracker_type): Move to
1828         expression.h.
1829         (innermost_block): Update comment.
1830         * parse.c (parse_exp_1): Add tracker_types parameter.
1831         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1832         tracker_types parameter.  Reset innermost_block.
1833         (parse_exp_in_context): Remove.
1834         (parse_expression_for_completion): Update.
1835         * objfiles.c (~objfile): Don't reset expression_context_block or
1836         innermost_block.
1837         * expression.h (enum innermost_block_tracker_type): Move from
1838         parser-defs.h.
1839         (parse_exp_1): Add tracker_types parameter.
1840         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1841         reset innermost_block.
1842
1843 2019-03-23  Tom Tromey  <tom@tromey.com>
1844
1845         * objfiles.h: Include bcache.h.
1846
1847 2019-03-23  Tom Tromey  <tom@tromey.com>
1848
1849         * linespec.c (get_current_search_block): Use
1850         scoped_restore_current_language.
1851         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1852
1853 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1854             Jiong Wang  <jiong.wang@arm.com>
1855
1856         * aarch64-linux-tdep.c
1857         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1858         section.
1859         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1860
1861 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1862             Jiong Wang  <jiong.wang@arm.com>
1863
1864         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1865         instructions.
1866         (aarch64_analyze_prologue_test): Add PACIASP test.
1867         (aarch64_prologue_prev_register): Unmask PC value.
1868
1869 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1870             Jiong Wang  <jiong.wang@arm.com>
1871
1872         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1873         (aarch64_dwarf2_prev_register): Unmask PC value.
1874         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1875         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1876         DW_CFA_AARCH64_negate_ra_state.
1877         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1878
1879 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1880             Jiong Wang  <jiong.wang@arm.com>
1881
1882         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1883         registers.
1884         (aarch64_pseudo_register_name): Likewise.
1885         (aarch64_pseudo_register_type): Likewise.
1886         (aarch64_pseudo_register_reggroup_p): Likewise.
1887         (aarch64_gdbarch_init): Add pauth registers.
1888         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1889         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1890         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1891         (struct gdbarch_tdep): Add regnum for ra_state.
1892
1893 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1894             Jiong Wang  <jiong.wang@arm.com>
1895
1896         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1897
1898 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1899             Jiong Wang  <jiong.wang@arm.com>
1900
1901         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1902         function.
1903         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1904         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1905         (aarch64_gdbarch_init): Add puth registers.
1906         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1907         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1908         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1909
1910 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1911             Jiong Wang  <jiong.wang@arm.com>
1912
1913         * aarch64-linux-nat.c
1914         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1915         * aarch64-linux-tdep.c
1916         (aarch64_linux_core_read_description): Likewise.
1917         (aarch64_linux_get_hwcap): New function.
1918         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1919         (aarch64_linux_get_hwcap): New declaration.
1920
1921 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1922             Jiong Wang  <jiong.wang@arm.com>
1923
1924         * aarch64-linux-nat.c
1925         (aarch64_linux_nat_target::read_description): Add pauth param.
1926         * aarch64-linux-tdep.c
1927         (aarch64_linux_core_read_description): Likewise.
1928         * aarch64-tdep.c (struct target_desc): Add in pauth.
1929         (aarch64_read_description): Add pauth param.
1930         (aarch64_gdbarch_init): Likewise.
1931         * aarch64-tdep.h (aarch64_read_description): Likewise.
1932         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1933         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1934         * features/Makefile: Add new files.
1935         * features/aarch64-pauth.c: New file.
1936         * features/aarch64-pauth.xml: New file.
1937
1938 2019-03-20  Tom Tromey  <tromey@adacore.com>
1939
1940         * infrun.c (handle_inferior_event): Rename from
1941         handle_inferior_event_1.  Create a scoped_value_mark.
1942         (handle_inferior_event): Remove.
1943
1944 2019-03-19  Tom Tromey  <tromey@adacore.com>
1945
1946         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1947         * infrun.h (print_stop_event): Add "displays" parameter.
1948         * infrun.c (print_stop_event): Add "displays" parameter.
1949
1950 2019-03-19  Pedro Alves  <palves@redhat.com>
1951
1952         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1953         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1954         to -1.  Fix TABs vs spaces.
1955         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1956         * tui/tui-out.h (tui_ui_out) Add intro comments.
1957         <m_line, m_start_of_line>: In-class initialize, and add describing
1958         comment.
1959
1960 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1961
1962         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1963         variable names.
1964         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1965
1966 2019-03-18  Pedro Alves  <palves@redhat.com>
1967             Eli Zaretskii <eliz@gnu.org>
1968
1969         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1970         m_line and m_start_of_line.
1971
1972 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1973
1974         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1975         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1976         it returns a newline.  This fixes a regression in TU mode, whereby
1977         the next line is output on the same screen line as the user input.
1978
1979 2019-03-18  Tom Tromey  <tromey@adacore.com>
1980
1981         * minsyms.c (minimal_symbol_reader::install): Remove call to
1982         obstack_blank.
1983
1984 2019-03-18  Pedro Alves  <palves@redhat.com>
1985
1986         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1987         New globals.
1988         (apply_style): New, factored out from ...
1989         (apply_ansi_escape): ... this.  Handle reverse video mode.
1990         (tui_set_reverse_mode): New function.
1991         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1992         * tui/tui-winsource.c (tui_show_source_line): Use
1993         tui_set_reverse_mode instead of setting A_STANDOUT.
1994         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1995         New setter methods.
1996
1997 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1998
1999         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2000         Handle tabs.
2001
2002 2019-03-18  Tom Tromey  <tromey@adacore.com>
2003
2004         * ada-lang.c (empty_array): Add "high" parameter.
2005         (ada_evaluate_subexp): Update.
2006
2007 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2008
2009         * unittests/string_view-selftests.c: Define
2010         _initialize_string_view_selftests unconditionally.
2011
2012 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2013
2014         PR gdb/24350
2015         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2016
2017 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2018
2019         PR gdb/24351
2020         * windows-nat.c (display_selector): Fix format specifiers.
2021
2022 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2023
2024         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2025         tui_refill_source_window instead of tui_refresh_win, to update the
2026         current execution line.  This fixes redisplay of the current line
2027         when stepping through the code with "next" or "step".
2028
2029 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2030
2031         * source-cache.c (source_cache::get_source_lines): Call
2032         find_source_lines to initialize s->nlines.  This fixes vertical
2033         scrolling of TUI source window when the DOWN arrow is pressed.
2034
2035 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2036
2037         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2038         linux-thread-db.c (_initialize_thread_db): Likewise.
2039
2040 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2041
2042         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2043         wclrtoeol in tui_show_source_line".  This reverts changes made in
2044         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2045
2046 2019-03-15  Tom Tromey  <tom@tromey.com>
2047
2048         * symtab.h (struct minimal_symbol): Derive from
2049         general_symbol_info.
2050         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2051         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2052         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2053         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2054         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2055         (MSYMBOL_SEARCH_NAME): Update.
2056         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2057         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2058         * minsyms.c (minimal_symbol_reader::record_full): Update.
2059
2060 2019-03-15  Tom Tromey  <tom@tromey.com>
2061
2062         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2063
2064 2019-03-15  Tom Tromey  <tom@tromey.com>
2065
2066         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2067         unique_xmalloc_ptr.
2068         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2069         Update.
2070         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2071         (build_minimal_symbol_hash_tables)
2072         (minimal_symbol_reader::install): Update.
2073
2074 2019-03-15  Tom Tromey  <tom@tromey.com>
2075
2076         * symtab.c (create_demangled_names_hash): Update.
2077         (symbol_set_names): Update.
2078         * objfiles.h (struct objfile_per_bfd_storage)
2079         <demangled_names_hash>: Now an htab_up.
2080         * objfiles.c (objfile_per_bfd_storage): Simplify.
2081
2082 2019-03-15  Tom Tromey  <tom@tromey.com>
2083
2084         * objfiles.h (struct objfile_per_bfd_storage): Declare
2085         destructor.
2086         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2087         New.
2088         (get_objfile_bfd_data): Use new.  Don't initialize
2089         language_of_main.
2090         (free_objfile_per_bfd_storage): Remove.
2091         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2092
2093 2019-03-15  Tom Tromey  <tom@tromey.com>
2094
2095         * symfile.c (reread_symbols): Update.
2096         * objfiles.c (objfile::objfile): Update.
2097         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2098         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2099         comment.
2100         (minimal_symbol_reader::install): Update.
2101         (terminate_minimal_symbol_table): Remove.
2102         * jit.c (jit_object_close_impl): Update.
2103
2104 2019-03-15  Tom Tromey  <tom@tromey.com>
2105
2106         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2107         initializations.
2108
2109 2019-03-15  Tom Tromey  <tom@tromey.com>
2110
2111         * objfiles.h (struct objfile_per_bfd_storage)
2112         <demangled_hash_languages>: Now a bitset.
2113         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2114         (lookup_minimal_symbol): Update.
2115
2116 2019-03-15  Tom Tromey  <tom@tromey.com>
2117
2118         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2119         Don't return the symbol.
2120         * coffread.c (record_minimal_symbol): Use record_full.
2121
2122 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2123
2124         The MS-Windows port of ncurses fails to switch to a color pair if
2125         one or both of the colors are the implicit default colors.  This
2126         change records the default colors when TUI is initialized, and
2127         then specifies them explicitly when a color pair uses the default
2128         colors.  This allows color styling in TUI mode on MS-Windows.
2129
2130         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2131         ncurses_norm_attr.
2132         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2133         colors in ncurses_norm_attr.
2134         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2135         "none", replace it with the default color recorded in
2136         ncurses_norm_attr.
2137
2138 2019-03-14  Tom Tromey  <tromey@adacore.com>
2139
2140         * source-cache.h (class source_cache) <get_source_lines>: Return
2141         std::string.
2142         * source-cache.c (source_cache::extract_lines): Handle case where
2143         first_pos==npos.  Return std::string.
2144         (source_cache::get_source_lines): Update.
2145
2146 2019-03-14  Tom Tromey  <tromey@adacore.com>
2147
2148         * NEWS: Add item for "style sources" commands.
2149         * source-cache.c (source_cache::get_source_lines): Check
2150         source_styling.
2151         * cli/cli-style.c (source_styling): New global.
2152         (_initialize_cli_style): Add "style sources" commands.
2153         (show_style_sources): New function.
2154         * cli/cli-style.h (source_styling): Declare.
2155
2156 2019-03-14  Pedro Alves  <palves@redhat.com>
2157             Tom Tromey  <tromey@adacore.com>
2158
2159         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2160         * tui/tui-winsource.c (tui_refill_source_window): New function,
2161         from...
2162         (tui_horizontal_source_scroll): ... here.  Move some logic.
2163         * cli/cli-style.c (set_style_enabled): Notify new observable.
2164         * tui/tui-hooks.c (tui_redisplay_source): New function.
2165         (tui_attach_detach_observers): Attach or detach
2166         tui_redisplay_source.
2167         * observable.h (source_styling_changed): New observable.
2168         * observable.c: Define source_styling_changed observable.
2169
2170 2019-03-13  Tom Tromey  <tromey@adacore.com>
2171
2172         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2173         (i386_gnu_nat_target::store_registers): Update.
2174         * target-debug.h (target_debug_print_std_string): New macro.
2175         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2176         * windows-tdep.c (display_one_tib): Update.
2177         * tui/tui-stack.c (tui_make_status_line): Update.
2178         * top.c (print_inferior_quit_action): Update.
2179         * thread.c (thr_try_catch_cmd): Update.
2180         (add_thread_with_info): Update.
2181         (thread_target_id_str): Update.
2182         (thr_try_catch_cmd): Update.
2183         (thread_command): Update.
2184         (thread_find_command): Update.
2185         * record-btrace.c (record_btrace_target::info_record)
2186         (record_btrace_resume_thread, record_btrace_target::resume)
2187         (record_btrace_cancel_resume, record_btrace_step_thread)
2188         (record_btrace_target::wait, record_btrace_target::wait)
2189         (record_btrace_target::wait, record_btrace_target::stop): Update.
2190         * progspace.c (print_program_space): Update.
2191         * process-stratum-target.c
2192         (process_stratum_target::thread_address_space): Update.
2193         * linux-fork.c (linux_fork_mourn_inferior)
2194         (detach_checkpoint_command, info_checkpoints_command)
2195         (linux_fork_context): Update.
2196         (linux_fork_detach): Update.
2197         (class scoped_switch_fork_info): Update.
2198         (delete_checkpoint_command): Update.
2199         * infrun.c (follow_fork_inferior): Update.
2200         (follow_fork_inferior): Update.
2201         (proceed_after_vfork_done): Update.
2202         (handle_vfork_child_exec_or_exit): Update.
2203         (follow_exec): Update.
2204         (displaced_step_prepare_throw): Update.
2205         (displaced_step_restore): Update.
2206         (start_step_over): Update.
2207         (resume_1): Update.
2208         (clear_proceed_status_thread): Update.
2209         (proceed): Update.
2210         (print_target_wait_results): Update.
2211         (do_target_wait): Update.
2212         (context_switch): Update.
2213         (stop_all_threads): Update.
2214         (restart_threads): Update.
2215         (finish_step_over): Update.
2216         (handle_signal_stop): Update.
2217         (switch_back_to_stepped_thread): Update.
2218         (keep_going_pass_signal): Update.
2219         (print_exited_reason): Update.
2220         (normal_stop): Update.
2221         * inferior.c (inferior_pid_to_str): Change return type.
2222         (print_selected_inferior): Update.
2223         (add_inferior): Update.
2224         (detach_inferior): Update.
2225         * dummy-frame.c (fprint_dummy_frames): Update.
2226         * dcache.c (dcache_info_1): Update.
2227         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2228         (btrace_fetch, btrace_clear): Update.
2229         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2230         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2231         type.
2232         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2233         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2234         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2235         * gdbarch.c, gdbarch.h: Rebuild.
2236         * gdbarch.sh (core_pid_to_str): Change return type.
2237         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2238         return type.
2239         (windows_nat_target::pid_to_str): Change return type.
2240         (windows_delete_thread): Update.
2241         (windows_nat_target::attach): Update.
2242         (windows_nat_target::files_info): Update.
2243         * target-delegates.c: Rebuild.
2244         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2245         return type.
2246         (sol_thread_target::pid_to_str): Change return type.
2247         * remote.c (class remote_target) <pid_to_str>: Change return
2248         type.
2249         (remote_target::pid_to_str): Change return type.
2250         (extended_remote_target::attach, remote_target::remote_stop_ns)
2251         (remote_target::remote_notif_remove_queued_reply)
2252         (remote_target::push_stop_reply, remote_target::disable_btrace):
2253         Update.
2254         (extended_remote_target::attach): Update.
2255         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2256         type.
2257         (gdbsim_target::pid_to_str): Change return type.
2258         * ravenscar-thread.c (struct ravenscar_thread_target)
2259         <pid_to_str>: Change return type.
2260         (ravenscar_thread_target::pid_to_str): Change return type.
2261         * procfs.c (class procfs_target) <pid_to_str>: Change return
2262         type.
2263         (procfs_target::pid_to_str): Change return type.
2264         (procfs_target::attach): Update.
2265         (procfs_target::detach): Update.
2266         (procfs_target::fetch_registers): Update.
2267         (procfs_target::store_registers): Update.
2268         (procfs_target::wait): Update.
2269         (procfs_target::files_info): Update.
2270         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2271         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2272         return type.
2273         (nto_procfs_target::pid_to_str): Change return type.
2274         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2275         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2276         return type.
2277         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2278         (exit_lwp): Update.
2279         (attach_proc_task_lwp_callback, get_detach_signal)
2280         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2281         (linux_nat_target::resume, wait_lwp, stop_callback)
2282         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2283         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2284         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2285         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2286         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2287         type.
2288         (inf_ptrace_target::attach): Update.
2289         (inf_ptrace_target::files_info): Update.
2290         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2291         type.
2292         (go32_nat_target::pid_to_str): Change return type.
2293         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2294         (gnu_nat_target::wait): Update.
2295         (gnu_nat_target::wait): Update.
2296         (gnu_nat_target::resume): Update.
2297         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2298         (fbsd_nat_target::wait): Update.
2299         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2300         type.
2301         (darwin_nat_target::attach): Update.
2302         * corelow.c (class core_target) <pid_to_str>: Change return type.
2303         (core_target::pid_to_str): Change return type.
2304         * target.c (normal_pid_to_str): Change return type.
2305         (default_pid_to_str): Likewise.
2306         (target_pid_to_str): Change return type.
2307         (target_translate_tls_address): Update.
2308         (target_announce_detach): Update.
2309         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2310         return type.
2311         (bsd_uthread_target::pid_to_str): Change return type.
2312         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2313         type.
2314         (bsd_kvm_target::pid_to_str): Change return type.
2315         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2316         return type.
2317         (aix_thread_target::pid_to_str): Change return type.
2318         * target.h (struct target_ops) <pid_to_str>: Change return type.
2319         (target_pid_to_str, normal_pid_to_str): Likewise.
2320         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2321         type.
2322         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2323         type.
2324         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2325         return type.
2326         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2327         type.
2328         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2329         type.
2330         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2331         return type.
2332
2333 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2334
2335         * NEWS: Mention that the new default MI version is 3.  Mention
2336         changes to the output of commands and events that deal with
2337         multi-location breakpoints.
2338         * breakpoint.c: Include "mi/mi-out.h".
2339         (print_one_breakpoint): Change output syntax if using MI version
2340         >= 3.
2341         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2342         New.
2343         (mi_multi_location_breakpoint_output_fixed): New.
2344         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2345         (mi_cmd_fix_multi_location_breakpoint_output): New.
2346         (mi_multi_location_breakpoint_output_fixed): New.
2347         * mi/mi-cmds.c (mi_cmds): Register command
2348         -fix-multi-location-breakpoint-output.
2349         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2350         interpreter "mi".
2351
2352 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2353
2354         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2355         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2356         instantiate mi_ui_out based on interpreter name.
2357         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2358         * mi/mi-main.c (mi_load_progress): Likewise.
2359
2360 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2361
2362         * NEWS: Combine separate "New targets" sections for 8.3.
2363
2364 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2365
2366         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2367         (ppcfbsd_init_abi): Install gdbarch
2368         "fetch_tls_load_module_address" and "get_thread_local_address"
2369         methods.
2370
2371 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2372
2373         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2374         (riscv_fbsd_init_abi): Install gdbarch
2375         "fetch_tls_load_module_address" and "get_thread_local_address"
2376         methods.
2377
2378 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2379
2380         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2381         (i386fbsd_init_abi): Install gdbarch
2382         "fetch_tls_load_module_address" and "get_thread_local_address"
2383         methods.
2384
2385 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2386
2387         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2388         (amd64fbsd_init_abi): Install gdbarch
2389         "fetch_tls_load_module_address" and "get_thread_local_address"
2390         methods.
2391
2392 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2393
2394         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2395         (struct fbsd_pspace_data): New type.
2396         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2397         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2398         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2399         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2400         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2401
2402 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2403
2404         * gdbtypes.c (lookup_struct_elt): New function.
2405         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2406         * gdbtypes.h (struct struct_elt): New type.
2407         (lookup_struct_elt): New prototype.
2408
2409 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2410
2411         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2412         remove disabled code block.
2413
2414 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2415
2416         * gdbarch.sh (get_thread_local_address): New method.
2417         * gdbarch.h, gdbarch.c: Regenerate.
2418         * target.c (target_translate_tls_address): Use
2419         gdbarch_get_thread_local_address if present instead of
2420         target::get_thread_local_address.
2421
2422 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2423
2424         * target.h (target::get_thread_local_address): Update comment.
2425
2426 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2427
2428         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2429         objfile->separate_debug_objfile_backlink if not NULL.
2430
2431 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2432
2433         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2434         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2435         (amd64bsd_store_inferior_registers): Likewise.
2436         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2437         Enable segment base registers.
2438         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2439         PT_GETFSBASE and PT_GETGSBASE.
2440         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2441         PT_SETGSBASE.
2442         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2443         segment base registers.
2444         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2445
2446 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2447
2448         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2449         Update calls to i386_target_description to add 'segments'
2450         parameter.
2451         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2452         add segment base registers.
2453         * arch/i386.c (i386_create_target_description): Add 'segments'
2454         parameter to enable segment base registers.
2455         * arch/i386.h (i386_create_target_description): Likewise.
2456         * features/i386/32bit-segments.xml: New file.
2457         * features/i386/32bit-segments.c: Generate.
2458         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2459         call to i386_target_description to add 'segments' parameter.
2460         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2461         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2462         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2463         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2464         if feature is present.
2465         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2466         Add 'segments' parameter to call to i386_target_description.
2467         (i386_target_description): Add 'segments' parameter to enable
2468         segment base registers.
2469         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2470         to call to i386_target_description.
2471         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2472         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2473         Define I386_NUM_REGS.
2474         (i386_target_description): Add 'segments' parameter to enable
2475         segment base registers.
2476
2477 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2478
2479         PR/24325
2480         * source-cache.c: #undef open and close, to avoid unresolved
2481         externals during linking.
2482
2483 2019-03-12  Tom Tromey  <tromey@adacore.com>
2484
2485         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2486         const.  Add initializers.
2487         (_initialize_remote): Don't initialize ptid globals.
2488
2489 2019-03-12  Pedro Alves  <palves@redhat.com>
2490
2491         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2492
2493 2019-03-12  Pedro Alves  <palves@redhat.com>
2494
2495         * cp-name-parser.y (main): Remove unused 'len' variable.
2496
2497 2019-03-12  Tom Tromey  <tromey@adacore.com>
2498
2499         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2500         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2501
2502 2019-03-12  Tom Tromey  <tromey@adacore.com>
2503
2504         * linux-nat.c (iterate_over_lwps): Update.
2505         (stop_callback): Remove parameter.
2506         (stop_wait_callback, detach_callback, resume_set_callback)
2507         (select_singlestep_lwp_callback, set_ignore_sigint)
2508         (status_callback, resumed_callback, resume_clear_callback)
2509         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2510         data parameter.
2511         (linux_nat_target::detach, linux_nat_target::resume)
2512         (linux_stop_and_wait_all_lwps, select_event_lwp)
2513         (linux_nat_filter_event, linux_nat_wait_1)
2514         (linux_nat_target::kill, linux_nat_target::stop)
2515         (linux_nat_target::stop): Update.
2516         (linux_nat_resume_callback): Change type.
2517         (resume_stopped_resumed_lwps, count_events_callback)
2518         (select_event_lwp_callback): Likewise.
2519         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2520         * arm-linux-nat.c (struct update_registers_data): Remove.
2521         (update_registers_callback): Change type.
2522         (arm_linux_insert_hw_breakpoint1): Update.
2523         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2524         parameter.
2525         (x86_linux_dr_set_addr): Update.
2526         (x86_linux_dr_set_control): Update.
2527         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2528         (iterate_over_lwps): Use gdb::function_view.
2529         * nat/aarch64-linux-hw-point.c (struct
2530         aarch64_dr_update_callback_param): Remove.
2531         (debug_reg_change_callback): Change type.
2532         (aarch64_notify_debug_reg_change): Update.
2533         * s390-linux-nat.c (s390_refresh_per_info): Update.
2534
2535 2019-03-11  Tom Tromey  <tromey@adacore.com>
2536
2537         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2538         redundant assignment to "this_cu".
2539
2540 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2541
2542         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2543
2544 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2545
2546         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2547         from...
2548         (rank_one_type): ... this.
2549
2550 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2551
2552         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2553         from...
2554         (rank_one_type): ... this.
2555
2556 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2557
2558         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2559         from...
2560         (rank_one_type): ... this.
2561
2562 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2563
2564         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2565         from...
2566         (rank_one_type): ... this.
2567
2568 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2569
2570         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2571         from...
2572         (rank_one_type): ... this.
2573
2574 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2575
2576         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2577         from...
2578         (rank_one_type): ... this.
2579
2580 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2581
2582         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2583         from...
2584         (rank_one_type): ... this.
2585
2586 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2587
2588         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2589         from...
2590         (rank_one_type): ... this.
2591
2592 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2593
2594         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2595         from...
2596         (rank_one_type): ... this.
2597
2598 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2599
2600         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2601         from...
2602         (rank_one_type): ... this.
2603
2604 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2605
2606         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2607         from...
2608         (rank_one_type): ... this.
2609
2610 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2611
2612         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2613         from...
2614         (rank_one_type): ... this.
2615
2616 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2617
2618         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2619         inferior-events' shows the example events.
2620
2621 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2622
2623         Support styling on native MS-Windows console
2624
2625         PR/24315
2626         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2627         on MS-Windows if $TERM is not defined.
2628
2629         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2630
2631         * posix-hdep.c (gdb_console_fputs):
2632         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2633         functions.
2634         * ui-file.h (gdb_console_fputs): Add prototype.
2635
2636         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2637         back to fputs only if the former returns zero.
2638
2639 2019-03-07  Tom Tromey  <tom@tromey.com>
2640
2641         * symmisc.c (print_symbol_bcache_statistics): Update.
2642         (print_objfile_statistics): Update.
2643         * symfile.c (allocate_symtab): Update.
2644         * stabsread.c: Don't include bcache.h.
2645         * psymtab.h (struct psymbol_bcache): Don't declare.
2646         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2647         (psymbol_bcache_init, psymbol_bcache_free)
2648         (psymbol_bcache_get_bcache): Don't declare.
2649         * psymtab.c (struct psymbol_bcache): Remove.
2650         (psymtab_storage::psymtab_storage): Update.
2651         (psymtab_storage::~psymtab_storage): Update.
2652         (psymbol_bcache_init, psymbol_bcache_free)
2653         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2654         (add_psymbol_to_bcache): Update.
2655         (allocate_psymtab): Update.
2656         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2657         macro_cache>: No longer pointers.
2658         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2659         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2660         * macrotab.c (macro_bcache): Update.
2661         * macroexp.c: Don't include bcache.h.
2662         * gdbtypes.c (check_types_worklist): Update.
2663         (types_deeply_equal): Remove TRY/CATCH.  Update.
2664         * elfread.c (elf_symtab_read): Update.
2665         * dwarf2read.c: Don't include bcache.h.
2666         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2667         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2668         (print_bcache_statistics, bcache_memory_used): Don't declare.
2669         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2670         methods.  Rename all data members.
2671         * bcache.c (struct bcache): Move to bcache.h.
2672         (bcache::expand_hash_table): Rename from expand_hash_table.
2673         (bcache): Remove.
2674         (bcache::insert): Rename from bcache_full.
2675         (bcache::compare): Rename from bcache_compare.
2676         (bcache_xmalloc): Remove.
2677         (bcache::~bcache): Rename from bcache_xfree.
2678         (bcache::print_statistics): Rename from print_bcache_statistics.
2679         (bcache::memory_used): Rename from bcache_memory_used.
2680
2681 2019-03-07  Pedro Alves  <palves@redhat.com>
2682
2683         * infrun.c (normal_stop): Also check for
2684         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2685
2686 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2687
2688         * f-lang.c (value_from_host_double): Moved to...
2689         * value.c (value_from_host_double): ...here.
2690         * value.h (value_from_host_double): Declare.
2691         * guile/scm-math.c (vlscm_convert_typed_number): Use
2692         value_from_host_double.
2693         (vlscm_convert_number): Likewise.
2694         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2695         * python/py-value.c (convert_value_from_python): Likewise.
2696
2697 2019-03-06  Tom Tromey  <tom@tromey.com>
2698
2699         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2700
2701 2019-03-06  Tom Tromey  <tom@tromey.com>
2702
2703         * utils.h (free_current_contents): Don't declare.
2704         * utils.c (free_current_contents): Remove.
2705
2706 2019-03-06  Tom Tromey  <tom@tromey.com>
2707
2708         * top.c (quit_force): Update.
2709         * main.c (captured_command_loop): Update.
2710         * common/new-op.c (operator new): Update.
2711         * common/common-exceptions.c (struct catcher)
2712         <save_cleanup_chain>: Remove member.
2713         (exceptions_state_mc_init): Update.
2714         (exception_try_scope_entry): Return nullptr.
2715         (exception_try_scope_exit, exception_rethrow)
2716         (throw_exception_sjlj, throw_exception_cxx): Update.
2717         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2718         (all_cleanups, do_cleanups, discard_cleanups)
2719         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2720         (restore_cleanups, restore_final_cleanups): Don't declare.
2721         (do_final_cleanups): Remove parameter.
2722         * common/cleanups.c (cleanup_chain, make_cleanup)
2723         (make_cleanup_dtor, all_cleanups, do_cleanups)
2724         (discard_my_cleanups, discard_cleanups)
2725         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2726         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2727         (null_cleanup): Remove.
2728         (do_final_cleanups): Remove parameter.
2729
2730 2019-03-06  Tom Tromey  <tom@tromey.com>
2731
2732         * remote.c (remote_target::remote_parse_stop_reply): Use
2733         unique_xmalloc_ptr.
2734
2735 2019-03-06  Tom Tromey  <tom@tromey.com>
2736
2737         * stabsread.c (struct stabs_field_info): Rename from field_info.
2738         <list, fnlist>: Add initializers.
2739         <obstack>: New member.
2740         (read_member_functions, read_struct_fields, read_baseclasses):
2741         Allocate on obstack.  Don't use cleanups.
2742         (read_one_struct_field, read_member_functions, read_struct_fields)
2743         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2744         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2745         (read_struct_type): Update.
2746
2747 2019-03-06  Tom Tromey  <tom@tromey.com>
2748
2749         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2750         * common/filestuff.h (make_cleanup_close): Don't declare.
2751         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2752         Remove.
2753
2754 2019-03-06  Tom Tromey  <tom@tromey.com>
2755
2756         * solib-aix.c: Use make_scope_exit.
2757
2758 2019-03-06  Tom Tromey  <tom@tromey.com>
2759
2760         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2761         Use make_scope_exit.
2762
2763 2019-03-06  Tom Tromey  <tom@tromey.com>
2764
2765         * solib-svr4.c (disable_probes_interface): Remove parameter.
2766         (svr4_handle_solib_event): Use make_scope_exit.
2767
2768 2019-03-06  Tom Tromey  <tom@tromey.com>
2769
2770         * remote.c (struct stop_reply_deleter): Remove.
2771         (stop_reply_up): Update.
2772         (struct stop_reply): Derive from notif_event.  Don't typedef.
2773         <regcache>: Now a std::vector.
2774         (stop_reply_xfree): Remove.
2775         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2776         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2777         (remote_target::discard_pending_stop_replies): Use delete.
2778         (remote_target::remote_parse_stop_reply): Update.
2779         (remote_target::process_stop_reply): Update.
2780         * remote-notif.h (struct notif_event): Add virtual destructor.
2781         Remove "dtr" member.
2782         (struct notif_client) <alloc_event>: Return a unique_ptr.
2783         (notif_event_xfree): Don't declare.
2784         (notif_event_up): New typedef.
2785         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2786         (notif_event_xfree, do_notif_event_xfree): Remove.
2787         (remote_notif_state_xfree): Update.
2788
2789 2019-03-06  Tom Tromey  <tom@tromey.com>
2790
2791         * infrun.c (displaced_step_clear_cleanup): Now a
2792         forward_scope_exit type.
2793         (displaced_step_prepare_throw): Update.
2794         (displaced_step_fixup): Update.
2795
2796 2019-03-06  Tom Tromey  <tom@tromey.com>
2797
2798         * inferior.h (class inferior): Update comment.
2799         * gdbthread.h (class thread_info): Update comment.
2800
2801 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2802             Tom Tromey  <tom@tromey.com>
2803
2804         * stabsread.h (struct stab_section_list): Remove.
2805         (coffstab_build_psymtabs): Update.
2806         * dbxread.c (symbuf_sections): Now a std::vector.
2807         (sect_idx): New global.
2808         (fill_symbuf): Update.
2809         (coffstab_build_psymtabs): Change type of stabsects parameter.
2810         Update.
2811         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2812         std::vector.
2813         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2814         (coff_locate_sections): Update.
2815         (coff_symfile_read): Remove cleanups.  Update.
2816         (init_stringtab): Add storage parameter.
2817         (free_stringtab, free_stringtab_cleanup): Remove.
2818         (init_lineno): Add storage parameter.
2819         (free_linetab, free_linetab_cleanup): Remove.
2820
2821 2019-03-06  Pedro Alves  <palves@redhat.com>
2822
2823         * linux-fork.c (fork_info::clobber_regs): Delete.
2824         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2825         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2826         comment.  Adjust.
2827         (scoped_switch_fork_info::scoped_switch_fork_info)
2828         (checkpoint_command, linux_fork_context): Adjust
2829         fork_save_infrun_state calls.
2830
2831 2019-03-06  Pedro Alves  <palves@redhat.com>
2832
2833         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2834         (inf_has_multiple_threads): Return 'bool' and rewrite using
2835         inferior_info::threads().
2836
2837 2019-03-06  Pedro Alves  <palves@redhat.com>
2838
2839         * linux-fork.c: Include <list>.
2840         (fork_list): Now a std::list instance.
2841         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2842         (forks_exist_p, find_last_fork): Adjust.
2843         (new_fork): Delete.
2844         (one_fork_p): New.
2845         (add_fork): Adjust.
2846         (free_fork): Delete, folded into fork_info::~fork_info().
2847         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2848         Adjust.
2849         (init_fork_list): Delete.
2850         (linux_fork_killall, linux_fork_mourn_inferior)
2851         (linux_fork_detach, info_checkpoints_command): Adjust.
2852         (_initialize_linux_fork): No longer call init_fork_list.
2853
2854 2019-03-06  Pedro Alves  <palves@redhat.com>
2855
2856         * linux-fork.c (new_fork): New, split out of ...
2857         (add_fork): ... this.  Return void.  Move "first fork" special
2858         case from here, to ...
2859         (checkpoint_command): ... here.
2860         * linux-linux.h (add_fork): Return void.
2861
2862 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2863
2864         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2865
2866 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2867             Chris January  <chris.january@arm.com>
2868             David Lecomber  <david.lecomber@arm.com>
2869
2870         * f-exp.y: New token, UNOP_INTRINSIC.
2871         (exp): New pattern using UNOP_INTRINSIC token.
2872         (f77_keywords): Add 'abs' keyword.
2873         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2874         (value_from_host_double): New function.
2875         (evaluate_subexp_f): Support UNOP_ABS.
2876
2877 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2878
2879         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2880         types.
2881
2882 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2883
2884         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2885         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2886         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2887
2888 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2889
2890         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2891
2892 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2893             Chris January  <chris.january@arm.com>
2894
2895         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2896         * f-exp.y: Define 'KIND' token.
2897         (exp): New pattern for KIND expressions.
2898         (ptype): Handle types with a kind extension.
2899         (direct_abs_decl): Extend to spot kind extensions.
2900         (f77_keywords): Add 'kind' to the list.
2901         (push_kind_type): New function.
2902         (convert_to_kind_type): New function.
2903         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2904         * parse.c (operator_length_standard): Likewise.
2905         * parser-defs.h (enum type_pieces): Add tp_kind.
2906         * std-operator.def: Add UNOP_KIND.
2907
2908 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2909
2910         * f-exp.y (f_parse): Set yydebug.
2911
2912 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2913
2914         * f-lang.c (evaluate_subexp_f): New function.
2915         (exp_descriptor_f): New global.
2916         (f_language_defn): Use exp_descriptor_f instead of
2917         exp_descriptor_standard.
2918
2919 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2920
2921         * f-exp.y (struct token): Add comments.
2922         (dot_ops): Remove uppercase versions and the end marker.
2923         (f77_keywords): Likewise.
2924         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2925         entries in the dot_ops array are case insensitive, and use
2926         strncasecmp to compare strings.  Also some whitespace cleanup in
2927         this area.  Similar for the f77_keywords array, except entries in
2928         this list might be case sensitive.
2929
2930 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2931
2932         * f-exp.y (struct f77_boolean_val): Add comments.
2933         (boolean_values): Remove uppercase versions, and end marker.
2934         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2935         and use strncasecmp to achieve case insensitivity.  Additionally,
2936         perform whitespace cleanup around this code.
2937
2938 2019-03-06  Tom Tromey  <tromey@adacore.com>
2939
2940         * remote-sim.c (gdbsim_target_open): Use result of
2941         gdb_argv::release.
2942
2943 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2944         Dirk Schubert  <dirk.schubert@arm.com>
2945         Chris January  <chris.january@arm.com>
2946
2947         * eval.c (evaluate_subexp_standard): Call Fortran argument
2948         wrapping logic.
2949         * f-lang.c (struct value): A value which can be passed into a
2950         Fortran function call.
2951         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2952         where appropriate.
2953         (struct type): Value ready for a Fortran function call.
2954         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2955         is needed.
2956         * f-lang.h (fortran_argument_convert): Declaration.
2957         (fortran_preserve_arg_pointer): Declaration.
2958         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2959
2960 2019-03-05  Tom Tromey  <tromey@adacore.com>
2961
2962         * python/py-prettyprint.c (print_string_repr): Remove #if.
2963         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2964
2965 2019-03-05  Tom Tromey  <tromey@adacore.com>
2966
2967         * target.c (the_dummy_target): Move later.  Change type to
2968         "dummy_target".
2969         (initialize_targets): Don't initialize the_dummy_target.
2970
2971 2019-03-05  Tom Tromey  <tromey@adacore.com>
2972
2973         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2974         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2975
2976 2019-03-05  Tom Tromey  <tromey@adacore.com>
2977
2978         * windows-nat.c (windows_nat_target::attach)
2979         (windows_nat_target::detach): Don't call gdb_flush.
2980         * valprint.c (generic_val_print, val_print, val_print_string):
2981         Don't call gdb_flush.
2982         * utils.c (defaulted_query): Don't call gdb_flush.
2983         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2984         * target.c (target_announce_detach): Don't call gdb_flush.
2985         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2986         * remote.c (extended_remote_target::attach): Don't call
2987         gdb_flush.
2988         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2989         * printcmd.c (do_examine): Don't call gdb_flush.
2990         (info_display_command): Don't call gdb_flush.
2991         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2992         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2993         * memattr.c (info_mem_command): Don't call gdb_flush.
2994         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2995         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2996         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2997         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2998         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2999         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3000         (gnu_nat_target::detach): Don't call gdb_flush.
3001         * f-valprint.c (f_val_print): Don't call gdb_flush.
3002         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3003         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3004         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3005         gdb_flush.
3006         * c-valprint.c (c_val_print): Don't call gdb_flush.
3007         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3008
3009 2019-03-05  Tom Tromey  <tromey@adacore.com>
3010
3011         * varobj.c (update_dynamic_varobj_children): Update.
3012         (install_default_visualizer): Use reset, not release.
3013         * value.c (set_internalvar): Update.
3014         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3015         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3016         ATTRIBUTE_UNUSED_RESULT.
3017
3018 2019-03-05  Tom Tromey  <tromey@adacore.com>
3019
3020         * remote.c (class scoped_remote_fd) <release>: Add
3021         ATTRIBUTE_UNUSED_RESULT.
3022
3023 2019-03-05  Tom Tromey  <tromey@adacore.com>
3024
3025         * macroexp.c (struct macro_buffer) <release>: Add
3026         ATTRIBUTE_UNUSED_RESULT.
3027
3028 2019-03-05  Tom Tromey  <tromey@adacore.com>
3029
3030         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3031         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3032         ATTRIBUTE_UNUSED_RESULT.
3033
3034 2019-03-05  Tom Tromey  <tromey@adacore.com>
3035
3036         * common/scoped_fd.h (class scoped_fd) <release>: Add
3037         ATTRIBUTE_UNUSED_RESULT.
3038
3039 2019-03-05  Tom Tromey  <tromey@adacore.com>
3040
3041         * parser-defs.h (struct parser_state) <release>: Add
3042         ATTRIBUTE_UNUSED_RESULT.
3043
3044 2019-03-05  Tom Tromey  <tromey@adacore.com>
3045
3046         * utils.h (class gdb_argv) <release>: Add
3047         ATTRIBUTE_UNUSED_RESULT.
3048         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3049
3050 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3051
3052         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3053         for-loop range, to avoid compiler warnings.
3054
3055         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3056         avoid compiler warnings about unused variables.
3057
3058         * NEWS: Mention end of support for native debugging on MS-Windows
3059         before XP.
3060
3061         PR gdb/24292
3062         * common/netstuff.c:
3063         * gdbserver/gdbreplay.c
3064         * gdbserver/remote-utils.c:
3065         * ser-tcp.c:
3066         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3067         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3068         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3069         'getaddrinfo' and 'freeaddrinfo' were not available before
3070         Windows XP, and mingw.org's MinGW headers by default define
3071         _WIN32_WINNT to 0x500.
3072
3073 2019-03-01  Gary Benson <gbenson@redhat.com>
3074
3075         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3076
3077 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3078             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3079
3080         PR gdb/8527
3081         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3082         set_sigint_trap, clear_sigint_trap.
3083
3084 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3085
3086         * target.c (target_detach): Clear the regcache and the
3087         frame cache.
3088
3089 2019-02-27  Pedro Alves  <palves@redhat.com>
3090
3091         * utils.c (set_screen_size): When we cap the height/width sizes,
3092         tweak the corresponding command variable to show "unlimited":
3093
3094 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3095             Pedro Alves  <palves@redhat.com>
3096
3097         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3098         before calling rl_set_screen_size.
3099
3100 2019-02-27  Tom Tromey  <tromey@adacore.com>
3101
3102         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3103         define.
3104         * python/py-value.c: Remove Python 2.4 workaround.
3105         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3106         workaround.
3107         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3108         Python 2.4 workaround.
3109         * python/python-internal.h: Remove Python 2.4 comment.
3110         (Py_ssize_t): Don't define.
3111         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3112         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3113         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3114         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3115         * python/python.c (do_start_initialization): Remove Python 2.4
3116         workaround.
3117         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3118         (print_children): Remove Python 2.4 workaround.
3119         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3120         workaround.
3121         (CHARBUFFERPROC_NAME): Remove.
3122         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3123         Python 2.4 workaround.
3124
3125 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3126
3127         * NEWS: Note minimum Python version.
3128
3129 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3130
3131         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3132         code from these functions.  Remove corresponding ifdefs.  Use
3133         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3134         Remove gotos and target of gotos.
3135         (infpy_search_memory): Likewise.
3136
3137 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3138
3139         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3140         (hppa_gdbarch_init): Don't register deleted functions with
3141         gdbarch.
3142
3143 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3144
3145         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3146         (h8300_unwind_sp): Delete.
3147         (h8300_dummy_id): Delete.
3148         (h8300_gdbarch_init): Don't register deleted functions with
3149         gdbarch.
3150
3151 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3152
3153         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3154         (ft32_unwind_pc): Delete.
3155         (ft32_unwind_sp): Delete.
3156         (ft32_gdbarch_init): Don't register deleted functions with
3157         gdbarch.
3158
3159 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3160
3161         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3162         (frv_unwind_pc): Delete.
3163         (frv_unwind_sp): Delete.
3164         (frv_gdbarch_init): Don't register deleted functions with
3165         gdbarch.
3166
3167 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3168
3169         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3170         (riscv_unwind_pc): Delete.
3171         (riscv_unwind_sp): Delete.
3172         (riscv_gdbarch_init): Don't register deleted functions with
3173         gdbarch.
3174
3175 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3176
3177         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3178         (csky_unwind_pc): Delete.
3179         (csky_unwind_sp): Delete.
3180         (csky_gdbarch_init): Don't register deleted functions with
3181         gdbarch.
3182
3183 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3184
3185         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3186         (cris_unwind_pc): Delete.
3187         (cris_unwind_sp): Delete.
3188         (cris_gdbarch_init): Don't register deleted functions with
3189         gdbarch.
3190
3191 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3192
3193         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3194         (bfin_unwind_pc): Delete.
3195         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3196
3197 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3198
3199         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3200         (arm_unwind_pc): Delete.
3201         (arm_unwind_sp): Delete.
3202         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3203
3204 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3205
3206         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3207         (arc_unwind_pc): Delete.
3208         (arc_unwind_sp): Delete.
3209         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3210
3211 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3212
3213         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3214         (alpha_unwind_pc): Delete.
3215         (alpha_gdbarch_init): Don't register deleted functions with
3216         gdbarch.
3217
3218 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3219
3220         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3221         (aarch64_unwind_pc): Delete.
3222         (aarch64_unwind_sp): Delete.
3223         (aarch64_gdbarch_init): Don't register deleted functions with
3224         gdbarch.
3225
3226 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3227
3228         * gdbtypes.c (type_align): Don't consider static members when
3229         computing structure alignment.
3230
3231 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3232
3233         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3234         return 0 for other types.
3235         * arch-utils.c (default_type_align): Always return 0.
3236         * gdbarch.h: Regenerate.
3237         * gdbarch.sh (type_align): Extend comment.
3238         * gdbtypes.c (type_align): Add additional comments, always call
3239         gdbarch_type_align before applying the default rules.
3240         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3241         generic code will then apply a suitable default.
3242         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3243         types, return 0 for other types.
3244
3245 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3246
3247         * NEWS: Create a new section for the next release branch.
3248         Rename the section of the current branch, now that it has
3249         been cut.
3250
3251 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3252
3253         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3254         * version.in: Bump version to 8.3.50.DATE-git.
3255
3256 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3257
3258         * aix-thread.c (ptid_cmp): Remove unused variable.
3259         (get_signaled_thread): Likewise.
3260         (store_regs_user_thread): Likewise.
3261         (store_regs_kernel_thread): Likewise.
3262         (fetch_regs_kernel_thread): Remove shadowed variable.
3263
3264 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3265
3266         * features/riscv/32bit-cpu.xml: Add register numbers.
3267         * features/riscv/32bit-fpu.c: Regenerate.
3268         * features/riscv/32bit-fpu.xml: Add register numbers.
3269         * features/riscv/64bit-cpu.xml: Add register numbers.
3270         * features/riscv/64bit-fpu.c: Regenerate.
3271         * features/riscv/64bit-fpu.xml: Add register numbers.
3272
3273 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3274
3275         * NEWS: Mention two argument form of gdb.Value constructor.
3276         * python/py-value.c (convert_buffer_and_type_to_value): New
3277         function.
3278         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3279         Add support for handling an optional second argument.  Call
3280         convert_buffer_and_type_to_value as appropriate.
3281         * python/python-internal.h (Py_buffer_deleter): New struct.
3282         (Py_buffer_up): New typedef.
3283
3284 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3285
3286         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3287         instead of releasing ownership.
3288
3289 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3290
3291         * dwarf2read.c (open_and_init_dwp_file): Call
3292         elf_numsections instead of bfd_count_sections to initialize
3293         dwp_file->num_sections.
3294
3295 2019-02-25  Tom Tromey  <tromey@adacore.com>
3296
3297         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3298
3299 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3300
3301         * gcore.in: Add '--readnever' option when invoking GDB.
3302
3303 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3304
3305         * MAINTAINERS: Update my email address.
3306
3307 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3308
3309         * build-id.c (build_id_to_debug_bfd_1): New function.
3310         (build_id_to_debug_bfd): Look for separate debug file in
3311         sysroot.
3312
3313 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3314
3315         * gdbarch.sh: Update the copyright year range that is placed into
3316         generated files.
3317
3318 2019-02-22  Keith Seitz  <keiths@redhat.com>
3319
3320         PR symtab/23853
3321         * linespec.c (create_sals_line_offset): Search for the default
3322         symtab's filename instead of its fullname.
3323
3324 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3325
3326         * NEWS: Update style defaults.
3327
3328 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3329
3330         * main.c (captured_main_1): Disable styling in batch mode.
3331
3332 2019-02-20  Tom Tromey  <tom@tromey.com>
3333
3334         * symtab.c (symtab_symbol_info): Fix typos.
3335
3336 2019-02-20  Tom Tromey  <tromey@adacore.com>
3337
3338         * findcmd.c (_initialize_mem_search): Use upper case for
3339         metasyntactic variables.
3340
3341 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3342
3343         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3344         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3345
3346 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3347
3348         * top.h (source_file_name): Change to std::string.
3349         * top.c (source_file_name): Likewise.
3350         (command_line_input): Adjust.
3351         * cli/cli-script.c (script_from_file): Adjust.
3352
3353 2019-02-19  Tom Tromey  <tromey@adacore.com>
3354
3355         * ravenscar-thread.c
3356         (ravenscar_thread_target::update_thread_list): Don't call
3357         ada_build_task_list.
3358         * ada-lang.h (ada_build_task_list): Don't declare.
3359         * ada-tasks.c (struct ada_tasks_inferior_data)
3360         <task_list_valid_p>: Now bool.
3361         (read_known_tasks, ada_task_list_changed)
3362         (ada_tasks_invalidate_inferior_data): Update.
3363         (read_known_tasks_array): Return bool.
3364         (read_known_tasks_list): Likewise.
3365         (read_known_tasks): Return void.
3366         (ada_build_task_list): Now static.
3367
3368 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3369
3370         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3371         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3372
3373 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3374
3375         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3376         variant for ada_tasks_pspace_data_handle and
3377         ada_tasks_inferior_data_handle.
3378         (ada_tasks_pspace_data_cleanup): New function.
3379         (ada_tasks_inferior_data_cleanup): New function.
3380
3381 2019-02-17  Tom Tromey  <tom@tromey.com>
3382
3383         * macrotab.h (macro_source_fullname): Return a std::string.
3384         * macrotab.c (macro_include, check_for_redefinition)
3385         (macro_undef, macro_lookup_definition, foreach_macro)
3386         (foreach_macro_in_scope): Update.
3387         (macro_source_fullname): Return a std::string.
3388         * macrocmd.c (show_pp_source_pos): Update.
3389
3390 2019-02-17  Tom Tromey  <tom@tromey.com>
3391
3392         * macrocmd.c (show_pp_source_pos): Style the file names.
3393
3394 2019-02-17  Tom Tromey  <tom@tromey.com>
3395
3396         PR tui/24197:
3397         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3398
3399 2019-02-17  Tom Tromey  <tom@tromey.com>
3400
3401         * ada-lang.c (user_select_syms): Use filtered printing.
3402         * utils.c (wrap_style): New global.
3403         (desired_style): Remove.
3404         (emit_style_escape): Add stream parameter.
3405         (set_output_style, reset_terminal_style, prompt_for_continue):
3406         Update.
3407         (flush_wrap_buffer): Only flush gdb_stdout.
3408         (wrap_here): Set wrap_style.
3409         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3410         treat escape sequences as a character.  Change when wrap buffer is
3411         flushed.
3412         (fputs_styled): Do not set the output style when the default is
3413         requested.
3414         * ui-style.h (struct ui_file_style) <is_default>: New method.
3415         * source.c (print_source_lines_base): Emit escape sequences in one
3416         piece.
3417
3418 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3419
3420         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3421         integers and enumeration types.
3422
3423 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3424
3425         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3426         instead of lookup_symbol_in_language
3427         (do_exact_match): New function.
3428         (ada_get_symbol_name_matcher): Return do_exact_match when
3429         doing a verbatim match.
3430
3431 2019-02-15  Tom Tromey  <tromey@adacore.com>
3432
3433         * ravenscar-thread.c (ravenscar_thread_target::resume)
3434         (ravenscar_thread_target::wait): Special case wildcard requests.
3435
3436 2019-02-15  Tom Tromey  <tromey@adacore.com>
3437
3438         * ravenscar-thread.c (base_ptid): Remove.
3439         (struct ravenscar_thread_target) <close>: New method.
3440         <m_base_ptid>: New member.
3441         <update_inferior_ptid, active_task, task_is_currently_active,
3442         runtime_initialized>: Declare methods.
3443         <ravenscar_thread_target>: Add constructor.
3444         (ravenscar_thread_target::task_is_currently_active)
3445         (ravenscar_thread_target::update_inferior_ptid)
3446         (ravenscar_runtime_initialized): Rename.  Now methods.
3447         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3448         (ravenscar_thread_target::update_thread_list): Update.
3449         (ravenscar_thread_target::active_task): Now method.
3450         (ravenscar_thread_target::store_registers)
3451         (ravenscar_thread_target::prepare_to_store)
3452         (ravenscar_thread_target::prepare_to_store)
3453         (ravenscar_thread_target::mourn_inferior): Update.
3454         (ravenscar_inferior_created): Use "new" to create target.
3455         (ravenscar_thread_target::get_ada_task_ptid): Update.
3456         (_initialize_ravenscar): Don't initialize base_ptid.
3457         (ravenscar_ops): Remove global.
3458
3459 2019-02-15  Tom Tromey  <tromey@adacore.com>
3460
3461         * target.h (push_target): Declare new overload.
3462         * target.c (push_target): New overload, taking an rvalue reference.
3463         * remote.c (remote_target::open_1): Use push_target overload.
3464         * corelow.c (core_target_open): Use push_target overload.
3465
3466 2019-02-15  Tom Tromey  <tromey@adacore.com>
3467
3468         * ravenscar-thread.c (is_ravenscar_task)
3469         (ravenscar_task_is_currently_active): Return bool.
3470         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3471         (_initialize_ravenscar): Remove "(void)".
3472         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3473         Return bool.
3474
3475 2019-02-15  Tom Tromey  <tromey@adacore.com>
3476
3477         * ravenscar-thread.c (ravenscar_runtime_initializer)
3478         (has_ravenscar_runtime, get_running_thread_id)
3479         (ravenscar_thread_target::resume): Fix indentation.
3480
3481 2019-02-15  Tom Tromey  <tromey@adacore.com>
3482
3483         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3484         from ravenscar_arch_ops.
3485         (sparc_ravenscar_ops::fetch_registers)
3486         (sparc_ravenscar_ops::store_registers): Now methods.
3487         (sparc_ravenscar_prepare_to_store): Remove.
3488         (sparc_ravenscar_ops): Redefine.
3489         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3490         methods and destructor.  Remove members.
3491         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3492         (ravenscar_thread_target::store_registers)
3493         (ravenscar_thread_target::prepare_to_store): Update.
3494         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3495         Remove.
3496         (struct ppc_ravenscar_powerpc_ops): Derive from
3497         ravenscar_arch_ops.
3498         (ppc_ravenscar_powerpc_ops::fetch_registers)
3499         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3500         (ppc_ravenscar_powerpc_ops): Redefine.
3501         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3502         (ppc_ravenscar_e500_ops::fetch_registers)
3503         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3504         (ppc_ravenscar_e500_ops): Redefine.
3505         * aarch64-ravenscar-thread.c
3506         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3507         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3508         (aarch64_ravenscar_fetch_registers)
3509         (aarch64_ravenscar_store_registers): Now methods.
3510         (aarch64_ravenscar_ops): Redefine.
3511
3512 2019-02-15  Tom Tromey  <tromey@adacore.com>
3513
3514         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3515         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3516         (ravenscar_thread_target::stopped_by_watchpoint)
3517         (ravenscar_thread_target::stopped_data_address)
3518         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3519
3520 2019-02-15  Tom Tromey  <tromey@adacore.com>
3521
3522         * ravenscar-thread.c: Fix some typos.
3523
3524 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3525             Tom Tromey  <tromey@adacore.com>
3526
3527         * ada-lang.c (ada_exception_sal): Change addr_string to a
3528         std::string.
3529         (create_ada_exception_catchpoint): Update.
3530
3531 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3532             Tom Tromey  <tromey@adacore.com>
3533
3534         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3535         (bp_location_ops): Remove.
3536         (base_breakpoint_allocate_location): Update.
3537         (free_bp_location): Update.
3538         * ada-lang.c (class ada_catchpoint_location)
3539         <ada_catchpoint_location>: Remove ops parameter.
3540         (ada_catchpoint_location_dtor): Remove.
3541         (ada_catchpoint_location_ops): Remove.
3542         (allocate_location_exception): Update.
3543         * breakpoint.h (struct bp_location_ops): Remove.
3544         (class bp_location) <bp_location>: Remove bp_location_ops
3545         parameter.
3546         <~bp_location>: Add destructor.
3547         <ops>: Remove.
3548
3549 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3550             Pedro Alves  <palves@redhat.com>
3551
3552         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3553         'PATH_MAX'.
3554
3555 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3556             Samuel Thibault  <samuel.thibault@gnu.org>
3557             Thomas Schwinge  <thomas@codesourcery.com>
3558
3559         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3560         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3561
3562 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3563
3564         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3565         (check_empty): Use "const char *".
3566
3567         * gnu-nat.c (gnu_nat_target::detach): Instead of
3568         'detach_inferior (pid)' call
3569         'detach_inferior (find_inferior_pid (pid))'.
3570
3571         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3572         'nat/fork-inferior.o'.
3573         * gnu-nat.c: #include "nat/fork-inferior.h".
3574
3575         * gnu-nat.c (gnu_nat_target::detach): Instead of
3576         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3577         * gnu-nat.h: #include "inf-child.h".
3578         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3579         'i386_gnu_nat_target::fetch_registers'.
3580         (gnu_store_registers): Rename/move to
3581         'i386_gnu_nat_target::store_registers'.
3582
3583         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3584         * gnu-nat.h (mach_thread_info): New function.
3585         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3586
3587         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3588
3589 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3590
3591         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3592
3593 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3594
3595         * windows-nat.c (windows_add_thread): Add new parameter
3596         "main_thread_p" with default value set to false.  Update
3597         function documentation as well as all callers.
3598         (windows_delete_thread): Likewise.
3599         (fake_create_process): Update call to windows_add_thread.
3600         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3601         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3602         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3603         call to windows_delete_thread.
3604
3605 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3606
3607         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3608
3609 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3610
3611         * symfile.c (find_separate_debug_file): Use canonical path of
3612         sysroot with child_path instead of gdb_sysroot if it is valid.
3613
3614 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3615
3616         * symfile.c (find_separate_debug_file): Use child_path to
3617         determine if an object file is under a sysroot.
3618
3619 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3620
3621         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3622         unittests/child-path-selftests.c.
3623         * common/pathstuff.c (child_path): New function.
3624         * common/pathstuff.h (child_path): New prototype.
3625         * unittests/child-path-selftests.c: New file.
3626
3627 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3628
3629         * symfile.c (find_separate_debug_file): Look for separate debug
3630         files in debug directories under the sysroot.
3631
3632 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3633
3634         * symtab.h (struct minimal_symbol data_p): New const method.
3635         (struct minimal_symbol text_p): Likewise.
3636         * symtab.c (output_source_filename): Use file name style
3637         to print file name.
3638         (print_symbol_info): Likewise.
3639         (print_msymbol_info): Use address style to print addresses.
3640         Use function name style to print executable text symbols.
3641         (expand_symtab_containing_pc): Use data_p.
3642         (find_pc_sect_compunit_symtab): Likewise.
3643
3644 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3645
3646         * breakpoint.c (describe_other_breakpoints): Use address style
3647         to print addresses.
3648         (say_where): Likewise.
3649
3650 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3651
3652         * ada-typeprint.c (print_func_type): Print function name
3653         style to print function name.
3654         * c-typeprint.c (c_print_type_1): Likewise.
3655
3656 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3657
3658         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3659         for execve.
3660
3661 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3662
3663         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3664         type_stack.
3665
3666 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3667
3668         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3669         TYPE_CODE_REF types.
3670
3671 2019-02-08  Jim Wilson  <jimw@sifive.com>
3672
3673         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3674         (riscv_linux_fregset): New.
3675         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3676
3677 2019-02-07  Tom Tromey  <tom@tromey.com>
3678
3679         * thread.c (thread_cancel_execution_command): Update.
3680         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3681         methods.
3682         (struct thread_fsm_ops): Remove.
3683         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3684         (thread_fsm_should_stop, thread_fsm_return_value)
3685         (thread_fsm_set_finished, thread_fsm_finished_p)
3686         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3687         Don't declare.
3688         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3689         * infrun.c (clear_proceed_status_thread)
3690         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3691         (print_stop_event): Update.
3692         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3693         Add constructor.
3694         (step_command_fsm_ops): Remove.
3695         (new_step_command_fsm): Remove.
3696         (step_1): Update.
3697         (step_command_fsm::should_stop): Rename from
3698         step_command_fsm_should_stop.
3699         (step_command_fsm::clean_up): Rename from
3700         step_command_fsm_clean_up.
3701         (step_command_fsm::do_async_reply_reason): Rename from
3702         step_command_fsm_async_reply_reason.
3703         (struct until_next_fsm): Inherit from thread_fsm.  Add
3704         constructor.
3705         (until_next_fsm_ops): Remove.
3706         (new_until_next_fsm): Remove.
3707         (until_next_fsm::should_stop): Rename from
3708         until_next_fsm_should_stop.
3709         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3710         (until_next_fsm::do_async_reply_reason): Rename from
3711         until_next_fsm_async_reply_reason.
3712         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3713         constructor.  Change type of breakpoint.
3714         (finish_command_fsm_ops): Remove.
3715         (new_finish_command_fsm): Remove.
3716         (finish_command_fsm::should_stop): Rename from
3717         finish_command_fsm_should_stop.
3718         (finish_command_fsm::clean_up): Rename from
3719         finish_command_fsm_clean_up.
3720         (finish_command_fsm::return_value): Rename from
3721         finish_command_fsm_return_value.
3722         (finish_command_fsm::do_async_reply_reason): Rename from
3723         finish_command_fsm_async_reply_reason.
3724         (finish_command): Update.
3725         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3726         Add constructor.
3727         (call_thread_fsm_ops): Remove.
3728         (call_thread_fsm::call_thread_fsm): Rename from
3729         new_call_thread_fsm.
3730         (call_thread_fsm::should_stop): Rename from
3731         call_thread_fsm_should_stop.
3732         (call_thread_fsm::should_notify_stop): Rename from
3733         call_thread_fsm_should_notify_stop.
3734         (run_inferior_call, call_function_by_hand_dummy): Update.
3735         * cli/cli-interp.c (should_print_stop_to_console): Update.
3736         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3737         Add constructor.  Change type of location_breakpoint,
3738         caller_breakpoint.
3739         (until_break_fsm_ops): Remove.
3740         (new_until_break_fsm): Remove.
3741         (until_break_fsm::should_stop): Rename from
3742         until_break_fsm_should_stop.
3743         (until_break_fsm::clean_up): Rename from
3744         until_break_fsm_clean_up.
3745         (until_break_fsm::do_async_reply_reason): Rename from
3746         until_break_fsm_async_reply_reason.
3747         (until_break_command): Update.
3748         * thread-fsm.c: Remove.
3749         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3750
3751 2019-02-07  Tom Tromey  <tom@tromey.com>
3752
3753         * yy-remap.h: Add include guard.
3754         * xtensa-tdep.h: Add include guard.
3755         * xcoffread.h: Rename include guard.
3756         * varobj-iter.h: Add include guard.
3757         * tui/tui.h: Rename include guard.
3758         * tui/tui-winsource.h: Rename include guard.
3759         * tui/tui-wingeneral.h: Rename include guard.
3760         * tui/tui-windata.h: Rename include guard.
3761         * tui/tui-win.h: Rename include guard.
3762         * tui/tui-stack.h: Rename include guard.
3763         * tui/tui-source.h: Rename include guard.
3764         * tui/tui-regs.h: Rename include guard.
3765         * tui/tui-out.h: Rename include guard.
3766         * tui/tui-layout.h: Rename include guard.
3767         * tui/tui-io.h: Rename include guard.
3768         * tui/tui-hooks.h: Rename include guard.
3769         * tui/tui-file.h: Rename include guard.
3770         * tui/tui-disasm.h: Rename include guard.
3771         * tui/tui-data.h: Rename include guard.
3772         * tui/tui-command.h: Rename include guard.
3773         * tic6x-tdep.h: Add include guard.
3774         * target/waitstatus.h: Rename include guard.
3775         * target/wait.h: Rename include guard.
3776         * target/target.h: Rename include guard.
3777         * target/resume.h: Rename include guard.
3778         * target-float.h: Rename include guard.
3779         * stabsread.h: Add include guard.
3780         * rs6000-tdep.h: Add include guard.
3781         * riscv-fbsd-tdep.h: Add include guard.
3782         * regformats/regdef.h: Rename include guard.
3783         * record.h: Rename include guard.
3784         * python/python.h: Rename include guard.
3785         * python/python-internal.h: Rename include guard.
3786         * python/py-stopevent.h: Rename include guard.
3787         * python/py-ref.h: Rename include guard.
3788         * python/py-record.h: Rename include guard.
3789         * python/py-record-full.h: Rename include guard.
3790         * python/py-record-btrace.h: Rename include guard.
3791         * python/py-instruction.h: Rename include guard.
3792         * python/py-events.h: Rename include guard.
3793         * python/py-event.h: Rename include guard.
3794         * procfs.h: Add include guard.
3795         * proc-utils.h: Add include guard.
3796         * p-lang.h: Add include guard.
3797         * or1k-tdep.h: Rename include guard.
3798         * observable.h: Rename include guard.
3799         * nto-tdep.h: Rename include guard.
3800         * nat/x86-linux.h: Rename include guard.
3801         * nat/x86-linux-dregs.h: Rename include guard.
3802         * nat/x86-gcc-cpuid.h: Add include guard.
3803         * nat/x86-dregs.h: Rename include guard.
3804         * nat/x86-cpuid.h: Rename include guard.
3805         * nat/ppc-linux.h: Rename include guard.
3806         * nat/mips-linux-watch.h: Rename include guard.
3807         * nat/linux-waitpid.h: Rename include guard.
3808         * nat/linux-ptrace.h: Rename include guard.
3809         * nat/linux-procfs.h: Rename include guard.
3810         * nat/linux-osdata.h: Rename include guard.
3811         * nat/linux-nat.h: Rename include guard.
3812         * nat/linux-namespaces.h: Rename include guard.
3813         * nat/linux-btrace.h: Rename include guard.
3814         * nat/glibc_thread_db.h: Rename include guard.
3815         * nat/gdb_thread_db.h: Rename include guard.
3816         * nat/gdb_ptrace.h: Rename include guard.
3817         * nat/fork-inferior.h: Rename include guard.
3818         * nat/amd64-linux-siginfo.h: Rename include guard.
3819         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3820         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3821         * nat/aarch64-linux.h: Rename include guard.
3822         * nat/aarch64-linux-hw-point.h: Rename include guard.
3823         * mn10300-tdep.h: Add include guard.
3824         * mips-linux-tdep.h: Add include guard.
3825         * mi/mi-parse.h: Rename include guard.
3826         * mi/mi-out.h: Rename include guard.
3827         * mi/mi-main.h: Rename include guard.
3828         * mi/mi-interp.h: Rename include guard.
3829         * mi/mi-getopt.h: Rename include guard.
3830         * mi/mi-console.h: Rename include guard.
3831         * mi/mi-common.h: Rename include guard.
3832         * mi/mi-cmds.h: Rename include guard.
3833         * mi/mi-cmd-break.h: Rename include guard.
3834         * m2-lang.h: Add include guard.
3835         * location.h: Rename include guard.
3836         * linux-record.h: Rename include guard.
3837         * linux-nat.h: Add include guard.
3838         * linux-fork.h: Add include guard.
3839         * i386-darwin-tdep.h: Rename include guard.
3840         * hppa-linux-offsets.h: Add include guard.
3841         * guile/guile.h: Rename include guard.
3842         * guile/guile-internal.h: Rename include guard.
3843         * gnu-nat.h: Rename include guard.
3844         * gdb-stabs.h: Rename include guard.
3845         * frv-tdep.h: Add include guard.
3846         * f-lang.h: Add include guard.
3847         * event-loop.h: Add include guard.
3848         * darwin-nat.h: Rename include guard.
3849         * cp-abi.h: Rename include guard.
3850         * config/sparc/nm-sol2.h: Rename include guard.
3851         * config/nm-nto.h: Rename include guard.
3852         * config/nm-linux.h: Add include guard.
3853         * config/i386/nm-i386gnu.h: Rename include guard.
3854         * config/djgpp/nl_types.h: Rename include guard.
3855         * config/djgpp/langinfo.h: Rename include guard.
3856         * compile/gcc-cp-plugin.h: Add include guard.
3857         * compile/gcc-c-plugin.h: Add include guard.
3858         * compile/compile.h: Rename include guard.
3859         * compile/compile-object-run.h: Rename include guard.
3860         * compile/compile-object-load.h: Rename include guard.
3861         * compile/compile-internal.h: Rename include guard.
3862         * compile/compile-cplus.h: Rename include guard.
3863         * compile/compile-c.h: Rename include guard.
3864         * common/xml-utils.h: Rename include guard.
3865         * common/x86-xstate.h: Rename include guard.
3866         * common/version.h: Rename include guard.
3867         * common/vec.h: Rename include guard.
3868         * common/tdesc.h: Rename include guard.
3869         * common/selftest.h: Rename include guard.
3870         * common/scoped_restore.h: Rename include guard.
3871         * common/scoped_mmap.h: Rename include guard.
3872         * common/scoped_fd.h: Rename include guard.
3873         * common/safe-iterator.h: Rename include guard.
3874         * common/run-time-clock.h: Rename include guard.
3875         * common/refcounted-object.h: Rename include guard.
3876         * common/queue.h: Rename include guard.
3877         * common/ptid.h: Rename include guard.
3878         * common/print-utils.h: Rename include guard.
3879         * common/preprocessor.h: Rename include guard.
3880         * common/pathstuff.h: Rename include guard.
3881         * common/observable.h: Rename include guard.
3882         * common/netstuff.h: Rename include guard.
3883         * common/job-control.h: Rename include guard.
3884         * common/host-defs.h: Rename include guard.
3885         * common/gdb_wait.h: Rename include guard.
3886         * common/gdb_vecs.h: Rename include guard.
3887         * common/gdb_unlinker.h: Rename include guard.
3888         * common/gdb_unique_ptr.h: Rename include guard.
3889         * common/gdb_tilde_expand.h: Rename include guard.
3890         * common/gdb_sys_time.h: Rename include guard.
3891         * common/gdb_string_view.h: Rename include guard.
3892         * common/gdb_splay_tree.h: Rename include guard.
3893         * common/gdb_setjmp.h: Rename include guard.
3894         * common/gdb_ref_ptr.h: Rename include guard.
3895         * common/gdb_optional.h: Rename include guard.
3896         * common/gdb_locale.h: Rename include guard.
3897         * common/gdb_assert.h: Rename include guard.
3898         * common/filtered-iterator.h: Rename include guard.
3899         * common/filestuff.h: Rename include guard.
3900         * common/fileio.h: Rename include guard.
3901         * common/environ.h: Rename include guard.
3902         * common/common-utils.h: Rename include guard.
3903         * common/common-types.h: Rename include guard.
3904         * common/common-regcache.h: Rename include guard.
3905         * common/common-inferior.h: Rename include guard.
3906         * common/common-gdbthread.h: Rename include guard.
3907         * common/common-exceptions.h: Rename include guard.
3908         * common/common-defs.h: Rename include guard.
3909         * common/common-debug.h: Rename include guard.
3910         * common/cleanups.h: Rename include guard.
3911         * common/buffer.h: Rename include guard.
3912         * common/btrace-common.h: Rename include guard.
3913         * common/break-common.h: Rename include guard.
3914         * cli/cli-utils.h: Rename include guard.
3915         * cli/cli-style.h: Rename include guard.
3916         * cli/cli-setshow.h: Rename include guard.
3917         * cli/cli-script.h: Rename include guard.
3918         * cli/cli-interp.h: Rename include guard.
3919         * cli/cli-decode.h: Rename include guard.
3920         * cli/cli-cmds.h: Rename include guard.
3921         * charset-list.h: Add include guard.
3922         * buildsym-legacy.h: Rename include guard.
3923         * bfin-tdep.h: Add include guard.
3924         * ax.h: Rename include guard.
3925         * arm-linux-tdep.h: Add include guard.
3926         * arm-fbsd-tdep.h: Add include guard.
3927         * arch/xtensa.h: Rename include guard.
3928         * arch/tic6x.h: Add include guard.
3929         * arch/i386.h: Add include guard.
3930         * arch/arm.h: Rename include guard.
3931         * arch/arm-linux.h: Rename include guard.
3932         * arch/arm-get-next-pcs.h: Rename include guard.
3933         * arch/amd64.h: Add include guard.
3934         * arch/aarch64-insn.h: Rename include guard.
3935         * arch-utils.h: Rename include guard.
3936         * annotate.h: Add include guard.
3937         * amd64-darwin-tdep.h: Rename include guard.
3938         * aarch64-linux-tdep.h: Add include guard.
3939         * aarch64-fbsd-tdep.h: Add include guard.
3940         * aarch32-linux-nat.h: Add include guard.
3941
3942 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3943
3944         * macrotab.c (macro_define_internal): New function that
3945         factorizes macro_define_object_internal and macro_define_function
3946         code.
3947         (macro_define_object_internal): Use macro_define_internal.
3948         (macro_define_function): Likewise.
3949
3950 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3951
3952         * macrocmd.c (extract_identifier): Return
3953         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3954         callers.
3955
3956 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3957
3958         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3959
3960 2019-02-05  Tom Tromey  <tom@tromey.com>
3961
3962         * target.c (target_stack::unpush): Move assertion earlier.
3963
3964 2019-01-30  Tom Tromey  <tom@tromey.com>
3965
3966         PR python/23615:
3967         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3968         (gdbpy_parse_and_eval): Likewise.
3969         * python/python-internal.h (gdbpy_allow_threads): New class.
3970
3971 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3972
3973         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3974         (aarch64_fbsd_fpregmap): Move earlier.
3975         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3976         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3977         instead of individual calls to trad_frame_set_reg_addr.
3978         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3979         earlier.
3980         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3981         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3982         instead of individual calls to trad_frame_set_reg_addr.
3983
3984 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3985
3986         * CONTRIBUTE: Replace contribution list with wiki link.
3987
3988 2019-01-25  Tom Tromey  <tom@tromey.com>
3989
3990         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3991
3992 2019-01-25  Tom Tromey  <tom@tromey.com>
3993
3994         * xtensa-linux-nat.c: Fix common/ includes.
3995         * xml-support.h: Fix common/ includes.
3996         * xml-support.c: Fix common/ includes.
3997         * x86-linux-nat.c: Fix common/ includes.
3998         * windows-nat.c: Fix common/ includes.
3999         * varobj.h: Fix common/ includes.
4000         * varobj.c: Fix common/ includes.
4001         * value.c: Fix common/ includes.
4002         * valops.c: Fix common/ includes.
4003         * utils.c: Fix common/ includes.
4004         * unittests/xml-utils-selftests.c: Fix common/ includes.
4005         * unittests/utils-selftests.c: Fix common/ includes.
4006         * unittests/unpack-selftests.c: Fix common/ includes.
4007         * unittests/tracepoint-selftests.c: Fix common/ includes.
4008         * unittests/style-selftests.c: Fix common/ includes.
4009         * unittests/string_view-selftests.c: Fix common/ includes.
4010         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4011         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4012         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4013         * unittests/rsp-low-selftests.c: Fix common/ includes.
4014         * unittests/parse-connection-spec-selftests.c: Fix common/
4015         includes.
4016         * unittests/optional-selftests.c: Fix common/ includes.
4017         * unittests/offset-type-selftests.c: Fix common/ includes.
4018         * unittests/observable-selftests.c: Fix common/ includes.
4019         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4020         * unittests/memrange-selftests.c: Fix common/ includes.
4021         * unittests/memory-map-selftests.c: Fix common/ includes.
4022         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4023         * unittests/function-view-selftests.c: Fix common/ includes.
4024         * unittests/environ-selftests.c: Fix common/ includes.
4025         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4026         * unittests/common-utils-selftests.c: Fix common/ includes.
4027         * unittests/cli-utils-selftests.c: Fix common/ includes.
4028         * unittests/array-view-selftests.c: Fix common/ includes.
4029         * ui-file.c: Fix common/ includes.
4030         * tui/tui-io.c: Fix common/ includes.
4031         * tracepoint.h: Fix common/ includes.
4032         * tracepoint.c: Fix common/ includes.
4033         * tracefile-tfile.c: Fix common/ includes.
4034         * top.h: Fix common/ includes.
4035         * top.c: Fix common/ includes.
4036         * thread.c: Fix common/ includes.
4037         * target/waitstatus.h: Fix common/ includes.
4038         * target/waitstatus.c: Fix common/ includes.
4039         * target.h: Fix common/ includes.
4040         * target.c: Fix common/ includes.
4041         * target-memory.c: Fix common/ includes.
4042         * target-descriptions.c: Fix common/ includes.
4043         * symtab.h: Fix common/ includes.
4044         * symfile.c: Fix common/ includes.
4045         * stap-probe.c: Fix common/ includes.
4046         * spu-linux-nat.c: Fix common/ includes.
4047         * sparc-nat.c: Fix common/ includes.
4048         * source.c: Fix common/ includes.
4049         * solib.c: Fix common/ includes.
4050         * solib-target.c: Fix common/ includes.
4051         * ser-unix.c: Fix common/ includes.
4052         * ser-tcp.c: Fix common/ includes.
4053         * ser-pipe.c: Fix common/ includes.
4054         * ser-base.c: Fix common/ includes.
4055         * selftest-arch.c: Fix common/ includes.
4056         * s12z-tdep.c: Fix common/ includes.
4057         * rust-exp.y: Fix common/ includes.
4058         * rs6000-aix-tdep.c: Fix common/ includes.
4059         * riscv-tdep.c: Fix common/ includes.
4060         * remote.c: Fix common/ includes.
4061         * remote-notif.h: Fix common/ includes.
4062         * remote-fileio.h: Fix common/ includes.
4063         * remote-fileio.c: Fix common/ includes.
4064         * regcache.h: Fix common/ includes.
4065         * regcache.c: Fix common/ includes.
4066         * record-btrace.c: Fix common/ includes.
4067         * python/python.c: Fix common/ includes.
4068         * python/py-type.c: Fix common/ includes.
4069         * python/py-inferior.c: Fix common/ includes.
4070         * progspace.h: Fix common/ includes.
4071         * producer.c: Fix common/ includes.
4072         * procfs.c: Fix common/ includes.
4073         * proc-api.c: Fix common/ includes.
4074         * printcmd.c: Fix common/ includes.
4075         * ppc-linux-nat.c: Fix common/ includes.
4076         * parser-defs.h: Fix common/ includes.
4077         * osdata.c: Fix common/ includes.
4078         * obsd-nat.c: Fix common/ includes.
4079         * nat/x86-linux.c: Fix common/ includes.
4080         * nat/x86-linux-dregs.c: Fix common/ includes.
4081         * nat/x86-dregs.h: Fix common/ includes.
4082         * nat/x86-dregs.c: Fix common/ includes.
4083         * nat/ppc-linux.c: Fix common/ includes.
4084         * nat/mips-linux-watch.h: Fix common/ includes.
4085         * nat/mips-linux-watch.c: Fix common/ includes.
4086         * nat/linux-waitpid.c: Fix common/ includes.
4087         * nat/linux-ptrace.h: Fix common/ includes.
4088         * nat/linux-ptrace.c: Fix common/ includes.
4089         * nat/linux-procfs.c: Fix common/ includes.
4090         * nat/linux-personality.c: Fix common/ includes.
4091         * nat/linux-osdata.c: Fix common/ includes.
4092         * nat/linux-namespaces.c: Fix common/ includes.
4093         * nat/linux-btrace.h: Fix common/ includes.
4094         * nat/linux-btrace.c: Fix common/ includes.
4095         * nat/fork-inferior.c: Fix common/ includes.
4096         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4097         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4098         * nat/aarch64-linux.c: Fix common/ includes.
4099         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4100         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4101         * namespace.h: Fix common/ includes.
4102         * mips-linux-tdep.c: Fix common/ includes.
4103         * minsyms.c: Fix common/ includes.
4104         * mi/mi-parse.h: Fix common/ includes.
4105         * mi/mi-main.c: Fix common/ includes.
4106         * mi/mi-cmd-env.c: Fix common/ includes.
4107         * memrange.h: Fix common/ includes.
4108         * memattr.c: Fix common/ includes.
4109         * maint.h: Fix common/ includes.
4110         * maint.c: Fix common/ includes.
4111         * main.c: Fix common/ includes.
4112         * machoread.c: Fix common/ includes.
4113         * location.c: Fix common/ includes.
4114         * linux-thread-db.c: Fix common/ includes.
4115         * linux-nat.c: Fix common/ includes.
4116         * linux-fork.c: Fix common/ includes.
4117         * inline-frame.c: Fix common/ includes.
4118         * infrun.c: Fix common/ includes.
4119         * inflow.c: Fix common/ includes.
4120         * inferior.h: Fix common/ includes.
4121         * inferior.c: Fix common/ includes.
4122         * infcmd.c: Fix common/ includes.
4123         * inf-ptrace.c: Fix common/ includes.
4124         * inf-child.c: Fix common/ includes.
4125         * ia64-linux-nat.c: Fix common/ includes.
4126         * i387-tdep.c: Fix common/ includes.
4127         * i386-tdep.c: Fix common/ includes.
4128         * i386-linux-tdep.c: Fix common/ includes.
4129         * i386-linux-nat.c: Fix common/ includes.
4130         * i386-go32-tdep.c: Fix common/ includes.
4131         * i386-fbsd-tdep.c: Fix common/ includes.
4132         * i386-fbsd-nat.c: Fix common/ includes.
4133         * guile/scm-type.c: Fix common/ includes.
4134         * guile/guile.c: Fix common/ includes.
4135         * go32-nat.c: Fix common/ includes.
4136         * gnu-nat.c: Fix common/ includes.
4137         * gdbthread.h: Fix common/ includes.
4138         * gdbarch-selftests.c: Fix common/ includes.
4139         * gdb_usleep.c: Fix common/ includes.
4140         * gdb_select.h: Fix common/ includes.
4141         * gdb_bfd.c: Fix common/ includes.
4142         * gcore.c: Fix common/ includes.
4143         * fork-child.c: Fix common/ includes.
4144         * findvar.c: Fix common/ includes.
4145         * fbsd-nat.c: Fix common/ includes.
4146         * event-top.c: Fix common/ includes.
4147         * event-loop.c: Fix common/ includes.
4148         * dwarf2read.c: Fix common/ includes.
4149         * dwarf2loc.c: Fix common/ includes.
4150         * dwarf2-frame.c: Fix common/ includes.
4151         * dwarf-index-cache.c: Fix common/ includes.
4152         * dtrace-probe.c: Fix common/ includes.
4153         * disasm-selftests.c: Fix common/ includes.
4154         * defs.h: Fix common/ includes.
4155         * csky-tdep.c: Fix common/ includes.
4156         * cp-valprint.c: Fix common/ includes.
4157         * cp-support.h: Fix common/ includes.
4158         * cp-support.c: Fix common/ includes.
4159         * corelow.c: Fix common/ includes.
4160         * completer.h: Fix common/ includes.
4161         * completer.c: Fix common/ includes.
4162         * compile/compile.c: Fix common/ includes.
4163         * compile/compile-loc2c.c: Fix common/ includes.
4164         * compile/compile-cplus-types.c: Fix common/ includes.
4165         * compile/compile-cplus-symbols.c: Fix common/ includes.
4166         * command.h: Fix common/ includes.
4167         * cli/cli-dump.c: Fix common/ includes.
4168         * cli/cli-cmds.c: Fix common/ includes.
4169         * charset.c: Fix common/ includes.
4170         * build-id.c: Fix common/ includes.
4171         * btrace.h: Fix common/ includes.
4172         * btrace.c: Fix common/ includes.
4173         * breakpoint.h: Fix common/ includes.
4174         * breakpoint.c: Fix common/ includes.
4175         * ax.h: 
4176         (enum agent_op): Fix common/ includes.
4177         * ax-general.c (struct aop_map): Fix common/ includes.
4178         * ax-gdb.c: Fix common/ includes.
4179         * auxv.c: Fix common/ includes.
4180         * auto-load.c: Fix common/ includes.
4181         * arm-tdep.c: Fix common/ includes.
4182         * arch/riscv.c: Fix common/ includes.
4183         * arch/ppc-linux-common.c: Fix common/ includes.
4184         * arch/i386.c: Fix common/ includes.
4185         * arch/arm.c: Fix common/ includes.
4186         * arch/arm-linux.c: Fix common/ includes.
4187         * arch/arm-get-next-pcs.c: Fix common/ includes.
4188         * arch/amd64.c: Fix common/ includes.
4189         * arch/aarch64.c: Fix common/ includes.
4190         * arch/aarch64-insn.c: Fix common/ includes.
4191         * arch-utils.c: Fix common/ includes.
4192         * amd64-windows-tdep.c: Fix common/ includes.
4193         * amd64-tdep.c: Fix common/ includes.
4194         * amd64-sol2-tdep.c: Fix common/ includes.
4195         * amd64-obsd-tdep.c: Fix common/ includes.
4196         * amd64-nbsd-tdep.c: Fix common/ includes.
4197         * amd64-linux-tdep.c: Fix common/ includes.
4198         * amd64-linux-nat.c: Fix common/ includes.
4199         * amd64-fbsd-tdep.c: Fix common/ includes.
4200         * amd64-fbsd-nat.c: Fix common/ includes.
4201         * amd64-dicos-tdep.c: Fix common/ includes.
4202         * amd64-darwin-tdep.c: Fix common/ includes.
4203         * agent.c: Fix common/ includes.
4204         * ada-lang.h: Fix common/ includes.
4205         * ada-lang.c: Fix common/ includes.
4206         * aarch64-tdep.c: Fix common/ includes.
4207
4208 2019-01-25  Tom Tromey  <tom@tromey.com>
4209
4210         * common/create-version.sh: Use common/version.h.
4211
4212 2019-01-24  Pedro Alves  <palves@redhat.com>
4213
4214         * infrun.c (signal_stop, signal_print, signal_program)
4215         (signal_catch, signal_pass): Now arrays instead of pointers.
4216         (update_signals_program_target, do_target_resume)
4217         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4218         * linux-nat.c (linux_nat_target::pass_signals)
4219         (linux_nat_target::create_inferior, linux_nat_target::attach):
4220         Adjust.
4221         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4222         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4223         * procfs.c (procfs_target::pass_signals): Adjust.
4224         * record-full.c (record_full_target::resume): Adjust.
4225         * remote.c (remote_target::pass_signals)
4226         (remote_target::program_signals): Adjust.
4227         * target-debug.h (target_debug_print_signals): Now takes a
4228         gdb::array_view as parameter.  Adjust.
4229         * target.h (target_ops) <pass_signals, program_signals>: Replace
4230         pointer and length parameters with gdb::array_view.
4231         (target_pass_signals, target_program_signals): Likewise.
4232         * target-delegates.c: Regenerate.
4233
4234 2019-01-24  Pedro Alves  <palves@redhat.com>
4235
4236         * common/forward-scope-exit.h
4237         (forward_scope_exit::forward_scope_exit): Pass arguments to
4238         m_bind_function directly, instead of creating a std::bind and
4239         copying that.
4240
4241 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4242
4243         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4244         for static members.
4245         (pass_in_v_vfp_candidate): Likewise.
4246
4247 2019-01-23  Tom Tromey  <tom@tromey.com>
4248             Pedro Alves  <palves@redhat.com>
4249
4250         * regcache.c (class regcache_invalidator): Remove.
4251         (regcache::raw_write): Use make_scope_exit.
4252
4253 2019-01-23  Tom Tromey  <tom@tromey.com>
4254
4255         * ui-out.h (class ui_out_emit_type): Update comment.
4256
4257 2019-01-23  Tom Tromey  <tom@tromey.com>
4258
4259         * infrun.c (fetch_inferior_event): Update comment.
4260
4261 2019-01-23  Tom Tromey  <tom@tromey.com>
4262             Pedro Alves  <palves@redhat.com>
4263
4264         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4265         parameter.
4266         (fetch_inferior_event): Use SCOPE_EXIT.
4267
4268
4269 2019-01-23  Tom Tromey  <tom@tromey.com>
4270             Pedro Alves  <palves@redhat.com>
4271
4272         * infrun.c (disable_thread_events): Delete.
4273         (stop_all_threads): Use SCOPE_EXIT.
4274
4275 2019-01-23  Tom Tromey  <tom@tromey.com>
4276             Pedro Alves  <palves@redhat.com>
4277
4278         * symfile.c: Include forward-scope-exit.h.
4279         (clear_symtab_users_cleanup): Replace forward declaration with
4280         a FORWARD_SCOPE_EXIT.
4281         (syms_from_objfile_1): Use the forward_scope_exit and
4282         gdb::optional instead of cleanup_function.
4283         (reread_symbols): Use the forward_scope_exit instead of
4284         cleanup_function.
4285         (clear_symtab_users_cleanup): Remove function.
4286
4287 2019-01-23  Tom Tromey  <tom@tromey.com>
4288             Pedro Alves  <palves@redhat.com>
4289
4290         * linux-nat.c: Include scope-exit.h.
4291         (cleanup_target_stop): Remove.
4292         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4293         SCOPE_EXIT.
4294
4295 2019-01-23  Tom Tromey  <tom@tromey.com>
4296             Pedro Alves  <palves@redhat.com>
4297
4298         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4299         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4300
4301 2019-01-23  Tom Tromey  <tom@tromey.com>
4302             Andrew Burgess  <andrew.burgess@embecosm.com>
4303             Pedro Alves  <palves@redhat.com>
4304
4305         * infrun.c (fetch_inferior_event): Use scope_exit.
4306         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4307         * top.c (execute_command): Use scope_exit.
4308         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4309         * utils.c (do_bpstat_clear_actions_cleanup)
4310         (make_bpstat_clear_actions_cleanup): Remove.
4311
4312 2019-01-23  Tom Tromey  <tom@tromey.com>
4313             Pedro Alves  <palves@redhat.com>
4314
4315         * infrun.c: Include "common/scope-exit.h"
4316         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4317         (wait_for_inferior): Use SCOPE_EXIT.
4318         (fetch_inferior_event): Use scope_exit.
4319
4320 2019-01-23  Tom Tromey  <tom@tromey.com>
4321             Pedro Alves  <palves@redhat.com>
4322
4323         * breakpoint.c (create_breakpoint): Remove cleanup.
4324
4325 2019-01-23  Tom Tromey  <tom@tromey.com>
4326             Andrew Burgess  <andrew.burgess@embecosm.com>
4327             Pedro Alves  <palves@redhat.com>
4328
4329 2019-01-23  Pedro Alves  <palves@redhat.com>
4330
4331         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4332
4333 2019-01-23  Pedro Alves  <palves@redhat.com>
4334             Andrew Burgess  <andrew.burgess@embecosm.com>
4335
4336         * gdbthread.h: Include "common/forward-scope-exit.h".
4337         (scoped_finish_thread_state): Redefine custom class in terms of
4338         forward_scope_exit.
4339
4340 2019-01-23  Pedro Alves  <palves@redhat.com>
4341             Andrew Burgess  <andrew.burgess@embecosm.com>
4342
4343         * common/forward-scope-exit.h: New file.
4344
4345 2019-01-23  Pedro Alves  <palves@redhat.com>
4346             Andrew Burgess  <andrew.burgess@embecosm.com>
4347             Tom Tromey  <tom@tromey.com>
4348
4349         * common/scope-exit.h: New file.
4350
4351 2019-01-23  Pedro Alves  <palves@redhat.com>
4352
4353         * common/preprocessor.h (ESC): Rename to ...
4354         (ESC_PARENS): ... this.
4355         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4356         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4357
4358 2019-01-23  Tom Tromey  <tom@tromey.com>
4359
4360         * language.h (class scoped_switch_to_sym_language_if_auto):
4361         Initialize m_lang in both cases.
4362
4363 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4364
4365         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4366         with XCNEW.
4367
4368 2019-01-22  Tom Tromey  <tom@tromey.com>
4369
4370         * corelow.c: Do not include sys/file.h.
4371
4372 2019-01-22  Tom Tromey  <tom@tromey.com>
4373
4374         * tui/tui-wingeneral.h: Include gdb_curses.h.
4375
4376 2019-01-22  Tom Tromey  <tom@tromey.com>
4377
4378         * source-cache.h (class source_cache) <get_source_lines,
4379         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4380
4381 2019-01-22  Tom Tromey  <tom@tromey.com>
4382
4383         * remote-fileio.h (struct remote_target): Declare.
4384
4385 2019-01-22  Tom Tromey  <tom@tromey.com>
4386
4387         * python/py-arch.c: Do not include py-ref.h.
4388         * python/py-bpevent.c: Do not include py-ref.h.
4389         * python/py-cmd.c: Do not include py-ref.h.
4390         * python/py-continueevent.c: Do not include py-ref.h.
4391         * python/py-event.h: Do not include py-ref.h.
4392         * python/py-evtregistry.c: Do not include py-ref.h.
4393         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4394         * python/py-frame.c: Do not include py-ref.h.
4395         * python/py-framefilter.c: Do not include py-ref.h.
4396         * python/py-function.c: Do not include py-ref.h.
4397         * python/py-infevents.c: Do not include py-ref.h.
4398         * python/py-linetable.c: Do not include py-ref.h.
4399         * python/py-objfile.c: Do not include py-ref.h.
4400         * python/py-param.c: Do not include py-ref.h.
4401         * python/py-prettyprint.c: Do not include py-ref.h.
4402         * python/py-progspace.c: Do not include py-ref.h.
4403         * python/py-symbol.c: Do not include py-ref.h.
4404         * python/py-symtab.c: Do not include py-ref.h.
4405         * python/py-type.c: Do not include py-ref.h.
4406         * python/py-unwind.c: Do not include py-ref.h.
4407         * python/py-utils.c: Do not include py-ref.h.
4408         * python/py-value.c: Do not include py-ref.h.
4409         * python/py-varobj.c: Do not include py-ref.h.
4410         * python/py-xmethods.c: Do not include py-ref.h.
4411         * python/python.c: Do not include py-ref.h.
4412         * varobj.c: Do not include py-ref.h.
4413
4414 2019-01-22  Tom Tromey  <tom@tromey.com>
4415
4416         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4417         keyword for bcache.
4418
4419 2019-01-22  Tom Tromey  <tom@tromey.com>
4420
4421         * compile/compile-cplus-types.c: Remove a comment by #include.
4422
4423 2019-01-22  Tom Tromey  <tom@tromey.com>
4424
4425         * compile/gcc-c-plugin.h: Include compile-internal.h.
4426
4427 2019-01-22  Tom Tromey  <tom@tromey.com>
4428
4429         * stabsread.c (EXTERN): Do not define.
4430         (symnum, next_symbol_text_func, processing_gcc_compilation)
4431         (within_function, global_sym_chain, global_stabs)
4432         (previous_stab_code, this_object_header_files)
4433         (n_this_object_header_files)
4434         (n_allocated_this_object_header_files): Define.
4435         * stabsread.h (EXTERN): Never define.  Use "extern".
4436
4437 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4438
4439         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4440         history_value.
4441
4442 2019-01-21  Tom Tromey  <tom@tromey.com>
4443
4444         * ui-out.c: Fix includes.
4445         * tui/tui-source.c: Fix includes.
4446         * target.c: Fix includes.
4447         * remote.c: Fix includes.
4448         * regcache.c: Fix includes.
4449         * python/py-block.c: Fix includes.
4450         * printcmd.c: Fix includes.
4451         * or1k-tdep.c: Fix includes.
4452         * mi/mi-main.c: Fix includes.
4453         * m32r-tdep.c: Fix includes.
4454         * csky-tdep.c: Fix includes.
4455         * compile/compile-cplus-types.c: Fix includes.
4456         * cli/cli-interp.c: Fix includes.
4457
4458 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4459
4460         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4461         for padding.
4462
4463 2019-01-16  Tom Tromey  <tom@tromey.com>
4464
4465         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4466         earlier.
4467         (struct objfile) <msymbols_range>: Move from top level.
4468         <msymbols>: New method.
4469         (class objfile_msymbols): Remove.
4470         * symtab.c (default_collect_symbol_completion_matches_break_on):
4471         Update.
4472         * symmisc.c (dump_msymbols): Update.
4473         * stabsread.c (scan_file_globals): Update.
4474         * objc-lang.c (info_selectors_command, info_classes_command)
4475         (find_methods): Update.
4476         * minsyms.c (find_solib_trampoline_target): Update.
4477         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4478         * coffread.c (coff_symfile_read): Update.
4479         * ada-lang.c (ada_lookup_simple_minsym)
4480         (ada_collect_symbol_completion_matches): Update.
4481
4482 2019-01-16  Tom Tromey  <tom@tromey.com>
4483
4484         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4485         type.  Remove no-argument constructor.
4486         <iterator::operator++>: Simplify.
4487         <begin>: Update.
4488         <end>: Use minimal_symbol_count.
4489
4490 2019-01-16  Tom Tromey  <tom@tromey.com>
4491
4492         * objfiles.h (struct objfile) <psymtabs>: New method.
4493         (class objfile_psymtabs): Remove.
4494         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4495         typedef.
4496         <range>: New method.
4497         (require_partial_symbols): Change return type.
4498         * psymtab.c (require_partial_symbols)
4499         (psym_expand_symtabs_matching): Update.
4500         * mdebugread.c (parse_partial_symbols): Update.
4501         * dbxread.c (dbx_end_psymtab): Update.
4502
4503 2019-01-15  Tom Tromey  <tom@tromey.com>
4504
4505         * symtab.c (lookup_objfile_from_block)
4506         (lookup_symbol_in_objfile_symtabs)
4507         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4508         (find_line_symtab, info_sources_command)
4509         (default_collect_symbol_completion_matches_break_on)
4510         (make_source_files_completion_list): Update.
4511         * symmisc.c (print_objfile_statistics, dump_objfile)
4512         (maintenance_print_symbols, maintenance_info_symtabs)
4513         (maintenance_check_symtabs, maintenance_info_line_tables):
4514         Update.
4515         * source.c (select_source_symtab)
4516         (forget_cached_source_info_for_objfile): Update.
4517         * objfiles.h (class objfile_compunits): Remove.
4518         (struct objfile) <compunits_range>: New typedef.
4519         (compunits): New method.
4520         * objfiles.c (objfile_relocate1): Update.
4521         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4522         * maint.c (count_symtabs_and_blocks): Update.
4523         * linespec.c (iterate_over_all_matching_symtabs): Update.
4524         * cp-support.c (add_symbol_overload_list_qualified): Update.
4525         * coffread.c (coff_symtab_read): Update.
4526         * ada-lang.c (add_nonlocal_symbols)
4527         (ada_collect_symbol_completion_matches)
4528         (ada_add_global_exceptions): Update.
4529
4530 2019-01-15  Tom Tromey  <tom@tromey.com>
4531
4532         * progspace.h (program_space) <objfiles_safe_range>: New
4533         typedef.
4534         <objfiles_safe>: New method.
4535         * objfiles.h (class all_objfiles_safe): Remove.
4536         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4537         * jit.c (jit_inferior_exit_hook): Update.
4538
4539 2019-01-17  Tom Tromey  <tom@tromey.com>
4540
4541         * progspace.h (program_space) <objfiles_range>: New typedef.
4542         <objfiles>: New method.
4543         <objfiles_head>: Rename from objfiles.
4544         (object_files): Update.
4545         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4546         * guile/scm-pretty-print.c
4547         (ppscm_find_pretty_printer_from_objfiles): Update.
4548         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4549         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4550         Update.
4551         * python/py-progspace.c (pspy_get_objfiles): Update.
4552         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4553         Update.
4554         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4555         (objfpy_lookup_objfile_by_build_id): Update.
4556         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4557         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4558         Update.
4559         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4560         (expand_symtab_containing_pc, lookup_objfile_from_block)
4561         (lookup_static_symbol, basic_lookup_transparent_type)
4562         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4563         (find_line_symtab, info_sources_command)
4564         (default_collect_symbol_completion_matches_break_on)
4565         (make_source_files_completion_list, find_main_name): Update.
4566         * symmisc.c (print_symbol_bcache_statistics)
4567         (print_objfile_statistics, maintenance_print_symbols)
4568         (maintenance_print_msymbols, maintenance_print_objfiles)
4569         (maintenance_info_symtabs, maintenance_check_symtabs)
4570         (maintenance_expand_symtabs, maintenance_info_line_tables):
4571         Update.
4572         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4573         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4574         (map_overlay_command, unmap_overlay_command)
4575         (simple_overlay_update, expand_symtabs_matching)
4576         (map_symbol_filenames): Update.
4577         * symfile-debug.c (set_debug_symfile): Update.
4578         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4579         Update.
4580         * source.c (select_source_symtab, forget_cached_source_info):
4581         Update.
4582         * solib.c (solib_read_symbols): Update.
4583         * solib-spu.c (append_ocl_sos): Update.
4584         * psymtab.c (maintenance_print_psymbols)
4585         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4586         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4587         * printcmd.c (info_symbol_command): Update.
4588         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4589         Update.
4590         * objfiles.h (class all_objfiles): Remove.
4591         * objfiles.c (have_partial_symbols, have_full_symbols)
4592         (have_minimal_symbols, qsort_cmp, update_section_map)
4593         (shared_objfile_contains_address_p)
4594         (default_iterate_over_objfiles_in_search_order): Update.
4595         * objc-lang.c (info_selectors_command, info_classes_command)
4596         (find_methods): Update.
4597         * minsyms.c (find_solib_trampoline_target): Update.
4598         * maint.c (maintenance_info_sections)
4599         (maintenance_translate_address, count_symtabs_and_blocks):
4600         Update.
4601         * main.c (captured_main_1): Update.
4602         * linux-thread-db.c (try_thread_db_load_from_pdir)
4603         (has_libpthread): Update.
4604         * linespec.c (iterate_over_all_matching_symtabs)
4605         (search_minsyms_for_name): Update.
4606         * jit.c (jit_find_objf_with_entry_addr): Update.
4607         * hppa-tdep.c (find_unwind_entry)
4608         (hppa_lookup_stub_minimal_symbol): Update.
4609         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4610         Update.
4611         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4612         (elf_gnu_ifunc_resolve_by_got): Update.
4613         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4614         * dwarf-index-write.c (save_gdb_index_command): Update.
4615         * cp-support.c (add_symbol_overload_list_qualified): Update.
4616         * breakpoint.c (create_overlay_event_breakpoint)
4617         (create_longjmp_master_breakpoint)
4618         (create_std_terminate_master_breakpoint)
4619         (create_exception_master_breakpoint): Update.
4620         * blockframe.c (find_pc_partial_function): Update.
4621         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4622         (ada_collect_symbol_completion_matches)
4623         (ada_add_global_exceptions): Update.
4624
4625 2019-01-17  Tom Tromey  <tom@tromey.com>
4626
4627         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4628         declare VEC.
4629         (solib_target_parse_libraries): Change return type.
4630         (library_list_start_segment, library_list_start_section)
4631         (library_list_end_library, library_list_start_library); Update.
4632         (solib_target_free_library_list): Remove.
4633         (solib_target_parse_libraries): Remove cleanup.  Change return
4634         type.
4635         (solib_target_current_sos): Update.
4636
4637 2019-01-17  Tom Tromey  <tromey@bapiya>
4638
4639         * valprint.c: Replace "the the" with "the".
4640         * symtab.c: Replace "the the" with "the".
4641         * solib.c: Replace "the the" with "the".
4642         * solib-dsbt.c: Replace "the the" with "the".
4643         * linespec.c: Replace "the the" with "the".
4644         * dwarf2loc.h: Replace "the the" with "the".
4645         * amd64-windows-tdep.c: Replace "the the" with "the".
4646         * aarch64-tdep.c: Replace "the the" with "the".
4647
4648 2019-01-16  Keith Seitz  <keiths@redhat.com>
4649
4650         PR gdb/23773
4651         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4652         <builder>: Rename to ..
4653         <m_builder>: ... this and make private.
4654         (dwarf2_cu::get_builder): New method.  Change all users of
4655         `builder' to use this method.
4656         (dwarf2_start_symtab): Move to ...
4657         (dwarf2_cu::start_symtab): ... here.  Update all callers
4658         (setup_type_unit_groups): Move to ...
4659         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4660         callers.
4661         (dwarf2_cu::reset_builder): New method.
4662         (process_full_compunit, process_full_type_unit): Use
4663         dwarf2_cu::reset_builder.
4664         (follow_die_offset): Record the ancestor CU if it is different
4665         from the followed DIE's CU.
4666         (follow_die_sig_1): Likewise.
4667
4668 2019-01-15  Tom Tromey  <tom@tromey.com>
4669
4670         * remote.c (class remote_state) <buf>: Now a char_vector.
4671         <buf_size>: Remove.
4672         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4673         parameter.
4674         (remote_target::getpkt_or_notif_sane_1)
4675         (remote_target::getpkt_sane)
4676         (remote_target::getpkt_or_notif_sane): Likewise.
4677         (class remote_target) <putpkt>: New overload.
4678         (remote_target::read_frame): Change type of "buf_p".  Remove
4679         sizeof_p parameter.
4680         (packet_ok): New overload.
4681         (packet_check_result): New overload.
4682         Update all uses.
4683
4684 2019-01-14  Tom Tromey  <tom@tromey.com>
4685
4686         * remote-notif.c (handle_notification, remote_notif_ack)
4687         (remote_notif_parse): Make "buf" const.
4688         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4689         const.
4690         (remote_notif_parse, remote_notif_ack, handle_notification):
4691         Likewise.
4692         * remote.c (remote_notif_stop_parse): Make "buf" const.
4693         (remote_target::remote_parse_stop_reply): Make "buf" const.
4694         (remote_notif_stop_ack): Make "buf" const.
4695
4696 2019-01-14  Tom Tromey  <tom@tromey.com>
4697
4698         * remote.c (remote_console_output): Make parameter const.
4699
4700 2019-01-14  Tom Tromey  <tom@tromey.com>
4701
4702         * target-debug.h (target_debug_print_signals): Constify.
4703         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4704         * procfs.c (procfs_target::pass_signals): Update.
4705         * linux-nat.c (linux_nat_target::pass_signals): Update.
4706         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4707         * target-delegates.c: Rebuild.
4708         * remote.c (remote_target::program_signals): Update.
4709         (remote_target::pass_signals): Update.
4710         * target.c (target_pass_signals): Constify argument.
4711         (target_program_signals): Likewise.
4712         * target.h (struct target_ops) <pass_signals, program_signals>:
4713         Constify argument.
4714         (target_pass_signals, target_program_signals): Constify argument.
4715
4716 2019-01-14  Tom Tromey  <tom@tromey.com>
4717
4718         PR tui/28819:
4719         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4720
4721 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4722
4723         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4724         field.
4725         * rs6000-tdep.c: Include reggroups.h.
4726         (IS_V_ALIAS_PSEUDOREG): Define.
4727         (rs6000_register_name): Return names for the "vX" aliases.
4728         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4729         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4730         aliases.  Call default_register_reggroup_p for all other
4731         pseudo-registers.
4732         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4733         New functions.
4734         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4735         Handle "vX" aliases.
4736         (v_alias_pseudo_register_collect): New function.
4737         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4738         (rs6000_gdbarch_init): Initialize "vX" aliases as
4739         pseudo-registers.  Restore registration of
4740         rs6000_pseudo_register_reggroup_p with
4741         set_tdesc_pseudo_register_reggroup_p.
4742
4743 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4744
4745         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4746         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4747         set_gdbarch_num_pseudo_regs.
4748
4749 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4750
4751         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4752         Remove arg prefixname, add do_set and do_show.
4753         Add member functions set_list and show_list.
4754         * cli/cli-style.c (class cli_style_option): Update accordingly.
4755         (style_set_list): Move to file scope.
4756         (style_show_list): Likewise.
4757         (set_style): Call help_list.
4758         (show_style): Call cmd_show_list.
4759         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4760         Update to use the new macro.
4761
4762 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4763
4764         * ada-lang.c (_initialize_ada_language): Expand the help text
4765         for the "catch exception" command.
4766
4767 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4768
4769         * symtab.c (matching_obj_sections): Initialize obj,
4770         declare it closer to its usage.
4771
4772 2019-01-10  Tom Tromey  <tom@tromey.com>
4773
4774         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4775         (basic_inf_threads_range): Remove.
4776         (inf_threads_range, inf_non_exited_threads_range)
4777         (safe_inf_threads_range): Use next_adapter.
4778
4779 2019-01-10  Keith Seitz  <keiths@redhat.com>
4780
4781         PR gdb/23712
4782         PR symtab/23010
4783         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4784         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4785
4786 2019-01-10  Keith Seitz  <keiths@redhat.com>
4787
4788         PR gdb/23712
4789         PR symtab/23010
4790         * dictionary.c (pending_to_vector): Remove.
4791         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4792         Remove _1 suffix, replacing functions of the same name.  Update
4793         all callers.
4794         (dict_create_hashed, dict_create_hashed_expandable)
4795         (dict_create_linear, dict_create_linear_expandable, dict_free)
4796         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4797         Make functions static.
4798
4799 2019-01-10  Keith Seitz  <keiths@redhat.com>
4800
4801         PR gdb/23712
4802         PR symtab/23010
4803         * dictionary.h (struct dictionary): Replace declaration with
4804         multidictionary.
4805         (dict_create_hashed, dict_create_hashed_expandable)
4806         (dict_create_linear, dict_create_linear_expandable)
4807         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4808         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4809         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4810         taking multidictionary argument.
4811         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4812         * block.h (struct block) <dict>: Change to multidictionary
4813         and rename `multidict'.
4814         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4815         symmisc.c: Update all dictionary references to multidictionary.
4816
4817 2019-01-10  Keith Seitz  <keiths@redhat.com>
4818
4819         PR gdb/23712
4820         PR symtab/23010
4821         * dictionary.c: Include unordered_map.
4822         (pending_to_vector): New function.
4823         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4824         Rewrite the non-"_1" functions to take vector instead
4825         of linked list.
4826         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4827         "new" _1 versions of the same name.
4828         (multidictionary): Define.
4829         (std::hash<enum language): New definition.
4830         (collate_pending_symbols_by_language, mdict_create_hashed)
4831         (mdict_create_hashed_expandable, mdict_create_linear)
4832         (mdict_create_linear_expandable, mdict_free)
4833         (find_language_dictionary, create_new_language_dictionary)
4834         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4835         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4836         (mdict_size, mdict_empty): New functions.
4837         * dictionary.h (mdict_iterator): Define.
4838
4839 2019-01-10  Pedro Alves  <palves@redhat.com>
4840
4841         * breakpoint.c (read_uploaded_action)
4842         (create_tracepoint_from_upload): Adjust to use
4843         gdb::unique_xmalloc_ptr.
4844         * ctf.c (ctf_write_uploaded_tp):
4845         (SET_ARRAY_FIELD): Use emplace_back.
4846         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4847         * tracefile-tfile.c (tfile_write_uploaded_tp):
4848         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4849         gdb::unique_xmalloc_ptr.
4850         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4851         at_string, cond_string, cmd_strings>: Replace char pointers
4852         with gdb::unique_xmalloc_ptr.
4853
4854 2019-01-10  Pedro Alves  <palves@redhat.com>
4855
4856         * solib-target.c (library_list_start_library): Don't xstrdup name.
4857
4858 2019-01-10  Pedro Alves  <palves@redhat.com>
4859
4860         * mdebugread.c (parse_partial_symbols): Use
4861         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4862
4863 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4864
4865         * linux-fork.c (scoped_switch_fork_info)
4866         <~scoped_switch_fork_info>: Fix incorrect variable name.
4867
4868 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4869
4870         * linux-fork.c (scoped_switch_fork_info)
4871         <scoped_switch_fork_info>: Make explicit.
4872         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4873
4874 2019-01-10  Tom Tromey  <tom@tromey.com>
4875
4876         * objfiles.h (objfile::reset_psymtabs): Update.
4877         * objfiles.c (objfile::objfile): Update.
4878         * psymtab.h (psymtab_storage::obstack): Update.
4879         (psymtab_storage::m_obstack): Use gdb::optional.
4880         (class psymtab_storage): Update comment.  Remove objfile
4881         parameter.
4882         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4883
4884 2019-01-10  Tom Tromey  <tom@tromey.com>
4885
4886         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4887         <free_psymtabs>: Now private.
4888         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4889         (allocate_psymtab): Use new method.
4890
4891 2019-01-10  Tom Tromey  <tom@tromey.com>
4892
4893         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4894         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4895         * mdebugread.c (parse_partial_symbols): Use
4896         allocate_dependencies.
4897         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4898         allocate_dependencies.
4899         (process_psymtab_comp_unit_reader)
4900         (build_type_psymtab_dependencies): Likewise.
4901         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4902
4903 2019-01-10  Tom Tromey  <tom@tromey.com>
4904
4905         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4906         PSYMBOL_SET_LANGUAGE.
4907         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4908
4909 2019-01-10  Tom Tromey  <tom@tromey.com>
4910
4911         * psymtab.h (psymtab_storage::obstack): New method.
4912         <m_obstack>: Rename from obstack; now private.
4913         * psymtab.c (psymtab_storage): Update.
4914         * dwarf2read.c (create_addrmap_from_index)
4915         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4916         Update.
4917
4918 2019-01-10  Tom Tromey  <tom@tromey.com>
4919
4920         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4921         * objfiles.h (objfile::reset_psymtabs): New method.
4922
4923 2019-01-10  Tom Tromey  <tom@tromey.com>
4924
4925         * symmisc.c (print_symbol_bcache_statistics): Update.
4926         (print_objfile_statistics): Update.
4927         * symfile.c (reread_symbols): Update.
4928         * psymtab.h (class psymtab_storage): New.
4929         * psymtab.c (psymtab_storage): New constructor.
4930         (~psymtab_storage): New destructor.
4931         (require_partial_symbols): Update.
4932         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4933         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4934         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4935         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4936         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4937         (start_psymtab_common, end_psymtab_common)
4938         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4939         (allocate_psymtab): Update.
4940         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4941         Update.
4942         (dump_psymtab_addrmap, maintenance_print_psymbols)
4943         (maintenance_check_psymtabs): Update.
4944         (class objfile_psymtabs): Move to objfiles.h.
4945         * psympriv.h (discard_psymtab): Now inline.
4946         (psymtab_discarder::psymtab_discarder): Update.
4947         (psymtab_discarder::~psymtab_discarder): Update.
4948         (ALL_OBJFILE_PSYMTABS): Rewrite.
4949         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4950         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4951         Remove fields.
4952         <partial_symtabs>: New field.
4953         (class objfile_psymtabs): Move from psymtab.h.  Update.
4954         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4955         psymbol_cache.
4956         (objfile::~objfile): Don't destroy psymbol_cache.
4957         * mdebugread.c (parse_partial_symbols): Update.
4958         * dwarf2read.c (create_addrmap_from_index)
4959         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4960         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4961         (add_partial_subprogram, dwarf2_ranges_read): Update.
4962         * dwarf-index-write.c (write_address_map)
4963         (write_one_signatured_type, recursively_write_psymbols)
4964         (class debug_names, class debug_names, write_psymtabs_to_index):
4965         Update.
4966
4967 2019-01-10  Tom Tromey  <tom@tromey.com>
4968
4969         * symtab.h (SYMBOL_SET_NAMES): Update.
4970         (symbol_set_names): Update.
4971         (MSYMBOL_SET_NAMES): Update.
4972         * symtab.c (symbol_set_names): Change argument to be an
4973         objfile_per_bfd_storage.
4974         * psymtab.c (add_psymbol_to_bcache): Update.
4975         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4976
4977 2019-01-10  Tom Tromey  <tom@tromey.com>
4978
4979         * symtab.c (create_demangled_names_hash): Change argument to be an
4980         objfile_per_bfd_storage.
4981         (symbol_set_names): Update.
4982
4983 2019-01-10  Tom Tromey  <tom@tromey.com>
4984
4985         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4986         init_psymbol_list.
4987         * psymtab.c (init_psymbol_list): Do nothing if already called.
4988         * psympriv.h (init_psymbol_list): Add comment.
4989         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4990         init_psymbol_list.
4991         * dbxread.c (dbx_symfile_read): Unconditionally call
4992         init_psymbol_list.
4993
4994 2019-01-10  Tom Tromey  <tom@tromey.com>
4995
4996         * xcoffread.c (scan_xcoff_symtab): Update.
4997         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4998         "where".
4999         * mdebugread.c (parse_partial_symbols)
5000         (handle_psymbol_enumerators): Update.
5001         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5002         * dbxread.c (read_dbx_symtab): Update.
5003         * psympriv.h (psymbol_placement): New enum.
5004         (add_psymbol_to_list): Update.
5005
5006 2019-01-10  Tom Tromey  <tom@tromey.com>
5007
5008         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5009         static_psymbols parameters.
5010         (scan_xcoff_symtab): Update.
5011         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5012         static_psymbols parameters.
5013         * psympriv.h (start_psymtab_common): Update.
5014         * mdebugread.c (parse_partial_symbols): Update.
5015         * dwarf2read.c (create_partial_symtab): Update.
5016         * dbxread.c (read_dbx_symtab): Update.
5017         (start_psymtab): Remove global_psymbols and static_psymbols
5018         parameters.
5019
5020 2019-01-10  Tom Tromey  <tom@tromey.com>
5021
5022         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5023         * psymtab.c (allocate_psymtab): Add comment.
5024         * psympriv.h (allocate_psymtab): Add comment.
5025         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5026         initializations.
5027         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5028
5029 2019-01-10  Tom Tromey  <tom@tromey.com>
5030
5031         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5032         Don't declare.
5033         * mipsread.c: Include mdebugread.h.
5034         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5035         Declare.
5036         * elfread.c: Include mdebugread.h.
5037
5038 2019-01-09  Tom Tromey  <tom@tromey.com>
5039
5040         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5041         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5042         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5043         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5044         (psym_lookup_symbol, psym_find_last_source_symtab)
5045         (psym_forget_cached_source_info, psym_print_stats)
5046         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5047         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5048         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5049         (psym_find_compunit_symtab_by_address)
5050         (maintenance_print_psymbols, maintenance_info_psymtabs)
5051         (maintenance_check_psymtabs): Use ranged for.
5052         * psymtab.h (class objfile_psymtabs): New.
5053         (require_partial_symbols): Return objfile_psymtabs.
5054         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5055
5056 2019-01-09  Tom Tromey  <tom@tromey.com>
5057
5058         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5059         (find_pc_mapped_section, list_overlays_command)
5060         (map_overlay_command, unmap_overlay_command)
5061         (simple_overlay_update): Use all_objfiles.
5062         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5063         * printcmd.c (info_symbol_command): Use all_objfiles.
5064         * objfiles.h (ALL_OBJSECTIONS): Remove.
5065         * maint.c (maintenance_translate_address): Use all_objfiles.
5066         * gcore.c (gcore_create_callback): Use all_objfiles.
5067         (objfile_find_memory_regions): Likewise.
5068
5069 2019-01-09  Tom Tromey  <tom@tromey.com>
5070
5071         * symtab.c (find_line_symtab, info_sources_command)
5072         (make_source_files_completion_list): Use objfile_compunits.
5073         * source.c (select_source_symtab): Use objfile_compunits.
5074         * objfiles.h (struct objfile): Update comment.
5075         (ALL_OBJFILES): Remove.
5076         (ALL_FILETABS): Remove.
5077         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5078         objfile_compunits.
5079
5080 2019-01-09  Tom Tromey  <tom@tromey.com>
5081
5082         * symmisc.c (print_objfile_statistics, dump_objfile)
5083         (maintenance_print_symbols): Use compunit_filetabs.
5084         * source.c (forget_cached_source_info_for_objfile): Use
5085         compunit_filetabs.
5086         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5087         (ALL_FILETABS): Use compunit_filetabs.
5088         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5089         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5090
5091 2019-01-09  Tom Tromey  <tom@tromey.com>
5092
5093         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5094         (compunit_filetabs): New.
5095         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5096         compunit_filetabs.
5097         (info_sources_command, make_source_files_completion_list): Remove
5098         declaration.
5099         * symmisc.c (print_objfile_statistics, dump_objfile)
5100         (maintenance_print_symbols): Remove declaration.
5101         (maintenance_info_symtabs): Use compunit_filetabs.
5102         (maintenance_info_line_tables): Likewise.
5103         * source.c (select_source_symtab): Change local variable name.
5104         (forget_cached_source_info_for_objfile): Remove declaration.
5105         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5106         * objfiles.c (objfile_relocate1): Remove declaration.
5107         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5108         declaration.
5109         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5110         * coffread.c (coff_symtab_read): Remove declaration.
5111         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5112         compunit_filetabs.
5113
5114 2019-01-09  Tom Tromey  <tom@tromey.com>
5115
5116         * symtab.c (lookup_objfile_from_block)
5117         (find_pc_sect_compunit_symtab, search_symbols)
5118         (default_collect_symbol_completion_matches_break_on): Use
5119         objfile_compunits.
5120         * objfiles.h (ALL_COMPUNITS): Remove.
5121         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5122         * cp-support.c (add_symbol_overload_list_qualified): Use
5123         objfile_compunits.
5124         * ada-lang.c (ada_collect_symbol_completion_matches)
5125         (ada_add_global_exceptions): Use objfile_compunits.
5126
5127 2019-01-09  Tom Tromey  <tom@tromey.com>
5128
5129         * source.c (select_source_symtab)
5130         (forget_cached_source_info_for_objfile): Remove declaration.
5131         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5132         declaration.
5133         * maint.c (count_symtabs_and_blocks): Remove declaration.
5134         * cp-support.c (add_symbol_overload_list_qualified): Remove
5135         declaration.
5136         * coffread.c (coff_symtab_read): Remove declaration.
5137         * symtab.c (lookup_symbol_in_objfile_symtabs)
5138         (basic_lookup_transparent_type_1): Use objfile_compunits.
5139         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5140         (info_sources_command, search_symbols)
5141         (default_collect_symbol_completion_matches_break_on)
5142         (make_source_files_completion_list): Remove declaration.
5143         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5144         (ada_collect_symbol_completion_matches)
5145         (ada_add_global_exceptions): Remove declaration.
5146         * linespec.c (iterate_over_all_matching_symtabs): Use
5147         objfile_compunits.
5148         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5149         (class objfile_compunits): New.
5150         (ALL_COMPUNITS): Use objfile_compunits.
5151         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5152         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5153         objfile_compunits.
5154         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5155
5156 2019-01-09  Tom Tromey  <tom@tromey.com>
5157
5158         * symtab.c (search_symbols)
5159         (default_collect_symbol_completion_matches_break_on): Use
5160         objfile_msymbols.
5161         * ada-lang.c (ada_lookup_simple_minsym)
5162         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5163         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5164         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5165         objfile_msymbols.
5166         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5167         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5168         * objc-lang.c (find_methods): Use objfile_msymbols.
5169         (info_selectors_command, info_classes_command): Likewise.
5170         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5171         * objfiles.h (class objfile_msymbols): New.
5172         (ALL_OBJFILE_MSYMBOLS): Remove.
5173         (ALL_MSYMBOLS): Remove.
5174
5175 2019-01-09  Tom Tromey  <tom@tromey.com>
5176
5177         * common/next-iterator.h (next_adapter): Add Iterator template
5178         parameter.
5179         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5180         (class all_objfiles_safe): New.
5181         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5182         * objfiles.c (put_objfile_before): Update comment.
5183         (add_separate_debug_objfile): Likewise.
5184         (free_all_objfiles): Use all_objfiles_safe.
5185         (objfile_purge_solibs): Likewise.
5186
5187 2019-01-09  Tom Tromey  <tom@tromey.com>
5188
5189         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5190         (expand_symtab_containing_pc, lookup_static_symbol)
5191         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5192         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5193         all_objfiles.
5194         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5195         * breakpoint.c (create_overlay_event_breakpoint)
5196         (create_longjmp_master_breakpoint)
5197         (create_std_terminate_master_breakpoint)
5198         (create_exception_master_breakpoint): Use all_objfiles.
5199         * linux-thread-db.c (try_thread_db_load_from_pdir)
5200         (has_libpthread): Use all_objfiles.
5201         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5202         * linespec.c (iterate_over_all_matching_symtabs)
5203         (search_minsyms_for_name): Use all_objfiles.
5204         * maint.c (maintenance_info_sections): Use all_objfiles.
5205         * main.c (captured_main_1): Use all_objfiles.
5206         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5207         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5208         * guile/scm-pretty-print.c
5209         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5210         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5211         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5212         (maintenance_print_msymbols): Use all_objfiles.
5213         * source.c (select_source_symtab): Use all_objfiles.
5214         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5215         * symfile.c (remove_symbol_file_command)
5216         (expand_symtabs_matching, map_symbol_filenames): Use
5217         all_objfiles.
5218         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5219         all_objfiles.
5220         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5221         * objc-lang.c (find_methods): Use all_objfiles.
5222         * objfiles.c (have_partial_symbols, have_full_symbols)
5223         (have_minimal_symbols, qsort_cmp)
5224         (default_iterate_over_objfiles_in_search_order): Use
5225         all_objfiles.
5226         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5227         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5228         (maintenance_check_psymtabs): Use all_objfiles.
5229         (ALL_PSYMTABS): Remove.
5230         * compile/compile-object-run.c (do_module_cleanup): Use
5231         all_objfiles.
5232         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5233         * cp-support.c (add_symbol_overload_list_qualified): Use
5234         all_objfiles.
5235         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5236         Use all_objfiles.
5237         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5238         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5239         all_objfiles.
5240         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5241         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5242         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5243         Uses all_objfiles.
5244         * solib.c (solib_read_symbols): Use all_objfiles
5245
5246 2019-01-09  Tom Tromey  <tom@tromey.com>
5247
5248         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5249         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5250         all_objfiles.
5251         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5252         * symmisc.c (print_symbol_bcache_statistics)
5253         (print_objfile_statistics, maintenance_print_objfiles)
5254         (maintenance_info_symtabs, maintenance_check_symtabs)
5255         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5256         all_objfiles.
5257         * source.c (forget_cached_source_info): Use all_objfiles.
5258         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5259         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5260         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5261         * objfiles.c (update_section_map): Use all_objfiles.
5262         (shared_objfile_contains_address_p): Likewise.
5263         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5264         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5265
5266 2019-01-09  Tom Tromey  <tom@tromey.com>
5267
5268         * common/next-iterator.h: New file.
5269         * objfiles.h (class all_objfiles): New.
5270         (struct objfile_iterator): New.
5271
5272 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5273
5274         * NEWS: Move the description of the changed "frame", "select-frame",
5275          and "info frame" commands to the Changed commands section.
5276
5277 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5278
5279         * gdbtypes.c (check_stub_method_group): Remove handling of old
5280         mangling schemes.
5281         * linespec.c (find_methods): Likewise.
5282         * stabsread.c (read_member_functions): Likewise.
5283         * valops.c (search_struct_method): Likewise.
5284         (value_struct_elt_for_reference): Likewise.
5285         * NEWS: Mention this change.
5286
5287 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5288
5289         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5290         print_source_lines.
5291         * source.c (print_source_lines_base): Update line number check.
5292         (print_source_lines): New function.
5293         (source_lines_range::source_lines_range): New function.
5294         * source.h (class source_lines_range): New class.
5295         (print_source_lines): New declaration.
5296
5297 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5298
5299         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5300
5301 2019-01-08  Tom Tromey  <tom@tromey.com>
5302             Simon Marchi  <simon.marchi@ericsson.com>
5303
5304         PR gdb/24060
5305         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5306         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5307         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5308         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5309         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5310         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5311
5312 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5313
5314         * source.c (select_source_symtab): Move header comment to
5315         declaration in source.h.
5316         (forget_cached_source_info_for_objfile): Likewise.
5317         (forget_cached_source_info): Likewise.
5318         (identify_source_line): Likewise.
5319         * source.h (identify_source_line): Move declaration from symtab.h
5320         and add comment from source.c
5321         (print_source_lines): Likewise.
5322         (forget_cached_source_info_for_objfile): Likewise.
5323         (forget_cached_source_info): Likewise.
5324         (select_source_symtab): Likewise.
5325         (enum print_source_lines_flag): Move definition from symtab.h.
5326         * symtab.h (identify_source_line): Move declaration to source.h.
5327         (print_source_lines): Likewise.
5328         (forget_cached_source_info_for_objfile): Likewise.
5329         (forget_cached_source_info): Likewise.
5330         (select_source_symtab): Likewise.
5331         (enum print_source_lines_flag): Move definition to source.h.
5332         * tui/tui-hooks.c: Add 'source.h' include.
5333
5334 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5335
5336         * source.c (print_source_lines_base): Handle requests to print
5337         reverse line number sequences, and guard against empty lines
5338         string.
5339
5340 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5341
5342         * source.c (print_source_lines_base): Fix skip of '\r' if next
5343         character is '\n'.
5344
5345 2019-01-06  Tom Tromey  <tom@tromey.com>
5346
5347         * c-exp.y (struct c_parse_state) <macro_original_text,
5348         expansion_obstack>: New member.
5349         (macro_original_text, expansion_obstack): Remove globals.
5350         (scan_macro_expansion, scanning_macro_expansion)
5351         (finished_macro_expansion): Update.
5352         (scan_macro_cleanup): Remove.
5353         (yylex, c_parse): Update.
5354
5355 2019-01-06  Tom Tromey  <tom@tromey.com>
5356
5357         * c-exp.y (struct c_parse_state) <strings>: New member.
5358         (operator_stoken): Update.
5359
5360 2019-01-06  Tom Tromey  <tom@tromey.com>
5361
5362         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5363         (union type_stack_elt) <typelist_val>: Now a pointer to
5364         std::vector.
5365         (type_stack_cleanup): Don't declare.
5366         (push_typelist): Update.
5367         * parse.c (pop_typelist): Return a std::vector.
5368         (push_typelist): Take a std::vector.
5369         (follow_types): Update.  Do not free args.
5370         (type_stack_cleanup): Remove.
5371         * c-exp.y (struct c_parse_state): New.
5372         (cpstate): New global.
5373         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5374         (nonempty_typelist): Update.
5375         (func_mod): Create a new vector.
5376         (c_parse): Create a c_parse_state.
5377         (check_parameter_typelist): Do not delete params.
5378         (function_method): Update.  Do not delete type_list.
5379
5380 2019-01-06  Tom Tromey  <tom@tromey.com>
5381
5382         PR gdb/28155:
5383         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5384         check_typedef.
5385         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5386         (print_return_value): Likewise.
5387
5388 2019-01-05  Tom Tromey  <tom@tromey.com>
5389
5390         * contrib/cleanup_check.py: Remove.
5391         * contrib/gcc-with-excheck: Remove.
5392         * contrib/exsummary.py: Remove.
5393         * contrib/excheck.py: Remove.
5394
5395 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5396
5397         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5398         NULL. Initialize tpprev to NULL instead of assigning it
5399         to NULL on the next statement.
5400         * windows-nat.c (windows_delete_thread): Remove check for
5401         main_thread_id before printing thread exit notifications.
5402         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5403         Remove thread ID check against main_thread_id.
5404         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5405         windows_delete_thread.
5406         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5407
5408 2019-01-04  Tom Tromey  <tom@tromey.com>
5409
5410         * compile/compile.c (_initialize_compile): Use upper case for
5411         metasyntactic variables.
5412         * symmisc.c (_initialize_symmisc): Use upper case for
5413         metasyntactic variables.
5414         * psymtab.c (_initialize_psymtab): Use upper case for
5415         metasyntactic variables.
5416         * demangle.c (demangle_command): Use upper case for metasyntactic
5417         variables.
5418         (_initialize_demangler): Likewise.
5419         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5420         variables.
5421
5422 2019-01-03  Tom Tromey  <tom@tromey.com>
5423
5424         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5425
5426 2019-01-03  Tom Tromey  <tom@tromey.com>
5427
5428         * python/py-symtab.c (salpy_str): Update.
5429         (struct salpy_sal_object) <symtab>: Now a PyObject.
5430         (salpy_dealloc): Update.
5431         (del_objfile_sal): Use gdbpy_ref.
5432
5433 2019-01-03  Tom Tromey  <tom@tromey.com>
5434
5435         * python/py-type.c (convert_field): Use new_reference.  Return
5436         gdbpy_ref.
5437         (make_fielditem): Return gdbpy_ref.
5438         (typy_fields): Update.
5439         (typy_getitem): Update.
5440         (field_name): Return gdbpy_ref.  Use new_reference.
5441         (typy_iterator_iternext): Update.
5442
5443 2019-01-03  Tom Tromey  <tom@tromey.com>
5444
5445         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5446
5447 2019-01-03  Tom Tromey  <tom@tromey.com>
5448
5449         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5450         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5451         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5452         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5453         (pspy_set_type_printers): Likewise.
5454         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5455         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5456         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5457         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5458         (objfpy_set_type_printers): Likewise.
5459
5460 2019-01-03  Tom Tromey  <tom@tromey.com>
5461
5462         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5463         (gdbpy_print_stack): Use gdbpy_err_fetch.
5464         * python/python-internal.h (class gdbpy_err_fetch): New class.
5465         (class gdbpy_enter) <m_error_type, m_error_value,
5466         m_error_traceback>: Remove.
5467         <m_error>: New member.
5468         (gdbpy_exception_to_string): Don't declare.
5469         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5470         * python/py-value.c (convert_value_from_python): Use
5471         gdbpy_err_fetch.
5472         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5473         gdbpy_exception_to_string.
5474         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5475         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5476         gdbpy_err_fetch.
5477
5478 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5479
5480         * linux-nat.c (delete_lwp_cleanup): Delete.
5481         (struct lwp_deleter): New struct.
5482         (lwp_info_up): New typedef.
5483         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5484         lwp_info_up.
5485
5486 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5487
5488         * linux-fork.c (class scoped_switch_fork_info): New class.
5489         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5490
5491 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5492
5493         * valops.c (find_overload_match): Remove use of null_cleanup, and
5494         calls to do_cleanups.
5495
5496 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5497
5498         * compile/compile-cplus-types.c
5499         (compile_cplus_instance::decl_name): Handle changes to
5500         cp_func_name.
5501         * cp-support.c (cp_func_name): Update header comment, update
5502         return type.
5503         * cp-support.h (cp_func_name): Update return type in declaration.
5504         * valops.c (find_overload_match): Move temp_func local to top
5505         level of function and change its type.  Use temp_func to hold and
5506         delete temporary string obtained from cp_func_name.
5507
5508 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5509
5510         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5511         gdb::char_vector, remove cleanup, and update uses of `msg`.
5512
5513 2019-01-03  Jim Wilson  <jimw@sifive.com>
5514
5515         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5516
5517 2019-01-02  Tom Tromey  <tom@tromey.com>
5518
5519         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5520         (tdesc_parse_xml): Remove cleanups.
5521         * target-descriptions.h (make_cleanup_free_target_description):
5522         Don't declare.
5523         (target_desc_deleter): New struct.
5524         (target_desc_up): New typedef.
5525         * target-descriptions.c (target_desc_deleter::operator()): Rename
5526         from free_target_description.
5527         (make_cleanup_free_target_description): Remove.
5528
5529 2019-01-02  Tom Tromey  <tom@tromey.com>
5530
5531         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5532         constructor, destructor.
5533         (linespec_parser): Remove typedef.
5534         (~linespec_parser): Rename from linespec_parser_delete.
5535         (linespec_lex_to_end, linespec_complete_label)
5536         (linespec_complete): Update.
5537         (decode_line_full): Remove cleanups.
5538         (decode_line_1): Update.
5539
5540 2019-01-02  Tom Tromey  <tom@tromey.com>
5541
5542         * python/python-internal.h (inferior_to_inferior_object): Change
5543         return type.
5544         * python/py-exitedevent.c (create_exited_event_object): Update.
5545         * python/py-inferior.c (inferior_to_inferior_object): Return
5546         gdbpy_ref.
5547         (python_new_inferior, python_inferior_deleted)
5548         (thread_to_thread_object, delete_thread_object)
5549         (build_inferior_list, gdbpy_selected_inferior): Update.
5550         * python/py-infthread.c (create_thread_object): Update.  Also fail
5551         if inferior_to_inferior_object fails.
5552
5553 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5554
5555         * inferior.h (class inferior) <displaced_step_state>: New field.
5556         * infrun.h (struct displaced_step_state): Move here from
5557         infrun.c.  Initialize fields, add constructor.
5558         <inf>: Remove field.
5559         <reset>: New method.
5560         * infrun.c (struct displaced_step_inferior_state): Move to
5561         infrun.h.
5562         (displaced_step_inferior_states): Remove.
5563         (get_displaced_stepping_state): Adust.
5564         (displaced_step_in_progress_any_inferior): Adjust.
5565         (displaced_step_in_progress_thread): Adjust.
5566         (displaced_step_in_progress): Adjust.
5567         (add_displaced_stepping_state): Remove.
5568         (get_displaced_step_closure_by_addr): Adjust.
5569         (remove_displaced_stepping_state): Remove.
5570         (infrun_inferior_exit): Call displaced_step_state.reset.
5571         (use_displaced_stepping): Don't check for NULL.
5572         (displaced_step_prepare_throw): Call
5573         get_displaced_stepping_state.
5574         (displaced_step_fixup): Don't check for NULL.
5575         (prepare_for_detach): Don't check for NULL.
5576
5577 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5578
5579         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5580          in case of call that did not complete.
5581
5582 2019-01-02  Andrey Utkin  <autkin@undo.io>
5583
5584         * symfile.c (find_separate_debug_file): Fix search of debug files for
5585         remote debuggee.
5586
5587 2019-01-02  Tom Tromey  <tom@tromey.com>
5588
5589         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5590         indentation.
5591         * python/py-frame.c (frapy_older): Remove cast.
5592         (frapy_newer): Likewise.
5593         * python/py-breakpoint.c (local_setattro): Remove cast.
5594         * python/py-arch.c (archpy_name): Remove local variable.
5595         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5596
5597 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5598
5599         * unittests/basic_string_view/element_access/char/empty.cc:
5600         Fix year range in copyright header.
5601
5602 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5603
5604         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5605         Delete.
5606         <operator==>: Update with for removed field.
5607         <hash>: Likewise.
5608         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5609         <isa_features>: ...this.
5610         <abi_features>: New field.
5611         (riscv_isa_flen): Update comment.
5612         (riscv_abi_xlen): New declaration.
5613         (riscv_abi_flen): New declaration.
5614         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5615         isa_features.
5616         (riscv_abi_xlen): New function.
5617         (riscv_isa_flen): Update to get answer from isa_features.
5618         (riscv_abi_flen): New function.
5619         (riscv_has_fp_abi): Update to get answer from abi_features.
5620         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5621         xlen and flen.
5622         (riscv_call_info) <xlen, flen>: Update comment.
5623         (riscv_call_arg_struct): Remove invalid assertions
5624         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5625         is removed.
5626         (riscv_gdbarch_init): Gather isa features and abi features
5627         separately, ensure both match on the gdbarch when reusing an old
5628         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5629         a target with 64-bit float hardware.
5630
5631 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5632
5633         * source.c (search_command_helper): Stop reverse search
5634         when line 1 has been searched.
5635
5636 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5637
5638         * record-full.c (record_full_base_target::close): Rewrite
5639         record_full_core_buf_list free logic.
5640
5641 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5642
5643         * break-catch-syscall.c (print_one_catch_syscall): xfree
5644         the last text.
5645
5646 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5647
5648         * top.c (print_gdb_version): Update Copyright year in version
5649         message.
5650
5651 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5652
5653         Update copyright year range in all GDB files.
5654
5655 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5656
5657         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5658
5659 For older changes see ChangeLog-2018.
5660 \f
5661 Local Variables:
5662 mode: change-log
5663 left-margin: 8
5664 fill-column: 74
5665 version-control: never
5666 coding: utf-8
5667 End:
5668