gdb/ChangeLog

   1 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
   2
   3         * windows-nat.c [_WIN32_WINNT]: Define _WIN32_WINNT to Windows XP
   4         level, so that various Windows header files expose the necessary
   5         declarations and definitions.
   6
   7         * symfile.c (find_separate_debug_file): Remove colon from the
   8         drive spec of DOS/Windows file names of the target, so that the
   9         file name produced from DEBUGDIR and the target's directory will
  10         be valid on DOS/Windows systems.
  11
  12 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  13
  14         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
  15         Use current_event.dwThreadId instead of main_thread_id.
  16
  17 2019-04-30  Tom Tromey  <tromey@adacore.com>
  18
  19         PR c++/24470:
  20         * dwarf2read.c (process_structure_scope): Handle case where type
  21         has template parameters but no symbol was created.
  22
  23 2019-04-19  Sergei Trofimovich <siarheit@google.com>
  24
  25         * configure.ac: add --enable-source-highlight switch.
  26         * configure: Regenerate.
  27         * top.c (print_gdb_version): plumb --enable-source-highlight
  28         status to "show configuration".
  29
  30 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
  31
  32         PR symtab/24423:
  33         * source.c (print_source_lines_base): Advance "iter" when a
  34         control character is seen.
  35
  36 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  37
  38         * inferior.h (struct infcall_suspend_state_deleter):
  39         Catch exception in destructor to avoid crash.
  40
  41 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
  42
  43         * utils.c (prompt_for_continue): Don't restore the styling at the
  44         end, as applied_style has the wrong value.  This fixes styling in
  45         long lists of file names that are interrupted by the "Continue?"
  46         prompt.
  47
  48 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  49
  50         * version.in: Set GDB version number to 8.2.91.DATE-git.
  51
  52 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  53
  54         GDB 8.2.91 released.
  55
  56 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  57
  58         * version.in: Set GDB version number to 8.2.91.
  59
  60 2019-03-20  Tom Tromey  <tromey@adacore.com>
  61
  62         PR gdb/24391
  63         * infrun.c (handle_inferior_event): Rename from
  64         handle_inferior_event_1.  Create a scoped_value_mark.
  65         (handle_inferior_event): Remove.
  66
  67 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
  68
  69         * source-cache.c (source_cache::get_source_lines): Re-read
  70         fullname after calling open_source_file.
  71
  72 2019-03-18  Pedro Alves  <palves@redhat.com>
  73             Eli Zaretskii <eliz@gnu.org>
  74
  75         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
  76         m_line and m_start_of_line.
  77
  78 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
  79
  80         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
  81         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
  82         it returns a newline.  This fixes a regression in TU mode, whereby
  83         the next line is output on the same screen line as the user input.
  84
  85 2019-03-18  Pedro Alves  <palves@redhat.com>
  86
  87         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
  88         New globals.
  89         (apply_style): New, factored out from ...
  90         (apply_ansi_escape): ... this.  Handle reverse video mode.
  91         (tui_set_reverse_mode): New function.
  92         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
  93         * tui/tui-winsource.c (tui_show_source_line): Use
  94         tui_set_reverse_mode instead of setting A_STANDOUT.
  95         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
  96         New setter methods.
  97
  98 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
  99
 100         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 101         Handle tabs.
 102
 103 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 104
 105         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 106         tui_refill_source_window instead of tui_refresh_win, to update the
 107         current execution line.  This fixes redisplay of the current line
 108         when stepping through the code with "next" or "step".
 109
 110 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 111
 112         * source-cache.c (source_cache::get_source_lines): Call
 113         find_source_lines to initialize s->nlines.  This fixes vertical
 114         scrolling of TUI source window when the DOWN arrow is pressed.
 115
 116 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 117
 118         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 119         wclrtoeol in tui_show_source_line".  This reverts changes made in
 120         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 121
 122 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 123
 124         * NEWS: Combine separate "New targets" sections for 8.3.
 125
 126 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 127
 128         The MS-Windows port of ncurses fails to switch to a color pair if
 129         one or both of the colors are the implicit default colors.  This
 130         change records the default colors when TUI is initialized, and
 131         then specifies them explicitly when a color pair uses the default
 132         colors.  This allows color styling in TUI mode on MS-Windows.
 133
 134         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 135         ncurses_norm_attr.
 136         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 137         colors in ncurses_norm_attr.
 138         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 139         "none", replace it with the default color recorded in
 140         ncurses_norm_attr.
 141
 142 2019-03-14  Tom Tromey  <tromey@adacore.com>
 143
 144         * source-cache.h (class source_cache) <get_source_lines>: Return
 145         std::string.
 146         * source-cache.c (source_cache::extract_lines): Handle case where
 147         first_pos==npos.  Return std::string.
 148         (source_cache::get_source_lines): Update.
 149
 150 2019-03-14  Tom Tromey  <tromey@adacore.com>
 151
 152         * NEWS: Add item for "style sources" commands.
 153         * source-cache.c (source_cache::get_source_lines): Check
 154         source_styling.
 155         * cli/cli-style.c (source_styling): New global.
 156         (_initialize_cli_style): Add "style sources" commands.
 157         (show_style_sources): New function.
 158         * cli/cli-style.h (source_styling): Declare.
 159
 160 2019-03-14  Pedro Alves  <palves@redhat.com>
 161             Tom Tromey  <tromey@adacore.com>
 162
 163         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 164         * tui/tui-winsource.c (tui_refill_source_window): New function,
 165         from...
 166         (tui_horizontal_source_scroll): ... here.  Move some logic.
 167         * cli/cli-style.c (set_style_enabled): Notify new observable.
 168         * tui/tui-hooks.c (tui_redisplay_source): New function.
 169         (tui_attach_detach_observers): Attach or detach
 170         tui_redisplay_source.
 171         * observable.h (source_styling_changed): New observable.
 172         * observable.c: Define source_styling_changed observable.
 173
 174 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 175
 176         PR/24325
 177         * source-cache.c: #undef open and close, to avoid unresolved
 178         externals during linking.
 179
 180 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 181
 182         Support styling on native MS-Windows console
 183
 184         PR/24315
 185         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 186         on MS-Windows if $TERM is not defined.
 187
 188         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 189
 190         * posix-hdep.c (gdb_console_fputs):
 191         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 192         functions.
 193         * ui-file.h (gdb_console_fputs): Add prototype.
 194
 195         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 196         back to fputs only if the former returns zero.
 197
 198 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
 199             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 200
 201         PR gdb/8527
 202         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 203         set_sigint_trap, clear_sigint_trap.
 204
 205 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 206
 207         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 208         for-loop range, to avoid compiler warnings.
 209
 210         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 211         avoid compiler warnings about unused variables.
 212
 213 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 214
 215         * NEWS: Mention end of support for native debugging on MS-Windows
 216         before XP.
 217
 218 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 219
 220         PR gdb/24292
 221         * common/netstuff.c:
 222         * gdbserver/gdbreplay.c
 223         * gdbserver/remote-utils.c:
 224         * ser-tcp.c:
 225         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 226         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 227         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 228         'getaddrinfo' and 'freeaddrinfo' were not available before
 229         Windows XP, and mingw.org's MinGW headers by default define
 230         _WIN32_WINNT to 0x500.
 231
 232 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 233
 234         * NEWS: Note minimum Python version.
 235
 236 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 237
 238         * version.in: Set GDB version number to 8.2.90.DATE-git.
 239
 240 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 241
 242         GDB 8.2.90 released.
 243
 244 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 245
 246         * version.in: Set GDB version number to 8.2.90.
 247
 248 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 249
 250         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
 251
 252 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 253
 254         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 255         * version.in: Bump version to 8.2.90.DATE-git.
 256
 257 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 258
 259         * aix-thread.c (ptid_cmp): Remove unused variable.
 260         (get_signaled_thread): Likewise.
 261         (store_regs_user_thread): Likewise.
 262         (store_regs_kernel_thread): Likewise.
 263         (fetch_regs_kernel_thread): Remove shadowed variable.
 264
 265 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 266
 267         * features/riscv/32bit-cpu.xml: Add register numbers.
 268         * features/riscv/32bit-fpu.c: Regenerate.
 269         * features/riscv/32bit-fpu.xml: Add register numbers.
 270         * features/riscv/64bit-cpu.xml: Add register numbers.
 271         * features/riscv/64bit-fpu.c: Regenerate.
 272         * features/riscv/64bit-fpu.xml: Add register numbers.
 273
 274 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 275
 276         * NEWS: Mention two argument form of gdb.Value constructor.
 277         * python/py-value.c (convert_buffer_and_type_to_value): New
 278         function.
 279         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 280         Add support for handling an optional second argument.  Call
 281         convert_buffer_and_type_to_value as appropriate.
 282         * python/python-internal.h (Py_buffer_deleter): New struct.
 283         (Py_buffer_up): New typedef.
 284
 285 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 286
 287         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 288         instead of releasing ownership.
 289
 290 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 291
 292         * dwarf2read.c (open_and_init_dwp_file): Call
 293         elf_numsections instead of bfd_count_sections to initialize
 294         dwp_file->num_sections.
 295
 296 2019-02-25  Tom Tromey  <tromey@adacore.com>
 297
 298         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 299
 300 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 301
 302         * gcore.in: Add '--readnever' option when invoking GDB.
 303
 304 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 305
 306         * MAINTAINERS: Update my email address.
 307
 308 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 309
 310         * build-id.c (build_id_to_debug_bfd_1): New function.
 311         (build_id_to_debug_bfd): Look for separate debug file in
 312         sysroot.
 313
 314 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 315
 316         * gdbarch.sh: Update the copyright year range that is placed into
 317         generated files.
 318
 319 2019-02-22  Keith Seitz  <keiths@redhat.com>
 320
 321         PR symtab/23853
 322         * linespec.c (create_sals_line_offset): Search for the default
 323         symtab's filename instead of its fullname.
 324
 325 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 326
 327         * NEWS: Update style defaults.
 328
 329 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 330
 331         * main.c (captured_main_1): Disable styling in batch mode.
 332
 333 2019-02-20  Tom Tromey  <tom@tromey.com>
 334
 335         * symtab.c (symtab_symbol_info): Fix typos.
 336
 337 2019-02-20  Tom Tromey  <tromey@adacore.com>
 338
 339         * findcmd.c (_initialize_mem_search): Use upper case for
 340         metasyntactic variables.
 341
 342 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 343
 344         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 345         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 346
 347 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 348
 349         * top.h (source_file_name): Change to std::string.
 350         * top.c (source_file_name): Likewise.
 351         (command_line_input): Adjust.
 352         * cli/cli-script.c (script_from_file): Adjust.
 353
 354 2019-02-19  Tom Tromey  <tromey@adacore.com>
 355
 356         * ravenscar-thread.c
 357         (ravenscar_thread_target::update_thread_list): Don't call
 358         ada_build_task_list.
 359         * ada-lang.h (ada_build_task_list): Don't declare.
 360         * ada-tasks.c (struct ada_tasks_inferior_data)
 361         <task_list_valid_p>: Now bool.
 362         (read_known_tasks, ada_task_list_changed)
 363         (ada_tasks_invalidate_inferior_data): Update.
 364         (read_known_tasks_array): Return bool.
 365         (read_known_tasks_list): Likewise.
 366         (read_known_tasks): Return void.
 367         (ada_build_task_list): Now static.
 368
 369 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 370
 371         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 372         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 373
 374 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 375
 376         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 377         variant for ada_tasks_pspace_data_handle and
 378         ada_tasks_inferior_data_handle.
 379         (ada_tasks_pspace_data_cleanup): New function.
 380         (ada_tasks_inferior_data_cleanup): New function.
 381
 382 2019-02-17  Tom Tromey  <tom@tromey.com>
 383
 384         * macrotab.h (macro_source_fullname): Return a std::string.
 385         * macrotab.c (macro_include, check_for_redefinition)
 386         (macro_undef, macro_lookup_definition, foreach_macro)
 387         (foreach_macro_in_scope): Update.
 388         (macro_source_fullname): Return a std::string.
 389         * macrocmd.c (show_pp_source_pos): Update.
 390
 391 2019-02-17  Tom Tromey  <tom@tromey.com>
 392
 393         * macrocmd.c (show_pp_source_pos): Style the file names.
 394
 395 2019-02-17  Tom Tromey  <tom@tromey.com>
 396
 397         PR tui/24197:
 398         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 399
 400 2019-02-17  Tom Tromey  <tom@tromey.com>
 401
 402         * ada-lang.c (user_select_syms): Use filtered printing.
 403         * utils.c (wrap_style): New global.
 404         (desired_style): Remove.
 405         (emit_style_escape): Add stream parameter.
 406         (set_output_style, reset_terminal_style, prompt_for_continue):
 407         Update.
 408         (flush_wrap_buffer): Only flush gdb_stdout.
 409         (wrap_here): Set wrap_style.
 410         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 411         treat escape sequences as a character.  Change when wrap buffer is
 412         flushed.
 413         (fputs_styled): Do not set the output style when the default is
 414         requested.
 415         * ui-style.h (struct ui_file_style) <is_default>: New method.
 416         * source.c (print_source_lines_base): Emit escape sequences in one
 417         piece.
 418
 419 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 420
 421         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 422         integers and enumeration types.
 423
 424 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 425
 426         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 427         instead of lookup_symbol_in_language
 428         (do_exact_match): New function.
 429         (ada_get_symbol_name_matcher): Return do_exact_match when
 430         doing a verbatim match.
 431
 432 2019-02-15  Tom Tromey  <tromey@adacore.com>
 433
 434         * ravenscar-thread.c (ravenscar_thread_target::resume)
 435         (ravenscar_thread_target::wait): Special case wildcard requests.
 436
 437 2019-02-15  Tom Tromey  <tromey@adacore.com>
 438
 439         * ravenscar-thread.c (base_ptid): Remove.
 440         (struct ravenscar_thread_target) <close>: New method.
 441         <m_base_ptid>: New member.
 442         <update_inferior_ptid, active_task, task_is_currently_active,
 443         runtime_initialized>: Declare methods.
 444         <ravenscar_thread_target>: Add constructor.
 445         (ravenscar_thread_target::task_is_currently_active)
 446         (ravenscar_thread_target::update_inferior_ptid)
 447         (ravenscar_runtime_initialized): Rename.  Now methods.
 448         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 449         (ravenscar_thread_target::update_thread_list): Update.
 450         (ravenscar_thread_target::active_task): Now method.
 451         (ravenscar_thread_target::store_registers)
 452         (ravenscar_thread_target::prepare_to_store)
 453         (ravenscar_thread_target::prepare_to_store)
 454         (ravenscar_thread_target::mourn_inferior): Update.
 455         (ravenscar_inferior_created): Use "new" to create target.
 456         (ravenscar_thread_target::get_ada_task_ptid): Update.
 457         (_initialize_ravenscar): Don't initialize base_ptid.
 458         (ravenscar_ops): Remove global.
 459
 460 2019-02-15  Tom Tromey  <tromey@adacore.com>
 461
 462         * target.h (push_target): Declare new overload.
 463         * target.c (push_target): New overload, taking an rvalue reference.
 464         * remote.c (remote_target::open_1): Use push_target overload.
 465         * corelow.c (core_target_open): Use push_target overload.
 466
 467 2019-02-15  Tom Tromey  <tromey@adacore.com>
 468
 469         * ravenscar-thread.c (is_ravenscar_task)
 470         (ravenscar_task_is_currently_active): Return bool.
 471         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 472         (_initialize_ravenscar): Remove "(void)".
 473         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 474         Return bool.
 475
 476 2019-02-15  Tom Tromey  <tromey@adacore.com>
 477
 478         * ravenscar-thread.c (ravenscar_runtime_initializer)
 479         (has_ravenscar_runtime, get_running_thread_id)
 480         (ravenscar_thread_target::resume): Fix indentation.
 481
 482 2019-02-15  Tom Tromey  <tromey@adacore.com>
 483
 484         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 485         from ravenscar_arch_ops.
 486         (sparc_ravenscar_ops::fetch_registers)
 487         (sparc_ravenscar_ops::store_registers): Now methods.
 488         (sparc_ravenscar_prepare_to_store): Remove.
 489         (sparc_ravenscar_ops): Redefine.
 490         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 491         methods and destructor.  Remove members.
 492         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 493         (ravenscar_thread_target::store_registers)
 494         (ravenscar_thread_target::prepare_to_store): Update.
 495         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 496         Remove.
 497         (struct ppc_ravenscar_powerpc_ops): Derive from
 498         ravenscar_arch_ops.
 499         (ppc_ravenscar_powerpc_ops::fetch_registers)
 500         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 501         (ppc_ravenscar_powerpc_ops): Redefine.
 502         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 503         (ppc_ravenscar_e500_ops::fetch_registers)
 504         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 505         (ppc_ravenscar_e500_ops): Redefine.
 506         * aarch64-ravenscar-thread.c
 507         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 508         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 509         (aarch64_ravenscar_fetch_registers)
 510         (aarch64_ravenscar_store_registers): Now methods.
 511         (aarch64_ravenscar_ops): Redefine.
 512
 513 2019-02-15  Tom Tromey  <tromey@adacore.com>
 514
 515         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 516         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 517         (ravenscar_thread_target::stopped_by_watchpoint)
 518         (ravenscar_thread_target::stopped_data_address)
 519         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 520
 521 2019-02-15  Tom Tromey  <tromey@adacore.com>
 522
 523         * ravenscar-thread.c: Fix some typos.
 524
 525 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 526             Tom Tromey  <tromey@adacore.com>
 527
 528         * ada-lang.c (ada_exception_sal): Change addr_string to a
 529         std::string.
 530         (create_ada_exception_catchpoint): Update.
 531
 532 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 533             Tom Tromey  <tromey@adacore.com>
 534
 535         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 536         (bp_location_ops): Remove.
 537         (base_breakpoint_allocate_location): Update.
 538         (free_bp_location): Update.
 539         * ada-lang.c (class ada_catchpoint_location)
 540         <ada_catchpoint_location>: Remove ops parameter.
 541         (ada_catchpoint_location_dtor): Remove.
 542         (ada_catchpoint_location_ops): Remove.
 543         (allocate_location_exception): Update.
 544         * breakpoint.h (struct bp_location_ops): Remove.
 545         (class bp_location) <bp_location>: Remove bp_location_ops
 546         parameter.
 547         <~bp_location>: Add destructor.
 548         <ops>: Remove.
 549
 550 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 551             Pedro Alves  <palves@redhat.com>
 552
 553         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 554         'PATH_MAX'.
 555
 556 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 557             Samuel Thibault  <samuel.thibault@gnu.org>
 558             Thomas Schwinge  <thomas@codesourcery.com>
 559
 560         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 561         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 562
 563 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 564
 565         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 566         (check_empty): Use "const char *".
 567
 568         * gnu-nat.c (gnu_nat_target::detach): Instead of
 569         'detach_inferior (pid)' call
 570         'detach_inferior (find_inferior_pid (pid))'.
 571
 572         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 573         'nat/fork-inferior.o'.
 574         * gnu-nat.c: #include "nat/fork-inferior.h".
 575
 576         * gnu-nat.c (gnu_nat_target::detach): Instead of
 577         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 578         * gnu-nat.h: #include "inf-child.h".
 579         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 580         'i386_gnu_nat_target::fetch_registers'.
 581         (gnu_store_registers): Rename/move to
 582         'i386_gnu_nat_target::store_registers'.
 583
 584         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 585         * gnu-nat.h (mach_thread_info): New function.
 586         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 587
 588         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 589
 590 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 591
 592         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 593
 594 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 595
 596         * windows-nat.c (windows_add_thread): Add new parameter
 597         "main_thread_p" with default value set to false.  Update
 598         function documentation as well as all callers.
 599         (windows_delete_thread): Likewise.
 600         (fake_create_process): Update call to windows_add_thread.
 601         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 602         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 603         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 604         call to windows_delete_thread.
 605
 606 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 607
 608         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 609
 610 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 611
 612         * symfile.c (find_separate_debug_file): Use canonical path of
 613         sysroot with child_path instead of gdb_sysroot if it is valid.
 614
 615 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 616
 617         * symfile.c (find_separate_debug_file): Use child_path to
 618         determine if an object file is under a sysroot.
 619
 620 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 621
 622         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 623         unittests/child-path-selftests.c.
 624         * common/pathstuff.c (child_path): New function.
 625         * common/pathstuff.h (child_path): New prototype.
 626         * unittests/child-path-selftests.c: New file.
 627
 628 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 629
 630         * symfile.c (find_separate_debug_file): Look for separate debug
 631         files in debug directories under the sysroot.
 632
 633 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 634
 635         * symtab.h (struct minimal_symbol data_p): New const method.
 636         (struct minimal_symbol text_p): Likewise.
 637         * symtab.c (output_source_filename): Use file name style
 638         to print file name.
 639         (print_symbol_info): Likewise.
 640         (print_msymbol_info): Use address style to print addresses.
 641         Use function name style to print executable text symbols.
 642         (expand_symtab_containing_pc): Use data_p.
 643         (find_pc_sect_compunit_symtab): Likewise.
 644
 645 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 646
 647         * breakpoint.c (describe_other_breakpoints): Use address style
 648         to print addresses.
 649         (say_where): Likewise.
 650
 651 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 652
 653         * ada-typeprint.c (print_func_type): Print function name
 654         style to print function name.
 655         * c-typeprint.c (c_print_type_1): Likewise.
 656
 657 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 658
 659         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 660         for execve.
 661
 662 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 663
 664         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 665         type_stack.
 666
 667 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 668
 669         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 670         TYPE_CODE_REF types.
 671
 672 2019-02-08  Jim Wilson  <jimw@sifive.com>
 673
 674         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 675         (riscv_linux_fregset): New.
 676         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 677
 678 2019-02-07  Tom Tromey  <tom@tromey.com>
 679
 680         * thread.c (thread_cancel_execution_command): Update.
 681         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 682         methods.
 683         (struct thread_fsm_ops): Remove.
 684         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 685         (thread_fsm_should_stop, thread_fsm_return_value)
 686         (thread_fsm_set_finished, thread_fsm_finished_p)
 687         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 688         Don't declare.
 689         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 690         * infrun.c (clear_proceed_status_thread)
 691         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 692         (print_stop_event): Update.
 693         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 694         Add constructor.
 695         (step_command_fsm_ops): Remove.
 696         (new_step_command_fsm): Remove.
 697         (step_1): Update.
 698         (step_command_fsm::should_stop): Rename from
 699         step_command_fsm_should_stop.
 700         (step_command_fsm::clean_up): Rename from
 701         step_command_fsm_clean_up.
 702         (step_command_fsm::do_async_reply_reason): Rename from
 703         step_command_fsm_async_reply_reason.
 704         (struct until_next_fsm): Inherit from thread_fsm.  Add
 705         constructor.
 706         (until_next_fsm_ops): Remove.
 707         (new_until_next_fsm): Remove.
 708         (until_next_fsm::should_stop): Rename from
 709         until_next_fsm_should_stop.
 710         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 711         (until_next_fsm::do_async_reply_reason): Rename from
 712         until_next_fsm_async_reply_reason.
 713         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 714         constructor.  Change type of breakpoint.
 715         (finish_command_fsm_ops): Remove.
 716         (new_finish_command_fsm): Remove.
 717         (finish_command_fsm::should_stop): Rename from
 718         finish_command_fsm_should_stop.
 719         (finish_command_fsm::clean_up): Rename from
 720         finish_command_fsm_clean_up.
 721         (finish_command_fsm::return_value): Rename from
 722         finish_command_fsm_return_value.
 723         (finish_command_fsm::do_async_reply_reason): Rename from
 724         finish_command_fsm_async_reply_reason.
 725         (finish_command): Update.
 726         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 727         Add constructor.
 728         (call_thread_fsm_ops): Remove.
 729         (call_thread_fsm::call_thread_fsm): Rename from
 730         new_call_thread_fsm.
 731         (call_thread_fsm::should_stop): Rename from
 732         call_thread_fsm_should_stop.
 733         (call_thread_fsm::should_notify_stop): Rename from
 734         call_thread_fsm_should_notify_stop.
 735         (run_inferior_call, call_function_by_hand_dummy): Update.
 736         * cli/cli-interp.c (should_print_stop_to_console): Update.
 737         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 738         Add constructor.  Change type of location_breakpoint,
 739         caller_breakpoint.
 740         (until_break_fsm_ops): Remove.
 741         (new_until_break_fsm): Remove.
 742         (until_break_fsm::should_stop): Rename from
 743         until_break_fsm_should_stop.
 744         (until_break_fsm::clean_up): Rename from
 745         until_break_fsm_clean_up.
 746         (until_break_fsm::do_async_reply_reason): Rename from
 747         until_break_fsm_async_reply_reason.
 748         (until_break_command): Update.
 749         * thread-fsm.c: Remove.
 750         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 751
 752 2019-02-07  Tom Tromey  <tom@tromey.com>
 753
 754         * yy-remap.h: Add include guard.
 755         * xtensa-tdep.h: Add include guard.
 756         * xcoffread.h: Rename include guard.
 757         * varobj-iter.h: Add include guard.
 758         * tui/tui.h: Rename include guard.
 759         * tui/tui-winsource.h: Rename include guard.
 760         * tui/tui-wingeneral.h: Rename include guard.
 761         * tui/tui-windata.h: Rename include guard.
 762         * tui/tui-win.h: Rename include guard.
 763         * tui/tui-stack.h: Rename include guard.
 764         * tui/tui-source.h: Rename include guard.
 765         * tui/tui-regs.h: Rename include guard.
 766         * tui/tui-out.h: Rename include guard.
 767         * tui/tui-layout.h: Rename include guard.
 768         * tui/tui-io.h: Rename include guard.
 769         * tui/tui-hooks.h: Rename include guard.
 770         * tui/tui-file.h: Rename include guard.
 771         * tui/tui-disasm.h: Rename include guard.
 772         * tui/tui-data.h: Rename include guard.
 773         * tui/tui-command.h: Rename include guard.
 774         * tic6x-tdep.h: Add include guard.
 775         * target/waitstatus.h: Rename include guard.
 776         * target/wait.h: Rename include guard.
 777         * target/target.h: Rename include guard.
 778         * target/resume.h: Rename include guard.
 779         * target-float.h: Rename include guard.
 780         * stabsread.h: Add include guard.
 781         * rs6000-tdep.h: Add include guard.
 782         * riscv-fbsd-tdep.h: Add include guard.
 783         * regformats/regdef.h: Rename include guard.
 784         * record.h: Rename include guard.
 785         * python/python.h: Rename include guard.
 786         * python/python-internal.h: Rename include guard.
 787         * python/py-stopevent.h: Rename include guard.
 788         * python/py-ref.h: Rename include guard.
 789         * python/py-record.h: Rename include guard.
 790         * python/py-record-full.h: Rename include guard.
 791         * python/py-record-btrace.h: Rename include guard.
 792         * python/py-instruction.h: Rename include guard.
 793         * python/py-events.h: Rename include guard.
 794         * python/py-event.h: Rename include guard.
 795         * procfs.h: Add include guard.
 796         * proc-utils.h: Add include guard.
 797         * p-lang.h: Add include guard.
 798         * or1k-tdep.h: Rename include guard.
 799         * observable.h: Rename include guard.
 800         * nto-tdep.h: Rename include guard.
 801         * nat/x86-linux.h: Rename include guard.
 802         * nat/x86-linux-dregs.h: Rename include guard.
 803         * nat/x86-gcc-cpuid.h: Add include guard.
 804         * nat/x86-dregs.h: Rename include guard.
 805         * nat/x86-cpuid.h: Rename include guard.
 806         * nat/ppc-linux.h: Rename include guard.
 807         * nat/mips-linux-watch.h: Rename include guard.
 808         * nat/linux-waitpid.h: Rename include guard.
 809         * nat/linux-ptrace.h: Rename include guard.
 810         * nat/linux-procfs.h: Rename include guard.
 811         * nat/linux-osdata.h: Rename include guard.
 812         * nat/linux-nat.h: Rename include guard.
 813         * nat/linux-namespaces.h: Rename include guard.
 814         * nat/linux-btrace.h: Rename include guard.
 815         * nat/glibc_thread_db.h: Rename include guard.
 816         * nat/gdb_thread_db.h: Rename include guard.
 817         * nat/gdb_ptrace.h: Rename include guard.
 818         * nat/fork-inferior.h: Rename include guard.
 819         * nat/amd64-linux-siginfo.h: Rename include guard.
 820         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 821         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 822         * nat/aarch64-linux.h: Rename include guard.
 823         * nat/aarch64-linux-hw-point.h: Rename include guard.
 824         * mn10300-tdep.h: Add include guard.
 825         * mips-linux-tdep.h: Add include guard.
 826         * mi/mi-parse.h: Rename include guard.
 827         * mi/mi-out.h: Rename include guard.
 828         * mi/mi-main.h: Rename include guard.
 829         * mi/mi-interp.h: Rename include guard.
 830         * mi/mi-getopt.h: Rename include guard.
 831         * mi/mi-console.h: Rename include guard.
 832         * mi/mi-common.h: Rename include guard.
 833         * mi/mi-cmds.h: Rename include guard.
 834         * mi/mi-cmd-break.h: Rename include guard.
 835         * m2-lang.h: Add include guard.
 836         * location.h: Rename include guard.
 837         * linux-record.h: Rename include guard.
 838         * linux-nat.h: Add include guard.
 839         * linux-fork.h: Add include guard.
 840         * i386-darwin-tdep.h: Rename include guard.
 841         * hppa-linux-offsets.h: Add include guard.
 842         * guile/guile.h: Rename include guard.
 843         * guile/guile-internal.h: Rename include guard.
 844         * gnu-nat.h: Rename include guard.
 845         * gdb-stabs.h: Rename include guard.
 846         * frv-tdep.h: Add include guard.
 847         * f-lang.h: Add include guard.
 848         * event-loop.h: Add include guard.
 849         * darwin-nat.h: Rename include guard.
 850         * cp-abi.h: Rename include guard.
 851         * config/sparc/nm-sol2.h: Rename include guard.
 852         * config/nm-nto.h: Rename include guard.
 853         * config/nm-linux.h: Add include guard.
 854         * config/i386/nm-i386gnu.h: Rename include guard.
 855         * config/djgpp/nl_types.h: Rename include guard.
 856         * config/djgpp/langinfo.h: Rename include guard.
 857         * compile/gcc-cp-plugin.h: Add include guard.
 858         * compile/gcc-c-plugin.h: Add include guard.
 859         * compile/compile.h: Rename include guard.
 860         * compile/compile-object-run.h: Rename include guard.
 861         * compile/compile-object-load.h: Rename include guard.
 862         * compile/compile-internal.h: Rename include guard.
 863         * compile/compile-cplus.h: Rename include guard.
 864         * compile/compile-c.h: Rename include guard.
 865         * common/xml-utils.h: Rename include guard.
 866         * common/x86-xstate.h: Rename include guard.
 867         * common/version.h: Rename include guard.
 868         * common/vec.h: Rename include guard.
 869         * common/tdesc.h: Rename include guard.
 870         * common/selftest.h: Rename include guard.
 871         * common/scoped_restore.h: Rename include guard.
 872         * common/scoped_mmap.h: Rename include guard.
 873         * common/scoped_fd.h: Rename include guard.
 874         * common/safe-iterator.h: Rename include guard.
 875         * common/run-time-clock.h: Rename include guard.
 876         * common/refcounted-object.h: Rename include guard.
 877         * common/queue.h: Rename include guard.
 878         * common/ptid.h: Rename include guard.
 879         * common/print-utils.h: Rename include guard.
 880         * common/preprocessor.h: Rename include guard.
 881         * common/pathstuff.h: Rename include guard.
 882         * common/observable.h: Rename include guard.
 883         * common/netstuff.h: Rename include guard.
 884         * common/job-control.h: Rename include guard.
 885         * common/host-defs.h: Rename include guard.
 886         * common/gdb_wait.h: Rename include guard.
 887         * common/gdb_vecs.h: Rename include guard.
 888         * common/gdb_unlinker.h: Rename include guard.
 889         * common/gdb_unique_ptr.h: Rename include guard.
 890         * common/gdb_tilde_expand.h: Rename include guard.
 891         * common/gdb_sys_time.h: Rename include guard.
 892         * common/gdb_string_view.h: Rename include guard.
 893         * common/gdb_splay_tree.h: Rename include guard.
 894         * common/gdb_setjmp.h: Rename include guard.
 895         * common/gdb_ref_ptr.h: Rename include guard.
 896         * common/gdb_optional.h: Rename include guard.
 897         * common/gdb_locale.h: Rename include guard.
 898         * common/gdb_assert.h: Rename include guard.
 899         * common/filtered-iterator.h: Rename include guard.
 900         * common/filestuff.h: Rename include guard.
 901         * common/fileio.h: Rename include guard.
 902         * common/environ.h: Rename include guard.
 903         * common/common-utils.h: Rename include guard.
 904         * common/common-types.h: Rename include guard.
 905         * common/common-regcache.h: Rename include guard.
 906         * common/common-inferior.h: Rename include guard.
 907         * common/common-gdbthread.h: Rename include guard.
 908         * common/common-exceptions.h: Rename include guard.
 909         * common/common-defs.h: Rename include guard.
 910         * common/common-debug.h: Rename include guard.
 911         * common/cleanups.h: Rename include guard.
 912         * common/buffer.h: Rename include guard.
 913         * common/btrace-common.h: Rename include guard.
 914         * common/break-common.h: Rename include guard.
 915         * cli/cli-utils.h: Rename include guard.
 916         * cli/cli-style.h: Rename include guard.
 917         * cli/cli-setshow.h: Rename include guard.
 918         * cli/cli-script.h: Rename include guard.
 919         * cli/cli-interp.h: Rename include guard.
 920         * cli/cli-decode.h: Rename include guard.
 921         * cli/cli-cmds.h: Rename include guard.
 922         * charset-list.h: Add include guard.
 923         * buildsym-legacy.h: Rename include guard.
 924         * bfin-tdep.h: Add include guard.
 925         * ax.h: Rename include guard.
 926         * arm-linux-tdep.h: Add include guard.
 927         * arm-fbsd-tdep.h: Add include guard.
 928         * arch/xtensa.h: Rename include guard.
 929         * arch/tic6x.h: Add include guard.
 930         * arch/i386.h: Add include guard.
 931         * arch/arm.h: Rename include guard.
 932         * arch/arm-linux.h: Rename include guard.
 933         * arch/arm-get-next-pcs.h: Rename include guard.
 934         * arch/amd64.h: Add include guard.
 935         * arch/aarch64-insn.h: Rename include guard.
 936         * arch-utils.h: Rename include guard.
 937         * annotate.h: Add include guard.
 938         * amd64-darwin-tdep.h: Rename include guard.
 939         * aarch64-linux-tdep.h: Add include guard.
 940         * aarch64-fbsd-tdep.h: Add include guard.
 941         * aarch32-linux-nat.h: Add include guard.
 942
 943 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 944
 945         * macrotab.c (macro_define_internal): New function that
 946         factorizes macro_define_object_internal and macro_define_function
 947         code.
 948         (macro_define_object_internal): Use macro_define_internal.
 949         (macro_define_function): Likewise.
 950
 951 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 952
 953         * macrocmd.c (extract_identifier): Return
 954         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 955         callers.
 956
 957 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 958
 959         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 960
 961 2019-02-05  Tom Tromey  <tom@tromey.com>
 962
 963         * target.c (target_stack::unpush): Move assertion earlier.
 964
 965 2019-01-30  Tom Tromey  <tom@tromey.com>
 966
 967         PR python/23615:
 968         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 969         (gdbpy_parse_and_eval): Likewise.
 970         * python/python-internal.h (gdbpy_allow_threads): New class.
 971
 972 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 973
 974         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 975         (aarch64_fbsd_fpregmap): Move earlier.
 976         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 977         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 978         instead of individual calls to trad_frame_set_reg_addr.
 979         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 980         earlier.
 981         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 982         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 983         instead of individual calls to trad_frame_set_reg_addr.
 984
 985 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 986
 987         * CONTRIBUTE: Replace contribution list with wiki link.
 988
 989 2019-01-25  Tom Tromey  <tom@tromey.com>
 990
 991         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 992
 993 2019-01-25  Tom Tromey  <tom@tromey.com>
 994
 995         * xtensa-linux-nat.c: Fix common/ includes.
 996         * xml-support.h: Fix common/ includes.
 997         * xml-support.c: Fix common/ includes.
 998         * x86-linux-nat.c: Fix common/ includes.
 999         * windows-nat.c: Fix common/ includes.
1000         * varobj.h: Fix common/ includes.
1001         * varobj.c: Fix common/ includes.
1002         * value.c: Fix common/ includes.
1003         * valops.c: Fix common/ includes.
1004         * utils.c: Fix common/ includes.
1005         * unittests/xml-utils-selftests.c: Fix common/ includes.
1006         * unittests/utils-selftests.c: Fix common/ includes.
1007         * unittests/unpack-selftests.c: Fix common/ includes.
1008         * unittests/tracepoint-selftests.c: Fix common/ includes.
1009         * unittests/style-selftests.c: Fix common/ includes.
1010         * unittests/string_view-selftests.c: Fix common/ includes.
1011         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1012         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1013         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1014         * unittests/rsp-low-selftests.c: Fix common/ includes.
1015         * unittests/parse-connection-spec-selftests.c: Fix common/
1016         includes.
1017         * unittests/optional-selftests.c: Fix common/ includes.
1018         * unittests/offset-type-selftests.c: Fix common/ includes.
1019         * unittests/observable-selftests.c: Fix common/ includes.
1020         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1021         * unittests/memrange-selftests.c: Fix common/ includes.
1022         * unittests/memory-map-selftests.c: Fix common/ includes.
1023         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1024         * unittests/function-view-selftests.c: Fix common/ includes.
1025         * unittests/environ-selftests.c: Fix common/ includes.
1026         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1027         * unittests/common-utils-selftests.c: Fix common/ includes.
1028         * unittests/cli-utils-selftests.c: Fix common/ includes.
1029         * unittests/array-view-selftests.c: Fix common/ includes.
1030         * ui-file.c: Fix common/ includes.
1031         * tui/tui-io.c: Fix common/ includes.
1032         * tracepoint.h: Fix common/ includes.
1033         * tracepoint.c: Fix common/ includes.
1034         * tracefile-tfile.c: Fix common/ includes.
1035         * top.h: Fix common/ includes.
1036         * top.c: Fix common/ includes.
1037         * thread.c: Fix common/ includes.
1038         * target/waitstatus.h: Fix common/ includes.
1039         * target/waitstatus.c: Fix common/ includes.
1040         * target.h: Fix common/ includes.
1041         * target.c: Fix common/ includes.
1042         * target-memory.c: Fix common/ includes.
1043         * target-descriptions.c: Fix common/ includes.
1044         * symtab.h: Fix common/ includes.
1045         * symfile.c: Fix common/ includes.
1046         * stap-probe.c: Fix common/ includes.
1047         * spu-linux-nat.c: Fix common/ includes.
1048         * sparc-nat.c: Fix common/ includes.
1049         * source.c: Fix common/ includes.
1050         * solib.c: Fix common/ includes.
1051         * solib-target.c: Fix common/ includes.
1052         * ser-unix.c: Fix common/ includes.
1053         * ser-tcp.c: Fix common/ includes.
1054         * ser-pipe.c: Fix common/ includes.
1055         * ser-base.c: Fix common/ includes.
1056         * selftest-arch.c: Fix common/ includes.
1057         * s12z-tdep.c: Fix common/ includes.
1058         * rust-exp.y: Fix common/ includes.
1059         * rs6000-aix-tdep.c: Fix common/ includes.
1060         * riscv-tdep.c: Fix common/ includes.
1061         * remote.c: Fix common/ includes.
1062         * remote-notif.h: Fix common/ includes.
1063         * remote-fileio.h: Fix common/ includes.
1064         * remote-fileio.c: Fix common/ includes.
1065         * regcache.h: Fix common/ includes.
1066         * regcache.c: Fix common/ includes.
1067         * record-btrace.c: Fix common/ includes.
1068         * python/python.c: Fix common/ includes.
1069         * python/py-type.c: Fix common/ includes.
1070         * python/py-inferior.c: Fix common/ includes.
1071         * progspace.h: Fix common/ includes.
1072         * producer.c: Fix common/ includes.
1073         * procfs.c: Fix common/ includes.
1074         * proc-api.c: Fix common/ includes.
1075         * printcmd.c: Fix common/ includes.
1076         * ppc-linux-nat.c: Fix common/ includes.
1077         * parser-defs.h: Fix common/ includes.
1078         * osdata.c: Fix common/ includes.
1079         * obsd-nat.c: Fix common/ includes.
1080         * nat/x86-linux.c: Fix common/ includes.
1081         * nat/x86-linux-dregs.c: Fix common/ includes.
1082         * nat/x86-dregs.h: Fix common/ includes.
1083         * nat/x86-dregs.c: Fix common/ includes.
1084         * nat/ppc-linux.c: Fix common/ includes.
1085         * nat/mips-linux-watch.h: Fix common/ includes.
1086         * nat/mips-linux-watch.c: Fix common/ includes.
1087         * nat/linux-waitpid.c: Fix common/ includes.
1088         * nat/linux-ptrace.h: Fix common/ includes.
1089         * nat/linux-ptrace.c: Fix common/ includes.
1090         * nat/linux-procfs.c: Fix common/ includes.
1091         * nat/linux-personality.c: Fix common/ includes.
1092         * nat/linux-osdata.c: Fix common/ includes.
1093         * nat/linux-namespaces.c: Fix common/ includes.
1094         * nat/linux-btrace.h: Fix common/ includes.
1095         * nat/linux-btrace.c: Fix common/ includes.
1096         * nat/fork-inferior.c: Fix common/ includes.
1097         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1098         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1099         * nat/aarch64-linux.c: Fix common/ includes.
1100         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1101         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1102         * namespace.h: Fix common/ includes.
1103         * mips-linux-tdep.c: Fix common/ includes.
1104         * minsyms.c: Fix common/ includes.
1105         * mi/mi-parse.h: Fix common/ includes.
1106         * mi/mi-main.c: Fix common/ includes.
1107         * mi/mi-cmd-env.c: Fix common/ includes.
1108         * memrange.h: Fix common/ includes.
1109         * memattr.c: Fix common/ includes.
1110         * maint.h: Fix common/ includes.
1111         * maint.c: Fix common/ includes.
1112         * main.c: Fix common/ includes.
1113         * machoread.c: Fix common/ includes.
1114         * location.c: Fix common/ includes.
1115         * linux-thread-db.c: Fix common/ includes.
1116         * linux-nat.c: Fix common/ includes.
1117         * linux-fork.c: Fix common/ includes.
1118         * inline-frame.c: Fix common/ includes.
1119         * infrun.c: Fix common/ includes.
1120         * inflow.c: Fix common/ includes.
1121         * inferior.h: Fix common/ includes.
1122         * inferior.c: Fix common/ includes.
1123         * infcmd.c: Fix common/ includes.
1124         * inf-ptrace.c: Fix common/ includes.
1125         * inf-child.c: Fix common/ includes.
1126         * ia64-linux-nat.c: Fix common/ includes.
1127         * i387-tdep.c: Fix common/ includes.
1128         * i386-tdep.c: Fix common/ includes.
1129         * i386-linux-tdep.c: Fix common/ includes.
1130         * i386-linux-nat.c: Fix common/ includes.
1131         * i386-go32-tdep.c: Fix common/ includes.
1132         * i386-fbsd-tdep.c: Fix common/ includes.
1133         * i386-fbsd-nat.c: Fix common/ includes.
1134         * guile/scm-type.c: Fix common/ includes.
1135         * guile/guile.c: Fix common/ includes.
1136         * go32-nat.c: Fix common/ includes.
1137         * gnu-nat.c: Fix common/ includes.
1138         * gdbthread.h: Fix common/ includes.
1139         * gdbarch-selftests.c: Fix common/ includes.
1140         * gdb_usleep.c: Fix common/ includes.
1141         * gdb_select.h: Fix common/ includes.
1142         * gdb_bfd.c: Fix common/ includes.
1143         * gcore.c: Fix common/ includes.
1144         * fork-child.c: Fix common/ includes.
1145         * findvar.c: Fix common/ includes.
1146         * fbsd-nat.c: Fix common/ includes.
1147         * event-top.c: Fix common/ includes.
1148         * event-loop.c: Fix common/ includes.
1149         * dwarf2read.c: Fix common/ includes.
1150         * dwarf2loc.c: Fix common/ includes.
1151         * dwarf2-frame.c: Fix common/ includes.
1152         * dwarf-index-cache.c: Fix common/ includes.
1153         * dtrace-probe.c: Fix common/ includes.
1154         * disasm-selftests.c: Fix common/ includes.
1155         * defs.h: Fix common/ includes.
1156         * csky-tdep.c: Fix common/ includes.
1157         * cp-valprint.c: Fix common/ includes.
1158         * cp-support.h: Fix common/ includes.
1159         * cp-support.c: Fix common/ includes.
1160         * corelow.c: Fix common/ includes.
1161         * completer.h: Fix common/ includes.
1162         * completer.c: Fix common/ includes.
1163         * compile/compile.c: Fix common/ includes.
1164         * compile/compile-loc2c.c: Fix common/ includes.
1165         * compile/compile-cplus-types.c: Fix common/ includes.
1166         * compile/compile-cplus-symbols.c: Fix common/ includes.
1167         * command.h: Fix common/ includes.
1168         * cli/cli-dump.c: Fix common/ includes.
1169         * cli/cli-cmds.c: Fix common/ includes.
1170         * charset.c: Fix common/ includes.
1171         * build-id.c: Fix common/ includes.
1172         * btrace.h: Fix common/ includes.
1173         * btrace.c: Fix common/ includes.
1174         * breakpoint.h: Fix common/ includes.
1175         * breakpoint.c: Fix common/ includes.
1176         * ax.h:
1177         (enum agent_op): Fix common/ includes.
1178         * ax-general.c (struct aop_map): Fix common/ includes.
1179         * ax-gdb.c: Fix common/ includes.
1180         * auxv.c: Fix common/ includes.
1181         * auto-load.c: Fix common/ includes.
1182         * arm-tdep.c: Fix common/ includes.
1183         * arch/riscv.c: Fix common/ includes.
1184         * arch/ppc-linux-common.c: Fix common/ includes.
1185         * arch/i386.c: Fix common/ includes.
1186         * arch/arm.c: Fix common/ includes.
1187         * arch/arm-linux.c: Fix common/ includes.
1188         * arch/arm-get-next-pcs.c: Fix common/ includes.
1189         * arch/amd64.c: Fix common/ includes.
1190         * arch/aarch64.c: Fix common/ includes.
1191         * arch/aarch64-insn.c: Fix common/ includes.
1192         * arch-utils.c: Fix common/ includes.
1193         * amd64-windows-tdep.c: Fix common/ includes.
1194         * amd64-tdep.c: Fix common/ includes.
1195         * amd64-sol2-tdep.c: Fix common/ includes.
1196         * amd64-obsd-tdep.c: Fix common/ includes.
1197         * amd64-nbsd-tdep.c: Fix common/ includes.
1198         * amd64-linux-tdep.c: Fix common/ includes.
1199         * amd64-linux-nat.c: Fix common/ includes.
1200         * amd64-fbsd-tdep.c: Fix common/ includes.
1201         * amd64-fbsd-nat.c: Fix common/ includes.
1202         * amd64-dicos-tdep.c: Fix common/ includes.
1203         * amd64-darwin-tdep.c: Fix common/ includes.
1204         * agent.c: Fix common/ includes.
1205         * ada-lang.h: Fix common/ includes.
1206         * ada-lang.c: Fix common/ includes.
1207         * aarch64-tdep.c: Fix common/ includes.
1208
1209 2019-01-25  Tom Tromey  <tom@tromey.com>
1210
1211         * common/create-version.sh: Use common/version.h.
1212
1213 2019-01-24  Pedro Alves  <palves@redhat.com>
1214
1215         * infrun.c (signal_stop, signal_print, signal_program)
1216         (signal_catch, signal_pass): Now arrays instead of pointers.
1217         (update_signals_program_target, do_target_resume)
1218         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1219         * linux-nat.c (linux_nat_target::pass_signals)
1220         (linux_nat_target::create_inferior, linux_nat_target::attach):
1221         Adjust.
1222         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1223         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1224         * procfs.c (procfs_target::pass_signals): Adjust.
1225         * record-full.c (record_full_target::resume): Adjust.
1226         * remote.c (remote_target::pass_signals)
1227         (remote_target::program_signals): Adjust.
1228         * target-debug.h (target_debug_print_signals): Now takes a
1229         gdb::array_view as parameter.  Adjust.
1230         * target.h (target_ops) <pass_signals, program_signals>: Replace
1231         pointer and length parameters with gdb::array_view.
1232         (target_pass_signals, target_program_signals): Likewise.
1233         * target-delegates.c: Regenerate.
1234
1235 2019-01-24  Pedro Alves  <palves@redhat.com>
1236
1237         * common/forward-scope-exit.h
1238         (forward_scope_exit::forward_scope_exit): Pass arguments to
1239         m_bind_function directly, instead of creating a std::bind and
1240         copying that.
1241
1242 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1243
1244         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1245         for static members.
1246         (pass_in_v_vfp_candidate): Likewise.
1247
1248 2019-01-23  Tom Tromey  <tom@tromey.com>
1249             Pedro Alves  <palves@redhat.com>
1250
1251         * regcache.c (class regcache_invalidator): Remove.
1252         (regcache::raw_write): Use make_scope_exit.
1253
1254 2019-01-23  Tom Tromey  <tom@tromey.com>
1255
1256         * ui-out.h (class ui_out_emit_type): Update comment.
1257
1258 2019-01-23  Tom Tromey  <tom@tromey.com>
1259
1260         * infrun.c (fetch_inferior_event): Update comment.
1261
1262 2019-01-23  Tom Tromey  <tom@tromey.com>
1263             Pedro Alves  <palves@redhat.com>
1264
1265         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1266         parameter.
1267         (fetch_inferior_event): Use SCOPE_EXIT.
1268
1269
1270 2019-01-23  Tom Tromey  <tom@tromey.com>
1271             Pedro Alves  <palves@redhat.com>
1272
1273         * infrun.c (disable_thread_events): Delete.
1274         (stop_all_threads): Use SCOPE_EXIT.
1275
1276 2019-01-23  Tom Tromey  <tom@tromey.com>
1277             Pedro Alves  <palves@redhat.com>
1278
1279         * symfile.c: Include forward-scope-exit.h.
1280         (clear_symtab_users_cleanup): Replace forward declaration with
1281         a FORWARD_SCOPE_EXIT.
1282         (syms_from_objfile_1): Use the forward_scope_exit and
1283         gdb::optional instead of cleanup_function.
1284         (reread_symbols): Use the forward_scope_exit instead of
1285         cleanup_function.
1286         (clear_symtab_users_cleanup): Remove function.
1287
1288 2019-01-23  Tom Tromey  <tom@tromey.com>
1289             Pedro Alves  <palves@redhat.com>
1290
1291         * linux-nat.c: Include scope-exit.h.
1292         (cleanup_target_stop): Remove.
1293         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1294         SCOPE_EXIT.
1295
1296 2019-01-23  Tom Tromey  <tom@tromey.com>
1297             Pedro Alves  <palves@redhat.com>
1298
1299         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1300         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1301
1302 2019-01-23  Tom Tromey  <tom@tromey.com>
1303             Andrew Burgess  <andrew.burgess@embecosm.com>
1304             Pedro Alves  <palves@redhat.com>
1305
1306         * infrun.c (fetch_inferior_event): Use scope_exit.
1307         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1308         * top.c (execute_command): Use scope_exit.
1309         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1310         * utils.c (do_bpstat_clear_actions_cleanup)
1311         (make_bpstat_clear_actions_cleanup): Remove.
1312
1313 2019-01-23  Tom Tromey  <tom@tromey.com>
1314             Pedro Alves  <palves@redhat.com>
1315
1316         * infrun.c: Include "common/scope-exit.h"
1317         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1318         (wait_for_inferior): Use SCOPE_EXIT.
1319         (fetch_inferior_event): Use scope_exit.
1320
1321 2019-01-23  Tom Tromey  <tom@tromey.com>
1322             Pedro Alves  <palves@redhat.com>
1323
1324         * breakpoint.c (create_breakpoint): Remove cleanup.
1325
1326 2019-01-23  Tom Tromey  <tom@tromey.com>
1327             Andrew Burgess  <andrew.burgess@embecosm.com>
1328             Pedro Alves  <palves@redhat.com>
1329
1330 2019-01-23  Pedro Alves  <palves@redhat.com>
1331
1332         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1333
1334 2019-01-23  Pedro Alves  <palves@redhat.com>
1335             Andrew Burgess  <andrew.burgess@embecosm.com>
1336
1337         * gdbthread.h: Include "common/forward-scope-exit.h".
1338         (scoped_finish_thread_state): Redefine custom class in terms of
1339         forward_scope_exit.
1340
1341 2019-01-23  Pedro Alves  <palves@redhat.com>
1342             Andrew Burgess  <andrew.burgess@embecosm.com>
1343
1344         * common/forward-scope-exit.h: New file.
1345
1346 2019-01-23  Pedro Alves  <palves@redhat.com>
1347             Andrew Burgess  <andrew.burgess@embecosm.com>
1348             Tom Tromey  <tom@tromey.com>
1349
1350         * common/scope-exit.h: New file.
1351
1352 2019-01-23  Pedro Alves  <palves@redhat.com>
1353
1354         * common/preprocessor.h (ESC): Rename to ...
1355         (ESC_PARENS): ... this.
1356         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1357         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1358
1359 2019-01-23  Tom Tromey  <tom@tromey.com>
1360
1361         * language.h (class scoped_switch_to_sym_language_if_auto):
1362         Initialize m_lang in both cases.
1363
1364 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1365
1366         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1367         with XCNEW.
1368
1369 2019-01-22  Tom Tromey  <tom@tromey.com>
1370
1371         * corelow.c: Do not include sys/file.h.
1372
1373 2019-01-22  Tom Tromey  <tom@tromey.com>
1374
1375         * tui/tui-wingeneral.h: Include gdb_curses.h.
1376
1377 2019-01-22  Tom Tromey  <tom@tromey.com>
1378
1379         * source-cache.h (class source_cache) <get_source_lines,
1380         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1381
1382 2019-01-22  Tom Tromey  <tom@tromey.com>
1383
1384         * remote-fileio.h (struct remote_target): Declare.
1385
1386 2019-01-22  Tom Tromey  <tom@tromey.com>
1387
1388         * python/py-arch.c: Do not include py-ref.h.
1389         * python/py-bpevent.c: Do not include py-ref.h.
1390         * python/py-cmd.c: Do not include py-ref.h.
1391         * python/py-continueevent.c: Do not include py-ref.h.
1392         * python/py-event.h: Do not include py-ref.h.
1393         * python/py-evtregistry.c: Do not include py-ref.h.
1394         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1395         * python/py-frame.c: Do not include py-ref.h.
1396         * python/py-framefilter.c: Do not include py-ref.h.
1397         * python/py-function.c: Do not include py-ref.h.
1398         * python/py-infevents.c: Do not include py-ref.h.
1399         * python/py-linetable.c: Do not include py-ref.h.
1400         * python/py-objfile.c: Do not include py-ref.h.
1401         * python/py-param.c: Do not include py-ref.h.
1402         * python/py-prettyprint.c: Do not include py-ref.h.
1403         * python/py-progspace.c: Do not include py-ref.h.
1404         * python/py-symbol.c: Do not include py-ref.h.
1405         * python/py-symtab.c: Do not include py-ref.h.
1406         * python/py-type.c: Do not include py-ref.h.
1407         * python/py-unwind.c: Do not include py-ref.h.
1408         * python/py-utils.c: Do not include py-ref.h.
1409         * python/py-value.c: Do not include py-ref.h.
1410         * python/py-varobj.c: Do not include py-ref.h.
1411         * python/py-xmethods.c: Do not include py-ref.h.
1412         * python/python.c: Do not include py-ref.h.
1413         * varobj.c: Do not include py-ref.h.
1414
1415 2019-01-22  Tom Tromey  <tom@tromey.com>
1416
1417         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1418         keyword for bcache.
1419
1420 2019-01-22  Tom Tromey  <tom@tromey.com>
1421
1422         * compile/compile-cplus-types.c: Remove a comment by #include.
1423
1424 2019-01-22  Tom Tromey  <tom@tromey.com>
1425
1426         * compile/gcc-c-plugin.h: Include compile-internal.h.
1427
1428 2019-01-22  Tom Tromey  <tom@tromey.com>
1429
1430         * stabsread.c (EXTERN): Do not define.
1431         (symnum, next_symbol_text_func, processing_gcc_compilation)
1432         (within_function, global_sym_chain, global_stabs)
1433         (previous_stab_code, this_object_header_files)
1434         (n_this_object_header_files)
1435         (n_allocated_this_object_header_files): Define.
1436         * stabsread.h (EXTERN): Never define.  Use "extern".
1437
1438 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1439
1440         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1441         history_value.
1442
1443 2019-01-21  Tom Tromey  <tom@tromey.com>
1444
1445         * ui-out.c: Fix includes.
1446         * tui/tui-source.c: Fix includes.
1447         * target.c: Fix includes.
1448         * remote.c: Fix includes.
1449         * regcache.c: Fix includes.
1450         * python/py-block.c: Fix includes.
1451         * printcmd.c: Fix includes.
1452         * or1k-tdep.c: Fix includes.
1453         * mi/mi-main.c: Fix includes.
1454         * m32r-tdep.c: Fix includes.
1455         * csky-tdep.c: Fix includes.
1456         * compile/compile-cplus-types.c: Fix includes.
1457         * cli/cli-interp.c: Fix includes.
1458
1459 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1460
1461         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1462         for padding.
1463
1464 2019-01-16  Tom Tromey  <tom@tromey.com>
1465
1466         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1467         earlier.
1468         (struct objfile) <msymbols_range>: Move from top level.
1469         <msymbols>: New method.
1470         (class objfile_msymbols): Remove.
1471         * symtab.c (default_collect_symbol_completion_matches_break_on):
1472         Update.
1473         * symmisc.c (dump_msymbols): Update.
1474         * stabsread.c (scan_file_globals): Update.
1475         * objc-lang.c (info_selectors_command, info_classes_command)
1476         (find_methods): Update.
1477         * minsyms.c (find_solib_trampoline_target): Update.
1478         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1479         * coffread.c (coff_symfile_read): Update.
1480         * ada-lang.c (ada_lookup_simple_minsym)
1481         (ada_collect_symbol_completion_matches): Update.
1482
1483 2019-01-16  Tom Tromey  <tom@tromey.com>
1484
1485         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1486         type.  Remove no-argument constructor.
1487         <iterator::operator++>: Simplify.
1488         <begin>: Update.
1489         <end>: Use minimal_symbol_count.
1490
1491 2019-01-16  Tom Tromey  <tom@tromey.com>
1492
1493         * objfiles.h (struct objfile) <psymtabs>: New method.
1494         (class objfile_psymtabs): Remove.
1495         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1496         typedef.
1497         <range>: New method.
1498         (require_partial_symbols): Change return type.
1499         * psymtab.c (require_partial_symbols)
1500         (psym_expand_symtabs_matching): Update.
1501         * mdebugread.c (parse_partial_symbols): Update.
1502         * dbxread.c (dbx_end_psymtab): Update.
1503
1504 2019-01-15  Tom Tromey  <tom@tromey.com>
1505
1506         * symtab.c (lookup_objfile_from_block)
1507         (lookup_symbol_in_objfile_symtabs)
1508         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1509         (find_line_symtab, info_sources_command)
1510         (default_collect_symbol_completion_matches_break_on)
1511         (make_source_files_completion_list): Update.
1512         * symmisc.c (print_objfile_statistics, dump_objfile)
1513         (maintenance_print_symbols, maintenance_info_symtabs)
1514         (maintenance_check_symtabs, maintenance_info_line_tables):
1515         Update.
1516         * source.c (select_source_symtab)
1517         (forget_cached_source_info_for_objfile): Update.
1518         * objfiles.h (class objfile_compunits): Remove.
1519         (struct objfile) <compunits_range>: New typedef.
1520         (compunits): New method.
1521         * objfiles.c (objfile_relocate1): Update.
1522         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1523         * maint.c (count_symtabs_and_blocks): Update.
1524         * linespec.c (iterate_over_all_matching_symtabs): Update.
1525         * cp-support.c (add_symbol_overload_list_qualified): Update.
1526         * coffread.c (coff_symtab_read): Update.
1527         * ada-lang.c (add_nonlocal_symbols)
1528         (ada_collect_symbol_completion_matches)
1529         (ada_add_global_exceptions): Update.
1530
1531 2019-01-15  Tom Tromey  <tom@tromey.com>
1532
1533         * progspace.h (program_space) <objfiles_safe_range>: New
1534         typedef.
1535         <objfiles_safe>: New method.
1536         * objfiles.h (class all_objfiles_safe): Remove.
1537         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1538         * jit.c (jit_inferior_exit_hook): Update.
1539
1540 2019-01-17  Tom Tromey  <tom@tromey.com>
1541
1542         * progspace.h (program_space) <objfiles_range>: New typedef.
1543         <objfiles>: New method.
1544         <objfiles_head>: Rename from objfiles.
1545         (object_files): Update.
1546         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1547         * guile/scm-pretty-print.c
1548         (ppscm_find_pretty_printer_from_objfiles): Update.
1549         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1550         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1551         Update.
1552         * python/py-progspace.c (pspy_get_objfiles): Update.
1553         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1554         Update.
1555         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1556         (objfpy_lookup_objfile_by_build_id): Update.
1557         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1558         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1559         Update.
1560         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1561         (expand_symtab_containing_pc, lookup_objfile_from_block)
1562         (lookup_static_symbol, basic_lookup_transparent_type)
1563         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1564         (find_line_symtab, info_sources_command)
1565         (default_collect_symbol_completion_matches_break_on)
1566         (make_source_files_completion_list, find_main_name): Update.
1567         * symmisc.c (print_symbol_bcache_statistics)
1568         (print_objfile_statistics, maintenance_print_symbols)
1569         (maintenance_print_msymbols, maintenance_print_objfiles)
1570         (maintenance_info_symtabs, maintenance_check_symtabs)
1571         (maintenance_expand_symtabs, maintenance_info_line_tables):
1572         Update.
1573         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1574         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1575         (map_overlay_command, unmap_overlay_command)
1576         (simple_overlay_update, expand_symtabs_matching)
1577         (map_symbol_filenames): Update.
1578         * symfile-debug.c (set_debug_symfile): Update.
1579         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1580         Update.
1581         * source.c (select_source_symtab, forget_cached_source_info):
1582         Update.
1583         * solib.c (solib_read_symbols): Update.
1584         * solib-spu.c (append_ocl_sos): Update.
1585         * psymtab.c (maintenance_print_psymbols)
1586         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1587         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1588         * printcmd.c (info_symbol_command): Update.
1589         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1590         Update.
1591         * objfiles.h (class all_objfiles): Remove.
1592         * objfiles.c (have_partial_symbols, have_full_symbols)
1593         (have_minimal_symbols, qsort_cmp, update_section_map)
1594         (shared_objfile_contains_address_p)
1595         (default_iterate_over_objfiles_in_search_order): Update.
1596         * objc-lang.c (info_selectors_command, info_classes_command)
1597         (find_methods): Update.
1598         * minsyms.c (find_solib_trampoline_target): Update.
1599         * maint.c (maintenance_info_sections)
1600         (maintenance_translate_address, count_symtabs_and_blocks):
1601         Update.
1602         * main.c (captured_main_1): Update.
1603         * linux-thread-db.c (try_thread_db_load_from_pdir)
1604         (has_libpthread): Update.
1605         * linespec.c (iterate_over_all_matching_symtabs)
1606         (search_minsyms_for_name): Update.
1607         * jit.c (jit_find_objf_with_entry_addr): Update.
1608         * hppa-tdep.c (find_unwind_entry)
1609         (hppa_lookup_stub_minimal_symbol): Update.
1610         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1611         Update.
1612         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1613         (elf_gnu_ifunc_resolve_by_got): Update.
1614         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1615         * dwarf-index-write.c (save_gdb_index_command): Update.
1616         * cp-support.c (add_symbol_overload_list_qualified): Update.
1617         * breakpoint.c (create_overlay_event_breakpoint)
1618         (create_longjmp_master_breakpoint)
1619         (create_std_terminate_master_breakpoint)
1620         (create_exception_master_breakpoint): Update.
1621         * blockframe.c (find_pc_partial_function): Update.
1622         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1623         (ada_collect_symbol_completion_matches)
1624         (ada_add_global_exceptions): Update.
1625
1626 2019-01-17  Tom Tromey  <tom@tromey.com>
1627
1628         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1629         declare VEC.
1630         (solib_target_parse_libraries): Change return type.
1631         (library_list_start_segment, library_list_start_section)
1632         (library_list_end_library, library_list_start_library); Update.
1633         (solib_target_free_library_list): Remove.
1634         (solib_target_parse_libraries): Remove cleanup.  Change return
1635         type.
1636         (solib_target_current_sos): Update.
1637
1638 2019-01-17  Tom Tromey  <tromey@bapiya>
1639
1640         * valprint.c: Replace "the the" with "the".
1641         * symtab.c: Replace "the the" with "the".
1642         * solib.c: Replace "the the" with "the".
1643         * solib-dsbt.c: Replace "the the" with "the".
1644         * linespec.c: Replace "the the" with "the".
1645         * dwarf2loc.h: Replace "the the" with "the".
1646         * amd64-windows-tdep.c: Replace "the the" with "the".
1647         * aarch64-tdep.c: Replace "the the" with "the".
1648
1649 2019-01-16  Keith Seitz  <keiths@redhat.com>
1650
1651         PR gdb/23773
1652         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1653         <builder>: Rename to ..
1654         <m_builder>: ... this and make private.
1655         (dwarf2_cu::get_builder): New method.  Change all users of
1656         `builder' to use this method.
1657         (dwarf2_start_symtab): Move to ...
1658         (dwarf2_cu::start_symtab): ... here.  Update all callers
1659         (setup_type_unit_groups): Move to ...
1660         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1661         callers.
1662         (dwarf2_cu::reset_builder): New method.
1663         (process_full_compunit, process_full_type_unit): Use
1664         dwarf2_cu::reset_builder.
1665         (follow_die_offset): Record the ancestor CU if it is different
1666         from the followed DIE's CU.
1667         (follow_die_sig_1): Likewise.
1668
1669 2019-01-15  Tom Tromey  <tom@tromey.com>
1670
1671         * remote.c (class remote_state) <buf>: Now a char_vector.
1672         <buf_size>: Remove.
1673         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1674         parameter.
1675         (remote_target::getpkt_or_notif_sane_1)
1676         (remote_target::getpkt_sane)
1677         (remote_target::getpkt_or_notif_sane): Likewise.
1678         (class remote_target) <putpkt>: New overload.
1679         (remote_target::read_frame): Change type of "buf_p".  Remove
1680         sizeof_p parameter.
1681         (packet_ok): New overload.
1682         (packet_check_result): New overload.
1683         Update all uses.
1684
1685 2019-01-14  Tom Tromey  <tom@tromey.com>
1686
1687         * remote-notif.c (handle_notification, remote_notif_ack)
1688         (remote_notif_parse): Make "buf" const.
1689         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1690         const.
1691         (remote_notif_parse, remote_notif_ack, handle_notification):
1692         Likewise.
1693         * remote.c (remote_notif_stop_parse): Make "buf" const.
1694         (remote_target::remote_parse_stop_reply): Make "buf" const.
1695         (remote_notif_stop_ack): Make "buf" const.
1696
1697 2019-01-14  Tom Tromey  <tom@tromey.com>
1698
1699         * remote.c (remote_console_output): Make parameter const.
1700
1701 2019-01-14  Tom Tromey  <tom@tromey.com>
1702
1703         * target-debug.h (target_debug_print_signals): Constify.
1704         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1705         * procfs.c (procfs_target::pass_signals): Update.
1706         * linux-nat.c (linux_nat_target::pass_signals): Update.
1707         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1708         * target-delegates.c: Rebuild.
1709         * remote.c (remote_target::program_signals): Update.
1710         (remote_target::pass_signals): Update.
1711         * target.c (target_pass_signals): Constify argument.
1712         (target_program_signals): Likewise.
1713         * target.h (struct target_ops) <pass_signals, program_signals>:
1714         Constify argument.
1715         (target_pass_signals, target_program_signals): Constify argument.
1716
1717 2019-01-14  Tom Tromey  <tom@tromey.com>
1718
1719         PR tui/28819:
1720         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1721
1722 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1723
1724         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1725         field.
1726         * rs6000-tdep.c: Include reggroups.h.
1727         (IS_V_ALIAS_PSEUDOREG): Define.
1728         (rs6000_register_name): Return names for the "vX" aliases.
1729         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1730         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1731         aliases.  Call default_register_reggroup_p for all other
1732         pseudo-registers.
1733         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1734         New functions.
1735         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1736         Handle "vX" aliases.
1737         (v_alias_pseudo_register_collect): New function.
1738         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1739         (rs6000_gdbarch_init): Initialize "vX" aliases as
1740         pseudo-registers.  Restore registration of
1741         rs6000_pseudo_register_reggroup_p with
1742         set_tdesc_pseudo_register_reggroup_p.
1743
1744 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1745
1746         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1747         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1748         set_gdbarch_num_pseudo_regs.
1749
1750 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1751
1752         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1753         Remove arg prefixname, add do_set and do_show.
1754         Add member functions set_list and show_list.
1755         * cli/cli-style.c (class cli_style_option): Update accordingly.
1756         (style_set_list): Move to file scope.
1757         (style_show_list): Likewise.
1758         (set_style): Call help_list.
1759         (show_style): Call cmd_show_list.
1760         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1761         Update to use the new macro.
1762
1763 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1764
1765         * ada-lang.c (_initialize_ada_language): Expand the help text
1766         for the "catch exception" command.
1767
1768 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1769
1770         * symtab.c (matching_obj_sections): Initialize obj,
1771         declare it closer to its usage.
1772
1773 2019-01-10  Tom Tromey  <tom@tromey.com>
1774
1775         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1776         (basic_inf_threads_range): Remove.
1777         (inf_threads_range, inf_non_exited_threads_range)
1778         (safe_inf_threads_range): Use next_adapter.
1779
1780 2019-01-10  Keith Seitz  <keiths@redhat.com>
1781
1782         PR gdb/23712
1783         PR symtab/23010
1784         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1785         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1786
1787 2019-01-10  Keith Seitz  <keiths@redhat.com>
1788
1789         PR gdb/23712
1790         PR symtab/23010
1791         * dictionary.c (pending_to_vector): Remove.
1792         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1793         Remove _1 suffix, replacing functions of the same name.  Update
1794         all callers.
1795         (dict_create_hashed, dict_create_hashed_expandable)
1796         (dict_create_linear, dict_create_linear_expandable, dict_free)
1797         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1798         Make functions static.
1799
1800 2019-01-10  Keith Seitz  <keiths@redhat.com>
1801
1802         PR gdb/23712
1803         PR symtab/23010
1804         * dictionary.h (struct dictionary): Replace declaration with
1805         multidictionary.
1806         (dict_create_hashed, dict_create_hashed_expandable)
1807         (dict_create_linear, dict_create_linear_expandable)
1808         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1809         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1810         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1811         taking multidictionary argument.
1812         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1813         * block.h (struct block) <dict>: Change to multidictionary
1814         and rename `multidict'.
1815         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1816         symmisc.c: Update all dictionary references to multidictionary.
1817
1818 2019-01-10  Keith Seitz  <keiths@redhat.com>
1819
1820         PR gdb/23712
1821         PR symtab/23010
1822         * dictionary.c: Include unordered_map.
1823         (pending_to_vector): New function.
1824         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1825         Rewrite the non-"_1" functions to take vector instead
1826         of linked list.
1827         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1828         "new" _1 versions of the same name.
1829         (multidictionary): Define.
1830         (std::hash<enum language): New definition.
1831         (collate_pending_symbols_by_language, mdict_create_hashed)
1832         (mdict_create_hashed_expandable, mdict_create_linear)
1833         (mdict_create_linear_expandable, mdict_free)
1834         (find_language_dictionary, create_new_language_dictionary)
1835         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1836         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1837         (mdict_size, mdict_empty): New functions.
1838         * dictionary.h (mdict_iterator): Define.
1839
1840 2019-01-10  Pedro Alves  <palves@redhat.com>
1841
1842         * breakpoint.c (read_uploaded_action)
1843         (create_tracepoint_from_upload): Adjust to use
1844         gdb::unique_xmalloc_ptr.
1845         * ctf.c (ctf_write_uploaded_tp):
1846         (SET_ARRAY_FIELD): Use emplace_back.
1847         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1848         * tracefile-tfile.c (tfile_write_uploaded_tp):
1849         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1850         gdb::unique_xmalloc_ptr.
1851         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1852         at_string, cond_string, cmd_strings>: Replace char pointers
1853         with gdb::unique_xmalloc_ptr.
1854
1855 2019-01-10  Pedro Alves  <palves@redhat.com>
1856
1857         * solib-target.c (library_list_start_library): Don't xstrdup name.
1858
1859 2019-01-10  Pedro Alves  <palves@redhat.com>
1860
1861         * mdebugread.c (parse_partial_symbols): Use
1862         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1863
1864 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1865
1866         * linux-fork.c (scoped_switch_fork_info)
1867         <~scoped_switch_fork_info>: Fix incorrect variable name.
1868
1869 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1870
1871         * linux-fork.c (scoped_switch_fork_info)
1872         <scoped_switch_fork_info>: Make explicit.
1873         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1874
1875 2019-01-10  Tom Tromey  <tom@tromey.com>
1876
1877         * objfiles.h (objfile::reset_psymtabs): Update.
1878         * objfiles.c (objfile::objfile): Update.
1879         * psymtab.h (psymtab_storage::obstack): Update.
1880         (psymtab_storage::m_obstack): Use gdb::optional.
1881         (class psymtab_storage): Update comment.  Remove objfile
1882         parameter.
1883         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1884
1885 2019-01-10  Tom Tromey  <tom@tromey.com>
1886
1887         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1888         <free_psymtabs>: Now private.
1889         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1890         (allocate_psymtab): Use new method.
1891
1892 2019-01-10  Tom Tromey  <tom@tromey.com>
1893
1894         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1895         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1896         * mdebugread.c (parse_partial_symbols): Use
1897         allocate_dependencies.
1898         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1899         allocate_dependencies.
1900         (process_psymtab_comp_unit_reader)
1901         (build_type_psymtab_dependencies): Likewise.
1902         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1903
1904 2019-01-10  Tom Tromey  <tom@tromey.com>
1905
1906         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1907         PSYMBOL_SET_LANGUAGE.
1908         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1909
1910 2019-01-10  Tom Tromey  <tom@tromey.com>
1911
1912         * psymtab.h (psymtab_storage::obstack): New method.
1913         <m_obstack>: Rename from obstack; now private.
1914         * psymtab.c (psymtab_storage): Update.
1915         * dwarf2read.c (create_addrmap_from_index)
1916         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1917         Update.
1918
1919 2019-01-10  Tom Tromey  <tom@tromey.com>
1920
1921         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1922         * objfiles.h (objfile::reset_psymtabs): New method.
1923
1924 2019-01-10  Tom Tromey  <tom@tromey.com>
1925
1926         * symmisc.c (print_symbol_bcache_statistics): Update.
1927         (print_objfile_statistics): Update.
1928         * symfile.c (reread_symbols): Update.
1929         * psymtab.h (class psymtab_storage): New.
1930         * psymtab.c (psymtab_storage): New constructor.
1931         (~psymtab_storage): New destructor.
1932         (require_partial_symbols): Update.
1933         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1934         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1935         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1936         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1937         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1938         (start_psymtab_common, end_psymtab_common)
1939         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1940         (allocate_psymtab): Update.
1941         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1942         Update.
1943         (dump_psymtab_addrmap, maintenance_print_psymbols)
1944         (maintenance_check_psymtabs): Update.
1945         (class objfile_psymtabs): Move to objfiles.h.
1946         * psympriv.h (discard_psymtab): Now inline.
1947         (psymtab_discarder::psymtab_discarder): Update.
1948         (psymtab_discarder::~psymtab_discarder): Update.
1949         (ALL_OBJFILE_PSYMTABS): Rewrite.
1950         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1951         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1952         Remove fields.
1953         <partial_symtabs>: New field.
1954         (class objfile_psymtabs): Move from psymtab.h.  Update.
1955         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1956         psymbol_cache.
1957         (objfile::~objfile): Don't destroy psymbol_cache.
1958         * mdebugread.c (parse_partial_symbols): Update.
1959         * dwarf2read.c (create_addrmap_from_index)
1960         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1961         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1962         (add_partial_subprogram, dwarf2_ranges_read): Update.
1963         * dwarf-index-write.c (write_address_map)
1964         (write_one_signatured_type, recursively_write_psymbols)
1965         (class debug_names, class debug_names, write_psymtabs_to_index):
1966         Update.
1967
1968 2019-01-10  Tom Tromey  <tom@tromey.com>
1969
1970         * symtab.h (SYMBOL_SET_NAMES): Update.
1971         (symbol_set_names): Update.
1972         (MSYMBOL_SET_NAMES): Update.
1973         * symtab.c (symbol_set_names): Change argument to be an
1974         objfile_per_bfd_storage.
1975         * psymtab.c (add_psymbol_to_bcache): Update.
1976         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1977
1978 2019-01-10  Tom Tromey  <tom@tromey.com>
1979
1980         * symtab.c (create_demangled_names_hash): Change argument to be an
1981         objfile_per_bfd_storage.
1982         (symbol_set_names): Update.
1983
1984 2019-01-10  Tom Tromey  <tom@tromey.com>
1985
1986         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1987         init_psymbol_list.
1988         * psymtab.c (init_psymbol_list): Do nothing if already called.
1989         * psympriv.h (init_psymbol_list): Add comment.
1990         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1991         init_psymbol_list.
1992         * dbxread.c (dbx_symfile_read): Unconditionally call
1993         init_psymbol_list.
1994
1995 2019-01-10  Tom Tromey  <tom@tromey.com>
1996
1997         * xcoffread.c (scan_xcoff_symtab): Update.
1998         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1999         "where".
2000         * mdebugread.c (parse_partial_symbols)
2001         (handle_psymbol_enumerators): Update.
2002         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2003         * dbxread.c (read_dbx_symtab): Update.
2004         * psympriv.h (psymbol_placement): New enum.
2005         (add_psymbol_to_list): Update.
2006
2007 2019-01-10  Tom Tromey  <tom@tromey.com>
2008
2009         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2010         static_psymbols parameters.
2011         (scan_xcoff_symtab): Update.
2012         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2013         static_psymbols parameters.
2014         * psympriv.h (start_psymtab_common): Update.
2015         * mdebugread.c (parse_partial_symbols): Update.
2016         * dwarf2read.c (create_partial_symtab): Update.
2017         * dbxread.c (read_dbx_symtab): Update.
2018         (start_psymtab): Remove global_psymbols and static_psymbols
2019         parameters.
2020
2021 2019-01-10  Tom Tromey  <tom@tromey.com>
2022
2023         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2024         * psymtab.c (allocate_psymtab): Add comment.
2025         * psympriv.h (allocate_psymtab): Add comment.
2026         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2027         initializations.
2028         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2029
2030 2019-01-10  Tom Tromey  <tom@tromey.com>
2031
2032         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2033         Don't declare.
2034         * mipsread.c: Include mdebugread.h.
2035         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2036         Declare.
2037         * elfread.c: Include mdebugread.h.
2038
2039 2019-01-09  Tom Tromey  <tom@tromey.com>
2040
2041         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2042         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2043         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2044         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2045         (psym_lookup_symbol, psym_find_last_source_symtab)
2046         (psym_forget_cached_source_info, psym_print_stats)
2047         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2048         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2049         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2050         (psym_find_compunit_symtab_by_address)
2051         (maintenance_print_psymbols, maintenance_info_psymtabs)
2052         (maintenance_check_psymtabs): Use ranged for.
2053         * psymtab.h (class objfile_psymtabs): New.
2054         (require_partial_symbols): Return objfile_psymtabs.
2055         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2056
2057 2019-01-09  Tom Tromey  <tom@tromey.com>
2058
2059         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2060         (find_pc_mapped_section, list_overlays_command)
2061         (map_overlay_command, unmap_overlay_command)
2062         (simple_overlay_update): Use all_objfiles.
2063         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2064         * printcmd.c (info_symbol_command): Use all_objfiles.
2065         * objfiles.h (ALL_OBJSECTIONS): Remove.
2066         * maint.c (maintenance_translate_address): Use all_objfiles.
2067         * gcore.c (gcore_create_callback): Use all_objfiles.
2068         (objfile_find_memory_regions): Likewise.
2069
2070 2019-01-09  Tom Tromey  <tom@tromey.com>
2071
2072         * symtab.c (find_line_symtab, info_sources_command)
2073         (make_source_files_completion_list): Use objfile_compunits.
2074         * source.c (select_source_symtab): Use objfile_compunits.
2075         * objfiles.h (struct objfile): Update comment.
2076         (ALL_OBJFILES): Remove.
2077         (ALL_FILETABS): Remove.
2078         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2079         objfile_compunits.
2080
2081 2019-01-09  Tom Tromey  <tom@tromey.com>
2082
2083         * symmisc.c (print_objfile_statistics, dump_objfile)
2084         (maintenance_print_symbols): Use compunit_filetabs.
2085         * source.c (forget_cached_source_info_for_objfile): Use
2086         compunit_filetabs.
2087         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2088         (ALL_FILETABS): Use compunit_filetabs.
2089         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2090         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2091
2092 2019-01-09  Tom Tromey  <tom@tromey.com>
2093
2094         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2095         (compunit_filetabs): New.
2096         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2097         compunit_filetabs.
2098         (info_sources_command, make_source_files_completion_list): Remove
2099         declaration.
2100         * symmisc.c (print_objfile_statistics, dump_objfile)
2101         (maintenance_print_symbols): Remove declaration.
2102         (maintenance_info_symtabs): Use compunit_filetabs.
2103         (maintenance_info_line_tables): Likewise.
2104         * source.c (select_source_symtab): Change local variable name.
2105         (forget_cached_source_info_for_objfile): Remove declaration.
2106         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2107         * objfiles.c (objfile_relocate1): Remove declaration.
2108         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2109         declaration.
2110         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2111         * coffread.c (coff_symtab_read): Remove declaration.
2112         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2113         compunit_filetabs.
2114
2115 2019-01-09  Tom Tromey  <tom@tromey.com>
2116
2117         * symtab.c (lookup_objfile_from_block)
2118         (find_pc_sect_compunit_symtab, search_symbols)
2119         (default_collect_symbol_completion_matches_break_on): Use
2120         objfile_compunits.
2121         * objfiles.h (ALL_COMPUNITS): Remove.
2122         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2123         * cp-support.c (add_symbol_overload_list_qualified): Use
2124         objfile_compunits.
2125         * ada-lang.c (ada_collect_symbol_completion_matches)
2126         (ada_add_global_exceptions): Use objfile_compunits.
2127
2128 2019-01-09  Tom Tromey  <tom@tromey.com>
2129
2130         * source.c (select_source_symtab)
2131         (forget_cached_source_info_for_objfile): Remove declaration.
2132         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2133         declaration.
2134         * maint.c (count_symtabs_and_blocks): Remove declaration.
2135         * cp-support.c (add_symbol_overload_list_qualified): Remove
2136         declaration.
2137         * coffread.c (coff_symtab_read): Remove declaration.
2138         * symtab.c (lookup_symbol_in_objfile_symtabs)
2139         (basic_lookup_transparent_type_1): Use objfile_compunits.
2140         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2141         (info_sources_command, search_symbols)
2142         (default_collect_symbol_completion_matches_break_on)
2143         (make_source_files_completion_list): Remove declaration.
2144         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2145         (ada_collect_symbol_completion_matches)
2146         (ada_add_global_exceptions): Remove declaration.
2147         * linespec.c (iterate_over_all_matching_symtabs): Use
2148         objfile_compunits.
2149         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2150         (class objfile_compunits): New.
2151         (ALL_COMPUNITS): Use objfile_compunits.
2152         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2153         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2154         objfile_compunits.
2155         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2156
2157 2019-01-09  Tom Tromey  <tom@tromey.com>
2158
2159         * symtab.c (search_symbols)
2160         (default_collect_symbol_completion_matches_break_on): Use
2161         objfile_msymbols.
2162         * ada-lang.c (ada_lookup_simple_minsym)
2163         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2164         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2165         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2166         objfile_msymbols.
2167         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2168         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2169         * objc-lang.c (find_methods): Use objfile_msymbols.
2170         (info_selectors_command, info_classes_command): Likewise.
2171         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2172         * objfiles.h (class objfile_msymbols): New.
2173         (ALL_OBJFILE_MSYMBOLS): Remove.
2174         (ALL_MSYMBOLS): Remove.
2175
2176 2019-01-09  Tom Tromey  <tom@tromey.com>
2177
2178         * common/next-iterator.h (next_adapter): Add Iterator template
2179         parameter.
2180         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2181         (class all_objfiles_safe): New.
2182         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2183         * objfiles.c (put_objfile_before): Update comment.
2184         (add_separate_debug_objfile): Likewise.
2185         (free_all_objfiles): Use all_objfiles_safe.
2186         (objfile_purge_solibs): Likewise.
2187
2188 2019-01-09  Tom Tromey  <tom@tromey.com>
2189
2190         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2191         (expand_symtab_containing_pc, lookup_static_symbol)
2192         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2193         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2194         all_objfiles.
2195         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2196         * breakpoint.c (create_overlay_event_breakpoint)
2197         (create_longjmp_master_breakpoint)
2198         (create_std_terminate_master_breakpoint)
2199         (create_exception_master_breakpoint): Use all_objfiles.
2200         * linux-thread-db.c (try_thread_db_load_from_pdir)
2201         (has_libpthread): Use all_objfiles.
2202         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2203         * linespec.c (iterate_over_all_matching_symtabs)
2204         (search_minsyms_for_name): Use all_objfiles.
2205         * maint.c (maintenance_info_sections): Use all_objfiles.
2206         * main.c (captured_main_1): Use all_objfiles.
2207         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2208         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2209         * guile/scm-pretty-print.c
2210         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2211         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2212         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2213         (maintenance_print_msymbols): Use all_objfiles.
2214         * source.c (select_source_symtab): Use all_objfiles.
2215         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2216         * symfile.c (remove_symbol_file_command)
2217         (expand_symtabs_matching, map_symbol_filenames): Use
2218         all_objfiles.
2219         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2220         all_objfiles.
2221         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2222         * objc-lang.c (find_methods): Use all_objfiles.
2223         * objfiles.c (have_partial_symbols, have_full_symbols)
2224         (have_minimal_symbols, qsort_cmp)
2225         (default_iterate_over_objfiles_in_search_order): Use
2226         all_objfiles.
2227         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2228         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2229         (maintenance_check_psymtabs): Use all_objfiles.
2230         (ALL_PSYMTABS): Remove.
2231         * compile/compile-object-run.c (do_module_cleanup): Use
2232         all_objfiles.
2233         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2234         * cp-support.c (add_symbol_overload_list_qualified): Use
2235         all_objfiles.
2236         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2237         Use all_objfiles.
2238         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2239         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2240         all_objfiles.
2241         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2242         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2243         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2244         Uses all_objfiles.
2245         * solib.c (solib_read_symbols): Use all_objfiles
2246
2247 2019-01-09  Tom Tromey  <tom@tromey.com>
2248
2249         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2250         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2251         all_objfiles.
2252         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2253         * symmisc.c (print_symbol_bcache_statistics)
2254         (print_objfile_statistics, maintenance_print_objfiles)
2255         (maintenance_info_symtabs, maintenance_check_symtabs)
2256         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2257         all_objfiles.
2258         * source.c (forget_cached_source_info): Use all_objfiles.
2259         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2260         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2261         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2262         * objfiles.c (update_section_map): Use all_objfiles.
2263         (shared_objfile_contains_address_p): Likewise.
2264         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2265         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2266
2267 2019-01-09  Tom Tromey  <tom@tromey.com>
2268
2269         * common/next-iterator.h: New file.
2270         * objfiles.h (class all_objfiles): New.
2271         (struct objfile_iterator): New.
2272
2273 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2274
2275         * NEWS: Move the description of the changed "frame", "select-frame",
2276          and "info frame" commands to the Changed commands section.
2277
2278 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2279
2280         * gdbtypes.c (check_stub_method_group): Remove handling of old
2281         mangling schemes.
2282         * linespec.c (find_methods): Likewise.
2283         * stabsread.c (read_member_functions): Likewise.
2284         * valops.c (search_struct_method): Likewise.
2285         (value_struct_elt_for_reference): Likewise.
2286         * NEWS: Mention this change.
2287
2288 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2289
2290         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2291         print_source_lines.
2292         * source.c (print_source_lines_base): Update line number check.
2293         (print_source_lines): New function.
2294         (source_lines_range::source_lines_range): New function.
2295         * source.h (class source_lines_range): New class.
2296         (print_source_lines): New declaration.
2297
2298 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2299
2300         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2301
2302 2019-01-08  Tom Tromey  <tom@tromey.com>
2303             Simon Marchi  <simon.marchi@ericsson.com>
2304
2305         PR gdb/24060
2306         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2307         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2308         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2309         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2310         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2311         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2312
2313 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2314
2315         * source.c (select_source_symtab): Move header comment to
2316         declaration in source.h.
2317         (forget_cached_source_info_for_objfile): Likewise.
2318         (forget_cached_source_info): Likewise.
2319         (identify_source_line): Likewise.
2320         * source.h (identify_source_line): Move declaration from symtab.h
2321         and add comment from source.c
2322         (print_source_lines): Likewise.
2323         (forget_cached_source_info_for_objfile): Likewise.
2324         (forget_cached_source_info): Likewise.
2325         (select_source_symtab): Likewise.
2326         (enum print_source_lines_flag): Move definition from symtab.h.
2327         * symtab.h (identify_source_line): Move declaration to source.h.
2328         (print_source_lines): Likewise.
2329         (forget_cached_source_info_for_objfile): Likewise.
2330         (forget_cached_source_info): Likewise.
2331         (select_source_symtab): Likewise.
2332         (enum print_source_lines_flag): Move definition to source.h.
2333         * tui/tui-hooks.c: Add 'source.h' include.
2334
2335 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2336
2337         * source.c (print_source_lines_base): Handle requests to print
2338         reverse line number sequences, and guard against empty lines
2339         string.
2340
2341 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2342
2343         * source.c (print_source_lines_base): Fix skip of '\r' if next
2344         character is '\n'.
2345
2346 2019-01-06  Tom Tromey  <tom@tromey.com>
2347
2348         * c-exp.y (struct c_parse_state) <macro_original_text,
2349         expansion_obstack>: New member.
2350         (macro_original_text, expansion_obstack): Remove globals.
2351         (scan_macro_expansion, scanning_macro_expansion)
2352         (finished_macro_expansion): Update.
2353         (scan_macro_cleanup): Remove.
2354         (yylex, c_parse): Update.
2355
2356 2019-01-06  Tom Tromey  <tom@tromey.com>
2357
2358         * c-exp.y (struct c_parse_state) <strings>: New member.
2359         (operator_stoken): Update.
2360
2361 2019-01-06  Tom Tromey  <tom@tromey.com>
2362
2363         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2364         (union type_stack_elt) <typelist_val>: Now a pointer to
2365         std::vector.
2366         (type_stack_cleanup): Don't declare.
2367         (push_typelist): Update.
2368         * parse.c (pop_typelist): Return a std::vector.
2369         (push_typelist): Take a std::vector.
2370         (follow_types): Update.  Do not free args.
2371         (type_stack_cleanup): Remove.
2372         * c-exp.y (struct c_parse_state): New.
2373         (cpstate): New global.
2374         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2375         (nonempty_typelist): Update.
2376         (func_mod): Create a new vector.
2377         (c_parse): Create a c_parse_state.
2378         (check_parameter_typelist): Do not delete params.
2379         (function_method): Update.  Do not delete type_list.
2380
2381 2019-01-06  Tom Tromey  <tom@tromey.com>
2382
2383         PR gdb/28155:
2384         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2385         check_typedef.
2386         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2387         (print_return_value): Likewise.
2388
2389 2019-01-05  Tom Tromey  <tom@tromey.com>
2390
2391         * contrib/cleanup_check.py: Remove.
2392         * contrib/gcc-with-excheck: Remove.
2393         * contrib/exsummary.py: Remove.
2394         * contrib/excheck.py: Remove.
2395
2396 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2397
2398         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2399         NULL. Initialize tpprev to NULL instead of assigning it
2400         to NULL on the next statement.
2401         * windows-nat.c (windows_delete_thread): Remove check for
2402         main_thread_id before printing thread exit notifications.
2403         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2404         Remove thread ID check against main_thread_id.
2405         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2406         windows_delete_thread.
2407         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2408
2409 2019-01-04  Tom Tromey  <tom@tromey.com>
2410
2411         * compile/compile.c (_initialize_compile): Use upper case for
2412         metasyntactic variables.
2413         * symmisc.c (_initialize_symmisc): Use upper case for
2414         metasyntactic variables.
2415         * psymtab.c (_initialize_psymtab): Use upper case for
2416         metasyntactic variables.
2417         * demangle.c (demangle_command): Use upper case for metasyntactic
2418         variables.
2419         (_initialize_demangler): Likewise.
2420         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2421         variables.
2422
2423 2019-01-03  Tom Tromey  <tom@tromey.com>
2424
2425         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2426
2427 2019-01-03  Tom Tromey  <tom@tromey.com>
2428
2429         * python/py-symtab.c (salpy_str): Update.
2430         (struct salpy_sal_object) <symtab>: Now a PyObject.
2431         (salpy_dealloc): Update.
2432         (del_objfile_sal): Use gdbpy_ref.
2433
2434 2019-01-03  Tom Tromey  <tom@tromey.com>
2435
2436         * python/py-type.c (convert_field): Use new_reference.  Return
2437         gdbpy_ref.
2438         (make_fielditem): Return gdbpy_ref.
2439         (typy_fields): Update.
2440         (typy_getitem): Update.
2441         (field_name): Return gdbpy_ref.  Use new_reference.
2442         (typy_iterator_iternext): Update.
2443
2444 2019-01-03  Tom Tromey  <tom@tromey.com>
2445
2446         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2447
2448 2019-01-03  Tom Tromey  <tom@tromey.com>
2449
2450         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2451         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2452         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2453         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2454         (pspy_set_type_printers): Likewise.
2455         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2456         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2457         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2458         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2459         (objfpy_set_type_printers): Likewise.
2460
2461 2019-01-03  Tom Tromey  <tom@tromey.com>
2462
2463         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2464         (gdbpy_print_stack): Use gdbpy_err_fetch.
2465         * python/python-internal.h (class gdbpy_err_fetch): New class.
2466         (class gdbpy_enter) <m_error_type, m_error_value,
2467         m_error_traceback>: Remove.
2468         <m_error>: New member.
2469         (gdbpy_exception_to_string): Don't declare.
2470         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2471         * python/py-value.c (convert_value_from_python): Use
2472         gdbpy_err_fetch.
2473         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2474         gdbpy_exception_to_string.
2475         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2476         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2477         gdbpy_err_fetch.
2478
2479 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2480
2481         * linux-nat.c (delete_lwp_cleanup): Delete.
2482         (struct lwp_deleter): New struct.
2483         (lwp_info_up): New typedef.
2484         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2485         lwp_info_up.
2486
2487 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2488
2489         * linux-fork.c (class scoped_switch_fork_info): New class.
2490         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2491
2492 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2493
2494         * valops.c (find_overload_match): Remove use of null_cleanup, and
2495         calls to do_cleanups.
2496
2497 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2498
2499         * compile/compile-cplus-types.c
2500         (compile_cplus_instance::decl_name): Handle changes to
2501         cp_func_name.
2502         * cp-support.c (cp_func_name): Update header comment, update
2503         return type.
2504         * cp-support.h (cp_func_name): Update return type in declaration.
2505         * valops.c (find_overload_match): Move temp_func local to top
2506         level of function and change its type.  Use temp_func to hold and
2507         delete temporary string obtained from cp_func_name.
2508
2509 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2510
2511         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2512         gdb::char_vector, remove cleanup, and update uses of `msg`.
2513
2514 2019-01-03  Jim Wilson  <jimw@sifive.com>
2515
2516         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2517
2518 2019-01-02  Tom Tromey  <tom@tromey.com>
2519
2520         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2521         (tdesc_parse_xml): Remove cleanups.
2522         * target-descriptions.h (make_cleanup_free_target_description):
2523         Don't declare.
2524         (target_desc_deleter): New struct.
2525         (target_desc_up): New typedef.
2526         * target-descriptions.c (target_desc_deleter::operator()): Rename
2527         from free_target_description.
2528         (make_cleanup_free_target_description): Remove.
2529
2530 2019-01-02  Tom Tromey  <tom@tromey.com>
2531
2532         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2533         constructor, destructor.
2534         (linespec_parser): Remove typedef.
2535         (~linespec_parser): Rename from linespec_parser_delete.
2536         (linespec_lex_to_end, linespec_complete_label)
2537         (linespec_complete): Update.
2538         (decode_line_full): Remove cleanups.
2539         (decode_line_1): Update.
2540
2541 2019-01-02  Tom Tromey  <tom@tromey.com>
2542
2543         * python/python-internal.h (inferior_to_inferior_object): Change
2544         return type.
2545         * python/py-exitedevent.c (create_exited_event_object): Update.
2546         * python/py-inferior.c (inferior_to_inferior_object): Return
2547         gdbpy_ref.
2548         (python_new_inferior, python_inferior_deleted)
2549         (thread_to_thread_object, delete_thread_object)
2550         (build_inferior_list, gdbpy_selected_inferior): Update.
2551         * python/py-infthread.c (create_thread_object): Update.  Also fail
2552         if inferior_to_inferior_object fails.
2553
2554 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2555
2556         * inferior.h (class inferior) <displaced_step_state>: New field.
2557         * infrun.h (struct displaced_step_state): Move here from
2558         infrun.c.  Initialize fields, add constructor.
2559         <inf>: Remove field.
2560         <reset>: New method.
2561         * infrun.c (struct displaced_step_inferior_state): Move to
2562         infrun.h.
2563         (displaced_step_inferior_states): Remove.
2564         (get_displaced_stepping_state): Adust.
2565         (displaced_step_in_progress_any_inferior): Adjust.
2566         (displaced_step_in_progress_thread): Adjust.
2567         (displaced_step_in_progress): Adjust.
2568         (add_displaced_stepping_state): Remove.
2569         (get_displaced_step_closure_by_addr): Adjust.
2570         (remove_displaced_stepping_state): Remove.
2571         (infrun_inferior_exit): Call displaced_step_state.reset.
2572         (use_displaced_stepping): Don't check for NULL.
2573         (displaced_step_prepare_throw): Call
2574         get_displaced_stepping_state.
2575         (displaced_step_fixup): Don't check for NULL.
2576         (prepare_for_detach): Don't check for NULL.
2577
2578 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2579
2580         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2581          in case of call that did not complete.
2582
2583 2019-01-02  Andrey Utkin  <autkin@undo.io>
2584
2585         * symfile.c (find_separate_debug_file): Fix search of debug files for
2586         remote debuggee.
2587
2588 2019-01-02  Tom Tromey  <tom@tromey.com>
2589
2590         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2591         indentation.
2592         * python/py-frame.c (frapy_older): Remove cast.
2593         (frapy_newer): Likewise.
2594         * python/py-breakpoint.c (local_setattro): Remove cast.
2595         * python/py-arch.c (archpy_name): Remove local variable.
2596         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2597
2598 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2599
2600         * unittests/basic_string_view/element_access/char/empty.cc:
2601         Fix year range in copyright header.
2602
2603 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2604
2605         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2606         Delete.
2607         <operator==>: Update with for removed field.
2608         <hash>: Likewise.
2609         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2610         <isa_features>: ...this.
2611         <abi_features>: New field.
2612         (riscv_isa_flen): Update comment.
2613         (riscv_abi_xlen): New declaration.
2614         (riscv_abi_flen): New declaration.
2615         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2616         isa_features.
2617         (riscv_abi_xlen): New function.
2618         (riscv_isa_flen): Update to get answer from isa_features.
2619         (riscv_abi_flen): New function.
2620         (riscv_has_fp_abi): Update to get answer from abi_features.
2621         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2622         xlen and flen.
2623         (riscv_call_info) <xlen, flen>: Update comment.
2624         (riscv_call_arg_struct): Remove invalid assertions
2625         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2626         is removed.
2627         (riscv_gdbarch_init): Gather isa features and abi features
2628         separately, ensure both match on the gdbarch when reusing an old
2629         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2630         a target with 64-bit float hardware.
2631
2632 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2633
2634         * source.c (search_command_helper): Stop reverse search
2635         when line 1 has been searched.
2636
2637 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2638
2639         * record-full.c (record_full_base_target::close): Rewrite
2640         record_full_core_buf_list free logic.
2641
2642 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2643
2644         * break-catch-syscall.c (print_one_catch_syscall): xfree
2645         the last text.
2646
2647 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2648
2649         * top.c (print_gdb_version): Update Copyright year in version
2650         message.
2651
2652 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2653
2654         Update copyright year range in all GDB files.
2655
2656 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2657
2658         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2659
2660 For older changes see ChangeLog-2018.
2661 \f
2662 Local Variables:
2663 mode: change-log
2664 left-margin: 8
2665 fill-column: 74
2666 version-control: never
2667 coding: utf-8
2668 End:
2669