Constify some remote-notif functions
[external/binutils.git] / gdb / ChangeLog
1 2019-01-14  Tom Tromey  <tom@tromey.com>
2
3         * remote-notif.c (handle_notification, remote_notif_ack)
4         (remote_notif_parse): Make "buf" const.
5         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6         const.
7         (remote_notif_parse, remote_notif_ack, handle_notification):
8         Likewise.
9         * remote.c (remote_notif_stop_parse): Make "buf" const.
10         (remote_target::remote_parse_stop_reply): Make "buf" const.
11         (remote_notif_stop_ack): Make "buf" const.
12
13 2019-01-14  Tom Tromey  <tom@tromey.com>
14
15         * remote.c (remote_console_output): Make parameter const.
16
17 2019-01-14  Tom Tromey  <tom@tromey.com>
18
19         * target-debug.h (target_debug_print_signals): Constify.
20         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
21         * procfs.c (procfs_target::pass_signals): Update.
22         * linux-nat.c (linux_nat_target::pass_signals): Update.
23         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
24         * target-delegates.c: Rebuild.
25         * remote.c (remote_target::program_signals): Update.
26         (remote_target::pass_signals): Update.
27         * target.c (target_pass_signals): Constify argument.
28         (target_program_signals): Likewise.
29         * target.h (struct target_ops) <pass_signals, program_signals>:
30         Constify argument.
31         (target_pass_signals, target_program_signals): Constify argument.
32
33 2019-01-14  Tom Tromey  <tom@tromey.com>
34
35         PR tui/28819:
36         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
37
38 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
39
40         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
41         field.
42         * rs6000-tdep.c: Include reggroups.h.
43         (IS_V_ALIAS_PSEUDOREG): Define.
44         (rs6000_register_name): Return names for the "vX" aliases.
45         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
46         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
47         aliases.  Call default_register_reggroup_p for all other
48         pseudo-registers.
49         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
50         New functions.
51         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
52         Handle "vX" aliases.
53         (v_alias_pseudo_register_collect): New function.
54         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
55         (rs6000_gdbarch_init): Initialize "vX" aliases as
56         pseudo-registers.  Restore registration of
57         rs6000_pseudo_register_reggroup_p with
58         set_tdesc_pseudo_register_reggroup_p.
59
60 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
61
62         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
63         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
64         set_gdbarch_num_pseudo_regs.
65
66 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
67
68         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
69         Remove arg prefixname, add do_set and do_show.
70         Add member functions set_list and show_list.
71         * cli/cli-style.c (class cli_style_option): Update accordingly.
72         (style_set_list): Move to file scope.
73         (style_show_list): Likewise.
74         (set_style): Call help_list.
75         (show_style): Call cmd_show_list.
76         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
77         Update to use the new macro.
78
79 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
80
81         * ada-lang.c (_initialize_ada_language): Expand the help text
82         for the "catch exception" command.
83
84 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
85
86         * symtab.c (matching_obj_sections): Initialize obj,
87         declare it closer to its usage.
88
89 2019-01-10  Tom Tromey  <tom@tromey.com>
90
91         * thread-iter.h (inf_threads_iterator): Use next_iterator.
92         (basic_inf_threads_range): Remove.
93         (inf_threads_range, inf_non_exited_threads_range)
94         (safe_inf_threads_range): Use next_adapter.
95
96 2019-01-10  Keith Seitz  <keiths@redhat.com>
97
98         PR gdb/23712
99         PR symtab/23010
100         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
101         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
102
103 2019-01-10  Keith Seitz  <keiths@redhat.com>
104
105         PR gdb/23712
106         PR symtab/23010
107         * dictionary.c (pending_to_vector): Remove.
108         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
109         Remove _1 suffix, replacing functions of the same name.  Update
110         all callers.
111         (dict_create_hashed, dict_create_hashed_expandable)
112         (dict_create_linear, dict_create_linear_expandable, dict_free)
113         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
114         Make functions static.
115
116 2019-01-10  Keith Seitz  <keiths@redhat.com>
117
118         PR gdb/23712
119         PR symtab/23010
120         * dictionary.h (struct dictionary): Replace declaration with
121         multidictionary.
122         (dict_create_hashed, dict_create_hashed_expandable)
123         (dict_create_linear, dict_create_linear_expandable)
124         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
125         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
126         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
127         taking multidictionary argument.
128         [ALL_DICT_SYMBOLS]: Update for multidictionary.
129         * block.h (struct block) <dict>: Change to multidictionary
130         and rename `multidict'.
131         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
132         symmisc.c: Update all dictionary references to multidictionary.
133
134 2019-01-10  Keith Seitz  <keiths@redhat.com>
135
136         PR gdb/23712
137         PR symtab/23010
138         * dictionary.c: Include unordered_map.
139         (pending_to_vector): New function.
140         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
141         Rewrite the non-"_1" functions to take vector instead
142         of linked list.
143         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
144         "new" _1 versions of the same name.
145         (multidictionary): Define.
146         (std::hash<enum language): New definition.
147         (collate_pending_symbols_by_language, mdict_create_hashed)
148         (mdict_create_hashed_expandable, mdict_create_linear)
149         (mdict_create_linear_expandable, mdict_free)
150         (find_language_dictionary, create_new_language_dictionary)
151         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
152         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
153         (mdict_size, mdict_empty): New functions.
154         * dictionary.h (mdict_iterator): Define.
155
156 2019-01-10  Pedro Alves  <palves@redhat.com>
157
158         * breakpoint.c (read_uploaded_action)
159         (create_tracepoint_from_upload): Adjust to use
160         gdb::unique_xmalloc_ptr.
161         * ctf.c (ctf_write_uploaded_tp):
162         (SET_ARRAY_FIELD): Use emplace_back.
163         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
164         * tracefile-tfile.c (tfile_write_uploaded_tp):
165         * tracepoint.c (parse_tracepoint_definition): Adjust to use
166         gdb::unique_xmalloc_ptr.
167         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
168         at_string, cond_string, cmd_strings>: Replace char pointers
169         with gdb::unique_xmalloc_ptr.
170
171 2019-01-10  Pedro Alves  <palves@redhat.com>
172
173         * solib-target.c (library_list_start_library): Don't xstrdup name.
174
175 2019-01-10  Pedro Alves  <palves@redhat.com>
176
177         * mdebugread.c (parse_partial_symbols): Use
178         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
179
180 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
181
182         * linux-fork.c (scoped_switch_fork_info)
183         <~scoped_switch_fork_info>: Fix incorrect variable name.
184
185 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
186
187         * linux-fork.c (scoped_switch_fork_info)
188         <scoped_switch_fork_info>: Make explicit.
189         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
190
191 2019-01-10  Tom Tromey  <tom@tromey.com>
192
193         * objfiles.h (objfile::reset_psymtabs): Update.
194         * objfiles.c (objfile::objfile): Update.
195         * psymtab.h (psymtab_storage::obstack): Update.
196         (psymtab_storage::m_obstack): Use gdb::optional.
197         (class psymtab_storage): Update comment.  Remove objfile
198         parameter.
199         * psymtab.c (psymtab_storage::psymtab_storage): Update.
200
201 2019-01-10  Tom Tromey  <tom@tromey.com>
202
203         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
204         <free_psymtabs>: Now private.
205         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
206         (allocate_psymtab): Use new method.
207
208 2019-01-10  Tom Tromey  <tom@tromey.com>
209
210         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
211         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
212         * mdebugread.c (parse_partial_symbols): Use
213         allocate_dependencies.
214         * dwarf2read.c (dwarf2_create_include_psymtab): Use
215         allocate_dependencies.
216         (process_psymtab_comp_unit_reader)
217         (build_type_psymtab_dependencies): Likewise.
218         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
219
220 2019-01-10  Tom Tromey  <tom@tromey.com>
221
222         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
223         PSYMBOL_SET_LANGUAGE.
224         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
225
226 2019-01-10  Tom Tromey  <tom@tromey.com>
227
228         * psymtab.h (psymtab_storage::obstack): New method.
229         <m_obstack>: Rename from obstack; now private.
230         * psymtab.c (psymtab_storage): Update.
231         * dwarf2read.c (create_addrmap_from_index)
232         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
233         Update.
234
235 2019-01-10  Tom Tromey  <tom@tromey.com>
236
237         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
238         * objfiles.h (objfile::reset_psymtabs): New method.
239
240 2019-01-10  Tom Tromey  <tom@tromey.com>
241
242         * symmisc.c (print_symbol_bcache_statistics): Update.
243         (print_objfile_statistics): Update.
244         * symfile.c (reread_symbols): Update.
245         * psymtab.h (class psymtab_storage): New.
246         * psymtab.c (psymtab_storage): New constructor.
247         (~psymtab_storage): New destructor.
248         (require_partial_symbols): Update.
249         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
250         (find_pc_sect_psymtab, find_pc_sect_psymbol)
251         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
252         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
253         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
254         (start_psymtab_common, end_psymtab_common)
255         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
256         (allocate_psymtab): Update.
257         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
258         Update.
259         (dump_psymtab_addrmap, maintenance_print_psymbols)
260         (maintenance_check_psymtabs): Update.
261         (class objfile_psymtabs): Move to objfiles.h.
262         * psympriv.h (discard_psymtab): Now inline.
263         (psymtab_discarder::psymtab_discarder): Update.
264         (psymtab_discarder::~psymtab_discarder): Update.
265         (ALL_OBJFILE_PSYMTABS): Rewrite.
266         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
267         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
268         Remove fields.
269         <partial_symtabs>: New field.
270         (class objfile_psymtabs): Move from psymtab.h.  Update.
271         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
272         psymbol_cache.
273         (objfile::~objfile): Don't destroy psymbol_cache.
274         * mdebugread.c (parse_partial_symbols): Update.
275         * dwarf2read.c (create_addrmap_from_index)
276         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
277         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
278         (add_partial_subprogram, dwarf2_ranges_read): Update.
279         * dwarf-index-write.c (write_address_map)
280         (write_one_signatured_type, recursively_write_psymbols)
281         (class debug_names, class debug_names, write_psymtabs_to_index):
282         Update.
283
284 2019-01-10  Tom Tromey  <tom@tromey.com>
285
286         * symtab.h (SYMBOL_SET_NAMES): Update.
287         (symbol_set_names): Update.
288         (MSYMBOL_SET_NAMES): Update.
289         * symtab.c (symbol_set_names): Change argument to be an
290         objfile_per_bfd_storage.
291         * psymtab.c (add_psymbol_to_bcache): Update.
292         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
293
294 2019-01-10  Tom Tromey  <tom@tromey.com>
295
296         * symtab.c (create_demangled_names_hash): Change argument to be an
297         objfile_per_bfd_storage.
298         (symbol_set_names): Update.
299
300 2019-01-10  Tom Tromey  <tom@tromey.com>
301
302         * xcoffread.c (xcoff_initial_scan): Unconditionally call
303         init_psymbol_list.
304         * psymtab.c (init_psymbol_list): Do nothing if already called.
305         * psympriv.h (init_psymbol_list): Add comment.
306         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
307         init_psymbol_list.
308         * dbxread.c (dbx_symfile_read): Unconditionally call
309         init_psymbol_list.
310
311 2019-01-10  Tom Tromey  <tom@tromey.com>
312
313         * xcoffread.c (scan_xcoff_symtab): Update.
314         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
315         "where".
316         * mdebugread.c (parse_partial_symbols)
317         (handle_psymbol_enumerators): Update.
318         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
319         * dbxread.c (read_dbx_symtab): Update.
320         * psympriv.h (psymbol_placement): New enum.
321         (add_psymbol_to_list): Update.
322
323 2019-01-10  Tom Tromey  <tom@tromey.com>
324
325         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
326         static_psymbols parameters.
327         (scan_xcoff_symtab): Update.
328         * psymtab.c (start_psymtab_common): Remove global_psymbols and
329         static_psymbols parameters.
330         * psympriv.h (start_psymtab_common): Update.
331         * mdebugread.c (parse_partial_symbols): Update.
332         * dwarf2read.c (create_partial_symtab): Update.
333         * dbxread.c (read_dbx_symtab): Update.
334         (start_psymtab): Remove global_psymbols and static_psymbols
335         parameters.
336
337 2019-01-10  Tom Tromey  <tom@tromey.com>
338
339         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
340         * psymtab.c (allocate_psymtab): Add comment.
341         * psympriv.h (allocate_psymtab): Add comment.
342         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
343         initializations.
344         * dbxread.c (dbx_end_psymtab): Remove some initializations.
345
346 2019-01-10  Tom Tromey  <tom@tromey.com>
347
348         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
349         Don't declare.
350         * mipsread.c: Include mdebugread.h.
351         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
352         Declare.
353         * elfread.c: Include mdebugread.h.
354
355 2019-01-09  Tom Tromey  <tom@tromey.com>
356
357         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
358         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
359         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
360         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
361         (psym_lookup_symbol, psym_find_last_source_symtab)
362         (psym_forget_cached_source_info, psym_print_stats)
363         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
364         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
365         (psym_map_matching_symbols, psym_expand_symtabs_matching)
366         (psym_find_compunit_symtab_by_address)
367         (maintenance_print_psymbols, maintenance_info_psymtabs)
368         (maintenance_check_psymtabs): Use ranged for.
369         * psymtab.h (class objfile_psymtabs): New.
370         (require_partial_symbols): Return objfile_psymtabs.
371         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
372
373 2019-01-09  Tom Tromey  <tom@tromey.com>
374
375         * symfile.c (overlay_invalidate_all, find_pc_overlay)
376         (find_pc_mapped_section, list_overlays_command)
377         (map_overlay_command, unmap_overlay_command)
378         (simple_overlay_update): Use all_objfiles.
379         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
380         * printcmd.c (info_symbol_command): Use all_objfiles.
381         * objfiles.h (ALL_OBJSECTIONS): Remove.
382         * maint.c (maintenance_translate_address): Use all_objfiles.
383         * gcore.c (gcore_create_callback): Use all_objfiles.
384         (objfile_find_memory_regions): Likewise.
385
386 2019-01-09  Tom Tromey  <tom@tromey.com>
387
388         * symtab.c (find_line_symtab, info_sources_command)
389         (make_source_files_completion_list): Use objfile_compunits.
390         * source.c (select_source_symtab): Use objfile_compunits.
391         * objfiles.h (struct objfile): Update comment.
392         (ALL_OBJFILES): Remove.
393         (ALL_FILETABS): Remove.
394         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
395         objfile_compunits.
396
397 2019-01-09  Tom Tromey  <tom@tromey.com>
398
399         * symmisc.c (print_objfile_statistics, dump_objfile)
400         (maintenance_print_symbols): Use compunit_filetabs.
401         * source.c (forget_cached_source_info_for_objfile): Use
402         compunit_filetabs.
403         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
404         (ALL_FILETABS): Use compunit_filetabs.
405         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
406         * coffread.c (coff_symtab_read): Use compunit_filetabs.
407
408 2019-01-09  Tom Tromey  <tom@tromey.com>
409
410         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
411         (compunit_filetabs): New.
412         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
413         compunit_filetabs.
414         (info_sources_command, make_source_files_completion_list): Remove
415         declaration.
416         * symmisc.c (print_objfile_statistics, dump_objfile)
417         (maintenance_print_symbols): Remove declaration.
418         (maintenance_info_symtabs): Use compunit_filetabs.
419         (maintenance_info_line_tables): Likewise.
420         * source.c (select_source_symtab): Change local variable name.
421         (forget_cached_source_info_for_objfile): Remove declaration.
422         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
423         * objfiles.c (objfile_relocate1): Remove declaration.
424         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
425         declaration.
426         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
427         * coffread.c (coff_symtab_read): Remove declaration.
428         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
429         compunit_filetabs.
430
431 2019-01-09  Tom Tromey  <tom@tromey.com>
432
433         * symtab.c (lookup_objfile_from_block)
434         (find_pc_sect_compunit_symtab, search_symbols)
435         (default_collect_symbol_completion_matches_break_on): Use
436         objfile_compunits.
437         * objfiles.h (ALL_COMPUNITS): Remove.
438         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
439         * cp-support.c (add_symbol_overload_list_qualified): Use
440         objfile_compunits.
441         * ada-lang.c (ada_collect_symbol_completion_matches)
442         (ada_add_global_exceptions): Use objfile_compunits.
443
444 2019-01-09  Tom Tromey  <tom@tromey.com>
445
446         * source.c (select_source_symtab)
447         (forget_cached_source_info_for_objfile): Remove declaration.
448         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
449         declaration.
450         * maint.c (count_symtabs_and_blocks): Remove declaration.
451         * cp-support.c (add_symbol_overload_list_qualified): Remove
452         declaration.
453         * coffread.c (coff_symtab_read): Remove declaration.
454         * symtab.c (lookup_symbol_in_objfile_symtabs)
455         (basic_lookup_transparent_type_1): Use objfile_compunits.
456         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
457         (info_sources_command, search_symbols)
458         (default_collect_symbol_completion_matches_break_on)
459         (make_source_files_completion_list): Remove declaration.
460         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
461         (ada_collect_symbol_completion_matches)
462         (ada_add_global_exceptions): Remove declaration.
463         * linespec.c (iterate_over_all_matching_symtabs): Use
464         objfile_compunits.
465         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
466         (class objfile_compunits): New.
467         (ALL_COMPUNITS): Use objfile_compunits.
468         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
469         (maintenance_check_symtabs, maintenance_info_line_tables): Use
470         objfile_compunits.
471         * objfiles.c (objfile_relocate1): Use objfile_compunits.
472
473 2019-01-09  Tom Tromey  <tom@tromey.com>
474
475         * symtab.c (search_symbols)
476         (default_collect_symbol_completion_matches_break_on): Use
477         objfile_msymbols.
478         * ada-lang.c (ada_lookup_simple_minsym)
479         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
480         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
481         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
482         objfile_msymbols.
483         * coffread.c (coff_symfile_read): Use objfile_msymbols.
484         * symmisc.c (dump_msymbols): Use objfile_msymbols.
485         * objc-lang.c (find_methods): Use objfile_msymbols.
486         (info_selectors_command, info_classes_command): Likewise.
487         * stabsread.c (scan_file_globals): Use objfile_msymbols.
488         * objfiles.h (class objfile_msymbols): New.
489         (ALL_OBJFILE_MSYMBOLS): Remove.
490         (ALL_MSYMBOLS): Remove.
491
492 2019-01-09  Tom Tromey  <tom@tromey.com>
493
494         * common/next-iterator.h (next_adapter): Add Iterator template
495         parameter.
496         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
497         (class all_objfiles_safe): New.
498         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
499         * objfiles.c (put_objfile_before): Update comment.
500         (add_separate_debug_objfile): Likewise.
501         (free_all_objfiles): Use all_objfiles_safe.
502         (objfile_purge_solibs): Likewise.
503
504 2019-01-09  Tom Tromey  <tom@tromey.com>
505
506         * symtab.c (iterate_over_symtabs, matching_obj_sections)
507         (expand_symtab_containing_pc, lookup_static_symbol)
508         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
509         (find_symbol_at_address, find_line_symtab, find_main_name): Use
510         all_objfiles.
511         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
512         * breakpoint.c (create_overlay_event_breakpoint)
513         (create_longjmp_master_breakpoint)
514         (create_std_terminate_master_breakpoint)
515         (create_exception_master_breakpoint): Use all_objfiles.
516         * linux-thread-db.c (try_thread_db_load_from_pdir)
517         (has_libpthread): Use all_objfiles.
518         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
519         * linespec.c (iterate_over_all_matching_symtabs)
520         (search_minsyms_for_name): Use all_objfiles.
521         * maint.c (maintenance_info_sections): Use all_objfiles.
522         * main.c (captured_main_1): Use all_objfiles.
523         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
524         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
525         * guile/scm-pretty-print.c
526         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
527         * solib-spu.c (append_ocl_sos): Use all_objfiles.
528         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
529         (maintenance_print_msymbols): Use all_objfiles.
530         * source.c (select_source_symtab): Use all_objfiles.
531         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
532         * symfile.c (remove_symbol_file_command)
533         (expand_symtabs_matching, map_symbol_filenames): Use
534         all_objfiles.
535         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
536         all_objfiles.
537         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
538         * objc-lang.c (find_methods): Use all_objfiles.
539         * objfiles.c (have_partial_symbols, have_full_symbols)
540         (have_minimal_symbols, qsort_cmp)
541         (default_iterate_over_objfiles_in_search_order): Use
542         all_objfiles.
543         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
544         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
545         (maintenance_check_psymtabs): Use all_objfiles.
546         (ALL_PSYMTABS): Remove.
547         * compile/compile-object-run.c (do_module_cleanup): Use
548         all_objfiles.
549         * blockframe.c (find_pc_partial_function): Use all_objfiles.
550         * cp-support.c (add_symbol_overload_list_qualified): Use
551         all_objfiles.
552         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
553         Use all_objfiles.
554         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
555         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
556         all_objfiles.
557         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
558         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
559         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
560         Uses all_objfiles.
561         * solib.c (solib_read_symbols): Use all_objfiles
562
563 2019-01-09  Tom Tromey  <tom@tromey.com>
564
565         * probe.c (parse_probes_in_pspace): Use all_objfiles.
566         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
567         all_objfiles.
568         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
569         * symmisc.c (print_symbol_bcache_statistics)
570         (print_objfile_statistics, maintenance_print_objfiles)
571         (maintenance_info_symtabs, maintenance_check_symtabs)
572         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
573         all_objfiles.
574         * source.c (forget_cached_source_info): Use all_objfiles.
575         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
576         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
577         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
578         * objfiles.c (update_section_map): Use all_objfiles.
579         (shared_objfile_contains_address_p): Likewise.
580         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
581         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
582
583 2019-01-09  Tom Tromey  <tom@tromey.com>
584
585         * common/next-iterator.h: New file.
586         * objfiles.h (class all_objfiles): New.
587         (struct objfile_iterator): New.
588
589 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
590
591         * NEWS: Move the description of the changed "frame", "select-frame",
592          and "info frame" commands to the Changed commands section.
593
594 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
595
596         * gdbtypes.c (check_stub_method_group): Remove handling of old
597         mangling schemes.
598         * linespec.c (find_methods): Likewise.
599         * stabsread.c (read_member_functions): Likewise.
600         * valops.c (search_struct_method): Likewise.
601         (value_struct_elt_for_reference): Likewise.
602         * NEWS: Mention this change.
603
604 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
605
606         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
607         print_source_lines.
608         * source.c (print_source_lines_base): Update line number check.
609         (print_source_lines): New function.
610         (source_lines_range::source_lines_range): New function.
611         * source.h (class source_lines_range): New class.
612         (print_source_lines): New declaration.
613
614 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
615
616         * linespec.c (linespec_state_destructor): Free self->canonical_names.
617
618 2019-01-08  Tom Tromey  <tom@tromey.com>
619             Simon Marchi  <simon.marchi@ericsson.com>
620
621         PR gdb/24060
622         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
623         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
624         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
625         * f-exp.y (DOLLAR_VARIABLE): Likewise.
626         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
627         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
628
629 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
630
631         * source.c (select_source_symtab): Move header comment to
632         declaration in source.h.
633         (forget_cached_source_info_for_objfile): Likewise.
634         (forget_cached_source_info): Likewise.
635         (identify_source_line): Likewise.
636         * source.h (identify_source_line): Move declaration from symtab.h
637         and add comment from source.c
638         (print_source_lines): Likewise.
639         (forget_cached_source_info_for_objfile): Likewise.
640         (forget_cached_source_info): Likewise.
641         (select_source_symtab): Likewise.
642         (enum print_source_lines_flag): Move definition from symtab.h.
643         * symtab.h (identify_source_line): Move declaration to source.h.
644         (print_source_lines): Likewise.
645         (forget_cached_source_info_for_objfile): Likewise.
646         (forget_cached_source_info): Likewise.
647         (select_source_symtab): Likewise.
648         (enum print_source_lines_flag): Move definition to source.h.
649         * tui/tui-hooks.c: Add 'source.h' include.
650
651 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
652
653         * source.c (print_source_lines_base): Handle requests to print
654         reverse line number sequences, and guard against empty lines
655         string.
656
657 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
658
659         * source.c (print_source_lines_base): Fix skip of '\r' if next
660         character is '\n'.
661
662 2019-01-06  Tom Tromey  <tom@tromey.com>
663
664         * c-exp.y (struct c_parse_state) <macro_original_text,
665         expansion_obstack>: New member.
666         (macro_original_text, expansion_obstack): Remove globals.
667         (scan_macro_expansion, scanning_macro_expansion)
668         (finished_macro_expansion): Update.
669         (scan_macro_cleanup): Remove.
670         (yylex, c_parse): Update.
671
672 2019-01-06  Tom Tromey  <tom@tromey.com>
673
674         * c-exp.y (struct c_parse_state) <strings>: New member.
675         (operator_stoken): Update.
676
677 2019-01-06  Tom Tromey  <tom@tromey.com>
678
679         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
680         (union type_stack_elt) <typelist_val>: Now a pointer to
681         std::vector.
682         (type_stack_cleanup): Don't declare.
683         (push_typelist): Update.
684         * parse.c (pop_typelist): Return a std::vector.
685         (push_typelist): Take a std::vector.
686         (follow_types): Update.  Do not free args.
687         (type_stack_cleanup): Remove.
688         * c-exp.y (struct c_parse_state): New.
689         (cpstate): New global.
690         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
691         (nonempty_typelist): Update.
692         (func_mod): Create a new vector.
693         (c_parse): Create a c_parse_state.
694         (check_parameter_typelist): Do not delete params.
695         (function_method): Update.  Do not delete type_list.
696
697 2019-01-06  Tom Tromey  <tom@tromey.com>
698
699         PR gdb/28155:
700         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
701         check_typedef.
702         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
703         (print_return_value): Likewise.
704
705 2019-01-05  Tom Tromey  <tom@tromey.com>
706
707         * contrib/cleanup_check.py: Remove.
708         * contrib/gcc-with-excheck: Remove.
709         * contrib/exsummary.py: Remove.
710         * contrib/excheck.py: Remove.
711
712 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
713
714         * thread.c (delete_thread_1): Add gdb_assert that THR is not
715         NULL. Initialize tpprev to NULL instead of assigning it
716         to NULL on the next statement.
717         * windows-nat.c (windows_delete_thread): Remove check for
718         main_thread_id before printing thread exit notifications.
719         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
720         Remove thread ID check against main_thread_id.
721         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
722         windows_delete_thread.
723         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
724
725 2019-01-04  Tom Tromey  <tom@tromey.com>
726
727         * compile/compile.c (_initialize_compile): Use upper case for
728         metasyntactic variables.
729         * symmisc.c (_initialize_symmisc): Use upper case for
730         metasyntactic variables.
731         * psymtab.c (_initialize_psymtab): Use upper case for
732         metasyntactic variables.
733         * demangle.c (demangle_command): Use upper case for metasyntactic
734         variables.
735         (_initialize_demangler): Likewise.
736         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
737         variables.
738
739 2019-01-03  Tom Tromey  <tom@tromey.com>
740
741         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
742
743 2019-01-03  Tom Tromey  <tom@tromey.com>
744
745         * python/py-symtab.c (salpy_str): Update.
746         (struct salpy_sal_object) <symtab>: Now a PyObject.
747         (salpy_dealloc): Update.
748         (del_objfile_sal): Use gdbpy_ref.
749
750 2019-01-03  Tom Tromey  <tom@tromey.com>
751
752         * python/py-type.c (convert_field): Use new_reference.  Return
753         gdbpy_ref.
754         (make_fielditem): Return gdbpy_ref.
755         (typy_fields): Update.
756         (typy_getitem): Update.
757         (field_name): Return gdbpy_ref.  Use new_reference.
758         (typy_iterator_iternext): Update.
759
760 2019-01-03  Tom Tromey  <tom@tromey.com>
761
762         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
763
764 2019-01-03  Tom Tromey  <tom@tromey.com>
765
766         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
767         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
768         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
769         (pspy_set_frame_filters, pspy_set_frame_unwinders)
770         (pspy_set_type_printers): Likewise.
771         * python/py-function.c (fnpy_init): Use gdbpy_ref.
772         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
773         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
774         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
775         (objfpy_set_type_printers): Likewise.
776
777 2019-01-03  Tom Tromey  <tom@tromey.com>
778
779         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
780         (gdbpy_print_stack): Use gdbpy_err_fetch.
781         * python/python-internal.h (class gdbpy_err_fetch): New class.
782         (class gdbpy_enter) <m_error_type, m_error_value,
783         m_error_traceback>: Remove.
784         <m_error>: New member.
785         (gdbpy_exception_to_string): Don't declare.
786         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
787         * python/py-value.c (convert_value_from_python): Use
788         gdbpy_err_fetch.
789         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
790         gdbpy_exception_to_string.
791         (gdbpy_handle_exception): Use gdbpy_err_fetch.
792         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
793         gdbpy_err_fetch.
794
795 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
796
797         * linux-nat.c (delete_lwp_cleanup): Delete.
798         (struct lwp_deleter): New struct.
799         (lwp_info_up): New typedef.
800         (linux_nat_target::follow_fork): Delete cleanup, and make use of
801         lwp_info_up.
802
803 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
804
805         * linux-fork.c (class scoped_switch_fork_info): New class.
806         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
807
808 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
809
810         * valops.c (find_overload_match): Remove use of null_cleanup, and
811         calls to do_cleanups.
812
813 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
814
815         * compile/compile-cplus-types.c
816         (compile_cplus_instance::decl_name): Handle changes to
817         cp_func_name.
818         * cp-support.c (cp_func_name): Update header comment, update
819         return type.
820         * cp-support.h (cp_func_name): Update return type in declaration.
821         * valops.c (find_overload_match): Move temp_func local to top
822         level of function and change its type.  Use temp_func to hold and
823         delete temporary string obtained from cp_func_name.
824
825 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
826
827         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
828         gdb::char_vector, remove cleanup, and update uses of `msg`.
829
830 2019-01-03  Jim Wilson  <jimw@sifive.com>
831
832         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
833
834 2019-01-02  Tom Tromey  <tom@tromey.com>
835
836         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
837         (tdesc_parse_xml): Remove cleanups.
838         * target-descriptions.h (make_cleanup_free_target_description):
839         Don't declare.
840         (target_desc_deleter): New struct.
841         (target_desc_up): New typedef.
842         * target-descriptions.c (target_desc_deleter::operator()): Rename
843         from free_target_description.
844         (make_cleanup_free_target_description): Remove.
845
846 2019-01-02  Tom Tromey  <tom@tromey.com>
847
848         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
849         constructor, destructor.
850         (linespec_parser): Remove typedef.
851         (~linespec_parser): Rename from linespec_parser_delete.
852         (linespec_lex_to_end, linespec_complete_label)
853         (linespec_complete): Update.
854         (decode_line_full): Remove cleanups.
855         (decode_line_1): Update.
856
857 2019-01-02  Tom Tromey  <tom@tromey.com>
858
859         * python/python-internal.h (inferior_to_inferior_object): Change
860         return type.
861         * python/py-exitedevent.c (create_exited_event_object): Update.
862         * python/py-inferior.c (inferior_to_inferior_object): Return
863         gdbpy_ref.
864         (python_new_inferior, python_inferior_deleted)
865         (thread_to_thread_object, delete_thread_object)
866         (build_inferior_list, gdbpy_selected_inferior): Update.
867         * python/py-infthread.c (create_thread_object): Update.  Also fail
868         if inferior_to_inferior_object fails.
869
870 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
871
872         * inferior.h (class inferior) <displaced_step_state>: New field.
873         * infrun.h (struct displaced_step_state): Move here from
874         infrun.c.  Initialize fields, add constructor.
875         <inf>: Remove field.
876         <reset>: New method.
877         * infrun.c (struct displaced_step_inferior_state): Move to
878         infrun.h.
879         (displaced_step_inferior_states): Remove.
880         (get_displaced_stepping_state): Adust.
881         (displaced_step_in_progress_any_inferior): Adjust.
882         (displaced_step_in_progress_thread): Adjust.
883         (displaced_step_in_progress): Adjust.
884         (add_displaced_stepping_state): Remove.
885         (get_displaced_step_closure_by_addr): Adjust.
886         (remove_displaced_stepping_state): Remove.
887         (infrun_inferior_exit): Call displaced_step_state.reset.
888         (use_displaced_stepping): Don't check for NULL.
889         (displaced_step_prepare_throw): Call
890         get_displaced_stepping_state.
891         (displaced_step_fixup): Don't check for NULL.
892         (prepare_for_detach): Don't check for NULL.
893
894 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
895
896         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
897          in case of call that did not complete.
898
899 2019-01-02  Andrey Utkin  <autkin@undo.io>
900
901         * symfile.c (find_separate_debug_file): Fix search of debug files for
902         remote debuggee.
903
904 2019-01-02  Tom Tromey  <tom@tromey.com>
905
906         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
907         indentation.
908         * python/py-frame.c (frapy_older): Remove cast.
909         (frapy_newer): Likewise.
910         * python/py-breakpoint.c (local_setattro): Remove cast.
911         * python/py-arch.c (archpy_name): Remove local variable.
912         * python/py-type.c (gdbpy_lookup_type): Remove cast.
913
914 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
915
916         * unittests/basic_string_view/element_access/char/empty.cc:
917         Fix year range in copyright header.
918
919 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
920
921         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
922         Delete.
923         <operator==>: Update with for removed field.
924         <hash>: Likewise.
925         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
926         <isa_features>: ...this.
927         <abi_features>: New field.
928         (riscv_isa_flen): Update comment.
929         (riscv_abi_xlen): New declaration.
930         (riscv_abi_flen): New declaration.
931         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
932         isa_features.
933         (riscv_abi_xlen): New function.
934         (riscv_isa_flen): Update to get answer from isa_features.
935         (riscv_abi_flen): New function.
936         (riscv_has_fp_abi): Update to get answer from abi_features.
937         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
938         xlen and flen.
939         (riscv_call_info) <xlen, flen>: Update comment.
940         (riscv_call_arg_struct): Remove invalid assertions
941         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
942         is removed.
943         (riscv_gdbarch_init): Gather isa features and abi features
944         separately, ensure both match on the gdbarch when reusing an old
945         gdbarch.  Relax an error check to allow 32-bit abi float to run on
946         a target with 64-bit float hardware.
947
948 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
949
950         * source.c (search_command_helper): Stop reverse search
951         when line 1 has been searched.
952
953 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
954
955         * record-full.c (record_full_base_target::close): Rewrite
956         record_full_core_buf_list free logic.
957
958 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
959
960         * break-catch-syscall.c (print_one_catch_syscall): xfree
961         the last text.
962
963 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
964
965         * top.c (print_gdb_version): Update Copyright year in version
966         message.
967
968 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
969
970         Update copyright year range in all GDB files.
971
972 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
973
974         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
975
976 For older changes see ChangeLog-2018.
977 \f
978 Local Variables:
979 mode: change-log
980 left-margin: 8
981 fill-column: 74
982 version-control: never
983 coding: utf-8
984 End:
985