gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
   4         declare.
   5         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
   6         Rename from tui_first_reg_element_no_inline.
   7         (tui_display_reg_element_at_line)
   8         (tui_display_registers_from_line): Update.
   9         * tui/tui-data.h (struct tui_data_window)
  10         <first_reg_element_no_inline>: New method.
  11
  12 2019-07-17  Tom Tromey  <tom@tromey.com>
  13
  14         * tui/tui-windata.c (tui_display_data_from)
  15         (tui_data_window::do_scroll_vertical): Update.
  16         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
  17         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
  18         Rename from tui_line_from_reg_element_no.
  19         (tui_display_registers_from_line): Update.
  20         * tui/tui-data.h (struct tui_data_window)
  21         <line_from_reg_element_no>: New method.
  22
  23 2019-07-17  Tom Tromey  <tom@tromey.com>
  24
  25         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
  26         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
  27         tui_last_regs_line_no.
  28         (tui_display_reg_element_at_line)
  29         (tui_display_registers_from_line): Update.
  30         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
  31         method.
  32
  33 2019-07-17  Tom Tromey  <tom@tromey.com>
  34
  35         PR tui/24722:
  36         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
  37         (tui_update_breakpoint_info): Add "being_deleted" parameter.
  38         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
  39         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
  40         (tui_update_breakpoint_info): Likewise.
  41         * tui/tui-hooks.c (tui_event_create_breakpoint)
  42         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
  43         Update.
  44
  45 2019-07-17  Tom Tromey  <tom@tromey.com>
  46
  47         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
  48
  49 2019-07-17  Tom Tromey  <tom@tromey.com>
  50
  51         * tui/tui-winsource.c (tui_update_source_window_as_is)
  52         (tui_update_source_windows_with_addr): Update.
  53         * tui/tui-source.h (tui_set_source_content)
  54         (tui_show_symtab_source): Add "win_info" parameter.
  55         * tui/tui-source.c (tui_set_source_content): Add "win_info"
  56         parameter.
  57         (tui_show_symtab_source): Likewise.
  58
  59 2019-07-17  Tom Tromey  <tom@tromey.com>
  60
  61         * tui/tui-wingeneral.c
  62         (tui_check_and_display_highlight_if_needed): Check can_highlight.
  63
  64 2019-07-17  Tom Tromey  <tom@tromey.com>
  65
  66         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
  67         (struct tui_cmd_window) <can_scroll>: New method.
  68         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
  69         method.
  70
  71 2019-07-17  Tom Tromey  <tromey@adacore.com>
  72
  73         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
  74         do_field_signed>: Rename.  Change type of "value".
  75         * ui-out.c (ui_out::field_signed): Rename from field_int.
  76         Change type of "value".
  77         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
  78         type of "value".
  79         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
  80         do_field_int.  Change type of "value".
  81         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
  82         do_field_int.  Change type of "value".
  83         * tracepoint.c (trace_status_mi, tfind_1)
  84         (print_one_static_tracepoint_marker): Update.
  85         * thread.c (print_thread_info_1, print_selected_thread_frame):
  86         Update.
  87         * stack.c (print_frame, print_frame_info): Update.
  88         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
  89         Update.
  90         * source.c (print_source_lines_base): Update.
  91         * skip.c (info_skip_command): Update.
  92         * record-btrace.c (btrace_ui_out_decode_error)
  93         (btrace_call_history_src_line): Update.
  94         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
  95         Update.
  96         * progspace.c (print_program_space): Update.
  97         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
  98         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
  99         do_field_int.  Change type of "value".
 100         * mi/mi-out.c (mi_ui_out::do_table_begin)
 101         (mi_ui_out::do_table_header): Update.
 102         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 103         type of "value".
 104         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 105         (mi_cmd_data_list_changed_registers, output_register)
 106         (mi_cmd_data_read_memory, mi_load_progress)
 107         (mi_cmd_trace_frame_collected): Update.
 108         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 109         Update.
 110         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 111         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 112         (mi_cmd_var_list_children, varobj_update_one): Update.
 113         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 114         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 115         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 116         * inferior.c (print_inferior): Update.
 117         * gdb_bfd.c (print_one_bfd): Update.
 118         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 119         Update.
 120         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 121         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 122         do_field_int.  Change type of "value".
 123         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 124         do_field_int.  Change type of "value".
 125         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 126         (print_one_breakpoint_location, print_it_catch_fork)
 127         (print_one_catch_fork, print_it_catch_vfork)
 128         (print_one_catch_vfork, print_it_catch_solib)
 129         (print_it_catch_exec, print_it_ranged_breakpoint)
 130         (print_mention_watchpoint, print_mention_masked_watchpoint)
 131         (bkpt_print_it, update_static_tracepoint): Update.
 132         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 133         * break-catch-syscall.c (print_it_catch_syscall): Update.
 134         * ada-tasks.c (print_ada_task_info): Update.
 135         * ada-lang.c (print_it_exception, print_mention_exception):
 136         Update.
 137
 138 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 139
 140         PR breakpoints/24541
 141         * gdbarch.c: Regenerate.
 142         * gdbarch.h: Regenerate.
 143         * gdbarch.sh: Adjust return type and parameter types for
 144         'stap_adjust_register'.
 145         (i386_stap_adjust_register): Adjust signature and return new
 146         register name.
 147         * stap-probe.c (stap_parse_register_operand): Adjust use of
 148         'gdbarch_stap_adjust_register'.
 149
 150 2019-07-17  Tom Tromey  <tromey@adacore.com>
 151
 152         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 153         declare VEC.
 154         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 155         std::vector.
 156         (struct s390_process_info): Add initializers.
 157         (s390_add_process): Use new.
 158         (s390_linux_nat_target::low_forget_process): Use delete.
 159         (s390_linux_nat_target::low_new_fork)
 160         (s390_linux_nat_target::stopped_by_watchpoint)
 161         (s390_linux_nat_target::low_prepare_to_resume)
 162         (s390_linux_nat_target::insert_watchpoint)
 163         (s390_linux_nat_target::insert_hw_breakpoint)
 164         (s390_linux_nat_target::remove_watchpoint)
 165         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 166
 167 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 168
 169         * aarch64-fbsd-nat.c: Include regcache.h.
 170         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 171         argument.
 172         (aarch64_fbsd_nat_target::fetch_registers)
 173         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 174         variable.
 175         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 176
 177 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 178
 179         * fbsd-nat.c: Include gdbarch.h.
 180
 181 2019-07-15  Tom Tromey  <tromey@adacore.com>
 182
 183         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 184
 185 2019-07-15  Tom Tromey  <tromey@adacore.com>
 186
 187         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 188         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 189         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 190         * cli-out.c (cli_ui_out::do_field_int): New method.
 191         * ui-out.c (ui_out::field_unsigned): New method.
 192         * symfile.c (generic_load): Use field_unsigned.
 193         (print_transfer_performance): Likewise.
 194         * record-btrace.c (ui_out_field_uint): Remove.
 195         (btrace_call_history_insn_range, btrace_call_history): Use
 196         field_unsigned.
 197         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 198         field_unsigned.
 199         * ui-out.h (class ui_out) <field_unsigned>: New method.
 200         <do_field_unsigned>: Likewise.
 201
 202 2019-07-15  Tom Tromey  <tromey@adacore.com>
 203
 204         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 205         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 206         * target.c (flash_erase_command): Use field_string.
 207         * infrun.c (print_signal_received_reason): Use field_string.
 208         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 209         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 210         field_string.
 211         * ada-tasks.c (print_ada_task_info): Use field_string.
 212
 213 2019-07-15  Tom Tromey  <tromey@adacore.com>
 214
 215         * target.c (flash_erase_command): Use field_core_addr.
 216         * symfile.c (generic_load): Use field_core_addr.
 217         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 218         Use field_core_addr.
 219         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 220         field_core_addr.
 221
 222 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 223
 224         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 225         value if its desired type is smaller than a CORE_ADDR and signed.
 226
 227 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 228
 229         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 230         of changes to field names, and use new is_reference field to
 231         decide if a property is a reference or not.
 232         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 233         field.
 234         (struct dwarf2_property_baton): Update header comment, rename
 235         'referenced_type' to 'property_type' and update comments.
 236         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 237         default property type, store in property baton, update to take
 238         accound of renamed field.
 239         (read_func_scope): Update call to attr_to_dynamic_prop.
 240         (read_array_type): Likewise.
 241         (dwarf2_per_cu_addr_sized_int_type): New function.
 242         (read_subrange_index_type): Move type finding code to
 243         dwarf2_per_cu_addr_sized_int_type.
 244         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 245         (dwarf2_per_cu_addr_type): New function.
 246         (set_die_type): Update calls to attr_to_dynamic_prop.
 247
 248 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 249
 250         * dwarf2read.c (read_subrange_index_type): New function.
 251         (read_subrange_type): Move code into new function and call it.
 252         * gdbtypes.c (create_range_type): Add some asserts.
 253
 254 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 255
 256         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 257         update return statements.
 258         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 259         declaration, and update comment to match.
 260         * gdbtypes.c (resolve_dynamic_array): Update call to
 261         dwarf2_evaluate_property to match new return type.
 262
 263 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 264
 265         * valarith.c (value_subscripted_rvalue): Change lowerbound
 266         parameter type from int to LONGEST.
 267         * value.h (value_subscripted_rvalue): Likewise in declaration.
 268
 269 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 270
 271         * cli/cli-utils.c (info_print_command_completer): New function.
 272         * cli/cli-utils.h: Add 'completer.h' include, and forward
 273         declaration for 'struct cmd_list_element'.
 274         (info_print_command_completer): Declare.
 275         * stack.c (_initialize_stack): Add completer for 'info locals' and
 276         'info args'.
 277         * symtab.c (_initialize_symtab): Add completer for 'info
 278         variables' and 'info functions'.
 279         * NEWS: Mention completion for additional info commands.
 280
 281 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 282
 283         * cli/cli-utils.c (extract_info_print_args): Delete.
 284         (extract_arg_maybe_quoted): Delete.
 285         (info_print_options_defs): New variable.
 286         (make_info_print_options_def_group): New function.
 287         (extract_info_print_options): Define new function.
 288         * cli/cli-utils.h (extract_info_print_args): Delete.
 289         (struct info_print_options): New structure.
 290         (extract_info_print_options): Declare new function.
 291         * stack.c (info_locals_command): Update to use new
 292         extract_info_print_options, also add a header comment.
 293         (info_args_command): Likewise.
 294         * symtab.c (info_variables_command): Likewise.
 295         (info_functions_command): Likewise.
 296
 297 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 298
 299         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 300         to extract string arguments.
 301         * common/common-utils.c (extract_string_maybe_quoted): New function.
 302         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 303
 304 2019-07-11  Tom Tromey  <tromey@adacore.com>
 305
 306         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 307         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 308         * top.h (gdbinit): Don't declare.
 309         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 310         into...
 311         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 312         * top.c (gdb_init): Don't call init_cli_cmds.
 313         (gdbinit): Remove.
 314         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 315
 316 2019-07-11  Tom Tromey  <tromey@adacore.com>
 317
 318         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 319         after it has been moved.
 320
 321 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 322
 323         * valops.c (value_must_coerce_to_target): Change return type to
 324         bool.
 325         * value.h (value_must_coerce_to_target): Likewise.
 326
 327 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 328
 329         * breakpoint.c (is_hardware_watchpoint): Remove
 330         forward-declaration.
 331         (is_masked_watchpoint): Change return type to bool.
 332         (is_tracepoint): Likewise.
 333         (is_breakpoint): Likewise.
 334         (is_hardware_watchpoint): Likewise.
 335         (is_watchpoint): Likewise.
 336         (is_no_memory_software_watchpoint): Likewise.
 337         (is_catchpoint): Likewise.
 338         (breakpoint_1): Make FILTER parameter's return type bool.
 339         is_masked_watchpoint): Change return type to bool.
 340         (save_breakpoints): Make FILTER parameter's return type bool.
 341         * breakpoint.h (is_breakpoint): Change return type to bool.
 342         (is_watchpoint): Likewise.
 343         (is_catchpoint): Likewise.
 344         (is_tracepoint): Likewise.
 345
 346 2019-07-10  Tom Tromey  <tom@tromey.com>
 347
 348         * defs.h: Don't include gdbarch.h.
 349         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 350         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 351         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 352         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 353         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 354         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 355         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 356         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 357         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 358         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 359         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 360         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 361         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 362         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 363         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 364         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 365         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 366         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 367         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 368         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 369         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 370         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 371         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 372         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 373         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 374         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 375         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 376
 377 2019-07-10  Tom Tromey  <tromey@adacore.com>
 378
 379         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 380         * breakpoint.c (init_ada_exception_breakpoint): Register as
 381         bp_catchpoint.
 382         (print_one_breakpoint_location, print_one_breakpoint): Use
 383         is_ada_exception_catchpoint.
 384         * ada-lang.c (class ada_catchpoint_location): Pass
 385         bp_loc_software_breakpoint to bp_location constructor.
 386         (is_ada_exception_catchpoint): New function.
 387
 388 2019-07-10  Tom Tromey  <tromey@adacore.com>
 389
 390         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 391         VEC.
 392         (struct arm_exidx_entry): New method operator<.
 393         (struct arm_exidx_data) <section_maps>: Change type.
 394         (arm_exidx_data_free): Remove.
 395         (arm_exidx_data_key): Change type.  Move lower.
 396         (arm_exidx_new_objfile): Update.
 397         (arm_compare_exidx_entries): Remove.
 398         (arm_find_exidx_entry, _initialize_arm_tdep)
 399
 400 2019-07-10  Tom Tromey  <tromey@adacore.com>
 401
 402         * solib-spu.c (ocl_program_data_key): Change type.
 403         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 404         Update.
 405
 406 2019-07-10  Tom Tromey  <tromey@adacore.com>
 407
 408         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 409         (struct solib_aix_inferior_data) <library_list>: Change type.
 410         (solib_aix_inferior_data_handle): Change type.
 411         (get_solib_aix_inferior_data): Update.
 412         (solib_aix_free_library_list): Remove.
 413         (library_list_start_library): Update.
 414         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 415         return type.
 416         (solib_aix_get_library_list)
 417         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 418         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 419
 420 2019-07-10  Tom Tromey  <tromey@adacore.com>
 421
 422         * solib-dsbt.c (struct dsbt_info): Add initializers.
 423         (solib_dsbt_pspace_data): Change type.
 424         (dsbt_pspace_data_cleanup): Remove.
 425         (get_dsbt_info, _initialize_dsbt_solib): Update.
 426
 427 2019-07-10  Tom Tromey  <tromey@adacore.com>
 428
 429         * spu-tdep.c (spu_overlay_data): Change type.
 430         (spu_get_overlay_table, spu_overlay_new_objfile)
 431         (_initialize_spu_tdep): Update.
 432
 433 2019-07-10  Tom Tromey  <tromey@adacore.com>
 434
 435         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 436         destructor.
 437         (dbx_objfile_data_key): Change type and declare later.
 438         (DBX_SYMFILE_INFO): Rewrite.
 439         * dbxread.c (dbx_objfile_data_key): Change type.
 440         (dbx_symfile_init): Update.
 441         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 442         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 443         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 444
 445 2019-07-10  Tom Tromey  <tromey@adacore.com>
 446
 447         * jit.c (jit_program_space_key): Change type.  Move lower.
 448         (get_jit_program_space_data): Update.
 449         (jit_program_space_data_cleanup): Remove.
 450         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 451         Update.
 452         (struct jit_program_space_data): Add initializers.
 453
 454 2019-07-10  Tom Tromey  <tromey@adacore.com>
 455
 456         * solib-darwin.c (struct darwin_info): Add initializers.
 457         (solib_darwin_pspace_data): Change type.
 458         (darwin_pspace_data_cleanup): Remove.
 459         (get_darwin_info, _initialize_darwin_solib): Update.
 460
 461 2019-07-10  Tom Tromey  <tromey@adacore.com>
 462
 463         * remote-sim.c (struct sim_inferior_data): Add initializers,
 464         constructor, and destructor.
 465         (sim_inferior_data_key): Change type.  Move lower.
 466         (check_for_duplicate_sim_descriptor): Update.
 467         (get_sim_inferior_data): Use new.  Update.
 468         (~sim_inferior_data_cleanup): Rename from
 469         sim_inferior_data_cleanup.  Simplify.
 470         (gdbsim_close_inferior, simulator_command)
 471         (sim_command_completer, _initialize_remote_sim): Update.
 472         (next_pid, INITIAL_PID): Move earlier.
 473
 474 2019-07-10  Tom Tromey  <tromey@adacore.com>
 475
 476         * python/python-internal.h (create_thread_object): Return
 477         gdbpy_ref.
 478         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 479         * python/py-inferior.c (struct threadlist_entry): Add
 480         constructor.
 481         <thread_obj>: Now a gdbpy_ref.
 482         (thread_to_thread_object): Update.
 483         (add_thread_object): Use new.
 484         (delete_thread_object): Use delete.
 485         (infpy_threads): Update.
 486         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 487         GIL.
 488
 489 2019-07-10  Tom Tromey  <tromey@adacore.com>
 490
 491         * valops.c (value_cast): Specialize error message for Ada.
 492
 493 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 494
 495         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 496
 497 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 498
 499         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 500         bpstat_should_step): Return bool, adjust comments.
 501         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 502         bpstat_should_step): Likewise.
 503
 504 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 505
 506         * features/Makefile: Use feature target descriptions for Arm.
 507         * features/arm/arm-core.c: Generate new file.
 508         * features/arm/arm-fpa.c: Likewise.
 509         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 510         * features/arm/arm-m-profile.c: Likewise.
 511         * features/arm/arm-vfpv2.c: Likewise.
 512         * features/arm/arm-vfpv3.c: Likewise.
 513         * features/arm/xscale-iwmmxt.c: Likewise.
 514         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 515
 516 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 517
 518         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 519         ptrace earlier.
 520
 521 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 522
 523         * features/aarch64-pauth.c: Regenerate.
 524
 525 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 526
 527         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 528         bool.
 529         (bpstat_what): Use false instead of 0.
 530
 531 2019-07-09  Pedro Alves  <palves@redhat.com>
 532
 533         * break-catch-throw.c (is_exception_catchpoint): New.
 534         * breakpoint.c (print_one_breakpoint_location): New parameter
 535         'raw_loc'.  Handle it.  Use
 536         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 537         looking at the breakpoint's type.
 538         (print_one_breakpoint): If handling "maint info breakpoints", also
 539         print locations of exception catchpoints.
 540         * breakpoint.h (is_exception_catchpoint): Declare.
 541
 542 2019-07-09  Pedro Alves  <palves@redhat.com>
 543
 544         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 545         "addr" field.
 546         (allocate_location_exception_catchpoint): New.
 547         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 548         (initialize_throw_catchpoint_ops): Install
 549         allocate_location_exception_catchpoint as allocate_location
 550         method.
 551         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 552         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 553         bp_loc_other.
 554         (breakpoint_address_is_meaningful): Delete.
 555         (bl_address_is_meaningful): New.
 556         (breakpoint_locations_match): Adjust comment.
 557         (bp_location_from_bp_type): New, factored out of...
 558         (bp_location::bp_location(breakpoint *)): ... this.
 559         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 560         factored out of...
 561         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 562         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 563         breakpoint_address_is_meaningful.
 564         (bp_locations_compare): Adjust comment.
 565         (update_global_location_list): Use bl_address_is_meaningful
 566         instead of breakpoint_address_is_meaningful.
 567         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 568         explicit.
 569         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 570         * python/py-breakpoint.c (bppy_get_location): No longer check
 571         whether location is null.
 572
 573 2019-07-09  Pedro Alves  <palves@redhat.com>
 574
 575         PR c++/15468
 576         * breakpoint.c (print_one_breakpoint_location): Remove
 577         single-location assert.
 578
 579 2019-07-09  Tom Tromey  <tom@tromey.com>
 580
 581         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 582         * configure: Rebuild.
 583         * configure.ac: Change common to gdbsupport.
 584         * gdbsupport: Rename from common.
 585         * acinclude.m4: Change common to gdbsupport.
 586         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 587         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 588         gdbsupport.
 589         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 590         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 591         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 592         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 593         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 594         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 595         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 596         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 597         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 598         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 599         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 600         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 601         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 602         coff-pe-read.c, command.h, compile/compile-c-support.c,
 603         compile/compile-c.h, compile/compile-cplus-symbols.c,
 604         compile/compile-cplus-types.c, compile/compile-cplus.h,
 605         compile/compile-loc2c.c, compile/compile.c, completer.c,
 606         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 607         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 608         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 609         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 610         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 611         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 612         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 613         features/aarch64-core.c, features/aarch64-fpu.c,
 614         features/aarch64-pauth.c, features/aarch64-sve.c,
 615         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 616         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 617         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 618         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 619         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 620         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 621         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 622         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 623         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 624         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 625         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 626         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 627         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 628         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 629         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 630         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 631         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 632         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 633         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 634         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 635         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 636         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 637         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 638         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 639         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 640         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 641         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 642         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 643         minsyms.c, mips-linux-tdep.c, namespace.h,
 644         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 645         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 646         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 647         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 648         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 649         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 650         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 651         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 652         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 653         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 654         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 655         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 656         procfs.c, producer.c, progspace.h, psymtab.h,
 657         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 658         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 659         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 660         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 661         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 662         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 663         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 664         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 665         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 666         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 667         target-memory.c, target.c, target.h, target/waitstatus.c,
 668         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 669         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 670         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 671         unittests/array-view-selftests.c,
 672         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 673         unittests/common-utils-selftests.c,
 674         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 675         unittests/format_pieces-selftests.c,
 676         unittests/function-view-selftests.c,
 677         unittests/lookup_name_info-selftests.c,
 678         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 679         unittests/mkdir-recursive-selftests.c,
 680         unittests/observable-selftests.c,
 681         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 682         unittests/parse-connection-spec-selftests.c,
 683         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 684         unittests/scoped_fd-selftests.c,
 685         unittests/scoped_mmap-selftests.c,
 686         unittests/scoped_restore-selftests.c,
 687         unittests/string_view-selftests.c, unittests/style-selftests.c,
 688         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 689         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 690         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 691         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 692         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 693         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 694
 695 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 696
 697         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 698         bool value.
 699         (decode_digits_ordinary): Set explicit_line field in sal.
 700         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 701         symtab_and_line that was set on an explicit line number in
 702         assembler code.  Do always update the recorded symtab and line if
 703         we do skip the prologue.
 704
 705 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 706
 707         * breakpoint.c (set_breakpoint_location_function): Remove
 708         explicit_loc parameter.
 709         (momentary_breakpoint_from_master): Update call to
 710         set_breakpoint_location_function.
 711         (add_location_to_breakpoint): Likewise.
 712
 713 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 714
 715         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 716         required features based on default bfd type when no specific bfd
 717         is present.
 718
 719 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 720
 721         * NEWS: Mention that GDB printf and eval commands can now print
 722         C-style and Ada-style convenience var strings without
 723         calling the inferior.
 724         * printcmd.c (printf_c_string): Locally print GDB internal var
 725         instead of transiting via the inferior.
 726         (printf_wide_c_string): Likewise.
 727
 728 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 729
 730         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 731
 732 2019-07-04  Tom Tromey  <tom@tromey.com>
 733
 734         PR tui/24724:
 735         * tui/tui-winsource.c (tui_clear_source_content): Update.
 736         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 737         (tui_update_breakpoint_info): Update.
 738         (tui_set_exec_info_content): Update.
 739         * tui/tui-source.c (tui_set_source_content_nil): Update.
 740         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 741         has_break.
 742         * tui/tui-data.h (enum tui_bp_flag): New.
 743         (tui_bp_flags): New enum flags type.
 744         (struct tui_source_element) <break_mode>: Change type.  Rename
 745         from has_break.
 746         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 747         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 748         constants.
 749         * tui/tui-winsource.h: Fix comment.
 750
 751 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 752
 753         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 754         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 755         (store_fpregs_to_thread)
 756         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 757         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 758         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 759         (IWMMXT_REGS_SIZE): Add define.
 760         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 761         (fetch_vfp_regs, store_vfp_regs)
 762         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 763         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 764
 765 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 766
 767         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 768         defines.
 769         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 770         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 771         (ARM_INT_REGISTER_SIZE): ...to this.
 772         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 773         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 774         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 775         (arm_linux_collect_gregset, supply_nwfpe_register)
 776         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 777         defines.
 778         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 779         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 780         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 781         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 782         (arm_return_in_memory, arm_store_return_value)
 783         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 784         (arm_record_ld_st_multiple): Likewise.
 785         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 786         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 787
 788 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 789
 790         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 791         AARCH64_DISPLACED_MODIFIED_INSNS.
 792         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 793         (aarch64_displaced_step_copy_insn): Likewise.
 794         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 795         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 796         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 797         ARM_DISPLACED_MODIFIED_INSNS.
 798         * arm-tdep.c (arm_gdbarch_init): Likewise.
 799         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 800         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 801         (struct arm_displaced_step_closure): Use
 802         ARM_DISPLACED_MODIFIED_INSNS.
 803
 804 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 805
 806         * features/Makefile: Remove unused xml files.
 807         * features/aarch64.xml: Remove.
 808         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 809         * features/i386/amd64-avx-avx512.xml: Remove.
 810         * features/i386/amd64-avx-linux.xml: Remove.
 811         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 812         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 813         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 814         * features/i386/amd64-avx-mpx.xml: Remove.
 815         * features/i386/amd64-avx.xml: Remove.
 816         * features/i386/amd64-linux.xml: Remove.
 817         * features/i386/amd64-mpx-linux.xml: Remove.
 818         * features/i386/amd64-mpx.xml: Remove.
 819         * features/i386/amd64.xml: Remove.
 820         * features/i386/i386-avx-avx512-linux.xml: Remove.
 821         * features/i386/i386-avx-avx512.xml: Remove.
 822         * features/i386/i386-avx-linux.xml: Remove.
 823         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 824         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 825         * features/i386/i386-avx-mpx-linux.xml: Remove.
 826         * features/i386/i386-avx-mpx.xml: Remove.
 827         * features/i386/i386-avx.xml: Remove.
 828         * features/i386/i386-linux.xml: Remove.
 829         * features/i386/i386-mmx-linux.xml: Remove.
 830         * features/i386/i386-mmx.xml: Remove.
 831         * features/i386/i386-mpx-linux.xml: Remove.
 832         * features/i386/i386-mpx.xml: Remove.
 833         * features/i386/i386.xml: Remove.
 834         * features/i386/x32-avx-avx512-linux.xml: Remove.
 835         * features/i386/x32-avx-linux.xml: Remove.
 836         * features/i386/x32-linux.xml: Remove.
 837
 838 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 839
 840         * regformats/aarch64.dat: Remove.
 841         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 842         * regformats/i386/amd64-avx-linux.dat: Remove.
 843         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 844         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 845         * regformats/i386/amd64-linux.dat: Remove.
 846         * regformats/i386/amd64-mpx-linux.dat: Remove.
 847         * regformats/i386/amd64.dat: Remove.
 848         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 849         * regformats/i386/i386-avx-linux.dat: Remove.
 850         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 851         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 852         * regformats/i386/i386-linux.dat: Remove.
 853         * regformats/i386/i386-mmx-linux.dat: Remove.
 854         * regformats/i386/i386-mpx-linux.dat: Remove.
 855         * regformats/i386/i386.dat: Remove.
 856         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 857         * regformats/i386/x32-avx-linux.dat: Remove.
 858         * regformats/i386/x32-linux.dat: Remove.
 859
 860 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 861
 862         * aarch64-tdep.c: Remove xml self tests.
 863         * amd64-linux-tdep.c: Likewise.
 864         * amd64-tdep.c: Likewise.
 865         * i386-linux-tdep.c: Likewise.
 866         * i386-tdep.c: Likewise.
 867
 868 2019-07-03  Pedro Alves  <palves@redhat.com>
 869
 870         PR cli/24732
 871         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 872         (pipe_cmd_option_defs): New.
 873         (make_pipe_cmd_options_def_group): New.
 874         (pipe_command): Use gdb::option::process_options.
 875         (pipe_command_completer): New function.
 876         (_initialize_cli_cmds): Install completer for "pipe" command.
 877
 878 2019-07-03  Pedro Alves  <palves@redhat.com>
 879
 880         * cli/cli-option.c (union option_value) <string>: New field.
 881         (struct option_def_and_value): Add ctor, move ctor, dtor and
 882         use DISABLE_COPY_AND_ASSIGN.
 883         (option_def_and_value::clear_value): New.
 884         (parse_option, save_option_value_in_ctx, get_val_type_str)
 885         (add_setshow_cmds_for_options): Handle var_string.
 886         * cli-option.h (union option_def::var_address) <string>: New
 887         field.
 888         (struct string_option_def): New.
 889         * maint-test-options.c (struct test_options_opts): Add default
 890         ctor and use DISABLE_COPY_AND_ASSIGN.
 891         <string_opt>: New field.
 892         (test_options_opts::~test_options_opts): New.
 893         (test_options_opts::dump): Also dump "-string".
 894         (test_options_option_defs): Install "string.
 895
 896 2019-07-03  Pedro Alves  <palves@redhat.com>
 897
 898         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 899         option_value with a null enumeration.
 900         (complete_options): Save the option values in the context.
 901         (save_option_value_in_ctx): New, factored out from ...
 902         (process_options): ... here.
 903         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 904         of the function.
 905         * maint-test-options.c (test_options_opts::dump): New, factored
 906         out from ...
 907         (maintenance_test_options_command_mode): ... here.
 908         (maintenance_test_options_command_completion_result): Delete.
 909         (maintenance_test_options_command_completion_text): Update
 910         comment.
 911         (maintenance_show_test_options_completion_result): Change
 912         prototype.  Just print
 913         maintenance_test_options_command_completion_text.
 914         (save_completion_result): New.
 915         (maintenance_test_options_completer_mode): Pass options context to
 916         complete_options, and then save a dump.
 917         (_initialize_maint_test_options): Use add_cmd to install "maint
 918         show test-options-completion-result".
 919
 920 2019-07-03  Pedro Alves  <palves@redhat.com>
 921
 922         * NEWS (New commands): Mention "with" and "maint with".
 923         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 924         (with_command, with_command_completer): New.
 925         (pipe_command): Adjust to new repeat_previous
 926         interface.
 927         (_initialize_cli_cmds): Install the "with" command and its "w"
 928         alias.
 929         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 930         declarations.
 931         * cli/cli-setshow.c (parse_cli_var_uinteger)
 932         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 933         argument strings for all var_types.
 934         (get_setshow_command_value_string): New, factored out from ...
 935         (do_show_command): ... this.
 936         * cli/cli-setshow.h: Include <string>.
 937         (get_setshow_command_value_string): Declare.
 938         * command.h (repeat_previous): Now returns const char *.  Adjust
 939         comment.
 940         * maint.c: Include "cli/cli-cmds.h".
 941         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 942         (_initialize_maint_cmds): Register the "maintenance with" command.
 943         * top.c (repeat_previous): Move bits from pipe_command here:
 944         Return the saved command line, if any; error out if there's no
 945         command to relaunch.
 946
 947 2019-07-03  Pedro Alves  <palves@redhat.com>
 948
 949         * NEWS (New commands): Mention "maint set/show test-settings"
 950         instead of "maint test-settings".
 951         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 952         (maintenance_test_settings_set_list): Rename to ...
 953         (maintenance_set_test_settings_list): ... this.
 954         (maintenance_test_settings_show_list): Rename to  ...
 955         (maintenance_show_test_settings_list): ... this.
 956         (maintenance_test_settings_cmd): Delete.
 957         (maintenance_test_settings_set_cmd): ...
 958         (maintenance_set_test_settings_cmd): ... this.
 959         (maintenance_test_settings_show_cmd): ...
 960         (maintenance_show_test_settings_cmd): ... this.
 961         (maintenance_test_settings_show_value_cmd):
 962         (maintenance_show_test_settings_value_cmd): ... this.
 963         (_initialize_maint_test_settings): No longer install the "maint
 964         test-settings" prefix command.  Rename "maint test-settings set"
 965         to "maint set test-settings", and "maint test-settings show" to
 966         "maint show test-settings".  Adjust all subcommands.
 967
 968 2019-07-03  Pedro Alves  <palves@redhat.com>
 969
 970         * maint-test-settings.c: Fix file's intro comment.  Replace all
 971         references to "test-options" with references to "test-settings",
 972         in comments.
 973
 974 2019-07-03  Pedro Alves  <palves@redhat.com>
 975
 976         * maint-test-settings.c (maintenance_test_settings_xxx)
 977         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 978         New.
 979         (maintenance_test_settings_enums): Use them.
 980         (maintenance_test_settings_enum): Default to
 981         maintenance_test_settings_xxx.
 982         (_initialize_maint_test_settings): Initialize
 983         MAINTENANCE_TEST_SETTINGS_FILENAME.
 984
 985 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 986
 987         * breakpoint.h (remove_breakpoints_inf): Change return type to
 988         void, move function documentation here.
 989         * breakpoint.c (remove_breakpoints_inf): Change return type to
 990         void, move function documentation to header.
 991
 992 2019-07-02  Pedro Alves  <palves@redhat.com>
 993
 994         * NEWS (Completion improvements): Mention "info threads".
 995         * thread.c (struct info_threads_opts, info_threads_option_defs)
 996         (make_info_threads_options_def_group): New.
 997         (info_threads_command): Use gdb::option::process_options.
 998         (info_threads_command_completer): New.
 999         (_initialize_thread): Use gdb::option::build_help to build the
1000         help text for "info threads".
1001
1002 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1003
1004         * defs.h (generic_load): Move from here...
1005         * symfile.h (generic_load): ... to here.  Rename name parameter
1006         to args.
1007         * symfile.c (generic_load): Add comment.
1008
1009 2019-07-01  Tom Tromey  <tromey@adacore.com>
1010
1011         * dwarf2read.c
1012         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1013         declaration of without_params.  Fix formatting.
1014
1015 2019-07-01  Tom Tromey  <tromey@adacore.com>
1016
1017         * ada-exp.y (find_primitive_type): Update.
1018         * ada-lang.h (ada_lookup_symbol): Update.
1019         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1020         parameter.
1021         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1022
1023 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1024
1025         PR breakpoints/24541
1026         * gdbarch.c: Regenerate.
1027         * gdbarch.h: Regenerate.
1028         * gdbarch.sh: Add 'stap_adjust_register'.
1029         * i386-tdep.c: Include '<unordered_set>'.
1030         (i386_stap_adjust_register): New function.
1031         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1032         * stap-probe.c (stap_parse_register_operand): Call
1033         'gdbarch_stap_adjust_register'.
1034
1035 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1036
1037         PR python/24742
1038         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1039         * python/python.c (do_start_initialization): Use 'xmalloc'
1040         instead of 'PyMem_Malloc'.
1041
1042 2019-06-28  Tom Tromey  <tromey@adacore.com>
1043
1044         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1045         for Ada.
1046
1047 2019-06-27  Tom Tromey  <tromey@adacore.com>
1048
1049         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1050         objfile_key.
1051         (arm_find_mapping_symbol, arm_record_special_symbol)
1052         (_initialize_arm_tdep): Update.
1053         (arm_objfile_data_free): Remove.
1054
1055 2019-06-27  Tom Tromey  <tromey@adacore.com>
1056
1057         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1058         to cp_print_static_field.
1059
1060 2019-06-26  Tom Tromey  <tromey@adacore.com>
1061
1062         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1063         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1064         declare.
1065
1066 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1067
1068         * features/aarch64-core.c (create_feature_aarch64_core):
1069         Regenerate.
1070         * features/aarch64-core.xml: Add cpsr flags.
1071
1072 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1073
1074         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1075         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1076
1077 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1078
1079         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1080         field.
1081         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1082         use.
1083         (arm_record_special_symbol): Don't insert new symbol in sorted
1084         position, push it at the end.
1085
1086 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1087
1088         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1089         (arm_mapping_symbol_s): Remove.
1090         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1091         (arm_mapping_symbol_vec): New typedef.
1092         (struct arm_per_objfile): Add constructor.
1093         <section_maps>: Change type to
1094         std::unique_ptr<arm_mapping_symbol_vec[]>.
1095         (arm_compare_mapping_symbols): Remove.
1096         (arm_find_mapping_symbol): Adjust to section_maps type change.
1097         (arm_objfile_data_free): Call delete on arm_per_objfile.
1098         (arm_record_special_symbol): Adjust to section_maps type change.
1099         Allocate arm_per_objfile with new.
1100
1101 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1102
1103         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1104         with the command prefix.
1105
1106 2019-06-25  Tom Tromey  <tom@tromey.com>
1107
1108         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1109         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1110
1111 2019-06-25  Tom Tromey  <tom@tromey.com>
1112
1113         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1114         type.
1115         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1116         protected.
1117
1118 2019-06-25  Tom Tromey  <tom@tromey.com>
1119
1120         * tui/tui-winsource.c
1121         (tui_source_window_base::set_is_exec_point_at): Add check against
1122         LOA_ADDRESS.
1123
1124 2019-06-25  Tom Tromey  <tom@tromey.com>
1125
1126         * tui/tui-source.c (tui_set_source_content): Don't check before
1127         xfree.
1128         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1129
1130 2019-06-25  Tom Tromey  <tom@tromey.com>
1131
1132         * tui/tui-winsource.h (tui_update_source_window_as_is)
1133         (tui_alloc_source_buffer, tui_line_is_displayed)
1134         (tui_addr_is_displayed): Change type of win_info.
1135         * tui/tui-winsource.c (tui_update_source_window_as_is)
1136         (tui_clear_source_content, tui_show_source_line)
1137         (tui_show_source_content, tui_source_window_base::refill)
1138         (tui_source_window_base::set_is_exec_point_at)
1139         (tui_source_window_base::set_is_exec_point_at)
1140         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1141         (tui_alloc_source_buffer, tui_line_is_displayed)
1142         (tui_addr_is_displayed): Change type of win_info.  Update.
1143         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1144         (tui_source_window_base::do_make_visible_with_new_height):
1145         Update.
1146         * tui/tui-source.c (tui_set_source_content)
1147         (tui_set_source_content_nil)
1148         (tui_source_window::do_scroll_vertical): Update.
1149         * tui/tui-layout.c (show_layout): Update.
1150         * tui/tui-disasm.c (tui_set_disassem_content)
1151         (tui_disasm_window::do_scroll_vertical): Update.
1152         * tui/tui-data.h (tui_win_content): Remove.
1153         (struct tui_gen_win_info) <content, content_size>: Remove.
1154         (struct tui_source_element): Add initializers and destructor.
1155         (union tui_which_element, struct tui_win_element): Remove.
1156         (struct tui_source_window_base) <content>: New field.
1157         (struct tui_data_window): Remove destructor.
1158         (tui_alloc_content, tui_free_win_content)
1159         (tui_free_all_source_wins_content): Don't declare.
1160         * tui/tui-data.c (tui_initialize_static_data): Update.
1161         (init_content_element, tui_alloc_content): Remove.
1162         (~tui_gen_win_info): Update.
1163         (~tui_data_window, tui_free_all_source_wins_content)
1164         (tui_free_win_content, free_content, free_content_elements):
1165         Remove.
1166
1167 2019-06-25  Tom Tromey  <tom@tromey.com>
1168
1169         * tui/tui-winsource.h (tui_clear_source_content)
1170         (tui_erase_source_content, tui_show_source_content): Change type
1171         of win_info.
1172         * tui/tui-winsource.c (tui_clear_source_content)
1173         (tui_erase_source_content, tui_show_source_content): Change type
1174         of win_info.
1175         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1176         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1177         win_info.
1178         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1179         win_info.
1180         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1181
1182 2019-06-25  Tom Tromey  <tom@tromey.com>
1183
1184         * tui/tui-winsource.c (tui_clear_source_content)
1185         (tui_source_window_base::set_is_exec_point_at): Update.
1186         * tui/tui-source.c (tui_set_source_content_nil): Update.
1187         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1188         a bool.
1189         * tui/tui-data.c (init_content_element): Update.
1190
1191 2019-06-25  Tom Tromey  <tom@tromey.com>
1192
1193         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1194         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1195         * tui/tui-layout.c (init_and_make_win): Update.
1196         * tui/tui.h (enum tui_win_type): Update.
1197         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1198         tui_win_is_auxillary.
1199         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1200         tui_win_is_auxillary.
1201
1202 2019-06-25  Tom Tromey  <tom@tromey.com>
1203
1204         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1205         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1206         (tui_delete_data_content_windows, tui_display_all_data)
1207         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1208         Update.
1209         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1210         * tui/tui-regs.c (tui_last_regs_line_no)
1211         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1212         (tui_show_registers): Update.
1213         (tui_show_register_group): Return void.  Update.
1214         (tui_display_registers_from, tui_display_reg_element_at_line)
1215         (tui_display_registers_from_line, tui_check_register_values):
1216         Update.
1217         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1218         member.
1219         (struct tui_data_window) <regs_content>: Now a std::vector.
1220         <regs_content_count>: Remove.
1221         (tui_add_content_elements, tui_free_data_content): Don't declare.
1222         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1223         (init_content_element): Remove DATA_WIN case.  Add assert.
1224         (tui_add_content_elements): Remove.
1225         (tui_data_window): Update.
1226         (tui_free_data_content): Remove.
1227         (free_content_elements): Remove DATA_WIN case.
1228
1229 2019-06-25  Tom Tromey  <tom@tromey.com>
1230
1231         * tui/tui-data.c (tui_data_item_window): Update.
1232         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1233         * tui/tui-windata.c (tui_display_all_data)
1234         (tui_display_data_from_line): Update.
1235         (tui_check_data_values): Remove.
1236         * tui/tui-regs.c (tui_show_register_group)
1237         (tui_display_reg_element_at_line): Update.
1238         * tui/tui-hooks.c (tui_register_changed)
1239         (tui_refresh_frame_and_register_information): Call
1240         tui_check_register_values.
1241         * tui/tui-data.h (struct tui_data_window) <data_content,
1242         data_content_count, data_type>: Remove.
1243         (enum tui_data_type): Remove.
1244
1245         * tui/tui-data.c (tui_data_window::clear_detail)
1246         (~tui_data_window): Update.
1247
1248 2019-06-25  Tom Tromey  <tom@tromey.com>
1249
1250         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1251         declare.
1252         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1253         Rename from tui_first_data_item_displayed.  Update.
1254         (tui_data_window::refresh_all)
1255         (tui_data_window::do_scroll_vertical): Update.
1256         * tui/tui-data.h (struct tui_data_window)
1257         <first_data_item_displayed>: Declare new method.
1258
1259 2019-06-25  Tom Tromey  <tom@tromey.com>
1260
1261         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1262         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1263         contents...
1264         (tui_initialize_static_data): ...here.
1265
1266 2019-06-25  Tom Tromey  <tom@tromey.com>
1267
1268         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1269         (tui_display_registers_from, tui_check_register_values): Update.
1270         (tui_display_register): Remove win_info parameter; update.
1271         (tui_get_register): Change type of parameters.
1272         * tui/tui-data.h (struct tui_data_element): Remove.
1273         (union tui_which_element) <data>: Remove.
1274         <data_window>: Change type.
1275         (struct tui_data_item_window): New.
1276         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1277         case.  Add assert.
1278         (~tui_data_item_window): New destructor.
1279         (free_content_elements): Remove DATA_ITEM_WIN case.
1280
1281 2019-06-25  Tom Tromey  <tom@tromey.com>
1282
1283         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1284         Remove.
1285
1286 2019-06-25  Tom Tromey  <tom@tromey.com>
1287
1288         * tui/tui-data.h (struct tui_command_element): Remove.
1289         (union tui_which_element) <command>: Remove.
1290         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1291         assert.
1292         (free_content_elements): Remove CMD_WIN case.
1293
1294 2019-06-25  Tom Tromey  <tom@tromey.com>
1295
1296         * tui/tui-layout.c (tui_set_layout): Update.
1297         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1298         * tui/tui-data.c (layout_def): Update.
1299
1300 2019-06-25  Tom Tromey  <tom@tromey.com>
1301
1302         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1303         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1304         (tui_source_window_base::set_new_height): Update.
1305         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1306         Update.
1307         (tui_set_locator_fullname, tui_set_locator_info)
1308         (tui_show_frame_info): Update.
1309         * tui/tui-source.c (tui_set_source_content)
1310         (tui_source_is_displayed): Update.
1311         * tui/tui-layout.c (show_source_disasm_command, show_data)
1312         (show_source_or_disasm_and_command): Update.
1313         * tui/tui-disasm.c (tui_set_disassem_content)
1314         (tui_get_begin_asm_address): Update.
1315         * tui/tui-data.h (struct tui_locator_element): Remove.
1316         (union tui_which_element) <locator>: Remove.
1317         (struct tui_locator_window): New.
1318         (tui_locator_win_info_ptr): Change return type.
1319         * tui/tui-data.c (_locator): Change type.
1320         (tui_locator_win_info_ptr): Change return type.
1321         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1322         (tui_alloc_content): Add assert.
1323
1324 2019-06-25  Tom Tromey  <tom@tromey.com>
1325
1326         * tui/tui-winsource.c
1327         (tui_exec_info_window::maybe_allocate_content): New method.
1328         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1329         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1330         (make_source_or_disasm_window): Add cast.
1331         * tui/tui-data.h (union tui_which_element) <simple_string>:
1332         Remove.
1333         (struct tui_source_info): New.
1334         (struct tui_source_window_base) <execution_info>: Change type.
1335         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1336         case, and add assert.
1337         (tui_alloc_content): Add assert.
1338
1339 2019-06-25  Tom Tromey  <tom@tromey.com>
1340
1341         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1342         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1343         * tui/tui-data.c (tui_alloc_win_info): Remove.
1344
1345 2019-06-25  Tom Tromey  <tom@tromey.com>
1346
1347         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1348         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1349         can_highlight.
1350
1351 2019-06-25  Tom Tromey  <tom@tromey.com>
1352
1353         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1354         make_visible_with_new_height method.
1355         (tui_win_info::make_visible_with_new_height): New method.
1356         (tui_source_window_base::do_make_visible_with_new_height)
1357         (tui_data_window::do_make_visible_with_new_height)
1358         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1359         (make_visible_with_new_height): Remove.
1360         (tui_resize_all, tui_adjust_win_heights): Use
1361         make_visible_with_new_height method.
1362         * tui/tui-data.h (struct tui_win_info)
1363         <do_make_visible_with_new_height, make_visible_with_new_height>:
1364         New methods.
1365         (struct tui_source_window_base, struct tui_data_window)
1366         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1367         methods.
1368
1369 2019-06-25  Tom Tromey  <tom@tromey.com>
1370
1371         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1372         method.
1373         (update_tab_width): Call update_tab_width method.
1374         * tui/tui-data.h (struct tui_win_info)
1375         (struct tui_source_window_base) <update_tab_width>: New methods.
1376
1377 2019-06-25  Tom Tromey  <tom@tromey.com>
1378
1379         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1380         parameter.
1381         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1382         parameter.
1383         (tui_gen_win_info::make_visible): Update.
1384         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1385         parameter.
1386         * tui/tui-data.h (enum tui_box): New enum.
1387         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1388
1389 2019-06-25  Tom Tromey  <tom@tromey.com>
1390
1391         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1392         init_and_make_win for EXEC_INFO_WIN.
1393         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1394         longer inline.
1395         (struct tui_win_info) <~tui_win_info>: Inline.
1396         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1397         Don't declare.
1398         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1399         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1400         Remove.
1401         (tui_initialize_static_data): Update.
1402         (~tui_gen_win_info): Handle more cleanup here.
1403         (~tui_source_window_base): Delete "execution_info".
1404         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1405
1406 2019-06-25  Tom Tromey  <tom@tromey.com>
1407
1408         * tui/tui-layout.c (make_command_window): Don't set
1409         can_highlight.
1410         (show_source_disasm_command): Call the reset method.
1411         (show_data): Don't set can_highlight.  Call the reset method.
1412         (tui_gen_win_info::reset): Rename from init_gen_win_info
1413         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1414         (show_source_or_disasm_and_command): Call the reset method.
1415         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1416         (struct tui_cmd_window): Set can_highlight.
1417
1418 2019-06-25  Tom Tromey  <tom@tromey.com>
1419
1420         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1421         from make_visible.
1422         (tui_make_visible, tui_make_invisible): Rewrite.
1423         (tui_win_info::make_visible): Remove.
1424         (tui_source_window_base::make_visible): Update.
1425         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1426         method.  Moved from...
1427         (struct tui_win_info) <make_visible>: ...here.
1428
1429 2019-06-25  Tom Tromey  <tom@tromey.com>
1430
1431         * tui/tui-winsource.c
1432         (tui_source_window_base::do_scroll_horizontal): Remove direction
1433         parameter.
1434         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1435         direction parameter.
1436         * tui/tui-win.c (tui_win_info::forward_scroll)
1437         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1438         (tui_win_info::right_scroll): Update.
1439         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1440         direction parameter.
1441         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1442         direction parameter.
1443         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1444         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1445         Remove direction parameter.
1446         (struct tui_source_window_base, struct tui_source_window)
1447         (struct tui_disasm_window, struct tui_data_window)
1448         (struct tui_cmd_window): Update.
1449
1450 2019-06-25  Tom Tromey  <tom@tromey.com>
1451
1452         * tui/tui-winsource.h (tui_set_exec_info_content)
1453         (tui_show_exec_info_content, tui_erase_exec_info_content)
1454         (tui_clear_exec_info_content, tui_update_exec_info): Change
1455         argument to tui_source_window_base.
1456         * tui/tui-winsource.c (tui_set_exec_info_content)
1457         (tui_show_exec_info_content, tui_erase_exec_info_content)
1458         (tui_clear_exec_info_content, tui_update_exec_info): Change
1459         argument to tui_source_window_base.
1460
1461 2019-06-25  Tom Tromey  <tom@tromey.com>
1462
1463         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1464         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1465
1466 2019-06-25  Tom Tromey  <tom@tromey.com>
1467
1468         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1469         check.
1470
1471 2019-06-25  Tom Tromey  <tom@tromey.com>
1472
1473         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1474         type to void.
1475         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1476         type to void.
1477         * tui/tui-source.c (tui_set_source_content): Update.
1478         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1479
1480 2019-06-25  Tom Tromey  <tom@tromey.com>
1481
1482         * tui/tui-win.c (window_name_completer, tui_set_focus)
1483         (tui_all_windows_info): Use name method.
1484         * tui/tui-data.h (struct tui_gen_win_info)
1485         (struct tui_source_window, struct tui_disasm_window)
1486         (struct tui_data_window, struct tui_cmd_window) <name>: New
1487         method.
1488         (tui_win_name): Don't declare.
1489         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1490         (tui_win_name): Remove.
1491
1492 2019-06-25  Tom Tromey  <tom@tromey.com>
1493
1494         * tui/tui-winsource.h (tui_update_source_window)
1495         (tui_update_source_window_as_is): Change parameter type.
1496         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1497         to be a tui_source_window_base.
1498         (tui_update_source_window_as_is): Likewise.
1499         * tui/tui-win.c (make_visible_with_new_height): Update.
1500
1501 2019-06-25  Tom Tromey  <tom@tromey.com>
1502
1503         * tui/tui-winsource.c (tui_erase_source_content)
1504         (tui_show_source_content, tui_show_exec_info_content)
1505         (tui_erase_exec_info_content): Use refresh_window method.
1506         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1507         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1508         from tui_refresh_win.
1509         (tui_data_window::refresh_window): New method.
1510         (tui_win_info::refresh, tui_source_window_base::refresh)
1511         (tui_refresh_all): Use refresh_window method.
1512         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1513         method.
1514         * tui/tui-regs.c (tui_display_register): Call refresh_window
1515         method.
1516         * tui/tui-layout.c (show_source_disasm_command)
1517         (show_source_or_disasm_and_command): Call refresh_window method.
1518         * tui/tui-data.h (struct tui_gen_win_info)
1519         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1520         New method.
1521
1522 2019-06-25  Tom Tromey  <tom@tromey.com>
1523
1524         * tui/tui.c (tui_rl_other_window, tui_enable)
1525         (tui_is_window_visible, tui_get_command_dimension): Update.
1526         * tui/tui-winsource.c (tui_update_source_window_as_is)
1527         (tui_clear_source_content, tui_erase_source_content)
1528         (tui_show_source_line, tui_source_window_base::refill)
1529         (tui_source_window_base::do_scroll_horizontal)
1530         (tui_source_window_base::set_is_exec_point_at)
1531         (tui_update_breakpoint_info, tui_set_exec_info_content)
1532         (tui_alloc_source_buffer, tui_line_is_displayed)
1533         (tui_addr_is_displayed): Update.
1534         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1535         (tui_check_and_display_highlight_if_needed)
1536         (tui_win_info::make_visible, tui_win_info::refresh)
1537         (tui_refresh_all): Update.
1538         * tui/tui-windata.c (tui_first_data_item_displayed)
1539         (tui_delete_data_content_windows, tui_erase_data_content)
1540         (tui_display_all_data, tui_data_window::refresh_all)
1541         (tui_check_data_values): Update.
1542         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1543         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1544         (tui_win_info::backward_scroll, tui_refresh_all_win)
1545         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1546         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1547         (tui_source_window_base::set_new_height)
1548         (tui_data_window::set_new_height)
1549         (make_invisible_and_set_new_height)
1550         (make_visible_with_new_height, new_height_ok)
1551         (parse_scrolling_args): Update.
1552         * tui/tui-stack.c (tui_show_frame_info): Update.
1553         * tui/tui-source.c (tui_set_source_content)
1554         (tui_set_source_content_nil, tui_source_is_displayed)
1555         (tui_source_window::do_scroll_vertical): Update.
1556         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1557         (tui_display_registers_from, tui_display_reg_element_at_line)
1558         (tui_check_register_values, tui_reg_command): Update.
1559         * tui/tui-layout.c (tui_default_win_height)
1560         (show_source_disasm_command, show_data, init_and_make_win)
1561         (show_source_or_disasm_and_command): Update.
1562         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1563         (tui_redisplay_readline, tui_mld_flush)
1564         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1565         (tui_getc): Update.
1566         * tui/tui-disasm.c (tui_set_disassem_content)
1567         (tui_disasm_window::do_scroll_vertical): Update.
1568         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1569         Now virtual.
1570         (struct tui_win_info): Derive from tui_gen_win_info.
1571         <~tui_win_info>: Mark as override.
1572         <generic>: Remove member.
1573         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1574         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1575         (~tui_data_window, ~tui_win_info)
1576         (tui_free_all_source_wins_content): Update.
1577         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1578
1579 2019-06-25  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui-layout.c (init_and_make_win): Use new.
1582         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1583         destructor, initializers.
1584         (tui_alloc_generic_win_info): Don't declare.
1585         * tui/tui-data.c (_locator): Add argument to constructor.
1586         (source_win, disasm_win): New globals.
1587         (exec_info): Remove.
1588         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1589         Update.
1590         (tui_alloc_generic_win_info): Remove.
1591         (init_content_element): Use new.
1592         (tui_win_info::tui_win_info): Update.
1593         (free_content_elements) <case DATA_WIN>: Use delete.
1594
1595 2019-06-25  Tom Tromey  <tom@tromey.com>
1596
1597         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1598         * tui/tui-windata.c (tui_first_data_item_displayed)
1599         (tui_delete_data_content_windows): Update.
1600         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1601         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1602         (tui_display_registers_from, tui_check_register_values): Update.
1603         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1604         pointer.
1605         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1606         window.
1607         (tui_free_data_content): Update.
1608         (free_content_elements) <case DATA_WIN>: Free the window.
1609
1610 2019-06-25  Tom Tromey  <tom@tromey.com>
1611
1612         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1613         Update.
1614         * tui/tui-layout.c (make_command_window)
1615         (show_source_disasm_command, show_data, init_and_make_win)
1616         (show_source_or_disasm_and_command): Update.
1617         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1618         method.
1619         <can_highight, is_highlighted>: Now bool.
1620         (tui_set_win_highlight): Don't declare.
1621         * tui/tui-data.c (tui_set_win_highlight): Remove.
1622
1623 2019-06-25  Tom Tromey  <tom@tromey.com>
1624
1625         * tui/tui-wingeneral.c (make_visible): Remove check of window
1626         type.
1627
1628 2019-06-25  Tom Tromey  <tom@tromey.com>
1629
1630         * tui/tui-win.c (tui_win_info::max_height)
1631         (tui_cmd_window::max_height): New methods.
1632         (new_height_ok): Call max_height.
1633         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1634         <max_height>: New method.
1635
1636 2019-06-25  Tom Tromey  <tom@tromey.com>
1637
1638         * tui/tui-win.c (tui_source_window_base::set_new_height)
1639         (tui_data_window::set_new_height): New methods.
1640         (make_invisible_and_set_new_height): Call set_new_height method.
1641         * tui/tui-data.h (struct tui_win_info)
1642         (struct tui_source_window_base, struct tui_data_window)
1643         <set_new_height>: New method.
1644
1645 2019-06-25  Tom Tromey  <tom@tromey.com>
1646
1647         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1648         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1649         tui_refresh_data_win.
1650         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1651         method.
1652         (tui_refresh_all_win): Call the refresh_all method.
1653         (tui_set_focus): Likewise.
1654         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1655         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1656         Likewise.
1657
1658 2019-06-25  Tom Tromey  <tom@tromey.com>
1659
1660         * tui/tui-winsource.h (tui_refill_source_window)
1661         (tui_set_is_exec_point_at): Don't declare.
1662         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1663         (tui_source_window_base::refill): Rename from
1664         tui_refill_source_window.
1665         (tui_source_window_base::do_scroll_horizontal): Update.
1666         (tui_source_window_base::set_is_exec_point_at): Rename from
1667         tui_set_is_exec_point_at.
1668         (tui_update_all_breakpoint_info): Update.
1669         * tui/tui-stack.c (tui_show_frame_info): Update.
1670         * tui/tui-layout.c (show_data): Add cast.
1671         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1672         * tui/tui-data.h (struct tui_source_window_base) <refill,
1673         set_is_exec_point_at>: New methods.
1674         (tui_source_windows, tui_add_to_source_windows): Update types.
1675         (tui_add_to_source_windows): Remove redundant declaration.
1676         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1677         (tui_source_windows): Change return type.
1678         (tui_clear_source_windows_detail): Update.
1679         (tui_add_to_source_windows): Change type of parameter.
1680         (tui_free_all_source_wins_content): Update.
1681
1682 2019-06-25  Tom Tromey  <tom@tromey.com>
1683
1684         * tui/tui-wingeneral.c (tui_win_info::refresh)
1685         (tui_source_window_base::refresh): New methods.
1686         (tui_refresh_all): Call the refresh method.
1687         * tui/tui-data.h (struct tui_win_info)
1688         (struct tui_source_window_base) <refresh>: New method.
1689
1690 2019-06-25  Tom Tromey  <tom@tromey.com>
1691
1692         * tui/tui.h (tui_is_window_visible): Return bool.
1693         * tui/tui.c (tui_is_window_visible): Return bool.
1694         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1695         (tui_make_visible, tui_make_invisible)
1696         (tui_win_info::make_visible)
1697         (tui_source_window_base::make_visible, make_all_visible)
1698         (tui_make_all_visible, tui_make_all_invisible): Update.
1699         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1700         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1701         bool.
1702         (struct tui_win_info, struct tui_source_window_base)
1703         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1704         * tui/tui-data.c (tui_init_generic_part): Update.
1705
1706 2019-06-25  Tom Tromey  <tom@tromey.com>
1707
1708         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1709         (tui_source_window_base::make_visible): New methods.
1710         (make_all_visible): Make method call.
1711         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1712         (struct tui_source_window_base, struct tui_cmd_window): Override
1713         make_visible.
1714         (tui_win_is_source_type): Don't declare.
1715         * tui/tui-data.c (tui_win_is_source_type): Remove.
1716
1717 2019-06-25  Tom Tromey  <tom@tromey.com>
1718
1719         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1720         NULL check.
1721
1722 2019-06-25  Tom Tromey  <tom@tromey.com>
1723
1724         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1725         Inline constructor.  Add initializers for members.
1726         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1727         constructors; now inline in class.
1728
1729 2019-06-25  Tom Tromey  <tom@tromey.com>
1730
1731         * tui/tui-regs.c (tui_show_registers): Update.
1732         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1733         bool.
1734         * tui/tui-data.c (tui_data_window::clear_detail)
1735         (tui_data_window): Update.
1736
1737 2019-06-25  Tom Tromey  <tom@tromey.com>
1738
1739         * tui/tui-windata.c (tui_display_all_data)
1740         (tui_display_data_from_line, tui_display_data_from)
1741         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1742         Update.
1743         * tui/tui-regs.c (tui_last_regs_line_no)
1744         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1745         (tui_show_registers, tui_show_register_group)
1746         (tui_display_registers_from, tui_display_reg_element_at_line)
1747         (tui_display_registers_from_line, tui_check_register_values)
1748         (tui_reg_next, tui_reg_prev): Update.
1749         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1750         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1751         tui_data_window.
1752         (struct tui_win_info) <detail>: Remove.  Add new fields from
1753         tui_data_info.
1754         (TUI_DATA_WIN): Add cast.
1755         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1756         (~tui_data_window): Simplify.
1757
1758 2019-06-25  Tom Tromey  <tom@tromey.com>
1759
1760         * tui/tui-layout.c (show_source_disasm_command)
1761         (show_source_or_disasm_and_command): Update.
1762         * tui/tui-io.c (update_cmdwin_start_line)
1763         (tui_redisplay_readline): Update.
1764         * tui/tui-data.h (struct tui_command_info): Remove.
1765         (struct tui_win_info) <detail>: Remove command_info member.
1766         (struct tui_data_window) <start_line>: New member, from
1767         tui_command_info.
1768         (TUI_CMD_WIN): Add casts.
1769
1770 2019-06-25  Tom Tromey  <tom@tromey.com>
1771
1772         * tui/tui-winsource.c (tui_update_source_window)
1773         (tui_refill_source_window)
1774         (tui_source_window_base::do_scroll_horizontal)
1775         (tui_update_breakpoint_info, tui_set_exec_info_content)
1776         (tui_show_exec_info_content, tui_erase_exec_info_content)
1777         (tui_clear_exec_info_content): Update.
1778         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1779         Update.
1780         * tui/tui-win.c (make_invisible_and_set_new_height)
1781         (make_visible_with_new_height): Update.
1782         * tui/tui-source.c (tui_set_source_content)
1783         (tui_show_symtab_source): Update.
1784         * tui/tui-layout.c (extract_display_start_addr)
1785         (show_source_disasm_command, show_data)
1786         (make_source_or_disasm_window)
1787         (show_source_or_disasm_and_command): Update.
1788         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1789         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1790         "gdbarch".
1791         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1792         to tui_source_window_base.
1793         (struct tui_win_info) <detail>: Remove source_info member.
1794         (struct tui_source_window_base) <has_locator>: Inline.
1795         Move contents from tui_source_info; rename has_locator member to
1796         m_has_locator.
1797         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1798         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1799         header file.
1800         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1801         Simplify.
1802         (tui_free_all_source_wins_content): Cast to
1803         tui_source_window_base.
1804
1805 2019-06-25  Tom Tromey  <tom@tromey.com>
1806
1807         * tui/tui-win.c (make_invisible_and_set_new_height)
1808         (make_visible_with_new_height): Call has_locator method.
1809         * tui/tui-layout.c (show_source_disasm_command, show_data)
1810         (show_source_or_disasm_and_command): Update for bool change.
1811         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1812         (tui_win_info) <has_locator>: New method.
1813         (struct tui_source_window_base) <has_locator>: New method.
1814         (tui_win_has_locator): Don't declare.
1815         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1816         from tui_win_has_locator.
1817         (tui_source_window_base): Use false, not FALSE.
1818
1819 2019-06-25  Tom Tromey  <tom@tromey.com>
1820
1821         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1822         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1823         clear_detail method directly.
1824         (tui_clear_win_detail): Remove.
1825
1826 2019-06-25  Tom Tromey  <tom@tromey.com>
1827
1828         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1829         "this", not TUI_DISASM_WIN.
1830
1831 2019-06-25  Tom Tromey  <tom@tromey.com>
1832
1833         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1834         declare.
1835         * tui/tui-winsource.c
1836         (tui_source_window_base::do_scroll_horizontal): Rename from
1837         tui_horizontal_source_scroll.
1838         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1839         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1840         from tui_vertical_data_scroll.
1841         * tui/tui-win.h (tui_scroll): Don't declare.
1842         * tui/tui-win.c (tui_win_info::forward_scroll)
1843         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1844         (tui_win_info::right_scroll): Rename and update.
1845         (tui_scroll_forward_command, tui_scroll_backward_command)
1846         (tui_scroll_left_command, tui_scroll_right_command): Update.
1847         (tui_scroll): Remove.
1848         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1849         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1850         from tui_vertical_source_scroll.
1851         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1852         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1853         from tui_vertical_disassem_scroll.
1854         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1855         do_scroll_horizontal>: New methods.
1856         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1857         Likewise.
1858         (struct tui_source_window_base): Add do_scroll_horizontal.
1859         (struct tui_source_window, struct tui_disasm_window): Add
1860         do_scroll_vertical.
1861         (struct tui_data_window, struct tui_cmd_window): Add
1862         do_scroll_horizontal and do_scroll_vertical.
1863         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1864
1865 2019-06-25  Tom Tromey  <tom@tromey.com>
1866
1867         * tui/tui-data.h (struct tui_source_window_base): New struct.
1868         (struct tui_source_window): Derive from tui_source_window_base.
1869         (struct tui_disasm_window): New struct.
1870         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1871         from tui_source_window::clear_detail.
1872         (tui_source_window_base): Rename from tui_source_window.
1873         (~tui_source_window_base): Rename from ~tui_source_window.
1874         (tui_alloc_win_info): Create a tui_disasm_window.
1875
1876 2019-06-25  Tom Tromey  <tom@tromey.com>
1877
1878         * tui/tui-data.h (struct tui_source_window)
1879         (struct tui_data_window): Declare destructors.
1880         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1881         destructors.
1882         (tui_win_info): Simplify.
1883
1884 2019-06-25  Tom Tromey  <tom@tromey.com>
1885
1886         * tui/tui-winsource.c (tui_display_main)
1887         (tui_update_source_windows_with_addr)
1888         (tui_update_all_breakpoint_info): Update.
1889         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1890         (new_height_ok, parse_scrolling_args): Update.
1891         * tui/tui-stack.c (tui_show_frame_info): Update.
1892         * tui/tui-data.h (struct tui_list): Remove.
1893         (tui_source_windows): Return a reference to a std::vector.
1894         * tui/tui-data.c (source_windows): Now a std::vector.
1895         (tui_source_windows): Change return type.
1896         (tui_clear_source_windows): Rewrite.
1897         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1898         (tui_free_all_source_wins_content): Rewrite.
1899
1900 2019-06-25  Tom Tromey  <tom@tromey.com>
1901
1902         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1903         (struct tui_data_window, struct tui_cmd_window): Declare
1904         clear_detail method.
1905         * tui/tui-data.c (tui_source_window::clear_detail)
1906         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1907         methods.
1908         (tui_clear_win_detail): Simplify.
1909
1910 2019-06-25  Tom Tromey  <tom@tromey.com>
1911
1912         * tui/tui-layout.c (make_source_window, make_disasm_window)
1913         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1914         Return the new window.
1915         (show_source_disasm_command, show_data)
1916         (show_source_or_disasm_and_command): Update.
1917
1918 2019-06-25  Tom Tromey  <tom@tromey.com>
1919
1920         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1921         parameter.  Return the new window.
1922         (show_source_disasm_command): Update and remove NULL check.
1923         (show_source_or_disasm_and_command): Update.
1924
1925 2019-06-25  Tom Tromey  <tom@tromey.com>
1926
1927         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1928
1929 2019-06-25  Tom Tromey  <tom@tromey.com>
1930
1931         * tui/tui-data.h (struct tui_win_info): Make constructor
1932         protected.  Make destructor virtual.  Add initializers.
1933         (tui_source_window, tui_data_window, tui_cmd_window): New
1934         classes.
1935         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1936         constructor.  Add "type" parameter.
1937         (tui_source_window, tui_data_window, tui_cmd_window): New
1938         constructors.
1939         (tui_alloc_win_info): Instantiate the appropriate subclass.
1940
1941 2019-06-25  Tom Tromey  <tom@tromey.com>
1942
1943         * tui/tui-win.c (tui_resize_all): Use delete.
1944         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1945         destructor.
1946         (tui_free_window): Don't declare.
1947         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1948         Update.
1949
1950 2019-06-25  Tom Tromey  <tom@tromey.com>
1951
1952         * tui/tui-data.h (struct tui_win_info): Add constructor.
1953         * tui/tui-data.c (tui_alloc_win_info): Use new.
1954         (tui_free_window): Use delete.
1955
1956 2019-06-22  Tom Tromey  <tom@tromey.com>
1957
1958         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1959         declare.
1960         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1961
1962 2019-06-22  Tom Tromey  <tom@tromey.com>
1963
1964         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1965         declare.
1966         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1967
1968 2019-06-22  Tom de Vries  <tdevries@suse.de>
1969
1970         * dwarf2read.c (create_addrmap_from_aranges)
1971         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1972         instead of '%zu'.
1973
1974 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1975
1976         * dwarf2read.h (dwarf2_section_info_def): Remove.
1977         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1978         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1979         std::vector<dwarf2_section_info>.
1980         (struct dwo_file) <~dwo_file>: Remove.
1981         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1982         types field.
1983         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1984         (dwarf2_read_debug_names): Likewise.
1985         (create_debug_types_hash_table): Change parameter type to
1986         array_view, adjust code accordingly.
1987         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1988         (partial_die_info::fixup): Likewise.
1989         (determine_prefix): Likewise.
1990         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1991
1992 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1993
1994         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1995         gdb_bfd_ref_ptr.
1996         <~dwo_file>: Remove call to gdb_bfd_unref.
1997         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1998         gdb_bfd_ref_ptr::get.
1999
2000 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2001
2002         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2003         type to htab_up.
2004         * dwarf2read.c (struct dwo_file): Initialize fields.
2005         <~dwo_file>: New.
2006         (free_dwo_file): Remove, move content to ~dwo_file.
2007         (struct dwo_file_deleter): Remove.
2008         (dwo_file_up>: Remove custom deleter.
2009         (free_dwo_files): Remove.
2010         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2011         dwo_files.
2012         (process_skeletonless_type_units): Call unique_ptr::get.
2013         (allocate_dwo_file_hash_table): Add deleter to created hash
2014         table.  Change return type to htab_up.
2015         (lookup_dwo_file_slot): Don't memset dwo_file, call
2016         unique_ptr::get.
2017         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2018         (create_dwo_unit_in_dwp_v2): Likewise.
2019         (open_and_init_dwo_file): Likewise.
2020         (free_dwo_file_from_slot): Remove.
2021
2022 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2023
2024         * dwarf2read.h (struct dwarf2_section_info) <readin,
2025         is_virtual>: Change type to bool.
2026         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2027         true instead of 1.
2028
2029 2019-06-19  Tom Tromey  <tom@tromey.com>
2030
2031         * tui/tui-data.h (tui_init_content_element): Don't declare.
2032
2033 2019-06-19  Tom Tromey  <tom@tromey.com>
2034
2035         * tui/tui-data.h (tui_init_win_info): Don't declare.
2036
2037 2019-06-19  Tom de Vries  <tdevries@suse.de>
2038
2039         * dwarf2read.h (abstract_to_concrete): Change type to
2040         std::unordered_map<sect_offset, std::vector<sect_offset>,
2041         gdb::hash_enum<sect_offset>>.
2042
2043 2019-06-19  Tom Tromey  <tromey@adacore.com>
2044
2045         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2046         EVAL_AVOID_SIDE_EFFECTS specially.
2047
2048 2019-06-19  Tom Tromey  <tromey@adacore.com>
2049
2050         * source-cache.c (highlighter): New global.
2051         (source_cache::get_source_lines): Create a highlighter on demand.
2052
2053 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2054
2055         * defs.h (deprecated_interactive_hook): Delete declaration.
2056         * interps.c (clear_interpreter_hooks): Remove use of
2057         deprecated_interactive_hook.
2058         * top.c (deprecated_interactive_hook): Delete definition.
2059         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2060
2061 2019-06-18  Tom de Vries  <tdevries@suse.de>
2062
2063         PR gdb/24515
2064         * dwarf2read.h (abstract_to_concrete): Change type from
2065         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2066         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2067         * dwarf2read.c (read_variable): Update.
2068         (dwarf2_fetch_die_loc_sect_off): Update.
2069
2070 2019-06-17  Tom de Vries  <tdevries@suse.de>
2071
2072         PR gdb/24617
2073         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2074         accessing parent[parent_len - 1].
2075
2076 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2077
2078         PR gdb/24364
2079         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2080         call dtrace_process_dof with NULL dof.
2081
2082 2019-06-16  Tom de Vries  <tdevries@suse.de>
2083
2084         PR gdb/24445
2085         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2086
2087 2019-06-16  Tom Tromey  <tom@tromey.com>
2088
2089         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2090         (make_all_visible): Use address of member.
2091
2092 2019-06-16  Tom Tromey  <tom@tromey.com>
2093
2094         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2095         (tui_free_window, free_content, free_content_elements): Remove
2096         unnecessary cast.
2097         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2098         cast.
2099         * tui/tui-regs.c (tui_show_register_group)
2100         (tui_display_registers_from, tui_display_reg_element_at_line):
2101         Remove unnecessary cast.
2102
2103 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2104
2105         * linux-nat.c (normal_mask): Delete.
2106         (_initialize_linux_nat): Don't initialise normal_mask.
2107
2108 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2109
2110         PR gdb/24445
2111         * dwarf-index-write.h (write_psymtabs_to_index): Add
2112         dwz_basename parameter.
2113         * dwarf-index-write.c (write_gdbindex): Move file writing to
2114         write_gdbindex_1.  Change return type void.
2115         (assert_file_size): Move up, remove filename parameter.
2116         (write_gdbindex_1): New function.
2117         (write_debug_names): Change return type to void, call
2118         assert_file_size.
2119         (struct index_wip_file): New struct.
2120         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2121         file logic to index_wip_file.  Write index for dwz file if
2122         needed.
2123         (save_gdb_index_command): Pass basename of dwz file, if present.
2124         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2125         build-id of dwz file, if present.
2126         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2127         (dwarf2_get_dwz_file): Likewise.
2128         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2129         (dwarf2_get_dwz_file): Likewise.
2130
2131 2019-06-16  Tom Tromey  <tom@tromey.com>
2132
2133         * coffread.c (process_coff_symbol): Use xstrdup.
2134         * value.c (create_internalvar): Use xstrdup.
2135
2136 2019-06-16  Tom Tromey  <tom@tromey.com>
2137
2138         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2139         * breakpoint.c (stopin_command, stopat_command)
2140         (until_break_command, decode_location_default): Remove unnecessary
2141         cast.
2142         * utils.c (subset_compare): Remove unnecessary cast.
2143         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2144         cast.
2145         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2146         cast.
2147         * infcmd.c (path_command): Remove unnecessary cast.
2148         * coffread.c (decode_type): Remove unnecessary cast.
2149         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2150         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2151         * tui/tui-stack.c (tui_show_locator_content)
2152         (tui_show_frame_info): Remove unnecessary cast.
2153         * tui/tui-win.c (tui_scroll_forward_command)
2154         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2155         (parse_scrolling_args): Remove unnecessary cast.
2156         * tui/tui-data.c (init_win_info, tui_del_window)
2157         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2158         (free_content_elements): Remove unnecessary cast.
2159         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2160         unnecessary cast.
2161         * tui/tui-source.c (tui_set_source_content)
2162         (tui_vertical_source_scroll): Remove unnecessary cast.
2163         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2164         cast.
2165         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2166         * tui/tui-regs.c (tui_display_registers_from)
2167         (tui_display_register): Remove unnecessary cast.
2168         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2169         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2170         (make_visible): Remove unnecessary cast.
2171         * tui/tui-winsource.c (tui_erase_source_content)
2172         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2173         unnecessary cast.
2174         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2175         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2176         * stabsread.c (read_type, read_array_type, read_range_type):
2177         Remove unnecessary cast.
2178         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2179         (parse_symbol, parse_type, upgrade_type, parse_external)
2180         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2181         unnecessary cast.
2182         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2183
2184 2019-06-16  Tom Tromey  <tom@tromey.com>
2185
2186         * tui/tui-data.c (tui_alloc_generic_win_info)
2187         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2188         checks.
2189
2190 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2191             Andrew Burgess  <andrew.burgess@embecosm.com>
2192
2193         * f-typeprint.c (f_print_type): Don't return early for not
2194         associated or not allocated types.
2195         (f_type_print_varspec_suffix): Add print_rank parameter and print
2196         ranks of array types in case they dangling.
2197         (f_type_print_base): Add print_rank parameter.
2198
2199 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2200
2201         * NEWS: Mention new MI commands.
2202         * break-catch-throw.c (enum exception_event_kind): Move to
2203         breakpoint.h.
2204         (print_mention_exception_catchpoint): Output text as a single
2205         message.
2206         (catch_exception_command_1): Rename to...
2207         (catch_exception_event): ...this, make non-static, update header
2208         command, and change some parameter types.
2209         (catch_catch_command): Update for changes to
2210         catch_exception_command_1.
2211         (catch_throw_command): Likewise.
2212         (catch_rethrow_command): Likewise.
2213         * breakpoint.c (enum exception_event_kind): Delete.
2214         * breakpoint.h (enum exception_event_kind): Moved here from
2215         break-catch-throw.c.
2216         (catch_exception_event): Declare.
2217         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2218         (mi_cmd_catch_throw): New function.
2219         (mi_cmd_catch_rethrow): New function.
2220         (mi_cmd_catch_catch): New function.
2221         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2222         'catch-catch' entries.
2223         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2224         (mi_cmd_catch_rethrow): Declare.
2225         (mi_cmd_catch_catch): Declare.
2226
2227 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2228
2229         * annotate.c (annotate_source_line): Change return type to void,
2230         update implementation to match.
2231         * annotate.h (annotate_source_line): Change return type to void,
2232         update header comment.
2233         * stack.c (print_frame_info): Don't change what frame information
2234         is printed based on whether annotations are on or not.
2235
2236 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2237
2238         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2239         (annotate_source): Make static.
2240         (annotate_source_line): Moved from source.c and renamed from
2241         identify_source_line.  Update the return type.
2242         * annotate.h (annotate_source): Delete declaration.
2243         (annotate_source_line): Declaration moved from source.h, and
2244         renamed from identify_source_line.  Return type updated.
2245         * source.c (identify_source_line): Moved to annotate.c and renamed
2246         to annotate_source_line.
2247         (info_line_command): Remove check of annotation_level.
2248         * source.h (identify_source_line): Move declaration to annotate.h
2249         and rename to annotate_source_line.
2250         * stack.c: Add 'annotate.h' include.
2251         (print_frame_info): Remove check of annotation_level before
2252         calling annotate_source_line.
2253
2254 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2255
2256         * source-cache.c (source_cache::get_plain_source_lines): Use
2257         open_source_file_with_line_charpos instead of just
2258         open_source_file, remove call to find_source_lines.
2259         (source_cache::get_source_lines): Likewise.
2260         * source.c (find_source_lines): Make static.
2261         (get_filename_and_charpos): Renamed into...
2262         (open_source_file_with_line_charpos): ..this along with changes to
2263         return a scoped_fd, and some other minor clean ups.
2264         (identify_source_line): Use open_source_file_with_line_charpos.
2265         (search_command_helper): Use open_source_file_with_line_charpos
2266         instead of just open_source_file, remove call to
2267         find_source_lines.
2268         * source.h (open_source_file_with_line_charpos): Declare new
2269         function.
2270         (find_source_lines): Delete declaration.
2271
2272 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2273
2274         * source.c (get_filename_and_charpos): Remove fullname
2275         parameter.
2276         (identify_source_line): Update call to get_filename_and_charpos.
2277
2278 2019-06-14  Tom Tromey  <tromey@adacore.com>
2279
2280         PR gdb/24502:
2281         * ui-style.h (skip_ansi_escape): Update comment.
2282         * ui-file.h (class no_terminal_escape_file): New class.
2283         * ui-file.c (no_terminal_escape_file::write)
2284         (no_terminal_escape_file::puts): New methods.
2285         * cli/cli-logging.c (handle_redirections): Use
2286         no_terminal_escape_file.
2287
2288 2019-06-14  Tom Tromey  <tromey@adacore.com>
2289
2290         * NEWS: Move convenience variable news above Python news.
2291
2292 2019-06-14  Tom Tromey  <tom@tromey.com>
2293
2294         * gnulib: Move directory to top-level.
2295         * configure.ac: Don't configure gnulib.
2296         * configure: Rebuild.
2297         * common/common-defs.h: Use new path to gnulib.
2298         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2299         (GNULIB_H): Remove.
2300         (INCGNU): Look in new gnulib location.
2301         (HFILES_NO_SRCDIR): Remove gnulib files.
2302         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2303         (generated_files): Remove GNULIB_H.
2304         ($(LIBGNU), all-lib): Remove targets.
2305         (distclean): Don't mention GNULIB_BUILDDIR.
2306         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2307
2308 2019-06-14  Tom Tromey  <tromey@adacore.com>
2309
2310         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2311         Warn if symbol file does not provide any symbols.
2312
2313 2019-06-14  Tom Tromey  <tromey@adacore.com>
2314
2315         * source.c (find_and_open_source): Respect basenames_may_differ.
2316
2317 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2318
2319         * annotate.c (annotate_breakpoints_invalid): Make use of
2320         scoped_restore_terminal_state.
2321         (annotate_frames_invalid): Likewise.
2322
2323 2019-06-14  Tom Tromey  <tromey@adacore.com>
2324
2325         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2326         allow assignment to an internalvar.
2327
2328 2019-06-14  Tom Tromey  <tromey@adacore.com>
2329
2330         * ada-lex.l: Allow "_" in attribute names.
2331
2332 2019-06-14  Tom Tromey  <tromey@adacore.com>
2333
2334         PR gdb/24653:
2335         * regcache.c (registers_changed): Don't call alloca.
2336         * top.c (execute_command): Don't call alloca.
2337
2338 2019-06-13  Pedro Alves  <palves@redhat.com>
2339
2340         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2341         'expression'.  When parsing an expression, error out if there's
2342         junk after "unlimited".
2343         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2344         (do_set_command): Adjust calls to is_unlimited_literal.
2345
2346 2019-06-13  Pedro Alves  <palves@redhat.com>
2347
2348         * compile/compile.c (make_compile_options_def_group): Add braces
2349         around array_view initializer.
2350         * thread.c (make_thread_apply_all_options_def_group)
2351         (make_thread_apply_all_options_def_group): Likewise.
2352
2353 2019-06-13  Pedro Alves  <palves@redhat.com>
2354
2355         * NEWS (New commands): Mention "maint test-options
2356         require-delimiter", "maint test-options unknown-is-error", "maint
2357         test-options unknown-is-operand" and "maint show
2358         test-options-completion-result".
2359         (New command options, command completion): New section.
2360         (Completion improvements): New section.
2361         Mention that you can abbreviate "unlimited".
2362
2363 2019-06-13  Pedro Alves  <palves@redhat.com>
2364
2365         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2366         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2367         * unittests/cli-utils-selftests.c (test_parse_flags)
2368         (test_parse_flags_qcs): Delete.
2369         (test_cli_utils): Don't call deleted functions.
2370
2371 2019-06-13  Pedro Alves  <palves@redhat.com>
2372
2373         * thread.c: Include "cli/cli-option.h".
2374         (tp_array_compar_ascending): Global.
2375         (tp_array_compar): Delete function.
2376         (tp_array_compar_ascending, tp_array_compar_descending): New
2377         functions.
2378         (ascending_option_def, qcs_flag_option_def)
2379         (thr_qcs_flags_option_defs)
2380         (make_thread_apply_all_options_def_group)
2381         (make_thread_apply_options_def_group): New.
2382         (thread_apply_all_command): Use gdb::option::process_options.
2383         (thread_apply_command_completer)
2384         (thread_apply_all_command_completer): New.
2385         (thread_apply_command): Use gdb::option::process_options.
2386         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2387         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2388         to generate help text of "thread apply".  Adjust "taas"'s help.
2389         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2390         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2391
2392 2019-06-13  Pedro Alves  <palves@redhat.com>
2393
2394         * thread.c (thread_apply_command): Check for invalid TID with
2395         isdigit instead of !isalpha.
2396
2397 2019-06-13  Pedro Alves  <palves@redhat.com>
2398
2399         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2400         (validate_flags_qcs): New.
2401         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2402         (validate_flags_qcs): Declare.
2403         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2404         (make_frame_apply_options_def_group): New.
2405         (frame_apply_command_count): Process options with
2406         gdb::option::process_options.
2407         (frame_apply_completer): New.
2408         (frame_apply_level_completer, frame_apply_all_completer)
2409         (frame_apply_completer): New.
2410         (_initialize_stack): Update help of "frame apply", "frame apply
2411         level", "frame apply all" and "faas" to mention supported options
2412         and install command completers.
2413         * stack.h (frame_apply_all_completer): Declare.
2414         * thread.c: Include "stack.h".
2415         (tfaas_command): Add "--".
2416         (_initialize_thread): Update help "tfaas" to mention supported
2417         options and install command completer.
2418
2419 2019-06-13  Pedro Alves  <palves@redhat.com>
2420
2421         * completer.c (complete_nested_command_line): New.
2422         (gdb_completion_word_break_characters_throw): Add assertion.
2423         * completer.h (complete_nested_command_line): Declare.
2424
2425 2019-06-13  Pedro Alves  <palves@redhat.com>
2426
2427         * stack.c (parse_backtrace_qualifiers): New.
2428         (backtrace_command): Use it.
2429         (backtrace_command_completer): Complete on qualifiers.
2430
2431 2019-06-13  Pedro Alves  <palves@redhat.com>
2432
2433         * frame.c: Include "cli/cli-option.h.
2434         (user_set_backtrace_options): New.
2435         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2436         Delete.
2437         (get_prev_frame): Adjust.
2438         (boolean_option_def, uinteger_option_def)
2439         (set_backtrace_option_defs): New.
2440         (_initialize_frame): Adjust and use
2441         gdb::option::add_setshow_cmds_for_options to install "set
2442         backtrace past-main" and "set backtrace past-entry".
2443         * frame.h: Include "cli/cli-option.h".
2444         (struct frame_print_options): Forward declare.
2445         (print_frame_arguments_all, print_frame_arguments_scalars)
2446         (print_frame_arguments_none): Declare.
2447         (print_entry_values): Delete declaration.
2448         (struct frame_print_options, user_frame_print_options): New.
2449         (struct set_backtrace_options): New.
2450         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2451         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2452         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2453         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2454         (list_args_or_locals): Add frame_print_options parameter.
2455         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2456         * python/py-framefilter.c (enumerate_args): Pass down
2457         USER_FRAME_PRINT_OPTIONS.
2458         * stack.c: Include "cli/cli-option.h".
2459         (print_frame_arguments_all, print_frame_arguments_scalars)
2460         (print_frame_arguments_none): Declare.
2461         (print_raw_frame_arguments, print_entry_values): Delete.
2462         (user_frame_print_options): New.
2463         (boolean_option_def, enum_option_def, frame_print_option_defs):
2464         New.
2465         (struct backtrace_cmd_options): New.
2466         (bt_flag_option_def): New.
2467         (backtrace_command_option_defs): New.
2468         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2469         (print_frame_arg, read_frame_arg, print_frame_args)
2470         (print_frame_info, print_frame): Add frame_print_options parameter
2471         and use it.
2472         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2473         (backtrace_command_1): Add frame_print_options and
2474         backtrace_cmd_options parameters and use them.
2475         (make_backtrace_options_def_group): New.
2476         (backtrace_command): Process command options with
2477         gdb::option::process_options.
2478         (backtrace_command_completer): New.
2479         (_initialize_stack): Extend "backtrace"'s help to mention
2480         supported options.  Install completer for "backtrace".
2481         Install some settings commands with add_setshow_cmds_for_options.
2482
2483 2019-06-13  Pedro Alves  <palves@redhat.com>
2484
2485         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2486         and that "set/show print raw frame-arguments" are now deprecated.
2487
2488         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2489         command.
2490         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2491         * stack.c (_initialize_stack): Install "set/show print
2492         raw-frame-arguments", and deprecate "set/show print raw
2493         frame-arguments".
2494         * valprint.c (_initialize_valprint): Deprecate "set/show print
2495         raw".
2496
2497 2019-06-13  Pedro Alves  <palves@redhat.com>
2498
2499         * compile/compile.c (struct compile_options): New.
2500         (compile_flag_option_def, compile_command_option_defs)
2501         (make_compile_options_def_group): New.
2502         (compile_file_command): Handle options with
2503         gdb::option::process_options.
2504         (compile_file_command_completer): New function.
2505         (compile_code_command): Handle options with
2506         gdb::option::process_options.
2507         (compile_code_command_completer): New function.
2508         (_initialize_compiler): Install completers for "compile code" and
2509         "compile file".  Mention available options in "compile code" and
2510         "compile code"'s help.
2511         * completer.c (advance_to_completion_word): New, factored out from
2512         ...
2513         (advance_to_expression_complete_word_point): ... this.
2514         (advance_to_filename_complete_word_point): New.
2515         * completer.h (advance_to_filename_complete_word_point): New
2516         declaration.
2517
2518 2019-06-13  Pedro Alves  <palves@redhat.com>
2519
2520         * compile/compile.c: Include "cli/cli-option.h".
2521         (compile_print_value): Scope data pointer is now a
2522         value_print_options pointer; adjust.
2523         (compile_print_command): Process options.  Scope data pointer is
2524         now a value_print_options pointer; adjust.
2525         (_initialize_compile): Update "compile print"'s help to include
2526         supported options.  Install a completer for "compile print".
2527         * cp-valprint.c (show_vtblprint, show_objectprint)
2528         (show_static_field_print): Delete.
2529         (_initialize_cp_valprint): Don't install "set print
2530         static-members", "set print vtbl", "set print object" here.
2531         * printcmd.c: Include "cli/cli-option.h" and
2532         "common/gdb_optional.h".
2533         (print_command_parse_format): Rework to fill in a
2534         value_print_options instead of a format_data.
2535         (print_value): Change parameter type from format_data pointer to
2536         value_print_options reference.  Adjust.
2537         (print_command_1): Process options.  Adjust to pass down a
2538         value_print_options.
2539         (print_command_completer): New.
2540         (_initialize_printcmd): Install print_command_completer as
2541         handle_brkchars completer for the "print" command.  Update
2542         "print"'s help to include supported options.
2543         * valprint.c: Include "cli/cli-option.h".
2544         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2545         here from cp-valprint.c.
2546         (boolean_option_def, uinteger_option_def)
2547         (value_print_option_defs, make_value_print_options_def_group):
2548         New.  Use gdb::option::add_setshow_cmds_for_options to install
2549         "set print elements", "set print null-stop", "set print repeats",
2550         "set print pretty", "set print union", "set print array", "set
2551         print address", "set print symbol", "set print array-indexes".
2552         * valprint.h: Include <string> and "cli/cli-option.h".
2553         (make_value_print_options_def_group): Declare.
2554         (print_value): Change parameter type from format_data pointer to
2555         value_print_options reference.
2556         (print_command_completer): Declare.
2557
2558 2019-06-13  Pedro Alves  <palves@redhat.com>
2559
2560         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2561         (COMMON_SFILES): Add maint-test-settings.c.
2562         * cli/cli-decode.c (boolean_enums): New global, factored out from
2563         ...
2564         (add_setshow_boolean_cmd): ... here.
2565         * cli/cli-decode.h (boolean_enums): Declare.
2566         * cli/cli-option.c: New file.
2567         * cli/cli-option.h: New file.
2568         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2569         factored out from ...
2570         (parse_cli_boolean_value(const char *)): ... this.
2571         (is_unlimited_literal): Change parameter type to pointer to
2572         pointer.  Adjust and advance ARG pointer.
2573         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2574         (parse_cli_var_enum): New, factored out from ...
2575         (do_set_command): ... this.  Adjust.
2576         * cli/cli-setshow.h (parse_cli_boolean_value)
2577         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2578         (parse_cli_var_enum): Declare.
2579         * cli/cli-utils.c: Include "cli/cli-option.h".
2580         (get_ulongest): New.
2581         * cli/cli-utils.h (get_ulongest): Declare.
2582         (check_for_argument): New overloads.
2583         * maint-test-options.c: New file.
2584
2585 2019-06-13  Pedro Alves  <palves@redhat.com>
2586
2587         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2588         parse a range if "-" is at the end of the string.
2589
2590 2019-06-13  Pedro Alves  <palves@redhat.com>
2591
2592         * cli/cli-setshow.c (parse_auto_binary_operation)
2593         (parse_cli_boolean_value): Don't allow "o".
2594
2595 2019-06-13  Pedro Alves  <palves@redhat.com>
2596
2597         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2598         * NEWS: Mention maint test-settings KIND.
2599         * maint-test-settings.c: New file.
2600
2601 2019-06-13  Pedro Alves  <palves@redhat.com>
2602
2603         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2604         completer.
2605         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2606         "set" completers.
2607
2608 2019-06-13  Pedro Alves  <palves@redhat.com>
2609
2610         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2611         after item.
2612
2613 2019-06-13  Pedro Alves  <palves@redhat.com>
2614
2615         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2616
2617 2019-06-13  Pedro Alves <palves@redhat.com>
2618
2619         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2620         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2621         call.
2622         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2623         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2624         calls.
2625         (check_for_argument): Skip spaces after argument.
2626
2627 2019-06-13  Pedro Alves  <palves@redhat.com>
2628
2629         * thread.c (thread_apply_command): Adjust TID parsing.
2630         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2631         detected before end of string.
2632         (tid_is_in_list): Error out if LIST is invalid.
2633
2634 2019-06-13  Pedro Alves  <palves@redhat.com>
2635
2636         * completer.c (complete_line_internal_1): Rewind completion word
2637         point.
2638         (completion_tracker::advance_custom_word_point_by): Change
2639         parameter type to int.
2640         * completer.h (completion_tracker::advance_custom_word_point_by):
2641         Likewise.
2642
2643 2019-06-13  Pedro Alves  <palves@redhat.com>
2644
2645         * completer.c (advance_to_completion_word): Handle delimiters.
2646
2647 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2648
2649         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2650
2651 2019-06-11  Tom Tromey  <tom@tromey.com>
2652
2653         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2654         (xmalloc_failed): Move to alloc.c.
2655         * alloc.c: New file.
2656         * Makefile.in (COMMON_SFILES): Add alloc.c.
2657
2658 2019-06-11  Tom Tromey  <tom@tromey.com>
2659
2660         * nat/linux-waitpid.c: Don't include server.h.
2661         (linux_debug): Remove.
2662         (my_waitpid): Update.
2663
2664 2019-06-11  Tom Tromey  <tromey@adacore.com>
2665
2666         * infcall.c (_initialize_infcall): Remove trailing newline from
2667         help.
2668         * user-regs.c (_initialize_user_regs): Remove trailing newline
2669         from help.
2670         * typeprint.c (_initialize_typeprint): Remove trailing newline
2671         from help.
2672         * reverse.c (_initialize_reverse): Remove trailing newlines from
2673         help.
2674         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2675         from help.
2676         * language.c (add_set_language_command): Remove trailing newline
2677         from help.
2678         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2679         help.
2680         * disasm.c (_initialize_disasm): Remove trailing newline from
2681         help.
2682         * top.c (init_main): Remove trailing newline from help.
2683         * interps.c (_initialize_interpreter): Remove trailing newline
2684         from help.
2685         * btrace.c (_initialize_btrace): Remove trailing newlines from
2686         help.
2687         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2688         from help.
2689         * python/python.c (_initialize_python): Remove trailing newline
2690         from help.
2691         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2692         help.
2693         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2694         from help.  Reformat some text.
2695         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2696         from help.
2697         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2698         newline from help.
2699
2700 2019-06-11  Tom Tromey  <tromey@adacore.com>
2701
2702         * darwin-nat.c (darwin_decode_exception_message)
2703         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2704
2705 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2706
2707         * valops.c (value_slice): Check for not allocated or not
2708         associated values.
2709
2710 2019-06-10  Tom de Vries  <tdevries@suse.de>
2711
2712         PR gdb/24618
2713         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2714         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2715         invalid.
2716
2717 2019-06-10  Tom de Vries  <tdevries@suse.de>
2718
2719         PR gdb/24611
2720         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2721         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2722
2723 2019-06-10  Tom de Vries  <tdevries@suse.de>
2724
2725         PR symtab/24545
2726         * symtab.c (struct demangled_name_entry): Add language field.
2727         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2728         static minimal symbol".  Set and use language field.
2729
2730 2019-06-10  Tom Tromey  <tromey@adacore.com>
2731
2732         * ada-lang.c (_initialize_ada_language): Update help text.
2733
2734 2019-06-10  Tom Tromey  <tromey@adacore.com>
2735
2736         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2737         with a newline.
2738         * guile/guile.c (handle_boot_error): Don't end warning with a
2739         newline.
2740         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2741         warning with a newline.
2742         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2743         newline.
2744         (s12z_frame_cache): Likewise.
2745         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2746         a newline.
2747         * solib-svr4.c (disable_probes_interface): Don't end warning with
2748         a newline.
2749         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2750         newline.
2751         * python/python.c (do_finish_initialization): Don't end warning
2752         with a newline.
2753
2754 2019-06-10  Tom Tromey  <tom@tromey.com>
2755
2756         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2757         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2758         gdbpy_enter.
2759
2760 2019-06-10  Tom Tromey  <tromey@adacore.com>
2761
2762         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2763         data.
2764         (elf_new_init): Don't call stabsread_new_init.
2765         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2766         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2767         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2768
2769 2019-06-10  Tom de Vries  <tdevries@suse.de>
2770
2771         PR symtab/16264
2772         PR symtab/24517
2773         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2774
2775 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2776
2777         * source.c (find_and_open_source): Also rewrite relative file
2778         names.
2779
2780 2019-04-26  Amos Bird  <amosbird@gmail.com>
2781
2782         * annotate.c (annotate_thread_exited): Add "thread-exited"
2783         annotation.
2784
2785 2019-06-06  Tom Tromey  <tromey@adacore.com>
2786
2787         * maint.h (class scoped_command_stats): Use
2788         DISABLE_COPY_AND_ASSIGN.
2789         <print_time>: New method.
2790         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2791         print_time.
2792         (scoped_command_stats::print_time): New method.
2793
2794 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2795
2796         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2797         instructions of lengths 6 or 8 bytes.
2798
2799 2019-06-04  Pedro Alves  <palves@redhat.com>
2800
2801         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2802
2803         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2804         * breakpoint.c (condition_completer): Likewise.
2805         * cli/cli-dump.c (scan_expression): Likewise.
2806         * common/filestuff.c (mkdir_recursive): Likewise.
2807         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2808         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2809         (gdb_abspath): Likewise.
2810         * compile/compile-cplus-types.c
2811         (compile_cplus_instance::decl_name): Likewise.
2812         * completer.c (complete_explicit_location):
2813         (signal_completer, reg_or_group_completer_1): Likewise.
2814         * cp-support.c (cp_remove_params_if_any): Likewise.
2815         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2816         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2817         * infcmd.c (strip_bg_char): Likewise.
2818         * linespec.c (copy_token_string): Likewise.
2819         * mi/mi-main.c (output_cores): Likewise.
2820         * psymtab.c (psymtab_search_name):
2821         * symfile.c (test_set_ext_lang_command): Likewise.
2822         * target.c (target_fileio_read_stralloc): Likewise.
2823         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2824         * value.c (complete_internalvar): Likewise.
2825
2826 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2827
2828         Add objfile property to gdb.Type.
2829         * NEWS: Mention Python API addition.
2830         * python/py-type.c (typy_get_objfile): New method.
2831
2832 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2833
2834         * NEWS: Mention the new set|show style [title|highlight].
2835         Mention changes to "show style", "help" and "apropos".
2836
2837 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2838
2839         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2840         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2841         instead of print_help_for_command.
2842         (print_doc_of_command): New function.
2843         (help_list): Add 'apropos -v word' suggestion.
2844         (print_help_for_command): Style the command name using title style.
2845         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2846         (_initialize_cli_cmds): Describe -v in apropos_command help.
2847
2848 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2849
2850         * cli/cli-style.h (cli_style_option): Add name in constructor,
2851         add m_name class member, add constructor with intensity,
2852         add name class function.
2853         (cli_style_option::add_setshow_commands): Remove name argument.
2854         (highlight_style, title_style): New styles.
2855         * cli/cli-style.c (do_show): New function that shows a style
2856         characteristic styling the style name with itself.
2857         (set_style_name): New function.
2858         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2859         Update all callers according to the changes in cli/cli-style.h.
2860         * utils.h (fputs_highlighted): New function.
2861         * utils.c (fputs_highlighted): Likewise.
2862
2863 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2864
2865         * NEWS: Mention new pipe command and new convenience variables.
2866
2867 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2868
2869         * cli/cli-cmds.c (pipe_command): New function.
2870         (_initialize_cli_cmds): Call add_com for pipe_command.
2871         Define | as an alias for pipe.
2872         (exit_status_set_internal_vars): New function.
2873         (shell_escape): Call exit_status_set_internal_vars.
2874         cli/cli-decode.c (find_command_name_length): Recognize | as
2875         a single character command.
2876
2877 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2878
2879         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2880         top.c (execute_command_to_ui_file): New function, mostly a copy
2881         of execute_command_to_string.
2882         (execute_command_to_string): Implement by calling
2883         execute_command_to_ui_file.
2884
2885 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2886
2887         * top.h (saved_command_line): Remove declaration.
2888         * top.c (previous_saved_command_line, previous_repeat_arguments):
2889         New variables.
2890         (saved_command_line): Make static, define together with other
2891         'repeat variables'.
2892         (dont_repeat): Clear repeat_arguments.
2893         (repeat_previous, get_saved_command_line, save_command_line):
2894         New functions.
2895         (gdb_init): Initialize saved_command_line
2896         and previous_saved_command_line.
2897         * main.c (captured_main_1): Remove saved_command_line initialization.
2898         * event-top.c (handle_line_of_input): Update to use
2899         the new 'repeat' related functions instead of direct access to
2900         saved_command_line.
2901         * command.h (repeat_previous, get_saved_command_line,
2902         save_command_line): New declarations.
2903         (dont_repeat): Add comment.
2904
2905 2019-05-30  Tom Tromey  <tromey@adacore.com>
2906
2907         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2908         Fix comment.
2909         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2910
2911 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2912
2913         PR cli/24587
2914         * completer.c (complete): Initialize variable word.
2915
2916 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2917
2918         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2919         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2920         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2921         'body' is NULL to the outter 'if', protecting the '!is_define'
2922         situation as well.
2923
2924 2019-05-29  Tom Tromey  <tromey@adacore.com>
2925
2926         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2927         (dwarf_unknown): New function.
2928         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2929         (dwarf_type_encoding_name): Use dwarf_unknown.
2930
2931 2019-05-29  Tom Tromey  <tromey@adacore.com>
2932
2933         PR c++/20020:
2934         * cp-valprint.c (cp_print_value_fields): Call
2935         cp_print_static_field inside "try".
2936
2937 2019-05-29  Tom Tromey  <tromey@adacore.com>
2938
2939         * inflow.c (struct terminal_info): Add default operator=.
2940         * configure: Rebuild.
2941         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2942         -Wdeprecated-copy-dtor, -Wredundant-move.
2943
2944 2019-05-29  Tom Tromey  <tromey@adacore.com>
2945
2946         * NEWS: Add entry.
2947         * infcmd.c (print_return_value_1): Handle finish_print
2948         option.
2949         (show_print_finish): New function.
2950         (_initialize_infcmd): Add "set/show print finish" commands.
2951         * valprint.c (user_print_options): Initialize new member.
2952         * valprint.h (struct value_print_options) <finish_print>: New
2953         member.
2954
2955 2019-05-28  Tom Tromey  <tromey@adacore.com>
2956
2957         * ada-lang.c (ada_remove_Xbn_suffix)
2958         (find_old_style_renaming_symbol)
2959         (parse_old_style_renaming): Remove.
2960         (ada_find_renaming_symbol): Don't call
2961         find_old_style_renaming_symbol.
2962         (ada_is_renaming_symbol): Rename from
2963         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2964         bool.  Now static.
2965         (ada_read_var_value): Update and simplify.
2966         * ada-exp.y (write_var_or_type): Remove old code.
2967
2968 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2969
2970         * event-top.c: Remove include comment.
2971         * inflow.c (class scoped_ignore_sigttou): Move from here...
2972         * inflow.h (class scoped_ignore_sigttou): ...to here.
2973         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2974         * top.c:  Remove include comment.
2975
2976 2019-05-27  Tom Tromey  <tom@tromey.com>
2977
2978         * NEWS: Fix typo.
2979
2980 2019-05-22  Tom Tromey  <tromey@adacore.com>
2981
2982         * target.c (target_follow_exec): Constify parameter.
2983         * target-delegates.c: Rebuild.
2984         * remote.c (remote_target::follow_exec): Constify parameter.
2985         * infrun.c (follow_exec): Constify parameter.
2986         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2987         (target_follow_exec): Likewise.
2988
2989 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2990
2991         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2992         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2993
2994 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2995
2996         * NEWS: Add debugredirect and testsuite sections.
2997
2998 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2999
3000         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3001         target descriptions using exclusively floating point register name
3002         aliases.
3003
3004 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3005
3006         PR gdb/18644:
3007         * f-lang.c (build_fortran_types): Handle the case where
3008         gdbarch_floatformat_for_type returns a nullptr.
3009
3010 2019-05-21  Tom de Vries  <tdevries@suse.de>
3011
3012         PR cli/24587
3013         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3014
3015 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3016
3017         PR gdb/18644:
3018         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3019         16-byte floats.
3020         * i386-tdep.c (i386_floatformat_for_type): Use
3021         floatformats_ia64_quad for the 16-byte floating point component
3022         within a fortran 32-byte complex number.
3023
3024 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3025
3026         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3027         delete default constructor.
3028         (find_partial_die): Update to return const struct.
3029         (partial_die_parent_scope): Move variable declaration into scope
3030         of its use and change its type to auto.
3031         (guess_partial_die_structure_name): Likewise.
3032         (partial_die_info::fixup): Likewise.
3033
3034 2019-05-17  Tom Tromey  <tromey@adacore.com>
3035
3036         * source.c (find_and_open_source): Remove cast.
3037
3038 2019-05-17  Tom Tromey  <tromey@adacore.com>
3039
3040         * annotate.c (annotate_source): Make "filename" const.
3041         * annotate.h (annotate_source): Use const.
3042
3043 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3044
3045         * disasm.c (set_disassembler_options): Send errors to stderr.
3046
3047 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3048
3049         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3050         (cli_interp_base::set_logging): Check debug_redirect.
3051         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3052         * cli/cli-logging.c (debug_redirect): Add static variable.
3053         (pop_output_files): Add default param.
3054         (handle_redirections): Print debug setting.
3055         (show_logging_command): Likewise.
3056         (_initialize_cli_logging): Add debugredirect command.
3057         * interps.c (current_interp_set_logging): Add debug_redirect
3058         parameter.
3059         * interps.h (set_logging): Add debug_redirect parameter.
3060         (current_interp_set_logging): Likewise.
3061         * mi/mi-common.h: Likewise.
3062         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3063
3064 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3065             Tom Tromey  <tromey@adacore.com>
3066
3067         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3068         directly.
3069         * cli/cli-interp.h (make_logging_output): Remove declaration.
3070         * cli/cli-logging.c (make_logging_output): Remove function.
3071         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3072         directly.
3073         * ui-file.c (tee_file::tee_file): Remove bools.
3074         (tee_file::~tee_file): Remove deletes.
3075         * ui-file.h (tee_file): Remove bools.
3076
3077 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3078
3079         * mi/mi-cmds.h (mi_cmd_complete): New function.
3080         * mi/mi-main.c (mi_cmd_complete): Likewise.
3081         * mi/mi-cmds.c: Define new MI command -complete.
3082         * NEWS: Mention new -complete command.
3083
3084 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3085
3086         * completer.h (complete): New function.
3087         * completer.c (complete): Likewise.
3088         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3089         function defined in completer.h.
3090
3091 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3092
3093         * MAINTAINERS (Write After Approval): Add myself.
3094
3095 2019-05-17  Tom de Vries  <tdevries@suse.de>
3096
3097         PR gdb/24094
3098         * dwarf2read.c (struct cu_partial_die_info): New struct.
3099         (find_partial_die): Return cu_partial_die_info.
3100         (partial_die_parent_scope, guess_partial_die_structure_name)
3101         (partial_die_info::fixup): Handle new return type of find_partial_die.
3102
3103 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3104
3105         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3106         "std::string", simplifying the algorithm.
3107
3108 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3109
3110         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3111         (stap_static_probe_ops::get_probes): Likewise.
3112
3113 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3114
3115         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3116         '-')" and "else if".
3117         (stap_parse_single_operand): Join checks for
3118         "gdbarch_stap_parse_special_token_p" and
3119         "gdbarch_stap_parse_special_token" in the same "if" statement.
3120         Invert check when verifying for operation on register
3121         displacement.
3122
3123 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3124
3125         * stap-probe.c (stap_get_opcode): Update comment.
3126         (stap_get_expected_argument_type): Likewise.
3127         (handle_stap_probe): Likewise.
3128
3129 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3130
3131         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3132         return type to 'bool'.  Adjust comment.  Use 'bool' when
3133         appropriate.
3134         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3135         * stap-probe.c (stap_parse_argument_1): Likewise.
3136         (stap_is_operator): Likewise.
3137         (stap_is_generic_prefix): Likewise.
3138         (stap_is_register_prefix): Likewise.
3139         (stap_is_register_indirection_prefix): Likewise.
3140         (stap_is_integer_prefix): Likewise.
3141         (stap_generic_check_suffix): Likewise.
3142         (stap_check_integer_suffix): Likewise.
3143         (stap_check_register_suffix): Likewise.
3144         (stap_check_register_indirection_suffix): Likewise.
3145         (stap_parse_register_operand): Likewise.
3146         (stap_parse_single_operand): Likewise.
3147         (stap_parse_argument_1): Likewise.
3148         (stap_probe::get_argument_count): Likewise.
3149         (stap_is_operator): Likewise.
3150
3151 2019-05-16  Tom Tromey  <tromey@adacore.com>
3152
3153         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3154         keyword to foreach.
3155
3156 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3157
3158         * linux-thread-db.c (try_thread_db_load_1): Change return type
3159         to bool.
3160         (try_thread_db_load): Likewise.
3161         (try_thread_db_load_from_pdir_1): Likewise.
3162         (try_thread_db_load_from_pdir): Likewise.
3163         (try_thread_db_load_from_sdir): Likewise.
3164         (try_thread_db_load_from_dir): Likewise.
3165         (thread_db_load_search): Likewise.
3166         (has_libpthread): Likewise.
3167         (thread_db_load): Likewise.
3168
3169 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3170
3171         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3172         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3173         NULL, and complain/return if that's the case.
3174
3175 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3176
3177         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3178         (advance, posn, abstract_read_memory): New functions.
3179         [struct mem_read_abstraction]: New struct.
3180         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3181
3182 2019-05-14  Tom Tromey  <tromey@adacore.com>
3183
3184         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3185         value is not lval_memory.
3186
3187 2019-05-14  Tom Tromey  <tromey@adacore.com>
3188
3189         * solib.c (info_sharedlibrary_command): Style the file name.
3190
3191 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3192
3193         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3194         (aarch64_vnv_type): Likewise.
3195         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3196         * common/tdesc.c: Likewise.
3197         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3198         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3199         * features/aarch64-fpu.xml: Add ieee half view.
3200         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3201         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3202         * gdbtypes.h (struct builtin_type): Likewise.
3203         (struct objfile_type): Likewise.
3204
3205 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3206
3207         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3208         typo.
3209         * location.h (string_to_event_location): Likewise.
3210
3211 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3212
3213         GDB 8.3 released.
3214
3215 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3216
3217         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3218         New variable declaration.
3219         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3220         New variable.
3221         (print_one_breakpoint): Use ui_out::test_flags and new global
3222         variable to compute use_fixed_output.
3223         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3224         Remove.
3225         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3226         (mi_multi_location_breakpoint_output_fixed): Remove.
3227         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3228         new variable.
3229         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3230         fix_multi_location_breakpoint_output flag if version >= 3.
3231         * ui-out.h (enum ui_out_flag)
3232         <fix_multi_location_breakpoint_output>: New enumerator.
3233
3234 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3235
3236         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3237
3238 2019-05-10  Tom Tromey  <tromey@adacore.com>
3239
3240         * ada-lang.c (catch_ada_completer): New function.
3241         (_initialize_ada_language): Use it.
3242
3243 2019-05-10  Tom Tromey  <tromey@adacore.com>
3244
3245         * thread.c (print_thread_info): Make "requested_threads" const.
3246         * gdbthread.h (print_thread_info): Make "requested_threads"
3247         const.
3248         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3249         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3250
3251 2019-05-08  Tom Tromey  <tom@tromey.com>
3252
3253         * gdbtypes.c (objfile_type_data): Change type.
3254         (objfile_type, _initialize_gdbtypes): Update.
3255
3256 2019-05-08  Tom Tromey  <tom@tromey.com>
3257
3258         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3259         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3260         (_initialize_dwarf2_frame): Update.
3261
3262 2019-05-08  Tom Tromey  <tom@tromey.com>
3263
3264         * objc-lang.c (objc_objfile_data): Change type.
3265         (find_methods): Update.
3266         (_initialize_objc_lang): Remove.
3267
3268 2019-05-08  Tom Tromey  <tom@tromey.com>
3269
3270         * stabsread.c (rs6000_builtin_type_data): Change type.
3271         (rs6000_builtin_type, _initialize_stabsread): Update.
3272
3273 2019-05-08  Tom Tromey  <tom@tromey.com>
3274
3275         * mips-tdep.c (mips_pdr_data): Remove.
3276         (_initialize_mips_tdep): Update.
3277
3278 2019-05-08  Tom Tromey  <tom@tromey.com>
3279
3280         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3281         (hppa_init_objfile_priv_data, read_unwind_info)
3282         (find_unwind_entry, _initialize_hppa_tdep): Update.
3283
3284 2019-05-08  Tom Tromey  <tom@tromey.com>
3285
3286         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3287         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3288         on obstack.
3289         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3290
3291 2019-05-08  Tom Tromey  <tom@tromey.com>
3292
3293         * mdebugread.c (basic_type_data): Change type.
3294         (basic_type, _initialize_mdebugread): Update.
3295
3296 2019-05-08  Tom Tromey  <tom@tromey.com>
3297
3298         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3299
3300 2019-05-08  Tom Tromey  <tom@tromey.com>
3301
3302         * nto-tdep.c (nto_inferior_data_reg): Change type.
3303         (nto_inferior_data): Update.
3304         (nto_inferior_data_cleanup, nto_new_inferior_data)
3305         (_initialize_nto_tdep): Remove.
3306         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3307
3308 2019-05-08  Tom Tromey  <tom@tromey.com>
3309
3310         * ada-lang.c (struct ada_inferior_data): Add initializers.
3311         (ada_inferior_data): Change type.
3312         (ada_inferior_data_cleanup): Remove.
3313         (get_ada_inferior_data, ada_inferior_exit)
3314         (struct ada_pspace_data): Add initializers, destructor.
3315         (ada_pspace_data_handle): Change type.
3316         (get_ada_pspace_data): Update.
3317         (ada_pspace_data_cleanup): Remove.
3318
3319 2019-05-08  Tom Tromey  <tom@tromey.com>
3320
3321         * coffread.c (struct coff_symfile_info): Add initializers.
3322         (coff_objfile_data_key): Move lower.  Change type.
3323         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3324         Update.
3325         (coff_free_info): Remove.
3326
3327 2019-05-08  Tom Tromey  <tom@tromey.com>
3328
3329         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3330         (fbsd_pspace_data_handle): Move lower.  Change type.
3331         (get_fbsd_pspace_data): Update.
3332         (fbsd_pspace_data_cleanup): Remove.
3333         (_initialize_fbsd_tdep): Update.
3334
3335 2019-05-08  Tom Tromey  <tom@tromey.com>
3336
3337         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3338         (get_ada_tasks_pspace_data): Update.
3339         (ada_tasks_pspace_data_cleanup): Remove.
3340         (_initialize_tasks): Update.
3341         (ada_tasks_inferior_data_handle): Change type.
3342         (get_ada_tasks_inferior_data): Update.
3343         (ada_tasks_inferior_data_cleanup): Remove.
3344         (struct ada_tasks_pspace_data): Add initializers.
3345
3346 2019-05-08  Tom Tromey  <tom@tromey.com>
3347
3348         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3349         * symfile-debug.c (debug_sym_get_probes): Change type.
3350         * stap-probe.c (handle_stap_probe):
3351         (stap_static_probe_ops::get_probes): Change type.
3352         * probe.h (class static_probe_ops) <get_probes>: Change type.
3353         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3354         (parse_probes_in_pspace): Update.
3355         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3356         Update.
3357         (any_static_probe_ops::get_probes): Change type.
3358         * elfread.c (elfread_data): New typedef.
3359         (probe_key): Change type.
3360         (elf_get_probes): Likewise.  Update.
3361         (probe_key_free): Remove.
3362         (_initialize_elfread): Update.
3363         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3364         Change type.
3365         (dtrace_process_dof_probe, dtrace_process_dof)
3366         (dtrace_static_probe_ops::get_probe): Change type.
3367
3368 2019-05-08  Tom Tromey  <tom@tromey.com>
3369
3370         * xcoffread.c (struct xcoff_symfile_info): Rename from
3371         coff_symfile_info.  Add initializers.
3372         (xcoff_objfile_data_key): Move lower.  Change type.
3373         (XCOFF_DATA): Rewrite.
3374         (xcoff_free_info): Remove.
3375         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3376         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3377         (xcoff_initial_scan): Update.
3378
3379 2019-05-08  Tom Tromey  <tom@tromey.com>
3380
3381         * solib-svr4.c (struct svr4_info): Add initializers and
3382         destructor.
3383         <probes_table>: Now an htab_up.
3384         (solib_svr4_pspace_data): Change type.
3385         (free_probes_table): Simplify.
3386         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3387         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3388         (probes_table_remove_objfile_probes, register_solib_event_probe)
3389         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3390         (_initialize_svr4_solib): Update.
3391
3392 2019-05-08  Tom Tromey  <tom@tromey.com>
3393
3394         * remote.c (remote_pspace_data): Change type.
3395         (remote_pspace_data_cleanup): Remove.
3396         (get_remote_exec_file, set_pspace_remote_exec_file)
3397         (_initialize_remote): Update.
3398
3399 2019-05-08  Tom Tromey  <tom@tromey.com>
3400
3401         * breakpoint.c (breakpoint_objfile_key): Change type.
3402         (get_breakpoint_objfile_data): Update.
3403         (free_breakpoint_objfile_data): Remove.
3404         (_initialize_breakpoint): Update.
3405
3406 2019-05-08  Tom Tromey  <tom@tromey.com>
3407
3408         * linux-tdep.c (struct linux_info): Add initializers.
3409         (linux_inferior_data): Move.  Change type.
3410         (invalidate_linux_cache_inf): Update.
3411         (linux_inferior_data_cleanup): Remove.
3412         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3413
3414 2019-05-08  Tom Tromey  <tom@tromey.com>
3415
3416         * auxv.c (auxv_inferior_data): Move.  Change type.
3417         (auxv_inferior_data_cleanup): Remove.
3418         (invalidate_auxv_cache_inf): Rewrite.
3419         (get_auxv_inferior_data, _initialize_auxv): Update.
3420
3421 2019-05-08  Tom Tromey  <tom@tromey.com>
3422
3423         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3424         (symfile_debug_objfile_data_key): Change type.
3425         (symfile_debug_installed, debug_qf_has_symbols)
3426         (debug_qf_find_last_source_symtab)
3427         (debug_qf_forget_cached_source_info)
3428         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3429         (debug_qf_print_stats, debug_qf_dump)
3430         (debug_qf_expand_symtabs_for_function)
3431         (debug_qf_expand_all_symtabs)
3432         (debug_qf_expand_symtabs_with_fullname)
3433         (debug_qf_map_matching_symbols)
3434         (debug_qf_expand_symtabs_matching)
3435         (debug_qf_find_pc_sect_compunit_symtab)
3436         (debug_qf_map_symbol_filenames)
3437         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3438         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3439         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3440         (debug_sym_read_linetable, debug_sym_relocate): Update.
3441         (symfile_debug_free_objfile): Remove.
3442         (install_symfile_debug_logging, _initialize_symfile_debug):
3443         Update.
3444
3445 2019-05-08  Tom Tromey  <tom@tromey.com>
3446
3447         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3448         allocate_on_obstack.
3449         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3450         (get_dwarf2_per_objfile): Update.
3451         (set_dwarf2_per_objfile): Remove.
3452         (dwarf2_has_info, dwarf2_get_section_info): Update.
3453         (dwarf2_free_objfile): Remove.
3454         (_initialize_dwarf2_read): Update.
3455
3456 2019-05-08  Tom Tromey  <tom@tromey.com>
3457
3458         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3459         initializers.
3460         <unsupported_script_warning_printed,
3461         script_not_found_warning_printed>: Now bool.
3462         (auto_load_pspace_data): Change type.
3463         (~auto_load_pspace_info): Rename from
3464         auto_load_pspace_data_cleanup.
3465         (get_auto_load_pspace_data, init_loaded_scripts_info)
3466         (clear_section_scripts, maybe_print_unsupported_script_warning)
3467         (maybe_print_script_not_found_warning, _initialize_auto_load):
3468         Update.
3469
3470 2019-05-08  Tom Tromey  <tom@tromey.com>
3471
3472         * objfiles.c (objfile_pspace_info): Add destructor and
3473         initializers.
3474         (objfiles_pspace_data): Change type.
3475         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3476         (get_objfile_pspace_data): Update.
3477         (objfiles_bfd_data): Change type.
3478         (get_objfile_bfd_data): Update.
3479         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3480
3481 2019-05-08  Tom Tromey  <tom@tromey.com>
3482
3483         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3484         Change type.
3485         (get_catch_syscall_inferior_data): Update.
3486         (catch_syscall_inferior_data_cleanup): Remove.
3487         (_initialize_break_catch_syscall): Update.
3488
3489 2019-05-08  Tom Tromey  <tom@tromey.com>
3490
3491         * inflow.c (struct terminal_info): Add destructor and
3492         initializers.
3493         (inflow_inferior_data): Change type.
3494         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3495         (get_inflow_inferior_data, inflow_inferior_exit)
3496         (swap_terminal_info, _initialize_inflow): Update.
3497
3498 2019-05-08  Tom Tromey  <tom@tromey.com>
3499
3500         * target-dcache.c (target_dcache_cleanup): Remove.
3501         (target_dcache_aspace_key): Change type.
3502         (target_dcache_init_p, target_dcache_invalidate)
3503         (target_dcache_get, target_dcache_get_or_init)
3504         (_initialize_target_dcache): Update.
3505         * dcache.h (struct dcache_deleter): New.
3506
3507 2019-05-08  Tom Tromey  <tom@tromey.com>
3508
3509         * symtab.c (struct symbol_cache): Add destructor and
3510         initializers.
3511         (symbol_cache_key): Move.  Change type.
3512         (make_symbol_cache, free_symbol_cache): Remove.
3513         (get_symbol_cache): Update.
3514         (symbol_cache_cleanup): Remove.
3515         (ALL_PSPACES, symbol_cache_flush)
3516         (maintenance_print_symbol_cache)
3517         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3518         Update.
3519
3520 2019-05-08  Tom Tromey  <tom@tromey.com>
3521
3522         * symtab.c (struct main_info): Add destructor and initializers.
3523         (main_progspace_key): Move.  Change type.
3524         (get_main_info): Update.
3525         (main_info_cleanup): Remove.
3526         (_initialize_symtab): Update.
3527
3528 2019-05-08  Tom Tromey  <tom@tromey.com>
3529
3530         * registry.h (DECLARE_REGISTRY): Define the _key class.
3531
3532 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3533
3534         * NEWS: Merge two 'New commands' sections.
3535
3536 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3537
3538         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3539         parameter and use Ada language definition instead.
3540         (ada_val_print_ptr): Remove unused language parameter.
3541         (ada_val_print_num): Remove language parameter and use Ada language
3542         definition instead.
3543         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3544         parameter.
3545         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3546         parameter and use Ada language definition instead.
3547         (ada_val_print_1): Update all ada_val_print_xxx calls.
3548         Remove language parameter.
3549         (ada_val_print): Update ada_val_print_1 call.
3550
3551 2019-05-08  Tom Tromey  <tromey@adacore.com>
3552
3553         * remote.c (remote_hw_watchpoint_limit)
3554         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3555         Now static.
3556
3557 2019-05-08  Tom Tromey  <tromey@adacore.com>
3558
3559         * maint.c (_initialize_maint_cmds): Move initialization code to
3560         remote.c.
3561         (watchdog, show_watchdog): Move to remote.c.
3562         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3563         "watchdog" static.
3564         (_initialize_remote): Move initialization code from maint.c.
3565         * defs.h (watchdog): Don't declare.
3566
3567 2019-05-08  Tom Tromey  <tromey@adacore.com>
3568
3569         * tui/tui-interp.c: Include main.h.
3570         * interps.c: Include main.h.
3571         * main.h (interpreter_p): Declare.
3572         * defs.h (interpreter_p): Don't declare.
3573
3574 2019-05-08  Tom Tromey  <tromey@adacore.com>
3575
3576         * dwarf2loc.c: Include dwarf2read.h.
3577         * defs.h (read_unsigned_leb128): Don't declare.
3578         * dwarf2read.h (read_unsigned_leb128): Declare.
3579
3580 2019-05-08  Tom Tromey  <tromey@adacore.com>
3581
3582         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3583         method.
3584
3585 2019-05-08  Tom Tromey  <tromey@adacore.com>
3586
3587         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3588         when no wrap column is set.
3589
3590 2019-05-08  Tom Tromey  <tromey@adacore.com>
3591
3592         * c-lang.c (c_get_string): Handle non-C-style arrays.
3593
3594 2019-05-08  Tom Tromey  <tromey@adacore.com>
3595
3596         * typeprint.c (print_offset_data::update): Print the bit offset,
3597         not the number of bits remaining.
3598
3599 2019-05-08  Tom Tromey  <tromey@adacore.com>
3600
3601         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3602         padding at end of comment.
3603
3604 2019-05-08  Tom Tromey  <tromey@adacore.com>
3605
3606         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3607         Compare main types.
3608
3609 2019-05-06  Tom Tromey  <tom@tromey.com>
3610
3611         * common/scoped_mmap.c: Include common-defs.h.
3612         * common/scoped_mmap.h: Don't include config.h.
3613
3614 2019-05-04  Tom Tromey  <tom@tromey.com>
3615
3616         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3617         (struct aarch64_call_info): Add initializers.
3618         <si>: Now a std::vector.
3619         (pass_on_stack, aarch64_push_dummy_call): Update.
3620
3621 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3622             Tom Tromey  <tom@tromey.com>
3623
3624         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3625         (ppc_threads): Now a std::vector.  Now static.
3626         (hwdebug_find_thread_points_by_tid)
3627         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3628         Update.
3629
3630 2019-05-04  Tom Tromey  <tom@tromey.com>
3631
3632         * arc-tdep.c (arc_tdesc_init): Return bool.
3633
3634 2019-05-04  Tom Tromey  <tom@tromey.com>
3635
3636         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3637         Use gdb_assert_not_reached.
3638
3639 2019-05-04  Tom Tromey  <tom@tromey.com>
3640
3641         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3642         "false".
3643
3644 2019-05-04  Tom Tromey  <tom@tromey.com>
3645
3646         * arc-tdep.c (arc_tdesc_init): Use bool.
3647
3648 2019-05-04  Tom Tromey  <tom@tromey.com>
3649
3650         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3651
3652 2019-05-04  Tom Tromey  <tom@tromey.com>
3653
3654         * cli/cli-cmds.c (valid_command_p): Return bool.
3655
3656 2019-05-04  Tom Tromey  <tom@tromey.com>
3657
3658         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3659         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3660
3661 2019-05-04  Raul Tambre  <raul@tambre.ee>
3662
3663         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3664         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3665         operator for comparison.
3666
3667 2019-05-04  Tom Tromey  <tom@tromey.com>
3668
3669         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3670         (lookup_partial_symbol, print_partial_symbols)
3671         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3672         (psymbol_compare): Update.
3673         (add_psymbol_to_bcache): Clear the entire psymbol.
3674         (maintenance_check_psymtabs): Update.
3675         * psympriv.h (struct partial_symbol): Don't derive from
3676         general_symbol_info.
3677         <obj_section, unrelocated_address, address,
3678         set_unrelocated_address>: Update.
3679         <ginfo>: New member.
3680         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3681         (debug_names::write_psymbols): Update.
3682
3683 2019-05-04  Tom de Vries  <tdevries@suse.de>
3684
3685         * contrib/cc-with-tweaks.sh: Support -n arg.
3686
3687 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3688
3689         * corelow.c (core_target::detach): Ensure frame cache and
3690         register caches are cleared.
3691         inferior.c (exit_inferior_1): Likewise.
3692
3693 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3694             Tom Tromey  <tom@tromey.com>
3695
3696         * dictionary.c (collate_pending_symbols_by_language): Remove
3697         "struct" from foreach.
3698         * symtab.c (lookup_global_symbol_from_objfile)
3699         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3700         foreach.
3701         * ser-tcp.c (net_open): Remove "struct" from foreach.
3702         * objfiles.c (objfile_relocate, objfile_rebase)
3703         (objfile_has_symbols): Remove "struct" from foreach.
3704         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3705         from foreach.
3706         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3707         foreach.
3708         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3709         "struct" from foreach.
3710         * ada-lang.c (create_excep_cond_exprs)
3711         (ada_exception_catchpoint_cond_string): Remove "struct" from
3712         foreach.
3713
3714 2019-05-03  Tom Tromey  <tromey@adacore.com>
3715
3716         * ada-exp.y (convert_char_literal): Check suffix of each
3717         enumerator.
3718
3719 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3720
3721         PR ada/21406:
3722         * ada-exp.y (yywrap): Don't define.
3723         * ada-lex.l (%option): Add noyywrap
3724         (yywrap): Remove.
3725
3726 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3727
3728         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3729         _WIN32_WINNT to the XP level, unless already defined to a higher
3730         level.
3731
3732         * unittests/parse-connection-spec-selftests.c:
3733         * ser-tcp.c:
3734         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3735         override.
3736
3737         * symfile.c (find_separate_debug_file): Remove colon from the
3738         drive spec of DOS/Windows file names of the target, so that the
3739         file name produced from DEBUGDIR and the target's directory will
3740         be valid on DOS/Windows systems.
3741
3742 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3743
3744         * rust-lang.c (val_print_struct): Handle printing structures
3745         containing strings.
3746
3747 2019-05-02  Tom Tromey  <tromey@adacore.com>
3748
3749         * valarith.c (_initialize_valarith): Remove.
3750
3751 2019-05-01  Tom Tromey  <tromey@adacore.com>
3752
3753         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3754         bitfields.
3755
3756 2019-05-01  Tom Tromey  <tromey@adacore.com>
3757
3758         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3759         for big-endian copies.
3760
3761 2019-04-30  Ali Tamur  <tamur@google.com>
3762         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3763         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3764         (read_3_bytes): New function.
3765
3766 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3767
3768         * windows-nat.c (main_thread_id): Delete.
3769         (handle_output_debug_string): Replace main_thread_id by
3770         current_event.dwThreadId.
3771         (fake_create_process): Likewise.
3772         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3773         Do not set main_thread_id.
3774         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3775         current_event.dwThreadId.
3776         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3777
3778 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3779
3780         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3781         Use current_event.dwThreadId instead of main_thread_id.
3782
3783 2019-04-30  Tom Tromey  <tromey@adacore.com>
3784
3785         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3786         (create_excep_cond_exprs): Iterate over program spaces.
3787         (ada_exception_catchpoint_cond_string): Examine all minimal
3788         symbols for exception types.
3789
3790 2019-04-30  Tom Tromey  <tromey@adacore.com>
3791
3792         PR c++/24470:
3793         * dwarf2read.c (process_structure_scope): Handle case where type
3794         has template parameters but no symbol was created.
3795
3796 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3797             Chris January  <chris.january@arm.com>
3798
3799         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3800         qualifier.
3801         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3802
3803 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3804
3805         * f-typeprint.c (f_print_type): Update rules for printing
3806         whitespace.
3807         (f_type_print_varspec_suffix): Likewise.
3808
3809 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3810             Chris January  <chris.january@arm.com>
3811
3812         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3813         function arguments.
3814
3815 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3816
3817         * f-lang.c (build_fortran_types): Change name of void type to
3818         lower case.
3819         * f-typeprint.c (f_type_print_base): Print the name of the void
3820         type, rather than a fixed string.
3821         * f-valprint.c (f_decorations): Use lower case void string.
3822
3823 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3824             Chris January  <chris.january@arm.com>
3825
3826         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3827         types for Fortran.
3828
3829 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3830             Chris January  <chris.january@arm.com>
3831             David Lecomber  <david.lecomber@arm.com>
3832
3833         * f-exp.y (BINOP_INTRINSIC): New token.
3834         (exp): New parser rule handling BINOP_INTRINSIC.
3835         (f77_keywords): Add new builtin procedures.
3836         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3837         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3838         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3839         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3840         (print_unop_subexp_f): New function.
3841         (print_binop_subexp_f): New function.
3842         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3843         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3844         (dump_subexp_body_f): Likewise.
3845         (operator_check_f): Likewise.
3846         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3847         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3848
3849 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3850
3851         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3852         UNOP_KIND.
3853         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3854         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3855         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3856         (operator_length_f): New fuction.
3857         (print_subexp_f): New function.
3858         (op_name_f): New function.
3859         (dump_subexp_body_f): New function.
3860         (operator_check_f): New function.
3861         (exp_descriptor_f): Replace standard expression handling functions
3862         with new functions.
3863         * gdb/fortran-operator.def: New file.
3864         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3865         * gdb/std-operator.def: Remove UNOP_KIND.
3866
3867 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3868
3869         * std-operator.def: Remove unbalanced, stray double quote
3870         character.
3871
3872 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3873             Chris January  <chris.january@arm.com>
3874             Daniel Everett  <daniel.everett@arm.com>
3875             Nick Forrington  <nick.forrington@arm.com>
3876             Richard Bunt  <richard.bunt@arm.com>
3877
3878         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3879         of depth when printing anonymous structs or unions.
3880         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3881         Don't print either the top-level value, or the children if the
3882         max-depth is exceeded.
3883         (ppscm_print_children): When printing the key of a map, allow one
3884         extra level of depth.
3885         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3886         print either the top-level value, or the children if the max-depth
3887         is exceeded.
3888         (print_children): When printing the key of a map, allow one extra
3889         level of depth.
3890         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3891         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3892         (user_print_options): Initialise max_depth field.
3893         (val_print_scalar_or_string_type_p): New function.
3894         (val_print): Check to see if the max depth has been reached.
3895         (val_print_check_max_depth): Define new function.
3896         (show_print_max_depth): New function.
3897         (_initialize_valprint): Add 'print max-depth' option.
3898         * valprint.h (struct value_print_options) <max_depth>: New field.
3899         (val_print_check_max_depth): Declare new function.
3900         * NEWS: Document new feature.
3901
3902 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3903
3904         * ada-lang.c (ada_language_defn): Initialise new field.
3905         * c-lang.c (c_is_string_type_p): New function.
3906         (c_language_defn): Initialise new field.
3907         (cplus_language_defn): Initialise new field.
3908         (asm_language_defn): Initialise new field.
3909         (minimal_language_defn): Initialise new field.
3910         * c-lang.h (c_is_string_type_p): Declare new function.
3911         * d-lang.c (d_language_defn): Initialise new field.
3912         * f-lang.c (f_is_string_type_p): New function.
3913         (f_language_defn): Initialise new field.
3914         * go-lang.c (go_is_string_type_p): New function.
3915         (go_language_defn): Initialise new field.
3916         * language.c (default_is_string_type_p): New function.
3917         (unknown_language_defn): Initialise new field.
3918         (auto_language_defn): Initialise new field.
3919         * language.h (struct language_defn) <la_is_string_type_p>: New
3920         member variable.
3921         (default_is_string_type_p): Declare new function.
3922         * m2-lang.c (m2_language_defn): Initialise new field.
3923         * objc-lang.c (objc_language_defn): Initialise new field.
3924         * opencl-lang.c (opencl_language_defn): Initialise new field.
3925         * p-lang.c (pascal_is_string_type_p): New function.
3926         (pascal_language_defn): Initialise new field.
3927         * rust-lang.c (rust_is_string_type_p): New function.
3928         (rust_language_defn): Initialise new field.
3929
3930 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3931
3932         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3933         New field.
3934         * ada-lang.c (ada_language_defn): Initialise new field.
3935         * c-lang.c (c_language_defn): Likewise.
3936         (cplus_language_defn): Likewise.
3937         (asm_language_defn): Likewise.
3938         (minimal_language_defn): Likewise.
3939         * d-lang.c (d_language_defn): Likewise.
3940         * f-lang.c (f_language_defn): Likewise.
3941         * go-lang.c (go_language_defn): Likewise.
3942         * language.c (unknown_language_defn): Likewise.
3943         (auto_language_defn): Likewise.
3944         * m2-lang.c (m2_language_defn): Likewise.
3945         * objc-lang.c (objc_language_defn): Likewise.
3946         * opencl-lang.c (opencl_language_defn): Likewise.
3947         * p-lang.c (pascal_language_defn): Likewise.
3948         * rust-lang.c (rust_language_defn): Likewise.
3949
3950 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3951
3952         * ada-lang.c (ada_is_character_type): Change return type to bool.
3953         (ada_is_string_type): Likewise.
3954         * ada-lang.h (ada_is_character_type): Update declaration
3955         (ada_is_string_type): Likewise.
3956
3957 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3958
3959         Support style in 'frame|thread apply'
3960
3961         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3962         * record.c (record_start, record_stop): Update callers of
3963         execute_command_to_string with false.
3964         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3965         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3966         methods.
3967         (class string_file): New constructor with term_out parameter.
3968         Override methods term_out and can_emit_style_escape.  New member
3969         term_out.
3970         (class stdio_file): Override can_emit_style_escape.
3971         (class tee_file): Override term_out and can_emit_style_escape.
3972         * utils.h (can_emit_style_escape): Remove.
3973         * utils.c (can_emit_style_escape): Likewise.
3974         Update all callers of can_emit_style_escape (SOMESTREAM) to
3975         SOMESTREAM->can_emit_style_escape.
3976         * source-cache.c (source_cache::get_source_lines): Likewise.
3977         * stack.c (frame_apply_command_count): Call execute_command_to_string
3978         passing the term_out characteristic of the current gdb_stdout.
3979         * thread.c (thr_try_catch_cmd): Likewise.
3980         * top.c (execute_command_to_string): pass term_out parameter
3981         to construct the string_file for the command output.
3982         * ui-file.c (term_cli_styling): New function (most code moved
3983         from utils.c can_emit_style_escape).
3984         (string_file::string_file, string_file::can_emit_style_escape,
3985         stdio_file::can_emit_style_escape, tee_file::term_out,
3986         tee_file::can_emit_style_escape): New functions.
3987
3988 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3989
3990         * NEWS: Mention the new set|show may-call-functions.
3991         * infcall.c (may_call_functions_p): New variable.
3992         (show_may_call_functions_p): New function.
3993         (call_function_by_hand_dummy): Throws an error if not
3994         may-call-functions.
3995         (_initialize_infcall): Call add_setshow_boolean_cmd for
3996         may-call-functions.
3997
3998 2019-04-25  Keith Seitz  <keiths@redhat.com>
3999
4000         PR c++/24367
4001         * cp-support.c (inspect_type): Don't attempt substitutions
4002         of symbol with the same name.
4003
4004 2019-04-25  Tom Tromey  <tromey@adacore.com>
4005
4006         PR gdb/24475:
4007         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4008         static.
4009
4010 2019-04-25  Tom Tromey  <tromey@adacore.com>
4011
4012         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4013         rvalue reference.
4014         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4015         (gdb_xml_parser::parse): Use std::move.
4016         * python/python-internal.h (gdbpy_convert_exception): Take a const
4017         reference.
4018         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4019         std::move.
4020         * python/py-utils.c (gdbpy_convert_exception): Take a const
4021         reference.
4022         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4023         Use std::move.
4024         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4025         Use std::move.
4026         * mi/mi-main.c (mi_print_exception): Take a const reference.
4027         * main.c (handle_command_errors): Take a const reference.
4028         * linespec.c (parse_linespec): Use std::move.
4029         * infcall.c (run_inferior_call): Use std::move.
4030         (call_function_by_hand_dummy): Use std::move.
4031         * exec.c (try_open_exec_file): Use std::move.
4032         * exceptions.h (exception_print, exception_fprintf)
4033         (exception_print_same): Update.
4034         * exceptions.c (print_exception, exception_print)
4035         (exception_fprintf, exception_print_same): Change parameters to
4036         const reference.
4037         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4038         * common/new-op.c: Use std::move.
4039         * common/common-exceptions.h (struct gdb_exception): Add move
4040         constructor.
4041         (struct gdb_exception_error, struct gdb_exception_quit, struct
4042         gdb_quit_bad_alloc): Change constructor to move constructor.
4043         (throw_exception): Change parameter to rvalue reference.
4044         * common/common-exceptions.c (throw_exception): Take rvalue
4045         reference.
4046         * cli/cli-interp.c (safe_execute_command): Use std::move.
4047         * breakpoint.c (insert_bp_location, location_to_sals): Use
4048         std::move.
4049
4050 2019-04-25  Tom Tromey  <tromey@adacore.com>
4051
4052         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4053         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4054         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4055         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4056         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4057         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4058         guile/scm-value.c: Use unpack.
4059         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4060         gdbscm_gdb_exception.
4061         (gdbscm_throw_gdb_exception): Likewise.
4062         (struct gdbscm_gdb_exception): New.
4063         (unpack): New function.
4064         (gdbscm_wrap): Use unpack.
4065
4066 2019-04-25  Tom Tromey  <tromey@adacore.com>
4067
4068         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4069         (gdb_rl_callback_handler): Use std::move.
4070         * common/common-exceptions.h (struct gdb_exception): Add move
4071         assignment operator.
4072         (throw_exception_sjlj): Change "exception" to const reference.
4073         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4074         (throw_exception_sjlj): Change "exception" to const reference.
4075
4076 2019-04-25  Tom Tromey  <tromey@adacore.com>
4077
4078         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4079         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4080         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4081         Update.
4082         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4083         Update.
4084         * mi/mi-interp.c (mi_interp::exec): Update.
4085         * linespec.c (parse_linespec): Update.
4086         * infcall.c (run_inferior_call): Update.
4087         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4088         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4089         (gdbscm_lookup_global_symbol): Update.
4090         * guile/scm-param.c (gdbscm_parameter_value): Update.
4091         * guile/scm-frame.c (gdbscm_frame_read_register)
4092         (gdbscm_frame_read_var): Update.
4093         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4094         * exec.c (try_open_exec_file): Update.
4095         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4096         (gdb_rl_callback_handler): Update.
4097         * common/common-exceptions.h (exception_none): Don't declare.
4098         * common/common-exceptions.c (exception_none): Don't define.
4099         (struct catcher) <exception>: Update.
4100         * cli/cli-interp.c (safe_execute_command): Update.
4101         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4102
4103 2019-04-25  Ali Tamur  <tamur@google.com>
4104
4105         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4106         (read_attribute_value): Likewise.
4107         (dwarf2_read_addr_index): Update comment.
4108         (read_str_index): Add DW_FORM_strx.
4109         (dwarf2_string_attr): Likewise.
4110         (dwarf2_const_value_attr): Likewise.
4111         (dump_die_shallow): Likewise.
4112         (dwarf2_fetch_constant_bytes): Likewise.
4113         (skip_form_bytes): Likewise.
4114         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4115
4116 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4117
4118         PR corefiles/11608
4119         PR corefiles/18187
4120         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4121         OFFSET.  Verify if current mapping contains an ELF header.
4122         (linux_find_memory_regions_full): Adjust call to
4123         dump_mapping_p.
4124
4125 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4126             Kang Li <kanglictf@gmail.com>
4127
4128         PR gdb/21600
4129
4130         * dwarf2-frame.c (read_initial_length): Be consistent about using
4131         unsigned representation of length.
4132         (decode_frame_entry_1): Likewise.  Check for wraparound of
4133         end pointer as well as buffer overflow.
4134
4135 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4136
4137         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4138         "vq".
4139
4140 2019-04-24  Tom Tromey  <tromey@adacore.com>
4141
4142         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4143
4144 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4145
4146         * s12z-tdep.c (s12z_unwind_pc): Delete.
4147         (s12z_unwind_sp): Delete.
4148         (s12z_gdbarch_init): Don't register deleted functions with
4149         gdbarch.
4150
4151 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4152
4153         * rl78-tdep.c (rl78_unwind_sp): Delete.
4154         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4155
4156 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4157
4158         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4159         (xstormy16_unwind_pc): Delete.
4160         (xstormy16_dummy_id): Delete.
4161         (xstormy16_gdbarch_init): Don't register deleted functions with
4162         gdbarch.
4163
4164 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4165
4166         * vax-tdep.c (vax_unwind_pc): Delete.
4167         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4168
4169 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4170
4171         * v850-tdep.c (v850_unwind_sp): Delete.
4172         (v850_unwind_pc): Delete.
4173         (v850_dummy_id): Delete.
4174         (v850_gdbarch_init): Don't register deleted functions with
4175         gdbarch.
4176
4177 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4178
4179         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4180         (tilegx_unwind_pc): Delete.
4181         (tilegx_unwind_dummy_id): Delete.
4182         (tilegx_gdbarch_init): Don't register deleted functions with
4183         gdbarch.
4184
4185 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4186
4187         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4188         (tic6x_dummy_id): Delete.
4189         (tic6x_gdbarch_init): Don't register deleted functions with
4190         gdbarch.
4191
4192 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4193
4194         * sparc-tdep.c (sparc_unwind_pc): Delete.
4195         (sparc32_gdbarch_init): Don't register deleted function with
4196         gdbarch.
4197
4198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4199
4200         * sh-tdep.c (sh_unwind_sp): Delete.
4201         (sh_unwind_pc): Delete.
4202         (sh_dummy_id): Delete.
4203         (sh_gdbarch_init): Don't register deleted functions with
4204         gdbarch.
4205
4206 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4207
4208         * score-tdep.c (score_unwind_sp): Delete.
4209         (score_unwind_pc): Delete.
4210         (score_dummy_id): Delete.
4211         (score_gdbarch_init): Don't register deleted functions with
4212         gdbarch.
4213
4214 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4215
4216         * rx-tdep.c (rx_unwind_pc): Delete.
4217         (rx_unwind_sp): Delete.
4218         (rx_dummy_id): Delete.
4219         (rx_gdbarch_init): Don't register deleted functions with
4220         gdbarch.  Update comment.
4221
4222 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4223
4224         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4225         (rs6000_dummy_id): Delete.
4226         (rs6000_gdbarch_init): Don't register deleted functions with
4227         gdbarch.
4228
4229 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4230
4231         * or1k-tdep.c (or1k_dummy_id): Delete.
4232         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4233
4234 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4235
4236         * nios2-tdep.c (nios2_dummy_id): Delete.
4237         (nios2_unwind_sp): Delete.
4238         (nios2_gdbarch_init): Don't register deleted functions with
4239         gdbarch.
4240
4241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4242
4243         * nds32-tdep.c (nds32_dummy_id): Delete.
4244         (nds32_unwind_pc): Delete.
4245         (nds32_unwind_sp): Delete.
4246         (nds32_gdbarch_init): Don't register deleted functions with
4247         gdbarch.
4248
4249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4250
4251         * msp430-tdep.c (msp430_unwind_pc): Delete.
4252         (msp430_unwind_sp): Delete.
4253         (msp430_dummy_id): Delete.
4254         (msp430_gdbarch_init): Don't register deleted functions with
4255         gdbarch.
4256
4257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4258
4259         * moxie-tdep.c (moxie_unwind_sp): Delete.
4260         (moxie_unwind_pc): Delete.
4261         (moxie_dummy_id): Delete.
4262         (moxie_gdbarch_init): Don't register deleted functions with
4263         gdbarch.
4264
4265 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4266
4267         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4268         (mn10300_unwind_pc): Delete.
4269         (mn10300_unwind_sp): Delete.
4270         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4271         mn10300_unwind_sp.
4272         (mn10300_frame_unwind_init): Don't register deleted functions with
4273         gdbarch.
4274
4275 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4276
4277         * mep-tdep.c (mep_unwind_pc): Delete.
4278         (mep_unwind_sp): Delete.
4279         (mep_dummy_id): Delete.
4280         (mep_gdbarch_init): Don't register deleted functions with
4281         gdbarch.
4282
4283 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4284
4285         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4286         (m68hc11_unwind_sp): Delete.
4287         (m68hc11_gdbarch_init): Don't register deleted functions with
4288         gdbarch.
4289
4290 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4291
4292         * m32r-tdep.c (m32r_unwind_sp): Delete.
4293         (m32r_unwind_pc): Delete.
4294         (m32r_dummy_id): Delete.
4295         (m32r_gdbarch_init): Don't register deleted functions with
4296         gdbarch.
4297
4298 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4299
4300         * m32c-tdep.c (m32c_unwind_pc): Delete.
4301         (m32c_unwind_sp): Delete.
4302         (m32c_dummy_id): Delete.
4303         (m32c_gdbarch_init): Don't register deleted functions with
4304         gdbarch.
4305
4306 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4307
4308         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4309         (lm32_unwind_pc): Delete.
4310         (lm32_dummy_id): Delete.
4311         (lm32_gdbarch_init): Don't register deleted functions with
4312         gdbarch.
4313
4314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4315
4316         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4317         (iq2000_unwind_pc): Delete.
4318         (iq2000_dummy_id): Delete.
4319         (iq2000_gdbarch_init): Don't register deleted functions with
4320         gdbarch.
4321
4322 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4323
4324         * nds32-tdep.c (nds32_type_align): Delete.
4325         (nds32_push_dummy_call): Use type_align instead.
4326
4327 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4328
4329         * arm-tdep.c (arm_type_align): Only handle vector override case.
4330         (arm_push_dummy_call): Use type_align.
4331         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4332
4333 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4334
4335         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4336         case.
4337         (pass_on_stack): Use type_align.
4338         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4339         function.
4340
4341 2019-04-23  Tom Tromey  <tromey@adacore.com>
4342
4343         * dwarf2read.c (line_header::file_name_at): Remove unused
4344         overload.
4345
4346 2019-04-23  Tom de Vries  <tdevries@suse.de>
4347
4348         PR gdb/24438
4349         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4350         invocation.
4351
4352
4353 2019-03-27  Ali Tamur  <tamur@google.com>
4354
4355         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4356         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4357         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4358         (dwarf_expr_context::get_addr_index): Likewise
4359         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4360         (symbol_needs_eval_context::get_addr_index): Likewise
4361         (disassemble_dwarf_expression): Add DW_OP_addrx
4362         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4363         (read_cutu_die_from_dwo): Update comment
4364         (skip_one_die): Add DW_FORM_addrx
4365         (read_attribute_value): Likewise
4366         (var_decode_location): Add DW_OP_addrx
4367         (dwarf2_const_value_attr): Add DW_FORM_addrx
4368         (dump_die_shallow): Likewise
4369         (dwarf2_fetch_constant_bytes): Likewise
4370         (decode_locdesc): Add DW_OP_addrx
4371         (skip_form_bytes): Add DW_FORM_addrx
4372
4373 2019-04-22  Ali Tamur  <tamur@google.com>
4374
4375         * MAINTAINERS (Write After Approval): Add self.
4376
4377 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4378
4379         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4380         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4381         (open_symbol_file_object): Likewise.
4382         (svr4_default_sos): Add info parameter.
4383         (svr4_read_so_list): Likewise.
4384         (svr4_current_sos_direct): Adjust functions calls to pass down
4385         info.
4386         (svr4_current_sos_1): Add info parameter.
4387         (svr4_current_sos): Call get_svr4_info, pass info down to
4388         svr4_current_sos_1.
4389         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4390         get_svr4_info.
4391         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4392         get_svr4_info.
4393         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4394         to get_svr4_info.
4395         (probes_table_remove_objfile_probes): Likewise.
4396         (register_solib_event_probe): Add info parameter.
4397         (solist_update_incremental): Pass info parameter down to
4398         svr4_read_so_list.
4399         (disable_probes_interface): Add info parameter.
4400         (svr4_handle_solib_event): Pass current_program_space to
4401         get_svr4_info.  Adjust disable_probes_interface cleanup.
4402         (svr4_create_probe_breakpoints): Add info parameter, pass it
4403         down to register_solib_event_probe.
4404         (svr4_create_solib_event_breakpoints): Add info parameter,
4405         pass it down to svr4_create_probe_breakpoints.
4406         (enable_break): Pass info down to
4407         svr4_create_solib_event_breakpoints.
4408         (svr4_solib_create_inferior_hook): Pass current_program_space to
4409         get_svr4_info.
4410         (svr4_clear_solib): Likewise.
4411
4412 2019-04-22  Pedro Alves  <palves@redhat.com>
4413
4414         * solib-svr4.c (svr4_free_objfile_observer): New.
4415         (probe_and_action::objfile): New field.
4416         (probes_table_htab_remove_objfile_probes)
4417         (probes_table_remove_objfile_probes): New functions.
4418         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4419         in the new probe_and_action.  Don't store the probe in 'lookup'.
4420         (svr4_create_probe_breakpoints): Pass objfile to
4421         register_solib_event_probe.
4422         (_initialize_svr4_solib): Register a free_objfile observer.
4423
4424 2019-04-19  Tom Tromey  <tom@tromey.com>
4425
4426         * common/queue.h: Remove.
4427
4428 2019-04-19  Tom Tromey  <tom@tromey.com>
4429
4430         * event-loop.c: Don't include "common/queue.h".
4431
4432 2019-04-19  Tom Tromey  <tom@tromey.com>
4433
4434         * remote.c (remote_target): Use delete.
4435         * remote-notif.h: Include <list>, not "common/queue.h".
4436         (notif_client_p): Remove typedef.
4437         (remote_notif_state): Add constructor, destructor, initializer.
4438         <notif_queue>: Now a std::list.
4439         (remote_notif_state_xfree): Don't declare.
4440         * remote-notif.c (remote_notif_process, handle_notification)
4441         (remote_notif_state_allocate): Update.
4442         (~remote_notif_state): Rename from remote_notif_state_xfree.
4443
4444 2019-04-19  Tom Tromey  <tom@tromey.com>
4445
4446         * symfile.c (reread_symbols): Update.
4447         * objfiles.c (objfile_register_static_link)
4448         (objfile_lookup_static_link): Update
4449         (~objfile) Don't delete static_links.
4450         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4451
4452 2019-04-19  Tom Tromey  <tom@tromey.com>
4453
4454         * type-stack.h (struct type_stack) <insert>: Constify string.
4455         * type-stack.c (type_stack::insert): Constify string.
4456         * gdbtypes.h (lookup_template_type): Update.
4457         (address_space_name_to_int): Update.
4458         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4459         const.
4460         (lookup_template_type): Make name const.
4461         * c-exp.y: Update rules.
4462         (lex_one_token, classify_name, classify_inner_name)
4463         (c_print_token): Update.
4464         * p-exp.y: Update rules.
4465         (yylex): Update.
4466         * f-exp.y: Update rules.
4467         (yylex): Update.
4468         * d-exp.y: Update rules.
4469         (lex_one_token, classify_name, classify_inner_name): Update.
4470         * parse.c (write_dollar_variable, copy_name): Return std::string.
4471         * parser-defs.h (copy_name): Change return type.
4472         * m2-exp.y: Update rules.
4473         (yylex): Update.
4474         * go-exp.y (lex_one_token): Update.
4475         Update rules.
4476         (classify_unsafe_function, classify_packaged_name)
4477         (classify_name, yylex): Update.
4478
4479 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4480
4481         * configure.ac: add --enable-source-highlight switch.
4482         * configure: Regenerate.
4483         * top.c (print_gdb_version): plumb --enable-source-highlight
4484         status to "show configuration".
4485
4486 2019-04-19  Tom Tromey  <tromey@adacore.com>
4487
4488         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4489         Check ADA_TYPE_P.
4490         (empty_record, ada_template_to_fixed_record_type_1)
4491         (template_to_static_fixed_type)
4492         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4493         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4494         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4495         macros.
4496
4497 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4498
4499         PR symtab/24423:
4500         * source.c (print_source_lines_base): Advance "iter" when a
4501         control character is seen.
4502
4503 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4504
4505         * inferior.h (struct infcall_suspend_state_deleter):
4506         Catch exception in destructor to avoid crash.
4507
4508 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4509
4510         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4511         close to the add_com "shell".
4512
4513 2019-04-18  Tom Tromey  <tromey@adacore.com>
4514
4515         * process-stratum-target.h (class process_stratum_target)
4516         <stratum>: Add "final".
4517
4518 2019-04-17  Tom Tromey  <tromey@adacore.com>
4519
4520         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4521         against nullptr before use.
4522
4523 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4524
4525         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4526
4527 2019-04-17  Jim Wilson  <jimw@sifive.com>
4528             Andrew Burgess  <andrew.burgess@embecosm.com>
4529
4530         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4531         code read might fail, assume 4-byte breakpoint in that case.
4532
4533 2019-04-15  Leszek Swirski  <leszeks@google.com>
4534
4535         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4536         rather than a hand-rolled POD check when checking for forced MEMORY
4537         classification.
4538
4539 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4540
4541         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4542         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4543         function.
4544         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4545         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4546         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4547         declaration.
4548
4549 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4550
4551         * aarch64-linux-nat.c
4552         (aarch64_linux_nat_target::thread_architecture): Add override.
4553         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4554         each VQ.
4555
4556 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4557
4558         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4559
4560 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4561
4562         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4563         target types of size 96-bits, add some additional comments, and
4564         check that the builtin type we found was the correct size.
4565
4566 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4567
4568         * utils.c (prompt_for_continue): Don't restore the styling at the
4569         end, as applied_style has the wrong value.  This fixes styling in
4570         long lists of file names that are interrupted by the "Continue?"
4571         prompt.
4572
4573 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4574
4575         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4576         * c-lang.c (c_language_defn): Likewise.
4577         (cplus_language_defn): Likewise.
4578         (asm_language_defn): Likewise.
4579         (minimal_language_defn): Likewise.
4580         * d-lang.c (d_language_defn): Likewise.
4581         * f-lang.c (f_language_defn): Likewise.
4582         * go-lang.c (go_language_defn): Likewise.
4583         * language.c (unknown_language_defn): Likewise.
4584         (auto_language_defn): Likewise.
4585         * language.h (struct language_defn): Remove la_magic field.
4586         (LANG_MAGIC): Delete.
4587         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4588         * objc-lang.c (objc_language_defn): Likewise.
4589         * opencl-lang.c (opencl_language_defn): Likewise.
4590         * p-lang.c (pascal_language_defn): Likewise.
4591         * rust-lang.c (rust_language_defn): Likewise.
4592
4593 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4594
4595         * riscv-tdep.c (riscv_type_align): New function.
4596         (riscv_type_alignment): Delete.
4597         (riscv_arg_location): Use 'type_align'.
4598         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4599
4600 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4601
4602         * gdbtypes.c (type_align): A struct with no non-static fields also
4603         has alignment of 1.
4604
4605 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4606
4607         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4608         component to 0.
4609         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4610         member.
4611         (riscv_struct_info::analyse): New implementation using new
4612         analyse_inner member function.
4613         (riscv_struct_info::field_offset): New member function.
4614         (riscv_struct_info::m_offsets): New member variable.
4615         (riscv_struct_info::analyse_inner): New private member function,
4616         takes the old implementation of riscv_struct_info::analyse but
4617         extended to track field offsets.
4618         (riscv_call_arg_struct): Update the struct folding special cases
4619         to handle cases where empty C++ structs, which are non-zero
4620         length, are found.
4621         (riscv_arg_location): Initialise the length of each location, a
4622         non-zero length now indicates the location is in use.
4623         (riscv_push_dummy_call): Allow for the first location having a
4624         non-zero offset when setting up arguments.
4625         (riscv_return_value): Likewise, but for return values.
4626
4627 2019-04-11  Tom Tromey  <tromey@adacore.com>
4628
4629         * utils.c (internal_vproblem): Make "msg" const.
4630
4631 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4632
4633         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4634         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4635         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4636         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4637
4638 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4639
4640         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4641         function.
4642         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4643         of amd64_collect_native_gregset.
4644         (amd64_linux_nat_target::store_registers): Likewise.
4645
4646 2019-04-10  Tom Tromey  <tom@tromey.com>
4647
4648         * symtab.c (lookup_global_symbol_from_objfile)
4649         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4650         * objfiles.h (class separate_debug_iterator): New.
4651         (class separate_debug_range): New.
4652         (struct objfile) <separate_debug_objfiles>: New method.
4653         (objfile_separate_debug_iterate): Don't declare.
4654         * objfiles.c (separate_debug_iterator::operator++): Rename from
4655         objfile_separate_debug_iterate.
4656         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4657         iterator.
4658         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4659         iterator.
4660
4661 2019-04-10  Tom Tromey  <tom@tromey.com>
4662
4663         * symfile.c (reread_symbols): Remove old comment.
4664         * objfiles.c (free_all_objfiles): Fix a typo.
4665
4666 2019-04-10  Tom Tromey  <tom@tromey.com>
4667
4668         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4669         * minsyms.c (lookup_minimal_symbol): Use foreach.
4670         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4671         (lookup_minimal_symbol_solib_trampoline): Likewise.
4672         * symfile.c (reread_symbols): Use foreach.
4673
4674 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4675             Tom Tromey  <tromey@adacore.com>
4676
4677         PR rust/24414:
4678         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4679         (rust_lex_int_test): Change "value" to be LONGEST.
4680         (rust_lex_tests): Add test for long integer literal.
4681
4682 2019-04-09  Tom Tromey  <tromey@adacore.com>
4683
4684         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4685         to bool.
4686         (extended_remote_target::attach): Update.
4687         (remote_target::remote_notice_new_inferior): Update.
4688         (remote_target::add_current_inferior_and_thread): Update.
4689         * inferior.c (exit_inferior_1): Use "false".
4690         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4691
4692 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4693
4694         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4695         the "start" command.
4696
4697 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4698
4699         * python/py-inferior.c (infpy_thread_from_thread_handle):
4700         Adjust comments to reflect renaming of thread_from_thread_handle
4701         to thread_from_handle.  Adjust keywords.  Fix type error message.
4702         (inferior_object_methods): Add thread_from_handle.  Retain
4703         thread_from_thread_handle, but mark it as deprecated.
4704
4705 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4706
4707         * gdbthread.h (find_thread_by_handle): Revise declaration.
4708         * thread.c (find_thread_by_handle): Likewise.  Adjust
4709         implementation too.
4710         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4711         support for buffer objects as handles.
4712
4713 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4714
4715         * python/py-infthread.c (thpy_thread_handle): New function.
4716         (thread_object_methods): Register thpy_thread_handle.
4717
4718 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4719
4720         * gdbthread.h (thread_to_thread_handle): Declare.
4721         * thread.c (gdbtypes.h): Include.
4722         (thread_to_thread_handle): New function.
4723
4724         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4725         (target_thread_info_to_thread_handle): Declare.
4726         * target.c (target_thread_info_to_thread_handle): New function.
4727         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4728         * target-delegates.c: Regenerate.
4729
4730         * linux-thread-db.c (class thread_db_target): Add method
4731         thread_info_to_thread_handle.
4732         (thread_db_target::thread_info_to_thread_handle): Define.
4733         * remote.c (class remote_target): Add new method
4734         thread_info_to_thread_handle.
4735         (remote_target::thread_info_to_thread_handle): Define.
4736
4737 2019-04-08  Pedro Alves  <palves@redhat.com>
4738
4739         * common/common-exceptions.c (throw_exception): Don't create
4740         named object to throw; throw directly.
4741         (throw_it): Likewise.  Don't initialize gdb_exception::message
4742         here, with new; pass FMT and AP to the ctor instead.
4743         * common/common-exceptions.h: Include <string>.
4744         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4745         const char *, va_list)): New ctor.  Use std::make_shared.
4746         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4747         errors)): Delete.
4748         (gdb_exception_error::gdb_exception_error(enum errors, const char
4749         *, va_list)): New.
4750         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4751         Add assertion.
4752         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4753         errors)): Delete.
4754         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4755         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4756         Add assertion.
4757
4758 2019-04-08  Tom Tromey  <tom@tromey.com>
4759
4760         * valops.c (value_rtti_indirect_type): Replace throw_exception
4761         with throw.
4762         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4763         with throw.
4764         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4765         throw.
4766         * target.c (target_translate_tls_address): Replace throw_exception
4767         with throw.
4768         * stack.c (frame_apply_command_count): Replace throw_exception
4769         with throw.
4770         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4771         throw.
4772         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4773         with throw.
4774         * rs6000-tdep.c (rs6000_frame_cache)
4775         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4776         * remote.c: Replace throw_exception with throw.
4777         * record-full.c (record_full_message, record_full_wait_1)
4778         (record_full_restore): Replace throw_exception with throw.
4779         * record-btrace.c:
4780         (get_thread_current_frame_id, record_btrace_start_replaying)
4781         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4782         (cmd_record_btrace_start): Replace throw_exception with throw.
4783         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4784         throw.
4785         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4786         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4787         * linespec.c:
4788         (find_linespec_symbols): Replace throw_exception with throw.
4789         * infrun.c (displaced_step_prepare, resume): Replace
4790         throw_exception with throw.
4791         * infcmd.c (post_create_inferior): Replace throw_exception with
4792         throw.
4793         * inf-loop.c (inferior_event_handler): Replace throw_exception
4794         with throw.
4795         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4796         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4797         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4798         (get_prev_frame_always, get_frame_pc_if_available)
4799         (get_frame_address_in_block_if_available, get_frame_language):
4800         Replace throw_exception with throw.
4801         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4802         throw_exception with throw.
4803         * eval.c (fetch_subexp_value, evaluate_var_value)
4804         (evaluate_funcall, evaluate_subexp_standard): Replace
4805         throw_exception with throw.
4806         * dwarf2loc.c (call_site_find_chain)
4807         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4808         Replace throw_exception with throw.
4809         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4810         with throw.
4811         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4812         throw.
4813         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4814         * completer.c (complete_line_internal): Replace throw_exception
4815         with throw.
4816         * compile/compile-object-run.c (compile_object_run): Replace
4817         throw_exception with throw.
4818         * cli/cli-script.c (process_next_line): Replace throw_exception
4819         with throw.
4820         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4821         (btrace_enable, btrace_maint_update_pt_packets): Replace
4822         throw_exception with throw.
4823         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4824         throw_exception with throw.
4825         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4826         throw_exception with throw.
4827         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4828         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4829         * aarch64-tdep.c (aarch64_make_prologue_cache)
4830         (aarch64_make_stub_cache): Replace throw_exception with throw.
4831
4832 2019-04-08  Tom Tromey  <tom@tromey.com>
4833
4834         * common/common-exceptions.c (throw_exception): Rename from
4835         throw_exception_cxx.  Remove old copy.  Make argument const.
4836         (throw_it): Create and throw exception objects directly.
4837         * common/common-exceptions.h (throw_exception): Make argument
4838         const.
4839         (struct gdb_exception_error): Add constructor.
4840         (struct gdb_exception_quit): Add constructor.
4841
4842 2019-04-08  Tom Tromey  <tom@tromey.com>
4843
4844         * common/common-exceptions.h (exception_rethrow): Don't declare.
4845         (TRY_SJLJ): Update comment.
4846         (TRY, CATCH, END_CATCH): Remove.
4847         * common/common-exceptions.c (exception_rethrow): Remove.
4848
4849 2019-04-08  Tom Tromey  <tom@tromey.com>
4850
4851         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4852         Remove.
4853         (gdb_exception_error): Rename from
4854         gdb_exception_RETURN_MASK_ERROR.
4855         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4856         (gdb_quit_bad_alloc): Update.
4857         * aarch64-tdep.c: Update.
4858         * ada-lang.c: Update.
4859         * ada-typeprint.c: Update.
4860         * ada-valprint.c: Update.
4861         * amd64-tdep.c: Update.
4862         * arch-utils.c: Update.
4863         * break-catch-throw.c: Update.
4864         * breakpoint.c: Update.
4865         * btrace.c: Update.
4866         * c-varobj.c: Update.
4867         * cli/cli-cmds.c: Update.
4868         * cli/cli-interp.c: Update.
4869         * cli/cli-script.c: Update.
4870         * common/common-exceptions.c: Update.
4871         * common/new-op.c: Update.
4872         * common/selftest.c: Update.
4873         * compile/compile-c-symbols.c: Update.
4874         * compile/compile-cplus-symbols.c: Update.
4875         * compile/compile-object-load.c: Update.
4876         * compile/compile-object-run.c: Update.
4877         * completer.c: Update.
4878         * corelow.c: Update.
4879         * cp-abi.c: Update.
4880         * cp-support.c: Update.
4881         * cp-valprint.c: Update.
4882         * darwin-nat.c: Update.
4883         * disasm-selftests.c: Update.
4884         * dtrace-probe.c: Update.
4885         * dwarf-index-cache.c: Update.
4886         * dwarf-index-write.c: Update.
4887         * dwarf2-frame-tailcall.c: Update.
4888         * dwarf2-frame.c: Update.
4889         * dwarf2loc.c: Update.
4890         * dwarf2read.c: Update.
4891         * eval.c: Update.
4892         * event-loop.c: Update.
4893         * event-top.c: Update.
4894         * exec.c: Update.
4895         * f-valprint.c: Update.
4896         * fbsd-tdep.c: Update.
4897         * frame-unwind.c: Update.
4898         * frame.c: Update.
4899         * gdbtypes.c: Update.
4900         * gnu-v3-abi.c: Update.
4901         * guile/guile-internal.h: Update.
4902         * guile/scm-block.c: Update.
4903         * guile/scm-breakpoint.c: Update.
4904         * guile/scm-cmd.c: Update.
4905         * guile/scm-disasm.c: Update.
4906         * guile/scm-frame.c: Update.
4907         * guile/scm-lazy-string.c: Update.
4908         * guile/scm-math.c: Update.
4909         * guile/scm-param.c: Update.
4910         * guile/scm-ports.c: Update.
4911         * guile/scm-pretty-print.c: Update.
4912         * guile/scm-symbol.c: Update.
4913         * guile/scm-symtab.c: Update.
4914         * guile/scm-type.c: Update.
4915         * guile/scm-value.c: Update.
4916         * i386-linux-tdep.c: Update.
4917         * i386-tdep.c: Update.
4918         * inf-loop.c: Update.
4919         * infcall.c: Update.
4920         * infcmd.c: Update.
4921         * infrun.c: Update.
4922         * jit.c: Update.
4923         * language.c: Update.
4924         * linespec.c: Update.
4925         * linux-fork.c: Update.
4926         * linux-nat.c: Update.
4927         * linux-tdep.c: Update.
4928         * linux-thread-db.c: Update.
4929         * main.c: Update.
4930         * mi/mi-cmd-break.c: Update.
4931         * mi/mi-cmd-stack.c: Update.
4932         * mi/mi-interp.c: Update.
4933         * mi/mi-main.c: Update.
4934         * objc-lang.c: Update.
4935         * p-valprint.c: Update.
4936         * parse.c: Update.
4937         * ppc-linux-tdep.c: Update.
4938         * printcmd.c: Update.
4939         * python/py-arch.c: Update.
4940         * python/py-breakpoint.c: Update.
4941         * python/py-cmd.c: Update.
4942         * python/py-finishbreakpoint.c: Update.
4943         * python/py-frame.c: Update.
4944         * python/py-framefilter.c: Update.
4945         * python/py-gdb-readline.c: Update.
4946         * python/py-inferior.c: Update.
4947         * python/py-infthread.c: Update.
4948         * python/py-lazy-string.c: Update.
4949         * python/py-linetable.c: Update.
4950         * python/py-objfile.c: Update.
4951         * python/py-param.c: Update.
4952         * python/py-prettyprint.c: Update.
4953         * python/py-progspace.c: Update.
4954         * python/py-record-btrace.c: Update.
4955         * python/py-record.c: Update.
4956         * python/py-symbol.c: Update.
4957         * python/py-type.c: Update.
4958         * python/py-unwind.c: Update.
4959         * python/py-utils.c: Update.
4960         * python/py-value.c: Update.
4961         * python/python.c: Update.
4962         * record-btrace.c: Update.
4963         * record-full.c: Update.
4964         * remote-fileio.c: Update.
4965         * remote.c: Update.
4966         * riscv-tdep.c: Update.
4967         * rs6000-aix-tdep.c: Update.
4968         * rs6000-tdep.c: Update.
4969         * rust-exp.y: Update.
4970         * rust-lang.c: Update.
4971         * s390-tdep.c: Update.
4972         * selftest-arch.c: Update.
4973         * solib-dsbt.c: Update.
4974         * solib-frv.c: Update.
4975         * solib-spu.c: Update.
4976         * solib-svr4.c: Update.
4977         * solib.c: Update.
4978         * sparc64-linux-tdep.c: Update.
4979         * stack.c: Update.
4980         * symfile-mem.c: Update.
4981         * symmisc.c: Update.
4982         * target.c: Update.
4983         * thread.c: Update.
4984         * top.c: Update.
4985         * tracefile-tfile.c: Update.
4986         * tui/tui.c: Update.
4987         * typeprint.c: Update.
4988         * unittests/cli-utils-selftests.c: Update.
4989         * unittests/parse-connection-spec-selftests.c: Update.
4990         * valops.c: Update.
4991         * valprint.c: Update.
4992         * value.c: Update.
4993         * varobj.c: Update.
4994         * windows-nat.c: Update.
4995         * x86-linux-nat.c: Update.
4996         * xml-support.c: Update.
4997
4998 2019-04-08  Tom Tromey  <tom@tromey.com>
4999
5000         * xml-support.c: Use C++ exception handling.
5001         * x86-linux-nat.c: Use C++ exception handling.
5002         * windows-nat.c: Use C++ exception handling.
5003         * varobj.c: Use C++ exception handling.
5004         * value.c: Use C++ exception handling.
5005         * valprint.c: Use C++ exception handling.
5006         * valops.c: Use C++ exception handling.
5007         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5008         handling.
5009         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5010         * typeprint.c: Use C++ exception handling.
5011         * tui/tui.c: Use C++ exception handling.
5012         * tracefile-tfile.c: Use C++ exception handling.
5013         * top.c: Use C++ exception handling.
5014         * thread.c: Use C++ exception handling.
5015         * target.c: Use C++ exception handling.
5016         * symmisc.c: Use C++ exception handling.
5017         * symfile-mem.c: Use C++ exception handling.
5018         * stack.c: Use C++ exception handling.
5019         * sparc64-linux-tdep.c: Use C++ exception handling.
5020         * solib.c: Use C++ exception handling.
5021         * solib-svr4.c: Use C++ exception handling.
5022         * solib-spu.c: Use C++ exception handling.
5023         * solib-frv.c: Use C++ exception handling.
5024         * solib-dsbt.c: Use C++ exception handling.
5025         * selftest-arch.c: Use C++ exception handling.
5026         * s390-tdep.c: Use C++ exception handling.
5027         * rust-lang.c: Use C++ exception handling.
5028         * rust-exp.y: Use C++ exception handling.
5029         * rs6000-tdep.c: Use C++ exception handling.
5030         * rs6000-aix-tdep.c: Use C++ exception handling.
5031         * riscv-tdep.c: Use C++ exception handling.
5032         * remote.c: Use C++ exception handling.
5033         * remote-fileio.c: Use C++ exception handling.
5034         * record-full.c: Use C++ exception handling.
5035         * record-btrace.c: Use C++ exception handling.
5036         * python/python.c: Use C++ exception handling.
5037         * python/py-value.c: Use C++ exception handling.
5038         * python/py-utils.c: Use C++ exception handling.
5039         * python/py-unwind.c: Use C++ exception handling.
5040         * python/py-type.c: Use C++ exception handling.
5041         * python/py-symbol.c: Use C++ exception handling.
5042         * python/py-record.c: Use C++ exception handling.
5043         * python/py-record-btrace.c: Use C++ exception handling.
5044         * python/py-progspace.c: Use C++ exception handling.
5045         * python/py-prettyprint.c: Use C++ exception handling.
5046         * python/py-param.c: Use C++ exception handling.
5047         * python/py-objfile.c: Use C++ exception handling.
5048         * python/py-linetable.c: Use C++ exception handling.
5049         * python/py-lazy-string.c: Use C++ exception handling.
5050         * python/py-infthread.c: Use C++ exception handling.
5051         * python/py-inferior.c: Use C++ exception handling.
5052         * python/py-gdb-readline.c: Use C++ exception handling.
5053         * python/py-framefilter.c: Use C++ exception handling.
5054         * python/py-frame.c: Use C++ exception handling.
5055         * python/py-finishbreakpoint.c: Use C++ exception handling.
5056         * python/py-cmd.c: Use C++ exception handling.
5057         * python/py-breakpoint.c: Use C++ exception handling.
5058         * python/py-arch.c: Use C++ exception handling.
5059         * printcmd.c: Use C++ exception handling.
5060         * ppc-linux-tdep.c: Use C++ exception handling.
5061         * parse.c: Use C++ exception handling.
5062         * p-valprint.c: Use C++ exception handling.
5063         * objc-lang.c: Use C++ exception handling.
5064         * mi/mi-main.c: Use C++ exception handling.
5065         * mi/mi-interp.c: Use C++ exception handling.
5066         * mi/mi-cmd-stack.c: Use C++ exception handling.
5067         * mi/mi-cmd-break.c: Use C++ exception handling.
5068         * main.c: Use C++ exception handling.
5069         * linux-thread-db.c: Use C++ exception handling.
5070         * linux-tdep.c: Use C++ exception handling.
5071         * linux-nat.c: Use C++ exception handling.
5072         * linux-fork.c: Use C++ exception handling.
5073         * linespec.c: Use C++ exception handling.
5074         * language.c: Use C++ exception handling.
5075         * jit.c: Use C++ exception handling.
5076         * infrun.c: Use C++ exception handling.
5077         * infcmd.c: Use C++ exception handling.
5078         * infcall.c: Use C++ exception handling.
5079         * inf-loop.c: Use C++ exception handling.
5080         * i386-tdep.c: Use C++ exception handling.
5081         * i386-linux-tdep.c: Use C++ exception handling.
5082         * guile/scm-value.c: Use C++ exception handling.
5083         * guile/scm-type.c: Use C++ exception handling.
5084         * guile/scm-symtab.c: Use C++ exception handling.
5085         * guile/scm-symbol.c: Use C++ exception handling.
5086         * guile/scm-pretty-print.c: Use C++ exception handling.
5087         * guile/scm-ports.c: Use C++ exception handling.
5088         * guile/scm-param.c: Use C++ exception handling.
5089         * guile/scm-math.c: Use C++ exception handling.
5090         * guile/scm-lazy-string.c: Use C++ exception handling.
5091         * guile/scm-frame.c: Use C++ exception handling.
5092         * guile/scm-disasm.c: Use C++ exception handling.
5093         * guile/scm-cmd.c: Use C++ exception handling.
5094         * guile/scm-breakpoint.c: Use C++ exception handling.
5095         * guile/scm-block.c: Use C++ exception handling.
5096         * guile/guile-internal.h: Use C++ exception handling.
5097         * gnu-v3-abi.c: Use C++ exception handling.
5098         * gdbtypes.c: Use C++ exception handling.
5099         * frame.c: Use C++ exception handling.
5100         * frame-unwind.c: Use C++ exception handling.
5101         * fbsd-tdep.c: Use C++ exception handling.
5102         * f-valprint.c: Use C++ exception handling.
5103         * exec.c: Use C++ exception handling.
5104         * event-top.c: Use C++ exception handling.
5105         * event-loop.c: Use C++ exception handling.
5106         * eval.c: Use C++ exception handling.
5107         * dwarf2read.c: Use C++ exception handling.
5108         * dwarf2loc.c: Use C++ exception handling.
5109         * dwarf2-frame.c: Use C++ exception handling.
5110         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5111         * dwarf-index-write.c: Use C++ exception handling.
5112         * dwarf-index-cache.c: Use C++ exception handling.
5113         * dtrace-probe.c: Use C++ exception handling.
5114         * disasm-selftests.c: Use C++ exception handling.
5115         * darwin-nat.c: Use C++ exception handling.
5116         * cp-valprint.c: Use C++ exception handling.
5117         * cp-support.c: Use C++ exception handling.
5118         * cp-abi.c: Use C++ exception handling.
5119         * corelow.c: Use C++ exception handling.
5120         * completer.c: Use C++ exception handling.
5121         * compile/compile-object-run.c: Use C++ exception handling.
5122         * compile/compile-object-load.c: Use C++ exception handling.
5123         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5124         * compile/compile-c-symbols.c: Use C++ exception handling.
5125         * common/selftest.c: Use C++ exception handling.
5126         * common/new-op.c: Use C++ exception handling.
5127         * cli/cli-script.c: Use C++ exception handling.
5128         * cli/cli-interp.c: Use C++ exception handling.
5129         * cli/cli-cmds.c: Use C++ exception handling.
5130         * c-varobj.c: Use C++ exception handling.
5131         * btrace.c: Use C++ exception handling.
5132         * breakpoint.c: Use C++ exception handling.
5133         * break-catch-throw.c: Use C++ exception handling.
5134         * arch-utils.c: Use C++ exception handling.
5135         * amd64-tdep.c: Use C++ exception handling.
5136         * ada-valprint.c: Use C++ exception handling.
5137         * ada-typeprint.c: Use C++ exception handling.
5138         * ada-lang.c: Use C++ exception handling.
5139         * aarch64-tdep.c: Use C++ exception handling.
5140
5141 2019-04-08  Tom Tromey  <tom@tromey.com>
5142
5143         * xml-support.c (gdb_xml_parser::parse): Update.
5144         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5145         * value.c (show_convenience): Update.
5146         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5147         (test_parse_flags_qcs): Update.
5148         * thread.c (thr_try_catch_cmd): Update.
5149         * target.c (target_translate_tls_address): Update.
5150         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5151         (info_frame_command_core, frame_apply_command_count): Update.
5152         * rust-exp.y (rust_lex_exception_test): Update.
5153         * riscv-tdep.c (riscv_print_one_register_info): Update.
5154         * remote.c (remote_target::enable_btrace): Update.
5155         * record-btrace.c (record_btrace_enable_warn): Update.
5156         * python/py-utils.c (gdbpy_convert_exception): Update.
5157         * printcmd.c (do_one_display, print_variable_and_value): Update.
5158         * mi/mi-main.c (mi_print_exception): Update.
5159         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5160         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5161         * linux-nat.c (linux_nat_target::attach): Update.
5162         * linux-fork.c (class scoped_switch_fork_info): Update.
5163         * infrun.c (displaced_step_prepare): Update.
5164         * infcall.c (call_function_by_hand_dummy): Update.
5165         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5166         * gnu-v3-abi.c (print_one_vtable): Update.
5167         * frame.c (get_prev_frame_always): Update.
5168         * f-valprint.c (info_common_command_for_block): Update.
5169         * exec.c (try_open_exec_file): Update.
5170         * exceptions.c (print_exception, exception_print)
5171         (exception_fprintf, exception_print_same): Update.
5172         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5173         * dwarf-index-cache.c (index_cache::store)
5174         (index_cache::lookup_gdb_index): Update.
5175         * darwin-nat.c (maybe_cache_shell): Update.
5176         * cp-valprint.c (cp_print_value_fields): Update.
5177         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5178         (gcc_cplus_symbol_address): Update.
5179         * compile/compile-c-symbols.c (gcc_convert_symbol)
5180         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5181         * common/selftest.c: Update.
5182         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5183         a std::string.
5184         (exception_try_scope_entry, exception_try_scope_exit): Don't
5185         declare.
5186         (struct exception_try_scope): Remove.
5187         (TRY): Don't use exception_try_scope.
5188         (struct gdb_exception): Add constructor, operator=.
5189         <what>: New method.
5190         (struct gdb_exception_RETURN_MASK_ALL)
5191         (struct gdb_exception_RETURN_MASK_ERROR)
5192         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5193         (struct gdb_quit_bad_alloc): Update.
5194         * common/common-exceptions.c (exception_none): Change
5195         initializer.
5196         (struct catcher) <state, exception>: Initialize inline.
5197         <prev>: Remove member.
5198         (current_catcher): Remove.
5199         (catchers): New global.
5200         (exceptions_state_mc_init): Simplify.
5201         (catcher_pop): Remove.
5202         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5203         (try_scope_depth, exception_try_scope_entry)
5204         (exception_try_scope_exit): Remove.
5205         (throw_exception_sjlj): Update.
5206         (exception_messages, exception_messages_size): Remove.
5207         (throw_it): Simplify.
5208         (gdb_exception_sliced_copy): Remove.
5209         (throw_exception_cxx): Update.
5210         * cli/cli-script.c (script_from_file): Update.
5211         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5212         Update.
5213         * ada-valprint.c (ada_val_print): Update.
5214         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5215         (create_excep_cond_exprs): Update.
5216
5217 2019-04-08  Tom Tromey  <tom@tromey.com>
5218
5219         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5220         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5221         (TRY, CATCH, END_CATCH): Remove some definitions.
5222         * common/common-exceptions.c: Don't use GDB_XCPT.
5223         (catcher_list_size): Remove.
5224         (throw_exception, throw_it): Simplify.
5225
5226 2019-04-05  Tom Tromey  <tom@tromey.com>
5227
5228         Revert the header-sorting patch.
5229         * ft32-tdep.c: Revert.
5230         * frv-tdep.c: Revert.
5231         * frv-linux-tdep.c: Revert.
5232         * frame.c: Revert.
5233         * frame-unwind.c: Revert.
5234         * frame-base.c: Revert.
5235         * fork-child.c: Revert.
5236         * findvar.c: Revert.
5237         * findcmd.c: Revert.
5238         * filesystem.c: Revert.
5239         * filename-seen-cache.h: Revert.
5240         * filename-seen-cache.c: Revert.
5241         * fbsd-tdep.c: Revert.
5242         * fbsd-nat.h: Revert.
5243         * fbsd-nat.c: Revert.
5244         * f-valprint.c: Revert.
5245         * f-typeprint.c: Revert.
5246         * f-lang.c: Revert.
5247         * extension.h: Revert.
5248         * extension.c: Revert.
5249         * extension-priv.h: Revert.
5250         * expprint.c: Revert.
5251         * exec.h: Revert.
5252         * exec.c: Revert.
5253         * exceptions.c: Revert.
5254         * event-top.c: Revert.
5255         * event-loop.c: Revert.
5256         * eval.c: Revert.
5257         * elfread.c: Revert.
5258         * dwarf2read.h: Revert.
5259         * dwarf2read.c: Revert.
5260         * dwarf2loc.c: Revert.
5261         * dwarf2expr.h: Revert.
5262         * dwarf2expr.c: Revert.
5263         * dwarf2-frame.c: Revert.
5264         * dwarf2-frame-tailcall.c: Revert.
5265         * dwarf-index-write.h: Revert.
5266         * dwarf-index-write.c: Revert.
5267         * dwarf-index-common.c: Revert.
5268         * dwarf-index-cache.h: Revert.
5269         * dwarf-index-cache.c: Revert.
5270         * dummy-frame.c: Revert.
5271         * dtrace-probe.c: Revert.
5272         * disasm.h: Revert.
5273         * disasm.c: Revert.
5274         * disasm-selftests.c: Revert.
5275         * dictionary.c: Revert.
5276         * dicos-tdep.c: Revert.
5277         * demangle.c: Revert.
5278         * dcache.h: Revert.
5279         * dcache.c: Revert.
5280         * darwin-nat.h: Revert.
5281         * darwin-nat.c: Revert.
5282         * darwin-nat-info.c: Revert.
5283         * d-valprint.c: Revert.
5284         * d-namespace.c: Revert.
5285         * d-lang.c: Revert.
5286         * ctf.c: Revert.
5287         * csky-tdep.c: Revert.
5288         * csky-linux-tdep.c: Revert.
5289         * cris-tdep.c: Revert.
5290         * cris-linux-tdep.c: Revert.
5291         * cp-valprint.c: Revert.
5292         * cp-support.c: Revert.
5293         * cp-namespace.c: Revert.
5294         * cp-abi.c: Revert.
5295         * corelow.c: Revert.
5296         * corefile.c: Revert.
5297         * continuations.c: Revert.
5298         * completer.h: Revert.
5299         * completer.c: Revert.
5300         * complaints.c: Revert.
5301         * coffread.c: Revert.
5302         * coff-pe-read.c: Revert.
5303         * cli-out.h: Revert.
5304         * cli-out.c: Revert.
5305         * charset.c: Revert.
5306         * c-varobj.c: Revert.
5307         * c-valprint.c: Revert.
5308         * c-typeprint.c: Revert.
5309         * c-lang.c: Revert.
5310         * buildsym.c: Revert.
5311         * buildsym-legacy.c: Revert.
5312         * build-id.h: Revert.
5313         * build-id.c: Revert.
5314         * btrace.c: Revert.
5315         * bsd-uthread.c: Revert.
5316         * breakpoint.h: Revert.
5317         * breakpoint.c: Revert.
5318         * break-catch-throw.c: Revert.
5319         * break-catch-syscall.c: Revert.
5320         * break-catch-sig.c: Revert.
5321         * blockframe.c: Revert.
5322         * block.c: Revert.
5323         * bfin-tdep.c: Revert.
5324         * bfin-linux-tdep.c: Revert.
5325         * bfd-target.c: Revert.
5326         * bcache.c: Revert.
5327         * ax-general.c: Revert.
5328         * ax-gdb.h: Revert.
5329         * ax-gdb.c: Revert.
5330         * avr-tdep.c: Revert.
5331         * auxv.c: Revert.
5332         * auto-load.c: Revert.
5333         * arm-wince-tdep.c: Revert.
5334         * arm-tdep.c: Revert.
5335         * arm-symbian-tdep.c: Revert.
5336         * arm-pikeos-tdep.c: Revert.
5337         * arm-obsd-tdep.c: Revert.
5338         * arm-nbsd-tdep.c: Revert.
5339         * arm-nbsd-nat.c: Revert.
5340         * arm-linux-tdep.c: Revert.
5341         * arm-linux-nat.c: Revert.
5342         * arm-fbsd-tdep.c: Revert.
5343         * arm-fbsd-nat.c: Revert.
5344         * arm-bsd-tdep.c: Revert.
5345         * arch-utils.c: Revert.
5346         * arc-tdep.c: Revert.
5347         * arc-newlib-tdep.c: Revert.
5348         * annotate.h: Revert.
5349         * annotate.c: Revert.
5350         * amd64-windows-tdep.c: Revert.
5351         * amd64-windows-nat.c: Revert.
5352         * amd64-tdep.c: Revert.
5353         * amd64-sol2-tdep.c: Revert.
5354         * amd64-obsd-tdep.c: Revert.
5355         * amd64-obsd-nat.c: Revert.
5356         * amd64-nbsd-tdep.c: Revert.
5357         * amd64-nbsd-nat.c: Revert.
5358         * amd64-nat.c: Revert.
5359         * amd64-linux-tdep.c: Revert.
5360         * amd64-linux-nat.c: Revert.
5361         * amd64-fbsd-tdep.c: Revert.
5362         * amd64-fbsd-nat.c: Revert.
5363         * amd64-dicos-tdep.c: Revert.
5364         * amd64-darwin-tdep.c: Revert.
5365         * amd64-bsd-nat.c: Revert.
5366         * alpha-tdep.c: Revert.
5367         * alpha-obsd-tdep.c: Revert.
5368         * alpha-nbsd-tdep.c: Revert.
5369         * alpha-mdebug-tdep.c: Revert.
5370         * alpha-linux-tdep.c: Revert.
5371         * alpha-linux-nat.c: Revert.
5372         * alpha-bsd-tdep.c: Revert.
5373         * alpha-bsd-nat.c: Revert.
5374         * aix-thread.c: Revert.
5375         * agent.c: Revert.
5376         * addrmap.c: Revert.
5377         * ada-varobj.c: Revert.
5378         * ada-valprint.c: Revert.
5379         * ada-typeprint.c: Revert.
5380         * ada-tasks.c: Revert.
5381         * ada-lang.c: Revert.
5382         * aarch64-tdep.c: Revert.
5383         * aarch64-ravenscar-thread.c: Revert.
5384         * aarch64-newlib-tdep.c: Revert.
5385         * aarch64-linux-tdep.c: Revert.
5386         * aarch64-linux-nat.c: Revert.
5387         * aarch64-fbsd-tdep.c: Revert.
5388         * aarch64-fbsd-nat.c: Revert.
5389         * aarch32-linux-nat.c: Revert.
5390
5391 2019-04-05  Tom Tromey  <tom@tromey.com>
5392
5393         * ft32-tdep.c: Sort headers.
5394         * frv-tdep.c: Sort headers.
5395         * frv-linux-tdep.c: Sort headers.
5396         * frame.c: Sort headers.
5397         * frame-unwind.c: Sort headers.
5398         * frame-base.c: Sort headers.
5399         * fork-child.c: Sort headers.
5400         * findvar.c: Sort headers.
5401         * findcmd.c: Sort headers.
5402         * filesystem.c: Sort headers.
5403         * filename-seen-cache.h: Sort headers.
5404         * filename-seen-cache.c: Sort headers.
5405         * fbsd-tdep.c: Sort headers.
5406         * fbsd-nat.h: Sort headers.
5407         * fbsd-nat.c: Sort headers.
5408         * f-valprint.c: Sort headers.
5409         * f-typeprint.c: Sort headers.
5410         * f-lang.c: Sort headers.
5411         * extension.h: Sort headers.
5412         * extension.c: Sort headers.
5413         * extension-priv.h: Sort headers.
5414         * expprint.c: Sort headers.
5415         * exec.h: Sort headers.
5416         * exec.c: Sort headers.
5417         * exceptions.c: Sort headers.
5418         * event-top.c: Sort headers.
5419         * event-loop.c: Sort headers.
5420         * eval.c: Sort headers.
5421         * elfread.c: Sort headers.
5422         * dwarf2read.h: Sort headers.
5423         * dwarf2read.c: Sort headers.
5424         * dwarf2loc.c: Sort headers.
5425         * dwarf2expr.h: Sort headers.
5426         * dwarf2expr.c: Sort headers.
5427         * dwarf2-frame.c: Sort headers.
5428         * dwarf2-frame-tailcall.c: Sort headers.
5429         * dwarf-index-write.h: Sort headers.
5430         * dwarf-index-write.c: Sort headers.
5431         * dwarf-index-common.c: Sort headers.
5432         * dwarf-index-cache.h: Sort headers.
5433         * dwarf-index-cache.c: Sort headers.
5434         * dummy-frame.c: Sort headers.
5435         * dtrace-probe.c: Sort headers.
5436         * disasm.h: Sort headers.
5437         * disasm.c: Sort headers.
5438         * disasm-selftests.c: Sort headers.
5439         * dictionary.c: Sort headers.
5440         * dicos-tdep.c: Sort headers.
5441         * demangle.c: Sort headers.
5442         * dcache.h: Sort headers.
5443         * dcache.c: Sort headers.
5444         * darwin-nat.h: Sort headers.
5445         * darwin-nat.c: Sort headers.
5446         * darwin-nat-info.c: Sort headers.
5447         * d-valprint.c: Sort headers.
5448         * d-namespace.c: Sort headers.
5449         * d-lang.c: Sort headers.
5450         * ctf.c: Sort headers.
5451         * csky-tdep.c: Sort headers.
5452         * csky-linux-tdep.c: Sort headers.
5453         * cris-tdep.c: Sort headers.
5454         * cris-linux-tdep.c: Sort headers.
5455         * cp-valprint.c: Sort headers.
5456         * cp-support.c: Sort headers.
5457         * cp-namespace.c: Sort headers.
5458         * cp-abi.c: Sort headers.
5459         * corelow.c: Sort headers.
5460         * corefile.c: Sort headers.
5461         * continuations.c: Sort headers.
5462         * completer.h: Sort headers.
5463         * completer.c: Sort headers.
5464         * complaints.c: Sort headers.
5465         * coffread.c: Sort headers.
5466         * coff-pe-read.c: Sort headers.
5467         * cli-out.h: Sort headers.
5468         * cli-out.c: Sort headers.
5469         * charset.c: Sort headers.
5470         * c-varobj.c: Sort headers.
5471         * c-valprint.c: Sort headers.
5472         * c-typeprint.c: Sort headers.
5473         * c-lang.c: Sort headers.
5474         * buildsym.c: Sort headers.
5475         * buildsym-legacy.c: Sort headers.
5476         * build-id.h: Sort headers.
5477         * build-id.c: Sort headers.
5478         * btrace.c: Sort headers.
5479         * bsd-uthread.c: Sort headers.
5480         * breakpoint.h: Sort headers.
5481         * breakpoint.c: Sort headers.
5482         * break-catch-throw.c: Sort headers.
5483         * break-catch-syscall.c: Sort headers.
5484         * break-catch-sig.c: Sort headers.
5485         * blockframe.c: Sort headers.
5486         * block.c: Sort headers.
5487         * bfin-tdep.c: Sort headers.
5488         * bfin-linux-tdep.c: Sort headers.
5489         * bfd-target.c: Sort headers.
5490         * bcache.c: Sort headers.
5491         * ax-general.c: Sort headers.
5492         * ax-gdb.h: Sort headers.
5493         * ax-gdb.c: Sort headers.
5494         * avr-tdep.c: Sort headers.
5495         * auxv.c: Sort headers.
5496         * auto-load.c: Sort headers.
5497         * arm-wince-tdep.c: Sort headers.
5498         * arm-tdep.c: Sort headers.
5499         * arm-symbian-tdep.c: Sort headers.
5500         * arm-pikeos-tdep.c: Sort headers.
5501         * arm-obsd-tdep.c: Sort headers.
5502         * arm-nbsd-tdep.c: Sort headers.
5503         * arm-nbsd-nat.c: Sort headers.
5504         * arm-linux-tdep.c: Sort headers.
5505         * arm-linux-nat.c: Sort headers.
5506         * arm-fbsd-tdep.c: Sort headers.
5507         * arm-fbsd-nat.c: Sort headers.
5508         * arm-bsd-tdep.c: Sort headers.
5509         * arch-utils.c: Sort headers.
5510         * arc-tdep.c: Sort headers.
5511         * arc-newlib-tdep.c: Sort headers.
5512         * annotate.h: Sort headers.
5513         * annotate.c: Sort headers.
5514         * amd64-windows-tdep.c: Sort headers.
5515         * amd64-windows-nat.c: Sort headers.
5516         * amd64-tdep.c: Sort headers.
5517         * amd64-sol2-tdep.c: Sort headers.
5518         * amd64-obsd-tdep.c: Sort headers.
5519         * amd64-obsd-nat.c: Sort headers.
5520         * amd64-nbsd-tdep.c: Sort headers.
5521         * amd64-nbsd-nat.c: Sort headers.
5522         * amd64-nat.c: Sort headers.
5523         * amd64-linux-tdep.c: Sort headers.
5524         * amd64-linux-nat.c: Sort headers.
5525         * amd64-fbsd-tdep.c: Sort headers.
5526         * amd64-fbsd-nat.c: Sort headers.
5527         * amd64-dicos-tdep.c: Sort headers.
5528         * amd64-darwin-tdep.c: Sort headers.
5529         * amd64-bsd-nat.c: Sort headers.
5530         * alpha-tdep.c: Sort headers.
5531         * alpha-obsd-tdep.c: Sort headers.
5532         * alpha-nbsd-tdep.c: Sort headers.
5533         * alpha-mdebug-tdep.c: Sort headers.
5534         * alpha-linux-tdep.c: Sort headers.
5535         * alpha-linux-nat.c: Sort headers.
5536         * alpha-bsd-tdep.c: Sort headers.
5537         * alpha-bsd-nat.c: Sort headers.
5538         * aix-thread.c: Sort headers.
5539         * agent.c: Sort headers.
5540         * addrmap.c: Sort headers.
5541         * ada-varobj.c: Sort headers.
5542         * ada-valprint.c: Sort headers.
5543         * ada-typeprint.c: Sort headers.
5544         * ada-tasks.c: Sort headers.
5545         * ada-lang.c: Sort headers.
5546         * aarch64-tdep.c: Sort headers.
5547         * aarch64-ravenscar-thread.c: Sort headers.
5548         * aarch64-newlib-tdep.c: Sort headers.
5549         * aarch64-linux-tdep.c: Sort headers.
5550         * aarch64-linux-nat.c: Sort headers.
5551         * aarch64-fbsd-tdep.c: Sort headers.
5552         * aarch64-fbsd-nat.c: Sort headers.
5553         * aarch32-linux-nat.c: Sort headers.
5554
5555 2019-04-04  Tom Tromey  <tom@tromey.com>
5556
5557         * varobj.c (varobj_create): Update.
5558         * rust-exp.y (struct rust_parser) <update_innermost_block,
5559         lookup_symbol>: New methods.
5560         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5561         Rename.
5562         (rust_parser::rust_lookup_type)
5563         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5564         * printcmd.c (display_command, do_one_display): Update.
5565         * parser-defs.h (struct parser_state) <parser_state>: Add
5566         "tracker" parameter.
5567         (block_tracker): New member.
5568         (class innermost_block_tracker) <innermost_block_tracker>: Add
5569         "types" parameter.
5570         <reset>: Remove method.
5571         (innermost_block): Don't declare.
5572         (null_post_parser): Update.
5573         * parse.c (innermost_block): Remove global.
5574         (write_dollar_variable): Update.
5575         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5576         Remove "tracker_types" parameter.
5577         (parse_expression): Add "tracker" parameter.
5578         (parse_expression_for_completion): Update.
5579         (null_post_parser): Add "tracker" parameter.
5580         * p-exp.y: Update rules.
5581         * m2-exp.y: Update rules.
5582         * language.h (struct language_defn) <la_post_parser>: Add
5583         "tracker" parameter.
5584         * go-exp.y: Update rules.
5585         * f-exp.y: Update rules.
5586         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5587         parameter.
5588         * d-exp.y: Update rules.
5589         * c-exp.y: Update rules.
5590         * breakpoint.c (set_breakpoint_condition): Create an
5591         innermost_block_tracker.
5592         (watch_command_1): Likewise.
5593         * ada-lang.c (resolve): Add "tracker" parameter.
5594         (resolve_subexp): Likewise.
5595         * ada-exp.y (write_var_from_sym): Update.
5596
5597 2019-04-04  Tom Tromey  <tom@tromey.com>
5598
5599         * type-stack.h: New file.
5600         * type-stack.c: New file.
5601         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5602         type-stack.h.
5603         (insert_into_type_stack, insert_type, push_type, push_type_int)
5604         (insert_type_address_space, pop_type, pop_type_int)
5605         (pop_typelist, pop_type_stack, append_type_stack)
5606         (push_type_stack, get_type_stack, push_typelist)
5607         (follow_type_instance_flags, follow_types): Don't declare.
5608         * parse.c (type_stack): Remove global.
5609         (parse_exp_in_context): Update.
5610         (insert_into_type_stack, insert_type, push_type, push_type_int)
5611         (insert_type_address_space, pop_type, pop_type_int)
5612         (pop_typelist, pop_type_stack, append_type_stack)
5613         (push_type_stack, get_type_stack, push_typelist)
5614         (follow_type_instance_flags, follow_types): Remove (moved to
5615         type-stack.c).
5616         * f-exp.y (type_stack): New global.
5617         Update rules.
5618         (push_kind_type, f_parse): Update.
5619         * d-exp.y (type_stack): New global.
5620         Update rules.
5621         (d_parse): Update.
5622         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5623         Update rules.
5624         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5625         (HFILES_NO_SRCDIR): Add type-stack.h.
5626
5627 2019-04-04  Tom Tromey  <tom@tromey.com>
5628
5629         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5630         (rust_parser::convert_ast_to_expression, rust_parse)
5631         (rust_lex_test_completion, rust_lex_tests): Update.
5632         * parser-defs.h (struct expr_completion_state): New.
5633         (struct parser_state) <parser_state>: Add completion parameter.
5634         <mark_struct_expression, mark_completion_tag>: New methods.
5635         <parse_completion, m_completion_state>: New members.
5636         (prefixify_expression, null_post_parser): Update.
5637         (mark_struct_expression, mark_completion_tag): Don't declare.
5638         * parse.c (parse_completion, expout_last_struct)
5639         (expout_tag_completion_type, expout_completion_name): Remove
5640         globals.
5641         (parser_state::mark_struct_expression)
5642         (parser_state::mark_completion_tag): Now methods.
5643         (prefixify_expression): Add last_struct parameter.
5644         (prefixify_subexp): Likewise.
5645         (parse_exp_1): Update.
5646         (parse_exp_in_context): Add cstate parameter.  Update.
5647         (parse_expression_for_completion): Create an
5648         expr_completion_state.
5649         (null_post_parser): Add "completion" parameter.
5650         * p-exp.y: Update rules.
5651         (yylex): Update.
5652         * language.h (struct language_defn) <la_post_parser>: Add
5653         "completing" parameter.
5654         * go-exp.y: Update rules.
5655         (lex_one_token): Update.
5656         * expression.h (parse_completion): Don't declare.
5657         * d-exp.y: Update rules.
5658         (lex_one_token): Update rules.
5659         * c-exp.y: Update rules.
5660         (lex_one_token): Update.
5661         * ada-lang.c (resolve): Add "parse_completion" parameter.
5662         (resolve_subexp): Likewise.
5663         (ada_resolve_function): Likewise.
5664
5665 2019-04-04  Tom Tromey  <tom@tromey.com>
5666
5667         * parser-defs.h (struct parser_state) <start_arglist,
5668         end_arglist>: New methods.
5669         <arglist_len, m_funcall_chain>: New members.
5670         (arglist_len, start_arglist, end_arglist): Don't declare.
5671         * parse.c (arglist_len, funcall_chain): Remove global.
5672         (start_arglist, end_arglist): Remove functions.
5673         (parse_exp_in_context): Update.
5674         * p-exp.y: Update rules.
5675         * m2-exp.y: Update rules.
5676         * go-exp.y: Update rules.
5677         * f-exp.y: Update rules.
5678         * d-exp.y: Update rules.
5679         * c-exp.y: Update rules.
5680
5681 2019-04-04  Tom Tromey  <tom@tromey.com>
5682
5683         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5684         lex_operator, push_back>: New methods.
5685         Update all rules.
5686         (rust_parser::lex_hex, lex_escape): Rename and update.
5687         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5688         (rust_parser::lex_operator): Rename and update.
5689         (rust_parser::lex_number, rustyylex, rustyyerror)
5690         (rust_lex_test_init, rust_lex_test_sequence)
5691         (rust_lex_test_push_back, rust_lex_tests): Update.
5692         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5693         parameter.
5694         <lexptr, prev_lexptr>: New members.
5695         (lexptr, prev_lexptr): Don't declare.
5696         * parse.c (lexptr, prev_lexptr): Remove globals.
5697         (parse_exp_in_context): Update.
5698         * p-exp.y (yylex, yyerror): Update.
5699         * m2-exp.y (parse_number, yylex, yyerror): Update.
5700         * go-exp.y (lex_one_token, yyerror): Update.
5701         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5702         * d-exp.y (lex_one_token, yyerror): Update.
5703         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5704         (lex_one_token, yyerror): Update.
5705         * ada-lex.l (YY_INPUT): Update.
5706         (rewind_to_char): Update.
5707         * ada-exp.y (yyerror): Update.
5708
5709 2019-04-04  Tom Tromey  <tom@tromey.com>
5710
5711         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5712         * parser-defs.h (struct parser_state) <parser_state>: Add new
5713         parameter.
5714         <comma_terminates>: New member.
5715         (comma_terminates): Don't declare global.
5716         * parse.c (comma_terminates): Remove global.
5717         (parse_exp_in_context): Update.
5718         * p-exp.y (yylex): Update.
5719         * m2-exp.y (yylex): Update.
5720         * go-exp.y (lex_one_token): Update.
5721         * f-exp.y (yylex): Update.
5722         * d-exp.y (lex_one_token): Update.
5723         * c-exp.y (lex_one_token): Update.
5724         * ada-lex.l: Update.
5725
5726 2019-04-04  Tom Tromey  <tom@tromey.com>
5727
5728         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5729         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5730         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5731         * parser-defs.h (paren_depth): Don't declare.
5732         * parse.c (paren_depth): Remove global.
5733         (parse_exp_in_context): Update.
5734         * p-exp.y (paren_depth): New global.
5735         (pascal_parse): Initialize it.
5736         * m2-exp.y (paren_depth): New global.
5737         (m2_parse): Initialize it.
5738         * go-exp.y (paren_depth): New global.
5739         (go_parse): Initialize it.
5740         * f-exp.y (paren_depth): New global.
5741         (f_parse): Initialize it.
5742         * d-exp.y (paren_depth): New global.
5743         (d_parse): Initialize it.
5744         * c-exp.y (paren_depth): New global.
5745         (c_parse): Initialize it.
5746         * ada-lex.l (paren_depth): New global.
5747         (lexer_init): Initialize it.
5748
5749 2019-04-04  Tom Tromey  <tom@tromey.com>
5750
5751         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5752         (rust_parser::convert_ast_to_type)
5753         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5754         * parser-defs.h (struct parser_state) <parser_state>: Add
5755         parameters.  Initialize new members.
5756         <expression_context_block, expression_context_pc>: New members.
5757         * parse.c (expression_context_block, expression_context_pc):
5758         Remove globals.
5759         (parse_exp_in_context): Update.
5760         * p-exp.y: Update all rules.
5761         (yylex): Update.
5762         * m2-exp.y: Update all rules.
5763         (yylex): Update.
5764         * go-exp.y (yylex): Update.
5765         * f-exp.y (yylex): Update.
5766         * d-exp.y: Update all rules.
5767         (yylex): Update.
5768         * c-exp.y: Update all rules.
5769         (lex_one_token, classify_name, yylex, c_parse): Update.
5770         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5771
5772 2019-04-04  Tom Tromey  <tom@tromey.com>
5773
5774         * gdbarch.h, gdbarch.c: Rebuild.
5775         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5776         * stap-probe.h:
5777         (struct stap_parse_info): Replace "parser_state" with
5778         "expr_builder".
5779         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5780         (parser_state): New class.
5781         * parse.c (expr_builder): Rename.
5782         (expr_builder::release): Rename.
5783         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5784         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5785         (write_exp_elt_longcst, write_exp_elt_floatcst)
5786         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5787         (write_exp_string_vector, write_exp_bitstring)
5788         (write_exp_msymbol, mark_struct_expression)
5789         (write_dollar_variable)
5790         (insert_type_address_space, increase_expout_size): Replace
5791         "parser_state" with "expr_builder".
5792         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5793         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5794         "parser_state" with "expr_builder".
5795
5796 2019-04-04  Tom Tromey  <tom@tromey.com>
5797
5798         * rust-exp.y: Replace "parse_language" with method call.
5799         * p-exp.y:
5800         (yylex): Replace "parse_language" with method call.
5801         * m2-exp.y:
5802         (yylex): Replace "parse_language" with method call.
5803         * go-exp.y (classify_name): Replace "parse_language" with method
5804         call.
5805         * f-exp.y (yylex): Replace "parse_language" with method call.
5806         * d-exp.y (lex_one_token): Replace "parse_language" with method
5807         call.
5808         * c-exp.y:
5809         (lex_one_token, classify_name, yylex): Replace "parse_language"
5810         with method call.
5811         * ada-exp.y (find_primitive_type, type_char)
5812         (type_system_address): Replace "parse_language" with method call.
5813
5814 2019-04-04  Tom Tromey  <tom@tromey.com>
5815
5816         * rust-exp.y: Replace "parse_gdbarch" with method call.
5817         * parse.c (write_dollar_variable, insert_type_address_space):
5818         Replace "parse_gdbarch" with method call.
5819         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5820         call.
5821         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5822         call.
5823         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5824         "parse_gdbarch" with method call.
5825         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5826         with method call.
5827         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5828         "parse_gdbarch" with method call.
5829         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5830         "parse_gdbarch" with method call.
5831         * c-exp.y (parse_type, parse_number, classify_name): Replace
5832         "parse_gdbarch" with method call.
5833         * ada-lex.l: Replace "parse_gdbarch" with method call.
5834         * ada-exp.y (parse_type, find_primitive_type, type_char)
5835         (type_system_address): Replace "parse_gdbarch" with method call.
5836
5837 2019-04-04  Tom Tromey  <tom@tromey.com>
5838
5839         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5840         * stap-probe.c (stap_parse_argument): Update.
5841         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5842         initial_size parameter.
5843         * rust-exp.y (rust_lex_tests): Update.
5844         * parse.c (parser_state): Update.
5845         (parse_exp_in_context): Update.
5846         * parser-defs.h (struct parser_state) <parser_state>: Remove
5847         "initial_size" parameter.
5848
5849 2019-04-04  Tom Tromey  <tom@tromey.com>
5850
5851         * parser-defs.h (increase_expout_size): Don't declare.
5852         * parse.c (increase_expout_size): Now static.
5853
5854 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5855
5856         * gnu-nat.c (gnu_nat_target::wait): Fix
5857         target_waitstatus_to_string call.
5858
5859 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5860
5861         * eval.c (evaluate_subexp_standard): Handle internal functions
5862         during Fortran function call handling.
5863
5864 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5865
5866         * NEWS: Mention new internal functions.
5867         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5868         (read_base_type): Use dwarf2_init_complex_target_type.
5869         * value.c (creal_internal_fn): New function.
5870         (cimag_internal_fn): New function.
5871         (_initialize_values): Register new internal functions.
5872
5873 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5874
5875         * infrun.c (stop_all_threads): If debug_infrun, always
5876         trace the wait status after wait_one, using
5877         target_waitstatus_to_string and target_pid_to_str.
5878         (handle_inferior_event): Replace various trace of
5879         wait status kind by a single trace.
5880         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5881         wait status kind image by target_waitstatus_to_string.
5882         * target/waitstatus.c (target_waitstatus_to_string): Fix
5883         obsolete comment.
5884
5885 2019-04-01  Tom Tromey  <tromey@adacore.com>
5886
5887         PR symtab/23331:
5888         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5889
5890 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5891             Pedro Alves  <palves@redhat.com>
5892
5893         * top.c (quit_force): Call 'finalize_values'.
5894         * value.c (finalize_values): New function.
5895         * value.h (finalize_values): Declare.
5896
5897 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5898
5899         * NEWS: Announce $_gdb_major and $_gdb_minor.
5900
5901         * top.c (init_gdb_version_vars): New function.
5902         (gdb_init): Call init_gdb_version_vars.
5903
5904 2019-03-29  Tom Tromey  <tromey@adacore.com>
5905
5906         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5907         help text.  Remove dead code.
5908
5909 2019-03-29  Keith Seitz  <keiths@redhat.com>
5910
5911         From Siddhesh Poyarekar:
5912         * f-lang.h (f77_get_upperbound): Return LONGEST.
5913         (f77_get_lowerbound): Likewise.
5914         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5915         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5916         print them.
5917         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5918         plongest to format print it.
5919         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5920         (f77_get_upperbound): Likewise.
5921         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5922         LOWER_BOUND to LONGEST.
5923         (f77_create_arrayprint_offset_tbl): Likewise.
5924
5925 2019-03-29  Keith Seitz  <keiths@redhat.com>
5926
5927         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5928         %s/pulongest for TYPE_LENGTH instead of %d in format
5929         strings.
5930         * ada-typerint.c (ada_print_type): Likewise.
5931         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5932         * compile/compile-c-support.c (generate_register_struct): Likewise.
5933         * gdbtypes.c (recursive_dump_type): Likewise.
5934         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5935         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5936         instead of %d in format strings.
5937         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5938         to std::min to ULONGEST.
5939         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5940         instead of %d in format strings.
5941         * tracepoint.c (info_scope_command): Likewise.
5942         * typeprint.c (print_offset_data::update)
5943         (print_offset_data::finish): Likewise.
5944         * xtensa-tdep.c (xtensa_store_return_value)
5945         (xtensa_push_dummy_call): Likewise.
5946
5947 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5948
5949         * windows-nat.c (display_selector): Fixed format specifications
5950         for 64-bit Cygwin.
5951
5952 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5953
5954         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5955
5956 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5957
5958         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5959         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5960         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5961         (nios2_linux_init_abi): Install it.
5962
5963 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5964
5965         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5966
5967 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5968
5969         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5970
5971 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5972             Tom Tromey  <tromey@adacore.com>
5973
5974         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5975
5976 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5977
5978         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5979         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5980         method to compute the bounds of range types. Also print "[evaluated]"
5981         if the bounds' values come from a dynamic evaluation.
5982
5983 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5984
5985         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5986         whitespace when pretty printing is on.
5987
5988 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5989
5990         * ppc-linux-nat.c: Add include.
5991
5992 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5993
5994         * NEWS: Mention AArch64 Pointer Authentication.
5995
5996 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5997
5998         * arm-linux-nat.c: Add include.
5999
6000 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6001
6002         * source-cache.c (source_cache::get_source_lines): Re-read
6003         fullname after calling open_source_file.
6004
6005 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6006
6007         * NEWS: Mention TLS support for FreeBSD.
6008
6009 2019-03-25  Tom Tromey  <tromey@adacore.com>
6010
6011         * minsyms.c (BUNCH_SIZE): Update comment.
6012         (~minimal_symbol_reader): Remove old comment.
6013         (compact_minimal_symbols): Update comment.
6014         (minimal_symbol_reader::install): Remove old comment.  Update
6015         other comments.
6016
6017 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6018
6019         * s390-linux-nat.c: Add include.
6020
6021 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6022
6023         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6024         Call linux_get_hwcap.
6025         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6026         Likewise.
6027         (aarch64_linux_get_hwcap): Remove function.
6028         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6029         declaration.
6030         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6031         linux_get_hwcap.
6032         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6033         * linux-tdep.c (linux_get_hwcap): Add function.
6034         (linux_get_hwcap2): Likewise.
6035         * linux-tdep.h (linux_get_hwcap): Add declaration.
6036         (linux_get_hwcap2): Likewise.
6037         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6038         (ppc_linux_get_hwcap2): Likewise.
6039         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6040         linux_get_hwcap.
6041         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6042         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6043         (ppc_linux_nat_target::read_description): Likewise.
6044         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6045         * s390-linux-nat.c: Likewise.
6046         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6047
6048 2019-03-24  Tom Tromey  <tom@tromey.com>
6049
6050         * ada-lang.c (standard_lookup): Simplify initialization.
6051         (ada_lookup_symbol_nonlocal): Simplify return.
6052         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6053         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6054         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6055         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6056         initialization.
6057         * solib.c (solib_global_lookup): Simplify.
6058         * symtab.c (null_block_symbol): Remove.
6059         (symbol_cache_lookup): Simplify returns.
6060         (lookup_language_this): Simplify returns.
6061         (lookup_symbol_aux): Simplify return.
6062         (lookup_local_symbol): Simplify returns.
6063         (lookup_global_symbol_from_objfile): Simplify return.
6064         (lookup_symbol_in_objfile_symtabs)
6065         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6066         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6067         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6068         * cp-namespace.c (cp_lookup_bare_symbol)
6069         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6070         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6071         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6072         (cp_lookup_symbol_via_imports): Simplify initialization.
6073         (find_symbol_in_baseclass): Likewise.
6074         * symtab.h (null_block_symbol): Remove.
6075         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6076         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6077         (d_lookup_symbol_module): Likewise.
6078         (find_symbol_in_baseclass): Simplify initialization.
6079
6080 2019-03-24  Tom Tromey  <tom@tromey.com>
6081
6082         * expression.h: Don't include symtab.h.
6083         (struct block): Forward declare.
6084
6085 2019-03-24  Tom Tromey  <tom@tromey.com>
6086
6087         * c-exp.y (typebase): Remove casts.
6088         * gdbtypes.c (lookup_unsigned_typename, )
6089         (lookup_signed_typename): Remove cast.
6090         * eval.c (parse_to_comma_and_eval): Remove cast.
6091         * parse.c (write_dollar_variable): Remove cast.
6092         * block.h (struct block) <superblock>: Now const.
6093         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6094         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6095         (map_block): Make "block" const.
6096         * symfile.h (struct quick_symbol_functions)
6097         <map_matching_symbols>: Constify block argument to "callback".
6098         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6099         const.
6100         (find_pc_sect_compunit_symtab): Make "b" const.
6101         (find_symbol_at_address): Likewise.
6102         (search_symbols): Likewise.
6103         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6104         (dw2_debug_names_lookup_symbol): Likewise.
6105         (dw2_map_matching_symbols): Update.
6106         * p-valprint.c (pascal_val_print): Remove "block".
6107         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6108         (aux_add_nonlocal_symbols): Make "block" const.
6109         (resolve_subexp): Remove cast.
6110         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6111         const.
6112         (iterate_over_file_blocks): Likewise.
6113         * f-exp.y (%union) <bval>: Remove.
6114         * coffread.c (patch_opaque_types): Make "b" const.
6115         * spu-tdep.c (spu_catch_start): Make "block" const.
6116         * c-valprint.c (print_unpacked_pointer): Remove "block".
6117         * symmisc.c (dump_symtab_1): Make "b" const.
6118         (block_depth): Make "block" const.
6119         * d-exp.y (%union) <bval>: Remove.
6120         * cp-support.h (cp_lookup_rtti_type): Update.
6121         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6122         * psymtab.c (psym_lookup_symbol): Make "block" const.
6123         (maintenance_check_psymtabs): Make "b" const.
6124         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6125         (enumerate_locals, enumerate_args): Update.
6126         * python/py-symtab.c (stpy_global_block): Make "block" const.
6127         (stpy_static_block): Likewise.
6128         * inline-frame.c (block_starting_point_at): Make "new_block"
6129         const.
6130         * block.c (find_block_in_blockvector): Make return type const.
6131         (blockvector_for_pc_sect): Make "b" const.
6132         (find_block_in_blockvector): Make "b" const.
6133
6134 2019-03-23  Tom Tromey  <tom@tromey.com>
6135
6136         * varobj.c (varobj_create): Update.
6137         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6138         * printcmd.c (display_command, do_one_display): Don't reset
6139         innermost_block.
6140         * parser-defs.h (enum innermost_block_tracker_type): Move to
6141         expression.h.
6142         (innermost_block): Update comment.
6143         * parse.c (parse_exp_1): Add tracker_types parameter.
6144         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6145         tracker_types parameter.  Reset innermost_block.
6146         (parse_exp_in_context): Remove.
6147         (parse_expression_for_completion): Update.
6148         * objfiles.c (~objfile): Don't reset expression_context_block or
6149         innermost_block.
6150         * expression.h (enum innermost_block_tracker_type): Move from
6151         parser-defs.h.
6152         (parse_exp_1): Add tracker_types parameter.
6153         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6154         reset innermost_block.
6155
6156 2019-03-23  Tom Tromey  <tom@tromey.com>
6157
6158         * objfiles.h: Include bcache.h.
6159
6160 2019-03-23  Tom Tromey  <tom@tromey.com>
6161
6162         * linespec.c (get_current_search_block): Use
6163         scoped_restore_current_language.
6164         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6165
6166 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6167             Jiong Wang  <jiong.wang@arm.com>
6168
6169         * aarch64-linux-tdep.c
6170         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6171         section.
6172         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6173
6174 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6175             Jiong Wang  <jiong.wang@arm.com>
6176
6177         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6178         instructions.
6179         (aarch64_analyze_prologue_test): Add PACIASP test.
6180         (aarch64_prologue_prev_register): Unmask PC value.
6181
6182 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6183             Jiong Wang  <jiong.wang@arm.com>
6184
6185         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6186         (aarch64_dwarf2_prev_register): Unmask PC value.
6187         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6188         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6189         DW_CFA_AARCH64_negate_ra_state.
6190         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6191
6192 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6193             Jiong Wang  <jiong.wang@arm.com>
6194
6195         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6196         registers.
6197         (aarch64_pseudo_register_name): Likewise.
6198         (aarch64_pseudo_register_type): Likewise.
6199         (aarch64_pseudo_register_reggroup_p): Likewise.
6200         (aarch64_gdbarch_init): Add pauth registers.
6201         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6202         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6203         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6204         (struct gdbarch_tdep): Add regnum for ra_state.
6205
6206 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6207             Jiong Wang  <jiong.wang@arm.com>
6208
6209         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6210
6211 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6212             Jiong Wang  <jiong.wang@arm.com>
6213
6214         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6215         function.
6216         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6217         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6218         (aarch64_gdbarch_init): Add puth registers.
6219         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6220         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6221         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6222
6223 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6224             Jiong Wang  <jiong.wang@arm.com>
6225
6226         * aarch64-linux-nat.c
6227         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6228         * aarch64-linux-tdep.c
6229         (aarch64_linux_core_read_description): Likewise.
6230         (aarch64_linux_get_hwcap): New function.
6231         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6232         (aarch64_linux_get_hwcap): New declaration.
6233
6234 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6235             Jiong Wang  <jiong.wang@arm.com>
6236
6237         * aarch64-linux-nat.c
6238         (aarch64_linux_nat_target::read_description): Add pauth param.
6239         * aarch64-linux-tdep.c
6240         (aarch64_linux_core_read_description): Likewise.
6241         * aarch64-tdep.c (struct target_desc): Add in pauth.
6242         (aarch64_read_description): Add pauth param.
6243         (aarch64_gdbarch_init): Likewise.
6244         * aarch64-tdep.h (aarch64_read_description): Likewise.
6245         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6246         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6247         * features/Makefile: Add new files.
6248         * features/aarch64-pauth.c: New file.
6249         * features/aarch64-pauth.xml: New file.
6250
6251 2019-03-20  Tom Tromey  <tromey@adacore.com>
6252
6253         * infrun.c (handle_inferior_event): Rename from
6254         handle_inferior_event_1.  Create a scoped_value_mark.
6255         (handle_inferior_event): Remove.
6256
6257 2019-03-19  Tom Tromey  <tromey@adacore.com>
6258
6259         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6260         * infrun.h (print_stop_event): Add "displays" parameter.
6261         * infrun.c (print_stop_event): Add "displays" parameter.
6262
6263 2019-03-19  Pedro Alves  <palves@redhat.com>
6264
6265         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6266         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6267         to -1.  Fix TABs vs spaces.
6268         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6269         * tui/tui-out.h (tui_ui_out) Add intro comments.
6270         <m_line, m_start_of_line>: In-class initialize, and add describing
6271         comment.
6272
6273 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6274
6275         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6276         variable names.
6277         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6278
6279 2019-03-18  Pedro Alves  <palves@redhat.com>
6280             Eli Zaretskii <eliz@gnu.org>
6281
6282         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6283         m_line and m_start_of_line.
6284
6285 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6286
6287         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6288         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6289         it returns a newline.  This fixes a regression in TU mode, whereby
6290         the next line is output on the same screen line as the user input.
6291
6292 2019-03-18  Tom Tromey  <tromey@adacore.com>
6293
6294         * minsyms.c (minimal_symbol_reader::install): Remove call to
6295         obstack_blank.
6296
6297 2019-03-18  Pedro Alves  <palves@redhat.com>
6298
6299         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6300         New globals.
6301         (apply_style): New, factored out from ...
6302         (apply_ansi_escape): ... this.  Handle reverse video mode.
6303         (tui_set_reverse_mode): New function.
6304         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6305         * tui/tui-winsource.c (tui_show_source_line): Use
6306         tui_set_reverse_mode instead of setting A_STANDOUT.
6307         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6308         New setter methods.
6309
6310 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6311
6312         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6313         Handle tabs.
6314
6315 2019-03-18  Tom Tromey  <tromey@adacore.com>
6316
6317         * ada-lang.c (empty_array): Add "high" parameter.
6318         (ada_evaluate_subexp): Update.
6319
6320 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6321
6322         * unittests/string_view-selftests.c: Define
6323         _initialize_string_view_selftests unconditionally.
6324
6325 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6326
6327         PR gdb/24350
6328         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6329
6330 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6331
6332         PR gdb/24351
6333         * windows-nat.c (display_selector): Fix format specifiers.
6334
6335 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6336
6337         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6338         tui_refill_source_window instead of tui_refresh_win, to update the
6339         current execution line.  This fixes redisplay of the current line
6340         when stepping through the code with "next" or "step".
6341
6342 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6343
6344         * source-cache.c (source_cache::get_source_lines): Call
6345         find_source_lines to initialize s->nlines.  This fixes vertical
6346         scrolling of TUI source window when the DOWN arrow is pressed.
6347
6348 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6349
6350         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6351         linux-thread-db.c (_initialize_thread_db): Likewise.
6352
6353 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6354
6355         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6356         wclrtoeol in tui_show_source_line".  This reverts changes made in
6357         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6358
6359 2019-03-15  Tom Tromey  <tom@tromey.com>
6360
6361         * symtab.h (struct minimal_symbol): Derive from
6362         general_symbol_info.
6363         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6364         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6365         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6366         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6367         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6368         (MSYMBOL_SEARCH_NAME): Update.
6369         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6370         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6371         * minsyms.c (minimal_symbol_reader::record_full): Update.
6372
6373 2019-03-15  Tom Tromey  <tom@tromey.com>
6374
6375         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6376
6377 2019-03-15  Tom Tromey  <tom@tromey.com>
6378
6379         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6380         unique_xmalloc_ptr.
6381         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6382         Update.
6383         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6384         (build_minimal_symbol_hash_tables)
6385         (minimal_symbol_reader::install): Update.
6386
6387 2019-03-15  Tom Tromey  <tom@tromey.com>
6388
6389         * symtab.c (create_demangled_names_hash): Update.
6390         (symbol_set_names): Update.
6391         * objfiles.h (struct objfile_per_bfd_storage)
6392         <demangled_names_hash>: Now an htab_up.
6393         * objfiles.c (objfile_per_bfd_storage): Simplify.
6394
6395 2019-03-15  Tom Tromey  <tom@tromey.com>
6396
6397         * objfiles.h (struct objfile_per_bfd_storage): Declare
6398         destructor.
6399         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6400         New.
6401         (get_objfile_bfd_data): Use new.  Don't initialize
6402         language_of_main.
6403         (free_objfile_per_bfd_storage): Remove.
6404         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6405
6406 2019-03-15  Tom Tromey  <tom@tromey.com>
6407
6408         * symfile.c (reread_symbols): Update.
6409         * objfiles.c (objfile::objfile): Update.
6410         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6411         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6412         comment.
6413         (minimal_symbol_reader::install): Update.
6414         (terminate_minimal_symbol_table): Remove.
6415         * jit.c (jit_object_close_impl): Update.
6416
6417 2019-03-15  Tom Tromey  <tom@tromey.com>
6418
6419         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6420         initializations.
6421
6422 2019-03-15  Tom Tromey  <tom@tromey.com>
6423
6424         * objfiles.h (struct objfile_per_bfd_storage)
6425         <demangled_hash_languages>: Now a bitset.
6426         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6427         (lookup_minimal_symbol): Update.
6428
6429 2019-03-15  Tom Tromey  <tom@tromey.com>
6430
6431         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6432         Don't return the symbol.
6433         * coffread.c (record_minimal_symbol): Use record_full.
6434
6435 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6436
6437         The MS-Windows port of ncurses fails to switch to a color pair if
6438         one or both of the colors are the implicit default colors.  This
6439         change records the default colors when TUI is initialized, and
6440         then specifies them explicitly when a color pair uses the default
6441         colors.  This allows color styling in TUI mode on MS-Windows.
6442
6443         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6444         ncurses_norm_attr.
6445         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6446         colors in ncurses_norm_attr.
6447         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6448         "none", replace it with the default color recorded in
6449         ncurses_norm_attr.
6450
6451 2019-03-14  Tom Tromey  <tromey@adacore.com>
6452
6453         * source-cache.h (class source_cache) <get_source_lines>: Return
6454         std::string.
6455         * source-cache.c (source_cache::extract_lines): Handle case where
6456         first_pos==npos.  Return std::string.
6457         (source_cache::get_source_lines): Update.
6458
6459 2019-03-14  Tom Tromey  <tromey@adacore.com>
6460
6461         * NEWS: Add item for "style sources" commands.
6462         * source-cache.c (source_cache::get_source_lines): Check
6463         source_styling.
6464         * cli/cli-style.c (source_styling): New global.
6465         (_initialize_cli_style): Add "style sources" commands.
6466         (show_style_sources): New function.
6467         * cli/cli-style.h (source_styling): Declare.
6468
6469 2019-03-14  Pedro Alves  <palves@redhat.com>
6470             Tom Tromey  <tromey@adacore.com>
6471
6472         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6473         * tui/tui-winsource.c (tui_refill_source_window): New function,
6474         from...
6475         (tui_horizontal_source_scroll): ... here.  Move some logic.
6476         * cli/cli-style.c (set_style_enabled): Notify new observable.
6477         * tui/tui-hooks.c (tui_redisplay_source): New function.
6478         (tui_attach_detach_observers): Attach or detach
6479         tui_redisplay_source.
6480         * observable.h (source_styling_changed): New observable.
6481         * observable.c: Define source_styling_changed observable.
6482
6483 2019-03-13  Tom Tromey  <tromey@adacore.com>
6484
6485         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6486         (i386_gnu_nat_target::store_registers): Update.
6487         * target-debug.h (target_debug_print_std_string): New macro.
6488         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6489         * windows-tdep.c (display_one_tib): Update.
6490         * tui/tui-stack.c (tui_make_status_line): Update.
6491         * top.c (print_inferior_quit_action): Update.
6492         * thread.c (thr_try_catch_cmd): Update.
6493         (add_thread_with_info): Update.
6494         (thread_target_id_str): Update.
6495         (thr_try_catch_cmd): Update.
6496         (thread_command): Update.
6497         (thread_find_command): Update.
6498         * record-btrace.c (record_btrace_target::info_record)
6499         (record_btrace_resume_thread, record_btrace_target::resume)
6500         (record_btrace_cancel_resume, record_btrace_step_thread)
6501         (record_btrace_target::wait, record_btrace_target::wait)
6502         (record_btrace_target::wait, record_btrace_target::stop): Update.
6503         * progspace.c (print_program_space): Update.
6504         * process-stratum-target.c
6505         (process_stratum_target::thread_address_space): Update.
6506         * linux-fork.c (linux_fork_mourn_inferior)
6507         (detach_checkpoint_command, info_checkpoints_command)
6508         (linux_fork_context): Update.
6509         (linux_fork_detach): Update.
6510         (class scoped_switch_fork_info): Update.
6511         (delete_checkpoint_command): Update.
6512         * infrun.c (follow_fork_inferior): Update.
6513         (follow_fork_inferior): Update.
6514         (proceed_after_vfork_done): Update.
6515         (handle_vfork_child_exec_or_exit): Update.
6516         (follow_exec): Update.
6517         (displaced_step_prepare_throw): Update.
6518         (displaced_step_restore): Update.
6519         (start_step_over): Update.
6520         (resume_1): Update.
6521         (clear_proceed_status_thread): Update.
6522         (proceed): Update.
6523         (print_target_wait_results): Update.
6524         (do_target_wait): Update.
6525         (context_switch): Update.
6526         (stop_all_threads): Update.
6527         (restart_threads): Update.
6528         (finish_step_over): Update.
6529         (handle_signal_stop): Update.
6530         (switch_back_to_stepped_thread): Update.
6531         (keep_going_pass_signal): Update.
6532         (print_exited_reason): Update.
6533         (normal_stop): Update.
6534         * inferior.c (inferior_pid_to_str): Change return type.
6535         (print_selected_inferior): Update.
6536         (add_inferior): Update.
6537         (detach_inferior): Update.
6538         * dummy-frame.c (fprint_dummy_frames): Update.
6539         * dcache.c (dcache_info_1): Update.
6540         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6541         (btrace_fetch, btrace_clear): Update.
6542         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6543         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6544         type.
6545         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6546         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6547         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6548         * gdbarch.c, gdbarch.h: Rebuild.
6549         * gdbarch.sh (core_pid_to_str): Change return type.
6550         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6551         return type.
6552         (windows_nat_target::pid_to_str): Change return type.
6553         (windows_delete_thread): Update.
6554         (windows_nat_target::attach): Update.
6555         (windows_nat_target::files_info): Update.
6556         * target-delegates.c: Rebuild.
6557         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6558         return type.
6559         (sol_thread_target::pid_to_str): Change return type.
6560         * remote.c (class remote_target) <pid_to_str>: Change return
6561         type.
6562         (remote_target::pid_to_str): Change return type.
6563         (extended_remote_target::attach, remote_target::remote_stop_ns)
6564         (remote_target::remote_notif_remove_queued_reply)
6565         (remote_target::push_stop_reply, remote_target::disable_btrace):
6566         Update.
6567         (extended_remote_target::attach): Update.
6568         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6569         type.
6570         (gdbsim_target::pid_to_str): Change return type.
6571         * ravenscar-thread.c (struct ravenscar_thread_target)
6572         <pid_to_str>: Change return type.
6573         (ravenscar_thread_target::pid_to_str): Change return type.
6574         * procfs.c (class procfs_target) <pid_to_str>: Change return
6575         type.
6576         (procfs_target::pid_to_str): Change return type.
6577         (procfs_target::attach): Update.
6578         (procfs_target::detach): Update.
6579         (procfs_target::fetch_registers): Update.
6580         (procfs_target::store_registers): Update.
6581         (procfs_target::wait): Update.
6582         (procfs_target::files_info): Update.
6583         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6584         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6585         return type.
6586         (nto_procfs_target::pid_to_str): Change return type.
6587         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6588         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6589         return type.
6590         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6591         (exit_lwp): Update.
6592         (attach_proc_task_lwp_callback, get_detach_signal)
6593         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6594         (linux_nat_target::resume, wait_lwp, stop_callback)
6595         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6596         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6597         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6598         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6599         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6600         type.
6601         (inf_ptrace_target::attach): Update.
6602         (inf_ptrace_target::files_info): Update.
6603         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6604         type.
6605         (go32_nat_target::pid_to_str): Change return type.
6606         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6607         (gnu_nat_target::wait): Update.
6608         (gnu_nat_target::wait): Update.
6609         (gnu_nat_target::resume): Update.
6610         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6611         (fbsd_nat_target::wait): Update.
6612         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6613         type.
6614         (darwin_nat_target::attach): Update.
6615         * corelow.c (class core_target) <pid_to_str>: Change return type.
6616         (core_target::pid_to_str): Change return type.
6617         * target.c (normal_pid_to_str): Change return type.
6618         (default_pid_to_str): Likewise.
6619         (target_pid_to_str): Change return type.
6620         (target_translate_tls_address): Update.
6621         (target_announce_detach): Update.
6622         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6623         return type.
6624         (bsd_uthread_target::pid_to_str): Change return type.
6625         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6626         type.
6627         (bsd_kvm_target::pid_to_str): Change return type.
6628         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6629         return type.
6630         (aix_thread_target::pid_to_str): Change return type.
6631         * target.h (struct target_ops) <pid_to_str>: Change return type.
6632         (target_pid_to_str, normal_pid_to_str): Likewise.
6633         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6634         type.
6635         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6636         type.
6637         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6638         return type.
6639         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6640         type.
6641         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6642         type.
6643         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6644         return type.
6645
6646 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6647
6648         * NEWS: Mention that the new default MI version is 3.  Mention
6649         changes to the output of commands and events that deal with
6650         multi-location breakpoints.
6651         * breakpoint.c: Include "mi/mi-out.h".
6652         (print_one_breakpoint): Change output syntax if using MI version
6653         >= 3.
6654         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6655         New.
6656         (mi_multi_location_breakpoint_output_fixed): New.
6657         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6658         (mi_cmd_fix_multi_location_breakpoint_output): New.
6659         (mi_multi_location_breakpoint_output_fixed): New.
6660         * mi/mi-cmds.c (mi_cmds): Register command
6661         -fix-multi-location-breakpoint-output.
6662         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6663         interpreter "mi".
6664
6665 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6666
6667         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6668         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6669         instantiate mi_ui_out based on interpreter name.
6670         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6671         * mi/mi-main.c (mi_load_progress): Likewise.
6672
6673 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6674
6675         * NEWS: Combine separate "New targets" sections for 8.3.
6676
6677 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6678
6679         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6680         (ppcfbsd_init_abi): Install gdbarch
6681         "fetch_tls_load_module_address" and "get_thread_local_address"
6682         methods.
6683
6684 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6685
6686         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6687         (riscv_fbsd_init_abi): Install gdbarch
6688         "fetch_tls_load_module_address" and "get_thread_local_address"
6689         methods.
6690
6691 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6692
6693         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6694         (i386fbsd_init_abi): Install gdbarch
6695         "fetch_tls_load_module_address" and "get_thread_local_address"
6696         methods.
6697
6698 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6699
6700         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6701         (amd64fbsd_init_abi): Install gdbarch
6702         "fetch_tls_load_module_address" and "get_thread_local_address"
6703         methods.
6704
6705 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6706
6707         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6708         (struct fbsd_pspace_data): New type.
6709         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6710         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6711         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6712         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6713         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6714
6715 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6716
6717         * gdbtypes.c (lookup_struct_elt): New function.
6718         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6719         * gdbtypes.h (struct struct_elt): New type.
6720         (lookup_struct_elt): New prototype.
6721
6722 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6723
6724         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6725         remove disabled code block.
6726
6727 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6728
6729         * gdbarch.sh (get_thread_local_address): New method.
6730         * gdbarch.h, gdbarch.c: Regenerate.
6731         * target.c (target_translate_tls_address): Use
6732         gdbarch_get_thread_local_address if present instead of
6733         target::get_thread_local_address.
6734
6735 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6736
6737         * target.h (target::get_thread_local_address): Update comment.
6738
6739 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6740
6741         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6742         objfile->separate_debug_objfile_backlink if not NULL.
6743
6744 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6745
6746         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6747         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6748         (amd64bsd_store_inferior_registers): Likewise.
6749         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6750         Enable segment base registers.
6751         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6752         PT_GETFSBASE and PT_GETGSBASE.
6753         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6754         PT_SETGSBASE.
6755         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6756         segment base registers.
6757         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6758
6759 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6760
6761         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6762         Update calls to i386_target_description to add 'segments'
6763         parameter.
6764         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6765         add segment base registers.
6766         * arch/i386.c (i386_create_target_description): Add 'segments'
6767         parameter to enable segment base registers.
6768         * arch/i386.h (i386_create_target_description): Likewise.
6769         * features/i386/32bit-segments.xml: New file.
6770         * features/i386/32bit-segments.c: Generate.
6771         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6772         call to i386_target_description to add 'segments' parameter.
6773         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6774         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6775         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6776         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6777         if feature is present.
6778         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6779         Add 'segments' parameter to call to i386_target_description.
6780         (i386_target_description): Add 'segments' parameter to enable
6781         segment base registers.
6782         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6783         to call to i386_target_description.
6784         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6785         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6786         Define I386_NUM_REGS.
6787         (i386_target_description): Add 'segments' parameter to enable
6788         segment base registers.
6789
6790 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6791
6792         PR/24325
6793         * source-cache.c: #undef open and close, to avoid unresolved
6794         externals during linking.
6795
6796 2019-03-12  Tom Tromey  <tromey@adacore.com>
6797
6798         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6799         const.  Add initializers.
6800         (_initialize_remote): Don't initialize ptid globals.
6801
6802 2019-03-12  Pedro Alves  <palves@redhat.com>
6803
6804         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6805
6806 2019-03-12  Pedro Alves  <palves@redhat.com>
6807
6808         * cp-name-parser.y (main): Remove unused 'len' variable.
6809
6810 2019-03-12  Tom Tromey  <tromey@adacore.com>
6811
6812         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6813         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6814
6815 2019-03-12  Tom Tromey  <tromey@adacore.com>
6816
6817         * linux-nat.c (iterate_over_lwps): Update.
6818         (stop_callback): Remove parameter.
6819         (stop_wait_callback, detach_callback, resume_set_callback)
6820         (select_singlestep_lwp_callback, set_ignore_sigint)
6821         (status_callback, resumed_callback, resume_clear_callback)
6822         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6823         data parameter.
6824         (linux_nat_target::detach, linux_nat_target::resume)
6825         (linux_stop_and_wait_all_lwps, select_event_lwp)
6826         (linux_nat_filter_event, linux_nat_wait_1)
6827         (linux_nat_target::kill, linux_nat_target::stop)
6828         (linux_nat_target::stop): Update.
6829         (linux_nat_resume_callback): Change type.
6830         (resume_stopped_resumed_lwps, count_events_callback)
6831         (select_event_lwp_callback): Likewise.
6832         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6833         * arm-linux-nat.c (struct update_registers_data): Remove.
6834         (update_registers_callback): Change type.
6835         (arm_linux_insert_hw_breakpoint1): Update.
6836         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6837         parameter.
6838         (x86_linux_dr_set_addr): Update.
6839         (x86_linux_dr_set_control): Update.
6840         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6841         (iterate_over_lwps): Use gdb::function_view.
6842         * nat/aarch64-linux-hw-point.c (struct
6843         aarch64_dr_update_callback_param): Remove.
6844         (debug_reg_change_callback): Change type.
6845         (aarch64_notify_debug_reg_change): Update.
6846         * s390-linux-nat.c (s390_refresh_per_info): Update.
6847
6848 2019-03-11  Tom Tromey  <tromey@adacore.com>
6849
6850         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6851         redundant assignment to "this_cu".
6852
6853 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6854
6855         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6856
6857 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6858
6859         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6860         from...
6861         (rank_one_type): ... this.
6862
6863 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6864
6865         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6866         from...
6867         (rank_one_type): ... this.
6868
6869 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6870
6871         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6872         from...
6873         (rank_one_type): ... this.
6874
6875 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6876
6877         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6878         from...
6879         (rank_one_type): ... this.
6880
6881 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6882
6883         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6884         from...
6885         (rank_one_type): ... this.
6886
6887 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6888
6889         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6890         from...
6891         (rank_one_type): ... this.
6892
6893 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6894
6895         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6896         from...
6897         (rank_one_type): ... this.
6898
6899 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6900
6901         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6902         from...
6903         (rank_one_type): ... this.
6904
6905 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6906
6907         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6908         from...
6909         (rank_one_type): ... this.
6910
6911 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6912
6913         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6914         from...
6915         (rank_one_type): ... this.
6916
6917 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6918
6919         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6920         from...
6921         (rank_one_type): ... this.
6922
6923 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6924
6925         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6926         from...
6927         (rank_one_type): ... this.
6928
6929 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6930
6931         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6932         inferior-events' shows the example events.
6933
6934 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6935
6936         Support styling on native MS-Windows console
6937
6938         PR/24315
6939         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6940         on MS-Windows if $TERM is not defined.
6941
6942         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6943
6944         * posix-hdep.c (gdb_console_fputs):
6945         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6946         functions.
6947         * ui-file.h (gdb_console_fputs): Add prototype.
6948
6949         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6950         back to fputs only if the former returns zero.
6951
6952 2019-03-07  Tom Tromey  <tom@tromey.com>
6953
6954         * symmisc.c (print_symbol_bcache_statistics): Update.
6955         (print_objfile_statistics): Update.
6956         * symfile.c (allocate_symtab): Update.
6957         * stabsread.c: Don't include bcache.h.
6958         * psymtab.h (struct psymbol_bcache): Don't declare.
6959         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6960         (psymbol_bcache_init, psymbol_bcache_free)
6961         (psymbol_bcache_get_bcache): Don't declare.
6962         * psymtab.c (struct psymbol_bcache): Remove.
6963         (psymtab_storage::psymtab_storage): Update.
6964         (psymtab_storage::~psymtab_storage): Update.
6965         (psymbol_bcache_init, psymbol_bcache_free)
6966         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6967         (add_psymbol_to_bcache): Update.
6968         (allocate_psymtab): Update.
6969         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6970         macro_cache>: No longer pointers.
6971         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6972         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6973         * macrotab.c (macro_bcache): Update.
6974         * macroexp.c: Don't include bcache.h.
6975         * gdbtypes.c (check_types_worklist): Update.
6976         (types_deeply_equal): Remove TRY/CATCH.  Update.
6977         * elfread.c (elf_symtab_read): Update.
6978         * dwarf2read.c: Don't include bcache.h.
6979         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6980         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6981         (print_bcache_statistics, bcache_memory_used): Don't declare.
6982         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6983         methods.  Rename all data members.
6984         * bcache.c (struct bcache): Move to bcache.h.
6985         (bcache::expand_hash_table): Rename from expand_hash_table.
6986         (bcache): Remove.
6987         (bcache::insert): Rename from bcache_full.
6988         (bcache::compare): Rename from bcache_compare.
6989         (bcache_xmalloc): Remove.
6990         (bcache::~bcache): Rename from bcache_xfree.
6991         (bcache::print_statistics): Rename from print_bcache_statistics.
6992         (bcache::memory_used): Rename from bcache_memory_used.
6993
6994 2019-03-07  Pedro Alves  <palves@redhat.com>
6995
6996         * infrun.c (normal_stop): Also check for
6997         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6998
6999 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7000
7001         * f-lang.c (value_from_host_double): Moved to...
7002         * value.c (value_from_host_double): ...here.
7003         * value.h (value_from_host_double): Declare.
7004         * guile/scm-math.c (vlscm_convert_typed_number): Use
7005         value_from_host_double.
7006         (vlscm_convert_number): Likewise.
7007         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7008         * python/py-value.c (convert_value_from_python): Likewise.
7009
7010 2019-03-06  Tom Tromey  <tom@tromey.com>
7011
7012         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7013
7014 2019-03-06  Tom Tromey  <tom@tromey.com>
7015
7016         * utils.h (free_current_contents): Don't declare.
7017         * utils.c (free_current_contents): Remove.
7018
7019 2019-03-06  Tom Tromey  <tom@tromey.com>
7020
7021         * top.c (quit_force): Update.
7022         * main.c (captured_command_loop): Update.
7023         * common/new-op.c (operator new): Update.
7024         * common/common-exceptions.c (struct catcher)
7025         <save_cleanup_chain>: Remove member.
7026         (exceptions_state_mc_init): Update.
7027         (exception_try_scope_entry): Return nullptr.
7028         (exception_try_scope_exit, exception_rethrow)
7029         (throw_exception_sjlj, throw_exception_cxx): Update.
7030         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7031         (all_cleanups, do_cleanups, discard_cleanups)
7032         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7033         (restore_cleanups, restore_final_cleanups): Don't declare.
7034         (do_final_cleanups): Remove parameter.
7035         * common/cleanups.c (cleanup_chain, make_cleanup)
7036         (make_cleanup_dtor, all_cleanups, do_cleanups)
7037         (discard_my_cleanups, discard_cleanups)
7038         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7039         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7040         (null_cleanup): Remove.
7041         (do_final_cleanups): Remove parameter.
7042
7043 2019-03-06  Tom Tromey  <tom@tromey.com>
7044
7045         * remote.c (remote_target::remote_parse_stop_reply): Use
7046         unique_xmalloc_ptr.
7047
7048 2019-03-06  Tom Tromey  <tom@tromey.com>
7049
7050         * stabsread.c (struct stabs_field_info): Rename from field_info.
7051         <list, fnlist>: Add initializers.
7052         <obstack>: New member.
7053         (read_member_functions, read_struct_fields, read_baseclasses):
7054         Allocate on obstack.  Don't use cleanups.
7055         (read_one_struct_field, read_member_functions, read_struct_fields)
7056         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7057         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7058         (read_struct_type): Update.
7059
7060 2019-03-06  Tom Tromey  <tom@tromey.com>
7061
7062         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7063         * common/filestuff.h (make_cleanup_close): Don't declare.
7064         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7065         Remove.
7066
7067 2019-03-06  Tom Tromey  <tom@tromey.com>
7068
7069         * solib-aix.c: Use make_scope_exit.
7070
7071 2019-03-06  Tom Tromey  <tom@tromey.com>
7072
7073         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7074         Use make_scope_exit.
7075
7076 2019-03-06  Tom Tromey  <tom@tromey.com>
7077
7078         * solib-svr4.c (disable_probes_interface): Remove parameter.
7079         (svr4_handle_solib_event): Use make_scope_exit.
7080
7081 2019-03-06  Tom Tromey  <tom@tromey.com>
7082
7083         * remote.c (struct stop_reply_deleter): Remove.
7084         (stop_reply_up): Update.
7085         (struct stop_reply): Derive from notif_event.  Don't typedef.
7086         <regcache>: Now a std::vector.
7087         (stop_reply_xfree): Remove.
7088         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7089         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7090         (remote_target::discard_pending_stop_replies): Use delete.
7091         (remote_target::remote_parse_stop_reply): Update.
7092         (remote_target::process_stop_reply): Update.
7093         * remote-notif.h (struct notif_event): Add virtual destructor.
7094         Remove "dtr" member.
7095         (struct notif_client) <alloc_event>: Return a unique_ptr.
7096         (notif_event_xfree): Don't declare.
7097         (notif_event_up): New typedef.
7098         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7099         (notif_event_xfree, do_notif_event_xfree): Remove.
7100         (remote_notif_state_xfree): Update.
7101
7102 2019-03-06  Tom Tromey  <tom@tromey.com>
7103
7104         * infrun.c (displaced_step_clear_cleanup): Now a
7105         forward_scope_exit type.
7106         (displaced_step_prepare_throw): Update.
7107         (displaced_step_fixup): Update.
7108
7109 2019-03-06  Tom Tromey  <tom@tromey.com>
7110
7111         * inferior.h (class inferior): Update comment.
7112         * gdbthread.h (class thread_info): Update comment.
7113
7114 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7115             Tom Tromey  <tom@tromey.com>
7116
7117         * stabsread.h (struct stab_section_list): Remove.
7118         (coffstab_build_psymtabs): Update.
7119         * dbxread.c (symbuf_sections): Now a std::vector.
7120         (sect_idx): New global.
7121         (fill_symbuf): Update.
7122         (coffstab_build_psymtabs): Change type of stabsects parameter.
7123         Update.
7124         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7125         std::vector.
7126         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7127         (coff_locate_sections): Update.
7128         (coff_symfile_read): Remove cleanups.  Update.
7129         (init_stringtab): Add storage parameter.
7130         (free_stringtab, free_stringtab_cleanup): Remove.
7131         (init_lineno): Add storage parameter.
7132         (free_linetab, free_linetab_cleanup): Remove.
7133
7134 2019-03-06  Pedro Alves  <palves@redhat.com>
7135
7136         * linux-fork.c (fork_info::clobber_regs): Delete.
7137         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7138         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7139         comment.  Adjust.
7140         (scoped_switch_fork_info::scoped_switch_fork_info)
7141         (checkpoint_command, linux_fork_context): Adjust
7142         fork_save_infrun_state calls.
7143
7144 2019-03-06  Pedro Alves  <palves@redhat.com>
7145
7146         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7147         (inf_has_multiple_threads): Return 'bool' and rewrite using
7148         inferior_info::threads().
7149
7150 2019-03-06  Pedro Alves  <palves@redhat.com>
7151
7152         * linux-fork.c: Include <list>.
7153         (fork_list): Now a std::list instance.
7154         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7155         (forks_exist_p, find_last_fork): Adjust.
7156         (new_fork): Delete.
7157         (one_fork_p): New.
7158         (add_fork): Adjust.
7159         (free_fork): Delete, folded into fork_info::~fork_info().
7160         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7161         Adjust.
7162         (init_fork_list): Delete.
7163         (linux_fork_killall, linux_fork_mourn_inferior)
7164         (linux_fork_detach, info_checkpoints_command): Adjust.
7165         (_initialize_linux_fork): No longer call init_fork_list.
7166
7167 2019-03-06  Pedro Alves  <palves@redhat.com>
7168
7169         * linux-fork.c (new_fork): New, split out of ...
7170         (add_fork): ... this.  Return void.  Move "first fork" special
7171         case from here, to ...
7172         (checkpoint_command): ... here.
7173         * linux-linux.h (add_fork): Return void.
7174
7175 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7176
7177         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7178
7179 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7180             Chris January  <chris.january@arm.com>
7181             David Lecomber  <david.lecomber@arm.com>
7182
7183         * f-exp.y: New token, UNOP_INTRINSIC.
7184         (exp): New pattern using UNOP_INTRINSIC token.
7185         (f77_keywords): Add 'abs' keyword.
7186         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7187         (value_from_host_double): New function.
7188         (evaluate_subexp_f): Support UNOP_ABS.
7189
7190 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7191
7192         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7193         types.
7194
7195 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7196
7197         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7198         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7199         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7200
7201 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7202
7203         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7204
7205 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7206             Chris January  <chris.january@arm.com>
7207
7208         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7209         * f-exp.y: Define 'KIND' token.
7210         (exp): New pattern for KIND expressions.
7211         (ptype): Handle types with a kind extension.
7212         (direct_abs_decl): Extend to spot kind extensions.
7213         (f77_keywords): Add 'kind' to the list.
7214         (push_kind_type): New function.
7215         (convert_to_kind_type): New function.
7216         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7217         * parse.c (operator_length_standard): Likewise.
7218         * parser-defs.h (enum type_pieces): Add tp_kind.
7219         * std-operator.def: Add UNOP_KIND.
7220
7221 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7222
7223         * f-exp.y (f_parse): Set yydebug.
7224
7225 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7226
7227         * f-lang.c (evaluate_subexp_f): New function.
7228         (exp_descriptor_f): New global.
7229         (f_language_defn): Use exp_descriptor_f instead of
7230         exp_descriptor_standard.
7231
7232 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7233
7234         * f-exp.y (struct token): Add comments.
7235         (dot_ops): Remove uppercase versions and the end marker.
7236         (f77_keywords): Likewise.
7237         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7238         entries in the dot_ops array are case insensitive, and use
7239         strncasecmp to compare strings.  Also some whitespace cleanup in
7240         this area.  Similar for the f77_keywords array, except entries in
7241         this list might be case sensitive.
7242
7243 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7244
7245         * f-exp.y (struct f77_boolean_val): Add comments.
7246         (boolean_values): Remove uppercase versions, and end marker.
7247         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7248         and use strncasecmp to achieve case insensitivity.  Additionally,
7249         perform whitespace cleanup around this code.
7250
7251 2019-03-06  Tom Tromey  <tromey@adacore.com>
7252
7253         * remote-sim.c (gdbsim_target_open): Use result of
7254         gdb_argv::release.
7255
7256 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7257         Dirk Schubert  <dirk.schubert@arm.com>
7258         Chris January  <chris.january@arm.com>
7259
7260         * eval.c (evaluate_subexp_standard): Call Fortran argument
7261         wrapping logic.
7262         * f-lang.c (struct value): A value which can be passed into a
7263         Fortran function call.
7264         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7265         where appropriate.
7266         (struct type): Value ready for a Fortran function call.
7267         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7268         is needed.
7269         * f-lang.h (fortran_argument_convert): Declaration.
7270         (fortran_preserve_arg_pointer): Declaration.
7271         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7272
7273 2019-03-05  Tom Tromey  <tromey@adacore.com>
7274
7275         * python/py-prettyprint.c (print_string_repr): Remove #if.
7276         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7277
7278 2019-03-05  Tom Tromey  <tromey@adacore.com>
7279
7280         * target.c (the_dummy_target): Move later.  Change type to
7281         "dummy_target".
7282         (initialize_targets): Don't initialize the_dummy_target.
7283
7284 2019-03-05  Tom Tromey  <tromey@adacore.com>
7285
7286         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7287         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7288
7289 2019-03-05  Tom Tromey  <tromey@adacore.com>
7290
7291         * windows-nat.c (windows_nat_target::attach)
7292         (windows_nat_target::detach): Don't call gdb_flush.
7293         * valprint.c (generic_val_print, val_print, val_print_string):
7294         Don't call gdb_flush.
7295         * utils.c (defaulted_query): Don't call gdb_flush.
7296         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7297         * target.c (target_announce_detach): Don't call gdb_flush.
7298         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7299         * remote.c (extended_remote_target::attach): Don't call
7300         gdb_flush.
7301         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7302         * printcmd.c (do_examine): Don't call gdb_flush.
7303         (info_display_command): Don't call gdb_flush.
7304         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7305         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7306         * memattr.c (info_mem_command): Don't call gdb_flush.
7307         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7308         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7309         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7310         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7311         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7312         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7313         (gnu_nat_target::detach): Don't call gdb_flush.
7314         * f-valprint.c (f_val_print): Don't call gdb_flush.
7315         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7316         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7317         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7318         gdb_flush.
7319         * c-valprint.c (c_val_print): Don't call gdb_flush.
7320         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7321
7322 2019-03-05  Tom Tromey  <tromey@adacore.com>
7323
7324         * varobj.c (update_dynamic_varobj_children): Update.
7325         (install_default_visualizer): Use reset, not release.
7326         * value.c (set_internalvar): Update.
7327         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7328         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7329         ATTRIBUTE_UNUSED_RESULT.
7330
7331 2019-03-05  Tom Tromey  <tromey@adacore.com>
7332
7333         * remote.c (class scoped_remote_fd) <release>: Add
7334         ATTRIBUTE_UNUSED_RESULT.
7335
7336 2019-03-05  Tom Tromey  <tromey@adacore.com>
7337
7338         * macroexp.c (struct macro_buffer) <release>: Add
7339         ATTRIBUTE_UNUSED_RESULT.
7340
7341 2019-03-05  Tom Tromey  <tromey@adacore.com>
7342
7343         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7344         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7345         ATTRIBUTE_UNUSED_RESULT.
7346
7347 2019-03-05  Tom Tromey  <tromey@adacore.com>
7348
7349         * common/scoped_fd.h (class scoped_fd) <release>: Add
7350         ATTRIBUTE_UNUSED_RESULT.
7351
7352 2019-03-05  Tom Tromey  <tromey@adacore.com>
7353
7354         * parser-defs.h (struct parser_state) <release>: Add
7355         ATTRIBUTE_UNUSED_RESULT.
7356
7357 2019-03-05  Tom Tromey  <tromey@adacore.com>
7358
7359         * utils.h (class gdb_argv) <release>: Add
7360         ATTRIBUTE_UNUSED_RESULT.
7361         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7362
7363 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7364
7365         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7366         for-loop range, to avoid compiler warnings.
7367
7368         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7369         avoid compiler warnings about unused variables.
7370
7371         * NEWS: Mention end of support for native debugging on MS-Windows
7372         before XP.
7373
7374         PR gdb/24292
7375         * common/netstuff.c:
7376         * gdbserver/gdbreplay.c
7377         * gdbserver/remote-utils.c:
7378         * ser-tcp.c:
7379         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7380         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7381         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7382         'getaddrinfo' and 'freeaddrinfo' were not available before
7383         Windows XP, and mingw.org's MinGW headers by default define
7384         _WIN32_WINNT to 0x500.
7385
7386 2019-03-01  Gary Benson <gbenson@redhat.com>
7387
7388         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7389
7390 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7391             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7392
7393         PR gdb/8527
7394         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7395         set_sigint_trap, clear_sigint_trap.
7396
7397 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7398
7399         * target.c (target_detach): Clear the regcache and the
7400         frame cache.
7401
7402 2019-02-27  Pedro Alves  <palves@redhat.com>
7403
7404         * utils.c (set_screen_size): When we cap the height/width sizes,
7405         tweak the corresponding command variable to show "unlimited":
7406
7407 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7408             Pedro Alves  <palves@redhat.com>
7409
7410         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7411         before calling rl_set_screen_size.
7412
7413 2019-02-27  Tom Tromey  <tromey@adacore.com>
7414
7415         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7416         define.
7417         * python/py-value.c: Remove Python 2.4 workaround.
7418         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7419         workaround.
7420         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7421         Python 2.4 workaround.
7422         * python/python-internal.h: Remove Python 2.4 comment.
7423         (Py_ssize_t): Don't define.
7424         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7425         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7426         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7427         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7428         * python/python.c (do_start_initialization): Remove Python 2.4
7429         workaround.
7430         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7431         (print_children): Remove Python 2.4 workaround.
7432         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7433         workaround.
7434         (CHARBUFFERPROC_NAME): Remove.
7435         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7436         Python 2.4 workaround.
7437
7438 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7439
7440         * NEWS: Note minimum Python version.
7441
7442 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7443
7444         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7445         code from these functions.  Remove corresponding ifdefs.  Use
7446         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7447         Remove gotos and target of gotos.
7448         (infpy_search_memory): Likewise.
7449
7450 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7451
7452         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7453         (hppa_gdbarch_init): Don't register deleted functions with
7454         gdbarch.
7455
7456 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7457
7458         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7459         (h8300_unwind_sp): Delete.
7460         (h8300_dummy_id): Delete.
7461         (h8300_gdbarch_init): Don't register deleted functions with
7462         gdbarch.
7463
7464 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7465
7466         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7467         (ft32_unwind_pc): Delete.
7468         (ft32_unwind_sp): Delete.
7469         (ft32_gdbarch_init): Don't register deleted functions with
7470         gdbarch.
7471
7472 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7473
7474         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7475         (frv_unwind_pc): Delete.
7476         (frv_unwind_sp): Delete.
7477         (frv_gdbarch_init): Don't register deleted functions with
7478         gdbarch.
7479
7480 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7481
7482         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7483         (riscv_unwind_pc): Delete.
7484         (riscv_unwind_sp): Delete.
7485         (riscv_gdbarch_init): Don't register deleted functions with
7486         gdbarch.
7487
7488 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7489
7490         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7491         (csky_unwind_pc): Delete.
7492         (csky_unwind_sp): Delete.
7493         (csky_gdbarch_init): Don't register deleted functions with
7494         gdbarch.
7495
7496 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7497
7498         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7499         (cris_unwind_pc): Delete.
7500         (cris_unwind_sp): Delete.
7501         (cris_gdbarch_init): Don't register deleted functions with
7502         gdbarch.
7503
7504 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7505
7506         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7507         (bfin_unwind_pc): Delete.
7508         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7509
7510 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7511
7512         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7513         (arm_unwind_pc): Delete.
7514         (arm_unwind_sp): Delete.
7515         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7516
7517 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7518
7519         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7520         (arc_unwind_pc): Delete.
7521         (arc_unwind_sp): Delete.
7522         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7523
7524 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7525
7526         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7527         (alpha_unwind_pc): Delete.
7528         (alpha_gdbarch_init): Don't register deleted functions with
7529         gdbarch.
7530
7531 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7532
7533         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7534         (aarch64_unwind_pc): Delete.
7535         (aarch64_unwind_sp): Delete.
7536         (aarch64_gdbarch_init): Don't register deleted functions with
7537         gdbarch.
7538
7539 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7540
7541         * gdbtypes.c (type_align): Don't consider static members when
7542         computing structure alignment.
7543
7544 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7545
7546         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7547         return 0 for other types.
7548         * arch-utils.c (default_type_align): Always return 0.
7549         * gdbarch.h: Regenerate.
7550         * gdbarch.sh (type_align): Extend comment.
7551         * gdbtypes.c (type_align): Add additional comments, always call
7552         gdbarch_type_align before applying the default rules.
7553         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7554         generic code will then apply a suitable default.
7555         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7556         types, return 0 for other types.
7557
7558 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7559
7560         * NEWS: Create a new section for the next release branch.
7561         Rename the section of the current branch, now that it has
7562         been cut.
7563
7564 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7565
7566         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7567         * version.in: Bump version to 8.3.50.DATE-git.
7568
7569 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7570
7571         * aix-thread.c (ptid_cmp): Remove unused variable.
7572         (get_signaled_thread): Likewise.
7573         (store_regs_user_thread): Likewise.
7574         (store_regs_kernel_thread): Likewise.
7575         (fetch_regs_kernel_thread): Remove shadowed variable.
7576
7577 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7578
7579         * features/riscv/32bit-cpu.xml: Add register numbers.
7580         * features/riscv/32bit-fpu.c: Regenerate.
7581         * features/riscv/32bit-fpu.xml: Add register numbers.
7582         * features/riscv/64bit-cpu.xml: Add register numbers.
7583         * features/riscv/64bit-fpu.c: Regenerate.
7584         * features/riscv/64bit-fpu.xml: Add register numbers.
7585
7586 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7587
7588         * NEWS: Mention two argument form of gdb.Value constructor.
7589         * python/py-value.c (convert_buffer_and_type_to_value): New
7590         function.
7591         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7592         Add support for handling an optional second argument.  Call
7593         convert_buffer_and_type_to_value as appropriate.
7594         * python/python-internal.h (Py_buffer_deleter): New struct.
7595         (Py_buffer_up): New typedef.
7596
7597 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7598
7599         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7600         instead of releasing ownership.
7601
7602 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7603
7604         * dwarf2read.c (open_and_init_dwp_file): Call
7605         elf_numsections instead of bfd_count_sections to initialize
7606         dwp_file->num_sections.
7607
7608 2019-02-25  Tom Tromey  <tromey@adacore.com>
7609
7610         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7611
7612 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7613
7614         * gcore.in: Add '--readnever' option when invoking GDB.
7615
7616 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7617
7618         * MAINTAINERS: Update my email address.
7619
7620 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7621
7622         * build-id.c (build_id_to_debug_bfd_1): New function.
7623         (build_id_to_debug_bfd): Look for separate debug file in
7624         sysroot.
7625
7626 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7627
7628         * gdbarch.sh: Update the copyright year range that is placed into
7629         generated files.
7630
7631 2019-02-22  Keith Seitz  <keiths@redhat.com>
7632
7633         PR symtab/23853
7634         * linespec.c (create_sals_line_offset): Search for the default
7635         symtab's filename instead of its fullname.
7636
7637 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7638
7639         * NEWS: Update style defaults.
7640
7641 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7642
7643         * main.c (captured_main_1): Disable styling in batch mode.
7644
7645 2019-02-20  Tom Tromey  <tom@tromey.com>
7646
7647         * symtab.c (symtab_symbol_info): Fix typos.
7648
7649 2019-02-20  Tom Tromey  <tromey@adacore.com>
7650
7651         * findcmd.c (_initialize_mem_search): Use upper case for
7652         metasyntactic variables.
7653
7654 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7655
7656         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7657         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7658
7659 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7660
7661         * top.h (source_file_name): Change to std::string.
7662         * top.c (source_file_name): Likewise.
7663         (command_line_input): Adjust.
7664         * cli/cli-script.c (script_from_file): Adjust.
7665
7666 2019-02-19  Tom Tromey  <tromey@adacore.com>
7667
7668         * ravenscar-thread.c
7669         (ravenscar_thread_target::update_thread_list): Don't call
7670         ada_build_task_list.
7671         * ada-lang.h (ada_build_task_list): Don't declare.
7672         * ada-tasks.c (struct ada_tasks_inferior_data)
7673         <task_list_valid_p>: Now bool.
7674         (read_known_tasks, ada_task_list_changed)
7675         (ada_tasks_invalidate_inferior_data): Update.
7676         (read_known_tasks_array): Return bool.
7677         (read_known_tasks_list): Likewise.
7678         (read_known_tasks): Return void.
7679         (ada_build_task_list): Now static.
7680
7681 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7682
7683         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7684         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7685
7686 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7687
7688         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7689         variant for ada_tasks_pspace_data_handle and
7690         ada_tasks_inferior_data_handle.
7691         (ada_tasks_pspace_data_cleanup): New function.
7692         (ada_tasks_inferior_data_cleanup): New function.
7693
7694 2019-02-17  Tom Tromey  <tom@tromey.com>
7695
7696         * macrotab.h (macro_source_fullname): Return a std::string.
7697         * macrotab.c (macro_include, check_for_redefinition)
7698         (macro_undef, macro_lookup_definition, foreach_macro)
7699         (foreach_macro_in_scope): Update.
7700         (macro_source_fullname): Return a std::string.
7701         * macrocmd.c (show_pp_source_pos): Update.
7702
7703 2019-02-17  Tom Tromey  <tom@tromey.com>
7704
7705         * macrocmd.c (show_pp_source_pos): Style the file names.
7706
7707 2019-02-17  Tom Tromey  <tom@tromey.com>
7708
7709         PR tui/24197:
7710         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7711
7712 2019-02-17  Tom Tromey  <tom@tromey.com>
7713
7714         * ada-lang.c (user_select_syms): Use filtered printing.
7715         * utils.c (wrap_style): New global.
7716         (desired_style): Remove.
7717         (emit_style_escape): Add stream parameter.
7718         (set_output_style, reset_terminal_style, prompt_for_continue):
7719         Update.
7720         (flush_wrap_buffer): Only flush gdb_stdout.
7721         (wrap_here): Set wrap_style.
7722         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7723         treat escape sequences as a character.  Change when wrap buffer is
7724         flushed.
7725         (fputs_styled): Do not set the output style when the default is
7726         requested.
7727         * ui-style.h (struct ui_file_style) <is_default>: New method.
7728         * source.c (print_source_lines_base): Emit escape sequences in one
7729         piece.
7730
7731 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7732
7733         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7734         integers and enumeration types.
7735
7736 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7737
7738         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7739         instead of lookup_symbol_in_language
7740         (do_exact_match): New function.
7741         (ada_get_symbol_name_matcher): Return do_exact_match when
7742         doing a verbatim match.
7743
7744 2019-02-15  Tom Tromey  <tromey@adacore.com>
7745
7746         * ravenscar-thread.c (ravenscar_thread_target::resume)
7747         (ravenscar_thread_target::wait): Special case wildcard requests.
7748
7749 2019-02-15  Tom Tromey  <tromey@adacore.com>
7750
7751         * ravenscar-thread.c (base_ptid): Remove.
7752         (struct ravenscar_thread_target) <close>: New method.
7753         <m_base_ptid>: New member.
7754         <update_inferior_ptid, active_task, task_is_currently_active,
7755         runtime_initialized>: Declare methods.
7756         <ravenscar_thread_target>: Add constructor.
7757         (ravenscar_thread_target::task_is_currently_active)
7758         (ravenscar_thread_target::update_inferior_ptid)
7759         (ravenscar_runtime_initialized): Rename.  Now methods.
7760         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7761         (ravenscar_thread_target::update_thread_list): Update.
7762         (ravenscar_thread_target::active_task): Now method.
7763         (ravenscar_thread_target::store_registers)
7764         (ravenscar_thread_target::prepare_to_store)
7765         (ravenscar_thread_target::prepare_to_store)
7766         (ravenscar_thread_target::mourn_inferior): Update.
7767         (ravenscar_inferior_created): Use "new" to create target.
7768         (ravenscar_thread_target::get_ada_task_ptid): Update.
7769         (_initialize_ravenscar): Don't initialize base_ptid.
7770         (ravenscar_ops): Remove global.
7771
7772 2019-02-15  Tom Tromey  <tromey@adacore.com>
7773
7774         * target.h (push_target): Declare new overload.
7775         * target.c (push_target): New overload, taking an rvalue reference.
7776         * remote.c (remote_target::open_1): Use push_target overload.
7777         * corelow.c (core_target_open): Use push_target overload.
7778
7779 2019-02-15  Tom Tromey  <tromey@adacore.com>
7780
7781         * ravenscar-thread.c (is_ravenscar_task)
7782         (ravenscar_task_is_currently_active): Return bool.
7783         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7784         (_initialize_ravenscar): Remove "(void)".
7785         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7786         Return bool.
7787
7788 2019-02-15  Tom Tromey  <tromey@adacore.com>
7789
7790         * ravenscar-thread.c (ravenscar_runtime_initializer)
7791         (has_ravenscar_runtime, get_running_thread_id)
7792         (ravenscar_thread_target::resume): Fix indentation.
7793
7794 2019-02-15  Tom Tromey  <tromey@adacore.com>
7795
7796         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7797         from ravenscar_arch_ops.
7798         (sparc_ravenscar_ops::fetch_registers)
7799         (sparc_ravenscar_ops::store_registers): Now methods.
7800         (sparc_ravenscar_prepare_to_store): Remove.
7801         (sparc_ravenscar_ops): Redefine.
7802         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7803         methods and destructor.  Remove members.
7804         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7805         (ravenscar_thread_target::store_registers)
7806         (ravenscar_thread_target::prepare_to_store): Update.
7807         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7808         Remove.
7809         (struct ppc_ravenscar_powerpc_ops): Derive from
7810         ravenscar_arch_ops.
7811         (ppc_ravenscar_powerpc_ops::fetch_registers)
7812         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7813         (ppc_ravenscar_powerpc_ops): Redefine.
7814         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7815         (ppc_ravenscar_e500_ops::fetch_registers)
7816         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7817         (ppc_ravenscar_e500_ops): Redefine.
7818         * aarch64-ravenscar-thread.c
7819         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7820         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7821         (aarch64_ravenscar_fetch_registers)
7822         (aarch64_ravenscar_store_registers): Now methods.
7823         (aarch64_ravenscar_ops): Redefine.
7824
7825 2019-02-15  Tom Tromey  <tromey@adacore.com>
7826
7827         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7828         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7829         (ravenscar_thread_target::stopped_by_watchpoint)
7830         (ravenscar_thread_target::stopped_data_address)
7831         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7832
7833 2019-02-15  Tom Tromey  <tromey@adacore.com>
7834
7835         * ravenscar-thread.c: Fix some typos.
7836
7837 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7838             Tom Tromey  <tromey@adacore.com>
7839
7840         * ada-lang.c (ada_exception_sal): Change addr_string to a
7841         std::string.
7842         (create_ada_exception_catchpoint): Update.
7843
7844 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7845             Tom Tromey  <tromey@adacore.com>
7846
7847         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7848         (bp_location_ops): Remove.
7849         (base_breakpoint_allocate_location): Update.
7850         (free_bp_location): Update.
7851         * ada-lang.c (class ada_catchpoint_location)
7852         <ada_catchpoint_location>: Remove ops parameter.
7853         (ada_catchpoint_location_dtor): Remove.
7854         (ada_catchpoint_location_ops): Remove.
7855         (allocate_location_exception): Update.
7856         * breakpoint.h (struct bp_location_ops): Remove.
7857         (class bp_location) <bp_location>: Remove bp_location_ops
7858         parameter.
7859         <~bp_location>: Add destructor.
7860         <ops>: Remove.
7861
7862 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7863             Pedro Alves  <palves@redhat.com>
7864
7865         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7866         'PATH_MAX'.
7867
7868 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7869             Samuel Thibault  <samuel.thibault@gnu.org>
7870             Thomas Schwinge  <thomas@codesourcery.com>
7871
7872         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7873         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7874
7875 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7876
7877         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7878         (check_empty): Use "const char *".
7879
7880         * gnu-nat.c (gnu_nat_target::detach): Instead of
7881         'detach_inferior (pid)' call
7882         'detach_inferior (find_inferior_pid (pid))'.
7883
7884         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7885         'nat/fork-inferior.o'.
7886         * gnu-nat.c: #include "nat/fork-inferior.h".
7887
7888         * gnu-nat.c (gnu_nat_target::detach): Instead of
7889         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7890         * gnu-nat.h: #include "inf-child.h".
7891         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7892         'i386_gnu_nat_target::fetch_registers'.
7893         (gnu_store_registers): Rename/move to
7894         'i386_gnu_nat_target::store_registers'.
7895
7896         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7897         * gnu-nat.h (mach_thread_info): New function.
7898         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7899
7900         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7901
7902 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7903
7904         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7905
7906 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7907
7908         * windows-nat.c (windows_add_thread): Add new parameter
7909         "main_thread_p" with default value set to false.  Update
7910         function documentation as well as all callers.
7911         (windows_delete_thread): Likewise.
7912         (fake_create_process): Update call to windows_add_thread.
7913         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7914         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7915         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7916         call to windows_delete_thread.
7917
7918 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7919
7920         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7921
7922 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7923
7924         * symfile.c (find_separate_debug_file): Use canonical path of
7925         sysroot with child_path instead of gdb_sysroot if it is valid.
7926
7927 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7928
7929         * symfile.c (find_separate_debug_file): Use child_path to
7930         determine if an object file is under a sysroot.
7931
7932 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7933
7934         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7935         unittests/child-path-selftests.c.
7936         * common/pathstuff.c (child_path): New function.
7937         * common/pathstuff.h (child_path): New prototype.
7938         * unittests/child-path-selftests.c: New file.
7939
7940 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7941
7942         * symfile.c (find_separate_debug_file): Look for separate debug
7943         files in debug directories under the sysroot.
7944
7945 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7946
7947         * symtab.h (struct minimal_symbol data_p): New const method.
7948         (struct minimal_symbol text_p): Likewise.
7949         * symtab.c (output_source_filename): Use file name style
7950         to print file name.
7951         (print_symbol_info): Likewise.
7952         (print_msymbol_info): Use address style to print addresses.
7953         Use function name style to print executable text symbols.
7954         (expand_symtab_containing_pc): Use data_p.
7955         (find_pc_sect_compunit_symtab): Likewise.
7956
7957 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7958
7959         * breakpoint.c (describe_other_breakpoints): Use address style
7960         to print addresses.
7961         (say_where): Likewise.
7962
7963 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7964
7965         * ada-typeprint.c (print_func_type): Print function name
7966         style to print function name.
7967         * c-typeprint.c (c_print_type_1): Likewise.
7968
7969 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7970
7971         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7972         for execve.
7973
7974 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7975
7976         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7977         type_stack.
7978
7979 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7980
7981         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7982         TYPE_CODE_REF types.
7983
7984 2019-02-08  Jim Wilson  <jimw@sifive.com>
7985
7986         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7987         (riscv_linux_fregset): New.
7988         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7989
7990 2019-02-07  Tom Tromey  <tom@tromey.com>
7991
7992         * thread.c (thread_cancel_execution_command): Update.
7993         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7994         methods.
7995         (struct thread_fsm_ops): Remove.
7996         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7997         (thread_fsm_should_stop, thread_fsm_return_value)
7998         (thread_fsm_set_finished, thread_fsm_finished_p)
7999         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8000         Don't declare.
8001         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8002         * infrun.c (clear_proceed_status_thread)
8003         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8004         (print_stop_event): Update.
8005         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8006         Add constructor.
8007         (step_command_fsm_ops): Remove.
8008         (new_step_command_fsm): Remove.
8009         (step_1): Update.
8010         (step_command_fsm::should_stop): Rename from
8011         step_command_fsm_should_stop.
8012         (step_command_fsm::clean_up): Rename from
8013         step_command_fsm_clean_up.
8014         (step_command_fsm::do_async_reply_reason): Rename from
8015         step_command_fsm_async_reply_reason.
8016         (struct until_next_fsm): Inherit from thread_fsm.  Add
8017         constructor.
8018         (until_next_fsm_ops): Remove.
8019         (new_until_next_fsm): Remove.
8020         (until_next_fsm::should_stop): Rename from
8021         until_next_fsm_should_stop.
8022         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8023         (until_next_fsm::do_async_reply_reason): Rename from
8024         until_next_fsm_async_reply_reason.
8025         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8026         constructor.  Change type of breakpoint.
8027         (finish_command_fsm_ops): Remove.
8028         (new_finish_command_fsm): Remove.
8029         (finish_command_fsm::should_stop): Rename from
8030         finish_command_fsm_should_stop.
8031         (finish_command_fsm::clean_up): Rename from
8032         finish_command_fsm_clean_up.
8033         (finish_command_fsm::return_value): Rename from
8034         finish_command_fsm_return_value.
8035         (finish_command_fsm::do_async_reply_reason): Rename from
8036         finish_command_fsm_async_reply_reason.
8037         (finish_command): Update.
8038         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8039         Add constructor.
8040         (call_thread_fsm_ops): Remove.
8041         (call_thread_fsm::call_thread_fsm): Rename from
8042         new_call_thread_fsm.
8043         (call_thread_fsm::should_stop): Rename from
8044         call_thread_fsm_should_stop.
8045         (call_thread_fsm::should_notify_stop): Rename from
8046         call_thread_fsm_should_notify_stop.
8047         (run_inferior_call, call_function_by_hand_dummy): Update.
8048         * cli/cli-interp.c (should_print_stop_to_console): Update.
8049         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8050         Add constructor.  Change type of location_breakpoint,
8051         caller_breakpoint.
8052         (until_break_fsm_ops): Remove.
8053         (new_until_break_fsm): Remove.
8054         (until_break_fsm::should_stop): Rename from
8055         until_break_fsm_should_stop.
8056         (until_break_fsm::clean_up): Rename from
8057         until_break_fsm_clean_up.
8058         (until_break_fsm::do_async_reply_reason): Rename from
8059         until_break_fsm_async_reply_reason.
8060         (until_break_command): Update.
8061         * thread-fsm.c: Remove.
8062         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8063
8064 2019-02-07  Tom Tromey  <tom@tromey.com>
8065
8066         * yy-remap.h: Add include guard.
8067         * xtensa-tdep.h: Add include guard.
8068         * xcoffread.h: Rename include guard.
8069         * varobj-iter.h: Add include guard.
8070         * tui/tui.h: Rename include guard.
8071         * tui/tui-winsource.h: Rename include guard.
8072         * tui/tui-wingeneral.h: Rename include guard.
8073         * tui/tui-windata.h: Rename include guard.
8074         * tui/tui-win.h: Rename include guard.
8075         * tui/tui-stack.h: Rename include guard.
8076         * tui/tui-source.h: Rename include guard.
8077         * tui/tui-regs.h: Rename include guard.
8078         * tui/tui-out.h: Rename include guard.
8079         * tui/tui-layout.h: Rename include guard.
8080         * tui/tui-io.h: Rename include guard.
8081         * tui/tui-hooks.h: Rename include guard.
8082         * tui/tui-file.h: Rename include guard.
8083         * tui/tui-disasm.h: Rename include guard.
8084         * tui/tui-data.h: Rename include guard.
8085         * tui/tui-command.h: Rename include guard.
8086         * tic6x-tdep.h: Add include guard.
8087         * target/waitstatus.h: Rename include guard.
8088         * target/wait.h: Rename include guard.
8089         * target/target.h: Rename include guard.
8090         * target/resume.h: Rename include guard.
8091         * target-float.h: Rename include guard.
8092         * stabsread.h: Add include guard.
8093         * rs6000-tdep.h: Add include guard.
8094         * riscv-fbsd-tdep.h: Add include guard.
8095         * regformats/regdef.h: Rename include guard.
8096         * record.h: Rename include guard.
8097         * python/python.h: Rename include guard.
8098         * python/python-internal.h: Rename include guard.
8099         * python/py-stopevent.h: Rename include guard.
8100         * python/py-ref.h: Rename include guard.
8101         * python/py-record.h: Rename include guard.
8102         * python/py-record-full.h: Rename include guard.
8103         * python/py-record-btrace.h: Rename include guard.
8104         * python/py-instruction.h: Rename include guard.
8105         * python/py-events.h: Rename include guard.
8106         * python/py-event.h: Rename include guard.
8107         * procfs.h: Add include guard.
8108         * proc-utils.h: Add include guard.
8109         * p-lang.h: Add include guard.
8110         * or1k-tdep.h: Rename include guard.
8111         * observable.h: Rename include guard.
8112         * nto-tdep.h: Rename include guard.
8113         * nat/x86-linux.h: Rename include guard.
8114         * nat/x86-linux-dregs.h: Rename include guard.
8115         * nat/x86-gcc-cpuid.h: Add include guard.
8116         * nat/x86-dregs.h: Rename include guard.
8117         * nat/x86-cpuid.h: Rename include guard.
8118         * nat/ppc-linux.h: Rename include guard.
8119         * nat/mips-linux-watch.h: Rename include guard.
8120         * nat/linux-waitpid.h: Rename include guard.
8121         * nat/linux-ptrace.h: Rename include guard.
8122         * nat/linux-procfs.h: Rename include guard.
8123         * nat/linux-osdata.h: Rename include guard.
8124         * nat/linux-nat.h: Rename include guard.
8125         * nat/linux-namespaces.h: Rename include guard.
8126         * nat/linux-btrace.h: Rename include guard.
8127         * nat/glibc_thread_db.h: Rename include guard.
8128         * nat/gdb_thread_db.h: Rename include guard.
8129         * nat/gdb_ptrace.h: Rename include guard.
8130         * nat/fork-inferior.h: Rename include guard.
8131         * nat/amd64-linux-siginfo.h: Rename include guard.
8132         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8133         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8134         * nat/aarch64-linux.h: Rename include guard.
8135         * nat/aarch64-linux-hw-point.h: Rename include guard.
8136         * mn10300-tdep.h: Add include guard.
8137         * mips-linux-tdep.h: Add include guard.
8138         * mi/mi-parse.h: Rename include guard.
8139         * mi/mi-out.h: Rename include guard.
8140         * mi/mi-main.h: Rename include guard.
8141         * mi/mi-interp.h: Rename include guard.
8142         * mi/mi-getopt.h: Rename include guard.
8143         * mi/mi-console.h: Rename include guard.
8144         * mi/mi-common.h: Rename include guard.
8145         * mi/mi-cmds.h: Rename include guard.
8146         * mi/mi-cmd-break.h: Rename include guard.
8147         * m2-lang.h: Add include guard.
8148         * location.h: Rename include guard.
8149         * linux-record.h: Rename include guard.
8150         * linux-nat.h: Add include guard.
8151         * linux-fork.h: Add include guard.
8152         * i386-darwin-tdep.h: Rename include guard.
8153         * hppa-linux-offsets.h: Add include guard.
8154         * guile/guile.h: Rename include guard.
8155         * guile/guile-internal.h: Rename include guard.
8156         * gnu-nat.h: Rename include guard.
8157         * gdb-stabs.h: Rename include guard.
8158         * frv-tdep.h: Add include guard.
8159         * f-lang.h: Add include guard.
8160         * event-loop.h: Add include guard.
8161         * darwin-nat.h: Rename include guard.
8162         * cp-abi.h: Rename include guard.
8163         * config/sparc/nm-sol2.h: Rename include guard.
8164         * config/nm-nto.h: Rename include guard.
8165         * config/nm-linux.h: Add include guard.
8166         * config/i386/nm-i386gnu.h: Rename include guard.
8167         * config/djgpp/nl_types.h: Rename include guard.
8168         * config/djgpp/langinfo.h: Rename include guard.
8169         * compile/gcc-cp-plugin.h: Add include guard.
8170         * compile/gcc-c-plugin.h: Add include guard.
8171         * compile/compile.h: Rename include guard.
8172         * compile/compile-object-run.h: Rename include guard.
8173         * compile/compile-object-load.h: Rename include guard.
8174         * compile/compile-internal.h: Rename include guard.
8175         * compile/compile-cplus.h: Rename include guard.
8176         * compile/compile-c.h: Rename include guard.
8177         * common/xml-utils.h: Rename include guard.
8178         * common/x86-xstate.h: Rename include guard.
8179         * common/version.h: Rename include guard.
8180         * common/vec.h: Rename include guard.
8181         * common/tdesc.h: Rename include guard.
8182         * common/selftest.h: Rename include guard.
8183         * common/scoped_restore.h: Rename include guard.
8184         * common/scoped_mmap.h: Rename include guard.
8185         * common/scoped_fd.h: Rename include guard.
8186         * common/safe-iterator.h: Rename include guard.
8187         * common/run-time-clock.h: Rename include guard.
8188         * common/refcounted-object.h: Rename include guard.
8189         * common/queue.h: Rename include guard.
8190         * common/ptid.h: Rename include guard.
8191         * common/print-utils.h: Rename include guard.
8192         * common/preprocessor.h: Rename include guard.
8193         * common/pathstuff.h: Rename include guard.
8194         * common/observable.h: Rename include guard.
8195         * common/netstuff.h: Rename include guard.
8196         * common/job-control.h: Rename include guard.
8197         * common/host-defs.h: Rename include guard.
8198         * common/gdb_wait.h: Rename include guard.
8199         * common/gdb_vecs.h: Rename include guard.
8200         * common/gdb_unlinker.h: Rename include guard.
8201         * common/gdb_unique_ptr.h: Rename include guard.
8202         * common/gdb_tilde_expand.h: Rename include guard.
8203         * common/gdb_sys_time.h: Rename include guard.
8204         * common/gdb_string_view.h: Rename include guard.
8205         * common/gdb_splay_tree.h: Rename include guard.
8206         * common/gdb_setjmp.h: Rename include guard.
8207         * common/gdb_ref_ptr.h: Rename include guard.
8208         * common/gdb_optional.h: Rename include guard.
8209         * common/gdb_locale.h: Rename include guard.
8210         * common/gdb_assert.h: Rename include guard.
8211         * common/filtered-iterator.h: Rename include guard.
8212         * common/filestuff.h: Rename include guard.
8213         * common/fileio.h: Rename include guard.
8214         * common/environ.h: Rename include guard.
8215         * common/common-utils.h: Rename include guard.
8216         * common/common-types.h: Rename include guard.
8217         * common/common-regcache.h: Rename include guard.
8218         * common/common-inferior.h: Rename include guard.
8219         * common/common-gdbthread.h: Rename include guard.
8220         * common/common-exceptions.h: Rename include guard.
8221         * common/common-defs.h: Rename include guard.
8222         * common/common-debug.h: Rename include guard.
8223         * common/cleanups.h: Rename include guard.
8224         * common/buffer.h: Rename include guard.
8225         * common/btrace-common.h: Rename include guard.
8226         * common/break-common.h: Rename include guard.
8227         * cli/cli-utils.h: Rename include guard.
8228         * cli/cli-style.h: Rename include guard.
8229         * cli/cli-setshow.h: Rename include guard.
8230         * cli/cli-script.h: Rename include guard.
8231         * cli/cli-interp.h: Rename include guard.
8232         * cli/cli-decode.h: Rename include guard.
8233         * cli/cli-cmds.h: Rename include guard.
8234         * charset-list.h: Add include guard.
8235         * buildsym-legacy.h: Rename include guard.
8236         * bfin-tdep.h: Add include guard.
8237         * ax.h: Rename include guard.
8238         * arm-linux-tdep.h: Add include guard.
8239         * arm-fbsd-tdep.h: Add include guard.
8240         * arch/xtensa.h: Rename include guard.
8241         * arch/tic6x.h: Add include guard.
8242         * arch/i386.h: Add include guard.
8243         * arch/arm.h: Rename include guard.
8244         * arch/arm-linux.h: Rename include guard.
8245         * arch/arm-get-next-pcs.h: Rename include guard.
8246         * arch/amd64.h: Add include guard.
8247         * arch/aarch64-insn.h: Rename include guard.
8248         * arch-utils.h: Rename include guard.
8249         * annotate.h: Add include guard.
8250         * amd64-darwin-tdep.h: Rename include guard.
8251         * aarch64-linux-tdep.h: Add include guard.
8252         * aarch64-fbsd-tdep.h: Add include guard.
8253         * aarch32-linux-nat.h: Add include guard.
8254
8255 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8256
8257         * macrotab.c (macro_define_internal): New function that
8258         factorizes macro_define_object_internal and macro_define_function
8259         code.
8260         (macro_define_object_internal): Use macro_define_internal.
8261         (macro_define_function): Likewise.
8262
8263 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8264
8265         * macrocmd.c (extract_identifier): Return
8266         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8267         callers.
8268
8269 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8270
8271         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8272
8273 2019-02-05  Tom Tromey  <tom@tromey.com>
8274
8275         * target.c (target_stack::unpush): Move assertion earlier.
8276
8277 2019-01-30  Tom Tromey  <tom@tromey.com>
8278
8279         PR python/23615:
8280         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8281         (gdbpy_parse_and_eval): Likewise.
8282         * python/python-internal.h (gdbpy_allow_threads): New class.
8283
8284 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8285
8286         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8287         (aarch64_fbsd_fpregmap): Move earlier.
8288         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8289         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8290         instead of individual calls to trad_frame_set_reg_addr.
8291         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8292         earlier.
8293         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8294         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8295         instead of individual calls to trad_frame_set_reg_addr.
8296
8297 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8298
8299         * CONTRIBUTE: Replace contribution list with wiki link.
8300
8301 2019-01-25  Tom Tromey  <tom@tromey.com>
8302
8303         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8304
8305 2019-01-25  Tom Tromey  <tom@tromey.com>
8306
8307         * xtensa-linux-nat.c: Fix common/ includes.
8308         * xml-support.h: Fix common/ includes.
8309         * xml-support.c: Fix common/ includes.
8310         * x86-linux-nat.c: Fix common/ includes.
8311         * windows-nat.c: Fix common/ includes.
8312         * varobj.h: Fix common/ includes.
8313         * varobj.c: Fix common/ includes.
8314         * value.c: Fix common/ includes.
8315         * valops.c: Fix common/ includes.
8316         * utils.c: Fix common/ includes.
8317         * unittests/xml-utils-selftests.c: Fix common/ includes.
8318         * unittests/utils-selftests.c: Fix common/ includes.
8319         * unittests/unpack-selftests.c: Fix common/ includes.
8320         * unittests/tracepoint-selftests.c: Fix common/ includes.
8321         * unittests/style-selftests.c: Fix common/ includes.
8322         * unittests/string_view-selftests.c: Fix common/ includes.
8323         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8324         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8325         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8326         * unittests/rsp-low-selftests.c: Fix common/ includes.
8327         * unittests/parse-connection-spec-selftests.c: Fix common/
8328         includes.
8329         * unittests/optional-selftests.c: Fix common/ includes.
8330         * unittests/offset-type-selftests.c: Fix common/ includes.
8331         * unittests/observable-selftests.c: Fix common/ includes.
8332         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8333         * unittests/memrange-selftests.c: Fix common/ includes.
8334         * unittests/memory-map-selftests.c: Fix common/ includes.
8335         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8336         * unittests/function-view-selftests.c: Fix common/ includes.
8337         * unittests/environ-selftests.c: Fix common/ includes.
8338         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8339         * unittests/common-utils-selftests.c: Fix common/ includes.
8340         * unittests/cli-utils-selftests.c: Fix common/ includes.
8341         * unittests/array-view-selftests.c: Fix common/ includes.
8342         * ui-file.c: Fix common/ includes.
8343         * tui/tui-io.c: Fix common/ includes.
8344         * tracepoint.h: Fix common/ includes.
8345         * tracepoint.c: Fix common/ includes.
8346         * tracefile-tfile.c: Fix common/ includes.
8347         * top.h: Fix common/ includes.
8348         * top.c: Fix common/ includes.
8349         * thread.c: Fix common/ includes.
8350         * target/waitstatus.h: Fix common/ includes.
8351         * target/waitstatus.c: Fix common/ includes.
8352         * target.h: Fix common/ includes.
8353         * target.c: Fix common/ includes.
8354         * target-memory.c: Fix common/ includes.
8355         * target-descriptions.c: Fix common/ includes.
8356         * symtab.h: Fix common/ includes.
8357         * symfile.c: Fix common/ includes.
8358         * stap-probe.c: Fix common/ includes.
8359         * spu-linux-nat.c: Fix common/ includes.
8360         * sparc-nat.c: Fix common/ includes.
8361         * source.c: Fix common/ includes.
8362         * solib.c: Fix common/ includes.
8363         * solib-target.c: Fix common/ includes.
8364         * ser-unix.c: Fix common/ includes.
8365         * ser-tcp.c: Fix common/ includes.
8366         * ser-pipe.c: Fix common/ includes.
8367         * ser-base.c: Fix common/ includes.
8368         * selftest-arch.c: Fix common/ includes.
8369         * s12z-tdep.c: Fix common/ includes.
8370         * rust-exp.y: Fix common/ includes.
8371         * rs6000-aix-tdep.c: Fix common/ includes.
8372         * riscv-tdep.c: Fix common/ includes.
8373         * remote.c: Fix common/ includes.
8374         * remote-notif.h: Fix common/ includes.
8375         * remote-fileio.h: Fix common/ includes.
8376         * remote-fileio.c: Fix common/ includes.
8377         * regcache.h: Fix common/ includes.
8378         * regcache.c: Fix common/ includes.
8379         * record-btrace.c: Fix common/ includes.
8380         * python/python.c: Fix common/ includes.
8381         * python/py-type.c: Fix common/ includes.
8382         * python/py-inferior.c: Fix common/ includes.
8383         * progspace.h: Fix common/ includes.
8384         * producer.c: Fix common/ includes.
8385         * procfs.c: Fix common/ includes.
8386         * proc-api.c: Fix common/ includes.
8387         * printcmd.c: Fix common/ includes.
8388         * ppc-linux-nat.c: Fix common/ includes.
8389         * parser-defs.h: Fix common/ includes.
8390         * osdata.c: Fix common/ includes.
8391         * obsd-nat.c: Fix common/ includes.
8392         * nat/x86-linux.c: Fix common/ includes.
8393         * nat/x86-linux-dregs.c: Fix common/ includes.
8394         * nat/x86-dregs.h: Fix common/ includes.
8395         * nat/x86-dregs.c: Fix common/ includes.
8396         * nat/ppc-linux.c: Fix common/ includes.
8397         * nat/mips-linux-watch.h: Fix common/ includes.
8398         * nat/mips-linux-watch.c: Fix common/ includes.
8399         * nat/linux-waitpid.c: Fix common/ includes.
8400         * nat/linux-ptrace.h: Fix common/ includes.
8401         * nat/linux-ptrace.c: Fix common/ includes.
8402         * nat/linux-procfs.c: Fix common/ includes.
8403         * nat/linux-personality.c: Fix common/ includes.
8404         * nat/linux-osdata.c: Fix common/ includes.
8405         * nat/linux-namespaces.c: Fix common/ includes.
8406         * nat/linux-btrace.h: Fix common/ includes.
8407         * nat/linux-btrace.c: Fix common/ includes.
8408         * nat/fork-inferior.c: Fix common/ includes.
8409         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8410         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8411         * nat/aarch64-linux.c: Fix common/ includes.
8412         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8413         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8414         * namespace.h: Fix common/ includes.
8415         * mips-linux-tdep.c: Fix common/ includes.
8416         * minsyms.c: Fix common/ includes.
8417         * mi/mi-parse.h: Fix common/ includes.
8418         * mi/mi-main.c: Fix common/ includes.
8419         * mi/mi-cmd-env.c: Fix common/ includes.
8420         * memrange.h: Fix common/ includes.
8421         * memattr.c: Fix common/ includes.
8422         * maint.h: Fix common/ includes.
8423         * maint.c: Fix common/ includes.
8424         * main.c: Fix common/ includes.
8425         * machoread.c: Fix common/ includes.
8426         * location.c: Fix common/ includes.
8427         * linux-thread-db.c: Fix common/ includes.
8428         * linux-nat.c: Fix common/ includes.
8429         * linux-fork.c: Fix common/ includes.
8430         * inline-frame.c: Fix common/ includes.
8431         * infrun.c: Fix common/ includes.
8432         * inflow.c: Fix common/ includes.
8433         * inferior.h: Fix common/ includes.
8434         * inferior.c: Fix common/ includes.
8435         * infcmd.c: Fix common/ includes.
8436         * inf-ptrace.c: Fix common/ includes.
8437         * inf-child.c: Fix common/ includes.
8438         * ia64-linux-nat.c: Fix common/ includes.
8439         * i387-tdep.c: Fix common/ includes.
8440         * i386-tdep.c: Fix common/ includes.
8441         * i386-linux-tdep.c: Fix common/ includes.
8442         * i386-linux-nat.c: Fix common/ includes.
8443         * i386-go32-tdep.c: Fix common/ includes.
8444         * i386-fbsd-tdep.c: Fix common/ includes.
8445         * i386-fbsd-nat.c: Fix common/ includes.
8446         * guile/scm-type.c: Fix common/ includes.
8447         * guile/guile.c: Fix common/ includes.
8448         * go32-nat.c: Fix common/ includes.
8449         * gnu-nat.c: Fix common/ includes.
8450         * gdbthread.h: Fix common/ includes.
8451         * gdbarch-selftests.c: Fix common/ includes.
8452         * gdb_usleep.c: Fix common/ includes.
8453         * gdb_select.h: Fix common/ includes.
8454         * gdb_bfd.c: Fix common/ includes.
8455         * gcore.c: Fix common/ includes.
8456         * fork-child.c: Fix common/ includes.
8457         * findvar.c: Fix common/ includes.
8458         * fbsd-nat.c: Fix common/ includes.
8459         * event-top.c: Fix common/ includes.
8460         * event-loop.c: Fix common/ includes.
8461         * dwarf2read.c: Fix common/ includes.
8462         * dwarf2loc.c: Fix common/ includes.
8463         * dwarf2-frame.c: Fix common/ includes.
8464         * dwarf-index-cache.c: Fix common/ includes.
8465         * dtrace-probe.c: Fix common/ includes.
8466         * disasm-selftests.c: Fix common/ includes.
8467         * defs.h: Fix common/ includes.
8468         * csky-tdep.c: Fix common/ includes.
8469         * cp-valprint.c: Fix common/ includes.
8470         * cp-support.h: Fix common/ includes.
8471         * cp-support.c: Fix common/ includes.
8472         * corelow.c: Fix common/ includes.
8473         * completer.h: Fix common/ includes.
8474         * completer.c: Fix common/ includes.
8475         * compile/compile.c: Fix common/ includes.
8476         * compile/compile-loc2c.c: Fix common/ includes.
8477         * compile/compile-cplus-types.c: Fix common/ includes.
8478         * compile/compile-cplus-symbols.c: Fix common/ includes.
8479         * command.h: Fix common/ includes.
8480         * cli/cli-dump.c: Fix common/ includes.
8481         * cli/cli-cmds.c: Fix common/ includes.
8482         * charset.c: Fix common/ includes.
8483         * build-id.c: Fix common/ includes.
8484         * btrace.h: Fix common/ includes.
8485         * btrace.c: Fix common/ includes.
8486         * breakpoint.h: Fix common/ includes.
8487         * breakpoint.c: Fix common/ includes.
8488         * ax.h:
8489         (enum agent_op): Fix common/ includes.
8490         * ax-general.c (struct aop_map): Fix common/ includes.
8491         * ax-gdb.c: Fix common/ includes.
8492         * auxv.c: Fix common/ includes.
8493         * auto-load.c: Fix common/ includes.
8494         * arm-tdep.c: Fix common/ includes.
8495         * arch/riscv.c: Fix common/ includes.
8496         * arch/ppc-linux-common.c: Fix common/ includes.
8497         * arch/i386.c: Fix common/ includes.
8498         * arch/arm.c: Fix common/ includes.
8499         * arch/arm-linux.c: Fix common/ includes.
8500         * arch/arm-get-next-pcs.c: Fix common/ includes.
8501         * arch/amd64.c: Fix common/ includes.
8502         * arch/aarch64.c: Fix common/ includes.
8503         * arch/aarch64-insn.c: Fix common/ includes.
8504         * arch-utils.c: Fix common/ includes.
8505         * amd64-windows-tdep.c: Fix common/ includes.
8506         * amd64-tdep.c: Fix common/ includes.
8507         * amd64-sol2-tdep.c: Fix common/ includes.
8508         * amd64-obsd-tdep.c: Fix common/ includes.
8509         * amd64-nbsd-tdep.c: Fix common/ includes.
8510         * amd64-linux-tdep.c: Fix common/ includes.
8511         * amd64-linux-nat.c: Fix common/ includes.
8512         * amd64-fbsd-tdep.c: Fix common/ includes.
8513         * amd64-fbsd-nat.c: Fix common/ includes.
8514         * amd64-dicos-tdep.c: Fix common/ includes.
8515         * amd64-darwin-tdep.c: Fix common/ includes.
8516         * agent.c: Fix common/ includes.
8517         * ada-lang.h: Fix common/ includes.
8518         * ada-lang.c: Fix common/ includes.
8519         * aarch64-tdep.c: Fix common/ includes.
8520
8521 2019-01-25  Tom Tromey  <tom@tromey.com>
8522
8523         * common/create-version.sh: Use common/version.h.
8524
8525 2019-01-24  Pedro Alves  <palves@redhat.com>
8526
8527         * infrun.c (signal_stop, signal_print, signal_program)
8528         (signal_catch, signal_pass): Now arrays instead of pointers.
8529         (update_signals_program_target, do_target_resume)
8530         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8531         * linux-nat.c (linux_nat_target::pass_signals)
8532         (linux_nat_target::create_inferior, linux_nat_target::attach):
8533         Adjust.
8534         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8535         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8536         * procfs.c (procfs_target::pass_signals): Adjust.
8537         * record-full.c (record_full_target::resume): Adjust.
8538         * remote.c (remote_target::pass_signals)
8539         (remote_target::program_signals): Adjust.
8540         * target-debug.h (target_debug_print_signals): Now takes a
8541         gdb::array_view as parameter.  Adjust.
8542         * target.h (target_ops) <pass_signals, program_signals>: Replace
8543         pointer and length parameters with gdb::array_view.
8544         (target_pass_signals, target_program_signals): Likewise.
8545         * target-delegates.c: Regenerate.
8546
8547 2019-01-24  Pedro Alves  <palves@redhat.com>
8548
8549         * common/forward-scope-exit.h
8550         (forward_scope_exit::forward_scope_exit): Pass arguments to
8551         m_bind_function directly, instead of creating a std::bind and
8552         copying that.
8553
8554 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8555
8556         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8557         for static members.
8558         (pass_in_v_vfp_candidate): Likewise.
8559
8560 2019-01-23  Tom Tromey  <tom@tromey.com>
8561             Pedro Alves  <palves@redhat.com>
8562
8563         * regcache.c (class regcache_invalidator): Remove.
8564         (regcache::raw_write): Use make_scope_exit.
8565
8566 2019-01-23  Tom Tromey  <tom@tromey.com>
8567
8568         * ui-out.h (class ui_out_emit_type): Update comment.
8569
8570 2019-01-23  Tom Tromey  <tom@tromey.com>
8571
8572         * infrun.c (fetch_inferior_event): Update comment.
8573
8574 2019-01-23  Tom Tromey  <tom@tromey.com>
8575             Pedro Alves  <palves@redhat.com>
8576
8577         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8578         parameter.
8579         (fetch_inferior_event): Use SCOPE_EXIT.
8580
8581
8582 2019-01-23  Tom Tromey  <tom@tromey.com>
8583             Pedro Alves  <palves@redhat.com>
8584
8585         * infrun.c (disable_thread_events): Delete.
8586         (stop_all_threads): Use SCOPE_EXIT.
8587
8588 2019-01-23  Tom Tromey  <tom@tromey.com>
8589             Pedro Alves  <palves@redhat.com>
8590
8591         * symfile.c: Include forward-scope-exit.h.
8592         (clear_symtab_users_cleanup): Replace forward declaration with
8593         a FORWARD_SCOPE_EXIT.
8594         (syms_from_objfile_1): Use the forward_scope_exit and
8595         gdb::optional instead of cleanup_function.
8596         (reread_symbols): Use the forward_scope_exit instead of
8597         cleanup_function.
8598         (clear_symtab_users_cleanup): Remove function.
8599
8600 2019-01-23  Tom Tromey  <tom@tromey.com>
8601             Pedro Alves  <palves@redhat.com>
8602
8603         * linux-nat.c: Include scope-exit.h.
8604         (cleanup_target_stop): Remove.
8605         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8606         SCOPE_EXIT.
8607
8608 2019-01-23  Tom Tromey  <tom@tromey.com>
8609             Pedro Alves  <palves@redhat.com>
8610
8611         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8612         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8613
8614 2019-01-23  Tom Tromey  <tom@tromey.com>
8615             Andrew Burgess  <andrew.burgess@embecosm.com>
8616             Pedro Alves  <palves@redhat.com>
8617
8618         * infrun.c (fetch_inferior_event): Use scope_exit.
8619         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8620         * top.c (execute_command): Use scope_exit.
8621         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8622         * utils.c (do_bpstat_clear_actions_cleanup)
8623         (make_bpstat_clear_actions_cleanup): Remove.
8624
8625 2019-01-23  Tom Tromey  <tom@tromey.com>
8626             Pedro Alves  <palves@redhat.com>
8627
8628         * infrun.c: Include "common/scope-exit.h"
8629         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8630         (wait_for_inferior): Use SCOPE_EXIT.
8631         (fetch_inferior_event): Use scope_exit.
8632
8633 2019-01-23  Tom Tromey  <tom@tromey.com>
8634             Pedro Alves  <palves@redhat.com>
8635
8636         * breakpoint.c (create_breakpoint): Remove cleanup.
8637
8638 2019-01-23  Tom Tromey  <tom@tromey.com>
8639             Andrew Burgess  <andrew.burgess@embecosm.com>
8640             Pedro Alves  <palves@redhat.com>
8641
8642 2019-01-23  Pedro Alves  <palves@redhat.com>
8643
8644         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8645
8646 2019-01-23  Pedro Alves  <palves@redhat.com>
8647             Andrew Burgess  <andrew.burgess@embecosm.com>
8648
8649         * gdbthread.h: Include "common/forward-scope-exit.h".
8650         (scoped_finish_thread_state): Redefine custom class in terms of
8651         forward_scope_exit.
8652
8653 2019-01-23  Pedro Alves  <palves@redhat.com>
8654             Andrew Burgess  <andrew.burgess@embecosm.com>
8655
8656         * common/forward-scope-exit.h: New file.
8657
8658 2019-01-23  Pedro Alves  <palves@redhat.com>
8659             Andrew Burgess  <andrew.burgess@embecosm.com>
8660             Tom Tromey  <tom@tromey.com>
8661
8662         * common/scope-exit.h: New file.
8663
8664 2019-01-23  Pedro Alves  <palves@redhat.com>
8665
8666         * common/preprocessor.h (ESC): Rename to ...
8667         (ESC_PARENS): ... this.
8668         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8669         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8670
8671 2019-01-23  Tom Tromey  <tom@tromey.com>
8672
8673         * language.h (class scoped_switch_to_sym_language_if_auto):
8674         Initialize m_lang in both cases.
8675
8676 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8677
8678         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8679         with XCNEW.
8680
8681 2019-01-22  Tom Tromey  <tom@tromey.com>
8682
8683         * corelow.c: Do not include sys/file.h.
8684
8685 2019-01-22  Tom Tromey  <tom@tromey.com>
8686
8687         * tui/tui-wingeneral.h: Include gdb_curses.h.
8688
8689 2019-01-22  Tom Tromey  <tom@tromey.com>
8690
8691         * source-cache.h (class source_cache) <get_source_lines,
8692         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8693
8694 2019-01-22  Tom Tromey  <tom@tromey.com>
8695
8696         * remote-fileio.h (struct remote_target): Declare.
8697
8698 2019-01-22  Tom Tromey  <tom@tromey.com>
8699
8700         * python/py-arch.c: Do not include py-ref.h.
8701         * python/py-bpevent.c: Do not include py-ref.h.
8702         * python/py-cmd.c: Do not include py-ref.h.
8703         * python/py-continueevent.c: Do not include py-ref.h.
8704         * python/py-event.h: Do not include py-ref.h.
8705         * python/py-evtregistry.c: Do not include py-ref.h.
8706         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8707         * python/py-frame.c: Do not include py-ref.h.
8708         * python/py-framefilter.c: Do not include py-ref.h.
8709         * python/py-function.c: Do not include py-ref.h.
8710         * python/py-infevents.c: Do not include py-ref.h.
8711         * python/py-linetable.c: Do not include py-ref.h.
8712         * python/py-objfile.c: Do not include py-ref.h.
8713         * python/py-param.c: Do not include py-ref.h.
8714         * python/py-prettyprint.c: Do not include py-ref.h.
8715         * python/py-progspace.c: Do not include py-ref.h.
8716         * python/py-symbol.c: Do not include py-ref.h.
8717         * python/py-symtab.c: Do not include py-ref.h.
8718         * python/py-type.c: Do not include py-ref.h.
8719         * python/py-unwind.c: Do not include py-ref.h.
8720         * python/py-utils.c: Do not include py-ref.h.
8721         * python/py-value.c: Do not include py-ref.h.
8722         * python/py-varobj.c: Do not include py-ref.h.
8723         * python/py-xmethods.c: Do not include py-ref.h.
8724         * python/python.c: Do not include py-ref.h.
8725         * varobj.c: Do not include py-ref.h.
8726
8727 2019-01-22  Tom Tromey  <tom@tromey.com>
8728
8729         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8730         keyword for bcache.
8731
8732 2019-01-22  Tom Tromey  <tom@tromey.com>
8733
8734         * compile/compile-cplus-types.c: Remove a comment by #include.
8735
8736 2019-01-22  Tom Tromey  <tom@tromey.com>
8737
8738         * compile/gcc-c-plugin.h: Include compile-internal.h.
8739
8740 2019-01-22  Tom Tromey  <tom@tromey.com>
8741
8742         * stabsread.c (EXTERN): Do not define.
8743         (symnum, next_symbol_text_func, processing_gcc_compilation)
8744         (within_function, global_sym_chain, global_stabs)
8745         (previous_stab_code, this_object_header_files)
8746         (n_this_object_header_files)
8747         (n_allocated_this_object_header_files): Define.
8748         * stabsread.h (EXTERN): Never define.  Use "extern".
8749
8750 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8751
8752         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8753         history_value.
8754
8755 2019-01-21  Tom Tromey  <tom@tromey.com>
8756
8757         * ui-out.c: Fix includes.
8758         * tui/tui-source.c: Fix includes.
8759         * target.c: Fix includes.
8760         * remote.c: Fix includes.
8761         * regcache.c: Fix includes.
8762         * python/py-block.c: Fix includes.
8763         * printcmd.c: Fix includes.
8764         * or1k-tdep.c: Fix includes.
8765         * mi/mi-main.c: Fix includes.
8766         * m32r-tdep.c: Fix includes.
8767         * csky-tdep.c: Fix includes.
8768         * compile/compile-cplus-types.c: Fix includes.
8769         * cli/cli-interp.c: Fix includes.
8770
8771 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8772
8773         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8774         for padding.
8775
8776 2019-01-16  Tom Tromey  <tom@tromey.com>
8777
8778         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8779         earlier.
8780         (struct objfile) <msymbols_range>: Move from top level.
8781         <msymbols>: New method.
8782         (class objfile_msymbols): Remove.
8783         * symtab.c (default_collect_symbol_completion_matches_break_on):
8784         Update.
8785         * symmisc.c (dump_msymbols): Update.
8786         * stabsread.c (scan_file_globals): Update.
8787         * objc-lang.c (info_selectors_command, info_classes_command)
8788         (find_methods): Update.
8789         * minsyms.c (find_solib_trampoline_target): Update.
8790         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8791         * coffread.c (coff_symfile_read): Update.
8792         * ada-lang.c (ada_lookup_simple_minsym)
8793         (ada_collect_symbol_completion_matches): Update.
8794
8795 2019-01-16  Tom Tromey  <tom@tromey.com>
8796
8797         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8798         type.  Remove no-argument constructor.
8799         <iterator::operator++>: Simplify.
8800         <begin>: Update.
8801         <end>: Use minimal_symbol_count.
8802
8803 2019-01-16  Tom Tromey  <tom@tromey.com>
8804
8805         * objfiles.h (struct objfile) <psymtabs>: New method.
8806         (class objfile_psymtabs): Remove.
8807         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8808         typedef.
8809         <range>: New method.
8810         (require_partial_symbols): Change return type.
8811         * psymtab.c (require_partial_symbols)
8812         (psym_expand_symtabs_matching): Update.
8813         * mdebugread.c (parse_partial_symbols): Update.
8814         * dbxread.c (dbx_end_psymtab): Update.
8815
8816 2019-01-15  Tom Tromey  <tom@tromey.com>
8817
8818         * symtab.c (lookup_objfile_from_block)
8819         (lookup_symbol_in_objfile_symtabs)
8820         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8821         (find_line_symtab, info_sources_command)
8822         (default_collect_symbol_completion_matches_break_on)
8823         (make_source_files_completion_list): Update.
8824         * symmisc.c (print_objfile_statistics, dump_objfile)
8825         (maintenance_print_symbols, maintenance_info_symtabs)
8826         (maintenance_check_symtabs, maintenance_info_line_tables):
8827         Update.
8828         * source.c (select_source_symtab)
8829         (forget_cached_source_info_for_objfile): Update.
8830         * objfiles.h (class objfile_compunits): Remove.
8831         (struct objfile) <compunits_range>: New typedef.
8832         (compunits): New method.
8833         * objfiles.c (objfile_relocate1): Update.
8834         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8835         * maint.c (count_symtabs_and_blocks): Update.
8836         * linespec.c (iterate_over_all_matching_symtabs): Update.
8837         * cp-support.c (add_symbol_overload_list_qualified): Update.
8838         * coffread.c (coff_symtab_read): Update.
8839         * ada-lang.c (add_nonlocal_symbols)
8840         (ada_collect_symbol_completion_matches)
8841         (ada_add_global_exceptions): Update.
8842
8843 2019-01-15  Tom Tromey  <tom@tromey.com>
8844
8845         * progspace.h (program_space) <objfiles_safe_range>: New
8846         typedef.
8847         <objfiles_safe>: New method.
8848         * objfiles.h (class all_objfiles_safe): Remove.
8849         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8850         * jit.c (jit_inferior_exit_hook): Update.
8851
8852 2019-01-17  Tom Tromey  <tom@tromey.com>
8853
8854         * progspace.h (program_space) <objfiles_range>: New typedef.
8855         <objfiles>: New method.
8856         <objfiles_head>: Rename from objfiles.
8857         (object_files): Update.
8858         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8859         * guile/scm-pretty-print.c
8860         (ppscm_find_pretty_printer_from_objfiles): Update.
8861         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8862         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8863         Update.
8864         * python/py-progspace.c (pspy_get_objfiles): Update.
8865         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8866         Update.
8867         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8868         (objfpy_lookup_objfile_by_build_id): Update.
8869         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8870         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8871         Update.
8872         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8873         (expand_symtab_containing_pc, lookup_objfile_from_block)
8874         (lookup_static_symbol, basic_lookup_transparent_type)
8875         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8876         (find_line_symtab, info_sources_command)
8877         (default_collect_symbol_completion_matches_break_on)
8878         (make_source_files_completion_list, find_main_name): Update.
8879         * symmisc.c (print_symbol_bcache_statistics)
8880         (print_objfile_statistics, maintenance_print_symbols)
8881         (maintenance_print_msymbols, maintenance_print_objfiles)
8882         (maintenance_info_symtabs, maintenance_check_symtabs)
8883         (maintenance_expand_symtabs, maintenance_info_line_tables):
8884         Update.
8885         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8886         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8887         (map_overlay_command, unmap_overlay_command)
8888         (simple_overlay_update, expand_symtabs_matching)
8889         (map_symbol_filenames): Update.
8890         * symfile-debug.c (set_debug_symfile): Update.
8891         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8892         Update.
8893         * source.c (select_source_symtab, forget_cached_source_info):
8894         Update.
8895         * solib.c (solib_read_symbols): Update.
8896         * solib-spu.c (append_ocl_sos): Update.
8897         * psymtab.c (maintenance_print_psymbols)
8898         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8899         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8900         * printcmd.c (info_symbol_command): Update.
8901         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8902         Update.
8903         * objfiles.h (class all_objfiles): Remove.
8904         * objfiles.c (have_partial_symbols, have_full_symbols)
8905         (have_minimal_symbols, qsort_cmp, update_section_map)
8906         (shared_objfile_contains_address_p)
8907         (default_iterate_over_objfiles_in_search_order): Update.
8908         * objc-lang.c (info_selectors_command, info_classes_command)
8909         (find_methods): Update.
8910         * minsyms.c (find_solib_trampoline_target): Update.
8911         * maint.c (maintenance_info_sections)
8912         (maintenance_translate_address, count_symtabs_and_blocks):
8913         Update.
8914         * main.c (captured_main_1): Update.
8915         * linux-thread-db.c (try_thread_db_load_from_pdir)
8916         (has_libpthread): Update.
8917         * linespec.c (iterate_over_all_matching_symtabs)
8918         (search_minsyms_for_name): Update.
8919         * jit.c (jit_find_objf_with_entry_addr): Update.
8920         * hppa-tdep.c (find_unwind_entry)
8921         (hppa_lookup_stub_minimal_symbol): Update.
8922         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8923         Update.
8924         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8925         (elf_gnu_ifunc_resolve_by_got): Update.
8926         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8927         * dwarf-index-write.c (save_gdb_index_command): Update.
8928         * cp-support.c (add_symbol_overload_list_qualified): Update.
8929         * breakpoint.c (create_overlay_event_breakpoint)
8930         (create_longjmp_master_breakpoint)
8931         (create_std_terminate_master_breakpoint)
8932         (create_exception_master_breakpoint): Update.
8933         * blockframe.c (find_pc_partial_function): Update.
8934         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8935         (ada_collect_symbol_completion_matches)
8936         (ada_add_global_exceptions): Update.
8937
8938 2019-01-17  Tom Tromey  <tom@tromey.com>
8939
8940         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8941         declare VEC.
8942         (solib_target_parse_libraries): Change return type.
8943         (library_list_start_segment, library_list_start_section)
8944         (library_list_end_library, library_list_start_library); Update.
8945         (solib_target_free_library_list): Remove.
8946         (solib_target_parse_libraries): Remove cleanup.  Change return
8947         type.
8948         (solib_target_current_sos): Update.
8949
8950 2019-01-17  Tom Tromey  <tromey@bapiya>
8951
8952         * valprint.c: Replace "the the" with "the".
8953         * symtab.c: Replace "the the" with "the".
8954         * solib.c: Replace "the the" with "the".
8955         * solib-dsbt.c: Replace "the the" with "the".
8956         * linespec.c: Replace "the the" with "the".
8957         * dwarf2loc.h: Replace "the the" with "the".
8958         * amd64-windows-tdep.c: Replace "the the" with "the".
8959         * aarch64-tdep.c: Replace "the the" with "the".
8960
8961 2019-01-16  Keith Seitz  <keiths@redhat.com>
8962
8963         PR gdb/23773
8964         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8965         <builder>: Rename to ..
8966         <m_builder>: ... this and make private.
8967         (dwarf2_cu::get_builder): New method.  Change all users of
8968         `builder' to use this method.
8969         (dwarf2_start_symtab): Move to ...
8970         (dwarf2_cu::start_symtab): ... here.  Update all callers
8971         (setup_type_unit_groups): Move to ...
8972         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8973         callers.
8974         (dwarf2_cu::reset_builder): New method.
8975         (process_full_compunit, process_full_type_unit): Use
8976         dwarf2_cu::reset_builder.
8977         (follow_die_offset): Record the ancestor CU if it is different
8978         from the followed DIE's CU.
8979         (follow_die_sig_1): Likewise.
8980
8981 2019-01-15  Tom Tromey  <tom@tromey.com>
8982
8983         * remote.c (class remote_state) <buf>: Now a char_vector.
8984         <buf_size>: Remove.
8985         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8986         parameter.
8987         (remote_target::getpkt_or_notif_sane_1)
8988         (remote_target::getpkt_sane)
8989         (remote_target::getpkt_or_notif_sane): Likewise.
8990         (class remote_target) <putpkt>: New overload.
8991         (remote_target::read_frame): Change type of "buf_p".  Remove
8992         sizeof_p parameter.
8993         (packet_ok): New overload.
8994         (packet_check_result): New overload.
8995         Update all uses.
8996
8997 2019-01-14  Tom Tromey  <tom@tromey.com>
8998
8999         * remote-notif.c (handle_notification, remote_notif_ack)
9000         (remote_notif_parse): Make "buf" const.
9001         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9002         const.
9003         (remote_notif_parse, remote_notif_ack, handle_notification):
9004         Likewise.
9005         * remote.c (remote_notif_stop_parse): Make "buf" const.
9006         (remote_target::remote_parse_stop_reply): Make "buf" const.
9007         (remote_notif_stop_ack): Make "buf" const.
9008
9009 2019-01-14  Tom Tromey  <tom@tromey.com>
9010
9011         * remote.c (remote_console_output): Make parameter const.
9012
9013 2019-01-14  Tom Tromey  <tom@tromey.com>
9014
9015         * target-debug.h (target_debug_print_signals): Constify.
9016         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9017         * procfs.c (procfs_target::pass_signals): Update.
9018         * linux-nat.c (linux_nat_target::pass_signals): Update.
9019         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9020         * target-delegates.c: Rebuild.
9021         * remote.c (remote_target::program_signals): Update.
9022         (remote_target::pass_signals): Update.
9023         * target.c (target_pass_signals): Constify argument.
9024         (target_program_signals): Likewise.
9025         * target.h (struct target_ops) <pass_signals, program_signals>:
9026         Constify argument.
9027         (target_pass_signals, target_program_signals): Constify argument.
9028
9029 2019-01-14  Tom Tromey  <tom@tromey.com>
9030
9031         PR tui/28819:
9032         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9033
9034 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9035
9036         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9037         field.
9038         * rs6000-tdep.c: Include reggroups.h.
9039         (IS_V_ALIAS_PSEUDOREG): Define.
9040         (rs6000_register_name): Return names for the "vX" aliases.
9041         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9042         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9043         aliases.  Call default_register_reggroup_p for all other
9044         pseudo-registers.
9045         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9046         New functions.
9047         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9048         Handle "vX" aliases.
9049         (v_alias_pseudo_register_collect): New function.
9050         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9051         (rs6000_gdbarch_init): Initialize "vX" aliases as
9052         pseudo-registers.  Restore registration of
9053         rs6000_pseudo_register_reggroup_p with
9054         set_tdesc_pseudo_register_reggroup_p.
9055
9056 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9057
9058         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9059         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9060         set_gdbarch_num_pseudo_regs.
9061
9062 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9063
9064         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9065         Remove arg prefixname, add do_set and do_show.
9066         Add member functions set_list and show_list.
9067         * cli/cli-style.c (class cli_style_option): Update accordingly.
9068         (style_set_list): Move to file scope.
9069         (style_show_list): Likewise.
9070         (set_style): Call help_list.
9071         (show_style): Call cmd_show_list.
9072         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9073         Update to use the new macro.
9074
9075 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9076
9077         * ada-lang.c (_initialize_ada_language): Expand the help text
9078         for the "catch exception" command.
9079
9080 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9081
9082         * symtab.c (matching_obj_sections): Initialize obj,
9083         declare it closer to its usage.
9084
9085 2019-01-10  Tom Tromey  <tom@tromey.com>
9086
9087         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9088         (basic_inf_threads_range): Remove.
9089         (inf_threads_range, inf_non_exited_threads_range)
9090         (safe_inf_threads_range): Use next_adapter.
9091
9092 2019-01-10  Keith Seitz  <keiths@redhat.com>
9093
9094         PR gdb/23712
9095         PR symtab/23010
9096         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9097         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9098
9099 2019-01-10  Keith Seitz  <keiths@redhat.com>
9100
9101         PR gdb/23712
9102         PR symtab/23010
9103         * dictionary.c (pending_to_vector): Remove.
9104         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9105         Remove _1 suffix, replacing functions of the same name.  Update
9106         all callers.
9107         (dict_create_hashed, dict_create_hashed_expandable)
9108         (dict_create_linear, dict_create_linear_expandable, dict_free)
9109         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9110         Make functions static.
9111
9112 2019-01-10  Keith Seitz  <keiths@redhat.com>
9113
9114         PR gdb/23712
9115         PR symtab/23010
9116         * dictionary.h (struct dictionary): Replace declaration with
9117         multidictionary.
9118         (dict_create_hashed, dict_create_hashed_expandable)
9119         (dict_create_linear, dict_create_linear_expandable)
9120         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9121         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9122         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9123         taking multidictionary argument.
9124         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9125         * block.h (struct block) <dict>: Change to multidictionary
9126         and rename `multidict'.
9127         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9128         symmisc.c: Update all dictionary references to multidictionary.
9129
9130 2019-01-10  Keith Seitz  <keiths@redhat.com>
9131
9132         PR gdb/23712
9133         PR symtab/23010
9134         * dictionary.c: Include unordered_map.
9135         (pending_to_vector): New function.
9136         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9137         Rewrite the non-"_1" functions to take vector instead
9138         of linked list.
9139         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9140         "new" _1 versions of the same name.
9141         (multidictionary): Define.
9142         (std::hash<enum language): New definition.
9143         (collate_pending_symbols_by_language, mdict_create_hashed)
9144         (mdict_create_hashed_expandable, mdict_create_linear)
9145         (mdict_create_linear_expandable, mdict_free)
9146         (find_language_dictionary, create_new_language_dictionary)
9147         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9148         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9149         (mdict_size, mdict_empty): New functions.
9150         * dictionary.h (mdict_iterator): Define.
9151
9152 2019-01-10  Pedro Alves  <palves@redhat.com>
9153
9154         * breakpoint.c (read_uploaded_action)
9155         (create_tracepoint_from_upload): Adjust to use
9156         gdb::unique_xmalloc_ptr.
9157         * ctf.c (ctf_write_uploaded_tp):
9158         (SET_ARRAY_FIELD): Use emplace_back.
9159         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9160         * tracefile-tfile.c (tfile_write_uploaded_tp):
9161         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9162         gdb::unique_xmalloc_ptr.
9163         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9164         at_string, cond_string, cmd_strings>: Replace char pointers
9165         with gdb::unique_xmalloc_ptr.
9166
9167 2019-01-10  Pedro Alves  <palves@redhat.com>
9168
9169         * solib-target.c (library_list_start_library): Don't xstrdup name.
9170
9171 2019-01-10  Pedro Alves  <palves@redhat.com>
9172
9173         * mdebugread.c (parse_partial_symbols): Use
9174         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9175
9176 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9177
9178         * linux-fork.c (scoped_switch_fork_info)
9179         <~scoped_switch_fork_info>: Fix incorrect variable name.
9180
9181 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9182
9183         * linux-fork.c (scoped_switch_fork_info)
9184         <scoped_switch_fork_info>: Make explicit.
9185         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9186
9187 2019-01-10  Tom Tromey  <tom@tromey.com>
9188
9189         * objfiles.h (objfile::reset_psymtabs): Update.
9190         * objfiles.c (objfile::objfile): Update.
9191         * psymtab.h (psymtab_storage::obstack): Update.
9192         (psymtab_storage::m_obstack): Use gdb::optional.
9193         (class psymtab_storage): Update comment.  Remove objfile
9194         parameter.
9195         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9196
9197 2019-01-10  Tom Tromey  <tom@tromey.com>
9198
9199         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9200         <free_psymtabs>: Now private.
9201         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9202         (allocate_psymtab): Use new method.
9203
9204 2019-01-10  Tom Tromey  <tom@tromey.com>
9205
9206         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9207         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9208         * mdebugread.c (parse_partial_symbols): Use
9209         allocate_dependencies.
9210         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9211         allocate_dependencies.
9212         (process_psymtab_comp_unit_reader)
9213         (build_type_psymtab_dependencies): Likewise.
9214         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9215
9216 2019-01-10  Tom Tromey  <tom@tromey.com>
9217
9218         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9219         PSYMBOL_SET_LANGUAGE.
9220         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9221
9222 2019-01-10  Tom Tromey  <tom@tromey.com>
9223
9224         * psymtab.h (psymtab_storage::obstack): New method.
9225         <m_obstack>: Rename from obstack; now private.
9226         * psymtab.c (psymtab_storage): Update.
9227         * dwarf2read.c (create_addrmap_from_index)
9228         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9229         Update.
9230
9231 2019-01-10  Tom Tromey  <tom@tromey.com>
9232
9233         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9234         * objfiles.h (objfile::reset_psymtabs): New method.
9235
9236 2019-01-10  Tom Tromey  <tom@tromey.com>
9237
9238         * symmisc.c (print_symbol_bcache_statistics): Update.
9239         (print_objfile_statistics): Update.
9240         * symfile.c (reread_symbols): Update.
9241         * psymtab.h (class psymtab_storage): New.
9242         * psymtab.c (psymtab_storage): New constructor.
9243         (~psymtab_storage): New destructor.
9244         (require_partial_symbols): Update.
9245         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9246         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9247         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9248         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9249         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9250         (start_psymtab_common, end_psymtab_common)
9251         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9252         (allocate_psymtab): Update.
9253         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9254         Update.
9255         (dump_psymtab_addrmap, maintenance_print_psymbols)
9256         (maintenance_check_psymtabs): Update.
9257         (class objfile_psymtabs): Move to objfiles.h.
9258         * psympriv.h (discard_psymtab): Now inline.
9259         (psymtab_discarder::psymtab_discarder): Update.
9260         (psymtab_discarder::~psymtab_discarder): Update.
9261         (ALL_OBJFILE_PSYMTABS): Rewrite.
9262         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9263         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9264         Remove fields.
9265         <partial_symtabs>: New field.
9266         (class objfile_psymtabs): Move from psymtab.h.  Update.
9267         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9268         psymbol_cache.
9269         (objfile::~objfile): Don't destroy psymbol_cache.
9270         * mdebugread.c (parse_partial_symbols): Update.
9271         * dwarf2read.c (create_addrmap_from_index)
9272         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9273         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9274         (add_partial_subprogram, dwarf2_ranges_read): Update.
9275         * dwarf-index-write.c (write_address_map)
9276         (write_one_signatured_type, recursively_write_psymbols)
9277         (class debug_names, class debug_names, write_psymtabs_to_index):
9278         Update.
9279
9280 2019-01-10  Tom Tromey  <tom@tromey.com>
9281
9282         * symtab.h (SYMBOL_SET_NAMES): Update.
9283         (symbol_set_names): Update.
9284         (MSYMBOL_SET_NAMES): Update.
9285         * symtab.c (symbol_set_names): Change argument to be an
9286         objfile_per_bfd_storage.
9287         * psymtab.c (add_psymbol_to_bcache): Update.
9288         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9289
9290 2019-01-10  Tom Tromey  <tom@tromey.com>
9291
9292         * symtab.c (create_demangled_names_hash): Change argument to be an
9293         objfile_per_bfd_storage.
9294         (symbol_set_names): Update.
9295
9296 2019-01-10  Tom Tromey  <tom@tromey.com>
9297
9298         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9299         init_psymbol_list.
9300         * psymtab.c (init_psymbol_list): Do nothing if already called.
9301         * psympriv.h (init_psymbol_list): Add comment.
9302         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9303         init_psymbol_list.
9304         * dbxread.c (dbx_symfile_read): Unconditionally call
9305         init_psymbol_list.
9306
9307 2019-01-10  Tom Tromey  <tom@tromey.com>
9308
9309         * xcoffread.c (scan_xcoff_symtab): Update.
9310         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9311         "where".
9312         * mdebugread.c (parse_partial_symbols)
9313         (handle_psymbol_enumerators): Update.
9314         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9315         * dbxread.c (read_dbx_symtab): Update.
9316         * psympriv.h (psymbol_placement): New enum.
9317         (add_psymbol_to_list): Update.
9318
9319 2019-01-10  Tom Tromey  <tom@tromey.com>
9320
9321         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9322         static_psymbols parameters.
9323         (scan_xcoff_symtab): Update.
9324         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9325         static_psymbols parameters.
9326         * psympriv.h (start_psymtab_common): Update.
9327         * mdebugread.c (parse_partial_symbols): Update.
9328         * dwarf2read.c (create_partial_symtab): Update.
9329         * dbxread.c (read_dbx_symtab): Update.
9330         (start_psymtab): Remove global_psymbols and static_psymbols
9331         parameters.
9332
9333 2019-01-10  Tom Tromey  <tom@tromey.com>
9334
9335         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9336         * psymtab.c (allocate_psymtab): Add comment.
9337         * psympriv.h (allocate_psymtab): Add comment.
9338         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9339         initializations.
9340         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9341
9342 2019-01-10  Tom Tromey  <tom@tromey.com>
9343
9344         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9345         Don't declare.
9346         * mipsread.c: Include mdebugread.h.
9347         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9348         Declare.
9349         * elfread.c: Include mdebugread.h.
9350
9351 2019-01-09  Tom Tromey  <tom@tromey.com>
9352
9353         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9354         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9355         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9356         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9357         (psym_lookup_symbol, psym_find_last_source_symtab)
9358         (psym_forget_cached_source_info, psym_print_stats)
9359         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9360         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9361         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9362         (psym_find_compunit_symtab_by_address)
9363         (maintenance_print_psymbols, maintenance_info_psymtabs)
9364         (maintenance_check_psymtabs): Use ranged for.
9365         * psymtab.h (class objfile_psymtabs): New.
9366         (require_partial_symbols): Return objfile_psymtabs.
9367         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9368
9369 2019-01-09  Tom Tromey  <tom@tromey.com>
9370
9371         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9372         (find_pc_mapped_section, list_overlays_command)
9373         (map_overlay_command, unmap_overlay_command)
9374         (simple_overlay_update): Use all_objfiles.
9375         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9376         * printcmd.c (info_symbol_command): Use all_objfiles.
9377         * objfiles.h (ALL_OBJSECTIONS): Remove.
9378         * maint.c (maintenance_translate_address): Use all_objfiles.
9379         * gcore.c (gcore_create_callback): Use all_objfiles.
9380         (objfile_find_memory_regions): Likewise.
9381
9382 2019-01-09  Tom Tromey  <tom@tromey.com>
9383
9384         * symtab.c (find_line_symtab, info_sources_command)
9385         (make_source_files_completion_list): Use objfile_compunits.
9386         * source.c (select_source_symtab): Use objfile_compunits.
9387         * objfiles.h (struct objfile): Update comment.
9388         (ALL_OBJFILES): Remove.
9389         (ALL_FILETABS): Remove.
9390         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9391         objfile_compunits.
9392
9393 2019-01-09  Tom Tromey  <tom@tromey.com>
9394
9395         * symmisc.c (print_objfile_statistics, dump_objfile)
9396         (maintenance_print_symbols): Use compunit_filetabs.
9397         * source.c (forget_cached_source_info_for_objfile): Use
9398         compunit_filetabs.
9399         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9400         (ALL_FILETABS): Use compunit_filetabs.
9401         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9402         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9403
9404 2019-01-09  Tom Tromey  <tom@tromey.com>
9405
9406         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9407         (compunit_filetabs): New.
9408         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9409         compunit_filetabs.
9410         (info_sources_command, make_source_files_completion_list): Remove
9411         declaration.
9412         * symmisc.c (print_objfile_statistics, dump_objfile)
9413         (maintenance_print_symbols): Remove declaration.
9414         (maintenance_info_symtabs): Use compunit_filetabs.
9415         (maintenance_info_line_tables): Likewise.
9416         * source.c (select_source_symtab): Change local variable name.
9417         (forget_cached_source_info_for_objfile): Remove declaration.
9418         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9419         * objfiles.c (objfile_relocate1): Remove declaration.
9420         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9421         declaration.
9422         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9423         * coffread.c (coff_symtab_read): Remove declaration.
9424         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9425         compunit_filetabs.
9426
9427 2019-01-09  Tom Tromey  <tom@tromey.com>
9428
9429         * symtab.c (lookup_objfile_from_block)
9430         (find_pc_sect_compunit_symtab, search_symbols)
9431         (default_collect_symbol_completion_matches_break_on): Use
9432         objfile_compunits.
9433         * objfiles.h (ALL_COMPUNITS): Remove.
9434         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9435         * cp-support.c (add_symbol_overload_list_qualified): Use
9436         objfile_compunits.
9437         * ada-lang.c (ada_collect_symbol_completion_matches)
9438         (ada_add_global_exceptions): Use objfile_compunits.
9439
9440 2019-01-09  Tom Tromey  <tom@tromey.com>
9441
9442         * source.c (select_source_symtab)
9443         (forget_cached_source_info_for_objfile): Remove declaration.
9444         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9445         declaration.
9446         * maint.c (count_symtabs_and_blocks): Remove declaration.
9447         * cp-support.c (add_symbol_overload_list_qualified): Remove
9448         declaration.
9449         * coffread.c (coff_symtab_read): Remove declaration.
9450         * symtab.c (lookup_symbol_in_objfile_symtabs)
9451         (basic_lookup_transparent_type_1): Use objfile_compunits.
9452         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9453         (info_sources_command, search_symbols)
9454         (default_collect_symbol_completion_matches_break_on)
9455         (make_source_files_completion_list): Remove declaration.
9456         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9457         (ada_collect_symbol_completion_matches)
9458         (ada_add_global_exceptions): Remove declaration.
9459         * linespec.c (iterate_over_all_matching_symtabs): Use
9460         objfile_compunits.
9461         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9462         (class objfile_compunits): New.
9463         (ALL_COMPUNITS): Use objfile_compunits.
9464         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9465         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9466         objfile_compunits.
9467         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9468
9469 2019-01-09  Tom Tromey  <tom@tromey.com>
9470
9471         * symtab.c (search_symbols)
9472         (default_collect_symbol_completion_matches_break_on): Use
9473         objfile_msymbols.
9474         * ada-lang.c (ada_lookup_simple_minsym)
9475         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9476         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9477         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9478         objfile_msymbols.
9479         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9480         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9481         * objc-lang.c (find_methods): Use objfile_msymbols.
9482         (info_selectors_command, info_classes_command): Likewise.
9483         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9484         * objfiles.h (class objfile_msymbols): New.
9485         (ALL_OBJFILE_MSYMBOLS): Remove.
9486         (ALL_MSYMBOLS): Remove.
9487
9488 2019-01-09  Tom Tromey  <tom@tromey.com>
9489
9490         * common/next-iterator.h (next_adapter): Add Iterator template
9491         parameter.
9492         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9493         (class all_objfiles_safe): New.
9494         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9495         * objfiles.c (put_objfile_before): Update comment.
9496         (add_separate_debug_objfile): Likewise.
9497         (free_all_objfiles): Use all_objfiles_safe.
9498         (objfile_purge_solibs): Likewise.
9499
9500 2019-01-09  Tom Tromey  <tom@tromey.com>
9501
9502         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9503         (expand_symtab_containing_pc, lookup_static_symbol)
9504         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9505         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9506         all_objfiles.
9507         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9508         * breakpoint.c (create_overlay_event_breakpoint)
9509         (create_longjmp_master_breakpoint)
9510         (create_std_terminate_master_breakpoint)
9511         (create_exception_master_breakpoint): Use all_objfiles.
9512         * linux-thread-db.c (try_thread_db_load_from_pdir)
9513         (has_libpthread): Use all_objfiles.
9514         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9515         * linespec.c (iterate_over_all_matching_symtabs)
9516         (search_minsyms_for_name): Use all_objfiles.
9517         * maint.c (maintenance_info_sections): Use all_objfiles.
9518         * main.c (captured_main_1): Use all_objfiles.
9519         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9520         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9521         * guile/scm-pretty-print.c
9522         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9523         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9524         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9525         (maintenance_print_msymbols): Use all_objfiles.
9526         * source.c (select_source_symtab): Use all_objfiles.
9527         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9528         * symfile.c (remove_symbol_file_command)
9529         (expand_symtabs_matching, map_symbol_filenames): Use
9530         all_objfiles.
9531         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9532         all_objfiles.
9533         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9534         * objc-lang.c (find_methods): Use all_objfiles.
9535         * objfiles.c (have_partial_symbols, have_full_symbols)
9536         (have_minimal_symbols, qsort_cmp)
9537         (default_iterate_over_objfiles_in_search_order): Use
9538         all_objfiles.
9539         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9540         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9541         (maintenance_check_psymtabs): Use all_objfiles.
9542         (ALL_PSYMTABS): Remove.
9543         * compile/compile-object-run.c (do_module_cleanup): Use
9544         all_objfiles.
9545         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9546         * cp-support.c (add_symbol_overload_list_qualified): Use
9547         all_objfiles.
9548         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9549         Use all_objfiles.
9550         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9551         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9552         all_objfiles.
9553         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9554         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9555         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9556         Uses all_objfiles.
9557         * solib.c (solib_read_symbols): Use all_objfiles
9558
9559 2019-01-09  Tom Tromey  <tom@tromey.com>
9560
9561         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9562         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9563         all_objfiles.
9564         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9565         * symmisc.c (print_symbol_bcache_statistics)
9566         (print_objfile_statistics, maintenance_print_objfiles)
9567         (maintenance_info_symtabs, maintenance_check_symtabs)
9568         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9569         all_objfiles.
9570         * source.c (forget_cached_source_info): Use all_objfiles.
9571         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9572         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9573         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9574         * objfiles.c (update_section_map): Use all_objfiles.
9575         (shared_objfile_contains_address_p): Likewise.
9576         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9577         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9578
9579 2019-01-09  Tom Tromey  <tom@tromey.com>
9580
9581         * common/next-iterator.h: New file.
9582         * objfiles.h (class all_objfiles): New.
9583         (struct objfile_iterator): New.
9584
9585 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9586
9587         * NEWS: Move the description of the changed "frame", "select-frame",
9588          and "info frame" commands to the Changed commands section.
9589
9590 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9591
9592         * gdbtypes.c (check_stub_method_group): Remove handling of old
9593         mangling schemes.
9594         * linespec.c (find_methods): Likewise.
9595         * stabsread.c (read_member_functions): Likewise.
9596         * valops.c (search_struct_method): Likewise.
9597         (value_struct_elt_for_reference): Likewise.
9598         * NEWS: Mention this change.
9599
9600 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9601
9602         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9603         print_source_lines.
9604         * source.c (print_source_lines_base): Update line number check.
9605         (print_source_lines): New function.
9606         (source_lines_range::source_lines_range): New function.
9607         * source.h (class source_lines_range): New class.
9608         (print_source_lines): New declaration.
9609
9610 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9611
9612         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9613
9614 2019-01-08  Tom Tromey  <tom@tromey.com>
9615             Simon Marchi  <simon.marchi@ericsson.com>
9616
9617         PR gdb/24060
9618         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9619         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9620         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9621         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9622         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9623         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9624
9625 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9626
9627         * source.c (select_source_symtab): Move header comment to
9628         declaration in source.h.
9629         (forget_cached_source_info_for_objfile): Likewise.
9630         (forget_cached_source_info): Likewise.
9631         (identify_source_line): Likewise.
9632         * source.h (identify_source_line): Move declaration from symtab.h
9633         and add comment from source.c
9634         (print_source_lines): Likewise.
9635         (forget_cached_source_info_for_objfile): Likewise.
9636         (forget_cached_source_info): Likewise.
9637         (select_source_symtab): Likewise.
9638         (enum print_source_lines_flag): Move definition from symtab.h.
9639         * symtab.h (identify_source_line): Move declaration to source.h.
9640         (print_source_lines): Likewise.
9641         (forget_cached_source_info_for_objfile): Likewise.
9642         (forget_cached_source_info): Likewise.
9643         (select_source_symtab): Likewise.
9644         (enum print_source_lines_flag): Move definition to source.h.
9645         * tui/tui-hooks.c: Add 'source.h' include.
9646
9647 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9648
9649         * source.c (print_source_lines_base): Handle requests to print
9650         reverse line number sequences, and guard against empty lines
9651         string.
9652
9653 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9654
9655         * source.c (print_source_lines_base): Fix skip of '\r' if next
9656         character is '\n'.
9657
9658 2019-01-06  Tom Tromey  <tom@tromey.com>
9659
9660         * c-exp.y (struct c_parse_state) <macro_original_text,
9661         expansion_obstack>: New member.
9662         (macro_original_text, expansion_obstack): Remove globals.
9663         (scan_macro_expansion, scanning_macro_expansion)
9664         (finished_macro_expansion): Update.
9665         (scan_macro_cleanup): Remove.
9666         (yylex, c_parse): Update.
9667
9668 2019-01-06  Tom Tromey  <tom@tromey.com>
9669
9670         * c-exp.y (struct c_parse_state) <strings>: New member.
9671         (operator_stoken): Update.
9672
9673 2019-01-06  Tom Tromey  <tom@tromey.com>
9674
9675         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9676         (union type_stack_elt) <typelist_val>: Now a pointer to
9677         std::vector.
9678         (type_stack_cleanup): Don't declare.
9679         (push_typelist): Update.
9680         * parse.c (pop_typelist): Return a std::vector.
9681         (push_typelist): Take a std::vector.
9682         (follow_types): Update.  Do not free args.
9683         (type_stack_cleanup): Remove.
9684         * c-exp.y (struct c_parse_state): New.
9685         (cpstate): New global.
9686         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9687         (nonempty_typelist): Update.
9688         (func_mod): Create a new vector.
9689         (c_parse): Create a c_parse_state.
9690         (check_parameter_typelist): Do not delete params.
9691         (function_method): Update.  Do not delete type_list.
9692
9693 2019-01-06  Tom Tromey  <tom@tromey.com>
9694
9695         PR gdb/28155:
9696         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9697         check_typedef.
9698         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9699         (print_return_value): Likewise.
9700
9701 2019-01-05  Tom Tromey  <tom@tromey.com>
9702
9703         * contrib/cleanup_check.py: Remove.
9704         * contrib/gcc-with-excheck: Remove.
9705         * contrib/exsummary.py: Remove.
9706         * contrib/excheck.py: Remove.
9707
9708 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9709
9710         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9711         NULL. Initialize tpprev to NULL instead of assigning it
9712         to NULL on the next statement.
9713         * windows-nat.c (windows_delete_thread): Remove check for
9714         main_thread_id before printing thread exit notifications.
9715         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9716         Remove thread ID check against main_thread_id.
9717         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9718         windows_delete_thread.
9719         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9720
9721 2019-01-04  Tom Tromey  <tom@tromey.com>
9722
9723         * compile/compile.c (_initialize_compile): Use upper case for
9724         metasyntactic variables.
9725         * symmisc.c (_initialize_symmisc): Use upper case for
9726         metasyntactic variables.
9727         * psymtab.c (_initialize_psymtab): Use upper case for
9728         metasyntactic variables.
9729         * demangle.c (demangle_command): Use upper case for metasyntactic
9730         variables.
9731         (_initialize_demangler): Likewise.
9732         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9733         variables.
9734
9735 2019-01-03  Tom Tromey  <tom@tromey.com>
9736
9737         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9738
9739 2019-01-03  Tom Tromey  <tom@tromey.com>
9740
9741         * python/py-symtab.c (salpy_str): Update.
9742         (struct salpy_sal_object) <symtab>: Now a PyObject.
9743         (salpy_dealloc): Update.
9744         (del_objfile_sal): Use gdbpy_ref.
9745
9746 2019-01-03  Tom Tromey  <tom@tromey.com>
9747
9748         * python/py-type.c (convert_field): Use new_reference.  Return
9749         gdbpy_ref.
9750         (make_fielditem): Return gdbpy_ref.
9751         (typy_fields): Update.
9752         (typy_getitem): Update.
9753         (field_name): Return gdbpy_ref.  Use new_reference.
9754         (typy_iterator_iternext): Update.
9755
9756 2019-01-03  Tom Tromey  <tom@tromey.com>
9757
9758         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9759
9760 2019-01-03  Tom Tromey  <tom@tromey.com>
9761
9762         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9763         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9764         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9765         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9766         (pspy_set_type_printers): Likewise.
9767         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9768         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9769         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9770         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9771         (objfpy_set_type_printers): Likewise.
9772
9773 2019-01-03  Tom Tromey  <tom@tromey.com>
9774
9775         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9776         (gdbpy_print_stack): Use gdbpy_err_fetch.
9777         * python/python-internal.h (class gdbpy_err_fetch): New class.
9778         (class gdbpy_enter) <m_error_type, m_error_value,
9779         m_error_traceback>: Remove.
9780         <m_error>: New member.
9781         (gdbpy_exception_to_string): Don't declare.
9782         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9783         * python/py-value.c (convert_value_from_python): Use
9784         gdbpy_err_fetch.
9785         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9786         gdbpy_exception_to_string.
9787         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9788         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9789         gdbpy_err_fetch.
9790
9791 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9792
9793         * linux-nat.c (delete_lwp_cleanup): Delete.
9794         (struct lwp_deleter): New struct.
9795         (lwp_info_up): New typedef.
9796         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9797         lwp_info_up.
9798
9799 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9800
9801         * linux-fork.c (class scoped_switch_fork_info): New class.
9802         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9803
9804 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9805
9806         * valops.c (find_overload_match): Remove use of null_cleanup, and
9807         calls to do_cleanups.
9808
9809 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9810
9811         * compile/compile-cplus-types.c
9812         (compile_cplus_instance::decl_name): Handle changes to
9813         cp_func_name.
9814         * cp-support.c (cp_func_name): Update header comment, update
9815         return type.
9816         * cp-support.h (cp_func_name): Update return type in declaration.
9817         * valops.c (find_overload_match): Move temp_func local to top
9818         level of function and change its type.  Use temp_func to hold and
9819         delete temporary string obtained from cp_func_name.
9820
9821 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9822
9823         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9824         gdb::char_vector, remove cleanup, and update uses of `msg`.
9825
9826 2019-01-03  Jim Wilson  <jimw@sifive.com>
9827
9828         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9829
9830 2019-01-02  Tom Tromey  <tom@tromey.com>
9831
9832         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9833         (tdesc_parse_xml): Remove cleanups.
9834         * target-descriptions.h (make_cleanup_free_target_description):
9835         Don't declare.
9836         (target_desc_deleter): New struct.
9837         (target_desc_up): New typedef.
9838         * target-descriptions.c (target_desc_deleter::operator()): Rename
9839         from free_target_description.
9840         (make_cleanup_free_target_description): Remove.
9841
9842 2019-01-02  Tom Tromey  <tom@tromey.com>
9843
9844         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9845         constructor, destructor.
9846         (linespec_parser): Remove typedef.
9847         (~linespec_parser): Rename from linespec_parser_delete.
9848         (linespec_lex_to_end, linespec_complete_label)
9849         (linespec_complete): Update.
9850         (decode_line_full): Remove cleanups.
9851         (decode_line_1): Update.
9852
9853 2019-01-02  Tom Tromey  <tom@tromey.com>
9854
9855         * python/python-internal.h (inferior_to_inferior_object): Change
9856         return type.
9857         * python/py-exitedevent.c (create_exited_event_object): Update.
9858         * python/py-inferior.c (inferior_to_inferior_object): Return
9859         gdbpy_ref.
9860         (python_new_inferior, python_inferior_deleted)
9861         (thread_to_thread_object, delete_thread_object)
9862         (build_inferior_list, gdbpy_selected_inferior): Update.
9863         * python/py-infthread.c (create_thread_object): Update.  Also fail
9864         if inferior_to_inferior_object fails.
9865
9866 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9867
9868         * inferior.h (class inferior) <displaced_step_state>: New field.
9869         * infrun.h (struct displaced_step_state): Move here from
9870         infrun.c.  Initialize fields, add constructor.
9871         <inf>: Remove field.
9872         <reset>: New method.
9873         * infrun.c (struct displaced_step_inferior_state): Move to
9874         infrun.h.
9875         (displaced_step_inferior_states): Remove.
9876         (get_displaced_stepping_state): Adust.
9877         (displaced_step_in_progress_any_inferior): Adjust.
9878         (displaced_step_in_progress_thread): Adjust.
9879         (displaced_step_in_progress): Adjust.
9880         (add_displaced_stepping_state): Remove.
9881         (get_displaced_step_closure_by_addr): Adjust.
9882         (remove_displaced_stepping_state): Remove.
9883         (infrun_inferior_exit): Call displaced_step_state.reset.
9884         (use_displaced_stepping): Don't check for NULL.
9885         (displaced_step_prepare_throw): Call
9886         get_displaced_stepping_state.
9887         (displaced_step_fixup): Don't check for NULL.
9888         (prepare_for_detach): Don't check for NULL.
9889
9890 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9891
9892         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9893          in case of call that did not complete.
9894
9895 2019-01-02  Andrey Utkin  <autkin@undo.io>
9896
9897         * symfile.c (find_separate_debug_file): Fix search of debug files for
9898         remote debuggee.
9899
9900 2019-01-02  Tom Tromey  <tom@tromey.com>
9901
9902         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9903         indentation.
9904         * python/py-frame.c (frapy_older): Remove cast.
9905         (frapy_newer): Likewise.
9906         * python/py-breakpoint.c (local_setattro): Remove cast.
9907         * python/py-arch.c (archpy_name): Remove local variable.
9908         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9909
9910 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9911
9912         * unittests/basic_string_view/element_access/char/empty.cc:
9913         Fix year range in copyright header.
9914
9915 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9916
9917         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9918         Delete.
9919         <operator==>: Update with for removed field.
9920         <hash>: Likewise.
9921         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9922         <isa_features>: ...this.
9923         <abi_features>: New field.
9924         (riscv_isa_flen): Update comment.
9925         (riscv_abi_xlen): New declaration.
9926         (riscv_abi_flen): New declaration.
9927         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9928         isa_features.
9929         (riscv_abi_xlen): New function.
9930         (riscv_isa_flen): Update to get answer from isa_features.
9931         (riscv_abi_flen): New function.
9932         (riscv_has_fp_abi): Update to get answer from abi_features.
9933         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9934         xlen and flen.
9935         (riscv_call_info) <xlen, flen>: Update comment.
9936         (riscv_call_arg_struct): Remove invalid assertions
9937         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9938         is removed.
9939         (riscv_gdbarch_init): Gather isa features and abi features
9940         separately, ensure both match on the gdbarch when reusing an old
9941         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9942         a target with 64-bit float hardware.
9943
9944 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9945
9946         * source.c (search_command_helper): Stop reverse search
9947         when line 1 has been searched.
9948
9949 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9950
9951         * record-full.c (record_full_base_target::close): Rewrite
9952         record_full_core_buf_list free logic.
9953
9954 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9955
9956         * break-catch-syscall.c (print_one_catch_syscall): xfree
9957         the last text.
9958
9959 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9960
9961         * top.c (print_gdb_version): Update Copyright year in version
9962         message.
9963
9964 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9965
9966         Update copyright year range in all GDB files.
9967
9968 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9969
9970         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9971
9972 For older changes see ChangeLog-2018.
9973 \f
9974 Local Variables:
9975 mode: change-log
9976 left-margin: 8
9977 fill-column: 74
9978 version-control: never
9979 coding: utf-8
9980 End:
9981