Remove last reference to REMOTE_OBS
[external/binutils.git] / gdb / ChangeLog
1 2018-05-27  Tom Tromey  <tom@tromey.com>
2
3         * Makefile.in (DEPFILES): Don't reference REMOTE_OBS.
4
5 2018-05-25  Tom Tromey  <tom@tromey.com>
6
7         * value.c (value::location): Initialize.
8
9 2018-05-25  Tom Tromey  <tom@tromey.com>
10
11         * dbxread.c (init_bincl_list): Remove.
12         (bincl_list): Now a std::vector.
13         (bincls_allocated, next_bincl): Remove.
14         (free_bincl_list, do_free_bincl_list_cleanup)
15         (make_cleanup_free_bincl_list): Remove.
16         (dbx_read_symtab, elfstab_build_psymtabs): Use scoped_restore,
17         unique_xmalloc_ptr.
18         (find_corresponding_bincl_psymtab, read_dbx_symtab): Update.
19         (struct header_file_location): Add constructor.
20         (add_bincl_to_list): Remove.
21
22 2018-05-25  Tom Tromey  <tom@tromey.com>
23
24         * tui/tui.c (tui_enable): Update.
25         * mi/mi-interp.c (mi_interp::init): Update.
26         * interps.h (class interp) <name>: New method.
27         <m_name>: Rename from name.
28         (~scoped_restore_interp): Update.
29         * interps.c (interp::interp): Update.
30         (interp_add, interp_set, interp_lookup_existing)
31         (current_interp_named_p): Update.
32
33 2018-05-25  Tom Tromey  <tom@tromey.com>
34
35         * interps.c (interp_name): Remove.
36         * mi/mi-interp.c (mi_interp::init): Update.
37         * interps.h (interp_name): Remove.
38         (~scoped_restore_interp): Update.
39         * tui/tui.c (tui_enable): Update.
40
41 2018-05-25  Tom Tromey  <tom@tromey.com>
42
43         * utils.c (fputs_maybe_filtered): Update.
44         * linespec.c (decode_line_full): Update.
45         * mi/mi-interp.c (mi_on_normal_stop_1, mi_tsv_modified)
46         (mi_print_breakpoint_for_event, mi_solib_loaded)
47         (mi_solib_unloaded, mi_command_param_changed, mi_memory_changed)
48         (mi_user_selected_context_changed): Update.
49         * mi/mi-main.c (mi_execute_command): Update.
50         * cli/cli-script.c (execute_control_command): Update.
51         * python/python.c (execute_gdb_command): Update.
52         * solib.c (info_sharedlibrary_command): Update.
53         * interps.c (interp_ui_out): Remove.
54         * interps.h (interp_ui_out): Remove.
55
56 2018-05-25  Tom Tromey  <tom@tromey.com>
57
58         * tui/tui-interp.c (as_tui_interp): Use dynamic_cast.
59         * mi/mi-interp.c (as_mi_interp): Use dynamic_cast.
60         * cli/cli-interp.c (as_cli_interp): Use dynamic_cast.
61
62 2018-05-25  Tom Tromey  <tom@tromey.com>
63
64         * cli/cli-interp.c (safe_execute_command): Use scoped_restore.
65         * interps.c (interp_exec): Use scoped_restore.
66
67 2018-05-25  Tom Tromey  <tom@tromey.com>
68
69         * remote.c (remote_target::remote_file_get): Use
70         gdb::byte_vector.
71         (remote_target::remote_file_put): Likewise.
72
73 2018-05-25  Tom Tromey  <tom@tromey.com>
74
75         * coff-pe-read.c (struct read_pe_section_data) <section_name>: Now
76         a std::string.
77         (get_pe_section_index, add_pe_exported_sym): Update.
78         (read_pe_exported_syms): Use gdb::def_vector.
79
80 2018-05-25  Tom Tromey  <tom@tromey.com>
81
82         * frame.c (remove_prev_frame): Remove.
83         (get_prev_frame_if_no_cycle): Use TRY/CATCH.
84
85 2018-05-25  Maciej W. Rozycki  <macro@mips.com>
86
87         * mips-linux-tdep.h (mips_supply_fpregset, mips_fill_fpregset):
88         Remove prototypes.
89         * mips-linux-nat.c (supply_fpregset): Always call
90         `mips64_supply_fpregset' rather than `mips_supply_fpregset'.
91         (fill_fpregset): Always call `mips64_fill_fpregset' rather than
92         `mips_fill_fpregset'.
93         * mips-linux-tdep.c (mips_supply_fpregset)
94         (mips_supply_fpregset_wrapper, mips_fill_fpregset)
95         (mips_fill_fpregset_wrapper): Remove functions.
96         (mips64_supply_fpregset, mips64_fill_fpregset): Update comments.
97         (mips_linux_fpregset): Remove variable.
98         (mips_linux_iterate_over_regset_sections): Use
99         `mips64_linux_fpregset' in place of `mips_linux_fpregset'.
100         (mips_linux_o32_sigframe_init): Remove comment.
101
102 2018-05-25  Pedro Alves  <palves@redhat.com>
103
104         * remote.c (struct vCont_action_support, MAXTHREADLISTRESULTS)
105         (struct readahead_cache, struct packet_reg, struct
106         remote_arch_state, class remote_state): Move higher up in the
107         file.
108         (remote_target::m_remote_state): Now an object instead of a pointer.
109         (remote_target::get_remote_state): Adjust.
110
111 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
112
113         * stack.c (select_and_print_frame): Delete.
114         (struct function_bounds): Move struct within function.
115         (func_command): Most content moved into new function
116         find_frame_for_function, use new function, print result, add
117         function comment.
118         (find_frame_for_function): New function, now returns a result.
119
120 2018-05-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
121
122         * stack.c (iterate_over_block_arg_vars): Fix comment.
123         (print_frame_arg_vars): Pass stream in cb_data, not gdb_stdout.
124
125 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
126
127         PR gdb/23203
128         * frame.c
129         (scoped_restore_selected_frame::scoped_restore_selected_frame):
130         Define.
131         (scoped_restore_selected_frame::~scoped_restore_selected_frame):
132         Define.
133         * frame.h (class scoped_restore_selected_frame): New class.
134         * stack.c (print_frame_local_vars): Remove catching and rethrowing
135         of any exception, use scoped_restore_selected_frame to restore the
136         frame instead.
137
138 2018-05-24  Pedro Alves  <palves@redhat.com>
139
140         * darwin-nat.h (darwin_nat_target::create_inferior): Mark with
141         override.
142
143 2018-05-23  Tom Tromey  <tom@tromey.com>
144
145         * complaints.c (struct complaints): Remove.
146         (symfile_complaint_book): Remove.
147         (series): New global.
148         (complaint_internal): Update.
149         (clear_complaints): Update.
150
151 2018-05-23  Tom Tromey  <tom@tromey.com>
152
153         * complaints.c (counters): New global.
154         (struct complain): Remove.
155         (struct complaints) <root>: Remove.
156         (complaint_sentinel): Remove.
157         (symfile_complaint_book): Update.
158         (find_complaint) Remove.
159         (complaint_internal, clear_complaints): Update.
160
161 2018-05-23  Tom Tromey  <tom@tromey.com>
162
163         * complaints.c (struct complain) <file, line>: Remove.
164         (find_complaint): Remove file, line parameters.
165         (complaint_internal): Update.
166
167 2018-05-23  Tom Tromey  <tom@tromey.com>
168
169         * complaints.c (vcomplaint): Remove.
170         (complaint_internal) Merge in contents of vcomplaint.
171
172 2018-05-23  Tom Tromey  <tom@tromey.com>
173
174         * complaints.c (struct complaints) <explanation>: Remove.
175         (symfile_explanations): Remove.
176         (symfile_complaint_book): Update.
177         (vcomplaint): Update.
178         (struct explanation): Remove.
179
180 2018-05-23  Tom Tromey  <tom@tromey.com>
181
182         * complaints.c (symfile_complaints): Remove.
183         (complaint_internal): Remove "complaints" parameter.
184         (clear_complaints, vcomplaint): Remove "c" parameter.
185         (get_complaints): Remove.
186         * dwarf2read.c (dwarf2_statement_list_fits_in_line_number_section_complaint)
187         (dwarf2_debug_line_missing_file_complaint)
188         (dwarf2_debug_line_missing_end_sequence_complaint)
189         (dwarf2_complex_location_expr_complaint)
190         (dwarf2_const_value_length_mismatch_complaint)
191         (dwarf2_section_buffer_overflow_complaint)
192         (dwarf2_macro_malformed_definition_complaint)
193         (dwarf2_invalid_attrib_class_complaint)
194         (create_addrmap_from_index, dw2_symtab_iter_next)
195         (dw2_expand_marked_cus)
196         (dw2_debug_names_iterator::find_vec_in_debug_names)
197         (dw2_debug_names_iterator::next, dw2_debug_names_iterator::next)
198         (create_debug_type_hash_table, init_cutu_and_read_dies)
199         (partial_die_parent_scope, add_partial_enumeration)
200         (skip_one_die, fixup_go_packaging, quirk_rust_enum, process_die)
201         (dwarf2_compute_name, dwarf2_physname, read_namespace_alias)
202         (read_import_statement, read_file_scope, create_dwo_cu_reader)
203         (create_cus_hash_table, create_dwp_hash_table)
204         (inherit_abstract_dies, read_func_scope, read_call_site_scope)
205         (dwarf2_rnglists_process, dwarf2_ranges_process)
206         (dwarf2_add_type_defn, dwarf2_attach_fields_to_type)
207         (dwarf2_add_member_fn, get_alignment, maybe_set_alignment)
208         (handle_struct_member_die, process_structure_scope)
209         (read_array_type, read_common_block, read_module_type)
210         (read_tag_pointer_type, read_typedef, read_base_type)
211         (read_subrange_type, load_partial_dies, partial_die_info::read)
212         (partial_die_info::read, partial_die_info::read)
213         (partial_die_info::read, read_checked_initial_length_and_offset)
214         (dwarf2_string_attr, read_formatted_entries)
215         (dwarf_decode_line_header)
216         (lnp_state_machine::check_line_address, dwarf_decode_lines_1)
217         (new_symbol, dwarf2_const_value_attr, lookup_die_type)
218         (read_type_die_1, determine_prefix, dwarf2_get_ref_die_offset)
219         (dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes)
220         (get_signatured_type, get_DW_AT_signature_type)
221         (decode_locdesc, file_file_name, consume_improper_spaces)
222         (skip_form_bytes, skip_unknown_opcode, dwarf_parse_macro_header)
223         (dwarf_decode_macro_bytes, dwarf_decode_macros)
224         (dwarf2_symbol_mark_computed, set_die_type)
225         (read_attribute_value): Update.
226         * stap-probe.c (handle_stap_probe, get_stap_base_address):
227         Update.
228         * dbxread.c (unknown_symtype_complaint)
229         (lbrac_mismatch_complaint, repeated_header_complaint)
230         (set_namestring, function_outside_compilation_unit_complaint)
231         (read_dbx_symtab, process_one_symbol): Update.
232         * gdbtypes.c (stub_noname_complaint): Update.
233         * windows-nat.c (handle_unload_dll): Update.
234         * coffread.c (coff_symtab_read, enter_linenos, decode_type)
235         (decode_base_type): Update.
236         * xcoffread.c (bf_notfound_complaint, ef_complaint)
237         (eb_complaint, record_include_begin, record_include_end)
238         (enter_line_range, xcoff_next_symbol_text, read_xcoff_symtab)
239         (process_xcoff_symbol, read_symbol)
240         (function_outside_compilation_unit_complaint)
241         (scan_xcoff_symtab): Update.
242         * machoread.c (macho_symtab_read, macho_add_oso_symfile): Update.
243         * buildsym.c (finish_block_internal, make_blockvector)
244         (end_symtab_get_static_block, augment_type_symtab): Update.
245         * dtrace-probe.c (dtrace_process_dof)
246         (dtrace_static_probe_ops::get_probes): Update.
247         * complaints.h (struct complaint): Don't declare.
248         (symfile_complaints): Remove.
249         (complaint_internal): Remove "complaints" parameter.
250         (complaint): Likewise.
251         (clear_complaints): Likewise.
252         * symfile.c (syms_from_objfile_1, finish_new_objfile)
253         (reread_symbols): Update.
254         * dwarf2-frame.c (dwarf2_restore_rule, execute_cfa_program)
255         (dwarf2_frame_cache, decode_frame_entry): Update.
256         * dwarf2loc.c (dwarf_reg_to_regnum): Update.
257         * objc-lang.c (lookup_objc_class, lookup_child_selector)
258         (info_selectors_command): Update.
259         * macrotab.c (macro_include, check_for_redefinition)
260         (macro_undef): Update.
261         * objfiles.c (filter_overlapping_sections): Update.
262         * stabsread.c (invalid_cpp_abbrev_complaint)
263         (reg_value_complaint, stabs_general_complaint, dbx_lookup_type)
264         (define_symbol, error_type, read_type, rs6000_builtin_type)
265         (stabs_method_name_from_physname, read_member_functions)
266         (read_cpp_abbrev, read_baseclasses, read_tilde_fields)
267         (attach_fields_to_type, complain_about_struct_wipeout)
268         (read_range_type, read_args, common_block_start)
269         (common_block_end, cleanup_undefined_types_1, scan_file_globals):
270         Update.
271         * mdebugread.c (index_complaint, unknown_ext_complaint)
272         (basic_type_complaint, bad_tag_guess_complaint)
273         (bad_rfd_entry_complaint, unexpected_type_code_complaint)
274         (reg_value_complaint, parse_symbol, parse_type, upgrade_type)
275         (parse_procedure, parse_lines)
276         (function_outside_compilation_unit_complaint)
277         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref)
278         (bad_tag_guess_complaint, reg_value_complaint): Update.
279         * cp-support.c (demangled_name_complaint): Update.
280         * macroscope.c (sal_macro_scope): Update.
281         * dwarf-index-write.c (class debug_names): Update.
282
283 2018-05-23  Tom Tromey  <tom@tromey.com>
284
285         * complaints.c (clear_complaints): Remove "noisy" parameter.
286         * complaints.h (clear_complaints): Update.
287         * symfile.c (syms_from_objfile_1, finish_new_objfile)
288         (reread_symbols): Update.
289
290 2018-05-23  Tom Tromey  <tom@tromey.com>
291
292         * complaints.c (enum complaint_series): Remove FIRST_MESSAGE,
293         SUBSEQUENT_MESSAGE.
294         (vcomplaint, clear_complaints): Update.
295         (symfile_explanations): Remove some messages.
296
297 2018-05-23  Tom Tromey  <tom@tromey.com>
298
299         * complaints.c (internal_complaint): Remove.
300         * complaints.h (internal_complaint): Remove.
301
302 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
303
304         * i387-tdep.c (i387_collect_xsave): Make `i' unsigned.
305
306 2018-05-22  Pedro Alves  <palves@redhat.com>
307
308         * remote-fileio.c (remote_fileio_reply, remote_fileio_ioerror)
309         (remote_fileio_badfd, remote_fileio_return_errno)
310         (remote_fileio_return_success, remote_fileio_func_open)
311         (remote_fileio_func_open, remote_fileio_func_close)
312         (remote_fileio_func_read, remote_fileio_func_write)
313         (remote_fileio_func_lseek, remote_fileio_func_rename)
314         (remote_fileio_func_unlink, remote_fileio_func_stat)
315         (remote_fileio_func_fstat, remote_fileio_func_gettimeofday)
316         (remote_fileio_func_isatty, remote_fileio_func_system): Add
317         remote_target parameter.
318         (remote_fio_func_map) <func>: Add remote_target parameter.
319         (do_remote_fileio_request, remote_fileio_request):
320         * remote-fileio.h (remote_fileio_request):
321         * remote-notif.c (remote_notif_ack, remote_notif_parse, ): Add
322         remote_target parameter.
323         (remote_notif_process, handle_notification): Adjust to pass down
324         the remote.
325         (remote_notif_state_allocate): Add remote_target parameter.  Save
326         it.
327         * remote-notif.h (struct remote_target): Forward declare.
328         (struct notif_client) <parse, ack, can_get_pending_events>: Add
329         remote_target parameter.
330         (struct remote_notif_state) <remote>: New field.
331         (remote_notif_ack, remote_notif_parse): Add remote_target
332         parameter.
333         (remote_notif_state_allocate, remote_notif_state_allocate): Add
334         remote_target parameter.
335         * remote.c (OPAQUETHREADBYTES, threadref, gdb_ext_thread_info)
336         (threads_listing_context, rmt_thread_action, protocol_feature)
337         (packet_reg, stop_reply, stop_reply_p, enum packet_support)
338         (packet_result, struct threads_listing_context, remote_state):
339         Move definitions and declarations higher up.
340         (remote_target) <~remote_target>: Declare.
341         (remote_download_command_source, remote_file_put, remote_file_get)
342         (remote_file_delete, remote_hostio_pread, remote_hostio_pwrite)
343         (remote_hostio_pread_vFile, remote_hostio_send_command)
344         (remote_hostio_set_filesystem, remote_hostio_open)
345         (remote_hostio_close, remote_hostio_unlink, remote_state)
346         (get_remote_state, get_remote_packet_size, get_memory_packet_size)
347         (get_memory_write_packet_size, get_memory_read_packet_size)
348         (append_pending_thread_resumptions, remote_detach_1)
349         (append_resumption, remote_resume_with_vcont)
350         (add_current_inferior_and_thread, wait_ns, wait_as)
351         (process_stop_reply, remote_notice_new_inferior)
352         (process_initial_stop_replies, remote_add_thread)
353         (btrace_sync_conf, remote_btrace_maybe_reopen)
354         (remove_new_fork_children, kill_new_fork_children)
355         (discard_pending_stop_replies, stop_reply_queue_length)
356         (check_pending_events_prevent_wildcard_vcont)
357         (discard_pending_stop_replies_in_queue, stop_reply)
358         (remote_notif_remove_queued_reply, stop_reply *queued_stop_reply)
359         (peek_stop_reply, remote_parse_stop_reply, remote_stop_ns)
360         (remote_interrupt_as, remote_interrupt_ns)
361         (remote_get_noisy_reply, remote_query_attached)
362         (remote_add_inferior, remote_current_thread, get_current_thread)
363         (set_thread, set_general_thread, set_continue_thread)
364         (set_general_process, write_ptid)
365         (remote_unpack_thread_info_response, remote_get_threadinfo)
366         (parse_threadlist_response, remote_get_threadlist)
367         (remote_threadlist_iterator, remote_get_threads_with_ql)
368         (remote_get_threads_with_qxfer)
369         (remote_get_threads_with_qthreadinfo, extended_remote_restart)
370         (get_offsets, remote_check_symbols, remote_supported_packet)
371         (remote_query_supported, remote_packet_size)
372         (remote_serial_quit_handler, remote_detach_pid)
373         (remote_vcont_probe, remote_resume_with_hc)
374         (send_interrupt_sequence, interrupt_query)
375         (remote_notif_get_pending_events, fetch_register_using_p)
376         (send_g_packet, process_g_packet, fetch_registers_using_g)
377         (store_register_using_P, store_registers_using_G)
378         (set_remote_traceframe, check_binary_download)
379         (remote_write_bytes_aux, remote_write_bytes, remote_read_bytes_1)
380         (remote_xfer_live_readonly_partial, remote_read_bytes)
381         (remote_send_printf, remote_flash_write, readchar)
382         (remote_serial_write, putpkt, putpkt_binary, skip_frame)
383         (read_frame, getpkt, getpkt_or_notif_sane_1, getpkt_sane)
384         (getpkt_or_notif_sane, remote_vkill, remote_kill_k)
385         (extended_remote_disable_randomization, extended_remote_run)
386         (send_environment_packet, extended_remote_environment_support)
387         (extended_remote_set_inferior_cwd, remote_write_qxfer)
388         (remote_read_qxfer, push_stop_reply, vcont_r_supported)
389         (packet_command): Now methods of ...
390         (remote_target): ... this class.
391         (m_remote_state) <remote_target>: New field.
392         (struct remote_state) <stop_reply_queue,
393         remote_async_inferior_event_token, wait_forever_enabled_p>: New
394         fields.
395         (remote_state::remote_state): Allocate stop_reply_queue.
396         (remote_state): Delete global.
397         (get_remote_state_raw): Delete.
398         (remote_target::get_remote_state): Allocate m_remote_state on
399         demand.
400         (get_current_remote_target): New.
401         (remote_ops, extended_remote_ops): Delete.
402         (wait_forever_enabled_p, remote_async_inferior_event_token):
403         Delete, moved to struct remote_state.
404         (remote_target::close): Delete self.  Destruction bits split to
405         ...
406         (remote_target::~remote_target): ... this.
407         (show_memory_packet_size): Adjust to use
408         get_current_remote_target.
409         (struct protocol_feature) <func>: Add remote_target parameter.
410         All callers adjusted.
411         (curr_quit_handler_target): New.
412         (remote_serial_quit_handler): Reimplement.
413         (remote_target::open_1): Adjust to use get_current_remote_target.
414         Heap-allocate remote_target/extended_remote_target instances.
415         (vcont_builder::vcont_builder): Add remote_target parameter, and
416         save it in m_remote.  All callers adjusted.
417         (vcont_builder::m_remote): New field.
418         (vcont_builder::restart, vcont_builder::flush)
419         (vcont_builder::push_action): Use it.
420         (remote_target::commit_resume): Use it.
421         (struct queue_iter_param) <remote>: New field.
422         (remote_target::remove_new_fork_children): Fill in 'remote' field.
423         (check_pending_event_prevents_wildcard_vcont_callback_data): New.
424         (check_pending_event_prevents_wildcard_vcont_callback)
425         (remote_target::check_pending_events_prevent_wildcard_vcont)
426         (remote_target::discard_pending_stop_replies)
427         (remote_target::discard_pending_stop_replies_in_queue)
428         (remote_target::remote_notif_remove_queued_reply): Fill in
429         'remote' field.
430         (remote_notif_get_pending_events): New.
431         (remote_target::readchar, remote_target::remote_serial_write):
432         Save/restore curr_quit_handler_target.
433         (putpkt): New.
434         (kill_new_fork_children): Fill in 'remote' field.
435         (packet_command): Use get_current_remote_target, defer to
436         remote_target method of same name.
437         (scoped_remote_fd::scoped_remote_fd): Add 'remote_target'
438         parameter, and save it in m_remote.  All callers adjusted.
439         (scoped_remote_fd::release): Use m_remote.
440         (scoped_remote_fd::m_remote): New field.
441         (remote_file_put, remote_file_get, remote_file_delete): Use
442         get_current_remote_target, defer to remote_target method of same
443         name.
444         (remote_btrace_reset): Add remote_state paremeter.  Update all
445         callers.
446         (remote_async_inferior_event_handler). Pass down 'data'.
447         (remote_new_objfile): Use get_current_remote_target.
448         (remote_target::vcont_r_supported): New.
449         (set_range_stepping): Use get_current_remote_target and
450         remote_target::vcont_r_supported.
451         (_initialize_remote): Don't allocate 'remote_state' and
452         'stop_reply_queue' globals.
453         * remote.h (struct remote_target): Forward declare.
454         (getpkt, putpkt, remote_notif_get_pending_events): Add
455         'remote_target' parameter.
456
457 2018-05-22  Pedro Alves  <palves@redhat.com>
458
459         * remote.c (vcont_builder): Now a class.  Make all data members
460         private.
461         (vcont_builder) <vcont_builder, restart, flush, push_action>:
462         Declare methods.
463         (vcont_builder_restart): Rename to ...
464         (vcont_builder::restart): ... this.
465         (vcont_builder_flush): Rename to ...
466         (vcont_builder::flush): ... this.
467         (vcont_builder_push_action): Rename to ...
468         (vcont_builder::push_action): ... this.
469         (remote_target::commit_resume): Adjust.
470
471 2018-05-22  Pedro Alves  <palves@redhat.com>
472
473         * remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
474         (DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
475         (get_fixed_memory_packet_size): New.
476         (get_memory_packet_size): Use it.
477         (set_memory_packet_size): Don't override the config size with
478         DEFAULT_MAX_MEMORY_PACKET_SIZE.
479         (show_memory_packet_size): Use get_fixed_memory_packet_size.
480         Don't refer to get_memory_packet_size if not connected to a remote
481         target.  Show "(default)" if configured size is 0.
482
483 2018-05-22  Pedro Alves  <palves@redhat.com>
484
485         * remote.c (remote_target::mourn_inferior): Move
486         discard_pending_stop_replies call here from ...
487         (_initialize_remote): ... here.
488
489 2018-05-22  Pedro Alves  <palves@redhat.com>
490
491         * remote.c (compare_section_command): Remove set_general_process
492         call.
493
494 2018-05-22  Pedro Alves  <palves@redhat.com>
495
496         * remote.c (struct packet_reg, struct remote_arch_state):
497         Move higher up in the file.
498         (remote_state) <m_arch_states>: Store remote_arch_state values
499         instead of remote_arch_state pointers.
500         (remote_state::get_remote_arch_state): Adjust.
501
502 2018-05-22  Pedro Alves  <palves@redhat.com>
503
504         * remote.c: Include <unordered_map>.
505         (remote_state): Now a class.
506         (remote_state) <get_remote_arch_state>: Declare method.
507         <get_remote_arch_state>: New field.
508         (remote_arch_state) <remote_arch_state>: Declare ctor.
509         <regs>: Now a unique_ptr.
510         (remote_gdbarch_data_handle): Delete.
511         (get_remote_arch_state): Delete.
512         (remote_state::get_remote_arch_state): New.
513         (get_remote_state): Adjust to call remote_state's
514         get_remote_arch_state method.
515         (init_remote_state): Delete, bits factored out to ...
516         (remote_arch_state::remote_arch_state): ... this new method.
517         (get_remote_packet_size, get_memory_packet_size)
518         (process_g_packet, remote_target::fetch_registers)
519         (remote_target::prepare_to_store, store_registers_using_G)
520         (remote_target::store_registers, remote_target::get_trace_status):
521         Adjust to call remote_state's method.
522         (_initialize_remote): Remove reference to
523         remote_gdbarch_data_handle.
524
525 2018-05-22  Pedro Alves  <palves@redhat.com>
526
527         * remote.c (struct readahead_cache) <invalidate, invalidate_fd,
528         pread>: New method declarations.
529         (remote_target::open_1): Adjust.
530         (readahead_cache_invalidate): Rename to ...
531         (readahead_cache::invalidate): ... this, and adjust to be a class
532         method.
533         (readahead_cache_invalidate_fd): Rename to ...
534         (readahead_cache::invalidate_fd): ... this, and adjust to be a
535         class method.
536         (remote_hostio_pwrite): Adjust.
537         (remote_hostio_pread_from_cache): Rename to ...
538         (readahead_cache::pread): ... this, and adjust to be a class
539         method.
540         (remote_hostio_close): Adjust.
541
542 2018-05-22  Pedro Alves  <palves@redhat.com>
543
544         * remote.c (remote_hostio_close_cleanup): Delete.
545         (class scoped_remote_fd): New.
546         (remote_file_put, remote_file_get): Use it.
547
548 2018-05-22  Pedro Alves  <palves@redhat.com>
549
550         (struct vCont_action_support): Use bool and initialize all fields.
551         (struct readahead_cache): Initialize all fields.
552         (remote_state): Use bool and initialize all fields.
553         (remote_state::remote_state, remote_state::~remote_state): New.
554         (new_remote_state): Delete.
555         (_initialize_remote): Use new to allocate remote_state.
556
557 2018-05-22  Pedro Alves  <palves@redhat.com>
558             張俊芝  <zjz@zjz.name>
559
560         PR gdb/22973
561         * c-exp.y: Include "c-support.h".
562         (parse_number, c_parse_escape, lex_one_token): Use TOLOWER instead
563         of tolower.  Use c_ident_is_alpha to scan names.
564         * c-lang.c: Include "c-support.h".
565         (convert_ucn, convert_octal, convert_hex, convert_escape): Use
566         ISXDIGIT instead of isxdigit and ISDIGIT instead of isdigit.
567         * c-support.h: New file, with bits factored out from ...
568         * cp-name-parser.y: ... this file.
569         Include "c-support.h".
570         (cp_ident_is_alpha, cp_ident_is_alnum): Deleted, moved to
571         c-support.h and renamed.
572         (symbol_end, yylex): Adjust.
573
574 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
575
576         * arch/ppc-linux-common.c (ppc_linux_has_isa205): Change the
577         parameter type to CORE_ADDR.
578         * arch/ppc-linux-common.h (ppc_linux_has_isa205): Change the
579         parameter type in declaration to CORE_ADDR.
580         * ppc-linux-tdep.c (ppc_linux_core_read_description): Call
581         target_auxv_search to get AT_HWCAP and use the result to get the
582         target description.
583         * ppc-linux-nat.c (ppc_linux_get_hwcap): Change the return type
584         to CORE_ADDR. Remove the cast of the return value to unsigned
585         long. Fix error predicate of target_auxv_search.
586         (ppc_linux_nat_target::read_description): Change the type of the
587         hwcap variable to CORE_ADDR.
588
589 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
590
591         * rs6000-tdep.c (rs6000_gdbarch_init): Assign 1 to have_dfp only
592         if the size of fpscr is larger than 32 bits.
593
594 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
595
596         * ppc-linux-tdep.c (ppc_linux_vsxregset): New function.
597         (ppc32_linux_vsxregmap): New global.
598         (ppc32_linux_vsxregset): Initialize with ppc32_linux_vsxregmap,
599         regcache_supply_regset, and regcache_collect_regset.
600         * ppc-linux-tdep.h (ppc_linux_vsxregset): Declare.
601         * ppc-linux-nat.c (supply_vsxregset, fill_vsxregset): Remove.
602         (fetch_vsx_register, store_vsx_register): Remove.
603         (fetch_vsx_registers): Add regno parameter. Get regset using
604         ppc_linux_vsxregset. Use regset to supply registers.
605         (store_vsx_registers): Add regno parameter. Get regset using
606         ppc_linux_vsxregset. Use regset to collect registers.
607         (fetch_register): Call fetch_vsx_registers instead of
608         fetch_vsx_register.
609         (store_register): Call store_vsx_registers instead of
610         store_vsx_register.
611         (fetch_ppc_registers): Call fetch_vsx_registers with -1 for the
612         new regno parameter.
613         (store_ppc_registers): Call store_vsx_registers with -1 for the
614         new regno parameter.
615         * rs6000-tdep.c (ppc_vsx_support_p, ppc_supply_vsxreget)
616         (ppc_collect_vsxregset): Remove.
617
618 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
619
620         * ppc-tdep.h (struct ppc_reg_offsets): Remove vector register
621         offset fields.
622         * ppc-fbsd-tdep.c (ppc32_fbsd_reg_offsets): Remove initializers
623         for vector register offset fields.
624         (ppc64_fbsd_reg_offsets): Likewise.
625         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
626         to vector register offset fields.
627         * ppc-obsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
628         to vector register offset fields.
629         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Remove assignment to
630         vector register offset fields.
631         * rs6000-aix-tdep.c (rs6000_aix32_reg_offsets): Remove
632         initializers for vector register offset fields.
633         (rs6000_aix64_reg_offsets): Likewise.
634         * rs6000-tdep.c (ppc_vrreg_offset): Remove.
635         (ppc_supply_vrregset): Remove.
636         (ppc_collect_vrregset): Remove.
637         * ppc-linux-tdep.c (ppc_linux_collect_vrregset): New function.
638         (ppc_linux_vrregset) : New function.
639         (ppc32_le_linux_vrregmap, ppc32_be_linux_vrregmap)
640         (ppc32_le_linux_vrregset, ppc32_be_linux_vrregset): New globals.
641         (ppc32_linux_vrregset): Remove.
642         (ppc_linux_iterate_over_regset_sections): Call ppc_linux_vrregset
643         and use result instead of ppc32_linux_vrregset.
644         (ppc32_linux_reg_offsets): Remove initializers for vector register
645         offset fields.
646         (ppc64_linux_reg_offsets): Likewise.
647         * ppc-linux-tdep.h (ppc_linux_vrregset): New declaration.
648         * ppc-linux-nat.c: Include regset.h.
649         (gdb_vrregset_t): Adjust comment to account for little-endian
650         mode.
651         (supply_vrregset, fill_vrregset): Remove.
652         (fetch_altivec_register, store_altivec_register): Remove.
653         (fetch_altivec_registers): Add regno parameter. Get regset using
654         ppc_linux_vrregset. Use regset to supply registers.
655         (store_altivec_registers): Add regno parameter. Get regset using
656         ppc_linux_vrregset. Use regset to collect registers.
657         (fetch_register): Call fetch_altivec_registers instead of
658         fetch_altivec_register.
659         (store_register): Call store_altivec_registers instead of
660         store_altivec_register.
661         (fetch_ppc_registers): Call fetch_altivec_registers with -1 for
662         the new regno parameter.
663         (store_ppc_registers): Call store_altivec_registers with -1 for
664         the new regno parameter.
665
666 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
667
668         * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_VRREGSET)
669         (PPC_LINUX_SIZEOF_VSXREGSET): Define.
670         * ppc-linux-nat.c (SIZEOF_VSXREGS, SIZEOF_VRREGS): Remove.
671         (gdb_vrregset_t): Change array type size to
672         PPC_LINUX_SIZEOF_VRREGSET.
673         (gdb_vsxregset_t): Change array type size to
674         PPC_LINUX_SIZEOF_VSXREGSET.
675         * ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections):
676         Change integer literals to PPC_LINUX_SIZEOF_VRREGSET and
677         PPC_LINUX_SIZEOF_VSXREGSET.
678
679 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
680
681         * configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
682         * ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
683         nat/ppc-linux.c.
684         (ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
685         ppc_linux_target_wordsize with tid.
686         (ppc_linux_nat_target::read_description): Call ppc_linux_target
687         wordsize with tid.
688         * nat/ppc-linux.c: Include nat/gdb_ptrace.h.
689         (ppc64_64bit_inferior_p): Add static and inline specifiers.
690         (ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
691         tid parameter. Remove static specifier.
692         * nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration.
693         (ppc_linux_target_wordsize): New declaration.
694
695 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
696
697         * arch/ppc-linux-common.c: New file.
698         * arch/ppc-linux-common.h: New file.
699         * arch/ppc-linux-tdesc.h: New file.
700         * configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o.
701         * Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o.
702         (HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and
703         arch/ppc-linux-tdesc.h.
704         * ppc-linux-nat.c: Include arch/ppc-linux-common.h and
705         arch/ppc-linux-tdesc.h.
706         (ppc_linux_nat_target::read_description): Remove target
707         description matching code. Fill a ppc_linux_features struct and
708         call ppc_linux_match_description with it. Move comment about ISA
709         2.05 to ppc-linux-common.c.
710         * ppc-linux-tdep.c: Include arch/ppc-linux-common.h and
711         arch/ppc-linux-tdesc.h.
712         (ppc_linux_core_read_description): Remove target description
713         matching code. Fill a ppc_linux_features struct and call
714         ppc_linux_match_description with it.
715         * ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
716         (tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
717         (tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
718         (tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
719         (tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
720         (tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
721         (tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
722         (tdesc_powerpc_e500l): Remove.
723
724 2018-05-22  Joel Brobecker  <brobecker@adacore.com>
725
726         * ada-lang.c (catch_assert_command): Pass empty string instead
727         of NULL for excep_string argument.
728
729 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
730
731         * mips-linux-nat.c (mips64_linux_register_addr): Return -1 if
732         the width of the requested register exceeds the width of the
733         `ptrace' data type.
734
735 2018-05-21  Tom Tromey  <tom@tromey.com>
736
737         * printcmd.c (output_command): Remove.
738         (output_command_const): Rename to output_command.
739         * valprint.h (output_command): Rename from output_command_const.
740         * tracepoint.c (trace_dump_actions): Call output_command.
741
742 2018-05-21  Tom Tromey  <tom@tromey.com>
743
744         * mi/mi-cmd-catch.c (mi_cmd_catch_assert)
745         (mi_cmd_catch_exception, mi_cmd_catch_handlers): Update.
746         * ada-lang.h (create_ada_exception_catchpoint): Update.
747         * ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
748         std::string.
749         (create_excep_cond_exprs, ~ada_catchpoint)
750         (should_stop_exception, print_one_exception)
751         (print_mention_exception, print_recreate_exception): Update.
752         (ada_get_next_arg): Remove.
753         (catch_ada_exception_command_split): Use std::string.  Change type
754         of "excep_string", "cond_string".
755         (catch_ada_exception_command): Update.
756         (create_ada_exception_catchpoint): Change type of excep_string.
757         (ada_exception_sal): Remove excep_string parameter.
758         (~ada_catchpoint): Remove.
759
760 2018-05-21  Tom Tromey  <tom@tromey.com>
761
762         * ada-lang.c (ada_collect_symbol_completion_matches): Remove
763         cleanup.
764
765 2018-05-21  Tom Tromey  <tom@tromey.com>
766
767         * ada-lang.c (ada_exception_message_1, ada_exception_message):
768         Return unique_xmalloc_ptr.
769         (print_it_exception): Update.
770
771 2018-05-21  Tom Tromey  <tom@tromey.com>
772
773         * tracepoint.c (trace_dump_actions): Use std::string.
774
775 2018-05-21  Tom Tromey  <tom@tromey.com>
776
777         * symfile.c (reread_symbols): Use std::string for original_name.
778
779 2018-05-21  Tom Tromey  <tom@tromey.com>
780
781         * dwarf2read.c (dwarf2_read_debug_names): Use std::unique_ptr.
782         (mapped_index_base): Use DISABLE_COPY_AND_ASSIGN.  Default
783         constructor.
784
785 2018-05-20  Simon Marchi  <simon.marchi@polymtl.ca>
786
787         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong
788         instance to...
789         (HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this.
790         * objfiles.c (get_objfile_bfd_data): Allocate
791         objfile_per_bfd_storage with obstack_new when allocating on
792         obstack.
793
794 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
795
796         * ada-lang.c (cache_symbol): Use XOBNEW and/or XOBNEWVEC and/or
797         OBSTACK_ZALLOC.
798         * dwarf2-frame.c (dwarf2_build_frame_info): Likewise.
799         * hppa-tdep.c (hppa_init_objfile_priv_data): Likewise.
800         * mdebugread.c (mdebug_build_psymtabs): Likewise.
801         (add_pending): Likewise.
802         (parse_symbol): Likewise.
803         (parse_partial_symbols): Likewise.
804         (psymtab_to_symtab_1): Likewise.
805         (new_psymtab): Likewise.
806         (elfmdebug_build_psymtabs): Likewise.
807         * minsyms.c (terminate_minimal_symbol_table): Likewise.
808         * objfiles.c (get_objfile_bfd_data): Likewise.
809         (objfile_register_static_link): Likewise.
810         * psymtab.c (allocate_psymtab): Likewise.
811         * stabsread.c (read_member_functions): Likewise.
812         * xcoffread.c (xcoff_end_psymtab): Likewise.
813
814 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
815
816         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Define if
817         compiler supports std::is_trivially_constructible.
818         * common/poison.h: Include obstack.h.
819         (IsMallocable): Define to is_trivially_constructible if the
820         compiler supports it, define to true_type otherwise.
821         (xobnew): New.
822         (XOBNEW): Redefine.
823         (xobnewvec): New.
824         (XOBNEWVEC): Redefine.
825         * gdb_obstack.h (obstack_zalloc): New.
826         (OBSTACK_ZALLOC): Redefine.
827         (obstack_calloc): New.
828         (OBSTACK_CALLOC): Redefine.
829         (obstack_new): New.
830         * gdbarch.sh: Include gdb_obstack in gdbarch.h.
831         (gdbarch_obstack): New declaration in gdbarch.h, definition in
832         gdbarch.c.
833         (GDBARCH_OBSTACK_CALLOC, GDBARCH_OBSTACK_ZALLOC): Use
834         obstack_calloc/obstack_zalloc.
835         (gdbarch_obstack_zalloc): Remove.
836         * target-descriptions.c (tdesc_data_init): Use obstack_new.
837
838 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
839
840         * stack.c (backtrace_command_1): Remove useless variable int i.
841
842 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
843
844         * stack.c (print_frame_info): Fix comment.
845
846 2018-05-18  Tom Tromey  <tom@tromey.com>
847
848         * dwarf2read.c (struct dwz_file): Add constructor, initializers.
849         <dwz_bfd>: Now a gdb_bfd_ref_ptr.
850         (~dwarf2_per_objfile): Update
851         (dwarf2_get_dwz_file): Use new.
852         * dwarf2read.h (struct dwarf2_per_objfile) <dwz_file>: Now a
853         unique_ptr.
854
855 2018-05-18  Tom Tromey  <tom@tromey.com>
856
857         * dwarf2read.h (struct dwarf2_per_objfile) <dwp_file>: Now a
858         unique_ptr.
859         * dwarf2read.c (struct dwp_file): Add constructor and
860         initializers.
861         (open_and_init_dwp_file): Return a unique_ptr.
862         (dwarf2_per_objfile, create_dwp_hash_table)
863         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2)
864         (lookup_dwo_unit_in_dwp): Update.
865         (open_and_init_dwp_file, get_dwp_file): Update.
866
867 2018-05-18  Tom Tromey  <tom@tromey.com>
868
869         * dwarf2read.c (dwarf2_per_objfile): Update.
870         (struct mapped_index): Add initializers.
871         (dwarf2_read_index): Use new.
872         (dw2_symtab_iter_init): Update.
873         * dwarf2read.h (struct dwarf2_per_objfile) <index_table>: Now a
874         unique_ptr.
875
876 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
877
878         * dwarf2read.c (mapped_index) <total_size>: Remove.
879
880 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
881
882         * unittests/format_pieces-selftests.c (test_format_specifier):
883         Add ARI comments.
884
885 2018-05-18  Tom Tromey  <tom@tromey.com>
886
887         * c-typeprint.c (maybe_print_hole): New function.
888         (c_print_type_struct_field_offset): Update.
889         (c_type_print_base_struct_union): Call maybe_print_hole.
890
891 2018-05-17  Keith Seitz  <keiths@redhat.com>
892
893         * breakpoint.c (build_bpstat_chain): New function, moved from
894         bpstat_stop_status.
895         (bpstat_stop_status): Add optional parameter, `stop_chain'.
896         If no stop chain is passed, call build_bpstat_chain to build it.
897         * breakpoint.h (build_bpstat_chain): Declare.
898         (bpstat_stop_status): Move documentation here from breakpoint.c.
899         * infrun.c (handle_signal_stop): Before eliding inlined frames,
900         build the stop chain and pass it to skip_inline_frames.
901         Pass this stop chain to bpstat_stop_status.
902         * inline-frame.c: Include breakpoint.h.
903         (stopped_by_user_bp_inline_frame): New function.
904         (skip_inline_frames): Add parameter `stop_chain'.
905         Move documention to inline-frame.h.
906         If non-NULL, use stopped_by_user_bp_inline_frame to determine
907         whether the frame should be elided.
908         * inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
909         Add moved documentation and update for new parameter.
910
911 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
912
913         PR cli/14975
914         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
915         unittests/format_pieces-selftests.c.
916         * common/format.h (format_piece) <operator==>: New.
917         (format_pieces) <operator[]>: Remove.
918         * common/format.c (format_pieces::format_pieces): Handle \e.
919         * unittests/format_pieces-selftests.c: New.
920
921 2018-05-17  Tom Tromey  <tom@tromey.com>
922
923         PR symtab/23010:
924         * dwarf2read.c (load_cu, dw2_do_instantiate_symtab)
925         (dw2_instantiate_symtab): Add skip_partial parameter.
926         (dw2_find_last_source_symtab, dw2_map_expand_apply)
927         (dw2_lookup_symbol, dw2_expand_symtabs_for_function)
928         (dw2_expand_all_symtabs, dw2_expand_symtabs_with_fullname)
929         (dw2_expand_symtabs_matching_one)
930         (dw2_find_pc_sect_compunit_symtab)
931         (dw2_debug_names_lookup_symbol)
932         (dw2_debug_names_expand_symtabs_for_function): Update.
933         (init_cutu_and_read_dies): Add skip_partial parameter.
934         (process_psymtab_comp_unit, build_type_psymtabs_1)
935         (process_skeletonless_type_unit, load_partial_comp_unit)
936         (psymtab_to_symtab_1): Update.
937         (load_full_comp_unit): Add skip_partial parameter.
938         (process_imported_unit_die, dwarf2_read_addr_index)
939         (follow_die_offset, dwarf2_fetch_die_loc_sect_off)
940         (dwarf2_fetch_constant_bytes, dwarf2_fetch_die_type_sect_off)
941         (read_signatured_type): Update.
942
943 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
944
945         * value.c (release_value): Remove unused variable.
946         (record_latest_value): Likewise.
947         (access_value_history): Likewise.
948         (preserve_values): Likewise.
949
950 2018-05-17  Tom Tromey  <tom@tromey.com>
951
952         * extension.h (struct ext_lang_type_printers) <py_type_printers>:
953         Initialize.
954
955 2018-05-16  Maciej W. Rozycki  <macro@mips.com>
956
957         PR gdb/22286
958         * linux-nat-trad.c (linux_nat_trad_target::fetch_register):
959         Also handle registers whose width is not a multiple of
960         PTRACE_TYPE_RET.
961         (linux_nat_trad_target::store_register): Likewise.
962
963 2018-05-16  Tom Tromey  <tom@tromey.com>
964
965         * gdbcore.h (core_bfd): Redefine.
966         * corelow.c (core_target::close): Update.
967         (core_target_open): Update.
968         * progspace.h (struct program_space) <cbfd>: Now a
969         gdb_bfd_ref_ptr.
970
971 2018-05-16  Tom Tromey  <tom@tromey.com>
972
973         PR cli/19551:
974         * symfile-add-flags.h (enum symfile_add_flags)
975         <SYMFILE_NOT_FILENAME>: New constant.
976         * symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
977         objfile name from BFD.
978         (symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
979         * minidebug.c (find_separate_debug_file_in_section): Put
980         ".gnu_debugdata" into BFD's file name.
981
982 2018-05-16  Simon Marchi  <simon.marchi@ericsson.com>
983
984         * regcache.c (regcache_read_ftype, regcache_write_ftype):
985         Remove.
986
987 2018-05-15  Tamar Christina  <tamar.christina@arm.com>
988
989         PR binutils/21446
990         * aarch64-tdep.c (aarch64_analyze_prologue,
991         aarch64_software_single_step, aarch64_displaced_step_copy_insn):
992         Indicate not interested in errors.
993
994 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
995
996         * mips-linux-nat.c (mips_linux_nat_target::fetch_registers):
997         Supply the MIPS_ZERO_REGNUM register.
998
999 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
1000
1001         * mips-tdep.c (mask_address_var): Make variable static.
1002
1003 2018-05-14  Tom Tromey  <tom@tromey.com>
1004
1005         * dwarf2read.c (rust_union_quirks): Clear rust_unions.
1006
1007 2018-05-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1008
1009         * i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not
1010         FXSAVE_ADDR for the mxcsr register.
1011
1012 2018-05-11  Max Filippov  <jcmvbkbc@gmail.com>
1013
1014         * configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.
1015
1016 2018-05-11  Pedro Alves  <palves@redhat.com>
1017
1018         * corelow.c (core_target) <core_target>: No longer inline.
1019         Initialize m_core_gdbarch, m_core_vec and build the section table
1020         here.
1021         <~core_target>: New.
1022         <core_gdbarch, get_core_register_section>: New methods.
1023         <m_core_section_table, m_core_vec, m_core_gdbarch>: New fields,
1024         factored out from ...
1025         <core_data, core_vec, core_gdbarch>: ... these deleted globals.
1026         (core_ops): Delete.
1027         (sniff_core_bfd): Add gdbarch parameter.
1028         (core_close): Delete, merged into ...
1029         (core_target::close): ... here.  Delete self.
1030         (core_close_cleanup): Delete.
1031         (core_target_open): Allocate a core_target on the heap.  Use a
1032         unique_ptr instead of a cleanup.  Bits moved into the core_target
1033         ctor.  Adjust to use core_target methods instead of globals.
1034         (get_core_register_section): Rename to ...
1035         (core_target::get_core_register_section): ... this and adjust.
1036         (struct get_core_registers_cb_data): New.
1037         (get_core_registers_cb): Use it.  Use bool.
1038         (core_target::fetch_registers, core_target::files_info)
1039         (core_target::xfer_partial, core_target::read_description)
1040         (core_target::pid_to, core_target::thread_name): Adjust to
1041         reference class fields instead of globals.
1042         * target.h (struct target_ops_deleter, target_ops_up): New.
1043
1044 2018-05-11  Pedro Alves  <palves@redhat.com>
1045
1046         * corefile.c (core_file_command): Move to corelow.c.
1047         * corelow.c (the_core_target): Delete.
1048         (core_file_command): Moved from corefile.c.  Check exec_bfd
1049         instead of the_core_target.  Use target_detach instead of calling
1050         into the_core_target directly.
1051         (maybe_say_no_core_file_now): New.
1052         (core_target::detach): Use it.
1053         (_initialize_corelow): Remove references to the_core_target.
1054         * gdbcore.h (the_core_target): Delete.
1055
1056 2018-05-11  Tom Tromey  <tromey@redhat.com>
1057             Pedro Alves  <palves@redhat.com>
1058
1059         * corefile.c (core_bfd): Remove.
1060         * gdbcore.h (core_bfd): Now a macro.
1061         * progspace.h (struct program_space) <cbfd>: New field.
1062
1063 2018-05-11  Tom Tromey  <tom@tromey.com>
1064
1065         * mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
1066         gdb::def_vector.
1067
1068 2018-05-10  Tom Tromey  <tom@tromey.com>
1069
1070         * configure: Rebuild.
1071         * warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.
1072
1073 2018-05-10  Joel Brobecker  <brobecker@adacore.com>
1074
1075         PR server/23158:
1076         * regformats/regdat.sh: Adjust script, following the addition
1077         of the new expedite_regs parameter to init_target_desc.
1078
1079 2018-05-10  Omair Javaid  <omair.javaid@linaro.org>
1080     
1081         PR gdb/23127
1082         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
1083         set_gdbarch_significant_addr_bit.
1084         * aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
1085         set_gdbarch_significant_addr_bit.
1086         * utils.c (address_significant): Update to sign extend addr.
1087
1088 2018-05-09  Max Filippov  <jcmvbkbc@gmail.com>
1089
1090         * xtensa-linux-tdep.c (xtensa-tdep.h): New include.
1091         (xtensa_linux_init_abi): Limit tdep->num_regs by
1092         tdep->num_nopriv_regs.
1093         * xtensa-tdep.c (xtensa_derive_tdep): Calculate
1094         tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's
1095         not initialized.
1096
1097 2018-05-08  Simon Marchi  <simon.marchi@ericsson.com>
1098
1099         * unittests/string_view-selftests.c: Define GNULIB_NAMESPACE.
1100
1101 2018-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1102
1103         * common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
1104         (I387_MXCSR_INIT_VAL): New constant.
1105         * amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
1106         buffer if it was supplied by the inferior.
1107         * i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
1108         (i387_xsave_get_clear_bv): New function.
1109         (i387_supply_xsave): Only read x87 control registers from the
1110         xsave buffer if the feature is enabled, and the state will have
1111         been written, otherwise, provide a suitable default.
1112         (i387_collect_xsave): Pre-clear all registers in xsave buffer,
1113         including x87 control registers.  Update control registers if they
1114         have changed from the default value, and mark features as enabled
1115         as required.
1116         * i387-tdep.h (i387_xsave_get_clear_bv): Declare.
1117
1118 2018-05-08  Ulrich Weigand  <uweigand@de.ibm.com>
1119
1120         * spu-tdep.c (info_spu_event_command): Fix output formatting.
1121
1122 2018-05-07  Tom Tromey  <tom@tromey.com>
1123
1124         * configure: Rebuild.
1125         * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond.
1126
1127 2018-05-07  Tom Tromey  <tom@tromey.com>
1128
1129         PR tdep/20362:
1130         * arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
1131         bit.  Use correct value for VDIV.
1132
1133 2018-05-04  Tom Tromey  <tom@tromey.com>
1134
1135         * configure: Rebuild.
1136         * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.
1137
1138 2018-05-04  Tom Tromey  <tom@tromey.com>
1139
1140         * linux-record.c (record_linux_system_call) <case
1141         RECORD_SYS_RECVFROM>: Add "break".
1142
1143 2018-05-04  Tom Tromey  <tom@tromey.com>
1144
1145         * mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
1146         Add missing "break".
1147         * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
1148         Add missing "break".
1149
1150 2018-05-04  Tom Tromey  <tom@tromey.com>
1151
1152         * rs6000-tdep.c (ppc_process_record_op4)
1153         (ppc_process_record_op63): Add fall-through comment.
1154
1155 2018-05-04  Tom Tromey  <tom@tromey.com>
1156
1157         * i386-tdep.c (i386_process_record): Add fall-through comment.
1158
1159 2018-05-04  Tom Tromey  <tom@tromey.com>
1160
1161         * stabsread.c (define_symbol) <case 'p'>: Add fall-through
1162         comment.
1163
1164 2018-05-04  Tom Tromey  <tom@tromey.com>
1165
1166         * riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
1167         * utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
1168         * eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
1169         comment.
1170         * d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
1171         comment.
1172         * coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
1173         comment.
1174
1175 2018-05-04  Tom Tromey  <tom@tromey.com>
1176
1177         * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
1178
1179 2018-05-04  Tom Tromey  <tom@tromey.com>
1180
1181         * s390-tdep.c (s390_process_record): Fix fall-through comments.
1182         * xcoffread.c (scan_xcoff_symtab): Move comment later.
1183         * symfile.c (section_is_mapped): Fix fall-through comment.
1184         * stabsread.c (define_symbol, read_member_functions): Fix
1185         fall-through comment.
1186         * s390-linux-tdep.c (s390_process_record): Fix fall-through
1187         comment.
1188         * remote.c (remote_wait_as): Fix fall-through comment.
1189         * p-exp.y (yylex): Fix fall-through comment.
1190         * nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
1191         comment.
1192         * msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
1193         * mdebugread.c (parse_partial_symbols): Fix fall-through comment.
1194         * jv-exp.y (yylex): Fix fall-through comment.
1195         * go-exp.y (lex_one_token): Fix fall-through comment.
1196         * gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
1197         fall-through comment.
1198         * f-exp.y (yylex): Fix fall-through comment.
1199         * dwarf2read.c (process_die): Fix fall-through comments.
1200         * dbxread.c (process_one_symbol): Fix fall-through comment.
1201         * d-exp.y (lex_one_token): Fix fall-through comment.
1202         * cp-name-parser.y (yylex): Fix fall-through comment.
1203         * coffread.c (coff_symtab_read): Fix fall-through comment.
1204         * c-exp.y (lex_one_token): Fix fall-through comment.
1205         * arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
1206         comment.
1207         * arch/arm.c (arm_instruction_changes_pc): Fix fall-through
1208         comment.
1209
1210 2018-05-04  Tom Tromey  <tom@tromey.com>
1211
1212         PR python/22730:
1213         * NEWS: Mention gdb.execute change.
1214         * gdbcmd.h (execute_control_command): Don't declare.
1215         * python/python.c (execute_gdb_command): Use read_command_lines_1,
1216         execute_control_commands, execute_control_commands_to_string.
1217         * cli/cli-script.h (execute_control_commands)
1218         (execute_control_commands_to_string): Declare.
1219         (execute_control_command): Add from_tty parameter.
1220         * cli/cli-script.c (execute_control_commands)
1221         (execute_control_commands_to_string): New functions.
1222         (execute_user_command): Use execute_control_commands.
1223         (execute_control_command_1): Add "from_tty" parameter.  Update.
1224         (execute_control_command): Likewise.
1225
1226 2018-05-04  Tom Tromey  <tom@tromey.com>
1227
1228         PR python/22731:
1229         * NEWS: Mention that breakpoint commands are writable.
1230         * python/py-breakpoint.c (bppy_set_commands): New function.
1231         (breakpoint_object_getset) <"commands">: Use it.
1232
1233 2018-05-04  Tom Tromey  <tom@tromey.com>
1234
1235         * tracepoint.c (actions_command): Update.
1236         * mi/mi-cmd-break.c (mi_command_line_array)
1237         (mi_command_line_array_cnt, mi_command_line_array_ptr)
1238         (mi_read_next_line): Remove.
1239         (mi_cmd_break_commands): Update.
1240         * cli/cli-script.h (read_command_lines, read_command_lines_1): Use
1241         function_view.
1242         * cli/cli-script.c (get_command_line): Update.
1243         (process_next_line): Use function_view.  Constify.
1244         (recurse_read_control_structure, read_command_lines)
1245         (read_command_lines_1): Change argument types to function_view.
1246         (do_define_command, document_command): Update.
1247         * breakpoint.h (check_tracepoint_command): Don't declare.
1248         * breakpoint.c (check_tracepoint_command): Remove.
1249         (commands_command_1, create_tracepoint_from_upload): Update.
1250
1251 2018-05-04  Tom Tromey  <tom@tromey.com>
1252
1253         PR gdb/11750:
1254         * cli/cli-script.h (enum command_control_type) <define_control>:
1255         New constant.
1256         * cli/cli-script.c (multi_line_command_p): Handle define_control.
1257         (build_command_line, execute_control_command_1)
1258         (process_next_line): Likewise.
1259         (do_define_command): New function, extracted from define_command.
1260         (define_command): Use it.
1261
1262 2018-05-04  Tom Tromey  <tom@tromey.com>
1263
1264         * tracepoint.c (actions_command): Update.
1265         * cli/cli-script.h (read_command_lines): Update.
1266         * cli/cli-script.c (read_command_lines): Constify prompt_arg.
1267         (MAX_TMPBUF): Remove define.
1268         (define_command): Use string_printf.
1269         (document_command): Likewise.
1270         * breakpoint.c (commands_command_1): Update.
1271
1272 2018-05-04  Tom Tromey  <tom@tromey.com>
1273
1274         * top.c (execute_command): Update.
1275         * cli/cli-script.h (print_command_lines): Now varargs.
1276         * cli/cli-script.c (print_command_lines): Now varargs.
1277         (execute_control_command_1) <case while_control, case if_control>:
1278         Update.
1279
1280 2018-05-04  Tom Tromey  <tom@tromey.com>
1281
1282         * tracepoint.c (all_tracepoint_actions): Rename from
1283         all_tracepoint_actions_and_cleanup.  Change return type.
1284         (actions_command, encode_actions_1, encode_actions)
1285         (trace_dump_actions, tdump_command): Update.
1286         * remote.c (remote_download_command_source): Update.
1287         * python/python.c (gdbpy_eval_from_control_command)
1288         (python_command, python_interactive_command): Update.
1289         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
1290         * guile/guile.c (guile_command)
1291         (gdbscm_eval_from_control_command, guile_command): Update.
1292         * compile/compile.c (compile_code_command)
1293         (compile_print_command, compile_to_object): Update.
1294         * cli/cli-script.h (struct command_lines_deleter): New.
1295         (counted_command_line): New typedef.
1296         (struct command_line): Add constructor, destructor.
1297         <body_list>: Remove.
1298         <body_list_0, body_list_1>: New members.
1299         (command_line_up): Remove typedef.
1300         (read_command_lines, read_command_lines_1, get_command_line):
1301         Update.
1302         (copy_command_lines): Don't declare.
1303         * cli/cli-script.c (build_command_line): Use "new".
1304         (get_command_line): Return counted_command_line.
1305         (print_command_lines, execute_user_command)
1306         (execute_control_command_1, while_command, if_command): Update.
1307         (realloc_body_list): Remove.
1308         (process_next_line, recurse_read_control_structure): Update.
1309         (read_command_lines, read_command_lines_1): Return counted_command_line.
1310         (free_command_lines): Use "delete".
1311         (copy_command_lines): Remove.
1312         (define_command, document_command, show_user_1): Update.
1313         * cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
1314         a counted_command_line.
1315         * breakpoint.h (counted_command_line): Remove typedef.
1316         (breakpoint_set_commands): Update.
1317         * breakpoint.c (check_no_tracepoint_commands)
1318         (validate_commands_for_breakpoint): Update.
1319         (breakpoint_set_commands): Change commands to be a
1320         counted_command_line.
1321         (commands_command_1, update_dprintf_command_list)
1322         (create_tracepoint_from_upload): Update.
1323
1324 2018-05-04  Tom Tromey  <tom@tromey.com>
1325
1326         * cli/cli-decode.h (cmd_list_element): New constructor.
1327         (~cmd_list_element): New destructor.
1328         (struct cmd_list_element): Add initializers.
1329         * cli/cli-decode.c (do_add_cmd): Use "new".
1330         (delete_cmd): Use "delete".
1331
1332 2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
1333             Pedro Alves <palves@redhat.com>
1334
1335         PR breakpoints/19806 and support for PR external/20207.
1336         * NEWS: Mention Aarch64 watchpoint improvements.
1337         * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
1338         watchpoints and PR external/20207 watchpoints.
1339         * nat/aarch64-linux-hw-point.c
1340         (kernel_supports_any_contiguous_range): New.
1341         (aarch64_watchpoint_offset): New.
1342         (aarch64_watchpoint_length): Support PR external/20207 watchpoints.
1343         (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
1344         (aarch64_point_is_aligned): Support PR external/20207 watchpoints.
1345         (aarch64_align_watchpoint): New parameters aligned_offset_p and
1346         next_addr_orig_p.  Support PR external/20207 watchpoints.
1347         (aarch64_downgrade_regs): New.
1348         (aarch64_dr_state_insert_one_point): New parameters offset and
1349         addr_orig.
1350         (aarch64_dr_state_remove_one_point): Likewise.
1351         (aarch64_handle_breakpoint): Update caller.
1352         (aarch64_handle_aligned_watchpoint): Likewise.
1353         (aarch64_handle_unaligned_watchpoint): Support addr_orig and
1354         aligned_offset.
1355         (aarch64_linux_set_debug_regs): Remove const from state.  Call
1356         aarch64_downgrade_regs.
1357         (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
1358         * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
1359         (DR_CONTROL_MASK): ... this.
1360         (struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
1361         (unsigned int aarch64_watchpoint_offset): New prototype.
1362         (aarch64_linux_set_debug_regs): Remove const from state.
1363         * utils.c (align_up, align_down): Move to ...
1364         * common/common-utils.c (align_up, align_down): ... here.
1365         * utils.h (align_up, align_down): Move to ...
1366         * common/common-utils.h (align_up, align_down): ... here.
1367
1368 2018-05-04  Joel Brobecker  <brobecker@adacore.com>
1369
1370         * sparc-tdep.c (sparc_structure_return_p): Re-implement to
1371         match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
1372         (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
1373         Re-implement to match the ABI as summarized in GCC's
1374         gcc/config/sparc/sparc.c.  All callers updated.
1375         (sparc32_store_arguments): Remove assertion.
1376
1377 2018-05-04  Tom Tromey  <tom@tromey.com>
1378
1379         * printcmd.c: Don't include tui.h.
1380         (decode_format): Use skip_spaces.
1381
1382 2018-05-04  Tom Tromey  <tom@tromey.com>
1383
1384         PR gdb/22619:
1385         * printcmd.c (last_count): New global.
1386         (x_command): Use saved count when repeating.
1387
1388 2018-05-04  Tom Tromey  <tom@tromey.com>
1389
1390         * nto-procfs.c (do_closedir_cleanup): Remove.
1391         (procfs_pidlist): Use gdb_dir_up.
1392         * procfs.c (do_closedir_cleanup): Remove.
1393         (proc_update_threads): Use gdb_dir_up.
1394         * common/filestuff.h (struct gdb_dir_deleter): New.
1395         (gdb_dir_up): New typedef.
1396
1397 2018-05-04  Tom Tromey  <tom@tromey.com>
1398
1399         * ada-lang.c (print_mention_exception): Use std::string.
1400
1401 2018-05-04  Tom Tromey  <tom@tromey.com>
1402
1403         * ada-lang.c (create_excep_cond_exprs): Update.
1404         (ada_exception_catchpoint_cond_string): Use std::string.
1405
1406 2018-05-04  Tom Tromey  <tom@tromey.com>
1407
1408         * ada-lang.c (xget_renaming_scope): Return std::string.
1409         (old_renaming_is_invisible): Update.
1410
1411 2018-05-04  Tom Tromey  <tom@tromey.com>
1412
1413         * bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
1414         (target_bfd::target_bfd, target_bfd::~target_bfd): Update.
1415
1416 2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>
1417
1418         * spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.
1419
1420 2018-05-04  Tom Tromey  <tom@tromey.com>
1421
1422         * remote.c (remote_query_supported_append): Change type.
1423         (remote_check_symbols): Update.
1424
1425 2018-05-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
1426
1427         PR gdb/11420
1428         * configure.ac: Prepend libpython.
1429         * python/python-config.py: Likewise.
1430         * configure: Regenerate.
1431
1432 2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
1433
1434         * Makefile.in (%.c: %.l): Use -t instead of --stdout.
1435
1436 2018-05-03  Pedro Alves  <palves@redhat.com>
1437
1438         * s390-linux-nat.c
1439         (s390_linux_nat_target::have_continuable_watchpoint): Mark with
1440         override.  Write 'true' instead of '1'.
1441         (s390_linux_nat_target::watchpoint_addr_within_range): Remove
1442         declaration.
1443
1444 2018-05-02  Pedro Alves  <palves@redhat.com>
1445
1446         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
1447         add_inf_child_target.
1448         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
1449         add_inf_child_target.
1450         * aix-thread.c (aix_thread_target_info): New.
1451         (aix_thread_target) <shortname, longname, doc>: Delete.
1452         <info>: New.
1453         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
1454         add_inf_child_target.
1455         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
1456         add_inf_child_target.
1457         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
1458         add_inf_child_target.
1459         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
1460         add_inf_child_target.
1461         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
1462         add_inf_child_target.
1463         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
1464         add_inf_child_target.
1465         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
1466         add_inf_child_target.
1467         * arm-linux-nat.c (_initialize_arm_linux_nat): Use
1468         add_inf_child_target.
1469         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
1470         add_inf_child_target.
1471         * bfd-target.c (target_bfd_target_info): New.
1472         (target_bfd) <shortname, longname, doc>: Delete.
1473         <info>: New.
1474         * bsd-kvm.c (bsd_kvm_target_info): New.
1475         (bsd_kvm_target) <shortname, longname, doc>: Delete.
1476         <info>: New.
1477         (bsd_kvm_target::open): Rename to ...
1478         (bsd_kvm_target_open): ... this.  Adjust.
1479         * bsd-uthread.c (bsd_uthread_target_info): New.
1480         (bsd_uthread_target) <shortname, longname, doc>: Delete.
1481         <info>: New.
1482         * corefile.c (core_file_command): Adjust.
1483         * corelow.c (core_target_info): New.
1484         (core_target) <shortname, longname, doc>: Delete.
1485         <info>: New.
1486         (core_target::open): Rename to ...
1487         (core_target_open): ... this.  Adjust.
1488         * ctf.c (ctf_target_info): New.
1489         (ctf_target) <shortname, longname, doc>: Delete.
1490         <info>: New.
1491         (ctf_target::open): Rename to ...
1492         (ctf_target_open): ... this.
1493         (_initialize_ctf): Adjust.
1494         * exec.c (exec_target_info): New.
1495         (exec_target) <shortname, longname, doc>: Delete.
1496         <info>: New.
1497         (exec_target::open): Rename to ...
1498         (exec_target_open): ... this.
1499         * gdbcore.h (core_target_open): Declare.
1500         * go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
1501         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
1502         add_inf_child_target.
1503         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
1504         add_inf_child_target.
1505         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
1506         add_inf_child_target.
1507         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
1508         add_inf_child_target.
1509         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
1510         add_inf_child_target.
1511         * i386-gnu-nat.c (_initialize_i386gnu_nat): Use
1512         add_inf_child_target.
1513         * i386-linux-nat.c (_initialize_i386_linux_nat): Use
1514         add_inf_child_target.
1515         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
1516         add_inf_child_target.
1517         * i386-obsd-nat.c (_initialize_i386obsd_nat): Use
1518         add_inf_child_target.
1519         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
1520         add_inf_child_target.
1521         * inf-child.c (inf_child_target_info): New.
1522         (inf_child_target::info): New.
1523         (inf_child_open_target): Remove 'target' parameter.  Use
1524         get_native_target instead.
1525         (inf_child_target::open): Delete.
1526         (add_inf_child_target): New.
1527         * inf-child.h (inf_child_target) <shortname, longname, doc, open>:
1528         Delete.
1529         <info>: New.
1530         (add_inf_child_target): Declare.
1531         (inf_child_open_target): Declare.
1532         * linux-thread-db.c (thread_db_target_info): New.
1533         (thread_db_target) <shortname, longname, doc>: Delete.
1534         <info>: New.
1535         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
1536         add_inf_child_target.
1537         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
1538         add_inf_child_target.
1539         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
1540         add_inf_child_target.
1541         * m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
1542         add_inf_child_target.
1543         * make-target-delegates (print_class): Adjust.
1544         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
1545         add_inf_child_target.
1546         * mips-linux-nat.c (_initialize_mips_linux_nat): Use
1547         add_inf_child_target.
1548         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
1549         add_inf_child_target.
1550         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
1551         add_inf_child_target.
1552         * nto-procfs.c (nto_native_target_info): New.
1553         (nto_procfs_target_native) <shortname, longname, doc>:
1554         Delete.
1555         <info>: New.
1556         (nto_procfs_target_info): New.
1557         (nto_procfs_target_procfs) <shortname, longname, doc>:
1558         Delete.
1559         <info>: New.
1560         (init_procfs_targets): Adjust.
1561         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
1562         add_inf_child_target.
1563         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
1564         add_inf_child_target.
1565         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
1566         add_inf_child_target.
1567         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
1568         add_inf_child_target.
1569         * ravenscar-thread.c (ravenscar_target_info): New.
1570         (ravenscar_thread_target) <shortname, longname, doc>:
1571         Delete.
1572         <info>: New.
1573         * record-btrace.c (record_btrace_target_info):
1574         (record_btrace_target) <shortname, longname, doc>: Delete.
1575         <info>: New.
1576         (record_btrace_target::open): Rename to ...
1577         (record_btrace_target_open): ... this.  Adjust.
1578         * record-full.c (record_longname, record_doc): New.
1579         (record_full_base_target) <shortname, longname, doc>: Delete.
1580         <info>: New.
1581         (record_full_target_info): New.
1582         (record_full_target): <shortname>: Delete.
1583         <info>: New.
1584         (record_full_core_open_1, record_full_open_1): Update comments.
1585         (record_full_base_target::open): Rename to ...
1586         (record_full_open): ... this.
1587         (cmd_record_full_restore): Update.
1588         (_initialize_record_full): Update.
1589         * remote-sim.c (remote_sim_target_info): New.
1590         (gdbsim_target) <shortname, longname, doc>: Delete.
1591         <info>: New.
1592         (gdbsim_target::open): Rename to ...
1593         (gdbsim_target_open): ... this.
1594         (_initialize_remote_sim): Adjust.
1595         * remote.c (remote_doc): New.
1596         (remote_target_info): New.
1597         (remote_target) <shortname, longname, doc>: Delete.
1598         <info>: New.
1599         (extended_remote_target_info): New.
1600         (extended_remote_target) <shortname, longname, doc>: Delete.
1601         <info>: New.
1602         (remote_target::open_1): Make static.  Adjust.
1603         * rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
1604         * s390-linux-nat.c (_initialize_s390_nat): Use
1605         add_inf_child_target.
1606         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
1607         add_inf_child_target.
1608         * sol-thread.c (thread_db_target_info): New.
1609         (sol_thread_target) <shortname, longname, doc>: Delete.
1610         <info>: New.
1611         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
1612         add_inf_child_target.
1613         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
1614         add_inf_child_target.
1615         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
1616         add_inf_child_target.
1617         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
1618         add_inf_child_target.
1619         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
1620         add_inf_child_target.
1621         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
1622         add_inf_child_target.
1623         * spu-linux-nat.c (_initialize_spu_nat): Use
1624         add_inf_child_target.
1625         * spu-multiarch.c (spu_multiarch_target_info): New.
1626         (spu_multiarch_target) <shortname, longname, doc>: Delete.
1627         <info>: New.
1628         * target-delegates.c: Regenerate.
1629         * target.c: Include <unordered_map>.
1630         (target_ops_p): Delete.
1631         (DEF_VEC_P(target_ops_p)): Delete.
1632         (target_factories): New.
1633         (test_target_info): New.
1634         (test_target_ops::info): New.
1635         (open_target): Adjust to use target_factories.
1636         (add_target_with_completer): Rename to ...
1637         (add_target): ... this.  Change prototype.  Register target_info
1638         and open callback in target_factories.  Register target_info in
1639         command context instead of target_ops.
1640         (add_target): Delete old implementation.
1641         (add_deprecated_target_alias): Change prototype.  Adjust.
1642         (the_native_target): New.
1643         (set_native_target, get_native_target): New.
1644         (find_default_run_target): Use the_native_target.
1645         (find_attach_target, find_run_target): Simplify.
1646         (target_ops::open): Delete.
1647         (dummy_target_info): New.
1648         (dummy_target::shortname, dummy_target::longname)
1649         (dummy_target::doc): Delete.
1650         (dummy_target::info): New.
1651         (debug_target::shortname, debug_target::longname)
1652         (debug_target::doc): Delete.
1653         (debug_target::info): New.
1654         * target.h (struct target_info): New.
1655         (target_ops::~target_ops): Add comment.
1656         (target_ops::info): New.
1657         (target_ops::shortname, target_ops::longname, target_ops::doc): No
1658         longer virtual.  Implement in terms of target_info.
1659         (set_native_target, get_native_target): Declare.
1660         (target_open_ftype): New.
1661         (add_target, add_target_with_completer)
1662         (add_deprecated_target_alias): Change prototype.
1663         (test_target) <shortname, longname, doc>: Delete.
1664         <info>: New.
1665         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
1666         add_inf_child_target.
1667         * tracefile-tfile.c (tfile_target_info): New.
1668         (tfile_target) <shortname, longname, doc>: Delete.
1669         <info>: New.
1670         (tfile_target::open): Rename to ...
1671         (tfile_target_open): ... this.
1672         (_initialize_tracefile_tfile): Adjust.
1673         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
1674         add_inf_child_target.
1675         * windows-nat.c (_initialize_windows_nat): Use
1676         add_inf_child_target.
1677         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
1678         add_inf_child_target.
1679
1680 2018-05-02  Pedro Alves  <palves@redhat.com>
1681
1682         * linux-nat.h (linux_nat_target) <low_new_thread,
1683         low_delete_thread, low_new_fork, low_forget_process,
1684         low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
1685         New virtual methods.
1686         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1687         (linux_nat_new_fork_ftype, linux_nat_set_new_fork)
1688         (linux_nat_forget_process_ftype, linux_nat_set_forget_process)
1689         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1690         (linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
1691         Delete.
1692         * linux-fork.c (delete_fork): Adjust to call low method.
1693         * linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
1694         (linux_nat_new_fork, linux_nat_forget_process_hook)
1695         (linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
1696         (linux_nat_status_is_event):
1697         (linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
1698         (linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
1699         to call low method.
1700         (sigtrap_is_event): Rename to ...
1701         (linux_nat_target::low_status_is_event): ... this.
1702         (linux_nat_set_status_is_event): Delete.
1703         (save_stop_reason, linux_nat_wait_1)
1704         (linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
1705         low methods.
1706         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1707         (linux_nat_set_new_fork, linux_nat_set_forget_process)
1708         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1709         (linux_nat_set_prepare_to_resume): Delete.
1710         * aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
1711         low virtual methods.
1712         * amd64-linux-nat.c: Likewise.
1713         * arm-linux-nat.c: Likewise.
1714         * i386-linux-nat.c: Likewise.
1715         * ia64-linux-nat.c: Likewise.
1716         * mips-linux-nat.c: Likewise.
1717         * ppc-linux-nat.c: Likewise.
1718         * s390-linux-nat.c: Likewise.
1719         * sparc64-linux-nat.c: Likewise.
1720         * x86-linux-nat.c: Likewise.
1721         * x86-linux-nat.h: Include "nat/x86-linux.h".
1722         (x86_linux_nat_target) <low_new_fork, low_forget_process,
1723         low_prepare_to_resume, low_new_thread, low_delete_thread>:
1724         Override methods.
1725
1726 2018-05-02  Pedro Alves  <palves@redhat.com>
1727
1728         * target.h (target_ops)
1729         <stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
1730         stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
1731         stopped_by_watchpoint, have_continuable_watchpoint,
1732         stopped_data_address, watchpoint_addr_within_range,
1733         can_accel_watchpoint_condition, can_run, thread_alive,
1734         has_all_memory, has_memory, has_stack, has_registers,
1735         has_execution, can_async_p, is_async_p, supports_non_stop,
1736         always_non_stop_p, can_execute_reverse, supports_multi_process,
1737         supports_enable_disable_tracepoint,
1738         supports_disable_randomization, supports_string_tracing,
1739         supports_evaluation_of_breakpoint_conditions,
1740         can_run_breakpoint_commands, filesystem_is_local,
1741         can_download_tracepoint, get_trace_state_variable_value,
1742         set_trace_notes, get_tib_address, use_agent, can_use_agent,
1743         record_is_replaying, record_will_replay,
1744         augmented_libraries_svr4_read>: Adjust to return bool.
1745         * aarch64-linux-nat.c: All implementations adjusted.
1746         * aix-thread.c: All implementations adjusted.
1747         * arm-linux-nat.c: All implementations adjusted.
1748         * breakpoint.c: All implementations adjusted.
1749         * bsd-kvm.c: All implementations adjusted.
1750         * bsd-uthread.c: All implementations adjusted.
1751         * corelow.c: All implementations adjusted.
1752         * ctf.c: All implementations adjusted.
1753         * darwin-nat.c: All implementations adjusted.
1754         * darwin-nat.h: All implementations adjusted.
1755         * exec.c: All implementations adjusted.
1756         * fbsd-nat.c: All implementations adjusted.
1757         * fbsd-nat.h: All implementations adjusted.
1758         * gnu-nat.c: All implementations adjusted.
1759         * gnu-nat.h: All implementations adjusted.
1760         * go32-nat.c: All implementations adjusted.
1761         * ia64-linux-nat.c: All implementations adjusted.
1762         * inf-child.c: All implementations adjusted.
1763         * inf-child.h: All implementations adjusted.
1764         * inf-ptrace.c: All implementations adjusted.
1765         * inf-ptrace.h: All implementations adjusted.
1766         * linux-nat.c: All implementations adjusted.
1767         * linux-nat.h: All implementations adjusted.
1768         * mips-linux-nat.c: All implementations adjusted.
1769         * nto-procfs.c: All implementations adjusted.
1770         * ppc-linux-nat.c: All implementations adjusted.
1771         * procfs.c: All implementations adjusted.
1772         * ravenscar-thread.c: All implementations adjusted.
1773         * record-btrace.c: All implementations adjusted.
1774         * record-full.c: All implementations adjusted.
1775         * remote-sim.c: All implementations adjusted.
1776         * remote.c: All implementations adjusted.
1777         * s390-linux-nat.c: All implementations adjusted.
1778         * sol-thread.c: All implementations adjusted.
1779         * spu-multiarch.c: All implementations adjusted.
1780         * target-delegates.c: All implementations adjusted.
1781         * target.c: All implementations adjusted.
1782         * target.h: All implementations adjusted.
1783         * tracefile-tfile.c: All implementations adjusted.
1784         * tracefile.c: All implementations adjusted.
1785         * tracefile.h: All implementations adjusted.
1786         * windows-nat.c: All implementations adjusted.
1787         * x86-linux-nat.h: All implementations adjusted.
1788         * x86-nat.h: All implementations adjusted.
1789
1790 2018-05-02  Pedro Alves  <palves@redhat.com>
1791
1792         * make-target-delegates (scan_target_h): Don't trim lines here.
1793         Replace sequences of tabs and/or whitespace with a single
1794         whitespace.
1795         (top level, parsing methods): Trim each line before processing it
1796         here.
1797
1798 2018-05-02  Pedro Alves  <palves@redhat.com>
1799             John Baldwin  <jhb@freebsd.org>
1800
1801         * target.h (enum strata) <debug_stratum>: New.
1802         (struct target_ops) <all delegation methods>: Replace by C++
1803         virtual methods, and drop "to_" prefix.  All references updated
1804         throughout.
1805         <to_shortname, to_longname, to_doc, to_data,
1806         to_have_steppable_watchpoint, to_have_continuable_watchpoint,
1807         to_has_thread_control, to_attach_no_wait>: Delete, replaced by
1808         virtual methods.  All references updated throughout.
1809         <can_attach, supports_terminal_ours, can_create_inferior,
1810         get_thread_control_capabilities, attach_no_wait>: New
1811         virtual methods.
1812         <insert_breakpoint, remove_breakpoint>: Now
1813         TARGET_DEFAULT_NORETURN methods.
1814         <info_proc>: Now returns bool.
1815         <to_magic>: Delete.
1816         (OPS_MAGIC): Delete.
1817         (current_target): Delete.  All references replaced by references
1818         to ...
1819         (target_stack): ... this.  New.
1820         (target_shortname, target_longname): Adjust.
1821         (target_can_run): Now a function declaration.
1822         (default_child_has_all_memory, default_child_has_memory)
1823         (default_child_has_stack, default_child_has_registers)
1824         (default_child_has_execution): Remove target_ops parameter.
1825         (complete_target_initialization): Delete.
1826         (memory_breakpoint_target): New template class.
1827         (test_target_ops): Refactor as a C++ class with virtual methods.
1828         * make-target-delegates (NAME_PART): Tighten.
1829         (POINTER_PART, CP_SYMBOL): New.
1830         (SIMPLE_RETURN_PART): Reimplement.
1831         (VEC_RETURN_PART): Expect less.
1832         (RETURN_PART, VIRTUAL_PART): New.
1833         (METHOD): Adjust to C++ virtual methods.
1834         (scan_target_h): Remove reference to C99.
1835         (dname): Output "target_ops::" prefix.
1836         (write_function_header): Adjust to output a C++ class method.
1837         (write_declaration): New.
1838         (write_delegator): Adjust to output a C++ class method.
1839         (tdname): Output "dummy_target::" prefix.
1840         (write_tdefault, write_debugmethod): Adjust to output a C++ class
1841         method.
1842         (tdefault_names, debug_names): Delete.
1843         (return_types, tdefaults, styles, argtypes_array): New.
1844         (top level): All methods are delegators.
1845         (print_class): New.
1846         (top level): Print dummy_target and debug_target classes.
1847         * target-delegates.c: Regenerate.
1848         * target-debug.h (target_debug_print_enum_info_proc_what)
1849         (target_debug_print_thread_control_capabilities)
1850         (target_debug_print_thread_info_p): New.
1851         * target.c (dummy_target): Delete.
1852         (the_dummy_target, the_debug_target): New.
1853         (target_stack): Now extern.
1854         (set_targetdebug): Push/unpush debug target.
1855         (default_child_has_all_memory, default_child_has_memory)
1856         (default_child_has_stack, default_child_has_registers)
1857         (default_child_has_execution): Remove target_ops parameter.
1858         (complete_target_initialization): Delete.
1859         (add_target_with_completer): No longer call
1860         complete_target_initialization.
1861         (target_supports_terminal_ours): Use regular delegation.
1862         (update_current_target): Delete.
1863         (push_target): No longer check magic number.  Don't call
1864         update_current_target.
1865         (unpush_target): Don't call update_current_target.
1866         (target_is_pushed): No longer check magic number.
1867         (target_require_runnable): Skip for all stratums over
1868         process_stratum.
1869         (target_ops::info_proc): New.
1870         (target_info_proc): Use find_target_at and
1871         find_default_run_target.
1872         (target_supports_disable_randomization): Use regular delegation.
1873         (target_get_osdata): Use find_target_at.
1874         (target_ops::open, target_ops::close, target_ops::can_attach)
1875         (target_ops::attach, target_ops::can_create_inferior)
1876         (target_ops::create_inferior, target_ops::can_run)
1877         (target_can_run): New.
1878         (default_fileio_target): Use regular delegation.
1879         (target_ops::fileio_open, target_ops::fileio_pwrite)
1880         (target_ops::fileio_pread, target_ops::fileio_fstat)
1881         (target_ops::fileio_close, target_ops::fileio_unlink)
1882         (target_ops::fileio_readlink): New.
1883         (target_fileio_open_1, target_fileio_unlink)
1884         (target_fileio_readlink): Always call the target method.  Handle
1885         FILEIO_ENOSYS.
1886         (return_zero, return_zero_has_execution): Delete.
1887         (init_dummy_target): Delete.
1888         (dummy_target::dummy_target, dummy_target::shortname)
1889         (dummy_target::longname, dummy_target::doc)
1890         (debug_target::debug_target, debug_target::shortname)
1891         (debug_target::longname, debug_target::doc): New.
1892         (target_supports_delete_record): Use regular delegation.
1893         (setup_target_debug): Delete.
1894         (maintenance_print_target_stack): Skip debug_stratum.
1895         (initialize_targets): Instantiate the_dummy_target and
1896         the_debug_target.
1897         * auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
1898         use target_stack.
1899         (target_auxv_search, fprint_target_auxv): Adjust.
1900         (info_auxv_command): Adjust to use target_stack.
1901         * auxv.h (target_auxv_parse): Remove 'ops' parameter.
1902         * exceptions.c (print_flush): Handle a NULL target_stack.
1903         * regcache.c (target_ops_no_register): Refactor as class with
1904         virtual methods.
1905
1906         * exec.c (exec_target): New class.
1907         (exec_ops): Now an exec_target.
1908         (exec_open, exec_close_1, exec_get_section_table)
1909         (exec_xfer_partial, exec_files_info, exec_has_memory)
1910         (exec_make_note_section): Refactor as exec_target methods.
1911         (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
1912         Delete.
1913         (exec_target::find_memory_regions): New.
1914         (_initialize_exec): Don't call init_exec_ops.
1915         * gdbcore.h (exec_file_clear): Delete.
1916
1917         * corefile.c (core_target): Delete.
1918         (core_file_command): Adjust.
1919         * corelow.c (core_target): New class.
1920         (the_core_target): New.
1921         (core_close): Remove target_ops parameter.
1922         (core_close_cleanup): Adjust.
1923         (core_target::close): New.
1924         (core_open, core_detach, get_core_registers, core_files_info)
1925         (core_xfer_partial, core_thread_alive, core_read_description)
1926         (core_pid_to_str, core_thread_name, core_has_memory)
1927         (core_has_stack, core_has_registers, core_info_proc): Rework as
1928         core_target methods.
1929         (ignore, core_remove_breakpoint, init_core_ops): Delete.
1930         (_initialize_corelow): Initialize the_core_target.
1931         * gdbcore.h (core_target): Delete.
1932         (the_core_target): New.
1933
1934         * ctf.c: (ctf_target): New class.
1935         (ctf_ops): Now a ctf_target.
1936         (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
1937         (ctf_xfer_partial, ctf_get_trace_state_variable_value)
1938         (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
1939         methods.
1940         (init_ctf_ops): Delete.
1941         (_initialize_ctf): Don't call it.
1942         * tracefile-tfile.c (tfile_target): New class.
1943         (tfile_ops): Now a tfile_target.
1944         (tfile_open, tfile_close, tfile_files_info)
1945         (tfile_get_tracepoint_status, tfile_trace_find)
1946         (tfile_fetch_registers, tfile_xfer_partial)
1947         (tfile_get_trace_state_variable_value, tfile_traceframe_info):
1948         Refactor as tfile_target methods.
1949         (tfile_xfer_partial_features): Remove target_ops parameter.
1950         (init_tfile_ops): Delete.
1951         (_initialize_tracefile_tfile): Don't call it.
1952         * tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
1953         (tracefile_has_stack, tracefile_has_registers)
1954         (tracefile_thread_alive, tracefile_get_trace_status): Refactor as
1955         tracefile_target methods.
1956         (init_tracefile_ops): Delete.
1957         (tracefile_target::tracefile_target): New.
1958         * tracefile.h: Include "target.h".
1959         (tracefile_target): New class.
1960         (init_tracefile_ops): Delete.
1961
1962         * spu-multiarch.c (spu_multiarch_target): New class.
1963         (spu_ops): Now a spu_multiarch_target.
1964         (spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
1965         (spu_fetch_registers, spu_store_registers, spu_xfer_partial)
1966         (spu_search_memory, spu_mourn_inferior): Refactor as
1967         spu_multiarch_target methods.
1968         (init_spu_ops): Delete.
1969         (_initialize_spu_multiarch): Remove references to init_spu_ops,
1970         complete_target_initialization.
1971
1972         * ravenscar-thread.c (ravenscar_thread_target): New class.
1973         (ravenscar_ops): Now a ravenscar_thread_target.
1974         (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
1975         (ravenscar_thread_alive, ravenscar_pid_to_str)
1976         (ravenscar_fetch_registers, ravenscar_store_registers)
1977         (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
1978         (ravenscar_stopped_by_hw_breakpoint)
1979         (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
1980         (ravenscar_mourn_inferior, ravenscar_core_of_thread)
1981         (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
1982         methods.
1983         (init_ravenscar_thread_ops): Delete.
1984         (_initialize_ravenscar): Remove references to
1985         init_ravenscar_thread_ops and complete_target_initialization.
1986
1987         * bsd-uthread.c (bsd_uthread_ops_hack): Delete.
1988         (bsd_uthread_target): New class.
1989         (bsd_uthread_ops): Now a bsd_uthread_target.
1990         (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
1991         (bsd_uthread_close, bsd_uthread_mourn_inferior)
1992         (bsd_uthread_fetch_registers, bsd_uthread_store_registers)
1993         (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
1994         (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
1995         (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
1996         (bsd_uthread_target): Delete function.
1997         (_initialize_bsd_uthread): Remove reference to
1998         complete_target_initialization.
1999
2000         * bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
2001         (target_bfd): ... this new class.
2002         (target_bfd_xfer_partial, target_bfd_get_section_table)
2003         (target_bfd_close): Refactor as target_bfd methods.
2004         (target_bfd::~target_bfd): New.
2005         (target_bfd_reopen): Adjust.
2006         (target_bfd::close): New.
2007
2008         * record-btrace.c (record_btrace_target): New class.
2009         (record_btrace_ops): Now a record_btrace_target.
2010         (record_btrace_open, record_btrace_stop_recording)
2011         (record_btrace_disconnect, record_btrace_close)
2012         (record_btrace_async, record_btrace_info)
2013         (record_btrace_insn_history, record_btrace_insn_history_range)
2014         (record_btrace_insn_history_from, record_btrace_call_history)
2015         (record_btrace_call_history_range)
2016         (record_btrace_call_history_from, record_btrace_record_method)
2017         (record_btrace_is_replaying, record_btrace_will_replay)
2018         (record_btrace_xfer_partial, record_btrace_insert_breakpoint)
2019         (record_btrace_remove_breakpoint, record_btrace_fetch_registers)
2020         (record_btrace_store_registers, record_btrace_prepare_to_store)
2021         (record_btrace_to_get_unwinder)
2022         (record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
2023         (record_btrace_commit_resume, record_btrace_wait)
2024         (record_btrace_stop, record_btrace_can_execute_reverse)
2025         (record_btrace_stopped_by_sw_breakpoint)
2026         (record_btrace_supports_stopped_by_sw_breakpoint)
2027         (record_btrace_stopped_by_hw_breakpoint)
2028         (record_btrace_supports_stopped_by_hw_breakpoint)
2029         (record_btrace_update_thread_list, record_btrace_thread_alive)
2030         (record_btrace_goto_begin, record_btrace_goto_end)
2031         (record_btrace_goto, record_btrace_stop_replaying_all)
2032         (record_btrace_execution_direction)
2033         (record_btrace_prepare_to_generate_core)
2034         (record_btrace_done_generating_core): Refactor as
2035         record_btrace_target methods.
2036         (init_record_btrace_ops): Delete.
2037         (_initialize_record_btrace): Remove reference to
2038         init_record_btrace_ops.
2039         * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
2040         the execution_direction global.
2041         (record_full_base_target, record_full_target)
2042         (record_full_core_target): New classes.
2043         (record_full_ops): Now a record_full_target.
2044         (record_full_core_ops): Now a record_full_core_target.
2045         (record_full_target::detach, record_full_target::disconnect)
2046         (record_full_core_target::disconnect)
2047         (record_full_target::mourn_inferior, record_full_target::kill):
2048         New.
2049         (record_full_open, record_full_close, record_full_async): Refactor
2050         as methods of the record_full_base_target class.
2051         (record_full_resume, record_full_commit_resume): Refactor
2052         as methods of the record_full_target class.
2053         (record_full_wait, record_full_stopped_by_watchpoint)
2054         (record_full_stopped_data_address)
2055         (record_full_stopped_by_sw_breakpoint)
2056         (record_full_supports_stopped_by_sw_breakpoint)
2057         (record_full_stopped_by_hw_breakpoint)
2058         (record_full_supports_stopped_by_hw_breakpoint): Refactor as
2059         methods of the record_full_base_target class.
2060         (record_full_store_registers, record_full_xfer_partial)
2061         (record_full_insert_breakpoint, record_full_remove_breakpoint):
2062         Refactor as methods of the record_full_target class.
2063         (record_full_can_execute_reverse, record_full_get_bookmark)
2064         (record_full_goto_bookmark, record_full_execution_direction)
2065         (record_full_record_method, record_full_info, record_full_delete)
2066         (record_full_is_replaying, record_full_will_replay)
2067         (record_full_goto_begin, record_full_goto_end, record_full_goto)
2068         (record_full_stop_replaying): Refactor as methods of the
2069         record_full_base_target class.
2070         (record_full_core_resume, record_full_core_kill)
2071         (record_full_core_fetch_registers)
2072         (record_full_core_prepare_to_store)
2073         (record_full_core_store_registers, record_full_core_xfer_partial)
2074         (record_full_core_insert_breakpoint)
2075         (record_full_core_remove_breakpoint)
2076         (record_full_core_has_execution): Refactor
2077         as methods of the record_full_core_target class.
2078         (record_full_base_target::supports_delete_record): New.
2079         (init_record_full_ops): Delete.
2080         (init_record_full_core_ops): Delete.
2081         (record_full_save): Refactor as method of the
2082         record_full_base_target class.
2083         (_initialize_record_full): Remove references to
2084         init_record_full_ops and init_record_full_core_ops.
2085
2086         * remote.c (remote_target, extended_remote_target): New classes.
2087         (remote_ops): Now a remote_target.
2088         (extended_remote_ops): Now an extended_remote_target.
2089         (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
2090         (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
2091         (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
2092         (remote_pass_signals, remote_set_syscall_catchpoint)
2093         (remote_program_signals, )
2094         (remote_thread_always_alive): Remove target_ops parameter.
2095         (remote_thread_alive, remote_thread_name)
2096         (remote_update_thread_list, remote_threads_extra_info)
2097         (remote_static_tracepoint_marker_at)
2098         (remote_static_tracepoint_markers_by_strid)
2099         (remote_get_ada_task_ptid, remote_close, remote_start_remote)
2100         (remote_open): Refactor as methods of remote_target.
2101         (extended_remote_open, extended_remote_detach)
2102         (extended_remote_attach, extended_remote_post_attach):
2103         (extended_remote_supports_disable_randomization)
2104         (extended_remote_create_inferior): : Refactor as method of
2105         extended_remote_target.
2106         (remote_set_permissions, remote_open_1, remote_detach)
2107         (remote_follow_fork, remote_follow_exec, remote_disconnect)
2108         (remote_resume, remote_commit_resume, remote_stop)
2109         (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
2110         (remote_terminal_ours, remote_wait, remote_fetch_registers)
2111         (remote_prepare_to_store, remote_store_registers)
2112         (remote_flash_erase, remote_flash_done, remote_files_info)
2113         (remote_kill, remote_mourn, remote_insert_breakpoint)
2114         (remote_remove_breakpoint, remote_insert_watchpoint)
2115         (remote_watchpoint_addr_within_range)
2116         (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
2117         (remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
2118         (remote_supports_stopped_by_sw_breakpoint)
2119         (remote_stopped_by_hw_breakpoint)
2120         (remote_supports_stopped_by_hw_breakpoint)
2121         (remote_stopped_by_watchpoint, remote_stopped_data_address)
2122         (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
2123         (remote_verify_memory): Refactor as methods of remote_target.
2124         (remote_write_qxfer, remote_read_qxfer): Remove target_ops
2125         parameter.
2126         (remote_xfer_partial, remote_get_memory_xfer_limit)
2127         (remote_search_memory, remote_rcmd, remote_memory_map)
2128         (remote_pid_to_str, remote_get_thread_local_address)
2129         (remote_get_tib_address, remote_read_description): Refactor as
2130         methods of remote_target.
2131         (remote_target::fileio_open, remote_target::fileio_pwrite)
2132         (remote_target::fileio_pread, remote_target::fileio_close): New.
2133         (remote_hostio_readlink, remote_hostio_fstat)
2134         (remote_filesystem_is_local, remote_can_execute_reverse)
2135         (remote_supports_non_stop, remote_supports_disable_randomization)
2136         (remote_supports_multi_process, remote_supports_cond_breakpoints)
2137         (remote_supports_enable_disable_tracepoint)
2138         (remote_supports_string_tracing)
2139         (remote_can_run_breakpoint_commands, remote_trace_init)
2140         (remote_download_tracepoint, remote_can_download_tracepoint)
2141         (remote_download_trace_state_variable, remote_enable_tracepoint)
2142         (remote_disable_tracepoint, remote_trace_set_readonly_regions)
2143         (remote_trace_start, remote_get_trace_status)
2144         (remote_get_tracepoint_status, remote_trace_stop)
2145         (remote_trace_find, remote_get_trace_state_variable_value)
2146         (remote_save_trace_data, remote_get_raw_trace_data)
2147         (remote_set_disconnected_tracing, remote_core_of_thread)
2148         (remote_set_circular_trace_buffer, remote_traceframe_info)
2149         (remote_get_min_fast_tracepoint_insn_len)
2150         (remote_set_trace_buffer_size, remote_set_trace_notes)
2151         (remote_use_agent, remote_can_use_agent, remote_enable_btrace)
2152         (remote_disable_btrace, remote_teardown_btrace)
2153         (remote_read_btrace, remote_btrace_conf)
2154         (remote_augmented_libraries_svr4_read, remote_load)
2155         (remote_pid_to_exec_file, remote_can_do_single_step)
2156         (remote_execution_direction, remote_thread_handle_to_thread_info):
2157         Refactor as methods of remote_target.
2158         (init_remote_ops, init_extended_remote_ops): Delete.
2159         (remote_can_async_p, remote_is_async_p, remote_async)
2160         (remote_thread_events, remote_upload_tracepoints)
2161         (remote_upload_trace_state_variables): Refactor as methods of
2162         remote_target.
2163         (_initialize_remote): Remove references to init_remote_ops and
2164         init_extended_remote_ops.
2165
2166         * remote-sim.c (gdbsim_target): New class.
2167         (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
2168         (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
2169         (gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
2170         (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
2171         (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
2172         (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
2173         Refactor as methods of gdbsim_target.
2174         (gdbsim_ops): Now a gdbsim_target.
2175         (init_gdbsim_ops): Delete.
2176         (gdbsim_cntrl_c): Adjust.
2177         (_initialize_remote_sim): Remove reference to init_gdbsim_ops.
2178
2179         * amd64-linux-nat.c (amd64_linux_nat_target): New class.
2180         (the_amd64_linux_nat_target): New.
2181         (amd64_linux_fetch_inferior_registers)
2182         (amd64_linux_store_inferior_registers): Refactor as methods of
2183         amd64_linux_nat_target.
2184         (_initialize_amd64_linux_nat): Adjust.  Set linux_target.
2185         * i386-linux-nat.c: Don't include "linux-nat.h".
2186         (i386_linux_nat_target): New class.
2187         (the_i386_linux_nat_target): New.
2188         (i386_linux_fetch_inferior_registers)
2189         (i386_linux_store_inferior_registers, i386_linux_resume): Refactor
2190         as methods of i386_linux_nat_target.
2191         (_initialize_i386_linux_nat): Adjust.  Set linux_target.
2192         * inf-child.c (inf_child_ops): Delete.
2193         (inf_child_fetch_inferior_registers)
2194         (inf_child_store_inferior_registers): Delete.
2195         (inf_child_post_attach, inf_child_prepare_to_store): Refactor as
2196         methods of inf_child_target.
2197         (inf_child_target::supports_terminal_ours)
2198         (inf_child_target::terminal_init)
2199         (inf_child_target::terminal_inferior)
2200         (inf_child_target::terminal_ours_for_output)
2201         (inf_child_target::terminal_ours, inf_child_target::interrupt)
2202         (inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
2203         New.
2204         (inf_child_open, inf_child_disconnect, inf_child_close)
2205         (inf_child_mourn_inferior, inf_child_maybe_unpush_target)
2206         (inf_child_post_startup_inferior, inf_child_can_run)
2207         (inf_child_pid_to_exec_file): Refactor as methods of
2208         inf_child_target.
2209         (inf_child_follow_fork): Delete.
2210         (inf_child_target::can_create_inferior)
2211         (inf_child_target::can_attach): New.
2212         (inf_child_target::has_all_memory, inf_child_target::has_memory)
2213         (inf_child_target::has_stack, inf_child_target::has_registers)
2214         (inf_child_target::has_execution): New.
2215         (inf_child_fileio_open, inf_child_fileio_pwrite)
2216         (inf_child_fileio_pread, inf_child_fileio_fstat)
2217         (inf_child_fileio_close, inf_child_fileio_unlink)
2218         (inf_child_fileio_readlink, inf_child_use_agent)
2219         (inf_child_can_use_agent): Refactor as methods of
2220         inf_child_target.
2221         (return_zero, inf_child_target): Delete.
2222         (inf_child_target::inf_child_target): New.
2223         * inf-child.h: Include "target.h".
2224         (inf_child_target): Delete function prototype.
2225         (inf_child_target): New class.
2226         (inf_child_open_target, inf_child_mourn_inferior)
2227         (inf_child_maybe_unpush_target): Delete.
2228         * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
2229         (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
2230         (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
2231         (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
2232         (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
2233         (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
2234         (inf_ptrace_wait, inf_ptrace_xfer_partial)
2235         (inf_ptrace_thread_alive, inf_ptrace_files_info)
2236         (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
2237         methods of inf_ptrace_target.
2238         (inf_ptrace_target): Delete function.
2239         * inf-ptrace.h: Include "inf-child.h".
2240         (inf_ptrace_target): Delete function declaration.
2241         (inf_ptrace_target): New class.
2242         (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
2243         * linux-nat.c (linux_target): New.
2244         (linux_ops, linux_ops_saved, super_xfer_partial): Delete.
2245         (linux_nat_target::~linux_nat_target): New.
2246         (linux_child_post_attach, linux_child_post_startup_inferior)
2247         (linux_child_follow_fork, linux_child_insert_fork_catchpoint)
2248         (linux_child_remove_fork_catchpoint)
2249         (linux_child_insert_vfork_catchpoint)
2250         (linux_child_remove_vfork_catchpoint)
2251         (linux_child_insert_exec_catchpoint)
2252         (linux_child_remove_exec_catchpoint)
2253         (linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
2254         (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
2255         (linux_nat_resume, linux_nat_stopped_by_watchpoint)
2256         (linux_nat_stopped_data_address)
2257         (linux_nat_stopped_by_sw_breakpoint)
2258         (linux_nat_supports_stopped_by_sw_breakpoint)
2259         (linux_nat_stopped_by_hw_breakpoint)
2260         (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
2261         (linux_nat_kill, linux_nat_mourn_inferior)
2262         (linux_nat_xfer_partial, linux_nat_thread_alive)
2263         (linux_nat_update_thread_list, linux_nat_pid_to_str)
2264         (linux_nat_thread_name, linux_child_pid_to_exec_file)
2265         (linux_child_static_tracepoint_markers_by_strid)
2266         (linux_nat_is_async_p, linux_nat_can_async_p)
2267         (linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
2268         (linux_nat_supports_multi_process)
2269         (linux_nat_supports_disable_randomization, linux_nat_async)
2270         (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
2271         (linux_nat_core_of_thread, linux_nat_filesystem_is_local)
2272         (linux_nat_fileio_open, linux_nat_fileio_readlink)
2273         (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
2274         methods of linux_nat_target.
2275         (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
2276         (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
2277         parameter.
2278         (check_stopped_by_watchpoint): Adjust.
2279         (linux_xfer_partial): Delete.
2280         (linux_target_install_ops, linux_target, linux_nat_add_target):
2281         Delete.
2282         (linux_nat_target::linux_nat_target): New.
2283         * linux-nat.h: Include "inf-ptrace.h".
2284         (linux_nat_target): New.
2285         (linux_target, linux_target_install_ops, linux_nat_add_target):
2286         Delete function declarations.
2287         (linux_target): Declare global.
2288         * linux-thread-db.c (thread_db_target): New.
2289         (thread_db_target::thread_db_target): New.
2290         (thread_db_ops): Delete.
2291         (the_thread_db_target): New.
2292         (thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
2293         (thread_db_update_thread_list, thread_db_pid_to_str)
2294         (thread_db_extra_thread_info)
2295         (thread_db_thread_handle_to_thread_info)
2296         (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
2297         (thread_db_resume): Refactor as methods of thread_db_target.
2298         (init_thread_db_ops): Delete.
2299         (_initialize_thread_db): Remove reference to init_thread_db_ops.
2300         * x86-linux-nat.c: Don't include "linux-nat.h".
2301         (super_post_startup_inferior): Delete.
2302         (x86_linux_nat_target::~x86_linux_nat_target): New.
2303         (x86_linux_child_post_startup_inferior)
2304         (x86_linux_read_description, x86_linux_enable_btrace)
2305         (x86_linux_disable_btrace, x86_linux_teardown_btrace)
2306         (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
2307         methods of x86_linux_nat_target.
2308         (x86_linux_create_target): Delete.  Bits folded ...
2309         (x86_linux_add_target): ... here.  Now takes a linux_nat_target
2310         pointer.
2311         * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
2312         (x86_linux_nat_target): New class.
2313         (x86_linux_create_target): Delete.
2314         (x86_linux_add_target): Now takes a linux_nat_target pointer.
2315         * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
2316         (x86_region_ok_for_watchpoint, x86_stopped_data_address)
2317         (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
2318         (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
2319         (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
2320         make extern.
2321         (x86_use_watchpoints): Delete.
2322         * x86-nat.h: Include "breakpoint.h" and "target.h".
2323         (x86_use_watchpoints): Delete.
2324         (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
2325         (x86_stopped_by_watchpoint, x86_stopped_data_address)
2326         (x86_insert_watchpoint, x86_remove_watchpoint)
2327         (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
2328         (x86_stopped_by_hw_breakpoint): New declarations.
2329         (x86_nat_target): New template class.
2330
2331         * ppc-linux-nat.c (ppc_linux_nat_target): New class.
2332         (the_ppc_linux_nat_target): New.
2333         (ppc_linux_fetch_inferior_registers)
2334         (ppc_linux_can_use_hw_breakpoint)
2335         (ppc_linux_region_ok_for_hw_watchpoint)
2336         (ppc_linux_ranged_break_num_registers)
2337         (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
2338         (ppc_linux_insert_mask_watchpoint)
2339         (ppc_linux_remove_mask_watchpoint)
2340         (ppc_linux_can_accel_watchpoint_condition)
2341         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
2342         (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
2343         (ppc_linux_watchpoint_addr_within_range)
2344         (ppc_linux_masked_watch_num_registers)
2345         (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
2346         (ppc_linux_read_description): Refactor as methods of
2347         ppc_linux_nat_target.
2348         (_initialize_ppc_linux_nat): Adjust.  Set linux_target.
2349
2350         * procfs.c (procfs_xfer_partial): Delete forward declaration.
2351         (procfs_target): New class.
2352         (the_procfs_target): New.
2353         (procfs_target): Delete function.
2354         (procfs_auxv_parse, procfs_attach, procfs_detach)
2355         (procfs_fetch_registers, procfs_store_registers, procfs_wait)
2356         (procfs_xfer_partial, procfs_resume, procfs_pass_signals)
2357         (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
2358         (procfs_create_inferior, procfs_update_thread_list)
2359         (procfs_thread_alive, procfs_pid_to_str)
2360         (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
2361         (procfs_stopped_data_address, procfs_insert_watchpoint)
2362         (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
2363         (proc_find_memory_regions, procfs_info_proc)
2364         (procfs_make_note_section): Refactor as methods of procfs_target.
2365         (_initialize_procfs): Adjust.
2366         * sol-thread.c (sol_thread_target): New class.
2367         (sol_thread_ops): Now a sol_thread_target.
2368         (sol_thread_detach, sol_thread_resume, sol_thread_wait)
2369         (sol_thread_fetch_registers, sol_thread_store_registers)
2370         (sol_thread_xfer_partial, sol_thread_mourn_inferior)
2371         (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
2372         (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
2373         (init_sol_thread_ops): Delete.
2374         (_initialize_sol_thread): Adjust.  Remove references to
2375         init_sol_thread_ops and complete_target_initialization.
2376
2377         * windows-nat.c (windows_nat_target): New class.
2378         (windows_fetch_inferior_registers)
2379         (windows_store_inferior_registers, windows_resume, windows_wait)
2380         (windows_attach, windows_detach, windows_pid_to_exec_file)
2381         (windows_files_info, windows_create_inferior)
2382         (windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
2383         (windows_close, windows_pid_to_str, windows_xfer_partial)
2384         (windows_get_tib_address, windows_get_ada_task_ptid)
2385         (windows_thread_name, windows_thread_alive): Refactor as
2386         windows_nat_target methods.
2387         (do_initial_windows_stuff): Adjust.
2388         (windows_target): Delete function.
2389         (_initialize_windows_nat): Adjust.
2390
2391         * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
2392         (darwin_mourn_inferior, darwin_kill_inferior)
2393         (darwin_create_inferior, darwin_attach, darwin_detach)
2394         (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
2395         (darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
2396         (darwin_supports_multi_process): Refactor as darwin_nat_target
2397         methods.
2398         (darwin_resume_to, darwin_files_info): Delete.
2399         (_initialize_darwin_inferior): Rename to ...
2400         (_initialize_darwin_nat): ... this.  Adjust to C++ification.
2401         * darwin-nat.h: Include "inf-child.h".
2402         (darwin_nat_target): New class.
2403         (darwin_complete_target): Delete.
2404         * i386-darwin-nat.c (i386_darwin_nat_target): New class.
2405         (darwin_target): New.
2406         (i386_darwin_fetch_inferior_registers)
2407         (i386_darwin_store_inferior_registers): Refactor as methods of
2408         darwin_nat_target.
2409         (darwin_complete_target): Delete, with ...
2410         (_initialize_i386_darwin_nat): ... bits factored out here.
2411
2412         * alpha-linux-nat.c (alpha_linux_nat_target): New class.
2413         (the_alpha_linux_nat_target): New.
2414         (alpha_linux_register_u_offset): Refactor as
2415         alpha_linux_nat_target method.
2416         (_initialize_alpha_linux_nat): Adjust.
2417         * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
2418         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
2419         (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
2420         methods of linux_nat_trad_target.
2421         (linux_trad_target): Delete.
2422         * linux-nat-trad.h (linux_trad_target): Delete function.
2423         (linux_nat_trad_target): New class.
2424         * mips-linux-nat.c (mips_linux_nat_target): New class.
2425         (super_fetch_registers, super_store_registers, super_close):
2426         Delete.
2427         (the_mips_linux_nat_target): New.
2428         (mips64_linux_regsets_fetch_registers)
2429         (mips64_linux_regsets_store_registers)
2430         (mips64_linux_fetch_registers, mips64_linux_store_registers)
2431         (mips_linux_register_u_offset, mips_linux_read_description)
2432         (mips_linux_can_use_hw_breakpoint)
2433         (mips_linux_stopped_by_watchpoint)
2434         (mips_linux_stopped_data_address)
2435         (mips_linux_region_ok_for_hw_watchpoint)
2436         (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
2437         (mips_linux_close): Refactor as methods of mips_linux_nat.
2438         (_initialize_mips_linux_nat): Adjust to C++ification.
2439
2440         * aix-thread.c (aix_thread_target): New class.
2441         (aix_thread_ops): Now an aix_thread_target.
2442         (aix_thread_detach, aix_thread_resume, aix_thread_wait)
2443         (aix_thread_fetch_registers, aix_thread_store_registers)
2444         (aix_thread_xfer_partial, aix_thread_mourn_inferior)
2445         (aix_thread_thread_alive, aix_thread_pid_to_str)
2446         (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
2447         Refactor as methods of aix_thread_target.
2448         (init_aix_thread_ops): Delete.
2449         (_initialize_aix_thread): Remove references to init_aix_thread_ops
2450         and complete_target_initialization.
2451         * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
2452         (rs6000_nat_target): New class.
2453         (the_rs6000_nat_target): New.
2454         (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
2455         (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
2456         (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
2457         (super_create_inferior): Delete.
2458         (_initialize_rs6000_nat): Adjust to C++ification.
2459
2460         * arm-linux-nat.c (arm_linux_nat_target): New class.
2461         (the_arm_linux_nat_target): New.
2462         (arm_linux_fetch_inferior_registers)
2463         (arm_linux_store_inferior_registers, arm_linux_read_description)
2464         (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
2465         (arm_linux_remove_hw_breakpoint)
2466         (arm_linux_region_ok_for_hw_watchpoint)
2467         (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
2468         (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
2469         (arm_linux_watchpoint_addr_within_range): Refactor as methods of
2470         arm_linux_nat_target.
2471         (_initialize_arm_linux_nat): Adjust to C++ification.
2472
2473         * aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
2474         (the_aarch64_linux_nat_target): New.
2475         (aarch64_linux_fetch_inferior_registers)
2476         (aarch64_linux_store_inferior_registers)
2477         (aarch64_linux_child_post_startup_inferior)
2478         (aarch64_linux_read_description)
2479         (aarch64_linux_can_use_hw_breakpoint)
2480         (aarch64_linux_insert_hw_breakpoint)
2481         (aarch64_linux_remove_hw_breakpoint)
2482         (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
2483         (aarch64_linux_region_ok_for_hw_watchpoint)
2484         (aarch64_linux_stopped_data_address)
2485         (aarch64_linux_stopped_by_watchpoint)
2486         (aarch64_linux_watchpoint_addr_within_range)
2487         (aarch64_linux_can_do_single_step): Refactor as methods of
2488         aarch64_linux_nat_target.
2489         (super_post_startup_inferior): Delete.
2490         (_initialize_aarch64_linux_nat): Adjust to C++ification.
2491
2492         * hppa-linux-nat.c (hppa_linux_nat_target): New class.
2493         (the_hppa_linux_nat_target): New.
2494         (hppa_linux_fetch_inferior_registers)
2495         (hppa_linux_store_inferior_registers): Refactor as methods of
2496         hppa_linux_nat_target.
2497         (_initialize_hppa_linux_nat): Adjust to C++ification.
2498
2499         * ia64-linux-nat.c (ia64_linux_nat_target): New class.
2500         (the_ia64_linux_nat_target): New.
2501         (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
2502         (ia64_linux_stopped_data_address)
2503         (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
2504         (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
2505         ia64_linux_nat_target methods.
2506         (super_xfer_partial): Delete.
2507         (_initialize_ia64_linux_nat): Adjust to C++ification.
2508
2509         * m32r-linux-nat.c (m32r_linux_nat_target): New class.
2510         (the_m32r_linux_nat_target): New.
2511         (m32r_linux_fetch_inferior_registers)
2512         (m32r_linux_store_inferior_registers): Refactor as
2513         m32r_linux_nat_target methods.
2514         (_initialize_m32r_linux_nat): Adjust to C++ification.
2515
2516         * m68k-linux-nat.c (m68k_linux_nat_target): New class.
2517         (the_m68k_linux_nat_target): New.
2518         (m68k_linux_fetch_inferior_registers)
2519         (m68k_linux_store_inferior_registers): Refactor as
2520         m68k_linux_nat_target methods.
2521         (_initialize_m68k_linux_nat): Adjust to C++ification.
2522
2523         * s390-linux-nat.c (s390_linux_nat_target): New class.
2524         (the_s390_linux_nat_target): New.
2525         (s390_linux_fetch_inferior_registers)
2526         (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
2527         (s390_insert_watchpoint, s390_remove_watchpoint)
2528         (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
2529         (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
2530         (s390_auxv_parse, s390_read_description): Refactor as methods of
2531         s390_linux_nat_target.
2532         (_initialize_s390_nat): Adjust to C++ification.
2533
2534         * sparc-linux-nat.c (sparc_linux_nat_target): New class.
2535         (the_sparc_linux_nat_target): New.
2536         (_initialize_sparc_linux_nat): Adjust to C++ification.
2537         * sparc-nat.c (sparc_fetch_inferior_registers)
2538         (sparc_store_inferior_registers): Remove target_ops parameter.
2539         * sparc-nat.h (sparc_fetch_inferior_registers)
2540         (sparc_store_inferior_registers): Remove target_ops parameter.
2541         * sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
2542         (the_sparc64_linux_nat_target): New.
2543         (_initialize_sparc64_linux_nat): Adjust to C++ification.
2544
2545         * spu-linux-nat.c (spu_linux_nat_target): New class.
2546         (the_spu_linux_nat_target): New.
2547         (spu_child_post_startup_inferior, spu_child_post_attach)
2548         (spu_child_wait, spu_fetch_inferior_registers)
2549         (spu_store_inferior_registers, spu_xfer_partial)
2550         (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
2551         methods.
2552         (_initialize_spu_nat): Adjust to C++ification.
2553
2554         * tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
2555         (the_tilegx_linux_nat_target): New.
2556         (fetch_inferior_registers, store_inferior_registers):
2557         Refactor as methods.
2558         (_initialize_tile_linux_nat): Adjust to C++ification.
2559
2560         * xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
2561         (the_xtensa_linux_nat_target): New.
2562         (xtensa_linux_fetch_inferior_registers)
2563         (xtensa_linux_store_inferior_registers): Refactor as
2564         xtensa_linux_nat_target methods.
2565         (_initialize_xtensa_linux_nat): Adjust to C++ification.
2566
2567         * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
2568         (fbsd_pid_to_exec_file, fbsd_find_memory_regions)
2569         (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
2570         (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
2571         (fbsd_update_thread_list, fbsd_resume, fbsd_wait)
2572         (fbsd_stopped_by_sw_breakpoint)
2573         (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
2574         (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
2575         (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
2576         (fbsd_post_startup_inferior, fbsd_post_attach)
2577         (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
2578         (fbsd_set_syscall_catchpoint)
2579         (super_xfer_partial, super_resume, super_wait)
2580         (fbsd_supports_stopped_by_hw_breakpoint): Delete.
2581         (fbsd_handle_debug_trap): Remove target_ops parameter.
2582         (fbsd_nat_add_target): Delete.
2583         * fbsd-nat.h: Include "inf-ptrace.h".
2584         (fbsd_nat_add_target): Delete.
2585         (USE_SIGTRAP_SIGINFO): Define.
2586         (fbsd_nat_target): New class.
2587
2588         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
2589         (amd64bsd_store_inferior_registers): Remove target_ops parameter.
2590         (amd64bsd_target): Delete.
2591         * amd64-bsd-nat.h: New file.
2592         * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
2593         "x86-bsd-nat.h".
2594         (amd64_fbsd_nat_target): New class.
2595         (the_amd64_fbsd_nat_target): New.
2596         (amd64fbsd_read_description): Refactor as method of
2597         amd64_fbsd_nat_target.
2598         (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2599         (_initialize_amd64fbsd_nat): Adjust to C++ification.
2600         * amd64-nat.h (amd64bsd_target): Delete function declaration.
2601         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
2602         (i386bsd_store_inferior_registers): Remove target_ops parameter.
2603         (i386bsd_target): Delete.
2604         * i386-bsd-nat.h (i386bsd_target): Delete function declaration.
2605         (i386bsd_fetch_inferior_registers)
2606         (i386bsd_store_inferior_registers): Declare.
2607         (i386_bsd_nat_target): New class.
2608         * i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
2609         (the_i386_fbsd_nat_target): New.
2610         (i386fbsd_resume, i386fbsd_read_description): Refactor as
2611         i386_fbsd_nat_target methods.
2612         (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2613         (_initialize_i386fbsd_nat): Adjust to C++ification.
2614         * x86-bsd-nat.c (super_mourn_inferior): Delete.
2615         (x86bsd_mourn_inferior, x86bsd_target): Delete.
2616         (_initialize_x86_bsd_nat): Adjust to C++ification.
2617         * x86-bsd-nat.h: Include "x86-nat.h".
2618         (x86bsd_target): Delete declaration.
2619         (x86bsd_nat_target): New class.
2620
2621         * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
2622         (the_aarch64_fbsd_nat_target): New.
2623         (aarch64_fbsd_fetch_inferior_registers)
2624         (aarch64_fbsd_store_inferior_registers): Refactor as methods of
2625         aarch64_fbsd_nat_target.
2626         (_initialize_aarch64_fbsd_nat): Adjust to C++ification.
2627         * alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
2628         (the_alpha_bsd_nat_target): New.
2629         (alphabsd_fetch_inferior_registers)
2630         (alphabsd_store_inferior_registers): Refactor as
2631         alpha_bsd_nat_target methods.
2632         (_initialize_alphabsd_nat): Refactor as methods of
2633         alpha_bsd_nat_target.
2634         * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
2635         (the_amd64_nbsd_nat_target): New.
2636         (_initialize_amd64nbsd_nat): Adjust to C++ification.
2637         * amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
2638         (the_amd64_obsd_nat_target): New.
2639         (_initialize_amd64obsd_nat): Adjust to C++ification.
2640         * arm-fbsd-nat.c (arm_fbsd_nat_target): New.
2641         (the_arm_fbsd_nat_target): New.
2642         (arm_fbsd_fetch_inferior_registers)
2643         (arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
2644         (_initialize_arm_fbsd_nat): Refactor as methods of
2645         arm_fbsd_nat_target.
2646         (_initialize_arm_fbsd_nat): Adjust to C++ification.
2647         * arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
2648         (the_arm_netbsd_nat_target): New.
2649         (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
2650         arm_netbsd_nat_target.
2651         (_initialize_arm_netbsd_nat): Adjust to C++ification.
2652         * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
2653         (the_hppa_nbsd_nat_target): New.
2654         (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
2655         hppa_nbsd_nat_target methods.
2656         (_initialize_hppanbsd_nat): Adjust to C++ification.
2657         * hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
2658         (the_hppa_obsd_nat_target): New.
2659         (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
2660         methods of hppa_obsd_nat_target.
2661         (_initialize_hppaobsd_nat): Adjust to C++ification.  Use
2662         add_target.
2663         * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
2664         (_initialize_i386nbsd_nat): Adjust to C++ification.  Use
2665         add_target.
2666         * i386-obsd-nat.c (the_i386_obsd_nat_target): New.
2667         (_initialize_i386obsd_nat): Use add_target.
2668         * m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
2669         (the_m68k_bsd_nat_target): New.
2670         (m68kbsd_fetch_inferior_registers)
2671         (m68kbsd_store_inferior_registers): Refactor as methods of
2672         m68k_bsd_nat_target.
2673         (_initialize_m68kbsd_nat): Adjust to C++ification.
2674         * mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
2675         (the_mips_fbsd_nat_target): New.
2676         (mips_fbsd_fetch_inferior_registers)
2677         (mips_fbsd_store_inferior_registers): Refactor as methods of
2678         mips_fbsd_nat_target.
2679         (_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
2680         add_target.
2681         * mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
2682         (the_mips_nbsd_nat_target): New.
2683         (mipsnbsd_fetch_inferior_registers)
2684         (mipsnbsd_store_inferior_registers): Refactor as methods of
2685         mips_nbsd_nat_target.
2686         (_initialize_mipsnbsd_nat): Adjust to C++ification.
2687         * mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
2688         (the_mips64_obsd_nat_target): New.
2689         (mips64obsd_fetch_inferior_registers)
2690         (mips64obsd_store_inferior_registers): Refactor as methods of
2691         mips64_obsd_nat_target.
2692         (_initialize_mips64obsd_nat): Adjust to C++ification.  Use
2693         add_target.
2694         * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
2695         nbsd_nat_target.
2696         * nbsd-nat.h: Include "inf-ptrace.h".
2697         (nbsd_nat_target): New class.
2698         * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
2699         (obsd_wait): Refactor as methods of obsd_nat_target.
2700         (obsd_add_target): Delete.
2701         * obsd-nat.h: Include "inf-ptrace.h".
2702         (obsd_nat_target): New class.
2703         * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
2704         (the_ppc_fbsd_nat_target): New.
2705         (ppcfbsd_fetch_inferior_registers)
2706         (ppcfbsd_store_inferior_registers): Refactor as methods of
2707         ppc_fbsd_nat_target.
2708         (_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
2709         add_target.
2710         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
2711         (the_ppc_nbsd_nat_target): New.
2712         (ppcnbsd_fetch_inferior_registers)
2713         (ppcnbsd_store_inferior_registers): Refactor as methods of
2714         ppc_nbsd_nat_target.
2715         (_initialize_ppcnbsd_nat): Adjust to C++ification.
2716         * ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
2717         (the_ppc_obsd_nat_target): New.
2718         (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
2719         methods of ppc_obsd_nat_target.
2720         (_initialize_ppcobsd_nat): Adjust to C++ification.  Use
2721         add_target.
2722         * sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
2723         (the_sh_nbsd_nat_target): New.
2724         (shnbsd_fetch_inferior_registers)
2725         (shnbsd_store_inferior_registers): Refactor as methods of
2726         sh_nbsd_nat_target.
2727         (_initialize_shnbsd_nat): Adjust to C++ification.
2728         * sparc-nat.c (sparc_xfer_wcookie): Make extern.
2729         (inf_ptrace_xfer_partial): Delete.
2730         (sparc_xfer_partial, sparc_target): Delete.
2731         * sparc-nat.h (sparc_fetch_inferior_registers)
2732         (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
2733         (sparc_target): Delete function declaration.
2734         (sparc_target): New template class.
2735         * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
2736         (_initialize_sparcnbsd_nat): Adjust to C++ification.
2737         * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
2738         (_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
2739         add_target.
2740         * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
2741         (_initialize_sparc64nbsd_nat): Adjust to C++ification.
2742         * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
2743         (_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
2744         add_target.
2745         * vax-bsd-nat.c (vax_bsd_nat_target): New class.
2746         (the_vax_bsd_nat_target): New.
2747         (vaxbsd_fetch_inferior_registers)
2748         (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
2749         methods.
2750         (_initialize_vaxbsd_nat): Adjust to C++ification.
2751
2752         * bsd-kvm.c (bsd_kvm_target): New class.
2753         (bsd_kvm_ops): Now a bsd_kvm_target.
2754         (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
2755         (bsd_kvm_files_info, bsd_kvm_fetch_registers)
2756         (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
2757         bsd_kvm_target.
2758         (bsd_kvm_return_one): Delete.
2759         (bsd_kvm_add_target): Adjust to C++ification.
2760
2761         * nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
2762         (nto_procfs_target_procfs): New classes.
2763         (procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
2764         (procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
2765         (procfs_post_attach, procfs_wait, procfs_fetch_registers)
2766         (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
2767         (procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
2768         (procfs_remove_hw_breakpoint, procfs_resume)
2769         (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
2770         (procfs_kill_inferior, procfs_store_registers)
2771         (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
2772         as methods of nto_procfs_target.
2773         (nto_procfs_ops): Now an nto_procfs_target_procfs.
2774         (nto_native_ops): Delete.
2775         (procfs_open, procfs_native_open): Delete.
2776         (nto_native_ops): Now an nto_procfs_target_native.
2777         (init_procfs_targets): Adjust to C++ification.
2778         (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
2779         (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
2780         Refactor as methods of nto_procfs_target.
2781
2782         * go32-nat.c (go32_nat_target): New class.
2783         (the_go32_nat_target): New.
2784         (go32_attach, go32_resume, go32_wait, go32_fetch_registers)
2785         (go32_store_registers, go32_xfer_partial, go32_files_info)
2786         (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
2787         (go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
2788         (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
2789         (go32_pid_to_str): Refactor as methods of go32_nat_target.
2790         (go32_target): Delete.
2791         (_initialize_go32_nat): Adjust to C++ification.
2792
2793         * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
2794         (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
2795         (gnu_stop, gnu_thread_alive, gnu_xfer_partial)
2796         (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
2797         gnu_nat_target.
2798         (gnu_target): Delete.
2799         * gnu-nat.h (gnu_target): Delete.
2800         (gnu_nat_target): New class.
2801         * i386-gnu-nat.c (gnu_base_target): New.
2802         (i386_gnu_nat_target): New class.
2803         (the_i386_gnu_nat_target): New.
2804         (_initialize_i386gnu_nat): Adjust to C++ification.
2805
2806 2018-05-02  Pedro Alves  <palves@redhat.com>
2807
2808         * bfd-target.c (target_bfd_xclose): Rename to ...
2809         (target_bfd_close): ... this.
2810         (target_bfd_reopen): Adjust.
2811         * target.c (target_close): Remove references to to_xclose.
2812         * target.h (target_ops::to_xclose): Delete.
2813         (target_ops::to_close): Update comments.
2814
2815 2018-05-02  Pedro Alves  <palves@redhat.com>
2816
2817         * alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
2818         "linux-nat.h".
2819         * configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
2820         * inf-ptrace.c (inf_ptrace_register_u_offset)
2821         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
2822         (inf_ptrace_store_register, inf_ptrace_store_registers)
2823         (inf_ptrace_trad_target): Move to ...
2824         * linux-nat-trad.c: ... this new file.
2825         * linux-nat-trad.h: New file.
2826         * linux-nat.c (linux_target_install_ops): Make extern.
2827         (linux_trad_target): Delete.
2828         * linux-nat.h (linux_trad_target): Delete declaration.
2829         (linux_target_install_ops): Declare.
2830         * mips-linux-nat.c: Include "linux-nat-trad.h" instead of
2831         "linux-nat.h".
2832
2833 2018-05-02  Pedro Alves  <palves@redhat.com>
2834
2835         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
2836         procfs_target/add_target here.
2837         * procfs.c (procfs_target): Make static.
2838         (_initialize_procfs): Call add_target here.
2839         * procfs.h (struct target_ops): Remove forward declaration.
2840         (procfs_target): Remove declaration.
2841         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
2842
2843 2018-05-02  Pedro Alves  <palves@redhat.com>
2844
2845         * procfs.c (procfs_stopped_by_watchpoint)
2846         (procfs_insert_watchpoint, procfs_remove_watchpoint)
2847         (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
2848         Forward declare.
2849         (procfs_use_watchpoints): Delete, move contents...
2850         (procfs_target): ... here.
2851         * procfs.h (procfs_use_watchpoints): Delete declaration.
2852         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
2853         procfs_use_watchpoints.
2854         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
2855         procfs_use_watchpoints.
2856
2857 2018-05-02  Tom Tromey  <tom@tromey.com>
2858
2859         PR python/20084:
2860         * python/python.c (gdbpy_parameter_value): Handle var_zuinteger
2861         and var_zuinteger_unlimited.
2862         * python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
2863         and PARAM_ZUINTEGER_UNLIMITED.
2864         (set_parameter_value): Handle var_zuinteger and
2865         var_zuinteger_unlimited.
2866         (add_setshow_generic): Likewise.
2867         (parmpy_init): Likewise.
2868
2869 2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>
2870
2871         PR rust/23124
2872         * gdb/rust-exp.y (convert_params_to_types): Ensure that the params
2873         pointer is not null before dereferencing it.
2874
2875 2018-04-30  Tom Tromey  <tom@tromey.com>
2876
2877         * darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
2878         is_mi_like_p.
2879
2880 2018-04-30  Tom Tromey  <tom@tromey.com>
2881
2882         * breakpoint.c (mention): Remove use of is_mi_like_p.
2883         (print_mention_ranged_breakpoint): Likewise.
2884         * break-catch-throw.c (print_it_exception_catchpoint): Remove use
2885         of is_mi_like_p.
2886
2887 2018-04-30  Tom Tromey  <tom@tromey.com>
2888
2889         * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
2890
2891 2018-04-30  Tom Tromey  <tom@tromey.com>
2892
2893         * spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
2894         (info_spu_event_command): Remove some uses of is_mi_like_p.
2895
2896 2018-04-30  Tom Tromey  <tom@tromey.com>
2897
2898         * python/py-framefilter.c (py_print_single_arg)
2899         (enumerate_locals, py_print_args, py_print_frame): Remove some
2900         uses of is_mi_like_p.
2901
2902 2018-04-30  Tom Tromey  <tom@tromey.com>
2903
2904         * ui-out.c: Update.
2905         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
2906         * ui-out.h (ui_out::is_mi_like_p): Now const.
2907         (ui_out::do_is_mi_like_p): Now const.
2908         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
2909
2910 2018-04-30  Tom Tromey  <tom@tromey.com>
2911
2912         * varobj.c (varobj_set_visualizer): Use new_reference.
2913         * python/python.c (gdbpy_decode_line): Use new_reference.
2914         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
2915         new_reference.
2916
2917 2018-04-30  Tom Tromey  <tom@tromey.com>
2918
2919         * varobj.c (install_new_value): Use new_reference.
2920         * value.h (value_incref): Return void.  Swap intro comment with
2921         value_decref.
2922         * value.c (set_value_parent): Use new_reference.
2923         (value_incref): Return void.  Update intro comment.
2924         (release_value): Use new_reference.
2925         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
2926
2927 2018-04-30  Tom Tromey  <tom@tromey.com>
2928
2929         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
2930         * gdb_bfd.h (new_bfd_ref): Remove.
2931         (gdb_bfd_open): Update comment.
2932         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
2933         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
2934         (gdb_bfd_fdopenr): Use new_reference.
2935         * exec.c (exec_file_attach): Use new_reference.
2936
2937 2018-04-30  Tom Tromey  <tom@tromey.com>
2938
2939         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
2940         method.
2941
2942 2018-04-30  Tom Tromey  <tom@tromey.com>
2943
2944         * jit.c (jit_read_code_entry): Use type_align.
2945         * i386-tdep.c (i386_gdbarch_init): Don't call
2946         set_gdbarch_long_long_align_bit.
2947         * gdbarch.sh: Remove long_long_align_bit.
2948         * gdbarch.c, gdbarch.h: Rebuild.
2949         * arc-tdep.c (arc_type_align): New function.
2950         (arc_gdbarch_init): Use arc_type_align.  Don't call
2951         set_gdbarch_long_long_align_bit.
2952
2953 2018-04-30  Tom Tromey  <tom@tromey.com>
2954
2955         * rust-lang.c (rust_type_alignment): Remove.
2956         (rust_composite_type): Use type_align.
2957
2958 2018-04-30  Tom Tromey  <tom@tromey.com>
2959
2960         * NEWS: Mention Type.align.
2961         * python/py-type.c (typy_get_alignof): New function.
2962         (type_object_getset): Add "alignof".
2963
2964 2018-04-30  Tom Tromey  <tom@tromey.com>
2965
2966         PR exp/17095:
2967         * NEWS: Update.
2968         * std-operator.def (UNOP_ALIGNOF): New operator.
2969         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
2970         New.
2971         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
2972         * c-lang.c (c_op_print_tab): Add alignof.
2973         * c-exp.y (ALIGNOF): New token.
2974         (exp): Add "ALIGNOF" production.
2975         (ident_tokens): Add _Alignof and alignof.
2976
2977 2018-04-30  Tom Tromey  <tom@tromey.com>
2978
2979         * i386-tdep.c (i386_type_align): New function.
2980         (i386_gdbarch_init): Update.
2981         * gdbarch.sh (type_align): New method.
2982         * gdbarch.c, gdbarch.h: Rebuild.
2983         * arch-utils.h (default_type_align): Declare.
2984         * arch-utils.c (default_type_align): New function.
2985         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
2986         (struct type) <align_log2>: New field.
2987         <instance_flags>: Now a bitfield.
2988         (TYPE_RAW_ALIGN): New macro.
2989         (type_align, type_raw_align, set_type_align): Declare.
2990         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
2991         functions.
2992         * dwarf2read.c (quirk_rust_enum): Set type alignment.
2993         (get_alignment, maybe_set_alignment): New functions.
2994         (read_structure_type, read_enumeration_type, read_array_type)
2995         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
2996         (read_subrange_type, read_base_type): Set type alignment.
2997
2998 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
2999
3000         * dwarf2read.c (read_index_from_section): Use bool.
3001
3002 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
3003
3004         PR gdb/22950
3005         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
3006         with #ifdef.
3007
3008 2018-04-29  John Reiser  <jreiser@BitWagon.com>
3009
3010         PR build/22873
3011         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
3012         last step, and do it atomically.
3013
3014 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
3015
3016         * compile/compile-c-types.c (convert_int, convert_float):
3017         Update for C FE v1.
3018
3019 2018-04-27  Tom Tromey  <tom@tromey.com>
3020
3021         PR rust/22545:
3022         * rust-lang.c (rust_inclusive_range_type_p): New function.
3023         (rust_range): Handle inclusive ranges.
3024         (rust_compute_range): Likewise.
3025         * rust-exp.y (struct rust_op) <inclusive>: New field.
3026         (DOTDOTEQ): New constant.
3027         (range_expr): Add "..=" productions.
3028         (operator_tokens): Add "..=" token.
3029         (ast_range): Add "inclusive" parameter.
3030         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
3031         ranges.
3032         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
3033         bounds values.
3034         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
3035         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
3036         Update comments.
3037         * expprint.c (print_subexp_standard): Handle new bounds values.
3038         (dump_subexp_body_standard): Likewise.
3039
3040 2018-04-27  Tom Tromey  <tom@tromey.com>
3041
3042         * configure: Rebuild.
3043         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
3044         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
3045         "OVERRIDE".
3046         (class symbol_needs_eval_context): Likewise.
3047         * dwarf2read.c (mock_mapped_index::symbol_name_count)
3048         (mock_mapped_index::symbol_name_at): Use "override".  Remove
3049         "virtual".
3050         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
3051         "override".
3052         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
3053         * aarch64-tdep.c (instruction_reader::read): Use "override".
3054         (instruction_reader_test::read): Likewise.
3055         * arm-tdep.c (instruction_reader::read): Use "override".
3056         (instruction_reader_thumb::read): Likewise.
3057
3058 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
3059
3060         PR remote/9665
3061         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
3062         instead of remote_send.
3063         (remote_send): Remove.
3064
3065 2018-04-26  Pedro Alves  <palves@redhat.com>
3066
3067         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
3068         find_function_start_sal instead of find_pc_line.
3069
3070 2018-04-26  Pedro Alves  <palves@redhat.com>
3071
3072         * breakpoint.c (set_breakpoint_location_function): Handle
3073         mst_data_gnu_ifunc.
3074         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
3075         * elfread.c (elf_symtab_read): Give data symbols with
3076         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
3077         (elf_rel_plt_read): Update comment.
3078         * linespec.c (convert_linespec_to_sals): Handle
3079         mst_data_gnu_ifunc.
3080         (minsym_found): Handle mst_data_gnu_ifunc.
3081         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
3082         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
3083         * parse.c (find_minsym_type_and_address): Handle
3084         mst_data_gnu_ifunc.
3085         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
3086         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
3087         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
3088         comment.
3089         <mst_data_gnu_ifunc>: New enumerator.
3090
3091 2018-04-26  Pedro Alves  <palves@redhat.com>
3092
3093         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
3094         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
3095         'want_trampoline' parameter by a lookup_msym_prefer parameter.
3096         Handle it.
3097         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
3098         (lookup_minimal_symbol_by_pc): Adjust.
3099         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
3100         (lookup_solib_trampoline_symbol_by_pc): Adjust.
3101         * minsyms.h (lookup_msym_prefer): New enum.
3102         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
3103         parameter by a lookup_msym_prefer parameter.
3104
3105 2018-04-26  Pedro Alves  <palves@redhat.com>
3106
3107         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
3108         ends in "@plt" instead of looking at the symbol's section.
3109
3110 2018-04-26  Pedro Alves  <palves@redhat.com>
3111
3112         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
3113         all references.
3114         (find_pc_partial_function_gnu_ifunc): Rename to ...
3115         (find_pc_partial_function): ... this, and remove references to
3116         'is_gnu_ifunc_p'.
3117         (find_pc_partial_function): Delete old implementation.
3118         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
3119
3120 2018-04-26  Pedro Alves  <palves@redhat.com>
3121
3122         * linespec.c (struct bound_minimal_symbol_search_key): New.
3123         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
3124         skip first line if we found a GNU ifunc minimal symbol by name.
3125         (compare_msymbols): Change parameters to work with a destructured
3126         lhs minsym.
3127         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
3128         functions.
3129
3130 2018-04-26  Pedro Alves  <palves@redhat.com>
3131
3132         * breakpoint.c (set_breakpoint_location_function): Don't resolve
3133         ifunc targets here.  Instead, if we have an ifunc minsym, use its
3134         address/name.
3135         (add_location_to_breakpoint): Store the minsym and the objfile in
3136         the breakpoint location.
3137         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
3138         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
3139         Record the minsym in the sal.
3140         * symtab.h (symtab_and_line) <msymbol>: New field.
3141
3142 2018-04-26  Pedro Alves  <palves@redhat.com>
3143
3144         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
3145         unless we actually resolved the ifunc.
3146
3147 2018-04-26  Pedro Alves  <palves@redhat.com>
3148
3149         * c-exp.y (variable production): Prefer ifunc minsyms over
3150         regular function symbols.
3151         * symtab.c (find_gnu_ifunc): New function.
3152         * minsyms.h (lookup_msym_prefer): New enum.
3153         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
3154         parameter by a lookup_msym_prefer parameter.
3155         * symtab.h (find_gnu_ifunc): New declaration.
3156
3157 2018-04-26  Pedro Alves  <palves@redhat.com>
3158
3159         * blockframe.c (find_gnu_ifunc_target_type): New function.
3160         (find_function_type): New.
3161         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
3162         return a value with a memory address.
3163         (eval_call): For calls to GNU ifunc functions, try to find the
3164         type of the target function from the type that the resolver
3165         returns.
3166         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
3167         symbols.
3168         * infcall.c (find_function_return_type): Delete.
3169         (find_function_addr): Add 'function_type' parameter.  For calls to
3170         GNU ifunc functions, try to find the type of the target function
3171         from the type that the resolver returns, and return it via
3172         FUNCTION_TYPE.
3173         (call_function_by_hand_dummy): Adjust to use the function type
3174         returned by find_function_addr.
3175         (find_function_addr): Add 'function_type' parameter and move
3176         description here.
3177         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
3178         declarations.
3179
3180 2018-04-26  Pedro Alves  <palves@redhat.com>
3181
3182         * c-exp.y (variable production): Skip finding an alias for ifunc
3183         symbols.
3184
3185 2018-04-26  Pedro Alves  <palves@redhat.com>
3186
3187         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
3188
3189 2018-04-25  Pedro Alves  <palves@redhat.com>
3190
3191         * infcmd.c (kill_command): Print the pid as string, not the whole
3192         thread's ptid.  Add comment.  s/has been killed/killed/ in output
3193         message.
3194         * remote.c (remote_detach_1): Print the pid as string, not the
3195         whole thread's ptid.
3196
3197 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
3198             Sergio Durigan Junior  <sergiodj@redhat.com>
3199             Pedro Alves  <palves@redhat.com>
3200
3201         * infcmd.c (kill_command): Print message when inferior has
3202         been killed.
3203         * inferior.c (print_inferior_events): Remove 'static'.  Set as
3204         '1'.
3205         (add_inferior): Improve message printed when
3206         'print_inferior_events' is on.
3207         (exit_inferior): Remove message printed when
3208         'print_inferior_events' is on.
3209         (detach_inferior): Improve message printed when
3210         'print_inferior_events' is on.
3211         (initialize_inferiors): Use 'add_inferior_silent' to set
3212         'current_inferior_'.
3213         * inferior.h (print_inferior_events): Declare here as
3214         'extern'.
3215         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
3216         '[Detaching...]' messages when 'print_inferior_events' is on.
3217         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
3218         as prefix/suffix for messages.  Remove periods.  Fix erroneous
3219         'Detaching after fork from child...', replace it by '... from
3220         parent...'.
3221         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
3222         prefix/suffix when printing 'Detaching...' messages.  Print
3223         them when 'print_inferior_events' is on.
3224         * remote.c (remote_detach_1): Print message when detaching
3225         from inferior and '!is_fork_parent'.
3226
3227 2018-04-24  Tom Tromey  <tom@tromey.com>
3228
3229         * cli-out.h: Reindent.
3230
3231 2018-04-24  Tom Tromey  <tom@tromey.com>
3232
3233         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
3234         (cli_ui_out::do_field_string): Use fputs_filtered.
3235         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
3236
3237 2018-04-23  Tom Tromey  <tom@tromey.com>
3238
3239         * guile/scm-frame.c (gdbscm_frame_read_var): Use
3240         gdb::unique_xmalloc_ptr.
3241
3242 2018-04-23  Tom Tromey  <tom@tromey.com>
3243
3244         * configure: Rebuild.
3245
3246 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
3247
3248         PR gdb/23095
3249         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
3250         prepare_for_testing.  Set normal_bp to r_debug_state if target
3251         is bsd.
3252
3253 2018-04-21  Pedro Alves  <palves@redhat.com>
3254             Rajendra SY  <rajendra.sy@gmail.com>
3255
3256         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
3257         * remote.c (extended_remote_attach): In all-stop mode, mark the
3258         thread as executing.
3259
3260 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3261
3262         * thread.c (thread_apply_all_command): Fix comment.
3263         (thread_command): Fix comment.
3264
3265 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
3266
3267         * common/tdesc.h (tdesc_create_feature): Remove xml filename
3268         parameter.
3269         * features/aarch64-core.c (create_feature_aarch64_core):
3270         Regenerate.
3271         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
3272         Likewise.
3273         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
3274         Likewise.
3275         * features/i386/32bit-avx512.c
3276         (create_feature_i386_32bit_avx512): Likewise.
3277         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
3278         Likewise.
3279         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
3280         Likewise.
3281         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
3282         Likewise.
3283         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
3284         Likewise.
3285         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
3286         Likewise.
3287         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
3288         Likewise.
3289         * features/i386/64bit-avx512.c
3290         (create_feature_i386_64bit_avx512): Likewise.
3291         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
3292         Likewise.
3293         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
3294         Likewise.
3295         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
3296         Likewise.
3297         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
3298         Likewise.
3299         * features/i386/64bit-segments.c
3300         (create_feature_i386_64bit_segments): Likewise.
3301         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
3302         Likewise.
3303         * features/i386/x32-core.c
3304         (create_feature_i386_x32_core): Likewise.
3305         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
3306         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
3307         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
3308         * target-descriptions.c: In generated code, don't pass xml
3309         filename.
3310
3311 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3312
3313         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
3314         (print_xml_feature::visit_post): Likewise.
3315         (print_xml_feature::visit): Likewise.
3316         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
3317         (print_xml_feature): Add new class.
3318         * regformats/regdat.sh: Null xmltarget on feature targets.
3319         * target-descriptions.c (struct target_desc): Add xmltarget.
3320         (maintenance_check_tdesc_xml_convert): Add unittest function.
3321         (tdesc_get_features_xml): Add function to get xml.
3322         (maintenance_check_xml_descriptions): Test xml generation.
3323         * xml-tdesc.c (string_read_description_xml): Add function.
3324         * xml-tdesc.h (string_read_description_xml): Add declaration.
3325
3326 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3327
3328         * features/Makefile: Add feature marker to targets with new style
3329         target descriptions.
3330         * regformats/aarch64.dat: Regenerate.
3331         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
3332         * regformats/i386/amd64-avx-linux.dat: Likewise.
3333         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
3334         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
3335         * regformats/i386/amd64-linux.dat: Likewise.
3336         * regformats/i386/amd64-mpx-linux.dat: Likewise.
3337         * regformats/i386/amd64.dat: Likewise.
3338         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
3339         * regformats/i386/i386-avx-linux.dat: Likewise.
3340         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
3341         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
3342         * regformats/i386/i386-linux.dat: Likewise.
3343         * regformats/i386/i386-mmx-linux.dat: Likewise.
3344         * regformats/i386/i386-mpx-linux.dat: Likewise.
3345         * regformats/i386/i386.dat: Likewise.
3346         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
3347         * regformats/i386/x32-avx-linux.dat: Likewise.
3348         * regformats/i386/x32-linux.dat: Likewise.
3349         * regformats/tic6x-c62x-linux.dat: Likewise.
3350         * regformats/tic6x-c64x-linux.dat: Likewise.
3351         * regformats/tic6x-c64xp-linux.dat: Likewise.
3352         * regformats/regdat.sh: Parse feature marker.
3353
3354 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3355
3356         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
3357         (tdesc_osabi_name): Likewise.
3358         * target-descriptions.c (tdesc_architecture_name): Add new
3359         function.
3360         (tdesc_osabi_name): Likewise.
3361
3362 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3363
3364         * common/tdesc.c (tdesc_predefined_type): Move to here.
3365         (tdesc_named_type): Likewise.
3366         (tdesc_create_vector): Likewise.
3367         (tdesc_create_struct): Likewise.
3368         (tdesc_set_struct_size): Likewise.
3369         (tdesc_create_union): Likewise.
3370         (tdesc_create_flags): Likewise.
3371         (tdesc_create_enum): Likewise.
3372         (tdesc_add_field): Likewise.
3373         (tdesc_add_typed_bitfield): Likewise.
3374         (tdesc_add_bitfield): Likewise.
3375         (tdesc_add_flag): Likewise.
3376         (tdesc_add_enum_value): Likewise.
3377         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
3378         (struct tdesc_type_vector): Likewise.
3379         (struct tdesc_type_field): Likewise.
3380         (struct tdesc_type_with_fields): Likewise.
3381         (tdesc_create_enum): Add declaration.
3382         (tdesc_add_typed_bitfield): Likewise.
3383         (tdesc_add_enum_value): Likewise.
3384         * target-descriptions.c (tdesc_type_field): Move from here.
3385         (tdesc_type_builtin): Likewise.
3386         (tdesc_type_vector): Likewise.
3387         (tdesc_type_with_fields): Likewise.
3388         (tdesc_predefined_types): Likewise.
3389         (tdesc_named_type): Likewise.
3390         (tdesc_create_vector): Likewise.
3391         (tdesc_create_struct): Likewise.
3392         (tdesc_set_struct_size): Likewise.
3393         (tdesc_create_union): Likewise.
3394         (tdesc_create_flags): Likewise.
3395         (tdesc_create_enum): Likewise.
3396         (tdesc_add_field): Likewise.
3397         (tdesc_add_typed_bitfield): Likewise.
3398         (tdesc_add_bitfield): Likewise.
3399         (tdesc_add_flag): Likewise.
3400         (tdesc_add_enum_value): Likewise.
3401         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
3402         (tdesc_add_typed_bitfield): Likewise.
3403         (tdesc_add_enum_value): Likewise.
3404
3405 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3406
3407         * common/tdesc.c (tdesc_feature::accept): Move to here.
3408         (tdesc_feature::operator==): Likewise.
3409         (tdesc_create_reg): Likewise.
3410         * common/tdesc.h (tdesc_type_kind): Likewise.
3411         (struct tdesc_type): Likewise.
3412         (struct tdesc_feature): Likewise.
3413         * regformats/regdat.sh: Create a feature.
3414         * target-descriptions.c (tdesc_type_kind): Move from here.
3415         (tdesc_type): Likewise.
3416         (tdesc_type_up): Likewise.
3417         (tdesc_feature): Likewise.
3418         (tdesc_create_reg): Likewise.
3419
3420 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3421
3422         * Makefile.in: Add arch/tdesc.c
3423         * common/tdesc.c: New file.
3424         * common/tdesc.h (tdesc_element_visitor): Move to here.
3425         (tdesc_element): Likewise.
3426         (tdesc_reg): Likewise.
3427         (tdesc_reg_up): Likewise.
3428         * regformats/regdef.h (reg): Add offset to constructors.
3429         * target-descriptions.c (tdesc_element_visitor): Move from here.
3430         (tdesc_element): Likewise.
3431         (tdesc_reg): Likewise.
3432         (tdesc_reg_up): Likewise.
3433
3434 2018-04-17  Tom Tromey  <tom@tromey.com>
3435
3436         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
3437         discriminant field.
3438
3439 2018-04-17  Tom Tromey  <tom@tromey.com>
3440
3441         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
3442
3443 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3444
3445         * symtab.c (print_symbol_info): Skip printing filename and line
3446         number when `last' is NULL.
3447         (symtab_symbol_info): Use empty string instead of NULL for first
3448         invocation of print_symbol_info.
3449         (rbreak_command): Pass NULL to `last' parameter of
3450         print_symbol_info.
3451
3452 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
3453
3454         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
3455         instead of nullptr.
3456
3457 2018-04-16  Pedro Alves  <palves@redhat.com>
3458
3459         * MAINTAINERS (sh): Remove.
3460         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
3461         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
3462         (ALLDEPFILES): Remove sh64-tdep.c.
3463         * NEWS: Mentions that support for SH-5/SH64 is removed.
3464         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
3465         (sh*-*-openbsd*): Ditto.
3466         (sh64-*-elf*): Remove.
3467         (sh*): Remove.
3468         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
3469         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
3470         * sh-tdep.c: No longer include "sh64-tdep.h".
3471         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
3472         * sh64-tdep.c, sh64-tdep.h: Remove files.
3473
3474 2018-04-16  Pedro Alves  <palves@redhat.com>
3475
3476         * MAINTAINERS: Remove m88k.
3477         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
3478         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
3479         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
3480         * NEWS: Mention that support for m88k was removed.
3481         * configure.host (m88*-*-*): Remove support.
3482         * configure.nat (m88k-*-*): Remove support.
3483         * configure.tgt (m88*-*-openbsd*): Remove.
3484         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
3485
3486 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
3487
3488         * configure.tgt (x86_tobjs): New variable.
3489         (amd64_tobjs, i386_tobjs): Use it.
3490
3491 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3492
3493         * symtab.c (print_symbol_info): Precede the symbol definition by
3494         the line number when available.
3495         * NEWS: Advertise this enhancement.
3496
3497 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3498
3499         * NEWS (New options): announce set/show record btrace cpu.
3500         * btrace.c: Include record-btrace.h.
3501         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
3502         the vendor is unknown.
3503         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
3504         Maybe overwrite the btrace configuration's cpu.
3505         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
3506         (btrace_fetch): Add cpu parameter.  Update callers.
3507         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
3508         Maybe overwrite the btrace configuration's cpu.  Skip enabling
3509         errata workarounds if the vendor is unknown.
3510         * python/py-record-btrace.c: Include record-btrace.h.
3511         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
3512         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
3513         * record-btrace.c (record_btrace_cpu_state_kind): New.
3514         (record_btrace_cpu): New.
3515         (set_record_btrace_cpu_cmdlist): New.
3516         (record_btrace_get_cpu): New.
3517         (require_btrace_thread, record_btrace_info)
3518         (record_btrace_resume_thread): Call record_btrace_get_cpu.
3519         (cmd_set_record_btrace_cpu_none): New.
3520         (cmd_set_record_btrace_cpu_auto): New.
3521         (cmd_set_record_btrace_cpu): New.
3522         (cmd_show_record_btrace_cpu): New.
3523         (_initialize_record_btrace): Initialize set/show record btrace cpu
3524         commands.
3525         * record-btrace.h (record_btrace_get_cpu): New.
3526
3527 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3528
3529         * record.c (set_record_command): Fix typo in message.
3530
3531 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3532
3533         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
3534
3535 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3536
3537         * infrun.c (process_event_stop_test): Call
3538         gdbarch_in_indirect_branch_thunk.
3539         * gdbarch.sh (in_indirect_branch_thunk): New.
3540         * gdbarch.c: Regenerated.
3541         * gdbarch.h: Regenerated.
3542         * x86-tdep.h: New.
3543         * x86-tdep.c: New.
3544         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
3545         (HFILES_NO_SRCDIR): Add x86-tdep.h.
3546         (ALLDEPFILES): Add x86-tdep.c.
3547         * arch-utils.h (default_in_indirect_branch_thunk): New.
3548         * arch-utils.c (default_in_indirect_branch_thunk): New.
3549         * i386-tdep: Include x86-tdep.h.
3550         (i386_in_indirect_branch_thunk): New.
3551         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
3552         function.
3553         * amd64-tdep: Include x86-tdep.h.
3554         (amd64_in_indirect_branch_thunk): New.
3555         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
3556
3557 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
3558
3559         PR gdb/23053
3560         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
3561         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
3562         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
3563         regression.
3564
3565 2018-04-12  Tom Tromey  <tom@tromey.com>
3566
3567         * rust-lang.c (rust_print_struct_def): Remove univariant code.
3568         (rust_evaluate_subexp): Likewise.
3569
3570 2018-04-12  Pedro Alves  <palves@redhat.com>
3571
3572         * procfs.c (procfs_detach): Make forward declaration's prototype
3573         match definition's protototype.
3574         (proc_get_LDT_entry): Remove stale do_cleanups call.
3575
3576 2018-04-12  Pedro Alves  <palves@redhat.com>
3577
3578         * target.h (target_ops::to_has_exited): Delete.
3579         (target_has_exited): Delete.
3580         * target-delegates.c: Regenerate.
3581
3582 2018-04-11  Pedro Alves  <palves@redhat.com>
3583
3584         * target.c (fileio_fh_t::t): Add comment.
3585         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3586         (target_fileio_close): Handle a NULL target.
3587         (invalidate_fileio_fh): New.
3588         (target_close): Call it.
3589         * remote.c (remote_hostio_send_command): No longer check whether
3590         remote_desc is open.
3591
3592 2018-04-11  Pedro Alves  <palves@redhat.com>
3593
3594         * target.c (fileio_fh_t): Make it a named struct instead of a
3595         typedef.
3596         (fileio_fh_t::is_closed): New method.
3597         (DEF_VEC_O (fileio_fh_t)): Remove.
3598         (fileio_fhandles): Now a std::vector.
3599         (is_closed_fileio_fh): Delete.
3600         (acquire_fileio_fd): Adjust.  Rename parameters.
3601         (release_fileio_fd): Adjust.
3602         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
3603         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3604         (target_fileio_close): Adjust.
3605
3606 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
3607
3608         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
3609         index.
3610
3611 2018-04-10  Pedro Alves  <palves@redhat.com>
3612
3613         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
3614         (scoped_finish_thread_state): New class.
3615         * infcmd.c (run_command_1): Use it instead of finish_thread_state
3616         cleanup.
3617         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
3618         (fetch_inferior_event, normal_stop): Likewise.
3619         * thread.c (finish_thread_state_cleanup): Delete.
3620
3621 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3622             Pedro Alves  <palves@redhat.com>
3623
3624         * value.c: Include "selftest.h" and "common/array-view.h".
3625         (struct range) <operator ==>: New.
3626         (test_ranges_contain): New.
3627         (check_ranges_vector): New.
3628         (test_insert_into_bit_range_vector): New.
3629         (_initialize_values): Register selftests.
3630         * common/array-view.h (operator==, operator!=): New.
3631
3632 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3633
3634         * common/gdb_vecs.h (unordered_remove): Add overload that takes
3635         an iterator.
3636         * inline-frame.c: Include <algorithm>.
3637         (struct inline_state): Add constructor.
3638         (inline_state_s): Remove.
3639         (DEF_VEC_O(inline_state_s)): Remove.
3640         (inline_states): Change type to std::vector.
3641         (find_inline_frame_state): Adjust to std::vector.
3642         (allocate_inline_frame_state): Remove.
3643         (clear_inline_frame_state): Adjust to std::vector.
3644         (skip_inline_frames): Adjust to std::vector.
3645
3646 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3647
3648         * tracepoint.h (struct trace_state_variable): Add constructor.
3649         <name>: Change type to std::string.
3650         * tracepoint.c (tsv_s): Remove.
3651         (DEF_VEC_O(tsv_s)): Remove.
3652         (tvariables): Change to std::vector.
3653         (create_trace_state_variable): Adjust to std::vector.
3654         (find_trace_state_variable): Likewise.
3655         (find_trace_state_variable_by_number): Likewise.
3656         (delete_trace_state_variable): Likewise.
3657         (trace_variable_command): Adjust to std::string.
3658         (delete_trace_variable_command): Likewise.
3659         (tvariables_info_1): Adjust to std::vector.
3660         (save_trace_state_variables): Likewise.
3661         (start_tracing): Likewise.
3662         (merge_uploaded_trace_state_variables): Adjust to std::vector
3663         and std::string.
3664         * target.h (struct target_ops)
3665         <to_download_trace_state_variable>: Pass reference to
3666         trace_state_variable.
3667         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
3668         * target-delegates.c: Re-generate.
3669         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
3670         (mi_tsv_deleted): Likewise.
3671         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
3672         * remote.c (remote_download_trace_state_variable): Change
3673         pointer to reference and adjust.
3674         * make-target-delegates (parse_argtypes): Handle references.
3675         (write_function_header): Likewise.
3676         (munge_type): Likewise.
3677
3678 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3679
3680         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3681         string_view-selftests.c.
3682         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
3683         testsuite.
3684         * unittests/basic_string_view/cons/char/1.cc: Likewise.
3685         * unittests/basic_string_view/cons/char/2.cc: Likewise.
3686         * unittests/basic_string_view/cons/char/3.cc: Likewise.
3687         * unittests/basic_string_view/element_access/char/1.cc:
3688         Likewise.
3689         * unittests/basic_string_view/element_access/char/empty.cc:
3690         Likewise.
3691         * unittests/basic_string_view/element_access/char/front_back.cc:
3692         Likewise.
3693         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
3694         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
3695         Likewise.
3696         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
3697         Likewise.
3698         * unittests/basic_string_view/modifiers/swap/char/1.cc:
3699         Likewise.
3700         * unittests/basic_string_view/operations/compare/char/1.cc:
3701         Likewise.
3702         * unittests/basic_string_view/operations/compare/char/13650.cc:
3703         Likewise.
3704         * unittests/basic_string_view/operations/copy/char/1.cc:
3705         Likewise.
3706         * unittests/basic_string_view/operations/data/char/1.cc:
3707         Likewise.
3708         * unittests/basic_string_view/operations/find/char/1.cc:
3709         Likewise.
3710         * unittests/basic_string_view/operations/find/char/2.cc:
3711         Likewise.
3712         * unittests/basic_string_view/operations/find/char/3.cc:
3713         Likewise.
3714         * unittests/basic_string_view/operations/find/char/4.cc:
3715         Likewise.
3716         * unittests/basic_string_view/operations/rfind/char/1.cc:
3717         Likewise.
3718         * unittests/basic_string_view/operations/rfind/char/2.cc:
3719         Likewise.
3720         * unittests/basic_string_view/operations/rfind/char/3.cc:
3721         Likewise.
3722         * unittests/basic_string_view/operations/substr/char/1.cc:
3723         Likewise.
3724         * unittests/basic_string_view/operators/char/2.cc: Likewise.
3725         * unittests/string_view-selftests.c: New file.
3726
3727 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3728
3729         * unittests/basic_string_view/capacity/1.cc: New file.
3730         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
3731         * unittests/basic_string_view/cons/char/1.cc: New file.
3732         * unittests/basic_string_view/cons/char/2.cc: New file.
3733         * unittests/basic_string_view/cons/char/3.cc: New file.
3734         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
3735         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
3736         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
3737         * unittests/basic_string_view/element_access/char/1.cc: New file.
3738         * unittests/basic_string_view/element_access/char/2.cc: New file.
3739         * unittests/basic_string_view/element_access/char/empty.cc: New file.
3740         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
3741         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
3742         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
3743         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
3744         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
3745         * unittests/basic_string_view/include.cc: New file.
3746         * unittests/basic_string_view/inserters/char/1.cc: New file.
3747         * unittests/basic_string_view/inserters/char/2.cc: New file.
3748         * unittests/basic_string_view/inserters/char/3.cc: New file.
3749         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
3750         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
3751         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
3752         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
3753         * unittests/basic_string_view/literals/types.cc: New file.
3754         * unittests/basic_string_view/literals/values.cc: New file.
3755         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
3756         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
3757         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
3758         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
3759         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
3760         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
3761         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
3762         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
3763         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
3764         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
3765         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
3766         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
3767         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
3768         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
3769         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
3770         * unittests/basic_string_view/operations/data/char/1.cc: New file.
3771         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
3772         * unittests/basic_string_view/operations/find/char/1.cc: New file.
3773         * unittests/basic_string_view/operations/find/char/2.cc: New file.
3774         * unittests/basic_string_view/operations/find/char/3.cc: New file.
3775         * unittests/basic_string_view/operations/find/char/4.cc: New file.
3776         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
3777         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
3778         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
3779         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
3780         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
3781         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
3782         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
3783         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
3784         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
3785         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
3786         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
3787         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
3788         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
3789         * unittests/basic_string_view/operators/char/2.cc: New file.
3790         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
3791         * unittests/basic_string_view/range_access/char/1.cc: New file.
3792         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
3793         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
3794         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
3795         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
3796         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
3797         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
3798         * unittests/basic_string_view/requirements/typedefs.cc: New file.
3799         * unittests/basic_string_view/typedefs.cc: New file.
3800         * unittests/basic_string_view/types/1.cc: New file.
3801
3802 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3803
3804         * common/gdb_string_view.h: Remove libstdc++ implementation
3805         details, adjust to gdb reality.
3806         * common/gdb_string_view.tcc: Likewise.
3807         * cli/cli-script.c (struct string_view): Remove.
3808         (user_args) <m_args>: Change element type to gdb::string_view.
3809         (user_args::insert_args): Adjust.
3810
3811 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3812
3813         * common/gdb_string_view.h: New file.
3814         * common/gdb_string_view.tcc: New file.
3815
3816 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3817
3818         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
3819         * configure: Re-generate.
3820
3821 2018-04-09  Pedro Alves  <palves@redhat.com>
3822
3823         * gdbarch.sh: Include "observable.h" instead of "observer.h".
3824         (set_target_gdbarch): Call
3825         gdb::observers::architecture_changed.notify instead of
3826         observer_notify_architecture_changed.
3827
3828 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3829
3830         * tracepoint.c (struct current_traceframe_cleanup): Remove.
3831         (do_restore_current_traceframe_cleanup): Remove.
3832         (restore_current_traceframe_cleanup_dtor): Remove.
3833         (make_cleanup_restore_current_traceframe): Remove.
3834         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
3835         New.
3836         * tracepoint.h (struct scoped_restore_current_traceframe): New.
3837         * infrun.c (fetch_inferior_event): Use
3838         scoped_restore_current_traceframe.
3839
3840 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3841
3842         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
3843         Remove.
3844         <n_allocated_type_units>: Remove.
3845         <all_type_units>: Change to std::vector.
3846         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
3847         to std::vector change.
3848         (dwarf2_per_objfile::get_cutu): Likewise.
3849         (dwarf2_per_objfile::get_tu): Likewise.
3850         (create_signatured_type_table_from_index): Likewise.
3851         (create_signatured_type_table_from_debug_names): Likewise.
3852         (dw2_symtab_iter_next): Likewise.
3853         (dw2_print_stats): Likewise.
3854         (dw2_expand_all_symtabs): Likewise.
3855         (dw2_expand_marked_cus): Likewise.
3856         (dw2_debug_names_iterator::next): Likewise.
3857         (dwarf2_initialize_objfile): Likewise.
3858         (add_signatured_type_cu_to_table): Likewise.
3859         (create_all_type_units): Likewise.
3860         (add_type_unit): Likewise.
3861         (struct tu_abbrev_offset): Add constructor.
3862         (build_type_psymtabs_1): Adjust to std::vector change.
3863         (print_tu_stats): Likewise.
3864         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
3865         (write_debug_names): Likewise.
3866
3867 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3868
3869         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
3870         Make an std::vector.
3871         <n_comp_units>: Remove.
3872         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
3873         to std::vector change.
3874         (dwarf2_per_objfile::get_cutu): Likewise.
3875         (dwarf2_per_objfile::get_cu): Likewise.
3876         (create_cus_from_index): Likewise.
3877         (create_addrmap_from_index): Likewise.
3878         (create_addrmap_from_aranges): Likewise.
3879         (dwarf2_read_index): Likewise.
3880         (dw2_find_last_source_symtab): Likewise.
3881         (dw2_map_symtabs_matching_filename): Likewise.
3882         (dw2_symtab_iter_next): Likewise.
3883         (dw2_print_stats): Likewise.
3884         (dw2_expand_all_symtabs): Likewise.
3885         (dw2_expand_symtabs_with_fullname): Likewise.
3886         (dw2_expand_marked_cus): Likewise.
3887         (dw2_map_symbol_filenames): Likewise.
3888         (create_cus_from_debug_names): Likewise.
3889         (dwarf2_read_debug_names): Likewise.
3890         (dw2_debug_names_iterator::next): Likewise.
3891         (dwarf2_initialize_objfile): Likewise.
3892         (set_partial_user): Likewise.
3893         (dwarf2_build_psymtabs_hard): Likewise.
3894         (read_comp_units_from_section): Remove arguments, adjust to
3895         std::vector change.
3896         (create_all_comp_units): Adjust to std::vector and
3897         read_comp_units_from_section changes.
3898         (dwarf2_find_containing_comp_unit): Adjust to std::vector
3899         change.
3900         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
3901         (psyms_seen_size): Likewise.
3902         (write_gdbindex): Likewise.
3903         (write_debug_names): Likewise.
3904
3905 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3906
3907         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
3908         with dwarf2_per_objfile.
3909         (create_cus_from_index): Likewise.
3910         (create_signatured_type_table_from_index): Likewise.
3911         (dwarf2_read_index): Likewise.
3912         (dwarf2_initialize_objfile): Likewise.
3913         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
3914         per_cu rather than get_dwarf2_per_objfile.
3915
3916 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3917
3918         * dwarf2read.h (struct signatured_type): Forward declare.
3919         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
3920         New methods.
3921         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
3922         (dw2_get_cutu): ...this.
3923         (dwarf2_per_objfile::get_cu): Rename from...
3924         (dw2_get_cu): ...this.
3925         (dwarf2_per_objfile::get_tu): New.
3926         (create_addrmap_from_index): Adjust.
3927         (create_addrmap_from_aranges): Adjust.
3928         (dw2_find_last_source_symtab): Adjust.
3929         (dw2_map_symtabs_matching_filename): Adjust.
3930         (dw2_symtab_iter_next): Adjust.
3931         (dw2_print_stats): Adjust.
3932         (dw2_expand_all_symtabs): Adjust.
3933         (dw2_expand_symtabs_with_fullname): Adjust.
3934         (dw2_expand_marked_cus): Adjust.
3935         (dw_expand_symtabs_matching_file_matcher): Adjust.
3936         (dw2_map_symbol_filenames): Adjust.
3937         (dw2_debug_names_iterator::next): Adjust.
3938         (dwarf2_initialize_objfile): Adjust.
3939         (set_partial_user): Adjust.
3940         (dwarf2_build_psymtabs_hard): Adjust.
3941
3942 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3943
3944         * dwarf2read.c (create_signatured_type_table_from_debug_names):
3945         Remove unused variables.
3946         (dw2_map_symtabs_matching_filename): Likewise.
3947         (dwarf2_record_block_ranges): Likewise.
3948         (dwarf2_read_addr_index): Likewise.
3949         (follow_die_offset): Likewise.
3950
3951 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3952
3953         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
3954         to symbol_file_add_main.
3955
3956 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3957
3958         PR mi/22299
3959         * mi/mi-console.c (do_fputc_async_safe): New.
3960         (mi_console_file::write_async_safe): New.
3961         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
3962         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
3963         New.
3964         * ui-file.c (ui_file::putstrn): Adjust call to
3965         fputstrn_unfiltered.
3966         * utils.c (printchar): Replace do_fputs and do_fprintf
3967         parameters by do_fputc.
3968         (fputstr_filtered): Adjust call to printchar.
3969         (fputstr_unfiltered): Likewise.
3970         (fputstrn_filtered): Likewise.
3971         (fputstrn_unfiltered): Add do_fputc parameter, pass to
3972         printchar.
3973         * utils.h (do_fputc_ftype): New typedef.
3974         (fputstrn_unfiltered): Add do_fputc parameter.
3975
3976 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3977
3978         * regformats/i386/i386-avx.dat: Remove.
3979
3980 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3981
3982         PR gdb/22979
3983         * amd64-tdep.c (amd64_none_init_abi): New function.
3984         (amd64_x32_none_init_abi): New function.
3985         (_initialize_amd64_tdep): Register handlers for x86-64 and
3986         x64_32 with GDB_OSABI_NONE.
3987         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
3988         GDB_OSABI_NONE osabi.
3989
3990 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3991
3992         PR gdb/22980
3993         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
3994         GDB_OSABI_NONE.
3995         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
3996         * osabi.c (gdb_osabi_names): Add "unknown" entry.
3997
3998 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3999
4000         * common/byte-vector.h (char_vector): New type.
4001         * target.h (target_read_alloc): Return
4002         gdb::optional<byte_vector>.
4003         (target_read_stralloc): Return gdb::optional<char_vector>.
4004         (target_get_osdata): Return gdb::optional<char_vector>.
4005         * target.c (target_read_alloc_1): Templatize.  Replacement
4006         manual memory management with vector.
4007         (target_read_alloc): Change return type, adjust.
4008         (target_read_stralloc): Change return type, adjust.
4009         (target_get_osdata): Change return type, adjust.
4010         * auxv.c (struct auxv_info) <length>: Remove.
4011         <data>: Change type to gdb::optional<byte_vector>.
4012         (auxv_inferior_data_cleanup): Free auxv_info with delete.
4013         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
4014         (target_auxv_search): Adjust.
4015         (fprint_target_auxv): Adjust.
4016         * avr-tdep.c (avr_io_reg_read_command): Adjust.
4017         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
4018         (linux_make_corefile_notes): Adjust.
4019         * osdata.c (get_osdata): Adjust.
4020         * remote.c (remote_get_threads_with_qxfer): Adjust.
4021         (remote_memory_map): Adjust.
4022         (remote_traceframe_info): Adjust.
4023         (btrace_read_config): Adjust.
4024         (remote_read_btrace): Adjust.
4025         (remote_pid_to_exec_file): Adjust.
4026         * solib-aix.c (solib_aix_get_library_list): Adjust.
4027         * solib-dsbt.c (decode_loadmap): Don't free buf.
4028         (dsbt_get_initial_loadmaps): Adjust.
4029         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
4030         * solib-target.c (solib_target_current_sos): Adjust.
4031         * tracepoint.c (sdata_make_value): Adjust.
4032         * xml-support.c (xinclude_start_include): Adjust.
4033         (xml_fetch_content_from_file): Adjust.
4034         * xml-support.h (xml_fetch_another): Change return type.
4035         (xml_fetch_content_from_file): Change return type.
4036         * xml-syscall.c (xml_init_syscalls_info): Adjust.
4037         * xml-tdesc.c (file_read_description_xml): Adjust.
4038         (fetch_available_features_from_target): Change return type.
4039         (target_fetch_description_xml): Adjust.
4040         (target_read_description_xml): Adjust.
4041
4042 2018-04-06  Tom Tromey  <tom@tromey.com>
4043
4044         * value.c (~value): Update.
4045         (struct value) <contents>: Now unique_xmalloc_ptr.
4046         (value_contents_bits_eq, allocate_value_contents)
4047         (value_contents_raw, value_contents_all_raw)
4048         (value_contents_for_printing, value_contents_for_printing_const)
4049         (set_value_enclosing_type): Update.
4050
4051 2018-04-06  Tom Tromey  <tom@tromey.com>
4052
4053         * value.c (range_s): Remove typedef, VEC.
4054         (struct range): Add operator<.
4055         (range_lessthan): Remove.
4056         (ranges_contain): Change type.
4057         (~value): Update.
4058         (struct value) <unavailable, optimized_out>: Now std::vector.
4059         (value_entirely_available)
4060         (value_entirely_covered_by_range_vector)
4061         (value_entirely_unavailable, value_entirely_optimized_out):
4062         Update.
4063         (insert_into_bit_range_vector): Change argument type.
4064         (find_first_range_overlap): Likewise.
4065         (struct ranges_and_idx, value_contents_bits_eq)
4066         (require_not_optimized_out, require_available): Update.
4067         (ranges_copy_adjusted): Change argument types.
4068         (value_optimized_out, value_copy, value_fetch_lazy): Update.
4069
4070 2018-04-06  Tom Tromey  <tom@tromey.com>
4071
4072         * value.c (~value): Update.
4073         (struct value) <parent>: Now a value_ref_ptr.
4074         (value_parent, set_value_parent, value_address, value_copy):
4075         Update.
4076
4077 2018-04-06  Tom Tromey  <tom@tromey.com>
4078
4079         * value.c (struct value): Add constructor, destructor, and member
4080         initializers.
4081         (allocate_value_lazy, value_decref): Update.
4082
4083 2018-04-06  Tom Tromey  <tom@tromey.com>
4084
4085         * value.c (struct value) <released, next>: Remove.
4086         (all_values): Now a std::vector.
4087         (allocate_value_lazy): Update.
4088         (value_next): Remove.
4089         (value_mark, value_free_to_mark, release_value)
4090         (value_release_to_mark): Update.
4091
4092 2018-04-06  Tom Tromey  <tom@tromey.com>
4093
4094         * value.h (fetch_subexp_value, value_release_to_mark): Update.
4095         (free_value_chain): Remove.
4096         * value.c (free_value_chain): Remove.
4097         (value_release_to_mark): Return a std::vector.
4098         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
4099         std::vector.
4100         (check_condition): Update.
4101         * eval.c (fetch_subexp_value): Change "val_chain" to a
4102         std::vector.
4103         * breakpoint.c (update_watchpoint): Update.
4104         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
4105
4106 2018-04-06  Tom Tromey  <tom@tromey.com>
4107
4108         * value.h (free_all_values): Remove.
4109         * value.c (free_all_values): Remove.
4110
4111 2018-04-06  Tom Tromey  <tom@tromey.com>
4112
4113         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
4114         (value_history_chain, value_history_count): Remove.
4115         (value_history): New global.
4116         (record_latest_value, access_value_history, show_values)
4117         (preserve_values): Update.
4118
4119 2018-04-06  Tom Tromey  <tom@tromey.com>
4120
4121         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
4122         * varobj.c (varobj_set_display_format, varobj_set_value)
4123         (install_default_visualizer, construct_visualizer)
4124         (install_new_value, ~varobj, varobj_get_value_type)
4125         (my_value_of_variable, varobj_editable_p): Update.
4126         * c-varobj.c (c_describe_child, c_value_of_variable)
4127         (cplus_number_of_children, cplus_describe_child): Update.
4128         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
4129         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
4130         (ada_value_of_variable, ada_value_is_changeable_p): Update.
4131
4132 2018-04-06  Tom Tromey  <tom@tromey.com>
4133
4134         * printcmd.c (last_examine_address): Change type to
4135         value_ref_ptr.
4136         (do_examine, x_command): Update.
4137
4138 2018-04-06  Tom Tromey  <tom@tromey.com>
4139
4140         * value.c (release_value): Update.
4141         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
4142         (struct bpstats) <val>: Now a value_ref_ptr.
4143         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
4144         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
4145         (~watchpoint, print_it_watchpoint, watch_command_1)
4146         (invalidate_bp_value_on_memory_change): Update.
4147
4148 2018-04-06  Tom Tromey  <tom@tromey.com>
4149
4150         * varobj.c (varobj_clear_saved_item)
4151         (update_dynamic_varobj_children, install_new_value, ~varobj):
4152         Update.
4153         * value.h (value_incref): Move declaration earlier.
4154         (value_decref): Rename from value_free.
4155         (struct value_ref_policy): New.
4156         (value_ref_ptr): New typedef.
4157         (struct value_deleter): Remove.
4158         (gdb_value_up): Remove typedef.
4159         (release_value): Change return type.
4160         (release_value_or_incref): Remove.
4161         * value.c (set_value_parent): Update.
4162         (value_incref): Change return type.
4163         (value_decref): Rename from value_free.
4164         (value_free_to_mark, free_all_values, free_value_chain): Update.
4165         (release_value): Return value_ref_ptr.
4166         (release_value_or_incref): Remove.
4167         (record_latest_value, set_internalvar, clear_internalvar):
4168         Update.
4169         * stack.c (info_frame_command): Don't call value_free.
4170         * python/py-value.c (valpy_dealloc, valpy_new)
4171         (value_to_value_object): Update.
4172         * printcmd.c (do_examine): Update.
4173         * opencl-lang.c (lval_func_free_closure): Update.
4174         * mi/mi-main.c (register_changed_p): Don't call value_free.
4175         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
4176         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
4177         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
4178         value_free.
4179         * guile/scm-value.c (vlscm_free_value_smob)
4180         (vlscm_scm_from_value): Update.
4181         * frame.c (frame_register_unwind, frame_unwind_register_signed)
4182         (frame_unwind_register_unsigned, get_frame_register_bytes)
4183         (put_frame_register_bytes): Don't call value_free.
4184         * findvar.c (address_from_register): Don't call value_free.
4185         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
4186         * dwarf2loc.c (entry_data_value_free_closure)
4187         (value_of_dwarf_reg_entry, free_pieced_value_closure)
4188         (dwarf2_evaluate_loc_desc_full): Update.
4189         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
4190         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
4191         (~watchpoint, watch_command_1)
4192         (invalidate_bp_value_on_memory_change): Update.
4193         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
4194
4195 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
4196
4197         PR gdb/23022
4198         * warning.m4: Add -Wno-error=deprecated-register.
4199         * configure: Re-generate.
4200
4201 2018-04-05  Tom Tromey  <tom@tromey.com>
4202
4203         * linespec.h: Remove include of "vec.h".
4204
4205 2018-04-05  Tom Tromey  <tom@tromey.com>
4206
4207         * linespec.c (typep): Remove typedef.
4208         (find_methods, find_superclass_methods): Take a std::vector.
4209         (find_method): Use std::vector.
4210
4211 2018-04-05  Tom Tromey  <tom@tromey.com>
4212
4213         * utils.c (compare_strings): Remove.
4214         * utils.h (compare_strings): Remove.
4215         * objc-lang.h (find_imps): Update.
4216         * objc-lang.c (find_methods): Take a std::vector.
4217         (uniquify_strings, find_imps): Likewise.
4218         * linespec.c (find_methods): Take a std::vector.
4219         (decode_objc): Use std::vector.
4220         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
4221         a std::vector.
4222         (find_method, find_function_symbols): Use std::vector.
4223
4224 2018-04-05  Tom Tromey  <tom@tromey.com>
4225
4226         * completer.c (completion_tracker::completion_tracker): Remove
4227         cast.
4228         (completion_tracker::discard_completions): Likewise.
4229         * breakpoint.c (ambiguous_names_p): Remove cast.
4230         * ada-lang.c (_initialize_ada_language): Remove cast.
4231         * utils.h (streq): Update.
4232         (streq_hash): Add new declaration.
4233         * utils.c (streq): Return bool.
4234         (streq_hash): New function.
4235
4236 2018-04-05  Tom Tromey  <tom@tromey.com>
4237
4238         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
4239         Remove a string copy.
4240
4241 2018-04-05  Tom Tromey  <tom@tromey.com>
4242
4243         * linespec.c (filter_results): Use std::vector.
4244         (decode_line_2, decode_line_full): Update.
4245
4246 2018-04-05  Tom Tromey  <tom@tromey.com>
4247
4248         * linespec.c (canonical_to_fullform): Return std::string.
4249         (filter_results): Update.
4250         (struct decode_line_2_item): Add constructor.
4251         <fullform, displayform>: Now std::string.
4252         (decode_line_2_compare_items): Now a std::sort comparator.
4253         (decode_line_2): Update.
4254
4255 2018-04-05  Tom Tromey  <tom@tromey.com>
4256
4257         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
4258         (unexpected_linespec_error): Update.
4259         (linespec_parse_basic, parse_linespec): Update.
4260
4261 2018-04-05  Tom Tromey  <tom@tromey.com>
4262
4263         * linespec.c (linespec_parse_basic): Reindent.
4264
4265 2018-04-05  Tom Tromey  <tom@tromey.com>
4266
4267         * minsyms.h (iterate_over_minimal_symbols): Update.
4268         * minsyms.c (iterate_over_minimal_symbols): Take a
4269         gdb::function_view.
4270         * linespec.c (struct collect_minsyms): Remove.
4271         (compare_msyms): Now a std::sort comparator.
4272         (add_minsym): Add parameters.
4273         (search_minsyms_for_name): Update.  Use std::vector.
4274
4275 2018-04-03  Tom Tromey  <tom@tromey.com>
4276
4277         * mipsread.c (read_alphacoff_dynamic_symtab): Use
4278         gdb::byte_vector.
4279
4280 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
4281
4282         * MAINTAINERS (Write After Approval): Add Weimin Pan.
4283
4284 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
4285
4286         PR gdb/16959
4287         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when 
4288         printing static type.
4289
4290 2018-04-01  Tom Tromey  <tom@tromey.com>
4291
4292         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
4293         (rs6000_xfer_shared_libraries): Update.
4294
4295 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
4296
4297         * common/gdb_vecs.h (char_ptr): Remove.
4298         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
4299
4300 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4301
4302         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
4303         with std::vector.
4304         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
4305
4306 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4307
4308         * tracepoint.h (struct uploaded_tp): Initialize fields.
4309         <actions, step_actions, cmd_strings>: Change type to
4310         std::vector<char *>.
4311         * tracepoint.c (get_uploaded_tp): Allocate with new.
4312         (free_uploaded_tps): Free with delete.
4313         (parse_tracepoint_definition): Adjust to std::vector change.
4314         * breakpoint.c (read_uploaded_action): Likewise.
4315         (create_tracepoint_from_upload): Likewise.
4316         * ctf.c (ctf_write_uploaded_tp): Likewise.
4317         (SET_ARRAY_FIELD): Likewise.
4318         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
4319
4320 2018-03-30  Tom Tromey  <tom@tromey.com>
4321
4322         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
4323         std::unique_ptr.
4324         (svr4_keep_data_in_core): Update.
4325         (svr4_read_so_list): Update.
4326
4327 2018-03-30  Tom Tromey  <tom@tromey.com>
4328
4329         * windows-nat.c (handle_output_debug_string, handle_exception):
4330         Update.
4331         * target.h (target_read_string): Update.
4332         * target.c (target_read_string): Change "string" to
4333         unique_xmalloc_ptr.
4334         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
4335         Update.
4336         * solib-frv.c (frv_current_sos): Update.
4337         * solib-dsbt.c (dsbt_current_sos): Update.
4338         * solib-darwin.c (darwin_current_sos): Update.
4339         * linux-thread-db.c (inferior_has_bug): Update.
4340         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
4341         Update.  Remove alloca.
4342         * ada-lang.c (ada_main_name): Update.
4343
4344 2018-03-30  Tom Tromey  <tom@tromey.com>
4345
4346         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
4347         (struct dwo_file_deleter): New.
4348         (dwo_file_up): New typedef.
4349         (open_and_init_dwo_file): Use dwo_file_up.
4350         (free_dwo_file_cleanup): Remove.
4351
4352 2018-03-30  Tom Tromey  <tom@tromey.com>
4353
4354         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
4355         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
4356
4357 2018-03-30  Tom Tromey  <tom@tromey.com>
4358
4359         * dwarf2read.c (class free_cached_comp_units): New class.
4360         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
4361         (free_cached_comp_units): Remove function.
4362
4363 2018-03-30  Tom Tromey  <tom@tromey.com>
4364
4365         * utils.h (make_cleanup_unpush_target): Remove.
4366         * inf-ptrace.c (struct target_unpusher): New.
4367         (target_unpush_up) New typedef.
4368         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
4369         target_unpush_up.
4370         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
4371
4372 2018-03-27  Tom Tromey  <tom@tromey.com>
4373
4374         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
4375
4376 2018-03-27  Pedro Alves  <palves@redhat.com>
4377             Tom Tromey  <tom@tromey.com>
4378
4379         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
4380         destructor.  Now a class.
4381         (gdb_readline_wrapper_cleanup): Remove function.
4382         (gdb_readline_wrapper): Remove cleanups.
4383
4384 2018-03-27  Tom Tromey  <tom@tromey.com>
4385
4386         * typeprint.h (struct type_print_options) <local_typedefs,
4387         global_typedefs>: Remove "struct" keyword.
4388         (class typedef_hash_table): New class.
4389         (recursively_update_typedef_hash, add_template_parameters)
4390         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
4391         (find_typedef_in_hash): Don't declare.
4392         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
4393         (typedef_hash_table::recursively_update): Rename from
4394         recursively_update_typedef_hash.  Now a member.
4395         (typedef_hash_table::add_template_parameters): Rename from
4396         add_template_parameters.  Now a member.
4397         (typedef_hash_table::typedef_hash_table): Now a constructor;
4398         rename from create_typedef_hash.
4399         (typedef_hash_table::~typedef_hash_table): Now a destructor;
4400         rename from free_typedef_hash.
4401         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
4402         (do_free_global_table): Remove.
4403         (typedef_hash_table::typedef_hash_table): New constructor; renamed
4404         from copy_type_recursive.
4405         (create_global_typedef_table): Remove.
4406         (typedef_hash_table::find_global_typedef): Now a member of
4407         typedef_hash_table.
4408         (typedef_hash_table::find_typedef): Rename from
4409         find_typedef_in_hash; now a member.
4410         (whatis_exp): Update.
4411         * extension.h (struct ext_lang_type_printers): Add constructor and
4412         destructor.
4413         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
4414         declare.
4415         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
4416         Now a constructor; rename from start_ext_lang_type_printers.
4417         (ext_lang_type_printers): Now a destructor; rename from
4418         free_ext_lang_type_printers.
4419         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
4420         Update.
4421         (c_type_print_base_struct_union): Update.  Remove cleanups.
4422
4423 2018-03-27  Tom Tromey  <tom@tromey.com>
4424
4425         * dwarf-index-write.c: Include <cmath>.
4426
4427 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4428
4429         * NEWS: Add entry describing new "set|show varsize-limit" command.
4430         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
4431         command.
4432         * printcmd.c (_initialize_printcmd): Add "set var" alias of
4433         "set variable".
4434
4435 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
4436
4437         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
4438         dwarf-index-write.c
4439         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
4440         * dwarf-index-common.c: New file.
4441         * dwarf-index-common.h: New file.
4442         * dwarf-index-write.c: New file.
4443         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
4444         (struct dwarf2_section_info): Move from here.
4445         (dwarf2_section_info_def): Likewise.
4446         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
4447         (offset_type): Likewise.
4448         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
4449         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
4450         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
4451         (byte_swap): Likewise.
4452         (MAYBE_SWAP): Likewise.
4453         (dwarf2_per_cu_ptr): Likewise.
4454         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
4455         (struct tu_stats): Likewise.
4456         (struct dwarf2_per_objfile): Likewise.
4457         (struct dwarf2_per_cu_data): Likewise.
4458         (struct signatured_type): Likewise.
4459         (sig_type_ptr): Likewise.
4460         (DEF_VEC_P (sig_type_ptr)): Likewise.
4461         (INDEX4_SUFFIX): Likewise.
4462         (INDEX5_SUFFIX): Likewise.
4463         (DEBUG_STR_SUFFIX): Likewise.
4464         (dwarf2_read_section): Make non-static.
4465         (mapped_index_string_hash): Move from here.
4466         (dwarf5_djb_hash): Likewise.
4467         (file_write): Likewise.
4468         (class data_buf): Likewise.
4469         (struct symtab_index_entry): Likewise.
4470         (struct mapped_symtab): Likewise.
4471         (find_slot): Likewise.
4472         (hash_expand): Likewise.
4473         (add_index_entry): Likewise.
4474         (uniquify_cu_indices): Likewise.
4475         (class c_str_view): Likewise.
4476         (class c_str_view_hasher): Likewise.
4477         (class vector_hasher): Likewise.
4478         (write_hash_table): Likewise.
4479         (psym_index_map): Likewise.
4480         (struct addrmap_index_data): Likewise.
4481         (add_address_entry): Likewise.
4482         (add_address_entry_worker): Likewise.
4483         (write_address_map): Likewise.
4484         (symbol_kind): Likewise.
4485         (write_psymbols): Likewise.
4486         (struct signatured_type_index_data): Likewise.
4487         (write_one_signatured_type): Likewise.
4488         (recursively_count_psymbols): Likewise.
4489         (recursively_write_psymbols): Likewise.
4490         (class debug_names): Likewise.
4491         (check_dwarf64_offsets): Likewise.
4492         (psyms_seen_size): Likewise.
4493         (write_gdbindex): Likewise.
4494         (write_debug_names): Likewise.
4495         (assert_file_size): Likewise.
4496         (write_psymtabs_to_index): Likewise.
4497         (save_gdb_index_command): Likewise.
4498         (_initialize_dwarf2_read): Don't register the "save gdb-index"
4499         command.
4500         * dwarf2read.h: New file.
4501
4502 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4503
4504         PR gdb/22670
4505         * dwarf2read.c (dwarf2_physname): Do not return the demangled
4506         symbol name if the CU's language stores symbol names in linkage
4507         format.
4508         * language.h (struct language_defn)
4509         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
4510         all instances of this struct.
4511
4512 2018-03-26  Tom Tromey  <tom@tromey.com>
4513
4514         * stack.c (backtrace_command_1): Remove verbose code.
4515
4516 2018-03-26  Tom Tromey  <tom@tromey.com>
4517
4518         * python/py-framefilter.c (py_print_type): Don't catch
4519         exceptions.  Return void.
4520         (py_print_value): Likewise.
4521         (py_print_single_arg): Likewise.
4522         (enumerate_args): Don't catch exceptions.
4523         (py_print_args): Likewise.
4524         (py_print_frame): Likewise.
4525         (gdbpy_apply_frame_filter): Catch exceptions here.
4526
4527 2018-03-26  Tom Tromey  <tom@tromey.com>
4528
4529         * stack.c (_initialize_stack): Remove trailing newlines from help
4530         text.  Add "Usage" line to "backtrace" help.
4531
4532 2018-03-26  Tom Tromey  <tom@tromey.com>
4533
4534         PR python/16486:
4535         * python/py-framefilter.c (py_print_args): Call wrap_hint.
4536
4537 2018-03-26  Tom Tromey  <tom@tromey.com>
4538
4539         * python/py-framefilter.c (py_print_single_arg): Return
4540         EXT_LANG_BT_ERROR from catch.
4541
4542 2018-03-26  Tom Tromey  <tom@tromey.com>
4543
4544         PR backtrace/15584:
4545         * stack.c (backtrace_command_1): Move some code into no-filters
4546         "if".
4547
4548 2018-03-26  Tom Tromey  <tom@tromey.com>
4549
4550         * python/py-framefilter.c (throw_quit_or_print_exception): New
4551         function.
4552         (gdbpy_apply_frame_filter): Use it.
4553
4554 2018-03-26  Tom Tromey  <tom@tromey.com>
4555
4556         PR cli/17716:
4557         * python/py-framefilter.c (py_print_type, py_print_value)
4558         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
4559         RETURN_MASK_ERROR.
4560
4561 2018-03-26  Tom Tromey  <tom@tromey.com>
4562
4563         * python/py-framefilter.c (enumerate_args): Use
4564         gdb::unique_xmalloc_ptr.
4565
4566 2018-03-26  Tom Tromey  <tom@tromey.com>
4567
4568         * python/py-framefilter.c (py_print_frame): Return
4569         EXT_LANG_BT_OK.
4570         (gdbpy_apply_frame_filter): Update comment.
4571         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
4572         Remove.
4573         <EXT_LANG_BT_NO_FILTERS>: Change value.
4574
4575 2018-03-26  Tom Tromey  <tom@tromey.com>
4576
4577         PR backtrace/15582:
4578         * stack.c (backtrace_command): Parse "hide" argument.
4579         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
4580         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
4581         constant.
4582
4583 2018-03-26  Tom Tromey  <tom@tromey.com>
4584
4585         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
4586         add "flags".
4587         (backtrace_command): Remove "fulltrace", add "flags".
4588
4589 2018-03-26  Tom Tromey  <tom@tromey.com>
4590
4591         * stack.c (backtrace_command): Rewrite command line parsing.
4592
4593 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4594
4595         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
4596
4597 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4598
4599         * filename-seen-cache.h: Add include guard.
4600
4601 2018-03-26  Keith Seitz  <keiths@redhat.com>
4602
4603         * symfile.c (place_section): Remove "struct" from section_addr_info
4604         in comment.
4605         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
4606         "struct" keyword from section_addr_info.
4607
4608 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
4609
4610         * regformats/regdef.h (reg): Add constructors.
4611
4612 2018-03-25  Pedro Alves  <palves@redhat.com>
4613
4614         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
4615         if then/else bodies in var_func_name extraction.
4616
4617 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
4618
4619         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
4620         lookup_minimal_symbol() to find symbol entry.
4621         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
4622
4623 2018-03-23  Keith Seitz  <keiths@redhat.com>
4624
4625         PR c++/22968
4626         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
4627         nested type definitions for C++, too.
4628
4629 2018-03-23  Tom Tromey  <tom@tromey.com>
4630
4631         * machoread.c (struct oso_el): Add a constructor.  Don't define as
4632         a typedef.
4633         (macho_register_oso): Remove.
4634         (macho_symtab_read): Take a std::vector.
4635         (oso_el_compare_name): Now a std::sort comparator.
4636         (macho_symfile_read_all_oso): Take a std::vector.
4637         (macho_symfile_read): Use std::vector.  Remove cleanups.
4638
4639 2018-03-22  Tom Tromey  <tom@tromey.com>
4640
4641         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
4642         (record_full_goto_bookmark): Use std::string.
4643
4644 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4645
4646         PR tdep/18295
4647         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
4648         a single mask.
4649
4650 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4651
4652         * rs6000-tdep.c (store_insn_p): New function.
4653         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
4654         and cr_reg to their unshifted values. Use store_insn_p to
4655         match LR saves using either R1 or fdata->alloca_reg. Use
4656         store_insn_p to match CR saves. Set alloca_reg_offset
4657         when alloca_reg and framep are set. Remove lr_reg shift
4658         when assigning to fdata->lr_register.
4659
4660 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4661
4662         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
4663         command line args instead of emitting a warning.
4664
4665 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4666
4667         * tracepoint.h (struct static_tracepoint_marker): Initialize
4668         fields, define default constructor, move constructor and move
4669         assignment, disable the rest.
4670         <str_id, extra>: Make std::string.
4671         (release_static_tracepoint_marker): Remove.
4672         (free_current_marker): Remove.
4673         * tracepoint.c (free_current_marker): Remove.
4674         (parse_static_tracepoint_marker_definition): Adjust to
4675         std::string, use new hex2str overload.
4676         (release_static_tracepoint_marker): Remove.
4677         (print_one_static_tracepoint_marker): Get marker by reference
4678         and adjust to std::string.
4679         (info_static_tracepoint_markers_command): Adjust to std::vector
4680         changes
4681         * target.h (static_tracepoint_marker_p): Remove typedef.
4682         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
4683         (struct target_ops) <to_static_tracepoint_marker_at>: Return
4684         bool.
4685         <to_static_tracepoint_markers_by_strid>: Return std::vector.
4686         * target-debug.h
4687         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
4688         (target_debug_print_std_vector_static_tracepoint_marker): New.
4689         (target_debug_print_struct_static_tracepoint_marker_p): Rename
4690         to...
4691         (target_debug_print_static_tracepoint_marker_p): ... this.
4692         * target-delegates.c: Re-generate.
4693         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
4694         Make std::string.
4695         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
4696         (decode_static_tracepoint_spec): Adjust to std::vector.
4697         (tracepoint_print_one_detail): Adjust to std::string.
4698         (strace_marker_decode_location): Adjust to std::string.
4699         (update_static_tracepoint): Adjust to std::string, remove call
4700         to release_static_tracepoint_marker.
4701         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
4702         Adjust to std::vector.
4703         * remote.c (remote_static_tracepoint_marker_at): Return bool.
4704         (remote_static_tracepoint_markers_by_strid): Adjust to
4705         std::vector.
4706         * common/rsp-low.h (hex2str): New overload with explicit count
4707         of bytes.
4708         * common/rsp-low.c (hex2str): New overload with explicit count
4709         of bytes.
4710         * unittests/rsp-low-selftests.c (test_hex2str): New function.
4711         (_initialize_rsp_low_selftests): Add test_hex2str test.
4712         * unittests/tracepoint-selftests.c
4713         (test_parse_static_tracepoint_marker_definition): Adjust to
4714         std::string.
4715
4716 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4717
4718         * tracepoint.c (parse_static_tracepoint_marker_definition):
4719         Consider case where the definition is followed by more
4720         definitions.
4721         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4722         tracepoint-selftests.c.
4723         * unittests/tracepoint-selftests.c: New.
4724
4725 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4726
4727         * MAINTAINERS (Write After Approval): Add Pedro Franco de
4728         Carvalho.
4729
4730 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4731
4732         * symtab.c (find_pc_sect_line): fixed indentation.
4733
4734 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4735
4736         * symtab.c (find_pc_sect_line): now uses binary search.
4737
4738 2018-03-19  Tom Tromey  <tom@tromey.com>
4739
4740         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
4741         "IDENT" production.
4742
4743 2018-03-19  Pedro Alves  <palves@redhat.com>
4744             Tom Tromey  <tom@tromey.com>
4745
4746         * unittests/observable-selftests.c: New file.
4747         * common/observable.h: New file.
4748         * observable.h: New file.
4749         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
4750         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
4751         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
4752         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
4753         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
4754         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
4755         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
4756         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
4757         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
4758         python/py-breakpoint.c, python/py-finishbreakpoint.c,
4759         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
4760         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
4761         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
4762         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
4763         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
4764         tui/tui-interp.c, valops.c: Update all users.
4765         * tui/tui-hooks.c (tui_bp_created_observer)
4766         (tui_bp_deleted_observer, tui_bp_modified_observer)
4767         (tui_inferior_exit_observer, tui_before_prompt_observer)
4768         (tui_normal_stop_observer, tui_register_changed_observer):
4769         Remove.
4770         (tui_observers_token): New global.
4771         (attach_or_detach, tui_attach_detach_observers): New functions.
4772         (tui_install_hooks, tui_remove_hooks): Use
4773         tui_attach_detach_observers.
4774         * record-btrace.c (record_btrace_thread_observer): Remove.
4775         (record_btrace_thread_observer_token): New global.
4776         * observer.sh: Remove.
4777         * observer.c: Rename to observable.c.
4778         * observable.c (namespace gdb_observers): Define new objects.
4779         (observer_debug): Move into gdb_observers namespace.
4780         (struct observer, struct observer_list, xalloc_observer_list_node)
4781         (xfree_observer_list_node, generic_observer_attach)
4782         (generic_observer_detach, generic_observer_notify): Remove.
4783         (_initialize_observer): Update.
4784         Don't include observer.inc.
4785         * Makefile.in (generated_files): Remove observer.h, observer.inc.
4786         (clean mostlyclean): Likewise.
4787         (observer.h, observer.inc): Remove targets.
4788         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
4789         (COMMON_SFILES): Use observable.c, not observer.c.
4790         * .gitignore: Remove observer.h.
4791
4792 2018-03-18  Tom Tromey  <tom@tromey.com>
4793
4794         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
4795         gdb::def_vector.
4796         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
4797
4798 2018-03-17  Tom Tromey  <tom@tromey.com>
4799
4800         * auto-load.c (auto_load_objfile_script_1): Use std::string.
4801
4802 2018-03-17  Tom Tromey  <tom@tromey.com>
4803
4804         * target.c (class scoped_target_fd): New.
4805         (target_fileio_close_cleanup): Remove.
4806         (target_fileio_read_alloc_1): Use scoped_target_fd.
4807
4808 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
4809
4810         * silent-rules.mk: New.
4811         * Makefile.in: Include silent-rules.mk
4812         (srcdir, VPATH, top_srcdir): Move up.
4813         (COMPILE): Add ECHO_CXX.
4814         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
4815         (init.c): Add ECHO_INIT_C.
4816         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
4817         (version.c): Add ECHO_GEN.
4818         (printcmd.o): Add ECHO_CXX.
4819         (target-float.o): Add ECHO_CXX.
4820         (ada-exp.o): Add ECHO_CXX.
4821         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
4822         (insight$(EXEEXT)): Add ECHO_CXXLD.
4823         * gnulib/configure.ac: Add AM_SILENT_RULES.
4824         * gnulib/aclocal.m4: Re-generate.
4825         * gnulib/configure: Re-generate.
4826         * gnulib/import/Makefile.in: Re-generate.
4827
4828 2018-03-16  Tom Tromey  <tom@tromey.com>
4829
4830         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
4831         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
4832         * utils.c (do_free_section_addr_info)
4833         (make_cleanup_free_section_addr_info): Remove.
4834         * symfile.h (struct other_sections): Add constructor.
4835         (struct section_addr_info): Remove.
4836         (section_addr_info): New typedef.
4837         (struct sym_fns) <sym_offsets>: Change type of parameter.
4838         (build_section_addr_info_from_objfile)
4839         (relative_addr_info_to_section_offsets, addr_info_make_relative)
4840         (default_symfile_offsets, symbol_file_add)
4841         (symbol_file_add_from_bfd)
4842         (build_section_addr_info_from_section_table): Update.
4843         (alloc_section_addr_info, free_section_addr_info): Don't declare.
4844         * symfile.c (alloc_section_addr_info): Remove.
4845         (build_section_addr_info_from_section_table): Change return type.
4846         Update.
4847         (build_section_addr_info_from_bfd)
4848         (build_section_addr_info_from_objfile): Likewise.
4849         (free_section_addr_info): Remove.
4850         (relative_addr_info_to_section_offsets): Change type of "addrs".
4851         (addrs_section_compar): Now a std::sort comparator.
4852         (addrs_section_sort): Change return type.
4853         (addr_info_make_relative): Change type of "addrs".  Update.
4854         (default_symfile_offsets, syms_from_objfile_1)
4855         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
4856         (symbol_file_add_separate): Update.
4857         (symbol_file_add): Change type of "addrs".  Update.
4858         (add_symbol_file_command): Update.  Remove cleanups.
4859         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
4860         cleanups.
4861         * symfile-debug.c (debug_sym_offsets): Change type of "info".
4862         * solib.c (solib_read_symbols): Update.
4863         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
4864         * machoread.c (macho_symfile_offsets): Update.
4865         * jit.c (jit_bfd_try_read_symtab): Update.
4866
4867 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
4868
4869         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4870         unittests/utils-selftests.c.
4871         * unittests/utils-selftests.c: New file.
4872
4873 2018-03-14  Tom Tromey  <tom@tromey.com>
4874
4875         PR cli/14977:
4876         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
4877         for NULL.
4878
4879 2018-03-14  Tom Tromey  <tom@tromey.com>
4880
4881         PR cli/19918:
4882         * printcmd.c (printf_pointer): Allow "-" in format.
4883
4884 2018-03-14  Tom Tromey  <tom@tromey.com>
4885
4886         * printcmd.c (_initialize_printcmd): Add usage to printf.
4887
4888 2018-03-14  Yao Qi  <qiyao@sourceware.org>
4889
4890         * MAINTAINERS: Update my email address.
4891
4892 2018-03-13  Tom Tromey  <tom@tromey.com>
4893
4894         * machoread.c (macho_check_dsym): Change filenamep to a
4895         std::string*.
4896         (macho_symfile_read): Update.
4897         * symfile.c (load_command): Use std::string.
4898
4899 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4900
4901         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
4902         to error message string.
4903         (riscv_register_name): Use xsnprintf instead of sprintf.
4904         (riscv_insn::fetch_instruction): Use gdb_assert instead of
4905         internal_error.
4906         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
4907         error.
4908         (riscv_push_dummy_call): Likewise.
4909
4910 2018-03-12  Tom Tromey  <tom@tromey.com>
4911
4912         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
4913         Use gdb::byte_vector.
4914         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
4915
4916 2018-03-12  Yao Qi  <yao.qi@linaro.org>
4917
4918         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
4919         parameter type to readable_regcache.
4920         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
4921         the declaration.
4922
4923 2018-03-11  Tom Tromey  <tom@tromey.com>
4924
4925         * dwarf2read.c (struct nextfield): Add initializers.
4926         (struct nextfnfield): Remove.
4927         (struct fnfieldlist): Add initializers.  Remove "length" and
4928         "head", use std::vector.
4929         (struct decl_field_list): Remove.
4930         (struct field_info): Add initializers.
4931         <fields, baseclasses>: Now std::vector.
4932         <nbaseclasses, nfnfields, typedef_field_list_count,
4933         nested_types_list_count>: Remove.
4934         (dwarf2_add_field, dwarf2_add_type_defn)
4935         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
4936         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
4937         (process_structure_scope): Update.
4938
4939 2018-03-11  Tom Tromey  <tom@tromey.com>
4940
4941         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
4942         for use by std::sort.
4943         (build_type_psymtabs_1): Use std::vector.
4944
4945 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
4946
4947         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
4948         and LIBMPFR in the printed configuration.
4949
4950 2018-03-08  Tom Tromey  <tom@tromey.com>
4951
4952         * source.c (get_filename_and_charpos): Use scoped_fd.
4953         * nto-procfs.c (procfs_open_1): Use scoped_fd.
4954         (procfs_pidlist): Likewise.
4955         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
4956         (iterate_over_mappings): Likewise.
4957
4958 2018-03-08  Tom Tromey  <tom@tromey.com>
4959
4960         * infcall.c (struct call_return_meta_info)
4961         <stack_temporaries_enabled>: Remove.
4962         (get_call_return_value, call_function_by_hand_dummy): Update.
4963         * thread.c (disable_thread_stack_temporaries): Remove.
4964         (enable_thread_stack_temporaries): Remove.
4965         (thread_stack_temporaries_enabled_p): Return bool.
4966         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
4967         (get_last_thread_stack_temporary): Update.
4968         * eval.c (evaluate_subexp): Update.
4969         * gdbthread.h (class enable_thread_stack_temporaries): Now a
4970         class, not a function.
4971         (value_ptr, value_vec): Remove typedefs.
4972         (class thread_info) <stack_temporaries_enabled>: Now bool.
4973         <stack_temporaries>: Now a std::vector.
4974         (thread_stack_temporaries_enabled_p)
4975         (value_in_thread_stack_temporaries): Return bool.
4976
4977 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
4978
4979         * remote.c (putpkt_binary): Fix omitted bytes reporting.
4980         (getpkt_or_notif_sane_1): Likewise.
4981
4982 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4983
4984         * build-id.c (build_id_to_debug_bfd): Use std::string.
4985
4986 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4987
4988         * build-id.c (find_separate_debug_file_by_buildid): Return
4989         std::string.
4990         * build-id.h (find_separate_debug_file_by_buildid): Return
4991         std::string.
4992         * coffread.c (coff_symfile_read): Adjust to std::string.
4993         * elfread.c (elf_symfile_read): Adjust to std::string.
4994         * symfile.c (separate_debug_file_exists): Change parameter to
4995         std::string.
4996         (find_separate_debug_file): Return std::string.
4997         (find_separate_debug_file_by_debuglink): Return std::string.
4998         * symfile.h (find_separate_debug_file_by_debuglink): Return
4999         std::string.
5000
5001 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
5002
5003         * common/xml-utils.c (xml_escape_text): Move code to...
5004         (xml_escape_text_append): ... this new function.
5005         * common/xml-utils.h (xml_escape_text_append): New declaration.
5006         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
5007         New function.
5008         (_initialize_xml_utils): register test_xml_escape_text_append as
5009         a selftest.
5010
5011 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
5012
5013         * defs.h: Remove MAX_REGISTER_SIZE.
5014         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
5015         asserts.
5016         * python/py-unwind.c (pyuw_sniffer): Likewise.
5017
5018 2018-03-07  Tom Tromey  <tom@tromey.com>
5019
5020         * linux-tdep.c (linux_info_proc): Update.
5021         * target.h (struct target_ops) <to_fileio_readlink>: Return
5022         optional<string>.
5023         (target_fileio_readlink): Return optional<string>.
5024         * remote.c (remote_hostio_readlink): Return optional<string>.
5025         * inf-child.c (inf_child_fileio_readlink): Return
5026         optional<string>.
5027         * target.c (target_fileio_readlink): Return optional<string>.
5028
5029 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5030
5031         * regcache.c (cooked_read_test): Add riscv to the list of
5032         architectures that have a save_reggroup.
5033
5034 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
5035
5036         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
5037         value is not a dynamic class object.
5038
5039 2018-03-06  Tom Tromey  <tom@tromey.com>
5040
5041         * rust-exp.y: Formatting fixes.
5042
5043 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5044
5045         * riscv-tdep.c (riscv_register_name): Remove target description
5046         support.
5047         (riscv_gdbarch_init): Remove target description check.
5048
5049 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5050
5051         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
5052         comment.
5053         * riscv-tdep.h: Likewise.
5054
5055 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5056
5057         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
5058         (riscv_pseudo_register_write): Delete.
5059         (riscv_gdbarch_init): Remove all use of pseudo registers.
5060
5061 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5062
5063         * record-btrace.c (btrace_print_lines): Replace cleanup
5064         parameter with RAII equivalents.
5065         (btrace_insn_history): Replace cleanup with RAII equivalents.
5066         * ui-out.h (make_cleanup_ui_out_list_begin_end,
5067         make_cleanup_ui_out_tuple_begin_end): Remove.
5068         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
5069         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
5070         make_cleanup_ui_out_list_begin_end): Remove.
5071
5072 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5073
5074         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
5075         parameter types to std::vector.  Use bool.
5076         (record_btrace_wait): Replace VEC(tp_t) with
5077         std::vector<thread_info *>.
5078         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
5079
5080 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5081
5082         * record-btrace.c (record_btrace_disable_callback): Remove.
5083         (struct scoped_btrace_disable): New.
5084         (record_btrace_open): Use scoped_btrace_disable.
5085
5086 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5087
5088         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
5089         reading values from registers.
5090
5091 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5092
5093         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
5094         where appropriate.
5095
5096 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5097
5098         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
5099         change parameter type.  Use GDB's print functions, and use
5100         core_addr_to_string where appropriate.
5101         (riscv_push_dummy_call): Use core_addr_to_string where
5102         appropriate, update call to riscv_print_arg_location, and reindent
5103         a few lines.
5104         (riscv_return_value): Update call to riscv_print_arg_location.
5105
5106 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5107             Tim Newsome <tim@sifive.com>
5108             Albert Ou <a0u@eecs.berkeley.edu>
5109             Darius Rad <darius@bluespec.com>
5110
5111         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
5112         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
5113         (ALLDEPFILES): Add riscv-tdep.c
5114         * configure.tgt: Add riscv support.
5115         * riscv-tdep.c: New file.
5116         * riscv-tdep.h: New file.
5117         * NEWS: Mention new target.
5118         * MAINTAINERS: Add entry for riscv.
5119
5120 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5121
5122         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
5123         fields within aggregates.
5124
5125 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
5126
5127         * record-btrace.c (btrace_print_lines): Change type of flags to
5128         gdb_disassembly_flags.
5129
5130 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5131
5132         * fbsd-nat.c: Include "inf-ptrace.h".
5133         (USE_SIGTRAP_SIGINFO): Conditionally define.
5134         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
5135         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
5136         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
5137         function.
5138         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
5139         Likewise.
5140         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
5141         Likewise.
5142         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
5143         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
5144         "supports_stopped_by_hw_breakpoint" target methods.
5145
5146 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5147
5148         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
5149         * fbsd-nat.c (debug_fbsd_nat): New variable.
5150         (show_fbsd_nat_debug): New function.
5151         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
5152         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
5153
5154 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5155
5156         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
5157         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
5158         prototype.
5159         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
5160         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
5161         method.
5162
5163 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5164
5165         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
5166         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
5167
5168 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5169
5170         * charset.c (struct charset_vector): New.
5171         (charsets): Change type to charset_vector.
5172         (find_charset_names): Adjust.
5173         (add_one): Adjust.
5174         (_initialize_charset): Adjust.
5175
5176 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5177
5178         * progspace.h (struct program_space) <deleted_solibs>: Change
5179         type to std::vector<std::string>.
5180         * progspace.c (clear_program_space_solib_cache): Adjust.
5181         * breakpoint.c (print_solib_event): Adjust.
5182         (check_status_catch_solib): Adjust.
5183         * solib.c (update_solib_list): Adjust.
5184         * ui-out.h (class ui_out) <field_string>: New overload.
5185         * ui-out.c (ui_out::field_string): New overload.
5186
5187 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5188
5189         * progspace.h (struct program_space): Add constructor and
5190         destructor, initialize fields.
5191         (add_program_space): Remove.
5192         * progspace.c (add_program_space): Rename to...
5193         (program_space::program_space): ... this.
5194         (release_program_space): Rename to...
5195         (program_space::~program_space): ... this.
5196         (delete_program_space): Use delete to delete program_space.
5197         (initialize_progspace): Use new to allocate program_space.
5198         * inferior.c (add_inferior_with_spaces): Likewise.
5199         (clone_inferior_command): Likewise.
5200         * infrun.c (follow_fork_inferior): Likewise.
5201         (handle_vfork_child_exec_or_exit): Likewise.
5202
5203 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5204
5205         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
5206         (delim_string_to_char_ptr_vec): Return std::vector of
5207         gdb::unique_xmalloc_ptr.
5208         (dirnames_to_char_ptr_vec_append): Take std::vector of
5209         gdb::unique_xmalloc_ptr.
5210         (dirnames_to_char_ptr_vec): Return std::vector of
5211         gdb::unique_xmalloc_ptr.
5212         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
5213         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
5214         (delim_string_to_char_ptr_vec): Return an std::vector of
5215         gdb::unique_xmalloc_ptr, adjust the code.
5216         (dirnames_to_char_ptr_vec_append): Take an std::vector of
5217         gdb::unique_xmalloc_ptr, adjust the code.
5218         (dirnames_to_char_ptr_vec): Return an std::vector of
5219         gdb::unique_xmalloc_ptr, adjust the code.
5220         * auto-load.c (auto_load_safe_path_vec): Change type to
5221         std::vector of gdb::unique_xmalloc_ptr.
5222         (auto_load_expand_dir_vars): Return an std::vector of
5223         gdb::unique_xmalloc_ptr, adjust the code.
5224         (auto_load_safe_path_vec_update): Adjust.
5225         (filename_is_in_auto_load_safe_path_vec): Adjust.
5226         (auto_load_objfile_script_1): Adjust.
5227         * build-id.c (build_id_to_debug_bfd): Adjust.
5228         * linux-thread-db.c (thread_db_load_search): Adjust.
5229         * source.c (add_path): Adjust.
5230         (openp): Adjust.
5231         * symfile.c (find_separate_debug_file): Adjust.
5232         * utils.c (do_free_char_ptr_vec): Remove.
5233         (make_cleanup_free_char_ptr_vec): Remove.
5234
5235 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5236
5237         PR gdb/22907
5238         * common/pathstuff.c: Conditionally include "<windows.h>".
5239
5240 2018-03-01  Georg Sauthoff  <mail@georg.so>
5241
5242         PR gdb/22888
5243         * gcore.in: Quote variables and switch interpreter to bash.
5244
5245 2018-03-01  Tom Tromey  <tom@tromey.com>
5246
5247         * dwarf2read.c (alloc_discriminant_info): Fix default_index
5248         assertion.  Add assertion for discriminant_index.
5249         (quirk_rust_enum): Use correct base type name in univariant case.
5250
5251 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
5252
5253         * record.c (get_call_history_modifiers): Return a
5254         record_print_flags.
5255         (cmd_record_call_history): Adjust.
5256         * record-btrace.c (record_btrace_call_history): Adjust.
5257         (record_btrace_call_history_range): Adjust.
5258         (record_btrace_call_history_from): Adjust.
5259         * target-debug.h (target_debug_print_record_print_flags): New.
5260         * target-delegates.c: Re-generate.
5261         * target.c (target_call_history): Change flags type.
5262         (target_call_history_from): Likewise.
5263         (target_call_history_range): Likewise.
5264         * target.h (struct target_ops) <target_call_history>: Likewise.
5265         (target_call_history_from): Likewise.
5266         (target_call_history_range): Likewise.
5267
5268 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5269             Simon Marchi  <simon.marchi@polymtl.ca>
5270
5271         * common/common-utils.c: Include "sys/stat.h".
5272         (is_regular_file): Move here from "source.c"; change return
5273         type to "bool".
5274         * common/common-utils.h (is_regular_file): New prototype.
5275         * common/pathstuff.c (contains_dir_separator): New function.
5276         * common/pathstuff.h (contains_dir_separator): New prototype.
5277         * source.c: Don't include "sys/stat.h".
5278         (is_regular_file): Move to "common/common-utils.c".
5279
5280 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5281
5282         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
5283         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
5284         * auto-load.c: Include "common/pathstuff.h".
5285         * common/common-def.h (current_directory): Move here.
5286         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
5287         function.
5288         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
5289         prototype.
5290         * common/pathstuff.c: New file.
5291         * common/pathstuff.h: New file.
5292         * compile/compile.c: Include "common/pathstuff.h".
5293         * defs.h (current_directory): Move to "common/common-defs.h".
5294         * dwarf2read.c: Include "common/pathstuff.h".
5295         * exec.c: Likewise.
5296         * guile/scm-safe-call.c: Likewise.
5297         * linux-thread-db.c: Likewise.
5298         * main.c: Likewise.
5299         * nto-tdep.c: Likewise.
5300         * objfiles.c: Likewise.
5301         * source.c: Likewise.
5302         * symtab.c: Likewise.
5303         * utils.c: Include "common/pathstuff.h".
5304         (gdb_realpath): Move to "common/pathstuff.c".
5305         (gdb_realpath_keepfile): Likewise.
5306         (gdb_abspath): Likewise.
5307         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
5308         (gdb_realpath_keepfile): Likewise.
5309         (gdb_abspath): Likewise.
5310
5311 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
5312
5313         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
5314         wildcard process pid for super_resume for kernels with a
5315         specific bug.
5316
5317 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
5318
5319         * compile/compile.c (get_args): Add additional comments
5320         explaining function.
5321
5322 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
5323             Tom Tromey  <tom@tromey.com>
5324
5325         * target.h (memory_write_request_s): Remove typedef.  Don't define
5326         VEC.
5327         (target_write_memory_blocks): Change argument to std::vector.
5328         (struct memory_write_request): Add constructor.
5329         * target-memory.c (compare_block_starting_address): Return bool.
5330         Change argument types.
5331         (claim_memory): Change arguments to use std::vector.
5332         (split_regular_and_flash_blocks, blocks_to_erase)
5333         (compute_garbled_blocks): Likewise.
5334         (cleanup_request_data, cleanup_write_requests_vector): Remove.
5335         (target_write_memory_blocks): Change argument to std::vector.
5336         * symfile.c (struct load_section_data): Add constructor and
5337         destructor.  Use std::vector for "requests".
5338         (struct load_progress_data): Add initializers.
5339         (load_section_callback): Update.  Use "new".
5340         (clear_memory_write_data): Remove.
5341         (generic_load): Update.
5342
5343 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
5344
5345         * arch/aarch64.h: Use common/tdesc.h.
5346
5347 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5348
5349         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
5350         architecture with a 64-bit ABI.
5351
5352 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5353
5354         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
5355         ahead of target description loading.
5356
5357 2018-02-26  Tom Tromey  <tom@tromey.com>
5358
5359         * stack.c (backtrace_command_1): Update.
5360         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
5361         of "flags".
5362         * python/py-framefilter.c (py_print_frame)
5363         (gdbpy_apply_frame_filter): Change type of "flags".
5364         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
5365         of "flags".
5366         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
5367         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
5368         * extension.h (enum frame_filter_flag): Rename from
5369         frame_filter_flags.
5370         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
5371         (apply_ext_lang_frame_filter): Change type of "flags".
5372         * extension.c (apply_ext_lang_frame_filter): Change type of
5373         "flags".
5374         * extension-priv.h (struct extension_language_ops)
5375         <apply_frame_filter>: Change type of "flags".
5376
5377 2018-02-26  Tom Tromey  <tom@tromey.com>
5378
5379         PR python/16497:
5380         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
5381         off-by-one in py_end computation.
5382         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
5383         PRINT_MORE_FRAMES.
5384         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
5385         constant.
5386
5387 2018-02-26  Tom Tromey  <tom@tromey.com>
5388
5389         * dwarf2read.c (struct variant_field): New.
5390         (struct nextfield) <variant>: New field.
5391         (dwarf2_add_field): Handle DW_TAG_variant_part.
5392         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
5393         discriminated union.
5394         (read_structure_type): Handle DW_TAG_variant_part.
5395         (handle_struct_member_die): New function, extracted from
5396         process_structure_scope.  Handle DW_TAG_variant.
5397         (process_structure_scope): Handle discriminated unions.  Call
5398         handle_struct_member_die.
5399
5400 2018-02-26  Tom Tromey  <tom@tromey.com>
5401
5402         * rust-lang.h (rust_last_path_segment): Declare.
5403         * rust-lang.c (rust_last_path_segment): Now public.  Change
5404         contract.
5405         (struct disr_info): Remove.
5406         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
5407         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
5408         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
5409         (rust_enum_p, rust_enum_variant): New function.
5410         (rust_underscore_fields): Remove "offset" parameter.
5411         (rust_print_enum): New function.
5412         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
5413         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
5414         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
5415         enums.
5416         (rust_internal_print_type): New function, from rust_print_type.
5417         Remove enum code.
5418         (rust_print_type): Call rust_internal_print_type.
5419         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
5420         Update enum handling.
5421         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
5422         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
5423         (rust_union_quirks): New functions.
5424         (process_full_comp_unit, process_full_type_unit): Call
5425         rust_union_quirks.
5426         (process_structure_scope): Update rust_unions if necessary.
5427
5428 2018-02-26  Tom Tromey  <tom@tromey.com>
5429
5430         * value.h (value_union_variant): Declare.
5431         * valops.c (value_union_variant): New function.
5432         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
5433         (struct discriminant_info): New.
5434         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
5435         enumerator.
5436         (struct main_type) <flag_discriminated_union>: New field.
5437
5438 2018-02-26  Tom Tromey  <tom@tromey.com>
5439
5440         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5441         unittests/unpack-selftests.c.
5442         * unittests/unpack-selftests.c: New file.
5443         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
5444
5445 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5446
5447         * dwarf2read.c (struct partial_die_info) <read>: New method.
5448         (read_partial_die): Remove the declaration.
5449         (load_partial_dies): Update.
5450         (partial_die_info::partial_die_info):
5451         (read_partial_die): Change it to partial_die_info::read.
5452
5453 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5454
5455         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
5456         (fixup_partial_die): Remove declaration.
5457         (scan_partial_symbols): Update.
5458         (partial_die_parent_scope): Likewise.
5459         (partial_die_full_name): Likewise.
5460         (fixup_partial_die): Change it to partial_die_info::fixup.
5461
5462 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5463
5464         * dwarf2read.c (read_partial_die): Update the declaration.
5465         (load_partial_dies): Caller update.
5466         (read_partial_die): Remove one argument abbrev_len.
5467
5468 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5469
5470         * dwarf2read.c (struct partial_die_info): Add ctor, delete
5471         assignment operator.
5472         (load_partial_dies): Use ctor and copy ctor.
5473         (read_partial_die): Update.
5474         (dwarf2_cu::find_partial_die): Use ctor.
5475
5476 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5477
5478         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
5479         (find_partial_die_in_comp_unit): Change it to
5480         dwarf2_cu::find_partial_die.
5481         (find_partial_die): Update.
5482
5483 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5484
5485         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
5486         is NULL.
5487
5488 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5489
5490         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
5491
5492 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
5493
5494         * arch/amd64.h: Use common/tdesc.h.
5495         * arch/i386.c: Likewise.
5496         * arch/i386.h: Likewise.
5497         * arch/tic6x.c: Likewise.
5498         * arch/tdesc.h: Move file from here...
5499         * common/tdesc.h: ...to here.
5500         * features/aarch64-core.c: Regenerate.
5501         * features/aarch64-fpu.c: Regenerate.
5502         * features/i386/32bit-avx.c: Regenerate.
5503         * features/i386/32bit-avx512.c: Regenerate.
5504         * features/i386/32bit-core.c: Regenerate.
5505         * features/i386/32bit-linux.c: Regenerate.
5506         * features/i386/32bit-mpx.c: Regenerate.
5507         * features/i386/32bit-pkeys.c: Regenerate.
5508         * features/i386/32bit-sse.c: Regenerate.
5509         * features/i386/64bit-avx.c: Regenerate.
5510         * features/i386/64bit-avx512.c: Regenerate.
5511         * features/i386/64bit-core.c: Regenerate.
5512         * features/i386/64bit-linux.c: Regenerate.
5513         * features/i386/64bit-mpx.c: Regenerate.
5514         * features/i386/64bit-pkeys.c: Regenerate.
5515         * features/i386/64bit-segments.c: Regenerate.
5516         * features/i386/64bit-sse.c: Regenerate.
5517         * features/i386/x32-core.c: Regenerate.
5518         * features/tic6x-c6xp.c: Regenerate.
5519         * features/tic6x-core.c: Regenerate.
5520         * features/tic6x-gp.c: Regenerate.
5521         * target-descriptions.c: Use common/tdesc.h.
5522         * target-descriptions.h: Likewise.
5523
5524 2018-02-24  Tom Tromey  <tom@tromey.com>
5525
5526         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
5527         (try_thread_db_load_from_dir, thread_db_load_search): Use
5528         std::string.
5529         (info_auto_load_libthread_db_compare): Return bool.  Change
5530         argument types.
5531         (info_auto_load_libthread_db): Use std::vector, std::string.
5532         Remove cleanups.
5533
5534 2018-02-24  Tom Tromey  <tom@tromey.com>
5535
5536         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
5537         std::string.
5538         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
5539         std::string*.
5540         * gdbarch.c: Rebuild.
5541         * gdbarch.h: Rebuild.
5542         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
5543         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
5544         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
5545         std::string*.
5546
5547 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
5548
5549         * gdbtypes.h (sect_offset): Change type to uint64_t.
5550         (sect_offset_str): New function.
5551         * dwarf2read.c (create_addrmap_from_aranges): Use
5552         sect_offset_str.
5553         (error_check_comp_unit_head): Likewise.
5554         (create_debug_type_hash_table): Likewise.
5555         (read_cutu_die_from_dwo): Likewise.
5556         (init_cutu_and_read_dies): Likewise.
5557         (init_cutu_and_read_dies_no_follow): Likewise.
5558         (process_psymtab_comp_unit_reader): Likewise.
5559         (partial_die_parent_scope): Likewise.
5560         (peek_die_abbrev): Likewise.
5561         (process_queue): Likewise.
5562         (dwarf2_physname): Likewise.
5563         (read_namespace_alias): Likewise.
5564         (read_import_statement): Likewise.
5565         (create_dwo_cu_reader): Likewise.
5566         (create_cus_hash_table): Likewise.
5567         (lookup_dwo_cutu): Likewise.
5568         (inherit_abstract_dies): Likewise.
5569         (read_func_scope): Likewise.
5570         (read_call_site_scope): Likewise.
5571         (dwarf2_add_member_fn): Likewise.
5572         (read_common_block): Likewise.
5573         (read_module_type): Likewise.
5574         (read_typedef): Likewise.
5575         (read_subrange_type): Likewise.
5576         (load_partial_dies): Likewise.
5577         (read_partial_die): Likewise.
5578         (find_partial_die): Likewise.
5579         (read_str_index): Likewise.
5580         (dwarf2_string_attr): Likewise.
5581         (build_error_marker_type): Likewise.
5582         (lookup_die_type): Likewise.
5583         (dump_die_shallow): Likewise.
5584         (follow_die_ref): Likewise.
5585         (dwarf2_fetch_die_loc_sect_off): Likewise.
5586         (dwarf2_fetch_constant_bytes): Likewise.
5587         (follow_die_sig): Likewise.
5588         (get_signatured_type): Likewise.
5589         (get_DW_AT_signature_type): Likewise.
5590         (dwarf2_find_containing_comp_unit): Likewise.
5591         (set_die_type): Likewise.
5592
5593 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
5594
5595         * arch/aarch64.c: Include "common-defs.h".
5596         * arch/amd64.c: Likewise.
5597         * arch/i386.c: Likewise.
5598
5599 2018-02-21  Tom Tromey  <tom@tromey.com>
5600
5601         * value.h: (extract_field_op): Update.
5602         * eval.c (extract_field_op): Return a const char *.
5603         * expression.h (parse_expression_for_completion): Update.
5604         * completer.c (complete_expression): Update.
5605         (add_struct_fields): Make fieldname const.
5606         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
5607         (mark_completion_tag, parse_exp_in_context_1): Update.
5608         (parse_expression_for_completion): Change "name" to
5609         unique_xmalloc_ptr*.
5610
5611 2018-02-21  Tom Tromey  <tom@tromey.com>
5612
5613         * infcall.c (call_function_by_hand_dummy): Use std::vector.
5614
5615 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5616
5617         * avr-tdep.c (avr_read_pc): Change parameter type to
5618         readable_regcache.
5619         * gdbarch.sh (read_pc): Likewise.
5620         * gdbarch.c: Re-generated.
5621         * gdbarch.h: Re-generated.
5622         * hppa-tdep.c (hppa_read_pc): Change parameter type to
5623         readable_regcache.
5624         * ia64-tdep.c (ia64_read_pc): Likewise.
5625         * mips-tdep.c (mips_read_pc): Likewise.
5626         * spu-tdep.c (spu_read_pc): Likewise.
5627
5628 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5629
5630         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
5631         * regcache-dump.c: New file.
5632         * regcache.c: Move register_dump to regcache-dump.c.
5633         (maintenance_print_registers): Likewise.
5634         (maintenance_print_raw_registers): Likewise.
5635         (maintenance_print_cooked_registers): Likewise.
5636         (maintenance_print_register_groups): Likewise.
5637         (maintenance_print_remote_registers): Likewise.
5638         (_initialize_regcache): Likewise.
5639         * regcache.h (register_dump): Moved from regcache.c.
5640
5641 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5642
5643         * regcache.c (regcache::regcache): Update.
5644         (regcache::invalidate): Move it to detached_regcache::invalidate.
5645         (get_thread_arch_aspace_regcache): Update.
5646         (regcache::raw_update): Update.
5647         (regcache::cooked_read): Remove some code.
5648         (regcache::cooked_read_value): Likewise.
5649         (regcache::raw_write): Remove assert on m_readonly_p.
5650         (regcache::raw_supply_integer): Move it to
5651         detached_regcache::raw_supply_integer.
5652         (regcache::raw_supply_zeroed): Likewise.
5653         * regcache.h (detached_regcache) <raw_supply_integer>: New
5654         declaration.
5655         <raw_supply_zeroed, invalidate>: Likewise.
5656         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
5657         <invalidate>: Likewise.
5658         <m_readonly_p>: Removed.
5659
5660 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5661
5662         * infcmd.c (get_return_value): Let stop_regs point to
5663         get_current_regcache.
5664         * regcache.c (regcache::regcache): Remove.
5665         (register_dump_reg_buffer): New class.
5666         (regcache_print): Adjust.
5667         * regcache.h (regcache): Remove constructors.
5668
5669 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5670
5671         * regcache.c (class register_dump): New class.
5672         (register_dump_regcache, register_dump_none): New class.
5673         (register_dump_remote, register_dump_groups): New class.
5674         (regcache_print): Update.
5675         * regcache.h (regcache_dump_what): Move it to regcache.c.
5676         (regcache) <dump>: Remove.
5677
5678 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5679
5680         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
5681          reg_buffer_rw *.
5682         (jit_unwind_reg_set_impl): Call raw_supply.
5683         (jit_frame_sniffer): Use reg_buffer_rw.
5684         * record-full.c (record_full_core_regbuf): Change its type.
5685         (record_full_core_open_1): Use reg_buffer_rw.
5686         (record_full_close): Likewise.
5687         (record_full_core_fetch_registers): Use regcache->raw_supply.
5688         (record_full_core_store_registers): Likewise.
5689         * regcache.c (regcache::get_register_status): Move it to
5690         reg_buffer.
5691         (regcache_raw_set_cached_value): Remove.
5692         (regcache::raw_set_cached_value): Remove.
5693         (regcache::raw_write): Call raw_supply.
5694         (regcache::raw_supply): Move it to reg_buffer_rw.
5695         * regcache.h (regcache_raw_set_cached_value): Remove.
5696         (reg_buffer_rw): New class.
5697
5698 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5699
5700         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
5701         readonly_detached_regcache.
5702         (dummy_frame_prev_register): Use regcache->cooked_read.
5703         * frame.c (frame_save_as_regcache): Change return type.
5704         (frame_pop): Update.
5705         * frame.h (frame_save_as_regcache): Update declaration.
5706         * inferior.h (get_infcall_suspend_state_regcache): Update
5707         declaration.
5708         * infrun.c (infcall_suspend_state) <registers>: use
5709         readonly_detached_regcache.
5710         (save_infcall_suspend_state): Don't use regcache_dup.
5711         (get_infcall_suspend_state_regcache): Change return type.
5712         * linux-fork.c (struct fork_info) <savedregs>: Change to
5713         readonly_detached_regcache.
5714         <pc>: New field.
5715         (fork_save_infrun_state): Don't use regcache_dup.
5716         (info_checkpoints_command): Adjust.
5717         * mi/mi-main.c (register_changed_p): Update declaration.
5718         (mi_cmd_data_list_changed_registers): Use
5719         readonly_detached_regcache.
5720         (register_changed_p): Change parameter type to
5721         readonly_detached_regcache.
5722         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
5723         readonly_detached_regcache.
5724         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
5725         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
5726         New.
5727         (regcache::save): Move it to reg_buffer.
5728         (regcache::restore): Change parameter type.
5729         (regcache_dup): Remove.
5730         * regcache.h (reg_buffer) <save>: New method.
5731         (readonly_detached_regcache): New class.
5732         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
5733         readonly_detached_regcache.
5734         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
5735
5736 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5737
5738         * frame.c (frame_save_as_regcache): Use regcache method save.
5739         (frame_pop): Use regcache method restore.
5740         * infrun.c (restore_infcall_suspend_state): Likewise.
5741         * linux-fork.c (fork_load_infrun_state): Likewise.
5742         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
5743         save.
5744         * regcache.c (regcache_save): Remove.
5745         (regcache::restore): More asserts.
5746         (regcache_cpy): Remove.
5747         * regcache.h (regcache_save): Remove the declaration.
5748         (regcache::restore): Move from private to public.
5749         Remove the friend declaration of regcache_cpy.
5750         (regcache_cpy): Remove declaration.
5751
5752 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5753
5754         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
5755         parameter type to 'readable_regcache *'.
5756         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
5757         * arm-tdep.c (arm_neon_quad_read): Likewise.
5758         (arm_pseudo_read): Likewise.
5759         * avr-tdep.c (avr_pseudo_register_read): Likewise.
5760         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
5761         * frv-tdep.c (frv_pseudo_register_read): Likewise.
5762         * gdbarch.c: Re-generated.
5763         * gdbarch.h: Re-generated.
5764         * gdbarch.sh (pseudo_register_read): Change parameter type to
5765         'readable_regcache *'.
5766         (pseudo_register_read_value): Likewise.
5767         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
5768         (h8300_pseudo_register_read): Likewise.
5769         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
5770         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
5771         (i386_pseudo_register_read_into_value): Likewise.
5772         (i386_pseudo_register_read_value): Likewise.
5773         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
5774         declaration.
5775         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
5776         * m32c-tdep.c (m32c_raw_read): Likewise.
5777         (m32c_read_flg): Likewise.
5778         (m32c_banked_register): Likewise.
5779         (m32c_banked_read): Likewise.
5780         (m32c_sb_read): Likewise.
5781         (m32c_part_read): Likewise.
5782         (m32c_cat_read): Likewise.
5783         (m32c_r3r2r1r0_read): Likewise.
5784         (m32c_pseudo_register_read): Likewise.
5785         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
5786         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
5787         (mep_pseudo_cr64_read): Likewise.
5788         (mep_pseudo_register_read): Likewise.
5789         * mips-tdep.c (mips_pseudo_register_read): Likewise.
5790         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
5791         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
5792         * regcache.c (regcache::raw_read): Move it to readable_regcache.
5793         (regcache::cooked_read): Likewise.
5794         (regcache::cooked_read_value): Likewise.
5795         (regcache_cooked_read_signed):
5796         (regcache::cooked_read): Likewise.
5797         * regcache.h (readable_regcache): New class.
5798         (regcache): Inherit readable_regcache.  Move some methods to
5799         readable_regcache.
5800         * rl78-tdep.c (rl78_pseudo_register_read): Change
5801         parameter type to 'readable_regcache *'.
5802         * rs6000-tdep.c (do_regcache_raw_read): Remove.
5803         (e500_pseudo_register_read): Change parameter type to
5804         'readable_regcache *'.
5805         (dfp_pseudo_register_read): Likewise.
5806         (vsx_pseudo_register_read): Likewise.
5807         (efpr_pseudo_register_read): Likewise.
5808         * s390-tdep.c (s390_pseudo_register_read): Likewise.
5809         * sh-tdep.c (sh_pseudo_register_read): Likewise.
5810         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
5811         (sh64_pseudo_register_read): Likewise.
5812         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
5813         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
5814         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
5815         (spu_pseudo_register_read): Likewise.
5816         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
5817         (xtensa_pseudo_register_read): Likewise.
5818
5819 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5820
5821         * regcache.c (regcache::regcache): Call reg_buffer ctor.
5822         (regcache::arch): Move it to reg_buffer::arch.
5823         (regcache::register_buffer): Likewise.
5824         (regcache::assert_regnum): Likewise.
5825         (regcache::num_raw_registers): Likewise.
5826         * regcache.h (reg_buffer): New class.
5827         (regcache): Inherit reg_buffer.
5828
5829 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
5830
5831         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
5832         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
5833
5834 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
5835
5836         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
5837
5838 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
5839
5840         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
5841         (SFILES): Remove common/*.c files.
5842         (COMMON_OBS): Remove some *.o files built from common/*.c files.
5843         * common/common.host: Add common reference.
5844         * configure.ac: Likewise.
5845         * configure: Regenerate.
5846
5847 2018-02-16  Yao Qi  <yao.qi@linaro.org>
5848
5849         * block.c (block_namespace_info): Inherit allocate_on_obstack.
5850         (block_initialize_namespace): Use new.
5851         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
5852         (dwarf2_free_objfile): Use delete.
5853         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
5854         (copy_type_recursive): Use new.
5855         * gdb_obstack.h (allocate_on_obstack): New.
5856
5857 2018-02-15  Yao Qi  <yao.qi@linaro.org>
5858
5859         PR gdb/22849
5860         * inferior.c (exit_inferior_1): Reset inf->control.
5861
5862 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
5863
5864         * ada-lang.c (ada_to_fixed_value_create): Delete advance
5865         declaration.
5866
5867 2018-02-14  Pedro Alves  <palves@redhat.com>
5868
5869         * frame-unwind.c (frame_unwind_try_unwinder): Always call
5870         frame_cleanup_after_sniffer on exception.
5871
5872 2018-02-14  Tom Tromey  <tom@tromey.com>
5873
5874         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
5875         const.
5876         (solib_bfd_open): Make pathname const.
5877         * solib.c (solib_bfd_open): Make pathname const.
5878         * solib-spu.c (spu_bfd_fopen): Make name const.
5879         (spu_bfd_open): Make pathname const.
5880         * solib-darwin.c (darwin_bfd_open): Make pathname const.
5881         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
5882
5883 2018-02-14  Tom Tromey  <tom@tromey.com>
5884
5885         * symfile.c (symfile_bfd_open): Update.
5886         * source.h (openp, source_full_path_of, find_and_open_source):
5887         Change argument type to unique_xmalloc_ptr.
5888         * source.c (openp): Take a unique_xmalloc_ptr.
5889         (source_full_path_of, find_and_open_source): Likewise.
5890         (open_source_file, symtab_to_fullname): Update.
5891         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
5892         unique_xmalloc_ptr.
5893         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
5894         (exec_file_find): Update.
5895         * psymtab.c (psymtab_to_fullname): Update.
5896         * nto-tdep.h (nto_find_and_open_solib): Update.
5897         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
5898         unique_xmalloc_ptr.
5899         * exec.c (exec_file_attach): Update.
5900         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
5901         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
5902
5903 2018-02-14  Tom Tromey  <tom@tromey.com>
5904
5905         * solib.c: Include source.h.
5906         * nto-tdep.c: Include source.h.
5907         * mi/mi-cmd-env.c: Include source.h.
5908         * infcmd.c: Include source.h.
5909         * exec.c: Include source.h.
5910         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
5911         (add_path, directory_switch, source_path, init_source_path): Move
5912         declarations...
5913         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
5914         (add_path, directory_switch, source_path, init_source_path):
5915         ...here.
5916
5917 2018-02-14  Tom Tromey  <tom@tromey.com>
5918
5919         * solist.h (exec_file_find, solib_find): Return
5920         unique_xmalloc_ptr.
5921         (solib_bfd_fopen): Take a const char *.
5922         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
5923         (exec_file_find, solib_find): Likewise.
5924         (solib_bfd_fopen): Do not take ownership of "pathname".
5925         (solib_bfd_open): Use unique_xmalloc_ptr.
5926         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
5927         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
5928         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
5929         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
5930
5931 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
5932
5933         * ada-lang.c (name_match_type_from_name): Remove reference to
5934         ada_name_for_lookup in function's documentation.
5935         * ada-lang.h (ada_name_for_lookup): Delete declaration.
5936
5937 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
5938
5939         * defs.h (enum openp_flags): New enum.
5940         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
5941         Move to enum openp_flags.
5942         (openp_flags): New enum flags.
5943         (openp): Change parameter type to openp_flags.
5944         * source.c (openp): Change parameter type to openp_flags.
5945         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
5946         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
5947
5948 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
5949
5950         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
5951         per-command.
5952
5953 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5954
5955         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
5956         into...
5957         (class dwarf2_queue_guard): ...the destructor of this new class.
5958         (dw2_do_instantiate_symtab): Create instance of the new class
5959         dwarf2_queue_guard, remove cleanup.
5960
5961 2018-02-09  Tom Tromey  <tom@tromey.com>
5962
5963         * source.c (find_source_lines): Don't reference past the end of
5964         the vector.
5965
5966 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5967
5968         * remote.c (remote_btrace_maybe_reopen): Change error message.
5969         * btrace.c (btrace_enable): Likewise.
5970         (parse_xml_btrace): Likewise.
5971         (parse_xml_btrace_conf): Likewise.
5972
5973 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5974
5975         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
5976         (linux_enable_pt, linux_enable_bts): Call
5977         diagnose_perf_event_open_fail.
5978
5979 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5980
5981         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
5982         Remove parameter and change return type.  Update callers.  Move it.
5983         (linux_enable_bts, linux_enable_pt): Improve error message.
5984         (linux_enable_pt): Remove zero buffer size check.
5985         (linux_enable_btrace): Improve error messages.  Remove NULL return
5986         check.
5987
5988 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5989
5990         * btrace.c (btrace_enable): Remove target_supports_btrace call.
5991         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
5992         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
5993         (linux_supports_pt, linux_supports_btrace): Remove.
5994         (linux_enable_bts): Call cpu_supports_bts.
5995         * nat/linux-btrace.h (linux_supports_btrace): Remove.
5996         * remote.c (remote_supports_btrace): Remove.
5997         (init_remote_ops): Remove remote_supports_btrace.
5998         * target-delegates.c: Regenerated.
5999         * target.c (target_supports_btrace): Remove.
6000         * target.h (target_ops) <to_supports_btrace>: Remove
6001         (target_supports_btrace): Remove.
6002         * x86-linux-nat.c (x86_linux_create_target): Remove
6003         linux_supports_btrace.
6004
6005 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6006
6007         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
6008         btrace failed.
6009         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
6010         exception and use message in own exception.
6011
6012 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6013
6014         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
6015         (perf_event_pt_event_type): Use gdb_file_up.
6016         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
6017         scoped_fd, and scoped_mmap.
6018
6019 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6020
6021         * common/scoped_mmap.h: New.
6022         * unittests/scoped_mmap-selftest.c: New.
6023         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6024         unittests/scoped_mmap-selftest.c.
6025
6026 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6027
6028         * common/scoped_fd.h: New.
6029         * unittests/scoped_fd-selftest.c: New.
6030         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6031         unittests/scoped_fd-selftest.c.
6032
6033 2018-02-09  Tom Tromey  <tom@tromey.com>
6034
6035         * auto-load.c (auto_load_section_scripts): Use
6036         gdb::unique_xmalloc_ptr.
6037
6038 2018-02-09  Tom Tromey  <tom@tromey.com>
6039
6040         * auto-load.c (execute_script_contents): Use std::string.
6041
6042 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
6043
6044         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
6045         Python function, rather than a new command.
6046
6047 2018-02-08  Tom Tromey  <tom@tromey.com>
6048
6049         * solib.c (solib_find_1): Use std::string.
6050         (solib_bfd_fopen): Use unique_xmalloc_ptr.
6051
6052 2018-02-08  Tom Tromey  <tom@tromey.com>
6053
6054         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
6055
6056 2018-02-08  Tom Tromey  <tom@tromey.com>
6057
6058         * source.c (find_source_lines): Use gdb::def_vector.
6059
6060 2018-02-08  Tom Tromey  <tom@tromey.com>
6061
6062         * macrocmd.c (struct temporary_macro_definition): New.
6063         (macro_define_command): Use temporary_macro_definition.  Remove
6064         cleanups.
6065         (free_macro_definition_ptr): Remove.
6066
6067 2018-02-08  Tom Tromey  <tom@tromey.com>
6068
6069         * macroexp.c (maybe_expand): Use std::string.
6070
6071 2018-02-08  Tom Tromey  <tom@tromey.com>
6072
6073         * macroexp.c (struct macro_buffer): Add initializers for some
6074         members.
6075         (init_buffer, init_shared_buffer, free_buffer)
6076         (free_buffer_return_text): Remove.
6077         (macro_buffer): New constructors.
6078         (~macro_buffer): New destructor.
6079         (macro_buffer::set_shared): New method.
6080         (macro_buffer::resize_buffer, macro_buffer::appendc)
6081         (macro_buffer::appendmem): Now methods, not free functions.
6082         (set_token, append_tokens_without_splicing, stringify)
6083         (macro_stringify): Update.
6084         (gather_arguments): Change return type.  Remove argc_p argument,
6085         add args_ptr argument.  Use std::vector.
6086         (substitute_args): Remove argc argument.  Accept std::vector.
6087         (expand): Update.  Use std::vector.
6088         (scan, macro_expand, macro_expand_next): Update.
6089
6090 2018-02-08  Tom Tromey  <tom@tromey.com>
6091
6092         * symtab.c (default_collect_symbol_completion_matches_break_on):
6093         Use unique_xmalloc_ptr.
6094         * macroscope.h: (sal_macro_scope, user_macro_scope)
6095         (default_macro_scope): Return unique_xmalloc_ptr.
6096         * macroscope.c (sal_macro_scope, user_macro_scope)
6097         (default_macro_scope): Return unique_xmalloc_ptr.
6098         * macroexp.h (macro_expand, macro_expand_once): Return
6099         unique_xmalloc_ptr.
6100         * macroexp.c (macro_expand, macro_expand_once): Return
6101         unique_xmalloc_ptr.
6102         * macrocmd.c (macro_expand_command, macro_expand_once_command)
6103         (info_macro_command, info_macros_command): Use
6104         unique_xmalloc_ptr.
6105         * compile/compile-c-support.c (write_macro_definitions): Use
6106         unique_xmalloc_ptr.
6107         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
6108
6109 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
6110
6111         * value.c (value_static_field): Assign field type instead of
6112         containing type when returning an optimized out value.
6113
6114 2018-02-06  Yao Qi  <yao.qi@linaro.org>
6115
6116         * ft32-tdep.c (ft32_read_pc): Remove.
6117         (ft32_write_pc): Remove.
6118         (ft32_gdbarch_init): Update.
6119         * m32r-tdep.c (m32r_read_pc): Remove.
6120         (m32r_gdbarch_init): Update.
6121         * mep-tdep.c (mep_read_pc): Remove.
6122         (mep_gdbarch_init): Update.
6123         * microblaze-tdep.c (microblaze_write_pc): Remove.
6124         (microblaze_gdbarch_init): Update.
6125         * mn10300-tdep.c (mn10300_read_pc): Remove.
6126         (mn10300_write_pc): Remove.
6127         (mn10300_gdbarch_init): Update.
6128         * moxie-tdep.c (moxie_read_pc): Remove.
6129         (moxie_write_pc): Remove.
6130         (moxie_gdbarch_init): Update.
6131
6132 2018-02-06  Yao Qi  <yao.qi@linaro.org>
6133
6134         * expprint.c (print_subexp_standard): Handle
6135         OP_F77_UNDETERMINED_ARGLIST.
6136         (dump_subexp_body_standard): Likewise.
6137
6138 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
6139
6140         * target-descriptions.c (tdesc_element_visitor) Add empty
6141         implementations.
6142         (tdesc_type): Move make_gdb_type from here.
6143         (tdesc_type_builtin): Likewise.
6144         (tdesc_type_vector): Likewise.
6145         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
6146         (make_gdb_type_struct): Move from tdesc_type_with_fields.
6147         (make_gdb_type_union): Likewise.
6148         (make_gdb_type_flags): Likewise.
6149         (make_gdb_type_enum): Likewise.
6150         (make_gdb_type): New function.
6151         (tdesc_register_type): Use static make_gdb_type.
6152
6153 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
6154
6155         * infcmd.c (default_print_one_register_info): Align natural-format
6156         column values consistently one under another.
6157         (pad_to_column): New function.
6158
6159 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
6160
6161         * dwarf2read.c (dwarf2_physname): Move commment.
6162
6163 2018-02-01  Leszek Swirski  <leszeks@google.com>
6164
6165         * varobj.c (varobj_formatted_print_options): Allow recursive
6166         pretty printing if pretty printing is enabled.
6167
6168 2018-02-01  Leszek Swirski  <leszeks@google.com>
6169
6170         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
6171         names after a structop as a filename.
6172
6173 2018-02-01  Yao Qi  <yao.qi@linaro.org>
6174
6175         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
6176         (arm_record_coproc_data_proc): Likewise.
6177
6178 2018-02-01  Yao Qi  <yao.qi@linaro.org>
6179
6180         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
6181
6182 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
6183
6184         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
6185         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
6186
6187 2018-01-31  Pedro Alves  <palves@redhat.com>
6188
6189         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
6190         * inflow.c (child_terminal_save_inferior): Wrap reference to
6191         tcgetpgrp in HAVE_TERMIOS_H.
6192         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
6193         _WIN32.
6194         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
6195         always iterate over all inferiors.
6196         (gdbsim_cntrl_c): Adjust.
6197         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
6198
6199 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
6200
6201         * gdbtypes.c (lookup_array_range_type): Make sure the array's
6202         index type is objfile-owned if the element type is as well.
6203
6204 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
6205
6206         GDB 8.1 released.
6207
6208 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6209
6210         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
6211         "features/s390x-linux64.c".
6212         (_initialize_s390_linux_tdep): Remove initialization of tdescs
6213         s390_linux32 and s390x_linux64.
6214         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
6215         default tdesc.
6216         * s390-tdep.c: Include "features/s390-linux32.c" and
6217         "features/s390x-linux64.c".
6218         (s390_tdesc_valid): Add check for tdesc_has_registers.
6219         (s390_gdbarch_init): Make sure there is always a valid tdesc.
6220         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
6221         tdesc_s390x_linux64.
6222         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
6223         tdesc_s390x_linux64 to...
6224         * s390-tdep.h: ...here.
6225
6226 2018-01-30  Pedro Alves  <palves@redhat.com>
6227
6228         PR gdb/13211
6229         * config.in, configure: Regenerate.
6230         * configure.ac: Check for getpgid.
6231         * go32-nat.c (go32_pass_ctrlc): New.
6232         (go32_target): Install it.
6233         * inf-child.c (inf_child_target): Install
6234         child_terminal_save_inferior, child_pass_ctrlc and
6235         child_interrupt.
6236         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
6237         (inf_ptrace_target): No longer install it.
6238         * infcmd.c (interrupt_target_1): Adjust.
6239         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
6240         (child_interrupt): Declare.
6241         (inferior::terminal_state): New.
6242         * inflow.c (struct terminal_info): Update comments.
6243         (inferior_process_group): Delete.
6244         (terminal_is_ours): Delete.
6245         (gdb_tty_state): New.
6246         (child_terminal_init): Adjust.
6247         (is_gdb_terminal, sharing_input_terminal_1)
6248         (sharing_input_terminal): New functions.
6249         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
6250         Set the process's actual process group in the foreground if
6251         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
6252         mark terminal as the inferior's if not sharing GDB's terminal.
6253         Don't check attach_flag.
6254         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
6255         pass down a target_terminal_state.
6256         (child_terminal_save_inferior): New, factored out from ...
6257         (child_terminal_ours_1): ... this.  Handle
6258         target_terminal_state::is_ours_for_output.
6259         (child_interrupt, child_pass_ctrlc): New.
6260         (inflow_inferior_exit): Clear the inferior's terminal_state.
6261         (copy_terminal_info): Copy the inferior's terminal state.
6262         (_initialize_inflow): Remove reference to terminal_is_ours.
6263         * inflow.h (inferior_process_group): Delete.
6264         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
6265         * procfs.c (procfs_target): Don't install procfs_interrupt.
6266         (procfs_interrupt): Delete.
6267         * remote.c (remote_serial_quit_handler): Adjust.
6268         (remote_interrupt): Remove ptid parameter.  Adjust.
6269         * target-delegates.c: Regenerate.
6270         * target.c: Include "terminal.h".
6271         (target_terminal::terminal_state): Rename to ...
6272         (target_terminal::m_terminal_state): ... this.
6273         (target_terminal::init): Adjust.
6274         (target_terminal::inferior): Adjust to per-inferior
6275         terminal_state.
6276         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
6277         (target_terminal::ours, target_terminal::ours_for_output): Use
6278         target_terminal_is_ours_kind.
6279         (target_interrupt): Remove ptid parameter.  Adjust.
6280         (default_target_pass_ctrlc): Adjust.
6281         * target.h (target_ops::to_terminal_save_inferior): New field.
6282         (target_ops::to_interrupt): Remove ptid_t parameter.
6283         (target_interrupt): Remove ptid_t parameter.  Update comment.
6284         (target_pass_ctrlc): Update comment.
6285         * target/target.h (target_terminal_state): New scoped enum,
6286         factored out of ...
6287         (target_terminal::terminal_state): ... here.
6288         (target_terminal::inferior): Update comments.
6289         (target_terminal::restore_inferior): New.
6290         (target_terminal::is_inferior, target_terminal::is_ours)
6291         (target_terminal::is_ours_for_output): Adjust.
6292         (target_terminal::scoped_restore_terminal_state): Adjust to
6293         rename, and call restore_inferior() instead of inferior().
6294         (target_terminal::scoped_restore_terminal_state::m_state): Change
6295         type.
6296         (target_terminal::terminal_state): Rename to ...
6297         (target_terminal::m_terminal_state): ... this and change type.
6298
6299 2018-01-30  Pedro Alves  <palves@redhat.com>
6300
6301         * linux-nat.c (wait_for_signal): New function.
6302         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
6303         directly.
6304         (async_terminal_is_ours)
6305         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
6306         (linux_nat_add_target): Don't override
6307         to_terminal_inferior/to_terminal_ours.
6308
6309 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6310
6311         * remote.c (remote_follow_fork): Don't call "detach_inferior".
6312
6313 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
6314
6315         * dwarf2read.c (free_dwo_files): Add forward-declaration.
6316         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
6317         dwarf2_per_objfile_free here.
6318         (dwarf2_per_objfile_free): Remove.
6319         (_initialize_dwarf2_read): Don't register
6320         dwarf2_per_objfile_free as a registry cleanup.
6321
6322 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
6323
6324         Avoid compilation errors in MinGW native builds
6325
6326         The error is triggered by including python-internal.h, and the
6327         error message is:
6328
6329              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
6330                       from build-gnulib/import/math.h:27,
6331                       from d:/usr/Python26/include/pyport.h:235,
6332                       from d:/usr/Python26/include/Python.h:58,
6333                       from python/python-internal.h:94,
6334                       from python/py-arch.c:24:
6335              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
6336         using ::hypot;
6337                 ^~~~~
6338
6339         This happens because Python headers define 'hypot' to expand t
6340         '_hypot' in the Windows builds.
6341         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
6342         'hypoth'.  This avoids a compilation error.
6343
6344 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6345
6346         * MAINTAINERS (Write After Approval): Fix ordering.
6347
6348 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6349
6350         * MAINTAINERS (Write After Approval): Add Alan Hayward.
6351
6352 2018-01-26  Alan Modra  <amodra@gmail.com>
6353
6354         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
6355         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
6356         Remove nop.  Make const.  Comment.
6357         (powerpc32_plt_stub_so_2): New.
6358         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
6359         Correct count.  Update uses.
6360         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
6361         Move common code reading PLT entry word.  Correct
6362         powerpc32_plt_stub PLT address calculation.
6363         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
6364         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
6365         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
6366         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
6367         (ppc64_standard_linkage8): Likewise.
6368         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
6369         Correct insns description.
6370         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
6371
6372 2018-01-24  Pedro Alves  <palves@redhat.com>
6373
6374         GCC PR libstdc++/83906
6375         * gdbtypes.c (operator==(const dynamic_prop &,
6376         const dynamic_prop &)): New.
6377         (operator==(const range_bounds &, const range_bounds &)): New.
6378         (check_types_equal): Use them instead of memcmp.
6379         * gdbtypes.h (operator==(const dynamic_prop &,
6380         const dynamic_prop &)): Declare.
6381         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
6382         (operator==(const range_bounds &, const range_bounds &)): Declare.
6383         (operator!=(const range_bounds &, const range_bounds &)): Declare.
6384
6385 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6386
6387         * s390-linux-tdep.c (s390_record_address_mask)
6388         (s390_record_calc_disp_common, s390_record_calc_disp)
6389         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6390         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6391         (s390_process_record): Move to s390-tdep.c.
6392         (s390_linux_init_abi_any): Adjust.
6393         * s390-tdep.c (s390_record_address_mask)
6394         (s390_record_calc_disp_common, s390_record_calc_disp)
6395         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6396         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6397         (s390_process_record): Moved from s390-linux-tdep.c
6398         (s390_gdbarch_init): Adjust.
6399
6400 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6401
6402         * s390-linux-nat.c (s390-tdep.h): New include.
6403         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
6404         (HFILES_NO_SRCDIR): Add s390-tdep.h.
6405         (ALLDEPFILES): Add s390-tdep.c.
6406         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
6407         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
6408         * s390-tdep.h: ...this.  New file.
6409         * s390-linux-tdep.c (s390-tdep.h): New include.
6410         (_initialize_s390_tdep): Rename to...
6411         (_initialize_s390_linux_tdep): ...this and adjust.
6412         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
6413         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
6414         s390-tdep.h.
6415         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
6416         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
6417         (s390_is_partial_instruction, s390_software_single_step)
6418         (is_non_branch_ril, s390_displaced_step_copy_insn)
6419         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
6420         (s390_prologue_data, s390_addr, s390_store, s390_load)
6421         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
6422         (s390_register_call_saved, s390_guess_tracepoint_registers)
6423         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
6424         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
6425         (s390_pseudo_register_name, s390_pseudo_register_type)
6426         (s390_pseudo_register_read, s390_pseudo_register_write)
6427         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
6428         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
6429         (s390_addr_bits_remove, s390_address_class_type_flags)
6430         (s390_address_class_type_flags_to_name)
6431         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
6432         (s390_function_arg_float, s390_function_arg_vector)
6433         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
6434         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
6435         (s390_frame_align, s390_register_return_value, s390_return_value)
6436         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
6437         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
6438         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
6439         (s390_trad_frame_prev_register, s390_unwind_cache)
6440         (s390_prologue_frame_unwind_cache)
6441         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
6442         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
6443         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
6444         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
6445         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
6446         (s390_frame_base_address, s390_local_base_address)
6447         (s390_frame_base, s390_gcc_target_options)
6448         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
6449         (s390_validate_reg_range, s390_tdesc_valid)
6450         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
6451         * s390-tdep.c: ...this.  New file.
6452
6453 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6454
6455         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
6456         (s390_process_record, s390_gdbarch_tdep_alloc)
6457         (s390_linux_init_abi_any): Use/set new hook.
6458
6459 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6460
6461         * s390-linux-tdep.c (osabi.h): New include.
6462         (s390_linux_init_abi_31, s390_linux_init_abi_64)
6463         (s390_linux_init_abi_any): New functions.
6464         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
6465
6466 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6467
6468         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
6469         tdesc_has_registers check
6470
6471 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6472
6473         * s390-linux-tdep.c (s390_tdesc_valid): New function.
6474         (s390_validate_reg_range): New macro.
6475         (s390_gdbarch_init): Adjust.
6476
6477 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6478
6479         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
6480         (s390_gdbarch_tdep_alloc): Adjust.
6481         (s390_gdbarch_init): Adjust.
6482
6483 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6484
6485         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
6486         <have_tdb>: Change type to bool.
6487         (s390_gdbarch_tdep_alloc): Adjust.
6488         (s390_gdbarch_init): Adjust.
6489
6490 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6491
6492         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
6493         (gdbarch_tdep) <have_upper, have_vx>: New fields.
6494         (s390_gdbarch_tdep_alloc): New function.
6495         (s390_gdbarch_init): Allocate tdep at start and use its fields
6496         instead of separate variables.
6497
6498 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6499
6500         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
6501         when looking for cached gdbarch and add comment for remaining.
6502
6503 2018-01-22  Pedro Alves  <palves@redhat.com>
6504             Sergio Durigan Junior  <sergiodj@redhat.com>
6505
6506         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
6507         case.
6508
6509 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
6510
6511         * MAINTAINERS: Update my company e-mail address.
6512
6513 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6514
6515         * regcache.c (cooked_write_test): New function.
6516         (_initialize_regcache): Register the test.
6517
6518 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6519
6520         * ia64-tdep.c (ia64_pseudo_register_read): Call
6521         regcache->cooked_read instead of regcache_cooked_read_unsigned.
6522         * m32c-tdep.c (m32c_cat_read): Likewise.
6523         (m32c_r3r2r1r0_read): Likewise.
6524         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
6525         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
6526
6527 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6528
6529         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
6530         method raw_read instead of regcache_raw_read.
6531         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
6532         * arm-tdep.c (arm_neon_quad_read): Likewise.
6533         * avr-tdep.c (avr_pseudo_register_read): Likewise.
6534         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
6535         * frv-tdep.c (frv_pseudo_register_read): Likewise.
6536         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
6537         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
6538         (i386_pseudo_register_read_into_value): Likewise.
6539         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
6540         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
6541         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
6542         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
6543         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
6544         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
6545         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
6546         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
6547         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
6548
6549 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6550
6551         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
6552         * configure.tgt: Remove target mt.
6553         * mt-tdep.c: Remove.
6554         * regcache.c (cooked_read_test): Remove the check for mt.
6555
6556 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6557
6558         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
6559         instead of gdbarch_pseudo_register_read_value.
6560
6561 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6562
6563         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
6564         language is Ada.
6565
6566 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6567
6568         * linespec.c (create_sals_line_offset): Remove code that preserved
6569         the symtab_and_line's line number.
6570
6571 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6572
6573         * varobj.c (varobj_create): Don't set valid_block when creating a
6574         floating varobj.
6575
6576 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6577
6578         * varobj.c (varobj_create): Remove out of date comment.
6579
6580 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6581
6582         PR mi/20395
6583         * ada-exp.y (write_var_from_sym): Pass extra parameter when
6584         updating innermost block.
6585         * parse.c (innermost_block_tracker::update): Take extra type
6586         parameter, and check types match before updating innermost block.
6587         (write_dollar_variable): Update innermost block for registers.
6588         * parser-defs.h (enum innermost_block_tracker_type): New enum.
6589         (innermost_block_tracker::innermost_block_tracker): Initialise
6590         m_types member.
6591         (innermost_block_tracker::reset): Take type parameter.
6592         (innermost_block_tracker::update): Take type parameter, and pass
6593         type through as needed.
6594         (innermost_block_tracker::m_types): New member.
6595         * varobj.c (varobj_create): Pass type when reseting innermost
6596         block.
6597
6598 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6599
6600         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
6601         * ada-lang.c (resolve_subexp): Likewise.
6602         * breakpoint.c (set_breakpoint_condition) Likewise.
6603         (watch_command_1) Likewise.
6604         * c-exp.y (variable): Likewise.
6605         * d-exp.y (PrimaryExpression): Likewise.
6606         * f-exp.y (variable): Likewise.
6607         * go-exp.y (variable): Likewise.
6608         * m2-exp.y (variable): Likewise.
6609         * objfiles.c (objfile::~objfile): Likewise.
6610         * p-exp.y (variable): Likewise.
6611         * parse.c (innermost_block): Change type.
6612         * parser-defs.h (class innermost_block_tracker): New.
6613         (innermost_block): Change to innermost_block_tracker.
6614         * printcmd.c (display_command): Switch to innermost_block API.
6615         (do_one_display): Likewise.
6616         * rust-exp.y (do_one_display): Likewise.
6617         * symfile.c (clear_symtab_users): Likewise.
6618         * varobj.c (varobj_create): Switch to innermost_block API, replace
6619         use of innermost_block with block stored on varobj object.
6620
6621 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6622
6623         * expression.h (innermost_block): Remove declaration.
6624         * varobj.c: Add 'parser-defs.h' include.
6625
6626 2018-01-19  Tom Tromey  <tom@tromey.com>
6627
6628         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
6629         symbols in the static and global blocks.
6630
6631 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
6632
6633         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
6634         gdb_ptrace.h, and move including gdb_wait.h ...
6635         * nat/linux-ptrace.h: ... to here.
6636
6637 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6638
6639         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
6640         inf_ptrace_detach_success.
6641         (inf_ptrace_detach_success): Add inferior parameter, use it
6642         instead of inferior_ptid, pass it to detach_inferior.
6643         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
6644         parameter.
6645         * inferior.c (detach_inferior): Add overload that takes an
6646         inferior object.
6647         * inferior.h (detach_inferior): Likewise.
6648         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
6649         use inferior_ptid, adjust call to inf_ptrace_detach_success.
6650         * linux-thread-db.c (thread_db_detach): Use inf parameter.
6651
6652 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6653
6654         * target.h (struct target_ops) <to_detach>: Add inferior
6655         parameter.
6656         (target_detach): Likewise.
6657         * target.c (dispose_inferior): Pass inferior down.
6658         (target_detach): Pass inferior down.  Assert that it is equal to
6659         the current inferior.
6660         * aix-thread.c (aix_thread_detach): Pass inferior down.
6661         * corefile.c (core_file_command): Pass current_inferior() down.
6662         * corelow.c (core_detach): Add inferior parameter.
6663         * darwin-nat.c (darwin_detach): Likewise.
6664         * gnu-nat.c (gnu_detach): Likewise.
6665         * inf-ptrace.c (inf_ptrace_detach): Likewise.
6666         * infcmd.c (detach_command): Pass current_inferior() down to
6667         target_detach.
6668         * infrun.c (follow_fork_inferior): Pass parent_inf to
6669         target_detach.
6670         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
6671         target_detach.
6672         * linux-nat.c (linux_nat_detach): Add inferior parameter.
6673         * linux-thread-db.c (thread_db_detach): Likewise.
6674         * nto-procfs.c (procfs_detach): Likewise.
6675         * procfs.c (procfs_detach): Likewise.
6676         * record.c (record_detach): Likewise.
6677         * record.h (struct inferior): Forward-declare.
6678         (record_detach): Add inferior parameter.
6679         * remote-sim.c (gdbsim_detach): Likewise.
6680         * remote.c (remote_detach_1): Likewise.
6681         (remote_detach): Likewise.
6682         (extended_remote_detach): Likewise.
6683         * sol-thread.c (sol_thread_detach): Likewise.
6684         * target-debug.h (target_debug_print_inferior_p): New macro.
6685         * target-delegates.c: Re-generate.
6686         * top.c (kill_or_detach): Pass inferior down to target_detach.
6687         * windows-nat.c (windows_detach): Add inferior parameter.
6688
6689 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6690
6691         * target.h (struct target_ops) <to_detach>: Remove args
6692         parameter.
6693         (target_detach): Likewise.
6694         * target.c (dispose_inferior): Adjust.
6695         (target_detach): Remove args parameter, adjust.
6696         * aix-thread.c (aix_thread_detach): Adjust.
6697         * corefile.c (core_file_command): Adjust.
6698         * corelow.c (core_detach): Adjust.
6699         * darwin-nat.c (darwin_detach): Adjust.
6700         * gnu-nat.c (gnu_detach): Adjust.
6701         * inf-ptrace.c (inf_ptrace_detach): Adjust.
6702         * infcmd.c (detach_command): Adjust
6703         * infrun.c (follow_fork_inferior): Adjust.
6704         (handle_vfork_child_exec_or_exit): Adjust.
6705         * linux-fork.c (linux_fork_detach): Remove args parameter.
6706         * linux-fork.h (linux_fork_detach): Likewise.
6707         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
6708         * linux-thread-db.c (thread_db_detach): Likewise.
6709         * nto-procfs.c (procfs_detach): Likewise.
6710         * procfs.c (procfs_detach): Likewise.
6711         (do_detach): Remove signo parameter.
6712         * record.c (record_detach): Remove args parameter.
6713         * record.h (record_detach): Likewise.
6714         * remote-sim.c (gdbsim_detach): Likewise.
6715         * remote.c (remote_detach_1): Likewise.
6716         (remote_detach): Likewise.
6717         (extended_remote_detach): Likewise.
6718         * sol-thread.c (sol_thread_detach): Likewise.
6719         * target-delegates.c: Re-generate.
6720         * top.c (struct qt_args) <args>: Remove field.
6721         (kill_or_detach): Don't pass args.
6722         (quit_force): Don't set args.
6723         * windows-nat.c (windows_detach): Remove args parameter.
6724
6725 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6726
6727         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
6728         (arm_linux_init_abi): Install it.
6729
6730 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6731
6732         * osabi.c (gdb_osabi_names): Extend the regexp for
6733         arm-linux-gnueabihf.
6734
6735 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6736
6737         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
6738         m_abbrevs.
6739         (abbrev_table::add_abbrev): Update.
6740         (abbrev_table::lookup_abbrev): Update.
6741
6742 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6743
6744         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
6745
6746 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
6747
6748         * compile/compile.c (compile_to_object): Convert "triplet_rx"
6749         to "std::string".
6750
6751 2018-01-17  Tom Tromey  <tom@tromey.com>
6752
6753         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
6754
6755 2018-01-17  Tom Tromey  <tom@tromey.com>
6756
6757         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
6758         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
6759         (create_array_type_with_stride): Update.
6760         * dwarf2read.c (set_die_type): Update.
6761
6762 2018-01-17  Tom Tromey  <tom@tromey.com>
6763
6764         * dwarf2read.c (delayed_method_info): Remove typedef.
6765         (dwarf2_cu::method_info): Now a std::vector.
6766         (add_to_method_list): Update.
6767         (free_delayed_list): Remove.
6768         (compute_delayed_physnames): Update.
6769         (process_full_comp_unit, process_full_type_unit): Clear the method
6770         list.  Remove cleanups.
6771         (psymtab_include_file_name): Add name_holder parameter.  Use
6772         unique_xmalloc_ptr.
6773         (dwarf_decode_lines): Update.
6774
6775 2018-01-17  Tom Tromey  <tom@tromey.com>
6776             Simon Marchi  <simon.marchi@ericsson.com>
6777
6778         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
6779         (dwarf2_per_objfile::free_cached_comp_units)
6780         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
6781         (init_cutu_and_read_dies_no_follow): Update.
6782         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
6783         (dwarf2_cu::~dwarf2_cu): New.
6784         (free_heap_comp_unit, free_stack_comp_unit): Remove.
6785         (age_cached_comp_units, free_one_cached_comp_unit): Update.
6786
6787 2018-01-17  Tom Tromey  <tom@tromey.com>
6788             Simon Marchi  <simon.marchi@ericsson.com>
6789
6790         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
6791         (struct die_reader_specs) <abbrev_table>: New member.
6792         (struct abbrev_table): Add constructor.
6793         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
6794         <abbrev_obstack>: Now an auto_obstack.
6795         (abbrev_table_up): New typedef.
6796         (init_cu_die_reader): Add abbrev_table parameter.
6797         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
6798         Add result_dwo_abbrev_table.
6799         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
6800         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
6801         Update.
6802         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
6803         parameter.
6804         (skip_children): Update.
6805         (abbrev_table::alloc_abbrev): Rename from
6806         abbrev_table_alloc_abbrev.
6807         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
6808         (abbrev_table::lookup_abbrev): Rename from
6809         abbrev_table_lookup_abbrev.
6810         (abbrev_table_read_table): Return abbrev_table_up.
6811         (abbrev_table_free, abbrev_table_free_cleanup)
6812         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
6813         (load_partial_dies): Update.
6814
6815 2018-01-17  Tom Tromey  <tom@tromey.com>
6816
6817         * dwarf2read.c (dwarf2_compute_name): Update comment.
6818         (read_func_scope, read_variable): Update.
6819         (new_symbol): Remove.
6820         (new_symbol_full): Rename to new_symbol.
6821
6822 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
6823
6824         PR gdb/16577
6825         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
6826         a warning instead of throwing an error, set section size to 0 and return
6827         NULL.
6828         * gdb_bfd.h (gdb_bfd_map_section): Update description.
6829
6830 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
6831
6832         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
6833         std::string.
6834         (linux_ptrace_attach_fail_reason_string): Likewise.
6835         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
6836         Likewise.
6837         (linux_ptrace_attach_fail_reason_string): Likewise.
6838         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
6839
6840 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
6841
6842         * linux-nat.c (linux_nat_attach): Remove xstrdup.
6843
6844 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
6845
6846         PR gdb/21559
6847         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
6848         checking for fs_base/gs_base fields in struct user_regs_struct.
6849         * configure: Regenerate.
6850
6851 2018-01-17  Yao Qi  <yao.qi@linaro.org>
6852
6853         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
6854         function.
6855         (aarch64_linux_init_abi): Install it to gdbarch hook
6856         gcc_target_options.
6857
6858 2018-01-15  Pedro Alves  <palves@redhat.com>
6859
6860         * common/signals-state-save-restore.c
6861         (save_original_signals_state): Fix typos.
6862
6863 2017-01-12  Tom Tromey  <tom@tromey.com>
6864             Sergio Durigan Junior  <sergiodj@redhat.com>
6865
6866         * Makefile.in (install-only): Install gdb-add-index.
6867
6868 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
6869
6870         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
6871
6872 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
6873
6874         * infrun.c (keep_going_pass_signal): Clear step-over info when
6875         insert_breakpoints fails.
6876
6877 2018-01-11  Pedro Alves  <palves@redhat.com>
6878
6879         PR gdb/22583
6880         * infrun.c (resume): Rename to ...
6881         (resume_1): ... this.
6882         (resume): Reimplement as wrapper around resume_1.
6883
6884 2018-01-11  Pedro Alves  <palves@redhat.com>
6885
6886         PR remote/22597
6887         * remote.c (remote_parse_stop_reply): Default to the last-set
6888         general thread instead of to 'magic_null_ptid'.
6889
6890 2018-01-10  Pedro Alves  <palves@redhat.com>
6891
6892         * language.h (language_get_symbol_name_matcher): Rename ...
6893         (get_symbol_name_matcher): ... this.
6894         * language.c (language_get_symbol_name_matcher): Ditto.
6895         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
6896         callers adjusted.
6897
6898 2018-01-10  Pedro Alves  <palves@redhat.com>
6899
6900         PR gdb/22670
6901         * dwarf2read.c
6902         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
6903         Adjust to use language_get_symbol_name_matcher instead of
6904         language_defn::la_get_symbol_name_matcher.
6905         * language.c (language_get_symbol_name_matcher): If in Ada mode
6906         and the lookup name is a verbatim match, return Ada's matcher.
6907         * language.h (language_get_symbol_name_matcher): Adjust comment.
6908         (ada_lookup_name_info::verbatim_p):: New method.
6909
6910 2018-01-10  Pedro Alves  <palves@redhat.com>
6911
6912         PR gdb/22670
6913         * ada-lang.c (ada_collect_symbol_completion_matches): If the
6914         minsym's language is language_auto or language_cplus, pass down
6915         language_ada instead.
6916         * symtab.c (compare_symbol_name): Don't frob symbol language here.
6917
6918 2018-01-10  Pedro Alves  <palves@redhat.com>
6919
6920         PR gdb/22670
6921         * minsyms.c (linkage_name_str): New function.
6922         (iterate_over_minimal_symbols): Use it.
6923
6924 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6925
6926         * NEWS: Document that 'info proc' now works on FreeBSD.
6927
6928 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6929
6930         * configure.ac: Check for kinfo_getfile in libutil.
6931         * configure: Regenerate.
6932         * config.in: Regenerate.
6933         * fbsd-nat.c: Include "fbsd-tdep.h".
6934         (fbsd_fetch_cmdline): New.
6935         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
6936         rather than calling error.
6937         (fbsd_info_proc): New.
6938         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
6939         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
6940         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
6941
6942 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6943
6944         * fbsd-nat.c (struct free_deleter): Remove.
6945         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
6946
6947 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6948
6949         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
6950         NULL for an empty pathname.
6951
6952 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6953
6954         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
6955         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
6956         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
6957         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
6958         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
6959         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
6960         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
6961         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
6962         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
6963         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
6964         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
6965         (fbsd_core_fetch_timeval, fbsd_print_sigset)
6966         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
6967         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
6968         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
6969
6970 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
6971
6972         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
6973         (gnu_xfer_auxv): New function.
6974         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
6975         TARGET_OBJECT_AUXV.
6976
6977 2018-01-08  Yao Qi  <yao.qi@linaro.org>
6978             Simon Marchi  <simon.marchi@ericsson.com>
6979
6980         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
6981         common/selftest.c.
6982         (COMMON_OBS): Remove selftest.o.
6983         * configure.ac: Append selftest-arch.c and common/selftest.c to
6984         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
6985         * configure: Re-generated.
6986         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
6987         GDB_SELF_TEST.
6988         (maintenance_info_selftests): Likewise.
6989
6990 2018-01-08  Xavier Roirand  <roirand@adacore.com>
6991
6992         * ada-valprint.c (val_print_packed_array_elements): Use
6993         proper number of elements when printing an array indexed
6994         by an enumeration type.
6995
6996 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
6997
6998         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
6999         (dw2_get_file_names_reader): Adjust.
7000         (lookup_dwo_signatured_type): Adjust.
7001         (lookup_dwp_signatured_type): Adjust.
7002         (lookup_signatured_type): Adjust.
7003         (create_type_unit_group): Adjust.
7004         (get_type_unit_group): Adjust.
7005         (process_psymtab_comp_unit_reader): Adjust.
7006         (build_type_psymtabs_reader): Adjust.
7007         (scan_partial_symbols): Adjust.
7008         (add_partial_symbol): Adjust.
7009         (add_partial_subprogram): Adjust.
7010         (peek_die_abbrev): Adjust.
7011         (fixup_go_packaging): Adjust.
7012         (process_imported_unit_die): Adjust.
7013         (dwarf2_compute_name): Adjust.
7014         (dwarf2_physname): Adjust.
7015         (read_import_statement): Adjust.
7016         (handle_DW_AT_stmt_list): Adjust.
7017         (read_file_scope): Adjust.
7018         (read_func_scope): Adjust.
7019         (read_lexical_block_scope): Adjust.
7020         (read_call_site_scope): Adjust.
7021         (read_variable): Adjust.
7022         (dwarf2_rnglists_process): Adjust.
7023         (dwarf2_ranges_process): Adjust.
7024         (dwarf2_ranges_read): Adjust.
7025         (dwarf2_get_pc_bounds): Adjust.
7026         (dwarf2_record_block_ranges): Adjust.
7027         (dwarf2_add_field): Adjust.
7028         (dwarf2_add_member_fn): Adjust.
7029         (read_structure_type): Adjust.
7030         (process_structure_scope): Adjust.
7031         (read_enumeration_type): Adjust.
7032         (read_array_type): Adjust.
7033         (mark_common_block_symbol_computed): Adjust.
7034         (read_common_block): Adjust.
7035         (read_namespace_type): Adjust.
7036         (read_namespace): Adjust.
7037         (read_module_type): Adjust.
7038         (read_tag_pointer_type): Adjust.
7039         (read_tag_ptr_to_member_type): Adjust.
7040         (read_tag_string_type): Adjust.
7041         (read_subroutine_type): Adjust.
7042         (read_typedef): Adjust.
7043         (read_base_type): Adjust.
7044         (attr_to_dynamic_prop): Adjust.
7045         (read_subrange_type): Adjust.
7046         (read_unspecified_type): Adjust.
7047         (dwarf2_read_abbrevs): Adjust.
7048         (load_partial_dies): Adjust.
7049         (read_partial_die): Adjust.
7050         (find_partial_die): Adjust.
7051         (guess_partial_die_structure_name): Adjust.
7052         (fixup_partial_die): Adjust.
7053         (read_attribute_value): Adjust.
7054         (read_addr_index): Adjust.
7055         (read_addr_index_from_leb128): Adjust.
7056         (read_str_index): Adjust.
7057         (dwarf2_string_attr): Adjust.
7058         (get_debug_line_section): Adjust.
7059         (dwarf_decode_line_header): Adjust.
7060         (lnp_state_machine::check_line_address): Adjust.
7061         (dwarf_decode_lines_1): Adjust.
7062         (dwarf_decode_lines): Adjust.
7063         (dwarf2_start_symtab): Adjust.
7064         (var_decode_location): Adjust.
7065         (new_symbol_full): Adjust.
7066         (dwarf2_const_value_data): Adjust.
7067         (dwarf2_const_value_attr): Adjust.
7068         (dwarf2_const_value): Adjust.
7069         (die_type): Adjust.
7070         (die_containing_type): Adjust.
7071         (build_error_marker_type): Adjust.
7072         (lookup_die_type): Adjust.
7073         (guess_full_die_structure_name): Adjust.
7074         (anonymous_struct_prefix): Adjust.
7075         (determine_prefix): Adjust.
7076         (dwarf2_name): Adjust.
7077         (follow_die_ref_or_sig): Adjust.
7078         (follow_die_offset): Adjust.
7079         (follow_die_ref): Adjust.
7080         (follow_die_sig_1): Adjust.
7081         (follow_die_sig): Adjust.
7082         (get_signatured_type): Adjust.
7083         (get_DW_AT_signature_type): Adjust.
7084         (decode_locdesc): Adjust.
7085         (dwarf_decode_macros): Adjust.
7086         (cu_debug_loc_section): Adjust.
7087         (fill_in_loclist_baton): Adjust.
7088         (dwarf2_symbol_mark_computed): Adjust.
7089         (init_one_comp_unit): Don't assign
7090         dwarf2_cu::dwarf2_per_objfile.
7091         (set_die_type): Adjust.
7092
7093 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7094
7095         * dwarf2read.c (struct mapped_debug_names): Add constructor.
7096         <dwarf2_per_objfile>: New field.
7097         (dwarf2_per_objfile): Remove global.
7098         (get_dwarf2_per_objfile): New function.
7099         (set_dwarf2_per_objfile): New function.
7100         (dwarf2_build_psymtabs_hard): Change objfile parameter to
7101         dwarf2_per_objfile.
7102         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
7103         (read_abbrev_offset): Likewise.
7104         (read_indirect_string): Likewise.
7105         (read_indirect_line_string): Likewise.
7106         (read_indirect_string_at_offset): Likewise.
7107         (read_indirect_string_from_dwz): Likewise.
7108         (dwarf2_find_containing_comp_unit): Change objfile parameter to
7109         dwarf2_per_objfile.
7110         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
7111         (create_all_comp_units): Change objfile parameter to
7112         dwarf2_per_objfile.
7113         (create_all_type_units): Likewise.
7114         (process_queue): Add dwarf2_per_objfile parameter.
7115         (read_and_check_comp_unit_head): Likewise.
7116         (lookup_dwo_unit_in_dwp): Likewise.
7117         (get_dwp_file): Likewise.
7118         (process_cu_includes): Likewise.
7119         (struct free_dwo_file_cleanup_data): New struct.
7120         (dwarf2_has_info): Use get_dwarf2_per_objfile and
7121         set_dwarf2_per_objfile.
7122         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
7123         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
7124         context, adjust calls.
7125         (dw2_instantiate_symtab): Likewise.
7126         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
7127         (dw2_get_cu): Likewise.
7128         (create_cu_from_index_list): Change objfile parameter to
7129         dwarf2_per_objfile.
7130         (create_cus_from_index_list): Get dwarf2_per_objfile from
7131         context, adjust calls.
7132         (create_cus_from_index): Likewise.
7133         (create_signatured_type_table_from_index): Change objfile
7134         parameter to dwarf2_per_objfile.
7135         (create_signatured_type_table_from_debug_names): Change objfile
7136         parameter to dwarf2_per_objfile.
7137         (create_addrmap_from_index): Likewise.
7138         (create_addrmap_from_aranges): Likewise.
7139         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
7140         (dw2_setup): Remove.
7141         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
7142         context.
7143         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
7144         get_dwarf2_per_objfile.
7145         (dw2_forget_cached_source_info): Likewise.
7146         (dw2_map_symtabs_matching_filename): Likewise.
7147         (struct dw2_symtab_iterator) <index>: Remove.
7148         <dwarf2_per_objfile>: New field.
7149         (dw2_symtab_iter_init): Replace index parameter with
7150         dwarf2_per_objfile.
7151         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
7152         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
7153         (dw2_print_stats): Likewise.
7154         (dw2_dump): Likewise.
7155         (dw2_expand_symtabs_for_function): Likewise.
7156         (dw2_expand_all_symtabs): Likewise.
7157         (dw2_expand_symtabs_with_fullname): Likewise.
7158         (dw2_expand_marked_cus): Replace index and objfile parameters
7159         with dwarf2_per_objfile.
7160         (dw_expand_symtabs_matching_file_matcher): Add
7161         dwarf2_per_objfile parameter and adjust calls.
7162         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
7163         adjust calls.
7164         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
7165         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
7166         adjust calls.
7167         (create_cus_from_debug_names_list): Replace objfile parameter
7168         with dwarf2_per_objfile and adjust calls.
7169         (create_cus_from_debug_names): Likewise.
7170         (dwarf2_read_debug_names): Likewise.
7171         (mapped_debug_names::namei_to_name): Adjust call.
7172         (dw2_debug_names_iterator::next): Likewise.
7173         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
7174         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
7175         (dw2_debug_names_dump): Likewise.
7176         (dw2_debug_names_expand_symtabs_for_function): Likewise.
7177         (dw2_debug_names_expand_symtabs_matching): Likewise.
7178         (dwarf2_initialize_objfile): Likewise.
7179         (dwarf2_build_psymtabs): Likewise.
7180         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
7181         this_cu.
7182         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
7183         (read_and_check_comp_unit_head): Likewise.
7184         (read_abbrev_offset): Likewise.
7185         (create_debug_type_hash_table): Likewise.
7186         (create_debug_types_hash_table): Likewise.
7187         (create_all_type_units): Replace objfile parameter with
7188         dwarf2_per_objfile.
7189         (add_type_unit): Add dwarf2_per_objfile parameter.
7190         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
7191         with dwarf2_per_objfile.
7192         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
7193         (lookup_dwp_signatured_type): Likewise.
7194         (lookup_signatured_type): Likewise.
7195         (read_cutu_die_from_dwo): Likewise.
7196         (init_tu_and_read_dwo_dies): Likewise.
7197         (init_cutu_and_read_dies): Likewise.
7198         (init_cutu_and_read_dies_no_follow): Likewise.
7199         (allocate_type_unit_groups_table): Add objfile parameter.
7200         (create_type_unit_group): Use dwarf2_per_objfile from cu.
7201         (get_type_unit_group): Likewise.
7202         (process_psymtab_comp_unit): Update call.
7203         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
7204         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
7205         (print_tu_stats): Likewise.
7206         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
7207         in void* parameter.
7208         (build_type_psymtabs): Change objfile parameter to
7209         dwarf2_per_objfile.
7210         (process_skeletonless_type_unit): Use dwarf2_per_objfile
7211         passed in void* parameter.
7212         (process_skeletonless_type_units): Change objfile parameter to
7213         dwarf2_per_objfile.
7214         (set_partial_user): Likewise.
7215         (dwarf2_build_psymtabs_hard): Likewise.
7216         (read_comp_units_from_section): Likewise.
7217         (create_all_comp_units): Likewise.
7218         (scan_partial_symbols): Update calls.
7219         (add_partial_symbol): Likewise.
7220         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
7221         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
7222         (process_queue): Add dwarf2_per_objfile parameter.
7223         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
7224         (compute_compunit_symtab_includes): Likewise.
7225         (process_cu_includes): Add dwarf2_per_objfile parameter.
7226         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
7227         (process_full_type_unit): Likewise.
7228         (process_imported_unit_die): Update call.
7229         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
7230         (read_file_scope): Likewise.
7231         (allocate_dwo_file_hash_table): Add objfile parameter.
7232         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
7233         (create_cus_hash_table): Likewise.
7234         (create_dwp_hash_table): Likewise.
7235         (create_dwo_unit_in_dwp_v1): Likewise.
7236         (create_dwp_v2_section): Likewise.
7237         (create_dwo_unit_in_dwp_v2): Likewise.
7238         (lookup_dwo_unit_in_dwp): Likewise.
7239         (try_open_dwop_file): Likewise.
7240         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
7241         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
7242         cleanup to include a reference to dwarf2_per_objfile.
7243         (open_dwp_file): Add dwarf2_per_objfile parameter.
7244         (open_and_init_dwp_file): Likewise.
7245         (get_dwp_file): Likewise.
7246         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
7247         (queue_and_load_all_dwo_tus): Update call.
7248         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
7249         data.
7250         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
7251         (dwarf2_ranges_process): Likewise.
7252         (dwarf2_get_pc_bounds): Likewise.
7253         (mark_common_block_symbol_computed): Likewise.
7254         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
7255         (dwarf2_read_abbrevs): Update call.
7256         (read_partial_die): Use dwarf2_per_objfile from cu.
7257         (find_partial_die): Likewise.
7258         (fixup_partial_die): Likewise.
7259         (read_attribute_value): Likewise.
7260         (read_indirect_string_at_offset_from): Add objfile parameter.
7261         (read_indirect_string_at_offset): Add dwarf2_per_objfile
7262         parameter.
7263         (read_indirect_string_from_dwz): Add objfile parameter.
7264         (read_indirect_string): Add objfile parameter.
7265         (read_addr_index_1): Add dwarf2_per_objfile parameter.
7266         (read_addr_index): Use dwarf2_per_objfile from cu.
7267         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
7268         call dw2_setup.
7269         (read_str_index): Use dwarf2_per_objfile from cu.
7270         (get_debug_line_section): Likewise.
7271         (read_formatted_entries): Add dwarf2_per_objfile parameter.
7272         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
7273         (new_symbol_full): Use dwarf2_per_objfile from cu.
7274         (build_error_marker_type): Likewise.
7275         (lookup_die_type): Likewise.
7276         (determine_prefix): Likewise.
7277         (follow_die_offset): Likewise.
7278         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
7279         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
7280         (dwarf2_fetch_die_type_sect_off): Likewise.
7281         (dwarf2_get_die_type): Likewise.
7282         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
7283         (get_signatured_type): Likewise.
7284         (get_DW_AT_signature_type): Likewise.
7285         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
7286         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
7287         (cu_debug_loc_section): Likewise.
7288         (fill_in_loclist_baton): Likewise.
7289         (dwarf2_symbol_mark_computed): Likewise.
7290         (dwarf2_find_containing_comp_unit): Change objfile parameter to
7291         dwarf2_per_objfile.
7292         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
7293         parameter.
7294         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
7295         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
7296         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
7297         (set_die_type): Use dwarf2_free_objfile from cu.
7298         (get_die_type_at_offset): Likewise.
7299         (dwarf2_per_objfile_free): Don't assign global variable.
7300         (debug_names) <constructor>: Add dwarf2_per_objfile
7301         parameter, update m_debugstrlookup construction.
7302         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
7303         parameter.
7304         <m_dwarf2_per_objfile>: New field.
7305         <lookup>: Use m_dwarf2_per_objfile.
7306         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
7307         (psyms_seen_size): Likewise.
7308         (write_gdbindex): Replace objfile parameter with
7309         dwarf2_per_objfile.
7310         (write_debug_names): Likewise.
7311         (write_psymtabs_to_index): Likewise.
7312         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
7313         calls.
7314
7315 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7316
7317         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
7318         <dwarf2_per_objfile>: New field.
7319         (struct dwarf2_per_cu_data) <objfile>: Remove.
7320         <dwarf2_per_objfile>: New field.
7321         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
7322         of objfile.
7323         (create_signatured_type_table_from_index): Likewise.
7324         (create_debug_type_hash_table): Likewise.
7325         (fill_in_sig_entry_from_dwo_entry): Likewise.
7326         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
7327         (create_type_unit_group): Assign dwarf2_per_objfile instead of
7328         objfile.
7329         (create_partial_symtab): Access objfile through
7330         dwarf2_per_objfile.
7331         (process_psymtab_comp_unit_reader): Likewise.
7332         (read_comp_units_from_section): Likewise.
7333         (scan_partial_symbols): Likewise.
7334         (add_partial_symbol): Likewise.
7335         (add_partial_subprogram): Likewise.
7336         (peek_die_abbrev): Likewise.
7337         (fixup_go_packaging): Likewise.
7338         (process_full_comp_unit): Likewise.
7339         (process_full_type_unit): Likewise.
7340         (process_imported_unit_die): Likewise.
7341         (dwarf2_compute_name): Likewise.
7342         (dwarf2_physname): Likewise.
7343         (read_import_statement): Likewise.
7344         (create_cus_hash_table): Assign dwarf2_physname instead of
7345         objfile.
7346         (read_func_scope): Access objfile through dwarf2_per_objfile.
7347         (read_lexical_block_scope): Likewise.
7348         (read_call_site_scope): Likewise.
7349         (read_variable): Likewise.
7350         (dwarf2_rnglists_process): Likewise.
7351         (dwarf2_ranges_process): Likewise.
7352         (dwarf2_ranges_read): Likewise.
7353         (dwarf2_record_block_ranges): Likewise.
7354         (dwarf2_add_field): Likewise.
7355         (dwarf2_add_member_fn): Likewise.
7356         (read_structure_type): Likewise.
7357         (process_structure_scope): Likewise.
7358         (read_enumeration_type): Likewise.
7359         (read_array_type): Likewise.
7360         (read_common_block): Likewise.
7361         (read_namespace_type): Likewise.
7362         (read_namespace): Likewise.
7363         (read_module_type): Likewise.
7364         (read_tag_pointer_type): Likewise.
7365         (read_tag_ptr_to_member_type): Likewise.
7366         (read_tag_string_type): Likewise.
7367         (read_subroutine_type): Likewise.
7368         (read_typedef): Likewise.
7369         (read_base_type): Likewise.
7370         (attr_to_dynamic_prop): Likewise.
7371         (read_subrange_type): Likewise.
7372         (read_unspecified_type): Likewise.
7373         (load_partial_dies): Likewise.
7374         (read_partial_die): Likewise.
7375         (find_partial_die): Likewise.
7376         (guess_partial_die_structure_name): Likewise.
7377         (fixup_partial_die): Likewise.
7378         (read_attribute_value): Likewise.
7379         (read_addr_index_from_leb128): Likewise.
7380         (dwarf2_read_addr_index): Likewise.
7381         (dwarf2_string_attr): Likewise.
7382         (lnp_state_machine::check_line_address): Likewise.
7383         (dwarf_decode_lines_1): Likewise.
7384         (dwarf_decode_lines): Likewise.
7385         (dwarf2_start_symtab): Likewise.
7386         (var_decode_location): Likewise.
7387         (new_symbol_full): Likewise.
7388         (dwarf2_const_value_data): Likewise.
7389         (dwarf2_const_value_attr): Likewise.
7390         (dwarf2_const_value): Likewise.
7391         (die_type): Likewise.
7392         (die_containing_type): Likewise.
7393         (lookup_die_type): Likewise.
7394         (guess_full_die_structure_name): Likewise.
7395         (anonymous_struct_prefix): Likewise.
7396         (dwarf2_name): Likewise.
7397         (follow_die_ref_or_sig): Likewise.
7398         (follow_die_offset): Likewise.
7399         (follow_die_ref): Likewise.
7400         (dwarf2_fetch_die_loc_sect_off): Likewise.
7401         (dwarf2_fetch_constant_bytes): Likewise.
7402         (dwarf2_fetch_die_type_sect_off): Likewise.
7403         (dwarf2_get_die_type): Likewise.
7404         (follow_die_sig): Likewise.
7405         (decode_locdesc): Likewise.
7406         (dwarf2_per_cu_objfile): Likewise.
7407         (dwarf2_per_cu_text_offset): Likewise.
7408         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
7409         objfile.
7410         (set_die_type): Access objfile through
7411         dwarf2_per_objfile.
7412
7413 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7414
7415         * valprint.c (converted_character_d): Remove typedef.
7416         (DEF_VEC_O (converted_character_d)): Remove.
7417         (count_next_character): Use std::vector.
7418         (print_converted_chars_to_obstack): Likewise.
7419         (generic_printstr): Likewise.
7420
7421 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7422
7423         * xml-support.h (struct gdb_xml_value): Add constructor.
7424         <value>: Change type to unique_xmalloc_ptr.
7425         (gdb_xml_value_s): Remove typedef.
7426         (DEF_VEC_O (gdb_xml_value_s)): Remove.
7427         (gdb_xml_element_start_handler): Change parameter type to
7428         std::vector.
7429         (xml_find_attribute): Likewise.
7430         * xml-support.c (xml_find_attribute): Change parameter type to
7431         std::vector and adjust.
7432         (gdb_xml_values_cleanup): Remove.
7433         (gdb_xml_parser::start_element): Adjust to std::vector.
7434         (xinclude_start_include): Change paraeter type to std::vector
7435         and adjust.
7436         * btrace.c (check_xml_btrace_version): Likewise.
7437         (parse_xml_btrace_block): Likewise.
7438         (parse_xml_btrace_pt_config_cpu): Likewise.
7439         (parse_xml_btrace_pt): Likewise.
7440         (parse_xml_btrace_conf_bts): Likewise.
7441         (parse_xml_btrace_conf_pt): Likewise.
7442         * memory-map.c (memory_map_start_memory): Likewise.
7443         (memory_map_start_property): Likewise.
7444         * osdata.c (osdata_start_osdata): Likewise.
7445         (osdata_start_item): Likewise.
7446         (osdata_start_column): Likewise.
7447         * remote.c (start_thread): Likewise.
7448         * solib-aix.c (library_list_start_library): Likewise.
7449         (library_list_start_list): Likewise.
7450         * solib-svr4.c (library_list_start_library): Likewise.
7451         (svr4_library_list_start_list): Likewise.
7452         * solib-target.c (library_list_start_segment): Likewise.
7453         (library_list_start_section): Likewise.
7454         (library_list_start_library): Likewise.
7455         (library_list_start_list): Likewise.
7456         * tracepoint.c (traceframe_info_start_memory): Likewise.
7457         (traceframe_info_start_tvar): Likewise.
7458         * xml-syscall.c (syscall_start_syscall): Likewise.
7459         * xml-tdesc.c (tdesc_start_target): Likewise.
7460         (tdesc_start_feature): Likewise.
7461         (tdesc_start_reg): Likewise.
7462         (tdesc_start_union): Likewise.
7463         (tdesc_start_struct): Likewise.
7464         (tdesc_start_flags): Likewise.
7465         (tdesc_start_enum): Likewise.
7466         (tdesc_start_field): Likewise.
7467         (tdesc_start_enum_value): Likewise.
7468         (tdesc_start_vector): Likewise.
7469
7470 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7471
7472         * extension.h (struct xmethod_worker) <clone>: Remove.
7473         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
7474         Remove.
7475         (python_xmethod_worker::clone): Remove.
7476         * valops.c (find_overload_match): Use std::move instead of
7477         clone.
7478
7479 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7480
7481         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
7482         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
7483         <free_xmethod_worker_data>: Remove.
7484         <get_matching_xmethod_workers>: Chance VEC to std::vector.
7485         <get_xmethod_arg_types>: Remove.
7486         <get_xmethod_result_type>: Remove.
7487         <invoke_xmethod>: Remove.
7488         * extension.c (new_xmethod_worker): Remove.
7489         (clone_xmethod_worker): Remove.
7490         (get_matching_xmethod_workers): Return void, pass std::vector by
7491         pointer.
7492         (get_xmethod_arg_types): Rename to...
7493         (xmethod_worker::get_arg_types): ... this, and adjust.
7494         (get_xmethod_result_type): Rename to...
7495         (xmethod_worker::get_result_type): ... this, and adjust.
7496         (invoke_xmethod): Remove.
7497         (free_xmethod_worker): Remove.
7498         (free_xmethod_worker_vec): Remove.
7499         * extension.h (enum ext_lang_rc): Move here from
7500         extension-priv.h.
7501         (struct xmethod_worker): Add constructor and destructor.
7502         <data>: Remove.
7503         <value>: Remove.
7504         <invoke, clone, do_get_result_type, do_get_arg_types>: New
7505         virtual pure methods.
7506         <get_arg_types, get_result_type>: New methods.
7507         (xmethod_worker_ptr): Remove typedef.
7508         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
7509         (xmethod_worker_vec): Remove typedef.
7510         (xmethod_worker_up): New typedef.
7511         (invoke_xmethod): Remove.
7512         (clone_xmethod_worker): Remove.
7513         (free_xmethod_worker): Remove.
7514         (free_xmethod_worker_vec): Remove.
7515         (get_xmethod_arg_types): Remove.
7516         (get_xmethod_result_type): Remove.
7517         * valops.c (find_method_list): Use std::vector, don't use
7518         intermediate vector.
7519         (value_find_oload_method_list): Use std::vector.
7520         (find_overload_match): Use std::vector.
7521         (find_oload_champ): Use std::vector.
7522         * value.c (value_free): Use operator delete.
7523         (value_of_xmethod): Rename to...
7524         (value_from_xmethod): ... this.  Don't assign
7525         xmethod_worker::value, take rvalue-reference.
7526         (result_type_of_xmethod): Adjust.
7527         (call_xmethod): Adjust.
7528         * value.h: Include extension.h.
7529         (struct xmethod_worker): Don't forward-declare.
7530         (value_of_xmethod): Rename to...
7531         (value_from_xmethod): ... this, take rvalue-reference.
7532         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
7533         (struct python_xmethod_worker): ... this, add constructor and
7534         destructor.
7535         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
7536         (gdbpy_free_xmethod_worker_data): Rename to...
7537         (python_xmethod_worker::~python_xmethod_worker): ... this and
7538         adjust.
7539         (gdbpy_clone_xmethod_worker_data): Rename to...
7540         (python_xmethod_worker::clone): ... this and adjust.
7541         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
7542         temporary vector.
7543         (gdbpy_get_xmethod_arg_types): Rename to...
7544         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
7545         (gdbpy_get_xmethod_result_type): Rename to...
7546         (python_xmethod_worker::do_get_result_type): ... this and
7547         adjust.
7548         (gdbpy_invoke_xmethod): Rename to...
7549         (python_xmethod_worker::invoke): ... this and adjust.
7550         (new_python_xmethod_worker): Rename to...
7551         (python_xmethod_worker::python_xmethod_worker): ... this and
7552         adjust.
7553         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
7554         Remove.
7555         (gdbpy_free_xmethod_worker_data): Remove.
7556         (gdbpy_get_matching_xmethod_workers): Use std::vector.
7557         (gdbpy_get_xmethod_arg_types): Remove.
7558         (gdbpy_get_xmethod_result_type): Remove.
7559         (gdbpy_invoke_xmethod): Remove.
7560         * python/python.c (python_extension_ops): Remove obsolete
7561         callbacks.
7562
7563 2018-01-05  Pedro Alves  <palves@redhat.com>
7564
7565         PR gdb/18653
7566         * common/signals-state-save-restore.c
7567         (save_original_signals_state): New parameter 'quiet'.  Warn if we
7568         find a custom handler preinstalled, instead of internal erroring.
7569         But only warn if !quiet.
7570         * common/signals-state-save-restore.h
7571         (save_original_signals_state): New parameter 'quiet'.
7572         * main.c (captured_main_1): Move save_original_signals_state call
7573         after option handling, and pass QUIET.
7574
7575 2018-01-05  Pedro Alves  <palves@redhat.com>
7576
7577         * spu-tdep.c (spu_catch_start): Pass
7578         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
7579
7580 2018-01-05  Pedro Alves  <palves@redhat.com>
7581
7582         PR gdb/22670
7583         * ada-lang.c (literal_symbol_name_matcher): New function.
7584         (ada_get_symbol_name_matcher): Use it for
7585         symbol_name_match_type::SEARCH_NAME.
7586         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
7587         it down instead of assuming symbol_name_match_type::FULL.
7588         * block.h (block_lookup_symbol): New parameter 'match_type'.
7589         * c-valprint.c (print_unpacked_pointer): Use
7590         lookup_symbol_search_name instead of lookup_symbol.
7591         * compile/compile-object-load.c (get_out_value_type): Pass down
7592         symbol_name_match_type::SEARCH_NAME.
7593         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
7594         symbol_name_match_type::FULL.
7595         * cp-support.c (cp_get_symbol_name_matcher): Handle
7596         symbol_name_match_type::SEARCH_NAME.
7597         * infrun.c (insert_exception_resume_breakpoint): Use
7598         lookup_symbol_search_name.
7599         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
7600         * psymtab.c (maintenance_check_psymtabs): Use
7601         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
7602         * stack.c (print_frame_args): Use lookup_symbol_search_name and
7603         SYMBOL_SEARCH_NAME.
7604         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
7605         if symbol_name_match_type::SEARCH_NAME.
7606         (lookup_symbol_in_language): Pass down
7607         symbol_name_match_type::FULL.
7608         (lookup_symbol_search_name): New.
7609         (lookup_language_this): Pass down
7610         symbol_name_match_type::SEARCH_NAME.
7611         (lookup_symbol_aux, lookup_local_symbol): New parameter
7612         'match_type'.  Pass it down.
7613         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
7614         (lookup_symbol_search_name): New declaration.
7615         (lookup_symbol_in_block): New 'match_type' parameter.
7616
7617 2018-01-05  Pedro Alves  <palves@redhat.com>
7618
7619         PR gdb/22670
7620         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
7621         ada_lookup_symbol.
7622         (ada_lookup_symbol): Reimplement in terms of
7623         ada_lookup_symbol_list, bits factored out from
7624         ada_lookup_encoded_symbol.
7625
7626 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7627
7628         * ada-exp.y (write_object_renaming): When subscripting an array
7629         using a symbol as the index, pass the block in call to
7630         ada_lookup_encoded_symbol when looking that symbol up.
7631
7632 2018-01-05  Jerome Guitton  <guitton@adacore.com>
7633
7634         * ada-lang.c (ada_array_length): Use ada_index_type instead of
7635         TYPE_INDEX_TYPE.
7636
7637 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7638
7639         * ada-lang.c (ada_to_fixed_value_create): Add handling of
7640         the case where VALUE_LVAL (val0) is not lval_memory.
7641
7642 2018-01-05  Xavier Roirand  <roirand@adacore.com>
7643
7644         * ada-valprint.c (print_optional_low_bound): Handle
7645         character-indexed array printing like boolean-indexed array
7646         printing.
7647
7648 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7649
7650         * NEWS: Create a new section for the next release branch.
7651         Rename the section of the current branch, now that it has
7652         been cut.
7653
7654 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7655
7656         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
7657         * version.in: Bump version to 8.1.50.DATE-git.
7658
7659 2018-01-03  Xavier Roirand  <roirand@adacore.com>
7660
7661         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
7662         Add field.
7663         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
7664         Add field.
7665         (default_exception_support_info) <catch_handlers_sym>: Add field.
7666         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
7667         (ada_exception_name_addr_1): Add "catch handlers" handling.
7668         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
7669         Update all callers.
7670         (create_excep_cond_exprs) <ex>: Add parameter.
7671         (re_set_exception): Update create_excep_cond_exprs call.
7672         (print_it_exception, print_one_exception, print_mention_exception)
7673         (print_recreate_exception): Add "catch handler" handling.
7674         (allocate_location_catch_handlers, re_set_catch_handlers)
7675         (check_status_catch_handlers, print_it_catch_handlers)
7676         (print_one_catch_handlers, print_mention_catch_handlers)
7677         (print_recreate_catch_handlers): New function.
7678         (catch_handlers_breakpoint_ops): New variable.
7679         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
7680         Add parameter.  Add "catch handler" handling.
7681         (ada_exception_sym_name, ada_exception_breakpoint_ops):
7682         Add "catch handler" handling.
7683         (ada_exception_catchpoint_cond_string): Add "catch handler"
7684         handling.
7685         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
7686         call.
7687         (catch_ada_handlers_command): New function.
7688         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
7689         operations structure.
7690         (_initialize_ada_language): Add "catch handlers" command entry.
7691         * NEWS: Document "catch handlers" feature.
7692
7693 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7694
7695         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
7696         account when creating the array type of the slice.
7697         (ada_value_slice): Likewise.
7698
7699 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7700
7701         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
7702         New enum value.
7703         (create_array_type_with_stride): Add byte_stride_prop parameter.
7704         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
7705         New parameter.  Update all callers in this file.
7706         (array_type_has_dynamic_stride): New function.
7707         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
7708         of arrays with dynamic byte strides.
7709         * dwarf2read.c (read_array_type): Add support for dynamic
7710         DW_AT_byte_stride attributes.
7711
7712 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7713
7714         * dwarf2read.c (read_unspecified_type): Treat
7715         DW_TAG_enumeration_type DIEs from Ada units as stubs.
7716
7717 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7718
7719         Update copyright year range in all GDB files.
7720
7721 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7722
7723         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
7724         and gdb/testsuite/gdb.base/step-line.c.
7725
7726 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7727
7728         * copyright.py (main): Dump the contents of
7729         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
7730         even if BY_HAND is empty.
7731
7732 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7733
7734         * top.c (print_gdb_version): Update Copyright year in version
7735         message.
7736
7737 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7738
7739         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
7740
7741 For older changes see ChangeLog-2017.
7742 \f
7743 Local Variables:
7744 mode: change-log
7745 left-margin: 8
7746 fill-column: 74
7747 version-control: never
7748 coding: utf-8
7749 End: