gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-layout.h (tui/tui-layout): Return void.
   4         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
   5
   6 2019-07-17  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-layout.c (show_source_disasm_command, show_data):
   9         Update.
  10         (reset_locator): Remove.
  11         (show_source_or_disasm_and_command): Update.
  12
  13 2019-07-17  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-source.c (tui_source_window_base::reset): Remove
  16         win_type parameter.
  17         * tui/tui-layout.c (make_command_window, make_source_window)
  18         (make_disasm_window, make_data_window)
  19         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
  20         (reset_locator, show_source_or_disasm_and_command): Update.
  21         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
  22         win_type parameter.
  23         (struct tui_source_window_base) <reset>: Likewise.
  24
  25 2019-07-17  Tom Tromey  <tom@tromey.com>
  26
  27         * tui/tui-layout.c (show_source_disasm_command): Use
  28         reset_locator.
  29         (reset_locator): New function.
  30         (init_and_make_win): Remove.
  31         (show_source_or_disasm_and_command): Use reset_locator.
  32
  33 2019-07-17  Tom Tromey  <tom@tromey.com>
  34
  35         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
  36         condition.
  37         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
  38         Remove condition.
  39         * tui/tui-source.c (tui_source_window_base::reset): New method.
  40         * tui/tui-layout.c (make_command_window): Don't call
  41         init_and_make_win.
  42         (make_source_window, make_disasm_window): Don't call
  43         make_source_or_disasm_window.
  44         (make_data_window): Don't call init_and_make_win.  Change calling
  45         convention.
  46         (show_source_disasm_command, show_data): Simplify.
  47         (make_source_or_disasm_window): Remove.
  48         (show_source_or_disasm_and_command): Simplify.
  49         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
  50         (struct tui_source_window_base) <reset>: Likewise.
  51         <execution_info>: Remove initializer.
  52         * tui/tui-data.c (tui_source_window_base): Initialize
  53         execution_info.
  54
  55 2019-07-17  Tom Tromey  <tom@tromey.com>
  56
  57         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
  58         variable.
  59
  60 2019-07-17  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui.c (tui_rl_other_window): Update.
  63         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
  64         superclass method first.  Always iterate over regs_content.
  65         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
  66         method.
  67         * tui/tui-win.c (tui_set_focus_command): Update.
  68
  69 2019-07-17  Tom Tromey  <tom@tromey.com>
  70
  71         * tui/tui-win.c (tui_set_focus_command): Rename from
  72         tui_set_focus.  Call tui_enable.
  73         (tui_set_focus_command): Remove.
  74
  75 2019-07-17  Tom Tromey  <tom@tromey.com>
  76
  77         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
  78         refresh_window.
  79         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
  80         touchwin.
  81         (tui_data_window::refresh_window): Call refresh_window on data
  82         items.  Always call superclass refresh_window.
  83         (tui_win_info::refresh): Remove.
  84         (tui_source_window_base::refresh_window): Update.
  85         (tui_refresh_all): Update.
  86         * tui/tui-layout.c (show_source_disasm_command): Remove call to
  87         refresh_window.
  88         (show_source_or_disasm_and_command): Likewise.
  89         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
  90         (struct tui_source_window_base) <refresh>: Likewise.
  91
  92 2019-07-17  Tom Tromey  <tom@tromey.com>
  93
  94         * tui/tui-winsource.c (tui_clear_source_content)
  95         (tui_show_source_content): Update.
  96         * tui/tui-source.c (tui_source_window::showing_source_p): Check
  97         whether content is empty.
  98         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
  99         Remove.
 100
 101 2019-07-17  Tom Tromey  <tom@tromey.com>
 102
 103         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 104         window's contents.
 105         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 106         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 107
 108 2019-07-17  Tom Tromey  <tom@tromey.com>
 109
 110         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 111         (struct tui_data_item_window): Update.
 112
 113 2019-07-17  Tom Tromey  <tom@tromey.com>
 114
 115         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 116         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 117         defines.
 118
 119 2019-07-17  Tom Tromey  <tom@tromey.com>
 120
 121         * tui/tui-winsource.h (tui_erase_source_content)
 122         (tui_clear_source_content): Remove "display_prompt" parameter.
 123         * tui/tui-winsource.c (tui_update_source_window_as_is)
 124         (tui_update_source_windows_with_addr): Update.
 125         (tui_clear_source_content): Remove "display_prompt" parameter.
 126         (tui_erase_source_content): Likewise.  Simplify.
 127         (tui_show_source_content): Update.
 128         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 129         * tui/tui-stack.c (tui_show_frame_info): Update.
 130         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 131         Remove defines.
 132
 133 2019-07-17  Tom Tromey  <tom@tromey.com>
 134
 135         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 136         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 137         parameter.
 138         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 139         parameter.
 140
 141 2019-07-17  Tom Tromey  <tom@tromey.com>
 142
 143         * tui/tui-winsource.c (tui_clear_source_content)
 144         (tui_show_source_content, tui_show_exec_info_content)
 145         (tui_clear_exec_info_content): Update.
 146         * tui/tui-stack.c (tui_show_locator_content): Update.
 147         (tui_show_frame_info): Update.
 148         * tui/tui-source.h (tui_source_window): Don't declare.
 149         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 150         from tui_source_is_displayed.
 151         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 152         Remove field.
 153         (struct tui_source_window_base) <content_in_use>: New field.  Now
 154         bool.
 155         (struct tui_source_window) <showing_source_p>: New method.
 156         (TUI_SRC_WIN): Change cast.
 157         * tui/tui-data.c (tui_initialize_static_data): Update.
 158
 159 2019-07-17  Tom Tromey  <tom@tromey.com>
 160
 161         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 162         location_matches_p.
 163         * tui/tui-source.c (tui_source_window::location_matches_p): New
 164         method.
 165         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 166         method.
 167         * tui/tui-data.h (struct tui_source_window_base)
 168         <location_matches_p>: New method.
 169         (struct tui_source_window, struct tui_disasm_window)
 170         <location_matches_p>: Likewise.
 171
 172 2019-07-17  Tom Tromey  <tom@tromey.com>
 173
 174         * tui/tui-win.c (tui_set_win_height_command): Rename from
 175         tui_set_win_height.
 176         (tui_set_win_height_command): Remove.
 177
 178 2019-07-17  Tom Tromey  <tom@tromey.com>
 179
 180         * tui/tui-source.c (tui_source_window): New constructor.  Add
 181         observer.
 182         (~tui_source_window): New destructor.
 183         (tui_source_window::style_changed): New method.
 184         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 185         (tui_attach_detach_observers): Update.
 186         * tui/tui-data.h (struct tui_source_window): Make constructor not
 187         inline.  Add destructor.
 188         (struct tui_source_window) <style_changed>: New method.
 189         <m_observable>: New member.
 190
 191 2019-07-17  Tom Tromey  <tom@tromey.com>
 192
 193         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 194         * tui/tui-win.c (tui_resize_all): Fix typo.
 195
 196 2019-07-17  Tom Tromey  <tom@tromey.com>
 197
 198         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 199         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 200         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 201         * tui/tui-win.c (window_name_completer): Use foreach.
 202         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 203         (update_tab_width): Likewise.
 204         * tui/tui-layout.c (show_layout): Update.
 205         * tui/tui-data.h (class tui_window_iterator): New.
 206         (struct all_tui_windows): New.
 207         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 208
 209 2019-07-17  Tom Tromey  <tom@tromey.com>
 210
 211         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 212         parameter.  Don't reference globals.
 213         (tui_reg_command): Update.
 214
 215 2019-07-17  Tom Tromey  <tom@tromey.com>
 216
 217         * tui/tui-regs.c (tui_show_registers): Simplify.
 218
 219 2019-07-17  Tom Tromey  <tom@tromey.com>
 220
 221         * tui/tui-regs.c (tui_show_registers): Update.
 222         (tui_show_register_group): Add win_info parameter.
 223
 224 2019-07-17  Tom Tromey  <tom@tromey.com>
 225
 226         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 227         Rename from tui_display_reg_element_at_line.
 228         (tui_data_window::display_registers_from_line): Update.
 229         * tui/tui-data.h (struct tui_data_window)
 230         <display_reg_element_at_line>: New method.
 231
 232 2019-07-17  Tom Tromey  <tom@tromey.com>
 233
 234         * tui/tui-regs.h (tui_display_registers_from)
 235         (tui_display_registers_from_line): Don't declare.
 236         * tui/tui-windata.c (tui_data_window::display_all_data)
 237         (tui_data_window::refresh_all)
 238         (tui_data_window::do_scroll_vertical): Update.
 239         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 240         from tui_display_registers_from.
 241         (tui_display_reg_element_at_line): Update.
 242         (tui_data_window::display_registers_from_line): Rename from
 243         tui_display_registers_from_line.
 244         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 245         display_registers_from_line>: New methods.
 246
 247 2019-07-17  Tom Tromey  <tom@tromey.com>
 248
 249         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 250         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 251         from tui_erase_data_content.
 252         (tui_data_window::display_all_data)
 253         (tui_data_window::refresh_all)
 254         (tui_data_window::do_scroll_vertical): Update.
 255         * tui/tui-regs.c (tui_show_registers): Update.
 256         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 257         New method.
 258
 259 2019-07-17  Tom Tromey  <tom@tromey.com>
 260
 261         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 262         declare.
 263         * tui/tui-windata.c
 264         (tui_data_window::delete_data_content_windows): Rename from
 265         tui_delete_data_content_windows.
 266         (tui_data_window::display_all_data)
 267         (tui_data_window::do_scroll_vertical): Update.
 268         * tui/tui-data.h (struct tui_data_window)
 269         <delete_data_content_windows>: New method.
 270
 271 2019-07-17  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 274         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 275
 276 2019-07-17  Tom Tromey  <tom@tromey.com>
 277
 278         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 279         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 280         from tui_display_all_data.
 281         * tui/tui-win.c
 282         (tui_data_window::do_make_visible_with_new_height): Update.
 283         * tui/tui-regs.c (tui_show_registers): Update.
 284         * tui/tui-layout.c (tui_set_layout): Update.
 285         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 286         method.
 287
 288 2019-07-17  Tom Tromey  <tom@tromey.com>
 289
 290         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 291         * tui/tui-windata.c (tui_display_data_from): Remove.
 292         (tui_data_window::refresh_all): Update.
 293
 294 2019-07-17  Tom Tromey  <tom@tromey.com>
 295
 296         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 297         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 298         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 299         tui_display_registers_from_line.
 300         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 301         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 302         "force_display" parameter.
 303
 304 2019-07-17  Tom Tromey  <tom@tromey.com>
 305
 306         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 307         declare.
 308         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 309         Rename from tui_first_reg_element_no_inline.
 310         (tui_display_reg_element_at_line)
 311         (tui_display_registers_from_line): Update.
 312         * tui/tui-data.h (struct tui_data_window)
 313         <first_reg_element_no_inline>: New method.
 314
 315 2019-07-17  Tom Tromey  <tom@tromey.com>
 316
 317         * tui/tui-windata.c (tui_display_data_from)
 318         (tui_data_window::do_scroll_vertical): Update.
 319         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 320         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 321         Rename from tui_line_from_reg_element_no.
 322         (tui_display_registers_from_line): Update.
 323         * tui/tui-data.h (struct tui_data_window)
 324         <line_from_reg_element_no>: New method.
 325
 326 2019-07-17  Tom Tromey  <tom@tromey.com>
 327
 328         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 329         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 330         tui_last_regs_line_no.
 331         (tui_display_reg_element_at_line)
 332         (tui_display_registers_from_line): Update.
 333         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 334         method.
 335
 336 2019-07-17  Tom Tromey  <tom@tromey.com>
 337
 338         PR tui/24722:
 339         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 340         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 341         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 342         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 343         (tui_update_breakpoint_info): Likewise.
 344         * tui/tui-hooks.c (tui_event_create_breakpoint)
 345         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 346         Update.
 347
 348 2019-07-17  Tom Tromey  <tom@tromey.com>
 349
 350         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 351
 352 2019-07-17  Tom Tromey  <tom@tromey.com>
 353
 354         * tui/tui-winsource.c (tui_update_source_window_as_is)
 355         (tui_update_source_windows_with_addr): Update.
 356         * tui/tui-source.h (tui_set_source_content)
 357         (tui_show_symtab_source): Add "win_info" parameter.
 358         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 359         parameter.
 360         (tui_show_symtab_source): Likewise.
 361
 362 2019-07-17  Tom Tromey  <tom@tromey.com>
 363
 364         * tui/tui-wingeneral.c
 365         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 366
 367 2019-07-17  Tom Tromey  <tom@tromey.com>
 368
 369         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 370         (struct tui_cmd_window) <can_scroll>: New method.
 371         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 372         method.
 373
 374 2019-07-17  Tom Tromey  <tromey@adacore.com>
 375
 376         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 377         do_field_signed>: Rename.  Change type of "value".
 378         * ui-out.c (ui_out::field_signed): Rename from field_int.
 379         Change type of "value".
 380         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 381         type of "value".
 382         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 383         do_field_int.  Change type of "value".
 384         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 385         do_field_int.  Change type of "value".
 386         * tracepoint.c (trace_status_mi, tfind_1)
 387         (print_one_static_tracepoint_marker): Update.
 388         * thread.c (print_thread_info_1, print_selected_thread_frame):
 389         Update.
 390         * stack.c (print_frame, print_frame_info): Update.
 391         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 392         Update.
 393         * source.c (print_source_lines_base): Update.
 394         * skip.c (info_skip_command): Update.
 395         * record-btrace.c (btrace_ui_out_decode_error)
 396         (btrace_call_history_src_line): Update.
 397         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 398         Update.
 399         * progspace.c (print_program_space): Update.
 400         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 401         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 402         do_field_int.  Change type of "value".
 403         * mi/mi-out.c (mi_ui_out::do_table_begin)
 404         (mi_ui_out::do_table_header): Update.
 405         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 406         type of "value".
 407         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 408         (mi_cmd_data_list_changed_registers, output_register)
 409         (mi_cmd_data_read_memory, mi_load_progress)
 410         (mi_cmd_trace_frame_collected): Update.
 411         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 412         Update.
 413         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 414         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 415         (mi_cmd_var_list_children, varobj_update_one): Update.
 416         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 417         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 418         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 419         * inferior.c (print_inferior): Update.
 420         * gdb_bfd.c (print_one_bfd): Update.
 421         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 422         Update.
 423         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 424         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 425         do_field_int.  Change type of "value".
 426         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 427         do_field_int.  Change type of "value".
 428         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 429         (print_one_breakpoint_location, print_it_catch_fork)
 430         (print_one_catch_fork, print_it_catch_vfork)
 431         (print_one_catch_vfork, print_it_catch_solib)
 432         (print_it_catch_exec, print_it_ranged_breakpoint)
 433         (print_mention_watchpoint, print_mention_masked_watchpoint)
 434         (bkpt_print_it, update_static_tracepoint): Update.
 435         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 436         * break-catch-syscall.c (print_it_catch_syscall): Update.
 437         * ada-tasks.c (print_ada_task_info): Update.
 438         * ada-lang.c (print_it_exception, print_mention_exception):
 439         Update.
 440
 441 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 442
 443         PR breakpoints/24541
 444         * gdbarch.c: Regenerate.
 445         * gdbarch.h: Regenerate.
 446         * gdbarch.sh: Adjust return type and parameter types for
 447         'stap_adjust_register'.
 448         (i386_stap_adjust_register): Adjust signature and return new
 449         register name.
 450         * stap-probe.c (stap_parse_register_operand): Adjust use of
 451         'gdbarch_stap_adjust_register'.
 452
 453 2019-07-17  Tom Tromey  <tromey@adacore.com>
 454
 455         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 456         declare VEC.
 457         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 458         std::vector.
 459         (struct s390_process_info): Add initializers.
 460         (s390_add_process): Use new.
 461         (s390_linux_nat_target::low_forget_process): Use delete.
 462         (s390_linux_nat_target::low_new_fork)
 463         (s390_linux_nat_target::stopped_by_watchpoint)
 464         (s390_linux_nat_target::low_prepare_to_resume)
 465         (s390_linux_nat_target::insert_watchpoint)
 466         (s390_linux_nat_target::insert_hw_breakpoint)
 467         (s390_linux_nat_target::remove_watchpoint)
 468         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 469
 470 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 471
 472         * aarch64-fbsd-nat.c: Include regcache.h.
 473         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 474         argument.
 475         (aarch64_fbsd_nat_target::fetch_registers)
 476         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 477         variable.
 478         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 479
 480 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 481
 482         * fbsd-nat.c: Include gdbarch.h.
 483
 484 2019-07-15  Tom Tromey  <tromey@adacore.com>
 485
 486         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 487
 488 2019-07-15  Tom Tromey  <tromey@adacore.com>
 489
 490         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 491         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 492         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 493         * cli-out.c (cli_ui_out::do_field_int): New method.
 494         * ui-out.c (ui_out::field_unsigned): New method.
 495         * symfile.c (generic_load): Use field_unsigned.
 496         (print_transfer_performance): Likewise.
 497         * record-btrace.c (ui_out_field_uint): Remove.
 498         (btrace_call_history_insn_range, btrace_call_history): Use
 499         field_unsigned.
 500         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 501         field_unsigned.
 502         * ui-out.h (class ui_out) <field_unsigned>: New method.
 503         <do_field_unsigned>: Likewise.
 504
 505 2019-07-15  Tom Tromey  <tromey@adacore.com>
 506
 507         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 508         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 509         * target.c (flash_erase_command): Use field_string.
 510         * infrun.c (print_signal_received_reason): Use field_string.
 511         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 512         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 513         field_string.
 514         * ada-tasks.c (print_ada_task_info): Use field_string.
 515
 516 2019-07-15  Tom Tromey  <tromey@adacore.com>
 517
 518         * target.c (flash_erase_command): Use field_core_addr.
 519         * symfile.c (generic_load): Use field_core_addr.
 520         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 521         Use field_core_addr.
 522         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 523         field_core_addr.
 524
 525 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 526
 527         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 528         value if its desired type is smaller than a CORE_ADDR and signed.
 529
 530 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 531
 532         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 533         of changes to field names, and use new is_reference field to
 534         decide if a property is a reference or not.
 535         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 536         field.
 537         (struct dwarf2_property_baton): Update header comment, rename
 538         'referenced_type' to 'property_type' and update comments.
 539         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 540         default property type, store in property baton, update to take
 541         accound of renamed field.
 542         (read_func_scope): Update call to attr_to_dynamic_prop.
 543         (read_array_type): Likewise.
 544         (dwarf2_per_cu_addr_sized_int_type): New function.
 545         (read_subrange_index_type): Move type finding code to
 546         dwarf2_per_cu_addr_sized_int_type.
 547         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 548         (dwarf2_per_cu_addr_type): New function.
 549         (set_die_type): Update calls to attr_to_dynamic_prop.
 550
 551 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 552
 553         * dwarf2read.c (read_subrange_index_type): New function.
 554         (read_subrange_type): Move code into new function and call it.
 555         * gdbtypes.c (create_range_type): Add some asserts.
 556
 557 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 558
 559         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 560         update return statements.
 561         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 562         declaration, and update comment to match.
 563         * gdbtypes.c (resolve_dynamic_array): Update call to
 564         dwarf2_evaluate_property to match new return type.
 565
 566 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 567
 568         * valarith.c (value_subscripted_rvalue): Change lowerbound
 569         parameter type from int to LONGEST.
 570         * value.h (value_subscripted_rvalue): Likewise in declaration.
 571
 572 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 573
 574         * cli/cli-utils.c (info_print_command_completer): New function.
 575         * cli/cli-utils.h: Add 'completer.h' include, and forward
 576         declaration for 'struct cmd_list_element'.
 577         (info_print_command_completer): Declare.
 578         * stack.c (_initialize_stack): Add completer for 'info locals' and
 579         'info args'.
 580         * symtab.c (_initialize_symtab): Add completer for 'info
 581         variables' and 'info functions'.
 582         * NEWS: Mention completion for additional info commands.
 583
 584 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 585
 586         * cli/cli-utils.c (extract_info_print_args): Delete.
 587         (extract_arg_maybe_quoted): Delete.
 588         (info_print_options_defs): New variable.
 589         (make_info_print_options_def_group): New function.
 590         (extract_info_print_options): Define new function.
 591         * cli/cli-utils.h (extract_info_print_args): Delete.
 592         (struct info_print_options): New structure.
 593         (extract_info_print_options): Declare new function.
 594         * stack.c (info_locals_command): Update to use new
 595         extract_info_print_options, also add a header comment.
 596         (info_args_command): Likewise.
 597         * symtab.c (info_variables_command): Likewise.
 598         (info_functions_command): Likewise.
 599
 600 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 601
 602         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 603         to extract string arguments.
 604         * common/common-utils.c (extract_string_maybe_quoted): New function.
 605         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 606
 607 2019-07-11  Tom Tromey  <tromey@adacore.com>
 608
 609         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 610         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 611         * top.h (gdbinit): Don't declare.
 612         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 613         into...
 614         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 615         * top.c (gdb_init): Don't call init_cli_cmds.
 616         (gdbinit): Remove.
 617         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 618
 619 2019-07-11  Tom Tromey  <tromey@adacore.com>
 620
 621         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 622         after it has been moved.
 623
 624 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 625
 626         * valops.c (value_must_coerce_to_target): Change return type to
 627         bool.
 628         * value.h (value_must_coerce_to_target): Likewise.
 629
 630 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 631
 632         * breakpoint.c (is_hardware_watchpoint): Remove
 633         forward-declaration.
 634         (is_masked_watchpoint): Change return type to bool.
 635         (is_tracepoint): Likewise.
 636         (is_breakpoint): Likewise.
 637         (is_hardware_watchpoint): Likewise.
 638         (is_watchpoint): Likewise.
 639         (is_no_memory_software_watchpoint): Likewise.
 640         (is_catchpoint): Likewise.
 641         (breakpoint_1): Make FILTER parameter's return type bool.
 642         is_masked_watchpoint): Change return type to bool.
 643         (save_breakpoints): Make FILTER parameter's return type bool.
 644         * breakpoint.h (is_breakpoint): Change return type to bool.
 645         (is_watchpoint): Likewise.
 646         (is_catchpoint): Likewise.
 647         (is_tracepoint): Likewise.
 648
 649 2019-07-10  Tom Tromey  <tom@tromey.com>
 650
 651         * defs.h: Don't include gdbarch.h.
 652         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 653         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 654         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 655         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 656         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 657         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 658         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 659         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 660         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 661         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 662         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 663         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 664         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 665         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 666         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 667         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 668         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 669         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 670         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 671         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 672         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 673         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 674         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 675         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 676         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 677         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 678         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 679
 680 2019-07-10  Tom Tromey  <tromey@adacore.com>
 681
 682         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 683         * breakpoint.c (init_ada_exception_breakpoint): Register as
 684         bp_catchpoint.
 685         (print_one_breakpoint_location, print_one_breakpoint): Use
 686         is_ada_exception_catchpoint.
 687         * ada-lang.c (class ada_catchpoint_location): Pass
 688         bp_loc_software_breakpoint to bp_location constructor.
 689         (is_ada_exception_catchpoint): New function.
 690
 691 2019-07-10  Tom Tromey  <tromey@adacore.com>
 692
 693         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 694         VEC.
 695         (struct arm_exidx_entry): New method operator<.
 696         (struct arm_exidx_data) <section_maps>: Change type.
 697         (arm_exidx_data_free): Remove.
 698         (arm_exidx_data_key): Change type.  Move lower.
 699         (arm_exidx_new_objfile): Update.
 700         (arm_compare_exidx_entries): Remove.
 701         (arm_find_exidx_entry, _initialize_arm_tdep)
 702
 703 2019-07-10  Tom Tromey  <tromey@adacore.com>
 704
 705         * solib-spu.c (ocl_program_data_key): Change type.
 706         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 707         Update.
 708
 709 2019-07-10  Tom Tromey  <tromey@adacore.com>
 710
 711         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 712         (struct solib_aix_inferior_data) <library_list>: Change type.
 713         (solib_aix_inferior_data_handle): Change type.
 714         (get_solib_aix_inferior_data): Update.
 715         (solib_aix_free_library_list): Remove.
 716         (library_list_start_library): Update.
 717         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 718         return type.
 719         (solib_aix_get_library_list)
 720         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 721         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 722
 723 2019-07-10  Tom Tromey  <tromey@adacore.com>
 724
 725         * solib-dsbt.c (struct dsbt_info): Add initializers.
 726         (solib_dsbt_pspace_data): Change type.
 727         (dsbt_pspace_data_cleanup): Remove.
 728         (get_dsbt_info, _initialize_dsbt_solib): Update.
 729
 730 2019-07-10  Tom Tromey  <tromey@adacore.com>
 731
 732         * spu-tdep.c (spu_overlay_data): Change type.
 733         (spu_get_overlay_table, spu_overlay_new_objfile)
 734         (_initialize_spu_tdep): Update.
 735
 736 2019-07-10  Tom Tromey  <tromey@adacore.com>
 737
 738         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 739         destructor.
 740         (dbx_objfile_data_key): Change type and declare later.
 741         (DBX_SYMFILE_INFO): Rewrite.
 742         * dbxread.c (dbx_objfile_data_key): Change type.
 743         (dbx_symfile_init): Update.
 744         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 745         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 746         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 747
 748 2019-07-10  Tom Tromey  <tromey@adacore.com>
 749
 750         * jit.c (jit_program_space_key): Change type.  Move lower.
 751         (get_jit_program_space_data): Update.
 752         (jit_program_space_data_cleanup): Remove.
 753         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 754         Update.
 755         (struct jit_program_space_data): Add initializers.
 756
 757 2019-07-10  Tom Tromey  <tromey@adacore.com>
 758
 759         * solib-darwin.c (struct darwin_info): Add initializers.
 760         (solib_darwin_pspace_data): Change type.
 761         (darwin_pspace_data_cleanup): Remove.
 762         (get_darwin_info, _initialize_darwin_solib): Update.
 763
 764 2019-07-10  Tom Tromey  <tromey@adacore.com>
 765
 766         * remote-sim.c (struct sim_inferior_data): Add initializers,
 767         constructor, and destructor.
 768         (sim_inferior_data_key): Change type.  Move lower.
 769         (check_for_duplicate_sim_descriptor): Update.
 770         (get_sim_inferior_data): Use new.  Update.
 771         (~sim_inferior_data_cleanup): Rename from
 772         sim_inferior_data_cleanup.  Simplify.
 773         (gdbsim_close_inferior, simulator_command)
 774         (sim_command_completer, _initialize_remote_sim): Update.
 775         (next_pid, INITIAL_PID): Move earlier.
 776
 777 2019-07-10  Tom Tromey  <tromey@adacore.com>
 778
 779         * python/python-internal.h (create_thread_object): Return
 780         gdbpy_ref.
 781         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 782         * python/py-inferior.c (struct threadlist_entry): Add
 783         constructor.
 784         <thread_obj>: Now a gdbpy_ref.
 785         (thread_to_thread_object): Update.
 786         (add_thread_object): Use new.
 787         (delete_thread_object): Use delete.
 788         (infpy_threads): Update.
 789         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 790         GIL.
 791
 792 2019-07-10  Tom Tromey  <tromey@adacore.com>
 793
 794         * valops.c (value_cast): Specialize error message for Ada.
 795
 796 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 797
 798         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 799
 800 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 801
 802         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 803         bpstat_should_step): Return bool, adjust comments.
 804         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 805         bpstat_should_step): Likewise.
 806
 807 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 808
 809         * features/Makefile: Use feature target descriptions for Arm.
 810         * features/arm/arm-core.c: Generate new file.
 811         * features/arm/arm-fpa.c: Likewise.
 812         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 813         * features/arm/arm-m-profile.c: Likewise.
 814         * features/arm/arm-vfpv2.c: Likewise.
 815         * features/arm/arm-vfpv3.c: Likewise.
 816         * features/arm/xscale-iwmmxt.c: Likewise.
 817         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 818
 819 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 820
 821         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 822         ptrace earlier.
 823
 824 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 825
 826         * features/aarch64-pauth.c: Regenerate.
 827
 828 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 829
 830         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 831         bool.
 832         (bpstat_what): Use false instead of 0.
 833
 834 2019-07-09  Pedro Alves  <palves@redhat.com>
 835
 836         * break-catch-throw.c (is_exception_catchpoint): New.
 837         * breakpoint.c (print_one_breakpoint_location): New parameter
 838         'raw_loc'.  Handle it.  Use
 839         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 840         looking at the breakpoint's type.
 841         (print_one_breakpoint): If handling "maint info breakpoints", also
 842         print locations of exception catchpoints.
 843         * breakpoint.h (is_exception_catchpoint): Declare.
 844
 845 2019-07-09  Pedro Alves  <palves@redhat.com>
 846
 847         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 848         "addr" field.
 849         (allocate_location_exception_catchpoint): New.
 850         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 851         (initialize_throw_catchpoint_ops): Install
 852         allocate_location_exception_catchpoint as allocate_location
 853         method.
 854         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 855         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 856         bp_loc_other.
 857         (breakpoint_address_is_meaningful): Delete.
 858         (bl_address_is_meaningful): New.
 859         (breakpoint_locations_match): Adjust comment.
 860         (bp_location_from_bp_type): New, factored out of...
 861         (bp_location::bp_location(breakpoint *)): ... this.
 862         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 863         factored out of...
 864         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 865         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 866         breakpoint_address_is_meaningful.
 867         (bp_locations_compare): Adjust comment.
 868         (update_global_location_list): Use bl_address_is_meaningful
 869         instead of breakpoint_address_is_meaningful.
 870         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 871         explicit.
 872         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 873         * python/py-breakpoint.c (bppy_get_location): No longer check
 874         whether location is null.
 875
 876 2019-07-09  Pedro Alves  <palves@redhat.com>
 877
 878         PR c++/15468
 879         * breakpoint.c (print_one_breakpoint_location): Remove
 880         single-location assert.
 881
 882 2019-07-09  Tom Tromey  <tom@tromey.com>
 883
 884         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 885         * configure: Rebuild.
 886         * configure.ac: Change common to gdbsupport.
 887         * gdbsupport: Rename from common.
 888         * acinclude.m4: Change common to gdbsupport.
 889         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 890         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 891         gdbsupport.
 892         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 893         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 894         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 895         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 896         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 897         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 898         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 899         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 900         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 901         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 902         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 903         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 904         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 905         coff-pe-read.c, command.h, compile/compile-c-support.c,
 906         compile/compile-c.h, compile/compile-cplus-symbols.c,
 907         compile/compile-cplus-types.c, compile/compile-cplus.h,
 908         compile/compile-loc2c.c, compile/compile.c, completer.c,
 909         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 910         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 911         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 912         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 913         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 914         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 915         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 916         features/aarch64-core.c, features/aarch64-fpu.c,
 917         features/aarch64-pauth.c, features/aarch64-sve.c,
 918         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 919         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 920         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 921         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 922         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 923         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 924         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 925         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 926         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 927         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 928         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 929         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 930         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 931         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 932         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 933         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 934         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 935         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 936         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 937         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 938         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 939         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 940         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 941         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 942         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 943         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 944         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 945         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 946         minsyms.c, mips-linux-tdep.c, namespace.h,
 947         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 948         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 949         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 950         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 951         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 952         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 953         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 954         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 955         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 956         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 957         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 958         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 959         procfs.c, producer.c, progspace.h, psymtab.h,
 960         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 961         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 962         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 963         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 964         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 965         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 966         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 967         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 968         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 969         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 970         target-memory.c, target.c, target.h, target/waitstatus.c,
 971         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 972         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 973         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 974         unittests/array-view-selftests.c,
 975         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 976         unittests/common-utils-selftests.c,
 977         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 978         unittests/format_pieces-selftests.c,
 979         unittests/function-view-selftests.c,
 980         unittests/lookup_name_info-selftests.c,
 981         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 982         unittests/mkdir-recursive-selftests.c,
 983         unittests/observable-selftests.c,
 984         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 985         unittests/parse-connection-spec-selftests.c,
 986         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 987         unittests/scoped_fd-selftests.c,
 988         unittests/scoped_mmap-selftests.c,
 989         unittests/scoped_restore-selftests.c,
 990         unittests/string_view-selftests.c, unittests/style-selftests.c,
 991         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 992         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 993         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 994         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 995         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 996         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 997
 998 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 999
1000         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1001         bool value.
1002         (decode_digits_ordinary): Set explicit_line field in sal.
1003         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1004         symtab_and_line that was set on an explicit line number in
1005         assembler code.  Do always update the recorded symtab and line if
1006         we do skip the prologue.
1007
1008 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1009
1010         * breakpoint.c (set_breakpoint_location_function): Remove
1011         explicit_loc parameter.
1012         (momentary_breakpoint_from_master): Update call to
1013         set_breakpoint_location_function.
1014         (add_location_to_breakpoint): Likewise.
1015
1016 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1017
1018         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1019         required features based on default bfd type when no specific bfd
1020         is present.
1021
1022 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1023
1024         * NEWS: Mention that GDB printf and eval commands can now print
1025         C-style and Ada-style convenience var strings without
1026         calling the inferior.
1027         * printcmd.c (printf_c_string): Locally print GDB internal var
1028         instead of transiting via the inferior.
1029         (printf_wide_c_string): Likewise.
1030
1031 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1032
1033         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1034
1035 2019-07-04  Tom Tromey  <tom@tromey.com>
1036
1037         PR tui/24724:
1038         * tui/tui-winsource.c (tui_clear_source_content): Update.
1039         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1040         (tui_update_breakpoint_info): Update.
1041         (tui_set_exec_info_content): Update.
1042         * tui/tui-source.c (tui_set_source_content_nil): Update.
1043         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1044         has_break.
1045         * tui/tui-data.h (enum tui_bp_flag): New.
1046         (tui_bp_flags): New enum flags type.
1047         (struct tui_source_element) <break_mode>: Change type.  Rename
1048         from has_break.
1049         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1050         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1051         constants.
1052         * tui/tui-winsource.h: Fix comment.
1053
1054 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1055
1056         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1057         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1058         (store_fpregs_to_thread)
1059         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1060         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1061         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1062         (IWMMXT_REGS_SIZE): Add define.
1063         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1064         (fetch_vfp_regs, store_vfp_regs)
1065         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1066         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1067
1068 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1069
1070         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1071         defines.
1072         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1073         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1074         (ARM_INT_REGISTER_SIZE): ...to this.
1075         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1076         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1077         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1078         (arm_linux_collect_gregset, supply_nwfpe_register)
1079         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1080         defines.
1081         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1082         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1083         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1084         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1085         (arm_return_in_memory, arm_store_return_value)
1086         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1087         (arm_record_ld_st_multiple): Likewise.
1088         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1089         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1090
1091 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1092
1093         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1094         AARCH64_DISPLACED_MODIFIED_INSNS.
1095         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1096         (aarch64_displaced_step_copy_insn): Likewise.
1097         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1098         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1099         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1100         ARM_DISPLACED_MODIFIED_INSNS.
1101         * arm-tdep.c (arm_gdbarch_init): Likewise.
1102         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1103         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1104         (struct arm_displaced_step_closure): Use
1105         ARM_DISPLACED_MODIFIED_INSNS.
1106
1107 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1108
1109         * features/Makefile: Remove unused xml files.
1110         * features/aarch64.xml: Remove.
1111         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1112         * features/i386/amd64-avx-avx512.xml: Remove.
1113         * features/i386/amd64-avx-linux.xml: Remove.
1114         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1115         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1116         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1117         * features/i386/amd64-avx-mpx.xml: Remove.
1118         * features/i386/amd64-avx.xml: Remove.
1119         * features/i386/amd64-linux.xml: Remove.
1120         * features/i386/amd64-mpx-linux.xml: Remove.
1121         * features/i386/amd64-mpx.xml: Remove.
1122         * features/i386/amd64.xml: Remove.
1123         * features/i386/i386-avx-avx512-linux.xml: Remove.
1124         * features/i386/i386-avx-avx512.xml: Remove.
1125         * features/i386/i386-avx-linux.xml: Remove.
1126         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1127         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1128         * features/i386/i386-avx-mpx-linux.xml: Remove.
1129         * features/i386/i386-avx-mpx.xml: Remove.
1130         * features/i386/i386-avx.xml: Remove.
1131         * features/i386/i386-linux.xml: Remove.
1132         * features/i386/i386-mmx-linux.xml: Remove.
1133         * features/i386/i386-mmx.xml: Remove.
1134         * features/i386/i386-mpx-linux.xml: Remove.
1135         * features/i386/i386-mpx.xml: Remove.
1136         * features/i386/i386.xml: Remove.
1137         * features/i386/x32-avx-avx512-linux.xml: Remove.
1138         * features/i386/x32-avx-linux.xml: Remove.
1139         * features/i386/x32-linux.xml: Remove.
1140
1141 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1142
1143         * regformats/aarch64.dat: Remove.
1144         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1145         * regformats/i386/amd64-avx-linux.dat: Remove.
1146         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1147         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1148         * regformats/i386/amd64-linux.dat: Remove.
1149         * regformats/i386/amd64-mpx-linux.dat: Remove.
1150         * regformats/i386/amd64.dat: Remove.
1151         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1152         * regformats/i386/i386-avx-linux.dat: Remove.
1153         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1154         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1155         * regformats/i386/i386-linux.dat: Remove.
1156         * regformats/i386/i386-mmx-linux.dat: Remove.
1157         * regformats/i386/i386-mpx-linux.dat: Remove.
1158         * regformats/i386/i386.dat: Remove.
1159         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1160         * regformats/i386/x32-avx-linux.dat: Remove.
1161         * regformats/i386/x32-linux.dat: Remove.
1162
1163 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1164
1165         * aarch64-tdep.c: Remove xml self tests.
1166         * amd64-linux-tdep.c: Likewise.
1167         * amd64-tdep.c: Likewise.
1168         * i386-linux-tdep.c: Likewise.
1169         * i386-tdep.c: Likewise.
1170
1171 2019-07-03  Pedro Alves  <palves@redhat.com>
1172
1173         PR cli/24732
1174         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1175         (pipe_cmd_option_defs): New.
1176         (make_pipe_cmd_options_def_group): New.
1177         (pipe_command): Use gdb::option::process_options.
1178         (pipe_command_completer): New function.
1179         (_initialize_cli_cmds): Install completer for "pipe" command.
1180
1181 2019-07-03  Pedro Alves  <palves@redhat.com>
1182
1183         * cli/cli-option.c (union option_value) <string>: New field.
1184         (struct option_def_and_value): Add ctor, move ctor, dtor and
1185         use DISABLE_COPY_AND_ASSIGN.
1186         (option_def_and_value::clear_value): New.
1187         (parse_option, save_option_value_in_ctx, get_val_type_str)
1188         (add_setshow_cmds_for_options): Handle var_string.
1189         * cli-option.h (union option_def::var_address) <string>: New
1190         field.
1191         (struct string_option_def): New.
1192         * maint-test-options.c (struct test_options_opts): Add default
1193         ctor and use DISABLE_COPY_AND_ASSIGN.
1194         <string_opt>: New field.
1195         (test_options_opts::~test_options_opts): New.
1196         (test_options_opts::dump): Also dump "-string".
1197         (test_options_option_defs): Install "string.
1198
1199 2019-07-03  Pedro Alves  <palves@redhat.com>
1200
1201         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1202         option_value with a null enumeration.
1203         (complete_options): Save the option values in the context.
1204         (save_option_value_in_ctx): New, factored out from ...
1205         (process_options): ... here.
1206         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1207         of the function.
1208         * maint-test-options.c (test_options_opts::dump): New, factored
1209         out from ...
1210         (maintenance_test_options_command_mode): ... here.
1211         (maintenance_test_options_command_completion_result): Delete.
1212         (maintenance_test_options_command_completion_text): Update
1213         comment.
1214         (maintenance_show_test_options_completion_result): Change
1215         prototype.  Just print
1216         maintenance_test_options_command_completion_text.
1217         (save_completion_result): New.
1218         (maintenance_test_options_completer_mode): Pass options context to
1219         complete_options, and then save a dump.
1220         (_initialize_maint_test_options): Use add_cmd to install "maint
1221         show test-options-completion-result".
1222
1223 2019-07-03  Pedro Alves  <palves@redhat.com>
1224
1225         * NEWS (New commands): Mention "with" and "maint with".
1226         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1227         (with_command, with_command_completer): New.
1228         (pipe_command): Adjust to new repeat_previous
1229         interface.
1230         (_initialize_cli_cmds): Install the "with" command and its "w"
1231         alias.
1232         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1233         declarations.
1234         * cli/cli-setshow.c (parse_cli_var_uinteger)
1235         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1236         argument strings for all var_types.
1237         (get_setshow_command_value_string): New, factored out from ...
1238         (do_show_command): ... this.
1239         * cli/cli-setshow.h: Include <string>.
1240         (get_setshow_command_value_string): Declare.
1241         * command.h (repeat_previous): Now returns const char *.  Adjust
1242         comment.
1243         * maint.c: Include "cli/cli-cmds.h".
1244         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1245         (_initialize_maint_cmds): Register the "maintenance with" command.
1246         * top.c (repeat_previous): Move bits from pipe_command here:
1247         Return the saved command line, if any; error out if there's no
1248         command to relaunch.
1249
1250 2019-07-03  Pedro Alves  <palves@redhat.com>
1251
1252         * NEWS (New commands): Mention "maint set/show test-settings"
1253         instead of "maint test-settings".
1254         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1255         (maintenance_test_settings_set_list): Rename to ...
1256         (maintenance_set_test_settings_list): ... this.
1257         (maintenance_test_settings_show_list): Rename to  ...
1258         (maintenance_show_test_settings_list): ... this.
1259         (maintenance_test_settings_cmd): Delete.
1260         (maintenance_test_settings_set_cmd): ...
1261         (maintenance_set_test_settings_cmd): ... this.
1262         (maintenance_test_settings_show_cmd): ...
1263         (maintenance_show_test_settings_cmd): ... this.
1264         (maintenance_test_settings_show_value_cmd):
1265         (maintenance_show_test_settings_value_cmd): ... this.
1266         (_initialize_maint_test_settings): No longer install the "maint
1267         test-settings" prefix command.  Rename "maint test-settings set"
1268         to "maint set test-settings", and "maint test-settings show" to
1269         "maint show test-settings".  Adjust all subcommands.
1270
1271 2019-07-03  Pedro Alves  <palves@redhat.com>
1272
1273         * maint-test-settings.c: Fix file's intro comment.  Replace all
1274         references to "test-options" with references to "test-settings",
1275         in comments.
1276
1277 2019-07-03  Pedro Alves  <palves@redhat.com>
1278
1279         * maint-test-settings.c (maintenance_test_settings_xxx)
1280         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1281         New.
1282         (maintenance_test_settings_enums): Use them.
1283         (maintenance_test_settings_enum): Default to
1284         maintenance_test_settings_xxx.
1285         (_initialize_maint_test_settings): Initialize
1286         MAINTENANCE_TEST_SETTINGS_FILENAME.
1287
1288 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1289
1290         * breakpoint.h (remove_breakpoints_inf): Change return type to
1291         void, move function documentation here.
1292         * breakpoint.c (remove_breakpoints_inf): Change return type to
1293         void, move function documentation to header.
1294
1295 2019-07-02  Pedro Alves  <palves@redhat.com>
1296
1297         * NEWS (Completion improvements): Mention "info threads".
1298         * thread.c (struct info_threads_opts, info_threads_option_defs)
1299         (make_info_threads_options_def_group): New.
1300         (info_threads_command): Use gdb::option::process_options.
1301         (info_threads_command_completer): New.
1302         (_initialize_thread): Use gdb::option::build_help to build the
1303         help text for "info threads".
1304
1305 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1306
1307         * defs.h (generic_load): Move from here...
1308         * symfile.h (generic_load): ... to here.  Rename name parameter
1309         to args.
1310         * symfile.c (generic_load): Add comment.
1311
1312 2019-07-01  Tom Tromey  <tromey@adacore.com>
1313
1314         * dwarf2read.c
1315         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1316         declaration of without_params.  Fix formatting.
1317
1318 2019-07-01  Tom Tromey  <tromey@adacore.com>
1319
1320         * ada-exp.y (find_primitive_type): Update.
1321         * ada-lang.h (ada_lookup_symbol): Update.
1322         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1323         parameter.
1324         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1325
1326 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1327
1328         PR breakpoints/24541
1329         * gdbarch.c: Regenerate.
1330         * gdbarch.h: Regenerate.
1331         * gdbarch.sh: Add 'stap_adjust_register'.
1332         * i386-tdep.c: Include '<unordered_set>'.
1333         (i386_stap_adjust_register): New function.
1334         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1335         * stap-probe.c (stap_parse_register_operand): Call
1336         'gdbarch_stap_adjust_register'.
1337
1338 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1339
1340         PR python/24742
1341         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1342         * python/python.c (do_start_initialization): Use 'xmalloc'
1343         instead of 'PyMem_Malloc'.
1344
1345 2019-06-28  Tom Tromey  <tromey@adacore.com>
1346
1347         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1348         for Ada.
1349
1350 2019-06-27  Tom Tromey  <tromey@adacore.com>
1351
1352         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1353         objfile_key.
1354         (arm_find_mapping_symbol, arm_record_special_symbol)
1355         (_initialize_arm_tdep): Update.
1356         (arm_objfile_data_free): Remove.
1357
1358 2019-06-27  Tom Tromey  <tromey@adacore.com>
1359
1360         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1361         to cp_print_static_field.
1362
1363 2019-06-26  Tom Tromey  <tromey@adacore.com>
1364
1365         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1366         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1367         declare.
1368
1369 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1370
1371         * features/aarch64-core.c (create_feature_aarch64_core):
1372         Regenerate.
1373         * features/aarch64-core.xml: Add cpsr flags.
1374
1375 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1376
1377         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1378         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1379
1380 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1381
1382         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1383         field.
1384         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1385         use.
1386         (arm_record_special_symbol): Don't insert new symbol in sorted
1387         position, push it at the end.
1388
1389 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1390
1391         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1392         (arm_mapping_symbol_s): Remove.
1393         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1394         (arm_mapping_symbol_vec): New typedef.
1395         (struct arm_per_objfile): Add constructor.
1396         <section_maps>: Change type to
1397         std::unique_ptr<arm_mapping_symbol_vec[]>.
1398         (arm_compare_mapping_symbols): Remove.
1399         (arm_find_mapping_symbol): Adjust to section_maps type change.
1400         (arm_objfile_data_free): Call delete on arm_per_objfile.
1401         (arm_record_special_symbol): Adjust to section_maps type change.
1402         Allocate arm_per_objfile with new.
1403
1404 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1405
1406         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1407         with the command prefix.
1408
1409 2019-06-25  Tom Tromey  <tom@tromey.com>
1410
1411         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1412         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1413
1414 2019-06-25  Tom Tromey  <tom@tromey.com>
1415
1416         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1417         type.
1418         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1419         protected.
1420
1421 2019-06-25  Tom Tromey  <tom@tromey.com>
1422
1423         * tui/tui-winsource.c
1424         (tui_source_window_base::set_is_exec_point_at): Add check against
1425         LOA_ADDRESS.
1426
1427 2019-06-25  Tom Tromey  <tom@tromey.com>
1428
1429         * tui/tui-source.c (tui_set_source_content): Don't check before
1430         xfree.
1431         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1432
1433 2019-06-25  Tom Tromey  <tom@tromey.com>
1434
1435         * tui/tui-winsource.h (tui_update_source_window_as_is)
1436         (tui_alloc_source_buffer, tui_line_is_displayed)
1437         (tui_addr_is_displayed): Change type of win_info.
1438         * tui/tui-winsource.c (tui_update_source_window_as_is)
1439         (tui_clear_source_content, tui_show_source_line)
1440         (tui_show_source_content, tui_source_window_base::refill)
1441         (tui_source_window_base::set_is_exec_point_at)
1442         (tui_source_window_base::set_is_exec_point_at)
1443         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1444         (tui_alloc_source_buffer, tui_line_is_displayed)
1445         (tui_addr_is_displayed): Change type of win_info.  Update.
1446         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1447         (tui_source_window_base::do_make_visible_with_new_height):
1448         Update.
1449         * tui/tui-source.c (tui_set_source_content)
1450         (tui_set_source_content_nil)
1451         (tui_source_window::do_scroll_vertical): Update.
1452         * tui/tui-layout.c (show_layout): Update.
1453         * tui/tui-disasm.c (tui_set_disassem_content)
1454         (tui_disasm_window::do_scroll_vertical): Update.
1455         * tui/tui-data.h (tui_win_content): Remove.
1456         (struct tui_gen_win_info) <content, content_size>: Remove.
1457         (struct tui_source_element): Add initializers and destructor.
1458         (union tui_which_element, struct tui_win_element): Remove.
1459         (struct tui_source_window_base) <content>: New field.
1460         (struct tui_data_window): Remove destructor.
1461         (tui_alloc_content, tui_free_win_content)
1462         (tui_free_all_source_wins_content): Don't declare.
1463         * tui/tui-data.c (tui_initialize_static_data): Update.
1464         (init_content_element, tui_alloc_content): Remove.
1465         (~tui_gen_win_info): Update.
1466         (~tui_data_window, tui_free_all_source_wins_content)
1467         (tui_free_win_content, free_content, free_content_elements):
1468         Remove.
1469
1470 2019-06-25  Tom Tromey  <tom@tromey.com>
1471
1472         * tui/tui-winsource.h (tui_clear_source_content)
1473         (tui_erase_source_content, tui_show_source_content): Change type
1474         of win_info.
1475         * tui/tui-winsource.c (tui_clear_source_content)
1476         (tui_erase_source_content, tui_show_source_content): Change type
1477         of win_info.
1478         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1479         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1480         win_info.
1481         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1482         win_info.
1483         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1484
1485 2019-06-25  Tom Tromey  <tom@tromey.com>
1486
1487         * tui/tui-winsource.c (tui_clear_source_content)
1488         (tui_source_window_base::set_is_exec_point_at): Update.
1489         * tui/tui-source.c (tui_set_source_content_nil): Update.
1490         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1491         a bool.
1492         * tui/tui-data.c (init_content_element): Update.
1493
1494 2019-06-25  Tom Tromey  <tom@tromey.com>
1495
1496         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1497         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1498         * tui/tui-layout.c (init_and_make_win): Update.
1499         * tui/tui.h (enum tui_win_type): Update.
1500         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1501         tui_win_is_auxillary.
1502         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1503         tui_win_is_auxillary.
1504
1505 2019-06-25  Tom Tromey  <tom@tromey.com>
1506
1507         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1508         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1509         (tui_delete_data_content_windows, tui_display_all_data)
1510         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1511         Update.
1512         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1513         * tui/tui-regs.c (tui_last_regs_line_no)
1514         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1515         (tui_show_registers): Update.
1516         (tui_show_register_group): Return void.  Update.
1517         (tui_display_registers_from, tui_display_reg_element_at_line)
1518         (tui_display_registers_from_line, tui_check_register_values):
1519         Update.
1520         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1521         member.
1522         (struct tui_data_window) <regs_content>: Now a std::vector.
1523         <regs_content_count>: Remove.
1524         (tui_add_content_elements, tui_free_data_content): Don't declare.
1525         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1526         (init_content_element): Remove DATA_WIN case.  Add assert.
1527         (tui_add_content_elements): Remove.
1528         (tui_data_window): Update.
1529         (tui_free_data_content): Remove.
1530         (free_content_elements): Remove DATA_WIN case.
1531
1532 2019-06-25  Tom Tromey  <tom@tromey.com>
1533
1534         * tui/tui-data.c (tui_data_item_window): Update.
1535         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1536         * tui/tui-windata.c (tui_display_all_data)
1537         (tui_display_data_from_line): Update.
1538         (tui_check_data_values): Remove.
1539         * tui/tui-regs.c (tui_show_register_group)
1540         (tui_display_reg_element_at_line): Update.
1541         * tui/tui-hooks.c (tui_register_changed)
1542         (tui_refresh_frame_and_register_information): Call
1543         tui_check_register_values.
1544         * tui/tui-data.h (struct tui_data_window) <data_content,
1545         data_content_count, data_type>: Remove.
1546         (enum tui_data_type): Remove.
1547
1548         * tui/tui-data.c (tui_data_window::clear_detail)
1549         (~tui_data_window): Update.
1550
1551 2019-06-25  Tom Tromey  <tom@tromey.com>
1552
1553         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1554         declare.
1555         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1556         Rename from tui_first_data_item_displayed.  Update.
1557         (tui_data_window::refresh_all)
1558         (tui_data_window::do_scroll_vertical): Update.
1559         * tui/tui-data.h (struct tui_data_window)
1560         <first_data_item_displayed>: Declare new method.
1561
1562 2019-06-25  Tom Tromey  <tom@tromey.com>
1563
1564         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1565         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1566         contents...
1567         (tui_initialize_static_data): ...here.
1568
1569 2019-06-25  Tom Tromey  <tom@tromey.com>
1570
1571         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1572         (tui_display_registers_from, tui_check_register_values): Update.
1573         (tui_display_register): Remove win_info parameter; update.
1574         (tui_get_register): Change type of parameters.
1575         * tui/tui-data.h (struct tui_data_element): Remove.
1576         (union tui_which_element) <data>: Remove.
1577         <data_window>: Change type.
1578         (struct tui_data_item_window): New.
1579         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1580         case.  Add assert.
1581         (~tui_data_item_window): New destructor.
1582         (free_content_elements): Remove DATA_ITEM_WIN case.
1583
1584 2019-06-25  Tom Tromey  <tom@tromey.com>
1585
1586         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1587         Remove.
1588
1589 2019-06-25  Tom Tromey  <tom@tromey.com>
1590
1591         * tui/tui-data.h (struct tui_command_element): Remove.
1592         (union tui_which_element) <command>: Remove.
1593         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1594         assert.
1595         (free_content_elements): Remove CMD_WIN case.
1596
1597 2019-06-25  Tom Tromey  <tom@tromey.com>
1598
1599         * tui/tui-layout.c (tui_set_layout): Update.
1600         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1601         * tui/tui-data.c (layout_def): Update.
1602
1603 2019-06-25  Tom Tromey  <tom@tromey.com>
1604
1605         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1606         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1607         (tui_source_window_base::set_new_height): Update.
1608         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1609         Update.
1610         (tui_set_locator_fullname, tui_set_locator_info)
1611         (tui_show_frame_info): Update.
1612         * tui/tui-source.c (tui_set_source_content)
1613         (tui_source_is_displayed): Update.
1614         * tui/tui-layout.c (show_source_disasm_command, show_data)
1615         (show_source_or_disasm_and_command): Update.
1616         * tui/tui-disasm.c (tui_set_disassem_content)
1617         (tui_get_begin_asm_address): Update.
1618         * tui/tui-data.h (struct tui_locator_element): Remove.
1619         (union tui_which_element) <locator>: Remove.
1620         (struct tui_locator_window): New.
1621         (tui_locator_win_info_ptr): Change return type.
1622         * tui/tui-data.c (_locator): Change type.
1623         (tui_locator_win_info_ptr): Change return type.
1624         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1625         (tui_alloc_content): Add assert.
1626
1627 2019-06-25  Tom Tromey  <tom@tromey.com>
1628
1629         * tui/tui-winsource.c
1630         (tui_exec_info_window::maybe_allocate_content): New method.
1631         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1632         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1633         (make_source_or_disasm_window): Add cast.
1634         * tui/tui-data.h (union tui_which_element) <simple_string>:
1635         Remove.
1636         (struct tui_source_info): New.
1637         (struct tui_source_window_base) <execution_info>: Change type.
1638         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1639         case, and add assert.
1640         (tui_alloc_content): Add assert.
1641
1642 2019-06-25  Tom Tromey  <tom@tromey.com>
1643
1644         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1645         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1646         * tui/tui-data.c (tui_alloc_win_info): Remove.
1647
1648 2019-06-25  Tom Tromey  <tom@tromey.com>
1649
1650         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1651         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1652         can_highlight.
1653
1654 2019-06-25  Tom Tromey  <tom@tromey.com>
1655
1656         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1657         make_visible_with_new_height method.
1658         (tui_win_info::make_visible_with_new_height): New method.
1659         (tui_source_window_base::do_make_visible_with_new_height)
1660         (tui_data_window::do_make_visible_with_new_height)
1661         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1662         (make_visible_with_new_height): Remove.
1663         (tui_resize_all, tui_adjust_win_heights): Use
1664         make_visible_with_new_height method.
1665         * tui/tui-data.h (struct tui_win_info)
1666         <do_make_visible_with_new_height, make_visible_with_new_height>:
1667         New methods.
1668         (struct tui_source_window_base, struct tui_data_window)
1669         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1670         methods.
1671
1672 2019-06-25  Tom Tromey  <tom@tromey.com>
1673
1674         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1675         method.
1676         (update_tab_width): Call update_tab_width method.
1677         * tui/tui-data.h (struct tui_win_info)
1678         (struct tui_source_window_base) <update_tab_width>: New methods.
1679
1680 2019-06-25  Tom Tromey  <tom@tromey.com>
1681
1682         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1683         parameter.
1684         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1685         parameter.
1686         (tui_gen_win_info::make_visible): Update.
1687         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1688         parameter.
1689         * tui/tui-data.h (enum tui_box): New enum.
1690         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1691
1692 2019-06-25  Tom Tromey  <tom@tromey.com>
1693
1694         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1695         init_and_make_win for EXEC_INFO_WIN.
1696         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1697         longer inline.
1698         (struct tui_win_info) <~tui_win_info>: Inline.
1699         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1700         Don't declare.
1701         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1702         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1703         Remove.
1704         (tui_initialize_static_data): Update.
1705         (~tui_gen_win_info): Handle more cleanup here.
1706         (~tui_source_window_base): Delete "execution_info".
1707         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1708
1709 2019-06-25  Tom Tromey  <tom@tromey.com>
1710
1711         * tui/tui-layout.c (make_command_window): Don't set
1712         can_highlight.
1713         (show_source_disasm_command): Call the reset method.
1714         (show_data): Don't set can_highlight.  Call the reset method.
1715         (tui_gen_win_info::reset): Rename from init_gen_win_info
1716         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1717         (show_source_or_disasm_and_command): Call the reset method.
1718         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1719         (struct tui_cmd_window): Set can_highlight.
1720
1721 2019-06-25  Tom Tromey  <tom@tromey.com>
1722
1723         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1724         from make_visible.
1725         (tui_make_visible, tui_make_invisible): Rewrite.
1726         (tui_win_info::make_visible): Remove.
1727         (tui_source_window_base::make_visible): Update.
1728         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1729         method.  Moved from...
1730         (struct tui_win_info) <make_visible>: ...here.
1731
1732 2019-06-25  Tom Tromey  <tom@tromey.com>
1733
1734         * tui/tui-winsource.c
1735         (tui_source_window_base::do_scroll_horizontal): Remove direction
1736         parameter.
1737         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1738         direction parameter.
1739         * tui/tui-win.c (tui_win_info::forward_scroll)
1740         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1741         (tui_win_info::right_scroll): Update.
1742         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1743         direction parameter.
1744         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1745         direction parameter.
1746         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1747         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1748         Remove direction parameter.
1749         (struct tui_source_window_base, struct tui_source_window)
1750         (struct tui_disasm_window, struct tui_data_window)
1751         (struct tui_cmd_window): Update.
1752
1753 2019-06-25  Tom Tromey  <tom@tromey.com>
1754
1755         * tui/tui-winsource.h (tui_set_exec_info_content)
1756         (tui_show_exec_info_content, tui_erase_exec_info_content)
1757         (tui_clear_exec_info_content, tui_update_exec_info): Change
1758         argument to tui_source_window_base.
1759         * tui/tui-winsource.c (tui_set_exec_info_content)
1760         (tui_show_exec_info_content, tui_erase_exec_info_content)
1761         (tui_clear_exec_info_content, tui_update_exec_info): Change
1762         argument to tui_source_window_base.
1763
1764 2019-06-25  Tom Tromey  <tom@tromey.com>
1765
1766         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1767         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1768
1769 2019-06-25  Tom Tromey  <tom@tromey.com>
1770
1771         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1772         check.
1773
1774 2019-06-25  Tom Tromey  <tom@tromey.com>
1775
1776         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1777         type to void.
1778         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1779         type to void.
1780         * tui/tui-source.c (tui_set_source_content): Update.
1781         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1782
1783 2019-06-25  Tom Tromey  <tom@tromey.com>
1784
1785         * tui/tui-win.c (window_name_completer, tui_set_focus)
1786         (tui_all_windows_info): Use name method.
1787         * tui/tui-data.h (struct tui_gen_win_info)
1788         (struct tui_source_window, struct tui_disasm_window)
1789         (struct tui_data_window, struct tui_cmd_window) <name>: New
1790         method.
1791         (tui_win_name): Don't declare.
1792         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1793         (tui_win_name): Remove.
1794
1795 2019-06-25  Tom Tromey  <tom@tromey.com>
1796
1797         * tui/tui-winsource.h (tui_update_source_window)
1798         (tui_update_source_window_as_is): Change parameter type.
1799         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1800         to be a tui_source_window_base.
1801         (tui_update_source_window_as_is): Likewise.
1802         * tui/tui-win.c (make_visible_with_new_height): Update.
1803
1804 2019-06-25  Tom Tromey  <tom@tromey.com>
1805
1806         * tui/tui-winsource.c (tui_erase_source_content)
1807         (tui_show_source_content, tui_show_exec_info_content)
1808         (tui_erase_exec_info_content): Use refresh_window method.
1809         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1810         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1811         from tui_refresh_win.
1812         (tui_data_window::refresh_window): New method.
1813         (tui_win_info::refresh, tui_source_window_base::refresh)
1814         (tui_refresh_all): Use refresh_window method.
1815         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1816         method.
1817         * tui/tui-regs.c (tui_display_register): Call refresh_window
1818         method.
1819         * tui/tui-layout.c (show_source_disasm_command)
1820         (show_source_or_disasm_and_command): Call refresh_window method.
1821         * tui/tui-data.h (struct tui_gen_win_info)
1822         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1823         New method.
1824
1825 2019-06-25  Tom Tromey  <tom@tromey.com>
1826
1827         * tui/tui.c (tui_rl_other_window, tui_enable)
1828         (tui_is_window_visible, tui_get_command_dimension): Update.
1829         * tui/tui-winsource.c (tui_update_source_window_as_is)
1830         (tui_clear_source_content, tui_erase_source_content)
1831         (tui_show_source_line, tui_source_window_base::refill)
1832         (tui_source_window_base::do_scroll_horizontal)
1833         (tui_source_window_base::set_is_exec_point_at)
1834         (tui_update_breakpoint_info, tui_set_exec_info_content)
1835         (tui_alloc_source_buffer, tui_line_is_displayed)
1836         (tui_addr_is_displayed): Update.
1837         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1838         (tui_check_and_display_highlight_if_needed)
1839         (tui_win_info::make_visible, tui_win_info::refresh)
1840         (tui_refresh_all): Update.
1841         * tui/tui-windata.c (tui_first_data_item_displayed)
1842         (tui_delete_data_content_windows, tui_erase_data_content)
1843         (tui_display_all_data, tui_data_window::refresh_all)
1844         (tui_check_data_values): Update.
1845         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1846         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1847         (tui_win_info::backward_scroll, tui_refresh_all_win)
1848         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1849         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1850         (tui_source_window_base::set_new_height)
1851         (tui_data_window::set_new_height)
1852         (make_invisible_and_set_new_height)
1853         (make_visible_with_new_height, new_height_ok)
1854         (parse_scrolling_args): Update.
1855         * tui/tui-stack.c (tui_show_frame_info): Update.
1856         * tui/tui-source.c (tui_set_source_content)
1857         (tui_set_source_content_nil, tui_source_is_displayed)
1858         (tui_source_window::do_scroll_vertical): Update.
1859         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1860         (tui_display_registers_from, tui_display_reg_element_at_line)
1861         (tui_check_register_values, tui_reg_command): Update.
1862         * tui/tui-layout.c (tui_default_win_height)
1863         (show_source_disasm_command, show_data, init_and_make_win)
1864         (show_source_or_disasm_and_command): Update.
1865         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1866         (tui_redisplay_readline, tui_mld_flush)
1867         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1868         (tui_getc): Update.
1869         * tui/tui-disasm.c (tui_set_disassem_content)
1870         (tui_disasm_window::do_scroll_vertical): Update.
1871         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1872         Now virtual.
1873         (struct tui_win_info): Derive from tui_gen_win_info.
1874         <~tui_win_info>: Mark as override.
1875         <generic>: Remove member.
1876         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1877         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1878         (~tui_data_window, ~tui_win_info)
1879         (tui_free_all_source_wins_content): Update.
1880         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1881
1882 2019-06-25  Tom Tromey  <tom@tromey.com>
1883
1884         * tui/tui-layout.c (init_and_make_win): Use new.
1885         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1886         destructor, initializers.
1887         (tui_alloc_generic_win_info): Don't declare.
1888         * tui/tui-data.c (_locator): Add argument to constructor.
1889         (source_win, disasm_win): New globals.
1890         (exec_info): Remove.
1891         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1892         Update.
1893         (tui_alloc_generic_win_info): Remove.
1894         (init_content_element): Use new.
1895         (tui_win_info::tui_win_info): Update.
1896         (free_content_elements) <case DATA_WIN>: Use delete.
1897
1898 2019-06-25  Tom Tromey  <tom@tromey.com>
1899
1900         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1901         * tui/tui-windata.c (tui_first_data_item_displayed)
1902         (tui_delete_data_content_windows): Update.
1903         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1904         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1905         (tui_display_registers_from, tui_check_register_values): Update.
1906         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1907         pointer.
1908         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1909         window.
1910         (tui_free_data_content): Update.
1911         (free_content_elements) <case DATA_WIN>: Free the window.
1912
1913 2019-06-25  Tom Tromey  <tom@tromey.com>
1914
1915         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1916         Update.
1917         * tui/tui-layout.c (make_command_window)
1918         (show_source_disasm_command, show_data, init_and_make_win)
1919         (show_source_or_disasm_and_command): Update.
1920         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1921         method.
1922         <can_highight, is_highlighted>: Now bool.
1923         (tui_set_win_highlight): Don't declare.
1924         * tui/tui-data.c (tui_set_win_highlight): Remove.
1925
1926 2019-06-25  Tom Tromey  <tom@tromey.com>
1927
1928         * tui/tui-wingeneral.c (make_visible): Remove check of window
1929         type.
1930
1931 2019-06-25  Tom Tromey  <tom@tromey.com>
1932
1933         * tui/tui-win.c (tui_win_info::max_height)
1934         (tui_cmd_window::max_height): New methods.
1935         (new_height_ok): Call max_height.
1936         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1937         <max_height>: New method.
1938
1939 2019-06-25  Tom Tromey  <tom@tromey.com>
1940
1941         * tui/tui-win.c (tui_source_window_base::set_new_height)
1942         (tui_data_window::set_new_height): New methods.
1943         (make_invisible_and_set_new_height): Call set_new_height method.
1944         * tui/tui-data.h (struct tui_win_info)
1945         (struct tui_source_window_base, struct tui_data_window)
1946         <set_new_height>: New method.
1947
1948 2019-06-25  Tom Tromey  <tom@tromey.com>
1949
1950         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1951         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1952         tui_refresh_data_win.
1953         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1954         method.
1955         (tui_refresh_all_win): Call the refresh_all method.
1956         (tui_set_focus): Likewise.
1957         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1958         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1959         Likewise.
1960
1961 2019-06-25  Tom Tromey  <tom@tromey.com>
1962
1963         * tui/tui-winsource.h (tui_refill_source_window)
1964         (tui_set_is_exec_point_at): Don't declare.
1965         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1966         (tui_source_window_base::refill): Rename from
1967         tui_refill_source_window.
1968         (tui_source_window_base::do_scroll_horizontal): Update.
1969         (tui_source_window_base::set_is_exec_point_at): Rename from
1970         tui_set_is_exec_point_at.
1971         (tui_update_all_breakpoint_info): Update.
1972         * tui/tui-stack.c (tui_show_frame_info): Update.
1973         * tui/tui-layout.c (show_data): Add cast.
1974         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1975         * tui/tui-data.h (struct tui_source_window_base) <refill,
1976         set_is_exec_point_at>: New methods.
1977         (tui_source_windows, tui_add_to_source_windows): Update types.
1978         (tui_add_to_source_windows): Remove redundant declaration.
1979         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1980         (tui_source_windows): Change return type.
1981         (tui_clear_source_windows_detail): Update.
1982         (tui_add_to_source_windows): Change type of parameter.
1983         (tui_free_all_source_wins_content): Update.
1984
1985 2019-06-25  Tom Tromey  <tom@tromey.com>
1986
1987         * tui/tui-wingeneral.c (tui_win_info::refresh)
1988         (tui_source_window_base::refresh): New methods.
1989         (tui_refresh_all): Call the refresh method.
1990         * tui/tui-data.h (struct tui_win_info)
1991         (struct tui_source_window_base) <refresh>: New method.
1992
1993 2019-06-25  Tom Tromey  <tom@tromey.com>
1994
1995         * tui/tui.h (tui_is_window_visible): Return bool.
1996         * tui/tui.c (tui_is_window_visible): Return bool.
1997         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1998         (tui_make_visible, tui_make_invisible)
1999         (tui_win_info::make_visible)
2000         (tui_source_window_base::make_visible, make_all_visible)
2001         (tui_make_all_visible, tui_make_all_invisible): Update.
2002         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2003         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2004         bool.
2005         (struct tui_win_info, struct tui_source_window_base)
2006         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2007         * tui/tui-data.c (tui_init_generic_part): Update.
2008
2009 2019-06-25  Tom Tromey  <tom@tromey.com>
2010
2011         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2012         (tui_source_window_base::make_visible): New methods.
2013         (make_all_visible): Make method call.
2014         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2015         (struct tui_source_window_base, struct tui_cmd_window): Override
2016         make_visible.
2017         (tui_win_is_source_type): Don't declare.
2018         * tui/tui-data.c (tui_win_is_source_type): Remove.
2019
2020 2019-06-25  Tom Tromey  <tom@tromey.com>
2021
2022         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2023         NULL check.
2024
2025 2019-06-25  Tom Tromey  <tom@tromey.com>
2026
2027         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2028         Inline constructor.  Add initializers for members.
2029         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2030         constructors; now inline in class.
2031
2032 2019-06-25  Tom Tromey  <tom@tromey.com>
2033
2034         * tui/tui-regs.c (tui_show_registers): Update.
2035         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2036         bool.
2037         * tui/tui-data.c (tui_data_window::clear_detail)
2038         (tui_data_window): Update.
2039
2040 2019-06-25  Tom Tromey  <tom@tromey.com>
2041
2042         * tui/tui-windata.c (tui_display_all_data)
2043         (tui_display_data_from_line, tui_display_data_from)
2044         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2045         Update.
2046         * tui/tui-regs.c (tui_last_regs_line_no)
2047         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2048         (tui_show_registers, tui_show_register_group)
2049         (tui_display_registers_from, tui_display_reg_element_at_line)
2050         (tui_display_registers_from_line, tui_check_register_values)
2051         (tui_reg_next, tui_reg_prev): Update.
2052         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2053         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2054         tui_data_window.
2055         (struct tui_win_info) <detail>: Remove.  Add new fields from
2056         tui_data_info.
2057         (TUI_DATA_WIN): Add cast.
2058         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2059         (~tui_data_window): Simplify.
2060
2061 2019-06-25  Tom Tromey  <tom@tromey.com>
2062
2063         * tui/tui-layout.c (show_source_disasm_command)
2064         (show_source_or_disasm_and_command): Update.
2065         * tui/tui-io.c (update_cmdwin_start_line)
2066         (tui_redisplay_readline): Update.
2067         * tui/tui-data.h (struct tui_command_info): Remove.
2068         (struct tui_win_info) <detail>: Remove command_info member.
2069         (struct tui_data_window) <start_line>: New member, from
2070         tui_command_info.
2071         (TUI_CMD_WIN): Add casts.
2072
2073 2019-06-25  Tom Tromey  <tom@tromey.com>
2074
2075         * tui/tui-winsource.c (tui_update_source_window)
2076         (tui_refill_source_window)
2077         (tui_source_window_base::do_scroll_horizontal)
2078         (tui_update_breakpoint_info, tui_set_exec_info_content)
2079         (tui_show_exec_info_content, tui_erase_exec_info_content)
2080         (tui_clear_exec_info_content): Update.
2081         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2082         Update.
2083         * tui/tui-win.c (make_invisible_and_set_new_height)
2084         (make_visible_with_new_height): Update.
2085         * tui/tui-source.c (tui_set_source_content)
2086         (tui_show_symtab_source): Update.
2087         * tui/tui-layout.c (extract_display_start_addr)
2088         (show_source_disasm_command, show_data)
2089         (make_source_or_disasm_window)
2090         (show_source_or_disasm_and_command): Update.
2091         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2092         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2093         "gdbarch".
2094         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2095         to tui_source_window_base.
2096         (struct tui_win_info) <detail>: Remove source_info member.
2097         (struct tui_source_window_base) <has_locator>: Inline.
2098         Move contents from tui_source_info; rename has_locator member to
2099         m_has_locator.
2100         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2101         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2102         header file.
2103         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2104         Simplify.
2105         (tui_free_all_source_wins_content): Cast to
2106         tui_source_window_base.
2107
2108 2019-06-25  Tom Tromey  <tom@tromey.com>
2109
2110         * tui/tui-win.c (make_invisible_and_set_new_height)
2111         (make_visible_with_new_height): Call has_locator method.
2112         * tui/tui-layout.c (show_source_disasm_command, show_data)
2113         (show_source_or_disasm_and_command): Update for bool change.
2114         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2115         (tui_win_info) <has_locator>: New method.
2116         (struct tui_source_window_base) <has_locator>: New method.
2117         (tui_win_has_locator): Don't declare.
2118         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2119         from tui_win_has_locator.
2120         (tui_source_window_base): Use false, not FALSE.
2121
2122 2019-06-25  Tom Tromey  <tom@tromey.com>
2123
2124         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2125         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2126         clear_detail method directly.
2127         (tui_clear_win_detail): Remove.
2128
2129 2019-06-25  Tom Tromey  <tom@tromey.com>
2130
2131         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2132         "this", not TUI_DISASM_WIN.
2133
2134 2019-06-25  Tom Tromey  <tom@tromey.com>
2135
2136         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2137         declare.
2138         * tui/tui-winsource.c
2139         (tui_source_window_base::do_scroll_horizontal): Rename from
2140         tui_horizontal_source_scroll.
2141         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2142         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2143         from tui_vertical_data_scroll.
2144         * tui/tui-win.h (tui_scroll): Don't declare.
2145         * tui/tui-win.c (tui_win_info::forward_scroll)
2146         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2147         (tui_win_info::right_scroll): Rename and update.
2148         (tui_scroll_forward_command, tui_scroll_backward_command)
2149         (tui_scroll_left_command, tui_scroll_right_command): Update.
2150         (tui_scroll): Remove.
2151         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2152         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2153         from tui_vertical_source_scroll.
2154         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2155         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2156         from tui_vertical_disassem_scroll.
2157         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2158         do_scroll_horizontal>: New methods.
2159         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2160         Likewise.
2161         (struct tui_source_window_base): Add do_scroll_horizontal.
2162         (struct tui_source_window, struct tui_disasm_window): Add
2163         do_scroll_vertical.
2164         (struct tui_data_window, struct tui_cmd_window): Add
2165         do_scroll_horizontal and do_scroll_vertical.
2166         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2167
2168 2019-06-25  Tom Tromey  <tom@tromey.com>
2169
2170         * tui/tui-data.h (struct tui_source_window_base): New struct.
2171         (struct tui_source_window): Derive from tui_source_window_base.
2172         (struct tui_disasm_window): New struct.
2173         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2174         from tui_source_window::clear_detail.
2175         (tui_source_window_base): Rename from tui_source_window.
2176         (~tui_source_window_base): Rename from ~tui_source_window.
2177         (tui_alloc_win_info): Create a tui_disasm_window.
2178
2179 2019-06-25  Tom Tromey  <tom@tromey.com>
2180
2181         * tui/tui-data.h (struct tui_source_window)
2182         (struct tui_data_window): Declare destructors.
2183         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2184         destructors.
2185         (tui_win_info): Simplify.
2186
2187 2019-06-25  Tom Tromey  <tom@tromey.com>
2188
2189         * tui/tui-winsource.c (tui_display_main)
2190         (tui_update_source_windows_with_addr)
2191         (tui_update_all_breakpoint_info): Update.
2192         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2193         (new_height_ok, parse_scrolling_args): Update.
2194         * tui/tui-stack.c (tui_show_frame_info): Update.
2195         * tui/tui-data.h (struct tui_list): Remove.
2196         (tui_source_windows): Return a reference to a std::vector.
2197         * tui/tui-data.c (source_windows): Now a std::vector.
2198         (tui_source_windows): Change return type.
2199         (tui_clear_source_windows): Rewrite.
2200         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2201         (tui_free_all_source_wins_content): Rewrite.
2202
2203 2019-06-25  Tom Tromey  <tom@tromey.com>
2204
2205         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2206         (struct tui_data_window, struct tui_cmd_window): Declare
2207         clear_detail method.
2208         * tui/tui-data.c (tui_source_window::clear_detail)
2209         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2210         methods.
2211         (tui_clear_win_detail): Simplify.
2212
2213 2019-06-25  Tom Tromey  <tom@tromey.com>
2214
2215         * tui/tui-layout.c (make_source_window, make_disasm_window)
2216         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2217         Return the new window.
2218         (show_source_disasm_command, show_data)
2219         (show_source_or_disasm_and_command): Update.
2220
2221 2019-06-25  Tom Tromey  <tom@tromey.com>
2222
2223         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2224         parameter.  Return the new window.
2225         (show_source_disasm_command): Update and remove NULL check.
2226         (show_source_or_disasm_and_command): Update.
2227
2228 2019-06-25  Tom Tromey  <tom@tromey.com>
2229
2230         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2231
2232 2019-06-25  Tom Tromey  <tom@tromey.com>
2233
2234         * tui/tui-data.h (struct tui_win_info): Make constructor
2235         protected.  Make destructor virtual.  Add initializers.
2236         (tui_source_window, tui_data_window, tui_cmd_window): New
2237         classes.
2238         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2239         constructor.  Add "type" parameter.
2240         (tui_source_window, tui_data_window, tui_cmd_window): New
2241         constructors.
2242         (tui_alloc_win_info): Instantiate the appropriate subclass.
2243
2244 2019-06-25  Tom Tromey  <tom@tromey.com>
2245
2246         * tui/tui-win.c (tui_resize_all): Use delete.
2247         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2248         destructor.
2249         (tui_free_window): Don't declare.
2250         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2251         Update.
2252
2253 2019-06-25  Tom Tromey  <tom@tromey.com>
2254
2255         * tui/tui-data.h (struct tui_win_info): Add constructor.
2256         * tui/tui-data.c (tui_alloc_win_info): Use new.
2257         (tui_free_window): Use delete.
2258
2259 2019-06-22  Tom Tromey  <tom@tromey.com>
2260
2261         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2262         declare.
2263         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2264
2265 2019-06-22  Tom Tromey  <tom@tromey.com>
2266
2267         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2268         declare.
2269         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2270
2271 2019-06-22  Tom de Vries  <tdevries@suse.de>
2272
2273         * dwarf2read.c (create_addrmap_from_aranges)
2274         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2275         instead of '%zu'.
2276
2277 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2278
2279         * dwarf2read.h (dwarf2_section_info_def): Remove.
2280         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2281         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2282         std::vector<dwarf2_section_info>.
2283         (struct dwo_file) <~dwo_file>: Remove.
2284         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2285         types field.
2286         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2287         (dwarf2_read_debug_names): Likewise.
2288         (create_debug_types_hash_table): Change parameter type to
2289         array_view, adjust code accordingly.
2290         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2291         (partial_die_info::fixup): Likewise.
2292         (determine_prefix): Likewise.
2293         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2294
2295 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2296
2297         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2298         gdb_bfd_ref_ptr.
2299         <~dwo_file>: Remove call to gdb_bfd_unref.
2300         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2301         gdb_bfd_ref_ptr::get.
2302
2303 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2304
2305         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2306         type to htab_up.
2307         * dwarf2read.c (struct dwo_file): Initialize fields.
2308         <~dwo_file>: New.
2309         (free_dwo_file): Remove, move content to ~dwo_file.
2310         (struct dwo_file_deleter): Remove.
2311         (dwo_file_up>: Remove custom deleter.
2312         (free_dwo_files): Remove.
2313         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2314         dwo_files.
2315         (process_skeletonless_type_units): Call unique_ptr::get.
2316         (allocate_dwo_file_hash_table): Add deleter to created hash
2317         table.  Change return type to htab_up.
2318         (lookup_dwo_file_slot): Don't memset dwo_file, call
2319         unique_ptr::get.
2320         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2321         (create_dwo_unit_in_dwp_v2): Likewise.
2322         (open_and_init_dwo_file): Likewise.
2323         (free_dwo_file_from_slot): Remove.
2324
2325 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2326
2327         * dwarf2read.h (struct dwarf2_section_info) <readin,
2328         is_virtual>: Change type to bool.
2329         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2330         true instead of 1.
2331
2332 2019-06-19  Tom Tromey  <tom@tromey.com>
2333
2334         * tui/tui-data.h (tui_init_content_element): Don't declare.
2335
2336 2019-06-19  Tom Tromey  <tom@tromey.com>
2337
2338         * tui/tui-data.h (tui_init_win_info): Don't declare.
2339
2340 2019-06-19  Tom de Vries  <tdevries@suse.de>
2341
2342         * dwarf2read.h (abstract_to_concrete): Change type to
2343         std::unordered_map<sect_offset, std::vector<sect_offset>,
2344         gdb::hash_enum<sect_offset>>.
2345
2346 2019-06-19  Tom Tromey  <tromey@adacore.com>
2347
2348         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2349         EVAL_AVOID_SIDE_EFFECTS specially.
2350
2351 2019-06-19  Tom Tromey  <tromey@adacore.com>
2352
2353         * source-cache.c (highlighter): New global.
2354         (source_cache::get_source_lines): Create a highlighter on demand.
2355
2356 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2357
2358         * defs.h (deprecated_interactive_hook): Delete declaration.
2359         * interps.c (clear_interpreter_hooks): Remove use of
2360         deprecated_interactive_hook.
2361         * top.c (deprecated_interactive_hook): Delete definition.
2362         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2363
2364 2019-06-18  Tom de Vries  <tdevries@suse.de>
2365
2366         PR gdb/24515
2367         * dwarf2read.h (abstract_to_concrete): Change type from
2368         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2369         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2370         * dwarf2read.c (read_variable): Update.
2371         (dwarf2_fetch_die_loc_sect_off): Update.
2372
2373 2019-06-17  Tom de Vries  <tdevries@suse.de>
2374
2375         PR gdb/24617
2376         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2377         accessing parent[parent_len - 1].
2378
2379 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2380
2381         PR gdb/24364
2382         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2383         call dtrace_process_dof with NULL dof.
2384
2385 2019-06-16  Tom de Vries  <tdevries@suse.de>
2386
2387         PR gdb/24445
2388         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2389
2390 2019-06-16  Tom Tromey  <tom@tromey.com>
2391
2392         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2393         (make_all_visible): Use address of member.
2394
2395 2019-06-16  Tom Tromey  <tom@tromey.com>
2396
2397         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2398         (tui_free_window, free_content, free_content_elements): Remove
2399         unnecessary cast.
2400         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2401         cast.
2402         * tui/tui-regs.c (tui_show_register_group)
2403         (tui_display_registers_from, tui_display_reg_element_at_line):
2404         Remove unnecessary cast.
2405
2406 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2407
2408         * linux-nat.c (normal_mask): Delete.
2409         (_initialize_linux_nat): Don't initialise normal_mask.
2410
2411 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2412
2413         PR gdb/24445
2414         * dwarf-index-write.h (write_psymtabs_to_index): Add
2415         dwz_basename parameter.
2416         * dwarf-index-write.c (write_gdbindex): Move file writing to
2417         write_gdbindex_1.  Change return type void.
2418         (assert_file_size): Move up, remove filename parameter.
2419         (write_gdbindex_1): New function.
2420         (write_debug_names): Change return type to void, call
2421         assert_file_size.
2422         (struct index_wip_file): New struct.
2423         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2424         file logic to index_wip_file.  Write index for dwz file if
2425         needed.
2426         (save_gdb_index_command): Pass basename of dwz file, if present.
2427         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2428         build-id of dwz file, if present.
2429         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2430         (dwarf2_get_dwz_file): Likewise.
2431         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2432         (dwarf2_get_dwz_file): Likewise.
2433
2434 2019-06-16  Tom Tromey  <tom@tromey.com>
2435
2436         * coffread.c (process_coff_symbol): Use xstrdup.
2437         * value.c (create_internalvar): Use xstrdup.
2438
2439 2019-06-16  Tom Tromey  <tom@tromey.com>
2440
2441         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2442         * breakpoint.c (stopin_command, stopat_command)
2443         (until_break_command, decode_location_default): Remove unnecessary
2444         cast.
2445         * utils.c (subset_compare): Remove unnecessary cast.
2446         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2447         cast.
2448         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2449         cast.
2450         * infcmd.c (path_command): Remove unnecessary cast.
2451         * coffread.c (decode_type): Remove unnecessary cast.
2452         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2453         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2454         * tui/tui-stack.c (tui_show_locator_content)
2455         (tui_show_frame_info): Remove unnecessary cast.
2456         * tui/tui-win.c (tui_scroll_forward_command)
2457         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2458         (parse_scrolling_args): Remove unnecessary cast.
2459         * tui/tui-data.c (init_win_info, tui_del_window)
2460         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2461         (free_content_elements): Remove unnecessary cast.
2462         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2463         unnecessary cast.
2464         * tui/tui-source.c (tui_set_source_content)
2465         (tui_vertical_source_scroll): Remove unnecessary cast.
2466         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2467         cast.
2468         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2469         * tui/tui-regs.c (tui_display_registers_from)
2470         (tui_display_register): Remove unnecessary cast.
2471         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2472         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2473         (make_visible): Remove unnecessary cast.
2474         * tui/tui-winsource.c (tui_erase_source_content)
2475         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2476         unnecessary cast.
2477         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2478         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2479         * stabsread.c (read_type, read_array_type, read_range_type):
2480         Remove unnecessary cast.
2481         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2482         (parse_symbol, parse_type, upgrade_type, parse_external)
2483         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2484         unnecessary cast.
2485         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2486
2487 2019-06-16  Tom Tromey  <tom@tromey.com>
2488
2489         * tui/tui-data.c (tui_alloc_generic_win_info)
2490         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2491         checks.
2492
2493 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2494             Andrew Burgess  <andrew.burgess@embecosm.com>
2495
2496         * f-typeprint.c (f_print_type): Don't return early for not
2497         associated or not allocated types.
2498         (f_type_print_varspec_suffix): Add print_rank parameter and print
2499         ranks of array types in case they dangling.
2500         (f_type_print_base): Add print_rank parameter.
2501
2502 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2503
2504         * NEWS: Mention new MI commands.
2505         * break-catch-throw.c (enum exception_event_kind): Move to
2506         breakpoint.h.
2507         (print_mention_exception_catchpoint): Output text as a single
2508         message.
2509         (catch_exception_command_1): Rename to...
2510         (catch_exception_event): ...this, make non-static, update header
2511         command, and change some parameter types.
2512         (catch_catch_command): Update for changes to
2513         catch_exception_command_1.
2514         (catch_throw_command): Likewise.
2515         (catch_rethrow_command): Likewise.
2516         * breakpoint.c (enum exception_event_kind): Delete.
2517         * breakpoint.h (enum exception_event_kind): Moved here from
2518         break-catch-throw.c.
2519         (catch_exception_event): Declare.
2520         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2521         (mi_cmd_catch_throw): New function.
2522         (mi_cmd_catch_rethrow): New function.
2523         (mi_cmd_catch_catch): New function.
2524         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2525         'catch-catch' entries.
2526         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2527         (mi_cmd_catch_rethrow): Declare.
2528         (mi_cmd_catch_catch): Declare.
2529
2530 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2531
2532         * annotate.c (annotate_source_line): Change return type to void,
2533         update implementation to match.
2534         * annotate.h (annotate_source_line): Change return type to void,
2535         update header comment.
2536         * stack.c (print_frame_info): Don't change what frame information
2537         is printed based on whether annotations are on or not.
2538
2539 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2540
2541         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2542         (annotate_source): Make static.
2543         (annotate_source_line): Moved from source.c and renamed from
2544         identify_source_line.  Update the return type.
2545         * annotate.h (annotate_source): Delete declaration.
2546         (annotate_source_line): Declaration moved from source.h, and
2547         renamed from identify_source_line.  Return type updated.
2548         * source.c (identify_source_line): Moved to annotate.c and renamed
2549         to annotate_source_line.
2550         (info_line_command): Remove check of annotation_level.
2551         * source.h (identify_source_line): Move declaration to annotate.h
2552         and rename to annotate_source_line.
2553         * stack.c: Add 'annotate.h' include.
2554         (print_frame_info): Remove check of annotation_level before
2555         calling annotate_source_line.
2556
2557 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2558
2559         * source-cache.c (source_cache::get_plain_source_lines): Use
2560         open_source_file_with_line_charpos instead of just
2561         open_source_file, remove call to find_source_lines.
2562         (source_cache::get_source_lines): Likewise.
2563         * source.c (find_source_lines): Make static.
2564         (get_filename_and_charpos): Renamed into...
2565         (open_source_file_with_line_charpos): ..this along with changes to
2566         return a scoped_fd, and some other minor clean ups.
2567         (identify_source_line): Use open_source_file_with_line_charpos.
2568         (search_command_helper): Use open_source_file_with_line_charpos
2569         instead of just open_source_file, remove call to
2570         find_source_lines.
2571         * source.h (open_source_file_with_line_charpos): Declare new
2572         function.
2573         (find_source_lines): Delete declaration.
2574
2575 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2576
2577         * source.c (get_filename_and_charpos): Remove fullname
2578         parameter.
2579         (identify_source_line): Update call to get_filename_and_charpos.
2580
2581 2019-06-14  Tom Tromey  <tromey@adacore.com>
2582
2583         PR gdb/24502:
2584         * ui-style.h (skip_ansi_escape): Update comment.
2585         * ui-file.h (class no_terminal_escape_file): New class.
2586         * ui-file.c (no_terminal_escape_file::write)
2587         (no_terminal_escape_file::puts): New methods.
2588         * cli/cli-logging.c (handle_redirections): Use
2589         no_terminal_escape_file.
2590
2591 2019-06-14  Tom Tromey  <tromey@adacore.com>
2592
2593         * NEWS: Move convenience variable news above Python news.
2594
2595 2019-06-14  Tom Tromey  <tom@tromey.com>
2596
2597         * gnulib: Move directory to top-level.
2598         * configure.ac: Don't configure gnulib.
2599         * configure: Rebuild.
2600         * common/common-defs.h: Use new path to gnulib.
2601         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2602         (GNULIB_H): Remove.
2603         (INCGNU): Look in new gnulib location.
2604         (HFILES_NO_SRCDIR): Remove gnulib files.
2605         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2606         (generated_files): Remove GNULIB_H.
2607         ($(LIBGNU), all-lib): Remove targets.
2608         (distclean): Don't mention GNULIB_BUILDDIR.
2609         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2610
2611 2019-06-14  Tom Tromey  <tromey@adacore.com>
2612
2613         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2614         Warn if symbol file does not provide any symbols.
2615
2616 2019-06-14  Tom Tromey  <tromey@adacore.com>
2617
2618         * source.c (find_and_open_source): Respect basenames_may_differ.
2619
2620 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2621
2622         * annotate.c (annotate_breakpoints_invalid): Make use of
2623         scoped_restore_terminal_state.
2624         (annotate_frames_invalid): Likewise.
2625
2626 2019-06-14  Tom Tromey  <tromey@adacore.com>
2627
2628         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2629         allow assignment to an internalvar.
2630
2631 2019-06-14  Tom Tromey  <tromey@adacore.com>
2632
2633         * ada-lex.l: Allow "_" in attribute names.
2634
2635 2019-06-14  Tom Tromey  <tromey@adacore.com>
2636
2637         PR gdb/24653:
2638         * regcache.c (registers_changed): Don't call alloca.
2639         * top.c (execute_command): Don't call alloca.
2640
2641 2019-06-13  Pedro Alves  <palves@redhat.com>
2642
2643         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2644         'expression'.  When parsing an expression, error out if there's
2645         junk after "unlimited".
2646         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2647         (do_set_command): Adjust calls to is_unlimited_literal.
2648
2649 2019-06-13  Pedro Alves  <palves@redhat.com>
2650
2651         * compile/compile.c (make_compile_options_def_group): Add braces
2652         around array_view initializer.
2653         * thread.c (make_thread_apply_all_options_def_group)
2654         (make_thread_apply_all_options_def_group): Likewise.
2655
2656 2019-06-13  Pedro Alves  <palves@redhat.com>
2657
2658         * NEWS (New commands): Mention "maint test-options
2659         require-delimiter", "maint test-options unknown-is-error", "maint
2660         test-options unknown-is-operand" and "maint show
2661         test-options-completion-result".
2662         (New command options, command completion): New section.
2663         (Completion improvements): New section.
2664         Mention that you can abbreviate "unlimited".
2665
2666 2019-06-13  Pedro Alves  <palves@redhat.com>
2667
2668         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2669         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2670         * unittests/cli-utils-selftests.c (test_parse_flags)
2671         (test_parse_flags_qcs): Delete.
2672         (test_cli_utils): Don't call deleted functions.
2673
2674 2019-06-13  Pedro Alves  <palves@redhat.com>
2675
2676         * thread.c: Include "cli/cli-option.h".
2677         (tp_array_compar_ascending): Global.
2678         (tp_array_compar): Delete function.
2679         (tp_array_compar_ascending, tp_array_compar_descending): New
2680         functions.
2681         (ascending_option_def, qcs_flag_option_def)
2682         (thr_qcs_flags_option_defs)
2683         (make_thread_apply_all_options_def_group)
2684         (make_thread_apply_options_def_group): New.
2685         (thread_apply_all_command): Use gdb::option::process_options.
2686         (thread_apply_command_completer)
2687         (thread_apply_all_command_completer): New.
2688         (thread_apply_command): Use gdb::option::process_options.
2689         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2690         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2691         to generate help text of "thread apply".  Adjust "taas"'s help.
2692         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2693         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2694
2695 2019-06-13  Pedro Alves  <palves@redhat.com>
2696
2697         * thread.c (thread_apply_command): Check for invalid TID with
2698         isdigit instead of !isalpha.
2699
2700 2019-06-13  Pedro Alves  <palves@redhat.com>
2701
2702         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2703         (validate_flags_qcs): New.
2704         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2705         (validate_flags_qcs): Declare.
2706         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2707         (make_frame_apply_options_def_group): New.
2708         (frame_apply_command_count): Process options with
2709         gdb::option::process_options.
2710         (frame_apply_completer): New.
2711         (frame_apply_level_completer, frame_apply_all_completer)
2712         (frame_apply_completer): New.
2713         (_initialize_stack): Update help of "frame apply", "frame apply
2714         level", "frame apply all" and "faas" to mention supported options
2715         and install command completers.
2716         * stack.h (frame_apply_all_completer): Declare.
2717         * thread.c: Include "stack.h".
2718         (tfaas_command): Add "--".
2719         (_initialize_thread): Update help "tfaas" to mention supported
2720         options and install command completer.
2721
2722 2019-06-13  Pedro Alves  <palves@redhat.com>
2723
2724         * completer.c (complete_nested_command_line): New.
2725         (gdb_completion_word_break_characters_throw): Add assertion.
2726         * completer.h (complete_nested_command_line): Declare.
2727
2728 2019-06-13  Pedro Alves  <palves@redhat.com>
2729
2730         * stack.c (parse_backtrace_qualifiers): New.
2731         (backtrace_command): Use it.
2732         (backtrace_command_completer): Complete on qualifiers.
2733
2734 2019-06-13  Pedro Alves  <palves@redhat.com>
2735
2736         * frame.c: Include "cli/cli-option.h.
2737         (user_set_backtrace_options): New.
2738         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2739         Delete.
2740         (get_prev_frame): Adjust.
2741         (boolean_option_def, uinteger_option_def)
2742         (set_backtrace_option_defs): New.
2743         (_initialize_frame): Adjust and use
2744         gdb::option::add_setshow_cmds_for_options to install "set
2745         backtrace past-main" and "set backtrace past-entry".
2746         * frame.h: Include "cli/cli-option.h".
2747         (struct frame_print_options): Forward declare.
2748         (print_frame_arguments_all, print_frame_arguments_scalars)
2749         (print_frame_arguments_none): Declare.
2750         (print_entry_values): Delete declaration.
2751         (struct frame_print_options, user_frame_print_options): New.
2752         (struct set_backtrace_options): New.
2753         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2754         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2755         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2756         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2757         (list_args_or_locals): Add frame_print_options parameter.
2758         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2759         * python/py-framefilter.c (enumerate_args): Pass down
2760         USER_FRAME_PRINT_OPTIONS.
2761         * stack.c: Include "cli/cli-option.h".
2762         (print_frame_arguments_all, print_frame_arguments_scalars)
2763         (print_frame_arguments_none): Declare.
2764         (print_raw_frame_arguments, print_entry_values): Delete.
2765         (user_frame_print_options): New.
2766         (boolean_option_def, enum_option_def, frame_print_option_defs):
2767         New.
2768         (struct backtrace_cmd_options): New.
2769         (bt_flag_option_def): New.
2770         (backtrace_command_option_defs): New.
2771         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2772         (print_frame_arg, read_frame_arg, print_frame_args)
2773         (print_frame_info, print_frame): Add frame_print_options parameter
2774         and use it.
2775         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2776         (backtrace_command_1): Add frame_print_options and
2777         backtrace_cmd_options parameters and use them.
2778         (make_backtrace_options_def_group): New.
2779         (backtrace_command): Process command options with
2780         gdb::option::process_options.
2781         (backtrace_command_completer): New.
2782         (_initialize_stack): Extend "backtrace"'s help to mention
2783         supported options.  Install completer for "backtrace".
2784         Install some settings commands with add_setshow_cmds_for_options.
2785
2786 2019-06-13  Pedro Alves  <palves@redhat.com>
2787
2788         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2789         and that "set/show print raw frame-arguments" are now deprecated.
2790
2791         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2792         command.
2793         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2794         * stack.c (_initialize_stack): Install "set/show print
2795         raw-frame-arguments", and deprecate "set/show print raw
2796         frame-arguments".
2797         * valprint.c (_initialize_valprint): Deprecate "set/show print
2798         raw".
2799
2800 2019-06-13  Pedro Alves  <palves@redhat.com>
2801
2802         * compile/compile.c (struct compile_options): New.
2803         (compile_flag_option_def, compile_command_option_defs)
2804         (make_compile_options_def_group): New.
2805         (compile_file_command): Handle options with
2806         gdb::option::process_options.
2807         (compile_file_command_completer): New function.
2808         (compile_code_command): Handle options with
2809         gdb::option::process_options.
2810         (compile_code_command_completer): New function.
2811         (_initialize_compiler): Install completers for "compile code" and
2812         "compile file".  Mention available options in "compile code" and
2813         "compile code"'s help.
2814         * completer.c (advance_to_completion_word): New, factored out from
2815         ...
2816         (advance_to_expression_complete_word_point): ... this.
2817         (advance_to_filename_complete_word_point): New.
2818         * completer.h (advance_to_filename_complete_word_point): New
2819         declaration.
2820
2821 2019-06-13  Pedro Alves  <palves@redhat.com>
2822
2823         * compile/compile.c: Include "cli/cli-option.h".
2824         (compile_print_value): Scope data pointer is now a
2825         value_print_options pointer; adjust.
2826         (compile_print_command): Process options.  Scope data pointer is
2827         now a value_print_options pointer; adjust.
2828         (_initialize_compile): Update "compile print"'s help to include
2829         supported options.  Install a completer for "compile print".
2830         * cp-valprint.c (show_vtblprint, show_objectprint)
2831         (show_static_field_print): Delete.
2832         (_initialize_cp_valprint): Don't install "set print
2833         static-members", "set print vtbl", "set print object" here.
2834         * printcmd.c: Include "cli/cli-option.h" and
2835         "common/gdb_optional.h".
2836         (print_command_parse_format): Rework to fill in a
2837         value_print_options instead of a format_data.
2838         (print_value): Change parameter type from format_data pointer to
2839         value_print_options reference.  Adjust.
2840         (print_command_1): Process options.  Adjust to pass down a
2841         value_print_options.
2842         (print_command_completer): New.
2843         (_initialize_printcmd): Install print_command_completer as
2844         handle_brkchars completer for the "print" command.  Update
2845         "print"'s help to include supported options.
2846         * valprint.c: Include "cli/cli-option.h".
2847         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2848         here from cp-valprint.c.
2849         (boolean_option_def, uinteger_option_def)
2850         (value_print_option_defs, make_value_print_options_def_group):
2851         New.  Use gdb::option::add_setshow_cmds_for_options to install
2852         "set print elements", "set print null-stop", "set print repeats",
2853         "set print pretty", "set print union", "set print array", "set
2854         print address", "set print symbol", "set print array-indexes".
2855         * valprint.h: Include <string> and "cli/cli-option.h".
2856         (make_value_print_options_def_group): Declare.
2857         (print_value): Change parameter type from format_data pointer to
2858         value_print_options reference.
2859         (print_command_completer): Declare.
2860
2861 2019-06-13  Pedro Alves  <palves@redhat.com>
2862
2863         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2864         (COMMON_SFILES): Add maint-test-settings.c.
2865         * cli/cli-decode.c (boolean_enums): New global, factored out from
2866         ...
2867         (add_setshow_boolean_cmd): ... here.
2868         * cli/cli-decode.h (boolean_enums): Declare.
2869         * cli/cli-option.c: New file.
2870         * cli/cli-option.h: New file.
2871         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2872         factored out from ...
2873         (parse_cli_boolean_value(const char *)): ... this.
2874         (is_unlimited_literal): Change parameter type to pointer to
2875         pointer.  Adjust and advance ARG pointer.
2876         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2877         (parse_cli_var_enum): New, factored out from ...
2878         (do_set_command): ... this.  Adjust.
2879         * cli/cli-setshow.h (parse_cli_boolean_value)
2880         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2881         (parse_cli_var_enum): Declare.
2882         * cli/cli-utils.c: Include "cli/cli-option.h".
2883         (get_ulongest): New.
2884         * cli/cli-utils.h (get_ulongest): Declare.
2885         (check_for_argument): New overloads.
2886         * maint-test-options.c: New file.
2887
2888 2019-06-13  Pedro Alves  <palves@redhat.com>
2889
2890         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2891         parse a range if "-" is at the end of the string.
2892
2893 2019-06-13  Pedro Alves  <palves@redhat.com>
2894
2895         * cli/cli-setshow.c (parse_auto_binary_operation)
2896         (parse_cli_boolean_value): Don't allow "o".
2897
2898 2019-06-13  Pedro Alves  <palves@redhat.com>
2899
2900         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2901         * NEWS: Mention maint test-settings KIND.
2902         * maint-test-settings.c: New file.
2903
2904 2019-06-13  Pedro Alves  <palves@redhat.com>
2905
2906         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2907         completer.
2908         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2909         "set" completers.
2910
2911 2019-06-13  Pedro Alves  <palves@redhat.com>
2912
2913         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2914         after item.
2915
2916 2019-06-13  Pedro Alves  <palves@redhat.com>
2917
2918         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2919
2920 2019-06-13  Pedro Alves <palves@redhat.com>
2921
2922         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2923         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2924         call.
2925         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2926         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2927         calls.
2928         (check_for_argument): Skip spaces after argument.
2929
2930 2019-06-13  Pedro Alves  <palves@redhat.com>
2931
2932         * thread.c (thread_apply_command): Adjust TID parsing.
2933         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2934         detected before end of string.
2935         (tid_is_in_list): Error out if LIST is invalid.
2936
2937 2019-06-13  Pedro Alves  <palves@redhat.com>
2938
2939         * completer.c (complete_line_internal_1): Rewind completion word
2940         point.
2941         (completion_tracker::advance_custom_word_point_by): Change
2942         parameter type to int.
2943         * completer.h (completion_tracker::advance_custom_word_point_by):
2944         Likewise.
2945
2946 2019-06-13  Pedro Alves  <palves@redhat.com>
2947
2948         * completer.c (advance_to_completion_word): Handle delimiters.
2949
2950 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2951
2952         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2953
2954 2019-06-11  Tom Tromey  <tom@tromey.com>
2955
2956         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2957         (xmalloc_failed): Move to alloc.c.
2958         * alloc.c: New file.
2959         * Makefile.in (COMMON_SFILES): Add alloc.c.
2960
2961 2019-06-11  Tom Tromey  <tom@tromey.com>
2962
2963         * nat/linux-waitpid.c: Don't include server.h.
2964         (linux_debug): Remove.
2965         (my_waitpid): Update.
2966
2967 2019-06-11  Tom Tromey  <tromey@adacore.com>
2968
2969         * infcall.c (_initialize_infcall): Remove trailing newline from
2970         help.
2971         * user-regs.c (_initialize_user_regs): Remove trailing newline
2972         from help.
2973         * typeprint.c (_initialize_typeprint): Remove trailing newline
2974         from help.
2975         * reverse.c (_initialize_reverse): Remove trailing newlines from
2976         help.
2977         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2978         from help.
2979         * language.c (add_set_language_command): Remove trailing newline
2980         from help.
2981         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2982         help.
2983         * disasm.c (_initialize_disasm): Remove trailing newline from
2984         help.
2985         * top.c (init_main): Remove trailing newline from help.
2986         * interps.c (_initialize_interpreter): Remove trailing newline
2987         from help.
2988         * btrace.c (_initialize_btrace): Remove trailing newlines from
2989         help.
2990         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2991         from help.
2992         * python/python.c (_initialize_python): Remove trailing newline
2993         from help.
2994         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2995         help.
2996         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2997         from help.  Reformat some text.
2998         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2999         from help.
3000         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3001         newline from help.
3002
3003 2019-06-11  Tom Tromey  <tromey@adacore.com>
3004
3005         * darwin-nat.c (darwin_decode_exception_message)
3006         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3007
3008 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3009
3010         * valops.c (value_slice): Check for not allocated or not
3011         associated values.
3012
3013 2019-06-10  Tom de Vries  <tdevries@suse.de>
3014
3015         PR gdb/24618
3016         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3017         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3018         invalid.
3019
3020 2019-06-10  Tom de Vries  <tdevries@suse.de>
3021
3022         PR gdb/24611
3023         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3024         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3025
3026 2019-06-10  Tom de Vries  <tdevries@suse.de>
3027
3028         PR symtab/24545
3029         * symtab.c (struct demangled_name_entry): Add language field.
3030         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3031         static minimal symbol".  Set and use language field.
3032
3033 2019-06-10  Tom Tromey  <tromey@adacore.com>
3034
3035         * ada-lang.c (_initialize_ada_language): Update help text.
3036
3037 2019-06-10  Tom Tromey  <tromey@adacore.com>
3038
3039         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3040         with a newline.
3041         * guile/guile.c (handle_boot_error): Don't end warning with a
3042         newline.
3043         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3044         warning with a newline.
3045         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3046         newline.
3047         (s12z_frame_cache): Likewise.
3048         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3049         a newline.
3050         * solib-svr4.c (disable_probes_interface): Don't end warning with
3051         a newline.
3052         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3053         newline.
3054         * python/python.c (do_finish_initialization): Don't end warning
3055         with a newline.
3056
3057 2019-06-10  Tom Tromey  <tom@tromey.com>
3058
3059         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3060         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3061         gdbpy_enter.
3062
3063 2019-06-10  Tom Tromey  <tromey@adacore.com>
3064
3065         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3066         data.
3067         (elf_new_init): Don't call stabsread_new_init.
3068         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3069         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3070         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3071
3072 2019-06-10  Tom de Vries  <tdevries@suse.de>
3073
3074         PR symtab/16264
3075         PR symtab/24517
3076         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3077
3078 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3079
3080         * source.c (find_and_open_source): Also rewrite relative file
3081         names.
3082
3083 2019-04-26  Amos Bird  <amosbird@gmail.com>
3084
3085         * annotate.c (annotate_thread_exited): Add "thread-exited"
3086         annotation.
3087
3088 2019-06-06  Tom Tromey  <tromey@adacore.com>
3089
3090         * maint.h (class scoped_command_stats): Use
3091         DISABLE_COPY_AND_ASSIGN.
3092         <print_time>: New method.
3093         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3094         print_time.
3095         (scoped_command_stats::print_time): New method.
3096
3097 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3098
3099         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3100         instructions of lengths 6 or 8 bytes.
3101
3102 2019-06-04  Pedro Alves  <palves@redhat.com>
3103
3104         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3105
3106         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3107         * breakpoint.c (condition_completer): Likewise.
3108         * cli/cli-dump.c (scan_expression): Likewise.
3109         * common/filestuff.c (mkdir_recursive): Likewise.
3110         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3111         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3112         (gdb_abspath): Likewise.
3113         * compile/compile-cplus-types.c
3114         (compile_cplus_instance::decl_name): Likewise.
3115         * completer.c (complete_explicit_location):
3116         (signal_completer, reg_or_group_completer_1): Likewise.
3117         * cp-support.c (cp_remove_params_if_any): Likewise.
3118         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3119         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3120         * infcmd.c (strip_bg_char): Likewise.
3121         * linespec.c (copy_token_string): Likewise.
3122         * mi/mi-main.c (output_cores): Likewise.
3123         * psymtab.c (psymtab_search_name):
3124         * symfile.c (test_set_ext_lang_command): Likewise.
3125         * target.c (target_fileio_read_stralloc): Likewise.
3126         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3127         * value.c (complete_internalvar): Likewise.
3128
3129 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3130
3131         Add objfile property to gdb.Type.
3132         * NEWS: Mention Python API addition.
3133         * python/py-type.c (typy_get_objfile): New method.
3134
3135 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3136
3137         * NEWS: Mention the new set|show style [title|highlight].
3138         Mention changes to "show style", "help" and "apropos".
3139
3140 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3141
3142         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3143         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3144         instead of print_help_for_command.
3145         (print_doc_of_command): New function.
3146         (help_list): Add 'apropos -v word' suggestion.
3147         (print_help_for_command): Style the command name using title style.
3148         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3149         (_initialize_cli_cmds): Describe -v in apropos_command help.
3150
3151 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3152
3153         * cli/cli-style.h (cli_style_option): Add name in constructor,
3154         add m_name class member, add constructor with intensity,
3155         add name class function.
3156         (cli_style_option::add_setshow_commands): Remove name argument.
3157         (highlight_style, title_style): New styles.
3158         * cli/cli-style.c (do_show): New function that shows a style
3159         characteristic styling the style name with itself.
3160         (set_style_name): New function.
3161         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3162         Update all callers according to the changes in cli/cli-style.h.
3163         * utils.h (fputs_highlighted): New function.
3164         * utils.c (fputs_highlighted): Likewise.
3165
3166 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3167
3168         * NEWS: Mention new pipe command and new convenience variables.
3169
3170 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3171
3172         * cli/cli-cmds.c (pipe_command): New function.
3173         (_initialize_cli_cmds): Call add_com for pipe_command.
3174         Define | as an alias for pipe.
3175         (exit_status_set_internal_vars): New function.
3176         (shell_escape): Call exit_status_set_internal_vars.
3177         cli/cli-decode.c (find_command_name_length): Recognize | as
3178         a single character command.
3179
3180 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3181
3182         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3183         top.c (execute_command_to_ui_file): New function, mostly a copy
3184         of execute_command_to_string.
3185         (execute_command_to_string): Implement by calling
3186         execute_command_to_ui_file.
3187
3188 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3189
3190         * top.h (saved_command_line): Remove declaration.
3191         * top.c (previous_saved_command_line, previous_repeat_arguments):
3192         New variables.
3193         (saved_command_line): Make static, define together with other
3194         'repeat variables'.
3195         (dont_repeat): Clear repeat_arguments.
3196         (repeat_previous, get_saved_command_line, save_command_line):
3197         New functions.
3198         (gdb_init): Initialize saved_command_line
3199         and previous_saved_command_line.
3200         * main.c (captured_main_1): Remove saved_command_line initialization.
3201         * event-top.c (handle_line_of_input): Update to use
3202         the new 'repeat' related functions instead of direct access to
3203         saved_command_line.
3204         * command.h (repeat_previous, get_saved_command_line,
3205         save_command_line): New declarations.
3206         (dont_repeat): Add comment.
3207
3208 2019-05-30  Tom Tromey  <tromey@adacore.com>
3209
3210         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3211         Fix comment.
3212         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3213
3214 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3215
3216         PR cli/24587
3217         * completer.c (complete): Initialize variable word.
3218
3219 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3220
3221         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3222         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3223         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3224         'body' is NULL to the outter 'if', protecting the '!is_define'
3225         situation as well.
3226
3227 2019-05-29  Tom Tromey  <tromey@adacore.com>
3228
3229         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3230         (dwarf_unknown): New function.
3231         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3232         (dwarf_type_encoding_name): Use dwarf_unknown.
3233
3234 2019-05-29  Tom Tromey  <tromey@adacore.com>
3235
3236         PR c++/20020:
3237         * cp-valprint.c (cp_print_value_fields): Call
3238         cp_print_static_field inside "try".
3239
3240 2019-05-29  Tom Tromey  <tromey@adacore.com>
3241
3242         * inflow.c (struct terminal_info): Add default operator=.
3243         * configure: Rebuild.
3244         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3245         -Wdeprecated-copy-dtor, -Wredundant-move.
3246
3247 2019-05-29  Tom Tromey  <tromey@adacore.com>
3248
3249         * NEWS: Add entry.
3250         * infcmd.c (print_return_value_1): Handle finish_print
3251         option.
3252         (show_print_finish): New function.
3253         (_initialize_infcmd): Add "set/show print finish" commands.
3254         * valprint.c (user_print_options): Initialize new member.
3255         * valprint.h (struct value_print_options) <finish_print>: New
3256         member.
3257
3258 2019-05-28  Tom Tromey  <tromey@adacore.com>
3259
3260         * ada-lang.c (ada_remove_Xbn_suffix)
3261         (find_old_style_renaming_symbol)
3262         (parse_old_style_renaming): Remove.
3263         (ada_find_renaming_symbol): Don't call
3264         find_old_style_renaming_symbol.
3265         (ada_is_renaming_symbol): Rename from
3266         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3267         bool.  Now static.
3268         (ada_read_var_value): Update and simplify.
3269         * ada-exp.y (write_var_or_type): Remove old code.
3270
3271 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3272
3273         * event-top.c: Remove include comment.
3274         * inflow.c (class scoped_ignore_sigttou): Move from here...
3275         * inflow.h (class scoped_ignore_sigttou): ...to here.
3276         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3277         * top.c:  Remove include comment.
3278
3279 2019-05-27  Tom Tromey  <tom@tromey.com>
3280
3281         * NEWS: Fix typo.
3282
3283 2019-05-22  Tom Tromey  <tromey@adacore.com>
3284
3285         * target.c (target_follow_exec): Constify parameter.
3286         * target-delegates.c: Rebuild.
3287         * remote.c (remote_target::follow_exec): Constify parameter.
3288         * infrun.c (follow_exec): Constify parameter.
3289         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3290         (target_follow_exec): Likewise.
3291
3292 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3293
3294         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3295         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3296
3297 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3298
3299         * NEWS: Add debugredirect and testsuite sections.
3300
3301 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3302
3303         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3304         target descriptions using exclusively floating point register name
3305         aliases.
3306
3307 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3308
3309         PR gdb/18644:
3310         * f-lang.c (build_fortran_types): Handle the case where
3311         gdbarch_floatformat_for_type returns a nullptr.
3312
3313 2019-05-21  Tom de Vries  <tdevries@suse.de>
3314
3315         PR cli/24587
3316         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3317
3318 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3319
3320         PR gdb/18644:
3321         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3322         16-byte floats.
3323         * i386-tdep.c (i386_floatformat_for_type): Use
3324         floatformats_ia64_quad for the 16-byte floating point component
3325         within a fortran 32-byte complex number.
3326
3327 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3328
3329         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3330         delete default constructor.
3331         (find_partial_die): Update to return const struct.
3332         (partial_die_parent_scope): Move variable declaration into scope
3333         of its use and change its type to auto.
3334         (guess_partial_die_structure_name): Likewise.
3335         (partial_die_info::fixup): Likewise.
3336
3337 2019-05-17  Tom Tromey  <tromey@adacore.com>
3338
3339         * source.c (find_and_open_source): Remove cast.
3340
3341 2019-05-17  Tom Tromey  <tromey@adacore.com>
3342
3343         * annotate.c (annotate_source): Make "filename" const.
3344         * annotate.h (annotate_source): Use const.
3345
3346 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3347
3348         * disasm.c (set_disassembler_options): Send errors to stderr.
3349
3350 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3351
3352         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3353         (cli_interp_base::set_logging): Check debug_redirect.
3354         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3355         * cli/cli-logging.c (debug_redirect): Add static variable.
3356         (pop_output_files): Add default param.
3357         (handle_redirections): Print debug setting.
3358         (show_logging_command): Likewise.
3359         (_initialize_cli_logging): Add debugredirect command.
3360         * interps.c (current_interp_set_logging): Add debug_redirect
3361         parameter.
3362         * interps.h (set_logging): Add debug_redirect parameter.
3363         (current_interp_set_logging): Likewise.
3364         * mi/mi-common.h: Likewise.
3365         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3366
3367 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3368             Tom Tromey  <tromey@adacore.com>
3369
3370         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3371         directly.
3372         * cli/cli-interp.h (make_logging_output): Remove declaration.
3373         * cli/cli-logging.c (make_logging_output): Remove function.
3374         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3375         directly.
3376         * ui-file.c (tee_file::tee_file): Remove bools.
3377         (tee_file::~tee_file): Remove deletes.
3378         * ui-file.h (tee_file): Remove bools.
3379
3380 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3381
3382         * mi/mi-cmds.h (mi_cmd_complete): New function.
3383         * mi/mi-main.c (mi_cmd_complete): Likewise.
3384         * mi/mi-cmds.c: Define new MI command -complete.
3385         * NEWS: Mention new -complete command.
3386
3387 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3388
3389         * completer.h (complete): New function.
3390         * completer.c (complete): Likewise.
3391         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3392         function defined in completer.h.
3393
3394 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3395
3396         * MAINTAINERS (Write After Approval): Add myself.
3397
3398 2019-05-17  Tom de Vries  <tdevries@suse.de>
3399
3400         PR gdb/24094
3401         * dwarf2read.c (struct cu_partial_die_info): New struct.
3402         (find_partial_die): Return cu_partial_die_info.
3403         (partial_die_parent_scope, guess_partial_die_structure_name)
3404         (partial_die_info::fixup): Handle new return type of find_partial_die.
3405
3406 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3407
3408         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3409         "std::string", simplifying the algorithm.
3410
3411 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3412
3413         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3414         (stap_static_probe_ops::get_probes): Likewise.
3415
3416 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3417
3418         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3419         '-')" and "else if".
3420         (stap_parse_single_operand): Join checks for
3421         "gdbarch_stap_parse_special_token_p" and
3422         "gdbarch_stap_parse_special_token" in the same "if" statement.
3423         Invert check when verifying for operation on register
3424         displacement.
3425
3426 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3427
3428         * stap-probe.c (stap_get_opcode): Update comment.
3429         (stap_get_expected_argument_type): Likewise.
3430         (handle_stap_probe): Likewise.
3431
3432 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3433
3434         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3435         return type to 'bool'.  Adjust comment.  Use 'bool' when
3436         appropriate.
3437         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3438         * stap-probe.c (stap_parse_argument_1): Likewise.
3439         (stap_is_operator): Likewise.
3440         (stap_is_generic_prefix): Likewise.
3441         (stap_is_register_prefix): Likewise.
3442         (stap_is_register_indirection_prefix): Likewise.
3443         (stap_is_integer_prefix): Likewise.
3444         (stap_generic_check_suffix): Likewise.
3445         (stap_check_integer_suffix): Likewise.
3446         (stap_check_register_suffix): Likewise.
3447         (stap_check_register_indirection_suffix): Likewise.
3448         (stap_parse_register_operand): Likewise.
3449         (stap_parse_single_operand): Likewise.
3450         (stap_parse_argument_1): Likewise.
3451         (stap_probe::get_argument_count): Likewise.
3452         (stap_is_operator): Likewise.
3453
3454 2019-05-16  Tom Tromey  <tromey@adacore.com>
3455
3456         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3457         keyword to foreach.
3458
3459 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3460
3461         * linux-thread-db.c (try_thread_db_load_1): Change return type
3462         to bool.
3463         (try_thread_db_load): Likewise.
3464         (try_thread_db_load_from_pdir_1): Likewise.
3465         (try_thread_db_load_from_pdir): Likewise.
3466         (try_thread_db_load_from_sdir): Likewise.
3467         (try_thread_db_load_from_dir): Likewise.
3468         (thread_db_load_search): Likewise.
3469         (has_libpthread): Likewise.
3470         (thread_db_load): Likewise.
3471
3472 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3473
3474         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3475         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3476         NULL, and complain/return if that's the case.
3477
3478 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3479
3480         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3481         (advance, posn, abstract_read_memory): New functions.
3482         [struct mem_read_abstraction]: New struct.
3483         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3484
3485 2019-05-14  Tom Tromey  <tromey@adacore.com>
3486
3487         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3488         value is not lval_memory.
3489
3490 2019-05-14  Tom Tromey  <tromey@adacore.com>
3491
3492         * solib.c (info_sharedlibrary_command): Style the file name.
3493
3494 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3495
3496         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3497         (aarch64_vnv_type): Likewise.
3498         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3499         * common/tdesc.c: Likewise.
3500         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3501         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3502         * features/aarch64-fpu.xml: Add ieee half view.
3503         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3504         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3505         * gdbtypes.h (struct builtin_type): Likewise.
3506         (struct objfile_type): Likewise.
3507
3508 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3509
3510         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3511         typo.
3512         * location.h (string_to_event_location): Likewise.
3513
3514 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3515
3516         GDB 8.3 released.
3517
3518 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3519
3520         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3521         New variable declaration.
3522         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3523         New variable.
3524         (print_one_breakpoint): Use ui_out::test_flags and new global
3525         variable to compute use_fixed_output.
3526         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3527         Remove.
3528         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3529         (mi_multi_location_breakpoint_output_fixed): Remove.
3530         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3531         new variable.
3532         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3533         fix_multi_location_breakpoint_output flag if version >= 3.
3534         * ui-out.h (enum ui_out_flag)
3535         <fix_multi_location_breakpoint_output>: New enumerator.
3536
3537 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3538
3539         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3540
3541 2019-05-10  Tom Tromey  <tromey@adacore.com>
3542
3543         * ada-lang.c (catch_ada_completer): New function.
3544         (_initialize_ada_language): Use it.
3545
3546 2019-05-10  Tom Tromey  <tromey@adacore.com>
3547
3548         * thread.c (print_thread_info): Make "requested_threads" const.
3549         * gdbthread.h (print_thread_info): Make "requested_threads"
3550         const.
3551         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3552         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3553
3554 2019-05-08  Tom Tromey  <tom@tromey.com>
3555
3556         * gdbtypes.c (objfile_type_data): Change type.
3557         (objfile_type, _initialize_gdbtypes): Update.
3558
3559 2019-05-08  Tom Tromey  <tom@tromey.com>
3560
3561         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3562         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3563         (_initialize_dwarf2_frame): Update.
3564
3565 2019-05-08  Tom Tromey  <tom@tromey.com>
3566
3567         * objc-lang.c (objc_objfile_data): Change type.
3568         (find_methods): Update.
3569         (_initialize_objc_lang): Remove.
3570
3571 2019-05-08  Tom Tromey  <tom@tromey.com>
3572
3573         * stabsread.c (rs6000_builtin_type_data): Change type.
3574         (rs6000_builtin_type, _initialize_stabsread): Update.
3575
3576 2019-05-08  Tom Tromey  <tom@tromey.com>
3577
3578         * mips-tdep.c (mips_pdr_data): Remove.
3579         (_initialize_mips_tdep): Update.
3580
3581 2019-05-08  Tom Tromey  <tom@tromey.com>
3582
3583         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3584         (hppa_init_objfile_priv_data, read_unwind_info)
3585         (find_unwind_entry, _initialize_hppa_tdep): Update.
3586
3587 2019-05-08  Tom Tromey  <tom@tromey.com>
3588
3589         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3590         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3591         on obstack.
3592         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3593
3594 2019-05-08  Tom Tromey  <tom@tromey.com>
3595
3596         * mdebugread.c (basic_type_data): Change type.
3597         (basic_type, _initialize_mdebugread): Update.
3598
3599 2019-05-08  Tom Tromey  <tom@tromey.com>
3600
3601         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3602
3603 2019-05-08  Tom Tromey  <tom@tromey.com>
3604
3605         * nto-tdep.c (nto_inferior_data_reg): Change type.
3606         (nto_inferior_data): Update.
3607         (nto_inferior_data_cleanup, nto_new_inferior_data)
3608         (_initialize_nto_tdep): Remove.
3609         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3610
3611 2019-05-08  Tom Tromey  <tom@tromey.com>
3612
3613         * ada-lang.c (struct ada_inferior_data): Add initializers.
3614         (ada_inferior_data): Change type.
3615         (ada_inferior_data_cleanup): Remove.
3616         (get_ada_inferior_data, ada_inferior_exit)
3617         (struct ada_pspace_data): Add initializers, destructor.
3618         (ada_pspace_data_handle): Change type.
3619         (get_ada_pspace_data): Update.
3620         (ada_pspace_data_cleanup): Remove.
3621
3622 2019-05-08  Tom Tromey  <tom@tromey.com>
3623
3624         * coffread.c (struct coff_symfile_info): Add initializers.
3625         (coff_objfile_data_key): Move lower.  Change type.
3626         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3627         Update.
3628         (coff_free_info): Remove.
3629
3630 2019-05-08  Tom Tromey  <tom@tromey.com>
3631
3632         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3633         (fbsd_pspace_data_handle): Move lower.  Change type.
3634         (get_fbsd_pspace_data): Update.
3635         (fbsd_pspace_data_cleanup): Remove.
3636         (_initialize_fbsd_tdep): Update.
3637
3638 2019-05-08  Tom Tromey  <tom@tromey.com>
3639
3640         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3641         (get_ada_tasks_pspace_data): Update.
3642         (ada_tasks_pspace_data_cleanup): Remove.
3643         (_initialize_tasks): Update.
3644         (ada_tasks_inferior_data_handle): Change type.
3645         (get_ada_tasks_inferior_data): Update.
3646         (ada_tasks_inferior_data_cleanup): Remove.
3647         (struct ada_tasks_pspace_data): Add initializers.
3648
3649 2019-05-08  Tom Tromey  <tom@tromey.com>
3650
3651         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3652         * symfile-debug.c (debug_sym_get_probes): Change type.
3653         * stap-probe.c (handle_stap_probe):
3654         (stap_static_probe_ops::get_probes): Change type.
3655         * probe.h (class static_probe_ops) <get_probes>: Change type.
3656         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3657         (parse_probes_in_pspace): Update.
3658         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3659         Update.
3660         (any_static_probe_ops::get_probes): Change type.
3661         * elfread.c (elfread_data): New typedef.
3662         (probe_key): Change type.
3663         (elf_get_probes): Likewise.  Update.
3664         (probe_key_free): Remove.
3665         (_initialize_elfread): Update.
3666         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3667         Change type.
3668         (dtrace_process_dof_probe, dtrace_process_dof)
3669         (dtrace_static_probe_ops::get_probe): Change type.
3670
3671 2019-05-08  Tom Tromey  <tom@tromey.com>
3672
3673         * xcoffread.c (struct xcoff_symfile_info): Rename from
3674         coff_symfile_info.  Add initializers.
3675         (xcoff_objfile_data_key): Move lower.  Change type.
3676         (XCOFF_DATA): Rewrite.
3677         (xcoff_free_info): Remove.
3678         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3679         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3680         (xcoff_initial_scan): Update.
3681
3682 2019-05-08  Tom Tromey  <tom@tromey.com>
3683
3684         * solib-svr4.c (struct svr4_info): Add initializers and
3685         destructor.
3686         <probes_table>: Now an htab_up.
3687         (solib_svr4_pspace_data): Change type.
3688         (free_probes_table): Simplify.
3689         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3690         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3691         (probes_table_remove_objfile_probes, register_solib_event_probe)
3692         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3693         (_initialize_svr4_solib): Update.
3694
3695 2019-05-08  Tom Tromey  <tom@tromey.com>
3696
3697         * remote.c (remote_pspace_data): Change type.
3698         (remote_pspace_data_cleanup): Remove.
3699         (get_remote_exec_file, set_pspace_remote_exec_file)
3700         (_initialize_remote): Update.
3701
3702 2019-05-08  Tom Tromey  <tom@tromey.com>
3703
3704         * breakpoint.c (breakpoint_objfile_key): Change type.
3705         (get_breakpoint_objfile_data): Update.
3706         (free_breakpoint_objfile_data): Remove.
3707         (_initialize_breakpoint): Update.
3708
3709 2019-05-08  Tom Tromey  <tom@tromey.com>
3710
3711         * linux-tdep.c (struct linux_info): Add initializers.
3712         (linux_inferior_data): Move.  Change type.
3713         (invalidate_linux_cache_inf): Update.
3714         (linux_inferior_data_cleanup): Remove.
3715         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3716
3717 2019-05-08  Tom Tromey  <tom@tromey.com>
3718
3719         * auxv.c (auxv_inferior_data): Move.  Change type.
3720         (auxv_inferior_data_cleanup): Remove.
3721         (invalidate_auxv_cache_inf): Rewrite.
3722         (get_auxv_inferior_data, _initialize_auxv): Update.
3723
3724 2019-05-08  Tom Tromey  <tom@tromey.com>
3725
3726         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3727         (symfile_debug_objfile_data_key): Change type.
3728         (symfile_debug_installed, debug_qf_has_symbols)
3729         (debug_qf_find_last_source_symtab)
3730         (debug_qf_forget_cached_source_info)
3731         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3732         (debug_qf_print_stats, debug_qf_dump)
3733         (debug_qf_expand_symtabs_for_function)
3734         (debug_qf_expand_all_symtabs)
3735         (debug_qf_expand_symtabs_with_fullname)
3736         (debug_qf_map_matching_symbols)
3737         (debug_qf_expand_symtabs_matching)
3738         (debug_qf_find_pc_sect_compunit_symtab)
3739         (debug_qf_map_symbol_filenames)
3740         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3741         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3742         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3743         (debug_sym_read_linetable, debug_sym_relocate): Update.
3744         (symfile_debug_free_objfile): Remove.
3745         (install_symfile_debug_logging, _initialize_symfile_debug):
3746         Update.
3747
3748 2019-05-08  Tom Tromey  <tom@tromey.com>
3749
3750         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3751         allocate_on_obstack.
3752         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3753         (get_dwarf2_per_objfile): Update.
3754         (set_dwarf2_per_objfile): Remove.
3755         (dwarf2_has_info, dwarf2_get_section_info): Update.
3756         (dwarf2_free_objfile): Remove.
3757         (_initialize_dwarf2_read): Update.
3758
3759 2019-05-08  Tom Tromey  <tom@tromey.com>
3760
3761         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3762         initializers.
3763         <unsupported_script_warning_printed,
3764         script_not_found_warning_printed>: Now bool.
3765         (auto_load_pspace_data): Change type.
3766         (~auto_load_pspace_info): Rename from
3767         auto_load_pspace_data_cleanup.
3768         (get_auto_load_pspace_data, init_loaded_scripts_info)
3769         (clear_section_scripts, maybe_print_unsupported_script_warning)
3770         (maybe_print_script_not_found_warning, _initialize_auto_load):
3771         Update.
3772
3773 2019-05-08  Tom Tromey  <tom@tromey.com>
3774
3775         * objfiles.c (objfile_pspace_info): Add destructor and
3776         initializers.
3777         (objfiles_pspace_data): Change type.
3778         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3779         (get_objfile_pspace_data): Update.
3780         (objfiles_bfd_data): Change type.
3781         (get_objfile_bfd_data): Update.
3782         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3783
3784 2019-05-08  Tom Tromey  <tom@tromey.com>
3785
3786         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3787         Change type.
3788         (get_catch_syscall_inferior_data): Update.
3789         (catch_syscall_inferior_data_cleanup): Remove.
3790         (_initialize_break_catch_syscall): Update.
3791
3792 2019-05-08  Tom Tromey  <tom@tromey.com>
3793
3794         * inflow.c (struct terminal_info): Add destructor and
3795         initializers.
3796         (inflow_inferior_data): Change type.
3797         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3798         (get_inflow_inferior_data, inflow_inferior_exit)
3799         (swap_terminal_info, _initialize_inflow): Update.
3800
3801 2019-05-08  Tom Tromey  <tom@tromey.com>
3802
3803         * target-dcache.c (target_dcache_cleanup): Remove.
3804         (target_dcache_aspace_key): Change type.
3805         (target_dcache_init_p, target_dcache_invalidate)
3806         (target_dcache_get, target_dcache_get_or_init)
3807         (_initialize_target_dcache): Update.
3808         * dcache.h (struct dcache_deleter): New.
3809
3810 2019-05-08  Tom Tromey  <tom@tromey.com>
3811
3812         * symtab.c (struct symbol_cache): Add destructor and
3813         initializers.
3814         (symbol_cache_key): Move.  Change type.
3815         (make_symbol_cache, free_symbol_cache): Remove.
3816         (get_symbol_cache): Update.
3817         (symbol_cache_cleanup): Remove.
3818         (ALL_PSPACES, symbol_cache_flush)
3819         (maintenance_print_symbol_cache)
3820         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3821         Update.
3822
3823 2019-05-08  Tom Tromey  <tom@tromey.com>
3824
3825         * symtab.c (struct main_info): Add destructor and initializers.
3826         (main_progspace_key): Move.  Change type.
3827         (get_main_info): Update.
3828         (main_info_cleanup): Remove.
3829         (_initialize_symtab): Update.
3830
3831 2019-05-08  Tom Tromey  <tom@tromey.com>
3832
3833         * registry.h (DECLARE_REGISTRY): Define the _key class.
3834
3835 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3836
3837         * NEWS: Merge two 'New commands' sections.
3838
3839 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3840
3841         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3842         parameter and use Ada language definition instead.
3843         (ada_val_print_ptr): Remove unused language parameter.
3844         (ada_val_print_num): Remove language parameter and use Ada language
3845         definition instead.
3846         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3847         parameter.
3848         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3849         parameter and use Ada language definition instead.
3850         (ada_val_print_1): Update all ada_val_print_xxx calls.
3851         Remove language parameter.
3852         (ada_val_print): Update ada_val_print_1 call.
3853
3854 2019-05-08  Tom Tromey  <tromey@adacore.com>
3855
3856         * remote.c (remote_hw_watchpoint_limit)
3857         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3858         Now static.
3859
3860 2019-05-08  Tom Tromey  <tromey@adacore.com>
3861
3862         * maint.c (_initialize_maint_cmds): Move initialization code to
3863         remote.c.
3864         (watchdog, show_watchdog): Move to remote.c.
3865         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3866         "watchdog" static.
3867         (_initialize_remote): Move initialization code from maint.c.
3868         * defs.h (watchdog): Don't declare.
3869
3870 2019-05-08  Tom Tromey  <tromey@adacore.com>
3871
3872         * tui/tui-interp.c: Include main.h.
3873         * interps.c: Include main.h.
3874         * main.h (interpreter_p): Declare.
3875         * defs.h (interpreter_p): Don't declare.
3876
3877 2019-05-08  Tom Tromey  <tromey@adacore.com>
3878
3879         * dwarf2loc.c: Include dwarf2read.h.
3880         * defs.h (read_unsigned_leb128): Don't declare.
3881         * dwarf2read.h (read_unsigned_leb128): Declare.
3882
3883 2019-05-08  Tom Tromey  <tromey@adacore.com>
3884
3885         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3886         method.
3887
3888 2019-05-08  Tom Tromey  <tromey@adacore.com>
3889
3890         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3891         when no wrap column is set.
3892
3893 2019-05-08  Tom Tromey  <tromey@adacore.com>
3894
3895         * c-lang.c (c_get_string): Handle non-C-style arrays.
3896
3897 2019-05-08  Tom Tromey  <tromey@adacore.com>
3898
3899         * typeprint.c (print_offset_data::update): Print the bit offset,
3900         not the number of bits remaining.
3901
3902 2019-05-08  Tom Tromey  <tromey@adacore.com>
3903
3904         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3905         padding at end of comment.
3906
3907 2019-05-08  Tom Tromey  <tromey@adacore.com>
3908
3909         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3910         Compare main types.
3911
3912 2019-05-06  Tom Tromey  <tom@tromey.com>
3913
3914         * common/scoped_mmap.c: Include common-defs.h.
3915         * common/scoped_mmap.h: Don't include config.h.
3916
3917 2019-05-04  Tom Tromey  <tom@tromey.com>
3918
3919         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3920         (struct aarch64_call_info): Add initializers.
3921         <si>: Now a std::vector.
3922         (pass_on_stack, aarch64_push_dummy_call): Update.
3923
3924 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3925             Tom Tromey  <tom@tromey.com>
3926
3927         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3928         (ppc_threads): Now a std::vector.  Now static.
3929         (hwdebug_find_thread_points_by_tid)
3930         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3931         Update.
3932
3933 2019-05-04  Tom Tromey  <tom@tromey.com>
3934
3935         * arc-tdep.c (arc_tdesc_init): Return bool.
3936
3937 2019-05-04  Tom Tromey  <tom@tromey.com>
3938
3939         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3940         Use gdb_assert_not_reached.
3941
3942 2019-05-04  Tom Tromey  <tom@tromey.com>
3943
3944         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3945         "false".
3946
3947 2019-05-04  Tom Tromey  <tom@tromey.com>
3948
3949         * arc-tdep.c (arc_tdesc_init): Use bool.
3950
3951 2019-05-04  Tom Tromey  <tom@tromey.com>
3952
3953         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3954
3955 2019-05-04  Tom Tromey  <tom@tromey.com>
3956
3957         * cli/cli-cmds.c (valid_command_p): Return bool.
3958
3959 2019-05-04  Tom Tromey  <tom@tromey.com>
3960
3961         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3962         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3963
3964 2019-05-04  Raul Tambre  <raul@tambre.ee>
3965
3966         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3967         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3968         operator for comparison.
3969
3970 2019-05-04  Tom Tromey  <tom@tromey.com>
3971
3972         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3973         (lookup_partial_symbol, print_partial_symbols)
3974         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3975         (psymbol_compare): Update.
3976         (add_psymbol_to_bcache): Clear the entire psymbol.
3977         (maintenance_check_psymtabs): Update.
3978         * psympriv.h (struct partial_symbol): Don't derive from
3979         general_symbol_info.
3980         <obj_section, unrelocated_address, address,
3981         set_unrelocated_address>: Update.
3982         <ginfo>: New member.
3983         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3984         (debug_names::write_psymbols): Update.
3985
3986 2019-05-04  Tom de Vries  <tdevries@suse.de>
3987
3988         * contrib/cc-with-tweaks.sh: Support -n arg.
3989
3990 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3991
3992         * corelow.c (core_target::detach): Ensure frame cache and
3993         register caches are cleared.
3994         inferior.c (exit_inferior_1): Likewise.
3995
3996 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3997             Tom Tromey  <tom@tromey.com>
3998
3999         * dictionary.c (collate_pending_symbols_by_language): Remove
4000         "struct" from foreach.
4001         * symtab.c (lookup_global_symbol_from_objfile)
4002         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4003         foreach.
4004         * ser-tcp.c (net_open): Remove "struct" from foreach.
4005         * objfiles.c (objfile_relocate, objfile_rebase)
4006         (objfile_has_symbols): Remove "struct" from foreach.
4007         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4008         from foreach.
4009         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4010         foreach.
4011         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4012         "struct" from foreach.
4013         * ada-lang.c (create_excep_cond_exprs)
4014         (ada_exception_catchpoint_cond_string): Remove "struct" from
4015         foreach.
4016
4017 2019-05-03  Tom Tromey  <tromey@adacore.com>
4018
4019         * ada-exp.y (convert_char_literal): Check suffix of each
4020         enumerator.
4021
4022 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4023
4024         PR ada/21406:
4025         * ada-exp.y (yywrap): Don't define.
4026         * ada-lex.l (%option): Add noyywrap
4027         (yywrap): Remove.
4028
4029 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4030
4031         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4032         _WIN32_WINNT to the XP level, unless already defined to a higher
4033         level.
4034
4035         * unittests/parse-connection-spec-selftests.c:
4036         * ser-tcp.c:
4037         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4038         override.
4039
4040         * symfile.c (find_separate_debug_file): Remove colon from the
4041         drive spec of DOS/Windows file names of the target, so that the
4042         file name produced from DEBUGDIR and the target's directory will
4043         be valid on DOS/Windows systems.
4044
4045 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4046
4047         * rust-lang.c (val_print_struct): Handle printing structures
4048         containing strings.
4049
4050 2019-05-02  Tom Tromey  <tromey@adacore.com>
4051
4052         * valarith.c (_initialize_valarith): Remove.
4053
4054 2019-05-01  Tom Tromey  <tromey@adacore.com>
4055
4056         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4057         bitfields.
4058
4059 2019-05-01  Tom Tromey  <tromey@adacore.com>
4060
4061         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4062         for big-endian copies.
4063
4064 2019-04-30  Ali Tamur  <tamur@google.com>
4065         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4066         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4067         (read_3_bytes): New function.
4068
4069 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4070
4071         * windows-nat.c (main_thread_id): Delete.
4072         (handle_output_debug_string): Replace main_thread_id by
4073         current_event.dwThreadId.
4074         (fake_create_process): Likewise.
4075         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4076         Do not set main_thread_id.
4077         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4078         current_event.dwThreadId.
4079         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4080
4081 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4082
4083         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4084         Use current_event.dwThreadId instead of main_thread_id.
4085
4086 2019-04-30  Tom Tromey  <tromey@adacore.com>
4087
4088         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4089         (create_excep_cond_exprs): Iterate over program spaces.
4090         (ada_exception_catchpoint_cond_string): Examine all minimal
4091         symbols for exception types.
4092
4093 2019-04-30  Tom Tromey  <tromey@adacore.com>
4094
4095         PR c++/24470:
4096         * dwarf2read.c (process_structure_scope): Handle case where type
4097         has template parameters but no symbol was created.
4098
4099 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4100             Chris January  <chris.january@arm.com>
4101
4102         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4103         qualifier.
4104         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4105
4106 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4107
4108         * f-typeprint.c (f_print_type): Update rules for printing
4109         whitespace.
4110         (f_type_print_varspec_suffix): Likewise.
4111
4112 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4113             Chris January  <chris.january@arm.com>
4114
4115         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4116         function arguments.
4117
4118 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4119
4120         * f-lang.c (build_fortran_types): Change name of void type to
4121         lower case.
4122         * f-typeprint.c (f_type_print_base): Print the name of the void
4123         type, rather than a fixed string.
4124         * f-valprint.c (f_decorations): Use lower case void string.
4125
4126 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4127             Chris January  <chris.january@arm.com>
4128
4129         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4130         types for Fortran.
4131
4132 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4133             Chris January  <chris.january@arm.com>
4134             David Lecomber  <david.lecomber@arm.com>
4135
4136         * f-exp.y (BINOP_INTRINSIC): New token.
4137         (exp): New parser rule handling BINOP_INTRINSIC.
4138         (f77_keywords): Add new builtin procedures.
4139         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4140         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4141         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4142         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4143         (print_unop_subexp_f): New function.
4144         (print_binop_subexp_f): New function.
4145         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4146         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4147         (dump_subexp_body_f): Likewise.
4148         (operator_check_f): Likewise.
4149         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4150         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4151
4152 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4153
4154         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4155         UNOP_KIND.
4156         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4157         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4158         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4159         (operator_length_f): New fuction.
4160         (print_subexp_f): New function.
4161         (op_name_f): New function.
4162         (dump_subexp_body_f): New function.
4163         (operator_check_f): New function.
4164         (exp_descriptor_f): Replace standard expression handling functions
4165         with new functions.
4166         * gdb/fortran-operator.def: New file.
4167         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4168         * gdb/std-operator.def: Remove UNOP_KIND.
4169
4170 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4171
4172         * std-operator.def: Remove unbalanced, stray double quote
4173         character.
4174
4175 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4176             Chris January  <chris.january@arm.com>
4177             Daniel Everett  <daniel.everett@arm.com>
4178             Nick Forrington  <nick.forrington@arm.com>
4179             Richard Bunt  <richard.bunt@arm.com>
4180
4181         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4182         of depth when printing anonymous structs or unions.
4183         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4184         Don't print either the top-level value, or the children if the
4185         max-depth is exceeded.
4186         (ppscm_print_children): When printing the key of a map, allow one
4187         extra level of depth.
4188         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4189         print either the top-level value, or the children if the max-depth
4190         is exceeded.
4191         (print_children): When printing the key of a map, allow one extra
4192         level of depth.
4193         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4194         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4195         (user_print_options): Initialise max_depth field.
4196         (val_print_scalar_or_string_type_p): New function.
4197         (val_print): Check to see if the max depth has been reached.
4198         (val_print_check_max_depth): Define new function.
4199         (show_print_max_depth): New function.
4200         (_initialize_valprint): Add 'print max-depth' option.
4201         * valprint.h (struct value_print_options) <max_depth>: New field.
4202         (val_print_check_max_depth): Declare new function.
4203         * NEWS: Document new feature.
4204
4205 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4206
4207         * ada-lang.c (ada_language_defn): Initialise new field.
4208         * c-lang.c (c_is_string_type_p): New function.
4209         (c_language_defn): Initialise new field.
4210         (cplus_language_defn): Initialise new field.
4211         (asm_language_defn): Initialise new field.
4212         (minimal_language_defn): Initialise new field.
4213         * c-lang.h (c_is_string_type_p): Declare new function.
4214         * d-lang.c (d_language_defn): Initialise new field.
4215         * f-lang.c (f_is_string_type_p): New function.
4216         (f_language_defn): Initialise new field.
4217         * go-lang.c (go_is_string_type_p): New function.
4218         (go_language_defn): Initialise new field.
4219         * language.c (default_is_string_type_p): New function.
4220         (unknown_language_defn): Initialise new field.
4221         (auto_language_defn): Initialise new field.
4222         * language.h (struct language_defn) <la_is_string_type_p>: New
4223         member variable.
4224         (default_is_string_type_p): Declare new function.
4225         * m2-lang.c (m2_language_defn): Initialise new field.
4226         * objc-lang.c (objc_language_defn): Initialise new field.
4227         * opencl-lang.c (opencl_language_defn): Initialise new field.
4228         * p-lang.c (pascal_is_string_type_p): New function.
4229         (pascal_language_defn): Initialise new field.
4230         * rust-lang.c (rust_is_string_type_p): New function.
4231         (rust_language_defn): Initialise new field.
4232
4233 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4234
4235         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4236         New field.
4237         * ada-lang.c (ada_language_defn): Initialise new field.
4238         * c-lang.c (c_language_defn): Likewise.
4239         (cplus_language_defn): Likewise.
4240         (asm_language_defn): Likewise.
4241         (minimal_language_defn): Likewise.
4242         * d-lang.c (d_language_defn): Likewise.
4243         * f-lang.c (f_language_defn): Likewise.
4244         * go-lang.c (go_language_defn): Likewise.
4245         * language.c (unknown_language_defn): Likewise.
4246         (auto_language_defn): Likewise.
4247         * m2-lang.c (m2_language_defn): Likewise.
4248         * objc-lang.c (objc_language_defn): Likewise.
4249         * opencl-lang.c (opencl_language_defn): Likewise.
4250         * p-lang.c (pascal_language_defn): Likewise.
4251         * rust-lang.c (rust_language_defn): Likewise.
4252
4253 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4254
4255         * ada-lang.c (ada_is_character_type): Change return type to bool.
4256         (ada_is_string_type): Likewise.
4257         * ada-lang.h (ada_is_character_type): Update declaration
4258         (ada_is_string_type): Likewise.
4259
4260 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4261
4262         Support style in 'frame|thread apply'
4263
4264         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4265         * record.c (record_start, record_stop): Update callers of
4266         execute_command_to_string with false.
4267         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4268         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4269         methods.
4270         (class string_file): New constructor with term_out parameter.
4271         Override methods term_out and can_emit_style_escape.  New member
4272         term_out.
4273         (class stdio_file): Override can_emit_style_escape.
4274         (class tee_file): Override term_out and can_emit_style_escape.
4275         * utils.h (can_emit_style_escape): Remove.
4276         * utils.c (can_emit_style_escape): Likewise.
4277         Update all callers of can_emit_style_escape (SOMESTREAM) to
4278         SOMESTREAM->can_emit_style_escape.
4279         * source-cache.c (source_cache::get_source_lines): Likewise.
4280         * stack.c (frame_apply_command_count): Call execute_command_to_string
4281         passing the term_out characteristic of the current gdb_stdout.
4282         * thread.c (thr_try_catch_cmd): Likewise.
4283         * top.c (execute_command_to_string): pass term_out parameter
4284         to construct the string_file for the command output.
4285         * ui-file.c (term_cli_styling): New function (most code moved
4286         from utils.c can_emit_style_escape).
4287         (string_file::string_file, string_file::can_emit_style_escape,
4288         stdio_file::can_emit_style_escape, tee_file::term_out,
4289         tee_file::can_emit_style_escape): New functions.
4290
4291 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4292
4293         * NEWS: Mention the new set|show may-call-functions.
4294         * infcall.c (may_call_functions_p): New variable.
4295         (show_may_call_functions_p): New function.
4296         (call_function_by_hand_dummy): Throws an error if not
4297         may-call-functions.
4298         (_initialize_infcall): Call add_setshow_boolean_cmd for
4299         may-call-functions.
4300
4301 2019-04-25  Keith Seitz  <keiths@redhat.com>
4302
4303         PR c++/24367
4304         * cp-support.c (inspect_type): Don't attempt substitutions
4305         of symbol with the same name.
4306
4307 2019-04-25  Tom Tromey  <tromey@adacore.com>
4308
4309         PR gdb/24475:
4310         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4311         static.
4312
4313 2019-04-25  Tom Tromey  <tromey@adacore.com>
4314
4315         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4316         rvalue reference.
4317         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4318         (gdb_xml_parser::parse): Use std::move.
4319         * python/python-internal.h (gdbpy_convert_exception): Take a const
4320         reference.
4321         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4322         std::move.
4323         * python/py-utils.c (gdbpy_convert_exception): Take a const
4324         reference.
4325         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4326         Use std::move.
4327         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4328         Use std::move.
4329         * mi/mi-main.c (mi_print_exception): Take a const reference.
4330         * main.c (handle_command_errors): Take a const reference.
4331         * linespec.c (parse_linespec): Use std::move.
4332         * infcall.c (run_inferior_call): Use std::move.
4333         (call_function_by_hand_dummy): Use std::move.
4334         * exec.c (try_open_exec_file): Use std::move.
4335         * exceptions.h (exception_print, exception_fprintf)
4336         (exception_print_same): Update.
4337         * exceptions.c (print_exception, exception_print)
4338         (exception_fprintf, exception_print_same): Change parameters to
4339         const reference.
4340         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4341         * common/new-op.c: Use std::move.
4342         * common/common-exceptions.h (struct gdb_exception): Add move
4343         constructor.
4344         (struct gdb_exception_error, struct gdb_exception_quit, struct
4345         gdb_quit_bad_alloc): Change constructor to move constructor.
4346         (throw_exception): Change parameter to rvalue reference.
4347         * common/common-exceptions.c (throw_exception): Take rvalue
4348         reference.
4349         * cli/cli-interp.c (safe_execute_command): Use std::move.
4350         * breakpoint.c (insert_bp_location, location_to_sals): Use
4351         std::move.
4352
4353 2019-04-25  Tom Tromey  <tromey@adacore.com>
4354
4355         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4356         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4357         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4358         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4359         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4360         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4361         guile/scm-value.c: Use unpack.
4362         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4363         gdbscm_gdb_exception.
4364         (gdbscm_throw_gdb_exception): Likewise.
4365         (struct gdbscm_gdb_exception): New.
4366         (unpack): New function.
4367         (gdbscm_wrap): Use unpack.
4368
4369 2019-04-25  Tom Tromey  <tromey@adacore.com>
4370
4371         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4372         (gdb_rl_callback_handler): Use std::move.
4373         * common/common-exceptions.h (struct gdb_exception): Add move
4374         assignment operator.
4375         (throw_exception_sjlj): Change "exception" to const reference.
4376         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4377         (throw_exception_sjlj): Change "exception" to const reference.
4378
4379 2019-04-25  Tom Tromey  <tromey@adacore.com>
4380
4381         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4382         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4383         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4384         Update.
4385         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4386         Update.
4387         * mi/mi-interp.c (mi_interp::exec): Update.
4388         * linespec.c (parse_linespec): Update.
4389         * infcall.c (run_inferior_call): Update.
4390         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4391         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4392         (gdbscm_lookup_global_symbol): Update.
4393         * guile/scm-param.c (gdbscm_parameter_value): Update.
4394         * guile/scm-frame.c (gdbscm_frame_read_register)
4395         (gdbscm_frame_read_var): Update.
4396         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4397         * exec.c (try_open_exec_file): Update.
4398         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4399         (gdb_rl_callback_handler): Update.
4400         * common/common-exceptions.h (exception_none): Don't declare.
4401         * common/common-exceptions.c (exception_none): Don't define.
4402         (struct catcher) <exception>: Update.
4403         * cli/cli-interp.c (safe_execute_command): Update.
4404         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4405
4406 2019-04-25  Ali Tamur  <tamur@google.com>
4407
4408         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4409         (read_attribute_value): Likewise.
4410         (dwarf2_read_addr_index): Update comment.
4411         (read_str_index): Add DW_FORM_strx.
4412         (dwarf2_string_attr): Likewise.
4413         (dwarf2_const_value_attr): Likewise.
4414         (dump_die_shallow): Likewise.
4415         (dwarf2_fetch_constant_bytes): Likewise.
4416         (skip_form_bytes): Likewise.
4417         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4418
4419 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4420
4421         PR corefiles/11608
4422         PR corefiles/18187
4423         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4424         OFFSET.  Verify if current mapping contains an ELF header.
4425         (linux_find_memory_regions_full): Adjust call to
4426         dump_mapping_p.
4427
4428 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4429             Kang Li <kanglictf@gmail.com>
4430
4431         PR gdb/21600
4432
4433         * dwarf2-frame.c (read_initial_length): Be consistent about using
4434         unsigned representation of length.
4435         (decode_frame_entry_1): Likewise.  Check for wraparound of
4436         end pointer as well as buffer overflow.
4437
4438 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4439
4440         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4441         "vq".
4442
4443 2019-04-24  Tom Tromey  <tromey@adacore.com>
4444
4445         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4446
4447 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4448
4449         * s12z-tdep.c (s12z_unwind_pc): Delete.
4450         (s12z_unwind_sp): Delete.
4451         (s12z_gdbarch_init): Don't register deleted functions with
4452         gdbarch.
4453
4454 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4455
4456         * rl78-tdep.c (rl78_unwind_sp): Delete.
4457         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4458
4459 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4460
4461         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4462         (xstormy16_unwind_pc): Delete.
4463         (xstormy16_dummy_id): Delete.
4464         (xstormy16_gdbarch_init): Don't register deleted functions with
4465         gdbarch.
4466
4467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4468
4469         * vax-tdep.c (vax_unwind_pc): Delete.
4470         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4471
4472 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4473
4474         * v850-tdep.c (v850_unwind_sp): Delete.
4475         (v850_unwind_pc): Delete.
4476         (v850_dummy_id): Delete.
4477         (v850_gdbarch_init): Don't register deleted functions with
4478         gdbarch.
4479
4480 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4481
4482         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4483         (tilegx_unwind_pc): Delete.
4484         (tilegx_unwind_dummy_id): Delete.
4485         (tilegx_gdbarch_init): Don't register deleted functions with
4486         gdbarch.
4487
4488 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4489
4490         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4491         (tic6x_dummy_id): Delete.
4492         (tic6x_gdbarch_init): Don't register deleted functions with
4493         gdbarch.
4494
4495 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4496
4497         * sparc-tdep.c (sparc_unwind_pc): Delete.
4498         (sparc32_gdbarch_init): Don't register deleted function with
4499         gdbarch.
4500
4501 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4502
4503         * sh-tdep.c (sh_unwind_sp): Delete.
4504         (sh_unwind_pc): Delete.
4505         (sh_dummy_id): Delete.
4506         (sh_gdbarch_init): Don't register deleted functions with
4507         gdbarch.
4508
4509 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4510
4511         * score-tdep.c (score_unwind_sp): Delete.
4512         (score_unwind_pc): Delete.
4513         (score_dummy_id): Delete.
4514         (score_gdbarch_init): Don't register deleted functions with
4515         gdbarch.
4516
4517 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4518
4519         * rx-tdep.c (rx_unwind_pc): Delete.
4520         (rx_unwind_sp): Delete.
4521         (rx_dummy_id): Delete.
4522         (rx_gdbarch_init): Don't register deleted functions with
4523         gdbarch.  Update comment.
4524
4525 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4526
4527         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4528         (rs6000_dummy_id): Delete.
4529         (rs6000_gdbarch_init): Don't register deleted functions with
4530         gdbarch.
4531
4532 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4533
4534         * or1k-tdep.c (or1k_dummy_id): Delete.
4535         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4536
4537 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4538
4539         * nios2-tdep.c (nios2_dummy_id): Delete.
4540         (nios2_unwind_sp): Delete.
4541         (nios2_gdbarch_init): Don't register deleted functions with
4542         gdbarch.
4543
4544 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4545
4546         * nds32-tdep.c (nds32_dummy_id): Delete.
4547         (nds32_unwind_pc): Delete.
4548         (nds32_unwind_sp): Delete.
4549         (nds32_gdbarch_init): Don't register deleted functions with
4550         gdbarch.
4551
4552 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4553
4554         * msp430-tdep.c (msp430_unwind_pc): Delete.
4555         (msp430_unwind_sp): Delete.
4556         (msp430_dummy_id): Delete.
4557         (msp430_gdbarch_init): Don't register deleted functions with
4558         gdbarch.
4559
4560 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4561
4562         * moxie-tdep.c (moxie_unwind_sp): Delete.
4563         (moxie_unwind_pc): Delete.
4564         (moxie_dummy_id): Delete.
4565         (moxie_gdbarch_init): Don't register deleted functions with
4566         gdbarch.
4567
4568 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4569
4570         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4571         (mn10300_unwind_pc): Delete.
4572         (mn10300_unwind_sp): Delete.
4573         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4574         mn10300_unwind_sp.
4575         (mn10300_frame_unwind_init): Don't register deleted functions with
4576         gdbarch.
4577
4578 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4579
4580         * mep-tdep.c (mep_unwind_pc): Delete.
4581         (mep_unwind_sp): Delete.
4582         (mep_dummy_id): Delete.
4583         (mep_gdbarch_init): Don't register deleted functions with
4584         gdbarch.
4585
4586 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4587
4588         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4589         (m68hc11_unwind_sp): Delete.
4590         (m68hc11_gdbarch_init): Don't register deleted functions with
4591         gdbarch.
4592
4593 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4594
4595         * m32r-tdep.c (m32r_unwind_sp): Delete.
4596         (m32r_unwind_pc): Delete.
4597         (m32r_dummy_id): Delete.
4598         (m32r_gdbarch_init): Don't register deleted functions with
4599         gdbarch.
4600
4601 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4602
4603         * m32c-tdep.c (m32c_unwind_pc): Delete.
4604         (m32c_unwind_sp): Delete.
4605         (m32c_dummy_id): Delete.
4606         (m32c_gdbarch_init): Don't register deleted functions with
4607         gdbarch.
4608
4609 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4610
4611         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4612         (lm32_unwind_pc): Delete.
4613         (lm32_dummy_id): Delete.
4614         (lm32_gdbarch_init): Don't register deleted functions with
4615         gdbarch.
4616
4617 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4618
4619         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4620         (iq2000_unwind_pc): Delete.
4621         (iq2000_dummy_id): Delete.
4622         (iq2000_gdbarch_init): Don't register deleted functions with
4623         gdbarch.
4624
4625 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4626
4627         * nds32-tdep.c (nds32_type_align): Delete.
4628         (nds32_push_dummy_call): Use type_align instead.
4629
4630 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4631
4632         * arm-tdep.c (arm_type_align): Only handle vector override case.
4633         (arm_push_dummy_call): Use type_align.
4634         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4635
4636 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4637
4638         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4639         case.
4640         (pass_on_stack): Use type_align.
4641         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4642         function.
4643
4644 2019-04-23  Tom Tromey  <tromey@adacore.com>
4645
4646         * dwarf2read.c (line_header::file_name_at): Remove unused
4647         overload.
4648
4649 2019-04-23  Tom de Vries  <tdevries@suse.de>
4650
4651         PR gdb/24438
4652         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4653         invocation.
4654
4655
4656 2019-03-27  Ali Tamur  <tamur@google.com>
4657
4658         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4659         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4660         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4661         (dwarf_expr_context::get_addr_index): Likewise
4662         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4663         (symbol_needs_eval_context::get_addr_index): Likewise
4664         (disassemble_dwarf_expression): Add DW_OP_addrx
4665         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4666         (read_cutu_die_from_dwo): Update comment
4667         (skip_one_die): Add DW_FORM_addrx
4668         (read_attribute_value): Likewise
4669         (var_decode_location): Add DW_OP_addrx
4670         (dwarf2_const_value_attr): Add DW_FORM_addrx
4671         (dump_die_shallow): Likewise
4672         (dwarf2_fetch_constant_bytes): Likewise
4673         (decode_locdesc): Add DW_OP_addrx
4674         (skip_form_bytes): Add DW_FORM_addrx
4675
4676 2019-04-22  Ali Tamur  <tamur@google.com>
4677
4678         * MAINTAINERS (Write After Approval): Add self.
4679
4680 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4681
4682         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4683         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4684         (open_symbol_file_object): Likewise.
4685         (svr4_default_sos): Add info parameter.
4686         (svr4_read_so_list): Likewise.
4687         (svr4_current_sos_direct): Adjust functions calls to pass down
4688         info.
4689         (svr4_current_sos_1): Add info parameter.
4690         (svr4_current_sos): Call get_svr4_info, pass info down to
4691         svr4_current_sos_1.
4692         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4693         get_svr4_info.
4694         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4695         get_svr4_info.
4696         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4697         to get_svr4_info.
4698         (probes_table_remove_objfile_probes): Likewise.
4699         (register_solib_event_probe): Add info parameter.
4700         (solist_update_incremental): Pass info parameter down to
4701         svr4_read_so_list.
4702         (disable_probes_interface): Add info parameter.
4703         (svr4_handle_solib_event): Pass current_program_space to
4704         get_svr4_info.  Adjust disable_probes_interface cleanup.
4705         (svr4_create_probe_breakpoints): Add info parameter, pass it
4706         down to register_solib_event_probe.
4707         (svr4_create_solib_event_breakpoints): Add info parameter,
4708         pass it down to svr4_create_probe_breakpoints.
4709         (enable_break): Pass info down to
4710         svr4_create_solib_event_breakpoints.
4711         (svr4_solib_create_inferior_hook): Pass current_program_space to
4712         get_svr4_info.
4713         (svr4_clear_solib): Likewise.
4714
4715 2019-04-22  Pedro Alves  <palves@redhat.com>
4716
4717         * solib-svr4.c (svr4_free_objfile_observer): New.
4718         (probe_and_action::objfile): New field.
4719         (probes_table_htab_remove_objfile_probes)
4720         (probes_table_remove_objfile_probes): New functions.
4721         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4722         in the new probe_and_action.  Don't store the probe in 'lookup'.
4723         (svr4_create_probe_breakpoints): Pass objfile to
4724         register_solib_event_probe.
4725         (_initialize_svr4_solib): Register a free_objfile observer.
4726
4727 2019-04-19  Tom Tromey  <tom@tromey.com>
4728
4729         * common/queue.h: Remove.
4730
4731 2019-04-19  Tom Tromey  <tom@tromey.com>
4732
4733         * event-loop.c: Don't include "common/queue.h".
4734
4735 2019-04-19  Tom Tromey  <tom@tromey.com>
4736
4737         * remote.c (remote_target): Use delete.
4738         * remote-notif.h: Include <list>, not "common/queue.h".
4739         (notif_client_p): Remove typedef.
4740         (remote_notif_state): Add constructor, destructor, initializer.
4741         <notif_queue>: Now a std::list.
4742         (remote_notif_state_xfree): Don't declare.
4743         * remote-notif.c (remote_notif_process, handle_notification)
4744         (remote_notif_state_allocate): Update.
4745         (~remote_notif_state): Rename from remote_notif_state_xfree.
4746
4747 2019-04-19  Tom Tromey  <tom@tromey.com>
4748
4749         * symfile.c (reread_symbols): Update.
4750         * objfiles.c (objfile_register_static_link)
4751         (objfile_lookup_static_link): Update
4752         (~objfile) Don't delete static_links.
4753         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4754
4755 2019-04-19  Tom Tromey  <tom@tromey.com>
4756
4757         * type-stack.h (struct type_stack) <insert>: Constify string.
4758         * type-stack.c (type_stack::insert): Constify string.
4759         * gdbtypes.h (lookup_template_type): Update.
4760         (address_space_name_to_int): Update.
4761         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4762         const.
4763         (lookup_template_type): Make name const.
4764         * c-exp.y: Update rules.
4765         (lex_one_token, classify_name, classify_inner_name)
4766         (c_print_token): Update.
4767         * p-exp.y: Update rules.
4768         (yylex): Update.
4769         * f-exp.y: Update rules.
4770         (yylex): Update.
4771         * d-exp.y: Update rules.
4772         (lex_one_token, classify_name, classify_inner_name): Update.
4773         * parse.c (write_dollar_variable, copy_name): Return std::string.
4774         * parser-defs.h (copy_name): Change return type.
4775         * m2-exp.y: Update rules.
4776         (yylex): Update.
4777         * go-exp.y (lex_one_token): Update.
4778         Update rules.
4779         (classify_unsafe_function, classify_packaged_name)
4780         (classify_name, yylex): Update.
4781
4782 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4783
4784         * configure.ac: add --enable-source-highlight switch.
4785         * configure: Regenerate.
4786         * top.c (print_gdb_version): plumb --enable-source-highlight
4787         status to "show configuration".
4788
4789 2019-04-19  Tom Tromey  <tromey@adacore.com>
4790
4791         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4792         Check ADA_TYPE_P.
4793         (empty_record, ada_template_to_fixed_record_type_1)
4794         (template_to_static_fixed_type)
4795         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4796         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4797         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4798         macros.
4799
4800 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4801
4802         PR symtab/24423:
4803         * source.c (print_source_lines_base): Advance "iter" when a
4804         control character is seen.
4805
4806 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4807
4808         * inferior.h (struct infcall_suspend_state_deleter):
4809         Catch exception in destructor to avoid crash.
4810
4811 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4812
4813         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4814         close to the add_com "shell".
4815
4816 2019-04-18  Tom Tromey  <tromey@adacore.com>
4817
4818         * process-stratum-target.h (class process_stratum_target)
4819         <stratum>: Add "final".
4820
4821 2019-04-17  Tom Tromey  <tromey@adacore.com>
4822
4823         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4824         against nullptr before use.
4825
4826 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4827
4828         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4829
4830 2019-04-17  Jim Wilson  <jimw@sifive.com>
4831             Andrew Burgess  <andrew.burgess@embecosm.com>
4832
4833         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4834         code read might fail, assume 4-byte breakpoint in that case.
4835
4836 2019-04-15  Leszek Swirski  <leszeks@google.com>
4837
4838         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4839         rather than a hand-rolled POD check when checking for forced MEMORY
4840         classification.
4841
4842 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4843
4844         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4845         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4846         function.
4847         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4848         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4849         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4850         declaration.
4851
4852 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4853
4854         * aarch64-linux-nat.c
4855         (aarch64_linux_nat_target::thread_architecture): Add override.
4856         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4857         each VQ.
4858
4859 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4860
4861         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4862
4863 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4864
4865         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4866         target types of size 96-bits, add some additional comments, and
4867         check that the builtin type we found was the correct size.
4868
4869 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4870
4871         * utils.c (prompt_for_continue): Don't restore the styling at the
4872         end, as applied_style has the wrong value.  This fixes styling in
4873         long lists of file names that are interrupted by the "Continue?"
4874         prompt.
4875
4876 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4877
4878         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4879         * c-lang.c (c_language_defn): Likewise.
4880         (cplus_language_defn): Likewise.
4881         (asm_language_defn): Likewise.
4882         (minimal_language_defn): Likewise.
4883         * d-lang.c (d_language_defn): Likewise.
4884         * f-lang.c (f_language_defn): Likewise.
4885         * go-lang.c (go_language_defn): Likewise.
4886         * language.c (unknown_language_defn): Likewise.
4887         (auto_language_defn): Likewise.
4888         * language.h (struct language_defn): Remove la_magic field.
4889         (LANG_MAGIC): Delete.
4890         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4891         * objc-lang.c (objc_language_defn): Likewise.
4892         * opencl-lang.c (opencl_language_defn): Likewise.
4893         * p-lang.c (pascal_language_defn): Likewise.
4894         * rust-lang.c (rust_language_defn): Likewise.
4895
4896 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4897
4898         * riscv-tdep.c (riscv_type_align): New function.
4899         (riscv_type_alignment): Delete.
4900         (riscv_arg_location): Use 'type_align'.
4901         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4902
4903 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4904
4905         * gdbtypes.c (type_align): A struct with no non-static fields also
4906         has alignment of 1.
4907
4908 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4909
4910         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4911         component to 0.
4912         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4913         member.
4914         (riscv_struct_info::analyse): New implementation using new
4915         analyse_inner member function.
4916         (riscv_struct_info::field_offset): New member function.
4917         (riscv_struct_info::m_offsets): New member variable.
4918         (riscv_struct_info::analyse_inner): New private member function,
4919         takes the old implementation of riscv_struct_info::analyse but
4920         extended to track field offsets.
4921         (riscv_call_arg_struct): Update the struct folding special cases
4922         to handle cases where empty C++ structs, which are non-zero
4923         length, are found.
4924         (riscv_arg_location): Initialise the length of each location, a
4925         non-zero length now indicates the location is in use.
4926         (riscv_push_dummy_call): Allow for the first location having a
4927         non-zero offset when setting up arguments.
4928         (riscv_return_value): Likewise, but for return values.
4929
4930 2019-04-11  Tom Tromey  <tromey@adacore.com>
4931
4932         * utils.c (internal_vproblem): Make "msg" const.
4933
4934 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4935
4936         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4937         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4938         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4939         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4940
4941 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4942
4943         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4944         function.
4945         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4946         of amd64_collect_native_gregset.
4947         (amd64_linux_nat_target::store_registers): Likewise.
4948
4949 2019-04-10  Tom Tromey  <tom@tromey.com>
4950
4951         * symtab.c (lookup_global_symbol_from_objfile)
4952         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4953         * objfiles.h (class separate_debug_iterator): New.
4954         (class separate_debug_range): New.
4955         (struct objfile) <separate_debug_objfiles>: New method.
4956         (objfile_separate_debug_iterate): Don't declare.
4957         * objfiles.c (separate_debug_iterator::operator++): Rename from
4958         objfile_separate_debug_iterate.
4959         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4960         iterator.
4961         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4962         iterator.
4963
4964 2019-04-10  Tom Tromey  <tom@tromey.com>
4965
4966         * symfile.c (reread_symbols): Remove old comment.
4967         * objfiles.c (free_all_objfiles): Fix a typo.
4968
4969 2019-04-10  Tom Tromey  <tom@tromey.com>
4970
4971         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4972         * minsyms.c (lookup_minimal_symbol): Use foreach.
4973         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4974         (lookup_minimal_symbol_solib_trampoline): Likewise.
4975         * symfile.c (reread_symbols): Use foreach.
4976
4977 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4978             Tom Tromey  <tromey@adacore.com>
4979
4980         PR rust/24414:
4981         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4982         (rust_lex_int_test): Change "value" to be LONGEST.
4983         (rust_lex_tests): Add test for long integer literal.
4984
4985 2019-04-09  Tom Tromey  <tromey@adacore.com>
4986
4987         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4988         to bool.
4989         (extended_remote_target::attach): Update.
4990         (remote_target::remote_notice_new_inferior): Update.
4991         (remote_target::add_current_inferior_and_thread): Update.
4992         * inferior.c (exit_inferior_1): Use "false".
4993         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4994
4995 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4996
4997         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4998         the "start" command.
4999
5000 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5001
5002         * python/py-inferior.c (infpy_thread_from_thread_handle):
5003         Adjust comments to reflect renaming of thread_from_thread_handle
5004         to thread_from_handle.  Adjust keywords.  Fix type error message.
5005         (inferior_object_methods): Add thread_from_handle.  Retain
5006         thread_from_thread_handle, but mark it as deprecated.
5007
5008 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5009
5010         * gdbthread.h (find_thread_by_handle): Revise declaration.
5011         * thread.c (find_thread_by_handle): Likewise.  Adjust
5012         implementation too.
5013         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5014         support for buffer objects as handles.
5015
5016 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5017
5018         * python/py-infthread.c (thpy_thread_handle): New function.
5019         (thread_object_methods): Register thpy_thread_handle.
5020
5021 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5022
5023         * gdbthread.h (thread_to_thread_handle): Declare.
5024         * thread.c (gdbtypes.h): Include.
5025         (thread_to_thread_handle): New function.
5026
5027         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5028         (target_thread_info_to_thread_handle): Declare.
5029         * target.c (target_thread_info_to_thread_handle): New function.
5030         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5031         * target-delegates.c: Regenerate.
5032
5033         * linux-thread-db.c (class thread_db_target): Add method
5034         thread_info_to_thread_handle.
5035         (thread_db_target::thread_info_to_thread_handle): Define.
5036         * remote.c (class remote_target): Add new method
5037         thread_info_to_thread_handle.
5038         (remote_target::thread_info_to_thread_handle): Define.
5039
5040 2019-04-08  Pedro Alves  <palves@redhat.com>
5041
5042         * common/common-exceptions.c (throw_exception): Don't create
5043         named object to throw; throw directly.
5044         (throw_it): Likewise.  Don't initialize gdb_exception::message
5045         here, with new; pass FMT and AP to the ctor instead.
5046         * common/common-exceptions.h: Include <string>.
5047         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5048         const char *, va_list)): New ctor.  Use std::make_shared.
5049         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5050         errors)): Delete.
5051         (gdb_exception_error::gdb_exception_error(enum errors, const char
5052         *, va_list)): New.
5053         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5054         Add assertion.
5055         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5056         errors)): Delete.
5057         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5058         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5059         Add assertion.
5060
5061 2019-04-08  Tom Tromey  <tom@tromey.com>
5062
5063         * valops.c (value_rtti_indirect_type): Replace throw_exception
5064         with throw.
5065         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5066         with throw.
5067         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5068         throw.
5069         * target.c (target_translate_tls_address): Replace throw_exception
5070         with throw.
5071         * stack.c (frame_apply_command_count): Replace throw_exception
5072         with throw.
5073         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5074         throw.
5075         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5076         with throw.
5077         * rs6000-tdep.c (rs6000_frame_cache)
5078         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5079         * remote.c: Replace throw_exception with throw.
5080         * record-full.c (record_full_message, record_full_wait_1)
5081         (record_full_restore): Replace throw_exception with throw.
5082         * record-btrace.c:
5083         (get_thread_current_frame_id, record_btrace_start_replaying)
5084         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5085         (cmd_record_btrace_start): Replace throw_exception with throw.
5086         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5087         throw.
5088         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5089         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5090         * linespec.c:
5091         (find_linespec_symbols): Replace throw_exception with throw.
5092         * infrun.c (displaced_step_prepare, resume): Replace
5093         throw_exception with throw.
5094         * infcmd.c (post_create_inferior): Replace throw_exception with
5095         throw.
5096         * inf-loop.c (inferior_event_handler): Replace throw_exception
5097         with throw.
5098         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5099         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5100         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5101         (get_prev_frame_always, get_frame_pc_if_available)
5102         (get_frame_address_in_block_if_available, get_frame_language):
5103         Replace throw_exception with throw.
5104         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5105         throw_exception with throw.
5106         * eval.c (fetch_subexp_value, evaluate_var_value)
5107         (evaluate_funcall, evaluate_subexp_standard): Replace
5108         throw_exception with throw.
5109         * dwarf2loc.c (call_site_find_chain)
5110         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5111         Replace throw_exception with throw.
5112         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5113         with throw.
5114         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5115         throw.
5116         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5117         * completer.c (complete_line_internal): Replace throw_exception
5118         with throw.
5119         * compile/compile-object-run.c (compile_object_run): Replace
5120         throw_exception with throw.
5121         * cli/cli-script.c (process_next_line): Replace throw_exception
5122         with throw.
5123         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5124         (btrace_enable, btrace_maint_update_pt_packets): Replace
5125         throw_exception with throw.
5126         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5127         throw_exception with throw.
5128         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5129         throw_exception with throw.
5130         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5131         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5132         * aarch64-tdep.c (aarch64_make_prologue_cache)
5133         (aarch64_make_stub_cache): Replace throw_exception with throw.
5134
5135 2019-04-08  Tom Tromey  <tom@tromey.com>
5136
5137         * common/common-exceptions.c (throw_exception): Rename from
5138         throw_exception_cxx.  Remove old copy.  Make argument const.
5139         (throw_it): Create and throw exception objects directly.
5140         * common/common-exceptions.h (throw_exception): Make argument
5141         const.
5142         (struct gdb_exception_error): Add constructor.
5143         (struct gdb_exception_quit): Add constructor.
5144
5145 2019-04-08  Tom Tromey  <tom@tromey.com>
5146
5147         * common/common-exceptions.h (exception_rethrow): Don't declare.
5148         (TRY_SJLJ): Update comment.
5149         (TRY, CATCH, END_CATCH): Remove.
5150         * common/common-exceptions.c (exception_rethrow): Remove.
5151
5152 2019-04-08  Tom Tromey  <tom@tromey.com>
5153
5154         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5155         Remove.
5156         (gdb_exception_error): Rename from
5157         gdb_exception_RETURN_MASK_ERROR.
5158         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5159         (gdb_quit_bad_alloc): Update.
5160         * aarch64-tdep.c: Update.
5161         * ada-lang.c: Update.
5162         * ada-typeprint.c: Update.
5163         * ada-valprint.c: Update.
5164         * amd64-tdep.c: Update.
5165         * arch-utils.c: Update.
5166         * break-catch-throw.c: Update.
5167         * breakpoint.c: Update.
5168         * btrace.c: Update.
5169         * c-varobj.c: Update.
5170         * cli/cli-cmds.c: Update.
5171         * cli/cli-interp.c: Update.
5172         * cli/cli-script.c: Update.
5173         * common/common-exceptions.c: Update.
5174         * common/new-op.c: Update.
5175         * common/selftest.c: Update.
5176         * compile/compile-c-symbols.c: Update.
5177         * compile/compile-cplus-symbols.c: Update.
5178         * compile/compile-object-load.c: Update.
5179         * compile/compile-object-run.c: Update.
5180         * completer.c: Update.
5181         * corelow.c: Update.
5182         * cp-abi.c: Update.
5183         * cp-support.c: Update.
5184         * cp-valprint.c: Update.
5185         * darwin-nat.c: Update.
5186         * disasm-selftests.c: Update.
5187         * dtrace-probe.c: Update.
5188         * dwarf-index-cache.c: Update.
5189         * dwarf-index-write.c: Update.
5190         * dwarf2-frame-tailcall.c: Update.
5191         * dwarf2-frame.c: Update.
5192         * dwarf2loc.c: Update.
5193         * dwarf2read.c: Update.
5194         * eval.c: Update.
5195         * event-loop.c: Update.
5196         * event-top.c: Update.
5197         * exec.c: Update.
5198         * f-valprint.c: Update.
5199         * fbsd-tdep.c: Update.
5200         * frame-unwind.c: Update.
5201         * frame.c: Update.
5202         * gdbtypes.c: Update.
5203         * gnu-v3-abi.c: Update.
5204         * guile/guile-internal.h: Update.
5205         * guile/scm-block.c: Update.
5206         * guile/scm-breakpoint.c: Update.
5207         * guile/scm-cmd.c: Update.
5208         * guile/scm-disasm.c: Update.
5209         * guile/scm-frame.c: Update.
5210         * guile/scm-lazy-string.c: Update.
5211         * guile/scm-math.c: Update.
5212         * guile/scm-param.c: Update.
5213         * guile/scm-ports.c: Update.
5214         * guile/scm-pretty-print.c: Update.
5215         * guile/scm-symbol.c: Update.
5216         * guile/scm-symtab.c: Update.
5217         * guile/scm-type.c: Update.
5218         * guile/scm-value.c: Update.
5219         * i386-linux-tdep.c: Update.
5220         * i386-tdep.c: Update.
5221         * inf-loop.c: Update.
5222         * infcall.c: Update.
5223         * infcmd.c: Update.
5224         * infrun.c: Update.
5225         * jit.c: Update.
5226         * language.c: Update.
5227         * linespec.c: Update.
5228         * linux-fork.c: Update.
5229         * linux-nat.c: Update.
5230         * linux-tdep.c: Update.
5231         * linux-thread-db.c: Update.
5232         * main.c: Update.
5233         * mi/mi-cmd-break.c: Update.
5234         * mi/mi-cmd-stack.c: Update.
5235         * mi/mi-interp.c: Update.
5236         * mi/mi-main.c: Update.
5237         * objc-lang.c: Update.
5238         * p-valprint.c: Update.
5239         * parse.c: Update.
5240         * ppc-linux-tdep.c: Update.
5241         * printcmd.c: Update.
5242         * python/py-arch.c: Update.
5243         * python/py-breakpoint.c: Update.
5244         * python/py-cmd.c: Update.
5245         * python/py-finishbreakpoint.c: Update.
5246         * python/py-frame.c: Update.
5247         * python/py-framefilter.c: Update.
5248         * python/py-gdb-readline.c: Update.
5249         * python/py-inferior.c: Update.
5250         * python/py-infthread.c: Update.
5251         * python/py-lazy-string.c: Update.
5252         * python/py-linetable.c: Update.
5253         * python/py-objfile.c: Update.
5254         * python/py-param.c: Update.
5255         * python/py-prettyprint.c: Update.
5256         * python/py-progspace.c: Update.
5257         * python/py-record-btrace.c: Update.
5258         * python/py-record.c: Update.
5259         * python/py-symbol.c: Update.
5260         * python/py-type.c: Update.
5261         * python/py-unwind.c: Update.
5262         * python/py-utils.c: Update.
5263         * python/py-value.c: Update.
5264         * python/python.c: Update.
5265         * record-btrace.c: Update.
5266         * record-full.c: Update.
5267         * remote-fileio.c: Update.
5268         * remote.c: Update.
5269         * riscv-tdep.c: Update.
5270         * rs6000-aix-tdep.c: Update.
5271         * rs6000-tdep.c: Update.
5272         * rust-exp.y: Update.
5273         * rust-lang.c: Update.
5274         * s390-tdep.c: Update.
5275         * selftest-arch.c: Update.
5276         * solib-dsbt.c: Update.
5277         * solib-frv.c: Update.
5278         * solib-spu.c: Update.
5279         * solib-svr4.c: Update.
5280         * solib.c: Update.
5281         * sparc64-linux-tdep.c: Update.
5282         * stack.c: Update.
5283         * symfile-mem.c: Update.
5284         * symmisc.c: Update.
5285         * target.c: Update.
5286         * thread.c: Update.
5287         * top.c: Update.
5288         * tracefile-tfile.c: Update.
5289         * tui/tui.c: Update.
5290         * typeprint.c: Update.
5291         * unittests/cli-utils-selftests.c: Update.
5292         * unittests/parse-connection-spec-selftests.c: Update.
5293         * valops.c: Update.
5294         * valprint.c: Update.
5295         * value.c: Update.
5296         * varobj.c: Update.
5297         * windows-nat.c: Update.
5298         * x86-linux-nat.c: Update.
5299         * xml-support.c: Update.
5300
5301 2019-04-08  Tom Tromey  <tom@tromey.com>
5302
5303         * xml-support.c: Use C++ exception handling.
5304         * x86-linux-nat.c: Use C++ exception handling.
5305         * windows-nat.c: Use C++ exception handling.
5306         * varobj.c: Use C++ exception handling.
5307         * value.c: Use C++ exception handling.
5308         * valprint.c: Use C++ exception handling.
5309         * valops.c: Use C++ exception handling.
5310         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5311         handling.
5312         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5313         * typeprint.c: Use C++ exception handling.
5314         * tui/tui.c: Use C++ exception handling.
5315         * tracefile-tfile.c: Use C++ exception handling.
5316         * top.c: Use C++ exception handling.
5317         * thread.c: Use C++ exception handling.
5318         * target.c: Use C++ exception handling.
5319         * symmisc.c: Use C++ exception handling.
5320         * symfile-mem.c: Use C++ exception handling.
5321         * stack.c: Use C++ exception handling.
5322         * sparc64-linux-tdep.c: Use C++ exception handling.
5323         * solib.c: Use C++ exception handling.
5324         * solib-svr4.c: Use C++ exception handling.
5325         * solib-spu.c: Use C++ exception handling.
5326         * solib-frv.c: Use C++ exception handling.
5327         * solib-dsbt.c: Use C++ exception handling.
5328         * selftest-arch.c: Use C++ exception handling.
5329         * s390-tdep.c: Use C++ exception handling.
5330         * rust-lang.c: Use C++ exception handling.
5331         * rust-exp.y: Use C++ exception handling.
5332         * rs6000-tdep.c: Use C++ exception handling.
5333         * rs6000-aix-tdep.c: Use C++ exception handling.
5334         * riscv-tdep.c: Use C++ exception handling.
5335         * remote.c: Use C++ exception handling.
5336         * remote-fileio.c: Use C++ exception handling.
5337         * record-full.c: Use C++ exception handling.
5338         * record-btrace.c: Use C++ exception handling.
5339         * python/python.c: Use C++ exception handling.
5340         * python/py-value.c: Use C++ exception handling.
5341         * python/py-utils.c: Use C++ exception handling.
5342         * python/py-unwind.c: Use C++ exception handling.
5343         * python/py-type.c: Use C++ exception handling.
5344         * python/py-symbol.c: Use C++ exception handling.
5345         * python/py-record.c: Use C++ exception handling.
5346         * python/py-record-btrace.c: Use C++ exception handling.
5347         * python/py-progspace.c: Use C++ exception handling.
5348         * python/py-prettyprint.c: Use C++ exception handling.
5349         * python/py-param.c: Use C++ exception handling.
5350         * python/py-objfile.c: Use C++ exception handling.
5351         * python/py-linetable.c: Use C++ exception handling.
5352         * python/py-lazy-string.c: Use C++ exception handling.
5353         * python/py-infthread.c: Use C++ exception handling.
5354         * python/py-inferior.c: Use C++ exception handling.
5355         * python/py-gdb-readline.c: Use C++ exception handling.
5356         * python/py-framefilter.c: Use C++ exception handling.
5357         * python/py-frame.c: Use C++ exception handling.
5358         * python/py-finishbreakpoint.c: Use C++ exception handling.
5359         * python/py-cmd.c: Use C++ exception handling.
5360         * python/py-breakpoint.c: Use C++ exception handling.
5361         * python/py-arch.c: Use C++ exception handling.
5362         * printcmd.c: Use C++ exception handling.
5363         * ppc-linux-tdep.c: Use C++ exception handling.
5364         * parse.c: Use C++ exception handling.
5365         * p-valprint.c: Use C++ exception handling.
5366         * objc-lang.c: Use C++ exception handling.
5367         * mi/mi-main.c: Use C++ exception handling.
5368         * mi/mi-interp.c: Use C++ exception handling.
5369         * mi/mi-cmd-stack.c: Use C++ exception handling.
5370         * mi/mi-cmd-break.c: Use C++ exception handling.
5371         * main.c: Use C++ exception handling.
5372         * linux-thread-db.c: Use C++ exception handling.
5373         * linux-tdep.c: Use C++ exception handling.
5374         * linux-nat.c: Use C++ exception handling.
5375         * linux-fork.c: Use C++ exception handling.
5376         * linespec.c: Use C++ exception handling.
5377         * language.c: Use C++ exception handling.
5378         * jit.c: Use C++ exception handling.
5379         * infrun.c: Use C++ exception handling.
5380         * infcmd.c: Use C++ exception handling.
5381         * infcall.c: Use C++ exception handling.
5382         * inf-loop.c: Use C++ exception handling.
5383         * i386-tdep.c: Use C++ exception handling.
5384         * i386-linux-tdep.c: Use C++ exception handling.
5385         * guile/scm-value.c: Use C++ exception handling.
5386         * guile/scm-type.c: Use C++ exception handling.
5387         * guile/scm-symtab.c: Use C++ exception handling.
5388         * guile/scm-symbol.c: Use C++ exception handling.
5389         * guile/scm-pretty-print.c: Use C++ exception handling.
5390         * guile/scm-ports.c: Use C++ exception handling.
5391         * guile/scm-param.c: Use C++ exception handling.
5392         * guile/scm-math.c: Use C++ exception handling.
5393         * guile/scm-lazy-string.c: Use C++ exception handling.
5394         * guile/scm-frame.c: Use C++ exception handling.
5395         * guile/scm-disasm.c: Use C++ exception handling.
5396         * guile/scm-cmd.c: Use C++ exception handling.
5397         * guile/scm-breakpoint.c: Use C++ exception handling.
5398         * guile/scm-block.c: Use C++ exception handling.
5399         * guile/guile-internal.h: Use C++ exception handling.
5400         * gnu-v3-abi.c: Use C++ exception handling.
5401         * gdbtypes.c: Use C++ exception handling.
5402         * frame.c: Use C++ exception handling.
5403         * frame-unwind.c: Use C++ exception handling.
5404         * fbsd-tdep.c: Use C++ exception handling.
5405         * f-valprint.c: Use C++ exception handling.
5406         * exec.c: Use C++ exception handling.
5407         * event-top.c: Use C++ exception handling.
5408         * event-loop.c: Use C++ exception handling.
5409         * eval.c: Use C++ exception handling.
5410         * dwarf2read.c: Use C++ exception handling.
5411         * dwarf2loc.c: Use C++ exception handling.
5412         * dwarf2-frame.c: Use C++ exception handling.
5413         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5414         * dwarf-index-write.c: Use C++ exception handling.
5415         * dwarf-index-cache.c: Use C++ exception handling.
5416         * dtrace-probe.c: Use C++ exception handling.
5417         * disasm-selftests.c: Use C++ exception handling.
5418         * darwin-nat.c: Use C++ exception handling.
5419         * cp-valprint.c: Use C++ exception handling.
5420         * cp-support.c: Use C++ exception handling.
5421         * cp-abi.c: Use C++ exception handling.
5422         * corelow.c: Use C++ exception handling.
5423         * completer.c: Use C++ exception handling.
5424         * compile/compile-object-run.c: Use C++ exception handling.
5425         * compile/compile-object-load.c: Use C++ exception handling.
5426         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5427         * compile/compile-c-symbols.c: Use C++ exception handling.
5428         * common/selftest.c: Use C++ exception handling.
5429         * common/new-op.c: Use C++ exception handling.
5430         * cli/cli-script.c: Use C++ exception handling.
5431         * cli/cli-interp.c: Use C++ exception handling.
5432         * cli/cli-cmds.c: Use C++ exception handling.
5433         * c-varobj.c: Use C++ exception handling.
5434         * btrace.c: Use C++ exception handling.
5435         * breakpoint.c: Use C++ exception handling.
5436         * break-catch-throw.c: Use C++ exception handling.
5437         * arch-utils.c: Use C++ exception handling.
5438         * amd64-tdep.c: Use C++ exception handling.
5439         * ada-valprint.c: Use C++ exception handling.
5440         * ada-typeprint.c: Use C++ exception handling.
5441         * ada-lang.c: Use C++ exception handling.
5442         * aarch64-tdep.c: Use C++ exception handling.
5443
5444 2019-04-08  Tom Tromey  <tom@tromey.com>
5445
5446         * xml-support.c (gdb_xml_parser::parse): Update.
5447         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5448         * value.c (show_convenience): Update.
5449         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5450         (test_parse_flags_qcs): Update.
5451         * thread.c (thr_try_catch_cmd): Update.
5452         * target.c (target_translate_tls_address): Update.
5453         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5454         (info_frame_command_core, frame_apply_command_count): Update.
5455         * rust-exp.y (rust_lex_exception_test): Update.
5456         * riscv-tdep.c (riscv_print_one_register_info): Update.
5457         * remote.c (remote_target::enable_btrace): Update.
5458         * record-btrace.c (record_btrace_enable_warn): Update.
5459         * python/py-utils.c (gdbpy_convert_exception): Update.
5460         * printcmd.c (do_one_display, print_variable_and_value): Update.
5461         * mi/mi-main.c (mi_print_exception): Update.
5462         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5463         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5464         * linux-nat.c (linux_nat_target::attach): Update.
5465         * linux-fork.c (class scoped_switch_fork_info): Update.
5466         * infrun.c (displaced_step_prepare): Update.
5467         * infcall.c (call_function_by_hand_dummy): Update.
5468         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5469         * gnu-v3-abi.c (print_one_vtable): Update.
5470         * frame.c (get_prev_frame_always): Update.
5471         * f-valprint.c (info_common_command_for_block): Update.
5472         * exec.c (try_open_exec_file): Update.
5473         * exceptions.c (print_exception, exception_print)
5474         (exception_fprintf, exception_print_same): Update.
5475         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5476         * dwarf-index-cache.c (index_cache::store)
5477         (index_cache::lookup_gdb_index): Update.
5478         * darwin-nat.c (maybe_cache_shell): Update.
5479         * cp-valprint.c (cp_print_value_fields): Update.
5480         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5481         (gcc_cplus_symbol_address): Update.
5482         * compile/compile-c-symbols.c (gcc_convert_symbol)
5483         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5484         * common/selftest.c: Update.
5485         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5486         a std::string.
5487         (exception_try_scope_entry, exception_try_scope_exit): Don't
5488         declare.
5489         (struct exception_try_scope): Remove.
5490         (TRY): Don't use exception_try_scope.
5491         (struct gdb_exception): Add constructor, operator=.
5492         <what>: New method.
5493         (struct gdb_exception_RETURN_MASK_ALL)
5494         (struct gdb_exception_RETURN_MASK_ERROR)
5495         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5496         (struct gdb_quit_bad_alloc): Update.
5497         * common/common-exceptions.c (exception_none): Change
5498         initializer.
5499         (struct catcher) <state, exception>: Initialize inline.
5500         <prev>: Remove member.
5501         (current_catcher): Remove.
5502         (catchers): New global.
5503         (exceptions_state_mc_init): Simplify.
5504         (catcher_pop): Remove.
5505         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5506         (try_scope_depth, exception_try_scope_entry)
5507         (exception_try_scope_exit): Remove.
5508         (throw_exception_sjlj): Update.
5509         (exception_messages, exception_messages_size): Remove.
5510         (throw_it): Simplify.
5511         (gdb_exception_sliced_copy): Remove.
5512         (throw_exception_cxx): Update.
5513         * cli/cli-script.c (script_from_file): Update.
5514         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5515         Update.
5516         * ada-valprint.c (ada_val_print): Update.
5517         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5518         (create_excep_cond_exprs): Update.
5519
5520 2019-04-08  Tom Tromey  <tom@tromey.com>
5521
5522         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5523         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5524         (TRY, CATCH, END_CATCH): Remove some definitions.
5525         * common/common-exceptions.c: Don't use GDB_XCPT.
5526         (catcher_list_size): Remove.
5527         (throw_exception, throw_it): Simplify.
5528
5529 2019-04-05  Tom Tromey  <tom@tromey.com>
5530
5531         Revert the header-sorting patch.
5532         * ft32-tdep.c: Revert.
5533         * frv-tdep.c: Revert.
5534         * frv-linux-tdep.c: Revert.
5535         * frame.c: Revert.
5536         * frame-unwind.c: Revert.
5537         * frame-base.c: Revert.
5538         * fork-child.c: Revert.
5539         * findvar.c: Revert.
5540         * findcmd.c: Revert.
5541         * filesystem.c: Revert.
5542         * filename-seen-cache.h: Revert.
5543         * filename-seen-cache.c: Revert.
5544         * fbsd-tdep.c: Revert.
5545         * fbsd-nat.h: Revert.
5546         * fbsd-nat.c: Revert.
5547         * f-valprint.c: Revert.
5548         * f-typeprint.c: Revert.
5549         * f-lang.c: Revert.
5550         * extension.h: Revert.
5551         * extension.c: Revert.
5552         * extension-priv.h: Revert.
5553         * expprint.c: Revert.
5554         * exec.h: Revert.
5555         * exec.c: Revert.
5556         * exceptions.c: Revert.
5557         * event-top.c: Revert.
5558         * event-loop.c: Revert.
5559         * eval.c: Revert.
5560         * elfread.c: Revert.
5561         * dwarf2read.h: Revert.
5562         * dwarf2read.c: Revert.
5563         * dwarf2loc.c: Revert.
5564         * dwarf2expr.h: Revert.
5565         * dwarf2expr.c: Revert.
5566         * dwarf2-frame.c: Revert.
5567         * dwarf2-frame-tailcall.c: Revert.
5568         * dwarf-index-write.h: Revert.
5569         * dwarf-index-write.c: Revert.
5570         * dwarf-index-common.c: Revert.
5571         * dwarf-index-cache.h: Revert.
5572         * dwarf-index-cache.c: Revert.
5573         * dummy-frame.c: Revert.
5574         * dtrace-probe.c: Revert.
5575         * disasm.h: Revert.
5576         * disasm.c: Revert.
5577         * disasm-selftests.c: Revert.
5578         * dictionary.c: Revert.
5579         * dicos-tdep.c: Revert.
5580         * demangle.c: Revert.
5581         * dcache.h: Revert.
5582         * dcache.c: Revert.
5583         * darwin-nat.h: Revert.
5584         * darwin-nat.c: Revert.
5585         * darwin-nat-info.c: Revert.
5586         * d-valprint.c: Revert.
5587         * d-namespace.c: Revert.
5588         * d-lang.c: Revert.
5589         * ctf.c: Revert.
5590         * csky-tdep.c: Revert.
5591         * csky-linux-tdep.c: Revert.
5592         * cris-tdep.c: Revert.
5593         * cris-linux-tdep.c: Revert.
5594         * cp-valprint.c: Revert.
5595         * cp-support.c: Revert.
5596         * cp-namespace.c: Revert.
5597         * cp-abi.c: Revert.
5598         * corelow.c: Revert.
5599         * corefile.c: Revert.
5600         * continuations.c: Revert.
5601         * completer.h: Revert.
5602         * completer.c: Revert.
5603         * complaints.c: Revert.
5604         * coffread.c: Revert.
5605         * coff-pe-read.c: Revert.
5606         * cli-out.h: Revert.
5607         * cli-out.c: Revert.
5608         * charset.c: Revert.
5609         * c-varobj.c: Revert.
5610         * c-valprint.c: Revert.
5611         * c-typeprint.c: Revert.
5612         * c-lang.c: Revert.
5613         * buildsym.c: Revert.
5614         * buildsym-legacy.c: Revert.
5615         * build-id.h: Revert.
5616         * build-id.c: Revert.
5617         * btrace.c: Revert.
5618         * bsd-uthread.c: Revert.
5619         * breakpoint.h: Revert.
5620         * breakpoint.c: Revert.
5621         * break-catch-throw.c: Revert.
5622         * break-catch-syscall.c: Revert.
5623         * break-catch-sig.c: Revert.
5624         * blockframe.c: Revert.
5625         * block.c: Revert.
5626         * bfin-tdep.c: Revert.
5627         * bfin-linux-tdep.c: Revert.
5628         * bfd-target.c: Revert.
5629         * bcache.c: Revert.
5630         * ax-general.c: Revert.
5631         * ax-gdb.h: Revert.
5632         * ax-gdb.c: Revert.
5633         * avr-tdep.c: Revert.
5634         * auxv.c: Revert.
5635         * auto-load.c: Revert.
5636         * arm-wince-tdep.c: Revert.
5637         * arm-tdep.c: Revert.
5638         * arm-symbian-tdep.c: Revert.
5639         * arm-pikeos-tdep.c: Revert.
5640         * arm-obsd-tdep.c: Revert.
5641         * arm-nbsd-tdep.c: Revert.
5642         * arm-nbsd-nat.c: Revert.
5643         * arm-linux-tdep.c: Revert.
5644         * arm-linux-nat.c: Revert.
5645         * arm-fbsd-tdep.c: Revert.
5646         * arm-fbsd-nat.c: Revert.
5647         * arm-bsd-tdep.c: Revert.
5648         * arch-utils.c: Revert.
5649         * arc-tdep.c: Revert.
5650         * arc-newlib-tdep.c: Revert.
5651         * annotate.h: Revert.
5652         * annotate.c: Revert.
5653         * amd64-windows-tdep.c: Revert.
5654         * amd64-windows-nat.c: Revert.
5655         * amd64-tdep.c: Revert.
5656         * amd64-sol2-tdep.c: Revert.
5657         * amd64-obsd-tdep.c: Revert.
5658         * amd64-obsd-nat.c: Revert.
5659         * amd64-nbsd-tdep.c: Revert.
5660         * amd64-nbsd-nat.c: Revert.
5661         * amd64-nat.c: Revert.
5662         * amd64-linux-tdep.c: Revert.
5663         * amd64-linux-nat.c: Revert.
5664         * amd64-fbsd-tdep.c: Revert.
5665         * amd64-fbsd-nat.c: Revert.
5666         * amd64-dicos-tdep.c: Revert.
5667         * amd64-darwin-tdep.c: Revert.
5668         * amd64-bsd-nat.c: Revert.
5669         * alpha-tdep.c: Revert.
5670         * alpha-obsd-tdep.c: Revert.
5671         * alpha-nbsd-tdep.c: Revert.
5672         * alpha-mdebug-tdep.c: Revert.
5673         * alpha-linux-tdep.c: Revert.
5674         * alpha-linux-nat.c: Revert.
5675         * alpha-bsd-tdep.c: Revert.
5676         * alpha-bsd-nat.c: Revert.
5677         * aix-thread.c: Revert.
5678         * agent.c: Revert.
5679         * addrmap.c: Revert.
5680         * ada-varobj.c: Revert.
5681         * ada-valprint.c: Revert.
5682         * ada-typeprint.c: Revert.
5683         * ada-tasks.c: Revert.
5684         * ada-lang.c: Revert.
5685         * aarch64-tdep.c: Revert.
5686         * aarch64-ravenscar-thread.c: Revert.
5687         * aarch64-newlib-tdep.c: Revert.
5688         * aarch64-linux-tdep.c: Revert.
5689         * aarch64-linux-nat.c: Revert.
5690         * aarch64-fbsd-tdep.c: Revert.
5691         * aarch64-fbsd-nat.c: Revert.
5692         * aarch32-linux-nat.c: Revert.
5693
5694 2019-04-05  Tom Tromey  <tom@tromey.com>
5695
5696         * ft32-tdep.c: Sort headers.
5697         * frv-tdep.c: Sort headers.
5698         * frv-linux-tdep.c: Sort headers.
5699         * frame.c: Sort headers.
5700         * frame-unwind.c: Sort headers.
5701         * frame-base.c: Sort headers.
5702         * fork-child.c: Sort headers.
5703         * findvar.c: Sort headers.
5704         * findcmd.c: Sort headers.
5705         * filesystem.c: Sort headers.
5706         * filename-seen-cache.h: Sort headers.
5707         * filename-seen-cache.c: Sort headers.
5708         * fbsd-tdep.c: Sort headers.
5709         * fbsd-nat.h: Sort headers.
5710         * fbsd-nat.c: Sort headers.
5711         * f-valprint.c: Sort headers.
5712         * f-typeprint.c: Sort headers.
5713         * f-lang.c: Sort headers.
5714         * extension.h: Sort headers.
5715         * extension.c: Sort headers.
5716         * extension-priv.h: Sort headers.
5717         * expprint.c: Sort headers.
5718         * exec.h: Sort headers.
5719         * exec.c: Sort headers.
5720         * exceptions.c: Sort headers.
5721         * event-top.c: Sort headers.
5722         * event-loop.c: Sort headers.
5723         * eval.c: Sort headers.
5724         * elfread.c: Sort headers.
5725         * dwarf2read.h: Sort headers.
5726         * dwarf2read.c: Sort headers.
5727         * dwarf2loc.c: Sort headers.
5728         * dwarf2expr.h: Sort headers.
5729         * dwarf2expr.c: Sort headers.
5730         * dwarf2-frame.c: Sort headers.
5731         * dwarf2-frame-tailcall.c: Sort headers.
5732         * dwarf-index-write.h: Sort headers.
5733         * dwarf-index-write.c: Sort headers.
5734         * dwarf-index-common.c: Sort headers.
5735         * dwarf-index-cache.h: Sort headers.
5736         * dwarf-index-cache.c: Sort headers.
5737         * dummy-frame.c: Sort headers.
5738         * dtrace-probe.c: Sort headers.
5739         * disasm.h: Sort headers.
5740         * disasm.c: Sort headers.
5741         * disasm-selftests.c: Sort headers.
5742         * dictionary.c: Sort headers.
5743         * dicos-tdep.c: Sort headers.
5744         * demangle.c: Sort headers.
5745         * dcache.h: Sort headers.
5746         * dcache.c: Sort headers.
5747         * darwin-nat.h: Sort headers.
5748         * darwin-nat.c: Sort headers.
5749         * darwin-nat-info.c: Sort headers.
5750         * d-valprint.c: Sort headers.
5751         * d-namespace.c: Sort headers.
5752         * d-lang.c: Sort headers.
5753         * ctf.c: Sort headers.
5754         * csky-tdep.c: Sort headers.
5755         * csky-linux-tdep.c: Sort headers.
5756         * cris-tdep.c: Sort headers.
5757         * cris-linux-tdep.c: Sort headers.
5758         * cp-valprint.c: Sort headers.
5759         * cp-support.c: Sort headers.
5760         * cp-namespace.c: Sort headers.
5761         * cp-abi.c: Sort headers.
5762         * corelow.c: Sort headers.
5763         * corefile.c: Sort headers.
5764         * continuations.c: Sort headers.
5765         * completer.h: Sort headers.
5766         * completer.c: Sort headers.
5767         * complaints.c: Sort headers.
5768         * coffread.c: Sort headers.
5769         * coff-pe-read.c: Sort headers.
5770         * cli-out.h: Sort headers.
5771         * cli-out.c: Sort headers.
5772         * charset.c: Sort headers.
5773         * c-varobj.c: Sort headers.
5774         * c-valprint.c: Sort headers.
5775         * c-typeprint.c: Sort headers.
5776         * c-lang.c: Sort headers.
5777         * buildsym.c: Sort headers.
5778         * buildsym-legacy.c: Sort headers.
5779         * build-id.h: Sort headers.
5780         * build-id.c: Sort headers.
5781         * btrace.c: Sort headers.
5782         * bsd-uthread.c: Sort headers.
5783         * breakpoint.h: Sort headers.
5784         * breakpoint.c: Sort headers.
5785         * break-catch-throw.c: Sort headers.
5786         * break-catch-syscall.c: Sort headers.
5787         * break-catch-sig.c: Sort headers.
5788         * blockframe.c: Sort headers.
5789         * block.c: Sort headers.
5790         * bfin-tdep.c: Sort headers.
5791         * bfin-linux-tdep.c: Sort headers.
5792         * bfd-target.c: Sort headers.
5793         * bcache.c: Sort headers.
5794         * ax-general.c: Sort headers.
5795         * ax-gdb.h: Sort headers.
5796         * ax-gdb.c: Sort headers.
5797         * avr-tdep.c: Sort headers.
5798         * auxv.c: Sort headers.
5799         * auto-load.c: Sort headers.
5800         * arm-wince-tdep.c: Sort headers.
5801         * arm-tdep.c: Sort headers.
5802         * arm-symbian-tdep.c: Sort headers.
5803         * arm-pikeos-tdep.c: Sort headers.
5804         * arm-obsd-tdep.c: Sort headers.
5805         * arm-nbsd-tdep.c: Sort headers.
5806         * arm-nbsd-nat.c: Sort headers.
5807         * arm-linux-tdep.c: Sort headers.
5808         * arm-linux-nat.c: Sort headers.
5809         * arm-fbsd-tdep.c: Sort headers.
5810         * arm-fbsd-nat.c: Sort headers.
5811         * arm-bsd-tdep.c: Sort headers.
5812         * arch-utils.c: Sort headers.
5813         * arc-tdep.c: Sort headers.
5814         * arc-newlib-tdep.c: Sort headers.
5815         * annotate.h: Sort headers.
5816         * annotate.c: Sort headers.
5817         * amd64-windows-tdep.c: Sort headers.
5818         * amd64-windows-nat.c: Sort headers.
5819         * amd64-tdep.c: Sort headers.
5820         * amd64-sol2-tdep.c: Sort headers.
5821         * amd64-obsd-tdep.c: Sort headers.
5822         * amd64-obsd-nat.c: Sort headers.
5823         * amd64-nbsd-tdep.c: Sort headers.
5824         * amd64-nbsd-nat.c: Sort headers.
5825         * amd64-nat.c: Sort headers.
5826         * amd64-linux-tdep.c: Sort headers.
5827         * amd64-linux-nat.c: Sort headers.
5828         * amd64-fbsd-tdep.c: Sort headers.
5829         * amd64-fbsd-nat.c: Sort headers.
5830         * amd64-dicos-tdep.c: Sort headers.
5831         * amd64-darwin-tdep.c: Sort headers.
5832         * amd64-bsd-nat.c: Sort headers.
5833         * alpha-tdep.c: Sort headers.
5834         * alpha-obsd-tdep.c: Sort headers.
5835         * alpha-nbsd-tdep.c: Sort headers.
5836         * alpha-mdebug-tdep.c: Sort headers.
5837         * alpha-linux-tdep.c: Sort headers.
5838         * alpha-linux-nat.c: Sort headers.
5839         * alpha-bsd-tdep.c: Sort headers.
5840         * alpha-bsd-nat.c: Sort headers.
5841         * aix-thread.c: Sort headers.
5842         * agent.c: Sort headers.
5843         * addrmap.c: Sort headers.
5844         * ada-varobj.c: Sort headers.
5845         * ada-valprint.c: Sort headers.
5846         * ada-typeprint.c: Sort headers.
5847         * ada-tasks.c: Sort headers.
5848         * ada-lang.c: Sort headers.
5849         * aarch64-tdep.c: Sort headers.
5850         * aarch64-ravenscar-thread.c: Sort headers.
5851         * aarch64-newlib-tdep.c: Sort headers.
5852         * aarch64-linux-tdep.c: Sort headers.
5853         * aarch64-linux-nat.c: Sort headers.
5854         * aarch64-fbsd-tdep.c: Sort headers.
5855         * aarch64-fbsd-nat.c: Sort headers.
5856         * aarch32-linux-nat.c: Sort headers.
5857
5858 2019-04-04  Tom Tromey  <tom@tromey.com>
5859
5860         * varobj.c (varobj_create): Update.
5861         * rust-exp.y (struct rust_parser) <update_innermost_block,
5862         lookup_symbol>: New methods.
5863         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5864         Rename.
5865         (rust_parser::rust_lookup_type)
5866         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5867         * printcmd.c (display_command, do_one_display): Update.
5868         * parser-defs.h (struct parser_state) <parser_state>: Add
5869         "tracker" parameter.
5870         (block_tracker): New member.
5871         (class innermost_block_tracker) <innermost_block_tracker>: Add
5872         "types" parameter.
5873         <reset>: Remove method.
5874         (innermost_block): Don't declare.
5875         (null_post_parser): Update.
5876         * parse.c (innermost_block): Remove global.
5877         (write_dollar_variable): Update.
5878         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5879         Remove "tracker_types" parameter.
5880         (parse_expression): Add "tracker" parameter.
5881         (parse_expression_for_completion): Update.
5882         (null_post_parser): Add "tracker" parameter.
5883         * p-exp.y: Update rules.
5884         * m2-exp.y: Update rules.
5885         * language.h (struct language_defn) <la_post_parser>: Add
5886         "tracker" parameter.
5887         * go-exp.y: Update rules.
5888         * f-exp.y: Update rules.
5889         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5890         parameter.
5891         * d-exp.y: Update rules.
5892         * c-exp.y: Update rules.
5893         * breakpoint.c (set_breakpoint_condition): Create an
5894         innermost_block_tracker.
5895         (watch_command_1): Likewise.
5896         * ada-lang.c (resolve): Add "tracker" parameter.
5897         (resolve_subexp): Likewise.
5898         * ada-exp.y (write_var_from_sym): Update.
5899
5900 2019-04-04  Tom Tromey  <tom@tromey.com>
5901
5902         * type-stack.h: New file.
5903         * type-stack.c: New file.
5904         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5905         type-stack.h.
5906         (insert_into_type_stack, insert_type, push_type, push_type_int)
5907         (insert_type_address_space, pop_type, pop_type_int)
5908         (pop_typelist, pop_type_stack, append_type_stack)
5909         (push_type_stack, get_type_stack, push_typelist)
5910         (follow_type_instance_flags, follow_types): Don't declare.
5911         * parse.c (type_stack): Remove global.
5912         (parse_exp_in_context): Update.
5913         (insert_into_type_stack, insert_type, push_type, push_type_int)
5914         (insert_type_address_space, pop_type, pop_type_int)
5915         (pop_typelist, pop_type_stack, append_type_stack)
5916         (push_type_stack, get_type_stack, push_typelist)
5917         (follow_type_instance_flags, follow_types): Remove (moved to
5918         type-stack.c).
5919         * f-exp.y (type_stack): New global.
5920         Update rules.
5921         (push_kind_type, f_parse): Update.
5922         * d-exp.y (type_stack): New global.
5923         Update rules.
5924         (d_parse): Update.
5925         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5926         Update rules.
5927         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5928         (HFILES_NO_SRCDIR): Add type-stack.h.
5929
5930 2019-04-04  Tom Tromey  <tom@tromey.com>
5931
5932         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5933         (rust_parser::convert_ast_to_expression, rust_parse)
5934         (rust_lex_test_completion, rust_lex_tests): Update.
5935         * parser-defs.h (struct expr_completion_state): New.
5936         (struct parser_state) <parser_state>: Add completion parameter.
5937         <mark_struct_expression, mark_completion_tag>: New methods.
5938         <parse_completion, m_completion_state>: New members.
5939         (prefixify_expression, null_post_parser): Update.
5940         (mark_struct_expression, mark_completion_tag): Don't declare.
5941         * parse.c (parse_completion, expout_last_struct)
5942         (expout_tag_completion_type, expout_completion_name): Remove
5943         globals.
5944         (parser_state::mark_struct_expression)
5945         (parser_state::mark_completion_tag): Now methods.
5946         (prefixify_expression): Add last_struct parameter.
5947         (prefixify_subexp): Likewise.
5948         (parse_exp_1): Update.
5949         (parse_exp_in_context): Add cstate parameter.  Update.
5950         (parse_expression_for_completion): Create an
5951         expr_completion_state.
5952         (null_post_parser): Add "completion" parameter.
5953         * p-exp.y: Update rules.
5954         (yylex): Update.
5955         * language.h (struct language_defn) <la_post_parser>: Add
5956         "completing" parameter.
5957         * go-exp.y: Update rules.
5958         (lex_one_token): Update.
5959         * expression.h (parse_completion): Don't declare.
5960         * d-exp.y: Update rules.
5961         (lex_one_token): Update rules.
5962         * c-exp.y: Update rules.
5963         (lex_one_token): Update.
5964         * ada-lang.c (resolve): Add "parse_completion" parameter.
5965         (resolve_subexp): Likewise.
5966         (ada_resolve_function): Likewise.
5967
5968 2019-04-04  Tom Tromey  <tom@tromey.com>
5969
5970         * parser-defs.h (struct parser_state) <start_arglist,
5971         end_arglist>: New methods.
5972         <arglist_len, m_funcall_chain>: New members.
5973         (arglist_len, start_arglist, end_arglist): Don't declare.
5974         * parse.c (arglist_len, funcall_chain): Remove global.
5975         (start_arglist, end_arglist): Remove functions.
5976         (parse_exp_in_context): Update.
5977         * p-exp.y: Update rules.
5978         * m2-exp.y: Update rules.
5979         * go-exp.y: Update rules.
5980         * f-exp.y: Update rules.
5981         * d-exp.y: Update rules.
5982         * c-exp.y: Update rules.
5983
5984 2019-04-04  Tom Tromey  <tom@tromey.com>
5985
5986         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5987         lex_operator, push_back>: New methods.
5988         Update all rules.
5989         (rust_parser::lex_hex, lex_escape): Rename and update.
5990         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5991         (rust_parser::lex_operator): Rename and update.
5992         (rust_parser::lex_number, rustyylex, rustyyerror)
5993         (rust_lex_test_init, rust_lex_test_sequence)
5994         (rust_lex_test_push_back, rust_lex_tests): Update.
5995         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5996         parameter.
5997         <lexptr, prev_lexptr>: New members.
5998         (lexptr, prev_lexptr): Don't declare.
5999         * parse.c (lexptr, prev_lexptr): Remove globals.
6000         (parse_exp_in_context): Update.
6001         * p-exp.y (yylex, yyerror): Update.
6002         * m2-exp.y (parse_number, yylex, yyerror): Update.
6003         * go-exp.y (lex_one_token, yyerror): Update.
6004         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6005         * d-exp.y (lex_one_token, yyerror): Update.
6006         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6007         (lex_one_token, yyerror): Update.
6008         * ada-lex.l (YY_INPUT): Update.
6009         (rewind_to_char): Update.
6010         * ada-exp.y (yyerror): Update.
6011
6012 2019-04-04  Tom Tromey  <tom@tromey.com>
6013
6014         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6015         * parser-defs.h (struct parser_state) <parser_state>: Add new
6016         parameter.
6017         <comma_terminates>: New member.
6018         (comma_terminates): Don't declare global.
6019         * parse.c (comma_terminates): Remove global.
6020         (parse_exp_in_context): Update.
6021         * p-exp.y (yylex): Update.
6022         * m2-exp.y (yylex): Update.
6023         * go-exp.y (lex_one_token): Update.
6024         * f-exp.y (yylex): Update.
6025         * d-exp.y (lex_one_token): Update.
6026         * c-exp.y (lex_one_token): Update.
6027         * ada-lex.l: Update.
6028
6029 2019-04-04  Tom Tromey  <tom@tromey.com>
6030
6031         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6032         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6033         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6034         * parser-defs.h (paren_depth): Don't declare.
6035         * parse.c (paren_depth): Remove global.
6036         (parse_exp_in_context): Update.
6037         * p-exp.y (paren_depth): New global.
6038         (pascal_parse): Initialize it.
6039         * m2-exp.y (paren_depth): New global.
6040         (m2_parse): Initialize it.
6041         * go-exp.y (paren_depth): New global.
6042         (go_parse): Initialize it.
6043         * f-exp.y (paren_depth): New global.
6044         (f_parse): Initialize it.
6045         * d-exp.y (paren_depth): New global.
6046         (d_parse): Initialize it.
6047         * c-exp.y (paren_depth): New global.
6048         (c_parse): Initialize it.
6049         * ada-lex.l (paren_depth): New global.
6050         (lexer_init): Initialize it.
6051
6052 2019-04-04  Tom Tromey  <tom@tromey.com>
6053
6054         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6055         (rust_parser::convert_ast_to_type)
6056         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6057         * parser-defs.h (struct parser_state) <parser_state>: Add
6058         parameters.  Initialize new members.
6059         <expression_context_block, expression_context_pc>: New members.
6060         * parse.c (expression_context_block, expression_context_pc):
6061         Remove globals.
6062         (parse_exp_in_context): Update.
6063         * p-exp.y: Update all rules.
6064         (yylex): Update.
6065         * m2-exp.y: Update all rules.
6066         (yylex): Update.
6067         * go-exp.y (yylex): Update.
6068         * f-exp.y (yylex): Update.
6069         * d-exp.y: Update all rules.
6070         (yylex): Update.
6071         * c-exp.y: Update all rules.
6072         (lex_one_token, classify_name, yylex, c_parse): Update.
6073         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6074
6075 2019-04-04  Tom Tromey  <tom@tromey.com>
6076
6077         * gdbarch.h, gdbarch.c: Rebuild.
6078         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6079         * stap-probe.h:
6080         (struct stap_parse_info): Replace "parser_state" with
6081         "expr_builder".
6082         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6083         (parser_state): New class.
6084         * parse.c (expr_builder): Rename.
6085         (expr_builder::release): Rename.
6086         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6087         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6088         (write_exp_elt_longcst, write_exp_elt_floatcst)
6089         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6090         (write_exp_string_vector, write_exp_bitstring)
6091         (write_exp_msymbol, mark_struct_expression)
6092         (write_dollar_variable)
6093         (insert_type_address_space, increase_expout_size): Replace
6094         "parser_state" with "expr_builder".
6095         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6096         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6097         "parser_state" with "expr_builder".
6098
6099 2019-04-04  Tom Tromey  <tom@tromey.com>
6100
6101         * rust-exp.y: Replace "parse_language" with method call.
6102         * p-exp.y:
6103         (yylex): Replace "parse_language" with method call.
6104         * m2-exp.y:
6105         (yylex): Replace "parse_language" with method call.
6106         * go-exp.y (classify_name): Replace "parse_language" with method
6107         call.
6108         * f-exp.y (yylex): Replace "parse_language" with method call.
6109         * d-exp.y (lex_one_token): Replace "parse_language" with method
6110         call.
6111         * c-exp.y:
6112         (lex_one_token, classify_name, yylex): Replace "parse_language"
6113         with method call.
6114         * ada-exp.y (find_primitive_type, type_char)
6115         (type_system_address): Replace "parse_language" with method call.
6116
6117 2019-04-04  Tom Tromey  <tom@tromey.com>
6118
6119         * rust-exp.y: Replace "parse_gdbarch" with method call.
6120         * parse.c (write_dollar_variable, insert_type_address_space):
6121         Replace "parse_gdbarch" with method call.
6122         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6123         call.
6124         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6125         call.
6126         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6127         "parse_gdbarch" with method call.
6128         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6129         with method call.
6130         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6131         "parse_gdbarch" with method call.
6132         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6133         "parse_gdbarch" with method call.
6134         * c-exp.y (parse_type, parse_number, classify_name): Replace
6135         "parse_gdbarch" with method call.
6136         * ada-lex.l: Replace "parse_gdbarch" with method call.
6137         * ada-exp.y (parse_type, find_primitive_type, type_char)
6138         (type_system_address): Replace "parse_gdbarch" with method call.
6139
6140 2019-04-04  Tom Tromey  <tom@tromey.com>
6141
6142         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6143         * stap-probe.c (stap_parse_argument): Update.
6144         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6145         initial_size parameter.
6146         * rust-exp.y (rust_lex_tests): Update.
6147         * parse.c (parser_state): Update.
6148         (parse_exp_in_context): Update.
6149         * parser-defs.h (struct parser_state) <parser_state>: Remove
6150         "initial_size" parameter.
6151
6152 2019-04-04  Tom Tromey  <tom@tromey.com>
6153
6154         * parser-defs.h (increase_expout_size): Don't declare.
6155         * parse.c (increase_expout_size): Now static.
6156
6157 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6158
6159         * gnu-nat.c (gnu_nat_target::wait): Fix
6160         target_waitstatus_to_string call.
6161
6162 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6163
6164         * eval.c (evaluate_subexp_standard): Handle internal functions
6165         during Fortran function call handling.
6166
6167 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6168
6169         * NEWS: Mention new internal functions.
6170         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6171         (read_base_type): Use dwarf2_init_complex_target_type.
6172         * value.c (creal_internal_fn): New function.
6173         (cimag_internal_fn): New function.
6174         (_initialize_values): Register new internal functions.
6175
6176 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6177
6178         * infrun.c (stop_all_threads): If debug_infrun, always
6179         trace the wait status after wait_one, using
6180         target_waitstatus_to_string and target_pid_to_str.
6181         (handle_inferior_event): Replace various trace of
6182         wait status kind by a single trace.
6183         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6184         wait status kind image by target_waitstatus_to_string.
6185         * target/waitstatus.c (target_waitstatus_to_string): Fix
6186         obsolete comment.
6187
6188 2019-04-01  Tom Tromey  <tromey@adacore.com>
6189
6190         PR symtab/23331:
6191         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6192
6193 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6194             Pedro Alves  <palves@redhat.com>
6195
6196         * top.c (quit_force): Call 'finalize_values'.
6197         * value.c (finalize_values): New function.
6198         * value.h (finalize_values): Declare.
6199
6200 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6201
6202         * NEWS: Announce $_gdb_major and $_gdb_minor.
6203
6204         * top.c (init_gdb_version_vars): New function.
6205         (gdb_init): Call init_gdb_version_vars.
6206
6207 2019-03-29  Tom Tromey  <tromey@adacore.com>
6208
6209         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6210         help text.  Remove dead code.
6211
6212 2019-03-29  Keith Seitz  <keiths@redhat.com>
6213
6214         From Siddhesh Poyarekar:
6215         * f-lang.h (f77_get_upperbound): Return LONGEST.
6216         (f77_get_lowerbound): Likewise.
6217         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6218         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6219         print them.
6220         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6221         plongest to format print it.
6222         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6223         (f77_get_upperbound): Likewise.
6224         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6225         LOWER_BOUND to LONGEST.
6226         (f77_create_arrayprint_offset_tbl): Likewise.
6227
6228 2019-03-29  Keith Seitz  <keiths@redhat.com>
6229
6230         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6231         %s/pulongest for TYPE_LENGTH instead of %d in format
6232         strings.
6233         * ada-typerint.c (ada_print_type): Likewise.
6234         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6235         * compile/compile-c-support.c (generate_register_struct): Likewise.
6236         * gdbtypes.c (recursive_dump_type): Likewise.
6237         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6238         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6239         instead of %d in format strings.
6240         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6241         to std::min to ULONGEST.
6242         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6243         instead of %d in format strings.
6244         * tracepoint.c (info_scope_command): Likewise.
6245         * typeprint.c (print_offset_data::update)
6246         (print_offset_data::finish): Likewise.
6247         * xtensa-tdep.c (xtensa_store_return_value)
6248         (xtensa_push_dummy_call): Likewise.
6249
6250 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6251
6252         * windows-nat.c (display_selector): Fixed format specifications
6253         for 64-bit Cygwin.
6254
6255 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6256
6257         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6258
6259 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6260
6261         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6262         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6263         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6264         (nios2_linux_init_abi): Install it.
6265
6266 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6267
6268         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6269
6270 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6271
6272         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6273
6274 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6275             Tom Tromey  <tromey@adacore.com>
6276
6277         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6278
6279 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6280
6281         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6282         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6283         method to compute the bounds of range types. Also print "[evaluated]"
6284         if the bounds' values come from a dynamic evaluation.
6285
6286 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6287
6288         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6289         whitespace when pretty printing is on.
6290
6291 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6292
6293         * ppc-linux-nat.c: Add include.
6294
6295 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6296
6297         * NEWS: Mention AArch64 Pointer Authentication.
6298
6299 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6300
6301         * arm-linux-nat.c: Add include.
6302
6303 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6304
6305         * source-cache.c (source_cache::get_source_lines): Re-read
6306         fullname after calling open_source_file.
6307
6308 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6309
6310         * NEWS: Mention TLS support for FreeBSD.
6311
6312 2019-03-25  Tom Tromey  <tromey@adacore.com>
6313
6314         * minsyms.c (BUNCH_SIZE): Update comment.
6315         (~minimal_symbol_reader): Remove old comment.
6316         (compact_minimal_symbols): Update comment.
6317         (minimal_symbol_reader::install): Remove old comment.  Update
6318         other comments.
6319
6320 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6321
6322         * s390-linux-nat.c: Add include.
6323
6324 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6325
6326         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6327         Call linux_get_hwcap.
6328         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6329         Likewise.
6330         (aarch64_linux_get_hwcap): Remove function.
6331         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6332         declaration.
6333         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6334         linux_get_hwcap.
6335         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6336         * linux-tdep.c (linux_get_hwcap): Add function.
6337         (linux_get_hwcap2): Likewise.
6338         * linux-tdep.h (linux_get_hwcap): Add declaration.
6339         (linux_get_hwcap2): Likewise.
6340         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6341         (ppc_linux_get_hwcap2): Likewise.
6342         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6343         linux_get_hwcap.
6344         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6345         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6346         (ppc_linux_nat_target::read_description): Likewise.
6347         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6348         * s390-linux-nat.c: Likewise.
6349         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6350
6351 2019-03-24  Tom Tromey  <tom@tromey.com>
6352
6353         * ada-lang.c (standard_lookup): Simplify initialization.
6354         (ada_lookup_symbol_nonlocal): Simplify return.
6355         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6356         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6357         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6358         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6359         initialization.
6360         * solib.c (solib_global_lookup): Simplify.
6361         * symtab.c (null_block_symbol): Remove.
6362         (symbol_cache_lookup): Simplify returns.
6363         (lookup_language_this): Simplify returns.
6364         (lookup_symbol_aux): Simplify return.
6365         (lookup_local_symbol): Simplify returns.
6366         (lookup_global_symbol_from_objfile): Simplify return.
6367         (lookup_symbol_in_objfile_symtabs)
6368         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6369         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6370         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6371         * cp-namespace.c (cp_lookup_bare_symbol)
6372         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6373         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6374         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6375         (cp_lookup_symbol_via_imports): Simplify initialization.
6376         (find_symbol_in_baseclass): Likewise.
6377         * symtab.h (null_block_symbol): Remove.
6378         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6379         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6380         (d_lookup_symbol_module): Likewise.
6381         (find_symbol_in_baseclass): Simplify initialization.
6382
6383 2019-03-24  Tom Tromey  <tom@tromey.com>
6384
6385         * expression.h: Don't include symtab.h.
6386         (struct block): Forward declare.
6387
6388 2019-03-24  Tom Tromey  <tom@tromey.com>
6389
6390         * c-exp.y (typebase): Remove casts.
6391         * gdbtypes.c (lookup_unsigned_typename, )
6392         (lookup_signed_typename): Remove cast.
6393         * eval.c (parse_to_comma_and_eval): Remove cast.
6394         * parse.c (write_dollar_variable): Remove cast.
6395         * block.h (struct block) <superblock>: Now const.
6396         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6397         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6398         (map_block): Make "block" const.
6399         * symfile.h (struct quick_symbol_functions)
6400         <map_matching_symbols>: Constify block argument to "callback".
6401         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6402         const.
6403         (find_pc_sect_compunit_symtab): Make "b" const.
6404         (find_symbol_at_address): Likewise.
6405         (search_symbols): Likewise.
6406         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6407         (dw2_debug_names_lookup_symbol): Likewise.
6408         (dw2_map_matching_symbols): Update.
6409         * p-valprint.c (pascal_val_print): Remove "block".
6410         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6411         (aux_add_nonlocal_symbols): Make "block" const.
6412         (resolve_subexp): Remove cast.
6413         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6414         const.
6415         (iterate_over_file_blocks): Likewise.
6416         * f-exp.y (%union) <bval>: Remove.
6417         * coffread.c (patch_opaque_types): Make "b" const.
6418         * spu-tdep.c (spu_catch_start): Make "block" const.
6419         * c-valprint.c (print_unpacked_pointer): Remove "block".
6420         * symmisc.c (dump_symtab_1): Make "b" const.
6421         (block_depth): Make "block" const.
6422         * d-exp.y (%union) <bval>: Remove.
6423         * cp-support.h (cp_lookup_rtti_type): Update.
6424         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6425         * psymtab.c (psym_lookup_symbol): Make "block" const.
6426         (maintenance_check_psymtabs): Make "b" const.
6427         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6428         (enumerate_locals, enumerate_args): Update.
6429         * python/py-symtab.c (stpy_global_block): Make "block" const.
6430         (stpy_static_block): Likewise.
6431         * inline-frame.c (block_starting_point_at): Make "new_block"
6432         const.
6433         * block.c (find_block_in_blockvector): Make return type const.
6434         (blockvector_for_pc_sect): Make "b" const.
6435         (find_block_in_blockvector): Make "b" const.
6436
6437 2019-03-23  Tom Tromey  <tom@tromey.com>
6438
6439         * varobj.c (varobj_create): Update.
6440         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6441         * printcmd.c (display_command, do_one_display): Don't reset
6442         innermost_block.
6443         * parser-defs.h (enum innermost_block_tracker_type): Move to
6444         expression.h.
6445         (innermost_block): Update comment.
6446         * parse.c (parse_exp_1): Add tracker_types parameter.
6447         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6448         tracker_types parameter.  Reset innermost_block.
6449         (parse_exp_in_context): Remove.
6450         (parse_expression_for_completion): Update.
6451         * objfiles.c (~objfile): Don't reset expression_context_block or
6452         innermost_block.
6453         * expression.h (enum innermost_block_tracker_type): Move from
6454         parser-defs.h.
6455         (parse_exp_1): Add tracker_types parameter.
6456         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6457         reset innermost_block.
6458
6459 2019-03-23  Tom Tromey  <tom@tromey.com>
6460
6461         * objfiles.h: Include bcache.h.
6462
6463 2019-03-23  Tom Tromey  <tom@tromey.com>
6464
6465         * linespec.c (get_current_search_block): Use
6466         scoped_restore_current_language.
6467         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6468
6469 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6470             Jiong Wang  <jiong.wang@arm.com>
6471
6472         * aarch64-linux-tdep.c
6473         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6474         section.
6475         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6476
6477 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6478             Jiong Wang  <jiong.wang@arm.com>
6479
6480         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6481         instructions.
6482         (aarch64_analyze_prologue_test): Add PACIASP test.
6483         (aarch64_prologue_prev_register): Unmask PC value.
6484
6485 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6486             Jiong Wang  <jiong.wang@arm.com>
6487
6488         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6489         (aarch64_dwarf2_prev_register): Unmask PC value.
6490         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6491         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6492         DW_CFA_AARCH64_negate_ra_state.
6493         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6494
6495 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6496             Jiong Wang  <jiong.wang@arm.com>
6497
6498         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6499         registers.
6500         (aarch64_pseudo_register_name): Likewise.
6501         (aarch64_pseudo_register_type): Likewise.
6502         (aarch64_pseudo_register_reggroup_p): Likewise.
6503         (aarch64_gdbarch_init): Add pauth registers.
6504         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6505         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6506         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6507         (struct gdbarch_tdep): Add regnum for ra_state.
6508
6509 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6510             Jiong Wang  <jiong.wang@arm.com>
6511
6512         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6513
6514 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6515             Jiong Wang  <jiong.wang@arm.com>
6516
6517         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6518         function.
6519         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6520         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6521         (aarch64_gdbarch_init): Add puth registers.
6522         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6523         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6524         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6525
6526 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6527             Jiong Wang  <jiong.wang@arm.com>
6528
6529         * aarch64-linux-nat.c
6530         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6531         * aarch64-linux-tdep.c
6532         (aarch64_linux_core_read_description): Likewise.
6533         (aarch64_linux_get_hwcap): New function.
6534         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6535         (aarch64_linux_get_hwcap): New declaration.
6536
6537 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6538             Jiong Wang  <jiong.wang@arm.com>
6539
6540         * aarch64-linux-nat.c
6541         (aarch64_linux_nat_target::read_description): Add pauth param.
6542         * aarch64-linux-tdep.c
6543         (aarch64_linux_core_read_description): Likewise.
6544         * aarch64-tdep.c (struct target_desc): Add in pauth.
6545         (aarch64_read_description): Add pauth param.
6546         (aarch64_gdbarch_init): Likewise.
6547         * aarch64-tdep.h (aarch64_read_description): Likewise.
6548         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6549         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6550         * features/Makefile: Add new files.
6551         * features/aarch64-pauth.c: New file.
6552         * features/aarch64-pauth.xml: New file.
6553
6554 2019-03-20  Tom Tromey  <tromey@adacore.com>
6555
6556         * infrun.c (handle_inferior_event): Rename from
6557         handle_inferior_event_1.  Create a scoped_value_mark.
6558         (handle_inferior_event): Remove.
6559
6560 2019-03-19  Tom Tromey  <tromey@adacore.com>
6561
6562         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6563         * infrun.h (print_stop_event): Add "displays" parameter.
6564         * infrun.c (print_stop_event): Add "displays" parameter.
6565
6566 2019-03-19  Pedro Alves  <palves@redhat.com>
6567
6568         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6569         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6570         to -1.  Fix TABs vs spaces.
6571         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6572         * tui/tui-out.h (tui_ui_out) Add intro comments.
6573         <m_line, m_start_of_line>: In-class initialize, and add describing
6574         comment.
6575
6576 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6577
6578         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6579         variable names.
6580         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6581
6582 2019-03-18  Pedro Alves  <palves@redhat.com>
6583             Eli Zaretskii <eliz@gnu.org>
6584
6585         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6586         m_line and m_start_of_line.
6587
6588 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6589
6590         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6591         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6592         it returns a newline.  This fixes a regression in TU mode, whereby
6593         the next line is output on the same screen line as the user input.
6594
6595 2019-03-18  Tom Tromey  <tromey@adacore.com>
6596
6597         * minsyms.c (minimal_symbol_reader::install): Remove call to
6598         obstack_blank.
6599
6600 2019-03-18  Pedro Alves  <palves@redhat.com>
6601
6602         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6603         New globals.
6604         (apply_style): New, factored out from ...
6605         (apply_ansi_escape): ... this.  Handle reverse video mode.
6606         (tui_set_reverse_mode): New function.
6607         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6608         * tui/tui-winsource.c (tui_show_source_line): Use
6609         tui_set_reverse_mode instead of setting A_STANDOUT.
6610         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6611         New setter methods.
6612
6613 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6614
6615         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6616         Handle tabs.
6617
6618 2019-03-18  Tom Tromey  <tromey@adacore.com>
6619
6620         * ada-lang.c (empty_array): Add "high" parameter.
6621         (ada_evaluate_subexp): Update.
6622
6623 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6624
6625         * unittests/string_view-selftests.c: Define
6626         _initialize_string_view_selftests unconditionally.
6627
6628 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6629
6630         PR gdb/24350
6631         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6632
6633 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6634
6635         PR gdb/24351
6636         * windows-nat.c (display_selector): Fix format specifiers.
6637
6638 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6639
6640         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6641         tui_refill_source_window instead of tui_refresh_win, to update the
6642         current execution line.  This fixes redisplay of the current line
6643         when stepping through the code with "next" or "step".
6644
6645 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6646
6647         * source-cache.c (source_cache::get_source_lines): Call
6648         find_source_lines to initialize s->nlines.  This fixes vertical
6649         scrolling of TUI source window when the DOWN arrow is pressed.
6650
6651 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6652
6653         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6654         linux-thread-db.c (_initialize_thread_db): Likewise.
6655
6656 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6657
6658         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6659         wclrtoeol in tui_show_source_line".  This reverts changes made in
6660         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6661
6662 2019-03-15  Tom Tromey  <tom@tromey.com>
6663
6664         * symtab.h (struct minimal_symbol): Derive from
6665         general_symbol_info.
6666         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6667         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6668         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6669         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6670         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6671         (MSYMBOL_SEARCH_NAME): Update.
6672         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6673         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6674         * minsyms.c (minimal_symbol_reader::record_full): Update.
6675
6676 2019-03-15  Tom Tromey  <tom@tromey.com>
6677
6678         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6679
6680 2019-03-15  Tom Tromey  <tom@tromey.com>
6681
6682         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6683         unique_xmalloc_ptr.
6684         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6685         Update.
6686         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6687         (build_minimal_symbol_hash_tables)
6688         (minimal_symbol_reader::install): Update.
6689
6690 2019-03-15  Tom Tromey  <tom@tromey.com>
6691
6692         * symtab.c (create_demangled_names_hash): Update.
6693         (symbol_set_names): Update.
6694         * objfiles.h (struct objfile_per_bfd_storage)
6695         <demangled_names_hash>: Now an htab_up.
6696         * objfiles.c (objfile_per_bfd_storage): Simplify.
6697
6698 2019-03-15  Tom Tromey  <tom@tromey.com>
6699
6700         * objfiles.h (struct objfile_per_bfd_storage): Declare
6701         destructor.
6702         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6703         New.
6704         (get_objfile_bfd_data): Use new.  Don't initialize
6705         language_of_main.
6706         (free_objfile_per_bfd_storage): Remove.
6707         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6708
6709 2019-03-15  Tom Tromey  <tom@tromey.com>
6710
6711         * symfile.c (reread_symbols): Update.
6712         * objfiles.c (objfile::objfile): Update.
6713         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6714         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6715         comment.
6716         (minimal_symbol_reader::install): Update.
6717         (terminate_minimal_symbol_table): Remove.
6718         * jit.c (jit_object_close_impl): Update.
6719
6720 2019-03-15  Tom Tromey  <tom@tromey.com>
6721
6722         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6723         initializations.
6724
6725 2019-03-15  Tom Tromey  <tom@tromey.com>
6726
6727         * objfiles.h (struct objfile_per_bfd_storage)
6728         <demangled_hash_languages>: Now a bitset.
6729         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6730         (lookup_minimal_symbol): Update.
6731
6732 2019-03-15  Tom Tromey  <tom@tromey.com>
6733
6734         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6735         Don't return the symbol.
6736         * coffread.c (record_minimal_symbol): Use record_full.
6737
6738 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6739
6740         The MS-Windows port of ncurses fails to switch to a color pair if
6741         one or both of the colors are the implicit default colors.  This
6742         change records the default colors when TUI is initialized, and
6743         then specifies them explicitly when a color pair uses the default
6744         colors.  This allows color styling in TUI mode on MS-Windows.
6745
6746         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6747         ncurses_norm_attr.
6748         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6749         colors in ncurses_norm_attr.
6750         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6751         "none", replace it with the default color recorded in
6752         ncurses_norm_attr.
6753
6754 2019-03-14  Tom Tromey  <tromey@adacore.com>
6755
6756         * source-cache.h (class source_cache) <get_source_lines>: Return
6757         std::string.
6758         * source-cache.c (source_cache::extract_lines): Handle case where
6759         first_pos==npos.  Return std::string.
6760         (source_cache::get_source_lines): Update.
6761
6762 2019-03-14  Tom Tromey  <tromey@adacore.com>
6763
6764         * NEWS: Add item for "style sources" commands.
6765         * source-cache.c (source_cache::get_source_lines): Check
6766         source_styling.
6767         * cli/cli-style.c (source_styling): New global.
6768         (_initialize_cli_style): Add "style sources" commands.
6769         (show_style_sources): New function.
6770         * cli/cli-style.h (source_styling): Declare.
6771
6772 2019-03-14  Pedro Alves  <palves@redhat.com>
6773             Tom Tromey  <tromey@adacore.com>
6774
6775         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6776         * tui/tui-winsource.c (tui_refill_source_window): New function,
6777         from...
6778         (tui_horizontal_source_scroll): ... here.  Move some logic.
6779         * cli/cli-style.c (set_style_enabled): Notify new observable.
6780         * tui/tui-hooks.c (tui_redisplay_source): New function.
6781         (tui_attach_detach_observers): Attach or detach
6782         tui_redisplay_source.
6783         * observable.h (source_styling_changed): New observable.
6784         * observable.c: Define source_styling_changed observable.
6785
6786 2019-03-13  Tom Tromey  <tromey@adacore.com>
6787
6788         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6789         (i386_gnu_nat_target::store_registers): Update.
6790         * target-debug.h (target_debug_print_std_string): New macro.
6791         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6792         * windows-tdep.c (display_one_tib): Update.
6793         * tui/tui-stack.c (tui_make_status_line): Update.
6794         * top.c (print_inferior_quit_action): Update.
6795         * thread.c (thr_try_catch_cmd): Update.
6796         (add_thread_with_info): Update.
6797         (thread_target_id_str): Update.
6798         (thr_try_catch_cmd): Update.
6799         (thread_command): Update.
6800         (thread_find_command): Update.
6801         * record-btrace.c (record_btrace_target::info_record)
6802         (record_btrace_resume_thread, record_btrace_target::resume)
6803         (record_btrace_cancel_resume, record_btrace_step_thread)
6804         (record_btrace_target::wait, record_btrace_target::wait)
6805         (record_btrace_target::wait, record_btrace_target::stop): Update.
6806         * progspace.c (print_program_space): Update.
6807         * process-stratum-target.c
6808         (process_stratum_target::thread_address_space): Update.
6809         * linux-fork.c (linux_fork_mourn_inferior)
6810         (detach_checkpoint_command, info_checkpoints_command)
6811         (linux_fork_context): Update.
6812         (linux_fork_detach): Update.
6813         (class scoped_switch_fork_info): Update.
6814         (delete_checkpoint_command): Update.
6815         * infrun.c (follow_fork_inferior): Update.
6816         (follow_fork_inferior): Update.
6817         (proceed_after_vfork_done): Update.
6818         (handle_vfork_child_exec_or_exit): Update.
6819         (follow_exec): Update.
6820         (displaced_step_prepare_throw): Update.
6821         (displaced_step_restore): Update.
6822         (start_step_over): Update.
6823         (resume_1): Update.
6824         (clear_proceed_status_thread): Update.
6825         (proceed): Update.
6826         (print_target_wait_results): Update.
6827         (do_target_wait): Update.
6828         (context_switch): Update.
6829         (stop_all_threads): Update.
6830         (restart_threads): Update.
6831         (finish_step_over): Update.
6832         (handle_signal_stop): Update.
6833         (switch_back_to_stepped_thread): Update.
6834         (keep_going_pass_signal): Update.
6835         (print_exited_reason): Update.
6836         (normal_stop): Update.
6837         * inferior.c (inferior_pid_to_str): Change return type.
6838         (print_selected_inferior): Update.
6839         (add_inferior): Update.
6840         (detach_inferior): Update.
6841         * dummy-frame.c (fprint_dummy_frames): Update.
6842         * dcache.c (dcache_info_1): Update.
6843         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6844         (btrace_fetch, btrace_clear): Update.
6845         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6846         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6847         type.
6848         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6849         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6850         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6851         * gdbarch.c, gdbarch.h: Rebuild.
6852         * gdbarch.sh (core_pid_to_str): Change return type.
6853         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6854         return type.
6855         (windows_nat_target::pid_to_str): Change return type.
6856         (windows_delete_thread): Update.
6857         (windows_nat_target::attach): Update.
6858         (windows_nat_target::files_info): Update.
6859         * target-delegates.c: Rebuild.
6860         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6861         return type.
6862         (sol_thread_target::pid_to_str): Change return type.
6863         * remote.c (class remote_target) <pid_to_str>: Change return
6864         type.
6865         (remote_target::pid_to_str): Change return type.
6866         (extended_remote_target::attach, remote_target::remote_stop_ns)
6867         (remote_target::remote_notif_remove_queued_reply)
6868         (remote_target::push_stop_reply, remote_target::disable_btrace):
6869         Update.
6870         (extended_remote_target::attach): Update.
6871         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6872         type.
6873         (gdbsim_target::pid_to_str): Change return type.
6874         * ravenscar-thread.c (struct ravenscar_thread_target)
6875         <pid_to_str>: Change return type.
6876         (ravenscar_thread_target::pid_to_str): Change return type.
6877         * procfs.c (class procfs_target) <pid_to_str>: Change return
6878         type.
6879         (procfs_target::pid_to_str): Change return type.
6880         (procfs_target::attach): Update.
6881         (procfs_target::detach): Update.
6882         (procfs_target::fetch_registers): Update.
6883         (procfs_target::store_registers): Update.
6884         (procfs_target::wait): Update.
6885         (procfs_target::files_info): Update.
6886         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6887         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6888         return type.
6889         (nto_procfs_target::pid_to_str): Change return type.
6890         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6891         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6892         return type.
6893         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6894         (exit_lwp): Update.
6895         (attach_proc_task_lwp_callback, get_detach_signal)
6896         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6897         (linux_nat_target::resume, wait_lwp, stop_callback)
6898         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6899         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6900         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6901         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6902         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6903         type.
6904         (inf_ptrace_target::attach): Update.
6905         (inf_ptrace_target::files_info): Update.
6906         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6907         type.
6908         (go32_nat_target::pid_to_str): Change return type.
6909         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6910         (gnu_nat_target::wait): Update.
6911         (gnu_nat_target::wait): Update.
6912         (gnu_nat_target::resume): Update.
6913         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6914         (fbsd_nat_target::wait): Update.
6915         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6916         type.
6917         (darwin_nat_target::attach): Update.
6918         * corelow.c (class core_target) <pid_to_str>: Change return type.
6919         (core_target::pid_to_str): Change return type.
6920         * target.c (normal_pid_to_str): Change return type.
6921         (default_pid_to_str): Likewise.
6922         (target_pid_to_str): Change return type.
6923         (target_translate_tls_address): Update.
6924         (target_announce_detach): Update.
6925         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6926         return type.
6927         (bsd_uthread_target::pid_to_str): Change return type.
6928         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6929         type.
6930         (bsd_kvm_target::pid_to_str): Change return type.
6931         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6932         return type.
6933         (aix_thread_target::pid_to_str): Change return type.
6934         * target.h (struct target_ops) <pid_to_str>: Change return type.
6935         (target_pid_to_str, normal_pid_to_str): Likewise.
6936         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6937         type.
6938         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6939         type.
6940         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6941         return type.
6942         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6943         type.
6944         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6945         type.
6946         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6947         return type.
6948
6949 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6950
6951         * NEWS: Mention that the new default MI version is 3.  Mention
6952         changes to the output of commands and events that deal with
6953         multi-location breakpoints.
6954         * breakpoint.c: Include "mi/mi-out.h".
6955         (print_one_breakpoint): Change output syntax if using MI version
6956         >= 3.
6957         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6958         New.
6959         (mi_multi_location_breakpoint_output_fixed): New.
6960         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6961         (mi_cmd_fix_multi_location_breakpoint_output): New.
6962         (mi_multi_location_breakpoint_output_fixed): New.
6963         * mi/mi-cmds.c (mi_cmds): Register command
6964         -fix-multi-location-breakpoint-output.
6965         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6966         interpreter "mi".
6967
6968 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6969
6970         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6971         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6972         instantiate mi_ui_out based on interpreter name.
6973         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6974         * mi/mi-main.c (mi_load_progress): Likewise.
6975
6976 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6977
6978         * NEWS: Combine separate "New targets" sections for 8.3.
6979
6980 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6981
6982         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6983         (ppcfbsd_init_abi): Install gdbarch
6984         "fetch_tls_load_module_address" and "get_thread_local_address"
6985         methods.
6986
6987 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6988
6989         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6990         (riscv_fbsd_init_abi): Install gdbarch
6991         "fetch_tls_load_module_address" and "get_thread_local_address"
6992         methods.
6993
6994 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6995
6996         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6997         (i386fbsd_init_abi): Install gdbarch
6998         "fetch_tls_load_module_address" and "get_thread_local_address"
6999         methods.
7000
7001 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7002
7003         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7004         (amd64fbsd_init_abi): Install gdbarch
7005         "fetch_tls_load_module_address" and "get_thread_local_address"
7006         methods.
7007
7008 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7009
7010         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7011         (struct fbsd_pspace_data): New type.
7012         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7013         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7014         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7015         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7016         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7017
7018 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7019
7020         * gdbtypes.c (lookup_struct_elt): New function.
7021         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7022         * gdbtypes.h (struct struct_elt): New type.
7023         (lookup_struct_elt): New prototype.
7024
7025 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7026
7027         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7028         remove disabled code block.
7029
7030 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7031
7032         * gdbarch.sh (get_thread_local_address): New method.
7033         * gdbarch.h, gdbarch.c: Regenerate.
7034         * target.c (target_translate_tls_address): Use
7035         gdbarch_get_thread_local_address if present instead of
7036         target::get_thread_local_address.
7037
7038 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7039
7040         * target.h (target::get_thread_local_address): Update comment.
7041
7042 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7043
7044         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7045         objfile->separate_debug_objfile_backlink if not NULL.
7046
7047 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7048
7049         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7050         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7051         (amd64bsd_store_inferior_registers): Likewise.
7052         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7053         Enable segment base registers.
7054         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7055         PT_GETFSBASE and PT_GETGSBASE.
7056         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7057         PT_SETGSBASE.
7058         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7059         segment base registers.
7060         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7061
7062 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7063
7064         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7065         Update calls to i386_target_description to add 'segments'
7066         parameter.
7067         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7068         add segment base registers.
7069         * arch/i386.c (i386_create_target_description): Add 'segments'
7070         parameter to enable segment base registers.
7071         * arch/i386.h (i386_create_target_description): Likewise.
7072         * features/i386/32bit-segments.xml: New file.
7073         * features/i386/32bit-segments.c: Generate.
7074         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7075         call to i386_target_description to add 'segments' parameter.
7076         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7077         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7078         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7079         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7080         if feature is present.
7081         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7082         Add 'segments' parameter to call to i386_target_description.
7083         (i386_target_description): Add 'segments' parameter to enable
7084         segment base registers.
7085         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7086         to call to i386_target_description.
7087         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7088         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7089         Define I386_NUM_REGS.
7090         (i386_target_description): Add 'segments' parameter to enable
7091         segment base registers.
7092
7093 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7094
7095         PR/24325
7096         * source-cache.c: #undef open and close, to avoid unresolved
7097         externals during linking.
7098
7099 2019-03-12  Tom Tromey  <tromey@adacore.com>
7100
7101         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7102         const.  Add initializers.
7103         (_initialize_remote): Don't initialize ptid globals.
7104
7105 2019-03-12  Pedro Alves  <palves@redhat.com>
7106
7107         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7108
7109 2019-03-12  Pedro Alves  <palves@redhat.com>
7110
7111         * cp-name-parser.y (main): Remove unused 'len' variable.
7112
7113 2019-03-12  Tom Tromey  <tromey@adacore.com>
7114
7115         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7116         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7117
7118 2019-03-12  Tom Tromey  <tromey@adacore.com>
7119
7120         * linux-nat.c (iterate_over_lwps): Update.
7121         (stop_callback): Remove parameter.
7122         (stop_wait_callback, detach_callback, resume_set_callback)
7123         (select_singlestep_lwp_callback, set_ignore_sigint)
7124         (status_callback, resumed_callback, resume_clear_callback)
7125         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7126         data parameter.
7127         (linux_nat_target::detach, linux_nat_target::resume)
7128         (linux_stop_and_wait_all_lwps, select_event_lwp)
7129         (linux_nat_filter_event, linux_nat_wait_1)
7130         (linux_nat_target::kill, linux_nat_target::stop)
7131         (linux_nat_target::stop): Update.
7132         (linux_nat_resume_callback): Change type.
7133         (resume_stopped_resumed_lwps, count_events_callback)
7134         (select_event_lwp_callback): Likewise.
7135         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7136         * arm-linux-nat.c (struct update_registers_data): Remove.
7137         (update_registers_callback): Change type.
7138         (arm_linux_insert_hw_breakpoint1): Update.
7139         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7140         parameter.
7141         (x86_linux_dr_set_addr): Update.
7142         (x86_linux_dr_set_control): Update.
7143         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7144         (iterate_over_lwps): Use gdb::function_view.
7145         * nat/aarch64-linux-hw-point.c (struct
7146         aarch64_dr_update_callback_param): Remove.
7147         (debug_reg_change_callback): Change type.
7148         (aarch64_notify_debug_reg_change): Update.
7149         * s390-linux-nat.c (s390_refresh_per_info): Update.
7150
7151 2019-03-11  Tom Tromey  <tromey@adacore.com>
7152
7153         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7154         redundant assignment to "this_cu".
7155
7156 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7157
7158         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7159
7160 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7161
7162         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7163         from...
7164         (rank_one_type): ... this.
7165
7166 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7167
7168         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7169         from...
7170         (rank_one_type): ... this.
7171
7172 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7173
7174         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7175         from...
7176         (rank_one_type): ... this.
7177
7178 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7179
7180         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7181         from...
7182         (rank_one_type): ... this.
7183
7184 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7185
7186         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7187         from...
7188         (rank_one_type): ... this.
7189
7190 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7191
7192         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7193         from...
7194         (rank_one_type): ... this.
7195
7196 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7197
7198         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7199         from...
7200         (rank_one_type): ... this.
7201
7202 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7203
7204         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7205         from...
7206         (rank_one_type): ... this.
7207
7208 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7209
7210         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7211         from...
7212         (rank_one_type): ... this.
7213
7214 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7215
7216         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7217         from...
7218         (rank_one_type): ... this.
7219
7220 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7221
7222         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7223         from...
7224         (rank_one_type): ... this.
7225
7226 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7227
7228         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7229         from...
7230         (rank_one_type): ... this.
7231
7232 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7233
7234         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7235         inferior-events' shows the example events.
7236
7237 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7238
7239         Support styling on native MS-Windows console
7240
7241         PR/24315
7242         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7243         on MS-Windows if $TERM is not defined.
7244
7245         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7246
7247         * posix-hdep.c (gdb_console_fputs):
7248         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7249         functions.
7250         * ui-file.h (gdb_console_fputs): Add prototype.
7251
7252         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7253         back to fputs only if the former returns zero.
7254
7255 2019-03-07  Tom Tromey  <tom@tromey.com>
7256
7257         * symmisc.c (print_symbol_bcache_statistics): Update.
7258         (print_objfile_statistics): Update.
7259         * symfile.c (allocate_symtab): Update.
7260         * stabsread.c: Don't include bcache.h.
7261         * psymtab.h (struct psymbol_bcache): Don't declare.
7262         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7263         (psymbol_bcache_init, psymbol_bcache_free)
7264         (psymbol_bcache_get_bcache): Don't declare.
7265         * psymtab.c (struct psymbol_bcache): Remove.
7266         (psymtab_storage::psymtab_storage): Update.
7267         (psymtab_storage::~psymtab_storage): Update.
7268         (psymbol_bcache_init, psymbol_bcache_free)
7269         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7270         (add_psymbol_to_bcache): Update.
7271         (allocate_psymtab): Update.
7272         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7273         macro_cache>: No longer pointers.
7274         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7275         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7276         * macrotab.c (macro_bcache): Update.
7277         * macroexp.c: Don't include bcache.h.
7278         * gdbtypes.c (check_types_worklist): Update.
7279         (types_deeply_equal): Remove TRY/CATCH.  Update.
7280         * elfread.c (elf_symtab_read): Update.
7281         * dwarf2read.c: Don't include bcache.h.
7282         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7283         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7284         (print_bcache_statistics, bcache_memory_used): Don't declare.
7285         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7286         methods.  Rename all data members.
7287         * bcache.c (struct bcache): Move to bcache.h.
7288         (bcache::expand_hash_table): Rename from expand_hash_table.
7289         (bcache): Remove.
7290         (bcache::insert): Rename from bcache_full.
7291         (bcache::compare): Rename from bcache_compare.
7292         (bcache_xmalloc): Remove.
7293         (bcache::~bcache): Rename from bcache_xfree.
7294         (bcache::print_statistics): Rename from print_bcache_statistics.
7295         (bcache::memory_used): Rename from bcache_memory_used.
7296
7297 2019-03-07  Pedro Alves  <palves@redhat.com>
7298
7299         * infrun.c (normal_stop): Also check for
7300         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7301
7302 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7303
7304         * f-lang.c (value_from_host_double): Moved to...
7305         * value.c (value_from_host_double): ...here.
7306         * value.h (value_from_host_double): Declare.
7307         * guile/scm-math.c (vlscm_convert_typed_number): Use
7308         value_from_host_double.
7309         (vlscm_convert_number): Likewise.
7310         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7311         * python/py-value.c (convert_value_from_python): Likewise.
7312
7313 2019-03-06  Tom Tromey  <tom@tromey.com>
7314
7315         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7316
7317 2019-03-06  Tom Tromey  <tom@tromey.com>
7318
7319         * utils.h (free_current_contents): Don't declare.
7320         * utils.c (free_current_contents): Remove.
7321
7322 2019-03-06  Tom Tromey  <tom@tromey.com>
7323
7324         * top.c (quit_force): Update.
7325         * main.c (captured_command_loop): Update.
7326         * common/new-op.c (operator new): Update.
7327         * common/common-exceptions.c (struct catcher)
7328         <save_cleanup_chain>: Remove member.
7329         (exceptions_state_mc_init): Update.
7330         (exception_try_scope_entry): Return nullptr.
7331         (exception_try_scope_exit, exception_rethrow)
7332         (throw_exception_sjlj, throw_exception_cxx): Update.
7333         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7334         (all_cleanups, do_cleanups, discard_cleanups)
7335         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7336         (restore_cleanups, restore_final_cleanups): Don't declare.
7337         (do_final_cleanups): Remove parameter.
7338         * common/cleanups.c (cleanup_chain, make_cleanup)
7339         (make_cleanup_dtor, all_cleanups, do_cleanups)
7340         (discard_my_cleanups, discard_cleanups)
7341         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7342         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7343         (null_cleanup): Remove.
7344         (do_final_cleanups): Remove parameter.
7345
7346 2019-03-06  Tom Tromey  <tom@tromey.com>
7347
7348         * remote.c (remote_target::remote_parse_stop_reply): Use
7349         unique_xmalloc_ptr.
7350
7351 2019-03-06  Tom Tromey  <tom@tromey.com>
7352
7353         * stabsread.c (struct stabs_field_info): Rename from field_info.
7354         <list, fnlist>: Add initializers.
7355         <obstack>: New member.
7356         (read_member_functions, read_struct_fields, read_baseclasses):
7357         Allocate on obstack.  Don't use cleanups.
7358         (read_one_struct_field, read_member_functions, read_struct_fields)
7359         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7360         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7361         (read_struct_type): Update.
7362
7363 2019-03-06  Tom Tromey  <tom@tromey.com>
7364
7365         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7366         * common/filestuff.h (make_cleanup_close): Don't declare.
7367         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7368         Remove.
7369
7370 2019-03-06  Tom Tromey  <tom@tromey.com>
7371
7372         * solib-aix.c: Use make_scope_exit.
7373
7374 2019-03-06  Tom Tromey  <tom@tromey.com>
7375
7376         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7377         Use make_scope_exit.
7378
7379 2019-03-06  Tom Tromey  <tom@tromey.com>
7380
7381         * solib-svr4.c (disable_probes_interface): Remove parameter.
7382         (svr4_handle_solib_event): Use make_scope_exit.
7383
7384 2019-03-06  Tom Tromey  <tom@tromey.com>
7385
7386         * remote.c (struct stop_reply_deleter): Remove.
7387         (stop_reply_up): Update.
7388         (struct stop_reply): Derive from notif_event.  Don't typedef.
7389         <regcache>: Now a std::vector.
7390         (stop_reply_xfree): Remove.
7391         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7392         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7393         (remote_target::discard_pending_stop_replies): Use delete.
7394         (remote_target::remote_parse_stop_reply): Update.
7395         (remote_target::process_stop_reply): Update.
7396         * remote-notif.h (struct notif_event): Add virtual destructor.
7397         Remove "dtr" member.
7398         (struct notif_client) <alloc_event>: Return a unique_ptr.
7399         (notif_event_xfree): Don't declare.
7400         (notif_event_up): New typedef.
7401         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7402         (notif_event_xfree, do_notif_event_xfree): Remove.
7403         (remote_notif_state_xfree): Update.
7404
7405 2019-03-06  Tom Tromey  <tom@tromey.com>
7406
7407         * infrun.c (displaced_step_clear_cleanup): Now a
7408         forward_scope_exit type.
7409         (displaced_step_prepare_throw): Update.
7410         (displaced_step_fixup): Update.
7411
7412 2019-03-06  Tom Tromey  <tom@tromey.com>
7413
7414         * inferior.h (class inferior): Update comment.
7415         * gdbthread.h (class thread_info): Update comment.
7416
7417 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7418             Tom Tromey  <tom@tromey.com>
7419
7420         * stabsread.h (struct stab_section_list): Remove.
7421         (coffstab_build_psymtabs): Update.
7422         * dbxread.c (symbuf_sections): Now a std::vector.
7423         (sect_idx): New global.
7424         (fill_symbuf): Update.
7425         (coffstab_build_psymtabs): Change type of stabsects parameter.
7426         Update.
7427         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7428         std::vector.
7429         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7430         (coff_locate_sections): Update.
7431         (coff_symfile_read): Remove cleanups.  Update.
7432         (init_stringtab): Add storage parameter.
7433         (free_stringtab, free_stringtab_cleanup): Remove.
7434         (init_lineno): Add storage parameter.
7435         (free_linetab, free_linetab_cleanup): Remove.
7436
7437 2019-03-06  Pedro Alves  <palves@redhat.com>
7438
7439         * linux-fork.c (fork_info::clobber_regs): Delete.
7440         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7441         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7442         comment.  Adjust.
7443         (scoped_switch_fork_info::scoped_switch_fork_info)
7444         (checkpoint_command, linux_fork_context): Adjust
7445         fork_save_infrun_state calls.
7446
7447 2019-03-06  Pedro Alves  <palves@redhat.com>
7448
7449         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7450         (inf_has_multiple_threads): Return 'bool' and rewrite using
7451         inferior_info::threads().
7452
7453 2019-03-06  Pedro Alves  <palves@redhat.com>
7454
7455         * linux-fork.c: Include <list>.
7456         (fork_list): Now a std::list instance.
7457         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7458         (forks_exist_p, find_last_fork): Adjust.
7459         (new_fork): Delete.
7460         (one_fork_p): New.
7461         (add_fork): Adjust.
7462         (free_fork): Delete, folded into fork_info::~fork_info().
7463         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7464         Adjust.
7465         (init_fork_list): Delete.
7466         (linux_fork_killall, linux_fork_mourn_inferior)
7467         (linux_fork_detach, info_checkpoints_command): Adjust.
7468         (_initialize_linux_fork): No longer call init_fork_list.
7469
7470 2019-03-06  Pedro Alves  <palves@redhat.com>
7471
7472         * linux-fork.c (new_fork): New, split out of ...
7473         (add_fork): ... this.  Return void.  Move "first fork" special
7474         case from here, to ...
7475         (checkpoint_command): ... here.
7476         * linux-linux.h (add_fork): Return void.
7477
7478 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7479
7480         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7481
7482 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7483             Chris January  <chris.january@arm.com>
7484             David Lecomber  <david.lecomber@arm.com>
7485
7486         * f-exp.y: New token, UNOP_INTRINSIC.
7487         (exp): New pattern using UNOP_INTRINSIC token.
7488         (f77_keywords): Add 'abs' keyword.
7489         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7490         (value_from_host_double): New function.
7491         (evaluate_subexp_f): Support UNOP_ABS.
7492
7493 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7494
7495         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7496         types.
7497
7498 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7499
7500         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7501         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7502         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7503
7504 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7505
7506         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7507
7508 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7509             Chris January  <chris.january@arm.com>
7510
7511         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7512         * f-exp.y: Define 'KIND' token.
7513         (exp): New pattern for KIND expressions.
7514         (ptype): Handle types with a kind extension.
7515         (direct_abs_decl): Extend to spot kind extensions.
7516         (f77_keywords): Add 'kind' to the list.
7517         (push_kind_type): New function.
7518         (convert_to_kind_type): New function.
7519         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7520         * parse.c (operator_length_standard): Likewise.
7521         * parser-defs.h (enum type_pieces): Add tp_kind.
7522         * std-operator.def: Add UNOP_KIND.
7523
7524 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7525
7526         * f-exp.y (f_parse): Set yydebug.
7527
7528 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7529
7530         * f-lang.c (evaluate_subexp_f): New function.
7531         (exp_descriptor_f): New global.
7532         (f_language_defn): Use exp_descriptor_f instead of
7533         exp_descriptor_standard.
7534
7535 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7536
7537         * f-exp.y (struct token): Add comments.
7538         (dot_ops): Remove uppercase versions and the end marker.
7539         (f77_keywords): Likewise.
7540         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7541         entries in the dot_ops array are case insensitive, and use
7542         strncasecmp to compare strings.  Also some whitespace cleanup in
7543         this area.  Similar for the f77_keywords array, except entries in
7544         this list might be case sensitive.
7545
7546 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7547
7548         * f-exp.y (struct f77_boolean_val): Add comments.
7549         (boolean_values): Remove uppercase versions, and end marker.
7550         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7551         and use strncasecmp to achieve case insensitivity.  Additionally,
7552         perform whitespace cleanup around this code.
7553
7554 2019-03-06  Tom Tromey  <tromey@adacore.com>
7555
7556         * remote-sim.c (gdbsim_target_open): Use result of
7557         gdb_argv::release.
7558
7559 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7560         Dirk Schubert  <dirk.schubert@arm.com>
7561         Chris January  <chris.january@arm.com>
7562
7563         * eval.c (evaluate_subexp_standard): Call Fortran argument
7564         wrapping logic.
7565         * f-lang.c (struct value): A value which can be passed into a
7566         Fortran function call.
7567         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7568         where appropriate.
7569         (struct type): Value ready for a Fortran function call.
7570         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7571         is needed.
7572         * f-lang.h (fortran_argument_convert): Declaration.
7573         (fortran_preserve_arg_pointer): Declaration.
7574         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7575
7576 2019-03-05  Tom Tromey  <tromey@adacore.com>
7577
7578         * python/py-prettyprint.c (print_string_repr): Remove #if.
7579         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7580
7581 2019-03-05  Tom Tromey  <tromey@adacore.com>
7582
7583         * target.c (the_dummy_target): Move later.  Change type to
7584         "dummy_target".
7585         (initialize_targets): Don't initialize the_dummy_target.
7586
7587 2019-03-05  Tom Tromey  <tromey@adacore.com>
7588
7589         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7590         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7591
7592 2019-03-05  Tom Tromey  <tromey@adacore.com>
7593
7594         * windows-nat.c (windows_nat_target::attach)
7595         (windows_nat_target::detach): Don't call gdb_flush.
7596         * valprint.c (generic_val_print, val_print, val_print_string):
7597         Don't call gdb_flush.
7598         * utils.c (defaulted_query): Don't call gdb_flush.
7599         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7600         * target.c (target_announce_detach): Don't call gdb_flush.
7601         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7602         * remote.c (extended_remote_target::attach): Don't call
7603         gdb_flush.
7604         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7605         * printcmd.c (do_examine): Don't call gdb_flush.
7606         (info_display_command): Don't call gdb_flush.
7607         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7608         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7609         * memattr.c (info_mem_command): Don't call gdb_flush.
7610         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7611         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7612         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7613         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7614         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7615         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7616         (gnu_nat_target::detach): Don't call gdb_flush.
7617         * f-valprint.c (f_val_print): Don't call gdb_flush.
7618         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7619         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7620         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7621         gdb_flush.
7622         * c-valprint.c (c_val_print): Don't call gdb_flush.
7623         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7624
7625 2019-03-05  Tom Tromey  <tromey@adacore.com>
7626
7627         * varobj.c (update_dynamic_varobj_children): Update.
7628         (install_default_visualizer): Use reset, not release.
7629         * value.c (set_internalvar): Update.
7630         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7631         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7632         ATTRIBUTE_UNUSED_RESULT.
7633
7634 2019-03-05  Tom Tromey  <tromey@adacore.com>
7635
7636         * remote.c (class scoped_remote_fd) <release>: Add
7637         ATTRIBUTE_UNUSED_RESULT.
7638
7639 2019-03-05  Tom Tromey  <tromey@adacore.com>
7640
7641         * macroexp.c (struct macro_buffer) <release>: Add
7642         ATTRIBUTE_UNUSED_RESULT.
7643
7644 2019-03-05  Tom Tromey  <tromey@adacore.com>
7645
7646         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7647         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7648         ATTRIBUTE_UNUSED_RESULT.
7649
7650 2019-03-05  Tom Tromey  <tromey@adacore.com>
7651
7652         * common/scoped_fd.h (class scoped_fd) <release>: Add
7653         ATTRIBUTE_UNUSED_RESULT.
7654
7655 2019-03-05  Tom Tromey  <tromey@adacore.com>
7656
7657         * parser-defs.h (struct parser_state) <release>: Add
7658         ATTRIBUTE_UNUSED_RESULT.
7659
7660 2019-03-05  Tom Tromey  <tromey@adacore.com>
7661
7662         * utils.h (class gdb_argv) <release>: Add
7663         ATTRIBUTE_UNUSED_RESULT.
7664         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7665
7666 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7667
7668         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7669         for-loop range, to avoid compiler warnings.
7670
7671         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7672         avoid compiler warnings about unused variables.
7673
7674         * NEWS: Mention end of support for native debugging on MS-Windows
7675         before XP.
7676
7677         PR gdb/24292
7678         * common/netstuff.c:
7679         * gdbserver/gdbreplay.c
7680         * gdbserver/remote-utils.c:
7681         * ser-tcp.c:
7682         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7683         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7684         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7685         'getaddrinfo' and 'freeaddrinfo' were not available before
7686         Windows XP, and mingw.org's MinGW headers by default define
7687         _WIN32_WINNT to 0x500.
7688
7689 2019-03-01  Gary Benson <gbenson@redhat.com>
7690
7691         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7692
7693 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7694             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7695
7696         PR gdb/8527
7697         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7698         set_sigint_trap, clear_sigint_trap.
7699
7700 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7701
7702         * target.c (target_detach): Clear the regcache and the
7703         frame cache.
7704
7705 2019-02-27  Pedro Alves  <palves@redhat.com>
7706
7707         * utils.c (set_screen_size): When we cap the height/width sizes,
7708         tweak the corresponding command variable to show "unlimited":
7709
7710 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7711             Pedro Alves  <palves@redhat.com>
7712
7713         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7714         before calling rl_set_screen_size.
7715
7716 2019-02-27  Tom Tromey  <tromey@adacore.com>
7717
7718         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7719         define.
7720         * python/py-value.c: Remove Python 2.4 workaround.
7721         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7722         workaround.
7723         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7724         Python 2.4 workaround.
7725         * python/python-internal.h: Remove Python 2.4 comment.
7726         (Py_ssize_t): Don't define.
7727         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7728         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7729         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7730         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7731         * python/python.c (do_start_initialization): Remove Python 2.4
7732         workaround.
7733         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7734         (print_children): Remove Python 2.4 workaround.
7735         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7736         workaround.
7737         (CHARBUFFERPROC_NAME): Remove.
7738         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7739         Python 2.4 workaround.
7740
7741 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7742
7743         * NEWS: Note minimum Python version.
7744
7745 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7746
7747         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7748         code from these functions.  Remove corresponding ifdefs.  Use
7749         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7750         Remove gotos and target of gotos.
7751         (infpy_search_memory): Likewise.
7752
7753 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7754
7755         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7756         (hppa_gdbarch_init): Don't register deleted functions with
7757         gdbarch.
7758
7759 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7760
7761         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7762         (h8300_unwind_sp): Delete.
7763         (h8300_dummy_id): Delete.
7764         (h8300_gdbarch_init): Don't register deleted functions with
7765         gdbarch.
7766
7767 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7768
7769         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7770         (ft32_unwind_pc): Delete.
7771         (ft32_unwind_sp): Delete.
7772         (ft32_gdbarch_init): Don't register deleted functions with
7773         gdbarch.
7774
7775 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7776
7777         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7778         (frv_unwind_pc): Delete.
7779         (frv_unwind_sp): Delete.
7780         (frv_gdbarch_init): Don't register deleted functions with
7781         gdbarch.
7782
7783 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7784
7785         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7786         (riscv_unwind_pc): Delete.
7787         (riscv_unwind_sp): Delete.
7788         (riscv_gdbarch_init): Don't register deleted functions with
7789         gdbarch.
7790
7791 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7792
7793         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7794         (csky_unwind_pc): Delete.
7795         (csky_unwind_sp): Delete.
7796         (csky_gdbarch_init): Don't register deleted functions with
7797         gdbarch.
7798
7799 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7800
7801         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7802         (cris_unwind_pc): Delete.
7803         (cris_unwind_sp): Delete.
7804         (cris_gdbarch_init): Don't register deleted functions with
7805         gdbarch.
7806
7807 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7808
7809         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7810         (bfin_unwind_pc): Delete.
7811         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7812
7813 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7814
7815         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7816         (arm_unwind_pc): Delete.
7817         (arm_unwind_sp): Delete.
7818         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7819
7820 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7821
7822         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7823         (arc_unwind_pc): Delete.
7824         (arc_unwind_sp): Delete.
7825         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7826
7827 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7828
7829         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7830         (alpha_unwind_pc): Delete.
7831         (alpha_gdbarch_init): Don't register deleted functions with
7832         gdbarch.
7833
7834 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7835
7836         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7837         (aarch64_unwind_pc): Delete.
7838         (aarch64_unwind_sp): Delete.
7839         (aarch64_gdbarch_init): Don't register deleted functions with
7840         gdbarch.
7841
7842 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7843
7844         * gdbtypes.c (type_align): Don't consider static members when
7845         computing structure alignment.
7846
7847 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7848
7849         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7850         return 0 for other types.
7851         * arch-utils.c (default_type_align): Always return 0.
7852         * gdbarch.h: Regenerate.
7853         * gdbarch.sh (type_align): Extend comment.
7854         * gdbtypes.c (type_align): Add additional comments, always call
7855         gdbarch_type_align before applying the default rules.
7856         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7857         generic code will then apply a suitable default.
7858         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7859         types, return 0 for other types.
7860
7861 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7862
7863         * NEWS: Create a new section for the next release branch.
7864         Rename the section of the current branch, now that it has
7865         been cut.
7866
7867 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7868
7869         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7870         * version.in: Bump version to 8.3.50.DATE-git.
7871
7872 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7873
7874         * aix-thread.c (ptid_cmp): Remove unused variable.
7875         (get_signaled_thread): Likewise.
7876         (store_regs_user_thread): Likewise.
7877         (store_regs_kernel_thread): Likewise.
7878         (fetch_regs_kernel_thread): Remove shadowed variable.
7879
7880 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7881
7882         * features/riscv/32bit-cpu.xml: Add register numbers.
7883         * features/riscv/32bit-fpu.c: Regenerate.
7884         * features/riscv/32bit-fpu.xml: Add register numbers.
7885         * features/riscv/64bit-cpu.xml: Add register numbers.
7886         * features/riscv/64bit-fpu.c: Regenerate.
7887         * features/riscv/64bit-fpu.xml: Add register numbers.
7888
7889 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7890
7891         * NEWS: Mention two argument form of gdb.Value constructor.
7892         * python/py-value.c (convert_buffer_and_type_to_value): New
7893         function.
7894         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7895         Add support for handling an optional second argument.  Call
7896         convert_buffer_and_type_to_value as appropriate.
7897         * python/python-internal.h (Py_buffer_deleter): New struct.
7898         (Py_buffer_up): New typedef.
7899
7900 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7901
7902         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7903         instead of releasing ownership.
7904
7905 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7906
7907         * dwarf2read.c (open_and_init_dwp_file): Call
7908         elf_numsections instead of bfd_count_sections to initialize
7909         dwp_file->num_sections.
7910
7911 2019-02-25  Tom Tromey  <tromey@adacore.com>
7912
7913         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7914
7915 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7916
7917         * gcore.in: Add '--readnever' option when invoking GDB.
7918
7919 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7920
7921         * MAINTAINERS: Update my email address.
7922
7923 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7924
7925         * build-id.c (build_id_to_debug_bfd_1): New function.
7926         (build_id_to_debug_bfd): Look for separate debug file in
7927         sysroot.
7928
7929 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7930
7931         * gdbarch.sh: Update the copyright year range that is placed into
7932         generated files.
7933
7934 2019-02-22  Keith Seitz  <keiths@redhat.com>
7935
7936         PR symtab/23853
7937         * linespec.c (create_sals_line_offset): Search for the default
7938         symtab's filename instead of its fullname.
7939
7940 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7941
7942         * NEWS: Update style defaults.
7943
7944 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7945
7946         * main.c (captured_main_1): Disable styling in batch mode.
7947
7948 2019-02-20  Tom Tromey  <tom@tromey.com>
7949
7950         * symtab.c (symtab_symbol_info): Fix typos.
7951
7952 2019-02-20  Tom Tromey  <tromey@adacore.com>
7953
7954         * findcmd.c (_initialize_mem_search): Use upper case for
7955         metasyntactic variables.
7956
7957 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7958
7959         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7960         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7961
7962 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7963
7964         * top.h (source_file_name): Change to std::string.
7965         * top.c (source_file_name): Likewise.
7966         (command_line_input): Adjust.
7967         * cli/cli-script.c (script_from_file): Adjust.
7968
7969 2019-02-19  Tom Tromey  <tromey@adacore.com>
7970
7971         * ravenscar-thread.c
7972         (ravenscar_thread_target::update_thread_list): Don't call
7973         ada_build_task_list.
7974         * ada-lang.h (ada_build_task_list): Don't declare.
7975         * ada-tasks.c (struct ada_tasks_inferior_data)
7976         <task_list_valid_p>: Now bool.
7977         (read_known_tasks, ada_task_list_changed)
7978         (ada_tasks_invalidate_inferior_data): Update.
7979         (read_known_tasks_array): Return bool.
7980         (read_known_tasks_list): Likewise.
7981         (read_known_tasks): Return void.
7982         (ada_build_task_list): Now static.
7983
7984 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7985
7986         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7987         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7988
7989 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7990
7991         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7992         variant for ada_tasks_pspace_data_handle and
7993         ada_tasks_inferior_data_handle.
7994         (ada_tasks_pspace_data_cleanup): New function.
7995         (ada_tasks_inferior_data_cleanup): New function.
7996
7997 2019-02-17  Tom Tromey  <tom@tromey.com>
7998
7999         * macrotab.h (macro_source_fullname): Return a std::string.
8000         * macrotab.c (macro_include, check_for_redefinition)
8001         (macro_undef, macro_lookup_definition, foreach_macro)
8002         (foreach_macro_in_scope): Update.
8003         (macro_source_fullname): Return a std::string.
8004         * macrocmd.c (show_pp_source_pos): Update.
8005
8006 2019-02-17  Tom Tromey  <tom@tromey.com>
8007
8008         * macrocmd.c (show_pp_source_pos): Style the file names.
8009
8010 2019-02-17  Tom Tromey  <tom@tromey.com>
8011
8012         PR tui/24197:
8013         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8014
8015 2019-02-17  Tom Tromey  <tom@tromey.com>
8016
8017         * ada-lang.c (user_select_syms): Use filtered printing.
8018         * utils.c (wrap_style): New global.
8019         (desired_style): Remove.
8020         (emit_style_escape): Add stream parameter.
8021         (set_output_style, reset_terminal_style, prompt_for_continue):
8022         Update.
8023         (flush_wrap_buffer): Only flush gdb_stdout.
8024         (wrap_here): Set wrap_style.
8025         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8026         treat escape sequences as a character.  Change when wrap buffer is
8027         flushed.
8028         (fputs_styled): Do not set the output style when the default is
8029         requested.
8030         * ui-style.h (struct ui_file_style) <is_default>: New method.
8031         * source.c (print_source_lines_base): Emit escape sequences in one
8032         piece.
8033
8034 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8035
8036         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8037         integers and enumeration types.
8038
8039 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8040
8041         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8042         instead of lookup_symbol_in_language
8043         (do_exact_match): New function.
8044         (ada_get_symbol_name_matcher): Return do_exact_match when
8045         doing a verbatim match.
8046
8047 2019-02-15  Tom Tromey  <tromey@adacore.com>
8048
8049         * ravenscar-thread.c (ravenscar_thread_target::resume)
8050         (ravenscar_thread_target::wait): Special case wildcard requests.
8051
8052 2019-02-15  Tom Tromey  <tromey@adacore.com>
8053
8054         * ravenscar-thread.c (base_ptid): Remove.
8055         (struct ravenscar_thread_target) <close>: New method.
8056         <m_base_ptid>: New member.
8057         <update_inferior_ptid, active_task, task_is_currently_active,
8058         runtime_initialized>: Declare methods.
8059         <ravenscar_thread_target>: Add constructor.
8060         (ravenscar_thread_target::task_is_currently_active)
8061         (ravenscar_thread_target::update_inferior_ptid)
8062         (ravenscar_runtime_initialized): Rename.  Now methods.
8063         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8064         (ravenscar_thread_target::update_thread_list): Update.
8065         (ravenscar_thread_target::active_task): Now method.
8066         (ravenscar_thread_target::store_registers)
8067         (ravenscar_thread_target::prepare_to_store)
8068         (ravenscar_thread_target::prepare_to_store)
8069         (ravenscar_thread_target::mourn_inferior): Update.
8070         (ravenscar_inferior_created): Use "new" to create target.
8071         (ravenscar_thread_target::get_ada_task_ptid): Update.
8072         (_initialize_ravenscar): Don't initialize base_ptid.
8073         (ravenscar_ops): Remove global.
8074
8075 2019-02-15  Tom Tromey  <tromey@adacore.com>
8076
8077         * target.h (push_target): Declare new overload.
8078         * target.c (push_target): New overload, taking an rvalue reference.
8079         * remote.c (remote_target::open_1): Use push_target overload.
8080         * corelow.c (core_target_open): Use push_target overload.
8081
8082 2019-02-15  Tom Tromey  <tromey@adacore.com>
8083
8084         * ravenscar-thread.c (is_ravenscar_task)
8085         (ravenscar_task_is_currently_active): Return bool.
8086         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8087         (_initialize_ravenscar): Remove "(void)".
8088         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8089         Return bool.
8090
8091 2019-02-15  Tom Tromey  <tromey@adacore.com>
8092
8093         * ravenscar-thread.c (ravenscar_runtime_initializer)
8094         (has_ravenscar_runtime, get_running_thread_id)
8095         (ravenscar_thread_target::resume): Fix indentation.
8096
8097 2019-02-15  Tom Tromey  <tromey@adacore.com>
8098
8099         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8100         from ravenscar_arch_ops.
8101         (sparc_ravenscar_ops::fetch_registers)
8102         (sparc_ravenscar_ops::store_registers): Now methods.
8103         (sparc_ravenscar_prepare_to_store): Remove.
8104         (sparc_ravenscar_ops): Redefine.
8105         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8106         methods and destructor.  Remove members.
8107         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8108         (ravenscar_thread_target::store_registers)
8109         (ravenscar_thread_target::prepare_to_store): Update.
8110         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8111         Remove.
8112         (struct ppc_ravenscar_powerpc_ops): Derive from
8113         ravenscar_arch_ops.
8114         (ppc_ravenscar_powerpc_ops::fetch_registers)
8115         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8116         (ppc_ravenscar_powerpc_ops): Redefine.
8117         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8118         (ppc_ravenscar_e500_ops::fetch_registers)
8119         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8120         (ppc_ravenscar_e500_ops): Redefine.
8121         * aarch64-ravenscar-thread.c
8122         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8123         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8124         (aarch64_ravenscar_fetch_registers)
8125         (aarch64_ravenscar_store_registers): Now methods.
8126         (aarch64_ravenscar_ops): Redefine.
8127
8128 2019-02-15  Tom Tromey  <tromey@adacore.com>
8129
8130         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8131         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8132         (ravenscar_thread_target::stopped_by_watchpoint)
8133         (ravenscar_thread_target::stopped_data_address)
8134         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8135
8136 2019-02-15  Tom Tromey  <tromey@adacore.com>
8137
8138         * ravenscar-thread.c: Fix some typos.
8139
8140 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8141             Tom Tromey  <tromey@adacore.com>
8142
8143         * ada-lang.c (ada_exception_sal): Change addr_string to a
8144         std::string.
8145         (create_ada_exception_catchpoint): Update.
8146
8147 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8148             Tom Tromey  <tromey@adacore.com>
8149
8150         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8151         (bp_location_ops): Remove.
8152         (base_breakpoint_allocate_location): Update.
8153         (free_bp_location): Update.
8154         * ada-lang.c (class ada_catchpoint_location)
8155         <ada_catchpoint_location>: Remove ops parameter.
8156         (ada_catchpoint_location_dtor): Remove.
8157         (ada_catchpoint_location_ops): Remove.
8158         (allocate_location_exception): Update.
8159         * breakpoint.h (struct bp_location_ops): Remove.
8160         (class bp_location) <bp_location>: Remove bp_location_ops
8161         parameter.
8162         <~bp_location>: Add destructor.
8163         <ops>: Remove.
8164
8165 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8166             Pedro Alves  <palves@redhat.com>
8167
8168         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8169         'PATH_MAX'.
8170
8171 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8172             Samuel Thibault  <samuel.thibault@gnu.org>
8173             Thomas Schwinge  <thomas@codesourcery.com>
8174
8175         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8176         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8177
8178 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8179
8180         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8181         (check_empty): Use "const char *".
8182
8183         * gnu-nat.c (gnu_nat_target::detach): Instead of
8184         'detach_inferior (pid)' call
8185         'detach_inferior (find_inferior_pid (pid))'.
8186
8187         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8188         'nat/fork-inferior.o'.
8189         * gnu-nat.c: #include "nat/fork-inferior.h".
8190
8191         * gnu-nat.c (gnu_nat_target::detach): Instead of
8192         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8193         * gnu-nat.h: #include "inf-child.h".
8194         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8195         'i386_gnu_nat_target::fetch_registers'.
8196         (gnu_store_registers): Rename/move to
8197         'i386_gnu_nat_target::store_registers'.
8198
8199         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8200         * gnu-nat.h (mach_thread_info): New function.
8201         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8202
8203         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8204
8205 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8206
8207         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8208
8209 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8210
8211         * windows-nat.c (windows_add_thread): Add new parameter
8212         "main_thread_p" with default value set to false.  Update
8213         function documentation as well as all callers.
8214         (windows_delete_thread): Likewise.
8215         (fake_create_process): Update call to windows_add_thread.
8216         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8217         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8218         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8219         call to windows_delete_thread.
8220
8221 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8222
8223         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8224
8225 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8226
8227         * symfile.c (find_separate_debug_file): Use canonical path of
8228         sysroot with child_path instead of gdb_sysroot if it is valid.
8229
8230 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8231
8232         * symfile.c (find_separate_debug_file): Use child_path to
8233         determine if an object file is under a sysroot.
8234
8235 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8236
8237         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8238         unittests/child-path-selftests.c.
8239         * common/pathstuff.c (child_path): New function.
8240         * common/pathstuff.h (child_path): New prototype.
8241         * unittests/child-path-selftests.c: New file.
8242
8243 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8244
8245         * symfile.c (find_separate_debug_file): Look for separate debug
8246         files in debug directories under the sysroot.
8247
8248 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8249
8250         * symtab.h (struct minimal_symbol data_p): New const method.
8251         (struct minimal_symbol text_p): Likewise.
8252         * symtab.c (output_source_filename): Use file name style
8253         to print file name.
8254         (print_symbol_info): Likewise.
8255         (print_msymbol_info): Use address style to print addresses.
8256         Use function name style to print executable text symbols.
8257         (expand_symtab_containing_pc): Use data_p.
8258         (find_pc_sect_compunit_symtab): Likewise.
8259
8260 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8261
8262         * breakpoint.c (describe_other_breakpoints): Use address style
8263         to print addresses.
8264         (say_where): Likewise.
8265
8266 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8267
8268         * ada-typeprint.c (print_func_type): Print function name
8269         style to print function name.
8270         * c-typeprint.c (c_print_type_1): Likewise.
8271
8272 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8273
8274         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8275         for execve.
8276
8277 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8278
8279         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8280         type_stack.
8281
8282 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8283
8284         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8285         TYPE_CODE_REF types.
8286
8287 2019-02-08  Jim Wilson  <jimw@sifive.com>
8288
8289         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8290         (riscv_linux_fregset): New.
8291         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8292
8293 2019-02-07  Tom Tromey  <tom@tromey.com>
8294
8295         * thread.c (thread_cancel_execution_command): Update.
8296         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8297         methods.
8298         (struct thread_fsm_ops): Remove.
8299         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8300         (thread_fsm_should_stop, thread_fsm_return_value)
8301         (thread_fsm_set_finished, thread_fsm_finished_p)
8302         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8303         Don't declare.
8304         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8305         * infrun.c (clear_proceed_status_thread)
8306         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8307         (print_stop_event): Update.
8308         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8309         Add constructor.
8310         (step_command_fsm_ops): Remove.
8311         (new_step_command_fsm): Remove.
8312         (step_1): Update.
8313         (step_command_fsm::should_stop): Rename from
8314         step_command_fsm_should_stop.
8315         (step_command_fsm::clean_up): Rename from
8316         step_command_fsm_clean_up.
8317         (step_command_fsm::do_async_reply_reason): Rename from
8318         step_command_fsm_async_reply_reason.
8319         (struct until_next_fsm): Inherit from thread_fsm.  Add
8320         constructor.
8321         (until_next_fsm_ops): Remove.
8322         (new_until_next_fsm): Remove.
8323         (until_next_fsm::should_stop): Rename from
8324         until_next_fsm_should_stop.
8325         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8326         (until_next_fsm::do_async_reply_reason): Rename from
8327         until_next_fsm_async_reply_reason.
8328         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8329         constructor.  Change type of breakpoint.
8330         (finish_command_fsm_ops): Remove.
8331         (new_finish_command_fsm): Remove.
8332         (finish_command_fsm::should_stop): Rename from
8333         finish_command_fsm_should_stop.
8334         (finish_command_fsm::clean_up): Rename from
8335         finish_command_fsm_clean_up.
8336         (finish_command_fsm::return_value): Rename from
8337         finish_command_fsm_return_value.
8338         (finish_command_fsm::do_async_reply_reason): Rename from
8339         finish_command_fsm_async_reply_reason.
8340         (finish_command): Update.
8341         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8342         Add constructor.
8343         (call_thread_fsm_ops): Remove.
8344         (call_thread_fsm::call_thread_fsm): Rename from
8345         new_call_thread_fsm.
8346         (call_thread_fsm::should_stop): Rename from
8347         call_thread_fsm_should_stop.
8348         (call_thread_fsm::should_notify_stop): Rename from
8349         call_thread_fsm_should_notify_stop.
8350         (run_inferior_call, call_function_by_hand_dummy): Update.
8351         * cli/cli-interp.c (should_print_stop_to_console): Update.
8352         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8353         Add constructor.  Change type of location_breakpoint,
8354         caller_breakpoint.
8355         (until_break_fsm_ops): Remove.
8356         (new_until_break_fsm): Remove.
8357         (until_break_fsm::should_stop): Rename from
8358         until_break_fsm_should_stop.
8359         (until_break_fsm::clean_up): Rename from
8360         until_break_fsm_clean_up.
8361         (until_break_fsm::do_async_reply_reason): Rename from
8362         until_break_fsm_async_reply_reason.
8363         (until_break_command): Update.
8364         * thread-fsm.c: Remove.
8365         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8366
8367 2019-02-07  Tom Tromey  <tom@tromey.com>
8368
8369         * yy-remap.h: Add include guard.
8370         * xtensa-tdep.h: Add include guard.
8371         * xcoffread.h: Rename include guard.
8372         * varobj-iter.h: Add include guard.
8373         * tui/tui.h: Rename include guard.
8374         * tui/tui-winsource.h: Rename include guard.
8375         * tui/tui-wingeneral.h: Rename include guard.
8376         * tui/tui-windata.h: Rename include guard.
8377         * tui/tui-win.h: Rename include guard.
8378         * tui/tui-stack.h: Rename include guard.
8379         * tui/tui-source.h: Rename include guard.
8380         * tui/tui-regs.h: Rename include guard.
8381         * tui/tui-out.h: Rename include guard.
8382         * tui/tui-layout.h: Rename include guard.
8383         * tui/tui-io.h: Rename include guard.
8384         * tui/tui-hooks.h: Rename include guard.
8385         * tui/tui-file.h: Rename include guard.
8386         * tui/tui-disasm.h: Rename include guard.
8387         * tui/tui-data.h: Rename include guard.
8388         * tui/tui-command.h: Rename include guard.
8389         * tic6x-tdep.h: Add include guard.
8390         * target/waitstatus.h: Rename include guard.
8391         * target/wait.h: Rename include guard.
8392         * target/target.h: Rename include guard.
8393         * target/resume.h: Rename include guard.
8394         * target-float.h: Rename include guard.
8395         * stabsread.h: Add include guard.
8396         * rs6000-tdep.h: Add include guard.
8397         * riscv-fbsd-tdep.h: Add include guard.
8398         * regformats/regdef.h: Rename include guard.
8399         * record.h: Rename include guard.
8400         * python/python.h: Rename include guard.
8401         * python/python-internal.h: Rename include guard.
8402         * python/py-stopevent.h: Rename include guard.
8403         * python/py-ref.h: Rename include guard.
8404         * python/py-record.h: Rename include guard.
8405         * python/py-record-full.h: Rename include guard.
8406         * python/py-record-btrace.h: Rename include guard.
8407         * python/py-instruction.h: Rename include guard.
8408         * python/py-events.h: Rename include guard.
8409         * python/py-event.h: Rename include guard.
8410         * procfs.h: Add include guard.
8411         * proc-utils.h: Add include guard.
8412         * p-lang.h: Add include guard.
8413         * or1k-tdep.h: Rename include guard.
8414         * observable.h: Rename include guard.
8415         * nto-tdep.h: Rename include guard.
8416         * nat/x86-linux.h: Rename include guard.
8417         * nat/x86-linux-dregs.h: Rename include guard.
8418         * nat/x86-gcc-cpuid.h: Add include guard.
8419         * nat/x86-dregs.h: Rename include guard.
8420         * nat/x86-cpuid.h: Rename include guard.
8421         * nat/ppc-linux.h: Rename include guard.
8422         * nat/mips-linux-watch.h: Rename include guard.
8423         * nat/linux-waitpid.h: Rename include guard.
8424         * nat/linux-ptrace.h: Rename include guard.
8425         * nat/linux-procfs.h: Rename include guard.
8426         * nat/linux-osdata.h: Rename include guard.
8427         * nat/linux-nat.h: Rename include guard.
8428         * nat/linux-namespaces.h: Rename include guard.
8429         * nat/linux-btrace.h: Rename include guard.
8430         * nat/glibc_thread_db.h: Rename include guard.
8431         * nat/gdb_thread_db.h: Rename include guard.
8432         * nat/gdb_ptrace.h: Rename include guard.
8433         * nat/fork-inferior.h: Rename include guard.
8434         * nat/amd64-linux-siginfo.h: Rename include guard.
8435         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8436         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8437         * nat/aarch64-linux.h: Rename include guard.
8438         * nat/aarch64-linux-hw-point.h: Rename include guard.
8439         * mn10300-tdep.h: Add include guard.
8440         * mips-linux-tdep.h: Add include guard.
8441         * mi/mi-parse.h: Rename include guard.
8442         * mi/mi-out.h: Rename include guard.
8443         * mi/mi-main.h: Rename include guard.
8444         * mi/mi-interp.h: Rename include guard.
8445         * mi/mi-getopt.h: Rename include guard.
8446         * mi/mi-console.h: Rename include guard.
8447         * mi/mi-common.h: Rename include guard.
8448         * mi/mi-cmds.h: Rename include guard.
8449         * mi/mi-cmd-break.h: Rename include guard.
8450         * m2-lang.h: Add include guard.
8451         * location.h: Rename include guard.
8452         * linux-record.h: Rename include guard.
8453         * linux-nat.h: Add include guard.
8454         * linux-fork.h: Add include guard.
8455         * i386-darwin-tdep.h: Rename include guard.
8456         * hppa-linux-offsets.h: Add include guard.
8457         * guile/guile.h: Rename include guard.
8458         * guile/guile-internal.h: Rename include guard.
8459         * gnu-nat.h: Rename include guard.
8460         * gdb-stabs.h: Rename include guard.
8461         * frv-tdep.h: Add include guard.
8462         * f-lang.h: Add include guard.
8463         * event-loop.h: Add include guard.
8464         * darwin-nat.h: Rename include guard.
8465         * cp-abi.h: Rename include guard.
8466         * config/sparc/nm-sol2.h: Rename include guard.
8467         * config/nm-nto.h: Rename include guard.
8468         * config/nm-linux.h: Add include guard.
8469         * config/i386/nm-i386gnu.h: Rename include guard.
8470         * config/djgpp/nl_types.h: Rename include guard.
8471         * config/djgpp/langinfo.h: Rename include guard.
8472         * compile/gcc-cp-plugin.h: Add include guard.
8473         * compile/gcc-c-plugin.h: Add include guard.
8474         * compile/compile.h: Rename include guard.
8475         * compile/compile-object-run.h: Rename include guard.
8476         * compile/compile-object-load.h: Rename include guard.
8477         * compile/compile-internal.h: Rename include guard.
8478         * compile/compile-cplus.h: Rename include guard.
8479         * compile/compile-c.h: Rename include guard.
8480         * common/xml-utils.h: Rename include guard.
8481         * common/x86-xstate.h: Rename include guard.
8482         * common/version.h: Rename include guard.
8483         * common/vec.h: Rename include guard.
8484         * common/tdesc.h: Rename include guard.
8485         * common/selftest.h: Rename include guard.
8486         * common/scoped_restore.h: Rename include guard.
8487         * common/scoped_mmap.h: Rename include guard.
8488         * common/scoped_fd.h: Rename include guard.
8489         * common/safe-iterator.h: Rename include guard.
8490         * common/run-time-clock.h: Rename include guard.
8491         * common/refcounted-object.h: Rename include guard.
8492         * common/queue.h: Rename include guard.
8493         * common/ptid.h: Rename include guard.
8494         * common/print-utils.h: Rename include guard.
8495         * common/preprocessor.h: Rename include guard.
8496         * common/pathstuff.h: Rename include guard.
8497         * common/observable.h: Rename include guard.
8498         * common/netstuff.h: Rename include guard.
8499         * common/job-control.h: Rename include guard.
8500         * common/host-defs.h: Rename include guard.
8501         * common/gdb_wait.h: Rename include guard.
8502         * common/gdb_vecs.h: Rename include guard.
8503         * common/gdb_unlinker.h: Rename include guard.
8504         * common/gdb_unique_ptr.h: Rename include guard.
8505         * common/gdb_tilde_expand.h: Rename include guard.
8506         * common/gdb_sys_time.h: Rename include guard.
8507         * common/gdb_string_view.h: Rename include guard.
8508         * common/gdb_splay_tree.h: Rename include guard.
8509         * common/gdb_setjmp.h: Rename include guard.
8510         * common/gdb_ref_ptr.h: Rename include guard.
8511         * common/gdb_optional.h: Rename include guard.
8512         * common/gdb_locale.h: Rename include guard.
8513         * common/gdb_assert.h: Rename include guard.
8514         * common/filtered-iterator.h: Rename include guard.
8515         * common/filestuff.h: Rename include guard.
8516         * common/fileio.h: Rename include guard.
8517         * common/environ.h: Rename include guard.
8518         * common/common-utils.h: Rename include guard.
8519         * common/common-types.h: Rename include guard.
8520         * common/common-regcache.h: Rename include guard.
8521         * common/common-inferior.h: Rename include guard.
8522         * common/common-gdbthread.h: Rename include guard.
8523         * common/common-exceptions.h: Rename include guard.
8524         * common/common-defs.h: Rename include guard.
8525         * common/common-debug.h: Rename include guard.
8526         * common/cleanups.h: Rename include guard.
8527         * common/buffer.h: Rename include guard.
8528         * common/btrace-common.h: Rename include guard.
8529         * common/break-common.h: Rename include guard.
8530         * cli/cli-utils.h: Rename include guard.
8531         * cli/cli-style.h: Rename include guard.
8532         * cli/cli-setshow.h: Rename include guard.
8533         * cli/cli-script.h: Rename include guard.
8534         * cli/cli-interp.h: Rename include guard.
8535         * cli/cli-decode.h: Rename include guard.
8536         * cli/cli-cmds.h: Rename include guard.
8537         * charset-list.h: Add include guard.
8538         * buildsym-legacy.h: Rename include guard.
8539         * bfin-tdep.h: Add include guard.
8540         * ax.h: Rename include guard.
8541         * arm-linux-tdep.h: Add include guard.
8542         * arm-fbsd-tdep.h: Add include guard.
8543         * arch/xtensa.h: Rename include guard.
8544         * arch/tic6x.h: Add include guard.
8545         * arch/i386.h: Add include guard.
8546         * arch/arm.h: Rename include guard.
8547         * arch/arm-linux.h: Rename include guard.
8548         * arch/arm-get-next-pcs.h: Rename include guard.
8549         * arch/amd64.h: Add include guard.
8550         * arch/aarch64-insn.h: Rename include guard.
8551         * arch-utils.h: Rename include guard.
8552         * annotate.h: Add include guard.
8553         * amd64-darwin-tdep.h: Rename include guard.
8554         * aarch64-linux-tdep.h: Add include guard.
8555         * aarch64-fbsd-tdep.h: Add include guard.
8556         * aarch32-linux-nat.h: Add include guard.
8557
8558 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8559
8560         * macrotab.c (macro_define_internal): New function that
8561         factorizes macro_define_object_internal and macro_define_function
8562         code.
8563         (macro_define_object_internal): Use macro_define_internal.
8564         (macro_define_function): Likewise.
8565
8566 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8567
8568         * macrocmd.c (extract_identifier): Return
8569         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8570         callers.
8571
8572 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8573
8574         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8575
8576 2019-02-05  Tom Tromey  <tom@tromey.com>
8577
8578         * target.c (target_stack::unpush): Move assertion earlier.
8579
8580 2019-01-30  Tom Tromey  <tom@tromey.com>
8581
8582         PR python/23615:
8583         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8584         (gdbpy_parse_and_eval): Likewise.
8585         * python/python-internal.h (gdbpy_allow_threads): New class.
8586
8587 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8588
8589         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8590         (aarch64_fbsd_fpregmap): Move earlier.
8591         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8592         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8593         instead of individual calls to trad_frame_set_reg_addr.
8594         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8595         earlier.
8596         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8597         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8598         instead of individual calls to trad_frame_set_reg_addr.
8599
8600 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8601
8602         * CONTRIBUTE: Replace contribution list with wiki link.
8603
8604 2019-01-25  Tom Tromey  <tom@tromey.com>
8605
8606         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8607
8608 2019-01-25  Tom Tromey  <tom@tromey.com>
8609
8610         * xtensa-linux-nat.c: Fix common/ includes.
8611         * xml-support.h: Fix common/ includes.
8612         * xml-support.c: Fix common/ includes.
8613         * x86-linux-nat.c: Fix common/ includes.
8614         * windows-nat.c: Fix common/ includes.
8615         * varobj.h: Fix common/ includes.
8616         * varobj.c: Fix common/ includes.
8617         * value.c: Fix common/ includes.
8618         * valops.c: Fix common/ includes.
8619         * utils.c: Fix common/ includes.
8620         * unittests/xml-utils-selftests.c: Fix common/ includes.
8621         * unittests/utils-selftests.c: Fix common/ includes.
8622         * unittests/unpack-selftests.c: Fix common/ includes.
8623         * unittests/tracepoint-selftests.c: Fix common/ includes.
8624         * unittests/style-selftests.c: Fix common/ includes.
8625         * unittests/string_view-selftests.c: Fix common/ includes.
8626         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8627         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8628         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8629         * unittests/rsp-low-selftests.c: Fix common/ includes.
8630         * unittests/parse-connection-spec-selftests.c: Fix common/
8631         includes.
8632         * unittests/optional-selftests.c: Fix common/ includes.
8633         * unittests/offset-type-selftests.c: Fix common/ includes.
8634         * unittests/observable-selftests.c: Fix common/ includes.
8635         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8636         * unittests/memrange-selftests.c: Fix common/ includes.
8637         * unittests/memory-map-selftests.c: Fix common/ includes.
8638         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8639         * unittests/function-view-selftests.c: Fix common/ includes.
8640         * unittests/environ-selftests.c: Fix common/ includes.
8641         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8642         * unittests/common-utils-selftests.c: Fix common/ includes.
8643         * unittests/cli-utils-selftests.c: Fix common/ includes.
8644         * unittests/array-view-selftests.c: Fix common/ includes.
8645         * ui-file.c: Fix common/ includes.
8646         * tui/tui-io.c: Fix common/ includes.
8647         * tracepoint.h: Fix common/ includes.
8648         * tracepoint.c: Fix common/ includes.
8649         * tracefile-tfile.c: Fix common/ includes.
8650         * top.h: Fix common/ includes.
8651         * top.c: Fix common/ includes.
8652         * thread.c: Fix common/ includes.
8653         * target/waitstatus.h: Fix common/ includes.
8654         * target/waitstatus.c: Fix common/ includes.
8655         * target.h: Fix common/ includes.
8656         * target.c: Fix common/ includes.
8657         * target-memory.c: Fix common/ includes.
8658         * target-descriptions.c: Fix common/ includes.
8659         * symtab.h: Fix common/ includes.
8660         * symfile.c: Fix common/ includes.
8661         * stap-probe.c: Fix common/ includes.
8662         * spu-linux-nat.c: Fix common/ includes.
8663         * sparc-nat.c: Fix common/ includes.
8664         * source.c: Fix common/ includes.
8665         * solib.c: Fix common/ includes.
8666         * solib-target.c: Fix common/ includes.
8667         * ser-unix.c: Fix common/ includes.
8668         * ser-tcp.c: Fix common/ includes.
8669         * ser-pipe.c: Fix common/ includes.
8670         * ser-base.c: Fix common/ includes.
8671         * selftest-arch.c: Fix common/ includes.
8672         * s12z-tdep.c: Fix common/ includes.
8673         * rust-exp.y: Fix common/ includes.
8674         * rs6000-aix-tdep.c: Fix common/ includes.
8675         * riscv-tdep.c: Fix common/ includes.
8676         * remote.c: Fix common/ includes.
8677         * remote-notif.h: Fix common/ includes.
8678         * remote-fileio.h: Fix common/ includes.
8679         * remote-fileio.c: Fix common/ includes.
8680         * regcache.h: Fix common/ includes.
8681         * regcache.c: Fix common/ includes.
8682         * record-btrace.c: Fix common/ includes.
8683         * python/python.c: Fix common/ includes.
8684         * python/py-type.c: Fix common/ includes.
8685         * python/py-inferior.c: Fix common/ includes.
8686         * progspace.h: Fix common/ includes.
8687         * producer.c: Fix common/ includes.
8688         * procfs.c: Fix common/ includes.
8689         * proc-api.c: Fix common/ includes.
8690         * printcmd.c: Fix common/ includes.
8691         * ppc-linux-nat.c: Fix common/ includes.
8692         * parser-defs.h: Fix common/ includes.
8693         * osdata.c: Fix common/ includes.
8694         * obsd-nat.c: Fix common/ includes.
8695         * nat/x86-linux.c: Fix common/ includes.
8696         * nat/x86-linux-dregs.c: Fix common/ includes.
8697         * nat/x86-dregs.h: Fix common/ includes.
8698         * nat/x86-dregs.c: Fix common/ includes.
8699         * nat/ppc-linux.c: Fix common/ includes.
8700         * nat/mips-linux-watch.h: Fix common/ includes.
8701         * nat/mips-linux-watch.c: Fix common/ includes.
8702         * nat/linux-waitpid.c: Fix common/ includes.
8703         * nat/linux-ptrace.h: Fix common/ includes.
8704         * nat/linux-ptrace.c: Fix common/ includes.
8705         * nat/linux-procfs.c: Fix common/ includes.
8706         * nat/linux-personality.c: Fix common/ includes.
8707         * nat/linux-osdata.c: Fix common/ includes.
8708         * nat/linux-namespaces.c: Fix common/ includes.
8709         * nat/linux-btrace.h: Fix common/ includes.
8710         * nat/linux-btrace.c: Fix common/ includes.
8711         * nat/fork-inferior.c: Fix common/ includes.
8712         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8713         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8714         * nat/aarch64-linux.c: Fix common/ includes.
8715         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8716         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8717         * namespace.h: Fix common/ includes.
8718         * mips-linux-tdep.c: Fix common/ includes.
8719         * minsyms.c: Fix common/ includes.
8720         * mi/mi-parse.h: Fix common/ includes.
8721         * mi/mi-main.c: Fix common/ includes.
8722         * mi/mi-cmd-env.c: Fix common/ includes.
8723         * memrange.h: Fix common/ includes.
8724         * memattr.c: Fix common/ includes.
8725         * maint.h: Fix common/ includes.
8726         * maint.c: Fix common/ includes.
8727         * main.c: Fix common/ includes.
8728         * machoread.c: Fix common/ includes.
8729         * location.c: Fix common/ includes.
8730         * linux-thread-db.c: Fix common/ includes.
8731         * linux-nat.c: Fix common/ includes.
8732         * linux-fork.c: Fix common/ includes.
8733         * inline-frame.c: Fix common/ includes.
8734         * infrun.c: Fix common/ includes.
8735         * inflow.c: Fix common/ includes.
8736         * inferior.h: Fix common/ includes.
8737         * inferior.c: Fix common/ includes.
8738         * infcmd.c: Fix common/ includes.
8739         * inf-ptrace.c: Fix common/ includes.
8740         * inf-child.c: Fix common/ includes.
8741         * ia64-linux-nat.c: Fix common/ includes.
8742         * i387-tdep.c: Fix common/ includes.
8743         * i386-tdep.c: Fix common/ includes.
8744         * i386-linux-tdep.c: Fix common/ includes.
8745         * i386-linux-nat.c: Fix common/ includes.
8746         * i386-go32-tdep.c: Fix common/ includes.
8747         * i386-fbsd-tdep.c: Fix common/ includes.
8748         * i386-fbsd-nat.c: Fix common/ includes.
8749         * guile/scm-type.c: Fix common/ includes.
8750         * guile/guile.c: Fix common/ includes.
8751         * go32-nat.c: Fix common/ includes.
8752         * gnu-nat.c: Fix common/ includes.
8753         * gdbthread.h: Fix common/ includes.
8754         * gdbarch-selftests.c: Fix common/ includes.
8755         * gdb_usleep.c: Fix common/ includes.
8756         * gdb_select.h: Fix common/ includes.
8757         * gdb_bfd.c: Fix common/ includes.
8758         * gcore.c: Fix common/ includes.
8759         * fork-child.c: Fix common/ includes.
8760         * findvar.c: Fix common/ includes.
8761         * fbsd-nat.c: Fix common/ includes.
8762         * event-top.c: Fix common/ includes.
8763         * event-loop.c: Fix common/ includes.
8764         * dwarf2read.c: Fix common/ includes.
8765         * dwarf2loc.c: Fix common/ includes.
8766         * dwarf2-frame.c: Fix common/ includes.
8767         * dwarf-index-cache.c: Fix common/ includes.
8768         * dtrace-probe.c: Fix common/ includes.
8769         * disasm-selftests.c: Fix common/ includes.
8770         * defs.h: Fix common/ includes.
8771         * csky-tdep.c: Fix common/ includes.
8772         * cp-valprint.c: Fix common/ includes.
8773         * cp-support.h: Fix common/ includes.
8774         * cp-support.c: Fix common/ includes.
8775         * corelow.c: Fix common/ includes.
8776         * completer.h: Fix common/ includes.
8777         * completer.c: Fix common/ includes.
8778         * compile/compile.c: Fix common/ includes.
8779         * compile/compile-loc2c.c: Fix common/ includes.
8780         * compile/compile-cplus-types.c: Fix common/ includes.
8781         * compile/compile-cplus-symbols.c: Fix common/ includes.
8782         * command.h: Fix common/ includes.
8783         * cli/cli-dump.c: Fix common/ includes.
8784         * cli/cli-cmds.c: Fix common/ includes.
8785         * charset.c: Fix common/ includes.
8786         * build-id.c: Fix common/ includes.
8787         * btrace.h: Fix common/ includes.
8788         * btrace.c: Fix common/ includes.
8789         * breakpoint.h: Fix common/ includes.
8790         * breakpoint.c: Fix common/ includes.
8791         * ax.h:
8792         (enum agent_op): Fix common/ includes.
8793         * ax-general.c (struct aop_map): Fix common/ includes.
8794         * ax-gdb.c: Fix common/ includes.
8795         * auxv.c: Fix common/ includes.
8796         * auto-load.c: Fix common/ includes.
8797         * arm-tdep.c: Fix common/ includes.
8798         * arch/riscv.c: Fix common/ includes.
8799         * arch/ppc-linux-common.c: Fix common/ includes.
8800         * arch/i386.c: Fix common/ includes.
8801         * arch/arm.c: Fix common/ includes.
8802         * arch/arm-linux.c: Fix common/ includes.
8803         * arch/arm-get-next-pcs.c: Fix common/ includes.
8804         * arch/amd64.c: Fix common/ includes.
8805         * arch/aarch64.c: Fix common/ includes.
8806         * arch/aarch64-insn.c: Fix common/ includes.
8807         * arch-utils.c: Fix common/ includes.
8808         * amd64-windows-tdep.c: Fix common/ includes.
8809         * amd64-tdep.c: Fix common/ includes.
8810         * amd64-sol2-tdep.c: Fix common/ includes.
8811         * amd64-obsd-tdep.c: Fix common/ includes.
8812         * amd64-nbsd-tdep.c: Fix common/ includes.
8813         * amd64-linux-tdep.c: Fix common/ includes.
8814         * amd64-linux-nat.c: Fix common/ includes.
8815         * amd64-fbsd-tdep.c: Fix common/ includes.
8816         * amd64-fbsd-nat.c: Fix common/ includes.
8817         * amd64-dicos-tdep.c: Fix common/ includes.
8818         * amd64-darwin-tdep.c: Fix common/ includes.
8819         * agent.c: Fix common/ includes.
8820         * ada-lang.h: Fix common/ includes.
8821         * ada-lang.c: Fix common/ includes.
8822         * aarch64-tdep.c: Fix common/ includes.
8823
8824 2019-01-25  Tom Tromey  <tom@tromey.com>
8825
8826         * common/create-version.sh: Use common/version.h.
8827
8828 2019-01-24  Pedro Alves  <palves@redhat.com>
8829
8830         * infrun.c (signal_stop, signal_print, signal_program)
8831         (signal_catch, signal_pass): Now arrays instead of pointers.
8832         (update_signals_program_target, do_target_resume)
8833         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8834         * linux-nat.c (linux_nat_target::pass_signals)
8835         (linux_nat_target::create_inferior, linux_nat_target::attach):
8836         Adjust.
8837         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8838         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8839         * procfs.c (procfs_target::pass_signals): Adjust.
8840         * record-full.c (record_full_target::resume): Adjust.
8841         * remote.c (remote_target::pass_signals)
8842         (remote_target::program_signals): Adjust.
8843         * target-debug.h (target_debug_print_signals): Now takes a
8844         gdb::array_view as parameter.  Adjust.
8845         * target.h (target_ops) <pass_signals, program_signals>: Replace
8846         pointer and length parameters with gdb::array_view.
8847         (target_pass_signals, target_program_signals): Likewise.
8848         * target-delegates.c: Regenerate.
8849
8850 2019-01-24  Pedro Alves  <palves@redhat.com>
8851
8852         * common/forward-scope-exit.h
8853         (forward_scope_exit::forward_scope_exit): Pass arguments to
8854         m_bind_function directly, instead of creating a std::bind and
8855         copying that.
8856
8857 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8858
8859         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8860         for static members.
8861         (pass_in_v_vfp_candidate): Likewise.
8862
8863 2019-01-23  Tom Tromey  <tom@tromey.com>
8864             Pedro Alves  <palves@redhat.com>
8865
8866         * regcache.c (class regcache_invalidator): Remove.
8867         (regcache::raw_write): Use make_scope_exit.
8868
8869 2019-01-23  Tom Tromey  <tom@tromey.com>
8870
8871         * ui-out.h (class ui_out_emit_type): Update comment.
8872
8873 2019-01-23  Tom Tromey  <tom@tromey.com>
8874
8875         * infrun.c (fetch_inferior_event): Update comment.
8876
8877 2019-01-23  Tom Tromey  <tom@tromey.com>
8878             Pedro Alves  <palves@redhat.com>
8879
8880         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8881         parameter.
8882         (fetch_inferior_event): Use SCOPE_EXIT.
8883
8884
8885 2019-01-23  Tom Tromey  <tom@tromey.com>
8886             Pedro Alves  <palves@redhat.com>
8887
8888         * infrun.c (disable_thread_events): Delete.
8889         (stop_all_threads): Use SCOPE_EXIT.
8890
8891 2019-01-23  Tom Tromey  <tom@tromey.com>
8892             Pedro Alves  <palves@redhat.com>
8893
8894         * symfile.c: Include forward-scope-exit.h.
8895         (clear_symtab_users_cleanup): Replace forward declaration with
8896         a FORWARD_SCOPE_EXIT.
8897         (syms_from_objfile_1): Use the forward_scope_exit and
8898         gdb::optional instead of cleanup_function.
8899         (reread_symbols): Use the forward_scope_exit instead of
8900         cleanup_function.
8901         (clear_symtab_users_cleanup): Remove function.
8902
8903 2019-01-23  Tom Tromey  <tom@tromey.com>
8904             Pedro Alves  <palves@redhat.com>
8905
8906         * linux-nat.c: Include scope-exit.h.
8907         (cleanup_target_stop): Remove.
8908         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8909         SCOPE_EXIT.
8910
8911 2019-01-23  Tom Tromey  <tom@tromey.com>
8912             Pedro Alves  <palves@redhat.com>
8913
8914         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8915         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8916
8917 2019-01-23  Tom Tromey  <tom@tromey.com>
8918             Andrew Burgess  <andrew.burgess@embecosm.com>
8919             Pedro Alves  <palves@redhat.com>
8920
8921         * infrun.c (fetch_inferior_event): Use scope_exit.
8922         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8923         * top.c (execute_command): Use scope_exit.
8924         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8925         * utils.c (do_bpstat_clear_actions_cleanup)
8926         (make_bpstat_clear_actions_cleanup): Remove.
8927
8928 2019-01-23  Tom Tromey  <tom@tromey.com>
8929             Pedro Alves  <palves@redhat.com>
8930
8931         * infrun.c: Include "common/scope-exit.h"
8932         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8933         (wait_for_inferior): Use SCOPE_EXIT.
8934         (fetch_inferior_event): Use scope_exit.
8935
8936 2019-01-23  Tom Tromey  <tom@tromey.com>
8937             Pedro Alves  <palves@redhat.com>
8938
8939         * breakpoint.c (create_breakpoint): Remove cleanup.
8940
8941 2019-01-23  Tom Tromey  <tom@tromey.com>
8942             Andrew Burgess  <andrew.burgess@embecosm.com>
8943             Pedro Alves  <palves@redhat.com>
8944
8945 2019-01-23  Pedro Alves  <palves@redhat.com>
8946
8947         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8948
8949 2019-01-23  Pedro Alves  <palves@redhat.com>
8950             Andrew Burgess  <andrew.burgess@embecosm.com>
8951
8952         * gdbthread.h: Include "common/forward-scope-exit.h".
8953         (scoped_finish_thread_state): Redefine custom class in terms of
8954         forward_scope_exit.
8955
8956 2019-01-23  Pedro Alves  <palves@redhat.com>
8957             Andrew Burgess  <andrew.burgess@embecosm.com>
8958
8959         * common/forward-scope-exit.h: New file.
8960
8961 2019-01-23  Pedro Alves  <palves@redhat.com>
8962             Andrew Burgess  <andrew.burgess@embecosm.com>
8963             Tom Tromey  <tom@tromey.com>
8964
8965         * common/scope-exit.h: New file.
8966
8967 2019-01-23  Pedro Alves  <palves@redhat.com>
8968
8969         * common/preprocessor.h (ESC): Rename to ...
8970         (ESC_PARENS): ... this.
8971         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8972         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8973
8974 2019-01-23  Tom Tromey  <tom@tromey.com>
8975
8976         * language.h (class scoped_switch_to_sym_language_if_auto):
8977         Initialize m_lang in both cases.
8978
8979 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8980
8981         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8982         with XCNEW.
8983
8984 2019-01-22  Tom Tromey  <tom@tromey.com>
8985
8986         * corelow.c: Do not include sys/file.h.
8987
8988 2019-01-22  Tom Tromey  <tom@tromey.com>
8989
8990         * tui/tui-wingeneral.h: Include gdb_curses.h.
8991
8992 2019-01-22  Tom Tromey  <tom@tromey.com>
8993
8994         * source-cache.h (class source_cache) <get_source_lines,
8995         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8996
8997 2019-01-22  Tom Tromey  <tom@tromey.com>
8998
8999         * remote-fileio.h (struct remote_target): Declare.
9000
9001 2019-01-22  Tom Tromey  <tom@tromey.com>
9002
9003         * python/py-arch.c: Do not include py-ref.h.
9004         * python/py-bpevent.c: Do not include py-ref.h.
9005         * python/py-cmd.c: Do not include py-ref.h.
9006         * python/py-continueevent.c: Do not include py-ref.h.
9007         * python/py-event.h: Do not include py-ref.h.
9008         * python/py-evtregistry.c: Do not include py-ref.h.
9009         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9010         * python/py-frame.c: Do not include py-ref.h.
9011         * python/py-framefilter.c: Do not include py-ref.h.
9012         * python/py-function.c: Do not include py-ref.h.
9013         * python/py-infevents.c: Do not include py-ref.h.
9014         * python/py-linetable.c: Do not include py-ref.h.
9015         * python/py-objfile.c: Do not include py-ref.h.
9016         * python/py-param.c: Do not include py-ref.h.
9017         * python/py-prettyprint.c: Do not include py-ref.h.
9018         * python/py-progspace.c: Do not include py-ref.h.
9019         * python/py-symbol.c: Do not include py-ref.h.
9020         * python/py-symtab.c: Do not include py-ref.h.
9021         * python/py-type.c: Do not include py-ref.h.
9022         * python/py-unwind.c: Do not include py-ref.h.
9023         * python/py-utils.c: Do not include py-ref.h.
9024         * python/py-value.c: Do not include py-ref.h.
9025         * python/py-varobj.c: Do not include py-ref.h.
9026         * python/py-xmethods.c: Do not include py-ref.h.
9027         * python/python.c: Do not include py-ref.h.
9028         * varobj.c: Do not include py-ref.h.
9029
9030 2019-01-22  Tom Tromey  <tom@tromey.com>
9031
9032         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9033         keyword for bcache.
9034
9035 2019-01-22  Tom Tromey  <tom@tromey.com>
9036
9037         * compile/compile-cplus-types.c: Remove a comment by #include.
9038
9039 2019-01-22  Tom Tromey  <tom@tromey.com>
9040
9041         * compile/gcc-c-plugin.h: Include compile-internal.h.
9042
9043 2019-01-22  Tom Tromey  <tom@tromey.com>
9044
9045         * stabsread.c (EXTERN): Do not define.
9046         (symnum, next_symbol_text_func, processing_gcc_compilation)
9047         (within_function, global_sym_chain, global_stabs)
9048         (previous_stab_code, this_object_header_files)
9049         (n_this_object_header_files)
9050         (n_allocated_this_object_header_files): Define.
9051         * stabsread.h (EXTERN): Never define.  Use "extern".
9052
9053 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9054
9055         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9056         history_value.
9057
9058 2019-01-21  Tom Tromey  <tom@tromey.com>
9059
9060         * ui-out.c: Fix includes.
9061         * tui/tui-source.c: Fix includes.
9062         * target.c: Fix includes.
9063         * remote.c: Fix includes.
9064         * regcache.c: Fix includes.
9065         * python/py-block.c: Fix includes.
9066         * printcmd.c: Fix includes.
9067         * or1k-tdep.c: Fix includes.
9068         * mi/mi-main.c: Fix includes.
9069         * m32r-tdep.c: Fix includes.
9070         * csky-tdep.c: Fix includes.
9071         * compile/compile-cplus-types.c: Fix includes.
9072         * cli/cli-interp.c: Fix includes.
9073
9074 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9075
9076         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9077         for padding.
9078
9079 2019-01-16  Tom Tromey  <tom@tromey.com>
9080
9081         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9082         earlier.
9083         (struct objfile) <msymbols_range>: Move from top level.
9084         <msymbols>: New method.
9085         (class objfile_msymbols): Remove.
9086         * symtab.c (default_collect_symbol_completion_matches_break_on):
9087         Update.
9088         * symmisc.c (dump_msymbols): Update.
9089         * stabsread.c (scan_file_globals): Update.
9090         * objc-lang.c (info_selectors_command, info_classes_command)
9091         (find_methods): Update.
9092         * minsyms.c (find_solib_trampoline_target): Update.
9093         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9094         * coffread.c (coff_symfile_read): Update.
9095         * ada-lang.c (ada_lookup_simple_minsym)
9096         (ada_collect_symbol_completion_matches): Update.
9097
9098 2019-01-16  Tom Tromey  <tom@tromey.com>
9099
9100         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9101         type.  Remove no-argument constructor.
9102         <iterator::operator++>: Simplify.
9103         <begin>: Update.
9104         <end>: Use minimal_symbol_count.
9105
9106 2019-01-16  Tom Tromey  <tom@tromey.com>
9107
9108         * objfiles.h (struct objfile) <psymtabs>: New method.
9109         (class objfile_psymtabs): Remove.
9110         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9111         typedef.
9112         <range>: New method.
9113         (require_partial_symbols): Change return type.
9114         * psymtab.c (require_partial_symbols)
9115         (psym_expand_symtabs_matching): Update.
9116         * mdebugread.c (parse_partial_symbols): Update.
9117         * dbxread.c (dbx_end_psymtab): Update.
9118
9119 2019-01-15  Tom Tromey  <tom@tromey.com>
9120
9121         * symtab.c (lookup_objfile_from_block)
9122         (lookup_symbol_in_objfile_symtabs)
9123         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9124         (find_line_symtab, info_sources_command)
9125         (default_collect_symbol_completion_matches_break_on)
9126         (make_source_files_completion_list): Update.
9127         * symmisc.c (print_objfile_statistics, dump_objfile)
9128         (maintenance_print_symbols, maintenance_info_symtabs)
9129         (maintenance_check_symtabs, maintenance_info_line_tables):
9130         Update.
9131         * source.c (select_source_symtab)
9132         (forget_cached_source_info_for_objfile): Update.
9133         * objfiles.h (class objfile_compunits): Remove.
9134         (struct objfile) <compunits_range>: New typedef.
9135         (compunits): New method.
9136         * objfiles.c (objfile_relocate1): Update.
9137         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9138         * maint.c (count_symtabs_and_blocks): Update.
9139         * linespec.c (iterate_over_all_matching_symtabs): Update.
9140         * cp-support.c (add_symbol_overload_list_qualified): Update.
9141         * coffread.c (coff_symtab_read): Update.
9142         * ada-lang.c (add_nonlocal_symbols)
9143         (ada_collect_symbol_completion_matches)
9144         (ada_add_global_exceptions): Update.
9145
9146 2019-01-15  Tom Tromey  <tom@tromey.com>
9147
9148         * progspace.h (program_space) <objfiles_safe_range>: New
9149         typedef.
9150         <objfiles_safe>: New method.
9151         * objfiles.h (class all_objfiles_safe): Remove.
9152         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9153         * jit.c (jit_inferior_exit_hook): Update.
9154
9155 2019-01-17  Tom Tromey  <tom@tromey.com>
9156
9157         * progspace.h (program_space) <objfiles_range>: New typedef.
9158         <objfiles>: New method.
9159         <objfiles_head>: Rename from objfiles.
9160         (object_files): Update.
9161         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9162         * guile/scm-pretty-print.c
9163         (ppscm_find_pretty_printer_from_objfiles): Update.
9164         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9165         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9166         Update.
9167         * python/py-progspace.c (pspy_get_objfiles): Update.
9168         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9169         Update.
9170         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9171         (objfpy_lookup_objfile_by_build_id): Update.
9172         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9173         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9174         Update.
9175         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9176         (expand_symtab_containing_pc, lookup_objfile_from_block)
9177         (lookup_static_symbol, basic_lookup_transparent_type)
9178         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9179         (find_line_symtab, info_sources_command)
9180         (default_collect_symbol_completion_matches_break_on)
9181         (make_source_files_completion_list, find_main_name): Update.
9182         * symmisc.c (print_symbol_bcache_statistics)
9183         (print_objfile_statistics, maintenance_print_symbols)
9184         (maintenance_print_msymbols, maintenance_print_objfiles)
9185         (maintenance_info_symtabs, maintenance_check_symtabs)
9186         (maintenance_expand_symtabs, maintenance_info_line_tables):
9187         Update.
9188         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9189         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9190         (map_overlay_command, unmap_overlay_command)
9191         (simple_overlay_update, expand_symtabs_matching)
9192         (map_symbol_filenames): Update.
9193         * symfile-debug.c (set_debug_symfile): Update.
9194         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9195         Update.
9196         * source.c (select_source_symtab, forget_cached_source_info):
9197         Update.
9198         * solib.c (solib_read_symbols): Update.
9199         * solib-spu.c (append_ocl_sos): Update.
9200         * psymtab.c (maintenance_print_psymbols)
9201         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9202         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9203         * printcmd.c (info_symbol_command): Update.
9204         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9205         Update.
9206         * objfiles.h (class all_objfiles): Remove.
9207         * objfiles.c (have_partial_symbols, have_full_symbols)
9208         (have_minimal_symbols, qsort_cmp, update_section_map)
9209         (shared_objfile_contains_address_p)
9210         (default_iterate_over_objfiles_in_search_order): Update.
9211         * objc-lang.c (info_selectors_command, info_classes_command)
9212         (find_methods): Update.
9213         * minsyms.c (find_solib_trampoline_target): Update.
9214         * maint.c (maintenance_info_sections)
9215         (maintenance_translate_address, count_symtabs_and_blocks):
9216         Update.
9217         * main.c (captured_main_1): Update.
9218         * linux-thread-db.c (try_thread_db_load_from_pdir)
9219         (has_libpthread): Update.
9220         * linespec.c (iterate_over_all_matching_symtabs)
9221         (search_minsyms_for_name): Update.
9222         * jit.c (jit_find_objf_with_entry_addr): Update.
9223         * hppa-tdep.c (find_unwind_entry)
9224         (hppa_lookup_stub_minimal_symbol): Update.
9225         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9226         Update.
9227         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9228         (elf_gnu_ifunc_resolve_by_got): Update.
9229         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9230         * dwarf-index-write.c (save_gdb_index_command): Update.
9231         * cp-support.c (add_symbol_overload_list_qualified): Update.
9232         * breakpoint.c (create_overlay_event_breakpoint)
9233         (create_longjmp_master_breakpoint)
9234         (create_std_terminate_master_breakpoint)
9235         (create_exception_master_breakpoint): Update.
9236         * blockframe.c (find_pc_partial_function): Update.
9237         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9238         (ada_collect_symbol_completion_matches)
9239         (ada_add_global_exceptions): Update.
9240
9241 2019-01-17  Tom Tromey  <tom@tromey.com>
9242
9243         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9244         declare VEC.
9245         (solib_target_parse_libraries): Change return type.
9246         (library_list_start_segment, library_list_start_section)
9247         (library_list_end_library, library_list_start_library); Update.
9248         (solib_target_free_library_list): Remove.
9249         (solib_target_parse_libraries): Remove cleanup.  Change return
9250         type.
9251         (solib_target_current_sos): Update.
9252
9253 2019-01-17  Tom Tromey  <tromey@bapiya>
9254
9255         * valprint.c: Replace "the the" with "the".
9256         * symtab.c: Replace "the the" with "the".
9257         * solib.c: Replace "the the" with "the".
9258         * solib-dsbt.c: Replace "the the" with "the".
9259         * linespec.c: Replace "the the" with "the".
9260         * dwarf2loc.h: Replace "the the" with "the".
9261         * amd64-windows-tdep.c: Replace "the the" with "the".
9262         * aarch64-tdep.c: Replace "the the" with "the".
9263
9264 2019-01-16  Keith Seitz  <keiths@redhat.com>
9265
9266         PR gdb/23773
9267         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9268         <builder>: Rename to ..
9269         <m_builder>: ... this and make private.
9270         (dwarf2_cu::get_builder): New method.  Change all users of
9271         `builder' to use this method.
9272         (dwarf2_start_symtab): Move to ...
9273         (dwarf2_cu::start_symtab): ... here.  Update all callers
9274         (setup_type_unit_groups): Move to ...
9275         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9276         callers.
9277         (dwarf2_cu::reset_builder): New method.
9278         (process_full_compunit, process_full_type_unit): Use
9279         dwarf2_cu::reset_builder.
9280         (follow_die_offset): Record the ancestor CU if it is different
9281         from the followed DIE's CU.
9282         (follow_die_sig_1): Likewise.
9283
9284 2019-01-15  Tom Tromey  <tom@tromey.com>
9285
9286         * remote.c (class remote_state) <buf>: Now a char_vector.
9287         <buf_size>: Remove.
9288         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9289         parameter.
9290         (remote_target::getpkt_or_notif_sane_1)
9291         (remote_target::getpkt_sane)
9292         (remote_target::getpkt_or_notif_sane): Likewise.
9293         (class remote_target) <putpkt>: New overload.
9294         (remote_target::read_frame): Change type of "buf_p".  Remove
9295         sizeof_p parameter.
9296         (packet_ok): New overload.
9297         (packet_check_result): New overload.
9298         Update all uses.
9299
9300 2019-01-14  Tom Tromey  <tom@tromey.com>
9301
9302         * remote-notif.c (handle_notification, remote_notif_ack)
9303         (remote_notif_parse): Make "buf" const.
9304         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9305         const.
9306         (remote_notif_parse, remote_notif_ack, handle_notification):
9307         Likewise.
9308         * remote.c (remote_notif_stop_parse): Make "buf" const.
9309         (remote_target::remote_parse_stop_reply): Make "buf" const.
9310         (remote_notif_stop_ack): Make "buf" const.
9311
9312 2019-01-14  Tom Tromey  <tom@tromey.com>
9313
9314         * remote.c (remote_console_output): Make parameter const.
9315
9316 2019-01-14  Tom Tromey  <tom@tromey.com>
9317
9318         * target-debug.h (target_debug_print_signals): Constify.
9319         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9320         * procfs.c (procfs_target::pass_signals): Update.
9321         * linux-nat.c (linux_nat_target::pass_signals): Update.
9322         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9323         * target-delegates.c: Rebuild.
9324         * remote.c (remote_target::program_signals): Update.
9325         (remote_target::pass_signals): Update.
9326         * target.c (target_pass_signals): Constify argument.
9327         (target_program_signals): Likewise.
9328         * target.h (struct target_ops) <pass_signals, program_signals>:
9329         Constify argument.
9330         (target_pass_signals, target_program_signals): Constify argument.
9331
9332 2019-01-14  Tom Tromey  <tom@tromey.com>
9333
9334         PR tui/28819:
9335         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9336
9337 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9338
9339         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9340         field.
9341         * rs6000-tdep.c: Include reggroups.h.
9342         (IS_V_ALIAS_PSEUDOREG): Define.
9343         (rs6000_register_name): Return names for the "vX" aliases.
9344         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9345         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9346         aliases.  Call default_register_reggroup_p for all other
9347         pseudo-registers.
9348         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9349         New functions.
9350         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9351         Handle "vX" aliases.
9352         (v_alias_pseudo_register_collect): New function.
9353         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9354         (rs6000_gdbarch_init): Initialize "vX" aliases as
9355         pseudo-registers.  Restore registration of
9356         rs6000_pseudo_register_reggroup_p with
9357         set_tdesc_pseudo_register_reggroup_p.
9358
9359 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9360
9361         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9362         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9363         set_gdbarch_num_pseudo_regs.
9364
9365 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9366
9367         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9368         Remove arg prefixname, add do_set and do_show.
9369         Add member functions set_list and show_list.
9370         * cli/cli-style.c (class cli_style_option): Update accordingly.
9371         (style_set_list): Move to file scope.
9372         (style_show_list): Likewise.
9373         (set_style): Call help_list.
9374         (show_style): Call cmd_show_list.
9375         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9376         Update to use the new macro.
9377
9378 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9379
9380         * ada-lang.c (_initialize_ada_language): Expand the help text
9381         for the "catch exception" command.
9382
9383 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9384
9385         * symtab.c (matching_obj_sections): Initialize obj,
9386         declare it closer to its usage.
9387
9388 2019-01-10  Tom Tromey  <tom@tromey.com>
9389
9390         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9391         (basic_inf_threads_range): Remove.
9392         (inf_threads_range, inf_non_exited_threads_range)
9393         (safe_inf_threads_range): Use next_adapter.
9394
9395 2019-01-10  Keith Seitz  <keiths@redhat.com>
9396
9397         PR gdb/23712
9398         PR symtab/23010
9399         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9400         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9401
9402 2019-01-10  Keith Seitz  <keiths@redhat.com>
9403
9404         PR gdb/23712
9405         PR symtab/23010
9406         * dictionary.c (pending_to_vector): Remove.
9407         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9408         Remove _1 suffix, replacing functions of the same name.  Update
9409         all callers.
9410         (dict_create_hashed, dict_create_hashed_expandable)
9411         (dict_create_linear, dict_create_linear_expandable, dict_free)
9412         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9413         Make functions static.
9414
9415 2019-01-10  Keith Seitz  <keiths@redhat.com>
9416
9417         PR gdb/23712
9418         PR symtab/23010
9419         * dictionary.h (struct dictionary): Replace declaration with
9420         multidictionary.
9421         (dict_create_hashed, dict_create_hashed_expandable)
9422         (dict_create_linear, dict_create_linear_expandable)
9423         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9424         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9425         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9426         taking multidictionary argument.
9427         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9428         * block.h (struct block) <dict>: Change to multidictionary
9429         and rename `multidict'.
9430         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9431         symmisc.c: Update all dictionary references to multidictionary.
9432
9433 2019-01-10  Keith Seitz  <keiths@redhat.com>
9434
9435         PR gdb/23712
9436         PR symtab/23010
9437         * dictionary.c: Include unordered_map.
9438         (pending_to_vector): New function.
9439         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9440         Rewrite the non-"_1" functions to take vector instead
9441         of linked list.
9442         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9443         "new" _1 versions of the same name.
9444         (multidictionary): Define.
9445         (std::hash<enum language): New definition.
9446         (collate_pending_symbols_by_language, mdict_create_hashed)
9447         (mdict_create_hashed_expandable, mdict_create_linear)
9448         (mdict_create_linear_expandable, mdict_free)
9449         (find_language_dictionary, create_new_language_dictionary)
9450         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9451         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9452         (mdict_size, mdict_empty): New functions.
9453         * dictionary.h (mdict_iterator): Define.
9454
9455 2019-01-10  Pedro Alves  <palves@redhat.com>
9456
9457         * breakpoint.c (read_uploaded_action)
9458         (create_tracepoint_from_upload): Adjust to use
9459         gdb::unique_xmalloc_ptr.
9460         * ctf.c (ctf_write_uploaded_tp):
9461         (SET_ARRAY_FIELD): Use emplace_back.
9462         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9463         * tracefile-tfile.c (tfile_write_uploaded_tp):
9464         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9465         gdb::unique_xmalloc_ptr.
9466         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9467         at_string, cond_string, cmd_strings>: Replace char pointers
9468         with gdb::unique_xmalloc_ptr.
9469
9470 2019-01-10  Pedro Alves  <palves@redhat.com>
9471
9472         * solib-target.c (library_list_start_library): Don't xstrdup name.
9473
9474 2019-01-10  Pedro Alves  <palves@redhat.com>
9475
9476         * mdebugread.c (parse_partial_symbols): Use
9477         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9478
9479 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9480
9481         * linux-fork.c (scoped_switch_fork_info)
9482         <~scoped_switch_fork_info>: Fix incorrect variable name.
9483
9484 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9485
9486         * linux-fork.c (scoped_switch_fork_info)
9487         <scoped_switch_fork_info>: Make explicit.
9488         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9489
9490 2019-01-10  Tom Tromey  <tom@tromey.com>
9491
9492         * objfiles.h (objfile::reset_psymtabs): Update.
9493         * objfiles.c (objfile::objfile): Update.
9494         * psymtab.h (psymtab_storage::obstack): Update.
9495         (psymtab_storage::m_obstack): Use gdb::optional.
9496         (class psymtab_storage): Update comment.  Remove objfile
9497         parameter.
9498         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9499
9500 2019-01-10  Tom Tromey  <tom@tromey.com>
9501
9502         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9503         <free_psymtabs>: Now private.
9504         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9505         (allocate_psymtab): Use new method.
9506
9507 2019-01-10  Tom Tromey  <tom@tromey.com>
9508
9509         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9510         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9511         * mdebugread.c (parse_partial_symbols): Use
9512         allocate_dependencies.
9513         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9514         allocate_dependencies.
9515         (process_psymtab_comp_unit_reader)
9516         (build_type_psymtab_dependencies): Likewise.
9517         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9518
9519 2019-01-10  Tom Tromey  <tom@tromey.com>
9520
9521         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9522         PSYMBOL_SET_LANGUAGE.
9523         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9524
9525 2019-01-10  Tom Tromey  <tom@tromey.com>
9526
9527         * psymtab.h (psymtab_storage::obstack): New method.
9528         <m_obstack>: Rename from obstack; now private.
9529         * psymtab.c (psymtab_storage): Update.
9530         * dwarf2read.c (create_addrmap_from_index)
9531         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9532         Update.
9533
9534 2019-01-10  Tom Tromey  <tom@tromey.com>
9535
9536         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9537         * objfiles.h (objfile::reset_psymtabs): New method.
9538
9539 2019-01-10  Tom Tromey  <tom@tromey.com>
9540
9541         * symmisc.c (print_symbol_bcache_statistics): Update.
9542         (print_objfile_statistics): Update.
9543         * symfile.c (reread_symbols): Update.
9544         * psymtab.h (class psymtab_storage): New.
9545         * psymtab.c (psymtab_storage): New constructor.
9546         (~psymtab_storage): New destructor.
9547         (require_partial_symbols): Update.
9548         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9549         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9550         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9551         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9552         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9553         (start_psymtab_common, end_psymtab_common)
9554         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9555         (allocate_psymtab): Update.
9556         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9557         Update.
9558         (dump_psymtab_addrmap, maintenance_print_psymbols)
9559         (maintenance_check_psymtabs): Update.
9560         (class objfile_psymtabs): Move to objfiles.h.
9561         * psympriv.h (discard_psymtab): Now inline.
9562         (psymtab_discarder::psymtab_discarder): Update.
9563         (psymtab_discarder::~psymtab_discarder): Update.
9564         (ALL_OBJFILE_PSYMTABS): Rewrite.
9565         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9566         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9567         Remove fields.
9568         <partial_symtabs>: New field.
9569         (class objfile_psymtabs): Move from psymtab.h.  Update.
9570         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9571         psymbol_cache.
9572         (objfile::~objfile): Don't destroy psymbol_cache.
9573         * mdebugread.c (parse_partial_symbols): Update.
9574         * dwarf2read.c (create_addrmap_from_index)
9575         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9576         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9577         (add_partial_subprogram, dwarf2_ranges_read): Update.
9578         * dwarf-index-write.c (write_address_map)
9579         (write_one_signatured_type, recursively_write_psymbols)
9580         (class debug_names, class debug_names, write_psymtabs_to_index):
9581         Update.
9582
9583 2019-01-10  Tom Tromey  <tom@tromey.com>
9584
9585         * symtab.h (SYMBOL_SET_NAMES): Update.
9586         (symbol_set_names): Update.
9587         (MSYMBOL_SET_NAMES): Update.
9588         * symtab.c (symbol_set_names): Change argument to be an
9589         objfile_per_bfd_storage.
9590         * psymtab.c (add_psymbol_to_bcache): Update.
9591         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9592
9593 2019-01-10  Tom Tromey  <tom@tromey.com>
9594
9595         * symtab.c (create_demangled_names_hash): Change argument to be an
9596         objfile_per_bfd_storage.
9597         (symbol_set_names): Update.
9598
9599 2019-01-10  Tom Tromey  <tom@tromey.com>
9600
9601         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9602         init_psymbol_list.
9603         * psymtab.c (init_psymbol_list): Do nothing if already called.
9604         * psympriv.h (init_psymbol_list): Add comment.
9605         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9606         init_psymbol_list.
9607         * dbxread.c (dbx_symfile_read): Unconditionally call
9608         init_psymbol_list.
9609
9610 2019-01-10  Tom Tromey  <tom@tromey.com>
9611
9612         * xcoffread.c (scan_xcoff_symtab): Update.
9613         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9614         "where".
9615         * mdebugread.c (parse_partial_symbols)
9616         (handle_psymbol_enumerators): Update.
9617         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9618         * dbxread.c (read_dbx_symtab): Update.
9619         * psympriv.h (psymbol_placement): New enum.
9620         (add_psymbol_to_list): Update.
9621
9622 2019-01-10  Tom Tromey  <tom@tromey.com>
9623
9624         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9625         static_psymbols parameters.
9626         (scan_xcoff_symtab): Update.
9627         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9628         static_psymbols parameters.
9629         * psympriv.h (start_psymtab_common): Update.
9630         * mdebugread.c (parse_partial_symbols): Update.
9631         * dwarf2read.c (create_partial_symtab): Update.
9632         * dbxread.c (read_dbx_symtab): Update.
9633         (start_psymtab): Remove global_psymbols and static_psymbols
9634         parameters.
9635
9636 2019-01-10  Tom Tromey  <tom@tromey.com>
9637
9638         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9639         * psymtab.c (allocate_psymtab): Add comment.
9640         * psympriv.h (allocate_psymtab): Add comment.
9641         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9642         initializations.
9643         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9644
9645 2019-01-10  Tom Tromey  <tom@tromey.com>
9646
9647         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9648         Don't declare.
9649         * mipsread.c: Include mdebugread.h.
9650         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9651         Declare.
9652         * elfread.c: Include mdebugread.h.
9653
9654 2019-01-09  Tom Tromey  <tom@tromey.com>
9655
9656         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9657         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9658         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9659         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9660         (psym_lookup_symbol, psym_find_last_source_symtab)
9661         (psym_forget_cached_source_info, psym_print_stats)
9662         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9663         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9664         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9665         (psym_find_compunit_symtab_by_address)
9666         (maintenance_print_psymbols, maintenance_info_psymtabs)
9667         (maintenance_check_psymtabs): Use ranged for.
9668         * psymtab.h (class objfile_psymtabs): New.
9669         (require_partial_symbols): Return objfile_psymtabs.
9670         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9671
9672 2019-01-09  Tom Tromey  <tom@tromey.com>
9673
9674         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9675         (find_pc_mapped_section, list_overlays_command)
9676         (map_overlay_command, unmap_overlay_command)
9677         (simple_overlay_update): Use all_objfiles.
9678         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9679         * printcmd.c (info_symbol_command): Use all_objfiles.
9680         * objfiles.h (ALL_OBJSECTIONS): Remove.
9681         * maint.c (maintenance_translate_address): Use all_objfiles.
9682         * gcore.c (gcore_create_callback): Use all_objfiles.
9683         (objfile_find_memory_regions): Likewise.
9684
9685 2019-01-09  Tom Tromey  <tom@tromey.com>
9686
9687         * symtab.c (find_line_symtab, info_sources_command)
9688         (make_source_files_completion_list): Use objfile_compunits.
9689         * source.c (select_source_symtab): Use objfile_compunits.
9690         * objfiles.h (struct objfile): Update comment.
9691         (ALL_OBJFILES): Remove.
9692         (ALL_FILETABS): Remove.
9693         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9694         objfile_compunits.
9695
9696 2019-01-09  Tom Tromey  <tom@tromey.com>
9697
9698         * symmisc.c (print_objfile_statistics, dump_objfile)
9699         (maintenance_print_symbols): Use compunit_filetabs.
9700         * source.c (forget_cached_source_info_for_objfile): Use
9701         compunit_filetabs.
9702         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9703         (ALL_FILETABS): Use compunit_filetabs.
9704         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9705         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9706
9707 2019-01-09  Tom Tromey  <tom@tromey.com>
9708
9709         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9710         (compunit_filetabs): New.
9711         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9712         compunit_filetabs.
9713         (info_sources_command, make_source_files_completion_list): Remove
9714         declaration.
9715         * symmisc.c (print_objfile_statistics, dump_objfile)
9716         (maintenance_print_symbols): Remove declaration.
9717         (maintenance_info_symtabs): Use compunit_filetabs.
9718         (maintenance_info_line_tables): Likewise.
9719         * source.c (select_source_symtab): Change local variable name.
9720         (forget_cached_source_info_for_objfile): Remove declaration.
9721         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9722         * objfiles.c (objfile_relocate1): Remove declaration.
9723         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9724         declaration.
9725         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9726         * coffread.c (coff_symtab_read): Remove declaration.
9727         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9728         compunit_filetabs.
9729
9730 2019-01-09  Tom Tromey  <tom@tromey.com>
9731
9732         * symtab.c (lookup_objfile_from_block)
9733         (find_pc_sect_compunit_symtab, search_symbols)
9734         (default_collect_symbol_completion_matches_break_on): Use
9735         objfile_compunits.
9736         * objfiles.h (ALL_COMPUNITS): Remove.
9737         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9738         * cp-support.c (add_symbol_overload_list_qualified): Use
9739         objfile_compunits.
9740         * ada-lang.c (ada_collect_symbol_completion_matches)
9741         (ada_add_global_exceptions): Use objfile_compunits.
9742
9743 2019-01-09  Tom Tromey  <tom@tromey.com>
9744
9745         * source.c (select_source_symtab)
9746         (forget_cached_source_info_for_objfile): Remove declaration.
9747         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9748         declaration.
9749         * maint.c (count_symtabs_and_blocks): Remove declaration.
9750         * cp-support.c (add_symbol_overload_list_qualified): Remove
9751         declaration.
9752         * coffread.c (coff_symtab_read): Remove declaration.
9753         * symtab.c (lookup_symbol_in_objfile_symtabs)
9754         (basic_lookup_transparent_type_1): Use objfile_compunits.
9755         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9756         (info_sources_command, search_symbols)
9757         (default_collect_symbol_completion_matches_break_on)
9758         (make_source_files_completion_list): Remove declaration.
9759         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9760         (ada_collect_symbol_completion_matches)
9761         (ada_add_global_exceptions): Remove declaration.
9762         * linespec.c (iterate_over_all_matching_symtabs): Use
9763         objfile_compunits.
9764         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9765         (class objfile_compunits): New.
9766         (ALL_COMPUNITS): Use objfile_compunits.
9767         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9768         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9769         objfile_compunits.
9770         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9771
9772 2019-01-09  Tom Tromey  <tom@tromey.com>
9773
9774         * symtab.c (search_symbols)
9775         (default_collect_symbol_completion_matches_break_on): Use
9776         objfile_msymbols.
9777         * ada-lang.c (ada_lookup_simple_minsym)
9778         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9779         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9780         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9781         objfile_msymbols.
9782         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9783         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9784         * objc-lang.c (find_methods): Use objfile_msymbols.
9785         (info_selectors_command, info_classes_command): Likewise.
9786         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9787         * objfiles.h (class objfile_msymbols): New.
9788         (ALL_OBJFILE_MSYMBOLS): Remove.
9789         (ALL_MSYMBOLS): Remove.
9790
9791 2019-01-09  Tom Tromey  <tom@tromey.com>
9792
9793         * common/next-iterator.h (next_adapter): Add Iterator template
9794         parameter.
9795         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9796         (class all_objfiles_safe): New.
9797         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9798         * objfiles.c (put_objfile_before): Update comment.
9799         (add_separate_debug_objfile): Likewise.
9800         (free_all_objfiles): Use all_objfiles_safe.
9801         (objfile_purge_solibs): Likewise.
9802
9803 2019-01-09  Tom Tromey  <tom@tromey.com>
9804
9805         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9806         (expand_symtab_containing_pc, lookup_static_symbol)
9807         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9808         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9809         all_objfiles.
9810         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9811         * breakpoint.c (create_overlay_event_breakpoint)
9812         (create_longjmp_master_breakpoint)
9813         (create_std_terminate_master_breakpoint)
9814         (create_exception_master_breakpoint): Use all_objfiles.
9815         * linux-thread-db.c (try_thread_db_load_from_pdir)
9816         (has_libpthread): Use all_objfiles.
9817         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9818         * linespec.c (iterate_over_all_matching_symtabs)
9819         (search_minsyms_for_name): Use all_objfiles.
9820         * maint.c (maintenance_info_sections): Use all_objfiles.
9821         * main.c (captured_main_1): Use all_objfiles.
9822         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9823         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9824         * guile/scm-pretty-print.c
9825         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9826         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9827         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9828         (maintenance_print_msymbols): Use all_objfiles.
9829         * source.c (select_source_symtab): Use all_objfiles.
9830         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9831         * symfile.c (remove_symbol_file_command)
9832         (expand_symtabs_matching, map_symbol_filenames): Use
9833         all_objfiles.
9834         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9835         all_objfiles.
9836         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9837         * objc-lang.c (find_methods): Use all_objfiles.
9838         * objfiles.c (have_partial_symbols, have_full_symbols)
9839         (have_minimal_symbols, qsort_cmp)
9840         (default_iterate_over_objfiles_in_search_order): Use
9841         all_objfiles.
9842         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9843         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9844         (maintenance_check_psymtabs): Use all_objfiles.
9845         (ALL_PSYMTABS): Remove.
9846         * compile/compile-object-run.c (do_module_cleanup): Use
9847         all_objfiles.
9848         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9849         * cp-support.c (add_symbol_overload_list_qualified): Use
9850         all_objfiles.
9851         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9852         Use all_objfiles.
9853         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9854         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9855         all_objfiles.
9856         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9857         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9858         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9859         Uses all_objfiles.
9860         * solib.c (solib_read_symbols): Use all_objfiles
9861
9862 2019-01-09  Tom Tromey  <tom@tromey.com>
9863
9864         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9865         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9866         all_objfiles.
9867         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9868         * symmisc.c (print_symbol_bcache_statistics)
9869         (print_objfile_statistics, maintenance_print_objfiles)
9870         (maintenance_info_symtabs, maintenance_check_symtabs)
9871         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9872         all_objfiles.
9873         * source.c (forget_cached_source_info): Use all_objfiles.
9874         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9875         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9876         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9877         * objfiles.c (update_section_map): Use all_objfiles.
9878         (shared_objfile_contains_address_p): Likewise.
9879         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9880         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9881
9882 2019-01-09  Tom Tromey  <tom@tromey.com>
9883
9884         * common/next-iterator.h: New file.
9885         * objfiles.h (class all_objfiles): New.
9886         (struct objfile_iterator): New.
9887
9888 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9889
9890         * NEWS: Move the description of the changed "frame", "select-frame",
9891          and "info frame" commands to the Changed commands section.
9892
9893 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9894
9895         * gdbtypes.c (check_stub_method_group): Remove handling of old
9896         mangling schemes.
9897         * linespec.c (find_methods): Likewise.
9898         * stabsread.c (read_member_functions): Likewise.
9899         * valops.c (search_struct_method): Likewise.
9900         (value_struct_elt_for_reference): Likewise.
9901         * NEWS: Mention this change.
9902
9903 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9904
9905         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9906         print_source_lines.
9907         * source.c (print_source_lines_base): Update line number check.
9908         (print_source_lines): New function.
9909         (source_lines_range::source_lines_range): New function.
9910         * source.h (class source_lines_range): New class.
9911         (print_source_lines): New declaration.
9912
9913 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9914
9915         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9916
9917 2019-01-08  Tom Tromey  <tom@tromey.com>
9918             Simon Marchi  <simon.marchi@ericsson.com>
9919
9920         PR gdb/24060
9921         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9922         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9923         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9924         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9925         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9926         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9927
9928 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9929
9930         * source.c (select_source_symtab): Move header comment to
9931         declaration in source.h.
9932         (forget_cached_source_info_for_objfile): Likewise.
9933         (forget_cached_source_info): Likewise.
9934         (identify_source_line): Likewise.
9935         * source.h (identify_source_line): Move declaration from symtab.h
9936         and add comment from source.c
9937         (print_source_lines): Likewise.
9938         (forget_cached_source_info_for_objfile): Likewise.
9939         (forget_cached_source_info): Likewise.
9940         (select_source_symtab): Likewise.
9941         (enum print_source_lines_flag): Move definition from symtab.h.
9942         * symtab.h (identify_source_line): Move declaration to source.h.
9943         (print_source_lines): Likewise.
9944         (forget_cached_source_info_for_objfile): Likewise.
9945         (forget_cached_source_info): Likewise.
9946         (select_source_symtab): Likewise.
9947         (enum print_source_lines_flag): Move definition to source.h.
9948         * tui/tui-hooks.c: Add 'source.h' include.
9949
9950 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9951
9952         * source.c (print_source_lines_base): Handle requests to print
9953         reverse line number sequences, and guard against empty lines
9954         string.
9955
9956 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9957
9958         * source.c (print_source_lines_base): Fix skip of '\r' if next
9959         character is '\n'.
9960
9961 2019-01-06  Tom Tromey  <tom@tromey.com>
9962
9963         * c-exp.y (struct c_parse_state) <macro_original_text,
9964         expansion_obstack>: New member.
9965         (macro_original_text, expansion_obstack): Remove globals.
9966         (scan_macro_expansion, scanning_macro_expansion)
9967         (finished_macro_expansion): Update.
9968         (scan_macro_cleanup): Remove.
9969         (yylex, c_parse): Update.
9970
9971 2019-01-06  Tom Tromey  <tom@tromey.com>
9972
9973         * c-exp.y (struct c_parse_state) <strings>: New member.
9974         (operator_stoken): Update.
9975
9976 2019-01-06  Tom Tromey  <tom@tromey.com>
9977
9978         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9979         (union type_stack_elt) <typelist_val>: Now a pointer to
9980         std::vector.
9981         (type_stack_cleanup): Don't declare.
9982         (push_typelist): Update.
9983         * parse.c (pop_typelist): Return a std::vector.
9984         (push_typelist): Take a std::vector.
9985         (follow_types): Update.  Do not free args.
9986         (type_stack_cleanup): Remove.
9987         * c-exp.y (struct c_parse_state): New.
9988         (cpstate): New global.
9989         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9990         (nonempty_typelist): Update.
9991         (func_mod): Create a new vector.
9992         (c_parse): Create a c_parse_state.
9993         (check_parameter_typelist): Do not delete params.
9994         (function_method): Update.  Do not delete type_list.
9995
9996 2019-01-06  Tom Tromey  <tom@tromey.com>
9997
9998         PR gdb/28155:
9999         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10000         check_typedef.
10001         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10002         (print_return_value): Likewise.
10003
10004 2019-01-05  Tom Tromey  <tom@tromey.com>
10005
10006         * contrib/cleanup_check.py: Remove.
10007         * contrib/gcc-with-excheck: Remove.
10008         * contrib/exsummary.py: Remove.
10009         * contrib/excheck.py: Remove.
10010
10011 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10012
10013         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10014         NULL. Initialize tpprev to NULL instead of assigning it
10015         to NULL on the next statement.
10016         * windows-nat.c (windows_delete_thread): Remove check for
10017         main_thread_id before printing thread exit notifications.
10018         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10019         Remove thread ID check against main_thread_id.
10020         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10021         windows_delete_thread.
10022         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10023
10024 2019-01-04  Tom Tromey  <tom@tromey.com>
10025
10026         * compile/compile.c (_initialize_compile): Use upper case for
10027         metasyntactic variables.
10028         * symmisc.c (_initialize_symmisc): Use upper case for
10029         metasyntactic variables.
10030         * psymtab.c (_initialize_psymtab): Use upper case for
10031         metasyntactic variables.
10032         * demangle.c (demangle_command): Use upper case for metasyntactic
10033         variables.
10034         (_initialize_demangler): Likewise.
10035         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10036         variables.
10037
10038 2019-01-03  Tom Tromey  <tom@tromey.com>
10039
10040         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10041
10042 2019-01-03  Tom Tromey  <tom@tromey.com>
10043
10044         * python/py-symtab.c (salpy_str): Update.
10045         (struct salpy_sal_object) <symtab>: Now a PyObject.
10046         (salpy_dealloc): Update.
10047         (del_objfile_sal): Use gdbpy_ref.
10048
10049 2019-01-03  Tom Tromey  <tom@tromey.com>
10050
10051         * python/py-type.c (convert_field): Use new_reference.  Return
10052         gdbpy_ref.
10053         (make_fielditem): Return gdbpy_ref.
10054         (typy_fields): Update.
10055         (typy_getitem): Update.
10056         (field_name): Return gdbpy_ref.  Use new_reference.
10057         (typy_iterator_iternext): Update.
10058
10059 2019-01-03  Tom Tromey  <tom@tromey.com>
10060
10061         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10062
10063 2019-01-03  Tom Tromey  <tom@tromey.com>
10064
10065         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10066         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10067         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10068         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10069         (pspy_set_type_printers): Likewise.
10070         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10071         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10072         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10073         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10074         (objfpy_set_type_printers): Likewise.
10075
10076 2019-01-03  Tom Tromey  <tom@tromey.com>
10077
10078         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10079         (gdbpy_print_stack): Use gdbpy_err_fetch.
10080         * python/python-internal.h (class gdbpy_err_fetch): New class.
10081         (class gdbpy_enter) <m_error_type, m_error_value,
10082         m_error_traceback>: Remove.
10083         <m_error>: New member.
10084         (gdbpy_exception_to_string): Don't declare.
10085         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10086         * python/py-value.c (convert_value_from_python): Use
10087         gdbpy_err_fetch.
10088         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10089         gdbpy_exception_to_string.
10090         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10091         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10092         gdbpy_err_fetch.
10093
10094 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10095
10096         * linux-nat.c (delete_lwp_cleanup): Delete.
10097         (struct lwp_deleter): New struct.
10098         (lwp_info_up): New typedef.
10099         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10100         lwp_info_up.
10101
10102 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10103
10104         * linux-fork.c (class scoped_switch_fork_info): New class.
10105         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10106
10107 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10108
10109         * valops.c (find_overload_match): Remove use of null_cleanup, and
10110         calls to do_cleanups.
10111
10112 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10113
10114         * compile/compile-cplus-types.c
10115         (compile_cplus_instance::decl_name): Handle changes to
10116         cp_func_name.
10117         * cp-support.c (cp_func_name): Update header comment, update
10118         return type.
10119         * cp-support.h (cp_func_name): Update return type in declaration.
10120         * valops.c (find_overload_match): Move temp_func local to top
10121         level of function and change its type.  Use temp_func to hold and
10122         delete temporary string obtained from cp_func_name.
10123
10124 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10125
10126         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10127         gdb::char_vector, remove cleanup, and update uses of `msg`.
10128
10129 2019-01-03  Jim Wilson  <jimw@sifive.com>
10130
10131         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10132
10133 2019-01-02  Tom Tromey  <tom@tromey.com>
10134
10135         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10136         (tdesc_parse_xml): Remove cleanups.
10137         * target-descriptions.h (make_cleanup_free_target_description):
10138         Don't declare.
10139         (target_desc_deleter): New struct.
10140         (target_desc_up): New typedef.
10141         * target-descriptions.c (target_desc_deleter::operator()): Rename
10142         from free_target_description.
10143         (make_cleanup_free_target_description): Remove.
10144
10145 2019-01-02  Tom Tromey  <tom@tromey.com>
10146
10147         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10148         constructor, destructor.
10149         (linespec_parser): Remove typedef.
10150         (~linespec_parser): Rename from linespec_parser_delete.
10151         (linespec_lex_to_end, linespec_complete_label)
10152         (linespec_complete): Update.
10153         (decode_line_full): Remove cleanups.
10154         (decode_line_1): Update.
10155
10156 2019-01-02  Tom Tromey  <tom@tromey.com>
10157
10158         * python/python-internal.h (inferior_to_inferior_object): Change
10159         return type.
10160         * python/py-exitedevent.c (create_exited_event_object): Update.
10161         * python/py-inferior.c (inferior_to_inferior_object): Return
10162         gdbpy_ref.
10163         (python_new_inferior, python_inferior_deleted)
10164         (thread_to_thread_object, delete_thread_object)
10165         (build_inferior_list, gdbpy_selected_inferior): Update.
10166         * python/py-infthread.c (create_thread_object): Update.  Also fail
10167         if inferior_to_inferior_object fails.
10168
10169 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10170
10171         * inferior.h (class inferior) <displaced_step_state>: New field.
10172         * infrun.h (struct displaced_step_state): Move here from
10173         infrun.c.  Initialize fields, add constructor.
10174         <inf>: Remove field.
10175         <reset>: New method.
10176         * infrun.c (struct displaced_step_inferior_state): Move to
10177         infrun.h.
10178         (displaced_step_inferior_states): Remove.
10179         (get_displaced_stepping_state): Adust.
10180         (displaced_step_in_progress_any_inferior): Adjust.
10181         (displaced_step_in_progress_thread): Adjust.
10182         (displaced_step_in_progress): Adjust.
10183         (add_displaced_stepping_state): Remove.
10184         (get_displaced_step_closure_by_addr): Adjust.
10185         (remove_displaced_stepping_state): Remove.
10186         (infrun_inferior_exit): Call displaced_step_state.reset.
10187         (use_displaced_stepping): Don't check for NULL.
10188         (displaced_step_prepare_throw): Call
10189         get_displaced_stepping_state.
10190         (displaced_step_fixup): Don't check for NULL.
10191         (prepare_for_detach): Don't check for NULL.
10192
10193 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10194
10195         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10196          in case of call that did not complete.
10197
10198 2019-01-02  Andrey Utkin  <autkin@undo.io>
10199
10200         * symfile.c (find_separate_debug_file): Fix search of debug files for
10201         remote debuggee.
10202
10203 2019-01-02  Tom Tromey  <tom@tromey.com>
10204
10205         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10206         indentation.
10207         * python/py-frame.c (frapy_older): Remove cast.
10208         (frapy_newer): Likewise.
10209         * python/py-breakpoint.c (local_setattro): Remove cast.
10210         * python/py-arch.c (archpy_name): Remove local variable.
10211         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10212
10213 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10214
10215         * unittests/basic_string_view/element_access/char/empty.cc:
10216         Fix year range in copyright header.
10217
10218 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10219
10220         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10221         Delete.
10222         <operator==>: Update with for removed field.
10223         <hash>: Likewise.
10224         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10225         <isa_features>: ...this.
10226         <abi_features>: New field.
10227         (riscv_isa_flen): Update comment.
10228         (riscv_abi_xlen): New declaration.
10229         (riscv_abi_flen): New declaration.
10230         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10231         isa_features.
10232         (riscv_abi_xlen): New function.
10233         (riscv_isa_flen): Update to get answer from isa_features.
10234         (riscv_abi_flen): New function.
10235         (riscv_has_fp_abi): Update to get answer from abi_features.
10236         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10237         xlen and flen.
10238         (riscv_call_info) <xlen, flen>: Update comment.
10239         (riscv_call_arg_struct): Remove invalid assertions
10240         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10241         is removed.
10242         (riscv_gdbarch_init): Gather isa features and abi features
10243         separately, ensure both match on the gdbarch when reusing an old
10244         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10245         a target with 64-bit float hardware.
10246
10247 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10248
10249         * source.c (search_command_helper): Stop reverse search
10250         when line 1 has been searched.
10251
10252 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10253
10254         * record-full.c (record_full_base_target::close): Rewrite
10255         record_full_core_buf_list free logic.
10256
10257 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10258
10259         * break-catch-syscall.c (print_one_catch_syscall): xfree
10260         the last text.
10261
10262 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10263
10264         * top.c (print_gdb_version): Update Copyright year in version
10265         message.
10266
10267 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10268
10269         Update copyright year range in all GDB files.
10270
10271 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10272
10273         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10274
10275 For older changes see ChangeLog-2018.
10276 \f
10277 Local Variables:
10278 mode: change-log
10279 left-margin: 8
10280 fill-column: 74
10281 version-control: never
10282 coding: utf-8
10283 End:
10284