gdb/ChangeLog

   1 2019-03-06  Pedro Alves  <palves@redhat.com>
   2
   3         * linux-fork.c (fork_info::clobber_regs): Delete.
   4         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
   5         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
   6         comment.  Adjust.
   7         (scoped_switch_fork_info::scoped_switch_fork_info)
   8         (checkpoint_command, linux_fork_context): Adjust
   9         fork_save_infrun_state calls.
  10
  11 2019-03-06  Pedro Alves  <palves@redhat.com>
  12
  13         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
  14         (inf_has_multiple_threads): Return 'bool' and rewrite using
  15         inferior_info::threads().
  16
  17 2019-03-06  Pedro Alves  <palves@redhat.com>
  18
  19         * linux-fork.c: Include <list>.
  20         (fork_list): Now a std::list instance.
  21         (fork_info): Add ctor, dtor, and in-class initialize all fields.
  22         (forks_exist_p, find_last_fork): Adjust.
  23         (new_fork): Delete.
  24         (one_fork_p): New.
  25         (add_fork): Adjust.
  26         (free_fork): Delete, folded into fork_info::~fork_info().
  27         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
  28         Adjust.
  29         (init_fork_list): Delete.
  30         (linux_fork_killall, linux_fork_mourn_inferior)
  31         (linux_fork_detach, info_checkpoints_command): Adjust.
  32         (_initialize_linux_fork): No longer call init_fork_list.
  33
  34 2019-03-06  Pedro Alves  <palves@redhat.com>
  35
  36         * linux-fork.c (new_fork): New, split out of ...
  37         (add_fork): ... this.  Return void.  Move "first fork" special
  38         case from here, to ...
  39         (checkpoint_command): ... here.
  40         * linux-linux.h (add_fork): Return void.
  41
  42 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
  43
  44         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
  45
  46 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
  47             Chris January  <chris.january@arm.com>
  48             David Lecomber  <david.lecomber@arm.com>
  49
  50         * f-exp.y: New token, UNOP_INTRINSIC.
  51         (exp): New pattern using UNOP_INTRINSIC token.
  52         (f77_keywords): Add 'abs' keyword.
  53         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
  54         (value_from_host_double): New function.
  55         (evaluate_subexp_f): Support UNOP_ABS.
  56
  57 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
  58
  59         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
  60         types.
  61
  62 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
  63
  64         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
  65         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
  66         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
  67
  68 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
  69
  70         * f-exp.y (convert_to_kind_type): Handle more type kinds.
  71
  72 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
  73             Chris January  <chris.january@arm.com>
  74
  75         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
  76         * f-exp.y: Define 'KIND' token.
  77         (exp): New pattern for KIND expressions.
  78         (ptype): Handle types with a kind extension.
  79         (direct_abs_decl): Extend to spot kind extensions.
  80         (f77_keywords): Add 'kind' to the list.
  81         (push_kind_type): New function.
  82         (convert_to_kind_type): New function.
  83         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
  84         * parse.c (operator_length_standard): Likewise.
  85         * parser-defs.h (enum type_pieces): Add tp_kind.
  86         * std-operator.def: Add UNOP_KIND.
  87
  88 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
  89
  90         * f-exp.y (f_parse): Set yydebug.
  91
  92 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
  93
  94         * f-lang.c (evaluate_subexp_f): New function.
  95         (exp_descriptor_f): New global.
  96         (f_language_defn): Use exp_descriptor_f instead of
  97         exp_descriptor_standard.
  98
  99 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 100
 101         * f-exp.y (struct token): Add comments.
 102         (dot_ops): Remove uppercase versions and the end marker.
 103         (f77_keywords): Likewise.
 104         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 105         entries in the dot_ops array are case insensitive, and use
 106         strncasecmp to compare strings.  Also some whitespace cleanup in
 107         this area.  Similar for the f77_keywords array, except entries in
 108         this list might be case sensitive.
 109
 110 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 111
 112         * f-exp.y (struct f77_boolean_val): Add comments.
 113         (boolean_values): Remove uppercase versions, and end marker.
 114         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 115         and use strncasecmp to achieve case insensitivity.  Additionally,
 116         perform whitespace cleanup around this code.
 117
 118 2019-03-06  Tom Tromey  <tromey@adacore.com>
 119
 120         * remote-sim.c (gdbsim_target_open): Use result of
 121         gdb_argv::release.
 122
 123 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 124         Dirk Schubert  <dirk.schubert@arm.com>
 125         Chris January  <chris.january@arm.com>
 126
 127         * eval.c (evaluate_subexp_standard): Call Fortran argument
 128         wrapping logic.
 129         * f-lang.c (struct value): A value which can be passed into a
 130         Fortran function call.
 131         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 132         where appropriate.
 133         (struct type): Value ready for a Fortran function call.
 134         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 135         is needed.
 136         * f-lang.h (fortran_argument_convert): Declaration.
 137         (fortran_preserve_arg_pointer): Declaration.
 138         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 139
 140 2019-03-05  Tom Tromey  <tromey@adacore.com>
 141
 142         * python/py-prettyprint.c (print_string_repr): Remove #if.
 143         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 144
 145 2019-03-05  Tom Tromey  <tromey@adacore.com>
 146
 147         * target.c (the_dummy_target): Move later.  Change type to
 148         "dummy_target".
 149         (initialize_targets): Don't initialize the_dummy_target.
 150
 151 2019-03-05  Tom Tromey  <tromey@adacore.com>
 152
 153         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 154         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 155
 156 2019-03-05  Tom Tromey  <tromey@adacore.com>
 157
 158         * windows-nat.c (windows_nat_target::attach)
 159         (windows_nat_target::detach): Don't call gdb_flush.
 160         * valprint.c (generic_val_print, val_print, val_print_string):
 161         Don't call gdb_flush.
 162         * utils.c (defaulted_query): Don't call gdb_flush.
 163         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 164         * target.c (target_announce_detach): Don't call gdb_flush.
 165         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 166         * remote.c (extended_remote_target::attach): Don't call
 167         gdb_flush.
 168         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 169         * printcmd.c (do_examine): Don't call gdb_flush.
 170         (info_display_command): Don't call gdb_flush.
 171         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 172         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 173         * memattr.c (info_mem_command): Don't call gdb_flush.
 174         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 175         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 176         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 177         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 178         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 179         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 180         (gnu_nat_target::detach): Don't call gdb_flush.
 181         * f-valprint.c (f_val_print): Don't call gdb_flush.
 182         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 183         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 184         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 185         gdb_flush.
 186         * c-valprint.c (c_val_print): Don't call gdb_flush.
 187         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 188
 189 2019-03-05  Tom Tromey  <tromey@adacore.com>
 190
 191         * varobj.c (update_dynamic_varobj_children): Update.
 192         (install_default_visualizer): Use reset, not release.
 193         * value.c (set_internalvar): Update.
 194         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 195         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 196         ATTRIBUTE_UNUSED_RESULT.
 197
 198 2019-03-05  Tom Tromey  <tromey@adacore.com>
 199
 200         * remote.c (class scoped_remote_fd) <release>: Add
 201         ATTRIBUTE_UNUSED_RESULT.
 202
 203 2019-03-05  Tom Tromey  <tromey@adacore.com>
 204
 205         * macroexp.c (struct macro_buffer) <release>: Add
 206         ATTRIBUTE_UNUSED_RESULT.
 207
 208 2019-03-05  Tom Tromey  <tromey@adacore.com>
 209
 210         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 211         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 212         ATTRIBUTE_UNUSED_RESULT.
 213
 214 2019-03-05  Tom Tromey  <tromey@adacore.com>
 215
 216         * common/scoped_fd.h (class scoped_fd) <release>: Add
 217         ATTRIBUTE_UNUSED_RESULT.
 218
 219 2019-03-05  Tom Tromey  <tromey@adacore.com>
 220
 221         * parser-defs.h (struct parser_state) <release>: Add
 222         ATTRIBUTE_UNUSED_RESULT.
 223
 224 2019-03-05  Tom Tromey  <tromey@adacore.com>
 225
 226         * utils.h (class gdb_argv) <release>: Add
 227         ATTRIBUTE_UNUSED_RESULT.
 228         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 229
 230 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 231
 232         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 233         for-loop range, to avoid compiler warnings.
 234
 235         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 236         avoid compiler warnings about unused variables.
 237
 238         * NEWS: Mention end of support for native debugging on MS-Windows
 239         before XP.
 240
 241         PR gdb/24292
 242         * common/netstuff.c:
 243         * gdbserver/gdbreplay.c
 244         * gdbserver/remote-utils.c:
 245         * ser-tcp.c:
 246         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 247         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 248         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 249         'getaddrinfo' and 'freeaddrinfo' were not available before
 250         Windows XP, and mingw.org's MinGW headers by default define
 251         _WIN32_WINNT to 0x500.
 252
 253 2019-03-01  Gary Benson <gbenson@redhat.com>
 254
 255         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
 256
 257 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
 258             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 259
 260         PR gdb/8527
 261         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 262         set_sigint_trap, clear_sigint_trap.
 263
 264 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 265
 266         * target.c (target_detach): Clear the regcache and the
 267         frame cache.
 268
 269 2019-02-27  Pedro Alves  <palves@redhat.com>
 270
 271         * utils.c (set_screen_size): When we cap the height/width sizes,
 272         tweak the corresponding command variable to show "unlimited":
 273
 274 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
 275             Pedro Alves  <palves@redhat.com>
 276
 277         * utils.c (set_screen_size): Reduce "infinite" rows and columns
 278         before calling rl_set_screen_size.
 279
 280 2019-02-27  Tom Tromey  <tromey@adacore.com>
 281
 282         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
 283         define.
 284         * python/py-value.c: Remove Python 2.4 workaround.
 285         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
 286         workaround.
 287         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
 288         Python 2.4 workaround.
 289         * python/python-internal.h: Remove Python 2.4 comment.
 290         (Py_ssize_t): Don't define.
 291         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
 292         (gdb_Py_DECREF): Remove Python 2.4 workaround.
 293         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
 294         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
 295         * python/python.c (do_start_initialization): Remove Python 2.4
 296         workaround.
 297         * python/py-prettyprint.c (class dummy_python_frame): Remove.
 298         (print_children): Remove Python 2.4 workaround.
 299         * python/py-inferior.c (buffer_procs): Remove Python 2.4
 300         workaround.
 301         (CHARBUFFERPROC_NAME): Remove.
 302         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
 303         Python 2.4 workaround.
 304
 305 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 306
 307         * NEWS: Note minimum Python version.
 308
 309 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 310
 311         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
 312         code from these functions.  Remove corresponding ifdefs.  Use
 313         Py_buffer_up instead of explicit calls to PyBuffer_Release.
 314         Remove gotos and target of gotos.
 315         (infpy_search_memory): Likewise.
 316
 317 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 318
 319         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
 320         (hppa_gdbarch_init): Don't register deleted functions with
 321         gdbarch.
 322
 323 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 324
 325         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
 326         (h8300_unwind_sp): Delete.
 327         (h8300_dummy_id): Delete.
 328         (h8300_gdbarch_init): Don't register deleted functions with
 329         gdbarch.
 330
 331 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 332
 333         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
 334         (ft32_unwind_pc): Delete.
 335         (ft32_unwind_sp): Delete.
 336         (ft32_gdbarch_init): Don't register deleted functions with
 337         gdbarch.
 338
 339 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 340
 341         * gdb/frv-tdep.c (frv_dummy_id): Delete.
 342         (frv_unwind_pc): Delete.
 343         (frv_unwind_sp): Delete.
 344         (frv_gdbarch_init): Don't register deleted functions with
 345         gdbarch.
 346
 347 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 348
 349         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
 350         (riscv_unwind_pc): Delete.
 351         (riscv_unwind_sp): Delete.
 352         (riscv_gdbarch_init): Don't register deleted functions with
 353         gdbarch.
 354
 355 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 356
 357         * gdb/csky-tdep.c (csky_dummy_id): Delete.
 358         (csky_unwind_pc): Delete.
 359         (csky_unwind_sp): Delete.
 360         (csky_gdbarch_init): Don't register deleted functions with
 361         gdbarch.
 362
 363 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 364
 365         * gdb/cris-tdep.c (cris_dummy_id): Delete.
 366         (cris_unwind_pc): Delete.
 367         (cris_unwind_sp): Delete.
 368         (cris_gdbarch_init): Don't register deleted functions with
 369         gdbarch.
 370
 371 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 372
 373         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
 374         (bfin_unwind_pc): Delete.
 375         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
 376
 377 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 378
 379         * gdb/arm-tdep.c (arm_dummy_id): Delete.
 380         (arm_unwind_pc): Delete.
 381         (arm_unwind_sp): Delete.
 382         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
 383
 384 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 385
 386         * gdb/arc-tdep.c (arc_dummy_id): Delete.
 387         (arc_unwind_pc): Delete.
 388         (arc_unwind_sp): Delete.
 389         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
 390
 391 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 392
 393         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
 394         (alpha_unwind_pc): Delete.
 395         (alpha_gdbarch_init): Don't register deleted functions with
 396         gdbarch.
 397
 398 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 399
 400         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
 401         (aarch64_unwind_pc): Delete.
 402         (aarch64_unwind_sp): Delete.
 403         (aarch64_gdbarch_init): Don't register deleted functions with
 404         gdbarch.
 405
 406 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 407
 408         * gdbtypes.c (type_align): Don't consider static members when
 409         computing structure alignment.
 410
 411 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 412
 413         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
 414         return 0 for other types.
 415         * arch-utils.c (default_type_align): Always return 0.
 416         * gdbarch.h: Regenerate.
 417         * gdbarch.sh (type_align): Extend comment.
 418         * gdbtypes.c (type_align): Add additional comments, always call
 419         gdbarch_type_align before applying the default rules.
 420         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
 421         generic code will then apply a suitable default.
 422         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
 423         types, return 0 for other types.
 424
 425 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 426
 427         * NEWS: Create a new section for the next release branch.
 428         Rename the section of the current branch, now that it has
 429         been cut.
 430
 431 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 432
 433         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 434         * version.in: Bump version to 8.3.50.DATE-git.
 435
 436 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 437
 438         * aix-thread.c (ptid_cmp): Remove unused variable.
 439         (get_signaled_thread): Likewise.
 440         (store_regs_user_thread): Likewise.
 441         (store_regs_kernel_thread): Likewise.
 442         (fetch_regs_kernel_thread): Remove shadowed variable.
 443
 444 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 445
 446         * features/riscv/32bit-cpu.xml: Add register numbers.
 447         * features/riscv/32bit-fpu.c: Regenerate.
 448         * features/riscv/32bit-fpu.xml: Add register numbers.
 449         * features/riscv/64bit-cpu.xml: Add register numbers.
 450         * features/riscv/64bit-fpu.c: Regenerate.
 451         * features/riscv/64bit-fpu.xml: Add register numbers.
 452
 453 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 454
 455         * NEWS: Mention two argument form of gdb.Value constructor.
 456         * python/py-value.c (convert_buffer_and_type_to_value): New
 457         function.
 458         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 459         Add support for handling an optional second argument.  Call
 460         convert_buffer_and_type_to_value as appropriate.
 461         * python/python-internal.h (Py_buffer_deleter): New struct.
 462         (Py_buffer_up): New typedef.
 463
 464 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 465
 466         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 467         instead of releasing ownership.
 468
 469 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 470
 471         * dwarf2read.c (open_and_init_dwp_file): Call
 472         elf_numsections instead of bfd_count_sections to initialize
 473         dwp_file->num_sections.
 474
 475 2019-02-25  Tom Tromey  <tromey@adacore.com>
 476
 477         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 478
 479 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 480
 481         * gcore.in: Add '--readnever' option when invoking GDB.
 482
 483 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 484
 485         * MAINTAINERS: Update my email address.
 486
 487 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 488
 489         * build-id.c (build_id_to_debug_bfd_1): New function.
 490         (build_id_to_debug_bfd): Look for separate debug file in
 491         sysroot.
 492
 493 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 494
 495         * gdbarch.sh: Update the copyright year range that is placed into
 496         generated files.
 497
 498 2019-02-22  Keith Seitz  <keiths@redhat.com>
 499
 500         PR symtab/23853
 501         * linespec.c (create_sals_line_offset): Search for the default
 502         symtab's filename instead of its fullname.
 503
 504 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 505
 506         * NEWS: Update style defaults.
 507
 508 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 509
 510         * main.c (captured_main_1): Disable styling in batch mode.
 511
 512 2019-02-20  Tom Tromey  <tom@tromey.com>
 513
 514         * symtab.c (symtab_symbol_info): Fix typos.
 515
 516 2019-02-20  Tom Tromey  <tromey@adacore.com>
 517
 518         * findcmd.c (_initialize_mem_search): Use upper case for
 519         metasyntactic variables.
 520
 521 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 522
 523         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 524         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 525
 526 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 527
 528         * top.h (source_file_name): Change to std::string.
 529         * top.c (source_file_name): Likewise.
 530         (command_line_input): Adjust.
 531         * cli/cli-script.c (script_from_file): Adjust.
 532
 533 2019-02-19  Tom Tromey  <tromey@adacore.com>
 534
 535         * ravenscar-thread.c
 536         (ravenscar_thread_target::update_thread_list): Don't call
 537         ada_build_task_list.
 538         * ada-lang.h (ada_build_task_list): Don't declare.
 539         * ada-tasks.c (struct ada_tasks_inferior_data)
 540         <task_list_valid_p>: Now bool.
 541         (read_known_tasks, ada_task_list_changed)
 542         (ada_tasks_invalidate_inferior_data): Update.
 543         (read_known_tasks_array): Return bool.
 544         (read_known_tasks_list): Likewise.
 545         (read_known_tasks): Return void.
 546         (ada_build_task_list): Now static.
 547
 548 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 549
 550         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 551         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 552
 553 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 554
 555         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 556         variant for ada_tasks_pspace_data_handle and
 557         ada_tasks_inferior_data_handle.
 558         (ada_tasks_pspace_data_cleanup): New function.
 559         (ada_tasks_inferior_data_cleanup): New function.
 560
 561 2019-02-17  Tom Tromey  <tom@tromey.com>
 562
 563         * macrotab.h (macro_source_fullname): Return a std::string.
 564         * macrotab.c (macro_include, check_for_redefinition)
 565         (macro_undef, macro_lookup_definition, foreach_macro)
 566         (foreach_macro_in_scope): Update.
 567         (macro_source_fullname): Return a std::string.
 568         * macrocmd.c (show_pp_source_pos): Update.
 569
 570 2019-02-17  Tom Tromey  <tom@tromey.com>
 571
 572         * macrocmd.c (show_pp_source_pos): Style the file names.
 573
 574 2019-02-17  Tom Tromey  <tom@tromey.com>
 575
 576         PR tui/24197:
 577         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 578
 579 2019-02-17  Tom Tromey  <tom@tromey.com>
 580
 581         * ada-lang.c (user_select_syms): Use filtered printing.
 582         * utils.c (wrap_style): New global.
 583         (desired_style): Remove.
 584         (emit_style_escape): Add stream parameter.
 585         (set_output_style, reset_terminal_style, prompt_for_continue):
 586         Update.
 587         (flush_wrap_buffer): Only flush gdb_stdout.
 588         (wrap_here): Set wrap_style.
 589         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 590         treat escape sequences as a character.  Change when wrap buffer is
 591         flushed.
 592         (fputs_styled): Do not set the output style when the default is
 593         requested.
 594         * ui-style.h (struct ui_file_style) <is_default>: New method.
 595         * source.c (print_source_lines_base): Emit escape sequences in one
 596         piece.
 597
 598 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 599
 600         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 601         integers and enumeration types.
 602
 603 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 604
 605         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 606         instead of lookup_symbol_in_language
 607         (do_exact_match): New function.
 608         (ada_get_symbol_name_matcher): Return do_exact_match when
 609         doing a verbatim match.
 610
 611 2019-02-15  Tom Tromey  <tromey@adacore.com>
 612
 613         * ravenscar-thread.c (ravenscar_thread_target::resume)
 614         (ravenscar_thread_target::wait): Special case wildcard requests.
 615
 616 2019-02-15  Tom Tromey  <tromey@adacore.com>
 617
 618         * ravenscar-thread.c (base_ptid): Remove.
 619         (struct ravenscar_thread_target) <close>: New method.
 620         <m_base_ptid>: New member.
 621         <update_inferior_ptid, active_task, task_is_currently_active,
 622         runtime_initialized>: Declare methods.
 623         <ravenscar_thread_target>: Add constructor.
 624         (ravenscar_thread_target::task_is_currently_active)
 625         (ravenscar_thread_target::update_inferior_ptid)
 626         (ravenscar_runtime_initialized): Rename.  Now methods.
 627         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 628         (ravenscar_thread_target::update_thread_list): Update.
 629         (ravenscar_thread_target::active_task): Now method.
 630         (ravenscar_thread_target::store_registers)
 631         (ravenscar_thread_target::prepare_to_store)
 632         (ravenscar_thread_target::prepare_to_store)
 633         (ravenscar_thread_target::mourn_inferior): Update.
 634         (ravenscar_inferior_created): Use "new" to create target.
 635         (ravenscar_thread_target::get_ada_task_ptid): Update.
 636         (_initialize_ravenscar): Don't initialize base_ptid.
 637         (ravenscar_ops): Remove global.
 638
 639 2019-02-15  Tom Tromey  <tromey@adacore.com>
 640
 641         * target.h (push_target): Declare new overload.
 642         * target.c (push_target): New overload, taking an rvalue reference.
 643         * remote.c (remote_target::open_1): Use push_target overload.
 644         * corelow.c (core_target_open): Use push_target overload.
 645
 646 2019-02-15  Tom Tromey  <tromey@adacore.com>
 647
 648         * ravenscar-thread.c (is_ravenscar_task)
 649         (ravenscar_task_is_currently_active): Return bool.
 650         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 651         (_initialize_ravenscar): Remove "(void)".
 652         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 653         Return bool.
 654
 655 2019-02-15  Tom Tromey  <tromey@adacore.com>
 656
 657         * ravenscar-thread.c (ravenscar_runtime_initializer)
 658         (has_ravenscar_runtime, get_running_thread_id)
 659         (ravenscar_thread_target::resume): Fix indentation.
 660
 661 2019-02-15  Tom Tromey  <tromey@adacore.com>
 662
 663         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 664         from ravenscar_arch_ops.
 665         (sparc_ravenscar_ops::fetch_registers)
 666         (sparc_ravenscar_ops::store_registers): Now methods.
 667         (sparc_ravenscar_prepare_to_store): Remove.
 668         (sparc_ravenscar_ops): Redefine.
 669         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 670         methods and destructor.  Remove members.
 671         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 672         (ravenscar_thread_target::store_registers)
 673         (ravenscar_thread_target::prepare_to_store): Update.
 674         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 675         Remove.
 676         (struct ppc_ravenscar_powerpc_ops): Derive from
 677         ravenscar_arch_ops.
 678         (ppc_ravenscar_powerpc_ops::fetch_registers)
 679         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 680         (ppc_ravenscar_powerpc_ops): Redefine.
 681         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 682         (ppc_ravenscar_e500_ops::fetch_registers)
 683         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 684         (ppc_ravenscar_e500_ops): Redefine.
 685         * aarch64-ravenscar-thread.c
 686         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 687         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 688         (aarch64_ravenscar_fetch_registers)
 689         (aarch64_ravenscar_store_registers): Now methods.
 690         (aarch64_ravenscar_ops): Redefine.
 691
 692 2019-02-15  Tom Tromey  <tromey@adacore.com>
 693
 694         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 695         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 696         (ravenscar_thread_target::stopped_by_watchpoint)
 697         (ravenscar_thread_target::stopped_data_address)
 698         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 699
 700 2019-02-15  Tom Tromey  <tromey@adacore.com>
 701
 702         * ravenscar-thread.c: Fix some typos.
 703
 704 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 705             Tom Tromey  <tromey@adacore.com>
 706
 707         * ada-lang.c (ada_exception_sal): Change addr_string to a
 708         std::string.
 709         (create_ada_exception_catchpoint): Update.
 710
 711 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 712             Tom Tromey  <tromey@adacore.com>
 713
 714         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 715         (bp_location_ops): Remove.
 716         (base_breakpoint_allocate_location): Update.
 717         (free_bp_location): Update.
 718         * ada-lang.c (class ada_catchpoint_location)
 719         <ada_catchpoint_location>: Remove ops parameter.
 720         (ada_catchpoint_location_dtor): Remove.
 721         (ada_catchpoint_location_ops): Remove.
 722         (allocate_location_exception): Update.
 723         * breakpoint.h (struct bp_location_ops): Remove.
 724         (class bp_location) <bp_location>: Remove bp_location_ops
 725         parameter.
 726         <~bp_location>: Add destructor.
 727         <ops>: Remove.
 728
 729 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 730             Pedro Alves  <palves@redhat.com>
 731
 732         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 733         'PATH_MAX'.
 734
 735 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 736             Samuel Thibault  <samuel.thibault@gnu.org>
 737             Thomas Schwinge  <thomas@codesourcery.com>
 738
 739         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 740         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 741
 742 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 743
 744         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 745         (check_empty): Use "const char *".
 746
 747         * gnu-nat.c (gnu_nat_target::detach): Instead of
 748         'detach_inferior (pid)' call
 749         'detach_inferior (find_inferior_pid (pid))'.
 750
 751         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 752         'nat/fork-inferior.o'.
 753         * gnu-nat.c: #include "nat/fork-inferior.h".
 754
 755         * gnu-nat.c (gnu_nat_target::detach): Instead of
 756         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 757         * gnu-nat.h: #include "inf-child.h".
 758         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 759         'i386_gnu_nat_target::fetch_registers'.
 760         (gnu_store_registers): Rename/move to
 761         'i386_gnu_nat_target::store_registers'.
 762
 763         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 764         * gnu-nat.h (mach_thread_info): New function.
 765         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 766
 767         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 768
 769 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 770
 771         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 772
 773 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 774
 775         * windows-nat.c (windows_add_thread): Add new parameter
 776         "main_thread_p" with default value set to false.  Update
 777         function documentation as well as all callers.
 778         (windows_delete_thread): Likewise.
 779         (fake_create_process): Update call to windows_add_thread.
 780         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 781         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 782         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 783         call to windows_delete_thread.
 784
 785 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 786
 787         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 788
 789 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 790
 791         * symfile.c (find_separate_debug_file): Use canonical path of
 792         sysroot with child_path instead of gdb_sysroot if it is valid.
 793
 794 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 795
 796         * symfile.c (find_separate_debug_file): Use child_path to
 797         determine if an object file is under a sysroot.
 798
 799 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 800
 801         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 802         unittests/child-path-selftests.c.
 803         * common/pathstuff.c (child_path): New function.
 804         * common/pathstuff.h (child_path): New prototype.
 805         * unittests/child-path-selftests.c: New file.
 806
 807 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 808
 809         * symfile.c (find_separate_debug_file): Look for separate debug
 810         files in debug directories under the sysroot.
 811
 812 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 813
 814         * symtab.h (struct minimal_symbol data_p): New const method.
 815         (struct minimal_symbol text_p): Likewise.
 816         * symtab.c (output_source_filename): Use file name style
 817         to print file name.
 818         (print_symbol_info): Likewise.
 819         (print_msymbol_info): Use address style to print addresses.
 820         Use function name style to print executable text symbols.
 821         (expand_symtab_containing_pc): Use data_p.
 822         (find_pc_sect_compunit_symtab): Likewise.
 823
 824 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 825
 826         * breakpoint.c (describe_other_breakpoints): Use address style
 827         to print addresses.
 828         (say_where): Likewise.
 829
 830 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 831
 832         * ada-typeprint.c (print_func_type): Print function name
 833         style to print function name.
 834         * c-typeprint.c (c_print_type_1): Likewise.
 835
 836 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 837
 838         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 839         for execve.
 840
 841 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 842
 843         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 844         type_stack.
 845
 846 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 847
 848         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 849         TYPE_CODE_REF types.
 850
 851 2019-02-08  Jim Wilson  <jimw@sifive.com>
 852
 853         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 854         (riscv_linux_fregset): New.
 855         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 856
 857 2019-02-07  Tom Tromey  <tom@tromey.com>
 858
 859         * thread.c (thread_cancel_execution_command): Update.
 860         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 861         methods.
 862         (struct thread_fsm_ops): Remove.
 863         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 864         (thread_fsm_should_stop, thread_fsm_return_value)
 865         (thread_fsm_set_finished, thread_fsm_finished_p)
 866         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 867         Don't declare.
 868         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 869         * infrun.c (clear_proceed_status_thread)
 870         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 871         (print_stop_event): Update.
 872         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 873         Add constructor.
 874         (step_command_fsm_ops): Remove.
 875         (new_step_command_fsm): Remove.
 876         (step_1): Update.
 877         (step_command_fsm::should_stop): Rename from
 878         step_command_fsm_should_stop.
 879         (step_command_fsm::clean_up): Rename from
 880         step_command_fsm_clean_up.
 881         (step_command_fsm::do_async_reply_reason): Rename from
 882         step_command_fsm_async_reply_reason.
 883         (struct until_next_fsm): Inherit from thread_fsm.  Add
 884         constructor.
 885         (until_next_fsm_ops): Remove.
 886         (new_until_next_fsm): Remove.
 887         (until_next_fsm::should_stop): Rename from
 888         until_next_fsm_should_stop.
 889         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 890         (until_next_fsm::do_async_reply_reason): Rename from
 891         until_next_fsm_async_reply_reason.
 892         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 893         constructor.  Change type of breakpoint.
 894         (finish_command_fsm_ops): Remove.
 895         (new_finish_command_fsm): Remove.
 896         (finish_command_fsm::should_stop): Rename from
 897         finish_command_fsm_should_stop.
 898         (finish_command_fsm::clean_up): Rename from
 899         finish_command_fsm_clean_up.
 900         (finish_command_fsm::return_value): Rename from
 901         finish_command_fsm_return_value.
 902         (finish_command_fsm::do_async_reply_reason): Rename from
 903         finish_command_fsm_async_reply_reason.
 904         (finish_command): Update.
 905         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 906         Add constructor.
 907         (call_thread_fsm_ops): Remove.
 908         (call_thread_fsm::call_thread_fsm): Rename from
 909         new_call_thread_fsm.
 910         (call_thread_fsm::should_stop): Rename from
 911         call_thread_fsm_should_stop.
 912         (call_thread_fsm::should_notify_stop): Rename from
 913         call_thread_fsm_should_notify_stop.
 914         (run_inferior_call, call_function_by_hand_dummy): Update.
 915         * cli/cli-interp.c (should_print_stop_to_console): Update.
 916         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 917         Add constructor.  Change type of location_breakpoint,
 918         caller_breakpoint.
 919         (until_break_fsm_ops): Remove.
 920         (new_until_break_fsm): Remove.
 921         (until_break_fsm::should_stop): Rename from
 922         until_break_fsm_should_stop.
 923         (until_break_fsm::clean_up): Rename from
 924         until_break_fsm_clean_up.
 925         (until_break_fsm::do_async_reply_reason): Rename from
 926         until_break_fsm_async_reply_reason.
 927         (until_break_command): Update.
 928         * thread-fsm.c: Remove.
 929         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 930
 931 2019-02-07  Tom Tromey  <tom@tromey.com>
 932
 933         * yy-remap.h: Add include guard.
 934         * xtensa-tdep.h: Add include guard.
 935         * xcoffread.h: Rename include guard.
 936         * varobj-iter.h: Add include guard.
 937         * tui/tui.h: Rename include guard.
 938         * tui/tui-winsource.h: Rename include guard.
 939         * tui/tui-wingeneral.h: Rename include guard.
 940         * tui/tui-windata.h: Rename include guard.
 941         * tui/tui-win.h: Rename include guard.
 942         * tui/tui-stack.h: Rename include guard.
 943         * tui/tui-source.h: Rename include guard.
 944         * tui/tui-regs.h: Rename include guard.
 945         * tui/tui-out.h: Rename include guard.
 946         * tui/tui-layout.h: Rename include guard.
 947         * tui/tui-io.h: Rename include guard.
 948         * tui/tui-hooks.h: Rename include guard.
 949         * tui/tui-file.h: Rename include guard.
 950         * tui/tui-disasm.h: Rename include guard.
 951         * tui/tui-data.h: Rename include guard.
 952         * tui/tui-command.h: Rename include guard.
 953         * tic6x-tdep.h: Add include guard.
 954         * target/waitstatus.h: Rename include guard.
 955         * target/wait.h: Rename include guard.
 956         * target/target.h: Rename include guard.
 957         * target/resume.h: Rename include guard.
 958         * target-float.h: Rename include guard.
 959         * stabsread.h: Add include guard.
 960         * rs6000-tdep.h: Add include guard.
 961         * riscv-fbsd-tdep.h: Add include guard.
 962         * regformats/regdef.h: Rename include guard.
 963         * record.h: Rename include guard.
 964         * python/python.h: Rename include guard.
 965         * python/python-internal.h: Rename include guard.
 966         * python/py-stopevent.h: Rename include guard.
 967         * python/py-ref.h: Rename include guard.
 968         * python/py-record.h: Rename include guard.
 969         * python/py-record-full.h: Rename include guard.
 970         * python/py-record-btrace.h: Rename include guard.
 971         * python/py-instruction.h: Rename include guard.
 972         * python/py-events.h: Rename include guard.
 973         * python/py-event.h: Rename include guard.
 974         * procfs.h: Add include guard.
 975         * proc-utils.h: Add include guard.
 976         * p-lang.h: Add include guard.
 977         * or1k-tdep.h: Rename include guard.
 978         * observable.h: Rename include guard.
 979         * nto-tdep.h: Rename include guard.
 980         * nat/x86-linux.h: Rename include guard.
 981         * nat/x86-linux-dregs.h: Rename include guard.
 982         * nat/x86-gcc-cpuid.h: Add include guard.
 983         * nat/x86-dregs.h: Rename include guard.
 984         * nat/x86-cpuid.h: Rename include guard.
 985         * nat/ppc-linux.h: Rename include guard.
 986         * nat/mips-linux-watch.h: Rename include guard.
 987         * nat/linux-waitpid.h: Rename include guard.
 988         * nat/linux-ptrace.h: Rename include guard.
 989         * nat/linux-procfs.h: Rename include guard.
 990         * nat/linux-osdata.h: Rename include guard.
 991         * nat/linux-nat.h: Rename include guard.
 992         * nat/linux-namespaces.h: Rename include guard.
 993         * nat/linux-btrace.h: Rename include guard.
 994         * nat/glibc_thread_db.h: Rename include guard.
 995         * nat/gdb_thread_db.h: Rename include guard.
 996         * nat/gdb_ptrace.h: Rename include guard.
 997         * nat/fork-inferior.h: Rename include guard.
 998         * nat/amd64-linux-siginfo.h: Rename include guard.
 999         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1000         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1001         * nat/aarch64-linux.h: Rename include guard.
1002         * nat/aarch64-linux-hw-point.h: Rename include guard.
1003         * mn10300-tdep.h: Add include guard.
1004         * mips-linux-tdep.h: Add include guard.
1005         * mi/mi-parse.h: Rename include guard.
1006         * mi/mi-out.h: Rename include guard.
1007         * mi/mi-main.h: Rename include guard.
1008         * mi/mi-interp.h: Rename include guard.
1009         * mi/mi-getopt.h: Rename include guard.
1010         * mi/mi-console.h: Rename include guard.
1011         * mi/mi-common.h: Rename include guard.
1012         * mi/mi-cmds.h: Rename include guard.
1013         * mi/mi-cmd-break.h: Rename include guard.
1014         * m2-lang.h: Add include guard.
1015         * location.h: Rename include guard.
1016         * linux-record.h: Rename include guard.
1017         * linux-nat.h: Add include guard.
1018         * linux-fork.h: Add include guard.
1019         * i386-darwin-tdep.h: Rename include guard.
1020         * hppa-linux-offsets.h: Add include guard.
1021         * guile/guile.h: Rename include guard.
1022         * guile/guile-internal.h: Rename include guard.
1023         * gnu-nat.h: Rename include guard.
1024         * gdb-stabs.h: Rename include guard.
1025         * frv-tdep.h: Add include guard.
1026         * f-lang.h: Add include guard.
1027         * event-loop.h: Add include guard.
1028         * darwin-nat.h: Rename include guard.
1029         * cp-abi.h: Rename include guard.
1030         * config/sparc/nm-sol2.h: Rename include guard.
1031         * config/nm-nto.h: Rename include guard.
1032         * config/nm-linux.h: Add include guard.
1033         * config/i386/nm-i386gnu.h: Rename include guard.
1034         * config/djgpp/nl_types.h: Rename include guard.
1035         * config/djgpp/langinfo.h: Rename include guard.
1036         * compile/gcc-cp-plugin.h: Add include guard.
1037         * compile/gcc-c-plugin.h: Add include guard.
1038         * compile/compile.h: Rename include guard.
1039         * compile/compile-object-run.h: Rename include guard.
1040         * compile/compile-object-load.h: Rename include guard.
1041         * compile/compile-internal.h: Rename include guard.
1042         * compile/compile-cplus.h: Rename include guard.
1043         * compile/compile-c.h: Rename include guard.
1044         * common/xml-utils.h: Rename include guard.
1045         * common/x86-xstate.h: Rename include guard.
1046         * common/version.h: Rename include guard.
1047         * common/vec.h: Rename include guard.
1048         * common/tdesc.h: Rename include guard.
1049         * common/selftest.h: Rename include guard.
1050         * common/scoped_restore.h: Rename include guard.
1051         * common/scoped_mmap.h: Rename include guard.
1052         * common/scoped_fd.h: Rename include guard.
1053         * common/safe-iterator.h: Rename include guard.
1054         * common/run-time-clock.h: Rename include guard.
1055         * common/refcounted-object.h: Rename include guard.
1056         * common/queue.h: Rename include guard.
1057         * common/ptid.h: Rename include guard.
1058         * common/print-utils.h: Rename include guard.
1059         * common/preprocessor.h: Rename include guard.
1060         * common/pathstuff.h: Rename include guard.
1061         * common/observable.h: Rename include guard.
1062         * common/netstuff.h: Rename include guard.
1063         * common/job-control.h: Rename include guard.
1064         * common/host-defs.h: Rename include guard.
1065         * common/gdb_wait.h: Rename include guard.
1066         * common/gdb_vecs.h: Rename include guard.
1067         * common/gdb_unlinker.h: Rename include guard.
1068         * common/gdb_unique_ptr.h: Rename include guard.
1069         * common/gdb_tilde_expand.h: Rename include guard.
1070         * common/gdb_sys_time.h: Rename include guard.
1071         * common/gdb_string_view.h: Rename include guard.
1072         * common/gdb_splay_tree.h: Rename include guard.
1073         * common/gdb_setjmp.h: Rename include guard.
1074         * common/gdb_ref_ptr.h: Rename include guard.
1075         * common/gdb_optional.h: Rename include guard.
1076         * common/gdb_locale.h: Rename include guard.
1077         * common/gdb_assert.h: Rename include guard.
1078         * common/filtered-iterator.h: Rename include guard.
1079         * common/filestuff.h: Rename include guard.
1080         * common/fileio.h: Rename include guard.
1081         * common/environ.h: Rename include guard.
1082         * common/common-utils.h: Rename include guard.
1083         * common/common-types.h: Rename include guard.
1084         * common/common-regcache.h: Rename include guard.
1085         * common/common-inferior.h: Rename include guard.
1086         * common/common-gdbthread.h: Rename include guard.
1087         * common/common-exceptions.h: Rename include guard.
1088         * common/common-defs.h: Rename include guard.
1089         * common/common-debug.h: Rename include guard.
1090         * common/cleanups.h: Rename include guard.
1091         * common/buffer.h: Rename include guard.
1092         * common/btrace-common.h: Rename include guard.
1093         * common/break-common.h: Rename include guard.
1094         * cli/cli-utils.h: Rename include guard.
1095         * cli/cli-style.h: Rename include guard.
1096         * cli/cli-setshow.h: Rename include guard.
1097         * cli/cli-script.h: Rename include guard.
1098         * cli/cli-interp.h: Rename include guard.
1099         * cli/cli-decode.h: Rename include guard.
1100         * cli/cli-cmds.h: Rename include guard.
1101         * charset-list.h: Add include guard.
1102         * buildsym-legacy.h: Rename include guard.
1103         * bfin-tdep.h: Add include guard.
1104         * ax.h: Rename include guard.
1105         * arm-linux-tdep.h: Add include guard.
1106         * arm-fbsd-tdep.h: Add include guard.
1107         * arch/xtensa.h: Rename include guard.
1108         * arch/tic6x.h: Add include guard.
1109         * arch/i386.h: Add include guard.
1110         * arch/arm.h: Rename include guard.
1111         * arch/arm-linux.h: Rename include guard.
1112         * arch/arm-get-next-pcs.h: Rename include guard.
1113         * arch/amd64.h: Add include guard.
1114         * arch/aarch64-insn.h: Rename include guard.
1115         * arch-utils.h: Rename include guard.
1116         * annotate.h: Add include guard.
1117         * amd64-darwin-tdep.h: Rename include guard.
1118         * aarch64-linux-tdep.h: Add include guard.
1119         * aarch64-fbsd-tdep.h: Add include guard.
1120         * aarch32-linux-nat.h: Add include guard.
1121
1122 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1123
1124         * macrotab.c (macro_define_internal): New function that
1125         factorizes macro_define_object_internal and macro_define_function
1126         code.
1127         (macro_define_object_internal): Use macro_define_internal.
1128         (macro_define_function): Likewise.
1129
1130 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1131
1132         * macrocmd.c (extract_identifier): Return
1133         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1134         callers.
1135
1136 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1137
1138         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1139
1140 2019-02-05  Tom Tromey  <tom@tromey.com>
1141
1142         * target.c (target_stack::unpush): Move assertion earlier.
1143
1144 2019-01-30  Tom Tromey  <tom@tromey.com>
1145
1146         PR python/23615:
1147         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1148         (gdbpy_parse_and_eval): Likewise.
1149         * python/python-internal.h (gdbpy_allow_threads): New class.
1150
1151 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1152
1153         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1154         (aarch64_fbsd_fpregmap): Move earlier.
1155         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1156         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1157         instead of individual calls to trad_frame_set_reg_addr.
1158         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1159         earlier.
1160         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1161         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1162         instead of individual calls to trad_frame_set_reg_addr.
1163
1164 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1165
1166         * CONTRIBUTE: Replace contribution list with wiki link.
1167
1168 2019-01-25  Tom Tromey  <tom@tromey.com>
1169
1170         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1171
1172 2019-01-25  Tom Tromey  <tom@tromey.com>
1173
1174         * xtensa-linux-nat.c: Fix common/ includes.
1175         * xml-support.h: Fix common/ includes.
1176         * xml-support.c: Fix common/ includes.
1177         * x86-linux-nat.c: Fix common/ includes.
1178         * windows-nat.c: Fix common/ includes.
1179         * varobj.h: Fix common/ includes.
1180         * varobj.c: Fix common/ includes.
1181         * value.c: Fix common/ includes.
1182         * valops.c: Fix common/ includes.
1183         * utils.c: Fix common/ includes.
1184         * unittests/xml-utils-selftests.c: Fix common/ includes.
1185         * unittests/utils-selftests.c: Fix common/ includes.
1186         * unittests/unpack-selftests.c: Fix common/ includes.
1187         * unittests/tracepoint-selftests.c: Fix common/ includes.
1188         * unittests/style-selftests.c: Fix common/ includes.
1189         * unittests/string_view-selftests.c: Fix common/ includes.
1190         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1191         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1192         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1193         * unittests/rsp-low-selftests.c: Fix common/ includes.
1194         * unittests/parse-connection-spec-selftests.c: Fix common/
1195         includes.
1196         * unittests/optional-selftests.c: Fix common/ includes.
1197         * unittests/offset-type-selftests.c: Fix common/ includes.
1198         * unittests/observable-selftests.c: Fix common/ includes.
1199         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1200         * unittests/memrange-selftests.c: Fix common/ includes.
1201         * unittests/memory-map-selftests.c: Fix common/ includes.
1202         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1203         * unittests/function-view-selftests.c: Fix common/ includes.
1204         * unittests/environ-selftests.c: Fix common/ includes.
1205         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1206         * unittests/common-utils-selftests.c: Fix common/ includes.
1207         * unittests/cli-utils-selftests.c: Fix common/ includes.
1208         * unittests/array-view-selftests.c: Fix common/ includes.
1209         * ui-file.c: Fix common/ includes.
1210         * tui/tui-io.c: Fix common/ includes.
1211         * tracepoint.h: Fix common/ includes.
1212         * tracepoint.c: Fix common/ includes.
1213         * tracefile-tfile.c: Fix common/ includes.
1214         * top.h: Fix common/ includes.
1215         * top.c: Fix common/ includes.
1216         * thread.c: Fix common/ includes.
1217         * target/waitstatus.h: Fix common/ includes.
1218         * target/waitstatus.c: Fix common/ includes.
1219         * target.h: Fix common/ includes.
1220         * target.c: Fix common/ includes.
1221         * target-memory.c: Fix common/ includes.
1222         * target-descriptions.c: Fix common/ includes.
1223         * symtab.h: Fix common/ includes.
1224         * symfile.c: Fix common/ includes.
1225         * stap-probe.c: Fix common/ includes.
1226         * spu-linux-nat.c: Fix common/ includes.
1227         * sparc-nat.c: Fix common/ includes.
1228         * source.c: Fix common/ includes.
1229         * solib.c: Fix common/ includes.
1230         * solib-target.c: Fix common/ includes.
1231         * ser-unix.c: Fix common/ includes.
1232         * ser-tcp.c: Fix common/ includes.
1233         * ser-pipe.c: Fix common/ includes.
1234         * ser-base.c: Fix common/ includes.
1235         * selftest-arch.c: Fix common/ includes.
1236         * s12z-tdep.c: Fix common/ includes.
1237         * rust-exp.y: Fix common/ includes.
1238         * rs6000-aix-tdep.c: Fix common/ includes.
1239         * riscv-tdep.c: Fix common/ includes.
1240         * remote.c: Fix common/ includes.
1241         * remote-notif.h: Fix common/ includes.
1242         * remote-fileio.h: Fix common/ includes.
1243         * remote-fileio.c: Fix common/ includes.
1244         * regcache.h: Fix common/ includes.
1245         * regcache.c: Fix common/ includes.
1246         * record-btrace.c: Fix common/ includes.
1247         * python/python.c: Fix common/ includes.
1248         * python/py-type.c: Fix common/ includes.
1249         * python/py-inferior.c: Fix common/ includes.
1250         * progspace.h: Fix common/ includes.
1251         * producer.c: Fix common/ includes.
1252         * procfs.c: Fix common/ includes.
1253         * proc-api.c: Fix common/ includes.
1254         * printcmd.c: Fix common/ includes.
1255         * ppc-linux-nat.c: Fix common/ includes.
1256         * parser-defs.h: Fix common/ includes.
1257         * osdata.c: Fix common/ includes.
1258         * obsd-nat.c: Fix common/ includes.
1259         * nat/x86-linux.c: Fix common/ includes.
1260         * nat/x86-linux-dregs.c: Fix common/ includes.
1261         * nat/x86-dregs.h: Fix common/ includes.
1262         * nat/x86-dregs.c: Fix common/ includes.
1263         * nat/ppc-linux.c: Fix common/ includes.
1264         * nat/mips-linux-watch.h: Fix common/ includes.
1265         * nat/mips-linux-watch.c: Fix common/ includes.
1266         * nat/linux-waitpid.c: Fix common/ includes.
1267         * nat/linux-ptrace.h: Fix common/ includes.
1268         * nat/linux-ptrace.c: Fix common/ includes.
1269         * nat/linux-procfs.c: Fix common/ includes.
1270         * nat/linux-personality.c: Fix common/ includes.
1271         * nat/linux-osdata.c: Fix common/ includes.
1272         * nat/linux-namespaces.c: Fix common/ includes.
1273         * nat/linux-btrace.h: Fix common/ includes.
1274         * nat/linux-btrace.c: Fix common/ includes.
1275         * nat/fork-inferior.c: Fix common/ includes.
1276         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1277         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1278         * nat/aarch64-linux.c: Fix common/ includes.
1279         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1280         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1281         * namespace.h: Fix common/ includes.
1282         * mips-linux-tdep.c: Fix common/ includes.
1283         * minsyms.c: Fix common/ includes.
1284         * mi/mi-parse.h: Fix common/ includes.
1285         * mi/mi-main.c: Fix common/ includes.
1286         * mi/mi-cmd-env.c: Fix common/ includes.
1287         * memrange.h: Fix common/ includes.
1288         * memattr.c: Fix common/ includes.
1289         * maint.h: Fix common/ includes.
1290         * maint.c: Fix common/ includes.
1291         * main.c: Fix common/ includes.
1292         * machoread.c: Fix common/ includes.
1293         * location.c: Fix common/ includes.
1294         * linux-thread-db.c: Fix common/ includes.
1295         * linux-nat.c: Fix common/ includes.
1296         * linux-fork.c: Fix common/ includes.
1297         * inline-frame.c: Fix common/ includes.
1298         * infrun.c: Fix common/ includes.
1299         * inflow.c: Fix common/ includes.
1300         * inferior.h: Fix common/ includes.
1301         * inferior.c: Fix common/ includes.
1302         * infcmd.c: Fix common/ includes.
1303         * inf-ptrace.c: Fix common/ includes.
1304         * inf-child.c: Fix common/ includes.
1305         * ia64-linux-nat.c: Fix common/ includes.
1306         * i387-tdep.c: Fix common/ includes.
1307         * i386-tdep.c: Fix common/ includes.
1308         * i386-linux-tdep.c: Fix common/ includes.
1309         * i386-linux-nat.c: Fix common/ includes.
1310         * i386-go32-tdep.c: Fix common/ includes.
1311         * i386-fbsd-tdep.c: Fix common/ includes.
1312         * i386-fbsd-nat.c: Fix common/ includes.
1313         * guile/scm-type.c: Fix common/ includes.
1314         * guile/guile.c: Fix common/ includes.
1315         * go32-nat.c: Fix common/ includes.
1316         * gnu-nat.c: Fix common/ includes.
1317         * gdbthread.h: Fix common/ includes.
1318         * gdbarch-selftests.c: Fix common/ includes.
1319         * gdb_usleep.c: Fix common/ includes.
1320         * gdb_select.h: Fix common/ includes.
1321         * gdb_bfd.c: Fix common/ includes.
1322         * gcore.c: Fix common/ includes.
1323         * fork-child.c: Fix common/ includes.
1324         * findvar.c: Fix common/ includes.
1325         * fbsd-nat.c: Fix common/ includes.
1326         * event-top.c: Fix common/ includes.
1327         * event-loop.c: Fix common/ includes.
1328         * dwarf2read.c: Fix common/ includes.
1329         * dwarf2loc.c: Fix common/ includes.
1330         * dwarf2-frame.c: Fix common/ includes.
1331         * dwarf-index-cache.c: Fix common/ includes.
1332         * dtrace-probe.c: Fix common/ includes.
1333         * disasm-selftests.c: Fix common/ includes.
1334         * defs.h: Fix common/ includes.
1335         * csky-tdep.c: Fix common/ includes.
1336         * cp-valprint.c: Fix common/ includes.
1337         * cp-support.h: Fix common/ includes.
1338         * cp-support.c: Fix common/ includes.
1339         * corelow.c: Fix common/ includes.
1340         * completer.h: Fix common/ includes.
1341         * completer.c: Fix common/ includes.
1342         * compile/compile.c: Fix common/ includes.
1343         * compile/compile-loc2c.c: Fix common/ includes.
1344         * compile/compile-cplus-types.c: Fix common/ includes.
1345         * compile/compile-cplus-symbols.c: Fix common/ includes.
1346         * command.h: Fix common/ includes.
1347         * cli/cli-dump.c: Fix common/ includes.
1348         * cli/cli-cmds.c: Fix common/ includes.
1349         * charset.c: Fix common/ includes.
1350         * build-id.c: Fix common/ includes.
1351         * btrace.h: Fix common/ includes.
1352         * btrace.c: Fix common/ includes.
1353         * breakpoint.h: Fix common/ includes.
1354         * breakpoint.c: Fix common/ includes.
1355         * ax.h:
1356         (enum agent_op): Fix common/ includes.
1357         * ax-general.c (struct aop_map): Fix common/ includes.
1358         * ax-gdb.c: Fix common/ includes.
1359         * auxv.c: Fix common/ includes.
1360         * auto-load.c: Fix common/ includes.
1361         * arm-tdep.c: Fix common/ includes.
1362         * arch/riscv.c: Fix common/ includes.
1363         * arch/ppc-linux-common.c: Fix common/ includes.
1364         * arch/i386.c: Fix common/ includes.
1365         * arch/arm.c: Fix common/ includes.
1366         * arch/arm-linux.c: Fix common/ includes.
1367         * arch/arm-get-next-pcs.c: Fix common/ includes.
1368         * arch/amd64.c: Fix common/ includes.
1369         * arch/aarch64.c: Fix common/ includes.
1370         * arch/aarch64-insn.c: Fix common/ includes.
1371         * arch-utils.c: Fix common/ includes.
1372         * amd64-windows-tdep.c: Fix common/ includes.
1373         * amd64-tdep.c: Fix common/ includes.
1374         * amd64-sol2-tdep.c: Fix common/ includes.
1375         * amd64-obsd-tdep.c: Fix common/ includes.
1376         * amd64-nbsd-tdep.c: Fix common/ includes.
1377         * amd64-linux-tdep.c: Fix common/ includes.
1378         * amd64-linux-nat.c: Fix common/ includes.
1379         * amd64-fbsd-tdep.c: Fix common/ includes.
1380         * amd64-fbsd-nat.c: Fix common/ includes.
1381         * amd64-dicos-tdep.c: Fix common/ includes.
1382         * amd64-darwin-tdep.c: Fix common/ includes.
1383         * agent.c: Fix common/ includes.
1384         * ada-lang.h: Fix common/ includes.
1385         * ada-lang.c: Fix common/ includes.
1386         * aarch64-tdep.c: Fix common/ includes.
1387
1388 2019-01-25  Tom Tromey  <tom@tromey.com>
1389
1390         * common/create-version.sh: Use common/version.h.
1391
1392 2019-01-24  Pedro Alves  <palves@redhat.com>
1393
1394         * infrun.c (signal_stop, signal_print, signal_program)
1395         (signal_catch, signal_pass): Now arrays instead of pointers.
1396         (update_signals_program_target, do_target_resume)
1397         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1398         * linux-nat.c (linux_nat_target::pass_signals)
1399         (linux_nat_target::create_inferior, linux_nat_target::attach):
1400         Adjust.
1401         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1402         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1403         * procfs.c (procfs_target::pass_signals): Adjust.
1404         * record-full.c (record_full_target::resume): Adjust.
1405         * remote.c (remote_target::pass_signals)
1406         (remote_target::program_signals): Adjust.
1407         * target-debug.h (target_debug_print_signals): Now takes a
1408         gdb::array_view as parameter.  Adjust.
1409         * target.h (target_ops) <pass_signals, program_signals>: Replace
1410         pointer and length parameters with gdb::array_view.
1411         (target_pass_signals, target_program_signals): Likewise.
1412         * target-delegates.c: Regenerate.
1413
1414 2019-01-24  Pedro Alves  <palves@redhat.com>
1415
1416         * common/forward-scope-exit.h
1417         (forward_scope_exit::forward_scope_exit): Pass arguments to
1418         m_bind_function directly, instead of creating a std::bind and
1419         copying that.
1420
1421 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1422
1423         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1424         for static members.
1425         (pass_in_v_vfp_candidate): Likewise.
1426
1427 2019-01-23  Tom Tromey  <tom@tromey.com>
1428             Pedro Alves  <palves@redhat.com>
1429
1430         * regcache.c (class regcache_invalidator): Remove.
1431         (regcache::raw_write): Use make_scope_exit.
1432
1433 2019-01-23  Tom Tromey  <tom@tromey.com>
1434
1435         * ui-out.h (class ui_out_emit_type): Update comment.
1436
1437 2019-01-23  Tom Tromey  <tom@tromey.com>
1438
1439         * infrun.c (fetch_inferior_event): Update comment.
1440
1441 2019-01-23  Tom Tromey  <tom@tromey.com>
1442             Pedro Alves  <palves@redhat.com>
1443
1444         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1445         parameter.
1446         (fetch_inferior_event): Use SCOPE_EXIT.
1447
1448
1449 2019-01-23  Tom Tromey  <tom@tromey.com>
1450             Pedro Alves  <palves@redhat.com>
1451
1452         * infrun.c (disable_thread_events): Delete.
1453         (stop_all_threads): Use SCOPE_EXIT.
1454
1455 2019-01-23  Tom Tromey  <tom@tromey.com>
1456             Pedro Alves  <palves@redhat.com>
1457
1458         * symfile.c: Include forward-scope-exit.h.
1459         (clear_symtab_users_cleanup): Replace forward declaration with
1460         a FORWARD_SCOPE_EXIT.
1461         (syms_from_objfile_1): Use the forward_scope_exit and
1462         gdb::optional instead of cleanup_function.
1463         (reread_symbols): Use the forward_scope_exit instead of
1464         cleanup_function.
1465         (clear_symtab_users_cleanup): Remove function.
1466
1467 2019-01-23  Tom Tromey  <tom@tromey.com>
1468             Pedro Alves  <palves@redhat.com>
1469
1470         * linux-nat.c: Include scope-exit.h.
1471         (cleanup_target_stop): Remove.
1472         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1473         SCOPE_EXIT.
1474
1475 2019-01-23  Tom Tromey  <tom@tromey.com>
1476             Pedro Alves  <palves@redhat.com>
1477
1478         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1479         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1480
1481 2019-01-23  Tom Tromey  <tom@tromey.com>
1482             Andrew Burgess  <andrew.burgess@embecosm.com>
1483             Pedro Alves  <palves@redhat.com>
1484
1485         * infrun.c (fetch_inferior_event): Use scope_exit.
1486         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1487         * top.c (execute_command): Use scope_exit.
1488         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1489         * utils.c (do_bpstat_clear_actions_cleanup)
1490         (make_bpstat_clear_actions_cleanup): Remove.
1491
1492 2019-01-23  Tom Tromey  <tom@tromey.com>
1493             Pedro Alves  <palves@redhat.com>
1494
1495         * infrun.c: Include "common/scope-exit.h"
1496         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1497         (wait_for_inferior): Use SCOPE_EXIT.
1498         (fetch_inferior_event): Use scope_exit.
1499
1500 2019-01-23  Tom Tromey  <tom@tromey.com>
1501             Pedro Alves  <palves@redhat.com>
1502
1503         * breakpoint.c (create_breakpoint): Remove cleanup.
1504
1505 2019-01-23  Tom Tromey  <tom@tromey.com>
1506             Andrew Burgess  <andrew.burgess@embecosm.com>
1507             Pedro Alves  <palves@redhat.com>
1508
1509 2019-01-23  Pedro Alves  <palves@redhat.com>
1510
1511         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1512
1513 2019-01-23  Pedro Alves  <palves@redhat.com>
1514             Andrew Burgess  <andrew.burgess@embecosm.com>
1515
1516         * gdbthread.h: Include "common/forward-scope-exit.h".
1517         (scoped_finish_thread_state): Redefine custom class in terms of
1518         forward_scope_exit.
1519
1520 2019-01-23  Pedro Alves  <palves@redhat.com>
1521             Andrew Burgess  <andrew.burgess@embecosm.com>
1522
1523         * common/forward-scope-exit.h: New file.
1524
1525 2019-01-23  Pedro Alves  <palves@redhat.com>
1526             Andrew Burgess  <andrew.burgess@embecosm.com>
1527             Tom Tromey  <tom@tromey.com>
1528
1529         * common/scope-exit.h: New file.
1530
1531 2019-01-23  Pedro Alves  <palves@redhat.com>
1532
1533         * common/preprocessor.h (ESC): Rename to ...
1534         (ESC_PARENS): ... this.
1535         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1536         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1537
1538 2019-01-23  Tom Tromey  <tom@tromey.com>
1539
1540         * language.h (class scoped_switch_to_sym_language_if_auto):
1541         Initialize m_lang in both cases.
1542
1543 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1544
1545         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1546         with XCNEW.
1547
1548 2019-01-22  Tom Tromey  <tom@tromey.com>
1549
1550         * corelow.c: Do not include sys/file.h.
1551
1552 2019-01-22  Tom Tromey  <tom@tromey.com>
1553
1554         * tui/tui-wingeneral.h: Include gdb_curses.h.
1555
1556 2019-01-22  Tom Tromey  <tom@tromey.com>
1557
1558         * source-cache.h (class source_cache) <get_source_lines,
1559         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1560
1561 2019-01-22  Tom Tromey  <tom@tromey.com>
1562
1563         * remote-fileio.h (struct remote_target): Declare.
1564
1565 2019-01-22  Tom Tromey  <tom@tromey.com>
1566
1567         * python/py-arch.c: Do not include py-ref.h.
1568         * python/py-bpevent.c: Do not include py-ref.h.
1569         * python/py-cmd.c: Do not include py-ref.h.
1570         * python/py-continueevent.c: Do not include py-ref.h.
1571         * python/py-event.h: Do not include py-ref.h.
1572         * python/py-evtregistry.c: Do not include py-ref.h.
1573         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1574         * python/py-frame.c: Do not include py-ref.h.
1575         * python/py-framefilter.c: Do not include py-ref.h.
1576         * python/py-function.c: Do not include py-ref.h.
1577         * python/py-infevents.c: Do not include py-ref.h.
1578         * python/py-linetable.c: Do not include py-ref.h.
1579         * python/py-objfile.c: Do not include py-ref.h.
1580         * python/py-param.c: Do not include py-ref.h.
1581         * python/py-prettyprint.c: Do not include py-ref.h.
1582         * python/py-progspace.c: Do not include py-ref.h.
1583         * python/py-symbol.c: Do not include py-ref.h.
1584         * python/py-symtab.c: Do not include py-ref.h.
1585         * python/py-type.c: Do not include py-ref.h.
1586         * python/py-unwind.c: Do not include py-ref.h.
1587         * python/py-utils.c: Do not include py-ref.h.
1588         * python/py-value.c: Do not include py-ref.h.
1589         * python/py-varobj.c: Do not include py-ref.h.
1590         * python/py-xmethods.c: Do not include py-ref.h.
1591         * python/python.c: Do not include py-ref.h.
1592         * varobj.c: Do not include py-ref.h.
1593
1594 2019-01-22  Tom Tromey  <tom@tromey.com>
1595
1596         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1597         keyword for bcache.
1598
1599 2019-01-22  Tom Tromey  <tom@tromey.com>
1600
1601         * compile/compile-cplus-types.c: Remove a comment by #include.
1602
1603 2019-01-22  Tom Tromey  <tom@tromey.com>
1604
1605         * compile/gcc-c-plugin.h: Include compile-internal.h.
1606
1607 2019-01-22  Tom Tromey  <tom@tromey.com>
1608
1609         * stabsread.c (EXTERN): Do not define.
1610         (symnum, next_symbol_text_func, processing_gcc_compilation)
1611         (within_function, global_sym_chain, global_stabs)
1612         (previous_stab_code, this_object_header_files)
1613         (n_this_object_header_files)
1614         (n_allocated_this_object_header_files): Define.
1615         * stabsread.h (EXTERN): Never define.  Use "extern".
1616
1617 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1618
1619         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1620         history_value.
1621
1622 2019-01-21  Tom Tromey  <tom@tromey.com>
1623
1624         * ui-out.c: Fix includes.
1625         * tui/tui-source.c: Fix includes.
1626         * target.c: Fix includes.
1627         * remote.c: Fix includes.
1628         * regcache.c: Fix includes.
1629         * python/py-block.c: Fix includes.
1630         * printcmd.c: Fix includes.
1631         * or1k-tdep.c: Fix includes.
1632         * mi/mi-main.c: Fix includes.
1633         * m32r-tdep.c: Fix includes.
1634         * csky-tdep.c: Fix includes.
1635         * compile/compile-cplus-types.c: Fix includes.
1636         * cli/cli-interp.c: Fix includes.
1637
1638 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1639
1640         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1641         for padding.
1642
1643 2019-01-16  Tom Tromey  <tom@tromey.com>
1644
1645         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1646         earlier.
1647         (struct objfile) <msymbols_range>: Move from top level.
1648         <msymbols>: New method.
1649         (class objfile_msymbols): Remove.
1650         * symtab.c (default_collect_symbol_completion_matches_break_on):
1651         Update.
1652         * symmisc.c (dump_msymbols): Update.
1653         * stabsread.c (scan_file_globals): Update.
1654         * objc-lang.c (info_selectors_command, info_classes_command)
1655         (find_methods): Update.
1656         * minsyms.c (find_solib_trampoline_target): Update.
1657         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1658         * coffread.c (coff_symfile_read): Update.
1659         * ada-lang.c (ada_lookup_simple_minsym)
1660         (ada_collect_symbol_completion_matches): Update.
1661
1662 2019-01-16  Tom Tromey  <tom@tromey.com>
1663
1664         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1665         type.  Remove no-argument constructor.
1666         <iterator::operator++>: Simplify.
1667         <begin>: Update.
1668         <end>: Use minimal_symbol_count.
1669
1670 2019-01-16  Tom Tromey  <tom@tromey.com>
1671
1672         * objfiles.h (struct objfile) <psymtabs>: New method.
1673         (class objfile_psymtabs): Remove.
1674         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1675         typedef.
1676         <range>: New method.
1677         (require_partial_symbols): Change return type.
1678         * psymtab.c (require_partial_symbols)
1679         (psym_expand_symtabs_matching): Update.
1680         * mdebugread.c (parse_partial_symbols): Update.
1681         * dbxread.c (dbx_end_psymtab): Update.
1682
1683 2019-01-15  Tom Tromey  <tom@tromey.com>
1684
1685         * symtab.c (lookup_objfile_from_block)
1686         (lookup_symbol_in_objfile_symtabs)
1687         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1688         (find_line_symtab, info_sources_command)
1689         (default_collect_symbol_completion_matches_break_on)
1690         (make_source_files_completion_list): Update.
1691         * symmisc.c (print_objfile_statistics, dump_objfile)
1692         (maintenance_print_symbols, maintenance_info_symtabs)
1693         (maintenance_check_symtabs, maintenance_info_line_tables):
1694         Update.
1695         * source.c (select_source_symtab)
1696         (forget_cached_source_info_for_objfile): Update.
1697         * objfiles.h (class objfile_compunits): Remove.
1698         (struct objfile) <compunits_range>: New typedef.
1699         (compunits): New method.
1700         * objfiles.c (objfile_relocate1): Update.
1701         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1702         * maint.c (count_symtabs_and_blocks): Update.
1703         * linespec.c (iterate_over_all_matching_symtabs): Update.
1704         * cp-support.c (add_symbol_overload_list_qualified): Update.
1705         * coffread.c (coff_symtab_read): Update.
1706         * ada-lang.c (add_nonlocal_symbols)
1707         (ada_collect_symbol_completion_matches)
1708         (ada_add_global_exceptions): Update.
1709
1710 2019-01-15  Tom Tromey  <tom@tromey.com>
1711
1712         * progspace.h (program_space) <objfiles_safe_range>: New
1713         typedef.
1714         <objfiles_safe>: New method.
1715         * objfiles.h (class all_objfiles_safe): Remove.
1716         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1717         * jit.c (jit_inferior_exit_hook): Update.
1718
1719 2019-01-17  Tom Tromey  <tom@tromey.com>
1720
1721         * progspace.h (program_space) <objfiles_range>: New typedef.
1722         <objfiles>: New method.
1723         <objfiles_head>: Rename from objfiles.
1724         (object_files): Update.
1725         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1726         * guile/scm-pretty-print.c
1727         (ppscm_find_pretty_printer_from_objfiles): Update.
1728         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1729         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1730         Update.
1731         * python/py-progspace.c (pspy_get_objfiles): Update.
1732         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1733         Update.
1734         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1735         (objfpy_lookup_objfile_by_build_id): Update.
1736         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1737         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1738         Update.
1739         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1740         (expand_symtab_containing_pc, lookup_objfile_from_block)
1741         (lookup_static_symbol, basic_lookup_transparent_type)
1742         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1743         (find_line_symtab, info_sources_command)
1744         (default_collect_symbol_completion_matches_break_on)
1745         (make_source_files_completion_list, find_main_name): Update.
1746         * symmisc.c (print_symbol_bcache_statistics)
1747         (print_objfile_statistics, maintenance_print_symbols)
1748         (maintenance_print_msymbols, maintenance_print_objfiles)
1749         (maintenance_info_symtabs, maintenance_check_symtabs)
1750         (maintenance_expand_symtabs, maintenance_info_line_tables):
1751         Update.
1752         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1753         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1754         (map_overlay_command, unmap_overlay_command)
1755         (simple_overlay_update, expand_symtabs_matching)
1756         (map_symbol_filenames): Update.
1757         * symfile-debug.c (set_debug_symfile): Update.
1758         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1759         Update.
1760         * source.c (select_source_symtab, forget_cached_source_info):
1761         Update.
1762         * solib.c (solib_read_symbols): Update.
1763         * solib-spu.c (append_ocl_sos): Update.
1764         * psymtab.c (maintenance_print_psymbols)
1765         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1766         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1767         * printcmd.c (info_symbol_command): Update.
1768         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1769         Update.
1770         * objfiles.h (class all_objfiles): Remove.
1771         * objfiles.c (have_partial_symbols, have_full_symbols)
1772         (have_minimal_symbols, qsort_cmp, update_section_map)
1773         (shared_objfile_contains_address_p)
1774         (default_iterate_over_objfiles_in_search_order): Update.
1775         * objc-lang.c (info_selectors_command, info_classes_command)
1776         (find_methods): Update.
1777         * minsyms.c (find_solib_trampoline_target): Update.
1778         * maint.c (maintenance_info_sections)
1779         (maintenance_translate_address, count_symtabs_and_blocks):
1780         Update.
1781         * main.c (captured_main_1): Update.
1782         * linux-thread-db.c (try_thread_db_load_from_pdir)
1783         (has_libpthread): Update.
1784         * linespec.c (iterate_over_all_matching_symtabs)
1785         (search_minsyms_for_name): Update.
1786         * jit.c (jit_find_objf_with_entry_addr): Update.
1787         * hppa-tdep.c (find_unwind_entry)
1788         (hppa_lookup_stub_minimal_symbol): Update.
1789         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1790         Update.
1791         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1792         (elf_gnu_ifunc_resolve_by_got): Update.
1793         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1794         * dwarf-index-write.c (save_gdb_index_command): Update.
1795         * cp-support.c (add_symbol_overload_list_qualified): Update.
1796         * breakpoint.c (create_overlay_event_breakpoint)
1797         (create_longjmp_master_breakpoint)
1798         (create_std_terminate_master_breakpoint)
1799         (create_exception_master_breakpoint): Update.
1800         * blockframe.c (find_pc_partial_function): Update.
1801         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1802         (ada_collect_symbol_completion_matches)
1803         (ada_add_global_exceptions): Update.
1804
1805 2019-01-17  Tom Tromey  <tom@tromey.com>
1806
1807         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1808         declare VEC.
1809         (solib_target_parse_libraries): Change return type.
1810         (library_list_start_segment, library_list_start_section)
1811         (library_list_end_library, library_list_start_library); Update.
1812         (solib_target_free_library_list): Remove.
1813         (solib_target_parse_libraries): Remove cleanup.  Change return
1814         type.
1815         (solib_target_current_sos): Update.
1816
1817 2019-01-17  Tom Tromey  <tromey@bapiya>
1818
1819         * valprint.c: Replace "the the" with "the".
1820         * symtab.c: Replace "the the" with "the".
1821         * solib.c: Replace "the the" with "the".
1822         * solib-dsbt.c: Replace "the the" with "the".
1823         * linespec.c: Replace "the the" with "the".
1824         * dwarf2loc.h: Replace "the the" with "the".
1825         * amd64-windows-tdep.c: Replace "the the" with "the".
1826         * aarch64-tdep.c: Replace "the the" with "the".
1827
1828 2019-01-16  Keith Seitz  <keiths@redhat.com>
1829
1830         PR gdb/23773
1831         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1832         <builder>: Rename to ..
1833         <m_builder>: ... this and make private.
1834         (dwarf2_cu::get_builder): New method.  Change all users of
1835         `builder' to use this method.
1836         (dwarf2_start_symtab): Move to ...
1837         (dwarf2_cu::start_symtab): ... here.  Update all callers
1838         (setup_type_unit_groups): Move to ...
1839         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1840         callers.
1841         (dwarf2_cu::reset_builder): New method.
1842         (process_full_compunit, process_full_type_unit): Use
1843         dwarf2_cu::reset_builder.
1844         (follow_die_offset): Record the ancestor CU if it is different
1845         from the followed DIE's CU.
1846         (follow_die_sig_1): Likewise.
1847
1848 2019-01-15  Tom Tromey  <tom@tromey.com>
1849
1850         * remote.c (class remote_state) <buf>: Now a char_vector.
1851         <buf_size>: Remove.
1852         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1853         parameter.
1854         (remote_target::getpkt_or_notif_sane_1)
1855         (remote_target::getpkt_sane)
1856         (remote_target::getpkt_or_notif_sane): Likewise.
1857         (class remote_target) <putpkt>: New overload.
1858         (remote_target::read_frame): Change type of "buf_p".  Remove
1859         sizeof_p parameter.
1860         (packet_ok): New overload.
1861         (packet_check_result): New overload.
1862         Update all uses.
1863
1864 2019-01-14  Tom Tromey  <tom@tromey.com>
1865
1866         * remote-notif.c (handle_notification, remote_notif_ack)
1867         (remote_notif_parse): Make "buf" const.
1868         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1869         const.
1870         (remote_notif_parse, remote_notif_ack, handle_notification):
1871         Likewise.
1872         * remote.c (remote_notif_stop_parse): Make "buf" const.
1873         (remote_target::remote_parse_stop_reply): Make "buf" const.
1874         (remote_notif_stop_ack): Make "buf" const.
1875
1876 2019-01-14  Tom Tromey  <tom@tromey.com>
1877
1878         * remote.c (remote_console_output): Make parameter const.
1879
1880 2019-01-14  Tom Tromey  <tom@tromey.com>
1881
1882         * target-debug.h (target_debug_print_signals): Constify.
1883         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1884         * procfs.c (procfs_target::pass_signals): Update.
1885         * linux-nat.c (linux_nat_target::pass_signals): Update.
1886         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1887         * target-delegates.c: Rebuild.
1888         * remote.c (remote_target::program_signals): Update.
1889         (remote_target::pass_signals): Update.
1890         * target.c (target_pass_signals): Constify argument.
1891         (target_program_signals): Likewise.
1892         * target.h (struct target_ops) <pass_signals, program_signals>:
1893         Constify argument.
1894         (target_pass_signals, target_program_signals): Constify argument.
1895
1896 2019-01-14  Tom Tromey  <tom@tromey.com>
1897
1898         PR tui/28819:
1899         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1900
1901 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1902
1903         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1904         field.
1905         * rs6000-tdep.c: Include reggroups.h.
1906         (IS_V_ALIAS_PSEUDOREG): Define.
1907         (rs6000_register_name): Return names for the "vX" aliases.
1908         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1909         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1910         aliases.  Call default_register_reggroup_p for all other
1911         pseudo-registers.
1912         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1913         New functions.
1914         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1915         Handle "vX" aliases.
1916         (v_alias_pseudo_register_collect): New function.
1917         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1918         (rs6000_gdbarch_init): Initialize "vX" aliases as
1919         pseudo-registers.  Restore registration of
1920         rs6000_pseudo_register_reggroup_p with
1921         set_tdesc_pseudo_register_reggroup_p.
1922
1923 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1924
1925         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1926         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1927         set_gdbarch_num_pseudo_regs.
1928
1929 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1930
1931         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1932         Remove arg prefixname, add do_set and do_show.
1933         Add member functions set_list and show_list.
1934         * cli/cli-style.c (class cli_style_option): Update accordingly.
1935         (style_set_list): Move to file scope.
1936         (style_show_list): Likewise.
1937         (set_style): Call help_list.
1938         (show_style): Call cmd_show_list.
1939         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1940         Update to use the new macro.
1941
1942 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1943
1944         * ada-lang.c (_initialize_ada_language): Expand the help text
1945         for the "catch exception" command.
1946
1947 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1948
1949         * symtab.c (matching_obj_sections): Initialize obj,
1950         declare it closer to its usage.
1951
1952 2019-01-10  Tom Tromey  <tom@tromey.com>
1953
1954         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1955         (basic_inf_threads_range): Remove.
1956         (inf_threads_range, inf_non_exited_threads_range)
1957         (safe_inf_threads_range): Use next_adapter.
1958
1959 2019-01-10  Keith Seitz  <keiths@redhat.com>
1960
1961         PR gdb/23712
1962         PR symtab/23010
1963         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1964         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1965
1966 2019-01-10  Keith Seitz  <keiths@redhat.com>
1967
1968         PR gdb/23712
1969         PR symtab/23010
1970         * dictionary.c (pending_to_vector): Remove.
1971         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1972         Remove _1 suffix, replacing functions of the same name.  Update
1973         all callers.
1974         (dict_create_hashed, dict_create_hashed_expandable)
1975         (dict_create_linear, dict_create_linear_expandable, dict_free)
1976         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1977         Make functions static.
1978
1979 2019-01-10  Keith Seitz  <keiths@redhat.com>
1980
1981         PR gdb/23712
1982         PR symtab/23010
1983         * dictionary.h (struct dictionary): Replace declaration with
1984         multidictionary.
1985         (dict_create_hashed, dict_create_hashed_expandable)
1986         (dict_create_linear, dict_create_linear_expandable)
1987         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1988         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1989         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1990         taking multidictionary argument.
1991         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1992         * block.h (struct block) <dict>: Change to multidictionary
1993         and rename `multidict'.
1994         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1995         symmisc.c: Update all dictionary references to multidictionary.
1996
1997 2019-01-10  Keith Seitz  <keiths@redhat.com>
1998
1999         PR gdb/23712
2000         PR symtab/23010
2001         * dictionary.c: Include unordered_map.
2002         (pending_to_vector): New function.
2003         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2004         Rewrite the non-"_1" functions to take vector instead
2005         of linked list.
2006         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2007         "new" _1 versions of the same name.
2008         (multidictionary): Define.
2009         (std::hash<enum language): New definition.
2010         (collate_pending_symbols_by_language, mdict_create_hashed)
2011         (mdict_create_hashed_expandable, mdict_create_linear)
2012         (mdict_create_linear_expandable, mdict_free)
2013         (find_language_dictionary, create_new_language_dictionary)
2014         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2015         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2016         (mdict_size, mdict_empty): New functions.
2017         * dictionary.h (mdict_iterator): Define.
2018
2019 2019-01-10  Pedro Alves  <palves@redhat.com>
2020
2021         * breakpoint.c (read_uploaded_action)
2022         (create_tracepoint_from_upload): Adjust to use
2023         gdb::unique_xmalloc_ptr.
2024         * ctf.c (ctf_write_uploaded_tp):
2025         (SET_ARRAY_FIELD): Use emplace_back.
2026         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2027         * tracefile-tfile.c (tfile_write_uploaded_tp):
2028         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2029         gdb::unique_xmalloc_ptr.
2030         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2031         at_string, cond_string, cmd_strings>: Replace char pointers
2032         with gdb::unique_xmalloc_ptr.
2033
2034 2019-01-10  Pedro Alves  <palves@redhat.com>
2035
2036         * solib-target.c (library_list_start_library): Don't xstrdup name.
2037
2038 2019-01-10  Pedro Alves  <palves@redhat.com>
2039
2040         * mdebugread.c (parse_partial_symbols): Use
2041         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2042
2043 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2044
2045         * linux-fork.c (scoped_switch_fork_info)
2046         <~scoped_switch_fork_info>: Fix incorrect variable name.
2047
2048 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2049
2050         * linux-fork.c (scoped_switch_fork_info)
2051         <scoped_switch_fork_info>: Make explicit.
2052         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2053
2054 2019-01-10  Tom Tromey  <tom@tromey.com>
2055
2056         * objfiles.h (objfile::reset_psymtabs): Update.
2057         * objfiles.c (objfile::objfile): Update.
2058         * psymtab.h (psymtab_storage::obstack): Update.
2059         (psymtab_storage::m_obstack): Use gdb::optional.
2060         (class psymtab_storage): Update comment.  Remove objfile
2061         parameter.
2062         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2063
2064 2019-01-10  Tom Tromey  <tom@tromey.com>
2065
2066         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2067         <free_psymtabs>: Now private.
2068         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2069         (allocate_psymtab): Use new method.
2070
2071 2019-01-10  Tom Tromey  <tom@tromey.com>
2072
2073         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2074         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2075         * mdebugread.c (parse_partial_symbols): Use
2076         allocate_dependencies.
2077         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2078         allocate_dependencies.
2079         (process_psymtab_comp_unit_reader)
2080         (build_type_psymtab_dependencies): Likewise.
2081         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2082
2083 2019-01-10  Tom Tromey  <tom@tromey.com>
2084
2085         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2086         PSYMBOL_SET_LANGUAGE.
2087         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2088
2089 2019-01-10  Tom Tromey  <tom@tromey.com>
2090
2091         * psymtab.h (psymtab_storage::obstack): New method.
2092         <m_obstack>: Rename from obstack; now private.
2093         * psymtab.c (psymtab_storage): Update.
2094         * dwarf2read.c (create_addrmap_from_index)
2095         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2096         Update.
2097
2098 2019-01-10  Tom Tromey  <tom@tromey.com>
2099
2100         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2101         * objfiles.h (objfile::reset_psymtabs): New method.
2102
2103 2019-01-10  Tom Tromey  <tom@tromey.com>
2104
2105         * symmisc.c (print_symbol_bcache_statistics): Update.
2106         (print_objfile_statistics): Update.
2107         * symfile.c (reread_symbols): Update.
2108         * psymtab.h (class psymtab_storage): New.
2109         * psymtab.c (psymtab_storage): New constructor.
2110         (~psymtab_storage): New destructor.
2111         (require_partial_symbols): Update.
2112         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2113         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2114         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2115         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2116         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2117         (start_psymtab_common, end_psymtab_common)
2118         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2119         (allocate_psymtab): Update.
2120         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2121         Update.
2122         (dump_psymtab_addrmap, maintenance_print_psymbols)
2123         (maintenance_check_psymtabs): Update.
2124         (class objfile_psymtabs): Move to objfiles.h.
2125         * psympriv.h (discard_psymtab): Now inline.
2126         (psymtab_discarder::psymtab_discarder): Update.
2127         (psymtab_discarder::~psymtab_discarder): Update.
2128         (ALL_OBJFILE_PSYMTABS): Rewrite.
2129         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2130         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2131         Remove fields.
2132         <partial_symtabs>: New field.
2133         (class objfile_psymtabs): Move from psymtab.h.  Update.
2134         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2135         psymbol_cache.
2136         (objfile::~objfile): Don't destroy psymbol_cache.
2137         * mdebugread.c (parse_partial_symbols): Update.
2138         * dwarf2read.c (create_addrmap_from_index)
2139         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2140         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2141         (add_partial_subprogram, dwarf2_ranges_read): Update.
2142         * dwarf-index-write.c (write_address_map)
2143         (write_one_signatured_type, recursively_write_psymbols)
2144         (class debug_names, class debug_names, write_psymtabs_to_index):
2145         Update.
2146
2147 2019-01-10  Tom Tromey  <tom@tromey.com>
2148
2149         * symtab.h (SYMBOL_SET_NAMES): Update.
2150         (symbol_set_names): Update.
2151         (MSYMBOL_SET_NAMES): Update.
2152         * symtab.c (symbol_set_names): Change argument to be an
2153         objfile_per_bfd_storage.
2154         * psymtab.c (add_psymbol_to_bcache): Update.
2155         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2156
2157 2019-01-10  Tom Tromey  <tom@tromey.com>
2158
2159         * symtab.c (create_demangled_names_hash): Change argument to be an
2160         objfile_per_bfd_storage.
2161         (symbol_set_names): Update.
2162
2163 2019-01-10  Tom Tromey  <tom@tromey.com>
2164
2165         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2166         init_psymbol_list.
2167         * psymtab.c (init_psymbol_list): Do nothing if already called.
2168         * psympriv.h (init_psymbol_list): Add comment.
2169         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2170         init_psymbol_list.
2171         * dbxread.c (dbx_symfile_read): Unconditionally call
2172         init_psymbol_list.
2173
2174 2019-01-10  Tom Tromey  <tom@tromey.com>
2175
2176         * xcoffread.c (scan_xcoff_symtab): Update.
2177         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2178         "where".
2179         * mdebugread.c (parse_partial_symbols)
2180         (handle_psymbol_enumerators): Update.
2181         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2182         * dbxread.c (read_dbx_symtab): Update.
2183         * psympriv.h (psymbol_placement): New enum.
2184         (add_psymbol_to_list): Update.
2185
2186 2019-01-10  Tom Tromey  <tom@tromey.com>
2187
2188         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2189         static_psymbols parameters.
2190         (scan_xcoff_symtab): Update.
2191         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2192         static_psymbols parameters.
2193         * psympriv.h (start_psymtab_common): Update.
2194         * mdebugread.c (parse_partial_symbols): Update.
2195         * dwarf2read.c (create_partial_symtab): Update.
2196         * dbxread.c (read_dbx_symtab): Update.
2197         (start_psymtab): Remove global_psymbols and static_psymbols
2198         parameters.
2199
2200 2019-01-10  Tom Tromey  <tom@tromey.com>
2201
2202         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2203         * psymtab.c (allocate_psymtab): Add comment.
2204         * psympriv.h (allocate_psymtab): Add comment.
2205         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2206         initializations.
2207         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2208
2209 2019-01-10  Tom Tromey  <tom@tromey.com>
2210
2211         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2212         Don't declare.
2213         * mipsread.c: Include mdebugread.h.
2214         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2215         Declare.
2216         * elfread.c: Include mdebugread.h.
2217
2218 2019-01-09  Tom Tromey  <tom@tromey.com>
2219
2220         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2221         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2222         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2223         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2224         (psym_lookup_symbol, psym_find_last_source_symtab)
2225         (psym_forget_cached_source_info, psym_print_stats)
2226         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2227         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2228         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2229         (psym_find_compunit_symtab_by_address)
2230         (maintenance_print_psymbols, maintenance_info_psymtabs)
2231         (maintenance_check_psymtabs): Use ranged for.
2232         * psymtab.h (class objfile_psymtabs): New.
2233         (require_partial_symbols): Return objfile_psymtabs.
2234         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2235
2236 2019-01-09  Tom Tromey  <tom@tromey.com>
2237
2238         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2239         (find_pc_mapped_section, list_overlays_command)
2240         (map_overlay_command, unmap_overlay_command)
2241         (simple_overlay_update): Use all_objfiles.
2242         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2243         * printcmd.c (info_symbol_command): Use all_objfiles.
2244         * objfiles.h (ALL_OBJSECTIONS): Remove.
2245         * maint.c (maintenance_translate_address): Use all_objfiles.
2246         * gcore.c (gcore_create_callback): Use all_objfiles.
2247         (objfile_find_memory_regions): Likewise.
2248
2249 2019-01-09  Tom Tromey  <tom@tromey.com>
2250
2251         * symtab.c (find_line_symtab, info_sources_command)
2252         (make_source_files_completion_list): Use objfile_compunits.
2253         * source.c (select_source_symtab): Use objfile_compunits.
2254         * objfiles.h (struct objfile): Update comment.
2255         (ALL_OBJFILES): Remove.
2256         (ALL_FILETABS): Remove.
2257         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2258         objfile_compunits.
2259
2260 2019-01-09  Tom Tromey  <tom@tromey.com>
2261
2262         * symmisc.c (print_objfile_statistics, dump_objfile)
2263         (maintenance_print_symbols): Use compunit_filetabs.
2264         * source.c (forget_cached_source_info_for_objfile): Use
2265         compunit_filetabs.
2266         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2267         (ALL_FILETABS): Use compunit_filetabs.
2268         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2269         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2270
2271 2019-01-09  Tom Tromey  <tom@tromey.com>
2272
2273         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2274         (compunit_filetabs): New.
2275         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2276         compunit_filetabs.
2277         (info_sources_command, make_source_files_completion_list): Remove
2278         declaration.
2279         * symmisc.c (print_objfile_statistics, dump_objfile)
2280         (maintenance_print_symbols): Remove declaration.
2281         (maintenance_info_symtabs): Use compunit_filetabs.
2282         (maintenance_info_line_tables): Likewise.
2283         * source.c (select_source_symtab): Change local variable name.
2284         (forget_cached_source_info_for_objfile): Remove declaration.
2285         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2286         * objfiles.c (objfile_relocate1): Remove declaration.
2287         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2288         declaration.
2289         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2290         * coffread.c (coff_symtab_read): Remove declaration.
2291         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2292         compunit_filetabs.
2293
2294 2019-01-09  Tom Tromey  <tom@tromey.com>
2295
2296         * symtab.c (lookup_objfile_from_block)
2297         (find_pc_sect_compunit_symtab, search_symbols)
2298         (default_collect_symbol_completion_matches_break_on): Use
2299         objfile_compunits.
2300         * objfiles.h (ALL_COMPUNITS): Remove.
2301         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2302         * cp-support.c (add_symbol_overload_list_qualified): Use
2303         objfile_compunits.
2304         * ada-lang.c (ada_collect_symbol_completion_matches)
2305         (ada_add_global_exceptions): Use objfile_compunits.
2306
2307 2019-01-09  Tom Tromey  <tom@tromey.com>
2308
2309         * source.c (select_source_symtab)
2310         (forget_cached_source_info_for_objfile): Remove declaration.
2311         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2312         declaration.
2313         * maint.c (count_symtabs_and_blocks): Remove declaration.
2314         * cp-support.c (add_symbol_overload_list_qualified): Remove
2315         declaration.
2316         * coffread.c (coff_symtab_read): Remove declaration.
2317         * symtab.c (lookup_symbol_in_objfile_symtabs)
2318         (basic_lookup_transparent_type_1): Use objfile_compunits.
2319         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2320         (info_sources_command, search_symbols)
2321         (default_collect_symbol_completion_matches_break_on)
2322         (make_source_files_completion_list): Remove declaration.
2323         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2324         (ada_collect_symbol_completion_matches)
2325         (ada_add_global_exceptions): Remove declaration.
2326         * linespec.c (iterate_over_all_matching_symtabs): Use
2327         objfile_compunits.
2328         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2329         (class objfile_compunits): New.
2330         (ALL_COMPUNITS): Use objfile_compunits.
2331         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2332         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2333         objfile_compunits.
2334         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2335
2336 2019-01-09  Tom Tromey  <tom@tromey.com>
2337
2338         * symtab.c (search_symbols)
2339         (default_collect_symbol_completion_matches_break_on): Use
2340         objfile_msymbols.
2341         * ada-lang.c (ada_lookup_simple_minsym)
2342         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2343         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2344         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2345         objfile_msymbols.
2346         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2347         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2348         * objc-lang.c (find_methods): Use objfile_msymbols.
2349         (info_selectors_command, info_classes_command): Likewise.
2350         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2351         * objfiles.h (class objfile_msymbols): New.
2352         (ALL_OBJFILE_MSYMBOLS): Remove.
2353         (ALL_MSYMBOLS): Remove.
2354
2355 2019-01-09  Tom Tromey  <tom@tromey.com>
2356
2357         * common/next-iterator.h (next_adapter): Add Iterator template
2358         parameter.
2359         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2360         (class all_objfiles_safe): New.
2361         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2362         * objfiles.c (put_objfile_before): Update comment.
2363         (add_separate_debug_objfile): Likewise.
2364         (free_all_objfiles): Use all_objfiles_safe.
2365         (objfile_purge_solibs): Likewise.
2366
2367 2019-01-09  Tom Tromey  <tom@tromey.com>
2368
2369         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2370         (expand_symtab_containing_pc, lookup_static_symbol)
2371         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2372         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2373         all_objfiles.
2374         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2375         * breakpoint.c (create_overlay_event_breakpoint)
2376         (create_longjmp_master_breakpoint)
2377         (create_std_terminate_master_breakpoint)
2378         (create_exception_master_breakpoint): Use all_objfiles.
2379         * linux-thread-db.c (try_thread_db_load_from_pdir)
2380         (has_libpthread): Use all_objfiles.
2381         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2382         * linespec.c (iterate_over_all_matching_symtabs)
2383         (search_minsyms_for_name): Use all_objfiles.
2384         * maint.c (maintenance_info_sections): Use all_objfiles.
2385         * main.c (captured_main_1): Use all_objfiles.
2386         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2387         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2388         * guile/scm-pretty-print.c
2389         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2390         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2391         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2392         (maintenance_print_msymbols): Use all_objfiles.
2393         * source.c (select_source_symtab): Use all_objfiles.
2394         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2395         * symfile.c (remove_symbol_file_command)
2396         (expand_symtabs_matching, map_symbol_filenames): Use
2397         all_objfiles.
2398         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2399         all_objfiles.
2400         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2401         * objc-lang.c (find_methods): Use all_objfiles.
2402         * objfiles.c (have_partial_symbols, have_full_symbols)
2403         (have_minimal_symbols, qsort_cmp)
2404         (default_iterate_over_objfiles_in_search_order): Use
2405         all_objfiles.
2406         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2407         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2408         (maintenance_check_psymtabs): Use all_objfiles.
2409         (ALL_PSYMTABS): Remove.
2410         * compile/compile-object-run.c (do_module_cleanup): Use
2411         all_objfiles.
2412         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2413         * cp-support.c (add_symbol_overload_list_qualified): Use
2414         all_objfiles.
2415         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2416         Use all_objfiles.
2417         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2418         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2419         all_objfiles.
2420         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2421         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2422         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2423         Uses all_objfiles.
2424         * solib.c (solib_read_symbols): Use all_objfiles
2425
2426 2019-01-09  Tom Tromey  <tom@tromey.com>
2427
2428         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2429         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2430         all_objfiles.
2431         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2432         * symmisc.c (print_symbol_bcache_statistics)
2433         (print_objfile_statistics, maintenance_print_objfiles)
2434         (maintenance_info_symtabs, maintenance_check_symtabs)
2435         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2436         all_objfiles.
2437         * source.c (forget_cached_source_info): Use all_objfiles.
2438         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2439         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2440         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2441         * objfiles.c (update_section_map): Use all_objfiles.
2442         (shared_objfile_contains_address_p): Likewise.
2443         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2444         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2445
2446 2019-01-09  Tom Tromey  <tom@tromey.com>
2447
2448         * common/next-iterator.h: New file.
2449         * objfiles.h (class all_objfiles): New.
2450         (struct objfile_iterator): New.
2451
2452 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2453
2454         * NEWS: Move the description of the changed "frame", "select-frame",
2455          and "info frame" commands to the Changed commands section.
2456
2457 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2458
2459         * gdbtypes.c (check_stub_method_group): Remove handling of old
2460         mangling schemes.
2461         * linespec.c (find_methods): Likewise.
2462         * stabsread.c (read_member_functions): Likewise.
2463         * valops.c (search_struct_method): Likewise.
2464         (value_struct_elt_for_reference): Likewise.
2465         * NEWS: Mention this change.
2466
2467 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2468
2469         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2470         print_source_lines.
2471         * source.c (print_source_lines_base): Update line number check.
2472         (print_source_lines): New function.
2473         (source_lines_range::source_lines_range): New function.
2474         * source.h (class source_lines_range): New class.
2475         (print_source_lines): New declaration.
2476
2477 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2478
2479         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2480
2481 2019-01-08  Tom Tromey  <tom@tromey.com>
2482             Simon Marchi  <simon.marchi@ericsson.com>
2483
2484         PR gdb/24060
2485         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2486         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2487         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2488         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2489         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2490         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2491
2492 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2493
2494         * source.c (select_source_symtab): Move header comment to
2495         declaration in source.h.
2496         (forget_cached_source_info_for_objfile): Likewise.
2497         (forget_cached_source_info): Likewise.
2498         (identify_source_line): Likewise.
2499         * source.h (identify_source_line): Move declaration from symtab.h
2500         and add comment from source.c
2501         (print_source_lines): Likewise.
2502         (forget_cached_source_info_for_objfile): Likewise.
2503         (forget_cached_source_info): Likewise.
2504         (select_source_symtab): Likewise.
2505         (enum print_source_lines_flag): Move definition from symtab.h.
2506         * symtab.h (identify_source_line): Move declaration to source.h.
2507         (print_source_lines): Likewise.
2508         (forget_cached_source_info_for_objfile): Likewise.
2509         (forget_cached_source_info): Likewise.
2510         (select_source_symtab): Likewise.
2511         (enum print_source_lines_flag): Move definition to source.h.
2512         * tui/tui-hooks.c: Add 'source.h' include.
2513
2514 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2515
2516         * source.c (print_source_lines_base): Handle requests to print
2517         reverse line number sequences, and guard against empty lines
2518         string.
2519
2520 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2521
2522         * source.c (print_source_lines_base): Fix skip of '\r' if next
2523         character is '\n'.
2524
2525 2019-01-06  Tom Tromey  <tom@tromey.com>
2526
2527         * c-exp.y (struct c_parse_state) <macro_original_text,
2528         expansion_obstack>: New member.
2529         (macro_original_text, expansion_obstack): Remove globals.
2530         (scan_macro_expansion, scanning_macro_expansion)
2531         (finished_macro_expansion): Update.
2532         (scan_macro_cleanup): Remove.
2533         (yylex, c_parse): Update.
2534
2535 2019-01-06  Tom Tromey  <tom@tromey.com>
2536
2537         * c-exp.y (struct c_parse_state) <strings>: New member.
2538         (operator_stoken): Update.
2539
2540 2019-01-06  Tom Tromey  <tom@tromey.com>
2541
2542         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2543         (union type_stack_elt) <typelist_val>: Now a pointer to
2544         std::vector.
2545         (type_stack_cleanup): Don't declare.
2546         (push_typelist): Update.
2547         * parse.c (pop_typelist): Return a std::vector.
2548         (push_typelist): Take a std::vector.
2549         (follow_types): Update.  Do not free args.
2550         (type_stack_cleanup): Remove.
2551         * c-exp.y (struct c_parse_state): New.
2552         (cpstate): New global.
2553         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2554         (nonempty_typelist): Update.
2555         (func_mod): Create a new vector.
2556         (c_parse): Create a c_parse_state.
2557         (check_parameter_typelist): Do not delete params.
2558         (function_method): Update.  Do not delete type_list.
2559
2560 2019-01-06  Tom Tromey  <tom@tromey.com>
2561
2562         PR gdb/28155:
2563         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2564         check_typedef.
2565         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2566         (print_return_value): Likewise.
2567
2568 2019-01-05  Tom Tromey  <tom@tromey.com>
2569
2570         * contrib/cleanup_check.py: Remove.
2571         * contrib/gcc-with-excheck: Remove.
2572         * contrib/exsummary.py: Remove.
2573         * contrib/excheck.py: Remove.
2574
2575 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2576
2577         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2578         NULL. Initialize tpprev to NULL instead of assigning it
2579         to NULL on the next statement.
2580         * windows-nat.c (windows_delete_thread): Remove check for
2581         main_thread_id before printing thread exit notifications.
2582         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2583         Remove thread ID check against main_thread_id.
2584         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2585         windows_delete_thread.
2586         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2587
2588 2019-01-04  Tom Tromey  <tom@tromey.com>
2589
2590         * compile/compile.c (_initialize_compile): Use upper case for
2591         metasyntactic variables.
2592         * symmisc.c (_initialize_symmisc): Use upper case for
2593         metasyntactic variables.
2594         * psymtab.c (_initialize_psymtab): Use upper case for
2595         metasyntactic variables.
2596         * demangle.c (demangle_command): Use upper case for metasyntactic
2597         variables.
2598         (_initialize_demangler): Likewise.
2599         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2600         variables.
2601
2602 2019-01-03  Tom Tromey  <tom@tromey.com>
2603
2604         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2605
2606 2019-01-03  Tom Tromey  <tom@tromey.com>
2607
2608         * python/py-symtab.c (salpy_str): Update.
2609         (struct salpy_sal_object) <symtab>: Now a PyObject.
2610         (salpy_dealloc): Update.
2611         (del_objfile_sal): Use gdbpy_ref.
2612
2613 2019-01-03  Tom Tromey  <tom@tromey.com>
2614
2615         * python/py-type.c (convert_field): Use new_reference.  Return
2616         gdbpy_ref.
2617         (make_fielditem): Return gdbpy_ref.
2618         (typy_fields): Update.
2619         (typy_getitem): Update.
2620         (field_name): Return gdbpy_ref.  Use new_reference.
2621         (typy_iterator_iternext): Update.
2622
2623 2019-01-03  Tom Tromey  <tom@tromey.com>
2624
2625         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2626
2627 2019-01-03  Tom Tromey  <tom@tromey.com>
2628
2629         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2630         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2631         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2632         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2633         (pspy_set_type_printers): Likewise.
2634         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2635         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2636         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2637         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2638         (objfpy_set_type_printers): Likewise.
2639
2640 2019-01-03  Tom Tromey  <tom@tromey.com>
2641
2642         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2643         (gdbpy_print_stack): Use gdbpy_err_fetch.
2644         * python/python-internal.h (class gdbpy_err_fetch): New class.
2645         (class gdbpy_enter) <m_error_type, m_error_value,
2646         m_error_traceback>: Remove.
2647         <m_error>: New member.
2648         (gdbpy_exception_to_string): Don't declare.
2649         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2650         * python/py-value.c (convert_value_from_python): Use
2651         gdbpy_err_fetch.
2652         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2653         gdbpy_exception_to_string.
2654         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2655         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2656         gdbpy_err_fetch.
2657
2658 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2659
2660         * linux-nat.c (delete_lwp_cleanup): Delete.
2661         (struct lwp_deleter): New struct.
2662         (lwp_info_up): New typedef.
2663         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2664         lwp_info_up.
2665
2666 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2667
2668         * linux-fork.c (class scoped_switch_fork_info): New class.
2669         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2670
2671 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2672
2673         * valops.c (find_overload_match): Remove use of null_cleanup, and
2674         calls to do_cleanups.
2675
2676 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2677
2678         * compile/compile-cplus-types.c
2679         (compile_cplus_instance::decl_name): Handle changes to
2680         cp_func_name.
2681         * cp-support.c (cp_func_name): Update header comment, update
2682         return type.
2683         * cp-support.h (cp_func_name): Update return type in declaration.
2684         * valops.c (find_overload_match): Move temp_func local to top
2685         level of function and change its type.  Use temp_func to hold and
2686         delete temporary string obtained from cp_func_name.
2687
2688 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2689
2690         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2691         gdb::char_vector, remove cleanup, and update uses of `msg`.
2692
2693 2019-01-03  Jim Wilson  <jimw@sifive.com>
2694
2695         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2696
2697 2019-01-02  Tom Tromey  <tom@tromey.com>
2698
2699         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2700         (tdesc_parse_xml): Remove cleanups.
2701         * target-descriptions.h (make_cleanup_free_target_description):
2702         Don't declare.
2703         (target_desc_deleter): New struct.
2704         (target_desc_up): New typedef.
2705         * target-descriptions.c (target_desc_deleter::operator()): Rename
2706         from free_target_description.
2707         (make_cleanup_free_target_description): Remove.
2708
2709 2019-01-02  Tom Tromey  <tom@tromey.com>
2710
2711         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2712         constructor, destructor.
2713         (linespec_parser): Remove typedef.
2714         (~linespec_parser): Rename from linespec_parser_delete.
2715         (linespec_lex_to_end, linespec_complete_label)
2716         (linespec_complete): Update.
2717         (decode_line_full): Remove cleanups.
2718         (decode_line_1): Update.
2719
2720 2019-01-02  Tom Tromey  <tom@tromey.com>
2721
2722         * python/python-internal.h (inferior_to_inferior_object): Change
2723         return type.
2724         * python/py-exitedevent.c (create_exited_event_object): Update.
2725         * python/py-inferior.c (inferior_to_inferior_object): Return
2726         gdbpy_ref.
2727         (python_new_inferior, python_inferior_deleted)
2728         (thread_to_thread_object, delete_thread_object)
2729         (build_inferior_list, gdbpy_selected_inferior): Update.
2730         * python/py-infthread.c (create_thread_object): Update.  Also fail
2731         if inferior_to_inferior_object fails.
2732
2733 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2734
2735         * inferior.h (class inferior) <displaced_step_state>: New field.
2736         * infrun.h (struct displaced_step_state): Move here from
2737         infrun.c.  Initialize fields, add constructor.
2738         <inf>: Remove field.
2739         <reset>: New method.
2740         * infrun.c (struct displaced_step_inferior_state): Move to
2741         infrun.h.
2742         (displaced_step_inferior_states): Remove.
2743         (get_displaced_stepping_state): Adust.
2744         (displaced_step_in_progress_any_inferior): Adjust.
2745         (displaced_step_in_progress_thread): Adjust.
2746         (displaced_step_in_progress): Adjust.
2747         (add_displaced_stepping_state): Remove.
2748         (get_displaced_step_closure_by_addr): Adjust.
2749         (remove_displaced_stepping_state): Remove.
2750         (infrun_inferior_exit): Call displaced_step_state.reset.
2751         (use_displaced_stepping): Don't check for NULL.
2752         (displaced_step_prepare_throw): Call
2753         get_displaced_stepping_state.
2754         (displaced_step_fixup): Don't check for NULL.
2755         (prepare_for_detach): Don't check for NULL.
2756
2757 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2758
2759         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2760          in case of call that did not complete.
2761
2762 2019-01-02  Andrey Utkin  <autkin@undo.io>
2763
2764         * symfile.c (find_separate_debug_file): Fix search of debug files for
2765         remote debuggee.
2766
2767 2019-01-02  Tom Tromey  <tom@tromey.com>
2768
2769         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2770         indentation.
2771         * python/py-frame.c (frapy_older): Remove cast.
2772         (frapy_newer): Likewise.
2773         * python/py-breakpoint.c (local_setattro): Remove cast.
2774         * python/py-arch.c (archpy_name): Remove local variable.
2775         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2776
2777 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2778
2779         * unittests/basic_string_view/element_access/char/empty.cc:
2780         Fix year range in copyright header.
2781
2782 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2783
2784         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2785         Delete.
2786         <operator==>: Update with for removed field.
2787         <hash>: Likewise.
2788         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2789         <isa_features>: ...this.
2790         <abi_features>: New field.
2791         (riscv_isa_flen): Update comment.
2792         (riscv_abi_xlen): New declaration.
2793         (riscv_abi_flen): New declaration.
2794         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2795         isa_features.
2796         (riscv_abi_xlen): New function.
2797         (riscv_isa_flen): Update to get answer from isa_features.
2798         (riscv_abi_flen): New function.
2799         (riscv_has_fp_abi): Update to get answer from abi_features.
2800         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2801         xlen and flen.
2802         (riscv_call_info) <xlen, flen>: Update comment.
2803         (riscv_call_arg_struct): Remove invalid assertions
2804         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2805         is removed.
2806         (riscv_gdbarch_init): Gather isa features and abi features
2807         separately, ensure both match on the gdbarch when reusing an old
2808         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2809         a target with 64-bit float hardware.
2810
2811 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2812
2813         * source.c (search_command_helper): Stop reverse search
2814         when line 1 has been searched.
2815
2816 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2817
2818         * record-full.c (record_full_base_target::close): Rewrite
2819         record_full_core_buf_list free logic.
2820
2821 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2822
2823         * break-catch-syscall.c (print_one_catch_syscall): xfree
2824         the last text.
2825
2826 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2827
2828         * top.c (print_gdb_version): Update Copyright year in version
2829         message.
2830
2831 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2832
2833         Update copyright year range in all GDB files.
2834
2835 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2836
2837         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2838
2839 For older changes see ChangeLog-2018.
2840 \f
2841 Local Variables:
2842 mode: change-log
2843 left-margin: 8
2844 fill-column: 74
2845 version-control: never
2846 coding: utf-8
2847 End:
2848