Remove init_cli_cmds
[external/binutils.git] / gdb / ChangeLog
1 2019-07-11  Tom Tromey  <tromey@adacore.com>
2
3         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
5         * top.h (gdbinit): Don't declare.
6         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7         into...
8         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
9         * top.c (gdb_init): Don't call init_cli_cmds.
10         (gdbinit): Remove.
11         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
12
13 2019-07-11  Tom Tromey  <tromey@adacore.com>
14
15         * python/py-inferior.c (add_thread_object): Don't use thread_obj
16         after it has been moved.
17
18 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
19
20         * valops.c (value_must_coerce_to_target): Change return type to
21         bool.
22         * value.h (value_must_coerce_to_target): Likewise.
23
24 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
25
26         * breakpoint.c (is_hardware_watchpoint): Remove
27         forward-declaration.
28         (is_masked_watchpoint): Change return type to bool.
29         (is_tracepoint): Likewise.
30         (is_breakpoint): Likewise.
31         (is_hardware_watchpoint): Likewise.
32         (is_watchpoint): Likewise.
33         (is_no_memory_software_watchpoint): Likewise.
34         (is_catchpoint): Likewise.
35         (breakpoint_1): Make FILTER parameter's return type bool.
36         is_masked_watchpoint): Change return type to bool.
37         (save_breakpoints): Make FILTER parameter's return type bool.
38         * breakpoint.h (is_breakpoint): Change return type to bool.
39         (is_watchpoint): Likewise.
40         (is_catchpoint): Likewise.
41         (is_tracepoint): Likewise.
42
43 2019-07-10  Tom Tromey  <tom@tromey.com>
44
45         * defs.h: Don't include gdbarch.h.
46         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
47         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
48         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
49         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
50         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
51         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
52         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
53         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
54         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
55         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
56         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
57         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
58         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
59         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
60         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
61         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
62         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
63         record-btrace.c, record.h, regcache-dump.c, regcache.h,
64         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
65         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
66         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
67         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
68         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
69         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
70         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
71         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
72         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
73
74 2019-07-10  Tom Tromey  <tromey@adacore.com>
75
76         * ada-lang.h (is_ada_exception_catchpoint): Declare.
77         * breakpoint.c (init_ada_exception_breakpoint): Register as
78         bp_catchpoint.
79         (print_one_breakpoint_location, print_one_breakpoint): Use
80         is_ada_exception_catchpoint.
81         * ada-lang.c (class ada_catchpoint_location): Pass
82         bp_loc_software_breakpoint to bp_location constructor.
83         (is_ada_exception_catchpoint): New function.
84
85 2019-07-10  Tom Tromey  <tromey@adacore.com>
86
87         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
88         VEC.
89         (struct arm_exidx_entry): New method operator<.
90         (struct arm_exidx_data) <section_maps>: Change type.
91         (arm_exidx_data_free): Remove.
92         (arm_exidx_data_key): Change type.  Move lower.
93         (arm_exidx_new_objfile): Update.
94         (arm_compare_exidx_entries): Remove.
95         (arm_find_exidx_entry, _initialize_arm_tdep)
96
97 2019-07-10  Tom Tromey  <tromey@adacore.com>
98
99         * solib-spu.c (ocl_program_data_key): Change type.
100         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
101         Update.
102
103 2019-07-10  Tom Tromey  <tromey@adacore.com>
104
105         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
106         (struct solib_aix_inferior_data) <library_list>: Change type.
107         (solib_aix_inferior_data_handle): Change type.
108         (get_solib_aix_inferior_data): Update.
109         (solib_aix_free_library_list): Remove.
110         (library_list_start_library): Update.
111         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
112         return type.
113         (solib_aix_get_library_list)
114         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
115         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
116
117 2019-07-10  Tom Tromey  <tromey@adacore.com>
118
119         * solib-dsbt.c (struct dsbt_info): Add initializers.
120         (solib_dsbt_pspace_data): Change type.
121         (dsbt_pspace_data_cleanup): Remove.
122         (get_dsbt_info, _initialize_dsbt_solib): Update.
123
124 2019-07-10  Tom Tromey  <tromey@adacore.com>
125
126         * spu-tdep.c (spu_overlay_data): Change type.
127         (spu_get_overlay_table, spu_overlay_new_objfile)
128         (_initialize_spu_tdep): Update.
129
130 2019-07-10  Tom Tromey  <tromey@adacore.com>
131
132         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
133         destructor.
134         (dbx_objfile_data_key): Change type and declare later.
135         (DBX_SYMFILE_INFO): Rewrite.
136         * dbxread.c (dbx_objfile_data_key): Change type.
137         (dbx_symfile_init): Update.
138         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
139         (coffstab_build_psymtabs, elfstab_build_psymtabs)
140         (stabsect_build_psymtabs, _initialize_dbxread): Update.
141
142 2019-07-10  Tom Tromey  <tromey@adacore.com>
143
144         * jit.c (jit_program_space_key): Change type.  Move lower.
145         (get_jit_program_space_data): Update.
146         (jit_program_space_data_cleanup): Remove.
147         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
148         Update.
149         (struct jit_program_space_data): Add initializers.
150
151 2019-07-10  Tom Tromey  <tromey@adacore.com>
152
153         * solib-darwin.c (struct darwin_info): Add initializers.
154         (solib_darwin_pspace_data): Change type.
155         (darwin_pspace_data_cleanup): Remove.
156         (get_darwin_info, _initialize_darwin_solib): Update.
157
158 2019-07-10  Tom Tromey  <tromey@adacore.com>
159
160         * remote-sim.c (struct sim_inferior_data): Add initializers,
161         constructor, and destructor.
162         (sim_inferior_data_key): Change type.  Move lower.
163         (check_for_duplicate_sim_descriptor): Update.
164         (get_sim_inferior_data): Use new.  Update.
165         (~sim_inferior_data_cleanup): Rename from
166         sim_inferior_data_cleanup.  Simplify.
167         (gdbsim_close_inferior, simulator_command)
168         (sim_command_completer, _initialize_remote_sim): Update.
169         (next_pid, INITIAL_PID): Move earlier.
170
171 2019-07-10  Tom Tromey  <tromey@adacore.com>
172
173         * python/python-internal.h (create_thread_object): Return
174         gdbpy_ref.
175         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
176         * python/py-inferior.c (struct threadlist_entry): Add
177         constructor.
178         <thread_obj>: Now a gdbpy_ref.
179         (thread_to_thread_object): Update.
180         (add_thread_object): Use new.
181         (delete_thread_object): Use delete.
182         (infpy_threads): Update.
183         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
184         GIL.
185
186 2019-07-10  Tom Tromey  <tromey@adacore.com>
187
188         * valops.c (value_cast): Specialize error message for Ada.
189
190 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
191
192         * breakpoint.c (breakpoint_1): Update doc and parameter names.
193
194 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
195
196         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
197         bpstat_should_step): Return bool, adjust comments.
198         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
199         bpstat_should_step): Likewise.
200
201 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
202
203         * features/Makefile: Use feature target descriptions for Arm.
204         * features/arm/arm-core.c: Generate new file.
205         * features/arm/arm-fpa.c: Likewise.
206         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
207         * features/arm/arm-m-profile.c: Likewise.
208         * features/arm/arm-vfpv2.c: Likewise.
209         * features/arm/arm-vfpv3.c: Likewise.
210         * features/arm/xscale-iwmmxt.c: Likewise.
211         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
212
213 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
214
215         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
216         ptrace earlier.
217
218 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
219
220         * features/aarch64-pauth.c: Regenerate.
221
222 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
223
224         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
225         bool.
226         (bpstat_what): Use false instead of 0.
227
228 2019-07-09  Pedro Alves  <palves@redhat.com>
229
230         * break-catch-throw.c (is_exception_catchpoint): New.
231         * breakpoint.c (print_one_breakpoint_location): New parameter
232         'raw_loc'.  Handle it.  Use
233         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
234         looking at the breakpoint's type.
235         (print_one_breakpoint): If handling "maint info breakpoints", also
236         print locations of exception catchpoints.
237         * breakpoint.h (is_exception_catchpoint): Declare.
238
239 2019-07-09  Pedro Alves  <palves@redhat.com>
240
241         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
242         "addr" field.
243         (allocate_location_exception_catchpoint): New.
244         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
245         (initialize_throw_catchpoint_ops): Install
246         allocate_location_exception_catchpoint as allocate_location
247         method.
248         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
249         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
250         bp_loc_other.
251         (breakpoint_address_is_meaningful): Delete.
252         (bl_address_is_meaningful): New.
253         (breakpoint_locations_match): Adjust comment.
254         (bp_location_from_bp_type): New, factored out of...
255         (bp_location::bp_location(breakpoint *)): ... this.
256         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
257         factored out of...
258         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
259         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
260         breakpoint_address_is_meaningful.
261         (bp_locations_compare): Adjust comment.
262         (update_global_location_list): Use bl_address_is_meaningful
263         instead of breakpoint_address_is_meaningful.
264         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
265         explicit.
266         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
267         * python/py-breakpoint.c (bppy_get_location): No longer check
268         whether location is null.
269
270 2019-07-09  Pedro Alves  <palves@redhat.com>
271
272         PR c++/15468
273         * breakpoint.c (print_one_breakpoint_location): Remove
274         single-location assert.
275
276 2019-07-09  Tom Tromey  <tom@tromey.com>
277
278         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
279         * configure: Rebuild.
280         * configure.ac: Change common to gdbsupport.
281         * gdbsupport: Rename from common.
282         * acinclude.m4: Change common to gdbsupport.
283         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
284         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
285         gdbsupport.
286         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
287         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
288         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
289         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
290         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
291         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
292         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
293         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
294         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
295         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
296         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
297         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
298         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
299         coff-pe-read.c, command.h, compile/compile-c-support.c,
300         compile/compile-c.h, compile/compile-cplus-symbols.c,
301         compile/compile-cplus-types.c, compile/compile-cplus.h,
302         compile/compile-loc2c.c, compile/compile.c, completer.c,
303         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
304         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
305         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
306         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
307         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
308         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
309         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
310         features/aarch64-core.c, features/aarch64-fpu.c,
311         features/aarch64-pauth.c, features/aarch64-sve.c,
312         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
313         features/i386/32bit-core.c, features/i386/32bit-linux.c,
314         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
315         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
316         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
317         features/i386/64bit-core.c, features/i386/64bit-linux.c,
318         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
319         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
320         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
321         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
322         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
323         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
324         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
325         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
326         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
327         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
328         go32-nat.c, guile/guile.c, guile/scm-ports.c,
329         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
330         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
331         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
332         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
333         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
334         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
335         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
336         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
337         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
338         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
339         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
340         minsyms.c, mips-linux-tdep.c, namespace.h,
341         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
342         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
343         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
344         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
345         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
346         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
347         nat/linux-waitpid.c, nat/mips-linux-watch.c,
348         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
349         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
350         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
351         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
352         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
353         procfs.c, producer.c, progspace.h, psymtab.h,
354         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
355         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
356         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
357         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
358         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
359         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
360         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
361         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
362         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
363         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
364         target-memory.c, target.c, target.h, target/waitstatus.c,
365         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
366         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
367         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
368         unittests/array-view-selftests.c,
369         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
370         unittests/common-utils-selftests.c,
371         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
372         unittests/format_pieces-selftests.c,
373         unittests/function-view-selftests.c,
374         unittests/lookup_name_info-selftests.c,
375         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
376         unittests/mkdir-recursive-selftests.c,
377         unittests/observable-selftests.c,
378         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
379         unittests/parse-connection-spec-selftests.c,
380         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
381         unittests/scoped_fd-selftests.c,
382         unittests/scoped_mmap-selftests.c,
383         unittests/scoped_restore-selftests.c,
384         unittests/string_view-selftests.c, unittests/style-selftests.c,
385         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
386         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
387         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
388         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
389         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
390         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
391
392 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
393
394         * linespec.c (decode_digits_list_mode): Set explicit_line to a
395         bool value.
396         (decode_digits_ordinary): Set explicit_line field in sal.
397         * symtab.c (skip_prologue_sal): Don't skip prologue for a
398         symtab_and_line that was set on an explicit line number in
399         assembler code.  Do always update the recorded symtab and line if
400         we do skip the prologue.
401
402 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
403
404         * breakpoint.c (set_breakpoint_location_function): Remove
405         explicit_loc parameter.
406         (momentary_breakpoint_from_master): Update call to
407         set_breakpoint_location_function.
408         (add_location_to_breakpoint): Likewise.
409
410 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
411
412         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
413         required features based on default bfd type when no specific bfd
414         is present.
415
416 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
417
418         * NEWS: Mention that GDB printf and eval commands can now print
419         C-style and Ada-style convenience var strings without
420         calling the inferior.
421         * printcmd.c (printf_c_string): Locally print GDB internal var
422         instead of transiting via the inferior.
423         (printf_wide_c_string): Likewise.
424
425 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
426
427         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
428
429 2019-07-04  Tom Tromey  <tom@tromey.com>
430
431         PR tui/24724:
432         * tui/tui-winsource.c (tui_clear_source_content): Update.
433         (tui_source_window_base::set_is_exec_point_at): Fix comment.
434         (tui_update_breakpoint_info): Update.
435         (tui_set_exec_info_content): Update.
436         * tui/tui-source.c (tui_set_source_content_nil): Update.
437         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
438         has_break.
439         * tui/tui-data.h (enum tui_bp_flag): New.
440         (tui_bp_flags): New enum flags type.
441         (struct tui_source_element) <break_mode>: Change type.  Rename
442         from has_break.
443         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
444         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
445         constants.
446         * tui/tui-winsource.h: Fix comment.
447
448 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
449
450         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
451         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
452         (store_fpregs_to_thread)
453         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
454         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
455         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
456         (IWMMXT_REGS_SIZE): Add define.
457         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
458         (fetch_vfp_regs, store_vfp_regs)
459         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
460         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
461
462 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
463
464         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
465         defines.
466         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
467         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
468         (ARM_INT_REGISTER_SIZE): ...to this.
469         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
470         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
471         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
472         (arm_linux_collect_gregset, supply_nwfpe_register)
473         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
474         defines.
475         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
476         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
477         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
478         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
479         (arm_return_in_memory, arm_store_return_value)
480         (arm_get_longjmp_target, arm_register_g_packet_guesses)
481         (arm_record_ld_st_multiple): Likewise.
482         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
483         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
484
485 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
486
487         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
488         AARCH64_DISPLACED_MODIFIED_INSNS.
489         * aarch64-tdep.c (struct aarch64_displaced_step_data)
490         (aarch64_displaced_step_copy_insn): Likewise.
491         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
492         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
493         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
494         ARM_DISPLACED_MODIFIED_INSNS.
495         * arm-tdep.c (arm_gdbarch_init): Likewise.
496         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
497         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
498         (struct arm_displaced_step_closure): Use
499         ARM_DISPLACED_MODIFIED_INSNS.
500
501 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
502
503         * features/Makefile: Remove unused xml files.
504         * features/aarch64.xml: Remove.
505         * features/i386/amd64-avx-avx512-linux.xml: Remove.
506         * features/i386/amd64-avx-avx512.xml: Remove.
507         * features/i386/amd64-avx-linux.xml: Remove.
508         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
509         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
510         * features/i386/amd64-avx-mpx-linux.xml: Remove.
511         * features/i386/amd64-avx-mpx.xml: Remove.
512         * features/i386/amd64-avx.xml: Remove.
513         * features/i386/amd64-linux.xml: Remove.
514         * features/i386/amd64-mpx-linux.xml: Remove.
515         * features/i386/amd64-mpx.xml: Remove.
516         * features/i386/amd64.xml: Remove.
517         * features/i386/i386-avx-avx512-linux.xml: Remove.
518         * features/i386/i386-avx-avx512.xml: Remove.
519         * features/i386/i386-avx-linux.xml: Remove.
520         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
521         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
522         * features/i386/i386-avx-mpx-linux.xml: Remove.
523         * features/i386/i386-avx-mpx.xml: Remove.
524         * features/i386/i386-avx.xml: Remove.
525         * features/i386/i386-linux.xml: Remove.
526         * features/i386/i386-mmx-linux.xml: Remove.
527         * features/i386/i386-mmx.xml: Remove.
528         * features/i386/i386-mpx-linux.xml: Remove.
529         * features/i386/i386-mpx.xml: Remove.
530         * features/i386/i386.xml: Remove.
531         * features/i386/x32-avx-avx512-linux.xml: Remove.
532         * features/i386/x32-avx-linux.xml: Remove.
533         * features/i386/x32-linux.xml: Remove.
534
535 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
536
537         * regformats/aarch64.dat: Remove.
538         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
539         * regformats/i386/amd64-avx-linux.dat: Remove.
540         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
541         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
542         * regformats/i386/amd64-linux.dat: Remove.
543         * regformats/i386/amd64-mpx-linux.dat: Remove.
544         * regformats/i386/amd64.dat: Remove.
545         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
546         * regformats/i386/i386-avx-linux.dat: Remove.
547         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
548         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
549         * regformats/i386/i386-linux.dat: Remove.
550         * regformats/i386/i386-mmx-linux.dat: Remove.
551         * regformats/i386/i386-mpx-linux.dat: Remove.
552         * regformats/i386/i386.dat: Remove.
553         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
554         * regformats/i386/x32-avx-linux.dat: Remove.
555         * regformats/i386/x32-linux.dat: Remove.
556
557 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
558
559         * aarch64-tdep.c: Remove xml self tests.
560         * amd64-linux-tdep.c: Likewise.
561         * amd64-tdep.c: Likewise.
562         * i386-linux-tdep.c: Likewise.
563         * i386-tdep.c: Likewise.
564
565 2019-07-03  Pedro Alves  <palves@redhat.com>
566
567         PR cli/24732
568         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
569         (pipe_cmd_option_defs): New.
570         (make_pipe_cmd_options_def_group): New.
571         (pipe_command): Use gdb::option::process_options.
572         (pipe_command_completer): New function.
573         (_initialize_cli_cmds): Install completer for "pipe" command.
574
575 2019-07-03  Pedro Alves  <palves@redhat.com>
576
577         * cli/cli-option.c (union option_value) <string>: New field.
578         (struct option_def_and_value): Add ctor, move ctor, dtor and
579         use DISABLE_COPY_AND_ASSIGN.
580         (option_def_and_value::clear_value): New.
581         (parse_option, save_option_value_in_ctx, get_val_type_str)
582         (add_setshow_cmds_for_options): Handle var_string.
583         * cli-option.h (union option_def::var_address) <string>: New
584         field.
585         (struct string_option_def): New.
586         * maint-test-options.c (struct test_options_opts): Add default
587         ctor and use DISABLE_COPY_AND_ASSIGN.
588         <string_opt>: New field.
589         (test_options_opts::~test_options_opts): New.
590         (test_options_opts::dump): Also dump "-string".
591         (test_options_option_defs): Install "string.
592
593 2019-07-03  Pedro Alves  <palves@redhat.com>
594
595         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
596         option_value with a null enumeration.
597         (complete_options): Save the option values in the context.
598         (save_option_value_in_ctx): New, factored out from ...
599         (process_options): ... here.
600         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
601         of the function.
602         * maint-test-options.c (test_options_opts::dump): New, factored
603         out from ...
604         (maintenance_test_options_command_mode): ... here.
605         (maintenance_test_options_command_completion_result): Delete.
606         (maintenance_test_options_command_completion_text): Update
607         comment.
608         (maintenance_show_test_options_completion_result): Change
609         prototype.  Just print
610         maintenance_test_options_command_completion_text.
611         (save_completion_result): New.
612         (maintenance_test_options_completer_mode): Pass options context to
613         complete_options, and then save a dump.
614         (_initialize_maint_test_options): Use add_cmd to install "maint
615         show test-options-completion-result".
616
617 2019-07-03  Pedro Alves  <palves@redhat.com>
618
619         * NEWS (New commands): Mention "with" and "maint with".
620         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
621         (with_command, with_command_completer): New.
622         (pipe_command): Adjust to new repeat_previous
623         interface.
624         (_initialize_cli_cmds): Install the "with" command and its "w"
625         alias.
626         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
627         declarations.
628         * cli/cli-setshow.c (parse_cli_var_uinteger)
629         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
630         argument strings for all var_types.
631         (get_setshow_command_value_string): New, factored out from ...
632         (do_show_command): ... this.
633         * cli/cli-setshow.h: Include <string>.
634         (get_setshow_command_value_string): Declare.
635         * command.h (repeat_previous): Now returns const char *.  Adjust
636         comment.
637         * maint.c: Include "cli/cli-cmds.h".
638         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
639         (_initialize_maint_cmds): Register the "maintenance with" command.
640         * top.c (repeat_previous): Move bits from pipe_command here:
641         Return the saved command line, if any; error out if there's no
642         command to relaunch.
643
644 2019-07-03  Pedro Alves  <palves@redhat.com>
645
646         * NEWS (New commands): Mention "maint set/show test-settings"
647         instead of "maint test-settings".
648         * maint-test-settings.c (maintenance_test_settings_list): Delete.
649         (maintenance_test_settings_set_list): Rename to ...
650         (maintenance_set_test_settings_list): ... this.
651         (maintenance_test_settings_show_list): Rename to  ...
652         (maintenance_show_test_settings_list): ... this.
653         (maintenance_test_settings_cmd): Delete.
654         (maintenance_test_settings_set_cmd): ...
655         (maintenance_set_test_settings_cmd): ... this.
656         (maintenance_test_settings_show_cmd): ...
657         (maintenance_show_test_settings_cmd): ... this.
658         (maintenance_test_settings_show_value_cmd):
659         (maintenance_show_test_settings_value_cmd): ... this.
660         (_initialize_maint_test_settings): No longer install the "maint
661         test-settings" prefix command.  Rename "maint test-settings set"
662         to "maint set test-settings", and "maint test-settings show" to
663         "maint show test-settings".  Adjust all subcommands.
664
665 2019-07-03  Pedro Alves  <palves@redhat.com>
666
667         * maint-test-settings.c: Fix file's intro comment.  Replace all
668         references to "test-options" with references to "test-settings",
669         in comments.
670
671 2019-07-03  Pedro Alves  <palves@redhat.com>
672
673         * maint-test-settings.c (maintenance_test_settings_xxx)
674         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
675         New.
676         (maintenance_test_settings_enums): Use them.
677         (maintenance_test_settings_enum): Default to
678         maintenance_test_settings_xxx.
679         (_initialize_maint_test_settings): Initialize
680         MAINTENANCE_TEST_SETTINGS_FILENAME.
681
682 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
683
684         * breakpoint.h (remove_breakpoints_inf): Change return type to
685         void, move function documentation here.
686         * breakpoint.c (remove_breakpoints_inf): Change return type to
687         void, move function documentation to header.
688
689 2019-07-02  Pedro Alves  <palves@redhat.com>
690
691         * NEWS (Completion improvements): Mention "info threads".
692         * thread.c (struct info_threads_opts, info_threads_option_defs)
693         (make_info_threads_options_def_group): New.
694         (info_threads_command): Use gdb::option::process_options.
695         (info_threads_command_completer): New.
696         (_initialize_thread): Use gdb::option::build_help to build the
697         help text for "info threads".
698
699 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
700
701         * defs.h (generic_load): Move from here...
702         * symfile.h (generic_load): ... to here.  Rename name parameter
703         to args.
704         * symfile.c (generic_load): Add comment.
705
706 2019-07-01  Tom Tromey  <tromey@adacore.com>
707
708         * dwarf2read.c
709         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
710         declaration of without_params.  Fix formatting.
711
712 2019-07-01  Tom Tromey  <tromey@adacore.com>
713
714         * ada-exp.y (find_primitive_type): Update.
715         * ada-lang.h (ada_lookup_symbol): Update.
716         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
717         parameter.
718         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
719
720 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
721
722         PR breakpoints/24541
723         * gdbarch.c: Regenerate.
724         * gdbarch.h: Regenerate.
725         * gdbarch.sh: Add 'stap_adjust_register'.
726         * i386-tdep.c: Include '<unordered_set>'.
727         (i386_stap_adjust_register): New function.
728         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
729         * stap-probe.c (stap_parse_register_operand): Call
730         'gdbarch_stap_adjust_register'.
731
732 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
733
734         PR python/24742
735         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
736         * python/python.c (do_start_initialization): Use 'xmalloc'
737         instead of 'PyMem_Malloc'.
738
739 2019-06-28  Tom Tromey  <tromey@adacore.com>
740
741         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
742         for Ada.
743
744 2019-06-27  Tom Tromey  <tromey@adacore.com>
745
746         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
747         objfile_key.
748         (arm_find_mapping_symbol, arm_record_special_symbol)
749         (_initialize_arm_tdep): Update.
750         (arm_objfile_data_free): Remove.
751
752 2019-06-27  Tom Tromey  <tromey@adacore.com>
753
754         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
755         to cp_print_static_field.
756
757 2019-06-26  Tom Tromey  <tromey@adacore.com>
758
759         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
760         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
761         declare.
762
763 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
764
765         * features/aarch64-core.c (create_feature_aarch64_core):
766         Regenerate.
767         * features/aarch64-core.xml: Add cpsr flags.
768
769 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
770
771         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
772         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
773
774 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
775
776         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
777         field.
778         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
779         use.
780         (arm_record_special_symbol): Don't insert new symbol in sorted
781         position, push it at the end.
782
783 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
784
785         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
786         (arm_mapping_symbol_s): Remove.
787         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
788         (arm_mapping_symbol_vec): New typedef.
789         (struct arm_per_objfile): Add constructor.
790         <section_maps>: Change type to
791         std::unique_ptr<arm_mapping_symbol_vec[]>.
792         (arm_compare_mapping_symbols): Remove.
793         (arm_find_mapping_symbol): Adjust to section_maps type change.
794         (arm_objfile_data_free): Call delete on arm_per_objfile.
795         (arm_record_special_symbol): Adjust to section_maps type change.
796         Allocate arm_per_objfile with new.
797
798 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
799
800         * cli/cli-cmds.c (alias_command): Compare the alias prefix
801         with the command prefix.
802
803 2019-06-25  Tom Tromey  <tom@tromey.com>
804
805         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
806         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
807
808 2019-06-25  Tom Tromey  <tom@tromey.com>
809
810         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
811         type.
812         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
813         protected.
814
815 2019-06-25  Tom Tromey  <tom@tromey.com>
816
817         * tui/tui-winsource.c
818         (tui_source_window_base::set_is_exec_point_at): Add check against
819         LOA_ADDRESS.
820
821 2019-06-25  Tom Tromey  <tom@tromey.com>
822
823         * tui/tui-source.c (tui_set_source_content): Don't check before
824         xfree.
825         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
826
827 2019-06-25  Tom Tromey  <tom@tromey.com>
828
829         * tui/tui-winsource.h (tui_update_source_window_as_is)
830         (tui_alloc_source_buffer, tui_line_is_displayed)
831         (tui_addr_is_displayed): Change type of win_info.
832         * tui/tui-winsource.c (tui_update_source_window_as_is)
833         (tui_clear_source_content, tui_show_source_line)
834         (tui_show_source_content, tui_source_window_base::refill)
835         (tui_source_window_base::set_is_exec_point_at)
836         (tui_source_window_base::set_is_exec_point_at)
837         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
838         (tui_alloc_source_buffer, tui_line_is_displayed)
839         (tui_addr_is_displayed): Change type of win_info.  Update.
840         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
841         (tui_source_window_base::do_make_visible_with_new_height):
842         Update.
843         * tui/tui-source.c (tui_set_source_content)
844         (tui_set_source_content_nil)
845         (tui_source_window::do_scroll_vertical): Update.
846         * tui/tui-layout.c (show_layout): Update.
847         * tui/tui-disasm.c (tui_set_disassem_content)
848         (tui_disasm_window::do_scroll_vertical): Update.
849         * tui/tui-data.h (tui_win_content): Remove.
850         (struct tui_gen_win_info) <content, content_size>: Remove.
851         (struct tui_source_element): Add initializers and destructor.
852         (union tui_which_element, struct tui_win_element): Remove.
853         (struct tui_source_window_base) <content>: New field.
854         (struct tui_data_window): Remove destructor.
855         (tui_alloc_content, tui_free_win_content)
856         (tui_free_all_source_wins_content): Don't declare.
857         * tui/tui-data.c (tui_initialize_static_data): Update.
858         (init_content_element, tui_alloc_content): Remove.
859         (~tui_gen_win_info): Update.
860         (~tui_data_window, tui_free_all_source_wins_content)
861         (tui_free_win_content, free_content, free_content_elements):
862         Remove.
863
864 2019-06-25  Tom Tromey  <tom@tromey.com>
865
866         * tui/tui-winsource.h (tui_clear_source_content)
867         (tui_erase_source_content, tui_show_source_content): Change type
868         of win_info.
869         * tui/tui-winsource.c (tui_clear_source_content)
870         (tui_erase_source_content, tui_show_source_content): Change type
871         of win_info.
872         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
873         * tui/tui-source.h (tui_set_source_content_nil): Change type of
874         win_info.
875         * tui/tui-source.c (tui_set_source_content_nil): Change type of
876         win_info.
877         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
878
879 2019-06-25  Tom Tromey  <tom@tromey.com>
880
881         * tui/tui-winsource.c (tui_clear_source_content)
882         (tui_source_window_base::set_is_exec_point_at): Update.
883         * tui/tui-source.c (tui_set_source_content_nil): Update.
884         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
885         a bool.
886         * tui/tui-data.c (init_content_element): Update.
887
888 2019-06-25  Tom Tromey  <tom@tromey.com>
889
890         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
891         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
892         * tui/tui-layout.c (init_and_make_win): Update.
893         * tui/tui.h (enum tui_win_type): Update.
894         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
895         tui_win_is_auxillary.
896         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
897         tui_win_is_auxillary.
898
899 2019-06-25  Tom Tromey  <tom@tromey.com>
900
901         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
902         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
903         (tui_delete_data_content_windows, tui_display_all_data)
904         (tui_data_window::do_scroll_vertical, tui_display_data_from):
905         Update.
906         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
907         * tui/tui-regs.c (tui_last_regs_line_no)
908         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
909         (tui_show_registers): Update.
910         (tui_show_register_group): Return void.  Update.
911         (tui_display_registers_from, tui_display_reg_element_at_line)
912         (tui_display_registers_from_line, tui_check_register_values):
913         Update.
914         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
915         member.
916         (struct tui_data_window) <regs_content>: Now a std::vector.
917         <regs_content_count>: Remove.
918         (tui_add_content_elements, tui_free_data_content): Don't declare.
919         * tui/tui-data.c (tui_data_window::clear_detail): Update.
920         (init_content_element): Remove DATA_WIN case.  Add assert.
921         (tui_add_content_elements): Remove.
922         (tui_data_window): Update.
923         (tui_free_data_content): Remove.
924         (free_content_elements): Remove DATA_WIN case.
925
926 2019-06-25  Tom Tromey  <tom@tromey.com>
927
928         * tui/tui-data.c (tui_data_item_window): Update.
929         * tui/tui-windata.h (tui_check_data_values): Don't declare.
930         * tui/tui-windata.c (tui_display_all_data)
931         (tui_display_data_from_line): Update.
932         (tui_check_data_values): Remove.
933         * tui/tui-regs.c (tui_show_register_group)
934         (tui_display_reg_element_at_line): Update.
935         * tui/tui-hooks.c (tui_register_changed)
936         (tui_refresh_frame_and_register_information): Call
937         tui_check_register_values.
938         * tui/tui-data.h (struct tui_data_window) <data_content,
939         data_content_count, data_type>: Remove.
940         (enum tui_data_type): Remove.
941
942         * tui/tui-data.c (tui_data_window::clear_detail)
943         (~tui_data_window): Update.
944
945 2019-06-25  Tom Tromey  <tom@tromey.com>
946
947         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
948         declare.
949         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
950         Rename from tui_first_data_item_displayed.  Update.
951         (tui_data_window::refresh_all)
952         (tui_data_window::do_scroll_vertical): Update.
953         * tui/tui-data.h (struct tui_data_window)
954         <first_data_item_displayed>: Declare new method.
955
956 2019-06-25  Tom Tromey  <tom@tromey.com>
957
958         * tui/tui-data.h (tui_init_generic_part): Don't declare.
959         * tui/tui-data.c (tui_init_generic_part): Remove, moving
960         contents...
961         (tui_initialize_static_data): ...here.
962
963 2019-06-25  Tom Tromey  <tom@tromey.com>
964
965         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
966         (tui_display_registers_from, tui_check_register_values): Update.
967         (tui_display_register): Remove win_info parameter; update.
968         (tui_get_register): Change type of parameters.
969         * tui/tui-data.h (struct tui_data_element): Remove.
970         (union tui_which_element) <data>: Remove.
971         <data_window>: Change type.
972         (struct tui_data_item_window): New.
973         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
974         case.  Add assert.
975         (~tui_data_item_window): New destructor.
976         (free_content_elements): Remove DATA_ITEM_WIN case.
977
978 2019-06-25  Tom Tromey  <tom@tromey.com>
979
980         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
981         Remove.
982
983 2019-06-25  Tom Tromey  <tom@tromey.com>
984
985         * tui/tui-data.h (struct tui_command_element): Remove.
986         (union tui_which_element) <command>: Remove.
987         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
988         assert.
989         (free_content_elements): Remove CMD_WIN case.
990
991 2019-06-25  Tom Tromey  <tom@tromey.com>
992
993         * tui/tui-layout.c (tui_set_layout): Update.
994         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
995         * tui/tui-data.c (layout_def): Update.
996
997 2019-06-25  Tom Tromey  <tom@tromey.com>
998
999         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1000         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1001         (tui_source_window_base::set_new_height): Update.
1002         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1003         Update.
1004         (tui_set_locator_fullname, tui_set_locator_info)
1005         (tui_show_frame_info): Update.
1006         * tui/tui-source.c (tui_set_source_content)
1007         (tui_source_is_displayed): Update.
1008         * tui/tui-layout.c (show_source_disasm_command, show_data)
1009         (show_source_or_disasm_and_command): Update.
1010         * tui/tui-disasm.c (tui_set_disassem_content)
1011         (tui_get_begin_asm_address): Update.
1012         * tui/tui-data.h (struct tui_locator_element): Remove.
1013         (union tui_which_element) <locator>: Remove.
1014         (struct tui_locator_window): New.
1015         (tui_locator_win_info_ptr): Change return type.
1016         * tui/tui-data.c (_locator): Change type.
1017         (tui_locator_win_info_ptr): Change return type.
1018         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1019         (tui_alloc_content): Add assert.
1020
1021 2019-06-25  Tom Tromey  <tom@tromey.com>
1022
1023         * tui/tui-winsource.c
1024         (tui_exec_info_window::maybe_allocate_content): New method.
1025         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1026         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1027         (make_source_or_disasm_window): Add cast.
1028         * tui/tui-data.h (union tui_which_element) <simple_string>:
1029         Remove.
1030         (struct tui_source_info): New.
1031         (struct tui_source_window_base) <execution_info>: Change type.
1032         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1033         case, and add assert.
1034         (tui_alloc_content): Add assert.
1035
1036 2019-06-25  Tom Tromey  <tom@tromey.com>
1037
1038         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1039         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1040         * tui/tui-data.c (tui_alloc_win_info): Remove.
1041
1042 2019-06-25  Tom Tromey  <tom@tromey.com>
1043
1044         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1045         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1046         can_highlight.
1047
1048 2019-06-25  Tom Tromey  <tom@tromey.com>
1049
1050         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1051         make_visible_with_new_height method.
1052         (tui_win_info::make_visible_with_new_height): New method.
1053         (tui_source_window_base::do_make_visible_with_new_height)
1054         (tui_data_window::do_make_visible_with_new_height)
1055         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1056         (make_visible_with_new_height): Remove.
1057         (tui_resize_all, tui_adjust_win_heights): Use
1058         make_visible_with_new_height method.
1059         * tui/tui-data.h (struct tui_win_info)
1060         <do_make_visible_with_new_height, make_visible_with_new_height>:
1061         New methods.
1062         (struct tui_source_window_base, struct tui_data_window)
1063         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1064         methods.
1065
1066 2019-06-25  Tom Tromey  <tom@tromey.com>
1067
1068         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1069         method.
1070         (update_tab_width): Call update_tab_width method.
1071         * tui/tui-data.h (struct tui_win_info)
1072         (struct tui_source_window_base) <update_tab_width>: New methods.
1073
1074 2019-06-25  Tom Tromey  <tom@tromey.com>
1075
1076         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1077         parameter.
1078         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1079         parameter.
1080         (tui_gen_win_info::make_visible): Update.
1081         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1082         parameter.
1083         * tui/tui-data.h (enum tui_box): New enum.
1084         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1085
1086 2019-06-25  Tom Tromey  <tom@tromey.com>
1087
1088         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1089         init_and_make_win for EXEC_INFO_WIN.
1090         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1091         longer inline.
1092         (struct tui_win_info) <~tui_win_info>: Inline.
1093         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1094         Don't declare.
1095         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1096         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1097         Remove.
1098         (tui_initialize_static_data): Update.
1099         (~tui_gen_win_info): Handle more cleanup here.
1100         (~tui_source_window_base): Delete "execution_info".
1101         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1102
1103 2019-06-25  Tom Tromey  <tom@tromey.com>
1104
1105         * tui/tui-layout.c (make_command_window): Don't set
1106         can_highlight.
1107         (show_source_disasm_command): Call the reset method.
1108         (show_data): Don't set can_highlight.  Call the reset method.
1109         (tui_gen_win_info::reset): Rename from init_gen_win_info
1110         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1111         (show_source_or_disasm_and_command): Call the reset method.
1112         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1113         (struct tui_cmd_window): Set can_highlight.
1114
1115 2019-06-25  Tom Tromey  <tom@tromey.com>
1116
1117         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1118         from make_visible.
1119         (tui_make_visible, tui_make_invisible): Rewrite.
1120         (tui_win_info::make_visible): Remove.
1121         (tui_source_window_base::make_visible): Update.
1122         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1123         method.  Moved from...
1124         (struct tui_win_info) <make_visible>: ...here.
1125
1126 2019-06-25  Tom Tromey  <tom@tromey.com>
1127
1128         * tui/tui-winsource.c
1129         (tui_source_window_base::do_scroll_horizontal): Remove direction
1130         parameter.
1131         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1132         direction parameter.
1133         * tui/tui-win.c (tui_win_info::forward_scroll)
1134         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1135         (tui_win_info::right_scroll): Update.
1136         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1137         direction parameter.
1138         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1139         direction parameter.
1140         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1141         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1142         Remove direction parameter.
1143         (struct tui_source_window_base, struct tui_source_window)
1144         (struct tui_disasm_window, struct tui_data_window)
1145         (struct tui_cmd_window): Update.
1146
1147 2019-06-25  Tom Tromey  <tom@tromey.com>
1148
1149         * tui/tui-winsource.h (tui_set_exec_info_content)
1150         (tui_show_exec_info_content, tui_erase_exec_info_content)
1151         (tui_clear_exec_info_content, tui_update_exec_info): Change
1152         argument to tui_source_window_base.
1153         * tui/tui-winsource.c (tui_set_exec_info_content)
1154         (tui_show_exec_info_content, tui_erase_exec_info_content)
1155         (tui_clear_exec_info_content, tui_update_exec_info): Change
1156         argument to tui_source_window_base.
1157
1158 2019-06-25  Tom Tromey  <tom@tromey.com>
1159
1160         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1161         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1162
1163 2019-06-25  Tom Tromey  <tom@tromey.com>
1164
1165         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1166         check.
1167
1168 2019-06-25  Tom Tromey  <tom@tromey.com>
1169
1170         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1171         type to void.
1172         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1173         type to void.
1174         * tui/tui-source.c (tui_set_source_content): Update.
1175         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1176
1177 2019-06-25  Tom Tromey  <tom@tromey.com>
1178
1179         * tui/tui-win.c (window_name_completer, tui_set_focus)
1180         (tui_all_windows_info): Use name method.
1181         * tui/tui-data.h (struct tui_gen_win_info)
1182         (struct tui_source_window, struct tui_disasm_window)
1183         (struct tui_data_window, struct tui_cmd_window) <name>: New
1184         method.
1185         (tui_win_name): Don't declare.
1186         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1187         (tui_win_name): Remove.
1188
1189 2019-06-25  Tom Tromey  <tom@tromey.com>
1190
1191         * tui/tui-winsource.h (tui_update_source_window)
1192         (tui_update_source_window_as_is): Change parameter type.
1193         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1194         to be a tui_source_window_base.
1195         (tui_update_source_window_as_is): Likewise.
1196         * tui/tui-win.c (make_visible_with_new_height): Update.
1197
1198 2019-06-25  Tom Tromey  <tom@tromey.com>
1199
1200         * tui/tui-winsource.c (tui_erase_source_content)
1201         (tui_show_source_content, tui_show_exec_info_content)
1202         (tui_erase_exec_info_content): Use refresh_window method.
1203         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1204         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1205         from tui_refresh_win.
1206         (tui_data_window::refresh_window): New method.
1207         (tui_win_info::refresh, tui_source_window_base::refresh)
1208         (tui_refresh_all): Use refresh_window method.
1209         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1210         method.
1211         * tui/tui-regs.c (tui_display_register): Call refresh_window
1212         method.
1213         * tui/tui-layout.c (show_source_disasm_command)
1214         (show_source_or_disasm_and_command): Call refresh_window method.
1215         * tui/tui-data.h (struct tui_gen_win_info)
1216         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1217         New method.
1218
1219 2019-06-25  Tom Tromey  <tom@tromey.com>
1220
1221         * tui/tui.c (tui_rl_other_window, tui_enable)
1222         (tui_is_window_visible, tui_get_command_dimension): Update.
1223         * tui/tui-winsource.c (tui_update_source_window_as_is)
1224         (tui_clear_source_content, tui_erase_source_content)
1225         (tui_show_source_line, tui_source_window_base::refill)
1226         (tui_source_window_base::do_scroll_horizontal)
1227         (tui_source_window_base::set_is_exec_point_at)
1228         (tui_update_breakpoint_info, tui_set_exec_info_content)
1229         (tui_alloc_source_buffer, tui_line_is_displayed)
1230         (tui_addr_is_displayed): Update.
1231         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1232         (tui_check_and_display_highlight_if_needed)
1233         (tui_win_info::make_visible, tui_win_info::refresh)
1234         (tui_refresh_all): Update.
1235         * tui/tui-windata.c (tui_first_data_item_displayed)
1236         (tui_delete_data_content_windows, tui_erase_data_content)
1237         (tui_display_all_data, tui_data_window::refresh_all)
1238         (tui_check_data_values): Update.
1239         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1240         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1241         (tui_win_info::backward_scroll, tui_refresh_all_win)
1242         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1243         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1244         (tui_source_window_base::set_new_height)
1245         (tui_data_window::set_new_height)
1246         (make_invisible_and_set_new_height)
1247         (make_visible_with_new_height, new_height_ok)
1248         (parse_scrolling_args): Update.
1249         * tui/tui-stack.c (tui_show_frame_info): Update.
1250         * tui/tui-source.c (tui_set_source_content)
1251         (tui_set_source_content_nil, tui_source_is_displayed)
1252         (tui_source_window::do_scroll_vertical): Update.
1253         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1254         (tui_display_registers_from, tui_display_reg_element_at_line)
1255         (tui_check_register_values, tui_reg_command): Update.
1256         * tui/tui-layout.c (tui_default_win_height)
1257         (show_source_disasm_command, show_data, init_and_make_win)
1258         (show_source_or_disasm_and_command): Update.
1259         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1260         (tui_redisplay_readline, tui_mld_flush)
1261         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1262         (tui_getc): Update.
1263         * tui/tui-disasm.c (tui_set_disassem_content)
1264         (tui_disasm_window::do_scroll_vertical): Update.
1265         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1266         Now virtual.
1267         (struct tui_win_info): Derive from tui_gen_win_info.
1268         <~tui_win_info>: Mark as override.
1269         <generic>: Remove member.
1270         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1271         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1272         (~tui_data_window, ~tui_win_info)
1273         (tui_free_all_source_wins_content): Update.
1274         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1275
1276 2019-06-25  Tom Tromey  <tom@tromey.com>
1277
1278         * tui/tui-layout.c (init_and_make_win): Use new.
1279         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1280         destructor, initializers.
1281         (tui_alloc_generic_win_info): Don't declare.
1282         * tui/tui-data.c (_locator): Add argument to constructor.
1283         (source_win, disasm_win): New globals.
1284         (exec_info): Remove.
1285         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1286         Update.
1287         (tui_alloc_generic_win_info): Remove.
1288         (init_content_element): Use new.
1289         (tui_win_info::tui_win_info): Update.
1290         (free_content_elements) <case DATA_WIN>: Use delete.
1291
1292 2019-06-25  Tom Tromey  <tom@tromey.com>
1293
1294         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1295         * tui/tui-windata.c (tui_first_data_item_displayed)
1296         (tui_delete_data_content_windows): Update.
1297         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1298         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1299         (tui_display_registers_from, tui_check_register_values): Update.
1300         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1301         pointer.
1302         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1303         window.
1304         (tui_free_data_content): Update.
1305         (free_content_elements) <case DATA_WIN>: Free the window.
1306
1307 2019-06-25  Tom Tromey  <tom@tromey.com>
1308
1309         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1310         Update.
1311         * tui/tui-layout.c (make_command_window)
1312         (show_source_disasm_command, show_data, init_and_make_win)
1313         (show_source_or_disasm_and_command): Update.
1314         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1315         method.
1316         <can_highight, is_highlighted>: Now bool.
1317         (tui_set_win_highlight): Don't declare.
1318         * tui/tui-data.c (tui_set_win_highlight): Remove.
1319
1320 2019-06-25  Tom Tromey  <tom@tromey.com>
1321
1322         * tui/tui-wingeneral.c (make_visible): Remove check of window
1323         type.
1324
1325 2019-06-25  Tom Tromey  <tom@tromey.com>
1326
1327         * tui/tui-win.c (tui_win_info::max_height)
1328         (tui_cmd_window::max_height): New methods.
1329         (new_height_ok): Call max_height.
1330         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1331         <max_height>: New method.
1332
1333 2019-06-25  Tom Tromey  <tom@tromey.com>
1334
1335         * tui/tui-win.c (tui_source_window_base::set_new_height)
1336         (tui_data_window::set_new_height): New methods.
1337         (make_invisible_and_set_new_height): Call set_new_height method.
1338         * tui/tui-data.h (struct tui_win_info)
1339         (struct tui_source_window_base, struct tui_data_window)
1340         <set_new_height>: New method.
1341
1342 2019-06-25  Tom Tromey  <tom@tromey.com>
1343
1344         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1345         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1346         tui_refresh_data_win.
1347         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1348         method.
1349         (tui_refresh_all_win): Call the refresh_all method.
1350         (tui_set_focus): Likewise.
1351         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1352         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1353         Likewise.
1354
1355 2019-06-25  Tom Tromey  <tom@tromey.com>
1356
1357         * tui/tui-winsource.h (tui_refill_source_window)
1358         (tui_set_is_exec_point_at): Don't declare.
1359         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1360         (tui_source_window_base::refill): Rename from
1361         tui_refill_source_window.
1362         (tui_source_window_base::do_scroll_horizontal): Update.
1363         (tui_source_window_base::set_is_exec_point_at): Rename from
1364         tui_set_is_exec_point_at.
1365         (tui_update_all_breakpoint_info): Update.
1366         * tui/tui-stack.c (tui_show_frame_info): Update.
1367         * tui/tui-layout.c (show_data): Add cast.
1368         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1369         * tui/tui-data.h (struct tui_source_window_base) <refill,
1370         set_is_exec_point_at>: New methods.
1371         (tui_source_windows, tui_add_to_source_windows): Update types.
1372         (tui_add_to_source_windows): Remove redundant declaration.
1373         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1374         (tui_source_windows): Change return type.
1375         (tui_clear_source_windows_detail): Update.
1376         (tui_add_to_source_windows): Change type of parameter.
1377         (tui_free_all_source_wins_content): Update.
1378
1379 2019-06-25  Tom Tromey  <tom@tromey.com>
1380
1381         * tui/tui-wingeneral.c (tui_win_info::refresh)
1382         (tui_source_window_base::refresh): New methods.
1383         (tui_refresh_all): Call the refresh method.
1384         * tui/tui-data.h (struct tui_win_info)
1385         (struct tui_source_window_base) <refresh>: New method.
1386
1387 2019-06-25  Tom Tromey  <tom@tromey.com>
1388
1389         * tui/tui.h (tui_is_window_visible): Return bool.
1390         * tui/tui.c (tui_is_window_visible): Return bool.
1391         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1392         (tui_make_visible, tui_make_invisible)
1393         (tui_win_info::make_visible)
1394         (tui_source_window_base::make_visible, make_all_visible)
1395         (tui_make_all_visible, tui_make_all_invisible): Update.
1396         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1397         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1398         bool.
1399         (struct tui_win_info, struct tui_source_window_base)
1400         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1401         * tui/tui-data.c (tui_init_generic_part): Update.
1402
1403 2019-06-25  Tom Tromey  <tom@tromey.com>
1404
1405         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1406         (tui_source_window_base::make_visible): New methods.
1407         (make_all_visible): Make method call.
1408         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1409         (struct tui_source_window_base, struct tui_cmd_window): Override
1410         make_visible.
1411         (tui_win_is_source_type): Don't declare.
1412         * tui/tui-data.c (tui_win_is_source_type): Remove.
1413
1414 2019-06-25  Tom Tromey  <tom@tromey.com>
1415
1416         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1417         NULL check.
1418
1419 2019-06-25  Tom Tromey  <tom@tromey.com>
1420
1421         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1422         Inline constructor.  Add initializers for members.
1423         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1424         constructors; now inline in class.
1425
1426 2019-06-25  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-regs.c (tui_show_registers): Update.
1429         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1430         bool.
1431         * tui/tui-data.c (tui_data_window::clear_detail)
1432         (tui_data_window): Update.
1433
1434 2019-06-25  Tom Tromey  <tom@tromey.com>
1435
1436         * tui/tui-windata.c (tui_display_all_data)
1437         (tui_display_data_from_line, tui_display_data_from)
1438         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1439         Update.
1440         * tui/tui-regs.c (tui_last_regs_line_no)
1441         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1442         (tui_show_registers, tui_show_register_group)
1443         (tui_display_registers_from, tui_display_reg_element_at_line)
1444         (tui_display_registers_from_line, tui_check_register_values)
1445         (tui_reg_next, tui_reg_prev): Update.
1446         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1447         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1448         tui_data_window.
1449         (struct tui_win_info) <detail>: Remove.  Add new fields from
1450         tui_data_info.
1451         (TUI_DATA_WIN): Add cast.
1452         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1453         (~tui_data_window): Simplify.
1454
1455 2019-06-25  Tom Tromey  <tom@tromey.com>
1456
1457         * tui/tui-layout.c (show_source_disasm_command)
1458         (show_source_or_disasm_and_command): Update.
1459         * tui/tui-io.c (update_cmdwin_start_line)
1460         (tui_redisplay_readline): Update.
1461         * tui/tui-data.h (struct tui_command_info): Remove.
1462         (struct tui_win_info) <detail>: Remove command_info member.
1463         (struct tui_data_window) <start_line>: New member, from
1464         tui_command_info.
1465         (TUI_CMD_WIN): Add casts.
1466
1467 2019-06-25  Tom Tromey  <tom@tromey.com>
1468
1469         * tui/tui-winsource.c (tui_update_source_window)
1470         (tui_refill_source_window)
1471         (tui_source_window_base::do_scroll_horizontal)
1472         (tui_update_breakpoint_info, tui_set_exec_info_content)
1473         (tui_show_exec_info_content, tui_erase_exec_info_content)
1474         (tui_clear_exec_info_content): Update.
1475         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1476         Update.
1477         * tui/tui-win.c (make_invisible_and_set_new_height)
1478         (make_visible_with_new_height): Update.
1479         * tui/tui-source.c (tui_set_source_content)
1480         (tui_show_symtab_source): Update.
1481         * tui/tui-layout.c (extract_display_start_addr)
1482         (show_source_disasm_command, show_data)
1483         (make_source_or_disasm_window)
1484         (show_source_or_disasm_and_command): Update.
1485         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1486         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1487         "gdbarch".
1488         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1489         to tui_source_window_base.
1490         (struct tui_win_info) <detail>: Remove source_info member.
1491         (struct tui_source_window_base) <has_locator>: Inline.
1492         Move contents from tui_source_info; rename has_locator member to
1493         m_has_locator.
1494         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1495         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1496         header file.
1497         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1498         Simplify.
1499         (tui_free_all_source_wins_content): Cast to
1500         tui_source_window_base.
1501
1502 2019-06-25  Tom Tromey  <tom@tromey.com>
1503
1504         * tui/tui-win.c (make_invisible_and_set_new_height)
1505         (make_visible_with_new_height): Call has_locator method.
1506         * tui/tui-layout.c (show_source_disasm_command, show_data)
1507         (show_source_or_disasm_and_command): Update for bool change.
1508         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1509         (tui_win_info) <has_locator>: New method.
1510         (struct tui_source_window_base) <has_locator>: New method.
1511         (tui_win_has_locator): Don't declare.
1512         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1513         from tui_win_has_locator.
1514         (tui_source_window_base): Use false, not FALSE.
1515
1516 2019-06-25  Tom Tromey  <tom@tromey.com>
1517
1518         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1519         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1520         clear_detail method directly.
1521         (tui_clear_win_detail): Remove.
1522
1523 2019-06-25  Tom Tromey  <tom@tromey.com>
1524
1525         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1526         "this", not TUI_DISASM_WIN.
1527
1528 2019-06-25  Tom Tromey  <tom@tromey.com>
1529
1530         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1531         declare.
1532         * tui/tui-winsource.c
1533         (tui_source_window_base::do_scroll_horizontal): Rename from
1534         tui_horizontal_source_scroll.
1535         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1536         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1537         from tui_vertical_data_scroll.
1538         * tui/tui-win.h (tui_scroll): Don't declare.
1539         * tui/tui-win.c (tui_win_info::forward_scroll)
1540         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1541         (tui_win_info::right_scroll): Rename and update.
1542         (tui_scroll_forward_command, tui_scroll_backward_command)
1543         (tui_scroll_left_command, tui_scroll_right_command): Update.
1544         (tui_scroll): Remove.
1545         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1546         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1547         from tui_vertical_source_scroll.
1548         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1549         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1550         from tui_vertical_disassem_scroll.
1551         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1552         do_scroll_horizontal>: New methods.
1553         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1554         Likewise.
1555         (struct tui_source_window_base): Add do_scroll_horizontal.
1556         (struct tui_source_window, struct tui_disasm_window): Add
1557         do_scroll_vertical.
1558         (struct tui_data_window, struct tui_cmd_window): Add
1559         do_scroll_horizontal and do_scroll_vertical.
1560         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1561
1562 2019-06-25  Tom Tromey  <tom@tromey.com>
1563
1564         * tui/tui-data.h (struct tui_source_window_base): New struct.
1565         (struct tui_source_window): Derive from tui_source_window_base.
1566         (struct tui_disasm_window): New struct.
1567         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1568         from tui_source_window::clear_detail.
1569         (tui_source_window_base): Rename from tui_source_window.
1570         (~tui_source_window_base): Rename from ~tui_source_window.
1571         (tui_alloc_win_info): Create a tui_disasm_window.
1572
1573 2019-06-25  Tom Tromey  <tom@tromey.com>
1574
1575         * tui/tui-data.h (struct tui_source_window)
1576         (struct tui_data_window): Declare destructors.
1577         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1578         destructors.
1579         (tui_win_info): Simplify.
1580
1581 2019-06-25  Tom Tromey  <tom@tromey.com>
1582
1583         * tui/tui-winsource.c (tui_display_main)
1584         (tui_update_source_windows_with_addr)
1585         (tui_update_all_breakpoint_info): Update.
1586         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1587         (new_height_ok, parse_scrolling_args): Update.
1588         * tui/tui-stack.c (tui_show_frame_info): Update.
1589         * tui/tui-data.h (struct tui_list): Remove.
1590         (tui_source_windows): Return a reference to a std::vector.
1591         * tui/tui-data.c (source_windows): Now a std::vector.
1592         (tui_source_windows): Change return type.
1593         (tui_clear_source_windows): Rewrite.
1594         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1595         (tui_free_all_source_wins_content): Rewrite.
1596
1597 2019-06-25  Tom Tromey  <tom@tromey.com>
1598
1599         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1600         (struct tui_data_window, struct tui_cmd_window): Declare
1601         clear_detail method.
1602         * tui/tui-data.c (tui_source_window::clear_detail)
1603         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1604         methods.
1605         (tui_clear_win_detail): Simplify.
1606
1607 2019-06-25  Tom Tromey  <tom@tromey.com>
1608
1609         * tui/tui-layout.c (make_source_window, make_disasm_window)
1610         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1611         Return the new window.
1612         (show_source_disasm_command, show_data)
1613         (show_source_or_disasm_and_command): Update.
1614
1615 2019-06-25  Tom Tromey  <tom@tromey.com>
1616
1617         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1618         parameter.  Return the new window.
1619         (show_source_disasm_command): Update and remove NULL check.
1620         (show_source_or_disasm_and_command): Update.
1621
1622 2019-06-25  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1625
1626 2019-06-25  Tom Tromey  <tom@tromey.com>
1627
1628         * tui/tui-data.h (struct tui_win_info): Make constructor
1629         protected.  Make destructor virtual.  Add initializers.
1630         (tui_source_window, tui_data_window, tui_cmd_window): New
1631         classes.
1632         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1633         constructor.  Add "type" parameter.
1634         (tui_source_window, tui_data_window, tui_cmd_window): New
1635         constructors.
1636         (tui_alloc_win_info): Instantiate the appropriate subclass.
1637
1638 2019-06-25  Tom Tromey  <tom@tromey.com>
1639
1640         * tui/tui-win.c (tui_resize_all): Use delete.
1641         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1642         destructor.
1643         (tui_free_window): Don't declare.
1644         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1645         Update.
1646
1647 2019-06-25  Tom Tromey  <tom@tromey.com>
1648
1649         * tui/tui-data.h (struct tui_win_info): Add constructor.
1650         * tui/tui-data.c (tui_alloc_win_info): Use new.
1651         (tui_free_window): Use delete.
1652
1653 2019-06-22  Tom Tromey  <tom@tromey.com>
1654
1655         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1656         declare.
1657         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1658
1659 2019-06-22  Tom Tromey  <tom@tromey.com>
1660
1661         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1662         declare.
1663         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1664
1665 2019-06-22  Tom de Vries  <tdevries@suse.de>
1666
1667         * dwarf2read.c (create_addrmap_from_aranges)
1668         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1669         instead of '%zu'.
1670
1671 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1672
1673         * dwarf2read.h (dwarf2_section_info_def): Remove.
1674         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1675         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1676         std::vector<dwarf2_section_info>.
1677         (struct dwo_file) <~dwo_file>: Remove.
1678         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1679         types field.
1680         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1681         (dwarf2_read_debug_names): Likewise.
1682         (create_debug_types_hash_table): Change parameter type to
1683         array_view, adjust code accordingly.
1684         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1685         (partial_die_info::fixup): Likewise.
1686         (determine_prefix): Likewise.
1687         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1688
1689 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1690
1691         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1692         gdb_bfd_ref_ptr.
1693         <~dwo_file>: Remove call to gdb_bfd_unref.
1694         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1695         gdb_bfd_ref_ptr::get.
1696
1697 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1698
1699         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1700         type to htab_up.
1701         * dwarf2read.c (struct dwo_file): Initialize fields.
1702         <~dwo_file>: New.
1703         (free_dwo_file): Remove, move content to ~dwo_file.
1704         (struct dwo_file_deleter): Remove.
1705         (dwo_file_up>: Remove custom deleter.
1706         (free_dwo_files): Remove.
1707         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1708         dwo_files.
1709         (process_skeletonless_type_units): Call unique_ptr::get.
1710         (allocate_dwo_file_hash_table): Add deleter to created hash
1711         table.  Change return type to htab_up.
1712         (lookup_dwo_file_slot): Don't memset dwo_file, call
1713         unique_ptr::get.
1714         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1715         (create_dwo_unit_in_dwp_v2): Likewise.
1716         (open_and_init_dwo_file): Likewise.
1717         (free_dwo_file_from_slot): Remove.
1718
1719 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1720
1721         * dwarf2read.h (struct dwarf2_section_info) <readin,
1722         is_virtual>: Change type to bool.
1723         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1724         true instead of 1.
1725
1726 2019-06-19  Tom Tromey  <tom@tromey.com>
1727
1728         * tui/tui-data.h (tui_init_content_element): Don't declare.
1729
1730 2019-06-19  Tom Tromey  <tom@tromey.com>
1731
1732         * tui/tui-data.h (tui_init_win_info): Don't declare.
1733
1734 2019-06-19  Tom de Vries  <tdevries@suse.de>
1735
1736         * dwarf2read.h (abstract_to_concrete): Change type to
1737         std::unordered_map<sect_offset, std::vector<sect_offset>,
1738         gdb::hash_enum<sect_offset>>.
1739
1740 2019-06-19  Tom Tromey  <tromey@adacore.com>
1741
1742         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1743         EVAL_AVOID_SIDE_EFFECTS specially.
1744
1745 2019-06-19  Tom Tromey  <tromey@adacore.com>
1746
1747         * source-cache.c (highlighter): New global.
1748         (source_cache::get_source_lines): Create a highlighter on demand.
1749
1750 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1751
1752         * defs.h (deprecated_interactive_hook): Delete declaration.
1753         * interps.c (clear_interpreter_hooks): Remove use of
1754         deprecated_interactive_hook.
1755         * top.c (deprecated_interactive_hook): Delete definition.
1756         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1757
1758 2019-06-18  Tom de Vries  <tdevries@suse.de>
1759
1760         PR gdb/24515
1761         * dwarf2read.h (abstract_to_concrete): Change type from
1762         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1763         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1764         * dwarf2read.c (read_variable): Update.
1765         (dwarf2_fetch_die_loc_sect_off): Update.
1766
1767 2019-06-17  Tom de Vries  <tdevries@suse.de>
1768
1769         PR gdb/24617
1770         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1771         accessing parent[parent_len - 1].
1772
1773 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1774
1775         PR gdb/24364
1776         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1777         call dtrace_process_dof with NULL dof.
1778
1779 2019-06-16  Tom de Vries  <tdevries@suse.de>
1780
1781         PR gdb/24445
1782         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1783
1784 2019-06-16  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1787         (make_all_visible): Use address of member.
1788
1789 2019-06-16  Tom Tromey  <tom@tromey.com>
1790
1791         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1792         (tui_free_window, free_content, free_content_elements): Remove
1793         unnecessary cast.
1794         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1795         cast.
1796         * tui/tui-regs.c (tui_show_register_group)
1797         (tui_display_registers_from, tui_display_reg_element_at_line):
1798         Remove unnecessary cast.
1799
1800 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1801
1802         * linux-nat.c (normal_mask): Delete.
1803         (_initialize_linux_nat): Don't initialise normal_mask.
1804
1805 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1806
1807         PR gdb/24445
1808         * dwarf-index-write.h (write_psymtabs_to_index): Add
1809         dwz_basename parameter.
1810         * dwarf-index-write.c (write_gdbindex): Move file writing to
1811         write_gdbindex_1.  Change return type void.
1812         (assert_file_size): Move up, remove filename parameter.
1813         (write_gdbindex_1): New function.
1814         (write_debug_names): Change return type to void, call
1815         assert_file_size.
1816         (struct index_wip_file): New struct.
1817         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1818         file logic to index_wip_file.  Write index for dwz file if
1819         needed.
1820         (save_gdb_index_command): Pass basename of dwz file, if present.
1821         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1822         build-id of dwz file, if present.
1823         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1824         (dwarf2_get_dwz_file): Likewise.
1825         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1826         (dwarf2_get_dwz_file): Likewise.
1827
1828 2019-06-16  Tom Tromey  <tom@tromey.com>
1829
1830         * coffread.c (process_coff_symbol): Use xstrdup.
1831         * value.c (create_internalvar): Use xstrdup.
1832
1833 2019-06-16  Tom Tromey  <tom@tromey.com>
1834
1835         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1836         * breakpoint.c (stopin_command, stopat_command)
1837         (until_break_command, decode_location_default): Remove unnecessary
1838         cast.
1839         * utils.c (subset_compare): Remove unnecessary cast.
1840         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1841         cast.
1842         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1843         cast.
1844         * infcmd.c (path_command): Remove unnecessary cast.
1845         * coffread.c (decode_type): Remove unnecessary cast.
1846         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1847         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1848         * tui/tui-stack.c (tui_show_locator_content)
1849         (tui_show_frame_info): Remove unnecessary cast.
1850         * tui/tui-win.c (tui_scroll_forward_command)
1851         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1852         (parse_scrolling_args): Remove unnecessary cast.
1853         * tui/tui-data.c (init_win_info, tui_del_window)
1854         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1855         (free_content_elements): Remove unnecessary cast.
1856         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1857         unnecessary cast.
1858         * tui/tui-source.c (tui_set_source_content)
1859         (tui_vertical_source_scroll): Remove unnecessary cast.
1860         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1861         cast.
1862         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1863         * tui/tui-regs.c (tui_display_registers_from)
1864         (tui_display_register): Remove unnecessary cast.
1865         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1866         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1867         (make_visible): Remove unnecessary cast.
1868         * tui/tui-winsource.c (tui_erase_source_content)
1869         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1870         unnecessary cast.
1871         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1872         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1873         * stabsread.c (read_type, read_array_type, read_range_type):
1874         Remove unnecessary cast.
1875         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1876         (parse_symbol, parse_type, upgrade_type, parse_external)
1877         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1878         unnecessary cast.
1879         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1880
1881 2019-06-16  Tom Tromey  <tom@tromey.com>
1882
1883         * tui/tui-data.c (tui_alloc_generic_win_info)
1884         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1885         checks.
1886
1887 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1888             Andrew Burgess  <andrew.burgess@embecosm.com>
1889
1890         * f-typeprint.c (f_print_type): Don't return early for not
1891         associated or not allocated types.
1892         (f_type_print_varspec_suffix): Add print_rank parameter and print
1893         ranks of array types in case they dangling.
1894         (f_type_print_base): Add print_rank parameter.
1895
1896 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1897
1898         * NEWS: Mention new MI commands.
1899         * break-catch-throw.c (enum exception_event_kind): Move to
1900         breakpoint.h.
1901         (print_mention_exception_catchpoint): Output text as a single
1902         message.
1903         (catch_exception_command_1): Rename to...
1904         (catch_exception_event): ...this, make non-static, update header
1905         command, and change some parameter types.
1906         (catch_catch_command): Update for changes to
1907         catch_exception_command_1.
1908         (catch_throw_command): Likewise.
1909         (catch_rethrow_command): Likewise.
1910         * breakpoint.c (enum exception_event_kind): Delete.
1911         * breakpoint.h (enum exception_event_kind): Moved here from
1912         break-catch-throw.c.
1913         (catch_exception_event): Declare.
1914         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1915         (mi_cmd_catch_throw): New function.
1916         (mi_cmd_catch_rethrow): New function.
1917         (mi_cmd_catch_catch): New function.
1918         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1919         'catch-catch' entries.
1920         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1921         (mi_cmd_catch_rethrow): Declare.
1922         (mi_cmd_catch_catch): Declare.
1923
1924 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1925
1926         * annotate.c (annotate_source_line): Change return type to void,
1927         update implementation to match.
1928         * annotate.h (annotate_source_line): Change return type to void,
1929         update header comment.
1930         * stack.c (print_frame_info): Don't change what frame information
1931         is printed based on whether annotations are on or not.
1932
1933 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1934
1935         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1936         (annotate_source): Make static.
1937         (annotate_source_line): Moved from source.c and renamed from
1938         identify_source_line.  Update the return type.
1939         * annotate.h (annotate_source): Delete declaration.
1940         (annotate_source_line): Declaration moved from source.h, and
1941         renamed from identify_source_line.  Return type updated.
1942         * source.c (identify_source_line): Moved to annotate.c and renamed
1943         to annotate_source_line.
1944         (info_line_command): Remove check of annotation_level.
1945         * source.h (identify_source_line): Move declaration to annotate.h
1946         and rename to annotate_source_line.
1947         * stack.c: Add 'annotate.h' include.
1948         (print_frame_info): Remove check of annotation_level before
1949         calling annotate_source_line.
1950
1951 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1952
1953         * source-cache.c (source_cache::get_plain_source_lines): Use
1954         open_source_file_with_line_charpos instead of just
1955         open_source_file, remove call to find_source_lines.
1956         (source_cache::get_source_lines): Likewise.
1957         * source.c (find_source_lines): Make static.
1958         (get_filename_and_charpos): Renamed into...
1959         (open_source_file_with_line_charpos): ..this along with changes to
1960         return a scoped_fd, and some other minor clean ups.
1961         (identify_source_line): Use open_source_file_with_line_charpos.
1962         (search_command_helper): Use open_source_file_with_line_charpos
1963         instead of just open_source_file, remove call to
1964         find_source_lines.
1965         * source.h (open_source_file_with_line_charpos): Declare new
1966         function.
1967         (find_source_lines): Delete declaration.
1968
1969 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1970
1971         * source.c (get_filename_and_charpos): Remove fullname
1972         parameter.
1973         (identify_source_line): Update call to get_filename_and_charpos.
1974
1975 2019-06-14  Tom Tromey  <tromey@adacore.com>
1976
1977         PR gdb/24502:
1978         * ui-style.h (skip_ansi_escape): Update comment.
1979         * ui-file.h (class no_terminal_escape_file): New class.
1980         * ui-file.c (no_terminal_escape_file::write)
1981         (no_terminal_escape_file::puts): New methods.
1982         * cli/cli-logging.c (handle_redirections): Use
1983         no_terminal_escape_file.
1984
1985 2019-06-14  Tom Tromey  <tromey@adacore.com>
1986
1987         * NEWS: Move convenience variable news above Python news.
1988
1989 2019-06-14  Tom Tromey  <tom@tromey.com>
1990
1991         * gnulib: Move directory to top-level.
1992         * configure.ac: Don't configure gnulib.
1993         * configure: Rebuild.
1994         * common/common-defs.h: Use new path to gnulib.
1995         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1996         (GNULIB_H): Remove.
1997         (INCGNU): Look in new gnulib location.
1998         (HFILES_NO_SRCDIR): Remove gnulib files.
1999         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2000         (generated_files): Remove GNULIB_H.
2001         ($(LIBGNU), all-lib): Remove targets.
2002         (distclean): Don't mention GNULIB_BUILDDIR.
2003         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2004
2005 2019-06-14  Tom Tromey  <tromey@adacore.com>
2006
2007         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2008         Warn if symbol file does not provide any symbols.
2009
2010 2019-06-14  Tom Tromey  <tromey@adacore.com>
2011
2012         * source.c (find_and_open_source): Respect basenames_may_differ.
2013
2014 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2015
2016         * annotate.c (annotate_breakpoints_invalid): Make use of
2017         scoped_restore_terminal_state.
2018         (annotate_frames_invalid): Likewise.
2019
2020 2019-06-14  Tom Tromey  <tromey@adacore.com>
2021
2022         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2023         allow assignment to an internalvar.
2024
2025 2019-06-14  Tom Tromey  <tromey@adacore.com>
2026
2027         * ada-lex.l: Allow "_" in attribute names.
2028
2029 2019-06-14  Tom Tromey  <tromey@adacore.com>
2030
2031         PR gdb/24653:
2032         * regcache.c (registers_changed): Don't call alloca.
2033         * top.c (execute_command): Don't call alloca.
2034
2035 2019-06-13  Pedro Alves  <palves@redhat.com>
2036
2037         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2038         'expression'.  When parsing an expression, error out if there's
2039         junk after "unlimited".
2040         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2041         (do_set_command): Adjust calls to is_unlimited_literal.
2042
2043 2019-06-13  Pedro Alves  <palves@redhat.com>
2044
2045         * compile/compile.c (make_compile_options_def_group): Add braces
2046         around array_view initializer.
2047         * thread.c (make_thread_apply_all_options_def_group)
2048         (make_thread_apply_all_options_def_group): Likewise.
2049
2050 2019-06-13  Pedro Alves  <palves@redhat.com>
2051
2052         * NEWS (New commands): Mention "maint test-options
2053         require-delimiter", "maint test-options unknown-is-error", "maint
2054         test-options unknown-is-operand" and "maint show
2055         test-options-completion-result".
2056         (New command options, command completion): New section.
2057         (Completion improvements): New section.
2058         Mention that you can abbreviate "unlimited".
2059
2060 2019-06-13  Pedro Alves  <palves@redhat.com>
2061
2062         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2063         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2064         * unittests/cli-utils-selftests.c (test_parse_flags)
2065         (test_parse_flags_qcs): Delete.
2066         (test_cli_utils): Don't call deleted functions.
2067
2068 2019-06-13  Pedro Alves  <palves@redhat.com>
2069
2070         * thread.c: Include "cli/cli-option.h".
2071         (tp_array_compar_ascending): Global.
2072         (tp_array_compar): Delete function.
2073         (tp_array_compar_ascending, tp_array_compar_descending): New
2074         functions.
2075         (ascending_option_def, qcs_flag_option_def)
2076         (thr_qcs_flags_option_defs)
2077         (make_thread_apply_all_options_def_group)
2078         (make_thread_apply_options_def_group): New.
2079         (thread_apply_all_command): Use gdb::option::process_options.
2080         (thread_apply_command_completer)
2081         (thread_apply_all_command_completer): New.
2082         (thread_apply_command): Use gdb::option::process_options.
2083         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2084         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2085         to generate help text of "thread apply".  Adjust "taas"'s help.
2086         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2087         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2088
2089 2019-06-13  Pedro Alves  <palves@redhat.com>
2090
2091         * thread.c (thread_apply_command): Check for invalid TID with
2092         isdigit instead of !isalpha.
2093
2094 2019-06-13  Pedro Alves  <palves@redhat.com>
2095
2096         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2097         (validate_flags_qcs): New.
2098         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2099         (validate_flags_qcs): Declare.
2100         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2101         (make_frame_apply_options_def_group): New.
2102         (frame_apply_command_count): Process options with
2103         gdb::option::process_options.
2104         (frame_apply_completer): New.
2105         (frame_apply_level_completer, frame_apply_all_completer)
2106         (frame_apply_completer): New.
2107         (_initialize_stack): Update help of "frame apply", "frame apply
2108         level", "frame apply all" and "faas" to mention supported options
2109         and install command completers.
2110         * stack.h (frame_apply_all_completer): Declare.
2111         * thread.c: Include "stack.h".
2112         (tfaas_command): Add "--".
2113         (_initialize_thread): Update help "tfaas" to mention supported
2114         options and install command completer.
2115
2116 2019-06-13  Pedro Alves  <palves@redhat.com>
2117
2118         * completer.c (complete_nested_command_line): New.
2119         (gdb_completion_word_break_characters_throw): Add assertion.
2120         * completer.h (complete_nested_command_line): Declare.
2121
2122 2019-06-13  Pedro Alves  <palves@redhat.com>
2123
2124         * stack.c (parse_backtrace_qualifiers): New.
2125         (backtrace_command): Use it.
2126         (backtrace_command_completer): Complete on qualifiers.
2127
2128 2019-06-13  Pedro Alves  <palves@redhat.com>
2129
2130         * frame.c: Include "cli/cli-option.h.
2131         (user_set_backtrace_options): New.
2132         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2133         Delete.
2134         (get_prev_frame): Adjust.
2135         (boolean_option_def, uinteger_option_def)
2136         (set_backtrace_option_defs): New.
2137         (_initialize_frame): Adjust and use
2138         gdb::option::add_setshow_cmds_for_options to install "set
2139         backtrace past-main" and "set backtrace past-entry".
2140         * frame.h: Include "cli/cli-option.h".
2141         (struct frame_print_options): Forward declare.
2142         (print_frame_arguments_all, print_frame_arguments_scalars)
2143         (print_frame_arguments_none): Declare.
2144         (print_entry_values): Delete declaration.
2145         (struct frame_print_options, user_frame_print_options): New.
2146         (struct set_backtrace_options): New.
2147         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2148         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2149         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2150         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2151         (list_args_or_locals): Add frame_print_options parameter.
2152         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2153         * python/py-framefilter.c (enumerate_args): Pass down
2154         USER_FRAME_PRINT_OPTIONS.
2155         * stack.c: Include "cli/cli-option.h".
2156         (print_frame_arguments_all, print_frame_arguments_scalars)
2157         (print_frame_arguments_none): Declare.
2158         (print_raw_frame_arguments, print_entry_values): Delete.
2159         (user_frame_print_options): New.
2160         (boolean_option_def, enum_option_def, frame_print_option_defs):
2161         New.
2162         (struct backtrace_cmd_options): New.
2163         (bt_flag_option_def): New.
2164         (backtrace_command_option_defs): New.
2165         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2166         (print_frame_arg, read_frame_arg, print_frame_args)
2167         (print_frame_info, print_frame): Add frame_print_options parameter
2168         and use it.
2169         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2170         (backtrace_command_1): Add frame_print_options and
2171         backtrace_cmd_options parameters and use them.
2172         (make_backtrace_options_def_group): New.
2173         (backtrace_command): Process command options with
2174         gdb::option::process_options.
2175         (backtrace_command_completer): New.
2176         (_initialize_stack): Extend "backtrace"'s help to mention
2177         supported options.  Install completer for "backtrace".
2178         Install some settings commands with add_setshow_cmds_for_options.
2179
2180 2019-06-13  Pedro Alves  <palves@redhat.com>
2181
2182         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2183         and that "set/show print raw frame-arguments" are now deprecated.
2184
2185         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2186         command.
2187         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2188         * stack.c (_initialize_stack): Install "set/show print
2189         raw-frame-arguments", and deprecate "set/show print raw
2190         frame-arguments".
2191         * valprint.c (_initialize_valprint): Deprecate "set/show print
2192         raw".
2193
2194 2019-06-13  Pedro Alves  <palves@redhat.com>
2195
2196         * compile/compile.c (struct compile_options): New.
2197         (compile_flag_option_def, compile_command_option_defs)
2198         (make_compile_options_def_group): New.
2199         (compile_file_command): Handle options with
2200         gdb::option::process_options.
2201         (compile_file_command_completer): New function.
2202         (compile_code_command): Handle options with
2203         gdb::option::process_options.
2204         (compile_code_command_completer): New function.
2205         (_initialize_compiler): Install completers for "compile code" and
2206         "compile file".  Mention available options in "compile code" and
2207         "compile code"'s help.
2208         * completer.c (advance_to_completion_word): New, factored out from
2209         ...
2210         (advance_to_expression_complete_word_point): ... this.
2211         (advance_to_filename_complete_word_point): New.
2212         * completer.h (advance_to_filename_complete_word_point): New
2213         declaration.
2214
2215 2019-06-13  Pedro Alves  <palves@redhat.com>
2216
2217         * compile/compile.c: Include "cli/cli-option.h".
2218         (compile_print_value): Scope data pointer is now a
2219         value_print_options pointer; adjust.
2220         (compile_print_command): Process options.  Scope data pointer is
2221         now a value_print_options pointer; adjust.
2222         (_initialize_compile): Update "compile print"'s help to include
2223         supported options.  Install a completer for "compile print".
2224         * cp-valprint.c (show_vtblprint, show_objectprint)
2225         (show_static_field_print): Delete.
2226         (_initialize_cp_valprint): Don't install "set print
2227         static-members", "set print vtbl", "set print object" here.
2228         * printcmd.c: Include "cli/cli-option.h" and
2229         "common/gdb_optional.h".
2230         (print_command_parse_format): Rework to fill in a
2231         value_print_options instead of a format_data.
2232         (print_value): Change parameter type from format_data pointer to
2233         value_print_options reference.  Adjust.
2234         (print_command_1): Process options.  Adjust to pass down a
2235         value_print_options.
2236         (print_command_completer): New.
2237         (_initialize_printcmd): Install print_command_completer as
2238         handle_brkchars completer for the "print" command.  Update
2239         "print"'s help to include supported options.
2240         * valprint.c: Include "cli/cli-option.h".
2241         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2242         here from cp-valprint.c.
2243         (boolean_option_def, uinteger_option_def)
2244         (value_print_option_defs, make_value_print_options_def_group):
2245         New.  Use gdb::option::add_setshow_cmds_for_options to install
2246         "set print elements", "set print null-stop", "set print repeats",
2247         "set print pretty", "set print union", "set print array", "set
2248         print address", "set print symbol", "set print array-indexes".
2249         * valprint.h: Include <string> and "cli/cli-option.h".
2250         (make_value_print_options_def_group): Declare.
2251         (print_value): Change parameter type from format_data pointer to
2252         value_print_options reference.
2253         (print_command_completer): Declare.
2254
2255 2019-06-13  Pedro Alves  <palves@redhat.com>
2256
2257         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2258         (COMMON_SFILES): Add maint-test-settings.c.
2259         * cli/cli-decode.c (boolean_enums): New global, factored out from
2260         ...
2261         (add_setshow_boolean_cmd): ... here.
2262         * cli/cli-decode.h (boolean_enums): Declare.
2263         * cli/cli-option.c: New file.
2264         * cli/cli-option.h: New file.
2265         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2266         factored out from ...
2267         (parse_cli_boolean_value(const char *)): ... this.
2268         (is_unlimited_literal): Change parameter type to pointer to
2269         pointer.  Adjust and advance ARG pointer.
2270         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2271         (parse_cli_var_enum): New, factored out from ...
2272         (do_set_command): ... this.  Adjust.
2273         * cli/cli-setshow.h (parse_cli_boolean_value)
2274         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2275         (parse_cli_var_enum): Declare.
2276         * cli/cli-utils.c: Include "cli/cli-option.h".
2277         (get_ulongest): New.
2278         * cli/cli-utils.h (get_ulongest): Declare.
2279         (check_for_argument): New overloads.
2280         * maint-test-options.c: New file.
2281
2282 2019-06-13  Pedro Alves  <palves@redhat.com>
2283
2284         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2285         parse a range if "-" is at the end of the string.
2286
2287 2019-06-13  Pedro Alves  <palves@redhat.com>
2288
2289         * cli/cli-setshow.c (parse_auto_binary_operation)
2290         (parse_cli_boolean_value): Don't allow "o".
2291
2292 2019-06-13  Pedro Alves  <palves@redhat.com>
2293
2294         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2295         * NEWS: Mention maint test-settings KIND.
2296         * maint-test-settings.c: New file.
2297
2298 2019-06-13  Pedro Alves  <palves@redhat.com>
2299
2300         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2301         completer.
2302         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2303         "set" completers.
2304
2305 2019-06-13  Pedro Alves  <palves@redhat.com>
2306
2307         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2308         after item.
2309
2310 2019-06-13  Pedro Alves  <palves@redhat.com>
2311
2312         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2313
2314 2019-06-13  Pedro Alves <palves@redhat.com>
2315
2316         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2317         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2318         call.
2319         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2320         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2321         calls.
2322         (check_for_argument): Skip spaces after argument.
2323
2324 2019-06-13  Pedro Alves  <palves@redhat.com>
2325
2326         * thread.c (thread_apply_command): Adjust TID parsing.
2327         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2328         detected before end of string.
2329         (tid_is_in_list): Error out if LIST is invalid.
2330
2331 2019-06-13  Pedro Alves  <palves@redhat.com>
2332
2333         * completer.c (complete_line_internal_1): Rewind completion word
2334         point.
2335         (completion_tracker::advance_custom_word_point_by): Change
2336         parameter type to int.
2337         * completer.h (completion_tracker::advance_custom_word_point_by):
2338         Likewise.
2339
2340 2019-06-13  Pedro Alves  <palves@redhat.com>
2341
2342         * completer.c (advance_to_completion_word): Handle delimiters.
2343
2344 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2345
2346         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2347
2348 2019-06-11  Tom Tromey  <tom@tromey.com>
2349
2350         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2351         (xmalloc_failed): Move to alloc.c.
2352         * alloc.c: New file.
2353         * Makefile.in (COMMON_SFILES): Add alloc.c.
2354
2355 2019-06-11  Tom Tromey  <tom@tromey.com>
2356
2357         * nat/linux-waitpid.c: Don't include server.h.
2358         (linux_debug): Remove.
2359         (my_waitpid): Update.
2360
2361 2019-06-11  Tom Tromey  <tromey@adacore.com>
2362
2363         * infcall.c (_initialize_infcall): Remove trailing newline from
2364         help.
2365         * user-regs.c (_initialize_user_regs): Remove trailing newline
2366         from help.
2367         * typeprint.c (_initialize_typeprint): Remove trailing newline
2368         from help.
2369         * reverse.c (_initialize_reverse): Remove trailing newlines from
2370         help.
2371         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2372         from help.
2373         * language.c (add_set_language_command): Remove trailing newline
2374         from help.
2375         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2376         help.
2377         * disasm.c (_initialize_disasm): Remove trailing newline from
2378         help.
2379         * top.c (init_main): Remove trailing newline from help.
2380         * interps.c (_initialize_interpreter): Remove trailing newline
2381         from help.
2382         * btrace.c (_initialize_btrace): Remove trailing newlines from
2383         help.
2384         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2385         from help.
2386         * python/python.c (_initialize_python): Remove trailing newline
2387         from help.
2388         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2389         help.
2390         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2391         from help.  Reformat some text.
2392         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2393         from help.
2394         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2395         newline from help.
2396
2397 2019-06-11  Tom Tromey  <tromey@adacore.com>
2398
2399         * darwin-nat.c (darwin_decode_exception_message)
2400         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2401
2402 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2403
2404         * valops.c (value_slice): Check for not allocated or not
2405         associated values.
2406
2407 2019-06-10  Tom de Vries  <tdevries@suse.de>
2408
2409         PR gdb/24618
2410         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2411         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2412         invalid.
2413
2414 2019-06-10  Tom de Vries  <tdevries@suse.de>
2415
2416         PR gdb/24611
2417         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2418         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2419
2420 2019-06-10  Tom de Vries  <tdevries@suse.de>
2421
2422         PR symtab/24545
2423         * symtab.c (struct demangled_name_entry): Add language field.
2424         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2425         static minimal symbol".  Set and use language field.
2426
2427 2019-06-10  Tom Tromey  <tromey@adacore.com>
2428
2429         * ada-lang.c (_initialize_ada_language): Update help text.
2430
2431 2019-06-10  Tom Tromey  <tromey@adacore.com>
2432
2433         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2434         with a newline.
2435         * guile/guile.c (handle_boot_error): Don't end warning with a
2436         newline.
2437         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2438         warning with a newline.
2439         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2440         newline.
2441         (s12z_frame_cache): Likewise.
2442         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2443         a newline.
2444         * solib-svr4.c (disable_probes_interface): Don't end warning with
2445         a newline.
2446         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2447         newline.
2448         * python/python.c (do_finish_initialization): Don't end warning
2449         with a newline.
2450
2451 2019-06-10  Tom Tromey  <tom@tromey.com>
2452
2453         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2454         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2455         gdbpy_enter.
2456
2457 2019-06-10  Tom Tromey  <tromey@adacore.com>
2458
2459         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2460         data.
2461         (elf_new_init): Don't call stabsread_new_init.
2462         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2463         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2464         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2465
2466 2019-06-10  Tom de Vries  <tdevries@suse.de>
2467
2468         PR symtab/16264
2469         PR symtab/24517
2470         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2471
2472 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2473
2474         * source.c (find_and_open_source): Also rewrite relative file
2475         names.
2476
2477 2019-04-26  Amos Bird  <amosbird@gmail.com>
2478
2479         * annotate.c (annotate_thread_exited): Add "thread-exited"
2480         annotation.
2481
2482 2019-06-06  Tom Tromey  <tromey@adacore.com>
2483
2484         * maint.h (class scoped_command_stats): Use
2485         DISABLE_COPY_AND_ASSIGN.
2486         <print_time>: New method.
2487         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2488         print_time.
2489         (scoped_command_stats::print_time): New method.
2490
2491 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2492
2493         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2494         instructions of lengths 6 or 8 bytes.
2495
2496 2019-06-04  Pedro Alves  <palves@redhat.com>
2497
2498         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2499
2500         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2501         * breakpoint.c (condition_completer): Likewise.
2502         * cli/cli-dump.c (scan_expression): Likewise.
2503         * common/filestuff.c (mkdir_recursive): Likewise.
2504         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2505         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2506         (gdb_abspath): Likewise.
2507         * compile/compile-cplus-types.c
2508         (compile_cplus_instance::decl_name): Likewise.
2509         * completer.c (complete_explicit_location):
2510         (signal_completer, reg_or_group_completer_1): Likewise.
2511         * cp-support.c (cp_remove_params_if_any): Likewise.
2512         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2513         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2514         * infcmd.c (strip_bg_char): Likewise.
2515         * linespec.c (copy_token_string): Likewise.
2516         * mi/mi-main.c (output_cores): Likewise.
2517         * psymtab.c (psymtab_search_name):
2518         * symfile.c (test_set_ext_lang_command): Likewise.
2519         * target.c (target_fileio_read_stralloc): Likewise.
2520         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2521         * value.c (complete_internalvar): Likewise.
2522
2523 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2524
2525         Add objfile property to gdb.Type.
2526         * NEWS: Mention Python API addition.
2527         * python/py-type.c (typy_get_objfile): New method.
2528
2529 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2530
2531         * NEWS: Mention the new set|show style [title|highlight].
2532         Mention changes to "show style", "help" and "apropos".
2533
2534 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2535
2536         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2537         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2538         instead of print_help_for_command.
2539         (print_doc_of_command): New function.
2540         (help_list): Add 'apropos -v word' suggestion.
2541         (print_help_for_command): Style the command name using title style.
2542         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2543         (_initialize_cli_cmds): Describe -v in apropos_command help.
2544
2545 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2546
2547         * cli/cli-style.h (cli_style_option): Add name in constructor,
2548         add m_name class member, add constructor with intensity,
2549         add name class function.
2550         (cli_style_option::add_setshow_commands): Remove name argument.
2551         (highlight_style, title_style): New styles.
2552         * cli/cli-style.c (do_show): New function that shows a style
2553         characteristic styling the style name with itself.
2554         (set_style_name): New function.
2555         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2556         Update all callers according to the changes in cli/cli-style.h.
2557         * utils.h (fputs_highlighted): New function.
2558         * utils.c (fputs_highlighted): Likewise.
2559
2560 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2561
2562         * NEWS: Mention new pipe command and new convenience variables.
2563
2564 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2565
2566         * cli/cli-cmds.c (pipe_command): New function.
2567         (_initialize_cli_cmds): Call add_com for pipe_command.
2568         Define | as an alias for pipe.
2569         (exit_status_set_internal_vars): New function.
2570         (shell_escape): Call exit_status_set_internal_vars.
2571         cli/cli-decode.c (find_command_name_length): Recognize | as
2572         a single character command.
2573
2574 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2575
2576         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2577         top.c (execute_command_to_ui_file): New function, mostly a copy
2578         of execute_command_to_string.
2579         (execute_command_to_string): Implement by calling
2580         execute_command_to_ui_file.
2581
2582 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2583
2584         * top.h (saved_command_line): Remove declaration.
2585         * top.c (previous_saved_command_line, previous_repeat_arguments):
2586         New variables.
2587         (saved_command_line): Make static, define together with other
2588         'repeat variables'.
2589         (dont_repeat): Clear repeat_arguments.
2590         (repeat_previous, get_saved_command_line, save_command_line):
2591         New functions.
2592         (gdb_init): Initialize saved_command_line
2593         and previous_saved_command_line.
2594         * main.c (captured_main_1): Remove saved_command_line initialization.
2595         * event-top.c (handle_line_of_input): Update to use
2596         the new 'repeat' related functions instead of direct access to
2597         saved_command_line.
2598         * command.h (repeat_previous, get_saved_command_line,
2599         save_command_line): New declarations.
2600         (dont_repeat): Add comment.
2601
2602 2019-05-30  Tom Tromey  <tromey@adacore.com>
2603
2604         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2605         Fix comment.
2606         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2607
2608 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2609
2610         PR cli/24587
2611         * completer.c (complete): Initialize variable word.
2612
2613 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2614
2615         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2616         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2617         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2618         'body' is NULL to the outter 'if', protecting the '!is_define'
2619         situation as well.
2620
2621 2019-05-29  Tom Tromey  <tromey@adacore.com>
2622
2623         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2624         (dwarf_unknown): New function.
2625         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2626         (dwarf_type_encoding_name): Use dwarf_unknown.
2627
2628 2019-05-29  Tom Tromey  <tromey@adacore.com>
2629
2630         PR c++/20020:
2631         * cp-valprint.c (cp_print_value_fields): Call
2632         cp_print_static_field inside "try".
2633
2634 2019-05-29  Tom Tromey  <tromey@adacore.com>
2635
2636         * inflow.c (struct terminal_info): Add default operator=.
2637         * configure: Rebuild.
2638         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2639         -Wdeprecated-copy-dtor, -Wredundant-move.
2640
2641 2019-05-29  Tom Tromey  <tromey@adacore.com>
2642
2643         * NEWS: Add entry.
2644         * infcmd.c (print_return_value_1): Handle finish_print
2645         option.
2646         (show_print_finish): New function.
2647         (_initialize_infcmd): Add "set/show print finish" commands.
2648         * valprint.c (user_print_options): Initialize new member.
2649         * valprint.h (struct value_print_options) <finish_print>: New
2650         member.
2651
2652 2019-05-28  Tom Tromey  <tromey@adacore.com>
2653
2654         * ada-lang.c (ada_remove_Xbn_suffix)
2655         (find_old_style_renaming_symbol)
2656         (parse_old_style_renaming): Remove.
2657         (ada_find_renaming_symbol): Don't call
2658         find_old_style_renaming_symbol.
2659         (ada_is_renaming_symbol): Rename from
2660         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2661         bool.  Now static.
2662         (ada_read_var_value): Update and simplify.
2663         * ada-exp.y (write_var_or_type): Remove old code.
2664
2665 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2666
2667         * event-top.c: Remove include comment.
2668         * inflow.c (class scoped_ignore_sigttou): Move from here...
2669         * inflow.h (class scoped_ignore_sigttou): ...to here.
2670         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2671         * top.c:  Remove include comment.
2672
2673 2019-05-27  Tom Tromey  <tom@tromey.com>
2674
2675         * NEWS: Fix typo.
2676
2677 2019-05-22  Tom Tromey  <tromey@adacore.com>
2678
2679         * target.c (target_follow_exec): Constify parameter.
2680         * target-delegates.c: Rebuild.
2681         * remote.c (remote_target::follow_exec): Constify parameter.
2682         * infrun.c (follow_exec): Constify parameter.
2683         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2684         (target_follow_exec): Likewise.
2685
2686 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2687
2688         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2689         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2690
2691 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2692
2693         * NEWS: Add debugredirect and testsuite sections.
2694
2695 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2696
2697         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2698         target descriptions using exclusively floating point register name
2699         aliases.
2700
2701 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2702
2703         PR gdb/18644:
2704         * f-lang.c (build_fortran_types): Handle the case where
2705         gdbarch_floatformat_for_type returns a nullptr.
2706
2707 2019-05-21  Tom de Vries  <tdevries@suse.de>
2708
2709         PR cli/24587
2710         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2711
2712 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2713
2714         PR gdb/18644:
2715         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2716         16-byte floats.
2717         * i386-tdep.c (i386_floatformat_for_type): Use
2718         floatformats_ia64_quad for the 16-byte floating point component
2719         within a fortran 32-byte complex number.
2720
2721 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2722
2723         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2724         delete default constructor.
2725         (find_partial_die): Update to return const struct.
2726         (partial_die_parent_scope): Move variable declaration into scope
2727         of its use and change its type to auto.
2728         (guess_partial_die_structure_name): Likewise.
2729         (partial_die_info::fixup): Likewise.
2730
2731 2019-05-17  Tom Tromey  <tromey@adacore.com>
2732
2733         * source.c (find_and_open_source): Remove cast.
2734
2735 2019-05-17  Tom Tromey  <tromey@adacore.com>
2736
2737         * annotate.c (annotate_source): Make "filename" const.
2738         * annotate.h (annotate_source): Use const.
2739
2740 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2741
2742         * disasm.c (set_disassembler_options): Send errors to stderr.
2743
2744 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2745
2746         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2747         (cli_interp_base::set_logging): Check debug_redirect.
2748         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2749         * cli/cli-logging.c (debug_redirect): Add static variable.
2750         (pop_output_files): Add default param.
2751         (handle_redirections): Print debug setting.
2752         (show_logging_command): Likewise.
2753         (_initialize_cli_logging): Add debugredirect command.
2754         * interps.c (current_interp_set_logging): Add debug_redirect
2755         parameter.
2756         * interps.h (set_logging): Add debug_redirect parameter.
2757         (current_interp_set_logging): Likewise.
2758         * mi/mi-common.h: Likewise.
2759         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2760
2761 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2762             Tom Tromey  <tromey@adacore.com>
2763
2764         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2765         directly.
2766         * cli/cli-interp.h (make_logging_output): Remove declaration.
2767         * cli/cli-logging.c (make_logging_output): Remove function.
2768         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2769         directly.
2770         * ui-file.c (tee_file::tee_file): Remove bools.
2771         (tee_file::~tee_file): Remove deletes.
2772         * ui-file.h (tee_file): Remove bools.
2773
2774 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2775
2776         * mi/mi-cmds.h (mi_cmd_complete): New function.
2777         * mi/mi-main.c (mi_cmd_complete): Likewise.
2778         * mi/mi-cmds.c: Define new MI command -complete.
2779         * NEWS: Mention new -complete command.
2780
2781 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2782
2783         * completer.h (complete): New function.
2784         * completer.c (complete): Likewise.
2785         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2786         function defined in completer.h.
2787
2788 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2789
2790         * MAINTAINERS (Write After Approval): Add myself.
2791
2792 2019-05-17  Tom de Vries  <tdevries@suse.de>
2793
2794         PR gdb/24094
2795         * dwarf2read.c (struct cu_partial_die_info): New struct.
2796         (find_partial_die): Return cu_partial_die_info.
2797         (partial_die_parent_scope, guess_partial_die_structure_name)
2798         (partial_die_info::fixup): Handle new return type of find_partial_die.
2799
2800 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2801
2802         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2803         "std::string", simplifying the algorithm.
2804
2805 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2806
2807         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2808         (stap_static_probe_ops::get_probes): Likewise.
2809
2810 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2811
2812         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2813         '-')" and "else if".
2814         (stap_parse_single_operand): Join checks for
2815         "gdbarch_stap_parse_special_token_p" and
2816         "gdbarch_stap_parse_special_token" in the same "if" statement.
2817         Invert check when verifying for operation on register
2818         displacement.
2819
2820 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2821
2822         * stap-probe.c (stap_get_opcode): Update comment.
2823         (stap_get_expected_argument_type): Likewise.
2824         (handle_stap_probe): Likewise.
2825
2826 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2827
2828         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2829         return type to 'bool'.  Adjust comment.  Use 'bool' when
2830         appropriate.
2831         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2832         * stap-probe.c (stap_parse_argument_1): Likewise.
2833         (stap_is_operator): Likewise.
2834         (stap_is_generic_prefix): Likewise.
2835         (stap_is_register_prefix): Likewise.
2836         (stap_is_register_indirection_prefix): Likewise.
2837         (stap_is_integer_prefix): Likewise.
2838         (stap_generic_check_suffix): Likewise.
2839         (stap_check_integer_suffix): Likewise.
2840         (stap_check_register_suffix): Likewise.
2841         (stap_check_register_indirection_suffix): Likewise.
2842         (stap_parse_register_operand): Likewise.
2843         (stap_parse_single_operand): Likewise.
2844         (stap_parse_argument_1): Likewise.
2845         (stap_probe::get_argument_count): Likewise.
2846         (stap_is_operator): Likewise.
2847
2848 2019-05-16  Tom Tromey  <tromey@adacore.com>
2849
2850         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2851         keyword to foreach.
2852
2853 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2854
2855         * linux-thread-db.c (try_thread_db_load_1): Change return type
2856         to bool.
2857         (try_thread_db_load): Likewise.
2858         (try_thread_db_load_from_pdir_1): Likewise.
2859         (try_thread_db_load_from_pdir): Likewise.
2860         (try_thread_db_load_from_sdir): Likewise.
2861         (try_thread_db_load_from_dir): Likewise.
2862         (thread_db_load_search): Likewise.
2863         (has_libpthread): Likewise.
2864         (thread_db_load): Likewise.
2865
2866 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2867
2868         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2869         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2870         NULL, and complain/return if that's the case.
2871
2872 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2873
2874         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2875         (advance, posn, abstract_read_memory): New functions.
2876         [struct mem_read_abstraction]: New struct.
2877         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2878
2879 2019-05-14  Tom Tromey  <tromey@adacore.com>
2880
2881         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2882         value is not lval_memory.
2883
2884 2019-05-14  Tom Tromey  <tromey@adacore.com>
2885
2886         * solib.c (info_sharedlibrary_command): Style the file name.
2887
2888 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2889
2890         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2891         (aarch64_vnv_type): Likewise.
2892         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2893         * common/tdesc.c: Likewise.
2894         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2895         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2896         * features/aarch64-fpu.xml: Add ieee half view.
2897         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2898         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2899         * gdbtypes.h (struct builtin_type): Likewise.
2900         (struct objfile_type): Likewise.
2901
2902 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2903
2904         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2905         typo.
2906         * location.h (string_to_event_location): Likewise.
2907
2908 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2909
2910         GDB 8.3 released.
2911
2912 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2913
2914         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2915         New variable declaration.
2916         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2917         New variable.
2918         (print_one_breakpoint): Use ui_out::test_flags and new global
2919         variable to compute use_fixed_output.
2920         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2921         Remove.
2922         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2923         (mi_multi_location_breakpoint_output_fixed): Remove.
2924         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2925         new variable.
2926         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2927         fix_multi_location_breakpoint_output flag if version >= 3.
2928         * ui-out.h (enum ui_out_flag)
2929         <fix_multi_location_breakpoint_output>: New enumerator.
2930
2931 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2932
2933         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2934
2935 2019-05-10  Tom Tromey  <tromey@adacore.com>
2936
2937         * ada-lang.c (catch_ada_completer): New function.
2938         (_initialize_ada_language): Use it.
2939
2940 2019-05-10  Tom Tromey  <tromey@adacore.com>
2941
2942         * thread.c (print_thread_info): Make "requested_threads" const.
2943         * gdbthread.h (print_thread_info): Make "requested_threads"
2944         const.
2945         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2946         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2947
2948 2019-05-08  Tom Tromey  <tom@tromey.com>
2949
2950         * gdbtypes.c (objfile_type_data): Change type.
2951         (objfile_type, _initialize_gdbtypes): Update.
2952
2953 2019-05-08  Tom Tromey  <tom@tromey.com>
2954
2955         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2956         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2957         (_initialize_dwarf2_frame): Update.
2958
2959 2019-05-08  Tom Tromey  <tom@tromey.com>
2960
2961         * objc-lang.c (objc_objfile_data): Change type.
2962         (find_methods): Update.
2963         (_initialize_objc_lang): Remove.
2964
2965 2019-05-08  Tom Tromey  <tom@tromey.com>
2966
2967         * stabsread.c (rs6000_builtin_type_data): Change type.
2968         (rs6000_builtin_type, _initialize_stabsread): Update.
2969
2970 2019-05-08  Tom Tromey  <tom@tromey.com>
2971
2972         * mips-tdep.c (mips_pdr_data): Remove.
2973         (_initialize_mips_tdep): Update.
2974
2975 2019-05-08  Tom Tromey  <tom@tromey.com>
2976
2977         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2978         (hppa_init_objfile_priv_data, read_unwind_info)
2979         (find_unwind_entry, _initialize_hppa_tdep): Update.
2980
2981 2019-05-08  Tom Tromey  <tom@tromey.com>
2982
2983         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2984         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2985         on obstack.
2986         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2987
2988 2019-05-08  Tom Tromey  <tom@tromey.com>
2989
2990         * mdebugread.c (basic_type_data): Change type.
2991         (basic_type, _initialize_mdebugread): Update.
2992
2993 2019-05-08  Tom Tromey  <tom@tromey.com>
2994
2995         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2996
2997 2019-05-08  Tom Tromey  <tom@tromey.com>
2998
2999         * nto-tdep.c (nto_inferior_data_reg): Change type.
3000         (nto_inferior_data): Update.
3001         (nto_inferior_data_cleanup, nto_new_inferior_data)
3002         (_initialize_nto_tdep): Remove.
3003         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3004
3005 2019-05-08  Tom Tromey  <tom@tromey.com>
3006
3007         * ada-lang.c (struct ada_inferior_data): Add initializers.
3008         (ada_inferior_data): Change type.
3009         (ada_inferior_data_cleanup): Remove.
3010         (get_ada_inferior_data, ada_inferior_exit)
3011         (struct ada_pspace_data): Add initializers, destructor.
3012         (ada_pspace_data_handle): Change type.
3013         (get_ada_pspace_data): Update.
3014         (ada_pspace_data_cleanup): Remove.
3015
3016 2019-05-08  Tom Tromey  <tom@tromey.com>
3017
3018         * coffread.c (struct coff_symfile_info): Add initializers.
3019         (coff_objfile_data_key): Move lower.  Change type.
3020         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3021         Update.
3022         (coff_free_info): Remove.
3023
3024 2019-05-08  Tom Tromey  <tom@tromey.com>
3025
3026         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3027         (fbsd_pspace_data_handle): Move lower.  Change type.
3028         (get_fbsd_pspace_data): Update.
3029         (fbsd_pspace_data_cleanup): Remove.
3030         (_initialize_fbsd_tdep): Update.
3031
3032 2019-05-08  Tom Tromey  <tom@tromey.com>
3033
3034         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3035         (get_ada_tasks_pspace_data): Update.
3036         (ada_tasks_pspace_data_cleanup): Remove.
3037         (_initialize_tasks): Update.
3038         (ada_tasks_inferior_data_handle): Change type.
3039         (get_ada_tasks_inferior_data): Update.
3040         (ada_tasks_inferior_data_cleanup): Remove.
3041         (struct ada_tasks_pspace_data): Add initializers.
3042
3043 2019-05-08  Tom Tromey  <tom@tromey.com>
3044
3045         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3046         * symfile-debug.c (debug_sym_get_probes): Change type.
3047         * stap-probe.c (handle_stap_probe):
3048         (stap_static_probe_ops::get_probes): Change type.
3049         * probe.h (class static_probe_ops) <get_probes>: Change type.
3050         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3051         (parse_probes_in_pspace): Update.
3052         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3053         Update.
3054         (any_static_probe_ops::get_probes): Change type.
3055         * elfread.c (elfread_data): New typedef.
3056         (probe_key): Change type.
3057         (elf_get_probes): Likewise.  Update.
3058         (probe_key_free): Remove.
3059         (_initialize_elfread): Update.
3060         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3061         Change type.
3062         (dtrace_process_dof_probe, dtrace_process_dof)
3063         (dtrace_static_probe_ops::get_probe): Change type.
3064
3065 2019-05-08  Tom Tromey  <tom@tromey.com>
3066
3067         * xcoffread.c (struct xcoff_symfile_info): Rename from
3068         coff_symfile_info.  Add initializers.
3069         (xcoff_objfile_data_key): Move lower.  Change type.
3070         (XCOFF_DATA): Rewrite.
3071         (xcoff_free_info): Remove.
3072         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3073         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3074         (xcoff_initial_scan): Update.
3075
3076 2019-05-08  Tom Tromey  <tom@tromey.com>
3077
3078         * solib-svr4.c (struct svr4_info): Add initializers and
3079         destructor.
3080         <probes_table>: Now an htab_up.
3081         (solib_svr4_pspace_data): Change type.
3082         (free_probes_table): Simplify.
3083         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3084         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3085         (probes_table_remove_objfile_probes, register_solib_event_probe)
3086         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3087         (_initialize_svr4_solib): Update.
3088
3089 2019-05-08  Tom Tromey  <tom@tromey.com>
3090
3091         * remote.c (remote_pspace_data): Change type.
3092         (remote_pspace_data_cleanup): Remove.
3093         (get_remote_exec_file, set_pspace_remote_exec_file)
3094         (_initialize_remote): Update.
3095
3096 2019-05-08  Tom Tromey  <tom@tromey.com>
3097
3098         * breakpoint.c (breakpoint_objfile_key): Change type.
3099         (get_breakpoint_objfile_data): Update.
3100         (free_breakpoint_objfile_data): Remove.
3101         (_initialize_breakpoint): Update.
3102
3103 2019-05-08  Tom Tromey  <tom@tromey.com>
3104
3105         * linux-tdep.c (struct linux_info): Add initializers.
3106         (linux_inferior_data): Move.  Change type.
3107         (invalidate_linux_cache_inf): Update.
3108         (linux_inferior_data_cleanup): Remove.
3109         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3110
3111 2019-05-08  Tom Tromey  <tom@tromey.com>
3112
3113         * auxv.c (auxv_inferior_data): Move.  Change type.
3114         (auxv_inferior_data_cleanup): Remove.
3115         (invalidate_auxv_cache_inf): Rewrite.
3116         (get_auxv_inferior_data, _initialize_auxv): Update.
3117
3118 2019-05-08  Tom Tromey  <tom@tromey.com>
3119
3120         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3121         (symfile_debug_objfile_data_key): Change type.
3122         (symfile_debug_installed, debug_qf_has_symbols)
3123         (debug_qf_find_last_source_symtab)
3124         (debug_qf_forget_cached_source_info)
3125         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3126         (debug_qf_print_stats, debug_qf_dump)
3127         (debug_qf_expand_symtabs_for_function)
3128         (debug_qf_expand_all_symtabs)
3129         (debug_qf_expand_symtabs_with_fullname)
3130         (debug_qf_map_matching_symbols)
3131         (debug_qf_expand_symtabs_matching)
3132         (debug_qf_find_pc_sect_compunit_symtab)
3133         (debug_qf_map_symbol_filenames)
3134         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3135         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3136         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3137         (debug_sym_read_linetable, debug_sym_relocate): Update.
3138         (symfile_debug_free_objfile): Remove.
3139         (install_symfile_debug_logging, _initialize_symfile_debug):
3140         Update.
3141
3142 2019-05-08  Tom Tromey  <tom@tromey.com>
3143
3144         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3145         allocate_on_obstack.
3146         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3147         (get_dwarf2_per_objfile): Update.
3148         (set_dwarf2_per_objfile): Remove.
3149         (dwarf2_has_info, dwarf2_get_section_info): Update.
3150         (dwarf2_free_objfile): Remove.
3151         (_initialize_dwarf2_read): Update.
3152
3153 2019-05-08  Tom Tromey  <tom@tromey.com>
3154
3155         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3156         initializers.
3157         <unsupported_script_warning_printed,
3158         script_not_found_warning_printed>: Now bool.
3159         (auto_load_pspace_data): Change type.
3160         (~auto_load_pspace_info): Rename from
3161         auto_load_pspace_data_cleanup.
3162         (get_auto_load_pspace_data, init_loaded_scripts_info)
3163         (clear_section_scripts, maybe_print_unsupported_script_warning)
3164         (maybe_print_script_not_found_warning, _initialize_auto_load):
3165         Update.
3166
3167 2019-05-08  Tom Tromey  <tom@tromey.com>
3168
3169         * objfiles.c (objfile_pspace_info): Add destructor and
3170         initializers.
3171         (objfiles_pspace_data): Change type.
3172         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3173         (get_objfile_pspace_data): Update.
3174         (objfiles_bfd_data): Change type.
3175         (get_objfile_bfd_data): Update.
3176         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3177
3178 2019-05-08  Tom Tromey  <tom@tromey.com>
3179
3180         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3181         Change type.
3182         (get_catch_syscall_inferior_data): Update.
3183         (catch_syscall_inferior_data_cleanup): Remove.
3184         (_initialize_break_catch_syscall): Update.
3185
3186 2019-05-08  Tom Tromey  <tom@tromey.com>
3187
3188         * inflow.c (struct terminal_info): Add destructor and
3189         initializers.
3190         (inflow_inferior_data): Change type.
3191         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3192         (get_inflow_inferior_data, inflow_inferior_exit)
3193         (swap_terminal_info, _initialize_inflow): Update.
3194
3195 2019-05-08  Tom Tromey  <tom@tromey.com>
3196
3197         * target-dcache.c (target_dcache_cleanup): Remove.
3198         (target_dcache_aspace_key): Change type.
3199         (target_dcache_init_p, target_dcache_invalidate)
3200         (target_dcache_get, target_dcache_get_or_init)
3201         (_initialize_target_dcache): Update.
3202         * dcache.h (struct dcache_deleter): New.
3203
3204 2019-05-08  Tom Tromey  <tom@tromey.com>
3205
3206         * symtab.c (struct symbol_cache): Add destructor and
3207         initializers.
3208         (symbol_cache_key): Move.  Change type.
3209         (make_symbol_cache, free_symbol_cache): Remove.
3210         (get_symbol_cache): Update.
3211         (symbol_cache_cleanup): Remove.
3212         (ALL_PSPACES, symbol_cache_flush)
3213         (maintenance_print_symbol_cache)
3214         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3215         Update.
3216
3217 2019-05-08  Tom Tromey  <tom@tromey.com>
3218
3219         * symtab.c (struct main_info): Add destructor and initializers.
3220         (main_progspace_key): Move.  Change type.
3221         (get_main_info): Update.
3222         (main_info_cleanup): Remove.
3223         (_initialize_symtab): Update.
3224
3225 2019-05-08  Tom Tromey  <tom@tromey.com>
3226
3227         * registry.h (DECLARE_REGISTRY): Define the _key class.
3228
3229 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3230
3231         * NEWS: Merge two 'New commands' sections.
3232
3233 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3234
3235         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3236         parameter and use Ada language definition instead.
3237         (ada_val_print_ptr): Remove unused language parameter.
3238         (ada_val_print_num): Remove language parameter and use Ada language
3239         definition instead.
3240         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3241         parameter.
3242         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3243         parameter and use Ada language definition instead.
3244         (ada_val_print_1): Update all ada_val_print_xxx calls.
3245         Remove language parameter.
3246         (ada_val_print): Update ada_val_print_1 call.
3247
3248 2019-05-08  Tom Tromey  <tromey@adacore.com>
3249
3250         * remote.c (remote_hw_watchpoint_limit)
3251         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3252         Now static.
3253
3254 2019-05-08  Tom Tromey  <tromey@adacore.com>
3255
3256         * maint.c (_initialize_maint_cmds): Move initialization code to
3257         remote.c.
3258         (watchdog, show_watchdog): Move to remote.c.
3259         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3260         "watchdog" static.
3261         (_initialize_remote): Move initialization code from maint.c.
3262         * defs.h (watchdog): Don't declare.
3263
3264 2019-05-08  Tom Tromey  <tromey@adacore.com>
3265
3266         * tui/tui-interp.c: Include main.h.
3267         * interps.c: Include main.h.
3268         * main.h (interpreter_p): Declare.
3269         * defs.h (interpreter_p): Don't declare.
3270
3271 2019-05-08  Tom Tromey  <tromey@adacore.com>
3272
3273         * dwarf2loc.c: Include dwarf2read.h.
3274         * defs.h (read_unsigned_leb128): Don't declare.
3275         * dwarf2read.h (read_unsigned_leb128): Declare.
3276
3277 2019-05-08  Tom Tromey  <tromey@adacore.com>
3278
3279         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3280         method.
3281
3282 2019-05-08  Tom Tromey  <tromey@adacore.com>
3283
3284         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3285         when no wrap column is set.
3286
3287 2019-05-08  Tom Tromey  <tromey@adacore.com>
3288
3289         * c-lang.c (c_get_string): Handle non-C-style arrays.
3290
3291 2019-05-08  Tom Tromey  <tromey@adacore.com>
3292
3293         * typeprint.c (print_offset_data::update): Print the bit offset,
3294         not the number of bits remaining.
3295
3296 2019-05-08  Tom Tromey  <tromey@adacore.com>
3297
3298         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3299         padding at end of comment.
3300
3301 2019-05-08  Tom Tromey  <tromey@adacore.com>
3302
3303         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3304         Compare main types.
3305
3306 2019-05-06  Tom Tromey  <tom@tromey.com>
3307
3308         * common/scoped_mmap.c: Include common-defs.h.
3309         * common/scoped_mmap.h: Don't include config.h.
3310
3311 2019-05-04  Tom Tromey  <tom@tromey.com>
3312
3313         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3314         (struct aarch64_call_info): Add initializers.
3315         <si>: Now a std::vector.
3316         (pass_on_stack, aarch64_push_dummy_call): Update.
3317
3318 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3319             Tom Tromey  <tom@tromey.com>
3320
3321         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3322         (ppc_threads): Now a std::vector.  Now static.
3323         (hwdebug_find_thread_points_by_tid)
3324         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3325         Update.
3326
3327 2019-05-04  Tom Tromey  <tom@tromey.com>
3328
3329         * arc-tdep.c (arc_tdesc_init): Return bool.
3330
3331 2019-05-04  Tom Tromey  <tom@tromey.com>
3332
3333         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3334         Use gdb_assert_not_reached.
3335
3336 2019-05-04  Tom Tromey  <tom@tromey.com>
3337
3338         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3339         "false".
3340
3341 2019-05-04  Tom Tromey  <tom@tromey.com>
3342
3343         * arc-tdep.c (arc_tdesc_init): Use bool.
3344
3345 2019-05-04  Tom Tromey  <tom@tromey.com>
3346
3347         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3348
3349 2019-05-04  Tom Tromey  <tom@tromey.com>
3350
3351         * cli/cli-cmds.c (valid_command_p): Return bool.
3352
3353 2019-05-04  Tom Tromey  <tom@tromey.com>
3354
3355         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3356         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3357
3358 2019-05-04  Raul Tambre  <raul@tambre.ee>
3359
3360         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3361         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3362         operator for comparison.
3363
3364 2019-05-04  Tom Tromey  <tom@tromey.com>
3365
3366         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3367         (lookup_partial_symbol, print_partial_symbols)
3368         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3369         (psymbol_compare): Update.
3370         (add_psymbol_to_bcache): Clear the entire psymbol.
3371         (maintenance_check_psymtabs): Update.
3372         * psympriv.h (struct partial_symbol): Don't derive from
3373         general_symbol_info.
3374         <obj_section, unrelocated_address, address,
3375         set_unrelocated_address>: Update.
3376         <ginfo>: New member.
3377         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3378         (debug_names::write_psymbols): Update.
3379
3380 2019-05-04  Tom de Vries  <tdevries@suse.de>
3381
3382         * contrib/cc-with-tweaks.sh: Support -n arg.
3383
3384 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3385
3386         * corelow.c (core_target::detach): Ensure frame cache and
3387         register caches are cleared.
3388         inferior.c (exit_inferior_1): Likewise.
3389
3390 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3391             Tom Tromey  <tom@tromey.com>
3392
3393         * dictionary.c (collate_pending_symbols_by_language): Remove
3394         "struct" from foreach.
3395         * symtab.c (lookup_global_symbol_from_objfile)
3396         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3397         foreach.
3398         * ser-tcp.c (net_open): Remove "struct" from foreach.
3399         * objfiles.c (objfile_relocate, objfile_rebase)
3400         (objfile_has_symbols): Remove "struct" from foreach.
3401         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3402         from foreach.
3403         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3404         foreach.
3405         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3406         "struct" from foreach.
3407         * ada-lang.c (create_excep_cond_exprs)
3408         (ada_exception_catchpoint_cond_string): Remove "struct" from
3409         foreach.
3410
3411 2019-05-03  Tom Tromey  <tromey@adacore.com>
3412
3413         * ada-exp.y (convert_char_literal): Check suffix of each
3414         enumerator.
3415
3416 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3417
3418         PR ada/21406:
3419         * ada-exp.y (yywrap): Don't define.
3420         * ada-lex.l (%option): Add noyywrap
3421         (yywrap): Remove.
3422
3423 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3424
3425         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3426         _WIN32_WINNT to the XP level, unless already defined to a higher
3427         level.
3428
3429         * unittests/parse-connection-spec-selftests.c:
3430         * ser-tcp.c:
3431         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3432         override.
3433
3434         * symfile.c (find_separate_debug_file): Remove colon from the
3435         drive spec of DOS/Windows file names of the target, so that the
3436         file name produced from DEBUGDIR and the target's directory will
3437         be valid on DOS/Windows systems.
3438
3439 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3440
3441         * rust-lang.c (val_print_struct): Handle printing structures
3442         containing strings.
3443
3444 2019-05-02  Tom Tromey  <tromey@adacore.com>
3445
3446         * valarith.c (_initialize_valarith): Remove.
3447
3448 2019-05-01  Tom Tromey  <tromey@adacore.com>
3449
3450         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3451         bitfields.
3452
3453 2019-05-01  Tom Tromey  <tromey@adacore.com>
3454
3455         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3456         for big-endian copies.
3457
3458 2019-04-30  Ali Tamur  <tamur@google.com>
3459         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3460         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3461         (read_3_bytes): New function.
3462
3463 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3464
3465         * windows-nat.c (main_thread_id): Delete.
3466         (handle_output_debug_string): Replace main_thread_id by
3467         current_event.dwThreadId.
3468         (fake_create_process): Likewise.
3469         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3470         Do not set main_thread_id.
3471         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3472         current_event.dwThreadId.
3473         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3474
3475 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3476
3477         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3478         Use current_event.dwThreadId instead of main_thread_id.
3479
3480 2019-04-30  Tom Tromey  <tromey@adacore.com>
3481
3482         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3483         (create_excep_cond_exprs): Iterate over program spaces.
3484         (ada_exception_catchpoint_cond_string): Examine all minimal
3485         symbols for exception types.
3486
3487 2019-04-30  Tom Tromey  <tromey@adacore.com>
3488
3489         PR c++/24470:
3490         * dwarf2read.c (process_structure_scope): Handle case where type
3491         has template parameters but no symbol was created.
3492
3493 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3494             Chris January  <chris.january@arm.com>
3495
3496         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3497         qualifier.
3498         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3499
3500 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3501
3502         * f-typeprint.c (f_print_type): Update rules for printing
3503         whitespace.
3504         (f_type_print_varspec_suffix): Likewise.
3505
3506 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3507             Chris January  <chris.january@arm.com>
3508
3509         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3510         function arguments.
3511
3512 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3513
3514         * f-lang.c (build_fortran_types): Change name of void type to
3515         lower case.
3516         * f-typeprint.c (f_type_print_base): Print the name of the void
3517         type, rather than a fixed string.
3518         * f-valprint.c (f_decorations): Use lower case void string.
3519
3520 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3521             Chris January  <chris.january@arm.com>
3522
3523         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3524         types for Fortran.
3525
3526 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3527             Chris January  <chris.january@arm.com>
3528             David Lecomber  <david.lecomber@arm.com>
3529
3530         * f-exp.y (BINOP_INTRINSIC): New token.
3531         (exp): New parser rule handling BINOP_INTRINSIC.
3532         (f77_keywords): Add new builtin procedures.
3533         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3534         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3535         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3536         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3537         (print_unop_subexp_f): New function.
3538         (print_binop_subexp_f): New function.
3539         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3540         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3541         (dump_subexp_body_f): Likewise.
3542         (operator_check_f): Likewise.
3543         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3544         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3545
3546 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3547
3548         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3549         UNOP_KIND.
3550         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3551         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3552         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3553         (operator_length_f): New fuction.
3554         (print_subexp_f): New function.
3555         (op_name_f): New function.
3556         (dump_subexp_body_f): New function.
3557         (operator_check_f): New function.
3558         (exp_descriptor_f): Replace standard expression handling functions
3559         with new functions.
3560         * gdb/fortran-operator.def: New file.
3561         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3562         * gdb/std-operator.def: Remove UNOP_KIND.
3563
3564 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3565
3566         * std-operator.def: Remove unbalanced, stray double quote
3567         character.
3568
3569 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3570             Chris January  <chris.january@arm.com>
3571             Daniel Everett  <daniel.everett@arm.com>
3572             Nick Forrington  <nick.forrington@arm.com>
3573             Richard Bunt  <richard.bunt@arm.com>
3574
3575         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3576         of depth when printing anonymous structs or unions.
3577         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3578         Don't print either the top-level value, or the children if the
3579         max-depth is exceeded.
3580         (ppscm_print_children): When printing the key of a map, allow one
3581         extra level of depth.
3582         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3583         print either the top-level value, or the children if the max-depth
3584         is exceeded.
3585         (print_children): When printing the key of a map, allow one extra
3586         level of depth.
3587         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3588         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3589         (user_print_options): Initialise max_depth field.
3590         (val_print_scalar_or_string_type_p): New function.
3591         (val_print): Check to see if the max depth has been reached.
3592         (val_print_check_max_depth): Define new function.
3593         (show_print_max_depth): New function.
3594         (_initialize_valprint): Add 'print max-depth' option.
3595         * valprint.h (struct value_print_options) <max_depth>: New field.
3596         (val_print_check_max_depth): Declare new function.
3597         * NEWS: Document new feature.
3598
3599 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3600
3601         * ada-lang.c (ada_language_defn): Initialise new field.
3602         * c-lang.c (c_is_string_type_p): New function.
3603         (c_language_defn): Initialise new field.
3604         (cplus_language_defn): Initialise new field.
3605         (asm_language_defn): Initialise new field.
3606         (minimal_language_defn): Initialise new field.
3607         * c-lang.h (c_is_string_type_p): Declare new function.
3608         * d-lang.c (d_language_defn): Initialise new field.
3609         * f-lang.c (f_is_string_type_p): New function.
3610         (f_language_defn): Initialise new field.
3611         * go-lang.c (go_is_string_type_p): New function.
3612         (go_language_defn): Initialise new field.
3613         * language.c (default_is_string_type_p): New function.
3614         (unknown_language_defn): Initialise new field.
3615         (auto_language_defn): Initialise new field.
3616         * language.h (struct language_defn) <la_is_string_type_p>: New
3617         member variable.
3618         (default_is_string_type_p): Declare new function.
3619         * m2-lang.c (m2_language_defn): Initialise new field.
3620         * objc-lang.c (objc_language_defn): Initialise new field.
3621         * opencl-lang.c (opencl_language_defn): Initialise new field.
3622         * p-lang.c (pascal_is_string_type_p): New function.
3623         (pascal_language_defn): Initialise new field.
3624         * rust-lang.c (rust_is_string_type_p): New function.
3625         (rust_language_defn): Initialise new field.
3626
3627 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3628
3629         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3630         New field.
3631         * ada-lang.c (ada_language_defn): Initialise new field.
3632         * c-lang.c (c_language_defn): Likewise.
3633         (cplus_language_defn): Likewise.
3634         (asm_language_defn): Likewise.
3635         (minimal_language_defn): Likewise.
3636         * d-lang.c (d_language_defn): Likewise.
3637         * f-lang.c (f_language_defn): Likewise.
3638         * go-lang.c (go_language_defn): Likewise.
3639         * language.c (unknown_language_defn): Likewise.
3640         (auto_language_defn): Likewise.
3641         * m2-lang.c (m2_language_defn): Likewise.
3642         * objc-lang.c (objc_language_defn): Likewise.
3643         * opencl-lang.c (opencl_language_defn): Likewise.
3644         * p-lang.c (pascal_language_defn): Likewise.
3645         * rust-lang.c (rust_language_defn): Likewise.
3646
3647 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3648
3649         * ada-lang.c (ada_is_character_type): Change return type to bool.
3650         (ada_is_string_type): Likewise.
3651         * ada-lang.h (ada_is_character_type): Update declaration
3652         (ada_is_string_type): Likewise.
3653
3654 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3655
3656         Support style in 'frame|thread apply'
3657
3658         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3659         * record.c (record_start, record_stop): Update callers of
3660         execute_command_to_string with false.
3661         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3662         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3663         methods.
3664         (class string_file): New constructor with term_out parameter.
3665         Override methods term_out and can_emit_style_escape.  New member
3666         term_out.
3667         (class stdio_file): Override can_emit_style_escape.
3668         (class tee_file): Override term_out and can_emit_style_escape.
3669         * utils.h (can_emit_style_escape): Remove.
3670         * utils.c (can_emit_style_escape): Likewise.
3671         Update all callers of can_emit_style_escape (SOMESTREAM) to
3672         SOMESTREAM->can_emit_style_escape.
3673         * source-cache.c (source_cache::get_source_lines): Likewise.
3674         * stack.c (frame_apply_command_count): Call execute_command_to_string
3675         passing the term_out characteristic of the current gdb_stdout.
3676         * thread.c (thr_try_catch_cmd): Likewise.
3677         * top.c (execute_command_to_string): pass term_out parameter
3678         to construct the string_file for the command output.
3679         * ui-file.c (term_cli_styling): New function (most code moved
3680         from utils.c can_emit_style_escape).
3681         (string_file::string_file, string_file::can_emit_style_escape,
3682         stdio_file::can_emit_style_escape, tee_file::term_out,
3683         tee_file::can_emit_style_escape): New functions.
3684
3685 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3686
3687         * NEWS: Mention the new set|show may-call-functions.
3688         * infcall.c (may_call_functions_p): New variable.
3689         (show_may_call_functions_p): New function.
3690         (call_function_by_hand_dummy): Throws an error if not
3691         may-call-functions.
3692         (_initialize_infcall): Call add_setshow_boolean_cmd for
3693         may-call-functions.
3694
3695 2019-04-25  Keith Seitz  <keiths@redhat.com>
3696
3697         PR c++/24367
3698         * cp-support.c (inspect_type): Don't attempt substitutions
3699         of symbol with the same name.
3700
3701 2019-04-25  Tom Tromey  <tromey@adacore.com>
3702
3703         PR gdb/24475:
3704         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3705         static.
3706
3707 2019-04-25  Tom Tromey  <tromey@adacore.com>
3708
3709         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3710         rvalue reference.
3711         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3712         (gdb_xml_parser::parse): Use std::move.
3713         * python/python-internal.h (gdbpy_convert_exception): Take a const
3714         reference.
3715         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3716         std::move.
3717         * python/py-utils.c (gdbpy_convert_exception): Take a const
3718         reference.
3719         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3720         Use std::move.
3721         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3722         Use std::move.
3723         * mi/mi-main.c (mi_print_exception): Take a const reference.
3724         * main.c (handle_command_errors): Take a const reference.
3725         * linespec.c (parse_linespec): Use std::move.
3726         * infcall.c (run_inferior_call): Use std::move.
3727         (call_function_by_hand_dummy): Use std::move.
3728         * exec.c (try_open_exec_file): Use std::move.
3729         * exceptions.h (exception_print, exception_fprintf)
3730         (exception_print_same): Update.
3731         * exceptions.c (print_exception, exception_print)
3732         (exception_fprintf, exception_print_same): Change parameters to
3733         const reference.
3734         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3735         * common/new-op.c: Use std::move.
3736         * common/common-exceptions.h (struct gdb_exception): Add move
3737         constructor.
3738         (struct gdb_exception_error, struct gdb_exception_quit, struct
3739         gdb_quit_bad_alloc): Change constructor to move constructor.
3740         (throw_exception): Change parameter to rvalue reference.
3741         * common/common-exceptions.c (throw_exception): Take rvalue
3742         reference.
3743         * cli/cli-interp.c (safe_execute_command): Use std::move.
3744         * breakpoint.c (insert_bp_location, location_to_sals): Use
3745         std::move.
3746
3747 2019-04-25  Tom Tromey  <tromey@adacore.com>
3748
3749         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3750         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3751         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3752         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3753         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3754         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3755         guile/scm-value.c: Use unpack.
3756         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3757         gdbscm_gdb_exception.
3758         (gdbscm_throw_gdb_exception): Likewise.
3759         (struct gdbscm_gdb_exception): New.
3760         (unpack): New function.
3761         (gdbscm_wrap): Use unpack.
3762
3763 2019-04-25  Tom Tromey  <tromey@adacore.com>
3764
3765         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3766         (gdb_rl_callback_handler): Use std::move.
3767         * common/common-exceptions.h (struct gdb_exception): Add move
3768         assignment operator.
3769         (throw_exception_sjlj): Change "exception" to const reference.
3770         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3771         (throw_exception_sjlj): Change "exception" to const reference.
3772
3773 2019-04-25  Tom Tromey  <tromey@adacore.com>
3774
3775         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3776         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3777         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3778         Update.
3779         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3780         Update.
3781         * mi/mi-interp.c (mi_interp::exec): Update.
3782         * linespec.c (parse_linespec): Update.
3783         * infcall.c (run_inferior_call): Update.
3784         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3785         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3786         (gdbscm_lookup_global_symbol): Update.
3787         * guile/scm-param.c (gdbscm_parameter_value): Update.
3788         * guile/scm-frame.c (gdbscm_frame_read_register)
3789         (gdbscm_frame_read_var): Update.
3790         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3791         * exec.c (try_open_exec_file): Update.
3792         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3793         (gdb_rl_callback_handler): Update.
3794         * common/common-exceptions.h (exception_none): Don't declare.
3795         * common/common-exceptions.c (exception_none): Don't define.
3796         (struct catcher) <exception>: Update.
3797         * cli/cli-interp.c (safe_execute_command): Update.
3798         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3799
3800 2019-04-25  Ali Tamur  <tamur@google.com>
3801
3802         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3803         (read_attribute_value): Likewise.
3804         (dwarf2_read_addr_index): Update comment.
3805         (read_str_index): Add DW_FORM_strx.
3806         (dwarf2_string_attr): Likewise.
3807         (dwarf2_const_value_attr): Likewise.
3808         (dump_die_shallow): Likewise.
3809         (dwarf2_fetch_constant_bytes): Likewise.
3810         (skip_form_bytes): Likewise.
3811         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3812
3813 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3814
3815         PR corefiles/11608
3816         PR corefiles/18187
3817         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3818         OFFSET.  Verify if current mapping contains an ELF header.
3819         (linux_find_memory_regions_full): Adjust call to
3820         dump_mapping_p.
3821
3822 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3823             Kang Li <kanglictf@gmail.com>
3824
3825         PR gdb/21600
3826
3827         * dwarf2-frame.c (read_initial_length): Be consistent about using
3828         unsigned representation of length.
3829         (decode_frame_entry_1): Likewise.  Check for wraparound of
3830         end pointer as well as buffer overflow.
3831
3832 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3833
3834         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3835         "vq".
3836
3837 2019-04-24  Tom Tromey  <tromey@adacore.com>
3838
3839         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3840
3841 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3842
3843         * s12z-tdep.c (s12z_unwind_pc): Delete.
3844         (s12z_unwind_sp): Delete.
3845         (s12z_gdbarch_init): Don't register deleted functions with
3846         gdbarch.
3847
3848 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3849
3850         * rl78-tdep.c (rl78_unwind_sp): Delete.
3851         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3852
3853 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3854
3855         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3856         (xstormy16_unwind_pc): Delete.
3857         (xstormy16_dummy_id): Delete.
3858         (xstormy16_gdbarch_init): Don't register deleted functions with
3859         gdbarch.
3860
3861 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3862
3863         * vax-tdep.c (vax_unwind_pc): Delete.
3864         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3865
3866 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3867
3868         * v850-tdep.c (v850_unwind_sp): Delete.
3869         (v850_unwind_pc): Delete.
3870         (v850_dummy_id): Delete.
3871         (v850_gdbarch_init): Don't register deleted functions with
3872         gdbarch.
3873
3874 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3875
3876         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3877         (tilegx_unwind_pc): Delete.
3878         (tilegx_unwind_dummy_id): Delete.
3879         (tilegx_gdbarch_init): Don't register deleted functions with
3880         gdbarch.
3881
3882 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3883
3884         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3885         (tic6x_dummy_id): Delete.
3886         (tic6x_gdbarch_init): Don't register deleted functions with
3887         gdbarch.
3888
3889 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3890
3891         * sparc-tdep.c (sparc_unwind_pc): Delete.
3892         (sparc32_gdbarch_init): Don't register deleted function with
3893         gdbarch.
3894
3895 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3896
3897         * sh-tdep.c (sh_unwind_sp): Delete.
3898         (sh_unwind_pc): Delete.
3899         (sh_dummy_id): Delete.
3900         (sh_gdbarch_init): Don't register deleted functions with
3901         gdbarch.
3902
3903 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3904
3905         * score-tdep.c (score_unwind_sp): Delete.
3906         (score_unwind_pc): Delete.
3907         (score_dummy_id): Delete.
3908         (score_gdbarch_init): Don't register deleted functions with
3909         gdbarch.
3910
3911 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3912
3913         * rx-tdep.c (rx_unwind_pc): Delete.
3914         (rx_unwind_sp): Delete.
3915         (rx_dummy_id): Delete.
3916         (rx_gdbarch_init): Don't register deleted functions with
3917         gdbarch.  Update comment.
3918
3919 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3920
3921         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3922         (rs6000_dummy_id): Delete.
3923         (rs6000_gdbarch_init): Don't register deleted functions with
3924         gdbarch.
3925
3926 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3927
3928         * or1k-tdep.c (or1k_dummy_id): Delete.
3929         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3930
3931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3932
3933         * nios2-tdep.c (nios2_dummy_id): Delete.
3934         (nios2_unwind_sp): Delete.
3935         (nios2_gdbarch_init): Don't register deleted functions with
3936         gdbarch.
3937
3938 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3939
3940         * nds32-tdep.c (nds32_dummy_id): Delete.
3941         (nds32_unwind_pc): Delete.
3942         (nds32_unwind_sp): Delete.
3943         (nds32_gdbarch_init): Don't register deleted functions with
3944         gdbarch.
3945
3946 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3947
3948         * msp430-tdep.c (msp430_unwind_pc): Delete.
3949         (msp430_unwind_sp): Delete.
3950         (msp430_dummy_id): Delete.
3951         (msp430_gdbarch_init): Don't register deleted functions with
3952         gdbarch.
3953
3954 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3955
3956         * moxie-tdep.c (moxie_unwind_sp): Delete.
3957         (moxie_unwind_pc): Delete.
3958         (moxie_dummy_id): Delete.
3959         (moxie_gdbarch_init): Don't register deleted functions with
3960         gdbarch.
3961
3962 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3963
3964         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3965         (mn10300_unwind_pc): Delete.
3966         (mn10300_unwind_sp): Delete.
3967         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3968         mn10300_unwind_sp.
3969         (mn10300_frame_unwind_init): Don't register deleted functions with
3970         gdbarch.
3971
3972 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3973
3974         * mep-tdep.c (mep_unwind_pc): Delete.
3975         (mep_unwind_sp): Delete.
3976         (mep_dummy_id): Delete.
3977         (mep_gdbarch_init): Don't register deleted functions with
3978         gdbarch.
3979
3980 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3981
3982         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3983         (m68hc11_unwind_sp): Delete.
3984         (m68hc11_gdbarch_init): Don't register deleted functions with
3985         gdbarch.
3986
3987 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3988
3989         * m32r-tdep.c (m32r_unwind_sp): Delete.
3990         (m32r_unwind_pc): Delete.
3991         (m32r_dummy_id): Delete.
3992         (m32r_gdbarch_init): Don't register deleted functions with
3993         gdbarch.
3994
3995 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3996
3997         * m32c-tdep.c (m32c_unwind_pc): Delete.
3998         (m32c_unwind_sp): Delete.
3999         (m32c_dummy_id): Delete.
4000         (m32c_gdbarch_init): Don't register deleted functions with
4001         gdbarch.
4002
4003 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4004
4005         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4006         (lm32_unwind_pc): Delete.
4007         (lm32_dummy_id): Delete.
4008         (lm32_gdbarch_init): Don't register deleted functions with
4009         gdbarch.
4010
4011 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4012
4013         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4014         (iq2000_unwind_pc): Delete.
4015         (iq2000_dummy_id): Delete.
4016         (iq2000_gdbarch_init): Don't register deleted functions with
4017         gdbarch.
4018
4019 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4020
4021         * nds32-tdep.c (nds32_type_align): Delete.
4022         (nds32_push_dummy_call): Use type_align instead.
4023
4024 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4025
4026         * arm-tdep.c (arm_type_align): Only handle vector override case.
4027         (arm_push_dummy_call): Use type_align.
4028         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4029
4030 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4031
4032         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4033         case.
4034         (pass_on_stack): Use type_align.
4035         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4036         function.
4037
4038 2019-04-23  Tom Tromey  <tromey@adacore.com>
4039
4040         * dwarf2read.c (line_header::file_name_at): Remove unused
4041         overload.
4042
4043 2019-04-23  Tom de Vries  <tdevries@suse.de>
4044
4045         PR gdb/24438
4046         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4047         invocation.
4048
4049
4050 2019-03-27  Ali Tamur  <tamur@google.com>
4051
4052         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4053         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4054         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4055         (dwarf_expr_context::get_addr_index): Likewise
4056         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4057         (symbol_needs_eval_context::get_addr_index): Likewise
4058         (disassemble_dwarf_expression): Add DW_OP_addrx
4059         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4060         (read_cutu_die_from_dwo): Update comment
4061         (skip_one_die): Add DW_FORM_addrx
4062         (read_attribute_value): Likewise
4063         (var_decode_location): Add DW_OP_addrx
4064         (dwarf2_const_value_attr): Add DW_FORM_addrx
4065         (dump_die_shallow): Likewise
4066         (dwarf2_fetch_constant_bytes): Likewise
4067         (decode_locdesc): Add DW_OP_addrx
4068         (skip_form_bytes): Add DW_FORM_addrx
4069
4070 2019-04-22  Ali Tamur  <tamur@google.com>
4071
4072         * MAINTAINERS (Write After Approval): Add self.
4073
4074 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4075
4076         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4077         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4078         (open_symbol_file_object): Likewise.
4079         (svr4_default_sos): Add info parameter.
4080         (svr4_read_so_list): Likewise.
4081         (svr4_current_sos_direct): Adjust functions calls to pass down
4082         info.
4083         (svr4_current_sos_1): Add info parameter.
4084         (svr4_current_sos): Call get_svr4_info, pass info down to
4085         svr4_current_sos_1.
4086         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4087         get_svr4_info.
4088         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4089         get_svr4_info.
4090         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4091         to get_svr4_info.
4092         (probes_table_remove_objfile_probes): Likewise.
4093         (register_solib_event_probe): Add info parameter.
4094         (solist_update_incremental): Pass info parameter down to
4095         svr4_read_so_list.
4096         (disable_probes_interface): Add info parameter.
4097         (svr4_handle_solib_event): Pass current_program_space to
4098         get_svr4_info.  Adjust disable_probes_interface cleanup.
4099         (svr4_create_probe_breakpoints): Add info parameter, pass it
4100         down to register_solib_event_probe.
4101         (svr4_create_solib_event_breakpoints): Add info parameter,
4102         pass it down to svr4_create_probe_breakpoints.
4103         (enable_break): Pass info down to
4104         svr4_create_solib_event_breakpoints.
4105         (svr4_solib_create_inferior_hook): Pass current_program_space to
4106         get_svr4_info.
4107         (svr4_clear_solib): Likewise.
4108
4109 2019-04-22  Pedro Alves  <palves@redhat.com>
4110
4111         * solib-svr4.c (svr4_free_objfile_observer): New.
4112         (probe_and_action::objfile): New field.
4113         (probes_table_htab_remove_objfile_probes)
4114         (probes_table_remove_objfile_probes): New functions.
4115         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4116         in the new probe_and_action.  Don't store the probe in 'lookup'.
4117         (svr4_create_probe_breakpoints): Pass objfile to
4118         register_solib_event_probe.
4119         (_initialize_svr4_solib): Register a free_objfile observer.
4120
4121 2019-04-19  Tom Tromey  <tom@tromey.com>
4122
4123         * common/queue.h: Remove.
4124
4125 2019-04-19  Tom Tromey  <tom@tromey.com>
4126
4127         * event-loop.c: Don't include "common/queue.h".
4128
4129 2019-04-19  Tom Tromey  <tom@tromey.com>
4130
4131         * remote.c (remote_target): Use delete.
4132         * remote-notif.h: Include <list>, not "common/queue.h".
4133         (notif_client_p): Remove typedef.
4134         (remote_notif_state): Add constructor, destructor, initializer.
4135         <notif_queue>: Now a std::list.
4136         (remote_notif_state_xfree): Don't declare.
4137         * remote-notif.c (remote_notif_process, handle_notification)
4138         (remote_notif_state_allocate): Update.
4139         (~remote_notif_state): Rename from remote_notif_state_xfree.
4140
4141 2019-04-19  Tom Tromey  <tom@tromey.com>
4142
4143         * symfile.c (reread_symbols): Update.
4144         * objfiles.c (objfile_register_static_link)
4145         (objfile_lookup_static_link): Update
4146         (~objfile) Don't delete static_links.
4147         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4148
4149 2019-04-19  Tom Tromey  <tom@tromey.com>
4150
4151         * type-stack.h (struct type_stack) <insert>: Constify string.
4152         * type-stack.c (type_stack::insert): Constify string.
4153         * gdbtypes.h (lookup_template_type): Update.
4154         (address_space_name_to_int): Update.
4155         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4156         const.
4157         (lookup_template_type): Make name const.
4158         * c-exp.y: Update rules.
4159         (lex_one_token, classify_name, classify_inner_name)
4160         (c_print_token): Update.
4161         * p-exp.y: Update rules.
4162         (yylex): Update.
4163         * f-exp.y: Update rules.
4164         (yylex): Update.
4165         * d-exp.y: Update rules.
4166         (lex_one_token, classify_name, classify_inner_name): Update.
4167         * parse.c (write_dollar_variable, copy_name): Return std::string.
4168         * parser-defs.h (copy_name): Change return type.
4169         * m2-exp.y: Update rules.
4170         (yylex): Update.
4171         * go-exp.y (lex_one_token): Update.
4172         Update rules.
4173         (classify_unsafe_function, classify_packaged_name)
4174         (classify_name, yylex): Update.
4175
4176 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4177
4178         * configure.ac: add --enable-source-highlight switch.
4179         * configure: Regenerate.
4180         * top.c (print_gdb_version): plumb --enable-source-highlight
4181         status to "show configuration".
4182
4183 2019-04-19  Tom Tromey  <tromey@adacore.com>
4184
4185         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4186         Check ADA_TYPE_P.
4187         (empty_record, ada_template_to_fixed_record_type_1)
4188         (template_to_static_fixed_type)
4189         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4190         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4191         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4192         macros.
4193
4194 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4195
4196         PR symtab/24423:
4197         * source.c (print_source_lines_base): Advance "iter" when a
4198         control character is seen.
4199
4200 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4201
4202         * inferior.h (struct infcall_suspend_state_deleter):
4203         Catch exception in destructor to avoid crash.
4204
4205 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4206
4207         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4208         close to the add_com "shell".
4209
4210 2019-04-18  Tom Tromey  <tromey@adacore.com>
4211
4212         * process-stratum-target.h (class process_stratum_target)
4213         <stratum>: Add "final".
4214
4215 2019-04-17  Tom Tromey  <tromey@adacore.com>
4216
4217         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4218         against nullptr before use.
4219
4220 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4221
4222         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4223
4224 2019-04-17  Jim Wilson  <jimw@sifive.com>
4225             Andrew Burgess  <andrew.burgess@embecosm.com>
4226
4227         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4228         code read might fail, assume 4-byte breakpoint in that case.
4229
4230 2019-04-15  Leszek Swirski  <leszeks@google.com>
4231
4232         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4233         rather than a hand-rolled POD check when checking for forced MEMORY
4234         classification.
4235
4236 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4237
4238         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4239         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4240         function.
4241         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4242         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4243         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4244         declaration.
4245
4246 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4247
4248         * aarch64-linux-nat.c
4249         (aarch64_linux_nat_target::thread_architecture): Add override.
4250         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4251         each VQ.
4252
4253 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4254
4255         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4256
4257 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4258
4259         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4260         target types of size 96-bits, add some additional comments, and
4261         check that the builtin type we found was the correct size.
4262
4263 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4264
4265         * utils.c (prompt_for_continue): Don't restore the styling at the
4266         end, as applied_style has the wrong value.  This fixes styling in
4267         long lists of file names that are interrupted by the "Continue?"
4268         prompt.
4269
4270 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4271
4272         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4273         * c-lang.c (c_language_defn): Likewise.
4274         (cplus_language_defn): Likewise.
4275         (asm_language_defn): Likewise.
4276         (minimal_language_defn): Likewise.
4277         * d-lang.c (d_language_defn): Likewise.
4278         * f-lang.c (f_language_defn): Likewise.
4279         * go-lang.c (go_language_defn): Likewise.
4280         * language.c (unknown_language_defn): Likewise.
4281         (auto_language_defn): Likewise.
4282         * language.h (struct language_defn): Remove la_magic field.
4283         (LANG_MAGIC): Delete.
4284         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4285         * objc-lang.c (objc_language_defn): Likewise.
4286         * opencl-lang.c (opencl_language_defn): Likewise.
4287         * p-lang.c (pascal_language_defn): Likewise.
4288         * rust-lang.c (rust_language_defn): Likewise.
4289
4290 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4291
4292         * riscv-tdep.c (riscv_type_align): New function.
4293         (riscv_type_alignment): Delete.
4294         (riscv_arg_location): Use 'type_align'.
4295         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4296
4297 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4298
4299         * gdbtypes.c (type_align): A struct with no non-static fields also
4300         has alignment of 1.
4301
4302 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4303
4304         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4305         component to 0.
4306         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4307         member.
4308         (riscv_struct_info::analyse): New implementation using new
4309         analyse_inner member function.
4310         (riscv_struct_info::field_offset): New member function.
4311         (riscv_struct_info::m_offsets): New member variable.
4312         (riscv_struct_info::analyse_inner): New private member function,
4313         takes the old implementation of riscv_struct_info::analyse but
4314         extended to track field offsets.
4315         (riscv_call_arg_struct): Update the struct folding special cases
4316         to handle cases where empty C++ structs, which are non-zero
4317         length, are found.
4318         (riscv_arg_location): Initialise the length of each location, a
4319         non-zero length now indicates the location is in use.
4320         (riscv_push_dummy_call): Allow for the first location having a
4321         non-zero offset when setting up arguments.
4322         (riscv_return_value): Likewise, but for return values.
4323
4324 2019-04-11  Tom Tromey  <tromey@adacore.com>
4325
4326         * utils.c (internal_vproblem): Make "msg" const.
4327
4328 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4329
4330         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4331         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4332         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4333         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4334
4335 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4336
4337         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4338         function.
4339         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4340         of amd64_collect_native_gregset.
4341         (amd64_linux_nat_target::store_registers): Likewise.
4342
4343 2019-04-10  Tom Tromey  <tom@tromey.com>
4344
4345         * symtab.c (lookup_global_symbol_from_objfile)
4346         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4347         * objfiles.h (class separate_debug_iterator): New.
4348         (class separate_debug_range): New.
4349         (struct objfile) <separate_debug_objfiles>: New method.
4350         (objfile_separate_debug_iterate): Don't declare.
4351         * objfiles.c (separate_debug_iterator::operator++): Rename from
4352         objfile_separate_debug_iterate.
4353         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4354         iterator.
4355         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4356         iterator.
4357
4358 2019-04-10  Tom Tromey  <tom@tromey.com>
4359
4360         * symfile.c (reread_symbols): Remove old comment.
4361         * objfiles.c (free_all_objfiles): Fix a typo.
4362
4363 2019-04-10  Tom Tromey  <tom@tromey.com>
4364
4365         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4366         * minsyms.c (lookup_minimal_symbol): Use foreach.
4367         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4368         (lookup_minimal_symbol_solib_trampoline): Likewise.
4369         * symfile.c (reread_symbols): Use foreach.
4370
4371 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4372             Tom Tromey  <tromey@adacore.com>
4373
4374         PR rust/24414:
4375         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4376         (rust_lex_int_test): Change "value" to be LONGEST.
4377         (rust_lex_tests): Add test for long integer literal.
4378
4379 2019-04-09  Tom Tromey  <tromey@adacore.com>
4380
4381         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4382         to bool.
4383         (extended_remote_target::attach): Update.
4384         (remote_target::remote_notice_new_inferior): Update.
4385         (remote_target::add_current_inferior_and_thread): Update.
4386         * inferior.c (exit_inferior_1): Use "false".
4387         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4388
4389 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4390
4391         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4392         the "start" command.
4393
4394 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4395
4396         * python/py-inferior.c (infpy_thread_from_thread_handle):
4397         Adjust comments to reflect renaming of thread_from_thread_handle
4398         to thread_from_handle.  Adjust keywords.  Fix type error message.
4399         (inferior_object_methods): Add thread_from_handle.  Retain
4400         thread_from_thread_handle, but mark it as deprecated.
4401
4402 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4403
4404         * gdbthread.h (find_thread_by_handle): Revise declaration.
4405         * thread.c (find_thread_by_handle): Likewise.  Adjust
4406         implementation too.
4407         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4408         support for buffer objects as handles.
4409
4410 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4411
4412         * python/py-infthread.c (thpy_thread_handle): New function.
4413         (thread_object_methods): Register thpy_thread_handle.
4414
4415 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4416
4417         * gdbthread.h (thread_to_thread_handle): Declare.
4418         * thread.c (gdbtypes.h): Include.
4419         (thread_to_thread_handle): New function.
4420
4421         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4422         (target_thread_info_to_thread_handle): Declare.
4423         * target.c (target_thread_info_to_thread_handle): New function.
4424         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4425         * target-delegates.c: Regenerate.
4426
4427         * linux-thread-db.c (class thread_db_target): Add method
4428         thread_info_to_thread_handle.
4429         (thread_db_target::thread_info_to_thread_handle): Define.
4430         * remote.c (class remote_target): Add new method
4431         thread_info_to_thread_handle.
4432         (remote_target::thread_info_to_thread_handle): Define.
4433
4434 2019-04-08  Pedro Alves  <palves@redhat.com>
4435
4436         * common/common-exceptions.c (throw_exception): Don't create
4437         named object to throw; throw directly.
4438         (throw_it): Likewise.  Don't initialize gdb_exception::message
4439         here, with new; pass FMT and AP to the ctor instead.
4440         * common/common-exceptions.h: Include <string>.
4441         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4442         const char *, va_list)): New ctor.  Use std::make_shared.
4443         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4444         errors)): Delete.
4445         (gdb_exception_error::gdb_exception_error(enum errors, const char
4446         *, va_list)): New.
4447         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4448         Add assertion.
4449         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4450         errors)): Delete.
4451         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4452         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4453         Add assertion.
4454
4455 2019-04-08  Tom Tromey  <tom@tromey.com>
4456
4457         * valops.c (value_rtti_indirect_type): Replace throw_exception
4458         with throw.
4459         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4460         with throw.
4461         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4462         throw.
4463         * target.c (target_translate_tls_address): Replace throw_exception
4464         with throw.
4465         * stack.c (frame_apply_command_count): Replace throw_exception
4466         with throw.
4467         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4468         throw.
4469         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4470         with throw.
4471         * rs6000-tdep.c (rs6000_frame_cache)
4472         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4473         * remote.c: Replace throw_exception with throw.
4474         * record-full.c (record_full_message, record_full_wait_1)
4475         (record_full_restore): Replace throw_exception with throw.
4476         * record-btrace.c:
4477         (get_thread_current_frame_id, record_btrace_start_replaying)
4478         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4479         (cmd_record_btrace_start): Replace throw_exception with throw.
4480         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4481         throw.
4482         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4483         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4484         * linespec.c:
4485         (find_linespec_symbols): Replace throw_exception with throw.
4486         * infrun.c (displaced_step_prepare, resume): Replace
4487         throw_exception with throw.
4488         * infcmd.c (post_create_inferior): Replace throw_exception with
4489         throw.
4490         * inf-loop.c (inferior_event_handler): Replace throw_exception
4491         with throw.
4492         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4493         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4494         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4495         (get_prev_frame_always, get_frame_pc_if_available)
4496         (get_frame_address_in_block_if_available, get_frame_language):
4497         Replace throw_exception with throw.
4498         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4499         throw_exception with throw.
4500         * eval.c (fetch_subexp_value, evaluate_var_value)
4501         (evaluate_funcall, evaluate_subexp_standard): Replace
4502         throw_exception with throw.
4503         * dwarf2loc.c (call_site_find_chain)
4504         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4505         Replace throw_exception with throw.
4506         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4507         with throw.
4508         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4509         throw.
4510         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4511         * completer.c (complete_line_internal): Replace throw_exception
4512         with throw.
4513         * compile/compile-object-run.c (compile_object_run): Replace
4514         throw_exception with throw.
4515         * cli/cli-script.c (process_next_line): Replace throw_exception
4516         with throw.
4517         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4518         (btrace_enable, btrace_maint_update_pt_packets): Replace
4519         throw_exception with throw.
4520         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4521         throw_exception with throw.
4522         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4523         throw_exception with throw.
4524         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4525         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4526         * aarch64-tdep.c (aarch64_make_prologue_cache)
4527         (aarch64_make_stub_cache): Replace throw_exception with throw.
4528
4529 2019-04-08  Tom Tromey  <tom@tromey.com>
4530
4531         * common/common-exceptions.c (throw_exception): Rename from
4532         throw_exception_cxx.  Remove old copy.  Make argument const.
4533         (throw_it): Create and throw exception objects directly.
4534         * common/common-exceptions.h (throw_exception): Make argument
4535         const.
4536         (struct gdb_exception_error): Add constructor.
4537         (struct gdb_exception_quit): Add constructor.
4538
4539 2019-04-08  Tom Tromey  <tom@tromey.com>
4540
4541         * common/common-exceptions.h (exception_rethrow): Don't declare.
4542         (TRY_SJLJ): Update comment.
4543         (TRY, CATCH, END_CATCH): Remove.
4544         * common/common-exceptions.c (exception_rethrow): Remove.
4545
4546 2019-04-08  Tom Tromey  <tom@tromey.com>
4547
4548         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4549         Remove.
4550         (gdb_exception_error): Rename from
4551         gdb_exception_RETURN_MASK_ERROR.
4552         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4553         (gdb_quit_bad_alloc): Update.
4554         * aarch64-tdep.c: Update.
4555         * ada-lang.c: Update.
4556         * ada-typeprint.c: Update.
4557         * ada-valprint.c: Update.
4558         * amd64-tdep.c: Update.
4559         * arch-utils.c: Update.
4560         * break-catch-throw.c: Update.
4561         * breakpoint.c: Update.
4562         * btrace.c: Update.
4563         * c-varobj.c: Update.
4564         * cli/cli-cmds.c: Update.
4565         * cli/cli-interp.c: Update.
4566         * cli/cli-script.c: Update.
4567         * common/common-exceptions.c: Update.
4568         * common/new-op.c: Update.
4569         * common/selftest.c: Update.
4570         * compile/compile-c-symbols.c: Update.
4571         * compile/compile-cplus-symbols.c: Update.
4572         * compile/compile-object-load.c: Update.
4573         * compile/compile-object-run.c: Update.
4574         * completer.c: Update.
4575         * corelow.c: Update.
4576         * cp-abi.c: Update.
4577         * cp-support.c: Update.
4578         * cp-valprint.c: Update.
4579         * darwin-nat.c: Update.
4580         * disasm-selftests.c: Update.
4581         * dtrace-probe.c: Update.
4582         * dwarf-index-cache.c: Update.
4583         * dwarf-index-write.c: Update.
4584         * dwarf2-frame-tailcall.c: Update.
4585         * dwarf2-frame.c: Update.
4586         * dwarf2loc.c: Update.
4587         * dwarf2read.c: Update.
4588         * eval.c: Update.
4589         * event-loop.c: Update.
4590         * event-top.c: Update.
4591         * exec.c: Update.
4592         * f-valprint.c: Update.
4593         * fbsd-tdep.c: Update.
4594         * frame-unwind.c: Update.
4595         * frame.c: Update.
4596         * gdbtypes.c: Update.
4597         * gnu-v3-abi.c: Update.
4598         * guile/guile-internal.h: Update.
4599         * guile/scm-block.c: Update.
4600         * guile/scm-breakpoint.c: Update.
4601         * guile/scm-cmd.c: Update.
4602         * guile/scm-disasm.c: Update.
4603         * guile/scm-frame.c: Update.
4604         * guile/scm-lazy-string.c: Update.
4605         * guile/scm-math.c: Update.
4606         * guile/scm-param.c: Update.
4607         * guile/scm-ports.c: Update.
4608         * guile/scm-pretty-print.c: Update.
4609         * guile/scm-symbol.c: Update.
4610         * guile/scm-symtab.c: Update.
4611         * guile/scm-type.c: Update.
4612         * guile/scm-value.c: Update.
4613         * i386-linux-tdep.c: Update.
4614         * i386-tdep.c: Update.
4615         * inf-loop.c: Update.
4616         * infcall.c: Update.
4617         * infcmd.c: Update.
4618         * infrun.c: Update.
4619         * jit.c: Update.
4620         * language.c: Update.
4621         * linespec.c: Update.
4622         * linux-fork.c: Update.
4623         * linux-nat.c: Update.
4624         * linux-tdep.c: Update.
4625         * linux-thread-db.c: Update.
4626         * main.c: Update.
4627         * mi/mi-cmd-break.c: Update.
4628         * mi/mi-cmd-stack.c: Update.
4629         * mi/mi-interp.c: Update.
4630         * mi/mi-main.c: Update.
4631         * objc-lang.c: Update.
4632         * p-valprint.c: Update.
4633         * parse.c: Update.
4634         * ppc-linux-tdep.c: Update.
4635         * printcmd.c: Update.
4636         * python/py-arch.c: Update.
4637         * python/py-breakpoint.c: Update.
4638         * python/py-cmd.c: Update.
4639         * python/py-finishbreakpoint.c: Update.
4640         * python/py-frame.c: Update.
4641         * python/py-framefilter.c: Update.
4642         * python/py-gdb-readline.c: Update.
4643         * python/py-inferior.c: Update.
4644         * python/py-infthread.c: Update.
4645         * python/py-lazy-string.c: Update.
4646         * python/py-linetable.c: Update.
4647         * python/py-objfile.c: Update.
4648         * python/py-param.c: Update.
4649         * python/py-prettyprint.c: Update.
4650         * python/py-progspace.c: Update.
4651         * python/py-record-btrace.c: Update.
4652         * python/py-record.c: Update.
4653         * python/py-symbol.c: Update.
4654         * python/py-type.c: Update.
4655         * python/py-unwind.c: Update.
4656         * python/py-utils.c: Update.
4657         * python/py-value.c: Update.
4658         * python/python.c: Update.
4659         * record-btrace.c: Update.
4660         * record-full.c: Update.
4661         * remote-fileio.c: Update.
4662         * remote.c: Update.
4663         * riscv-tdep.c: Update.
4664         * rs6000-aix-tdep.c: Update.
4665         * rs6000-tdep.c: Update.
4666         * rust-exp.y: Update.
4667         * rust-lang.c: Update.
4668         * s390-tdep.c: Update.
4669         * selftest-arch.c: Update.
4670         * solib-dsbt.c: Update.
4671         * solib-frv.c: Update.
4672         * solib-spu.c: Update.
4673         * solib-svr4.c: Update.
4674         * solib.c: Update.
4675         * sparc64-linux-tdep.c: Update.
4676         * stack.c: Update.
4677         * symfile-mem.c: Update.
4678         * symmisc.c: Update.
4679         * target.c: Update.
4680         * thread.c: Update.
4681         * top.c: Update.
4682         * tracefile-tfile.c: Update.
4683         * tui/tui.c: Update.
4684         * typeprint.c: Update.
4685         * unittests/cli-utils-selftests.c: Update.
4686         * unittests/parse-connection-spec-selftests.c: Update.
4687         * valops.c: Update.
4688         * valprint.c: Update.
4689         * value.c: Update.
4690         * varobj.c: Update.
4691         * windows-nat.c: Update.
4692         * x86-linux-nat.c: Update.
4693         * xml-support.c: Update.
4694
4695 2019-04-08  Tom Tromey  <tom@tromey.com>
4696
4697         * xml-support.c: Use C++ exception handling.
4698         * x86-linux-nat.c: Use C++ exception handling.
4699         * windows-nat.c: Use C++ exception handling.
4700         * varobj.c: Use C++ exception handling.
4701         * value.c: Use C++ exception handling.
4702         * valprint.c: Use C++ exception handling.
4703         * valops.c: Use C++ exception handling.
4704         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4705         handling.
4706         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4707         * typeprint.c: Use C++ exception handling.
4708         * tui/tui.c: Use C++ exception handling.
4709         * tracefile-tfile.c: Use C++ exception handling.
4710         * top.c: Use C++ exception handling.
4711         * thread.c: Use C++ exception handling.
4712         * target.c: Use C++ exception handling.
4713         * symmisc.c: Use C++ exception handling.
4714         * symfile-mem.c: Use C++ exception handling.
4715         * stack.c: Use C++ exception handling.
4716         * sparc64-linux-tdep.c: Use C++ exception handling.
4717         * solib.c: Use C++ exception handling.
4718         * solib-svr4.c: Use C++ exception handling.
4719         * solib-spu.c: Use C++ exception handling.
4720         * solib-frv.c: Use C++ exception handling.
4721         * solib-dsbt.c: Use C++ exception handling.
4722         * selftest-arch.c: Use C++ exception handling.
4723         * s390-tdep.c: Use C++ exception handling.
4724         * rust-lang.c: Use C++ exception handling.
4725         * rust-exp.y: Use C++ exception handling.
4726         * rs6000-tdep.c: Use C++ exception handling.
4727         * rs6000-aix-tdep.c: Use C++ exception handling.
4728         * riscv-tdep.c: Use C++ exception handling.
4729         * remote.c: Use C++ exception handling.
4730         * remote-fileio.c: Use C++ exception handling.
4731         * record-full.c: Use C++ exception handling.
4732         * record-btrace.c: Use C++ exception handling.
4733         * python/python.c: Use C++ exception handling.
4734         * python/py-value.c: Use C++ exception handling.
4735         * python/py-utils.c: Use C++ exception handling.
4736         * python/py-unwind.c: Use C++ exception handling.
4737         * python/py-type.c: Use C++ exception handling.
4738         * python/py-symbol.c: Use C++ exception handling.
4739         * python/py-record.c: Use C++ exception handling.
4740         * python/py-record-btrace.c: Use C++ exception handling.
4741         * python/py-progspace.c: Use C++ exception handling.
4742         * python/py-prettyprint.c: Use C++ exception handling.
4743         * python/py-param.c: Use C++ exception handling.
4744         * python/py-objfile.c: Use C++ exception handling.
4745         * python/py-linetable.c: Use C++ exception handling.
4746         * python/py-lazy-string.c: Use C++ exception handling.
4747         * python/py-infthread.c: Use C++ exception handling.
4748         * python/py-inferior.c: Use C++ exception handling.
4749         * python/py-gdb-readline.c: Use C++ exception handling.
4750         * python/py-framefilter.c: Use C++ exception handling.
4751         * python/py-frame.c: Use C++ exception handling.
4752         * python/py-finishbreakpoint.c: Use C++ exception handling.
4753         * python/py-cmd.c: Use C++ exception handling.
4754         * python/py-breakpoint.c: Use C++ exception handling.
4755         * python/py-arch.c: Use C++ exception handling.
4756         * printcmd.c: Use C++ exception handling.
4757         * ppc-linux-tdep.c: Use C++ exception handling.
4758         * parse.c: Use C++ exception handling.
4759         * p-valprint.c: Use C++ exception handling.
4760         * objc-lang.c: Use C++ exception handling.
4761         * mi/mi-main.c: Use C++ exception handling.
4762         * mi/mi-interp.c: Use C++ exception handling.
4763         * mi/mi-cmd-stack.c: Use C++ exception handling.
4764         * mi/mi-cmd-break.c: Use C++ exception handling.
4765         * main.c: Use C++ exception handling.
4766         * linux-thread-db.c: Use C++ exception handling.
4767         * linux-tdep.c: Use C++ exception handling.
4768         * linux-nat.c: Use C++ exception handling.
4769         * linux-fork.c: Use C++ exception handling.
4770         * linespec.c: Use C++ exception handling.
4771         * language.c: Use C++ exception handling.
4772         * jit.c: Use C++ exception handling.
4773         * infrun.c: Use C++ exception handling.
4774         * infcmd.c: Use C++ exception handling.
4775         * infcall.c: Use C++ exception handling.
4776         * inf-loop.c: Use C++ exception handling.
4777         * i386-tdep.c: Use C++ exception handling.
4778         * i386-linux-tdep.c: Use C++ exception handling.
4779         * guile/scm-value.c: Use C++ exception handling.
4780         * guile/scm-type.c: Use C++ exception handling.
4781         * guile/scm-symtab.c: Use C++ exception handling.
4782         * guile/scm-symbol.c: Use C++ exception handling.
4783         * guile/scm-pretty-print.c: Use C++ exception handling.
4784         * guile/scm-ports.c: Use C++ exception handling.
4785         * guile/scm-param.c: Use C++ exception handling.
4786         * guile/scm-math.c: Use C++ exception handling.
4787         * guile/scm-lazy-string.c: Use C++ exception handling.
4788         * guile/scm-frame.c: Use C++ exception handling.
4789         * guile/scm-disasm.c: Use C++ exception handling.
4790         * guile/scm-cmd.c: Use C++ exception handling.
4791         * guile/scm-breakpoint.c: Use C++ exception handling.
4792         * guile/scm-block.c: Use C++ exception handling.
4793         * guile/guile-internal.h: Use C++ exception handling.
4794         * gnu-v3-abi.c: Use C++ exception handling.
4795         * gdbtypes.c: Use C++ exception handling.
4796         * frame.c: Use C++ exception handling.
4797         * frame-unwind.c: Use C++ exception handling.
4798         * fbsd-tdep.c: Use C++ exception handling.
4799         * f-valprint.c: Use C++ exception handling.
4800         * exec.c: Use C++ exception handling.
4801         * event-top.c: Use C++ exception handling.
4802         * event-loop.c: Use C++ exception handling.
4803         * eval.c: Use C++ exception handling.
4804         * dwarf2read.c: Use C++ exception handling.
4805         * dwarf2loc.c: Use C++ exception handling.
4806         * dwarf2-frame.c: Use C++ exception handling.
4807         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4808         * dwarf-index-write.c: Use C++ exception handling.
4809         * dwarf-index-cache.c: Use C++ exception handling.
4810         * dtrace-probe.c: Use C++ exception handling.
4811         * disasm-selftests.c: Use C++ exception handling.
4812         * darwin-nat.c: Use C++ exception handling.
4813         * cp-valprint.c: Use C++ exception handling.
4814         * cp-support.c: Use C++ exception handling.
4815         * cp-abi.c: Use C++ exception handling.
4816         * corelow.c: Use C++ exception handling.
4817         * completer.c: Use C++ exception handling.
4818         * compile/compile-object-run.c: Use C++ exception handling.
4819         * compile/compile-object-load.c: Use C++ exception handling.
4820         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4821         * compile/compile-c-symbols.c: Use C++ exception handling.
4822         * common/selftest.c: Use C++ exception handling.
4823         * common/new-op.c: Use C++ exception handling.
4824         * cli/cli-script.c: Use C++ exception handling.
4825         * cli/cli-interp.c: Use C++ exception handling.
4826         * cli/cli-cmds.c: Use C++ exception handling.
4827         * c-varobj.c: Use C++ exception handling.
4828         * btrace.c: Use C++ exception handling.
4829         * breakpoint.c: Use C++ exception handling.
4830         * break-catch-throw.c: Use C++ exception handling.
4831         * arch-utils.c: Use C++ exception handling.
4832         * amd64-tdep.c: Use C++ exception handling.
4833         * ada-valprint.c: Use C++ exception handling.
4834         * ada-typeprint.c: Use C++ exception handling.
4835         * ada-lang.c: Use C++ exception handling.
4836         * aarch64-tdep.c: Use C++ exception handling.
4837
4838 2019-04-08  Tom Tromey  <tom@tromey.com>
4839
4840         * xml-support.c (gdb_xml_parser::parse): Update.
4841         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4842         * value.c (show_convenience): Update.
4843         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4844         (test_parse_flags_qcs): Update.
4845         * thread.c (thr_try_catch_cmd): Update.
4846         * target.c (target_translate_tls_address): Update.
4847         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4848         (info_frame_command_core, frame_apply_command_count): Update.
4849         * rust-exp.y (rust_lex_exception_test): Update.
4850         * riscv-tdep.c (riscv_print_one_register_info): Update.
4851         * remote.c (remote_target::enable_btrace): Update.
4852         * record-btrace.c (record_btrace_enable_warn): Update.
4853         * python/py-utils.c (gdbpy_convert_exception): Update.
4854         * printcmd.c (do_one_display, print_variable_and_value): Update.
4855         * mi/mi-main.c (mi_print_exception): Update.
4856         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4857         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4858         * linux-nat.c (linux_nat_target::attach): Update.
4859         * linux-fork.c (class scoped_switch_fork_info): Update.
4860         * infrun.c (displaced_step_prepare): Update.
4861         * infcall.c (call_function_by_hand_dummy): Update.
4862         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4863         * gnu-v3-abi.c (print_one_vtable): Update.
4864         * frame.c (get_prev_frame_always): Update.
4865         * f-valprint.c (info_common_command_for_block): Update.
4866         * exec.c (try_open_exec_file): Update.
4867         * exceptions.c (print_exception, exception_print)
4868         (exception_fprintf, exception_print_same): Update.
4869         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4870         * dwarf-index-cache.c (index_cache::store)
4871         (index_cache::lookup_gdb_index): Update.
4872         * darwin-nat.c (maybe_cache_shell): Update.
4873         * cp-valprint.c (cp_print_value_fields): Update.
4874         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4875         (gcc_cplus_symbol_address): Update.
4876         * compile/compile-c-symbols.c (gcc_convert_symbol)
4877         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4878         * common/selftest.c: Update.
4879         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4880         a std::string.
4881         (exception_try_scope_entry, exception_try_scope_exit): Don't
4882         declare.
4883         (struct exception_try_scope): Remove.
4884         (TRY): Don't use exception_try_scope.
4885         (struct gdb_exception): Add constructor, operator=.
4886         <what>: New method.
4887         (struct gdb_exception_RETURN_MASK_ALL)
4888         (struct gdb_exception_RETURN_MASK_ERROR)
4889         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4890         (struct gdb_quit_bad_alloc): Update.
4891         * common/common-exceptions.c (exception_none): Change
4892         initializer.
4893         (struct catcher) <state, exception>: Initialize inline.
4894         <prev>: Remove member.
4895         (current_catcher): Remove.
4896         (catchers): New global.
4897         (exceptions_state_mc_init): Simplify.
4898         (catcher_pop): Remove.
4899         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4900         (try_scope_depth, exception_try_scope_entry)
4901         (exception_try_scope_exit): Remove.
4902         (throw_exception_sjlj): Update.
4903         (exception_messages, exception_messages_size): Remove.
4904         (throw_it): Simplify.
4905         (gdb_exception_sliced_copy): Remove.
4906         (throw_exception_cxx): Update.
4907         * cli/cli-script.c (script_from_file): Update.
4908         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4909         Update.
4910         * ada-valprint.c (ada_val_print): Update.
4911         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4912         (create_excep_cond_exprs): Update.
4913
4914 2019-04-08  Tom Tromey  <tom@tromey.com>
4915
4916         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4917         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4918         (TRY, CATCH, END_CATCH): Remove some definitions.
4919         * common/common-exceptions.c: Don't use GDB_XCPT.
4920         (catcher_list_size): Remove.
4921         (throw_exception, throw_it): Simplify.
4922
4923 2019-04-05  Tom Tromey  <tom@tromey.com>
4924
4925         Revert the header-sorting patch.
4926         * ft32-tdep.c: Revert.
4927         * frv-tdep.c: Revert.
4928         * frv-linux-tdep.c: Revert.
4929         * frame.c: Revert.
4930         * frame-unwind.c: Revert.
4931         * frame-base.c: Revert.
4932         * fork-child.c: Revert.
4933         * findvar.c: Revert.
4934         * findcmd.c: Revert.
4935         * filesystem.c: Revert.
4936         * filename-seen-cache.h: Revert.
4937         * filename-seen-cache.c: Revert.
4938         * fbsd-tdep.c: Revert.
4939         * fbsd-nat.h: Revert.
4940         * fbsd-nat.c: Revert.
4941         * f-valprint.c: Revert.
4942         * f-typeprint.c: Revert.
4943         * f-lang.c: Revert.
4944         * extension.h: Revert.
4945         * extension.c: Revert.
4946         * extension-priv.h: Revert.
4947         * expprint.c: Revert.
4948         * exec.h: Revert.
4949         * exec.c: Revert.
4950         * exceptions.c: Revert.
4951         * event-top.c: Revert.
4952         * event-loop.c: Revert.
4953         * eval.c: Revert.
4954         * elfread.c: Revert.
4955         * dwarf2read.h: Revert.
4956         * dwarf2read.c: Revert.
4957         * dwarf2loc.c: Revert.
4958         * dwarf2expr.h: Revert.
4959         * dwarf2expr.c: Revert.
4960         * dwarf2-frame.c: Revert.
4961         * dwarf2-frame-tailcall.c: Revert.
4962         * dwarf-index-write.h: Revert.
4963         * dwarf-index-write.c: Revert.
4964         * dwarf-index-common.c: Revert.
4965         * dwarf-index-cache.h: Revert.
4966         * dwarf-index-cache.c: Revert.
4967         * dummy-frame.c: Revert.
4968         * dtrace-probe.c: Revert.
4969         * disasm.h: Revert.
4970         * disasm.c: Revert.
4971         * disasm-selftests.c: Revert.
4972         * dictionary.c: Revert.
4973         * dicos-tdep.c: Revert.
4974         * demangle.c: Revert.
4975         * dcache.h: Revert.
4976         * dcache.c: Revert.
4977         * darwin-nat.h: Revert.
4978         * darwin-nat.c: Revert.
4979         * darwin-nat-info.c: Revert.
4980         * d-valprint.c: Revert.
4981         * d-namespace.c: Revert.
4982         * d-lang.c: Revert.
4983         * ctf.c: Revert.
4984         * csky-tdep.c: Revert.
4985         * csky-linux-tdep.c: Revert.
4986         * cris-tdep.c: Revert.
4987         * cris-linux-tdep.c: Revert.
4988         * cp-valprint.c: Revert.
4989         * cp-support.c: Revert.
4990         * cp-namespace.c: Revert.
4991         * cp-abi.c: Revert.
4992         * corelow.c: Revert.
4993         * corefile.c: Revert.
4994         * continuations.c: Revert.
4995         * completer.h: Revert.
4996         * completer.c: Revert.
4997         * complaints.c: Revert.
4998         * coffread.c: Revert.
4999         * coff-pe-read.c: Revert.
5000         * cli-out.h: Revert.
5001         * cli-out.c: Revert.
5002         * charset.c: Revert.
5003         * c-varobj.c: Revert.
5004         * c-valprint.c: Revert.
5005         * c-typeprint.c: Revert.
5006         * c-lang.c: Revert.
5007         * buildsym.c: Revert.
5008         * buildsym-legacy.c: Revert.
5009         * build-id.h: Revert.
5010         * build-id.c: Revert.
5011         * btrace.c: Revert.
5012         * bsd-uthread.c: Revert.
5013         * breakpoint.h: Revert.
5014         * breakpoint.c: Revert.
5015         * break-catch-throw.c: Revert.
5016         * break-catch-syscall.c: Revert.
5017         * break-catch-sig.c: Revert.
5018         * blockframe.c: Revert.
5019         * block.c: Revert.
5020         * bfin-tdep.c: Revert.
5021         * bfin-linux-tdep.c: Revert.
5022         * bfd-target.c: Revert.
5023         * bcache.c: Revert.
5024         * ax-general.c: Revert.
5025         * ax-gdb.h: Revert.
5026         * ax-gdb.c: Revert.
5027         * avr-tdep.c: Revert.
5028         * auxv.c: Revert.
5029         * auto-load.c: Revert.
5030         * arm-wince-tdep.c: Revert.
5031         * arm-tdep.c: Revert.
5032         * arm-symbian-tdep.c: Revert.
5033         * arm-pikeos-tdep.c: Revert.
5034         * arm-obsd-tdep.c: Revert.
5035         * arm-nbsd-tdep.c: Revert.
5036         * arm-nbsd-nat.c: Revert.
5037         * arm-linux-tdep.c: Revert.
5038         * arm-linux-nat.c: Revert.
5039         * arm-fbsd-tdep.c: Revert.
5040         * arm-fbsd-nat.c: Revert.
5041         * arm-bsd-tdep.c: Revert.
5042         * arch-utils.c: Revert.
5043         * arc-tdep.c: Revert.
5044         * arc-newlib-tdep.c: Revert.
5045         * annotate.h: Revert.
5046         * annotate.c: Revert.
5047         * amd64-windows-tdep.c: Revert.
5048         * amd64-windows-nat.c: Revert.
5049         * amd64-tdep.c: Revert.
5050         * amd64-sol2-tdep.c: Revert.
5051         * amd64-obsd-tdep.c: Revert.
5052         * amd64-obsd-nat.c: Revert.
5053         * amd64-nbsd-tdep.c: Revert.
5054         * amd64-nbsd-nat.c: Revert.
5055         * amd64-nat.c: Revert.
5056         * amd64-linux-tdep.c: Revert.
5057         * amd64-linux-nat.c: Revert.
5058         * amd64-fbsd-tdep.c: Revert.
5059         * amd64-fbsd-nat.c: Revert.
5060         * amd64-dicos-tdep.c: Revert.
5061         * amd64-darwin-tdep.c: Revert.
5062         * amd64-bsd-nat.c: Revert.
5063         * alpha-tdep.c: Revert.
5064         * alpha-obsd-tdep.c: Revert.
5065         * alpha-nbsd-tdep.c: Revert.
5066         * alpha-mdebug-tdep.c: Revert.
5067         * alpha-linux-tdep.c: Revert.
5068         * alpha-linux-nat.c: Revert.
5069         * alpha-bsd-tdep.c: Revert.
5070         * alpha-bsd-nat.c: Revert.
5071         * aix-thread.c: Revert.
5072         * agent.c: Revert.
5073         * addrmap.c: Revert.
5074         * ada-varobj.c: Revert.
5075         * ada-valprint.c: Revert.
5076         * ada-typeprint.c: Revert.
5077         * ada-tasks.c: Revert.
5078         * ada-lang.c: Revert.
5079         * aarch64-tdep.c: Revert.
5080         * aarch64-ravenscar-thread.c: Revert.
5081         * aarch64-newlib-tdep.c: Revert.
5082         * aarch64-linux-tdep.c: Revert.
5083         * aarch64-linux-nat.c: Revert.
5084         * aarch64-fbsd-tdep.c: Revert.
5085         * aarch64-fbsd-nat.c: Revert.
5086         * aarch32-linux-nat.c: Revert.
5087
5088 2019-04-05  Tom Tromey  <tom@tromey.com>
5089
5090         * ft32-tdep.c: Sort headers.
5091         * frv-tdep.c: Sort headers.
5092         * frv-linux-tdep.c: Sort headers.
5093         * frame.c: Sort headers.
5094         * frame-unwind.c: Sort headers.
5095         * frame-base.c: Sort headers.
5096         * fork-child.c: Sort headers.
5097         * findvar.c: Sort headers.
5098         * findcmd.c: Sort headers.
5099         * filesystem.c: Sort headers.
5100         * filename-seen-cache.h: Sort headers.
5101         * filename-seen-cache.c: Sort headers.
5102         * fbsd-tdep.c: Sort headers.
5103         * fbsd-nat.h: Sort headers.
5104         * fbsd-nat.c: Sort headers.
5105         * f-valprint.c: Sort headers.
5106         * f-typeprint.c: Sort headers.
5107         * f-lang.c: Sort headers.
5108         * extension.h: Sort headers.
5109         * extension.c: Sort headers.
5110         * extension-priv.h: Sort headers.
5111         * expprint.c: Sort headers.
5112         * exec.h: Sort headers.
5113         * exec.c: Sort headers.
5114         * exceptions.c: Sort headers.
5115         * event-top.c: Sort headers.
5116         * event-loop.c: Sort headers.
5117         * eval.c: Sort headers.
5118         * elfread.c: Sort headers.
5119         * dwarf2read.h: Sort headers.
5120         * dwarf2read.c: Sort headers.
5121         * dwarf2loc.c: Sort headers.
5122         * dwarf2expr.h: Sort headers.
5123         * dwarf2expr.c: Sort headers.
5124         * dwarf2-frame.c: Sort headers.
5125         * dwarf2-frame-tailcall.c: Sort headers.
5126         * dwarf-index-write.h: Sort headers.
5127         * dwarf-index-write.c: Sort headers.
5128         * dwarf-index-common.c: Sort headers.
5129         * dwarf-index-cache.h: Sort headers.
5130         * dwarf-index-cache.c: Sort headers.
5131         * dummy-frame.c: Sort headers.
5132         * dtrace-probe.c: Sort headers.
5133         * disasm.h: Sort headers.
5134         * disasm.c: Sort headers.
5135         * disasm-selftests.c: Sort headers.
5136         * dictionary.c: Sort headers.
5137         * dicos-tdep.c: Sort headers.
5138         * demangle.c: Sort headers.
5139         * dcache.h: Sort headers.
5140         * dcache.c: Sort headers.
5141         * darwin-nat.h: Sort headers.
5142         * darwin-nat.c: Sort headers.
5143         * darwin-nat-info.c: Sort headers.
5144         * d-valprint.c: Sort headers.
5145         * d-namespace.c: Sort headers.
5146         * d-lang.c: Sort headers.
5147         * ctf.c: Sort headers.
5148         * csky-tdep.c: Sort headers.
5149         * csky-linux-tdep.c: Sort headers.
5150         * cris-tdep.c: Sort headers.
5151         * cris-linux-tdep.c: Sort headers.
5152         * cp-valprint.c: Sort headers.
5153         * cp-support.c: Sort headers.
5154         * cp-namespace.c: Sort headers.
5155         * cp-abi.c: Sort headers.
5156         * corelow.c: Sort headers.
5157         * corefile.c: Sort headers.
5158         * continuations.c: Sort headers.
5159         * completer.h: Sort headers.
5160         * completer.c: Sort headers.
5161         * complaints.c: Sort headers.
5162         * coffread.c: Sort headers.
5163         * coff-pe-read.c: Sort headers.
5164         * cli-out.h: Sort headers.
5165         * cli-out.c: Sort headers.
5166         * charset.c: Sort headers.
5167         * c-varobj.c: Sort headers.
5168         * c-valprint.c: Sort headers.
5169         * c-typeprint.c: Sort headers.
5170         * c-lang.c: Sort headers.
5171         * buildsym.c: Sort headers.
5172         * buildsym-legacy.c: Sort headers.
5173         * build-id.h: Sort headers.
5174         * build-id.c: Sort headers.
5175         * btrace.c: Sort headers.
5176         * bsd-uthread.c: Sort headers.
5177         * breakpoint.h: Sort headers.
5178         * breakpoint.c: Sort headers.
5179         * break-catch-throw.c: Sort headers.
5180         * break-catch-syscall.c: Sort headers.
5181         * break-catch-sig.c: Sort headers.
5182         * blockframe.c: Sort headers.
5183         * block.c: Sort headers.
5184         * bfin-tdep.c: Sort headers.
5185         * bfin-linux-tdep.c: Sort headers.
5186         * bfd-target.c: Sort headers.
5187         * bcache.c: Sort headers.
5188         * ax-general.c: Sort headers.
5189         * ax-gdb.h: Sort headers.
5190         * ax-gdb.c: Sort headers.
5191         * avr-tdep.c: Sort headers.
5192         * auxv.c: Sort headers.
5193         * auto-load.c: Sort headers.
5194         * arm-wince-tdep.c: Sort headers.
5195         * arm-tdep.c: Sort headers.
5196         * arm-symbian-tdep.c: Sort headers.
5197         * arm-pikeos-tdep.c: Sort headers.
5198         * arm-obsd-tdep.c: Sort headers.
5199         * arm-nbsd-tdep.c: Sort headers.
5200         * arm-nbsd-nat.c: Sort headers.
5201         * arm-linux-tdep.c: Sort headers.
5202         * arm-linux-nat.c: Sort headers.
5203         * arm-fbsd-tdep.c: Sort headers.
5204         * arm-fbsd-nat.c: Sort headers.
5205         * arm-bsd-tdep.c: Sort headers.
5206         * arch-utils.c: Sort headers.
5207         * arc-tdep.c: Sort headers.
5208         * arc-newlib-tdep.c: Sort headers.
5209         * annotate.h: Sort headers.
5210         * annotate.c: Sort headers.
5211         * amd64-windows-tdep.c: Sort headers.
5212         * amd64-windows-nat.c: Sort headers.
5213         * amd64-tdep.c: Sort headers.
5214         * amd64-sol2-tdep.c: Sort headers.
5215         * amd64-obsd-tdep.c: Sort headers.
5216         * amd64-obsd-nat.c: Sort headers.
5217         * amd64-nbsd-tdep.c: Sort headers.
5218         * amd64-nbsd-nat.c: Sort headers.
5219         * amd64-nat.c: Sort headers.
5220         * amd64-linux-tdep.c: Sort headers.
5221         * amd64-linux-nat.c: Sort headers.
5222         * amd64-fbsd-tdep.c: Sort headers.
5223         * amd64-fbsd-nat.c: Sort headers.
5224         * amd64-dicos-tdep.c: Sort headers.
5225         * amd64-darwin-tdep.c: Sort headers.
5226         * amd64-bsd-nat.c: Sort headers.
5227         * alpha-tdep.c: Sort headers.
5228         * alpha-obsd-tdep.c: Sort headers.
5229         * alpha-nbsd-tdep.c: Sort headers.
5230         * alpha-mdebug-tdep.c: Sort headers.
5231         * alpha-linux-tdep.c: Sort headers.
5232         * alpha-linux-nat.c: Sort headers.
5233         * alpha-bsd-tdep.c: Sort headers.
5234         * alpha-bsd-nat.c: Sort headers.
5235         * aix-thread.c: Sort headers.
5236         * agent.c: Sort headers.
5237         * addrmap.c: Sort headers.
5238         * ada-varobj.c: Sort headers.
5239         * ada-valprint.c: Sort headers.
5240         * ada-typeprint.c: Sort headers.
5241         * ada-tasks.c: Sort headers.
5242         * ada-lang.c: Sort headers.
5243         * aarch64-tdep.c: Sort headers.
5244         * aarch64-ravenscar-thread.c: Sort headers.
5245         * aarch64-newlib-tdep.c: Sort headers.
5246         * aarch64-linux-tdep.c: Sort headers.
5247         * aarch64-linux-nat.c: Sort headers.
5248         * aarch64-fbsd-tdep.c: Sort headers.
5249         * aarch64-fbsd-nat.c: Sort headers.
5250         * aarch32-linux-nat.c: Sort headers.
5251
5252 2019-04-04  Tom Tromey  <tom@tromey.com>
5253
5254         * varobj.c (varobj_create): Update.
5255         * rust-exp.y (struct rust_parser) <update_innermost_block,
5256         lookup_symbol>: New methods.
5257         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5258         Rename.
5259         (rust_parser::rust_lookup_type)
5260         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5261         * printcmd.c (display_command, do_one_display): Update.
5262         * parser-defs.h (struct parser_state) <parser_state>: Add
5263         "tracker" parameter.
5264         (block_tracker): New member.
5265         (class innermost_block_tracker) <innermost_block_tracker>: Add
5266         "types" parameter.
5267         <reset>: Remove method.
5268         (innermost_block): Don't declare.
5269         (null_post_parser): Update.
5270         * parse.c (innermost_block): Remove global.
5271         (write_dollar_variable): Update.
5272         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5273         Remove "tracker_types" parameter.
5274         (parse_expression): Add "tracker" parameter.
5275         (parse_expression_for_completion): Update.
5276         (null_post_parser): Add "tracker" parameter.
5277         * p-exp.y: Update rules.
5278         * m2-exp.y: Update rules.
5279         * language.h (struct language_defn) <la_post_parser>: Add
5280         "tracker" parameter.
5281         * go-exp.y: Update rules.
5282         * f-exp.y: Update rules.
5283         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5284         parameter.
5285         * d-exp.y: Update rules.
5286         * c-exp.y: Update rules.
5287         * breakpoint.c (set_breakpoint_condition): Create an
5288         innermost_block_tracker.
5289         (watch_command_1): Likewise.
5290         * ada-lang.c (resolve): Add "tracker" parameter.
5291         (resolve_subexp): Likewise.
5292         * ada-exp.y (write_var_from_sym): Update.
5293
5294 2019-04-04  Tom Tromey  <tom@tromey.com>
5295
5296         * type-stack.h: New file.
5297         * type-stack.c: New file.
5298         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5299         type-stack.h.
5300         (insert_into_type_stack, insert_type, push_type, push_type_int)
5301         (insert_type_address_space, pop_type, pop_type_int)
5302         (pop_typelist, pop_type_stack, append_type_stack)
5303         (push_type_stack, get_type_stack, push_typelist)
5304         (follow_type_instance_flags, follow_types): Don't declare.
5305         * parse.c (type_stack): Remove global.
5306         (parse_exp_in_context): Update.
5307         (insert_into_type_stack, insert_type, push_type, push_type_int)
5308         (insert_type_address_space, pop_type, pop_type_int)
5309         (pop_typelist, pop_type_stack, append_type_stack)
5310         (push_type_stack, get_type_stack, push_typelist)
5311         (follow_type_instance_flags, follow_types): Remove (moved to
5312         type-stack.c).
5313         * f-exp.y (type_stack): New global.
5314         Update rules.
5315         (push_kind_type, f_parse): Update.
5316         * d-exp.y (type_stack): New global.
5317         Update rules.
5318         (d_parse): Update.
5319         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5320         Update rules.
5321         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5322         (HFILES_NO_SRCDIR): Add type-stack.h.
5323
5324 2019-04-04  Tom Tromey  <tom@tromey.com>
5325
5326         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5327         (rust_parser::convert_ast_to_expression, rust_parse)
5328         (rust_lex_test_completion, rust_lex_tests): Update.
5329         * parser-defs.h (struct expr_completion_state): New.
5330         (struct parser_state) <parser_state>: Add completion parameter.
5331         <mark_struct_expression, mark_completion_tag>: New methods.
5332         <parse_completion, m_completion_state>: New members.
5333         (prefixify_expression, null_post_parser): Update.
5334         (mark_struct_expression, mark_completion_tag): Don't declare.
5335         * parse.c (parse_completion, expout_last_struct)
5336         (expout_tag_completion_type, expout_completion_name): Remove
5337         globals.
5338         (parser_state::mark_struct_expression)
5339         (parser_state::mark_completion_tag): Now methods.
5340         (prefixify_expression): Add last_struct parameter.
5341         (prefixify_subexp): Likewise.
5342         (parse_exp_1): Update.
5343         (parse_exp_in_context): Add cstate parameter.  Update.
5344         (parse_expression_for_completion): Create an
5345         expr_completion_state.
5346         (null_post_parser): Add "completion" parameter.
5347         * p-exp.y: Update rules.
5348         (yylex): Update.
5349         * language.h (struct language_defn) <la_post_parser>: Add
5350         "completing" parameter.
5351         * go-exp.y: Update rules.
5352         (lex_one_token): Update.
5353         * expression.h (parse_completion): Don't declare.
5354         * d-exp.y: Update rules.
5355         (lex_one_token): Update rules.
5356         * c-exp.y: Update rules.
5357         (lex_one_token): Update.
5358         * ada-lang.c (resolve): Add "parse_completion" parameter.
5359         (resolve_subexp): Likewise.
5360         (ada_resolve_function): Likewise.
5361
5362 2019-04-04  Tom Tromey  <tom@tromey.com>
5363
5364         * parser-defs.h (struct parser_state) <start_arglist,
5365         end_arglist>: New methods.
5366         <arglist_len, m_funcall_chain>: New members.
5367         (arglist_len, start_arglist, end_arglist): Don't declare.
5368         * parse.c (arglist_len, funcall_chain): Remove global.
5369         (start_arglist, end_arglist): Remove functions.
5370         (parse_exp_in_context): Update.
5371         * p-exp.y: Update rules.
5372         * m2-exp.y: Update rules.
5373         * go-exp.y: Update rules.
5374         * f-exp.y: Update rules.
5375         * d-exp.y: Update rules.
5376         * c-exp.y: Update rules.
5377
5378 2019-04-04  Tom Tromey  <tom@tromey.com>
5379
5380         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5381         lex_operator, push_back>: New methods.
5382         Update all rules.
5383         (rust_parser::lex_hex, lex_escape): Rename and update.
5384         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5385         (rust_parser::lex_operator): Rename and update.
5386         (rust_parser::lex_number, rustyylex, rustyyerror)
5387         (rust_lex_test_init, rust_lex_test_sequence)
5388         (rust_lex_test_push_back, rust_lex_tests): Update.
5389         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5390         parameter.
5391         <lexptr, prev_lexptr>: New members.
5392         (lexptr, prev_lexptr): Don't declare.
5393         * parse.c (lexptr, prev_lexptr): Remove globals.
5394         (parse_exp_in_context): Update.
5395         * p-exp.y (yylex, yyerror): Update.
5396         * m2-exp.y (parse_number, yylex, yyerror): Update.
5397         * go-exp.y (lex_one_token, yyerror): Update.
5398         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5399         * d-exp.y (lex_one_token, yyerror): Update.
5400         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5401         (lex_one_token, yyerror): Update.
5402         * ada-lex.l (YY_INPUT): Update.
5403         (rewind_to_char): Update.
5404         * ada-exp.y (yyerror): Update.
5405
5406 2019-04-04  Tom Tromey  <tom@tromey.com>
5407
5408         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5409         * parser-defs.h (struct parser_state) <parser_state>: Add new
5410         parameter.
5411         <comma_terminates>: New member.
5412         (comma_terminates): Don't declare global.
5413         * parse.c (comma_terminates): Remove global.
5414         (parse_exp_in_context): Update.
5415         * p-exp.y (yylex): Update.
5416         * m2-exp.y (yylex): Update.
5417         * go-exp.y (lex_one_token): Update.
5418         * f-exp.y (yylex): Update.
5419         * d-exp.y (lex_one_token): Update.
5420         * c-exp.y (lex_one_token): Update.
5421         * ada-lex.l: Update.
5422
5423 2019-04-04  Tom Tromey  <tom@tromey.com>
5424
5425         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5426         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5427         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5428         * parser-defs.h (paren_depth): Don't declare.
5429         * parse.c (paren_depth): Remove global.
5430         (parse_exp_in_context): Update.
5431         * p-exp.y (paren_depth): New global.
5432         (pascal_parse): Initialize it.
5433         * m2-exp.y (paren_depth): New global.
5434         (m2_parse): Initialize it.
5435         * go-exp.y (paren_depth): New global.
5436         (go_parse): Initialize it.
5437         * f-exp.y (paren_depth): New global.
5438         (f_parse): Initialize it.
5439         * d-exp.y (paren_depth): New global.
5440         (d_parse): Initialize it.
5441         * c-exp.y (paren_depth): New global.
5442         (c_parse): Initialize it.
5443         * ada-lex.l (paren_depth): New global.
5444         (lexer_init): Initialize it.
5445
5446 2019-04-04  Tom Tromey  <tom@tromey.com>
5447
5448         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5449         (rust_parser::convert_ast_to_type)
5450         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5451         * parser-defs.h (struct parser_state) <parser_state>: Add
5452         parameters.  Initialize new members.
5453         <expression_context_block, expression_context_pc>: New members.
5454         * parse.c (expression_context_block, expression_context_pc):
5455         Remove globals.
5456         (parse_exp_in_context): Update.
5457         * p-exp.y: Update all rules.
5458         (yylex): Update.
5459         * m2-exp.y: Update all rules.
5460         (yylex): Update.
5461         * go-exp.y (yylex): Update.
5462         * f-exp.y (yylex): Update.
5463         * d-exp.y: Update all rules.
5464         (yylex): Update.
5465         * c-exp.y: Update all rules.
5466         (lex_one_token, classify_name, yylex, c_parse): Update.
5467         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5468
5469 2019-04-04  Tom Tromey  <tom@tromey.com>
5470
5471         * gdbarch.h, gdbarch.c: Rebuild.
5472         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5473         * stap-probe.h: 
5474         (struct stap_parse_info): Replace "parser_state" with
5475         "expr_builder".
5476         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5477         (parser_state): New class.
5478         * parse.c (expr_builder): Rename.
5479         (expr_builder::release): Rename.
5480         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5481         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5482         (write_exp_elt_longcst, write_exp_elt_floatcst)
5483         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5484         (write_exp_string_vector, write_exp_bitstring)
5485         (write_exp_msymbol, mark_struct_expression)
5486         (write_dollar_variable)
5487         (insert_type_address_space, increase_expout_size): Replace
5488         "parser_state" with "expr_builder".
5489         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5490         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5491         "parser_state" with "expr_builder".
5492
5493 2019-04-04  Tom Tromey  <tom@tromey.com>
5494
5495         * rust-exp.y: Replace "parse_language" with method call.
5496         * p-exp.y: 
5497         (yylex): Replace "parse_language" with method call.
5498         * m2-exp.y: 
5499         (yylex): Replace "parse_language" with method call.
5500         * go-exp.y (classify_name): Replace "parse_language" with method
5501         call.
5502         * f-exp.y (yylex): Replace "parse_language" with method call.
5503         * d-exp.y (lex_one_token): Replace "parse_language" with method
5504         call.
5505         * c-exp.y: 
5506         (lex_one_token, classify_name, yylex): Replace "parse_language"
5507         with method call.
5508         * ada-exp.y (find_primitive_type, type_char)
5509         (type_system_address): Replace "parse_language" with method call.
5510
5511 2019-04-04  Tom Tromey  <tom@tromey.com>
5512
5513         * rust-exp.y: Replace "parse_gdbarch" with method call.
5514         * parse.c (write_dollar_variable, insert_type_address_space):
5515         Replace "parse_gdbarch" with method call.
5516         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5517         call.
5518         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5519         call.
5520         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5521         "parse_gdbarch" with method call.
5522         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5523         with method call.
5524         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5525         "parse_gdbarch" with method call.
5526         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5527         "parse_gdbarch" with method call.
5528         * c-exp.y (parse_type, parse_number, classify_name): Replace
5529         "parse_gdbarch" with method call.
5530         * ada-lex.l: Replace "parse_gdbarch" with method call.
5531         * ada-exp.y (parse_type, find_primitive_type, type_char)
5532         (type_system_address): Replace "parse_gdbarch" with method call.
5533
5534 2019-04-04  Tom Tromey  <tom@tromey.com>
5535
5536         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5537         * stap-probe.c (stap_parse_argument): Update.
5538         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5539         initial_size parameter.
5540         * rust-exp.y (rust_lex_tests): Update.
5541         * parse.c (parser_state): Update.
5542         (parse_exp_in_context): Update.
5543         * parser-defs.h (struct parser_state) <parser_state>: Remove
5544         "initial_size" parameter.
5545
5546 2019-04-04  Tom Tromey  <tom@tromey.com>
5547
5548         * parser-defs.h (increase_expout_size): Don't declare.
5549         * parse.c (increase_expout_size): Now static.
5550
5551 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5552
5553         * gnu-nat.c (gnu_nat_target::wait): Fix
5554         target_waitstatus_to_string call.
5555
5556 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5557
5558         * eval.c (evaluate_subexp_standard): Handle internal functions
5559         during Fortran function call handling.
5560
5561 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5562
5563         * NEWS: Mention new internal functions.
5564         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5565         (read_base_type): Use dwarf2_init_complex_target_type.
5566         * value.c (creal_internal_fn): New function.
5567         (cimag_internal_fn): New function.
5568         (_initialize_values): Register new internal functions.
5569
5570 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5571
5572         * infrun.c (stop_all_threads): If debug_infrun, always
5573         trace the wait status after wait_one, using
5574         target_waitstatus_to_string and target_pid_to_str.
5575         (handle_inferior_event): Replace various trace of
5576         wait status kind by a single trace.
5577         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5578         wait status kind image by target_waitstatus_to_string.
5579         * target/waitstatus.c (target_waitstatus_to_string): Fix
5580         obsolete comment.
5581
5582 2019-04-01  Tom Tromey  <tromey@adacore.com>
5583
5584         PR symtab/23331:
5585         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5586
5587 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5588             Pedro Alves  <palves@redhat.com>
5589
5590         * top.c (quit_force): Call 'finalize_values'.
5591         * value.c (finalize_values): New function.
5592         * value.h (finalize_values): Declare.
5593
5594 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5595
5596         * NEWS: Announce $_gdb_major and $_gdb_minor.
5597
5598         * top.c (init_gdb_version_vars): New function.
5599         (gdb_init): Call init_gdb_version_vars.
5600
5601 2019-03-29  Tom Tromey  <tromey@adacore.com>
5602
5603         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5604         help text.  Remove dead code.
5605
5606 2019-03-29  Keith Seitz  <keiths@redhat.com>
5607
5608         From Siddhesh Poyarekar:
5609         * f-lang.h (f77_get_upperbound): Return LONGEST.
5610         (f77_get_lowerbound): Likewise.
5611         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5612         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5613         print them.
5614         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5615         plongest to format print it.
5616         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5617         (f77_get_upperbound): Likewise.
5618         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5619         LOWER_BOUND to LONGEST.
5620         (f77_create_arrayprint_offset_tbl): Likewise.
5621
5622 2019-03-29  Keith Seitz  <keiths@redhat.com>
5623
5624         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5625         %s/pulongest for TYPE_LENGTH instead of %d in format
5626         strings.
5627         * ada-typerint.c (ada_print_type): Likewise.
5628         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5629         * compile/compile-c-support.c (generate_register_struct): Likewise.
5630         * gdbtypes.c (recursive_dump_type): Likewise.
5631         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5632         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5633         instead of %d in format strings.
5634         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5635         to std::min to ULONGEST.
5636         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5637         instead of %d in format strings.
5638         * tracepoint.c (info_scope_command): Likewise.
5639         * typeprint.c (print_offset_data::update)
5640         (print_offset_data::finish): Likewise.
5641         * xtensa-tdep.c (xtensa_store_return_value)
5642         (xtensa_push_dummy_call): Likewise.
5643
5644 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5645
5646         * windows-nat.c (display_selector): Fixed format specifications
5647         for 64-bit Cygwin.
5648
5649 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5650
5651         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5652
5653 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5654
5655         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5656         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5657         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5658         (nios2_linux_init_abi): Install it.
5659
5660 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5661
5662         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5663
5664 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5665
5666         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5667
5668 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5669             Tom Tromey  <tromey@adacore.com>
5670
5671         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5672
5673 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5674
5675         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5676         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5677         method to compute the bounds of range types. Also print "[evaluated]"
5678         if the bounds' values come from a dynamic evaluation.
5679
5680 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5681
5682         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5683         whitespace when pretty printing is on.
5684
5685 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5686
5687         * ppc-linux-nat.c: Add include.
5688
5689 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5690
5691         * NEWS: Mention AArch64 Pointer Authentication.
5692
5693 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5694
5695         * arm-linux-nat.c: Add include.
5696
5697 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5698
5699         * source-cache.c (source_cache::get_source_lines): Re-read
5700         fullname after calling open_source_file.
5701
5702 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5703
5704         * NEWS: Mention TLS support for FreeBSD.
5705
5706 2019-03-25  Tom Tromey  <tromey@adacore.com>
5707
5708         * minsyms.c (BUNCH_SIZE): Update comment.
5709         (~minimal_symbol_reader): Remove old comment.
5710         (compact_minimal_symbols): Update comment.
5711         (minimal_symbol_reader::install): Remove old comment.  Update
5712         other comments.
5713
5714 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5715
5716         * s390-linux-nat.c: Add include.
5717
5718 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5719
5720         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5721         Call linux_get_hwcap.
5722         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5723         Likewise.
5724         (aarch64_linux_get_hwcap): Remove function.
5725         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5726         declaration.
5727         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5728         linux_get_hwcap.
5729         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5730         * linux-tdep.c (linux_get_hwcap): Add function.
5731         (linux_get_hwcap2): Likewise.
5732         * linux-tdep.h (linux_get_hwcap): Add declaration.
5733         (linux_get_hwcap2): Likewise.
5734         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5735         (ppc_linux_get_hwcap2): Likewise.
5736         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5737         linux_get_hwcap.
5738         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5739         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5740         (ppc_linux_nat_target::read_description): Likewise.
5741         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5742         * s390-linux-nat.c: Likewise.
5743         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5744
5745 2019-03-24  Tom Tromey  <tom@tromey.com>
5746
5747         * ada-lang.c (standard_lookup): Simplify initialization.
5748         (ada_lookup_symbol_nonlocal): Simplify return.
5749         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5750         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5751         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5752         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5753         initialization.
5754         * solib.c (solib_global_lookup): Simplify.
5755         * symtab.c (null_block_symbol): Remove.
5756         (symbol_cache_lookup): Simplify returns.
5757         (lookup_language_this): Simplify returns.
5758         (lookup_symbol_aux): Simplify return.
5759         (lookup_local_symbol): Simplify returns.
5760         (lookup_global_symbol_from_objfile): Simplify return.
5761         (lookup_symbol_in_objfile_symtabs)
5762         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5763         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5764         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5765         * cp-namespace.c (cp_lookup_bare_symbol)
5766         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5767         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5768         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5769         (cp_lookup_symbol_via_imports): Simplify initialization.
5770         (find_symbol_in_baseclass): Likewise.
5771         * symtab.h (null_block_symbol): Remove.
5772         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5773         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5774         (d_lookup_symbol_module): Likewise.
5775         (find_symbol_in_baseclass): Simplify initialization.
5776
5777 2019-03-24  Tom Tromey  <tom@tromey.com>
5778
5779         * expression.h: Don't include symtab.h.
5780         (struct block): Forward declare.
5781
5782 2019-03-24  Tom Tromey  <tom@tromey.com>
5783
5784         * c-exp.y (typebase): Remove casts.
5785         * gdbtypes.c (lookup_unsigned_typename, )
5786         (lookup_signed_typename): Remove cast.
5787         * eval.c (parse_to_comma_and_eval): Remove cast.
5788         * parse.c (write_dollar_variable): Remove cast.
5789         * block.h (struct block) <superblock>: Now const.
5790         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5791         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5792         (map_block): Make "block" const.
5793         * symfile.h (struct quick_symbol_functions)
5794         <map_matching_symbols>: Constify block argument to "callback".
5795         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5796         const.
5797         (find_pc_sect_compunit_symtab): Make "b" const.
5798         (find_symbol_at_address): Likewise.
5799         (search_symbols): Likewise.
5800         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5801         (dw2_debug_names_lookup_symbol): Likewise.
5802         (dw2_map_matching_symbols): Update.
5803         * p-valprint.c (pascal_val_print): Remove "block".
5804         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5805         (aux_add_nonlocal_symbols): Make "block" const.
5806         (resolve_subexp): Remove cast.
5807         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5808         const.
5809         (iterate_over_file_blocks): Likewise.
5810         * f-exp.y (%union) <bval>: Remove.
5811         * coffread.c (patch_opaque_types): Make "b" const.
5812         * spu-tdep.c (spu_catch_start): Make "block" const.
5813         * c-valprint.c (print_unpacked_pointer): Remove "block".
5814         * symmisc.c (dump_symtab_1): Make "b" const.
5815         (block_depth): Make "block" const.
5816         * d-exp.y (%union) <bval>: Remove.
5817         * cp-support.h (cp_lookup_rtti_type): Update.
5818         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5819         * psymtab.c (psym_lookup_symbol): Make "block" const.
5820         (maintenance_check_psymtabs): Make "b" const.
5821         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5822         (enumerate_locals, enumerate_args): Update.
5823         * python/py-symtab.c (stpy_global_block): Make "block" const.
5824         (stpy_static_block): Likewise.
5825         * inline-frame.c (block_starting_point_at): Make "new_block"
5826         const.
5827         * block.c (find_block_in_blockvector): Make return type const.
5828         (blockvector_for_pc_sect): Make "b" const.
5829         (find_block_in_blockvector): Make "b" const.
5830
5831 2019-03-23  Tom Tromey  <tom@tromey.com>
5832
5833         * varobj.c (varobj_create): Update.
5834         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5835         * printcmd.c (display_command, do_one_display): Don't reset
5836         innermost_block.
5837         * parser-defs.h (enum innermost_block_tracker_type): Move to
5838         expression.h.
5839         (innermost_block): Update comment.
5840         * parse.c (parse_exp_1): Add tracker_types parameter.
5841         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5842         tracker_types parameter.  Reset innermost_block.
5843         (parse_exp_in_context): Remove.
5844         (parse_expression_for_completion): Update.
5845         * objfiles.c (~objfile): Don't reset expression_context_block or
5846         innermost_block.
5847         * expression.h (enum innermost_block_tracker_type): Move from
5848         parser-defs.h.
5849         (parse_exp_1): Add tracker_types parameter.
5850         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5851         reset innermost_block.
5852
5853 2019-03-23  Tom Tromey  <tom@tromey.com>
5854
5855         * objfiles.h: Include bcache.h.
5856
5857 2019-03-23  Tom Tromey  <tom@tromey.com>
5858
5859         * linespec.c (get_current_search_block): Use
5860         scoped_restore_current_language.
5861         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5862
5863 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5864             Jiong Wang  <jiong.wang@arm.com>
5865
5866         * aarch64-linux-tdep.c
5867         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5868         section.
5869         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5870
5871 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5872             Jiong Wang  <jiong.wang@arm.com>
5873
5874         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5875         instructions.
5876         (aarch64_analyze_prologue_test): Add PACIASP test.
5877         (aarch64_prologue_prev_register): Unmask PC value.
5878
5879 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5880             Jiong Wang  <jiong.wang@arm.com>
5881
5882         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5883         (aarch64_dwarf2_prev_register): Unmask PC value.
5884         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5885         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5886         DW_CFA_AARCH64_negate_ra_state.
5887         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5888
5889 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5890             Jiong Wang  <jiong.wang@arm.com>
5891
5892         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5893         registers.
5894         (aarch64_pseudo_register_name): Likewise.
5895         (aarch64_pseudo_register_type): Likewise.
5896         (aarch64_pseudo_register_reggroup_p): Likewise.
5897         (aarch64_gdbarch_init): Add pauth registers.
5898         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5899         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5900         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5901         (struct gdbarch_tdep): Add regnum for ra_state.
5902
5903 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5904             Jiong Wang  <jiong.wang@arm.com>
5905
5906         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5907
5908 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5909             Jiong Wang  <jiong.wang@arm.com>
5910
5911         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5912         function.
5913         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5914         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5915         (aarch64_gdbarch_init): Add puth registers.
5916         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5917         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5918         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5919
5920 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5921             Jiong Wang  <jiong.wang@arm.com>
5922
5923         * aarch64-linux-nat.c
5924         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5925         * aarch64-linux-tdep.c
5926         (aarch64_linux_core_read_description): Likewise.
5927         (aarch64_linux_get_hwcap): New function.
5928         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5929         (aarch64_linux_get_hwcap): New declaration.
5930
5931 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5932             Jiong Wang  <jiong.wang@arm.com>
5933
5934         * aarch64-linux-nat.c
5935         (aarch64_linux_nat_target::read_description): Add pauth param.
5936         * aarch64-linux-tdep.c
5937         (aarch64_linux_core_read_description): Likewise.
5938         * aarch64-tdep.c (struct target_desc): Add in pauth.
5939         (aarch64_read_description): Add pauth param.
5940         (aarch64_gdbarch_init): Likewise.
5941         * aarch64-tdep.h (aarch64_read_description): Likewise.
5942         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5943         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5944         * features/Makefile: Add new files.
5945         * features/aarch64-pauth.c: New file.
5946         * features/aarch64-pauth.xml: New file.
5947
5948 2019-03-20  Tom Tromey  <tromey@adacore.com>
5949
5950         * infrun.c (handle_inferior_event): Rename from
5951         handle_inferior_event_1.  Create a scoped_value_mark.
5952         (handle_inferior_event): Remove.
5953
5954 2019-03-19  Tom Tromey  <tromey@adacore.com>
5955
5956         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5957         * infrun.h (print_stop_event): Add "displays" parameter.
5958         * infrun.c (print_stop_event): Add "displays" parameter.
5959
5960 2019-03-19  Pedro Alves  <palves@redhat.com>
5961
5962         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5963         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5964         to -1.  Fix TABs vs spaces.
5965         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5966         * tui/tui-out.h (tui_ui_out) Add intro comments.
5967         <m_line, m_start_of_line>: In-class initialize, and add describing
5968         comment.
5969
5970 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5971
5972         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5973         variable names.
5974         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5975
5976 2019-03-18  Pedro Alves  <palves@redhat.com>
5977             Eli Zaretskii <eliz@gnu.org>
5978
5979         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5980         m_line and m_start_of_line.
5981
5982 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5983
5984         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5985         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5986         it returns a newline.  This fixes a regression in TU mode, whereby
5987         the next line is output on the same screen line as the user input.
5988
5989 2019-03-18  Tom Tromey  <tromey@adacore.com>
5990
5991         * minsyms.c (minimal_symbol_reader::install): Remove call to
5992         obstack_blank.
5993
5994 2019-03-18  Pedro Alves  <palves@redhat.com>
5995
5996         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5997         New globals.
5998         (apply_style): New, factored out from ...
5999         (apply_ansi_escape): ... this.  Handle reverse video mode.
6000         (tui_set_reverse_mode): New function.
6001         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6002         * tui/tui-winsource.c (tui_show_source_line): Use
6003         tui_set_reverse_mode instead of setting A_STANDOUT.
6004         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6005         New setter methods.
6006
6007 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6008
6009         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6010         Handle tabs.
6011
6012 2019-03-18  Tom Tromey  <tromey@adacore.com>
6013
6014         * ada-lang.c (empty_array): Add "high" parameter.
6015         (ada_evaluate_subexp): Update.
6016
6017 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6018
6019         * unittests/string_view-selftests.c: Define
6020         _initialize_string_view_selftests unconditionally.
6021
6022 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6023
6024         PR gdb/24350
6025         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6026
6027 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6028
6029         PR gdb/24351
6030         * windows-nat.c (display_selector): Fix format specifiers.
6031
6032 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6033
6034         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6035         tui_refill_source_window instead of tui_refresh_win, to update the
6036         current execution line.  This fixes redisplay of the current line
6037         when stepping through the code with "next" or "step".
6038
6039 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6040
6041         * source-cache.c (source_cache::get_source_lines): Call
6042         find_source_lines to initialize s->nlines.  This fixes vertical
6043         scrolling of TUI source window when the DOWN arrow is pressed.
6044
6045 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6046
6047         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6048         linux-thread-db.c (_initialize_thread_db): Likewise.
6049
6050 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6051
6052         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6053         wclrtoeol in tui_show_source_line".  This reverts changes made in
6054         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6055
6056 2019-03-15  Tom Tromey  <tom@tromey.com>
6057
6058         * symtab.h (struct minimal_symbol): Derive from
6059         general_symbol_info.
6060         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6061         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6062         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6063         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6064         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6065         (MSYMBOL_SEARCH_NAME): Update.
6066         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6067         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6068         * minsyms.c (minimal_symbol_reader::record_full): Update.
6069
6070 2019-03-15  Tom Tromey  <tom@tromey.com>
6071
6072         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6073
6074 2019-03-15  Tom Tromey  <tom@tromey.com>
6075
6076         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6077         unique_xmalloc_ptr.
6078         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6079         Update.
6080         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6081         (build_minimal_symbol_hash_tables)
6082         (minimal_symbol_reader::install): Update.
6083
6084 2019-03-15  Tom Tromey  <tom@tromey.com>
6085
6086         * symtab.c (create_demangled_names_hash): Update.
6087         (symbol_set_names): Update.
6088         * objfiles.h (struct objfile_per_bfd_storage)
6089         <demangled_names_hash>: Now an htab_up.
6090         * objfiles.c (objfile_per_bfd_storage): Simplify.
6091
6092 2019-03-15  Tom Tromey  <tom@tromey.com>
6093
6094         * objfiles.h (struct objfile_per_bfd_storage): Declare
6095         destructor.
6096         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6097         New.
6098         (get_objfile_bfd_data): Use new.  Don't initialize
6099         language_of_main.
6100         (free_objfile_per_bfd_storage): Remove.
6101         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6102
6103 2019-03-15  Tom Tromey  <tom@tromey.com>
6104
6105         * symfile.c (reread_symbols): Update.
6106         * objfiles.c (objfile::objfile): Update.
6107         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6108         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6109         comment.
6110         (minimal_symbol_reader::install): Update.
6111         (terminate_minimal_symbol_table): Remove.
6112         * jit.c (jit_object_close_impl): Update.
6113
6114 2019-03-15  Tom Tromey  <tom@tromey.com>
6115
6116         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6117         initializations.
6118
6119 2019-03-15  Tom Tromey  <tom@tromey.com>
6120
6121         * objfiles.h (struct objfile_per_bfd_storage)
6122         <demangled_hash_languages>: Now a bitset.
6123         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6124         (lookup_minimal_symbol): Update.
6125
6126 2019-03-15  Tom Tromey  <tom@tromey.com>
6127
6128         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6129         Don't return the symbol.
6130         * coffread.c (record_minimal_symbol): Use record_full.
6131
6132 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6133
6134         The MS-Windows port of ncurses fails to switch to a color pair if
6135         one or both of the colors are the implicit default colors.  This
6136         change records the default colors when TUI is initialized, and
6137         then specifies them explicitly when a color pair uses the default
6138         colors.  This allows color styling in TUI mode on MS-Windows.
6139
6140         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6141         ncurses_norm_attr.
6142         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6143         colors in ncurses_norm_attr.
6144         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6145         "none", replace it with the default color recorded in
6146         ncurses_norm_attr.
6147
6148 2019-03-14  Tom Tromey  <tromey@adacore.com>
6149
6150         * source-cache.h (class source_cache) <get_source_lines>: Return
6151         std::string.
6152         * source-cache.c (source_cache::extract_lines): Handle case where
6153         first_pos==npos.  Return std::string.
6154         (source_cache::get_source_lines): Update.
6155
6156 2019-03-14  Tom Tromey  <tromey@adacore.com>
6157
6158         * NEWS: Add item for "style sources" commands.
6159         * source-cache.c (source_cache::get_source_lines): Check
6160         source_styling.
6161         * cli/cli-style.c (source_styling): New global.
6162         (_initialize_cli_style): Add "style sources" commands.
6163         (show_style_sources): New function.
6164         * cli/cli-style.h (source_styling): Declare.
6165
6166 2019-03-14  Pedro Alves  <palves@redhat.com>
6167             Tom Tromey  <tromey@adacore.com>
6168
6169         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6170         * tui/tui-winsource.c (tui_refill_source_window): New function,
6171         from...
6172         (tui_horizontal_source_scroll): ... here.  Move some logic.
6173         * cli/cli-style.c (set_style_enabled): Notify new observable.
6174         * tui/tui-hooks.c (tui_redisplay_source): New function.
6175         (tui_attach_detach_observers): Attach or detach
6176         tui_redisplay_source.
6177         * observable.h (source_styling_changed): New observable.
6178         * observable.c: Define source_styling_changed observable.
6179
6180 2019-03-13  Tom Tromey  <tromey@adacore.com>
6181
6182         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6183         (i386_gnu_nat_target::store_registers): Update.
6184         * target-debug.h (target_debug_print_std_string): New macro.
6185         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6186         * windows-tdep.c (display_one_tib): Update.
6187         * tui/tui-stack.c (tui_make_status_line): Update.
6188         * top.c (print_inferior_quit_action): Update.
6189         * thread.c (thr_try_catch_cmd): Update.
6190         (add_thread_with_info): Update.
6191         (thread_target_id_str): Update.
6192         (thr_try_catch_cmd): Update.
6193         (thread_command): Update.
6194         (thread_find_command): Update.
6195         * record-btrace.c (record_btrace_target::info_record)
6196         (record_btrace_resume_thread, record_btrace_target::resume)
6197         (record_btrace_cancel_resume, record_btrace_step_thread)
6198         (record_btrace_target::wait, record_btrace_target::wait)
6199         (record_btrace_target::wait, record_btrace_target::stop): Update.
6200         * progspace.c (print_program_space): Update.
6201         * process-stratum-target.c
6202         (process_stratum_target::thread_address_space): Update.
6203         * linux-fork.c (linux_fork_mourn_inferior)
6204         (detach_checkpoint_command, info_checkpoints_command)
6205         (linux_fork_context): Update.
6206         (linux_fork_detach): Update.
6207         (class scoped_switch_fork_info): Update.
6208         (delete_checkpoint_command): Update.
6209         * infrun.c (follow_fork_inferior): Update.
6210         (follow_fork_inferior): Update.
6211         (proceed_after_vfork_done): Update.
6212         (handle_vfork_child_exec_or_exit): Update.
6213         (follow_exec): Update.
6214         (displaced_step_prepare_throw): Update.
6215         (displaced_step_restore): Update.
6216         (start_step_over): Update.
6217         (resume_1): Update.
6218         (clear_proceed_status_thread): Update.
6219         (proceed): Update.
6220         (print_target_wait_results): Update.
6221         (do_target_wait): Update.
6222         (context_switch): Update.
6223         (stop_all_threads): Update.
6224         (restart_threads): Update.
6225         (finish_step_over): Update.
6226         (handle_signal_stop): Update.
6227         (switch_back_to_stepped_thread): Update.
6228         (keep_going_pass_signal): Update.
6229         (print_exited_reason): Update.
6230         (normal_stop): Update.
6231         * inferior.c (inferior_pid_to_str): Change return type.
6232         (print_selected_inferior): Update.
6233         (add_inferior): Update.
6234         (detach_inferior): Update.
6235         * dummy-frame.c (fprint_dummy_frames): Update.
6236         * dcache.c (dcache_info_1): Update.
6237         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6238         (btrace_fetch, btrace_clear): Update.
6239         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6240         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6241         type.
6242         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6243         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6244         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6245         * gdbarch.c, gdbarch.h: Rebuild.
6246         * gdbarch.sh (core_pid_to_str): Change return type.
6247         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6248         return type.
6249         (windows_nat_target::pid_to_str): Change return type.
6250         (windows_delete_thread): Update.
6251         (windows_nat_target::attach): Update.
6252         (windows_nat_target::files_info): Update.
6253         * target-delegates.c: Rebuild.
6254         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6255         return type.
6256         (sol_thread_target::pid_to_str): Change return type.
6257         * remote.c (class remote_target) <pid_to_str>: Change return
6258         type.
6259         (remote_target::pid_to_str): Change return type.
6260         (extended_remote_target::attach, remote_target::remote_stop_ns)
6261         (remote_target::remote_notif_remove_queued_reply)
6262         (remote_target::push_stop_reply, remote_target::disable_btrace):
6263         Update.
6264         (extended_remote_target::attach): Update.
6265         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6266         type.
6267         (gdbsim_target::pid_to_str): Change return type.
6268         * ravenscar-thread.c (struct ravenscar_thread_target)
6269         <pid_to_str>: Change return type.
6270         (ravenscar_thread_target::pid_to_str): Change return type.
6271         * procfs.c (class procfs_target) <pid_to_str>: Change return
6272         type.
6273         (procfs_target::pid_to_str): Change return type.
6274         (procfs_target::attach): Update.
6275         (procfs_target::detach): Update.
6276         (procfs_target::fetch_registers): Update.
6277         (procfs_target::store_registers): Update.
6278         (procfs_target::wait): Update.
6279         (procfs_target::files_info): Update.
6280         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6281         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6282         return type.
6283         (nto_procfs_target::pid_to_str): Change return type.
6284         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6285         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6286         return type.
6287         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6288         (exit_lwp): Update.
6289         (attach_proc_task_lwp_callback, get_detach_signal)
6290         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6291         (linux_nat_target::resume, wait_lwp, stop_callback)
6292         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6293         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6294         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6295         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6296         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6297         type.
6298         (inf_ptrace_target::attach): Update.
6299         (inf_ptrace_target::files_info): Update.
6300         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6301         type.
6302         (go32_nat_target::pid_to_str): Change return type.
6303         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6304         (gnu_nat_target::wait): Update.
6305         (gnu_nat_target::wait): Update.
6306         (gnu_nat_target::resume): Update.
6307         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6308         (fbsd_nat_target::wait): Update.
6309         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6310         type.
6311         (darwin_nat_target::attach): Update.
6312         * corelow.c (class core_target) <pid_to_str>: Change return type.
6313         (core_target::pid_to_str): Change return type.
6314         * target.c (normal_pid_to_str): Change return type.
6315         (default_pid_to_str): Likewise.
6316         (target_pid_to_str): Change return type.
6317         (target_translate_tls_address): Update.
6318         (target_announce_detach): Update.
6319         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6320         return type.
6321         (bsd_uthread_target::pid_to_str): Change return type.
6322         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6323         type.
6324         (bsd_kvm_target::pid_to_str): Change return type.
6325         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6326         return type.
6327         (aix_thread_target::pid_to_str): Change return type.
6328         * target.h (struct target_ops) <pid_to_str>: Change return type.
6329         (target_pid_to_str, normal_pid_to_str): Likewise.
6330         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6331         type.
6332         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6333         type.
6334         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6335         return type.
6336         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6337         type.
6338         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6339         type.
6340         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6341         return type.
6342
6343 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6344
6345         * NEWS: Mention that the new default MI version is 3.  Mention
6346         changes to the output of commands and events that deal with
6347         multi-location breakpoints.
6348         * breakpoint.c: Include "mi/mi-out.h".
6349         (print_one_breakpoint): Change output syntax if using MI version
6350         >= 3.
6351         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6352         New.
6353         (mi_multi_location_breakpoint_output_fixed): New.
6354         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6355         (mi_cmd_fix_multi_location_breakpoint_output): New.
6356         (mi_multi_location_breakpoint_output_fixed): New.
6357         * mi/mi-cmds.c (mi_cmds): Register command
6358         -fix-multi-location-breakpoint-output.
6359         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6360         interpreter "mi".
6361
6362 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6363
6364         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6365         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6366         instantiate mi_ui_out based on interpreter name.
6367         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6368         * mi/mi-main.c (mi_load_progress): Likewise.
6369
6370 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6371
6372         * NEWS: Combine separate "New targets" sections for 8.3.
6373
6374 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6375
6376         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6377         (ppcfbsd_init_abi): Install gdbarch
6378         "fetch_tls_load_module_address" and "get_thread_local_address"
6379         methods.
6380
6381 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6382
6383         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6384         (riscv_fbsd_init_abi): Install gdbarch
6385         "fetch_tls_load_module_address" and "get_thread_local_address"
6386         methods.
6387
6388 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6389
6390         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6391         (i386fbsd_init_abi): Install gdbarch
6392         "fetch_tls_load_module_address" and "get_thread_local_address"
6393         methods.
6394
6395 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6396
6397         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6398         (amd64fbsd_init_abi): Install gdbarch
6399         "fetch_tls_load_module_address" and "get_thread_local_address"
6400         methods.
6401
6402 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6403
6404         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6405         (struct fbsd_pspace_data): New type.
6406         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6407         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6408         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6409         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6410         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6411
6412 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6413
6414         * gdbtypes.c (lookup_struct_elt): New function.
6415         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6416         * gdbtypes.h (struct struct_elt): New type.
6417         (lookup_struct_elt): New prototype.
6418
6419 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6420
6421         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6422         remove disabled code block.
6423
6424 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6425
6426         * gdbarch.sh (get_thread_local_address): New method.
6427         * gdbarch.h, gdbarch.c: Regenerate.
6428         * target.c (target_translate_tls_address): Use
6429         gdbarch_get_thread_local_address if present instead of
6430         target::get_thread_local_address.
6431
6432 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6433
6434         * target.h (target::get_thread_local_address): Update comment.
6435
6436 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6437
6438         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6439         objfile->separate_debug_objfile_backlink if not NULL.
6440
6441 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6442
6443         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6444         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6445         (amd64bsd_store_inferior_registers): Likewise.
6446         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6447         Enable segment base registers.
6448         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6449         PT_GETFSBASE and PT_GETGSBASE.
6450         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6451         PT_SETGSBASE.
6452         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6453         segment base registers.
6454         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6455
6456 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6457
6458         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6459         Update calls to i386_target_description to add 'segments'
6460         parameter.
6461         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6462         add segment base registers.
6463         * arch/i386.c (i386_create_target_description): Add 'segments'
6464         parameter to enable segment base registers.
6465         * arch/i386.h (i386_create_target_description): Likewise.
6466         * features/i386/32bit-segments.xml: New file.
6467         * features/i386/32bit-segments.c: Generate.
6468         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6469         call to i386_target_description to add 'segments' parameter.
6470         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6471         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6472         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6473         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6474         if feature is present.
6475         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6476         Add 'segments' parameter to call to i386_target_description.
6477         (i386_target_description): Add 'segments' parameter to enable
6478         segment base registers.
6479         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6480         to call to i386_target_description.
6481         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6482         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6483         Define I386_NUM_REGS.
6484         (i386_target_description): Add 'segments' parameter to enable
6485         segment base registers.
6486
6487 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6488
6489         PR/24325
6490         * source-cache.c: #undef open and close, to avoid unresolved
6491         externals during linking.
6492
6493 2019-03-12  Tom Tromey  <tromey@adacore.com>
6494
6495         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6496         const.  Add initializers.
6497         (_initialize_remote): Don't initialize ptid globals.
6498
6499 2019-03-12  Pedro Alves  <palves@redhat.com>
6500
6501         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6502
6503 2019-03-12  Pedro Alves  <palves@redhat.com>
6504
6505         * cp-name-parser.y (main): Remove unused 'len' variable.
6506
6507 2019-03-12  Tom Tromey  <tromey@adacore.com>
6508
6509         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6510         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6511
6512 2019-03-12  Tom Tromey  <tromey@adacore.com>
6513
6514         * linux-nat.c (iterate_over_lwps): Update.
6515         (stop_callback): Remove parameter.
6516         (stop_wait_callback, detach_callback, resume_set_callback)
6517         (select_singlestep_lwp_callback, set_ignore_sigint)
6518         (status_callback, resumed_callback, resume_clear_callback)
6519         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6520         data parameter.
6521         (linux_nat_target::detach, linux_nat_target::resume)
6522         (linux_stop_and_wait_all_lwps, select_event_lwp)
6523         (linux_nat_filter_event, linux_nat_wait_1)
6524         (linux_nat_target::kill, linux_nat_target::stop)
6525         (linux_nat_target::stop): Update.
6526         (linux_nat_resume_callback): Change type.
6527         (resume_stopped_resumed_lwps, count_events_callback)
6528         (select_event_lwp_callback): Likewise.
6529         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6530         * arm-linux-nat.c (struct update_registers_data): Remove.
6531         (update_registers_callback): Change type.
6532         (arm_linux_insert_hw_breakpoint1): Update.
6533         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6534         parameter.
6535         (x86_linux_dr_set_addr): Update.
6536         (x86_linux_dr_set_control): Update.
6537         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6538         (iterate_over_lwps): Use gdb::function_view.
6539         * nat/aarch64-linux-hw-point.c (struct
6540         aarch64_dr_update_callback_param): Remove.
6541         (debug_reg_change_callback): Change type.
6542         (aarch64_notify_debug_reg_change): Update.
6543         * s390-linux-nat.c (s390_refresh_per_info): Update.
6544
6545 2019-03-11  Tom Tromey  <tromey@adacore.com>
6546
6547         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6548         redundant assignment to "this_cu".
6549
6550 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6551
6552         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6553
6554 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6555
6556         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6557         from...
6558         (rank_one_type): ... this.
6559
6560 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6561
6562         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6563         from...
6564         (rank_one_type): ... this.
6565
6566 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6567
6568         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6569         from...
6570         (rank_one_type): ... this.
6571
6572 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6573
6574         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6575         from...
6576         (rank_one_type): ... this.
6577
6578 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6579
6580         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6581         from...
6582         (rank_one_type): ... this.
6583
6584 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6585
6586         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6587         from...
6588         (rank_one_type): ... this.
6589
6590 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6591
6592         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6593         from...
6594         (rank_one_type): ... this.
6595
6596 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6597
6598         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6599         from...
6600         (rank_one_type): ... this.
6601
6602 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6603
6604         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6605         from...
6606         (rank_one_type): ... this.
6607
6608 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6609
6610         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6611         from...
6612         (rank_one_type): ... this.
6613
6614 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6615
6616         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6617         from...
6618         (rank_one_type): ... this.
6619
6620 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6621
6622         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6623         from...
6624         (rank_one_type): ... this.
6625
6626 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6627
6628         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6629         inferior-events' shows the example events.
6630
6631 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6632
6633         Support styling on native MS-Windows console
6634
6635         PR/24315
6636         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6637         on MS-Windows if $TERM is not defined.
6638
6639         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6640
6641         * posix-hdep.c (gdb_console_fputs):
6642         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6643         functions.
6644         * ui-file.h (gdb_console_fputs): Add prototype.
6645
6646         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6647         back to fputs only if the former returns zero.
6648
6649 2019-03-07  Tom Tromey  <tom@tromey.com>
6650
6651         * symmisc.c (print_symbol_bcache_statistics): Update.
6652         (print_objfile_statistics): Update.
6653         * symfile.c (allocate_symtab): Update.
6654         * stabsread.c: Don't include bcache.h.
6655         * psymtab.h (struct psymbol_bcache): Don't declare.
6656         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6657         (psymbol_bcache_init, psymbol_bcache_free)
6658         (psymbol_bcache_get_bcache): Don't declare.
6659         * psymtab.c (struct psymbol_bcache): Remove.
6660         (psymtab_storage::psymtab_storage): Update.
6661         (psymtab_storage::~psymtab_storage): Update.
6662         (psymbol_bcache_init, psymbol_bcache_free)
6663         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6664         (add_psymbol_to_bcache): Update.
6665         (allocate_psymtab): Update.
6666         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6667         macro_cache>: No longer pointers.
6668         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6669         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6670         * macrotab.c (macro_bcache): Update.
6671         * macroexp.c: Don't include bcache.h.
6672         * gdbtypes.c (check_types_worklist): Update.
6673         (types_deeply_equal): Remove TRY/CATCH.  Update.
6674         * elfread.c (elf_symtab_read): Update.
6675         * dwarf2read.c: Don't include bcache.h.
6676         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6677         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6678         (print_bcache_statistics, bcache_memory_used): Don't declare.
6679         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6680         methods.  Rename all data members.
6681         * bcache.c (struct bcache): Move to bcache.h.
6682         (bcache::expand_hash_table): Rename from expand_hash_table.
6683         (bcache): Remove.
6684         (bcache::insert): Rename from bcache_full.
6685         (bcache::compare): Rename from bcache_compare.
6686         (bcache_xmalloc): Remove.
6687         (bcache::~bcache): Rename from bcache_xfree.
6688         (bcache::print_statistics): Rename from print_bcache_statistics.
6689         (bcache::memory_used): Rename from bcache_memory_used.
6690
6691 2019-03-07  Pedro Alves  <palves@redhat.com>
6692
6693         * infrun.c (normal_stop): Also check for
6694         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6695
6696 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6697
6698         * f-lang.c (value_from_host_double): Moved to...
6699         * value.c (value_from_host_double): ...here.
6700         * value.h (value_from_host_double): Declare.
6701         * guile/scm-math.c (vlscm_convert_typed_number): Use
6702         value_from_host_double.
6703         (vlscm_convert_number): Likewise.
6704         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6705         * python/py-value.c (convert_value_from_python): Likewise.
6706
6707 2019-03-06  Tom Tromey  <tom@tromey.com>
6708
6709         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6710
6711 2019-03-06  Tom Tromey  <tom@tromey.com>
6712
6713         * utils.h (free_current_contents): Don't declare.
6714         * utils.c (free_current_contents): Remove.
6715
6716 2019-03-06  Tom Tromey  <tom@tromey.com>
6717
6718         * top.c (quit_force): Update.
6719         * main.c (captured_command_loop): Update.
6720         * common/new-op.c (operator new): Update.
6721         * common/common-exceptions.c (struct catcher)
6722         <save_cleanup_chain>: Remove member.
6723         (exceptions_state_mc_init): Update.
6724         (exception_try_scope_entry): Return nullptr.
6725         (exception_try_scope_exit, exception_rethrow)
6726         (throw_exception_sjlj, throw_exception_cxx): Update.
6727         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6728         (all_cleanups, do_cleanups, discard_cleanups)
6729         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6730         (restore_cleanups, restore_final_cleanups): Don't declare.
6731         (do_final_cleanups): Remove parameter.
6732         * common/cleanups.c (cleanup_chain, make_cleanup)
6733         (make_cleanup_dtor, all_cleanups, do_cleanups)
6734         (discard_my_cleanups, discard_cleanups)
6735         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6736         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6737         (null_cleanup): Remove.
6738         (do_final_cleanups): Remove parameter.
6739
6740 2019-03-06  Tom Tromey  <tom@tromey.com>
6741
6742         * remote.c (remote_target::remote_parse_stop_reply): Use
6743         unique_xmalloc_ptr.
6744
6745 2019-03-06  Tom Tromey  <tom@tromey.com>
6746
6747         * stabsread.c (struct stabs_field_info): Rename from field_info.
6748         <list, fnlist>: Add initializers.
6749         <obstack>: New member.
6750         (read_member_functions, read_struct_fields, read_baseclasses):
6751         Allocate on obstack.  Don't use cleanups.
6752         (read_one_struct_field, read_member_functions, read_struct_fields)
6753         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6754         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6755         (read_struct_type): Update.
6756
6757 2019-03-06  Tom Tromey  <tom@tromey.com>
6758
6759         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6760         * common/filestuff.h (make_cleanup_close): Don't declare.
6761         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6762         Remove.
6763
6764 2019-03-06  Tom Tromey  <tom@tromey.com>
6765
6766         * solib-aix.c: Use make_scope_exit.
6767
6768 2019-03-06  Tom Tromey  <tom@tromey.com>
6769
6770         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6771         Use make_scope_exit.
6772
6773 2019-03-06  Tom Tromey  <tom@tromey.com>
6774
6775         * solib-svr4.c (disable_probes_interface): Remove parameter.
6776         (svr4_handle_solib_event): Use make_scope_exit.
6777
6778 2019-03-06  Tom Tromey  <tom@tromey.com>
6779
6780         * remote.c (struct stop_reply_deleter): Remove.
6781         (stop_reply_up): Update.
6782         (struct stop_reply): Derive from notif_event.  Don't typedef.
6783         <regcache>: Now a std::vector.
6784         (stop_reply_xfree): Remove.
6785         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6786         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6787         (remote_target::discard_pending_stop_replies): Use delete.
6788         (remote_target::remote_parse_stop_reply): Update.
6789         (remote_target::process_stop_reply): Update.
6790         * remote-notif.h (struct notif_event): Add virtual destructor.
6791         Remove "dtr" member.
6792         (struct notif_client) <alloc_event>: Return a unique_ptr.
6793         (notif_event_xfree): Don't declare.
6794         (notif_event_up): New typedef.
6795         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6796         (notif_event_xfree, do_notif_event_xfree): Remove.
6797         (remote_notif_state_xfree): Update.
6798
6799 2019-03-06  Tom Tromey  <tom@tromey.com>
6800
6801         * infrun.c (displaced_step_clear_cleanup): Now a
6802         forward_scope_exit type.
6803         (displaced_step_prepare_throw): Update.
6804         (displaced_step_fixup): Update.
6805
6806 2019-03-06  Tom Tromey  <tom@tromey.com>
6807
6808         * inferior.h (class inferior): Update comment.
6809         * gdbthread.h (class thread_info): Update comment.
6810
6811 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6812             Tom Tromey  <tom@tromey.com>
6813
6814         * stabsread.h (struct stab_section_list): Remove.
6815         (coffstab_build_psymtabs): Update.
6816         * dbxread.c (symbuf_sections): Now a std::vector.
6817         (sect_idx): New global.
6818         (fill_symbuf): Update.
6819         (coffstab_build_psymtabs): Change type of stabsects parameter.
6820         Update.
6821         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6822         std::vector.
6823         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6824         (coff_locate_sections): Update.
6825         (coff_symfile_read): Remove cleanups.  Update.
6826         (init_stringtab): Add storage parameter.
6827         (free_stringtab, free_stringtab_cleanup): Remove.
6828         (init_lineno): Add storage parameter.
6829         (free_linetab, free_linetab_cleanup): Remove.
6830
6831 2019-03-06  Pedro Alves  <palves@redhat.com>
6832
6833         * linux-fork.c (fork_info::clobber_regs): Delete.
6834         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6835         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6836         comment.  Adjust.
6837         (scoped_switch_fork_info::scoped_switch_fork_info)
6838         (checkpoint_command, linux_fork_context): Adjust
6839         fork_save_infrun_state calls.
6840
6841 2019-03-06  Pedro Alves  <palves@redhat.com>
6842
6843         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6844         (inf_has_multiple_threads): Return 'bool' and rewrite using
6845         inferior_info::threads().
6846
6847 2019-03-06  Pedro Alves  <palves@redhat.com>
6848
6849         * linux-fork.c: Include <list>.
6850         (fork_list): Now a std::list instance.
6851         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6852         (forks_exist_p, find_last_fork): Adjust.
6853         (new_fork): Delete.
6854         (one_fork_p): New.
6855         (add_fork): Adjust.
6856         (free_fork): Delete, folded into fork_info::~fork_info().
6857         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6858         Adjust.
6859         (init_fork_list): Delete.
6860         (linux_fork_killall, linux_fork_mourn_inferior)
6861         (linux_fork_detach, info_checkpoints_command): Adjust.
6862         (_initialize_linux_fork): No longer call init_fork_list.
6863
6864 2019-03-06  Pedro Alves  <palves@redhat.com>
6865
6866         * linux-fork.c (new_fork): New, split out of ...
6867         (add_fork): ... this.  Return void.  Move "first fork" special
6868         case from here, to ...
6869         (checkpoint_command): ... here.
6870         * linux-linux.h (add_fork): Return void.
6871
6872 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6873
6874         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6875
6876 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6877             Chris January  <chris.january@arm.com>
6878             David Lecomber  <david.lecomber@arm.com>
6879
6880         * f-exp.y: New token, UNOP_INTRINSIC.
6881         (exp): New pattern using UNOP_INTRINSIC token.
6882         (f77_keywords): Add 'abs' keyword.
6883         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6884         (value_from_host_double): New function.
6885         (evaluate_subexp_f): Support UNOP_ABS.
6886
6887 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6888
6889         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6890         types.
6891
6892 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6893
6894         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6895         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6896         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6897
6898 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6899
6900         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6901
6902 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6903             Chris January  <chris.january@arm.com>
6904
6905         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6906         * f-exp.y: Define 'KIND' token.
6907         (exp): New pattern for KIND expressions.
6908         (ptype): Handle types with a kind extension.
6909         (direct_abs_decl): Extend to spot kind extensions.
6910         (f77_keywords): Add 'kind' to the list.
6911         (push_kind_type): New function.
6912         (convert_to_kind_type): New function.
6913         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6914         * parse.c (operator_length_standard): Likewise.
6915         * parser-defs.h (enum type_pieces): Add tp_kind.
6916         * std-operator.def: Add UNOP_KIND.
6917
6918 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6919
6920         * f-exp.y (f_parse): Set yydebug.
6921
6922 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6923
6924         * f-lang.c (evaluate_subexp_f): New function.
6925         (exp_descriptor_f): New global.
6926         (f_language_defn): Use exp_descriptor_f instead of
6927         exp_descriptor_standard.
6928
6929 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6930
6931         * f-exp.y (struct token): Add comments.
6932         (dot_ops): Remove uppercase versions and the end marker.
6933         (f77_keywords): Likewise.
6934         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6935         entries in the dot_ops array are case insensitive, and use
6936         strncasecmp to compare strings.  Also some whitespace cleanup in
6937         this area.  Similar for the f77_keywords array, except entries in
6938         this list might be case sensitive.
6939
6940 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6941
6942         * f-exp.y (struct f77_boolean_val): Add comments.
6943         (boolean_values): Remove uppercase versions, and end marker.
6944         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6945         and use strncasecmp to achieve case insensitivity.  Additionally,
6946         perform whitespace cleanup around this code.
6947
6948 2019-03-06  Tom Tromey  <tromey@adacore.com>
6949
6950         * remote-sim.c (gdbsim_target_open): Use result of
6951         gdb_argv::release.
6952
6953 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6954         Dirk Schubert  <dirk.schubert@arm.com>
6955         Chris January  <chris.january@arm.com>
6956
6957         * eval.c (evaluate_subexp_standard): Call Fortran argument
6958         wrapping logic.
6959         * f-lang.c (struct value): A value which can be passed into a
6960         Fortran function call.
6961         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6962         where appropriate.
6963         (struct type): Value ready for a Fortran function call.
6964         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6965         is needed.
6966         * f-lang.h (fortran_argument_convert): Declaration.
6967         (fortran_preserve_arg_pointer): Declaration.
6968         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6969
6970 2019-03-05  Tom Tromey  <tromey@adacore.com>
6971
6972         * python/py-prettyprint.c (print_string_repr): Remove #if.
6973         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6974
6975 2019-03-05  Tom Tromey  <tromey@adacore.com>
6976
6977         * target.c (the_dummy_target): Move later.  Change type to
6978         "dummy_target".
6979         (initialize_targets): Don't initialize the_dummy_target.
6980
6981 2019-03-05  Tom Tromey  <tromey@adacore.com>
6982
6983         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6984         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6985
6986 2019-03-05  Tom Tromey  <tromey@adacore.com>
6987
6988         * windows-nat.c (windows_nat_target::attach)
6989         (windows_nat_target::detach): Don't call gdb_flush.
6990         * valprint.c (generic_val_print, val_print, val_print_string):
6991         Don't call gdb_flush.
6992         * utils.c (defaulted_query): Don't call gdb_flush.
6993         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6994         * target.c (target_announce_detach): Don't call gdb_flush.
6995         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6996         * remote.c (extended_remote_target::attach): Don't call
6997         gdb_flush.
6998         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6999         * printcmd.c (do_examine): Don't call gdb_flush.
7000         (info_display_command): Don't call gdb_flush.
7001         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7002         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7003         * memattr.c (info_mem_command): Don't call gdb_flush.
7004         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7005         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7006         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7007         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7008         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7009         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7010         (gnu_nat_target::detach): Don't call gdb_flush.
7011         * f-valprint.c (f_val_print): Don't call gdb_flush.
7012         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7013         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7014         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7015         gdb_flush.
7016         * c-valprint.c (c_val_print): Don't call gdb_flush.
7017         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7018
7019 2019-03-05  Tom Tromey  <tromey@adacore.com>
7020
7021         * varobj.c (update_dynamic_varobj_children): Update.
7022         (install_default_visualizer): Use reset, not release.
7023         * value.c (set_internalvar): Update.
7024         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7025         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7026         ATTRIBUTE_UNUSED_RESULT.
7027
7028 2019-03-05  Tom Tromey  <tromey@adacore.com>
7029
7030         * remote.c (class scoped_remote_fd) <release>: Add
7031         ATTRIBUTE_UNUSED_RESULT.
7032
7033 2019-03-05  Tom Tromey  <tromey@adacore.com>
7034
7035         * macroexp.c (struct macro_buffer) <release>: Add
7036         ATTRIBUTE_UNUSED_RESULT.
7037
7038 2019-03-05  Tom Tromey  <tromey@adacore.com>
7039
7040         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7041         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7042         ATTRIBUTE_UNUSED_RESULT.
7043
7044 2019-03-05  Tom Tromey  <tromey@adacore.com>
7045
7046         * common/scoped_fd.h (class scoped_fd) <release>: Add
7047         ATTRIBUTE_UNUSED_RESULT.
7048
7049 2019-03-05  Tom Tromey  <tromey@adacore.com>
7050
7051         * parser-defs.h (struct parser_state) <release>: Add
7052         ATTRIBUTE_UNUSED_RESULT.
7053
7054 2019-03-05  Tom Tromey  <tromey@adacore.com>
7055
7056         * utils.h (class gdb_argv) <release>: Add
7057         ATTRIBUTE_UNUSED_RESULT.
7058         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7059
7060 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7061
7062         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7063         for-loop range, to avoid compiler warnings.
7064
7065         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7066         avoid compiler warnings about unused variables.
7067
7068         * NEWS: Mention end of support for native debugging on MS-Windows
7069         before XP.
7070
7071         PR gdb/24292
7072         * common/netstuff.c:
7073         * gdbserver/gdbreplay.c
7074         * gdbserver/remote-utils.c:
7075         * ser-tcp.c:
7076         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7077         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7078         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7079         'getaddrinfo' and 'freeaddrinfo' were not available before
7080         Windows XP, and mingw.org's MinGW headers by default define
7081         _WIN32_WINNT to 0x500.
7082
7083 2019-03-01  Gary Benson <gbenson@redhat.com>
7084
7085         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7086
7087 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7088             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7089
7090         PR gdb/8527
7091         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7092         set_sigint_trap, clear_sigint_trap.
7093
7094 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7095
7096         * target.c (target_detach): Clear the regcache and the
7097         frame cache.
7098
7099 2019-02-27  Pedro Alves  <palves@redhat.com>
7100
7101         * utils.c (set_screen_size): When we cap the height/width sizes,
7102         tweak the corresponding command variable to show "unlimited":
7103
7104 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7105             Pedro Alves  <palves@redhat.com>
7106
7107         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7108         before calling rl_set_screen_size.
7109
7110 2019-02-27  Tom Tromey  <tromey@adacore.com>
7111
7112         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7113         define.
7114         * python/py-value.c: Remove Python 2.4 workaround.
7115         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7116         workaround.
7117         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7118         Python 2.4 workaround.
7119         * python/python-internal.h: Remove Python 2.4 comment.
7120         (Py_ssize_t): Don't define.
7121         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7122         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7123         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7124         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7125         * python/python.c (do_start_initialization): Remove Python 2.4
7126         workaround.
7127         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7128         (print_children): Remove Python 2.4 workaround.
7129         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7130         workaround.
7131         (CHARBUFFERPROC_NAME): Remove.
7132         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7133         Python 2.4 workaround.
7134
7135 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7136
7137         * NEWS: Note minimum Python version.
7138
7139 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7140
7141         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7142         code from these functions.  Remove corresponding ifdefs.  Use
7143         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7144         Remove gotos and target of gotos.
7145         (infpy_search_memory): Likewise.
7146
7147 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7148
7149         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7150         (hppa_gdbarch_init): Don't register deleted functions with
7151         gdbarch.
7152
7153 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7154
7155         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7156         (h8300_unwind_sp): Delete.
7157         (h8300_dummy_id): Delete.
7158         (h8300_gdbarch_init): Don't register deleted functions with
7159         gdbarch.
7160
7161 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7162
7163         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7164         (ft32_unwind_pc): Delete.
7165         (ft32_unwind_sp): Delete.
7166         (ft32_gdbarch_init): Don't register deleted functions with
7167         gdbarch.
7168
7169 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7170
7171         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7172         (frv_unwind_pc): Delete.
7173         (frv_unwind_sp): Delete.
7174         (frv_gdbarch_init): Don't register deleted functions with
7175         gdbarch.
7176
7177 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7178
7179         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7180         (riscv_unwind_pc): Delete.
7181         (riscv_unwind_sp): Delete.
7182         (riscv_gdbarch_init): Don't register deleted functions with
7183         gdbarch.
7184
7185 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7186
7187         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7188         (csky_unwind_pc): Delete.
7189         (csky_unwind_sp): Delete.
7190         (csky_gdbarch_init): Don't register deleted functions with
7191         gdbarch.
7192
7193 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7194
7195         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7196         (cris_unwind_pc): Delete.
7197         (cris_unwind_sp): Delete.
7198         (cris_gdbarch_init): Don't register deleted functions with
7199         gdbarch.
7200
7201 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7202
7203         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7204         (bfin_unwind_pc): Delete.
7205         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7206
7207 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7208
7209         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7210         (arm_unwind_pc): Delete.
7211         (arm_unwind_sp): Delete.
7212         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7213
7214 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7215
7216         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7217         (arc_unwind_pc): Delete.
7218         (arc_unwind_sp): Delete.
7219         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7220
7221 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7222
7223         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7224         (alpha_unwind_pc): Delete.
7225         (alpha_gdbarch_init): Don't register deleted functions with
7226         gdbarch.
7227
7228 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7229
7230         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7231         (aarch64_unwind_pc): Delete.
7232         (aarch64_unwind_sp): Delete.
7233         (aarch64_gdbarch_init): Don't register deleted functions with
7234         gdbarch.
7235
7236 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7237
7238         * gdbtypes.c (type_align): Don't consider static members when
7239         computing structure alignment.
7240
7241 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7242
7243         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7244         return 0 for other types.
7245         * arch-utils.c (default_type_align): Always return 0.
7246         * gdbarch.h: Regenerate.
7247         * gdbarch.sh (type_align): Extend comment.
7248         * gdbtypes.c (type_align): Add additional comments, always call
7249         gdbarch_type_align before applying the default rules.
7250         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7251         generic code will then apply a suitable default.
7252         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7253         types, return 0 for other types.
7254
7255 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7256
7257         * NEWS: Create a new section for the next release branch.
7258         Rename the section of the current branch, now that it has
7259         been cut.
7260
7261 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7262
7263         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7264         * version.in: Bump version to 8.3.50.DATE-git.
7265
7266 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7267
7268         * aix-thread.c (ptid_cmp): Remove unused variable.
7269         (get_signaled_thread): Likewise.
7270         (store_regs_user_thread): Likewise.
7271         (store_regs_kernel_thread): Likewise.
7272         (fetch_regs_kernel_thread): Remove shadowed variable.
7273
7274 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7275
7276         * features/riscv/32bit-cpu.xml: Add register numbers.
7277         * features/riscv/32bit-fpu.c: Regenerate.
7278         * features/riscv/32bit-fpu.xml: Add register numbers.
7279         * features/riscv/64bit-cpu.xml: Add register numbers.
7280         * features/riscv/64bit-fpu.c: Regenerate.
7281         * features/riscv/64bit-fpu.xml: Add register numbers.
7282
7283 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7284
7285         * NEWS: Mention two argument form of gdb.Value constructor.
7286         * python/py-value.c (convert_buffer_and_type_to_value): New
7287         function.
7288         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7289         Add support for handling an optional second argument.  Call
7290         convert_buffer_and_type_to_value as appropriate.
7291         * python/python-internal.h (Py_buffer_deleter): New struct.
7292         (Py_buffer_up): New typedef.
7293
7294 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7295
7296         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7297         instead of releasing ownership.
7298
7299 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7300
7301         * dwarf2read.c (open_and_init_dwp_file): Call
7302         elf_numsections instead of bfd_count_sections to initialize
7303         dwp_file->num_sections.
7304
7305 2019-02-25  Tom Tromey  <tromey@adacore.com>
7306
7307         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7308
7309 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7310
7311         * gcore.in: Add '--readnever' option when invoking GDB.
7312
7313 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7314
7315         * MAINTAINERS: Update my email address.
7316
7317 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7318
7319         * build-id.c (build_id_to_debug_bfd_1): New function.
7320         (build_id_to_debug_bfd): Look for separate debug file in
7321         sysroot.
7322
7323 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7324
7325         * gdbarch.sh: Update the copyright year range that is placed into
7326         generated files.
7327
7328 2019-02-22  Keith Seitz  <keiths@redhat.com>
7329
7330         PR symtab/23853
7331         * linespec.c (create_sals_line_offset): Search for the default
7332         symtab's filename instead of its fullname.
7333
7334 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7335
7336         * NEWS: Update style defaults.
7337
7338 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7339
7340         * main.c (captured_main_1): Disable styling in batch mode.
7341
7342 2019-02-20  Tom Tromey  <tom@tromey.com>
7343
7344         * symtab.c (symtab_symbol_info): Fix typos.
7345
7346 2019-02-20  Tom Tromey  <tromey@adacore.com>
7347
7348         * findcmd.c (_initialize_mem_search): Use upper case for
7349         metasyntactic variables.
7350
7351 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7352
7353         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7354         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7355
7356 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7357
7358         * top.h (source_file_name): Change to std::string.
7359         * top.c (source_file_name): Likewise.
7360         (command_line_input): Adjust.
7361         * cli/cli-script.c (script_from_file): Adjust.
7362
7363 2019-02-19  Tom Tromey  <tromey@adacore.com>
7364
7365         * ravenscar-thread.c
7366         (ravenscar_thread_target::update_thread_list): Don't call
7367         ada_build_task_list.
7368         * ada-lang.h (ada_build_task_list): Don't declare.
7369         * ada-tasks.c (struct ada_tasks_inferior_data)
7370         <task_list_valid_p>: Now bool.
7371         (read_known_tasks, ada_task_list_changed)
7372         (ada_tasks_invalidate_inferior_data): Update.
7373         (read_known_tasks_array): Return bool.
7374         (read_known_tasks_list): Likewise.
7375         (read_known_tasks): Return void.
7376         (ada_build_task_list): Now static.
7377
7378 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7379
7380         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7381         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7382
7383 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7384
7385         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7386         variant for ada_tasks_pspace_data_handle and
7387         ada_tasks_inferior_data_handle.
7388         (ada_tasks_pspace_data_cleanup): New function.
7389         (ada_tasks_inferior_data_cleanup): New function.
7390
7391 2019-02-17  Tom Tromey  <tom@tromey.com>
7392
7393         * macrotab.h (macro_source_fullname): Return a std::string.
7394         * macrotab.c (macro_include, check_for_redefinition)
7395         (macro_undef, macro_lookup_definition, foreach_macro)
7396         (foreach_macro_in_scope): Update.
7397         (macro_source_fullname): Return a std::string.
7398         * macrocmd.c (show_pp_source_pos): Update.
7399
7400 2019-02-17  Tom Tromey  <tom@tromey.com>
7401
7402         * macrocmd.c (show_pp_source_pos): Style the file names.
7403
7404 2019-02-17  Tom Tromey  <tom@tromey.com>
7405
7406         PR tui/24197:
7407         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7408
7409 2019-02-17  Tom Tromey  <tom@tromey.com>
7410
7411         * ada-lang.c (user_select_syms): Use filtered printing.
7412         * utils.c (wrap_style): New global.
7413         (desired_style): Remove.
7414         (emit_style_escape): Add stream parameter.
7415         (set_output_style, reset_terminal_style, prompt_for_continue):
7416         Update.
7417         (flush_wrap_buffer): Only flush gdb_stdout.
7418         (wrap_here): Set wrap_style.
7419         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7420         treat escape sequences as a character.  Change when wrap buffer is
7421         flushed.
7422         (fputs_styled): Do not set the output style when the default is
7423         requested.
7424         * ui-style.h (struct ui_file_style) <is_default>: New method.
7425         * source.c (print_source_lines_base): Emit escape sequences in one
7426         piece.
7427
7428 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7429
7430         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7431         integers and enumeration types.
7432
7433 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7434
7435         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7436         instead of lookup_symbol_in_language
7437         (do_exact_match): New function.
7438         (ada_get_symbol_name_matcher): Return do_exact_match when
7439         doing a verbatim match.
7440
7441 2019-02-15  Tom Tromey  <tromey@adacore.com>
7442
7443         * ravenscar-thread.c (ravenscar_thread_target::resume)
7444         (ravenscar_thread_target::wait): Special case wildcard requests.
7445
7446 2019-02-15  Tom Tromey  <tromey@adacore.com>
7447
7448         * ravenscar-thread.c (base_ptid): Remove.
7449         (struct ravenscar_thread_target) <close>: New method.
7450         <m_base_ptid>: New member.
7451         <update_inferior_ptid, active_task, task_is_currently_active,
7452         runtime_initialized>: Declare methods.
7453         <ravenscar_thread_target>: Add constructor.
7454         (ravenscar_thread_target::task_is_currently_active)
7455         (ravenscar_thread_target::update_inferior_ptid)
7456         (ravenscar_runtime_initialized): Rename.  Now methods.
7457         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7458         (ravenscar_thread_target::update_thread_list): Update.
7459         (ravenscar_thread_target::active_task): Now method.
7460         (ravenscar_thread_target::store_registers)
7461         (ravenscar_thread_target::prepare_to_store)
7462         (ravenscar_thread_target::prepare_to_store)
7463         (ravenscar_thread_target::mourn_inferior): Update.
7464         (ravenscar_inferior_created): Use "new" to create target.
7465         (ravenscar_thread_target::get_ada_task_ptid): Update.
7466         (_initialize_ravenscar): Don't initialize base_ptid.
7467         (ravenscar_ops): Remove global.
7468
7469 2019-02-15  Tom Tromey  <tromey@adacore.com>
7470
7471         * target.h (push_target): Declare new overload.
7472         * target.c (push_target): New overload, taking an rvalue reference.
7473         * remote.c (remote_target::open_1): Use push_target overload.
7474         * corelow.c (core_target_open): Use push_target overload.
7475
7476 2019-02-15  Tom Tromey  <tromey@adacore.com>
7477
7478         * ravenscar-thread.c (is_ravenscar_task)
7479         (ravenscar_task_is_currently_active): Return bool.
7480         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7481         (_initialize_ravenscar): Remove "(void)".
7482         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7483         Return bool.
7484
7485 2019-02-15  Tom Tromey  <tromey@adacore.com>
7486
7487         * ravenscar-thread.c (ravenscar_runtime_initializer)
7488         (has_ravenscar_runtime, get_running_thread_id)
7489         (ravenscar_thread_target::resume): Fix indentation.
7490
7491 2019-02-15  Tom Tromey  <tromey@adacore.com>
7492
7493         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7494         from ravenscar_arch_ops.
7495         (sparc_ravenscar_ops::fetch_registers)
7496         (sparc_ravenscar_ops::store_registers): Now methods.
7497         (sparc_ravenscar_prepare_to_store): Remove.
7498         (sparc_ravenscar_ops): Redefine.
7499         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7500         methods and destructor.  Remove members.
7501         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7502         (ravenscar_thread_target::store_registers)
7503         (ravenscar_thread_target::prepare_to_store): Update.
7504         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7505         Remove.
7506         (struct ppc_ravenscar_powerpc_ops): Derive from
7507         ravenscar_arch_ops.
7508         (ppc_ravenscar_powerpc_ops::fetch_registers)
7509         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7510         (ppc_ravenscar_powerpc_ops): Redefine.
7511         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7512         (ppc_ravenscar_e500_ops::fetch_registers)
7513         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7514         (ppc_ravenscar_e500_ops): Redefine.
7515         * aarch64-ravenscar-thread.c
7516         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7517         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7518         (aarch64_ravenscar_fetch_registers)
7519         (aarch64_ravenscar_store_registers): Now methods.
7520         (aarch64_ravenscar_ops): Redefine.
7521
7522 2019-02-15  Tom Tromey  <tromey@adacore.com>
7523
7524         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7525         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7526         (ravenscar_thread_target::stopped_by_watchpoint)
7527         (ravenscar_thread_target::stopped_data_address)
7528         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7529
7530 2019-02-15  Tom Tromey  <tromey@adacore.com>
7531
7532         * ravenscar-thread.c: Fix some typos.
7533
7534 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7535             Tom Tromey  <tromey@adacore.com>
7536
7537         * ada-lang.c (ada_exception_sal): Change addr_string to a
7538         std::string.
7539         (create_ada_exception_catchpoint): Update.
7540
7541 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7542             Tom Tromey  <tromey@adacore.com>
7543
7544         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7545         (bp_location_ops): Remove.
7546         (base_breakpoint_allocate_location): Update.
7547         (free_bp_location): Update.
7548         * ada-lang.c (class ada_catchpoint_location)
7549         <ada_catchpoint_location>: Remove ops parameter.
7550         (ada_catchpoint_location_dtor): Remove.
7551         (ada_catchpoint_location_ops): Remove.
7552         (allocate_location_exception): Update.
7553         * breakpoint.h (struct bp_location_ops): Remove.
7554         (class bp_location) <bp_location>: Remove bp_location_ops
7555         parameter.
7556         <~bp_location>: Add destructor.
7557         <ops>: Remove.
7558
7559 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7560             Pedro Alves  <palves@redhat.com>
7561
7562         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7563         'PATH_MAX'.
7564
7565 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7566             Samuel Thibault  <samuel.thibault@gnu.org>
7567             Thomas Schwinge  <thomas@codesourcery.com>
7568
7569         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7570         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7571
7572 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7573
7574         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7575         (check_empty): Use "const char *".
7576
7577         * gnu-nat.c (gnu_nat_target::detach): Instead of
7578         'detach_inferior (pid)' call
7579         'detach_inferior (find_inferior_pid (pid))'.
7580
7581         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7582         'nat/fork-inferior.o'.
7583         * gnu-nat.c: #include "nat/fork-inferior.h".
7584
7585         * gnu-nat.c (gnu_nat_target::detach): Instead of
7586         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7587         * gnu-nat.h: #include "inf-child.h".
7588         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7589         'i386_gnu_nat_target::fetch_registers'.
7590         (gnu_store_registers): Rename/move to
7591         'i386_gnu_nat_target::store_registers'.
7592
7593         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7594         * gnu-nat.h (mach_thread_info): New function.
7595         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7596
7597         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7598
7599 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7600
7601         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7602
7603 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7604
7605         * windows-nat.c (windows_add_thread): Add new parameter
7606         "main_thread_p" with default value set to false.  Update
7607         function documentation as well as all callers.
7608         (windows_delete_thread): Likewise.
7609         (fake_create_process): Update call to windows_add_thread.
7610         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7611         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7612         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7613         call to windows_delete_thread.
7614
7615 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7616
7617         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7618
7619 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7620
7621         * symfile.c (find_separate_debug_file): Use canonical path of
7622         sysroot with child_path instead of gdb_sysroot if it is valid.
7623
7624 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7625
7626         * symfile.c (find_separate_debug_file): Use child_path to
7627         determine if an object file is under a sysroot.
7628
7629 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7630
7631         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7632         unittests/child-path-selftests.c.
7633         * common/pathstuff.c (child_path): New function.
7634         * common/pathstuff.h (child_path): New prototype.
7635         * unittests/child-path-selftests.c: New file.
7636
7637 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7638
7639         * symfile.c (find_separate_debug_file): Look for separate debug
7640         files in debug directories under the sysroot.
7641
7642 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7643
7644         * symtab.h (struct minimal_symbol data_p): New const method.
7645         (struct minimal_symbol text_p): Likewise.
7646         * symtab.c (output_source_filename): Use file name style
7647         to print file name.
7648         (print_symbol_info): Likewise.
7649         (print_msymbol_info): Use address style to print addresses.
7650         Use function name style to print executable text symbols.
7651         (expand_symtab_containing_pc): Use data_p.
7652         (find_pc_sect_compunit_symtab): Likewise.
7653
7654 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7655
7656         * breakpoint.c (describe_other_breakpoints): Use address style
7657         to print addresses.
7658         (say_where): Likewise.
7659
7660 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7661
7662         * ada-typeprint.c (print_func_type): Print function name
7663         style to print function name.
7664         * c-typeprint.c (c_print_type_1): Likewise.
7665
7666 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7667
7668         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7669         for execve.
7670
7671 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7672
7673         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7674         type_stack.
7675
7676 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7677
7678         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7679         TYPE_CODE_REF types.
7680
7681 2019-02-08  Jim Wilson  <jimw@sifive.com>
7682
7683         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7684         (riscv_linux_fregset): New.
7685         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7686
7687 2019-02-07  Tom Tromey  <tom@tromey.com>
7688
7689         * thread.c (thread_cancel_execution_command): Update.
7690         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7691         methods.
7692         (struct thread_fsm_ops): Remove.
7693         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7694         (thread_fsm_should_stop, thread_fsm_return_value)
7695         (thread_fsm_set_finished, thread_fsm_finished_p)
7696         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7697         Don't declare.
7698         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7699         * infrun.c (clear_proceed_status_thread)
7700         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7701         (print_stop_event): Update.
7702         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7703         Add constructor.
7704         (step_command_fsm_ops): Remove.
7705         (new_step_command_fsm): Remove.
7706         (step_1): Update.
7707         (step_command_fsm::should_stop): Rename from
7708         step_command_fsm_should_stop.
7709         (step_command_fsm::clean_up): Rename from
7710         step_command_fsm_clean_up.
7711         (step_command_fsm::do_async_reply_reason): Rename from
7712         step_command_fsm_async_reply_reason.
7713         (struct until_next_fsm): Inherit from thread_fsm.  Add
7714         constructor.
7715         (until_next_fsm_ops): Remove.
7716         (new_until_next_fsm): Remove.
7717         (until_next_fsm::should_stop): Rename from
7718         until_next_fsm_should_stop.
7719         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7720         (until_next_fsm::do_async_reply_reason): Rename from
7721         until_next_fsm_async_reply_reason.
7722         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7723         constructor.  Change type of breakpoint.
7724         (finish_command_fsm_ops): Remove.
7725         (new_finish_command_fsm): Remove.
7726         (finish_command_fsm::should_stop): Rename from
7727         finish_command_fsm_should_stop.
7728         (finish_command_fsm::clean_up): Rename from
7729         finish_command_fsm_clean_up.
7730         (finish_command_fsm::return_value): Rename from
7731         finish_command_fsm_return_value.
7732         (finish_command_fsm::do_async_reply_reason): Rename from
7733         finish_command_fsm_async_reply_reason.
7734         (finish_command): Update.
7735         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7736         Add constructor.
7737         (call_thread_fsm_ops): Remove.
7738         (call_thread_fsm::call_thread_fsm): Rename from
7739         new_call_thread_fsm.
7740         (call_thread_fsm::should_stop): Rename from
7741         call_thread_fsm_should_stop.
7742         (call_thread_fsm::should_notify_stop): Rename from
7743         call_thread_fsm_should_notify_stop.
7744         (run_inferior_call, call_function_by_hand_dummy): Update.
7745         * cli/cli-interp.c (should_print_stop_to_console): Update.
7746         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7747         Add constructor.  Change type of location_breakpoint,
7748         caller_breakpoint.
7749         (until_break_fsm_ops): Remove.
7750         (new_until_break_fsm): Remove.
7751         (until_break_fsm::should_stop): Rename from
7752         until_break_fsm_should_stop.
7753         (until_break_fsm::clean_up): Rename from
7754         until_break_fsm_clean_up.
7755         (until_break_fsm::do_async_reply_reason): Rename from
7756         until_break_fsm_async_reply_reason.
7757         (until_break_command): Update.
7758         * thread-fsm.c: Remove.
7759         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7760
7761 2019-02-07  Tom Tromey  <tom@tromey.com>
7762
7763         * yy-remap.h: Add include guard.
7764         * xtensa-tdep.h: Add include guard.
7765         * xcoffread.h: Rename include guard.
7766         * varobj-iter.h: Add include guard.
7767         * tui/tui.h: Rename include guard.
7768         * tui/tui-winsource.h: Rename include guard.
7769         * tui/tui-wingeneral.h: Rename include guard.
7770         * tui/tui-windata.h: Rename include guard.
7771         * tui/tui-win.h: Rename include guard.
7772         * tui/tui-stack.h: Rename include guard.
7773         * tui/tui-source.h: Rename include guard.
7774         * tui/tui-regs.h: Rename include guard.
7775         * tui/tui-out.h: Rename include guard.
7776         * tui/tui-layout.h: Rename include guard.
7777         * tui/tui-io.h: Rename include guard.
7778         * tui/tui-hooks.h: Rename include guard.
7779         * tui/tui-file.h: Rename include guard.
7780         * tui/tui-disasm.h: Rename include guard.
7781         * tui/tui-data.h: Rename include guard.
7782         * tui/tui-command.h: Rename include guard.
7783         * tic6x-tdep.h: Add include guard.
7784         * target/waitstatus.h: Rename include guard.
7785         * target/wait.h: Rename include guard.
7786         * target/target.h: Rename include guard.
7787         * target/resume.h: Rename include guard.
7788         * target-float.h: Rename include guard.
7789         * stabsread.h: Add include guard.
7790         * rs6000-tdep.h: Add include guard.
7791         * riscv-fbsd-tdep.h: Add include guard.
7792         * regformats/regdef.h: Rename include guard.
7793         * record.h: Rename include guard.
7794         * python/python.h: Rename include guard.
7795         * python/python-internal.h: Rename include guard.
7796         * python/py-stopevent.h: Rename include guard.
7797         * python/py-ref.h: Rename include guard.
7798         * python/py-record.h: Rename include guard.
7799         * python/py-record-full.h: Rename include guard.
7800         * python/py-record-btrace.h: Rename include guard.
7801         * python/py-instruction.h: Rename include guard.
7802         * python/py-events.h: Rename include guard.
7803         * python/py-event.h: Rename include guard.
7804         * procfs.h: Add include guard.
7805         * proc-utils.h: Add include guard.
7806         * p-lang.h: Add include guard.
7807         * or1k-tdep.h: Rename include guard.
7808         * observable.h: Rename include guard.
7809         * nto-tdep.h: Rename include guard.
7810         * nat/x86-linux.h: Rename include guard.
7811         * nat/x86-linux-dregs.h: Rename include guard.
7812         * nat/x86-gcc-cpuid.h: Add include guard.
7813         * nat/x86-dregs.h: Rename include guard.
7814         * nat/x86-cpuid.h: Rename include guard.
7815         * nat/ppc-linux.h: Rename include guard.
7816         * nat/mips-linux-watch.h: Rename include guard.
7817         * nat/linux-waitpid.h: Rename include guard.
7818         * nat/linux-ptrace.h: Rename include guard.
7819         * nat/linux-procfs.h: Rename include guard.
7820         * nat/linux-osdata.h: Rename include guard.
7821         * nat/linux-nat.h: Rename include guard.
7822         * nat/linux-namespaces.h: Rename include guard.
7823         * nat/linux-btrace.h: Rename include guard.
7824         * nat/glibc_thread_db.h: Rename include guard.
7825         * nat/gdb_thread_db.h: Rename include guard.
7826         * nat/gdb_ptrace.h: Rename include guard.
7827         * nat/fork-inferior.h: Rename include guard.
7828         * nat/amd64-linux-siginfo.h: Rename include guard.
7829         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7830         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7831         * nat/aarch64-linux.h: Rename include guard.
7832         * nat/aarch64-linux-hw-point.h: Rename include guard.
7833         * mn10300-tdep.h: Add include guard.
7834         * mips-linux-tdep.h: Add include guard.
7835         * mi/mi-parse.h: Rename include guard.
7836         * mi/mi-out.h: Rename include guard.
7837         * mi/mi-main.h: Rename include guard.
7838         * mi/mi-interp.h: Rename include guard.
7839         * mi/mi-getopt.h: Rename include guard.
7840         * mi/mi-console.h: Rename include guard.
7841         * mi/mi-common.h: Rename include guard.
7842         * mi/mi-cmds.h: Rename include guard.
7843         * mi/mi-cmd-break.h: Rename include guard.
7844         * m2-lang.h: Add include guard.
7845         * location.h: Rename include guard.
7846         * linux-record.h: Rename include guard.
7847         * linux-nat.h: Add include guard.
7848         * linux-fork.h: Add include guard.
7849         * i386-darwin-tdep.h: Rename include guard.
7850         * hppa-linux-offsets.h: Add include guard.
7851         * guile/guile.h: Rename include guard.
7852         * guile/guile-internal.h: Rename include guard.
7853         * gnu-nat.h: Rename include guard.
7854         * gdb-stabs.h: Rename include guard.
7855         * frv-tdep.h: Add include guard.
7856         * f-lang.h: Add include guard.
7857         * event-loop.h: Add include guard.
7858         * darwin-nat.h: Rename include guard.
7859         * cp-abi.h: Rename include guard.
7860         * config/sparc/nm-sol2.h: Rename include guard.
7861         * config/nm-nto.h: Rename include guard.
7862         * config/nm-linux.h: Add include guard.
7863         * config/i386/nm-i386gnu.h: Rename include guard.
7864         * config/djgpp/nl_types.h: Rename include guard.
7865         * config/djgpp/langinfo.h: Rename include guard.
7866         * compile/gcc-cp-plugin.h: Add include guard.
7867         * compile/gcc-c-plugin.h: Add include guard.
7868         * compile/compile.h: Rename include guard.
7869         * compile/compile-object-run.h: Rename include guard.
7870         * compile/compile-object-load.h: Rename include guard.
7871         * compile/compile-internal.h: Rename include guard.
7872         * compile/compile-cplus.h: Rename include guard.
7873         * compile/compile-c.h: Rename include guard.
7874         * common/xml-utils.h: Rename include guard.
7875         * common/x86-xstate.h: Rename include guard.
7876         * common/version.h: Rename include guard.
7877         * common/vec.h: Rename include guard.
7878         * common/tdesc.h: Rename include guard.
7879         * common/selftest.h: Rename include guard.
7880         * common/scoped_restore.h: Rename include guard.
7881         * common/scoped_mmap.h: Rename include guard.
7882         * common/scoped_fd.h: Rename include guard.
7883         * common/safe-iterator.h: Rename include guard.
7884         * common/run-time-clock.h: Rename include guard.
7885         * common/refcounted-object.h: Rename include guard.
7886         * common/queue.h: Rename include guard.
7887         * common/ptid.h: Rename include guard.
7888         * common/print-utils.h: Rename include guard.
7889         * common/preprocessor.h: Rename include guard.
7890         * common/pathstuff.h: Rename include guard.
7891         * common/observable.h: Rename include guard.
7892         * common/netstuff.h: Rename include guard.
7893         * common/job-control.h: Rename include guard.
7894         * common/host-defs.h: Rename include guard.
7895         * common/gdb_wait.h: Rename include guard.
7896         * common/gdb_vecs.h: Rename include guard.
7897         * common/gdb_unlinker.h: Rename include guard.
7898         * common/gdb_unique_ptr.h: Rename include guard.
7899         * common/gdb_tilde_expand.h: Rename include guard.
7900         * common/gdb_sys_time.h: Rename include guard.
7901         * common/gdb_string_view.h: Rename include guard.
7902         * common/gdb_splay_tree.h: Rename include guard.
7903         * common/gdb_setjmp.h: Rename include guard.
7904         * common/gdb_ref_ptr.h: Rename include guard.
7905         * common/gdb_optional.h: Rename include guard.
7906         * common/gdb_locale.h: Rename include guard.
7907         * common/gdb_assert.h: Rename include guard.
7908         * common/filtered-iterator.h: Rename include guard.
7909         * common/filestuff.h: Rename include guard.
7910         * common/fileio.h: Rename include guard.
7911         * common/environ.h: Rename include guard.
7912         * common/common-utils.h: Rename include guard.
7913         * common/common-types.h: Rename include guard.
7914         * common/common-regcache.h: Rename include guard.
7915         * common/common-inferior.h: Rename include guard.
7916         * common/common-gdbthread.h: Rename include guard.
7917         * common/common-exceptions.h: Rename include guard.
7918         * common/common-defs.h: Rename include guard.
7919         * common/common-debug.h: Rename include guard.
7920         * common/cleanups.h: Rename include guard.
7921         * common/buffer.h: Rename include guard.
7922         * common/btrace-common.h: Rename include guard.
7923         * common/break-common.h: Rename include guard.
7924         * cli/cli-utils.h: Rename include guard.
7925         * cli/cli-style.h: Rename include guard.
7926         * cli/cli-setshow.h: Rename include guard.
7927         * cli/cli-script.h: Rename include guard.
7928         * cli/cli-interp.h: Rename include guard.
7929         * cli/cli-decode.h: Rename include guard.
7930         * cli/cli-cmds.h: Rename include guard.
7931         * charset-list.h: Add include guard.
7932         * buildsym-legacy.h: Rename include guard.
7933         * bfin-tdep.h: Add include guard.
7934         * ax.h: Rename include guard.
7935         * arm-linux-tdep.h: Add include guard.
7936         * arm-fbsd-tdep.h: Add include guard.
7937         * arch/xtensa.h: Rename include guard.
7938         * arch/tic6x.h: Add include guard.
7939         * arch/i386.h: Add include guard.
7940         * arch/arm.h: Rename include guard.
7941         * arch/arm-linux.h: Rename include guard.
7942         * arch/arm-get-next-pcs.h: Rename include guard.
7943         * arch/amd64.h: Add include guard.
7944         * arch/aarch64-insn.h: Rename include guard.
7945         * arch-utils.h: Rename include guard.
7946         * annotate.h: Add include guard.
7947         * amd64-darwin-tdep.h: Rename include guard.
7948         * aarch64-linux-tdep.h: Add include guard.
7949         * aarch64-fbsd-tdep.h: Add include guard.
7950         * aarch32-linux-nat.h: Add include guard.
7951
7952 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7953
7954         * macrotab.c (macro_define_internal): New function that
7955         factorizes macro_define_object_internal and macro_define_function
7956         code.
7957         (macro_define_object_internal): Use macro_define_internal.
7958         (macro_define_function): Likewise.
7959
7960 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7961
7962         * macrocmd.c (extract_identifier): Return
7963         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7964         callers.
7965
7966 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7967
7968         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7969
7970 2019-02-05  Tom Tromey  <tom@tromey.com>
7971
7972         * target.c (target_stack::unpush): Move assertion earlier.
7973
7974 2019-01-30  Tom Tromey  <tom@tromey.com>
7975
7976         PR python/23615:
7977         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7978         (gdbpy_parse_and_eval): Likewise.
7979         * python/python-internal.h (gdbpy_allow_threads): New class.
7980
7981 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7982
7983         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7984         (aarch64_fbsd_fpregmap): Move earlier.
7985         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7986         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7987         instead of individual calls to trad_frame_set_reg_addr.
7988         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7989         earlier.
7990         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7991         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7992         instead of individual calls to trad_frame_set_reg_addr.
7993
7994 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7995
7996         * CONTRIBUTE: Replace contribution list with wiki link.
7997
7998 2019-01-25  Tom Tromey  <tom@tromey.com>
7999
8000         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8001
8002 2019-01-25  Tom Tromey  <tom@tromey.com>
8003
8004         * xtensa-linux-nat.c: Fix common/ includes.
8005         * xml-support.h: Fix common/ includes.
8006         * xml-support.c: Fix common/ includes.
8007         * x86-linux-nat.c: Fix common/ includes.
8008         * windows-nat.c: Fix common/ includes.
8009         * varobj.h: Fix common/ includes.
8010         * varobj.c: Fix common/ includes.
8011         * value.c: Fix common/ includes.
8012         * valops.c: Fix common/ includes.
8013         * utils.c: Fix common/ includes.
8014         * unittests/xml-utils-selftests.c: Fix common/ includes.
8015         * unittests/utils-selftests.c: Fix common/ includes.
8016         * unittests/unpack-selftests.c: Fix common/ includes.
8017         * unittests/tracepoint-selftests.c: Fix common/ includes.
8018         * unittests/style-selftests.c: Fix common/ includes.
8019         * unittests/string_view-selftests.c: Fix common/ includes.
8020         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8021         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8022         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8023         * unittests/rsp-low-selftests.c: Fix common/ includes.
8024         * unittests/parse-connection-spec-selftests.c: Fix common/
8025         includes.
8026         * unittests/optional-selftests.c: Fix common/ includes.
8027         * unittests/offset-type-selftests.c: Fix common/ includes.
8028         * unittests/observable-selftests.c: Fix common/ includes.
8029         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8030         * unittests/memrange-selftests.c: Fix common/ includes.
8031         * unittests/memory-map-selftests.c: Fix common/ includes.
8032         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8033         * unittests/function-view-selftests.c: Fix common/ includes.
8034         * unittests/environ-selftests.c: Fix common/ includes.
8035         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8036         * unittests/common-utils-selftests.c: Fix common/ includes.
8037         * unittests/cli-utils-selftests.c: Fix common/ includes.
8038         * unittests/array-view-selftests.c: Fix common/ includes.
8039         * ui-file.c: Fix common/ includes.
8040         * tui/tui-io.c: Fix common/ includes.
8041         * tracepoint.h: Fix common/ includes.
8042         * tracepoint.c: Fix common/ includes.
8043         * tracefile-tfile.c: Fix common/ includes.
8044         * top.h: Fix common/ includes.
8045         * top.c: Fix common/ includes.
8046         * thread.c: Fix common/ includes.
8047         * target/waitstatus.h: Fix common/ includes.
8048         * target/waitstatus.c: Fix common/ includes.
8049         * target.h: Fix common/ includes.
8050         * target.c: Fix common/ includes.
8051         * target-memory.c: Fix common/ includes.
8052         * target-descriptions.c: Fix common/ includes.
8053         * symtab.h: Fix common/ includes.
8054         * symfile.c: Fix common/ includes.
8055         * stap-probe.c: Fix common/ includes.
8056         * spu-linux-nat.c: Fix common/ includes.
8057         * sparc-nat.c: Fix common/ includes.
8058         * source.c: Fix common/ includes.
8059         * solib.c: Fix common/ includes.
8060         * solib-target.c: Fix common/ includes.
8061         * ser-unix.c: Fix common/ includes.
8062         * ser-tcp.c: Fix common/ includes.
8063         * ser-pipe.c: Fix common/ includes.
8064         * ser-base.c: Fix common/ includes.
8065         * selftest-arch.c: Fix common/ includes.
8066         * s12z-tdep.c: Fix common/ includes.
8067         * rust-exp.y: Fix common/ includes.
8068         * rs6000-aix-tdep.c: Fix common/ includes.
8069         * riscv-tdep.c: Fix common/ includes.
8070         * remote.c: Fix common/ includes.
8071         * remote-notif.h: Fix common/ includes.
8072         * remote-fileio.h: Fix common/ includes.
8073         * remote-fileio.c: Fix common/ includes.
8074         * regcache.h: Fix common/ includes.
8075         * regcache.c: Fix common/ includes.
8076         * record-btrace.c: Fix common/ includes.
8077         * python/python.c: Fix common/ includes.
8078         * python/py-type.c: Fix common/ includes.
8079         * python/py-inferior.c: Fix common/ includes.
8080         * progspace.h: Fix common/ includes.
8081         * producer.c: Fix common/ includes.
8082         * procfs.c: Fix common/ includes.
8083         * proc-api.c: Fix common/ includes.
8084         * printcmd.c: Fix common/ includes.
8085         * ppc-linux-nat.c: Fix common/ includes.
8086         * parser-defs.h: Fix common/ includes.
8087         * osdata.c: Fix common/ includes.
8088         * obsd-nat.c: Fix common/ includes.
8089         * nat/x86-linux.c: Fix common/ includes.
8090         * nat/x86-linux-dregs.c: Fix common/ includes.
8091         * nat/x86-dregs.h: Fix common/ includes.
8092         * nat/x86-dregs.c: Fix common/ includes.
8093         * nat/ppc-linux.c: Fix common/ includes.
8094         * nat/mips-linux-watch.h: Fix common/ includes.
8095         * nat/mips-linux-watch.c: Fix common/ includes.
8096         * nat/linux-waitpid.c: Fix common/ includes.
8097         * nat/linux-ptrace.h: Fix common/ includes.
8098         * nat/linux-ptrace.c: Fix common/ includes.
8099         * nat/linux-procfs.c: Fix common/ includes.
8100         * nat/linux-personality.c: Fix common/ includes.
8101         * nat/linux-osdata.c: Fix common/ includes.
8102         * nat/linux-namespaces.c: Fix common/ includes.
8103         * nat/linux-btrace.h: Fix common/ includes.
8104         * nat/linux-btrace.c: Fix common/ includes.
8105         * nat/fork-inferior.c: Fix common/ includes.
8106         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8107         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8108         * nat/aarch64-linux.c: Fix common/ includes.
8109         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8110         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8111         * namespace.h: Fix common/ includes.
8112         * mips-linux-tdep.c: Fix common/ includes.
8113         * minsyms.c: Fix common/ includes.
8114         * mi/mi-parse.h: Fix common/ includes.
8115         * mi/mi-main.c: Fix common/ includes.
8116         * mi/mi-cmd-env.c: Fix common/ includes.
8117         * memrange.h: Fix common/ includes.
8118         * memattr.c: Fix common/ includes.
8119         * maint.h: Fix common/ includes.
8120         * maint.c: Fix common/ includes.
8121         * main.c: Fix common/ includes.
8122         * machoread.c: Fix common/ includes.
8123         * location.c: Fix common/ includes.
8124         * linux-thread-db.c: Fix common/ includes.
8125         * linux-nat.c: Fix common/ includes.
8126         * linux-fork.c: Fix common/ includes.
8127         * inline-frame.c: Fix common/ includes.
8128         * infrun.c: Fix common/ includes.
8129         * inflow.c: Fix common/ includes.
8130         * inferior.h: Fix common/ includes.
8131         * inferior.c: Fix common/ includes.
8132         * infcmd.c: Fix common/ includes.
8133         * inf-ptrace.c: Fix common/ includes.
8134         * inf-child.c: Fix common/ includes.
8135         * ia64-linux-nat.c: Fix common/ includes.
8136         * i387-tdep.c: Fix common/ includes.
8137         * i386-tdep.c: Fix common/ includes.
8138         * i386-linux-tdep.c: Fix common/ includes.
8139         * i386-linux-nat.c: Fix common/ includes.
8140         * i386-go32-tdep.c: Fix common/ includes.
8141         * i386-fbsd-tdep.c: Fix common/ includes.
8142         * i386-fbsd-nat.c: Fix common/ includes.
8143         * guile/scm-type.c: Fix common/ includes.
8144         * guile/guile.c: Fix common/ includes.
8145         * go32-nat.c: Fix common/ includes.
8146         * gnu-nat.c: Fix common/ includes.
8147         * gdbthread.h: Fix common/ includes.
8148         * gdbarch-selftests.c: Fix common/ includes.
8149         * gdb_usleep.c: Fix common/ includes.
8150         * gdb_select.h: Fix common/ includes.
8151         * gdb_bfd.c: Fix common/ includes.
8152         * gcore.c: Fix common/ includes.
8153         * fork-child.c: Fix common/ includes.
8154         * findvar.c: Fix common/ includes.
8155         * fbsd-nat.c: Fix common/ includes.
8156         * event-top.c: Fix common/ includes.
8157         * event-loop.c: Fix common/ includes.
8158         * dwarf2read.c: Fix common/ includes.
8159         * dwarf2loc.c: Fix common/ includes.
8160         * dwarf2-frame.c: Fix common/ includes.
8161         * dwarf-index-cache.c: Fix common/ includes.
8162         * dtrace-probe.c: Fix common/ includes.
8163         * disasm-selftests.c: Fix common/ includes.
8164         * defs.h: Fix common/ includes.
8165         * csky-tdep.c: Fix common/ includes.
8166         * cp-valprint.c: Fix common/ includes.
8167         * cp-support.h: Fix common/ includes.
8168         * cp-support.c: Fix common/ includes.
8169         * corelow.c: Fix common/ includes.
8170         * completer.h: Fix common/ includes.
8171         * completer.c: Fix common/ includes.
8172         * compile/compile.c: Fix common/ includes.
8173         * compile/compile-loc2c.c: Fix common/ includes.
8174         * compile/compile-cplus-types.c: Fix common/ includes.
8175         * compile/compile-cplus-symbols.c: Fix common/ includes.
8176         * command.h: Fix common/ includes.
8177         * cli/cli-dump.c: Fix common/ includes.
8178         * cli/cli-cmds.c: Fix common/ includes.
8179         * charset.c: Fix common/ includes.
8180         * build-id.c: Fix common/ includes.
8181         * btrace.h: Fix common/ includes.
8182         * btrace.c: Fix common/ includes.
8183         * breakpoint.h: Fix common/ includes.
8184         * breakpoint.c: Fix common/ includes.
8185         * ax.h: 
8186         (enum agent_op): Fix common/ includes.
8187         * ax-general.c (struct aop_map): Fix common/ includes.
8188         * ax-gdb.c: Fix common/ includes.
8189         * auxv.c: Fix common/ includes.
8190         * auto-load.c: Fix common/ includes.
8191         * arm-tdep.c: Fix common/ includes.
8192         * arch/riscv.c: Fix common/ includes.
8193         * arch/ppc-linux-common.c: Fix common/ includes.
8194         * arch/i386.c: Fix common/ includes.
8195         * arch/arm.c: Fix common/ includes.
8196         * arch/arm-linux.c: Fix common/ includes.
8197         * arch/arm-get-next-pcs.c: Fix common/ includes.
8198         * arch/amd64.c: Fix common/ includes.
8199         * arch/aarch64.c: Fix common/ includes.
8200         * arch/aarch64-insn.c: Fix common/ includes.
8201         * arch-utils.c: Fix common/ includes.
8202         * amd64-windows-tdep.c: Fix common/ includes.
8203         * amd64-tdep.c: Fix common/ includes.
8204         * amd64-sol2-tdep.c: Fix common/ includes.
8205         * amd64-obsd-tdep.c: Fix common/ includes.
8206         * amd64-nbsd-tdep.c: Fix common/ includes.
8207         * amd64-linux-tdep.c: Fix common/ includes.
8208         * amd64-linux-nat.c: Fix common/ includes.
8209         * amd64-fbsd-tdep.c: Fix common/ includes.
8210         * amd64-fbsd-nat.c: Fix common/ includes.
8211         * amd64-dicos-tdep.c: Fix common/ includes.
8212         * amd64-darwin-tdep.c: Fix common/ includes.
8213         * agent.c: Fix common/ includes.
8214         * ada-lang.h: Fix common/ includes.
8215         * ada-lang.c: Fix common/ includes.
8216         * aarch64-tdep.c: Fix common/ includes.
8217
8218 2019-01-25  Tom Tromey  <tom@tromey.com>
8219
8220         * common/create-version.sh: Use common/version.h.
8221
8222 2019-01-24  Pedro Alves  <palves@redhat.com>
8223
8224         * infrun.c (signal_stop, signal_print, signal_program)
8225         (signal_catch, signal_pass): Now arrays instead of pointers.
8226         (update_signals_program_target, do_target_resume)
8227         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8228         * linux-nat.c (linux_nat_target::pass_signals)
8229         (linux_nat_target::create_inferior, linux_nat_target::attach):
8230         Adjust.
8231         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8232         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8233         * procfs.c (procfs_target::pass_signals): Adjust.
8234         * record-full.c (record_full_target::resume): Adjust.
8235         * remote.c (remote_target::pass_signals)
8236         (remote_target::program_signals): Adjust.
8237         * target-debug.h (target_debug_print_signals): Now takes a
8238         gdb::array_view as parameter.  Adjust.
8239         * target.h (target_ops) <pass_signals, program_signals>: Replace
8240         pointer and length parameters with gdb::array_view.
8241         (target_pass_signals, target_program_signals): Likewise.
8242         * target-delegates.c: Regenerate.
8243
8244 2019-01-24  Pedro Alves  <palves@redhat.com>
8245
8246         * common/forward-scope-exit.h
8247         (forward_scope_exit::forward_scope_exit): Pass arguments to
8248         m_bind_function directly, instead of creating a std::bind and
8249         copying that.
8250
8251 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8252
8253         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8254         for static members.
8255         (pass_in_v_vfp_candidate): Likewise.
8256
8257 2019-01-23  Tom Tromey  <tom@tromey.com>
8258             Pedro Alves  <palves@redhat.com>
8259
8260         * regcache.c (class regcache_invalidator): Remove.
8261         (regcache::raw_write): Use make_scope_exit.
8262
8263 2019-01-23  Tom Tromey  <tom@tromey.com>
8264
8265         * ui-out.h (class ui_out_emit_type): Update comment.
8266
8267 2019-01-23  Tom Tromey  <tom@tromey.com>
8268
8269         * infrun.c (fetch_inferior_event): Update comment.
8270
8271 2019-01-23  Tom Tromey  <tom@tromey.com>
8272             Pedro Alves  <palves@redhat.com>
8273
8274         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8275         parameter.
8276         (fetch_inferior_event): Use SCOPE_EXIT.
8277
8278
8279 2019-01-23  Tom Tromey  <tom@tromey.com>
8280             Pedro Alves  <palves@redhat.com>
8281
8282         * infrun.c (disable_thread_events): Delete.
8283         (stop_all_threads): Use SCOPE_EXIT.
8284
8285 2019-01-23  Tom Tromey  <tom@tromey.com>
8286             Pedro Alves  <palves@redhat.com>
8287
8288         * symfile.c: Include forward-scope-exit.h.
8289         (clear_symtab_users_cleanup): Replace forward declaration with
8290         a FORWARD_SCOPE_EXIT.
8291         (syms_from_objfile_1): Use the forward_scope_exit and
8292         gdb::optional instead of cleanup_function.
8293         (reread_symbols): Use the forward_scope_exit instead of
8294         cleanup_function.
8295         (clear_symtab_users_cleanup): Remove function.
8296
8297 2019-01-23  Tom Tromey  <tom@tromey.com>
8298             Pedro Alves  <palves@redhat.com>
8299
8300         * linux-nat.c: Include scope-exit.h.
8301         (cleanup_target_stop): Remove.
8302         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8303         SCOPE_EXIT.
8304
8305 2019-01-23  Tom Tromey  <tom@tromey.com>
8306             Pedro Alves  <palves@redhat.com>
8307
8308         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8309         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8310
8311 2019-01-23  Tom Tromey  <tom@tromey.com>
8312             Andrew Burgess  <andrew.burgess@embecosm.com>
8313             Pedro Alves  <palves@redhat.com>
8314
8315         * infrun.c (fetch_inferior_event): Use scope_exit.
8316         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8317         * top.c (execute_command): Use scope_exit.
8318         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8319         * utils.c (do_bpstat_clear_actions_cleanup)
8320         (make_bpstat_clear_actions_cleanup): Remove.
8321
8322 2019-01-23  Tom Tromey  <tom@tromey.com>
8323             Pedro Alves  <palves@redhat.com>
8324
8325         * infrun.c: Include "common/scope-exit.h"
8326         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8327         (wait_for_inferior): Use SCOPE_EXIT.
8328         (fetch_inferior_event): Use scope_exit.
8329
8330 2019-01-23  Tom Tromey  <tom@tromey.com>
8331             Pedro Alves  <palves@redhat.com>
8332
8333         * breakpoint.c (create_breakpoint): Remove cleanup.
8334
8335 2019-01-23  Tom Tromey  <tom@tromey.com>
8336             Andrew Burgess  <andrew.burgess@embecosm.com>
8337             Pedro Alves  <palves@redhat.com>
8338
8339 2019-01-23  Pedro Alves  <palves@redhat.com>
8340
8341         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8342
8343 2019-01-23  Pedro Alves  <palves@redhat.com>
8344             Andrew Burgess  <andrew.burgess@embecosm.com>
8345
8346         * gdbthread.h: Include "common/forward-scope-exit.h".
8347         (scoped_finish_thread_state): Redefine custom class in terms of
8348         forward_scope_exit.
8349
8350 2019-01-23  Pedro Alves  <palves@redhat.com>
8351             Andrew Burgess  <andrew.burgess@embecosm.com>
8352
8353         * common/forward-scope-exit.h: New file.
8354
8355 2019-01-23  Pedro Alves  <palves@redhat.com>
8356             Andrew Burgess  <andrew.burgess@embecosm.com>
8357             Tom Tromey  <tom@tromey.com>
8358
8359         * common/scope-exit.h: New file.
8360
8361 2019-01-23  Pedro Alves  <palves@redhat.com>
8362
8363         * common/preprocessor.h (ESC): Rename to ...
8364         (ESC_PARENS): ... this.
8365         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8366         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8367
8368 2019-01-23  Tom Tromey  <tom@tromey.com>
8369
8370         * language.h (class scoped_switch_to_sym_language_if_auto):
8371         Initialize m_lang in both cases.
8372
8373 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8374
8375         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8376         with XCNEW.
8377
8378 2019-01-22  Tom Tromey  <tom@tromey.com>
8379
8380         * corelow.c: Do not include sys/file.h.
8381
8382 2019-01-22  Tom Tromey  <tom@tromey.com>
8383
8384         * tui/tui-wingeneral.h: Include gdb_curses.h.
8385
8386 2019-01-22  Tom Tromey  <tom@tromey.com>
8387
8388         * source-cache.h (class source_cache) <get_source_lines,
8389         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8390
8391 2019-01-22  Tom Tromey  <tom@tromey.com>
8392
8393         * remote-fileio.h (struct remote_target): Declare.
8394
8395 2019-01-22  Tom Tromey  <tom@tromey.com>
8396
8397         * python/py-arch.c: Do not include py-ref.h.
8398         * python/py-bpevent.c: Do not include py-ref.h.
8399         * python/py-cmd.c: Do not include py-ref.h.
8400         * python/py-continueevent.c: Do not include py-ref.h.
8401         * python/py-event.h: Do not include py-ref.h.
8402         * python/py-evtregistry.c: Do not include py-ref.h.
8403         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8404         * python/py-frame.c: Do not include py-ref.h.
8405         * python/py-framefilter.c: Do not include py-ref.h.
8406         * python/py-function.c: Do not include py-ref.h.
8407         * python/py-infevents.c: Do not include py-ref.h.
8408         * python/py-linetable.c: Do not include py-ref.h.
8409         * python/py-objfile.c: Do not include py-ref.h.
8410         * python/py-param.c: Do not include py-ref.h.
8411         * python/py-prettyprint.c: Do not include py-ref.h.
8412         * python/py-progspace.c: Do not include py-ref.h.
8413         * python/py-symbol.c: Do not include py-ref.h.
8414         * python/py-symtab.c: Do not include py-ref.h.
8415         * python/py-type.c: Do not include py-ref.h.
8416         * python/py-unwind.c: Do not include py-ref.h.
8417         * python/py-utils.c: Do not include py-ref.h.
8418         * python/py-value.c: Do not include py-ref.h.
8419         * python/py-varobj.c: Do not include py-ref.h.
8420         * python/py-xmethods.c: Do not include py-ref.h.
8421         * python/python.c: Do not include py-ref.h.
8422         * varobj.c: Do not include py-ref.h.
8423
8424 2019-01-22  Tom Tromey  <tom@tromey.com>
8425
8426         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8427         keyword for bcache.
8428
8429 2019-01-22  Tom Tromey  <tom@tromey.com>
8430
8431         * compile/compile-cplus-types.c: Remove a comment by #include.
8432
8433 2019-01-22  Tom Tromey  <tom@tromey.com>
8434
8435         * compile/gcc-c-plugin.h: Include compile-internal.h.
8436
8437 2019-01-22  Tom Tromey  <tom@tromey.com>
8438
8439         * stabsread.c (EXTERN): Do not define.
8440         (symnum, next_symbol_text_func, processing_gcc_compilation)
8441         (within_function, global_sym_chain, global_stabs)
8442         (previous_stab_code, this_object_header_files)
8443         (n_this_object_header_files)
8444         (n_allocated_this_object_header_files): Define.
8445         * stabsread.h (EXTERN): Never define.  Use "extern".
8446
8447 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8448
8449         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8450         history_value.
8451
8452 2019-01-21  Tom Tromey  <tom@tromey.com>
8453
8454         * ui-out.c: Fix includes.
8455         * tui/tui-source.c: Fix includes.
8456         * target.c: Fix includes.
8457         * remote.c: Fix includes.
8458         * regcache.c: Fix includes.
8459         * python/py-block.c: Fix includes.
8460         * printcmd.c: Fix includes.
8461         * or1k-tdep.c: Fix includes.
8462         * mi/mi-main.c: Fix includes.
8463         * m32r-tdep.c: Fix includes.
8464         * csky-tdep.c: Fix includes.
8465         * compile/compile-cplus-types.c: Fix includes.
8466         * cli/cli-interp.c: Fix includes.
8467
8468 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8469
8470         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8471         for padding.
8472
8473 2019-01-16  Tom Tromey  <tom@tromey.com>
8474
8475         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8476         earlier.
8477         (struct objfile) <msymbols_range>: Move from top level.
8478         <msymbols>: New method.
8479         (class objfile_msymbols): Remove.
8480         * symtab.c (default_collect_symbol_completion_matches_break_on):
8481         Update.
8482         * symmisc.c (dump_msymbols): Update.
8483         * stabsread.c (scan_file_globals): Update.
8484         * objc-lang.c (info_selectors_command, info_classes_command)
8485         (find_methods): Update.
8486         * minsyms.c (find_solib_trampoline_target): Update.
8487         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8488         * coffread.c (coff_symfile_read): Update.
8489         * ada-lang.c (ada_lookup_simple_minsym)
8490         (ada_collect_symbol_completion_matches): Update.
8491
8492 2019-01-16  Tom Tromey  <tom@tromey.com>
8493
8494         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8495         type.  Remove no-argument constructor.
8496         <iterator::operator++>: Simplify.
8497         <begin>: Update.
8498         <end>: Use minimal_symbol_count.
8499
8500 2019-01-16  Tom Tromey  <tom@tromey.com>
8501
8502         * objfiles.h (struct objfile) <psymtabs>: New method.
8503         (class objfile_psymtabs): Remove.
8504         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8505         typedef.
8506         <range>: New method.
8507         (require_partial_symbols): Change return type.
8508         * psymtab.c (require_partial_symbols)
8509         (psym_expand_symtabs_matching): Update.
8510         * mdebugread.c (parse_partial_symbols): Update.
8511         * dbxread.c (dbx_end_psymtab): Update.
8512
8513 2019-01-15  Tom Tromey  <tom@tromey.com>
8514
8515         * symtab.c (lookup_objfile_from_block)
8516         (lookup_symbol_in_objfile_symtabs)
8517         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8518         (find_line_symtab, info_sources_command)
8519         (default_collect_symbol_completion_matches_break_on)
8520         (make_source_files_completion_list): Update.
8521         * symmisc.c (print_objfile_statistics, dump_objfile)
8522         (maintenance_print_symbols, maintenance_info_symtabs)
8523         (maintenance_check_symtabs, maintenance_info_line_tables):
8524         Update.
8525         * source.c (select_source_symtab)
8526         (forget_cached_source_info_for_objfile): Update.
8527         * objfiles.h (class objfile_compunits): Remove.
8528         (struct objfile) <compunits_range>: New typedef.
8529         (compunits): New method.
8530         * objfiles.c (objfile_relocate1): Update.
8531         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8532         * maint.c (count_symtabs_and_blocks): Update.
8533         * linespec.c (iterate_over_all_matching_symtabs): Update.
8534         * cp-support.c (add_symbol_overload_list_qualified): Update.
8535         * coffread.c (coff_symtab_read): Update.
8536         * ada-lang.c (add_nonlocal_symbols)
8537         (ada_collect_symbol_completion_matches)
8538         (ada_add_global_exceptions): Update.
8539
8540 2019-01-15  Tom Tromey  <tom@tromey.com>
8541
8542         * progspace.h (program_space) <objfiles_safe_range>: New
8543         typedef.
8544         <objfiles_safe>: New method.
8545         * objfiles.h (class all_objfiles_safe): Remove.
8546         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8547         * jit.c (jit_inferior_exit_hook): Update.
8548
8549 2019-01-17  Tom Tromey  <tom@tromey.com>
8550
8551         * progspace.h (program_space) <objfiles_range>: New typedef.
8552         <objfiles>: New method.
8553         <objfiles_head>: Rename from objfiles.
8554         (object_files): Update.
8555         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8556         * guile/scm-pretty-print.c
8557         (ppscm_find_pretty_printer_from_objfiles): Update.
8558         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8559         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8560         Update.
8561         * python/py-progspace.c (pspy_get_objfiles): Update.
8562         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8563         Update.
8564         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8565         (objfpy_lookup_objfile_by_build_id): Update.
8566         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8567         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8568         Update.
8569         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8570         (expand_symtab_containing_pc, lookup_objfile_from_block)
8571         (lookup_static_symbol, basic_lookup_transparent_type)
8572         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8573         (find_line_symtab, info_sources_command)
8574         (default_collect_symbol_completion_matches_break_on)
8575         (make_source_files_completion_list, find_main_name): Update.
8576         * symmisc.c (print_symbol_bcache_statistics)
8577         (print_objfile_statistics, maintenance_print_symbols)
8578         (maintenance_print_msymbols, maintenance_print_objfiles)
8579         (maintenance_info_symtabs, maintenance_check_symtabs)
8580         (maintenance_expand_symtabs, maintenance_info_line_tables):
8581         Update.
8582         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8583         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8584         (map_overlay_command, unmap_overlay_command)
8585         (simple_overlay_update, expand_symtabs_matching)
8586         (map_symbol_filenames): Update.
8587         * symfile-debug.c (set_debug_symfile): Update.
8588         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8589         Update.
8590         * source.c (select_source_symtab, forget_cached_source_info):
8591         Update.
8592         * solib.c (solib_read_symbols): Update.
8593         * solib-spu.c (append_ocl_sos): Update.
8594         * psymtab.c (maintenance_print_psymbols)
8595         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8596         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8597         * printcmd.c (info_symbol_command): Update.
8598         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8599         Update.
8600         * objfiles.h (class all_objfiles): Remove.
8601         * objfiles.c (have_partial_symbols, have_full_symbols)
8602         (have_minimal_symbols, qsort_cmp, update_section_map)
8603         (shared_objfile_contains_address_p)
8604         (default_iterate_over_objfiles_in_search_order): Update.
8605         * objc-lang.c (info_selectors_command, info_classes_command)
8606         (find_methods): Update.
8607         * minsyms.c (find_solib_trampoline_target): Update.
8608         * maint.c (maintenance_info_sections)
8609         (maintenance_translate_address, count_symtabs_and_blocks):
8610         Update.
8611         * main.c (captured_main_1): Update.
8612         * linux-thread-db.c (try_thread_db_load_from_pdir)
8613         (has_libpthread): Update.
8614         * linespec.c (iterate_over_all_matching_symtabs)
8615         (search_minsyms_for_name): Update.
8616         * jit.c (jit_find_objf_with_entry_addr): Update.
8617         * hppa-tdep.c (find_unwind_entry)
8618         (hppa_lookup_stub_minimal_symbol): Update.
8619         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8620         Update.
8621         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8622         (elf_gnu_ifunc_resolve_by_got): Update.
8623         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8624         * dwarf-index-write.c (save_gdb_index_command): Update.
8625         * cp-support.c (add_symbol_overload_list_qualified): Update.
8626         * breakpoint.c (create_overlay_event_breakpoint)
8627         (create_longjmp_master_breakpoint)
8628         (create_std_terminate_master_breakpoint)
8629         (create_exception_master_breakpoint): Update.
8630         * blockframe.c (find_pc_partial_function): Update.
8631         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8632         (ada_collect_symbol_completion_matches)
8633         (ada_add_global_exceptions): Update.
8634
8635 2019-01-17  Tom Tromey  <tom@tromey.com>
8636
8637         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8638         declare VEC.
8639         (solib_target_parse_libraries): Change return type.
8640         (library_list_start_segment, library_list_start_section)
8641         (library_list_end_library, library_list_start_library); Update.
8642         (solib_target_free_library_list): Remove.
8643         (solib_target_parse_libraries): Remove cleanup.  Change return
8644         type.
8645         (solib_target_current_sos): Update.
8646
8647 2019-01-17  Tom Tromey  <tromey@bapiya>
8648
8649         * valprint.c: Replace "the the" with "the".
8650         * symtab.c: Replace "the the" with "the".
8651         * solib.c: Replace "the the" with "the".
8652         * solib-dsbt.c: Replace "the the" with "the".
8653         * linespec.c: Replace "the the" with "the".
8654         * dwarf2loc.h: Replace "the the" with "the".
8655         * amd64-windows-tdep.c: Replace "the the" with "the".
8656         * aarch64-tdep.c: Replace "the the" with "the".
8657
8658 2019-01-16  Keith Seitz  <keiths@redhat.com>
8659
8660         PR gdb/23773
8661         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8662         <builder>: Rename to ..
8663         <m_builder>: ... this and make private.
8664         (dwarf2_cu::get_builder): New method.  Change all users of
8665         `builder' to use this method.
8666         (dwarf2_start_symtab): Move to ...
8667         (dwarf2_cu::start_symtab): ... here.  Update all callers
8668         (setup_type_unit_groups): Move to ...
8669         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8670         callers.
8671         (dwarf2_cu::reset_builder): New method.
8672         (process_full_compunit, process_full_type_unit): Use
8673         dwarf2_cu::reset_builder.
8674         (follow_die_offset): Record the ancestor CU if it is different
8675         from the followed DIE's CU.
8676         (follow_die_sig_1): Likewise.
8677
8678 2019-01-15  Tom Tromey  <tom@tromey.com>
8679
8680         * remote.c (class remote_state) <buf>: Now a char_vector.
8681         <buf_size>: Remove.
8682         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8683         parameter.
8684         (remote_target::getpkt_or_notif_sane_1)
8685         (remote_target::getpkt_sane)
8686         (remote_target::getpkt_or_notif_sane): Likewise.
8687         (class remote_target) <putpkt>: New overload.
8688         (remote_target::read_frame): Change type of "buf_p".  Remove
8689         sizeof_p parameter.
8690         (packet_ok): New overload.
8691         (packet_check_result): New overload.
8692         Update all uses.
8693
8694 2019-01-14  Tom Tromey  <tom@tromey.com>
8695
8696         * remote-notif.c (handle_notification, remote_notif_ack)
8697         (remote_notif_parse): Make "buf" const.
8698         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8699         const.
8700         (remote_notif_parse, remote_notif_ack, handle_notification):
8701         Likewise.
8702         * remote.c (remote_notif_stop_parse): Make "buf" const.
8703         (remote_target::remote_parse_stop_reply): Make "buf" const.
8704         (remote_notif_stop_ack): Make "buf" const.
8705
8706 2019-01-14  Tom Tromey  <tom@tromey.com>
8707
8708         * remote.c (remote_console_output): Make parameter const.
8709
8710 2019-01-14  Tom Tromey  <tom@tromey.com>
8711
8712         * target-debug.h (target_debug_print_signals): Constify.
8713         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8714         * procfs.c (procfs_target::pass_signals): Update.
8715         * linux-nat.c (linux_nat_target::pass_signals): Update.
8716         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8717         * target-delegates.c: Rebuild.
8718         * remote.c (remote_target::program_signals): Update.
8719         (remote_target::pass_signals): Update.
8720         * target.c (target_pass_signals): Constify argument.
8721         (target_program_signals): Likewise.
8722         * target.h (struct target_ops) <pass_signals, program_signals>:
8723         Constify argument.
8724         (target_pass_signals, target_program_signals): Constify argument.
8725
8726 2019-01-14  Tom Tromey  <tom@tromey.com>
8727
8728         PR tui/28819:
8729         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8730
8731 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8732
8733         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8734         field.
8735         * rs6000-tdep.c: Include reggroups.h.
8736         (IS_V_ALIAS_PSEUDOREG): Define.
8737         (rs6000_register_name): Return names for the "vX" aliases.
8738         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8739         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8740         aliases.  Call default_register_reggroup_p for all other
8741         pseudo-registers.
8742         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8743         New functions.
8744         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8745         Handle "vX" aliases.
8746         (v_alias_pseudo_register_collect): New function.
8747         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8748         (rs6000_gdbarch_init): Initialize "vX" aliases as
8749         pseudo-registers.  Restore registration of
8750         rs6000_pseudo_register_reggroup_p with
8751         set_tdesc_pseudo_register_reggroup_p.
8752
8753 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8754
8755         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8756         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8757         set_gdbarch_num_pseudo_regs.
8758
8759 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8760
8761         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8762         Remove arg prefixname, add do_set and do_show.
8763         Add member functions set_list and show_list.
8764         * cli/cli-style.c (class cli_style_option): Update accordingly.
8765         (style_set_list): Move to file scope.
8766         (style_show_list): Likewise.
8767         (set_style): Call help_list.
8768         (show_style): Call cmd_show_list.
8769         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8770         Update to use the new macro.
8771
8772 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8773
8774         * ada-lang.c (_initialize_ada_language): Expand the help text
8775         for the "catch exception" command.
8776
8777 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8778
8779         * symtab.c (matching_obj_sections): Initialize obj,
8780         declare it closer to its usage.
8781
8782 2019-01-10  Tom Tromey  <tom@tromey.com>
8783
8784         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8785         (basic_inf_threads_range): Remove.
8786         (inf_threads_range, inf_non_exited_threads_range)
8787         (safe_inf_threads_range): Use next_adapter.
8788
8789 2019-01-10  Keith Seitz  <keiths@redhat.com>
8790
8791         PR gdb/23712
8792         PR symtab/23010
8793         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8794         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8795
8796 2019-01-10  Keith Seitz  <keiths@redhat.com>
8797
8798         PR gdb/23712
8799         PR symtab/23010
8800         * dictionary.c (pending_to_vector): Remove.
8801         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8802         Remove _1 suffix, replacing functions of the same name.  Update
8803         all callers.
8804         (dict_create_hashed, dict_create_hashed_expandable)
8805         (dict_create_linear, dict_create_linear_expandable, dict_free)
8806         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8807         Make functions static.
8808
8809 2019-01-10  Keith Seitz  <keiths@redhat.com>
8810
8811         PR gdb/23712
8812         PR symtab/23010
8813         * dictionary.h (struct dictionary): Replace declaration with
8814         multidictionary.
8815         (dict_create_hashed, dict_create_hashed_expandable)
8816         (dict_create_linear, dict_create_linear_expandable)
8817         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8818         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8819         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8820         taking multidictionary argument.
8821         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8822         * block.h (struct block) <dict>: Change to multidictionary
8823         and rename `multidict'.
8824         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8825         symmisc.c: Update all dictionary references to multidictionary.
8826
8827 2019-01-10  Keith Seitz  <keiths@redhat.com>
8828
8829         PR gdb/23712
8830         PR symtab/23010
8831         * dictionary.c: Include unordered_map.
8832         (pending_to_vector): New function.
8833         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8834         Rewrite the non-"_1" functions to take vector instead
8835         of linked list.
8836         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8837         "new" _1 versions of the same name.
8838         (multidictionary): Define.
8839         (std::hash<enum language): New definition.
8840         (collate_pending_symbols_by_language, mdict_create_hashed)
8841         (mdict_create_hashed_expandable, mdict_create_linear)
8842         (mdict_create_linear_expandable, mdict_free)
8843         (find_language_dictionary, create_new_language_dictionary)
8844         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8845         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8846         (mdict_size, mdict_empty): New functions.
8847         * dictionary.h (mdict_iterator): Define.
8848
8849 2019-01-10  Pedro Alves  <palves@redhat.com>
8850
8851         * breakpoint.c (read_uploaded_action)
8852         (create_tracepoint_from_upload): Adjust to use
8853         gdb::unique_xmalloc_ptr.
8854         * ctf.c (ctf_write_uploaded_tp):
8855         (SET_ARRAY_FIELD): Use emplace_back.
8856         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8857         * tracefile-tfile.c (tfile_write_uploaded_tp):
8858         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8859         gdb::unique_xmalloc_ptr.
8860         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8861         at_string, cond_string, cmd_strings>: Replace char pointers
8862         with gdb::unique_xmalloc_ptr.
8863
8864 2019-01-10  Pedro Alves  <palves@redhat.com>
8865
8866         * solib-target.c (library_list_start_library): Don't xstrdup name.
8867
8868 2019-01-10  Pedro Alves  <palves@redhat.com>
8869
8870         * mdebugread.c (parse_partial_symbols): Use
8871         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8872
8873 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8874
8875         * linux-fork.c (scoped_switch_fork_info)
8876         <~scoped_switch_fork_info>: Fix incorrect variable name.
8877
8878 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8879
8880         * linux-fork.c (scoped_switch_fork_info)
8881         <scoped_switch_fork_info>: Make explicit.
8882         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8883
8884 2019-01-10  Tom Tromey  <tom@tromey.com>
8885
8886         * objfiles.h (objfile::reset_psymtabs): Update.
8887         * objfiles.c (objfile::objfile): Update.
8888         * psymtab.h (psymtab_storage::obstack): Update.
8889         (psymtab_storage::m_obstack): Use gdb::optional.
8890         (class psymtab_storage): Update comment.  Remove objfile
8891         parameter.
8892         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8893
8894 2019-01-10  Tom Tromey  <tom@tromey.com>
8895
8896         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8897         <free_psymtabs>: Now private.
8898         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8899         (allocate_psymtab): Use new method.
8900
8901 2019-01-10  Tom Tromey  <tom@tromey.com>
8902
8903         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8904         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8905         * mdebugread.c (parse_partial_symbols): Use
8906         allocate_dependencies.
8907         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8908         allocate_dependencies.
8909         (process_psymtab_comp_unit_reader)
8910         (build_type_psymtab_dependencies): Likewise.
8911         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8912
8913 2019-01-10  Tom Tromey  <tom@tromey.com>
8914
8915         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8916         PSYMBOL_SET_LANGUAGE.
8917         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8918
8919 2019-01-10  Tom Tromey  <tom@tromey.com>
8920
8921         * psymtab.h (psymtab_storage::obstack): New method.
8922         <m_obstack>: Rename from obstack; now private.
8923         * psymtab.c (psymtab_storage): Update.
8924         * dwarf2read.c (create_addrmap_from_index)
8925         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8926         Update.
8927
8928 2019-01-10  Tom Tromey  <tom@tromey.com>
8929
8930         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8931         * objfiles.h (objfile::reset_psymtabs): New method.
8932
8933 2019-01-10  Tom Tromey  <tom@tromey.com>
8934
8935         * symmisc.c (print_symbol_bcache_statistics): Update.
8936         (print_objfile_statistics): Update.
8937         * symfile.c (reread_symbols): Update.
8938         * psymtab.h (class psymtab_storage): New.
8939         * psymtab.c (psymtab_storage): New constructor.
8940         (~psymtab_storage): New destructor.
8941         (require_partial_symbols): Update.
8942         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8943         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8944         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8945         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8946         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8947         (start_psymtab_common, end_psymtab_common)
8948         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8949         (allocate_psymtab): Update.
8950         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8951         Update.
8952         (dump_psymtab_addrmap, maintenance_print_psymbols)
8953         (maintenance_check_psymtabs): Update.
8954         (class objfile_psymtabs): Move to objfiles.h.
8955         * psympriv.h (discard_psymtab): Now inline.
8956         (psymtab_discarder::psymtab_discarder): Update.
8957         (psymtab_discarder::~psymtab_discarder): Update.
8958         (ALL_OBJFILE_PSYMTABS): Rewrite.
8959         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8960         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8961         Remove fields.
8962         <partial_symtabs>: New field.
8963         (class objfile_psymtabs): Move from psymtab.h.  Update.
8964         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8965         psymbol_cache.
8966         (objfile::~objfile): Don't destroy psymbol_cache.
8967         * mdebugread.c (parse_partial_symbols): Update.
8968         * dwarf2read.c (create_addrmap_from_index)
8969         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8970         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8971         (add_partial_subprogram, dwarf2_ranges_read): Update.
8972         * dwarf-index-write.c (write_address_map)
8973         (write_one_signatured_type, recursively_write_psymbols)
8974         (class debug_names, class debug_names, write_psymtabs_to_index):
8975         Update.
8976
8977 2019-01-10  Tom Tromey  <tom@tromey.com>
8978
8979         * symtab.h (SYMBOL_SET_NAMES): Update.
8980         (symbol_set_names): Update.
8981         (MSYMBOL_SET_NAMES): Update.
8982         * symtab.c (symbol_set_names): Change argument to be an
8983         objfile_per_bfd_storage.
8984         * psymtab.c (add_psymbol_to_bcache): Update.
8985         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8986
8987 2019-01-10  Tom Tromey  <tom@tromey.com>
8988
8989         * symtab.c (create_demangled_names_hash): Change argument to be an
8990         objfile_per_bfd_storage.
8991         (symbol_set_names): Update.
8992
8993 2019-01-10  Tom Tromey  <tom@tromey.com>
8994
8995         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8996         init_psymbol_list.
8997         * psymtab.c (init_psymbol_list): Do nothing if already called.
8998         * psympriv.h (init_psymbol_list): Add comment.
8999         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9000         init_psymbol_list.
9001         * dbxread.c (dbx_symfile_read): Unconditionally call
9002         init_psymbol_list.
9003
9004 2019-01-10  Tom Tromey  <tom@tromey.com>
9005
9006         * xcoffread.c (scan_xcoff_symtab): Update.
9007         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9008         "where".
9009         * mdebugread.c (parse_partial_symbols)
9010         (handle_psymbol_enumerators): Update.
9011         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9012         * dbxread.c (read_dbx_symtab): Update.
9013         * psympriv.h (psymbol_placement): New enum.
9014         (add_psymbol_to_list): Update.
9015
9016 2019-01-10  Tom Tromey  <tom@tromey.com>
9017
9018         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9019         static_psymbols parameters.
9020         (scan_xcoff_symtab): Update.
9021         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9022         static_psymbols parameters.
9023         * psympriv.h (start_psymtab_common): Update.
9024         * mdebugread.c (parse_partial_symbols): Update.
9025         * dwarf2read.c (create_partial_symtab): Update.
9026         * dbxread.c (read_dbx_symtab): Update.
9027         (start_psymtab): Remove global_psymbols and static_psymbols
9028         parameters.
9029
9030 2019-01-10  Tom Tromey  <tom@tromey.com>
9031
9032         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9033         * psymtab.c (allocate_psymtab): Add comment.
9034         * psympriv.h (allocate_psymtab): Add comment.
9035         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9036         initializations.
9037         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9038
9039 2019-01-10  Tom Tromey  <tom@tromey.com>
9040
9041         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9042         Don't declare.
9043         * mipsread.c: Include mdebugread.h.
9044         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9045         Declare.
9046         * elfread.c: Include mdebugread.h.
9047
9048 2019-01-09  Tom Tromey  <tom@tromey.com>
9049
9050         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9051         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9052         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9053         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9054         (psym_lookup_symbol, psym_find_last_source_symtab)
9055         (psym_forget_cached_source_info, psym_print_stats)
9056         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9057         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9058         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9059         (psym_find_compunit_symtab_by_address)
9060         (maintenance_print_psymbols, maintenance_info_psymtabs)
9061         (maintenance_check_psymtabs): Use ranged for.
9062         * psymtab.h (class objfile_psymtabs): New.
9063         (require_partial_symbols): Return objfile_psymtabs.
9064         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9065
9066 2019-01-09  Tom Tromey  <tom@tromey.com>
9067
9068         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9069         (find_pc_mapped_section, list_overlays_command)
9070         (map_overlay_command, unmap_overlay_command)
9071         (simple_overlay_update): Use all_objfiles.
9072         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9073         * printcmd.c (info_symbol_command): Use all_objfiles.
9074         * objfiles.h (ALL_OBJSECTIONS): Remove.
9075         * maint.c (maintenance_translate_address): Use all_objfiles.
9076         * gcore.c (gcore_create_callback): Use all_objfiles.
9077         (objfile_find_memory_regions): Likewise.
9078
9079 2019-01-09  Tom Tromey  <tom@tromey.com>
9080
9081         * symtab.c (find_line_symtab, info_sources_command)
9082         (make_source_files_completion_list): Use objfile_compunits.
9083         * source.c (select_source_symtab): Use objfile_compunits.
9084         * objfiles.h (struct objfile): Update comment.
9085         (ALL_OBJFILES): Remove.
9086         (ALL_FILETABS): Remove.
9087         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9088         objfile_compunits.
9089
9090 2019-01-09  Tom Tromey  <tom@tromey.com>
9091
9092         * symmisc.c (print_objfile_statistics, dump_objfile)
9093         (maintenance_print_symbols): Use compunit_filetabs.
9094         * source.c (forget_cached_source_info_for_objfile): Use
9095         compunit_filetabs.
9096         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9097         (ALL_FILETABS): Use compunit_filetabs.
9098         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9099         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9100
9101 2019-01-09  Tom Tromey  <tom@tromey.com>
9102
9103         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9104         (compunit_filetabs): New.
9105         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9106         compunit_filetabs.
9107         (info_sources_command, make_source_files_completion_list): Remove
9108         declaration.
9109         * symmisc.c (print_objfile_statistics, dump_objfile)
9110         (maintenance_print_symbols): Remove declaration.
9111         (maintenance_info_symtabs): Use compunit_filetabs.
9112         (maintenance_info_line_tables): Likewise.
9113         * source.c (select_source_symtab): Change local variable name.
9114         (forget_cached_source_info_for_objfile): Remove declaration.
9115         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9116         * objfiles.c (objfile_relocate1): Remove declaration.
9117         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9118         declaration.
9119         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9120         * coffread.c (coff_symtab_read): Remove declaration.
9121         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9122         compunit_filetabs.
9123
9124 2019-01-09  Tom Tromey  <tom@tromey.com>
9125
9126         * symtab.c (lookup_objfile_from_block)
9127         (find_pc_sect_compunit_symtab, search_symbols)
9128         (default_collect_symbol_completion_matches_break_on): Use
9129         objfile_compunits.
9130         * objfiles.h (ALL_COMPUNITS): Remove.
9131         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9132         * cp-support.c (add_symbol_overload_list_qualified): Use
9133         objfile_compunits.
9134         * ada-lang.c (ada_collect_symbol_completion_matches)
9135         (ada_add_global_exceptions): Use objfile_compunits.
9136
9137 2019-01-09  Tom Tromey  <tom@tromey.com>
9138
9139         * source.c (select_source_symtab)
9140         (forget_cached_source_info_for_objfile): Remove declaration.
9141         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9142         declaration.
9143         * maint.c (count_symtabs_and_blocks): Remove declaration.
9144         * cp-support.c (add_symbol_overload_list_qualified): Remove
9145         declaration.
9146         * coffread.c (coff_symtab_read): Remove declaration.
9147         * symtab.c (lookup_symbol_in_objfile_symtabs)
9148         (basic_lookup_transparent_type_1): Use objfile_compunits.
9149         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9150         (info_sources_command, search_symbols)
9151         (default_collect_symbol_completion_matches_break_on)
9152         (make_source_files_completion_list): Remove declaration.
9153         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9154         (ada_collect_symbol_completion_matches)
9155         (ada_add_global_exceptions): Remove declaration.
9156         * linespec.c (iterate_over_all_matching_symtabs): Use
9157         objfile_compunits.
9158         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9159         (class objfile_compunits): New.
9160         (ALL_COMPUNITS): Use objfile_compunits.
9161         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9162         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9163         objfile_compunits.
9164         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9165
9166 2019-01-09  Tom Tromey  <tom@tromey.com>
9167
9168         * symtab.c (search_symbols)
9169         (default_collect_symbol_completion_matches_break_on): Use
9170         objfile_msymbols.
9171         * ada-lang.c (ada_lookup_simple_minsym)
9172         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9173         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9174         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9175         objfile_msymbols.
9176         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9177         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9178         * objc-lang.c (find_methods): Use objfile_msymbols.
9179         (info_selectors_command, info_classes_command): Likewise.
9180         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9181         * objfiles.h (class objfile_msymbols): New.
9182         (ALL_OBJFILE_MSYMBOLS): Remove.
9183         (ALL_MSYMBOLS): Remove.
9184
9185 2019-01-09  Tom Tromey  <tom@tromey.com>
9186
9187         * common/next-iterator.h (next_adapter): Add Iterator template
9188         parameter.
9189         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9190         (class all_objfiles_safe): New.
9191         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9192         * objfiles.c (put_objfile_before): Update comment.
9193         (add_separate_debug_objfile): Likewise.
9194         (free_all_objfiles): Use all_objfiles_safe.
9195         (objfile_purge_solibs): Likewise.
9196
9197 2019-01-09  Tom Tromey  <tom@tromey.com>
9198
9199         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9200         (expand_symtab_containing_pc, lookup_static_symbol)
9201         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9202         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9203         all_objfiles.
9204         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9205         * breakpoint.c (create_overlay_event_breakpoint)
9206         (create_longjmp_master_breakpoint)
9207         (create_std_terminate_master_breakpoint)
9208         (create_exception_master_breakpoint): Use all_objfiles.
9209         * linux-thread-db.c (try_thread_db_load_from_pdir)
9210         (has_libpthread): Use all_objfiles.
9211         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9212         * linespec.c (iterate_over_all_matching_symtabs)
9213         (search_minsyms_for_name): Use all_objfiles.
9214         * maint.c (maintenance_info_sections): Use all_objfiles.
9215         * main.c (captured_main_1): Use all_objfiles.
9216         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9217         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9218         * guile/scm-pretty-print.c
9219         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9220         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9221         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9222         (maintenance_print_msymbols): Use all_objfiles.
9223         * source.c (select_source_symtab): Use all_objfiles.
9224         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9225         * symfile.c (remove_symbol_file_command)
9226         (expand_symtabs_matching, map_symbol_filenames): Use
9227         all_objfiles.
9228         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9229         all_objfiles.
9230         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9231         * objc-lang.c (find_methods): Use all_objfiles.
9232         * objfiles.c (have_partial_symbols, have_full_symbols)
9233         (have_minimal_symbols, qsort_cmp)
9234         (default_iterate_over_objfiles_in_search_order): Use
9235         all_objfiles.
9236         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9237         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9238         (maintenance_check_psymtabs): Use all_objfiles.
9239         (ALL_PSYMTABS): Remove.
9240         * compile/compile-object-run.c (do_module_cleanup): Use
9241         all_objfiles.
9242         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9243         * cp-support.c (add_symbol_overload_list_qualified): Use
9244         all_objfiles.
9245         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9246         Use all_objfiles.
9247         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9248         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9249         all_objfiles.
9250         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9251         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9252         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9253         Uses all_objfiles.
9254         * solib.c (solib_read_symbols): Use all_objfiles
9255
9256 2019-01-09  Tom Tromey  <tom@tromey.com>
9257
9258         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9259         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9260         all_objfiles.
9261         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9262         * symmisc.c (print_symbol_bcache_statistics)
9263         (print_objfile_statistics, maintenance_print_objfiles)
9264         (maintenance_info_symtabs, maintenance_check_symtabs)
9265         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9266         all_objfiles.
9267         * source.c (forget_cached_source_info): Use all_objfiles.
9268         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9269         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9270         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9271         * objfiles.c (update_section_map): Use all_objfiles.
9272         (shared_objfile_contains_address_p): Likewise.
9273         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9274         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9275
9276 2019-01-09  Tom Tromey  <tom@tromey.com>
9277
9278         * common/next-iterator.h: New file.
9279         * objfiles.h (class all_objfiles): New.
9280         (struct objfile_iterator): New.
9281
9282 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9283
9284         * NEWS: Move the description of the changed "frame", "select-frame",
9285          and "info frame" commands to the Changed commands section.
9286
9287 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9288
9289         * gdbtypes.c (check_stub_method_group): Remove handling of old
9290         mangling schemes.
9291         * linespec.c (find_methods): Likewise.
9292         * stabsread.c (read_member_functions): Likewise.
9293         * valops.c (search_struct_method): Likewise.
9294         (value_struct_elt_for_reference): Likewise.
9295         * NEWS: Mention this change.
9296
9297 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9298
9299         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9300         print_source_lines.
9301         * source.c (print_source_lines_base): Update line number check.
9302         (print_source_lines): New function.
9303         (source_lines_range::source_lines_range): New function.
9304         * source.h (class source_lines_range): New class.
9305         (print_source_lines): New declaration.
9306
9307 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9308
9309         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9310
9311 2019-01-08  Tom Tromey  <tom@tromey.com>
9312             Simon Marchi  <simon.marchi@ericsson.com>
9313
9314         PR gdb/24060
9315         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9316         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9317         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9318         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9319         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9320         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9321
9322 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9323
9324         * source.c (select_source_symtab): Move header comment to
9325         declaration in source.h.
9326         (forget_cached_source_info_for_objfile): Likewise.
9327         (forget_cached_source_info): Likewise.
9328         (identify_source_line): Likewise.
9329         * source.h (identify_source_line): Move declaration from symtab.h
9330         and add comment from source.c
9331         (print_source_lines): Likewise.
9332         (forget_cached_source_info_for_objfile): Likewise.
9333         (forget_cached_source_info): Likewise.
9334         (select_source_symtab): Likewise.
9335         (enum print_source_lines_flag): Move definition from symtab.h.
9336         * symtab.h (identify_source_line): Move declaration to source.h.
9337         (print_source_lines): Likewise.
9338         (forget_cached_source_info_for_objfile): Likewise.
9339         (forget_cached_source_info): Likewise.
9340         (select_source_symtab): Likewise.
9341         (enum print_source_lines_flag): Move definition to source.h.
9342         * tui/tui-hooks.c: Add 'source.h' include.
9343
9344 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9345
9346         * source.c (print_source_lines_base): Handle requests to print
9347         reverse line number sequences, and guard against empty lines
9348         string.
9349
9350 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9351
9352         * source.c (print_source_lines_base): Fix skip of '\r' if next
9353         character is '\n'.
9354
9355 2019-01-06  Tom Tromey  <tom@tromey.com>
9356
9357         * c-exp.y (struct c_parse_state) <macro_original_text,
9358         expansion_obstack>: New member.
9359         (macro_original_text, expansion_obstack): Remove globals.
9360         (scan_macro_expansion, scanning_macro_expansion)
9361         (finished_macro_expansion): Update.
9362         (scan_macro_cleanup): Remove.
9363         (yylex, c_parse): Update.
9364
9365 2019-01-06  Tom Tromey  <tom@tromey.com>
9366
9367         * c-exp.y (struct c_parse_state) <strings>: New member.
9368         (operator_stoken): Update.
9369
9370 2019-01-06  Tom Tromey  <tom@tromey.com>
9371
9372         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9373         (union type_stack_elt) <typelist_val>: Now a pointer to
9374         std::vector.
9375         (type_stack_cleanup): Don't declare.
9376         (push_typelist): Update.
9377         * parse.c (pop_typelist): Return a std::vector.
9378         (push_typelist): Take a std::vector.
9379         (follow_types): Update.  Do not free args.
9380         (type_stack_cleanup): Remove.
9381         * c-exp.y (struct c_parse_state): New.
9382         (cpstate): New global.
9383         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9384         (nonempty_typelist): Update.
9385         (func_mod): Create a new vector.
9386         (c_parse): Create a c_parse_state.
9387         (check_parameter_typelist): Do not delete params.
9388         (function_method): Update.  Do not delete type_list.
9389
9390 2019-01-06  Tom Tromey  <tom@tromey.com>
9391
9392         PR gdb/28155:
9393         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9394         check_typedef.
9395         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9396         (print_return_value): Likewise.
9397
9398 2019-01-05  Tom Tromey  <tom@tromey.com>
9399
9400         * contrib/cleanup_check.py: Remove.
9401         * contrib/gcc-with-excheck: Remove.
9402         * contrib/exsummary.py: Remove.
9403         * contrib/excheck.py: Remove.
9404
9405 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9406
9407         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9408         NULL. Initialize tpprev to NULL instead of assigning it
9409         to NULL on the next statement.
9410         * windows-nat.c (windows_delete_thread): Remove check for
9411         main_thread_id before printing thread exit notifications.
9412         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9413         Remove thread ID check against main_thread_id.
9414         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9415         windows_delete_thread.
9416         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9417
9418 2019-01-04  Tom Tromey  <tom@tromey.com>
9419
9420         * compile/compile.c (_initialize_compile): Use upper case for
9421         metasyntactic variables.
9422         * symmisc.c (_initialize_symmisc): Use upper case for
9423         metasyntactic variables.
9424         * psymtab.c (_initialize_psymtab): Use upper case for
9425         metasyntactic variables.
9426         * demangle.c (demangle_command): Use upper case for metasyntactic
9427         variables.
9428         (_initialize_demangler): Likewise.
9429         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9430         variables.
9431
9432 2019-01-03  Tom Tromey  <tom@tromey.com>
9433
9434         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9435
9436 2019-01-03  Tom Tromey  <tom@tromey.com>
9437
9438         * python/py-symtab.c (salpy_str): Update.
9439         (struct salpy_sal_object) <symtab>: Now a PyObject.
9440         (salpy_dealloc): Update.
9441         (del_objfile_sal): Use gdbpy_ref.
9442
9443 2019-01-03  Tom Tromey  <tom@tromey.com>
9444
9445         * python/py-type.c (convert_field): Use new_reference.  Return
9446         gdbpy_ref.
9447         (make_fielditem): Return gdbpy_ref.
9448         (typy_fields): Update.
9449         (typy_getitem): Update.
9450         (field_name): Return gdbpy_ref.  Use new_reference.
9451         (typy_iterator_iternext): Update.
9452
9453 2019-01-03  Tom Tromey  <tom@tromey.com>
9454
9455         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9456
9457 2019-01-03  Tom Tromey  <tom@tromey.com>
9458
9459         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9460         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9461         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9462         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9463         (pspy_set_type_printers): Likewise.
9464         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9465         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9466         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9467         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9468         (objfpy_set_type_printers): Likewise.
9469
9470 2019-01-03  Tom Tromey  <tom@tromey.com>
9471
9472         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9473         (gdbpy_print_stack): Use gdbpy_err_fetch.
9474         * python/python-internal.h (class gdbpy_err_fetch): New class.
9475         (class gdbpy_enter) <m_error_type, m_error_value,
9476         m_error_traceback>: Remove.
9477         <m_error>: New member.
9478         (gdbpy_exception_to_string): Don't declare.
9479         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9480         * python/py-value.c (convert_value_from_python): Use
9481         gdbpy_err_fetch.
9482         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9483         gdbpy_exception_to_string.
9484         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9485         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9486         gdbpy_err_fetch.
9487
9488 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9489
9490         * linux-nat.c (delete_lwp_cleanup): Delete.
9491         (struct lwp_deleter): New struct.
9492         (lwp_info_up): New typedef.
9493         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9494         lwp_info_up.
9495
9496 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9497
9498         * linux-fork.c (class scoped_switch_fork_info): New class.
9499         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9500
9501 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9502
9503         * valops.c (find_overload_match): Remove use of null_cleanup, and
9504         calls to do_cleanups.
9505
9506 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9507
9508         * compile/compile-cplus-types.c
9509         (compile_cplus_instance::decl_name): Handle changes to
9510         cp_func_name.
9511         * cp-support.c (cp_func_name): Update header comment, update
9512         return type.
9513         * cp-support.h (cp_func_name): Update return type in declaration.
9514         * valops.c (find_overload_match): Move temp_func local to top
9515         level of function and change its type.  Use temp_func to hold and
9516         delete temporary string obtained from cp_func_name.
9517
9518 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9519
9520         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9521         gdb::char_vector, remove cleanup, and update uses of `msg`.
9522
9523 2019-01-03  Jim Wilson  <jimw@sifive.com>
9524
9525         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9526
9527 2019-01-02  Tom Tromey  <tom@tromey.com>
9528
9529         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9530         (tdesc_parse_xml): Remove cleanups.
9531         * target-descriptions.h (make_cleanup_free_target_description):
9532         Don't declare.
9533         (target_desc_deleter): New struct.
9534         (target_desc_up): New typedef.
9535         * target-descriptions.c (target_desc_deleter::operator()): Rename
9536         from free_target_description.
9537         (make_cleanup_free_target_description): Remove.
9538
9539 2019-01-02  Tom Tromey  <tom@tromey.com>
9540
9541         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9542         constructor, destructor.
9543         (linespec_parser): Remove typedef.
9544         (~linespec_parser): Rename from linespec_parser_delete.
9545         (linespec_lex_to_end, linespec_complete_label)
9546         (linespec_complete): Update.
9547         (decode_line_full): Remove cleanups.
9548         (decode_line_1): Update.
9549
9550 2019-01-02  Tom Tromey  <tom@tromey.com>
9551
9552         * python/python-internal.h (inferior_to_inferior_object): Change
9553         return type.
9554         * python/py-exitedevent.c (create_exited_event_object): Update.
9555         * python/py-inferior.c (inferior_to_inferior_object): Return
9556         gdbpy_ref.
9557         (python_new_inferior, python_inferior_deleted)
9558         (thread_to_thread_object, delete_thread_object)
9559         (build_inferior_list, gdbpy_selected_inferior): Update.
9560         * python/py-infthread.c (create_thread_object): Update.  Also fail
9561         if inferior_to_inferior_object fails.
9562
9563 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9564
9565         * inferior.h (class inferior) <displaced_step_state>: New field.
9566         * infrun.h (struct displaced_step_state): Move here from
9567         infrun.c.  Initialize fields, add constructor.
9568         <inf>: Remove field.
9569         <reset>: New method.
9570         * infrun.c (struct displaced_step_inferior_state): Move to
9571         infrun.h.
9572         (displaced_step_inferior_states): Remove.
9573         (get_displaced_stepping_state): Adust.
9574         (displaced_step_in_progress_any_inferior): Adjust.
9575         (displaced_step_in_progress_thread): Adjust.
9576         (displaced_step_in_progress): Adjust.
9577         (add_displaced_stepping_state): Remove.
9578         (get_displaced_step_closure_by_addr): Adjust.
9579         (remove_displaced_stepping_state): Remove.
9580         (infrun_inferior_exit): Call displaced_step_state.reset.
9581         (use_displaced_stepping): Don't check for NULL.
9582         (displaced_step_prepare_throw): Call
9583         get_displaced_stepping_state.
9584         (displaced_step_fixup): Don't check for NULL.
9585         (prepare_for_detach): Don't check for NULL.
9586
9587 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9588
9589         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9590          in case of call that did not complete.
9591
9592 2019-01-02  Andrey Utkin  <autkin@undo.io>
9593
9594         * symfile.c (find_separate_debug_file): Fix search of debug files for
9595         remote debuggee.
9596
9597 2019-01-02  Tom Tromey  <tom@tromey.com>
9598
9599         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9600         indentation.
9601         * python/py-frame.c (frapy_older): Remove cast.
9602         (frapy_newer): Likewise.
9603         * python/py-breakpoint.c (local_setattro): Remove cast.
9604         * python/py-arch.c (archpy_name): Remove local variable.
9605         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9606
9607 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9608
9609         * unittests/basic_string_view/element_access/char/empty.cc:
9610         Fix year range in copyright header.
9611
9612 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9613
9614         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9615         Delete.
9616         <operator==>: Update with for removed field.
9617         <hash>: Likewise.
9618         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9619         <isa_features>: ...this.
9620         <abi_features>: New field.
9621         (riscv_isa_flen): Update comment.
9622         (riscv_abi_xlen): New declaration.
9623         (riscv_abi_flen): New declaration.
9624         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9625         isa_features.
9626         (riscv_abi_xlen): New function.
9627         (riscv_isa_flen): Update to get answer from isa_features.
9628         (riscv_abi_flen): New function.
9629         (riscv_has_fp_abi): Update to get answer from abi_features.
9630         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9631         xlen and flen.
9632         (riscv_call_info) <xlen, flen>: Update comment.
9633         (riscv_call_arg_struct): Remove invalid assertions
9634         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9635         is removed.
9636         (riscv_gdbarch_init): Gather isa features and abi features
9637         separately, ensure both match on the gdbarch when reusing an old
9638         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9639         a target with 64-bit float hardware.
9640
9641 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9642
9643         * source.c (search_command_helper): Stop reverse search
9644         when line 1 has been searched.
9645
9646 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9647
9648         * record-full.c (record_full_base_target::close): Rewrite
9649         record_full_core_buf_list free logic.
9650
9651 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9652
9653         * break-catch-syscall.c (print_one_catch_syscall): xfree
9654         the last text.
9655
9656 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9657
9658         * top.c (print_gdb_version): Update Copyright year in version
9659         message.
9660
9661 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9662
9663         Update copyright year range in all GDB files.
9664
9665 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9666
9667         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9668
9669 For older changes see ChangeLog-2018.
9670 \f
9671 Local Variables:
9672 mode: change-log
9673 left-margin: 8
9674 fill-column: 74
9675 version-control: never
9676 coding: utf-8
9677 End:
9678