gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-source.c (tui_source_window): New constructor.  Add
   4         observer.
   5         (~tui_source_window): New destructor.
   6         (tui_source_window::style_changed): New method.
   7         * tui/tui-hooks.c (tui_redisplay_source): Remove.
   8         (tui_attach_detach_observers): Update.
   9         * tui/tui-data.h (struct tui_source_window): Make constructor not
  10         inline.  Add destructor.
  11         (struct tui_source_window) <style_changed>: New method.
  12         <m_observable>: New member.
  13
  14 2019-07-17  Tom Tromey  <tom@tromey.com>
  15
  16         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
  17         * tui/tui-win.c (tui_resize_all): Fix typo.
  18
  19 2019-07-17  Tom Tromey  <tom@tromey.com>
  20
  21         * tui/tui-wingeneral.h (tui_refresh_all): Update.
  22         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
  23         (tui_refresh_all): Remove "list" parameter.  Use foreach.
  24         * tui/tui-win.c (window_name_completer): Use foreach.
  25         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
  26         (update_tab_width): Likewise.
  27         * tui/tui-layout.c (show_layout): Update.
  28         * tui/tui-data.h (class tui_window_iterator): New.
  29         (struct all_tui_windows): New.
  30         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
  31
  32 2019-07-17  Tom Tromey  <tom@tromey.com>
  33
  34         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
  35         parameter.  Don't reference globals.
  36         (tui_reg_command): Update.
  37
  38 2019-07-17  Tom Tromey  <tom@tromey.com>
  39
  40         * tui/tui-regs.c (tui_show_registers): Simplify.
  41
  42 2019-07-17  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui-regs.c (tui_show_registers): Update.
  45         (tui_show_register_group): Add win_info parameter.
  46
  47 2019-07-17  Tom Tromey  <tom@tromey.com>
  48
  49         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
  50         Rename from tui_display_reg_element_at_line.
  51         (tui_data_window::display_registers_from_line): Update.
  52         * tui/tui-data.h (struct tui_data_window)
  53         <display_reg_element_at_line>: New method.
  54
  55 2019-07-17  Tom Tromey  <tom@tromey.com>
  56
  57         * tui/tui-regs.h (tui_display_registers_from)
  58         (tui_display_registers_from_line): Don't declare.
  59         * tui/tui-windata.c (tui_data_window::display_all_data)
  60         (tui_data_window::refresh_all)
  61         (tui_data_window::do_scroll_vertical): Update.
  62         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
  63         from tui_display_registers_from.
  64         (tui_display_reg_element_at_line): Update.
  65         (tui_data_window::display_registers_from_line): Rename from
  66         tui_display_registers_from_line.
  67         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
  68         display_registers_from_line>: New methods.
  69
  70 2019-07-17  Tom Tromey  <tom@tromey.com>
  71
  72         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
  73         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
  74         from tui_erase_data_content.
  75         (tui_data_window::display_all_data)
  76         (tui_data_window::refresh_all)
  77         (tui_data_window::do_scroll_vertical): Update.
  78         * tui/tui-regs.c (tui_show_registers): Update.
  79         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
  80         New method.
  81
  82 2019-07-17  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
  85         declare.
  86         * tui/tui-windata.c
  87         (tui_data_window::delete_data_content_windows): Rename from
  88         tui_delete_data_content_windows.
  89         (tui_data_window::display_all_data)
  90         (tui_data_window::do_scroll_vertical): Update.
  91         * tui/tui-data.h (struct tui_data_window)
  92         <delete_data_content_windows>: New method.
  93
  94 2019-07-17  Tom Tromey  <tom@tromey.com>
  95
  96         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
  97         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
  98
  99 2019-07-17  Tom Tromey  <tom@tromey.com>
 100
 101         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 102         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 103         from tui_display_all_data.
 104         * tui/tui-win.c
 105         (tui_data_window::do_make_visible_with_new_height): Update.
 106         * tui/tui-regs.c (tui_show_registers): Update.
 107         * tui/tui-layout.c (tui_set_layout): Update.
 108         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 109         method.
 110
 111 2019-07-17  Tom Tromey  <tom@tromey.com>
 112
 113         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 114         * tui/tui-windata.c (tui_display_data_from): Remove.
 115         (tui_data_window::refresh_all): Update.
 116
 117 2019-07-17  Tom Tromey  <tom@tromey.com>
 118
 119         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 120         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 121         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 122         tui_display_registers_from_line.
 123         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 124         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 125         "force_display" parameter.
 126
 127 2019-07-17  Tom Tromey  <tom@tromey.com>
 128
 129         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 130         declare.
 131         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 132         Rename from tui_first_reg_element_no_inline.
 133         (tui_display_reg_element_at_line)
 134         (tui_display_registers_from_line): Update.
 135         * tui/tui-data.h (struct tui_data_window)
 136         <first_reg_element_no_inline>: New method.
 137
 138 2019-07-17  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-windata.c (tui_display_data_from)
 141         (tui_data_window::do_scroll_vertical): Update.
 142         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 143         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 144         Rename from tui_line_from_reg_element_no.
 145         (tui_display_registers_from_line): Update.
 146         * tui/tui-data.h (struct tui_data_window)
 147         <line_from_reg_element_no>: New method.
 148
 149 2019-07-17  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 152         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 153         tui_last_regs_line_no.
 154         (tui_display_reg_element_at_line)
 155         (tui_display_registers_from_line): Update.
 156         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 157         method.
 158
 159 2019-07-17  Tom Tromey  <tom@tromey.com>
 160
 161         PR tui/24722:
 162         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 163         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 164         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 165         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 166         (tui_update_breakpoint_info): Likewise.
 167         * tui/tui-hooks.c (tui_event_create_breakpoint)
 168         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 169         Update.
 170
 171 2019-07-17  Tom Tromey  <tom@tromey.com>
 172
 173         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 174
 175 2019-07-17  Tom Tromey  <tom@tromey.com>
 176
 177         * tui/tui-winsource.c (tui_update_source_window_as_is)
 178         (tui_update_source_windows_with_addr): Update.
 179         * tui/tui-source.h (tui_set_source_content)
 180         (tui_show_symtab_source): Add "win_info" parameter.
 181         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 182         parameter.
 183         (tui_show_symtab_source): Likewise.
 184
 185 2019-07-17  Tom Tromey  <tom@tromey.com>
 186
 187         * tui/tui-wingeneral.c
 188         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 189
 190 2019-07-17  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 193         (struct tui_cmd_window) <can_scroll>: New method.
 194         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 195         method.
 196
 197 2019-07-17  Tom Tromey  <tromey@adacore.com>
 198
 199         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 200         do_field_signed>: Rename.  Change type of "value".
 201         * ui-out.c (ui_out::field_signed): Rename from field_int.
 202         Change type of "value".
 203         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 204         type of "value".
 205         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 206         do_field_int.  Change type of "value".
 207         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 208         do_field_int.  Change type of "value".
 209         * tracepoint.c (trace_status_mi, tfind_1)
 210         (print_one_static_tracepoint_marker): Update.
 211         * thread.c (print_thread_info_1, print_selected_thread_frame):
 212         Update.
 213         * stack.c (print_frame, print_frame_info): Update.
 214         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 215         Update.
 216         * source.c (print_source_lines_base): Update.
 217         * skip.c (info_skip_command): Update.
 218         * record-btrace.c (btrace_ui_out_decode_error)
 219         (btrace_call_history_src_line): Update.
 220         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 221         Update.
 222         * progspace.c (print_program_space): Update.
 223         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 224         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 225         do_field_int.  Change type of "value".
 226         * mi/mi-out.c (mi_ui_out::do_table_begin)
 227         (mi_ui_out::do_table_header): Update.
 228         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 229         type of "value".
 230         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 231         (mi_cmd_data_list_changed_registers, output_register)
 232         (mi_cmd_data_read_memory, mi_load_progress)
 233         (mi_cmd_trace_frame_collected): Update.
 234         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 235         Update.
 236         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 237         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 238         (mi_cmd_var_list_children, varobj_update_one): Update.
 239         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 240         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 241         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 242         * inferior.c (print_inferior): Update.
 243         * gdb_bfd.c (print_one_bfd): Update.
 244         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 245         Update.
 246         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 247         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 248         do_field_int.  Change type of "value".
 249         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 250         do_field_int.  Change type of "value".
 251         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 252         (print_one_breakpoint_location, print_it_catch_fork)
 253         (print_one_catch_fork, print_it_catch_vfork)
 254         (print_one_catch_vfork, print_it_catch_solib)
 255         (print_it_catch_exec, print_it_ranged_breakpoint)
 256         (print_mention_watchpoint, print_mention_masked_watchpoint)
 257         (bkpt_print_it, update_static_tracepoint): Update.
 258         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 259         * break-catch-syscall.c (print_it_catch_syscall): Update.
 260         * ada-tasks.c (print_ada_task_info): Update.
 261         * ada-lang.c (print_it_exception, print_mention_exception):
 262         Update.
 263
 264 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 265
 266         PR breakpoints/24541
 267         * gdbarch.c: Regenerate.
 268         * gdbarch.h: Regenerate.
 269         * gdbarch.sh: Adjust return type and parameter types for
 270         'stap_adjust_register'.
 271         (i386_stap_adjust_register): Adjust signature and return new
 272         register name.
 273         * stap-probe.c (stap_parse_register_operand): Adjust use of
 274         'gdbarch_stap_adjust_register'.
 275
 276 2019-07-17  Tom Tromey  <tromey@adacore.com>
 277
 278         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 279         declare VEC.
 280         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 281         std::vector.
 282         (struct s390_process_info): Add initializers.
 283         (s390_add_process): Use new.
 284         (s390_linux_nat_target::low_forget_process): Use delete.
 285         (s390_linux_nat_target::low_new_fork)
 286         (s390_linux_nat_target::stopped_by_watchpoint)
 287         (s390_linux_nat_target::low_prepare_to_resume)
 288         (s390_linux_nat_target::insert_watchpoint)
 289         (s390_linux_nat_target::insert_hw_breakpoint)
 290         (s390_linux_nat_target::remove_watchpoint)
 291         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 292
 293 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 294
 295         * aarch64-fbsd-nat.c: Include regcache.h.
 296         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 297         argument.
 298         (aarch64_fbsd_nat_target::fetch_registers)
 299         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 300         variable.
 301         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 302
 303 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 304
 305         * fbsd-nat.c: Include gdbarch.h.
 306
 307 2019-07-15  Tom Tromey  <tromey@adacore.com>
 308
 309         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 310
 311 2019-07-15  Tom Tromey  <tromey@adacore.com>
 312
 313         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 314         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 315         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 316         * cli-out.c (cli_ui_out::do_field_int): New method.
 317         * ui-out.c (ui_out::field_unsigned): New method.
 318         * symfile.c (generic_load): Use field_unsigned.
 319         (print_transfer_performance): Likewise.
 320         * record-btrace.c (ui_out_field_uint): Remove.
 321         (btrace_call_history_insn_range, btrace_call_history): Use
 322         field_unsigned.
 323         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 324         field_unsigned.
 325         * ui-out.h (class ui_out) <field_unsigned>: New method.
 326         <do_field_unsigned>: Likewise.
 327
 328 2019-07-15  Tom Tromey  <tromey@adacore.com>
 329
 330         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 331         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 332         * target.c (flash_erase_command): Use field_string.
 333         * infrun.c (print_signal_received_reason): Use field_string.
 334         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 335         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 336         field_string.
 337         * ada-tasks.c (print_ada_task_info): Use field_string.
 338
 339 2019-07-15  Tom Tromey  <tromey@adacore.com>
 340
 341         * target.c (flash_erase_command): Use field_core_addr.
 342         * symfile.c (generic_load): Use field_core_addr.
 343         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 344         Use field_core_addr.
 345         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 346         field_core_addr.
 347
 348 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 349
 350         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 351         value if its desired type is smaller than a CORE_ADDR and signed.
 352
 353 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 354
 355         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 356         of changes to field names, and use new is_reference field to
 357         decide if a property is a reference or not.
 358         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 359         field.
 360         (struct dwarf2_property_baton): Update header comment, rename
 361         'referenced_type' to 'property_type' and update comments.
 362         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 363         default property type, store in property baton, update to take
 364         accound of renamed field.
 365         (read_func_scope): Update call to attr_to_dynamic_prop.
 366         (read_array_type): Likewise.
 367         (dwarf2_per_cu_addr_sized_int_type): New function.
 368         (read_subrange_index_type): Move type finding code to
 369         dwarf2_per_cu_addr_sized_int_type.
 370         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 371         (dwarf2_per_cu_addr_type): New function.
 372         (set_die_type): Update calls to attr_to_dynamic_prop.
 373
 374 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 375
 376         * dwarf2read.c (read_subrange_index_type): New function.
 377         (read_subrange_type): Move code into new function and call it.
 378         * gdbtypes.c (create_range_type): Add some asserts.
 379
 380 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 381
 382         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 383         update return statements.
 384         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 385         declaration, and update comment to match.
 386         * gdbtypes.c (resolve_dynamic_array): Update call to
 387         dwarf2_evaluate_property to match new return type.
 388
 389 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 390
 391         * valarith.c (value_subscripted_rvalue): Change lowerbound
 392         parameter type from int to LONGEST.
 393         * value.h (value_subscripted_rvalue): Likewise in declaration.
 394
 395 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 396
 397         * cli/cli-utils.c (info_print_command_completer): New function.
 398         * cli/cli-utils.h: Add 'completer.h' include, and forward
 399         declaration for 'struct cmd_list_element'.
 400         (info_print_command_completer): Declare.
 401         * stack.c (_initialize_stack): Add completer for 'info locals' and
 402         'info args'.
 403         * symtab.c (_initialize_symtab): Add completer for 'info
 404         variables' and 'info functions'.
 405         * NEWS: Mention completion for additional info commands.
 406
 407 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 408
 409         * cli/cli-utils.c (extract_info_print_args): Delete.
 410         (extract_arg_maybe_quoted): Delete.
 411         (info_print_options_defs): New variable.
 412         (make_info_print_options_def_group): New function.
 413         (extract_info_print_options): Define new function.
 414         * cli/cli-utils.h (extract_info_print_args): Delete.
 415         (struct info_print_options): New structure.
 416         (extract_info_print_options): Declare new function.
 417         * stack.c (info_locals_command): Update to use new
 418         extract_info_print_options, also add a header comment.
 419         (info_args_command): Likewise.
 420         * symtab.c (info_variables_command): Likewise.
 421         (info_functions_command): Likewise.
 422
 423 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 424
 425         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 426         to extract string arguments.
 427         * common/common-utils.c (extract_string_maybe_quoted): New function.
 428         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 429
 430 2019-07-11  Tom Tromey  <tromey@adacore.com>
 431
 432         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 433         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 434         * top.h (gdbinit): Don't declare.
 435         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 436         into...
 437         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 438         * top.c (gdb_init): Don't call init_cli_cmds.
 439         (gdbinit): Remove.
 440         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 441
 442 2019-07-11  Tom Tromey  <tromey@adacore.com>
 443
 444         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 445         after it has been moved.
 446
 447 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 448
 449         * valops.c (value_must_coerce_to_target): Change return type to
 450         bool.
 451         * value.h (value_must_coerce_to_target): Likewise.
 452
 453 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 454
 455         * breakpoint.c (is_hardware_watchpoint): Remove
 456         forward-declaration.
 457         (is_masked_watchpoint): Change return type to bool.
 458         (is_tracepoint): Likewise.
 459         (is_breakpoint): Likewise.
 460         (is_hardware_watchpoint): Likewise.
 461         (is_watchpoint): Likewise.
 462         (is_no_memory_software_watchpoint): Likewise.
 463         (is_catchpoint): Likewise.
 464         (breakpoint_1): Make FILTER parameter's return type bool.
 465         is_masked_watchpoint): Change return type to bool.
 466         (save_breakpoints): Make FILTER parameter's return type bool.
 467         * breakpoint.h (is_breakpoint): Change return type to bool.
 468         (is_watchpoint): Likewise.
 469         (is_catchpoint): Likewise.
 470         (is_tracepoint): Likewise.
 471
 472 2019-07-10  Tom Tromey  <tom@tromey.com>
 473
 474         * defs.h: Don't include gdbarch.h.
 475         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 476         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 477         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 478         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 479         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 480         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 481         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 482         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 483         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 484         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 485         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 486         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 487         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 488         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 489         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 490         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 491         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 492         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 493         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 494         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 495         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 496         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 497         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 498         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 499         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 500         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 501         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 502
 503 2019-07-10  Tom Tromey  <tromey@adacore.com>
 504
 505         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 506         * breakpoint.c (init_ada_exception_breakpoint): Register as
 507         bp_catchpoint.
 508         (print_one_breakpoint_location, print_one_breakpoint): Use
 509         is_ada_exception_catchpoint.
 510         * ada-lang.c (class ada_catchpoint_location): Pass
 511         bp_loc_software_breakpoint to bp_location constructor.
 512         (is_ada_exception_catchpoint): New function.
 513
 514 2019-07-10  Tom Tromey  <tromey@adacore.com>
 515
 516         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 517         VEC.
 518         (struct arm_exidx_entry): New method operator<.
 519         (struct arm_exidx_data) <section_maps>: Change type.
 520         (arm_exidx_data_free): Remove.
 521         (arm_exidx_data_key): Change type.  Move lower.
 522         (arm_exidx_new_objfile): Update.
 523         (arm_compare_exidx_entries): Remove.
 524         (arm_find_exidx_entry, _initialize_arm_tdep)
 525
 526 2019-07-10  Tom Tromey  <tromey@adacore.com>
 527
 528         * solib-spu.c (ocl_program_data_key): Change type.
 529         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 530         Update.
 531
 532 2019-07-10  Tom Tromey  <tromey@adacore.com>
 533
 534         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 535         (struct solib_aix_inferior_data) <library_list>: Change type.
 536         (solib_aix_inferior_data_handle): Change type.
 537         (get_solib_aix_inferior_data): Update.
 538         (solib_aix_free_library_list): Remove.
 539         (library_list_start_library): Update.
 540         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 541         return type.
 542         (solib_aix_get_library_list)
 543         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 544         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 545
 546 2019-07-10  Tom Tromey  <tromey@adacore.com>
 547
 548         * solib-dsbt.c (struct dsbt_info): Add initializers.
 549         (solib_dsbt_pspace_data): Change type.
 550         (dsbt_pspace_data_cleanup): Remove.
 551         (get_dsbt_info, _initialize_dsbt_solib): Update.
 552
 553 2019-07-10  Tom Tromey  <tromey@adacore.com>
 554
 555         * spu-tdep.c (spu_overlay_data): Change type.
 556         (spu_get_overlay_table, spu_overlay_new_objfile)
 557         (_initialize_spu_tdep): Update.
 558
 559 2019-07-10  Tom Tromey  <tromey@adacore.com>
 560
 561         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 562         destructor.
 563         (dbx_objfile_data_key): Change type and declare later.
 564         (DBX_SYMFILE_INFO): Rewrite.
 565         * dbxread.c (dbx_objfile_data_key): Change type.
 566         (dbx_symfile_init): Update.
 567         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 568         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 569         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 570
 571 2019-07-10  Tom Tromey  <tromey@adacore.com>
 572
 573         * jit.c (jit_program_space_key): Change type.  Move lower.
 574         (get_jit_program_space_data): Update.
 575         (jit_program_space_data_cleanup): Remove.
 576         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 577         Update.
 578         (struct jit_program_space_data): Add initializers.
 579
 580 2019-07-10  Tom Tromey  <tromey@adacore.com>
 581
 582         * solib-darwin.c (struct darwin_info): Add initializers.
 583         (solib_darwin_pspace_data): Change type.
 584         (darwin_pspace_data_cleanup): Remove.
 585         (get_darwin_info, _initialize_darwin_solib): Update.
 586
 587 2019-07-10  Tom Tromey  <tromey@adacore.com>
 588
 589         * remote-sim.c (struct sim_inferior_data): Add initializers,
 590         constructor, and destructor.
 591         (sim_inferior_data_key): Change type.  Move lower.
 592         (check_for_duplicate_sim_descriptor): Update.
 593         (get_sim_inferior_data): Use new.  Update.
 594         (~sim_inferior_data_cleanup): Rename from
 595         sim_inferior_data_cleanup.  Simplify.
 596         (gdbsim_close_inferior, simulator_command)
 597         (sim_command_completer, _initialize_remote_sim): Update.
 598         (next_pid, INITIAL_PID): Move earlier.
 599
 600 2019-07-10  Tom Tromey  <tromey@adacore.com>
 601
 602         * python/python-internal.h (create_thread_object): Return
 603         gdbpy_ref.
 604         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 605         * python/py-inferior.c (struct threadlist_entry): Add
 606         constructor.
 607         <thread_obj>: Now a gdbpy_ref.
 608         (thread_to_thread_object): Update.
 609         (add_thread_object): Use new.
 610         (delete_thread_object): Use delete.
 611         (infpy_threads): Update.
 612         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 613         GIL.
 614
 615 2019-07-10  Tom Tromey  <tromey@adacore.com>
 616
 617         * valops.c (value_cast): Specialize error message for Ada.
 618
 619 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 620
 621         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 622
 623 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 624
 625         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 626         bpstat_should_step): Return bool, adjust comments.
 627         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 628         bpstat_should_step): Likewise.
 629
 630 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 631
 632         * features/Makefile: Use feature target descriptions for Arm.
 633         * features/arm/arm-core.c: Generate new file.
 634         * features/arm/arm-fpa.c: Likewise.
 635         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 636         * features/arm/arm-m-profile.c: Likewise.
 637         * features/arm/arm-vfpv2.c: Likewise.
 638         * features/arm/arm-vfpv3.c: Likewise.
 639         * features/arm/xscale-iwmmxt.c: Likewise.
 640         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 641
 642 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 643
 644         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 645         ptrace earlier.
 646
 647 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 648
 649         * features/aarch64-pauth.c: Regenerate.
 650
 651 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 652
 653         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 654         bool.
 655         (bpstat_what): Use false instead of 0.
 656
 657 2019-07-09  Pedro Alves  <palves@redhat.com>
 658
 659         * break-catch-throw.c (is_exception_catchpoint): New.
 660         * breakpoint.c (print_one_breakpoint_location): New parameter
 661         'raw_loc'.  Handle it.  Use
 662         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 663         looking at the breakpoint's type.
 664         (print_one_breakpoint): If handling "maint info breakpoints", also
 665         print locations of exception catchpoints.
 666         * breakpoint.h (is_exception_catchpoint): Declare.
 667
 668 2019-07-09  Pedro Alves  <palves@redhat.com>
 669
 670         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 671         "addr" field.
 672         (allocate_location_exception_catchpoint): New.
 673         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 674         (initialize_throw_catchpoint_ops): Install
 675         allocate_location_exception_catchpoint as allocate_location
 676         method.
 677         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 678         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 679         bp_loc_other.
 680         (breakpoint_address_is_meaningful): Delete.
 681         (bl_address_is_meaningful): New.
 682         (breakpoint_locations_match): Adjust comment.
 683         (bp_location_from_bp_type): New, factored out of...
 684         (bp_location::bp_location(breakpoint *)): ... this.
 685         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 686         factored out of...
 687         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 688         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 689         breakpoint_address_is_meaningful.
 690         (bp_locations_compare): Adjust comment.
 691         (update_global_location_list): Use bl_address_is_meaningful
 692         instead of breakpoint_address_is_meaningful.
 693         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 694         explicit.
 695         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 696         * python/py-breakpoint.c (bppy_get_location): No longer check
 697         whether location is null.
 698
 699 2019-07-09  Pedro Alves  <palves@redhat.com>
 700
 701         PR c++/15468
 702         * breakpoint.c (print_one_breakpoint_location): Remove
 703         single-location assert.
 704
 705 2019-07-09  Tom Tromey  <tom@tromey.com>
 706
 707         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 708         * configure: Rebuild.
 709         * configure.ac: Change common to gdbsupport.
 710         * gdbsupport: Rename from common.
 711         * acinclude.m4: Change common to gdbsupport.
 712         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 713         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 714         gdbsupport.
 715         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 716         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 717         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 718         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 719         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 720         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 721         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 722         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 723         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 724         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 725         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 726         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 727         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 728         coff-pe-read.c, command.h, compile/compile-c-support.c,
 729         compile/compile-c.h, compile/compile-cplus-symbols.c,
 730         compile/compile-cplus-types.c, compile/compile-cplus.h,
 731         compile/compile-loc2c.c, compile/compile.c, completer.c,
 732         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 733         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 734         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 735         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 736         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 737         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 738         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 739         features/aarch64-core.c, features/aarch64-fpu.c,
 740         features/aarch64-pauth.c, features/aarch64-sve.c,
 741         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 742         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 743         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 744         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 745         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 746         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 747         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 748         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 749         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 750         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 751         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 752         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 753         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 754         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 755         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 756         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 757         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 758         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 759         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 760         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 761         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 762         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 763         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 764         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 765         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 766         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 767         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 768         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 769         minsyms.c, mips-linux-tdep.c, namespace.h,
 770         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 771         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 772         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 773         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 774         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 775         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 776         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 777         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 778         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 779         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 780         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 781         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 782         procfs.c, producer.c, progspace.h, psymtab.h,
 783         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 784         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 785         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 786         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 787         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 788         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 789         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 790         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 791         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 792         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 793         target-memory.c, target.c, target.h, target/waitstatus.c,
 794         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 795         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 796         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 797         unittests/array-view-selftests.c,
 798         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 799         unittests/common-utils-selftests.c,
 800         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 801         unittests/format_pieces-selftests.c,
 802         unittests/function-view-selftests.c,
 803         unittests/lookup_name_info-selftests.c,
 804         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 805         unittests/mkdir-recursive-selftests.c,
 806         unittests/observable-selftests.c,
 807         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 808         unittests/parse-connection-spec-selftests.c,
 809         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 810         unittests/scoped_fd-selftests.c,
 811         unittests/scoped_mmap-selftests.c,
 812         unittests/scoped_restore-selftests.c,
 813         unittests/string_view-selftests.c, unittests/style-selftests.c,
 814         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 815         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 816         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 817         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 818         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 819         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 820
 821 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 822
 823         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 824         bool value.
 825         (decode_digits_ordinary): Set explicit_line field in sal.
 826         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 827         symtab_and_line that was set on an explicit line number in
 828         assembler code.  Do always update the recorded symtab and line if
 829         we do skip the prologue.
 830
 831 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 832
 833         * breakpoint.c (set_breakpoint_location_function): Remove
 834         explicit_loc parameter.
 835         (momentary_breakpoint_from_master): Update call to
 836         set_breakpoint_location_function.
 837         (add_location_to_breakpoint): Likewise.
 838
 839 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 840
 841         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 842         required features based on default bfd type when no specific bfd
 843         is present.
 844
 845 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 846
 847         * NEWS: Mention that GDB printf and eval commands can now print
 848         C-style and Ada-style convenience var strings without
 849         calling the inferior.
 850         * printcmd.c (printf_c_string): Locally print GDB internal var
 851         instead of transiting via the inferior.
 852         (printf_wide_c_string): Likewise.
 853
 854 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 855
 856         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 857
 858 2019-07-04  Tom Tromey  <tom@tromey.com>
 859
 860         PR tui/24724:
 861         * tui/tui-winsource.c (tui_clear_source_content): Update.
 862         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 863         (tui_update_breakpoint_info): Update.
 864         (tui_set_exec_info_content): Update.
 865         * tui/tui-source.c (tui_set_source_content_nil): Update.
 866         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 867         has_break.
 868         * tui/tui-data.h (enum tui_bp_flag): New.
 869         (tui_bp_flags): New enum flags type.
 870         (struct tui_source_element) <break_mode>: Change type.  Rename
 871         from has_break.
 872         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 873         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 874         constants.
 875         * tui/tui-winsource.h: Fix comment.
 876
 877 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 878
 879         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 880         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 881         (store_fpregs_to_thread)
 882         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 883         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 884         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 885         (IWMMXT_REGS_SIZE): Add define.
 886         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 887         (fetch_vfp_regs, store_vfp_regs)
 888         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 889         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 890
 891 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 892
 893         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 894         defines.
 895         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 896         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 897         (ARM_INT_REGISTER_SIZE): ...to this.
 898         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 899         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 900         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 901         (arm_linux_collect_gregset, supply_nwfpe_register)
 902         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 903         defines.
 904         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 905         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 906         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 907         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 908         (arm_return_in_memory, arm_store_return_value)
 909         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 910         (arm_record_ld_st_multiple): Likewise.
 911         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 912         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 913
 914 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 915
 916         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 917         AARCH64_DISPLACED_MODIFIED_INSNS.
 918         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 919         (aarch64_displaced_step_copy_insn): Likewise.
 920         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 921         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 922         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 923         ARM_DISPLACED_MODIFIED_INSNS.
 924         * arm-tdep.c (arm_gdbarch_init): Likewise.
 925         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 926         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 927         (struct arm_displaced_step_closure): Use
 928         ARM_DISPLACED_MODIFIED_INSNS.
 929
 930 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 931
 932         * features/Makefile: Remove unused xml files.
 933         * features/aarch64.xml: Remove.
 934         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 935         * features/i386/amd64-avx-avx512.xml: Remove.
 936         * features/i386/amd64-avx-linux.xml: Remove.
 937         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 938         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 939         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 940         * features/i386/amd64-avx-mpx.xml: Remove.
 941         * features/i386/amd64-avx.xml: Remove.
 942         * features/i386/amd64-linux.xml: Remove.
 943         * features/i386/amd64-mpx-linux.xml: Remove.
 944         * features/i386/amd64-mpx.xml: Remove.
 945         * features/i386/amd64.xml: Remove.
 946         * features/i386/i386-avx-avx512-linux.xml: Remove.
 947         * features/i386/i386-avx-avx512.xml: Remove.
 948         * features/i386/i386-avx-linux.xml: Remove.
 949         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 950         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 951         * features/i386/i386-avx-mpx-linux.xml: Remove.
 952         * features/i386/i386-avx-mpx.xml: Remove.
 953         * features/i386/i386-avx.xml: Remove.
 954         * features/i386/i386-linux.xml: Remove.
 955         * features/i386/i386-mmx-linux.xml: Remove.
 956         * features/i386/i386-mmx.xml: Remove.
 957         * features/i386/i386-mpx-linux.xml: Remove.
 958         * features/i386/i386-mpx.xml: Remove.
 959         * features/i386/i386.xml: Remove.
 960         * features/i386/x32-avx-avx512-linux.xml: Remove.
 961         * features/i386/x32-avx-linux.xml: Remove.
 962         * features/i386/x32-linux.xml: Remove.
 963
 964 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 965
 966         * regformats/aarch64.dat: Remove.
 967         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 968         * regformats/i386/amd64-avx-linux.dat: Remove.
 969         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 970         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 971         * regformats/i386/amd64-linux.dat: Remove.
 972         * regformats/i386/amd64-mpx-linux.dat: Remove.
 973         * regformats/i386/amd64.dat: Remove.
 974         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 975         * regformats/i386/i386-avx-linux.dat: Remove.
 976         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 977         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 978         * regformats/i386/i386-linux.dat: Remove.
 979         * regformats/i386/i386-mmx-linux.dat: Remove.
 980         * regformats/i386/i386-mpx-linux.dat: Remove.
 981         * regformats/i386/i386.dat: Remove.
 982         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 983         * regformats/i386/x32-avx-linux.dat: Remove.
 984         * regformats/i386/x32-linux.dat: Remove.
 985
 986 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 987
 988         * aarch64-tdep.c: Remove xml self tests.
 989         * amd64-linux-tdep.c: Likewise.
 990         * amd64-tdep.c: Likewise.
 991         * i386-linux-tdep.c: Likewise.
 992         * i386-tdep.c: Likewise.
 993
 994 2019-07-03  Pedro Alves  <palves@redhat.com>
 995
 996         PR cli/24732
 997         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 998         (pipe_cmd_option_defs): New.
 999         (make_pipe_cmd_options_def_group): New.
1000         (pipe_command): Use gdb::option::process_options.
1001         (pipe_command_completer): New function.
1002         (_initialize_cli_cmds): Install completer for "pipe" command.
1003
1004 2019-07-03  Pedro Alves  <palves@redhat.com>
1005
1006         * cli/cli-option.c (union option_value) <string>: New field.
1007         (struct option_def_and_value): Add ctor, move ctor, dtor and
1008         use DISABLE_COPY_AND_ASSIGN.
1009         (option_def_and_value::clear_value): New.
1010         (parse_option, save_option_value_in_ctx, get_val_type_str)
1011         (add_setshow_cmds_for_options): Handle var_string.
1012         * cli-option.h (union option_def::var_address) <string>: New
1013         field.
1014         (struct string_option_def): New.
1015         * maint-test-options.c (struct test_options_opts): Add default
1016         ctor and use DISABLE_COPY_AND_ASSIGN.
1017         <string_opt>: New field.
1018         (test_options_opts::~test_options_opts): New.
1019         (test_options_opts::dump): Also dump "-string".
1020         (test_options_option_defs): Install "string.
1021
1022 2019-07-03  Pedro Alves  <palves@redhat.com>
1023
1024         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1025         option_value with a null enumeration.
1026         (complete_options): Save the option values in the context.
1027         (save_option_value_in_ctx): New, factored out from ...
1028         (process_options): ... here.
1029         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1030         of the function.
1031         * maint-test-options.c (test_options_opts::dump): New, factored
1032         out from ...
1033         (maintenance_test_options_command_mode): ... here.
1034         (maintenance_test_options_command_completion_result): Delete.
1035         (maintenance_test_options_command_completion_text): Update
1036         comment.
1037         (maintenance_show_test_options_completion_result): Change
1038         prototype.  Just print
1039         maintenance_test_options_command_completion_text.
1040         (save_completion_result): New.
1041         (maintenance_test_options_completer_mode): Pass options context to
1042         complete_options, and then save a dump.
1043         (_initialize_maint_test_options): Use add_cmd to install "maint
1044         show test-options-completion-result".
1045
1046 2019-07-03  Pedro Alves  <palves@redhat.com>
1047
1048         * NEWS (New commands): Mention "with" and "maint with".
1049         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1050         (with_command, with_command_completer): New.
1051         (pipe_command): Adjust to new repeat_previous
1052         interface.
1053         (_initialize_cli_cmds): Install the "with" command and its "w"
1054         alias.
1055         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1056         declarations.
1057         * cli/cli-setshow.c (parse_cli_var_uinteger)
1058         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1059         argument strings for all var_types.
1060         (get_setshow_command_value_string): New, factored out from ...
1061         (do_show_command): ... this.
1062         * cli/cli-setshow.h: Include <string>.
1063         (get_setshow_command_value_string): Declare.
1064         * command.h (repeat_previous): Now returns const char *.  Adjust
1065         comment.
1066         * maint.c: Include "cli/cli-cmds.h".
1067         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1068         (_initialize_maint_cmds): Register the "maintenance with" command.
1069         * top.c (repeat_previous): Move bits from pipe_command here:
1070         Return the saved command line, if any; error out if there's no
1071         command to relaunch.
1072
1073 2019-07-03  Pedro Alves  <palves@redhat.com>
1074
1075         * NEWS (New commands): Mention "maint set/show test-settings"
1076         instead of "maint test-settings".
1077         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1078         (maintenance_test_settings_set_list): Rename to ...
1079         (maintenance_set_test_settings_list): ... this.
1080         (maintenance_test_settings_show_list): Rename to  ...
1081         (maintenance_show_test_settings_list): ... this.
1082         (maintenance_test_settings_cmd): Delete.
1083         (maintenance_test_settings_set_cmd): ...
1084         (maintenance_set_test_settings_cmd): ... this.
1085         (maintenance_test_settings_show_cmd): ...
1086         (maintenance_show_test_settings_cmd): ... this.
1087         (maintenance_test_settings_show_value_cmd):
1088         (maintenance_show_test_settings_value_cmd): ... this.
1089         (_initialize_maint_test_settings): No longer install the "maint
1090         test-settings" prefix command.  Rename "maint test-settings set"
1091         to "maint set test-settings", and "maint test-settings show" to
1092         "maint show test-settings".  Adjust all subcommands.
1093
1094 2019-07-03  Pedro Alves  <palves@redhat.com>
1095
1096         * maint-test-settings.c: Fix file's intro comment.  Replace all
1097         references to "test-options" with references to "test-settings",
1098         in comments.
1099
1100 2019-07-03  Pedro Alves  <palves@redhat.com>
1101
1102         * maint-test-settings.c (maintenance_test_settings_xxx)
1103         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1104         New.
1105         (maintenance_test_settings_enums): Use them.
1106         (maintenance_test_settings_enum): Default to
1107         maintenance_test_settings_xxx.
1108         (_initialize_maint_test_settings): Initialize
1109         MAINTENANCE_TEST_SETTINGS_FILENAME.
1110
1111 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1112
1113         * breakpoint.h (remove_breakpoints_inf): Change return type to
1114         void, move function documentation here.
1115         * breakpoint.c (remove_breakpoints_inf): Change return type to
1116         void, move function documentation to header.
1117
1118 2019-07-02  Pedro Alves  <palves@redhat.com>
1119
1120         * NEWS (Completion improvements): Mention "info threads".
1121         * thread.c (struct info_threads_opts, info_threads_option_defs)
1122         (make_info_threads_options_def_group): New.
1123         (info_threads_command): Use gdb::option::process_options.
1124         (info_threads_command_completer): New.
1125         (_initialize_thread): Use gdb::option::build_help to build the
1126         help text for "info threads".
1127
1128 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1129
1130         * defs.h (generic_load): Move from here...
1131         * symfile.h (generic_load): ... to here.  Rename name parameter
1132         to args.
1133         * symfile.c (generic_load): Add comment.
1134
1135 2019-07-01  Tom Tromey  <tromey@adacore.com>
1136
1137         * dwarf2read.c
1138         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1139         declaration of without_params.  Fix formatting.
1140
1141 2019-07-01  Tom Tromey  <tromey@adacore.com>
1142
1143         * ada-exp.y (find_primitive_type): Update.
1144         * ada-lang.h (ada_lookup_symbol): Update.
1145         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1146         parameter.
1147         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1148
1149 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1150
1151         PR breakpoints/24541
1152         * gdbarch.c: Regenerate.
1153         * gdbarch.h: Regenerate.
1154         * gdbarch.sh: Add 'stap_adjust_register'.
1155         * i386-tdep.c: Include '<unordered_set>'.
1156         (i386_stap_adjust_register): New function.
1157         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1158         * stap-probe.c (stap_parse_register_operand): Call
1159         'gdbarch_stap_adjust_register'.
1160
1161 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1162
1163         PR python/24742
1164         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1165         * python/python.c (do_start_initialization): Use 'xmalloc'
1166         instead of 'PyMem_Malloc'.
1167
1168 2019-06-28  Tom Tromey  <tromey@adacore.com>
1169
1170         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1171         for Ada.
1172
1173 2019-06-27  Tom Tromey  <tromey@adacore.com>
1174
1175         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1176         objfile_key.
1177         (arm_find_mapping_symbol, arm_record_special_symbol)
1178         (_initialize_arm_tdep): Update.
1179         (arm_objfile_data_free): Remove.
1180
1181 2019-06-27  Tom Tromey  <tromey@adacore.com>
1182
1183         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1184         to cp_print_static_field.
1185
1186 2019-06-26  Tom Tromey  <tromey@adacore.com>
1187
1188         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1189         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1190         declare.
1191
1192 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1193
1194         * features/aarch64-core.c (create_feature_aarch64_core):
1195         Regenerate.
1196         * features/aarch64-core.xml: Add cpsr flags.
1197
1198 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1199
1200         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1201         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1202
1203 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1204
1205         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1206         field.
1207         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1208         use.
1209         (arm_record_special_symbol): Don't insert new symbol in sorted
1210         position, push it at the end.
1211
1212 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1213
1214         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1215         (arm_mapping_symbol_s): Remove.
1216         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1217         (arm_mapping_symbol_vec): New typedef.
1218         (struct arm_per_objfile): Add constructor.
1219         <section_maps>: Change type to
1220         std::unique_ptr<arm_mapping_symbol_vec[]>.
1221         (arm_compare_mapping_symbols): Remove.
1222         (arm_find_mapping_symbol): Adjust to section_maps type change.
1223         (arm_objfile_data_free): Call delete on arm_per_objfile.
1224         (arm_record_special_symbol): Adjust to section_maps type change.
1225         Allocate arm_per_objfile with new.
1226
1227 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1228
1229         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1230         with the command prefix.
1231
1232 2019-06-25  Tom Tromey  <tom@tromey.com>
1233
1234         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1235         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1236
1237 2019-06-25  Tom Tromey  <tom@tromey.com>
1238
1239         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1240         type.
1241         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1242         protected.
1243
1244 2019-06-25  Tom Tromey  <tom@tromey.com>
1245
1246         * tui/tui-winsource.c
1247         (tui_source_window_base::set_is_exec_point_at): Add check against
1248         LOA_ADDRESS.
1249
1250 2019-06-25  Tom Tromey  <tom@tromey.com>
1251
1252         * tui/tui-source.c (tui_set_source_content): Don't check before
1253         xfree.
1254         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1255
1256 2019-06-25  Tom Tromey  <tom@tromey.com>
1257
1258         * tui/tui-winsource.h (tui_update_source_window_as_is)
1259         (tui_alloc_source_buffer, tui_line_is_displayed)
1260         (tui_addr_is_displayed): Change type of win_info.
1261         * tui/tui-winsource.c (tui_update_source_window_as_is)
1262         (tui_clear_source_content, tui_show_source_line)
1263         (tui_show_source_content, tui_source_window_base::refill)
1264         (tui_source_window_base::set_is_exec_point_at)
1265         (tui_source_window_base::set_is_exec_point_at)
1266         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1267         (tui_alloc_source_buffer, tui_line_is_displayed)
1268         (tui_addr_is_displayed): Change type of win_info.  Update.
1269         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1270         (tui_source_window_base::do_make_visible_with_new_height):
1271         Update.
1272         * tui/tui-source.c (tui_set_source_content)
1273         (tui_set_source_content_nil)
1274         (tui_source_window::do_scroll_vertical): Update.
1275         * tui/tui-layout.c (show_layout): Update.
1276         * tui/tui-disasm.c (tui_set_disassem_content)
1277         (tui_disasm_window::do_scroll_vertical): Update.
1278         * tui/tui-data.h (tui_win_content): Remove.
1279         (struct tui_gen_win_info) <content, content_size>: Remove.
1280         (struct tui_source_element): Add initializers and destructor.
1281         (union tui_which_element, struct tui_win_element): Remove.
1282         (struct tui_source_window_base) <content>: New field.
1283         (struct tui_data_window): Remove destructor.
1284         (tui_alloc_content, tui_free_win_content)
1285         (tui_free_all_source_wins_content): Don't declare.
1286         * tui/tui-data.c (tui_initialize_static_data): Update.
1287         (init_content_element, tui_alloc_content): Remove.
1288         (~tui_gen_win_info): Update.
1289         (~tui_data_window, tui_free_all_source_wins_content)
1290         (tui_free_win_content, free_content, free_content_elements):
1291         Remove.
1292
1293 2019-06-25  Tom Tromey  <tom@tromey.com>
1294
1295         * tui/tui-winsource.h (tui_clear_source_content)
1296         (tui_erase_source_content, tui_show_source_content): Change type
1297         of win_info.
1298         * tui/tui-winsource.c (tui_clear_source_content)
1299         (tui_erase_source_content, tui_show_source_content): Change type
1300         of win_info.
1301         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1302         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1303         win_info.
1304         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1305         win_info.
1306         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1307
1308 2019-06-25  Tom Tromey  <tom@tromey.com>
1309
1310         * tui/tui-winsource.c (tui_clear_source_content)
1311         (tui_source_window_base::set_is_exec_point_at): Update.
1312         * tui/tui-source.c (tui_set_source_content_nil): Update.
1313         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1314         a bool.
1315         * tui/tui-data.c (init_content_element): Update.
1316
1317 2019-06-25  Tom Tromey  <tom@tromey.com>
1318
1319         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1320         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1321         * tui/tui-layout.c (init_and_make_win): Update.
1322         * tui/tui.h (enum tui_win_type): Update.
1323         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1324         tui_win_is_auxillary.
1325         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1326         tui_win_is_auxillary.
1327
1328 2019-06-25  Tom Tromey  <tom@tromey.com>
1329
1330         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1331         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1332         (tui_delete_data_content_windows, tui_display_all_data)
1333         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1334         Update.
1335         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1336         * tui/tui-regs.c (tui_last_regs_line_no)
1337         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1338         (tui_show_registers): Update.
1339         (tui_show_register_group): Return void.  Update.
1340         (tui_display_registers_from, tui_display_reg_element_at_line)
1341         (tui_display_registers_from_line, tui_check_register_values):
1342         Update.
1343         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1344         member.
1345         (struct tui_data_window) <regs_content>: Now a std::vector.
1346         <regs_content_count>: Remove.
1347         (tui_add_content_elements, tui_free_data_content): Don't declare.
1348         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1349         (init_content_element): Remove DATA_WIN case.  Add assert.
1350         (tui_add_content_elements): Remove.
1351         (tui_data_window): Update.
1352         (tui_free_data_content): Remove.
1353         (free_content_elements): Remove DATA_WIN case.
1354
1355 2019-06-25  Tom Tromey  <tom@tromey.com>
1356
1357         * tui/tui-data.c (tui_data_item_window): Update.
1358         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1359         * tui/tui-windata.c (tui_display_all_data)
1360         (tui_display_data_from_line): Update.
1361         (tui_check_data_values): Remove.
1362         * tui/tui-regs.c (tui_show_register_group)
1363         (tui_display_reg_element_at_line): Update.
1364         * tui/tui-hooks.c (tui_register_changed)
1365         (tui_refresh_frame_and_register_information): Call
1366         tui_check_register_values.
1367         * tui/tui-data.h (struct tui_data_window) <data_content,
1368         data_content_count, data_type>: Remove.
1369         (enum tui_data_type): Remove.
1370
1371         * tui/tui-data.c (tui_data_window::clear_detail)
1372         (~tui_data_window): Update.
1373
1374 2019-06-25  Tom Tromey  <tom@tromey.com>
1375
1376         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1377         declare.
1378         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1379         Rename from tui_first_data_item_displayed.  Update.
1380         (tui_data_window::refresh_all)
1381         (tui_data_window::do_scroll_vertical): Update.
1382         * tui/tui-data.h (struct tui_data_window)
1383         <first_data_item_displayed>: Declare new method.
1384
1385 2019-06-25  Tom Tromey  <tom@tromey.com>
1386
1387         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1388         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1389         contents...
1390         (tui_initialize_static_data): ...here.
1391
1392 2019-06-25  Tom Tromey  <tom@tromey.com>
1393
1394         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1395         (tui_display_registers_from, tui_check_register_values): Update.
1396         (tui_display_register): Remove win_info parameter; update.
1397         (tui_get_register): Change type of parameters.
1398         * tui/tui-data.h (struct tui_data_element): Remove.
1399         (union tui_which_element) <data>: Remove.
1400         <data_window>: Change type.
1401         (struct tui_data_item_window): New.
1402         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1403         case.  Add assert.
1404         (~tui_data_item_window): New destructor.
1405         (free_content_elements): Remove DATA_ITEM_WIN case.
1406
1407 2019-06-25  Tom Tromey  <tom@tromey.com>
1408
1409         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1410         Remove.
1411
1412 2019-06-25  Tom Tromey  <tom@tromey.com>
1413
1414         * tui/tui-data.h (struct tui_command_element): Remove.
1415         (union tui_which_element) <command>: Remove.
1416         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1417         assert.
1418         (free_content_elements): Remove CMD_WIN case.
1419
1420 2019-06-25  Tom Tromey  <tom@tromey.com>
1421
1422         * tui/tui-layout.c (tui_set_layout): Update.
1423         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1424         * tui/tui-data.c (layout_def): Update.
1425
1426 2019-06-25  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1429         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1430         (tui_source_window_base::set_new_height): Update.
1431         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1432         Update.
1433         (tui_set_locator_fullname, tui_set_locator_info)
1434         (tui_show_frame_info): Update.
1435         * tui/tui-source.c (tui_set_source_content)
1436         (tui_source_is_displayed): Update.
1437         * tui/tui-layout.c (show_source_disasm_command, show_data)
1438         (show_source_or_disasm_and_command): Update.
1439         * tui/tui-disasm.c (tui_set_disassem_content)
1440         (tui_get_begin_asm_address): Update.
1441         * tui/tui-data.h (struct tui_locator_element): Remove.
1442         (union tui_which_element) <locator>: Remove.
1443         (struct tui_locator_window): New.
1444         (tui_locator_win_info_ptr): Change return type.
1445         * tui/tui-data.c (_locator): Change type.
1446         (tui_locator_win_info_ptr): Change return type.
1447         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1448         (tui_alloc_content): Add assert.
1449
1450 2019-06-25  Tom Tromey  <tom@tromey.com>
1451
1452         * tui/tui-winsource.c
1453         (tui_exec_info_window::maybe_allocate_content): New method.
1454         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1455         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1456         (make_source_or_disasm_window): Add cast.
1457         * tui/tui-data.h (union tui_which_element) <simple_string>:
1458         Remove.
1459         (struct tui_source_info): New.
1460         (struct tui_source_window_base) <execution_info>: Change type.
1461         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1462         case, and add assert.
1463         (tui_alloc_content): Add assert.
1464
1465 2019-06-25  Tom Tromey  <tom@tromey.com>
1466
1467         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1468         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1469         * tui/tui-data.c (tui_alloc_win_info): Remove.
1470
1471 2019-06-25  Tom Tromey  <tom@tromey.com>
1472
1473         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1474         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1475         can_highlight.
1476
1477 2019-06-25  Tom Tromey  <tom@tromey.com>
1478
1479         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1480         make_visible_with_new_height method.
1481         (tui_win_info::make_visible_with_new_height): New method.
1482         (tui_source_window_base::do_make_visible_with_new_height)
1483         (tui_data_window::do_make_visible_with_new_height)
1484         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1485         (make_visible_with_new_height): Remove.
1486         (tui_resize_all, tui_adjust_win_heights): Use
1487         make_visible_with_new_height method.
1488         * tui/tui-data.h (struct tui_win_info)
1489         <do_make_visible_with_new_height, make_visible_with_new_height>:
1490         New methods.
1491         (struct tui_source_window_base, struct tui_data_window)
1492         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1493         methods.
1494
1495 2019-06-25  Tom Tromey  <tom@tromey.com>
1496
1497         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1498         method.
1499         (update_tab_width): Call update_tab_width method.
1500         * tui/tui-data.h (struct tui_win_info)
1501         (struct tui_source_window_base) <update_tab_width>: New methods.
1502
1503 2019-06-25  Tom Tromey  <tom@tromey.com>
1504
1505         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1506         parameter.
1507         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1508         parameter.
1509         (tui_gen_win_info::make_visible): Update.
1510         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1511         parameter.
1512         * tui/tui-data.h (enum tui_box): New enum.
1513         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1514
1515 2019-06-25  Tom Tromey  <tom@tromey.com>
1516
1517         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1518         init_and_make_win for EXEC_INFO_WIN.
1519         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1520         longer inline.
1521         (struct tui_win_info) <~tui_win_info>: Inline.
1522         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1523         Don't declare.
1524         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1525         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1526         Remove.
1527         (tui_initialize_static_data): Update.
1528         (~tui_gen_win_info): Handle more cleanup here.
1529         (~tui_source_window_base): Delete "execution_info".
1530         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1531
1532 2019-06-25  Tom Tromey  <tom@tromey.com>
1533
1534         * tui/tui-layout.c (make_command_window): Don't set
1535         can_highlight.
1536         (show_source_disasm_command): Call the reset method.
1537         (show_data): Don't set can_highlight.  Call the reset method.
1538         (tui_gen_win_info::reset): Rename from init_gen_win_info
1539         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1540         (show_source_or_disasm_and_command): Call the reset method.
1541         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1542         (struct tui_cmd_window): Set can_highlight.
1543
1544 2019-06-25  Tom Tromey  <tom@tromey.com>
1545
1546         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1547         from make_visible.
1548         (tui_make_visible, tui_make_invisible): Rewrite.
1549         (tui_win_info::make_visible): Remove.
1550         (tui_source_window_base::make_visible): Update.
1551         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1552         method.  Moved from...
1553         (struct tui_win_info) <make_visible>: ...here.
1554
1555 2019-06-25  Tom Tromey  <tom@tromey.com>
1556
1557         * tui/tui-winsource.c
1558         (tui_source_window_base::do_scroll_horizontal): Remove direction
1559         parameter.
1560         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1561         direction parameter.
1562         * tui/tui-win.c (tui_win_info::forward_scroll)
1563         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1564         (tui_win_info::right_scroll): Update.
1565         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1566         direction parameter.
1567         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1568         direction parameter.
1569         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1570         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1571         Remove direction parameter.
1572         (struct tui_source_window_base, struct tui_source_window)
1573         (struct tui_disasm_window, struct tui_data_window)
1574         (struct tui_cmd_window): Update.
1575
1576 2019-06-25  Tom Tromey  <tom@tromey.com>
1577
1578         * tui/tui-winsource.h (tui_set_exec_info_content)
1579         (tui_show_exec_info_content, tui_erase_exec_info_content)
1580         (tui_clear_exec_info_content, tui_update_exec_info): Change
1581         argument to tui_source_window_base.
1582         * tui/tui-winsource.c (tui_set_exec_info_content)
1583         (tui_show_exec_info_content, tui_erase_exec_info_content)
1584         (tui_clear_exec_info_content, tui_update_exec_info): Change
1585         argument to tui_source_window_base.
1586
1587 2019-06-25  Tom Tromey  <tom@tromey.com>
1588
1589         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1590         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1591
1592 2019-06-25  Tom Tromey  <tom@tromey.com>
1593
1594         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1595         check.
1596
1597 2019-06-25  Tom Tromey  <tom@tromey.com>
1598
1599         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1600         type to void.
1601         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1602         type to void.
1603         * tui/tui-source.c (tui_set_source_content): Update.
1604         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1605
1606 2019-06-25  Tom Tromey  <tom@tromey.com>
1607
1608         * tui/tui-win.c (window_name_completer, tui_set_focus)
1609         (tui_all_windows_info): Use name method.
1610         * tui/tui-data.h (struct tui_gen_win_info)
1611         (struct tui_source_window, struct tui_disasm_window)
1612         (struct tui_data_window, struct tui_cmd_window) <name>: New
1613         method.
1614         (tui_win_name): Don't declare.
1615         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1616         (tui_win_name): Remove.
1617
1618 2019-06-25  Tom Tromey  <tom@tromey.com>
1619
1620         * tui/tui-winsource.h (tui_update_source_window)
1621         (tui_update_source_window_as_is): Change parameter type.
1622         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1623         to be a tui_source_window_base.
1624         (tui_update_source_window_as_is): Likewise.
1625         * tui/tui-win.c (make_visible_with_new_height): Update.
1626
1627 2019-06-25  Tom Tromey  <tom@tromey.com>
1628
1629         * tui/tui-winsource.c (tui_erase_source_content)
1630         (tui_show_source_content, tui_show_exec_info_content)
1631         (tui_erase_exec_info_content): Use refresh_window method.
1632         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1633         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1634         from tui_refresh_win.
1635         (tui_data_window::refresh_window): New method.
1636         (tui_win_info::refresh, tui_source_window_base::refresh)
1637         (tui_refresh_all): Use refresh_window method.
1638         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1639         method.
1640         * tui/tui-regs.c (tui_display_register): Call refresh_window
1641         method.
1642         * tui/tui-layout.c (show_source_disasm_command)
1643         (show_source_or_disasm_and_command): Call refresh_window method.
1644         * tui/tui-data.h (struct tui_gen_win_info)
1645         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1646         New method.
1647
1648 2019-06-25  Tom Tromey  <tom@tromey.com>
1649
1650         * tui/tui.c (tui_rl_other_window, tui_enable)
1651         (tui_is_window_visible, tui_get_command_dimension): Update.
1652         * tui/tui-winsource.c (tui_update_source_window_as_is)
1653         (tui_clear_source_content, tui_erase_source_content)
1654         (tui_show_source_line, tui_source_window_base::refill)
1655         (tui_source_window_base::do_scroll_horizontal)
1656         (tui_source_window_base::set_is_exec_point_at)
1657         (tui_update_breakpoint_info, tui_set_exec_info_content)
1658         (tui_alloc_source_buffer, tui_line_is_displayed)
1659         (tui_addr_is_displayed): Update.
1660         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1661         (tui_check_and_display_highlight_if_needed)
1662         (tui_win_info::make_visible, tui_win_info::refresh)
1663         (tui_refresh_all): Update.
1664         * tui/tui-windata.c (tui_first_data_item_displayed)
1665         (tui_delete_data_content_windows, tui_erase_data_content)
1666         (tui_display_all_data, tui_data_window::refresh_all)
1667         (tui_check_data_values): Update.
1668         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1669         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1670         (tui_win_info::backward_scroll, tui_refresh_all_win)
1671         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1672         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1673         (tui_source_window_base::set_new_height)
1674         (tui_data_window::set_new_height)
1675         (make_invisible_and_set_new_height)
1676         (make_visible_with_new_height, new_height_ok)
1677         (parse_scrolling_args): Update.
1678         * tui/tui-stack.c (tui_show_frame_info): Update.
1679         * tui/tui-source.c (tui_set_source_content)
1680         (tui_set_source_content_nil, tui_source_is_displayed)
1681         (tui_source_window::do_scroll_vertical): Update.
1682         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1683         (tui_display_registers_from, tui_display_reg_element_at_line)
1684         (tui_check_register_values, tui_reg_command): Update.
1685         * tui/tui-layout.c (tui_default_win_height)
1686         (show_source_disasm_command, show_data, init_and_make_win)
1687         (show_source_or_disasm_and_command): Update.
1688         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1689         (tui_redisplay_readline, tui_mld_flush)
1690         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1691         (tui_getc): Update.
1692         * tui/tui-disasm.c (tui_set_disassem_content)
1693         (tui_disasm_window::do_scroll_vertical): Update.
1694         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1695         Now virtual.
1696         (struct tui_win_info): Derive from tui_gen_win_info.
1697         <~tui_win_info>: Mark as override.
1698         <generic>: Remove member.
1699         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1700         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1701         (~tui_data_window, ~tui_win_info)
1702         (tui_free_all_source_wins_content): Update.
1703         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1704
1705 2019-06-25  Tom Tromey  <tom@tromey.com>
1706
1707         * tui/tui-layout.c (init_and_make_win): Use new.
1708         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1709         destructor, initializers.
1710         (tui_alloc_generic_win_info): Don't declare.
1711         * tui/tui-data.c (_locator): Add argument to constructor.
1712         (source_win, disasm_win): New globals.
1713         (exec_info): Remove.
1714         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1715         Update.
1716         (tui_alloc_generic_win_info): Remove.
1717         (init_content_element): Use new.
1718         (tui_win_info::tui_win_info): Update.
1719         (free_content_elements) <case DATA_WIN>: Use delete.
1720
1721 2019-06-25  Tom Tromey  <tom@tromey.com>
1722
1723         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1724         * tui/tui-windata.c (tui_first_data_item_displayed)
1725         (tui_delete_data_content_windows): Update.
1726         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1727         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1728         (tui_display_registers_from, tui_check_register_values): Update.
1729         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1730         pointer.
1731         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1732         window.
1733         (tui_free_data_content): Update.
1734         (free_content_elements) <case DATA_WIN>: Free the window.
1735
1736 2019-06-25  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1739         Update.
1740         * tui/tui-layout.c (make_command_window)
1741         (show_source_disasm_command, show_data, init_and_make_win)
1742         (show_source_or_disasm_and_command): Update.
1743         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1744         method.
1745         <can_highight, is_highlighted>: Now bool.
1746         (tui_set_win_highlight): Don't declare.
1747         * tui/tui-data.c (tui_set_win_highlight): Remove.
1748
1749 2019-06-25  Tom Tromey  <tom@tromey.com>
1750
1751         * tui/tui-wingeneral.c (make_visible): Remove check of window
1752         type.
1753
1754 2019-06-25  Tom Tromey  <tom@tromey.com>
1755
1756         * tui/tui-win.c (tui_win_info::max_height)
1757         (tui_cmd_window::max_height): New methods.
1758         (new_height_ok): Call max_height.
1759         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1760         <max_height>: New method.
1761
1762 2019-06-25  Tom Tromey  <tom@tromey.com>
1763
1764         * tui/tui-win.c (tui_source_window_base::set_new_height)
1765         (tui_data_window::set_new_height): New methods.
1766         (make_invisible_and_set_new_height): Call set_new_height method.
1767         * tui/tui-data.h (struct tui_win_info)
1768         (struct tui_source_window_base, struct tui_data_window)
1769         <set_new_height>: New method.
1770
1771 2019-06-25  Tom Tromey  <tom@tromey.com>
1772
1773         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1774         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1775         tui_refresh_data_win.
1776         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1777         method.
1778         (tui_refresh_all_win): Call the refresh_all method.
1779         (tui_set_focus): Likewise.
1780         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1781         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1782         Likewise.
1783
1784 2019-06-25  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-winsource.h (tui_refill_source_window)
1787         (tui_set_is_exec_point_at): Don't declare.
1788         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1789         (tui_source_window_base::refill): Rename from
1790         tui_refill_source_window.
1791         (tui_source_window_base::do_scroll_horizontal): Update.
1792         (tui_source_window_base::set_is_exec_point_at): Rename from
1793         tui_set_is_exec_point_at.
1794         (tui_update_all_breakpoint_info): Update.
1795         * tui/tui-stack.c (tui_show_frame_info): Update.
1796         * tui/tui-layout.c (show_data): Add cast.
1797         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1798         * tui/tui-data.h (struct tui_source_window_base) <refill,
1799         set_is_exec_point_at>: New methods.
1800         (tui_source_windows, tui_add_to_source_windows): Update types.
1801         (tui_add_to_source_windows): Remove redundant declaration.
1802         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1803         (tui_source_windows): Change return type.
1804         (tui_clear_source_windows_detail): Update.
1805         (tui_add_to_source_windows): Change type of parameter.
1806         (tui_free_all_source_wins_content): Update.
1807
1808 2019-06-25  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-wingeneral.c (tui_win_info::refresh)
1811         (tui_source_window_base::refresh): New methods.
1812         (tui_refresh_all): Call the refresh method.
1813         * tui/tui-data.h (struct tui_win_info)
1814         (struct tui_source_window_base) <refresh>: New method.
1815
1816 2019-06-25  Tom Tromey  <tom@tromey.com>
1817
1818         * tui/tui.h (tui_is_window_visible): Return bool.
1819         * tui/tui.c (tui_is_window_visible): Return bool.
1820         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1821         (tui_make_visible, tui_make_invisible)
1822         (tui_win_info::make_visible)
1823         (tui_source_window_base::make_visible, make_all_visible)
1824         (tui_make_all_visible, tui_make_all_invisible): Update.
1825         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1826         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1827         bool.
1828         (struct tui_win_info, struct tui_source_window_base)
1829         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1830         * tui/tui-data.c (tui_init_generic_part): Update.
1831
1832 2019-06-25  Tom Tromey  <tom@tromey.com>
1833
1834         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1835         (tui_source_window_base::make_visible): New methods.
1836         (make_all_visible): Make method call.
1837         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1838         (struct tui_source_window_base, struct tui_cmd_window): Override
1839         make_visible.
1840         (tui_win_is_source_type): Don't declare.
1841         * tui/tui-data.c (tui_win_is_source_type): Remove.
1842
1843 2019-06-25  Tom Tromey  <tom@tromey.com>
1844
1845         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1846         NULL check.
1847
1848 2019-06-25  Tom Tromey  <tom@tromey.com>
1849
1850         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1851         Inline constructor.  Add initializers for members.
1852         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1853         constructors; now inline in class.
1854
1855 2019-06-25  Tom Tromey  <tom@tromey.com>
1856
1857         * tui/tui-regs.c (tui_show_registers): Update.
1858         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1859         bool.
1860         * tui/tui-data.c (tui_data_window::clear_detail)
1861         (tui_data_window): Update.
1862
1863 2019-06-25  Tom Tromey  <tom@tromey.com>
1864
1865         * tui/tui-windata.c (tui_display_all_data)
1866         (tui_display_data_from_line, tui_display_data_from)
1867         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1868         Update.
1869         * tui/tui-regs.c (tui_last_regs_line_no)
1870         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1871         (tui_show_registers, tui_show_register_group)
1872         (tui_display_registers_from, tui_display_reg_element_at_line)
1873         (tui_display_registers_from_line, tui_check_register_values)
1874         (tui_reg_next, tui_reg_prev): Update.
1875         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1876         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1877         tui_data_window.
1878         (struct tui_win_info) <detail>: Remove.  Add new fields from
1879         tui_data_info.
1880         (TUI_DATA_WIN): Add cast.
1881         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1882         (~tui_data_window): Simplify.
1883
1884 2019-06-25  Tom Tromey  <tom@tromey.com>
1885
1886         * tui/tui-layout.c (show_source_disasm_command)
1887         (show_source_or_disasm_and_command): Update.
1888         * tui/tui-io.c (update_cmdwin_start_line)
1889         (tui_redisplay_readline): Update.
1890         * tui/tui-data.h (struct tui_command_info): Remove.
1891         (struct tui_win_info) <detail>: Remove command_info member.
1892         (struct tui_data_window) <start_line>: New member, from
1893         tui_command_info.
1894         (TUI_CMD_WIN): Add casts.
1895
1896 2019-06-25  Tom Tromey  <tom@tromey.com>
1897
1898         * tui/tui-winsource.c (tui_update_source_window)
1899         (tui_refill_source_window)
1900         (tui_source_window_base::do_scroll_horizontal)
1901         (tui_update_breakpoint_info, tui_set_exec_info_content)
1902         (tui_show_exec_info_content, tui_erase_exec_info_content)
1903         (tui_clear_exec_info_content): Update.
1904         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1905         Update.
1906         * tui/tui-win.c (make_invisible_and_set_new_height)
1907         (make_visible_with_new_height): Update.
1908         * tui/tui-source.c (tui_set_source_content)
1909         (tui_show_symtab_source): Update.
1910         * tui/tui-layout.c (extract_display_start_addr)
1911         (show_source_disasm_command, show_data)
1912         (make_source_or_disasm_window)
1913         (show_source_or_disasm_and_command): Update.
1914         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1915         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1916         "gdbarch".
1917         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1918         to tui_source_window_base.
1919         (struct tui_win_info) <detail>: Remove source_info member.
1920         (struct tui_source_window_base) <has_locator>: Inline.
1921         Move contents from tui_source_info; rename has_locator member to
1922         m_has_locator.
1923         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1924         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1925         header file.
1926         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1927         Simplify.
1928         (tui_free_all_source_wins_content): Cast to
1929         tui_source_window_base.
1930
1931 2019-06-25  Tom Tromey  <tom@tromey.com>
1932
1933         * tui/tui-win.c (make_invisible_and_set_new_height)
1934         (make_visible_with_new_height): Call has_locator method.
1935         * tui/tui-layout.c (show_source_disasm_command, show_data)
1936         (show_source_or_disasm_and_command): Update for bool change.
1937         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1938         (tui_win_info) <has_locator>: New method.
1939         (struct tui_source_window_base) <has_locator>: New method.
1940         (tui_win_has_locator): Don't declare.
1941         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1942         from tui_win_has_locator.
1943         (tui_source_window_base): Use false, not FALSE.
1944
1945 2019-06-25  Tom Tromey  <tom@tromey.com>
1946
1947         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1948         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1949         clear_detail method directly.
1950         (tui_clear_win_detail): Remove.
1951
1952 2019-06-25  Tom Tromey  <tom@tromey.com>
1953
1954         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1955         "this", not TUI_DISASM_WIN.
1956
1957 2019-06-25  Tom Tromey  <tom@tromey.com>
1958
1959         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1960         declare.
1961         * tui/tui-winsource.c
1962         (tui_source_window_base::do_scroll_horizontal): Rename from
1963         tui_horizontal_source_scroll.
1964         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1965         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1966         from tui_vertical_data_scroll.
1967         * tui/tui-win.h (tui_scroll): Don't declare.
1968         * tui/tui-win.c (tui_win_info::forward_scroll)
1969         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1970         (tui_win_info::right_scroll): Rename and update.
1971         (tui_scroll_forward_command, tui_scroll_backward_command)
1972         (tui_scroll_left_command, tui_scroll_right_command): Update.
1973         (tui_scroll): Remove.
1974         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1975         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1976         from tui_vertical_source_scroll.
1977         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1978         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1979         from tui_vertical_disassem_scroll.
1980         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1981         do_scroll_horizontal>: New methods.
1982         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1983         Likewise.
1984         (struct tui_source_window_base): Add do_scroll_horizontal.
1985         (struct tui_source_window, struct tui_disasm_window): Add
1986         do_scroll_vertical.
1987         (struct tui_data_window, struct tui_cmd_window): Add
1988         do_scroll_horizontal and do_scroll_vertical.
1989         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1990
1991 2019-06-25  Tom Tromey  <tom@tromey.com>
1992
1993         * tui/tui-data.h (struct tui_source_window_base): New struct.
1994         (struct tui_source_window): Derive from tui_source_window_base.
1995         (struct tui_disasm_window): New struct.
1996         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1997         from tui_source_window::clear_detail.
1998         (tui_source_window_base): Rename from tui_source_window.
1999         (~tui_source_window_base): Rename from ~tui_source_window.
2000         (tui_alloc_win_info): Create a tui_disasm_window.
2001
2002 2019-06-25  Tom Tromey  <tom@tromey.com>
2003
2004         * tui/tui-data.h (struct tui_source_window)
2005         (struct tui_data_window): Declare destructors.
2006         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2007         destructors.
2008         (tui_win_info): Simplify.
2009
2010 2019-06-25  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-winsource.c (tui_display_main)
2013         (tui_update_source_windows_with_addr)
2014         (tui_update_all_breakpoint_info): Update.
2015         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2016         (new_height_ok, parse_scrolling_args): Update.
2017         * tui/tui-stack.c (tui_show_frame_info): Update.
2018         * tui/tui-data.h (struct tui_list): Remove.
2019         (tui_source_windows): Return a reference to a std::vector.
2020         * tui/tui-data.c (source_windows): Now a std::vector.
2021         (tui_source_windows): Change return type.
2022         (tui_clear_source_windows): Rewrite.
2023         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2024         (tui_free_all_source_wins_content): Rewrite.
2025
2026 2019-06-25  Tom Tromey  <tom@tromey.com>
2027
2028         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2029         (struct tui_data_window, struct tui_cmd_window): Declare
2030         clear_detail method.
2031         * tui/tui-data.c (tui_source_window::clear_detail)
2032         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2033         methods.
2034         (tui_clear_win_detail): Simplify.
2035
2036 2019-06-25  Tom Tromey  <tom@tromey.com>
2037
2038         * tui/tui-layout.c (make_source_window, make_disasm_window)
2039         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2040         Return the new window.
2041         (show_source_disasm_command, show_data)
2042         (show_source_or_disasm_and_command): Update.
2043
2044 2019-06-25  Tom Tromey  <tom@tromey.com>
2045
2046         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2047         parameter.  Return the new window.
2048         (show_source_disasm_command): Update and remove NULL check.
2049         (show_source_or_disasm_and_command): Update.
2050
2051 2019-06-25  Tom Tromey  <tom@tromey.com>
2052
2053         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2054
2055 2019-06-25  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-data.h (struct tui_win_info): Make constructor
2058         protected.  Make destructor virtual.  Add initializers.
2059         (tui_source_window, tui_data_window, tui_cmd_window): New
2060         classes.
2061         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2062         constructor.  Add "type" parameter.
2063         (tui_source_window, tui_data_window, tui_cmd_window): New
2064         constructors.
2065         (tui_alloc_win_info): Instantiate the appropriate subclass.
2066
2067 2019-06-25  Tom Tromey  <tom@tromey.com>
2068
2069         * tui/tui-win.c (tui_resize_all): Use delete.
2070         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2071         destructor.
2072         (tui_free_window): Don't declare.
2073         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2074         Update.
2075
2076 2019-06-25  Tom Tromey  <tom@tromey.com>
2077
2078         * tui/tui-data.h (struct tui_win_info): Add constructor.
2079         * tui/tui-data.c (tui_alloc_win_info): Use new.
2080         (tui_free_window): Use delete.
2081
2082 2019-06-22  Tom Tromey  <tom@tromey.com>
2083
2084         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2085         declare.
2086         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2087
2088 2019-06-22  Tom Tromey  <tom@tromey.com>
2089
2090         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2091         declare.
2092         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2093
2094 2019-06-22  Tom de Vries  <tdevries@suse.de>
2095
2096         * dwarf2read.c (create_addrmap_from_aranges)
2097         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2098         instead of '%zu'.
2099
2100 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2101
2102         * dwarf2read.h (dwarf2_section_info_def): Remove.
2103         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2104         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2105         std::vector<dwarf2_section_info>.
2106         (struct dwo_file) <~dwo_file>: Remove.
2107         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2108         types field.
2109         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2110         (dwarf2_read_debug_names): Likewise.
2111         (create_debug_types_hash_table): Change parameter type to
2112         array_view, adjust code accordingly.
2113         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2114         (partial_die_info::fixup): Likewise.
2115         (determine_prefix): Likewise.
2116         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2117
2118 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2119
2120         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2121         gdb_bfd_ref_ptr.
2122         <~dwo_file>: Remove call to gdb_bfd_unref.
2123         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2124         gdb_bfd_ref_ptr::get.
2125
2126 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2127
2128         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2129         type to htab_up.
2130         * dwarf2read.c (struct dwo_file): Initialize fields.
2131         <~dwo_file>: New.
2132         (free_dwo_file): Remove, move content to ~dwo_file.
2133         (struct dwo_file_deleter): Remove.
2134         (dwo_file_up>: Remove custom deleter.
2135         (free_dwo_files): Remove.
2136         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2137         dwo_files.
2138         (process_skeletonless_type_units): Call unique_ptr::get.
2139         (allocate_dwo_file_hash_table): Add deleter to created hash
2140         table.  Change return type to htab_up.
2141         (lookup_dwo_file_slot): Don't memset dwo_file, call
2142         unique_ptr::get.
2143         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2144         (create_dwo_unit_in_dwp_v2): Likewise.
2145         (open_and_init_dwo_file): Likewise.
2146         (free_dwo_file_from_slot): Remove.
2147
2148 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2149
2150         * dwarf2read.h (struct dwarf2_section_info) <readin,
2151         is_virtual>: Change type to bool.
2152         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2153         true instead of 1.
2154
2155 2019-06-19  Tom Tromey  <tom@tromey.com>
2156
2157         * tui/tui-data.h (tui_init_content_element): Don't declare.
2158
2159 2019-06-19  Tom Tromey  <tom@tromey.com>
2160
2161         * tui/tui-data.h (tui_init_win_info): Don't declare.
2162
2163 2019-06-19  Tom de Vries  <tdevries@suse.de>
2164
2165         * dwarf2read.h (abstract_to_concrete): Change type to
2166         std::unordered_map<sect_offset, std::vector<sect_offset>,
2167         gdb::hash_enum<sect_offset>>.
2168
2169 2019-06-19  Tom Tromey  <tromey@adacore.com>
2170
2171         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2172         EVAL_AVOID_SIDE_EFFECTS specially.
2173
2174 2019-06-19  Tom Tromey  <tromey@adacore.com>
2175
2176         * source-cache.c (highlighter): New global.
2177         (source_cache::get_source_lines): Create a highlighter on demand.
2178
2179 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2180
2181         * defs.h (deprecated_interactive_hook): Delete declaration.
2182         * interps.c (clear_interpreter_hooks): Remove use of
2183         deprecated_interactive_hook.
2184         * top.c (deprecated_interactive_hook): Delete definition.
2185         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2186
2187 2019-06-18  Tom de Vries  <tdevries@suse.de>
2188
2189         PR gdb/24515
2190         * dwarf2read.h (abstract_to_concrete): Change type from
2191         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2192         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2193         * dwarf2read.c (read_variable): Update.
2194         (dwarf2_fetch_die_loc_sect_off): Update.
2195
2196 2019-06-17  Tom de Vries  <tdevries@suse.de>
2197
2198         PR gdb/24617
2199         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2200         accessing parent[parent_len - 1].
2201
2202 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2203
2204         PR gdb/24364
2205         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2206         call dtrace_process_dof with NULL dof.
2207
2208 2019-06-16  Tom de Vries  <tdevries@suse.de>
2209
2210         PR gdb/24445
2211         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2212
2213 2019-06-16  Tom Tromey  <tom@tromey.com>
2214
2215         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2216         (make_all_visible): Use address of member.
2217
2218 2019-06-16  Tom Tromey  <tom@tromey.com>
2219
2220         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2221         (tui_free_window, free_content, free_content_elements): Remove
2222         unnecessary cast.
2223         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2224         cast.
2225         * tui/tui-regs.c (tui_show_register_group)
2226         (tui_display_registers_from, tui_display_reg_element_at_line):
2227         Remove unnecessary cast.
2228
2229 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2230
2231         * linux-nat.c (normal_mask): Delete.
2232         (_initialize_linux_nat): Don't initialise normal_mask.
2233
2234 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2235
2236         PR gdb/24445
2237         * dwarf-index-write.h (write_psymtabs_to_index): Add
2238         dwz_basename parameter.
2239         * dwarf-index-write.c (write_gdbindex): Move file writing to
2240         write_gdbindex_1.  Change return type void.
2241         (assert_file_size): Move up, remove filename parameter.
2242         (write_gdbindex_1): New function.
2243         (write_debug_names): Change return type to void, call
2244         assert_file_size.
2245         (struct index_wip_file): New struct.
2246         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2247         file logic to index_wip_file.  Write index for dwz file if
2248         needed.
2249         (save_gdb_index_command): Pass basename of dwz file, if present.
2250         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2251         build-id of dwz file, if present.
2252         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2253         (dwarf2_get_dwz_file): Likewise.
2254         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2255         (dwarf2_get_dwz_file): Likewise.
2256
2257 2019-06-16  Tom Tromey  <tom@tromey.com>
2258
2259         * coffread.c (process_coff_symbol): Use xstrdup.
2260         * value.c (create_internalvar): Use xstrdup.
2261
2262 2019-06-16  Tom Tromey  <tom@tromey.com>
2263
2264         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2265         * breakpoint.c (stopin_command, stopat_command)
2266         (until_break_command, decode_location_default): Remove unnecessary
2267         cast.
2268         * utils.c (subset_compare): Remove unnecessary cast.
2269         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2270         cast.
2271         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2272         cast.
2273         * infcmd.c (path_command): Remove unnecessary cast.
2274         * coffread.c (decode_type): Remove unnecessary cast.
2275         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2276         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2277         * tui/tui-stack.c (tui_show_locator_content)
2278         (tui_show_frame_info): Remove unnecessary cast.
2279         * tui/tui-win.c (tui_scroll_forward_command)
2280         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2281         (parse_scrolling_args): Remove unnecessary cast.
2282         * tui/tui-data.c (init_win_info, tui_del_window)
2283         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2284         (free_content_elements): Remove unnecessary cast.
2285         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2286         unnecessary cast.
2287         * tui/tui-source.c (tui_set_source_content)
2288         (tui_vertical_source_scroll): Remove unnecessary cast.
2289         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2290         cast.
2291         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2292         * tui/tui-regs.c (tui_display_registers_from)
2293         (tui_display_register): Remove unnecessary cast.
2294         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2295         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2296         (make_visible): Remove unnecessary cast.
2297         * tui/tui-winsource.c (tui_erase_source_content)
2298         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2299         unnecessary cast.
2300         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2301         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2302         * stabsread.c (read_type, read_array_type, read_range_type):
2303         Remove unnecessary cast.
2304         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2305         (parse_symbol, parse_type, upgrade_type, parse_external)
2306         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2307         unnecessary cast.
2308         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2309
2310 2019-06-16  Tom Tromey  <tom@tromey.com>
2311
2312         * tui/tui-data.c (tui_alloc_generic_win_info)
2313         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2314         checks.
2315
2316 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2317             Andrew Burgess  <andrew.burgess@embecosm.com>
2318
2319         * f-typeprint.c (f_print_type): Don't return early for not
2320         associated or not allocated types.
2321         (f_type_print_varspec_suffix): Add print_rank parameter and print
2322         ranks of array types in case they dangling.
2323         (f_type_print_base): Add print_rank parameter.
2324
2325 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2326
2327         * NEWS: Mention new MI commands.
2328         * break-catch-throw.c (enum exception_event_kind): Move to
2329         breakpoint.h.
2330         (print_mention_exception_catchpoint): Output text as a single
2331         message.
2332         (catch_exception_command_1): Rename to...
2333         (catch_exception_event): ...this, make non-static, update header
2334         command, and change some parameter types.
2335         (catch_catch_command): Update for changes to
2336         catch_exception_command_1.
2337         (catch_throw_command): Likewise.
2338         (catch_rethrow_command): Likewise.
2339         * breakpoint.c (enum exception_event_kind): Delete.
2340         * breakpoint.h (enum exception_event_kind): Moved here from
2341         break-catch-throw.c.
2342         (catch_exception_event): Declare.
2343         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2344         (mi_cmd_catch_throw): New function.
2345         (mi_cmd_catch_rethrow): New function.
2346         (mi_cmd_catch_catch): New function.
2347         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2348         'catch-catch' entries.
2349         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2350         (mi_cmd_catch_rethrow): Declare.
2351         (mi_cmd_catch_catch): Declare.
2352
2353 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2354
2355         * annotate.c (annotate_source_line): Change return type to void,
2356         update implementation to match.
2357         * annotate.h (annotate_source_line): Change return type to void,
2358         update header comment.
2359         * stack.c (print_frame_info): Don't change what frame information
2360         is printed based on whether annotations are on or not.
2361
2362 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2363
2364         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2365         (annotate_source): Make static.
2366         (annotate_source_line): Moved from source.c and renamed from
2367         identify_source_line.  Update the return type.
2368         * annotate.h (annotate_source): Delete declaration.
2369         (annotate_source_line): Declaration moved from source.h, and
2370         renamed from identify_source_line.  Return type updated.
2371         * source.c (identify_source_line): Moved to annotate.c and renamed
2372         to annotate_source_line.
2373         (info_line_command): Remove check of annotation_level.
2374         * source.h (identify_source_line): Move declaration to annotate.h
2375         and rename to annotate_source_line.
2376         * stack.c: Add 'annotate.h' include.
2377         (print_frame_info): Remove check of annotation_level before
2378         calling annotate_source_line.
2379
2380 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2381
2382         * source-cache.c (source_cache::get_plain_source_lines): Use
2383         open_source_file_with_line_charpos instead of just
2384         open_source_file, remove call to find_source_lines.
2385         (source_cache::get_source_lines): Likewise.
2386         * source.c (find_source_lines): Make static.
2387         (get_filename_and_charpos): Renamed into...
2388         (open_source_file_with_line_charpos): ..this along with changes to
2389         return a scoped_fd, and some other minor clean ups.
2390         (identify_source_line): Use open_source_file_with_line_charpos.
2391         (search_command_helper): Use open_source_file_with_line_charpos
2392         instead of just open_source_file, remove call to
2393         find_source_lines.
2394         * source.h (open_source_file_with_line_charpos): Declare new
2395         function.
2396         (find_source_lines): Delete declaration.
2397
2398 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2399
2400         * source.c (get_filename_and_charpos): Remove fullname
2401         parameter.
2402         (identify_source_line): Update call to get_filename_and_charpos.
2403
2404 2019-06-14  Tom Tromey  <tromey@adacore.com>
2405
2406         PR gdb/24502:
2407         * ui-style.h (skip_ansi_escape): Update comment.
2408         * ui-file.h (class no_terminal_escape_file): New class.
2409         * ui-file.c (no_terminal_escape_file::write)
2410         (no_terminal_escape_file::puts): New methods.
2411         * cli/cli-logging.c (handle_redirections): Use
2412         no_terminal_escape_file.
2413
2414 2019-06-14  Tom Tromey  <tromey@adacore.com>
2415
2416         * NEWS: Move convenience variable news above Python news.
2417
2418 2019-06-14  Tom Tromey  <tom@tromey.com>
2419
2420         * gnulib: Move directory to top-level.
2421         * configure.ac: Don't configure gnulib.
2422         * configure: Rebuild.
2423         * common/common-defs.h: Use new path to gnulib.
2424         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2425         (GNULIB_H): Remove.
2426         (INCGNU): Look in new gnulib location.
2427         (HFILES_NO_SRCDIR): Remove gnulib files.
2428         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2429         (generated_files): Remove GNULIB_H.
2430         ($(LIBGNU), all-lib): Remove targets.
2431         (distclean): Don't mention GNULIB_BUILDDIR.
2432         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2433
2434 2019-06-14  Tom Tromey  <tromey@adacore.com>
2435
2436         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2437         Warn if symbol file does not provide any symbols.
2438
2439 2019-06-14  Tom Tromey  <tromey@adacore.com>
2440
2441         * source.c (find_and_open_source): Respect basenames_may_differ.
2442
2443 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2444
2445         * annotate.c (annotate_breakpoints_invalid): Make use of
2446         scoped_restore_terminal_state.
2447         (annotate_frames_invalid): Likewise.
2448
2449 2019-06-14  Tom Tromey  <tromey@adacore.com>
2450
2451         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2452         allow assignment to an internalvar.
2453
2454 2019-06-14  Tom Tromey  <tromey@adacore.com>
2455
2456         * ada-lex.l: Allow "_" in attribute names.
2457
2458 2019-06-14  Tom Tromey  <tromey@adacore.com>
2459
2460         PR gdb/24653:
2461         * regcache.c (registers_changed): Don't call alloca.
2462         * top.c (execute_command): Don't call alloca.
2463
2464 2019-06-13  Pedro Alves  <palves@redhat.com>
2465
2466         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2467         'expression'.  When parsing an expression, error out if there's
2468         junk after "unlimited".
2469         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2470         (do_set_command): Adjust calls to is_unlimited_literal.
2471
2472 2019-06-13  Pedro Alves  <palves@redhat.com>
2473
2474         * compile/compile.c (make_compile_options_def_group): Add braces
2475         around array_view initializer.
2476         * thread.c (make_thread_apply_all_options_def_group)
2477         (make_thread_apply_all_options_def_group): Likewise.
2478
2479 2019-06-13  Pedro Alves  <palves@redhat.com>
2480
2481         * NEWS (New commands): Mention "maint test-options
2482         require-delimiter", "maint test-options unknown-is-error", "maint
2483         test-options unknown-is-operand" and "maint show
2484         test-options-completion-result".
2485         (New command options, command completion): New section.
2486         (Completion improvements): New section.
2487         Mention that you can abbreviate "unlimited".
2488
2489 2019-06-13  Pedro Alves  <palves@redhat.com>
2490
2491         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2492         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2493         * unittests/cli-utils-selftests.c (test_parse_flags)
2494         (test_parse_flags_qcs): Delete.
2495         (test_cli_utils): Don't call deleted functions.
2496
2497 2019-06-13  Pedro Alves  <palves@redhat.com>
2498
2499         * thread.c: Include "cli/cli-option.h".
2500         (tp_array_compar_ascending): Global.
2501         (tp_array_compar): Delete function.
2502         (tp_array_compar_ascending, tp_array_compar_descending): New
2503         functions.
2504         (ascending_option_def, qcs_flag_option_def)
2505         (thr_qcs_flags_option_defs)
2506         (make_thread_apply_all_options_def_group)
2507         (make_thread_apply_options_def_group): New.
2508         (thread_apply_all_command): Use gdb::option::process_options.
2509         (thread_apply_command_completer)
2510         (thread_apply_all_command_completer): New.
2511         (thread_apply_command): Use gdb::option::process_options.
2512         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2513         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2514         to generate help text of "thread apply".  Adjust "taas"'s help.
2515         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2516         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2517
2518 2019-06-13  Pedro Alves  <palves@redhat.com>
2519
2520         * thread.c (thread_apply_command): Check for invalid TID with
2521         isdigit instead of !isalpha.
2522
2523 2019-06-13  Pedro Alves  <palves@redhat.com>
2524
2525         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2526         (validate_flags_qcs): New.
2527         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2528         (validate_flags_qcs): Declare.
2529         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2530         (make_frame_apply_options_def_group): New.
2531         (frame_apply_command_count): Process options with
2532         gdb::option::process_options.
2533         (frame_apply_completer): New.
2534         (frame_apply_level_completer, frame_apply_all_completer)
2535         (frame_apply_completer): New.
2536         (_initialize_stack): Update help of "frame apply", "frame apply
2537         level", "frame apply all" and "faas" to mention supported options
2538         and install command completers.
2539         * stack.h (frame_apply_all_completer): Declare.
2540         * thread.c: Include "stack.h".
2541         (tfaas_command): Add "--".
2542         (_initialize_thread): Update help "tfaas" to mention supported
2543         options and install command completer.
2544
2545 2019-06-13  Pedro Alves  <palves@redhat.com>
2546
2547         * completer.c (complete_nested_command_line): New.
2548         (gdb_completion_word_break_characters_throw): Add assertion.
2549         * completer.h (complete_nested_command_line): Declare.
2550
2551 2019-06-13  Pedro Alves  <palves@redhat.com>
2552
2553         * stack.c (parse_backtrace_qualifiers): New.
2554         (backtrace_command): Use it.
2555         (backtrace_command_completer): Complete on qualifiers.
2556
2557 2019-06-13  Pedro Alves  <palves@redhat.com>
2558
2559         * frame.c: Include "cli/cli-option.h.
2560         (user_set_backtrace_options): New.
2561         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2562         Delete.
2563         (get_prev_frame): Adjust.
2564         (boolean_option_def, uinteger_option_def)
2565         (set_backtrace_option_defs): New.
2566         (_initialize_frame): Adjust and use
2567         gdb::option::add_setshow_cmds_for_options to install "set
2568         backtrace past-main" and "set backtrace past-entry".
2569         * frame.h: Include "cli/cli-option.h".
2570         (struct frame_print_options): Forward declare.
2571         (print_frame_arguments_all, print_frame_arguments_scalars)
2572         (print_frame_arguments_none): Declare.
2573         (print_entry_values): Delete declaration.
2574         (struct frame_print_options, user_frame_print_options): New.
2575         (struct set_backtrace_options): New.
2576         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2577         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2578         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2579         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2580         (list_args_or_locals): Add frame_print_options parameter.
2581         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2582         * python/py-framefilter.c (enumerate_args): Pass down
2583         USER_FRAME_PRINT_OPTIONS.
2584         * stack.c: Include "cli/cli-option.h".
2585         (print_frame_arguments_all, print_frame_arguments_scalars)
2586         (print_frame_arguments_none): Declare.
2587         (print_raw_frame_arguments, print_entry_values): Delete.
2588         (user_frame_print_options): New.
2589         (boolean_option_def, enum_option_def, frame_print_option_defs):
2590         New.
2591         (struct backtrace_cmd_options): New.
2592         (bt_flag_option_def): New.
2593         (backtrace_command_option_defs): New.
2594         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2595         (print_frame_arg, read_frame_arg, print_frame_args)
2596         (print_frame_info, print_frame): Add frame_print_options parameter
2597         and use it.
2598         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2599         (backtrace_command_1): Add frame_print_options and
2600         backtrace_cmd_options parameters and use them.
2601         (make_backtrace_options_def_group): New.
2602         (backtrace_command): Process command options with
2603         gdb::option::process_options.
2604         (backtrace_command_completer): New.
2605         (_initialize_stack): Extend "backtrace"'s help to mention
2606         supported options.  Install completer for "backtrace".
2607         Install some settings commands with add_setshow_cmds_for_options.
2608
2609 2019-06-13  Pedro Alves  <palves@redhat.com>
2610
2611         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2612         and that "set/show print raw frame-arguments" are now deprecated.
2613
2614         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2615         command.
2616         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2617         * stack.c (_initialize_stack): Install "set/show print
2618         raw-frame-arguments", and deprecate "set/show print raw
2619         frame-arguments".
2620         * valprint.c (_initialize_valprint): Deprecate "set/show print
2621         raw".
2622
2623 2019-06-13  Pedro Alves  <palves@redhat.com>
2624
2625         * compile/compile.c (struct compile_options): New.
2626         (compile_flag_option_def, compile_command_option_defs)
2627         (make_compile_options_def_group): New.
2628         (compile_file_command): Handle options with
2629         gdb::option::process_options.
2630         (compile_file_command_completer): New function.
2631         (compile_code_command): Handle options with
2632         gdb::option::process_options.
2633         (compile_code_command_completer): New function.
2634         (_initialize_compiler): Install completers for "compile code" and
2635         "compile file".  Mention available options in "compile code" and
2636         "compile code"'s help.
2637         * completer.c (advance_to_completion_word): New, factored out from
2638         ...
2639         (advance_to_expression_complete_word_point): ... this.
2640         (advance_to_filename_complete_word_point): New.
2641         * completer.h (advance_to_filename_complete_word_point): New
2642         declaration.
2643
2644 2019-06-13  Pedro Alves  <palves@redhat.com>
2645
2646         * compile/compile.c: Include "cli/cli-option.h".
2647         (compile_print_value): Scope data pointer is now a
2648         value_print_options pointer; adjust.
2649         (compile_print_command): Process options.  Scope data pointer is
2650         now a value_print_options pointer; adjust.
2651         (_initialize_compile): Update "compile print"'s help to include
2652         supported options.  Install a completer for "compile print".
2653         * cp-valprint.c (show_vtblprint, show_objectprint)
2654         (show_static_field_print): Delete.
2655         (_initialize_cp_valprint): Don't install "set print
2656         static-members", "set print vtbl", "set print object" here.
2657         * printcmd.c: Include "cli/cli-option.h" and
2658         "common/gdb_optional.h".
2659         (print_command_parse_format): Rework to fill in a
2660         value_print_options instead of a format_data.
2661         (print_value): Change parameter type from format_data pointer to
2662         value_print_options reference.  Adjust.
2663         (print_command_1): Process options.  Adjust to pass down a
2664         value_print_options.
2665         (print_command_completer): New.
2666         (_initialize_printcmd): Install print_command_completer as
2667         handle_brkchars completer for the "print" command.  Update
2668         "print"'s help to include supported options.
2669         * valprint.c: Include "cli/cli-option.h".
2670         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2671         here from cp-valprint.c.
2672         (boolean_option_def, uinteger_option_def)
2673         (value_print_option_defs, make_value_print_options_def_group):
2674         New.  Use gdb::option::add_setshow_cmds_for_options to install
2675         "set print elements", "set print null-stop", "set print repeats",
2676         "set print pretty", "set print union", "set print array", "set
2677         print address", "set print symbol", "set print array-indexes".
2678         * valprint.h: Include <string> and "cli/cli-option.h".
2679         (make_value_print_options_def_group): Declare.
2680         (print_value): Change parameter type from format_data pointer to
2681         value_print_options reference.
2682         (print_command_completer): Declare.
2683
2684 2019-06-13  Pedro Alves  <palves@redhat.com>
2685
2686         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2687         (COMMON_SFILES): Add maint-test-settings.c.
2688         * cli/cli-decode.c (boolean_enums): New global, factored out from
2689         ...
2690         (add_setshow_boolean_cmd): ... here.
2691         * cli/cli-decode.h (boolean_enums): Declare.
2692         * cli/cli-option.c: New file.
2693         * cli/cli-option.h: New file.
2694         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2695         factored out from ...
2696         (parse_cli_boolean_value(const char *)): ... this.
2697         (is_unlimited_literal): Change parameter type to pointer to
2698         pointer.  Adjust and advance ARG pointer.
2699         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2700         (parse_cli_var_enum): New, factored out from ...
2701         (do_set_command): ... this.  Adjust.
2702         * cli/cli-setshow.h (parse_cli_boolean_value)
2703         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2704         (parse_cli_var_enum): Declare.
2705         * cli/cli-utils.c: Include "cli/cli-option.h".
2706         (get_ulongest): New.
2707         * cli/cli-utils.h (get_ulongest): Declare.
2708         (check_for_argument): New overloads.
2709         * maint-test-options.c: New file.
2710
2711 2019-06-13  Pedro Alves  <palves@redhat.com>
2712
2713         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2714         parse a range if "-" is at the end of the string.
2715
2716 2019-06-13  Pedro Alves  <palves@redhat.com>
2717
2718         * cli/cli-setshow.c (parse_auto_binary_operation)
2719         (parse_cli_boolean_value): Don't allow "o".
2720
2721 2019-06-13  Pedro Alves  <palves@redhat.com>
2722
2723         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2724         * NEWS: Mention maint test-settings KIND.
2725         * maint-test-settings.c: New file.
2726
2727 2019-06-13  Pedro Alves  <palves@redhat.com>
2728
2729         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2730         completer.
2731         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2732         "set" completers.
2733
2734 2019-06-13  Pedro Alves  <palves@redhat.com>
2735
2736         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2737         after item.
2738
2739 2019-06-13  Pedro Alves  <palves@redhat.com>
2740
2741         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2742
2743 2019-06-13  Pedro Alves <palves@redhat.com>
2744
2745         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2746         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2747         call.
2748         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2749         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2750         calls.
2751         (check_for_argument): Skip spaces after argument.
2752
2753 2019-06-13  Pedro Alves  <palves@redhat.com>
2754
2755         * thread.c (thread_apply_command): Adjust TID parsing.
2756         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2757         detected before end of string.
2758         (tid_is_in_list): Error out if LIST is invalid.
2759
2760 2019-06-13  Pedro Alves  <palves@redhat.com>
2761
2762         * completer.c (complete_line_internal_1): Rewind completion word
2763         point.
2764         (completion_tracker::advance_custom_word_point_by): Change
2765         parameter type to int.
2766         * completer.h (completion_tracker::advance_custom_word_point_by):
2767         Likewise.
2768
2769 2019-06-13  Pedro Alves  <palves@redhat.com>
2770
2771         * completer.c (advance_to_completion_word): Handle delimiters.
2772
2773 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2774
2775         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2776
2777 2019-06-11  Tom Tromey  <tom@tromey.com>
2778
2779         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2780         (xmalloc_failed): Move to alloc.c.
2781         * alloc.c: New file.
2782         * Makefile.in (COMMON_SFILES): Add alloc.c.
2783
2784 2019-06-11  Tom Tromey  <tom@tromey.com>
2785
2786         * nat/linux-waitpid.c: Don't include server.h.
2787         (linux_debug): Remove.
2788         (my_waitpid): Update.
2789
2790 2019-06-11  Tom Tromey  <tromey@adacore.com>
2791
2792         * infcall.c (_initialize_infcall): Remove trailing newline from
2793         help.
2794         * user-regs.c (_initialize_user_regs): Remove trailing newline
2795         from help.
2796         * typeprint.c (_initialize_typeprint): Remove trailing newline
2797         from help.
2798         * reverse.c (_initialize_reverse): Remove trailing newlines from
2799         help.
2800         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2801         from help.
2802         * language.c (add_set_language_command): Remove trailing newline
2803         from help.
2804         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2805         help.
2806         * disasm.c (_initialize_disasm): Remove trailing newline from
2807         help.
2808         * top.c (init_main): Remove trailing newline from help.
2809         * interps.c (_initialize_interpreter): Remove trailing newline
2810         from help.
2811         * btrace.c (_initialize_btrace): Remove trailing newlines from
2812         help.
2813         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2814         from help.
2815         * python/python.c (_initialize_python): Remove trailing newline
2816         from help.
2817         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2818         help.
2819         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2820         from help.  Reformat some text.
2821         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2822         from help.
2823         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2824         newline from help.
2825
2826 2019-06-11  Tom Tromey  <tromey@adacore.com>
2827
2828         * darwin-nat.c (darwin_decode_exception_message)
2829         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2830
2831 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2832
2833         * valops.c (value_slice): Check for not allocated or not
2834         associated values.
2835
2836 2019-06-10  Tom de Vries  <tdevries@suse.de>
2837
2838         PR gdb/24618
2839         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2840         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2841         invalid.
2842
2843 2019-06-10  Tom de Vries  <tdevries@suse.de>
2844
2845         PR gdb/24611
2846         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2847         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2848
2849 2019-06-10  Tom de Vries  <tdevries@suse.de>
2850
2851         PR symtab/24545
2852         * symtab.c (struct demangled_name_entry): Add language field.
2853         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2854         static minimal symbol".  Set and use language field.
2855
2856 2019-06-10  Tom Tromey  <tromey@adacore.com>
2857
2858         * ada-lang.c (_initialize_ada_language): Update help text.
2859
2860 2019-06-10  Tom Tromey  <tromey@adacore.com>
2861
2862         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2863         with a newline.
2864         * guile/guile.c (handle_boot_error): Don't end warning with a
2865         newline.
2866         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2867         warning with a newline.
2868         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2869         newline.
2870         (s12z_frame_cache): Likewise.
2871         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2872         a newline.
2873         * solib-svr4.c (disable_probes_interface): Don't end warning with
2874         a newline.
2875         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2876         newline.
2877         * python/python.c (do_finish_initialization): Don't end warning
2878         with a newline.
2879
2880 2019-06-10  Tom Tromey  <tom@tromey.com>
2881
2882         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2883         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2884         gdbpy_enter.
2885
2886 2019-06-10  Tom Tromey  <tromey@adacore.com>
2887
2888         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2889         data.
2890         (elf_new_init): Don't call stabsread_new_init.
2891         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2892         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2893         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2894
2895 2019-06-10  Tom de Vries  <tdevries@suse.de>
2896
2897         PR symtab/16264
2898         PR symtab/24517
2899         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2900
2901 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2902
2903         * source.c (find_and_open_source): Also rewrite relative file
2904         names.
2905
2906 2019-04-26  Amos Bird  <amosbird@gmail.com>
2907
2908         * annotate.c (annotate_thread_exited): Add "thread-exited"
2909         annotation.
2910
2911 2019-06-06  Tom Tromey  <tromey@adacore.com>
2912
2913         * maint.h (class scoped_command_stats): Use
2914         DISABLE_COPY_AND_ASSIGN.
2915         <print_time>: New method.
2916         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2917         print_time.
2918         (scoped_command_stats::print_time): New method.
2919
2920 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2921
2922         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2923         instructions of lengths 6 or 8 bytes.
2924
2925 2019-06-04  Pedro Alves  <palves@redhat.com>
2926
2927         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2928
2929         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2930         * breakpoint.c (condition_completer): Likewise.
2931         * cli/cli-dump.c (scan_expression): Likewise.
2932         * common/filestuff.c (mkdir_recursive): Likewise.
2933         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2934         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2935         (gdb_abspath): Likewise.
2936         * compile/compile-cplus-types.c
2937         (compile_cplus_instance::decl_name): Likewise.
2938         * completer.c (complete_explicit_location):
2939         (signal_completer, reg_or_group_completer_1): Likewise.
2940         * cp-support.c (cp_remove_params_if_any): Likewise.
2941         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2942         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2943         * infcmd.c (strip_bg_char): Likewise.
2944         * linespec.c (copy_token_string): Likewise.
2945         * mi/mi-main.c (output_cores): Likewise.
2946         * psymtab.c (psymtab_search_name):
2947         * symfile.c (test_set_ext_lang_command): Likewise.
2948         * target.c (target_fileio_read_stralloc): Likewise.
2949         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2950         * value.c (complete_internalvar): Likewise.
2951
2952 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2953
2954         Add objfile property to gdb.Type.
2955         * NEWS: Mention Python API addition.
2956         * python/py-type.c (typy_get_objfile): New method.
2957
2958 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2959
2960         * NEWS: Mention the new set|show style [title|highlight].
2961         Mention changes to "show style", "help" and "apropos".
2962
2963 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2964
2965         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2966         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2967         instead of print_help_for_command.
2968         (print_doc_of_command): New function.
2969         (help_list): Add 'apropos -v word' suggestion.
2970         (print_help_for_command): Style the command name using title style.
2971         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2972         (_initialize_cli_cmds): Describe -v in apropos_command help.
2973
2974 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2975
2976         * cli/cli-style.h (cli_style_option): Add name in constructor,
2977         add m_name class member, add constructor with intensity,
2978         add name class function.
2979         (cli_style_option::add_setshow_commands): Remove name argument.
2980         (highlight_style, title_style): New styles.
2981         * cli/cli-style.c (do_show): New function that shows a style
2982         characteristic styling the style name with itself.
2983         (set_style_name): New function.
2984         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2985         Update all callers according to the changes in cli/cli-style.h.
2986         * utils.h (fputs_highlighted): New function.
2987         * utils.c (fputs_highlighted): Likewise.
2988
2989 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2990
2991         * NEWS: Mention new pipe command and new convenience variables.
2992
2993 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2994
2995         * cli/cli-cmds.c (pipe_command): New function.
2996         (_initialize_cli_cmds): Call add_com for pipe_command.
2997         Define | as an alias for pipe.
2998         (exit_status_set_internal_vars): New function.
2999         (shell_escape): Call exit_status_set_internal_vars.
3000         cli/cli-decode.c (find_command_name_length): Recognize | as
3001         a single character command.
3002
3003 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3004
3005         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3006         top.c (execute_command_to_ui_file): New function, mostly a copy
3007         of execute_command_to_string.
3008         (execute_command_to_string): Implement by calling
3009         execute_command_to_ui_file.
3010
3011 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3012
3013         * top.h (saved_command_line): Remove declaration.
3014         * top.c (previous_saved_command_line, previous_repeat_arguments):
3015         New variables.
3016         (saved_command_line): Make static, define together with other
3017         'repeat variables'.
3018         (dont_repeat): Clear repeat_arguments.
3019         (repeat_previous, get_saved_command_line, save_command_line):
3020         New functions.
3021         (gdb_init): Initialize saved_command_line
3022         and previous_saved_command_line.
3023         * main.c (captured_main_1): Remove saved_command_line initialization.
3024         * event-top.c (handle_line_of_input): Update to use
3025         the new 'repeat' related functions instead of direct access to
3026         saved_command_line.
3027         * command.h (repeat_previous, get_saved_command_line,
3028         save_command_line): New declarations.
3029         (dont_repeat): Add comment.
3030
3031 2019-05-30  Tom Tromey  <tromey@adacore.com>
3032
3033         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3034         Fix comment.
3035         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3036
3037 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3038
3039         PR cli/24587
3040         * completer.c (complete): Initialize variable word.
3041
3042 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3043
3044         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3045         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3046         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3047         'body' is NULL to the outter 'if', protecting the '!is_define'
3048         situation as well.
3049
3050 2019-05-29  Tom Tromey  <tromey@adacore.com>
3051
3052         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3053         (dwarf_unknown): New function.
3054         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3055         (dwarf_type_encoding_name): Use dwarf_unknown.
3056
3057 2019-05-29  Tom Tromey  <tromey@adacore.com>
3058
3059         PR c++/20020:
3060         * cp-valprint.c (cp_print_value_fields): Call
3061         cp_print_static_field inside "try".
3062
3063 2019-05-29  Tom Tromey  <tromey@adacore.com>
3064
3065         * inflow.c (struct terminal_info): Add default operator=.
3066         * configure: Rebuild.
3067         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3068         -Wdeprecated-copy-dtor, -Wredundant-move.
3069
3070 2019-05-29  Tom Tromey  <tromey@adacore.com>
3071
3072         * NEWS: Add entry.
3073         * infcmd.c (print_return_value_1): Handle finish_print
3074         option.
3075         (show_print_finish): New function.
3076         (_initialize_infcmd): Add "set/show print finish" commands.
3077         * valprint.c (user_print_options): Initialize new member.
3078         * valprint.h (struct value_print_options) <finish_print>: New
3079         member.
3080
3081 2019-05-28  Tom Tromey  <tromey@adacore.com>
3082
3083         * ada-lang.c (ada_remove_Xbn_suffix)
3084         (find_old_style_renaming_symbol)
3085         (parse_old_style_renaming): Remove.
3086         (ada_find_renaming_symbol): Don't call
3087         find_old_style_renaming_symbol.
3088         (ada_is_renaming_symbol): Rename from
3089         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3090         bool.  Now static.
3091         (ada_read_var_value): Update and simplify.
3092         * ada-exp.y (write_var_or_type): Remove old code.
3093
3094 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3095
3096         * event-top.c: Remove include comment.
3097         * inflow.c (class scoped_ignore_sigttou): Move from here...
3098         * inflow.h (class scoped_ignore_sigttou): ...to here.
3099         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3100         * top.c:  Remove include comment.
3101
3102 2019-05-27  Tom Tromey  <tom@tromey.com>
3103
3104         * NEWS: Fix typo.
3105
3106 2019-05-22  Tom Tromey  <tromey@adacore.com>
3107
3108         * target.c (target_follow_exec): Constify parameter.
3109         * target-delegates.c: Rebuild.
3110         * remote.c (remote_target::follow_exec): Constify parameter.
3111         * infrun.c (follow_exec): Constify parameter.
3112         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3113         (target_follow_exec): Likewise.
3114
3115 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3116
3117         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3118         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3119
3120 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3121
3122         * NEWS: Add debugredirect and testsuite sections.
3123
3124 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3125
3126         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3127         target descriptions using exclusively floating point register name
3128         aliases.
3129
3130 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3131
3132         PR gdb/18644:
3133         * f-lang.c (build_fortran_types): Handle the case where
3134         gdbarch_floatformat_for_type returns a nullptr.
3135
3136 2019-05-21  Tom de Vries  <tdevries@suse.de>
3137
3138         PR cli/24587
3139         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3140
3141 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3142
3143         PR gdb/18644:
3144         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3145         16-byte floats.
3146         * i386-tdep.c (i386_floatformat_for_type): Use
3147         floatformats_ia64_quad for the 16-byte floating point component
3148         within a fortran 32-byte complex number.
3149
3150 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3151
3152         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3153         delete default constructor.
3154         (find_partial_die): Update to return const struct.
3155         (partial_die_parent_scope): Move variable declaration into scope
3156         of its use and change its type to auto.
3157         (guess_partial_die_structure_name): Likewise.
3158         (partial_die_info::fixup): Likewise.
3159
3160 2019-05-17  Tom Tromey  <tromey@adacore.com>
3161
3162         * source.c (find_and_open_source): Remove cast.
3163
3164 2019-05-17  Tom Tromey  <tromey@adacore.com>
3165
3166         * annotate.c (annotate_source): Make "filename" const.
3167         * annotate.h (annotate_source): Use const.
3168
3169 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3170
3171         * disasm.c (set_disassembler_options): Send errors to stderr.
3172
3173 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3174
3175         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3176         (cli_interp_base::set_logging): Check debug_redirect.
3177         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3178         * cli/cli-logging.c (debug_redirect): Add static variable.
3179         (pop_output_files): Add default param.
3180         (handle_redirections): Print debug setting.
3181         (show_logging_command): Likewise.
3182         (_initialize_cli_logging): Add debugredirect command.
3183         * interps.c (current_interp_set_logging): Add debug_redirect
3184         parameter.
3185         * interps.h (set_logging): Add debug_redirect parameter.
3186         (current_interp_set_logging): Likewise.
3187         * mi/mi-common.h: Likewise.
3188         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3189
3190 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3191             Tom Tromey  <tromey@adacore.com>
3192
3193         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3194         directly.
3195         * cli/cli-interp.h (make_logging_output): Remove declaration.
3196         * cli/cli-logging.c (make_logging_output): Remove function.
3197         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3198         directly.
3199         * ui-file.c (tee_file::tee_file): Remove bools.
3200         (tee_file::~tee_file): Remove deletes.
3201         * ui-file.h (tee_file): Remove bools.
3202
3203 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3204
3205         * mi/mi-cmds.h (mi_cmd_complete): New function.
3206         * mi/mi-main.c (mi_cmd_complete): Likewise.
3207         * mi/mi-cmds.c: Define new MI command -complete.
3208         * NEWS: Mention new -complete command.
3209
3210 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3211
3212         * completer.h (complete): New function.
3213         * completer.c (complete): Likewise.
3214         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3215         function defined in completer.h.
3216
3217 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3218
3219         * MAINTAINERS (Write After Approval): Add myself.
3220
3221 2019-05-17  Tom de Vries  <tdevries@suse.de>
3222
3223         PR gdb/24094
3224         * dwarf2read.c (struct cu_partial_die_info): New struct.
3225         (find_partial_die): Return cu_partial_die_info.
3226         (partial_die_parent_scope, guess_partial_die_structure_name)
3227         (partial_die_info::fixup): Handle new return type of find_partial_die.
3228
3229 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3230
3231         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3232         "std::string", simplifying the algorithm.
3233
3234 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3235
3236         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3237         (stap_static_probe_ops::get_probes): Likewise.
3238
3239 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3240
3241         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3242         '-')" and "else if".
3243         (stap_parse_single_operand): Join checks for
3244         "gdbarch_stap_parse_special_token_p" and
3245         "gdbarch_stap_parse_special_token" in the same "if" statement.
3246         Invert check when verifying for operation on register
3247         displacement.
3248
3249 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3250
3251         * stap-probe.c (stap_get_opcode): Update comment.
3252         (stap_get_expected_argument_type): Likewise.
3253         (handle_stap_probe): Likewise.
3254
3255 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3256
3257         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3258         return type to 'bool'.  Adjust comment.  Use 'bool' when
3259         appropriate.
3260         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3261         * stap-probe.c (stap_parse_argument_1): Likewise.
3262         (stap_is_operator): Likewise.
3263         (stap_is_generic_prefix): Likewise.
3264         (stap_is_register_prefix): Likewise.
3265         (stap_is_register_indirection_prefix): Likewise.
3266         (stap_is_integer_prefix): Likewise.
3267         (stap_generic_check_suffix): Likewise.
3268         (stap_check_integer_suffix): Likewise.
3269         (stap_check_register_suffix): Likewise.
3270         (stap_check_register_indirection_suffix): Likewise.
3271         (stap_parse_register_operand): Likewise.
3272         (stap_parse_single_operand): Likewise.
3273         (stap_parse_argument_1): Likewise.
3274         (stap_probe::get_argument_count): Likewise.
3275         (stap_is_operator): Likewise.
3276
3277 2019-05-16  Tom Tromey  <tromey@adacore.com>
3278
3279         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3280         keyword to foreach.
3281
3282 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3283
3284         * linux-thread-db.c (try_thread_db_load_1): Change return type
3285         to bool.
3286         (try_thread_db_load): Likewise.
3287         (try_thread_db_load_from_pdir_1): Likewise.
3288         (try_thread_db_load_from_pdir): Likewise.
3289         (try_thread_db_load_from_sdir): Likewise.
3290         (try_thread_db_load_from_dir): Likewise.
3291         (thread_db_load_search): Likewise.
3292         (has_libpthread): Likewise.
3293         (thread_db_load): Likewise.
3294
3295 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3296
3297         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3298         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3299         NULL, and complain/return if that's the case.
3300
3301 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3302
3303         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3304         (advance, posn, abstract_read_memory): New functions.
3305         [struct mem_read_abstraction]: New struct.
3306         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3307
3308 2019-05-14  Tom Tromey  <tromey@adacore.com>
3309
3310         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3311         value is not lval_memory.
3312
3313 2019-05-14  Tom Tromey  <tromey@adacore.com>
3314
3315         * solib.c (info_sharedlibrary_command): Style the file name.
3316
3317 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3318
3319         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3320         (aarch64_vnv_type): Likewise.
3321         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3322         * common/tdesc.c: Likewise.
3323         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3324         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3325         * features/aarch64-fpu.xml: Add ieee half view.
3326         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3327         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3328         * gdbtypes.h (struct builtin_type): Likewise.
3329         (struct objfile_type): Likewise.
3330
3331 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3332
3333         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3334         typo.
3335         * location.h (string_to_event_location): Likewise.
3336
3337 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3338
3339         GDB 8.3 released.
3340
3341 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3342
3343         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3344         New variable declaration.
3345         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3346         New variable.
3347         (print_one_breakpoint): Use ui_out::test_flags and new global
3348         variable to compute use_fixed_output.
3349         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3350         Remove.
3351         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3352         (mi_multi_location_breakpoint_output_fixed): Remove.
3353         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3354         new variable.
3355         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3356         fix_multi_location_breakpoint_output flag if version >= 3.
3357         * ui-out.h (enum ui_out_flag)
3358         <fix_multi_location_breakpoint_output>: New enumerator.
3359
3360 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3361
3362         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3363
3364 2019-05-10  Tom Tromey  <tromey@adacore.com>
3365
3366         * ada-lang.c (catch_ada_completer): New function.
3367         (_initialize_ada_language): Use it.
3368
3369 2019-05-10  Tom Tromey  <tromey@adacore.com>
3370
3371         * thread.c (print_thread_info): Make "requested_threads" const.
3372         * gdbthread.h (print_thread_info): Make "requested_threads"
3373         const.
3374         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3375         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3376
3377 2019-05-08  Tom Tromey  <tom@tromey.com>
3378
3379         * gdbtypes.c (objfile_type_data): Change type.
3380         (objfile_type, _initialize_gdbtypes): Update.
3381
3382 2019-05-08  Tom Tromey  <tom@tromey.com>
3383
3384         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3385         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3386         (_initialize_dwarf2_frame): Update.
3387
3388 2019-05-08  Tom Tromey  <tom@tromey.com>
3389
3390         * objc-lang.c (objc_objfile_data): Change type.
3391         (find_methods): Update.
3392         (_initialize_objc_lang): Remove.
3393
3394 2019-05-08  Tom Tromey  <tom@tromey.com>
3395
3396         * stabsread.c (rs6000_builtin_type_data): Change type.
3397         (rs6000_builtin_type, _initialize_stabsread): Update.
3398
3399 2019-05-08  Tom Tromey  <tom@tromey.com>
3400
3401         * mips-tdep.c (mips_pdr_data): Remove.
3402         (_initialize_mips_tdep): Update.
3403
3404 2019-05-08  Tom Tromey  <tom@tromey.com>
3405
3406         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3407         (hppa_init_objfile_priv_data, read_unwind_info)
3408         (find_unwind_entry, _initialize_hppa_tdep): Update.
3409
3410 2019-05-08  Tom Tromey  <tom@tromey.com>
3411
3412         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3413         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3414         on obstack.
3415         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3416
3417 2019-05-08  Tom Tromey  <tom@tromey.com>
3418
3419         * mdebugread.c (basic_type_data): Change type.
3420         (basic_type, _initialize_mdebugread): Update.
3421
3422 2019-05-08  Tom Tromey  <tom@tromey.com>
3423
3424         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3425
3426 2019-05-08  Tom Tromey  <tom@tromey.com>
3427
3428         * nto-tdep.c (nto_inferior_data_reg): Change type.
3429         (nto_inferior_data): Update.
3430         (nto_inferior_data_cleanup, nto_new_inferior_data)
3431         (_initialize_nto_tdep): Remove.
3432         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3433
3434 2019-05-08  Tom Tromey  <tom@tromey.com>
3435
3436         * ada-lang.c (struct ada_inferior_data): Add initializers.
3437         (ada_inferior_data): Change type.
3438         (ada_inferior_data_cleanup): Remove.
3439         (get_ada_inferior_data, ada_inferior_exit)
3440         (struct ada_pspace_data): Add initializers, destructor.
3441         (ada_pspace_data_handle): Change type.
3442         (get_ada_pspace_data): Update.
3443         (ada_pspace_data_cleanup): Remove.
3444
3445 2019-05-08  Tom Tromey  <tom@tromey.com>
3446
3447         * coffread.c (struct coff_symfile_info): Add initializers.
3448         (coff_objfile_data_key): Move lower.  Change type.
3449         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3450         Update.
3451         (coff_free_info): Remove.
3452
3453 2019-05-08  Tom Tromey  <tom@tromey.com>
3454
3455         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3456         (fbsd_pspace_data_handle): Move lower.  Change type.
3457         (get_fbsd_pspace_data): Update.
3458         (fbsd_pspace_data_cleanup): Remove.
3459         (_initialize_fbsd_tdep): Update.
3460
3461 2019-05-08  Tom Tromey  <tom@tromey.com>
3462
3463         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3464         (get_ada_tasks_pspace_data): Update.
3465         (ada_tasks_pspace_data_cleanup): Remove.
3466         (_initialize_tasks): Update.
3467         (ada_tasks_inferior_data_handle): Change type.
3468         (get_ada_tasks_inferior_data): Update.
3469         (ada_tasks_inferior_data_cleanup): Remove.
3470         (struct ada_tasks_pspace_data): Add initializers.
3471
3472 2019-05-08  Tom Tromey  <tom@tromey.com>
3473
3474         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3475         * symfile-debug.c (debug_sym_get_probes): Change type.
3476         * stap-probe.c (handle_stap_probe):
3477         (stap_static_probe_ops::get_probes): Change type.
3478         * probe.h (class static_probe_ops) <get_probes>: Change type.
3479         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3480         (parse_probes_in_pspace): Update.
3481         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3482         Update.
3483         (any_static_probe_ops::get_probes): Change type.
3484         * elfread.c (elfread_data): New typedef.
3485         (probe_key): Change type.
3486         (elf_get_probes): Likewise.  Update.
3487         (probe_key_free): Remove.
3488         (_initialize_elfread): Update.
3489         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3490         Change type.
3491         (dtrace_process_dof_probe, dtrace_process_dof)
3492         (dtrace_static_probe_ops::get_probe): Change type.
3493
3494 2019-05-08  Tom Tromey  <tom@tromey.com>
3495
3496         * xcoffread.c (struct xcoff_symfile_info): Rename from
3497         coff_symfile_info.  Add initializers.
3498         (xcoff_objfile_data_key): Move lower.  Change type.
3499         (XCOFF_DATA): Rewrite.
3500         (xcoff_free_info): Remove.
3501         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3502         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3503         (xcoff_initial_scan): Update.
3504
3505 2019-05-08  Tom Tromey  <tom@tromey.com>
3506
3507         * solib-svr4.c (struct svr4_info): Add initializers and
3508         destructor.
3509         <probes_table>: Now an htab_up.
3510         (solib_svr4_pspace_data): Change type.
3511         (free_probes_table): Simplify.
3512         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3513         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3514         (probes_table_remove_objfile_probes, register_solib_event_probe)
3515         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3516         (_initialize_svr4_solib): Update.
3517
3518 2019-05-08  Tom Tromey  <tom@tromey.com>
3519
3520         * remote.c (remote_pspace_data): Change type.
3521         (remote_pspace_data_cleanup): Remove.
3522         (get_remote_exec_file, set_pspace_remote_exec_file)
3523         (_initialize_remote): Update.
3524
3525 2019-05-08  Tom Tromey  <tom@tromey.com>
3526
3527         * breakpoint.c (breakpoint_objfile_key): Change type.
3528         (get_breakpoint_objfile_data): Update.
3529         (free_breakpoint_objfile_data): Remove.
3530         (_initialize_breakpoint): Update.
3531
3532 2019-05-08  Tom Tromey  <tom@tromey.com>
3533
3534         * linux-tdep.c (struct linux_info): Add initializers.
3535         (linux_inferior_data): Move.  Change type.
3536         (invalidate_linux_cache_inf): Update.
3537         (linux_inferior_data_cleanup): Remove.
3538         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3539
3540 2019-05-08  Tom Tromey  <tom@tromey.com>
3541
3542         * auxv.c (auxv_inferior_data): Move.  Change type.
3543         (auxv_inferior_data_cleanup): Remove.
3544         (invalidate_auxv_cache_inf): Rewrite.
3545         (get_auxv_inferior_data, _initialize_auxv): Update.
3546
3547 2019-05-08  Tom Tromey  <tom@tromey.com>
3548
3549         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3550         (symfile_debug_objfile_data_key): Change type.
3551         (symfile_debug_installed, debug_qf_has_symbols)
3552         (debug_qf_find_last_source_symtab)
3553         (debug_qf_forget_cached_source_info)
3554         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3555         (debug_qf_print_stats, debug_qf_dump)
3556         (debug_qf_expand_symtabs_for_function)
3557         (debug_qf_expand_all_symtabs)
3558         (debug_qf_expand_symtabs_with_fullname)
3559         (debug_qf_map_matching_symbols)
3560         (debug_qf_expand_symtabs_matching)
3561         (debug_qf_find_pc_sect_compunit_symtab)
3562         (debug_qf_map_symbol_filenames)
3563         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3564         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3565         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3566         (debug_sym_read_linetable, debug_sym_relocate): Update.
3567         (symfile_debug_free_objfile): Remove.
3568         (install_symfile_debug_logging, _initialize_symfile_debug):
3569         Update.
3570
3571 2019-05-08  Tom Tromey  <tom@tromey.com>
3572
3573         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3574         allocate_on_obstack.
3575         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3576         (get_dwarf2_per_objfile): Update.
3577         (set_dwarf2_per_objfile): Remove.
3578         (dwarf2_has_info, dwarf2_get_section_info): Update.
3579         (dwarf2_free_objfile): Remove.
3580         (_initialize_dwarf2_read): Update.
3581
3582 2019-05-08  Tom Tromey  <tom@tromey.com>
3583
3584         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3585         initializers.
3586         <unsupported_script_warning_printed,
3587         script_not_found_warning_printed>: Now bool.
3588         (auto_load_pspace_data): Change type.
3589         (~auto_load_pspace_info): Rename from
3590         auto_load_pspace_data_cleanup.
3591         (get_auto_load_pspace_data, init_loaded_scripts_info)
3592         (clear_section_scripts, maybe_print_unsupported_script_warning)
3593         (maybe_print_script_not_found_warning, _initialize_auto_load):
3594         Update.
3595
3596 2019-05-08  Tom Tromey  <tom@tromey.com>
3597
3598         * objfiles.c (objfile_pspace_info): Add destructor and
3599         initializers.
3600         (objfiles_pspace_data): Change type.
3601         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3602         (get_objfile_pspace_data): Update.
3603         (objfiles_bfd_data): Change type.
3604         (get_objfile_bfd_data): Update.
3605         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3606
3607 2019-05-08  Tom Tromey  <tom@tromey.com>
3608
3609         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3610         Change type.
3611         (get_catch_syscall_inferior_data): Update.
3612         (catch_syscall_inferior_data_cleanup): Remove.
3613         (_initialize_break_catch_syscall): Update.
3614
3615 2019-05-08  Tom Tromey  <tom@tromey.com>
3616
3617         * inflow.c (struct terminal_info): Add destructor and
3618         initializers.
3619         (inflow_inferior_data): Change type.
3620         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3621         (get_inflow_inferior_data, inflow_inferior_exit)
3622         (swap_terminal_info, _initialize_inflow): Update.
3623
3624 2019-05-08  Tom Tromey  <tom@tromey.com>
3625
3626         * target-dcache.c (target_dcache_cleanup): Remove.
3627         (target_dcache_aspace_key): Change type.
3628         (target_dcache_init_p, target_dcache_invalidate)
3629         (target_dcache_get, target_dcache_get_or_init)
3630         (_initialize_target_dcache): Update.
3631         * dcache.h (struct dcache_deleter): New.
3632
3633 2019-05-08  Tom Tromey  <tom@tromey.com>
3634
3635         * symtab.c (struct symbol_cache): Add destructor and
3636         initializers.
3637         (symbol_cache_key): Move.  Change type.
3638         (make_symbol_cache, free_symbol_cache): Remove.
3639         (get_symbol_cache): Update.
3640         (symbol_cache_cleanup): Remove.
3641         (ALL_PSPACES, symbol_cache_flush)
3642         (maintenance_print_symbol_cache)
3643         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3644         Update.
3645
3646 2019-05-08  Tom Tromey  <tom@tromey.com>
3647
3648         * symtab.c (struct main_info): Add destructor and initializers.
3649         (main_progspace_key): Move.  Change type.
3650         (get_main_info): Update.
3651         (main_info_cleanup): Remove.
3652         (_initialize_symtab): Update.
3653
3654 2019-05-08  Tom Tromey  <tom@tromey.com>
3655
3656         * registry.h (DECLARE_REGISTRY): Define the _key class.
3657
3658 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3659
3660         * NEWS: Merge two 'New commands' sections.
3661
3662 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3663
3664         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3665         parameter and use Ada language definition instead.
3666         (ada_val_print_ptr): Remove unused language parameter.
3667         (ada_val_print_num): Remove language parameter and use Ada language
3668         definition instead.
3669         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3670         parameter.
3671         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3672         parameter and use Ada language definition instead.
3673         (ada_val_print_1): Update all ada_val_print_xxx calls.
3674         Remove language parameter.
3675         (ada_val_print): Update ada_val_print_1 call.
3676
3677 2019-05-08  Tom Tromey  <tromey@adacore.com>
3678
3679         * remote.c (remote_hw_watchpoint_limit)
3680         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3681         Now static.
3682
3683 2019-05-08  Tom Tromey  <tromey@adacore.com>
3684
3685         * maint.c (_initialize_maint_cmds): Move initialization code to
3686         remote.c.
3687         (watchdog, show_watchdog): Move to remote.c.
3688         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3689         "watchdog" static.
3690         (_initialize_remote): Move initialization code from maint.c.
3691         * defs.h (watchdog): Don't declare.
3692
3693 2019-05-08  Tom Tromey  <tromey@adacore.com>
3694
3695         * tui/tui-interp.c: Include main.h.
3696         * interps.c: Include main.h.
3697         * main.h (interpreter_p): Declare.
3698         * defs.h (interpreter_p): Don't declare.
3699
3700 2019-05-08  Tom Tromey  <tromey@adacore.com>
3701
3702         * dwarf2loc.c: Include dwarf2read.h.
3703         * defs.h (read_unsigned_leb128): Don't declare.
3704         * dwarf2read.h (read_unsigned_leb128): Declare.
3705
3706 2019-05-08  Tom Tromey  <tromey@adacore.com>
3707
3708         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3709         method.
3710
3711 2019-05-08  Tom Tromey  <tromey@adacore.com>
3712
3713         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3714         when no wrap column is set.
3715
3716 2019-05-08  Tom Tromey  <tromey@adacore.com>
3717
3718         * c-lang.c (c_get_string): Handle non-C-style arrays.
3719
3720 2019-05-08  Tom Tromey  <tromey@adacore.com>
3721
3722         * typeprint.c (print_offset_data::update): Print the bit offset,
3723         not the number of bits remaining.
3724
3725 2019-05-08  Tom Tromey  <tromey@adacore.com>
3726
3727         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3728         padding at end of comment.
3729
3730 2019-05-08  Tom Tromey  <tromey@adacore.com>
3731
3732         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3733         Compare main types.
3734
3735 2019-05-06  Tom Tromey  <tom@tromey.com>
3736
3737         * common/scoped_mmap.c: Include common-defs.h.
3738         * common/scoped_mmap.h: Don't include config.h.
3739
3740 2019-05-04  Tom Tromey  <tom@tromey.com>
3741
3742         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3743         (struct aarch64_call_info): Add initializers.
3744         <si>: Now a std::vector.
3745         (pass_on_stack, aarch64_push_dummy_call): Update.
3746
3747 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3748             Tom Tromey  <tom@tromey.com>
3749
3750         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3751         (ppc_threads): Now a std::vector.  Now static.
3752         (hwdebug_find_thread_points_by_tid)
3753         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3754         Update.
3755
3756 2019-05-04  Tom Tromey  <tom@tromey.com>
3757
3758         * arc-tdep.c (arc_tdesc_init): Return bool.
3759
3760 2019-05-04  Tom Tromey  <tom@tromey.com>
3761
3762         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3763         Use gdb_assert_not_reached.
3764
3765 2019-05-04  Tom Tromey  <tom@tromey.com>
3766
3767         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3768         "false".
3769
3770 2019-05-04  Tom Tromey  <tom@tromey.com>
3771
3772         * arc-tdep.c (arc_tdesc_init): Use bool.
3773
3774 2019-05-04  Tom Tromey  <tom@tromey.com>
3775
3776         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3777
3778 2019-05-04  Tom Tromey  <tom@tromey.com>
3779
3780         * cli/cli-cmds.c (valid_command_p): Return bool.
3781
3782 2019-05-04  Tom Tromey  <tom@tromey.com>
3783
3784         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3785         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3786
3787 2019-05-04  Raul Tambre  <raul@tambre.ee>
3788
3789         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3790         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3791         operator for comparison.
3792
3793 2019-05-04  Tom Tromey  <tom@tromey.com>
3794
3795         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3796         (lookup_partial_symbol, print_partial_symbols)
3797         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3798         (psymbol_compare): Update.
3799         (add_psymbol_to_bcache): Clear the entire psymbol.
3800         (maintenance_check_psymtabs): Update.
3801         * psympriv.h (struct partial_symbol): Don't derive from
3802         general_symbol_info.
3803         <obj_section, unrelocated_address, address,
3804         set_unrelocated_address>: Update.
3805         <ginfo>: New member.
3806         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3807         (debug_names::write_psymbols): Update.
3808
3809 2019-05-04  Tom de Vries  <tdevries@suse.de>
3810
3811         * contrib/cc-with-tweaks.sh: Support -n arg.
3812
3813 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3814
3815         * corelow.c (core_target::detach): Ensure frame cache and
3816         register caches are cleared.
3817         inferior.c (exit_inferior_1): Likewise.
3818
3819 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3820             Tom Tromey  <tom@tromey.com>
3821
3822         * dictionary.c (collate_pending_symbols_by_language): Remove
3823         "struct" from foreach.
3824         * symtab.c (lookup_global_symbol_from_objfile)
3825         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3826         foreach.
3827         * ser-tcp.c (net_open): Remove "struct" from foreach.
3828         * objfiles.c (objfile_relocate, objfile_rebase)
3829         (objfile_has_symbols): Remove "struct" from foreach.
3830         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3831         from foreach.
3832         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3833         foreach.
3834         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3835         "struct" from foreach.
3836         * ada-lang.c (create_excep_cond_exprs)
3837         (ada_exception_catchpoint_cond_string): Remove "struct" from
3838         foreach.
3839
3840 2019-05-03  Tom Tromey  <tromey@adacore.com>
3841
3842         * ada-exp.y (convert_char_literal): Check suffix of each
3843         enumerator.
3844
3845 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3846
3847         PR ada/21406:
3848         * ada-exp.y (yywrap): Don't define.
3849         * ada-lex.l (%option): Add noyywrap
3850         (yywrap): Remove.
3851
3852 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3853
3854         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3855         _WIN32_WINNT to the XP level, unless already defined to a higher
3856         level.
3857
3858         * unittests/parse-connection-spec-selftests.c:
3859         * ser-tcp.c:
3860         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3861         override.
3862
3863         * symfile.c (find_separate_debug_file): Remove colon from the
3864         drive spec of DOS/Windows file names of the target, so that the
3865         file name produced from DEBUGDIR and the target's directory will
3866         be valid on DOS/Windows systems.
3867
3868 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3869
3870         * rust-lang.c (val_print_struct): Handle printing structures
3871         containing strings.
3872
3873 2019-05-02  Tom Tromey  <tromey@adacore.com>
3874
3875         * valarith.c (_initialize_valarith): Remove.
3876
3877 2019-05-01  Tom Tromey  <tromey@adacore.com>
3878
3879         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3880         bitfields.
3881
3882 2019-05-01  Tom Tromey  <tromey@adacore.com>
3883
3884         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3885         for big-endian copies.
3886
3887 2019-04-30  Ali Tamur  <tamur@google.com>
3888         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3889         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3890         (read_3_bytes): New function.
3891
3892 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3893
3894         * windows-nat.c (main_thread_id): Delete.
3895         (handle_output_debug_string): Replace main_thread_id by
3896         current_event.dwThreadId.
3897         (fake_create_process): Likewise.
3898         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3899         Do not set main_thread_id.
3900         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3901         current_event.dwThreadId.
3902         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3903
3904 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3905
3906         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3907         Use current_event.dwThreadId instead of main_thread_id.
3908
3909 2019-04-30  Tom Tromey  <tromey@adacore.com>
3910
3911         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3912         (create_excep_cond_exprs): Iterate over program spaces.
3913         (ada_exception_catchpoint_cond_string): Examine all minimal
3914         symbols for exception types.
3915
3916 2019-04-30  Tom Tromey  <tromey@adacore.com>
3917
3918         PR c++/24470:
3919         * dwarf2read.c (process_structure_scope): Handle case where type
3920         has template parameters but no symbol was created.
3921
3922 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3923             Chris January  <chris.january@arm.com>
3924
3925         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3926         qualifier.
3927         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3928
3929 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3930
3931         * f-typeprint.c (f_print_type): Update rules for printing
3932         whitespace.
3933         (f_type_print_varspec_suffix): Likewise.
3934
3935 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3936             Chris January  <chris.january@arm.com>
3937
3938         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3939         function arguments.
3940
3941 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3942
3943         * f-lang.c (build_fortran_types): Change name of void type to
3944         lower case.
3945         * f-typeprint.c (f_type_print_base): Print the name of the void
3946         type, rather than a fixed string.
3947         * f-valprint.c (f_decorations): Use lower case void string.
3948
3949 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3950             Chris January  <chris.january@arm.com>
3951
3952         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3953         types for Fortran.
3954
3955 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3956             Chris January  <chris.january@arm.com>
3957             David Lecomber  <david.lecomber@arm.com>
3958
3959         * f-exp.y (BINOP_INTRINSIC): New token.
3960         (exp): New parser rule handling BINOP_INTRINSIC.
3961         (f77_keywords): Add new builtin procedures.
3962         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3963         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3964         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3965         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3966         (print_unop_subexp_f): New function.
3967         (print_binop_subexp_f): New function.
3968         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3969         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3970         (dump_subexp_body_f): Likewise.
3971         (operator_check_f): Likewise.
3972         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3973         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3974
3975 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3976
3977         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3978         UNOP_KIND.
3979         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3980         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3981         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3982         (operator_length_f): New fuction.
3983         (print_subexp_f): New function.
3984         (op_name_f): New function.
3985         (dump_subexp_body_f): New function.
3986         (operator_check_f): New function.
3987         (exp_descriptor_f): Replace standard expression handling functions
3988         with new functions.
3989         * gdb/fortran-operator.def: New file.
3990         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3991         * gdb/std-operator.def: Remove UNOP_KIND.
3992
3993 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3994
3995         * std-operator.def: Remove unbalanced, stray double quote
3996         character.
3997
3998 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3999             Chris January  <chris.january@arm.com>
4000             Daniel Everett  <daniel.everett@arm.com>
4001             Nick Forrington  <nick.forrington@arm.com>
4002             Richard Bunt  <richard.bunt@arm.com>
4003
4004         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4005         of depth when printing anonymous structs or unions.
4006         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4007         Don't print either the top-level value, or the children if the
4008         max-depth is exceeded.
4009         (ppscm_print_children): When printing the key of a map, allow one
4010         extra level of depth.
4011         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4012         print either the top-level value, or the children if the max-depth
4013         is exceeded.
4014         (print_children): When printing the key of a map, allow one extra
4015         level of depth.
4016         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4017         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4018         (user_print_options): Initialise max_depth field.
4019         (val_print_scalar_or_string_type_p): New function.
4020         (val_print): Check to see if the max depth has been reached.
4021         (val_print_check_max_depth): Define new function.
4022         (show_print_max_depth): New function.
4023         (_initialize_valprint): Add 'print max-depth' option.
4024         * valprint.h (struct value_print_options) <max_depth>: New field.
4025         (val_print_check_max_depth): Declare new function.
4026         * NEWS: Document new feature.
4027
4028 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4029
4030         * ada-lang.c (ada_language_defn): Initialise new field.
4031         * c-lang.c (c_is_string_type_p): New function.
4032         (c_language_defn): Initialise new field.
4033         (cplus_language_defn): Initialise new field.
4034         (asm_language_defn): Initialise new field.
4035         (minimal_language_defn): Initialise new field.
4036         * c-lang.h (c_is_string_type_p): Declare new function.
4037         * d-lang.c (d_language_defn): Initialise new field.
4038         * f-lang.c (f_is_string_type_p): New function.
4039         (f_language_defn): Initialise new field.
4040         * go-lang.c (go_is_string_type_p): New function.
4041         (go_language_defn): Initialise new field.
4042         * language.c (default_is_string_type_p): New function.
4043         (unknown_language_defn): Initialise new field.
4044         (auto_language_defn): Initialise new field.
4045         * language.h (struct language_defn) <la_is_string_type_p>: New
4046         member variable.
4047         (default_is_string_type_p): Declare new function.
4048         * m2-lang.c (m2_language_defn): Initialise new field.
4049         * objc-lang.c (objc_language_defn): Initialise new field.
4050         * opencl-lang.c (opencl_language_defn): Initialise new field.
4051         * p-lang.c (pascal_is_string_type_p): New function.
4052         (pascal_language_defn): Initialise new field.
4053         * rust-lang.c (rust_is_string_type_p): New function.
4054         (rust_language_defn): Initialise new field.
4055
4056 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4057
4058         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4059         New field.
4060         * ada-lang.c (ada_language_defn): Initialise new field.
4061         * c-lang.c (c_language_defn): Likewise.
4062         (cplus_language_defn): Likewise.
4063         (asm_language_defn): Likewise.
4064         (minimal_language_defn): Likewise.
4065         * d-lang.c (d_language_defn): Likewise.
4066         * f-lang.c (f_language_defn): Likewise.
4067         * go-lang.c (go_language_defn): Likewise.
4068         * language.c (unknown_language_defn): Likewise.
4069         (auto_language_defn): Likewise.
4070         * m2-lang.c (m2_language_defn): Likewise.
4071         * objc-lang.c (objc_language_defn): Likewise.
4072         * opencl-lang.c (opencl_language_defn): Likewise.
4073         * p-lang.c (pascal_language_defn): Likewise.
4074         * rust-lang.c (rust_language_defn): Likewise.
4075
4076 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4077
4078         * ada-lang.c (ada_is_character_type): Change return type to bool.
4079         (ada_is_string_type): Likewise.
4080         * ada-lang.h (ada_is_character_type): Update declaration
4081         (ada_is_string_type): Likewise.
4082
4083 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4084
4085         Support style in 'frame|thread apply'
4086
4087         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4088         * record.c (record_start, record_stop): Update callers of
4089         execute_command_to_string with false.
4090         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4091         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4092         methods.
4093         (class string_file): New constructor with term_out parameter.
4094         Override methods term_out and can_emit_style_escape.  New member
4095         term_out.
4096         (class stdio_file): Override can_emit_style_escape.
4097         (class tee_file): Override term_out and can_emit_style_escape.
4098         * utils.h (can_emit_style_escape): Remove.
4099         * utils.c (can_emit_style_escape): Likewise.
4100         Update all callers of can_emit_style_escape (SOMESTREAM) to
4101         SOMESTREAM->can_emit_style_escape.
4102         * source-cache.c (source_cache::get_source_lines): Likewise.
4103         * stack.c (frame_apply_command_count): Call execute_command_to_string
4104         passing the term_out characteristic of the current gdb_stdout.
4105         * thread.c (thr_try_catch_cmd): Likewise.
4106         * top.c (execute_command_to_string): pass term_out parameter
4107         to construct the string_file for the command output.
4108         * ui-file.c (term_cli_styling): New function (most code moved
4109         from utils.c can_emit_style_escape).
4110         (string_file::string_file, string_file::can_emit_style_escape,
4111         stdio_file::can_emit_style_escape, tee_file::term_out,
4112         tee_file::can_emit_style_escape): New functions.
4113
4114 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4115
4116         * NEWS: Mention the new set|show may-call-functions.
4117         * infcall.c (may_call_functions_p): New variable.
4118         (show_may_call_functions_p): New function.
4119         (call_function_by_hand_dummy): Throws an error if not
4120         may-call-functions.
4121         (_initialize_infcall): Call add_setshow_boolean_cmd for
4122         may-call-functions.
4123
4124 2019-04-25  Keith Seitz  <keiths@redhat.com>
4125
4126         PR c++/24367
4127         * cp-support.c (inspect_type): Don't attempt substitutions
4128         of symbol with the same name.
4129
4130 2019-04-25  Tom Tromey  <tromey@adacore.com>
4131
4132         PR gdb/24475:
4133         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4134         static.
4135
4136 2019-04-25  Tom Tromey  <tromey@adacore.com>
4137
4138         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4139         rvalue reference.
4140         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4141         (gdb_xml_parser::parse): Use std::move.
4142         * python/python-internal.h (gdbpy_convert_exception): Take a const
4143         reference.
4144         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4145         std::move.
4146         * python/py-utils.c (gdbpy_convert_exception): Take a const
4147         reference.
4148         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4149         Use std::move.
4150         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4151         Use std::move.
4152         * mi/mi-main.c (mi_print_exception): Take a const reference.
4153         * main.c (handle_command_errors): Take a const reference.
4154         * linespec.c (parse_linespec): Use std::move.
4155         * infcall.c (run_inferior_call): Use std::move.
4156         (call_function_by_hand_dummy): Use std::move.
4157         * exec.c (try_open_exec_file): Use std::move.
4158         * exceptions.h (exception_print, exception_fprintf)
4159         (exception_print_same): Update.
4160         * exceptions.c (print_exception, exception_print)
4161         (exception_fprintf, exception_print_same): Change parameters to
4162         const reference.
4163         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4164         * common/new-op.c: Use std::move.
4165         * common/common-exceptions.h (struct gdb_exception): Add move
4166         constructor.
4167         (struct gdb_exception_error, struct gdb_exception_quit, struct
4168         gdb_quit_bad_alloc): Change constructor to move constructor.
4169         (throw_exception): Change parameter to rvalue reference.
4170         * common/common-exceptions.c (throw_exception): Take rvalue
4171         reference.
4172         * cli/cli-interp.c (safe_execute_command): Use std::move.
4173         * breakpoint.c (insert_bp_location, location_to_sals): Use
4174         std::move.
4175
4176 2019-04-25  Tom Tromey  <tromey@adacore.com>
4177
4178         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4179         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4180         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4181         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4182         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4183         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4184         guile/scm-value.c: Use unpack.
4185         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4186         gdbscm_gdb_exception.
4187         (gdbscm_throw_gdb_exception): Likewise.
4188         (struct gdbscm_gdb_exception): New.
4189         (unpack): New function.
4190         (gdbscm_wrap): Use unpack.
4191
4192 2019-04-25  Tom Tromey  <tromey@adacore.com>
4193
4194         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4195         (gdb_rl_callback_handler): Use std::move.
4196         * common/common-exceptions.h (struct gdb_exception): Add move
4197         assignment operator.
4198         (throw_exception_sjlj): Change "exception" to const reference.
4199         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4200         (throw_exception_sjlj): Change "exception" to const reference.
4201
4202 2019-04-25  Tom Tromey  <tromey@adacore.com>
4203
4204         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4205         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4206         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4207         Update.
4208         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4209         Update.
4210         * mi/mi-interp.c (mi_interp::exec): Update.
4211         * linespec.c (parse_linespec): Update.
4212         * infcall.c (run_inferior_call): Update.
4213         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4214         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4215         (gdbscm_lookup_global_symbol): Update.
4216         * guile/scm-param.c (gdbscm_parameter_value): Update.
4217         * guile/scm-frame.c (gdbscm_frame_read_register)
4218         (gdbscm_frame_read_var): Update.
4219         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4220         * exec.c (try_open_exec_file): Update.
4221         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4222         (gdb_rl_callback_handler): Update.
4223         * common/common-exceptions.h (exception_none): Don't declare.
4224         * common/common-exceptions.c (exception_none): Don't define.
4225         (struct catcher) <exception>: Update.
4226         * cli/cli-interp.c (safe_execute_command): Update.
4227         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4228
4229 2019-04-25  Ali Tamur  <tamur@google.com>
4230
4231         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4232         (read_attribute_value): Likewise.
4233         (dwarf2_read_addr_index): Update comment.
4234         (read_str_index): Add DW_FORM_strx.
4235         (dwarf2_string_attr): Likewise.
4236         (dwarf2_const_value_attr): Likewise.
4237         (dump_die_shallow): Likewise.
4238         (dwarf2_fetch_constant_bytes): Likewise.
4239         (skip_form_bytes): Likewise.
4240         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4241
4242 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4243
4244         PR corefiles/11608
4245         PR corefiles/18187
4246         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4247         OFFSET.  Verify if current mapping contains an ELF header.
4248         (linux_find_memory_regions_full): Adjust call to
4249         dump_mapping_p.
4250
4251 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4252             Kang Li <kanglictf@gmail.com>
4253
4254         PR gdb/21600
4255
4256         * dwarf2-frame.c (read_initial_length): Be consistent about using
4257         unsigned representation of length.
4258         (decode_frame_entry_1): Likewise.  Check for wraparound of
4259         end pointer as well as buffer overflow.
4260
4261 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4262
4263         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4264         "vq".
4265
4266 2019-04-24  Tom Tromey  <tromey@adacore.com>
4267
4268         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4269
4270 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4271
4272         * s12z-tdep.c (s12z_unwind_pc): Delete.
4273         (s12z_unwind_sp): Delete.
4274         (s12z_gdbarch_init): Don't register deleted functions with
4275         gdbarch.
4276
4277 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4278
4279         * rl78-tdep.c (rl78_unwind_sp): Delete.
4280         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4281
4282 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4283
4284         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4285         (xstormy16_unwind_pc): Delete.
4286         (xstormy16_dummy_id): Delete.
4287         (xstormy16_gdbarch_init): Don't register deleted functions with
4288         gdbarch.
4289
4290 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4291
4292         * vax-tdep.c (vax_unwind_pc): Delete.
4293         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4294
4295 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4296
4297         * v850-tdep.c (v850_unwind_sp): Delete.
4298         (v850_unwind_pc): Delete.
4299         (v850_dummy_id): Delete.
4300         (v850_gdbarch_init): Don't register deleted functions with
4301         gdbarch.
4302
4303 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4304
4305         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4306         (tilegx_unwind_pc): Delete.
4307         (tilegx_unwind_dummy_id): Delete.
4308         (tilegx_gdbarch_init): Don't register deleted functions with
4309         gdbarch.
4310
4311 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4312
4313         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4314         (tic6x_dummy_id): Delete.
4315         (tic6x_gdbarch_init): Don't register deleted functions with
4316         gdbarch.
4317
4318 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4319
4320         * sparc-tdep.c (sparc_unwind_pc): Delete.
4321         (sparc32_gdbarch_init): Don't register deleted function with
4322         gdbarch.
4323
4324 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4325
4326         * sh-tdep.c (sh_unwind_sp): Delete.
4327         (sh_unwind_pc): Delete.
4328         (sh_dummy_id): Delete.
4329         (sh_gdbarch_init): Don't register deleted functions with
4330         gdbarch.
4331
4332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4333
4334         * score-tdep.c (score_unwind_sp): Delete.
4335         (score_unwind_pc): Delete.
4336         (score_dummy_id): Delete.
4337         (score_gdbarch_init): Don't register deleted functions with
4338         gdbarch.
4339
4340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4341
4342         * rx-tdep.c (rx_unwind_pc): Delete.
4343         (rx_unwind_sp): Delete.
4344         (rx_dummy_id): Delete.
4345         (rx_gdbarch_init): Don't register deleted functions with
4346         gdbarch.  Update comment.
4347
4348 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4349
4350         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4351         (rs6000_dummy_id): Delete.
4352         (rs6000_gdbarch_init): Don't register deleted functions with
4353         gdbarch.
4354
4355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4356
4357         * or1k-tdep.c (or1k_dummy_id): Delete.
4358         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4359
4360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4361
4362         * nios2-tdep.c (nios2_dummy_id): Delete.
4363         (nios2_unwind_sp): Delete.
4364         (nios2_gdbarch_init): Don't register deleted functions with
4365         gdbarch.
4366
4367 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4368
4369         * nds32-tdep.c (nds32_dummy_id): Delete.
4370         (nds32_unwind_pc): Delete.
4371         (nds32_unwind_sp): Delete.
4372         (nds32_gdbarch_init): Don't register deleted functions with
4373         gdbarch.
4374
4375 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4376
4377         * msp430-tdep.c (msp430_unwind_pc): Delete.
4378         (msp430_unwind_sp): Delete.
4379         (msp430_dummy_id): Delete.
4380         (msp430_gdbarch_init): Don't register deleted functions with
4381         gdbarch.
4382
4383 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4384
4385         * moxie-tdep.c (moxie_unwind_sp): Delete.
4386         (moxie_unwind_pc): Delete.
4387         (moxie_dummy_id): Delete.
4388         (moxie_gdbarch_init): Don't register deleted functions with
4389         gdbarch.
4390
4391 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4392
4393         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4394         (mn10300_unwind_pc): Delete.
4395         (mn10300_unwind_sp): Delete.
4396         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4397         mn10300_unwind_sp.
4398         (mn10300_frame_unwind_init): Don't register deleted functions with
4399         gdbarch.
4400
4401 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4402
4403         * mep-tdep.c (mep_unwind_pc): Delete.
4404         (mep_unwind_sp): Delete.
4405         (mep_dummy_id): Delete.
4406         (mep_gdbarch_init): Don't register deleted functions with
4407         gdbarch.
4408
4409 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4410
4411         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4412         (m68hc11_unwind_sp): Delete.
4413         (m68hc11_gdbarch_init): Don't register deleted functions with
4414         gdbarch.
4415
4416 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4417
4418         * m32r-tdep.c (m32r_unwind_sp): Delete.
4419         (m32r_unwind_pc): Delete.
4420         (m32r_dummy_id): Delete.
4421         (m32r_gdbarch_init): Don't register deleted functions with
4422         gdbarch.
4423
4424 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4425
4426         * m32c-tdep.c (m32c_unwind_pc): Delete.
4427         (m32c_unwind_sp): Delete.
4428         (m32c_dummy_id): Delete.
4429         (m32c_gdbarch_init): Don't register deleted functions with
4430         gdbarch.
4431
4432 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4433
4434         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4435         (lm32_unwind_pc): Delete.
4436         (lm32_dummy_id): Delete.
4437         (lm32_gdbarch_init): Don't register deleted functions with
4438         gdbarch.
4439
4440 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4441
4442         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4443         (iq2000_unwind_pc): Delete.
4444         (iq2000_dummy_id): Delete.
4445         (iq2000_gdbarch_init): Don't register deleted functions with
4446         gdbarch.
4447
4448 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4449
4450         * nds32-tdep.c (nds32_type_align): Delete.
4451         (nds32_push_dummy_call): Use type_align instead.
4452
4453 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4454
4455         * arm-tdep.c (arm_type_align): Only handle vector override case.
4456         (arm_push_dummy_call): Use type_align.
4457         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4458
4459 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4460
4461         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4462         case.
4463         (pass_on_stack): Use type_align.
4464         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4465         function.
4466
4467 2019-04-23  Tom Tromey  <tromey@adacore.com>
4468
4469         * dwarf2read.c (line_header::file_name_at): Remove unused
4470         overload.
4471
4472 2019-04-23  Tom de Vries  <tdevries@suse.de>
4473
4474         PR gdb/24438
4475         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4476         invocation.
4477
4478
4479 2019-03-27  Ali Tamur  <tamur@google.com>
4480
4481         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4482         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4483         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4484         (dwarf_expr_context::get_addr_index): Likewise
4485         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4486         (symbol_needs_eval_context::get_addr_index): Likewise
4487         (disassemble_dwarf_expression): Add DW_OP_addrx
4488         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4489         (read_cutu_die_from_dwo): Update comment
4490         (skip_one_die): Add DW_FORM_addrx
4491         (read_attribute_value): Likewise
4492         (var_decode_location): Add DW_OP_addrx
4493         (dwarf2_const_value_attr): Add DW_FORM_addrx
4494         (dump_die_shallow): Likewise
4495         (dwarf2_fetch_constant_bytes): Likewise
4496         (decode_locdesc): Add DW_OP_addrx
4497         (skip_form_bytes): Add DW_FORM_addrx
4498
4499 2019-04-22  Ali Tamur  <tamur@google.com>
4500
4501         * MAINTAINERS (Write After Approval): Add self.
4502
4503 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4504
4505         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4506         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4507         (open_symbol_file_object): Likewise.
4508         (svr4_default_sos): Add info parameter.
4509         (svr4_read_so_list): Likewise.
4510         (svr4_current_sos_direct): Adjust functions calls to pass down
4511         info.
4512         (svr4_current_sos_1): Add info parameter.
4513         (svr4_current_sos): Call get_svr4_info, pass info down to
4514         svr4_current_sos_1.
4515         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4516         get_svr4_info.
4517         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4518         get_svr4_info.
4519         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4520         to get_svr4_info.
4521         (probes_table_remove_objfile_probes): Likewise.
4522         (register_solib_event_probe): Add info parameter.
4523         (solist_update_incremental): Pass info parameter down to
4524         svr4_read_so_list.
4525         (disable_probes_interface): Add info parameter.
4526         (svr4_handle_solib_event): Pass current_program_space to
4527         get_svr4_info.  Adjust disable_probes_interface cleanup.
4528         (svr4_create_probe_breakpoints): Add info parameter, pass it
4529         down to register_solib_event_probe.
4530         (svr4_create_solib_event_breakpoints): Add info parameter,
4531         pass it down to svr4_create_probe_breakpoints.
4532         (enable_break): Pass info down to
4533         svr4_create_solib_event_breakpoints.
4534         (svr4_solib_create_inferior_hook): Pass current_program_space to
4535         get_svr4_info.
4536         (svr4_clear_solib): Likewise.
4537
4538 2019-04-22  Pedro Alves  <palves@redhat.com>
4539
4540         * solib-svr4.c (svr4_free_objfile_observer): New.
4541         (probe_and_action::objfile): New field.
4542         (probes_table_htab_remove_objfile_probes)
4543         (probes_table_remove_objfile_probes): New functions.
4544         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4545         in the new probe_and_action.  Don't store the probe in 'lookup'.
4546         (svr4_create_probe_breakpoints): Pass objfile to
4547         register_solib_event_probe.
4548         (_initialize_svr4_solib): Register a free_objfile observer.
4549
4550 2019-04-19  Tom Tromey  <tom@tromey.com>
4551
4552         * common/queue.h: Remove.
4553
4554 2019-04-19  Tom Tromey  <tom@tromey.com>
4555
4556         * event-loop.c: Don't include "common/queue.h".
4557
4558 2019-04-19  Tom Tromey  <tom@tromey.com>
4559
4560         * remote.c (remote_target): Use delete.
4561         * remote-notif.h: Include <list>, not "common/queue.h".
4562         (notif_client_p): Remove typedef.
4563         (remote_notif_state): Add constructor, destructor, initializer.
4564         <notif_queue>: Now a std::list.
4565         (remote_notif_state_xfree): Don't declare.
4566         * remote-notif.c (remote_notif_process, handle_notification)
4567         (remote_notif_state_allocate): Update.
4568         (~remote_notif_state): Rename from remote_notif_state_xfree.
4569
4570 2019-04-19  Tom Tromey  <tom@tromey.com>
4571
4572         * symfile.c (reread_symbols): Update.
4573         * objfiles.c (objfile_register_static_link)
4574         (objfile_lookup_static_link): Update
4575         (~objfile) Don't delete static_links.
4576         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4577
4578 2019-04-19  Tom Tromey  <tom@tromey.com>
4579
4580         * type-stack.h (struct type_stack) <insert>: Constify string.
4581         * type-stack.c (type_stack::insert): Constify string.
4582         * gdbtypes.h (lookup_template_type): Update.
4583         (address_space_name_to_int): Update.
4584         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4585         const.
4586         (lookup_template_type): Make name const.
4587         * c-exp.y: Update rules.
4588         (lex_one_token, classify_name, classify_inner_name)
4589         (c_print_token): Update.
4590         * p-exp.y: Update rules.
4591         (yylex): Update.
4592         * f-exp.y: Update rules.
4593         (yylex): Update.
4594         * d-exp.y: Update rules.
4595         (lex_one_token, classify_name, classify_inner_name): Update.
4596         * parse.c (write_dollar_variable, copy_name): Return std::string.
4597         * parser-defs.h (copy_name): Change return type.
4598         * m2-exp.y: Update rules.
4599         (yylex): Update.
4600         * go-exp.y (lex_one_token): Update.
4601         Update rules.
4602         (classify_unsafe_function, classify_packaged_name)
4603         (classify_name, yylex): Update.
4604
4605 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4606
4607         * configure.ac: add --enable-source-highlight switch.
4608         * configure: Regenerate.
4609         * top.c (print_gdb_version): plumb --enable-source-highlight
4610         status to "show configuration".
4611
4612 2019-04-19  Tom Tromey  <tromey@adacore.com>
4613
4614         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4615         Check ADA_TYPE_P.
4616         (empty_record, ada_template_to_fixed_record_type_1)
4617         (template_to_static_fixed_type)
4618         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4619         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4620         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4621         macros.
4622
4623 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4624
4625         PR symtab/24423:
4626         * source.c (print_source_lines_base): Advance "iter" when a
4627         control character is seen.
4628
4629 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4630
4631         * inferior.h (struct infcall_suspend_state_deleter):
4632         Catch exception in destructor to avoid crash.
4633
4634 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4635
4636         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4637         close to the add_com "shell".
4638
4639 2019-04-18  Tom Tromey  <tromey@adacore.com>
4640
4641         * process-stratum-target.h (class process_stratum_target)
4642         <stratum>: Add "final".
4643
4644 2019-04-17  Tom Tromey  <tromey@adacore.com>
4645
4646         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4647         against nullptr before use.
4648
4649 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4650
4651         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4652
4653 2019-04-17  Jim Wilson  <jimw@sifive.com>
4654             Andrew Burgess  <andrew.burgess@embecosm.com>
4655
4656         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4657         code read might fail, assume 4-byte breakpoint in that case.
4658
4659 2019-04-15  Leszek Swirski  <leszeks@google.com>
4660
4661         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4662         rather than a hand-rolled POD check when checking for forced MEMORY
4663         classification.
4664
4665 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4666
4667         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4668         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4669         function.
4670         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4671         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4672         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4673         declaration.
4674
4675 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4676
4677         * aarch64-linux-nat.c
4678         (aarch64_linux_nat_target::thread_architecture): Add override.
4679         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4680         each VQ.
4681
4682 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4683
4684         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4685
4686 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4687
4688         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4689         target types of size 96-bits, add some additional comments, and
4690         check that the builtin type we found was the correct size.
4691
4692 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4693
4694         * utils.c (prompt_for_continue): Don't restore the styling at the
4695         end, as applied_style has the wrong value.  This fixes styling in
4696         long lists of file names that are interrupted by the "Continue?"
4697         prompt.
4698
4699 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4700
4701         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4702         * c-lang.c (c_language_defn): Likewise.
4703         (cplus_language_defn): Likewise.
4704         (asm_language_defn): Likewise.
4705         (minimal_language_defn): Likewise.
4706         * d-lang.c (d_language_defn): Likewise.
4707         * f-lang.c (f_language_defn): Likewise.
4708         * go-lang.c (go_language_defn): Likewise.
4709         * language.c (unknown_language_defn): Likewise.
4710         (auto_language_defn): Likewise.
4711         * language.h (struct language_defn): Remove la_magic field.
4712         (LANG_MAGIC): Delete.
4713         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4714         * objc-lang.c (objc_language_defn): Likewise.
4715         * opencl-lang.c (opencl_language_defn): Likewise.
4716         * p-lang.c (pascal_language_defn): Likewise.
4717         * rust-lang.c (rust_language_defn): Likewise.
4718
4719 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4720
4721         * riscv-tdep.c (riscv_type_align): New function.
4722         (riscv_type_alignment): Delete.
4723         (riscv_arg_location): Use 'type_align'.
4724         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4725
4726 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4727
4728         * gdbtypes.c (type_align): A struct with no non-static fields also
4729         has alignment of 1.
4730
4731 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4732
4733         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4734         component to 0.
4735         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4736         member.
4737         (riscv_struct_info::analyse): New implementation using new
4738         analyse_inner member function.
4739         (riscv_struct_info::field_offset): New member function.
4740         (riscv_struct_info::m_offsets): New member variable.
4741         (riscv_struct_info::analyse_inner): New private member function,
4742         takes the old implementation of riscv_struct_info::analyse but
4743         extended to track field offsets.
4744         (riscv_call_arg_struct): Update the struct folding special cases
4745         to handle cases where empty C++ structs, which are non-zero
4746         length, are found.
4747         (riscv_arg_location): Initialise the length of each location, a
4748         non-zero length now indicates the location is in use.
4749         (riscv_push_dummy_call): Allow for the first location having a
4750         non-zero offset when setting up arguments.
4751         (riscv_return_value): Likewise, but for return values.
4752
4753 2019-04-11  Tom Tromey  <tromey@adacore.com>
4754
4755         * utils.c (internal_vproblem): Make "msg" const.
4756
4757 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4758
4759         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4760         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4761         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4762         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4763
4764 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4765
4766         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4767         function.
4768         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4769         of amd64_collect_native_gregset.
4770         (amd64_linux_nat_target::store_registers): Likewise.
4771
4772 2019-04-10  Tom Tromey  <tom@tromey.com>
4773
4774         * symtab.c (lookup_global_symbol_from_objfile)
4775         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4776         * objfiles.h (class separate_debug_iterator): New.
4777         (class separate_debug_range): New.
4778         (struct objfile) <separate_debug_objfiles>: New method.
4779         (objfile_separate_debug_iterate): Don't declare.
4780         * objfiles.c (separate_debug_iterator::operator++): Rename from
4781         objfile_separate_debug_iterate.
4782         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4783         iterator.
4784         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4785         iterator.
4786
4787 2019-04-10  Tom Tromey  <tom@tromey.com>
4788
4789         * symfile.c (reread_symbols): Remove old comment.
4790         * objfiles.c (free_all_objfiles): Fix a typo.
4791
4792 2019-04-10  Tom Tromey  <tom@tromey.com>
4793
4794         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4795         * minsyms.c (lookup_minimal_symbol): Use foreach.
4796         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4797         (lookup_minimal_symbol_solib_trampoline): Likewise.
4798         * symfile.c (reread_symbols): Use foreach.
4799
4800 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4801             Tom Tromey  <tromey@adacore.com>
4802
4803         PR rust/24414:
4804         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4805         (rust_lex_int_test): Change "value" to be LONGEST.
4806         (rust_lex_tests): Add test for long integer literal.
4807
4808 2019-04-09  Tom Tromey  <tromey@adacore.com>
4809
4810         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4811         to bool.
4812         (extended_remote_target::attach): Update.
4813         (remote_target::remote_notice_new_inferior): Update.
4814         (remote_target::add_current_inferior_and_thread): Update.
4815         * inferior.c (exit_inferior_1): Use "false".
4816         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4817
4818 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4819
4820         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4821         the "start" command.
4822
4823 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4824
4825         * python/py-inferior.c (infpy_thread_from_thread_handle):
4826         Adjust comments to reflect renaming of thread_from_thread_handle
4827         to thread_from_handle.  Adjust keywords.  Fix type error message.
4828         (inferior_object_methods): Add thread_from_handle.  Retain
4829         thread_from_thread_handle, but mark it as deprecated.
4830
4831 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4832
4833         * gdbthread.h (find_thread_by_handle): Revise declaration.
4834         * thread.c (find_thread_by_handle): Likewise.  Adjust
4835         implementation too.
4836         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4837         support for buffer objects as handles.
4838
4839 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4840
4841         * python/py-infthread.c (thpy_thread_handle): New function.
4842         (thread_object_methods): Register thpy_thread_handle.
4843
4844 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4845
4846         * gdbthread.h (thread_to_thread_handle): Declare.
4847         * thread.c (gdbtypes.h): Include.
4848         (thread_to_thread_handle): New function.
4849
4850         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4851         (target_thread_info_to_thread_handle): Declare.
4852         * target.c (target_thread_info_to_thread_handle): New function.
4853         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4854         * target-delegates.c: Regenerate.
4855
4856         * linux-thread-db.c (class thread_db_target): Add method
4857         thread_info_to_thread_handle.
4858         (thread_db_target::thread_info_to_thread_handle): Define.
4859         * remote.c (class remote_target): Add new method
4860         thread_info_to_thread_handle.
4861         (remote_target::thread_info_to_thread_handle): Define.
4862
4863 2019-04-08  Pedro Alves  <palves@redhat.com>
4864
4865         * common/common-exceptions.c (throw_exception): Don't create
4866         named object to throw; throw directly.
4867         (throw_it): Likewise.  Don't initialize gdb_exception::message
4868         here, with new; pass FMT and AP to the ctor instead.
4869         * common/common-exceptions.h: Include <string>.
4870         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4871         const char *, va_list)): New ctor.  Use std::make_shared.
4872         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4873         errors)): Delete.
4874         (gdb_exception_error::gdb_exception_error(enum errors, const char
4875         *, va_list)): New.
4876         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4877         Add assertion.
4878         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4879         errors)): Delete.
4880         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4881         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4882         Add assertion.
4883
4884 2019-04-08  Tom Tromey  <tom@tromey.com>
4885
4886         * valops.c (value_rtti_indirect_type): Replace throw_exception
4887         with throw.
4888         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4889         with throw.
4890         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4891         throw.
4892         * target.c (target_translate_tls_address): Replace throw_exception
4893         with throw.
4894         * stack.c (frame_apply_command_count): Replace throw_exception
4895         with throw.
4896         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4897         throw.
4898         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4899         with throw.
4900         * rs6000-tdep.c (rs6000_frame_cache)
4901         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4902         * remote.c: Replace throw_exception with throw.
4903         * record-full.c (record_full_message, record_full_wait_1)
4904         (record_full_restore): Replace throw_exception with throw.
4905         * record-btrace.c:
4906         (get_thread_current_frame_id, record_btrace_start_replaying)
4907         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4908         (cmd_record_btrace_start): Replace throw_exception with throw.
4909         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4910         throw.
4911         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4912         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4913         * linespec.c:
4914         (find_linespec_symbols): Replace throw_exception with throw.
4915         * infrun.c (displaced_step_prepare, resume): Replace
4916         throw_exception with throw.
4917         * infcmd.c (post_create_inferior): Replace throw_exception with
4918         throw.
4919         * inf-loop.c (inferior_event_handler): Replace throw_exception
4920         with throw.
4921         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4922         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4923         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4924         (get_prev_frame_always, get_frame_pc_if_available)
4925         (get_frame_address_in_block_if_available, get_frame_language):
4926         Replace throw_exception with throw.
4927         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4928         throw_exception with throw.
4929         * eval.c (fetch_subexp_value, evaluate_var_value)
4930         (evaluate_funcall, evaluate_subexp_standard): Replace
4931         throw_exception with throw.
4932         * dwarf2loc.c (call_site_find_chain)
4933         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4934         Replace throw_exception with throw.
4935         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4936         with throw.
4937         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4938         throw.
4939         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4940         * completer.c (complete_line_internal): Replace throw_exception
4941         with throw.
4942         * compile/compile-object-run.c (compile_object_run): Replace
4943         throw_exception with throw.
4944         * cli/cli-script.c (process_next_line): Replace throw_exception
4945         with throw.
4946         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4947         (btrace_enable, btrace_maint_update_pt_packets): Replace
4948         throw_exception with throw.
4949         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4950         throw_exception with throw.
4951         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4952         throw_exception with throw.
4953         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4954         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4955         * aarch64-tdep.c (aarch64_make_prologue_cache)
4956         (aarch64_make_stub_cache): Replace throw_exception with throw.
4957
4958 2019-04-08  Tom Tromey  <tom@tromey.com>
4959
4960         * common/common-exceptions.c (throw_exception): Rename from
4961         throw_exception_cxx.  Remove old copy.  Make argument const.
4962         (throw_it): Create and throw exception objects directly.
4963         * common/common-exceptions.h (throw_exception): Make argument
4964         const.
4965         (struct gdb_exception_error): Add constructor.
4966         (struct gdb_exception_quit): Add constructor.
4967
4968 2019-04-08  Tom Tromey  <tom@tromey.com>
4969
4970         * common/common-exceptions.h (exception_rethrow): Don't declare.
4971         (TRY_SJLJ): Update comment.
4972         (TRY, CATCH, END_CATCH): Remove.
4973         * common/common-exceptions.c (exception_rethrow): Remove.
4974
4975 2019-04-08  Tom Tromey  <tom@tromey.com>
4976
4977         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4978         Remove.
4979         (gdb_exception_error): Rename from
4980         gdb_exception_RETURN_MASK_ERROR.
4981         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4982         (gdb_quit_bad_alloc): Update.
4983         * aarch64-tdep.c: Update.
4984         * ada-lang.c: Update.
4985         * ada-typeprint.c: Update.
4986         * ada-valprint.c: Update.
4987         * amd64-tdep.c: Update.
4988         * arch-utils.c: Update.
4989         * break-catch-throw.c: Update.
4990         * breakpoint.c: Update.
4991         * btrace.c: Update.
4992         * c-varobj.c: Update.
4993         * cli/cli-cmds.c: Update.
4994         * cli/cli-interp.c: Update.
4995         * cli/cli-script.c: Update.
4996         * common/common-exceptions.c: Update.
4997         * common/new-op.c: Update.
4998         * common/selftest.c: Update.
4999         * compile/compile-c-symbols.c: Update.
5000         * compile/compile-cplus-symbols.c: Update.
5001         * compile/compile-object-load.c: Update.
5002         * compile/compile-object-run.c: Update.
5003         * completer.c: Update.
5004         * corelow.c: Update.
5005         * cp-abi.c: Update.
5006         * cp-support.c: Update.
5007         * cp-valprint.c: Update.
5008         * darwin-nat.c: Update.
5009         * disasm-selftests.c: Update.
5010         * dtrace-probe.c: Update.
5011         * dwarf-index-cache.c: Update.
5012         * dwarf-index-write.c: Update.
5013         * dwarf2-frame-tailcall.c: Update.
5014         * dwarf2-frame.c: Update.
5015         * dwarf2loc.c: Update.
5016         * dwarf2read.c: Update.
5017         * eval.c: Update.
5018         * event-loop.c: Update.
5019         * event-top.c: Update.
5020         * exec.c: Update.
5021         * f-valprint.c: Update.
5022         * fbsd-tdep.c: Update.
5023         * frame-unwind.c: Update.
5024         * frame.c: Update.
5025         * gdbtypes.c: Update.
5026         * gnu-v3-abi.c: Update.
5027         * guile/guile-internal.h: Update.
5028         * guile/scm-block.c: Update.
5029         * guile/scm-breakpoint.c: Update.
5030         * guile/scm-cmd.c: Update.
5031         * guile/scm-disasm.c: Update.
5032         * guile/scm-frame.c: Update.
5033         * guile/scm-lazy-string.c: Update.
5034         * guile/scm-math.c: Update.
5035         * guile/scm-param.c: Update.
5036         * guile/scm-ports.c: Update.
5037         * guile/scm-pretty-print.c: Update.
5038         * guile/scm-symbol.c: Update.
5039         * guile/scm-symtab.c: Update.
5040         * guile/scm-type.c: Update.
5041         * guile/scm-value.c: Update.
5042         * i386-linux-tdep.c: Update.
5043         * i386-tdep.c: Update.
5044         * inf-loop.c: Update.
5045         * infcall.c: Update.
5046         * infcmd.c: Update.
5047         * infrun.c: Update.
5048         * jit.c: Update.
5049         * language.c: Update.
5050         * linespec.c: Update.
5051         * linux-fork.c: Update.
5052         * linux-nat.c: Update.
5053         * linux-tdep.c: Update.
5054         * linux-thread-db.c: Update.
5055         * main.c: Update.
5056         * mi/mi-cmd-break.c: Update.
5057         * mi/mi-cmd-stack.c: Update.
5058         * mi/mi-interp.c: Update.
5059         * mi/mi-main.c: Update.
5060         * objc-lang.c: Update.
5061         * p-valprint.c: Update.
5062         * parse.c: Update.
5063         * ppc-linux-tdep.c: Update.
5064         * printcmd.c: Update.
5065         * python/py-arch.c: Update.
5066         * python/py-breakpoint.c: Update.
5067         * python/py-cmd.c: Update.
5068         * python/py-finishbreakpoint.c: Update.
5069         * python/py-frame.c: Update.
5070         * python/py-framefilter.c: Update.
5071         * python/py-gdb-readline.c: Update.
5072         * python/py-inferior.c: Update.
5073         * python/py-infthread.c: Update.
5074         * python/py-lazy-string.c: Update.
5075         * python/py-linetable.c: Update.
5076         * python/py-objfile.c: Update.
5077         * python/py-param.c: Update.
5078         * python/py-prettyprint.c: Update.
5079         * python/py-progspace.c: Update.
5080         * python/py-record-btrace.c: Update.
5081         * python/py-record.c: Update.
5082         * python/py-symbol.c: Update.
5083         * python/py-type.c: Update.
5084         * python/py-unwind.c: Update.
5085         * python/py-utils.c: Update.
5086         * python/py-value.c: Update.
5087         * python/python.c: Update.
5088         * record-btrace.c: Update.
5089         * record-full.c: Update.
5090         * remote-fileio.c: Update.
5091         * remote.c: Update.
5092         * riscv-tdep.c: Update.
5093         * rs6000-aix-tdep.c: Update.
5094         * rs6000-tdep.c: Update.
5095         * rust-exp.y: Update.
5096         * rust-lang.c: Update.
5097         * s390-tdep.c: Update.
5098         * selftest-arch.c: Update.
5099         * solib-dsbt.c: Update.
5100         * solib-frv.c: Update.
5101         * solib-spu.c: Update.
5102         * solib-svr4.c: Update.
5103         * solib.c: Update.
5104         * sparc64-linux-tdep.c: Update.
5105         * stack.c: Update.
5106         * symfile-mem.c: Update.
5107         * symmisc.c: Update.
5108         * target.c: Update.
5109         * thread.c: Update.
5110         * top.c: Update.
5111         * tracefile-tfile.c: Update.
5112         * tui/tui.c: Update.
5113         * typeprint.c: Update.
5114         * unittests/cli-utils-selftests.c: Update.
5115         * unittests/parse-connection-spec-selftests.c: Update.
5116         * valops.c: Update.
5117         * valprint.c: Update.
5118         * value.c: Update.
5119         * varobj.c: Update.
5120         * windows-nat.c: Update.
5121         * x86-linux-nat.c: Update.
5122         * xml-support.c: Update.
5123
5124 2019-04-08  Tom Tromey  <tom@tromey.com>
5125
5126         * xml-support.c: Use C++ exception handling.
5127         * x86-linux-nat.c: Use C++ exception handling.
5128         * windows-nat.c: Use C++ exception handling.
5129         * varobj.c: Use C++ exception handling.
5130         * value.c: Use C++ exception handling.
5131         * valprint.c: Use C++ exception handling.
5132         * valops.c: Use C++ exception handling.
5133         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5134         handling.
5135         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5136         * typeprint.c: Use C++ exception handling.
5137         * tui/tui.c: Use C++ exception handling.
5138         * tracefile-tfile.c: Use C++ exception handling.
5139         * top.c: Use C++ exception handling.
5140         * thread.c: Use C++ exception handling.
5141         * target.c: Use C++ exception handling.
5142         * symmisc.c: Use C++ exception handling.
5143         * symfile-mem.c: Use C++ exception handling.
5144         * stack.c: Use C++ exception handling.
5145         * sparc64-linux-tdep.c: Use C++ exception handling.
5146         * solib.c: Use C++ exception handling.
5147         * solib-svr4.c: Use C++ exception handling.
5148         * solib-spu.c: Use C++ exception handling.
5149         * solib-frv.c: Use C++ exception handling.
5150         * solib-dsbt.c: Use C++ exception handling.
5151         * selftest-arch.c: Use C++ exception handling.
5152         * s390-tdep.c: Use C++ exception handling.
5153         * rust-lang.c: Use C++ exception handling.
5154         * rust-exp.y: Use C++ exception handling.
5155         * rs6000-tdep.c: Use C++ exception handling.
5156         * rs6000-aix-tdep.c: Use C++ exception handling.
5157         * riscv-tdep.c: Use C++ exception handling.
5158         * remote.c: Use C++ exception handling.
5159         * remote-fileio.c: Use C++ exception handling.
5160         * record-full.c: Use C++ exception handling.
5161         * record-btrace.c: Use C++ exception handling.
5162         * python/python.c: Use C++ exception handling.
5163         * python/py-value.c: Use C++ exception handling.
5164         * python/py-utils.c: Use C++ exception handling.
5165         * python/py-unwind.c: Use C++ exception handling.
5166         * python/py-type.c: Use C++ exception handling.
5167         * python/py-symbol.c: Use C++ exception handling.
5168         * python/py-record.c: Use C++ exception handling.
5169         * python/py-record-btrace.c: Use C++ exception handling.
5170         * python/py-progspace.c: Use C++ exception handling.
5171         * python/py-prettyprint.c: Use C++ exception handling.
5172         * python/py-param.c: Use C++ exception handling.
5173         * python/py-objfile.c: Use C++ exception handling.
5174         * python/py-linetable.c: Use C++ exception handling.
5175         * python/py-lazy-string.c: Use C++ exception handling.
5176         * python/py-infthread.c: Use C++ exception handling.
5177         * python/py-inferior.c: Use C++ exception handling.
5178         * python/py-gdb-readline.c: Use C++ exception handling.
5179         * python/py-framefilter.c: Use C++ exception handling.
5180         * python/py-frame.c: Use C++ exception handling.
5181         * python/py-finishbreakpoint.c: Use C++ exception handling.
5182         * python/py-cmd.c: Use C++ exception handling.
5183         * python/py-breakpoint.c: Use C++ exception handling.
5184         * python/py-arch.c: Use C++ exception handling.
5185         * printcmd.c: Use C++ exception handling.
5186         * ppc-linux-tdep.c: Use C++ exception handling.
5187         * parse.c: Use C++ exception handling.
5188         * p-valprint.c: Use C++ exception handling.
5189         * objc-lang.c: Use C++ exception handling.
5190         * mi/mi-main.c: Use C++ exception handling.
5191         * mi/mi-interp.c: Use C++ exception handling.
5192         * mi/mi-cmd-stack.c: Use C++ exception handling.
5193         * mi/mi-cmd-break.c: Use C++ exception handling.
5194         * main.c: Use C++ exception handling.
5195         * linux-thread-db.c: Use C++ exception handling.
5196         * linux-tdep.c: Use C++ exception handling.
5197         * linux-nat.c: Use C++ exception handling.
5198         * linux-fork.c: Use C++ exception handling.
5199         * linespec.c: Use C++ exception handling.
5200         * language.c: Use C++ exception handling.
5201         * jit.c: Use C++ exception handling.
5202         * infrun.c: Use C++ exception handling.
5203         * infcmd.c: Use C++ exception handling.
5204         * infcall.c: Use C++ exception handling.
5205         * inf-loop.c: Use C++ exception handling.
5206         * i386-tdep.c: Use C++ exception handling.
5207         * i386-linux-tdep.c: Use C++ exception handling.
5208         * guile/scm-value.c: Use C++ exception handling.
5209         * guile/scm-type.c: Use C++ exception handling.
5210         * guile/scm-symtab.c: Use C++ exception handling.
5211         * guile/scm-symbol.c: Use C++ exception handling.
5212         * guile/scm-pretty-print.c: Use C++ exception handling.
5213         * guile/scm-ports.c: Use C++ exception handling.
5214         * guile/scm-param.c: Use C++ exception handling.
5215         * guile/scm-math.c: Use C++ exception handling.
5216         * guile/scm-lazy-string.c: Use C++ exception handling.
5217         * guile/scm-frame.c: Use C++ exception handling.
5218         * guile/scm-disasm.c: Use C++ exception handling.
5219         * guile/scm-cmd.c: Use C++ exception handling.
5220         * guile/scm-breakpoint.c: Use C++ exception handling.
5221         * guile/scm-block.c: Use C++ exception handling.
5222         * guile/guile-internal.h: Use C++ exception handling.
5223         * gnu-v3-abi.c: Use C++ exception handling.
5224         * gdbtypes.c: Use C++ exception handling.
5225         * frame.c: Use C++ exception handling.
5226         * frame-unwind.c: Use C++ exception handling.
5227         * fbsd-tdep.c: Use C++ exception handling.
5228         * f-valprint.c: Use C++ exception handling.
5229         * exec.c: Use C++ exception handling.
5230         * event-top.c: Use C++ exception handling.
5231         * event-loop.c: Use C++ exception handling.
5232         * eval.c: Use C++ exception handling.
5233         * dwarf2read.c: Use C++ exception handling.
5234         * dwarf2loc.c: Use C++ exception handling.
5235         * dwarf2-frame.c: Use C++ exception handling.
5236         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5237         * dwarf-index-write.c: Use C++ exception handling.
5238         * dwarf-index-cache.c: Use C++ exception handling.
5239         * dtrace-probe.c: Use C++ exception handling.
5240         * disasm-selftests.c: Use C++ exception handling.
5241         * darwin-nat.c: Use C++ exception handling.
5242         * cp-valprint.c: Use C++ exception handling.
5243         * cp-support.c: Use C++ exception handling.
5244         * cp-abi.c: Use C++ exception handling.
5245         * corelow.c: Use C++ exception handling.
5246         * completer.c: Use C++ exception handling.
5247         * compile/compile-object-run.c: Use C++ exception handling.
5248         * compile/compile-object-load.c: Use C++ exception handling.
5249         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5250         * compile/compile-c-symbols.c: Use C++ exception handling.
5251         * common/selftest.c: Use C++ exception handling.
5252         * common/new-op.c: Use C++ exception handling.
5253         * cli/cli-script.c: Use C++ exception handling.
5254         * cli/cli-interp.c: Use C++ exception handling.
5255         * cli/cli-cmds.c: Use C++ exception handling.
5256         * c-varobj.c: Use C++ exception handling.
5257         * btrace.c: Use C++ exception handling.
5258         * breakpoint.c: Use C++ exception handling.
5259         * break-catch-throw.c: Use C++ exception handling.
5260         * arch-utils.c: Use C++ exception handling.
5261         * amd64-tdep.c: Use C++ exception handling.
5262         * ada-valprint.c: Use C++ exception handling.
5263         * ada-typeprint.c: Use C++ exception handling.
5264         * ada-lang.c: Use C++ exception handling.
5265         * aarch64-tdep.c: Use C++ exception handling.
5266
5267 2019-04-08  Tom Tromey  <tom@tromey.com>
5268
5269         * xml-support.c (gdb_xml_parser::parse): Update.
5270         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5271         * value.c (show_convenience): Update.
5272         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5273         (test_parse_flags_qcs): Update.
5274         * thread.c (thr_try_catch_cmd): Update.
5275         * target.c (target_translate_tls_address): Update.
5276         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5277         (info_frame_command_core, frame_apply_command_count): Update.
5278         * rust-exp.y (rust_lex_exception_test): Update.
5279         * riscv-tdep.c (riscv_print_one_register_info): Update.
5280         * remote.c (remote_target::enable_btrace): Update.
5281         * record-btrace.c (record_btrace_enable_warn): Update.
5282         * python/py-utils.c (gdbpy_convert_exception): Update.
5283         * printcmd.c (do_one_display, print_variable_and_value): Update.
5284         * mi/mi-main.c (mi_print_exception): Update.
5285         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5286         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5287         * linux-nat.c (linux_nat_target::attach): Update.
5288         * linux-fork.c (class scoped_switch_fork_info): Update.
5289         * infrun.c (displaced_step_prepare): Update.
5290         * infcall.c (call_function_by_hand_dummy): Update.
5291         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5292         * gnu-v3-abi.c (print_one_vtable): Update.
5293         * frame.c (get_prev_frame_always): Update.
5294         * f-valprint.c (info_common_command_for_block): Update.
5295         * exec.c (try_open_exec_file): Update.
5296         * exceptions.c (print_exception, exception_print)
5297         (exception_fprintf, exception_print_same): Update.
5298         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5299         * dwarf-index-cache.c (index_cache::store)
5300         (index_cache::lookup_gdb_index): Update.
5301         * darwin-nat.c (maybe_cache_shell): Update.
5302         * cp-valprint.c (cp_print_value_fields): Update.
5303         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5304         (gcc_cplus_symbol_address): Update.
5305         * compile/compile-c-symbols.c (gcc_convert_symbol)
5306         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5307         * common/selftest.c: Update.
5308         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5309         a std::string.
5310         (exception_try_scope_entry, exception_try_scope_exit): Don't
5311         declare.
5312         (struct exception_try_scope): Remove.
5313         (TRY): Don't use exception_try_scope.
5314         (struct gdb_exception): Add constructor, operator=.
5315         <what>: New method.
5316         (struct gdb_exception_RETURN_MASK_ALL)
5317         (struct gdb_exception_RETURN_MASK_ERROR)
5318         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5319         (struct gdb_quit_bad_alloc): Update.
5320         * common/common-exceptions.c (exception_none): Change
5321         initializer.
5322         (struct catcher) <state, exception>: Initialize inline.
5323         <prev>: Remove member.
5324         (current_catcher): Remove.
5325         (catchers): New global.
5326         (exceptions_state_mc_init): Simplify.
5327         (catcher_pop): Remove.
5328         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5329         (try_scope_depth, exception_try_scope_entry)
5330         (exception_try_scope_exit): Remove.
5331         (throw_exception_sjlj): Update.
5332         (exception_messages, exception_messages_size): Remove.
5333         (throw_it): Simplify.
5334         (gdb_exception_sliced_copy): Remove.
5335         (throw_exception_cxx): Update.
5336         * cli/cli-script.c (script_from_file): Update.
5337         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5338         Update.
5339         * ada-valprint.c (ada_val_print): Update.
5340         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5341         (create_excep_cond_exprs): Update.
5342
5343 2019-04-08  Tom Tromey  <tom@tromey.com>
5344
5345         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5346         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5347         (TRY, CATCH, END_CATCH): Remove some definitions.
5348         * common/common-exceptions.c: Don't use GDB_XCPT.
5349         (catcher_list_size): Remove.
5350         (throw_exception, throw_it): Simplify.
5351
5352 2019-04-05  Tom Tromey  <tom@tromey.com>
5353
5354         Revert the header-sorting patch.
5355         * ft32-tdep.c: Revert.
5356         * frv-tdep.c: Revert.
5357         * frv-linux-tdep.c: Revert.
5358         * frame.c: Revert.
5359         * frame-unwind.c: Revert.
5360         * frame-base.c: Revert.
5361         * fork-child.c: Revert.
5362         * findvar.c: Revert.
5363         * findcmd.c: Revert.
5364         * filesystem.c: Revert.
5365         * filename-seen-cache.h: Revert.
5366         * filename-seen-cache.c: Revert.
5367         * fbsd-tdep.c: Revert.
5368         * fbsd-nat.h: Revert.
5369         * fbsd-nat.c: Revert.
5370         * f-valprint.c: Revert.
5371         * f-typeprint.c: Revert.
5372         * f-lang.c: Revert.
5373         * extension.h: Revert.
5374         * extension.c: Revert.
5375         * extension-priv.h: Revert.
5376         * expprint.c: Revert.
5377         * exec.h: Revert.
5378         * exec.c: Revert.
5379         * exceptions.c: Revert.
5380         * event-top.c: Revert.
5381         * event-loop.c: Revert.
5382         * eval.c: Revert.
5383         * elfread.c: Revert.
5384         * dwarf2read.h: Revert.
5385         * dwarf2read.c: Revert.
5386         * dwarf2loc.c: Revert.
5387         * dwarf2expr.h: Revert.
5388         * dwarf2expr.c: Revert.
5389         * dwarf2-frame.c: Revert.
5390         * dwarf2-frame-tailcall.c: Revert.
5391         * dwarf-index-write.h: Revert.
5392         * dwarf-index-write.c: Revert.
5393         * dwarf-index-common.c: Revert.
5394         * dwarf-index-cache.h: Revert.
5395         * dwarf-index-cache.c: Revert.
5396         * dummy-frame.c: Revert.
5397         * dtrace-probe.c: Revert.
5398         * disasm.h: Revert.
5399         * disasm.c: Revert.
5400         * disasm-selftests.c: Revert.
5401         * dictionary.c: Revert.
5402         * dicos-tdep.c: Revert.
5403         * demangle.c: Revert.
5404         * dcache.h: Revert.
5405         * dcache.c: Revert.
5406         * darwin-nat.h: Revert.
5407         * darwin-nat.c: Revert.
5408         * darwin-nat-info.c: Revert.
5409         * d-valprint.c: Revert.
5410         * d-namespace.c: Revert.
5411         * d-lang.c: Revert.
5412         * ctf.c: Revert.
5413         * csky-tdep.c: Revert.
5414         * csky-linux-tdep.c: Revert.
5415         * cris-tdep.c: Revert.
5416         * cris-linux-tdep.c: Revert.
5417         * cp-valprint.c: Revert.
5418         * cp-support.c: Revert.
5419         * cp-namespace.c: Revert.
5420         * cp-abi.c: Revert.
5421         * corelow.c: Revert.
5422         * corefile.c: Revert.
5423         * continuations.c: Revert.
5424         * completer.h: Revert.
5425         * completer.c: Revert.
5426         * complaints.c: Revert.
5427         * coffread.c: Revert.
5428         * coff-pe-read.c: Revert.
5429         * cli-out.h: Revert.
5430         * cli-out.c: Revert.
5431         * charset.c: Revert.
5432         * c-varobj.c: Revert.
5433         * c-valprint.c: Revert.
5434         * c-typeprint.c: Revert.
5435         * c-lang.c: Revert.
5436         * buildsym.c: Revert.
5437         * buildsym-legacy.c: Revert.
5438         * build-id.h: Revert.
5439         * build-id.c: Revert.
5440         * btrace.c: Revert.
5441         * bsd-uthread.c: Revert.
5442         * breakpoint.h: Revert.
5443         * breakpoint.c: Revert.
5444         * break-catch-throw.c: Revert.
5445         * break-catch-syscall.c: Revert.
5446         * break-catch-sig.c: Revert.
5447         * blockframe.c: Revert.
5448         * block.c: Revert.
5449         * bfin-tdep.c: Revert.
5450         * bfin-linux-tdep.c: Revert.
5451         * bfd-target.c: Revert.
5452         * bcache.c: Revert.
5453         * ax-general.c: Revert.
5454         * ax-gdb.h: Revert.
5455         * ax-gdb.c: Revert.
5456         * avr-tdep.c: Revert.
5457         * auxv.c: Revert.
5458         * auto-load.c: Revert.
5459         * arm-wince-tdep.c: Revert.
5460         * arm-tdep.c: Revert.
5461         * arm-symbian-tdep.c: Revert.
5462         * arm-pikeos-tdep.c: Revert.
5463         * arm-obsd-tdep.c: Revert.
5464         * arm-nbsd-tdep.c: Revert.
5465         * arm-nbsd-nat.c: Revert.
5466         * arm-linux-tdep.c: Revert.
5467         * arm-linux-nat.c: Revert.
5468         * arm-fbsd-tdep.c: Revert.
5469         * arm-fbsd-nat.c: Revert.
5470         * arm-bsd-tdep.c: Revert.
5471         * arch-utils.c: Revert.
5472         * arc-tdep.c: Revert.
5473         * arc-newlib-tdep.c: Revert.
5474         * annotate.h: Revert.
5475         * annotate.c: Revert.
5476         * amd64-windows-tdep.c: Revert.
5477         * amd64-windows-nat.c: Revert.
5478         * amd64-tdep.c: Revert.
5479         * amd64-sol2-tdep.c: Revert.
5480         * amd64-obsd-tdep.c: Revert.
5481         * amd64-obsd-nat.c: Revert.
5482         * amd64-nbsd-tdep.c: Revert.
5483         * amd64-nbsd-nat.c: Revert.
5484         * amd64-nat.c: Revert.
5485         * amd64-linux-tdep.c: Revert.
5486         * amd64-linux-nat.c: Revert.
5487         * amd64-fbsd-tdep.c: Revert.
5488         * amd64-fbsd-nat.c: Revert.
5489         * amd64-dicos-tdep.c: Revert.
5490         * amd64-darwin-tdep.c: Revert.
5491         * amd64-bsd-nat.c: Revert.
5492         * alpha-tdep.c: Revert.
5493         * alpha-obsd-tdep.c: Revert.
5494         * alpha-nbsd-tdep.c: Revert.
5495         * alpha-mdebug-tdep.c: Revert.
5496         * alpha-linux-tdep.c: Revert.
5497         * alpha-linux-nat.c: Revert.
5498         * alpha-bsd-tdep.c: Revert.
5499         * alpha-bsd-nat.c: Revert.
5500         * aix-thread.c: Revert.
5501         * agent.c: Revert.
5502         * addrmap.c: Revert.
5503         * ada-varobj.c: Revert.
5504         * ada-valprint.c: Revert.
5505         * ada-typeprint.c: Revert.
5506         * ada-tasks.c: Revert.
5507         * ada-lang.c: Revert.
5508         * aarch64-tdep.c: Revert.
5509         * aarch64-ravenscar-thread.c: Revert.
5510         * aarch64-newlib-tdep.c: Revert.
5511         * aarch64-linux-tdep.c: Revert.
5512         * aarch64-linux-nat.c: Revert.
5513         * aarch64-fbsd-tdep.c: Revert.
5514         * aarch64-fbsd-nat.c: Revert.
5515         * aarch32-linux-nat.c: Revert.
5516
5517 2019-04-05  Tom Tromey  <tom@tromey.com>
5518
5519         * ft32-tdep.c: Sort headers.
5520         * frv-tdep.c: Sort headers.
5521         * frv-linux-tdep.c: Sort headers.
5522         * frame.c: Sort headers.
5523         * frame-unwind.c: Sort headers.
5524         * frame-base.c: Sort headers.
5525         * fork-child.c: Sort headers.
5526         * findvar.c: Sort headers.
5527         * findcmd.c: Sort headers.
5528         * filesystem.c: Sort headers.
5529         * filename-seen-cache.h: Sort headers.
5530         * filename-seen-cache.c: Sort headers.
5531         * fbsd-tdep.c: Sort headers.
5532         * fbsd-nat.h: Sort headers.
5533         * fbsd-nat.c: Sort headers.
5534         * f-valprint.c: Sort headers.
5535         * f-typeprint.c: Sort headers.
5536         * f-lang.c: Sort headers.
5537         * extension.h: Sort headers.
5538         * extension.c: Sort headers.
5539         * extension-priv.h: Sort headers.
5540         * expprint.c: Sort headers.
5541         * exec.h: Sort headers.
5542         * exec.c: Sort headers.
5543         * exceptions.c: Sort headers.
5544         * event-top.c: Sort headers.
5545         * event-loop.c: Sort headers.
5546         * eval.c: Sort headers.
5547         * elfread.c: Sort headers.
5548         * dwarf2read.h: Sort headers.
5549         * dwarf2read.c: Sort headers.
5550         * dwarf2loc.c: Sort headers.
5551         * dwarf2expr.h: Sort headers.
5552         * dwarf2expr.c: Sort headers.
5553         * dwarf2-frame.c: Sort headers.
5554         * dwarf2-frame-tailcall.c: Sort headers.
5555         * dwarf-index-write.h: Sort headers.
5556         * dwarf-index-write.c: Sort headers.
5557         * dwarf-index-common.c: Sort headers.
5558         * dwarf-index-cache.h: Sort headers.
5559         * dwarf-index-cache.c: Sort headers.
5560         * dummy-frame.c: Sort headers.
5561         * dtrace-probe.c: Sort headers.
5562         * disasm.h: Sort headers.
5563         * disasm.c: Sort headers.
5564         * disasm-selftests.c: Sort headers.
5565         * dictionary.c: Sort headers.
5566         * dicos-tdep.c: Sort headers.
5567         * demangle.c: Sort headers.
5568         * dcache.h: Sort headers.
5569         * dcache.c: Sort headers.
5570         * darwin-nat.h: Sort headers.
5571         * darwin-nat.c: Sort headers.
5572         * darwin-nat-info.c: Sort headers.
5573         * d-valprint.c: Sort headers.
5574         * d-namespace.c: Sort headers.
5575         * d-lang.c: Sort headers.
5576         * ctf.c: Sort headers.
5577         * csky-tdep.c: Sort headers.
5578         * csky-linux-tdep.c: Sort headers.
5579         * cris-tdep.c: Sort headers.
5580         * cris-linux-tdep.c: Sort headers.
5581         * cp-valprint.c: Sort headers.
5582         * cp-support.c: Sort headers.
5583         * cp-namespace.c: Sort headers.
5584         * cp-abi.c: Sort headers.
5585         * corelow.c: Sort headers.
5586         * corefile.c: Sort headers.
5587         * continuations.c: Sort headers.
5588         * completer.h: Sort headers.
5589         * completer.c: Sort headers.
5590         * complaints.c: Sort headers.
5591         * coffread.c: Sort headers.
5592         * coff-pe-read.c: Sort headers.
5593         * cli-out.h: Sort headers.
5594         * cli-out.c: Sort headers.
5595         * charset.c: Sort headers.
5596         * c-varobj.c: Sort headers.
5597         * c-valprint.c: Sort headers.
5598         * c-typeprint.c: Sort headers.
5599         * c-lang.c: Sort headers.
5600         * buildsym.c: Sort headers.
5601         * buildsym-legacy.c: Sort headers.
5602         * build-id.h: Sort headers.
5603         * build-id.c: Sort headers.
5604         * btrace.c: Sort headers.
5605         * bsd-uthread.c: Sort headers.
5606         * breakpoint.h: Sort headers.
5607         * breakpoint.c: Sort headers.
5608         * break-catch-throw.c: Sort headers.
5609         * break-catch-syscall.c: Sort headers.
5610         * break-catch-sig.c: Sort headers.
5611         * blockframe.c: Sort headers.
5612         * block.c: Sort headers.
5613         * bfin-tdep.c: Sort headers.
5614         * bfin-linux-tdep.c: Sort headers.
5615         * bfd-target.c: Sort headers.
5616         * bcache.c: Sort headers.
5617         * ax-general.c: Sort headers.
5618         * ax-gdb.h: Sort headers.
5619         * ax-gdb.c: Sort headers.
5620         * avr-tdep.c: Sort headers.
5621         * auxv.c: Sort headers.
5622         * auto-load.c: Sort headers.
5623         * arm-wince-tdep.c: Sort headers.
5624         * arm-tdep.c: Sort headers.
5625         * arm-symbian-tdep.c: Sort headers.
5626         * arm-pikeos-tdep.c: Sort headers.
5627         * arm-obsd-tdep.c: Sort headers.
5628         * arm-nbsd-tdep.c: Sort headers.
5629         * arm-nbsd-nat.c: Sort headers.
5630         * arm-linux-tdep.c: Sort headers.
5631         * arm-linux-nat.c: Sort headers.
5632         * arm-fbsd-tdep.c: Sort headers.
5633         * arm-fbsd-nat.c: Sort headers.
5634         * arm-bsd-tdep.c: Sort headers.
5635         * arch-utils.c: Sort headers.
5636         * arc-tdep.c: Sort headers.
5637         * arc-newlib-tdep.c: Sort headers.
5638         * annotate.h: Sort headers.
5639         * annotate.c: Sort headers.
5640         * amd64-windows-tdep.c: Sort headers.
5641         * amd64-windows-nat.c: Sort headers.
5642         * amd64-tdep.c: Sort headers.
5643         * amd64-sol2-tdep.c: Sort headers.
5644         * amd64-obsd-tdep.c: Sort headers.
5645         * amd64-obsd-nat.c: Sort headers.
5646         * amd64-nbsd-tdep.c: Sort headers.
5647         * amd64-nbsd-nat.c: Sort headers.
5648         * amd64-nat.c: Sort headers.
5649         * amd64-linux-tdep.c: Sort headers.
5650         * amd64-linux-nat.c: Sort headers.
5651         * amd64-fbsd-tdep.c: Sort headers.
5652         * amd64-fbsd-nat.c: Sort headers.
5653         * amd64-dicos-tdep.c: Sort headers.
5654         * amd64-darwin-tdep.c: Sort headers.
5655         * amd64-bsd-nat.c: Sort headers.
5656         * alpha-tdep.c: Sort headers.
5657         * alpha-obsd-tdep.c: Sort headers.
5658         * alpha-nbsd-tdep.c: Sort headers.
5659         * alpha-mdebug-tdep.c: Sort headers.
5660         * alpha-linux-tdep.c: Sort headers.
5661         * alpha-linux-nat.c: Sort headers.
5662         * alpha-bsd-tdep.c: Sort headers.
5663         * alpha-bsd-nat.c: Sort headers.
5664         * aix-thread.c: Sort headers.
5665         * agent.c: Sort headers.
5666         * addrmap.c: Sort headers.
5667         * ada-varobj.c: Sort headers.
5668         * ada-valprint.c: Sort headers.
5669         * ada-typeprint.c: Sort headers.
5670         * ada-tasks.c: Sort headers.
5671         * ada-lang.c: Sort headers.
5672         * aarch64-tdep.c: Sort headers.
5673         * aarch64-ravenscar-thread.c: Sort headers.
5674         * aarch64-newlib-tdep.c: Sort headers.
5675         * aarch64-linux-tdep.c: Sort headers.
5676         * aarch64-linux-nat.c: Sort headers.
5677         * aarch64-fbsd-tdep.c: Sort headers.
5678         * aarch64-fbsd-nat.c: Sort headers.
5679         * aarch32-linux-nat.c: Sort headers.
5680
5681 2019-04-04  Tom Tromey  <tom@tromey.com>
5682
5683         * varobj.c (varobj_create): Update.
5684         * rust-exp.y (struct rust_parser) <update_innermost_block,
5685         lookup_symbol>: New methods.
5686         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5687         Rename.
5688         (rust_parser::rust_lookup_type)
5689         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5690         * printcmd.c (display_command, do_one_display): Update.
5691         * parser-defs.h (struct parser_state) <parser_state>: Add
5692         "tracker" parameter.
5693         (block_tracker): New member.
5694         (class innermost_block_tracker) <innermost_block_tracker>: Add
5695         "types" parameter.
5696         <reset>: Remove method.
5697         (innermost_block): Don't declare.
5698         (null_post_parser): Update.
5699         * parse.c (innermost_block): Remove global.
5700         (write_dollar_variable): Update.
5701         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5702         Remove "tracker_types" parameter.
5703         (parse_expression): Add "tracker" parameter.
5704         (parse_expression_for_completion): Update.
5705         (null_post_parser): Add "tracker" parameter.
5706         * p-exp.y: Update rules.
5707         * m2-exp.y: Update rules.
5708         * language.h (struct language_defn) <la_post_parser>: Add
5709         "tracker" parameter.
5710         * go-exp.y: Update rules.
5711         * f-exp.y: Update rules.
5712         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5713         parameter.
5714         * d-exp.y: Update rules.
5715         * c-exp.y: Update rules.
5716         * breakpoint.c (set_breakpoint_condition): Create an
5717         innermost_block_tracker.
5718         (watch_command_1): Likewise.
5719         * ada-lang.c (resolve): Add "tracker" parameter.
5720         (resolve_subexp): Likewise.
5721         * ada-exp.y (write_var_from_sym): Update.
5722
5723 2019-04-04  Tom Tromey  <tom@tromey.com>
5724
5725         * type-stack.h: New file.
5726         * type-stack.c: New file.
5727         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5728         type-stack.h.
5729         (insert_into_type_stack, insert_type, push_type, push_type_int)
5730         (insert_type_address_space, pop_type, pop_type_int)
5731         (pop_typelist, pop_type_stack, append_type_stack)
5732         (push_type_stack, get_type_stack, push_typelist)
5733         (follow_type_instance_flags, follow_types): Don't declare.
5734         * parse.c (type_stack): Remove global.
5735         (parse_exp_in_context): Update.
5736         (insert_into_type_stack, insert_type, push_type, push_type_int)
5737         (insert_type_address_space, pop_type, pop_type_int)
5738         (pop_typelist, pop_type_stack, append_type_stack)
5739         (push_type_stack, get_type_stack, push_typelist)
5740         (follow_type_instance_flags, follow_types): Remove (moved to
5741         type-stack.c).
5742         * f-exp.y (type_stack): New global.
5743         Update rules.
5744         (push_kind_type, f_parse): Update.
5745         * d-exp.y (type_stack): New global.
5746         Update rules.
5747         (d_parse): Update.
5748         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5749         Update rules.
5750         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5751         (HFILES_NO_SRCDIR): Add type-stack.h.
5752
5753 2019-04-04  Tom Tromey  <tom@tromey.com>
5754
5755         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5756         (rust_parser::convert_ast_to_expression, rust_parse)
5757         (rust_lex_test_completion, rust_lex_tests): Update.
5758         * parser-defs.h (struct expr_completion_state): New.
5759         (struct parser_state) <parser_state>: Add completion parameter.
5760         <mark_struct_expression, mark_completion_tag>: New methods.
5761         <parse_completion, m_completion_state>: New members.
5762         (prefixify_expression, null_post_parser): Update.
5763         (mark_struct_expression, mark_completion_tag): Don't declare.
5764         * parse.c (parse_completion, expout_last_struct)
5765         (expout_tag_completion_type, expout_completion_name): Remove
5766         globals.
5767         (parser_state::mark_struct_expression)
5768         (parser_state::mark_completion_tag): Now methods.
5769         (prefixify_expression): Add last_struct parameter.
5770         (prefixify_subexp): Likewise.
5771         (parse_exp_1): Update.
5772         (parse_exp_in_context): Add cstate parameter.  Update.
5773         (parse_expression_for_completion): Create an
5774         expr_completion_state.
5775         (null_post_parser): Add "completion" parameter.
5776         * p-exp.y: Update rules.
5777         (yylex): Update.
5778         * language.h (struct language_defn) <la_post_parser>: Add
5779         "completing" parameter.
5780         * go-exp.y: Update rules.
5781         (lex_one_token): Update.
5782         * expression.h (parse_completion): Don't declare.
5783         * d-exp.y: Update rules.
5784         (lex_one_token): Update rules.
5785         * c-exp.y: Update rules.
5786         (lex_one_token): Update.
5787         * ada-lang.c (resolve): Add "parse_completion" parameter.
5788         (resolve_subexp): Likewise.
5789         (ada_resolve_function): Likewise.
5790
5791 2019-04-04  Tom Tromey  <tom@tromey.com>
5792
5793         * parser-defs.h (struct parser_state) <start_arglist,
5794         end_arglist>: New methods.
5795         <arglist_len, m_funcall_chain>: New members.
5796         (arglist_len, start_arglist, end_arglist): Don't declare.
5797         * parse.c (arglist_len, funcall_chain): Remove global.
5798         (start_arglist, end_arglist): Remove functions.
5799         (parse_exp_in_context): Update.
5800         * p-exp.y: Update rules.
5801         * m2-exp.y: Update rules.
5802         * go-exp.y: Update rules.
5803         * f-exp.y: Update rules.
5804         * d-exp.y: Update rules.
5805         * c-exp.y: Update rules.
5806
5807 2019-04-04  Tom Tromey  <tom@tromey.com>
5808
5809         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5810         lex_operator, push_back>: New methods.
5811         Update all rules.
5812         (rust_parser::lex_hex, lex_escape): Rename and update.
5813         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5814         (rust_parser::lex_operator): Rename and update.
5815         (rust_parser::lex_number, rustyylex, rustyyerror)
5816         (rust_lex_test_init, rust_lex_test_sequence)
5817         (rust_lex_test_push_back, rust_lex_tests): Update.
5818         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5819         parameter.
5820         <lexptr, prev_lexptr>: New members.
5821         (lexptr, prev_lexptr): Don't declare.
5822         * parse.c (lexptr, prev_lexptr): Remove globals.
5823         (parse_exp_in_context): Update.
5824         * p-exp.y (yylex, yyerror): Update.
5825         * m2-exp.y (parse_number, yylex, yyerror): Update.
5826         * go-exp.y (lex_one_token, yyerror): Update.
5827         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5828         * d-exp.y (lex_one_token, yyerror): Update.
5829         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5830         (lex_one_token, yyerror): Update.
5831         * ada-lex.l (YY_INPUT): Update.
5832         (rewind_to_char): Update.
5833         * ada-exp.y (yyerror): Update.
5834
5835 2019-04-04  Tom Tromey  <tom@tromey.com>
5836
5837         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5838         * parser-defs.h (struct parser_state) <parser_state>: Add new
5839         parameter.
5840         <comma_terminates>: New member.
5841         (comma_terminates): Don't declare global.
5842         * parse.c (comma_terminates): Remove global.
5843         (parse_exp_in_context): Update.
5844         * p-exp.y (yylex): Update.
5845         * m2-exp.y (yylex): Update.
5846         * go-exp.y (lex_one_token): Update.
5847         * f-exp.y (yylex): Update.
5848         * d-exp.y (lex_one_token): Update.
5849         * c-exp.y (lex_one_token): Update.
5850         * ada-lex.l: Update.
5851
5852 2019-04-04  Tom Tromey  <tom@tromey.com>
5853
5854         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5855         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5856         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5857         * parser-defs.h (paren_depth): Don't declare.
5858         * parse.c (paren_depth): Remove global.
5859         (parse_exp_in_context): Update.
5860         * p-exp.y (paren_depth): New global.
5861         (pascal_parse): Initialize it.
5862         * m2-exp.y (paren_depth): New global.
5863         (m2_parse): Initialize it.
5864         * go-exp.y (paren_depth): New global.
5865         (go_parse): Initialize it.
5866         * f-exp.y (paren_depth): New global.
5867         (f_parse): Initialize it.
5868         * d-exp.y (paren_depth): New global.
5869         (d_parse): Initialize it.
5870         * c-exp.y (paren_depth): New global.
5871         (c_parse): Initialize it.
5872         * ada-lex.l (paren_depth): New global.
5873         (lexer_init): Initialize it.
5874
5875 2019-04-04  Tom Tromey  <tom@tromey.com>
5876
5877         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5878         (rust_parser::convert_ast_to_type)
5879         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5880         * parser-defs.h (struct parser_state) <parser_state>: Add
5881         parameters.  Initialize new members.
5882         <expression_context_block, expression_context_pc>: New members.
5883         * parse.c (expression_context_block, expression_context_pc):
5884         Remove globals.
5885         (parse_exp_in_context): Update.
5886         * p-exp.y: Update all rules.
5887         (yylex): Update.
5888         * m2-exp.y: Update all rules.
5889         (yylex): Update.
5890         * go-exp.y (yylex): Update.
5891         * f-exp.y (yylex): Update.
5892         * d-exp.y: Update all rules.
5893         (yylex): Update.
5894         * c-exp.y: Update all rules.
5895         (lex_one_token, classify_name, yylex, c_parse): Update.
5896         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5897
5898 2019-04-04  Tom Tromey  <tom@tromey.com>
5899
5900         * gdbarch.h, gdbarch.c: Rebuild.
5901         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5902         * stap-probe.h:
5903         (struct stap_parse_info): Replace "parser_state" with
5904         "expr_builder".
5905         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5906         (parser_state): New class.
5907         * parse.c (expr_builder): Rename.
5908         (expr_builder::release): Rename.
5909         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5910         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5911         (write_exp_elt_longcst, write_exp_elt_floatcst)
5912         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5913         (write_exp_string_vector, write_exp_bitstring)
5914         (write_exp_msymbol, mark_struct_expression)
5915         (write_dollar_variable)
5916         (insert_type_address_space, increase_expout_size): Replace
5917         "parser_state" with "expr_builder".
5918         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5919         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5920         "parser_state" with "expr_builder".
5921
5922 2019-04-04  Tom Tromey  <tom@tromey.com>
5923
5924         * rust-exp.y: Replace "parse_language" with method call.
5925         * p-exp.y:
5926         (yylex): Replace "parse_language" with method call.
5927         * m2-exp.y:
5928         (yylex): Replace "parse_language" with method call.
5929         * go-exp.y (classify_name): Replace "parse_language" with method
5930         call.
5931         * f-exp.y (yylex): Replace "parse_language" with method call.
5932         * d-exp.y (lex_one_token): Replace "parse_language" with method
5933         call.
5934         * c-exp.y:
5935         (lex_one_token, classify_name, yylex): Replace "parse_language"
5936         with method call.
5937         * ada-exp.y (find_primitive_type, type_char)
5938         (type_system_address): Replace "parse_language" with method call.
5939
5940 2019-04-04  Tom Tromey  <tom@tromey.com>
5941
5942         * rust-exp.y: Replace "parse_gdbarch" with method call.
5943         * parse.c (write_dollar_variable, insert_type_address_space):
5944         Replace "parse_gdbarch" with method call.
5945         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5946         call.
5947         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5948         call.
5949         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5950         "parse_gdbarch" with method call.
5951         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5952         with method call.
5953         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5954         "parse_gdbarch" with method call.
5955         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5956         "parse_gdbarch" with method call.
5957         * c-exp.y (parse_type, parse_number, classify_name): Replace
5958         "parse_gdbarch" with method call.
5959         * ada-lex.l: Replace "parse_gdbarch" with method call.
5960         * ada-exp.y (parse_type, find_primitive_type, type_char)
5961         (type_system_address): Replace "parse_gdbarch" with method call.
5962
5963 2019-04-04  Tom Tromey  <tom@tromey.com>
5964
5965         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5966         * stap-probe.c (stap_parse_argument): Update.
5967         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5968         initial_size parameter.
5969         * rust-exp.y (rust_lex_tests): Update.
5970         * parse.c (parser_state): Update.
5971         (parse_exp_in_context): Update.
5972         * parser-defs.h (struct parser_state) <parser_state>: Remove
5973         "initial_size" parameter.
5974
5975 2019-04-04  Tom Tromey  <tom@tromey.com>
5976
5977         * parser-defs.h (increase_expout_size): Don't declare.
5978         * parse.c (increase_expout_size): Now static.
5979
5980 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5981
5982         * gnu-nat.c (gnu_nat_target::wait): Fix
5983         target_waitstatus_to_string call.
5984
5985 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5986
5987         * eval.c (evaluate_subexp_standard): Handle internal functions
5988         during Fortran function call handling.
5989
5990 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5991
5992         * NEWS: Mention new internal functions.
5993         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5994         (read_base_type): Use dwarf2_init_complex_target_type.
5995         * value.c (creal_internal_fn): New function.
5996         (cimag_internal_fn): New function.
5997         (_initialize_values): Register new internal functions.
5998
5999 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6000
6001         * infrun.c (stop_all_threads): If debug_infrun, always
6002         trace the wait status after wait_one, using
6003         target_waitstatus_to_string and target_pid_to_str.
6004         (handle_inferior_event): Replace various trace of
6005         wait status kind by a single trace.
6006         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6007         wait status kind image by target_waitstatus_to_string.
6008         * target/waitstatus.c (target_waitstatus_to_string): Fix
6009         obsolete comment.
6010
6011 2019-04-01  Tom Tromey  <tromey@adacore.com>
6012
6013         PR symtab/23331:
6014         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6015
6016 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6017             Pedro Alves  <palves@redhat.com>
6018
6019         * top.c (quit_force): Call 'finalize_values'.
6020         * value.c (finalize_values): New function.
6021         * value.h (finalize_values): Declare.
6022
6023 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6024
6025         * NEWS: Announce $_gdb_major and $_gdb_minor.
6026
6027         * top.c (init_gdb_version_vars): New function.
6028         (gdb_init): Call init_gdb_version_vars.
6029
6030 2019-03-29  Tom Tromey  <tromey@adacore.com>
6031
6032         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6033         help text.  Remove dead code.
6034
6035 2019-03-29  Keith Seitz  <keiths@redhat.com>
6036
6037         From Siddhesh Poyarekar:
6038         * f-lang.h (f77_get_upperbound): Return LONGEST.
6039         (f77_get_lowerbound): Likewise.
6040         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6041         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6042         print them.
6043         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6044         plongest to format print it.
6045         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6046         (f77_get_upperbound): Likewise.
6047         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6048         LOWER_BOUND to LONGEST.
6049         (f77_create_arrayprint_offset_tbl): Likewise.
6050
6051 2019-03-29  Keith Seitz  <keiths@redhat.com>
6052
6053         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6054         %s/pulongest for TYPE_LENGTH instead of %d in format
6055         strings.
6056         * ada-typerint.c (ada_print_type): Likewise.
6057         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6058         * compile/compile-c-support.c (generate_register_struct): Likewise.
6059         * gdbtypes.c (recursive_dump_type): Likewise.
6060         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6061         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6062         instead of %d in format strings.
6063         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6064         to std::min to ULONGEST.
6065         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6066         instead of %d in format strings.
6067         * tracepoint.c (info_scope_command): Likewise.
6068         * typeprint.c (print_offset_data::update)
6069         (print_offset_data::finish): Likewise.
6070         * xtensa-tdep.c (xtensa_store_return_value)
6071         (xtensa_push_dummy_call): Likewise.
6072
6073 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6074
6075         * windows-nat.c (display_selector): Fixed format specifications
6076         for 64-bit Cygwin.
6077
6078 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6079
6080         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6081
6082 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6083
6084         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6085         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6086         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6087         (nios2_linux_init_abi): Install it.
6088
6089 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6090
6091         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6092
6093 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6094
6095         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6096
6097 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6098             Tom Tromey  <tromey@adacore.com>
6099
6100         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6101
6102 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6103
6104         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6105         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6106         method to compute the bounds of range types. Also print "[evaluated]"
6107         if the bounds' values come from a dynamic evaluation.
6108
6109 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6110
6111         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6112         whitespace when pretty printing is on.
6113
6114 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6115
6116         * ppc-linux-nat.c: Add include.
6117
6118 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6119
6120         * NEWS: Mention AArch64 Pointer Authentication.
6121
6122 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6123
6124         * arm-linux-nat.c: Add include.
6125
6126 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6127
6128         * source-cache.c (source_cache::get_source_lines): Re-read
6129         fullname after calling open_source_file.
6130
6131 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6132
6133         * NEWS: Mention TLS support for FreeBSD.
6134
6135 2019-03-25  Tom Tromey  <tromey@adacore.com>
6136
6137         * minsyms.c (BUNCH_SIZE): Update comment.
6138         (~minimal_symbol_reader): Remove old comment.
6139         (compact_minimal_symbols): Update comment.
6140         (minimal_symbol_reader::install): Remove old comment.  Update
6141         other comments.
6142
6143 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6144
6145         * s390-linux-nat.c: Add include.
6146
6147 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6148
6149         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6150         Call linux_get_hwcap.
6151         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6152         Likewise.
6153         (aarch64_linux_get_hwcap): Remove function.
6154         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6155         declaration.
6156         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6157         linux_get_hwcap.
6158         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6159         * linux-tdep.c (linux_get_hwcap): Add function.
6160         (linux_get_hwcap2): Likewise.
6161         * linux-tdep.h (linux_get_hwcap): Add declaration.
6162         (linux_get_hwcap2): Likewise.
6163         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6164         (ppc_linux_get_hwcap2): Likewise.
6165         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6166         linux_get_hwcap.
6167         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6168         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6169         (ppc_linux_nat_target::read_description): Likewise.
6170         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6171         * s390-linux-nat.c: Likewise.
6172         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6173
6174 2019-03-24  Tom Tromey  <tom@tromey.com>
6175
6176         * ada-lang.c (standard_lookup): Simplify initialization.
6177         (ada_lookup_symbol_nonlocal): Simplify return.
6178         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6179         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6180         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6181         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6182         initialization.
6183         * solib.c (solib_global_lookup): Simplify.
6184         * symtab.c (null_block_symbol): Remove.
6185         (symbol_cache_lookup): Simplify returns.
6186         (lookup_language_this): Simplify returns.
6187         (lookup_symbol_aux): Simplify return.
6188         (lookup_local_symbol): Simplify returns.
6189         (lookup_global_symbol_from_objfile): Simplify return.
6190         (lookup_symbol_in_objfile_symtabs)
6191         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6192         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6193         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6194         * cp-namespace.c (cp_lookup_bare_symbol)
6195         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6196         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6197         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6198         (cp_lookup_symbol_via_imports): Simplify initialization.
6199         (find_symbol_in_baseclass): Likewise.
6200         * symtab.h (null_block_symbol): Remove.
6201         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6202         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6203         (d_lookup_symbol_module): Likewise.
6204         (find_symbol_in_baseclass): Simplify initialization.
6205
6206 2019-03-24  Tom Tromey  <tom@tromey.com>
6207
6208         * expression.h: Don't include symtab.h.
6209         (struct block): Forward declare.
6210
6211 2019-03-24  Tom Tromey  <tom@tromey.com>
6212
6213         * c-exp.y (typebase): Remove casts.
6214         * gdbtypes.c (lookup_unsigned_typename, )
6215         (lookup_signed_typename): Remove cast.
6216         * eval.c (parse_to_comma_and_eval): Remove cast.
6217         * parse.c (write_dollar_variable): Remove cast.
6218         * block.h (struct block) <superblock>: Now const.
6219         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6220         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6221         (map_block): Make "block" const.
6222         * symfile.h (struct quick_symbol_functions)
6223         <map_matching_symbols>: Constify block argument to "callback".
6224         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6225         const.
6226         (find_pc_sect_compunit_symtab): Make "b" const.
6227         (find_symbol_at_address): Likewise.
6228         (search_symbols): Likewise.
6229         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6230         (dw2_debug_names_lookup_symbol): Likewise.
6231         (dw2_map_matching_symbols): Update.
6232         * p-valprint.c (pascal_val_print): Remove "block".
6233         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6234         (aux_add_nonlocal_symbols): Make "block" const.
6235         (resolve_subexp): Remove cast.
6236         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6237         const.
6238         (iterate_over_file_blocks): Likewise.
6239         * f-exp.y (%union) <bval>: Remove.
6240         * coffread.c (patch_opaque_types): Make "b" const.
6241         * spu-tdep.c (spu_catch_start): Make "block" const.
6242         * c-valprint.c (print_unpacked_pointer): Remove "block".
6243         * symmisc.c (dump_symtab_1): Make "b" const.
6244         (block_depth): Make "block" const.
6245         * d-exp.y (%union) <bval>: Remove.
6246         * cp-support.h (cp_lookup_rtti_type): Update.
6247         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6248         * psymtab.c (psym_lookup_symbol): Make "block" const.
6249         (maintenance_check_psymtabs): Make "b" const.
6250         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6251         (enumerate_locals, enumerate_args): Update.
6252         * python/py-symtab.c (stpy_global_block): Make "block" const.
6253         (stpy_static_block): Likewise.
6254         * inline-frame.c (block_starting_point_at): Make "new_block"
6255         const.
6256         * block.c (find_block_in_blockvector): Make return type const.
6257         (blockvector_for_pc_sect): Make "b" const.
6258         (find_block_in_blockvector): Make "b" const.
6259
6260 2019-03-23  Tom Tromey  <tom@tromey.com>
6261
6262         * varobj.c (varobj_create): Update.
6263         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6264         * printcmd.c (display_command, do_one_display): Don't reset
6265         innermost_block.
6266         * parser-defs.h (enum innermost_block_tracker_type): Move to
6267         expression.h.
6268         (innermost_block): Update comment.
6269         * parse.c (parse_exp_1): Add tracker_types parameter.
6270         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6271         tracker_types parameter.  Reset innermost_block.
6272         (parse_exp_in_context): Remove.
6273         (parse_expression_for_completion): Update.
6274         * objfiles.c (~objfile): Don't reset expression_context_block or
6275         innermost_block.
6276         * expression.h (enum innermost_block_tracker_type): Move from
6277         parser-defs.h.
6278         (parse_exp_1): Add tracker_types parameter.
6279         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6280         reset innermost_block.
6281
6282 2019-03-23  Tom Tromey  <tom@tromey.com>
6283
6284         * objfiles.h: Include bcache.h.
6285
6286 2019-03-23  Tom Tromey  <tom@tromey.com>
6287
6288         * linespec.c (get_current_search_block): Use
6289         scoped_restore_current_language.
6290         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6291
6292 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6293             Jiong Wang  <jiong.wang@arm.com>
6294
6295         * aarch64-linux-tdep.c
6296         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6297         section.
6298         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6299
6300 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6301             Jiong Wang  <jiong.wang@arm.com>
6302
6303         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6304         instructions.
6305         (aarch64_analyze_prologue_test): Add PACIASP test.
6306         (aarch64_prologue_prev_register): Unmask PC value.
6307
6308 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6309             Jiong Wang  <jiong.wang@arm.com>
6310
6311         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6312         (aarch64_dwarf2_prev_register): Unmask PC value.
6313         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6314         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6315         DW_CFA_AARCH64_negate_ra_state.
6316         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6317
6318 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6319             Jiong Wang  <jiong.wang@arm.com>
6320
6321         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6322         registers.
6323         (aarch64_pseudo_register_name): Likewise.
6324         (aarch64_pseudo_register_type): Likewise.
6325         (aarch64_pseudo_register_reggroup_p): Likewise.
6326         (aarch64_gdbarch_init): Add pauth registers.
6327         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6328         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6329         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6330         (struct gdbarch_tdep): Add regnum for ra_state.
6331
6332 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6333             Jiong Wang  <jiong.wang@arm.com>
6334
6335         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6336
6337 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6338             Jiong Wang  <jiong.wang@arm.com>
6339
6340         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6341         function.
6342         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6343         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6344         (aarch64_gdbarch_init): Add puth registers.
6345         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6346         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6347         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6348
6349 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6350             Jiong Wang  <jiong.wang@arm.com>
6351
6352         * aarch64-linux-nat.c
6353         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6354         * aarch64-linux-tdep.c
6355         (aarch64_linux_core_read_description): Likewise.
6356         (aarch64_linux_get_hwcap): New function.
6357         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6358         (aarch64_linux_get_hwcap): New declaration.
6359
6360 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6361             Jiong Wang  <jiong.wang@arm.com>
6362
6363         * aarch64-linux-nat.c
6364         (aarch64_linux_nat_target::read_description): Add pauth param.
6365         * aarch64-linux-tdep.c
6366         (aarch64_linux_core_read_description): Likewise.
6367         * aarch64-tdep.c (struct target_desc): Add in pauth.
6368         (aarch64_read_description): Add pauth param.
6369         (aarch64_gdbarch_init): Likewise.
6370         * aarch64-tdep.h (aarch64_read_description): Likewise.
6371         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6372         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6373         * features/Makefile: Add new files.
6374         * features/aarch64-pauth.c: New file.
6375         * features/aarch64-pauth.xml: New file.
6376
6377 2019-03-20  Tom Tromey  <tromey@adacore.com>
6378
6379         * infrun.c (handle_inferior_event): Rename from
6380         handle_inferior_event_1.  Create a scoped_value_mark.
6381         (handle_inferior_event): Remove.
6382
6383 2019-03-19  Tom Tromey  <tromey@adacore.com>
6384
6385         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6386         * infrun.h (print_stop_event): Add "displays" parameter.
6387         * infrun.c (print_stop_event): Add "displays" parameter.
6388
6389 2019-03-19  Pedro Alves  <palves@redhat.com>
6390
6391         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6392         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6393         to -1.  Fix TABs vs spaces.
6394         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6395         * tui/tui-out.h (tui_ui_out) Add intro comments.
6396         <m_line, m_start_of_line>: In-class initialize, and add describing
6397         comment.
6398
6399 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6400
6401         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6402         variable names.
6403         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6404
6405 2019-03-18  Pedro Alves  <palves@redhat.com>
6406             Eli Zaretskii <eliz@gnu.org>
6407
6408         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6409         m_line and m_start_of_line.
6410
6411 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6412
6413         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6414         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6415         it returns a newline.  This fixes a regression in TU mode, whereby
6416         the next line is output on the same screen line as the user input.
6417
6418 2019-03-18  Tom Tromey  <tromey@adacore.com>
6419
6420         * minsyms.c (minimal_symbol_reader::install): Remove call to
6421         obstack_blank.
6422
6423 2019-03-18  Pedro Alves  <palves@redhat.com>
6424
6425         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6426         New globals.
6427         (apply_style): New, factored out from ...
6428         (apply_ansi_escape): ... this.  Handle reverse video mode.
6429         (tui_set_reverse_mode): New function.
6430         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6431         * tui/tui-winsource.c (tui_show_source_line): Use
6432         tui_set_reverse_mode instead of setting A_STANDOUT.
6433         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6434         New setter methods.
6435
6436 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6437
6438         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6439         Handle tabs.
6440
6441 2019-03-18  Tom Tromey  <tromey@adacore.com>
6442
6443         * ada-lang.c (empty_array): Add "high" parameter.
6444         (ada_evaluate_subexp): Update.
6445
6446 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6447
6448         * unittests/string_view-selftests.c: Define
6449         _initialize_string_view_selftests unconditionally.
6450
6451 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6452
6453         PR gdb/24350
6454         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6455
6456 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6457
6458         PR gdb/24351
6459         * windows-nat.c (display_selector): Fix format specifiers.
6460
6461 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6462
6463         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6464         tui_refill_source_window instead of tui_refresh_win, to update the
6465         current execution line.  This fixes redisplay of the current line
6466         when stepping through the code with "next" or "step".
6467
6468 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6469
6470         * source-cache.c (source_cache::get_source_lines): Call
6471         find_source_lines to initialize s->nlines.  This fixes vertical
6472         scrolling of TUI source window when the DOWN arrow is pressed.
6473
6474 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6475
6476         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6477         linux-thread-db.c (_initialize_thread_db): Likewise.
6478
6479 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6480
6481         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6482         wclrtoeol in tui_show_source_line".  This reverts changes made in
6483         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6484
6485 2019-03-15  Tom Tromey  <tom@tromey.com>
6486
6487         * symtab.h (struct minimal_symbol): Derive from
6488         general_symbol_info.
6489         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6490         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6491         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6492         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6493         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6494         (MSYMBOL_SEARCH_NAME): Update.
6495         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6496         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6497         * minsyms.c (minimal_symbol_reader::record_full): Update.
6498
6499 2019-03-15  Tom Tromey  <tom@tromey.com>
6500
6501         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6502
6503 2019-03-15  Tom Tromey  <tom@tromey.com>
6504
6505         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6506         unique_xmalloc_ptr.
6507         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6508         Update.
6509         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6510         (build_minimal_symbol_hash_tables)
6511         (minimal_symbol_reader::install): Update.
6512
6513 2019-03-15  Tom Tromey  <tom@tromey.com>
6514
6515         * symtab.c (create_demangled_names_hash): Update.
6516         (symbol_set_names): Update.
6517         * objfiles.h (struct objfile_per_bfd_storage)
6518         <demangled_names_hash>: Now an htab_up.
6519         * objfiles.c (objfile_per_bfd_storage): Simplify.
6520
6521 2019-03-15  Tom Tromey  <tom@tromey.com>
6522
6523         * objfiles.h (struct objfile_per_bfd_storage): Declare
6524         destructor.
6525         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6526         New.
6527         (get_objfile_bfd_data): Use new.  Don't initialize
6528         language_of_main.
6529         (free_objfile_per_bfd_storage): Remove.
6530         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6531
6532 2019-03-15  Tom Tromey  <tom@tromey.com>
6533
6534         * symfile.c (reread_symbols): Update.
6535         * objfiles.c (objfile::objfile): Update.
6536         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6537         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6538         comment.
6539         (minimal_symbol_reader::install): Update.
6540         (terminate_minimal_symbol_table): Remove.
6541         * jit.c (jit_object_close_impl): Update.
6542
6543 2019-03-15  Tom Tromey  <tom@tromey.com>
6544
6545         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6546         initializations.
6547
6548 2019-03-15  Tom Tromey  <tom@tromey.com>
6549
6550         * objfiles.h (struct objfile_per_bfd_storage)
6551         <demangled_hash_languages>: Now a bitset.
6552         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6553         (lookup_minimal_symbol): Update.
6554
6555 2019-03-15  Tom Tromey  <tom@tromey.com>
6556
6557         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6558         Don't return the symbol.
6559         * coffread.c (record_minimal_symbol): Use record_full.
6560
6561 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6562
6563         The MS-Windows port of ncurses fails to switch to a color pair if
6564         one or both of the colors are the implicit default colors.  This
6565         change records the default colors when TUI is initialized, and
6566         then specifies them explicitly when a color pair uses the default
6567         colors.  This allows color styling in TUI mode on MS-Windows.
6568
6569         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6570         ncurses_norm_attr.
6571         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6572         colors in ncurses_norm_attr.
6573         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6574         "none", replace it with the default color recorded in
6575         ncurses_norm_attr.
6576
6577 2019-03-14  Tom Tromey  <tromey@adacore.com>
6578
6579         * source-cache.h (class source_cache) <get_source_lines>: Return
6580         std::string.
6581         * source-cache.c (source_cache::extract_lines): Handle case where
6582         first_pos==npos.  Return std::string.
6583         (source_cache::get_source_lines): Update.
6584
6585 2019-03-14  Tom Tromey  <tromey@adacore.com>
6586
6587         * NEWS: Add item for "style sources" commands.
6588         * source-cache.c (source_cache::get_source_lines): Check
6589         source_styling.
6590         * cli/cli-style.c (source_styling): New global.
6591         (_initialize_cli_style): Add "style sources" commands.
6592         (show_style_sources): New function.
6593         * cli/cli-style.h (source_styling): Declare.
6594
6595 2019-03-14  Pedro Alves  <palves@redhat.com>
6596             Tom Tromey  <tromey@adacore.com>
6597
6598         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6599         * tui/tui-winsource.c (tui_refill_source_window): New function,
6600         from...
6601         (tui_horizontal_source_scroll): ... here.  Move some logic.
6602         * cli/cli-style.c (set_style_enabled): Notify new observable.
6603         * tui/tui-hooks.c (tui_redisplay_source): New function.
6604         (tui_attach_detach_observers): Attach or detach
6605         tui_redisplay_source.
6606         * observable.h (source_styling_changed): New observable.
6607         * observable.c: Define source_styling_changed observable.
6608
6609 2019-03-13  Tom Tromey  <tromey@adacore.com>
6610
6611         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6612         (i386_gnu_nat_target::store_registers): Update.
6613         * target-debug.h (target_debug_print_std_string): New macro.
6614         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6615         * windows-tdep.c (display_one_tib): Update.
6616         * tui/tui-stack.c (tui_make_status_line): Update.
6617         * top.c (print_inferior_quit_action): Update.
6618         * thread.c (thr_try_catch_cmd): Update.
6619         (add_thread_with_info): Update.
6620         (thread_target_id_str): Update.
6621         (thr_try_catch_cmd): Update.
6622         (thread_command): Update.
6623         (thread_find_command): Update.
6624         * record-btrace.c (record_btrace_target::info_record)
6625         (record_btrace_resume_thread, record_btrace_target::resume)
6626         (record_btrace_cancel_resume, record_btrace_step_thread)
6627         (record_btrace_target::wait, record_btrace_target::wait)
6628         (record_btrace_target::wait, record_btrace_target::stop): Update.
6629         * progspace.c (print_program_space): Update.
6630         * process-stratum-target.c
6631         (process_stratum_target::thread_address_space): Update.
6632         * linux-fork.c (linux_fork_mourn_inferior)
6633         (detach_checkpoint_command, info_checkpoints_command)
6634         (linux_fork_context): Update.
6635         (linux_fork_detach): Update.
6636         (class scoped_switch_fork_info): Update.
6637         (delete_checkpoint_command): Update.
6638         * infrun.c (follow_fork_inferior): Update.
6639         (follow_fork_inferior): Update.
6640         (proceed_after_vfork_done): Update.
6641         (handle_vfork_child_exec_or_exit): Update.
6642         (follow_exec): Update.
6643         (displaced_step_prepare_throw): Update.
6644         (displaced_step_restore): Update.
6645         (start_step_over): Update.
6646         (resume_1): Update.
6647         (clear_proceed_status_thread): Update.
6648         (proceed): Update.
6649         (print_target_wait_results): Update.
6650         (do_target_wait): Update.
6651         (context_switch): Update.
6652         (stop_all_threads): Update.
6653         (restart_threads): Update.
6654         (finish_step_over): Update.
6655         (handle_signal_stop): Update.
6656         (switch_back_to_stepped_thread): Update.
6657         (keep_going_pass_signal): Update.
6658         (print_exited_reason): Update.
6659         (normal_stop): Update.
6660         * inferior.c (inferior_pid_to_str): Change return type.
6661         (print_selected_inferior): Update.
6662         (add_inferior): Update.
6663         (detach_inferior): Update.
6664         * dummy-frame.c (fprint_dummy_frames): Update.
6665         * dcache.c (dcache_info_1): Update.
6666         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6667         (btrace_fetch, btrace_clear): Update.
6668         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6669         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6670         type.
6671         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6672         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6673         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6674         * gdbarch.c, gdbarch.h: Rebuild.
6675         * gdbarch.sh (core_pid_to_str): Change return type.
6676         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6677         return type.
6678         (windows_nat_target::pid_to_str): Change return type.
6679         (windows_delete_thread): Update.
6680         (windows_nat_target::attach): Update.
6681         (windows_nat_target::files_info): Update.
6682         * target-delegates.c: Rebuild.
6683         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6684         return type.
6685         (sol_thread_target::pid_to_str): Change return type.
6686         * remote.c (class remote_target) <pid_to_str>: Change return
6687         type.
6688         (remote_target::pid_to_str): Change return type.
6689         (extended_remote_target::attach, remote_target::remote_stop_ns)
6690         (remote_target::remote_notif_remove_queued_reply)
6691         (remote_target::push_stop_reply, remote_target::disable_btrace):
6692         Update.
6693         (extended_remote_target::attach): Update.
6694         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6695         type.
6696         (gdbsim_target::pid_to_str): Change return type.
6697         * ravenscar-thread.c (struct ravenscar_thread_target)
6698         <pid_to_str>: Change return type.
6699         (ravenscar_thread_target::pid_to_str): Change return type.
6700         * procfs.c (class procfs_target) <pid_to_str>: Change return
6701         type.
6702         (procfs_target::pid_to_str): Change return type.
6703         (procfs_target::attach): Update.
6704         (procfs_target::detach): Update.
6705         (procfs_target::fetch_registers): Update.
6706         (procfs_target::store_registers): Update.
6707         (procfs_target::wait): Update.
6708         (procfs_target::files_info): Update.
6709         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6710         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6711         return type.
6712         (nto_procfs_target::pid_to_str): Change return type.
6713         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6714         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6715         return type.
6716         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6717         (exit_lwp): Update.
6718         (attach_proc_task_lwp_callback, get_detach_signal)
6719         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6720         (linux_nat_target::resume, wait_lwp, stop_callback)
6721         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6722         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6723         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6724         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6725         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6726         type.
6727         (inf_ptrace_target::attach): Update.
6728         (inf_ptrace_target::files_info): Update.
6729         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6730         type.
6731         (go32_nat_target::pid_to_str): Change return type.
6732         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6733         (gnu_nat_target::wait): Update.
6734         (gnu_nat_target::wait): Update.
6735         (gnu_nat_target::resume): Update.
6736         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6737         (fbsd_nat_target::wait): Update.
6738         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6739         type.
6740         (darwin_nat_target::attach): Update.
6741         * corelow.c (class core_target) <pid_to_str>: Change return type.
6742         (core_target::pid_to_str): Change return type.
6743         * target.c (normal_pid_to_str): Change return type.
6744         (default_pid_to_str): Likewise.
6745         (target_pid_to_str): Change return type.
6746         (target_translate_tls_address): Update.
6747         (target_announce_detach): Update.
6748         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6749         return type.
6750         (bsd_uthread_target::pid_to_str): Change return type.
6751         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6752         type.
6753         (bsd_kvm_target::pid_to_str): Change return type.
6754         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6755         return type.
6756         (aix_thread_target::pid_to_str): Change return type.
6757         * target.h (struct target_ops) <pid_to_str>: Change return type.
6758         (target_pid_to_str, normal_pid_to_str): Likewise.
6759         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6760         type.
6761         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6762         type.
6763         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6764         return type.
6765         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6766         type.
6767         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6768         type.
6769         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6770         return type.
6771
6772 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6773
6774         * NEWS: Mention that the new default MI version is 3.  Mention
6775         changes to the output of commands and events that deal with
6776         multi-location breakpoints.
6777         * breakpoint.c: Include "mi/mi-out.h".
6778         (print_one_breakpoint): Change output syntax if using MI version
6779         >= 3.
6780         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6781         New.
6782         (mi_multi_location_breakpoint_output_fixed): New.
6783         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6784         (mi_cmd_fix_multi_location_breakpoint_output): New.
6785         (mi_multi_location_breakpoint_output_fixed): New.
6786         * mi/mi-cmds.c (mi_cmds): Register command
6787         -fix-multi-location-breakpoint-output.
6788         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6789         interpreter "mi".
6790
6791 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6792
6793         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6794         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6795         instantiate mi_ui_out based on interpreter name.
6796         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6797         * mi/mi-main.c (mi_load_progress): Likewise.
6798
6799 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6800
6801         * NEWS: Combine separate "New targets" sections for 8.3.
6802
6803 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6804
6805         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6806         (ppcfbsd_init_abi): Install gdbarch
6807         "fetch_tls_load_module_address" and "get_thread_local_address"
6808         methods.
6809
6810 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6811
6812         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6813         (riscv_fbsd_init_abi): Install gdbarch
6814         "fetch_tls_load_module_address" and "get_thread_local_address"
6815         methods.
6816
6817 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6818
6819         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6820         (i386fbsd_init_abi): Install gdbarch
6821         "fetch_tls_load_module_address" and "get_thread_local_address"
6822         methods.
6823
6824 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6825
6826         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6827         (amd64fbsd_init_abi): Install gdbarch
6828         "fetch_tls_load_module_address" and "get_thread_local_address"
6829         methods.
6830
6831 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6832
6833         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6834         (struct fbsd_pspace_data): New type.
6835         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6836         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6837         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6838         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6839         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6840
6841 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6842
6843         * gdbtypes.c (lookup_struct_elt): New function.
6844         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6845         * gdbtypes.h (struct struct_elt): New type.
6846         (lookup_struct_elt): New prototype.
6847
6848 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6849
6850         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6851         remove disabled code block.
6852
6853 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6854
6855         * gdbarch.sh (get_thread_local_address): New method.
6856         * gdbarch.h, gdbarch.c: Regenerate.
6857         * target.c (target_translate_tls_address): Use
6858         gdbarch_get_thread_local_address if present instead of
6859         target::get_thread_local_address.
6860
6861 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6862
6863         * target.h (target::get_thread_local_address): Update comment.
6864
6865 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6866
6867         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6868         objfile->separate_debug_objfile_backlink if not NULL.
6869
6870 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6871
6872         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6873         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6874         (amd64bsd_store_inferior_registers): Likewise.
6875         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6876         Enable segment base registers.
6877         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6878         PT_GETFSBASE and PT_GETGSBASE.
6879         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6880         PT_SETGSBASE.
6881         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6882         segment base registers.
6883         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6884
6885 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6886
6887         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6888         Update calls to i386_target_description to add 'segments'
6889         parameter.
6890         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6891         add segment base registers.
6892         * arch/i386.c (i386_create_target_description): Add 'segments'
6893         parameter to enable segment base registers.
6894         * arch/i386.h (i386_create_target_description): Likewise.
6895         * features/i386/32bit-segments.xml: New file.
6896         * features/i386/32bit-segments.c: Generate.
6897         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6898         call to i386_target_description to add 'segments' parameter.
6899         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6900         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6901         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6902         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6903         if feature is present.
6904         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6905         Add 'segments' parameter to call to i386_target_description.
6906         (i386_target_description): Add 'segments' parameter to enable
6907         segment base registers.
6908         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6909         to call to i386_target_description.
6910         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6911         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6912         Define I386_NUM_REGS.
6913         (i386_target_description): Add 'segments' parameter to enable
6914         segment base registers.
6915
6916 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6917
6918         PR/24325
6919         * source-cache.c: #undef open and close, to avoid unresolved
6920         externals during linking.
6921
6922 2019-03-12  Tom Tromey  <tromey@adacore.com>
6923
6924         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6925         const.  Add initializers.
6926         (_initialize_remote): Don't initialize ptid globals.
6927
6928 2019-03-12  Pedro Alves  <palves@redhat.com>
6929
6930         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6931
6932 2019-03-12  Pedro Alves  <palves@redhat.com>
6933
6934         * cp-name-parser.y (main): Remove unused 'len' variable.
6935
6936 2019-03-12  Tom Tromey  <tromey@adacore.com>
6937
6938         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6939         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6940
6941 2019-03-12  Tom Tromey  <tromey@adacore.com>
6942
6943         * linux-nat.c (iterate_over_lwps): Update.
6944         (stop_callback): Remove parameter.
6945         (stop_wait_callback, detach_callback, resume_set_callback)
6946         (select_singlestep_lwp_callback, set_ignore_sigint)
6947         (status_callback, resumed_callback, resume_clear_callback)
6948         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6949         data parameter.
6950         (linux_nat_target::detach, linux_nat_target::resume)
6951         (linux_stop_and_wait_all_lwps, select_event_lwp)
6952         (linux_nat_filter_event, linux_nat_wait_1)
6953         (linux_nat_target::kill, linux_nat_target::stop)
6954         (linux_nat_target::stop): Update.
6955         (linux_nat_resume_callback): Change type.
6956         (resume_stopped_resumed_lwps, count_events_callback)
6957         (select_event_lwp_callback): Likewise.
6958         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6959         * arm-linux-nat.c (struct update_registers_data): Remove.
6960         (update_registers_callback): Change type.
6961         (arm_linux_insert_hw_breakpoint1): Update.
6962         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6963         parameter.
6964         (x86_linux_dr_set_addr): Update.
6965         (x86_linux_dr_set_control): Update.
6966         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6967         (iterate_over_lwps): Use gdb::function_view.
6968         * nat/aarch64-linux-hw-point.c (struct
6969         aarch64_dr_update_callback_param): Remove.
6970         (debug_reg_change_callback): Change type.
6971         (aarch64_notify_debug_reg_change): Update.
6972         * s390-linux-nat.c (s390_refresh_per_info): Update.
6973
6974 2019-03-11  Tom Tromey  <tromey@adacore.com>
6975
6976         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6977         redundant assignment to "this_cu".
6978
6979 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6980
6981         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6982
6983 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6984
6985         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6986         from...
6987         (rank_one_type): ... this.
6988
6989 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6990
6991         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6992         from...
6993         (rank_one_type): ... this.
6994
6995 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6996
6997         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6998         from...
6999         (rank_one_type): ... this.
7000
7001 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7002
7003         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7004         from...
7005         (rank_one_type): ... this.
7006
7007 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7008
7009         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7010         from...
7011         (rank_one_type): ... this.
7012
7013 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7014
7015         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7016         from...
7017         (rank_one_type): ... this.
7018
7019 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7020
7021         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7022         from...
7023         (rank_one_type): ... this.
7024
7025 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7026
7027         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7028         from...
7029         (rank_one_type): ... this.
7030
7031 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7032
7033         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7034         from...
7035         (rank_one_type): ... this.
7036
7037 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7038
7039         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7040         from...
7041         (rank_one_type): ... this.
7042
7043 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7044
7045         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7046         from...
7047         (rank_one_type): ... this.
7048
7049 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7050
7051         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7052         from...
7053         (rank_one_type): ... this.
7054
7055 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7056
7057         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7058         inferior-events' shows the example events.
7059
7060 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7061
7062         Support styling on native MS-Windows console
7063
7064         PR/24315
7065         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7066         on MS-Windows if $TERM is not defined.
7067
7068         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7069
7070         * posix-hdep.c (gdb_console_fputs):
7071         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7072         functions.
7073         * ui-file.h (gdb_console_fputs): Add prototype.
7074
7075         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7076         back to fputs only if the former returns zero.
7077
7078 2019-03-07  Tom Tromey  <tom@tromey.com>
7079
7080         * symmisc.c (print_symbol_bcache_statistics): Update.
7081         (print_objfile_statistics): Update.
7082         * symfile.c (allocate_symtab): Update.
7083         * stabsread.c: Don't include bcache.h.
7084         * psymtab.h (struct psymbol_bcache): Don't declare.
7085         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7086         (psymbol_bcache_init, psymbol_bcache_free)
7087         (psymbol_bcache_get_bcache): Don't declare.
7088         * psymtab.c (struct psymbol_bcache): Remove.
7089         (psymtab_storage::psymtab_storage): Update.
7090         (psymtab_storage::~psymtab_storage): Update.
7091         (psymbol_bcache_init, psymbol_bcache_free)
7092         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7093         (add_psymbol_to_bcache): Update.
7094         (allocate_psymtab): Update.
7095         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7096         macro_cache>: No longer pointers.
7097         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7098         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7099         * macrotab.c (macro_bcache): Update.
7100         * macroexp.c: Don't include bcache.h.
7101         * gdbtypes.c (check_types_worklist): Update.
7102         (types_deeply_equal): Remove TRY/CATCH.  Update.
7103         * elfread.c (elf_symtab_read): Update.
7104         * dwarf2read.c: Don't include bcache.h.
7105         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7106         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7107         (print_bcache_statistics, bcache_memory_used): Don't declare.
7108         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7109         methods.  Rename all data members.
7110         * bcache.c (struct bcache): Move to bcache.h.
7111         (bcache::expand_hash_table): Rename from expand_hash_table.
7112         (bcache): Remove.
7113         (bcache::insert): Rename from bcache_full.
7114         (bcache::compare): Rename from bcache_compare.
7115         (bcache_xmalloc): Remove.
7116         (bcache::~bcache): Rename from bcache_xfree.
7117         (bcache::print_statistics): Rename from print_bcache_statistics.
7118         (bcache::memory_used): Rename from bcache_memory_used.
7119
7120 2019-03-07  Pedro Alves  <palves@redhat.com>
7121
7122         * infrun.c (normal_stop): Also check for
7123         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7124
7125 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7126
7127         * f-lang.c (value_from_host_double): Moved to...
7128         * value.c (value_from_host_double): ...here.
7129         * value.h (value_from_host_double): Declare.
7130         * guile/scm-math.c (vlscm_convert_typed_number): Use
7131         value_from_host_double.
7132         (vlscm_convert_number): Likewise.
7133         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7134         * python/py-value.c (convert_value_from_python): Likewise.
7135
7136 2019-03-06  Tom Tromey  <tom@tromey.com>
7137
7138         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7139
7140 2019-03-06  Tom Tromey  <tom@tromey.com>
7141
7142         * utils.h (free_current_contents): Don't declare.
7143         * utils.c (free_current_contents): Remove.
7144
7145 2019-03-06  Tom Tromey  <tom@tromey.com>
7146
7147         * top.c (quit_force): Update.
7148         * main.c (captured_command_loop): Update.
7149         * common/new-op.c (operator new): Update.
7150         * common/common-exceptions.c (struct catcher)
7151         <save_cleanup_chain>: Remove member.
7152         (exceptions_state_mc_init): Update.
7153         (exception_try_scope_entry): Return nullptr.
7154         (exception_try_scope_exit, exception_rethrow)
7155         (throw_exception_sjlj, throw_exception_cxx): Update.
7156         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7157         (all_cleanups, do_cleanups, discard_cleanups)
7158         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7159         (restore_cleanups, restore_final_cleanups): Don't declare.
7160         (do_final_cleanups): Remove parameter.
7161         * common/cleanups.c (cleanup_chain, make_cleanup)
7162         (make_cleanup_dtor, all_cleanups, do_cleanups)
7163         (discard_my_cleanups, discard_cleanups)
7164         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7165         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7166         (null_cleanup): Remove.
7167         (do_final_cleanups): Remove parameter.
7168
7169 2019-03-06  Tom Tromey  <tom@tromey.com>
7170
7171         * remote.c (remote_target::remote_parse_stop_reply): Use
7172         unique_xmalloc_ptr.
7173
7174 2019-03-06  Tom Tromey  <tom@tromey.com>
7175
7176         * stabsread.c (struct stabs_field_info): Rename from field_info.
7177         <list, fnlist>: Add initializers.
7178         <obstack>: New member.
7179         (read_member_functions, read_struct_fields, read_baseclasses):
7180         Allocate on obstack.  Don't use cleanups.
7181         (read_one_struct_field, read_member_functions, read_struct_fields)
7182         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7183         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7184         (read_struct_type): Update.
7185
7186 2019-03-06  Tom Tromey  <tom@tromey.com>
7187
7188         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7189         * common/filestuff.h (make_cleanup_close): Don't declare.
7190         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7191         Remove.
7192
7193 2019-03-06  Tom Tromey  <tom@tromey.com>
7194
7195         * solib-aix.c: Use make_scope_exit.
7196
7197 2019-03-06  Tom Tromey  <tom@tromey.com>
7198
7199         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7200         Use make_scope_exit.
7201
7202 2019-03-06  Tom Tromey  <tom@tromey.com>
7203
7204         * solib-svr4.c (disable_probes_interface): Remove parameter.
7205         (svr4_handle_solib_event): Use make_scope_exit.
7206
7207 2019-03-06  Tom Tromey  <tom@tromey.com>
7208
7209         * remote.c (struct stop_reply_deleter): Remove.
7210         (stop_reply_up): Update.
7211         (struct stop_reply): Derive from notif_event.  Don't typedef.
7212         <regcache>: Now a std::vector.
7213         (stop_reply_xfree): Remove.
7214         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7215         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7216         (remote_target::discard_pending_stop_replies): Use delete.
7217         (remote_target::remote_parse_stop_reply): Update.
7218         (remote_target::process_stop_reply): Update.
7219         * remote-notif.h (struct notif_event): Add virtual destructor.
7220         Remove "dtr" member.
7221         (struct notif_client) <alloc_event>: Return a unique_ptr.
7222         (notif_event_xfree): Don't declare.
7223         (notif_event_up): New typedef.
7224         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7225         (notif_event_xfree, do_notif_event_xfree): Remove.
7226         (remote_notif_state_xfree): Update.
7227
7228 2019-03-06  Tom Tromey  <tom@tromey.com>
7229
7230         * infrun.c (displaced_step_clear_cleanup): Now a
7231         forward_scope_exit type.
7232         (displaced_step_prepare_throw): Update.
7233         (displaced_step_fixup): Update.
7234
7235 2019-03-06  Tom Tromey  <tom@tromey.com>
7236
7237         * inferior.h (class inferior): Update comment.
7238         * gdbthread.h (class thread_info): Update comment.
7239
7240 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7241             Tom Tromey  <tom@tromey.com>
7242
7243         * stabsread.h (struct stab_section_list): Remove.
7244         (coffstab_build_psymtabs): Update.
7245         * dbxread.c (symbuf_sections): Now a std::vector.
7246         (sect_idx): New global.
7247         (fill_symbuf): Update.
7248         (coffstab_build_psymtabs): Change type of stabsects parameter.
7249         Update.
7250         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7251         std::vector.
7252         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7253         (coff_locate_sections): Update.
7254         (coff_symfile_read): Remove cleanups.  Update.
7255         (init_stringtab): Add storage parameter.
7256         (free_stringtab, free_stringtab_cleanup): Remove.
7257         (init_lineno): Add storage parameter.
7258         (free_linetab, free_linetab_cleanup): Remove.
7259
7260 2019-03-06  Pedro Alves  <palves@redhat.com>
7261
7262         * linux-fork.c (fork_info::clobber_regs): Delete.
7263         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7264         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7265         comment.  Adjust.
7266         (scoped_switch_fork_info::scoped_switch_fork_info)
7267         (checkpoint_command, linux_fork_context): Adjust
7268         fork_save_infrun_state calls.
7269
7270 2019-03-06  Pedro Alves  <palves@redhat.com>
7271
7272         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7273         (inf_has_multiple_threads): Return 'bool' and rewrite using
7274         inferior_info::threads().
7275
7276 2019-03-06  Pedro Alves  <palves@redhat.com>
7277
7278         * linux-fork.c: Include <list>.
7279         (fork_list): Now a std::list instance.
7280         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7281         (forks_exist_p, find_last_fork): Adjust.
7282         (new_fork): Delete.
7283         (one_fork_p): New.
7284         (add_fork): Adjust.
7285         (free_fork): Delete, folded into fork_info::~fork_info().
7286         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7287         Adjust.
7288         (init_fork_list): Delete.
7289         (linux_fork_killall, linux_fork_mourn_inferior)
7290         (linux_fork_detach, info_checkpoints_command): Adjust.
7291         (_initialize_linux_fork): No longer call init_fork_list.
7292
7293 2019-03-06  Pedro Alves  <palves@redhat.com>
7294
7295         * linux-fork.c (new_fork): New, split out of ...
7296         (add_fork): ... this.  Return void.  Move "first fork" special
7297         case from here, to ...
7298         (checkpoint_command): ... here.
7299         * linux-linux.h (add_fork): Return void.
7300
7301 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7302
7303         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7304
7305 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7306             Chris January  <chris.january@arm.com>
7307             David Lecomber  <david.lecomber@arm.com>
7308
7309         * f-exp.y: New token, UNOP_INTRINSIC.
7310         (exp): New pattern using UNOP_INTRINSIC token.
7311         (f77_keywords): Add 'abs' keyword.
7312         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7313         (value_from_host_double): New function.
7314         (evaluate_subexp_f): Support UNOP_ABS.
7315
7316 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7317
7318         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7319         types.
7320
7321 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7322
7323         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7324         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7325         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7326
7327 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7328
7329         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7330
7331 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7332             Chris January  <chris.january@arm.com>
7333
7334         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7335         * f-exp.y: Define 'KIND' token.
7336         (exp): New pattern for KIND expressions.
7337         (ptype): Handle types with a kind extension.
7338         (direct_abs_decl): Extend to spot kind extensions.
7339         (f77_keywords): Add 'kind' to the list.
7340         (push_kind_type): New function.
7341         (convert_to_kind_type): New function.
7342         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7343         * parse.c (operator_length_standard): Likewise.
7344         * parser-defs.h (enum type_pieces): Add tp_kind.
7345         * std-operator.def: Add UNOP_KIND.
7346
7347 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7348
7349         * f-exp.y (f_parse): Set yydebug.
7350
7351 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7352
7353         * f-lang.c (evaluate_subexp_f): New function.
7354         (exp_descriptor_f): New global.
7355         (f_language_defn): Use exp_descriptor_f instead of
7356         exp_descriptor_standard.
7357
7358 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7359
7360         * f-exp.y (struct token): Add comments.
7361         (dot_ops): Remove uppercase versions and the end marker.
7362         (f77_keywords): Likewise.
7363         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7364         entries in the dot_ops array are case insensitive, and use
7365         strncasecmp to compare strings.  Also some whitespace cleanup in
7366         this area.  Similar for the f77_keywords array, except entries in
7367         this list might be case sensitive.
7368
7369 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7370
7371         * f-exp.y (struct f77_boolean_val): Add comments.
7372         (boolean_values): Remove uppercase versions, and end marker.
7373         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7374         and use strncasecmp to achieve case insensitivity.  Additionally,
7375         perform whitespace cleanup around this code.
7376
7377 2019-03-06  Tom Tromey  <tromey@adacore.com>
7378
7379         * remote-sim.c (gdbsim_target_open): Use result of
7380         gdb_argv::release.
7381
7382 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7383         Dirk Schubert  <dirk.schubert@arm.com>
7384         Chris January  <chris.january@arm.com>
7385
7386         * eval.c (evaluate_subexp_standard): Call Fortran argument
7387         wrapping logic.
7388         * f-lang.c (struct value): A value which can be passed into a
7389         Fortran function call.
7390         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7391         where appropriate.
7392         (struct type): Value ready for a Fortran function call.
7393         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7394         is needed.
7395         * f-lang.h (fortran_argument_convert): Declaration.
7396         (fortran_preserve_arg_pointer): Declaration.
7397         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7398
7399 2019-03-05  Tom Tromey  <tromey@adacore.com>
7400
7401         * python/py-prettyprint.c (print_string_repr): Remove #if.
7402         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7403
7404 2019-03-05  Tom Tromey  <tromey@adacore.com>
7405
7406         * target.c (the_dummy_target): Move later.  Change type to
7407         "dummy_target".
7408         (initialize_targets): Don't initialize the_dummy_target.
7409
7410 2019-03-05  Tom Tromey  <tromey@adacore.com>
7411
7412         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7413         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7414
7415 2019-03-05  Tom Tromey  <tromey@adacore.com>
7416
7417         * windows-nat.c (windows_nat_target::attach)
7418         (windows_nat_target::detach): Don't call gdb_flush.
7419         * valprint.c (generic_val_print, val_print, val_print_string):
7420         Don't call gdb_flush.
7421         * utils.c (defaulted_query): Don't call gdb_flush.
7422         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7423         * target.c (target_announce_detach): Don't call gdb_flush.
7424         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7425         * remote.c (extended_remote_target::attach): Don't call
7426         gdb_flush.
7427         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7428         * printcmd.c (do_examine): Don't call gdb_flush.
7429         (info_display_command): Don't call gdb_flush.
7430         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7431         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7432         * memattr.c (info_mem_command): Don't call gdb_flush.
7433         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7434         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7435         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7436         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7437         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7438         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7439         (gnu_nat_target::detach): Don't call gdb_flush.
7440         * f-valprint.c (f_val_print): Don't call gdb_flush.
7441         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7442         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7443         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7444         gdb_flush.
7445         * c-valprint.c (c_val_print): Don't call gdb_flush.
7446         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7447
7448 2019-03-05  Tom Tromey  <tromey@adacore.com>
7449
7450         * varobj.c (update_dynamic_varobj_children): Update.
7451         (install_default_visualizer): Use reset, not release.
7452         * value.c (set_internalvar): Update.
7453         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7454         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7455         ATTRIBUTE_UNUSED_RESULT.
7456
7457 2019-03-05  Tom Tromey  <tromey@adacore.com>
7458
7459         * remote.c (class scoped_remote_fd) <release>: Add
7460         ATTRIBUTE_UNUSED_RESULT.
7461
7462 2019-03-05  Tom Tromey  <tromey@adacore.com>
7463
7464         * macroexp.c (struct macro_buffer) <release>: Add
7465         ATTRIBUTE_UNUSED_RESULT.
7466
7467 2019-03-05  Tom Tromey  <tromey@adacore.com>
7468
7469         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7470         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7471         ATTRIBUTE_UNUSED_RESULT.
7472
7473 2019-03-05  Tom Tromey  <tromey@adacore.com>
7474
7475         * common/scoped_fd.h (class scoped_fd) <release>: Add
7476         ATTRIBUTE_UNUSED_RESULT.
7477
7478 2019-03-05  Tom Tromey  <tromey@adacore.com>
7479
7480         * parser-defs.h (struct parser_state) <release>: Add
7481         ATTRIBUTE_UNUSED_RESULT.
7482
7483 2019-03-05  Tom Tromey  <tromey@adacore.com>
7484
7485         * utils.h (class gdb_argv) <release>: Add
7486         ATTRIBUTE_UNUSED_RESULT.
7487         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7488
7489 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7490
7491         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7492         for-loop range, to avoid compiler warnings.
7493
7494         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7495         avoid compiler warnings about unused variables.
7496
7497         * NEWS: Mention end of support for native debugging on MS-Windows
7498         before XP.
7499
7500         PR gdb/24292
7501         * common/netstuff.c:
7502         * gdbserver/gdbreplay.c
7503         * gdbserver/remote-utils.c:
7504         * ser-tcp.c:
7505         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7506         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7507         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7508         'getaddrinfo' and 'freeaddrinfo' were not available before
7509         Windows XP, and mingw.org's MinGW headers by default define
7510         _WIN32_WINNT to 0x500.
7511
7512 2019-03-01  Gary Benson <gbenson@redhat.com>
7513
7514         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7515
7516 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7517             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7518
7519         PR gdb/8527
7520         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7521         set_sigint_trap, clear_sigint_trap.
7522
7523 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7524
7525         * target.c (target_detach): Clear the regcache and the
7526         frame cache.
7527
7528 2019-02-27  Pedro Alves  <palves@redhat.com>
7529
7530         * utils.c (set_screen_size): When we cap the height/width sizes,
7531         tweak the corresponding command variable to show "unlimited":
7532
7533 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7534             Pedro Alves  <palves@redhat.com>
7535
7536         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7537         before calling rl_set_screen_size.
7538
7539 2019-02-27  Tom Tromey  <tromey@adacore.com>
7540
7541         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7542         define.
7543         * python/py-value.c: Remove Python 2.4 workaround.
7544         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7545         workaround.
7546         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7547         Python 2.4 workaround.
7548         * python/python-internal.h: Remove Python 2.4 comment.
7549         (Py_ssize_t): Don't define.
7550         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7551         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7552         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7553         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7554         * python/python.c (do_start_initialization): Remove Python 2.4
7555         workaround.
7556         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7557         (print_children): Remove Python 2.4 workaround.
7558         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7559         workaround.
7560         (CHARBUFFERPROC_NAME): Remove.
7561         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7562         Python 2.4 workaround.
7563
7564 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7565
7566         * NEWS: Note minimum Python version.
7567
7568 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7569
7570         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7571         code from these functions.  Remove corresponding ifdefs.  Use
7572         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7573         Remove gotos and target of gotos.
7574         (infpy_search_memory): Likewise.
7575
7576 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7577
7578         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7579         (hppa_gdbarch_init): Don't register deleted functions with
7580         gdbarch.
7581
7582 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7583
7584         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7585         (h8300_unwind_sp): Delete.
7586         (h8300_dummy_id): Delete.
7587         (h8300_gdbarch_init): Don't register deleted functions with
7588         gdbarch.
7589
7590 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7591
7592         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7593         (ft32_unwind_pc): Delete.
7594         (ft32_unwind_sp): Delete.
7595         (ft32_gdbarch_init): Don't register deleted functions with
7596         gdbarch.
7597
7598 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7599
7600         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7601         (frv_unwind_pc): Delete.
7602         (frv_unwind_sp): Delete.
7603         (frv_gdbarch_init): Don't register deleted functions with
7604         gdbarch.
7605
7606 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7607
7608         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7609         (riscv_unwind_pc): Delete.
7610         (riscv_unwind_sp): Delete.
7611         (riscv_gdbarch_init): Don't register deleted functions with
7612         gdbarch.
7613
7614 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7615
7616         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7617         (csky_unwind_pc): Delete.
7618         (csky_unwind_sp): Delete.
7619         (csky_gdbarch_init): Don't register deleted functions with
7620         gdbarch.
7621
7622 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7623
7624         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7625         (cris_unwind_pc): Delete.
7626         (cris_unwind_sp): Delete.
7627         (cris_gdbarch_init): Don't register deleted functions with
7628         gdbarch.
7629
7630 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7631
7632         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7633         (bfin_unwind_pc): Delete.
7634         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7635
7636 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7637
7638         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7639         (arm_unwind_pc): Delete.
7640         (arm_unwind_sp): Delete.
7641         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7642
7643 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7644
7645         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7646         (arc_unwind_pc): Delete.
7647         (arc_unwind_sp): Delete.
7648         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7649
7650 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7651
7652         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7653         (alpha_unwind_pc): Delete.
7654         (alpha_gdbarch_init): Don't register deleted functions with
7655         gdbarch.
7656
7657 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7658
7659         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7660         (aarch64_unwind_pc): Delete.
7661         (aarch64_unwind_sp): Delete.
7662         (aarch64_gdbarch_init): Don't register deleted functions with
7663         gdbarch.
7664
7665 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7666
7667         * gdbtypes.c (type_align): Don't consider static members when
7668         computing structure alignment.
7669
7670 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7671
7672         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7673         return 0 for other types.
7674         * arch-utils.c (default_type_align): Always return 0.
7675         * gdbarch.h: Regenerate.
7676         * gdbarch.sh (type_align): Extend comment.
7677         * gdbtypes.c (type_align): Add additional comments, always call
7678         gdbarch_type_align before applying the default rules.
7679         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7680         generic code will then apply a suitable default.
7681         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7682         types, return 0 for other types.
7683
7684 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7685
7686         * NEWS: Create a new section for the next release branch.
7687         Rename the section of the current branch, now that it has
7688         been cut.
7689
7690 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7691
7692         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7693         * version.in: Bump version to 8.3.50.DATE-git.
7694
7695 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7696
7697         * aix-thread.c (ptid_cmp): Remove unused variable.
7698         (get_signaled_thread): Likewise.
7699         (store_regs_user_thread): Likewise.
7700         (store_regs_kernel_thread): Likewise.
7701         (fetch_regs_kernel_thread): Remove shadowed variable.
7702
7703 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7704
7705         * features/riscv/32bit-cpu.xml: Add register numbers.
7706         * features/riscv/32bit-fpu.c: Regenerate.
7707         * features/riscv/32bit-fpu.xml: Add register numbers.
7708         * features/riscv/64bit-cpu.xml: Add register numbers.
7709         * features/riscv/64bit-fpu.c: Regenerate.
7710         * features/riscv/64bit-fpu.xml: Add register numbers.
7711
7712 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7713
7714         * NEWS: Mention two argument form of gdb.Value constructor.
7715         * python/py-value.c (convert_buffer_and_type_to_value): New
7716         function.
7717         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7718         Add support for handling an optional second argument.  Call
7719         convert_buffer_and_type_to_value as appropriate.
7720         * python/python-internal.h (Py_buffer_deleter): New struct.
7721         (Py_buffer_up): New typedef.
7722
7723 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7724
7725         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7726         instead of releasing ownership.
7727
7728 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7729
7730         * dwarf2read.c (open_and_init_dwp_file): Call
7731         elf_numsections instead of bfd_count_sections to initialize
7732         dwp_file->num_sections.
7733
7734 2019-02-25  Tom Tromey  <tromey@adacore.com>
7735
7736         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7737
7738 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7739
7740         * gcore.in: Add '--readnever' option when invoking GDB.
7741
7742 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7743
7744         * MAINTAINERS: Update my email address.
7745
7746 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7747
7748         * build-id.c (build_id_to_debug_bfd_1): New function.
7749         (build_id_to_debug_bfd): Look for separate debug file in
7750         sysroot.
7751
7752 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7753
7754         * gdbarch.sh: Update the copyright year range that is placed into
7755         generated files.
7756
7757 2019-02-22  Keith Seitz  <keiths@redhat.com>
7758
7759         PR symtab/23853
7760         * linespec.c (create_sals_line_offset): Search for the default
7761         symtab's filename instead of its fullname.
7762
7763 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7764
7765         * NEWS: Update style defaults.
7766
7767 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7768
7769         * main.c (captured_main_1): Disable styling in batch mode.
7770
7771 2019-02-20  Tom Tromey  <tom@tromey.com>
7772
7773         * symtab.c (symtab_symbol_info): Fix typos.
7774
7775 2019-02-20  Tom Tromey  <tromey@adacore.com>
7776
7777         * findcmd.c (_initialize_mem_search): Use upper case for
7778         metasyntactic variables.
7779
7780 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7781
7782         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7783         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7784
7785 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7786
7787         * top.h (source_file_name): Change to std::string.
7788         * top.c (source_file_name): Likewise.
7789         (command_line_input): Adjust.
7790         * cli/cli-script.c (script_from_file): Adjust.
7791
7792 2019-02-19  Tom Tromey  <tromey@adacore.com>
7793
7794         * ravenscar-thread.c
7795         (ravenscar_thread_target::update_thread_list): Don't call
7796         ada_build_task_list.
7797         * ada-lang.h (ada_build_task_list): Don't declare.
7798         * ada-tasks.c (struct ada_tasks_inferior_data)
7799         <task_list_valid_p>: Now bool.
7800         (read_known_tasks, ada_task_list_changed)
7801         (ada_tasks_invalidate_inferior_data): Update.
7802         (read_known_tasks_array): Return bool.
7803         (read_known_tasks_list): Likewise.
7804         (read_known_tasks): Return void.
7805         (ada_build_task_list): Now static.
7806
7807 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7808
7809         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7810         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7811
7812 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7813
7814         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7815         variant for ada_tasks_pspace_data_handle and
7816         ada_tasks_inferior_data_handle.
7817         (ada_tasks_pspace_data_cleanup): New function.
7818         (ada_tasks_inferior_data_cleanup): New function.
7819
7820 2019-02-17  Tom Tromey  <tom@tromey.com>
7821
7822         * macrotab.h (macro_source_fullname): Return a std::string.
7823         * macrotab.c (macro_include, check_for_redefinition)
7824         (macro_undef, macro_lookup_definition, foreach_macro)
7825         (foreach_macro_in_scope): Update.
7826         (macro_source_fullname): Return a std::string.
7827         * macrocmd.c (show_pp_source_pos): Update.
7828
7829 2019-02-17  Tom Tromey  <tom@tromey.com>
7830
7831         * macrocmd.c (show_pp_source_pos): Style the file names.
7832
7833 2019-02-17  Tom Tromey  <tom@tromey.com>
7834
7835         PR tui/24197:
7836         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7837
7838 2019-02-17  Tom Tromey  <tom@tromey.com>
7839
7840         * ada-lang.c (user_select_syms): Use filtered printing.
7841         * utils.c (wrap_style): New global.
7842         (desired_style): Remove.
7843         (emit_style_escape): Add stream parameter.
7844         (set_output_style, reset_terminal_style, prompt_for_continue):
7845         Update.
7846         (flush_wrap_buffer): Only flush gdb_stdout.
7847         (wrap_here): Set wrap_style.
7848         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7849         treat escape sequences as a character.  Change when wrap buffer is
7850         flushed.
7851         (fputs_styled): Do not set the output style when the default is
7852         requested.
7853         * ui-style.h (struct ui_file_style) <is_default>: New method.
7854         * source.c (print_source_lines_base): Emit escape sequences in one
7855         piece.
7856
7857 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7858
7859         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7860         integers and enumeration types.
7861
7862 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7863
7864         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7865         instead of lookup_symbol_in_language
7866         (do_exact_match): New function.
7867         (ada_get_symbol_name_matcher): Return do_exact_match when
7868         doing a verbatim match.
7869
7870 2019-02-15  Tom Tromey  <tromey@adacore.com>
7871
7872         * ravenscar-thread.c (ravenscar_thread_target::resume)
7873         (ravenscar_thread_target::wait): Special case wildcard requests.
7874
7875 2019-02-15  Tom Tromey  <tromey@adacore.com>
7876
7877         * ravenscar-thread.c (base_ptid): Remove.
7878         (struct ravenscar_thread_target) <close>: New method.
7879         <m_base_ptid>: New member.
7880         <update_inferior_ptid, active_task, task_is_currently_active,
7881         runtime_initialized>: Declare methods.
7882         <ravenscar_thread_target>: Add constructor.
7883         (ravenscar_thread_target::task_is_currently_active)
7884         (ravenscar_thread_target::update_inferior_ptid)
7885         (ravenscar_runtime_initialized): Rename.  Now methods.
7886         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7887         (ravenscar_thread_target::update_thread_list): Update.
7888         (ravenscar_thread_target::active_task): Now method.
7889         (ravenscar_thread_target::store_registers)
7890         (ravenscar_thread_target::prepare_to_store)
7891         (ravenscar_thread_target::prepare_to_store)
7892         (ravenscar_thread_target::mourn_inferior): Update.
7893         (ravenscar_inferior_created): Use "new" to create target.
7894         (ravenscar_thread_target::get_ada_task_ptid): Update.
7895         (_initialize_ravenscar): Don't initialize base_ptid.
7896         (ravenscar_ops): Remove global.
7897
7898 2019-02-15  Tom Tromey  <tromey@adacore.com>
7899
7900         * target.h (push_target): Declare new overload.
7901         * target.c (push_target): New overload, taking an rvalue reference.
7902         * remote.c (remote_target::open_1): Use push_target overload.
7903         * corelow.c (core_target_open): Use push_target overload.
7904
7905 2019-02-15  Tom Tromey  <tromey@adacore.com>
7906
7907         * ravenscar-thread.c (is_ravenscar_task)
7908         (ravenscar_task_is_currently_active): Return bool.
7909         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7910         (_initialize_ravenscar): Remove "(void)".
7911         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7912         Return bool.
7913
7914 2019-02-15  Tom Tromey  <tromey@adacore.com>
7915
7916         * ravenscar-thread.c (ravenscar_runtime_initializer)
7917         (has_ravenscar_runtime, get_running_thread_id)
7918         (ravenscar_thread_target::resume): Fix indentation.
7919
7920 2019-02-15  Tom Tromey  <tromey@adacore.com>
7921
7922         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7923         from ravenscar_arch_ops.
7924         (sparc_ravenscar_ops::fetch_registers)
7925         (sparc_ravenscar_ops::store_registers): Now methods.
7926         (sparc_ravenscar_prepare_to_store): Remove.
7927         (sparc_ravenscar_ops): Redefine.
7928         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7929         methods and destructor.  Remove members.
7930         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7931         (ravenscar_thread_target::store_registers)
7932         (ravenscar_thread_target::prepare_to_store): Update.
7933         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7934         Remove.
7935         (struct ppc_ravenscar_powerpc_ops): Derive from
7936         ravenscar_arch_ops.
7937         (ppc_ravenscar_powerpc_ops::fetch_registers)
7938         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7939         (ppc_ravenscar_powerpc_ops): Redefine.
7940         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7941         (ppc_ravenscar_e500_ops::fetch_registers)
7942         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7943         (ppc_ravenscar_e500_ops): Redefine.
7944         * aarch64-ravenscar-thread.c
7945         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7946         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7947         (aarch64_ravenscar_fetch_registers)
7948         (aarch64_ravenscar_store_registers): Now methods.
7949         (aarch64_ravenscar_ops): Redefine.
7950
7951 2019-02-15  Tom Tromey  <tromey@adacore.com>
7952
7953         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7954         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7955         (ravenscar_thread_target::stopped_by_watchpoint)
7956         (ravenscar_thread_target::stopped_data_address)
7957         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7958
7959 2019-02-15  Tom Tromey  <tromey@adacore.com>
7960
7961         * ravenscar-thread.c: Fix some typos.
7962
7963 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7964             Tom Tromey  <tromey@adacore.com>
7965
7966         * ada-lang.c (ada_exception_sal): Change addr_string to a
7967         std::string.
7968         (create_ada_exception_catchpoint): Update.
7969
7970 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7971             Tom Tromey  <tromey@adacore.com>
7972
7973         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7974         (bp_location_ops): Remove.
7975         (base_breakpoint_allocate_location): Update.
7976         (free_bp_location): Update.
7977         * ada-lang.c (class ada_catchpoint_location)
7978         <ada_catchpoint_location>: Remove ops parameter.
7979         (ada_catchpoint_location_dtor): Remove.
7980         (ada_catchpoint_location_ops): Remove.
7981         (allocate_location_exception): Update.
7982         * breakpoint.h (struct bp_location_ops): Remove.
7983         (class bp_location) <bp_location>: Remove bp_location_ops
7984         parameter.
7985         <~bp_location>: Add destructor.
7986         <ops>: Remove.
7987
7988 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7989             Pedro Alves  <palves@redhat.com>
7990
7991         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7992         'PATH_MAX'.
7993
7994 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7995             Samuel Thibault  <samuel.thibault@gnu.org>
7996             Thomas Schwinge  <thomas@codesourcery.com>
7997
7998         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7999         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8000
8001 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8002
8003         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8004         (check_empty): Use "const char *".
8005
8006         * gnu-nat.c (gnu_nat_target::detach): Instead of
8007         'detach_inferior (pid)' call
8008         'detach_inferior (find_inferior_pid (pid))'.
8009
8010         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8011         'nat/fork-inferior.o'.
8012         * gnu-nat.c: #include "nat/fork-inferior.h".
8013
8014         * gnu-nat.c (gnu_nat_target::detach): Instead of
8015         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8016         * gnu-nat.h: #include "inf-child.h".
8017         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8018         'i386_gnu_nat_target::fetch_registers'.
8019         (gnu_store_registers): Rename/move to
8020         'i386_gnu_nat_target::store_registers'.
8021
8022         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8023         * gnu-nat.h (mach_thread_info): New function.
8024         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8025
8026         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8027
8028 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8029
8030         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8031
8032 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8033
8034         * windows-nat.c (windows_add_thread): Add new parameter
8035         "main_thread_p" with default value set to false.  Update
8036         function documentation as well as all callers.
8037         (windows_delete_thread): Likewise.
8038         (fake_create_process): Update call to windows_add_thread.
8039         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8040         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8041         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8042         call to windows_delete_thread.
8043
8044 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8045
8046         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8047
8048 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8049
8050         * symfile.c (find_separate_debug_file): Use canonical path of
8051         sysroot with child_path instead of gdb_sysroot if it is valid.
8052
8053 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8054
8055         * symfile.c (find_separate_debug_file): Use child_path to
8056         determine if an object file is under a sysroot.
8057
8058 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8059
8060         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8061         unittests/child-path-selftests.c.
8062         * common/pathstuff.c (child_path): New function.
8063         * common/pathstuff.h (child_path): New prototype.
8064         * unittests/child-path-selftests.c: New file.
8065
8066 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8067
8068         * symfile.c (find_separate_debug_file): Look for separate debug
8069         files in debug directories under the sysroot.
8070
8071 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8072
8073         * symtab.h (struct minimal_symbol data_p): New const method.
8074         (struct minimal_symbol text_p): Likewise.
8075         * symtab.c (output_source_filename): Use file name style
8076         to print file name.
8077         (print_symbol_info): Likewise.
8078         (print_msymbol_info): Use address style to print addresses.
8079         Use function name style to print executable text symbols.
8080         (expand_symtab_containing_pc): Use data_p.
8081         (find_pc_sect_compunit_symtab): Likewise.
8082
8083 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8084
8085         * breakpoint.c (describe_other_breakpoints): Use address style
8086         to print addresses.
8087         (say_where): Likewise.
8088
8089 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8090
8091         * ada-typeprint.c (print_func_type): Print function name
8092         style to print function name.
8093         * c-typeprint.c (c_print_type_1): Likewise.
8094
8095 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8096
8097         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8098         for execve.
8099
8100 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8101
8102         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8103         type_stack.
8104
8105 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8106
8107         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8108         TYPE_CODE_REF types.
8109
8110 2019-02-08  Jim Wilson  <jimw@sifive.com>
8111
8112         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8113         (riscv_linux_fregset): New.
8114         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8115
8116 2019-02-07  Tom Tromey  <tom@tromey.com>
8117
8118         * thread.c (thread_cancel_execution_command): Update.
8119         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8120         methods.
8121         (struct thread_fsm_ops): Remove.
8122         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8123         (thread_fsm_should_stop, thread_fsm_return_value)
8124         (thread_fsm_set_finished, thread_fsm_finished_p)
8125         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8126         Don't declare.
8127         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8128         * infrun.c (clear_proceed_status_thread)
8129         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8130         (print_stop_event): Update.
8131         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8132         Add constructor.
8133         (step_command_fsm_ops): Remove.
8134         (new_step_command_fsm): Remove.
8135         (step_1): Update.
8136         (step_command_fsm::should_stop): Rename from
8137         step_command_fsm_should_stop.
8138         (step_command_fsm::clean_up): Rename from
8139         step_command_fsm_clean_up.
8140         (step_command_fsm::do_async_reply_reason): Rename from
8141         step_command_fsm_async_reply_reason.
8142         (struct until_next_fsm): Inherit from thread_fsm.  Add
8143         constructor.
8144         (until_next_fsm_ops): Remove.
8145         (new_until_next_fsm): Remove.
8146         (until_next_fsm::should_stop): Rename from
8147         until_next_fsm_should_stop.
8148         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8149         (until_next_fsm::do_async_reply_reason): Rename from
8150         until_next_fsm_async_reply_reason.
8151         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8152         constructor.  Change type of breakpoint.
8153         (finish_command_fsm_ops): Remove.
8154         (new_finish_command_fsm): Remove.
8155         (finish_command_fsm::should_stop): Rename from
8156         finish_command_fsm_should_stop.
8157         (finish_command_fsm::clean_up): Rename from
8158         finish_command_fsm_clean_up.
8159         (finish_command_fsm::return_value): Rename from
8160         finish_command_fsm_return_value.
8161         (finish_command_fsm::do_async_reply_reason): Rename from
8162         finish_command_fsm_async_reply_reason.
8163         (finish_command): Update.
8164         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8165         Add constructor.
8166         (call_thread_fsm_ops): Remove.
8167         (call_thread_fsm::call_thread_fsm): Rename from
8168         new_call_thread_fsm.
8169         (call_thread_fsm::should_stop): Rename from
8170         call_thread_fsm_should_stop.
8171         (call_thread_fsm::should_notify_stop): Rename from
8172         call_thread_fsm_should_notify_stop.
8173         (run_inferior_call, call_function_by_hand_dummy): Update.
8174         * cli/cli-interp.c (should_print_stop_to_console): Update.
8175         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8176         Add constructor.  Change type of location_breakpoint,
8177         caller_breakpoint.
8178         (until_break_fsm_ops): Remove.
8179         (new_until_break_fsm): Remove.
8180         (until_break_fsm::should_stop): Rename from
8181         until_break_fsm_should_stop.
8182         (until_break_fsm::clean_up): Rename from
8183         until_break_fsm_clean_up.
8184         (until_break_fsm::do_async_reply_reason): Rename from
8185         until_break_fsm_async_reply_reason.
8186         (until_break_command): Update.
8187         * thread-fsm.c: Remove.
8188         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8189
8190 2019-02-07  Tom Tromey  <tom@tromey.com>
8191
8192         * yy-remap.h: Add include guard.
8193         * xtensa-tdep.h: Add include guard.
8194         * xcoffread.h: Rename include guard.
8195         * varobj-iter.h: Add include guard.
8196         * tui/tui.h: Rename include guard.
8197         * tui/tui-winsource.h: Rename include guard.
8198         * tui/tui-wingeneral.h: Rename include guard.
8199         * tui/tui-windata.h: Rename include guard.
8200         * tui/tui-win.h: Rename include guard.
8201         * tui/tui-stack.h: Rename include guard.
8202         * tui/tui-source.h: Rename include guard.
8203         * tui/tui-regs.h: Rename include guard.
8204         * tui/tui-out.h: Rename include guard.
8205         * tui/tui-layout.h: Rename include guard.
8206         * tui/tui-io.h: Rename include guard.
8207         * tui/tui-hooks.h: Rename include guard.
8208         * tui/tui-file.h: Rename include guard.
8209         * tui/tui-disasm.h: Rename include guard.
8210         * tui/tui-data.h: Rename include guard.
8211         * tui/tui-command.h: Rename include guard.
8212         * tic6x-tdep.h: Add include guard.
8213         * target/waitstatus.h: Rename include guard.
8214         * target/wait.h: Rename include guard.
8215         * target/target.h: Rename include guard.
8216         * target/resume.h: Rename include guard.
8217         * target-float.h: Rename include guard.
8218         * stabsread.h: Add include guard.
8219         * rs6000-tdep.h: Add include guard.
8220         * riscv-fbsd-tdep.h: Add include guard.
8221         * regformats/regdef.h: Rename include guard.
8222         * record.h: Rename include guard.
8223         * python/python.h: Rename include guard.
8224         * python/python-internal.h: Rename include guard.
8225         * python/py-stopevent.h: Rename include guard.
8226         * python/py-ref.h: Rename include guard.
8227         * python/py-record.h: Rename include guard.
8228         * python/py-record-full.h: Rename include guard.
8229         * python/py-record-btrace.h: Rename include guard.
8230         * python/py-instruction.h: Rename include guard.
8231         * python/py-events.h: Rename include guard.
8232         * python/py-event.h: Rename include guard.
8233         * procfs.h: Add include guard.
8234         * proc-utils.h: Add include guard.
8235         * p-lang.h: Add include guard.
8236         * or1k-tdep.h: Rename include guard.
8237         * observable.h: Rename include guard.
8238         * nto-tdep.h: Rename include guard.
8239         * nat/x86-linux.h: Rename include guard.
8240         * nat/x86-linux-dregs.h: Rename include guard.
8241         * nat/x86-gcc-cpuid.h: Add include guard.
8242         * nat/x86-dregs.h: Rename include guard.
8243         * nat/x86-cpuid.h: Rename include guard.
8244         * nat/ppc-linux.h: Rename include guard.
8245         * nat/mips-linux-watch.h: Rename include guard.
8246         * nat/linux-waitpid.h: Rename include guard.
8247         * nat/linux-ptrace.h: Rename include guard.
8248         * nat/linux-procfs.h: Rename include guard.
8249         * nat/linux-osdata.h: Rename include guard.
8250         * nat/linux-nat.h: Rename include guard.
8251         * nat/linux-namespaces.h: Rename include guard.
8252         * nat/linux-btrace.h: Rename include guard.
8253         * nat/glibc_thread_db.h: Rename include guard.
8254         * nat/gdb_thread_db.h: Rename include guard.
8255         * nat/gdb_ptrace.h: Rename include guard.
8256         * nat/fork-inferior.h: Rename include guard.
8257         * nat/amd64-linux-siginfo.h: Rename include guard.
8258         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8259         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8260         * nat/aarch64-linux.h: Rename include guard.
8261         * nat/aarch64-linux-hw-point.h: Rename include guard.
8262         * mn10300-tdep.h: Add include guard.
8263         * mips-linux-tdep.h: Add include guard.
8264         * mi/mi-parse.h: Rename include guard.
8265         * mi/mi-out.h: Rename include guard.
8266         * mi/mi-main.h: Rename include guard.
8267         * mi/mi-interp.h: Rename include guard.
8268         * mi/mi-getopt.h: Rename include guard.
8269         * mi/mi-console.h: Rename include guard.
8270         * mi/mi-common.h: Rename include guard.
8271         * mi/mi-cmds.h: Rename include guard.
8272         * mi/mi-cmd-break.h: Rename include guard.
8273         * m2-lang.h: Add include guard.
8274         * location.h: Rename include guard.
8275         * linux-record.h: Rename include guard.
8276         * linux-nat.h: Add include guard.
8277         * linux-fork.h: Add include guard.
8278         * i386-darwin-tdep.h: Rename include guard.
8279         * hppa-linux-offsets.h: Add include guard.
8280         * guile/guile.h: Rename include guard.
8281         * guile/guile-internal.h: Rename include guard.
8282         * gnu-nat.h: Rename include guard.
8283         * gdb-stabs.h: Rename include guard.
8284         * frv-tdep.h: Add include guard.
8285         * f-lang.h: Add include guard.
8286         * event-loop.h: Add include guard.
8287         * darwin-nat.h: Rename include guard.
8288         * cp-abi.h: Rename include guard.
8289         * config/sparc/nm-sol2.h: Rename include guard.
8290         * config/nm-nto.h: Rename include guard.
8291         * config/nm-linux.h: Add include guard.
8292         * config/i386/nm-i386gnu.h: Rename include guard.
8293         * config/djgpp/nl_types.h: Rename include guard.
8294         * config/djgpp/langinfo.h: Rename include guard.
8295         * compile/gcc-cp-plugin.h: Add include guard.
8296         * compile/gcc-c-plugin.h: Add include guard.
8297         * compile/compile.h: Rename include guard.
8298         * compile/compile-object-run.h: Rename include guard.
8299         * compile/compile-object-load.h: Rename include guard.
8300         * compile/compile-internal.h: Rename include guard.
8301         * compile/compile-cplus.h: Rename include guard.
8302         * compile/compile-c.h: Rename include guard.
8303         * common/xml-utils.h: Rename include guard.
8304         * common/x86-xstate.h: Rename include guard.
8305         * common/version.h: Rename include guard.
8306         * common/vec.h: Rename include guard.
8307         * common/tdesc.h: Rename include guard.
8308         * common/selftest.h: Rename include guard.
8309         * common/scoped_restore.h: Rename include guard.
8310         * common/scoped_mmap.h: Rename include guard.
8311         * common/scoped_fd.h: Rename include guard.
8312         * common/safe-iterator.h: Rename include guard.
8313         * common/run-time-clock.h: Rename include guard.
8314         * common/refcounted-object.h: Rename include guard.
8315         * common/queue.h: Rename include guard.
8316         * common/ptid.h: Rename include guard.
8317         * common/print-utils.h: Rename include guard.
8318         * common/preprocessor.h: Rename include guard.
8319         * common/pathstuff.h: Rename include guard.
8320         * common/observable.h: Rename include guard.
8321         * common/netstuff.h: Rename include guard.
8322         * common/job-control.h: Rename include guard.
8323         * common/host-defs.h: Rename include guard.
8324         * common/gdb_wait.h: Rename include guard.
8325         * common/gdb_vecs.h: Rename include guard.
8326         * common/gdb_unlinker.h: Rename include guard.
8327         * common/gdb_unique_ptr.h: Rename include guard.
8328         * common/gdb_tilde_expand.h: Rename include guard.
8329         * common/gdb_sys_time.h: Rename include guard.
8330         * common/gdb_string_view.h: Rename include guard.
8331         * common/gdb_splay_tree.h: Rename include guard.
8332         * common/gdb_setjmp.h: Rename include guard.
8333         * common/gdb_ref_ptr.h: Rename include guard.
8334         * common/gdb_optional.h: Rename include guard.
8335         * common/gdb_locale.h: Rename include guard.
8336         * common/gdb_assert.h: Rename include guard.
8337         * common/filtered-iterator.h: Rename include guard.
8338         * common/filestuff.h: Rename include guard.
8339         * common/fileio.h: Rename include guard.
8340         * common/environ.h: Rename include guard.
8341         * common/common-utils.h: Rename include guard.
8342         * common/common-types.h: Rename include guard.
8343         * common/common-regcache.h: Rename include guard.
8344         * common/common-inferior.h: Rename include guard.
8345         * common/common-gdbthread.h: Rename include guard.
8346         * common/common-exceptions.h: Rename include guard.
8347         * common/common-defs.h: Rename include guard.
8348         * common/common-debug.h: Rename include guard.
8349         * common/cleanups.h: Rename include guard.
8350         * common/buffer.h: Rename include guard.
8351         * common/btrace-common.h: Rename include guard.
8352         * common/break-common.h: Rename include guard.
8353         * cli/cli-utils.h: Rename include guard.
8354         * cli/cli-style.h: Rename include guard.
8355         * cli/cli-setshow.h: Rename include guard.
8356         * cli/cli-script.h: Rename include guard.
8357         * cli/cli-interp.h: Rename include guard.
8358         * cli/cli-decode.h: Rename include guard.
8359         * cli/cli-cmds.h: Rename include guard.
8360         * charset-list.h: Add include guard.
8361         * buildsym-legacy.h: Rename include guard.
8362         * bfin-tdep.h: Add include guard.
8363         * ax.h: Rename include guard.
8364         * arm-linux-tdep.h: Add include guard.
8365         * arm-fbsd-tdep.h: Add include guard.
8366         * arch/xtensa.h: Rename include guard.
8367         * arch/tic6x.h: Add include guard.
8368         * arch/i386.h: Add include guard.
8369         * arch/arm.h: Rename include guard.
8370         * arch/arm-linux.h: Rename include guard.
8371         * arch/arm-get-next-pcs.h: Rename include guard.
8372         * arch/amd64.h: Add include guard.
8373         * arch/aarch64-insn.h: Rename include guard.
8374         * arch-utils.h: Rename include guard.
8375         * annotate.h: Add include guard.
8376         * amd64-darwin-tdep.h: Rename include guard.
8377         * aarch64-linux-tdep.h: Add include guard.
8378         * aarch64-fbsd-tdep.h: Add include guard.
8379         * aarch32-linux-nat.h: Add include guard.
8380
8381 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8382
8383         * macrotab.c (macro_define_internal): New function that
8384         factorizes macro_define_object_internal and macro_define_function
8385         code.
8386         (macro_define_object_internal): Use macro_define_internal.
8387         (macro_define_function): Likewise.
8388
8389 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8390
8391         * macrocmd.c (extract_identifier): Return
8392         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8393         callers.
8394
8395 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8396
8397         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8398
8399 2019-02-05  Tom Tromey  <tom@tromey.com>
8400
8401         * target.c (target_stack::unpush): Move assertion earlier.
8402
8403 2019-01-30  Tom Tromey  <tom@tromey.com>
8404
8405         PR python/23615:
8406         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8407         (gdbpy_parse_and_eval): Likewise.
8408         * python/python-internal.h (gdbpy_allow_threads): New class.
8409
8410 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8411
8412         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8413         (aarch64_fbsd_fpregmap): Move earlier.
8414         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8415         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8416         instead of individual calls to trad_frame_set_reg_addr.
8417         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8418         earlier.
8419         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8420         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8421         instead of individual calls to trad_frame_set_reg_addr.
8422
8423 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8424
8425         * CONTRIBUTE: Replace contribution list with wiki link.
8426
8427 2019-01-25  Tom Tromey  <tom@tromey.com>
8428
8429         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8430
8431 2019-01-25  Tom Tromey  <tom@tromey.com>
8432
8433         * xtensa-linux-nat.c: Fix common/ includes.
8434         * xml-support.h: Fix common/ includes.
8435         * xml-support.c: Fix common/ includes.
8436         * x86-linux-nat.c: Fix common/ includes.
8437         * windows-nat.c: Fix common/ includes.
8438         * varobj.h: Fix common/ includes.
8439         * varobj.c: Fix common/ includes.
8440         * value.c: Fix common/ includes.
8441         * valops.c: Fix common/ includes.
8442         * utils.c: Fix common/ includes.
8443         * unittests/xml-utils-selftests.c: Fix common/ includes.
8444         * unittests/utils-selftests.c: Fix common/ includes.
8445         * unittests/unpack-selftests.c: Fix common/ includes.
8446         * unittests/tracepoint-selftests.c: Fix common/ includes.
8447         * unittests/style-selftests.c: Fix common/ includes.
8448         * unittests/string_view-selftests.c: Fix common/ includes.
8449         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8450         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8451         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8452         * unittests/rsp-low-selftests.c: Fix common/ includes.
8453         * unittests/parse-connection-spec-selftests.c: Fix common/
8454         includes.
8455         * unittests/optional-selftests.c: Fix common/ includes.
8456         * unittests/offset-type-selftests.c: Fix common/ includes.
8457         * unittests/observable-selftests.c: Fix common/ includes.
8458         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8459         * unittests/memrange-selftests.c: Fix common/ includes.
8460         * unittests/memory-map-selftests.c: Fix common/ includes.
8461         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8462         * unittests/function-view-selftests.c: Fix common/ includes.
8463         * unittests/environ-selftests.c: Fix common/ includes.
8464         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8465         * unittests/common-utils-selftests.c: Fix common/ includes.
8466         * unittests/cli-utils-selftests.c: Fix common/ includes.
8467         * unittests/array-view-selftests.c: Fix common/ includes.
8468         * ui-file.c: Fix common/ includes.
8469         * tui/tui-io.c: Fix common/ includes.
8470         * tracepoint.h: Fix common/ includes.
8471         * tracepoint.c: Fix common/ includes.
8472         * tracefile-tfile.c: Fix common/ includes.
8473         * top.h: Fix common/ includes.
8474         * top.c: Fix common/ includes.
8475         * thread.c: Fix common/ includes.
8476         * target/waitstatus.h: Fix common/ includes.
8477         * target/waitstatus.c: Fix common/ includes.
8478         * target.h: Fix common/ includes.
8479         * target.c: Fix common/ includes.
8480         * target-memory.c: Fix common/ includes.
8481         * target-descriptions.c: Fix common/ includes.
8482         * symtab.h: Fix common/ includes.
8483         * symfile.c: Fix common/ includes.
8484         * stap-probe.c: Fix common/ includes.
8485         * spu-linux-nat.c: Fix common/ includes.
8486         * sparc-nat.c: Fix common/ includes.
8487         * source.c: Fix common/ includes.
8488         * solib.c: Fix common/ includes.
8489         * solib-target.c: Fix common/ includes.
8490         * ser-unix.c: Fix common/ includes.
8491         * ser-tcp.c: Fix common/ includes.
8492         * ser-pipe.c: Fix common/ includes.
8493         * ser-base.c: Fix common/ includes.
8494         * selftest-arch.c: Fix common/ includes.
8495         * s12z-tdep.c: Fix common/ includes.
8496         * rust-exp.y: Fix common/ includes.
8497         * rs6000-aix-tdep.c: Fix common/ includes.
8498         * riscv-tdep.c: Fix common/ includes.
8499         * remote.c: Fix common/ includes.
8500         * remote-notif.h: Fix common/ includes.
8501         * remote-fileio.h: Fix common/ includes.
8502         * remote-fileio.c: Fix common/ includes.
8503         * regcache.h: Fix common/ includes.
8504         * regcache.c: Fix common/ includes.
8505         * record-btrace.c: Fix common/ includes.
8506         * python/python.c: Fix common/ includes.
8507         * python/py-type.c: Fix common/ includes.
8508         * python/py-inferior.c: Fix common/ includes.
8509         * progspace.h: Fix common/ includes.
8510         * producer.c: Fix common/ includes.
8511         * procfs.c: Fix common/ includes.
8512         * proc-api.c: Fix common/ includes.
8513         * printcmd.c: Fix common/ includes.
8514         * ppc-linux-nat.c: Fix common/ includes.
8515         * parser-defs.h: Fix common/ includes.
8516         * osdata.c: Fix common/ includes.
8517         * obsd-nat.c: Fix common/ includes.
8518         * nat/x86-linux.c: Fix common/ includes.
8519         * nat/x86-linux-dregs.c: Fix common/ includes.
8520         * nat/x86-dregs.h: Fix common/ includes.
8521         * nat/x86-dregs.c: Fix common/ includes.
8522         * nat/ppc-linux.c: Fix common/ includes.
8523         * nat/mips-linux-watch.h: Fix common/ includes.
8524         * nat/mips-linux-watch.c: Fix common/ includes.
8525         * nat/linux-waitpid.c: Fix common/ includes.
8526         * nat/linux-ptrace.h: Fix common/ includes.
8527         * nat/linux-ptrace.c: Fix common/ includes.
8528         * nat/linux-procfs.c: Fix common/ includes.
8529         * nat/linux-personality.c: Fix common/ includes.
8530         * nat/linux-osdata.c: Fix common/ includes.
8531         * nat/linux-namespaces.c: Fix common/ includes.
8532         * nat/linux-btrace.h: Fix common/ includes.
8533         * nat/linux-btrace.c: Fix common/ includes.
8534         * nat/fork-inferior.c: Fix common/ includes.
8535         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8536         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8537         * nat/aarch64-linux.c: Fix common/ includes.
8538         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8539         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8540         * namespace.h: Fix common/ includes.
8541         * mips-linux-tdep.c: Fix common/ includes.
8542         * minsyms.c: Fix common/ includes.
8543         * mi/mi-parse.h: Fix common/ includes.
8544         * mi/mi-main.c: Fix common/ includes.
8545         * mi/mi-cmd-env.c: Fix common/ includes.
8546         * memrange.h: Fix common/ includes.
8547         * memattr.c: Fix common/ includes.
8548         * maint.h: Fix common/ includes.
8549         * maint.c: Fix common/ includes.
8550         * main.c: Fix common/ includes.
8551         * machoread.c: Fix common/ includes.
8552         * location.c: Fix common/ includes.
8553         * linux-thread-db.c: Fix common/ includes.
8554         * linux-nat.c: Fix common/ includes.
8555         * linux-fork.c: Fix common/ includes.
8556         * inline-frame.c: Fix common/ includes.
8557         * infrun.c: Fix common/ includes.
8558         * inflow.c: Fix common/ includes.
8559         * inferior.h: Fix common/ includes.
8560         * inferior.c: Fix common/ includes.
8561         * infcmd.c: Fix common/ includes.
8562         * inf-ptrace.c: Fix common/ includes.
8563         * inf-child.c: Fix common/ includes.
8564         * ia64-linux-nat.c: Fix common/ includes.
8565         * i387-tdep.c: Fix common/ includes.
8566         * i386-tdep.c: Fix common/ includes.
8567         * i386-linux-tdep.c: Fix common/ includes.
8568         * i386-linux-nat.c: Fix common/ includes.
8569         * i386-go32-tdep.c: Fix common/ includes.
8570         * i386-fbsd-tdep.c: Fix common/ includes.
8571         * i386-fbsd-nat.c: Fix common/ includes.
8572         * guile/scm-type.c: Fix common/ includes.
8573         * guile/guile.c: Fix common/ includes.
8574         * go32-nat.c: Fix common/ includes.
8575         * gnu-nat.c: Fix common/ includes.
8576         * gdbthread.h: Fix common/ includes.
8577         * gdbarch-selftests.c: Fix common/ includes.
8578         * gdb_usleep.c: Fix common/ includes.
8579         * gdb_select.h: Fix common/ includes.
8580         * gdb_bfd.c: Fix common/ includes.
8581         * gcore.c: Fix common/ includes.
8582         * fork-child.c: Fix common/ includes.
8583         * findvar.c: Fix common/ includes.
8584         * fbsd-nat.c: Fix common/ includes.
8585         * event-top.c: Fix common/ includes.
8586         * event-loop.c: Fix common/ includes.
8587         * dwarf2read.c: Fix common/ includes.
8588         * dwarf2loc.c: Fix common/ includes.
8589         * dwarf2-frame.c: Fix common/ includes.
8590         * dwarf-index-cache.c: Fix common/ includes.
8591         * dtrace-probe.c: Fix common/ includes.
8592         * disasm-selftests.c: Fix common/ includes.
8593         * defs.h: Fix common/ includes.
8594         * csky-tdep.c: Fix common/ includes.
8595         * cp-valprint.c: Fix common/ includes.
8596         * cp-support.h: Fix common/ includes.
8597         * cp-support.c: Fix common/ includes.
8598         * corelow.c: Fix common/ includes.
8599         * completer.h: Fix common/ includes.
8600         * completer.c: Fix common/ includes.
8601         * compile/compile.c: Fix common/ includes.
8602         * compile/compile-loc2c.c: Fix common/ includes.
8603         * compile/compile-cplus-types.c: Fix common/ includes.
8604         * compile/compile-cplus-symbols.c: Fix common/ includes.
8605         * command.h: Fix common/ includes.
8606         * cli/cli-dump.c: Fix common/ includes.
8607         * cli/cli-cmds.c: Fix common/ includes.
8608         * charset.c: Fix common/ includes.
8609         * build-id.c: Fix common/ includes.
8610         * btrace.h: Fix common/ includes.
8611         * btrace.c: Fix common/ includes.
8612         * breakpoint.h: Fix common/ includes.
8613         * breakpoint.c: Fix common/ includes.
8614         * ax.h:
8615         (enum agent_op): Fix common/ includes.
8616         * ax-general.c (struct aop_map): Fix common/ includes.
8617         * ax-gdb.c: Fix common/ includes.
8618         * auxv.c: Fix common/ includes.
8619         * auto-load.c: Fix common/ includes.
8620         * arm-tdep.c: Fix common/ includes.
8621         * arch/riscv.c: Fix common/ includes.
8622         * arch/ppc-linux-common.c: Fix common/ includes.
8623         * arch/i386.c: Fix common/ includes.
8624         * arch/arm.c: Fix common/ includes.
8625         * arch/arm-linux.c: Fix common/ includes.
8626         * arch/arm-get-next-pcs.c: Fix common/ includes.
8627         * arch/amd64.c: Fix common/ includes.
8628         * arch/aarch64.c: Fix common/ includes.
8629         * arch/aarch64-insn.c: Fix common/ includes.
8630         * arch-utils.c: Fix common/ includes.
8631         * amd64-windows-tdep.c: Fix common/ includes.
8632         * amd64-tdep.c: Fix common/ includes.
8633         * amd64-sol2-tdep.c: Fix common/ includes.
8634         * amd64-obsd-tdep.c: Fix common/ includes.
8635         * amd64-nbsd-tdep.c: Fix common/ includes.
8636         * amd64-linux-tdep.c: Fix common/ includes.
8637         * amd64-linux-nat.c: Fix common/ includes.
8638         * amd64-fbsd-tdep.c: Fix common/ includes.
8639         * amd64-fbsd-nat.c: Fix common/ includes.
8640         * amd64-dicos-tdep.c: Fix common/ includes.
8641         * amd64-darwin-tdep.c: Fix common/ includes.
8642         * agent.c: Fix common/ includes.
8643         * ada-lang.h: Fix common/ includes.
8644         * ada-lang.c: Fix common/ includes.
8645         * aarch64-tdep.c: Fix common/ includes.
8646
8647 2019-01-25  Tom Tromey  <tom@tromey.com>
8648
8649         * common/create-version.sh: Use common/version.h.
8650
8651 2019-01-24  Pedro Alves  <palves@redhat.com>
8652
8653         * infrun.c (signal_stop, signal_print, signal_program)
8654         (signal_catch, signal_pass): Now arrays instead of pointers.
8655         (update_signals_program_target, do_target_resume)
8656         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8657         * linux-nat.c (linux_nat_target::pass_signals)
8658         (linux_nat_target::create_inferior, linux_nat_target::attach):
8659         Adjust.
8660         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8661         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8662         * procfs.c (procfs_target::pass_signals): Adjust.
8663         * record-full.c (record_full_target::resume): Adjust.
8664         * remote.c (remote_target::pass_signals)
8665         (remote_target::program_signals): Adjust.
8666         * target-debug.h (target_debug_print_signals): Now takes a
8667         gdb::array_view as parameter.  Adjust.
8668         * target.h (target_ops) <pass_signals, program_signals>: Replace
8669         pointer and length parameters with gdb::array_view.
8670         (target_pass_signals, target_program_signals): Likewise.
8671         * target-delegates.c: Regenerate.
8672
8673 2019-01-24  Pedro Alves  <palves@redhat.com>
8674
8675         * common/forward-scope-exit.h
8676         (forward_scope_exit::forward_scope_exit): Pass arguments to
8677         m_bind_function directly, instead of creating a std::bind and
8678         copying that.
8679
8680 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8681
8682         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8683         for static members.
8684         (pass_in_v_vfp_candidate): Likewise.
8685
8686 2019-01-23  Tom Tromey  <tom@tromey.com>
8687             Pedro Alves  <palves@redhat.com>
8688
8689         * regcache.c (class regcache_invalidator): Remove.
8690         (regcache::raw_write): Use make_scope_exit.
8691
8692 2019-01-23  Tom Tromey  <tom@tromey.com>
8693
8694         * ui-out.h (class ui_out_emit_type): Update comment.
8695
8696 2019-01-23  Tom Tromey  <tom@tromey.com>
8697
8698         * infrun.c (fetch_inferior_event): Update comment.
8699
8700 2019-01-23  Tom Tromey  <tom@tromey.com>
8701             Pedro Alves  <palves@redhat.com>
8702
8703         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8704         parameter.
8705         (fetch_inferior_event): Use SCOPE_EXIT.
8706
8707
8708 2019-01-23  Tom Tromey  <tom@tromey.com>
8709             Pedro Alves  <palves@redhat.com>
8710
8711         * infrun.c (disable_thread_events): Delete.
8712         (stop_all_threads): Use SCOPE_EXIT.
8713
8714 2019-01-23  Tom Tromey  <tom@tromey.com>
8715             Pedro Alves  <palves@redhat.com>
8716
8717         * symfile.c: Include forward-scope-exit.h.
8718         (clear_symtab_users_cleanup): Replace forward declaration with
8719         a FORWARD_SCOPE_EXIT.
8720         (syms_from_objfile_1): Use the forward_scope_exit and
8721         gdb::optional instead of cleanup_function.
8722         (reread_symbols): Use the forward_scope_exit instead of
8723         cleanup_function.
8724         (clear_symtab_users_cleanup): Remove function.
8725
8726 2019-01-23  Tom Tromey  <tom@tromey.com>
8727             Pedro Alves  <palves@redhat.com>
8728
8729         * linux-nat.c: Include scope-exit.h.
8730         (cleanup_target_stop): Remove.
8731         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8732         SCOPE_EXIT.
8733
8734 2019-01-23  Tom Tromey  <tom@tromey.com>
8735             Pedro Alves  <palves@redhat.com>
8736
8737         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8738         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8739
8740 2019-01-23  Tom Tromey  <tom@tromey.com>
8741             Andrew Burgess  <andrew.burgess@embecosm.com>
8742             Pedro Alves  <palves@redhat.com>
8743
8744         * infrun.c (fetch_inferior_event): Use scope_exit.
8745         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8746         * top.c (execute_command): Use scope_exit.
8747         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8748         * utils.c (do_bpstat_clear_actions_cleanup)
8749         (make_bpstat_clear_actions_cleanup): Remove.
8750
8751 2019-01-23  Tom Tromey  <tom@tromey.com>
8752             Pedro Alves  <palves@redhat.com>
8753
8754         * infrun.c: Include "common/scope-exit.h"
8755         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8756         (wait_for_inferior): Use SCOPE_EXIT.
8757         (fetch_inferior_event): Use scope_exit.
8758
8759 2019-01-23  Tom Tromey  <tom@tromey.com>
8760             Pedro Alves  <palves@redhat.com>
8761
8762         * breakpoint.c (create_breakpoint): Remove cleanup.
8763
8764 2019-01-23  Tom Tromey  <tom@tromey.com>
8765             Andrew Burgess  <andrew.burgess@embecosm.com>
8766             Pedro Alves  <palves@redhat.com>
8767
8768 2019-01-23  Pedro Alves  <palves@redhat.com>
8769
8770         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8771
8772 2019-01-23  Pedro Alves  <palves@redhat.com>
8773             Andrew Burgess  <andrew.burgess@embecosm.com>
8774
8775         * gdbthread.h: Include "common/forward-scope-exit.h".
8776         (scoped_finish_thread_state): Redefine custom class in terms of
8777         forward_scope_exit.
8778
8779 2019-01-23  Pedro Alves  <palves@redhat.com>
8780             Andrew Burgess  <andrew.burgess@embecosm.com>
8781
8782         * common/forward-scope-exit.h: New file.
8783
8784 2019-01-23  Pedro Alves  <palves@redhat.com>
8785             Andrew Burgess  <andrew.burgess@embecosm.com>
8786             Tom Tromey  <tom@tromey.com>
8787
8788         * common/scope-exit.h: New file.
8789
8790 2019-01-23  Pedro Alves  <palves@redhat.com>
8791
8792         * common/preprocessor.h (ESC): Rename to ...
8793         (ESC_PARENS): ... this.
8794         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8795         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8796
8797 2019-01-23  Tom Tromey  <tom@tromey.com>
8798
8799         * language.h (class scoped_switch_to_sym_language_if_auto):
8800         Initialize m_lang in both cases.
8801
8802 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8803
8804         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8805         with XCNEW.
8806
8807 2019-01-22  Tom Tromey  <tom@tromey.com>
8808
8809         * corelow.c: Do not include sys/file.h.
8810
8811 2019-01-22  Tom Tromey  <tom@tromey.com>
8812
8813         * tui/tui-wingeneral.h: Include gdb_curses.h.
8814
8815 2019-01-22  Tom Tromey  <tom@tromey.com>
8816
8817         * source-cache.h (class source_cache) <get_source_lines,
8818         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8819
8820 2019-01-22  Tom Tromey  <tom@tromey.com>
8821
8822         * remote-fileio.h (struct remote_target): Declare.
8823
8824 2019-01-22  Tom Tromey  <tom@tromey.com>
8825
8826         * python/py-arch.c: Do not include py-ref.h.
8827         * python/py-bpevent.c: Do not include py-ref.h.
8828         * python/py-cmd.c: Do not include py-ref.h.
8829         * python/py-continueevent.c: Do not include py-ref.h.
8830         * python/py-event.h: Do not include py-ref.h.
8831         * python/py-evtregistry.c: Do not include py-ref.h.
8832         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8833         * python/py-frame.c: Do not include py-ref.h.
8834         * python/py-framefilter.c: Do not include py-ref.h.
8835         * python/py-function.c: Do not include py-ref.h.
8836         * python/py-infevents.c: Do not include py-ref.h.
8837         * python/py-linetable.c: Do not include py-ref.h.
8838         * python/py-objfile.c: Do not include py-ref.h.
8839         * python/py-param.c: Do not include py-ref.h.
8840         * python/py-prettyprint.c: Do not include py-ref.h.
8841         * python/py-progspace.c: Do not include py-ref.h.
8842         * python/py-symbol.c: Do not include py-ref.h.
8843         * python/py-symtab.c: Do not include py-ref.h.
8844         * python/py-type.c: Do not include py-ref.h.
8845         * python/py-unwind.c: Do not include py-ref.h.
8846         * python/py-utils.c: Do not include py-ref.h.
8847         * python/py-value.c: Do not include py-ref.h.
8848         * python/py-varobj.c: Do not include py-ref.h.
8849         * python/py-xmethods.c: Do not include py-ref.h.
8850         * python/python.c: Do not include py-ref.h.
8851         * varobj.c: Do not include py-ref.h.
8852
8853 2019-01-22  Tom Tromey  <tom@tromey.com>
8854
8855         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8856         keyword for bcache.
8857
8858 2019-01-22  Tom Tromey  <tom@tromey.com>
8859
8860         * compile/compile-cplus-types.c: Remove a comment by #include.
8861
8862 2019-01-22  Tom Tromey  <tom@tromey.com>
8863
8864         * compile/gcc-c-plugin.h: Include compile-internal.h.
8865
8866 2019-01-22  Tom Tromey  <tom@tromey.com>
8867
8868         * stabsread.c (EXTERN): Do not define.
8869         (symnum, next_symbol_text_func, processing_gcc_compilation)
8870         (within_function, global_sym_chain, global_stabs)
8871         (previous_stab_code, this_object_header_files)
8872         (n_this_object_header_files)
8873         (n_allocated_this_object_header_files): Define.
8874         * stabsread.h (EXTERN): Never define.  Use "extern".
8875
8876 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8877
8878         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8879         history_value.
8880
8881 2019-01-21  Tom Tromey  <tom@tromey.com>
8882
8883         * ui-out.c: Fix includes.
8884         * tui/tui-source.c: Fix includes.
8885         * target.c: Fix includes.
8886         * remote.c: Fix includes.
8887         * regcache.c: Fix includes.
8888         * python/py-block.c: Fix includes.
8889         * printcmd.c: Fix includes.
8890         * or1k-tdep.c: Fix includes.
8891         * mi/mi-main.c: Fix includes.
8892         * m32r-tdep.c: Fix includes.
8893         * csky-tdep.c: Fix includes.
8894         * compile/compile-cplus-types.c: Fix includes.
8895         * cli/cli-interp.c: Fix includes.
8896
8897 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8898
8899         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8900         for padding.
8901
8902 2019-01-16  Tom Tromey  <tom@tromey.com>
8903
8904         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8905         earlier.
8906         (struct objfile) <msymbols_range>: Move from top level.
8907         <msymbols>: New method.
8908         (class objfile_msymbols): Remove.
8909         * symtab.c (default_collect_symbol_completion_matches_break_on):
8910         Update.
8911         * symmisc.c (dump_msymbols): Update.
8912         * stabsread.c (scan_file_globals): Update.
8913         * objc-lang.c (info_selectors_command, info_classes_command)
8914         (find_methods): Update.
8915         * minsyms.c (find_solib_trampoline_target): Update.
8916         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8917         * coffread.c (coff_symfile_read): Update.
8918         * ada-lang.c (ada_lookup_simple_minsym)
8919         (ada_collect_symbol_completion_matches): Update.
8920
8921 2019-01-16  Tom Tromey  <tom@tromey.com>
8922
8923         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8924         type.  Remove no-argument constructor.
8925         <iterator::operator++>: Simplify.
8926         <begin>: Update.
8927         <end>: Use minimal_symbol_count.
8928
8929 2019-01-16  Tom Tromey  <tom@tromey.com>
8930
8931         * objfiles.h (struct objfile) <psymtabs>: New method.
8932         (class objfile_psymtabs): Remove.
8933         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8934         typedef.
8935         <range>: New method.
8936         (require_partial_symbols): Change return type.
8937         * psymtab.c (require_partial_symbols)
8938         (psym_expand_symtabs_matching): Update.
8939         * mdebugread.c (parse_partial_symbols): Update.
8940         * dbxread.c (dbx_end_psymtab): Update.
8941
8942 2019-01-15  Tom Tromey  <tom@tromey.com>
8943
8944         * symtab.c (lookup_objfile_from_block)
8945         (lookup_symbol_in_objfile_symtabs)
8946         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8947         (find_line_symtab, info_sources_command)
8948         (default_collect_symbol_completion_matches_break_on)
8949         (make_source_files_completion_list): Update.
8950         * symmisc.c (print_objfile_statistics, dump_objfile)
8951         (maintenance_print_symbols, maintenance_info_symtabs)
8952         (maintenance_check_symtabs, maintenance_info_line_tables):
8953         Update.
8954         * source.c (select_source_symtab)
8955         (forget_cached_source_info_for_objfile): Update.
8956         * objfiles.h (class objfile_compunits): Remove.
8957         (struct objfile) <compunits_range>: New typedef.
8958         (compunits): New method.
8959         * objfiles.c (objfile_relocate1): Update.
8960         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8961         * maint.c (count_symtabs_and_blocks): Update.
8962         * linespec.c (iterate_over_all_matching_symtabs): Update.
8963         * cp-support.c (add_symbol_overload_list_qualified): Update.
8964         * coffread.c (coff_symtab_read): Update.
8965         * ada-lang.c (add_nonlocal_symbols)
8966         (ada_collect_symbol_completion_matches)
8967         (ada_add_global_exceptions): Update.
8968
8969 2019-01-15  Tom Tromey  <tom@tromey.com>
8970
8971         * progspace.h (program_space) <objfiles_safe_range>: New
8972         typedef.
8973         <objfiles_safe>: New method.
8974         * objfiles.h (class all_objfiles_safe): Remove.
8975         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8976         * jit.c (jit_inferior_exit_hook): Update.
8977
8978 2019-01-17  Tom Tromey  <tom@tromey.com>
8979
8980         * progspace.h (program_space) <objfiles_range>: New typedef.
8981         <objfiles>: New method.
8982         <objfiles_head>: Rename from objfiles.
8983         (object_files): Update.
8984         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8985         * guile/scm-pretty-print.c
8986         (ppscm_find_pretty_printer_from_objfiles): Update.
8987         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8988         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8989         Update.
8990         * python/py-progspace.c (pspy_get_objfiles): Update.
8991         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8992         Update.
8993         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8994         (objfpy_lookup_objfile_by_build_id): Update.
8995         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8996         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8997         Update.
8998         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8999         (expand_symtab_containing_pc, lookup_objfile_from_block)
9000         (lookup_static_symbol, basic_lookup_transparent_type)
9001         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9002         (find_line_symtab, info_sources_command)
9003         (default_collect_symbol_completion_matches_break_on)
9004         (make_source_files_completion_list, find_main_name): Update.
9005         * symmisc.c (print_symbol_bcache_statistics)
9006         (print_objfile_statistics, maintenance_print_symbols)
9007         (maintenance_print_msymbols, maintenance_print_objfiles)
9008         (maintenance_info_symtabs, maintenance_check_symtabs)
9009         (maintenance_expand_symtabs, maintenance_info_line_tables):
9010         Update.
9011         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9012         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9013         (map_overlay_command, unmap_overlay_command)
9014         (simple_overlay_update, expand_symtabs_matching)
9015         (map_symbol_filenames): Update.
9016         * symfile-debug.c (set_debug_symfile): Update.
9017         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9018         Update.
9019         * source.c (select_source_symtab, forget_cached_source_info):
9020         Update.
9021         * solib.c (solib_read_symbols): Update.
9022         * solib-spu.c (append_ocl_sos): Update.
9023         * psymtab.c (maintenance_print_psymbols)
9024         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9025         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9026         * printcmd.c (info_symbol_command): Update.
9027         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9028         Update.
9029         * objfiles.h (class all_objfiles): Remove.
9030         * objfiles.c (have_partial_symbols, have_full_symbols)
9031         (have_minimal_symbols, qsort_cmp, update_section_map)
9032         (shared_objfile_contains_address_p)
9033         (default_iterate_over_objfiles_in_search_order): Update.
9034         * objc-lang.c (info_selectors_command, info_classes_command)
9035         (find_methods): Update.
9036         * minsyms.c (find_solib_trampoline_target): Update.
9037         * maint.c (maintenance_info_sections)
9038         (maintenance_translate_address, count_symtabs_and_blocks):
9039         Update.
9040         * main.c (captured_main_1): Update.
9041         * linux-thread-db.c (try_thread_db_load_from_pdir)
9042         (has_libpthread): Update.
9043         * linespec.c (iterate_over_all_matching_symtabs)
9044         (search_minsyms_for_name): Update.
9045         * jit.c (jit_find_objf_with_entry_addr): Update.
9046         * hppa-tdep.c (find_unwind_entry)
9047         (hppa_lookup_stub_minimal_symbol): Update.
9048         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9049         Update.
9050         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9051         (elf_gnu_ifunc_resolve_by_got): Update.
9052         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9053         * dwarf-index-write.c (save_gdb_index_command): Update.
9054         * cp-support.c (add_symbol_overload_list_qualified): Update.
9055         * breakpoint.c (create_overlay_event_breakpoint)
9056         (create_longjmp_master_breakpoint)
9057         (create_std_terminate_master_breakpoint)
9058         (create_exception_master_breakpoint): Update.
9059         * blockframe.c (find_pc_partial_function): Update.
9060         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9061         (ada_collect_symbol_completion_matches)
9062         (ada_add_global_exceptions): Update.
9063
9064 2019-01-17  Tom Tromey  <tom@tromey.com>
9065
9066         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9067         declare VEC.
9068         (solib_target_parse_libraries): Change return type.
9069         (library_list_start_segment, library_list_start_section)
9070         (library_list_end_library, library_list_start_library); Update.
9071         (solib_target_free_library_list): Remove.
9072         (solib_target_parse_libraries): Remove cleanup.  Change return
9073         type.
9074         (solib_target_current_sos): Update.
9075
9076 2019-01-17  Tom Tromey  <tromey@bapiya>
9077
9078         * valprint.c: Replace "the the" with "the".
9079         * symtab.c: Replace "the the" with "the".
9080         * solib.c: Replace "the the" with "the".
9081         * solib-dsbt.c: Replace "the the" with "the".
9082         * linespec.c: Replace "the the" with "the".
9083         * dwarf2loc.h: Replace "the the" with "the".
9084         * amd64-windows-tdep.c: Replace "the the" with "the".
9085         * aarch64-tdep.c: Replace "the the" with "the".
9086
9087 2019-01-16  Keith Seitz  <keiths@redhat.com>
9088
9089         PR gdb/23773
9090         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9091         <builder>: Rename to ..
9092         <m_builder>: ... this and make private.
9093         (dwarf2_cu::get_builder): New method.  Change all users of
9094         `builder' to use this method.
9095         (dwarf2_start_symtab): Move to ...
9096         (dwarf2_cu::start_symtab): ... here.  Update all callers
9097         (setup_type_unit_groups): Move to ...
9098         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9099         callers.
9100         (dwarf2_cu::reset_builder): New method.
9101         (process_full_compunit, process_full_type_unit): Use
9102         dwarf2_cu::reset_builder.
9103         (follow_die_offset): Record the ancestor CU if it is different
9104         from the followed DIE's CU.
9105         (follow_die_sig_1): Likewise.
9106
9107 2019-01-15  Tom Tromey  <tom@tromey.com>
9108
9109         * remote.c (class remote_state) <buf>: Now a char_vector.
9110         <buf_size>: Remove.
9111         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9112         parameter.
9113         (remote_target::getpkt_or_notif_sane_1)
9114         (remote_target::getpkt_sane)
9115         (remote_target::getpkt_or_notif_sane): Likewise.
9116         (class remote_target) <putpkt>: New overload.
9117         (remote_target::read_frame): Change type of "buf_p".  Remove
9118         sizeof_p parameter.
9119         (packet_ok): New overload.
9120         (packet_check_result): New overload.
9121         Update all uses.
9122
9123 2019-01-14  Tom Tromey  <tom@tromey.com>
9124
9125         * remote-notif.c (handle_notification, remote_notif_ack)
9126         (remote_notif_parse): Make "buf" const.
9127         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9128         const.
9129         (remote_notif_parse, remote_notif_ack, handle_notification):
9130         Likewise.
9131         * remote.c (remote_notif_stop_parse): Make "buf" const.
9132         (remote_target::remote_parse_stop_reply): Make "buf" const.
9133         (remote_notif_stop_ack): Make "buf" const.
9134
9135 2019-01-14  Tom Tromey  <tom@tromey.com>
9136
9137         * remote.c (remote_console_output): Make parameter const.
9138
9139 2019-01-14  Tom Tromey  <tom@tromey.com>
9140
9141         * target-debug.h (target_debug_print_signals): Constify.
9142         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9143         * procfs.c (procfs_target::pass_signals): Update.
9144         * linux-nat.c (linux_nat_target::pass_signals): Update.
9145         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9146         * target-delegates.c: Rebuild.
9147         * remote.c (remote_target::program_signals): Update.
9148         (remote_target::pass_signals): Update.
9149         * target.c (target_pass_signals): Constify argument.
9150         (target_program_signals): Likewise.
9151         * target.h (struct target_ops) <pass_signals, program_signals>:
9152         Constify argument.
9153         (target_pass_signals, target_program_signals): Constify argument.
9154
9155 2019-01-14  Tom Tromey  <tom@tromey.com>
9156
9157         PR tui/28819:
9158         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9159
9160 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9161
9162         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9163         field.
9164         * rs6000-tdep.c: Include reggroups.h.
9165         (IS_V_ALIAS_PSEUDOREG): Define.
9166         (rs6000_register_name): Return names for the "vX" aliases.
9167         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9168         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9169         aliases.  Call default_register_reggroup_p for all other
9170         pseudo-registers.
9171         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9172         New functions.
9173         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9174         Handle "vX" aliases.
9175         (v_alias_pseudo_register_collect): New function.
9176         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9177         (rs6000_gdbarch_init): Initialize "vX" aliases as
9178         pseudo-registers.  Restore registration of
9179         rs6000_pseudo_register_reggroup_p with
9180         set_tdesc_pseudo_register_reggroup_p.
9181
9182 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9183
9184         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9185         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9186         set_gdbarch_num_pseudo_regs.
9187
9188 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9189
9190         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9191         Remove arg prefixname, add do_set and do_show.
9192         Add member functions set_list and show_list.
9193         * cli/cli-style.c (class cli_style_option): Update accordingly.
9194         (style_set_list): Move to file scope.
9195         (style_show_list): Likewise.
9196         (set_style): Call help_list.
9197         (show_style): Call cmd_show_list.
9198         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9199         Update to use the new macro.
9200
9201 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9202
9203         * ada-lang.c (_initialize_ada_language): Expand the help text
9204         for the "catch exception" command.
9205
9206 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9207
9208         * symtab.c (matching_obj_sections): Initialize obj,
9209         declare it closer to its usage.
9210
9211 2019-01-10  Tom Tromey  <tom@tromey.com>
9212
9213         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9214         (basic_inf_threads_range): Remove.
9215         (inf_threads_range, inf_non_exited_threads_range)
9216         (safe_inf_threads_range): Use next_adapter.
9217
9218 2019-01-10  Keith Seitz  <keiths@redhat.com>
9219
9220         PR gdb/23712
9221         PR symtab/23010
9222         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9223         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9224
9225 2019-01-10  Keith Seitz  <keiths@redhat.com>
9226
9227         PR gdb/23712
9228         PR symtab/23010
9229         * dictionary.c (pending_to_vector): Remove.
9230         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9231         Remove _1 suffix, replacing functions of the same name.  Update
9232         all callers.
9233         (dict_create_hashed, dict_create_hashed_expandable)
9234         (dict_create_linear, dict_create_linear_expandable, dict_free)
9235         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9236         Make functions static.
9237
9238 2019-01-10  Keith Seitz  <keiths@redhat.com>
9239
9240         PR gdb/23712
9241         PR symtab/23010
9242         * dictionary.h (struct dictionary): Replace declaration with
9243         multidictionary.
9244         (dict_create_hashed, dict_create_hashed_expandable)
9245         (dict_create_linear, dict_create_linear_expandable)
9246         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9247         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9248         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9249         taking multidictionary argument.
9250         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9251         * block.h (struct block) <dict>: Change to multidictionary
9252         and rename `multidict'.
9253         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9254         symmisc.c: Update all dictionary references to multidictionary.
9255
9256 2019-01-10  Keith Seitz  <keiths@redhat.com>
9257
9258         PR gdb/23712
9259         PR symtab/23010
9260         * dictionary.c: Include unordered_map.
9261         (pending_to_vector): New function.
9262         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9263         Rewrite the non-"_1" functions to take vector instead
9264         of linked list.
9265         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9266         "new" _1 versions of the same name.
9267         (multidictionary): Define.
9268         (std::hash<enum language): New definition.
9269         (collate_pending_symbols_by_language, mdict_create_hashed)
9270         (mdict_create_hashed_expandable, mdict_create_linear)
9271         (mdict_create_linear_expandable, mdict_free)
9272         (find_language_dictionary, create_new_language_dictionary)
9273         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9274         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9275         (mdict_size, mdict_empty): New functions.
9276         * dictionary.h (mdict_iterator): Define.
9277
9278 2019-01-10  Pedro Alves  <palves@redhat.com>
9279
9280         * breakpoint.c (read_uploaded_action)
9281         (create_tracepoint_from_upload): Adjust to use
9282         gdb::unique_xmalloc_ptr.
9283         * ctf.c (ctf_write_uploaded_tp):
9284         (SET_ARRAY_FIELD): Use emplace_back.
9285         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9286         * tracefile-tfile.c (tfile_write_uploaded_tp):
9287         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9288         gdb::unique_xmalloc_ptr.
9289         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9290         at_string, cond_string, cmd_strings>: Replace char pointers
9291         with gdb::unique_xmalloc_ptr.
9292
9293 2019-01-10  Pedro Alves  <palves@redhat.com>
9294
9295         * solib-target.c (library_list_start_library): Don't xstrdup name.
9296
9297 2019-01-10  Pedro Alves  <palves@redhat.com>
9298
9299         * mdebugread.c (parse_partial_symbols): Use
9300         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9301
9302 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9303
9304         * linux-fork.c (scoped_switch_fork_info)
9305         <~scoped_switch_fork_info>: Fix incorrect variable name.
9306
9307 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9308
9309         * linux-fork.c (scoped_switch_fork_info)
9310         <scoped_switch_fork_info>: Make explicit.
9311         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9312
9313 2019-01-10  Tom Tromey  <tom@tromey.com>
9314
9315         * objfiles.h (objfile::reset_psymtabs): Update.
9316         * objfiles.c (objfile::objfile): Update.
9317         * psymtab.h (psymtab_storage::obstack): Update.
9318         (psymtab_storage::m_obstack): Use gdb::optional.
9319         (class psymtab_storage): Update comment.  Remove objfile
9320         parameter.
9321         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9322
9323 2019-01-10  Tom Tromey  <tom@tromey.com>
9324
9325         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9326         <free_psymtabs>: Now private.
9327         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9328         (allocate_psymtab): Use new method.
9329
9330 2019-01-10  Tom Tromey  <tom@tromey.com>
9331
9332         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9333         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9334         * mdebugread.c (parse_partial_symbols): Use
9335         allocate_dependencies.
9336         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9337         allocate_dependencies.
9338         (process_psymtab_comp_unit_reader)
9339         (build_type_psymtab_dependencies): Likewise.
9340         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9341
9342 2019-01-10  Tom Tromey  <tom@tromey.com>
9343
9344         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9345         PSYMBOL_SET_LANGUAGE.
9346         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9347
9348 2019-01-10  Tom Tromey  <tom@tromey.com>
9349
9350         * psymtab.h (psymtab_storage::obstack): New method.
9351         <m_obstack>: Rename from obstack; now private.
9352         * psymtab.c (psymtab_storage): Update.
9353         * dwarf2read.c (create_addrmap_from_index)
9354         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9355         Update.
9356
9357 2019-01-10  Tom Tromey  <tom@tromey.com>
9358
9359         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9360         * objfiles.h (objfile::reset_psymtabs): New method.
9361
9362 2019-01-10  Tom Tromey  <tom@tromey.com>
9363
9364         * symmisc.c (print_symbol_bcache_statistics): Update.
9365         (print_objfile_statistics): Update.
9366         * symfile.c (reread_symbols): Update.
9367         * psymtab.h (class psymtab_storage): New.
9368         * psymtab.c (psymtab_storage): New constructor.
9369         (~psymtab_storage): New destructor.
9370         (require_partial_symbols): Update.
9371         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9372         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9373         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9374         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9375         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9376         (start_psymtab_common, end_psymtab_common)
9377         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9378         (allocate_psymtab): Update.
9379         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9380         Update.
9381         (dump_psymtab_addrmap, maintenance_print_psymbols)
9382         (maintenance_check_psymtabs): Update.
9383         (class objfile_psymtabs): Move to objfiles.h.
9384         * psympriv.h (discard_psymtab): Now inline.
9385         (psymtab_discarder::psymtab_discarder): Update.
9386         (psymtab_discarder::~psymtab_discarder): Update.
9387         (ALL_OBJFILE_PSYMTABS): Rewrite.
9388         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9389         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9390         Remove fields.
9391         <partial_symtabs>: New field.
9392         (class objfile_psymtabs): Move from psymtab.h.  Update.
9393         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9394         psymbol_cache.
9395         (objfile::~objfile): Don't destroy psymbol_cache.
9396         * mdebugread.c (parse_partial_symbols): Update.
9397         * dwarf2read.c (create_addrmap_from_index)
9398         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9399         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9400         (add_partial_subprogram, dwarf2_ranges_read): Update.
9401         * dwarf-index-write.c (write_address_map)
9402         (write_one_signatured_type, recursively_write_psymbols)
9403         (class debug_names, class debug_names, write_psymtabs_to_index):
9404         Update.
9405
9406 2019-01-10  Tom Tromey  <tom@tromey.com>
9407
9408         * symtab.h (SYMBOL_SET_NAMES): Update.
9409         (symbol_set_names): Update.
9410         (MSYMBOL_SET_NAMES): Update.
9411         * symtab.c (symbol_set_names): Change argument to be an
9412         objfile_per_bfd_storage.
9413         * psymtab.c (add_psymbol_to_bcache): Update.
9414         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9415
9416 2019-01-10  Tom Tromey  <tom@tromey.com>
9417
9418         * symtab.c (create_demangled_names_hash): Change argument to be an
9419         objfile_per_bfd_storage.
9420         (symbol_set_names): Update.
9421
9422 2019-01-10  Tom Tromey  <tom@tromey.com>
9423
9424         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9425         init_psymbol_list.
9426         * psymtab.c (init_psymbol_list): Do nothing if already called.
9427         * psympriv.h (init_psymbol_list): Add comment.
9428         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9429         init_psymbol_list.
9430         * dbxread.c (dbx_symfile_read): Unconditionally call
9431         init_psymbol_list.
9432
9433 2019-01-10  Tom Tromey  <tom@tromey.com>
9434
9435         * xcoffread.c (scan_xcoff_symtab): Update.
9436         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9437         "where".
9438         * mdebugread.c (parse_partial_symbols)
9439         (handle_psymbol_enumerators): Update.
9440         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9441         * dbxread.c (read_dbx_symtab): Update.
9442         * psympriv.h (psymbol_placement): New enum.
9443         (add_psymbol_to_list): Update.
9444
9445 2019-01-10  Tom Tromey  <tom@tromey.com>
9446
9447         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9448         static_psymbols parameters.
9449         (scan_xcoff_symtab): Update.
9450         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9451         static_psymbols parameters.
9452         * psympriv.h (start_psymtab_common): Update.
9453         * mdebugread.c (parse_partial_symbols): Update.
9454         * dwarf2read.c (create_partial_symtab): Update.
9455         * dbxread.c (read_dbx_symtab): Update.
9456         (start_psymtab): Remove global_psymbols and static_psymbols
9457         parameters.
9458
9459 2019-01-10  Tom Tromey  <tom@tromey.com>
9460
9461         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9462         * psymtab.c (allocate_psymtab): Add comment.
9463         * psympriv.h (allocate_psymtab): Add comment.
9464         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9465         initializations.
9466         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9467
9468 2019-01-10  Tom Tromey  <tom@tromey.com>
9469
9470         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9471         Don't declare.
9472         * mipsread.c: Include mdebugread.h.
9473         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9474         Declare.
9475         * elfread.c: Include mdebugread.h.
9476
9477 2019-01-09  Tom Tromey  <tom@tromey.com>
9478
9479         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9480         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9481         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9482         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9483         (psym_lookup_symbol, psym_find_last_source_symtab)
9484         (psym_forget_cached_source_info, psym_print_stats)
9485         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9486         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9487         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9488         (psym_find_compunit_symtab_by_address)
9489         (maintenance_print_psymbols, maintenance_info_psymtabs)
9490         (maintenance_check_psymtabs): Use ranged for.
9491         * psymtab.h (class objfile_psymtabs): New.
9492         (require_partial_symbols): Return objfile_psymtabs.
9493         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9494
9495 2019-01-09  Tom Tromey  <tom@tromey.com>
9496
9497         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9498         (find_pc_mapped_section, list_overlays_command)
9499         (map_overlay_command, unmap_overlay_command)
9500         (simple_overlay_update): Use all_objfiles.
9501         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9502         * printcmd.c (info_symbol_command): Use all_objfiles.
9503         * objfiles.h (ALL_OBJSECTIONS): Remove.
9504         * maint.c (maintenance_translate_address): Use all_objfiles.
9505         * gcore.c (gcore_create_callback): Use all_objfiles.
9506         (objfile_find_memory_regions): Likewise.
9507
9508 2019-01-09  Tom Tromey  <tom@tromey.com>
9509
9510         * symtab.c (find_line_symtab, info_sources_command)
9511         (make_source_files_completion_list): Use objfile_compunits.
9512         * source.c (select_source_symtab): Use objfile_compunits.
9513         * objfiles.h (struct objfile): Update comment.
9514         (ALL_OBJFILES): Remove.
9515         (ALL_FILETABS): Remove.
9516         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9517         objfile_compunits.
9518
9519 2019-01-09  Tom Tromey  <tom@tromey.com>
9520
9521         * symmisc.c (print_objfile_statistics, dump_objfile)
9522         (maintenance_print_symbols): Use compunit_filetabs.
9523         * source.c (forget_cached_source_info_for_objfile): Use
9524         compunit_filetabs.
9525         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9526         (ALL_FILETABS): Use compunit_filetabs.
9527         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9528         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9529
9530 2019-01-09  Tom Tromey  <tom@tromey.com>
9531
9532         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9533         (compunit_filetabs): New.
9534         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9535         compunit_filetabs.
9536         (info_sources_command, make_source_files_completion_list): Remove
9537         declaration.
9538         * symmisc.c (print_objfile_statistics, dump_objfile)
9539         (maintenance_print_symbols): Remove declaration.
9540         (maintenance_info_symtabs): Use compunit_filetabs.
9541         (maintenance_info_line_tables): Likewise.
9542         * source.c (select_source_symtab): Change local variable name.
9543         (forget_cached_source_info_for_objfile): Remove declaration.
9544         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9545         * objfiles.c (objfile_relocate1): Remove declaration.
9546         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9547         declaration.
9548         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9549         * coffread.c (coff_symtab_read): Remove declaration.
9550         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9551         compunit_filetabs.
9552
9553 2019-01-09  Tom Tromey  <tom@tromey.com>
9554
9555         * symtab.c (lookup_objfile_from_block)
9556         (find_pc_sect_compunit_symtab, search_symbols)
9557         (default_collect_symbol_completion_matches_break_on): Use
9558         objfile_compunits.
9559         * objfiles.h (ALL_COMPUNITS): Remove.
9560         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9561         * cp-support.c (add_symbol_overload_list_qualified): Use
9562         objfile_compunits.
9563         * ada-lang.c (ada_collect_symbol_completion_matches)
9564         (ada_add_global_exceptions): Use objfile_compunits.
9565
9566 2019-01-09  Tom Tromey  <tom@tromey.com>
9567
9568         * source.c (select_source_symtab)
9569         (forget_cached_source_info_for_objfile): Remove declaration.
9570         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9571         declaration.
9572         * maint.c (count_symtabs_and_blocks): Remove declaration.
9573         * cp-support.c (add_symbol_overload_list_qualified): Remove
9574         declaration.
9575         * coffread.c (coff_symtab_read): Remove declaration.
9576         * symtab.c (lookup_symbol_in_objfile_symtabs)
9577         (basic_lookup_transparent_type_1): Use objfile_compunits.
9578         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9579         (info_sources_command, search_symbols)
9580         (default_collect_symbol_completion_matches_break_on)
9581         (make_source_files_completion_list): Remove declaration.
9582         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9583         (ada_collect_symbol_completion_matches)
9584         (ada_add_global_exceptions): Remove declaration.
9585         * linespec.c (iterate_over_all_matching_symtabs): Use
9586         objfile_compunits.
9587         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9588         (class objfile_compunits): New.
9589         (ALL_COMPUNITS): Use objfile_compunits.
9590         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9591         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9592         objfile_compunits.
9593         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9594
9595 2019-01-09  Tom Tromey  <tom@tromey.com>
9596
9597         * symtab.c (search_symbols)
9598         (default_collect_symbol_completion_matches_break_on): Use
9599         objfile_msymbols.
9600         * ada-lang.c (ada_lookup_simple_minsym)
9601         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9602         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9603         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9604         objfile_msymbols.
9605         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9606         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9607         * objc-lang.c (find_methods): Use objfile_msymbols.
9608         (info_selectors_command, info_classes_command): Likewise.
9609         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9610         * objfiles.h (class objfile_msymbols): New.
9611         (ALL_OBJFILE_MSYMBOLS): Remove.
9612         (ALL_MSYMBOLS): Remove.
9613
9614 2019-01-09  Tom Tromey  <tom@tromey.com>
9615
9616         * common/next-iterator.h (next_adapter): Add Iterator template
9617         parameter.
9618         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9619         (class all_objfiles_safe): New.
9620         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9621         * objfiles.c (put_objfile_before): Update comment.
9622         (add_separate_debug_objfile): Likewise.
9623         (free_all_objfiles): Use all_objfiles_safe.
9624         (objfile_purge_solibs): Likewise.
9625
9626 2019-01-09  Tom Tromey  <tom@tromey.com>
9627
9628         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9629         (expand_symtab_containing_pc, lookup_static_symbol)
9630         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9631         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9632         all_objfiles.
9633         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9634         * breakpoint.c (create_overlay_event_breakpoint)
9635         (create_longjmp_master_breakpoint)
9636         (create_std_terminate_master_breakpoint)
9637         (create_exception_master_breakpoint): Use all_objfiles.
9638         * linux-thread-db.c (try_thread_db_load_from_pdir)
9639         (has_libpthread): Use all_objfiles.
9640         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9641         * linespec.c (iterate_over_all_matching_symtabs)
9642         (search_minsyms_for_name): Use all_objfiles.
9643         * maint.c (maintenance_info_sections): Use all_objfiles.
9644         * main.c (captured_main_1): Use all_objfiles.
9645         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9646         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9647         * guile/scm-pretty-print.c
9648         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9649         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9650         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9651         (maintenance_print_msymbols): Use all_objfiles.
9652         * source.c (select_source_symtab): Use all_objfiles.
9653         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9654         * symfile.c (remove_symbol_file_command)
9655         (expand_symtabs_matching, map_symbol_filenames): Use
9656         all_objfiles.
9657         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9658         all_objfiles.
9659         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9660         * objc-lang.c (find_methods): Use all_objfiles.
9661         * objfiles.c (have_partial_symbols, have_full_symbols)
9662         (have_minimal_symbols, qsort_cmp)
9663         (default_iterate_over_objfiles_in_search_order): Use
9664         all_objfiles.
9665         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9666         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9667         (maintenance_check_psymtabs): Use all_objfiles.
9668         (ALL_PSYMTABS): Remove.
9669         * compile/compile-object-run.c (do_module_cleanup): Use
9670         all_objfiles.
9671         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9672         * cp-support.c (add_symbol_overload_list_qualified): Use
9673         all_objfiles.
9674         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9675         Use all_objfiles.
9676         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9677         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9678         all_objfiles.
9679         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9680         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9681         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9682         Uses all_objfiles.
9683         * solib.c (solib_read_symbols): Use all_objfiles
9684
9685 2019-01-09  Tom Tromey  <tom@tromey.com>
9686
9687         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9688         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9689         all_objfiles.
9690         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9691         * symmisc.c (print_symbol_bcache_statistics)
9692         (print_objfile_statistics, maintenance_print_objfiles)
9693         (maintenance_info_symtabs, maintenance_check_symtabs)
9694         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9695         all_objfiles.
9696         * source.c (forget_cached_source_info): Use all_objfiles.
9697         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9698         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9699         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9700         * objfiles.c (update_section_map): Use all_objfiles.
9701         (shared_objfile_contains_address_p): Likewise.
9702         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9703         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9704
9705 2019-01-09  Tom Tromey  <tom@tromey.com>
9706
9707         * common/next-iterator.h: New file.
9708         * objfiles.h (class all_objfiles): New.
9709         (struct objfile_iterator): New.
9710
9711 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9712
9713         * NEWS: Move the description of the changed "frame", "select-frame",
9714          and "info frame" commands to the Changed commands section.
9715
9716 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9717
9718         * gdbtypes.c (check_stub_method_group): Remove handling of old
9719         mangling schemes.
9720         * linespec.c (find_methods): Likewise.
9721         * stabsread.c (read_member_functions): Likewise.
9722         * valops.c (search_struct_method): Likewise.
9723         (value_struct_elt_for_reference): Likewise.
9724         * NEWS: Mention this change.
9725
9726 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9727
9728         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9729         print_source_lines.
9730         * source.c (print_source_lines_base): Update line number check.
9731         (print_source_lines): New function.
9732         (source_lines_range::source_lines_range): New function.
9733         * source.h (class source_lines_range): New class.
9734         (print_source_lines): New declaration.
9735
9736 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9737
9738         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9739
9740 2019-01-08  Tom Tromey  <tom@tromey.com>
9741             Simon Marchi  <simon.marchi@ericsson.com>
9742
9743         PR gdb/24060
9744         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9745         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9746         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9747         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9748         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9749         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9750
9751 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9752
9753         * source.c (select_source_symtab): Move header comment to
9754         declaration in source.h.
9755         (forget_cached_source_info_for_objfile): Likewise.
9756         (forget_cached_source_info): Likewise.
9757         (identify_source_line): Likewise.
9758         * source.h (identify_source_line): Move declaration from symtab.h
9759         and add comment from source.c
9760         (print_source_lines): Likewise.
9761         (forget_cached_source_info_for_objfile): Likewise.
9762         (forget_cached_source_info): Likewise.
9763         (select_source_symtab): Likewise.
9764         (enum print_source_lines_flag): Move definition from symtab.h.
9765         * symtab.h (identify_source_line): Move declaration to source.h.
9766         (print_source_lines): Likewise.
9767         (forget_cached_source_info_for_objfile): Likewise.
9768         (forget_cached_source_info): Likewise.
9769         (select_source_symtab): Likewise.
9770         (enum print_source_lines_flag): Move definition to source.h.
9771         * tui/tui-hooks.c: Add 'source.h' include.
9772
9773 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9774
9775         * source.c (print_source_lines_base): Handle requests to print
9776         reverse line number sequences, and guard against empty lines
9777         string.
9778
9779 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9780
9781         * source.c (print_source_lines_base): Fix skip of '\r' if next
9782         character is '\n'.
9783
9784 2019-01-06  Tom Tromey  <tom@tromey.com>
9785
9786         * c-exp.y (struct c_parse_state) <macro_original_text,
9787         expansion_obstack>: New member.
9788         (macro_original_text, expansion_obstack): Remove globals.
9789         (scan_macro_expansion, scanning_macro_expansion)
9790         (finished_macro_expansion): Update.
9791         (scan_macro_cleanup): Remove.
9792         (yylex, c_parse): Update.
9793
9794 2019-01-06  Tom Tromey  <tom@tromey.com>
9795
9796         * c-exp.y (struct c_parse_state) <strings>: New member.
9797         (operator_stoken): Update.
9798
9799 2019-01-06  Tom Tromey  <tom@tromey.com>
9800
9801         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9802         (union type_stack_elt) <typelist_val>: Now a pointer to
9803         std::vector.
9804         (type_stack_cleanup): Don't declare.
9805         (push_typelist): Update.
9806         * parse.c (pop_typelist): Return a std::vector.
9807         (push_typelist): Take a std::vector.
9808         (follow_types): Update.  Do not free args.
9809         (type_stack_cleanup): Remove.
9810         * c-exp.y (struct c_parse_state): New.
9811         (cpstate): New global.
9812         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9813         (nonempty_typelist): Update.
9814         (func_mod): Create a new vector.
9815         (c_parse): Create a c_parse_state.
9816         (check_parameter_typelist): Do not delete params.
9817         (function_method): Update.  Do not delete type_list.
9818
9819 2019-01-06  Tom Tromey  <tom@tromey.com>
9820
9821         PR gdb/28155:
9822         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9823         check_typedef.
9824         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9825         (print_return_value): Likewise.
9826
9827 2019-01-05  Tom Tromey  <tom@tromey.com>
9828
9829         * contrib/cleanup_check.py: Remove.
9830         * contrib/gcc-with-excheck: Remove.
9831         * contrib/exsummary.py: Remove.
9832         * contrib/excheck.py: Remove.
9833
9834 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9835
9836         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9837         NULL. Initialize tpprev to NULL instead of assigning it
9838         to NULL on the next statement.
9839         * windows-nat.c (windows_delete_thread): Remove check for
9840         main_thread_id before printing thread exit notifications.
9841         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9842         Remove thread ID check against main_thread_id.
9843         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9844         windows_delete_thread.
9845         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9846
9847 2019-01-04  Tom Tromey  <tom@tromey.com>
9848
9849         * compile/compile.c (_initialize_compile): Use upper case for
9850         metasyntactic variables.
9851         * symmisc.c (_initialize_symmisc): Use upper case for
9852         metasyntactic variables.
9853         * psymtab.c (_initialize_psymtab): Use upper case for
9854         metasyntactic variables.
9855         * demangle.c (demangle_command): Use upper case for metasyntactic
9856         variables.
9857         (_initialize_demangler): Likewise.
9858         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9859         variables.
9860
9861 2019-01-03  Tom Tromey  <tom@tromey.com>
9862
9863         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9864
9865 2019-01-03  Tom Tromey  <tom@tromey.com>
9866
9867         * python/py-symtab.c (salpy_str): Update.
9868         (struct salpy_sal_object) <symtab>: Now a PyObject.
9869         (salpy_dealloc): Update.
9870         (del_objfile_sal): Use gdbpy_ref.
9871
9872 2019-01-03  Tom Tromey  <tom@tromey.com>
9873
9874         * python/py-type.c (convert_field): Use new_reference.  Return
9875         gdbpy_ref.
9876         (make_fielditem): Return gdbpy_ref.
9877         (typy_fields): Update.
9878         (typy_getitem): Update.
9879         (field_name): Return gdbpy_ref.  Use new_reference.
9880         (typy_iterator_iternext): Update.
9881
9882 2019-01-03  Tom Tromey  <tom@tromey.com>
9883
9884         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9885
9886 2019-01-03  Tom Tromey  <tom@tromey.com>
9887
9888         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9889         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9890         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9891         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9892         (pspy_set_type_printers): Likewise.
9893         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9894         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9895         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9896         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9897         (objfpy_set_type_printers): Likewise.
9898
9899 2019-01-03  Tom Tromey  <tom@tromey.com>
9900
9901         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9902         (gdbpy_print_stack): Use gdbpy_err_fetch.
9903         * python/python-internal.h (class gdbpy_err_fetch): New class.
9904         (class gdbpy_enter) <m_error_type, m_error_value,
9905         m_error_traceback>: Remove.
9906         <m_error>: New member.
9907         (gdbpy_exception_to_string): Don't declare.
9908         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9909         * python/py-value.c (convert_value_from_python): Use
9910         gdbpy_err_fetch.
9911         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9912         gdbpy_exception_to_string.
9913         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9914         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9915         gdbpy_err_fetch.
9916
9917 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9918
9919         * linux-nat.c (delete_lwp_cleanup): Delete.
9920         (struct lwp_deleter): New struct.
9921         (lwp_info_up): New typedef.
9922         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9923         lwp_info_up.
9924
9925 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9926
9927         * linux-fork.c (class scoped_switch_fork_info): New class.
9928         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9929
9930 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9931
9932         * valops.c (find_overload_match): Remove use of null_cleanup, and
9933         calls to do_cleanups.
9934
9935 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9936
9937         * compile/compile-cplus-types.c
9938         (compile_cplus_instance::decl_name): Handle changes to
9939         cp_func_name.
9940         * cp-support.c (cp_func_name): Update header comment, update
9941         return type.
9942         * cp-support.h (cp_func_name): Update return type in declaration.
9943         * valops.c (find_overload_match): Move temp_func local to top
9944         level of function and change its type.  Use temp_func to hold and
9945         delete temporary string obtained from cp_func_name.
9946
9947 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9948
9949         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9950         gdb::char_vector, remove cleanup, and update uses of `msg`.
9951
9952 2019-01-03  Jim Wilson  <jimw@sifive.com>
9953
9954         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9955
9956 2019-01-02  Tom Tromey  <tom@tromey.com>
9957
9958         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9959         (tdesc_parse_xml): Remove cleanups.
9960         * target-descriptions.h (make_cleanup_free_target_description):
9961         Don't declare.
9962         (target_desc_deleter): New struct.
9963         (target_desc_up): New typedef.
9964         * target-descriptions.c (target_desc_deleter::operator()): Rename
9965         from free_target_description.
9966         (make_cleanup_free_target_description): Remove.
9967
9968 2019-01-02  Tom Tromey  <tom@tromey.com>
9969
9970         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9971         constructor, destructor.
9972         (linespec_parser): Remove typedef.
9973         (~linespec_parser): Rename from linespec_parser_delete.
9974         (linespec_lex_to_end, linespec_complete_label)
9975         (linespec_complete): Update.
9976         (decode_line_full): Remove cleanups.
9977         (decode_line_1): Update.
9978
9979 2019-01-02  Tom Tromey  <tom@tromey.com>
9980
9981         * python/python-internal.h (inferior_to_inferior_object): Change
9982         return type.
9983         * python/py-exitedevent.c (create_exited_event_object): Update.
9984         * python/py-inferior.c (inferior_to_inferior_object): Return
9985         gdbpy_ref.
9986         (python_new_inferior, python_inferior_deleted)
9987         (thread_to_thread_object, delete_thread_object)
9988         (build_inferior_list, gdbpy_selected_inferior): Update.
9989         * python/py-infthread.c (create_thread_object): Update.  Also fail
9990         if inferior_to_inferior_object fails.
9991
9992 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9993
9994         * inferior.h (class inferior) <displaced_step_state>: New field.
9995         * infrun.h (struct displaced_step_state): Move here from
9996         infrun.c.  Initialize fields, add constructor.
9997         <inf>: Remove field.
9998         <reset>: New method.
9999         * infrun.c (struct displaced_step_inferior_state): Move to
10000         infrun.h.
10001         (displaced_step_inferior_states): Remove.
10002         (get_displaced_stepping_state): Adust.
10003         (displaced_step_in_progress_any_inferior): Adjust.
10004         (displaced_step_in_progress_thread): Adjust.
10005         (displaced_step_in_progress): Adjust.
10006         (add_displaced_stepping_state): Remove.
10007         (get_displaced_step_closure_by_addr): Adjust.
10008         (remove_displaced_stepping_state): Remove.
10009         (infrun_inferior_exit): Call displaced_step_state.reset.
10010         (use_displaced_stepping): Don't check for NULL.
10011         (displaced_step_prepare_throw): Call
10012         get_displaced_stepping_state.
10013         (displaced_step_fixup): Don't check for NULL.
10014         (prepare_for_detach): Don't check for NULL.
10015
10016 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10017
10018         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10019          in case of call that did not complete.
10020
10021 2019-01-02  Andrey Utkin  <autkin@undo.io>
10022
10023         * symfile.c (find_separate_debug_file): Fix search of debug files for
10024         remote debuggee.
10025
10026 2019-01-02  Tom Tromey  <tom@tromey.com>
10027
10028         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10029         indentation.
10030         * python/py-frame.c (frapy_older): Remove cast.
10031         (frapy_newer): Likewise.
10032         * python/py-breakpoint.c (local_setattro): Remove cast.
10033         * python/py-arch.c (archpy_name): Remove local variable.
10034         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10035
10036 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10037
10038         * unittests/basic_string_view/element_access/char/empty.cc:
10039         Fix year range in copyright header.
10040
10041 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10042
10043         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10044         Delete.
10045         <operator==>: Update with for removed field.
10046         <hash>: Likewise.
10047         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10048         <isa_features>: ...this.
10049         <abi_features>: New field.
10050         (riscv_isa_flen): Update comment.
10051         (riscv_abi_xlen): New declaration.
10052         (riscv_abi_flen): New declaration.
10053         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10054         isa_features.
10055         (riscv_abi_xlen): New function.
10056         (riscv_isa_flen): Update to get answer from isa_features.
10057         (riscv_abi_flen): New function.
10058         (riscv_has_fp_abi): Update to get answer from abi_features.
10059         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10060         xlen and flen.
10061         (riscv_call_info) <xlen, flen>: Update comment.
10062         (riscv_call_arg_struct): Remove invalid assertions
10063         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10064         is removed.
10065         (riscv_gdbarch_init): Gather isa features and abi features
10066         separately, ensure both match on the gdbarch when reusing an old
10067         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10068         a target with 64-bit float hardware.
10069
10070 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10071
10072         * source.c (search_command_helper): Stop reverse search
10073         when line 1 has been searched.
10074
10075 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10076
10077         * record-full.c (record_full_base_target::close): Rewrite
10078         record_full_core_buf_list free logic.
10079
10080 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10081
10082         * break-catch-syscall.c (print_one_catch_syscall): xfree
10083         the last text.
10084
10085 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10086
10087         * top.c (print_gdb_version): Update Copyright year in version
10088         message.
10089
10090 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10091
10092         Update copyright year range in all GDB files.
10093
10094 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10095
10096         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10097
10098 For older changes see ChangeLog-2018.
10099 \f
10100 Local Variables:
10101 mode: change-log
10102 left-margin: 8
10103 fill-column: 74
10104 version-control: never
10105 coding: utf-8
10106 End:
10107