gdb/ChangeLog

   1 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
   4         history_value.
   5
   6 2019-01-21  Tom Tromey  <tom@tromey.com>
   7
   8         * ui-out.c: Fix includes.
   9         * tui/tui-source.c: Fix includes.
  10         * target.c: Fix includes.
  11         * remote.c: Fix includes.
  12         * regcache.c: Fix includes.
  13         * python/py-block.c: Fix includes.
  14         * printcmd.c: Fix includes.
  15         * or1k-tdep.c: Fix includes.
  16         * mi/mi-main.c: Fix includes.
  17         * m32r-tdep.c: Fix includes.
  18         * csky-tdep.c: Fix includes.
  19         * compile/compile-cplus-types.c: Fix includes.
  20         * cli/cli-interp.c: Fix includes.
  21
  22 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
  23
  24         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
  25         for padding.
  26
  27 2019-01-16  Tom Tromey  <tom@tromey.com>
  28
  29         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
  30         earlier.
  31         (struct objfile) <msymbols_range>: Move from top level.
  32         <msymbols>: New method.
  33         (class objfile_msymbols): Remove.
  34         * symtab.c (default_collect_symbol_completion_matches_break_on):
  35         Update.
  36         * symmisc.c (dump_msymbols): Update.
  37         * stabsread.c (scan_file_globals): Update.
  38         * objc-lang.c (info_selectors_command, info_classes_command)
  39         (find_methods): Update.
  40         * minsyms.c (find_solib_trampoline_target): Update.
  41         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
  42         * coffread.c (coff_symfile_read): Update.
  43         * ada-lang.c (ada_lookup_simple_minsym)
  44         (ada_collect_symbol_completion_matches): Update.
  45
  46 2019-01-16  Tom Tromey  <tom@tromey.com>
  47
  48         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
  49         type.  Remove no-argument constructor.
  50         <iterator::operator++>: Simplify.
  51         <begin>: Update.
  52         <end>: Use minimal_symbol_count.
  53
  54 2019-01-16  Tom Tromey  <tom@tromey.com>
  55
  56         * objfiles.h (struct objfile) <psymtabs>: New method.
  57         (class objfile_psymtabs): Remove.
  58         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
  59         typedef.
  60         <range>: New method.
  61         (require_partial_symbols): Change return type.
  62         * psymtab.c (require_partial_symbols)
  63         (psym_expand_symtabs_matching): Update.
  64         * mdebugread.c (parse_partial_symbols): Update.
  65         * dbxread.c (dbx_end_psymtab): Update.
  66
  67 2019-01-15  Tom Tromey  <tom@tromey.com>
  68
  69         * symtab.c (lookup_objfile_from_block)
  70         (lookup_symbol_in_objfile_symtabs)
  71         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
  72         (find_line_symtab, info_sources_command)
  73         (default_collect_symbol_completion_matches_break_on)
  74         (make_source_files_completion_list): Update.
  75         * symmisc.c (print_objfile_statistics, dump_objfile)
  76         (maintenance_print_symbols, maintenance_info_symtabs)
  77         (maintenance_check_symtabs, maintenance_info_line_tables):
  78         Update.
  79         * source.c (select_source_symtab)
  80         (forget_cached_source_info_for_objfile): Update.
  81         * objfiles.h (class objfile_compunits): Remove.
  82         (struct objfile) <compunits_range>: New typedef.
  83         (compunits): New method.
  84         * objfiles.c (objfile_relocate1): Update.
  85         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
  86         * maint.c (count_symtabs_and_blocks): Update.
  87         * linespec.c (iterate_over_all_matching_symtabs): Update.
  88         * cp-support.c (add_symbol_overload_list_qualified): Update.
  89         * coffread.c (coff_symtab_read): Update.
  90         * ada-lang.c (add_nonlocal_symbols)
  91         (ada_collect_symbol_completion_matches)
  92         (ada_add_global_exceptions): Update.
  93
  94 2019-01-15  Tom Tromey  <tom@tromey.com>
  95
  96         * progspace.h (program_space) <objfiles_safe_range>: New
  97         typedef.
  98         <objfiles_safe>: New method.
  99         * objfiles.h (class all_objfiles_safe): Remove.
 100         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 101         * jit.c (jit_inferior_exit_hook): Update.
 102
 103 2019-01-17  Tom Tromey  <tom@tromey.com>
 104
 105         * progspace.h (program_space) <objfiles_range>: New typedef.
 106         <objfiles>: New method.
 107         <objfiles_head>: Rename from objfiles.
 108         (object_files): Update.
 109         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 110         * guile/scm-pretty-print.c
 111         (ppscm_find_pretty_printer_from_objfiles): Update.
 112         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 113         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 114         Update.
 115         * python/py-progspace.c (pspy_get_objfiles): Update.
 116         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 117         Update.
 118         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 119         (objfpy_lookup_objfile_by_build_id): Update.
 120         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 121         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 122         Update.
 123         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 124         (expand_symtab_containing_pc, lookup_objfile_from_block)
 125         (lookup_static_symbol, basic_lookup_transparent_type)
 126         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 127         (find_line_symtab, info_sources_command)
 128         (default_collect_symbol_completion_matches_break_on)
 129         (make_source_files_completion_list, find_main_name): Update.
 130         * symmisc.c (print_symbol_bcache_statistics)
 131         (print_objfile_statistics, maintenance_print_symbols)
 132         (maintenance_print_msymbols, maintenance_print_objfiles)
 133         (maintenance_info_symtabs, maintenance_check_symtabs)
 134         (maintenance_expand_symtabs, maintenance_info_line_tables):
 135         Update.
 136         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 137         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 138         (map_overlay_command, unmap_overlay_command)
 139         (simple_overlay_update, expand_symtabs_matching)
 140         (map_symbol_filenames): Update.
 141         * symfile-debug.c (set_debug_symfile): Update.
 142         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 143         Update.
 144         * source.c (select_source_symtab, forget_cached_source_info):
 145         Update.
 146         * solib.c (solib_read_symbols): Update.
 147         * solib-spu.c (append_ocl_sos): Update.
 148         * psymtab.c (maintenance_print_psymbols)
 149         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 150         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 151         * printcmd.c (info_symbol_command): Update.
 152         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 153         Update.
 154         * objfiles.h (class all_objfiles): Remove.
 155         * objfiles.c (have_partial_symbols, have_full_symbols)
 156         (have_minimal_symbols, qsort_cmp, update_section_map)
 157         (shared_objfile_contains_address_p)
 158         (default_iterate_over_objfiles_in_search_order): Update.
 159         * objc-lang.c (info_selectors_command, info_classes_command)
 160         (find_methods): Update.
 161         * minsyms.c (find_solib_trampoline_target): Update.
 162         * maint.c (maintenance_info_sections)
 163         (maintenance_translate_address, count_symtabs_and_blocks):
 164         Update.
 165         * main.c (captured_main_1): Update.
 166         * linux-thread-db.c (try_thread_db_load_from_pdir)
 167         (has_libpthread): Update.
 168         * linespec.c (iterate_over_all_matching_symtabs)
 169         (search_minsyms_for_name): Update.
 170         * jit.c (jit_find_objf_with_entry_addr): Update.
 171         * hppa-tdep.c (find_unwind_entry)
 172         (hppa_lookup_stub_minimal_symbol): Update.
 173         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 174         Update.
 175         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 176         (elf_gnu_ifunc_resolve_by_got): Update.
 177         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 178         * dwarf-index-write.c (save_gdb_index_command): Update.
 179         * cp-support.c (add_symbol_overload_list_qualified): Update.
 180         * breakpoint.c (create_overlay_event_breakpoint)
 181         (create_longjmp_master_breakpoint)
 182         (create_std_terminate_master_breakpoint)
 183         (create_exception_master_breakpoint): Update.
 184         * blockframe.c (find_pc_partial_function): Update.
 185         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 186         (ada_collect_symbol_completion_matches)
 187         (ada_add_global_exceptions): Update.
 188
 189 2019-01-17  Tom Tromey  <tom@tromey.com>
 190
 191         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 192         declare VEC.
 193         (solib_target_parse_libraries): Change return type.
 194         (library_list_start_segment, library_list_start_section)
 195         (library_list_end_library, library_list_start_library); Update.
 196         (solib_target_free_library_list): Remove.
 197         (solib_target_parse_libraries): Remove cleanup.  Change return
 198         type.
 199         (solib_target_current_sos): Update.
 200
 201 2019-01-17  Tom Tromey  <tromey@bapiya>
 202
 203         * valprint.c: Replace "the the" with "the".
 204         * symtab.c: Replace "the the" with "the".
 205         * solib.c: Replace "the the" with "the".
 206         * solib-dsbt.c: Replace "the the" with "the".
 207         * linespec.c: Replace "the the" with "the".
 208         * dwarf2loc.h: Replace "the the" with "the".
 209         * amd64-windows-tdep.c: Replace "the the" with "the".
 210         * aarch64-tdep.c: Replace "the the" with "the".
 211
 212 2019-01-16  Keith Seitz  <keiths@redhat.com>
 213
 214         PR gdb/23773
 215         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 216         <builder>: Rename to ..
 217         <m_builder>: ... this and make private.
 218         (dwarf2_cu::get_builder): New method.  Change all users of
 219         `builder' to use this method.
 220         (dwarf2_start_symtab): Move to ...
 221         (dwarf2_cu::start_symtab): ... here.  Update all callers
 222         (setup_type_unit_groups): Move to ...
 223         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 224         callers.
 225         (dwarf2_cu::reset_builder): New method.
 226         (process_full_compunit, process_full_type_unit): Use
 227         dwarf2_cu::reset_builder.
 228         (follow_die_offset): Record the ancestor CU if it is different
 229         from the followed DIE's CU.
 230         (follow_die_sig_1): Likewise.
 231
 232 2019-01-15  Tom Tromey  <tom@tromey.com>
 233
 234         * remote.c (class remote_state) <buf>: Now a char_vector.
 235         <buf_size>: Remove.
 236         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 237         parameter.
 238         (remote_target::getpkt_or_notif_sane_1)
 239         (remote_target::getpkt_sane)
 240         (remote_target::getpkt_or_notif_sane): Likewise.
 241         (class remote_target) <putpkt>: New overload.
 242         (remote_target::read_frame): Change type of "buf_p".  Remove
 243         sizeof_p parameter.
 244         (packet_ok): New overload.
 245         (packet_check_result): New overload.
 246         Update all uses.
 247
 248 2019-01-14  Tom Tromey  <tom@tromey.com>
 249
 250         * remote-notif.c (handle_notification, remote_notif_ack)
 251         (remote_notif_parse): Make "buf" const.
 252         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 253         const.
 254         (remote_notif_parse, remote_notif_ack, handle_notification):
 255         Likewise.
 256         * remote.c (remote_notif_stop_parse): Make "buf" const.
 257         (remote_target::remote_parse_stop_reply): Make "buf" const.
 258         (remote_notif_stop_ack): Make "buf" const.
 259
 260 2019-01-14  Tom Tromey  <tom@tromey.com>
 261
 262         * remote.c (remote_console_output): Make parameter const.
 263
 264 2019-01-14  Tom Tromey  <tom@tromey.com>
 265
 266         * target-debug.h (target_debug_print_signals): Constify.
 267         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 268         * procfs.c (procfs_target::pass_signals): Update.
 269         * linux-nat.c (linux_nat_target::pass_signals): Update.
 270         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 271         * target-delegates.c: Rebuild.
 272         * remote.c (remote_target::program_signals): Update.
 273         (remote_target::pass_signals): Update.
 274         * target.c (target_pass_signals): Constify argument.
 275         (target_program_signals): Likewise.
 276         * target.h (struct target_ops) <pass_signals, program_signals>:
 277         Constify argument.
 278         (target_pass_signals, target_program_signals): Constify argument.
 279
 280 2019-01-14  Tom Tromey  <tom@tromey.com>
 281
 282         PR tui/28819:
 283         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 284
 285 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 286
 287         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 288         field.
 289         * rs6000-tdep.c: Include reggroups.h.
 290         (IS_V_ALIAS_PSEUDOREG): Define.
 291         (rs6000_register_name): Return names for the "vX" aliases.
 292         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 293         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 294         aliases.  Call default_register_reggroup_p for all other
 295         pseudo-registers.
 296         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 297         New functions.
 298         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 299         Handle "vX" aliases.
 300         (v_alias_pseudo_register_collect): New function.
 301         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 302         (rs6000_gdbarch_init): Initialize "vX" aliases as
 303         pseudo-registers.  Restore registration of
 304         rs6000_pseudo_register_reggroup_p with
 305         set_tdesc_pseudo_register_reggroup_p.
 306
 307 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 308
 309         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 310         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 311         set_gdbarch_num_pseudo_regs.
 312
 313 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 314
 315         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 316         Remove arg prefixname, add do_set and do_show.
 317         Add member functions set_list and show_list.
 318         * cli/cli-style.c (class cli_style_option): Update accordingly.
 319         (style_set_list): Move to file scope.
 320         (style_show_list): Likewise.
 321         (set_style): Call help_list.
 322         (show_style): Call cmd_show_list.
 323         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 324         Update to use the new macro.
 325
 326 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 327
 328         * ada-lang.c (_initialize_ada_language): Expand the help text
 329         for the "catch exception" command.
 330
 331 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 332
 333         * symtab.c (matching_obj_sections): Initialize obj,
 334         declare it closer to its usage.
 335
 336 2019-01-10  Tom Tromey  <tom@tromey.com>
 337
 338         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 339         (basic_inf_threads_range): Remove.
 340         (inf_threads_range, inf_non_exited_threads_range)
 341         (safe_inf_threads_range): Use next_adapter.
 342
 343 2019-01-10  Keith Seitz  <keiths@redhat.com>
 344
 345         PR gdb/23712
 346         PR symtab/23010
 347         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 348         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 349
 350 2019-01-10  Keith Seitz  <keiths@redhat.com>
 351
 352         PR gdb/23712
 353         PR symtab/23010
 354         * dictionary.c (pending_to_vector): Remove.
 355         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 356         Remove _1 suffix, replacing functions of the same name.  Update
 357         all callers.
 358         (dict_create_hashed, dict_create_hashed_expandable)
 359         (dict_create_linear, dict_create_linear_expandable, dict_free)
 360         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 361         Make functions static.
 362
 363 2019-01-10  Keith Seitz  <keiths@redhat.com>
 364
 365         PR gdb/23712
 366         PR symtab/23010
 367         * dictionary.h (struct dictionary): Replace declaration with
 368         multidictionary.
 369         (dict_create_hashed, dict_create_hashed_expandable)
 370         (dict_create_linear, dict_create_linear_expandable)
 371         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 372         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 373         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 374         taking multidictionary argument.
 375         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 376         * block.h (struct block) <dict>: Change to multidictionary
 377         and rename `multidict'.
 378         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 379         symmisc.c: Update all dictionary references to multidictionary.
 380
 381 2019-01-10  Keith Seitz  <keiths@redhat.com>
 382
 383         PR gdb/23712
 384         PR symtab/23010
 385         * dictionary.c: Include unordered_map.
 386         (pending_to_vector): New function.
 387         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 388         Rewrite the non-"_1" functions to take vector instead
 389         of linked list.
 390         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 391         "new" _1 versions of the same name.
 392         (multidictionary): Define.
 393         (std::hash<enum language): New definition.
 394         (collate_pending_symbols_by_language, mdict_create_hashed)
 395         (mdict_create_hashed_expandable, mdict_create_linear)
 396         (mdict_create_linear_expandable, mdict_free)
 397         (find_language_dictionary, create_new_language_dictionary)
 398         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 399         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 400         (mdict_size, mdict_empty): New functions.
 401         * dictionary.h (mdict_iterator): Define.
 402
 403 2019-01-10  Pedro Alves  <palves@redhat.com>
 404
 405         * breakpoint.c (read_uploaded_action)
 406         (create_tracepoint_from_upload): Adjust to use
 407         gdb::unique_xmalloc_ptr.
 408         * ctf.c (ctf_write_uploaded_tp):
 409         (SET_ARRAY_FIELD): Use emplace_back.
 410         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 411         * tracefile-tfile.c (tfile_write_uploaded_tp):
 412         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 413         gdb::unique_xmalloc_ptr.
 414         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 415         at_string, cond_string, cmd_strings>: Replace char pointers
 416         with gdb::unique_xmalloc_ptr.
 417
 418 2019-01-10  Pedro Alves  <palves@redhat.com>
 419
 420         * solib-target.c (library_list_start_library): Don't xstrdup name.
 421
 422 2019-01-10  Pedro Alves  <palves@redhat.com>
 423
 424         * mdebugread.c (parse_partial_symbols): Use
 425         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 426
 427 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 428
 429         * linux-fork.c (scoped_switch_fork_info)
 430         <~scoped_switch_fork_info>: Fix incorrect variable name.
 431
 432 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 433
 434         * linux-fork.c (scoped_switch_fork_info)
 435         <scoped_switch_fork_info>: Make explicit.
 436         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 437
 438 2019-01-10  Tom Tromey  <tom@tromey.com>
 439
 440         * objfiles.h (objfile::reset_psymtabs): Update.
 441         * objfiles.c (objfile::objfile): Update.
 442         * psymtab.h (psymtab_storage::obstack): Update.
 443         (psymtab_storage::m_obstack): Use gdb::optional.
 444         (class psymtab_storage): Update comment.  Remove objfile
 445         parameter.
 446         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 447
 448 2019-01-10  Tom Tromey  <tom@tromey.com>
 449
 450         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 451         <free_psymtabs>: Now private.
 452         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 453         (allocate_psymtab): Use new method.
 454
 455 2019-01-10  Tom Tromey  <tom@tromey.com>
 456
 457         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 458         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 459         * mdebugread.c (parse_partial_symbols): Use
 460         allocate_dependencies.
 461         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 462         allocate_dependencies.
 463         (process_psymtab_comp_unit_reader)
 464         (build_type_psymtab_dependencies): Likewise.
 465         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 466
 467 2019-01-10  Tom Tromey  <tom@tromey.com>
 468
 469         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 470         PSYMBOL_SET_LANGUAGE.
 471         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 472
 473 2019-01-10  Tom Tromey  <tom@tromey.com>
 474
 475         * psymtab.h (psymtab_storage::obstack): New method.
 476         <m_obstack>: Rename from obstack; now private.
 477         * psymtab.c (psymtab_storage): Update.
 478         * dwarf2read.c (create_addrmap_from_index)
 479         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 480         Update.
 481
 482 2019-01-10  Tom Tromey  <tom@tromey.com>
 483
 484         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 485         * objfiles.h (objfile::reset_psymtabs): New method.
 486
 487 2019-01-10  Tom Tromey  <tom@tromey.com>
 488
 489         * symmisc.c (print_symbol_bcache_statistics): Update.
 490         (print_objfile_statistics): Update.
 491         * symfile.c (reread_symbols): Update.
 492         * psymtab.h (class psymtab_storage): New.
 493         * psymtab.c (psymtab_storage): New constructor.
 494         (~psymtab_storage): New destructor.
 495         (require_partial_symbols): Update.
 496         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 497         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 498         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 499         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 500         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 501         (start_psymtab_common, end_psymtab_common)
 502         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 503         (allocate_psymtab): Update.
 504         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 505         Update.
 506         (dump_psymtab_addrmap, maintenance_print_psymbols)
 507         (maintenance_check_psymtabs): Update.
 508         (class objfile_psymtabs): Move to objfiles.h.
 509         * psympriv.h (discard_psymtab): Now inline.
 510         (psymtab_discarder::psymtab_discarder): Update.
 511         (psymtab_discarder::~psymtab_discarder): Update.
 512         (ALL_OBJFILE_PSYMTABS): Rewrite.
 513         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 514         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 515         Remove fields.
 516         <partial_symtabs>: New field.
 517         (class objfile_psymtabs): Move from psymtab.h.  Update.
 518         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 519         psymbol_cache.
 520         (objfile::~objfile): Don't destroy psymbol_cache.
 521         * mdebugread.c (parse_partial_symbols): Update.
 522         * dwarf2read.c (create_addrmap_from_index)
 523         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 524         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 525         (add_partial_subprogram, dwarf2_ranges_read): Update.
 526         * dwarf-index-write.c (write_address_map)
 527         (write_one_signatured_type, recursively_write_psymbols)
 528         (class debug_names, class debug_names, write_psymtabs_to_index):
 529         Update.
 530
 531 2019-01-10  Tom Tromey  <tom@tromey.com>
 532
 533         * symtab.h (SYMBOL_SET_NAMES): Update.
 534         (symbol_set_names): Update.
 535         (MSYMBOL_SET_NAMES): Update.
 536         * symtab.c (symbol_set_names): Change argument to be an
 537         objfile_per_bfd_storage.
 538         * psymtab.c (add_psymbol_to_bcache): Update.
 539         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 540
 541 2019-01-10  Tom Tromey  <tom@tromey.com>
 542
 543         * symtab.c (create_demangled_names_hash): Change argument to be an
 544         objfile_per_bfd_storage.
 545         (symbol_set_names): Update.
 546
 547 2019-01-10  Tom Tromey  <tom@tromey.com>
 548
 549         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 550         init_psymbol_list.
 551         * psymtab.c (init_psymbol_list): Do nothing if already called.
 552         * psympriv.h (init_psymbol_list): Add comment.
 553         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 554         init_psymbol_list.
 555         * dbxread.c (dbx_symfile_read): Unconditionally call
 556         init_psymbol_list.
 557
 558 2019-01-10  Tom Tromey  <tom@tromey.com>
 559
 560         * xcoffread.c (scan_xcoff_symtab): Update.
 561         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 562         "where".
 563         * mdebugread.c (parse_partial_symbols)
 564         (handle_psymbol_enumerators): Update.
 565         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 566         * dbxread.c (read_dbx_symtab): Update.
 567         * psympriv.h (psymbol_placement): New enum.
 568         (add_psymbol_to_list): Update.
 569
 570 2019-01-10  Tom Tromey  <tom@tromey.com>
 571
 572         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 573         static_psymbols parameters.
 574         (scan_xcoff_symtab): Update.
 575         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 576         static_psymbols parameters.
 577         * psympriv.h (start_psymtab_common): Update.
 578         * mdebugread.c (parse_partial_symbols): Update.
 579         * dwarf2read.c (create_partial_symtab): Update.
 580         * dbxread.c (read_dbx_symtab): Update.
 581         (start_psymtab): Remove global_psymbols and static_psymbols
 582         parameters.
 583
 584 2019-01-10  Tom Tromey  <tom@tromey.com>
 585
 586         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 587         * psymtab.c (allocate_psymtab): Add comment.
 588         * psympriv.h (allocate_psymtab): Add comment.
 589         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 590         initializations.
 591         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 592
 593 2019-01-10  Tom Tromey  <tom@tromey.com>
 594
 595         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 596         Don't declare.
 597         * mipsread.c: Include mdebugread.h.
 598         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 599         Declare.
 600         * elfread.c: Include mdebugread.h.
 601
 602 2019-01-09  Tom Tromey  <tom@tromey.com>
 603
 604         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 605         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 606         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 607         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 608         (psym_lookup_symbol, psym_find_last_source_symtab)
 609         (psym_forget_cached_source_info, psym_print_stats)
 610         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 611         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 612         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 613         (psym_find_compunit_symtab_by_address)
 614         (maintenance_print_psymbols, maintenance_info_psymtabs)
 615         (maintenance_check_psymtabs): Use ranged for.
 616         * psymtab.h (class objfile_psymtabs): New.
 617         (require_partial_symbols): Return objfile_psymtabs.
 618         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 619
 620 2019-01-09  Tom Tromey  <tom@tromey.com>
 621
 622         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 623         (find_pc_mapped_section, list_overlays_command)
 624         (map_overlay_command, unmap_overlay_command)
 625         (simple_overlay_update): Use all_objfiles.
 626         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 627         * printcmd.c (info_symbol_command): Use all_objfiles.
 628         * objfiles.h (ALL_OBJSECTIONS): Remove.
 629         * maint.c (maintenance_translate_address): Use all_objfiles.
 630         * gcore.c (gcore_create_callback): Use all_objfiles.
 631         (objfile_find_memory_regions): Likewise.
 632
 633 2019-01-09  Tom Tromey  <tom@tromey.com>
 634
 635         * symtab.c (find_line_symtab, info_sources_command)
 636         (make_source_files_completion_list): Use objfile_compunits.
 637         * source.c (select_source_symtab): Use objfile_compunits.
 638         * objfiles.h (struct objfile): Update comment.
 639         (ALL_OBJFILES): Remove.
 640         (ALL_FILETABS): Remove.
 641         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 642         objfile_compunits.
 643
 644 2019-01-09  Tom Tromey  <tom@tromey.com>
 645
 646         * symmisc.c (print_objfile_statistics, dump_objfile)
 647         (maintenance_print_symbols): Use compunit_filetabs.
 648         * source.c (forget_cached_source_info_for_objfile): Use
 649         compunit_filetabs.
 650         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 651         (ALL_FILETABS): Use compunit_filetabs.
 652         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 653         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 654
 655 2019-01-09  Tom Tromey  <tom@tromey.com>
 656
 657         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 658         (compunit_filetabs): New.
 659         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 660         compunit_filetabs.
 661         (info_sources_command, make_source_files_completion_list): Remove
 662         declaration.
 663         * symmisc.c (print_objfile_statistics, dump_objfile)
 664         (maintenance_print_symbols): Remove declaration.
 665         (maintenance_info_symtabs): Use compunit_filetabs.
 666         (maintenance_info_line_tables): Likewise.
 667         * source.c (select_source_symtab): Change local variable name.
 668         (forget_cached_source_info_for_objfile): Remove declaration.
 669         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 670         * objfiles.c (objfile_relocate1): Remove declaration.
 671         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 672         declaration.
 673         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 674         * coffread.c (coff_symtab_read): Remove declaration.
 675         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 676         compunit_filetabs.
 677
 678 2019-01-09  Tom Tromey  <tom@tromey.com>
 679
 680         * symtab.c (lookup_objfile_from_block)
 681         (find_pc_sect_compunit_symtab, search_symbols)
 682         (default_collect_symbol_completion_matches_break_on): Use
 683         objfile_compunits.
 684         * objfiles.h (ALL_COMPUNITS): Remove.
 685         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 686         * cp-support.c (add_symbol_overload_list_qualified): Use
 687         objfile_compunits.
 688         * ada-lang.c (ada_collect_symbol_completion_matches)
 689         (ada_add_global_exceptions): Use objfile_compunits.
 690
 691 2019-01-09  Tom Tromey  <tom@tromey.com>
 692
 693         * source.c (select_source_symtab)
 694         (forget_cached_source_info_for_objfile): Remove declaration.
 695         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 696         declaration.
 697         * maint.c (count_symtabs_and_blocks): Remove declaration.
 698         * cp-support.c (add_symbol_overload_list_qualified): Remove
 699         declaration.
 700         * coffread.c (coff_symtab_read): Remove declaration.
 701         * symtab.c (lookup_symbol_in_objfile_symtabs)
 702         (basic_lookup_transparent_type_1): Use objfile_compunits.
 703         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 704         (info_sources_command, search_symbols)
 705         (default_collect_symbol_completion_matches_break_on)
 706         (make_source_files_completion_list): Remove declaration.
 707         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 708         (ada_collect_symbol_completion_matches)
 709         (ada_add_global_exceptions): Remove declaration.
 710         * linespec.c (iterate_over_all_matching_symtabs): Use
 711         objfile_compunits.
 712         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 713         (class objfile_compunits): New.
 714         (ALL_COMPUNITS): Use objfile_compunits.
 715         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 716         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 717         objfile_compunits.
 718         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 719
 720 2019-01-09  Tom Tromey  <tom@tromey.com>
 721
 722         * symtab.c (search_symbols)
 723         (default_collect_symbol_completion_matches_break_on): Use
 724         objfile_msymbols.
 725         * ada-lang.c (ada_lookup_simple_minsym)
 726         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 727         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 728         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 729         objfile_msymbols.
 730         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 731         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 732         * objc-lang.c (find_methods): Use objfile_msymbols.
 733         (info_selectors_command, info_classes_command): Likewise.
 734         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 735         * objfiles.h (class objfile_msymbols): New.
 736         (ALL_OBJFILE_MSYMBOLS): Remove.
 737         (ALL_MSYMBOLS): Remove.
 738
 739 2019-01-09  Tom Tromey  <tom@tromey.com>
 740
 741         * common/next-iterator.h (next_adapter): Add Iterator template
 742         parameter.
 743         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 744         (class all_objfiles_safe): New.
 745         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 746         * objfiles.c (put_objfile_before): Update comment.
 747         (add_separate_debug_objfile): Likewise.
 748         (free_all_objfiles): Use all_objfiles_safe.
 749         (objfile_purge_solibs): Likewise.
 750
 751 2019-01-09  Tom Tromey  <tom@tromey.com>
 752
 753         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 754         (expand_symtab_containing_pc, lookup_static_symbol)
 755         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 756         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 757         all_objfiles.
 758         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 759         * breakpoint.c (create_overlay_event_breakpoint)
 760         (create_longjmp_master_breakpoint)
 761         (create_std_terminate_master_breakpoint)
 762         (create_exception_master_breakpoint): Use all_objfiles.
 763         * linux-thread-db.c (try_thread_db_load_from_pdir)
 764         (has_libpthread): Use all_objfiles.
 765         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 766         * linespec.c (iterate_over_all_matching_symtabs)
 767         (search_minsyms_for_name): Use all_objfiles.
 768         * maint.c (maintenance_info_sections): Use all_objfiles.
 769         * main.c (captured_main_1): Use all_objfiles.
 770         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 771         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 772         * guile/scm-pretty-print.c
 773         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 774         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 775         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 776         (maintenance_print_msymbols): Use all_objfiles.
 777         * source.c (select_source_symtab): Use all_objfiles.
 778         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 779         * symfile.c (remove_symbol_file_command)
 780         (expand_symtabs_matching, map_symbol_filenames): Use
 781         all_objfiles.
 782         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 783         all_objfiles.
 784         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 785         * objc-lang.c (find_methods): Use all_objfiles.
 786         * objfiles.c (have_partial_symbols, have_full_symbols)
 787         (have_minimal_symbols, qsort_cmp)
 788         (default_iterate_over_objfiles_in_search_order): Use
 789         all_objfiles.
 790         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 791         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 792         (maintenance_check_psymtabs): Use all_objfiles.
 793         (ALL_PSYMTABS): Remove.
 794         * compile/compile-object-run.c (do_module_cleanup): Use
 795         all_objfiles.
 796         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 797         * cp-support.c (add_symbol_overload_list_qualified): Use
 798         all_objfiles.
 799         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 800         Use all_objfiles.
 801         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 802         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 803         all_objfiles.
 804         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 805         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 806         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 807         Uses all_objfiles.
 808         * solib.c (solib_read_symbols): Use all_objfiles
 809
 810 2019-01-09  Tom Tromey  <tom@tromey.com>
 811
 812         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 813         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 814         all_objfiles.
 815         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 816         * symmisc.c (print_symbol_bcache_statistics)
 817         (print_objfile_statistics, maintenance_print_objfiles)
 818         (maintenance_info_symtabs, maintenance_check_symtabs)
 819         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 820         all_objfiles.
 821         * source.c (forget_cached_source_info): Use all_objfiles.
 822         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 823         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 824         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 825         * objfiles.c (update_section_map): Use all_objfiles.
 826         (shared_objfile_contains_address_p): Likewise.
 827         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 828         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 829
 830 2019-01-09  Tom Tromey  <tom@tromey.com>
 831
 832         * common/next-iterator.h: New file.
 833         * objfiles.h (class all_objfiles): New.
 834         (struct objfile_iterator): New.
 835
 836 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 837
 838         * NEWS: Move the description of the changed "frame", "select-frame",
 839          and "info frame" commands to the Changed commands section.
 840
 841 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 842
 843         * gdbtypes.c (check_stub_method_group): Remove handling of old
 844         mangling schemes.
 845         * linespec.c (find_methods): Likewise.
 846         * stabsread.c (read_member_functions): Likewise.
 847         * valops.c (search_struct_method): Likewise.
 848         (value_struct_elt_for_reference): Likewise.
 849         * NEWS: Mention this change.
 850
 851 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 852
 853         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 854         print_source_lines.
 855         * source.c (print_source_lines_base): Update line number check.
 856         (print_source_lines): New function.
 857         (source_lines_range::source_lines_range): New function.
 858         * source.h (class source_lines_range): New class.
 859         (print_source_lines): New declaration.
 860
 861 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 862
 863         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 864
 865 2019-01-08  Tom Tromey  <tom@tromey.com>
 866             Simon Marchi  <simon.marchi@ericsson.com>
 867
 868         PR gdb/24060
 869         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 870         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 871         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 872         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 873         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 874         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 875
 876 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 877
 878         * source.c (select_source_symtab): Move header comment to
 879         declaration in source.h.
 880         (forget_cached_source_info_for_objfile): Likewise.
 881         (forget_cached_source_info): Likewise.
 882         (identify_source_line): Likewise.
 883         * source.h (identify_source_line): Move declaration from symtab.h
 884         and add comment from source.c
 885         (print_source_lines): Likewise.
 886         (forget_cached_source_info_for_objfile): Likewise.
 887         (forget_cached_source_info): Likewise.
 888         (select_source_symtab): Likewise.
 889         (enum print_source_lines_flag): Move definition from symtab.h.
 890         * symtab.h (identify_source_line): Move declaration to source.h.
 891         (print_source_lines): Likewise.
 892         (forget_cached_source_info_for_objfile): Likewise.
 893         (forget_cached_source_info): Likewise.
 894         (select_source_symtab): Likewise.
 895         (enum print_source_lines_flag): Move definition to source.h.
 896         * tui/tui-hooks.c: Add 'source.h' include.
 897
 898 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 899
 900         * source.c (print_source_lines_base): Handle requests to print
 901         reverse line number sequences, and guard against empty lines
 902         string.
 903
 904 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 905
 906         * source.c (print_source_lines_base): Fix skip of '\r' if next
 907         character is '\n'.
 908
 909 2019-01-06  Tom Tromey  <tom@tromey.com>
 910
 911         * c-exp.y (struct c_parse_state) <macro_original_text,
 912         expansion_obstack>: New member.
 913         (macro_original_text, expansion_obstack): Remove globals.
 914         (scan_macro_expansion, scanning_macro_expansion)
 915         (finished_macro_expansion): Update.
 916         (scan_macro_cleanup): Remove.
 917         (yylex, c_parse): Update.
 918
 919 2019-01-06  Tom Tromey  <tom@tromey.com>
 920
 921         * c-exp.y (struct c_parse_state) <strings>: New member.
 922         (operator_stoken): Update.
 923
 924 2019-01-06  Tom Tromey  <tom@tromey.com>
 925
 926         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 927         (union type_stack_elt) <typelist_val>: Now a pointer to
 928         std::vector.
 929         (type_stack_cleanup): Don't declare.
 930         (push_typelist): Update.
 931         * parse.c (pop_typelist): Return a std::vector.
 932         (push_typelist): Take a std::vector.
 933         (follow_types): Update.  Do not free args.
 934         (type_stack_cleanup): Remove.
 935         * c-exp.y (struct c_parse_state): New.
 936         (cpstate): New global.
 937         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 938         (nonempty_typelist): Update.
 939         (func_mod): Create a new vector.
 940         (c_parse): Create a c_parse_state.
 941         (check_parameter_typelist): Do not delete params.
 942         (function_method): Update.  Do not delete type_list.
 943
 944 2019-01-06  Tom Tromey  <tom@tromey.com>
 945
 946         PR gdb/28155:
 947         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
 948         check_typedef.
 949         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
 950         (print_return_value): Likewise.
 951
 952 2019-01-05  Tom Tromey  <tom@tromey.com>
 953
 954         * contrib/cleanup_check.py: Remove.
 955         * contrib/gcc-with-excheck: Remove.
 956         * contrib/exsummary.py: Remove.
 957         * contrib/excheck.py: Remove.
 958
 959 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
 960
 961         * thread.c (delete_thread_1): Add gdb_assert that THR is not
 962         NULL. Initialize tpprev to NULL instead of assigning it
 963         to NULL on the next statement.
 964         * windows-nat.c (windows_delete_thread): Remove check for
 965         main_thread_id before printing thread exit notifications.
 966         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
 967         Remove thread ID check against main_thread_id.
 968         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
 969         windows_delete_thread.
 970         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
 971
 972 2019-01-04  Tom Tromey  <tom@tromey.com>
 973
 974         * compile/compile.c (_initialize_compile): Use upper case for
 975         metasyntactic variables.
 976         * symmisc.c (_initialize_symmisc): Use upper case for
 977         metasyntactic variables.
 978         * psymtab.c (_initialize_psymtab): Use upper case for
 979         metasyntactic variables.
 980         * demangle.c (demangle_command): Use upper case for metasyntactic
 981         variables.
 982         (_initialize_demangler): Likewise.
 983         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
 984         variables.
 985
 986 2019-01-03  Tom Tromey  <tom@tromey.com>
 987
 988         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
 989
 990 2019-01-03  Tom Tromey  <tom@tromey.com>
 991
 992         * python/py-symtab.c (salpy_str): Update.
 993         (struct salpy_sal_object) <symtab>: Now a PyObject.
 994         (salpy_dealloc): Update.
 995         (del_objfile_sal): Use gdbpy_ref.
 996
 997 2019-01-03  Tom Tromey  <tom@tromey.com>
 998
 999         * python/py-type.c (convert_field): Use new_reference.  Return
1000         gdbpy_ref.
1001         (make_fielditem): Return gdbpy_ref.
1002         (typy_fields): Update.
1003         (typy_getitem): Update.
1004         (field_name): Return gdbpy_ref.  Use new_reference.
1005         (typy_iterator_iternext): Update.
1006
1007 2019-01-03  Tom Tromey  <tom@tromey.com>
1008
1009         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1010
1011 2019-01-03  Tom Tromey  <tom@tromey.com>
1012
1013         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1014         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1015         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1016         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1017         (pspy_set_type_printers): Likewise.
1018         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1019         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1020         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1021         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1022         (objfpy_set_type_printers): Likewise.
1023
1024 2019-01-03  Tom Tromey  <tom@tromey.com>
1025
1026         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1027         (gdbpy_print_stack): Use gdbpy_err_fetch.
1028         * python/python-internal.h (class gdbpy_err_fetch): New class.
1029         (class gdbpy_enter) <m_error_type, m_error_value,
1030         m_error_traceback>: Remove.
1031         <m_error>: New member.
1032         (gdbpy_exception_to_string): Don't declare.
1033         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1034         * python/py-value.c (convert_value_from_python): Use
1035         gdbpy_err_fetch.
1036         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1037         gdbpy_exception_to_string.
1038         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1039         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1040         gdbpy_err_fetch.
1041
1042 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1043
1044         * linux-nat.c (delete_lwp_cleanup): Delete.
1045         (struct lwp_deleter): New struct.
1046         (lwp_info_up): New typedef.
1047         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1048         lwp_info_up.
1049
1050 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1051
1052         * linux-fork.c (class scoped_switch_fork_info): New class.
1053         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1054
1055 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1056
1057         * valops.c (find_overload_match): Remove use of null_cleanup, and
1058         calls to do_cleanups.
1059
1060 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1061
1062         * compile/compile-cplus-types.c
1063         (compile_cplus_instance::decl_name): Handle changes to
1064         cp_func_name.
1065         * cp-support.c (cp_func_name): Update header comment, update
1066         return type.
1067         * cp-support.h (cp_func_name): Update return type in declaration.
1068         * valops.c (find_overload_match): Move temp_func local to top
1069         level of function and change its type.  Use temp_func to hold and
1070         delete temporary string obtained from cp_func_name.
1071
1072 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1073
1074         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1075         gdb::char_vector, remove cleanup, and update uses of `msg`.
1076
1077 2019-01-03  Jim Wilson  <jimw@sifive.com>
1078
1079         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1080
1081 2019-01-02  Tom Tromey  <tom@tromey.com>
1082
1083         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1084         (tdesc_parse_xml): Remove cleanups.
1085         * target-descriptions.h (make_cleanup_free_target_description):
1086         Don't declare.
1087         (target_desc_deleter): New struct.
1088         (target_desc_up): New typedef.
1089         * target-descriptions.c (target_desc_deleter::operator()): Rename
1090         from free_target_description.
1091         (make_cleanup_free_target_description): Remove.
1092
1093 2019-01-02  Tom Tromey  <tom@tromey.com>
1094
1095         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1096         constructor, destructor.
1097         (linespec_parser): Remove typedef.
1098         (~linespec_parser): Rename from linespec_parser_delete.
1099         (linespec_lex_to_end, linespec_complete_label)
1100         (linespec_complete): Update.
1101         (decode_line_full): Remove cleanups.
1102         (decode_line_1): Update.
1103
1104 2019-01-02  Tom Tromey  <tom@tromey.com>
1105
1106         * python/python-internal.h (inferior_to_inferior_object): Change
1107         return type.
1108         * python/py-exitedevent.c (create_exited_event_object): Update.
1109         * python/py-inferior.c (inferior_to_inferior_object): Return
1110         gdbpy_ref.
1111         (python_new_inferior, python_inferior_deleted)
1112         (thread_to_thread_object, delete_thread_object)
1113         (build_inferior_list, gdbpy_selected_inferior): Update.
1114         * python/py-infthread.c (create_thread_object): Update.  Also fail
1115         if inferior_to_inferior_object fails.
1116
1117 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1118
1119         * inferior.h (class inferior) <displaced_step_state>: New field.
1120         * infrun.h (struct displaced_step_state): Move here from
1121         infrun.c.  Initialize fields, add constructor.
1122         <inf>: Remove field.
1123         <reset>: New method.
1124         * infrun.c (struct displaced_step_inferior_state): Move to
1125         infrun.h.
1126         (displaced_step_inferior_states): Remove.
1127         (get_displaced_stepping_state): Adust.
1128         (displaced_step_in_progress_any_inferior): Adjust.
1129         (displaced_step_in_progress_thread): Adjust.
1130         (displaced_step_in_progress): Adjust.
1131         (add_displaced_stepping_state): Remove.
1132         (get_displaced_step_closure_by_addr): Adjust.
1133         (remove_displaced_stepping_state): Remove.
1134         (infrun_inferior_exit): Call displaced_step_state.reset.
1135         (use_displaced_stepping): Don't check for NULL.
1136         (displaced_step_prepare_throw): Call
1137         get_displaced_stepping_state.
1138         (displaced_step_fixup): Don't check for NULL.
1139         (prepare_for_detach): Don't check for NULL.
1140
1141 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1142
1143         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1144          in case of call that did not complete.
1145
1146 2019-01-02  Andrey Utkin  <autkin@undo.io>
1147
1148         * symfile.c (find_separate_debug_file): Fix search of debug files for
1149         remote debuggee.
1150
1151 2019-01-02  Tom Tromey  <tom@tromey.com>
1152
1153         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1154         indentation.
1155         * python/py-frame.c (frapy_older): Remove cast.
1156         (frapy_newer): Likewise.
1157         * python/py-breakpoint.c (local_setattro): Remove cast.
1158         * python/py-arch.c (archpy_name): Remove local variable.
1159         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1160
1161 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1162
1163         * unittests/basic_string_view/element_access/char/empty.cc:
1164         Fix year range in copyright header.
1165
1166 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1167
1168         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1169         Delete.
1170         <operator==>: Update with for removed field.
1171         <hash>: Likewise.
1172         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1173         <isa_features>: ...this.
1174         <abi_features>: New field.
1175         (riscv_isa_flen): Update comment.
1176         (riscv_abi_xlen): New declaration.
1177         (riscv_abi_flen): New declaration.
1178         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1179         isa_features.
1180         (riscv_abi_xlen): New function.
1181         (riscv_isa_flen): Update to get answer from isa_features.
1182         (riscv_abi_flen): New function.
1183         (riscv_has_fp_abi): Update to get answer from abi_features.
1184         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1185         xlen and flen.
1186         (riscv_call_info) <xlen, flen>: Update comment.
1187         (riscv_call_arg_struct): Remove invalid assertions
1188         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1189         is removed.
1190         (riscv_gdbarch_init): Gather isa features and abi features
1191         separately, ensure both match on the gdbarch when reusing an old
1192         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1193         a target with 64-bit float hardware.
1194
1195 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1196
1197         * source.c (search_command_helper): Stop reverse search
1198         when line 1 has been searched.
1199
1200 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1201
1202         * record-full.c (record_full_base_target::close): Rewrite
1203         record_full_core_buf_list free logic.
1204
1205 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1206
1207         * break-catch-syscall.c (print_one_catch_syscall): xfree
1208         the last text.
1209
1210 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1211
1212         * top.c (print_gdb_version): Update Copyright year in version
1213         message.
1214
1215 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1216
1217         Update copyright year range in all GDB files.
1218
1219 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1220
1221         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1222
1223 For older changes see ChangeLog-2018.
1224 \f
1225 Local Variables:
1226 mode: change-log
1227 left-margin: 8
1228 fill-column: 74
1229 version-control: never
1230 coding: utf-8
1231 End:
1232