gdb/ChangeLog

   1 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
   2             Pedro Alves  <palves@redhat.com>
   3
   4         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
   5         'PATH_MAX'.
   6
   7 2019-02-14  David Michael  <fedora.dm0@gmail.com>
   8             Samuel Thibault  <samuel.thibault@gnu.org>
   9             Thomas Schwinge  <thomas@codesourcery.com>
  10
  11         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
  12         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
  13
  14 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
  15
  16         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
  17         (check_empty): Use "const char *".
  18
  19         * gnu-nat.c (gnu_nat_target::detach): Instead of
  20         'detach_inferior (pid)' call
  21         'detach_inferior (find_inferior_pid (pid))'.
  22
  23         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
  24         'nat/fork-inferior.o'.
  25         * gnu-nat.c: #include "nat/fork-inferior.h".
  26
  27         * gnu-nat.c (gnu_nat_target::detach): Instead of
  28         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
  29         * gnu-nat.h: #include "inf-child.h".
  30         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
  31         'i386_gnu_nat_target::fetch_registers'.
  32         (gnu_store_registers): Rename/move to
  33         'i386_gnu_nat_target::store_registers'.
  34
  35         * config/i386/nm-i386gnu.h: Don't "#include" any files.
  36         * gnu-nat.h (mach_thread_info): New function.
  37         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
  38
  39         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
  40
  41 2019-02-14  Frederic Konrad  <konrad@adacore.com>
  42
  43         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
  44
  45 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
  46
  47         * windows-nat.c (windows_add_thread): Add new parameter
  48         "main_thread_p" with default value set to false.  Update
  49         function documentation as well as all callers.
  50         (windows_delete_thread): Likewise.
  51         (fake_create_process): Update call to windows_add_thread.
  52         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
  53         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
  54         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
  55         call to windows_delete_thread.
  56
  57 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
  58
  59         * MAINTAINERS: Add Andrew Burgess as global maintainer.
  60
  61 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  62
  63         * symfile.c (find_separate_debug_file): Use canonical path of
  64         sysroot with child_path instead of gdb_sysroot if it is valid.
  65
  66 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  67
  68         * symfile.c (find_separate_debug_file): Use child_path to
  69         determine if an object file is under a sysroot.
  70
  71 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  72
  73         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
  74         unittests/child-path-selftests.c.
  75         * common/pathstuff.c (child_path): New function.
  76         * common/pathstuff.h (child_path): New prototype.
  77         * unittests/child-path-selftests.c: New file.
  78
  79 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  80
  81         * symfile.c (find_separate_debug_file): Look for separate debug
  82         files in debug directories under the sysroot.
  83
  84 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  85
  86         * symtab.h (struct minimal_symbol data_p): New const method.
  87         (struct minimal_symbol text_p): Likewise.
  88         * symtab.c (output_source_filename): Use file name style
  89         to print file name.
  90         (print_symbol_info): Likewise.
  91         (print_msymbol_info): Use address style to print addresses.
  92         Use function name style to print executable text symbols.
  93         (expand_symtab_containing_pc): Use data_p.
  94         (find_pc_sect_compunit_symtab): Likewise.
  95
  96 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  97
  98         * breakpoint.c (describe_other_breakpoints): Use address style
  99         to print addresses.
 100         (say_where): Likewise.
 101
 102 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 103
 104         * ada-typeprint.c (print_func_type): Print function name
 105         style to print function name.
 106         * c-typeprint.c (c_print_type_1): Likewise.
 107
 108 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 109
 110         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 111         for execve.
 112
 113 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 114
 115         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 116         type_stack.
 117
 118 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 119
 120         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 121         TYPE_CODE_REF types.
 122
 123 2019-02-08  Jim Wilson  <jimw@sifive.com>
 124
 125         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 126         (riscv_linux_fregset): New.
 127         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 128
 129 2019-02-07  Tom Tromey  <tom@tromey.com>
 130
 131         * thread.c (thread_cancel_execution_command): Update.
 132         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 133         methods.
 134         (struct thread_fsm_ops): Remove.
 135         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 136         (thread_fsm_should_stop, thread_fsm_return_value)
 137         (thread_fsm_set_finished, thread_fsm_finished_p)
 138         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 139         Don't declare.
 140         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 141         * infrun.c (clear_proceed_status_thread)
 142         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 143         (print_stop_event): Update.
 144         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 145         Add constructor.
 146         (step_command_fsm_ops): Remove.
 147         (new_step_command_fsm): Remove.
 148         (step_1): Update.
 149         (step_command_fsm::should_stop): Rename from
 150         step_command_fsm_should_stop.
 151         (step_command_fsm::clean_up): Rename from
 152         step_command_fsm_clean_up.
 153         (step_command_fsm::do_async_reply_reason): Rename from
 154         step_command_fsm_async_reply_reason.
 155         (struct until_next_fsm): Inherit from thread_fsm.  Add
 156         constructor.
 157         (until_next_fsm_ops): Remove.
 158         (new_until_next_fsm): Remove.
 159         (until_next_fsm::should_stop): Rename from
 160         until_next_fsm_should_stop.
 161         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 162         (until_next_fsm::do_async_reply_reason): Rename from
 163         until_next_fsm_async_reply_reason.
 164         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 165         constructor.  Change type of breakpoint.
 166         (finish_command_fsm_ops): Remove.
 167         (new_finish_command_fsm): Remove.
 168         (finish_command_fsm::should_stop): Rename from
 169         finish_command_fsm_should_stop.
 170         (finish_command_fsm::clean_up): Rename from
 171         finish_command_fsm_clean_up.
 172         (finish_command_fsm::return_value): Rename from
 173         finish_command_fsm_return_value.
 174         (finish_command_fsm::do_async_reply_reason): Rename from
 175         finish_command_fsm_async_reply_reason.
 176         (finish_command): Update.
 177         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 178         Add constructor.
 179         (call_thread_fsm_ops): Remove.
 180         (call_thread_fsm::call_thread_fsm): Rename from
 181         new_call_thread_fsm.
 182         (call_thread_fsm::should_stop): Rename from
 183         call_thread_fsm_should_stop.
 184         (call_thread_fsm::should_notify_stop): Rename from
 185         call_thread_fsm_should_notify_stop.
 186         (run_inferior_call, call_function_by_hand_dummy): Update.
 187         * cli/cli-interp.c (should_print_stop_to_console): Update.
 188         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 189         Add constructor.  Change type of location_breakpoint,
 190         caller_breakpoint.
 191         (until_break_fsm_ops): Remove.
 192         (new_until_break_fsm): Remove.
 193         (until_break_fsm::should_stop): Rename from
 194         until_break_fsm_should_stop.
 195         (until_break_fsm::clean_up): Rename from
 196         until_break_fsm_clean_up.
 197         (until_break_fsm::do_async_reply_reason): Rename from
 198         until_break_fsm_async_reply_reason.
 199         (until_break_command): Update.
 200         * thread-fsm.c: Remove.
 201         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 202
 203 2019-02-07  Tom Tromey  <tom@tromey.com>
 204
 205         * yy-remap.h: Add include guard.
 206         * xtensa-tdep.h: Add include guard.
 207         * xcoffread.h: Rename include guard.
 208         * varobj-iter.h: Add include guard.
 209         * tui/tui.h: Rename include guard.
 210         * tui/tui-winsource.h: Rename include guard.
 211         * tui/tui-wingeneral.h: Rename include guard.
 212         * tui/tui-windata.h: Rename include guard.
 213         * tui/tui-win.h: Rename include guard.
 214         * tui/tui-stack.h: Rename include guard.
 215         * tui/tui-source.h: Rename include guard.
 216         * tui/tui-regs.h: Rename include guard.
 217         * tui/tui-out.h: Rename include guard.
 218         * tui/tui-layout.h: Rename include guard.
 219         * tui/tui-io.h: Rename include guard.
 220         * tui/tui-hooks.h: Rename include guard.
 221         * tui/tui-file.h: Rename include guard.
 222         * tui/tui-disasm.h: Rename include guard.
 223         * tui/tui-data.h: Rename include guard.
 224         * tui/tui-command.h: Rename include guard.
 225         * tic6x-tdep.h: Add include guard.
 226         * target/waitstatus.h: Rename include guard.
 227         * target/wait.h: Rename include guard.
 228         * target/target.h: Rename include guard.
 229         * target/resume.h: Rename include guard.
 230         * target-float.h: Rename include guard.
 231         * stabsread.h: Add include guard.
 232         * rs6000-tdep.h: Add include guard.
 233         * riscv-fbsd-tdep.h: Add include guard.
 234         * regformats/regdef.h: Rename include guard.
 235         * record.h: Rename include guard.
 236         * python/python.h: Rename include guard.
 237         * python/python-internal.h: Rename include guard.
 238         * python/py-stopevent.h: Rename include guard.
 239         * python/py-ref.h: Rename include guard.
 240         * python/py-record.h: Rename include guard.
 241         * python/py-record-full.h: Rename include guard.
 242         * python/py-record-btrace.h: Rename include guard.
 243         * python/py-instruction.h: Rename include guard.
 244         * python/py-events.h: Rename include guard.
 245         * python/py-event.h: Rename include guard.
 246         * procfs.h: Add include guard.
 247         * proc-utils.h: Add include guard.
 248         * p-lang.h: Add include guard.
 249         * or1k-tdep.h: Rename include guard.
 250         * observable.h: Rename include guard.
 251         * nto-tdep.h: Rename include guard.
 252         * nat/x86-linux.h: Rename include guard.
 253         * nat/x86-linux-dregs.h: Rename include guard.
 254         * nat/x86-gcc-cpuid.h: Add include guard.
 255         * nat/x86-dregs.h: Rename include guard.
 256         * nat/x86-cpuid.h: Rename include guard.
 257         * nat/ppc-linux.h: Rename include guard.
 258         * nat/mips-linux-watch.h: Rename include guard.
 259         * nat/linux-waitpid.h: Rename include guard.
 260         * nat/linux-ptrace.h: Rename include guard.
 261         * nat/linux-procfs.h: Rename include guard.
 262         * nat/linux-osdata.h: Rename include guard.
 263         * nat/linux-nat.h: Rename include guard.
 264         * nat/linux-namespaces.h: Rename include guard.
 265         * nat/linux-btrace.h: Rename include guard.
 266         * nat/glibc_thread_db.h: Rename include guard.
 267         * nat/gdb_thread_db.h: Rename include guard.
 268         * nat/gdb_ptrace.h: Rename include guard.
 269         * nat/fork-inferior.h: Rename include guard.
 270         * nat/amd64-linux-siginfo.h: Rename include guard.
 271         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 272         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 273         * nat/aarch64-linux.h: Rename include guard.
 274         * nat/aarch64-linux-hw-point.h: Rename include guard.
 275         * mn10300-tdep.h: Add include guard.
 276         * mips-linux-tdep.h: Add include guard.
 277         * mi/mi-parse.h: Rename include guard.
 278         * mi/mi-out.h: Rename include guard.
 279         * mi/mi-main.h: Rename include guard.
 280         * mi/mi-interp.h: Rename include guard.
 281         * mi/mi-getopt.h: Rename include guard.
 282         * mi/mi-console.h: Rename include guard.
 283         * mi/mi-common.h: Rename include guard.
 284         * mi/mi-cmds.h: Rename include guard.
 285         * mi/mi-cmd-break.h: Rename include guard.
 286         * m2-lang.h: Add include guard.
 287         * location.h: Rename include guard.
 288         * linux-record.h: Rename include guard.
 289         * linux-nat.h: Add include guard.
 290         * linux-fork.h: Add include guard.
 291         * i386-darwin-tdep.h: Rename include guard.
 292         * hppa-linux-offsets.h: Add include guard.
 293         * guile/guile.h: Rename include guard.
 294         * guile/guile-internal.h: Rename include guard.
 295         * gnu-nat.h: Rename include guard.
 296         * gdb-stabs.h: Rename include guard.
 297         * frv-tdep.h: Add include guard.
 298         * f-lang.h: Add include guard.
 299         * event-loop.h: Add include guard.
 300         * darwin-nat.h: Rename include guard.
 301         * cp-abi.h: Rename include guard.
 302         * config/sparc/nm-sol2.h: Rename include guard.
 303         * config/nm-nto.h: Rename include guard.
 304         * config/nm-linux.h: Add include guard.
 305         * config/i386/nm-i386gnu.h: Rename include guard.
 306         * config/djgpp/nl_types.h: Rename include guard.
 307         * config/djgpp/langinfo.h: Rename include guard.
 308         * compile/gcc-cp-plugin.h: Add include guard.
 309         * compile/gcc-c-plugin.h: Add include guard.
 310         * compile/compile.h: Rename include guard.
 311         * compile/compile-object-run.h: Rename include guard.
 312         * compile/compile-object-load.h: Rename include guard.
 313         * compile/compile-internal.h: Rename include guard.
 314         * compile/compile-cplus.h: Rename include guard.
 315         * compile/compile-c.h: Rename include guard.
 316         * common/xml-utils.h: Rename include guard.
 317         * common/x86-xstate.h: Rename include guard.
 318         * common/version.h: Rename include guard.
 319         * common/vec.h: Rename include guard.
 320         * common/tdesc.h: Rename include guard.
 321         * common/selftest.h: Rename include guard.
 322         * common/scoped_restore.h: Rename include guard.
 323         * common/scoped_mmap.h: Rename include guard.
 324         * common/scoped_fd.h: Rename include guard.
 325         * common/safe-iterator.h: Rename include guard.
 326         * common/run-time-clock.h: Rename include guard.
 327         * common/refcounted-object.h: Rename include guard.
 328         * common/queue.h: Rename include guard.
 329         * common/ptid.h: Rename include guard.
 330         * common/print-utils.h: Rename include guard.
 331         * common/preprocessor.h: Rename include guard.
 332         * common/pathstuff.h: Rename include guard.
 333         * common/observable.h: Rename include guard.
 334         * common/netstuff.h: Rename include guard.
 335         * common/job-control.h: Rename include guard.
 336         * common/host-defs.h: Rename include guard.
 337         * common/gdb_wait.h: Rename include guard.
 338         * common/gdb_vecs.h: Rename include guard.
 339         * common/gdb_unlinker.h: Rename include guard.
 340         * common/gdb_unique_ptr.h: Rename include guard.
 341         * common/gdb_tilde_expand.h: Rename include guard.
 342         * common/gdb_sys_time.h: Rename include guard.
 343         * common/gdb_string_view.h: Rename include guard.
 344         * common/gdb_splay_tree.h: Rename include guard.
 345         * common/gdb_setjmp.h: Rename include guard.
 346         * common/gdb_ref_ptr.h: Rename include guard.
 347         * common/gdb_optional.h: Rename include guard.
 348         * common/gdb_locale.h: Rename include guard.
 349         * common/gdb_assert.h: Rename include guard.
 350         * common/filtered-iterator.h: Rename include guard.
 351         * common/filestuff.h: Rename include guard.
 352         * common/fileio.h: Rename include guard.
 353         * common/environ.h: Rename include guard.
 354         * common/common-utils.h: Rename include guard.
 355         * common/common-types.h: Rename include guard.
 356         * common/common-regcache.h: Rename include guard.
 357         * common/common-inferior.h: Rename include guard.
 358         * common/common-gdbthread.h: Rename include guard.
 359         * common/common-exceptions.h: Rename include guard.
 360         * common/common-defs.h: Rename include guard.
 361         * common/common-debug.h: Rename include guard.
 362         * common/cleanups.h: Rename include guard.
 363         * common/buffer.h: Rename include guard.
 364         * common/btrace-common.h: Rename include guard.
 365         * common/break-common.h: Rename include guard.
 366         * cli/cli-utils.h: Rename include guard.
 367         * cli/cli-style.h: Rename include guard.
 368         * cli/cli-setshow.h: Rename include guard.
 369         * cli/cli-script.h: Rename include guard.
 370         * cli/cli-interp.h: Rename include guard.
 371         * cli/cli-decode.h: Rename include guard.
 372         * cli/cli-cmds.h: Rename include guard.
 373         * charset-list.h: Add include guard.
 374         * buildsym-legacy.h: Rename include guard.
 375         * bfin-tdep.h: Add include guard.
 376         * ax.h: Rename include guard.
 377         * arm-linux-tdep.h: Add include guard.
 378         * arm-fbsd-tdep.h: Add include guard.
 379         * arch/xtensa.h: Rename include guard.
 380         * arch/tic6x.h: Add include guard.
 381         * arch/i386.h: Add include guard.
 382         * arch/arm.h: Rename include guard.
 383         * arch/arm-linux.h: Rename include guard.
 384         * arch/arm-get-next-pcs.h: Rename include guard.
 385         * arch/amd64.h: Add include guard.
 386         * arch/aarch64-insn.h: Rename include guard.
 387         * arch-utils.h: Rename include guard.
 388         * annotate.h: Add include guard.
 389         * amd64-darwin-tdep.h: Rename include guard.
 390         * aarch64-linux-tdep.h: Add include guard.
 391         * aarch64-fbsd-tdep.h: Add include guard.
 392         * aarch32-linux-nat.h: Add include guard.
 393
 394 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 395
 396         * macrotab.c (macro_define_internal): New function that
 397         factorizes macro_define_object_internal and macro_define_function
 398         code.
 399         (macro_define_object_internal): Use macro_define_internal.
 400         (macro_define_function): Likewise.
 401
 402 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 403
 404         * macrocmd.c (extract_identifier): Return
 405         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 406         callers.
 407
 408 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 409
 410         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 411
 412 2019-02-05  Tom Tromey  <tom@tromey.com>
 413
 414         * target.c (target_stack::unpush): Move assertion earlier.
 415
 416 2019-01-30  Tom Tromey  <tom@tromey.com>
 417
 418         PR python/23615:
 419         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 420         (gdbpy_parse_and_eval): Likewise.
 421         * python/python-internal.h (gdbpy_allow_threads): New class.
 422
 423 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 424
 425         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 426         (aarch64_fbsd_fpregmap): Move earlier.
 427         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 428         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 429         instead of individual calls to trad_frame_set_reg_addr.
 430         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 431         earlier.
 432         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 433         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 434         instead of individual calls to trad_frame_set_reg_addr.
 435
 436 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 437
 438         * CONTRIBUTE: Replace contribution list with wiki link.
 439
 440 2019-01-25  Tom Tromey  <tom@tromey.com>
 441
 442         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 443
 444 2019-01-25  Tom Tromey  <tom@tromey.com>
 445
 446         * xtensa-linux-nat.c: Fix common/ includes.
 447         * xml-support.h: Fix common/ includes.
 448         * xml-support.c: Fix common/ includes.
 449         * x86-linux-nat.c: Fix common/ includes.
 450         * windows-nat.c: Fix common/ includes.
 451         * varobj.h: Fix common/ includes.
 452         * varobj.c: Fix common/ includes.
 453         * value.c: Fix common/ includes.
 454         * valops.c: Fix common/ includes.
 455         * utils.c: Fix common/ includes.
 456         * unittests/xml-utils-selftests.c: Fix common/ includes.
 457         * unittests/utils-selftests.c: Fix common/ includes.
 458         * unittests/unpack-selftests.c: Fix common/ includes.
 459         * unittests/tracepoint-selftests.c: Fix common/ includes.
 460         * unittests/style-selftests.c: Fix common/ includes.
 461         * unittests/string_view-selftests.c: Fix common/ includes.
 462         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 463         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 464         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 465         * unittests/rsp-low-selftests.c: Fix common/ includes.
 466         * unittests/parse-connection-spec-selftests.c: Fix common/
 467         includes.
 468         * unittests/optional-selftests.c: Fix common/ includes.
 469         * unittests/offset-type-selftests.c: Fix common/ includes.
 470         * unittests/observable-selftests.c: Fix common/ includes.
 471         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 472         * unittests/memrange-selftests.c: Fix common/ includes.
 473         * unittests/memory-map-selftests.c: Fix common/ includes.
 474         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 475         * unittests/function-view-selftests.c: Fix common/ includes.
 476         * unittests/environ-selftests.c: Fix common/ includes.
 477         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 478         * unittests/common-utils-selftests.c: Fix common/ includes.
 479         * unittests/cli-utils-selftests.c: Fix common/ includes.
 480         * unittests/array-view-selftests.c: Fix common/ includes.
 481         * ui-file.c: Fix common/ includes.
 482         * tui/tui-io.c: Fix common/ includes.
 483         * tracepoint.h: Fix common/ includes.
 484         * tracepoint.c: Fix common/ includes.
 485         * tracefile-tfile.c: Fix common/ includes.
 486         * top.h: Fix common/ includes.
 487         * top.c: Fix common/ includes.
 488         * thread.c: Fix common/ includes.
 489         * target/waitstatus.h: Fix common/ includes.
 490         * target/waitstatus.c: Fix common/ includes.
 491         * target.h: Fix common/ includes.
 492         * target.c: Fix common/ includes.
 493         * target-memory.c: Fix common/ includes.
 494         * target-descriptions.c: Fix common/ includes.
 495         * symtab.h: Fix common/ includes.
 496         * symfile.c: Fix common/ includes.
 497         * stap-probe.c: Fix common/ includes.
 498         * spu-linux-nat.c: Fix common/ includes.
 499         * sparc-nat.c: Fix common/ includes.
 500         * source.c: Fix common/ includes.
 501         * solib.c: Fix common/ includes.
 502         * solib-target.c: Fix common/ includes.
 503         * ser-unix.c: Fix common/ includes.
 504         * ser-tcp.c: Fix common/ includes.
 505         * ser-pipe.c: Fix common/ includes.
 506         * ser-base.c: Fix common/ includes.
 507         * selftest-arch.c: Fix common/ includes.
 508         * s12z-tdep.c: Fix common/ includes.
 509         * rust-exp.y: Fix common/ includes.
 510         * rs6000-aix-tdep.c: Fix common/ includes.
 511         * riscv-tdep.c: Fix common/ includes.
 512         * remote.c: Fix common/ includes.
 513         * remote-notif.h: Fix common/ includes.
 514         * remote-fileio.h: Fix common/ includes.
 515         * remote-fileio.c: Fix common/ includes.
 516         * regcache.h: Fix common/ includes.
 517         * regcache.c: Fix common/ includes.
 518         * record-btrace.c: Fix common/ includes.
 519         * python/python.c: Fix common/ includes.
 520         * python/py-type.c: Fix common/ includes.
 521         * python/py-inferior.c: Fix common/ includes.
 522         * progspace.h: Fix common/ includes.
 523         * producer.c: Fix common/ includes.
 524         * procfs.c: Fix common/ includes.
 525         * proc-api.c: Fix common/ includes.
 526         * printcmd.c: Fix common/ includes.
 527         * ppc-linux-nat.c: Fix common/ includes.
 528         * parser-defs.h: Fix common/ includes.
 529         * osdata.c: Fix common/ includes.
 530         * obsd-nat.c: Fix common/ includes.
 531         * nat/x86-linux.c: Fix common/ includes.
 532         * nat/x86-linux-dregs.c: Fix common/ includes.
 533         * nat/x86-dregs.h: Fix common/ includes.
 534         * nat/x86-dregs.c: Fix common/ includes.
 535         * nat/ppc-linux.c: Fix common/ includes.
 536         * nat/mips-linux-watch.h: Fix common/ includes.
 537         * nat/mips-linux-watch.c: Fix common/ includes.
 538         * nat/linux-waitpid.c: Fix common/ includes.
 539         * nat/linux-ptrace.h: Fix common/ includes.
 540         * nat/linux-ptrace.c: Fix common/ includes.
 541         * nat/linux-procfs.c: Fix common/ includes.
 542         * nat/linux-personality.c: Fix common/ includes.
 543         * nat/linux-osdata.c: Fix common/ includes.
 544         * nat/linux-namespaces.c: Fix common/ includes.
 545         * nat/linux-btrace.h: Fix common/ includes.
 546         * nat/linux-btrace.c: Fix common/ includes.
 547         * nat/fork-inferior.c: Fix common/ includes.
 548         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 549         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 550         * nat/aarch64-linux.c: Fix common/ includes.
 551         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 552         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 553         * namespace.h: Fix common/ includes.
 554         * mips-linux-tdep.c: Fix common/ includes.
 555         * minsyms.c: Fix common/ includes.
 556         * mi/mi-parse.h: Fix common/ includes.
 557         * mi/mi-main.c: Fix common/ includes.
 558         * mi/mi-cmd-env.c: Fix common/ includes.
 559         * memrange.h: Fix common/ includes.
 560         * memattr.c: Fix common/ includes.
 561         * maint.h: Fix common/ includes.
 562         * maint.c: Fix common/ includes.
 563         * main.c: Fix common/ includes.
 564         * machoread.c: Fix common/ includes.
 565         * location.c: Fix common/ includes.
 566         * linux-thread-db.c: Fix common/ includes.
 567         * linux-nat.c: Fix common/ includes.
 568         * linux-fork.c: Fix common/ includes.
 569         * inline-frame.c: Fix common/ includes.
 570         * infrun.c: Fix common/ includes.
 571         * inflow.c: Fix common/ includes.
 572         * inferior.h: Fix common/ includes.
 573         * inferior.c: Fix common/ includes.
 574         * infcmd.c: Fix common/ includes.
 575         * inf-ptrace.c: Fix common/ includes.
 576         * inf-child.c: Fix common/ includes.
 577         * ia64-linux-nat.c: Fix common/ includes.
 578         * i387-tdep.c: Fix common/ includes.
 579         * i386-tdep.c: Fix common/ includes.
 580         * i386-linux-tdep.c: Fix common/ includes.
 581         * i386-linux-nat.c: Fix common/ includes.
 582         * i386-go32-tdep.c: Fix common/ includes.
 583         * i386-fbsd-tdep.c: Fix common/ includes.
 584         * i386-fbsd-nat.c: Fix common/ includes.
 585         * guile/scm-type.c: Fix common/ includes.
 586         * guile/guile.c: Fix common/ includes.
 587         * go32-nat.c: Fix common/ includes.
 588         * gnu-nat.c: Fix common/ includes.
 589         * gdbthread.h: Fix common/ includes.
 590         * gdbarch-selftests.c: Fix common/ includes.
 591         * gdb_usleep.c: Fix common/ includes.
 592         * gdb_select.h: Fix common/ includes.
 593         * gdb_bfd.c: Fix common/ includes.
 594         * gcore.c: Fix common/ includes.
 595         * fork-child.c: Fix common/ includes.
 596         * findvar.c: Fix common/ includes.
 597         * fbsd-nat.c: Fix common/ includes.
 598         * event-top.c: Fix common/ includes.
 599         * event-loop.c: Fix common/ includes.
 600         * dwarf2read.c: Fix common/ includes.
 601         * dwarf2loc.c: Fix common/ includes.
 602         * dwarf2-frame.c: Fix common/ includes.
 603         * dwarf-index-cache.c: Fix common/ includes.
 604         * dtrace-probe.c: Fix common/ includes.
 605         * disasm-selftests.c: Fix common/ includes.
 606         * defs.h: Fix common/ includes.
 607         * csky-tdep.c: Fix common/ includes.
 608         * cp-valprint.c: Fix common/ includes.
 609         * cp-support.h: Fix common/ includes.
 610         * cp-support.c: Fix common/ includes.
 611         * corelow.c: Fix common/ includes.
 612         * completer.h: Fix common/ includes.
 613         * completer.c: Fix common/ includes.
 614         * compile/compile.c: Fix common/ includes.
 615         * compile/compile-loc2c.c: Fix common/ includes.
 616         * compile/compile-cplus-types.c: Fix common/ includes.
 617         * compile/compile-cplus-symbols.c: Fix common/ includes.
 618         * command.h: Fix common/ includes.
 619         * cli/cli-dump.c: Fix common/ includes.
 620         * cli/cli-cmds.c: Fix common/ includes.
 621         * charset.c: Fix common/ includes.
 622         * build-id.c: Fix common/ includes.
 623         * btrace.h: Fix common/ includes.
 624         * btrace.c: Fix common/ includes.
 625         * breakpoint.h: Fix common/ includes.
 626         * breakpoint.c: Fix common/ includes.
 627         * ax.h:
 628         (enum agent_op): Fix common/ includes.
 629         * ax-general.c (struct aop_map): Fix common/ includes.
 630         * ax-gdb.c: Fix common/ includes.
 631         * auxv.c: Fix common/ includes.
 632         * auto-load.c: Fix common/ includes.
 633         * arm-tdep.c: Fix common/ includes.
 634         * arch/riscv.c: Fix common/ includes.
 635         * arch/ppc-linux-common.c: Fix common/ includes.
 636         * arch/i386.c: Fix common/ includes.
 637         * arch/arm.c: Fix common/ includes.
 638         * arch/arm-linux.c: Fix common/ includes.
 639         * arch/arm-get-next-pcs.c: Fix common/ includes.
 640         * arch/amd64.c: Fix common/ includes.
 641         * arch/aarch64.c: Fix common/ includes.
 642         * arch/aarch64-insn.c: Fix common/ includes.
 643         * arch-utils.c: Fix common/ includes.
 644         * amd64-windows-tdep.c: Fix common/ includes.
 645         * amd64-tdep.c: Fix common/ includes.
 646         * amd64-sol2-tdep.c: Fix common/ includes.
 647         * amd64-obsd-tdep.c: Fix common/ includes.
 648         * amd64-nbsd-tdep.c: Fix common/ includes.
 649         * amd64-linux-tdep.c: Fix common/ includes.
 650         * amd64-linux-nat.c: Fix common/ includes.
 651         * amd64-fbsd-tdep.c: Fix common/ includes.
 652         * amd64-fbsd-nat.c: Fix common/ includes.
 653         * amd64-dicos-tdep.c: Fix common/ includes.
 654         * amd64-darwin-tdep.c: Fix common/ includes.
 655         * agent.c: Fix common/ includes.
 656         * ada-lang.h: Fix common/ includes.
 657         * ada-lang.c: Fix common/ includes.
 658         * aarch64-tdep.c: Fix common/ includes.
 659
 660 2019-01-25  Tom Tromey  <tom@tromey.com>
 661
 662         * common/create-version.sh: Use common/version.h.
 663
 664 2019-01-24  Pedro Alves  <palves@redhat.com>
 665
 666         * infrun.c (signal_stop, signal_print, signal_program)
 667         (signal_catch, signal_pass): Now arrays instead of pointers.
 668         (update_signals_program_target, do_target_resume)
 669         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 670         * linux-nat.c (linux_nat_target::pass_signals)
 671         (linux_nat_target::create_inferior, linux_nat_target::attach):
 672         Adjust.
 673         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 674         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 675         * procfs.c (procfs_target::pass_signals): Adjust.
 676         * record-full.c (record_full_target::resume): Adjust.
 677         * remote.c (remote_target::pass_signals)
 678         (remote_target::program_signals): Adjust.
 679         * target-debug.h (target_debug_print_signals): Now takes a
 680         gdb::array_view as parameter.  Adjust.
 681         * target.h (target_ops) <pass_signals, program_signals>: Replace
 682         pointer and length parameters with gdb::array_view.
 683         (target_pass_signals, target_program_signals): Likewise.
 684         * target-delegates.c: Regenerate.
 685
 686 2019-01-24  Pedro Alves  <palves@redhat.com>
 687
 688         * common/forward-scope-exit.h
 689         (forward_scope_exit::forward_scope_exit): Pass arguments to
 690         m_bind_function directly, instead of creating a std::bind and
 691         copying that.
 692
 693 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 694
 695         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 696         for static members.
 697         (pass_in_v_vfp_candidate): Likewise.
 698
 699 2019-01-23  Tom Tromey  <tom@tromey.com>
 700             Pedro Alves  <palves@redhat.com>
 701
 702         * regcache.c (class regcache_invalidator): Remove.
 703         (regcache::raw_write): Use make_scope_exit.
 704
 705 2019-01-23  Tom Tromey  <tom@tromey.com>
 706
 707         * ui-out.h (class ui_out_emit_type): Update comment.
 708
 709 2019-01-23  Tom Tromey  <tom@tromey.com>
 710
 711         * infrun.c (fetch_inferior_event): Update comment.
 712
 713 2019-01-23  Tom Tromey  <tom@tromey.com>
 714             Pedro Alves  <palves@redhat.com>
 715
 716         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 717         parameter.
 718         (fetch_inferior_event): Use SCOPE_EXIT.
 719
 720
 721 2019-01-23  Tom Tromey  <tom@tromey.com>
 722             Pedro Alves  <palves@redhat.com>
 723
 724         * infrun.c (disable_thread_events): Delete.
 725         (stop_all_threads): Use SCOPE_EXIT.
 726
 727 2019-01-23  Tom Tromey  <tom@tromey.com>
 728             Pedro Alves  <palves@redhat.com>
 729
 730         * symfile.c: Include forward-scope-exit.h.
 731         (clear_symtab_users_cleanup): Replace forward declaration with
 732         a FORWARD_SCOPE_EXIT.
 733         (syms_from_objfile_1): Use the forward_scope_exit and
 734         gdb::optional instead of cleanup_function.
 735         (reread_symbols): Use the forward_scope_exit instead of
 736         cleanup_function.
 737         (clear_symtab_users_cleanup): Remove function.
 738
 739 2019-01-23  Tom Tromey  <tom@tromey.com>
 740             Pedro Alves  <palves@redhat.com>
 741
 742         * linux-nat.c: Include scope-exit.h.
 743         (cleanup_target_stop): Remove.
 744         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 745         SCOPE_EXIT.
 746
 747 2019-01-23  Tom Tromey  <tom@tromey.com>
 748             Pedro Alves  <palves@redhat.com>
 749
 750         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 751         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 752
 753 2019-01-23  Tom Tromey  <tom@tromey.com>
 754             Andrew Burgess  <andrew.burgess@embecosm.com>
 755             Pedro Alves  <palves@redhat.com>
 756
 757         * infrun.c (fetch_inferior_event): Use scope_exit.
 758         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 759         * top.c (execute_command): Use scope_exit.
 760         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 761         * utils.c (do_bpstat_clear_actions_cleanup)
 762         (make_bpstat_clear_actions_cleanup): Remove.
 763
 764 2019-01-23  Tom Tromey  <tom@tromey.com>
 765             Pedro Alves  <palves@redhat.com>
 766
 767         * infrun.c: Include "common/scope-exit.h"
 768         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 769         (wait_for_inferior): Use SCOPE_EXIT.
 770         (fetch_inferior_event): Use scope_exit.
 771
 772 2019-01-23  Tom Tromey  <tom@tromey.com>
 773             Pedro Alves  <palves@redhat.com>
 774
 775         * breakpoint.c (create_breakpoint): Remove cleanup.
 776
 777 2019-01-23  Tom Tromey  <tom@tromey.com>
 778             Andrew Burgess  <andrew.burgess@embecosm.com>
 779             Pedro Alves  <palves@redhat.com>
 780
 781 2019-01-23  Pedro Alves  <palves@redhat.com>
 782
 783         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 784
 785 2019-01-23  Pedro Alves  <palves@redhat.com>
 786             Andrew Burgess  <andrew.burgess@embecosm.com>
 787
 788         * gdbthread.h: Include "common/forward-scope-exit.h".
 789         (scoped_finish_thread_state): Redefine custom class in terms of
 790         forward_scope_exit.
 791
 792 2019-01-23  Pedro Alves  <palves@redhat.com>
 793             Andrew Burgess  <andrew.burgess@embecosm.com>
 794
 795         * common/forward-scope-exit.h: New file.
 796
 797 2019-01-23  Pedro Alves  <palves@redhat.com>
 798             Andrew Burgess  <andrew.burgess@embecosm.com>
 799             Tom Tromey  <tom@tromey.com>
 800
 801         * common/scope-exit.h: New file.
 802
 803 2019-01-23  Pedro Alves  <palves@redhat.com>
 804
 805         * common/preprocessor.h (ESC): Rename to ...
 806         (ESC_PARENS): ... this.
 807         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 808         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 809
 810 2019-01-23  Tom Tromey  <tom@tromey.com>
 811
 812         * language.h (class scoped_switch_to_sym_language_if_auto):
 813         Initialize m_lang in both cases.
 814
 815 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 816
 817         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 818         with XCNEW.
 819
 820 2019-01-22  Tom Tromey  <tom@tromey.com>
 821
 822         * corelow.c: Do not include sys/file.h.
 823
 824 2019-01-22  Tom Tromey  <tom@tromey.com>
 825
 826         * tui/tui-wingeneral.h: Include gdb_curses.h.
 827
 828 2019-01-22  Tom Tromey  <tom@tromey.com>
 829
 830         * source-cache.h (class source_cache) <get_source_lines,
 831         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 832
 833 2019-01-22  Tom Tromey  <tom@tromey.com>
 834
 835         * remote-fileio.h (struct remote_target): Declare.
 836
 837 2019-01-22  Tom Tromey  <tom@tromey.com>
 838
 839         * python/py-arch.c: Do not include py-ref.h.
 840         * python/py-bpevent.c: Do not include py-ref.h.
 841         * python/py-cmd.c: Do not include py-ref.h.
 842         * python/py-continueevent.c: Do not include py-ref.h.
 843         * python/py-event.h: Do not include py-ref.h.
 844         * python/py-evtregistry.c: Do not include py-ref.h.
 845         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 846         * python/py-frame.c: Do not include py-ref.h.
 847         * python/py-framefilter.c: Do not include py-ref.h.
 848         * python/py-function.c: Do not include py-ref.h.
 849         * python/py-infevents.c: Do not include py-ref.h.
 850         * python/py-linetable.c: Do not include py-ref.h.
 851         * python/py-objfile.c: Do not include py-ref.h.
 852         * python/py-param.c: Do not include py-ref.h.
 853         * python/py-prettyprint.c: Do not include py-ref.h.
 854         * python/py-progspace.c: Do not include py-ref.h.
 855         * python/py-symbol.c: Do not include py-ref.h.
 856         * python/py-symtab.c: Do not include py-ref.h.
 857         * python/py-type.c: Do not include py-ref.h.
 858         * python/py-unwind.c: Do not include py-ref.h.
 859         * python/py-utils.c: Do not include py-ref.h.
 860         * python/py-value.c: Do not include py-ref.h.
 861         * python/py-varobj.c: Do not include py-ref.h.
 862         * python/py-xmethods.c: Do not include py-ref.h.
 863         * python/python.c: Do not include py-ref.h.
 864         * varobj.c: Do not include py-ref.h.
 865
 866 2019-01-22  Tom Tromey  <tom@tromey.com>
 867
 868         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 869         keyword for bcache.
 870
 871 2019-01-22  Tom Tromey  <tom@tromey.com>
 872
 873         * compile/compile-cplus-types.c: Remove a comment by #include.
 874
 875 2019-01-22  Tom Tromey  <tom@tromey.com>
 876
 877         * compile/gcc-c-plugin.h: Include compile-internal.h.
 878
 879 2019-01-22  Tom Tromey  <tom@tromey.com>
 880
 881         * stabsread.c (EXTERN): Do not define.
 882         (symnum, next_symbol_text_func, processing_gcc_compilation)
 883         (within_function, global_sym_chain, global_stabs)
 884         (previous_stab_code, this_object_header_files)
 885         (n_this_object_header_files)
 886         (n_allocated_this_object_header_files): Define.
 887         * stabsread.h (EXTERN): Never define.  Use "extern".
 888
 889 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 890
 891         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 892         history_value.
 893
 894 2019-01-21  Tom Tromey  <tom@tromey.com>
 895
 896         * ui-out.c: Fix includes.
 897         * tui/tui-source.c: Fix includes.
 898         * target.c: Fix includes.
 899         * remote.c: Fix includes.
 900         * regcache.c: Fix includes.
 901         * python/py-block.c: Fix includes.
 902         * printcmd.c: Fix includes.
 903         * or1k-tdep.c: Fix includes.
 904         * mi/mi-main.c: Fix includes.
 905         * m32r-tdep.c: Fix includes.
 906         * csky-tdep.c: Fix includes.
 907         * compile/compile-cplus-types.c: Fix includes.
 908         * cli/cli-interp.c: Fix includes.
 909
 910 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 911
 912         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 913         for padding.
 914
 915 2019-01-16  Tom Tromey  <tom@tromey.com>
 916
 917         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 918         earlier.
 919         (struct objfile) <msymbols_range>: Move from top level.
 920         <msymbols>: New method.
 921         (class objfile_msymbols): Remove.
 922         * symtab.c (default_collect_symbol_completion_matches_break_on):
 923         Update.
 924         * symmisc.c (dump_msymbols): Update.
 925         * stabsread.c (scan_file_globals): Update.
 926         * objc-lang.c (info_selectors_command, info_classes_command)
 927         (find_methods): Update.
 928         * minsyms.c (find_solib_trampoline_target): Update.
 929         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 930         * coffread.c (coff_symfile_read): Update.
 931         * ada-lang.c (ada_lookup_simple_minsym)
 932         (ada_collect_symbol_completion_matches): Update.
 933
 934 2019-01-16  Tom Tromey  <tom@tromey.com>
 935
 936         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 937         type.  Remove no-argument constructor.
 938         <iterator::operator++>: Simplify.
 939         <begin>: Update.
 940         <end>: Use minimal_symbol_count.
 941
 942 2019-01-16  Tom Tromey  <tom@tromey.com>
 943
 944         * objfiles.h (struct objfile) <psymtabs>: New method.
 945         (class objfile_psymtabs): Remove.
 946         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 947         typedef.
 948         <range>: New method.
 949         (require_partial_symbols): Change return type.
 950         * psymtab.c (require_partial_symbols)
 951         (psym_expand_symtabs_matching): Update.
 952         * mdebugread.c (parse_partial_symbols): Update.
 953         * dbxread.c (dbx_end_psymtab): Update.
 954
 955 2019-01-15  Tom Tromey  <tom@tromey.com>
 956
 957         * symtab.c (lookup_objfile_from_block)
 958         (lookup_symbol_in_objfile_symtabs)
 959         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 960         (find_line_symtab, info_sources_command)
 961         (default_collect_symbol_completion_matches_break_on)
 962         (make_source_files_completion_list): Update.
 963         * symmisc.c (print_objfile_statistics, dump_objfile)
 964         (maintenance_print_symbols, maintenance_info_symtabs)
 965         (maintenance_check_symtabs, maintenance_info_line_tables):
 966         Update.
 967         * source.c (select_source_symtab)
 968         (forget_cached_source_info_for_objfile): Update.
 969         * objfiles.h (class objfile_compunits): Remove.
 970         (struct objfile) <compunits_range>: New typedef.
 971         (compunits): New method.
 972         * objfiles.c (objfile_relocate1): Update.
 973         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 974         * maint.c (count_symtabs_and_blocks): Update.
 975         * linespec.c (iterate_over_all_matching_symtabs): Update.
 976         * cp-support.c (add_symbol_overload_list_qualified): Update.
 977         * coffread.c (coff_symtab_read): Update.
 978         * ada-lang.c (add_nonlocal_symbols)
 979         (ada_collect_symbol_completion_matches)
 980         (ada_add_global_exceptions): Update.
 981
 982 2019-01-15  Tom Tromey  <tom@tromey.com>
 983
 984         * progspace.h (program_space) <objfiles_safe_range>: New
 985         typedef.
 986         <objfiles_safe>: New method.
 987         * objfiles.h (class all_objfiles_safe): Remove.
 988         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 989         * jit.c (jit_inferior_exit_hook): Update.
 990
 991 2019-01-17  Tom Tromey  <tom@tromey.com>
 992
 993         * progspace.h (program_space) <objfiles_range>: New typedef.
 994         <objfiles>: New method.
 995         <objfiles_head>: Rename from objfiles.
 996         (object_files): Update.
 997         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 998         * guile/scm-pretty-print.c
 999         (ppscm_find_pretty_printer_from_objfiles): Update.
1000         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1001         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1002         Update.
1003         * python/py-progspace.c (pspy_get_objfiles): Update.
1004         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1005         Update.
1006         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1007         (objfpy_lookup_objfile_by_build_id): Update.
1008         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1009         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1010         Update.
1011         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1012         (expand_symtab_containing_pc, lookup_objfile_from_block)
1013         (lookup_static_symbol, basic_lookup_transparent_type)
1014         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1015         (find_line_symtab, info_sources_command)
1016         (default_collect_symbol_completion_matches_break_on)
1017         (make_source_files_completion_list, find_main_name): Update.
1018         * symmisc.c (print_symbol_bcache_statistics)
1019         (print_objfile_statistics, maintenance_print_symbols)
1020         (maintenance_print_msymbols, maintenance_print_objfiles)
1021         (maintenance_info_symtabs, maintenance_check_symtabs)
1022         (maintenance_expand_symtabs, maintenance_info_line_tables):
1023         Update.
1024         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1025         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1026         (map_overlay_command, unmap_overlay_command)
1027         (simple_overlay_update, expand_symtabs_matching)
1028         (map_symbol_filenames): Update.
1029         * symfile-debug.c (set_debug_symfile): Update.
1030         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1031         Update.
1032         * source.c (select_source_symtab, forget_cached_source_info):
1033         Update.
1034         * solib.c (solib_read_symbols): Update.
1035         * solib-spu.c (append_ocl_sos): Update.
1036         * psymtab.c (maintenance_print_psymbols)
1037         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1038         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1039         * printcmd.c (info_symbol_command): Update.
1040         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1041         Update.
1042         * objfiles.h (class all_objfiles): Remove.
1043         * objfiles.c (have_partial_symbols, have_full_symbols)
1044         (have_minimal_symbols, qsort_cmp, update_section_map)
1045         (shared_objfile_contains_address_p)
1046         (default_iterate_over_objfiles_in_search_order): Update.
1047         * objc-lang.c (info_selectors_command, info_classes_command)
1048         (find_methods): Update.
1049         * minsyms.c (find_solib_trampoline_target): Update.
1050         * maint.c (maintenance_info_sections)
1051         (maintenance_translate_address, count_symtabs_and_blocks):
1052         Update.
1053         * main.c (captured_main_1): Update.
1054         * linux-thread-db.c (try_thread_db_load_from_pdir)
1055         (has_libpthread): Update.
1056         * linespec.c (iterate_over_all_matching_symtabs)
1057         (search_minsyms_for_name): Update.
1058         * jit.c (jit_find_objf_with_entry_addr): Update.
1059         * hppa-tdep.c (find_unwind_entry)
1060         (hppa_lookup_stub_minimal_symbol): Update.
1061         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1062         Update.
1063         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1064         (elf_gnu_ifunc_resolve_by_got): Update.
1065         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1066         * dwarf-index-write.c (save_gdb_index_command): Update.
1067         * cp-support.c (add_symbol_overload_list_qualified): Update.
1068         * breakpoint.c (create_overlay_event_breakpoint)
1069         (create_longjmp_master_breakpoint)
1070         (create_std_terminate_master_breakpoint)
1071         (create_exception_master_breakpoint): Update.
1072         * blockframe.c (find_pc_partial_function): Update.
1073         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1074         (ada_collect_symbol_completion_matches)
1075         (ada_add_global_exceptions): Update.
1076
1077 2019-01-17  Tom Tromey  <tom@tromey.com>
1078
1079         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1080         declare VEC.
1081         (solib_target_parse_libraries): Change return type.
1082         (library_list_start_segment, library_list_start_section)
1083         (library_list_end_library, library_list_start_library); Update.
1084         (solib_target_free_library_list): Remove.
1085         (solib_target_parse_libraries): Remove cleanup.  Change return
1086         type.
1087         (solib_target_current_sos): Update.
1088
1089 2019-01-17  Tom Tromey  <tromey@bapiya>
1090
1091         * valprint.c: Replace "the the" with "the".
1092         * symtab.c: Replace "the the" with "the".
1093         * solib.c: Replace "the the" with "the".
1094         * solib-dsbt.c: Replace "the the" with "the".
1095         * linespec.c: Replace "the the" with "the".
1096         * dwarf2loc.h: Replace "the the" with "the".
1097         * amd64-windows-tdep.c: Replace "the the" with "the".
1098         * aarch64-tdep.c: Replace "the the" with "the".
1099
1100 2019-01-16  Keith Seitz  <keiths@redhat.com>
1101
1102         PR gdb/23773
1103         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1104         <builder>: Rename to ..
1105         <m_builder>: ... this and make private.
1106         (dwarf2_cu::get_builder): New method.  Change all users of
1107         `builder' to use this method.
1108         (dwarf2_start_symtab): Move to ...
1109         (dwarf2_cu::start_symtab): ... here.  Update all callers
1110         (setup_type_unit_groups): Move to ...
1111         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1112         callers.
1113         (dwarf2_cu::reset_builder): New method.
1114         (process_full_compunit, process_full_type_unit): Use
1115         dwarf2_cu::reset_builder.
1116         (follow_die_offset): Record the ancestor CU if it is different
1117         from the followed DIE's CU.
1118         (follow_die_sig_1): Likewise.
1119
1120 2019-01-15  Tom Tromey  <tom@tromey.com>
1121
1122         * remote.c (class remote_state) <buf>: Now a char_vector.
1123         <buf_size>: Remove.
1124         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1125         parameter.
1126         (remote_target::getpkt_or_notif_sane_1)
1127         (remote_target::getpkt_sane)
1128         (remote_target::getpkt_or_notif_sane): Likewise.
1129         (class remote_target) <putpkt>: New overload.
1130         (remote_target::read_frame): Change type of "buf_p".  Remove
1131         sizeof_p parameter.
1132         (packet_ok): New overload.
1133         (packet_check_result): New overload.
1134         Update all uses.
1135
1136 2019-01-14  Tom Tromey  <tom@tromey.com>
1137
1138         * remote-notif.c (handle_notification, remote_notif_ack)
1139         (remote_notif_parse): Make "buf" const.
1140         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1141         const.
1142         (remote_notif_parse, remote_notif_ack, handle_notification):
1143         Likewise.
1144         * remote.c (remote_notif_stop_parse): Make "buf" const.
1145         (remote_target::remote_parse_stop_reply): Make "buf" const.
1146         (remote_notif_stop_ack): Make "buf" const.
1147
1148 2019-01-14  Tom Tromey  <tom@tromey.com>
1149
1150         * remote.c (remote_console_output): Make parameter const.
1151
1152 2019-01-14  Tom Tromey  <tom@tromey.com>
1153
1154         * target-debug.h (target_debug_print_signals): Constify.
1155         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1156         * procfs.c (procfs_target::pass_signals): Update.
1157         * linux-nat.c (linux_nat_target::pass_signals): Update.
1158         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1159         * target-delegates.c: Rebuild.
1160         * remote.c (remote_target::program_signals): Update.
1161         (remote_target::pass_signals): Update.
1162         * target.c (target_pass_signals): Constify argument.
1163         (target_program_signals): Likewise.
1164         * target.h (struct target_ops) <pass_signals, program_signals>:
1165         Constify argument.
1166         (target_pass_signals, target_program_signals): Constify argument.
1167
1168 2019-01-14  Tom Tromey  <tom@tromey.com>
1169
1170         PR tui/28819:
1171         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1172
1173 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1174
1175         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1176         field.
1177         * rs6000-tdep.c: Include reggroups.h.
1178         (IS_V_ALIAS_PSEUDOREG): Define.
1179         (rs6000_register_name): Return names for the "vX" aliases.
1180         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1181         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1182         aliases.  Call default_register_reggroup_p for all other
1183         pseudo-registers.
1184         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1185         New functions.
1186         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1187         Handle "vX" aliases.
1188         (v_alias_pseudo_register_collect): New function.
1189         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1190         (rs6000_gdbarch_init): Initialize "vX" aliases as
1191         pseudo-registers.  Restore registration of
1192         rs6000_pseudo_register_reggroup_p with
1193         set_tdesc_pseudo_register_reggroup_p.
1194
1195 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1196
1197         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1198         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1199         set_gdbarch_num_pseudo_regs.
1200
1201 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1202
1203         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1204         Remove arg prefixname, add do_set and do_show.
1205         Add member functions set_list and show_list.
1206         * cli/cli-style.c (class cli_style_option): Update accordingly.
1207         (style_set_list): Move to file scope.
1208         (style_show_list): Likewise.
1209         (set_style): Call help_list.
1210         (show_style): Call cmd_show_list.
1211         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1212         Update to use the new macro.
1213
1214 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1215
1216         * ada-lang.c (_initialize_ada_language): Expand the help text
1217         for the "catch exception" command.
1218
1219 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1220
1221         * symtab.c (matching_obj_sections): Initialize obj,
1222         declare it closer to its usage.
1223
1224 2019-01-10  Tom Tromey  <tom@tromey.com>
1225
1226         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1227         (basic_inf_threads_range): Remove.
1228         (inf_threads_range, inf_non_exited_threads_range)
1229         (safe_inf_threads_range): Use next_adapter.
1230
1231 2019-01-10  Keith Seitz  <keiths@redhat.com>
1232
1233         PR gdb/23712
1234         PR symtab/23010
1235         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1236         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1237
1238 2019-01-10  Keith Seitz  <keiths@redhat.com>
1239
1240         PR gdb/23712
1241         PR symtab/23010
1242         * dictionary.c (pending_to_vector): Remove.
1243         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1244         Remove _1 suffix, replacing functions of the same name.  Update
1245         all callers.
1246         (dict_create_hashed, dict_create_hashed_expandable)
1247         (dict_create_linear, dict_create_linear_expandable, dict_free)
1248         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1249         Make functions static.
1250
1251 2019-01-10  Keith Seitz  <keiths@redhat.com>
1252
1253         PR gdb/23712
1254         PR symtab/23010
1255         * dictionary.h (struct dictionary): Replace declaration with
1256         multidictionary.
1257         (dict_create_hashed, dict_create_hashed_expandable)
1258         (dict_create_linear, dict_create_linear_expandable)
1259         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1260         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1261         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1262         taking multidictionary argument.
1263         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1264         * block.h (struct block) <dict>: Change to multidictionary
1265         and rename `multidict'.
1266         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1267         symmisc.c: Update all dictionary references to multidictionary.
1268
1269 2019-01-10  Keith Seitz  <keiths@redhat.com>
1270
1271         PR gdb/23712
1272         PR symtab/23010
1273         * dictionary.c: Include unordered_map.
1274         (pending_to_vector): New function.
1275         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1276         Rewrite the non-"_1" functions to take vector instead
1277         of linked list.
1278         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1279         "new" _1 versions of the same name.
1280         (multidictionary): Define.
1281         (std::hash<enum language): New definition.
1282         (collate_pending_symbols_by_language, mdict_create_hashed)
1283         (mdict_create_hashed_expandable, mdict_create_linear)
1284         (mdict_create_linear_expandable, mdict_free)
1285         (find_language_dictionary, create_new_language_dictionary)
1286         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1287         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1288         (mdict_size, mdict_empty): New functions.
1289         * dictionary.h (mdict_iterator): Define.
1290
1291 2019-01-10  Pedro Alves  <palves@redhat.com>
1292
1293         * breakpoint.c (read_uploaded_action)
1294         (create_tracepoint_from_upload): Adjust to use
1295         gdb::unique_xmalloc_ptr.
1296         * ctf.c (ctf_write_uploaded_tp):
1297         (SET_ARRAY_FIELD): Use emplace_back.
1298         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1299         * tracefile-tfile.c (tfile_write_uploaded_tp):
1300         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1301         gdb::unique_xmalloc_ptr.
1302         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1303         at_string, cond_string, cmd_strings>: Replace char pointers
1304         with gdb::unique_xmalloc_ptr.
1305
1306 2019-01-10  Pedro Alves  <palves@redhat.com>
1307
1308         * solib-target.c (library_list_start_library): Don't xstrdup name.
1309
1310 2019-01-10  Pedro Alves  <palves@redhat.com>
1311
1312         * mdebugread.c (parse_partial_symbols): Use
1313         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1314
1315 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1316
1317         * linux-fork.c (scoped_switch_fork_info)
1318         <~scoped_switch_fork_info>: Fix incorrect variable name.
1319
1320 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1321
1322         * linux-fork.c (scoped_switch_fork_info)
1323         <scoped_switch_fork_info>: Make explicit.
1324         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1325
1326 2019-01-10  Tom Tromey  <tom@tromey.com>
1327
1328         * objfiles.h (objfile::reset_psymtabs): Update.
1329         * objfiles.c (objfile::objfile): Update.
1330         * psymtab.h (psymtab_storage::obstack): Update.
1331         (psymtab_storage::m_obstack): Use gdb::optional.
1332         (class psymtab_storage): Update comment.  Remove objfile
1333         parameter.
1334         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1335
1336 2019-01-10  Tom Tromey  <tom@tromey.com>
1337
1338         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1339         <free_psymtabs>: Now private.
1340         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1341         (allocate_psymtab): Use new method.
1342
1343 2019-01-10  Tom Tromey  <tom@tromey.com>
1344
1345         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1346         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1347         * mdebugread.c (parse_partial_symbols): Use
1348         allocate_dependencies.
1349         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1350         allocate_dependencies.
1351         (process_psymtab_comp_unit_reader)
1352         (build_type_psymtab_dependencies): Likewise.
1353         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1354
1355 2019-01-10  Tom Tromey  <tom@tromey.com>
1356
1357         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1358         PSYMBOL_SET_LANGUAGE.
1359         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1360
1361 2019-01-10  Tom Tromey  <tom@tromey.com>
1362
1363         * psymtab.h (psymtab_storage::obstack): New method.
1364         <m_obstack>: Rename from obstack; now private.
1365         * psymtab.c (psymtab_storage): Update.
1366         * dwarf2read.c (create_addrmap_from_index)
1367         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1368         Update.
1369
1370 2019-01-10  Tom Tromey  <tom@tromey.com>
1371
1372         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1373         * objfiles.h (objfile::reset_psymtabs): New method.
1374
1375 2019-01-10  Tom Tromey  <tom@tromey.com>
1376
1377         * symmisc.c (print_symbol_bcache_statistics): Update.
1378         (print_objfile_statistics): Update.
1379         * symfile.c (reread_symbols): Update.
1380         * psymtab.h (class psymtab_storage): New.
1381         * psymtab.c (psymtab_storage): New constructor.
1382         (~psymtab_storage): New destructor.
1383         (require_partial_symbols): Update.
1384         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1385         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1386         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1387         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1388         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1389         (start_psymtab_common, end_psymtab_common)
1390         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1391         (allocate_psymtab): Update.
1392         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1393         Update.
1394         (dump_psymtab_addrmap, maintenance_print_psymbols)
1395         (maintenance_check_psymtabs): Update.
1396         (class objfile_psymtabs): Move to objfiles.h.
1397         * psympriv.h (discard_psymtab): Now inline.
1398         (psymtab_discarder::psymtab_discarder): Update.
1399         (psymtab_discarder::~psymtab_discarder): Update.
1400         (ALL_OBJFILE_PSYMTABS): Rewrite.
1401         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1402         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1403         Remove fields.
1404         <partial_symtabs>: New field.
1405         (class objfile_psymtabs): Move from psymtab.h.  Update.
1406         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1407         psymbol_cache.
1408         (objfile::~objfile): Don't destroy psymbol_cache.
1409         * mdebugread.c (parse_partial_symbols): Update.
1410         * dwarf2read.c (create_addrmap_from_index)
1411         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1412         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1413         (add_partial_subprogram, dwarf2_ranges_read): Update.
1414         * dwarf-index-write.c (write_address_map)
1415         (write_one_signatured_type, recursively_write_psymbols)
1416         (class debug_names, class debug_names, write_psymtabs_to_index):
1417         Update.
1418
1419 2019-01-10  Tom Tromey  <tom@tromey.com>
1420
1421         * symtab.h (SYMBOL_SET_NAMES): Update.
1422         (symbol_set_names): Update.
1423         (MSYMBOL_SET_NAMES): Update.
1424         * symtab.c (symbol_set_names): Change argument to be an
1425         objfile_per_bfd_storage.
1426         * psymtab.c (add_psymbol_to_bcache): Update.
1427         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1428
1429 2019-01-10  Tom Tromey  <tom@tromey.com>
1430
1431         * symtab.c (create_demangled_names_hash): Change argument to be an
1432         objfile_per_bfd_storage.
1433         (symbol_set_names): Update.
1434
1435 2019-01-10  Tom Tromey  <tom@tromey.com>
1436
1437         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1438         init_psymbol_list.
1439         * psymtab.c (init_psymbol_list): Do nothing if already called.
1440         * psympriv.h (init_psymbol_list): Add comment.
1441         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1442         init_psymbol_list.
1443         * dbxread.c (dbx_symfile_read): Unconditionally call
1444         init_psymbol_list.
1445
1446 2019-01-10  Tom Tromey  <tom@tromey.com>
1447
1448         * xcoffread.c (scan_xcoff_symtab): Update.
1449         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1450         "where".
1451         * mdebugread.c (parse_partial_symbols)
1452         (handle_psymbol_enumerators): Update.
1453         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1454         * dbxread.c (read_dbx_symtab): Update.
1455         * psympriv.h (psymbol_placement): New enum.
1456         (add_psymbol_to_list): Update.
1457
1458 2019-01-10  Tom Tromey  <tom@tromey.com>
1459
1460         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1461         static_psymbols parameters.
1462         (scan_xcoff_symtab): Update.
1463         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1464         static_psymbols parameters.
1465         * psympriv.h (start_psymtab_common): Update.
1466         * mdebugread.c (parse_partial_symbols): Update.
1467         * dwarf2read.c (create_partial_symtab): Update.
1468         * dbxread.c (read_dbx_symtab): Update.
1469         (start_psymtab): Remove global_psymbols and static_psymbols
1470         parameters.
1471
1472 2019-01-10  Tom Tromey  <tom@tromey.com>
1473
1474         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1475         * psymtab.c (allocate_psymtab): Add comment.
1476         * psympriv.h (allocate_psymtab): Add comment.
1477         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1478         initializations.
1479         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1480
1481 2019-01-10  Tom Tromey  <tom@tromey.com>
1482
1483         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1484         Don't declare.
1485         * mipsread.c: Include mdebugread.h.
1486         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1487         Declare.
1488         * elfread.c: Include mdebugread.h.
1489
1490 2019-01-09  Tom Tromey  <tom@tromey.com>
1491
1492         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1493         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1494         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1495         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1496         (psym_lookup_symbol, psym_find_last_source_symtab)
1497         (psym_forget_cached_source_info, psym_print_stats)
1498         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1499         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1500         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1501         (psym_find_compunit_symtab_by_address)
1502         (maintenance_print_psymbols, maintenance_info_psymtabs)
1503         (maintenance_check_psymtabs): Use ranged for.
1504         * psymtab.h (class objfile_psymtabs): New.
1505         (require_partial_symbols): Return objfile_psymtabs.
1506         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1507
1508 2019-01-09  Tom Tromey  <tom@tromey.com>
1509
1510         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1511         (find_pc_mapped_section, list_overlays_command)
1512         (map_overlay_command, unmap_overlay_command)
1513         (simple_overlay_update): Use all_objfiles.
1514         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1515         * printcmd.c (info_symbol_command): Use all_objfiles.
1516         * objfiles.h (ALL_OBJSECTIONS): Remove.
1517         * maint.c (maintenance_translate_address): Use all_objfiles.
1518         * gcore.c (gcore_create_callback): Use all_objfiles.
1519         (objfile_find_memory_regions): Likewise.
1520
1521 2019-01-09  Tom Tromey  <tom@tromey.com>
1522
1523         * symtab.c (find_line_symtab, info_sources_command)
1524         (make_source_files_completion_list): Use objfile_compunits.
1525         * source.c (select_source_symtab): Use objfile_compunits.
1526         * objfiles.h (struct objfile): Update comment.
1527         (ALL_OBJFILES): Remove.
1528         (ALL_FILETABS): Remove.
1529         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1530         objfile_compunits.
1531
1532 2019-01-09  Tom Tromey  <tom@tromey.com>
1533
1534         * symmisc.c (print_objfile_statistics, dump_objfile)
1535         (maintenance_print_symbols): Use compunit_filetabs.
1536         * source.c (forget_cached_source_info_for_objfile): Use
1537         compunit_filetabs.
1538         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1539         (ALL_FILETABS): Use compunit_filetabs.
1540         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1541         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1542
1543 2019-01-09  Tom Tromey  <tom@tromey.com>
1544
1545         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1546         (compunit_filetabs): New.
1547         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1548         compunit_filetabs.
1549         (info_sources_command, make_source_files_completion_list): Remove
1550         declaration.
1551         * symmisc.c (print_objfile_statistics, dump_objfile)
1552         (maintenance_print_symbols): Remove declaration.
1553         (maintenance_info_symtabs): Use compunit_filetabs.
1554         (maintenance_info_line_tables): Likewise.
1555         * source.c (select_source_symtab): Change local variable name.
1556         (forget_cached_source_info_for_objfile): Remove declaration.
1557         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1558         * objfiles.c (objfile_relocate1): Remove declaration.
1559         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1560         declaration.
1561         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1562         * coffread.c (coff_symtab_read): Remove declaration.
1563         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1564         compunit_filetabs.
1565
1566 2019-01-09  Tom Tromey  <tom@tromey.com>
1567
1568         * symtab.c (lookup_objfile_from_block)
1569         (find_pc_sect_compunit_symtab, search_symbols)
1570         (default_collect_symbol_completion_matches_break_on): Use
1571         objfile_compunits.
1572         * objfiles.h (ALL_COMPUNITS): Remove.
1573         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1574         * cp-support.c (add_symbol_overload_list_qualified): Use
1575         objfile_compunits.
1576         * ada-lang.c (ada_collect_symbol_completion_matches)
1577         (ada_add_global_exceptions): Use objfile_compunits.
1578
1579 2019-01-09  Tom Tromey  <tom@tromey.com>
1580
1581         * source.c (select_source_symtab)
1582         (forget_cached_source_info_for_objfile): Remove declaration.
1583         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1584         declaration.
1585         * maint.c (count_symtabs_and_blocks): Remove declaration.
1586         * cp-support.c (add_symbol_overload_list_qualified): Remove
1587         declaration.
1588         * coffread.c (coff_symtab_read): Remove declaration.
1589         * symtab.c (lookup_symbol_in_objfile_symtabs)
1590         (basic_lookup_transparent_type_1): Use objfile_compunits.
1591         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1592         (info_sources_command, search_symbols)
1593         (default_collect_symbol_completion_matches_break_on)
1594         (make_source_files_completion_list): Remove declaration.
1595         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1596         (ada_collect_symbol_completion_matches)
1597         (ada_add_global_exceptions): Remove declaration.
1598         * linespec.c (iterate_over_all_matching_symtabs): Use
1599         objfile_compunits.
1600         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1601         (class objfile_compunits): New.
1602         (ALL_COMPUNITS): Use objfile_compunits.
1603         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1604         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1605         objfile_compunits.
1606         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1607
1608 2019-01-09  Tom Tromey  <tom@tromey.com>
1609
1610         * symtab.c (search_symbols)
1611         (default_collect_symbol_completion_matches_break_on): Use
1612         objfile_msymbols.
1613         * ada-lang.c (ada_lookup_simple_minsym)
1614         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1615         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1616         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1617         objfile_msymbols.
1618         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1619         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1620         * objc-lang.c (find_methods): Use objfile_msymbols.
1621         (info_selectors_command, info_classes_command): Likewise.
1622         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1623         * objfiles.h (class objfile_msymbols): New.
1624         (ALL_OBJFILE_MSYMBOLS): Remove.
1625         (ALL_MSYMBOLS): Remove.
1626
1627 2019-01-09  Tom Tromey  <tom@tromey.com>
1628
1629         * common/next-iterator.h (next_adapter): Add Iterator template
1630         parameter.
1631         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1632         (class all_objfiles_safe): New.
1633         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1634         * objfiles.c (put_objfile_before): Update comment.
1635         (add_separate_debug_objfile): Likewise.
1636         (free_all_objfiles): Use all_objfiles_safe.
1637         (objfile_purge_solibs): Likewise.
1638
1639 2019-01-09  Tom Tromey  <tom@tromey.com>
1640
1641         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1642         (expand_symtab_containing_pc, lookup_static_symbol)
1643         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1644         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1645         all_objfiles.
1646         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1647         * breakpoint.c (create_overlay_event_breakpoint)
1648         (create_longjmp_master_breakpoint)
1649         (create_std_terminate_master_breakpoint)
1650         (create_exception_master_breakpoint): Use all_objfiles.
1651         * linux-thread-db.c (try_thread_db_load_from_pdir)
1652         (has_libpthread): Use all_objfiles.
1653         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1654         * linespec.c (iterate_over_all_matching_symtabs)
1655         (search_minsyms_for_name): Use all_objfiles.
1656         * maint.c (maintenance_info_sections): Use all_objfiles.
1657         * main.c (captured_main_1): Use all_objfiles.
1658         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1659         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1660         * guile/scm-pretty-print.c
1661         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1662         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1663         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1664         (maintenance_print_msymbols): Use all_objfiles.
1665         * source.c (select_source_symtab): Use all_objfiles.
1666         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1667         * symfile.c (remove_symbol_file_command)
1668         (expand_symtabs_matching, map_symbol_filenames): Use
1669         all_objfiles.
1670         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1671         all_objfiles.
1672         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1673         * objc-lang.c (find_methods): Use all_objfiles.
1674         * objfiles.c (have_partial_symbols, have_full_symbols)
1675         (have_minimal_symbols, qsort_cmp)
1676         (default_iterate_over_objfiles_in_search_order): Use
1677         all_objfiles.
1678         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1679         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1680         (maintenance_check_psymtabs): Use all_objfiles.
1681         (ALL_PSYMTABS): Remove.
1682         * compile/compile-object-run.c (do_module_cleanup): Use
1683         all_objfiles.
1684         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1685         * cp-support.c (add_symbol_overload_list_qualified): Use
1686         all_objfiles.
1687         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1688         Use all_objfiles.
1689         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1690         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1691         all_objfiles.
1692         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1693         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1694         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1695         Uses all_objfiles.
1696         * solib.c (solib_read_symbols): Use all_objfiles
1697
1698 2019-01-09  Tom Tromey  <tom@tromey.com>
1699
1700         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1701         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1702         all_objfiles.
1703         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1704         * symmisc.c (print_symbol_bcache_statistics)
1705         (print_objfile_statistics, maintenance_print_objfiles)
1706         (maintenance_info_symtabs, maintenance_check_symtabs)
1707         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1708         all_objfiles.
1709         * source.c (forget_cached_source_info): Use all_objfiles.
1710         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1711         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1712         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1713         * objfiles.c (update_section_map): Use all_objfiles.
1714         (shared_objfile_contains_address_p): Likewise.
1715         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1716         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1717
1718 2019-01-09  Tom Tromey  <tom@tromey.com>
1719
1720         * common/next-iterator.h: New file.
1721         * objfiles.h (class all_objfiles): New.
1722         (struct objfile_iterator): New.
1723
1724 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1725
1726         * NEWS: Move the description of the changed "frame", "select-frame",
1727          and "info frame" commands to the Changed commands section.
1728
1729 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1730
1731         * gdbtypes.c (check_stub_method_group): Remove handling of old
1732         mangling schemes.
1733         * linespec.c (find_methods): Likewise.
1734         * stabsread.c (read_member_functions): Likewise.
1735         * valops.c (search_struct_method): Likewise.
1736         (value_struct_elt_for_reference): Likewise.
1737         * NEWS: Mention this change.
1738
1739 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1740
1741         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1742         print_source_lines.
1743         * source.c (print_source_lines_base): Update line number check.
1744         (print_source_lines): New function.
1745         (source_lines_range::source_lines_range): New function.
1746         * source.h (class source_lines_range): New class.
1747         (print_source_lines): New declaration.
1748
1749 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1750
1751         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1752
1753 2019-01-08  Tom Tromey  <tom@tromey.com>
1754             Simon Marchi  <simon.marchi@ericsson.com>
1755
1756         PR gdb/24060
1757         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1758         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1759         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1760         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1761         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1762         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1763
1764 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1765
1766         * source.c (select_source_symtab): Move header comment to
1767         declaration in source.h.
1768         (forget_cached_source_info_for_objfile): Likewise.
1769         (forget_cached_source_info): Likewise.
1770         (identify_source_line): Likewise.
1771         * source.h (identify_source_line): Move declaration from symtab.h
1772         and add comment from source.c
1773         (print_source_lines): Likewise.
1774         (forget_cached_source_info_for_objfile): Likewise.
1775         (forget_cached_source_info): Likewise.
1776         (select_source_symtab): Likewise.
1777         (enum print_source_lines_flag): Move definition from symtab.h.
1778         * symtab.h (identify_source_line): Move declaration to source.h.
1779         (print_source_lines): Likewise.
1780         (forget_cached_source_info_for_objfile): Likewise.
1781         (forget_cached_source_info): Likewise.
1782         (select_source_symtab): Likewise.
1783         (enum print_source_lines_flag): Move definition to source.h.
1784         * tui/tui-hooks.c: Add 'source.h' include.
1785
1786 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1787
1788         * source.c (print_source_lines_base): Handle requests to print
1789         reverse line number sequences, and guard against empty lines
1790         string.
1791
1792 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1793
1794         * source.c (print_source_lines_base): Fix skip of '\r' if next
1795         character is '\n'.
1796
1797 2019-01-06  Tom Tromey  <tom@tromey.com>
1798
1799         * c-exp.y (struct c_parse_state) <macro_original_text,
1800         expansion_obstack>: New member.
1801         (macro_original_text, expansion_obstack): Remove globals.
1802         (scan_macro_expansion, scanning_macro_expansion)
1803         (finished_macro_expansion): Update.
1804         (scan_macro_cleanup): Remove.
1805         (yylex, c_parse): Update.
1806
1807 2019-01-06  Tom Tromey  <tom@tromey.com>
1808
1809         * c-exp.y (struct c_parse_state) <strings>: New member.
1810         (operator_stoken): Update.
1811
1812 2019-01-06  Tom Tromey  <tom@tromey.com>
1813
1814         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1815         (union type_stack_elt) <typelist_val>: Now a pointer to
1816         std::vector.
1817         (type_stack_cleanup): Don't declare.
1818         (push_typelist): Update.
1819         * parse.c (pop_typelist): Return a std::vector.
1820         (push_typelist): Take a std::vector.
1821         (follow_types): Update.  Do not free args.
1822         (type_stack_cleanup): Remove.
1823         * c-exp.y (struct c_parse_state): New.
1824         (cpstate): New global.
1825         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1826         (nonempty_typelist): Update.
1827         (func_mod): Create a new vector.
1828         (c_parse): Create a c_parse_state.
1829         (check_parameter_typelist): Do not delete params.
1830         (function_method): Update.  Do not delete type_list.
1831
1832 2019-01-06  Tom Tromey  <tom@tromey.com>
1833
1834         PR gdb/28155:
1835         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1836         check_typedef.
1837         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1838         (print_return_value): Likewise.
1839
1840 2019-01-05  Tom Tromey  <tom@tromey.com>
1841
1842         * contrib/cleanup_check.py: Remove.
1843         * contrib/gcc-with-excheck: Remove.
1844         * contrib/exsummary.py: Remove.
1845         * contrib/excheck.py: Remove.
1846
1847 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1848
1849         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1850         NULL. Initialize tpprev to NULL instead of assigning it
1851         to NULL on the next statement.
1852         * windows-nat.c (windows_delete_thread): Remove check for
1853         main_thread_id before printing thread exit notifications.
1854         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1855         Remove thread ID check against main_thread_id.
1856         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1857         windows_delete_thread.
1858         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1859
1860 2019-01-04  Tom Tromey  <tom@tromey.com>
1861
1862         * compile/compile.c (_initialize_compile): Use upper case for
1863         metasyntactic variables.
1864         * symmisc.c (_initialize_symmisc): Use upper case for
1865         metasyntactic variables.
1866         * psymtab.c (_initialize_psymtab): Use upper case for
1867         metasyntactic variables.
1868         * demangle.c (demangle_command): Use upper case for metasyntactic
1869         variables.
1870         (_initialize_demangler): Likewise.
1871         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1872         variables.
1873
1874 2019-01-03  Tom Tromey  <tom@tromey.com>
1875
1876         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1877
1878 2019-01-03  Tom Tromey  <tom@tromey.com>
1879
1880         * python/py-symtab.c (salpy_str): Update.
1881         (struct salpy_sal_object) <symtab>: Now a PyObject.
1882         (salpy_dealloc): Update.
1883         (del_objfile_sal): Use gdbpy_ref.
1884
1885 2019-01-03  Tom Tromey  <tom@tromey.com>
1886
1887         * python/py-type.c (convert_field): Use new_reference.  Return
1888         gdbpy_ref.
1889         (make_fielditem): Return gdbpy_ref.
1890         (typy_fields): Update.
1891         (typy_getitem): Update.
1892         (field_name): Return gdbpy_ref.  Use new_reference.
1893         (typy_iterator_iternext): Update.
1894
1895 2019-01-03  Tom Tromey  <tom@tromey.com>
1896
1897         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1898
1899 2019-01-03  Tom Tromey  <tom@tromey.com>
1900
1901         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1902         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1903         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1904         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1905         (pspy_set_type_printers): Likewise.
1906         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1907         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1908         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1909         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1910         (objfpy_set_type_printers): Likewise.
1911
1912 2019-01-03  Tom Tromey  <tom@tromey.com>
1913
1914         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1915         (gdbpy_print_stack): Use gdbpy_err_fetch.
1916         * python/python-internal.h (class gdbpy_err_fetch): New class.
1917         (class gdbpy_enter) <m_error_type, m_error_value,
1918         m_error_traceback>: Remove.
1919         <m_error>: New member.
1920         (gdbpy_exception_to_string): Don't declare.
1921         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1922         * python/py-value.c (convert_value_from_python): Use
1923         gdbpy_err_fetch.
1924         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1925         gdbpy_exception_to_string.
1926         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1927         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1928         gdbpy_err_fetch.
1929
1930 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1931
1932         * linux-nat.c (delete_lwp_cleanup): Delete.
1933         (struct lwp_deleter): New struct.
1934         (lwp_info_up): New typedef.
1935         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1936         lwp_info_up.
1937
1938 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1939
1940         * linux-fork.c (class scoped_switch_fork_info): New class.
1941         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1942
1943 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1944
1945         * valops.c (find_overload_match): Remove use of null_cleanup, and
1946         calls to do_cleanups.
1947
1948 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1949
1950         * compile/compile-cplus-types.c
1951         (compile_cplus_instance::decl_name): Handle changes to
1952         cp_func_name.
1953         * cp-support.c (cp_func_name): Update header comment, update
1954         return type.
1955         * cp-support.h (cp_func_name): Update return type in declaration.
1956         * valops.c (find_overload_match): Move temp_func local to top
1957         level of function and change its type.  Use temp_func to hold and
1958         delete temporary string obtained from cp_func_name.
1959
1960 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1961
1962         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1963         gdb::char_vector, remove cleanup, and update uses of `msg`.
1964
1965 2019-01-03  Jim Wilson  <jimw@sifive.com>
1966
1967         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1968
1969 2019-01-02  Tom Tromey  <tom@tromey.com>
1970
1971         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1972         (tdesc_parse_xml): Remove cleanups.
1973         * target-descriptions.h (make_cleanup_free_target_description):
1974         Don't declare.
1975         (target_desc_deleter): New struct.
1976         (target_desc_up): New typedef.
1977         * target-descriptions.c (target_desc_deleter::operator()): Rename
1978         from free_target_description.
1979         (make_cleanup_free_target_description): Remove.
1980
1981 2019-01-02  Tom Tromey  <tom@tromey.com>
1982
1983         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1984         constructor, destructor.
1985         (linespec_parser): Remove typedef.
1986         (~linespec_parser): Rename from linespec_parser_delete.
1987         (linespec_lex_to_end, linespec_complete_label)
1988         (linespec_complete): Update.
1989         (decode_line_full): Remove cleanups.
1990         (decode_line_1): Update.
1991
1992 2019-01-02  Tom Tromey  <tom@tromey.com>
1993
1994         * python/python-internal.h (inferior_to_inferior_object): Change
1995         return type.
1996         * python/py-exitedevent.c (create_exited_event_object): Update.
1997         * python/py-inferior.c (inferior_to_inferior_object): Return
1998         gdbpy_ref.
1999         (python_new_inferior, python_inferior_deleted)
2000         (thread_to_thread_object, delete_thread_object)
2001         (build_inferior_list, gdbpy_selected_inferior): Update.
2002         * python/py-infthread.c (create_thread_object): Update.  Also fail
2003         if inferior_to_inferior_object fails.
2004
2005 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2006
2007         * inferior.h (class inferior) <displaced_step_state>: New field.
2008         * infrun.h (struct displaced_step_state): Move here from
2009         infrun.c.  Initialize fields, add constructor.
2010         <inf>: Remove field.
2011         <reset>: New method.
2012         * infrun.c (struct displaced_step_inferior_state): Move to
2013         infrun.h.
2014         (displaced_step_inferior_states): Remove.
2015         (get_displaced_stepping_state): Adust.
2016         (displaced_step_in_progress_any_inferior): Adjust.
2017         (displaced_step_in_progress_thread): Adjust.
2018         (displaced_step_in_progress): Adjust.
2019         (add_displaced_stepping_state): Remove.
2020         (get_displaced_step_closure_by_addr): Adjust.
2021         (remove_displaced_stepping_state): Remove.
2022         (infrun_inferior_exit): Call displaced_step_state.reset.
2023         (use_displaced_stepping): Don't check for NULL.
2024         (displaced_step_prepare_throw): Call
2025         get_displaced_stepping_state.
2026         (displaced_step_fixup): Don't check for NULL.
2027         (prepare_for_detach): Don't check for NULL.
2028
2029 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2030
2031         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2032          in case of call that did not complete.
2033
2034 2019-01-02  Andrey Utkin  <autkin@undo.io>
2035
2036         * symfile.c (find_separate_debug_file): Fix search of debug files for
2037         remote debuggee.
2038
2039 2019-01-02  Tom Tromey  <tom@tromey.com>
2040
2041         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2042         indentation.
2043         * python/py-frame.c (frapy_older): Remove cast.
2044         (frapy_newer): Likewise.
2045         * python/py-breakpoint.c (local_setattro): Remove cast.
2046         * python/py-arch.c (archpy_name): Remove local variable.
2047         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2048
2049 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2050
2051         * unittests/basic_string_view/element_access/char/empty.cc:
2052         Fix year range in copyright header.
2053
2054 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2055
2056         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2057         Delete.
2058         <operator==>: Update with for removed field.
2059         <hash>: Likewise.
2060         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2061         <isa_features>: ...this.
2062         <abi_features>: New field.
2063         (riscv_isa_flen): Update comment.
2064         (riscv_abi_xlen): New declaration.
2065         (riscv_abi_flen): New declaration.
2066         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2067         isa_features.
2068         (riscv_abi_xlen): New function.
2069         (riscv_isa_flen): Update to get answer from isa_features.
2070         (riscv_abi_flen): New function.
2071         (riscv_has_fp_abi): Update to get answer from abi_features.
2072         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2073         xlen and flen.
2074         (riscv_call_info) <xlen, flen>: Update comment.
2075         (riscv_call_arg_struct): Remove invalid assertions
2076         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2077         is removed.
2078         (riscv_gdbarch_init): Gather isa features and abi features
2079         separately, ensure both match on the gdbarch when reusing an old
2080         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2081         a target with 64-bit float hardware.
2082
2083 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2084
2085         * source.c (search_command_helper): Stop reverse search
2086         when line 1 has been searched.
2087
2088 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2089
2090         * record-full.c (record_full_base_target::close): Rewrite
2091         record_full_core_buf_list free logic.
2092
2093 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2094
2095         * break-catch-syscall.c (print_one_catch_syscall): xfree
2096         the last text.
2097
2098 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2099
2100         * top.c (print_gdb_version): Update Copyright year in version
2101         message.
2102
2103 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2104
2105         Update copyright year range in all GDB files.
2106
2107 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2108
2109         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2110
2111 For older changes see ChangeLog-2018.
2112 \f
2113 Local Variables:
2114 mode: change-log
2115 left-margin: 8
2116 fill-column: 74
2117 version-control: never
2118 coding: utf-8
2119 End:
2120