gdb/ChangeLog

   1 2019-01-30  Tom Tromey  <tom@tromey.com>
   2
   3         PR python/23615:
   4         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
   5         (gdbpy_parse_and_eval): Likewise.
   6         * python/python-internal.h (gdbpy_allow_threads): New class.
   7
   8 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
   9
  10         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
  11         (aarch64_fbsd_fpregmap): Move earlier.
  12         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
  13         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
  14         instead of individual calls to trad_frame_set_reg_addr.
  15         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
  16         earlier.
  17         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
  18         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
  19         instead of individual calls to trad_frame_set_reg_addr.
  20
  21 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
  22
  23         * CONTRIBUTE: Replace contribution list with wiki link.
  24
  25 2019-01-25  Tom Tromey  <tom@tromey.com>
  26
  27         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
  28
  29 2019-01-25  Tom Tromey  <tom@tromey.com>
  30
  31         * xtensa-linux-nat.c: Fix common/ includes.
  32         * xml-support.h: Fix common/ includes.
  33         * xml-support.c: Fix common/ includes.
  34         * x86-linux-nat.c: Fix common/ includes.
  35         * windows-nat.c: Fix common/ includes.
  36         * varobj.h: Fix common/ includes.
  37         * varobj.c: Fix common/ includes.
  38         * value.c: Fix common/ includes.
  39         * valops.c: Fix common/ includes.
  40         * utils.c: Fix common/ includes.
  41         * unittests/xml-utils-selftests.c: Fix common/ includes.
  42         * unittests/utils-selftests.c: Fix common/ includes.
  43         * unittests/unpack-selftests.c: Fix common/ includes.
  44         * unittests/tracepoint-selftests.c: Fix common/ includes.
  45         * unittests/style-selftests.c: Fix common/ includes.
  46         * unittests/string_view-selftests.c: Fix common/ includes.
  47         * unittests/scoped_restore-selftests.c: Fix common/ includes.
  48         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
  49         * unittests/scoped_fd-selftests.c: Fix common/ includes.
  50         * unittests/rsp-low-selftests.c: Fix common/ includes.
  51         * unittests/parse-connection-spec-selftests.c: Fix common/
  52         includes.
  53         * unittests/optional-selftests.c: Fix common/ includes.
  54         * unittests/offset-type-selftests.c: Fix common/ includes.
  55         * unittests/observable-selftests.c: Fix common/ includes.
  56         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
  57         * unittests/memrange-selftests.c: Fix common/ includes.
  58         * unittests/memory-map-selftests.c: Fix common/ includes.
  59         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
  60         * unittests/function-view-selftests.c: Fix common/ includes.
  61         * unittests/environ-selftests.c: Fix common/ includes.
  62         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
  63         * unittests/common-utils-selftests.c: Fix common/ includes.
  64         * unittests/cli-utils-selftests.c: Fix common/ includes.
  65         * unittests/array-view-selftests.c: Fix common/ includes.
  66         * ui-file.c: Fix common/ includes.
  67         * tui/tui-io.c: Fix common/ includes.
  68         * tracepoint.h: Fix common/ includes.
  69         * tracepoint.c: Fix common/ includes.
  70         * tracefile-tfile.c: Fix common/ includes.
  71         * top.h: Fix common/ includes.
  72         * top.c: Fix common/ includes.
  73         * thread.c: Fix common/ includes.
  74         * target/waitstatus.h: Fix common/ includes.
  75         * target/waitstatus.c: Fix common/ includes.
  76         * target.h: Fix common/ includes.
  77         * target.c: Fix common/ includes.
  78         * target-memory.c: Fix common/ includes.
  79         * target-descriptions.c: Fix common/ includes.
  80         * symtab.h: Fix common/ includes.
  81         * symfile.c: Fix common/ includes.
  82         * stap-probe.c: Fix common/ includes.
  83         * spu-linux-nat.c: Fix common/ includes.
  84         * sparc-nat.c: Fix common/ includes.
  85         * source.c: Fix common/ includes.
  86         * solib.c: Fix common/ includes.
  87         * solib-target.c: Fix common/ includes.
  88         * ser-unix.c: Fix common/ includes.
  89         * ser-tcp.c: Fix common/ includes.
  90         * ser-pipe.c: Fix common/ includes.
  91         * ser-base.c: Fix common/ includes.
  92         * selftest-arch.c: Fix common/ includes.
  93         * s12z-tdep.c: Fix common/ includes.
  94         * rust-exp.y: Fix common/ includes.
  95         * rs6000-aix-tdep.c: Fix common/ includes.
  96         * riscv-tdep.c: Fix common/ includes.
  97         * remote.c: Fix common/ includes.
  98         * remote-notif.h: Fix common/ includes.
  99         * remote-fileio.h: Fix common/ includes.
 100         * remote-fileio.c: Fix common/ includes.
 101         * regcache.h: Fix common/ includes.
 102         * regcache.c: Fix common/ includes.
 103         * record-btrace.c: Fix common/ includes.
 104         * python/python.c: Fix common/ includes.
 105         * python/py-type.c: Fix common/ includes.
 106         * python/py-inferior.c: Fix common/ includes.
 107         * progspace.h: Fix common/ includes.
 108         * producer.c: Fix common/ includes.
 109         * procfs.c: Fix common/ includes.
 110         * proc-api.c: Fix common/ includes.
 111         * printcmd.c: Fix common/ includes.
 112         * ppc-linux-nat.c: Fix common/ includes.
 113         * parser-defs.h: Fix common/ includes.
 114         * osdata.c: Fix common/ includes.
 115         * obsd-nat.c: Fix common/ includes.
 116         * nat/x86-linux.c: Fix common/ includes.
 117         * nat/x86-linux-dregs.c: Fix common/ includes.
 118         * nat/x86-dregs.h: Fix common/ includes.
 119         * nat/x86-dregs.c: Fix common/ includes.
 120         * nat/ppc-linux.c: Fix common/ includes.
 121         * nat/mips-linux-watch.h: Fix common/ includes.
 122         * nat/mips-linux-watch.c: Fix common/ includes.
 123         * nat/linux-waitpid.c: Fix common/ includes.
 124         * nat/linux-ptrace.h: Fix common/ includes.
 125         * nat/linux-ptrace.c: Fix common/ includes.
 126         * nat/linux-procfs.c: Fix common/ includes.
 127         * nat/linux-personality.c: Fix common/ includes.
 128         * nat/linux-osdata.c: Fix common/ includes.
 129         * nat/linux-namespaces.c: Fix common/ includes.
 130         * nat/linux-btrace.h: Fix common/ includes.
 131         * nat/linux-btrace.c: Fix common/ includes.
 132         * nat/fork-inferior.c: Fix common/ includes.
 133         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 134         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 135         * nat/aarch64-linux.c: Fix common/ includes.
 136         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 137         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 138         * namespace.h: Fix common/ includes.
 139         * mips-linux-tdep.c: Fix common/ includes.
 140         * minsyms.c: Fix common/ includes.
 141         * mi/mi-parse.h: Fix common/ includes.
 142         * mi/mi-main.c: Fix common/ includes.
 143         * mi/mi-cmd-env.c: Fix common/ includes.
 144         * memrange.h: Fix common/ includes.
 145         * memattr.c: Fix common/ includes.
 146         * maint.h: Fix common/ includes.
 147         * maint.c: Fix common/ includes.
 148         * main.c: Fix common/ includes.
 149         * machoread.c: Fix common/ includes.
 150         * location.c: Fix common/ includes.
 151         * linux-thread-db.c: Fix common/ includes.
 152         * linux-nat.c: Fix common/ includes.
 153         * linux-fork.c: Fix common/ includes.
 154         * inline-frame.c: Fix common/ includes.
 155         * infrun.c: Fix common/ includes.
 156         * inflow.c: Fix common/ includes.
 157         * inferior.h: Fix common/ includes.
 158         * inferior.c: Fix common/ includes.
 159         * infcmd.c: Fix common/ includes.
 160         * inf-ptrace.c: Fix common/ includes.
 161         * inf-child.c: Fix common/ includes.
 162         * ia64-linux-nat.c: Fix common/ includes.
 163         * i387-tdep.c: Fix common/ includes.
 164         * i386-tdep.c: Fix common/ includes.
 165         * i386-linux-tdep.c: Fix common/ includes.
 166         * i386-linux-nat.c: Fix common/ includes.
 167         * i386-go32-tdep.c: Fix common/ includes.
 168         * i386-fbsd-tdep.c: Fix common/ includes.
 169         * i386-fbsd-nat.c: Fix common/ includes.
 170         * guile/scm-type.c: Fix common/ includes.
 171         * guile/guile.c: Fix common/ includes.
 172         * go32-nat.c: Fix common/ includes.
 173         * gnu-nat.c: Fix common/ includes.
 174         * gdbthread.h: Fix common/ includes.
 175         * gdbarch-selftests.c: Fix common/ includes.
 176         * gdb_usleep.c: Fix common/ includes.
 177         * gdb_select.h: Fix common/ includes.
 178         * gdb_bfd.c: Fix common/ includes.
 179         * gcore.c: Fix common/ includes.
 180         * fork-child.c: Fix common/ includes.
 181         * findvar.c: Fix common/ includes.
 182         * fbsd-nat.c: Fix common/ includes.
 183         * event-top.c: Fix common/ includes.
 184         * event-loop.c: Fix common/ includes.
 185         * dwarf2read.c: Fix common/ includes.
 186         * dwarf2loc.c: Fix common/ includes.
 187         * dwarf2-frame.c: Fix common/ includes.
 188         * dwarf-index-cache.c: Fix common/ includes.
 189         * dtrace-probe.c: Fix common/ includes.
 190         * disasm-selftests.c: Fix common/ includes.
 191         * defs.h: Fix common/ includes.
 192         * csky-tdep.c: Fix common/ includes.
 193         * cp-valprint.c: Fix common/ includes.
 194         * cp-support.h: Fix common/ includes.
 195         * cp-support.c: Fix common/ includes.
 196         * corelow.c: Fix common/ includes.
 197         * completer.h: Fix common/ includes.
 198         * completer.c: Fix common/ includes.
 199         * compile/compile.c: Fix common/ includes.
 200         * compile/compile-loc2c.c: Fix common/ includes.
 201         * compile/compile-cplus-types.c: Fix common/ includes.
 202         * compile/compile-cplus-symbols.c: Fix common/ includes.
 203         * command.h: Fix common/ includes.
 204         * cli/cli-dump.c: Fix common/ includes.
 205         * cli/cli-cmds.c: Fix common/ includes.
 206         * charset.c: Fix common/ includes.
 207         * build-id.c: Fix common/ includes.
 208         * btrace.h: Fix common/ includes.
 209         * btrace.c: Fix common/ includes.
 210         * breakpoint.h: Fix common/ includes.
 211         * breakpoint.c: Fix common/ includes.
 212         * ax.h:
 213         (enum agent_op): Fix common/ includes.
 214         * ax-general.c (struct aop_map): Fix common/ includes.
 215         * ax-gdb.c: Fix common/ includes.
 216         * auxv.c: Fix common/ includes.
 217         * auto-load.c: Fix common/ includes.
 218         * arm-tdep.c: Fix common/ includes.
 219         * arch/riscv.c: Fix common/ includes.
 220         * arch/ppc-linux-common.c: Fix common/ includes.
 221         * arch/i386.c: Fix common/ includes.
 222         * arch/arm.c: Fix common/ includes.
 223         * arch/arm-linux.c: Fix common/ includes.
 224         * arch/arm-get-next-pcs.c: Fix common/ includes.
 225         * arch/amd64.c: Fix common/ includes.
 226         * arch/aarch64.c: Fix common/ includes.
 227         * arch/aarch64-insn.c: Fix common/ includes.
 228         * arch-utils.c: Fix common/ includes.
 229         * amd64-windows-tdep.c: Fix common/ includes.
 230         * amd64-tdep.c: Fix common/ includes.
 231         * amd64-sol2-tdep.c: Fix common/ includes.
 232         * amd64-obsd-tdep.c: Fix common/ includes.
 233         * amd64-nbsd-tdep.c: Fix common/ includes.
 234         * amd64-linux-tdep.c: Fix common/ includes.
 235         * amd64-linux-nat.c: Fix common/ includes.
 236         * amd64-fbsd-tdep.c: Fix common/ includes.
 237         * amd64-fbsd-nat.c: Fix common/ includes.
 238         * amd64-dicos-tdep.c: Fix common/ includes.
 239         * amd64-darwin-tdep.c: Fix common/ includes.
 240         * agent.c: Fix common/ includes.
 241         * ada-lang.h: Fix common/ includes.
 242         * ada-lang.c: Fix common/ includes.
 243         * aarch64-tdep.c: Fix common/ includes.
 244
 245 2019-01-25  Tom Tromey  <tom@tromey.com>
 246
 247         * common/create-version.sh: Use common/version.h.
 248
 249 2019-01-24  Pedro Alves  <palves@redhat.com>
 250
 251         * infrun.c (signal_stop, signal_print, signal_program)
 252         (signal_catch, signal_pass): Now arrays instead of pointers.
 253         (update_signals_program_target, do_target_resume)
 254         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 255         * linux-nat.c (linux_nat_target::pass_signals)
 256         (linux_nat_target::create_inferior, linux_nat_target::attach):
 257         Adjust.
 258         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 259         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 260         * procfs.c (procfs_target::pass_signals): Adjust.
 261         * record-full.c (record_full_target::resume): Adjust.
 262         * remote.c (remote_target::pass_signals)
 263         (remote_target::program_signals): Adjust.
 264         * target-debug.h (target_debug_print_signals): Now takes a
 265         gdb::array_view as parameter.  Adjust.
 266         * target.h (target_ops) <pass_signals, program_signals>: Replace
 267         pointer and length parameters with gdb::array_view.
 268         (target_pass_signals, target_program_signals): Likewise.
 269         * target-delegates.c: Regenerate.
 270
 271 2019-01-24  Pedro Alves  <palves@redhat.com>
 272
 273         * common/forward-scope-exit.h
 274         (forward_scope_exit::forward_scope_exit): Pass arguments to
 275         m_bind_function directly, instead of creating a std::bind and
 276         copying that.
 277
 278 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 279
 280         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 281         for static members.
 282         (pass_in_v_vfp_candidate): Likewise.
 283
 284 2019-01-23  Tom Tromey  <tom@tromey.com>
 285             Pedro Alves  <palves@redhat.com>
 286
 287         * regcache.c (class regcache_invalidator): Remove.
 288         (regcache::raw_write): Use make_scope_exit.
 289
 290 2019-01-23  Tom Tromey  <tom@tromey.com>
 291
 292         * ui-out.h (class ui_out_emit_type): Update comment.
 293
 294 2019-01-23  Tom Tromey  <tom@tromey.com>
 295
 296         * infrun.c (fetch_inferior_event): Update comment.
 297
 298 2019-01-23  Tom Tromey  <tom@tromey.com>
 299             Pedro Alves  <palves@redhat.com>
 300
 301         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 302         parameter.
 303         (fetch_inferior_event): Use SCOPE_EXIT.
 304
 305
 306 2019-01-23  Tom Tromey  <tom@tromey.com>
 307             Pedro Alves  <palves@redhat.com>
 308
 309         * infrun.c (disable_thread_events): Delete.
 310         (stop_all_threads): Use SCOPE_EXIT.
 311
 312 2019-01-23  Tom Tromey  <tom@tromey.com>
 313             Pedro Alves  <palves@redhat.com>
 314
 315         * symfile.c: Include forward-scope-exit.h.
 316         (clear_symtab_users_cleanup): Replace forward declaration with
 317         a FORWARD_SCOPE_EXIT.
 318         (syms_from_objfile_1): Use the forward_scope_exit and
 319         gdb::optional instead of cleanup_function.
 320         (reread_symbols): Use the forward_scope_exit instead of
 321         cleanup_function.
 322         (clear_symtab_users_cleanup): Remove function.
 323
 324 2019-01-23  Tom Tromey  <tom@tromey.com>
 325             Pedro Alves  <palves@redhat.com>
 326
 327         * linux-nat.c: Include scope-exit.h.
 328         (cleanup_target_stop): Remove.
 329         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 330         SCOPE_EXIT.
 331
 332 2019-01-23  Tom Tromey  <tom@tromey.com>
 333             Pedro Alves  <palves@redhat.com>
 334
 335         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 336         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 337
 338 2019-01-23  Tom Tromey  <tom@tromey.com>
 339             Andrew Burgess  <andrew.burgess@embecosm.com>
 340             Pedro Alves  <palves@redhat.com>
 341
 342         * infrun.c (fetch_inferior_event): Use scope_exit.
 343         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 344         * top.c (execute_command): Use scope_exit.
 345         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 346         * utils.c (do_bpstat_clear_actions_cleanup)
 347         (make_bpstat_clear_actions_cleanup): Remove.
 348
 349 2019-01-23  Tom Tromey  <tom@tromey.com>
 350             Pedro Alves  <palves@redhat.com>
 351
 352         * infrun.c: Include "common/scope-exit.h"
 353         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 354         (wait_for_inferior): Use SCOPE_EXIT.
 355         (fetch_inferior_event): Use scope_exit.
 356
 357 2019-01-23  Tom Tromey  <tom@tromey.com>
 358             Pedro Alves  <palves@redhat.com>
 359
 360         * breakpoint.c (create_breakpoint): Remove cleanup.
 361
 362 2019-01-23  Tom Tromey  <tom@tromey.com>
 363             Andrew Burgess  <andrew.burgess@embecosm.com>
 364             Pedro Alves  <palves@redhat.com>
 365
 366 2019-01-23  Pedro Alves  <palves@redhat.com>
 367
 368         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 369
 370 2019-01-23  Pedro Alves  <palves@redhat.com>
 371             Andrew Burgess  <andrew.burgess@embecosm.com>
 372
 373         * gdbthread.h: Include "common/forward-scope-exit.h".
 374         (scoped_finish_thread_state): Redefine custom class in terms of
 375         forward_scope_exit.
 376
 377 2019-01-23  Pedro Alves  <palves@redhat.com>
 378             Andrew Burgess  <andrew.burgess@embecosm.com>
 379
 380         * common/forward-scope-exit.h: New file.
 381
 382 2019-01-23  Pedro Alves  <palves@redhat.com>
 383             Andrew Burgess  <andrew.burgess@embecosm.com>
 384             Tom Tromey  <tom@tromey.com>
 385
 386         * common/scope-exit.h: New file.
 387
 388 2019-01-23  Pedro Alves  <palves@redhat.com>
 389
 390         * common/preprocessor.h (ESC): Rename to ...
 391         (ESC_PARENS): ... this.
 392         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 393         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 394
 395 2019-01-23  Tom Tromey  <tom@tromey.com>
 396
 397         * language.h (class scoped_switch_to_sym_language_if_auto):
 398         Initialize m_lang in both cases.
 399
 400 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 401
 402         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 403         with XCNEW.
 404
 405 2019-01-22  Tom Tromey  <tom@tromey.com>
 406
 407         * corelow.c: Do not include sys/file.h.
 408
 409 2019-01-22  Tom Tromey  <tom@tromey.com>
 410
 411         * tui/tui-wingeneral.h: Include gdb_curses.h.
 412
 413 2019-01-22  Tom Tromey  <tom@tromey.com>
 414
 415         * source-cache.h (class source_cache) <get_source_lines,
 416         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 417
 418 2019-01-22  Tom Tromey  <tom@tromey.com>
 419
 420         * remote-fileio.h (struct remote_target): Declare.
 421
 422 2019-01-22  Tom Tromey  <tom@tromey.com>
 423
 424         * python/py-arch.c: Do not include py-ref.h.
 425         * python/py-bpevent.c: Do not include py-ref.h.
 426         * python/py-cmd.c: Do not include py-ref.h.
 427         * python/py-continueevent.c: Do not include py-ref.h.
 428         * python/py-event.h: Do not include py-ref.h.
 429         * python/py-evtregistry.c: Do not include py-ref.h.
 430         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 431         * python/py-frame.c: Do not include py-ref.h.
 432         * python/py-framefilter.c: Do not include py-ref.h.
 433         * python/py-function.c: Do not include py-ref.h.
 434         * python/py-infevents.c: Do not include py-ref.h.
 435         * python/py-linetable.c: Do not include py-ref.h.
 436         * python/py-objfile.c: Do not include py-ref.h.
 437         * python/py-param.c: Do not include py-ref.h.
 438         * python/py-prettyprint.c: Do not include py-ref.h.
 439         * python/py-progspace.c: Do not include py-ref.h.
 440         * python/py-symbol.c: Do not include py-ref.h.
 441         * python/py-symtab.c: Do not include py-ref.h.
 442         * python/py-type.c: Do not include py-ref.h.
 443         * python/py-unwind.c: Do not include py-ref.h.
 444         * python/py-utils.c: Do not include py-ref.h.
 445         * python/py-value.c: Do not include py-ref.h.
 446         * python/py-varobj.c: Do not include py-ref.h.
 447         * python/py-xmethods.c: Do not include py-ref.h.
 448         * python/python.c: Do not include py-ref.h.
 449         * varobj.c: Do not include py-ref.h.
 450
 451 2019-01-22  Tom Tromey  <tom@tromey.com>
 452
 453         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 454         keyword for bcache.
 455
 456 2019-01-22  Tom Tromey  <tom@tromey.com>
 457
 458         * compile/compile-cplus-types.c: Remove a comment by #include.
 459
 460 2019-01-22  Tom Tromey  <tom@tromey.com>
 461
 462         * compile/gcc-c-plugin.h: Include compile-internal.h.
 463
 464 2019-01-22  Tom Tromey  <tom@tromey.com>
 465
 466         * stabsread.c (EXTERN): Do not define.
 467         (symnum, next_symbol_text_func, processing_gcc_compilation)
 468         (within_function, global_sym_chain, global_stabs)
 469         (previous_stab_code, this_object_header_files)
 470         (n_this_object_header_files)
 471         (n_allocated_this_object_header_files): Define.
 472         * stabsread.h (EXTERN): Never define.  Use "extern".
 473
 474 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 475
 476         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 477         history_value.
 478
 479 2019-01-21  Tom Tromey  <tom@tromey.com>
 480
 481         * ui-out.c: Fix includes.
 482         * tui/tui-source.c: Fix includes.
 483         * target.c: Fix includes.
 484         * remote.c: Fix includes.
 485         * regcache.c: Fix includes.
 486         * python/py-block.c: Fix includes.
 487         * printcmd.c: Fix includes.
 488         * or1k-tdep.c: Fix includes.
 489         * mi/mi-main.c: Fix includes.
 490         * m32r-tdep.c: Fix includes.
 491         * csky-tdep.c: Fix includes.
 492         * compile/compile-cplus-types.c: Fix includes.
 493         * cli/cli-interp.c: Fix includes.
 494
 495 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 496
 497         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 498         for padding.
 499
 500 2019-01-16  Tom Tromey  <tom@tromey.com>
 501
 502         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 503         earlier.
 504         (struct objfile) <msymbols_range>: Move from top level.
 505         <msymbols>: New method.
 506         (class objfile_msymbols): Remove.
 507         * symtab.c (default_collect_symbol_completion_matches_break_on):
 508         Update.
 509         * symmisc.c (dump_msymbols): Update.
 510         * stabsread.c (scan_file_globals): Update.
 511         * objc-lang.c (info_selectors_command, info_classes_command)
 512         (find_methods): Update.
 513         * minsyms.c (find_solib_trampoline_target): Update.
 514         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 515         * coffread.c (coff_symfile_read): Update.
 516         * ada-lang.c (ada_lookup_simple_minsym)
 517         (ada_collect_symbol_completion_matches): Update.
 518
 519 2019-01-16  Tom Tromey  <tom@tromey.com>
 520
 521         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 522         type.  Remove no-argument constructor.
 523         <iterator::operator++>: Simplify.
 524         <begin>: Update.
 525         <end>: Use minimal_symbol_count.
 526
 527 2019-01-16  Tom Tromey  <tom@tromey.com>
 528
 529         * objfiles.h (struct objfile) <psymtabs>: New method.
 530         (class objfile_psymtabs): Remove.
 531         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 532         typedef.
 533         <range>: New method.
 534         (require_partial_symbols): Change return type.
 535         * psymtab.c (require_partial_symbols)
 536         (psym_expand_symtabs_matching): Update.
 537         * mdebugread.c (parse_partial_symbols): Update.
 538         * dbxread.c (dbx_end_psymtab): Update.
 539
 540 2019-01-15  Tom Tromey  <tom@tromey.com>
 541
 542         * symtab.c (lookup_objfile_from_block)
 543         (lookup_symbol_in_objfile_symtabs)
 544         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 545         (find_line_symtab, info_sources_command)
 546         (default_collect_symbol_completion_matches_break_on)
 547         (make_source_files_completion_list): Update.
 548         * symmisc.c (print_objfile_statistics, dump_objfile)
 549         (maintenance_print_symbols, maintenance_info_symtabs)
 550         (maintenance_check_symtabs, maintenance_info_line_tables):
 551         Update.
 552         * source.c (select_source_symtab)
 553         (forget_cached_source_info_for_objfile): Update.
 554         * objfiles.h (class objfile_compunits): Remove.
 555         (struct objfile) <compunits_range>: New typedef.
 556         (compunits): New method.
 557         * objfiles.c (objfile_relocate1): Update.
 558         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 559         * maint.c (count_symtabs_and_blocks): Update.
 560         * linespec.c (iterate_over_all_matching_symtabs): Update.
 561         * cp-support.c (add_symbol_overload_list_qualified): Update.
 562         * coffread.c (coff_symtab_read): Update.
 563         * ada-lang.c (add_nonlocal_symbols)
 564         (ada_collect_symbol_completion_matches)
 565         (ada_add_global_exceptions): Update.
 566
 567 2019-01-15  Tom Tromey  <tom@tromey.com>
 568
 569         * progspace.h (program_space) <objfiles_safe_range>: New
 570         typedef.
 571         <objfiles_safe>: New method.
 572         * objfiles.h (class all_objfiles_safe): Remove.
 573         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 574         * jit.c (jit_inferior_exit_hook): Update.
 575
 576 2019-01-17  Tom Tromey  <tom@tromey.com>
 577
 578         * progspace.h (program_space) <objfiles_range>: New typedef.
 579         <objfiles>: New method.
 580         <objfiles_head>: Rename from objfiles.
 581         (object_files): Update.
 582         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 583         * guile/scm-pretty-print.c
 584         (ppscm_find_pretty_printer_from_objfiles): Update.
 585         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 586         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 587         Update.
 588         * python/py-progspace.c (pspy_get_objfiles): Update.
 589         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 590         Update.
 591         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 592         (objfpy_lookup_objfile_by_build_id): Update.
 593         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 594         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 595         Update.
 596         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 597         (expand_symtab_containing_pc, lookup_objfile_from_block)
 598         (lookup_static_symbol, basic_lookup_transparent_type)
 599         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 600         (find_line_symtab, info_sources_command)
 601         (default_collect_symbol_completion_matches_break_on)
 602         (make_source_files_completion_list, find_main_name): Update.
 603         * symmisc.c (print_symbol_bcache_statistics)
 604         (print_objfile_statistics, maintenance_print_symbols)
 605         (maintenance_print_msymbols, maintenance_print_objfiles)
 606         (maintenance_info_symtabs, maintenance_check_symtabs)
 607         (maintenance_expand_symtabs, maintenance_info_line_tables):
 608         Update.
 609         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 610         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 611         (map_overlay_command, unmap_overlay_command)
 612         (simple_overlay_update, expand_symtabs_matching)
 613         (map_symbol_filenames): Update.
 614         * symfile-debug.c (set_debug_symfile): Update.
 615         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 616         Update.
 617         * source.c (select_source_symtab, forget_cached_source_info):
 618         Update.
 619         * solib.c (solib_read_symbols): Update.
 620         * solib-spu.c (append_ocl_sos): Update.
 621         * psymtab.c (maintenance_print_psymbols)
 622         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 623         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 624         * printcmd.c (info_symbol_command): Update.
 625         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 626         Update.
 627         * objfiles.h (class all_objfiles): Remove.
 628         * objfiles.c (have_partial_symbols, have_full_symbols)
 629         (have_minimal_symbols, qsort_cmp, update_section_map)
 630         (shared_objfile_contains_address_p)
 631         (default_iterate_over_objfiles_in_search_order): Update.
 632         * objc-lang.c (info_selectors_command, info_classes_command)
 633         (find_methods): Update.
 634         * minsyms.c (find_solib_trampoline_target): Update.
 635         * maint.c (maintenance_info_sections)
 636         (maintenance_translate_address, count_symtabs_and_blocks):
 637         Update.
 638         * main.c (captured_main_1): Update.
 639         * linux-thread-db.c (try_thread_db_load_from_pdir)
 640         (has_libpthread): Update.
 641         * linespec.c (iterate_over_all_matching_symtabs)
 642         (search_minsyms_for_name): Update.
 643         * jit.c (jit_find_objf_with_entry_addr): Update.
 644         * hppa-tdep.c (find_unwind_entry)
 645         (hppa_lookup_stub_minimal_symbol): Update.
 646         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 647         Update.
 648         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 649         (elf_gnu_ifunc_resolve_by_got): Update.
 650         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 651         * dwarf-index-write.c (save_gdb_index_command): Update.
 652         * cp-support.c (add_symbol_overload_list_qualified): Update.
 653         * breakpoint.c (create_overlay_event_breakpoint)
 654         (create_longjmp_master_breakpoint)
 655         (create_std_terminate_master_breakpoint)
 656         (create_exception_master_breakpoint): Update.
 657         * blockframe.c (find_pc_partial_function): Update.
 658         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 659         (ada_collect_symbol_completion_matches)
 660         (ada_add_global_exceptions): Update.
 661
 662 2019-01-17  Tom Tromey  <tom@tromey.com>
 663
 664         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 665         declare VEC.
 666         (solib_target_parse_libraries): Change return type.
 667         (library_list_start_segment, library_list_start_section)
 668         (library_list_end_library, library_list_start_library); Update.
 669         (solib_target_free_library_list): Remove.
 670         (solib_target_parse_libraries): Remove cleanup.  Change return
 671         type.
 672         (solib_target_current_sos): Update.
 673
 674 2019-01-17  Tom Tromey  <tromey@bapiya>
 675
 676         * valprint.c: Replace "the the" with "the".
 677         * symtab.c: Replace "the the" with "the".
 678         * solib.c: Replace "the the" with "the".
 679         * solib-dsbt.c: Replace "the the" with "the".
 680         * linespec.c: Replace "the the" with "the".
 681         * dwarf2loc.h: Replace "the the" with "the".
 682         * amd64-windows-tdep.c: Replace "the the" with "the".
 683         * aarch64-tdep.c: Replace "the the" with "the".
 684
 685 2019-01-16  Keith Seitz  <keiths@redhat.com>
 686
 687         PR gdb/23773
 688         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 689         <builder>: Rename to ..
 690         <m_builder>: ... this and make private.
 691         (dwarf2_cu::get_builder): New method.  Change all users of
 692         `builder' to use this method.
 693         (dwarf2_start_symtab): Move to ...
 694         (dwarf2_cu::start_symtab): ... here.  Update all callers
 695         (setup_type_unit_groups): Move to ...
 696         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 697         callers.
 698         (dwarf2_cu::reset_builder): New method.
 699         (process_full_compunit, process_full_type_unit): Use
 700         dwarf2_cu::reset_builder.
 701         (follow_die_offset): Record the ancestor CU if it is different
 702         from the followed DIE's CU.
 703         (follow_die_sig_1): Likewise.
 704
 705 2019-01-15  Tom Tromey  <tom@tromey.com>
 706
 707         * remote.c (class remote_state) <buf>: Now a char_vector.
 708         <buf_size>: Remove.
 709         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 710         parameter.
 711         (remote_target::getpkt_or_notif_sane_1)
 712         (remote_target::getpkt_sane)
 713         (remote_target::getpkt_or_notif_sane): Likewise.
 714         (class remote_target) <putpkt>: New overload.
 715         (remote_target::read_frame): Change type of "buf_p".  Remove
 716         sizeof_p parameter.
 717         (packet_ok): New overload.
 718         (packet_check_result): New overload.
 719         Update all uses.
 720
 721 2019-01-14  Tom Tromey  <tom@tromey.com>
 722
 723         * remote-notif.c (handle_notification, remote_notif_ack)
 724         (remote_notif_parse): Make "buf" const.
 725         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 726         const.
 727         (remote_notif_parse, remote_notif_ack, handle_notification):
 728         Likewise.
 729         * remote.c (remote_notif_stop_parse): Make "buf" const.
 730         (remote_target::remote_parse_stop_reply): Make "buf" const.
 731         (remote_notif_stop_ack): Make "buf" const.
 732
 733 2019-01-14  Tom Tromey  <tom@tromey.com>
 734
 735         * remote.c (remote_console_output): Make parameter const.
 736
 737 2019-01-14  Tom Tromey  <tom@tromey.com>
 738
 739         * target-debug.h (target_debug_print_signals): Constify.
 740         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 741         * procfs.c (procfs_target::pass_signals): Update.
 742         * linux-nat.c (linux_nat_target::pass_signals): Update.
 743         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 744         * target-delegates.c: Rebuild.
 745         * remote.c (remote_target::program_signals): Update.
 746         (remote_target::pass_signals): Update.
 747         * target.c (target_pass_signals): Constify argument.
 748         (target_program_signals): Likewise.
 749         * target.h (struct target_ops) <pass_signals, program_signals>:
 750         Constify argument.
 751         (target_pass_signals, target_program_signals): Constify argument.
 752
 753 2019-01-14  Tom Tromey  <tom@tromey.com>
 754
 755         PR tui/28819:
 756         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 757
 758 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 759
 760         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 761         field.
 762         * rs6000-tdep.c: Include reggroups.h.
 763         (IS_V_ALIAS_PSEUDOREG): Define.
 764         (rs6000_register_name): Return names for the "vX" aliases.
 765         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 766         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 767         aliases.  Call default_register_reggroup_p for all other
 768         pseudo-registers.
 769         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 770         New functions.
 771         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 772         Handle "vX" aliases.
 773         (v_alias_pseudo_register_collect): New function.
 774         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 775         (rs6000_gdbarch_init): Initialize "vX" aliases as
 776         pseudo-registers.  Restore registration of
 777         rs6000_pseudo_register_reggroup_p with
 778         set_tdesc_pseudo_register_reggroup_p.
 779
 780 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 781
 782         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 783         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 784         set_gdbarch_num_pseudo_regs.
 785
 786 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 787
 788         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 789         Remove arg prefixname, add do_set and do_show.
 790         Add member functions set_list and show_list.
 791         * cli/cli-style.c (class cli_style_option): Update accordingly.
 792         (style_set_list): Move to file scope.
 793         (style_show_list): Likewise.
 794         (set_style): Call help_list.
 795         (show_style): Call cmd_show_list.
 796         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 797         Update to use the new macro.
 798
 799 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 800
 801         * ada-lang.c (_initialize_ada_language): Expand the help text
 802         for the "catch exception" command.
 803
 804 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 805
 806         * symtab.c (matching_obj_sections): Initialize obj,
 807         declare it closer to its usage.
 808
 809 2019-01-10  Tom Tromey  <tom@tromey.com>
 810
 811         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 812         (basic_inf_threads_range): Remove.
 813         (inf_threads_range, inf_non_exited_threads_range)
 814         (safe_inf_threads_range): Use next_adapter.
 815
 816 2019-01-10  Keith Seitz  <keiths@redhat.com>
 817
 818         PR gdb/23712
 819         PR symtab/23010
 820         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 821         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 822
 823 2019-01-10  Keith Seitz  <keiths@redhat.com>
 824
 825         PR gdb/23712
 826         PR symtab/23010
 827         * dictionary.c (pending_to_vector): Remove.
 828         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 829         Remove _1 suffix, replacing functions of the same name.  Update
 830         all callers.
 831         (dict_create_hashed, dict_create_hashed_expandable)
 832         (dict_create_linear, dict_create_linear_expandable, dict_free)
 833         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 834         Make functions static.
 835
 836 2019-01-10  Keith Seitz  <keiths@redhat.com>
 837
 838         PR gdb/23712
 839         PR symtab/23010
 840         * dictionary.h (struct dictionary): Replace declaration with
 841         multidictionary.
 842         (dict_create_hashed, dict_create_hashed_expandable)
 843         (dict_create_linear, dict_create_linear_expandable)
 844         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 845         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 846         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 847         taking multidictionary argument.
 848         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 849         * block.h (struct block) <dict>: Change to multidictionary
 850         and rename `multidict'.
 851         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 852         symmisc.c: Update all dictionary references to multidictionary.
 853
 854 2019-01-10  Keith Seitz  <keiths@redhat.com>
 855
 856         PR gdb/23712
 857         PR symtab/23010
 858         * dictionary.c: Include unordered_map.
 859         (pending_to_vector): New function.
 860         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 861         Rewrite the non-"_1" functions to take vector instead
 862         of linked list.
 863         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 864         "new" _1 versions of the same name.
 865         (multidictionary): Define.
 866         (std::hash<enum language): New definition.
 867         (collate_pending_symbols_by_language, mdict_create_hashed)
 868         (mdict_create_hashed_expandable, mdict_create_linear)
 869         (mdict_create_linear_expandable, mdict_free)
 870         (find_language_dictionary, create_new_language_dictionary)
 871         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 872         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 873         (mdict_size, mdict_empty): New functions.
 874         * dictionary.h (mdict_iterator): Define.
 875
 876 2019-01-10  Pedro Alves  <palves@redhat.com>
 877
 878         * breakpoint.c (read_uploaded_action)
 879         (create_tracepoint_from_upload): Adjust to use
 880         gdb::unique_xmalloc_ptr.
 881         * ctf.c (ctf_write_uploaded_tp):
 882         (SET_ARRAY_FIELD): Use emplace_back.
 883         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 884         * tracefile-tfile.c (tfile_write_uploaded_tp):
 885         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 886         gdb::unique_xmalloc_ptr.
 887         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 888         at_string, cond_string, cmd_strings>: Replace char pointers
 889         with gdb::unique_xmalloc_ptr.
 890
 891 2019-01-10  Pedro Alves  <palves@redhat.com>
 892
 893         * solib-target.c (library_list_start_library): Don't xstrdup name.
 894
 895 2019-01-10  Pedro Alves  <palves@redhat.com>
 896
 897         * mdebugread.c (parse_partial_symbols): Use
 898         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 899
 900 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 901
 902         * linux-fork.c (scoped_switch_fork_info)
 903         <~scoped_switch_fork_info>: Fix incorrect variable name.
 904
 905 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 906
 907         * linux-fork.c (scoped_switch_fork_info)
 908         <scoped_switch_fork_info>: Make explicit.
 909         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 910
 911 2019-01-10  Tom Tromey  <tom@tromey.com>
 912
 913         * objfiles.h (objfile::reset_psymtabs): Update.
 914         * objfiles.c (objfile::objfile): Update.
 915         * psymtab.h (psymtab_storage::obstack): Update.
 916         (psymtab_storage::m_obstack): Use gdb::optional.
 917         (class psymtab_storage): Update comment.  Remove objfile
 918         parameter.
 919         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 920
 921 2019-01-10  Tom Tromey  <tom@tromey.com>
 922
 923         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 924         <free_psymtabs>: Now private.
 925         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 926         (allocate_psymtab): Use new method.
 927
 928 2019-01-10  Tom Tromey  <tom@tromey.com>
 929
 930         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 931         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 932         * mdebugread.c (parse_partial_symbols): Use
 933         allocate_dependencies.
 934         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 935         allocate_dependencies.
 936         (process_psymtab_comp_unit_reader)
 937         (build_type_psymtab_dependencies): Likewise.
 938         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 939
 940 2019-01-10  Tom Tromey  <tom@tromey.com>
 941
 942         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 943         PSYMBOL_SET_LANGUAGE.
 944         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 945
 946 2019-01-10  Tom Tromey  <tom@tromey.com>
 947
 948         * psymtab.h (psymtab_storage::obstack): New method.
 949         <m_obstack>: Rename from obstack; now private.
 950         * psymtab.c (psymtab_storage): Update.
 951         * dwarf2read.c (create_addrmap_from_index)
 952         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 953         Update.
 954
 955 2019-01-10  Tom Tromey  <tom@tromey.com>
 956
 957         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 958         * objfiles.h (objfile::reset_psymtabs): New method.
 959
 960 2019-01-10  Tom Tromey  <tom@tromey.com>
 961
 962         * symmisc.c (print_symbol_bcache_statistics): Update.
 963         (print_objfile_statistics): Update.
 964         * symfile.c (reread_symbols): Update.
 965         * psymtab.h (class psymtab_storage): New.
 966         * psymtab.c (psymtab_storage): New constructor.
 967         (~psymtab_storage): New destructor.
 968         (require_partial_symbols): Update.
 969         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 970         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 971         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 972         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 973         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 974         (start_psymtab_common, end_psymtab_common)
 975         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 976         (allocate_psymtab): Update.
 977         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 978         Update.
 979         (dump_psymtab_addrmap, maintenance_print_psymbols)
 980         (maintenance_check_psymtabs): Update.
 981         (class objfile_psymtabs): Move to objfiles.h.
 982         * psympriv.h (discard_psymtab): Now inline.
 983         (psymtab_discarder::psymtab_discarder): Update.
 984         (psymtab_discarder::~psymtab_discarder): Update.
 985         (ALL_OBJFILE_PSYMTABS): Rewrite.
 986         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 987         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 988         Remove fields.
 989         <partial_symtabs>: New field.
 990         (class objfile_psymtabs): Move from psymtab.h.  Update.
 991         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 992         psymbol_cache.
 993         (objfile::~objfile): Don't destroy psymbol_cache.
 994         * mdebugread.c (parse_partial_symbols): Update.
 995         * dwarf2read.c (create_addrmap_from_index)
 996         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 997         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 998         (add_partial_subprogram, dwarf2_ranges_read): Update.
 999         * dwarf-index-write.c (write_address_map)
1000         (write_one_signatured_type, recursively_write_psymbols)
1001         (class debug_names, class debug_names, write_psymtabs_to_index):
1002         Update.
1003
1004 2019-01-10  Tom Tromey  <tom@tromey.com>
1005
1006         * symtab.h (SYMBOL_SET_NAMES): Update.
1007         (symbol_set_names): Update.
1008         (MSYMBOL_SET_NAMES): Update.
1009         * symtab.c (symbol_set_names): Change argument to be an
1010         objfile_per_bfd_storage.
1011         * psymtab.c (add_psymbol_to_bcache): Update.
1012         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1013
1014 2019-01-10  Tom Tromey  <tom@tromey.com>
1015
1016         * symtab.c (create_demangled_names_hash): Change argument to be an
1017         objfile_per_bfd_storage.
1018         (symbol_set_names): Update.
1019
1020 2019-01-10  Tom Tromey  <tom@tromey.com>
1021
1022         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1023         init_psymbol_list.
1024         * psymtab.c (init_psymbol_list): Do nothing if already called.
1025         * psympriv.h (init_psymbol_list): Add comment.
1026         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1027         init_psymbol_list.
1028         * dbxread.c (dbx_symfile_read): Unconditionally call
1029         init_psymbol_list.
1030
1031 2019-01-10  Tom Tromey  <tom@tromey.com>
1032
1033         * xcoffread.c (scan_xcoff_symtab): Update.
1034         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1035         "where".
1036         * mdebugread.c (parse_partial_symbols)
1037         (handle_psymbol_enumerators): Update.
1038         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1039         * dbxread.c (read_dbx_symtab): Update.
1040         * psympriv.h (psymbol_placement): New enum.
1041         (add_psymbol_to_list): Update.
1042
1043 2019-01-10  Tom Tromey  <tom@tromey.com>
1044
1045         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1046         static_psymbols parameters.
1047         (scan_xcoff_symtab): Update.
1048         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1049         static_psymbols parameters.
1050         * psympriv.h (start_psymtab_common): Update.
1051         * mdebugread.c (parse_partial_symbols): Update.
1052         * dwarf2read.c (create_partial_symtab): Update.
1053         * dbxread.c (read_dbx_symtab): Update.
1054         (start_psymtab): Remove global_psymbols and static_psymbols
1055         parameters.
1056
1057 2019-01-10  Tom Tromey  <tom@tromey.com>
1058
1059         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1060         * psymtab.c (allocate_psymtab): Add comment.
1061         * psympriv.h (allocate_psymtab): Add comment.
1062         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1063         initializations.
1064         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1065
1066 2019-01-10  Tom Tromey  <tom@tromey.com>
1067
1068         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1069         Don't declare.
1070         * mipsread.c: Include mdebugread.h.
1071         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1072         Declare.
1073         * elfread.c: Include mdebugread.h.
1074
1075 2019-01-09  Tom Tromey  <tom@tromey.com>
1076
1077         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1078         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1079         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1080         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1081         (psym_lookup_symbol, psym_find_last_source_symtab)
1082         (psym_forget_cached_source_info, psym_print_stats)
1083         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1084         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1085         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1086         (psym_find_compunit_symtab_by_address)
1087         (maintenance_print_psymbols, maintenance_info_psymtabs)
1088         (maintenance_check_psymtabs): Use ranged for.
1089         * psymtab.h (class objfile_psymtabs): New.
1090         (require_partial_symbols): Return objfile_psymtabs.
1091         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1092
1093 2019-01-09  Tom Tromey  <tom@tromey.com>
1094
1095         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1096         (find_pc_mapped_section, list_overlays_command)
1097         (map_overlay_command, unmap_overlay_command)
1098         (simple_overlay_update): Use all_objfiles.
1099         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1100         * printcmd.c (info_symbol_command): Use all_objfiles.
1101         * objfiles.h (ALL_OBJSECTIONS): Remove.
1102         * maint.c (maintenance_translate_address): Use all_objfiles.
1103         * gcore.c (gcore_create_callback): Use all_objfiles.
1104         (objfile_find_memory_regions): Likewise.
1105
1106 2019-01-09  Tom Tromey  <tom@tromey.com>
1107
1108         * symtab.c (find_line_symtab, info_sources_command)
1109         (make_source_files_completion_list): Use objfile_compunits.
1110         * source.c (select_source_symtab): Use objfile_compunits.
1111         * objfiles.h (struct objfile): Update comment.
1112         (ALL_OBJFILES): Remove.
1113         (ALL_FILETABS): Remove.
1114         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1115         objfile_compunits.
1116
1117 2019-01-09  Tom Tromey  <tom@tromey.com>
1118
1119         * symmisc.c (print_objfile_statistics, dump_objfile)
1120         (maintenance_print_symbols): Use compunit_filetabs.
1121         * source.c (forget_cached_source_info_for_objfile): Use
1122         compunit_filetabs.
1123         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1124         (ALL_FILETABS): Use compunit_filetabs.
1125         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1126         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1127
1128 2019-01-09  Tom Tromey  <tom@tromey.com>
1129
1130         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1131         (compunit_filetabs): New.
1132         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1133         compunit_filetabs.
1134         (info_sources_command, make_source_files_completion_list): Remove
1135         declaration.
1136         * symmisc.c (print_objfile_statistics, dump_objfile)
1137         (maintenance_print_symbols): Remove declaration.
1138         (maintenance_info_symtabs): Use compunit_filetabs.
1139         (maintenance_info_line_tables): Likewise.
1140         * source.c (select_source_symtab): Change local variable name.
1141         (forget_cached_source_info_for_objfile): Remove declaration.
1142         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1143         * objfiles.c (objfile_relocate1): Remove declaration.
1144         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1145         declaration.
1146         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1147         * coffread.c (coff_symtab_read): Remove declaration.
1148         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1149         compunit_filetabs.
1150
1151 2019-01-09  Tom Tromey  <tom@tromey.com>
1152
1153         * symtab.c (lookup_objfile_from_block)
1154         (find_pc_sect_compunit_symtab, search_symbols)
1155         (default_collect_symbol_completion_matches_break_on): Use
1156         objfile_compunits.
1157         * objfiles.h (ALL_COMPUNITS): Remove.
1158         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1159         * cp-support.c (add_symbol_overload_list_qualified): Use
1160         objfile_compunits.
1161         * ada-lang.c (ada_collect_symbol_completion_matches)
1162         (ada_add_global_exceptions): Use objfile_compunits.
1163
1164 2019-01-09  Tom Tromey  <tom@tromey.com>
1165
1166         * source.c (select_source_symtab)
1167         (forget_cached_source_info_for_objfile): Remove declaration.
1168         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1169         declaration.
1170         * maint.c (count_symtabs_and_blocks): Remove declaration.
1171         * cp-support.c (add_symbol_overload_list_qualified): Remove
1172         declaration.
1173         * coffread.c (coff_symtab_read): Remove declaration.
1174         * symtab.c (lookup_symbol_in_objfile_symtabs)
1175         (basic_lookup_transparent_type_1): Use objfile_compunits.
1176         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1177         (info_sources_command, search_symbols)
1178         (default_collect_symbol_completion_matches_break_on)
1179         (make_source_files_completion_list): Remove declaration.
1180         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1181         (ada_collect_symbol_completion_matches)
1182         (ada_add_global_exceptions): Remove declaration.
1183         * linespec.c (iterate_over_all_matching_symtabs): Use
1184         objfile_compunits.
1185         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1186         (class objfile_compunits): New.
1187         (ALL_COMPUNITS): Use objfile_compunits.
1188         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1189         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1190         objfile_compunits.
1191         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1192
1193 2019-01-09  Tom Tromey  <tom@tromey.com>
1194
1195         * symtab.c (search_symbols)
1196         (default_collect_symbol_completion_matches_break_on): Use
1197         objfile_msymbols.
1198         * ada-lang.c (ada_lookup_simple_minsym)
1199         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1200         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1201         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1202         objfile_msymbols.
1203         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1204         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1205         * objc-lang.c (find_methods): Use objfile_msymbols.
1206         (info_selectors_command, info_classes_command): Likewise.
1207         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1208         * objfiles.h (class objfile_msymbols): New.
1209         (ALL_OBJFILE_MSYMBOLS): Remove.
1210         (ALL_MSYMBOLS): Remove.
1211
1212 2019-01-09  Tom Tromey  <tom@tromey.com>
1213
1214         * common/next-iterator.h (next_adapter): Add Iterator template
1215         parameter.
1216         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1217         (class all_objfiles_safe): New.
1218         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1219         * objfiles.c (put_objfile_before): Update comment.
1220         (add_separate_debug_objfile): Likewise.
1221         (free_all_objfiles): Use all_objfiles_safe.
1222         (objfile_purge_solibs): Likewise.
1223
1224 2019-01-09  Tom Tromey  <tom@tromey.com>
1225
1226         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1227         (expand_symtab_containing_pc, lookup_static_symbol)
1228         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1229         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1230         all_objfiles.
1231         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1232         * breakpoint.c (create_overlay_event_breakpoint)
1233         (create_longjmp_master_breakpoint)
1234         (create_std_terminate_master_breakpoint)
1235         (create_exception_master_breakpoint): Use all_objfiles.
1236         * linux-thread-db.c (try_thread_db_load_from_pdir)
1237         (has_libpthread): Use all_objfiles.
1238         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1239         * linespec.c (iterate_over_all_matching_symtabs)
1240         (search_minsyms_for_name): Use all_objfiles.
1241         * maint.c (maintenance_info_sections): Use all_objfiles.
1242         * main.c (captured_main_1): Use all_objfiles.
1243         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1244         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1245         * guile/scm-pretty-print.c
1246         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1247         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1248         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1249         (maintenance_print_msymbols): Use all_objfiles.
1250         * source.c (select_source_symtab): Use all_objfiles.
1251         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1252         * symfile.c (remove_symbol_file_command)
1253         (expand_symtabs_matching, map_symbol_filenames): Use
1254         all_objfiles.
1255         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1256         all_objfiles.
1257         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1258         * objc-lang.c (find_methods): Use all_objfiles.
1259         * objfiles.c (have_partial_symbols, have_full_symbols)
1260         (have_minimal_symbols, qsort_cmp)
1261         (default_iterate_over_objfiles_in_search_order): Use
1262         all_objfiles.
1263         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1264         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1265         (maintenance_check_psymtabs): Use all_objfiles.
1266         (ALL_PSYMTABS): Remove.
1267         * compile/compile-object-run.c (do_module_cleanup): Use
1268         all_objfiles.
1269         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1270         * cp-support.c (add_symbol_overload_list_qualified): Use
1271         all_objfiles.
1272         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1273         Use all_objfiles.
1274         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1275         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1276         all_objfiles.
1277         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1278         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1279         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1280         Uses all_objfiles.
1281         * solib.c (solib_read_symbols): Use all_objfiles
1282
1283 2019-01-09  Tom Tromey  <tom@tromey.com>
1284
1285         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1286         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1287         all_objfiles.
1288         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1289         * symmisc.c (print_symbol_bcache_statistics)
1290         (print_objfile_statistics, maintenance_print_objfiles)
1291         (maintenance_info_symtabs, maintenance_check_symtabs)
1292         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1293         all_objfiles.
1294         * source.c (forget_cached_source_info): Use all_objfiles.
1295         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1296         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1297         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1298         * objfiles.c (update_section_map): Use all_objfiles.
1299         (shared_objfile_contains_address_p): Likewise.
1300         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1301         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1302
1303 2019-01-09  Tom Tromey  <tom@tromey.com>
1304
1305         * common/next-iterator.h: New file.
1306         * objfiles.h (class all_objfiles): New.
1307         (struct objfile_iterator): New.
1308
1309 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1310
1311         * NEWS: Move the description of the changed "frame", "select-frame",
1312          and "info frame" commands to the Changed commands section.
1313
1314 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1315
1316         * gdbtypes.c (check_stub_method_group): Remove handling of old
1317         mangling schemes.
1318         * linespec.c (find_methods): Likewise.
1319         * stabsread.c (read_member_functions): Likewise.
1320         * valops.c (search_struct_method): Likewise.
1321         (value_struct_elt_for_reference): Likewise.
1322         * NEWS: Mention this change.
1323
1324 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1325
1326         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1327         print_source_lines.
1328         * source.c (print_source_lines_base): Update line number check.
1329         (print_source_lines): New function.
1330         (source_lines_range::source_lines_range): New function.
1331         * source.h (class source_lines_range): New class.
1332         (print_source_lines): New declaration.
1333
1334 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1335
1336         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1337
1338 2019-01-08  Tom Tromey  <tom@tromey.com>
1339             Simon Marchi  <simon.marchi@ericsson.com>
1340
1341         PR gdb/24060
1342         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1343         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1344         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1345         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1346         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1347         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1348
1349 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1350
1351         * source.c (select_source_symtab): Move header comment to
1352         declaration in source.h.
1353         (forget_cached_source_info_for_objfile): Likewise.
1354         (forget_cached_source_info): Likewise.
1355         (identify_source_line): Likewise.
1356         * source.h (identify_source_line): Move declaration from symtab.h
1357         and add comment from source.c
1358         (print_source_lines): Likewise.
1359         (forget_cached_source_info_for_objfile): Likewise.
1360         (forget_cached_source_info): Likewise.
1361         (select_source_symtab): Likewise.
1362         (enum print_source_lines_flag): Move definition from symtab.h.
1363         * symtab.h (identify_source_line): Move declaration to source.h.
1364         (print_source_lines): Likewise.
1365         (forget_cached_source_info_for_objfile): Likewise.
1366         (forget_cached_source_info): Likewise.
1367         (select_source_symtab): Likewise.
1368         (enum print_source_lines_flag): Move definition to source.h.
1369         * tui/tui-hooks.c: Add 'source.h' include.
1370
1371 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1372
1373         * source.c (print_source_lines_base): Handle requests to print
1374         reverse line number sequences, and guard against empty lines
1375         string.
1376
1377 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1378
1379         * source.c (print_source_lines_base): Fix skip of '\r' if next
1380         character is '\n'.
1381
1382 2019-01-06  Tom Tromey  <tom@tromey.com>
1383
1384         * c-exp.y (struct c_parse_state) <macro_original_text,
1385         expansion_obstack>: New member.
1386         (macro_original_text, expansion_obstack): Remove globals.
1387         (scan_macro_expansion, scanning_macro_expansion)
1388         (finished_macro_expansion): Update.
1389         (scan_macro_cleanup): Remove.
1390         (yylex, c_parse): Update.
1391
1392 2019-01-06  Tom Tromey  <tom@tromey.com>
1393
1394         * c-exp.y (struct c_parse_state) <strings>: New member.
1395         (operator_stoken): Update.
1396
1397 2019-01-06  Tom Tromey  <tom@tromey.com>
1398
1399         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1400         (union type_stack_elt) <typelist_val>: Now a pointer to
1401         std::vector.
1402         (type_stack_cleanup): Don't declare.
1403         (push_typelist): Update.
1404         * parse.c (pop_typelist): Return a std::vector.
1405         (push_typelist): Take a std::vector.
1406         (follow_types): Update.  Do not free args.
1407         (type_stack_cleanup): Remove.
1408         * c-exp.y (struct c_parse_state): New.
1409         (cpstate): New global.
1410         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1411         (nonempty_typelist): Update.
1412         (func_mod): Create a new vector.
1413         (c_parse): Create a c_parse_state.
1414         (check_parameter_typelist): Do not delete params.
1415         (function_method): Update.  Do not delete type_list.
1416
1417 2019-01-06  Tom Tromey  <tom@tromey.com>
1418
1419         PR gdb/28155:
1420         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1421         check_typedef.
1422         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1423         (print_return_value): Likewise.
1424
1425 2019-01-05  Tom Tromey  <tom@tromey.com>
1426
1427         * contrib/cleanup_check.py: Remove.
1428         * contrib/gcc-with-excheck: Remove.
1429         * contrib/exsummary.py: Remove.
1430         * contrib/excheck.py: Remove.
1431
1432 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1433
1434         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1435         NULL. Initialize tpprev to NULL instead of assigning it
1436         to NULL on the next statement.
1437         * windows-nat.c (windows_delete_thread): Remove check for
1438         main_thread_id before printing thread exit notifications.
1439         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1440         Remove thread ID check against main_thread_id.
1441         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1442         windows_delete_thread.
1443         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1444
1445 2019-01-04  Tom Tromey  <tom@tromey.com>
1446
1447         * compile/compile.c (_initialize_compile): Use upper case for
1448         metasyntactic variables.
1449         * symmisc.c (_initialize_symmisc): Use upper case for
1450         metasyntactic variables.
1451         * psymtab.c (_initialize_psymtab): Use upper case for
1452         metasyntactic variables.
1453         * demangle.c (demangle_command): Use upper case for metasyntactic
1454         variables.
1455         (_initialize_demangler): Likewise.
1456         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1457         variables.
1458
1459 2019-01-03  Tom Tromey  <tom@tromey.com>
1460
1461         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1462
1463 2019-01-03  Tom Tromey  <tom@tromey.com>
1464
1465         * python/py-symtab.c (salpy_str): Update.
1466         (struct salpy_sal_object) <symtab>: Now a PyObject.
1467         (salpy_dealloc): Update.
1468         (del_objfile_sal): Use gdbpy_ref.
1469
1470 2019-01-03  Tom Tromey  <tom@tromey.com>
1471
1472         * python/py-type.c (convert_field): Use new_reference.  Return
1473         gdbpy_ref.
1474         (make_fielditem): Return gdbpy_ref.
1475         (typy_fields): Update.
1476         (typy_getitem): Update.
1477         (field_name): Return gdbpy_ref.  Use new_reference.
1478         (typy_iterator_iternext): Update.
1479
1480 2019-01-03  Tom Tromey  <tom@tromey.com>
1481
1482         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1483
1484 2019-01-03  Tom Tromey  <tom@tromey.com>
1485
1486         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1487         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1488         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1489         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1490         (pspy_set_type_printers): Likewise.
1491         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1492         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1493         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1494         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1495         (objfpy_set_type_printers): Likewise.
1496
1497 2019-01-03  Tom Tromey  <tom@tromey.com>
1498
1499         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1500         (gdbpy_print_stack): Use gdbpy_err_fetch.
1501         * python/python-internal.h (class gdbpy_err_fetch): New class.
1502         (class gdbpy_enter) <m_error_type, m_error_value,
1503         m_error_traceback>: Remove.
1504         <m_error>: New member.
1505         (gdbpy_exception_to_string): Don't declare.
1506         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1507         * python/py-value.c (convert_value_from_python): Use
1508         gdbpy_err_fetch.
1509         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1510         gdbpy_exception_to_string.
1511         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1512         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1513         gdbpy_err_fetch.
1514
1515 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1516
1517         * linux-nat.c (delete_lwp_cleanup): Delete.
1518         (struct lwp_deleter): New struct.
1519         (lwp_info_up): New typedef.
1520         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1521         lwp_info_up.
1522
1523 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1524
1525         * linux-fork.c (class scoped_switch_fork_info): New class.
1526         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1527
1528 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1529
1530         * valops.c (find_overload_match): Remove use of null_cleanup, and
1531         calls to do_cleanups.
1532
1533 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1534
1535         * compile/compile-cplus-types.c
1536         (compile_cplus_instance::decl_name): Handle changes to
1537         cp_func_name.
1538         * cp-support.c (cp_func_name): Update header comment, update
1539         return type.
1540         * cp-support.h (cp_func_name): Update return type in declaration.
1541         * valops.c (find_overload_match): Move temp_func local to top
1542         level of function and change its type.  Use temp_func to hold and
1543         delete temporary string obtained from cp_func_name.
1544
1545 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1546
1547         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1548         gdb::char_vector, remove cleanup, and update uses of `msg`.
1549
1550 2019-01-03  Jim Wilson  <jimw@sifive.com>
1551
1552         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1553
1554 2019-01-02  Tom Tromey  <tom@tromey.com>
1555
1556         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1557         (tdesc_parse_xml): Remove cleanups.
1558         * target-descriptions.h (make_cleanup_free_target_description):
1559         Don't declare.
1560         (target_desc_deleter): New struct.
1561         (target_desc_up): New typedef.
1562         * target-descriptions.c (target_desc_deleter::operator()): Rename
1563         from free_target_description.
1564         (make_cleanup_free_target_description): Remove.
1565
1566 2019-01-02  Tom Tromey  <tom@tromey.com>
1567
1568         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1569         constructor, destructor.
1570         (linespec_parser): Remove typedef.
1571         (~linespec_parser): Rename from linespec_parser_delete.
1572         (linespec_lex_to_end, linespec_complete_label)
1573         (linespec_complete): Update.
1574         (decode_line_full): Remove cleanups.
1575         (decode_line_1): Update.
1576
1577 2019-01-02  Tom Tromey  <tom@tromey.com>
1578
1579         * python/python-internal.h (inferior_to_inferior_object): Change
1580         return type.
1581         * python/py-exitedevent.c (create_exited_event_object): Update.
1582         * python/py-inferior.c (inferior_to_inferior_object): Return
1583         gdbpy_ref.
1584         (python_new_inferior, python_inferior_deleted)
1585         (thread_to_thread_object, delete_thread_object)
1586         (build_inferior_list, gdbpy_selected_inferior): Update.
1587         * python/py-infthread.c (create_thread_object): Update.  Also fail
1588         if inferior_to_inferior_object fails.
1589
1590 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1591
1592         * inferior.h (class inferior) <displaced_step_state>: New field.
1593         * infrun.h (struct displaced_step_state): Move here from
1594         infrun.c.  Initialize fields, add constructor.
1595         <inf>: Remove field.
1596         <reset>: New method.
1597         * infrun.c (struct displaced_step_inferior_state): Move to
1598         infrun.h.
1599         (displaced_step_inferior_states): Remove.
1600         (get_displaced_stepping_state): Adust.
1601         (displaced_step_in_progress_any_inferior): Adjust.
1602         (displaced_step_in_progress_thread): Adjust.
1603         (displaced_step_in_progress): Adjust.
1604         (add_displaced_stepping_state): Remove.
1605         (get_displaced_step_closure_by_addr): Adjust.
1606         (remove_displaced_stepping_state): Remove.
1607         (infrun_inferior_exit): Call displaced_step_state.reset.
1608         (use_displaced_stepping): Don't check for NULL.
1609         (displaced_step_prepare_throw): Call
1610         get_displaced_stepping_state.
1611         (displaced_step_fixup): Don't check for NULL.
1612         (prepare_for_detach): Don't check for NULL.
1613
1614 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1615
1616         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1617          in case of call that did not complete.
1618
1619 2019-01-02  Andrey Utkin  <autkin@undo.io>
1620
1621         * symfile.c (find_separate_debug_file): Fix search of debug files for
1622         remote debuggee.
1623
1624 2019-01-02  Tom Tromey  <tom@tromey.com>
1625
1626         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1627         indentation.
1628         * python/py-frame.c (frapy_older): Remove cast.
1629         (frapy_newer): Likewise.
1630         * python/py-breakpoint.c (local_setattro): Remove cast.
1631         * python/py-arch.c (archpy_name): Remove local variable.
1632         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1633
1634 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1635
1636         * unittests/basic_string_view/element_access/char/empty.cc:
1637         Fix year range in copyright header.
1638
1639 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1640
1641         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1642         Delete.
1643         <operator==>: Update with for removed field.
1644         <hash>: Likewise.
1645         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1646         <isa_features>: ...this.
1647         <abi_features>: New field.
1648         (riscv_isa_flen): Update comment.
1649         (riscv_abi_xlen): New declaration.
1650         (riscv_abi_flen): New declaration.
1651         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1652         isa_features.
1653         (riscv_abi_xlen): New function.
1654         (riscv_isa_flen): Update to get answer from isa_features.
1655         (riscv_abi_flen): New function.
1656         (riscv_has_fp_abi): Update to get answer from abi_features.
1657         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1658         xlen and flen.
1659         (riscv_call_info) <xlen, flen>: Update comment.
1660         (riscv_call_arg_struct): Remove invalid assertions
1661         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1662         is removed.
1663         (riscv_gdbarch_init): Gather isa features and abi features
1664         separately, ensure both match on the gdbarch when reusing an old
1665         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1666         a target with 64-bit float hardware.
1667
1668 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1669
1670         * source.c (search_command_helper): Stop reverse search
1671         when line 1 has been searched.
1672
1673 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1674
1675         * record-full.c (record_full_base_target::close): Rewrite
1676         record_full_core_buf_list free logic.
1677
1678 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1679
1680         * break-catch-syscall.c (print_one_catch_syscall): xfree
1681         the last text.
1682
1683 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1684
1685         * top.c (print_gdb_version): Update Copyright year in version
1686         message.
1687
1688 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1689
1690         Update copyright year range in all GDB files.
1691
1692 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1693
1694         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1695
1696 For older changes see ChangeLog-2018.
1697 \f
1698 Local Variables:
1699 mode: change-log
1700 left-margin: 8
1701 fill-column: 74
1702 version-control: never
1703 coding: utf-8
1704 End:
1705