gdb/ChangeLog

   1 2019-01-10  Tom Tromey  <tom@tromey.com>
   2
   3         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
   4         <free_psymtabs>: Now private.
   5         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
   6         (allocate_psymtab): Use new method.
   7
   8 2019-01-10  Tom Tromey  <tom@tromey.com>
   9
  10         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
  11         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
  12         * mdebugread.c (parse_partial_symbols): Use
  13         allocate_dependencies.
  14         * dwarf2read.c (dwarf2_create_include_psymtab): Use
  15         allocate_dependencies.
  16         (process_psymtab_comp_unit_reader)
  17         (build_type_psymtab_dependencies): Likewise.
  18         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
  19
  20 2019-01-10  Tom Tromey  <tom@tromey.com>
  21
  22         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
  23         PSYMBOL_SET_LANGUAGE.
  24         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
  25
  26 2019-01-10  Tom Tromey  <tom@tromey.com>
  27
  28         * psymtab.h (psymtab_storage::obstack): New method.
  29         <m_obstack>: Rename from obstack; now private.
  30         * psymtab.c (psymtab_storage): Update.
  31         * dwarf2read.c (create_addrmap_from_index)
  32         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
  33         Update.
  34
  35 2019-01-10  Tom Tromey  <tom@tromey.com>
  36
  37         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
  38         * objfiles.h (objfile::reset_psymtabs): New method.
  39
  40 2019-01-10  Tom Tromey  <tom@tromey.com>
  41
  42         * symmisc.c (print_symbol_bcache_statistics): Update.
  43         (print_objfile_statistics): Update.
  44         * symfile.c (reread_symbols): Update.
  45         * psymtab.h (class psymtab_storage): New.
  46         * psymtab.c (psymtab_storage): New constructor.
  47         (~psymtab_storage): New destructor.
  48         (require_partial_symbols): Update.
  49         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
  50         (find_pc_sect_psymtab, find_pc_sect_psymbol)
  51         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
  52         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
  53         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
  54         (start_psymtab_common, end_psymtab_common)
  55         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
  56         (allocate_psymtab): Update.
  57         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
  58         Update.
  59         (dump_psymtab_addrmap, maintenance_print_psymbols)
  60         (maintenance_check_psymtabs): Update.
  61         (class objfile_psymtabs): Move to objfiles.h.
  62         * psympriv.h (discard_psymtab): Now inline.
  63         (psymtab_discarder::psymtab_discarder): Update.
  64         (psymtab_discarder::~psymtab_discarder): Update.
  65         (ALL_OBJFILE_PSYMTABS): Rewrite.
  66         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
  67         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
  68         Remove fields.
  69         <partial_symtabs>: New field.
  70         (class objfile_psymtabs): Move from psymtab.h.  Update.
  71         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
  72         psymbol_cache.
  73         (objfile::~objfile): Don't destroy psymbol_cache.
  74         * mdebugread.c (parse_partial_symbols): Update.
  75         * dwarf2read.c (create_addrmap_from_index)
  76         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
  77         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
  78         (add_partial_subprogram, dwarf2_ranges_read): Update.
  79         * dwarf-index-write.c (write_address_map)
  80         (write_one_signatured_type, recursively_write_psymbols)
  81         (class debug_names, class debug_names, write_psymtabs_to_index):
  82         Update.
  83
  84 2019-01-10  Tom Tromey  <tom@tromey.com>
  85
  86         * symtab.h (SYMBOL_SET_NAMES): Update.
  87         (symbol_set_names): Update.
  88         (MSYMBOL_SET_NAMES): Update.
  89         * symtab.c (symbol_set_names): Change argument to be an
  90         objfile_per_bfd_storage.
  91         * psymtab.c (add_psymbol_to_bcache): Update.
  92         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
  93
  94 2019-01-10  Tom Tromey  <tom@tromey.com>
  95
  96         * symtab.c (create_demangled_names_hash): Change argument to be an
  97         objfile_per_bfd_storage.
  98         (symbol_set_names): Update.
  99
 100 2019-01-10  Tom Tromey  <tom@tromey.com>
 101
 102         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 103         init_psymbol_list.
 104         * psymtab.c (init_psymbol_list): Do nothing if already called.
 105         * psympriv.h (init_psymbol_list): Add comment.
 106         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 107         init_psymbol_list.
 108         * dbxread.c (dbx_symfile_read): Unconditionally call
 109         init_psymbol_list.
 110
 111 2019-01-10  Tom Tromey  <tom@tromey.com>
 112
 113         * xcoffread.c (scan_xcoff_symtab): Update.
 114         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 115         "where".
 116         * mdebugread.c (parse_partial_symbols)
 117         (handle_psymbol_enumerators): Update.
 118         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 119         * dbxread.c (read_dbx_symtab): Update.
 120         * psympriv.h (psymbol_placement): New enum.
 121         (add_psymbol_to_list): Update.
 122
 123 2019-01-10  Tom Tromey  <tom@tromey.com>
 124
 125         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 126         static_psymbols parameters.
 127         (scan_xcoff_symtab): Update.
 128         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 129         static_psymbols parameters.
 130         * psympriv.h (start_psymtab_common): Update.
 131         * mdebugread.c (parse_partial_symbols): Update.
 132         * dwarf2read.c (create_partial_symtab): Update.
 133         * dbxread.c (read_dbx_symtab): Update.
 134         (start_psymtab): Remove global_psymbols and static_psymbols
 135         parameters.
 136
 137 2019-01-10  Tom Tromey  <tom@tromey.com>
 138
 139         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 140         * psymtab.c (allocate_psymtab): Add comment.
 141         * psympriv.h (allocate_psymtab): Add comment.
 142         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 143         initializations.
 144         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 145
 146 2019-01-10  Tom Tromey  <tom@tromey.com>
 147
 148         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 149         Don't declare.
 150         * mipsread.c: Include mdebugread.h.
 151         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 152         Declare.
 153         * elfread.c: Include mdebugread.h.
 154
 155 2019-01-09  Tom Tromey  <tom@tromey.com>
 156
 157         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 158         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 159         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 160         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 161         (psym_lookup_symbol, psym_find_last_source_symtab)
 162         (psym_forget_cached_source_info, psym_print_stats)
 163         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 164         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 165         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 166         (psym_find_compunit_symtab_by_address)
 167         (maintenance_print_psymbols, maintenance_info_psymtabs)
 168         (maintenance_check_psymtabs): Use ranged for.
 169         * psymtab.h (class objfile_psymtabs): New.
 170         (require_partial_symbols): Return objfile_psymtabs.
 171         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 172
 173 2019-01-09  Tom Tromey  <tom@tromey.com>
 174
 175         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 176         (find_pc_mapped_section, list_overlays_command)
 177         (map_overlay_command, unmap_overlay_command)
 178         (simple_overlay_update): Use all_objfiles.
 179         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 180         * printcmd.c (info_symbol_command): Use all_objfiles.
 181         * objfiles.h (ALL_OBJSECTIONS): Remove.
 182         * maint.c (maintenance_translate_address): Use all_objfiles.
 183         * gcore.c (gcore_create_callback): Use all_objfiles.
 184         (objfile_find_memory_regions): Likewise.
 185
 186 2019-01-09  Tom Tromey  <tom@tromey.com>
 187
 188         * symtab.c (find_line_symtab, info_sources_command)
 189         (make_source_files_completion_list): Use objfile_compunits.
 190         * source.c (select_source_symtab): Use objfile_compunits.
 191         * objfiles.h (struct objfile): Update comment.
 192         (ALL_OBJFILES): Remove.
 193         (ALL_FILETABS): Remove.
 194         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 195         objfile_compunits.
 196
 197 2019-01-09  Tom Tromey  <tom@tromey.com>
 198
 199         * symmisc.c (print_objfile_statistics, dump_objfile)
 200         (maintenance_print_symbols): Use compunit_filetabs.
 201         * source.c (forget_cached_source_info_for_objfile): Use
 202         compunit_filetabs.
 203         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 204         (ALL_FILETABS): Use compunit_filetabs.
 205         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 206         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 207
 208 2019-01-09  Tom Tromey  <tom@tromey.com>
 209
 210         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 211         (compunit_filetabs): New.
 212         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 213         compunit_filetabs.
 214         (info_sources_command, make_source_files_completion_list): Remove
 215         declaration.
 216         * symmisc.c (print_objfile_statistics, dump_objfile)
 217         (maintenance_print_symbols): Remove declaration.
 218         (maintenance_info_symtabs): Use compunit_filetabs.
 219         (maintenance_info_line_tables): Likewise.
 220         * source.c (select_source_symtab): Change local variable name.
 221         (forget_cached_source_info_for_objfile): Remove declaration.
 222         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 223         * objfiles.c (objfile_relocate1): Remove declaration.
 224         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 225         declaration.
 226         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 227         * coffread.c (coff_symtab_read): Remove declaration.
 228         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 229         compunit_filetabs.
 230
 231 2019-01-09  Tom Tromey  <tom@tromey.com>
 232
 233         * symtab.c (lookup_objfile_from_block)
 234         (find_pc_sect_compunit_symtab, search_symbols)
 235         (default_collect_symbol_completion_matches_break_on): Use
 236         objfile_compunits.
 237         * objfiles.h (ALL_COMPUNITS): Remove.
 238         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 239         * cp-support.c (add_symbol_overload_list_qualified): Use
 240         objfile_compunits.
 241         * ada-lang.c (ada_collect_symbol_completion_matches)
 242         (ada_add_global_exceptions): Use objfile_compunits.
 243
 244 2019-01-09  Tom Tromey  <tom@tromey.com>
 245
 246         * source.c (select_source_symtab)
 247         (forget_cached_source_info_for_objfile): Remove declaration.
 248         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 249         declaration.
 250         * maint.c (count_symtabs_and_blocks): Remove declaration.
 251         * cp-support.c (add_symbol_overload_list_qualified): Remove
 252         declaration.
 253         * coffread.c (coff_symtab_read): Remove declaration.
 254         * symtab.c (lookup_symbol_in_objfile_symtabs)
 255         (basic_lookup_transparent_type_1): Use objfile_compunits.
 256         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 257         (info_sources_command, search_symbols)
 258         (default_collect_symbol_completion_matches_break_on)
 259         (make_source_files_completion_list): Remove declaration.
 260         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 261         (ada_collect_symbol_completion_matches)
 262         (ada_add_global_exceptions): Remove declaration.
 263         * linespec.c (iterate_over_all_matching_symtabs): Use
 264         objfile_compunits.
 265         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 266         (class objfile_compunits): New.
 267         (ALL_COMPUNITS): Use objfile_compunits.
 268         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 269         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 270         objfile_compunits.
 271         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 272
 273 2019-01-09  Tom Tromey  <tom@tromey.com>
 274
 275         * symtab.c (search_symbols)
 276         (default_collect_symbol_completion_matches_break_on): Use
 277         objfile_msymbols.
 278         * ada-lang.c (ada_lookup_simple_minsym)
 279         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 280         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 281         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 282         objfile_msymbols.
 283         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 284         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 285         * objc-lang.c (find_methods): Use objfile_msymbols.
 286         (info_selectors_command, info_classes_command): Likewise.
 287         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 288         * objfiles.h (class objfile_msymbols): New.
 289         (ALL_OBJFILE_MSYMBOLS): Remove.
 290         (ALL_MSYMBOLS): Remove.
 291
 292 2019-01-09  Tom Tromey  <tom@tromey.com>
 293
 294         * common/next-iterator.h (next_adapter): Add Iterator template
 295         parameter.
 296         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 297         (class all_objfiles_safe): New.
 298         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 299         * objfiles.c (put_objfile_before): Update comment.
 300         (add_separate_debug_objfile): Likewise.
 301         (free_all_objfiles): Use all_objfiles_safe.
 302         (objfile_purge_solibs): Likewise.
 303
 304 2019-01-09  Tom Tromey  <tom@tromey.com>
 305
 306         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 307         (expand_symtab_containing_pc, lookup_static_symbol)
 308         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 309         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 310         all_objfiles.
 311         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 312         * breakpoint.c (create_overlay_event_breakpoint)
 313         (create_longjmp_master_breakpoint)
 314         (create_std_terminate_master_breakpoint)
 315         (create_exception_master_breakpoint): Use all_objfiles.
 316         * linux-thread-db.c (try_thread_db_load_from_pdir)
 317         (has_libpthread): Use all_objfiles.
 318         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 319         * linespec.c (iterate_over_all_matching_symtabs)
 320         (search_minsyms_for_name): Use all_objfiles.
 321         * maint.c (maintenance_info_sections): Use all_objfiles.
 322         * main.c (captured_main_1): Use all_objfiles.
 323         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 324         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 325         * guile/scm-pretty-print.c
 326         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 327         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 328         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 329         (maintenance_print_msymbols): Use all_objfiles.
 330         * source.c (select_source_symtab): Use all_objfiles.
 331         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 332         * symfile.c (remove_symbol_file_command)
 333         (expand_symtabs_matching, map_symbol_filenames): Use
 334         all_objfiles.
 335         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 336         all_objfiles.
 337         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 338         * objc-lang.c (find_methods): Use all_objfiles.
 339         * objfiles.c (have_partial_symbols, have_full_symbols)
 340         (have_minimal_symbols, qsort_cmp)
 341         (default_iterate_over_objfiles_in_search_order): Use
 342         all_objfiles.
 343         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 344         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 345         (maintenance_check_psymtabs): Use all_objfiles.
 346         (ALL_PSYMTABS): Remove.
 347         * compile/compile-object-run.c (do_module_cleanup): Use
 348         all_objfiles.
 349         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 350         * cp-support.c (add_symbol_overload_list_qualified): Use
 351         all_objfiles.
 352         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 353         Use all_objfiles.
 354         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 355         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 356         all_objfiles.
 357         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 358         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 359         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 360         Uses all_objfiles.
 361         * solib.c (solib_read_symbols): Use all_objfiles
 362
 363 2019-01-09  Tom Tromey  <tom@tromey.com>
 364
 365         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 366         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 367         all_objfiles.
 368         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 369         * symmisc.c (print_symbol_bcache_statistics)
 370         (print_objfile_statistics, maintenance_print_objfiles)
 371         (maintenance_info_symtabs, maintenance_check_symtabs)
 372         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 373         all_objfiles.
 374         * source.c (forget_cached_source_info): Use all_objfiles.
 375         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 376         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 377         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 378         * objfiles.c (update_section_map): Use all_objfiles.
 379         (shared_objfile_contains_address_p): Likewise.
 380         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 381         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 382
 383 2019-01-09  Tom Tromey  <tom@tromey.com>
 384
 385         * common/next-iterator.h: New file.
 386         * objfiles.h (class all_objfiles): New.
 387         (struct objfile_iterator): New.
 388
 389 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 390
 391         * NEWS: Move the description of the changed "frame", "select-frame",
 392          and "info frame" commands to the Changed commands section.
 393
 394 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 395
 396         * gdbtypes.c (check_stub_method_group): Remove handling of old
 397         mangling schemes.
 398         * linespec.c (find_methods): Likewise.
 399         * stabsread.c (read_member_functions): Likewise.
 400         * valops.c (search_struct_method): Likewise.
 401         (value_struct_elt_for_reference): Likewise.
 402         * NEWS: Mention this change.
 403
 404 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 405
 406         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 407         print_source_lines.
 408         * source.c (print_source_lines_base): Update line number check.
 409         (print_source_lines): New function.
 410         (source_lines_range::source_lines_range): New function.
 411         * source.h (class source_lines_range): New class.
 412         (print_source_lines): New declaration.
 413
 414 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 415
 416         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 417
 418 2019-01-08  Tom Tromey  <tom@tromey.com>
 419             Simon Marchi  <simon.marchi@ericsson.com>
 420
 421         PR gdb/24060
 422         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 423         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 424         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 425         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 426         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 427         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 428
 429 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 430
 431         * source.c (select_source_symtab): Move header comment to
 432         declaration in source.h.
 433         (forget_cached_source_info_for_objfile): Likewise.
 434         (forget_cached_source_info): Likewise.
 435         (identify_source_line): Likewise.
 436         * source.h (identify_source_line): Move declaration from symtab.h
 437         and add comment from source.c
 438         (print_source_lines): Likewise.
 439         (forget_cached_source_info_for_objfile): Likewise.
 440         (forget_cached_source_info): Likewise.
 441         (select_source_symtab): Likewise.
 442         (enum print_source_lines_flag): Move definition from symtab.h.
 443         * symtab.h (identify_source_line): Move declaration to source.h.
 444         (print_source_lines): Likewise.
 445         (forget_cached_source_info_for_objfile): Likewise.
 446         (forget_cached_source_info): Likewise.
 447         (select_source_symtab): Likewise.
 448         (enum print_source_lines_flag): Move definition to source.h.
 449         * tui/tui-hooks.c: Add 'source.h' include.
 450
 451 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 452
 453         * source.c (print_source_lines_base): Handle requests to print
 454         reverse line number sequences, and guard against empty lines
 455         string.
 456
 457 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 458
 459         * source.c (print_source_lines_base): Fix skip of '\r' if next
 460         character is '\n'.
 461
 462 2019-01-06  Tom Tromey  <tom@tromey.com>
 463
 464         * c-exp.y (struct c_parse_state) <macro_original_text,
 465         expansion_obstack>: New member.
 466         (macro_original_text, expansion_obstack): Remove globals.
 467         (scan_macro_expansion, scanning_macro_expansion)
 468         (finished_macro_expansion): Update.
 469         (scan_macro_cleanup): Remove.
 470         (yylex, c_parse): Update.
 471
 472 2019-01-06  Tom Tromey  <tom@tromey.com>
 473
 474         * c-exp.y (struct c_parse_state) <strings>: New member.
 475         (operator_stoken): Update.
 476
 477 2019-01-06  Tom Tromey  <tom@tromey.com>
 478
 479         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 480         (union type_stack_elt) <typelist_val>: Now a pointer to
 481         std::vector.
 482         (type_stack_cleanup): Don't declare.
 483         (push_typelist): Update.
 484         * parse.c (pop_typelist): Return a std::vector.
 485         (push_typelist): Take a std::vector.
 486         (follow_types): Update.  Do not free args.
 487         (type_stack_cleanup): Remove.
 488         * c-exp.y (struct c_parse_state): New.
 489         (cpstate): New global.
 490         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 491         (nonempty_typelist): Update.
 492         (func_mod): Create a new vector.
 493         (c_parse): Create a c_parse_state.
 494         (check_parameter_typelist): Do not delete params.
 495         (function_method): Update.  Do not delete type_list.
 496
 497 2019-01-06  Tom Tromey  <tom@tromey.com>
 498
 499         PR gdb/28155:
 500         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
 501         check_typedef.
 502         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
 503         (print_return_value): Likewise.
 504
 505 2019-01-05  Tom Tromey  <tom@tromey.com>
 506
 507         * contrib/cleanup_check.py: Remove.
 508         * contrib/gcc-with-excheck: Remove.
 509         * contrib/exsummary.py: Remove.
 510         * contrib/excheck.py: Remove.
 511
 512 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
 513
 514         * thread.c (delete_thread_1): Add gdb_assert that THR is not
 515         NULL. Initialize tpprev to NULL instead of assigning it
 516         to NULL on the next statement.
 517         * windows-nat.c (windows_delete_thread): Remove check for
 518         main_thread_id before printing thread exit notifications.
 519         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
 520         Remove thread ID check against main_thread_id.
 521         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
 522         windows_delete_thread.
 523         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
 524
 525 2019-01-04  Tom Tromey  <tom@tromey.com>
 526
 527         * compile/compile.c (_initialize_compile): Use upper case for
 528         metasyntactic variables.
 529         * symmisc.c (_initialize_symmisc): Use upper case for
 530         metasyntactic variables.
 531         * psymtab.c (_initialize_psymtab): Use upper case for
 532         metasyntactic variables.
 533         * demangle.c (demangle_command): Use upper case for metasyntactic
 534         variables.
 535         (_initialize_demangler): Likewise.
 536         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
 537         variables.
 538
 539 2019-01-03  Tom Tromey  <tom@tromey.com>
 540
 541         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
 542
 543 2019-01-03  Tom Tromey  <tom@tromey.com>
 544
 545         * python/py-symtab.c (salpy_str): Update.
 546         (struct salpy_sal_object) <symtab>: Now a PyObject.
 547         (salpy_dealloc): Update.
 548         (del_objfile_sal): Use gdbpy_ref.
 549
 550 2019-01-03  Tom Tromey  <tom@tromey.com>
 551
 552         * python/py-type.c (convert_field): Use new_reference.  Return
 553         gdbpy_ref.
 554         (make_fielditem): Return gdbpy_ref.
 555         (typy_fields): Update.
 556         (typy_getitem): Update.
 557         (field_name): Return gdbpy_ref.  Use new_reference.
 558         (typy_iterator_iternext): Update.
 559
 560 2019-01-03  Tom Tromey  <tom@tromey.com>
 561
 562         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
 563
 564 2019-01-03  Tom Tromey  <tom@tromey.com>
 565
 566         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
 567         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
 568         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
 569         (pspy_set_frame_filters, pspy_set_frame_unwinders)
 570         (pspy_set_type_printers): Likewise.
 571         * python/py-function.c (fnpy_init): Use gdbpy_ref.
 572         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
 573         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
 574         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
 575         (objfpy_set_type_printers): Likewise.
 576
 577 2019-01-03  Tom Tromey  <tom@tromey.com>
 578
 579         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
 580         (gdbpy_print_stack): Use gdbpy_err_fetch.
 581         * python/python-internal.h (class gdbpy_err_fetch): New class.
 582         (class gdbpy_enter) <m_error_type, m_error_value,
 583         m_error_traceback>: Remove.
 584         <m_error>: New member.
 585         (gdbpy_exception_to_string): Don't declare.
 586         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
 587         * python/py-value.c (convert_value_from_python): Use
 588         gdbpy_err_fetch.
 589         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
 590         gdbpy_exception_to_string.
 591         (gdbpy_handle_exception): Use gdbpy_err_fetch.
 592         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 593         gdbpy_err_fetch.
 594
 595 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 596
 597         * linux-nat.c (delete_lwp_cleanup): Delete.
 598         (struct lwp_deleter): New struct.
 599         (lwp_info_up): New typedef.
 600         (linux_nat_target::follow_fork): Delete cleanup, and make use of
 601         lwp_info_up.
 602
 603 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 604
 605         * linux-fork.c (class scoped_switch_fork_info): New class.
 606         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
 607
 608 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 609
 610         * valops.c (find_overload_match): Remove use of null_cleanup, and
 611         calls to do_cleanups.
 612
 613 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 614
 615         * compile/compile-cplus-types.c
 616         (compile_cplus_instance::decl_name): Handle changes to
 617         cp_func_name.
 618         * cp-support.c (cp_func_name): Update header comment, update
 619         return type.
 620         * cp-support.h (cp_func_name): Update return type in declaration.
 621         * valops.c (find_overload_match): Move temp_func local to top
 622         level of function and change its type.  Use temp_func to hold and
 623         delete temporary string obtained from cp_func_name.
 624
 625 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 626
 627         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
 628         gdb::char_vector, remove cleanup, and update uses of `msg`.
 629
 630 2019-01-03  Jim Wilson  <jimw@sifive.com>
 631
 632         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
 633
 634 2019-01-02  Tom Tromey  <tom@tromey.com>
 635
 636         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
 637         (tdesc_parse_xml): Remove cleanups.
 638         * target-descriptions.h (make_cleanup_free_target_description):
 639         Don't declare.
 640         (target_desc_deleter): New struct.
 641         (target_desc_up): New typedef.
 642         * target-descriptions.c (target_desc_deleter::operator()): Rename
 643         from free_target_description.
 644         (make_cleanup_free_target_description): Remove.
 645
 646 2019-01-02  Tom Tromey  <tom@tromey.com>
 647
 648         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
 649         constructor, destructor.
 650         (linespec_parser): Remove typedef.
 651         (~linespec_parser): Rename from linespec_parser_delete.
 652         (linespec_lex_to_end, linespec_complete_label)
 653         (linespec_complete): Update.
 654         (decode_line_full): Remove cleanups.
 655         (decode_line_1): Update.
 656
 657 2019-01-02  Tom Tromey  <tom@tromey.com>
 658
 659         * python/python-internal.h (inferior_to_inferior_object): Change
 660         return type.
 661         * python/py-exitedevent.c (create_exited_event_object): Update.
 662         * python/py-inferior.c (inferior_to_inferior_object): Return
 663         gdbpy_ref.
 664         (python_new_inferior, python_inferior_deleted)
 665         (thread_to_thread_object, delete_thread_object)
 666         (build_inferior_list, gdbpy_selected_inferior): Update.
 667         * python/py-infthread.c (create_thread_object): Update.  Also fail
 668         if inferior_to_inferior_object fails.
 669
 670 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
 671
 672         * inferior.h (class inferior) <displaced_step_state>: New field.
 673         * infrun.h (struct displaced_step_state): Move here from
 674         infrun.c.  Initialize fields, add constructor.
 675         <inf>: Remove field.
 676         <reset>: New method.
 677         * infrun.c (struct displaced_step_inferior_state): Move to
 678         infrun.h.
 679         (displaced_step_inferior_states): Remove.
 680         (get_displaced_stepping_state): Adust.
 681         (displaced_step_in_progress_any_inferior): Adjust.
 682         (displaced_step_in_progress_thread): Adjust.
 683         (displaced_step_in_progress): Adjust.
 684         (add_displaced_stepping_state): Remove.
 685         (get_displaced_step_closure_by_addr): Adjust.
 686         (remove_displaced_stepping_state): Remove.
 687         (infrun_inferior_exit): Call displaced_step_state.reset.
 688         (use_displaced_stepping): Don't check for NULL.
 689         (displaced_step_prepare_throw): Call
 690         get_displaced_stepping_state.
 691         (displaced_step_fixup): Don't check for NULL.
 692         (prepare_for_detach): Don't check for NULL.
 693
 694 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 695
 696         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
 697          in case of call that did not complete.
 698
 699 2019-01-02  Andrey Utkin  <autkin@undo.io>
 700
 701         * symfile.c (find_separate_debug_file): Fix search of debug files for
 702         remote debuggee.
 703
 704 2019-01-02  Tom Tromey  <tom@tromey.com>
 705
 706         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
 707         indentation.
 708         * python/py-frame.c (frapy_older): Remove cast.
 709         (frapy_newer): Likewise.
 710         * python/py-breakpoint.c (local_setattro): Remove cast.
 711         * python/py-arch.c (archpy_name): Remove local variable.
 712         * python/py-type.c (gdbpy_lookup_type): Remove cast.
 713
 714 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
 715
 716         * unittests/basic_string_view/element_access/char/empty.cc:
 717         Fix year range in copyright header.
 718
 719 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 720
 721         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
 722         Delete.
 723         <operator==>: Update with for removed field.
 724         <hash>: Likewise.
 725         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
 726         <isa_features>: ...this.
 727         <abi_features>: New field.
 728         (riscv_isa_flen): Update comment.
 729         (riscv_abi_xlen): New declaration.
 730         (riscv_abi_flen): New declaration.
 731         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
 732         isa_features.
 733         (riscv_abi_xlen): New function.
 734         (riscv_isa_flen): Update to get answer from isa_features.
 735         (riscv_abi_flen): New function.
 736         (riscv_has_fp_abi): Update to get answer from abi_features.
 737         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
 738         xlen and flen.
 739         (riscv_call_info) <xlen, flen>: Update comment.
 740         (riscv_call_arg_struct): Remove invalid assertions
 741         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
 742         is removed.
 743         (riscv_gdbarch_init): Gather isa features and abi features
 744         separately, ensure both match on the gdbarch when reusing an old
 745         gdbarch.  Relax an error check to allow 32-bit abi float to run on
 746         a target with 64-bit float hardware.
 747
 748 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 749
 750         * source.c (search_command_helper): Stop reverse search
 751         when line 1 has been searched.
 752
 753 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 754
 755         * record-full.c (record_full_base_target::close): Rewrite
 756         record_full_core_buf_list free logic.
 757
 758 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 759
 760         * break-catch-syscall.c (print_one_catch_syscall): xfree
 761         the last text.
 762
 763 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 764
 765         * top.c (print_gdb_version): Update Copyright year in version
 766         message.
 767
 768 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 769
 770         Update copyright year range in all GDB files.
 771
 772 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 773
 774         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
 775
 776 For older changes see ChangeLog-2018.
 777 \f
 778 Local Variables:
 779 mode: change-log
 780 left-margin: 8
 781 fill-column: 74
 782 version-control: never
 783 coding: utf-8
 784 End:
 785