gdb/ChangeLog

   1 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
   4         (lookup_symbol_in_objfile): Change int to block_enum and add a
   5         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
   6
   7 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
   8
   9         * MAINTAINERS (Write After Approval): Add self.
  10
  11 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
  12
  13         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
  14         instruction to the dummy code region.
  15
  16 2019-07-19  Tom Tromey  <tromey@adacore.com>
  17
  18         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
  19         (ARGSUSED, PARAMS, __func__): Remove rules.
  20
  21 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  22
  23         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
  24         * features/arm/arm-with-iwmmxt.c: Remove.
  25         * features/arm/arm-with-iwmmxt.xml: Remove.
  26         * features/arm/arm-with-m-fpa-layout.c: Remove.
  27         * features/arm/arm-with-m-fpa-layout.xml: Remove.
  28         * features/arm/arm-with-m-vfp-d16.c: Remove.
  29         * features/arm/arm-with-m-vfp-d16.xml: Remove.
  30         * features/arm/arm-with-m.c: Remove.
  31         * features/arm/arm-with-m.xml: Remove.
  32         * features/arm/arm-with-neon.c: Remove.
  33         * features/arm/arm-with-neon.xml: Remove.
  34         * features/arm/arm-with-vfpv2.c: Remove.
  35         * features/arm/arm-with-vfpv2.xml: Remove.
  36         * features/arm/arm-with-vfpv3.c: Remove.
  37         * features/arm/arm-with-vfpv3.xml: Remove.
  38
  39 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  40
  41         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
  42
  43 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  44
  45         * arch/aarch32.c (aarch32_create_target_description): Create
  46         target descriptions using features.
  47         * arch/arm.c (arm_create_target_description)
  48         (arm_create_mprofile_target_description): Likewise.
  49         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
  50
  51 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  52
  53         * Makefile.in: Add new files.
  54         * aarch32-tdep.c: New file.
  55         * aarch32-tdep.h: New file.
  56         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  57         Call aarch32_read_description.
  58         * arch/aarch32.c: New file.
  59         * arch/aarch32.h: New file.
  60         * arch/arm.c (arm_create_target_description)
  61         (arm_create_mprofile_target_description): New function.
  62         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
  63         (arm_create_target_description)
  64         (arm_create_mprofile_target_description): New declaration.
  65         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
  66         read_description functions.
  67         * arm-linux-nat.c (arm_linux_nat_target::read_description):
  68         Likewise.
  69         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  70         * arm-tdep.c (tdesc_arm_list): New variable.
  71         (arm_register_g_packet_guesses): Call create description functions.
  72         (arm_read_description) (arm_read_mprofile_description): New
  73         function.
  74         * arm-tdep.h (arm_read_description)
  75         (arm_read_mprofile_description): Add declaration.
  76         * configure.tgt: Add new files.
  77
  78 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
  79
  80         * top.c (new_ui_command): Open specified terminal just once.
  81
  82 2019-07-18  Tom Tromey  <tromey@adacore.com>
  83
  84         * symtab.c (main_name): Constify return type.
  85         * symfile.c (set_initial_language): Update.
  86         * symtab.h (main_name): Constify return type.
  87
  88 2019-07-17  Tom Tromey  <tom@tromey.com>
  89
  90         * tui/tui-winsource.c (tui_update_source_window)
  91         (tui_update_source_window_as_is)
  92         (tui_update_source_windows_with_line): Remove return.
  93         * tui/tui-disasm.c (tui_show_disassem)
  94         (tui_show_disassem_and_update_source): Remove return.
  95         * tui/tui.c (tui_reset): Remove return.
  96         * tui/tui-wingeneral.c
  97         (tui_check_and_display_highlight_if_needed): Remove return.
  98
  99 2019-07-17  Tom Tromey  <tom@tromey.com>
 100
 101         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 102
 103 2019-07-17  Tom Tromey  <tom@tromey.com>
 104
 105         * tui/tui-winsource.h (struct tui_exec_info_window)
 106         (struct tui_source_window_base): Move from tui-data.h.
 107         * tui/tui-winsource.c: Move many method definitions from
 108         elsewhere.  Remove "structuring" comments.
 109         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 110         (tui_source_window_base::refresh_window): Move to
 111         tui-winsource.c.
 112         * tui/tui-win.c (tui_source_window_base::refresh_all)
 113         (tui_source_window_base::update_tab_width)
 114         (tui_source_window_base::set_new_height)
 115         (tui_source_window_base::do_make_visible_with_new_height): Move to
 116         tui-winsource.c.
 117         * tui/tui-source.h: Update.
 118         * tui/tui-source.c (tui_source_window_base::reset): Move to
 119         tui-winsource.c.
 120         * tui/tui-disasm.h: Update.
 121         * tui/tui-data.h (struct tui_exec_info_window): Move to
 122         tui-winsource.h.
 123         (struct tui_source_window_base): Likewise.
 124         * tui/tui-data.c (tui_source_window_base::clear_detail)
 125         (tui_source_window_base, ~tui_source_window_base): Move to
 126         tui-winsource.c.
 127
 128 2019-07-17  Tom Tromey  <tom@tromey.com>
 129
 130         * tui/tui-win.c (tui_resize_all)
 131         (tui_source_window_base::update_tab_width)
 132         (tui_adjust_win_heights): Update.
 133         (tui_win_info::make_invisible_and_set_new_height): Rename from
 134         make_invisible_and_set_new_height.
 135         * tui/tui-data.h (struct tui_win_info)
 136         <make_invisible_and_set_new_height>: New method.
 137
 138 2019-07-17  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui.c: Update.
 141         * tui/tui-source.h (struct tui_source_window): Move from
 142         tui-data.h.
 143         * tui/tui-layout.c: Update.
 144         * tui/tui-disasm.c: Update.
 145         * tui/tui-data.h (struct tui_source_window): Move to
 146         tui-source.h.
 147
 148 2019-07-17  Tom Tromey  <tom@tromey.com>
 149
 150         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 151         tui-data.h.
 152         * tui/tui-data.h (struct tui_disasm_window): Move to
 153         tui-disasm.h.
 154
 155 2019-07-17  Tom Tromey  <tom@tromey.com>
 156
 157         * tui/tui-regs.h (struct tui_data_item_window): Move from
 158         tui-data.h.
 159         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 160         * tui/tui-data.h (struct tui_data_item_window): Move to
 161         tui-regs.h.
 162         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 163
 164 2019-07-17  Tom Tromey  <tom@tromey.com>
 165
 166         * tui/tui.c: Update.
 167         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 168         (tui_cmd_window::max_height): Move to tui-command.c.
 169         * tui/tui-layout.c: Update.
 170         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 171         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 172         tui-command.c.
 173         * tui/tui-command.h (struct tui_cmd_window): Move from
 174         tui-data.h.
 175         * tui/tui-command.c: Remove "structuring" comments.
 176         (tui_cmd_window::clear_detail)
 177         (tui_cmd_window::do_make_visible_with_new_height)
 178         (tui_cmd_window::max_height): Move from elsewhere.
 179
 180 2019-07-17  Tom Tromey  <tom@tromey.com>
 181
 182         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 183         Now static.
 184         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 185         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 186
 187 2019-07-17  Tom Tromey  <tom@tromey.com>
 188
 189         * tui/tui.c: Update.
 190         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 191         tui-regs.c.
 192         * tui/tui-windata.h: Remove file.
 193         * tui/tui-windata.c: Remove file.
 194         * tui/tui-win.c (tui_data_window::set_new_height)
 195         (tui_data_window::do_make_visible_with_new_height): Move to
 196         tui-regs.c.
 197         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 198         * tui/tui-regs.c: Remove "structuring" comments.
 199         (tui_data_window::first_data_item_displayed)
 200         (tui_data_window::delete_data_content_windows)
 201         (tui_data_window::erase_data_content)
 202         (tui_data_window::display_all_data)
 203         (tui_data_window::refresh_all)
 204         (tui_data_window::do_scroll_vertical)
 205         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 206         (tui_data_window::do_make_visible_with_new_height)
 207         (tui_data_window::refresh_window): Move from elsewhere.
 208         (_initialize_tui_regs): Move to end of file.
 209         * tui/tui-layout.c: Update.
 210         * tui/tui-hooks.c: Update.
 211         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 212         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 213         tui-regs.c.
 214         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 215
 216 2019-07-17  Tom Tromey  <tom@tromey.com>
 217
 218         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 219         seen.
 220
 221 2019-07-17  Tom Tromey  <tom@tromey.com>
 222
 223         * tui/tui-win.c (tui_source_window_base::set_new_height)
 224         (tui_source_window_base::do_make_visible_with_new_height): Use
 225         m_has_locator field directly.
 226         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 227         method.
 228         (struct tui_source_window_base) <has_locator>: Likewise.
 229
 230 2019-07-17  Tom Tromey  <tom@tromey.com>
 231
 232         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 233         Don't declare.
 234         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 235         Remove.
 236         * tui/tui-win.c (tui_source_window_base::set_new_height)
 237         (tui_source_window_base::set_new_height)
 238         (make_invisible_and_set_new_height)
 239         (tui_source_window_base::do_make_visible_with_new_height)
 240         (tui_source_window_base::do_make_visible_with_new_height):
 241         Update.
 242         * tui/tui-layout.c (show_source_disasm_command, show_data)
 243         (show_source_or_disasm_and_command): Update.
 244         * tui/tui-layout.c (show_layout): Update.
 245
 246 2019-07-17  Tom Tromey  <tom@tromey.com>
 247
 248         * tui/tui-layout.c (make_data_window): Remove.
 249         (show_data): Unify creation and re-initialization cases.
 250
 251 2019-07-17  Tom Tromey  <tom@tromey.com>
 252
 253         * tui/tui-layout.c (make_source_window, make_disasm_window):
 254         Remove.
 255         (show_data): Unify creation and re-initialization cases.
 256
 257 2019-07-17  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui-layout.c (make_command_window): Remove.
 260         (show_source_disasm_command, show_source_or_disasm_and_command):
 261         Unify creation and re-initialization cases.
 262
 263 2019-07-17  Tom Tromey  <tom@tromey.com>
 264
 265         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 266         creation and re-initialization cases.
 267
 268 2019-07-17  Tom Tromey  <tom@tromey.com>
 269
 270         * tui/tui-regs.c (tui_get_register): Return void.
 271
 272 2019-07-17  Tom Tromey  <tom@tromey.com>
 273
 274         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 275         Simplify.
 276
 277 2019-07-17  Tom Tromey  <tom@tromey.com>
 278
 279         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 280         resetting.
 281
 282 2019-07-17  Tom Tromey  <tom@tromey.com>
 283
 284         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 285         * tui/tui-regs.c (tui_reg_layout): New function.
 286         (tui_show_registers, tui_reg_command): Use it.
 287         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 288         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 289         parameters.
 290         (tui_layout_command): Remove.
 291
 292 2019-07-17  Tom Tromey  <tom@tromey.com>
 293
 294         * tui/tui-layout.h (tui/tui-layout): Return void.
 295         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 296
 297 2019-07-17  Tom Tromey  <tom@tromey.com>
 298
 299         * tui/tui-layout.c (show_source_disasm_command, show_data):
 300         Update.
 301         (reset_locator): Remove.
 302         (show_source_or_disasm_and_command): Update.
 303
 304 2019-07-17  Tom Tromey  <tom@tromey.com>
 305
 306         * tui/tui-source.c (tui_source_window_base::reset): Remove
 307         win_type parameter.
 308         * tui/tui-layout.c (make_command_window, make_source_window)
 309         (make_disasm_window, make_data_window)
 310         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 311         (reset_locator, show_source_or_disasm_and_command): Update.
 312         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 313         win_type parameter.
 314         (struct tui_source_window_base) <reset>: Likewise.
 315
 316 2019-07-17  Tom Tromey  <tom@tromey.com>
 317
 318         * tui/tui-layout.c (show_source_disasm_command): Use
 319         reset_locator.
 320         (reset_locator): New function.
 321         (init_and_make_win): Remove.
 322         (show_source_or_disasm_and_command): Use reset_locator.
 323
 324 2019-07-17  Tom Tromey  <tom@tromey.com>
 325
 326         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 327         condition.
 328         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 329         Remove condition.
 330         * tui/tui-source.c (tui_source_window_base::reset): New method.
 331         * tui/tui-layout.c (make_command_window): Don't call
 332         init_and_make_win.
 333         (make_source_window, make_disasm_window): Don't call
 334         make_source_or_disasm_window.
 335         (make_data_window): Don't call init_and_make_win.  Change calling
 336         convention.
 337         (show_source_disasm_command, show_data): Simplify.
 338         (make_source_or_disasm_window): Remove.
 339         (show_source_or_disasm_and_command): Simplify.
 340         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 341         (struct tui_source_window_base) <reset>: Likewise.
 342         <execution_info>: Remove initializer.
 343         * tui/tui-data.c (tui_source_window_base): Initialize
 344         execution_info.
 345
 346 2019-07-17  Tom Tromey  <tom@tromey.com>
 347
 348         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 349         variable.
 350
 351 2019-07-17  Tom Tromey  <tom@tromey.com>
 352
 353         * tui/tui.c (tui_rl_other_window): Update.
 354         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 355         superclass method first.  Always iterate over regs_content.
 356         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 357         method.
 358         * tui/tui-win.c (tui_set_focus_command): Update.
 359
 360 2019-07-17  Tom Tromey  <tom@tromey.com>
 361
 362         * tui/tui-win.c (tui_set_focus_command): Rename from
 363         tui_set_focus.  Call tui_enable.
 364         (tui_set_focus_command): Remove.
 365
 366 2019-07-17  Tom Tromey  <tom@tromey.com>
 367
 368         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 369         refresh_window.
 370         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 371         touchwin.
 372         (tui_data_window::refresh_window): Call refresh_window on data
 373         items.  Always call superclass refresh_window.
 374         (tui_win_info::refresh): Remove.
 375         (tui_source_window_base::refresh_window): Update.
 376         (tui_refresh_all): Update.
 377         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 378         refresh_window.
 379         (show_source_or_disasm_and_command): Likewise.
 380         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 381         (struct tui_source_window_base) <refresh>: Likewise.
 382
 383 2019-07-17  Tom Tromey  <tom@tromey.com>
 384
 385         * tui/tui-winsource.c (tui_clear_source_content)
 386         (tui_show_source_content): Update.
 387         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 388         whether content is empty.
 389         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 390         Remove.
 391
 392 2019-07-17  Tom Tromey  <tom@tromey.com>
 393
 394         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 395         window's contents.
 396         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 397         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 398
 399 2019-07-17  Tom Tromey  <tom@tromey.com>
 400
 401         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 402         (struct tui_data_item_window): Update.
 403
 404 2019-07-17  Tom Tromey  <tom@tromey.com>
 405
 406         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 407         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 408         defines.
 409
 410 2019-07-17  Tom Tromey  <tom@tromey.com>
 411
 412         * tui/tui-winsource.h (tui_erase_source_content)
 413         (tui_clear_source_content): Remove "display_prompt" parameter.
 414         * tui/tui-winsource.c (tui_update_source_window_as_is)
 415         (tui_update_source_windows_with_addr): Update.
 416         (tui_clear_source_content): Remove "display_prompt" parameter.
 417         (tui_erase_source_content): Likewise.  Simplify.
 418         (tui_show_source_content): Update.
 419         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 420         * tui/tui-stack.c (tui_show_frame_info): Update.
 421         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 422         Remove defines.
 423
 424 2019-07-17  Tom Tromey  <tom@tromey.com>
 425
 426         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 427         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 428         parameter.
 429         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 430         parameter.
 431
 432 2019-07-17  Tom Tromey  <tom@tromey.com>
 433
 434         * tui/tui-winsource.c (tui_clear_source_content)
 435         (tui_show_source_content, tui_show_exec_info_content)
 436         (tui_clear_exec_info_content): Update.
 437         * tui/tui-stack.c (tui_show_locator_content): Update.
 438         (tui_show_frame_info): Update.
 439         * tui/tui-source.h (tui_source_window): Don't declare.
 440         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 441         from tui_source_is_displayed.
 442         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 443         Remove field.
 444         (struct tui_source_window_base) <content_in_use>: New field.  Now
 445         bool.
 446         (struct tui_source_window) <showing_source_p>: New method.
 447         (TUI_SRC_WIN): Change cast.
 448         * tui/tui-data.c (tui_initialize_static_data): Update.
 449
 450 2019-07-17  Tom Tromey  <tom@tromey.com>
 451
 452         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 453         location_matches_p.
 454         * tui/tui-source.c (tui_source_window::location_matches_p): New
 455         method.
 456         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 457         method.
 458         * tui/tui-data.h (struct tui_source_window_base)
 459         <location_matches_p>: New method.
 460         (struct tui_source_window, struct tui_disasm_window)
 461         <location_matches_p>: Likewise.
 462
 463 2019-07-17  Tom Tromey  <tom@tromey.com>
 464
 465         * tui/tui-win.c (tui_set_win_height_command): Rename from
 466         tui_set_win_height.
 467         (tui_set_win_height_command): Remove.
 468
 469 2019-07-17  Tom Tromey  <tom@tromey.com>
 470
 471         * tui/tui-source.c (tui_source_window): New constructor.  Add
 472         observer.
 473         (~tui_source_window): New destructor.
 474         (tui_source_window::style_changed): New method.
 475         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 476         (tui_attach_detach_observers): Update.
 477         * tui/tui-data.h (struct tui_source_window): Make constructor not
 478         inline.  Add destructor.
 479         (struct tui_source_window) <style_changed>: New method.
 480         <m_observable>: New member.
 481
 482 2019-07-17  Tom Tromey  <tom@tromey.com>
 483
 484         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 485         * tui/tui-win.c (tui_resize_all): Fix typo.
 486
 487 2019-07-17  Tom Tromey  <tom@tromey.com>
 488
 489         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 490         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 491         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 492         * tui/tui-win.c (window_name_completer): Use foreach.
 493         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 494         (update_tab_width): Likewise.
 495         * tui/tui-layout.c (show_layout): Update.
 496         * tui/tui-data.h (class tui_window_iterator): New.
 497         (struct all_tui_windows): New.
 498         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 499
 500 2019-07-17  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 503         parameter.  Don't reference globals.
 504         (tui_reg_command): Update.
 505
 506 2019-07-17  Tom Tromey  <tom@tromey.com>
 507
 508         * tui/tui-regs.c (tui_show_registers): Simplify.
 509
 510 2019-07-17  Tom Tromey  <tom@tromey.com>
 511
 512         * tui/tui-regs.c (tui_show_registers): Update.
 513         (tui_show_register_group): Add win_info parameter.
 514
 515 2019-07-17  Tom Tromey  <tom@tromey.com>
 516
 517         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 518         Rename from tui_display_reg_element_at_line.
 519         (tui_data_window::display_registers_from_line): Update.
 520         * tui/tui-data.h (struct tui_data_window)
 521         <display_reg_element_at_line>: New method.
 522
 523 2019-07-17  Tom Tromey  <tom@tromey.com>
 524
 525         * tui/tui-regs.h (tui_display_registers_from)
 526         (tui_display_registers_from_line): Don't declare.
 527         * tui/tui-windata.c (tui_data_window::display_all_data)
 528         (tui_data_window::refresh_all)
 529         (tui_data_window::do_scroll_vertical): Update.
 530         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 531         from tui_display_registers_from.
 532         (tui_display_reg_element_at_line): Update.
 533         (tui_data_window::display_registers_from_line): Rename from
 534         tui_display_registers_from_line.
 535         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 536         display_registers_from_line>: New methods.
 537
 538 2019-07-17  Tom Tromey  <tom@tromey.com>
 539
 540         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 541         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 542         from tui_erase_data_content.
 543         (tui_data_window::display_all_data)
 544         (tui_data_window::refresh_all)
 545         (tui_data_window::do_scroll_vertical): Update.
 546         * tui/tui-regs.c (tui_show_registers): Update.
 547         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 548         New method.
 549
 550 2019-07-17  Tom Tromey  <tom@tromey.com>
 551
 552         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 553         declare.
 554         * tui/tui-windata.c
 555         (tui_data_window::delete_data_content_windows): Rename from
 556         tui_delete_data_content_windows.
 557         (tui_data_window::display_all_data)
 558         (tui_data_window::do_scroll_vertical): Update.
 559         * tui/tui-data.h (struct tui_data_window)
 560         <delete_data_content_windows>: New method.
 561
 562 2019-07-17  Tom Tromey  <tom@tromey.com>
 563
 564         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 565         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 566
 567 2019-07-17  Tom Tromey  <tom@tromey.com>
 568
 569         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 570         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 571         from tui_display_all_data.
 572         * tui/tui-win.c
 573         (tui_data_window::do_make_visible_with_new_height): Update.
 574         * tui/tui-regs.c (tui_show_registers): Update.
 575         * tui/tui-layout.c (tui_set_layout): Update.
 576         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 577         method.
 578
 579 2019-07-17  Tom Tromey  <tom@tromey.com>
 580
 581         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 582         * tui/tui-windata.c (tui_display_data_from): Remove.
 583         (tui_data_window::refresh_all): Update.
 584
 585 2019-07-17  Tom Tromey  <tom@tromey.com>
 586
 587         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 588         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 589         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 590         tui_display_registers_from_line.
 591         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 592         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 593         "force_display" parameter.
 594
 595 2019-07-17  Tom Tromey  <tom@tromey.com>
 596
 597         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 598         declare.
 599         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 600         Rename from tui_first_reg_element_no_inline.
 601         (tui_display_reg_element_at_line)
 602         (tui_display_registers_from_line): Update.
 603         * tui/tui-data.h (struct tui_data_window)
 604         <first_reg_element_no_inline>: New method.
 605
 606 2019-07-17  Tom Tromey  <tom@tromey.com>
 607
 608         * tui/tui-windata.c (tui_display_data_from)
 609         (tui_data_window::do_scroll_vertical): Update.
 610         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 611         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 612         Rename from tui_line_from_reg_element_no.
 613         (tui_display_registers_from_line): Update.
 614         * tui/tui-data.h (struct tui_data_window)
 615         <line_from_reg_element_no>: New method.
 616
 617 2019-07-17  Tom Tromey  <tom@tromey.com>
 618
 619         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 620         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 621         tui_last_regs_line_no.
 622         (tui_display_reg_element_at_line)
 623         (tui_display_registers_from_line): Update.
 624         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 625         method.
 626
 627 2019-07-17  Tom Tromey  <tom@tromey.com>
 628
 629         PR tui/24722:
 630         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 631         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 632         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 633         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 634         (tui_update_breakpoint_info): Likewise.
 635         * tui/tui-hooks.c (tui_event_create_breakpoint)
 636         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 637         Update.
 638
 639 2019-07-17  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 642
 643 2019-07-17  Tom Tromey  <tom@tromey.com>
 644
 645         * tui/tui-winsource.c (tui_update_source_window_as_is)
 646         (tui_update_source_windows_with_addr): Update.
 647         * tui/tui-source.h (tui_set_source_content)
 648         (tui_show_symtab_source): Add "win_info" parameter.
 649         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 650         parameter.
 651         (tui_show_symtab_source): Likewise.
 652
 653 2019-07-17  Tom Tromey  <tom@tromey.com>
 654
 655         * tui/tui-wingeneral.c
 656         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 657
 658 2019-07-17  Tom Tromey  <tom@tromey.com>
 659
 660         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 661         (struct tui_cmd_window) <can_scroll>: New method.
 662         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 663         method.
 664
 665 2019-07-17  Tom Tromey  <tromey@adacore.com>
 666
 667         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 668         do_field_signed>: Rename.  Change type of "value".
 669         * ui-out.c (ui_out::field_signed): Rename from field_int.
 670         Change type of "value".
 671         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 672         type of "value".
 673         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 674         do_field_int.  Change type of "value".
 675         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 676         do_field_int.  Change type of "value".
 677         * tracepoint.c (trace_status_mi, tfind_1)
 678         (print_one_static_tracepoint_marker): Update.
 679         * thread.c (print_thread_info_1, print_selected_thread_frame):
 680         Update.
 681         * stack.c (print_frame, print_frame_info): Update.
 682         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 683         Update.
 684         * source.c (print_source_lines_base): Update.
 685         * skip.c (info_skip_command): Update.
 686         * record-btrace.c (btrace_ui_out_decode_error)
 687         (btrace_call_history_src_line): Update.
 688         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 689         Update.
 690         * progspace.c (print_program_space): Update.
 691         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 692         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 693         do_field_int.  Change type of "value".
 694         * mi/mi-out.c (mi_ui_out::do_table_begin)
 695         (mi_ui_out::do_table_header): Update.
 696         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 697         type of "value".
 698         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 699         (mi_cmd_data_list_changed_registers, output_register)
 700         (mi_cmd_data_read_memory, mi_load_progress)
 701         (mi_cmd_trace_frame_collected): Update.
 702         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 703         Update.
 704         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 705         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 706         (mi_cmd_var_list_children, varobj_update_one): Update.
 707         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 708         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 709         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 710         * inferior.c (print_inferior): Update.
 711         * gdb_bfd.c (print_one_bfd): Update.
 712         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 713         Update.
 714         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 715         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 716         do_field_int.  Change type of "value".
 717         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 718         do_field_int.  Change type of "value".
 719         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 720         (print_one_breakpoint_location, print_it_catch_fork)
 721         (print_one_catch_fork, print_it_catch_vfork)
 722         (print_one_catch_vfork, print_it_catch_solib)
 723         (print_it_catch_exec, print_it_ranged_breakpoint)
 724         (print_mention_watchpoint, print_mention_masked_watchpoint)
 725         (bkpt_print_it, update_static_tracepoint): Update.
 726         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 727         * break-catch-syscall.c (print_it_catch_syscall): Update.
 728         * ada-tasks.c (print_ada_task_info): Update.
 729         * ada-lang.c (print_it_exception, print_mention_exception):
 730         Update.
 731
 732 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 733
 734         PR breakpoints/24541
 735         * gdbarch.c: Regenerate.
 736         * gdbarch.h: Regenerate.
 737         * gdbarch.sh: Adjust return type and parameter types for
 738         'stap_adjust_register'.
 739         (i386_stap_adjust_register): Adjust signature and return new
 740         register name.
 741         * stap-probe.c (stap_parse_register_operand): Adjust use of
 742         'gdbarch_stap_adjust_register'.
 743
 744 2019-07-17  Tom Tromey  <tromey@adacore.com>
 745
 746         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 747         declare VEC.
 748         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 749         std::vector.
 750         (struct s390_process_info): Add initializers.
 751         (s390_add_process): Use new.
 752         (s390_linux_nat_target::low_forget_process): Use delete.
 753         (s390_linux_nat_target::low_new_fork)
 754         (s390_linux_nat_target::stopped_by_watchpoint)
 755         (s390_linux_nat_target::low_prepare_to_resume)
 756         (s390_linux_nat_target::insert_watchpoint)
 757         (s390_linux_nat_target::insert_hw_breakpoint)
 758         (s390_linux_nat_target::remove_watchpoint)
 759         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 760
 761 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 762
 763         * aarch64-fbsd-nat.c: Include regcache.h.
 764         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 765         argument.
 766         (aarch64_fbsd_nat_target::fetch_registers)
 767         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 768         variable.
 769         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 770
 771 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 772
 773         * fbsd-nat.c: Include gdbarch.h.
 774
 775 2019-07-15  Tom Tromey  <tromey@adacore.com>
 776
 777         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 778
 779 2019-07-15  Tom Tromey  <tromey@adacore.com>
 780
 781         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 782         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 783         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 784         * cli-out.c (cli_ui_out::do_field_int): New method.
 785         * ui-out.c (ui_out::field_unsigned): New method.
 786         * symfile.c (generic_load): Use field_unsigned.
 787         (print_transfer_performance): Likewise.
 788         * record-btrace.c (ui_out_field_uint): Remove.
 789         (btrace_call_history_insn_range, btrace_call_history): Use
 790         field_unsigned.
 791         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 792         field_unsigned.
 793         * ui-out.h (class ui_out) <field_unsigned>: New method.
 794         <do_field_unsigned>: Likewise.
 795
 796 2019-07-15  Tom Tromey  <tromey@adacore.com>
 797
 798         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 799         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 800         * target.c (flash_erase_command): Use field_string.
 801         * infrun.c (print_signal_received_reason): Use field_string.
 802         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 803         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 804         field_string.
 805         * ada-tasks.c (print_ada_task_info): Use field_string.
 806
 807 2019-07-15  Tom Tromey  <tromey@adacore.com>
 808
 809         * target.c (flash_erase_command): Use field_core_addr.
 810         * symfile.c (generic_load): Use field_core_addr.
 811         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 812         Use field_core_addr.
 813         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 814         field_core_addr.
 815
 816 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 817
 818         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 819         value if its desired type is smaller than a CORE_ADDR and signed.
 820
 821 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 822
 823         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 824         of changes to field names, and use new is_reference field to
 825         decide if a property is a reference or not.
 826         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 827         field.
 828         (struct dwarf2_property_baton): Update header comment, rename
 829         'referenced_type' to 'property_type' and update comments.
 830         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 831         default property type, store in property baton, update to take
 832         accound of renamed field.
 833         (read_func_scope): Update call to attr_to_dynamic_prop.
 834         (read_array_type): Likewise.
 835         (dwarf2_per_cu_addr_sized_int_type): New function.
 836         (read_subrange_index_type): Move type finding code to
 837         dwarf2_per_cu_addr_sized_int_type.
 838         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 839         (dwarf2_per_cu_addr_type): New function.
 840         (set_die_type): Update calls to attr_to_dynamic_prop.
 841
 842 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 843
 844         * dwarf2read.c (read_subrange_index_type): New function.
 845         (read_subrange_type): Move code into new function and call it.
 846         * gdbtypes.c (create_range_type): Add some asserts.
 847
 848 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 849
 850         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 851         update return statements.
 852         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 853         declaration, and update comment to match.
 854         * gdbtypes.c (resolve_dynamic_array): Update call to
 855         dwarf2_evaluate_property to match new return type.
 856
 857 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 858
 859         * valarith.c (value_subscripted_rvalue): Change lowerbound
 860         parameter type from int to LONGEST.
 861         * value.h (value_subscripted_rvalue): Likewise in declaration.
 862
 863 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 864
 865         * cli/cli-utils.c (info_print_command_completer): New function.
 866         * cli/cli-utils.h: Add 'completer.h' include, and forward
 867         declaration for 'struct cmd_list_element'.
 868         (info_print_command_completer): Declare.
 869         * stack.c (_initialize_stack): Add completer for 'info locals' and
 870         'info args'.
 871         * symtab.c (_initialize_symtab): Add completer for 'info
 872         variables' and 'info functions'.
 873         * NEWS: Mention completion for additional info commands.
 874
 875 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 876
 877         * cli/cli-utils.c (extract_info_print_args): Delete.
 878         (extract_arg_maybe_quoted): Delete.
 879         (info_print_options_defs): New variable.
 880         (make_info_print_options_def_group): New function.
 881         (extract_info_print_options): Define new function.
 882         * cli/cli-utils.h (extract_info_print_args): Delete.
 883         (struct info_print_options): New structure.
 884         (extract_info_print_options): Declare new function.
 885         * stack.c (info_locals_command): Update to use new
 886         extract_info_print_options, also add a header comment.
 887         (info_args_command): Likewise.
 888         * symtab.c (info_variables_command): Likewise.
 889         (info_functions_command): Likewise.
 890
 891 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 892
 893         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 894         to extract string arguments.
 895         * common/common-utils.c (extract_string_maybe_quoted): New function.
 896         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 897
 898 2019-07-11  Tom Tromey  <tromey@adacore.com>
 899
 900         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 901         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 902         * top.h (gdbinit): Don't declare.
 903         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 904         into...
 905         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 906         * top.c (gdb_init): Don't call init_cli_cmds.
 907         (gdbinit): Remove.
 908         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 909
 910 2019-07-11  Tom Tromey  <tromey@adacore.com>
 911
 912         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 913         after it has been moved.
 914
 915 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 916
 917         * valops.c (value_must_coerce_to_target): Change return type to
 918         bool.
 919         * value.h (value_must_coerce_to_target): Likewise.
 920
 921 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 922
 923         * breakpoint.c (is_hardware_watchpoint): Remove
 924         forward-declaration.
 925         (is_masked_watchpoint): Change return type to bool.
 926         (is_tracepoint): Likewise.
 927         (is_breakpoint): Likewise.
 928         (is_hardware_watchpoint): Likewise.
 929         (is_watchpoint): Likewise.
 930         (is_no_memory_software_watchpoint): Likewise.
 931         (is_catchpoint): Likewise.
 932         (breakpoint_1): Make FILTER parameter's return type bool.
 933         is_masked_watchpoint): Change return type to bool.
 934         (save_breakpoints): Make FILTER parameter's return type bool.
 935         * breakpoint.h (is_breakpoint): Change return type to bool.
 936         (is_watchpoint): Likewise.
 937         (is_catchpoint): Likewise.
 938         (is_tracepoint): Likewise.
 939
 940 2019-07-10  Tom Tromey  <tom@tromey.com>
 941
 942         * defs.h: Don't include gdbarch.h.
 943         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 944         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 945         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 946         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 947         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 948         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 949         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 950         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 951         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 952         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 953         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 954         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 955         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 956         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 957         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 958         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 959         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 960         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 961         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 962         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 963         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 964         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 965         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 966         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 967         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 968         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 969         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 970
 971 2019-07-10  Tom Tromey  <tromey@adacore.com>
 972
 973         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 974         * breakpoint.c (init_ada_exception_breakpoint): Register as
 975         bp_catchpoint.
 976         (print_one_breakpoint_location, print_one_breakpoint): Use
 977         is_ada_exception_catchpoint.
 978         * ada-lang.c (class ada_catchpoint_location): Pass
 979         bp_loc_software_breakpoint to bp_location constructor.
 980         (is_ada_exception_catchpoint): New function.
 981
 982 2019-07-10  Tom Tromey  <tromey@adacore.com>
 983
 984         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 985         VEC.
 986         (struct arm_exidx_entry): New method operator<.
 987         (struct arm_exidx_data) <section_maps>: Change type.
 988         (arm_exidx_data_free): Remove.
 989         (arm_exidx_data_key): Change type.  Move lower.
 990         (arm_exidx_new_objfile): Update.
 991         (arm_compare_exidx_entries): Remove.
 992         (arm_find_exidx_entry, _initialize_arm_tdep)
 993
 994 2019-07-10  Tom Tromey  <tromey@adacore.com>
 995
 996         * solib-spu.c (ocl_program_data_key): Change type.
 997         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 998         Update.
 999
1000 2019-07-10  Tom Tromey  <tromey@adacore.com>
1001
1002         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1003         (struct solib_aix_inferior_data) <library_list>: Change type.
1004         (solib_aix_inferior_data_handle): Change type.
1005         (get_solib_aix_inferior_data): Update.
1006         (solib_aix_free_library_list): Remove.
1007         (library_list_start_library): Update.
1008         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1009         return type.
1010         (solib_aix_get_library_list)
1011         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1012         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1013
1014 2019-07-10  Tom Tromey  <tromey@adacore.com>
1015
1016         * solib-dsbt.c (struct dsbt_info): Add initializers.
1017         (solib_dsbt_pspace_data): Change type.
1018         (dsbt_pspace_data_cleanup): Remove.
1019         (get_dsbt_info, _initialize_dsbt_solib): Update.
1020
1021 2019-07-10  Tom Tromey  <tromey@adacore.com>
1022
1023         * spu-tdep.c (spu_overlay_data): Change type.
1024         (spu_get_overlay_table, spu_overlay_new_objfile)
1025         (_initialize_spu_tdep): Update.
1026
1027 2019-07-10  Tom Tromey  <tromey@adacore.com>
1028
1029         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1030         destructor.
1031         (dbx_objfile_data_key): Change type and declare later.
1032         (DBX_SYMFILE_INFO): Rewrite.
1033         * dbxread.c (dbx_objfile_data_key): Change type.
1034         (dbx_symfile_init): Update.
1035         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1036         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1037         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1038
1039 2019-07-10  Tom Tromey  <tromey@adacore.com>
1040
1041         * jit.c (jit_program_space_key): Change type.  Move lower.
1042         (get_jit_program_space_data): Update.
1043         (jit_program_space_data_cleanup): Remove.
1044         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1045         Update.
1046         (struct jit_program_space_data): Add initializers.
1047
1048 2019-07-10  Tom Tromey  <tromey@adacore.com>
1049
1050         * solib-darwin.c (struct darwin_info): Add initializers.
1051         (solib_darwin_pspace_data): Change type.
1052         (darwin_pspace_data_cleanup): Remove.
1053         (get_darwin_info, _initialize_darwin_solib): Update.
1054
1055 2019-07-10  Tom Tromey  <tromey@adacore.com>
1056
1057         * remote-sim.c (struct sim_inferior_data): Add initializers,
1058         constructor, and destructor.
1059         (sim_inferior_data_key): Change type.  Move lower.
1060         (check_for_duplicate_sim_descriptor): Update.
1061         (get_sim_inferior_data): Use new.  Update.
1062         (~sim_inferior_data_cleanup): Rename from
1063         sim_inferior_data_cleanup.  Simplify.
1064         (gdbsim_close_inferior, simulator_command)
1065         (sim_command_completer, _initialize_remote_sim): Update.
1066         (next_pid, INITIAL_PID): Move earlier.
1067
1068 2019-07-10  Tom Tromey  <tromey@adacore.com>
1069
1070         * python/python-internal.h (create_thread_object): Return
1071         gdbpy_ref.
1072         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1073         * python/py-inferior.c (struct threadlist_entry): Add
1074         constructor.
1075         <thread_obj>: Now a gdbpy_ref.
1076         (thread_to_thread_object): Update.
1077         (add_thread_object): Use new.
1078         (delete_thread_object): Use delete.
1079         (infpy_threads): Update.
1080         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1081         GIL.
1082
1083 2019-07-10  Tom Tromey  <tromey@adacore.com>
1084
1085         * valops.c (value_cast): Specialize error message for Ada.
1086
1087 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1088
1089         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1090
1091 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1092
1093         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1094         bpstat_should_step): Return bool, adjust comments.
1095         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1096         bpstat_should_step): Likewise.
1097
1098 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1099
1100         * features/Makefile: Use feature target descriptions for Arm.
1101         * features/arm/arm-core.c: Generate new file.
1102         * features/arm/arm-fpa.c: Likewise.
1103         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1104         * features/arm/arm-m-profile.c: Likewise.
1105         * features/arm/arm-vfpv2.c: Likewise.
1106         * features/arm/arm-vfpv3.c: Likewise.
1107         * features/arm/xscale-iwmmxt.c: Likewise.
1108         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1109
1110 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1111
1112         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1113         ptrace earlier.
1114
1115 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1116
1117         * features/aarch64-pauth.c: Regenerate.
1118
1119 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1120
1121         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1122         bool.
1123         (bpstat_what): Use false instead of 0.
1124
1125 2019-07-09  Pedro Alves  <palves@redhat.com>
1126
1127         * break-catch-throw.c (is_exception_catchpoint): New.
1128         * breakpoint.c (print_one_breakpoint_location): New parameter
1129         'raw_loc'.  Handle it.  Use
1130         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1131         looking at the breakpoint's type.
1132         (print_one_breakpoint): If handling "maint info breakpoints", also
1133         print locations of exception catchpoints.
1134         * breakpoint.h (is_exception_catchpoint): Declare.
1135
1136 2019-07-09  Pedro Alves  <palves@redhat.com>
1137
1138         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1139         "addr" field.
1140         (allocate_location_exception_catchpoint): New.
1141         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1142         (initialize_throw_catchpoint_ops): Install
1143         allocate_location_exception_catchpoint as allocate_location
1144         method.
1145         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1146         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1147         bp_loc_other.
1148         (breakpoint_address_is_meaningful): Delete.
1149         (bl_address_is_meaningful): New.
1150         (breakpoint_locations_match): Adjust comment.
1151         (bp_location_from_bp_type): New, factored out of...
1152         (bp_location::bp_location(breakpoint *)): ... this.
1153         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1154         factored out of...
1155         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1156         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1157         breakpoint_address_is_meaningful.
1158         (bp_locations_compare): Adjust comment.
1159         (update_global_location_list): Use bl_address_is_meaningful
1160         instead of breakpoint_address_is_meaningful.
1161         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1162         explicit.
1163         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1164         * python/py-breakpoint.c (bppy_get_location): No longer check
1165         whether location is null.
1166
1167 2019-07-09  Pedro Alves  <palves@redhat.com>
1168
1169         PR c++/15468
1170         * breakpoint.c (print_one_breakpoint_location): Remove
1171         single-location assert.
1172
1173 2019-07-09  Tom Tromey  <tom@tromey.com>
1174
1175         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1176         * configure: Rebuild.
1177         * configure.ac: Change common to gdbsupport.
1178         * gdbsupport: Rename from common.
1179         * acinclude.m4: Change common to gdbsupport.
1180         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1181         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1182         gdbsupport.
1183         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1184         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1185         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1186         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1187         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1188         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1189         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1190         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1191         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1192         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1193         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1194         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1195         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1196         coff-pe-read.c, command.h, compile/compile-c-support.c,
1197         compile/compile-c.h, compile/compile-cplus-symbols.c,
1198         compile/compile-cplus-types.c, compile/compile-cplus.h,
1199         compile/compile-loc2c.c, compile/compile.c, completer.c,
1200         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1201         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1202         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1203         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1204         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1205         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1206         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1207         features/aarch64-core.c, features/aarch64-fpu.c,
1208         features/aarch64-pauth.c, features/aarch64-sve.c,
1209         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1210         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1211         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1212         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1213         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1214         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1215         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1216         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1217         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1218         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1219         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1220         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1221         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1222         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1223         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1224         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1225         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1226         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1227         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1228         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1229         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1230         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1231         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1232         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1233         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1234         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1235         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1236         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1237         minsyms.c, mips-linux-tdep.c, namespace.h,
1238         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1239         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1240         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1241         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1242         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1243         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1244         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1245         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1246         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1247         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1248         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1249         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1250         procfs.c, producer.c, progspace.h, psymtab.h,
1251         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1252         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1253         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1254         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1255         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1256         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1257         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1258         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1259         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1260         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1261         target-memory.c, target.c, target.h, target/waitstatus.c,
1262         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1263         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1264         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1265         unittests/array-view-selftests.c,
1266         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1267         unittests/common-utils-selftests.c,
1268         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1269         unittests/format_pieces-selftests.c,
1270         unittests/function-view-selftests.c,
1271         unittests/lookup_name_info-selftests.c,
1272         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1273         unittests/mkdir-recursive-selftests.c,
1274         unittests/observable-selftests.c,
1275         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1276         unittests/parse-connection-spec-selftests.c,
1277         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1278         unittests/scoped_fd-selftests.c,
1279         unittests/scoped_mmap-selftests.c,
1280         unittests/scoped_restore-selftests.c,
1281         unittests/string_view-selftests.c, unittests/style-selftests.c,
1282         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1283         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1284         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1285         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1286         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1287         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1288
1289 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1290
1291         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1292         bool value.
1293         (decode_digits_ordinary): Set explicit_line field in sal.
1294         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1295         symtab_and_line that was set on an explicit line number in
1296         assembler code.  Do always update the recorded symtab and line if
1297         we do skip the prologue.
1298
1299 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1300
1301         * breakpoint.c (set_breakpoint_location_function): Remove
1302         explicit_loc parameter.
1303         (momentary_breakpoint_from_master): Update call to
1304         set_breakpoint_location_function.
1305         (add_location_to_breakpoint): Likewise.
1306
1307 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1308
1309         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1310         required features based on default bfd type when no specific bfd
1311         is present.
1312
1313 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1314
1315         * NEWS: Mention that GDB printf and eval commands can now print
1316         C-style and Ada-style convenience var strings without
1317         calling the inferior.
1318         * printcmd.c (printf_c_string): Locally print GDB internal var
1319         instead of transiting via the inferior.
1320         (printf_wide_c_string): Likewise.
1321
1322 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1323
1324         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1325
1326 2019-07-04  Tom Tromey  <tom@tromey.com>
1327
1328         PR tui/24724:
1329         * tui/tui-winsource.c (tui_clear_source_content): Update.
1330         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1331         (tui_update_breakpoint_info): Update.
1332         (tui_set_exec_info_content): Update.
1333         * tui/tui-source.c (tui_set_source_content_nil): Update.
1334         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1335         has_break.
1336         * tui/tui-data.h (enum tui_bp_flag): New.
1337         (tui_bp_flags): New enum flags type.
1338         (struct tui_source_element) <break_mode>: Change type.  Rename
1339         from has_break.
1340         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1341         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1342         constants.
1343         * tui/tui-winsource.h: Fix comment.
1344
1345 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1346
1347         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1348         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1349         (store_fpregs_to_thread)
1350         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1351         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1352         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1353         (IWMMXT_REGS_SIZE): Add define.
1354         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1355         (fetch_vfp_regs, store_vfp_regs)
1356         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1357         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1358
1359 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1360
1361         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1362         defines.
1363         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1364         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1365         (ARM_INT_REGISTER_SIZE): ...to this.
1366         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1367         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1368         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1369         (arm_linux_collect_gregset, supply_nwfpe_register)
1370         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1371         defines.
1372         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1373         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1374         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1375         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1376         (arm_return_in_memory, arm_store_return_value)
1377         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1378         (arm_record_ld_st_multiple): Likewise.
1379         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1380         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1381
1382 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1383
1384         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1385         AARCH64_DISPLACED_MODIFIED_INSNS.
1386         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1387         (aarch64_displaced_step_copy_insn): Likewise.
1388         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1389         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1390         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1391         ARM_DISPLACED_MODIFIED_INSNS.
1392         * arm-tdep.c (arm_gdbarch_init): Likewise.
1393         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1394         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1395         (struct arm_displaced_step_closure): Use
1396         ARM_DISPLACED_MODIFIED_INSNS.
1397
1398 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1399
1400         * features/Makefile: Remove unused xml files.
1401         * features/aarch64.xml: Remove.
1402         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1403         * features/i386/amd64-avx-avx512.xml: Remove.
1404         * features/i386/amd64-avx-linux.xml: Remove.
1405         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1406         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1407         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1408         * features/i386/amd64-avx-mpx.xml: Remove.
1409         * features/i386/amd64-avx.xml: Remove.
1410         * features/i386/amd64-linux.xml: Remove.
1411         * features/i386/amd64-mpx-linux.xml: Remove.
1412         * features/i386/amd64-mpx.xml: Remove.
1413         * features/i386/amd64.xml: Remove.
1414         * features/i386/i386-avx-avx512-linux.xml: Remove.
1415         * features/i386/i386-avx-avx512.xml: Remove.
1416         * features/i386/i386-avx-linux.xml: Remove.
1417         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1418         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1419         * features/i386/i386-avx-mpx-linux.xml: Remove.
1420         * features/i386/i386-avx-mpx.xml: Remove.
1421         * features/i386/i386-avx.xml: Remove.
1422         * features/i386/i386-linux.xml: Remove.
1423         * features/i386/i386-mmx-linux.xml: Remove.
1424         * features/i386/i386-mmx.xml: Remove.
1425         * features/i386/i386-mpx-linux.xml: Remove.
1426         * features/i386/i386-mpx.xml: Remove.
1427         * features/i386/i386.xml: Remove.
1428         * features/i386/x32-avx-avx512-linux.xml: Remove.
1429         * features/i386/x32-avx-linux.xml: Remove.
1430         * features/i386/x32-linux.xml: Remove.
1431
1432 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1433
1434         * regformats/aarch64.dat: Remove.
1435         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1436         * regformats/i386/amd64-avx-linux.dat: Remove.
1437         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1438         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1439         * regformats/i386/amd64-linux.dat: Remove.
1440         * regformats/i386/amd64-mpx-linux.dat: Remove.
1441         * regformats/i386/amd64.dat: Remove.
1442         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1443         * regformats/i386/i386-avx-linux.dat: Remove.
1444         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1445         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1446         * regformats/i386/i386-linux.dat: Remove.
1447         * regformats/i386/i386-mmx-linux.dat: Remove.
1448         * regformats/i386/i386-mpx-linux.dat: Remove.
1449         * regformats/i386/i386.dat: Remove.
1450         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1451         * regformats/i386/x32-avx-linux.dat: Remove.
1452         * regformats/i386/x32-linux.dat: Remove.
1453
1454 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1455
1456         * aarch64-tdep.c: Remove xml self tests.
1457         * amd64-linux-tdep.c: Likewise.
1458         * amd64-tdep.c: Likewise.
1459         * i386-linux-tdep.c: Likewise.
1460         * i386-tdep.c: Likewise.
1461
1462 2019-07-03  Pedro Alves  <palves@redhat.com>
1463
1464         PR cli/24732
1465         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1466         (pipe_cmd_option_defs): New.
1467         (make_pipe_cmd_options_def_group): New.
1468         (pipe_command): Use gdb::option::process_options.
1469         (pipe_command_completer): New function.
1470         (_initialize_cli_cmds): Install completer for "pipe" command.
1471
1472 2019-07-03  Pedro Alves  <palves@redhat.com>
1473
1474         * cli/cli-option.c (union option_value) <string>: New field.
1475         (struct option_def_and_value): Add ctor, move ctor, dtor and
1476         use DISABLE_COPY_AND_ASSIGN.
1477         (option_def_and_value::clear_value): New.
1478         (parse_option, save_option_value_in_ctx, get_val_type_str)
1479         (add_setshow_cmds_for_options): Handle var_string.
1480         * cli-option.h (union option_def::var_address) <string>: New
1481         field.
1482         (struct string_option_def): New.
1483         * maint-test-options.c (struct test_options_opts): Add default
1484         ctor and use DISABLE_COPY_AND_ASSIGN.
1485         <string_opt>: New field.
1486         (test_options_opts::~test_options_opts): New.
1487         (test_options_opts::dump): Also dump "-string".
1488         (test_options_option_defs): Install "string.
1489
1490 2019-07-03  Pedro Alves  <palves@redhat.com>
1491
1492         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1493         option_value with a null enumeration.
1494         (complete_options): Save the option values in the context.
1495         (save_option_value_in_ctx): New, factored out from ...
1496         (process_options): ... here.
1497         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1498         of the function.
1499         * maint-test-options.c (test_options_opts::dump): New, factored
1500         out from ...
1501         (maintenance_test_options_command_mode): ... here.
1502         (maintenance_test_options_command_completion_result): Delete.
1503         (maintenance_test_options_command_completion_text): Update
1504         comment.
1505         (maintenance_show_test_options_completion_result): Change
1506         prototype.  Just print
1507         maintenance_test_options_command_completion_text.
1508         (save_completion_result): New.
1509         (maintenance_test_options_completer_mode): Pass options context to
1510         complete_options, and then save a dump.
1511         (_initialize_maint_test_options): Use add_cmd to install "maint
1512         show test-options-completion-result".
1513
1514 2019-07-03  Pedro Alves  <palves@redhat.com>
1515
1516         * NEWS (New commands): Mention "with" and "maint with".
1517         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1518         (with_command, with_command_completer): New.
1519         (pipe_command): Adjust to new repeat_previous
1520         interface.
1521         (_initialize_cli_cmds): Install the "with" command and its "w"
1522         alias.
1523         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1524         declarations.
1525         * cli/cli-setshow.c (parse_cli_var_uinteger)
1526         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1527         argument strings for all var_types.
1528         (get_setshow_command_value_string): New, factored out from ...
1529         (do_show_command): ... this.
1530         * cli/cli-setshow.h: Include <string>.
1531         (get_setshow_command_value_string): Declare.
1532         * command.h (repeat_previous): Now returns const char *.  Adjust
1533         comment.
1534         * maint.c: Include "cli/cli-cmds.h".
1535         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1536         (_initialize_maint_cmds): Register the "maintenance with" command.
1537         * top.c (repeat_previous): Move bits from pipe_command here:
1538         Return the saved command line, if any; error out if there's no
1539         command to relaunch.
1540
1541 2019-07-03  Pedro Alves  <palves@redhat.com>
1542
1543         * NEWS (New commands): Mention "maint set/show test-settings"
1544         instead of "maint test-settings".
1545         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1546         (maintenance_test_settings_set_list): Rename to ...
1547         (maintenance_set_test_settings_list): ... this.
1548         (maintenance_test_settings_show_list): Rename to  ...
1549         (maintenance_show_test_settings_list): ... this.
1550         (maintenance_test_settings_cmd): Delete.
1551         (maintenance_test_settings_set_cmd): ...
1552         (maintenance_set_test_settings_cmd): ... this.
1553         (maintenance_test_settings_show_cmd): ...
1554         (maintenance_show_test_settings_cmd): ... this.
1555         (maintenance_test_settings_show_value_cmd):
1556         (maintenance_show_test_settings_value_cmd): ... this.
1557         (_initialize_maint_test_settings): No longer install the "maint
1558         test-settings" prefix command.  Rename "maint test-settings set"
1559         to "maint set test-settings", and "maint test-settings show" to
1560         "maint show test-settings".  Adjust all subcommands.
1561
1562 2019-07-03  Pedro Alves  <palves@redhat.com>
1563
1564         * maint-test-settings.c: Fix file's intro comment.  Replace all
1565         references to "test-options" with references to "test-settings",
1566         in comments.
1567
1568 2019-07-03  Pedro Alves  <palves@redhat.com>
1569
1570         * maint-test-settings.c (maintenance_test_settings_xxx)
1571         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1572         New.
1573         (maintenance_test_settings_enums): Use them.
1574         (maintenance_test_settings_enum): Default to
1575         maintenance_test_settings_xxx.
1576         (_initialize_maint_test_settings): Initialize
1577         MAINTENANCE_TEST_SETTINGS_FILENAME.
1578
1579 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1580
1581         * breakpoint.h (remove_breakpoints_inf): Change return type to
1582         void, move function documentation here.
1583         * breakpoint.c (remove_breakpoints_inf): Change return type to
1584         void, move function documentation to header.
1585
1586 2019-07-02  Pedro Alves  <palves@redhat.com>
1587
1588         * NEWS (Completion improvements): Mention "info threads".
1589         * thread.c (struct info_threads_opts, info_threads_option_defs)
1590         (make_info_threads_options_def_group): New.
1591         (info_threads_command): Use gdb::option::process_options.
1592         (info_threads_command_completer): New.
1593         (_initialize_thread): Use gdb::option::build_help to build the
1594         help text for "info threads".
1595
1596 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1597
1598         * defs.h (generic_load): Move from here...
1599         * symfile.h (generic_load): ... to here.  Rename name parameter
1600         to args.
1601         * symfile.c (generic_load): Add comment.
1602
1603 2019-07-01  Tom Tromey  <tromey@adacore.com>
1604
1605         * dwarf2read.c
1606         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1607         declaration of without_params.  Fix formatting.
1608
1609 2019-07-01  Tom Tromey  <tromey@adacore.com>
1610
1611         * ada-exp.y (find_primitive_type): Update.
1612         * ada-lang.h (ada_lookup_symbol): Update.
1613         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1614         parameter.
1615         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1616
1617 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1618
1619         PR breakpoints/24541
1620         * gdbarch.c: Regenerate.
1621         * gdbarch.h: Regenerate.
1622         * gdbarch.sh: Add 'stap_adjust_register'.
1623         * i386-tdep.c: Include '<unordered_set>'.
1624         (i386_stap_adjust_register): New function.
1625         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1626         * stap-probe.c (stap_parse_register_operand): Call
1627         'gdbarch_stap_adjust_register'.
1628
1629 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1630
1631         PR python/24742
1632         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1633         * python/python.c (do_start_initialization): Use 'xmalloc'
1634         instead of 'PyMem_Malloc'.
1635
1636 2019-06-28  Tom Tromey  <tromey@adacore.com>
1637
1638         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1639         for Ada.
1640
1641 2019-06-27  Tom Tromey  <tromey@adacore.com>
1642
1643         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1644         objfile_key.
1645         (arm_find_mapping_symbol, arm_record_special_symbol)
1646         (_initialize_arm_tdep): Update.
1647         (arm_objfile_data_free): Remove.
1648
1649 2019-06-27  Tom Tromey  <tromey@adacore.com>
1650
1651         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1652         to cp_print_static_field.
1653
1654 2019-06-26  Tom Tromey  <tromey@adacore.com>
1655
1656         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1657         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1658         declare.
1659
1660 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1661
1662         * features/aarch64-core.c (create_feature_aarch64_core):
1663         Regenerate.
1664         * features/aarch64-core.xml: Add cpsr flags.
1665
1666 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1667
1668         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1669         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1670
1671 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1672
1673         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1674         field.
1675         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1676         use.
1677         (arm_record_special_symbol): Don't insert new symbol in sorted
1678         position, push it at the end.
1679
1680 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1681
1682         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1683         (arm_mapping_symbol_s): Remove.
1684         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1685         (arm_mapping_symbol_vec): New typedef.
1686         (struct arm_per_objfile): Add constructor.
1687         <section_maps>: Change type to
1688         std::unique_ptr<arm_mapping_symbol_vec[]>.
1689         (arm_compare_mapping_symbols): Remove.
1690         (arm_find_mapping_symbol): Adjust to section_maps type change.
1691         (arm_objfile_data_free): Call delete on arm_per_objfile.
1692         (arm_record_special_symbol): Adjust to section_maps type change.
1693         Allocate arm_per_objfile with new.
1694
1695 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1696
1697         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1698         with the command prefix.
1699
1700 2019-06-25  Tom Tromey  <tom@tromey.com>
1701
1702         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1703         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1704
1705 2019-06-25  Tom Tromey  <tom@tromey.com>
1706
1707         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1708         type.
1709         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1710         protected.
1711
1712 2019-06-25  Tom Tromey  <tom@tromey.com>
1713
1714         * tui/tui-winsource.c
1715         (tui_source_window_base::set_is_exec_point_at): Add check against
1716         LOA_ADDRESS.
1717
1718 2019-06-25  Tom Tromey  <tom@tromey.com>
1719
1720         * tui/tui-source.c (tui_set_source_content): Don't check before
1721         xfree.
1722         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1723
1724 2019-06-25  Tom Tromey  <tom@tromey.com>
1725
1726         * tui/tui-winsource.h (tui_update_source_window_as_is)
1727         (tui_alloc_source_buffer, tui_line_is_displayed)
1728         (tui_addr_is_displayed): Change type of win_info.
1729         * tui/tui-winsource.c (tui_update_source_window_as_is)
1730         (tui_clear_source_content, tui_show_source_line)
1731         (tui_show_source_content, tui_source_window_base::refill)
1732         (tui_source_window_base::set_is_exec_point_at)
1733         (tui_source_window_base::set_is_exec_point_at)
1734         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1735         (tui_alloc_source_buffer, tui_line_is_displayed)
1736         (tui_addr_is_displayed): Change type of win_info.  Update.
1737         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1738         (tui_source_window_base::do_make_visible_with_new_height):
1739         Update.
1740         * tui/tui-source.c (tui_set_source_content)
1741         (tui_set_source_content_nil)
1742         (tui_source_window::do_scroll_vertical): Update.
1743         * tui/tui-layout.c (show_layout): Update.
1744         * tui/tui-disasm.c (tui_set_disassem_content)
1745         (tui_disasm_window::do_scroll_vertical): Update.
1746         * tui/tui-data.h (tui_win_content): Remove.
1747         (struct tui_gen_win_info) <content, content_size>: Remove.
1748         (struct tui_source_element): Add initializers and destructor.
1749         (union tui_which_element, struct tui_win_element): Remove.
1750         (struct tui_source_window_base) <content>: New field.
1751         (struct tui_data_window): Remove destructor.
1752         (tui_alloc_content, tui_free_win_content)
1753         (tui_free_all_source_wins_content): Don't declare.
1754         * tui/tui-data.c (tui_initialize_static_data): Update.
1755         (init_content_element, tui_alloc_content): Remove.
1756         (~tui_gen_win_info): Update.
1757         (~tui_data_window, tui_free_all_source_wins_content)
1758         (tui_free_win_content, free_content, free_content_elements):
1759         Remove.
1760
1761 2019-06-25  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-winsource.h (tui_clear_source_content)
1764         (tui_erase_source_content, tui_show_source_content): Change type
1765         of win_info.
1766         * tui/tui-winsource.c (tui_clear_source_content)
1767         (tui_erase_source_content, tui_show_source_content): Change type
1768         of win_info.
1769         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1770         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1771         win_info.
1772         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1773         win_info.
1774         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1775
1776 2019-06-25  Tom Tromey  <tom@tromey.com>
1777
1778         * tui/tui-winsource.c (tui_clear_source_content)
1779         (tui_source_window_base::set_is_exec_point_at): Update.
1780         * tui/tui-source.c (tui_set_source_content_nil): Update.
1781         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1782         a bool.
1783         * tui/tui-data.c (init_content_element): Update.
1784
1785 2019-06-25  Tom Tromey  <tom@tromey.com>
1786
1787         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1788         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1789         * tui/tui-layout.c (init_and_make_win): Update.
1790         * tui/tui.h (enum tui_win_type): Update.
1791         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1792         tui_win_is_auxillary.
1793         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1794         tui_win_is_auxillary.
1795
1796 2019-06-25  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1799         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1800         (tui_delete_data_content_windows, tui_display_all_data)
1801         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1802         Update.
1803         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1804         * tui/tui-regs.c (tui_last_regs_line_no)
1805         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1806         (tui_show_registers): Update.
1807         (tui_show_register_group): Return void.  Update.
1808         (tui_display_registers_from, tui_display_reg_element_at_line)
1809         (tui_display_registers_from_line, tui_check_register_values):
1810         Update.
1811         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1812         member.
1813         (struct tui_data_window) <regs_content>: Now a std::vector.
1814         <regs_content_count>: Remove.
1815         (tui_add_content_elements, tui_free_data_content): Don't declare.
1816         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1817         (init_content_element): Remove DATA_WIN case.  Add assert.
1818         (tui_add_content_elements): Remove.
1819         (tui_data_window): Update.
1820         (tui_free_data_content): Remove.
1821         (free_content_elements): Remove DATA_WIN case.
1822
1823 2019-06-25  Tom Tromey  <tom@tromey.com>
1824
1825         * tui/tui-data.c (tui_data_item_window): Update.
1826         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1827         * tui/tui-windata.c (tui_display_all_data)
1828         (tui_display_data_from_line): Update.
1829         (tui_check_data_values): Remove.
1830         * tui/tui-regs.c (tui_show_register_group)
1831         (tui_display_reg_element_at_line): Update.
1832         * tui/tui-hooks.c (tui_register_changed)
1833         (tui_refresh_frame_and_register_information): Call
1834         tui_check_register_values.
1835         * tui/tui-data.h (struct tui_data_window) <data_content,
1836         data_content_count, data_type>: Remove.
1837         (enum tui_data_type): Remove.
1838
1839         * tui/tui-data.c (tui_data_window::clear_detail)
1840         (~tui_data_window): Update.
1841
1842 2019-06-25  Tom Tromey  <tom@tromey.com>
1843
1844         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1845         declare.
1846         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1847         Rename from tui_first_data_item_displayed.  Update.
1848         (tui_data_window::refresh_all)
1849         (tui_data_window::do_scroll_vertical): Update.
1850         * tui/tui-data.h (struct tui_data_window)
1851         <first_data_item_displayed>: Declare new method.
1852
1853 2019-06-25  Tom Tromey  <tom@tromey.com>
1854
1855         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1856         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1857         contents...
1858         (tui_initialize_static_data): ...here.
1859
1860 2019-06-25  Tom Tromey  <tom@tromey.com>
1861
1862         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1863         (tui_display_registers_from, tui_check_register_values): Update.
1864         (tui_display_register): Remove win_info parameter; update.
1865         (tui_get_register): Change type of parameters.
1866         * tui/tui-data.h (struct tui_data_element): Remove.
1867         (union tui_which_element) <data>: Remove.
1868         <data_window>: Change type.
1869         (struct tui_data_item_window): New.
1870         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1871         case.  Add assert.
1872         (~tui_data_item_window): New destructor.
1873         (free_content_elements): Remove DATA_ITEM_WIN case.
1874
1875 2019-06-25  Tom Tromey  <tom@tromey.com>
1876
1877         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1878         Remove.
1879
1880 2019-06-25  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-data.h (struct tui_command_element): Remove.
1883         (union tui_which_element) <command>: Remove.
1884         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1885         assert.
1886         (free_content_elements): Remove CMD_WIN case.
1887
1888 2019-06-25  Tom Tromey  <tom@tromey.com>
1889
1890         * tui/tui-layout.c (tui_set_layout): Update.
1891         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1892         * tui/tui-data.c (layout_def): Update.
1893
1894 2019-06-25  Tom Tromey  <tom@tromey.com>
1895
1896         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1897         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1898         (tui_source_window_base::set_new_height): Update.
1899         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1900         Update.
1901         (tui_set_locator_fullname, tui_set_locator_info)
1902         (tui_show_frame_info): Update.
1903         * tui/tui-source.c (tui_set_source_content)
1904         (tui_source_is_displayed): Update.
1905         * tui/tui-layout.c (show_source_disasm_command, show_data)
1906         (show_source_or_disasm_and_command): Update.
1907         * tui/tui-disasm.c (tui_set_disassem_content)
1908         (tui_get_begin_asm_address): Update.
1909         * tui/tui-data.h (struct tui_locator_element): Remove.
1910         (union tui_which_element) <locator>: Remove.
1911         (struct tui_locator_window): New.
1912         (tui_locator_win_info_ptr): Change return type.
1913         * tui/tui-data.c (_locator): Change type.
1914         (tui_locator_win_info_ptr): Change return type.
1915         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1916         (tui_alloc_content): Add assert.
1917
1918 2019-06-25  Tom Tromey  <tom@tromey.com>
1919
1920         * tui/tui-winsource.c
1921         (tui_exec_info_window::maybe_allocate_content): New method.
1922         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1923         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1924         (make_source_or_disasm_window): Add cast.
1925         * tui/tui-data.h (union tui_which_element) <simple_string>:
1926         Remove.
1927         (struct tui_source_info): New.
1928         (struct tui_source_window_base) <execution_info>: Change type.
1929         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1930         case, and add assert.
1931         (tui_alloc_content): Add assert.
1932
1933 2019-06-25  Tom Tromey  <tom@tromey.com>
1934
1935         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1936         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1937         * tui/tui-data.c (tui_alloc_win_info): Remove.
1938
1939 2019-06-25  Tom Tromey  <tom@tromey.com>
1940
1941         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1942         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1943         can_highlight.
1944
1945 2019-06-25  Tom Tromey  <tom@tromey.com>
1946
1947         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1948         make_visible_with_new_height method.
1949         (tui_win_info::make_visible_with_new_height): New method.
1950         (tui_source_window_base::do_make_visible_with_new_height)
1951         (tui_data_window::do_make_visible_with_new_height)
1952         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1953         (make_visible_with_new_height): Remove.
1954         (tui_resize_all, tui_adjust_win_heights): Use
1955         make_visible_with_new_height method.
1956         * tui/tui-data.h (struct tui_win_info)
1957         <do_make_visible_with_new_height, make_visible_with_new_height>:
1958         New methods.
1959         (struct tui_source_window_base, struct tui_data_window)
1960         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1961         methods.
1962
1963 2019-06-25  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1966         method.
1967         (update_tab_width): Call update_tab_width method.
1968         * tui/tui-data.h (struct tui_win_info)
1969         (struct tui_source_window_base) <update_tab_width>: New methods.
1970
1971 2019-06-25  Tom Tromey  <tom@tromey.com>
1972
1973         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1974         parameter.
1975         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1976         parameter.
1977         (tui_gen_win_info::make_visible): Update.
1978         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1979         parameter.
1980         * tui/tui-data.h (enum tui_box): New enum.
1981         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1982
1983 2019-06-25  Tom Tromey  <tom@tromey.com>
1984
1985         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1986         init_and_make_win for EXEC_INFO_WIN.
1987         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1988         longer inline.
1989         (struct tui_win_info) <~tui_win_info>: Inline.
1990         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1991         Don't declare.
1992         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1993         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1994         Remove.
1995         (tui_initialize_static_data): Update.
1996         (~tui_gen_win_info): Handle more cleanup here.
1997         (~tui_source_window_base): Delete "execution_info".
1998         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1999
2000 2019-06-25  Tom Tromey  <tom@tromey.com>
2001
2002         * tui/tui-layout.c (make_command_window): Don't set
2003         can_highlight.
2004         (show_source_disasm_command): Call the reset method.
2005         (show_data): Don't set can_highlight.  Call the reset method.
2006         (tui_gen_win_info::reset): Rename from init_gen_win_info
2007         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2008         (show_source_or_disasm_and_command): Call the reset method.
2009         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2010         (struct tui_cmd_window): Set can_highlight.
2011
2012 2019-06-25  Tom Tromey  <tom@tromey.com>
2013
2014         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2015         from make_visible.
2016         (tui_make_visible, tui_make_invisible): Rewrite.
2017         (tui_win_info::make_visible): Remove.
2018         (tui_source_window_base::make_visible): Update.
2019         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2020         method.  Moved from...
2021         (struct tui_win_info) <make_visible>: ...here.
2022
2023 2019-06-25  Tom Tromey  <tom@tromey.com>
2024
2025         * tui/tui-winsource.c
2026         (tui_source_window_base::do_scroll_horizontal): Remove direction
2027         parameter.
2028         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2029         direction parameter.
2030         * tui/tui-win.c (tui_win_info::forward_scroll)
2031         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2032         (tui_win_info::right_scroll): Update.
2033         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2034         direction parameter.
2035         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2036         direction parameter.
2037         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2038         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2039         Remove direction parameter.
2040         (struct tui_source_window_base, struct tui_source_window)
2041         (struct tui_disasm_window, struct tui_data_window)
2042         (struct tui_cmd_window): Update.
2043
2044 2019-06-25  Tom Tromey  <tom@tromey.com>
2045
2046         * tui/tui-winsource.h (tui_set_exec_info_content)
2047         (tui_show_exec_info_content, tui_erase_exec_info_content)
2048         (tui_clear_exec_info_content, tui_update_exec_info): Change
2049         argument to tui_source_window_base.
2050         * tui/tui-winsource.c (tui_set_exec_info_content)
2051         (tui_show_exec_info_content, tui_erase_exec_info_content)
2052         (tui_clear_exec_info_content, tui_update_exec_info): Change
2053         argument to tui_source_window_base.
2054
2055 2019-06-25  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2058         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2059
2060 2019-06-25  Tom Tromey  <tom@tromey.com>
2061
2062         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2063         check.
2064
2065 2019-06-25  Tom Tromey  <tom@tromey.com>
2066
2067         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2068         type to void.
2069         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2070         type to void.
2071         * tui/tui-source.c (tui_set_source_content): Update.
2072         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2073
2074 2019-06-25  Tom Tromey  <tom@tromey.com>
2075
2076         * tui/tui-win.c (window_name_completer, tui_set_focus)
2077         (tui_all_windows_info): Use name method.
2078         * tui/tui-data.h (struct tui_gen_win_info)
2079         (struct tui_source_window, struct tui_disasm_window)
2080         (struct tui_data_window, struct tui_cmd_window) <name>: New
2081         method.
2082         (tui_win_name): Don't declare.
2083         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2084         (tui_win_name): Remove.
2085
2086 2019-06-25  Tom Tromey  <tom@tromey.com>
2087
2088         * tui/tui-winsource.h (tui_update_source_window)
2089         (tui_update_source_window_as_is): Change parameter type.
2090         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2091         to be a tui_source_window_base.
2092         (tui_update_source_window_as_is): Likewise.
2093         * tui/tui-win.c (make_visible_with_new_height): Update.
2094
2095 2019-06-25  Tom Tromey  <tom@tromey.com>
2096
2097         * tui/tui-winsource.c (tui_erase_source_content)
2098         (tui_show_source_content, tui_show_exec_info_content)
2099         (tui_erase_exec_info_content): Use refresh_window method.
2100         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2101         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2102         from tui_refresh_win.
2103         (tui_data_window::refresh_window): New method.
2104         (tui_win_info::refresh, tui_source_window_base::refresh)
2105         (tui_refresh_all): Use refresh_window method.
2106         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2107         method.
2108         * tui/tui-regs.c (tui_display_register): Call refresh_window
2109         method.
2110         * tui/tui-layout.c (show_source_disasm_command)
2111         (show_source_or_disasm_and_command): Call refresh_window method.
2112         * tui/tui-data.h (struct tui_gen_win_info)
2113         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2114         New method.
2115
2116 2019-06-25  Tom Tromey  <tom@tromey.com>
2117
2118         * tui/tui.c (tui_rl_other_window, tui_enable)
2119         (tui_is_window_visible, tui_get_command_dimension): Update.
2120         * tui/tui-winsource.c (tui_update_source_window_as_is)
2121         (tui_clear_source_content, tui_erase_source_content)
2122         (tui_show_source_line, tui_source_window_base::refill)
2123         (tui_source_window_base::do_scroll_horizontal)
2124         (tui_source_window_base::set_is_exec_point_at)
2125         (tui_update_breakpoint_info, tui_set_exec_info_content)
2126         (tui_alloc_source_buffer, tui_line_is_displayed)
2127         (tui_addr_is_displayed): Update.
2128         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2129         (tui_check_and_display_highlight_if_needed)
2130         (tui_win_info::make_visible, tui_win_info::refresh)
2131         (tui_refresh_all): Update.
2132         * tui/tui-windata.c (tui_first_data_item_displayed)
2133         (tui_delete_data_content_windows, tui_erase_data_content)
2134         (tui_display_all_data, tui_data_window::refresh_all)
2135         (tui_check_data_values): Update.
2136         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2137         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2138         (tui_win_info::backward_scroll, tui_refresh_all_win)
2139         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2140         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2141         (tui_source_window_base::set_new_height)
2142         (tui_data_window::set_new_height)
2143         (make_invisible_and_set_new_height)
2144         (make_visible_with_new_height, new_height_ok)
2145         (parse_scrolling_args): Update.
2146         * tui/tui-stack.c (tui_show_frame_info): Update.
2147         * tui/tui-source.c (tui_set_source_content)
2148         (tui_set_source_content_nil, tui_source_is_displayed)
2149         (tui_source_window::do_scroll_vertical): Update.
2150         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2151         (tui_display_registers_from, tui_display_reg_element_at_line)
2152         (tui_check_register_values, tui_reg_command): Update.
2153         * tui/tui-layout.c (tui_default_win_height)
2154         (show_source_disasm_command, show_data, init_and_make_win)
2155         (show_source_or_disasm_and_command): Update.
2156         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2157         (tui_redisplay_readline, tui_mld_flush)
2158         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2159         (tui_getc): Update.
2160         * tui/tui-disasm.c (tui_set_disassem_content)
2161         (tui_disasm_window::do_scroll_vertical): Update.
2162         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2163         Now virtual.
2164         (struct tui_win_info): Derive from tui_gen_win_info.
2165         <~tui_win_info>: Mark as override.
2166         <generic>: Remove member.
2167         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2168         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2169         (~tui_data_window, ~tui_win_info)
2170         (tui_free_all_source_wins_content): Update.
2171         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2172
2173 2019-06-25  Tom Tromey  <tom@tromey.com>
2174
2175         * tui/tui-layout.c (init_and_make_win): Use new.
2176         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2177         destructor, initializers.
2178         (tui_alloc_generic_win_info): Don't declare.
2179         * tui/tui-data.c (_locator): Add argument to constructor.
2180         (source_win, disasm_win): New globals.
2181         (exec_info): Remove.
2182         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2183         Update.
2184         (tui_alloc_generic_win_info): Remove.
2185         (init_content_element): Use new.
2186         (tui_win_info::tui_win_info): Update.
2187         (free_content_elements) <case DATA_WIN>: Use delete.
2188
2189 2019-06-25  Tom Tromey  <tom@tromey.com>
2190
2191         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2192         * tui/tui-windata.c (tui_first_data_item_displayed)
2193         (tui_delete_data_content_windows): Update.
2194         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2195         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2196         (tui_display_registers_from, tui_check_register_values): Update.
2197         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2198         pointer.
2199         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2200         window.
2201         (tui_free_data_content): Update.
2202         (free_content_elements) <case DATA_WIN>: Free the window.
2203
2204 2019-06-25  Tom Tromey  <tom@tromey.com>
2205
2206         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2207         Update.
2208         * tui/tui-layout.c (make_command_window)
2209         (show_source_disasm_command, show_data, init_and_make_win)
2210         (show_source_or_disasm_and_command): Update.
2211         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2212         method.
2213         <can_highight, is_highlighted>: Now bool.
2214         (tui_set_win_highlight): Don't declare.
2215         * tui/tui-data.c (tui_set_win_highlight): Remove.
2216
2217 2019-06-25  Tom Tromey  <tom@tromey.com>
2218
2219         * tui/tui-wingeneral.c (make_visible): Remove check of window
2220         type.
2221
2222 2019-06-25  Tom Tromey  <tom@tromey.com>
2223
2224         * tui/tui-win.c (tui_win_info::max_height)
2225         (tui_cmd_window::max_height): New methods.
2226         (new_height_ok): Call max_height.
2227         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2228         <max_height>: New method.
2229
2230 2019-06-25  Tom Tromey  <tom@tromey.com>
2231
2232         * tui/tui-win.c (tui_source_window_base::set_new_height)
2233         (tui_data_window::set_new_height): New methods.
2234         (make_invisible_and_set_new_height): Call set_new_height method.
2235         * tui/tui-data.h (struct tui_win_info)
2236         (struct tui_source_window_base, struct tui_data_window)
2237         <set_new_height>: New method.
2238
2239 2019-06-25  Tom Tromey  <tom@tromey.com>
2240
2241         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2242         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2243         tui_refresh_data_win.
2244         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2245         method.
2246         (tui_refresh_all_win): Call the refresh_all method.
2247         (tui_set_focus): Likewise.
2248         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2249         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2250         Likewise.
2251
2252 2019-06-25  Tom Tromey  <tom@tromey.com>
2253
2254         * tui/tui-winsource.h (tui_refill_source_window)
2255         (tui_set_is_exec_point_at): Don't declare.
2256         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2257         (tui_source_window_base::refill): Rename from
2258         tui_refill_source_window.
2259         (tui_source_window_base::do_scroll_horizontal): Update.
2260         (tui_source_window_base::set_is_exec_point_at): Rename from
2261         tui_set_is_exec_point_at.
2262         (tui_update_all_breakpoint_info): Update.
2263         * tui/tui-stack.c (tui_show_frame_info): Update.
2264         * tui/tui-layout.c (show_data): Add cast.
2265         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2266         * tui/tui-data.h (struct tui_source_window_base) <refill,
2267         set_is_exec_point_at>: New methods.
2268         (tui_source_windows, tui_add_to_source_windows): Update types.
2269         (tui_add_to_source_windows): Remove redundant declaration.
2270         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2271         (tui_source_windows): Change return type.
2272         (tui_clear_source_windows_detail): Update.
2273         (tui_add_to_source_windows): Change type of parameter.
2274         (tui_free_all_source_wins_content): Update.
2275
2276 2019-06-25  Tom Tromey  <tom@tromey.com>
2277
2278         * tui/tui-wingeneral.c (tui_win_info::refresh)
2279         (tui_source_window_base::refresh): New methods.
2280         (tui_refresh_all): Call the refresh method.
2281         * tui/tui-data.h (struct tui_win_info)
2282         (struct tui_source_window_base) <refresh>: New method.
2283
2284 2019-06-25  Tom Tromey  <tom@tromey.com>
2285
2286         * tui/tui.h (tui_is_window_visible): Return bool.
2287         * tui/tui.c (tui_is_window_visible): Return bool.
2288         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2289         (tui_make_visible, tui_make_invisible)
2290         (tui_win_info::make_visible)
2291         (tui_source_window_base::make_visible, make_all_visible)
2292         (tui_make_all_visible, tui_make_all_invisible): Update.
2293         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2294         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2295         bool.
2296         (struct tui_win_info, struct tui_source_window_base)
2297         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2298         * tui/tui-data.c (tui_init_generic_part): Update.
2299
2300 2019-06-25  Tom Tromey  <tom@tromey.com>
2301
2302         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2303         (tui_source_window_base::make_visible): New methods.
2304         (make_all_visible): Make method call.
2305         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2306         (struct tui_source_window_base, struct tui_cmd_window): Override
2307         make_visible.
2308         (tui_win_is_source_type): Don't declare.
2309         * tui/tui-data.c (tui_win_is_source_type): Remove.
2310
2311 2019-06-25  Tom Tromey  <tom@tromey.com>
2312
2313         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2314         NULL check.
2315
2316 2019-06-25  Tom Tromey  <tom@tromey.com>
2317
2318         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2319         Inline constructor.  Add initializers for members.
2320         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2321         constructors; now inline in class.
2322
2323 2019-06-25  Tom Tromey  <tom@tromey.com>
2324
2325         * tui/tui-regs.c (tui_show_registers): Update.
2326         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2327         bool.
2328         * tui/tui-data.c (tui_data_window::clear_detail)
2329         (tui_data_window): Update.
2330
2331 2019-06-25  Tom Tromey  <tom@tromey.com>
2332
2333         * tui/tui-windata.c (tui_display_all_data)
2334         (tui_display_data_from_line, tui_display_data_from)
2335         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2336         Update.
2337         * tui/tui-regs.c (tui_last_regs_line_no)
2338         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2339         (tui_show_registers, tui_show_register_group)
2340         (tui_display_registers_from, tui_display_reg_element_at_line)
2341         (tui_display_registers_from_line, tui_check_register_values)
2342         (tui_reg_next, tui_reg_prev): Update.
2343         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2344         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2345         tui_data_window.
2346         (struct tui_win_info) <detail>: Remove.  Add new fields from
2347         tui_data_info.
2348         (TUI_DATA_WIN): Add cast.
2349         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2350         (~tui_data_window): Simplify.
2351
2352 2019-06-25  Tom Tromey  <tom@tromey.com>
2353
2354         * tui/tui-layout.c (show_source_disasm_command)
2355         (show_source_or_disasm_and_command): Update.
2356         * tui/tui-io.c (update_cmdwin_start_line)
2357         (tui_redisplay_readline): Update.
2358         * tui/tui-data.h (struct tui_command_info): Remove.
2359         (struct tui_win_info) <detail>: Remove command_info member.
2360         (struct tui_data_window) <start_line>: New member, from
2361         tui_command_info.
2362         (TUI_CMD_WIN): Add casts.
2363
2364 2019-06-25  Tom Tromey  <tom@tromey.com>
2365
2366         * tui/tui-winsource.c (tui_update_source_window)
2367         (tui_refill_source_window)
2368         (tui_source_window_base::do_scroll_horizontal)
2369         (tui_update_breakpoint_info, tui_set_exec_info_content)
2370         (tui_show_exec_info_content, tui_erase_exec_info_content)
2371         (tui_clear_exec_info_content): Update.
2372         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2373         Update.
2374         * tui/tui-win.c (make_invisible_and_set_new_height)
2375         (make_visible_with_new_height): Update.
2376         * tui/tui-source.c (tui_set_source_content)
2377         (tui_show_symtab_source): Update.
2378         * tui/tui-layout.c (extract_display_start_addr)
2379         (show_source_disasm_command, show_data)
2380         (make_source_or_disasm_window)
2381         (show_source_or_disasm_and_command): Update.
2382         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2383         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2384         "gdbarch".
2385         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2386         to tui_source_window_base.
2387         (struct tui_win_info) <detail>: Remove source_info member.
2388         (struct tui_source_window_base) <has_locator>: Inline.
2389         Move contents from tui_source_info; rename has_locator member to
2390         m_has_locator.
2391         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2392         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2393         header file.
2394         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2395         Simplify.
2396         (tui_free_all_source_wins_content): Cast to
2397         tui_source_window_base.
2398
2399 2019-06-25  Tom Tromey  <tom@tromey.com>
2400
2401         * tui/tui-win.c (make_invisible_and_set_new_height)
2402         (make_visible_with_new_height): Call has_locator method.
2403         * tui/tui-layout.c (show_source_disasm_command, show_data)
2404         (show_source_or_disasm_and_command): Update for bool change.
2405         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2406         (tui_win_info) <has_locator>: New method.
2407         (struct tui_source_window_base) <has_locator>: New method.
2408         (tui_win_has_locator): Don't declare.
2409         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2410         from tui_win_has_locator.
2411         (tui_source_window_base): Use false, not FALSE.
2412
2413 2019-06-25  Tom Tromey  <tom@tromey.com>
2414
2415         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2416         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2417         clear_detail method directly.
2418         (tui_clear_win_detail): Remove.
2419
2420 2019-06-25  Tom Tromey  <tom@tromey.com>
2421
2422         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2423         "this", not TUI_DISASM_WIN.
2424
2425 2019-06-25  Tom Tromey  <tom@tromey.com>
2426
2427         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2428         declare.
2429         * tui/tui-winsource.c
2430         (tui_source_window_base::do_scroll_horizontal): Rename from
2431         tui_horizontal_source_scroll.
2432         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2433         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2434         from tui_vertical_data_scroll.
2435         * tui/tui-win.h (tui_scroll): Don't declare.
2436         * tui/tui-win.c (tui_win_info::forward_scroll)
2437         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2438         (tui_win_info::right_scroll): Rename and update.
2439         (tui_scroll_forward_command, tui_scroll_backward_command)
2440         (tui_scroll_left_command, tui_scroll_right_command): Update.
2441         (tui_scroll): Remove.
2442         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2443         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2444         from tui_vertical_source_scroll.
2445         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2446         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2447         from tui_vertical_disassem_scroll.
2448         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2449         do_scroll_horizontal>: New methods.
2450         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2451         Likewise.
2452         (struct tui_source_window_base): Add do_scroll_horizontal.
2453         (struct tui_source_window, struct tui_disasm_window): Add
2454         do_scroll_vertical.
2455         (struct tui_data_window, struct tui_cmd_window): Add
2456         do_scroll_horizontal and do_scroll_vertical.
2457         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2458
2459 2019-06-25  Tom Tromey  <tom@tromey.com>
2460
2461         * tui/tui-data.h (struct tui_source_window_base): New struct.
2462         (struct tui_source_window): Derive from tui_source_window_base.
2463         (struct tui_disasm_window): New struct.
2464         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2465         from tui_source_window::clear_detail.
2466         (tui_source_window_base): Rename from tui_source_window.
2467         (~tui_source_window_base): Rename from ~tui_source_window.
2468         (tui_alloc_win_info): Create a tui_disasm_window.
2469
2470 2019-06-25  Tom Tromey  <tom@tromey.com>
2471
2472         * tui/tui-data.h (struct tui_source_window)
2473         (struct tui_data_window): Declare destructors.
2474         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2475         destructors.
2476         (tui_win_info): Simplify.
2477
2478 2019-06-25  Tom Tromey  <tom@tromey.com>
2479
2480         * tui/tui-winsource.c (tui_display_main)
2481         (tui_update_source_windows_with_addr)
2482         (tui_update_all_breakpoint_info): Update.
2483         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2484         (new_height_ok, parse_scrolling_args): Update.
2485         * tui/tui-stack.c (tui_show_frame_info): Update.
2486         * tui/tui-data.h (struct tui_list): Remove.
2487         (tui_source_windows): Return a reference to a std::vector.
2488         * tui/tui-data.c (source_windows): Now a std::vector.
2489         (tui_source_windows): Change return type.
2490         (tui_clear_source_windows): Rewrite.
2491         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2492         (tui_free_all_source_wins_content): Rewrite.
2493
2494 2019-06-25  Tom Tromey  <tom@tromey.com>
2495
2496         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2497         (struct tui_data_window, struct tui_cmd_window): Declare
2498         clear_detail method.
2499         * tui/tui-data.c (tui_source_window::clear_detail)
2500         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2501         methods.
2502         (tui_clear_win_detail): Simplify.
2503
2504 2019-06-25  Tom Tromey  <tom@tromey.com>
2505
2506         * tui/tui-layout.c (make_source_window, make_disasm_window)
2507         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2508         Return the new window.
2509         (show_source_disasm_command, show_data)
2510         (show_source_or_disasm_and_command): Update.
2511
2512 2019-06-25  Tom Tromey  <tom@tromey.com>
2513
2514         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2515         parameter.  Return the new window.
2516         (show_source_disasm_command): Update and remove NULL check.
2517         (show_source_or_disasm_and_command): Update.
2518
2519 2019-06-25  Tom Tromey  <tom@tromey.com>
2520
2521         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2522
2523 2019-06-25  Tom Tromey  <tom@tromey.com>
2524
2525         * tui/tui-data.h (struct tui_win_info): Make constructor
2526         protected.  Make destructor virtual.  Add initializers.
2527         (tui_source_window, tui_data_window, tui_cmd_window): New
2528         classes.
2529         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2530         constructor.  Add "type" parameter.
2531         (tui_source_window, tui_data_window, tui_cmd_window): New
2532         constructors.
2533         (tui_alloc_win_info): Instantiate the appropriate subclass.
2534
2535 2019-06-25  Tom Tromey  <tom@tromey.com>
2536
2537         * tui/tui-win.c (tui_resize_all): Use delete.
2538         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2539         destructor.
2540         (tui_free_window): Don't declare.
2541         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2542         Update.
2543
2544 2019-06-25  Tom Tromey  <tom@tromey.com>
2545
2546         * tui/tui-data.h (struct tui_win_info): Add constructor.
2547         * tui/tui-data.c (tui_alloc_win_info): Use new.
2548         (tui_free_window): Use delete.
2549
2550 2019-06-22  Tom Tromey  <tom@tromey.com>
2551
2552         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2553         declare.
2554         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2555
2556 2019-06-22  Tom Tromey  <tom@tromey.com>
2557
2558         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2559         declare.
2560         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2561
2562 2019-06-22  Tom de Vries  <tdevries@suse.de>
2563
2564         * dwarf2read.c (create_addrmap_from_aranges)
2565         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2566         instead of '%zu'.
2567
2568 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2569
2570         * dwarf2read.h (dwarf2_section_info_def): Remove.
2571         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2572         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2573         std::vector<dwarf2_section_info>.
2574         (struct dwo_file) <~dwo_file>: Remove.
2575         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2576         types field.
2577         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2578         (dwarf2_read_debug_names): Likewise.
2579         (create_debug_types_hash_table): Change parameter type to
2580         array_view, adjust code accordingly.
2581         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2582         (partial_die_info::fixup): Likewise.
2583         (determine_prefix): Likewise.
2584         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2585
2586 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2587
2588         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2589         gdb_bfd_ref_ptr.
2590         <~dwo_file>: Remove call to gdb_bfd_unref.
2591         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2592         gdb_bfd_ref_ptr::get.
2593
2594 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2595
2596         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2597         type to htab_up.
2598         * dwarf2read.c (struct dwo_file): Initialize fields.
2599         <~dwo_file>: New.
2600         (free_dwo_file): Remove, move content to ~dwo_file.
2601         (struct dwo_file_deleter): Remove.
2602         (dwo_file_up>: Remove custom deleter.
2603         (free_dwo_files): Remove.
2604         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2605         dwo_files.
2606         (process_skeletonless_type_units): Call unique_ptr::get.
2607         (allocate_dwo_file_hash_table): Add deleter to created hash
2608         table.  Change return type to htab_up.
2609         (lookup_dwo_file_slot): Don't memset dwo_file, call
2610         unique_ptr::get.
2611         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2612         (create_dwo_unit_in_dwp_v2): Likewise.
2613         (open_and_init_dwo_file): Likewise.
2614         (free_dwo_file_from_slot): Remove.
2615
2616 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2617
2618         * dwarf2read.h (struct dwarf2_section_info) <readin,
2619         is_virtual>: Change type to bool.
2620         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2621         true instead of 1.
2622
2623 2019-06-19  Tom Tromey  <tom@tromey.com>
2624
2625         * tui/tui-data.h (tui_init_content_element): Don't declare.
2626
2627 2019-06-19  Tom Tromey  <tom@tromey.com>
2628
2629         * tui/tui-data.h (tui_init_win_info): Don't declare.
2630
2631 2019-06-19  Tom de Vries  <tdevries@suse.de>
2632
2633         * dwarf2read.h (abstract_to_concrete): Change type to
2634         std::unordered_map<sect_offset, std::vector<sect_offset>,
2635         gdb::hash_enum<sect_offset>>.
2636
2637 2019-06-19  Tom Tromey  <tromey@adacore.com>
2638
2639         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2640         EVAL_AVOID_SIDE_EFFECTS specially.
2641
2642 2019-06-19  Tom Tromey  <tromey@adacore.com>
2643
2644         * source-cache.c (highlighter): New global.
2645         (source_cache::get_source_lines): Create a highlighter on demand.
2646
2647 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2648
2649         * defs.h (deprecated_interactive_hook): Delete declaration.
2650         * interps.c (clear_interpreter_hooks): Remove use of
2651         deprecated_interactive_hook.
2652         * top.c (deprecated_interactive_hook): Delete definition.
2653         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2654
2655 2019-06-18  Tom de Vries  <tdevries@suse.de>
2656
2657         PR gdb/24515
2658         * dwarf2read.h (abstract_to_concrete): Change type from
2659         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2660         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2661         * dwarf2read.c (read_variable): Update.
2662         (dwarf2_fetch_die_loc_sect_off): Update.
2663
2664 2019-06-17  Tom de Vries  <tdevries@suse.de>
2665
2666         PR gdb/24617
2667         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2668         accessing parent[parent_len - 1].
2669
2670 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2671
2672         PR gdb/24364
2673         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2674         call dtrace_process_dof with NULL dof.
2675
2676 2019-06-16  Tom de Vries  <tdevries@suse.de>
2677
2678         PR gdb/24445
2679         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2680
2681 2019-06-16  Tom Tromey  <tom@tromey.com>
2682
2683         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2684         (make_all_visible): Use address of member.
2685
2686 2019-06-16  Tom Tromey  <tom@tromey.com>
2687
2688         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2689         (tui_free_window, free_content, free_content_elements): Remove
2690         unnecessary cast.
2691         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2692         cast.
2693         * tui/tui-regs.c (tui_show_register_group)
2694         (tui_display_registers_from, tui_display_reg_element_at_line):
2695         Remove unnecessary cast.
2696
2697 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2698
2699         * linux-nat.c (normal_mask): Delete.
2700         (_initialize_linux_nat): Don't initialise normal_mask.
2701
2702 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2703
2704         PR gdb/24445
2705         * dwarf-index-write.h (write_psymtabs_to_index): Add
2706         dwz_basename parameter.
2707         * dwarf-index-write.c (write_gdbindex): Move file writing to
2708         write_gdbindex_1.  Change return type void.
2709         (assert_file_size): Move up, remove filename parameter.
2710         (write_gdbindex_1): New function.
2711         (write_debug_names): Change return type to void, call
2712         assert_file_size.
2713         (struct index_wip_file): New struct.
2714         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2715         file logic to index_wip_file.  Write index for dwz file if
2716         needed.
2717         (save_gdb_index_command): Pass basename of dwz file, if present.
2718         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2719         build-id of dwz file, if present.
2720         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2721         (dwarf2_get_dwz_file): Likewise.
2722         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2723         (dwarf2_get_dwz_file): Likewise.
2724
2725 2019-06-16  Tom Tromey  <tom@tromey.com>
2726
2727         * coffread.c (process_coff_symbol): Use xstrdup.
2728         * value.c (create_internalvar): Use xstrdup.
2729
2730 2019-06-16  Tom Tromey  <tom@tromey.com>
2731
2732         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2733         * breakpoint.c (stopin_command, stopat_command)
2734         (until_break_command, decode_location_default): Remove unnecessary
2735         cast.
2736         * utils.c (subset_compare): Remove unnecessary cast.
2737         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2738         cast.
2739         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2740         cast.
2741         * infcmd.c (path_command): Remove unnecessary cast.
2742         * coffread.c (decode_type): Remove unnecessary cast.
2743         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2744         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2745         * tui/tui-stack.c (tui_show_locator_content)
2746         (tui_show_frame_info): Remove unnecessary cast.
2747         * tui/tui-win.c (tui_scroll_forward_command)
2748         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2749         (parse_scrolling_args): Remove unnecessary cast.
2750         * tui/tui-data.c (init_win_info, tui_del_window)
2751         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2752         (free_content_elements): Remove unnecessary cast.
2753         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2754         unnecessary cast.
2755         * tui/tui-source.c (tui_set_source_content)
2756         (tui_vertical_source_scroll): Remove unnecessary cast.
2757         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2758         cast.
2759         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2760         * tui/tui-regs.c (tui_display_registers_from)
2761         (tui_display_register): Remove unnecessary cast.
2762         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2763         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2764         (make_visible): Remove unnecessary cast.
2765         * tui/tui-winsource.c (tui_erase_source_content)
2766         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2767         unnecessary cast.
2768         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2769         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2770         * stabsread.c (read_type, read_array_type, read_range_type):
2771         Remove unnecessary cast.
2772         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2773         (parse_symbol, parse_type, upgrade_type, parse_external)
2774         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2775         unnecessary cast.
2776         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2777
2778 2019-06-16  Tom Tromey  <tom@tromey.com>
2779
2780         * tui/tui-data.c (tui_alloc_generic_win_info)
2781         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2782         checks.
2783
2784 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2785             Andrew Burgess  <andrew.burgess@embecosm.com>
2786
2787         * f-typeprint.c (f_print_type): Don't return early for not
2788         associated or not allocated types.
2789         (f_type_print_varspec_suffix): Add print_rank parameter and print
2790         ranks of array types in case they dangling.
2791         (f_type_print_base): Add print_rank parameter.
2792
2793 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2794
2795         * NEWS: Mention new MI commands.
2796         * break-catch-throw.c (enum exception_event_kind): Move to
2797         breakpoint.h.
2798         (print_mention_exception_catchpoint): Output text as a single
2799         message.
2800         (catch_exception_command_1): Rename to...
2801         (catch_exception_event): ...this, make non-static, update header
2802         command, and change some parameter types.
2803         (catch_catch_command): Update for changes to
2804         catch_exception_command_1.
2805         (catch_throw_command): Likewise.
2806         (catch_rethrow_command): Likewise.
2807         * breakpoint.c (enum exception_event_kind): Delete.
2808         * breakpoint.h (enum exception_event_kind): Moved here from
2809         break-catch-throw.c.
2810         (catch_exception_event): Declare.
2811         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2812         (mi_cmd_catch_throw): New function.
2813         (mi_cmd_catch_rethrow): New function.
2814         (mi_cmd_catch_catch): New function.
2815         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2816         'catch-catch' entries.
2817         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2818         (mi_cmd_catch_rethrow): Declare.
2819         (mi_cmd_catch_catch): Declare.
2820
2821 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2822
2823         * annotate.c (annotate_source_line): Change return type to void,
2824         update implementation to match.
2825         * annotate.h (annotate_source_line): Change return type to void,
2826         update header comment.
2827         * stack.c (print_frame_info): Don't change what frame information
2828         is printed based on whether annotations are on or not.
2829
2830 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2831
2832         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2833         (annotate_source): Make static.
2834         (annotate_source_line): Moved from source.c and renamed from
2835         identify_source_line.  Update the return type.
2836         * annotate.h (annotate_source): Delete declaration.
2837         (annotate_source_line): Declaration moved from source.h, and
2838         renamed from identify_source_line.  Return type updated.
2839         * source.c (identify_source_line): Moved to annotate.c and renamed
2840         to annotate_source_line.
2841         (info_line_command): Remove check of annotation_level.
2842         * source.h (identify_source_line): Move declaration to annotate.h
2843         and rename to annotate_source_line.
2844         * stack.c: Add 'annotate.h' include.
2845         (print_frame_info): Remove check of annotation_level before
2846         calling annotate_source_line.
2847
2848 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2849
2850         * source-cache.c (source_cache::get_plain_source_lines): Use
2851         open_source_file_with_line_charpos instead of just
2852         open_source_file, remove call to find_source_lines.
2853         (source_cache::get_source_lines): Likewise.
2854         * source.c (find_source_lines): Make static.
2855         (get_filename_and_charpos): Renamed into...
2856         (open_source_file_with_line_charpos): ..this along with changes to
2857         return a scoped_fd, and some other minor clean ups.
2858         (identify_source_line): Use open_source_file_with_line_charpos.
2859         (search_command_helper): Use open_source_file_with_line_charpos
2860         instead of just open_source_file, remove call to
2861         find_source_lines.
2862         * source.h (open_source_file_with_line_charpos): Declare new
2863         function.
2864         (find_source_lines): Delete declaration.
2865
2866 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2867
2868         * source.c (get_filename_and_charpos): Remove fullname
2869         parameter.
2870         (identify_source_line): Update call to get_filename_and_charpos.
2871
2872 2019-06-14  Tom Tromey  <tromey@adacore.com>
2873
2874         PR gdb/24502:
2875         * ui-style.h (skip_ansi_escape): Update comment.
2876         * ui-file.h (class no_terminal_escape_file): New class.
2877         * ui-file.c (no_terminal_escape_file::write)
2878         (no_terminal_escape_file::puts): New methods.
2879         * cli/cli-logging.c (handle_redirections): Use
2880         no_terminal_escape_file.
2881
2882 2019-06-14  Tom Tromey  <tromey@adacore.com>
2883
2884         * NEWS: Move convenience variable news above Python news.
2885
2886 2019-06-14  Tom Tromey  <tom@tromey.com>
2887
2888         * gnulib: Move directory to top-level.
2889         * configure.ac: Don't configure gnulib.
2890         * configure: Rebuild.
2891         * common/common-defs.h: Use new path to gnulib.
2892         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2893         (GNULIB_H): Remove.
2894         (INCGNU): Look in new gnulib location.
2895         (HFILES_NO_SRCDIR): Remove gnulib files.
2896         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2897         (generated_files): Remove GNULIB_H.
2898         ($(LIBGNU), all-lib): Remove targets.
2899         (distclean): Don't mention GNULIB_BUILDDIR.
2900         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2901
2902 2019-06-14  Tom Tromey  <tromey@adacore.com>
2903
2904         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2905         Warn if symbol file does not provide any symbols.
2906
2907 2019-06-14  Tom Tromey  <tromey@adacore.com>
2908
2909         * source.c (find_and_open_source): Respect basenames_may_differ.
2910
2911 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2912
2913         * annotate.c (annotate_breakpoints_invalid): Make use of
2914         scoped_restore_terminal_state.
2915         (annotate_frames_invalid): Likewise.
2916
2917 2019-06-14  Tom Tromey  <tromey@adacore.com>
2918
2919         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2920         allow assignment to an internalvar.
2921
2922 2019-06-14  Tom Tromey  <tromey@adacore.com>
2923
2924         * ada-lex.l: Allow "_" in attribute names.
2925
2926 2019-06-14  Tom Tromey  <tromey@adacore.com>
2927
2928         PR gdb/24653:
2929         * regcache.c (registers_changed): Don't call alloca.
2930         * top.c (execute_command): Don't call alloca.
2931
2932 2019-06-13  Pedro Alves  <palves@redhat.com>
2933
2934         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2935         'expression'.  When parsing an expression, error out if there's
2936         junk after "unlimited".
2937         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2938         (do_set_command): Adjust calls to is_unlimited_literal.
2939
2940 2019-06-13  Pedro Alves  <palves@redhat.com>
2941
2942         * compile/compile.c (make_compile_options_def_group): Add braces
2943         around array_view initializer.
2944         * thread.c (make_thread_apply_all_options_def_group)
2945         (make_thread_apply_all_options_def_group): Likewise.
2946
2947 2019-06-13  Pedro Alves  <palves@redhat.com>
2948
2949         * NEWS (New commands): Mention "maint test-options
2950         require-delimiter", "maint test-options unknown-is-error", "maint
2951         test-options unknown-is-operand" and "maint show
2952         test-options-completion-result".
2953         (New command options, command completion): New section.
2954         (Completion improvements): New section.
2955         Mention that you can abbreviate "unlimited".
2956
2957 2019-06-13  Pedro Alves  <palves@redhat.com>
2958
2959         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2960         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2961         * unittests/cli-utils-selftests.c (test_parse_flags)
2962         (test_parse_flags_qcs): Delete.
2963         (test_cli_utils): Don't call deleted functions.
2964
2965 2019-06-13  Pedro Alves  <palves@redhat.com>
2966
2967         * thread.c: Include "cli/cli-option.h".
2968         (tp_array_compar_ascending): Global.
2969         (tp_array_compar): Delete function.
2970         (tp_array_compar_ascending, tp_array_compar_descending): New
2971         functions.
2972         (ascending_option_def, qcs_flag_option_def)
2973         (thr_qcs_flags_option_defs)
2974         (make_thread_apply_all_options_def_group)
2975         (make_thread_apply_options_def_group): New.
2976         (thread_apply_all_command): Use gdb::option::process_options.
2977         (thread_apply_command_completer)
2978         (thread_apply_all_command_completer): New.
2979         (thread_apply_command): Use gdb::option::process_options.
2980         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2981         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2982         to generate help text of "thread apply".  Adjust "taas"'s help.
2983         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2984         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2985
2986 2019-06-13  Pedro Alves  <palves@redhat.com>
2987
2988         * thread.c (thread_apply_command): Check for invalid TID with
2989         isdigit instead of !isalpha.
2990
2991 2019-06-13  Pedro Alves  <palves@redhat.com>
2992
2993         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2994         (validate_flags_qcs): New.
2995         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2996         (validate_flags_qcs): Declare.
2997         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2998         (make_frame_apply_options_def_group): New.
2999         (frame_apply_command_count): Process options with
3000         gdb::option::process_options.
3001         (frame_apply_completer): New.
3002         (frame_apply_level_completer, frame_apply_all_completer)
3003         (frame_apply_completer): New.
3004         (_initialize_stack): Update help of "frame apply", "frame apply
3005         level", "frame apply all" and "faas" to mention supported options
3006         and install command completers.
3007         * stack.h (frame_apply_all_completer): Declare.
3008         * thread.c: Include "stack.h".
3009         (tfaas_command): Add "--".
3010         (_initialize_thread): Update help "tfaas" to mention supported
3011         options and install command completer.
3012
3013 2019-06-13  Pedro Alves  <palves@redhat.com>
3014
3015         * completer.c (complete_nested_command_line): New.
3016         (gdb_completion_word_break_characters_throw): Add assertion.
3017         * completer.h (complete_nested_command_line): Declare.
3018
3019 2019-06-13  Pedro Alves  <palves@redhat.com>
3020
3021         * stack.c (parse_backtrace_qualifiers): New.
3022         (backtrace_command): Use it.
3023         (backtrace_command_completer): Complete on qualifiers.
3024
3025 2019-06-13  Pedro Alves  <palves@redhat.com>
3026
3027         * frame.c: Include "cli/cli-option.h.
3028         (user_set_backtrace_options): New.
3029         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3030         Delete.
3031         (get_prev_frame): Adjust.
3032         (boolean_option_def, uinteger_option_def)
3033         (set_backtrace_option_defs): New.
3034         (_initialize_frame): Adjust and use
3035         gdb::option::add_setshow_cmds_for_options to install "set
3036         backtrace past-main" and "set backtrace past-entry".
3037         * frame.h: Include "cli/cli-option.h".
3038         (struct frame_print_options): Forward declare.
3039         (print_frame_arguments_all, print_frame_arguments_scalars)
3040         (print_frame_arguments_none): Declare.
3041         (print_entry_values): Delete declaration.
3042         (struct frame_print_options, user_frame_print_options): New.
3043         (struct set_backtrace_options): New.
3044         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3045         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3046         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3047         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3048         (list_args_or_locals): Add frame_print_options parameter.
3049         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3050         * python/py-framefilter.c (enumerate_args): Pass down
3051         USER_FRAME_PRINT_OPTIONS.
3052         * stack.c: Include "cli/cli-option.h".
3053         (print_frame_arguments_all, print_frame_arguments_scalars)
3054         (print_frame_arguments_none): Declare.
3055         (print_raw_frame_arguments, print_entry_values): Delete.
3056         (user_frame_print_options): New.
3057         (boolean_option_def, enum_option_def, frame_print_option_defs):
3058         New.
3059         (struct backtrace_cmd_options): New.
3060         (bt_flag_option_def): New.
3061         (backtrace_command_option_defs): New.
3062         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3063         (print_frame_arg, read_frame_arg, print_frame_args)
3064         (print_frame_info, print_frame): Add frame_print_options parameter
3065         and use it.
3066         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3067         (backtrace_command_1): Add frame_print_options and
3068         backtrace_cmd_options parameters and use them.
3069         (make_backtrace_options_def_group): New.
3070         (backtrace_command): Process command options with
3071         gdb::option::process_options.
3072         (backtrace_command_completer): New.
3073         (_initialize_stack): Extend "backtrace"'s help to mention
3074         supported options.  Install completer for "backtrace".
3075         Install some settings commands with add_setshow_cmds_for_options.
3076
3077 2019-06-13  Pedro Alves  <palves@redhat.com>
3078
3079         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3080         and that "set/show print raw frame-arguments" are now deprecated.
3081
3082         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3083         command.
3084         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3085         * stack.c (_initialize_stack): Install "set/show print
3086         raw-frame-arguments", and deprecate "set/show print raw
3087         frame-arguments".
3088         * valprint.c (_initialize_valprint): Deprecate "set/show print
3089         raw".
3090
3091 2019-06-13  Pedro Alves  <palves@redhat.com>
3092
3093         * compile/compile.c (struct compile_options): New.
3094         (compile_flag_option_def, compile_command_option_defs)
3095         (make_compile_options_def_group): New.
3096         (compile_file_command): Handle options with
3097         gdb::option::process_options.
3098         (compile_file_command_completer): New function.
3099         (compile_code_command): Handle options with
3100         gdb::option::process_options.
3101         (compile_code_command_completer): New function.
3102         (_initialize_compiler): Install completers for "compile code" and
3103         "compile file".  Mention available options in "compile code" and
3104         "compile code"'s help.
3105         * completer.c (advance_to_completion_word): New, factored out from
3106         ...
3107         (advance_to_expression_complete_word_point): ... this.
3108         (advance_to_filename_complete_word_point): New.
3109         * completer.h (advance_to_filename_complete_word_point): New
3110         declaration.
3111
3112 2019-06-13  Pedro Alves  <palves@redhat.com>
3113
3114         * compile/compile.c: Include "cli/cli-option.h".
3115         (compile_print_value): Scope data pointer is now a
3116         value_print_options pointer; adjust.
3117         (compile_print_command): Process options.  Scope data pointer is
3118         now a value_print_options pointer; adjust.
3119         (_initialize_compile): Update "compile print"'s help to include
3120         supported options.  Install a completer for "compile print".
3121         * cp-valprint.c (show_vtblprint, show_objectprint)
3122         (show_static_field_print): Delete.
3123         (_initialize_cp_valprint): Don't install "set print
3124         static-members", "set print vtbl", "set print object" here.
3125         * printcmd.c: Include "cli/cli-option.h" and
3126         "common/gdb_optional.h".
3127         (print_command_parse_format): Rework to fill in a
3128         value_print_options instead of a format_data.
3129         (print_value): Change parameter type from format_data pointer to
3130         value_print_options reference.  Adjust.
3131         (print_command_1): Process options.  Adjust to pass down a
3132         value_print_options.
3133         (print_command_completer): New.
3134         (_initialize_printcmd): Install print_command_completer as
3135         handle_brkchars completer for the "print" command.  Update
3136         "print"'s help to include supported options.
3137         * valprint.c: Include "cli/cli-option.h".
3138         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3139         here from cp-valprint.c.
3140         (boolean_option_def, uinteger_option_def)
3141         (value_print_option_defs, make_value_print_options_def_group):
3142         New.  Use gdb::option::add_setshow_cmds_for_options to install
3143         "set print elements", "set print null-stop", "set print repeats",
3144         "set print pretty", "set print union", "set print array", "set
3145         print address", "set print symbol", "set print array-indexes".
3146         * valprint.h: Include <string> and "cli/cli-option.h".
3147         (make_value_print_options_def_group): Declare.
3148         (print_value): Change parameter type from format_data pointer to
3149         value_print_options reference.
3150         (print_command_completer): Declare.
3151
3152 2019-06-13  Pedro Alves  <palves@redhat.com>
3153
3154         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3155         (COMMON_SFILES): Add maint-test-settings.c.
3156         * cli/cli-decode.c (boolean_enums): New global, factored out from
3157         ...
3158         (add_setshow_boolean_cmd): ... here.
3159         * cli/cli-decode.h (boolean_enums): Declare.
3160         * cli/cli-option.c: New file.
3161         * cli/cli-option.h: New file.
3162         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3163         factored out from ...
3164         (parse_cli_boolean_value(const char *)): ... this.
3165         (is_unlimited_literal): Change parameter type to pointer to
3166         pointer.  Adjust and advance ARG pointer.
3167         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3168         (parse_cli_var_enum): New, factored out from ...
3169         (do_set_command): ... this.  Adjust.
3170         * cli/cli-setshow.h (parse_cli_boolean_value)
3171         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3172         (parse_cli_var_enum): Declare.
3173         * cli/cli-utils.c: Include "cli/cli-option.h".
3174         (get_ulongest): New.
3175         * cli/cli-utils.h (get_ulongest): Declare.
3176         (check_for_argument): New overloads.
3177         * maint-test-options.c: New file.
3178
3179 2019-06-13  Pedro Alves  <palves@redhat.com>
3180
3181         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3182         parse a range if "-" is at the end of the string.
3183
3184 2019-06-13  Pedro Alves  <palves@redhat.com>
3185
3186         * cli/cli-setshow.c (parse_auto_binary_operation)
3187         (parse_cli_boolean_value): Don't allow "o".
3188
3189 2019-06-13  Pedro Alves  <palves@redhat.com>
3190
3191         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3192         * NEWS: Mention maint test-settings KIND.
3193         * maint-test-settings.c: New file.
3194
3195 2019-06-13  Pedro Alves  <palves@redhat.com>
3196
3197         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3198         completer.
3199         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3200         "set" completers.
3201
3202 2019-06-13  Pedro Alves  <palves@redhat.com>
3203
3204         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3205         after item.
3206
3207 2019-06-13  Pedro Alves  <palves@redhat.com>
3208
3209         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3210
3211 2019-06-13  Pedro Alves <palves@redhat.com>
3212
3213         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3214         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3215         call.
3216         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3217         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3218         calls.
3219         (check_for_argument): Skip spaces after argument.
3220
3221 2019-06-13  Pedro Alves  <palves@redhat.com>
3222
3223         * thread.c (thread_apply_command): Adjust TID parsing.
3224         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3225         detected before end of string.
3226         (tid_is_in_list): Error out if LIST is invalid.
3227
3228 2019-06-13  Pedro Alves  <palves@redhat.com>
3229
3230         * completer.c (complete_line_internal_1): Rewind completion word
3231         point.
3232         (completion_tracker::advance_custom_word_point_by): Change
3233         parameter type to int.
3234         * completer.h (completion_tracker::advance_custom_word_point_by):
3235         Likewise.
3236
3237 2019-06-13  Pedro Alves  <palves@redhat.com>
3238
3239         * completer.c (advance_to_completion_word): Handle delimiters.
3240
3241 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3242
3243         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3244
3245 2019-06-11  Tom Tromey  <tom@tromey.com>
3246
3247         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3248         (xmalloc_failed): Move to alloc.c.
3249         * alloc.c: New file.
3250         * Makefile.in (COMMON_SFILES): Add alloc.c.
3251
3252 2019-06-11  Tom Tromey  <tom@tromey.com>
3253
3254         * nat/linux-waitpid.c: Don't include server.h.
3255         (linux_debug): Remove.
3256         (my_waitpid): Update.
3257
3258 2019-06-11  Tom Tromey  <tromey@adacore.com>
3259
3260         * infcall.c (_initialize_infcall): Remove trailing newline from
3261         help.
3262         * user-regs.c (_initialize_user_regs): Remove trailing newline
3263         from help.
3264         * typeprint.c (_initialize_typeprint): Remove trailing newline
3265         from help.
3266         * reverse.c (_initialize_reverse): Remove trailing newlines from
3267         help.
3268         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3269         from help.
3270         * language.c (add_set_language_command): Remove trailing newline
3271         from help.
3272         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3273         help.
3274         * disasm.c (_initialize_disasm): Remove trailing newline from
3275         help.
3276         * top.c (init_main): Remove trailing newline from help.
3277         * interps.c (_initialize_interpreter): Remove trailing newline
3278         from help.
3279         * btrace.c (_initialize_btrace): Remove trailing newlines from
3280         help.
3281         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3282         from help.
3283         * python/python.c (_initialize_python): Remove trailing newline
3284         from help.
3285         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3286         help.
3287         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3288         from help.  Reformat some text.
3289         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3290         from help.
3291         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3292         newline from help.
3293
3294 2019-06-11  Tom Tromey  <tromey@adacore.com>
3295
3296         * darwin-nat.c (darwin_decode_exception_message)
3297         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3298
3299 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3300
3301         * valops.c (value_slice): Check for not allocated or not
3302         associated values.
3303
3304 2019-06-10  Tom de Vries  <tdevries@suse.de>
3305
3306         PR gdb/24618
3307         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3308         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3309         invalid.
3310
3311 2019-06-10  Tom de Vries  <tdevries@suse.de>
3312
3313         PR gdb/24611
3314         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3315         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3316
3317 2019-06-10  Tom de Vries  <tdevries@suse.de>
3318
3319         PR symtab/24545
3320         * symtab.c (struct demangled_name_entry): Add language field.
3321         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3322         static minimal symbol".  Set and use language field.
3323
3324 2019-06-10  Tom Tromey  <tromey@adacore.com>
3325
3326         * ada-lang.c (_initialize_ada_language): Update help text.
3327
3328 2019-06-10  Tom Tromey  <tromey@adacore.com>
3329
3330         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3331         with a newline.
3332         * guile/guile.c (handle_boot_error): Don't end warning with a
3333         newline.
3334         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3335         warning with a newline.
3336         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3337         newline.
3338         (s12z_frame_cache): Likewise.
3339         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3340         a newline.
3341         * solib-svr4.c (disable_probes_interface): Don't end warning with
3342         a newline.
3343         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3344         newline.
3345         * python/python.c (do_finish_initialization): Don't end warning
3346         with a newline.
3347
3348 2019-06-10  Tom Tromey  <tom@tromey.com>
3349
3350         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3351         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3352         gdbpy_enter.
3353
3354 2019-06-10  Tom Tromey  <tromey@adacore.com>
3355
3356         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3357         data.
3358         (elf_new_init): Don't call stabsread_new_init.
3359         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3360         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3361         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3362
3363 2019-06-10  Tom de Vries  <tdevries@suse.de>
3364
3365         PR symtab/16264
3366         PR symtab/24517
3367         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3368
3369 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3370
3371         * source.c (find_and_open_source): Also rewrite relative file
3372         names.
3373
3374 2019-04-26  Amos Bird  <amosbird@gmail.com>
3375
3376         * annotate.c (annotate_thread_exited): Add "thread-exited"
3377         annotation.
3378
3379 2019-06-06  Tom Tromey  <tromey@adacore.com>
3380
3381         * maint.h (class scoped_command_stats): Use
3382         DISABLE_COPY_AND_ASSIGN.
3383         <print_time>: New method.
3384         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3385         print_time.
3386         (scoped_command_stats::print_time): New method.
3387
3388 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3389
3390         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3391         instructions of lengths 6 or 8 bytes.
3392
3393 2019-06-04  Pedro Alves  <palves@redhat.com>
3394
3395         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3396
3397         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3398         * breakpoint.c (condition_completer): Likewise.
3399         * cli/cli-dump.c (scan_expression): Likewise.
3400         * common/filestuff.c (mkdir_recursive): Likewise.
3401         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3402         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3403         (gdb_abspath): Likewise.
3404         * compile/compile-cplus-types.c
3405         (compile_cplus_instance::decl_name): Likewise.
3406         * completer.c (complete_explicit_location):
3407         (signal_completer, reg_or_group_completer_1): Likewise.
3408         * cp-support.c (cp_remove_params_if_any): Likewise.
3409         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3410         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3411         * infcmd.c (strip_bg_char): Likewise.
3412         * linespec.c (copy_token_string): Likewise.
3413         * mi/mi-main.c (output_cores): Likewise.
3414         * psymtab.c (psymtab_search_name):
3415         * symfile.c (test_set_ext_lang_command): Likewise.
3416         * target.c (target_fileio_read_stralloc): Likewise.
3417         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3418         * value.c (complete_internalvar): Likewise.
3419
3420 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3421
3422         Add objfile property to gdb.Type.
3423         * NEWS: Mention Python API addition.
3424         * python/py-type.c (typy_get_objfile): New method.
3425
3426 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3427
3428         * NEWS: Mention the new set|show style [title|highlight].
3429         Mention changes to "show style", "help" and "apropos".
3430
3431 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3432
3433         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3434         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3435         instead of print_help_for_command.
3436         (print_doc_of_command): New function.
3437         (help_list): Add 'apropos -v word' suggestion.
3438         (print_help_for_command): Style the command name using title style.
3439         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3440         (_initialize_cli_cmds): Describe -v in apropos_command help.
3441
3442 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3443
3444         * cli/cli-style.h (cli_style_option): Add name in constructor,
3445         add m_name class member, add constructor with intensity,
3446         add name class function.
3447         (cli_style_option::add_setshow_commands): Remove name argument.
3448         (highlight_style, title_style): New styles.
3449         * cli/cli-style.c (do_show): New function that shows a style
3450         characteristic styling the style name with itself.
3451         (set_style_name): New function.
3452         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3453         Update all callers according to the changes in cli/cli-style.h.
3454         * utils.h (fputs_highlighted): New function.
3455         * utils.c (fputs_highlighted): Likewise.
3456
3457 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3458
3459         * NEWS: Mention new pipe command and new convenience variables.
3460
3461 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3462
3463         * cli/cli-cmds.c (pipe_command): New function.
3464         (_initialize_cli_cmds): Call add_com for pipe_command.
3465         Define | as an alias for pipe.
3466         (exit_status_set_internal_vars): New function.
3467         (shell_escape): Call exit_status_set_internal_vars.
3468         cli/cli-decode.c (find_command_name_length): Recognize | as
3469         a single character command.
3470
3471 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3472
3473         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3474         top.c (execute_command_to_ui_file): New function, mostly a copy
3475         of execute_command_to_string.
3476         (execute_command_to_string): Implement by calling
3477         execute_command_to_ui_file.
3478
3479 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3480
3481         * top.h (saved_command_line): Remove declaration.
3482         * top.c (previous_saved_command_line, previous_repeat_arguments):
3483         New variables.
3484         (saved_command_line): Make static, define together with other
3485         'repeat variables'.
3486         (dont_repeat): Clear repeat_arguments.
3487         (repeat_previous, get_saved_command_line, save_command_line):
3488         New functions.
3489         (gdb_init): Initialize saved_command_line
3490         and previous_saved_command_line.
3491         * main.c (captured_main_1): Remove saved_command_line initialization.
3492         * event-top.c (handle_line_of_input): Update to use
3493         the new 'repeat' related functions instead of direct access to
3494         saved_command_line.
3495         * command.h (repeat_previous, get_saved_command_line,
3496         save_command_line): New declarations.
3497         (dont_repeat): Add comment.
3498
3499 2019-05-30  Tom Tromey  <tromey@adacore.com>
3500
3501         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3502         Fix comment.
3503         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3504
3505 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3506
3507         PR cli/24587
3508         * completer.c (complete): Initialize variable word.
3509
3510 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3511
3512         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3513         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3514         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3515         'body' is NULL to the outter 'if', protecting the '!is_define'
3516         situation as well.
3517
3518 2019-05-29  Tom Tromey  <tromey@adacore.com>
3519
3520         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3521         (dwarf_unknown): New function.
3522         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3523         (dwarf_type_encoding_name): Use dwarf_unknown.
3524
3525 2019-05-29  Tom Tromey  <tromey@adacore.com>
3526
3527         PR c++/20020:
3528         * cp-valprint.c (cp_print_value_fields): Call
3529         cp_print_static_field inside "try".
3530
3531 2019-05-29  Tom Tromey  <tromey@adacore.com>
3532
3533         * inflow.c (struct terminal_info): Add default operator=.
3534         * configure: Rebuild.
3535         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3536         -Wdeprecated-copy-dtor, -Wredundant-move.
3537
3538 2019-05-29  Tom Tromey  <tromey@adacore.com>
3539
3540         * NEWS: Add entry.
3541         * infcmd.c (print_return_value_1): Handle finish_print
3542         option.
3543         (show_print_finish): New function.
3544         (_initialize_infcmd): Add "set/show print finish" commands.
3545         * valprint.c (user_print_options): Initialize new member.
3546         * valprint.h (struct value_print_options) <finish_print>: New
3547         member.
3548
3549 2019-05-28  Tom Tromey  <tromey@adacore.com>
3550
3551         * ada-lang.c (ada_remove_Xbn_suffix)
3552         (find_old_style_renaming_symbol)
3553         (parse_old_style_renaming): Remove.
3554         (ada_find_renaming_symbol): Don't call
3555         find_old_style_renaming_symbol.
3556         (ada_is_renaming_symbol): Rename from
3557         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3558         bool.  Now static.
3559         (ada_read_var_value): Update and simplify.
3560         * ada-exp.y (write_var_or_type): Remove old code.
3561
3562 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3563
3564         * event-top.c: Remove include comment.
3565         * inflow.c (class scoped_ignore_sigttou): Move from here...
3566         * inflow.h (class scoped_ignore_sigttou): ...to here.
3567         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3568         * top.c:  Remove include comment.
3569
3570 2019-05-27  Tom Tromey  <tom@tromey.com>
3571
3572         * NEWS: Fix typo.
3573
3574 2019-05-22  Tom Tromey  <tromey@adacore.com>
3575
3576         * target.c (target_follow_exec): Constify parameter.
3577         * target-delegates.c: Rebuild.
3578         * remote.c (remote_target::follow_exec): Constify parameter.
3579         * infrun.c (follow_exec): Constify parameter.
3580         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3581         (target_follow_exec): Likewise.
3582
3583 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3584
3585         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3586         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3587
3588 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3589
3590         * NEWS: Add debugredirect and testsuite sections.
3591
3592 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3593
3594         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3595         target descriptions using exclusively floating point register name
3596         aliases.
3597
3598 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3599
3600         PR gdb/18644:
3601         * f-lang.c (build_fortran_types): Handle the case where
3602         gdbarch_floatformat_for_type returns a nullptr.
3603
3604 2019-05-21  Tom de Vries  <tdevries@suse.de>
3605
3606         PR cli/24587
3607         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3608
3609 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3610
3611         PR gdb/18644:
3612         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3613         16-byte floats.
3614         * i386-tdep.c (i386_floatformat_for_type): Use
3615         floatformats_ia64_quad for the 16-byte floating point component
3616         within a fortran 32-byte complex number.
3617
3618 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3619
3620         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3621         delete default constructor.
3622         (find_partial_die): Update to return const struct.
3623         (partial_die_parent_scope): Move variable declaration into scope
3624         of its use and change its type to auto.
3625         (guess_partial_die_structure_name): Likewise.
3626         (partial_die_info::fixup): Likewise.
3627
3628 2019-05-17  Tom Tromey  <tromey@adacore.com>
3629
3630         * source.c (find_and_open_source): Remove cast.
3631
3632 2019-05-17  Tom Tromey  <tromey@adacore.com>
3633
3634         * annotate.c (annotate_source): Make "filename" const.
3635         * annotate.h (annotate_source): Use const.
3636
3637 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3638
3639         * disasm.c (set_disassembler_options): Send errors to stderr.
3640
3641 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3642
3643         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3644         (cli_interp_base::set_logging): Check debug_redirect.
3645         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3646         * cli/cli-logging.c (debug_redirect): Add static variable.
3647         (pop_output_files): Add default param.
3648         (handle_redirections): Print debug setting.
3649         (show_logging_command): Likewise.
3650         (_initialize_cli_logging): Add debugredirect command.
3651         * interps.c (current_interp_set_logging): Add debug_redirect
3652         parameter.
3653         * interps.h (set_logging): Add debug_redirect parameter.
3654         (current_interp_set_logging): Likewise.
3655         * mi/mi-common.h: Likewise.
3656         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3657
3658 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3659             Tom Tromey  <tromey@adacore.com>
3660
3661         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3662         directly.
3663         * cli/cli-interp.h (make_logging_output): Remove declaration.
3664         * cli/cli-logging.c (make_logging_output): Remove function.
3665         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3666         directly.
3667         * ui-file.c (tee_file::tee_file): Remove bools.
3668         (tee_file::~tee_file): Remove deletes.
3669         * ui-file.h (tee_file): Remove bools.
3670
3671 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3672
3673         * mi/mi-cmds.h (mi_cmd_complete): New function.
3674         * mi/mi-main.c (mi_cmd_complete): Likewise.
3675         * mi/mi-cmds.c: Define new MI command -complete.
3676         * NEWS: Mention new -complete command.
3677
3678 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3679
3680         * completer.h (complete): New function.
3681         * completer.c (complete): Likewise.
3682         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3683         function defined in completer.h.
3684
3685 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3686
3687         * MAINTAINERS (Write After Approval): Add myself.
3688
3689 2019-05-17  Tom de Vries  <tdevries@suse.de>
3690
3691         PR gdb/24094
3692         * dwarf2read.c (struct cu_partial_die_info): New struct.
3693         (find_partial_die): Return cu_partial_die_info.
3694         (partial_die_parent_scope, guess_partial_die_structure_name)
3695         (partial_die_info::fixup): Handle new return type of find_partial_die.
3696
3697 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3698
3699         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3700         "std::string", simplifying the algorithm.
3701
3702 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3703
3704         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3705         (stap_static_probe_ops::get_probes): Likewise.
3706
3707 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3708
3709         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3710         '-')" and "else if".
3711         (stap_parse_single_operand): Join checks for
3712         "gdbarch_stap_parse_special_token_p" and
3713         "gdbarch_stap_parse_special_token" in the same "if" statement.
3714         Invert check when verifying for operation on register
3715         displacement.
3716
3717 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3718
3719         * stap-probe.c (stap_get_opcode): Update comment.
3720         (stap_get_expected_argument_type): Likewise.
3721         (handle_stap_probe): Likewise.
3722
3723 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3724
3725         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3726         return type to 'bool'.  Adjust comment.  Use 'bool' when
3727         appropriate.
3728         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3729         * stap-probe.c (stap_parse_argument_1): Likewise.
3730         (stap_is_operator): Likewise.
3731         (stap_is_generic_prefix): Likewise.
3732         (stap_is_register_prefix): Likewise.
3733         (stap_is_register_indirection_prefix): Likewise.
3734         (stap_is_integer_prefix): Likewise.
3735         (stap_generic_check_suffix): Likewise.
3736         (stap_check_integer_suffix): Likewise.
3737         (stap_check_register_suffix): Likewise.
3738         (stap_check_register_indirection_suffix): Likewise.
3739         (stap_parse_register_operand): Likewise.
3740         (stap_parse_single_operand): Likewise.
3741         (stap_parse_argument_1): Likewise.
3742         (stap_probe::get_argument_count): Likewise.
3743         (stap_is_operator): Likewise.
3744
3745 2019-05-16  Tom Tromey  <tromey@adacore.com>
3746
3747         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3748         keyword to foreach.
3749
3750 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3751
3752         * linux-thread-db.c (try_thread_db_load_1): Change return type
3753         to bool.
3754         (try_thread_db_load): Likewise.
3755         (try_thread_db_load_from_pdir_1): Likewise.
3756         (try_thread_db_load_from_pdir): Likewise.
3757         (try_thread_db_load_from_sdir): Likewise.
3758         (try_thread_db_load_from_dir): Likewise.
3759         (thread_db_load_search): Likewise.
3760         (has_libpthread): Likewise.
3761         (thread_db_load): Likewise.
3762
3763 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3764
3765         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3766         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3767         NULL, and complain/return if that's the case.
3768
3769 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3770
3771         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3772         (advance, posn, abstract_read_memory): New functions.
3773         [struct mem_read_abstraction]: New struct.
3774         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3775
3776 2019-05-14  Tom Tromey  <tromey@adacore.com>
3777
3778         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3779         value is not lval_memory.
3780
3781 2019-05-14  Tom Tromey  <tromey@adacore.com>
3782
3783         * solib.c (info_sharedlibrary_command): Style the file name.
3784
3785 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3786
3787         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3788         (aarch64_vnv_type): Likewise.
3789         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3790         * common/tdesc.c: Likewise.
3791         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3792         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3793         * features/aarch64-fpu.xml: Add ieee half view.
3794         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3795         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3796         * gdbtypes.h (struct builtin_type): Likewise.
3797         (struct objfile_type): Likewise.
3798
3799 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3800
3801         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3802         typo.
3803         * location.h (string_to_event_location): Likewise.
3804
3805 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3806
3807         GDB 8.3 released.
3808
3809 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3810
3811         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3812         New variable declaration.
3813         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3814         New variable.
3815         (print_one_breakpoint): Use ui_out::test_flags and new global
3816         variable to compute use_fixed_output.
3817         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3818         Remove.
3819         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3820         (mi_multi_location_breakpoint_output_fixed): Remove.
3821         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3822         new variable.
3823         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3824         fix_multi_location_breakpoint_output flag if version >= 3.
3825         * ui-out.h (enum ui_out_flag)
3826         <fix_multi_location_breakpoint_output>: New enumerator.
3827
3828 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3829
3830         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3831
3832 2019-05-10  Tom Tromey  <tromey@adacore.com>
3833
3834         * ada-lang.c (catch_ada_completer): New function.
3835         (_initialize_ada_language): Use it.
3836
3837 2019-05-10  Tom Tromey  <tromey@adacore.com>
3838
3839         * thread.c (print_thread_info): Make "requested_threads" const.
3840         * gdbthread.h (print_thread_info): Make "requested_threads"
3841         const.
3842         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3843         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3844
3845 2019-05-08  Tom Tromey  <tom@tromey.com>
3846
3847         * gdbtypes.c (objfile_type_data): Change type.
3848         (objfile_type, _initialize_gdbtypes): Update.
3849
3850 2019-05-08  Tom Tromey  <tom@tromey.com>
3851
3852         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3853         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3854         (_initialize_dwarf2_frame): Update.
3855
3856 2019-05-08  Tom Tromey  <tom@tromey.com>
3857
3858         * objc-lang.c (objc_objfile_data): Change type.
3859         (find_methods): Update.
3860         (_initialize_objc_lang): Remove.
3861
3862 2019-05-08  Tom Tromey  <tom@tromey.com>
3863
3864         * stabsread.c (rs6000_builtin_type_data): Change type.
3865         (rs6000_builtin_type, _initialize_stabsread): Update.
3866
3867 2019-05-08  Tom Tromey  <tom@tromey.com>
3868
3869         * mips-tdep.c (mips_pdr_data): Remove.
3870         (_initialize_mips_tdep): Update.
3871
3872 2019-05-08  Tom Tromey  <tom@tromey.com>
3873
3874         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3875         (hppa_init_objfile_priv_data, read_unwind_info)
3876         (find_unwind_entry, _initialize_hppa_tdep): Update.
3877
3878 2019-05-08  Tom Tromey  <tom@tromey.com>
3879
3880         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3881         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3882         on obstack.
3883         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3884
3885 2019-05-08  Tom Tromey  <tom@tromey.com>
3886
3887         * mdebugread.c (basic_type_data): Change type.
3888         (basic_type, _initialize_mdebugread): Update.
3889
3890 2019-05-08  Tom Tromey  <tom@tromey.com>
3891
3892         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3893
3894 2019-05-08  Tom Tromey  <tom@tromey.com>
3895
3896         * nto-tdep.c (nto_inferior_data_reg): Change type.
3897         (nto_inferior_data): Update.
3898         (nto_inferior_data_cleanup, nto_new_inferior_data)
3899         (_initialize_nto_tdep): Remove.
3900         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3901
3902 2019-05-08  Tom Tromey  <tom@tromey.com>
3903
3904         * ada-lang.c (struct ada_inferior_data): Add initializers.
3905         (ada_inferior_data): Change type.
3906         (ada_inferior_data_cleanup): Remove.
3907         (get_ada_inferior_data, ada_inferior_exit)
3908         (struct ada_pspace_data): Add initializers, destructor.
3909         (ada_pspace_data_handle): Change type.
3910         (get_ada_pspace_data): Update.
3911         (ada_pspace_data_cleanup): Remove.
3912
3913 2019-05-08  Tom Tromey  <tom@tromey.com>
3914
3915         * coffread.c (struct coff_symfile_info): Add initializers.
3916         (coff_objfile_data_key): Move lower.  Change type.
3917         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3918         Update.
3919         (coff_free_info): Remove.
3920
3921 2019-05-08  Tom Tromey  <tom@tromey.com>
3922
3923         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3924         (fbsd_pspace_data_handle): Move lower.  Change type.
3925         (get_fbsd_pspace_data): Update.
3926         (fbsd_pspace_data_cleanup): Remove.
3927         (_initialize_fbsd_tdep): Update.
3928
3929 2019-05-08  Tom Tromey  <tom@tromey.com>
3930
3931         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3932         (get_ada_tasks_pspace_data): Update.
3933         (ada_tasks_pspace_data_cleanup): Remove.
3934         (_initialize_tasks): Update.
3935         (ada_tasks_inferior_data_handle): Change type.
3936         (get_ada_tasks_inferior_data): Update.
3937         (ada_tasks_inferior_data_cleanup): Remove.
3938         (struct ada_tasks_pspace_data): Add initializers.
3939
3940 2019-05-08  Tom Tromey  <tom@tromey.com>
3941
3942         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3943         * symfile-debug.c (debug_sym_get_probes): Change type.
3944         * stap-probe.c (handle_stap_probe):
3945         (stap_static_probe_ops::get_probes): Change type.
3946         * probe.h (class static_probe_ops) <get_probes>: Change type.
3947         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3948         (parse_probes_in_pspace): Update.
3949         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3950         Update.
3951         (any_static_probe_ops::get_probes): Change type.
3952         * elfread.c (elfread_data): New typedef.
3953         (probe_key): Change type.
3954         (elf_get_probes): Likewise.  Update.
3955         (probe_key_free): Remove.
3956         (_initialize_elfread): Update.
3957         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3958         Change type.
3959         (dtrace_process_dof_probe, dtrace_process_dof)
3960         (dtrace_static_probe_ops::get_probe): Change type.
3961
3962 2019-05-08  Tom Tromey  <tom@tromey.com>
3963
3964         * xcoffread.c (struct xcoff_symfile_info): Rename from
3965         coff_symfile_info.  Add initializers.
3966         (xcoff_objfile_data_key): Move lower.  Change type.
3967         (XCOFF_DATA): Rewrite.
3968         (xcoff_free_info): Remove.
3969         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3970         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3971         (xcoff_initial_scan): Update.
3972
3973 2019-05-08  Tom Tromey  <tom@tromey.com>
3974
3975         * solib-svr4.c (struct svr4_info): Add initializers and
3976         destructor.
3977         <probes_table>: Now an htab_up.
3978         (solib_svr4_pspace_data): Change type.
3979         (free_probes_table): Simplify.
3980         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3981         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3982         (probes_table_remove_objfile_probes, register_solib_event_probe)
3983         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3984         (_initialize_svr4_solib): Update.
3985
3986 2019-05-08  Tom Tromey  <tom@tromey.com>
3987
3988         * remote.c (remote_pspace_data): Change type.
3989         (remote_pspace_data_cleanup): Remove.
3990         (get_remote_exec_file, set_pspace_remote_exec_file)
3991         (_initialize_remote): Update.
3992
3993 2019-05-08  Tom Tromey  <tom@tromey.com>
3994
3995         * breakpoint.c (breakpoint_objfile_key): Change type.
3996         (get_breakpoint_objfile_data): Update.
3997         (free_breakpoint_objfile_data): Remove.
3998         (_initialize_breakpoint): Update.
3999
4000 2019-05-08  Tom Tromey  <tom@tromey.com>
4001
4002         * linux-tdep.c (struct linux_info): Add initializers.
4003         (linux_inferior_data): Move.  Change type.
4004         (invalidate_linux_cache_inf): Update.
4005         (linux_inferior_data_cleanup): Remove.
4006         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4007
4008 2019-05-08  Tom Tromey  <tom@tromey.com>
4009
4010         * auxv.c (auxv_inferior_data): Move.  Change type.
4011         (auxv_inferior_data_cleanup): Remove.
4012         (invalidate_auxv_cache_inf): Rewrite.
4013         (get_auxv_inferior_data, _initialize_auxv): Update.
4014
4015 2019-05-08  Tom Tromey  <tom@tromey.com>
4016
4017         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4018         (symfile_debug_objfile_data_key): Change type.
4019         (symfile_debug_installed, debug_qf_has_symbols)
4020         (debug_qf_find_last_source_symtab)
4021         (debug_qf_forget_cached_source_info)
4022         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4023         (debug_qf_print_stats, debug_qf_dump)
4024         (debug_qf_expand_symtabs_for_function)
4025         (debug_qf_expand_all_symtabs)
4026         (debug_qf_expand_symtabs_with_fullname)
4027         (debug_qf_map_matching_symbols)
4028         (debug_qf_expand_symtabs_matching)
4029         (debug_qf_find_pc_sect_compunit_symtab)
4030         (debug_qf_map_symbol_filenames)
4031         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4032         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4033         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4034         (debug_sym_read_linetable, debug_sym_relocate): Update.
4035         (symfile_debug_free_objfile): Remove.
4036         (install_symfile_debug_logging, _initialize_symfile_debug):
4037         Update.
4038
4039 2019-05-08  Tom Tromey  <tom@tromey.com>
4040
4041         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4042         allocate_on_obstack.
4043         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4044         (get_dwarf2_per_objfile): Update.
4045         (set_dwarf2_per_objfile): Remove.
4046         (dwarf2_has_info, dwarf2_get_section_info): Update.
4047         (dwarf2_free_objfile): Remove.
4048         (_initialize_dwarf2_read): Update.
4049
4050 2019-05-08  Tom Tromey  <tom@tromey.com>
4051
4052         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4053         initializers.
4054         <unsupported_script_warning_printed,
4055         script_not_found_warning_printed>: Now bool.
4056         (auto_load_pspace_data): Change type.
4057         (~auto_load_pspace_info): Rename from
4058         auto_load_pspace_data_cleanup.
4059         (get_auto_load_pspace_data, init_loaded_scripts_info)
4060         (clear_section_scripts, maybe_print_unsupported_script_warning)
4061         (maybe_print_script_not_found_warning, _initialize_auto_load):
4062         Update.
4063
4064 2019-05-08  Tom Tromey  <tom@tromey.com>
4065
4066         * objfiles.c (objfile_pspace_info): Add destructor and
4067         initializers.
4068         (objfiles_pspace_data): Change type.
4069         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4070         (get_objfile_pspace_data): Update.
4071         (objfiles_bfd_data): Change type.
4072         (get_objfile_bfd_data): Update.
4073         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4074
4075 2019-05-08  Tom Tromey  <tom@tromey.com>
4076
4077         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4078         Change type.
4079         (get_catch_syscall_inferior_data): Update.
4080         (catch_syscall_inferior_data_cleanup): Remove.
4081         (_initialize_break_catch_syscall): Update.
4082
4083 2019-05-08  Tom Tromey  <tom@tromey.com>
4084
4085         * inflow.c (struct terminal_info): Add destructor and
4086         initializers.
4087         (inflow_inferior_data): Change type.
4088         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4089         (get_inflow_inferior_data, inflow_inferior_exit)
4090         (swap_terminal_info, _initialize_inflow): Update.
4091
4092 2019-05-08  Tom Tromey  <tom@tromey.com>
4093
4094         * target-dcache.c (target_dcache_cleanup): Remove.
4095         (target_dcache_aspace_key): Change type.
4096         (target_dcache_init_p, target_dcache_invalidate)
4097         (target_dcache_get, target_dcache_get_or_init)
4098         (_initialize_target_dcache): Update.
4099         * dcache.h (struct dcache_deleter): New.
4100
4101 2019-05-08  Tom Tromey  <tom@tromey.com>
4102
4103         * symtab.c (struct symbol_cache): Add destructor and
4104         initializers.
4105         (symbol_cache_key): Move.  Change type.
4106         (make_symbol_cache, free_symbol_cache): Remove.
4107         (get_symbol_cache): Update.
4108         (symbol_cache_cleanup): Remove.
4109         (ALL_PSPACES, symbol_cache_flush)
4110         (maintenance_print_symbol_cache)
4111         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4112         Update.
4113
4114 2019-05-08  Tom Tromey  <tom@tromey.com>
4115
4116         * symtab.c (struct main_info): Add destructor and initializers.
4117         (main_progspace_key): Move.  Change type.
4118         (get_main_info): Update.
4119         (main_info_cleanup): Remove.
4120         (_initialize_symtab): Update.
4121
4122 2019-05-08  Tom Tromey  <tom@tromey.com>
4123
4124         * registry.h (DECLARE_REGISTRY): Define the _key class.
4125
4126 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4127
4128         * NEWS: Merge two 'New commands' sections.
4129
4130 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4131
4132         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4133         parameter and use Ada language definition instead.
4134         (ada_val_print_ptr): Remove unused language parameter.
4135         (ada_val_print_num): Remove language parameter and use Ada language
4136         definition instead.
4137         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4138         parameter.
4139         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4140         parameter and use Ada language definition instead.
4141         (ada_val_print_1): Update all ada_val_print_xxx calls.
4142         Remove language parameter.
4143         (ada_val_print): Update ada_val_print_1 call.
4144
4145 2019-05-08  Tom Tromey  <tromey@adacore.com>
4146
4147         * remote.c (remote_hw_watchpoint_limit)
4148         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4149         Now static.
4150
4151 2019-05-08  Tom Tromey  <tromey@adacore.com>
4152
4153         * maint.c (_initialize_maint_cmds): Move initialization code to
4154         remote.c.
4155         (watchdog, show_watchdog): Move to remote.c.
4156         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4157         "watchdog" static.
4158         (_initialize_remote): Move initialization code from maint.c.
4159         * defs.h (watchdog): Don't declare.
4160
4161 2019-05-08  Tom Tromey  <tromey@adacore.com>
4162
4163         * tui/tui-interp.c: Include main.h.
4164         * interps.c: Include main.h.
4165         * main.h (interpreter_p): Declare.
4166         * defs.h (interpreter_p): Don't declare.
4167
4168 2019-05-08  Tom Tromey  <tromey@adacore.com>
4169
4170         * dwarf2loc.c: Include dwarf2read.h.
4171         * defs.h (read_unsigned_leb128): Don't declare.
4172         * dwarf2read.h (read_unsigned_leb128): Declare.
4173
4174 2019-05-08  Tom Tromey  <tromey@adacore.com>
4175
4176         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4177         method.
4178
4179 2019-05-08  Tom Tromey  <tromey@adacore.com>
4180
4181         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4182         when no wrap column is set.
4183
4184 2019-05-08  Tom Tromey  <tromey@adacore.com>
4185
4186         * c-lang.c (c_get_string): Handle non-C-style arrays.
4187
4188 2019-05-08  Tom Tromey  <tromey@adacore.com>
4189
4190         * typeprint.c (print_offset_data::update): Print the bit offset,
4191         not the number of bits remaining.
4192
4193 2019-05-08  Tom Tromey  <tromey@adacore.com>
4194
4195         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4196         padding at end of comment.
4197
4198 2019-05-08  Tom Tromey  <tromey@adacore.com>
4199
4200         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4201         Compare main types.
4202
4203 2019-05-06  Tom Tromey  <tom@tromey.com>
4204
4205         * common/scoped_mmap.c: Include common-defs.h.
4206         * common/scoped_mmap.h: Don't include config.h.
4207
4208 2019-05-04  Tom Tromey  <tom@tromey.com>
4209
4210         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4211         (struct aarch64_call_info): Add initializers.
4212         <si>: Now a std::vector.
4213         (pass_on_stack, aarch64_push_dummy_call): Update.
4214
4215 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4216             Tom Tromey  <tom@tromey.com>
4217
4218         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4219         (ppc_threads): Now a std::vector.  Now static.
4220         (hwdebug_find_thread_points_by_tid)
4221         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4222         Update.
4223
4224 2019-05-04  Tom Tromey  <tom@tromey.com>
4225
4226         * arc-tdep.c (arc_tdesc_init): Return bool.
4227
4228 2019-05-04  Tom Tromey  <tom@tromey.com>
4229
4230         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4231         Use gdb_assert_not_reached.
4232
4233 2019-05-04  Tom Tromey  <tom@tromey.com>
4234
4235         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4236         "false".
4237
4238 2019-05-04  Tom Tromey  <tom@tromey.com>
4239
4240         * arc-tdep.c (arc_tdesc_init): Use bool.
4241
4242 2019-05-04  Tom Tromey  <tom@tromey.com>
4243
4244         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4245
4246 2019-05-04  Tom Tromey  <tom@tromey.com>
4247
4248         * cli/cli-cmds.c (valid_command_p): Return bool.
4249
4250 2019-05-04  Tom Tromey  <tom@tromey.com>
4251
4252         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4253         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4254
4255 2019-05-04  Raul Tambre  <raul@tambre.ee>
4256
4257         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4258         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4259         operator for comparison.
4260
4261 2019-05-04  Tom Tromey  <tom@tromey.com>
4262
4263         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4264         (lookup_partial_symbol, print_partial_symbols)
4265         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4266         (psymbol_compare): Update.
4267         (add_psymbol_to_bcache): Clear the entire psymbol.
4268         (maintenance_check_psymtabs): Update.
4269         * psympriv.h (struct partial_symbol): Don't derive from
4270         general_symbol_info.
4271         <obj_section, unrelocated_address, address,
4272         set_unrelocated_address>: Update.
4273         <ginfo>: New member.
4274         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4275         (debug_names::write_psymbols): Update.
4276
4277 2019-05-04  Tom de Vries  <tdevries@suse.de>
4278
4279         * contrib/cc-with-tweaks.sh: Support -n arg.
4280
4281 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4282
4283         * corelow.c (core_target::detach): Ensure frame cache and
4284         register caches are cleared.
4285         inferior.c (exit_inferior_1): Likewise.
4286
4287 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4288             Tom Tromey  <tom@tromey.com>
4289
4290         * dictionary.c (collate_pending_symbols_by_language): Remove
4291         "struct" from foreach.
4292         * symtab.c (lookup_global_symbol_from_objfile)
4293         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4294         foreach.
4295         * ser-tcp.c (net_open): Remove "struct" from foreach.
4296         * objfiles.c (objfile_relocate, objfile_rebase)
4297         (objfile_has_symbols): Remove "struct" from foreach.
4298         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4299         from foreach.
4300         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4301         foreach.
4302         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4303         "struct" from foreach.
4304         * ada-lang.c (create_excep_cond_exprs)
4305         (ada_exception_catchpoint_cond_string): Remove "struct" from
4306         foreach.
4307
4308 2019-05-03  Tom Tromey  <tromey@adacore.com>
4309
4310         * ada-exp.y (convert_char_literal): Check suffix of each
4311         enumerator.
4312
4313 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4314
4315         PR ada/21406:
4316         * ada-exp.y (yywrap): Don't define.
4317         * ada-lex.l (%option): Add noyywrap
4318         (yywrap): Remove.
4319
4320 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4321
4322         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4323         _WIN32_WINNT to the XP level, unless already defined to a higher
4324         level.
4325
4326         * unittests/parse-connection-spec-selftests.c:
4327         * ser-tcp.c:
4328         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4329         override.
4330
4331         * symfile.c (find_separate_debug_file): Remove colon from the
4332         drive spec of DOS/Windows file names of the target, so that the
4333         file name produced from DEBUGDIR and the target's directory will
4334         be valid on DOS/Windows systems.
4335
4336 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4337
4338         * rust-lang.c (val_print_struct): Handle printing structures
4339         containing strings.
4340
4341 2019-05-02  Tom Tromey  <tromey@adacore.com>
4342
4343         * valarith.c (_initialize_valarith): Remove.
4344
4345 2019-05-01  Tom Tromey  <tromey@adacore.com>
4346
4347         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4348         bitfields.
4349
4350 2019-05-01  Tom Tromey  <tromey@adacore.com>
4351
4352         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4353         for big-endian copies.
4354
4355 2019-04-30  Ali Tamur  <tamur@google.com>
4356         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4357         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4358         (read_3_bytes): New function.
4359
4360 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4361
4362         * windows-nat.c (main_thread_id): Delete.
4363         (handle_output_debug_string): Replace main_thread_id by
4364         current_event.dwThreadId.
4365         (fake_create_process): Likewise.
4366         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4367         Do not set main_thread_id.
4368         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4369         current_event.dwThreadId.
4370         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4371
4372 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4373
4374         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4375         Use current_event.dwThreadId instead of main_thread_id.
4376
4377 2019-04-30  Tom Tromey  <tromey@adacore.com>
4378
4379         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4380         (create_excep_cond_exprs): Iterate over program spaces.
4381         (ada_exception_catchpoint_cond_string): Examine all minimal
4382         symbols for exception types.
4383
4384 2019-04-30  Tom Tromey  <tromey@adacore.com>
4385
4386         PR c++/24470:
4387         * dwarf2read.c (process_structure_scope): Handle case where type
4388         has template parameters but no symbol was created.
4389
4390 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4391             Chris January  <chris.january@arm.com>
4392
4393         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4394         qualifier.
4395         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4396
4397 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4398
4399         * f-typeprint.c (f_print_type): Update rules for printing
4400         whitespace.
4401         (f_type_print_varspec_suffix): Likewise.
4402
4403 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4404             Chris January  <chris.january@arm.com>
4405
4406         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4407         function arguments.
4408
4409 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4410
4411         * f-lang.c (build_fortran_types): Change name of void type to
4412         lower case.
4413         * f-typeprint.c (f_type_print_base): Print the name of the void
4414         type, rather than a fixed string.
4415         * f-valprint.c (f_decorations): Use lower case void string.
4416
4417 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4418             Chris January  <chris.january@arm.com>
4419
4420         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4421         types for Fortran.
4422
4423 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4424             Chris January  <chris.january@arm.com>
4425             David Lecomber  <david.lecomber@arm.com>
4426
4427         * f-exp.y (BINOP_INTRINSIC): New token.
4428         (exp): New parser rule handling BINOP_INTRINSIC.
4429         (f77_keywords): Add new builtin procedures.
4430         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4431         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4432         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4433         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4434         (print_unop_subexp_f): New function.
4435         (print_binop_subexp_f): New function.
4436         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4437         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4438         (dump_subexp_body_f): Likewise.
4439         (operator_check_f): Likewise.
4440         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4441         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4442
4443 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4444
4445         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4446         UNOP_KIND.
4447         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4448         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4449         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4450         (operator_length_f): New fuction.
4451         (print_subexp_f): New function.
4452         (op_name_f): New function.
4453         (dump_subexp_body_f): New function.
4454         (operator_check_f): New function.
4455         (exp_descriptor_f): Replace standard expression handling functions
4456         with new functions.
4457         * gdb/fortran-operator.def: New file.
4458         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4459         * gdb/std-operator.def: Remove UNOP_KIND.
4460
4461 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4462
4463         * std-operator.def: Remove unbalanced, stray double quote
4464         character.
4465
4466 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4467             Chris January  <chris.january@arm.com>
4468             Daniel Everett  <daniel.everett@arm.com>
4469             Nick Forrington  <nick.forrington@arm.com>
4470             Richard Bunt  <richard.bunt@arm.com>
4471
4472         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4473         of depth when printing anonymous structs or unions.
4474         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4475         Don't print either the top-level value, or the children if the
4476         max-depth is exceeded.
4477         (ppscm_print_children): When printing the key of a map, allow one
4478         extra level of depth.
4479         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4480         print either the top-level value, or the children if the max-depth
4481         is exceeded.
4482         (print_children): When printing the key of a map, allow one extra
4483         level of depth.
4484         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4485         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4486         (user_print_options): Initialise max_depth field.
4487         (val_print_scalar_or_string_type_p): New function.
4488         (val_print): Check to see if the max depth has been reached.
4489         (val_print_check_max_depth): Define new function.
4490         (show_print_max_depth): New function.
4491         (_initialize_valprint): Add 'print max-depth' option.
4492         * valprint.h (struct value_print_options) <max_depth>: New field.
4493         (val_print_check_max_depth): Declare new function.
4494         * NEWS: Document new feature.
4495
4496 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4497
4498         * ada-lang.c (ada_language_defn): Initialise new field.
4499         * c-lang.c (c_is_string_type_p): New function.
4500         (c_language_defn): Initialise new field.
4501         (cplus_language_defn): Initialise new field.
4502         (asm_language_defn): Initialise new field.
4503         (minimal_language_defn): Initialise new field.
4504         * c-lang.h (c_is_string_type_p): Declare new function.
4505         * d-lang.c (d_language_defn): Initialise new field.
4506         * f-lang.c (f_is_string_type_p): New function.
4507         (f_language_defn): Initialise new field.
4508         * go-lang.c (go_is_string_type_p): New function.
4509         (go_language_defn): Initialise new field.
4510         * language.c (default_is_string_type_p): New function.
4511         (unknown_language_defn): Initialise new field.
4512         (auto_language_defn): Initialise new field.
4513         * language.h (struct language_defn) <la_is_string_type_p>: New
4514         member variable.
4515         (default_is_string_type_p): Declare new function.
4516         * m2-lang.c (m2_language_defn): Initialise new field.
4517         * objc-lang.c (objc_language_defn): Initialise new field.
4518         * opencl-lang.c (opencl_language_defn): Initialise new field.
4519         * p-lang.c (pascal_is_string_type_p): New function.
4520         (pascal_language_defn): Initialise new field.
4521         * rust-lang.c (rust_is_string_type_p): New function.
4522         (rust_language_defn): Initialise new field.
4523
4524 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4525
4526         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4527         New field.
4528         * ada-lang.c (ada_language_defn): Initialise new field.
4529         * c-lang.c (c_language_defn): Likewise.
4530         (cplus_language_defn): Likewise.
4531         (asm_language_defn): Likewise.
4532         (minimal_language_defn): Likewise.
4533         * d-lang.c (d_language_defn): Likewise.
4534         * f-lang.c (f_language_defn): Likewise.
4535         * go-lang.c (go_language_defn): Likewise.
4536         * language.c (unknown_language_defn): Likewise.
4537         (auto_language_defn): Likewise.
4538         * m2-lang.c (m2_language_defn): Likewise.
4539         * objc-lang.c (objc_language_defn): Likewise.
4540         * opencl-lang.c (opencl_language_defn): Likewise.
4541         * p-lang.c (pascal_language_defn): Likewise.
4542         * rust-lang.c (rust_language_defn): Likewise.
4543
4544 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4545
4546         * ada-lang.c (ada_is_character_type): Change return type to bool.
4547         (ada_is_string_type): Likewise.
4548         * ada-lang.h (ada_is_character_type): Update declaration
4549         (ada_is_string_type): Likewise.
4550
4551 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4552
4553         Support style in 'frame|thread apply'
4554
4555         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4556         * record.c (record_start, record_stop): Update callers of
4557         execute_command_to_string with false.
4558         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4559         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4560         methods.
4561         (class string_file): New constructor with term_out parameter.
4562         Override methods term_out and can_emit_style_escape.  New member
4563         term_out.
4564         (class stdio_file): Override can_emit_style_escape.
4565         (class tee_file): Override term_out and can_emit_style_escape.
4566         * utils.h (can_emit_style_escape): Remove.
4567         * utils.c (can_emit_style_escape): Likewise.
4568         Update all callers of can_emit_style_escape (SOMESTREAM) to
4569         SOMESTREAM->can_emit_style_escape.
4570         * source-cache.c (source_cache::get_source_lines): Likewise.
4571         * stack.c (frame_apply_command_count): Call execute_command_to_string
4572         passing the term_out characteristic of the current gdb_stdout.
4573         * thread.c (thr_try_catch_cmd): Likewise.
4574         * top.c (execute_command_to_string): pass term_out parameter
4575         to construct the string_file for the command output.
4576         * ui-file.c (term_cli_styling): New function (most code moved
4577         from utils.c can_emit_style_escape).
4578         (string_file::string_file, string_file::can_emit_style_escape,
4579         stdio_file::can_emit_style_escape, tee_file::term_out,
4580         tee_file::can_emit_style_escape): New functions.
4581
4582 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4583
4584         * NEWS: Mention the new set|show may-call-functions.
4585         * infcall.c (may_call_functions_p): New variable.
4586         (show_may_call_functions_p): New function.
4587         (call_function_by_hand_dummy): Throws an error if not
4588         may-call-functions.
4589         (_initialize_infcall): Call add_setshow_boolean_cmd for
4590         may-call-functions.
4591
4592 2019-04-25  Keith Seitz  <keiths@redhat.com>
4593
4594         PR c++/24367
4595         * cp-support.c (inspect_type): Don't attempt substitutions
4596         of symbol with the same name.
4597
4598 2019-04-25  Tom Tromey  <tromey@adacore.com>
4599
4600         PR gdb/24475:
4601         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4602         static.
4603
4604 2019-04-25  Tom Tromey  <tromey@adacore.com>
4605
4606         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4607         rvalue reference.
4608         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4609         (gdb_xml_parser::parse): Use std::move.
4610         * python/python-internal.h (gdbpy_convert_exception): Take a const
4611         reference.
4612         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4613         std::move.
4614         * python/py-utils.c (gdbpy_convert_exception): Take a const
4615         reference.
4616         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4617         Use std::move.
4618         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4619         Use std::move.
4620         * mi/mi-main.c (mi_print_exception): Take a const reference.
4621         * main.c (handle_command_errors): Take a const reference.
4622         * linespec.c (parse_linespec): Use std::move.
4623         * infcall.c (run_inferior_call): Use std::move.
4624         (call_function_by_hand_dummy): Use std::move.
4625         * exec.c (try_open_exec_file): Use std::move.
4626         * exceptions.h (exception_print, exception_fprintf)
4627         (exception_print_same): Update.
4628         * exceptions.c (print_exception, exception_print)
4629         (exception_fprintf, exception_print_same): Change parameters to
4630         const reference.
4631         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4632         * common/new-op.c: Use std::move.
4633         * common/common-exceptions.h (struct gdb_exception): Add move
4634         constructor.
4635         (struct gdb_exception_error, struct gdb_exception_quit, struct
4636         gdb_quit_bad_alloc): Change constructor to move constructor.
4637         (throw_exception): Change parameter to rvalue reference.
4638         * common/common-exceptions.c (throw_exception): Take rvalue
4639         reference.
4640         * cli/cli-interp.c (safe_execute_command): Use std::move.
4641         * breakpoint.c (insert_bp_location, location_to_sals): Use
4642         std::move.
4643
4644 2019-04-25  Tom Tromey  <tromey@adacore.com>
4645
4646         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4647         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4648         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4649         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4650         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4651         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4652         guile/scm-value.c: Use unpack.
4653         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4654         gdbscm_gdb_exception.
4655         (gdbscm_throw_gdb_exception): Likewise.
4656         (struct gdbscm_gdb_exception): New.
4657         (unpack): New function.
4658         (gdbscm_wrap): Use unpack.
4659
4660 2019-04-25  Tom Tromey  <tromey@adacore.com>
4661
4662         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4663         (gdb_rl_callback_handler): Use std::move.
4664         * common/common-exceptions.h (struct gdb_exception): Add move
4665         assignment operator.
4666         (throw_exception_sjlj): Change "exception" to const reference.
4667         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4668         (throw_exception_sjlj): Change "exception" to const reference.
4669
4670 2019-04-25  Tom Tromey  <tromey@adacore.com>
4671
4672         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4673         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4674         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4675         Update.
4676         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4677         Update.
4678         * mi/mi-interp.c (mi_interp::exec): Update.
4679         * linespec.c (parse_linespec): Update.
4680         * infcall.c (run_inferior_call): Update.
4681         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4682         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4683         (gdbscm_lookup_global_symbol): Update.
4684         * guile/scm-param.c (gdbscm_parameter_value): Update.
4685         * guile/scm-frame.c (gdbscm_frame_read_register)
4686         (gdbscm_frame_read_var): Update.
4687         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4688         * exec.c (try_open_exec_file): Update.
4689         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4690         (gdb_rl_callback_handler): Update.
4691         * common/common-exceptions.h (exception_none): Don't declare.
4692         * common/common-exceptions.c (exception_none): Don't define.
4693         (struct catcher) <exception>: Update.
4694         * cli/cli-interp.c (safe_execute_command): Update.
4695         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4696
4697 2019-04-25  Ali Tamur  <tamur@google.com>
4698
4699         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4700         (read_attribute_value): Likewise.
4701         (dwarf2_read_addr_index): Update comment.
4702         (read_str_index): Add DW_FORM_strx.
4703         (dwarf2_string_attr): Likewise.
4704         (dwarf2_const_value_attr): Likewise.
4705         (dump_die_shallow): Likewise.
4706         (dwarf2_fetch_constant_bytes): Likewise.
4707         (skip_form_bytes): Likewise.
4708         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4709
4710 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4711
4712         PR corefiles/11608
4713         PR corefiles/18187
4714         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4715         OFFSET.  Verify if current mapping contains an ELF header.
4716         (linux_find_memory_regions_full): Adjust call to
4717         dump_mapping_p.
4718
4719 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4720             Kang Li <kanglictf@gmail.com>
4721
4722         PR gdb/21600
4723
4724         * dwarf2-frame.c (read_initial_length): Be consistent about using
4725         unsigned representation of length.
4726         (decode_frame_entry_1): Likewise.  Check for wraparound of
4727         end pointer as well as buffer overflow.
4728
4729 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4730
4731         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4732         "vq".
4733
4734 2019-04-24  Tom Tromey  <tromey@adacore.com>
4735
4736         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4737
4738 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4739
4740         * s12z-tdep.c (s12z_unwind_pc): Delete.
4741         (s12z_unwind_sp): Delete.
4742         (s12z_gdbarch_init): Don't register deleted functions with
4743         gdbarch.
4744
4745 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4746
4747         * rl78-tdep.c (rl78_unwind_sp): Delete.
4748         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4749
4750 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4751
4752         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4753         (xstormy16_unwind_pc): Delete.
4754         (xstormy16_dummy_id): Delete.
4755         (xstormy16_gdbarch_init): Don't register deleted functions with
4756         gdbarch.
4757
4758 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4759
4760         * vax-tdep.c (vax_unwind_pc): Delete.
4761         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4762
4763 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4764
4765         * v850-tdep.c (v850_unwind_sp): Delete.
4766         (v850_unwind_pc): Delete.
4767         (v850_dummy_id): Delete.
4768         (v850_gdbarch_init): Don't register deleted functions with
4769         gdbarch.
4770
4771 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4772
4773         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4774         (tilegx_unwind_pc): Delete.
4775         (tilegx_unwind_dummy_id): Delete.
4776         (tilegx_gdbarch_init): Don't register deleted functions with
4777         gdbarch.
4778
4779 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4780
4781         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4782         (tic6x_dummy_id): Delete.
4783         (tic6x_gdbarch_init): Don't register deleted functions with
4784         gdbarch.
4785
4786 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4787
4788         * sparc-tdep.c (sparc_unwind_pc): Delete.
4789         (sparc32_gdbarch_init): Don't register deleted function with
4790         gdbarch.
4791
4792 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4793
4794         * sh-tdep.c (sh_unwind_sp): Delete.
4795         (sh_unwind_pc): Delete.
4796         (sh_dummy_id): Delete.
4797         (sh_gdbarch_init): Don't register deleted functions with
4798         gdbarch.
4799
4800 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4801
4802         * score-tdep.c (score_unwind_sp): Delete.
4803         (score_unwind_pc): Delete.
4804         (score_dummy_id): Delete.
4805         (score_gdbarch_init): Don't register deleted functions with
4806         gdbarch.
4807
4808 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4809
4810         * rx-tdep.c (rx_unwind_pc): Delete.
4811         (rx_unwind_sp): Delete.
4812         (rx_dummy_id): Delete.
4813         (rx_gdbarch_init): Don't register deleted functions with
4814         gdbarch.  Update comment.
4815
4816 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4817
4818         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4819         (rs6000_dummy_id): Delete.
4820         (rs6000_gdbarch_init): Don't register deleted functions with
4821         gdbarch.
4822
4823 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4824
4825         * or1k-tdep.c (or1k_dummy_id): Delete.
4826         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4827
4828 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4829
4830         * nios2-tdep.c (nios2_dummy_id): Delete.
4831         (nios2_unwind_sp): Delete.
4832         (nios2_gdbarch_init): Don't register deleted functions with
4833         gdbarch.
4834
4835 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4836
4837         * nds32-tdep.c (nds32_dummy_id): Delete.
4838         (nds32_unwind_pc): Delete.
4839         (nds32_unwind_sp): Delete.
4840         (nds32_gdbarch_init): Don't register deleted functions with
4841         gdbarch.
4842
4843 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4844
4845         * msp430-tdep.c (msp430_unwind_pc): Delete.
4846         (msp430_unwind_sp): Delete.
4847         (msp430_dummy_id): Delete.
4848         (msp430_gdbarch_init): Don't register deleted functions with
4849         gdbarch.
4850
4851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4852
4853         * moxie-tdep.c (moxie_unwind_sp): Delete.
4854         (moxie_unwind_pc): Delete.
4855         (moxie_dummy_id): Delete.
4856         (moxie_gdbarch_init): Don't register deleted functions with
4857         gdbarch.
4858
4859 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4860
4861         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4862         (mn10300_unwind_pc): Delete.
4863         (mn10300_unwind_sp): Delete.
4864         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4865         mn10300_unwind_sp.
4866         (mn10300_frame_unwind_init): Don't register deleted functions with
4867         gdbarch.
4868
4869 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4870
4871         * mep-tdep.c (mep_unwind_pc): Delete.
4872         (mep_unwind_sp): Delete.
4873         (mep_dummy_id): Delete.
4874         (mep_gdbarch_init): Don't register deleted functions with
4875         gdbarch.
4876
4877 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4878
4879         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4880         (m68hc11_unwind_sp): Delete.
4881         (m68hc11_gdbarch_init): Don't register deleted functions with
4882         gdbarch.
4883
4884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4885
4886         * m32r-tdep.c (m32r_unwind_sp): Delete.
4887         (m32r_unwind_pc): Delete.
4888         (m32r_dummy_id): Delete.
4889         (m32r_gdbarch_init): Don't register deleted functions with
4890         gdbarch.
4891
4892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4893
4894         * m32c-tdep.c (m32c_unwind_pc): Delete.
4895         (m32c_unwind_sp): Delete.
4896         (m32c_dummy_id): Delete.
4897         (m32c_gdbarch_init): Don't register deleted functions with
4898         gdbarch.
4899
4900 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4901
4902         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4903         (lm32_unwind_pc): Delete.
4904         (lm32_dummy_id): Delete.
4905         (lm32_gdbarch_init): Don't register deleted functions with
4906         gdbarch.
4907
4908 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4909
4910         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4911         (iq2000_unwind_pc): Delete.
4912         (iq2000_dummy_id): Delete.
4913         (iq2000_gdbarch_init): Don't register deleted functions with
4914         gdbarch.
4915
4916 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4917
4918         * nds32-tdep.c (nds32_type_align): Delete.
4919         (nds32_push_dummy_call): Use type_align instead.
4920
4921 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4922
4923         * arm-tdep.c (arm_type_align): Only handle vector override case.
4924         (arm_push_dummy_call): Use type_align.
4925         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4926
4927 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4928
4929         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4930         case.
4931         (pass_on_stack): Use type_align.
4932         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4933         function.
4934
4935 2019-04-23  Tom Tromey  <tromey@adacore.com>
4936
4937         * dwarf2read.c (line_header::file_name_at): Remove unused
4938         overload.
4939
4940 2019-04-23  Tom de Vries  <tdevries@suse.de>
4941
4942         PR gdb/24438
4943         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4944         invocation.
4945
4946
4947 2019-03-27  Ali Tamur  <tamur@google.com>
4948
4949         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4950         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4951         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4952         (dwarf_expr_context::get_addr_index): Likewise
4953         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4954         (symbol_needs_eval_context::get_addr_index): Likewise
4955         (disassemble_dwarf_expression): Add DW_OP_addrx
4956         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4957         (read_cutu_die_from_dwo): Update comment
4958         (skip_one_die): Add DW_FORM_addrx
4959         (read_attribute_value): Likewise
4960         (var_decode_location): Add DW_OP_addrx
4961         (dwarf2_const_value_attr): Add DW_FORM_addrx
4962         (dump_die_shallow): Likewise
4963         (dwarf2_fetch_constant_bytes): Likewise
4964         (decode_locdesc): Add DW_OP_addrx
4965         (skip_form_bytes): Add DW_FORM_addrx
4966
4967 2019-04-22  Ali Tamur  <tamur@google.com>
4968
4969         * MAINTAINERS (Write After Approval): Add self.
4970
4971 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4972
4973         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4974         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4975         (open_symbol_file_object): Likewise.
4976         (svr4_default_sos): Add info parameter.
4977         (svr4_read_so_list): Likewise.
4978         (svr4_current_sos_direct): Adjust functions calls to pass down
4979         info.
4980         (svr4_current_sos_1): Add info parameter.
4981         (svr4_current_sos): Call get_svr4_info, pass info down to
4982         svr4_current_sos_1.
4983         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4984         get_svr4_info.
4985         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4986         get_svr4_info.
4987         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4988         to get_svr4_info.
4989         (probes_table_remove_objfile_probes): Likewise.
4990         (register_solib_event_probe): Add info parameter.
4991         (solist_update_incremental): Pass info parameter down to
4992         svr4_read_so_list.
4993         (disable_probes_interface): Add info parameter.
4994         (svr4_handle_solib_event): Pass current_program_space to
4995         get_svr4_info.  Adjust disable_probes_interface cleanup.
4996         (svr4_create_probe_breakpoints): Add info parameter, pass it
4997         down to register_solib_event_probe.
4998         (svr4_create_solib_event_breakpoints): Add info parameter,
4999         pass it down to svr4_create_probe_breakpoints.
5000         (enable_break): Pass info down to
5001         svr4_create_solib_event_breakpoints.
5002         (svr4_solib_create_inferior_hook): Pass current_program_space to
5003         get_svr4_info.
5004         (svr4_clear_solib): Likewise.
5005
5006 2019-04-22  Pedro Alves  <palves@redhat.com>
5007
5008         * solib-svr4.c (svr4_free_objfile_observer): New.
5009         (probe_and_action::objfile): New field.
5010         (probes_table_htab_remove_objfile_probes)
5011         (probes_table_remove_objfile_probes): New functions.
5012         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5013         in the new probe_and_action.  Don't store the probe in 'lookup'.
5014         (svr4_create_probe_breakpoints): Pass objfile to
5015         register_solib_event_probe.
5016         (_initialize_svr4_solib): Register a free_objfile observer.
5017
5018 2019-04-19  Tom Tromey  <tom@tromey.com>
5019
5020         * common/queue.h: Remove.
5021
5022 2019-04-19  Tom Tromey  <tom@tromey.com>
5023
5024         * event-loop.c: Don't include "common/queue.h".
5025
5026 2019-04-19  Tom Tromey  <tom@tromey.com>
5027
5028         * remote.c (remote_target): Use delete.
5029         * remote-notif.h: Include <list>, not "common/queue.h".
5030         (notif_client_p): Remove typedef.
5031         (remote_notif_state): Add constructor, destructor, initializer.
5032         <notif_queue>: Now a std::list.
5033         (remote_notif_state_xfree): Don't declare.
5034         * remote-notif.c (remote_notif_process, handle_notification)
5035         (remote_notif_state_allocate): Update.
5036         (~remote_notif_state): Rename from remote_notif_state_xfree.
5037
5038 2019-04-19  Tom Tromey  <tom@tromey.com>
5039
5040         * symfile.c (reread_symbols): Update.
5041         * objfiles.c (objfile_register_static_link)
5042         (objfile_lookup_static_link): Update
5043         (~objfile) Don't delete static_links.
5044         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5045
5046 2019-04-19  Tom Tromey  <tom@tromey.com>
5047
5048         * type-stack.h (struct type_stack) <insert>: Constify string.
5049         * type-stack.c (type_stack::insert): Constify string.
5050         * gdbtypes.h (lookup_template_type): Update.
5051         (address_space_name_to_int): Update.
5052         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5053         const.
5054         (lookup_template_type): Make name const.
5055         * c-exp.y: Update rules.
5056         (lex_one_token, classify_name, classify_inner_name)
5057         (c_print_token): Update.
5058         * p-exp.y: Update rules.
5059         (yylex): Update.
5060         * f-exp.y: Update rules.
5061         (yylex): Update.
5062         * d-exp.y: Update rules.
5063         (lex_one_token, classify_name, classify_inner_name): Update.
5064         * parse.c (write_dollar_variable, copy_name): Return std::string.
5065         * parser-defs.h (copy_name): Change return type.
5066         * m2-exp.y: Update rules.
5067         (yylex): Update.
5068         * go-exp.y (lex_one_token): Update.
5069         Update rules.
5070         (classify_unsafe_function, classify_packaged_name)
5071         (classify_name, yylex): Update.
5072
5073 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5074
5075         * configure.ac: add --enable-source-highlight switch.
5076         * configure: Regenerate.
5077         * top.c (print_gdb_version): plumb --enable-source-highlight
5078         status to "show configuration".
5079
5080 2019-04-19  Tom Tromey  <tromey@adacore.com>
5081
5082         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5083         Check ADA_TYPE_P.
5084         (empty_record, ada_template_to_fixed_record_type_1)
5085         (template_to_static_fixed_type)
5086         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5087         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5088         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5089         macros.
5090
5091 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5092
5093         PR symtab/24423:
5094         * source.c (print_source_lines_base): Advance "iter" when a
5095         control character is seen.
5096
5097 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5098
5099         * inferior.h (struct infcall_suspend_state_deleter):
5100         Catch exception in destructor to avoid crash.
5101
5102 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5103
5104         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5105         close to the add_com "shell".
5106
5107 2019-04-18  Tom Tromey  <tromey@adacore.com>
5108
5109         * process-stratum-target.h (class process_stratum_target)
5110         <stratum>: Add "final".
5111
5112 2019-04-17  Tom Tromey  <tromey@adacore.com>
5113
5114         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5115         against nullptr before use.
5116
5117 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5118
5119         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5120
5121 2019-04-17  Jim Wilson  <jimw@sifive.com>
5122             Andrew Burgess  <andrew.burgess@embecosm.com>
5123
5124         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5125         code read might fail, assume 4-byte breakpoint in that case.
5126
5127 2019-04-15  Leszek Swirski  <leszeks@google.com>
5128
5129         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5130         rather than a hand-rolled POD check when checking for forced MEMORY
5131         classification.
5132
5133 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5134
5135         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5136         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5137         function.
5138         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5139         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5140         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5141         declaration.
5142
5143 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5144
5145         * aarch64-linux-nat.c
5146         (aarch64_linux_nat_target::thread_architecture): Add override.
5147         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5148         each VQ.
5149
5150 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5151
5152         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5153
5154 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5155
5156         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5157         target types of size 96-bits, add some additional comments, and
5158         check that the builtin type we found was the correct size.
5159
5160 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5161
5162         * utils.c (prompt_for_continue): Don't restore the styling at the
5163         end, as applied_style has the wrong value.  This fixes styling in
5164         long lists of file names that are interrupted by the "Continue?"
5165         prompt.
5166
5167 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5168
5169         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5170         * c-lang.c (c_language_defn): Likewise.
5171         (cplus_language_defn): Likewise.
5172         (asm_language_defn): Likewise.
5173         (minimal_language_defn): Likewise.
5174         * d-lang.c (d_language_defn): Likewise.
5175         * f-lang.c (f_language_defn): Likewise.
5176         * go-lang.c (go_language_defn): Likewise.
5177         * language.c (unknown_language_defn): Likewise.
5178         (auto_language_defn): Likewise.
5179         * language.h (struct language_defn): Remove la_magic field.
5180         (LANG_MAGIC): Delete.
5181         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5182         * objc-lang.c (objc_language_defn): Likewise.
5183         * opencl-lang.c (opencl_language_defn): Likewise.
5184         * p-lang.c (pascal_language_defn): Likewise.
5185         * rust-lang.c (rust_language_defn): Likewise.
5186
5187 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5188
5189         * riscv-tdep.c (riscv_type_align): New function.
5190         (riscv_type_alignment): Delete.
5191         (riscv_arg_location): Use 'type_align'.
5192         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5193
5194 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5195
5196         * gdbtypes.c (type_align): A struct with no non-static fields also
5197         has alignment of 1.
5198
5199 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5200
5201         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5202         component to 0.
5203         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5204         member.
5205         (riscv_struct_info::analyse): New implementation using new
5206         analyse_inner member function.
5207         (riscv_struct_info::field_offset): New member function.
5208         (riscv_struct_info::m_offsets): New member variable.
5209         (riscv_struct_info::analyse_inner): New private member function,
5210         takes the old implementation of riscv_struct_info::analyse but
5211         extended to track field offsets.
5212         (riscv_call_arg_struct): Update the struct folding special cases
5213         to handle cases where empty C++ structs, which are non-zero
5214         length, are found.
5215         (riscv_arg_location): Initialise the length of each location, a
5216         non-zero length now indicates the location is in use.
5217         (riscv_push_dummy_call): Allow for the first location having a
5218         non-zero offset when setting up arguments.
5219         (riscv_return_value): Likewise, but for return values.
5220
5221 2019-04-11  Tom Tromey  <tromey@adacore.com>
5222
5223         * utils.c (internal_vproblem): Make "msg" const.
5224
5225 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5226
5227         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5228         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5229         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5230         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5231
5232 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5233
5234         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5235         function.
5236         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5237         of amd64_collect_native_gregset.
5238         (amd64_linux_nat_target::store_registers): Likewise.
5239
5240 2019-04-10  Tom Tromey  <tom@tromey.com>
5241
5242         * symtab.c (lookup_global_symbol_from_objfile)
5243         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5244         * objfiles.h (class separate_debug_iterator): New.
5245         (class separate_debug_range): New.
5246         (struct objfile) <separate_debug_objfiles>: New method.
5247         (objfile_separate_debug_iterate): Don't declare.
5248         * objfiles.c (separate_debug_iterator::operator++): Rename from
5249         objfile_separate_debug_iterate.
5250         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5251         iterator.
5252         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5253         iterator.
5254
5255 2019-04-10  Tom Tromey  <tom@tromey.com>
5256
5257         * symfile.c (reread_symbols): Remove old comment.
5258         * objfiles.c (free_all_objfiles): Fix a typo.
5259
5260 2019-04-10  Tom Tromey  <tom@tromey.com>
5261
5262         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5263         * minsyms.c (lookup_minimal_symbol): Use foreach.
5264         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5265         (lookup_minimal_symbol_solib_trampoline): Likewise.
5266         * symfile.c (reread_symbols): Use foreach.
5267
5268 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5269             Tom Tromey  <tromey@adacore.com>
5270
5271         PR rust/24414:
5272         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5273         (rust_lex_int_test): Change "value" to be LONGEST.
5274         (rust_lex_tests): Add test for long integer literal.
5275
5276 2019-04-09  Tom Tromey  <tromey@adacore.com>
5277
5278         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5279         to bool.
5280         (extended_remote_target::attach): Update.
5281         (remote_target::remote_notice_new_inferior): Update.
5282         (remote_target::add_current_inferior_and_thread): Update.
5283         * inferior.c (exit_inferior_1): Use "false".
5284         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5285
5286 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5287
5288         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5289         the "start" command.
5290
5291 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5292
5293         * python/py-inferior.c (infpy_thread_from_thread_handle):
5294         Adjust comments to reflect renaming of thread_from_thread_handle
5295         to thread_from_handle.  Adjust keywords.  Fix type error message.
5296         (inferior_object_methods): Add thread_from_handle.  Retain
5297         thread_from_thread_handle, but mark it as deprecated.
5298
5299 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5300
5301         * gdbthread.h (find_thread_by_handle): Revise declaration.
5302         * thread.c (find_thread_by_handle): Likewise.  Adjust
5303         implementation too.
5304         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5305         support for buffer objects as handles.
5306
5307 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5308
5309         * python/py-infthread.c (thpy_thread_handle): New function.
5310         (thread_object_methods): Register thpy_thread_handle.
5311
5312 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5313
5314         * gdbthread.h (thread_to_thread_handle): Declare.
5315         * thread.c (gdbtypes.h): Include.
5316         (thread_to_thread_handle): New function.
5317
5318         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5319         (target_thread_info_to_thread_handle): Declare.
5320         * target.c (target_thread_info_to_thread_handle): New function.
5321         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5322         * target-delegates.c: Regenerate.
5323
5324         * linux-thread-db.c (class thread_db_target): Add method
5325         thread_info_to_thread_handle.
5326         (thread_db_target::thread_info_to_thread_handle): Define.
5327         * remote.c (class remote_target): Add new method
5328         thread_info_to_thread_handle.
5329         (remote_target::thread_info_to_thread_handle): Define.
5330
5331 2019-04-08  Pedro Alves  <palves@redhat.com>
5332
5333         * common/common-exceptions.c (throw_exception): Don't create
5334         named object to throw; throw directly.
5335         (throw_it): Likewise.  Don't initialize gdb_exception::message
5336         here, with new; pass FMT and AP to the ctor instead.
5337         * common/common-exceptions.h: Include <string>.
5338         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5339         const char *, va_list)): New ctor.  Use std::make_shared.
5340         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5341         errors)): Delete.
5342         (gdb_exception_error::gdb_exception_error(enum errors, const char
5343         *, va_list)): New.
5344         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5345         Add assertion.
5346         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5347         errors)): Delete.
5348         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5349         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5350         Add assertion.
5351
5352 2019-04-08  Tom Tromey  <tom@tromey.com>
5353
5354         * valops.c (value_rtti_indirect_type): Replace throw_exception
5355         with throw.
5356         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5357         with throw.
5358         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5359         throw.
5360         * target.c (target_translate_tls_address): Replace throw_exception
5361         with throw.
5362         * stack.c (frame_apply_command_count): Replace throw_exception
5363         with throw.
5364         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5365         throw.
5366         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5367         with throw.
5368         * rs6000-tdep.c (rs6000_frame_cache)
5369         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5370         * remote.c: Replace throw_exception with throw.
5371         * record-full.c (record_full_message, record_full_wait_1)
5372         (record_full_restore): Replace throw_exception with throw.
5373         * record-btrace.c:
5374         (get_thread_current_frame_id, record_btrace_start_replaying)
5375         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5376         (cmd_record_btrace_start): Replace throw_exception with throw.
5377         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5378         throw.
5379         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5380         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5381         * linespec.c:
5382         (find_linespec_symbols): Replace throw_exception with throw.
5383         * infrun.c (displaced_step_prepare, resume): Replace
5384         throw_exception with throw.
5385         * infcmd.c (post_create_inferior): Replace throw_exception with
5386         throw.
5387         * inf-loop.c (inferior_event_handler): Replace throw_exception
5388         with throw.
5389         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5390         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5391         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5392         (get_prev_frame_always, get_frame_pc_if_available)
5393         (get_frame_address_in_block_if_available, get_frame_language):
5394         Replace throw_exception with throw.
5395         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5396         throw_exception with throw.
5397         * eval.c (fetch_subexp_value, evaluate_var_value)
5398         (evaluate_funcall, evaluate_subexp_standard): Replace
5399         throw_exception with throw.
5400         * dwarf2loc.c (call_site_find_chain)
5401         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5402         Replace throw_exception with throw.
5403         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5404         with throw.
5405         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5406         throw.
5407         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5408         * completer.c (complete_line_internal): Replace throw_exception
5409         with throw.
5410         * compile/compile-object-run.c (compile_object_run): Replace
5411         throw_exception with throw.
5412         * cli/cli-script.c (process_next_line): Replace throw_exception
5413         with throw.
5414         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5415         (btrace_enable, btrace_maint_update_pt_packets): Replace
5416         throw_exception with throw.
5417         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5418         throw_exception with throw.
5419         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5420         throw_exception with throw.
5421         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5422         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5423         * aarch64-tdep.c (aarch64_make_prologue_cache)
5424         (aarch64_make_stub_cache): Replace throw_exception with throw.
5425
5426 2019-04-08  Tom Tromey  <tom@tromey.com>
5427
5428         * common/common-exceptions.c (throw_exception): Rename from
5429         throw_exception_cxx.  Remove old copy.  Make argument const.
5430         (throw_it): Create and throw exception objects directly.
5431         * common/common-exceptions.h (throw_exception): Make argument
5432         const.
5433         (struct gdb_exception_error): Add constructor.
5434         (struct gdb_exception_quit): Add constructor.
5435
5436 2019-04-08  Tom Tromey  <tom@tromey.com>
5437
5438         * common/common-exceptions.h (exception_rethrow): Don't declare.
5439         (TRY_SJLJ): Update comment.
5440         (TRY, CATCH, END_CATCH): Remove.
5441         * common/common-exceptions.c (exception_rethrow): Remove.
5442
5443 2019-04-08  Tom Tromey  <tom@tromey.com>
5444
5445         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5446         Remove.
5447         (gdb_exception_error): Rename from
5448         gdb_exception_RETURN_MASK_ERROR.
5449         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5450         (gdb_quit_bad_alloc): Update.
5451         * aarch64-tdep.c: Update.
5452         * ada-lang.c: Update.
5453         * ada-typeprint.c: Update.
5454         * ada-valprint.c: Update.
5455         * amd64-tdep.c: Update.
5456         * arch-utils.c: Update.
5457         * break-catch-throw.c: Update.
5458         * breakpoint.c: Update.
5459         * btrace.c: Update.
5460         * c-varobj.c: Update.
5461         * cli/cli-cmds.c: Update.
5462         * cli/cli-interp.c: Update.
5463         * cli/cli-script.c: Update.
5464         * common/common-exceptions.c: Update.
5465         * common/new-op.c: Update.
5466         * common/selftest.c: Update.
5467         * compile/compile-c-symbols.c: Update.
5468         * compile/compile-cplus-symbols.c: Update.
5469         * compile/compile-object-load.c: Update.
5470         * compile/compile-object-run.c: Update.
5471         * completer.c: Update.
5472         * corelow.c: Update.
5473         * cp-abi.c: Update.
5474         * cp-support.c: Update.
5475         * cp-valprint.c: Update.
5476         * darwin-nat.c: Update.
5477         * disasm-selftests.c: Update.
5478         * dtrace-probe.c: Update.
5479         * dwarf-index-cache.c: Update.
5480         * dwarf-index-write.c: Update.
5481         * dwarf2-frame-tailcall.c: Update.
5482         * dwarf2-frame.c: Update.
5483         * dwarf2loc.c: Update.
5484         * dwarf2read.c: Update.
5485         * eval.c: Update.
5486         * event-loop.c: Update.
5487         * event-top.c: Update.
5488         * exec.c: Update.
5489         * f-valprint.c: Update.
5490         * fbsd-tdep.c: Update.
5491         * frame-unwind.c: Update.
5492         * frame.c: Update.
5493         * gdbtypes.c: Update.
5494         * gnu-v3-abi.c: Update.
5495         * guile/guile-internal.h: Update.
5496         * guile/scm-block.c: Update.
5497         * guile/scm-breakpoint.c: Update.
5498         * guile/scm-cmd.c: Update.
5499         * guile/scm-disasm.c: Update.
5500         * guile/scm-frame.c: Update.
5501         * guile/scm-lazy-string.c: Update.
5502         * guile/scm-math.c: Update.
5503         * guile/scm-param.c: Update.
5504         * guile/scm-ports.c: Update.
5505         * guile/scm-pretty-print.c: Update.
5506         * guile/scm-symbol.c: Update.
5507         * guile/scm-symtab.c: Update.
5508         * guile/scm-type.c: Update.
5509         * guile/scm-value.c: Update.
5510         * i386-linux-tdep.c: Update.
5511         * i386-tdep.c: Update.
5512         * inf-loop.c: Update.
5513         * infcall.c: Update.
5514         * infcmd.c: Update.
5515         * infrun.c: Update.
5516         * jit.c: Update.
5517         * language.c: Update.
5518         * linespec.c: Update.
5519         * linux-fork.c: Update.
5520         * linux-nat.c: Update.
5521         * linux-tdep.c: Update.
5522         * linux-thread-db.c: Update.
5523         * main.c: Update.
5524         * mi/mi-cmd-break.c: Update.
5525         * mi/mi-cmd-stack.c: Update.
5526         * mi/mi-interp.c: Update.
5527         * mi/mi-main.c: Update.
5528         * objc-lang.c: Update.
5529         * p-valprint.c: Update.
5530         * parse.c: Update.
5531         * ppc-linux-tdep.c: Update.
5532         * printcmd.c: Update.
5533         * python/py-arch.c: Update.
5534         * python/py-breakpoint.c: Update.
5535         * python/py-cmd.c: Update.
5536         * python/py-finishbreakpoint.c: Update.
5537         * python/py-frame.c: Update.
5538         * python/py-framefilter.c: Update.
5539         * python/py-gdb-readline.c: Update.
5540         * python/py-inferior.c: Update.
5541         * python/py-infthread.c: Update.
5542         * python/py-lazy-string.c: Update.
5543         * python/py-linetable.c: Update.
5544         * python/py-objfile.c: Update.
5545         * python/py-param.c: Update.
5546         * python/py-prettyprint.c: Update.
5547         * python/py-progspace.c: Update.
5548         * python/py-record-btrace.c: Update.
5549         * python/py-record.c: Update.
5550         * python/py-symbol.c: Update.
5551         * python/py-type.c: Update.
5552         * python/py-unwind.c: Update.
5553         * python/py-utils.c: Update.
5554         * python/py-value.c: Update.
5555         * python/python.c: Update.
5556         * record-btrace.c: Update.
5557         * record-full.c: Update.
5558         * remote-fileio.c: Update.
5559         * remote.c: Update.
5560         * riscv-tdep.c: Update.
5561         * rs6000-aix-tdep.c: Update.
5562         * rs6000-tdep.c: Update.
5563         * rust-exp.y: Update.
5564         * rust-lang.c: Update.
5565         * s390-tdep.c: Update.
5566         * selftest-arch.c: Update.
5567         * solib-dsbt.c: Update.
5568         * solib-frv.c: Update.
5569         * solib-spu.c: Update.
5570         * solib-svr4.c: Update.
5571         * solib.c: Update.
5572         * sparc64-linux-tdep.c: Update.
5573         * stack.c: Update.
5574         * symfile-mem.c: Update.
5575         * symmisc.c: Update.
5576         * target.c: Update.
5577         * thread.c: Update.
5578         * top.c: Update.
5579         * tracefile-tfile.c: Update.
5580         * tui/tui.c: Update.
5581         * typeprint.c: Update.
5582         * unittests/cli-utils-selftests.c: Update.
5583         * unittests/parse-connection-spec-selftests.c: Update.
5584         * valops.c: Update.
5585         * valprint.c: Update.
5586         * value.c: Update.
5587         * varobj.c: Update.
5588         * windows-nat.c: Update.
5589         * x86-linux-nat.c: Update.
5590         * xml-support.c: Update.
5591
5592 2019-04-08  Tom Tromey  <tom@tromey.com>
5593
5594         * xml-support.c: Use C++ exception handling.
5595         * x86-linux-nat.c: Use C++ exception handling.
5596         * windows-nat.c: Use C++ exception handling.
5597         * varobj.c: Use C++ exception handling.
5598         * value.c: Use C++ exception handling.
5599         * valprint.c: Use C++ exception handling.
5600         * valops.c: Use C++ exception handling.
5601         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5602         handling.
5603         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5604         * typeprint.c: Use C++ exception handling.
5605         * tui/tui.c: Use C++ exception handling.
5606         * tracefile-tfile.c: Use C++ exception handling.
5607         * top.c: Use C++ exception handling.
5608         * thread.c: Use C++ exception handling.
5609         * target.c: Use C++ exception handling.
5610         * symmisc.c: Use C++ exception handling.
5611         * symfile-mem.c: Use C++ exception handling.
5612         * stack.c: Use C++ exception handling.
5613         * sparc64-linux-tdep.c: Use C++ exception handling.
5614         * solib.c: Use C++ exception handling.
5615         * solib-svr4.c: Use C++ exception handling.
5616         * solib-spu.c: Use C++ exception handling.
5617         * solib-frv.c: Use C++ exception handling.
5618         * solib-dsbt.c: Use C++ exception handling.
5619         * selftest-arch.c: Use C++ exception handling.
5620         * s390-tdep.c: Use C++ exception handling.
5621         * rust-lang.c: Use C++ exception handling.
5622         * rust-exp.y: Use C++ exception handling.
5623         * rs6000-tdep.c: Use C++ exception handling.
5624         * rs6000-aix-tdep.c: Use C++ exception handling.
5625         * riscv-tdep.c: Use C++ exception handling.
5626         * remote.c: Use C++ exception handling.
5627         * remote-fileio.c: Use C++ exception handling.
5628         * record-full.c: Use C++ exception handling.
5629         * record-btrace.c: Use C++ exception handling.
5630         * python/python.c: Use C++ exception handling.
5631         * python/py-value.c: Use C++ exception handling.
5632         * python/py-utils.c: Use C++ exception handling.
5633         * python/py-unwind.c: Use C++ exception handling.
5634         * python/py-type.c: Use C++ exception handling.
5635         * python/py-symbol.c: Use C++ exception handling.
5636         * python/py-record.c: Use C++ exception handling.
5637         * python/py-record-btrace.c: Use C++ exception handling.
5638         * python/py-progspace.c: Use C++ exception handling.
5639         * python/py-prettyprint.c: Use C++ exception handling.
5640         * python/py-param.c: Use C++ exception handling.
5641         * python/py-objfile.c: Use C++ exception handling.
5642         * python/py-linetable.c: Use C++ exception handling.
5643         * python/py-lazy-string.c: Use C++ exception handling.
5644         * python/py-infthread.c: Use C++ exception handling.
5645         * python/py-inferior.c: Use C++ exception handling.
5646         * python/py-gdb-readline.c: Use C++ exception handling.
5647         * python/py-framefilter.c: Use C++ exception handling.
5648         * python/py-frame.c: Use C++ exception handling.
5649         * python/py-finishbreakpoint.c: Use C++ exception handling.
5650         * python/py-cmd.c: Use C++ exception handling.
5651         * python/py-breakpoint.c: Use C++ exception handling.
5652         * python/py-arch.c: Use C++ exception handling.
5653         * printcmd.c: Use C++ exception handling.
5654         * ppc-linux-tdep.c: Use C++ exception handling.
5655         * parse.c: Use C++ exception handling.
5656         * p-valprint.c: Use C++ exception handling.
5657         * objc-lang.c: Use C++ exception handling.
5658         * mi/mi-main.c: Use C++ exception handling.
5659         * mi/mi-interp.c: Use C++ exception handling.
5660         * mi/mi-cmd-stack.c: Use C++ exception handling.
5661         * mi/mi-cmd-break.c: Use C++ exception handling.
5662         * main.c: Use C++ exception handling.
5663         * linux-thread-db.c: Use C++ exception handling.
5664         * linux-tdep.c: Use C++ exception handling.
5665         * linux-nat.c: Use C++ exception handling.
5666         * linux-fork.c: Use C++ exception handling.
5667         * linespec.c: Use C++ exception handling.
5668         * language.c: Use C++ exception handling.
5669         * jit.c: Use C++ exception handling.
5670         * infrun.c: Use C++ exception handling.
5671         * infcmd.c: Use C++ exception handling.
5672         * infcall.c: Use C++ exception handling.
5673         * inf-loop.c: Use C++ exception handling.
5674         * i386-tdep.c: Use C++ exception handling.
5675         * i386-linux-tdep.c: Use C++ exception handling.
5676         * guile/scm-value.c: Use C++ exception handling.
5677         * guile/scm-type.c: Use C++ exception handling.
5678         * guile/scm-symtab.c: Use C++ exception handling.
5679         * guile/scm-symbol.c: Use C++ exception handling.
5680         * guile/scm-pretty-print.c: Use C++ exception handling.
5681         * guile/scm-ports.c: Use C++ exception handling.
5682         * guile/scm-param.c: Use C++ exception handling.
5683         * guile/scm-math.c: Use C++ exception handling.
5684         * guile/scm-lazy-string.c: Use C++ exception handling.
5685         * guile/scm-frame.c: Use C++ exception handling.
5686         * guile/scm-disasm.c: Use C++ exception handling.
5687         * guile/scm-cmd.c: Use C++ exception handling.
5688         * guile/scm-breakpoint.c: Use C++ exception handling.
5689         * guile/scm-block.c: Use C++ exception handling.
5690         * guile/guile-internal.h: Use C++ exception handling.
5691         * gnu-v3-abi.c: Use C++ exception handling.
5692         * gdbtypes.c: Use C++ exception handling.
5693         * frame.c: Use C++ exception handling.
5694         * frame-unwind.c: Use C++ exception handling.
5695         * fbsd-tdep.c: Use C++ exception handling.
5696         * f-valprint.c: Use C++ exception handling.
5697         * exec.c: Use C++ exception handling.
5698         * event-top.c: Use C++ exception handling.
5699         * event-loop.c: Use C++ exception handling.
5700         * eval.c: Use C++ exception handling.
5701         * dwarf2read.c: Use C++ exception handling.
5702         * dwarf2loc.c: Use C++ exception handling.
5703         * dwarf2-frame.c: Use C++ exception handling.
5704         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5705         * dwarf-index-write.c: Use C++ exception handling.
5706         * dwarf-index-cache.c: Use C++ exception handling.
5707         * dtrace-probe.c: Use C++ exception handling.
5708         * disasm-selftests.c: Use C++ exception handling.
5709         * darwin-nat.c: Use C++ exception handling.
5710         * cp-valprint.c: Use C++ exception handling.
5711         * cp-support.c: Use C++ exception handling.
5712         * cp-abi.c: Use C++ exception handling.
5713         * corelow.c: Use C++ exception handling.
5714         * completer.c: Use C++ exception handling.
5715         * compile/compile-object-run.c: Use C++ exception handling.
5716         * compile/compile-object-load.c: Use C++ exception handling.
5717         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5718         * compile/compile-c-symbols.c: Use C++ exception handling.
5719         * common/selftest.c: Use C++ exception handling.
5720         * common/new-op.c: Use C++ exception handling.
5721         * cli/cli-script.c: Use C++ exception handling.
5722         * cli/cli-interp.c: Use C++ exception handling.
5723         * cli/cli-cmds.c: Use C++ exception handling.
5724         * c-varobj.c: Use C++ exception handling.
5725         * btrace.c: Use C++ exception handling.
5726         * breakpoint.c: Use C++ exception handling.
5727         * break-catch-throw.c: Use C++ exception handling.
5728         * arch-utils.c: Use C++ exception handling.
5729         * amd64-tdep.c: Use C++ exception handling.
5730         * ada-valprint.c: Use C++ exception handling.
5731         * ada-typeprint.c: Use C++ exception handling.
5732         * ada-lang.c: Use C++ exception handling.
5733         * aarch64-tdep.c: Use C++ exception handling.
5734
5735 2019-04-08  Tom Tromey  <tom@tromey.com>
5736
5737         * xml-support.c (gdb_xml_parser::parse): Update.
5738         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5739         * value.c (show_convenience): Update.
5740         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5741         (test_parse_flags_qcs): Update.
5742         * thread.c (thr_try_catch_cmd): Update.
5743         * target.c (target_translate_tls_address): Update.
5744         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5745         (info_frame_command_core, frame_apply_command_count): Update.
5746         * rust-exp.y (rust_lex_exception_test): Update.
5747         * riscv-tdep.c (riscv_print_one_register_info): Update.
5748         * remote.c (remote_target::enable_btrace): Update.
5749         * record-btrace.c (record_btrace_enable_warn): Update.
5750         * python/py-utils.c (gdbpy_convert_exception): Update.
5751         * printcmd.c (do_one_display, print_variable_and_value): Update.
5752         * mi/mi-main.c (mi_print_exception): Update.
5753         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5754         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5755         * linux-nat.c (linux_nat_target::attach): Update.
5756         * linux-fork.c (class scoped_switch_fork_info): Update.
5757         * infrun.c (displaced_step_prepare): Update.
5758         * infcall.c (call_function_by_hand_dummy): Update.
5759         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5760         * gnu-v3-abi.c (print_one_vtable): Update.
5761         * frame.c (get_prev_frame_always): Update.
5762         * f-valprint.c (info_common_command_for_block): Update.
5763         * exec.c (try_open_exec_file): Update.
5764         * exceptions.c (print_exception, exception_print)
5765         (exception_fprintf, exception_print_same): Update.
5766         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5767         * dwarf-index-cache.c (index_cache::store)
5768         (index_cache::lookup_gdb_index): Update.
5769         * darwin-nat.c (maybe_cache_shell): Update.
5770         * cp-valprint.c (cp_print_value_fields): Update.
5771         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5772         (gcc_cplus_symbol_address): Update.
5773         * compile/compile-c-symbols.c (gcc_convert_symbol)
5774         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5775         * common/selftest.c: Update.
5776         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5777         a std::string.
5778         (exception_try_scope_entry, exception_try_scope_exit): Don't
5779         declare.
5780         (struct exception_try_scope): Remove.
5781         (TRY): Don't use exception_try_scope.
5782         (struct gdb_exception): Add constructor, operator=.
5783         <what>: New method.
5784         (struct gdb_exception_RETURN_MASK_ALL)
5785         (struct gdb_exception_RETURN_MASK_ERROR)
5786         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5787         (struct gdb_quit_bad_alloc): Update.
5788         * common/common-exceptions.c (exception_none): Change
5789         initializer.
5790         (struct catcher) <state, exception>: Initialize inline.
5791         <prev>: Remove member.
5792         (current_catcher): Remove.
5793         (catchers): New global.
5794         (exceptions_state_mc_init): Simplify.
5795         (catcher_pop): Remove.
5796         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5797         (try_scope_depth, exception_try_scope_entry)
5798         (exception_try_scope_exit): Remove.
5799         (throw_exception_sjlj): Update.
5800         (exception_messages, exception_messages_size): Remove.
5801         (throw_it): Simplify.
5802         (gdb_exception_sliced_copy): Remove.
5803         (throw_exception_cxx): Update.
5804         * cli/cli-script.c (script_from_file): Update.
5805         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5806         Update.
5807         * ada-valprint.c (ada_val_print): Update.
5808         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5809         (create_excep_cond_exprs): Update.
5810
5811 2019-04-08  Tom Tromey  <tom@tromey.com>
5812
5813         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5814         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5815         (TRY, CATCH, END_CATCH): Remove some definitions.
5816         * common/common-exceptions.c: Don't use GDB_XCPT.
5817         (catcher_list_size): Remove.
5818         (throw_exception, throw_it): Simplify.
5819
5820 2019-04-05  Tom Tromey  <tom@tromey.com>
5821
5822         Revert the header-sorting patch.
5823         * ft32-tdep.c: Revert.
5824         * frv-tdep.c: Revert.
5825         * frv-linux-tdep.c: Revert.
5826         * frame.c: Revert.
5827         * frame-unwind.c: Revert.
5828         * frame-base.c: Revert.
5829         * fork-child.c: Revert.
5830         * findvar.c: Revert.
5831         * findcmd.c: Revert.
5832         * filesystem.c: Revert.
5833         * filename-seen-cache.h: Revert.
5834         * filename-seen-cache.c: Revert.
5835         * fbsd-tdep.c: Revert.
5836         * fbsd-nat.h: Revert.
5837         * fbsd-nat.c: Revert.
5838         * f-valprint.c: Revert.
5839         * f-typeprint.c: Revert.
5840         * f-lang.c: Revert.
5841         * extension.h: Revert.
5842         * extension.c: Revert.
5843         * extension-priv.h: Revert.
5844         * expprint.c: Revert.
5845         * exec.h: Revert.
5846         * exec.c: Revert.
5847         * exceptions.c: Revert.
5848         * event-top.c: Revert.
5849         * event-loop.c: Revert.
5850         * eval.c: Revert.
5851         * elfread.c: Revert.
5852         * dwarf2read.h: Revert.
5853         * dwarf2read.c: Revert.
5854         * dwarf2loc.c: Revert.
5855         * dwarf2expr.h: Revert.
5856         * dwarf2expr.c: Revert.
5857         * dwarf2-frame.c: Revert.
5858         * dwarf2-frame-tailcall.c: Revert.
5859         * dwarf-index-write.h: Revert.
5860         * dwarf-index-write.c: Revert.
5861         * dwarf-index-common.c: Revert.
5862         * dwarf-index-cache.h: Revert.
5863         * dwarf-index-cache.c: Revert.
5864         * dummy-frame.c: Revert.
5865         * dtrace-probe.c: Revert.
5866         * disasm.h: Revert.
5867         * disasm.c: Revert.
5868         * disasm-selftests.c: Revert.
5869         * dictionary.c: Revert.
5870         * dicos-tdep.c: Revert.
5871         * demangle.c: Revert.
5872         * dcache.h: Revert.
5873         * dcache.c: Revert.
5874         * darwin-nat.h: Revert.
5875         * darwin-nat.c: Revert.
5876         * darwin-nat-info.c: Revert.
5877         * d-valprint.c: Revert.
5878         * d-namespace.c: Revert.
5879         * d-lang.c: Revert.
5880         * ctf.c: Revert.
5881         * csky-tdep.c: Revert.
5882         * csky-linux-tdep.c: Revert.
5883         * cris-tdep.c: Revert.
5884         * cris-linux-tdep.c: Revert.
5885         * cp-valprint.c: Revert.
5886         * cp-support.c: Revert.
5887         * cp-namespace.c: Revert.
5888         * cp-abi.c: Revert.
5889         * corelow.c: Revert.
5890         * corefile.c: Revert.
5891         * continuations.c: Revert.
5892         * completer.h: Revert.
5893         * completer.c: Revert.
5894         * complaints.c: Revert.
5895         * coffread.c: Revert.
5896         * coff-pe-read.c: Revert.
5897         * cli-out.h: Revert.
5898         * cli-out.c: Revert.
5899         * charset.c: Revert.
5900         * c-varobj.c: Revert.
5901         * c-valprint.c: Revert.
5902         * c-typeprint.c: Revert.
5903         * c-lang.c: Revert.
5904         * buildsym.c: Revert.
5905         * buildsym-legacy.c: Revert.
5906         * build-id.h: Revert.
5907         * build-id.c: Revert.
5908         * btrace.c: Revert.
5909         * bsd-uthread.c: Revert.
5910         * breakpoint.h: Revert.
5911         * breakpoint.c: Revert.
5912         * break-catch-throw.c: Revert.
5913         * break-catch-syscall.c: Revert.
5914         * break-catch-sig.c: Revert.
5915         * blockframe.c: Revert.
5916         * block.c: Revert.
5917         * bfin-tdep.c: Revert.
5918         * bfin-linux-tdep.c: Revert.
5919         * bfd-target.c: Revert.
5920         * bcache.c: Revert.
5921         * ax-general.c: Revert.
5922         * ax-gdb.h: Revert.
5923         * ax-gdb.c: Revert.
5924         * avr-tdep.c: Revert.
5925         * auxv.c: Revert.
5926         * auto-load.c: Revert.
5927         * arm-wince-tdep.c: Revert.
5928         * arm-tdep.c: Revert.
5929         * arm-symbian-tdep.c: Revert.
5930         * arm-pikeos-tdep.c: Revert.
5931         * arm-obsd-tdep.c: Revert.
5932         * arm-nbsd-tdep.c: Revert.
5933         * arm-nbsd-nat.c: Revert.
5934         * arm-linux-tdep.c: Revert.
5935         * arm-linux-nat.c: Revert.
5936         * arm-fbsd-tdep.c: Revert.
5937         * arm-fbsd-nat.c: Revert.
5938         * arm-bsd-tdep.c: Revert.
5939         * arch-utils.c: Revert.
5940         * arc-tdep.c: Revert.
5941         * arc-newlib-tdep.c: Revert.
5942         * annotate.h: Revert.
5943         * annotate.c: Revert.
5944         * amd64-windows-tdep.c: Revert.
5945         * amd64-windows-nat.c: Revert.
5946         * amd64-tdep.c: Revert.
5947         * amd64-sol2-tdep.c: Revert.
5948         * amd64-obsd-tdep.c: Revert.
5949         * amd64-obsd-nat.c: Revert.
5950         * amd64-nbsd-tdep.c: Revert.
5951         * amd64-nbsd-nat.c: Revert.
5952         * amd64-nat.c: Revert.
5953         * amd64-linux-tdep.c: Revert.
5954         * amd64-linux-nat.c: Revert.
5955         * amd64-fbsd-tdep.c: Revert.
5956         * amd64-fbsd-nat.c: Revert.
5957         * amd64-dicos-tdep.c: Revert.
5958         * amd64-darwin-tdep.c: Revert.
5959         * amd64-bsd-nat.c: Revert.
5960         * alpha-tdep.c: Revert.
5961         * alpha-obsd-tdep.c: Revert.
5962         * alpha-nbsd-tdep.c: Revert.
5963         * alpha-mdebug-tdep.c: Revert.
5964         * alpha-linux-tdep.c: Revert.
5965         * alpha-linux-nat.c: Revert.
5966         * alpha-bsd-tdep.c: Revert.
5967         * alpha-bsd-nat.c: Revert.
5968         * aix-thread.c: Revert.
5969         * agent.c: Revert.
5970         * addrmap.c: Revert.
5971         * ada-varobj.c: Revert.
5972         * ada-valprint.c: Revert.
5973         * ada-typeprint.c: Revert.
5974         * ada-tasks.c: Revert.
5975         * ada-lang.c: Revert.
5976         * aarch64-tdep.c: Revert.
5977         * aarch64-ravenscar-thread.c: Revert.
5978         * aarch64-newlib-tdep.c: Revert.
5979         * aarch64-linux-tdep.c: Revert.
5980         * aarch64-linux-nat.c: Revert.
5981         * aarch64-fbsd-tdep.c: Revert.
5982         * aarch64-fbsd-nat.c: Revert.
5983         * aarch32-linux-nat.c: Revert.
5984
5985 2019-04-05  Tom Tromey  <tom@tromey.com>
5986
5987         * ft32-tdep.c: Sort headers.
5988         * frv-tdep.c: Sort headers.
5989         * frv-linux-tdep.c: Sort headers.
5990         * frame.c: Sort headers.
5991         * frame-unwind.c: Sort headers.
5992         * frame-base.c: Sort headers.
5993         * fork-child.c: Sort headers.
5994         * findvar.c: Sort headers.
5995         * findcmd.c: Sort headers.
5996         * filesystem.c: Sort headers.
5997         * filename-seen-cache.h: Sort headers.
5998         * filename-seen-cache.c: Sort headers.
5999         * fbsd-tdep.c: Sort headers.
6000         * fbsd-nat.h: Sort headers.
6001         * fbsd-nat.c: Sort headers.
6002         * f-valprint.c: Sort headers.
6003         * f-typeprint.c: Sort headers.
6004         * f-lang.c: Sort headers.
6005         * extension.h: Sort headers.
6006         * extension.c: Sort headers.
6007         * extension-priv.h: Sort headers.
6008         * expprint.c: Sort headers.
6009         * exec.h: Sort headers.
6010         * exec.c: Sort headers.
6011         * exceptions.c: Sort headers.
6012         * event-top.c: Sort headers.
6013         * event-loop.c: Sort headers.
6014         * eval.c: Sort headers.
6015         * elfread.c: Sort headers.
6016         * dwarf2read.h: Sort headers.
6017         * dwarf2read.c: Sort headers.
6018         * dwarf2loc.c: Sort headers.
6019         * dwarf2expr.h: Sort headers.
6020         * dwarf2expr.c: Sort headers.
6021         * dwarf2-frame.c: Sort headers.
6022         * dwarf2-frame-tailcall.c: Sort headers.
6023         * dwarf-index-write.h: Sort headers.
6024         * dwarf-index-write.c: Sort headers.
6025         * dwarf-index-common.c: Sort headers.
6026         * dwarf-index-cache.h: Sort headers.
6027         * dwarf-index-cache.c: Sort headers.
6028         * dummy-frame.c: Sort headers.
6029         * dtrace-probe.c: Sort headers.
6030         * disasm.h: Sort headers.
6031         * disasm.c: Sort headers.
6032         * disasm-selftests.c: Sort headers.
6033         * dictionary.c: Sort headers.
6034         * dicos-tdep.c: Sort headers.
6035         * demangle.c: Sort headers.
6036         * dcache.h: Sort headers.
6037         * dcache.c: Sort headers.
6038         * darwin-nat.h: Sort headers.
6039         * darwin-nat.c: Sort headers.
6040         * darwin-nat-info.c: Sort headers.
6041         * d-valprint.c: Sort headers.
6042         * d-namespace.c: Sort headers.
6043         * d-lang.c: Sort headers.
6044         * ctf.c: Sort headers.
6045         * csky-tdep.c: Sort headers.
6046         * csky-linux-tdep.c: Sort headers.
6047         * cris-tdep.c: Sort headers.
6048         * cris-linux-tdep.c: Sort headers.
6049         * cp-valprint.c: Sort headers.
6050         * cp-support.c: Sort headers.
6051         * cp-namespace.c: Sort headers.
6052         * cp-abi.c: Sort headers.
6053         * corelow.c: Sort headers.
6054         * corefile.c: Sort headers.
6055         * continuations.c: Sort headers.
6056         * completer.h: Sort headers.
6057         * completer.c: Sort headers.
6058         * complaints.c: Sort headers.
6059         * coffread.c: Sort headers.
6060         * coff-pe-read.c: Sort headers.
6061         * cli-out.h: Sort headers.
6062         * cli-out.c: Sort headers.
6063         * charset.c: Sort headers.
6064         * c-varobj.c: Sort headers.
6065         * c-valprint.c: Sort headers.
6066         * c-typeprint.c: Sort headers.
6067         * c-lang.c: Sort headers.
6068         * buildsym.c: Sort headers.
6069         * buildsym-legacy.c: Sort headers.
6070         * build-id.h: Sort headers.
6071         * build-id.c: Sort headers.
6072         * btrace.c: Sort headers.
6073         * bsd-uthread.c: Sort headers.
6074         * breakpoint.h: Sort headers.
6075         * breakpoint.c: Sort headers.
6076         * break-catch-throw.c: Sort headers.
6077         * break-catch-syscall.c: Sort headers.
6078         * break-catch-sig.c: Sort headers.
6079         * blockframe.c: Sort headers.
6080         * block.c: Sort headers.
6081         * bfin-tdep.c: Sort headers.
6082         * bfin-linux-tdep.c: Sort headers.
6083         * bfd-target.c: Sort headers.
6084         * bcache.c: Sort headers.
6085         * ax-general.c: Sort headers.
6086         * ax-gdb.h: Sort headers.
6087         * ax-gdb.c: Sort headers.
6088         * avr-tdep.c: Sort headers.
6089         * auxv.c: Sort headers.
6090         * auto-load.c: Sort headers.
6091         * arm-wince-tdep.c: Sort headers.
6092         * arm-tdep.c: Sort headers.
6093         * arm-symbian-tdep.c: Sort headers.
6094         * arm-pikeos-tdep.c: Sort headers.
6095         * arm-obsd-tdep.c: Sort headers.
6096         * arm-nbsd-tdep.c: Sort headers.
6097         * arm-nbsd-nat.c: Sort headers.
6098         * arm-linux-tdep.c: Sort headers.
6099         * arm-linux-nat.c: Sort headers.
6100         * arm-fbsd-tdep.c: Sort headers.
6101         * arm-fbsd-nat.c: Sort headers.
6102         * arm-bsd-tdep.c: Sort headers.
6103         * arch-utils.c: Sort headers.
6104         * arc-tdep.c: Sort headers.
6105         * arc-newlib-tdep.c: Sort headers.
6106         * annotate.h: Sort headers.
6107         * annotate.c: Sort headers.
6108         * amd64-windows-tdep.c: Sort headers.
6109         * amd64-windows-nat.c: Sort headers.
6110         * amd64-tdep.c: Sort headers.
6111         * amd64-sol2-tdep.c: Sort headers.
6112         * amd64-obsd-tdep.c: Sort headers.
6113         * amd64-obsd-nat.c: Sort headers.
6114         * amd64-nbsd-tdep.c: Sort headers.
6115         * amd64-nbsd-nat.c: Sort headers.
6116         * amd64-nat.c: Sort headers.
6117         * amd64-linux-tdep.c: Sort headers.
6118         * amd64-linux-nat.c: Sort headers.
6119         * amd64-fbsd-tdep.c: Sort headers.
6120         * amd64-fbsd-nat.c: Sort headers.
6121         * amd64-dicos-tdep.c: Sort headers.
6122         * amd64-darwin-tdep.c: Sort headers.
6123         * amd64-bsd-nat.c: Sort headers.
6124         * alpha-tdep.c: Sort headers.
6125         * alpha-obsd-tdep.c: Sort headers.
6126         * alpha-nbsd-tdep.c: Sort headers.
6127         * alpha-mdebug-tdep.c: Sort headers.
6128         * alpha-linux-tdep.c: Sort headers.
6129         * alpha-linux-nat.c: Sort headers.
6130         * alpha-bsd-tdep.c: Sort headers.
6131         * alpha-bsd-nat.c: Sort headers.
6132         * aix-thread.c: Sort headers.
6133         * agent.c: Sort headers.
6134         * addrmap.c: Sort headers.
6135         * ada-varobj.c: Sort headers.
6136         * ada-valprint.c: Sort headers.
6137         * ada-typeprint.c: Sort headers.
6138         * ada-tasks.c: Sort headers.
6139         * ada-lang.c: Sort headers.
6140         * aarch64-tdep.c: Sort headers.
6141         * aarch64-ravenscar-thread.c: Sort headers.
6142         * aarch64-newlib-tdep.c: Sort headers.
6143         * aarch64-linux-tdep.c: Sort headers.
6144         * aarch64-linux-nat.c: Sort headers.
6145         * aarch64-fbsd-tdep.c: Sort headers.
6146         * aarch64-fbsd-nat.c: Sort headers.
6147         * aarch32-linux-nat.c: Sort headers.
6148
6149 2019-04-04  Tom Tromey  <tom@tromey.com>
6150
6151         * varobj.c (varobj_create): Update.
6152         * rust-exp.y (struct rust_parser) <update_innermost_block,
6153         lookup_symbol>: New methods.
6154         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6155         Rename.
6156         (rust_parser::rust_lookup_type)
6157         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6158         * printcmd.c (display_command, do_one_display): Update.
6159         * parser-defs.h (struct parser_state) <parser_state>: Add
6160         "tracker" parameter.
6161         (block_tracker): New member.
6162         (class innermost_block_tracker) <innermost_block_tracker>: Add
6163         "types" parameter.
6164         <reset>: Remove method.
6165         (innermost_block): Don't declare.
6166         (null_post_parser): Update.
6167         * parse.c (innermost_block): Remove global.
6168         (write_dollar_variable): Update.
6169         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6170         Remove "tracker_types" parameter.
6171         (parse_expression): Add "tracker" parameter.
6172         (parse_expression_for_completion): Update.
6173         (null_post_parser): Add "tracker" parameter.
6174         * p-exp.y: Update rules.
6175         * m2-exp.y: Update rules.
6176         * language.h (struct language_defn) <la_post_parser>: Add
6177         "tracker" parameter.
6178         * go-exp.y: Update rules.
6179         * f-exp.y: Update rules.
6180         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6181         parameter.
6182         * d-exp.y: Update rules.
6183         * c-exp.y: Update rules.
6184         * breakpoint.c (set_breakpoint_condition): Create an
6185         innermost_block_tracker.
6186         (watch_command_1): Likewise.
6187         * ada-lang.c (resolve): Add "tracker" parameter.
6188         (resolve_subexp): Likewise.
6189         * ada-exp.y (write_var_from_sym): Update.
6190
6191 2019-04-04  Tom Tromey  <tom@tromey.com>
6192
6193         * type-stack.h: New file.
6194         * type-stack.c: New file.
6195         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6196         type-stack.h.
6197         (insert_into_type_stack, insert_type, push_type, push_type_int)
6198         (insert_type_address_space, pop_type, pop_type_int)
6199         (pop_typelist, pop_type_stack, append_type_stack)
6200         (push_type_stack, get_type_stack, push_typelist)
6201         (follow_type_instance_flags, follow_types): Don't declare.
6202         * parse.c (type_stack): Remove global.
6203         (parse_exp_in_context): Update.
6204         (insert_into_type_stack, insert_type, push_type, push_type_int)
6205         (insert_type_address_space, pop_type, pop_type_int)
6206         (pop_typelist, pop_type_stack, append_type_stack)
6207         (push_type_stack, get_type_stack, push_typelist)
6208         (follow_type_instance_flags, follow_types): Remove (moved to
6209         type-stack.c).
6210         * f-exp.y (type_stack): New global.
6211         Update rules.
6212         (push_kind_type, f_parse): Update.
6213         * d-exp.y (type_stack): New global.
6214         Update rules.
6215         (d_parse): Update.
6216         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6217         Update rules.
6218         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6219         (HFILES_NO_SRCDIR): Add type-stack.h.
6220
6221 2019-04-04  Tom Tromey  <tom@tromey.com>
6222
6223         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6224         (rust_parser::convert_ast_to_expression, rust_parse)
6225         (rust_lex_test_completion, rust_lex_tests): Update.
6226         * parser-defs.h (struct expr_completion_state): New.
6227         (struct parser_state) <parser_state>: Add completion parameter.
6228         <mark_struct_expression, mark_completion_tag>: New methods.
6229         <parse_completion, m_completion_state>: New members.
6230         (prefixify_expression, null_post_parser): Update.
6231         (mark_struct_expression, mark_completion_tag): Don't declare.
6232         * parse.c (parse_completion, expout_last_struct)
6233         (expout_tag_completion_type, expout_completion_name): Remove
6234         globals.
6235         (parser_state::mark_struct_expression)
6236         (parser_state::mark_completion_tag): Now methods.
6237         (prefixify_expression): Add last_struct parameter.
6238         (prefixify_subexp): Likewise.
6239         (parse_exp_1): Update.
6240         (parse_exp_in_context): Add cstate parameter.  Update.
6241         (parse_expression_for_completion): Create an
6242         expr_completion_state.
6243         (null_post_parser): Add "completion" parameter.
6244         * p-exp.y: Update rules.
6245         (yylex): Update.
6246         * language.h (struct language_defn) <la_post_parser>: Add
6247         "completing" parameter.
6248         * go-exp.y: Update rules.
6249         (lex_one_token): Update.
6250         * expression.h (parse_completion): Don't declare.
6251         * d-exp.y: Update rules.
6252         (lex_one_token): Update rules.
6253         * c-exp.y: Update rules.
6254         (lex_one_token): Update.
6255         * ada-lang.c (resolve): Add "parse_completion" parameter.
6256         (resolve_subexp): Likewise.
6257         (ada_resolve_function): Likewise.
6258
6259 2019-04-04  Tom Tromey  <tom@tromey.com>
6260
6261         * parser-defs.h (struct parser_state) <start_arglist,
6262         end_arglist>: New methods.
6263         <arglist_len, m_funcall_chain>: New members.
6264         (arglist_len, start_arglist, end_arglist): Don't declare.
6265         * parse.c (arglist_len, funcall_chain): Remove global.
6266         (start_arglist, end_arglist): Remove functions.
6267         (parse_exp_in_context): Update.
6268         * p-exp.y: Update rules.
6269         * m2-exp.y: Update rules.
6270         * go-exp.y: Update rules.
6271         * f-exp.y: Update rules.
6272         * d-exp.y: Update rules.
6273         * c-exp.y: Update rules.
6274
6275 2019-04-04  Tom Tromey  <tom@tromey.com>
6276
6277         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6278         lex_operator, push_back>: New methods.
6279         Update all rules.
6280         (rust_parser::lex_hex, lex_escape): Rename and update.
6281         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6282         (rust_parser::lex_operator): Rename and update.
6283         (rust_parser::lex_number, rustyylex, rustyyerror)
6284         (rust_lex_test_init, rust_lex_test_sequence)
6285         (rust_lex_test_push_back, rust_lex_tests): Update.
6286         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6287         parameter.
6288         <lexptr, prev_lexptr>: New members.
6289         (lexptr, prev_lexptr): Don't declare.
6290         * parse.c (lexptr, prev_lexptr): Remove globals.
6291         (parse_exp_in_context): Update.
6292         * p-exp.y (yylex, yyerror): Update.
6293         * m2-exp.y (parse_number, yylex, yyerror): Update.
6294         * go-exp.y (lex_one_token, yyerror): Update.
6295         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6296         * d-exp.y (lex_one_token, yyerror): Update.
6297         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6298         (lex_one_token, yyerror): Update.
6299         * ada-lex.l (YY_INPUT): Update.
6300         (rewind_to_char): Update.
6301         * ada-exp.y (yyerror): Update.
6302
6303 2019-04-04  Tom Tromey  <tom@tromey.com>
6304
6305         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6306         * parser-defs.h (struct parser_state) <parser_state>: Add new
6307         parameter.
6308         <comma_terminates>: New member.
6309         (comma_terminates): Don't declare global.
6310         * parse.c (comma_terminates): Remove global.
6311         (parse_exp_in_context): Update.
6312         * p-exp.y (yylex): Update.
6313         * m2-exp.y (yylex): Update.
6314         * go-exp.y (lex_one_token): Update.
6315         * f-exp.y (yylex): Update.
6316         * d-exp.y (lex_one_token): Update.
6317         * c-exp.y (lex_one_token): Update.
6318         * ada-lex.l: Update.
6319
6320 2019-04-04  Tom Tromey  <tom@tromey.com>
6321
6322         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6323         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6324         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6325         * parser-defs.h (paren_depth): Don't declare.
6326         * parse.c (paren_depth): Remove global.
6327         (parse_exp_in_context): Update.
6328         * p-exp.y (paren_depth): New global.
6329         (pascal_parse): Initialize it.
6330         * m2-exp.y (paren_depth): New global.
6331         (m2_parse): Initialize it.
6332         * go-exp.y (paren_depth): New global.
6333         (go_parse): Initialize it.
6334         * f-exp.y (paren_depth): New global.
6335         (f_parse): Initialize it.
6336         * d-exp.y (paren_depth): New global.
6337         (d_parse): Initialize it.
6338         * c-exp.y (paren_depth): New global.
6339         (c_parse): Initialize it.
6340         * ada-lex.l (paren_depth): New global.
6341         (lexer_init): Initialize it.
6342
6343 2019-04-04  Tom Tromey  <tom@tromey.com>
6344
6345         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6346         (rust_parser::convert_ast_to_type)
6347         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6348         * parser-defs.h (struct parser_state) <parser_state>: Add
6349         parameters.  Initialize new members.
6350         <expression_context_block, expression_context_pc>: New members.
6351         * parse.c (expression_context_block, expression_context_pc):
6352         Remove globals.
6353         (parse_exp_in_context): Update.
6354         * p-exp.y: Update all rules.
6355         (yylex): Update.
6356         * m2-exp.y: Update all rules.
6357         (yylex): Update.
6358         * go-exp.y (yylex): Update.
6359         * f-exp.y (yylex): Update.
6360         * d-exp.y: Update all rules.
6361         (yylex): Update.
6362         * c-exp.y: Update all rules.
6363         (lex_one_token, classify_name, yylex, c_parse): Update.
6364         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6365
6366 2019-04-04  Tom Tromey  <tom@tromey.com>
6367
6368         * gdbarch.h, gdbarch.c: Rebuild.
6369         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6370         * stap-probe.h:
6371         (struct stap_parse_info): Replace "parser_state" with
6372         "expr_builder".
6373         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6374         (parser_state): New class.
6375         * parse.c (expr_builder): Rename.
6376         (expr_builder::release): Rename.
6377         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6378         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6379         (write_exp_elt_longcst, write_exp_elt_floatcst)
6380         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6381         (write_exp_string_vector, write_exp_bitstring)
6382         (write_exp_msymbol, mark_struct_expression)
6383         (write_dollar_variable)
6384         (insert_type_address_space, increase_expout_size): Replace
6385         "parser_state" with "expr_builder".
6386         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6387         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6388         "parser_state" with "expr_builder".
6389
6390 2019-04-04  Tom Tromey  <tom@tromey.com>
6391
6392         * rust-exp.y: Replace "parse_language" with method call.
6393         * p-exp.y:
6394         (yylex): Replace "parse_language" with method call.
6395         * m2-exp.y:
6396         (yylex): Replace "parse_language" with method call.
6397         * go-exp.y (classify_name): Replace "parse_language" with method
6398         call.
6399         * f-exp.y (yylex): Replace "parse_language" with method call.
6400         * d-exp.y (lex_one_token): Replace "parse_language" with method
6401         call.
6402         * c-exp.y:
6403         (lex_one_token, classify_name, yylex): Replace "parse_language"
6404         with method call.
6405         * ada-exp.y (find_primitive_type, type_char)
6406         (type_system_address): Replace "parse_language" with method call.
6407
6408 2019-04-04  Tom Tromey  <tom@tromey.com>
6409
6410         * rust-exp.y: Replace "parse_gdbarch" with method call.
6411         * parse.c (write_dollar_variable, insert_type_address_space):
6412         Replace "parse_gdbarch" with method call.
6413         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6414         call.
6415         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6416         call.
6417         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6418         "parse_gdbarch" with method call.
6419         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6420         with method call.
6421         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6422         "parse_gdbarch" with method call.
6423         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6424         "parse_gdbarch" with method call.
6425         * c-exp.y (parse_type, parse_number, classify_name): Replace
6426         "parse_gdbarch" with method call.
6427         * ada-lex.l: Replace "parse_gdbarch" with method call.
6428         * ada-exp.y (parse_type, find_primitive_type, type_char)
6429         (type_system_address): Replace "parse_gdbarch" with method call.
6430
6431 2019-04-04  Tom Tromey  <tom@tromey.com>
6432
6433         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6434         * stap-probe.c (stap_parse_argument): Update.
6435         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6436         initial_size parameter.
6437         * rust-exp.y (rust_lex_tests): Update.
6438         * parse.c (parser_state): Update.
6439         (parse_exp_in_context): Update.
6440         * parser-defs.h (struct parser_state) <parser_state>: Remove
6441         "initial_size" parameter.
6442
6443 2019-04-04  Tom Tromey  <tom@tromey.com>
6444
6445         * parser-defs.h (increase_expout_size): Don't declare.
6446         * parse.c (increase_expout_size): Now static.
6447
6448 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6449
6450         * gnu-nat.c (gnu_nat_target::wait): Fix
6451         target_waitstatus_to_string call.
6452
6453 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6454
6455         * eval.c (evaluate_subexp_standard): Handle internal functions
6456         during Fortran function call handling.
6457
6458 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6459
6460         * NEWS: Mention new internal functions.
6461         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6462         (read_base_type): Use dwarf2_init_complex_target_type.
6463         * value.c (creal_internal_fn): New function.
6464         (cimag_internal_fn): New function.
6465         (_initialize_values): Register new internal functions.
6466
6467 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6468
6469         * infrun.c (stop_all_threads): If debug_infrun, always
6470         trace the wait status after wait_one, using
6471         target_waitstatus_to_string and target_pid_to_str.
6472         (handle_inferior_event): Replace various trace of
6473         wait status kind by a single trace.
6474         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6475         wait status kind image by target_waitstatus_to_string.
6476         * target/waitstatus.c (target_waitstatus_to_string): Fix
6477         obsolete comment.
6478
6479 2019-04-01  Tom Tromey  <tromey@adacore.com>
6480
6481         PR symtab/23331:
6482         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6483
6484 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6485             Pedro Alves  <palves@redhat.com>
6486
6487         * top.c (quit_force): Call 'finalize_values'.
6488         * value.c (finalize_values): New function.
6489         * value.h (finalize_values): Declare.
6490
6491 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6492
6493         * NEWS: Announce $_gdb_major and $_gdb_minor.
6494
6495         * top.c (init_gdb_version_vars): New function.
6496         (gdb_init): Call init_gdb_version_vars.
6497
6498 2019-03-29  Tom Tromey  <tromey@adacore.com>
6499
6500         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6501         help text.  Remove dead code.
6502
6503 2019-03-29  Keith Seitz  <keiths@redhat.com>
6504
6505         From Siddhesh Poyarekar:
6506         * f-lang.h (f77_get_upperbound): Return LONGEST.
6507         (f77_get_lowerbound): Likewise.
6508         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6509         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6510         print them.
6511         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6512         plongest to format print it.
6513         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6514         (f77_get_upperbound): Likewise.
6515         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6516         LOWER_BOUND to LONGEST.
6517         (f77_create_arrayprint_offset_tbl): Likewise.
6518
6519 2019-03-29  Keith Seitz  <keiths@redhat.com>
6520
6521         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6522         %s/pulongest for TYPE_LENGTH instead of %d in format
6523         strings.
6524         * ada-typerint.c (ada_print_type): Likewise.
6525         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6526         * compile/compile-c-support.c (generate_register_struct): Likewise.
6527         * gdbtypes.c (recursive_dump_type): Likewise.
6528         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6529         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6530         instead of %d in format strings.
6531         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6532         to std::min to ULONGEST.
6533         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6534         instead of %d in format strings.
6535         * tracepoint.c (info_scope_command): Likewise.
6536         * typeprint.c (print_offset_data::update)
6537         (print_offset_data::finish): Likewise.
6538         * xtensa-tdep.c (xtensa_store_return_value)
6539         (xtensa_push_dummy_call): Likewise.
6540
6541 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6542
6543         * windows-nat.c (display_selector): Fixed format specifications
6544         for 64-bit Cygwin.
6545
6546 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6547
6548         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6549
6550 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6551
6552         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6553         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6554         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6555         (nios2_linux_init_abi): Install it.
6556
6557 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6558
6559         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6560
6561 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6562
6563         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6564
6565 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6566             Tom Tromey  <tromey@adacore.com>
6567
6568         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6569
6570 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6571
6572         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6573         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6574         method to compute the bounds of range types. Also print "[evaluated]"
6575         if the bounds' values come from a dynamic evaluation.
6576
6577 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6578
6579         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6580         whitespace when pretty printing is on.
6581
6582 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6583
6584         * ppc-linux-nat.c: Add include.
6585
6586 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6587
6588         * NEWS: Mention AArch64 Pointer Authentication.
6589
6590 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6591
6592         * arm-linux-nat.c: Add include.
6593
6594 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6595
6596         * source-cache.c (source_cache::get_source_lines): Re-read
6597         fullname after calling open_source_file.
6598
6599 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6600
6601         * NEWS: Mention TLS support for FreeBSD.
6602
6603 2019-03-25  Tom Tromey  <tromey@adacore.com>
6604
6605         * minsyms.c (BUNCH_SIZE): Update comment.
6606         (~minimal_symbol_reader): Remove old comment.
6607         (compact_minimal_symbols): Update comment.
6608         (minimal_symbol_reader::install): Remove old comment.  Update
6609         other comments.
6610
6611 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6612
6613         * s390-linux-nat.c: Add include.
6614
6615 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6616
6617         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6618         Call linux_get_hwcap.
6619         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6620         Likewise.
6621         (aarch64_linux_get_hwcap): Remove function.
6622         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6623         declaration.
6624         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6625         linux_get_hwcap.
6626         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6627         * linux-tdep.c (linux_get_hwcap): Add function.
6628         (linux_get_hwcap2): Likewise.
6629         * linux-tdep.h (linux_get_hwcap): Add declaration.
6630         (linux_get_hwcap2): Likewise.
6631         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6632         (ppc_linux_get_hwcap2): Likewise.
6633         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6634         linux_get_hwcap.
6635         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6636         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6637         (ppc_linux_nat_target::read_description): Likewise.
6638         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6639         * s390-linux-nat.c: Likewise.
6640         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6641
6642 2019-03-24  Tom Tromey  <tom@tromey.com>
6643
6644         * ada-lang.c (standard_lookup): Simplify initialization.
6645         (ada_lookup_symbol_nonlocal): Simplify return.
6646         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6647         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6648         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6649         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6650         initialization.
6651         * solib.c (solib_global_lookup): Simplify.
6652         * symtab.c (null_block_symbol): Remove.
6653         (symbol_cache_lookup): Simplify returns.
6654         (lookup_language_this): Simplify returns.
6655         (lookup_symbol_aux): Simplify return.
6656         (lookup_local_symbol): Simplify returns.
6657         (lookup_global_symbol_from_objfile): Simplify return.
6658         (lookup_symbol_in_objfile_symtabs)
6659         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6660         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6661         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6662         * cp-namespace.c (cp_lookup_bare_symbol)
6663         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6664         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6665         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6666         (cp_lookup_symbol_via_imports): Simplify initialization.
6667         (find_symbol_in_baseclass): Likewise.
6668         * symtab.h (null_block_symbol): Remove.
6669         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6670         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6671         (d_lookup_symbol_module): Likewise.
6672         (find_symbol_in_baseclass): Simplify initialization.
6673
6674 2019-03-24  Tom Tromey  <tom@tromey.com>
6675
6676         * expression.h: Don't include symtab.h.
6677         (struct block): Forward declare.
6678
6679 2019-03-24  Tom Tromey  <tom@tromey.com>
6680
6681         * c-exp.y (typebase): Remove casts.
6682         * gdbtypes.c (lookup_unsigned_typename, )
6683         (lookup_signed_typename): Remove cast.
6684         * eval.c (parse_to_comma_and_eval): Remove cast.
6685         * parse.c (write_dollar_variable): Remove cast.
6686         * block.h (struct block) <superblock>: Now const.
6687         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6688         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6689         (map_block): Make "block" const.
6690         * symfile.h (struct quick_symbol_functions)
6691         <map_matching_symbols>: Constify block argument to "callback".
6692         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6693         const.
6694         (find_pc_sect_compunit_symtab): Make "b" const.
6695         (find_symbol_at_address): Likewise.
6696         (search_symbols): Likewise.
6697         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6698         (dw2_debug_names_lookup_symbol): Likewise.
6699         (dw2_map_matching_symbols): Update.
6700         * p-valprint.c (pascal_val_print): Remove "block".
6701         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6702         (aux_add_nonlocal_symbols): Make "block" const.
6703         (resolve_subexp): Remove cast.
6704         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6705         const.
6706         (iterate_over_file_blocks): Likewise.
6707         * f-exp.y (%union) <bval>: Remove.
6708         * coffread.c (patch_opaque_types): Make "b" const.
6709         * spu-tdep.c (spu_catch_start): Make "block" const.
6710         * c-valprint.c (print_unpacked_pointer): Remove "block".
6711         * symmisc.c (dump_symtab_1): Make "b" const.
6712         (block_depth): Make "block" const.
6713         * d-exp.y (%union) <bval>: Remove.
6714         * cp-support.h (cp_lookup_rtti_type): Update.
6715         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6716         * psymtab.c (psym_lookup_symbol): Make "block" const.
6717         (maintenance_check_psymtabs): Make "b" const.
6718         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6719         (enumerate_locals, enumerate_args): Update.
6720         * python/py-symtab.c (stpy_global_block): Make "block" const.
6721         (stpy_static_block): Likewise.
6722         * inline-frame.c (block_starting_point_at): Make "new_block"
6723         const.
6724         * block.c (find_block_in_blockvector): Make return type const.
6725         (blockvector_for_pc_sect): Make "b" const.
6726         (find_block_in_blockvector): Make "b" const.
6727
6728 2019-03-23  Tom Tromey  <tom@tromey.com>
6729
6730         * varobj.c (varobj_create): Update.
6731         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6732         * printcmd.c (display_command, do_one_display): Don't reset
6733         innermost_block.
6734         * parser-defs.h (enum innermost_block_tracker_type): Move to
6735         expression.h.
6736         (innermost_block): Update comment.
6737         * parse.c (parse_exp_1): Add tracker_types parameter.
6738         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6739         tracker_types parameter.  Reset innermost_block.
6740         (parse_exp_in_context): Remove.
6741         (parse_expression_for_completion): Update.
6742         * objfiles.c (~objfile): Don't reset expression_context_block or
6743         innermost_block.
6744         * expression.h (enum innermost_block_tracker_type): Move from
6745         parser-defs.h.
6746         (parse_exp_1): Add tracker_types parameter.
6747         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6748         reset innermost_block.
6749
6750 2019-03-23  Tom Tromey  <tom@tromey.com>
6751
6752         * objfiles.h: Include bcache.h.
6753
6754 2019-03-23  Tom Tromey  <tom@tromey.com>
6755
6756         * linespec.c (get_current_search_block): Use
6757         scoped_restore_current_language.
6758         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6759
6760 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6761             Jiong Wang  <jiong.wang@arm.com>
6762
6763         * aarch64-linux-tdep.c
6764         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6765         section.
6766         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6767
6768 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6769             Jiong Wang  <jiong.wang@arm.com>
6770
6771         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6772         instructions.
6773         (aarch64_analyze_prologue_test): Add PACIASP test.
6774         (aarch64_prologue_prev_register): Unmask PC value.
6775
6776 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6777             Jiong Wang  <jiong.wang@arm.com>
6778
6779         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6780         (aarch64_dwarf2_prev_register): Unmask PC value.
6781         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6782         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6783         DW_CFA_AARCH64_negate_ra_state.
6784         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6785
6786 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6787             Jiong Wang  <jiong.wang@arm.com>
6788
6789         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6790         registers.
6791         (aarch64_pseudo_register_name): Likewise.
6792         (aarch64_pseudo_register_type): Likewise.
6793         (aarch64_pseudo_register_reggroup_p): Likewise.
6794         (aarch64_gdbarch_init): Add pauth registers.
6795         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6796         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6797         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6798         (struct gdbarch_tdep): Add regnum for ra_state.
6799
6800 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6801             Jiong Wang  <jiong.wang@arm.com>
6802
6803         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6804
6805 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6806             Jiong Wang  <jiong.wang@arm.com>
6807
6808         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6809         function.
6810         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6811         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6812         (aarch64_gdbarch_init): Add puth registers.
6813         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6814         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6815         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6816
6817 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6818             Jiong Wang  <jiong.wang@arm.com>
6819
6820         * aarch64-linux-nat.c
6821         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6822         * aarch64-linux-tdep.c
6823         (aarch64_linux_core_read_description): Likewise.
6824         (aarch64_linux_get_hwcap): New function.
6825         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6826         (aarch64_linux_get_hwcap): New declaration.
6827
6828 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6829             Jiong Wang  <jiong.wang@arm.com>
6830
6831         * aarch64-linux-nat.c
6832         (aarch64_linux_nat_target::read_description): Add pauth param.
6833         * aarch64-linux-tdep.c
6834         (aarch64_linux_core_read_description): Likewise.
6835         * aarch64-tdep.c (struct target_desc): Add in pauth.
6836         (aarch64_read_description): Add pauth param.
6837         (aarch64_gdbarch_init): Likewise.
6838         * aarch64-tdep.h (aarch64_read_description): Likewise.
6839         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6840         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6841         * features/Makefile: Add new files.
6842         * features/aarch64-pauth.c: New file.
6843         * features/aarch64-pauth.xml: New file.
6844
6845 2019-03-20  Tom Tromey  <tromey@adacore.com>
6846
6847         * infrun.c (handle_inferior_event): Rename from
6848         handle_inferior_event_1.  Create a scoped_value_mark.
6849         (handle_inferior_event): Remove.
6850
6851 2019-03-19  Tom Tromey  <tromey@adacore.com>
6852
6853         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6854         * infrun.h (print_stop_event): Add "displays" parameter.
6855         * infrun.c (print_stop_event): Add "displays" parameter.
6856
6857 2019-03-19  Pedro Alves  <palves@redhat.com>
6858
6859         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6860         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6861         to -1.  Fix TABs vs spaces.
6862         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6863         * tui/tui-out.h (tui_ui_out) Add intro comments.
6864         <m_line, m_start_of_line>: In-class initialize, and add describing
6865         comment.
6866
6867 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6868
6869         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6870         variable names.
6871         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6872
6873 2019-03-18  Pedro Alves  <palves@redhat.com>
6874             Eli Zaretskii <eliz@gnu.org>
6875
6876         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6877         m_line and m_start_of_line.
6878
6879 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6880
6881         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6882         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6883         it returns a newline.  This fixes a regression in TU mode, whereby
6884         the next line is output on the same screen line as the user input.
6885
6886 2019-03-18  Tom Tromey  <tromey@adacore.com>
6887
6888         * minsyms.c (minimal_symbol_reader::install): Remove call to
6889         obstack_blank.
6890
6891 2019-03-18  Pedro Alves  <palves@redhat.com>
6892
6893         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6894         New globals.
6895         (apply_style): New, factored out from ...
6896         (apply_ansi_escape): ... this.  Handle reverse video mode.
6897         (tui_set_reverse_mode): New function.
6898         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6899         * tui/tui-winsource.c (tui_show_source_line): Use
6900         tui_set_reverse_mode instead of setting A_STANDOUT.
6901         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6902         New setter methods.
6903
6904 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6905
6906         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6907         Handle tabs.
6908
6909 2019-03-18  Tom Tromey  <tromey@adacore.com>
6910
6911         * ada-lang.c (empty_array): Add "high" parameter.
6912         (ada_evaluate_subexp): Update.
6913
6914 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6915
6916         * unittests/string_view-selftests.c: Define
6917         _initialize_string_view_selftests unconditionally.
6918
6919 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6920
6921         PR gdb/24350
6922         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6923
6924 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6925
6926         PR gdb/24351
6927         * windows-nat.c (display_selector): Fix format specifiers.
6928
6929 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6930
6931         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6932         tui_refill_source_window instead of tui_refresh_win, to update the
6933         current execution line.  This fixes redisplay of the current line
6934         when stepping through the code with "next" or "step".
6935
6936 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6937
6938         * source-cache.c (source_cache::get_source_lines): Call
6939         find_source_lines to initialize s->nlines.  This fixes vertical
6940         scrolling of TUI source window when the DOWN arrow is pressed.
6941
6942 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6943
6944         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6945         linux-thread-db.c (_initialize_thread_db): Likewise.
6946
6947 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6948
6949         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6950         wclrtoeol in tui_show_source_line".  This reverts changes made in
6951         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6952
6953 2019-03-15  Tom Tromey  <tom@tromey.com>
6954
6955         * symtab.h (struct minimal_symbol): Derive from
6956         general_symbol_info.
6957         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6958         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6959         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6960         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6961         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6962         (MSYMBOL_SEARCH_NAME): Update.
6963         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6964         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6965         * minsyms.c (minimal_symbol_reader::record_full): Update.
6966
6967 2019-03-15  Tom Tromey  <tom@tromey.com>
6968
6969         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6970
6971 2019-03-15  Tom Tromey  <tom@tromey.com>
6972
6973         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6974         unique_xmalloc_ptr.
6975         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6976         Update.
6977         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6978         (build_minimal_symbol_hash_tables)
6979         (minimal_symbol_reader::install): Update.
6980
6981 2019-03-15  Tom Tromey  <tom@tromey.com>
6982
6983         * symtab.c (create_demangled_names_hash): Update.
6984         (symbol_set_names): Update.
6985         * objfiles.h (struct objfile_per_bfd_storage)
6986         <demangled_names_hash>: Now an htab_up.
6987         * objfiles.c (objfile_per_bfd_storage): Simplify.
6988
6989 2019-03-15  Tom Tromey  <tom@tromey.com>
6990
6991         * objfiles.h (struct objfile_per_bfd_storage): Declare
6992         destructor.
6993         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6994         New.
6995         (get_objfile_bfd_data): Use new.  Don't initialize
6996         language_of_main.
6997         (free_objfile_per_bfd_storage): Remove.
6998         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6999
7000 2019-03-15  Tom Tromey  <tom@tromey.com>
7001
7002         * symfile.c (reread_symbols): Update.
7003         * objfiles.c (objfile::objfile): Update.
7004         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7005         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7006         comment.
7007         (minimal_symbol_reader::install): Update.
7008         (terminate_minimal_symbol_table): Remove.
7009         * jit.c (jit_object_close_impl): Update.
7010
7011 2019-03-15  Tom Tromey  <tom@tromey.com>
7012
7013         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7014         initializations.
7015
7016 2019-03-15  Tom Tromey  <tom@tromey.com>
7017
7018         * objfiles.h (struct objfile_per_bfd_storage)
7019         <demangled_hash_languages>: Now a bitset.
7020         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7021         (lookup_minimal_symbol): Update.
7022
7023 2019-03-15  Tom Tromey  <tom@tromey.com>
7024
7025         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7026         Don't return the symbol.
7027         * coffread.c (record_minimal_symbol): Use record_full.
7028
7029 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7030
7031         The MS-Windows port of ncurses fails to switch to a color pair if
7032         one or both of the colors are the implicit default colors.  This
7033         change records the default colors when TUI is initialized, and
7034         then specifies them explicitly when a color pair uses the default
7035         colors.  This allows color styling in TUI mode on MS-Windows.
7036
7037         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7038         ncurses_norm_attr.
7039         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7040         colors in ncurses_norm_attr.
7041         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7042         "none", replace it with the default color recorded in
7043         ncurses_norm_attr.
7044
7045 2019-03-14  Tom Tromey  <tromey@adacore.com>
7046
7047         * source-cache.h (class source_cache) <get_source_lines>: Return
7048         std::string.
7049         * source-cache.c (source_cache::extract_lines): Handle case where
7050         first_pos==npos.  Return std::string.
7051         (source_cache::get_source_lines): Update.
7052
7053 2019-03-14  Tom Tromey  <tromey@adacore.com>
7054
7055         * NEWS: Add item for "style sources" commands.
7056         * source-cache.c (source_cache::get_source_lines): Check
7057         source_styling.
7058         * cli/cli-style.c (source_styling): New global.
7059         (_initialize_cli_style): Add "style sources" commands.
7060         (show_style_sources): New function.
7061         * cli/cli-style.h (source_styling): Declare.
7062
7063 2019-03-14  Pedro Alves  <palves@redhat.com>
7064             Tom Tromey  <tromey@adacore.com>
7065
7066         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7067         * tui/tui-winsource.c (tui_refill_source_window): New function,
7068         from...
7069         (tui_horizontal_source_scroll): ... here.  Move some logic.
7070         * cli/cli-style.c (set_style_enabled): Notify new observable.
7071         * tui/tui-hooks.c (tui_redisplay_source): New function.
7072         (tui_attach_detach_observers): Attach or detach
7073         tui_redisplay_source.
7074         * observable.h (source_styling_changed): New observable.
7075         * observable.c: Define source_styling_changed observable.
7076
7077 2019-03-13  Tom Tromey  <tromey@adacore.com>
7078
7079         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7080         (i386_gnu_nat_target::store_registers): Update.
7081         * target-debug.h (target_debug_print_std_string): New macro.
7082         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7083         * windows-tdep.c (display_one_tib): Update.
7084         * tui/tui-stack.c (tui_make_status_line): Update.
7085         * top.c (print_inferior_quit_action): Update.
7086         * thread.c (thr_try_catch_cmd): Update.
7087         (add_thread_with_info): Update.
7088         (thread_target_id_str): Update.
7089         (thr_try_catch_cmd): Update.
7090         (thread_command): Update.
7091         (thread_find_command): Update.
7092         * record-btrace.c (record_btrace_target::info_record)
7093         (record_btrace_resume_thread, record_btrace_target::resume)
7094         (record_btrace_cancel_resume, record_btrace_step_thread)
7095         (record_btrace_target::wait, record_btrace_target::wait)
7096         (record_btrace_target::wait, record_btrace_target::stop): Update.
7097         * progspace.c (print_program_space): Update.
7098         * process-stratum-target.c
7099         (process_stratum_target::thread_address_space): Update.
7100         * linux-fork.c (linux_fork_mourn_inferior)
7101         (detach_checkpoint_command, info_checkpoints_command)
7102         (linux_fork_context): Update.
7103         (linux_fork_detach): Update.
7104         (class scoped_switch_fork_info): Update.
7105         (delete_checkpoint_command): Update.
7106         * infrun.c (follow_fork_inferior): Update.
7107         (follow_fork_inferior): Update.
7108         (proceed_after_vfork_done): Update.
7109         (handle_vfork_child_exec_or_exit): Update.
7110         (follow_exec): Update.
7111         (displaced_step_prepare_throw): Update.
7112         (displaced_step_restore): Update.
7113         (start_step_over): Update.
7114         (resume_1): Update.
7115         (clear_proceed_status_thread): Update.
7116         (proceed): Update.
7117         (print_target_wait_results): Update.
7118         (do_target_wait): Update.
7119         (context_switch): Update.
7120         (stop_all_threads): Update.
7121         (restart_threads): Update.
7122         (finish_step_over): Update.
7123         (handle_signal_stop): Update.
7124         (switch_back_to_stepped_thread): Update.
7125         (keep_going_pass_signal): Update.
7126         (print_exited_reason): Update.
7127         (normal_stop): Update.
7128         * inferior.c (inferior_pid_to_str): Change return type.
7129         (print_selected_inferior): Update.
7130         (add_inferior): Update.
7131         (detach_inferior): Update.
7132         * dummy-frame.c (fprint_dummy_frames): Update.
7133         * dcache.c (dcache_info_1): Update.
7134         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7135         (btrace_fetch, btrace_clear): Update.
7136         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7137         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7138         type.
7139         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7140         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7141         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7142         * gdbarch.c, gdbarch.h: Rebuild.
7143         * gdbarch.sh (core_pid_to_str): Change return type.
7144         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7145         return type.
7146         (windows_nat_target::pid_to_str): Change return type.
7147         (windows_delete_thread): Update.
7148         (windows_nat_target::attach): Update.
7149         (windows_nat_target::files_info): Update.
7150         * target-delegates.c: Rebuild.
7151         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7152         return type.
7153         (sol_thread_target::pid_to_str): Change return type.
7154         * remote.c (class remote_target) <pid_to_str>: Change return
7155         type.
7156         (remote_target::pid_to_str): Change return type.
7157         (extended_remote_target::attach, remote_target::remote_stop_ns)
7158         (remote_target::remote_notif_remove_queued_reply)
7159         (remote_target::push_stop_reply, remote_target::disable_btrace):
7160         Update.
7161         (extended_remote_target::attach): Update.
7162         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7163         type.
7164         (gdbsim_target::pid_to_str): Change return type.
7165         * ravenscar-thread.c (struct ravenscar_thread_target)
7166         <pid_to_str>: Change return type.
7167         (ravenscar_thread_target::pid_to_str): Change return type.
7168         * procfs.c (class procfs_target) <pid_to_str>: Change return
7169         type.
7170         (procfs_target::pid_to_str): Change return type.
7171         (procfs_target::attach): Update.
7172         (procfs_target::detach): Update.
7173         (procfs_target::fetch_registers): Update.
7174         (procfs_target::store_registers): Update.
7175         (procfs_target::wait): Update.
7176         (procfs_target::files_info): Update.
7177         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7178         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7179         return type.
7180         (nto_procfs_target::pid_to_str): Change return type.
7181         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7182         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7183         return type.
7184         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7185         (exit_lwp): Update.
7186         (attach_proc_task_lwp_callback, get_detach_signal)
7187         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7188         (linux_nat_target::resume, wait_lwp, stop_callback)
7189         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7190         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7191         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7192         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7193         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7194         type.
7195         (inf_ptrace_target::attach): Update.
7196         (inf_ptrace_target::files_info): Update.
7197         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7198         type.
7199         (go32_nat_target::pid_to_str): Change return type.
7200         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7201         (gnu_nat_target::wait): Update.
7202         (gnu_nat_target::wait): Update.
7203         (gnu_nat_target::resume): Update.
7204         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7205         (fbsd_nat_target::wait): Update.
7206         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7207         type.
7208         (darwin_nat_target::attach): Update.
7209         * corelow.c (class core_target) <pid_to_str>: Change return type.
7210         (core_target::pid_to_str): Change return type.
7211         * target.c (normal_pid_to_str): Change return type.
7212         (default_pid_to_str): Likewise.
7213         (target_pid_to_str): Change return type.
7214         (target_translate_tls_address): Update.
7215         (target_announce_detach): Update.
7216         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7217         return type.
7218         (bsd_uthread_target::pid_to_str): Change return type.
7219         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7220         type.
7221         (bsd_kvm_target::pid_to_str): Change return type.
7222         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7223         return type.
7224         (aix_thread_target::pid_to_str): Change return type.
7225         * target.h (struct target_ops) <pid_to_str>: Change return type.
7226         (target_pid_to_str, normal_pid_to_str): Likewise.
7227         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7228         type.
7229         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7230         type.
7231         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7232         return type.
7233         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7234         type.
7235         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7236         type.
7237         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7238         return type.
7239
7240 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7241
7242         * NEWS: Mention that the new default MI version is 3.  Mention
7243         changes to the output of commands and events that deal with
7244         multi-location breakpoints.
7245         * breakpoint.c: Include "mi/mi-out.h".
7246         (print_one_breakpoint): Change output syntax if using MI version
7247         >= 3.
7248         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7249         New.
7250         (mi_multi_location_breakpoint_output_fixed): New.
7251         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7252         (mi_cmd_fix_multi_location_breakpoint_output): New.
7253         (mi_multi_location_breakpoint_output_fixed): New.
7254         * mi/mi-cmds.c (mi_cmds): Register command
7255         -fix-multi-location-breakpoint-output.
7256         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7257         interpreter "mi".
7258
7259 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7260
7261         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7262         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7263         instantiate mi_ui_out based on interpreter name.
7264         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7265         * mi/mi-main.c (mi_load_progress): Likewise.
7266
7267 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7268
7269         * NEWS: Combine separate "New targets" sections for 8.3.
7270
7271 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7272
7273         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7274         (ppcfbsd_init_abi): Install gdbarch
7275         "fetch_tls_load_module_address" and "get_thread_local_address"
7276         methods.
7277
7278 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7279
7280         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7281         (riscv_fbsd_init_abi): Install gdbarch
7282         "fetch_tls_load_module_address" and "get_thread_local_address"
7283         methods.
7284
7285 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7286
7287         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7288         (i386fbsd_init_abi): Install gdbarch
7289         "fetch_tls_load_module_address" and "get_thread_local_address"
7290         methods.
7291
7292 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7293
7294         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7295         (amd64fbsd_init_abi): Install gdbarch
7296         "fetch_tls_load_module_address" and "get_thread_local_address"
7297         methods.
7298
7299 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7300
7301         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7302         (struct fbsd_pspace_data): New type.
7303         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7304         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7305         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7306         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7307         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7308
7309 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7310
7311         * gdbtypes.c (lookup_struct_elt): New function.
7312         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7313         * gdbtypes.h (struct struct_elt): New type.
7314         (lookup_struct_elt): New prototype.
7315
7316 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7317
7318         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7319         remove disabled code block.
7320
7321 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7322
7323         * gdbarch.sh (get_thread_local_address): New method.
7324         * gdbarch.h, gdbarch.c: Regenerate.
7325         * target.c (target_translate_tls_address): Use
7326         gdbarch_get_thread_local_address if present instead of
7327         target::get_thread_local_address.
7328
7329 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7330
7331         * target.h (target::get_thread_local_address): Update comment.
7332
7333 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7334
7335         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7336         objfile->separate_debug_objfile_backlink if not NULL.
7337
7338 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7339
7340         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7341         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7342         (amd64bsd_store_inferior_registers): Likewise.
7343         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7344         Enable segment base registers.
7345         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7346         PT_GETFSBASE and PT_GETGSBASE.
7347         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7348         PT_SETGSBASE.
7349         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7350         segment base registers.
7351         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7352
7353 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7354
7355         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7356         Update calls to i386_target_description to add 'segments'
7357         parameter.
7358         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7359         add segment base registers.
7360         * arch/i386.c (i386_create_target_description): Add 'segments'
7361         parameter to enable segment base registers.
7362         * arch/i386.h (i386_create_target_description): Likewise.
7363         * features/i386/32bit-segments.xml: New file.
7364         * features/i386/32bit-segments.c: Generate.
7365         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7366         call to i386_target_description to add 'segments' parameter.
7367         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7368         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7369         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7370         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7371         if feature is present.
7372         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7373         Add 'segments' parameter to call to i386_target_description.
7374         (i386_target_description): Add 'segments' parameter to enable
7375         segment base registers.
7376         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7377         to call to i386_target_description.
7378         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7379         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7380         Define I386_NUM_REGS.
7381         (i386_target_description): Add 'segments' parameter to enable
7382         segment base registers.
7383
7384 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7385
7386         PR/24325
7387         * source-cache.c: #undef open and close, to avoid unresolved
7388         externals during linking.
7389
7390 2019-03-12  Tom Tromey  <tromey@adacore.com>
7391
7392         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7393         const.  Add initializers.
7394         (_initialize_remote): Don't initialize ptid globals.
7395
7396 2019-03-12  Pedro Alves  <palves@redhat.com>
7397
7398         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7399
7400 2019-03-12  Pedro Alves  <palves@redhat.com>
7401
7402         * cp-name-parser.y (main): Remove unused 'len' variable.
7403
7404 2019-03-12  Tom Tromey  <tromey@adacore.com>
7405
7406         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7407         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7408
7409 2019-03-12  Tom Tromey  <tromey@adacore.com>
7410
7411         * linux-nat.c (iterate_over_lwps): Update.
7412         (stop_callback): Remove parameter.
7413         (stop_wait_callback, detach_callback, resume_set_callback)
7414         (select_singlestep_lwp_callback, set_ignore_sigint)
7415         (status_callback, resumed_callback, resume_clear_callback)
7416         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7417         data parameter.
7418         (linux_nat_target::detach, linux_nat_target::resume)
7419         (linux_stop_and_wait_all_lwps, select_event_lwp)
7420         (linux_nat_filter_event, linux_nat_wait_1)
7421         (linux_nat_target::kill, linux_nat_target::stop)
7422         (linux_nat_target::stop): Update.
7423         (linux_nat_resume_callback): Change type.
7424         (resume_stopped_resumed_lwps, count_events_callback)
7425         (select_event_lwp_callback): Likewise.
7426         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7427         * arm-linux-nat.c (struct update_registers_data): Remove.
7428         (update_registers_callback): Change type.
7429         (arm_linux_insert_hw_breakpoint1): Update.
7430         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7431         parameter.
7432         (x86_linux_dr_set_addr): Update.
7433         (x86_linux_dr_set_control): Update.
7434         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7435         (iterate_over_lwps): Use gdb::function_view.
7436         * nat/aarch64-linux-hw-point.c (struct
7437         aarch64_dr_update_callback_param): Remove.
7438         (debug_reg_change_callback): Change type.
7439         (aarch64_notify_debug_reg_change): Update.
7440         * s390-linux-nat.c (s390_refresh_per_info): Update.
7441
7442 2019-03-11  Tom Tromey  <tromey@adacore.com>
7443
7444         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7445         redundant assignment to "this_cu".
7446
7447 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7448
7449         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7450
7451 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7452
7453         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7454         from...
7455         (rank_one_type): ... this.
7456
7457 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7458
7459         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7460         from...
7461         (rank_one_type): ... this.
7462
7463 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7464
7465         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7466         from...
7467         (rank_one_type): ... this.
7468
7469 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7470
7471         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7472         from...
7473         (rank_one_type): ... this.
7474
7475 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7476
7477         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7478         from...
7479         (rank_one_type): ... this.
7480
7481 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7482
7483         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7484         from...
7485         (rank_one_type): ... this.
7486
7487 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7488
7489         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7490         from...
7491         (rank_one_type): ... this.
7492
7493 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7494
7495         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7496         from...
7497         (rank_one_type): ... this.
7498
7499 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7500
7501         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7502         from...
7503         (rank_one_type): ... this.
7504
7505 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7506
7507         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7508         from...
7509         (rank_one_type): ... this.
7510
7511 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7512
7513         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7514         from...
7515         (rank_one_type): ... this.
7516
7517 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7518
7519         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7520         from...
7521         (rank_one_type): ... this.
7522
7523 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7524
7525         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7526         inferior-events' shows the example events.
7527
7528 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7529
7530         Support styling on native MS-Windows console
7531
7532         PR/24315
7533         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7534         on MS-Windows if $TERM is not defined.
7535
7536         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7537
7538         * posix-hdep.c (gdb_console_fputs):
7539         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7540         functions.
7541         * ui-file.h (gdb_console_fputs): Add prototype.
7542
7543         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7544         back to fputs only if the former returns zero.
7545
7546 2019-03-07  Tom Tromey  <tom@tromey.com>
7547
7548         * symmisc.c (print_symbol_bcache_statistics): Update.
7549         (print_objfile_statistics): Update.
7550         * symfile.c (allocate_symtab): Update.
7551         * stabsread.c: Don't include bcache.h.
7552         * psymtab.h (struct psymbol_bcache): Don't declare.
7553         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7554         (psymbol_bcache_init, psymbol_bcache_free)
7555         (psymbol_bcache_get_bcache): Don't declare.
7556         * psymtab.c (struct psymbol_bcache): Remove.
7557         (psymtab_storage::psymtab_storage): Update.
7558         (psymtab_storage::~psymtab_storage): Update.
7559         (psymbol_bcache_init, psymbol_bcache_free)
7560         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7561         (add_psymbol_to_bcache): Update.
7562         (allocate_psymtab): Update.
7563         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7564         macro_cache>: No longer pointers.
7565         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7566         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7567         * macrotab.c (macro_bcache): Update.
7568         * macroexp.c: Don't include bcache.h.
7569         * gdbtypes.c (check_types_worklist): Update.
7570         (types_deeply_equal): Remove TRY/CATCH.  Update.
7571         * elfread.c (elf_symtab_read): Update.
7572         * dwarf2read.c: Don't include bcache.h.
7573         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7574         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7575         (print_bcache_statistics, bcache_memory_used): Don't declare.
7576         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7577         methods.  Rename all data members.
7578         * bcache.c (struct bcache): Move to bcache.h.
7579         (bcache::expand_hash_table): Rename from expand_hash_table.
7580         (bcache): Remove.
7581         (bcache::insert): Rename from bcache_full.
7582         (bcache::compare): Rename from bcache_compare.
7583         (bcache_xmalloc): Remove.
7584         (bcache::~bcache): Rename from bcache_xfree.
7585         (bcache::print_statistics): Rename from print_bcache_statistics.
7586         (bcache::memory_used): Rename from bcache_memory_used.
7587
7588 2019-03-07  Pedro Alves  <palves@redhat.com>
7589
7590         * infrun.c (normal_stop): Also check for
7591         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7592
7593 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7594
7595         * f-lang.c (value_from_host_double): Moved to...
7596         * value.c (value_from_host_double): ...here.
7597         * value.h (value_from_host_double): Declare.
7598         * guile/scm-math.c (vlscm_convert_typed_number): Use
7599         value_from_host_double.
7600         (vlscm_convert_number): Likewise.
7601         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7602         * python/py-value.c (convert_value_from_python): Likewise.
7603
7604 2019-03-06  Tom Tromey  <tom@tromey.com>
7605
7606         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7607
7608 2019-03-06  Tom Tromey  <tom@tromey.com>
7609
7610         * utils.h (free_current_contents): Don't declare.
7611         * utils.c (free_current_contents): Remove.
7612
7613 2019-03-06  Tom Tromey  <tom@tromey.com>
7614
7615         * top.c (quit_force): Update.
7616         * main.c (captured_command_loop): Update.
7617         * common/new-op.c (operator new): Update.
7618         * common/common-exceptions.c (struct catcher)
7619         <save_cleanup_chain>: Remove member.
7620         (exceptions_state_mc_init): Update.
7621         (exception_try_scope_entry): Return nullptr.
7622         (exception_try_scope_exit, exception_rethrow)
7623         (throw_exception_sjlj, throw_exception_cxx): Update.
7624         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7625         (all_cleanups, do_cleanups, discard_cleanups)
7626         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7627         (restore_cleanups, restore_final_cleanups): Don't declare.
7628         (do_final_cleanups): Remove parameter.
7629         * common/cleanups.c (cleanup_chain, make_cleanup)
7630         (make_cleanup_dtor, all_cleanups, do_cleanups)
7631         (discard_my_cleanups, discard_cleanups)
7632         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7633         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7634         (null_cleanup): Remove.
7635         (do_final_cleanups): Remove parameter.
7636
7637 2019-03-06  Tom Tromey  <tom@tromey.com>
7638
7639         * remote.c (remote_target::remote_parse_stop_reply): Use
7640         unique_xmalloc_ptr.
7641
7642 2019-03-06  Tom Tromey  <tom@tromey.com>
7643
7644         * stabsread.c (struct stabs_field_info): Rename from field_info.
7645         <list, fnlist>: Add initializers.
7646         <obstack>: New member.
7647         (read_member_functions, read_struct_fields, read_baseclasses):
7648         Allocate on obstack.  Don't use cleanups.
7649         (read_one_struct_field, read_member_functions, read_struct_fields)
7650         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7651         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7652         (read_struct_type): Update.
7653
7654 2019-03-06  Tom Tromey  <tom@tromey.com>
7655
7656         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7657         * common/filestuff.h (make_cleanup_close): Don't declare.
7658         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7659         Remove.
7660
7661 2019-03-06  Tom Tromey  <tom@tromey.com>
7662
7663         * solib-aix.c: Use make_scope_exit.
7664
7665 2019-03-06  Tom Tromey  <tom@tromey.com>
7666
7667         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7668         Use make_scope_exit.
7669
7670 2019-03-06  Tom Tromey  <tom@tromey.com>
7671
7672         * solib-svr4.c (disable_probes_interface): Remove parameter.
7673         (svr4_handle_solib_event): Use make_scope_exit.
7674
7675 2019-03-06  Tom Tromey  <tom@tromey.com>
7676
7677         * remote.c (struct stop_reply_deleter): Remove.
7678         (stop_reply_up): Update.
7679         (struct stop_reply): Derive from notif_event.  Don't typedef.
7680         <regcache>: Now a std::vector.
7681         (stop_reply_xfree): Remove.
7682         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7683         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7684         (remote_target::discard_pending_stop_replies): Use delete.
7685         (remote_target::remote_parse_stop_reply): Update.
7686         (remote_target::process_stop_reply): Update.
7687         * remote-notif.h (struct notif_event): Add virtual destructor.
7688         Remove "dtr" member.
7689         (struct notif_client) <alloc_event>: Return a unique_ptr.
7690         (notif_event_xfree): Don't declare.
7691         (notif_event_up): New typedef.
7692         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7693         (notif_event_xfree, do_notif_event_xfree): Remove.
7694         (remote_notif_state_xfree): Update.
7695
7696 2019-03-06  Tom Tromey  <tom@tromey.com>
7697
7698         * infrun.c (displaced_step_clear_cleanup): Now a
7699         forward_scope_exit type.
7700         (displaced_step_prepare_throw): Update.
7701         (displaced_step_fixup): Update.
7702
7703 2019-03-06  Tom Tromey  <tom@tromey.com>
7704
7705         * inferior.h (class inferior): Update comment.
7706         * gdbthread.h (class thread_info): Update comment.
7707
7708 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7709             Tom Tromey  <tom@tromey.com>
7710
7711         * stabsread.h (struct stab_section_list): Remove.
7712         (coffstab_build_psymtabs): Update.
7713         * dbxread.c (symbuf_sections): Now a std::vector.
7714         (sect_idx): New global.
7715         (fill_symbuf): Update.
7716         (coffstab_build_psymtabs): Change type of stabsects parameter.
7717         Update.
7718         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7719         std::vector.
7720         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7721         (coff_locate_sections): Update.
7722         (coff_symfile_read): Remove cleanups.  Update.
7723         (init_stringtab): Add storage parameter.
7724         (free_stringtab, free_stringtab_cleanup): Remove.
7725         (init_lineno): Add storage parameter.
7726         (free_linetab, free_linetab_cleanup): Remove.
7727
7728 2019-03-06  Pedro Alves  <palves@redhat.com>
7729
7730         * linux-fork.c (fork_info::clobber_regs): Delete.
7731         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7732         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7733         comment.  Adjust.
7734         (scoped_switch_fork_info::scoped_switch_fork_info)
7735         (checkpoint_command, linux_fork_context): Adjust
7736         fork_save_infrun_state calls.
7737
7738 2019-03-06  Pedro Alves  <palves@redhat.com>
7739
7740         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7741         (inf_has_multiple_threads): Return 'bool' and rewrite using
7742         inferior_info::threads().
7743
7744 2019-03-06  Pedro Alves  <palves@redhat.com>
7745
7746         * linux-fork.c: Include <list>.
7747         (fork_list): Now a std::list instance.
7748         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7749         (forks_exist_p, find_last_fork): Adjust.
7750         (new_fork): Delete.
7751         (one_fork_p): New.
7752         (add_fork): Adjust.
7753         (free_fork): Delete, folded into fork_info::~fork_info().
7754         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7755         Adjust.
7756         (init_fork_list): Delete.
7757         (linux_fork_killall, linux_fork_mourn_inferior)
7758         (linux_fork_detach, info_checkpoints_command): Adjust.
7759         (_initialize_linux_fork): No longer call init_fork_list.
7760
7761 2019-03-06  Pedro Alves  <palves@redhat.com>
7762
7763         * linux-fork.c (new_fork): New, split out of ...
7764         (add_fork): ... this.  Return void.  Move "first fork" special
7765         case from here, to ...
7766         (checkpoint_command): ... here.
7767         * linux-linux.h (add_fork): Return void.
7768
7769 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7770
7771         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7772
7773 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7774             Chris January  <chris.january@arm.com>
7775             David Lecomber  <david.lecomber@arm.com>
7776
7777         * f-exp.y: New token, UNOP_INTRINSIC.
7778         (exp): New pattern using UNOP_INTRINSIC token.
7779         (f77_keywords): Add 'abs' keyword.
7780         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7781         (value_from_host_double): New function.
7782         (evaluate_subexp_f): Support UNOP_ABS.
7783
7784 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7785
7786         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7787         types.
7788
7789 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7790
7791         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7792         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7793         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7794
7795 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7796
7797         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7798
7799 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7800             Chris January  <chris.january@arm.com>
7801
7802         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7803         * f-exp.y: Define 'KIND' token.
7804         (exp): New pattern for KIND expressions.
7805         (ptype): Handle types with a kind extension.
7806         (direct_abs_decl): Extend to spot kind extensions.
7807         (f77_keywords): Add 'kind' to the list.
7808         (push_kind_type): New function.
7809         (convert_to_kind_type): New function.
7810         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7811         * parse.c (operator_length_standard): Likewise.
7812         * parser-defs.h (enum type_pieces): Add tp_kind.
7813         * std-operator.def: Add UNOP_KIND.
7814
7815 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7816
7817         * f-exp.y (f_parse): Set yydebug.
7818
7819 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7820
7821         * f-lang.c (evaluate_subexp_f): New function.
7822         (exp_descriptor_f): New global.
7823         (f_language_defn): Use exp_descriptor_f instead of
7824         exp_descriptor_standard.
7825
7826 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7827
7828         * f-exp.y (struct token): Add comments.
7829         (dot_ops): Remove uppercase versions and the end marker.
7830         (f77_keywords): Likewise.
7831         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7832         entries in the dot_ops array are case insensitive, and use
7833         strncasecmp to compare strings.  Also some whitespace cleanup in
7834         this area.  Similar for the f77_keywords array, except entries in
7835         this list might be case sensitive.
7836
7837 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7838
7839         * f-exp.y (struct f77_boolean_val): Add comments.
7840         (boolean_values): Remove uppercase versions, and end marker.
7841         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7842         and use strncasecmp to achieve case insensitivity.  Additionally,
7843         perform whitespace cleanup around this code.
7844
7845 2019-03-06  Tom Tromey  <tromey@adacore.com>
7846
7847         * remote-sim.c (gdbsim_target_open): Use result of
7848         gdb_argv::release.
7849
7850 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7851         Dirk Schubert  <dirk.schubert@arm.com>
7852         Chris January  <chris.january@arm.com>
7853
7854         * eval.c (evaluate_subexp_standard): Call Fortran argument
7855         wrapping logic.
7856         * f-lang.c (struct value): A value which can be passed into a
7857         Fortran function call.
7858         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7859         where appropriate.
7860         (struct type): Value ready for a Fortran function call.
7861         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7862         is needed.
7863         * f-lang.h (fortran_argument_convert): Declaration.
7864         (fortran_preserve_arg_pointer): Declaration.
7865         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7866
7867 2019-03-05  Tom Tromey  <tromey@adacore.com>
7868
7869         * python/py-prettyprint.c (print_string_repr): Remove #if.
7870         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7871
7872 2019-03-05  Tom Tromey  <tromey@adacore.com>
7873
7874         * target.c (the_dummy_target): Move later.  Change type to
7875         "dummy_target".
7876         (initialize_targets): Don't initialize the_dummy_target.
7877
7878 2019-03-05  Tom Tromey  <tromey@adacore.com>
7879
7880         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7881         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7882
7883 2019-03-05  Tom Tromey  <tromey@adacore.com>
7884
7885         * windows-nat.c (windows_nat_target::attach)
7886         (windows_nat_target::detach): Don't call gdb_flush.
7887         * valprint.c (generic_val_print, val_print, val_print_string):
7888         Don't call gdb_flush.
7889         * utils.c (defaulted_query): Don't call gdb_flush.
7890         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7891         * target.c (target_announce_detach): Don't call gdb_flush.
7892         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7893         * remote.c (extended_remote_target::attach): Don't call
7894         gdb_flush.
7895         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7896         * printcmd.c (do_examine): Don't call gdb_flush.
7897         (info_display_command): Don't call gdb_flush.
7898         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7899         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7900         * memattr.c (info_mem_command): Don't call gdb_flush.
7901         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7902         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7903         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7904         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7905         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7906         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7907         (gnu_nat_target::detach): Don't call gdb_flush.
7908         * f-valprint.c (f_val_print): Don't call gdb_flush.
7909         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7910         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7911         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7912         gdb_flush.
7913         * c-valprint.c (c_val_print): Don't call gdb_flush.
7914         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7915
7916 2019-03-05  Tom Tromey  <tromey@adacore.com>
7917
7918         * varobj.c (update_dynamic_varobj_children): Update.
7919         (install_default_visualizer): Use reset, not release.
7920         * value.c (set_internalvar): Update.
7921         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7922         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7923         ATTRIBUTE_UNUSED_RESULT.
7924
7925 2019-03-05  Tom Tromey  <tromey@adacore.com>
7926
7927         * remote.c (class scoped_remote_fd) <release>: Add
7928         ATTRIBUTE_UNUSED_RESULT.
7929
7930 2019-03-05  Tom Tromey  <tromey@adacore.com>
7931
7932         * macroexp.c (struct macro_buffer) <release>: Add
7933         ATTRIBUTE_UNUSED_RESULT.
7934
7935 2019-03-05  Tom Tromey  <tromey@adacore.com>
7936
7937         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7938         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7939         ATTRIBUTE_UNUSED_RESULT.
7940
7941 2019-03-05  Tom Tromey  <tromey@adacore.com>
7942
7943         * common/scoped_fd.h (class scoped_fd) <release>: Add
7944         ATTRIBUTE_UNUSED_RESULT.
7945
7946 2019-03-05  Tom Tromey  <tromey@adacore.com>
7947
7948         * parser-defs.h (struct parser_state) <release>: Add
7949         ATTRIBUTE_UNUSED_RESULT.
7950
7951 2019-03-05  Tom Tromey  <tromey@adacore.com>
7952
7953         * utils.h (class gdb_argv) <release>: Add
7954         ATTRIBUTE_UNUSED_RESULT.
7955         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7956
7957 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7958
7959         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7960         for-loop range, to avoid compiler warnings.
7961
7962         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7963         avoid compiler warnings about unused variables.
7964
7965         * NEWS: Mention end of support for native debugging on MS-Windows
7966         before XP.
7967
7968         PR gdb/24292
7969         * common/netstuff.c:
7970         * gdbserver/gdbreplay.c
7971         * gdbserver/remote-utils.c:
7972         * ser-tcp.c:
7973         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7974         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7975         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7976         'getaddrinfo' and 'freeaddrinfo' were not available before
7977         Windows XP, and mingw.org's MinGW headers by default define
7978         _WIN32_WINNT to 0x500.
7979
7980 2019-03-01  Gary Benson <gbenson@redhat.com>
7981
7982         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7983
7984 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7985             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7986
7987         PR gdb/8527
7988         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7989         set_sigint_trap, clear_sigint_trap.
7990
7991 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7992
7993         * target.c (target_detach): Clear the regcache and the
7994         frame cache.
7995
7996 2019-02-27  Pedro Alves  <palves@redhat.com>
7997
7998         * utils.c (set_screen_size): When we cap the height/width sizes,
7999         tweak the corresponding command variable to show "unlimited":
8000
8001 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8002             Pedro Alves  <palves@redhat.com>
8003
8004         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8005         before calling rl_set_screen_size.
8006
8007 2019-02-27  Tom Tromey  <tromey@adacore.com>
8008
8009         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8010         define.
8011         * python/py-value.c: Remove Python 2.4 workaround.
8012         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8013         workaround.
8014         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8015         Python 2.4 workaround.
8016         * python/python-internal.h: Remove Python 2.4 comment.
8017         (Py_ssize_t): Don't define.
8018         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8019         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8020         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8021         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8022         * python/python.c (do_start_initialization): Remove Python 2.4
8023         workaround.
8024         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8025         (print_children): Remove Python 2.4 workaround.
8026         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8027         workaround.
8028         (CHARBUFFERPROC_NAME): Remove.
8029         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8030         Python 2.4 workaround.
8031
8032 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8033
8034         * NEWS: Note minimum Python version.
8035
8036 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8037
8038         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8039         code from these functions.  Remove corresponding ifdefs.  Use
8040         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8041         Remove gotos and target of gotos.
8042         (infpy_search_memory): Likewise.
8043
8044 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8045
8046         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8047         (hppa_gdbarch_init): Don't register deleted functions with
8048         gdbarch.
8049
8050 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8051
8052         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8053         (h8300_unwind_sp): Delete.
8054         (h8300_dummy_id): Delete.
8055         (h8300_gdbarch_init): Don't register deleted functions with
8056         gdbarch.
8057
8058 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8059
8060         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8061         (ft32_unwind_pc): Delete.
8062         (ft32_unwind_sp): Delete.
8063         (ft32_gdbarch_init): Don't register deleted functions with
8064         gdbarch.
8065
8066 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8067
8068         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8069         (frv_unwind_pc): Delete.
8070         (frv_unwind_sp): Delete.
8071         (frv_gdbarch_init): Don't register deleted functions with
8072         gdbarch.
8073
8074 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8075
8076         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8077         (riscv_unwind_pc): Delete.
8078         (riscv_unwind_sp): Delete.
8079         (riscv_gdbarch_init): Don't register deleted functions with
8080         gdbarch.
8081
8082 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8083
8084         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8085         (csky_unwind_pc): Delete.
8086         (csky_unwind_sp): Delete.
8087         (csky_gdbarch_init): Don't register deleted functions with
8088         gdbarch.
8089
8090 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8091
8092         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8093         (cris_unwind_pc): Delete.
8094         (cris_unwind_sp): Delete.
8095         (cris_gdbarch_init): Don't register deleted functions with
8096         gdbarch.
8097
8098 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8099
8100         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8101         (bfin_unwind_pc): Delete.
8102         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8103
8104 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8105
8106         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8107         (arm_unwind_pc): Delete.
8108         (arm_unwind_sp): Delete.
8109         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8110
8111 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8112
8113         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8114         (arc_unwind_pc): Delete.
8115         (arc_unwind_sp): Delete.
8116         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8117
8118 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8119
8120         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8121         (alpha_unwind_pc): Delete.
8122         (alpha_gdbarch_init): Don't register deleted functions with
8123         gdbarch.
8124
8125 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8126
8127         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8128         (aarch64_unwind_pc): Delete.
8129         (aarch64_unwind_sp): Delete.
8130         (aarch64_gdbarch_init): Don't register deleted functions with
8131         gdbarch.
8132
8133 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8134
8135         * gdbtypes.c (type_align): Don't consider static members when
8136         computing structure alignment.
8137
8138 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8139
8140         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8141         return 0 for other types.
8142         * arch-utils.c (default_type_align): Always return 0.
8143         * gdbarch.h: Regenerate.
8144         * gdbarch.sh (type_align): Extend comment.
8145         * gdbtypes.c (type_align): Add additional comments, always call
8146         gdbarch_type_align before applying the default rules.
8147         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8148         generic code will then apply a suitable default.
8149         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8150         types, return 0 for other types.
8151
8152 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8153
8154         * NEWS: Create a new section for the next release branch.
8155         Rename the section of the current branch, now that it has
8156         been cut.
8157
8158 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8159
8160         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8161         * version.in: Bump version to 8.3.50.DATE-git.
8162
8163 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8164
8165         * aix-thread.c (ptid_cmp): Remove unused variable.
8166         (get_signaled_thread): Likewise.
8167         (store_regs_user_thread): Likewise.
8168         (store_regs_kernel_thread): Likewise.
8169         (fetch_regs_kernel_thread): Remove shadowed variable.
8170
8171 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8172
8173         * features/riscv/32bit-cpu.xml: Add register numbers.
8174         * features/riscv/32bit-fpu.c: Regenerate.
8175         * features/riscv/32bit-fpu.xml: Add register numbers.
8176         * features/riscv/64bit-cpu.xml: Add register numbers.
8177         * features/riscv/64bit-fpu.c: Regenerate.
8178         * features/riscv/64bit-fpu.xml: Add register numbers.
8179
8180 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8181
8182         * NEWS: Mention two argument form of gdb.Value constructor.
8183         * python/py-value.c (convert_buffer_and_type_to_value): New
8184         function.
8185         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8186         Add support for handling an optional second argument.  Call
8187         convert_buffer_and_type_to_value as appropriate.
8188         * python/python-internal.h (Py_buffer_deleter): New struct.
8189         (Py_buffer_up): New typedef.
8190
8191 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8192
8193         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8194         instead of releasing ownership.
8195
8196 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8197
8198         * dwarf2read.c (open_and_init_dwp_file): Call
8199         elf_numsections instead of bfd_count_sections to initialize
8200         dwp_file->num_sections.
8201
8202 2019-02-25  Tom Tromey  <tromey@adacore.com>
8203
8204         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8205
8206 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8207
8208         * gcore.in: Add '--readnever' option when invoking GDB.
8209
8210 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8211
8212         * MAINTAINERS: Update my email address.
8213
8214 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8215
8216         * build-id.c (build_id_to_debug_bfd_1): New function.
8217         (build_id_to_debug_bfd): Look for separate debug file in
8218         sysroot.
8219
8220 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8221
8222         * gdbarch.sh: Update the copyright year range that is placed into
8223         generated files.
8224
8225 2019-02-22  Keith Seitz  <keiths@redhat.com>
8226
8227         PR symtab/23853
8228         * linespec.c (create_sals_line_offset): Search for the default
8229         symtab's filename instead of its fullname.
8230
8231 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8232
8233         * NEWS: Update style defaults.
8234
8235 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8236
8237         * main.c (captured_main_1): Disable styling in batch mode.
8238
8239 2019-02-20  Tom Tromey  <tom@tromey.com>
8240
8241         * symtab.c (symtab_symbol_info): Fix typos.
8242
8243 2019-02-20  Tom Tromey  <tromey@adacore.com>
8244
8245         * findcmd.c (_initialize_mem_search): Use upper case for
8246         metasyntactic variables.
8247
8248 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8249
8250         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8251         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8252
8253 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8254
8255         * top.h (source_file_name): Change to std::string.
8256         * top.c (source_file_name): Likewise.
8257         (command_line_input): Adjust.
8258         * cli/cli-script.c (script_from_file): Adjust.
8259
8260 2019-02-19  Tom Tromey  <tromey@adacore.com>
8261
8262         * ravenscar-thread.c
8263         (ravenscar_thread_target::update_thread_list): Don't call
8264         ada_build_task_list.
8265         * ada-lang.h (ada_build_task_list): Don't declare.
8266         * ada-tasks.c (struct ada_tasks_inferior_data)
8267         <task_list_valid_p>: Now bool.
8268         (read_known_tasks, ada_task_list_changed)
8269         (ada_tasks_invalidate_inferior_data): Update.
8270         (read_known_tasks_array): Return bool.
8271         (read_known_tasks_list): Likewise.
8272         (read_known_tasks): Return void.
8273         (ada_build_task_list): Now static.
8274
8275 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8276
8277         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8278         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8279
8280 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8281
8282         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8283         variant for ada_tasks_pspace_data_handle and
8284         ada_tasks_inferior_data_handle.
8285         (ada_tasks_pspace_data_cleanup): New function.
8286         (ada_tasks_inferior_data_cleanup): New function.
8287
8288 2019-02-17  Tom Tromey  <tom@tromey.com>
8289
8290         * macrotab.h (macro_source_fullname): Return a std::string.
8291         * macrotab.c (macro_include, check_for_redefinition)
8292         (macro_undef, macro_lookup_definition, foreach_macro)
8293         (foreach_macro_in_scope): Update.
8294         (macro_source_fullname): Return a std::string.
8295         * macrocmd.c (show_pp_source_pos): Update.
8296
8297 2019-02-17  Tom Tromey  <tom@tromey.com>
8298
8299         * macrocmd.c (show_pp_source_pos): Style the file names.
8300
8301 2019-02-17  Tom Tromey  <tom@tromey.com>
8302
8303         PR tui/24197:
8304         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8305
8306 2019-02-17  Tom Tromey  <tom@tromey.com>
8307
8308         * ada-lang.c (user_select_syms): Use filtered printing.
8309         * utils.c (wrap_style): New global.
8310         (desired_style): Remove.
8311         (emit_style_escape): Add stream parameter.
8312         (set_output_style, reset_terminal_style, prompt_for_continue):
8313         Update.
8314         (flush_wrap_buffer): Only flush gdb_stdout.
8315         (wrap_here): Set wrap_style.
8316         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8317         treat escape sequences as a character.  Change when wrap buffer is
8318         flushed.
8319         (fputs_styled): Do not set the output style when the default is
8320         requested.
8321         * ui-style.h (struct ui_file_style) <is_default>: New method.
8322         * source.c (print_source_lines_base): Emit escape sequences in one
8323         piece.
8324
8325 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8326
8327         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8328         integers and enumeration types.
8329
8330 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8331
8332         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8333         instead of lookup_symbol_in_language
8334         (do_exact_match): New function.
8335         (ada_get_symbol_name_matcher): Return do_exact_match when
8336         doing a verbatim match.
8337
8338 2019-02-15  Tom Tromey  <tromey@adacore.com>
8339
8340         * ravenscar-thread.c (ravenscar_thread_target::resume)
8341         (ravenscar_thread_target::wait): Special case wildcard requests.
8342
8343 2019-02-15  Tom Tromey  <tromey@adacore.com>
8344
8345         * ravenscar-thread.c (base_ptid): Remove.
8346         (struct ravenscar_thread_target) <close>: New method.
8347         <m_base_ptid>: New member.
8348         <update_inferior_ptid, active_task, task_is_currently_active,
8349         runtime_initialized>: Declare methods.
8350         <ravenscar_thread_target>: Add constructor.
8351         (ravenscar_thread_target::task_is_currently_active)
8352         (ravenscar_thread_target::update_inferior_ptid)
8353         (ravenscar_runtime_initialized): Rename.  Now methods.
8354         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8355         (ravenscar_thread_target::update_thread_list): Update.
8356         (ravenscar_thread_target::active_task): Now method.
8357         (ravenscar_thread_target::store_registers)
8358         (ravenscar_thread_target::prepare_to_store)
8359         (ravenscar_thread_target::prepare_to_store)
8360         (ravenscar_thread_target::mourn_inferior): Update.
8361         (ravenscar_inferior_created): Use "new" to create target.
8362         (ravenscar_thread_target::get_ada_task_ptid): Update.
8363         (_initialize_ravenscar): Don't initialize base_ptid.
8364         (ravenscar_ops): Remove global.
8365
8366 2019-02-15  Tom Tromey  <tromey@adacore.com>
8367
8368         * target.h (push_target): Declare new overload.
8369         * target.c (push_target): New overload, taking an rvalue reference.
8370         * remote.c (remote_target::open_1): Use push_target overload.
8371         * corelow.c (core_target_open): Use push_target overload.
8372
8373 2019-02-15  Tom Tromey  <tromey@adacore.com>
8374
8375         * ravenscar-thread.c (is_ravenscar_task)
8376         (ravenscar_task_is_currently_active): Return bool.
8377         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8378         (_initialize_ravenscar): Remove "(void)".
8379         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8380         Return bool.
8381
8382 2019-02-15  Tom Tromey  <tromey@adacore.com>
8383
8384         * ravenscar-thread.c (ravenscar_runtime_initializer)
8385         (has_ravenscar_runtime, get_running_thread_id)
8386         (ravenscar_thread_target::resume): Fix indentation.
8387
8388 2019-02-15  Tom Tromey  <tromey@adacore.com>
8389
8390         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8391         from ravenscar_arch_ops.
8392         (sparc_ravenscar_ops::fetch_registers)
8393         (sparc_ravenscar_ops::store_registers): Now methods.
8394         (sparc_ravenscar_prepare_to_store): Remove.
8395         (sparc_ravenscar_ops): Redefine.
8396         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8397         methods and destructor.  Remove members.
8398         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8399         (ravenscar_thread_target::store_registers)
8400         (ravenscar_thread_target::prepare_to_store): Update.
8401         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8402         Remove.
8403         (struct ppc_ravenscar_powerpc_ops): Derive from
8404         ravenscar_arch_ops.
8405         (ppc_ravenscar_powerpc_ops::fetch_registers)
8406         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8407         (ppc_ravenscar_powerpc_ops): Redefine.
8408         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8409         (ppc_ravenscar_e500_ops::fetch_registers)
8410         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8411         (ppc_ravenscar_e500_ops): Redefine.
8412         * aarch64-ravenscar-thread.c
8413         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8414         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8415         (aarch64_ravenscar_fetch_registers)
8416         (aarch64_ravenscar_store_registers): Now methods.
8417         (aarch64_ravenscar_ops): Redefine.
8418
8419 2019-02-15  Tom Tromey  <tromey@adacore.com>
8420
8421         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8422         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8423         (ravenscar_thread_target::stopped_by_watchpoint)
8424         (ravenscar_thread_target::stopped_data_address)
8425         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8426
8427 2019-02-15  Tom Tromey  <tromey@adacore.com>
8428
8429         * ravenscar-thread.c: Fix some typos.
8430
8431 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8432             Tom Tromey  <tromey@adacore.com>
8433
8434         * ada-lang.c (ada_exception_sal): Change addr_string to a
8435         std::string.
8436         (create_ada_exception_catchpoint): Update.
8437
8438 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8439             Tom Tromey  <tromey@adacore.com>
8440
8441         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8442         (bp_location_ops): Remove.
8443         (base_breakpoint_allocate_location): Update.
8444         (free_bp_location): Update.
8445         * ada-lang.c (class ada_catchpoint_location)
8446         <ada_catchpoint_location>: Remove ops parameter.
8447         (ada_catchpoint_location_dtor): Remove.
8448         (ada_catchpoint_location_ops): Remove.
8449         (allocate_location_exception): Update.
8450         * breakpoint.h (struct bp_location_ops): Remove.
8451         (class bp_location) <bp_location>: Remove bp_location_ops
8452         parameter.
8453         <~bp_location>: Add destructor.
8454         <ops>: Remove.
8455
8456 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8457             Pedro Alves  <palves@redhat.com>
8458
8459         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8460         'PATH_MAX'.
8461
8462 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8463             Samuel Thibault  <samuel.thibault@gnu.org>
8464             Thomas Schwinge  <thomas@codesourcery.com>
8465
8466         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8467         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8468
8469 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8470
8471         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8472         (check_empty): Use "const char *".
8473
8474         * gnu-nat.c (gnu_nat_target::detach): Instead of
8475         'detach_inferior (pid)' call
8476         'detach_inferior (find_inferior_pid (pid))'.
8477
8478         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8479         'nat/fork-inferior.o'.
8480         * gnu-nat.c: #include "nat/fork-inferior.h".
8481
8482         * gnu-nat.c (gnu_nat_target::detach): Instead of
8483         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8484         * gnu-nat.h: #include "inf-child.h".
8485         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8486         'i386_gnu_nat_target::fetch_registers'.
8487         (gnu_store_registers): Rename/move to
8488         'i386_gnu_nat_target::store_registers'.
8489
8490         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8491         * gnu-nat.h (mach_thread_info): New function.
8492         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8493
8494         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8495
8496 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8497
8498         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8499
8500 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8501
8502         * windows-nat.c (windows_add_thread): Add new parameter
8503         "main_thread_p" with default value set to false.  Update
8504         function documentation as well as all callers.
8505         (windows_delete_thread): Likewise.
8506         (fake_create_process): Update call to windows_add_thread.
8507         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8508         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8509         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8510         call to windows_delete_thread.
8511
8512 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8513
8514         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8515
8516 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8517
8518         * symfile.c (find_separate_debug_file): Use canonical path of
8519         sysroot with child_path instead of gdb_sysroot if it is valid.
8520
8521 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8522
8523         * symfile.c (find_separate_debug_file): Use child_path to
8524         determine if an object file is under a sysroot.
8525
8526 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8527
8528         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8529         unittests/child-path-selftests.c.
8530         * common/pathstuff.c (child_path): New function.
8531         * common/pathstuff.h (child_path): New prototype.
8532         * unittests/child-path-selftests.c: New file.
8533
8534 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8535
8536         * symfile.c (find_separate_debug_file): Look for separate debug
8537         files in debug directories under the sysroot.
8538
8539 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8540
8541         * symtab.h (struct minimal_symbol data_p): New const method.
8542         (struct minimal_symbol text_p): Likewise.
8543         * symtab.c (output_source_filename): Use file name style
8544         to print file name.
8545         (print_symbol_info): Likewise.
8546         (print_msymbol_info): Use address style to print addresses.
8547         Use function name style to print executable text symbols.
8548         (expand_symtab_containing_pc): Use data_p.
8549         (find_pc_sect_compunit_symtab): Likewise.
8550
8551 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8552
8553         * breakpoint.c (describe_other_breakpoints): Use address style
8554         to print addresses.
8555         (say_where): Likewise.
8556
8557 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8558
8559         * ada-typeprint.c (print_func_type): Print function name
8560         style to print function name.
8561         * c-typeprint.c (c_print_type_1): Likewise.
8562
8563 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8564
8565         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8566         for execve.
8567
8568 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8569
8570         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8571         type_stack.
8572
8573 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8574
8575         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8576         TYPE_CODE_REF types.
8577
8578 2019-02-08  Jim Wilson  <jimw@sifive.com>
8579
8580         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8581         (riscv_linux_fregset): New.
8582         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8583
8584 2019-02-07  Tom Tromey  <tom@tromey.com>
8585
8586         * thread.c (thread_cancel_execution_command): Update.
8587         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8588         methods.
8589         (struct thread_fsm_ops): Remove.
8590         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8591         (thread_fsm_should_stop, thread_fsm_return_value)
8592         (thread_fsm_set_finished, thread_fsm_finished_p)
8593         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8594         Don't declare.
8595         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8596         * infrun.c (clear_proceed_status_thread)
8597         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8598         (print_stop_event): Update.
8599         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8600         Add constructor.
8601         (step_command_fsm_ops): Remove.
8602         (new_step_command_fsm): Remove.
8603         (step_1): Update.
8604         (step_command_fsm::should_stop): Rename from
8605         step_command_fsm_should_stop.
8606         (step_command_fsm::clean_up): Rename from
8607         step_command_fsm_clean_up.
8608         (step_command_fsm::do_async_reply_reason): Rename from
8609         step_command_fsm_async_reply_reason.
8610         (struct until_next_fsm): Inherit from thread_fsm.  Add
8611         constructor.
8612         (until_next_fsm_ops): Remove.
8613         (new_until_next_fsm): Remove.
8614         (until_next_fsm::should_stop): Rename from
8615         until_next_fsm_should_stop.
8616         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8617         (until_next_fsm::do_async_reply_reason): Rename from
8618         until_next_fsm_async_reply_reason.
8619         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8620         constructor.  Change type of breakpoint.
8621         (finish_command_fsm_ops): Remove.
8622         (new_finish_command_fsm): Remove.
8623         (finish_command_fsm::should_stop): Rename from
8624         finish_command_fsm_should_stop.
8625         (finish_command_fsm::clean_up): Rename from
8626         finish_command_fsm_clean_up.
8627         (finish_command_fsm::return_value): Rename from
8628         finish_command_fsm_return_value.
8629         (finish_command_fsm::do_async_reply_reason): Rename from
8630         finish_command_fsm_async_reply_reason.
8631         (finish_command): Update.
8632         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8633         Add constructor.
8634         (call_thread_fsm_ops): Remove.
8635         (call_thread_fsm::call_thread_fsm): Rename from
8636         new_call_thread_fsm.
8637         (call_thread_fsm::should_stop): Rename from
8638         call_thread_fsm_should_stop.
8639         (call_thread_fsm::should_notify_stop): Rename from
8640         call_thread_fsm_should_notify_stop.
8641         (run_inferior_call, call_function_by_hand_dummy): Update.
8642         * cli/cli-interp.c (should_print_stop_to_console): Update.
8643         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8644         Add constructor.  Change type of location_breakpoint,
8645         caller_breakpoint.
8646         (until_break_fsm_ops): Remove.
8647         (new_until_break_fsm): Remove.
8648         (until_break_fsm::should_stop): Rename from
8649         until_break_fsm_should_stop.
8650         (until_break_fsm::clean_up): Rename from
8651         until_break_fsm_clean_up.
8652         (until_break_fsm::do_async_reply_reason): Rename from
8653         until_break_fsm_async_reply_reason.
8654         (until_break_command): Update.
8655         * thread-fsm.c: Remove.
8656         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8657
8658 2019-02-07  Tom Tromey  <tom@tromey.com>
8659
8660         * yy-remap.h: Add include guard.
8661         * xtensa-tdep.h: Add include guard.
8662         * xcoffread.h: Rename include guard.
8663         * varobj-iter.h: Add include guard.
8664         * tui/tui.h: Rename include guard.
8665         * tui/tui-winsource.h: Rename include guard.
8666         * tui/tui-wingeneral.h: Rename include guard.
8667         * tui/tui-windata.h: Rename include guard.
8668         * tui/tui-win.h: Rename include guard.
8669         * tui/tui-stack.h: Rename include guard.
8670         * tui/tui-source.h: Rename include guard.
8671         * tui/tui-regs.h: Rename include guard.
8672         * tui/tui-out.h: Rename include guard.
8673         * tui/tui-layout.h: Rename include guard.
8674         * tui/tui-io.h: Rename include guard.
8675         * tui/tui-hooks.h: Rename include guard.
8676         * tui/tui-file.h: Rename include guard.
8677         * tui/tui-disasm.h: Rename include guard.
8678         * tui/tui-data.h: Rename include guard.
8679         * tui/tui-command.h: Rename include guard.
8680         * tic6x-tdep.h: Add include guard.
8681         * target/waitstatus.h: Rename include guard.
8682         * target/wait.h: Rename include guard.
8683         * target/target.h: Rename include guard.
8684         * target/resume.h: Rename include guard.
8685         * target-float.h: Rename include guard.
8686         * stabsread.h: Add include guard.
8687         * rs6000-tdep.h: Add include guard.
8688         * riscv-fbsd-tdep.h: Add include guard.
8689         * regformats/regdef.h: Rename include guard.
8690         * record.h: Rename include guard.
8691         * python/python.h: Rename include guard.
8692         * python/python-internal.h: Rename include guard.
8693         * python/py-stopevent.h: Rename include guard.
8694         * python/py-ref.h: Rename include guard.
8695         * python/py-record.h: Rename include guard.
8696         * python/py-record-full.h: Rename include guard.
8697         * python/py-record-btrace.h: Rename include guard.
8698         * python/py-instruction.h: Rename include guard.
8699         * python/py-events.h: Rename include guard.
8700         * python/py-event.h: Rename include guard.
8701         * procfs.h: Add include guard.
8702         * proc-utils.h: Add include guard.
8703         * p-lang.h: Add include guard.
8704         * or1k-tdep.h: Rename include guard.
8705         * observable.h: Rename include guard.
8706         * nto-tdep.h: Rename include guard.
8707         * nat/x86-linux.h: Rename include guard.
8708         * nat/x86-linux-dregs.h: Rename include guard.
8709         * nat/x86-gcc-cpuid.h: Add include guard.
8710         * nat/x86-dregs.h: Rename include guard.
8711         * nat/x86-cpuid.h: Rename include guard.
8712         * nat/ppc-linux.h: Rename include guard.
8713         * nat/mips-linux-watch.h: Rename include guard.
8714         * nat/linux-waitpid.h: Rename include guard.
8715         * nat/linux-ptrace.h: Rename include guard.
8716         * nat/linux-procfs.h: Rename include guard.
8717         * nat/linux-osdata.h: Rename include guard.
8718         * nat/linux-nat.h: Rename include guard.
8719         * nat/linux-namespaces.h: Rename include guard.
8720         * nat/linux-btrace.h: Rename include guard.
8721         * nat/glibc_thread_db.h: Rename include guard.
8722         * nat/gdb_thread_db.h: Rename include guard.
8723         * nat/gdb_ptrace.h: Rename include guard.
8724         * nat/fork-inferior.h: Rename include guard.
8725         * nat/amd64-linux-siginfo.h: Rename include guard.
8726         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8727         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8728         * nat/aarch64-linux.h: Rename include guard.
8729         * nat/aarch64-linux-hw-point.h: Rename include guard.
8730         * mn10300-tdep.h: Add include guard.
8731         * mips-linux-tdep.h: Add include guard.
8732         * mi/mi-parse.h: Rename include guard.
8733         * mi/mi-out.h: Rename include guard.
8734         * mi/mi-main.h: Rename include guard.
8735         * mi/mi-interp.h: Rename include guard.
8736         * mi/mi-getopt.h: Rename include guard.
8737         * mi/mi-console.h: Rename include guard.
8738         * mi/mi-common.h: Rename include guard.
8739         * mi/mi-cmds.h: Rename include guard.
8740         * mi/mi-cmd-break.h: Rename include guard.
8741         * m2-lang.h: Add include guard.
8742         * location.h: Rename include guard.
8743         * linux-record.h: Rename include guard.
8744         * linux-nat.h: Add include guard.
8745         * linux-fork.h: Add include guard.
8746         * i386-darwin-tdep.h: Rename include guard.
8747         * hppa-linux-offsets.h: Add include guard.
8748         * guile/guile.h: Rename include guard.
8749         * guile/guile-internal.h: Rename include guard.
8750         * gnu-nat.h: Rename include guard.
8751         * gdb-stabs.h: Rename include guard.
8752         * frv-tdep.h: Add include guard.
8753         * f-lang.h: Add include guard.
8754         * event-loop.h: Add include guard.
8755         * darwin-nat.h: Rename include guard.
8756         * cp-abi.h: Rename include guard.
8757         * config/sparc/nm-sol2.h: Rename include guard.
8758         * config/nm-nto.h: Rename include guard.
8759         * config/nm-linux.h: Add include guard.
8760         * config/i386/nm-i386gnu.h: Rename include guard.
8761         * config/djgpp/nl_types.h: Rename include guard.
8762         * config/djgpp/langinfo.h: Rename include guard.
8763         * compile/gcc-cp-plugin.h: Add include guard.
8764         * compile/gcc-c-plugin.h: Add include guard.
8765         * compile/compile.h: Rename include guard.
8766         * compile/compile-object-run.h: Rename include guard.
8767         * compile/compile-object-load.h: Rename include guard.
8768         * compile/compile-internal.h: Rename include guard.
8769         * compile/compile-cplus.h: Rename include guard.
8770         * compile/compile-c.h: Rename include guard.
8771         * common/xml-utils.h: Rename include guard.
8772         * common/x86-xstate.h: Rename include guard.
8773         * common/version.h: Rename include guard.
8774         * common/vec.h: Rename include guard.
8775         * common/tdesc.h: Rename include guard.
8776         * common/selftest.h: Rename include guard.
8777         * common/scoped_restore.h: Rename include guard.
8778         * common/scoped_mmap.h: Rename include guard.
8779         * common/scoped_fd.h: Rename include guard.
8780         * common/safe-iterator.h: Rename include guard.
8781         * common/run-time-clock.h: Rename include guard.
8782         * common/refcounted-object.h: Rename include guard.
8783         * common/queue.h: Rename include guard.
8784         * common/ptid.h: Rename include guard.
8785         * common/print-utils.h: Rename include guard.
8786         * common/preprocessor.h: Rename include guard.
8787         * common/pathstuff.h: Rename include guard.
8788         * common/observable.h: Rename include guard.
8789         * common/netstuff.h: Rename include guard.
8790         * common/job-control.h: Rename include guard.
8791         * common/host-defs.h: Rename include guard.
8792         * common/gdb_wait.h: Rename include guard.
8793         * common/gdb_vecs.h: Rename include guard.
8794         * common/gdb_unlinker.h: Rename include guard.
8795         * common/gdb_unique_ptr.h: Rename include guard.
8796         * common/gdb_tilde_expand.h: Rename include guard.
8797         * common/gdb_sys_time.h: Rename include guard.
8798         * common/gdb_string_view.h: Rename include guard.
8799         * common/gdb_splay_tree.h: Rename include guard.
8800         * common/gdb_setjmp.h: Rename include guard.
8801         * common/gdb_ref_ptr.h: Rename include guard.
8802         * common/gdb_optional.h: Rename include guard.
8803         * common/gdb_locale.h: Rename include guard.
8804         * common/gdb_assert.h: Rename include guard.
8805         * common/filtered-iterator.h: Rename include guard.
8806         * common/filestuff.h: Rename include guard.
8807         * common/fileio.h: Rename include guard.
8808         * common/environ.h: Rename include guard.
8809         * common/common-utils.h: Rename include guard.
8810         * common/common-types.h: Rename include guard.
8811         * common/common-regcache.h: Rename include guard.
8812         * common/common-inferior.h: Rename include guard.
8813         * common/common-gdbthread.h: Rename include guard.
8814         * common/common-exceptions.h: Rename include guard.
8815         * common/common-defs.h: Rename include guard.
8816         * common/common-debug.h: Rename include guard.
8817         * common/cleanups.h: Rename include guard.
8818         * common/buffer.h: Rename include guard.
8819         * common/btrace-common.h: Rename include guard.
8820         * common/break-common.h: Rename include guard.
8821         * cli/cli-utils.h: Rename include guard.
8822         * cli/cli-style.h: Rename include guard.
8823         * cli/cli-setshow.h: Rename include guard.
8824         * cli/cli-script.h: Rename include guard.
8825         * cli/cli-interp.h: Rename include guard.
8826         * cli/cli-decode.h: Rename include guard.
8827         * cli/cli-cmds.h: Rename include guard.
8828         * charset-list.h: Add include guard.
8829         * buildsym-legacy.h: Rename include guard.
8830         * bfin-tdep.h: Add include guard.
8831         * ax.h: Rename include guard.
8832         * arm-linux-tdep.h: Add include guard.
8833         * arm-fbsd-tdep.h: Add include guard.
8834         * arch/xtensa.h: Rename include guard.
8835         * arch/tic6x.h: Add include guard.
8836         * arch/i386.h: Add include guard.
8837         * arch/arm.h: Rename include guard.
8838         * arch/arm-linux.h: Rename include guard.
8839         * arch/arm-get-next-pcs.h: Rename include guard.
8840         * arch/amd64.h: Add include guard.
8841         * arch/aarch64-insn.h: Rename include guard.
8842         * arch-utils.h: Rename include guard.
8843         * annotate.h: Add include guard.
8844         * amd64-darwin-tdep.h: Rename include guard.
8845         * aarch64-linux-tdep.h: Add include guard.
8846         * aarch64-fbsd-tdep.h: Add include guard.
8847         * aarch32-linux-nat.h: Add include guard.
8848
8849 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8850
8851         * macrotab.c (macro_define_internal): New function that
8852         factorizes macro_define_object_internal and macro_define_function
8853         code.
8854         (macro_define_object_internal): Use macro_define_internal.
8855         (macro_define_function): Likewise.
8856
8857 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8858
8859         * macrocmd.c (extract_identifier): Return
8860         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8861         callers.
8862
8863 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8864
8865         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8866
8867 2019-02-05  Tom Tromey  <tom@tromey.com>
8868
8869         * target.c (target_stack::unpush): Move assertion earlier.
8870
8871 2019-01-30  Tom Tromey  <tom@tromey.com>
8872
8873         PR python/23615:
8874         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8875         (gdbpy_parse_and_eval): Likewise.
8876         * python/python-internal.h (gdbpy_allow_threads): New class.
8877
8878 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8879
8880         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8881         (aarch64_fbsd_fpregmap): Move earlier.
8882         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8883         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8884         instead of individual calls to trad_frame_set_reg_addr.
8885         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8886         earlier.
8887         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8888         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8889         instead of individual calls to trad_frame_set_reg_addr.
8890
8891 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8892
8893         * CONTRIBUTE: Replace contribution list with wiki link.
8894
8895 2019-01-25  Tom Tromey  <tom@tromey.com>
8896
8897         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8898
8899 2019-01-25  Tom Tromey  <tom@tromey.com>
8900
8901         * xtensa-linux-nat.c: Fix common/ includes.
8902         * xml-support.h: Fix common/ includes.
8903         * xml-support.c: Fix common/ includes.
8904         * x86-linux-nat.c: Fix common/ includes.
8905         * windows-nat.c: Fix common/ includes.
8906         * varobj.h: Fix common/ includes.
8907         * varobj.c: Fix common/ includes.
8908         * value.c: Fix common/ includes.
8909         * valops.c: Fix common/ includes.
8910         * utils.c: Fix common/ includes.
8911         * unittests/xml-utils-selftests.c: Fix common/ includes.
8912         * unittests/utils-selftests.c: Fix common/ includes.
8913         * unittests/unpack-selftests.c: Fix common/ includes.
8914         * unittests/tracepoint-selftests.c: Fix common/ includes.
8915         * unittests/style-selftests.c: Fix common/ includes.
8916         * unittests/string_view-selftests.c: Fix common/ includes.
8917         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8918         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8919         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8920         * unittests/rsp-low-selftests.c: Fix common/ includes.
8921         * unittests/parse-connection-spec-selftests.c: Fix common/
8922         includes.
8923         * unittests/optional-selftests.c: Fix common/ includes.
8924         * unittests/offset-type-selftests.c: Fix common/ includes.
8925         * unittests/observable-selftests.c: Fix common/ includes.
8926         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8927         * unittests/memrange-selftests.c: Fix common/ includes.
8928         * unittests/memory-map-selftests.c: Fix common/ includes.
8929         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8930         * unittests/function-view-selftests.c: Fix common/ includes.
8931         * unittests/environ-selftests.c: Fix common/ includes.
8932         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8933         * unittests/common-utils-selftests.c: Fix common/ includes.
8934         * unittests/cli-utils-selftests.c: Fix common/ includes.
8935         * unittests/array-view-selftests.c: Fix common/ includes.
8936         * ui-file.c: Fix common/ includes.
8937         * tui/tui-io.c: Fix common/ includes.
8938         * tracepoint.h: Fix common/ includes.
8939         * tracepoint.c: Fix common/ includes.
8940         * tracefile-tfile.c: Fix common/ includes.
8941         * top.h: Fix common/ includes.
8942         * top.c: Fix common/ includes.
8943         * thread.c: Fix common/ includes.
8944         * target/waitstatus.h: Fix common/ includes.
8945         * target/waitstatus.c: Fix common/ includes.
8946         * target.h: Fix common/ includes.
8947         * target.c: Fix common/ includes.
8948         * target-memory.c: Fix common/ includes.
8949         * target-descriptions.c: Fix common/ includes.
8950         * symtab.h: Fix common/ includes.
8951         * symfile.c: Fix common/ includes.
8952         * stap-probe.c: Fix common/ includes.
8953         * spu-linux-nat.c: Fix common/ includes.
8954         * sparc-nat.c: Fix common/ includes.
8955         * source.c: Fix common/ includes.
8956         * solib.c: Fix common/ includes.
8957         * solib-target.c: Fix common/ includes.
8958         * ser-unix.c: Fix common/ includes.
8959         * ser-tcp.c: Fix common/ includes.
8960         * ser-pipe.c: Fix common/ includes.
8961         * ser-base.c: Fix common/ includes.
8962         * selftest-arch.c: Fix common/ includes.
8963         * s12z-tdep.c: Fix common/ includes.
8964         * rust-exp.y: Fix common/ includes.
8965         * rs6000-aix-tdep.c: Fix common/ includes.
8966         * riscv-tdep.c: Fix common/ includes.
8967         * remote.c: Fix common/ includes.
8968         * remote-notif.h: Fix common/ includes.
8969         * remote-fileio.h: Fix common/ includes.
8970         * remote-fileio.c: Fix common/ includes.
8971         * regcache.h: Fix common/ includes.
8972         * regcache.c: Fix common/ includes.
8973         * record-btrace.c: Fix common/ includes.
8974         * python/python.c: Fix common/ includes.
8975         * python/py-type.c: Fix common/ includes.
8976         * python/py-inferior.c: Fix common/ includes.
8977         * progspace.h: Fix common/ includes.
8978         * producer.c: Fix common/ includes.
8979         * procfs.c: Fix common/ includes.
8980         * proc-api.c: Fix common/ includes.
8981         * printcmd.c: Fix common/ includes.
8982         * ppc-linux-nat.c: Fix common/ includes.
8983         * parser-defs.h: Fix common/ includes.
8984         * osdata.c: Fix common/ includes.
8985         * obsd-nat.c: Fix common/ includes.
8986         * nat/x86-linux.c: Fix common/ includes.
8987         * nat/x86-linux-dregs.c: Fix common/ includes.
8988         * nat/x86-dregs.h: Fix common/ includes.
8989         * nat/x86-dregs.c: Fix common/ includes.
8990         * nat/ppc-linux.c: Fix common/ includes.
8991         * nat/mips-linux-watch.h: Fix common/ includes.
8992         * nat/mips-linux-watch.c: Fix common/ includes.
8993         * nat/linux-waitpid.c: Fix common/ includes.
8994         * nat/linux-ptrace.h: Fix common/ includes.
8995         * nat/linux-ptrace.c: Fix common/ includes.
8996         * nat/linux-procfs.c: Fix common/ includes.
8997         * nat/linux-personality.c: Fix common/ includes.
8998         * nat/linux-osdata.c: Fix common/ includes.
8999         * nat/linux-namespaces.c: Fix common/ includes.
9000         * nat/linux-btrace.h: Fix common/ includes.
9001         * nat/linux-btrace.c: Fix common/ includes.
9002         * nat/fork-inferior.c: Fix common/ includes.
9003         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9004         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9005         * nat/aarch64-linux.c: Fix common/ includes.
9006         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9007         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9008         * namespace.h: Fix common/ includes.
9009         * mips-linux-tdep.c: Fix common/ includes.
9010         * minsyms.c: Fix common/ includes.
9011         * mi/mi-parse.h: Fix common/ includes.
9012         * mi/mi-main.c: Fix common/ includes.
9013         * mi/mi-cmd-env.c: Fix common/ includes.
9014         * memrange.h: Fix common/ includes.
9015         * memattr.c: Fix common/ includes.
9016         * maint.h: Fix common/ includes.
9017         * maint.c: Fix common/ includes.
9018         * main.c: Fix common/ includes.
9019         * machoread.c: Fix common/ includes.
9020         * location.c: Fix common/ includes.
9021         * linux-thread-db.c: Fix common/ includes.
9022         * linux-nat.c: Fix common/ includes.
9023         * linux-fork.c: Fix common/ includes.
9024         * inline-frame.c: Fix common/ includes.
9025         * infrun.c: Fix common/ includes.
9026         * inflow.c: Fix common/ includes.
9027         * inferior.h: Fix common/ includes.
9028         * inferior.c: Fix common/ includes.
9029         * infcmd.c: Fix common/ includes.
9030         * inf-ptrace.c: Fix common/ includes.
9031         * inf-child.c: Fix common/ includes.
9032         * ia64-linux-nat.c: Fix common/ includes.
9033         * i387-tdep.c: Fix common/ includes.
9034         * i386-tdep.c: Fix common/ includes.
9035         * i386-linux-tdep.c: Fix common/ includes.
9036         * i386-linux-nat.c: Fix common/ includes.
9037         * i386-go32-tdep.c: Fix common/ includes.
9038         * i386-fbsd-tdep.c: Fix common/ includes.
9039         * i386-fbsd-nat.c: Fix common/ includes.
9040         * guile/scm-type.c: Fix common/ includes.
9041         * guile/guile.c: Fix common/ includes.
9042         * go32-nat.c: Fix common/ includes.
9043         * gnu-nat.c: Fix common/ includes.
9044         * gdbthread.h: Fix common/ includes.
9045         * gdbarch-selftests.c: Fix common/ includes.
9046         * gdb_usleep.c: Fix common/ includes.
9047         * gdb_select.h: Fix common/ includes.
9048         * gdb_bfd.c: Fix common/ includes.
9049         * gcore.c: Fix common/ includes.
9050         * fork-child.c: Fix common/ includes.
9051         * findvar.c: Fix common/ includes.
9052         * fbsd-nat.c: Fix common/ includes.
9053         * event-top.c: Fix common/ includes.
9054         * event-loop.c: Fix common/ includes.
9055         * dwarf2read.c: Fix common/ includes.
9056         * dwarf2loc.c: Fix common/ includes.
9057         * dwarf2-frame.c: Fix common/ includes.
9058         * dwarf-index-cache.c: Fix common/ includes.
9059         * dtrace-probe.c: Fix common/ includes.
9060         * disasm-selftests.c: Fix common/ includes.
9061         * defs.h: Fix common/ includes.
9062         * csky-tdep.c: Fix common/ includes.
9063         * cp-valprint.c: Fix common/ includes.
9064         * cp-support.h: Fix common/ includes.
9065         * cp-support.c: Fix common/ includes.
9066         * corelow.c: Fix common/ includes.
9067         * completer.h: Fix common/ includes.
9068         * completer.c: Fix common/ includes.
9069         * compile/compile.c: Fix common/ includes.
9070         * compile/compile-loc2c.c: Fix common/ includes.
9071         * compile/compile-cplus-types.c: Fix common/ includes.
9072         * compile/compile-cplus-symbols.c: Fix common/ includes.
9073         * command.h: Fix common/ includes.
9074         * cli/cli-dump.c: Fix common/ includes.
9075         * cli/cli-cmds.c: Fix common/ includes.
9076         * charset.c: Fix common/ includes.
9077         * build-id.c: Fix common/ includes.
9078         * btrace.h: Fix common/ includes.
9079         * btrace.c: Fix common/ includes.
9080         * breakpoint.h: Fix common/ includes.
9081         * breakpoint.c: Fix common/ includes.
9082         * ax.h:
9083         (enum agent_op): Fix common/ includes.
9084         * ax-general.c (struct aop_map): Fix common/ includes.
9085         * ax-gdb.c: Fix common/ includes.
9086         * auxv.c: Fix common/ includes.
9087         * auto-load.c: Fix common/ includes.
9088         * arm-tdep.c: Fix common/ includes.
9089         * arch/riscv.c: Fix common/ includes.
9090         * arch/ppc-linux-common.c: Fix common/ includes.
9091         * arch/i386.c: Fix common/ includes.
9092         * arch/arm.c: Fix common/ includes.
9093         * arch/arm-linux.c: Fix common/ includes.
9094         * arch/arm-get-next-pcs.c: Fix common/ includes.
9095         * arch/amd64.c: Fix common/ includes.
9096         * arch/aarch64.c: Fix common/ includes.
9097         * arch/aarch64-insn.c: Fix common/ includes.
9098         * arch-utils.c: Fix common/ includes.
9099         * amd64-windows-tdep.c: Fix common/ includes.
9100         * amd64-tdep.c: Fix common/ includes.
9101         * amd64-sol2-tdep.c: Fix common/ includes.
9102         * amd64-obsd-tdep.c: Fix common/ includes.
9103         * amd64-nbsd-tdep.c: Fix common/ includes.
9104         * amd64-linux-tdep.c: Fix common/ includes.
9105         * amd64-linux-nat.c: Fix common/ includes.
9106         * amd64-fbsd-tdep.c: Fix common/ includes.
9107         * amd64-fbsd-nat.c: Fix common/ includes.
9108         * amd64-dicos-tdep.c: Fix common/ includes.
9109         * amd64-darwin-tdep.c: Fix common/ includes.
9110         * agent.c: Fix common/ includes.
9111         * ada-lang.h: Fix common/ includes.
9112         * ada-lang.c: Fix common/ includes.
9113         * aarch64-tdep.c: Fix common/ includes.
9114
9115 2019-01-25  Tom Tromey  <tom@tromey.com>
9116
9117         * common/create-version.sh: Use common/version.h.
9118
9119 2019-01-24  Pedro Alves  <palves@redhat.com>
9120
9121         * infrun.c (signal_stop, signal_print, signal_program)
9122         (signal_catch, signal_pass): Now arrays instead of pointers.
9123         (update_signals_program_target, do_target_resume)
9124         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9125         * linux-nat.c (linux_nat_target::pass_signals)
9126         (linux_nat_target::create_inferior, linux_nat_target::attach):
9127         Adjust.
9128         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9129         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9130         * procfs.c (procfs_target::pass_signals): Adjust.
9131         * record-full.c (record_full_target::resume): Adjust.
9132         * remote.c (remote_target::pass_signals)
9133         (remote_target::program_signals): Adjust.
9134         * target-debug.h (target_debug_print_signals): Now takes a
9135         gdb::array_view as parameter.  Adjust.
9136         * target.h (target_ops) <pass_signals, program_signals>: Replace
9137         pointer and length parameters with gdb::array_view.
9138         (target_pass_signals, target_program_signals): Likewise.
9139         * target-delegates.c: Regenerate.
9140
9141 2019-01-24  Pedro Alves  <palves@redhat.com>
9142
9143         * common/forward-scope-exit.h
9144         (forward_scope_exit::forward_scope_exit): Pass arguments to
9145         m_bind_function directly, instead of creating a std::bind and
9146         copying that.
9147
9148 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9149
9150         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9151         for static members.
9152         (pass_in_v_vfp_candidate): Likewise.
9153
9154 2019-01-23  Tom Tromey  <tom@tromey.com>
9155             Pedro Alves  <palves@redhat.com>
9156
9157         * regcache.c (class regcache_invalidator): Remove.
9158         (regcache::raw_write): Use make_scope_exit.
9159
9160 2019-01-23  Tom Tromey  <tom@tromey.com>
9161
9162         * ui-out.h (class ui_out_emit_type): Update comment.
9163
9164 2019-01-23  Tom Tromey  <tom@tromey.com>
9165
9166         * infrun.c (fetch_inferior_event): Update comment.
9167
9168 2019-01-23  Tom Tromey  <tom@tromey.com>
9169             Pedro Alves  <palves@redhat.com>
9170
9171         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9172         parameter.
9173         (fetch_inferior_event): Use SCOPE_EXIT.
9174
9175
9176 2019-01-23  Tom Tromey  <tom@tromey.com>
9177             Pedro Alves  <palves@redhat.com>
9178
9179         * infrun.c (disable_thread_events): Delete.
9180         (stop_all_threads): Use SCOPE_EXIT.
9181
9182 2019-01-23  Tom Tromey  <tom@tromey.com>
9183             Pedro Alves  <palves@redhat.com>
9184
9185         * symfile.c: Include forward-scope-exit.h.
9186         (clear_symtab_users_cleanup): Replace forward declaration with
9187         a FORWARD_SCOPE_EXIT.
9188         (syms_from_objfile_1): Use the forward_scope_exit and
9189         gdb::optional instead of cleanup_function.
9190         (reread_symbols): Use the forward_scope_exit instead of
9191         cleanup_function.
9192         (clear_symtab_users_cleanup): Remove function.
9193
9194 2019-01-23  Tom Tromey  <tom@tromey.com>
9195             Pedro Alves  <palves@redhat.com>
9196
9197         * linux-nat.c: Include scope-exit.h.
9198         (cleanup_target_stop): Remove.
9199         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9200         SCOPE_EXIT.
9201
9202 2019-01-23  Tom Tromey  <tom@tromey.com>
9203             Pedro Alves  <palves@redhat.com>
9204
9205         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9206         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9207
9208 2019-01-23  Tom Tromey  <tom@tromey.com>
9209             Andrew Burgess  <andrew.burgess@embecosm.com>
9210             Pedro Alves  <palves@redhat.com>
9211
9212         * infrun.c (fetch_inferior_event): Use scope_exit.
9213         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9214         * top.c (execute_command): Use scope_exit.
9215         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9216         * utils.c (do_bpstat_clear_actions_cleanup)
9217         (make_bpstat_clear_actions_cleanup): Remove.
9218
9219 2019-01-23  Tom Tromey  <tom@tromey.com>
9220             Pedro Alves  <palves@redhat.com>
9221
9222         * infrun.c: Include "common/scope-exit.h"
9223         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9224         (wait_for_inferior): Use SCOPE_EXIT.
9225         (fetch_inferior_event): Use scope_exit.
9226
9227 2019-01-23  Tom Tromey  <tom@tromey.com>
9228             Pedro Alves  <palves@redhat.com>
9229
9230         * breakpoint.c (create_breakpoint): Remove cleanup.
9231
9232 2019-01-23  Tom Tromey  <tom@tromey.com>
9233             Andrew Burgess  <andrew.burgess@embecosm.com>
9234             Pedro Alves  <palves@redhat.com>
9235
9236 2019-01-23  Pedro Alves  <palves@redhat.com>
9237
9238         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9239
9240 2019-01-23  Pedro Alves  <palves@redhat.com>
9241             Andrew Burgess  <andrew.burgess@embecosm.com>
9242
9243         * gdbthread.h: Include "common/forward-scope-exit.h".
9244         (scoped_finish_thread_state): Redefine custom class in terms of
9245         forward_scope_exit.
9246
9247 2019-01-23  Pedro Alves  <palves@redhat.com>
9248             Andrew Burgess  <andrew.burgess@embecosm.com>
9249
9250         * common/forward-scope-exit.h: New file.
9251
9252 2019-01-23  Pedro Alves  <palves@redhat.com>
9253             Andrew Burgess  <andrew.burgess@embecosm.com>
9254             Tom Tromey  <tom@tromey.com>
9255
9256         * common/scope-exit.h: New file.
9257
9258 2019-01-23  Pedro Alves  <palves@redhat.com>
9259
9260         * common/preprocessor.h (ESC): Rename to ...
9261         (ESC_PARENS): ... this.
9262         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9263         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9264
9265 2019-01-23  Tom Tromey  <tom@tromey.com>
9266
9267         * language.h (class scoped_switch_to_sym_language_if_auto):
9268         Initialize m_lang in both cases.
9269
9270 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9271
9272         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9273         with XCNEW.
9274
9275 2019-01-22  Tom Tromey  <tom@tromey.com>
9276
9277         * corelow.c: Do not include sys/file.h.
9278
9279 2019-01-22  Tom Tromey  <tom@tromey.com>
9280
9281         * tui/tui-wingeneral.h: Include gdb_curses.h.
9282
9283 2019-01-22  Tom Tromey  <tom@tromey.com>
9284
9285         * source-cache.h (class source_cache) <get_source_lines,
9286         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9287
9288 2019-01-22  Tom Tromey  <tom@tromey.com>
9289
9290         * remote-fileio.h (struct remote_target): Declare.
9291
9292 2019-01-22  Tom Tromey  <tom@tromey.com>
9293
9294         * python/py-arch.c: Do not include py-ref.h.
9295         * python/py-bpevent.c: Do not include py-ref.h.
9296         * python/py-cmd.c: Do not include py-ref.h.
9297         * python/py-continueevent.c: Do not include py-ref.h.
9298         * python/py-event.h: Do not include py-ref.h.
9299         * python/py-evtregistry.c: Do not include py-ref.h.
9300         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9301         * python/py-frame.c: Do not include py-ref.h.
9302         * python/py-framefilter.c: Do not include py-ref.h.
9303         * python/py-function.c: Do not include py-ref.h.
9304         * python/py-infevents.c: Do not include py-ref.h.
9305         * python/py-linetable.c: Do not include py-ref.h.
9306         * python/py-objfile.c: Do not include py-ref.h.
9307         * python/py-param.c: Do not include py-ref.h.
9308         * python/py-prettyprint.c: Do not include py-ref.h.
9309         * python/py-progspace.c: Do not include py-ref.h.
9310         * python/py-symbol.c: Do not include py-ref.h.
9311         * python/py-symtab.c: Do not include py-ref.h.
9312         * python/py-type.c: Do not include py-ref.h.
9313         * python/py-unwind.c: Do not include py-ref.h.
9314         * python/py-utils.c: Do not include py-ref.h.
9315         * python/py-value.c: Do not include py-ref.h.
9316         * python/py-varobj.c: Do not include py-ref.h.
9317         * python/py-xmethods.c: Do not include py-ref.h.
9318         * python/python.c: Do not include py-ref.h.
9319         * varobj.c: Do not include py-ref.h.
9320
9321 2019-01-22  Tom Tromey  <tom@tromey.com>
9322
9323         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9324         keyword for bcache.
9325
9326 2019-01-22  Tom Tromey  <tom@tromey.com>
9327
9328         * compile/compile-cplus-types.c: Remove a comment by #include.
9329
9330 2019-01-22  Tom Tromey  <tom@tromey.com>
9331
9332         * compile/gcc-c-plugin.h: Include compile-internal.h.
9333
9334 2019-01-22  Tom Tromey  <tom@tromey.com>
9335
9336         * stabsread.c (EXTERN): Do not define.
9337         (symnum, next_symbol_text_func, processing_gcc_compilation)
9338         (within_function, global_sym_chain, global_stabs)
9339         (previous_stab_code, this_object_header_files)
9340         (n_this_object_header_files)
9341         (n_allocated_this_object_header_files): Define.
9342         * stabsread.h (EXTERN): Never define.  Use "extern".
9343
9344 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9345
9346         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9347         history_value.
9348
9349 2019-01-21  Tom Tromey  <tom@tromey.com>
9350
9351         * ui-out.c: Fix includes.
9352         * tui/tui-source.c: Fix includes.
9353         * target.c: Fix includes.
9354         * remote.c: Fix includes.
9355         * regcache.c: Fix includes.
9356         * python/py-block.c: Fix includes.
9357         * printcmd.c: Fix includes.
9358         * or1k-tdep.c: Fix includes.
9359         * mi/mi-main.c: Fix includes.
9360         * m32r-tdep.c: Fix includes.
9361         * csky-tdep.c: Fix includes.
9362         * compile/compile-cplus-types.c: Fix includes.
9363         * cli/cli-interp.c: Fix includes.
9364
9365 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9366
9367         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9368         for padding.
9369
9370 2019-01-16  Tom Tromey  <tom@tromey.com>
9371
9372         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9373         earlier.
9374         (struct objfile) <msymbols_range>: Move from top level.
9375         <msymbols>: New method.
9376         (class objfile_msymbols): Remove.
9377         * symtab.c (default_collect_symbol_completion_matches_break_on):
9378         Update.
9379         * symmisc.c (dump_msymbols): Update.
9380         * stabsread.c (scan_file_globals): Update.
9381         * objc-lang.c (info_selectors_command, info_classes_command)
9382         (find_methods): Update.
9383         * minsyms.c (find_solib_trampoline_target): Update.
9384         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9385         * coffread.c (coff_symfile_read): Update.
9386         * ada-lang.c (ada_lookup_simple_minsym)
9387         (ada_collect_symbol_completion_matches): Update.
9388
9389 2019-01-16  Tom Tromey  <tom@tromey.com>
9390
9391         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9392         type.  Remove no-argument constructor.
9393         <iterator::operator++>: Simplify.
9394         <begin>: Update.
9395         <end>: Use minimal_symbol_count.
9396
9397 2019-01-16  Tom Tromey  <tom@tromey.com>
9398
9399         * objfiles.h (struct objfile) <psymtabs>: New method.
9400         (class objfile_psymtabs): Remove.
9401         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9402         typedef.
9403         <range>: New method.
9404         (require_partial_symbols): Change return type.
9405         * psymtab.c (require_partial_symbols)
9406         (psym_expand_symtabs_matching): Update.
9407         * mdebugread.c (parse_partial_symbols): Update.
9408         * dbxread.c (dbx_end_psymtab): Update.
9409
9410 2019-01-15  Tom Tromey  <tom@tromey.com>
9411
9412         * symtab.c (lookup_objfile_from_block)
9413         (lookup_symbol_in_objfile_symtabs)
9414         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9415         (find_line_symtab, info_sources_command)
9416         (default_collect_symbol_completion_matches_break_on)
9417         (make_source_files_completion_list): Update.
9418         * symmisc.c (print_objfile_statistics, dump_objfile)
9419         (maintenance_print_symbols, maintenance_info_symtabs)
9420         (maintenance_check_symtabs, maintenance_info_line_tables):
9421         Update.
9422         * source.c (select_source_symtab)
9423         (forget_cached_source_info_for_objfile): Update.
9424         * objfiles.h (class objfile_compunits): Remove.
9425         (struct objfile) <compunits_range>: New typedef.
9426         (compunits): New method.
9427         * objfiles.c (objfile_relocate1): Update.
9428         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9429         * maint.c (count_symtabs_and_blocks): Update.
9430         * linespec.c (iterate_over_all_matching_symtabs): Update.
9431         * cp-support.c (add_symbol_overload_list_qualified): Update.
9432         * coffread.c (coff_symtab_read): Update.
9433         * ada-lang.c (add_nonlocal_symbols)
9434         (ada_collect_symbol_completion_matches)
9435         (ada_add_global_exceptions): Update.
9436
9437 2019-01-15  Tom Tromey  <tom@tromey.com>
9438
9439         * progspace.h (program_space) <objfiles_safe_range>: New
9440         typedef.
9441         <objfiles_safe>: New method.
9442         * objfiles.h (class all_objfiles_safe): Remove.
9443         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9444         * jit.c (jit_inferior_exit_hook): Update.
9445
9446 2019-01-17  Tom Tromey  <tom@tromey.com>
9447
9448         * progspace.h (program_space) <objfiles_range>: New typedef.
9449         <objfiles>: New method.
9450         <objfiles_head>: Rename from objfiles.
9451         (object_files): Update.
9452         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9453         * guile/scm-pretty-print.c
9454         (ppscm_find_pretty_printer_from_objfiles): Update.
9455         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9456         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9457         Update.
9458         * python/py-progspace.c (pspy_get_objfiles): Update.
9459         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9460         Update.
9461         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9462         (objfpy_lookup_objfile_by_build_id): Update.
9463         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9464         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9465         Update.
9466         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9467         (expand_symtab_containing_pc, lookup_objfile_from_block)
9468         (lookup_static_symbol, basic_lookup_transparent_type)
9469         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9470         (find_line_symtab, info_sources_command)
9471         (default_collect_symbol_completion_matches_break_on)
9472         (make_source_files_completion_list, find_main_name): Update.
9473         * symmisc.c (print_symbol_bcache_statistics)
9474         (print_objfile_statistics, maintenance_print_symbols)
9475         (maintenance_print_msymbols, maintenance_print_objfiles)
9476         (maintenance_info_symtabs, maintenance_check_symtabs)
9477         (maintenance_expand_symtabs, maintenance_info_line_tables):
9478         Update.
9479         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9480         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9481         (map_overlay_command, unmap_overlay_command)
9482         (simple_overlay_update, expand_symtabs_matching)
9483         (map_symbol_filenames): Update.
9484         * symfile-debug.c (set_debug_symfile): Update.
9485         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9486         Update.
9487         * source.c (select_source_symtab, forget_cached_source_info):
9488         Update.
9489         * solib.c (solib_read_symbols): Update.
9490         * solib-spu.c (append_ocl_sos): Update.
9491         * psymtab.c (maintenance_print_psymbols)
9492         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9493         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9494         * printcmd.c (info_symbol_command): Update.
9495         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9496         Update.
9497         * objfiles.h (class all_objfiles): Remove.
9498         * objfiles.c (have_partial_symbols, have_full_symbols)
9499         (have_minimal_symbols, qsort_cmp, update_section_map)
9500         (shared_objfile_contains_address_p)
9501         (default_iterate_over_objfiles_in_search_order): Update.
9502         * objc-lang.c (info_selectors_command, info_classes_command)
9503         (find_methods): Update.
9504         * minsyms.c (find_solib_trampoline_target): Update.
9505         * maint.c (maintenance_info_sections)
9506         (maintenance_translate_address, count_symtabs_and_blocks):
9507         Update.
9508         * main.c (captured_main_1): Update.
9509         * linux-thread-db.c (try_thread_db_load_from_pdir)
9510         (has_libpthread): Update.
9511         * linespec.c (iterate_over_all_matching_symtabs)
9512         (search_minsyms_for_name): Update.
9513         * jit.c (jit_find_objf_with_entry_addr): Update.
9514         * hppa-tdep.c (find_unwind_entry)
9515         (hppa_lookup_stub_minimal_symbol): Update.
9516         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9517         Update.
9518         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9519         (elf_gnu_ifunc_resolve_by_got): Update.
9520         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9521         * dwarf-index-write.c (save_gdb_index_command): Update.
9522         * cp-support.c (add_symbol_overload_list_qualified): Update.
9523         * breakpoint.c (create_overlay_event_breakpoint)
9524         (create_longjmp_master_breakpoint)
9525         (create_std_terminate_master_breakpoint)
9526         (create_exception_master_breakpoint): Update.
9527         * blockframe.c (find_pc_partial_function): Update.
9528         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9529         (ada_collect_symbol_completion_matches)
9530         (ada_add_global_exceptions): Update.
9531
9532 2019-01-17  Tom Tromey  <tom@tromey.com>
9533
9534         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9535         declare VEC.
9536         (solib_target_parse_libraries): Change return type.
9537         (library_list_start_segment, library_list_start_section)
9538         (library_list_end_library, library_list_start_library); Update.
9539         (solib_target_free_library_list): Remove.
9540         (solib_target_parse_libraries): Remove cleanup.  Change return
9541         type.
9542         (solib_target_current_sos): Update.
9543
9544 2019-01-17  Tom Tromey  <tromey@bapiya>
9545
9546         * valprint.c: Replace "the the" with "the".
9547         * symtab.c: Replace "the the" with "the".
9548         * solib.c: Replace "the the" with "the".
9549         * solib-dsbt.c: Replace "the the" with "the".
9550         * linespec.c: Replace "the the" with "the".
9551         * dwarf2loc.h: Replace "the the" with "the".
9552         * amd64-windows-tdep.c: Replace "the the" with "the".
9553         * aarch64-tdep.c: Replace "the the" with "the".
9554
9555 2019-01-16  Keith Seitz  <keiths@redhat.com>
9556
9557         PR gdb/23773
9558         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9559         <builder>: Rename to ..
9560         <m_builder>: ... this and make private.
9561         (dwarf2_cu::get_builder): New method.  Change all users of
9562         `builder' to use this method.
9563         (dwarf2_start_symtab): Move to ...
9564         (dwarf2_cu::start_symtab): ... here.  Update all callers
9565         (setup_type_unit_groups): Move to ...
9566         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9567         callers.
9568         (dwarf2_cu::reset_builder): New method.
9569         (process_full_compunit, process_full_type_unit): Use
9570         dwarf2_cu::reset_builder.
9571         (follow_die_offset): Record the ancestor CU if it is different
9572         from the followed DIE's CU.
9573         (follow_die_sig_1): Likewise.
9574
9575 2019-01-15  Tom Tromey  <tom@tromey.com>
9576
9577         * remote.c (class remote_state) <buf>: Now a char_vector.
9578         <buf_size>: Remove.
9579         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9580         parameter.
9581         (remote_target::getpkt_or_notif_sane_1)
9582         (remote_target::getpkt_sane)
9583         (remote_target::getpkt_or_notif_sane): Likewise.
9584         (class remote_target) <putpkt>: New overload.
9585         (remote_target::read_frame): Change type of "buf_p".  Remove
9586         sizeof_p parameter.
9587         (packet_ok): New overload.
9588         (packet_check_result): New overload.
9589         Update all uses.
9590
9591 2019-01-14  Tom Tromey  <tom@tromey.com>
9592
9593         * remote-notif.c (handle_notification, remote_notif_ack)
9594         (remote_notif_parse): Make "buf" const.
9595         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9596         const.
9597         (remote_notif_parse, remote_notif_ack, handle_notification):
9598         Likewise.
9599         * remote.c (remote_notif_stop_parse): Make "buf" const.
9600         (remote_target::remote_parse_stop_reply): Make "buf" const.
9601         (remote_notif_stop_ack): Make "buf" const.
9602
9603 2019-01-14  Tom Tromey  <tom@tromey.com>
9604
9605         * remote.c (remote_console_output): Make parameter const.
9606
9607 2019-01-14  Tom Tromey  <tom@tromey.com>
9608
9609         * target-debug.h (target_debug_print_signals): Constify.
9610         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9611         * procfs.c (procfs_target::pass_signals): Update.
9612         * linux-nat.c (linux_nat_target::pass_signals): Update.
9613         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9614         * target-delegates.c: Rebuild.
9615         * remote.c (remote_target::program_signals): Update.
9616         (remote_target::pass_signals): Update.
9617         * target.c (target_pass_signals): Constify argument.
9618         (target_program_signals): Likewise.
9619         * target.h (struct target_ops) <pass_signals, program_signals>:
9620         Constify argument.
9621         (target_pass_signals, target_program_signals): Constify argument.
9622
9623 2019-01-14  Tom Tromey  <tom@tromey.com>
9624
9625         PR tui/28819:
9626         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9627
9628 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9629
9630         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9631         field.
9632         * rs6000-tdep.c: Include reggroups.h.
9633         (IS_V_ALIAS_PSEUDOREG): Define.
9634         (rs6000_register_name): Return names for the "vX" aliases.
9635         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9636         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9637         aliases.  Call default_register_reggroup_p for all other
9638         pseudo-registers.
9639         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9640         New functions.
9641         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9642         Handle "vX" aliases.
9643         (v_alias_pseudo_register_collect): New function.
9644         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9645         (rs6000_gdbarch_init): Initialize "vX" aliases as
9646         pseudo-registers.  Restore registration of
9647         rs6000_pseudo_register_reggroup_p with
9648         set_tdesc_pseudo_register_reggroup_p.
9649
9650 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9651
9652         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9653         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9654         set_gdbarch_num_pseudo_regs.
9655
9656 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9657
9658         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9659         Remove arg prefixname, add do_set and do_show.
9660         Add member functions set_list and show_list.
9661         * cli/cli-style.c (class cli_style_option): Update accordingly.
9662         (style_set_list): Move to file scope.
9663         (style_show_list): Likewise.
9664         (set_style): Call help_list.
9665         (show_style): Call cmd_show_list.
9666         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9667         Update to use the new macro.
9668
9669 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9670
9671         * ada-lang.c (_initialize_ada_language): Expand the help text
9672         for the "catch exception" command.
9673
9674 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9675
9676         * symtab.c (matching_obj_sections): Initialize obj,
9677         declare it closer to its usage.
9678
9679 2019-01-10  Tom Tromey  <tom@tromey.com>
9680
9681         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9682         (basic_inf_threads_range): Remove.
9683         (inf_threads_range, inf_non_exited_threads_range)
9684         (safe_inf_threads_range): Use next_adapter.
9685
9686 2019-01-10  Keith Seitz  <keiths@redhat.com>
9687
9688         PR gdb/23712
9689         PR symtab/23010
9690         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9691         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9692
9693 2019-01-10  Keith Seitz  <keiths@redhat.com>
9694
9695         PR gdb/23712
9696         PR symtab/23010
9697         * dictionary.c (pending_to_vector): Remove.
9698         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9699         Remove _1 suffix, replacing functions of the same name.  Update
9700         all callers.
9701         (dict_create_hashed, dict_create_hashed_expandable)
9702         (dict_create_linear, dict_create_linear_expandable, dict_free)
9703         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9704         Make functions static.
9705
9706 2019-01-10  Keith Seitz  <keiths@redhat.com>
9707
9708         PR gdb/23712
9709         PR symtab/23010
9710         * dictionary.h (struct dictionary): Replace declaration with
9711         multidictionary.
9712         (dict_create_hashed, dict_create_hashed_expandable)
9713         (dict_create_linear, dict_create_linear_expandable)
9714         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9715         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9716         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9717         taking multidictionary argument.
9718         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9719         * block.h (struct block) <dict>: Change to multidictionary
9720         and rename `multidict'.
9721         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9722         symmisc.c: Update all dictionary references to multidictionary.
9723
9724 2019-01-10  Keith Seitz  <keiths@redhat.com>
9725
9726         PR gdb/23712
9727         PR symtab/23010
9728         * dictionary.c: Include unordered_map.
9729         (pending_to_vector): New function.
9730         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9731         Rewrite the non-"_1" functions to take vector instead
9732         of linked list.
9733         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9734         "new" _1 versions of the same name.
9735         (multidictionary): Define.
9736         (std::hash<enum language): New definition.
9737         (collate_pending_symbols_by_language, mdict_create_hashed)
9738         (mdict_create_hashed_expandable, mdict_create_linear)
9739         (mdict_create_linear_expandable, mdict_free)
9740         (find_language_dictionary, create_new_language_dictionary)
9741         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9742         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9743         (mdict_size, mdict_empty): New functions.
9744         * dictionary.h (mdict_iterator): Define.
9745
9746 2019-01-10  Pedro Alves  <palves@redhat.com>
9747
9748         * breakpoint.c (read_uploaded_action)
9749         (create_tracepoint_from_upload): Adjust to use
9750         gdb::unique_xmalloc_ptr.
9751         * ctf.c (ctf_write_uploaded_tp):
9752         (SET_ARRAY_FIELD): Use emplace_back.
9753         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9754         * tracefile-tfile.c (tfile_write_uploaded_tp):
9755         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9756         gdb::unique_xmalloc_ptr.
9757         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9758         at_string, cond_string, cmd_strings>: Replace char pointers
9759         with gdb::unique_xmalloc_ptr.
9760
9761 2019-01-10  Pedro Alves  <palves@redhat.com>
9762
9763         * solib-target.c (library_list_start_library): Don't xstrdup name.
9764
9765 2019-01-10  Pedro Alves  <palves@redhat.com>
9766
9767         * mdebugread.c (parse_partial_symbols): Use
9768         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9769
9770 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9771
9772         * linux-fork.c (scoped_switch_fork_info)
9773         <~scoped_switch_fork_info>: Fix incorrect variable name.
9774
9775 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9776
9777         * linux-fork.c (scoped_switch_fork_info)
9778         <scoped_switch_fork_info>: Make explicit.
9779         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9780
9781 2019-01-10  Tom Tromey  <tom@tromey.com>
9782
9783         * objfiles.h (objfile::reset_psymtabs): Update.
9784         * objfiles.c (objfile::objfile): Update.
9785         * psymtab.h (psymtab_storage::obstack): Update.
9786         (psymtab_storage::m_obstack): Use gdb::optional.
9787         (class psymtab_storage): Update comment.  Remove objfile
9788         parameter.
9789         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9790
9791 2019-01-10  Tom Tromey  <tom@tromey.com>
9792
9793         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9794         <free_psymtabs>: Now private.
9795         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9796         (allocate_psymtab): Use new method.
9797
9798 2019-01-10  Tom Tromey  <tom@tromey.com>
9799
9800         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9801         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9802         * mdebugread.c (parse_partial_symbols): Use
9803         allocate_dependencies.
9804         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9805         allocate_dependencies.
9806         (process_psymtab_comp_unit_reader)
9807         (build_type_psymtab_dependencies): Likewise.
9808         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9809
9810 2019-01-10  Tom Tromey  <tom@tromey.com>
9811
9812         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9813         PSYMBOL_SET_LANGUAGE.
9814         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9815
9816 2019-01-10  Tom Tromey  <tom@tromey.com>
9817
9818         * psymtab.h (psymtab_storage::obstack): New method.
9819         <m_obstack>: Rename from obstack; now private.
9820         * psymtab.c (psymtab_storage): Update.
9821         * dwarf2read.c (create_addrmap_from_index)
9822         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9823         Update.
9824
9825 2019-01-10  Tom Tromey  <tom@tromey.com>
9826
9827         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9828         * objfiles.h (objfile::reset_psymtabs): New method.
9829
9830 2019-01-10  Tom Tromey  <tom@tromey.com>
9831
9832         * symmisc.c (print_symbol_bcache_statistics): Update.
9833         (print_objfile_statistics): Update.
9834         * symfile.c (reread_symbols): Update.
9835         * psymtab.h (class psymtab_storage): New.
9836         * psymtab.c (psymtab_storage): New constructor.
9837         (~psymtab_storage): New destructor.
9838         (require_partial_symbols): Update.
9839         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9840         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9841         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9842         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9843         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9844         (start_psymtab_common, end_psymtab_common)
9845         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9846         (allocate_psymtab): Update.
9847         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9848         Update.
9849         (dump_psymtab_addrmap, maintenance_print_psymbols)
9850         (maintenance_check_psymtabs): Update.
9851         (class objfile_psymtabs): Move to objfiles.h.
9852         * psympriv.h (discard_psymtab): Now inline.
9853         (psymtab_discarder::psymtab_discarder): Update.
9854         (psymtab_discarder::~psymtab_discarder): Update.
9855         (ALL_OBJFILE_PSYMTABS): Rewrite.
9856         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9857         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9858         Remove fields.
9859         <partial_symtabs>: New field.
9860         (class objfile_psymtabs): Move from psymtab.h.  Update.
9861         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9862         psymbol_cache.
9863         (objfile::~objfile): Don't destroy psymbol_cache.
9864         * mdebugread.c (parse_partial_symbols): Update.
9865         * dwarf2read.c (create_addrmap_from_index)
9866         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9867         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9868         (add_partial_subprogram, dwarf2_ranges_read): Update.
9869         * dwarf-index-write.c (write_address_map)
9870         (write_one_signatured_type, recursively_write_psymbols)
9871         (class debug_names, class debug_names, write_psymtabs_to_index):
9872         Update.
9873
9874 2019-01-10  Tom Tromey  <tom@tromey.com>
9875
9876         * symtab.h (SYMBOL_SET_NAMES): Update.
9877         (symbol_set_names): Update.
9878         (MSYMBOL_SET_NAMES): Update.
9879         * symtab.c (symbol_set_names): Change argument to be an
9880         objfile_per_bfd_storage.
9881         * psymtab.c (add_psymbol_to_bcache): Update.
9882         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9883
9884 2019-01-10  Tom Tromey  <tom@tromey.com>
9885
9886         * symtab.c (create_demangled_names_hash): Change argument to be an
9887         objfile_per_bfd_storage.
9888         (symbol_set_names): Update.
9889
9890 2019-01-10  Tom Tromey  <tom@tromey.com>
9891
9892         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9893         init_psymbol_list.
9894         * psymtab.c (init_psymbol_list): Do nothing if already called.
9895         * psympriv.h (init_psymbol_list): Add comment.
9896         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9897         init_psymbol_list.
9898         * dbxread.c (dbx_symfile_read): Unconditionally call
9899         init_psymbol_list.
9900
9901 2019-01-10  Tom Tromey  <tom@tromey.com>
9902
9903         * xcoffread.c (scan_xcoff_symtab): Update.
9904         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9905         "where".
9906         * mdebugread.c (parse_partial_symbols)
9907         (handle_psymbol_enumerators): Update.
9908         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9909         * dbxread.c (read_dbx_symtab): Update.
9910         * psympriv.h (psymbol_placement): New enum.
9911         (add_psymbol_to_list): Update.
9912
9913 2019-01-10  Tom Tromey  <tom@tromey.com>
9914
9915         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9916         static_psymbols parameters.
9917         (scan_xcoff_symtab): Update.
9918         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9919         static_psymbols parameters.
9920         * psympriv.h (start_psymtab_common): Update.
9921         * mdebugread.c (parse_partial_symbols): Update.
9922         * dwarf2read.c (create_partial_symtab): Update.
9923         * dbxread.c (read_dbx_symtab): Update.
9924         (start_psymtab): Remove global_psymbols and static_psymbols
9925         parameters.
9926
9927 2019-01-10  Tom Tromey  <tom@tromey.com>
9928
9929         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9930         * psymtab.c (allocate_psymtab): Add comment.
9931         * psympriv.h (allocate_psymtab): Add comment.
9932         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9933         initializations.
9934         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9935
9936 2019-01-10  Tom Tromey  <tom@tromey.com>
9937
9938         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9939         Don't declare.
9940         * mipsread.c: Include mdebugread.h.
9941         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9942         Declare.
9943         * elfread.c: Include mdebugread.h.
9944
9945 2019-01-09  Tom Tromey  <tom@tromey.com>
9946
9947         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9948         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9949         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9950         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9951         (psym_lookup_symbol, psym_find_last_source_symtab)
9952         (psym_forget_cached_source_info, psym_print_stats)
9953         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9954         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9955         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9956         (psym_find_compunit_symtab_by_address)
9957         (maintenance_print_psymbols, maintenance_info_psymtabs)
9958         (maintenance_check_psymtabs): Use ranged for.
9959         * psymtab.h (class objfile_psymtabs): New.
9960         (require_partial_symbols): Return objfile_psymtabs.
9961         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9962
9963 2019-01-09  Tom Tromey  <tom@tromey.com>
9964
9965         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9966         (find_pc_mapped_section, list_overlays_command)
9967         (map_overlay_command, unmap_overlay_command)
9968         (simple_overlay_update): Use all_objfiles.
9969         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9970         * printcmd.c (info_symbol_command): Use all_objfiles.
9971         * objfiles.h (ALL_OBJSECTIONS): Remove.
9972         * maint.c (maintenance_translate_address): Use all_objfiles.
9973         * gcore.c (gcore_create_callback): Use all_objfiles.
9974         (objfile_find_memory_regions): Likewise.
9975
9976 2019-01-09  Tom Tromey  <tom@tromey.com>
9977
9978         * symtab.c (find_line_symtab, info_sources_command)
9979         (make_source_files_completion_list): Use objfile_compunits.
9980         * source.c (select_source_symtab): Use objfile_compunits.
9981         * objfiles.h (struct objfile): Update comment.
9982         (ALL_OBJFILES): Remove.
9983         (ALL_FILETABS): Remove.
9984         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9985         objfile_compunits.
9986
9987 2019-01-09  Tom Tromey  <tom@tromey.com>
9988
9989         * symmisc.c (print_objfile_statistics, dump_objfile)
9990         (maintenance_print_symbols): Use compunit_filetabs.
9991         * source.c (forget_cached_source_info_for_objfile): Use
9992         compunit_filetabs.
9993         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9994         (ALL_FILETABS): Use compunit_filetabs.
9995         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9996         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9997
9998 2019-01-09  Tom Tromey  <tom@tromey.com>
9999
10000         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10001         (compunit_filetabs): New.
10002         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10003         compunit_filetabs.
10004         (info_sources_command, make_source_files_completion_list): Remove
10005         declaration.
10006         * symmisc.c (print_objfile_statistics, dump_objfile)
10007         (maintenance_print_symbols): Remove declaration.
10008         (maintenance_info_symtabs): Use compunit_filetabs.
10009         (maintenance_info_line_tables): Likewise.
10010         * source.c (select_source_symtab): Change local variable name.
10011         (forget_cached_source_info_for_objfile): Remove declaration.
10012         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10013         * objfiles.c (objfile_relocate1): Remove declaration.
10014         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10015         declaration.
10016         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10017         * coffread.c (coff_symtab_read): Remove declaration.
10018         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10019         compunit_filetabs.
10020
10021 2019-01-09  Tom Tromey  <tom@tromey.com>
10022
10023         * symtab.c (lookup_objfile_from_block)
10024         (find_pc_sect_compunit_symtab, search_symbols)
10025         (default_collect_symbol_completion_matches_break_on): Use
10026         objfile_compunits.
10027         * objfiles.h (ALL_COMPUNITS): Remove.
10028         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10029         * cp-support.c (add_symbol_overload_list_qualified): Use
10030         objfile_compunits.
10031         * ada-lang.c (ada_collect_symbol_completion_matches)
10032         (ada_add_global_exceptions): Use objfile_compunits.
10033
10034 2019-01-09  Tom Tromey  <tom@tromey.com>
10035
10036         * source.c (select_source_symtab)
10037         (forget_cached_source_info_for_objfile): Remove declaration.
10038         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10039         declaration.
10040         * maint.c (count_symtabs_and_blocks): Remove declaration.
10041         * cp-support.c (add_symbol_overload_list_qualified): Remove
10042         declaration.
10043         * coffread.c (coff_symtab_read): Remove declaration.
10044         * symtab.c (lookup_symbol_in_objfile_symtabs)
10045         (basic_lookup_transparent_type_1): Use objfile_compunits.
10046         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10047         (info_sources_command, search_symbols)
10048         (default_collect_symbol_completion_matches_break_on)
10049         (make_source_files_completion_list): Remove declaration.
10050         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10051         (ada_collect_symbol_completion_matches)
10052         (ada_add_global_exceptions): Remove declaration.
10053         * linespec.c (iterate_over_all_matching_symtabs): Use
10054         objfile_compunits.
10055         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10056         (class objfile_compunits): New.
10057         (ALL_COMPUNITS): Use objfile_compunits.
10058         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10059         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10060         objfile_compunits.
10061         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10062
10063 2019-01-09  Tom Tromey  <tom@tromey.com>
10064
10065         * symtab.c (search_symbols)
10066         (default_collect_symbol_completion_matches_break_on): Use
10067         objfile_msymbols.
10068         * ada-lang.c (ada_lookup_simple_minsym)
10069         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10070         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10071         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10072         objfile_msymbols.
10073         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10074         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10075         * objc-lang.c (find_methods): Use objfile_msymbols.
10076         (info_selectors_command, info_classes_command): Likewise.
10077         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10078         * objfiles.h (class objfile_msymbols): New.
10079         (ALL_OBJFILE_MSYMBOLS): Remove.
10080         (ALL_MSYMBOLS): Remove.
10081
10082 2019-01-09  Tom Tromey  <tom@tromey.com>
10083
10084         * common/next-iterator.h (next_adapter): Add Iterator template
10085         parameter.
10086         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10087         (class all_objfiles_safe): New.
10088         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10089         * objfiles.c (put_objfile_before): Update comment.
10090         (add_separate_debug_objfile): Likewise.
10091         (free_all_objfiles): Use all_objfiles_safe.
10092         (objfile_purge_solibs): Likewise.
10093
10094 2019-01-09  Tom Tromey  <tom@tromey.com>
10095
10096         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10097         (expand_symtab_containing_pc, lookup_static_symbol)
10098         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10099         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10100         all_objfiles.
10101         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10102         * breakpoint.c (create_overlay_event_breakpoint)
10103         (create_longjmp_master_breakpoint)
10104         (create_std_terminate_master_breakpoint)
10105         (create_exception_master_breakpoint): Use all_objfiles.
10106         * linux-thread-db.c (try_thread_db_load_from_pdir)
10107         (has_libpthread): Use all_objfiles.
10108         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10109         * linespec.c (iterate_over_all_matching_symtabs)
10110         (search_minsyms_for_name): Use all_objfiles.
10111         * maint.c (maintenance_info_sections): Use all_objfiles.
10112         * main.c (captured_main_1): Use all_objfiles.
10113         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10114         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10115         * guile/scm-pretty-print.c
10116         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10117         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10118         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10119         (maintenance_print_msymbols): Use all_objfiles.
10120         * source.c (select_source_symtab): Use all_objfiles.
10121         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10122         * symfile.c (remove_symbol_file_command)
10123         (expand_symtabs_matching, map_symbol_filenames): Use
10124         all_objfiles.
10125         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10126         all_objfiles.
10127         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10128         * objc-lang.c (find_methods): Use all_objfiles.
10129         * objfiles.c (have_partial_symbols, have_full_symbols)
10130         (have_minimal_symbols, qsort_cmp)
10131         (default_iterate_over_objfiles_in_search_order): Use
10132         all_objfiles.
10133         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10134         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10135         (maintenance_check_psymtabs): Use all_objfiles.
10136         (ALL_PSYMTABS): Remove.
10137         * compile/compile-object-run.c (do_module_cleanup): Use
10138         all_objfiles.
10139         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10140         * cp-support.c (add_symbol_overload_list_qualified): Use
10141         all_objfiles.
10142         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10143         Use all_objfiles.
10144         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10145         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10146         all_objfiles.
10147         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10148         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10149         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10150         Uses all_objfiles.
10151         * solib.c (solib_read_symbols): Use all_objfiles
10152
10153 2019-01-09  Tom Tromey  <tom@tromey.com>
10154
10155         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10156         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10157         all_objfiles.
10158         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10159         * symmisc.c (print_symbol_bcache_statistics)
10160         (print_objfile_statistics, maintenance_print_objfiles)
10161         (maintenance_info_symtabs, maintenance_check_symtabs)
10162         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10163         all_objfiles.
10164         * source.c (forget_cached_source_info): Use all_objfiles.
10165         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10166         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10167         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10168         * objfiles.c (update_section_map): Use all_objfiles.
10169         (shared_objfile_contains_address_p): Likewise.
10170         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10171         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10172
10173 2019-01-09  Tom Tromey  <tom@tromey.com>
10174
10175         * common/next-iterator.h: New file.
10176         * objfiles.h (class all_objfiles): New.
10177         (struct objfile_iterator): New.
10178
10179 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10180
10181         * NEWS: Move the description of the changed "frame", "select-frame",
10182          and "info frame" commands to the Changed commands section.
10183
10184 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10185
10186         * gdbtypes.c (check_stub_method_group): Remove handling of old
10187         mangling schemes.
10188         * linespec.c (find_methods): Likewise.
10189         * stabsread.c (read_member_functions): Likewise.
10190         * valops.c (search_struct_method): Likewise.
10191         (value_struct_elt_for_reference): Likewise.
10192         * NEWS: Mention this change.
10193
10194 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10195
10196         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10197         print_source_lines.
10198         * source.c (print_source_lines_base): Update line number check.
10199         (print_source_lines): New function.
10200         (source_lines_range::source_lines_range): New function.
10201         * source.h (class source_lines_range): New class.
10202         (print_source_lines): New declaration.
10203
10204 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10205
10206         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10207
10208 2019-01-08  Tom Tromey  <tom@tromey.com>
10209             Simon Marchi  <simon.marchi@ericsson.com>
10210
10211         PR gdb/24060
10212         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10213         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10214         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10215         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10216         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10217         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10218
10219 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10220
10221         * source.c (select_source_symtab): Move header comment to
10222         declaration in source.h.
10223         (forget_cached_source_info_for_objfile): Likewise.
10224         (forget_cached_source_info): Likewise.
10225         (identify_source_line): Likewise.
10226         * source.h (identify_source_line): Move declaration from symtab.h
10227         and add comment from source.c
10228         (print_source_lines): Likewise.
10229         (forget_cached_source_info_for_objfile): Likewise.
10230         (forget_cached_source_info): Likewise.
10231         (select_source_symtab): Likewise.
10232         (enum print_source_lines_flag): Move definition from symtab.h.
10233         * symtab.h (identify_source_line): Move declaration to source.h.
10234         (print_source_lines): Likewise.
10235         (forget_cached_source_info_for_objfile): Likewise.
10236         (forget_cached_source_info): Likewise.
10237         (select_source_symtab): Likewise.
10238         (enum print_source_lines_flag): Move definition to source.h.
10239         * tui/tui-hooks.c: Add 'source.h' include.
10240
10241 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10242
10243         * source.c (print_source_lines_base): Handle requests to print
10244         reverse line number sequences, and guard against empty lines
10245         string.
10246
10247 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10248
10249         * source.c (print_source_lines_base): Fix skip of '\r' if next
10250         character is '\n'.
10251
10252 2019-01-06  Tom Tromey  <tom@tromey.com>
10253
10254         * c-exp.y (struct c_parse_state) <macro_original_text,
10255         expansion_obstack>: New member.
10256         (macro_original_text, expansion_obstack): Remove globals.
10257         (scan_macro_expansion, scanning_macro_expansion)
10258         (finished_macro_expansion): Update.
10259         (scan_macro_cleanup): Remove.
10260         (yylex, c_parse): Update.
10261
10262 2019-01-06  Tom Tromey  <tom@tromey.com>
10263
10264         * c-exp.y (struct c_parse_state) <strings>: New member.
10265         (operator_stoken): Update.
10266
10267 2019-01-06  Tom Tromey  <tom@tromey.com>
10268
10269         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10270         (union type_stack_elt) <typelist_val>: Now a pointer to
10271         std::vector.
10272         (type_stack_cleanup): Don't declare.
10273         (push_typelist): Update.
10274         * parse.c (pop_typelist): Return a std::vector.
10275         (push_typelist): Take a std::vector.
10276         (follow_types): Update.  Do not free args.
10277         (type_stack_cleanup): Remove.
10278         * c-exp.y (struct c_parse_state): New.
10279         (cpstate): New global.
10280         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10281         (nonempty_typelist): Update.
10282         (func_mod): Create a new vector.
10283         (c_parse): Create a c_parse_state.
10284         (check_parameter_typelist): Do not delete params.
10285         (function_method): Update.  Do not delete type_list.
10286
10287 2019-01-06  Tom Tromey  <tom@tromey.com>
10288
10289         PR gdb/28155:
10290         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10291         check_typedef.
10292         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10293         (print_return_value): Likewise.
10294
10295 2019-01-05  Tom Tromey  <tom@tromey.com>
10296
10297         * contrib/cleanup_check.py: Remove.
10298         * contrib/gcc-with-excheck: Remove.
10299         * contrib/exsummary.py: Remove.
10300         * contrib/excheck.py: Remove.
10301
10302 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10303
10304         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10305         NULL. Initialize tpprev to NULL instead of assigning it
10306         to NULL on the next statement.
10307         * windows-nat.c (windows_delete_thread): Remove check for
10308         main_thread_id before printing thread exit notifications.
10309         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10310         Remove thread ID check against main_thread_id.
10311         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10312         windows_delete_thread.
10313         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10314
10315 2019-01-04  Tom Tromey  <tom@tromey.com>
10316
10317         * compile/compile.c (_initialize_compile): Use upper case for
10318         metasyntactic variables.
10319         * symmisc.c (_initialize_symmisc): Use upper case for
10320         metasyntactic variables.
10321         * psymtab.c (_initialize_psymtab): Use upper case for
10322         metasyntactic variables.
10323         * demangle.c (demangle_command): Use upper case for metasyntactic
10324         variables.
10325         (_initialize_demangler): Likewise.
10326         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10327         variables.
10328
10329 2019-01-03  Tom Tromey  <tom@tromey.com>
10330
10331         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10332
10333 2019-01-03  Tom Tromey  <tom@tromey.com>
10334
10335         * python/py-symtab.c (salpy_str): Update.
10336         (struct salpy_sal_object) <symtab>: Now a PyObject.
10337         (salpy_dealloc): Update.
10338         (del_objfile_sal): Use gdbpy_ref.
10339
10340 2019-01-03  Tom Tromey  <tom@tromey.com>
10341
10342         * python/py-type.c (convert_field): Use new_reference.  Return
10343         gdbpy_ref.
10344         (make_fielditem): Return gdbpy_ref.
10345         (typy_fields): Update.
10346         (typy_getitem): Update.
10347         (field_name): Return gdbpy_ref.  Use new_reference.
10348         (typy_iterator_iternext): Update.
10349
10350 2019-01-03  Tom Tromey  <tom@tromey.com>
10351
10352         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10353
10354 2019-01-03  Tom Tromey  <tom@tromey.com>
10355
10356         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10357         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10358         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10359         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10360         (pspy_set_type_printers): Likewise.
10361         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10362         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10363         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10364         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10365         (objfpy_set_type_printers): Likewise.
10366
10367 2019-01-03  Tom Tromey  <tom@tromey.com>
10368
10369         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10370         (gdbpy_print_stack): Use gdbpy_err_fetch.
10371         * python/python-internal.h (class gdbpy_err_fetch): New class.
10372         (class gdbpy_enter) <m_error_type, m_error_value,
10373         m_error_traceback>: Remove.
10374         <m_error>: New member.
10375         (gdbpy_exception_to_string): Don't declare.
10376         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10377         * python/py-value.c (convert_value_from_python): Use
10378         gdbpy_err_fetch.
10379         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10380         gdbpy_exception_to_string.
10381         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10382         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10383         gdbpy_err_fetch.
10384
10385 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10386
10387         * linux-nat.c (delete_lwp_cleanup): Delete.
10388         (struct lwp_deleter): New struct.
10389         (lwp_info_up): New typedef.
10390         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10391         lwp_info_up.
10392
10393 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10394
10395         * linux-fork.c (class scoped_switch_fork_info): New class.
10396         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10397
10398 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10399
10400         * valops.c (find_overload_match): Remove use of null_cleanup, and
10401         calls to do_cleanups.
10402
10403 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10404
10405         * compile/compile-cplus-types.c
10406         (compile_cplus_instance::decl_name): Handle changes to
10407         cp_func_name.
10408         * cp-support.c (cp_func_name): Update header comment, update
10409         return type.
10410         * cp-support.h (cp_func_name): Update return type in declaration.
10411         * valops.c (find_overload_match): Move temp_func local to top
10412         level of function and change its type.  Use temp_func to hold and
10413         delete temporary string obtained from cp_func_name.
10414
10415 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10416
10417         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10418         gdb::char_vector, remove cleanup, and update uses of `msg`.
10419
10420 2019-01-03  Jim Wilson  <jimw@sifive.com>
10421
10422         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10423
10424 2019-01-02  Tom Tromey  <tom@tromey.com>
10425
10426         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10427         (tdesc_parse_xml): Remove cleanups.
10428         * target-descriptions.h (make_cleanup_free_target_description):
10429         Don't declare.
10430         (target_desc_deleter): New struct.
10431         (target_desc_up): New typedef.
10432         * target-descriptions.c (target_desc_deleter::operator()): Rename
10433         from free_target_description.
10434         (make_cleanup_free_target_description): Remove.
10435
10436 2019-01-02  Tom Tromey  <tom@tromey.com>
10437
10438         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10439         constructor, destructor.
10440         (linespec_parser): Remove typedef.
10441         (~linespec_parser): Rename from linespec_parser_delete.
10442         (linespec_lex_to_end, linespec_complete_label)
10443         (linespec_complete): Update.
10444         (decode_line_full): Remove cleanups.
10445         (decode_line_1): Update.
10446
10447 2019-01-02  Tom Tromey  <tom@tromey.com>
10448
10449         * python/python-internal.h (inferior_to_inferior_object): Change
10450         return type.
10451         * python/py-exitedevent.c (create_exited_event_object): Update.
10452         * python/py-inferior.c (inferior_to_inferior_object): Return
10453         gdbpy_ref.
10454         (python_new_inferior, python_inferior_deleted)
10455         (thread_to_thread_object, delete_thread_object)
10456         (build_inferior_list, gdbpy_selected_inferior): Update.
10457         * python/py-infthread.c (create_thread_object): Update.  Also fail
10458         if inferior_to_inferior_object fails.
10459
10460 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10461
10462         * inferior.h (class inferior) <displaced_step_state>: New field.
10463         * infrun.h (struct displaced_step_state): Move here from
10464         infrun.c.  Initialize fields, add constructor.
10465         <inf>: Remove field.
10466         <reset>: New method.
10467         * infrun.c (struct displaced_step_inferior_state): Move to
10468         infrun.h.
10469         (displaced_step_inferior_states): Remove.
10470         (get_displaced_stepping_state): Adust.
10471         (displaced_step_in_progress_any_inferior): Adjust.
10472         (displaced_step_in_progress_thread): Adjust.
10473         (displaced_step_in_progress): Adjust.
10474         (add_displaced_stepping_state): Remove.
10475         (get_displaced_step_closure_by_addr): Adjust.
10476         (remove_displaced_stepping_state): Remove.
10477         (infrun_inferior_exit): Call displaced_step_state.reset.
10478         (use_displaced_stepping): Don't check for NULL.
10479         (displaced_step_prepare_throw): Call
10480         get_displaced_stepping_state.
10481         (displaced_step_fixup): Don't check for NULL.
10482         (prepare_for_detach): Don't check for NULL.
10483
10484 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10485
10486         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10487          in case of call that did not complete.
10488
10489 2019-01-02  Andrey Utkin  <autkin@undo.io>
10490
10491         * symfile.c (find_separate_debug_file): Fix search of debug files for
10492         remote debuggee.
10493
10494 2019-01-02  Tom Tromey  <tom@tromey.com>
10495
10496         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10497         indentation.
10498         * python/py-frame.c (frapy_older): Remove cast.
10499         (frapy_newer): Likewise.
10500         * python/py-breakpoint.c (local_setattro): Remove cast.
10501         * python/py-arch.c (archpy_name): Remove local variable.
10502         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10503
10504 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10505
10506         * unittests/basic_string_view/element_access/char/empty.cc:
10507         Fix year range in copyright header.
10508
10509 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10510
10511         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10512         Delete.
10513         <operator==>: Update with for removed field.
10514         <hash>: Likewise.
10515         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10516         <isa_features>: ...this.
10517         <abi_features>: New field.
10518         (riscv_isa_flen): Update comment.
10519         (riscv_abi_xlen): New declaration.
10520         (riscv_abi_flen): New declaration.
10521         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10522         isa_features.
10523         (riscv_abi_xlen): New function.
10524         (riscv_isa_flen): Update to get answer from isa_features.
10525         (riscv_abi_flen): New function.
10526         (riscv_has_fp_abi): Update to get answer from abi_features.
10527         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10528         xlen and flen.
10529         (riscv_call_info) <xlen, flen>: Update comment.
10530         (riscv_call_arg_struct): Remove invalid assertions
10531         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10532         is removed.
10533         (riscv_gdbarch_init): Gather isa features and abi features
10534         separately, ensure both match on the gdbarch when reusing an old
10535         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10536         a target with 64-bit float hardware.
10537
10538 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10539
10540         * source.c (search_command_helper): Stop reverse search
10541         when line 1 has been searched.
10542
10543 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10544
10545         * record-full.c (record_full_base_target::close): Rewrite
10546         record_full_core_buf_list free logic.
10547
10548 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10549
10550         * break-catch-syscall.c (print_one_catch_syscall): xfree
10551         the last text.
10552
10553 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10554
10555         * top.c (print_gdb_version): Update Copyright year in version
10556         message.
10557
10558 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10559
10560         Update copyright year range in all GDB files.
10561
10562 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10563
10564         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10565
10566 For older changes see ChangeLog-2018.
10567 \f
10568 Local Variables:
10569 mode: change-log
10570 left-margin: 8
10571 fill-column: 74
10572 version-control: never
10573 coding: utf-8
10574 End:
10575