gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
   4         declare.
   5         * tui/tui-windata.c
   6         (tui_data_window::delete_data_content_windows): Rename from
   7         tui_delete_data_content_windows.
   8         (tui_data_window::display_all_data)
   9         (tui_data_window::do_scroll_vertical): Update.
  10         * tui/tui-data.h (struct tui_data_window)
  11         <delete_data_content_windows>: New method.
  12
  13 2019-07-17  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
  16         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
  17
  18 2019-07-17  Tom Tromey  <tom@tromey.com>
  19
  20         * tui/tui-windata.h (tui_display_all_data): Don't declare.
  21         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
  22         from tui_display_all_data.
  23         * tui/tui-win.c
  24         (tui_data_window::do_make_visible_with_new_height): Update.
  25         * tui/tui-regs.c (tui_show_registers): Update.
  26         * tui/tui-layout.c (tui_set_layout): Update.
  27         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
  28         method.
  29
  30 2019-07-17  Tom Tromey  <tom@tromey.com>
  31
  32         * tui/tui-windata.h (tui_display_data_from): Don't declare.
  33         * tui/tui-windata.c (tui_display_data_from): Remove.
  34         (tui_data_window::refresh_all): Update.
  35
  36 2019-07-17  Tom Tromey  <tom@tromey.com>
  37
  38         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
  39         * tui/tui-windata.c (tui_display_data_from_line): Remove.
  40         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
  41         tui_display_registers_from_line.
  42         * tui/tui-regs.h (tui_display_registers_from_line): Update.
  43         * tui/tui-regs.c (tui_display_registers_from_line): Remove
  44         "force_display" parameter.
  45
  46 2019-07-17  Tom Tromey  <tom@tromey.com>
  47
  48         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
  49         declare.
  50         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
  51         Rename from tui_first_reg_element_no_inline.
  52         (tui_display_reg_element_at_line)
  53         (tui_display_registers_from_line): Update.
  54         * tui/tui-data.h (struct tui_data_window)
  55         <first_reg_element_no_inline>: New method.
  56
  57 2019-07-17  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-windata.c (tui_display_data_from)
  60         (tui_data_window::do_scroll_vertical): Update.
  61         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
  62         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
  63         Rename from tui_line_from_reg_element_no.
  64         (tui_display_registers_from_line): Update.
  65         * tui/tui-data.h (struct tui_data_window)
  66         <line_from_reg_element_no>: New method.
  67
  68 2019-07-17  Tom Tromey  <tom@tromey.com>
  69
  70         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
  71         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
  72         tui_last_regs_line_no.
  73         (tui_display_reg_element_at_line)
  74         (tui_display_registers_from_line): Update.
  75         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
  76         method.
  77
  78 2019-07-17  Tom Tromey  <tom@tromey.com>
  79
  80         PR tui/24722:
  81         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
  82         (tui_update_breakpoint_info): Add "being_deleted" parameter.
  83         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
  84         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
  85         (tui_update_breakpoint_info): Likewise.
  86         * tui/tui-hooks.c (tui_event_create_breakpoint)
  87         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
  88         Update.
  89
  90 2019-07-17  Tom Tromey  <tom@tromey.com>
  91
  92         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
  93
  94 2019-07-17  Tom Tromey  <tom@tromey.com>
  95
  96         * tui/tui-winsource.c (tui_update_source_window_as_is)
  97         (tui_update_source_windows_with_addr): Update.
  98         * tui/tui-source.h (tui_set_source_content)
  99         (tui_show_symtab_source): Add "win_info" parameter.
 100         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 101         parameter.
 102         (tui_show_symtab_source): Likewise.
 103
 104 2019-07-17  Tom Tromey  <tom@tromey.com>
 105
 106         * tui/tui-wingeneral.c
 107         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 108
 109 2019-07-17  Tom Tromey  <tom@tromey.com>
 110
 111         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 112         (struct tui_cmd_window) <can_scroll>: New method.
 113         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 114         method.
 115
 116 2019-07-17  Tom Tromey  <tromey@adacore.com>
 117
 118         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 119         do_field_signed>: Rename.  Change type of "value".
 120         * ui-out.c (ui_out::field_signed): Rename from field_int.
 121         Change type of "value".
 122         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 123         type of "value".
 124         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 125         do_field_int.  Change type of "value".
 126         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 127         do_field_int.  Change type of "value".
 128         * tracepoint.c (trace_status_mi, tfind_1)
 129         (print_one_static_tracepoint_marker): Update.
 130         * thread.c (print_thread_info_1, print_selected_thread_frame):
 131         Update.
 132         * stack.c (print_frame, print_frame_info): Update.
 133         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 134         Update.
 135         * source.c (print_source_lines_base): Update.
 136         * skip.c (info_skip_command): Update.
 137         * record-btrace.c (btrace_ui_out_decode_error)
 138         (btrace_call_history_src_line): Update.
 139         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 140         Update.
 141         * progspace.c (print_program_space): Update.
 142         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 143         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 144         do_field_int.  Change type of "value".
 145         * mi/mi-out.c (mi_ui_out::do_table_begin)
 146         (mi_ui_out::do_table_header): Update.
 147         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 148         type of "value".
 149         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 150         (mi_cmd_data_list_changed_registers, output_register)
 151         (mi_cmd_data_read_memory, mi_load_progress)
 152         (mi_cmd_trace_frame_collected): Update.
 153         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 154         Update.
 155         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 156         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 157         (mi_cmd_var_list_children, varobj_update_one): Update.
 158         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 159         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 160         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 161         * inferior.c (print_inferior): Update.
 162         * gdb_bfd.c (print_one_bfd): Update.
 163         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 164         Update.
 165         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 166         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 167         do_field_int.  Change type of "value".
 168         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 169         do_field_int.  Change type of "value".
 170         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 171         (print_one_breakpoint_location, print_it_catch_fork)
 172         (print_one_catch_fork, print_it_catch_vfork)
 173         (print_one_catch_vfork, print_it_catch_solib)
 174         (print_it_catch_exec, print_it_ranged_breakpoint)
 175         (print_mention_watchpoint, print_mention_masked_watchpoint)
 176         (bkpt_print_it, update_static_tracepoint): Update.
 177         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 178         * break-catch-syscall.c (print_it_catch_syscall): Update.
 179         * ada-tasks.c (print_ada_task_info): Update.
 180         * ada-lang.c (print_it_exception, print_mention_exception):
 181         Update.
 182
 183 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 184
 185         PR breakpoints/24541
 186         * gdbarch.c: Regenerate.
 187         * gdbarch.h: Regenerate.
 188         * gdbarch.sh: Adjust return type and parameter types for
 189         'stap_adjust_register'.
 190         (i386_stap_adjust_register): Adjust signature and return new
 191         register name.
 192         * stap-probe.c (stap_parse_register_operand): Adjust use of
 193         'gdbarch_stap_adjust_register'.
 194
 195 2019-07-17  Tom Tromey  <tromey@adacore.com>
 196
 197         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 198         declare VEC.
 199         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 200         std::vector.
 201         (struct s390_process_info): Add initializers.
 202         (s390_add_process): Use new.
 203         (s390_linux_nat_target::low_forget_process): Use delete.
 204         (s390_linux_nat_target::low_new_fork)
 205         (s390_linux_nat_target::stopped_by_watchpoint)
 206         (s390_linux_nat_target::low_prepare_to_resume)
 207         (s390_linux_nat_target::insert_watchpoint)
 208         (s390_linux_nat_target::insert_hw_breakpoint)
 209         (s390_linux_nat_target::remove_watchpoint)
 210         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 211
 212 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 213
 214         * aarch64-fbsd-nat.c: Include regcache.h.
 215         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 216         argument.
 217         (aarch64_fbsd_nat_target::fetch_registers)
 218         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 219         variable.
 220         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 221
 222 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 223
 224         * fbsd-nat.c: Include gdbarch.h.
 225
 226 2019-07-15  Tom Tromey  <tromey@adacore.com>
 227
 228         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 229
 230 2019-07-15  Tom Tromey  <tromey@adacore.com>
 231
 232         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 233         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 234         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 235         * cli-out.c (cli_ui_out::do_field_int): New method.
 236         * ui-out.c (ui_out::field_unsigned): New method.
 237         * symfile.c (generic_load): Use field_unsigned.
 238         (print_transfer_performance): Likewise.
 239         * record-btrace.c (ui_out_field_uint): Remove.
 240         (btrace_call_history_insn_range, btrace_call_history): Use
 241         field_unsigned.
 242         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 243         field_unsigned.
 244         * ui-out.h (class ui_out) <field_unsigned>: New method.
 245         <do_field_unsigned>: Likewise.
 246
 247 2019-07-15  Tom Tromey  <tromey@adacore.com>
 248
 249         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 250         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 251         * target.c (flash_erase_command): Use field_string.
 252         * infrun.c (print_signal_received_reason): Use field_string.
 253         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 254         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 255         field_string.
 256         * ada-tasks.c (print_ada_task_info): Use field_string.
 257
 258 2019-07-15  Tom Tromey  <tromey@adacore.com>
 259
 260         * target.c (flash_erase_command): Use field_core_addr.
 261         * symfile.c (generic_load): Use field_core_addr.
 262         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 263         Use field_core_addr.
 264         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 265         field_core_addr.
 266
 267 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 268
 269         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 270         value if its desired type is smaller than a CORE_ADDR and signed.
 271
 272 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 273
 274         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 275         of changes to field names, and use new is_reference field to
 276         decide if a property is a reference or not.
 277         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 278         field.
 279         (struct dwarf2_property_baton): Update header comment, rename
 280         'referenced_type' to 'property_type' and update comments.
 281         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 282         default property type, store in property baton, update to take
 283         accound of renamed field.
 284         (read_func_scope): Update call to attr_to_dynamic_prop.
 285         (read_array_type): Likewise.
 286         (dwarf2_per_cu_addr_sized_int_type): New function.
 287         (read_subrange_index_type): Move type finding code to
 288         dwarf2_per_cu_addr_sized_int_type.
 289         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 290         (dwarf2_per_cu_addr_type): New function.
 291         (set_die_type): Update calls to attr_to_dynamic_prop.
 292
 293 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 294
 295         * dwarf2read.c (read_subrange_index_type): New function.
 296         (read_subrange_type): Move code into new function and call it.
 297         * gdbtypes.c (create_range_type): Add some asserts.
 298
 299 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 300
 301         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 302         update return statements.
 303         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 304         declaration, and update comment to match.
 305         * gdbtypes.c (resolve_dynamic_array): Update call to
 306         dwarf2_evaluate_property to match new return type.
 307
 308 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 309
 310         * valarith.c (value_subscripted_rvalue): Change lowerbound
 311         parameter type from int to LONGEST.
 312         * value.h (value_subscripted_rvalue): Likewise in declaration.
 313
 314 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 315
 316         * cli/cli-utils.c (info_print_command_completer): New function.
 317         * cli/cli-utils.h: Add 'completer.h' include, and forward
 318         declaration for 'struct cmd_list_element'.
 319         (info_print_command_completer): Declare.
 320         * stack.c (_initialize_stack): Add completer for 'info locals' and
 321         'info args'.
 322         * symtab.c (_initialize_symtab): Add completer for 'info
 323         variables' and 'info functions'.
 324         * NEWS: Mention completion for additional info commands.
 325
 326 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 327
 328         * cli/cli-utils.c (extract_info_print_args): Delete.
 329         (extract_arg_maybe_quoted): Delete.
 330         (info_print_options_defs): New variable.
 331         (make_info_print_options_def_group): New function.
 332         (extract_info_print_options): Define new function.
 333         * cli/cli-utils.h (extract_info_print_args): Delete.
 334         (struct info_print_options): New structure.
 335         (extract_info_print_options): Declare new function.
 336         * stack.c (info_locals_command): Update to use new
 337         extract_info_print_options, also add a header comment.
 338         (info_args_command): Likewise.
 339         * symtab.c (info_variables_command): Likewise.
 340         (info_functions_command): Likewise.
 341
 342 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 343
 344         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 345         to extract string arguments.
 346         * common/common-utils.c (extract_string_maybe_quoted): New function.
 347         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 348
 349 2019-07-11  Tom Tromey  <tromey@adacore.com>
 350
 351         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 352         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 353         * top.h (gdbinit): Don't declare.
 354         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 355         into...
 356         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 357         * top.c (gdb_init): Don't call init_cli_cmds.
 358         (gdbinit): Remove.
 359         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 360
 361 2019-07-11  Tom Tromey  <tromey@adacore.com>
 362
 363         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 364         after it has been moved.
 365
 366 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 367
 368         * valops.c (value_must_coerce_to_target): Change return type to
 369         bool.
 370         * value.h (value_must_coerce_to_target): Likewise.
 371
 372 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 373
 374         * breakpoint.c (is_hardware_watchpoint): Remove
 375         forward-declaration.
 376         (is_masked_watchpoint): Change return type to bool.
 377         (is_tracepoint): Likewise.
 378         (is_breakpoint): Likewise.
 379         (is_hardware_watchpoint): Likewise.
 380         (is_watchpoint): Likewise.
 381         (is_no_memory_software_watchpoint): Likewise.
 382         (is_catchpoint): Likewise.
 383         (breakpoint_1): Make FILTER parameter's return type bool.
 384         is_masked_watchpoint): Change return type to bool.
 385         (save_breakpoints): Make FILTER parameter's return type bool.
 386         * breakpoint.h (is_breakpoint): Change return type to bool.
 387         (is_watchpoint): Likewise.
 388         (is_catchpoint): Likewise.
 389         (is_tracepoint): Likewise.
 390
 391 2019-07-10  Tom Tromey  <tom@tromey.com>
 392
 393         * defs.h: Don't include gdbarch.h.
 394         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 395         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 396         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 397         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 398         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 399         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 400         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 401         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 402         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 403         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 404         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 405         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 406         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 407         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 408         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 409         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 410         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 411         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 412         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 413         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 414         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 415         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 416         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 417         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 418         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 419         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 420         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 421
 422 2019-07-10  Tom Tromey  <tromey@adacore.com>
 423
 424         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 425         * breakpoint.c (init_ada_exception_breakpoint): Register as
 426         bp_catchpoint.
 427         (print_one_breakpoint_location, print_one_breakpoint): Use
 428         is_ada_exception_catchpoint.
 429         * ada-lang.c (class ada_catchpoint_location): Pass
 430         bp_loc_software_breakpoint to bp_location constructor.
 431         (is_ada_exception_catchpoint): New function.
 432
 433 2019-07-10  Tom Tromey  <tromey@adacore.com>
 434
 435         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 436         VEC.
 437         (struct arm_exidx_entry): New method operator<.
 438         (struct arm_exidx_data) <section_maps>: Change type.
 439         (arm_exidx_data_free): Remove.
 440         (arm_exidx_data_key): Change type.  Move lower.
 441         (arm_exidx_new_objfile): Update.
 442         (arm_compare_exidx_entries): Remove.
 443         (arm_find_exidx_entry, _initialize_arm_tdep)
 444
 445 2019-07-10  Tom Tromey  <tromey@adacore.com>
 446
 447         * solib-spu.c (ocl_program_data_key): Change type.
 448         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 449         Update.
 450
 451 2019-07-10  Tom Tromey  <tromey@adacore.com>
 452
 453         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 454         (struct solib_aix_inferior_data) <library_list>: Change type.
 455         (solib_aix_inferior_data_handle): Change type.
 456         (get_solib_aix_inferior_data): Update.
 457         (solib_aix_free_library_list): Remove.
 458         (library_list_start_library): Update.
 459         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 460         return type.
 461         (solib_aix_get_library_list)
 462         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 463         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 464
 465 2019-07-10  Tom Tromey  <tromey@adacore.com>
 466
 467         * solib-dsbt.c (struct dsbt_info): Add initializers.
 468         (solib_dsbt_pspace_data): Change type.
 469         (dsbt_pspace_data_cleanup): Remove.
 470         (get_dsbt_info, _initialize_dsbt_solib): Update.
 471
 472 2019-07-10  Tom Tromey  <tromey@adacore.com>
 473
 474         * spu-tdep.c (spu_overlay_data): Change type.
 475         (spu_get_overlay_table, spu_overlay_new_objfile)
 476         (_initialize_spu_tdep): Update.
 477
 478 2019-07-10  Tom Tromey  <tromey@adacore.com>
 479
 480         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 481         destructor.
 482         (dbx_objfile_data_key): Change type and declare later.
 483         (DBX_SYMFILE_INFO): Rewrite.
 484         * dbxread.c (dbx_objfile_data_key): Change type.
 485         (dbx_symfile_init): Update.
 486         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 487         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 488         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 489
 490 2019-07-10  Tom Tromey  <tromey@adacore.com>
 491
 492         * jit.c (jit_program_space_key): Change type.  Move lower.
 493         (get_jit_program_space_data): Update.
 494         (jit_program_space_data_cleanup): Remove.
 495         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 496         Update.
 497         (struct jit_program_space_data): Add initializers.
 498
 499 2019-07-10  Tom Tromey  <tromey@adacore.com>
 500
 501         * solib-darwin.c (struct darwin_info): Add initializers.
 502         (solib_darwin_pspace_data): Change type.
 503         (darwin_pspace_data_cleanup): Remove.
 504         (get_darwin_info, _initialize_darwin_solib): Update.
 505
 506 2019-07-10  Tom Tromey  <tromey@adacore.com>
 507
 508         * remote-sim.c (struct sim_inferior_data): Add initializers,
 509         constructor, and destructor.
 510         (sim_inferior_data_key): Change type.  Move lower.
 511         (check_for_duplicate_sim_descriptor): Update.
 512         (get_sim_inferior_data): Use new.  Update.
 513         (~sim_inferior_data_cleanup): Rename from
 514         sim_inferior_data_cleanup.  Simplify.
 515         (gdbsim_close_inferior, simulator_command)
 516         (sim_command_completer, _initialize_remote_sim): Update.
 517         (next_pid, INITIAL_PID): Move earlier.
 518
 519 2019-07-10  Tom Tromey  <tromey@adacore.com>
 520
 521         * python/python-internal.h (create_thread_object): Return
 522         gdbpy_ref.
 523         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 524         * python/py-inferior.c (struct threadlist_entry): Add
 525         constructor.
 526         <thread_obj>: Now a gdbpy_ref.
 527         (thread_to_thread_object): Update.
 528         (add_thread_object): Use new.
 529         (delete_thread_object): Use delete.
 530         (infpy_threads): Update.
 531         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 532         GIL.
 533
 534 2019-07-10  Tom Tromey  <tromey@adacore.com>
 535
 536         * valops.c (value_cast): Specialize error message for Ada.
 537
 538 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 539
 540         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 541
 542 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 543
 544         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 545         bpstat_should_step): Return bool, adjust comments.
 546         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 547         bpstat_should_step): Likewise.
 548
 549 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 550
 551         * features/Makefile: Use feature target descriptions for Arm.
 552         * features/arm/arm-core.c: Generate new file.
 553         * features/arm/arm-fpa.c: Likewise.
 554         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 555         * features/arm/arm-m-profile.c: Likewise.
 556         * features/arm/arm-vfpv2.c: Likewise.
 557         * features/arm/arm-vfpv3.c: Likewise.
 558         * features/arm/xscale-iwmmxt.c: Likewise.
 559         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 560
 561 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 562
 563         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 564         ptrace earlier.
 565
 566 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 567
 568         * features/aarch64-pauth.c: Regenerate.
 569
 570 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 571
 572         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 573         bool.
 574         (bpstat_what): Use false instead of 0.
 575
 576 2019-07-09  Pedro Alves  <palves@redhat.com>
 577
 578         * break-catch-throw.c (is_exception_catchpoint): New.
 579         * breakpoint.c (print_one_breakpoint_location): New parameter
 580         'raw_loc'.  Handle it.  Use
 581         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 582         looking at the breakpoint's type.
 583         (print_one_breakpoint): If handling "maint info breakpoints", also
 584         print locations of exception catchpoints.
 585         * breakpoint.h (is_exception_catchpoint): Declare.
 586
 587 2019-07-09  Pedro Alves  <palves@redhat.com>
 588
 589         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 590         "addr" field.
 591         (allocate_location_exception_catchpoint): New.
 592         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 593         (initialize_throw_catchpoint_ops): Install
 594         allocate_location_exception_catchpoint as allocate_location
 595         method.
 596         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 597         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 598         bp_loc_other.
 599         (breakpoint_address_is_meaningful): Delete.
 600         (bl_address_is_meaningful): New.
 601         (breakpoint_locations_match): Adjust comment.
 602         (bp_location_from_bp_type): New, factored out of...
 603         (bp_location::bp_location(breakpoint *)): ... this.
 604         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 605         factored out of...
 606         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 607         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 608         breakpoint_address_is_meaningful.
 609         (bp_locations_compare): Adjust comment.
 610         (update_global_location_list): Use bl_address_is_meaningful
 611         instead of breakpoint_address_is_meaningful.
 612         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 613         explicit.
 614         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 615         * python/py-breakpoint.c (bppy_get_location): No longer check
 616         whether location is null.
 617
 618 2019-07-09  Pedro Alves  <palves@redhat.com>
 619
 620         PR c++/15468
 621         * breakpoint.c (print_one_breakpoint_location): Remove
 622         single-location assert.
 623
 624 2019-07-09  Tom Tromey  <tom@tromey.com>
 625
 626         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 627         * configure: Rebuild.
 628         * configure.ac: Change common to gdbsupport.
 629         * gdbsupport: Rename from common.
 630         * acinclude.m4: Change common to gdbsupport.
 631         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 632         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 633         gdbsupport.
 634         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 635         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 636         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 637         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 638         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 639         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 640         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 641         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 642         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 643         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 644         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 645         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 646         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 647         coff-pe-read.c, command.h, compile/compile-c-support.c,
 648         compile/compile-c.h, compile/compile-cplus-symbols.c,
 649         compile/compile-cplus-types.c, compile/compile-cplus.h,
 650         compile/compile-loc2c.c, compile/compile.c, completer.c,
 651         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 652         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 653         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 654         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 655         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 656         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 657         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 658         features/aarch64-core.c, features/aarch64-fpu.c,
 659         features/aarch64-pauth.c, features/aarch64-sve.c,
 660         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 661         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 662         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 663         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 664         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 665         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 666         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 667         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 668         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 669         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 670         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 671         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 672         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 673         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 674         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 675         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 676         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 677         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 678         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 679         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 680         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 681         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 682         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 683         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 684         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 685         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 686         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 687         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 688         minsyms.c, mips-linux-tdep.c, namespace.h,
 689         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 690         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 691         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 692         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 693         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 694         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 695         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 696         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 697         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 698         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 699         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 700         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 701         procfs.c, producer.c, progspace.h, psymtab.h,
 702         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 703         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 704         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 705         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 706         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 707         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 708         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 709         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 710         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 711         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 712         target-memory.c, target.c, target.h, target/waitstatus.c,
 713         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 714         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 715         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 716         unittests/array-view-selftests.c,
 717         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 718         unittests/common-utils-selftests.c,
 719         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 720         unittests/format_pieces-selftests.c,
 721         unittests/function-view-selftests.c,
 722         unittests/lookup_name_info-selftests.c,
 723         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 724         unittests/mkdir-recursive-selftests.c,
 725         unittests/observable-selftests.c,
 726         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 727         unittests/parse-connection-spec-selftests.c,
 728         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 729         unittests/scoped_fd-selftests.c,
 730         unittests/scoped_mmap-selftests.c,
 731         unittests/scoped_restore-selftests.c,
 732         unittests/string_view-selftests.c, unittests/style-selftests.c,
 733         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 734         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 735         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 736         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 737         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 738         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 739
 740 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 741
 742         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 743         bool value.
 744         (decode_digits_ordinary): Set explicit_line field in sal.
 745         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 746         symtab_and_line that was set on an explicit line number in
 747         assembler code.  Do always update the recorded symtab and line if
 748         we do skip the prologue.
 749
 750 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 751
 752         * breakpoint.c (set_breakpoint_location_function): Remove
 753         explicit_loc parameter.
 754         (momentary_breakpoint_from_master): Update call to
 755         set_breakpoint_location_function.
 756         (add_location_to_breakpoint): Likewise.
 757
 758 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 759
 760         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 761         required features based on default bfd type when no specific bfd
 762         is present.
 763
 764 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 765
 766         * NEWS: Mention that GDB printf and eval commands can now print
 767         C-style and Ada-style convenience var strings without
 768         calling the inferior.
 769         * printcmd.c (printf_c_string): Locally print GDB internal var
 770         instead of transiting via the inferior.
 771         (printf_wide_c_string): Likewise.
 772
 773 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 774
 775         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 776
 777 2019-07-04  Tom Tromey  <tom@tromey.com>
 778
 779         PR tui/24724:
 780         * tui/tui-winsource.c (tui_clear_source_content): Update.
 781         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 782         (tui_update_breakpoint_info): Update.
 783         (tui_set_exec_info_content): Update.
 784         * tui/tui-source.c (tui_set_source_content_nil): Update.
 785         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 786         has_break.
 787         * tui/tui-data.h (enum tui_bp_flag): New.
 788         (tui_bp_flags): New enum flags type.
 789         (struct tui_source_element) <break_mode>: Change type.  Rename
 790         from has_break.
 791         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 792         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 793         constants.
 794         * tui/tui-winsource.h: Fix comment.
 795
 796 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 797
 798         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 799         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 800         (store_fpregs_to_thread)
 801         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 802         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 803         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 804         (IWMMXT_REGS_SIZE): Add define.
 805         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 806         (fetch_vfp_regs, store_vfp_regs)
 807         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 808         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 809
 810 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 811
 812         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 813         defines.
 814         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 815         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 816         (ARM_INT_REGISTER_SIZE): ...to this.
 817         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 818         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 819         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 820         (arm_linux_collect_gregset, supply_nwfpe_register)
 821         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 822         defines.
 823         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 824         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 825         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 826         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 827         (arm_return_in_memory, arm_store_return_value)
 828         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 829         (arm_record_ld_st_multiple): Likewise.
 830         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 831         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 832
 833 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 834
 835         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 836         AARCH64_DISPLACED_MODIFIED_INSNS.
 837         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 838         (aarch64_displaced_step_copy_insn): Likewise.
 839         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 840         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 841         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 842         ARM_DISPLACED_MODIFIED_INSNS.
 843         * arm-tdep.c (arm_gdbarch_init): Likewise.
 844         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 845         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 846         (struct arm_displaced_step_closure): Use
 847         ARM_DISPLACED_MODIFIED_INSNS.
 848
 849 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 850
 851         * features/Makefile: Remove unused xml files.
 852         * features/aarch64.xml: Remove.
 853         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 854         * features/i386/amd64-avx-avx512.xml: Remove.
 855         * features/i386/amd64-avx-linux.xml: Remove.
 856         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 857         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 858         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 859         * features/i386/amd64-avx-mpx.xml: Remove.
 860         * features/i386/amd64-avx.xml: Remove.
 861         * features/i386/amd64-linux.xml: Remove.
 862         * features/i386/amd64-mpx-linux.xml: Remove.
 863         * features/i386/amd64-mpx.xml: Remove.
 864         * features/i386/amd64.xml: Remove.
 865         * features/i386/i386-avx-avx512-linux.xml: Remove.
 866         * features/i386/i386-avx-avx512.xml: Remove.
 867         * features/i386/i386-avx-linux.xml: Remove.
 868         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 869         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 870         * features/i386/i386-avx-mpx-linux.xml: Remove.
 871         * features/i386/i386-avx-mpx.xml: Remove.
 872         * features/i386/i386-avx.xml: Remove.
 873         * features/i386/i386-linux.xml: Remove.
 874         * features/i386/i386-mmx-linux.xml: Remove.
 875         * features/i386/i386-mmx.xml: Remove.
 876         * features/i386/i386-mpx-linux.xml: Remove.
 877         * features/i386/i386-mpx.xml: Remove.
 878         * features/i386/i386.xml: Remove.
 879         * features/i386/x32-avx-avx512-linux.xml: Remove.
 880         * features/i386/x32-avx-linux.xml: Remove.
 881         * features/i386/x32-linux.xml: Remove.
 882
 883 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 884
 885         * regformats/aarch64.dat: Remove.
 886         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 887         * regformats/i386/amd64-avx-linux.dat: Remove.
 888         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 889         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 890         * regformats/i386/amd64-linux.dat: Remove.
 891         * regformats/i386/amd64-mpx-linux.dat: Remove.
 892         * regformats/i386/amd64.dat: Remove.
 893         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 894         * regformats/i386/i386-avx-linux.dat: Remove.
 895         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 896         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 897         * regformats/i386/i386-linux.dat: Remove.
 898         * regformats/i386/i386-mmx-linux.dat: Remove.
 899         * regformats/i386/i386-mpx-linux.dat: Remove.
 900         * regformats/i386/i386.dat: Remove.
 901         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 902         * regformats/i386/x32-avx-linux.dat: Remove.
 903         * regformats/i386/x32-linux.dat: Remove.
 904
 905 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 906
 907         * aarch64-tdep.c: Remove xml self tests.
 908         * amd64-linux-tdep.c: Likewise.
 909         * amd64-tdep.c: Likewise.
 910         * i386-linux-tdep.c: Likewise.
 911         * i386-tdep.c: Likewise.
 912
 913 2019-07-03  Pedro Alves  <palves@redhat.com>
 914
 915         PR cli/24732
 916         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 917         (pipe_cmd_option_defs): New.
 918         (make_pipe_cmd_options_def_group): New.
 919         (pipe_command): Use gdb::option::process_options.
 920         (pipe_command_completer): New function.
 921         (_initialize_cli_cmds): Install completer for "pipe" command.
 922
 923 2019-07-03  Pedro Alves  <palves@redhat.com>
 924
 925         * cli/cli-option.c (union option_value) <string>: New field.
 926         (struct option_def_and_value): Add ctor, move ctor, dtor and
 927         use DISABLE_COPY_AND_ASSIGN.
 928         (option_def_and_value::clear_value): New.
 929         (parse_option, save_option_value_in_ctx, get_val_type_str)
 930         (add_setshow_cmds_for_options): Handle var_string.
 931         * cli-option.h (union option_def::var_address) <string>: New
 932         field.
 933         (struct string_option_def): New.
 934         * maint-test-options.c (struct test_options_opts): Add default
 935         ctor and use DISABLE_COPY_AND_ASSIGN.
 936         <string_opt>: New field.
 937         (test_options_opts::~test_options_opts): New.
 938         (test_options_opts::dump): Also dump "-string".
 939         (test_options_option_defs): Install "string.
 940
 941 2019-07-03  Pedro Alves  <palves@redhat.com>
 942
 943         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 944         option_value with a null enumeration.
 945         (complete_options): Save the option values in the context.
 946         (save_option_value_in_ctx): New, factored out from ...
 947         (process_options): ... here.
 948         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 949         of the function.
 950         * maint-test-options.c (test_options_opts::dump): New, factored
 951         out from ...
 952         (maintenance_test_options_command_mode): ... here.
 953         (maintenance_test_options_command_completion_result): Delete.
 954         (maintenance_test_options_command_completion_text): Update
 955         comment.
 956         (maintenance_show_test_options_completion_result): Change
 957         prototype.  Just print
 958         maintenance_test_options_command_completion_text.
 959         (save_completion_result): New.
 960         (maintenance_test_options_completer_mode): Pass options context to
 961         complete_options, and then save a dump.
 962         (_initialize_maint_test_options): Use add_cmd to install "maint
 963         show test-options-completion-result".
 964
 965 2019-07-03  Pedro Alves  <palves@redhat.com>
 966
 967         * NEWS (New commands): Mention "with" and "maint with".
 968         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 969         (with_command, with_command_completer): New.
 970         (pipe_command): Adjust to new repeat_previous
 971         interface.
 972         (_initialize_cli_cmds): Install the "with" command and its "w"
 973         alias.
 974         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 975         declarations.
 976         * cli/cli-setshow.c (parse_cli_var_uinteger)
 977         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 978         argument strings for all var_types.
 979         (get_setshow_command_value_string): New, factored out from ...
 980         (do_show_command): ... this.
 981         * cli/cli-setshow.h: Include <string>.
 982         (get_setshow_command_value_string): Declare.
 983         * command.h (repeat_previous): Now returns const char *.  Adjust
 984         comment.
 985         * maint.c: Include "cli/cli-cmds.h".
 986         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 987         (_initialize_maint_cmds): Register the "maintenance with" command.
 988         * top.c (repeat_previous): Move bits from pipe_command here:
 989         Return the saved command line, if any; error out if there's no
 990         command to relaunch.
 991
 992 2019-07-03  Pedro Alves  <palves@redhat.com>
 993
 994         * NEWS (New commands): Mention "maint set/show test-settings"
 995         instead of "maint test-settings".
 996         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 997         (maintenance_test_settings_set_list): Rename to ...
 998         (maintenance_set_test_settings_list): ... this.
 999         (maintenance_test_settings_show_list): Rename to  ...
1000         (maintenance_show_test_settings_list): ... this.
1001         (maintenance_test_settings_cmd): Delete.
1002         (maintenance_test_settings_set_cmd): ...
1003         (maintenance_set_test_settings_cmd): ... this.
1004         (maintenance_test_settings_show_cmd): ...
1005         (maintenance_show_test_settings_cmd): ... this.
1006         (maintenance_test_settings_show_value_cmd):
1007         (maintenance_show_test_settings_value_cmd): ... this.
1008         (_initialize_maint_test_settings): No longer install the "maint
1009         test-settings" prefix command.  Rename "maint test-settings set"
1010         to "maint set test-settings", and "maint test-settings show" to
1011         "maint show test-settings".  Adjust all subcommands.
1012
1013 2019-07-03  Pedro Alves  <palves@redhat.com>
1014
1015         * maint-test-settings.c: Fix file's intro comment.  Replace all
1016         references to "test-options" with references to "test-settings",
1017         in comments.
1018
1019 2019-07-03  Pedro Alves  <palves@redhat.com>
1020
1021         * maint-test-settings.c (maintenance_test_settings_xxx)
1022         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1023         New.
1024         (maintenance_test_settings_enums): Use them.
1025         (maintenance_test_settings_enum): Default to
1026         maintenance_test_settings_xxx.
1027         (_initialize_maint_test_settings): Initialize
1028         MAINTENANCE_TEST_SETTINGS_FILENAME.
1029
1030 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1031
1032         * breakpoint.h (remove_breakpoints_inf): Change return type to
1033         void, move function documentation here.
1034         * breakpoint.c (remove_breakpoints_inf): Change return type to
1035         void, move function documentation to header.
1036
1037 2019-07-02  Pedro Alves  <palves@redhat.com>
1038
1039         * NEWS (Completion improvements): Mention "info threads".
1040         * thread.c (struct info_threads_opts, info_threads_option_defs)
1041         (make_info_threads_options_def_group): New.
1042         (info_threads_command): Use gdb::option::process_options.
1043         (info_threads_command_completer): New.
1044         (_initialize_thread): Use gdb::option::build_help to build the
1045         help text for "info threads".
1046
1047 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1048
1049         * defs.h (generic_load): Move from here...
1050         * symfile.h (generic_load): ... to here.  Rename name parameter
1051         to args.
1052         * symfile.c (generic_load): Add comment.
1053
1054 2019-07-01  Tom Tromey  <tromey@adacore.com>
1055
1056         * dwarf2read.c
1057         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1058         declaration of without_params.  Fix formatting.
1059
1060 2019-07-01  Tom Tromey  <tromey@adacore.com>
1061
1062         * ada-exp.y (find_primitive_type): Update.
1063         * ada-lang.h (ada_lookup_symbol): Update.
1064         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1065         parameter.
1066         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1067
1068 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1069
1070         PR breakpoints/24541
1071         * gdbarch.c: Regenerate.
1072         * gdbarch.h: Regenerate.
1073         * gdbarch.sh: Add 'stap_adjust_register'.
1074         * i386-tdep.c: Include '<unordered_set>'.
1075         (i386_stap_adjust_register): New function.
1076         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1077         * stap-probe.c (stap_parse_register_operand): Call
1078         'gdbarch_stap_adjust_register'.
1079
1080 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1081
1082         PR python/24742
1083         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1084         * python/python.c (do_start_initialization): Use 'xmalloc'
1085         instead of 'PyMem_Malloc'.
1086
1087 2019-06-28  Tom Tromey  <tromey@adacore.com>
1088
1089         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1090         for Ada.
1091
1092 2019-06-27  Tom Tromey  <tromey@adacore.com>
1093
1094         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1095         objfile_key.
1096         (arm_find_mapping_symbol, arm_record_special_symbol)
1097         (_initialize_arm_tdep): Update.
1098         (arm_objfile_data_free): Remove.
1099
1100 2019-06-27  Tom Tromey  <tromey@adacore.com>
1101
1102         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1103         to cp_print_static_field.
1104
1105 2019-06-26  Tom Tromey  <tromey@adacore.com>
1106
1107         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1108         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1109         declare.
1110
1111 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1112
1113         * features/aarch64-core.c (create_feature_aarch64_core):
1114         Regenerate.
1115         * features/aarch64-core.xml: Add cpsr flags.
1116
1117 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1118
1119         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1120         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1121
1122 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1123
1124         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1125         field.
1126         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1127         use.
1128         (arm_record_special_symbol): Don't insert new symbol in sorted
1129         position, push it at the end.
1130
1131 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1132
1133         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1134         (arm_mapping_symbol_s): Remove.
1135         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1136         (arm_mapping_symbol_vec): New typedef.
1137         (struct arm_per_objfile): Add constructor.
1138         <section_maps>: Change type to
1139         std::unique_ptr<arm_mapping_symbol_vec[]>.
1140         (arm_compare_mapping_symbols): Remove.
1141         (arm_find_mapping_symbol): Adjust to section_maps type change.
1142         (arm_objfile_data_free): Call delete on arm_per_objfile.
1143         (arm_record_special_symbol): Adjust to section_maps type change.
1144         Allocate arm_per_objfile with new.
1145
1146 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1147
1148         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1149         with the command prefix.
1150
1151 2019-06-25  Tom Tromey  <tom@tromey.com>
1152
1153         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1154         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1155
1156 2019-06-25  Tom Tromey  <tom@tromey.com>
1157
1158         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1159         type.
1160         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1161         protected.
1162
1163 2019-06-25  Tom Tromey  <tom@tromey.com>
1164
1165         * tui/tui-winsource.c
1166         (tui_source_window_base::set_is_exec_point_at): Add check against
1167         LOA_ADDRESS.
1168
1169 2019-06-25  Tom Tromey  <tom@tromey.com>
1170
1171         * tui/tui-source.c (tui_set_source_content): Don't check before
1172         xfree.
1173         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1174
1175 2019-06-25  Tom Tromey  <tom@tromey.com>
1176
1177         * tui/tui-winsource.h (tui_update_source_window_as_is)
1178         (tui_alloc_source_buffer, tui_line_is_displayed)
1179         (tui_addr_is_displayed): Change type of win_info.
1180         * tui/tui-winsource.c (tui_update_source_window_as_is)
1181         (tui_clear_source_content, tui_show_source_line)
1182         (tui_show_source_content, tui_source_window_base::refill)
1183         (tui_source_window_base::set_is_exec_point_at)
1184         (tui_source_window_base::set_is_exec_point_at)
1185         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1186         (tui_alloc_source_buffer, tui_line_is_displayed)
1187         (tui_addr_is_displayed): Change type of win_info.  Update.
1188         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1189         (tui_source_window_base::do_make_visible_with_new_height):
1190         Update.
1191         * tui/tui-source.c (tui_set_source_content)
1192         (tui_set_source_content_nil)
1193         (tui_source_window::do_scroll_vertical): Update.
1194         * tui/tui-layout.c (show_layout): Update.
1195         * tui/tui-disasm.c (tui_set_disassem_content)
1196         (tui_disasm_window::do_scroll_vertical): Update.
1197         * tui/tui-data.h (tui_win_content): Remove.
1198         (struct tui_gen_win_info) <content, content_size>: Remove.
1199         (struct tui_source_element): Add initializers and destructor.
1200         (union tui_which_element, struct tui_win_element): Remove.
1201         (struct tui_source_window_base) <content>: New field.
1202         (struct tui_data_window): Remove destructor.
1203         (tui_alloc_content, tui_free_win_content)
1204         (tui_free_all_source_wins_content): Don't declare.
1205         * tui/tui-data.c (tui_initialize_static_data): Update.
1206         (init_content_element, tui_alloc_content): Remove.
1207         (~tui_gen_win_info): Update.
1208         (~tui_data_window, tui_free_all_source_wins_content)
1209         (tui_free_win_content, free_content, free_content_elements):
1210         Remove.
1211
1212 2019-06-25  Tom Tromey  <tom@tromey.com>
1213
1214         * tui/tui-winsource.h (tui_clear_source_content)
1215         (tui_erase_source_content, tui_show_source_content): Change type
1216         of win_info.
1217         * tui/tui-winsource.c (tui_clear_source_content)
1218         (tui_erase_source_content, tui_show_source_content): Change type
1219         of win_info.
1220         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1221         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1222         win_info.
1223         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1224         win_info.
1225         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1226
1227 2019-06-25  Tom Tromey  <tom@tromey.com>
1228
1229         * tui/tui-winsource.c (tui_clear_source_content)
1230         (tui_source_window_base::set_is_exec_point_at): Update.
1231         * tui/tui-source.c (tui_set_source_content_nil): Update.
1232         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1233         a bool.
1234         * tui/tui-data.c (init_content_element): Update.
1235
1236 2019-06-25  Tom Tromey  <tom@tromey.com>
1237
1238         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1239         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1240         * tui/tui-layout.c (init_and_make_win): Update.
1241         * tui/tui.h (enum tui_win_type): Update.
1242         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1243         tui_win_is_auxillary.
1244         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1245         tui_win_is_auxillary.
1246
1247 2019-06-25  Tom Tromey  <tom@tromey.com>
1248
1249         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1250         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1251         (tui_delete_data_content_windows, tui_display_all_data)
1252         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1253         Update.
1254         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1255         * tui/tui-regs.c (tui_last_regs_line_no)
1256         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1257         (tui_show_registers): Update.
1258         (tui_show_register_group): Return void.  Update.
1259         (tui_display_registers_from, tui_display_reg_element_at_line)
1260         (tui_display_registers_from_line, tui_check_register_values):
1261         Update.
1262         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1263         member.
1264         (struct tui_data_window) <regs_content>: Now a std::vector.
1265         <regs_content_count>: Remove.
1266         (tui_add_content_elements, tui_free_data_content): Don't declare.
1267         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1268         (init_content_element): Remove DATA_WIN case.  Add assert.
1269         (tui_add_content_elements): Remove.
1270         (tui_data_window): Update.
1271         (tui_free_data_content): Remove.
1272         (free_content_elements): Remove DATA_WIN case.
1273
1274 2019-06-25  Tom Tromey  <tom@tromey.com>
1275
1276         * tui/tui-data.c (tui_data_item_window): Update.
1277         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1278         * tui/tui-windata.c (tui_display_all_data)
1279         (tui_display_data_from_line): Update.
1280         (tui_check_data_values): Remove.
1281         * tui/tui-regs.c (tui_show_register_group)
1282         (tui_display_reg_element_at_line): Update.
1283         * tui/tui-hooks.c (tui_register_changed)
1284         (tui_refresh_frame_and_register_information): Call
1285         tui_check_register_values.
1286         * tui/tui-data.h (struct tui_data_window) <data_content,
1287         data_content_count, data_type>: Remove.
1288         (enum tui_data_type): Remove.
1289
1290         * tui/tui-data.c (tui_data_window::clear_detail)
1291         (~tui_data_window): Update.
1292
1293 2019-06-25  Tom Tromey  <tom@tromey.com>
1294
1295         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1296         declare.
1297         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1298         Rename from tui_first_data_item_displayed.  Update.
1299         (tui_data_window::refresh_all)
1300         (tui_data_window::do_scroll_vertical): Update.
1301         * tui/tui-data.h (struct tui_data_window)
1302         <first_data_item_displayed>: Declare new method.
1303
1304 2019-06-25  Tom Tromey  <tom@tromey.com>
1305
1306         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1307         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1308         contents...
1309         (tui_initialize_static_data): ...here.
1310
1311 2019-06-25  Tom Tromey  <tom@tromey.com>
1312
1313         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1314         (tui_display_registers_from, tui_check_register_values): Update.
1315         (tui_display_register): Remove win_info parameter; update.
1316         (tui_get_register): Change type of parameters.
1317         * tui/tui-data.h (struct tui_data_element): Remove.
1318         (union tui_which_element) <data>: Remove.
1319         <data_window>: Change type.
1320         (struct tui_data_item_window): New.
1321         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1322         case.  Add assert.
1323         (~tui_data_item_window): New destructor.
1324         (free_content_elements): Remove DATA_ITEM_WIN case.
1325
1326 2019-06-25  Tom Tromey  <tom@tromey.com>
1327
1328         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1329         Remove.
1330
1331 2019-06-25  Tom Tromey  <tom@tromey.com>
1332
1333         * tui/tui-data.h (struct tui_command_element): Remove.
1334         (union tui_which_element) <command>: Remove.
1335         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1336         assert.
1337         (free_content_elements): Remove CMD_WIN case.
1338
1339 2019-06-25  Tom Tromey  <tom@tromey.com>
1340
1341         * tui/tui-layout.c (tui_set_layout): Update.
1342         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1343         * tui/tui-data.c (layout_def): Update.
1344
1345 2019-06-25  Tom Tromey  <tom@tromey.com>
1346
1347         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1348         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1349         (tui_source_window_base::set_new_height): Update.
1350         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1351         Update.
1352         (tui_set_locator_fullname, tui_set_locator_info)
1353         (tui_show_frame_info): Update.
1354         * tui/tui-source.c (tui_set_source_content)
1355         (tui_source_is_displayed): Update.
1356         * tui/tui-layout.c (show_source_disasm_command, show_data)
1357         (show_source_or_disasm_and_command): Update.
1358         * tui/tui-disasm.c (tui_set_disassem_content)
1359         (tui_get_begin_asm_address): Update.
1360         * tui/tui-data.h (struct tui_locator_element): Remove.
1361         (union tui_which_element) <locator>: Remove.
1362         (struct tui_locator_window): New.
1363         (tui_locator_win_info_ptr): Change return type.
1364         * tui/tui-data.c (_locator): Change type.
1365         (tui_locator_win_info_ptr): Change return type.
1366         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1367         (tui_alloc_content): Add assert.
1368
1369 2019-06-25  Tom Tromey  <tom@tromey.com>
1370
1371         * tui/tui-winsource.c
1372         (tui_exec_info_window::maybe_allocate_content): New method.
1373         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1374         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1375         (make_source_or_disasm_window): Add cast.
1376         * tui/tui-data.h (union tui_which_element) <simple_string>:
1377         Remove.
1378         (struct tui_source_info): New.
1379         (struct tui_source_window_base) <execution_info>: Change type.
1380         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1381         case, and add assert.
1382         (tui_alloc_content): Add assert.
1383
1384 2019-06-25  Tom Tromey  <tom@tromey.com>
1385
1386         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1387         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1388         * tui/tui-data.c (tui_alloc_win_info): Remove.
1389
1390 2019-06-25  Tom Tromey  <tom@tromey.com>
1391
1392         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1393         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1394         can_highlight.
1395
1396 2019-06-25  Tom Tromey  <tom@tromey.com>
1397
1398         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1399         make_visible_with_new_height method.
1400         (tui_win_info::make_visible_with_new_height): New method.
1401         (tui_source_window_base::do_make_visible_with_new_height)
1402         (tui_data_window::do_make_visible_with_new_height)
1403         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1404         (make_visible_with_new_height): Remove.
1405         (tui_resize_all, tui_adjust_win_heights): Use
1406         make_visible_with_new_height method.
1407         * tui/tui-data.h (struct tui_win_info)
1408         <do_make_visible_with_new_height, make_visible_with_new_height>:
1409         New methods.
1410         (struct tui_source_window_base, struct tui_data_window)
1411         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1412         methods.
1413
1414 2019-06-25  Tom Tromey  <tom@tromey.com>
1415
1416         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1417         method.
1418         (update_tab_width): Call update_tab_width method.
1419         * tui/tui-data.h (struct tui_win_info)
1420         (struct tui_source_window_base) <update_tab_width>: New methods.
1421
1422 2019-06-25  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1425         parameter.
1426         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1427         parameter.
1428         (tui_gen_win_info::make_visible): Update.
1429         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1430         parameter.
1431         * tui/tui-data.h (enum tui_box): New enum.
1432         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1433
1434 2019-06-25  Tom Tromey  <tom@tromey.com>
1435
1436         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1437         init_and_make_win for EXEC_INFO_WIN.
1438         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1439         longer inline.
1440         (struct tui_win_info) <~tui_win_info>: Inline.
1441         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1442         Don't declare.
1443         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1444         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1445         Remove.
1446         (tui_initialize_static_data): Update.
1447         (~tui_gen_win_info): Handle more cleanup here.
1448         (~tui_source_window_base): Delete "execution_info".
1449         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1450
1451 2019-06-25  Tom Tromey  <tom@tromey.com>
1452
1453         * tui/tui-layout.c (make_command_window): Don't set
1454         can_highlight.
1455         (show_source_disasm_command): Call the reset method.
1456         (show_data): Don't set can_highlight.  Call the reset method.
1457         (tui_gen_win_info::reset): Rename from init_gen_win_info
1458         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1459         (show_source_or_disasm_and_command): Call the reset method.
1460         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1461         (struct tui_cmd_window): Set can_highlight.
1462
1463 2019-06-25  Tom Tromey  <tom@tromey.com>
1464
1465         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1466         from make_visible.
1467         (tui_make_visible, tui_make_invisible): Rewrite.
1468         (tui_win_info::make_visible): Remove.
1469         (tui_source_window_base::make_visible): Update.
1470         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1471         method.  Moved from...
1472         (struct tui_win_info) <make_visible>: ...here.
1473
1474 2019-06-25  Tom Tromey  <tom@tromey.com>
1475
1476         * tui/tui-winsource.c
1477         (tui_source_window_base::do_scroll_horizontal): Remove direction
1478         parameter.
1479         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1480         direction parameter.
1481         * tui/tui-win.c (tui_win_info::forward_scroll)
1482         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1483         (tui_win_info::right_scroll): Update.
1484         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1485         direction parameter.
1486         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1487         direction parameter.
1488         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1489         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1490         Remove direction parameter.
1491         (struct tui_source_window_base, struct tui_source_window)
1492         (struct tui_disasm_window, struct tui_data_window)
1493         (struct tui_cmd_window): Update.
1494
1495 2019-06-25  Tom Tromey  <tom@tromey.com>
1496
1497         * tui/tui-winsource.h (tui_set_exec_info_content)
1498         (tui_show_exec_info_content, tui_erase_exec_info_content)
1499         (tui_clear_exec_info_content, tui_update_exec_info): Change
1500         argument to tui_source_window_base.
1501         * tui/tui-winsource.c (tui_set_exec_info_content)
1502         (tui_show_exec_info_content, tui_erase_exec_info_content)
1503         (tui_clear_exec_info_content, tui_update_exec_info): Change
1504         argument to tui_source_window_base.
1505
1506 2019-06-25  Tom Tromey  <tom@tromey.com>
1507
1508         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1509         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1510
1511 2019-06-25  Tom Tromey  <tom@tromey.com>
1512
1513         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1514         check.
1515
1516 2019-06-25  Tom Tromey  <tom@tromey.com>
1517
1518         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1519         type to void.
1520         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1521         type to void.
1522         * tui/tui-source.c (tui_set_source_content): Update.
1523         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1524
1525 2019-06-25  Tom Tromey  <tom@tromey.com>
1526
1527         * tui/tui-win.c (window_name_completer, tui_set_focus)
1528         (tui_all_windows_info): Use name method.
1529         * tui/tui-data.h (struct tui_gen_win_info)
1530         (struct tui_source_window, struct tui_disasm_window)
1531         (struct tui_data_window, struct tui_cmd_window) <name>: New
1532         method.
1533         (tui_win_name): Don't declare.
1534         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1535         (tui_win_name): Remove.
1536
1537 2019-06-25  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-winsource.h (tui_update_source_window)
1540         (tui_update_source_window_as_is): Change parameter type.
1541         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1542         to be a tui_source_window_base.
1543         (tui_update_source_window_as_is): Likewise.
1544         * tui/tui-win.c (make_visible_with_new_height): Update.
1545
1546 2019-06-25  Tom Tromey  <tom@tromey.com>
1547
1548         * tui/tui-winsource.c (tui_erase_source_content)
1549         (tui_show_source_content, tui_show_exec_info_content)
1550         (tui_erase_exec_info_content): Use refresh_window method.
1551         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1552         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1553         from tui_refresh_win.
1554         (tui_data_window::refresh_window): New method.
1555         (tui_win_info::refresh, tui_source_window_base::refresh)
1556         (tui_refresh_all): Use refresh_window method.
1557         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1558         method.
1559         * tui/tui-regs.c (tui_display_register): Call refresh_window
1560         method.
1561         * tui/tui-layout.c (show_source_disasm_command)
1562         (show_source_or_disasm_and_command): Call refresh_window method.
1563         * tui/tui-data.h (struct tui_gen_win_info)
1564         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1565         New method.
1566
1567 2019-06-25  Tom Tromey  <tom@tromey.com>
1568
1569         * tui/tui.c (tui_rl_other_window, tui_enable)
1570         (tui_is_window_visible, tui_get_command_dimension): Update.
1571         * tui/tui-winsource.c (tui_update_source_window_as_is)
1572         (tui_clear_source_content, tui_erase_source_content)
1573         (tui_show_source_line, tui_source_window_base::refill)
1574         (tui_source_window_base::do_scroll_horizontal)
1575         (tui_source_window_base::set_is_exec_point_at)
1576         (tui_update_breakpoint_info, tui_set_exec_info_content)
1577         (tui_alloc_source_buffer, tui_line_is_displayed)
1578         (tui_addr_is_displayed): Update.
1579         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1580         (tui_check_and_display_highlight_if_needed)
1581         (tui_win_info::make_visible, tui_win_info::refresh)
1582         (tui_refresh_all): Update.
1583         * tui/tui-windata.c (tui_first_data_item_displayed)
1584         (tui_delete_data_content_windows, tui_erase_data_content)
1585         (tui_display_all_data, tui_data_window::refresh_all)
1586         (tui_check_data_values): Update.
1587         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1588         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1589         (tui_win_info::backward_scroll, tui_refresh_all_win)
1590         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1591         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1592         (tui_source_window_base::set_new_height)
1593         (tui_data_window::set_new_height)
1594         (make_invisible_and_set_new_height)
1595         (make_visible_with_new_height, new_height_ok)
1596         (parse_scrolling_args): Update.
1597         * tui/tui-stack.c (tui_show_frame_info): Update.
1598         * tui/tui-source.c (tui_set_source_content)
1599         (tui_set_source_content_nil, tui_source_is_displayed)
1600         (tui_source_window::do_scroll_vertical): Update.
1601         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1602         (tui_display_registers_from, tui_display_reg_element_at_line)
1603         (tui_check_register_values, tui_reg_command): Update.
1604         * tui/tui-layout.c (tui_default_win_height)
1605         (show_source_disasm_command, show_data, init_and_make_win)
1606         (show_source_or_disasm_and_command): Update.
1607         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1608         (tui_redisplay_readline, tui_mld_flush)
1609         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1610         (tui_getc): Update.
1611         * tui/tui-disasm.c (tui_set_disassem_content)
1612         (tui_disasm_window::do_scroll_vertical): Update.
1613         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1614         Now virtual.
1615         (struct tui_win_info): Derive from tui_gen_win_info.
1616         <~tui_win_info>: Mark as override.
1617         <generic>: Remove member.
1618         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1619         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1620         (~tui_data_window, ~tui_win_info)
1621         (tui_free_all_source_wins_content): Update.
1622         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1623
1624 2019-06-25  Tom Tromey  <tom@tromey.com>
1625
1626         * tui/tui-layout.c (init_and_make_win): Use new.
1627         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1628         destructor, initializers.
1629         (tui_alloc_generic_win_info): Don't declare.
1630         * tui/tui-data.c (_locator): Add argument to constructor.
1631         (source_win, disasm_win): New globals.
1632         (exec_info): Remove.
1633         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1634         Update.
1635         (tui_alloc_generic_win_info): Remove.
1636         (init_content_element): Use new.
1637         (tui_win_info::tui_win_info): Update.
1638         (free_content_elements) <case DATA_WIN>: Use delete.
1639
1640 2019-06-25  Tom Tromey  <tom@tromey.com>
1641
1642         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1643         * tui/tui-windata.c (tui_first_data_item_displayed)
1644         (tui_delete_data_content_windows): Update.
1645         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1646         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1647         (tui_display_registers_from, tui_check_register_values): Update.
1648         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1649         pointer.
1650         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1651         window.
1652         (tui_free_data_content): Update.
1653         (free_content_elements) <case DATA_WIN>: Free the window.
1654
1655 2019-06-25  Tom Tromey  <tom@tromey.com>
1656
1657         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1658         Update.
1659         * tui/tui-layout.c (make_command_window)
1660         (show_source_disasm_command, show_data, init_and_make_win)
1661         (show_source_or_disasm_and_command): Update.
1662         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1663         method.
1664         <can_highight, is_highlighted>: Now bool.
1665         (tui_set_win_highlight): Don't declare.
1666         * tui/tui-data.c (tui_set_win_highlight): Remove.
1667
1668 2019-06-25  Tom Tromey  <tom@tromey.com>
1669
1670         * tui/tui-wingeneral.c (make_visible): Remove check of window
1671         type.
1672
1673 2019-06-25  Tom Tromey  <tom@tromey.com>
1674
1675         * tui/tui-win.c (tui_win_info::max_height)
1676         (tui_cmd_window::max_height): New methods.
1677         (new_height_ok): Call max_height.
1678         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1679         <max_height>: New method.
1680
1681 2019-06-25  Tom Tromey  <tom@tromey.com>
1682
1683         * tui/tui-win.c (tui_source_window_base::set_new_height)
1684         (tui_data_window::set_new_height): New methods.
1685         (make_invisible_and_set_new_height): Call set_new_height method.
1686         * tui/tui-data.h (struct tui_win_info)
1687         (struct tui_source_window_base, struct tui_data_window)
1688         <set_new_height>: New method.
1689
1690 2019-06-25  Tom Tromey  <tom@tromey.com>
1691
1692         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1693         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1694         tui_refresh_data_win.
1695         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1696         method.
1697         (tui_refresh_all_win): Call the refresh_all method.
1698         (tui_set_focus): Likewise.
1699         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1700         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1701         Likewise.
1702
1703 2019-06-25  Tom Tromey  <tom@tromey.com>
1704
1705         * tui/tui-winsource.h (tui_refill_source_window)
1706         (tui_set_is_exec_point_at): Don't declare.
1707         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1708         (tui_source_window_base::refill): Rename from
1709         tui_refill_source_window.
1710         (tui_source_window_base::do_scroll_horizontal): Update.
1711         (tui_source_window_base::set_is_exec_point_at): Rename from
1712         tui_set_is_exec_point_at.
1713         (tui_update_all_breakpoint_info): Update.
1714         * tui/tui-stack.c (tui_show_frame_info): Update.
1715         * tui/tui-layout.c (show_data): Add cast.
1716         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1717         * tui/tui-data.h (struct tui_source_window_base) <refill,
1718         set_is_exec_point_at>: New methods.
1719         (tui_source_windows, tui_add_to_source_windows): Update types.
1720         (tui_add_to_source_windows): Remove redundant declaration.
1721         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1722         (tui_source_windows): Change return type.
1723         (tui_clear_source_windows_detail): Update.
1724         (tui_add_to_source_windows): Change type of parameter.
1725         (tui_free_all_source_wins_content): Update.
1726
1727 2019-06-25  Tom Tromey  <tom@tromey.com>
1728
1729         * tui/tui-wingeneral.c (tui_win_info::refresh)
1730         (tui_source_window_base::refresh): New methods.
1731         (tui_refresh_all): Call the refresh method.
1732         * tui/tui-data.h (struct tui_win_info)
1733         (struct tui_source_window_base) <refresh>: New method.
1734
1735 2019-06-25  Tom Tromey  <tom@tromey.com>
1736
1737         * tui/tui.h (tui_is_window_visible): Return bool.
1738         * tui/tui.c (tui_is_window_visible): Return bool.
1739         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1740         (tui_make_visible, tui_make_invisible)
1741         (tui_win_info::make_visible)
1742         (tui_source_window_base::make_visible, make_all_visible)
1743         (tui_make_all_visible, tui_make_all_invisible): Update.
1744         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1745         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1746         bool.
1747         (struct tui_win_info, struct tui_source_window_base)
1748         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1749         * tui/tui-data.c (tui_init_generic_part): Update.
1750
1751 2019-06-25  Tom Tromey  <tom@tromey.com>
1752
1753         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1754         (tui_source_window_base::make_visible): New methods.
1755         (make_all_visible): Make method call.
1756         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1757         (struct tui_source_window_base, struct tui_cmd_window): Override
1758         make_visible.
1759         (tui_win_is_source_type): Don't declare.
1760         * tui/tui-data.c (tui_win_is_source_type): Remove.
1761
1762 2019-06-25  Tom Tromey  <tom@tromey.com>
1763
1764         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1765         NULL check.
1766
1767 2019-06-25  Tom Tromey  <tom@tromey.com>
1768
1769         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1770         Inline constructor.  Add initializers for members.
1771         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1772         constructors; now inline in class.
1773
1774 2019-06-25  Tom Tromey  <tom@tromey.com>
1775
1776         * tui/tui-regs.c (tui_show_registers): Update.
1777         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1778         bool.
1779         * tui/tui-data.c (tui_data_window::clear_detail)
1780         (tui_data_window): Update.
1781
1782 2019-06-25  Tom Tromey  <tom@tromey.com>
1783
1784         * tui/tui-windata.c (tui_display_all_data)
1785         (tui_display_data_from_line, tui_display_data_from)
1786         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1787         Update.
1788         * tui/tui-regs.c (tui_last_regs_line_no)
1789         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1790         (tui_show_registers, tui_show_register_group)
1791         (tui_display_registers_from, tui_display_reg_element_at_line)
1792         (tui_display_registers_from_line, tui_check_register_values)
1793         (tui_reg_next, tui_reg_prev): Update.
1794         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1795         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1796         tui_data_window.
1797         (struct tui_win_info) <detail>: Remove.  Add new fields from
1798         tui_data_info.
1799         (TUI_DATA_WIN): Add cast.
1800         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1801         (~tui_data_window): Simplify.
1802
1803 2019-06-25  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-layout.c (show_source_disasm_command)
1806         (show_source_or_disasm_and_command): Update.
1807         * tui/tui-io.c (update_cmdwin_start_line)
1808         (tui_redisplay_readline): Update.
1809         * tui/tui-data.h (struct tui_command_info): Remove.
1810         (struct tui_win_info) <detail>: Remove command_info member.
1811         (struct tui_data_window) <start_line>: New member, from
1812         tui_command_info.
1813         (TUI_CMD_WIN): Add casts.
1814
1815 2019-06-25  Tom Tromey  <tom@tromey.com>
1816
1817         * tui/tui-winsource.c (tui_update_source_window)
1818         (tui_refill_source_window)
1819         (tui_source_window_base::do_scroll_horizontal)
1820         (tui_update_breakpoint_info, tui_set_exec_info_content)
1821         (tui_show_exec_info_content, tui_erase_exec_info_content)
1822         (tui_clear_exec_info_content): Update.
1823         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1824         Update.
1825         * tui/tui-win.c (make_invisible_and_set_new_height)
1826         (make_visible_with_new_height): Update.
1827         * tui/tui-source.c (tui_set_source_content)
1828         (tui_show_symtab_source): Update.
1829         * tui/tui-layout.c (extract_display_start_addr)
1830         (show_source_disasm_command, show_data)
1831         (make_source_or_disasm_window)
1832         (show_source_or_disasm_and_command): Update.
1833         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1834         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1835         "gdbarch".
1836         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1837         to tui_source_window_base.
1838         (struct tui_win_info) <detail>: Remove source_info member.
1839         (struct tui_source_window_base) <has_locator>: Inline.
1840         Move contents from tui_source_info; rename has_locator member to
1841         m_has_locator.
1842         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1843         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1844         header file.
1845         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1846         Simplify.
1847         (tui_free_all_source_wins_content): Cast to
1848         tui_source_window_base.
1849
1850 2019-06-25  Tom Tromey  <tom@tromey.com>
1851
1852         * tui/tui-win.c (make_invisible_and_set_new_height)
1853         (make_visible_with_new_height): Call has_locator method.
1854         * tui/tui-layout.c (show_source_disasm_command, show_data)
1855         (show_source_or_disasm_and_command): Update for bool change.
1856         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1857         (tui_win_info) <has_locator>: New method.
1858         (struct tui_source_window_base) <has_locator>: New method.
1859         (tui_win_has_locator): Don't declare.
1860         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1861         from tui_win_has_locator.
1862         (tui_source_window_base): Use false, not FALSE.
1863
1864 2019-06-25  Tom Tromey  <tom@tromey.com>
1865
1866         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1867         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1868         clear_detail method directly.
1869         (tui_clear_win_detail): Remove.
1870
1871 2019-06-25  Tom Tromey  <tom@tromey.com>
1872
1873         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1874         "this", not TUI_DISASM_WIN.
1875
1876 2019-06-25  Tom Tromey  <tom@tromey.com>
1877
1878         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1879         declare.
1880         * tui/tui-winsource.c
1881         (tui_source_window_base::do_scroll_horizontal): Rename from
1882         tui_horizontal_source_scroll.
1883         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1884         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1885         from tui_vertical_data_scroll.
1886         * tui/tui-win.h (tui_scroll): Don't declare.
1887         * tui/tui-win.c (tui_win_info::forward_scroll)
1888         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1889         (tui_win_info::right_scroll): Rename and update.
1890         (tui_scroll_forward_command, tui_scroll_backward_command)
1891         (tui_scroll_left_command, tui_scroll_right_command): Update.
1892         (tui_scroll): Remove.
1893         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1894         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1895         from tui_vertical_source_scroll.
1896         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1897         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1898         from tui_vertical_disassem_scroll.
1899         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1900         do_scroll_horizontal>: New methods.
1901         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1902         Likewise.
1903         (struct tui_source_window_base): Add do_scroll_horizontal.
1904         (struct tui_source_window, struct tui_disasm_window): Add
1905         do_scroll_vertical.
1906         (struct tui_data_window, struct tui_cmd_window): Add
1907         do_scroll_horizontal and do_scroll_vertical.
1908         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1909
1910 2019-06-25  Tom Tromey  <tom@tromey.com>
1911
1912         * tui/tui-data.h (struct tui_source_window_base): New struct.
1913         (struct tui_source_window): Derive from tui_source_window_base.
1914         (struct tui_disasm_window): New struct.
1915         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1916         from tui_source_window::clear_detail.
1917         (tui_source_window_base): Rename from tui_source_window.
1918         (~tui_source_window_base): Rename from ~tui_source_window.
1919         (tui_alloc_win_info): Create a tui_disasm_window.
1920
1921 2019-06-25  Tom Tromey  <tom@tromey.com>
1922
1923         * tui/tui-data.h (struct tui_source_window)
1924         (struct tui_data_window): Declare destructors.
1925         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1926         destructors.
1927         (tui_win_info): Simplify.
1928
1929 2019-06-25  Tom Tromey  <tom@tromey.com>
1930
1931         * tui/tui-winsource.c (tui_display_main)
1932         (tui_update_source_windows_with_addr)
1933         (tui_update_all_breakpoint_info): Update.
1934         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1935         (new_height_ok, parse_scrolling_args): Update.
1936         * tui/tui-stack.c (tui_show_frame_info): Update.
1937         * tui/tui-data.h (struct tui_list): Remove.
1938         (tui_source_windows): Return a reference to a std::vector.
1939         * tui/tui-data.c (source_windows): Now a std::vector.
1940         (tui_source_windows): Change return type.
1941         (tui_clear_source_windows): Rewrite.
1942         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1943         (tui_free_all_source_wins_content): Rewrite.
1944
1945 2019-06-25  Tom Tromey  <tom@tromey.com>
1946
1947         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1948         (struct tui_data_window, struct tui_cmd_window): Declare
1949         clear_detail method.
1950         * tui/tui-data.c (tui_source_window::clear_detail)
1951         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1952         methods.
1953         (tui_clear_win_detail): Simplify.
1954
1955 2019-06-25  Tom Tromey  <tom@tromey.com>
1956
1957         * tui/tui-layout.c (make_source_window, make_disasm_window)
1958         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1959         Return the new window.
1960         (show_source_disasm_command, show_data)
1961         (show_source_or_disasm_and_command): Update.
1962
1963 2019-06-25  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1966         parameter.  Return the new window.
1967         (show_source_disasm_command): Update and remove NULL check.
1968         (show_source_or_disasm_and_command): Update.
1969
1970 2019-06-25  Tom Tromey  <tom@tromey.com>
1971
1972         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1973
1974 2019-06-25  Tom Tromey  <tom@tromey.com>
1975
1976         * tui/tui-data.h (struct tui_win_info): Make constructor
1977         protected.  Make destructor virtual.  Add initializers.
1978         (tui_source_window, tui_data_window, tui_cmd_window): New
1979         classes.
1980         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1981         constructor.  Add "type" parameter.
1982         (tui_source_window, tui_data_window, tui_cmd_window): New
1983         constructors.
1984         (tui_alloc_win_info): Instantiate the appropriate subclass.
1985
1986 2019-06-25  Tom Tromey  <tom@tromey.com>
1987
1988         * tui/tui-win.c (tui_resize_all): Use delete.
1989         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1990         destructor.
1991         (tui_free_window): Don't declare.
1992         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1993         Update.
1994
1995 2019-06-25  Tom Tromey  <tom@tromey.com>
1996
1997         * tui/tui-data.h (struct tui_win_info): Add constructor.
1998         * tui/tui-data.c (tui_alloc_win_info): Use new.
1999         (tui_free_window): Use delete.
2000
2001 2019-06-22  Tom Tromey  <tom@tromey.com>
2002
2003         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2004         declare.
2005         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2006
2007 2019-06-22  Tom Tromey  <tom@tromey.com>
2008
2009         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2010         declare.
2011         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2012
2013 2019-06-22  Tom de Vries  <tdevries@suse.de>
2014
2015         * dwarf2read.c (create_addrmap_from_aranges)
2016         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2017         instead of '%zu'.
2018
2019 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2020
2021         * dwarf2read.h (dwarf2_section_info_def): Remove.
2022         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2023         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2024         std::vector<dwarf2_section_info>.
2025         (struct dwo_file) <~dwo_file>: Remove.
2026         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2027         types field.
2028         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2029         (dwarf2_read_debug_names): Likewise.
2030         (create_debug_types_hash_table): Change parameter type to
2031         array_view, adjust code accordingly.
2032         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2033         (partial_die_info::fixup): Likewise.
2034         (determine_prefix): Likewise.
2035         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2036
2037 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2038
2039         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2040         gdb_bfd_ref_ptr.
2041         <~dwo_file>: Remove call to gdb_bfd_unref.
2042         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2043         gdb_bfd_ref_ptr::get.
2044
2045 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2046
2047         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2048         type to htab_up.
2049         * dwarf2read.c (struct dwo_file): Initialize fields.
2050         <~dwo_file>: New.
2051         (free_dwo_file): Remove, move content to ~dwo_file.
2052         (struct dwo_file_deleter): Remove.
2053         (dwo_file_up>: Remove custom deleter.
2054         (free_dwo_files): Remove.
2055         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2056         dwo_files.
2057         (process_skeletonless_type_units): Call unique_ptr::get.
2058         (allocate_dwo_file_hash_table): Add deleter to created hash
2059         table.  Change return type to htab_up.
2060         (lookup_dwo_file_slot): Don't memset dwo_file, call
2061         unique_ptr::get.
2062         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2063         (create_dwo_unit_in_dwp_v2): Likewise.
2064         (open_and_init_dwo_file): Likewise.
2065         (free_dwo_file_from_slot): Remove.
2066
2067 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2068
2069         * dwarf2read.h (struct dwarf2_section_info) <readin,
2070         is_virtual>: Change type to bool.
2071         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2072         true instead of 1.
2073
2074 2019-06-19  Tom Tromey  <tom@tromey.com>
2075
2076         * tui/tui-data.h (tui_init_content_element): Don't declare.
2077
2078 2019-06-19  Tom Tromey  <tom@tromey.com>
2079
2080         * tui/tui-data.h (tui_init_win_info): Don't declare.
2081
2082 2019-06-19  Tom de Vries  <tdevries@suse.de>
2083
2084         * dwarf2read.h (abstract_to_concrete): Change type to
2085         std::unordered_map<sect_offset, std::vector<sect_offset>,
2086         gdb::hash_enum<sect_offset>>.
2087
2088 2019-06-19  Tom Tromey  <tromey@adacore.com>
2089
2090         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2091         EVAL_AVOID_SIDE_EFFECTS specially.
2092
2093 2019-06-19  Tom Tromey  <tromey@adacore.com>
2094
2095         * source-cache.c (highlighter): New global.
2096         (source_cache::get_source_lines): Create a highlighter on demand.
2097
2098 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2099
2100         * defs.h (deprecated_interactive_hook): Delete declaration.
2101         * interps.c (clear_interpreter_hooks): Remove use of
2102         deprecated_interactive_hook.
2103         * top.c (deprecated_interactive_hook): Delete definition.
2104         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2105
2106 2019-06-18  Tom de Vries  <tdevries@suse.de>
2107
2108         PR gdb/24515
2109         * dwarf2read.h (abstract_to_concrete): Change type from
2110         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2111         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2112         * dwarf2read.c (read_variable): Update.
2113         (dwarf2_fetch_die_loc_sect_off): Update.
2114
2115 2019-06-17  Tom de Vries  <tdevries@suse.de>
2116
2117         PR gdb/24617
2118         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2119         accessing parent[parent_len - 1].
2120
2121 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2122
2123         PR gdb/24364
2124         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2125         call dtrace_process_dof with NULL dof.
2126
2127 2019-06-16  Tom de Vries  <tdevries@suse.de>
2128
2129         PR gdb/24445
2130         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2131
2132 2019-06-16  Tom Tromey  <tom@tromey.com>
2133
2134         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2135         (make_all_visible): Use address of member.
2136
2137 2019-06-16  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2140         (tui_free_window, free_content, free_content_elements): Remove
2141         unnecessary cast.
2142         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2143         cast.
2144         * tui/tui-regs.c (tui_show_register_group)
2145         (tui_display_registers_from, tui_display_reg_element_at_line):
2146         Remove unnecessary cast.
2147
2148 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2149
2150         * linux-nat.c (normal_mask): Delete.
2151         (_initialize_linux_nat): Don't initialise normal_mask.
2152
2153 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2154
2155         PR gdb/24445
2156         * dwarf-index-write.h (write_psymtabs_to_index): Add
2157         dwz_basename parameter.
2158         * dwarf-index-write.c (write_gdbindex): Move file writing to
2159         write_gdbindex_1.  Change return type void.
2160         (assert_file_size): Move up, remove filename parameter.
2161         (write_gdbindex_1): New function.
2162         (write_debug_names): Change return type to void, call
2163         assert_file_size.
2164         (struct index_wip_file): New struct.
2165         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2166         file logic to index_wip_file.  Write index for dwz file if
2167         needed.
2168         (save_gdb_index_command): Pass basename of dwz file, if present.
2169         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2170         build-id of dwz file, if present.
2171         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2172         (dwarf2_get_dwz_file): Likewise.
2173         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2174         (dwarf2_get_dwz_file): Likewise.
2175
2176 2019-06-16  Tom Tromey  <tom@tromey.com>
2177
2178         * coffread.c (process_coff_symbol): Use xstrdup.
2179         * value.c (create_internalvar): Use xstrdup.
2180
2181 2019-06-16  Tom Tromey  <tom@tromey.com>
2182
2183         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2184         * breakpoint.c (stopin_command, stopat_command)
2185         (until_break_command, decode_location_default): Remove unnecessary
2186         cast.
2187         * utils.c (subset_compare): Remove unnecessary cast.
2188         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2189         cast.
2190         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2191         cast.
2192         * infcmd.c (path_command): Remove unnecessary cast.
2193         * coffread.c (decode_type): Remove unnecessary cast.
2194         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2195         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2196         * tui/tui-stack.c (tui_show_locator_content)
2197         (tui_show_frame_info): Remove unnecessary cast.
2198         * tui/tui-win.c (tui_scroll_forward_command)
2199         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2200         (parse_scrolling_args): Remove unnecessary cast.
2201         * tui/tui-data.c (init_win_info, tui_del_window)
2202         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2203         (free_content_elements): Remove unnecessary cast.
2204         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2205         unnecessary cast.
2206         * tui/tui-source.c (tui_set_source_content)
2207         (tui_vertical_source_scroll): Remove unnecessary cast.
2208         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2209         cast.
2210         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2211         * tui/tui-regs.c (tui_display_registers_from)
2212         (tui_display_register): Remove unnecessary cast.
2213         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2214         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2215         (make_visible): Remove unnecessary cast.
2216         * tui/tui-winsource.c (tui_erase_source_content)
2217         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2218         unnecessary cast.
2219         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2220         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2221         * stabsread.c (read_type, read_array_type, read_range_type):
2222         Remove unnecessary cast.
2223         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2224         (parse_symbol, parse_type, upgrade_type, parse_external)
2225         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2226         unnecessary cast.
2227         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2228
2229 2019-06-16  Tom Tromey  <tom@tromey.com>
2230
2231         * tui/tui-data.c (tui_alloc_generic_win_info)
2232         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2233         checks.
2234
2235 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2236             Andrew Burgess  <andrew.burgess@embecosm.com>
2237
2238         * f-typeprint.c (f_print_type): Don't return early for not
2239         associated or not allocated types.
2240         (f_type_print_varspec_suffix): Add print_rank parameter and print
2241         ranks of array types in case they dangling.
2242         (f_type_print_base): Add print_rank parameter.
2243
2244 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2245
2246         * NEWS: Mention new MI commands.
2247         * break-catch-throw.c (enum exception_event_kind): Move to
2248         breakpoint.h.
2249         (print_mention_exception_catchpoint): Output text as a single
2250         message.
2251         (catch_exception_command_1): Rename to...
2252         (catch_exception_event): ...this, make non-static, update header
2253         command, and change some parameter types.
2254         (catch_catch_command): Update for changes to
2255         catch_exception_command_1.
2256         (catch_throw_command): Likewise.
2257         (catch_rethrow_command): Likewise.
2258         * breakpoint.c (enum exception_event_kind): Delete.
2259         * breakpoint.h (enum exception_event_kind): Moved here from
2260         break-catch-throw.c.
2261         (catch_exception_event): Declare.
2262         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2263         (mi_cmd_catch_throw): New function.
2264         (mi_cmd_catch_rethrow): New function.
2265         (mi_cmd_catch_catch): New function.
2266         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2267         'catch-catch' entries.
2268         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2269         (mi_cmd_catch_rethrow): Declare.
2270         (mi_cmd_catch_catch): Declare.
2271
2272 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2273
2274         * annotate.c (annotate_source_line): Change return type to void,
2275         update implementation to match.
2276         * annotate.h (annotate_source_line): Change return type to void,
2277         update header comment.
2278         * stack.c (print_frame_info): Don't change what frame information
2279         is printed based on whether annotations are on or not.
2280
2281 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2282
2283         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2284         (annotate_source): Make static.
2285         (annotate_source_line): Moved from source.c and renamed from
2286         identify_source_line.  Update the return type.
2287         * annotate.h (annotate_source): Delete declaration.
2288         (annotate_source_line): Declaration moved from source.h, and
2289         renamed from identify_source_line.  Return type updated.
2290         * source.c (identify_source_line): Moved to annotate.c and renamed
2291         to annotate_source_line.
2292         (info_line_command): Remove check of annotation_level.
2293         * source.h (identify_source_line): Move declaration to annotate.h
2294         and rename to annotate_source_line.
2295         * stack.c: Add 'annotate.h' include.
2296         (print_frame_info): Remove check of annotation_level before
2297         calling annotate_source_line.
2298
2299 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2300
2301         * source-cache.c (source_cache::get_plain_source_lines): Use
2302         open_source_file_with_line_charpos instead of just
2303         open_source_file, remove call to find_source_lines.
2304         (source_cache::get_source_lines): Likewise.
2305         * source.c (find_source_lines): Make static.
2306         (get_filename_and_charpos): Renamed into...
2307         (open_source_file_with_line_charpos): ..this along with changes to
2308         return a scoped_fd, and some other minor clean ups.
2309         (identify_source_line): Use open_source_file_with_line_charpos.
2310         (search_command_helper): Use open_source_file_with_line_charpos
2311         instead of just open_source_file, remove call to
2312         find_source_lines.
2313         * source.h (open_source_file_with_line_charpos): Declare new
2314         function.
2315         (find_source_lines): Delete declaration.
2316
2317 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2318
2319         * source.c (get_filename_and_charpos): Remove fullname
2320         parameter.
2321         (identify_source_line): Update call to get_filename_and_charpos.
2322
2323 2019-06-14  Tom Tromey  <tromey@adacore.com>
2324
2325         PR gdb/24502:
2326         * ui-style.h (skip_ansi_escape): Update comment.
2327         * ui-file.h (class no_terminal_escape_file): New class.
2328         * ui-file.c (no_terminal_escape_file::write)
2329         (no_terminal_escape_file::puts): New methods.
2330         * cli/cli-logging.c (handle_redirections): Use
2331         no_terminal_escape_file.
2332
2333 2019-06-14  Tom Tromey  <tromey@adacore.com>
2334
2335         * NEWS: Move convenience variable news above Python news.
2336
2337 2019-06-14  Tom Tromey  <tom@tromey.com>
2338
2339         * gnulib: Move directory to top-level.
2340         * configure.ac: Don't configure gnulib.
2341         * configure: Rebuild.
2342         * common/common-defs.h: Use new path to gnulib.
2343         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2344         (GNULIB_H): Remove.
2345         (INCGNU): Look in new gnulib location.
2346         (HFILES_NO_SRCDIR): Remove gnulib files.
2347         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2348         (generated_files): Remove GNULIB_H.
2349         ($(LIBGNU), all-lib): Remove targets.
2350         (distclean): Don't mention GNULIB_BUILDDIR.
2351         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2352
2353 2019-06-14  Tom Tromey  <tromey@adacore.com>
2354
2355         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2356         Warn if symbol file does not provide any symbols.
2357
2358 2019-06-14  Tom Tromey  <tromey@adacore.com>
2359
2360         * source.c (find_and_open_source): Respect basenames_may_differ.
2361
2362 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2363
2364         * annotate.c (annotate_breakpoints_invalid): Make use of
2365         scoped_restore_terminal_state.
2366         (annotate_frames_invalid): Likewise.
2367
2368 2019-06-14  Tom Tromey  <tromey@adacore.com>
2369
2370         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2371         allow assignment to an internalvar.
2372
2373 2019-06-14  Tom Tromey  <tromey@adacore.com>
2374
2375         * ada-lex.l: Allow "_" in attribute names.
2376
2377 2019-06-14  Tom Tromey  <tromey@adacore.com>
2378
2379         PR gdb/24653:
2380         * regcache.c (registers_changed): Don't call alloca.
2381         * top.c (execute_command): Don't call alloca.
2382
2383 2019-06-13  Pedro Alves  <palves@redhat.com>
2384
2385         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2386         'expression'.  When parsing an expression, error out if there's
2387         junk after "unlimited".
2388         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2389         (do_set_command): Adjust calls to is_unlimited_literal.
2390
2391 2019-06-13  Pedro Alves  <palves@redhat.com>
2392
2393         * compile/compile.c (make_compile_options_def_group): Add braces
2394         around array_view initializer.
2395         * thread.c (make_thread_apply_all_options_def_group)
2396         (make_thread_apply_all_options_def_group): Likewise.
2397
2398 2019-06-13  Pedro Alves  <palves@redhat.com>
2399
2400         * NEWS (New commands): Mention "maint test-options
2401         require-delimiter", "maint test-options unknown-is-error", "maint
2402         test-options unknown-is-operand" and "maint show
2403         test-options-completion-result".
2404         (New command options, command completion): New section.
2405         (Completion improvements): New section.
2406         Mention that you can abbreviate "unlimited".
2407
2408 2019-06-13  Pedro Alves  <palves@redhat.com>
2409
2410         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2411         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2412         * unittests/cli-utils-selftests.c (test_parse_flags)
2413         (test_parse_flags_qcs): Delete.
2414         (test_cli_utils): Don't call deleted functions.
2415
2416 2019-06-13  Pedro Alves  <palves@redhat.com>
2417
2418         * thread.c: Include "cli/cli-option.h".
2419         (tp_array_compar_ascending): Global.
2420         (tp_array_compar): Delete function.
2421         (tp_array_compar_ascending, tp_array_compar_descending): New
2422         functions.
2423         (ascending_option_def, qcs_flag_option_def)
2424         (thr_qcs_flags_option_defs)
2425         (make_thread_apply_all_options_def_group)
2426         (make_thread_apply_options_def_group): New.
2427         (thread_apply_all_command): Use gdb::option::process_options.
2428         (thread_apply_command_completer)
2429         (thread_apply_all_command_completer): New.
2430         (thread_apply_command): Use gdb::option::process_options.
2431         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2432         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2433         to generate help text of "thread apply".  Adjust "taas"'s help.
2434         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2435         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2436
2437 2019-06-13  Pedro Alves  <palves@redhat.com>
2438
2439         * thread.c (thread_apply_command): Check for invalid TID with
2440         isdigit instead of !isalpha.
2441
2442 2019-06-13  Pedro Alves  <palves@redhat.com>
2443
2444         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2445         (validate_flags_qcs): New.
2446         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2447         (validate_flags_qcs): Declare.
2448         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2449         (make_frame_apply_options_def_group): New.
2450         (frame_apply_command_count): Process options with
2451         gdb::option::process_options.
2452         (frame_apply_completer): New.
2453         (frame_apply_level_completer, frame_apply_all_completer)
2454         (frame_apply_completer): New.
2455         (_initialize_stack): Update help of "frame apply", "frame apply
2456         level", "frame apply all" and "faas" to mention supported options
2457         and install command completers.
2458         * stack.h (frame_apply_all_completer): Declare.
2459         * thread.c: Include "stack.h".
2460         (tfaas_command): Add "--".
2461         (_initialize_thread): Update help "tfaas" to mention supported
2462         options and install command completer.
2463
2464 2019-06-13  Pedro Alves  <palves@redhat.com>
2465
2466         * completer.c (complete_nested_command_line): New.
2467         (gdb_completion_word_break_characters_throw): Add assertion.
2468         * completer.h (complete_nested_command_line): Declare.
2469
2470 2019-06-13  Pedro Alves  <palves@redhat.com>
2471
2472         * stack.c (parse_backtrace_qualifiers): New.
2473         (backtrace_command): Use it.
2474         (backtrace_command_completer): Complete on qualifiers.
2475
2476 2019-06-13  Pedro Alves  <palves@redhat.com>
2477
2478         * frame.c: Include "cli/cli-option.h.
2479         (user_set_backtrace_options): New.
2480         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2481         Delete.
2482         (get_prev_frame): Adjust.
2483         (boolean_option_def, uinteger_option_def)
2484         (set_backtrace_option_defs): New.
2485         (_initialize_frame): Adjust and use
2486         gdb::option::add_setshow_cmds_for_options to install "set
2487         backtrace past-main" and "set backtrace past-entry".
2488         * frame.h: Include "cli/cli-option.h".
2489         (struct frame_print_options): Forward declare.
2490         (print_frame_arguments_all, print_frame_arguments_scalars)
2491         (print_frame_arguments_none): Declare.
2492         (print_entry_values): Delete declaration.
2493         (struct frame_print_options, user_frame_print_options): New.
2494         (struct set_backtrace_options): New.
2495         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2496         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2497         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2498         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2499         (list_args_or_locals): Add frame_print_options parameter.
2500         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2501         * python/py-framefilter.c (enumerate_args): Pass down
2502         USER_FRAME_PRINT_OPTIONS.
2503         * stack.c: Include "cli/cli-option.h".
2504         (print_frame_arguments_all, print_frame_arguments_scalars)
2505         (print_frame_arguments_none): Declare.
2506         (print_raw_frame_arguments, print_entry_values): Delete.
2507         (user_frame_print_options): New.
2508         (boolean_option_def, enum_option_def, frame_print_option_defs):
2509         New.
2510         (struct backtrace_cmd_options): New.
2511         (bt_flag_option_def): New.
2512         (backtrace_command_option_defs): New.
2513         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2514         (print_frame_arg, read_frame_arg, print_frame_args)
2515         (print_frame_info, print_frame): Add frame_print_options parameter
2516         and use it.
2517         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2518         (backtrace_command_1): Add frame_print_options and
2519         backtrace_cmd_options parameters and use them.
2520         (make_backtrace_options_def_group): New.
2521         (backtrace_command): Process command options with
2522         gdb::option::process_options.
2523         (backtrace_command_completer): New.
2524         (_initialize_stack): Extend "backtrace"'s help to mention
2525         supported options.  Install completer for "backtrace".
2526         Install some settings commands with add_setshow_cmds_for_options.
2527
2528 2019-06-13  Pedro Alves  <palves@redhat.com>
2529
2530         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2531         and that "set/show print raw frame-arguments" are now deprecated.
2532
2533         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2534         command.
2535         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2536         * stack.c (_initialize_stack): Install "set/show print
2537         raw-frame-arguments", and deprecate "set/show print raw
2538         frame-arguments".
2539         * valprint.c (_initialize_valprint): Deprecate "set/show print
2540         raw".
2541
2542 2019-06-13  Pedro Alves  <palves@redhat.com>
2543
2544         * compile/compile.c (struct compile_options): New.
2545         (compile_flag_option_def, compile_command_option_defs)
2546         (make_compile_options_def_group): New.
2547         (compile_file_command): Handle options with
2548         gdb::option::process_options.
2549         (compile_file_command_completer): New function.
2550         (compile_code_command): Handle options with
2551         gdb::option::process_options.
2552         (compile_code_command_completer): New function.
2553         (_initialize_compiler): Install completers for "compile code" and
2554         "compile file".  Mention available options in "compile code" and
2555         "compile code"'s help.
2556         * completer.c (advance_to_completion_word): New, factored out from
2557         ...
2558         (advance_to_expression_complete_word_point): ... this.
2559         (advance_to_filename_complete_word_point): New.
2560         * completer.h (advance_to_filename_complete_word_point): New
2561         declaration.
2562
2563 2019-06-13  Pedro Alves  <palves@redhat.com>
2564
2565         * compile/compile.c: Include "cli/cli-option.h".
2566         (compile_print_value): Scope data pointer is now a
2567         value_print_options pointer; adjust.
2568         (compile_print_command): Process options.  Scope data pointer is
2569         now a value_print_options pointer; adjust.
2570         (_initialize_compile): Update "compile print"'s help to include
2571         supported options.  Install a completer for "compile print".
2572         * cp-valprint.c (show_vtblprint, show_objectprint)
2573         (show_static_field_print): Delete.
2574         (_initialize_cp_valprint): Don't install "set print
2575         static-members", "set print vtbl", "set print object" here.
2576         * printcmd.c: Include "cli/cli-option.h" and
2577         "common/gdb_optional.h".
2578         (print_command_parse_format): Rework to fill in a
2579         value_print_options instead of a format_data.
2580         (print_value): Change parameter type from format_data pointer to
2581         value_print_options reference.  Adjust.
2582         (print_command_1): Process options.  Adjust to pass down a
2583         value_print_options.
2584         (print_command_completer): New.
2585         (_initialize_printcmd): Install print_command_completer as
2586         handle_brkchars completer for the "print" command.  Update
2587         "print"'s help to include supported options.
2588         * valprint.c: Include "cli/cli-option.h".
2589         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2590         here from cp-valprint.c.
2591         (boolean_option_def, uinteger_option_def)
2592         (value_print_option_defs, make_value_print_options_def_group):
2593         New.  Use gdb::option::add_setshow_cmds_for_options to install
2594         "set print elements", "set print null-stop", "set print repeats",
2595         "set print pretty", "set print union", "set print array", "set
2596         print address", "set print symbol", "set print array-indexes".
2597         * valprint.h: Include <string> and "cli/cli-option.h".
2598         (make_value_print_options_def_group): Declare.
2599         (print_value): Change parameter type from format_data pointer to
2600         value_print_options reference.
2601         (print_command_completer): Declare.
2602
2603 2019-06-13  Pedro Alves  <palves@redhat.com>
2604
2605         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2606         (COMMON_SFILES): Add maint-test-settings.c.
2607         * cli/cli-decode.c (boolean_enums): New global, factored out from
2608         ...
2609         (add_setshow_boolean_cmd): ... here.
2610         * cli/cli-decode.h (boolean_enums): Declare.
2611         * cli/cli-option.c: New file.
2612         * cli/cli-option.h: New file.
2613         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2614         factored out from ...
2615         (parse_cli_boolean_value(const char *)): ... this.
2616         (is_unlimited_literal): Change parameter type to pointer to
2617         pointer.  Adjust and advance ARG pointer.
2618         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2619         (parse_cli_var_enum): New, factored out from ...
2620         (do_set_command): ... this.  Adjust.
2621         * cli/cli-setshow.h (parse_cli_boolean_value)
2622         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2623         (parse_cli_var_enum): Declare.
2624         * cli/cli-utils.c: Include "cli/cli-option.h".
2625         (get_ulongest): New.
2626         * cli/cli-utils.h (get_ulongest): Declare.
2627         (check_for_argument): New overloads.
2628         * maint-test-options.c: New file.
2629
2630 2019-06-13  Pedro Alves  <palves@redhat.com>
2631
2632         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2633         parse a range if "-" is at the end of the string.
2634
2635 2019-06-13  Pedro Alves  <palves@redhat.com>
2636
2637         * cli/cli-setshow.c (parse_auto_binary_operation)
2638         (parse_cli_boolean_value): Don't allow "o".
2639
2640 2019-06-13  Pedro Alves  <palves@redhat.com>
2641
2642         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2643         * NEWS: Mention maint test-settings KIND.
2644         * maint-test-settings.c: New file.
2645
2646 2019-06-13  Pedro Alves  <palves@redhat.com>
2647
2648         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2649         completer.
2650         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2651         "set" completers.
2652
2653 2019-06-13  Pedro Alves  <palves@redhat.com>
2654
2655         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2656         after item.
2657
2658 2019-06-13  Pedro Alves  <palves@redhat.com>
2659
2660         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2661
2662 2019-06-13  Pedro Alves <palves@redhat.com>
2663
2664         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2665         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2666         call.
2667         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2668         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2669         calls.
2670         (check_for_argument): Skip spaces after argument.
2671
2672 2019-06-13  Pedro Alves  <palves@redhat.com>
2673
2674         * thread.c (thread_apply_command): Adjust TID parsing.
2675         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2676         detected before end of string.
2677         (tid_is_in_list): Error out if LIST is invalid.
2678
2679 2019-06-13  Pedro Alves  <palves@redhat.com>
2680
2681         * completer.c (complete_line_internal_1): Rewind completion word
2682         point.
2683         (completion_tracker::advance_custom_word_point_by): Change
2684         parameter type to int.
2685         * completer.h (completion_tracker::advance_custom_word_point_by):
2686         Likewise.
2687
2688 2019-06-13  Pedro Alves  <palves@redhat.com>
2689
2690         * completer.c (advance_to_completion_word): Handle delimiters.
2691
2692 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2693
2694         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2695
2696 2019-06-11  Tom Tromey  <tom@tromey.com>
2697
2698         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2699         (xmalloc_failed): Move to alloc.c.
2700         * alloc.c: New file.
2701         * Makefile.in (COMMON_SFILES): Add alloc.c.
2702
2703 2019-06-11  Tom Tromey  <tom@tromey.com>
2704
2705         * nat/linux-waitpid.c: Don't include server.h.
2706         (linux_debug): Remove.
2707         (my_waitpid): Update.
2708
2709 2019-06-11  Tom Tromey  <tromey@adacore.com>
2710
2711         * infcall.c (_initialize_infcall): Remove trailing newline from
2712         help.
2713         * user-regs.c (_initialize_user_regs): Remove trailing newline
2714         from help.
2715         * typeprint.c (_initialize_typeprint): Remove trailing newline
2716         from help.
2717         * reverse.c (_initialize_reverse): Remove trailing newlines from
2718         help.
2719         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2720         from help.
2721         * language.c (add_set_language_command): Remove trailing newline
2722         from help.
2723         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2724         help.
2725         * disasm.c (_initialize_disasm): Remove trailing newline from
2726         help.
2727         * top.c (init_main): Remove trailing newline from help.
2728         * interps.c (_initialize_interpreter): Remove trailing newline
2729         from help.
2730         * btrace.c (_initialize_btrace): Remove trailing newlines from
2731         help.
2732         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2733         from help.
2734         * python/python.c (_initialize_python): Remove trailing newline
2735         from help.
2736         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2737         help.
2738         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2739         from help.  Reformat some text.
2740         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2741         from help.
2742         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2743         newline from help.
2744
2745 2019-06-11  Tom Tromey  <tromey@adacore.com>
2746
2747         * darwin-nat.c (darwin_decode_exception_message)
2748         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2749
2750 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2751
2752         * valops.c (value_slice): Check for not allocated or not
2753         associated values.
2754
2755 2019-06-10  Tom de Vries  <tdevries@suse.de>
2756
2757         PR gdb/24618
2758         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2759         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2760         invalid.
2761
2762 2019-06-10  Tom de Vries  <tdevries@suse.de>
2763
2764         PR gdb/24611
2765         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2766         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2767
2768 2019-06-10  Tom de Vries  <tdevries@suse.de>
2769
2770         PR symtab/24545
2771         * symtab.c (struct demangled_name_entry): Add language field.
2772         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2773         static minimal symbol".  Set and use language field.
2774
2775 2019-06-10  Tom Tromey  <tromey@adacore.com>
2776
2777         * ada-lang.c (_initialize_ada_language): Update help text.
2778
2779 2019-06-10  Tom Tromey  <tromey@adacore.com>
2780
2781         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2782         with a newline.
2783         * guile/guile.c (handle_boot_error): Don't end warning with a
2784         newline.
2785         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2786         warning with a newline.
2787         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2788         newline.
2789         (s12z_frame_cache): Likewise.
2790         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2791         a newline.
2792         * solib-svr4.c (disable_probes_interface): Don't end warning with
2793         a newline.
2794         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2795         newline.
2796         * python/python.c (do_finish_initialization): Don't end warning
2797         with a newline.
2798
2799 2019-06-10  Tom Tromey  <tom@tromey.com>
2800
2801         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2802         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2803         gdbpy_enter.
2804
2805 2019-06-10  Tom Tromey  <tromey@adacore.com>
2806
2807         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2808         data.
2809         (elf_new_init): Don't call stabsread_new_init.
2810         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2811         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2812         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2813
2814 2019-06-10  Tom de Vries  <tdevries@suse.de>
2815
2816         PR symtab/16264
2817         PR symtab/24517
2818         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2819
2820 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2821
2822         * source.c (find_and_open_source): Also rewrite relative file
2823         names.
2824
2825 2019-04-26  Amos Bird  <amosbird@gmail.com>
2826
2827         * annotate.c (annotate_thread_exited): Add "thread-exited"
2828         annotation.
2829
2830 2019-06-06  Tom Tromey  <tromey@adacore.com>
2831
2832         * maint.h (class scoped_command_stats): Use
2833         DISABLE_COPY_AND_ASSIGN.
2834         <print_time>: New method.
2835         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2836         print_time.
2837         (scoped_command_stats::print_time): New method.
2838
2839 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2840
2841         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2842         instructions of lengths 6 or 8 bytes.
2843
2844 2019-06-04  Pedro Alves  <palves@redhat.com>
2845
2846         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2847
2848         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2849         * breakpoint.c (condition_completer): Likewise.
2850         * cli/cli-dump.c (scan_expression): Likewise.
2851         * common/filestuff.c (mkdir_recursive): Likewise.
2852         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2853         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2854         (gdb_abspath): Likewise.
2855         * compile/compile-cplus-types.c
2856         (compile_cplus_instance::decl_name): Likewise.
2857         * completer.c (complete_explicit_location):
2858         (signal_completer, reg_or_group_completer_1): Likewise.
2859         * cp-support.c (cp_remove_params_if_any): Likewise.
2860         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2861         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2862         * infcmd.c (strip_bg_char): Likewise.
2863         * linespec.c (copy_token_string): Likewise.
2864         * mi/mi-main.c (output_cores): Likewise.
2865         * psymtab.c (psymtab_search_name):
2866         * symfile.c (test_set_ext_lang_command): Likewise.
2867         * target.c (target_fileio_read_stralloc): Likewise.
2868         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2869         * value.c (complete_internalvar): Likewise.
2870
2871 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2872
2873         Add objfile property to gdb.Type.
2874         * NEWS: Mention Python API addition.
2875         * python/py-type.c (typy_get_objfile): New method.
2876
2877 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2878
2879         * NEWS: Mention the new set|show style [title|highlight].
2880         Mention changes to "show style", "help" and "apropos".
2881
2882 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2883
2884         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2885         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2886         instead of print_help_for_command.
2887         (print_doc_of_command): New function.
2888         (help_list): Add 'apropos -v word' suggestion.
2889         (print_help_for_command): Style the command name using title style.
2890         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2891         (_initialize_cli_cmds): Describe -v in apropos_command help.
2892
2893 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2894
2895         * cli/cli-style.h (cli_style_option): Add name in constructor,
2896         add m_name class member, add constructor with intensity,
2897         add name class function.
2898         (cli_style_option::add_setshow_commands): Remove name argument.
2899         (highlight_style, title_style): New styles.
2900         * cli/cli-style.c (do_show): New function that shows a style
2901         characteristic styling the style name with itself.
2902         (set_style_name): New function.
2903         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2904         Update all callers according to the changes in cli/cli-style.h.
2905         * utils.h (fputs_highlighted): New function.
2906         * utils.c (fputs_highlighted): Likewise.
2907
2908 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2909
2910         * NEWS: Mention new pipe command and new convenience variables.
2911
2912 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2913
2914         * cli/cli-cmds.c (pipe_command): New function.
2915         (_initialize_cli_cmds): Call add_com for pipe_command.
2916         Define | as an alias for pipe.
2917         (exit_status_set_internal_vars): New function.
2918         (shell_escape): Call exit_status_set_internal_vars.
2919         cli/cli-decode.c (find_command_name_length): Recognize | as
2920         a single character command.
2921
2922 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2923
2924         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2925         top.c (execute_command_to_ui_file): New function, mostly a copy
2926         of execute_command_to_string.
2927         (execute_command_to_string): Implement by calling
2928         execute_command_to_ui_file.
2929
2930 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2931
2932         * top.h (saved_command_line): Remove declaration.
2933         * top.c (previous_saved_command_line, previous_repeat_arguments):
2934         New variables.
2935         (saved_command_line): Make static, define together with other
2936         'repeat variables'.
2937         (dont_repeat): Clear repeat_arguments.
2938         (repeat_previous, get_saved_command_line, save_command_line):
2939         New functions.
2940         (gdb_init): Initialize saved_command_line
2941         and previous_saved_command_line.
2942         * main.c (captured_main_1): Remove saved_command_line initialization.
2943         * event-top.c (handle_line_of_input): Update to use
2944         the new 'repeat' related functions instead of direct access to
2945         saved_command_line.
2946         * command.h (repeat_previous, get_saved_command_line,
2947         save_command_line): New declarations.
2948         (dont_repeat): Add comment.
2949
2950 2019-05-30  Tom Tromey  <tromey@adacore.com>
2951
2952         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2953         Fix comment.
2954         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2955
2956 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2957
2958         PR cli/24587
2959         * completer.c (complete): Initialize variable word.
2960
2961 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2962
2963         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2964         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2965         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2966         'body' is NULL to the outter 'if', protecting the '!is_define'
2967         situation as well.
2968
2969 2019-05-29  Tom Tromey  <tromey@adacore.com>
2970
2971         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2972         (dwarf_unknown): New function.
2973         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2974         (dwarf_type_encoding_name): Use dwarf_unknown.
2975
2976 2019-05-29  Tom Tromey  <tromey@adacore.com>
2977
2978         PR c++/20020:
2979         * cp-valprint.c (cp_print_value_fields): Call
2980         cp_print_static_field inside "try".
2981
2982 2019-05-29  Tom Tromey  <tromey@adacore.com>
2983
2984         * inflow.c (struct terminal_info): Add default operator=.
2985         * configure: Rebuild.
2986         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2987         -Wdeprecated-copy-dtor, -Wredundant-move.
2988
2989 2019-05-29  Tom Tromey  <tromey@adacore.com>
2990
2991         * NEWS: Add entry.
2992         * infcmd.c (print_return_value_1): Handle finish_print
2993         option.
2994         (show_print_finish): New function.
2995         (_initialize_infcmd): Add "set/show print finish" commands.
2996         * valprint.c (user_print_options): Initialize new member.
2997         * valprint.h (struct value_print_options) <finish_print>: New
2998         member.
2999
3000 2019-05-28  Tom Tromey  <tromey@adacore.com>
3001
3002         * ada-lang.c (ada_remove_Xbn_suffix)
3003         (find_old_style_renaming_symbol)
3004         (parse_old_style_renaming): Remove.
3005         (ada_find_renaming_symbol): Don't call
3006         find_old_style_renaming_symbol.
3007         (ada_is_renaming_symbol): Rename from
3008         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3009         bool.  Now static.
3010         (ada_read_var_value): Update and simplify.
3011         * ada-exp.y (write_var_or_type): Remove old code.
3012
3013 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3014
3015         * event-top.c: Remove include comment.
3016         * inflow.c (class scoped_ignore_sigttou): Move from here...
3017         * inflow.h (class scoped_ignore_sigttou): ...to here.
3018         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3019         * top.c:  Remove include comment.
3020
3021 2019-05-27  Tom Tromey  <tom@tromey.com>
3022
3023         * NEWS: Fix typo.
3024
3025 2019-05-22  Tom Tromey  <tromey@adacore.com>
3026
3027         * target.c (target_follow_exec): Constify parameter.
3028         * target-delegates.c: Rebuild.
3029         * remote.c (remote_target::follow_exec): Constify parameter.
3030         * infrun.c (follow_exec): Constify parameter.
3031         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3032         (target_follow_exec): Likewise.
3033
3034 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3035
3036         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3037         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3038
3039 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3040
3041         * NEWS: Add debugredirect and testsuite sections.
3042
3043 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3044
3045         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3046         target descriptions using exclusively floating point register name
3047         aliases.
3048
3049 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3050
3051         PR gdb/18644:
3052         * f-lang.c (build_fortran_types): Handle the case where
3053         gdbarch_floatformat_for_type returns a nullptr.
3054
3055 2019-05-21  Tom de Vries  <tdevries@suse.de>
3056
3057         PR cli/24587
3058         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3059
3060 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3061
3062         PR gdb/18644:
3063         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3064         16-byte floats.
3065         * i386-tdep.c (i386_floatformat_for_type): Use
3066         floatformats_ia64_quad for the 16-byte floating point component
3067         within a fortran 32-byte complex number.
3068
3069 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3070
3071         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3072         delete default constructor.
3073         (find_partial_die): Update to return const struct.
3074         (partial_die_parent_scope): Move variable declaration into scope
3075         of its use and change its type to auto.
3076         (guess_partial_die_structure_name): Likewise.
3077         (partial_die_info::fixup): Likewise.
3078
3079 2019-05-17  Tom Tromey  <tromey@adacore.com>
3080
3081         * source.c (find_and_open_source): Remove cast.
3082
3083 2019-05-17  Tom Tromey  <tromey@adacore.com>
3084
3085         * annotate.c (annotate_source): Make "filename" const.
3086         * annotate.h (annotate_source): Use const.
3087
3088 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3089
3090         * disasm.c (set_disassembler_options): Send errors to stderr.
3091
3092 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3093
3094         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3095         (cli_interp_base::set_logging): Check debug_redirect.
3096         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3097         * cli/cli-logging.c (debug_redirect): Add static variable.
3098         (pop_output_files): Add default param.
3099         (handle_redirections): Print debug setting.
3100         (show_logging_command): Likewise.
3101         (_initialize_cli_logging): Add debugredirect command.
3102         * interps.c (current_interp_set_logging): Add debug_redirect
3103         parameter.
3104         * interps.h (set_logging): Add debug_redirect parameter.
3105         (current_interp_set_logging): Likewise.
3106         * mi/mi-common.h: Likewise.
3107         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3108
3109 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3110             Tom Tromey  <tromey@adacore.com>
3111
3112         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3113         directly.
3114         * cli/cli-interp.h (make_logging_output): Remove declaration.
3115         * cli/cli-logging.c (make_logging_output): Remove function.
3116         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3117         directly.
3118         * ui-file.c (tee_file::tee_file): Remove bools.
3119         (tee_file::~tee_file): Remove deletes.
3120         * ui-file.h (tee_file): Remove bools.
3121
3122 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3123
3124         * mi/mi-cmds.h (mi_cmd_complete): New function.
3125         * mi/mi-main.c (mi_cmd_complete): Likewise.
3126         * mi/mi-cmds.c: Define new MI command -complete.
3127         * NEWS: Mention new -complete command.
3128
3129 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3130
3131         * completer.h (complete): New function.
3132         * completer.c (complete): Likewise.
3133         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3134         function defined in completer.h.
3135
3136 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3137
3138         * MAINTAINERS (Write After Approval): Add myself.
3139
3140 2019-05-17  Tom de Vries  <tdevries@suse.de>
3141
3142         PR gdb/24094
3143         * dwarf2read.c (struct cu_partial_die_info): New struct.
3144         (find_partial_die): Return cu_partial_die_info.
3145         (partial_die_parent_scope, guess_partial_die_structure_name)
3146         (partial_die_info::fixup): Handle new return type of find_partial_die.
3147
3148 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3149
3150         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3151         "std::string", simplifying the algorithm.
3152
3153 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3154
3155         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3156         (stap_static_probe_ops::get_probes): Likewise.
3157
3158 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3159
3160         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3161         '-')" and "else if".
3162         (stap_parse_single_operand): Join checks for
3163         "gdbarch_stap_parse_special_token_p" and
3164         "gdbarch_stap_parse_special_token" in the same "if" statement.
3165         Invert check when verifying for operation on register
3166         displacement.
3167
3168 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3169
3170         * stap-probe.c (stap_get_opcode): Update comment.
3171         (stap_get_expected_argument_type): Likewise.
3172         (handle_stap_probe): Likewise.
3173
3174 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3175
3176         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3177         return type to 'bool'.  Adjust comment.  Use 'bool' when
3178         appropriate.
3179         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3180         * stap-probe.c (stap_parse_argument_1): Likewise.
3181         (stap_is_operator): Likewise.
3182         (stap_is_generic_prefix): Likewise.
3183         (stap_is_register_prefix): Likewise.
3184         (stap_is_register_indirection_prefix): Likewise.
3185         (stap_is_integer_prefix): Likewise.
3186         (stap_generic_check_suffix): Likewise.
3187         (stap_check_integer_suffix): Likewise.
3188         (stap_check_register_suffix): Likewise.
3189         (stap_check_register_indirection_suffix): Likewise.
3190         (stap_parse_register_operand): Likewise.
3191         (stap_parse_single_operand): Likewise.
3192         (stap_parse_argument_1): Likewise.
3193         (stap_probe::get_argument_count): Likewise.
3194         (stap_is_operator): Likewise.
3195
3196 2019-05-16  Tom Tromey  <tromey@adacore.com>
3197
3198         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3199         keyword to foreach.
3200
3201 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3202
3203         * linux-thread-db.c (try_thread_db_load_1): Change return type
3204         to bool.
3205         (try_thread_db_load): Likewise.
3206         (try_thread_db_load_from_pdir_1): Likewise.
3207         (try_thread_db_load_from_pdir): Likewise.
3208         (try_thread_db_load_from_sdir): Likewise.
3209         (try_thread_db_load_from_dir): Likewise.
3210         (thread_db_load_search): Likewise.
3211         (has_libpthread): Likewise.
3212         (thread_db_load): Likewise.
3213
3214 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3215
3216         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3217         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3218         NULL, and complain/return if that's the case.
3219
3220 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3221
3222         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3223         (advance, posn, abstract_read_memory): New functions.
3224         [struct mem_read_abstraction]: New struct.
3225         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3226
3227 2019-05-14  Tom Tromey  <tromey@adacore.com>
3228
3229         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3230         value is not lval_memory.
3231
3232 2019-05-14  Tom Tromey  <tromey@adacore.com>
3233
3234         * solib.c (info_sharedlibrary_command): Style the file name.
3235
3236 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3237
3238         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3239         (aarch64_vnv_type): Likewise.
3240         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3241         * common/tdesc.c: Likewise.
3242         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3243         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3244         * features/aarch64-fpu.xml: Add ieee half view.
3245         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3246         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3247         * gdbtypes.h (struct builtin_type): Likewise.
3248         (struct objfile_type): Likewise.
3249
3250 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3251
3252         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3253         typo.
3254         * location.h (string_to_event_location): Likewise.
3255
3256 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3257
3258         GDB 8.3 released.
3259
3260 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3261
3262         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3263         New variable declaration.
3264         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3265         New variable.
3266         (print_one_breakpoint): Use ui_out::test_flags and new global
3267         variable to compute use_fixed_output.
3268         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3269         Remove.
3270         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3271         (mi_multi_location_breakpoint_output_fixed): Remove.
3272         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3273         new variable.
3274         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3275         fix_multi_location_breakpoint_output flag if version >= 3.
3276         * ui-out.h (enum ui_out_flag)
3277         <fix_multi_location_breakpoint_output>: New enumerator.
3278
3279 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3280
3281         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3282
3283 2019-05-10  Tom Tromey  <tromey@adacore.com>
3284
3285         * ada-lang.c (catch_ada_completer): New function.
3286         (_initialize_ada_language): Use it.
3287
3288 2019-05-10  Tom Tromey  <tromey@adacore.com>
3289
3290         * thread.c (print_thread_info): Make "requested_threads" const.
3291         * gdbthread.h (print_thread_info): Make "requested_threads"
3292         const.
3293         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3294         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3295
3296 2019-05-08  Tom Tromey  <tom@tromey.com>
3297
3298         * gdbtypes.c (objfile_type_data): Change type.
3299         (objfile_type, _initialize_gdbtypes): Update.
3300
3301 2019-05-08  Tom Tromey  <tom@tromey.com>
3302
3303         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3304         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3305         (_initialize_dwarf2_frame): Update.
3306
3307 2019-05-08  Tom Tromey  <tom@tromey.com>
3308
3309         * objc-lang.c (objc_objfile_data): Change type.
3310         (find_methods): Update.
3311         (_initialize_objc_lang): Remove.
3312
3313 2019-05-08  Tom Tromey  <tom@tromey.com>
3314
3315         * stabsread.c (rs6000_builtin_type_data): Change type.
3316         (rs6000_builtin_type, _initialize_stabsread): Update.
3317
3318 2019-05-08  Tom Tromey  <tom@tromey.com>
3319
3320         * mips-tdep.c (mips_pdr_data): Remove.
3321         (_initialize_mips_tdep): Update.
3322
3323 2019-05-08  Tom Tromey  <tom@tromey.com>
3324
3325         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3326         (hppa_init_objfile_priv_data, read_unwind_info)
3327         (find_unwind_entry, _initialize_hppa_tdep): Update.
3328
3329 2019-05-08  Tom Tromey  <tom@tromey.com>
3330
3331         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3332         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3333         on obstack.
3334         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3335
3336 2019-05-08  Tom Tromey  <tom@tromey.com>
3337
3338         * mdebugread.c (basic_type_data): Change type.
3339         (basic_type, _initialize_mdebugread): Update.
3340
3341 2019-05-08  Tom Tromey  <tom@tromey.com>
3342
3343         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3344
3345 2019-05-08  Tom Tromey  <tom@tromey.com>
3346
3347         * nto-tdep.c (nto_inferior_data_reg): Change type.
3348         (nto_inferior_data): Update.
3349         (nto_inferior_data_cleanup, nto_new_inferior_data)
3350         (_initialize_nto_tdep): Remove.
3351         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3352
3353 2019-05-08  Tom Tromey  <tom@tromey.com>
3354
3355         * ada-lang.c (struct ada_inferior_data): Add initializers.
3356         (ada_inferior_data): Change type.
3357         (ada_inferior_data_cleanup): Remove.
3358         (get_ada_inferior_data, ada_inferior_exit)
3359         (struct ada_pspace_data): Add initializers, destructor.
3360         (ada_pspace_data_handle): Change type.
3361         (get_ada_pspace_data): Update.
3362         (ada_pspace_data_cleanup): Remove.
3363
3364 2019-05-08  Tom Tromey  <tom@tromey.com>
3365
3366         * coffread.c (struct coff_symfile_info): Add initializers.
3367         (coff_objfile_data_key): Move lower.  Change type.
3368         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3369         Update.
3370         (coff_free_info): Remove.
3371
3372 2019-05-08  Tom Tromey  <tom@tromey.com>
3373
3374         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3375         (fbsd_pspace_data_handle): Move lower.  Change type.
3376         (get_fbsd_pspace_data): Update.
3377         (fbsd_pspace_data_cleanup): Remove.
3378         (_initialize_fbsd_tdep): Update.
3379
3380 2019-05-08  Tom Tromey  <tom@tromey.com>
3381
3382         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3383         (get_ada_tasks_pspace_data): Update.
3384         (ada_tasks_pspace_data_cleanup): Remove.
3385         (_initialize_tasks): Update.
3386         (ada_tasks_inferior_data_handle): Change type.
3387         (get_ada_tasks_inferior_data): Update.
3388         (ada_tasks_inferior_data_cleanup): Remove.
3389         (struct ada_tasks_pspace_data): Add initializers.
3390
3391 2019-05-08  Tom Tromey  <tom@tromey.com>
3392
3393         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3394         * symfile-debug.c (debug_sym_get_probes): Change type.
3395         * stap-probe.c (handle_stap_probe):
3396         (stap_static_probe_ops::get_probes): Change type.
3397         * probe.h (class static_probe_ops) <get_probes>: Change type.
3398         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3399         (parse_probes_in_pspace): Update.
3400         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3401         Update.
3402         (any_static_probe_ops::get_probes): Change type.
3403         * elfread.c (elfread_data): New typedef.
3404         (probe_key): Change type.
3405         (elf_get_probes): Likewise.  Update.
3406         (probe_key_free): Remove.
3407         (_initialize_elfread): Update.
3408         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3409         Change type.
3410         (dtrace_process_dof_probe, dtrace_process_dof)
3411         (dtrace_static_probe_ops::get_probe): Change type.
3412
3413 2019-05-08  Tom Tromey  <tom@tromey.com>
3414
3415         * xcoffread.c (struct xcoff_symfile_info): Rename from
3416         coff_symfile_info.  Add initializers.
3417         (xcoff_objfile_data_key): Move lower.  Change type.
3418         (XCOFF_DATA): Rewrite.
3419         (xcoff_free_info): Remove.
3420         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3421         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3422         (xcoff_initial_scan): Update.
3423
3424 2019-05-08  Tom Tromey  <tom@tromey.com>
3425
3426         * solib-svr4.c (struct svr4_info): Add initializers and
3427         destructor.
3428         <probes_table>: Now an htab_up.
3429         (solib_svr4_pspace_data): Change type.
3430         (free_probes_table): Simplify.
3431         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3432         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3433         (probes_table_remove_objfile_probes, register_solib_event_probe)
3434         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3435         (_initialize_svr4_solib): Update.
3436
3437 2019-05-08  Tom Tromey  <tom@tromey.com>
3438
3439         * remote.c (remote_pspace_data): Change type.
3440         (remote_pspace_data_cleanup): Remove.
3441         (get_remote_exec_file, set_pspace_remote_exec_file)
3442         (_initialize_remote): Update.
3443
3444 2019-05-08  Tom Tromey  <tom@tromey.com>
3445
3446         * breakpoint.c (breakpoint_objfile_key): Change type.
3447         (get_breakpoint_objfile_data): Update.
3448         (free_breakpoint_objfile_data): Remove.
3449         (_initialize_breakpoint): Update.
3450
3451 2019-05-08  Tom Tromey  <tom@tromey.com>
3452
3453         * linux-tdep.c (struct linux_info): Add initializers.
3454         (linux_inferior_data): Move.  Change type.
3455         (invalidate_linux_cache_inf): Update.
3456         (linux_inferior_data_cleanup): Remove.
3457         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3458
3459 2019-05-08  Tom Tromey  <tom@tromey.com>
3460
3461         * auxv.c (auxv_inferior_data): Move.  Change type.
3462         (auxv_inferior_data_cleanup): Remove.
3463         (invalidate_auxv_cache_inf): Rewrite.
3464         (get_auxv_inferior_data, _initialize_auxv): Update.
3465
3466 2019-05-08  Tom Tromey  <tom@tromey.com>
3467
3468         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3469         (symfile_debug_objfile_data_key): Change type.
3470         (symfile_debug_installed, debug_qf_has_symbols)
3471         (debug_qf_find_last_source_symtab)
3472         (debug_qf_forget_cached_source_info)
3473         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3474         (debug_qf_print_stats, debug_qf_dump)
3475         (debug_qf_expand_symtabs_for_function)
3476         (debug_qf_expand_all_symtabs)
3477         (debug_qf_expand_symtabs_with_fullname)
3478         (debug_qf_map_matching_symbols)
3479         (debug_qf_expand_symtabs_matching)
3480         (debug_qf_find_pc_sect_compunit_symtab)
3481         (debug_qf_map_symbol_filenames)
3482         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3483         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3484         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3485         (debug_sym_read_linetable, debug_sym_relocate): Update.
3486         (symfile_debug_free_objfile): Remove.
3487         (install_symfile_debug_logging, _initialize_symfile_debug):
3488         Update.
3489
3490 2019-05-08  Tom Tromey  <tom@tromey.com>
3491
3492         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3493         allocate_on_obstack.
3494         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3495         (get_dwarf2_per_objfile): Update.
3496         (set_dwarf2_per_objfile): Remove.
3497         (dwarf2_has_info, dwarf2_get_section_info): Update.
3498         (dwarf2_free_objfile): Remove.
3499         (_initialize_dwarf2_read): Update.
3500
3501 2019-05-08  Tom Tromey  <tom@tromey.com>
3502
3503         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3504         initializers.
3505         <unsupported_script_warning_printed,
3506         script_not_found_warning_printed>: Now bool.
3507         (auto_load_pspace_data): Change type.
3508         (~auto_load_pspace_info): Rename from
3509         auto_load_pspace_data_cleanup.
3510         (get_auto_load_pspace_data, init_loaded_scripts_info)
3511         (clear_section_scripts, maybe_print_unsupported_script_warning)
3512         (maybe_print_script_not_found_warning, _initialize_auto_load):
3513         Update.
3514
3515 2019-05-08  Tom Tromey  <tom@tromey.com>
3516
3517         * objfiles.c (objfile_pspace_info): Add destructor and
3518         initializers.
3519         (objfiles_pspace_data): Change type.
3520         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3521         (get_objfile_pspace_data): Update.
3522         (objfiles_bfd_data): Change type.
3523         (get_objfile_bfd_data): Update.
3524         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3525
3526 2019-05-08  Tom Tromey  <tom@tromey.com>
3527
3528         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3529         Change type.
3530         (get_catch_syscall_inferior_data): Update.
3531         (catch_syscall_inferior_data_cleanup): Remove.
3532         (_initialize_break_catch_syscall): Update.
3533
3534 2019-05-08  Tom Tromey  <tom@tromey.com>
3535
3536         * inflow.c (struct terminal_info): Add destructor and
3537         initializers.
3538         (inflow_inferior_data): Change type.
3539         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3540         (get_inflow_inferior_data, inflow_inferior_exit)
3541         (swap_terminal_info, _initialize_inflow): Update.
3542
3543 2019-05-08  Tom Tromey  <tom@tromey.com>
3544
3545         * target-dcache.c (target_dcache_cleanup): Remove.
3546         (target_dcache_aspace_key): Change type.
3547         (target_dcache_init_p, target_dcache_invalidate)
3548         (target_dcache_get, target_dcache_get_or_init)
3549         (_initialize_target_dcache): Update.
3550         * dcache.h (struct dcache_deleter): New.
3551
3552 2019-05-08  Tom Tromey  <tom@tromey.com>
3553
3554         * symtab.c (struct symbol_cache): Add destructor and
3555         initializers.
3556         (symbol_cache_key): Move.  Change type.
3557         (make_symbol_cache, free_symbol_cache): Remove.
3558         (get_symbol_cache): Update.
3559         (symbol_cache_cleanup): Remove.
3560         (ALL_PSPACES, symbol_cache_flush)
3561         (maintenance_print_symbol_cache)
3562         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3563         Update.
3564
3565 2019-05-08  Tom Tromey  <tom@tromey.com>
3566
3567         * symtab.c (struct main_info): Add destructor and initializers.
3568         (main_progspace_key): Move.  Change type.
3569         (get_main_info): Update.
3570         (main_info_cleanup): Remove.
3571         (_initialize_symtab): Update.
3572
3573 2019-05-08  Tom Tromey  <tom@tromey.com>
3574
3575         * registry.h (DECLARE_REGISTRY): Define the _key class.
3576
3577 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3578
3579         * NEWS: Merge two 'New commands' sections.
3580
3581 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3582
3583         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3584         parameter and use Ada language definition instead.
3585         (ada_val_print_ptr): Remove unused language parameter.
3586         (ada_val_print_num): Remove language parameter and use Ada language
3587         definition instead.
3588         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3589         parameter.
3590         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3591         parameter and use Ada language definition instead.
3592         (ada_val_print_1): Update all ada_val_print_xxx calls.
3593         Remove language parameter.
3594         (ada_val_print): Update ada_val_print_1 call.
3595
3596 2019-05-08  Tom Tromey  <tromey@adacore.com>
3597
3598         * remote.c (remote_hw_watchpoint_limit)
3599         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3600         Now static.
3601
3602 2019-05-08  Tom Tromey  <tromey@adacore.com>
3603
3604         * maint.c (_initialize_maint_cmds): Move initialization code to
3605         remote.c.
3606         (watchdog, show_watchdog): Move to remote.c.
3607         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3608         "watchdog" static.
3609         (_initialize_remote): Move initialization code from maint.c.
3610         * defs.h (watchdog): Don't declare.
3611
3612 2019-05-08  Tom Tromey  <tromey@adacore.com>
3613
3614         * tui/tui-interp.c: Include main.h.
3615         * interps.c: Include main.h.
3616         * main.h (interpreter_p): Declare.
3617         * defs.h (interpreter_p): Don't declare.
3618
3619 2019-05-08  Tom Tromey  <tromey@adacore.com>
3620
3621         * dwarf2loc.c: Include dwarf2read.h.
3622         * defs.h (read_unsigned_leb128): Don't declare.
3623         * dwarf2read.h (read_unsigned_leb128): Declare.
3624
3625 2019-05-08  Tom Tromey  <tromey@adacore.com>
3626
3627         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3628         method.
3629
3630 2019-05-08  Tom Tromey  <tromey@adacore.com>
3631
3632         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3633         when no wrap column is set.
3634
3635 2019-05-08  Tom Tromey  <tromey@adacore.com>
3636
3637         * c-lang.c (c_get_string): Handle non-C-style arrays.
3638
3639 2019-05-08  Tom Tromey  <tromey@adacore.com>
3640
3641         * typeprint.c (print_offset_data::update): Print the bit offset,
3642         not the number of bits remaining.
3643
3644 2019-05-08  Tom Tromey  <tromey@adacore.com>
3645
3646         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3647         padding at end of comment.
3648
3649 2019-05-08  Tom Tromey  <tromey@adacore.com>
3650
3651         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3652         Compare main types.
3653
3654 2019-05-06  Tom Tromey  <tom@tromey.com>
3655
3656         * common/scoped_mmap.c: Include common-defs.h.
3657         * common/scoped_mmap.h: Don't include config.h.
3658
3659 2019-05-04  Tom Tromey  <tom@tromey.com>
3660
3661         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3662         (struct aarch64_call_info): Add initializers.
3663         <si>: Now a std::vector.
3664         (pass_on_stack, aarch64_push_dummy_call): Update.
3665
3666 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3667             Tom Tromey  <tom@tromey.com>
3668
3669         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3670         (ppc_threads): Now a std::vector.  Now static.
3671         (hwdebug_find_thread_points_by_tid)
3672         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3673         Update.
3674
3675 2019-05-04  Tom Tromey  <tom@tromey.com>
3676
3677         * arc-tdep.c (arc_tdesc_init): Return bool.
3678
3679 2019-05-04  Tom Tromey  <tom@tromey.com>
3680
3681         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3682         Use gdb_assert_not_reached.
3683
3684 2019-05-04  Tom Tromey  <tom@tromey.com>
3685
3686         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3687         "false".
3688
3689 2019-05-04  Tom Tromey  <tom@tromey.com>
3690
3691         * arc-tdep.c (arc_tdesc_init): Use bool.
3692
3693 2019-05-04  Tom Tromey  <tom@tromey.com>
3694
3695         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3696
3697 2019-05-04  Tom Tromey  <tom@tromey.com>
3698
3699         * cli/cli-cmds.c (valid_command_p): Return bool.
3700
3701 2019-05-04  Tom Tromey  <tom@tromey.com>
3702
3703         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3704         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3705
3706 2019-05-04  Raul Tambre  <raul@tambre.ee>
3707
3708         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3709         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3710         operator for comparison.
3711
3712 2019-05-04  Tom Tromey  <tom@tromey.com>
3713
3714         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3715         (lookup_partial_symbol, print_partial_symbols)
3716         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3717         (psymbol_compare): Update.
3718         (add_psymbol_to_bcache): Clear the entire psymbol.
3719         (maintenance_check_psymtabs): Update.
3720         * psympriv.h (struct partial_symbol): Don't derive from
3721         general_symbol_info.
3722         <obj_section, unrelocated_address, address,
3723         set_unrelocated_address>: Update.
3724         <ginfo>: New member.
3725         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3726         (debug_names::write_psymbols): Update.
3727
3728 2019-05-04  Tom de Vries  <tdevries@suse.de>
3729
3730         * contrib/cc-with-tweaks.sh: Support -n arg.
3731
3732 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3733
3734         * corelow.c (core_target::detach): Ensure frame cache and
3735         register caches are cleared.
3736         inferior.c (exit_inferior_1): Likewise.
3737
3738 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3739             Tom Tromey  <tom@tromey.com>
3740
3741         * dictionary.c (collate_pending_symbols_by_language): Remove
3742         "struct" from foreach.
3743         * symtab.c (lookup_global_symbol_from_objfile)
3744         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3745         foreach.
3746         * ser-tcp.c (net_open): Remove "struct" from foreach.
3747         * objfiles.c (objfile_relocate, objfile_rebase)
3748         (objfile_has_symbols): Remove "struct" from foreach.
3749         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3750         from foreach.
3751         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3752         foreach.
3753         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3754         "struct" from foreach.
3755         * ada-lang.c (create_excep_cond_exprs)
3756         (ada_exception_catchpoint_cond_string): Remove "struct" from
3757         foreach.
3758
3759 2019-05-03  Tom Tromey  <tromey@adacore.com>
3760
3761         * ada-exp.y (convert_char_literal): Check suffix of each
3762         enumerator.
3763
3764 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3765
3766         PR ada/21406:
3767         * ada-exp.y (yywrap): Don't define.
3768         * ada-lex.l (%option): Add noyywrap
3769         (yywrap): Remove.
3770
3771 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3772
3773         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3774         _WIN32_WINNT to the XP level, unless already defined to a higher
3775         level.
3776
3777         * unittests/parse-connection-spec-selftests.c:
3778         * ser-tcp.c:
3779         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3780         override.
3781
3782         * symfile.c (find_separate_debug_file): Remove colon from the
3783         drive spec of DOS/Windows file names of the target, so that the
3784         file name produced from DEBUGDIR and the target's directory will
3785         be valid on DOS/Windows systems.
3786
3787 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3788
3789         * rust-lang.c (val_print_struct): Handle printing structures
3790         containing strings.
3791
3792 2019-05-02  Tom Tromey  <tromey@adacore.com>
3793
3794         * valarith.c (_initialize_valarith): Remove.
3795
3796 2019-05-01  Tom Tromey  <tromey@adacore.com>
3797
3798         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3799         bitfields.
3800
3801 2019-05-01  Tom Tromey  <tromey@adacore.com>
3802
3803         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3804         for big-endian copies.
3805
3806 2019-04-30  Ali Tamur  <tamur@google.com>
3807         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3808         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3809         (read_3_bytes): New function.
3810
3811 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3812
3813         * windows-nat.c (main_thread_id): Delete.
3814         (handle_output_debug_string): Replace main_thread_id by
3815         current_event.dwThreadId.
3816         (fake_create_process): Likewise.
3817         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3818         Do not set main_thread_id.
3819         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3820         current_event.dwThreadId.
3821         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3822
3823 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3824
3825         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3826         Use current_event.dwThreadId instead of main_thread_id.
3827
3828 2019-04-30  Tom Tromey  <tromey@adacore.com>
3829
3830         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3831         (create_excep_cond_exprs): Iterate over program spaces.
3832         (ada_exception_catchpoint_cond_string): Examine all minimal
3833         symbols for exception types.
3834
3835 2019-04-30  Tom Tromey  <tromey@adacore.com>
3836
3837         PR c++/24470:
3838         * dwarf2read.c (process_structure_scope): Handle case where type
3839         has template parameters but no symbol was created.
3840
3841 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3842             Chris January  <chris.january@arm.com>
3843
3844         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3845         qualifier.
3846         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3847
3848 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3849
3850         * f-typeprint.c (f_print_type): Update rules for printing
3851         whitespace.
3852         (f_type_print_varspec_suffix): Likewise.
3853
3854 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3855             Chris January  <chris.january@arm.com>
3856
3857         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3858         function arguments.
3859
3860 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3861
3862         * f-lang.c (build_fortran_types): Change name of void type to
3863         lower case.
3864         * f-typeprint.c (f_type_print_base): Print the name of the void
3865         type, rather than a fixed string.
3866         * f-valprint.c (f_decorations): Use lower case void string.
3867
3868 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3869             Chris January  <chris.january@arm.com>
3870
3871         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3872         types for Fortran.
3873
3874 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3875             Chris January  <chris.january@arm.com>
3876             David Lecomber  <david.lecomber@arm.com>
3877
3878         * f-exp.y (BINOP_INTRINSIC): New token.
3879         (exp): New parser rule handling BINOP_INTRINSIC.
3880         (f77_keywords): Add new builtin procedures.
3881         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3882         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3883         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3884         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3885         (print_unop_subexp_f): New function.
3886         (print_binop_subexp_f): New function.
3887         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3888         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3889         (dump_subexp_body_f): Likewise.
3890         (operator_check_f): Likewise.
3891         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3892         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3893
3894 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3895
3896         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3897         UNOP_KIND.
3898         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3899         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3900         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3901         (operator_length_f): New fuction.
3902         (print_subexp_f): New function.
3903         (op_name_f): New function.
3904         (dump_subexp_body_f): New function.
3905         (operator_check_f): New function.
3906         (exp_descriptor_f): Replace standard expression handling functions
3907         with new functions.
3908         * gdb/fortran-operator.def: New file.
3909         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3910         * gdb/std-operator.def: Remove UNOP_KIND.
3911
3912 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3913
3914         * std-operator.def: Remove unbalanced, stray double quote
3915         character.
3916
3917 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3918             Chris January  <chris.january@arm.com>
3919             Daniel Everett  <daniel.everett@arm.com>
3920             Nick Forrington  <nick.forrington@arm.com>
3921             Richard Bunt  <richard.bunt@arm.com>
3922
3923         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3924         of depth when printing anonymous structs or unions.
3925         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3926         Don't print either the top-level value, or the children if the
3927         max-depth is exceeded.
3928         (ppscm_print_children): When printing the key of a map, allow one
3929         extra level of depth.
3930         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3931         print either the top-level value, or the children if the max-depth
3932         is exceeded.
3933         (print_children): When printing the key of a map, allow one extra
3934         level of depth.
3935         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3936         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3937         (user_print_options): Initialise max_depth field.
3938         (val_print_scalar_or_string_type_p): New function.
3939         (val_print): Check to see if the max depth has been reached.
3940         (val_print_check_max_depth): Define new function.
3941         (show_print_max_depth): New function.
3942         (_initialize_valprint): Add 'print max-depth' option.
3943         * valprint.h (struct value_print_options) <max_depth>: New field.
3944         (val_print_check_max_depth): Declare new function.
3945         * NEWS: Document new feature.
3946
3947 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3948
3949         * ada-lang.c (ada_language_defn): Initialise new field.
3950         * c-lang.c (c_is_string_type_p): New function.
3951         (c_language_defn): Initialise new field.
3952         (cplus_language_defn): Initialise new field.
3953         (asm_language_defn): Initialise new field.
3954         (minimal_language_defn): Initialise new field.
3955         * c-lang.h (c_is_string_type_p): Declare new function.
3956         * d-lang.c (d_language_defn): Initialise new field.
3957         * f-lang.c (f_is_string_type_p): New function.
3958         (f_language_defn): Initialise new field.
3959         * go-lang.c (go_is_string_type_p): New function.
3960         (go_language_defn): Initialise new field.
3961         * language.c (default_is_string_type_p): New function.
3962         (unknown_language_defn): Initialise new field.
3963         (auto_language_defn): Initialise new field.
3964         * language.h (struct language_defn) <la_is_string_type_p>: New
3965         member variable.
3966         (default_is_string_type_p): Declare new function.
3967         * m2-lang.c (m2_language_defn): Initialise new field.
3968         * objc-lang.c (objc_language_defn): Initialise new field.
3969         * opencl-lang.c (opencl_language_defn): Initialise new field.
3970         * p-lang.c (pascal_is_string_type_p): New function.
3971         (pascal_language_defn): Initialise new field.
3972         * rust-lang.c (rust_is_string_type_p): New function.
3973         (rust_language_defn): Initialise new field.
3974
3975 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3976
3977         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3978         New field.
3979         * ada-lang.c (ada_language_defn): Initialise new field.
3980         * c-lang.c (c_language_defn): Likewise.
3981         (cplus_language_defn): Likewise.
3982         (asm_language_defn): Likewise.
3983         (minimal_language_defn): Likewise.
3984         * d-lang.c (d_language_defn): Likewise.
3985         * f-lang.c (f_language_defn): Likewise.
3986         * go-lang.c (go_language_defn): Likewise.
3987         * language.c (unknown_language_defn): Likewise.
3988         (auto_language_defn): Likewise.
3989         * m2-lang.c (m2_language_defn): Likewise.
3990         * objc-lang.c (objc_language_defn): Likewise.
3991         * opencl-lang.c (opencl_language_defn): Likewise.
3992         * p-lang.c (pascal_language_defn): Likewise.
3993         * rust-lang.c (rust_language_defn): Likewise.
3994
3995 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3996
3997         * ada-lang.c (ada_is_character_type): Change return type to bool.
3998         (ada_is_string_type): Likewise.
3999         * ada-lang.h (ada_is_character_type): Update declaration
4000         (ada_is_string_type): Likewise.
4001
4002 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4003
4004         Support style in 'frame|thread apply'
4005
4006         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4007         * record.c (record_start, record_stop): Update callers of
4008         execute_command_to_string with false.
4009         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4010         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4011         methods.
4012         (class string_file): New constructor with term_out parameter.
4013         Override methods term_out and can_emit_style_escape.  New member
4014         term_out.
4015         (class stdio_file): Override can_emit_style_escape.
4016         (class tee_file): Override term_out and can_emit_style_escape.
4017         * utils.h (can_emit_style_escape): Remove.
4018         * utils.c (can_emit_style_escape): Likewise.
4019         Update all callers of can_emit_style_escape (SOMESTREAM) to
4020         SOMESTREAM->can_emit_style_escape.
4021         * source-cache.c (source_cache::get_source_lines): Likewise.
4022         * stack.c (frame_apply_command_count): Call execute_command_to_string
4023         passing the term_out characteristic of the current gdb_stdout.
4024         * thread.c (thr_try_catch_cmd): Likewise.
4025         * top.c (execute_command_to_string): pass term_out parameter
4026         to construct the string_file for the command output.
4027         * ui-file.c (term_cli_styling): New function (most code moved
4028         from utils.c can_emit_style_escape).
4029         (string_file::string_file, string_file::can_emit_style_escape,
4030         stdio_file::can_emit_style_escape, tee_file::term_out,
4031         tee_file::can_emit_style_escape): New functions.
4032
4033 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4034
4035         * NEWS: Mention the new set|show may-call-functions.
4036         * infcall.c (may_call_functions_p): New variable.
4037         (show_may_call_functions_p): New function.
4038         (call_function_by_hand_dummy): Throws an error if not
4039         may-call-functions.
4040         (_initialize_infcall): Call add_setshow_boolean_cmd for
4041         may-call-functions.
4042
4043 2019-04-25  Keith Seitz  <keiths@redhat.com>
4044
4045         PR c++/24367
4046         * cp-support.c (inspect_type): Don't attempt substitutions
4047         of symbol with the same name.
4048
4049 2019-04-25  Tom Tromey  <tromey@adacore.com>
4050
4051         PR gdb/24475:
4052         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4053         static.
4054
4055 2019-04-25  Tom Tromey  <tromey@adacore.com>
4056
4057         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4058         rvalue reference.
4059         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4060         (gdb_xml_parser::parse): Use std::move.
4061         * python/python-internal.h (gdbpy_convert_exception): Take a const
4062         reference.
4063         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4064         std::move.
4065         * python/py-utils.c (gdbpy_convert_exception): Take a const
4066         reference.
4067         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4068         Use std::move.
4069         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4070         Use std::move.
4071         * mi/mi-main.c (mi_print_exception): Take a const reference.
4072         * main.c (handle_command_errors): Take a const reference.
4073         * linespec.c (parse_linespec): Use std::move.
4074         * infcall.c (run_inferior_call): Use std::move.
4075         (call_function_by_hand_dummy): Use std::move.
4076         * exec.c (try_open_exec_file): Use std::move.
4077         * exceptions.h (exception_print, exception_fprintf)
4078         (exception_print_same): Update.
4079         * exceptions.c (print_exception, exception_print)
4080         (exception_fprintf, exception_print_same): Change parameters to
4081         const reference.
4082         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4083         * common/new-op.c: Use std::move.
4084         * common/common-exceptions.h (struct gdb_exception): Add move
4085         constructor.
4086         (struct gdb_exception_error, struct gdb_exception_quit, struct
4087         gdb_quit_bad_alloc): Change constructor to move constructor.
4088         (throw_exception): Change parameter to rvalue reference.
4089         * common/common-exceptions.c (throw_exception): Take rvalue
4090         reference.
4091         * cli/cli-interp.c (safe_execute_command): Use std::move.
4092         * breakpoint.c (insert_bp_location, location_to_sals): Use
4093         std::move.
4094
4095 2019-04-25  Tom Tromey  <tromey@adacore.com>
4096
4097         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4098         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4099         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4100         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4101         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4102         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4103         guile/scm-value.c: Use unpack.
4104         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4105         gdbscm_gdb_exception.
4106         (gdbscm_throw_gdb_exception): Likewise.
4107         (struct gdbscm_gdb_exception): New.
4108         (unpack): New function.
4109         (gdbscm_wrap): Use unpack.
4110
4111 2019-04-25  Tom Tromey  <tromey@adacore.com>
4112
4113         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4114         (gdb_rl_callback_handler): Use std::move.
4115         * common/common-exceptions.h (struct gdb_exception): Add move
4116         assignment operator.
4117         (throw_exception_sjlj): Change "exception" to const reference.
4118         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4119         (throw_exception_sjlj): Change "exception" to const reference.
4120
4121 2019-04-25  Tom Tromey  <tromey@adacore.com>
4122
4123         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4124         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4125         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4126         Update.
4127         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4128         Update.
4129         * mi/mi-interp.c (mi_interp::exec): Update.
4130         * linespec.c (parse_linespec): Update.
4131         * infcall.c (run_inferior_call): Update.
4132         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4133         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4134         (gdbscm_lookup_global_symbol): Update.
4135         * guile/scm-param.c (gdbscm_parameter_value): Update.
4136         * guile/scm-frame.c (gdbscm_frame_read_register)
4137         (gdbscm_frame_read_var): Update.
4138         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4139         * exec.c (try_open_exec_file): Update.
4140         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4141         (gdb_rl_callback_handler): Update.
4142         * common/common-exceptions.h (exception_none): Don't declare.
4143         * common/common-exceptions.c (exception_none): Don't define.
4144         (struct catcher) <exception>: Update.
4145         * cli/cli-interp.c (safe_execute_command): Update.
4146         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4147
4148 2019-04-25  Ali Tamur  <tamur@google.com>
4149
4150         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4151         (read_attribute_value): Likewise.
4152         (dwarf2_read_addr_index): Update comment.
4153         (read_str_index): Add DW_FORM_strx.
4154         (dwarf2_string_attr): Likewise.
4155         (dwarf2_const_value_attr): Likewise.
4156         (dump_die_shallow): Likewise.
4157         (dwarf2_fetch_constant_bytes): Likewise.
4158         (skip_form_bytes): Likewise.
4159         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4160
4161 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4162
4163         PR corefiles/11608
4164         PR corefiles/18187
4165         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4166         OFFSET.  Verify if current mapping contains an ELF header.
4167         (linux_find_memory_regions_full): Adjust call to
4168         dump_mapping_p.
4169
4170 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4171             Kang Li <kanglictf@gmail.com>
4172
4173         PR gdb/21600
4174
4175         * dwarf2-frame.c (read_initial_length): Be consistent about using
4176         unsigned representation of length.
4177         (decode_frame_entry_1): Likewise.  Check for wraparound of
4178         end pointer as well as buffer overflow.
4179
4180 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4181
4182         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4183         "vq".
4184
4185 2019-04-24  Tom Tromey  <tromey@adacore.com>
4186
4187         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4188
4189 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4190
4191         * s12z-tdep.c (s12z_unwind_pc): Delete.
4192         (s12z_unwind_sp): Delete.
4193         (s12z_gdbarch_init): Don't register deleted functions with
4194         gdbarch.
4195
4196 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4197
4198         * rl78-tdep.c (rl78_unwind_sp): Delete.
4199         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4200
4201 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4202
4203         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4204         (xstormy16_unwind_pc): Delete.
4205         (xstormy16_dummy_id): Delete.
4206         (xstormy16_gdbarch_init): Don't register deleted functions with
4207         gdbarch.
4208
4209 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4210
4211         * vax-tdep.c (vax_unwind_pc): Delete.
4212         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4213
4214 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4215
4216         * v850-tdep.c (v850_unwind_sp): Delete.
4217         (v850_unwind_pc): Delete.
4218         (v850_dummy_id): Delete.
4219         (v850_gdbarch_init): Don't register deleted functions with
4220         gdbarch.
4221
4222 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4223
4224         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4225         (tilegx_unwind_pc): Delete.
4226         (tilegx_unwind_dummy_id): Delete.
4227         (tilegx_gdbarch_init): Don't register deleted functions with
4228         gdbarch.
4229
4230 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4231
4232         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4233         (tic6x_dummy_id): Delete.
4234         (tic6x_gdbarch_init): Don't register deleted functions with
4235         gdbarch.
4236
4237 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4238
4239         * sparc-tdep.c (sparc_unwind_pc): Delete.
4240         (sparc32_gdbarch_init): Don't register deleted function with
4241         gdbarch.
4242
4243 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4244
4245         * sh-tdep.c (sh_unwind_sp): Delete.
4246         (sh_unwind_pc): Delete.
4247         (sh_dummy_id): Delete.
4248         (sh_gdbarch_init): Don't register deleted functions with
4249         gdbarch.
4250
4251 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4252
4253         * score-tdep.c (score_unwind_sp): Delete.
4254         (score_unwind_pc): Delete.
4255         (score_dummy_id): Delete.
4256         (score_gdbarch_init): Don't register deleted functions with
4257         gdbarch.
4258
4259 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4260
4261         * rx-tdep.c (rx_unwind_pc): Delete.
4262         (rx_unwind_sp): Delete.
4263         (rx_dummy_id): Delete.
4264         (rx_gdbarch_init): Don't register deleted functions with
4265         gdbarch.  Update comment.
4266
4267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4268
4269         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4270         (rs6000_dummy_id): Delete.
4271         (rs6000_gdbarch_init): Don't register deleted functions with
4272         gdbarch.
4273
4274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4275
4276         * or1k-tdep.c (or1k_dummy_id): Delete.
4277         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4278
4279 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4280
4281         * nios2-tdep.c (nios2_dummy_id): Delete.
4282         (nios2_unwind_sp): Delete.
4283         (nios2_gdbarch_init): Don't register deleted functions with
4284         gdbarch.
4285
4286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4287
4288         * nds32-tdep.c (nds32_dummy_id): Delete.
4289         (nds32_unwind_pc): Delete.
4290         (nds32_unwind_sp): Delete.
4291         (nds32_gdbarch_init): Don't register deleted functions with
4292         gdbarch.
4293
4294 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4295
4296         * msp430-tdep.c (msp430_unwind_pc): Delete.
4297         (msp430_unwind_sp): Delete.
4298         (msp430_dummy_id): Delete.
4299         (msp430_gdbarch_init): Don't register deleted functions with
4300         gdbarch.
4301
4302 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4303
4304         * moxie-tdep.c (moxie_unwind_sp): Delete.
4305         (moxie_unwind_pc): Delete.
4306         (moxie_dummy_id): Delete.
4307         (moxie_gdbarch_init): Don't register deleted functions with
4308         gdbarch.
4309
4310 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4311
4312         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4313         (mn10300_unwind_pc): Delete.
4314         (mn10300_unwind_sp): Delete.
4315         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4316         mn10300_unwind_sp.
4317         (mn10300_frame_unwind_init): Don't register deleted functions with
4318         gdbarch.
4319
4320 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4321
4322         * mep-tdep.c (mep_unwind_pc): Delete.
4323         (mep_unwind_sp): Delete.
4324         (mep_dummy_id): Delete.
4325         (mep_gdbarch_init): Don't register deleted functions with
4326         gdbarch.
4327
4328 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4329
4330         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4331         (m68hc11_unwind_sp): Delete.
4332         (m68hc11_gdbarch_init): Don't register deleted functions with
4333         gdbarch.
4334
4335 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4336
4337         * m32r-tdep.c (m32r_unwind_sp): Delete.
4338         (m32r_unwind_pc): Delete.
4339         (m32r_dummy_id): Delete.
4340         (m32r_gdbarch_init): Don't register deleted functions with
4341         gdbarch.
4342
4343 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4344
4345         * m32c-tdep.c (m32c_unwind_pc): Delete.
4346         (m32c_unwind_sp): Delete.
4347         (m32c_dummy_id): Delete.
4348         (m32c_gdbarch_init): Don't register deleted functions with
4349         gdbarch.
4350
4351 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4352
4353         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4354         (lm32_unwind_pc): Delete.
4355         (lm32_dummy_id): Delete.
4356         (lm32_gdbarch_init): Don't register deleted functions with
4357         gdbarch.
4358
4359 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4360
4361         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4362         (iq2000_unwind_pc): Delete.
4363         (iq2000_dummy_id): Delete.
4364         (iq2000_gdbarch_init): Don't register deleted functions with
4365         gdbarch.
4366
4367 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4368
4369         * nds32-tdep.c (nds32_type_align): Delete.
4370         (nds32_push_dummy_call): Use type_align instead.
4371
4372 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4373
4374         * arm-tdep.c (arm_type_align): Only handle vector override case.
4375         (arm_push_dummy_call): Use type_align.
4376         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4377
4378 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4379
4380         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4381         case.
4382         (pass_on_stack): Use type_align.
4383         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4384         function.
4385
4386 2019-04-23  Tom Tromey  <tromey@adacore.com>
4387
4388         * dwarf2read.c (line_header::file_name_at): Remove unused
4389         overload.
4390
4391 2019-04-23  Tom de Vries  <tdevries@suse.de>
4392
4393         PR gdb/24438
4394         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4395         invocation.
4396
4397
4398 2019-03-27  Ali Tamur  <tamur@google.com>
4399
4400         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4401         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4402         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4403         (dwarf_expr_context::get_addr_index): Likewise
4404         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4405         (symbol_needs_eval_context::get_addr_index): Likewise
4406         (disassemble_dwarf_expression): Add DW_OP_addrx
4407         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4408         (read_cutu_die_from_dwo): Update comment
4409         (skip_one_die): Add DW_FORM_addrx
4410         (read_attribute_value): Likewise
4411         (var_decode_location): Add DW_OP_addrx
4412         (dwarf2_const_value_attr): Add DW_FORM_addrx
4413         (dump_die_shallow): Likewise
4414         (dwarf2_fetch_constant_bytes): Likewise
4415         (decode_locdesc): Add DW_OP_addrx
4416         (skip_form_bytes): Add DW_FORM_addrx
4417
4418 2019-04-22  Ali Tamur  <tamur@google.com>
4419
4420         * MAINTAINERS (Write After Approval): Add self.
4421
4422 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4423
4424         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4425         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4426         (open_symbol_file_object): Likewise.
4427         (svr4_default_sos): Add info parameter.
4428         (svr4_read_so_list): Likewise.
4429         (svr4_current_sos_direct): Adjust functions calls to pass down
4430         info.
4431         (svr4_current_sos_1): Add info parameter.
4432         (svr4_current_sos): Call get_svr4_info, pass info down to
4433         svr4_current_sos_1.
4434         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4435         get_svr4_info.
4436         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4437         get_svr4_info.
4438         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4439         to get_svr4_info.
4440         (probes_table_remove_objfile_probes): Likewise.
4441         (register_solib_event_probe): Add info parameter.
4442         (solist_update_incremental): Pass info parameter down to
4443         svr4_read_so_list.
4444         (disable_probes_interface): Add info parameter.
4445         (svr4_handle_solib_event): Pass current_program_space to
4446         get_svr4_info.  Adjust disable_probes_interface cleanup.
4447         (svr4_create_probe_breakpoints): Add info parameter, pass it
4448         down to register_solib_event_probe.
4449         (svr4_create_solib_event_breakpoints): Add info parameter,
4450         pass it down to svr4_create_probe_breakpoints.
4451         (enable_break): Pass info down to
4452         svr4_create_solib_event_breakpoints.
4453         (svr4_solib_create_inferior_hook): Pass current_program_space to
4454         get_svr4_info.
4455         (svr4_clear_solib): Likewise.
4456
4457 2019-04-22  Pedro Alves  <palves@redhat.com>
4458
4459         * solib-svr4.c (svr4_free_objfile_observer): New.
4460         (probe_and_action::objfile): New field.
4461         (probes_table_htab_remove_objfile_probes)
4462         (probes_table_remove_objfile_probes): New functions.
4463         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4464         in the new probe_and_action.  Don't store the probe in 'lookup'.
4465         (svr4_create_probe_breakpoints): Pass objfile to
4466         register_solib_event_probe.
4467         (_initialize_svr4_solib): Register a free_objfile observer.
4468
4469 2019-04-19  Tom Tromey  <tom@tromey.com>
4470
4471         * common/queue.h: Remove.
4472
4473 2019-04-19  Tom Tromey  <tom@tromey.com>
4474
4475         * event-loop.c: Don't include "common/queue.h".
4476
4477 2019-04-19  Tom Tromey  <tom@tromey.com>
4478
4479         * remote.c (remote_target): Use delete.
4480         * remote-notif.h: Include <list>, not "common/queue.h".
4481         (notif_client_p): Remove typedef.
4482         (remote_notif_state): Add constructor, destructor, initializer.
4483         <notif_queue>: Now a std::list.
4484         (remote_notif_state_xfree): Don't declare.
4485         * remote-notif.c (remote_notif_process, handle_notification)
4486         (remote_notif_state_allocate): Update.
4487         (~remote_notif_state): Rename from remote_notif_state_xfree.
4488
4489 2019-04-19  Tom Tromey  <tom@tromey.com>
4490
4491         * symfile.c (reread_symbols): Update.
4492         * objfiles.c (objfile_register_static_link)
4493         (objfile_lookup_static_link): Update
4494         (~objfile) Don't delete static_links.
4495         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4496
4497 2019-04-19  Tom Tromey  <tom@tromey.com>
4498
4499         * type-stack.h (struct type_stack) <insert>: Constify string.
4500         * type-stack.c (type_stack::insert): Constify string.
4501         * gdbtypes.h (lookup_template_type): Update.
4502         (address_space_name_to_int): Update.
4503         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4504         const.
4505         (lookup_template_type): Make name const.
4506         * c-exp.y: Update rules.
4507         (lex_one_token, classify_name, classify_inner_name)
4508         (c_print_token): Update.
4509         * p-exp.y: Update rules.
4510         (yylex): Update.
4511         * f-exp.y: Update rules.
4512         (yylex): Update.
4513         * d-exp.y: Update rules.
4514         (lex_one_token, classify_name, classify_inner_name): Update.
4515         * parse.c (write_dollar_variable, copy_name): Return std::string.
4516         * parser-defs.h (copy_name): Change return type.
4517         * m2-exp.y: Update rules.
4518         (yylex): Update.
4519         * go-exp.y (lex_one_token): Update.
4520         Update rules.
4521         (classify_unsafe_function, classify_packaged_name)
4522         (classify_name, yylex): Update.
4523
4524 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4525
4526         * configure.ac: add --enable-source-highlight switch.
4527         * configure: Regenerate.
4528         * top.c (print_gdb_version): plumb --enable-source-highlight
4529         status to "show configuration".
4530
4531 2019-04-19  Tom Tromey  <tromey@adacore.com>
4532
4533         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4534         Check ADA_TYPE_P.
4535         (empty_record, ada_template_to_fixed_record_type_1)
4536         (template_to_static_fixed_type)
4537         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4538         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4539         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4540         macros.
4541
4542 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4543
4544         PR symtab/24423:
4545         * source.c (print_source_lines_base): Advance "iter" when a
4546         control character is seen.
4547
4548 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4549
4550         * inferior.h (struct infcall_suspend_state_deleter):
4551         Catch exception in destructor to avoid crash.
4552
4553 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4554
4555         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4556         close to the add_com "shell".
4557
4558 2019-04-18  Tom Tromey  <tromey@adacore.com>
4559
4560         * process-stratum-target.h (class process_stratum_target)
4561         <stratum>: Add "final".
4562
4563 2019-04-17  Tom Tromey  <tromey@adacore.com>
4564
4565         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4566         against nullptr before use.
4567
4568 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4569
4570         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4571
4572 2019-04-17  Jim Wilson  <jimw@sifive.com>
4573             Andrew Burgess  <andrew.burgess@embecosm.com>
4574
4575         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4576         code read might fail, assume 4-byte breakpoint in that case.
4577
4578 2019-04-15  Leszek Swirski  <leszeks@google.com>
4579
4580         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4581         rather than a hand-rolled POD check when checking for forced MEMORY
4582         classification.
4583
4584 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4585
4586         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4587         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4588         function.
4589         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4590         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4591         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4592         declaration.
4593
4594 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4595
4596         * aarch64-linux-nat.c
4597         (aarch64_linux_nat_target::thread_architecture): Add override.
4598         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4599         each VQ.
4600
4601 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4602
4603         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4604
4605 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4606
4607         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4608         target types of size 96-bits, add some additional comments, and
4609         check that the builtin type we found was the correct size.
4610
4611 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4612
4613         * utils.c (prompt_for_continue): Don't restore the styling at the
4614         end, as applied_style has the wrong value.  This fixes styling in
4615         long lists of file names that are interrupted by the "Continue?"
4616         prompt.
4617
4618 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4619
4620         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4621         * c-lang.c (c_language_defn): Likewise.
4622         (cplus_language_defn): Likewise.
4623         (asm_language_defn): Likewise.
4624         (minimal_language_defn): Likewise.
4625         * d-lang.c (d_language_defn): Likewise.
4626         * f-lang.c (f_language_defn): Likewise.
4627         * go-lang.c (go_language_defn): Likewise.
4628         * language.c (unknown_language_defn): Likewise.
4629         (auto_language_defn): Likewise.
4630         * language.h (struct language_defn): Remove la_magic field.
4631         (LANG_MAGIC): Delete.
4632         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4633         * objc-lang.c (objc_language_defn): Likewise.
4634         * opencl-lang.c (opencl_language_defn): Likewise.
4635         * p-lang.c (pascal_language_defn): Likewise.
4636         * rust-lang.c (rust_language_defn): Likewise.
4637
4638 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4639
4640         * riscv-tdep.c (riscv_type_align): New function.
4641         (riscv_type_alignment): Delete.
4642         (riscv_arg_location): Use 'type_align'.
4643         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4644
4645 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4646
4647         * gdbtypes.c (type_align): A struct with no non-static fields also
4648         has alignment of 1.
4649
4650 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4651
4652         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4653         component to 0.
4654         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4655         member.
4656         (riscv_struct_info::analyse): New implementation using new
4657         analyse_inner member function.
4658         (riscv_struct_info::field_offset): New member function.
4659         (riscv_struct_info::m_offsets): New member variable.
4660         (riscv_struct_info::analyse_inner): New private member function,
4661         takes the old implementation of riscv_struct_info::analyse but
4662         extended to track field offsets.
4663         (riscv_call_arg_struct): Update the struct folding special cases
4664         to handle cases where empty C++ structs, which are non-zero
4665         length, are found.
4666         (riscv_arg_location): Initialise the length of each location, a
4667         non-zero length now indicates the location is in use.
4668         (riscv_push_dummy_call): Allow for the first location having a
4669         non-zero offset when setting up arguments.
4670         (riscv_return_value): Likewise, but for return values.
4671
4672 2019-04-11  Tom Tromey  <tromey@adacore.com>
4673
4674         * utils.c (internal_vproblem): Make "msg" const.
4675
4676 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4677
4678         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4679         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4680         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4681         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4682
4683 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4684
4685         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4686         function.
4687         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4688         of amd64_collect_native_gregset.
4689         (amd64_linux_nat_target::store_registers): Likewise.
4690
4691 2019-04-10  Tom Tromey  <tom@tromey.com>
4692
4693         * symtab.c (lookup_global_symbol_from_objfile)
4694         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4695         * objfiles.h (class separate_debug_iterator): New.
4696         (class separate_debug_range): New.
4697         (struct objfile) <separate_debug_objfiles>: New method.
4698         (objfile_separate_debug_iterate): Don't declare.
4699         * objfiles.c (separate_debug_iterator::operator++): Rename from
4700         objfile_separate_debug_iterate.
4701         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4702         iterator.
4703         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4704         iterator.
4705
4706 2019-04-10  Tom Tromey  <tom@tromey.com>
4707
4708         * symfile.c (reread_symbols): Remove old comment.
4709         * objfiles.c (free_all_objfiles): Fix a typo.
4710
4711 2019-04-10  Tom Tromey  <tom@tromey.com>
4712
4713         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4714         * minsyms.c (lookup_minimal_symbol): Use foreach.
4715         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4716         (lookup_minimal_symbol_solib_trampoline): Likewise.
4717         * symfile.c (reread_symbols): Use foreach.
4718
4719 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4720             Tom Tromey  <tromey@adacore.com>
4721
4722         PR rust/24414:
4723         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4724         (rust_lex_int_test): Change "value" to be LONGEST.
4725         (rust_lex_tests): Add test for long integer literal.
4726
4727 2019-04-09  Tom Tromey  <tromey@adacore.com>
4728
4729         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4730         to bool.
4731         (extended_remote_target::attach): Update.
4732         (remote_target::remote_notice_new_inferior): Update.
4733         (remote_target::add_current_inferior_and_thread): Update.
4734         * inferior.c (exit_inferior_1): Use "false".
4735         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4736
4737 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4738
4739         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4740         the "start" command.
4741
4742 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4743
4744         * python/py-inferior.c (infpy_thread_from_thread_handle):
4745         Adjust comments to reflect renaming of thread_from_thread_handle
4746         to thread_from_handle.  Adjust keywords.  Fix type error message.
4747         (inferior_object_methods): Add thread_from_handle.  Retain
4748         thread_from_thread_handle, but mark it as deprecated.
4749
4750 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4751
4752         * gdbthread.h (find_thread_by_handle): Revise declaration.
4753         * thread.c (find_thread_by_handle): Likewise.  Adjust
4754         implementation too.
4755         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4756         support for buffer objects as handles.
4757
4758 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4759
4760         * python/py-infthread.c (thpy_thread_handle): New function.
4761         (thread_object_methods): Register thpy_thread_handle.
4762
4763 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4764
4765         * gdbthread.h (thread_to_thread_handle): Declare.
4766         * thread.c (gdbtypes.h): Include.
4767         (thread_to_thread_handle): New function.
4768
4769         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4770         (target_thread_info_to_thread_handle): Declare.
4771         * target.c (target_thread_info_to_thread_handle): New function.
4772         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4773         * target-delegates.c: Regenerate.
4774
4775         * linux-thread-db.c (class thread_db_target): Add method
4776         thread_info_to_thread_handle.
4777         (thread_db_target::thread_info_to_thread_handle): Define.
4778         * remote.c (class remote_target): Add new method
4779         thread_info_to_thread_handle.
4780         (remote_target::thread_info_to_thread_handle): Define.
4781
4782 2019-04-08  Pedro Alves  <palves@redhat.com>
4783
4784         * common/common-exceptions.c (throw_exception): Don't create
4785         named object to throw; throw directly.
4786         (throw_it): Likewise.  Don't initialize gdb_exception::message
4787         here, with new; pass FMT and AP to the ctor instead.
4788         * common/common-exceptions.h: Include <string>.
4789         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4790         const char *, va_list)): New ctor.  Use std::make_shared.
4791         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4792         errors)): Delete.
4793         (gdb_exception_error::gdb_exception_error(enum errors, const char
4794         *, va_list)): New.
4795         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4796         Add assertion.
4797         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4798         errors)): Delete.
4799         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4800         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4801         Add assertion.
4802
4803 2019-04-08  Tom Tromey  <tom@tromey.com>
4804
4805         * valops.c (value_rtti_indirect_type): Replace throw_exception
4806         with throw.
4807         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4808         with throw.
4809         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4810         throw.
4811         * target.c (target_translate_tls_address): Replace throw_exception
4812         with throw.
4813         * stack.c (frame_apply_command_count): Replace throw_exception
4814         with throw.
4815         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4816         throw.
4817         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4818         with throw.
4819         * rs6000-tdep.c (rs6000_frame_cache)
4820         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4821         * remote.c: Replace throw_exception with throw.
4822         * record-full.c (record_full_message, record_full_wait_1)
4823         (record_full_restore): Replace throw_exception with throw.
4824         * record-btrace.c:
4825         (get_thread_current_frame_id, record_btrace_start_replaying)
4826         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4827         (cmd_record_btrace_start): Replace throw_exception with throw.
4828         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4829         throw.
4830         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4831         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4832         * linespec.c:
4833         (find_linespec_symbols): Replace throw_exception with throw.
4834         * infrun.c (displaced_step_prepare, resume): Replace
4835         throw_exception with throw.
4836         * infcmd.c (post_create_inferior): Replace throw_exception with
4837         throw.
4838         * inf-loop.c (inferior_event_handler): Replace throw_exception
4839         with throw.
4840         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4841         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4842         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4843         (get_prev_frame_always, get_frame_pc_if_available)
4844         (get_frame_address_in_block_if_available, get_frame_language):
4845         Replace throw_exception with throw.
4846         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4847         throw_exception with throw.
4848         * eval.c (fetch_subexp_value, evaluate_var_value)
4849         (evaluate_funcall, evaluate_subexp_standard): Replace
4850         throw_exception with throw.
4851         * dwarf2loc.c (call_site_find_chain)
4852         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4853         Replace throw_exception with throw.
4854         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4855         with throw.
4856         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4857         throw.
4858         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4859         * completer.c (complete_line_internal): Replace throw_exception
4860         with throw.
4861         * compile/compile-object-run.c (compile_object_run): Replace
4862         throw_exception with throw.
4863         * cli/cli-script.c (process_next_line): Replace throw_exception
4864         with throw.
4865         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4866         (btrace_enable, btrace_maint_update_pt_packets): Replace
4867         throw_exception with throw.
4868         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4869         throw_exception with throw.
4870         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4871         throw_exception with throw.
4872         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4873         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4874         * aarch64-tdep.c (aarch64_make_prologue_cache)
4875         (aarch64_make_stub_cache): Replace throw_exception with throw.
4876
4877 2019-04-08  Tom Tromey  <tom@tromey.com>
4878
4879         * common/common-exceptions.c (throw_exception): Rename from
4880         throw_exception_cxx.  Remove old copy.  Make argument const.
4881         (throw_it): Create and throw exception objects directly.
4882         * common/common-exceptions.h (throw_exception): Make argument
4883         const.
4884         (struct gdb_exception_error): Add constructor.
4885         (struct gdb_exception_quit): Add constructor.
4886
4887 2019-04-08  Tom Tromey  <tom@tromey.com>
4888
4889         * common/common-exceptions.h (exception_rethrow): Don't declare.
4890         (TRY_SJLJ): Update comment.
4891         (TRY, CATCH, END_CATCH): Remove.
4892         * common/common-exceptions.c (exception_rethrow): Remove.
4893
4894 2019-04-08  Tom Tromey  <tom@tromey.com>
4895
4896         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4897         Remove.
4898         (gdb_exception_error): Rename from
4899         gdb_exception_RETURN_MASK_ERROR.
4900         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4901         (gdb_quit_bad_alloc): Update.
4902         * aarch64-tdep.c: Update.
4903         * ada-lang.c: Update.
4904         * ada-typeprint.c: Update.
4905         * ada-valprint.c: Update.
4906         * amd64-tdep.c: Update.
4907         * arch-utils.c: Update.
4908         * break-catch-throw.c: Update.
4909         * breakpoint.c: Update.
4910         * btrace.c: Update.
4911         * c-varobj.c: Update.
4912         * cli/cli-cmds.c: Update.
4913         * cli/cli-interp.c: Update.
4914         * cli/cli-script.c: Update.
4915         * common/common-exceptions.c: Update.
4916         * common/new-op.c: Update.
4917         * common/selftest.c: Update.
4918         * compile/compile-c-symbols.c: Update.
4919         * compile/compile-cplus-symbols.c: Update.
4920         * compile/compile-object-load.c: Update.
4921         * compile/compile-object-run.c: Update.
4922         * completer.c: Update.
4923         * corelow.c: Update.
4924         * cp-abi.c: Update.
4925         * cp-support.c: Update.
4926         * cp-valprint.c: Update.
4927         * darwin-nat.c: Update.
4928         * disasm-selftests.c: Update.
4929         * dtrace-probe.c: Update.
4930         * dwarf-index-cache.c: Update.
4931         * dwarf-index-write.c: Update.
4932         * dwarf2-frame-tailcall.c: Update.
4933         * dwarf2-frame.c: Update.
4934         * dwarf2loc.c: Update.
4935         * dwarf2read.c: Update.
4936         * eval.c: Update.
4937         * event-loop.c: Update.
4938         * event-top.c: Update.
4939         * exec.c: Update.
4940         * f-valprint.c: Update.
4941         * fbsd-tdep.c: Update.
4942         * frame-unwind.c: Update.
4943         * frame.c: Update.
4944         * gdbtypes.c: Update.
4945         * gnu-v3-abi.c: Update.
4946         * guile/guile-internal.h: Update.
4947         * guile/scm-block.c: Update.
4948         * guile/scm-breakpoint.c: Update.
4949         * guile/scm-cmd.c: Update.
4950         * guile/scm-disasm.c: Update.
4951         * guile/scm-frame.c: Update.
4952         * guile/scm-lazy-string.c: Update.
4953         * guile/scm-math.c: Update.
4954         * guile/scm-param.c: Update.
4955         * guile/scm-ports.c: Update.
4956         * guile/scm-pretty-print.c: Update.
4957         * guile/scm-symbol.c: Update.
4958         * guile/scm-symtab.c: Update.
4959         * guile/scm-type.c: Update.
4960         * guile/scm-value.c: Update.
4961         * i386-linux-tdep.c: Update.
4962         * i386-tdep.c: Update.
4963         * inf-loop.c: Update.
4964         * infcall.c: Update.
4965         * infcmd.c: Update.
4966         * infrun.c: Update.
4967         * jit.c: Update.
4968         * language.c: Update.
4969         * linespec.c: Update.
4970         * linux-fork.c: Update.
4971         * linux-nat.c: Update.
4972         * linux-tdep.c: Update.
4973         * linux-thread-db.c: Update.
4974         * main.c: Update.
4975         * mi/mi-cmd-break.c: Update.
4976         * mi/mi-cmd-stack.c: Update.
4977         * mi/mi-interp.c: Update.
4978         * mi/mi-main.c: Update.
4979         * objc-lang.c: Update.
4980         * p-valprint.c: Update.
4981         * parse.c: Update.
4982         * ppc-linux-tdep.c: Update.
4983         * printcmd.c: Update.
4984         * python/py-arch.c: Update.
4985         * python/py-breakpoint.c: Update.
4986         * python/py-cmd.c: Update.
4987         * python/py-finishbreakpoint.c: Update.
4988         * python/py-frame.c: Update.
4989         * python/py-framefilter.c: Update.
4990         * python/py-gdb-readline.c: Update.
4991         * python/py-inferior.c: Update.
4992         * python/py-infthread.c: Update.
4993         * python/py-lazy-string.c: Update.
4994         * python/py-linetable.c: Update.
4995         * python/py-objfile.c: Update.
4996         * python/py-param.c: Update.
4997         * python/py-prettyprint.c: Update.
4998         * python/py-progspace.c: Update.
4999         * python/py-record-btrace.c: Update.
5000         * python/py-record.c: Update.
5001         * python/py-symbol.c: Update.
5002         * python/py-type.c: Update.
5003         * python/py-unwind.c: Update.
5004         * python/py-utils.c: Update.
5005         * python/py-value.c: Update.
5006         * python/python.c: Update.
5007         * record-btrace.c: Update.
5008         * record-full.c: Update.
5009         * remote-fileio.c: Update.
5010         * remote.c: Update.
5011         * riscv-tdep.c: Update.
5012         * rs6000-aix-tdep.c: Update.
5013         * rs6000-tdep.c: Update.
5014         * rust-exp.y: Update.
5015         * rust-lang.c: Update.
5016         * s390-tdep.c: Update.
5017         * selftest-arch.c: Update.
5018         * solib-dsbt.c: Update.
5019         * solib-frv.c: Update.
5020         * solib-spu.c: Update.
5021         * solib-svr4.c: Update.
5022         * solib.c: Update.
5023         * sparc64-linux-tdep.c: Update.
5024         * stack.c: Update.
5025         * symfile-mem.c: Update.
5026         * symmisc.c: Update.
5027         * target.c: Update.
5028         * thread.c: Update.
5029         * top.c: Update.
5030         * tracefile-tfile.c: Update.
5031         * tui/tui.c: Update.
5032         * typeprint.c: Update.
5033         * unittests/cli-utils-selftests.c: Update.
5034         * unittests/parse-connection-spec-selftests.c: Update.
5035         * valops.c: Update.
5036         * valprint.c: Update.
5037         * value.c: Update.
5038         * varobj.c: Update.
5039         * windows-nat.c: Update.
5040         * x86-linux-nat.c: Update.
5041         * xml-support.c: Update.
5042
5043 2019-04-08  Tom Tromey  <tom@tromey.com>
5044
5045         * xml-support.c: Use C++ exception handling.
5046         * x86-linux-nat.c: Use C++ exception handling.
5047         * windows-nat.c: Use C++ exception handling.
5048         * varobj.c: Use C++ exception handling.
5049         * value.c: Use C++ exception handling.
5050         * valprint.c: Use C++ exception handling.
5051         * valops.c: Use C++ exception handling.
5052         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5053         handling.
5054         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5055         * typeprint.c: Use C++ exception handling.
5056         * tui/tui.c: Use C++ exception handling.
5057         * tracefile-tfile.c: Use C++ exception handling.
5058         * top.c: Use C++ exception handling.
5059         * thread.c: Use C++ exception handling.
5060         * target.c: Use C++ exception handling.
5061         * symmisc.c: Use C++ exception handling.
5062         * symfile-mem.c: Use C++ exception handling.
5063         * stack.c: Use C++ exception handling.
5064         * sparc64-linux-tdep.c: Use C++ exception handling.
5065         * solib.c: Use C++ exception handling.
5066         * solib-svr4.c: Use C++ exception handling.
5067         * solib-spu.c: Use C++ exception handling.
5068         * solib-frv.c: Use C++ exception handling.
5069         * solib-dsbt.c: Use C++ exception handling.
5070         * selftest-arch.c: Use C++ exception handling.
5071         * s390-tdep.c: Use C++ exception handling.
5072         * rust-lang.c: Use C++ exception handling.
5073         * rust-exp.y: Use C++ exception handling.
5074         * rs6000-tdep.c: Use C++ exception handling.
5075         * rs6000-aix-tdep.c: Use C++ exception handling.
5076         * riscv-tdep.c: Use C++ exception handling.
5077         * remote.c: Use C++ exception handling.
5078         * remote-fileio.c: Use C++ exception handling.
5079         * record-full.c: Use C++ exception handling.
5080         * record-btrace.c: Use C++ exception handling.
5081         * python/python.c: Use C++ exception handling.
5082         * python/py-value.c: Use C++ exception handling.
5083         * python/py-utils.c: Use C++ exception handling.
5084         * python/py-unwind.c: Use C++ exception handling.
5085         * python/py-type.c: Use C++ exception handling.
5086         * python/py-symbol.c: Use C++ exception handling.
5087         * python/py-record.c: Use C++ exception handling.
5088         * python/py-record-btrace.c: Use C++ exception handling.
5089         * python/py-progspace.c: Use C++ exception handling.
5090         * python/py-prettyprint.c: Use C++ exception handling.
5091         * python/py-param.c: Use C++ exception handling.
5092         * python/py-objfile.c: Use C++ exception handling.
5093         * python/py-linetable.c: Use C++ exception handling.
5094         * python/py-lazy-string.c: Use C++ exception handling.
5095         * python/py-infthread.c: Use C++ exception handling.
5096         * python/py-inferior.c: Use C++ exception handling.
5097         * python/py-gdb-readline.c: Use C++ exception handling.
5098         * python/py-framefilter.c: Use C++ exception handling.
5099         * python/py-frame.c: Use C++ exception handling.
5100         * python/py-finishbreakpoint.c: Use C++ exception handling.
5101         * python/py-cmd.c: Use C++ exception handling.
5102         * python/py-breakpoint.c: Use C++ exception handling.
5103         * python/py-arch.c: Use C++ exception handling.
5104         * printcmd.c: Use C++ exception handling.
5105         * ppc-linux-tdep.c: Use C++ exception handling.
5106         * parse.c: Use C++ exception handling.
5107         * p-valprint.c: Use C++ exception handling.
5108         * objc-lang.c: Use C++ exception handling.
5109         * mi/mi-main.c: Use C++ exception handling.
5110         * mi/mi-interp.c: Use C++ exception handling.
5111         * mi/mi-cmd-stack.c: Use C++ exception handling.
5112         * mi/mi-cmd-break.c: Use C++ exception handling.
5113         * main.c: Use C++ exception handling.
5114         * linux-thread-db.c: Use C++ exception handling.
5115         * linux-tdep.c: Use C++ exception handling.
5116         * linux-nat.c: Use C++ exception handling.
5117         * linux-fork.c: Use C++ exception handling.
5118         * linespec.c: Use C++ exception handling.
5119         * language.c: Use C++ exception handling.
5120         * jit.c: Use C++ exception handling.
5121         * infrun.c: Use C++ exception handling.
5122         * infcmd.c: Use C++ exception handling.
5123         * infcall.c: Use C++ exception handling.
5124         * inf-loop.c: Use C++ exception handling.
5125         * i386-tdep.c: Use C++ exception handling.
5126         * i386-linux-tdep.c: Use C++ exception handling.
5127         * guile/scm-value.c: Use C++ exception handling.
5128         * guile/scm-type.c: Use C++ exception handling.
5129         * guile/scm-symtab.c: Use C++ exception handling.
5130         * guile/scm-symbol.c: Use C++ exception handling.
5131         * guile/scm-pretty-print.c: Use C++ exception handling.
5132         * guile/scm-ports.c: Use C++ exception handling.
5133         * guile/scm-param.c: Use C++ exception handling.
5134         * guile/scm-math.c: Use C++ exception handling.
5135         * guile/scm-lazy-string.c: Use C++ exception handling.
5136         * guile/scm-frame.c: Use C++ exception handling.
5137         * guile/scm-disasm.c: Use C++ exception handling.
5138         * guile/scm-cmd.c: Use C++ exception handling.
5139         * guile/scm-breakpoint.c: Use C++ exception handling.
5140         * guile/scm-block.c: Use C++ exception handling.
5141         * guile/guile-internal.h: Use C++ exception handling.
5142         * gnu-v3-abi.c: Use C++ exception handling.
5143         * gdbtypes.c: Use C++ exception handling.
5144         * frame.c: Use C++ exception handling.
5145         * frame-unwind.c: Use C++ exception handling.
5146         * fbsd-tdep.c: Use C++ exception handling.
5147         * f-valprint.c: Use C++ exception handling.
5148         * exec.c: Use C++ exception handling.
5149         * event-top.c: Use C++ exception handling.
5150         * event-loop.c: Use C++ exception handling.
5151         * eval.c: Use C++ exception handling.
5152         * dwarf2read.c: Use C++ exception handling.
5153         * dwarf2loc.c: Use C++ exception handling.
5154         * dwarf2-frame.c: Use C++ exception handling.
5155         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5156         * dwarf-index-write.c: Use C++ exception handling.
5157         * dwarf-index-cache.c: Use C++ exception handling.
5158         * dtrace-probe.c: Use C++ exception handling.
5159         * disasm-selftests.c: Use C++ exception handling.
5160         * darwin-nat.c: Use C++ exception handling.
5161         * cp-valprint.c: Use C++ exception handling.
5162         * cp-support.c: Use C++ exception handling.
5163         * cp-abi.c: Use C++ exception handling.
5164         * corelow.c: Use C++ exception handling.
5165         * completer.c: Use C++ exception handling.
5166         * compile/compile-object-run.c: Use C++ exception handling.
5167         * compile/compile-object-load.c: Use C++ exception handling.
5168         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5169         * compile/compile-c-symbols.c: Use C++ exception handling.
5170         * common/selftest.c: Use C++ exception handling.
5171         * common/new-op.c: Use C++ exception handling.
5172         * cli/cli-script.c: Use C++ exception handling.
5173         * cli/cli-interp.c: Use C++ exception handling.
5174         * cli/cli-cmds.c: Use C++ exception handling.
5175         * c-varobj.c: Use C++ exception handling.
5176         * btrace.c: Use C++ exception handling.
5177         * breakpoint.c: Use C++ exception handling.
5178         * break-catch-throw.c: Use C++ exception handling.
5179         * arch-utils.c: Use C++ exception handling.
5180         * amd64-tdep.c: Use C++ exception handling.
5181         * ada-valprint.c: Use C++ exception handling.
5182         * ada-typeprint.c: Use C++ exception handling.
5183         * ada-lang.c: Use C++ exception handling.
5184         * aarch64-tdep.c: Use C++ exception handling.
5185
5186 2019-04-08  Tom Tromey  <tom@tromey.com>
5187
5188         * xml-support.c (gdb_xml_parser::parse): Update.
5189         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5190         * value.c (show_convenience): Update.
5191         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5192         (test_parse_flags_qcs): Update.
5193         * thread.c (thr_try_catch_cmd): Update.
5194         * target.c (target_translate_tls_address): Update.
5195         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5196         (info_frame_command_core, frame_apply_command_count): Update.
5197         * rust-exp.y (rust_lex_exception_test): Update.
5198         * riscv-tdep.c (riscv_print_one_register_info): Update.
5199         * remote.c (remote_target::enable_btrace): Update.
5200         * record-btrace.c (record_btrace_enable_warn): Update.
5201         * python/py-utils.c (gdbpy_convert_exception): Update.
5202         * printcmd.c (do_one_display, print_variable_and_value): Update.
5203         * mi/mi-main.c (mi_print_exception): Update.
5204         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5205         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5206         * linux-nat.c (linux_nat_target::attach): Update.
5207         * linux-fork.c (class scoped_switch_fork_info): Update.
5208         * infrun.c (displaced_step_prepare): Update.
5209         * infcall.c (call_function_by_hand_dummy): Update.
5210         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5211         * gnu-v3-abi.c (print_one_vtable): Update.
5212         * frame.c (get_prev_frame_always): Update.
5213         * f-valprint.c (info_common_command_for_block): Update.
5214         * exec.c (try_open_exec_file): Update.
5215         * exceptions.c (print_exception, exception_print)
5216         (exception_fprintf, exception_print_same): Update.
5217         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5218         * dwarf-index-cache.c (index_cache::store)
5219         (index_cache::lookup_gdb_index): Update.
5220         * darwin-nat.c (maybe_cache_shell): Update.
5221         * cp-valprint.c (cp_print_value_fields): Update.
5222         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5223         (gcc_cplus_symbol_address): Update.
5224         * compile/compile-c-symbols.c (gcc_convert_symbol)
5225         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5226         * common/selftest.c: Update.
5227         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5228         a std::string.
5229         (exception_try_scope_entry, exception_try_scope_exit): Don't
5230         declare.
5231         (struct exception_try_scope): Remove.
5232         (TRY): Don't use exception_try_scope.
5233         (struct gdb_exception): Add constructor, operator=.
5234         <what>: New method.
5235         (struct gdb_exception_RETURN_MASK_ALL)
5236         (struct gdb_exception_RETURN_MASK_ERROR)
5237         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5238         (struct gdb_quit_bad_alloc): Update.
5239         * common/common-exceptions.c (exception_none): Change
5240         initializer.
5241         (struct catcher) <state, exception>: Initialize inline.
5242         <prev>: Remove member.
5243         (current_catcher): Remove.
5244         (catchers): New global.
5245         (exceptions_state_mc_init): Simplify.
5246         (catcher_pop): Remove.
5247         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5248         (try_scope_depth, exception_try_scope_entry)
5249         (exception_try_scope_exit): Remove.
5250         (throw_exception_sjlj): Update.
5251         (exception_messages, exception_messages_size): Remove.
5252         (throw_it): Simplify.
5253         (gdb_exception_sliced_copy): Remove.
5254         (throw_exception_cxx): Update.
5255         * cli/cli-script.c (script_from_file): Update.
5256         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5257         Update.
5258         * ada-valprint.c (ada_val_print): Update.
5259         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5260         (create_excep_cond_exprs): Update.
5261
5262 2019-04-08  Tom Tromey  <tom@tromey.com>
5263
5264         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5265         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5266         (TRY, CATCH, END_CATCH): Remove some definitions.
5267         * common/common-exceptions.c: Don't use GDB_XCPT.
5268         (catcher_list_size): Remove.
5269         (throw_exception, throw_it): Simplify.
5270
5271 2019-04-05  Tom Tromey  <tom@tromey.com>
5272
5273         Revert the header-sorting patch.
5274         * ft32-tdep.c: Revert.
5275         * frv-tdep.c: Revert.
5276         * frv-linux-tdep.c: Revert.
5277         * frame.c: Revert.
5278         * frame-unwind.c: Revert.
5279         * frame-base.c: Revert.
5280         * fork-child.c: Revert.
5281         * findvar.c: Revert.
5282         * findcmd.c: Revert.
5283         * filesystem.c: Revert.
5284         * filename-seen-cache.h: Revert.
5285         * filename-seen-cache.c: Revert.
5286         * fbsd-tdep.c: Revert.
5287         * fbsd-nat.h: Revert.
5288         * fbsd-nat.c: Revert.
5289         * f-valprint.c: Revert.
5290         * f-typeprint.c: Revert.
5291         * f-lang.c: Revert.
5292         * extension.h: Revert.
5293         * extension.c: Revert.
5294         * extension-priv.h: Revert.
5295         * expprint.c: Revert.
5296         * exec.h: Revert.
5297         * exec.c: Revert.
5298         * exceptions.c: Revert.
5299         * event-top.c: Revert.
5300         * event-loop.c: Revert.
5301         * eval.c: Revert.
5302         * elfread.c: Revert.
5303         * dwarf2read.h: Revert.
5304         * dwarf2read.c: Revert.
5305         * dwarf2loc.c: Revert.
5306         * dwarf2expr.h: Revert.
5307         * dwarf2expr.c: Revert.
5308         * dwarf2-frame.c: Revert.
5309         * dwarf2-frame-tailcall.c: Revert.
5310         * dwarf-index-write.h: Revert.
5311         * dwarf-index-write.c: Revert.
5312         * dwarf-index-common.c: Revert.
5313         * dwarf-index-cache.h: Revert.
5314         * dwarf-index-cache.c: Revert.
5315         * dummy-frame.c: Revert.
5316         * dtrace-probe.c: Revert.
5317         * disasm.h: Revert.
5318         * disasm.c: Revert.
5319         * disasm-selftests.c: Revert.
5320         * dictionary.c: Revert.
5321         * dicos-tdep.c: Revert.
5322         * demangle.c: Revert.
5323         * dcache.h: Revert.
5324         * dcache.c: Revert.
5325         * darwin-nat.h: Revert.
5326         * darwin-nat.c: Revert.
5327         * darwin-nat-info.c: Revert.
5328         * d-valprint.c: Revert.
5329         * d-namespace.c: Revert.
5330         * d-lang.c: Revert.
5331         * ctf.c: Revert.
5332         * csky-tdep.c: Revert.
5333         * csky-linux-tdep.c: Revert.
5334         * cris-tdep.c: Revert.
5335         * cris-linux-tdep.c: Revert.
5336         * cp-valprint.c: Revert.
5337         * cp-support.c: Revert.
5338         * cp-namespace.c: Revert.
5339         * cp-abi.c: Revert.
5340         * corelow.c: Revert.
5341         * corefile.c: Revert.
5342         * continuations.c: Revert.
5343         * completer.h: Revert.
5344         * completer.c: Revert.
5345         * complaints.c: Revert.
5346         * coffread.c: Revert.
5347         * coff-pe-read.c: Revert.
5348         * cli-out.h: Revert.
5349         * cli-out.c: Revert.
5350         * charset.c: Revert.
5351         * c-varobj.c: Revert.
5352         * c-valprint.c: Revert.
5353         * c-typeprint.c: Revert.
5354         * c-lang.c: Revert.
5355         * buildsym.c: Revert.
5356         * buildsym-legacy.c: Revert.
5357         * build-id.h: Revert.
5358         * build-id.c: Revert.
5359         * btrace.c: Revert.
5360         * bsd-uthread.c: Revert.
5361         * breakpoint.h: Revert.
5362         * breakpoint.c: Revert.
5363         * break-catch-throw.c: Revert.
5364         * break-catch-syscall.c: Revert.
5365         * break-catch-sig.c: Revert.
5366         * blockframe.c: Revert.
5367         * block.c: Revert.
5368         * bfin-tdep.c: Revert.
5369         * bfin-linux-tdep.c: Revert.
5370         * bfd-target.c: Revert.
5371         * bcache.c: Revert.
5372         * ax-general.c: Revert.
5373         * ax-gdb.h: Revert.
5374         * ax-gdb.c: Revert.
5375         * avr-tdep.c: Revert.
5376         * auxv.c: Revert.
5377         * auto-load.c: Revert.
5378         * arm-wince-tdep.c: Revert.
5379         * arm-tdep.c: Revert.
5380         * arm-symbian-tdep.c: Revert.
5381         * arm-pikeos-tdep.c: Revert.
5382         * arm-obsd-tdep.c: Revert.
5383         * arm-nbsd-tdep.c: Revert.
5384         * arm-nbsd-nat.c: Revert.
5385         * arm-linux-tdep.c: Revert.
5386         * arm-linux-nat.c: Revert.
5387         * arm-fbsd-tdep.c: Revert.
5388         * arm-fbsd-nat.c: Revert.
5389         * arm-bsd-tdep.c: Revert.
5390         * arch-utils.c: Revert.
5391         * arc-tdep.c: Revert.
5392         * arc-newlib-tdep.c: Revert.
5393         * annotate.h: Revert.
5394         * annotate.c: Revert.
5395         * amd64-windows-tdep.c: Revert.
5396         * amd64-windows-nat.c: Revert.
5397         * amd64-tdep.c: Revert.
5398         * amd64-sol2-tdep.c: Revert.
5399         * amd64-obsd-tdep.c: Revert.
5400         * amd64-obsd-nat.c: Revert.
5401         * amd64-nbsd-tdep.c: Revert.
5402         * amd64-nbsd-nat.c: Revert.
5403         * amd64-nat.c: Revert.
5404         * amd64-linux-tdep.c: Revert.
5405         * amd64-linux-nat.c: Revert.
5406         * amd64-fbsd-tdep.c: Revert.
5407         * amd64-fbsd-nat.c: Revert.
5408         * amd64-dicos-tdep.c: Revert.
5409         * amd64-darwin-tdep.c: Revert.
5410         * amd64-bsd-nat.c: Revert.
5411         * alpha-tdep.c: Revert.
5412         * alpha-obsd-tdep.c: Revert.
5413         * alpha-nbsd-tdep.c: Revert.
5414         * alpha-mdebug-tdep.c: Revert.
5415         * alpha-linux-tdep.c: Revert.
5416         * alpha-linux-nat.c: Revert.
5417         * alpha-bsd-tdep.c: Revert.
5418         * alpha-bsd-nat.c: Revert.
5419         * aix-thread.c: Revert.
5420         * agent.c: Revert.
5421         * addrmap.c: Revert.
5422         * ada-varobj.c: Revert.
5423         * ada-valprint.c: Revert.
5424         * ada-typeprint.c: Revert.
5425         * ada-tasks.c: Revert.
5426         * ada-lang.c: Revert.
5427         * aarch64-tdep.c: Revert.
5428         * aarch64-ravenscar-thread.c: Revert.
5429         * aarch64-newlib-tdep.c: Revert.
5430         * aarch64-linux-tdep.c: Revert.
5431         * aarch64-linux-nat.c: Revert.
5432         * aarch64-fbsd-tdep.c: Revert.
5433         * aarch64-fbsd-nat.c: Revert.
5434         * aarch32-linux-nat.c: Revert.
5435
5436 2019-04-05  Tom Tromey  <tom@tromey.com>
5437
5438         * ft32-tdep.c: Sort headers.
5439         * frv-tdep.c: Sort headers.
5440         * frv-linux-tdep.c: Sort headers.
5441         * frame.c: Sort headers.
5442         * frame-unwind.c: Sort headers.
5443         * frame-base.c: Sort headers.
5444         * fork-child.c: Sort headers.
5445         * findvar.c: Sort headers.
5446         * findcmd.c: Sort headers.
5447         * filesystem.c: Sort headers.
5448         * filename-seen-cache.h: Sort headers.
5449         * filename-seen-cache.c: Sort headers.
5450         * fbsd-tdep.c: Sort headers.
5451         * fbsd-nat.h: Sort headers.
5452         * fbsd-nat.c: Sort headers.
5453         * f-valprint.c: Sort headers.
5454         * f-typeprint.c: Sort headers.
5455         * f-lang.c: Sort headers.
5456         * extension.h: Sort headers.
5457         * extension.c: Sort headers.
5458         * extension-priv.h: Sort headers.
5459         * expprint.c: Sort headers.
5460         * exec.h: Sort headers.
5461         * exec.c: Sort headers.
5462         * exceptions.c: Sort headers.
5463         * event-top.c: Sort headers.
5464         * event-loop.c: Sort headers.
5465         * eval.c: Sort headers.
5466         * elfread.c: Sort headers.
5467         * dwarf2read.h: Sort headers.
5468         * dwarf2read.c: Sort headers.
5469         * dwarf2loc.c: Sort headers.
5470         * dwarf2expr.h: Sort headers.
5471         * dwarf2expr.c: Sort headers.
5472         * dwarf2-frame.c: Sort headers.
5473         * dwarf2-frame-tailcall.c: Sort headers.
5474         * dwarf-index-write.h: Sort headers.
5475         * dwarf-index-write.c: Sort headers.
5476         * dwarf-index-common.c: Sort headers.
5477         * dwarf-index-cache.h: Sort headers.
5478         * dwarf-index-cache.c: Sort headers.
5479         * dummy-frame.c: Sort headers.
5480         * dtrace-probe.c: Sort headers.
5481         * disasm.h: Sort headers.
5482         * disasm.c: Sort headers.
5483         * disasm-selftests.c: Sort headers.
5484         * dictionary.c: Sort headers.
5485         * dicos-tdep.c: Sort headers.
5486         * demangle.c: Sort headers.
5487         * dcache.h: Sort headers.
5488         * dcache.c: Sort headers.
5489         * darwin-nat.h: Sort headers.
5490         * darwin-nat.c: Sort headers.
5491         * darwin-nat-info.c: Sort headers.
5492         * d-valprint.c: Sort headers.
5493         * d-namespace.c: Sort headers.
5494         * d-lang.c: Sort headers.
5495         * ctf.c: Sort headers.
5496         * csky-tdep.c: Sort headers.
5497         * csky-linux-tdep.c: Sort headers.
5498         * cris-tdep.c: Sort headers.
5499         * cris-linux-tdep.c: Sort headers.
5500         * cp-valprint.c: Sort headers.
5501         * cp-support.c: Sort headers.
5502         * cp-namespace.c: Sort headers.
5503         * cp-abi.c: Sort headers.
5504         * corelow.c: Sort headers.
5505         * corefile.c: Sort headers.
5506         * continuations.c: Sort headers.
5507         * completer.h: Sort headers.
5508         * completer.c: Sort headers.
5509         * complaints.c: Sort headers.
5510         * coffread.c: Sort headers.
5511         * coff-pe-read.c: Sort headers.
5512         * cli-out.h: Sort headers.
5513         * cli-out.c: Sort headers.
5514         * charset.c: Sort headers.
5515         * c-varobj.c: Sort headers.
5516         * c-valprint.c: Sort headers.
5517         * c-typeprint.c: Sort headers.
5518         * c-lang.c: Sort headers.
5519         * buildsym.c: Sort headers.
5520         * buildsym-legacy.c: Sort headers.
5521         * build-id.h: Sort headers.
5522         * build-id.c: Sort headers.
5523         * btrace.c: Sort headers.
5524         * bsd-uthread.c: Sort headers.
5525         * breakpoint.h: Sort headers.
5526         * breakpoint.c: Sort headers.
5527         * break-catch-throw.c: Sort headers.
5528         * break-catch-syscall.c: Sort headers.
5529         * break-catch-sig.c: Sort headers.
5530         * blockframe.c: Sort headers.
5531         * block.c: Sort headers.
5532         * bfin-tdep.c: Sort headers.
5533         * bfin-linux-tdep.c: Sort headers.
5534         * bfd-target.c: Sort headers.
5535         * bcache.c: Sort headers.
5536         * ax-general.c: Sort headers.
5537         * ax-gdb.h: Sort headers.
5538         * ax-gdb.c: Sort headers.
5539         * avr-tdep.c: Sort headers.
5540         * auxv.c: Sort headers.
5541         * auto-load.c: Sort headers.
5542         * arm-wince-tdep.c: Sort headers.
5543         * arm-tdep.c: Sort headers.
5544         * arm-symbian-tdep.c: Sort headers.
5545         * arm-pikeos-tdep.c: Sort headers.
5546         * arm-obsd-tdep.c: Sort headers.
5547         * arm-nbsd-tdep.c: Sort headers.
5548         * arm-nbsd-nat.c: Sort headers.
5549         * arm-linux-tdep.c: Sort headers.
5550         * arm-linux-nat.c: Sort headers.
5551         * arm-fbsd-tdep.c: Sort headers.
5552         * arm-fbsd-nat.c: Sort headers.
5553         * arm-bsd-tdep.c: Sort headers.
5554         * arch-utils.c: Sort headers.
5555         * arc-tdep.c: Sort headers.
5556         * arc-newlib-tdep.c: Sort headers.
5557         * annotate.h: Sort headers.
5558         * annotate.c: Sort headers.
5559         * amd64-windows-tdep.c: Sort headers.
5560         * amd64-windows-nat.c: Sort headers.
5561         * amd64-tdep.c: Sort headers.
5562         * amd64-sol2-tdep.c: Sort headers.
5563         * amd64-obsd-tdep.c: Sort headers.
5564         * amd64-obsd-nat.c: Sort headers.
5565         * amd64-nbsd-tdep.c: Sort headers.
5566         * amd64-nbsd-nat.c: Sort headers.
5567         * amd64-nat.c: Sort headers.
5568         * amd64-linux-tdep.c: Sort headers.
5569         * amd64-linux-nat.c: Sort headers.
5570         * amd64-fbsd-tdep.c: Sort headers.
5571         * amd64-fbsd-nat.c: Sort headers.
5572         * amd64-dicos-tdep.c: Sort headers.
5573         * amd64-darwin-tdep.c: Sort headers.
5574         * amd64-bsd-nat.c: Sort headers.
5575         * alpha-tdep.c: Sort headers.
5576         * alpha-obsd-tdep.c: Sort headers.
5577         * alpha-nbsd-tdep.c: Sort headers.
5578         * alpha-mdebug-tdep.c: Sort headers.
5579         * alpha-linux-tdep.c: Sort headers.
5580         * alpha-linux-nat.c: Sort headers.
5581         * alpha-bsd-tdep.c: Sort headers.
5582         * alpha-bsd-nat.c: Sort headers.
5583         * aix-thread.c: Sort headers.
5584         * agent.c: Sort headers.
5585         * addrmap.c: Sort headers.
5586         * ada-varobj.c: Sort headers.
5587         * ada-valprint.c: Sort headers.
5588         * ada-typeprint.c: Sort headers.
5589         * ada-tasks.c: Sort headers.
5590         * ada-lang.c: Sort headers.
5591         * aarch64-tdep.c: Sort headers.
5592         * aarch64-ravenscar-thread.c: Sort headers.
5593         * aarch64-newlib-tdep.c: Sort headers.
5594         * aarch64-linux-tdep.c: Sort headers.
5595         * aarch64-linux-nat.c: Sort headers.
5596         * aarch64-fbsd-tdep.c: Sort headers.
5597         * aarch64-fbsd-nat.c: Sort headers.
5598         * aarch32-linux-nat.c: Sort headers.
5599
5600 2019-04-04  Tom Tromey  <tom@tromey.com>
5601
5602         * varobj.c (varobj_create): Update.
5603         * rust-exp.y (struct rust_parser) <update_innermost_block,
5604         lookup_symbol>: New methods.
5605         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5606         Rename.
5607         (rust_parser::rust_lookup_type)
5608         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5609         * printcmd.c (display_command, do_one_display): Update.
5610         * parser-defs.h (struct parser_state) <parser_state>: Add
5611         "tracker" parameter.
5612         (block_tracker): New member.
5613         (class innermost_block_tracker) <innermost_block_tracker>: Add
5614         "types" parameter.
5615         <reset>: Remove method.
5616         (innermost_block): Don't declare.
5617         (null_post_parser): Update.
5618         * parse.c (innermost_block): Remove global.
5619         (write_dollar_variable): Update.
5620         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5621         Remove "tracker_types" parameter.
5622         (parse_expression): Add "tracker" parameter.
5623         (parse_expression_for_completion): Update.
5624         (null_post_parser): Add "tracker" parameter.
5625         * p-exp.y: Update rules.
5626         * m2-exp.y: Update rules.
5627         * language.h (struct language_defn) <la_post_parser>: Add
5628         "tracker" parameter.
5629         * go-exp.y: Update rules.
5630         * f-exp.y: Update rules.
5631         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5632         parameter.
5633         * d-exp.y: Update rules.
5634         * c-exp.y: Update rules.
5635         * breakpoint.c (set_breakpoint_condition): Create an
5636         innermost_block_tracker.
5637         (watch_command_1): Likewise.
5638         * ada-lang.c (resolve): Add "tracker" parameter.
5639         (resolve_subexp): Likewise.
5640         * ada-exp.y (write_var_from_sym): Update.
5641
5642 2019-04-04  Tom Tromey  <tom@tromey.com>
5643
5644         * type-stack.h: New file.
5645         * type-stack.c: New file.
5646         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5647         type-stack.h.
5648         (insert_into_type_stack, insert_type, push_type, push_type_int)
5649         (insert_type_address_space, pop_type, pop_type_int)
5650         (pop_typelist, pop_type_stack, append_type_stack)
5651         (push_type_stack, get_type_stack, push_typelist)
5652         (follow_type_instance_flags, follow_types): Don't declare.
5653         * parse.c (type_stack): Remove global.
5654         (parse_exp_in_context): Update.
5655         (insert_into_type_stack, insert_type, push_type, push_type_int)
5656         (insert_type_address_space, pop_type, pop_type_int)
5657         (pop_typelist, pop_type_stack, append_type_stack)
5658         (push_type_stack, get_type_stack, push_typelist)
5659         (follow_type_instance_flags, follow_types): Remove (moved to
5660         type-stack.c).
5661         * f-exp.y (type_stack): New global.
5662         Update rules.
5663         (push_kind_type, f_parse): Update.
5664         * d-exp.y (type_stack): New global.
5665         Update rules.
5666         (d_parse): Update.
5667         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5668         Update rules.
5669         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5670         (HFILES_NO_SRCDIR): Add type-stack.h.
5671
5672 2019-04-04  Tom Tromey  <tom@tromey.com>
5673
5674         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5675         (rust_parser::convert_ast_to_expression, rust_parse)
5676         (rust_lex_test_completion, rust_lex_tests): Update.
5677         * parser-defs.h (struct expr_completion_state): New.
5678         (struct parser_state) <parser_state>: Add completion parameter.
5679         <mark_struct_expression, mark_completion_tag>: New methods.
5680         <parse_completion, m_completion_state>: New members.
5681         (prefixify_expression, null_post_parser): Update.
5682         (mark_struct_expression, mark_completion_tag): Don't declare.
5683         * parse.c (parse_completion, expout_last_struct)
5684         (expout_tag_completion_type, expout_completion_name): Remove
5685         globals.
5686         (parser_state::mark_struct_expression)
5687         (parser_state::mark_completion_tag): Now methods.
5688         (prefixify_expression): Add last_struct parameter.
5689         (prefixify_subexp): Likewise.
5690         (parse_exp_1): Update.
5691         (parse_exp_in_context): Add cstate parameter.  Update.
5692         (parse_expression_for_completion): Create an
5693         expr_completion_state.
5694         (null_post_parser): Add "completion" parameter.
5695         * p-exp.y: Update rules.
5696         (yylex): Update.
5697         * language.h (struct language_defn) <la_post_parser>: Add
5698         "completing" parameter.
5699         * go-exp.y: Update rules.
5700         (lex_one_token): Update.
5701         * expression.h (parse_completion): Don't declare.
5702         * d-exp.y: Update rules.
5703         (lex_one_token): Update rules.
5704         * c-exp.y: Update rules.
5705         (lex_one_token): Update.
5706         * ada-lang.c (resolve): Add "parse_completion" parameter.
5707         (resolve_subexp): Likewise.
5708         (ada_resolve_function): Likewise.
5709
5710 2019-04-04  Tom Tromey  <tom@tromey.com>
5711
5712         * parser-defs.h (struct parser_state) <start_arglist,
5713         end_arglist>: New methods.
5714         <arglist_len, m_funcall_chain>: New members.
5715         (arglist_len, start_arglist, end_arglist): Don't declare.
5716         * parse.c (arglist_len, funcall_chain): Remove global.
5717         (start_arglist, end_arglist): Remove functions.
5718         (parse_exp_in_context): Update.
5719         * p-exp.y: Update rules.
5720         * m2-exp.y: Update rules.
5721         * go-exp.y: Update rules.
5722         * f-exp.y: Update rules.
5723         * d-exp.y: Update rules.
5724         * c-exp.y: Update rules.
5725
5726 2019-04-04  Tom Tromey  <tom@tromey.com>
5727
5728         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5729         lex_operator, push_back>: New methods.
5730         Update all rules.
5731         (rust_parser::lex_hex, lex_escape): Rename and update.
5732         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5733         (rust_parser::lex_operator): Rename and update.
5734         (rust_parser::lex_number, rustyylex, rustyyerror)
5735         (rust_lex_test_init, rust_lex_test_sequence)
5736         (rust_lex_test_push_back, rust_lex_tests): Update.
5737         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5738         parameter.
5739         <lexptr, prev_lexptr>: New members.
5740         (lexptr, prev_lexptr): Don't declare.
5741         * parse.c (lexptr, prev_lexptr): Remove globals.
5742         (parse_exp_in_context): Update.
5743         * p-exp.y (yylex, yyerror): Update.
5744         * m2-exp.y (parse_number, yylex, yyerror): Update.
5745         * go-exp.y (lex_one_token, yyerror): Update.
5746         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5747         * d-exp.y (lex_one_token, yyerror): Update.
5748         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5749         (lex_one_token, yyerror): Update.
5750         * ada-lex.l (YY_INPUT): Update.
5751         (rewind_to_char): Update.
5752         * ada-exp.y (yyerror): Update.
5753
5754 2019-04-04  Tom Tromey  <tom@tromey.com>
5755
5756         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5757         * parser-defs.h (struct parser_state) <parser_state>: Add new
5758         parameter.
5759         <comma_terminates>: New member.
5760         (comma_terminates): Don't declare global.
5761         * parse.c (comma_terminates): Remove global.
5762         (parse_exp_in_context): Update.
5763         * p-exp.y (yylex): Update.
5764         * m2-exp.y (yylex): Update.
5765         * go-exp.y (lex_one_token): Update.
5766         * f-exp.y (yylex): Update.
5767         * d-exp.y (lex_one_token): Update.
5768         * c-exp.y (lex_one_token): Update.
5769         * ada-lex.l: Update.
5770
5771 2019-04-04  Tom Tromey  <tom@tromey.com>
5772
5773         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5774         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5775         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5776         * parser-defs.h (paren_depth): Don't declare.
5777         * parse.c (paren_depth): Remove global.
5778         (parse_exp_in_context): Update.
5779         * p-exp.y (paren_depth): New global.
5780         (pascal_parse): Initialize it.
5781         * m2-exp.y (paren_depth): New global.
5782         (m2_parse): Initialize it.
5783         * go-exp.y (paren_depth): New global.
5784         (go_parse): Initialize it.
5785         * f-exp.y (paren_depth): New global.
5786         (f_parse): Initialize it.
5787         * d-exp.y (paren_depth): New global.
5788         (d_parse): Initialize it.
5789         * c-exp.y (paren_depth): New global.
5790         (c_parse): Initialize it.
5791         * ada-lex.l (paren_depth): New global.
5792         (lexer_init): Initialize it.
5793
5794 2019-04-04  Tom Tromey  <tom@tromey.com>
5795
5796         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5797         (rust_parser::convert_ast_to_type)
5798         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5799         * parser-defs.h (struct parser_state) <parser_state>: Add
5800         parameters.  Initialize new members.
5801         <expression_context_block, expression_context_pc>: New members.
5802         * parse.c (expression_context_block, expression_context_pc):
5803         Remove globals.
5804         (parse_exp_in_context): Update.
5805         * p-exp.y: Update all rules.
5806         (yylex): Update.
5807         * m2-exp.y: Update all rules.
5808         (yylex): Update.
5809         * go-exp.y (yylex): Update.
5810         * f-exp.y (yylex): Update.
5811         * d-exp.y: Update all rules.
5812         (yylex): Update.
5813         * c-exp.y: Update all rules.
5814         (lex_one_token, classify_name, yylex, c_parse): Update.
5815         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5816
5817 2019-04-04  Tom Tromey  <tom@tromey.com>
5818
5819         * gdbarch.h, gdbarch.c: Rebuild.
5820         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5821         * stap-probe.h:
5822         (struct stap_parse_info): Replace "parser_state" with
5823         "expr_builder".
5824         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5825         (parser_state): New class.
5826         * parse.c (expr_builder): Rename.
5827         (expr_builder::release): Rename.
5828         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5829         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5830         (write_exp_elt_longcst, write_exp_elt_floatcst)
5831         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5832         (write_exp_string_vector, write_exp_bitstring)
5833         (write_exp_msymbol, mark_struct_expression)
5834         (write_dollar_variable)
5835         (insert_type_address_space, increase_expout_size): Replace
5836         "parser_state" with "expr_builder".
5837         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5838         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5839         "parser_state" with "expr_builder".
5840
5841 2019-04-04  Tom Tromey  <tom@tromey.com>
5842
5843         * rust-exp.y: Replace "parse_language" with method call.
5844         * p-exp.y:
5845         (yylex): Replace "parse_language" with method call.
5846         * m2-exp.y:
5847         (yylex): Replace "parse_language" with method call.
5848         * go-exp.y (classify_name): Replace "parse_language" with method
5849         call.
5850         * f-exp.y (yylex): Replace "parse_language" with method call.
5851         * d-exp.y (lex_one_token): Replace "parse_language" with method
5852         call.
5853         * c-exp.y:
5854         (lex_one_token, classify_name, yylex): Replace "parse_language"
5855         with method call.
5856         * ada-exp.y (find_primitive_type, type_char)
5857         (type_system_address): Replace "parse_language" with method call.
5858
5859 2019-04-04  Tom Tromey  <tom@tromey.com>
5860
5861         * rust-exp.y: Replace "parse_gdbarch" with method call.
5862         * parse.c (write_dollar_variable, insert_type_address_space):
5863         Replace "parse_gdbarch" with method call.
5864         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5865         call.
5866         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5867         call.
5868         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5869         "parse_gdbarch" with method call.
5870         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5871         with method call.
5872         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5873         "parse_gdbarch" with method call.
5874         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5875         "parse_gdbarch" with method call.
5876         * c-exp.y (parse_type, parse_number, classify_name): Replace
5877         "parse_gdbarch" with method call.
5878         * ada-lex.l: Replace "parse_gdbarch" with method call.
5879         * ada-exp.y (parse_type, find_primitive_type, type_char)
5880         (type_system_address): Replace "parse_gdbarch" with method call.
5881
5882 2019-04-04  Tom Tromey  <tom@tromey.com>
5883
5884         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5885         * stap-probe.c (stap_parse_argument): Update.
5886         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5887         initial_size parameter.
5888         * rust-exp.y (rust_lex_tests): Update.
5889         * parse.c (parser_state): Update.
5890         (parse_exp_in_context): Update.
5891         * parser-defs.h (struct parser_state) <parser_state>: Remove
5892         "initial_size" parameter.
5893
5894 2019-04-04  Tom Tromey  <tom@tromey.com>
5895
5896         * parser-defs.h (increase_expout_size): Don't declare.
5897         * parse.c (increase_expout_size): Now static.
5898
5899 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5900
5901         * gnu-nat.c (gnu_nat_target::wait): Fix
5902         target_waitstatus_to_string call.
5903
5904 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5905
5906         * eval.c (evaluate_subexp_standard): Handle internal functions
5907         during Fortran function call handling.
5908
5909 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5910
5911         * NEWS: Mention new internal functions.
5912         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5913         (read_base_type): Use dwarf2_init_complex_target_type.
5914         * value.c (creal_internal_fn): New function.
5915         (cimag_internal_fn): New function.
5916         (_initialize_values): Register new internal functions.
5917
5918 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5919
5920         * infrun.c (stop_all_threads): If debug_infrun, always
5921         trace the wait status after wait_one, using
5922         target_waitstatus_to_string and target_pid_to_str.
5923         (handle_inferior_event): Replace various trace of
5924         wait status kind by a single trace.
5925         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5926         wait status kind image by target_waitstatus_to_string.
5927         * target/waitstatus.c (target_waitstatus_to_string): Fix
5928         obsolete comment.
5929
5930 2019-04-01  Tom Tromey  <tromey@adacore.com>
5931
5932         PR symtab/23331:
5933         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5934
5935 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5936             Pedro Alves  <palves@redhat.com>
5937
5938         * top.c (quit_force): Call 'finalize_values'.
5939         * value.c (finalize_values): New function.
5940         * value.h (finalize_values): Declare.
5941
5942 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5943
5944         * NEWS: Announce $_gdb_major and $_gdb_minor.
5945
5946         * top.c (init_gdb_version_vars): New function.
5947         (gdb_init): Call init_gdb_version_vars.
5948
5949 2019-03-29  Tom Tromey  <tromey@adacore.com>
5950
5951         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5952         help text.  Remove dead code.
5953
5954 2019-03-29  Keith Seitz  <keiths@redhat.com>
5955
5956         From Siddhesh Poyarekar:
5957         * f-lang.h (f77_get_upperbound): Return LONGEST.
5958         (f77_get_lowerbound): Likewise.
5959         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5960         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5961         print them.
5962         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5963         plongest to format print it.
5964         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5965         (f77_get_upperbound): Likewise.
5966         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5967         LOWER_BOUND to LONGEST.
5968         (f77_create_arrayprint_offset_tbl): Likewise.
5969
5970 2019-03-29  Keith Seitz  <keiths@redhat.com>
5971
5972         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5973         %s/pulongest for TYPE_LENGTH instead of %d in format
5974         strings.
5975         * ada-typerint.c (ada_print_type): Likewise.
5976         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5977         * compile/compile-c-support.c (generate_register_struct): Likewise.
5978         * gdbtypes.c (recursive_dump_type): Likewise.
5979         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5980         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5981         instead of %d in format strings.
5982         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5983         to std::min to ULONGEST.
5984         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5985         instead of %d in format strings.
5986         * tracepoint.c (info_scope_command): Likewise.
5987         * typeprint.c (print_offset_data::update)
5988         (print_offset_data::finish): Likewise.
5989         * xtensa-tdep.c (xtensa_store_return_value)
5990         (xtensa_push_dummy_call): Likewise.
5991
5992 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5993
5994         * windows-nat.c (display_selector): Fixed format specifications
5995         for 64-bit Cygwin.
5996
5997 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5998
5999         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6000
6001 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6002
6003         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6004         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6005         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6006         (nios2_linux_init_abi): Install it.
6007
6008 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6009
6010         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6011
6012 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6013
6014         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6015
6016 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6017             Tom Tromey  <tromey@adacore.com>
6018
6019         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6020
6021 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6022
6023         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6024         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6025         method to compute the bounds of range types. Also print "[evaluated]"
6026         if the bounds' values come from a dynamic evaluation.
6027
6028 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6029
6030         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6031         whitespace when pretty printing is on.
6032
6033 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6034
6035         * ppc-linux-nat.c: Add include.
6036
6037 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6038
6039         * NEWS: Mention AArch64 Pointer Authentication.
6040
6041 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6042
6043         * arm-linux-nat.c: Add include.
6044
6045 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6046
6047         * source-cache.c (source_cache::get_source_lines): Re-read
6048         fullname after calling open_source_file.
6049
6050 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6051
6052         * NEWS: Mention TLS support for FreeBSD.
6053
6054 2019-03-25  Tom Tromey  <tromey@adacore.com>
6055
6056         * minsyms.c (BUNCH_SIZE): Update comment.
6057         (~minimal_symbol_reader): Remove old comment.
6058         (compact_minimal_symbols): Update comment.
6059         (minimal_symbol_reader::install): Remove old comment.  Update
6060         other comments.
6061
6062 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6063
6064         * s390-linux-nat.c: Add include.
6065
6066 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6067
6068         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6069         Call linux_get_hwcap.
6070         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6071         Likewise.
6072         (aarch64_linux_get_hwcap): Remove function.
6073         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6074         declaration.
6075         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6076         linux_get_hwcap.
6077         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6078         * linux-tdep.c (linux_get_hwcap): Add function.
6079         (linux_get_hwcap2): Likewise.
6080         * linux-tdep.h (linux_get_hwcap): Add declaration.
6081         (linux_get_hwcap2): Likewise.
6082         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6083         (ppc_linux_get_hwcap2): Likewise.
6084         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6085         linux_get_hwcap.
6086         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6087         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6088         (ppc_linux_nat_target::read_description): Likewise.
6089         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6090         * s390-linux-nat.c: Likewise.
6091         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6092
6093 2019-03-24  Tom Tromey  <tom@tromey.com>
6094
6095         * ada-lang.c (standard_lookup): Simplify initialization.
6096         (ada_lookup_symbol_nonlocal): Simplify return.
6097         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6098         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6099         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6100         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6101         initialization.
6102         * solib.c (solib_global_lookup): Simplify.
6103         * symtab.c (null_block_symbol): Remove.
6104         (symbol_cache_lookup): Simplify returns.
6105         (lookup_language_this): Simplify returns.
6106         (lookup_symbol_aux): Simplify return.
6107         (lookup_local_symbol): Simplify returns.
6108         (lookup_global_symbol_from_objfile): Simplify return.
6109         (lookup_symbol_in_objfile_symtabs)
6110         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6111         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6112         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6113         * cp-namespace.c (cp_lookup_bare_symbol)
6114         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6115         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6116         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6117         (cp_lookup_symbol_via_imports): Simplify initialization.
6118         (find_symbol_in_baseclass): Likewise.
6119         * symtab.h (null_block_symbol): Remove.
6120         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6121         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6122         (d_lookup_symbol_module): Likewise.
6123         (find_symbol_in_baseclass): Simplify initialization.
6124
6125 2019-03-24  Tom Tromey  <tom@tromey.com>
6126
6127         * expression.h: Don't include symtab.h.
6128         (struct block): Forward declare.
6129
6130 2019-03-24  Tom Tromey  <tom@tromey.com>
6131
6132         * c-exp.y (typebase): Remove casts.
6133         * gdbtypes.c (lookup_unsigned_typename, )
6134         (lookup_signed_typename): Remove cast.
6135         * eval.c (parse_to_comma_and_eval): Remove cast.
6136         * parse.c (write_dollar_variable): Remove cast.
6137         * block.h (struct block) <superblock>: Now const.
6138         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6139         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6140         (map_block): Make "block" const.
6141         * symfile.h (struct quick_symbol_functions)
6142         <map_matching_symbols>: Constify block argument to "callback".
6143         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6144         const.
6145         (find_pc_sect_compunit_symtab): Make "b" const.
6146         (find_symbol_at_address): Likewise.
6147         (search_symbols): Likewise.
6148         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6149         (dw2_debug_names_lookup_symbol): Likewise.
6150         (dw2_map_matching_symbols): Update.
6151         * p-valprint.c (pascal_val_print): Remove "block".
6152         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6153         (aux_add_nonlocal_symbols): Make "block" const.
6154         (resolve_subexp): Remove cast.
6155         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6156         const.
6157         (iterate_over_file_blocks): Likewise.
6158         * f-exp.y (%union) <bval>: Remove.
6159         * coffread.c (patch_opaque_types): Make "b" const.
6160         * spu-tdep.c (spu_catch_start): Make "block" const.
6161         * c-valprint.c (print_unpacked_pointer): Remove "block".
6162         * symmisc.c (dump_symtab_1): Make "b" const.
6163         (block_depth): Make "block" const.
6164         * d-exp.y (%union) <bval>: Remove.
6165         * cp-support.h (cp_lookup_rtti_type): Update.
6166         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6167         * psymtab.c (psym_lookup_symbol): Make "block" const.
6168         (maintenance_check_psymtabs): Make "b" const.
6169         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6170         (enumerate_locals, enumerate_args): Update.
6171         * python/py-symtab.c (stpy_global_block): Make "block" const.
6172         (stpy_static_block): Likewise.
6173         * inline-frame.c (block_starting_point_at): Make "new_block"
6174         const.
6175         * block.c (find_block_in_blockvector): Make return type const.
6176         (blockvector_for_pc_sect): Make "b" const.
6177         (find_block_in_blockvector): Make "b" const.
6178
6179 2019-03-23  Tom Tromey  <tom@tromey.com>
6180
6181         * varobj.c (varobj_create): Update.
6182         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6183         * printcmd.c (display_command, do_one_display): Don't reset
6184         innermost_block.
6185         * parser-defs.h (enum innermost_block_tracker_type): Move to
6186         expression.h.
6187         (innermost_block): Update comment.
6188         * parse.c (parse_exp_1): Add tracker_types parameter.
6189         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6190         tracker_types parameter.  Reset innermost_block.
6191         (parse_exp_in_context): Remove.
6192         (parse_expression_for_completion): Update.
6193         * objfiles.c (~objfile): Don't reset expression_context_block or
6194         innermost_block.
6195         * expression.h (enum innermost_block_tracker_type): Move from
6196         parser-defs.h.
6197         (parse_exp_1): Add tracker_types parameter.
6198         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6199         reset innermost_block.
6200
6201 2019-03-23  Tom Tromey  <tom@tromey.com>
6202
6203         * objfiles.h: Include bcache.h.
6204
6205 2019-03-23  Tom Tromey  <tom@tromey.com>
6206
6207         * linespec.c (get_current_search_block): Use
6208         scoped_restore_current_language.
6209         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6210
6211 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6212             Jiong Wang  <jiong.wang@arm.com>
6213
6214         * aarch64-linux-tdep.c
6215         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6216         section.
6217         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6218
6219 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6220             Jiong Wang  <jiong.wang@arm.com>
6221
6222         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6223         instructions.
6224         (aarch64_analyze_prologue_test): Add PACIASP test.
6225         (aarch64_prologue_prev_register): Unmask PC value.
6226
6227 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6228             Jiong Wang  <jiong.wang@arm.com>
6229
6230         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6231         (aarch64_dwarf2_prev_register): Unmask PC value.
6232         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6233         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6234         DW_CFA_AARCH64_negate_ra_state.
6235         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6236
6237 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6238             Jiong Wang  <jiong.wang@arm.com>
6239
6240         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6241         registers.
6242         (aarch64_pseudo_register_name): Likewise.
6243         (aarch64_pseudo_register_type): Likewise.
6244         (aarch64_pseudo_register_reggroup_p): Likewise.
6245         (aarch64_gdbarch_init): Add pauth registers.
6246         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6247         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6248         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6249         (struct gdbarch_tdep): Add regnum for ra_state.
6250
6251 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6252             Jiong Wang  <jiong.wang@arm.com>
6253
6254         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6255
6256 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6257             Jiong Wang  <jiong.wang@arm.com>
6258
6259         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6260         function.
6261         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6262         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6263         (aarch64_gdbarch_init): Add puth registers.
6264         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6265         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6266         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6267
6268 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6269             Jiong Wang  <jiong.wang@arm.com>
6270
6271         * aarch64-linux-nat.c
6272         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6273         * aarch64-linux-tdep.c
6274         (aarch64_linux_core_read_description): Likewise.
6275         (aarch64_linux_get_hwcap): New function.
6276         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6277         (aarch64_linux_get_hwcap): New declaration.
6278
6279 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6280             Jiong Wang  <jiong.wang@arm.com>
6281
6282         * aarch64-linux-nat.c
6283         (aarch64_linux_nat_target::read_description): Add pauth param.
6284         * aarch64-linux-tdep.c
6285         (aarch64_linux_core_read_description): Likewise.
6286         * aarch64-tdep.c (struct target_desc): Add in pauth.
6287         (aarch64_read_description): Add pauth param.
6288         (aarch64_gdbarch_init): Likewise.
6289         * aarch64-tdep.h (aarch64_read_description): Likewise.
6290         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6291         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6292         * features/Makefile: Add new files.
6293         * features/aarch64-pauth.c: New file.
6294         * features/aarch64-pauth.xml: New file.
6295
6296 2019-03-20  Tom Tromey  <tromey@adacore.com>
6297
6298         * infrun.c (handle_inferior_event): Rename from
6299         handle_inferior_event_1.  Create a scoped_value_mark.
6300         (handle_inferior_event): Remove.
6301
6302 2019-03-19  Tom Tromey  <tromey@adacore.com>
6303
6304         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6305         * infrun.h (print_stop_event): Add "displays" parameter.
6306         * infrun.c (print_stop_event): Add "displays" parameter.
6307
6308 2019-03-19  Pedro Alves  <palves@redhat.com>
6309
6310         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6311         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6312         to -1.  Fix TABs vs spaces.
6313         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6314         * tui/tui-out.h (tui_ui_out) Add intro comments.
6315         <m_line, m_start_of_line>: In-class initialize, and add describing
6316         comment.
6317
6318 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6319
6320         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6321         variable names.
6322         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6323
6324 2019-03-18  Pedro Alves  <palves@redhat.com>
6325             Eli Zaretskii <eliz@gnu.org>
6326
6327         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6328         m_line and m_start_of_line.
6329
6330 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6331
6332         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6333         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6334         it returns a newline.  This fixes a regression in TU mode, whereby
6335         the next line is output on the same screen line as the user input.
6336
6337 2019-03-18  Tom Tromey  <tromey@adacore.com>
6338
6339         * minsyms.c (minimal_symbol_reader::install): Remove call to
6340         obstack_blank.
6341
6342 2019-03-18  Pedro Alves  <palves@redhat.com>
6343
6344         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6345         New globals.
6346         (apply_style): New, factored out from ...
6347         (apply_ansi_escape): ... this.  Handle reverse video mode.
6348         (tui_set_reverse_mode): New function.
6349         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6350         * tui/tui-winsource.c (tui_show_source_line): Use
6351         tui_set_reverse_mode instead of setting A_STANDOUT.
6352         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6353         New setter methods.
6354
6355 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6356
6357         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6358         Handle tabs.
6359
6360 2019-03-18  Tom Tromey  <tromey@adacore.com>
6361
6362         * ada-lang.c (empty_array): Add "high" parameter.
6363         (ada_evaluate_subexp): Update.
6364
6365 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6366
6367         * unittests/string_view-selftests.c: Define
6368         _initialize_string_view_selftests unconditionally.
6369
6370 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6371
6372         PR gdb/24350
6373         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6374
6375 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6376
6377         PR gdb/24351
6378         * windows-nat.c (display_selector): Fix format specifiers.
6379
6380 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6381
6382         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6383         tui_refill_source_window instead of tui_refresh_win, to update the
6384         current execution line.  This fixes redisplay of the current line
6385         when stepping through the code with "next" or "step".
6386
6387 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6388
6389         * source-cache.c (source_cache::get_source_lines): Call
6390         find_source_lines to initialize s->nlines.  This fixes vertical
6391         scrolling of TUI source window when the DOWN arrow is pressed.
6392
6393 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6394
6395         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6396         linux-thread-db.c (_initialize_thread_db): Likewise.
6397
6398 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6399
6400         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6401         wclrtoeol in tui_show_source_line".  This reverts changes made in
6402         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6403
6404 2019-03-15  Tom Tromey  <tom@tromey.com>
6405
6406         * symtab.h (struct minimal_symbol): Derive from
6407         general_symbol_info.
6408         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6409         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6410         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6411         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6412         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6413         (MSYMBOL_SEARCH_NAME): Update.
6414         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6415         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6416         * minsyms.c (minimal_symbol_reader::record_full): Update.
6417
6418 2019-03-15  Tom Tromey  <tom@tromey.com>
6419
6420         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6421
6422 2019-03-15  Tom Tromey  <tom@tromey.com>
6423
6424         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6425         unique_xmalloc_ptr.
6426         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6427         Update.
6428         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6429         (build_minimal_symbol_hash_tables)
6430         (minimal_symbol_reader::install): Update.
6431
6432 2019-03-15  Tom Tromey  <tom@tromey.com>
6433
6434         * symtab.c (create_demangled_names_hash): Update.
6435         (symbol_set_names): Update.
6436         * objfiles.h (struct objfile_per_bfd_storage)
6437         <demangled_names_hash>: Now an htab_up.
6438         * objfiles.c (objfile_per_bfd_storage): Simplify.
6439
6440 2019-03-15  Tom Tromey  <tom@tromey.com>
6441
6442         * objfiles.h (struct objfile_per_bfd_storage): Declare
6443         destructor.
6444         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6445         New.
6446         (get_objfile_bfd_data): Use new.  Don't initialize
6447         language_of_main.
6448         (free_objfile_per_bfd_storage): Remove.
6449         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6450
6451 2019-03-15  Tom Tromey  <tom@tromey.com>
6452
6453         * symfile.c (reread_symbols): Update.
6454         * objfiles.c (objfile::objfile): Update.
6455         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6456         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6457         comment.
6458         (minimal_symbol_reader::install): Update.
6459         (terminate_minimal_symbol_table): Remove.
6460         * jit.c (jit_object_close_impl): Update.
6461
6462 2019-03-15  Tom Tromey  <tom@tromey.com>
6463
6464         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6465         initializations.
6466
6467 2019-03-15  Tom Tromey  <tom@tromey.com>
6468
6469         * objfiles.h (struct objfile_per_bfd_storage)
6470         <demangled_hash_languages>: Now a bitset.
6471         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6472         (lookup_minimal_symbol): Update.
6473
6474 2019-03-15  Tom Tromey  <tom@tromey.com>
6475
6476         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6477         Don't return the symbol.
6478         * coffread.c (record_minimal_symbol): Use record_full.
6479
6480 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6481
6482         The MS-Windows port of ncurses fails to switch to a color pair if
6483         one or both of the colors are the implicit default colors.  This
6484         change records the default colors when TUI is initialized, and
6485         then specifies them explicitly when a color pair uses the default
6486         colors.  This allows color styling in TUI mode on MS-Windows.
6487
6488         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6489         ncurses_norm_attr.
6490         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6491         colors in ncurses_norm_attr.
6492         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6493         "none", replace it with the default color recorded in
6494         ncurses_norm_attr.
6495
6496 2019-03-14  Tom Tromey  <tromey@adacore.com>
6497
6498         * source-cache.h (class source_cache) <get_source_lines>: Return
6499         std::string.
6500         * source-cache.c (source_cache::extract_lines): Handle case where
6501         first_pos==npos.  Return std::string.
6502         (source_cache::get_source_lines): Update.
6503
6504 2019-03-14  Tom Tromey  <tromey@adacore.com>
6505
6506         * NEWS: Add item for "style sources" commands.
6507         * source-cache.c (source_cache::get_source_lines): Check
6508         source_styling.
6509         * cli/cli-style.c (source_styling): New global.
6510         (_initialize_cli_style): Add "style sources" commands.
6511         (show_style_sources): New function.
6512         * cli/cli-style.h (source_styling): Declare.
6513
6514 2019-03-14  Pedro Alves  <palves@redhat.com>
6515             Tom Tromey  <tromey@adacore.com>
6516
6517         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6518         * tui/tui-winsource.c (tui_refill_source_window): New function,
6519         from...
6520         (tui_horizontal_source_scroll): ... here.  Move some logic.
6521         * cli/cli-style.c (set_style_enabled): Notify new observable.
6522         * tui/tui-hooks.c (tui_redisplay_source): New function.
6523         (tui_attach_detach_observers): Attach or detach
6524         tui_redisplay_source.
6525         * observable.h (source_styling_changed): New observable.
6526         * observable.c: Define source_styling_changed observable.
6527
6528 2019-03-13  Tom Tromey  <tromey@adacore.com>
6529
6530         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6531         (i386_gnu_nat_target::store_registers): Update.
6532         * target-debug.h (target_debug_print_std_string): New macro.
6533         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6534         * windows-tdep.c (display_one_tib): Update.
6535         * tui/tui-stack.c (tui_make_status_line): Update.
6536         * top.c (print_inferior_quit_action): Update.
6537         * thread.c (thr_try_catch_cmd): Update.
6538         (add_thread_with_info): Update.
6539         (thread_target_id_str): Update.
6540         (thr_try_catch_cmd): Update.
6541         (thread_command): Update.
6542         (thread_find_command): Update.
6543         * record-btrace.c (record_btrace_target::info_record)
6544         (record_btrace_resume_thread, record_btrace_target::resume)
6545         (record_btrace_cancel_resume, record_btrace_step_thread)
6546         (record_btrace_target::wait, record_btrace_target::wait)
6547         (record_btrace_target::wait, record_btrace_target::stop): Update.
6548         * progspace.c (print_program_space): Update.
6549         * process-stratum-target.c
6550         (process_stratum_target::thread_address_space): Update.
6551         * linux-fork.c (linux_fork_mourn_inferior)
6552         (detach_checkpoint_command, info_checkpoints_command)
6553         (linux_fork_context): Update.
6554         (linux_fork_detach): Update.
6555         (class scoped_switch_fork_info): Update.
6556         (delete_checkpoint_command): Update.
6557         * infrun.c (follow_fork_inferior): Update.
6558         (follow_fork_inferior): Update.
6559         (proceed_after_vfork_done): Update.
6560         (handle_vfork_child_exec_or_exit): Update.
6561         (follow_exec): Update.
6562         (displaced_step_prepare_throw): Update.
6563         (displaced_step_restore): Update.
6564         (start_step_over): Update.
6565         (resume_1): Update.
6566         (clear_proceed_status_thread): Update.
6567         (proceed): Update.
6568         (print_target_wait_results): Update.
6569         (do_target_wait): Update.
6570         (context_switch): Update.
6571         (stop_all_threads): Update.
6572         (restart_threads): Update.
6573         (finish_step_over): Update.
6574         (handle_signal_stop): Update.
6575         (switch_back_to_stepped_thread): Update.
6576         (keep_going_pass_signal): Update.
6577         (print_exited_reason): Update.
6578         (normal_stop): Update.
6579         * inferior.c (inferior_pid_to_str): Change return type.
6580         (print_selected_inferior): Update.
6581         (add_inferior): Update.
6582         (detach_inferior): Update.
6583         * dummy-frame.c (fprint_dummy_frames): Update.
6584         * dcache.c (dcache_info_1): Update.
6585         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6586         (btrace_fetch, btrace_clear): Update.
6587         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6588         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6589         type.
6590         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6591         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6592         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6593         * gdbarch.c, gdbarch.h: Rebuild.
6594         * gdbarch.sh (core_pid_to_str): Change return type.
6595         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6596         return type.
6597         (windows_nat_target::pid_to_str): Change return type.
6598         (windows_delete_thread): Update.
6599         (windows_nat_target::attach): Update.
6600         (windows_nat_target::files_info): Update.
6601         * target-delegates.c: Rebuild.
6602         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6603         return type.
6604         (sol_thread_target::pid_to_str): Change return type.
6605         * remote.c (class remote_target) <pid_to_str>: Change return
6606         type.
6607         (remote_target::pid_to_str): Change return type.
6608         (extended_remote_target::attach, remote_target::remote_stop_ns)
6609         (remote_target::remote_notif_remove_queued_reply)
6610         (remote_target::push_stop_reply, remote_target::disable_btrace):
6611         Update.
6612         (extended_remote_target::attach): Update.
6613         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6614         type.
6615         (gdbsim_target::pid_to_str): Change return type.
6616         * ravenscar-thread.c (struct ravenscar_thread_target)
6617         <pid_to_str>: Change return type.
6618         (ravenscar_thread_target::pid_to_str): Change return type.
6619         * procfs.c (class procfs_target) <pid_to_str>: Change return
6620         type.
6621         (procfs_target::pid_to_str): Change return type.
6622         (procfs_target::attach): Update.
6623         (procfs_target::detach): Update.
6624         (procfs_target::fetch_registers): Update.
6625         (procfs_target::store_registers): Update.
6626         (procfs_target::wait): Update.
6627         (procfs_target::files_info): Update.
6628         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6629         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6630         return type.
6631         (nto_procfs_target::pid_to_str): Change return type.
6632         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6633         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6634         return type.
6635         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6636         (exit_lwp): Update.
6637         (attach_proc_task_lwp_callback, get_detach_signal)
6638         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6639         (linux_nat_target::resume, wait_lwp, stop_callback)
6640         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6641         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6642         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6643         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6644         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6645         type.
6646         (inf_ptrace_target::attach): Update.
6647         (inf_ptrace_target::files_info): Update.
6648         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6649         type.
6650         (go32_nat_target::pid_to_str): Change return type.
6651         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6652         (gnu_nat_target::wait): Update.
6653         (gnu_nat_target::wait): Update.
6654         (gnu_nat_target::resume): Update.
6655         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6656         (fbsd_nat_target::wait): Update.
6657         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6658         type.
6659         (darwin_nat_target::attach): Update.
6660         * corelow.c (class core_target) <pid_to_str>: Change return type.
6661         (core_target::pid_to_str): Change return type.
6662         * target.c (normal_pid_to_str): Change return type.
6663         (default_pid_to_str): Likewise.
6664         (target_pid_to_str): Change return type.
6665         (target_translate_tls_address): Update.
6666         (target_announce_detach): Update.
6667         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6668         return type.
6669         (bsd_uthread_target::pid_to_str): Change return type.
6670         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6671         type.
6672         (bsd_kvm_target::pid_to_str): Change return type.
6673         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6674         return type.
6675         (aix_thread_target::pid_to_str): Change return type.
6676         * target.h (struct target_ops) <pid_to_str>: Change return type.
6677         (target_pid_to_str, normal_pid_to_str): Likewise.
6678         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6679         type.
6680         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6681         type.
6682         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6683         return type.
6684         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6685         type.
6686         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6687         type.
6688         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6689         return type.
6690
6691 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6692
6693         * NEWS: Mention that the new default MI version is 3.  Mention
6694         changes to the output of commands and events that deal with
6695         multi-location breakpoints.
6696         * breakpoint.c: Include "mi/mi-out.h".
6697         (print_one_breakpoint): Change output syntax if using MI version
6698         >= 3.
6699         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6700         New.
6701         (mi_multi_location_breakpoint_output_fixed): New.
6702         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6703         (mi_cmd_fix_multi_location_breakpoint_output): New.
6704         (mi_multi_location_breakpoint_output_fixed): New.
6705         * mi/mi-cmds.c (mi_cmds): Register command
6706         -fix-multi-location-breakpoint-output.
6707         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6708         interpreter "mi".
6709
6710 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6711
6712         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6713         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6714         instantiate mi_ui_out based on interpreter name.
6715         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6716         * mi/mi-main.c (mi_load_progress): Likewise.
6717
6718 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6719
6720         * NEWS: Combine separate "New targets" sections for 8.3.
6721
6722 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6723
6724         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6725         (ppcfbsd_init_abi): Install gdbarch
6726         "fetch_tls_load_module_address" and "get_thread_local_address"
6727         methods.
6728
6729 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6730
6731         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6732         (riscv_fbsd_init_abi): Install gdbarch
6733         "fetch_tls_load_module_address" and "get_thread_local_address"
6734         methods.
6735
6736 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6737
6738         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6739         (i386fbsd_init_abi): Install gdbarch
6740         "fetch_tls_load_module_address" and "get_thread_local_address"
6741         methods.
6742
6743 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6744
6745         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6746         (amd64fbsd_init_abi): Install gdbarch
6747         "fetch_tls_load_module_address" and "get_thread_local_address"
6748         methods.
6749
6750 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6751
6752         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6753         (struct fbsd_pspace_data): New type.
6754         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6755         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6756         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6757         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6758         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6759
6760 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6761
6762         * gdbtypes.c (lookup_struct_elt): New function.
6763         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6764         * gdbtypes.h (struct struct_elt): New type.
6765         (lookup_struct_elt): New prototype.
6766
6767 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6768
6769         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6770         remove disabled code block.
6771
6772 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6773
6774         * gdbarch.sh (get_thread_local_address): New method.
6775         * gdbarch.h, gdbarch.c: Regenerate.
6776         * target.c (target_translate_tls_address): Use
6777         gdbarch_get_thread_local_address if present instead of
6778         target::get_thread_local_address.
6779
6780 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6781
6782         * target.h (target::get_thread_local_address): Update comment.
6783
6784 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6785
6786         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6787         objfile->separate_debug_objfile_backlink if not NULL.
6788
6789 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6790
6791         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6792         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6793         (amd64bsd_store_inferior_registers): Likewise.
6794         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6795         Enable segment base registers.
6796         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6797         PT_GETFSBASE and PT_GETGSBASE.
6798         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6799         PT_SETGSBASE.
6800         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6801         segment base registers.
6802         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6803
6804 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6805
6806         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6807         Update calls to i386_target_description to add 'segments'
6808         parameter.
6809         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6810         add segment base registers.
6811         * arch/i386.c (i386_create_target_description): Add 'segments'
6812         parameter to enable segment base registers.
6813         * arch/i386.h (i386_create_target_description): Likewise.
6814         * features/i386/32bit-segments.xml: New file.
6815         * features/i386/32bit-segments.c: Generate.
6816         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6817         call to i386_target_description to add 'segments' parameter.
6818         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6819         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6820         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6821         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6822         if feature is present.
6823         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6824         Add 'segments' parameter to call to i386_target_description.
6825         (i386_target_description): Add 'segments' parameter to enable
6826         segment base registers.
6827         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6828         to call to i386_target_description.
6829         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6830         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6831         Define I386_NUM_REGS.
6832         (i386_target_description): Add 'segments' parameter to enable
6833         segment base registers.
6834
6835 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6836
6837         PR/24325
6838         * source-cache.c: #undef open and close, to avoid unresolved
6839         externals during linking.
6840
6841 2019-03-12  Tom Tromey  <tromey@adacore.com>
6842
6843         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6844         const.  Add initializers.
6845         (_initialize_remote): Don't initialize ptid globals.
6846
6847 2019-03-12  Pedro Alves  <palves@redhat.com>
6848
6849         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6850
6851 2019-03-12  Pedro Alves  <palves@redhat.com>
6852
6853         * cp-name-parser.y (main): Remove unused 'len' variable.
6854
6855 2019-03-12  Tom Tromey  <tromey@adacore.com>
6856
6857         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6858         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6859
6860 2019-03-12  Tom Tromey  <tromey@adacore.com>
6861
6862         * linux-nat.c (iterate_over_lwps): Update.
6863         (stop_callback): Remove parameter.
6864         (stop_wait_callback, detach_callback, resume_set_callback)
6865         (select_singlestep_lwp_callback, set_ignore_sigint)
6866         (status_callback, resumed_callback, resume_clear_callback)
6867         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6868         data parameter.
6869         (linux_nat_target::detach, linux_nat_target::resume)
6870         (linux_stop_and_wait_all_lwps, select_event_lwp)
6871         (linux_nat_filter_event, linux_nat_wait_1)
6872         (linux_nat_target::kill, linux_nat_target::stop)
6873         (linux_nat_target::stop): Update.
6874         (linux_nat_resume_callback): Change type.
6875         (resume_stopped_resumed_lwps, count_events_callback)
6876         (select_event_lwp_callback): Likewise.
6877         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6878         * arm-linux-nat.c (struct update_registers_data): Remove.
6879         (update_registers_callback): Change type.
6880         (arm_linux_insert_hw_breakpoint1): Update.
6881         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6882         parameter.
6883         (x86_linux_dr_set_addr): Update.
6884         (x86_linux_dr_set_control): Update.
6885         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6886         (iterate_over_lwps): Use gdb::function_view.
6887         * nat/aarch64-linux-hw-point.c (struct
6888         aarch64_dr_update_callback_param): Remove.
6889         (debug_reg_change_callback): Change type.
6890         (aarch64_notify_debug_reg_change): Update.
6891         * s390-linux-nat.c (s390_refresh_per_info): Update.
6892
6893 2019-03-11  Tom Tromey  <tromey@adacore.com>
6894
6895         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6896         redundant assignment to "this_cu".
6897
6898 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6899
6900         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6901
6902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6903
6904         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6905         from...
6906         (rank_one_type): ... this.
6907
6908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6909
6910         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6911         from...
6912         (rank_one_type): ... this.
6913
6914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6915
6916         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6917         from...
6918         (rank_one_type): ... this.
6919
6920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6921
6922         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6923         from...
6924         (rank_one_type): ... this.
6925
6926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6927
6928         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6929         from...
6930         (rank_one_type): ... this.
6931
6932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6933
6934         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6935         from...
6936         (rank_one_type): ... this.
6937
6938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6939
6940         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6941         from...
6942         (rank_one_type): ... this.
6943
6944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6945
6946         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6947         from...
6948         (rank_one_type): ... this.
6949
6950 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6951
6952         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6953         from...
6954         (rank_one_type): ... this.
6955
6956 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6957
6958         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6959         from...
6960         (rank_one_type): ... this.
6961
6962 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6963
6964         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6965         from...
6966         (rank_one_type): ... this.
6967
6968 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6969
6970         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6971         from...
6972         (rank_one_type): ... this.
6973
6974 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6975
6976         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6977         inferior-events' shows the example events.
6978
6979 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6980
6981         Support styling on native MS-Windows console
6982
6983         PR/24315
6984         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6985         on MS-Windows if $TERM is not defined.
6986
6987         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6988
6989         * posix-hdep.c (gdb_console_fputs):
6990         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6991         functions.
6992         * ui-file.h (gdb_console_fputs): Add prototype.
6993
6994         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6995         back to fputs only if the former returns zero.
6996
6997 2019-03-07  Tom Tromey  <tom@tromey.com>
6998
6999         * symmisc.c (print_symbol_bcache_statistics): Update.
7000         (print_objfile_statistics): Update.
7001         * symfile.c (allocate_symtab): Update.
7002         * stabsread.c: Don't include bcache.h.
7003         * psymtab.h (struct psymbol_bcache): Don't declare.
7004         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7005         (psymbol_bcache_init, psymbol_bcache_free)
7006         (psymbol_bcache_get_bcache): Don't declare.
7007         * psymtab.c (struct psymbol_bcache): Remove.
7008         (psymtab_storage::psymtab_storage): Update.
7009         (psymtab_storage::~psymtab_storage): Update.
7010         (psymbol_bcache_init, psymbol_bcache_free)
7011         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7012         (add_psymbol_to_bcache): Update.
7013         (allocate_psymtab): Update.
7014         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7015         macro_cache>: No longer pointers.
7016         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7017         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7018         * macrotab.c (macro_bcache): Update.
7019         * macroexp.c: Don't include bcache.h.
7020         * gdbtypes.c (check_types_worklist): Update.
7021         (types_deeply_equal): Remove TRY/CATCH.  Update.
7022         * elfread.c (elf_symtab_read): Update.
7023         * dwarf2read.c: Don't include bcache.h.
7024         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7025         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7026         (print_bcache_statistics, bcache_memory_used): Don't declare.
7027         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7028         methods.  Rename all data members.
7029         * bcache.c (struct bcache): Move to bcache.h.
7030         (bcache::expand_hash_table): Rename from expand_hash_table.
7031         (bcache): Remove.
7032         (bcache::insert): Rename from bcache_full.
7033         (bcache::compare): Rename from bcache_compare.
7034         (bcache_xmalloc): Remove.
7035         (bcache::~bcache): Rename from bcache_xfree.
7036         (bcache::print_statistics): Rename from print_bcache_statistics.
7037         (bcache::memory_used): Rename from bcache_memory_used.
7038
7039 2019-03-07  Pedro Alves  <palves@redhat.com>
7040
7041         * infrun.c (normal_stop): Also check for
7042         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7043
7044 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7045
7046         * f-lang.c (value_from_host_double): Moved to...
7047         * value.c (value_from_host_double): ...here.
7048         * value.h (value_from_host_double): Declare.
7049         * guile/scm-math.c (vlscm_convert_typed_number): Use
7050         value_from_host_double.
7051         (vlscm_convert_number): Likewise.
7052         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7053         * python/py-value.c (convert_value_from_python): Likewise.
7054
7055 2019-03-06  Tom Tromey  <tom@tromey.com>
7056
7057         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7058
7059 2019-03-06  Tom Tromey  <tom@tromey.com>
7060
7061         * utils.h (free_current_contents): Don't declare.
7062         * utils.c (free_current_contents): Remove.
7063
7064 2019-03-06  Tom Tromey  <tom@tromey.com>
7065
7066         * top.c (quit_force): Update.
7067         * main.c (captured_command_loop): Update.
7068         * common/new-op.c (operator new): Update.
7069         * common/common-exceptions.c (struct catcher)
7070         <save_cleanup_chain>: Remove member.
7071         (exceptions_state_mc_init): Update.
7072         (exception_try_scope_entry): Return nullptr.
7073         (exception_try_scope_exit, exception_rethrow)
7074         (throw_exception_sjlj, throw_exception_cxx): Update.
7075         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7076         (all_cleanups, do_cleanups, discard_cleanups)
7077         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7078         (restore_cleanups, restore_final_cleanups): Don't declare.
7079         (do_final_cleanups): Remove parameter.
7080         * common/cleanups.c (cleanup_chain, make_cleanup)
7081         (make_cleanup_dtor, all_cleanups, do_cleanups)
7082         (discard_my_cleanups, discard_cleanups)
7083         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7084         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7085         (null_cleanup): Remove.
7086         (do_final_cleanups): Remove parameter.
7087
7088 2019-03-06  Tom Tromey  <tom@tromey.com>
7089
7090         * remote.c (remote_target::remote_parse_stop_reply): Use
7091         unique_xmalloc_ptr.
7092
7093 2019-03-06  Tom Tromey  <tom@tromey.com>
7094
7095         * stabsread.c (struct stabs_field_info): Rename from field_info.
7096         <list, fnlist>: Add initializers.
7097         <obstack>: New member.
7098         (read_member_functions, read_struct_fields, read_baseclasses):
7099         Allocate on obstack.  Don't use cleanups.
7100         (read_one_struct_field, read_member_functions, read_struct_fields)
7101         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7102         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7103         (read_struct_type): Update.
7104
7105 2019-03-06  Tom Tromey  <tom@tromey.com>
7106
7107         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7108         * common/filestuff.h (make_cleanup_close): Don't declare.
7109         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7110         Remove.
7111
7112 2019-03-06  Tom Tromey  <tom@tromey.com>
7113
7114         * solib-aix.c: Use make_scope_exit.
7115
7116 2019-03-06  Tom Tromey  <tom@tromey.com>
7117
7118         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7119         Use make_scope_exit.
7120
7121 2019-03-06  Tom Tromey  <tom@tromey.com>
7122
7123         * solib-svr4.c (disable_probes_interface): Remove parameter.
7124         (svr4_handle_solib_event): Use make_scope_exit.
7125
7126 2019-03-06  Tom Tromey  <tom@tromey.com>
7127
7128         * remote.c (struct stop_reply_deleter): Remove.
7129         (stop_reply_up): Update.
7130         (struct stop_reply): Derive from notif_event.  Don't typedef.
7131         <regcache>: Now a std::vector.
7132         (stop_reply_xfree): Remove.
7133         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7134         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7135         (remote_target::discard_pending_stop_replies): Use delete.
7136         (remote_target::remote_parse_stop_reply): Update.
7137         (remote_target::process_stop_reply): Update.
7138         * remote-notif.h (struct notif_event): Add virtual destructor.
7139         Remove "dtr" member.
7140         (struct notif_client) <alloc_event>: Return a unique_ptr.
7141         (notif_event_xfree): Don't declare.
7142         (notif_event_up): New typedef.
7143         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7144         (notif_event_xfree, do_notif_event_xfree): Remove.
7145         (remote_notif_state_xfree): Update.
7146
7147 2019-03-06  Tom Tromey  <tom@tromey.com>
7148
7149         * infrun.c (displaced_step_clear_cleanup): Now a
7150         forward_scope_exit type.
7151         (displaced_step_prepare_throw): Update.
7152         (displaced_step_fixup): Update.
7153
7154 2019-03-06  Tom Tromey  <tom@tromey.com>
7155
7156         * inferior.h (class inferior): Update comment.
7157         * gdbthread.h (class thread_info): Update comment.
7158
7159 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7160             Tom Tromey  <tom@tromey.com>
7161
7162         * stabsread.h (struct stab_section_list): Remove.
7163         (coffstab_build_psymtabs): Update.
7164         * dbxread.c (symbuf_sections): Now a std::vector.
7165         (sect_idx): New global.
7166         (fill_symbuf): Update.
7167         (coffstab_build_psymtabs): Change type of stabsects parameter.
7168         Update.
7169         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7170         std::vector.
7171         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7172         (coff_locate_sections): Update.
7173         (coff_symfile_read): Remove cleanups.  Update.
7174         (init_stringtab): Add storage parameter.
7175         (free_stringtab, free_stringtab_cleanup): Remove.
7176         (init_lineno): Add storage parameter.
7177         (free_linetab, free_linetab_cleanup): Remove.
7178
7179 2019-03-06  Pedro Alves  <palves@redhat.com>
7180
7181         * linux-fork.c (fork_info::clobber_regs): Delete.
7182         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7183         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7184         comment.  Adjust.
7185         (scoped_switch_fork_info::scoped_switch_fork_info)
7186         (checkpoint_command, linux_fork_context): Adjust
7187         fork_save_infrun_state calls.
7188
7189 2019-03-06  Pedro Alves  <palves@redhat.com>
7190
7191         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7192         (inf_has_multiple_threads): Return 'bool' and rewrite using
7193         inferior_info::threads().
7194
7195 2019-03-06  Pedro Alves  <palves@redhat.com>
7196
7197         * linux-fork.c: Include <list>.
7198         (fork_list): Now a std::list instance.
7199         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7200         (forks_exist_p, find_last_fork): Adjust.
7201         (new_fork): Delete.
7202         (one_fork_p): New.
7203         (add_fork): Adjust.
7204         (free_fork): Delete, folded into fork_info::~fork_info().
7205         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7206         Adjust.
7207         (init_fork_list): Delete.
7208         (linux_fork_killall, linux_fork_mourn_inferior)
7209         (linux_fork_detach, info_checkpoints_command): Adjust.
7210         (_initialize_linux_fork): No longer call init_fork_list.
7211
7212 2019-03-06  Pedro Alves  <palves@redhat.com>
7213
7214         * linux-fork.c (new_fork): New, split out of ...
7215         (add_fork): ... this.  Return void.  Move "first fork" special
7216         case from here, to ...
7217         (checkpoint_command): ... here.
7218         * linux-linux.h (add_fork): Return void.
7219
7220 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7221
7222         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7223
7224 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7225             Chris January  <chris.january@arm.com>
7226             David Lecomber  <david.lecomber@arm.com>
7227
7228         * f-exp.y: New token, UNOP_INTRINSIC.
7229         (exp): New pattern using UNOP_INTRINSIC token.
7230         (f77_keywords): Add 'abs' keyword.
7231         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7232         (value_from_host_double): New function.
7233         (evaluate_subexp_f): Support UNOP_ABS.
7234
7235 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7236
7237         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7238         types.
7239
7240 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7241
7242         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7243         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7244         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7245
7246 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7247
7248         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7249
7250 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7251             Chris January  <chris.january@arm.com>
7252
7253         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7254         * f-exp.y: Define 'KIND' token.
7255         (exp): New pattern for KIND expressions.
7256         (ptype): Handle types with a kind extension.
7257         (direct_abs_decl): Extend to spot kind extensions.
7258         (f77_keywords): Add 'kind' to the list.
7259         (push_kind_type): New function.
7260         (convert_to_kind_type): New function.
7261         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7262         * parse.c (operator_length_standard): Likewise.
7263         * parser-defs.h (enum type_pieces): Add tp_kind.
7264         * std-operator.def: Add UNOP_KIND.
7265
7266 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7267
7268         * f-exp.y (f_parse): Set yydebug.
7269
7270 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7271
7272         * f-lang.c (evaluate_subexp_f): New function.
7273         (exp_descriptor_f): New global.
7274         (f_language_defn): Use exp_descriptor_f instead of
7275         exp_descriptor_standard.
7276
7277 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7278
7279         * f-exp.y (struct token): Add comments.
7280         (dot_ops): Remove uppercase versions and the end marker.
7281         (f77_keywords): Likewise.
7282         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7283         entries in the dot_ops array are case insensitive, and use
7284         strncasecmp to compare strings.  Also some whitespace cleanup in
7285         this area.  Similar for the f77_keywords array, except entries in
7286         this list might be case sensitive.
7287
7288 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7289
7290         * f-exp.y (struct f77_boolean_val): Add comments.
7291         (boolean_values): Remove uppercase versions, and end marker.
7292         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7293         and use strncasecmp to achieve case insensitivity.  Additionally,
7294         perform whitespace cleanup around this code.
7295
7296 2019-03-06  Tom Tromey  <tromey@adacore.com>
7297
7298         * remote-sim.c (gdbsim_target_open): Use result of
7299         gdb_argv::release.
7300
7301 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7302         Dirk Schubert  <dirk.schubert@arm.com>
7303         Chris January  <chris.january@arm.com>
7304
7305         * eval.c (evaluate_subexp_standard): Call Fortran argument
7306         wrapping logic.
7307         * f-lang.c (struct value): A value which can be passed into a
7308         Fortran function call.
7309         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7310         where appropriate.
7311         (struct type): Value ready for a Fortran function call.
7312         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7313         is needed.
7314         * f-lang.h (fortran_argument_convert): Declaration.
7315         (fortran_preserve_arg_pointer): Declaration.
7316         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7317
7318 2019-03-05  Tom Tromey  <tromey@adacore.com>
7319
7320         * python/py-prettyprint.c (print_string_repr): Remove #if.
7321         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7322
7323 2019-03-05  Tom Tromey  <tromey@adacore.com>
7324
7325         * target.c (the_dummy_target): Move later.  Change type to
7326         "dummy_target".
7327         (initialize_targets): Don't initialize the_dummy_target.
7328
7329 2019-03-05  Tom Tromey  <tromey@adacore.com>
7330
7331         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7332         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7333
7334 2019-03-05  Tom Tromey  <tromey@adacore.com>
7335
7336         * windows-nat.c (windows_nat_target::attach)
7337         (windows_nat_target::detach): Don't call gdb_flush.
7338         * valprint.c (generic_val_print, val_print, val_print_string):
7339         Don't call gdb_flush.
7340         * utils.c (defaulted_query): Don't call gdb_flush.
7341         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7342         * target.c (target_announce_detach): Don't call gdb_flush.
7343         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7344         * remote.c (extended_remote_target::attach): Don't call
7345         gdb_flush.
7346         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7347         * printcmd.c (do_examine): Don't call gdb_flush.
7348         (info_display_command): Don't call gdb_flush.
7349         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7350         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7351         * memattr.c (info_mem_command): Don't call gdb_flush.
7352         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7353         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7354         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7355         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7356         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7357         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7358         (gnu_nat_target::detach): Don't call gdb_flush.
7359         * f-valprint.c (f_val_print): Don't call gdb_flush.
7360         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7361         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7362         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7363         gdb_flush.
7364         * c-valprint.c (c_val_print): Don't call gdb_flush.
7365         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7366
7367 2019-03-05  Tom Tromey  <tromey@adacore.com>
7368
7369         * varobj.c (update_dynamic_varobj_children): Update.
7370         (install_default_visualizer): Use reset, not release.
7371         * value.c (set_internalvar): Update.
7372         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7373         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7374         ATTRIBUTE_UNUSED_RESULT.
7375
7376 2019-03-05  Tom Tromey  <tromey@adacore.com>
7377
7378         * remote.c (class scoped_remote_fd) <release>: Add
7379         ATTRIBUTE_UNUSED_RESULT.
7380
7381 2019-03-05  Tom Tromey  <tromey@adacore.com>
7382
7383         * macroexp.c (struct macro_buffer) <release>: Add
7384         ATTRIBUTE_UNUSED_RESULT.
7385
7386 2019-03-05  Tom Tromey  <tromey@adacore.com>
7387
7388         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7389         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7390         ATTRIBUTE_UNUSED_RESULT.
7391
7392 2019-03-05  Tom Tromey  <tromey@adacore.com>
7393
7394         * common/scoped_fd.h (class scoped_fd) <release>: Add
7395         ATTRIBUTE_UNUSED_RESULT.
7396
7397 2019-03-05  Tom Tromey  <tromey@adacore.com>
7398
7399         * parser-defs.h (struct parser_state) <release>: Add
7400         ATTRIBUTE_UNUSED_RESULT.
7401
7402 2019-03-05  Tom Tromey  <tromey@adacore.com>
7403
7404         * utils.h (class gdb_argv) <release>: Add
7405         ATTRIBUTE_UNUSED_RESULT.
7406         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7407
7408 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7409
7410         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7411         for-loop range, to avoid compiler warnings.
7412
7413         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7414         avoid compiler warnings about unused variables.
7415
7416         * NEWS: Mention end of support for native debugging on MS-Windows
7417         before XP.
7418
7419         PR gdb/24292
7420         * common/netstuff.c:
7421         * gdbserver/gdbreplay.c
7422         * gdbserver/remote-utils.c:
7423         * ser-tcp.c:
7424         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7425         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7426         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7427         'getaddrinfo' and 'freeaddrinfo' were not available before
7428         Windows XP, and mingw.org's MinGW headers by default define
7429         _WIN32_WINNT to 0x500.
7430
7431 2019-03-01  Gary Benson <gbenson@redhat.com>
7432
7433         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7434
7435 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7436             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7437
7438         PR gdb/8527
7439         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7440         set_sigint_trap, clear_sigint_trap.
7441
7442 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7443
7444         * target.c (target_detach): Clear the regcache and the
7445         frame cache.
7446
7447 2019-02-27  Pedro Alves  <palves@redhat.com>
7448
7449         * utils.c (set_screen_size): When we cap the height/width sizes,
7450         tweak the corresponding command variable to show "unlimited":
7451
7452 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7453             Pedro Alves  <palves@redhat.com>
7454
7455         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7456         before calling rl_set_screen_size.
7457
7458 2019-02-27  Tom Tromey  <tromey@adacore.com>
7459
7460         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7461         define.
7462         * python/py-value.c: Remove Python 2.4 workaround.
7463         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7464         workaround.
7465         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7466         Python 2.4 workaround.
7467         * python/python-internal.h: Remove Python 2.4 comment.
7468         (Py_ssize_t): Don't define.
7469         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7470         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7471         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7472         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7473         * python/python.c (do_start_initialization): Remove Python 2.4
7474         workaround.
7475         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7476         (print_children): Remove Python 2.4 workaround.
7477         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7478         workaround.
7479         (CHARBUFFERPROC_NAME): Remove.
7480         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7481         Python 2.4 workaround.
7482
7483 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7484
7485         * NEWS: Note minimum Python version.
7486
7487 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7488
7489         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7490         code from these functions.  Remove corresponding ifdefs.  Use
7491         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7492         Remove gotos and target of gotos.
7493         (infpy_search_memory): Likewise.
7494
7495 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7496
7497         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7498         (hppa_gdbarch_init): Don't register deleted functions with
7499         gdbarch.
7500
7501 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7502
7503         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7504         (h8300_unwind_sp): Delete.
7505         (h8300_dummy_id): Delete.
7506         (h8300_gdbarch_init): Don't register deleted functions with
7507         gdbarch.
7508
7509 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7510
7511         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7512         (ft32_unwind_pc): Delete.
7513         (ft32_unwind_sp): Delete.
7514         (ft32_gdbarch_init): Don't register deleted functions with
7515         gdbarch.
7516
7517 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7518
7519         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7520         (frv_unwind_pc): Delete.
7521         (frv_unwind_sp): Delete.
7522         (frv_gdbarch_init): Don't register deleted functions with
7523         gdbarch.
7524
7525 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7526
7527         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7528         (riscv_unwind_pc): Delete.
7529         (riscv_unwind_sp): Delete.
7530         (riscv_gdbarch_init): Don't register deleted functions with
7531         gdbarch.
7532
7533 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7534
7535         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7536         (csky_unwind_pc): Delete.
7537         (csky_unwind_sp): Delete.
7538         (csky_gdbarch_init): Don't register deleted functions with
7539         gdbarch.
7540
7541 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7542
7543         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7544         (cris_unwind_pc): Delete.
7545         (cris_unwind_sp): Delete.
7546         (cris_gdbarch_init): Don't register deleted functions with
7547         gdbarch.
7548
7549 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7550
7551         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7552         (bfin_unwind_pc): Delete.
7553         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7554
7555 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7556
7557         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7558         (arm_unwind_pc): Delete.
7559         (arm_unwind_sp): Delete.
7560         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7561
7562 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7563
7564         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7565         (arc_unwind_pc): Delete.
7566         (arc_unwind_sp): Delete.
7567         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7568
7569 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7570
7571         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7572         (alpha_unwind_pc): Delete.
7573         (alpha_gdbarch_init): Don't register deleted functions with
7574         gdbarch.
7575
7576 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7577
7578         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7579         (aarch64_unwind_pc): Delete.
7580         (aarch64_unwind_sp): Delete.
7581         (aarch64_gdbarch_init): Don't register deleted functions with
7582         gdbarch.
7583
7584 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7585
7586         * gdbtypes.c (type_align): Don't consider static members when
7587         computing structure alignment.
7588
7589 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7590
7591         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7592         return 0 for other types.
7593         * arch-utils.c (default_type_align): Always return 0.
7594         * gdbarch.h: Regenerate.
7595         * gdbarch.sh (type_align): Extend comment.
7596         * gdbtypes.c (type_align): Add additional comments, always call
7597         gdbarch_type_align before applying the default rules.
7598         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7599         generic code will then apply a suitable default.
7600         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7601         types, return 0 for other types.
7602
7603 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7604
7605         * NEWS: Create a new section for the next release branch.
7606         Rename the section of the current branch, now that it has
7607         been cut.
7608
7609 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7610
7611         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7612         * version.in: Bump version to 8.3.50.DATE-git.
7613
7614 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7615
7616         * aix-thread.c (ptid_cmp): Remove unused variable.
7617         (get_signaled_thread): Likewise.
7618         (store_regs_user_thread): Likewise.
7619         (store_regs_kernel_thread): Likewise.
7620         (fetch_regs_kernel_thread): Remove shadowed variable.
7621
7622 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7623
7624         * features/riscv/32bit-cpu.xml: Add register numbers.
7625         * features/riscv/32bit-fpu.c: Regenerate.
7626         * features/riscv/32bit-fpu.xml: Add register numbers.
7627         * features/riscv/64bit-cpu.xml: Add register numbers.
7628         * features/riscv/64bit-fpu.c: Regenerate.
7629         * features/riscv/64bit-fpu.xml: Add register numbers.
7630
7631 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7632
7633         * NEWS: Mention two argument form of gdb.Value constructor.
7634         * python/py-value.c (convert_buffer_and_type_to_value): New
7635         function.
7636         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7637         Add support for handling an optional second argument.  Call
7638         convert_buffer_and_type_to_value as appropriate.
7639         * python/python-internal.h (Py_buffer_deleter): New struct.
7640         (Py_buffer_up): New typedef.
7641
7642 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7643
7644         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7645         instead of releasing ownership.
7646
7647 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7648
7649         * dwarf2read.c (open_and_init_dwp_file): Call
7650         elf_numsections instead of bfd_count_sections to initialize
7651         dwp_file->num_sections.
7652
7653 2019-02-25  Tom Tromey  <tromey@adacore.com>
7654
7655         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7656
7657 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7658
7659         * gcore.in: Add '--readnever' option when invoking GDB.
7660
7661 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7662
7663         * MAINTAINERS: Update my email address.
7664
7665 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7666
7667         * build-id.c (build_id_to_debug_bfd_1): New function.
7668         (build_id_to_debug_bfd): Look for separate debug file in
7669         sysroot.
7670
7671 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7672
7673         * gdbarch.sh: Update the copyright year range that is placed into
7674         generated files.
7675
7676 2019-02-22  Keith Seitz  <keiths@redhat.com>
7677
7678         PR symtab/23853
7679         * linespec.c (create_sals_line_offset): Search for the default
7680         symtab's filename instead of its fullname.
7681
7682 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7683
7684         * NEWS: Update style defaults.
7685
7686 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7687
7688         * main.c (captured_main_1): Disable styling in batch mode.
7689
7690 2019-02-20  Tom Tromey  <tom@tromey.com>
7691
7692         * symtab.c (symtab_symbol_info): Fix typos.
7693
7694 2019-02-20  Tom Tromey  <tromey@adacore.com>
7695
7696         * findcmd.c (_initialize_mem_search): Use upper case for
7697         metasyntactic variables.
7698
7699 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7700
7701         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7702         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7703
7704 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7705
7706         * top.h (source_file_name): Change to std::string.
7707         * top.c (source_file_name): Likewise.
7708         (command_line_input): Adjust.
7709         * cli/cli-script.c (script_from_file): Adjust.
7710
7711 2019-02-19  Tom Tromey  <tromey@adacore.com>
7712
7713         * ravenscar-thread.c
7714         (ravenscar_thread_target::update_thread_list): Don't call
7715         ada_build_task_list.
7716         * ada-lang.h (ada_build_task_list): Don't declare.
7717         * ada-tasks.c (struct ada_tasks_inferior_data)
7718         <task_list_valid_p>: Now bool.
7719         (read_known_tasks, ada_task_list_changed)
7720         (ada_tasks_invalidate_inferior_data): Update.
7721         (read_known_tasks_array): Return bool.
7722         (read_known_tasks_list): Likewise.
7723         (read_known_tasks): Return void.
7724         (ada_build_task_list): Now static.
7725
7726 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7727
7728         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7729         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7730
7731 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7732
7733         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7734         variant for ada_tasks_pspace_data_handle and
7735         ada_tasks_inferior_data_handle.
7736         (ada_tasks_pspace_data_cleanup): New function.
7737         (ada_tasks_inferior_data_cleanup): New function.
7738
7739 2019-02-17  Tom Tromey  <tom@tromey.com>
7740
7741         * macrotab.h (macro_source_fullname): Return a std::string.
7742         * macrotab.c (macro_include, check_for_redefinition)
7743         (macro_undef, macro_lookup_definition, foreach_macro)
7744         (foreach_macro_in_scope): Update.
7745         (macro_source_fullname): Return a std::string.
7746         * macrocmd.c (show_pp_source_pos): Update.
7747
7748 2019-02-17  Tom Tromey  <tom@tromey.com>
7749
7750         * macrocmd.c (show_pp_source_pos): Style the file names.
7751
7752 2019-02-17  Tom Tromey  <tom@tromey.com>
7753
7754         PR tui/24197:
7755         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7756
7757 2019-02-17  Tom Tromey  <tom@tromey.com>
7758
7759         * ada-lang.c (user_select_syms): Use filtered printing.
7760         * utils.c (wrap_style): New global.
7761         (desired_style): Remove.
7762         (emit_style_escape): Add stream parameter.
7763         (set_output_style, reset_terminal_style, prompt_for_continue):
7764         Update.
7765         (flush_wrap_buffer): Only flush gdb_stdout.
7766         (wrap_here): Set wrap_style.
7767         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7768         treat escape sequences as a character.  Change when wrap buffer is
7769         flushed.
7770         (fputs_styled): Do not set the output style when the default is
7771         requested.
7772         * ui-style.h (struct ui_file_style) <is_default>: New method.
7773         * source.c (print_source_lines_base): Emit escape sequences in one
7774         piece.
7775
7776 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7777
7778         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7779         integers and enumeration types.
7780
7781 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7782
7783         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7784         instead of lookup_symbol_in_language
7785         (do_exact_match): New function.
7786         (ada_get_symbol_name_matcher): Return do_exact_match when
7787         doing a verbatim match.
7788
7789 2019-02-15  Tom Tromey  <tromey@adacore.com>
7790
7791         * ravenscar-thread.c (ravenscar_thread_target::resume)
7792         (ravenscar_thread_target::wait): Special case wildcard requests.
7793
7794 2019-02-15  Tom Tromey  <tromey@adacore.com>
7795
7796         * ravenscar-thread.c (base_ptid): Remove.
7797         (struct ravenscar_thread_target) <close>: New method.
7798         <m_base_ptid>: New member.
7799         <update_inferior_ptid, active_task, task_is_currently_active,
7800         runtime_initialized>: Declare methods.
7801         <ravenscar_thread_target>: Add constructor.
7802         (ravenscar_thread_target::task_is_currently_active)
7803         (ravenscar_thread_target::update_inferior_ptid)
7804         (ravenscar_runtime_initialized): Rename.  Now methods.
7805         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7806         (ravenscar_thread_target::update_thread_list): Update.
7807         (ravenscar_thread_target::active_task): Now method.
7808         (ravenscar_thread_target::store_registers)
7809         (ravenscar_thread_target::prepare_to_store)
7810         (ravenscar_thread_target::prepare_to_store)
7811         (ravenscar_thread_target::mourn_inferior): Update.
7812         (ravenscar_inferior_created): Use "new" to create target.
7813         (ravenscar_thread_target::get_ada_task_ptid): Update.
7814         (_initialize_ravenscar): Don't initialize base_ptid.
7815         (ravenscar_ops): Remove global.
7816
7817 2019-02-15  Tom Tromey  <tromey@adacore.com>
7818
7819         * target.h (push_target): Declare new overload.
7820         * target.c (push_target): New overload, taking an rvalue reference.
7821         * remote.c (remote_target::open_1): Use push_target overload.
7822         * corelow.c (core_target_open): Use push_target overload.
7823
7824 2019-02-15  Tom Tromey  <tromey@adacore.com>
7825
7826         * ravenscar-thread.c (is_ravenscar_task)
7827         (ravenscar_task_is_currently_active): Return bool.
7828         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7829         (_initialize_ravenscar): Remove "(void)".
7830         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7831         Return bool.
7832
7833 2019-02-15  Tom Tromey  <tromey@adacore.com>
7834
7835         * ravenscar-thread.c (ravenscar_runtime_initializer)
7836         (has_ravenscar_runtime, get_running_thread_id)
7837         (ravenscar_thread_target::resume): Fix indentation.
7838
7839 2019-02-15  Tom Tromey  <tromey@adacore.com>
7840
7841         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7842         from ravenscar_arch_ops.
7843         (sparc_ravenscar_ops::fetch_registers)
7844         (sparc_ravenscar_ops::store_registers): Now methods.
7845         (sparc_ravenscar_prepare_to_store): Remove.
7846         (sparc_ravenscar_ops): Redefine.
7847         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7848         methods and destructor.  Remove members.
7849         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7850         (ravenscar_thread_target::store_registers)
7851         (ravenscar_thread_target::prepare_to_store): Update.
7852         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7853         Remove.
7854         (struct ppc_ravenscar_powerpc_ops): Derive from
7855         ravenscar_arch_ops.
7856         (ppc_ravenscar_powerpc_ops::fetch_registers)
7857         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7858         (ppc_ravenscar_powerpc_ops): Redefine.
7859         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7860         (ppc_ravenscar_e500_ops::fetch_registers)
7861         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7862         (ppc_ravenscar_e500_ops): Redefine.
7863         * aarch64-ravenscar-thread.c
7864         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7865         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7866         (aarch64_ravenscar_fetch_registers)
7867         (aarch64_ravenscar_store_registers): Now methods.
7868         (aarch64_ravenscar_ops): Redefine.
7869
7870 2019-02-15  Tom Tromey  <tromey@adacore.com>
7871
7872         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7873         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7874         (ravenscar_thread_target::stopped_by_watchpoint)
7875         (ravenscar_thread_target::stopped_data_address)
7876         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7877
7878 2019-02-15  Tom Tromey  <tromey@adacore.com>
7879
7880         * ravenscar-thread.c: Fix some typos.
7881
7882 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7883             Tom Tromey  <tromey@adacore.com>
7884
7885         * ada-lang.c (ada_exception_sal): Change addr_string to a
7886         std::string.
7887         (create_ada_exception_catchpoint): Update.
7888
7889 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7890             Tom Tromey  <tromey@adacore.com>
7891
7892         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7893         (bp_location_ops): Remove.
7894         (base_breakpoint_allocate_location): Update.
7895         (free_bp_location): Update.
7896         * ada-lang.c (class ada_catchpoint_location)
7897         <ada_catchpoint_location>: Remove ops parameter.
7898         (ada_catchpoint_location_dtor): Remove.
7899         (ada_catchpoint_location_ops): Remove.
7900         (allocate_location_exception): Update.
7901         * breakpoint.h (struct bp_location_ops): Remove.
7902         (class bp_location) <bp_location>: Remove bp_location_ops
7903         parameter.
7904         <~bp_location>: Add destructor.
7905         <ops>: Remove.
7906
7907 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7908             Pedro Alves  <palves@redhat.com>
7909
7910         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7911         'PATH_MAX'.
7912
7913 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7914             Samuel Thibault  <samuel.thibault@gnu.org>
7915             Thomas Schwinge  <thomas@codesourcery.com>
7916
7917         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7918         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7919
7920 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7921
7922         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7923         (check_empty): Use "const char *".
7924
7925         * gnu-nat.c (gnu_nat_target::detach): Instead of
7926         'detach_inferior (pid)' call
7927         'detach_inferior (find_inferior_pid (pid))'.
7928
7929         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7930         'nat/fork-inferior.o'.
7931         * gnu-nat.c: #include "nat/fork-inferior.h".
7932
7933         * gnu-nat.c (gnu_nat_target::detach): Instead of
7934         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7935         * gnu-nat.h: #include "inf-child.h".
7936         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7937         'i386_gnu_nat_target::fetch_registers'.
7938         (gnu_store_registers): Rename/move to
7939         'i386_gnu_nat_target::store_registers'.
7940
7941         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7942         * gnu-nat.h (mach_thread_info): New function.
7943         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7944
7945         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7946
7947 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7948
7949         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7950
7951 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7952
7953         * windows-nat.c (windows_add_thread): Add new parameter
7954         "main_thread_p" with default value set to false.  Update
7955         function documentation as well as all callers.
7956         (windows_delete_thread): Likewise.
7957         (fake_create_process): Update call to windows_add_thread.
7958         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7959         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7960         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7961         call to windows_delete_thread.
7962
7963 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7964
7965         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7966
7967 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7968
7969         * symfile.c (find_separate_debug_file): Use canonical path of
7970         sysroot with child_path instead of gdb_sysroot if it is valid.
7971
7972 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7973
7974         * symfile.c (find_separate_debug_file): Use child_path to
7975         determine if an object file is under a sysroot.
7976
7977 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7978
7979         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7980         unittests/child-path-selftests.c.
7981         * common/pathstuff.c (child_path): New function.
7982         * common/pathstuff.h (child_path): New prototype.
7983         * unittests/child-path-selftests.c: New file.
7984
7985 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7986
7987         * symfile.c (find_separate_debug_file): Look for separate debug
7988         files in debug directories under the sysroot.
7989
7990 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7991
7992         * symtab.h (struct minimal_symbol data_p): New const method.
7993         (struct minimal_symbol text_p): Likewise.
7994         * symtab.c (output_source_filename): Use file name style
7995         to print file name.
7996         (print_symbol_info): Likewise.
7997         (print_msymbol_info): Use address style to print addresses.
7998         Use function name style to print executable text symbols.
7999         (expand_symtab_containing_pc): Use data_p.
8000         (find_pc_sect_compunit_symtab): Likewise.
8001
8002 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8003
8004         * breakpoint.c (describe_other_breakpoints): Use address style
8005         to print addresses.
8006         (say_where): Likewise.
8007
8008 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8009
8010         * ada-typeprint.c (print_func_type): Print function name
8011         style to print function name.
8012         * c-typeprint.c (c_print_type_1): Likewise.
8013
8014 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8015
8016         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8017         for execve.
8018
8019 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8020
8021         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8022         type_stack.
8023
8024 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8025
8026         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8027         TYPE_CODE_REF types.
8028
8029 2019-02-08  Jim Wilson  <jimw@sifive.com>
8030
8031         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8032         (riscv_linux_fregset): New.
8033         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8034
8035 2019-02-07  Tom Tromey  <tom@tromey.com>
8036
8037         * thread.c (thread_cancel_execution_command): Update.
8038         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8039         methods.
8040         (struct thread_fsm_ops): Remove.
8041         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8042         (thread_fsm_should_stop, thread_fsm_return_value)
8043         (thread_fsm_set_finished, thread_fsm_finished_p)
8044         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8045         Don't declare.
8046         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8047         * infrun.c (clear_proceed_status_thread)
8048         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8049         (print_stop_event): Update.
8050         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8051         Add constructor.
8052         (step_command_fsm_ops): Remove.
8053         (new_step_command_fsm): Remove.
8054         (step_1): Update.
8055         (step_command_fsm::should_stop): Rename from
8056         step_command_fsm_should_stop.
8057         (step_command_fsm::clean_up): Rename from
8058         step_command_fsm_clean_up.
8059         (step_command_fsm::do_async_reply_reason): Rename from
8060         step_command_fsm_async_reply_reason.
8061         (struct until_next_fsm): Inherit from thread_fsm.  Add
8062         constructor.
8063         (until_next_fsm_ops): Remove.
8064         (new_until_next_fsm): Remove.
8065         (until_next_fsm::should_stop): Rename from
8066         until_next_fsm_should_stop.
8067         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8068         (until_next_fsm::do_async_reply_reason): Rename from
8069         until_next_fsm_async_reply_reason.
8070         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8071         constructor.  Change type of breakpoint.
8072         (finish_command_fsm_ops): Remove.
8073         (new_finish_command_fsm): Remove.
8074         (finish_command_fsm::should_stop): Rename from
8075         finish_command_fsm_should_stop.
8076         (finish_command_fsm::clean_up): Rename from
8077         finish_command_fsm_clean_up.
8078         (finish_command_fsm::return_value): Rename from
8079         finish_command_fsm_return_value.
8080         (finish_command_fsm::do_async_reply_reason): Rename from
8081         finish_command_fsm_async_reply_reason.
8082         (finish_command): Update.
8083         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8084         Add constructor.
8085         (call_thread_fsm_ops): Remove.
8086         (call_thread_fsm::call_thread_fsm): Rename from
8087         new_call_thread_fsm.
8088         (call_thread_fsm::should_stop): Rename from
8089         call_thread_fsm_should_stop.
8090         (call_thread_fsm::should_notify_stop): Rename from
8091         call_thread_fsm_should_notify_stop.
8092         (run_inferior_call, call_function_by_hand_dummy): Update.
8093         * cli/cli-interp.c (should_print_stop_to_console): Update.
8094         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8095         Add constructor.  Change type of location_breakpoint,
8096         caller_breakpoint.
8097         (until_break_fsm_ops): Remove.
8098         (new_until_break_fsm): Remove.
8099         (until_break_fsm::should_stop): Rename from
8100         until_break_fsm_should_stop.
8101         (until_break_fsm::clean_up): Rename from
8102         until_break_fsm_clean_up.
8103         (until_break_fsm::do_async_reply_reason): Rename from
8104         until_break_fsm_async_reply_reason.
8105         (until_break_command): Update.
8106         * thread-fsm.c: Remove.
8107         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8108
8109 2019-02-07  Tom Tromey  <tom@tromey.com>
8110
8111         * yy-remap.h: Add include guard.
8112         * xtensa-tdep.h: Add include guard.
8113         * xcoffread.h: Rename include guard.
8114         * varobj-iter.h: Add include guard.
8115         * tui/tui.h: Rename include guard.
8116         * tui/tui-winsource.h: Rename include guard.
8117         * tui/tui-wingeneral.h: Rename include guard.
8118         * tui/tui-windata.h: Rename include guard.
8119         * tui/tui-win.h: Rename include guard.
8120         * tui/tui-stack.h: Rename include guard.
8121         * tui/tui-source.h: Rename include guard.
8122         * tui/tui-regs.h: Rename include guard.
8123         * tui/tui-out.h: Rename include guard.
8124         * tui/tui-layout.h: Rename include guard.
8125         * tui/tui-io.h: Rename include guard.
8126         * tui/tui-hooks.h: Rename include guard.
8127         * tui/tui-file.h: Rename include guard.
8128         * tui/tui-disasm.h: Rename include guard.
8129         * tui/tui-data.h: Rename include guard.
8130         * tui/tui-command.h: Rename include guard.
8131         * tic6x-tdep.h: Add include guard.
8132         * target/waitstatus.h: Rename include guard.
8133         * target/wait.h: Rename include guard.
8134         * target/target.h: Rename include guard.
8135         * target/resume.h: Rename include guard.
8136         * target-float.h: Rename include guard.
8137         * stabsread.h: Add include guard.
8138         * rs6000-tdep.h: Add include guard.
8139         * riscv-fbsd-tdep.h: Add include guard.
8140         * regformats/regdef.h: Rename include guard.
8141         * record.h: Rename include guard.
8142         * python/python.h: Rename include guard.
8143         * python/python-internal.h: Rename include guard.
8144         * python/py-stopevent.h: Rename include guard.
8145         * python/py-ref.h: Rename include guard.
8146         * python/py-record.h: Rename include guard.
8147         * python/py-record-full.h: Rename include guard.
8148         * python/py-record-btrace.h: Rename include guard.
8149         * python/py-instruction.h: Rename include guard.
8150         * python/py-events.h: Rename include guard.
8151         * python/py-event.h: Rename include guard.
8152         * procfs.h: Add include guard.
8153         * proc-utils.h: Add include guard.
8154         * p-lang.h: Add include guard.
8155         * or1k-tdep.h: Rename include guard.
8156         * observable.h: Rename include guard.
8157         * nto-tdep.h: Rename include guard.
8158         * nat/x86-linux.h: Rename include guard.
8159         * nat/x86-linux-dregs.h: Rename include guard.
8160         * nat/x86-gcc-cpuid.h: Add include guard.
8161         * nat/x86-dregs.h: Rename include guard.
8162         * nat/x86-cpuid.h: Rename include guard.
8163         * nat/ppc-linux.h: Rename include guard.
8164         * nat/mips-linux-watch.h: Rename include guard.
8165         * nat/linux-waitpid.h: Rename include guard.
8166         * nat/linux-ptrace.h: Rename include guard.
8167         * nat/linux-procfs.h: Rename include guard.
8168         * nat/linux-osdata.h: Rename include guard.
8169         * nat/linux-nat.h: Rename include guard.
8170         * nat/linux-namespaces.h: Rename include guard.
8171         * nat/linux-btrace.h: Rename include guard.
8172         * nat/glibc_thread_db.h: Rename include guard.
8173         * nat/gdb_thread_db.h: Rename include guard.
8174         * nat/gdb_ptrace.h: Rename include guard.
8175         * nat/fork-inferior.h: Rename include guard.
8176         * nat/amd64-linux-siginfo.h: Rename include guard.
8177         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8178         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8179         * nat/aarch64-linux.h: Rename include guard.
8180         * nat/aarch64-linux-hw-point.h: Rename include guard.
8181         * mn10300-tdep.h: Add include guard.
8182         * mips-linux-tdep.h: Add include guard.
8183         * mi/mi-parse.h: Rename include guard.
8184         * mi/mi-out.h: Rename include guard.
8185         * mi/mi-main.h: Rename include guard.
8186         * mi/mi-interp.h: Rename include guard.
8187         * mi/mi-getopt.h: Rename include guard.
8188         * mi/mi-console.h: Rename include guard.
8189         * mi/mi-common.h: Rename include guard.
8190         * mi/mi-cmds.h: Rename include guard.
8191         * mi/mi-cmd-break.h: Rename include guard.
8192         * m2-lang.h: Add include guard.
8193         * location.h: Rename include guard.
8194         * linux-record.h: Rename include guard.
8195         * linux-nat.h: Add include guard.
8196         * linux-fork.h: Add include guard.
8197         * i386-darwin-tdep.h: Rename include guard.
8198         * hppa-linux-offsets.h: Add include guard.
8199         * guile/guile.h: Rename include guard.
8200         * guile/guile-internal.h: Rename include guard.
8201         * gnu-nat.h: Rename include guard.
8202         * gdb-stabs.h: Rename include guard.
8203         * frv-tdep.h: Add include guard.
8204         * f-lang.h: Add include guard.
8205         * event-loop.h: Add include guard.
8206         * darwin-nat.h: Rename include guard.
8207         * cp-abi.h: Rename include guard.
8208         * config/sparc/nm-sol2.h: Rename include guard.
8209         * config/nm-nto.h: Rename include guard.
8210         * config/nm-linux.h: Add include guard.
8211         * config/i386/nm-i386gnu.h: Rename include guard.
8212         * config/djgpp/nl_types.h: Rename include guard.
8213         * config/djgpp/langinfo.h: Rename include guard.
8214         * compile/gcc-cp-plugin.h: Add include guard.
8215         * compile/gcc-c-plugin.h: Add include guard.
8216         * compile/compile.h: Rename include guard.
8217         * compile/compile-object-run.h: Rename include guard.
8218         * compile/compile-object-load.h: Rename include guard.
8219         * compile/compile-internal.h: Rename include guard.
8220         * compile/compile-cplus.h: Rename include guard.
8221         * compile/compile-c.h: Rename include guard.
8222         * common/xml-utils.h: Rename include guard.
8223         * common/x86-xstate.h: Rename include guard.
8224         * common/version.h: Rename include guard.
8225         * common/vec.h: Rename include guard.
8226         * common/tdesc.h: Rename include guard.
8227         * common/selftest.h: Rename include guard.
8228         * common/scoped_restore.h: Rename include guard.
8229         * common/scoped_mmap.h: Rename include guard.
8230         * common/scoped_fd.h: Rename include guard.
8231         * common/safe-iterator.h: Rename include guard.
8232         * common/run-time-clock.h: Rename include guard.
8233         * common/refcounted-object.h: Rename include guard.
8234         * common/queue.h: Rename include guard.
8235         * common/ptid.h: Rename include guard.
8236         * common/print-utils.h: Rename include guard.
8237         * common/preprocessor.h: Rename include guard.
8238         * common/pathstuff.h: Rename include guard.
8239         * common/observable.h: Rename include guard.
8240         * common/netstuff.h: Rename include guard.
8241         * common/job-control.h: Rename include guard.
8242         * common/host-defs.h: Rename include guard.
8243         * common/gdb_wait.h: Rename include guard.
8244         * common/gdb_vecs.h: Rename include guard.
8245         * common/gdb_unlinker.h: Rename include guard.
8246         * common/gdb_unique_ptr.h: Rename include guard.
8247         * common/gdb_tilde_expand.h: Rename include guard.
8248         * common/gdb_sys_time.h: Rename include guard.
8249         * common/gdb_string_view.h: Rename include guard.
8250         * common/gdb_splay_tree.h: Rename include guard.
8251         * common/gdb_setjmp.h: Rename include guard.
8252         * common/gdb_ref_ptr.h: Rename include guard.
8253         * common/gdb_optional.h: Rename include guard.
8254         * common/gdb_locale.h: Rename include guard.
8255         * common/gdb_assert.h: Rename include guard.
8256         * common/filtered-iterator.h: Rename include guard.
8257         * common/filestuff.h: Rename include guard.
8258         * common/fileio.h: Rename include guard.
8259         * common/environ.h: Rename include guard.
8260         * common/common-utils.h: Rename include guard.
8261         * common/common-types.h: Rename include guard.
8262         * common/common-regcache.h: Rename include guard.
8263         * common/common-inferior.h: Rename include guard.
8264         * common/common-gdbthread.h: Rename include guard.
8265         * common/common-exceptions.h: Rename include guard.
8266         * common/common-defs.h: Rename include guard.
8267         * common/common-debug.h: Rename include guard.
8268         * common/cleanups.h: Rename include guard.
8269         * common/buffer.h: Rename include guard.
8270         * common/btrace-common.h: Rename include guard.
8271         * common/break-common.h: Rename include guard.
8272         * cli/cli-utils.h: Rename include guard.
8273         * cli/cli-style.h: Rename include guard.
8274         * cli/cli-setshow.h: Rename include guard.
8275         * cli/cli-script.h: Rename include guard.
8276         * cli/cli-interp.h: Rename include guard.
8277         * cli/cli-decode.h: Rename include guard.
8278         * cli/cli-cmds.h: Rename include guard.
8279         * charset-list.h: Add include guard.
8280         * buildsym-legacy.h: Rename include guard.
8281         * bfin-tdep.h: Add include guard.
8282         * ax.h: Rename include guard.
8283         * arm-linux-tdep.h: Add include guard.
8284         * arm-fbsd-tdep.h: Add include guard.
8285         * arch/xtensa.h: Rename include guard.
8286         * arch/tic6x.h: Add include guard.
8287         * arch/i386.h: Add include guard.
8288         * arch/arm.h: Rename include guard.
8289         * arch/arm-linux.h: Rename include guard.
8290         * arch/arm-get-next-pcs.h: Rename include guard.
8291         * arch/amd64.h: Add include guard.
8292         * arch/aarch64-insn.h: Rename include guard.
8293         * arch-utils.h: Rename include guard.
8294         * annotate.h: Add include guard.
8295         * amd64-darwin-tdep.h: Rename include guard.
8296         * aarch64-linux-tdep.h: Add include guard.
8297         * aarch64-fbsd-tdep.h: Add include guard.
8298         * aarch32-linux-nat.h: Add include guard.
8299
8300 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8301
8302         * macrotab.c (macro_define_internal): New function that
8303         factorizes macro_define_object_internal and macro_define_function
8304         code.
8305         (macro_define_object_internal): Use macro_define_internal.
8306         (macro_define_function): Likewise.
8307
8308 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8309
8310         * macrocmd.c (extract_identifier): Return
8311         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8312         callers.
8313
8314 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8315
8316         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8317
8318 2019-02-05  Tom Tromey  <tom@tromey.com>
8319
8320         * target.c (target_stack::unpush): Move assertion earlier.
8321
8322 2019-01-30  Tom Tromey  <tom@tromey.com>
8323
8324         PR python/23615:
8325         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8326         (gdbpy_parse_and_eval): Likewise.
8327         * python/python-internal.h (gdbpy_allow_threads): New class.
8328
8329 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8330
8331         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8332         (aarch64_fbsd_fpregmap): Move earlier.
8333         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8334         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8335         instead of individual calls to trad_frame_set_reg_addr.
8336         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8337         earlier.
8338         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8339         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8340         instead of individual calls to trad_frame_set_reg_addr.
8341
8342 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8343
8344         * CONTRIBUTE: Replace contribution list with wiki link.
8345
8346 2019-01-25  Tom Tromey  <tom@tromey.com>
8347
8348         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8349
8350 2019-01-25  Tom Tromey  <tom@tromey.com>
8351
8352         * xtensa-linux-nat.c: Fix common/ includes.
8353         * xml-support.h: Fix common/ includes.
8354         * xml-support.c: Fix common/ includes.
8355         * x86-linux-nat.c: Fix common/ includes.
8356         * windows-nat.c: Fix common/ includes.
8357         * varobj.h: Fix common/ includes.
8358         * varobj.c: Fix common/ includes.
8359         * value.c: Fix common/ includes.
8360         * valops.c: Fix common/ includes.
8361         * utils.c: Fix common/ includes.
8362         * unittests/xml-utils-selftests.c: Fix common/ includes.
8363         * unittests/utils-selftests.c: Fix common/ includes.
8364         * unittests/unpack-selftests.c: Fix common/ includes.
8365         * unittests/tracepoint-selftests.c: Fix common/ includes.
8366         * unittests/style-selftests.c: Fix common/ includes.
8367         * unittests/string_view-selftests.c: Fix common/ includes.
8368         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8369         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8370         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8371         * unittests/rsp-low-selftests.c: Fix common/ includes.
8372         * unittests/parse-connection-spec-selftests.c: Fix common/
8373         includes.
8374         * unittests/optional-selftests.c: Fix common/ includes.
8375         * unittests/offset-type-selftests.c: Fix common/ includes.
8376         * unittests/observable-selftests.c: Fix common/ includes.
8377         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8378         * unittests/memrange-selftests.c: Fix common/ includes.
8379         * unittests/memory-map-selftests.c: Fix common/ includes.
8380         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8381         * unittests/function-view-selftests.c: Fix common/ includes.
8382         * unittests/environ-selftests.c: Fix common/ includes.
8383         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8384         * unittests/common-utils-selftests.c: Fix common/ includes.
8385         * unittests/cli-utils-selftests.c: Fix common/ includes.
8386         * unittests/array-view-selftests.c: Fix common/ includes.
8387         * ui-file.c: Fix common/ includes.
8388         * tui/tui-io.c: Fix common/ includes.
8389         * tracepoint.h: Fix common/ includes.
8390         * tracepoint.c: Fix common/ includes.
8391         * tracefile-tfile.c: Fix common/ includes.
8392         * top.h: Fix common/ includes.
8393         * top.c: Fix common/ includes.
8394         * thread.c: Fix common/ includes.
8395         * target/waitstatus.h: Fix common/ includes.
8396         * target/waitstatus.c: Fix common/ includes.
8397         * target.h: Fix common/ includes.
8398         * target.c: Fix common/ includes.
8399         * target-memory.c: Fix common/ includes.
8400         * target-descriptions.c: Fix common/ includes.
8401         * symtab.h: Fix common/ includes.
8402         * symfile.c: Fix common/ includes.
8403         * stap-probe.c: Fix common/ includes.
8404         * spu-linux-nat.c: Fix common/ includes.
8405         * sparc-nat.c: Fix common/ includes.
8406         * source.c: Fix common/ includes.
8407         * solib.c: Fix common/ includes.
8408         * solib-target.c: Fix common/ includes.
8409         * ser-unix.c: Fix common/ includes.
8410         * ser-tcp.c: Fix common/ includes.
8411         * ser-pipe.c: Fix common/ includes.
8412         * ser-base.c: Fix common/ includes.
8413         * selftest-arch.c: Fix common/ includes.
8414         * s12z-tdep.c: Fix common/ includes.
8415         * rust-exp.y: Fix common/ includes.
8416         * rs6000-aix-tdep.c: Fix common/ includes.
8417         * riscv-tdep.c: Fix common/ includes.
8418         * remote.c: Fix common/ includes.
8419         * remote-notif.h: Fix common/ includes.
8420         * remote-fileio.h: Fix common/ includes.
8421         * remote-fileio.c: Fix common/ includes.
8422         * regcache.h: Fix common/ includes.
8423         * regcache.c: Fix common/ includes.
8424         * record-btrace.c: Fix common/ includes.
8425         * python/python.c: Fix common/ includes.
8426         * python/py-type.c: Fix common/ includes.
8427         * python/py-inferior.c: Fix common/ includes.
8428         * progspace.h: Fix common/ includes.
8429         * producer.c: Fix common/ includes.
8430         * procfs.c: Fix common/ includes.
8431         * proc-api.c: Fix common/ includes.
8432         * printcmd.c: Fix common/ includes.
8433         * ppc-linux-nat.c: Fix common/ includes.
8434         * parser-defs.h: Fix common/ includes.
8435         * osdata.c: Fix common/ includes.
8436         * obsd-nat.c: Fix common/ includes.
8437         * nat/x86-linux.c: Fix common/ includes.
8438         * nat/x86-linux-dregs.c: Fix common/ includes.
8439         * nat/x86-dregs.h: Fix common/ includes.
8440         * nat/x86-dregs.c: Fix common/ includes.
8441         * nat/ppc-linux.c: Fix common/ includes.
8442         * nat/mips-linux-watch.h: Fix common/ includes.
8443         * nat/mips-linux-watch.c: Fix common/ includes.
8444         * nat/linux-waitpid.c: Fix common/ includes.
8445         * nat/linux-ptrace.h: Fix common/ includes.
8446         * nat/linux-ptrace.c: Fix common/ includes.
8447         * nat/linux-procfs.c: Fix common/ includes.
8448         * nat/linux-personality.c: Fix common/ includes.
8449         * nat/linux-osdata.c: Fix common/ includes.
8450         * nat/linux-namespaces.c: Fix common/ includes.
8451         * nat/linux-btrace.h: Fix common/ includes.
8452         * nat/linux-btrace.c: Fix common/ includes.
8453         * nat/fork-inferior.c: Fix common/ includes.
8454         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8455         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8456         * nat/aarch64-linux.c: Fix common/ includes.
8457         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8458         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8459         * namespace.h: Fix common/ includes.
8460         * mips-linux-tdep.c: Fix common/ includes.
8461         * minsyms.c: Fix common/ includes.
8462         * mi/mi-parse.h: Fix common/ includes.
8463         * mi/mi-main.c: Fix common/ includes.
8464         * mi/mi-cmd-env.c: Fix common/ includes.
8465         * memrange.h: Fix common/ includes.
8466         * memattr.c: Fix common/ includes.
8467         * maint.h: Fix common/ includes.
8468         * maint.c: Fix common/ includes.
8469         * main.c: Fix common/ includes.
8470         * machoread.c: Fix common/ includes.
8471         * location.c: Fix common/ includes.
8472         * linux-thread-db.c: Fix common/ includes.
8473         * linux-nat.c: Fix common/ includes.
8474         * linux-fork.c: Fix common/ includes.
8475         * inline-frame.c: Fix common/ includes.
8476         * infrun.c: Fix common/ includes.
8477         * inflow.c: Fix common/ includes.
8478         * inferior.h: Fix common/ includes.
8479         * inferior.c: Fix common/ includes.
8480         * infcmd.c: Fix common/ includes.
8481         * inf-ptrace.c: Fix common/ includes.
8482         * inf-child.c: Fix common/ includes.
8483         * ia64-linux-nat.c: Fix common/ includes.
8484         * i387-tdep.c: Fix common/ includes.
8485         * i386-tdep.c: Fix common/ includes.
8486         * i386-linux-tdep.c: Fix common/ includes.
8487         * i386-linux-nat.c: Fix common/ includes.
8488         * i386-go32-tdep.c: Fix common/ includes.
8489         * i386-fbsd-tdep.c: Fix common/ includes.
8490         * i386-fbsd-nat.c: Fix common/ includes.
8491         * guile/scm-type.c: Fix common/ includes.
8492         * guile/guile.c: Fix common/ includes.
8493         * go32-nat.c: Fix common/ includes.
8494         * gnu-nat.c: Fix common/ includes.
8495         * gdbthread.h: Fix common/ includes.
8496         * gdbarch-selftests.c: Fix common/ includes.
8497         * gdb_usleep.c: Fix common/ includes.
8498         * gdb_select.h: Fix common/ includes.
8499         * gdb_bfd.c: Fix common/ includes.
8500         * gcore.c: Fix common/ includes.
8501         * fork-child.c: Fix common/ includes.
8502         * findvar.c: Fix common/ includes.
8503         * fbsd-nat.c: Fix common/ includes.
8504         * event-top.c: Fix common/ includes.
8505         * event-loop.c: Fix common/ includes.
8506         * dwarf2read.c: Fix common/ includes.
8507         * dwarf2loc.c: Fix common/ includes.
8508         * dwarf2-frame.c: Fix common/ includes.
8509         * dwarf-index-cache.c: Fix common/ includes.
8510         * dtrace-probe.c: Fix common/ includes.
8511         * disasm-selftests.c: Fix common/ includes.
8512         * defs.h: Fix common/ includes.
8513         * csky-tdep.c: Fix common/ includes.
8514         * cp-valprint.c: Fix common/ includes.
8515         * cp-support.h: Fix common/ includes.
8516         * cp-support.c: Fix common/ includes.
8517         * corelow.c: Fix common/ includes.
8518         * completer.h: Fix common/ includes.
8519         * completer.c: Fix common/ includes.
8520         * compile/compile.c: Fix common/ includes.
8521         * compile/compile-loc2c.c: Fix common/ includes.
8522         * compile/compile-cplus-types.c: Fix common/ includes.
8523         * compile/compile-cplus-symbols.c: Fix common/ includes.
8524         * command.h: Fix common/ includes.
8525         * cli/cli-dump.c: Fix common/ includes.
8526         * cli/cli-cmds.c: Fix common/ includes.
8527         * charset.c: Fix common/ includes.
8528         * build-id.c: Fix common/ includes.
8529         * btrace.h: Fix common/ includes.
8530         * btrace.c: Fix common/ includes.
8531         * breakpoint.h: Fix common/ includes.
8532         * breakpoint.c: Fix common/ includes.
8533         * ax.h:
8534         (enum agent_op): Fix common/ includes.
8535         * ax-general.c (struct aop_map): Fix common/ includes.
8536         * ax-gdb.c: Fix common/ includes.
8537         * auxv.c: Fix common/ includes.
8538         * auto-load.c: Fix common/ includes.
8539         * arm-tdep.c: Fix common/ includes.
8540         * arch/riscv.c: Fix common/ includes.
8541         * arch/ppc-linux-common.c: Fix common/ includes.
8542         * arch/i386.c: Fix common/ includes.
8543         * arch/arm.c: Fix common/ includes.
8544         * arch/arm-linux.c: Fix common/ includes.
8545         * arch/arm-get-next-pcs.c: Fix common/ includes.
8546         * arch/amd64.c: Fix common/ includes.
8547         * arch/aarch64.c: Fix common/ includes.
8548         * arch/aarch64-insn.c: Fix common/ includes.
8549         * arch-utils.c: Fix common/ includes.
8550         * amd64-windows-tdep.c: Fix common/ includes.
8551         * amd64-tdep.c: Fix common/ includes.
8552         * amd64-sol2-tdep.c: Fix common/ includes.
8553         * amd64-obsd-tdep.c: Fix common/ includes.
8554         * amd64-nbsd-tdep.c: Fix common/ includes.
8555         * amd64-linux-tdep.c: Fix common/ includes.
8556         * amd64-linux-nat.c: Fix common/ includes.
8557         * amd64-fbsd-tdep.c: Fix common/ includes.
8558         * amd64-fbsd-nat.c: Fix common/ includes.
8559         * amd64-dicos-tdep.c: Fix common/ includes.
8560         * amd64-darwin-tdep.c: Fix common/ includes.
8561         * agent.c: Fix common/ includes.
8562         * ada-lang.h: Fix common/ includes.
8563         * ada-lang.c: Fix common/ includes.
8564         * aarch64-tdep.c: Fix common/ includes.
8565
8566 2019-01-25  Tom Tromey  <tom@tromey.com>
8567
8568         * common/create-version.sh: Use common/version.h.
8569
8570 2019-01-24  Pedro Alves  <palves@redhat.com>
8571
8572         * infrun.c (signal_stop, signal_print, signal_program)
8573         (signal_catch, signal_pass): Now arrays instead of pointers.
8574         (update_signals_program_target, do_target_resume)
8575         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8576         * linux-nat.c (linux_nat_target::pass_signals)
8577         (linux_nat_target::create_inferior, linux_nat_target::attach):
8578         Adjust.
8579         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8580         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8581         * procfs.c (procfs_target::pass_signals): Adjust.
8582         * record-full.c (record_full_target::resume): Adjust.
8583         * remote.c (remote_target::pass_signals)
8584         (remote_target::program_signals): Adjust.
8585         * target-debug.h (target_debug_print_signals): Now takes a
8586         gdb::array_view as parameter.  Adjust.
8587         * target.h (target_ops) <pass_signals, program_signals>: Replace
8588         pointer and length parameters with gdb::array_view.
8589         (target_pass_signals, target_program_signals): Likewise.
8590         * target-delegates.c: Regenerate.
8591
8592 2019-01-24  Pedro Alves  <palves@redhat.com>
8593
8594         * common/forward-scope-exit.h
8595         (forward_scope_exit::forward_scope_exit): Pass arguments to
8596         m_bind_function directly, instead of creating a std::bind and
8597         copying that.
8598
8599 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8600
8601         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8602         for static members.
8603         (pass_in_v_vfp_candidate): Likewise.
8604
8605 2019-01-23  Tom Tromey  <tom@tromey.com>
8606             Pedro Alves  <palves@redhat.com>
8607
8608         * regcache.c (class regcache_invalidator): Remove.
8609         (regcache::raw_write): Use make_scope_exit.
8610
8611 2019-01-23  Tom Tromey  <tom@tromey.com>
8612
8613         * ui-out.h (class ui_out_emit_type): Update comment.
8614
8615 2019-01-23  Tom Tromey  <tom@tromey.com>
8616
8617         * infrun.c (fetch_inferior_event): Update comment.
8618
8619 2019-01-23  Tom Tromey  <tom@tromey.com>
8620             Pedro Alves  <palves@redhat.com>
8621
8622         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8623         parameter.
8624         (fetch_inferior_event): Use SCOPE_EXIT.
8625
8626
8627 2019-01-23  Tom Tromey  <tom@tromey.com>
8628             Pedro Alves  <palves@redhat.com>
8629
8630         * infrun.c (disable_thread_events): Delete.
8631         (stop_all_threads): Use SCOPE_EXIT.
8632
8633 2019-01-23  Tom Tromey  <tom@tromey.com>
8634             Pedro Alves  <palves@redhat.com>
8635
8636         * symfile.c: Include forward-scope-exit.h.
8637         (clear_symtab_users_cleanup): Replace forward declaration with
8638         a FORWARD_SCOPE_EXIT.
8639         (syms_from_objfile_1): Use the forward_scope_exit and
8640         gdb::optional instead of cleanup_function.
8641         (reread_symbols): Use the forward_scope_exit instead of
8642         cleanup_function.
8643         (clear_symtab_users_cleanup): Remove function.
8644
8645 2019-01-23  Tom Tromey  <tom@tromey.com>
8646             Pedro Alves  <palves@redhat.com>
8647
8648         * linux-nat.c: Include scope-exit.h.
8649         (cleanup_target_stop): Remove.
8650         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8651         SCOPE_EXIT.
8652
8653 2019-01-23  Tom Tromey  <tom@tromey.com>
8654             Pedro Alves  <palves@redhat.com>
8655
8656         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8657         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8658
8659 2019-01-23  Tom Tromey  <tom@tromey.com>
8660             Andrew Burgess  <andrew.burgess@embecosm.com>
8661             Pedro Alves  <palves@redhat.com>
8662
8663         * infrun.c (fetch_inferior_event): Use scope_exit.
8664         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8665         * top.c (execute_command): Use scope_exit.
8666         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8667         * utils.c (do_bpstat_clear_actions_cleanup)
8668         (make_bpstat_clear_actions_cleanup): Remove.
8669
8670 2019-01-23  Tom Tromey  <tom@tromey.com>
8671             Pedro Alves  <palves@redhat.com>
8672
8673         * infrun.c: Include "common/scope-exit.h"
8674         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8675         (wait_for_inferior): Use SCOPE_EXIT.
8676         (fetch_inferior_event): Use scope_exit.
8677
8678 2019-01-23  Tom Tromey  <tom@tromey.com>
8679             Pedro Alves  <palves@redhat.com>
8680
8681         * breakpoint.c (create_breakpoint): Remove cleanup.
8682
8683 2019-01-23  Tom Tromey  <tom@tromey.com>
8684             Andrew Burgess  <andrew.burgess@embecosm.com>
8685             Pedro Alves  <palves@redhat.com>
8686
8687 2019-01-23  Pedro Alves  <palves@redhat.com>
8688
8689         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8690
8691 2019-01-23  Pedro Alves  <palves@redhat.com>
8692             Andrew Burgess  <andrew.burgess@embecosm.com>
8693
8694         * gdbthread.h: Include "common/forward-scope-exit.h".
8695         (scoped_finish_thread_state): Redefine custom class in terms of
8696         forward_scope_exit.
8697
8698 2019-01-23  Pedro Alves  <palves@redhat.com>
8699             Andrew Burgess  <andrew.burgess@embecosm.com>
8700
8701         * common/forward-scope-exit.h: New file.
8702
8703 2019-01-23  Pedro Alves  <palves@redhat.com>
8704             Andrew Burgess  <andrew.burgess@embecosm.com>
8705             Tom Tromey  <tom@tromey.com>
8706
8707         * common/scope-exit.h: New file.
8708
8709 2019-01-23  Pedro Alves  <palves@redhat.com>
8710
8711         * common/preprocessor.h (ESC): Rename to ...
8712         (ESC_PARENS): ... this.
8713         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8714         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8715
8716 2019-01-23  Tom Tromey  <tom@tromey.com>
8717
8718         * language.h (class scoped_switch_to_sym_language_if_auto):
8719         Initialize m_lang in both cases.
8720
8721 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8722
8723         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8724         with XCNEW.
8725
8726 2019-01-22  Tom Tromey  <tom@tromey.com>
8727
8728         * corelow.c: Do not include sys/file.h.
8729
8730 2019-01-22  Tom Tromey  <tom@tromey.com>
8731
8732         * tui/tui-wingeneral.h: Include gdb_curses.h.
8733
8734 2019-01-22  Tom Tromey  <tom@tromey.com>
8735
8736         * source-cache.h (class source_cache) <get_source_lines,
8737         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8738
8739 2019-01-22  Tom Tromey  <tom@tromey.com>
8740
8741         * remote-fileio.h (struct remote_target): Declare.
8742
8743 2019-01-22  Tom Tromey  <tom@tromey.com>
8744
8745         * python/py-arch.c: Do not include py-ref.h.
8746         * python/py-bpevent.c: Do not include py-ref.h.
8747         * python/py-cmd.c: Do not include py-ref.h.
8748         * python/py-continueevent.c: Do not include py-ref.h.
8749         * python/py-event.h: Do not include py-ref.h.
8750         * python/py-evtregistry.c: Do not include py-ref.h.
8751         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8752         * python/py-frame.c: Do not include py-ref.h.
8753         * python/py-framefilter.c: Do not include py-ref.h.
8754         * python/py-function.c: Do not include py-ref.h.
8755         * python/py-infevents.c: Do not include py-ref.h.
8756         * python/py-linetable.c: Do not include py-ref.h.
8757         * python/py-objfile.c: Do not include py-ref.h.
8758         * python/py-param.c: Do not include py-ref.h.
8759         * python/py-prettyprint.c: Do not include py-ref.h.
8760         * python/py-progspace.c: Do not include py-ref.h.
8761         * python/py-symbol.c: Do not include py-ref.h.
8762         * python/py-symtab.c: Do not include py-ref.h.
8763         * python/py-type.c: Do not include py-ref.h.
8764         * python/py-unwind.c: Do not include py-ref.h.
8765         * python/py-utils.c: Do not include py-ref.h.
8766         * python/py-value.c: Do not include py-ref.h.
8767         * python/py-varobj.c: Do not include py-ref.h.
8768         * python/py-xmethods.c: Do not include py-ref.h.
8769         * python/python.c: Do not include py-ref.h.
8770         * varobj.c: Do not include py-ref.h.
8771
8772 2019-01-22  Tom Tromey  <tom@tromey.com>
8773
8774         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8775         keyword for bcache.
8776
8777 2019-01-22  Tom Tromey  <tom@tromey.com>
8778
8779         * compile/compile-cplus-types.c: Remove a comment by #include.
8780
8781 2019-01-22  Tom Tromey  <tom@tromey.com>
8782
8783         * compile/gcc-c-plugin.h: Include compile-internal.h.
8784
8785 2019-01-22  Tom Tromey  <tom@tromey.com>
8786
8787         * stabsread.c (EXTERN): Do not define.
8788         (symnum, next_symbol_text_func, processing_gcc_compilation)
8789         (within_function, global_sym_chain, global_stabs)
8790         (previous_stab_code, this_object_header_files)
8791         (n_this_object_header_files)
8792         (n_allocated_this_object_header_files): Define.
8793         * stabsread.h (EXTERN): Never define.  Use "extern".
8794
8795 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8796
8797         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8798         history_value.
8799
8800 2019-01-21  Tom Tromey  <tom@tromey.com>
8801
8802         * ui-out.c: Fix includes.
8803         * tui/tui-source.c: Fix includes.
8804         * target.c: Fix includes.
8805         * remote.c: Fix includes.
8806         * regcache.c: Fix includes.
8807         * python/py-block.c: Fix includes.
8808         * printcmd.c: Fix includes.
8809         * or1k-tdep.c: Fix includes.
8810         * mi/mi-main.c: Fix includes.
8811         * m32r-tdep.c: Fix includes.
8812         * csky-tdep.c: Fix includes.
8813         * compile/compile-cplus-types.c: Fix includes.
8814         * cli/cli-interp.c: Fix includes.
8815
8816 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8817
8818         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8819         for padding.
8820
8821 2019-01-16  Tom Tromey  <tom@tromey.com>
8822
8823         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8824         earlier.
8825         (struct objfile) <msymbols_range>: Move from top level.
8826         <msymbols>: New method.
8827         (class objfile_msymbols): Remove.
8828         * symtab.c (default_collect_symbol_completion_matches_break_on):
8829         Update.
8830         * symmisc.c (dump_msymbols): Update.
8831         * stabsread.c (scan_file_globals): Update.
8832         * objc-lang.c (info_selectors_command, info_classes_command)
8833         (find_methods): Update.
8834         * minsyms.c (find_solib_trampoline_target): Update.
8835         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8836         * coffread.c (coff_symfile_read): Update.
8837         * ada-lang.c (ada_lookup_simple_minsym)
8838         (ada_collect_symbol_completion_matches): Update.
8839
8840 2019-01-16  Tom Tromey  <tom@tromey.com>
8841
8842         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8843         type.  Remove no-argument constructor.
8844         <iterator::operator++>: Simplify.
8845         <begin>: Update.
8846         <end>: Use minimal_symbol_count.
8847
8848 2019-01-16  Tom Tromey  <tom@tromey.com>
8849
8850         * objfiles.h (struct objfile) <psymtabs>: New method.
8851         (class objfile_psymtabs): Remove.
8852         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8853         typedef.
8854         <range>: New method.
8855         (require_partial_symbols): Change return type.
8856         * psymtab.c (require_partial_symbols)
8857         (psym_expand_symtabs_matching): Update.
8858         * mdebugread.c (parse_partial_symbols): Update.
8859         * dbxread.c (dbx_end_psymtab): Update.
8860
8861 2019-01-15  Tom Tromey  <tom@tromey.com>
8862
8863         * symtab.c (lookup_objfile_from_block)
8864         (lookup_symbol_in_objfile_symtabs)
8865         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8866         (find_line_symtab, info_sources_command)
8867         (default_collect_symbol_completion_matches_break_on)
8868         (make_source_files_completion_list): Update.
8869         * symmisc.c (print_objfile_statistics, dump_objfile)
8870         (maintenance_print_symbols, maintenance_info_symtabs)
8871         (maintenance_check_symtabs, maintenance_info_line_tables):
8872         Update.
8873         * source.c (select_source_symtab)
8874         (forget_cached_source_info_for_objfile): Update.
8875         * objfiles.h (class objfile_compunits): Remove.
8876         (struct objfile) <compunits_range>: New typedef.
8877         (compunits): New method.
8878         * objfiles.c (objfile_relocate1): Update.
8879         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8880         * maint.c (count_symtabs_and_blocks): Update.
8881         * linespec.c (iterate_over_all_matching_symtabs): Update.
8882         * cp-support.c (add_symbol_overload_list_qualified): Update.
8883         * coffread.c (coff_symtab_read): Update.
8884         * ada-lang.c (add_nonlocal_symbols)
8885         (ada_collect_symbol_completion_matches)
8886         (ada_add_global_exceptions): Update.
8887
8888 2019-01-15  Tom Tromey  <tom@tromey.com>
8889
8890         * progspace.h (program_space) <objfiles_safe_range>: New
8891         typedef.
8892         <objfiles_safe>: New method.
8893         * objfiles.h (class all_objfiles_safe): Remove.
8894         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8895         * jit.c (jit_inferior_exit_hook): Update.
8896
8897 2019-01-17  Tom Tromey  <tom@tromey.com>
8898
8899         * progspace.h (program_space) <objfiles_range>: New typedef.
8900         <objfiles>: New method.
8901         <objfiles_head>: Rename from objfiles.
8902         (object_files): Update.
8903         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8904         * guile/scm-pretty-print.c
8905         (ppscm_find_pretty_printer_from_objfiles): Update.
8906         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8907         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8908         Update.
8909         * python/py-progspace.c (pspy_get_objfiles): Update.
8910         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8911         Update.
8912         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8913         (objfpy_lookup_objfile_by_build_id): Update.
8914         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8915         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8916         Update.
8917         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8918         (expand_symtab_containing_pc, lookup_objfile_from_block)
8919         (lookup_static_symbol, basic_lookup_transparent_type)
8920         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8921         (find_line_symtab, info_sources_command)
8922         (default_collect_symbol_completion_matches_break_on)
8923         (make_source_files_completion_list, find_main_name): Update.
8924         * symmisc.c (print_symbol_bcache_statistics)
8925         (print_objfile_statistics, maintenance_print_symbols)
8926         (maintenance_print_msymbols, maintenance_print_objfiles)
8927         (maintenance_info_symtabs, maintenance_check_symtabs)
8928         (maintenance_expand_symtabs, maintenance_info_line_tables):
8929         Update.
8930         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8931         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8932         (map_overlay_command, unmap_overlay_command)
8933         (simple_overlay_update, expand_symtabs_matching)
8934         (map_symbol_filenames): Update.
8935         * symfile-debug.c (set_debug_symfile): Update.
8936         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8937         Update.
8938         * source.c (select_source_symtab, forget_cached_source_info):
8939         Update.
8940         * solib.c (solib_read_symbols): Update.
8941         * solib-spu.c (append_ocl_sos): Update.
8942         * psymtab.c (maintenance_print_psymbols)
8943         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8944         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8945         * printcmd.c (info_symbol_command): Update.
8946         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8947         Update.
8948         * objfiles.h (class all_objfiles): Remove.
8949         * objfiles.c (have_partial_symbols, have_full_symbols)
8950         (have_minimal_symbols, qsort_cmp, update_section_map)
8951         (shared_objfile_contains_address_p)
8952         (default_iterate_over_objfiles_in_search_order): Update.
8953         * objc-lang.c (info_selectors_command, info_classes_command)
8954         (find_methods): Update.
8955         * minsyms.c (find_solib_trampoline_target): Update.
8956         * maint.c (maintenance_info_sections)
8957         (maintenance_translate_address, count_symtabs_and_blocks):
8958         Update.
8959         * main.c (captured_main_1): Update.
8960         * linux-thread-db.c (try_thread_db_load_from_pdir)
8961         (has_libpthread): Update.
8962         * linespec.c (iterate_over_all_matching_symtabs)
8963         (search_minsyms_for_name): Update.
8964         * jit.c (jit_find_objf_with_entry_addr): Update.
8965         * hppa-tdep.c (find_unwind_entry)
8966         (hppa_lookup_stub_minimal_symbol): Update.
8967         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8968         Update.
8969         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8970         (elf_gnu_ifunc_resolve_by_got): Update.
8971         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8972         * dwarf-index-write.c (save_gdb_index_command): Update.
8973         * cp-support.c (add_symbol_overload_list_qualified): Update.
8974         * breakpoint.c (create_overlay_event_breakpoint)
8975         (create_longjmp_master_breakpoint)
8976         (create_std_terminate_master_breakpoint)
8977         (create_exception_master_breakpoint): Update.
8978         * blockframe.c (find_pc_partial_function): Update.
8979         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8980         (ada_collect_symbol_completion_matches)
8981         (ada_add_global_exceptions): Update.
8982
8983 2019-01-17  Tom Tromey  <tom@tromey.com>
8984
8985         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8986         declare VEC.
8987         (solib_target_parse_libraries): Change return type.
8988         (library_list_start_segment, library_list_start_section)
8989         (library_list_end_library, library_list_start_library); Update.
8990         (solib_target_free_library_list): Remove.
8991         (solib_target_parse_libraries): Remove cleanup.  Change return
8992         type.
8993         (solib_target_current_sos): Update.
8994
8995 2019-01-17  Tom Tromey  <tromey@bapiya>
8996
8997         * valprint.c: Replace "the the" with "the".
8998         * symtab.c: Replace "the the" with "the".
8999         * solib.c: Replace "the the" with "the".
9000         * solib-dsbt.c: Replace "the the" with "the".
9001         * linespec.c: Replace "the the" with "the".
9002         * dwarf2loc.h: Replace "the the" with "the".
9003         * amd64-windows-tdep.c: Replace "the the" with "the".
9004         * aarch64-tdep.c: Replace "the the" with "the".
9005
9006 2019-01-16  Keith Seitz  <keiths@redhat.com>
9007
9008         PR gdb/23773
9009         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9010         <builder>: Rename to ..
9011         <m_builder>: ... this and make private.
9012         (dwarf2_cu::get_builder): New method.  Change all users of
9013         `builder' to use this method.
9014         (dwarf2_start_symtab): Move to ...
9015         (dwarf2_cu::start_symtab): ... here.  Update all callers
9016         (setup_type_unit_groups): Move to ...
9017         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9018         callers.
9019         (dwarf2_cu::reset_builder): New method.
9020         (process_full_compunit, process_full_type_unit): Use
9021         dwarf2_cu::reset_builder.
9022         (follow_die_offset): Record the ancestor CU if it is different
9023         from the followed DIE's CU.
9024         (follow_die_sig_1): Likewise.
9025
9026 2019-01-15  Tom Tromey  <tom@tromey.com>
9027
9028         * remote.c (class remote_state) <buf>: Now a char_vector.
9029         <buf_size>: Remove.
9030         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9031         parameter.
9032         (remote_target::getpkt_or_notif_sane_1)
9033         (remote_target::getpkt_sane)
9034         (remote_target::getpkt_or_notif_sane): Likewise.
9035         (class remote_target) <putpkt>: New overload.
9036         (remote_target::read_frame): Change type of "buf_p".  Remove
9037         sizeof_p parameter.
9038         (packet_ok): New overload.
9039         (packet_check_result): New overload.
9040         Update all uses.
9041
9042 2019-01-14  Tom Tromey  <tom@tromey.com>
9043
9044         * remote-notif.c (handle_notification, remote_notif_ack)
9045         (remote_notif_parse): Make "buf" const.
9046         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9047         const.
9048         (remote_notif_parse, remote_notif_ack, handle_notification):
9049         Likewise.
9050         * remote.c (remote_notif_stop_parse): Make "buf" const.
9051         (remote_target::remote_parse_stop_reply): Make "buf" const.
9052         (remote_notif_stop_ack): Make "buf" const.
9053
9054 2019-01-14  Tom Tromey  <tom@tromey.com>
9055
9056         * remote.c (remote_console_output): Make parameter const.
9057
9058 2019-01-14  Tom Tromey  <tom@tromey.com>
9059
9060         * target-debug.h (target_debug_print_signals): Constify.
9061         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9062         * procfs.c (procfs_target::pass_signals): Update.
9063         * linux-nat.c (linux_nat_target::pass_signals): Update.
9064         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9065         * target-delegates.c: Rebuild.
9066         * remote.c (remote_target::program_signals): Update.
9067         (remote_target::pass_signals): Update.
9068         * target.c (target_pass_signals): Constify argument.
9069         (target_program_signals): Likewise.
9070         * target.h (struct target_ops) <pass_signals, program_signals>:
9071         Constify argument.
9072         (target_pass_signals, target_program_signals): Constify argument.
9073
9074 2019-01-14  Tom Tromey  <tom@tromey.com>
9075
9076         PR tui/28819:
9077         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9078
9079 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9080
9081         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9082         field.
9083         * rs6000-tdep.c: Include reggroups.h.
9084         (IS_V_ALIAS_PSEUDOREG): Define.
9085         (rs6000_register_name): Return names for the "vX" aliases.
9086         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9087         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9088         aliases.  Call default_register_reggroup_p for all other
9089         pseudo-registers.
9090         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9091         New functions.
9092         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9093         Handle "vX" aliases.
9094         (v_alias_pseudo_register_collect): New function.
9095         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9096         (rs6000_gdbarch_init): Initialize "vX" aliases as
9097         pseudo-registers.  Restore registration of
9098         rs6000_pseudo_register_reggroup_p with
9099         set_tdesc_pseudo_register_reggroup_p.
9100
9101 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9102
9103         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9104         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9105         set_gdbarch_num_pseudo_regs.
9106
9107 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9108
9109         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9110         Remove arg prefixname, add do_set and do_show.
9111         Add member functions set_list and show_list.
9112         * cli/cli-style.c (class cli_style_option): Update accordingly.
9113         (style_set_list): Move to file scope.
9114         (style_show_list): Likewise.
9115         (set_style): Call help_list.
9116         (show_style): Call cmd_show_list.
9117         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9118         Update to use the new macro.
9119
9120 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9121
9122         * ada-lang.c (_initialize_ada_language): Expand the help text
9123         for the "catch exception" command.
9124
9125 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9126
9127         * symtab.c (matching_obj_sections): Initialize obj,
9128         declare it closer to its usage.
9129
9130 2019-01-10  Tom Tromey  <tom@tromey.com>
9131
9132         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9133         (basic_inf_threads_range): Remove.
9134         (inf_threads_range, inf_non_exited_threads_range)
9135         (safe_inf_threads_range): Use next_adapter.
9136
9137 2019-01-10  Keith Seitz  <keiths@redhat.com>
9138
9139         PR gdb/23712
9140         PR symtab/23010
9141         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9142         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9143
9144 2019-01-10  Keith Seitz  <keiths@redhat.com>
9145
9146         PR gdb/23712
9147         PR symtab/23010
9148         * dictionary.c (pending_to_vector): Remove.
9149         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9150         Remove _1 suffix, replacing functions of the same name.  Update
9151         all callers.
9152         (dict_create_hashed, dict_create_hashed_expandable)
9153         (dict_create_linear, dict_create_linear_expandable, dict_free)
9154         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9155         Make functions static.
9156
9157 2019-01-10  Keith Seitz  <keiths@redhat.com>
9158
9159         PR gdb/23712
9160         PR symtab/23010
9161         * dictionary.h (struct dictionary): Replace declaration with
9162         multidictionary.
9163         (dict_create_hashed, dict_create_hashed_expandable)
9164         (dict_create_linear, dict_create_linear_expandable)
9165         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9166         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9167         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9168         taking multidictionary argument.
9169         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9170         * block.h (struct block) <dict>: Change to multidictionary
9171         and rename `multidict'.
9172         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9173         symmisc.c: Update all dictionary references to multidictionary.
9174
9175 2019-01-10  Keith Seitz  <keiths@redhat.com>
9176
9177         PR gdb/23712
9178         PR symtab/23010
9179         * dictionary.c: Include unordered_map.
9180         (pending_to_vector): New function.
9181         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9182         Rewrite the non-"_1" functions to take vector instead
9183         of linked list.
9184         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9185         "new" _1 versions of the same name.
9186         (multidictionary): Define.
9187         (std::hash<enum language): New definition.
9188         (collate_pending_symbols_by_language, mdict_create_hashed)
9189         (mdict_create_hashed_expandable, mdict_create_linear)
9190         (mdict_create_linear_expandable, mdict_free)
9191         (find_language_dictionary, create_new_language_dictionary)
9192         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9193         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9194         (mdict_size, mdict_empty): New functions.
9195         * dictionary.h (mdict_iterator): Define.
9196
9197 2019-01-10  Pedro Alves  <palves@redhat.com>
9198
9199         * breakpoint.c (read_uploaded_action)
9200         (create_tracepoint_from_upload): Adjust to use
9201         gdb::unique_xmalloc_ptr.
9202         * ctf.c (ctf_write_uploaded_tp):
9203         (SET_ARRAY_FIELD): Use emplace_back.
9204         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9205         * tracefile-tfile.c (tfile_write_uploaded_tp):
9206         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9207         gdb::unique_xmalloc_ptr.
9208         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9209         at_string, cond_string, cmd_strings>: Replace char pointers
9210         with gdb::unique_xmalloc_ptr.
9211
9212 2019-01-10  Pedro Alves  <palves@redhat.com>
9213
9214         * solib-target.c (library_list_start_library): Don't xstrdup name.
9215
9216 2019-01-10  Pedro Alves  <palves@redhat.com>
9217
9218         * mdebugread.c (parse_partial_symbols): Use
9219         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9220
9221 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9222
9223         * linux-fork.c (scoped_switch_fork_info)
9224         <~scoped_switch_fork_info>: Fix incorrect variable name.
9225
9226 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9227
9228         * linux-fork.c (scoped_switch_fork_info)
9229         <scoped_switch_fork_info>: Make explicit.
9230         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9231
9232 2019-01-10  Tom Tromey  <tom@tromey.com>
9233
9234         * objfiles.h (objfile::reset_psymtabs): Update.
9235         * objfiles.c (objfile::objfile): Update.
9236         * psymtab.h (psymtab_storage::obstack): Update.
9237         (psymtab_storage::m_obstack): Use gdb::optional.
9238         (class psymtab_storage): Update comment.  Remove objfile
9239         parameter.
9240         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9241
9242 2019-01-10  Tom Tromey  <tom@tromey.com>
9243
9244         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9245         <free_psymtabs>: Now private.
9246         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9247         (allocate_psymtab): Use new method.
9248
9249 2019-01-10  Tom Tromey  <tom@tromey.com>
9250
9251         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9252         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9253         * mdebugread.c (parse_partial_symbols): Use
9254         allocate_dependencies.
9255         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9256         allocate_dependencies.
9257         (process_psymtab_comp_unit_reader)
9258         (build_type_psymtab_dependencies): Likewise.
9259         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9260
9261 2019-01-10  Tom Tromey  <tom@tromey.com>
9262
9263         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9264         PSYMBOL_SET_LANGUAGE.
9265         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9266
9267 2019-01-10  Tom Tromey  <tom@tromey.com>
9268
9269         * psymtab.h (psymtab_storage::obstack): New method.
9270         <m_obstack>: Rename from obstack; now private.
9271         * psymtab.c (psymtab_storage): Update.
9272         * dwarf2read.c (create_addrmap_from_index)
9273         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9274         Update.
9275
9276 2019-01-10  Tom Tromey  <tom@tromey.com>
9277
9278         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9279         * objfiles.h (objfile::reset_psymtabs): New method.
9280
9281 2019-01-10  Tom Tromey  <tom@tromey.com>
9282
9283         * symmisc.c (print_symbol_bcache_statistics): Update.
9284         (print_objfile_statistics): Update.
9285         * symfile.c (reread_symbols): Update.
9286         * psymtab.h (class psymtab_storage): New.
9287         * psymtab.c (psymtab_storage): New constructor.
9288         (~psymtab_storage): New destructor.
9289         (require_partial_symbols): Update.
9290         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9291         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9292         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9293         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9294         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9295         (start_psymtab_common, end_psymtab_common)
9296         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9297         (allocate_psymtab): Update.
9298         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9299         Update.
9300         (dump_psymtab_addrmap, maintenance_print_psymbols)
9301         (maintenance_check_psymtabs): Update.
9302         (class objfile_psymtabs): Move to objfiles.h.
9303         * psympriv.h (discard_psymtab): Now inline.
9304         (psymtab_discarder::psymtab_discarder): Update.
9305         (psymtab_discarder::~psymtab_discarder): Update.
9306         (ALL_OBJFILE_PSYMTABS): Rewrite.
9307         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9308         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9309         Remove fields.
9310         <partial_symtabs>: New field.
9311         (class objfile_psymtabs): Move from psymtab.h.  Update.
9312         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9313         psymbol_cache.
9314         (objfile::~objfile): Don't destroy psymbol_cache.
9315         * mdebugread.c (parse_partial_symbols): Update.
9316         * dwarf2read.c (create_addrmap_from_index)
9317         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9318         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9319         (add_partial_subprogram, dwarf2_ranges_read): Update.
9320         * dwarf-index-write.c (write_address_map)
9321         (write_one_signatured_type, recursively_write_psymbols)
9322         (class debug_names, class debug_names, write_psymtabs_to_index):
9323         Update.
9324
9325 2019-01-10  Tom Tromey  <tom@tromey.com>
9326
9327         * symtab.h (SYMBOL_SET_NAMES): Update.
9328         (symbol_set_names): Update.
9329         (MSYMBOL_SET_NAMES): Update.
9330         * symtab.c (symbol_set_names): Change argument to be an
9331         objfile_per_bfd_storage.
9332         * psymtab.c (add_psymbol_to_bcache): Update.
9333         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9334
9335 2019-01-10  Tom Tromey  <tom@tromey.com>
9336
9337         * symtab.c (create_demangled_names_hash): Change argument to be an
9338         objfile_per_bfd_storage.
9339         (symbol_set_names): Update.
9340
9341 2019-01-10  Tom Tromey  <tom@tromey.com>
9342
9343         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9344         init_psymbol_list.
9345         * psymtab.c (init_psymbol_list): Do nothing if already called.
9346         * psympriv.h (init_psymbol_list): Add comment.
9347         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9348         init_psymbol_list.
9349         * dbxread.c (dbx_symfile_read): Unconditionally call
9350         init_psymbol_list.
9351
9352 2019-01-10  Tom Tromey  <tom@tromey.com>
9353
9354         * xcoffread.c (scan_xcoff_symtab): Update.
9355         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9356         "where".
9357         * mdebugread.c (parse_partial_symbols)
9358         (handle_psymbol_enumerators): Update.
9359         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9360         * dbxread.c (read_dbx_symtab): Update.
9361         * psympriv.h (psymbol_placement): New enum.
9362         (add_psymbol_to_list): Update.
9363
9364 2019-01-10  Tom Tromey  <tom@tromey.com>
9365
9366         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9367         static_psymbols parameters.
9368         (scan_xcoff_symtab): Update.
9369         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9370         static_psymbols parameters.
9371         * psympriv.h (start_psymtab_common): Update.
9372         * mdebugread.c (parse_partial_symbols): Update.
9373         * dwarf2read.c (create_partial_symtab): Update.
9374         * dbxread.c (read_dbx_symtab): Update.
9375         (start_psymtab): Remove global_psymbols and static_psymbols
9376         parameters.
9377
9378 2019-01-10  Tom Tromey  <tom@tromey.com>
9379
9380         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9381         * psymtab.c (allocate_psymtab): Add comment.
9382         * psympriv.h (allocate_psymtab): Add comment.
9383         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9384         initializations.
9385         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9386
9387 2019-01-10  Tom Tromey  <tom@tromey.com>
9388
9389         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9390         Don't declare.
9391         * mipsread.c: Include mdebugread.h.
9392         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9393         Declare.
9394         * elfread.c: Include mdebugread.h.
9395
9396 2019-01-09  Tom Tromey  <tom@tromey.com>
9397
9398         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9399         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9400         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9401         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9402         (psym_lookup_symbol, psym_find_last_source_symtab)
9403         (psym_forget_cached_source_info, psym_print_stats)
9404         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9405         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9406         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9407         (psym_find_compunit_symtab_by_address)
9408         (maintenance_print_psymbols, maintenance_info_psymtabs)
9409         (maintenance_check_psymtabs): Use ranged for.
9410         * psymtab.h (class objfile_psymtabs): New.
9411         (require_partial_symbols): Return objfile_psymtabs.
9412         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9413
9414 2019-01-09  Tom Tromey  <tom@tromey.com>
9415
9416         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9417         (find_pc_mapped_section, list_overlays_command)
9418         (map_overlay_command, unmap_overlay_command)
9419         (simple_overlay_update): Use all_objfiles.
9420         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9421         * printcmd.c (info_symbol_command): Use all_objfiles.
9422         * objfiles.h (ALL_OBJSECTIONS): Remove.
9423         * maint.c (maintenance_translate_address): Use all_objfiles.
9424         * gcore.c (gcore_create_callback): Use all_objfiles.
9425         (objfile_find_memory_regions): Likewise.
9426
9427 2019-01-09  Tom Tromey  <tom@tromey.com>
9428
9429         * symtab.c (find_line_symtab, info_sources_command)
9430         (make_source_files_completion_list): Use objfile_compunits.
9431         * source.c (select_source_symtab): Use objfile_compunits.
9432         * objfiles.h (struct objfile): Update comment.
9433         (ALL_OBJFILES): Remove.
9434         (ALL_FILETABS): Remove.
9435         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9436         objfile_compunits.
9437
9438 2019-01-09  Tom Tromey  <tom@tromey.com>
9439
9440         * symmisc.c (print_objfile_statistics, dump_objfile)
9441         (maintenance_print_symbols): Use compunit_filetabs.
9442         * source.c (forget_cached_source_info_for_objfile): Use
9443         compunit_filetabs.
9444         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9445         (ALL_FILETABS): Use compunit_filetabs.
9446         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9447         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9448
9449 2019-01-09  Tom Tromey  <tom@tromey.com>
9450
9451         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9452         (compunit_filetabs): New.
9453         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9454         compunit_filetabs.
9455         (info_sources_command, make_source_files_completion_list): Remove
9456         declaration.
9457         * symmisc.c (print_objfile_statistics, dump_objfile)
9458         (maintenance_print_symbols): Remove declaration.
9459         (maintenance_info_symtabs): Use compunit_filetabs.
9460         (maintenance_info_line_tables): Likewise.
9461         * source.c (select_source_symtab): Change local variable name.
9462         (forget_cached_source_info_for_objfile): Remove declaration.
9463         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9464         * objfiles.c (objfile_relocate1): Remove declaration.
9465         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9466         declaration.
9467         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9468         * coffread.c (coff_symtab_read): Remove declaration.
9469         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9470         compunit_filetabs.
9471
9472 2019-01-09  Tom Tromey  <tom@tromey.com>
9473
9474         * symtab.c (lookup_objfile_from_block)
9475         (find_pc_sect_compunit_symtab, search_symbols)
9476         (default_collect_symbol_completion_matches_break_on): Use
9477         objfile_compunits.
9478         * objfiles.h (ALL_COMPUNITS): Remove.
9479         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9480         * cp-support.c (add_symbol_overload_list_qualified): Use
9481         objfile_compunits.
9482         * ada-lang.c (ada_collect_symbol_completion_matches)
9483         (ada_add_global_exceptions): Use objfile_compunits.
9484
9485 2019-01-09  Tom Tromey  <tom@tromey.com>
9486
9487         * source.c (select_source_symtab)
9488         (forget_cached_source_info_for_objfile): Remove declaration.
9489         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9490         declaration.
9491         * maint.c (count_symtabs_and_blocks): Remove declaration.
9492         * cp-support.c (add_symbol_overload_list_qualified): Remove
9493         declaration.
9494         * coffread.c (coff_symtab_read): Remove declaration.
9495         * symtab.c (lookup_symbol_in_objfile_symtabs)
9496         (basic_lookup_transparent_type_1): Use objfile_compunits.
9497         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9498         (info_sources_command, search_symbols)
9499         (default_collect_symbol_completion_matches_break_on)
9500         (make_source_files_completion_list): Remove declaration.
9501         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9502         (ada_collect_symbol_completion_matches)
9503         (ada_add_global_exceptions): Remove declaration.
9504         * linespec.c (iterate_over_all_matching_symtabs): Use
9505         objfile_compunits.
9506         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9507         (class objfile_compunits): New.
9508         (ALL_COMPUNITS): Use objfile_compunits.
9509         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9510         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9511         objfile_compunits.
9512         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9513
9514 2019-01-09  Tom Tromey  <tom@tromey.com>
9515
9516         * symtab.c (search_symbols)
9517         (default_collect_symbol_completion_matches_break_on): Use
9518         objfile_msymbols.
9519         * ada-lang.c (ada_lookup_simple_minsym)
9520         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9521         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9522         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9523         objfile_msymbols.
9524         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9525         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9526         * objc-lang.c (find_methods): Use objfile_msymbols.
9527         (info_selectors_command, info_classes_command): Likewise.
9528         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9529         * objfiles.h (class objfile_msymbols): New.
9530         (ALL_OBJFILE_MSYMBOLS): Remove.
9531         (ALL_MSYMBOLS): Remove.
9532
9533 2019-01-09  Tom Tromey  <tom@tromey.com>
9534
9535         * common/next-iterator.h (next_adapter): Add Iterator template
9536         parameter.
9537         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9538         (class all_objfiles_safe): New.
9539         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9540         * objfiles.c (put_objfile_before): Update comment.
9541         (add_separate_debug_objfile): Likewise.
9542         (free_all_objfiles): Use all_objfiles_safe.
9543         (objfile_purge_solibs): Likewise.
9544
9545 2019-01-09  Tom Tromey  <tom@tromey.com>
9546
9547         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9548         (expand_symtab_containing_pc, lookup_static_symbol)
9549         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9550         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9551         all_objfiles.
9552         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9553         * breakpoint.c (create_overlay_event_breakpoint)
9554         (create_longjmp_master_breakpoint)
9555         (create_std_terminate_master_breakpoint)
9556         (create_exception_master_breakpoint): Use all_objfiles.
9557         * linux-thread-db.c (try_thread_db_load_from_pdir)
9558         (has_libpthread): Use all_objfiles.
9559         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9560         * linespec.c (iterate_over_all_matching_symtabs)
9561         (search_minsyms_for_name): Use all_objfiles.
9562         * maint.c (maintenance_info_sections): Use all_objfiles.
9563         * main.c (captured_main_1): Use all_objfiles.
9564         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9565         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9566         * guile/scm-pretty-print.c
9567         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9568         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9569         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9570         (maintenance_print_msymbols): Use all_objfiles.
9571         * source.c (select_source_symtab): Use all_objfiles.
9572         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9573         * symfile.c (remove_symbol_file_command)
9574         (expand_symtabs_matching, map_symbol_filenames): Use
9575         all_objfiles.
9576         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9577         all_objfiles.
9578         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9579         * objc-lang.c (find_methods): Use all_objfiles.
9580         * objfiles.c (have_partial_symbols, have_full_symbols)
9581         (have_minimal_symbols, qsort_cmp)
9582         (default_iterate_over_objfiles_in_search_order): Use
9583         all_objfiles.
9584         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9585         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9586         (maintenance_check_psymtabs): Use all_objfiles.
9587         (ALL_PSYMTABS): Remove.
9588         * compile/compile-object-run.c (do_module_cleanup): Use
9589         all_objfiles.
9590         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9591         * cp-support.c (add_symbol_overload_list_qualified): Use
9592         all_objfiles.
9593         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9594         Use all_objfiles.
9595         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9596         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9597         all_objfiles.
9598         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9599         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9600         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9601         Uses all_objfiles.
9602         * solib.c (solib_read_symbols): Use all_objfiles
9603
9604 2019-01-09  Tom Tromey  <tom@tromey.com>
9605
9606         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9607         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9608         all_objfiles.
9609         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9610         * symmisc.c (print_symbol_bcache_statistics)
9611         (print_objfile_statistics, maintenance_print_objfiles)
9612         (maintenance_info_symtabs, maintenance_check_symtabs)
9613         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9614         all_objfiles.
9615         * source.c (forget_cached_source_info): Use all_objfiles.
9616         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9617         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9618         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9619         * objfiles.c (update_section_map): Use all_objfiles.
9620         (shared_objfile_contains_address_p): Likewise.
9621         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9622         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9623
9624 2019-01-09  Tom Tromey  <tom@tromey.com>
9625
9626         * common/next-iterator.h: New file.
9627         * objfiles.h (class all_objfiles): New.
9628         (struct objfile_iterator): New.
9629
9630 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9631
9632         * NEWS: Move the description of the changed "frame", "select-frame",
9633          and "info frame" commands to the Changed commands section.
9634
9635 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9636
9637         * gdbtypes.c (check_stub_method_group): Remove handling of old
9638         mangling schemes.
9639         * linespec.c (find_methods): Likewise.
9640         * stabsread.c (read_member_functions): Likewise.
9641         * valops.c (search_struct_method): Likewise.
9642         (value_struct_elt_for_reference): Likewise.
9643         * NEWS: Mention this change.
9644
9645 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9646
9647         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9648         print_source_lines.
9649         * source.c (print_source_lines_base): Update line number check.
9650         (print_source_lines): New function.
9651         (source_lines_range::source_lines_range): New function.
9652         * source.h (class source_lines_range): New class.
9653         (print_source_lines): New declaration.
9654
9655 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9656
9657         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9658
9659 2019-01-08  Tom Tromey  <tom@tromey.com>
9660             Simon Marchi  <simon.marchi@ericsson.com>
9661
9662         PR gdb/24060
9663         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9664         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9665         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9666         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9667         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9668         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9669
9670 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9671
9672         * source.c (select_source_symtab): Move header comment to
9673         declaration in source.h.
9674         (forget_cached_source_info_for_objfile): Likewise.
9675         (forget_cached_source_info): Likewise.
9676         (identify_source_line): Likewise.
9677         * source.h (identify_source_line): Move declaration from symtab.h
9678         and add comment from source.c
9679         (print_source_lines): Likewise.
9680         (forget_cached_source_info_for_objfile): Likewise.
9681         (forget_cached_source_info): Likewise.
9682         (select_source_symtab): Likewise.
9683         (enum print_source_lines_flag): Move definition from symtab.h.
9684         * symtab.h (identify_source_line): Move declaration to source.h.
9685         (print_source_lines): Likewise.
9686         (forget_cached_source_info_for_objfile): Likewise.
9687         (forget_cached_source_info): Likewise.
9688         (select_source_symtab): Likewise.
9689         (enum print_source_lines_flag): Move definition to source.h.
9690         * tui/tui-hooks.c: Add 'source.h' include.
9691
9692 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9693
9694         * source.c (print_source_lines_base): Handle requests to print
9695         reverse line number sequences, and guard against empty lines
9696         string.
9697
9698 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9699
9700         * source.c (print_source_lines_base): Fix skip of '\r' if next
9701         character is '\n'.
9702
9703 2019-01-06  Tom Tromey  <tom@tromey.com>
9704
9705         * c-exp.y (struct c_parse_state) <macro_original_text,
9706         expansion_obstack>: New member.
9707         (macro_original_text, expansion_obstack): Remove globals.
9708         (scan_macro_expansion, scanning_macro_expansion)
9709         (finished_macro_expansion): Update.
9710         (scan_macro_cleanup): Remove.
9711         (yylex, c_parse): Update.
9712
9713 2019-01-06  Tom Tromey  <tom@tromey.com>
9714
9715         * c-exp.y (struct c_parse_state) <strings>: New member.
9716         (operator_stoken): Update.
9717
9718 2019-01-06  Tom Tromey  <tom@tromey.com>
9719
9720         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9721         (union type_stack_elt) <typelist_val>: Now a pointer to
9722         std::vector.
9723         (type_stack_cleanup): Don't declare.
9724         (push_typelist): Update.
9725         * parse.c (pop_typelist): Return a std::vector.
9726         (push_typelist): Take a std::vector.
9727         (follow_types): Update.  Do not free args.
9728         (type_stack_cleanup): Remove.
9729         * c-exp.y (struct c_parse_state): New.
9730         (cpstate): New global.
9731         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9732         (nonempty_typelist): Update.
9733         (func_mod): Create a new vector.
9734         (c_parse): Create a c_parse_state.
9735         (check_parameter_typelist): Do not delete params.
9736         (function_method): Update.  Do not delete type_list.
9737
9738 2019-01-06  Tom Tromey  <tom@tromey.com>
9739
9740         PR gdb/28155:
9741         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9742         check_typedef.
9743         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9744         (print_return_value): Likewise.
9745
9746 2019-01-05  Tom Tromey  <tom@tromey.com>
9747
9748         * contrib/cleanup_check.py: Remove.
9749         * contrib/gcc-with-excheck: Remove.
9750         * contrib/exsummary.py: Remove.
9751         * contrib/excheck.py: Remove.
9752
9753 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9754
9755         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9756         NULL. Initialize tpprev to NULL instead of assigning it
9757         to NULL on the next statement.
9758         * windows-nat.c (windows_delete_thread): Remove check for
9759         main_thread_id before printing thread exit notifications.
9760         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9761         Remove thread ID check against main_thread_id.
9762         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9763         windows_delete_thread.
9764         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9765
9766 2019-01-04  Tom Tromey  <tom@tromey.com>
9767
9768         * compile/compile.c (_initialize_compile): Use upper case for
9769         metasyntactic variables.
9770         * symmisc.c (_initialize_symmisc): Use upper case for
9771         metasyntactic variables.
9772         * psymtab.c (_initialize_psymtab): Use upper case for
9773         metasyntactic variables.
9774         * demangle.c (demangle_command): Use upper case for metasyntactic
9775         variables.
9776         (_initialize_demangler): Likewise.
9777         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9778         variables.
9779
9780 2019-01-03  Tom Tromey  <tom@tromey.com>
9781
9782         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9783
9784 2019-01-03  Tom Tromey  <tom@tromey.com>
9785
9786         * python/py-symtab.c (salpy_str): Update.
9787         (struct salpy_sal_object) <symtab>: Now a PyObject.
9788         (salpy_dealloc): Update.
9789         (del_objfile_sal): Use gdbpy_ref.
9790
9791 2019-01-03  Tom Tromey  <tom@tromey.com>
9792
9793         * python/py-type.c (convert_field): Use new_reference.  Return
9794         gdbpy_ref.
9795         (make_fielditem): Return gdbpy_ref.
9796         (typy_fields): Update.
9797         (typy_getitem): Update.
9798         (field_name): Return gdbpy_ref.  Use new_reference.
9799         (typy_iterator_iternext): Update.
9800
9801 2019-01-03  Tom Tromey  <tom@tromey.com>
9802
9803         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9804
9805 2019-01-03  Tom Tromey  <tom@tromey.com>
9806
9807         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9808         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9809         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9810         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9811         (pspy_set_type_printers): Likewise.
9812         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9813         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9814         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9815         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9816         (objfpy_set_type_printers): Likewise.
9817
9818 2019-01-03  Tom Tromey  <tom@tromey.com>
9819
9820         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9821         (gdbpy_print_stack): Use gdbpy_err_fetch.
9822         * python/python-internal.h (class gdbpy_err_fetch): New class.
9823         (class gdbpy_enter) <m_error_type, m_error_value,
9824         m_error_traceback>: Remove.
9825         <m_error>: New member.
9826         (gdbpy_exception_to_string): Don't declare.
9827         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9828         * python/py-value.c (convert_value_from_python): Use
9829         gdbpy_err_fetch.
9830         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9831         gdbpy_exception_to_string.
9832         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9833         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9834         gdbpy_err_fetch.
9835
9836 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9837
9838         * linux-nat.c (delete_lwp_cleanup): Delete.
9839         (struct lwp_deleter): New struct.
9840         (lwp_info_up): New typedef.
9841         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9842         lwp_info_up.
9843
9844 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9845
9846         * linux-fork.c (class scoped_switch_fork_info): New class.
9847         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9848
9849 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9850
9851         * valops.c (find_overload_match): Remove use of null_cleanup, and
9852         calls to do_cleanups.
9853
9854 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9855
9856         * compile/compile-cplus-types.c
9857         (compile_cplus_instance::decl_name): Handle changes to
9858         cp_func_name.
9859         * cp-support.c (cp_func_name): Update header comment, update
9860         return type.
9861         * cp-support.h (cp_func_name): Update return type in declaration.
9862         * valops.c (find_overload_match): Move temp_func local to top
9863         level of function and change its type.  Use temp_func to hold and
9864         delete temporary string obtained from cp_func_name.
9865
9866 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9867
9868         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9869         gdb::char_vector, remove cleanup, and update uses of `msg`.
9870
9871 2019-01-03  Jim Wilson  <jimw@sifive.com>
9872
9873         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9874
9875 2019-01-02  Tom Tromey  <tom@tromey.com>
9876
9877         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9878         (tdesc_parse_xml): Remove cleanups.
9879         * target-descriptions.h (make_cleanup_free_target_description):
9880         Don't declare.
9881         (target_desc_deleter): New struct.
9882         (target_desc_up): New typedef.
9883         * target-descriptions.c (target_desc_deleter::operator()): Rename
9884         from free_target_description.
9885         (make_cleanup_free_target_description): Remove.
9886
9887 2019-01-02  Tom Tromey  <tom@tromey.com>
9888
9889         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9890         constructor, destructor.
9891         (linespec_parser): Remove typedef.
9892         (~linespec_parser): Rename from linespec_parser_delete.
9893         (linespec_lex_to_end, linespec_complete_label)
9894         (linespec_complete): Update.
9895         (decode_line_full): Remove cleanups.
9896         (decode_line_1): Update.
9897
9898 2019-01-02  Tom Tromey  <tom@tromey.com>
9899
9900         * python/python-internal.h (inferior_to_inferior_object): Change
9901         return type.
9902         * python/py-exitedevent.c (create_exited_event_object): Update.
9903         * python/py-inferior.c (inferior_to_inferior_object): Return
9904         gdbpy_ref.
9905         (python_new_inferior, python_inferior_deleted)
9906         (thread_to_thread_object, delete_thread_object)
9907         (build_inferior_list, gdbpy_selected_inferior): Update.
9908         * python/py-infthread.c (create_thread_object): Update.  Also fail
9909         if inferior_to_inferior_object fails.
9910
9911 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9912
9913         * inferior.h (class inferior) <displaced_step_state>: New field.
9914         * infrun.h (struct displaced_step_state): Move here from
9915         infrun.c.  Initialize fields, add constructor.
9916         <inf>: Remove field.
9917         <reset>: New method.
9918         * infrun.c (struct displaced_step_inferior_state): Move to
9919         infrun.h.
9920         (displaced_step_inferior_states): Remove.
9921         (get_displaced_stepping_state): Adust.
9922         (displaced_step_in_progress_any_inferior): Adjust.
9923         (displaced_step_in_progress_thread): Adjust.
9924         (displaced_step_in_progress): Adjust.
9925         (add_displaced_stepping_state): Remove.
9926         (get_displaced_step_closure_by_addr): Adjust.
9927         (remove_displaced_stepping_state): Remove.
9928         (infrun_inferior_exit): Call displaced_step_state.reset.
9929         (use_displaced_stepping): Don't check for NULL.
9930         (displaced_step_prepare_throw): Call
9931         get_displaced_stepping_state.
9932         (displaced_step_fixup): Don't check for NULL.
9933         (prepare_for_detach): Don't check for NULL.
9934
9935 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9936
9937         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9938          in case of call that did not complete.
9939
9940 2019-01-02  Andrey Utkin  <autkin@undo.io>
9941
9942         * symfile.c (find_separate_debug_file): Fix search of debug files for
9943         remote debuggee.
9944
9945 2019-01-02  Tom Tromey  <tom@tromey.com>
9946
9947         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9948         indentation.
9949         * python/py-frame.c (frapy_older): Remove cast.
9950         (frapy_newer): Likewise.
9951         * python/py-breakpoint.c (local_setattro): Remove cast.
9952         * python/py-arch.c (archpy_name): Remove local variable.
9953         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9954
9955 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9956
9957         * unittests/basic_string_view/element_access/char/empty.cc:
9958         Fix year range in copyright header.
9959
9960 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9961
9962         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9963         Delete.
9964         <operator==>: Update with for removed field.
9965         <hash>: Likewise.
9966         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9967         <isa_features>: ...this.
9968         <abi_features>: New field.
9969         (riscv_isa_flen): Update comment.
9970         (riscv_abi_xlen): New declaration.
9971         (riscv_abi_flen): New declaration.
9972         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9973         isa_features.
9974         (riscv_abi_xlen): New function.
9975         (riscv_isa_flen): Update to get answer from isa_features.
9976         (riscv_abi_flen): New function.
9977         (riscv_has_fp_abi): Update to get answer from abi_features.
9978         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9979         xlen and flen.
9980         (riscv_call_info) <xlen, flen>: Update comment.
9981         (riscv_call_arg_struct): Remove invalid assertions
9982         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9983         is removed.
9984         (riscv_gdbarch_init): Gather isa features and abi features
9985         separately, ensure both match on the gdbarch when reusing an old
9986         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9987         a target with 64-bit float hardware.
9988
9989 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9990
9991         * source.c (search_command_helper): Stop reverse search
9992         when line 1 has been searched.
9993
9994 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9995
9996         * record-full.c (record_full_base_target::close): Rewrite
9997         record_full_core_buf_list free logic.
9998
9999 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10000
10001         * break-catch-syscall.c (print_one_catch_syscall): xfree
10002         the last text.
10003
10004 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10005
10006         * top.c (print_gdb_version): Update Copyright year in version
10007         message.
10008
10009 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10010
10011         Update copyright year range in all GDB files.
10012
10013 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10014
10015         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10016
10017 For older changes see ChangeLog-2018.
10018 \f
10019 Local Variables:
10020 mode: change-log
10021 left-margin: 8
10022 fill-column: 74
10023 version-control: never
10024 coding: utf-8
10025 End:
10026