gdb/riscv: Don't use default bfd to define required features
[external/binutils.git] / gdb / ChangeLog
1 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2
3         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4         required features based on default bfd type when no specific bfd
5         is present.
6
7 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8
9         * NEWS: Mention that GDB printf and eval commands can now print
10         C-style and Ada-style convenience var strings without
11         calling the inferior.
12         * printcmd.c (printf_c_string): Locally print GDB internal var
13         instead of transiting via the inferior.
14         (printf_wide_c_string): Likewise.
15
16 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
17
18         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
19
20 2019-07-04  Tom Tromey  <tom@tromey.com>
21
22         PR tui/24724:
23         * tui/tui-winsource.c (tui_clear_source_content): Update.
24         (tui_source_window_base::set_is_exec_point_at): Fix comment.
25         (tui_update_breakpoint_info): Update.
26         (tui_set_exec_info_content): Update.
27         * tui/tui-source.c (tui_set_source_content_nil): Update.
28         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
29         has_break.
30         * tui/tui-data.h (enum tui_bp_flag): New.
31         (tui_bp_flags): New enum flags type.
32         (struct tui_source_element) <break_mode>: Change type.  Rename
33         from has_break.
34         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
35         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
36         constants.
37         * tui/tui-winsource.h: Fix comment.
38
39 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
40
41         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
42         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
43         (store_fpregs_to_thread)
44         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
45         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
46         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
47         (IWMMXT_REGS_SIZE): Add define.
48         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
49         (fetch_vfp_regs, store_vfp_regs)
50         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
51         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
52
53 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
54
55         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
56         defines.
57         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
58         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
59         (ARM_INT_REGISTER_SIZE): ...to this.
60         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
61         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
62         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
63         (arm_linux_collect_gregset, supply_nwfpe_register)
64         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
65         defines.
66         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
67         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
68         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
69         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
70         (arm_return_in_memory, arm_store_return_value)
71         (arm_get_longjmp_target, arm_register_g_packet_guesses)
72         (arm_record_ld_st_multiple): Likewise.
73         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
74         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
75
76 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
77
78         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
79         AARCH64_DISPLACED_MODIFIED_INSNS.
80         * aarch64-tdep.c (struct aarch64_displaced_step_data)
81         (aarch64_displaced_step_copy_insn): Likewise.
82         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
83         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
84         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
85         ARM_DISPLACED_MODIFIED_INSNS.
86         * arm-tdep.c (arm_gdbarch_init): Likewise.
87         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
88         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
89         (struct arm_displaced_step_closure): Use
90         ARM_DISPLACED_MODIFIED_INSNS.
91
92 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
93
94         * features/Makefile: Remove unused xml files.
95         * features/aarch64.xml: Remove.
96         * features/i386/amd64-avx-avx512-linux.xml: Remove.
97         * features/i386/amd64-avx-avx512.xml: Remove.
98         * features/i386/amd64-avx-linux.xml: Remove.
99         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
100         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
101         * features/i386/amd64-avx-mpx-linux.xml: Remove.
102         * features/i386/amd64-avx-mpx.xml: Remove.
103         * features/i386/amd64-avx.xml: Remove.
104         * features/i386/amd64-linux.xml: Remove.
105         * features/i386/amd64-mpx-linux.xml: Remove.
106         * features/i386/amd64-mpx.xml: Remove.
107         * features/i386/amd64.xml: Remove.
108         * features/i386/i386-avx-avx512-linux.xml: Remove.
109         * features/i386/i386-avx-avx512.xml: Remove.
110         * features/i386/i386-avx-linux.xml: Remove.
111         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
112         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
113         * features/i386/i386-avx-mpx-linux.xml: Remove.
114         * features/i386/i386-avx-mpx.xml: Remove.
115         * features/i386/i386-avx.xml: Remove.
116         * features/i386/i386-linux.xml: Remove.
117         * features/i386/i386-mmx-linux.xml: Remove.
118         * features/i386/i386-mmx.xml: Remove.
119         * features/i386/i386-mpx-linux.xml: Remove.
120         * features/i386/i386-mpx.xml: Remove.
121         * features/i386/i386.xml: Remove.
122         * features/i386/x32-avx-avx512-linux.xml: Remove.
123         * features/i386/x32-avx-linux.xml: Remove.
124         * features/i386/x32-linux.xml: Remove.
125
126 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
127
128         * regformats/aarch64.dat: Remove.
129         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
130         * regformats/i386/amd64-avx-linux.dat: Remove.
131         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
132         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
133         * regformats/i386/amd64-linux.dat: Remove.
134         * regformats/i386/amd64-mpx-linux.dat: Remove.
135         * regformats/i386/amd64.dat: Remove.
136         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
137         * regformats/i386/i386-avx-linux.dat: Remove.
138         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
139         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
140         * regformats/i386/i386-linux.dat: Remove.
141         * regformats/i386/i386-mmx-linux.dat: Remove.
142         * regformats/i386/i386-mpx-linux.dat: Remove.
143         * regformats/i386/i386.dat: Remove.
144         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
145         * regformats/i386/x32-avx-linux.dat: Remove.
146         * regformats/i386/x32-linux.dat: Remove.
147
148 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
149
150         * aarch64-tdep.c: Remove xml self tests.
151         * amd64-linux-tdep.c: Likewise.
152         * amd64-tdep.c: Likewise.
153         * i386-linux-tdep.c: Likewise.
154         * i386-tdep.c: Likewise.
155
156 2019-07-03  Pedro Alves  <palves@redhat.com>
157
158         PR cli/24732
159         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
160         (pipe_cmd_option_defs): New.
161         (make_pipe_cmd_options_def_group): New.
162         (pipe_command): Use gdb::option::process_options.
163         (pipe_command_completer): New function.
164         (_initialize_cli_cmds): Install completer for "pipe" command.
165
166 2019-07-03  Pedro Alves  <palves@redhat.com>
167
168         * cli/cli-option.c (union option_value) <string>: New field.
169         (struct option_def_and_value): Add ctor, move ctor, dtor and
170         use DISABLE_COPY_AND_ASSIGN.
171         (option_def_and_value::clear_value): New.
172         (parse_option, save_option_value_in_ctx, get_val_type_str)
173         (add_setshow_cmds_for_options): Handle var_string.
174         * cli-option.h (union option_def::var_address) <string>: New
175         field.
176         (struct string_option_def): New.
177         * maint-test-options.c (struct test_options_opts): Add default
178         ctor and use DISABLE_COPY_AND_ASSIGN.
179         <string_opt>: New field.
180         (test_options_opts::~test_options_opts): New.
181         (test_options_opts::dump): Also dump "-string".
182         (test_options_option_defs): Install "string.
183
184 2019-07-03  Pedro Alves  <palves@redhat.com>
185
186         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
187         option_value with a null enumeration.
188         (complete_options): Save the option values in the context.
189         (save_option_value_in_ctx): New, factored out from ...
190         (process_options): ... here.
191         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
192         of the function.
193         * maint-test-options.c (test_options_opts::dump): New, factored
194         out from ...
195         (maintenance_test_options_command_mode): ... here.
196         (maintenance_test_options_command_completion_result): Delete.
197         (maintenance_test_options_command_completion_text): Update
198         comment.
199         (maintenance_show_test_options_completion_result): Change
200         prototype.  Just print
201         maintenance_test_options_command_completion_text.
202         (save_completion_result): New.
203         (maintenance_test_options_completer_mode): Pass options context to
204         complete_options, and then save a dump.
205         (_initialize_maint_test_options): Use add_cmd to install "maint
206         show test-options-completion-result".
207
208 2019-07-03  Pedro Alves  <palves@redhat.com>
209
210         * NEWS (New commands): Mention "with" and "maint with".
211         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
212         (with_command, with_command_completer): New.
213         (pipe_command): Adjust to new repeat_previous
214         interface.
215         (_initialize_cli_cmds): Install the "with" command and its "w"
216         alias.
217         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
218         declarations.
219         * cli/cli-setshow.c (parse_cli_var_uinteger)
220         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
221         argument strings for all var_types.
222         (get_setshow_command_value_string): New, factored out from ...
223         (do_show_command): ... this.
224         * cli/cli-setshow.h: Include <string>.
225         (get_setshow_command_value_string): Declare.
226         * command.h (repeat_previous): Now returns const char *.  Adjust
227         comment.
228         * maint.c: Include "cli/cli-cmds.h".
229         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
230         (_initialize_maint_cmds): Register the "maintenance with" command.
231         * top.c (repeat_previous): Move bits from pipe_command here:
232         Return the saved command line, if any; error out if there's no
233         command to relaunch.
234
235 2019-07-03  Pedro Alves  <palves@redhat.com>
236
237         * NEWS (New commands): Mention "maint set/show test-settings"
238         instead of "maint test-settings".
239         * maint-test-settings.c (maintenance_test_settings_list): Delete.
240         (maintenance_test_settings_set_list): Rename to ...
241         (maintenance_set_test_settings_list): ... this.
242         (maintenance_test_settings_show_list): Rename to  ...
243         (maintenance_show_test_settings_list): ... this.
244         (maintenance_test_settings_cmd): Delete.
245         (maintenance_test_settings_set_cmd): ...
246         (maintenance_set_test_settings_cmd): ... this.
247         (maintenance_test_settings_show_cmd): ...
248         (maintenance_show_test_settings_cmd): ... this.
249         (maintenance_test_settings_show_value_cmd):
250         (maintenance_show_test_settings_value_cmd): ... this.
251         (_initialize_maint_test_settings): No longer install the "maint
252         test-settings" prefix command.  Rename "maint test-settings set"
253         to "maint set test-settings", and "maint test-settings show" to
254         "maint show test-settings".  Adjust all subcommands.
255
256 2019-07-03  Pedro Alves  <palves@redhat.com>
257
258         * maint-test-settings.c: Fix file's intro comment.  Replace all
259         references to "test-options" with references to "test-settings",
260         in comments.
261
262 2019-07-03  Pedro Alves  <palves@redhat.com>
263
264         * maint-test-settings.c (maintenance_test_settings_xxx)
265         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
266         New.
267         (maintenance_test_settings_enums): Use them.
268         (maintenance_test_settings_enum): Default to
269         maintenance_test_settings_xxx.
270         (_initialize_maint_test_settings): Initialize
271         MAINTENANCE_TEST_SETTINGS_FILENAME.
272
273 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
274
275         * breakpoint.h (remove_breakpoints_inf): Change return type to
276         void, move function documentation here.
277         * breakpoint.c (remove_breakpoints_inf): Change return type to
278         void, move function documentation to header.
279
280 2019-07-02  Pedro Alves  <palves@redhat.com>
281
282         * NEWS (Completion improvements): Mention "info threads".
283         * thread.c (struct info_threads_opts, info_threads_option_defs)
284         (make_info_threads_options_def_group): New.
285         (info_threads_command): Use gdb::option::process_options.
286         (info_threads_command_completer): New.
287         (_initialize_thread): Use gdb::option::build_help to build the
288         help text for "info threads".
289
290 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
291
292         * defs.h (generic_load): Move from here...
293         * symfile.h (generic_load): ... to here.  Rename name parameter
294         to args.
295         * symfile.c (generic_load): Add comment.
296
297 2019-07-01  Tom Tromey  <tromey@adacore.com>
298
299         * dwarf2read.c
300         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
301         declaration of without_params.  Fix formatting.
302
303 2019-07-01  Tom Tromey  <tromey@adacore.com>
304
305         * ada-exp.y (find_primitive_type): Update.
306         * ada-lang.h (ada_lookup_symbol): Update.
307         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
308         parameter.
309         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
310
311 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
312
313         PR breakpoints/24541
314         * gdbarch.c: Regenerate.
315         * gdbarch.h: Regenerate.
316         * gdbarch.sh: Add 'stap_adjust_register'.
317         * i386-tdep.c: Include '<unordered_set>'.
318         (i386_stap_adjust_register): New function.
319         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
320         * stap-probe.c (stap_parse_register_operand): Call
321         'gdbarch_stap_adjust_register'.
322
323 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
324
325         PR python/24742
326         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
327         * python/python.c (do_start_initialization): Use 'xmalloc'
328         instead of 'PyMem_Malloc'.
329
330 2019-06-28  Tom Tromey  <tromey@adacore.com>
331
332         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
333         for Ada.
334
335 2019-06-27  Tom Tromey  <tromey@adacore.com>
336
337         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
338         objfile_key.
339         (arm_find_mapping_symbol, arm_record_special_symbol)
340         (_initialize_arm_tdep): Update.
341         (arm_objfile_data_free): Remove.
342
343 2019-06-27  Tom Tromey  <tromey@adacore.com>
344
345         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
346         to cp_print_static_field.
347
348 2019-06-26  Tom Tromey  <tromey@adacore.com>
349
350         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
351         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
352         declare.
353
354 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
355
356         * features/aarch64-core.c (create_feature_aarch64_core):
357         Regenerate.
358         * features/aarch64-core.xml: Add cpsr flags.
359
360 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
361
362         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
363         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
364
365 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
366
367         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
368         field.
369         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
370         use.
371         (arm_record_special_symbol): Don't insert new symbol in sorted
372         position, push it at the end.
373
374 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
375
376         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
377         (arm_mapping_symbol_s): Remove.
378         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
379         (arm_mapping_symbol_vec): New typedef.
380         (struct arm_per_objfile): Add constructor.
381         <section_maps>: Change type to
382         std::unique_ptr<arm_mapping_symbol_vec[]>.
383         (arm_compare_mapping_symbols): Remove.
384         (arm_find_mapping_symbol): Adjust to section_maps type change.
385         (arm_objfile_data_free): Call delete on arm_per_objfile.
386         (arm_record_special_symbol): Adjust to section_maps type change.
387         Allocate arm_per_objfile with new.
388
389 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
390
391         * cli/cli-cmds.c (alias_command): Compare the alias prefix
392         with the command prefix.
393
394 2019-06-25  Tom Tromey  <tom@tromey.com>
395
396         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
397         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
398
399 2019-06-25  Tom Tromey  <tom@tromey.com>
400
401         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
402         type.
403         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
404         protected.
405
406 2019-06-25  Tom Tromey  <tom@tromey.com>
407
408         * tui/tui-winsource.c
409         (tui_source_window_base::set_is_exec_point_at): Add check against
410         LOA_ADDRESS.
411
412 2019-06-25  Tom Tromey  <tom@tromey.com>
413
414         * tui/tui-source.c (tui_set_source_content): Don't check before
415         xfree.
416         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
417
418 2019-06-25  Tom Tromey  <tom@tromey.com>
419
420         * tui/tui-winsource.h (tui_update_source_window_as_is)
421         (tui_alloc_source_buffer, tui_line_is_displayed)
422         (tui_addr_is_displayed): Change type of win_info.
423         * tui/tui-winsource.c (tui_update_source_window_as_is)
424         (tui_clear_source_content, tui_show_source_line)
425         (tui_show_source_content, tui_source_window_base::refill)
426         (tui_source_window_base::set_is_exec_point_at)
427         (tui_source_window_base::set_is_exec_point_at)
428         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
429         (tui_alloc_source_buffer, tui_line_is_displayed)
430         (tui_addr_is_displayed): Change type of win_info.  Update.
431         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
432         (tui_source_window_base::do_make_visible_with_new_height):
433         Update.
434         * tui/tui-source.c (tui_set_source_content)
435         (tui_set_source_content_nil)
436         (tui_source_window::do_scroll_vertical): Update.
437         * tui/tui-layout.c (show_layout): Update.
438         * tui/tui-disasm.c (tui_set_disassem_content)
439         (tui_disasm_window::do_scroll_vertical): Update.
440         * tui/tui-data.h (tui_win_content): Remove.
441         (struct tui_gen_win_info) <content, content_size>: Remove.
442         (struct tui_source_element): Add initializers and destructor.
443         (union tui_which_element, struct tui_win_element): Remove.
444         (struct tui_source_window_base) <content>: New field.
445         (struct tui_data_window): Remove destructor.
446         (tui_alloc_content, tui_free_win_content)
447         (tui_free_all_source_wins_content): Don't declare.
448         * tui/tui-data.c (tui_initialize_static_data): Update.
449         (init_content_element, tui_alloc_content): Remove.
450         (~tui_gen_win_info): Update.
451         (~tui_data_window, tui_free_all_source_wins_content)
452         (tui_free_win_content, free_content, free_content_elements):
453         Remove.
454
455 2019-06-25  Tom Tromey  <tom@tromey.com>
456
457         * tui/tui-winsource.h (tui_clear_source_content)
458         (tui_erase_source_content, tui_show_source_content): Change type
459         of win_info.
460         * tui/tui-winsource.c (tui_clear_source_content)
461         (tui_erase_source_content, tui_show_source_content): Change type
462         of win_info.
463         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
464         * tui/tui-source.h (tui_set_source_content_nil): Change type of
465         win_info.
466         * tui/tui-source.c (tui_set_source_content_nil): Change type of
467         win_info.
468         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
469
470 2019-06-25  Tom Tromey  <tom@tromey.com>
471
472         * tui/tui-winsource.c (tui_clear_source_content)
473         (tui_source_window_base::set_is_exec_point_at): Update.
474         * tui/tui-source.c (tui_set_source_content_nil): Update.
475         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
476         a bool.
477         * tui/tui-data.c (init_content_element): Update.
478
479 2019-06-25  Tom Tromey  <tom@tromey.com>
480
481         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
482         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
483         * tui/tui-layout.c (init_and_make_win): Update.
484         * tui/tui.h (enum tui_win_type): Update.
485         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
486         tui_win_is_auxillary.
487         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
488         tui_win_is_auxillary.
489
490 2019-06-25  Tom Tromey  <tom@tromey.com>
491
492         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
493         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
494         (tui_delete_data_content_windows, tui_display_all_data)
495         (tui_data_window::do_scroll_vertical, tui_display_data_from):
496         Update.
497         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
498         * tui/tui-regs.c (tui_last_regs_line_no)
499         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
500         (tui_show_registers): Update.
501         (tui_show_register_group): Return void.  Update.
502         (tui_display_registers_from, tui_display_reg_element_at_line)
503         (tui_display_registers_from_line, tui_check_register_values):
504         Update.
505         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
506         member.
507         (struct tui_data_window) <regs_content>: Now a std::vector.
508         <regs_content_count>: Remove.
509         (tui_add_content_elements, tui_free_data_content): Don't declare.
510         * tui/tui-data.c (tui_data_window::clear_detail): Update.
511         (init_content_element): Remove DATA_WIN case.  Add assert.
512         (tui_add_content_elements): Remove.
513         (tui_data_window): Update.
514         (tui_free_data_content): Remove.
515         (free_content_elements): Remove DATA_WIN case.
516
517 2019-06-25  Tom Tromey  <tom@tromey.com>
518
519         * tui/tui-data.c (tui_data_item_window): Update.
520         * tui/tui-windata.h (tui_check_data_values): Don't declare.
521         * tui/tui-windata.c (tui_display_all_data)
522         (tui_display_data_from_line): Update.
523         (tui_check_data_values): Remove.
524         * tui/tui-regs.c (tui_show_register_group)
525         (tui_display_reg_element_at_line): Update.
526         * tui/tui-hooks.c (tui_register_changed)
527         (tui_refresh_frame_and_register_information): Call
528         tui_check_register_values.
529         * tui/tui-data.h (struct tui_data_window) <data_content,
530         data_content_count, data_type>: Remove.
531         (enum tui_data_type): Remove.
532
533         * tui/tui-data.c (tui_data_window::clear_detail)
534         (~tui_data_window): Update.
535
536 2019-06-25  Tom Tromey  <tom@tromey.com>
537
538         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
539         declare.
540         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
541         Rename from tui_first_data_item_displayed.  Update.
542         (tui_data_window::refresh_all)
543         (tui_data_window::do_scroll_vertical): Update.
544         * tui/tui-data.h (struct tui_data_window)
545         <first_data_item_displayed>: Declare new method.
546
547 2019-06-25  Tom Tromey  <tom@tromey.com>
548
549         * tui/tui-data.h (tui_init_generic_part): Don't declare.
550         * tui/tui-data.c (tui_init_generic_part): Remove, moving
551         contents...
552         (tui_initialize_static_data): ...here.
553
554 2019-06-25  Tom Tromey  <tom@tromey.com>
555
556         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
557         (tui_display_registers_from, tui_check_register_values): Update.
558         (tui_display_register): Remove win_info parameter; update.
559         (tui_get_register): Change type of parameters.
560         * tui/tui-data.h (struct tui_data_element): Remove.
561         (union tui_which_element) <data>: Remove.
562         <data_window>: Change type.
563         (struct tui_data_item_window): New.
564         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
565         case.  Add assert.
566         (~tui_data_item_window): New destructor.
567         (free_content_elements): Remove DATA_ITEM_WIN case.
568
569 2019-06-25  Tom Tromey  <tom@tromey.com>
570
571         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
572         Remove.
573
574 2019-06-25  Tom Tromey  <tom@tromey.com>
575
576         * tui/tui-data.h (struct tui_command_element): Remove.
577         (union tui_which_element) <command>: Remove.
578         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
579         assert.
580         (free_content_elements): Remove CMD_WIN case.
581
582 2019-06-25  Tom Tromey  <tom@tromey.com>
583
584         * tui/tui-layout.c (tui_set_layout): Update.
585         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
586         * tui/tui-data.c (layout_def): Update.
587
588 2019-06-25  Tom Tromey  <tom@tromey.com>
589
590         * tui/tui-wingeneral.c (tui_refresh_all): Update.
591         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
592         (tui_source_window_base::set_new_height): Update.
593         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
594         Update.
595         (tui_set_locator_fullname, tui_set_locator_info)
596         (tui_show_frame_info): Update.
597         * tui/tui-source.c (tui_set_source_content)
598         (tui_source_is_displayed): Update.
599         * tui/tui-layout.c (show_source_disasm_command, show_data)
600         (show_source_or_disasm_and_command): Update.
601         * tui/tui-disasm.c (tui_set_disassem_content)
602         (tui_get_begin_asm_address): Update.
603         * tui/tui-data.h (struct tui_locator_element): Remove.
604         (union tui_which_element) <locator>: Remove.
605         (struct tui_locator_window): New.
606         (tui_locator_win_info_ptr): Change return type.
607         * tui/tui-data.c (_locator): Change type.
608         (tui_locator_win_info_ptr): Change return type.
609         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
610         (tui_alloc_content): Add assert.
611
612 2019-06-25  Tom Tromey  <tom@tromey.com>
613
614         * tui/tui-winsource.c
615         (tui_exec_info_window::maybe_allocate_content): New method.
616         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
617         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
618         (make_source_or_disasm_window): Add cast.
619         * tui/tui-data.h (union tui_which_element) <simple_string>:
620         Remove.
621         (struct tui_source_info): New.
622         (struct tui_source_window_base) <execution_info>: Change type.
623         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
624         case, and add assert.
625         (tui_alloc_content): Add assert.
626
627 2019-06-25  Tom Tromey  <tom@tromey.com>
628
629         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
630         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
631         * tui/tui-data.c (tui_alloc_win_info): Remove.
632
633 2019-06-25  Tom Tromey  <tom@tromey.com>
634
635         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
636         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
637         can_highlight.
638
639 2019-06-25  Tom Tromey  <tom@tromey.com>
640
641         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
642         make_visible_with_new_height method.
643         (tui_win_info::make_visible_with_new_height): New method.
644         (tui_source_window_base::do_make_visible_with_new_height)
645         (tui_data_window::do_make_visible_with_new_height)
646         (tui_cmd_window::do_make_visible_with_new_height): New methods.
647         (make_visible_with_new_height): Remove.
648         (tui_resize_all, tui_adjust_win_heights): Use
649         make_visible_with_new_height method.
650         * tui/tui-data.h (struct tui_win_info)
651         <do_make_visible_with_new_height, make_visible_with_new_height>:
652         New methods.
653         (struct tui_source_window_base, struct tui_data_window)
654         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
655         methods.
656
657 2019-06-25  Tom Tromey  <tom@tromey.com>
658
659         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
660         method.
661         (update_tab_width): Call update_tab_width method.
662         * tui/tui-data.h (struct tui_win_info)
663         (struct tui_source_window_base) <update_tab_width>: New methods.
664
665 2019-06-25  Tom Tromey  <tom@tromey.com>
666
667         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
668         parameter.
669         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
670         parameter.
671         (tui_gen_win_info::make_visible): Update.
672         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
673         parameter.
674         * tui/tui-data.h (enum tui_box): New enum.
675         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
676
677 2019-06-25  Tom Tromey  <tom@tromey.com>
678
679         * tui/tui-layout.c (make_source_or_disasm_window): Always use
680         init_and_make_win for EXEC_INFO_WIN.
681         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
682         longer inline.
683         (struct tui_win_info) <~tui_win_info>: Inline.
684         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
685         Don't declare.
686         * tui/tui-data.c (source_win, disasm_win): Remove globals.
687         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
688         Remove.
689         (tui_initialize_static_data): Update.
690         (~tui_gen_win_info): Handle more cleanup here.
691         (~tui_source_window_base): Delete "execution_info".
692         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
693
694 2019-06-25  Tom Tromey  <tom@tromey.com>
695
696         * tui/tui-layout.c (make_command_window): Don't set
697         can_highlight.
698         (show_source_disasm_command): Call the reset method.
699         (show_data): Don't set can_highlight.  Call the reset method.
700         (tui_gen_win_info::reset): Rename from init_gen_win_info
701         (init_and_make_win): Simplify.  Return tui_gen_win_info.
702         (show_source_or_disasm_and_command): Call the reset method.
703         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
704         (struct tui_cmd_window): Set can_highlight.
705
706 2019-06-25  Tom Tromey  <tom@tromey.com>
707
708         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
709         from make_visible.
710         (tui_make_visible, tui_make_invisible): Rewrite.
711         (tui_win_info::make_visible): Remove.
712         (tui_source_window_base::make_visible): Update.
713         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
714         method.  Moved from...
715         (struct tui_win_info) <make_visible>: ...here.
716
717 2019-06-25  Tom Tromey  <tom@tromey.com>
718
719         * tui/tui-winsource.c
720         (tui_source_window_base::do_scroll_horizontal): Remove direction
721         parameter.
722         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
723         direction parameter.
724         * tui/tui-win.c (tui_win_info::forward_scroll)
725         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
726         (tui_win_info::right_scroll): Update.
727         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
728         direction parameter.
729         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
730         direction parameter.
731         * tui/tui-data.h (enum tui_scroll_direction): Remove.
732         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
733         Remove direction parameter.
734         (struct tui_source_window_base, struct tui_source_window)
735         (struct tui_disasm_window, struct tui_data_window)
736         (struct tui_cmd_window): Update.
737
738 2019-06-25  Tom Tromey  <tom@tromey.com>
739
740         * tui/tui-winsource.h (tui_set_exec_info_content)
741         (tui_show_exec_info_content, tui_erase_exec_info_content)
742         (tui_clear_exec_info_content, tui_update_exec_info): Change
743         argument to tui_source_window_base.
744         * tui/tui-winsource.c (tui_set_exec_info_content)
745         (tui_show_exec_info_content, tui_erase_exec_info_content)
746         (tui_clear_exec_info_content, tui_update_exec_info): Change
747         argument to tui_source_window_base.
748
749 2019-06-25  Tom Tromey  <tom@tromey.com>
750
751         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
752         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
753
754 2019-06-25  Tom Tromey  <tom@tromey.com>
755
756         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
757         check.
758
759 2019-06-25  Tom Tromey  <tom@tromey.com>
760
761         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
762         type to void.
763         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
764         type to void.
765         * tui/tui-source.c (tui_set_source_content): Update.
766         * tui/tui-disasm.c (tui_set_disassem_content): Update.
767
768 2019-06-25  Tom Tromey  <tom@tromey.com>
769
770         * tui/tui-win.c (window_name_completer, tui_set_focus)
771         (tui_all_windows_info): Use name method.
772         * tui/tui-data.h (struct tui_gen_win_info)
773         (struct tui_source_window, struct tui_disasm_window)
774         (struct tui_data_window, struct tui_cmd_window) <name>: New
775         method.
776         (tui_win_name): Don't declare.
777         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
778         (tui_win_name): Remove.
779
780 2019-06-25  Tom Tromey  <tom@tromey.com>
781
782         * tui/tui-winsource.h (tui_update_source_window)
783         (tui_update_source_window_as_is): Change parameter type.
784         * tui/tui-winsource.c (tui_update_source_window): Change win_info
785         to be a tui_source_window_base.
786         (tui_update_source_window_as_is): Likewise.
787         * tui/tui-win.c (make_visible_with_new_height): Update.
788
789 2019-06-25  Tom Tromey  <tom@tromey.com>
790
791         * tui/tui-winsource.c (tui_erase_source_content)
792         (tui_show_source_content, tui_show_exec_info_content)
793         (tui_erase_exec_info_content): Use refresh_window method.
794         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
795         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
796         from tui_refresh_win.
797         (tui_data_window::refresh_window): New method.
798         (tui_win_info::refresh, tui_source_window_base::refresh)
799         (tui_refresh_all): Use refresh_window method.
800         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
801         method.
802         * tui/tui-regs.c (tui_display_register): Call refresh_window
803         method.
804         * tui/tui-layout.c (show_source_disasm_command)
805         (show_source_or_disasm_and_command): Call refresh_window method.
806         * tui/tui-data.h (struct tui_gen_win_info)
807         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
808         New method.
809
810 2019-06-25  Tom Tromey  <tom@tromey.com>
811
812         * tui/tui.c (tui_rl_other_window, tui_enable)
813         (tui_is_window_visible, tui_get_command_dimension): Update.
814         * tui/tui-winsource.c (tui_update_source_window_as_is)
815         (tui_clear_source_content, tui_erase_source_content)
816         (tui_show_source_line, tui_source_window_base::refill)
817         (tui_source_window_base::do_scroll_horizontal)
818         (tui_source_window_base::set_is_exec_point_at)
819         (tui_update_breakpoint_info, tui_set_exec_info_content)
820         (tui_alloc_source_buffer, tui_line_is_displayed)
821         (tui_addr_is_displayed): Update.
822         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
823         (tui_check_and_display_highlight_if_needed)
824         (tui_win_info::make_visible, tui_win_info::refresh)
825         (tui_refresh_all): Update.
826         * tui/tui-windata.c (tui_first_data_item_displayed)
827         (tui_delete_data_content_windows, tui_erase_data_content)
828         (tui_display_all_data, tui_data_window::refresh_all)
829         (tui_check_data_values): Update.
830         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
831         (tui_set_win_focus_to, tui_win_info::forward_scroll)
832         (tui_win_info::backward_scroll, tui_refresh_all_win)
833         (tui_resize_all, tui_set_focus, tui_all_windows_info)
834         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
835         (tui_source_window_base::set_new_height)
836         (tui_data_window::set_new_height)
837         (make_invisible_and_set_new_height)
838         (make_visible_with_new_height, new_height_ok)
839         (parse_scrolling_args): Update.
840         * tui/tui-stack.c (tui_show_frame_info): Update.
841         * tui/tui-source.c (tui_set_source_content)
842         (tui_set_source_content_nil, tui_source_is_displayed)
843         (tui_source_window::do_scroll_vertical): Update.
844         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
845         (tui_display_registers_from, tui_display_reg_element_at_line)
846         (tui_check_register_values, tui_reg_command): Update.
847         * tui/tui-layout.c (tui_default_win_height)
848         (show_source_disasm_command, show_data, init_and_make_win)
849         (show_source_or_disasm_and_command): Update.
850         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
851         (tui_redisplay_readline, tui_mld_flush)
852         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
853         (tui_getc): Update.
854         * tui/tui-disasm.c (tui_set_disassem_content)
855         (tui_disasm_window::do_scroll_vertical): Update.
856         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
857         Now virtual.
858         (struct tui_win_info): Derive from tui_gen_win_info.
859         <~tui_win_info>: Mark as override.
860         <generic>: Remove member.
861         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
862         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
863         (~tui_data_window, ~tui_win_info)
864         (tui_free_all_source_wins_content): Update.
865         * tui/tui-command.c (tui_refresh_cmd_win): Update.
866
867 2019-06-25  Tom Tromey  <tom@tromey.com>
868
869         * tui/tui-layout.c (init_and_make_win): Use new.
870         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
871         destructor, initializers.
872         (tui_alloc_generic_win_info): Don't declare.
873         * tui/tui-data.c (_locator): Add argument to constructor.
874         (source_win, disasm_win): New globals.
875         (exec_info): Remove.
876         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
877         Update.
878         (tui_alloc_generic_win_info): Remove.
879         (init_content_element): Use new.
880         (tui_win_info::tui_win_info): Update.
881         (free_content_elements) <case DATA_WIN>: Use delete.
882
883 2019-06-25  Tom Tromey  <tom@tromey.com>
884
885         * tui/tui-wingeneral.c (tui_refresh_win): Update.
886         * tui/tui-windata.c (tui_first_data_item_displayed)
887         (tui_delete_data_content_windows): Update.
888         * tui/tui-win.c (tui_data_window::set_new_height): Update.
889         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
890         (tui_display_registers_from, tui_check_register_values): Update.
891         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
892         pointer.
893         * tui/tui-data.c (init_content_element): Update.  Allocate the new
894         window.
895         (tui_free_data_content): Update.
896         (free_content_elements) <case DATA_WIN>: Free the window.
897
898 2019-06-25  Tom Tromey  <tom@tromey.com>
899
900         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
901         Update.
902         * tui/tui-layout.c (make_command_window)
903         (show_source_disasm_command, show_data, init_and_make_win)
904         (show_source_or_disasm_and_command): Update.
905         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
906         method.
907         <can_highight, is_highlighted>: Now bool.
908         (tui_set_win_highlight): Don't declare.
909         * tui/tui-data.c (tui_set_win_highlight): Remove.
910
911 2019-06-25  Tom Tromey  <tom@tromey.com>
912
913         * tui/tui-wingeneral.c (make_visible): Remove check of window
914         type.
915
916 2019-06-25  Tom Tromey  <tom@tromey.com>
917
918         * tui/tui-win.c (tui_win_info::max_height)
919         (tui_cmd_window::max_height): New methods.
920         (new_height_ok): Call max_height.
921         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
922         <max_height>: New method.
923
924 2019-06-25  Tom Tromey  <tom@tromey.com>
925
926         * tui/tui-win.c (tui_source_window_base::set_new_height)
927         (tui_data_window::set_new_height): New methods.
928         (make_invisible_and_set_new_height): Call set_new_height method.
929         * tui/tui-data.h (struct tui_win_info)
930         (struct tui_source_window_base, struct tui_data_window)
931         <set_new_height>: New method.
932
933 2019-06-25  Tom Tromey  <tom@tromey.com>
934
935         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
936         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
937         tui_refresh_data_win.
938         * tui/tui-win.c (tui_source_window_base::refresh_all): New
939         method.
940         (tui_refresh_all_win): Call the refresh_all method.
941         (tui_set_focus): Likewise.
942         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
943         (struct tui_source_window_base, struct tui_data_window) <refresh>:
944         Likewise.
945
946 2019-06-25  Tom Tromey  <tom@tromey.com>
947
948         * tui/tui-winsource.h (tui_refill_source_window)
949         (tui_set_is_exec_point_at): Don't declare.
950         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
951         (tui_source_window_base::refill): Rename from
952         tui_refill_source_window.
953         (tui_source_window_base::do_scroll_horizontal): Update.
954         (tui_source_window_base::set_is_exec_point_at): Rename from
955         tui_set_is_exec_point_at.
956         (tui_update_all_breakpoint_info): Update.
957         * tui/tui-stack.c (tui_show_frame_info): Update.
958         * tui/tui-layout.c (show_data): Add cast.
959         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
960         * tui/tui-data.h (struct tui_source_window_base) <refill,
961         set_is_exec_point_at>: New methods.
962         (tui_source_windows, tui_add_to_source_windows): Update types.
963         (tui_add_to_source_windows): Remove redundant declaration.
964         * tui/tui-data.c (source_windows): Store tui_source_window_base.
965         (tui_source_windows): Change return type.
966         (tui_clear_source_windows_detail): Update.
967         (tui_add_to_source_windows): Change type of parameter.
968         (tui_free_all_source_wins_content): Update.
969
970 2019-06-25  Tom Tromey  <tom@tromey.com>
971
972         * tui/tui-wingeneral.c (tui_win_info::refresh)
973         (tui_source_window_base::refresh): New methods.
974         (tui_refresh_all): Call the refresh method.
975         * tui/tui-data.h (struct tui_win_info)
976         (struct tui_source_window_base) <refresh>: New method.
977
978 2019-06-25  Tom Tromey  <tom@tromey.com>
979
980         * tui/tui.h (tui_is_window_visible): Return bool.
981         * tui/tui.c (tui_is_window_visible): Return bool.
982         * tui/tui-wingeneral.c (tui_make_window, make_visible)
983         (tui_make_visible, tui_make_invisible)
984         (tui_win_info::make_visible)
985         (tui_source_window_base::make_visible, make_all_visible)
986         (tui_make_all_visible, tui_make_all_invisible): Update.
987         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
988         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
989         bool.
990         (struct tui_win_info, struct tui_source_window_base)
991         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
992         * tui/tui-data.c (tui_init_generic_part): Update.
993
994 2019-06-25  Tom Tromey  <tom@tromey.com>
995
996         * tui/tui-wingeneral.c (tui_win_info::make_visible)
997         (tui_source_window_base::make_visible): New methods.
998         (make_all_visible): Make method call.
999         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1000         (struct tui_source_window_base, struct tui_cmd_window): Override
1001         make_visible.
1002         (tui_win_is_source_type): Don't declare.
1003         * tui/tui-data.c (tui_win_is_source_type): Remove.
1004
1005 2019-06-25  Tom Tromey  <tom@tromey.com>
1006
1007         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1008         NULL check.
1009
1010 2019-06-25  Tom Tromey  <tom@tromey.com>
1011
1012         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1013         Inline constructor.  Add initializers for members.
1014         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1015         constructors; now inline in class.
1016
1017 2019-06-25  Tom Tromey  <tom@tromey.com>
1018
1019         * tui/tui-regs.c (tui_show_registers): Update.
1020         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1021         bool.
1022         * tui/tui-data.c (tui_data_window::clear_detail)
1023         (tui_data_window): Update.
1024
1025 2019-06-25  Tom Tromey  <tom@tromey.com>
1026
1027         * tui/tui-windata.c (tui_display_all_data)
1028         (tui_display_data_from_line, tui_display_data_from)
1029         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1030         Update.
1031         * tui/tui-regs.c (tui_last_regs_line_no)
1032         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1033         (tui_show_registers, tui_show_register_group)
1034         (tui_display_registers_from, tui_display_reg_element_at_line)
1035         (tui_display_registers_from_line, tui_check_register_values)
1036         (tui_reg_next, tui_reg_prev): Update.
1037         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1038         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1039         tui_data_window.
1040         (struct tui_win_info) <detail>: Remove.  Add new fields from
1041         tui_data_info.
1042         (TUI_DATA_WIN): Add cast.
1043         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1044         (~tui_data_window): Simplify.
1045
1046 2019-06-25  Tom Tromey  <tom@tromey.com>
1047
1048         * tui/tui-layout.c (show_source_disasm_command)
1049         (show_source_or_disasm_and_command): Update.
1050         * tui/tui-io.c (update_cmdwin_start_line)
1051         (tui_redisplay_readline): Update.
1052         * tui/tui-data.h (struct tui_command_info): Remove.
1053         (struct tui_win_info) <detail>: Remove command_info member.
1054         (struct tui_data_window) <start_line>: New member, from
1055         tui_command_info.
1056         (TUI_CMD_WIN): Add casts.
1057
1058 2019-06-25  Tom Tromey  <tom@tromey.com>
1059
1060         * tui/tui-winsource.c (tui_update_source_window)
1061         (tui_refill_source_window)
1062         (tui_source_window_base::do_scroll_horizontal)
1063         (tui_update_breakpoint_info, tui_set_exec_info_content)
1064         (tui_show_exec_info_content, tui_erase_exec_info_content)
1065         (tui_clear_exec_info_content): Update.
1066         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1067         Update.
1068         * tui/tui-win.c (make_invisible_and_set_new_height)
1069         (make_visible_with_new_height): Update.
1070         * tui/tui-source.c (tui_set_source_content)
1071         (tui_show_symtab_source): Update.
1072         * tui/tui-layout.c (extract_display_start_addr)
1073         (show_source_disasm_command, show_data)
1074         (make_source_or_disasm_window)
1075         (show_source_or_disasm_and_command): Update.
1076         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1077         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1078         "gdbarch".
1079         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1080         to tui_source_window_base.
1081         (struct tui_win_info) <detail>: Remove source_info member.
1082         (struct tui_source_window_base) <has_locator>: Inline.
1083         Move contents from tui_source_info; rename has_locator member to
1084         m_has_locator.
1085         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1086         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1087         header file.
1088         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1089         Simplify.
1090         (tui_free_all_source_wins_content): Cast to
1091         tui_source_window_base.
1092
1093 2019-06-25  Tom Tromey  <tom@tromey.com>
1094
1095         * tui/tui-win.c (make_invisible_and_set_new_height)
1096         (make_visible_with_new_height): Call has_locator method.
1097         * tui/tui-layout.c (show_source_disasm_command, show_data)
1098         (show_source_or_disasm_and_command): Update for bool change.
1099         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1100         (tui_win_info) <has_locator>: New method.
1101         (struct tui_source_window_base) <has_locator>: New method.
1102         (tui_win_has_locator): Don't declare.
1103         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1104         from tui_win_has_locator.
1105         (tui_source_window_base): Use false, not FALSE.
1106
1107 2019-06-25  Tom Tromey  <tom@tromey.com>
1108
1109         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1110         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1111         clear_detail method directly.
1112         (tui_clear_win_detail): Remove.
1113
1114 2019-06-25  Tom Tromey  <tom@tromey.com>
1115
1116         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1117         "this", not TUI_DISASM_WIN.
1118
1119 2019-06-25  Tom Tromey  <tom@tromey.com>
1120
1121         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1122         declare.
1123         * tui/tui-winsource.c
1124         (tui_source_window_base::do_scroll_horizontal): Rename from
1125         tui_horizontal_source_scroll.
1126         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1127         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1128         from tui_vertical_data_scroll.
1129         * tui/tui-win.h (tui_scroll): Don't declare.
1130         * tui/tui-win.c (tui_win_info::forward_scroll)
1131         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1132         (tui_win_info::right_scroll): Rename and update.
1133         (tui_scroll_forward_command, tui_scroll_backward_command)
1134         (tui_scroll_left_command, tui_scroll_right_command): Update.
1135         (tui_scroll): Remove.
1136         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1137         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1138         from tui_vertical_source_scroll.
1139         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1140         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1141         from tui_vertical_disassem_scroll.
1142         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1143         do_scroll_horizontal>: New methods.
1144         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1145         Likewise.
1146         (struct tui_source_window_base): Add do_scroll_horizontal.
1147         (struct tui_source_window, struct tui_disasm_window): Add
1148         do_scroll_vertical.
1149         (struct tui_data_window, struct tui_cmd_window): Add
1150         do_scroll_horizontal and do_scroll_vertical.
1151         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1152
1153 2019-06-25  Tom Tromey  <tom@tromey.com>
1154
1155         * tui/tui-data.h (struct tui_source_window_base): New struct.
1156         (struct tui_source_window): Derive from tui_source_window_base.
1157         (struct tui_disasm_window): New struct.
1158         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1159         from tui_source_window::clear_detail.
1160         (tui_source_window_base): Rename from tui_source_window.
1161         (~tui_source_window_base): Rename from ~tui_source_window.
1162         (tui_alloc_win_info): Create a tui_disasm_window.
1163
1164 2019-06-25  Tom Tromey  <tom@tromey.com>
1165
1166         * tui/tui-data.h (struct tui_source_window)
1167         (struct tui_data_window): Declare destructors.
1168         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1169         destructors.
1170         (tui_win_info): Simplify.
1171
1172 2019-06-25  Tom Tromey  <tom@tromey.com>
1173
1174         * tui/tui-winsource.c (tui_display_main)
1175         (tui_update_source_windows_with_addr)
1176         (tui_update_all_breakpoint_info): Update.
1177         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1178         (new_height_ok, parse_scrolling_args): Update.
1179         * tui/tui-stack.c (tui_show_frame_info): Update.
1180         * tui/tui-data.h (struct tui_list): Remove.
1181         (tui_source_windows): Return a reference to a std::vector.
1182         * tui/tui-data.c (source_windows): Now a std::vector.
1183         (tui_source_windows): Change return type.
1184         (tui_clear_source_windows): Rewrite.
1185         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1186         (tui_free_all_source_wins_content): Rewrite.
1187
1188 2019-06-25  Tom Tromey  <tom@tromey.com>
1189
1190         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1191         (struct tui_data_window, struct tui_cmd_window): Declare
1192         clear_detail method.
1193         * tui/tui-data.c (tui_source_window::clear_detail)
1194         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1195         methods.
1196         (tui_clear_win_detail): Simplify.
1197
1198 2019-06-25  Tom Tromey  <tom@tromey.com>
1199
1200         * tui/tui-layout.c (make_source_window, make_disasm_window)
1201         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1202         Return the new window.
1203         (show_source_disasm_command, show_data)
1204         (show_source_or_disasm_and_command): Update.
1205
1206 2019-06-25  Tom Tromey  <tom@tromey.com>
1207
1208         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1209         parameter.  Return the new window.
1210         (show_source_disasm_command): Update and remove NULL check.
1211         (show_source_or_disasm_and_command): Update.
1212
1213 2019-06-25  Tom Tromey  <tom@tromey.com>
1214
1215         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1216
1217 2019-06-25  Tom Tromey  <tom@tromey.com>
1218
1219         * tui/tui-data.h (struct tui_win_info): Make constructor
1220         protected.  Make destructor virtual.  Add initializers.
1221         (tui_source_window, tui_data_window, tui_cmd_window): New
1222         classes.
1223         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1224         constructor.  Add "type" parameter.
1225         (tui_source_window, tui_data_window, tui_cmd_window): New
1226         constructors.
1227         (tui_alloc_win_info): Instantiate the appropriate subclass.
1228
1229 2019-06-25  Tom Tromey  <tom@tromey.com>
1230
1231         * tui/tui-win.c (tui_resize_all): Use delete.
1232         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1233         destructor.
1234         (tui_free_window): Don't declare.
1235         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1236         Update.
1237
1238 2019-06-25  Tom Tromey  <tom@tromey.com>
1239
1240         * tui/tui-data.h (struct tui_win_info): Add constructor.
1241         * tui/tui-data.c (tui_alloc_win_info): Use new.
1242         (tui_free_window): Use delete.
1243
1244 2019-06-22  Tom Tromey  <tom@tromey.com>
1245
1246         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1247         declare.
1248         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1249
1250 2019-06-22  Tom Tromey  <tom@tromey.com>
1251
1252         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1253         declare.
1254         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1255
1256 2019-06-22  Tom de Vries  <tdevries@suse.de>
1257
1258         * dwarf2read.c (create_addrmap_from_aranges)
1259         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1260         instead of '%zu'.
1261
1262 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1263
1264         * dwarf2read.h (dwarf2_section_info_def): Remove.
1265         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1266         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1267         std::vector<dwarf2_section_info>.
1268         (struct dwo_file) <~dwo_file>: Remove.
1269         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1270         types field.
1271         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1272         (dwarf2_read_debug_names): Likewise.
1273         (create_debug_types_hash_table): Change parameter type to
1274         array_view, adjust code accordingly.
1275         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1276         (partial_die_info::fixup): Likewise.
1277         (determine_prefix): Likewise.
1278         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1279
1280 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1281
1282         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1283         gdb_bfd_ref_ptr.
1284         <~dwo_file>: Remove call to gdb_bfd_unref.
1285         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1286         gdb_bfd_ref_ptr::get.
1287
1288 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1289
1290         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1291         type to htab_up.
1292         * dwarf2read.c (struct dwo_file): Initialize fields.
1293         <~dwo_file>: New.
1294         (free_dwo_file): Remove, move content to ~dwo_file.
1295         (struct dwo_file_deleter): Remove.
1296         (dwo_file_up>: Remove custom deleter.
1297         (free_dwo_files): Remove.
1298         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1299         dwo_files.
1300         (process_skeletonless_type_units): Call unique_ptr::get.
1301         (allocate_dwo_file_hash_table): Add deleter to created hash
1302         table.  Change return type to htab_up.
1303         (lookup_dwo_file_slot): Don't memset dwo_file, call
1304         unique_ptr::get.
1305         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1306         (create_dwo_unit_in_dwp_v2): Likewise.
1307         (open_and_init_dwo_file): Likewise.
1308         (free_dwo_file_from_slot): Remove.
1309
1310 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1311
1312         * dwarf2read.h (struct dwarf2_section_info) <readin,
1313         is_virtual>: Change type to bool.
1314         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1315         true instead of 1.
1316
1317 2019-06-19  Tom Tromey  <tom@tromey.com>
1318
1319         * tui/tui-data.h (tui_init_content_element): Don't declare.
1320
1321 2019-06-19  Tom Tromey  <tom@tromey.com>
1322
1323         * tui/tui-data.h (tui_init_win_info): Don't declare.
1324
1325 2019-06-19  Tom de Vries  <tdevries@suse.de>
1326
1327         * dwarf2read.h (abstract_to_concrete): Change type to
1328         std::unordered_map<sect_offset, std::vector<sect_offset>,
1329         gdb::hash_enum<sect_offset>>.
1330
1331 2019-06-19  Tom Tromey  <tromey@adacore.com>
1332
1333         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1334         EVAL_AVOID_SIDE_EFFECTS specially.
1335
1336 2019-06-19  Tom Tromey  <tromey@adacore.com>
1337
1338         * source-cache.c (highlighter): New global.
1339         (source_cache::get_source_lines): Create a highlighter on demand.
1340
1341 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1342
1343         * defs.h (deprecated_interactive_hook): Delete declaration.
1344         * interps.c (clear_interpreter_hooks): Remove use of
1345         deprecated_interactive_hook.
1346         * top.c (deprecated_interactive_hook): Delete definition.
1347         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1348
1349 2019-06-18  Tom de Vries  <tdevries@suse.de>
1350
1351         PR gdb/24515
1352         * dwarf2read.h (abstract_to_concrete): Change type from
1353         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1354         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1355         * dwarf2read.c (read_variable): Update.
1356         (dwarf2_fetch_die_loc_sect_off): Update.
1357
1358 2019-06-17  Tom de Vries  <tdevries@suse.de>
1359
1360         PR gdb/24617
1361         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1362         accessing parent[parent_len - 1].
1363
1364 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1365
1366         PR gdb/24364
1367         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1368         call dtrace_process_dof with NULL dof.
1369
1370 2019-06-16  Tom de Vries  <tdevries@suse.de>
1371
1372         PR gdb/24445
1373         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1374
1375 2019-06-16  Tom Tromey  <tom@tromey.com>
1376
1377         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1378         (make_all_visible): Use address of member.
1379
1380 2019-06-16  Tom Tromey  <tom@tromey.com>
1381
1382         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1383         (tui_free_window, free_content, free_content_elements): Remove
1384         unnecessary cast.
1385         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1386         cast.
1387         * tui/tui-regs.c (tui_show_register_group)
1388         (tui_display_registers_from, tui_display_reg_element_at_line):
1389         Remove unnecessary cast.
1390
1391 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1392
1393         * linux-nat.c (normal_mask): Delete.
1394         (_initialize_linux_nat): Don't initialise normal_mask.
1395
1396 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1397
1398         PR gdb/24445
1399         * dwarf-index-write.h (write_psymtabs_to_index): Add
1400         dwz_basename parameter.
1401         * dwarf-index-write.c (write_gdbindex): Move file writing to
1402         write_gdbindex_1.  Change return type void.
1403         (assert_file_size): Move up, remove filename parameter.
1404         (write_gdbindex_1): New function.
1405         (write_debug_names): Change return type to void, call
1406         assert_file_size.
1407         (struct index_wip_file): New struct.
1408         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1409         file logic to index_wip_file.  Write index for dwz file if
1410         needed.
1411         (save_gdb_index_command): Pass basename of dwz file, if present.
1412         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1413         build-id of dwz file, if present.
1414         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1415         (dwarf2_get_dwz_file): Likewise.
1416         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1417         (dwarf2_get_dwz_file): Likewise.
1418
1419 2019-06-16  Tom Tromey  <tom@tromey.com>
1420
1421         * coffread.c (process_coff_symbol): Use xstrdup.
1422         * value.c (create_internalvar): Use xstrdup.
1423
1424 2019-06-16  Tom Tromey  <tom@tromey.com>
1425
1426         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1427         * breakpoint.c (stopin_command, stopat_command)
1428         (until_break_command, decode_location_default): Remove unnecessary
1429         cast.
1430         * utils.c (subset_compare): Remove unnecessary cast.
1431         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1432         cast.
1433         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1434         cast.
1435         * infcmd.c (path_command): Remove unnecessary cast.
1436         * coffread.c (decode_type): Remove unnecessary cast.
1437         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1438         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1439         * tui/tui-stack.c (tui_show_locator_content)
1440         (tui_show_frame_info): Remove unnecessary cast.
1441         * tui/tui-win.c (tui_scroll_forward_command)
1442         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1443         (parse_scrolling_args): Remove unnecessary cast.
1444         * tui/tui-data.c (init_win_info, tui_del_window)
1445         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1446         (free_content_elements): Remove unnecessary cast.
1447         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1448         unnecessary cast.
1449         * tui/tui-source.c (tui_set_source_content)
1450         (tui_vertical_source_scroll): Remove unnecessary cast.
1451         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1452         cast.
1453         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1454         * tui/tui-regs.c (tui_display_registers_from)
1455         (tui_display_register): Remove unnecessary cast.
1456         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1457         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1458         (make_visible): Remove unnecessary cast.
1459         * tui/tui-winsource.c (tui_erase_source_content)
1460         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1461         unnecessary cast.
1462         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1463         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1464         * stabsread.c (read_type, read_array_type, read_range_type):
1465         Remove unnecessary cast.
1466         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1467         (parse_symbol, parse_type, upgrade_type, parse_external)
1468         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1469         unnecessary cast.
1470         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1471
1472 2019-06-16  Tom Tromey  <tom@tromey.com>
1473
1474         * tui/tui-data.c (tui_alloc_generic_win_info)
1475         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1476         checks.
1477
1478 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1479             Andrew Burgess  <andrew.burgess@embecosm.com>
1480
1481         * f-typeprint.c (f_print_type): Don't return early for not
1482         associated or not allocated types.
1483         (f_type_print_varspec_suffix): Add print_rank parameter and print
1484         ranks of array types in case they dangling.
1485         (f_type_print_base): Add print_rank parameter.
1486
1487 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1488
1489         * NEWS: Mention new MI commands.
1490         * break-catch-throw.c (enum exception_event_kind): Move to
1491         breakpoint.h.
1492         (print_mention_exception_catchpoint): Output text as a single
1493         message.
1494         (catch_exception_command_1): Rename to...
1495         (catch_exception_event): ...this, make non-static, update header
1496         command, and change some parameter types.
1497         (catch_catch_command): Update for changes to
1498         catch_exception_command_1.
1499         (catch_throw_command): Likewise.
1500         (catch_rethrow_command): Likewise.
1501         * breakpoint.c (enum exception_event_kind): Delete.
1502         * breakpoint.h (enum exception_event_kind): Moved here from
1503         break-catch-throw.c.
1504         (catch_exception_event): Declare.
1505         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1506         (mi_cmd_catch_throw): New function.
1507         (mi_cmd_catch_rethrow): New function.
1508         (mi_cmd_catch_catch): New function.
1509         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1510         'catch-catch' entries.
1511         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1512         (mi_cmd_catch_rethrow): Declare.
1513         (mi_cmd_catch_catch): Declare.
1514
1515 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1516
1517         * annotate.c (annotate_source_line): Change return type to void,
1518         update implementation to match.
1519         * annotate.h (annotate_source_line): Change return type to void,
1520         update header comment.
1521         * stack.c (print_frame_info): Don't change what frame information
1522         is printed based on whether annotations are on or not.
1523
1524 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1525
1526         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1527         (annotate_source): Make static.
1528         (annotate_source_line): Moved from source.c and renamed from
1529         identify_source_line.  Update the return type.
1530         * annotate.h (annotate_source): Delete declaration.
1531         (annotate_source_line): Declaration moved from source.h, and
1532         renamed from identify_source_line.  Return type updated.
1533         * source.c (identify_source_line): Moved to annotate.c and renamed
1534         to annotate_source_line.
1535         (info_line_command): Remove check of annotation_level.
1536         * source.h (identify_source_line): Move declaration to annotate.h
1537         and rename to annotate_source_line.
1538         * stack.c: Add 'annotate.h' include.
1539         (print_frame_info): Remove check of annotation_level before
1540         calling annotate_source_line.
1541
1542 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1543
1544         * source-cache.c (source_cache::get_plain_source_lines): Use
1545         open_source_file_with_line_charpos instead of just
1546         open_source_file, remove call to find_source_lines.
1547         (source_cache::get_source_lines): Likewise.
1548         * source.c (find_source_lines): Make static.
1549         (get_filename_and_charpos): Renamed into...
1550         (open_source_file_with_line_charpos): ..this along with changes to
1551         return a scoped_fd, and some other minor clean ups.
1552         (identify_source_line): Use open_source_file_with_line_charpos.
1553         (search_command_helper): Use open_source_file_with_line_charpos
1554         instead of just open_source_file, remove call to
1555         find_source_lines.
1556         * source.h (open_source_file_with_line_charpos): Declare new
1557         function.
1558         (find_source_lines): Delete declaration.
1559
1560 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1561
1562         * source.c (get_filename_and_charpos): Remove fullname
1563         parameter.
1564         (identify_source_line): Update call to get_filename_and_charpos.
1565
1566 2019-06-14  Tom Tromey  <tromey@adacore.com>
1567
1568         PR gdb/24502:
1569         * ui-style.h (skip_ansi_escape): Update comment.
1570         * ui-file.h (class no_terminal_escape_file): New class.
1571         * ui-file.c (no_terminal_escape_file::write)
1572         (no_terminal_escape_file::puts): New methods.
1573         * cli/cli-logging.c (handle_redirections): Use
1574         no_terminal_escape_file.
1575
1576 2019-06-14  Tom Tromey  <tromey@adacore.com>
1577
1578         * NEWS: Move convenience variable news above Python news.
1579
1580 2019-06-14  Tom Tromey  <tom@tromey.com>
1581
1582         * gnulib: Move directory to top-level.
1583         * configure.ac: Don't configure gnulib.
1584         * configure: Rebuild.
1585         * common/common-defs.h: Use new path to gnulib.
1586         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1587         (GNULIB_H): Remove.
1588         (INCGNU): Look in new gnulib location.
1589         (HFILES_NO_SRCDIR): Remove gnulib files.
1590         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1591         (generated_files): Remove GNULIB_H.
1592         ($(LIBGNU), all-lib): Remove targets.
1593         (distclean): Don't mention GNULIB_BUILDDIR.
1594         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1595
1596 2019-06-14  Tom Tromey  <tromey@adacore.com>
1597
1598         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1599         Warn if symbol file does not provide any symbols.
1600
1601 2019-06-14  Tom Tromey  <tromey@adacore.com>
1602
1603         * source.c (find_and_open_source): Respect basenames_may_differ.
1604
1605 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1606
1607         * annotate.c (annotate_breakpoints_invalid): Make use of
1608         scoped_restore_terminal_state.
1609         (annotate_frames_invalid): Likewise.
1610
1611 2019-06-14  Tom Tromey  <tromey@adacore.com>
1612
1613         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1614         allow assignment to an internalvar.
1615
1616 2019-06-14  Tom Tromey  <tromey@adacore.com>
1617
1618         * ada-lex.l: Allow "_" in attribute names.
1619
1620 2019-06-14  Tom Tromey  <tromey@adacore.com>
1621
1622         PR gdb/24653:
1623         * regcache.c (registers_changed): Don't call alloca.
1624         * top.c (execute_command): Don't call alloca.
1625
1626 2019-06-13  Pedro Alves  <palves@redhat.com>
1627
1628         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1629         'expression'.  When parsing an expression, error out if there's
1630         junk after "unlimited".
1631         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1632         (do_set_command): Adjust calls to is_unlimited_literal.
1633
1634 2019-06-13  Pedro Alves  <palves@redhat.com>
1635
1636         * compile/compile.c (make_compile_options_def_group): Add braces
1637         around array_view initializer.
1638         * thread.c (make_thread_apply_all_options_def_group)
1639         (make_thread_apply_all_options_def_group): Likewise.
1640
1641 2019-06-13  Pedro Alves  <palves@redhat.com>
1642
1643         * NEWS (New commands): Mention "maint test-options
1644         require-delimiter", "maint test-options unknown-is-error", "maint
1645         test-options unknown-is-operand" and "maint show
1646         test-options-completion-result".
1647         (New command options, command completion): New section.
1648         (Completion improvements): New section.
1649         Mention that you can abbreviate "unlimited".
1650
1651 2019-06-13  Pedro Alves  <palves@redhat.com>
1652
1653         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1654         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1655         * unittests/cli-utils-selftests.c (test_parse_flags)
1656         (test_parse_flags_qcs): Delete.
1657         (test_cli_utils): Don't call deleted functions.
1658
1659 2019-06-13  Pedro Alves  <palves@redhat.com>
1660
1661         * thread.c: Include "cli/cli-option.h".
1662         (tp_array_compar_ascending): Global.
1663         (tp_array_compar): Delete function.
1664         (tp_array_compar_ascending, tp_array_compar_descending): New
1665         functions.
1666         (ascending_option_def, qcs_flag_option_def)
1667         (thr_qcs_flags_option_defs)
1668         (make_thread_apply_all_options_def_group)
1669         (make_thread_apply_options_def_group): New.
1670         (thread_apply_all_command): Use gdb::option::process_options.
1671         (thread_apply_command_completer)
1672         (thread_apply_all_command_completer): New.
1673         (thread_apply_command): Use gdb::option::process_options.
1674         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1675         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1676         to generate help text of "thread apply".  Adjust "taas"'s help.
1677         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1678         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1679
1680 2019-06-13  Pedro Alves  <palves@redhat.com>
1681
1682         * thread.c (thread_apply_command): Check for invalid TID with
1683         isdigit instead of !isalpha.
1684
1685 2019-06-13  Pedro Alves  <palves@redhat.com>
1686
1687         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1688         (validate_flags_qcs): New.
1689         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1690         (validate_flags_qcs): Declare.
1691         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1692         (make_frame_apply_options_def_group): New.
1693         (frame_apply_command_count): Process options with
1694         gdb::option::process_options.
1695         (frame_apply_completer): New.
1696         (frame_apply_level_completer, frame_apply_all_completer)
1697         (frame_apply_completer): New.
1698         (_initialize_stack): Update help of "frame apply", "frame apply
1699         level", "frame apply all" and "faas" to mention supported options
1700         and install command completers.
1701         * stack.h (frame_apply_all_completer): Declare.
1702         * thread.c: Include "stack.h".
1703         (tfaas_command): Add "--".
1704         (_initialize_thread): Update help "tfaas" to mention supported
1705         options and install command completer.
1706
1707 2019-06-13  Pedro Alves  <palves@redhat.com>
1708
1709         * completer.c (complete_nested_command_line): New.
1710         (gdb_completion_word_break_characters_throw): Add assertion.
1711         * completer.h (complete_nested_command_line): Declare.
1712
1713 2019-06-13  Pedro Alves  <palves@redhat.com>
1714
1715         * stack.c (parse_backtrace_qualifiers): New.
1716         (backtrace_command): Use it.
1717         (backtrace_command_completer): Complete on qualifiers.
1718
1719 2019-06-13  Pedro Alves  <palves@redhat.com>
1720
1721         * frame.c: Include "cli/cli-option.h.
1722         (user_set_backtrace_options): New.
1723         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1724         Delete.
1725         (get_prev_frame): Adjust.
1726         (boolean_option_def, uinteger_option_def)
1727         (set_backtrace_option_defs): New.
1728         (_initialize_frame): Adjust and use
1729         gdb::option::add_setshow_cmds_for_options to install "set
1730         backtrace past-main" and "set backtrace past-entry".
1731         * frame.h: Include "cli/cli-option.h".
1732         (struct frame_print_options): Forward declare.
1733         (print_frame_arguments_all, print_frame_arguments_scalars)
1734         (print_frame_arguments_none): Declare.
1735         (print_entry_values): Delete declaration.
1736         (struct frame_print_options, user_frame_print_options): New.
1737         (struct set_backtrace_options): New.
1738         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1739         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1740         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1741         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1742         (list_args_or_locals): Add frame_print_options parameter.
1743         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1744         * python/py-framefilter.c (enumerate_args): Pass down
1745         USER_FRAME_PRINT_OPTIONS.
1746         * stack.c: Include "cli/cli-option.h".
1747         (print_frame_arguments_all, print_frame_arguments_scalars)
1748         (print_frame_arguments_none): Declare.
1749         (print_raw_frame_arguments, print_entry_values): Delete.
1750         (user_frame_print_options): New.
1751         (boolean_option_def, enum_option_def, frame_print_option_defs):
1752         New.
1753         (struct backtrace_cmd_options): New.
1754         (bt_flag_option_def): New.
1755         (backtrace_command_option_defs): New.
1756         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1757         (print_frame_arg, read_frame_arg, print_frame_args)
1758         (print_frame_info, print_frame): Add frame_print_options parameter
1759         and use it.
1760         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1761         (backtrace_command_1): Add frame_print_options and
1762         backtrace_cmd_options parameters and use them.
1763         (make_backtrace_options_def_group): New.
1764         (backtrace_command): Process command options with
1765         gdb::option::process_options.
1766         (backtrace_command_completer): New.
1767         (_initialize_stack): Extend "backtrace"'s help to mention
1768         supported options.  Install completer for "backtrace".
1769         Install some settings commands with add_setshow_cmds_for_options.
1770
1771 2019-06-13  Pedro Alves  <palves@redhat.com>
1772
1773         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1774         and that "set/show print raw frame-arguments" are now deprecated.
1775
1776         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1777         command.
1778         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1779         * stack.c (_initialize_stack): Install "set/show print
1780         raw-frame-arguments", and deprecate "set/show print raw
1781         frame-arguments".
1782         * valprint.c (_initialize_valprint): Deprecate "set/show print
1783         raw".
1784
1785 2019-06-13  Pedro Alves  <palves@redhat.com>
1786
1787         * compile/compile.c (struct compile_options): New.
1788         (compile_flag_option_def, compile_command_option_defs)
1789         (make_compile_options_def_group): New.
1790         (compile_file_command): Handle options with
1791         gdb::option::process_options.
1792         (compile_file_command_completer): New function.
1793         (compile_code_command): Handle options with
1794         gdb::option::process_options.
1795         (compile_code_command_completer): New function.
1796         (_initialize_compiler): Install completers for "compile code" and
1797         "compile file".  Mention available options in "compile code" and
1798         "compile code"'s help.
1799         * completer.c (advance_to_completion_word): New, factored out from
1800         ...
1801         (advance_to_expression_complete_word_point): ... this.
1802         (advance_to_filename_complete_word_point): New.
1803         * completer.h (advance_to_filename_complete_word_point): New
1804         declaration.
1805
1806 2019-06-13  Pedro Alves  <palves@redhat.com>
1807
1808         * compile/compile.c: Include "cli/cli-option.h".
1809         (compile_print_value): Scope data pointer is now a
1810         value_print_options pointer; adjust.
1811         (compile_print_command): Process options.  Scope data pointer is
1812         now a value_print_options pointer; adjust.
1813         (_initialize_compile): Update "compile print"'s help to include
1814         supported options.  Install a completer for "compile print".
1815         * cp-valprint.c (show_vtblprint, show_objectprint)
1816         (show_static_field_print): Delete.
1817         (_initialize_cp_valprint): Don't install "set print
1818         static-members", "set print vtbl", "set print object" here.
1819         * printcmd.c: Include "cli/cli-option.h" and
1820         "common/gdb_optional.h".
1821         (print_command_parse_format): Rework to fill in a
1822         value_print_options instead of a format_data.
1823         (print_value): Change parameter type from format_data pointer to
1824         value_print_options reference.  Adjust.
1825         (print_command_1): Process options.  Adjust to pass down a
1826         value_print_options.
1827         (print_command_completer): New.
1828         (_initialize_printcmd): Install print_command_completer as
1829         handle_brkchars completer for the "print" command.  Update
1830         "print"'s help to include supported options.
1831         * valprint.c: Include "cli/cli-option.h".
1832         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1833         here from cp-valprint.c.
1834         (boolean_option_def, uinteger_option_def)
1835         (value_print_option_defs, make_value_print_options_def_group):
1836         New.  Use gdb::option::add_setshow_cmds_for_options to install
1837         "set print elements", "set print null-stop", "set print repeats",
1838         "set print pretty", "set print union", "set print array", "set
1839         print address", "set print symbol", "set print array-indexes".
1840         * valprint.h: Include <string> and "cli/cli-option.h".
1841         (make_value_print_options_def_group): Declare.
1842         (print_value): Change parameter type from format_data pointer to
1843         value_print_options reference.
1844         (print_command_completer): Declare.
1845
1846 2019-06-13  Pedro Alves  <palves@redhat.com>
1847
1848         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1849         (COMMON_SFILES): Add maint-test-settings.c.
1850         * cli/cli-decode.c (boolean_enums): New global, factored out from
1851         ...
1852         (add_setshow_boolean_cmd): ... here.
1853         * cli/cli-decode.h (boolean_enums): Declare.
1854         * cli/cli-option.c: New file.
1855         * cli/cli-option.h: New file.
1856         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1857         factored out from ...
1858         (parse_cli_boolean_value(const char *)): ... this.
1859         (is_unlimited_literal): Change parameter type to pointer to
1860         pointer.  Adjust and advance ARG pointer.
1861         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1862         (parse_cli_var_enum): New, factored out from ...
1863         (do_set_command): ... this.  Adjust.
1864         * cli/cli-setshow.h (parse_cli_boolean_value)
1865         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1866         (parse_cli_var_enum): Declare.
1867         * cli/cli-utils.c: Include "cli/cli-option.h".
1868         (get_ulongest): New.
1869         * cli/cli-utils.h (get_ulongest): Declare.
1870         (check_for_argument): New overloads.
1871         * maint-test-options.c: New file.
1872
1873 2019-06-13  Pedro Alves  <palves@redhat.com>
1874
1875         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1876         parse a range if "-" is at the end of the string.
1877
1878 2019-06-13  Pedro Alves  <palves@redhat.com>
1879
1880         * cli/cli-setshow.c (parse_auto_binary_operation)
1881         (parse_cli_boolean_value): Don't allow "o".
1882
1883 2019-06-13  Pedro Alves  <palves@redhat.com>
1884
1885         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1886         * NEWS: Mention maint test-settings KIND.
1887         * maint-test-settings.c: New file.
1888
1889 2019-06-13  Pedro Alves  <palves@redhat.com>
1890
1891         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1892         completer.
1893         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1894         "set" completers.
1895
1896 2019-06-13  Pedro Alves  <palves@redhat.com>
1897
1898         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1899         after item.
1900
1901 2019-06-13  Pedro Alves  <palves@redhat.com>
1902
1903         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1904
1905 2019-06-13  Pedro Alves <palves@redhat.com>
1906
1907         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1908         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1909         call.
1910         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1911         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1912         calls.
1913         (check_for_argument): Skip spaces after argument.
1914
1915 2019-06-13  Pedro Alves  <palves@redhat.com>
1916
1917         * thread.c (thread_apply_command): Adjust TID parsing.
1918         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1919         detected before end of string.
1920         (tid_is_in_list): Error out if LIST is invalid.
1921
1922 2019-06-13  Pedro Alves  <palves@redhat.com>
1923
1924         * completer.c (complete_line_internal_1): Rewind completion word
1925         point.
1926         (completion_tracker::advance_custom_word_point_by): Change
1927         parameter type to int.
1928         * completer.h (completion_tracker::advance_custom_word_point_by):
1929         Likewise.
1930
1931 2019-06-13  Pedro Alves  <palves@redhat.com>
1932
1933         * completer.c (advance_to_completion_word): Handle delimiters.
1934
1935 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1936
1937         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1938
1939 2019-06-11  Tom Tromey  <tom@tromey.com>
1940
1941         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1942         (xmalloc_failed): Move to alloc.c.
1943         * alloc.c: New file.
1944         * Makefile.in (COMMON_SFILES): Add alloc.c.
1945
1946 2019-06-11  Tom Tromey  <tom@tromey.com>
1947
1948         * nat/linux-waitpid.c: Don't include server.h.
1949         (linux_debug): Remove.
1950         (my_waitpid): Update.
1951
1952 2019-06-11  Tom Tromey  <tromey@adacore.com>
1953
1954         * infcall.c (_initialize_infcall): Remove trailing newline from
1955         help.
1956         * user-regs.c (_initialize_user_regs): Remove trailing newline
1957         from help.
1958         * typeprint.c (_initialize_typeprint): Remove trailing newline
1959         from help.
1960         * reverse.c (_initialize_reverse): Remove trailing newlines from
1961         help.
1962         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1963         from help.
1964         * language.c (add_set_language_command): Remove trailing newline
1965         from help.
1966         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1967         help.
1968         * disasm.c (_initialize_disasm): Remove trailing newline from
1969         help.
1970         * top.c (init_main): Remove trailing newline from help.
1971         * interps.c (_initialize_interpreter): Remove trailing newline
1972         from help.
1973         * btrace.c (_initialize_btrace): Remove trailing newlines from
1974         help.
1975         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1976         from help.
1977         * python/python.c (_initialize_python): Remove trailing newline
1978         from help.
1979         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1980         help.
1981         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1982         from help.  Reformat some text.
1983         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1984         from help.
1985         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1986         newline from help.
1987
1988 2019-06-11  Tom Tromey  <tromey@adacore.com>
1989
1990         * darwin-nat.c (darwin_decode_exception_message)
1991         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1992
1993 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1994
1995         * valops.c (value_slice): Check for not allocated or not
1996         associated values.
1997
1998 2019-06-10  Tom de Vries  <tdevries@suse.de>
1999
2000         PR gdb/24618
2001         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2002         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2003         invalid.
2004
2005 2019-06-10  Tom de Vries  <tdevries@suse.de>
2006
2007         PR gdb/24611
2008         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2009         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2010
2011 2019-06-10  Tom de Vries  <tdevries@suse.de>
2012
2013         PR symtab/24545
2014         * symtab.c (struct demangled_name_entry): Add language field.
2015         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2016         static minimal symbol".  Set and use language field.
2017
2018 2019-06-10  Tom Tromey  <tromey@adacore.com>
2019
2020         * ada-lang.c (_initialize_ada_language): Update help text.
2021
2022 2019-06-10  Tom Tromey  <tromey@adacore.com>
2023
2024         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2025         with a newline.
2026         * guile/guile.c (handle_boot_error): Don't end warning with a
2027         newline.
2028         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2029         warning with a newline.
2030         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2031         newline.
2032         (s12z_frame_cache): Likewise.
2033         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2034         a newline.
2035         * solib-svr4.c (disable_probes_interface): Don't end warning with
2036         a newline.
2037         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2038         newline.
2039         * python/python.c (do_finish_initialization): Don't end warning
2040         with a newline.
2041
2042 2019-06-10  Tom Tromey  <tom@tromey.com>
2043
2044         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2045         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2046         gdbpy_enter.
2047
2048 2019-06-10  Tom Tromey  <tromey@adacore.com>
2049
2050         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2051         data.
2052         (elf_new_init): Don't call stabsread_new_init.
2053         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2054         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2055         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2056
2057 2019-06-10  Tom de Vries  <tdevries@suse.de>
2058
2059         PR symtab/16264
2060         PR symtab/24517
2061         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2062
2063 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2064
2065         * source.c (find_and_open_source): Also rewrite relative file
2066         names.
2067
2068 2019-04-26  Amos Bird  <amosbird@gmail.com>
2069
2070         * annotate.c (annotate_thread_exited): Add "thread-exited"
2071         annotation.
2072
2073 2019-06-06  Tom Tromey  <tromey@adacore.com>
2074
2075         * maint.h (class scoped_command_stats): Use
2076         DISABLE_COPY_AND_ASSIGN.
2077         <print_time>: New method.
2078         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2079         print_time.
2080         (scoped_command_stats::print_time): New method.
2081
2082 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2083
2084         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2085         instructions of lengths 6 or 8 bytes.
2086
2087 2019-06-04  Pedro Alves  <palves@redhat.com>
2088
2089         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2090
2091         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2092         * breakpoint.c (condition_completer): Likewise.
2093         * cli/cli-dump.c (scan_expression): Likewise.
2094         * common/filestuff.c (mkdir_recursive): Likewise.
2095         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2096         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2097         (gdb_abspath): Likewise.
2098         * compile/compile-cplus-types.c
2099         (compile_cplus_instance::decl_name): Likewise.
2100         * completer.c (complete_explicit_location):
2101         (signal_completer, reg_or_group_completer_1): Likewise.
2102         * cp-support.c (cp_remove_params_if_any): Likewise.
2103         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2104         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2105         * infcmd.c (strip_bg_char): Likewise.
2106         * linespec.c (copy_token_string): Likewise.
2107         * mi/mi-main.c (output_cores): Likewise.
2108         * psymtab.c (psymtab_search_name):
2109         * symfile.c (test_set_ext_lang_command): Likewise.
2110         * target.c (target_fileio_read_stralloc): Likewise.
2111         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2112         * value.c (complete_internalvar): Likewise.
2113
2114 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2115
2116         Add objfile property to gdb.Type.
2117         * NEWS: Mention Python API addition.
2118         * python/py-type.c (typy_get_objfile): New method.
2119
2120 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2121
2122         * NEWS: Mention the new set|show style [title|highlight].
2123         Mention changes to "show style", "help" and "apropos".
2124
2125 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2126
2127         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2128         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2129         instead of print_help_for_command.
2130         (print_doc_of_command): New function.
2131         (help_list): Add 'apropos -v word' suggestion.
2132         (print_help_for_command): Style the command name using title style.
2133         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2134         (_initialize_cli_cmds): Describe -v in apropos_command help.
2135
2136 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2137
2138         * cli/cli-style.h (cli_style_option): Add name in constructor,
2139         add m_name class member, add constructor with intensity,
2140         add name class function.
2141         (cli_style_option::add_setshow_commands): Remove name argument.
2142         (highlight_style, title_style): New styles.
2143         * cli/cli-style.c (do_show): New function that shows a style
2144         characteristic styling the style name with itself.
2145         (set_style_name): New function.
2146         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2147         Update all callers according to the changes in cli/cli-style.h.
2148         * utils.h (fputs_highlighted): New function.
2149         * utils.c (fputs_highlighted): Likewise.
2150
2151 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2152
2153         * NEWS: Mention new pipe command and new convenience variables.
2154
2155 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2156
2157         * cli/cli-cmds.c (pipe_command): New function.
2158         (_initialize_cli_cmds): Call add_com for pipe_command.
2159         Define | as an alias for pipe.
2160         (exit_status_set_internal_vars): New function.
2161         (shell_escape): Call exit_status_set_internal_vars.
2162         cli/cli-decode.c (find_command_name_length): Recognize | as
2163         a single character command.
2164
2165 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2166
2167         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2168         top.c (execute_command_to_ui_file): New function, mostly a copy
2169         of execute_command_to_string.
2170         (execute_command_to_string): Implement by calling
2171         execute_command_to_ui_file.
2172
2173 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2174
2175         * top.h (saved_command_line): Remove declaration.
2176         * top.c (previous_saved_command_line, previous_repeat_arguments):
2177         New variables.
2178         (saved_command_line): Make static, define together with other
2179         'repeat variables'.
2180         (dont_repeat): Clear repeat_arguments.
2181         (repeat_previous, get_saved_command_line, save_command_line):
2182         New functions.
2183         (gdb_init): Initialize saved_command_line
2184         and previous_saved_command_line.
2185         * main.c (captured_main_1): Remove saved_command_line initialization.
2186         * event-top.c (handle_line_of_input): Update to use
2187         the new 'repeat' related functions instead of direct access to
2188         saved_command_line.
2189         * command.h (repeat_previous, get_saved_command_line,
2190         save_command_line): New declarations.
2191         (dont_repeat): Add comment.
2192
2193 2019-05-30  Tom Tromey  <tromey@adacore.com>
2194
2195         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2196         Fix comment.
2197         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2198
2199 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2200
2201         PR cli/24587
2202         * completer.c (complete): Initialize variable word.
2203
2204 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2205
2206         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2207         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2208         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2209         'body' is NULL to the outter 'if', protecting the '!is_define'
2210         situation as well.
2211
2212 2019-05-29  Tom Tromey  <tromey@adacore.com>
2213
2214         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2215         (dwarf_unknown): New function.
2216         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2217         (dwarf_type_encoding_name): Use dwarf_unknown.
2218
2219 2019-05-29  Tom Tromey  <tromey@adacore.com>
2220
2221         PR c++/20020:
2222         * cp-valprint.c (cp_print_value_fields): Call
2223         cp_print_static_field inside "try".
2224
2225 2019-05-29  Tom Tromey  <tromey@adacore.com>
2226
2227         * inflow.c (struct terminal_info): Add default operator=.
2228         * configure: Rebuild.
2229         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2230         -Wdeprecated-copy-dtor, -Wredundant-move.
2231
2232 2019-05-29  Tom Tromey  <tromey@adacore.com>
2233
2234         * NEWS: Add entry.
2235         * infcmd.c (print_return_value_1): Handle finish_print
2236         option.
2237         (show_print_finish): New function.
2238         (_initialize_infcmd): Add "set/show print finish" commands.
2239         * valprint.c (user_print_options): Initialize new member.
2240         * valprint.h (struct value_print_options) <finish_print>: New
2241         member.
2242
2243 2019-05-28  Tom Tromey  <tromey@adacore.com>
2244
2245         * ada-lang.c (ada_remove_Xbn_suffix)
2246         (find_old_style_renaming_symbol)
2247         (parse_old_style_renaming): Remove.
2248         (ada_find_renaming_symbol): Don't call
2249         find_old_style_renaming_symbol.
2250         (ada_is_renaming_symbol): Rename from
2251         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2252         bool.  Now static.
2253         (ada_read_var_value): Update and simplify.
2254         * ada-exp.y (write_var_or_type): Remove old code.
2255
2256 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2257
2258         * event-top.c: Remove include comment.
2259         * inflow.c (class scoped_ignore_sigttou): Move from here...
2260         * inflow.h (class scoped_ignore_sigttou): ...to here.
2261         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2262         * top.c:  Remove include comment.
2263
2264 2019-05-27  Tom Tromey  <tom@tromey.com>
2265
2266         * NEWS: Fix typo.
2267
2268 2019-05-22  Tom Tromey  <tromey@adacore.com>
2269
2270         * target.c (target_follow_exec): Constify parameter.
2271         * target-delegates.c: Rebuild.
2272         * remote.c (remote_target::follow_exec): Constify parameter.
2273         * infrun.c (follow_exec): Constify parameter.
2274         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2275         (target_follow_exec): Likewise.
2276
2277 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2278
2279         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2280         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2281
2282 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2283
2284         * NEWS: Add debugredirect and testsuite sections.
2285
2286 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2287
2288         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2289         target descriptions using exclusively floating point register name
2290         aliases.
2291
2292 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2293
2294         PR gdb/18644:
2295         * f-lang.c (build_fortran_types): Handle the case where
2296         gdbarch_floatformat_for_type returns a nullptr.
2297
2298 2019-05-21  Tom de Vries  <tdevries@suse.de>
2299
2300         PR cli/24587
2301         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2302
2303 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2304
2305         PR gdb/18644:
2306         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2307         16-byte floats.
2308         * i386-tdep.c (i386_floatformat_for_type): Use
2309         floatformats_ia64_quad for the 16-byte floating point component
2310         within a fortran 32-byte complex number.
2311
2312 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2313
2314         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2315         delete default constructor.
2316         (find_partial_die): Update to return const struct.
2317         (partial_die_parent_scope): Move variable declaration into scope
2318         of its use and change its type to auto.
2319         (guess_partial_die_structure_name): Likewise.
2320         (partial_die_info::fixup): Likewise.
2321
2322 2019-05-17  Tom Tromey  <tromey@adacore.com>
2323
2324         * source.c (find_and_open_source): Remove cast.
2325
2326 2019-05-17  Tom Tromey  <tromey@adacore.com>
2327
2328         * annotate.c (annotate_source): Make "filename" const.
2329         * annotate.h (annotate_source): Use const.
2330
2331 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2332
2333         * disasm.c (set_disassembler_options): Send errors to stderr.
2334
2335 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2336
2337         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2338         (cli_interp_base::set_logging): Check debug_redirect.
2339         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2340         * cli/cli-logging.c (debug_redirect): Add static variable.
2341         (pop_output_files): Add default param.
2342         (handle_redirections): Print debug setting.
2343         (show_logging_command): Likewise.
2344         (_initialize_cli_logging): Add debugredirect command.
2345         * interps.c (current_interp_set_logging): Add debug_redirect
2346         parameter.
2347         * interps.h (set_logging): Add debug_redirect parameter.
2348         (current_interp_set_logging): Likewise.
2349         * mi/mi-common.h: Likewise.
2350         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2351
2352 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2353             Tom Tromey  <tromey@adacore.com>
2354
2355         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2356         directly.
2357         * cli/cli-interp.h (make_logging_output): Remove declaration.
2358         * cli/cli-logging.c (make_logging_output): Remove function.
2359         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2360         directly.
2361         * ui-file.c (tee_file::tee_file): Remove bools.
2362         (tee_file::~tee_file): Remove deletes.
2363         * ui-file.h (tee_file): Remove bools.
2364
2365 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2366
2367         * mi/mi-cmds.h (mi_cmd_complete): New function.
2368         * mi/mi-main.c (mi_cmd_complete): Likewise.
2369         * mi/mi-cmds.c: Define new MI command -complete.
2370         * NEWS: Mention new -complete command.
2371
2372 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2373
2374         * completer.h (complete): New function.
2375         * completer.c (complete): Likewise.
2376         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2377         function defined in completer.h.
2378
2379 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2380
2381         * MAINTAINERS (Write After Approval): Add myself.
2382
2383 2019-05-17  Tom de Vries  <tdevries@suse.de>
2384
2385         PR gdb/24094
2386         * dwarf2read.c (struct cu_partial_die_info): New struct.
2387         (find_partial_die): Return cu_partial_die_info.
2388         (partial_die_parent_scope, guess_partial_die_structure_name)
2389         (partial_die_info::fixup): Handle new return type of find_partial_die.
2390
2391 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2392
2393         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2394         "std::string", simplifying the algorithm.
2395
2396 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2397
2398         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2399         (stap_static_probe_ops::get_probes): Likewise.
2400
2401 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2402
2403         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2404         '-')" and "else if".
2405         (stap_parse_single_operand): Join checks for
2406         "gdbarch_stap_parse_special_token_p" and
2407         "gdbarch_stap_parse_special_token" in the same "if" statement.
2408         Invert check when verifying for operation on register
2409         displacement.
2410
2411 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2412
2413         * stap-probe.c (stap_get_opcode): Update comment.
2414         (stap_get_expected_argument_type): Likewise.
2415         (handle_stap_probe): Likewise.
2416
2417 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2418
2419         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2420         return type to 'bool'.  Adjust comment.  Use 'bool' when
2421         appropriate.
2422         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2423         * stap-probe.c (stap_parse_argument_1): Likewise.
2424         (stap_is_operator): Likewise.
2425         (stap_is_generic_prefix): Likewise.
2426         (stap_is_register_prefix): Likewise.
2427         (stap_is_register_indirection_prefix): Likewise.
2428         (stap_is_integer_prefix): Likewise.
2429         (stap_generic_check_suffix): Likewise.
2430         (stap_check_integer_suffix): Likewise.
2431         (stap_check_register_suffix): Likewise.
2432         (stap_check_register_indirection_suffix): Likewise.
2433         (stap_parse_register_operand): Likewise.
2434         (stap_parse_single_operand): Likewise.
2435         (stap_parse_argument_1): Likewise.
2436         (stap_probe::get_argument_count): Likewise.
2437         (stap_is_operator): Likewise.
2438
2439 2019-05-16  Tom Tromey  <tromey@adacore.com>
2440
2441         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2442         keyword to foreach.
2443
2444 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2445
2446         * linux-thread-db.c (try_thread_db_load_1): Change return type
2447         to bool.
2448         (try_thread_db_load): Likewise.
2449         (try_thread_db_load_from_pdir_1): Likewise.
2450         (try_thread_db_load_from_pdir): Likewise.
2451         (try_thread_db_load_from_sdir): Likewise.
2452         (try_thread_db_load_from_dir): Likewise.
2453         (thread_db_load_search): Likewise.
2454         (has_libpthread): Likewise.
2455         (thread_db_load): Likewise.
2456
2457 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2458
2459         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2460         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2461         NULL, and complain/return if that's the case.
2462
2463 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2464
2465         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2466         (advance, posn, abstract_read_memory): New functions.
2467         [struct mem_read_abstraction]: New struct.
2468         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2469
2470 2019-05-14  Tom Tromey  <tromey@adacore.com>
2471
2472         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2473         value is not lval_memory.
2474
2475 2019-05-14  Tom Tromey  <tromey@adacore.com>
2476
2477         * solib.c (info_sharedlibrary_command): Style the file name.
2478
2479 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2480
2481         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2482         (aarch64_vnv_type): Likewise.
2483         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2484         * common/tdesc.c: Likewise.
2485         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2486         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2487         * features/aarch64-fpu.xml: Add ieee half view.
2488         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2489         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2490         * gdbtypes.h (struct builtin_type): Likewise.
2491         (struct objfile_type): Likewise.
2492
2493 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2494
2495         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2496         typo.
2497         * location.h (string_to_event_location): Likewise.
2498
2499 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2500
2501         GDB 8.3 released.
2502
2503 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2504
2505         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2506         New variable declaration.
2507         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2508         New variable.
2509         (print_one_breakpoint): Use ui_out::test_flags and new global
2510         variable to compute use_fixed_output.
2511         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2512         Remove.
2513         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2514         (mi_multi_location_breakpoint_output_fixed): Remove.
2515         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2516         new variable.
2517         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2518         fix_multi_location_breakpoint_output flag if version >= 3.
2519         * ui-out.h (enum ui_out_flag)
2520         <fix_multi_location_breakpoint_output>: New enumerator.
2521
2522 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2523
2524         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2525
2526 2019-05-10  Tom Tromey  <tromey@adacore.com>
2527
2528         * ada-lang.c (catch_ada_completer): New function.
2529         (_initialize_ada_language): Use it.
2530
2531 2019-05-10  Tom Tromey  <tromey@adacore.com>
2532
2533         * thread.c (print_thread_info): Make "requested_threads" const.
2534         * gdbthread.h (print_thread_info): Make "requested_threads"
2535         const.
2536         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2537         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2538
2539 2019-05-08  Tom Tromey  <tom@tromey.com>
2540
2541         * gdbtypes.c (objfile_type_data): Change type.
2542         (objfile_type, _initialize_gdbtypes): Update.
2543
2544 2019-05-08  Tom Tromey  <tom@tromey.com>
2545
2546         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2547         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2548         (_initialize_dwarf2_frame): Update.
2549
2550 2019-05-08  Tom Tromey  <tom@tromey.com>
2551
2552         * objc-lang.c (objc_objfile_data): Change type.
2553         (find_methods): Update.
2554         (_initialize_objc_lang): Remove.
2555
2556 2019-05-08  Tom Tromey  <tom@tromey.com>
2557
2558         * stabsread.c (rs6000_builtin_type_data): Change type.
2559         (rs6000_builtin_type, _initialize_stabsread): Update.
2560
2561 2019-05-08  Tom Tromey  <tom@tromey.com>
2562
2563         * mips-tdep.c (mips_pdr_data): Remove.
2564         (_initialize_mips_tdep): Update.
2565
2566 2019-05-08  Tom Tromey  <tom@tromey.com>
2567
2568         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2569         (hppa_init_objfile_priv_data, read_unwind_info)
2570         (find_unwind_entry, _initialize_hppa_tdep): Update.
2571
2572 2019-05-08  Tom Tromey  <tom@tromey.com>
2573
2574         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2575         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2576         on obstack.
2577         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2578
2579 2019-05-08  Tom Tromey  <tom@tromey.com>
2580
2581         * mdebugread.c (basic_type_data): Change type.
2582         (basic_type, _initialize_mdebugread): Update.
2583
2584 2019-05-08  Tom Tromey  <tom@tromey.com>
2585
2586         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2587
2588 2019-05-08  Tom Tromey  <tom@tromey.com>
2589
2590         * nto-tdep.c (nto_inferior_data_reg): Change type.
2591         (nto_inferior_data): Update.
2592         (nto_inferior_data_cleanup, nto_new_inferior_data)
2593         (_initialize_nto_tdep): Remove.
2594         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2595
2596 2019-05-08  Tom Tromey  <tom@tromey.com>
2597
2598         * ada-lang.c (struct ada_inferior_data): Add initializers.
2599         (ada_inferior_data): Change type.
2600         (ada_inferior_data_cleanup): Remove.
2601         (get_ada_inferior_data, ada_inferior_exit)
2602         (struct ada_pspace_data): Add initializers, destructor.
2603         (ada_pspace_data_handle): Change type.
2604         (get_ada_pspace_data): Update.
2605         (ada_pspace_data_cleanup): Remove.
2606
2607 2019-05-08  Tom Tromey  <tom@tromey.com>
2608
2609         * coffread.c (struct coff_symfile_info): Add initializers.
2610         (coff_objfile_data_key): Move lower.  Change type.
2611         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2612         Update.
2613         (coff_free_info): Remove.
2614
2615 2019-05-08  Tom Tromey  <tom@tromey.com>
2616
2617         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2618         (fbsd_pspace_data_handle): Move lower.  Change type.
2619         (get_fbsd_pspace_data): Update.
2620         (fbsd_pspace_data_cleanup): Remove.
2621         (_initialize_fbsd_tdep): Update.
2622
2623 2019-05-08  Tom Tromey  <tom@tromey.com>
2624
2625         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2626         (get_ada_tasks_pspace_data): Update.
2627         (ada_tasks_pspace_data_cleanup): Remove.
2628         (_initialize_tasks): Update.
2629         (ada_tasks_inferior_data_handle): Change type.
2630         (get_ada_tasks_inferior_data): Update.
2631         (ada_tasks_inferior_data_cleanup): Remove.
2632         (struct ada_tasks_pspace_data): Add initializers.
2633
2634 2019-05-08  Tom Tromey  <tom@tromey.com>
2635
2636         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2637         * symfile-debug.c (debug_sym_get_probes): Change type.
2638         * stap-probe.c (handle_stap_probe):
2639         (stap_static_probe_ops::get_probes): Change type.
2640         * probe.h (class static_probe_ops) <get_probes>: Change type.
2641         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2642         (parse_probes_in_pspace): Update.
2643         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2644         Update.
2645         (any_static_probe_ops::get_probes): Change type.
2646         * elfread.c (elfread_data): New typedef.
2647         (probe_key): Change type.
2648         (elf_get_probes): Likewise.  Update.
2649         (probe_key_free): Remove.
2650         (_initialize_elfread): Update.
2651         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2652         Change type.
2653         (dtrace_process_dof_probe, dtrace_process_dof)
2654         (dtrace_static_probe_ops::get_probe): Change type.
2655
2656 2019-05-08  Tom Tromey  <tom@tromey.com>
2657
2658         * xcoffread.c (struct xcoff_symfile_info): Rename from
2659         coff_symfile_info.  Add initializers.
2660         (xcoff_objfile_data_key): Move lower.  Change type.
2661         (XCOFF_DATA): Rewrite.
2662         (xcoff_free_info): Remove.
2663         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2664         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2665         (xcoff_initial_scan): Update.
2666
2667 2019-05-08  Tom Tromey  <tom@tromey.com>
2668
2669         * solib-svr4.c (struct svr4_info): Add initializers and
2670         destructor.
2671         <probes_table>: Now an htab_up.
2672         (solib_svr4_pspace_data): Change type.
2673         (free_probes_table): Simplify.
2674         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2675         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2676         (probes_table_remove_objfile_probes, register_solib_event_probe)
2677         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2678         (_initialize_svr4_solib): Update.
2679
2680 2019-05-08  Tom Tromey  <tom@tromey.com>
2681
2682         * remote.c (remote_pspace_data): Change type.
2683         (remote_pspace_data_cleanup): Remove.
2684         (get_remote_exec_file, set_pspace_remote_exec_file)
2685         (_initialize_remote): Update.
2686
2687 2019-05-08  Tom Tromey  <tom@tromey.com>
2688
2689         * breakpoint.c (breakpoint_objfile_key): Change type.
2690         (get_breakpoint_objfile_data): Update.
2691         (free_breakpoint_objfile_data): Remove.
2692         (_initialize_breakpoint): Update.
2693
2694 2019-05-08  Tom Tromey  <tom@tromey.com>
2695
2696         * linux-tdep.c (struct linux_info): Add initializers.
2697         (linux_inferior_data): Move.  Change type.
2698         (invalidate_linux_cache_inf): Update.
2699         (linux_inferior_data_cleanup): Remove.
2700         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2701
2702 2019-05-08  Tom Tromey  <tom@tromey.com>
2703
2704         * auxv.c (auxv_inferior_data): Move.  Change type.
2705         (auxv_inferior_data_cleanup): Remove.
2706         (invalidate_auxv_cache_inf): Rewrite.
2707         (get_auxv_inferior_data, _initialize_auxv): Update.
2708
2709 2019-05-08  Tom Tromey  <tom@tromey.com>
2710
2711         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2712         (symfile_debug_objfile_data_key): Change type.
2713         (symfile_debug_installed, debug_qf_has_symbols)
2714         (debug_qf_find_last_source_symtab)
2715         (debug_qf_forget_cached_source_info)
2716         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2717         (debug_qf_print_stats, debug_qf_dump)
2718         (debug_qf_expand_symtabs_for_function)
2719         (debug_qf_expand_all_symtabs)
2720         (debug_qf_expand_symtabs_with_fullname)
2721         (debug_qf_map_matching_symbols)
2722         (debug_qf_expand_symtabs_matching)
2723         (debug_qf_find_pc_sect_compunit_symtab)
2724         (debug_qf_map_symbol_filenames)
2725         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2726         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2727         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2728         (debug_sym_read_linetable, debug_sym_relocate): Update.
2729         (symfile_debug_free_objfile): Remove.
2730         (install_symfile_debug_logging, _initialize_symfile_debug):
2731         Update.
2732
2733 2019-05-08  Tom Tromey  <tom@tromey.com>
2734
2735         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2736         allocate_on_obstack.
2737         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2738         (get_dwarf2_per_objfile): Update.
2739         (set_dwarf2_per_objfile): Remove.
2740         (dwarf2_has_info, dwarf2_get_section_info): Update.
2741         (dwarf2_free_objfile): Remove.
2742         (_initialize_dwarf2_read): Update.
2743
2744 2019-05-08  Tom Tromey  <tom@tromey.com>
2745
2746         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2747         initializers.
2748         <unsupported_script_warning_printed,
2749         script_not_found_warning_printed>: Now bool.
2750         (auto_load_pspace_data): Change type.
2751         (~auto_load_pspace_info): Rename from
2752         auto_load_pspace_data_cleanup.
2753         (get_auto_load_pspace_data, init_loaded_scripts_info)
2754         (clear_section_scripts, maybe_print_unsupported_script_warning)
2755         (maybe_print_script_not_found_warning, _initialize_auto_load):
2756         Update.
2757
2758 2019-05-08  Tom Tromey  <tom@tromey.com>
2759
2760         * objfiles.c (objfile_pspace_info): Add destructor and
2761         initializers.
2762         (objfiles_pspace_data): Change type.
2763         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2764         (get_objfile_pspace_data): Update.
2765         (objfiles_bfd_data): Change type.
2766         (get_objfile_bfd_data): Update.
2767         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2768
2769 2019-05-08  Tom Tromey  <tom@tromey.com>
2770
2771         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2772         Change type.
2773         (get_catch_syscall_inferior_data): Update.
2774         (catch_syscall_inferior_data_cleanup): Remove.
2775         (_initialize_break_catch_syscall): Update.
2776
2777 2019-05-08  Tom Tromey  <tom@tromey.com>
2778
2779         * inflow.c (struct terminal_info): Add destructor and
2780         initializers.
2781         (inflow_inferior_data): Change type.
2782         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2783         (get_inflow_inferior_data, inflow_inferior_exit)
2784         (swap_terminal_info, _initialize_inflow): Update.
2785
2786 2019-05-08  Tom Tromey  <tom@tromey.com>
2787
2788         * target-dcache.c (target_dcache_cleanup): Remove.
2789         (target_dcache_aspace_key): Change type.
2790         (target_dcache_init_p, target_dcache_invalidate)
2791         (target_dcache_get, target_dcache_get_or_init)
2792         (_initialize_target_dcache): Update.
2793         * dcache.h (struct dcache_deleter): New.
2794
2795 2019-05-08  Tom Tromey  <tom@tromey.com>
2796
2797         * symtab.c (struct symbol_cache): Add destructor and
2798         initializers.
2799         (symbol_cache_key): Move.  Change type.
2800         (make_symbol_cache, free_symbol_cache): Remove.
2801         (get_symbol_cache): Update.
2802         (symbol_cache_cleanup): Remove.
2803         (ALL_PSPACES, symbol_cache_flush)
2804         (maintenance_print_symbol_cache)
2805         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2806         Update.
2807
2808 2019-05-08  Tom Tromey  <tom@tromey.com>
2809
2810         * symtab.c (struct main_info): Add destructor and initializers.
2811         (main_progspace_key): Move.  Change type.
2812         (get_main_info): Update.
2813         (main_info_cleanup): Remove.
2814         (_initialize_symtab): Update.
2815
2816 2019-05-08  Tom Tromey  <tom@tromey.com>
2817
2818         * registry.h (DECLARE_REGISTRY): Define the _key class.
2819
2820 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2821
2822         * NEWS: Merge two 'New commands' sections.
2823
2824 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2825
2826         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2827         parameter and use Ada language definition instead.
2828         (ada_val_print_ptr): Remove unused language parameter.
2829         (ada_val_print_num): Remove language parameter and use Ada language
2830         definition instead.
2831         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2832         parameter.
2833         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2834         parameter and use Ada language definition instead.
2835         (ada_val_print_1): Update all ada_val_print_xxx calls.
2836         Remove language parameter.
2837         (ada_val_print): Update ada_val_print_1 call.
2838
2839 2019-05-08  Tom Tromey  <tromey@adacore.com>
2840
2841         * remote.c (remote_hw_watchpoint_limit)
2842         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2843         Now static.
2844
2845 2019-05-08  Tom Tromey  <tromey@adacore.com>
2846
2847         * maint.c (_initialize_maint_cmds): Move initialization code to
2848         remote.c.
2849         (watchdog, show_watchdog): Move to remote.c.
2850         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2851         "watchdog" static.
2852         (_initialize_remote): Move initialization code from maint.c.
2853         * defs.h (watchdog): Don't declare.
2854
2855 2019-05-08  Tom Tromey  <tromey@adacore.com>
2856
2857         * tui/tui-interp.c: Include main.h.
2858         * interps.c: Include main.h.
2859         * main.h (interpreter_p): Declare.
2860         * defs.h (interpreter_p): Don't declare.
2861
2862 2019-05-08  Tom Tromey  <tromey@adacore.com>
2863
2864         * dwarf2loc.c: Include dwarf2read.h.
2865         * defs.h (read_unsigned_leb128): Don't declare.
2866         * dwarf2read.h (read_unsigned_leb128): Declare.
2867
2868 2019-05-08  Tom Tromey  <tromey@adacore.com>
2869
2870         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2871         method.
2872
2873 2019-05-08  Tom Tromey  <tromey@adacore.com>
2874
2875         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2876         when no wrap column is set.
2877
2878 2019-05-08  Tom Tromey  <tromey@adacore.com>
2879
2880         * c-lang.c (c_get_string): Handle non-C-style arrays.
2881
2882 2019-05-08  Tom Tromey  <tromey@adacore.com>
2883
2884         * typeprint.c (print_offset_data::update): Print the bit offset,
2885         not the number of bits remaining.
2886
2887 2019-05-08  Tom Tromey  <tromey@adacore.com>
2888
2889         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2890         padding at end of comment.
2891
2892 2019-05-08  Tom Tromey  <tromey@adacore.com>
2893
2894         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2895         Compare main types.
2896
2897 2019-05-06  Tom Tromey  <tom@tromey.com>
2898
2899         * common/scoped_mmap.c: Include common-defs.h.
2900         * common/scoped_mmap.h: Don't include config.h.
2901
2902 2019-05-04  Tom Tromey  <tom@tromey.com>
2903
2904         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2905         (struct aarch64_call_info): Add initializers.
2906         <si>: Now a std::vector.
2907         (pass_on_stack, aarch64_push_dummy_call): Update.
2908
2909 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2910             Tom Tromey  <tom@tromey.com>
2911
2912         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2913         (ppc_threads): Now a std::vector.  Now static.
2914         (hwdebug_find_thread_points_by_tid)
2915         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2916         Update.
2917
2918 2019-05-04  Tom Tromey  <tom@tromey.com>
2919
2920         * arc-tdep.c (arc_tdesc_init): Return bool.
2921
2922 2019-05-04  Tom Tromey  <tom@tromey.com>
2923
2924         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2925         Use gdb_assert_not_reached.
2926
2927 2019-05-04  Tom Tromey  <tom@tromey.com>
2928
2929         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2930         "false".
2931
2932 2019-05-04  Tom Tromey  <tom@tromey.com>
2933
2934         * arc-tdep.c (arc_tdesc_init): Use bool.
2935
2936 2019-05-04  Tom Tromey  <tom@tromey.com>
2937
2938         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2939
2940 2019-05-04  Tom Tromey  <tom@tromey.com>
2941
2942         * cli/cli-cmds.c (valid_command_p): Return bool.
2943
2944 2019-05-04  Tom Tromey  <tom@tromey.com>
2945
2946         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2947         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2948
2949 2019-05-04  Raul Tambre  <raul@tambre.ee>
2950
2951         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2952         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2953         operator for comparison.
2954
2955 2019-05-04  Tom Tromey  <tom@tromey.com>
2956
2957         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2958         (lookup_partial_symbol, print_partial_symbols)
2959         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2960         (psymbol_compare): Update.
2961         (add_psymbol_to_bcache): Clear the entire psymbol.
2962         (maintenance_check_psymtabs): Update.
2963         * psympriv.h (struct partial_symbol): Don't derive from
2964         general_symbol_info.
2965         <obj_section, unrelocated_address, address,
2966         set_unrelocated_address>: Update.
2967         <ginfo>: New member.
2968         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2969         (debug_names::write_psymbols): Update.
2970
2971 2019-05-04  Tom de Vries  <tdevries@suse.de>
2972
2973         * contrib/cc-with-tweaks.sh: Support -n arg.
2974
2975 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2976
2977         * corelow.c (core_target::detach): Ensure frame cache and
2978         register caches are cleared.
2979         inferior.c (exit_inferior_1): Likewise.
2980
2981 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2982             Tom Tromey  <tom@tromey.com>
2983
2984         * dictionary.c (collate_pending_symbols_by_language): Remove
2985         "struct" from foreach.
2986         * symtab.c (lookup_global_symbol_from_objfile)
2987         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2988         foreach.
2989         * ser-tcp.c (net_open): Remove "struct" from foreach.
2990         * objfiles.c (objfile_relocate, objfile_rebase)
2991         (objfile_has_symbols): Remove "struct" from foreach.
2992         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2993         from foreach.
2994         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2995         foreach.
2996         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2997         "struct" from foreach.
2998         * ada-lang.c (create_excep_cond_exprs)
2999         (ada_exception_catchpoint_cond_string): Remove "struct" from
3000         foreach.
3001
3002 2019-05-03  Tom Tromey  <tromey@adacore.com>
3003
3004         * ada-exp.y (convert_char_literal): Check suffix of each
3005         enumerator.
3006
3007 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3008
3009         PR ada/21406:
3010         * ada-exp.y (yywrap): Don't define.
3011         * ada-lex.l (%option): Add noyywrap
3012         (yywrap): Remove.
3013
3014 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3015
3016         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3017         _WIN32_WINNT to the XP level, unless already defined to a higher
3018         level.
3019
3020         * unittests/parse-connection-spec-selftests.c:
3021         * ser-tcp.c:
3022         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3023         override.
3024
3025         * symfile.c (find_separate_debug_file): Remove colon from the
3026         drive spec of DOS/Windows file names of the target, so that the
3027         file name produced from DEBUGDIR and the target's directory will
3028         be valid on DOS/Windows systems.
3029
3030 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3031
3032         * rust-lang.c (val_print_struct): Handle printing structures
3033         containing strings.
3034
3035 2019-05-02  Tom Tromey  <tromey@adacore.com>
3036
3037         * valarith.c (_initialize_valarith): Remove.
3038
3039 2019-05-01  Tom Tromey  <tromey@adacore.com>
3040
3041         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3042         bitfields.
3043
3044 2019-05-01  Tom Tromey  <tromey@adacore.com>
3045
3046         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3047         for big-endian copies.
3048
3049 2019-04-30  Ali Tamur  <tamur@google.com>
3050         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3051         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3052         (read_3_bytes): New function.
3053
3054 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3055
3056         * windows-nat.c (main_thread_id): Delete.
3057         (handle_output_debug_string): Replace main_thread_id by
3058         current_event.dwThreadId.
3059         (fake_create_process): Likewise.
3060         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3061         Do not set main_thread_id.
3062         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3063         current_event.dwThreadId.
3064         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3065
3066 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3067
3068         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3069         Use current_event.dwThreadId instead of main_thread_id.
3070
3071 2019-04-30  Tom Tromey  <tromey@adacore.com>
3072
3073         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3074         (create_excep_cond_exprs): Iterate over program spaces.
3075         (ada_exception_catchpoint_cond_string): Examine all minimal
3076         symbols for exception types.
3077
3078 2019-04-30  Tom Tromey  <tromey@adacore.com>
3079
3080         PR c++/24470:
3081         * dwarf2read.c (process_structure_scope): Handle case where type
3082         has template parameters but no symbol was created.
3083
3084 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3085             Chris January  <chris.january@arm.com>
3086
3087         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3088         qualifier.
3089         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3090
3091 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3092
3093         * f-typeprint.c (f_print_type): Update rules for printing
3094         whitespace.
3095         (f_type_print_varspec_suffix): Likewise.
3096
3097 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3098             Chris January  <chris.january@arm.com>
3099
3100         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3101         function arguments.
3102
3103 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3104
3105         * f-lang.c (build_fortran_types): Change name of void type to
3106         lower case.
3107         * f-typeprint.c (f_type_print_base): Print the name of the void
3108         type, rather than a fixed string.
3109         * f-valprint.c (f_decorations): Use lower case void string.
3110
3111 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3112             Chris January  <chris.january@arm.com>
3113
3114         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3115         types for Fortran.
3116
3117 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3118             Chris January  <chris.january@arm.com>
3119             David Lecomber  <david.lecomber@arm.com>
3120
3121         * f-exp.y (BINOP_INTRINSIC): New token.
3122         (exp): New parser rule handling BINOP_INTRINSIC.
3123         (f77_keywords): Add new builtin procedures.
3124         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3125         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3126         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3127         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3128         (print_unop_subexp_f): New function.
3129         (print_binop_subexp_f): New function.
3130         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3131         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3132         (dump_subexp_body_f): Likewise.
3133         (operator_check_f): Likewise.
3134         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3135         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3136
3137 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3138
3139         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3140         UNOP_KIND.
3141         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3142         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3143         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3144         (operator_length_f): New fuction.
3145         (print_subexp_f): New function.
3146         (op_name_f): New function.
3147         (dump_subexp_body_f): New function.
3148         (operator_check_f): New function.
3149         (exp_descriptor_f): Replace standard expression handling functions
3150         with new functions.
3151         * gdb/fortran-operator.def: New file.
3152         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3153         * gdb/std-operator.def: Remove UNOP_KIND.
3154
3155 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3156
3157         * std-operator.def: Remove unbalanced, stray double quote
3158         character.
3159
3160 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3161             Chris January  <chris.january@arm.com>
3162             Daniel Everett  <daniel.everett@arm.com>
3163             Nick Forrington  <nick.forrington@arm.com>
3164             Richard Bunt  <richard.bunt@arm.com>
3165
3166         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3167         of depth when printing anonymous structs or unions.
3168         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3169         Don't print either the top-level value, or the children if the
3170         max-depth is exceeded.
3171         (ppscm_print_children): When printing the key of a map, allow one
3172         extra level of depth.
3173         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3174         print either the top-level value, or the children if the max-depth
3175         is exceeded.
3176         (print_children): When printing the key of a map, allow one extra
3177         level of depth.
3178         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3179         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3180         (user_print_options): Initialise max_depth field.
3181         (val_print_scalar_or_string_type_p): New function.
3182         (val_print): Check to see if the max depth has been reached.
3183         (val_print_check_max_depth): Define new function.
3184         (show_print_max_depth): New function.
3185         (_initialize_valprint): Add 'print max-depth' option.
3186         * valprint.h (struct value_print_options) <max_depth>: New field.
3187         (val_print_check_max_depth): Declare new function.
3188         * NEWS: Document new feature.
3189
3190 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3191
3192         * ada-lang.c (ada_language_defn): Initialise new field.
3193         * c-lang.c (c_is_string_type_p): New function.
3194         (c_language_defn): Initialise new field.
3195         (cplus_language_defn): Initialise new field.
3196         (asm_language_defn): Initialise new field.
3197         (minimal_language_defn): Initialise new field.
3198         * c-lang.h (c_is_string_type_p): Declare new function.
3199         * d-lang.c (d_language_defn): Initialise new field.
3200         * f-lang.c (f_is_string_type_p): New function.
3201         (f_language_defn): Initialise new field.
3202         * go-lang.c (go_is_string_type_p): New function.
3203         (go_language_defn): Initialise new field.
3204         * language.c (default_is_string_type_p): New function.
3205         (unknown_language_defn): Initialise new field.
3206         (auto_language_defn): Initialise new field.
3207         * language.h (struct language_defn) <la_is_string_type_p>: New
3208         member variable.
3209         (default_is_string_type_p): Declare new function.
3210         * m2-lang.c (m2_language_defn): Initialise new field.
3211         * objc-lang.c (objc_language_defn): Initialise new field.
3212         * opencl-lang.c (opencl_language_defn): Initialise new field.
3213         * p-lang.c (pascal_is_string_type_p): New function.
3214         (pascal_language_defn): Initialise new field.
3215         * rust-lang.c (rust_is_string_type_p): New function.
3216         (rust_language_defn): Initialise new field.
3217
3218 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3219
3220         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3221         New field.
3222         * ada-lang.c (ada_language_defn): Initialise new field.
3223         * c-lang.c (c_language_defn): Likewise.
3224         (cplus_language_defn): Likewise.
3225         (asm_language_defn): Likewise.
3226         (minimal_language_defn): Likewise.
3227         * d-lang.c (d_language_defn): Likewise.
3228         * f-lang.c (f_language_defn): Likewise.
3229         * go-lang.c (go_language_defn): Likewise.
3230         * language.c (unknown_language_defn): Likewise.
3231         (auto_language_defn): Likewise.
3232         * m2-lang.c (m2_language_defn): Likewise.
3233         * objc-lang.c (objc_language_defn): Likewise.
3234         * opencl-lang.c (opencl_language_defn): Likewise.
3235         * p-lang.c (pascal_language_defn): Likewise.
3236         * rust-lang.c (rust_language_defn): Likewise.
3237
3238 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3239
3240         * ada-lang.c (ada_is_character_type): Change return type to bool.
3241         (ada_is_string_type): Likewise.
3242         * ada-lang.h (ada_is_character_type): Update declaration
3243         (ada_is_string_type): Likewise.
3244
3245 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3246
3247         Support style in 'frame|thread apply'
3248
3249         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3250         * record.c (record_start, record_stop): Update callers of
3251         execute_command_to_string with false.
3252         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3253         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3254         methods.
3255         (class string_file): New constructor with term_out parameter.
3256         Override methods term_out and can_emit_style_escape.  New member
3257         term_out.
3258         (class stdio_file): Override can_emit_style_escape.
3259         (class tee_file): Override term_out and can_emit_style_escape.
3260         * utils.h (can_emit_style_escape): Remove.
3261         * utils.c (can_emit_style_escape): Likewise.
3262         Update all callers of can_emit_style_escape (SOMESTREAM) to
3263         SOMESTREAM->can_emit_style_escape.
3264         * source-cache.c (source_cache::get_source_lines): Likewise.
3265         * stack.c (frame_apply_command_count): Call execute_command_to_string
3266         passing the term_out characteristic of the current gdb_stdout.
3267         * thread.c (thr_try_catch_cmd): Likewise.
3268         * top.c (execute_command_to_string): pass term_out parameter
3269         to construct the string_file for the command output.
3270         * ui-file.c (term_cli_styling): New function (most code moved
3271         from utils.c can_emit_style_escape).
3272         (string_file::string_file, string_file::can_emit_style_escape,
3273         stdio_file::can_emit_style_escape, tee_file::term_out,
3274         tee_file::can_emit_style_escape): New functions.
3275
3276 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3277
3278         * NEWS: Mention the new set|show may-call-functions.
3279         * infcall.c (may_call_functions_p): New variable.
3280         (show_may_call_functions_p): New function.
3281         (call_function_by_hand_dummy): Throws an error if not
3282         may-call-functions.
3283         (_initialize_infcall): Call add_setshow_boolean_cmd for
3284         may-call-functions.
3285
3286 2019-04-25  Keith Seitz  <keiths@redhat.com>
3287
3288         PR c++/24367
3289         * cp-support.c (inspect_type): Don't attempt substitutions
3290         of symbol with the same name.
3291
3292 2019-04-25  Tom Tromey  <tromey@adacore.com>
3293
3294         PR gdb/24475:
3295         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3296         static.
3297
3298 2019-04-25  Tom Tromey  <tromey@adacore.com>
3299
3300         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3301         rvalue reference.
3302         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3303         (gdb_xml_parser::parse): Use std::move.
3304         * python/python-internal.h (gdbpy_convert_exception): Take a const
3305         reference.
3306         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3307         std::move.
3308         * python/py-utils.c (gdbpy_convert_exception): Take a const
3309         reference.
3310         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3311         Use std::move.
3312         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3313         Use std::move.
3314         * mi/mi-main.c (mi_print_exception): Take a const reference.
3315         * main.c (handle_command_errors): Take a const reference.
3316         * linespec.c (parse_linespec): Use std::move.
3317         * infcall.c (run_inferior_call): Use std::move.
3318         (call_function_by_hand_dummy): Use std::move.
3319         * exec.c (try_open_exec_file): Use std::move.
3320         * exceptions.h (exception_print, exception_fprintf)
3321         (exception_print_same): Update.
3322         * exceptions.c (print_exception, exception_print)
3323         (exception_fprintf, exception_print_same): Change parameters to
3324         const reference.
3325         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3326         * common/new-op.c: Use std::move.
3327         * common/common-exceptions.h (struct gdb_exception): Add move
3328         constructor.
3329         (struct gdb_exception_error, struct gdb_exception_quit, struct
3330         gdb_quit_bad_alloc): Change constructor to move constructor.
3331         (throw_exception): Change parameter to rvalue reference.
3332         * common/common-exceptions.c (throw_exception): Take rvalue
3333         reference.
3334         * cli/cli-interp.c (safe_execute_command): Use std::move.
3335         * breakpoint.c (insert_bp_location, location_to_sals): Use
3336         std::move.
3337
3338 2019-04-25  Tom Tromey  <tromey@adacore.com>
3339
3340         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3341         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3342         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3343         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3344         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3345         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3346         guile/scm-value.c: Use unpack.
3347         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3348         gdbscm_gdb_exception.
3349         (gdbscm_throw_gdb_exception): Likewise.
3350         (struct gdbscm_gdb_exception): New.
3351         (unpack): New function.
3352         (gdbscm_wrap): Use unpack.
3353
3354 2019-04-25  Tom Tromey  <tromey@adacore.com>
3355
3356         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3357         (gdb_rl_callback_handler): Use std::move.
3358         * common/common-exceptions.h (struct gdb_exception): Add move
3359         assignment operator.
3360         (throw_exception_sjlj): Change "exception" to const reference.
3361         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3362         (throw_exception_sjlj): Change "exception" to const reference.
3363
3364 2019-04-25  Tom Tromey  <tromey@adacore.com>
3365
3366         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3367         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3368         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3369         Update.
3370         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3371         Update.
3372         * mi/mi-interp.c (mi_interp::exec): Update.
3373         * linespec.c (parse_linespec): Update.
3374         * infcall.c (run_inferior_call): Update.
3375         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3376         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3377         (gdbscm_lookup_global_symbol): Update.
3378         * guile/scm-param.c (gdbscm_parameter_value): Update.
3379         * guile/scm-frame.c (gdbscm_frame_read_register)
3380         (gdbscm_frame_read_var): Update.
3381         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3382         * exec.c (try_open_exec_file): Update.
3383         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3384         (gdb_rl_callback_handler): Update.
3385         * common/common-exceptions.h (exception_none): Don't declare.
3386         * common/common-exceptions.c (exception_none): Don't define.
3387         (struct catcher) <exception>: Update.
3388         * cli/cli-interp.c (safe_execute_command): Update.
3389         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3390
3391 2019-04-25  Ali Tamur  <tamur@google.com>
3392
3393         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3394         (read_attribute_value): Likewise.
3395         (dwarf2_read_addr_index): Update comment.
3396         (read_str_index): Add DW_FORM_strx.
3397         (dwarf2_string_attr): Likewise.
3398         (dwarf2_const_value_attr): Likewise.
3399         (dump_die_shallow): Likewise.
3400         (dwarf2_fetch_constant_bytes): Likewise.
3401         (skip_form_bytes): Likewise.
3402         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3403
3404 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3405
3406         PR corefiles/11608
3407         PR corefiles/18187
3408         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3409         OFFSET.  Verify if current mapping contains an ELF header.
3410         (linux_find_memory_regions_full): Adjust call to
3411         dump_mapping_p.
3412
3413 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3414             Kang Li <kanglictf@gmail.com>
3415
3416         PR gdb/21600
3417
3418         * dwarf2-frame.c (read_initial_length): Be consistent about using
3419         unsigned representation of length.
3420         (decode_frame_entry_1): Likewise.  Check for wraparound of
3421         end pointer as well as buffer overflow.
3422
3423 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3424
3425         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3426         "vq".
3427
3428 2019-04-24  Tom Tromey  <tromey@adacore.com>
3429
3430         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3431
3432 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3433
3434         * s12z-tdep.c (s12z_unwind_pc): Delete.
3435         (s12z_unwind_sp): Delete.
3436         (s12z_gdbarch_init): Don't register deleted functions with
3437         gdbarch.
3438
3439 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3440
3441         * rl78-tdep.c (rl78_unwind_sp): Delete.
3442         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3443
3444 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3445
3446         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3447         (xstormy16_unwind_pc): Delete.
3448         (xstormy16_dummy_id): Delete.
3449         (xstormy16_gdbarch_init): Don't register deleted functions with
3450         gdbarch.
3451
3452 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3453
3454         * vax-tdep.c (vax_unwind_pc): Delete.
3455         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3456
3457 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3458
3459         * v850-tdep.c (v850_unwind_sp): Delete.
3460         (v850_unwind_pc): Delete.
3461         (v850_dummy_id): Delete.
3462         (v850_gdbarch_init): Don't register deleted functions with
3463         gdbarch.
3464
3465 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3466
3467         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3468         (tilegx_unwind_pc): Delete.
3469         (tilegx_unwind_dummy_id): Delete.
3470         (tilegx_gdbarch_init): Don't register deleted functions with
3471         gdbarch.
3472
3473 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3474
3475         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3476         (tic6x_dummy_id): Delete.
3477         (tic6x_gdbarch_init): Don't register deleted functions with
3478         gdbarch.
3479
3480 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3481
3482         * sparc-tdep.c (sparc_unwind_pc): Delete.
3483         (sparc32_gdbarch_init): Don't register deleted function with
3484         gdbarch.
3485
3486 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3487
3488         * sh-tdep.c (sh_unwind_sp): Delete.
3489         (sh_unwind_pc): Delete.
3490         (sh_dummy_id): Delete.
3491         (sh_gdbarch_init): Don't register deleted functions with
3492         gdbarch.
3493
3494 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3495
3496         * score-tdep.c (score_unwind_sp): Delete.
3497         (score_unwind_pc): Delete.
3498         (score_dummy_id): Delete.
3499         (score_gdbarch_init): Don't register deleted functions with
3500         gdbarch.
3501
3502 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3503
3504         * rx-tdep.c (rx_unwind_pc): Delete.
3505         (rx_unwind_sp): Delete.
3506         (rx_dummy_id): Delete.
3507         (rx_gdbarch_init): Don't register deleted functions with
3508         gdbarch.  Update comment.
3509
3510 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3511
3512         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3513         (rs6000_dummy_id): Delete.
3514         (rs6000_gdbarch_init): Don't register deleted functions with
3515         gdbarch.
3516
3517 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3518
3519         * or1k-tdep.c (or1k_dummy_id): Delete.
3520         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3521
3522 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3523
3524         * nios2-tdep.c (nios2_dummy_id): Delete.
3525         (nios2_unwind_sp): Delete.
3526         (nios2_gdbarch_init): Don't register deleted functions with
3527         gdbarch.
3528
3529 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3530
3531         * nds32-tdep.c (nds32_dummy_id): Delete.
3532         (nds32_unwind_pc): Delete.
3533         (nds32_unwind_sp): Delete.
3534         (nds32_gdbarch_init): Don't register deleted functions with
3535         gdbarch.
3536
3537 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3538
3539         * msp430-tdep.c (msp430_unwind_pc): Delete.
3540         (msp430_unwind_sp): Delete.
3541         (msp430_dummy_id): Delete.
3542         (msp430_gdbarch_init): Don't register deleted functions with
3543         gdbarch.
3544
3545 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3546
3547         * moxie-tdep.c (moxie_unwind_sp): Delete.
3548         (moxie_unwind_pc): Delete.
3549         (moxie_dummy_id): Delete.
3550         (moxie_gdbarch_init): Don't register deleted functions with
3551         gdbarch.
3552
3553 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3554
3555         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3556         (mn10300_unwind_pc): Delete.
3557         (mn10300_unwind_sp): Delete.
3558         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3559         mn10300_unwind_sp.
3560         (mn10300_frame_unwind_init): Don't register deleted functions with
3561         gdbarch.
3562
3563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3564
3565         * mep-tdep.c (mep_unwind_pc): Delete.
3566         (mep_unwind_sp): Delete.
3567         (mep_dummy_id): Delete.
3568         (mep_gdbarch_init): Don't register deleted functions with
3569         gdbarch.
3570
3571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3572
3573         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3574         (m68hc11_unwind_sp): Delete.
3575         (m68hc11_gdbarch_init): Don't register deleted functions with
3576         gdbarch.
3577
3578 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3579
3580         * m32r-tdep.c (m32r_unwind_sp): Delete.
3581         (m32r_unwind_pc): Delete.
3582         (m32r_dummy_id): Delete.
3583         (m32r_gdbarch_init): Don't register deleted functions with
3584         gdbarch.
3585
3586 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3587
3588         * m32c-tdep.c (m32c_unwind_pc): Delete.
3589         (m32c_unwind_sp): Delete.
3590         (m32c_dummy_id): Delete.
3591         (m32c_gdbarch_init): Don't register deleted functions with
3592         gdbarch.
3593
3594 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3595
3596         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3597         (lm32_unwind_pc): Delete.
3598         (lm32_dummy_id): Delete.
3599         (lm32_gdbarch_init): Don't register deleted functions with
3600         gdbarch.
3601
3602 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3603
3604         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3605         (iq2000_unwind_pc): Delete.
3606         (iq2000_dummy_id): Delete.
3607         (iq2000_gdbarch_init): Don't register deleted functions with
3608         gdbarch.
3609
3610 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3611
3612         * nds32-tdep.c (nds32_type_align): Delete.
3613         (nds32_push_dummy_call): Use type_align instead.
3614
3615 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3616
3617         * arm-tdep.c (arm_type_align): Only handle vector override case.
3618         (arm_push_dummy_call): Use type_align.
3619         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3620
3621 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3622
3623         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3624         case.
3625         (pass_on_stack): Use type_align.
3626         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3627         function.
3628
3629 2019-04-23  Tom Tromey  <tromey@adacore.com>
3630
3631         * dwarf2read.c (line_header::file_name_at): Remove unused
3632         overload.
3633
3634 2019-04-23  Tom de Vries  <tdevries@suse.de>
3635
3636         PR gdb/24438
3637         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3638         invocation.
3639
3640
3641 2019-03-27  Ali Tamur  <tamur@google.com>
3642
3643         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3644         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3645         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3646         (dwarf_expr_context::get_addr_index): Likewise
3647         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3648         (symbol_needs_eval_context::get_addr_index): Likewise
3649         (disassemble_dwarf_expression): Add DW_OP_addrx
3650         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3651         (read_cutu_die_from_dwo): Update comment
3652         (skip_one_die): Add DW_FORM_addrx
3653         (read_attribute_value): Likewise
3654         (var_decode_location): Add DW_OP_addrx
3655         (dwarf2_const_value_attr): Add DW_FORM_addrx
3656         (dump_die_shallow): Likewise
3657         (dwarf2_fetch_constant_bytes): Likewise
3658         (decode_locdesc): Add DW_OP_addrx
3659         (skip_form_bytes): Add DW_FORM_addrx
3660
3661 2019-04-22  Ali Tamur  <tamur@google.com>
3662
3663         * MAINTAINERS (Write After Approval): Add self.
3664
3665 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3666
3667         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3668         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3669         (open_symbol_file_object): Likewise.
3670         (svr4_default_sos): Add info parameter.
3671         (svr4_read_so_list): Likewise.
3672         (svr4_current_sos_direct): Adjust functions calls to pass down
3673         info.
3674         (svr4_current_sos_1): Add info parameter.
3675         (svr4_current_sos): Call get_svr4_info, pass info down to
3676         svr4_current_sos_1.
3677         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3678         get_svr4_info.
3679         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3680         get_svr4_info.
3681         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3682         to get_svr4_info.
3683         (probes_table_remove_objfile_probes): Likewise.
3684         (register_solib_event_probe): Add info parameter.
3685         (solist_update_incremental): Pass info parameter down to
3686         svr4_read_so_list.
3687         (disable_probes_interface): Add info parameter.
3688         (svr4_handle_solib_event): Pass current_program_space to
3689         get_svr4_info.  Adjust disable_probes_interface cleanup.
3690         (svr4_create_probe_breakpoints): Add info parameter, pass it
3691         down to register_solib_event_probe.
3692         (svr4_create_solib_event_breakpoints): Add info parameter,
3693         pass it down to svr4_create_probe_breakpoints.
3694         (enable_break): Pass info down to
3695         svr4_create_solib_event_breakpoints.
3696         (svr4_solib_create_inferior_hook): Pass current_program_space to
3697         get_svr4_info.
3698         (svr4_clear_solib): Likewise.
3699
3700 2019-04-22  Pedro Alves  <palves@redhat.com>
3701
3702         * solib-svr4.c (svr4_free_objfile_observer): New.
3703         (probe_and_action::objfile): New field.
3704         (probes_table_htab_remove_objfile_probes)
3705         (probes_table_remove_objfile_probes): New functions.
3706         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3707         in the new probe_and_action.  Don't store the probe in 'lookup'.
3708         (svr4_create_probe_breakpoints): Pass objfile to
3709         register_solib_event_probe.
3710         (_initialize_svr4_solib): Register a free_objfile observer.
3711
3712 2019-04-19  Tom Tromey  <tom@tromey.com>
3713
3714         * common/queue.h: Remove.
3715
3716 2019-04-19  Tom Tromey  <tom@tromey.com>
3717
3718         * event-loop.c: Don't include "common/queue.h".
3719
3720 2019-04-19  Tom Tromey  <tom@tromey.com>
3721
3722         * remote.c (remote_target): Use delete.
3723         * remote-notif.h: Include <list>, not "common/queue.h".
3724         (notif_client_p): Remove typedef.
3725         (remote_notif_state): Add constructor, destructor, initializer.
3726         <notif_queue>: Now a std::list.
3727         (remote_notif_state_xfree): Don't declare.
3728         * remote-notif.c (remote_notif_process, handle_notification)
3729         (remote_notif_state_allocate): Update.
3730         (~remote_notif_state): Rename from remote_notif_state_xfree.
3731
3732 2019-04-19  Tom Tromey  <tom@tromey.com>
3733
3734         * symfile.c (reread_symbols): Update.
3735         * objfiles.c (objfile_register_static_link)
3736         (objfile_lookup_static_link): Update
3737         (~objfile) Don't delete static_links.
3738         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3739
3740 2019-04-19  Tom Tromey  <tom@tromey.com>
3741
3742         * type-stack.h (struct type_stack) <insert>: Constify string.
3743         * type-stack.c (type_stack::insert): Constify string.
3744         * gdbtypes.h (lookup_template_type): Update.
3745         (address_space_name_to_int): Update.
3746         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3747         const.
3748         (lookup_template_type): Make name const.
3749         * c-exp.y: Update rules.
3750         (lex_one_token, classify_name, classify_inner_name)
3751         (c_print_token): Update.
3752         * p-exp.y: Update rules.
3753         (yylex): Update.
3754         * f-exp.y: Update rules.
3755         (yylex): Update.
3756         * d-exp.y: Update rules.
3757         (lex_one_token, classify_name, classify_inner_name): Update.
3758         * parse.c (write_dollar_variable, copy_name): Return std::string.
3759         * parser-defs.h (copy_name): Change return type.
3760         * m2-exp.y: Update rules.
3761         (yylex): Update.
3762         * go-exp.y (lex_one_token): Update.
3763         Update rules.
3764         (classify_unsafe_function, classify_packaged_name)
3765         (classify_name, yylex): Update.
3766
3767 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3768
3769         * configure.ac: add --enable-source-highlight switch.
3770         * configure: Regenerate.
3771         * top.c (print_gdb_version): plumb --enable-source-highlight
3772         status to "show configuration".
3773
3774 2019-04-19  Tom Tromey  <tromey@adacore.com>
3775
3776         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3777         Check ADA_TYPE_P.
3778         (empty_record, ada_template_to_fixed_record_type_1)
3779         (template_to_static_fixed_type)
3780         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3781         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3782         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3783         macros.
3784
3785 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3786
3787         PR symtab/24423:
3788         * source.c (print_source_lines_base): Advance "iter" when a
3789         control character is seen.
3790
3791 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3792
3793         * inferior.h (struct infcall_suspend_state_deleter):
3794         Catch exception in destructor to avoid crash.
3795
3796 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3797
3798         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3799         close to the add_com "shell".
3800
3801 2019-04-18  Tom Tromey  <tromey@adacore.com>
3802
3803         * process-stratum-target.h (class process_stratum_target)
3804         <stratum>: Add "final".
3805
3806 2019-04-17  Tom Tromey  <tromey@adacore.com>
3807
3808         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3809         against nullptr before use.
3810
3811 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3812
3813         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3814
3815 2019-04-17  Jim Wilson  <jimw@sifive.com>
3816             Andrew Burgess  <andrew.burgess@embecosm.com>
3817
3818         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3819         code read might fail, assume 4-byte breakpoint in that case.
3820
3821 2019-04-15  Leszek Swirski  <leszeks@google.com>
3822
3823         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3824         rather than a hand-rolled POD check when checking for forced MEMORY
3825         classification.
3826
3827 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3828
3829         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3830         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3831         function.
3832         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3833         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3834         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3835         declaration.
3836
3837 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3838
3839         * aarch64-linux-nat.c
3840         (aarch64_linux_nat_target::thread_architecture): Add override.
3841         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3842         each VQ.
3843
3844 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3845
3846         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3847
3848 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3849
3850         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3851         target types of size 96-bits, add some additional comments, and
3852         check that the builtin type we found was the correct size.
3853
3854 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3855
3856         * utils.c (prompt_for_continue): Don't restore the styling at the
3857         end, as applied_style has the wrong value.  This fixes styling in
3858         long lists of file names that are interrupted by the "Continue?"
3859         prompt.
3860
3861 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3862
3863         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3864         * c-lang.c (c_language_defn): Likewise.
3865         (cplus_language_defn): Likewise.
3866         (asm_language_defn): Likewise.
3867         (minimal_language_defn): Likewise.
3868         * d-lang.c (d_language_defn): Likewise.
3869         * f-lang.c (f_language_defn): Likewise.
3870         * go-lang.c (go_language_defn): Likewise.
3871         * language.c (unknown_language_defn): Likewise.
3872         (auto_language_defn): Likewise.
3873         * language.h (struct language_defn): Remove la_magic field.
3874         (LANG_MAGIC): Delete.
3875         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3876         * objc-lang.c (objc_language_defn): Likewise.
3877         * opencl-lang.c (opencl_language_defn): Likewise.
3878         * p-lang.c (pascal_language_defn): Likewise.
3879         * rust-lang.c (rust_language_defn): Likewise.
3880
3881 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3882
3883         * riscv-tdep.c (riscv_type_align): New function.
3884         (riscv_type_alignment): Delete.
3885         (riscv_arg_location): Use 'type_align'.
3886         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3887
3888 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3889
3890         * gdbtypes.c (type_align): A struct with no non-static fields also
3891         has alignment of 1.
3892
3893 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3894
3895         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3896         component to 0.
3897         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3898         member.
3899         (riscv_struct_info::analyse): New implementation using new
3900         analyse_inner member function.
3901         (riscv_struct_info::field_offset): New member function.
3902         (riscv_struct_info::m_offsets): New member variable.
3903         (riscv_struct_info::analyse_inner): New private member function,
3904         takes the old implementation of riscv_struct_info::analyse but
3905         extended to track field offsets.
3906         (riscv_call_arg_struct): Update the struct folding special cases
3907         to handle cases where empty C++ structs, which are non-zero
3908         length, are found.
3909         (riscv_arg_location): Initialise the length of each location, a
3910         non-zero length now indicates the location is in use.
3911         (riscv_push_dummy_call): Allow for the first location having a
3912         non-zero offset when setting up arguments.
3913         (riscv_return_value): Likewise, but for return values.
3914
3915 2019-04-11  Tom Tromey  <tromey@adacore.com>
3916
3917         * utils.c (internal_vproblem): Make "msg" const.
3918
3919 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3920
3921         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3922         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3923         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3924         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3925
3926 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3927
3928         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3929         function.
3930         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3931         of amd64_collect_native_gregset.
3932         (amd64_linux_nat_target::store_registers): Likewise.
3933
3934 2019-04-10  Tom Tromey  <tom@tromey.com>
3935
3936         * symtab.c (lookup_global_symbol_from_objfile)
3937         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3938         * objfiles.h (class separate_debug_iterator): New.
3939         (class separate_debug_range): New.
3940         (struct objfile) <separate_debug_objfiles>: New method.
3941         (objfile_separate_debug_iterate): Don't declare.
3942         * objfiles.c (separate_debug_iterator::operator++): Rename from
3943         objfile_separate_debug_iterate.
3944         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3945         iterator.
3946         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3947         iterator.
3948
3949 2019-04-10  Tom Tromey  <tom@tromey.com>
3950
3951         * symfile.c (reread_symbols): Remove old comment.
3952         * objfiles.c (free_all_objfiles): Fix a typo.
3953
3954 2019-04-10  Tom Tromey  <tom@tromey.com>
3955
3956         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3957         * minsyms.c (lookup_minimal_symbol): Use foreach.
3958         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3959         (lookup_minimal_symbol_solib_trampoline): Likewise.
3960         * symfile.c (reread_symbols): Use foreach.
3961
3962 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3963             Tom Tromey  <tromey@adacore.com>
3964
3965         PR rust/24414:
3966         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3967         (rust_lex_int_test): Change "value" to be LONGEST.
3968         (rust_lex_tests): Add test for long integer literal.
3969
3970 2019-04-09  Tom Tromey  <tromey@adacore.com>
3971
3972         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3973         to bool.
3974         (extended_remote_target::attach): Update.
3975         (remote_target::remote_notice_new_inferior): Update.
3976         (remote_target::add_current_inferior_and_thread): Update.
3977         * inferior.c (exit_inferior_1): Use "false".
3978         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3979
3980 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3981
3982         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3983         the "start" command.
3984
3985 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3986
3987         * python/py-inferior.c (infpy_thread_from_thread_handle):
3988         Adjust comments to reflect renaming of thread_from_thread_handle
3989         to thread_from_handle.  Adjust keywords.  Fix type error message.
3990         (inferior_object_methods): Add thread_from_handle.  Retain
3991         thread_from_thread_handle, but mark it as deprecated.
3992
3993 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3994
3995         * gdbthread.h (find_thread_by_handle): Revise declaration.
3996         * thread.c (find_thread_by_handle): Likewise.  Adjust
3997         implementation too.
3998         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3999         support for buffer objects as handles.
4000
4001 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4002
4003         * python/py-infthread.c (thpy_thread_handle): New function.
4004         (thread_object_methods): Register thpy_thread_handle.
4005
4006 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4007
4008         * gdbthread.h (thread_to_thread_handle): Declare.
4009         * thread.c (gdbtypes.h): Include.
4010         (thread_to_thread_handle): New function.
4011
4012         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4013         (target_thread_info_to_thread_handle): Declare.
4014         * target.c (target_thread_info_to_thread_handle): New function.
4015         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4016         * target-delegates.c: Regenerate.
4017
4018         * linux-thread-db.c (class thread_db_target): Add method
4019         thread_info_to_thread_handle.
4020         (thread_db_target::thread_info_to_thread_handle): Define.
4021         * remote.c (class remote_target): Add new method
4022         thread_info_to_thread_handle.
4023         (remote_target::thread_info_to_thread_handle): Define.
4024
4025 2019-04-08  Pedro Alves  <palves@redhat.com>
4026
4027         * common/common-exceptions.c (throw_exception): Don't create
4028         named object to throw; throw directly.
4029         (throw_it): Likewise.  Don't initialize gdb_exception::message
4030         here, with new; pass FMT and AP to the ctor instead.
4031         * common/common-exceptions.h: Include <string>.
4032         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4033         const char *, va_list)): New ctor.  Use std::make_shared.
4034         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4035         errors)): Delete.
4036         (gdb_exception_error::gdb_exception_error(enum errors, const char
4037         *, va_list)): New.
4038         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4039         Add assertion.
4040         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4041         errors)): Delete.
4042         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4043         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4044         Add assertion.
4045
4046 2019-04-08  Tom Tromey  <tom@tromey.com>
4047
4048         * valops.c (value_rtti_indirect_type): Replace throw_exception
4049         with throw.
4050         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4051         with throw.
4052         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4053         throw.
4054         * target.c (target_translate_tls_address): Replace throw_exception
4055         with throw.
4056         * stack.c (frame_apply_command_count): Replace throw_exception
4057         with throw.
4058         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4059         throw.
4060         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4061         with throw.
4062         * rs6000-tdep.c (rs6000_frame_cache)
4063         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4064         * remote.c: Replace throw_exception with throw.
4065         * record-full.c (record_full_message, record_full_wait_1)
4066         (record_full_restore): Replace throw_exception with throw.
4067         * record-btrace.c:
4068         (get_thread_current_frame_id, record_btrace_start_replaying)
4069         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4070         (cmd_record_btrace_start): Replace throw_exception with throw.
4071         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4072         throw.
4073         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4074         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4075         * linespec.c:
4076         (find_linespec_symbols): Replace throw_exception with throw.
4077         * infrun.c (displaced_step_prepare, resume): Replace
4078         throw_exception with throw.
4079         * infcmd.c (post_create_inferior): Replace throw_exception with
4080         throw.
4081         * inf-loop.c (inferior_event_handler): Replace throw_exception
4082         with throw.
4083         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4084         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4085         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4086         (get_prev_frame_always, get_frame_pc_if_available)
4087         (get_frame_address_in_block_if_available, get_frame_language):
4088         Replace throw_exception with throw.
4089         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4090         throw_exception with throw.
4091         * eval.c (fetch_subexp_value, evaluate_var_value)
4092         (evaluate_funcall, evaluate_subexp_standard): Replace
4093         throw_exception with throw.
4094         * dwarf2loc.c (call_site_find_chain)
4095         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4096         Replace throw_exception with throw.
4097         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4098         with throw.
4099         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4100         throw.
4101         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4102         * completer.c (complete_line_internal): Replace throw_exception
4103         with throw.
4104         * compile/compile-object-run.c (compile_object_run): Replace
4105         throw_exception with throw.
4106         * cli/cli-script.c (process_next_line): Replace throw_exception
4107         with throw.
4108         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4109         (btrace_enable, btrace_maint_update_pt_packets): Replace
4110         throw_exception with throw.
4111         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4112         throw_exception with throw.
4113         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4114         throw_exception with throw.
4115         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4116         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4117         * aarch64-tdep.c (aarch64_make_prologue_cache)
4118         (aarch64_make_stub_cache): Replace throw_exception with throw.
4119
4120 2019-04-08  Tom Tromey  <tom@tromey.com>
4121
4122         * common/common-exceptions.c (throw_exception): Rename from
4123         throw_exception_cxx.  Remove old copy.  Make argument const.
4124         (throw_it): Create and throw exception objects directly.
4125         * common/common-exceptions.h (throw_exception): Make argument
4126         const.
4127         (struct gdb_exception_error): Add constructor.
4128         (struct gdb_exception_quit): Add constructor.
4129
4130 2019-04-08  Tom Tromey  <tom@tromey.com>
4131
4132         * common/common-exceptions.h (exception_rethrow): Don't declare.
4133         (TRY_SJLJ): Update comment.
4134         (TRY, CATCH, END_CATCH): Remove.
4135         * common/common-exceptions.c (exception_rethrow): Remove.
4136
4137 2019-04-08  Tom Tromey  <tom@tromey.com>
4138
4139         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4140         Remove.
4141         (gdb_exception_error): Rename from
4142         gdb_exception_RETURN_MASK_ERROR.
4143         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4144         (gdb_quit_bad_alloc): Update.
4145         * aarch64-tdep.c: Update.
4146         * ada-lang.c: Update.
4147         * ada-typeprint.c: Update.
4148         * ada-valprint.c: Update.
4149         * amd64-tdep.c: Update.
4150         * arch-utils.c: Update.
4151         * break-catch-throw.c: Update.
4152         * breakpoint.c: Update.
4153         * btrace.c: Update.
4154         * c-varobj.c: Update.
4155         * cli/cli-cmds.c: Update.
4156         * cli/cli-interp.c: Update.
4157         * cli/cli-script.c: Update.
4158         * common/common-exceptions.c: Update.
4159         * common/new-op.c: Update.
4160         * common/selftest.c: Update.
4161         * compile/compile-c-symbols.c: Update.
4162         * compile/compile-cplus-symbols.c: Update.
4163         * compile/compile-object-load.c: Update.
4164         * compile/compile-object-run.c: Update.
4165         * completer.c: Update.
4166         * corelow.c: Update.
4167         * cp-abi.c: Update.
4168         * cp-support.c: Update.
4169         * cp-valprint.c: Update.
4170         * darwin-nat.c: Update.
4171         * disasm-selftests.c: Update.
4172         * dtrace-probe.c: Update.
4173         * dwarf-index-cache.c: Update.
4174         * dwarf-index-write.c: Update.
4175         * dwarf2-frame-tailcall.c: Update.
4176         * dwarf2-frame.c: Update.
4177         * dwarf2loc.c: Update.
4178         * dwarf2read.c: Update.
4179         * eval.c: Update.
4180         * event-loop.c: Update.
4181         * event-top.c: Update.
4182         * exec.c: Update.
4183         * f-valprint.c: Update.
4184         * fbsd-tdep.c: Update.
4185         * frame-unwind.c: Update.
4186         * frame.c: Update.
4187         * gdbtypes.c: Update.
4188         * gnu-v3-abi.c: Update.
4189         * guile/guile-internal.h: Update.
4190         * guile/scm-block.c: Update.
4191         * guile/scm-breakpoint.c: Update.
4192         * guile/scm-cmd.c: Update.
4193         * guile/scm-disasm.c: Update.
4194         * guile/scm-frame.c: Update.
4195         * guile/scm-lazy-string.c: Update.
4196         * guile/scm-math.c: Update.
4197         * guile/scm-param.c: Update.
4198         * guile/scm-ports.c: Update.
4199         * guile/scm-pretty-print.c: Update.
4200         * guile/scm-symbol.c: Update.
4201         * guile/scm-symtab.c: Update.
4202         * guile/scm-type.c: Update.
4203         * guile/scm-value.c: Update.
4204         * i386-linux-tdep.c: Update.
4205         * i386-tdep.c: Update.
4206         * inf-loop.c: Update.
4207         * infcall.c: Update.
4208         * infcmd.c: Update.
4209         * infrun.c: Update.
4210         * jit.c: Update.
4211         * language.c: Update.
4212         * linespec.c: Update.
4213         * linux-fork.c: Update.
4214         * linux-nat.c: Update.
4215         * linux-tdep.c: Update.
4216         * linux-thread-db.c: Update.
4217         * main.c: Update.
4218         * mi/mi-cmd-break.c: Update.
4219         * mi/mi-cmd-stack.c: Update.
4220         * mi/mi-interp.c: Update.
4221         * mi/mi-main.c: Update.
4222         * objc-lang.c: Update.
4223         * p-valprint.c: Update.
4224         * parse.c: Update.
4225         * ppc-linux-tdep.c: Update.
4226         * printcmd.c: Update.
4227         * python/py-arch.c: Update.
4228         * python/py-breakpoint.c: Update.
4229         * python/py-cmd.c: Update.
4230         * python/py-finishbreakpoint.c: Update.
4231         * python/py-frame.c: Update.
4232         * python/py-framefilter.c: Update.
4233         * python/py-gdb-readline.c: Update.
4234         * python/py-inferior.c: Update.
4235         * python/py-infthread.c: Update.
4236         * python/py-lazy-string.c: Update.
4237         * python/py-linetable.c: Update.
4238         * python/py-objfile.c: Update.
4239         * python/py-param.c: Update.
4240         * python/py-prettyprint.c: Update.
4241         * python/py-progspace.c: Update.
4242         * python/py-record-btrace.c: Update.
4243         * python/py-record.c: Update.
4244         * python/py-symbol.c: Update.
4245         * python/py-type.c: Update.
4246         * python/py-unwind.c: Update.
4247         * python/py-utils.c: Update.
4248         * python/py-value.c: Update.
4249         * python/python.c: Update.
4250         * record-btrace.c: Update.
4251         * record-full.c: Update.
4252         * remote-fileio.c: Update.
4253         * remote.c: Update.
4254         * riscv-tdep.c: Update.
4255         * rs6000-aix-tdep.c: Update.
4256         * rs6000-tdep.c: Update.
4257         * rust-exp.y: Update.
4258         * rust-lang.c: Update.
4259         * s390-tdep.c: Update.
4260         * selftest-arch.c: Update.
4261         * solib-dsbt.c: Update.
4262         * solib-frv.c: Update.
4263         * solib-spu.c: Update.
4264         * solib-svr4.c: Update.
4265         * solib.c: Update.
4266         * sparc64-linux-tdep.c: Update.
4267         * stack.c: Update.
4268         * symfile-mem.c: Update.
4269         * symmisc.c: Update.
4270         * target.c: Update.
4271         * thread.c: Update.
4272         * top.c: Update.
4273         * tracefile-tfile.c: Update.
4274         * tui/tui.c: Update.
4275         * typeprint.c: Update.
4276         * unittests/cli-utils-selftests.c: Update.
4277         * unittests/parse-connection-spec-selftests.c: Update.
4278         * valops.c: Update.
4279         * valprint.c: Update.
4280         * value.c: Update.
4281         * varobj.c: Update.
4282         * windows-nat.c: Update.
4283         * x86-linux-nat.c: Update.
4284         * xml-support.c: Update.
4285
4286 2019-04-08  Tom Tromey  <tom@tromey.com>
4287
4288         * xml-support.c: Use C++ exception handling.
4289         * x86-linux-nat.c: Use C++ exception handling.
4290         * windows-nat.c: Use C++ exception handling.
4291         * varobj.c: Use C++ exception handling.
4292         * value.c: Use C++ exception handling.
4293         * valprint.c: Use C++ exception handling.
4294         * valops.c: Use C++ exception handling.
4295         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4296         handling.
4297         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4298         * typeprint.c: Use C++ exception handling.
4299         * tui/tui.c: Use C++ exception handling.
4300         * tracefile-tfile.c: Use C++ exception handling.
4301         * top.c: Use C++ exception handling.
4302         * thread.c: Use C++ exception handling.
4303         * target.c: Use C++ exception handling.
4304         * symmisc.c: Use C++ exception handling.
4305         * symfile-mem.c: Use C++ exception handling.
4306         * stack.c: Use C++ exception handling.
4307         * sparc64-linux-tdep.c: Use C++ exception handling.
4308         * solib.c: Use C++ exception handling.
4309         * solib-svr4.c: Use C++ exception handling.
4310         * solib-spu.c: Use C++ exception handling.
4311         * solib-frv.c: Use C++ exception handling.
4312         * solib-dsbt.c: Use C++ exception handling.
4313         * selftest-arch.c: Use C++ exception handling.
4314         * s390-tdep.c: Use C++ exception handling.
4315         * rust-lang.c: Use C++ exception handling.
4316         * rust-exp.y: Use C++ exception handling.
4317         * rs6000-tdep.c: Use C++ exception handling.
4318         * rs6000-aix-tdep.c: Use C++ exception handling.
4319         * riscv-tdep.c: Use C++ exception handling.
4320         * remote.c: Use C++ exception handling.
4321         * remote-fileio.c: Use C++ exception handling.
4322         * record-full.c: Use C++ exception handling.
4323         * record-btrace.c: Use C++ exception handling.
4324         * python/python.c: Use C++ exception handling.
4325         * python/py-value.c: Use C++ exception handling.
4326         * python/py-utils.c: Use C++ exception handling.
4327         * python/py-unwind.c: Use C++ exception handling.
4328         * python/py-type.c: Use C++ exception handling.
4329         * python/py-symbol.c: Use C++ exception handling.
4330         * python/py-record.c: Use C++ exception handling.
4331         * python/py-record-btrace.c: Use C++ exception handling.
4332         * python/py-progspace.c: Use C++ exception handling.
4333         * python/py-prettyprint.c: Use C++ exception handling.
4334         * python/py-param.c: Use C++ exception handling.
4335         * python/py-objfile.c: Use C++ exception handling.
4336         * python/py-linetable.c: Use C++ exception handling.
4337         * python/py-lazy-string.c: Use C++ exception handling.
4338         * python/py-infthread.c: Use C++ exception handling.
4339         * python/py-inferior.c: Use C++ exception handling.
4340         * python/py-gdb-readline.c: Use C++ exception handling.
4341         * python/py-framefilter.c: Use C++ exception handling.
4342         * python/py-frame.c: Use C++ exception handling.
4343         * python/py-finishbreakpoint.c: Use C++ exception handling.
4344         * python/py-cmd.c: Use C++ exception handling.
4345         * python/py-breakpoint.c: Use C++ exception handling.
4346         * python/py-arch.c: Use C++ exception handling.
4347         * printcmd.c: Use C++ exception handling.
4348         * ppc-linux-tdep.c: Use C++ exception handling.
4349         * parse.c: Use C++ exception handling.
4350         * p-valprint.c: Use C++ exception handling.
4351         * objc-lang.c: Use C++ exception handling.
4352         * mi/mi-main.c: Use C++ exception handling.
4353         * mi/mi-interp.c: Use C++ exception handling.
4354         * mi/mi-cmd-stack.c: Use C++ exception handling.
4355         * mi/mi-cmd-break.c: Use C++ exception handling.
4356         * main.c: Use C++ exception handling.
4357         * linux-thread-db.c: Use C++ exception handling.
4358         * linux-tdep.c: Use C++ exception handling.
4359         * linux-nat.c: Use C++ exception handling.
4360         * linux-fork.c: Use C++ exception handling.
4361         * linespec.c: Use C++ exception handling.
4362         * language.c: Use C++ exception handling.
4363         * jit.c: Use C++ exception handling.
4364         * infrun.c: Use C++ exception handling.
4365         * infcmd.c: Use C++ exception handling.
4366         * infcall.c: Use C++ exception handling.
4367         * inf-loop.c: Use C++ exception handling.
4368         * i386-tdep.c: Use C++ exception handling.
4369         * i386-linux-tdep.c: Use C++ exception handling.
4370         * guile/scm-value.c: Use C++ exception handling.
4371         * guile/scm-type.c: Use C++ exception handling.
4372         * guile/scm-symtab.c: Use C++ exception handling.
4373         * guile/scm-symbol.c: Use C++ exception handling.
4374         * guile/scm-pretty-print.c: Use C++ exception handling.
4375         * guile/scm-ports.c: Use C++ exception handling.
4376         * guile/scm-param.c: Use C++ exception handling.
4377         * guile/scm-math.c: Use C++ exception handling.
4378         * guile/scm-lazy-string.c: Use C++ exception handling.
4379         * guile/scm-frame.c: Use C++ exception handling.
4380         * guile/scm-disasm.c: Use C++ exception handling.
4381         * guile/scm-cmd.c: Use C++ exception handling.
4382         * guile/scm-breakpoint.c: Use C++ exception handling.
4383         * guile/scm-block.c: Use C++ exception handling.
4384         * guile/guile-internal.h: Use C++ exception handling.
4385         * gnu-v3-abi.c: Use C++ exception handling.
4386         * gdbtypes.c: Use C++ exception handling.
4387         * frame.c: Use C++ exception handling.
4388         * frame-unwind.c: Use C++ exception handling.
4389         * fbsd-tdep.c: Use C++ exception handling.
4390         * f-valprint.c: Use C++ exception handling.
4391         * exec.c: Use C++ exception handling.
4392         * event-top.c: Use C++ exception handling.
4393         * event-loop.c: Use C++ exception handling.
4394         * eval.c: Use C++ exception handling.
4395         * dwarf2read.c: Use C++ exception handling.
4396         * dwarf2loc.c: Use C++ exception handling.
4397         * dwarf2-frame.c: Use C++ exception handling.
4398         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4399         * dwarf-index-write.c: Use C++ exception handling.
4400         * dwarf-index-cache.c: Use C++ exception handling.
4401         * dtrace-probe.c: Use C++ exception handling.
4402         * disasm-selftests.c: Use C++ exception handling.
4403         * darwin-nat.c: Use C++ exception handling.
4404         * cp-valprint.c: Use C++ exception handling.
4405         * cp-support.c: Use C++ exception handling.
4406         * cp-abi.c: Use C++ exception handling.
4407         * corelow.c: Use C++ exception handling.
4408         * completer.c: Use C++ exception handling.
4409         * compile/compile-object-run.c: Use C++ exception handling.
4410         * compile/compile-object-load.c: Use C++ exception handling.
4411         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4412         * compile/compile-c-symbols.c: Use C++ exception handling.
4413         * common/selftest.c: Use C++ exception handling.
4414         * common/new-op.c: Use C++ exception handling.
4415         * cli/cli-script.c: Use C++ exception handling.
4416         * cli/cli-interp.c: Use C++ exception handling.
4417         * cli/cli-cmds.c: Use C++ exception handling.
4418         * c-varobj.c: Use C++ exception handling.
4419         * btrace.c: Use C++ exception handling.
4420         * breakpoint.c: Use C++ exception handling.
4421         * break-catch-throw.c: Use C++ exception handling.
4422         * arch-utils.c: Use C++ exception handling.
4423         * amd64-tdep.c: Use C++ exception handling.
4424         * ada-valprint.c: Use C++ exception handling.
4425         * ada-typeprint.c: Use C++ exception handling.
4426         * ada-lang.c: Use C++ exception handling.
4427         * aarch64-tdep.c: Use C++ exception handling.
4428
4429 2019-04-08  Tom Tromey  <tom@tromey.com>
4430
4431         * xml-support.c (gdb_xml_parser::parse): Update.
4432         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4433         * value.c (show_convenience): Update.
4434         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4435         (test_parse_flags_qcs): Update.
4436         * thread.c (thr_try_catch_cmd): Update.
4437         * target.c (target_translate_tls_address): Update.
4438         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4439         (info_frame_command_core, frame_apply_command_count): Update.
4440         * rust-exp.y (rust_lex_exception_test): Update.
4441         * riscv-tdep.c (riscv_print_one_register_info): Update.
4442         * remote.c (remote_target::enable_btrace): Update.
4443         * record-btrace.c (record_btrace_enable_warn): Update.
4444         * python/py-utils.c (gdbpy_convert_exception): Update.
4445         * printcmd.c (do_one_display, print_variable_and_value): Update.
4446         * mi/mi-main.c (mi_print_exception): Update.
4447         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4448         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4449         * linux-nat.c (linux_nat_target::attach): Update.
4450         * linux-fork.c (class scoped_switch_fork_info): Update.
4451         * infrun.c (displaced_step_prepare): Update.
4452         * infcall.c (call_function_by_hand_dummy): Update.
4453         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4454         * gnu-v3-abi.c (print_one_vtable): Update.
4455         * frame.c (get_prev_frame_always): Update.
4456         * f-valprint.c (info_common_command_for_block): Update.
4457         * exec.c (try_open_exec_file): Update.
4458         * exceptions.c (print_exception, exception_print)
4459         (exception_fprintf, exception_print_same): Update.
4460         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4461         * dwarf-index-cache.c (index_cache::store)
4462         (index_cache::lookup_gdb_index): Update.
4463         * darwin-nat.c (maybe_cache_shell): Update.
4464         * cp-valprint.c (cp_print_value_fields): Update.
4465         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4466         (gcc_cplus_symbol_address): Update.
4467         * compile/compile-c-symbols.c (gcc_convert_symbol)
4468         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4469         * common/selftest.c: Update.
4470         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4471         a std::string.
4472         (exception_try_scope_entry, exception_try_scope_exit): Don't
4473         declare.
4474         (struct exception_try_scope): Remove.
4475         (TRY): Don't use exception_try_scope.
4476         (struct gdb_exception): Add constructor, operator=.
4477         <what>: New method.
4478         (struct gdb_exception_RETURN_MASK_ALL)
4479         (struct gdb_exception_RETURN_MASK_ERROR)
4480         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4481         (struct gdb_quit_bad_alloc): Update.
4482         * common/common-exceptions.c (exception_none): Change
4483         initializer.
4484         (struct catcher) <state, exception>: Initialize inline.
4485         <prev>: Remove member.
4486         (current_catcher): Remove.
4487         (catchers): New global.
4488         (exceptions_state_mc_init): Simplify.
4489         (catcher_pop): Remove.
4490         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4491         (try_scope_depth, exception_try_scope_entry)
4492         (exception_try_scope_exit): Remove.
4493         (throw_exception_sjlj): Update.
4494         (exception_messages, exception_messages_size): Remove.
4495         (throw_it): Simplify.
4496         (gdb_exception_sliced_copy): Remove.
4497         (throw_exception_cxx): Update.
4498         * cli/cli-script.c (script_from_file): Update.
4499         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4500         Update.
4501         * ada-valprint.c (ada_val_print): Update.
4502         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4503         (create_excep_cond_exprs): Update.
4504
4505 2019-04-08  Tom Tromey  <tom@tromey.com>
4506
4507         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4508         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4509         (TRY, CATCH, END_CATCH): Remove some definitions.
4510         * common/common-exceptions.c: Don't use GDB_XCPT.
4511         (catcher_list_size): Remove.
4512         (throw_exception, throw_it): Simplify.
4513
4514 2019-04-05  Tom Tromey  <tom@tromey.com>
4515
4516         Revert the header-sorting patch.
4517         * ft32-tdep.c: Revert.
4518         * frv-tdep.c: Revert.
4519         * frv-linux-tdep.c: Revert.
4520         * frame.c: Revert.
4521         * frame-unwind.c: Revert.
4522         * frame-base.c: Revert.
4523         * fork-child.c: Revert.
4524         * findvar.c: Revert.
4525         * findcmd.c: Revert.
4526         * filesystem.c: Revert.
4527         * filename-seen-cache.h: Revert.
4528         * filename-seen-cache.c: Revert.
4529         * fbsd-tdep.c: Revert.
4530         * fbsd-nat.h: Revert.
4531         * fbsd-nat.c: Revert.
4532         * f-valprint.c: Revert.
4533         * f-typeprint.c: Revert.
4534         * f-lang.c: Revert.
4535         * extension.h: Revert.
4536         * extension.c: Revert.
4537         * extension-priv.h: Revert.
4538         * expprint.c: Revert.
4539         * exec.h: Revert.
4540         * exec.c: Revert.
4541         * exceptions.c: Revert.
4542         * event-top.c: Revert.
4543         * event-loop.c: Revert.
4544         * eval.c: Revert.
4545         * elfread.c: Revert.
4546         * dwarf2read.h: Revert.
4547         * dwarf2read.c: Revert.
4548         * dwarf2loc.c: Revert.
4549         * dwarf2expr.h: Revert.
4550         * dwarf2expr.c: Revert.
4551         * dwarf2-frame.c: Revert.
4552         * dwarf2-frame-tailcall.c: Revert.
4553         * dwarf-index-write.h: Revert.
4554         * dwarf-index-write.c: Revert.
4555         * dwarf-index-common.c: Revert.
4556         * dwarf-index-cache.h: Revert.
4557         * dwarf-index-cache.c: Revert.
4558         * dummy-frame.c: Revert.
4559         * dtrace-probe.c: Revert.
4560         * disasm.h: Revert.
4561         * disasm.c: Revert.
4562         * disasm-selftests.c: Revert.
4563         * dictionary.c: Revert.
4564         * dicos-tdep.c: Revert.
4565         * demangle.c: Revert.
4566         * dcache.h: Revert.
4567         * dcache.c: Revert.
4568         * darwin-nat.h: Revert.
4569         * darwin-nat.c: Revert.
4570         * darwin-nat-info.c: Revert.
4571         * d-valprint.c: Revert.
4572         * d-namespace.c: Revert.
4573         * d-lang.c: Revert.
4574         * ctf.c: Revert.
4575         * csky-tdep.c: Revert.
4576         * csky-linux-tdep.c: Revert.
4577         * cris-tdep.c: Revert.
4578         * cris-linux-tdep.c: Revert.
4579         * cp-valprint.c: Revert.
4580         * cp-support.c: Revert.
4581         * cp-namespace.c: Revert.
4582         * cp-abi.c: Revert.
4583         * corelow.c: Revert.
4584         * corefile.c: Revert.
4585         * continuations.c: Revert.
4586         * completer.h: Revert.
4587         * completer.c: Revert.
4588         * complaints.c: Revert.
4589         * coffread.c: Revert.
4590         * coff-pe-read.c: Revert.
4591         * cli-out.h: Revert.
4592         * cli-out.c: Revert.
4593         * charset.c: Revert.
4594         * c-varobj.c: Revert.
4595         * c-valprint.c: Revert.
4596         * c-typeprint.c: Revert.
4597         * c-lang.c: Revert.
4598         * buildsym.c: Revert.
4599         * buildsym-legacy.c: Revert.
4600         * build-id.h: Revert.
4601         * build-id.c: Revert.
4602         * btrace.c: Revert.
4603         * bsd-uthread.c: Revert.
4604         * breakpoint.h: Revert.
4605         * breakpoint.c: Revert.
4606         * break-catch-throw.c: Revert.
4607         * break-catch-syscall.c: Revert.
4608         * break-catch-sig.c: Revert.
4609         * blockframe.c: Revert.
4610         * block.c: Revert.
4611         * bfin-tdep.c: Revert.
4612         * bfin-linux-tdep.c: Revert.
4613         * bfd-target.c: Revert.
4614         * bcache.c: Revert.
4615         * ax-general.c: Revert.
4616         * ax-gdb.h: Revert.
4617         * ax-gdb.c: Revert.
4618         * avr-tdep.c: Revert.
4619         * auxv.c: Revert.
4620         * auto-load.c: Revert.
4621         * arm-wince-tdep.c: Revert.
4622         * arm-tdep.c: Revert.
4623         * arm-symbian-tdep.c: Revert.
4624         * arm-pikeos-tdep.c: Revert.
4625         * arm-obsd-tdep.c: Revert.
4626         * arm-nbsd-tdep.c: Revert.
4627         * arm-nbsd-nat.c: Revert.
4628         * arm-linux-tdep.c: Revert.
4629         * arm-linux-nat.c: Revert.
4630         * arm-fbsd-tdep.c: Revert.
4631         * arm-fbsd-nat.c: Revert.
4632         * arm-bsd-tdep.c: Revert.
4633         * arch-utils.c: Revert.
4634         * arc-tdep.c: Revert.
4635         * arc-newlib-tdep.c: Revert.
4636         * annotate.h: Revert.
4637         * annotate.c: Revert.
4638         * amd64-windows-tdep.c: Revert.
4639         * amd64-windows-nat.c: Revert.
4640         * amd64-tdep.c: Revert.
4641         * amd64-sol2-tdep.c: Revert.
4642         * amd64-obsd-tdep.c: Revert.
4643         * amd64-obsd-nat.c: Revert.
4644         * amd64-nbsd-tdep.c: Revert.
4645         * amd64-nbsd-nat.c: Revert.
4646         * amd64-nat.c: Revert.
4647         * amd64-linux-tdep.c: Revert.
4648         * amd64-linux-nat.c: Revert.
4649         * amd64-fbsd-tdep.c: Revert.
4650         * amd64-fbsd-nat.c: Revert.
4651         * amd64-dicos-tdep.c: Revert.
4652         * amd64-darwin-tdep.c: Revert.
4653         * amd64-bsd-nat.c: Revert.
4654         * alpha-tdep.c: Revert.
4655         * alpha-obsd-tdep.c: Revert.
4656         * alpha-nbsd-tdep.c: Revert.
4657         * alpha-mdebug-tdep.c: Revert.
4658         * alpha-linux-tdep.c: Revert.
4659         * alpha-linux-nat.c: Revert.
4660         * alpha-bsd-tdep.c: Revert.
4661         * alpha-bsd-nat.c: Revert.
4662         * aix-thread.c: Revert.
4663         * agent.c: Revert.
4664         * addrmap.c: Revert.
4665         * ada-varobj.c: Revert.
4666         * ada-valprint.c: Revert.
4667         * ada-typeprint.c: Revert.
4668         * ada-tasks.c: Revert.
4669         * ada-lang.c: Revert.
4670         * aarch64-tdep.c: Revert.
4671         * aarch64-ravenscar-thread.c: Revert.
4672         * aarch64-newlib-tdep.c: Revert.
4673         * aarch64-linux-tdep.c: Revert.
4674         * aarch64-linux-nat.c: Revert.
4675         * aarch64-fbsd-tdep.c: Revert.
4676         * aarch64-fbsd-nat.c: Revert.
4677         * aarch32-linux-nat.c: Revert.
4678
4679 2019-04-05  Tom Tromey  <tom@tromey.com>
4680
4681         * ft32-tdep.c: Sort headers.
4682         * frv-tdep.c: Sort headers.
4683         * frv-linux-tdep.c: Sort headers.
4684         * frame.c: Sort headers.
4685         * frame-unwind.c: Sort headers.
4686         * frame-base.c: Sort headers.
4687         * fork-child.c: Sort headers.
4688         * findvar.c: Sort headers.
4689         * findcmd.c: Sort headers.
4690         * filesystem.c: Sort headers.
4691         * filename-seen-cache.h: Sort headers.
4692         * filename-seen-cache.c: Sort headers.
4693         * fbsd-tdep.c: Sort headers.
4694         * fbsd-nat.h: Sort headers.
4695         * fbsd-nat.c: Sort headers.
4696         * f-valprint.c: Sort headers.
4697         * f-typeprint.c: Sort headers.
4698         * f-lang.c: Sort headers.
4699         * extension.h: Sort headers.
4700         * extension.c: Sort headers.
4701         * extension-priv.h: Sort headers.
4702         * expprint.c: Sort headers.
4703         * exec.h: Sort headers.
4704         * exec.c: Sort headers.
4705         * exceptions.c: Sort headers.
4706         * event-top.c: Sort headers.
4707         * event-loop.c: Sort headers.
4708         * eval.c: Sort headers.
4709         * elfread.c: Sort headers.
4710         * dwarf2read.h: Sort headers.
4711         * dwarf2read.c: Sort headers.
4712         * dwarf2loc.c: Sort headers.
4713         * dwarf2expr.h: Sort headers.
4714         * dwarf2expr.c: Sort headers.
4715         * dwarf2-frame.c: Sort headers.
4716         * dwarf2-frame-tailcall.c: Sort headers.
4717         * dwarf-index-write.h: Sort headers.
4718         * dwarf-index-write.c: Sort headers.
4719         * dwarf-index-common.c: Sort headers.
4720         * dwarf-index-cache.h: Sort headers.
4721         * dwarf-index-cache.c: Sort headers.
4722         * dummy-frame.c: Sort headers.
4723         * dtrace-probe.c: Sort headers.
4724         * disasm.h: Sort headers.
4725         * disasm.c: Sort headers.
4726         * disasm-selftests.c: Sort headers.
4727         * dictionary.c: Sort headers.
4728         * dicos-tdep.c: Sort headers.
4729         * demangle.c: Sort headers.
4730         * dcache.h: Sort headers.
4731         * dcache.c: Sort headers.
4732         * darwin-nat.h: Sort headers.
4733         * darwin-nat.c: Sort headers.
4734         * darwin-nat-info.c: Sort headers.
4735         * d-valprint.c: Sort headers.
4736         * d-namespace.c: Sort headers.
4737         * d-lang.c: Sort headers.
4738         * ctf.c: Sort headers.
4739         * csky-tdep.c: Sort headers.
4740         * csky-linux-tdep.c: Sort headers.
4741         * cris-tdep.c: Sort headers.
4742         * cris-linux-tdep.c: Sort headers.
4743         * cp-valprint.c: Sort headers.
4744         * cp-support.c: Sort headers.
4745         * cp-namespace.c: Sort headers.
4746         * cp-abi.c: Sort headers.
4747         * corelow.c: Sort headers.
4748         * corefile.c: Sort headers.
4749         * continuations.c: Sort headers.
4750         * completer.h: Sort headers.
4751         * completer.c: Sort headers.
4752         * complaints.c: Sort headers.
4753         * coffread.c: Sort headers.
4754         * coff-pe-read.c: Sort headers.
4755         * cli-out.h: Sort headers.
4756         * cli-out.c: Sort headers.
4757         * charset.c: Sort headers.
4758         * c-varobj.c: Sort headers.
4759         * c-valprint.c: Sort headers.
4760         * c-typeprint.c: Sort headers.
4761         * c-lang.c: Sort headers.
4762         * buildsym.c: Sort headers.
4763         * buildsym-legacy.c: Sort headers.
4764         * build-id.h: Sort headers.
4765         * build-id.c: Sort headers.
4766         * btrace.c: Sort headers.
4767         * bsd-uthread.c: Sort headers.
4768         * breakpoint.h: Sort headers.
4769         * breakpoint.c: Sort headers.
4770         * break-catch-throw.c: Sort headers.
4771         * break-catch-syscall.c: Sort headers.
4772         * break-catch-sig.c: Sort headers.
4773         * blockframe.c: Sort headers.
4774         * block.c: Sort headers.
4775         * bfin-tdep.c: Sort headers.
4776         * bfin-linux-tdep.c: Sort headers.
4777         * bfd-target.c: Sort headers.
4778         * bcache.c: Sort headers.
4779         * ax-general.c: Sort headers.
4780         * ax-gdb.h: Sort headers.
4781         * ax-gdb.c: Sort headers.
4782         * avr-tdep.c: Sort headers.
4783         * auxv.c: Sort headers.
4784         * auto-load.c: Sort headers.
4785         * arm-wince-tdep.c: Sort headers.
4786         * arm-tdep.c: Sort headers.
4787         * arm-symbian-tdep.c: Sort headers.
4788         * arm-pikeos-tdep.c: Sort headers.
4789         * arm-obsd-tdep.c: Sort headers.
4790         * arm-nbsd-tdep.c: Sort headers.
4791         * arm-nbsd-nat.c: Sort headers.
4792         * arm-linux-tdep.c: Sort headers.
4793         * arm-linux-nat.c: Sort headers.
4794         * arm-fbsd-tdep.c: Sort headers.
4795         * arm-fbsd-nat.c: Sort headers.
4796         * arm-bsd-tdep.c: Sort headers.
4797         * arch-utils.c: Sort headers.
4798         * arc-tdep.c: Sort headers.
4799         * arc-newlib-tdep.c: Sort headers.
4800         * annotate.h: Sort headers.
4801         * annotate.c: Sort headers.
4802         * amd64-windows-tdep.c: Sort headers.
4803         * amd64-windows-nat.c: Sort headers.
4804         * amd64-tdep.c: Sort headers.
4805         * amd64-sol2-tdep.c: Sort headers.
4806         * amd64-obsd-tdep.c: Sort headers.
4807         * amd64-obsd-nat.c: Sort headers.
4808         * amd64-nbsd-tdep.c: Sort headers.
4809         * amd64-nbsd-nat.c: Sort headers.
4810         * amd64-nat.c: Sort headers.
4811         * amd64-linux-tdep.c: Sort headers.
4812         * amd64-linux-nat.c: Sort headers.
4813         * amd64-fbsd-tdep.c: Sort headers.
4814         * amd64-fbsd-nat.c: Sort headers.
4815         * amd64-dicos-tdep.c: Sort headers.
4816         * amd64-darwin-tdep.c: Sort headers.
4817         * amd64-bsd-nat.c: Sort headers.
4818         * alpha-tdep.c: Sort headers.
4819         * alpha-obsd-tdep.c: Sort headers.
4820         * alpha-nbsd-tdep.c: Sort headers.
4821         * alpha-mdebug-tdep.c: Sort headers.
4822         * alpha-linux-tdep.c: Sort headers.
4823         * alpha-linux-nat.c: Sort headers.
4824         * alpha-bsd-tdep.c: Sort headers.
4825         * alpha-bsd-nat.c: Sort headers.
4826         * aix-thread.c: Sort headers.
4827         * agent.c: Sort headers.
4828         * addrmap.c: Sort headers.
4829         * ada-varobj.c: Sort headers.
4830         * ada-valprint.c: Sort headers.
4831         * ada-typeprint.c: Sort headers.
4832         * ada-tasks.c: Sort headers.
4833         * ada-lang.c: Sort headers.
4834         * aarch64-tdep.c: Sort headers.
4835         * aarch64-ravenscar-thread.c: Sort headers.
4836         * aarch64-newlib-tdep.c: Sort headers.
4837         * aarch64-linux-tdep.c: Sort headers.
4838         * aarch64-linux-nat.c: Sort headers.
4839         * aarch64-fbsd-tdep.c: Sort headers.
4840         * aarch64-fbsd-nat.c: Sort headers.
4841         * aarch32-linux-nat.c: Sort headers.
4842
4843 2019-04-04  Tom Tromey  <tom@tromey.com>
4844
4845         * varobj.c (varobj_create): Update.
4846         * rust-exp.y (struct rust_parser) <update_innermost_block,
4847         lookup_symbol>: New methods.
4848         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4849         Rename.
4850         (rust_parser::rust_lookup_type)
4851         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4852         * printcmd.c (display_command, do_one_display): Update.
4853         * parser-defs.h (struct parser_state) <parser_state>: Add
4854         "tracker" parameter.
4855         (block_tracker): New member.
4856         (class innermost_block_tracker) <innermost_block_tracker>: Add
4857         "types" parameter.
4858         <reset>: Remove method.
4859         (innermost_block): Don't declare.
4860         (null_post_parser): Update.
4861         * parse.c (innermost_block): Remove global.
4862         (write_dollar_variable): Update.
4863         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4864         Remove "tracker_types" parameter.
4865         (parse_expression): Add "tracker" parameter.
4866         (parse_expression_for_completion): Update.
4867         (null_post_parser): Add "tracker" parameter.
4868         * p-exp.y: Update rules.
4869         * m2-exp.y: Update rules.
4870         * language.h (struct language_defn) <la_post_parser>: Add
4871         "tracker" parameter.
4872         * go-exp.y: Update rules.
4873         * f-exp.y: Update rules.
4874         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4875         parameter.
4876         * d-exp.y: Update rules.
4877         * c-exp.y: Update rules.
4878         * breakpoint.c (set_breakpoint_condition): Create an
4879         innermost_block_tracker.
4880         (watch_command_1): Likewise.
4881         * ada-lang.c (resolve): Add "tracker" parameter.
4882         (resolve_subexp): Likewise.
4883         * ada-exp.y (write_var_from_sym): Update.
4884
4885 2019-04-04  Tom Tromey  <tom@tromey.com>
4886
4887         * type-stack.h: New file.
4888         * type-stack.c: New file.
4889         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4890         type-stack.h.
4891         (insert_into_type_stack, insert_type, push_type, push_type_int)
4892         (insert_type_address_space, pop_type, pop_type_int)
4893         (pop_typelist, pop_type_stack, append_type_stack)
4894         (push_type_stack, get_type_stack, push_typelist)
4895         (follow_type_instance_flags, follow_types): Don't declare.
4896         * parse.c (type_stack): Remove global.
4897         (parse_exp_in_context): Update.
4898         (insert_into_type_stack, insert_type, push_type, push_type_int)
4899         (insert_type_address_space, pop_type, pop_type_int)
4900         (pop_typelist, pop_type_stack, append_type_stack)
4901         (push_type_stack, get_type_stack, push_typelist)
4902         (follow_type_instance_flags, follow_types): Remove (moved to
4903         type-stack.c).
4904         * f-exp.y (type_stack): New global.
4905         Update rules.
4906         (push_kind_type, f_parse): Update.
4907         * d-exp.y (type_stack): New global.
4908         Update rules.
4909         (d_parse): Update.
4910         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4911         Update rules.
4912         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4913         (HFILES_NO_SRCDIR): Add type-stack.h.
4914
4915 2019-04-04  Tom Tromey  <tom@tromey.com>
4916
4917         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4918         (rust_parser::convert_ast_to_expression, rust_parse)
4919         (rust_lex_test_completion, rust_lex_tests): Update.
4920         * parser-defs.h (struct expr_completion_state): New.
4921         (struct parser_state) <parser_state>: Add completion parameter.
4922         <mark_struct_expression, mark_completion_tag>: New methods.
4923         <parse_completion, m_completion_state>: New members.
4924         (prefixify_expression, null_post_parser): Update.
4925         (mark_struct_expression, mark_completion_tag): Don't declare.
4926         * parse.c (parse_completion, expout_last_struct)
4927         (expout_tag_completion_type, expout_completion_name): Remove
4928         globals.
4929         (parser_state::mark_struct_expression)
4930         (parser_state::mark_completion_tag): Now methods.
4931         (prefixify_expression): Add last_struct parameter.
4932         (prefixify_subexp): Likewise.
4933         (parse_exp_1): Update.
4934         (parse_exp_in_context): Add cstate parameter.  Update.
4935         (parse_expression_for_completion): Create an
4936         expr_completion_state.
4937         (null_post_parser): Add "completion" parameter.
4938         * p-exp.y: Update rules.
4939         (yylex): Update.
4940         * language.h (struct language_defn) <la_post_parser>: Add
4941         "completing" parameter.
4942         * go-exp.y: Update rules.
4943         (lex_one_token): Update.
4944         * expression.h (parse_completion): Don't declare.
4945         * d-exp.y: Update rules.
4946         (lex_one_token): Update rules.
4947         * c-exp.y: Update rules.
4948         (lex_one_token): Update.
4949         * ada-lang.c (resolve): Add "parse_completion" parameter.
4950         (resolve_subexp): Likewise.
4951         (ada_resolve_function): Likewise.
4952
4953 2019-04-04  Tom Tromey  <tom@tromey.com>
4954
4955         * parser-defs.h (struct parser_state) <start_arglist,
4956         end_arglist>: New methods.
4957         <arglist_len, m_funcall_chain>: New members.
4958         (arglist_len, start_arglist, end_arglist): Don't declare.
4959         * parse.c (arglist_len, funcall_chain): Remove global.
4960         (start_arglist, end_arglist): Remove functions.
4961         (parse_exp_in_context): Update.
4962         * p-exp.y: Update rules.
4963         * m2-exp.y: Update rules.
4964         * go-exp.y: Update rules.
4965         * f-exp.y: Update rules.
4966         * d-exp.y: Update rules.
4967         * c-exp.y: Update rules.
4968
4969 2019-04-04  Tom Tromey  <tom@tromey.com>
4970
4971         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4972         lex_operator, push_back>: New methods.
4973         Update all rules.
4974         (rust_parser::lex_hex, lex_escape): Rename and update.
4975         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4976         (rust_parser::lex_operator): Rename and update.
4977         (rust_parser::lex_number, rustyylex, rustyyerror)
4978         (rust_lex_test_init, rust_lex_test_sequence)
4979         (rust_lex_test_push_back, rust_lex_tests): Update.
4980         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4981         parameter.
4982         <lexptr, prev_lexptr>: New members.
4983         (lexptr, prev_lexptr): Don't declare.
4984         * parse.c (lexptr, prev_lexptr): Remove globals.
4985         (parse_exp_in_context): Update.
4986         * p-exp.y (yylex, yyerror): Update.
4987         * m2-exp.y (parse_number, yylex, yyerror): Update.
4988         * go-exp.y (lex_one_token, yyerror): Update.
4989         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4990         * d-exp.y (lex_one_token, yyerror): Update.
4991         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4992         (lex_one_token, yyerror): Update.
4993         * ada-lex.l (YY_INPUT): Update.
4994         (rewind_to_char): Update.
4995         * ada-exp.y (yyerror): Update.
4996
4997 2019-04-04  Tom Tromey  <tom@tromey.com>
4998
4999         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5000         * parser-defs.h (struct parser_state) <parser_state>: Add new
5001         parameter.
5002         <comma_terminates>: New member.
5003         (comma_terminates): Don't declare global.
5004         * parse.c (comma_terminates): Remove global.
5005         (parse_exp_in_context): Update.
5006         * p-exp.y (yylex): Update.
5007         * m2-exp.y (yylex): Update.
5008         * go-exp.y (lex_one_token): Update.
5009         * f-exp.y (yylex): Update.
5010         * d-exp.y (lex_one_token): Update.
5011         * c-exp.y (lex_one_token): Update.
5012         * ada-lex.l: Update.
5013
5014 2019-04-04  Tom Tromey  <tom@tromey.com>
5015
5016         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5017         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5018         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5019         * parser-defs.h (paren_depth): Don't declare.
5020         * parse.c (paren_depth): Remove global.
5021         (parse_exp_in_context): Update.
5022         * p-exp.y (paren_depth): New global.
5023         (pascal_parse): Initialize it.
5024         * m2-exp.y (paren_depth): New global.
5025         (m2_parse): Initialize it.
5026         * go-exp.y (paren_depth): New global.
5027         (go_parse): Initialize it.
5028         * f-exp.y (paren_depth): New global.
5029         (f_parse): Initialize it.
5030         * d-exp.y (paren_depth): New global.
5031         (d_parse): Initialize it.
5032         * c-exp.y (paren_depth): New global.
5033         (c_parse): Initialize it.
5034         * ada-lex.l (paren_depth): New global.
5035         (lexer_init): Initialize it.
5036
5037 2019-04-04  Tom Tromey  <tom@tromey.com>
5038
5039         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5040         (rust_parser::convert_ast_to_type)
5041         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5042         * parser-defs.h (struct parser_state) <parser_state>: Add
5043         parameters.  Initialize new members.
5044         <expression_context_block, expression_context_pc>: New members.
5045         * parse.c (expression_context_block, expression_context_pc):
5046         Remove globals.
5047         (parse_exp_in_context): Update.
5048         * p-exp.y: Update all rules.
5049         (yylex): Update.
5050         * m2-exp.y: Update all rules.
5051         (yylex): Update.
5052         * go-exp.y (yylex): Update.
5053         * f-exp.y (yylex): Update.
5054         * d-exp.y: Update all rules.
5055         (yylex): Update.
5056         * c-exp.y: Update all rules.
5057         (lex_one_token, classify_name, yylex, c_parse): Update.
5058         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5059
5060 2019-04-04  Tom Tromey  <tom@tromey.com>
5061
5062         * gdbarch.h, gdbarch.c: Rebuild.
5063         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5064         * stap-probe.h: 
5065         (struct stap_parse_info): Replace "parser_state" with
5066         "expr_builder".
5067         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5068         (parser_state): New class.
5069         * parse.c (expr_builder): Rename.
5070         (expr_builder::release): Rename.
5071         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5072         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5073         (write_exp_elt_longcst, write_exp_elt_floatcst)
5074         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5075         (write_exp_string_vector, write_exp_bitstring)
5076         (write_exp_msymbol, mark_struct_expression)
5077         (write_dollar_variable)
5078         (insert_type_address_space, increase_expout_size): Replace
5079         "parser_state" with "expr_builder".
5080         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5081         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5082         "parser_state" with "expr_builder".
5083
5084 2019-04-04  Tom Tromey  <tom@tromey.com>
5085
5086         * rust-exp.y: Replace "parse_language" with method call.
5087         * p-exp.y: 
5088         (yylex): Replace "parse_language" with method call.
5089         * m2-exp.y: 
5090         (yylex): Replace "parse_language" with method call.
5091         * go-exp.y (classify_name): Replace "parse_language" with method
5092         call.
5093         * f-exp.y (yylex): Replace "parse_language" with method call.
5094         * d-exp.y (lex_one_token): Replace "parse_language" with method
5095         call.
5096         * c-exp.y: 
5097         (lex_one_token, classify_name, yylex): Replace "parse_language"
5098         with method call.
5099         * ada-exp.y (find_primitive_type, type_char)
5100         (type_system_address): Replace "parse_language" with method call.
5101
5102 2019-04-04  Tom Tromey  <tom@tromey.com>
5103
5104         * rust-exp.y: Replace "parse_gdbarch" with method call.
5105         * parse.c (write_dollar_variable, insert_type_address_space):
5106         Replace "parse_gdbarch" with method call.
5107         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5108         call.
5109         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5110         call.
5111         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5112         "parse_gdbarch" with method call.
5113         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5114         with method call.
5115         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5116         "parse_gdbarch" with method call.
5117         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5118         "parse_gdbarch" with method call.
5119         * c-exp.y (parse_type, parse_number, classify_name): Replace
5120         "parse_gdbarch" with method call.
5121         * ada-lex.l: Replace "parse_gdbarch" with method call.
5122         * ada-exp.y (parse_type, find_primitive_type, type_char)
5123         (type_system_address): Replace "parse_gdbarch" with method call.
5124
5125 2019-04-04  Tom Tromey  <tom@tromey.com>
5126
5127         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5128         * stap-probe.c (stap_parse_argument): Update.
5129         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5130         initial_size parameter.
5131         * rust-exp.y (rust_lex_tests): Update.
5132         * parse.c (parser_state): Update.
5133         (parse_exp_in_context): Update.
5134         * parser-defs.h (struct parser_state) <parser_state>: Remove
5135         "initial_size" parameter.
5136
5137 2019-04-04  Tom Tromey  <tom@tromey.com>
5138
5139         * parser-defs.h (increase_expout_size): Don't declare.
5140         * parse.c (increase_expout_size): Now static.
5141
5142 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5143
5144         * gnu-nat.c (gnu_nat_target::wait): Fix
5145         target_waitstatus_to_string call.
5146
5147 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5148
5149         * eval.c (evaluate_subexp_standard): Handle internal functions
5150         during Fortran function call handling.
5151
5152 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5153
5154         * NEWS: Mention new internal functions.
5155         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5156         (read_base_type): Use dwarf2_init_complex_target_type.
5157         * value.c (creal_internal_fn): New function.
5158         (cimag_internal_fn): New function.
5159         (_initialize_values): Register new internal functions.
5160
5161 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5162
5163         * infrun.c (stop_all_threads): If debug_infrun, always
5164         trace the wait status after wait_one, using
5165         target_waitstatus_to_string and target_pid_to_str.
5166         (handle_inferior_event): Replace various trace of
5167         wait status kind by a single trace.
5168         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5169         wait status kind image by target_waitstatus_to_string.
5170         * target/waitstatus.c (target_waitstatus_to_string): Fix
5171         obsolete comment.
5172
5173 2019-04-01  Tom Tromey  <tromey@adacore.com>
5174
5175         PR symtab/23331:
5176         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5177
5178 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5179             Pedro Alves  <palves@redhat.com>
5180
5181         * top.c (quit_force): Call 'finalize_values'.
5182         * value.c (finalize_values): New function.
5183         * value.h (finalize_values): Declare.
5184
5185 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5186
5187         * NEWS: Announce $_gdb_major and $_gdb_minor.
5188
5189         * top.c (init_gdb_version_vars): New function.
5190         (gdb_init): Call init_gdb_version_vars.
5191
5192 2019-03-29  Tom Tromey  <tromey@adacore.com>
5193
5194         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5195         help text.  Remove dead code.
5196
5197 2019-03-29  Keith Seitz  <keiths@redhat.com>
5198
5199         From Siddhesh Poyarekar:
5200         * f-lang.h (f77_get_upperbound): Return LONGEST.
5201         (f77_get_lowerbound): Likewise.
5202         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5203         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5204         print them.
5205         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5206         plongest to format print it.
5207         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5208         (f77_get_upperbound): Likewise.
5209         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5210         LOWER_BOUND to LONGEST.
5211         (f77_create_arrayprint_offset_tbl): Likewise.
5212
5213 2019-03-29  Keith Seitz  <keiths@redhat.com>
5214
5215         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5216         %s/pulongest for TYPE_LENGTH instead of %d in format
5217         strings.
5218         * ada-typerint.c (ada_print_type): Likewise.
5219         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5220         * compile/compile-c-support.c (generate_register_struct): Likewise.
5221         * gdbtypes.c (recursive_dump_type): Likewise.
5222         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5223         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5224         instead of %d in format strings.
5225         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5226         to std::min to ULONGEST.
5227         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5228         instead of %d in format strings.
5229         * tracepoint.c (info_scope_command): Likewise.
5230         * typeprint.c (print_offset_data::update)
5231         (print_offset_data::finish): Likewise.
5232         * xtensa-tdep.c (xtensa_store_return_value)
5233         (xtensa_push_dummy_call): Likewise.
5234
5235 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5236
5237         * windows-nat.c (display_selector): Fixed format specifications
5238         for 64-bit Cygwin.
5239
5240 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5241
5242         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5243
5244 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5245
5246         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5247         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5248         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5249         (nios2_linux_init_abi): Install it.
5250
5251 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5252
5253         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5254
5255 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5256
5257         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5258
5259 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5260             Tom Tromey  <tromey@adacore.com>
5261
5262         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5263
5264 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5265
5266         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5267         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5268         method to compute the bounds of range types. Also print "[evaluated]"
5269         if the bounds' values come from a dynamic evaluation.
5270
5271 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5272
5273         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5274         whitespace when pretty printing is on.
5275
5276 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5277
5278         * ppc-linux-nat.c: Add include.
5279
5280 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5281
5282         * NEWS: Mention AArch64 Pointer Authentication.
5283
5284 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5285
5286         * arm-linux-nat.c: Add include.
5287
5288 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5289
5290         * source-cache.c (source_cache::get_source_lines): Re-read
5291         fullname after calling open_source_file.
5292
5293 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5294
5295         * NEWS: Mention TLS support for FreeBSD.
5296
5297 2019-03-25  Tom Tromey  <tromey@adacore.com>
5298
5299         * minsyms.c (BUNCH_SIZE): Update comment.
5300         (~minimal_symbol_reader): Remove old comment.
5301         (compact_minimal_symbols): Update comment.
5302         (minimal_symbol_reader::install): Remove old comment.  Update
5303         other comments.
5304
5305 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5306
5307         * s390-linux-nat.c: Add include.
5308
5309 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5310
5311         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5312         Call linux_get_hwcap.
5313         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5314         Likewise.
5315         (aarch64_linux_get_hwcap): Remove function.
5316         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5317         declaration.
5318         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5319         linux_get_hwcap.
5320         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5321         * linux-tdep.c (linux_get_hwcap): Add function.
5322         (linux_get_hwcap2): Likewise.
5323         * linux-tdep.h (linux_get_hwcap): Add declaration.
5324         (linux_get_hwcap2): Likewise.
5325         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5326         (ppc_linux_get_hwcap2): Likewise.
5327         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5328         linux_get_hwcap.
5329         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5330         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5331         (ppc_linux_nat_target::read_description): Likewise.
5332         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5333         * s390-linux-nat.c: Likewise.
5334         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5335
5336 2019-03-24  Tom Tromey  <tom@tromey.com>
5337
5338         * ada-lang.c (standard_lookup): Simplify initialization.
5339         (ada_lookup_symbol_nonlocal): Simplify return.
5340         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5341         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5342         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5343         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5344         initialization.
5345         * solib.c (solib_global_lookup): Simplify.
5346         * symtab.c (null_block_symbol): Remove.
5347         (symbol_cache_lookup): Simplify returns.
5348         (lookup_language_this): Simplify returns.
5349         (lookup_symbol_aux): Simplify return.
5350         (lookup_local_symbol): Simplify returns.
5351         (lookup_global_symbol_from_objfile): Simplify return.
5352         (lookup_symbol_in_objfile_symtabs)
5353         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5354         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5355         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5356         * cp-namespace.c (cp_lookup_bare_symbol)
5357         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5358         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5359         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5360         (cp_lookup_symbol_via_imports): Simplify initialization.
5361         (find_symbol_in_baseclass): Likewise.
5362         * symtab.h (null_block_symbol): Remove.
5363         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5364         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5365         (d_lookup_symbol_module): Likewise.
5366         (find_symbol_in_baseclass): Simplify initialization.
5367
5368 2019-03-24  Tom Tromey  <tom@tromey.com>
5369
5370         * expression.h: Don't include symtab.h.
5371         (struct block): Forward declare.
5372
5373 2019-03-24  Tom Tromey  <tom@tromey.com>
5374
5375         * c-exp.y (typebase): Remove casts.
5376         * gdbtypes.c (lookup_unsigned_typename, )
5377         (lookup_signed_typename): Remove cast.
5378         * eval.c (parse_to_comma_and_eval): Remove cast.
5379         * parse.c (write_dollar_variable): Remove cast.
5380         * block.h (struct block) <superblock>: Now const.
5381         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5382         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5383         (map_block): Make "block" const.
5384         * symfile.h (struct quick_symbol_functions)
5385         <map_matching_symbols>: Constify block argument to "callback".
5386         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5387         const.
5388         (find_pc_sect_compunit_symtab): Make "b" const.
5389         (find_symbol_at_address): Likewise.
5390         (search_symbols): Likewise.
5391         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5392         (dw2_debug_names_lookup_symbol): Likewise.
5393         (dw2_map_matching_symbols): Update.
5394         * p-valprint.c (pascal_val_print): Remove "block".
5395         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5396         (aux_add_nonlocal_symbols): Make "block" const.
5397         (resolve_subexp): Remove cast.
5398         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5399         const.
5400         (iterate_over_file_blocks): Likewise.
5401         * f-exp.y (%union) <bval>: Remove.
5402         * coffread.c (patch_opaque_types): Make "b" const.
5403         * spu-tdep.c (spu_catch_start): Make "block" const.
5404         * c-valprint.c (print_unpacked_pointer): Remove "block".
5405         * symmisc.c (dump_symtab_1): Make "b" const.
5406         (block_depth): Make "block" const.
5407         * d-exp.y (%union) <bval>: Remove.
5408         * cp-support.h (cp_lookup_rtti_type): Update.
5409         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5410         * psymtab.c (psym_lookup_symbol): Make "block" const.
5411         (maintenance_check_psymtabs): Make "b" const.
5412         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5413         (enumerate_locals, enumerate_args): Update.
5414         * python/py-symtab.c (stpy_global_block): Make "block" const.
5415         (stpy_static_block): Likewise.
5416         * inline-frame.c (block_starting_point_at): Make "new_block"
5417         const.
5418         * block.c (find_block_in_blockvector): Make return type const.
5419         (blockvector_for_pc_sect): Make "b" const.
5420         (find_block_in_blockvector): Make "b" const.
5421
5422 2019-03-23  Tom Tromey  <tom@tromey.com>
5423
5424         * varobj.c (varobj_create): Update.
5425         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5426         * printcmd.c (display_command, do_one_display): Don't reset
5427         innermost_block.
5428         * parser-defs.h (enum innermost_block_tracker_type): Move to
5429         expression.h.
5430         (innermost_block): Update comment.
5431         * parse.c (parse_exp_1): Add tracker_types parameter.
5432         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5433         tracker_types parameter.  Reset innermost_block.
5434         (parse_exp_in_context): Remove.
5435         (parse_expression_for_completion): Update.
5436         * objfiles.c (~objfile): Don't reset expression_context_block or
5437         innermost_block.
5438         * expression.h (enum innermost_block_tracker_type): Move from
5439         parser-defs.h.
5440         (parse_exp_1): Add tracker_types parameter.
5441         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5442         reset innermost_block.
5443
5444 2019-03-23  Tom Tromey  <tom@tromey.com>
5445
5446         * objfiles.h: Include bcache.h.
5447
5448 2019-03-23  Tom Tromey  <tom@tromey.com>
5449
5450         * linespec.c (get_current_search_block): Use
5451         scoped_restore_current_language.
5452         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5453
5454 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5455             Jiong Wang  <jiong.wang@arm.com>
5456
5457         * aarch64-linux-tdep.c
5458         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5459         section.
5460         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5461
5462 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5463             Jiong Wang  <jiong.wang@arm.com>
5464
5465         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5466         instructions.
5467         (aarch64_analyze_prologue_test): Add PACIASP test.
5468         (aarch64_prologue_prev_register): Unmask PC value.
5469
5470 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5471             Jiong Wang  <jiong.wang@arm.com>
5472
5473         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5474         (aarch64_dwarf2_prev_register): Unmask PC value.
5475         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5476         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5477         DW_CFA_AARCH64_negate_ra_state.
5478         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5479
5480 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5481             Jiong Wang  <jiong.wang@arm.com>
5482
5483         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5484         registers.
5485         (aarch64_pseudo_register_name): Likewise.
5486         (aarch64_pseudo_register_type): Likewise.
5487         (aarch64_pseudo_register_reggroup_p): Likewise.
5488         (aarch64_gdbarch_init): Add pauth registers.
5489         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5490         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5491         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5492         (struct gdbarch_tdep): Add regnum for ra_state.
5493
5494 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5495             Jiong Wang  <jiong.wang@arm.com>
5496
5497         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5498
5499 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5500             Jiong Wang  <jiong.wang@arm.com>
5501
5502         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5503         function.
5504         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5505         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5506         (aarch64_gdbarch_init): Add puth registers.
5507         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5508         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5509         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5510
5511 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5512             Jiong Wang  <jiong.wang@arm.com>
5513
5514         * aarch64-linux-nat.c
5515         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5516         * aarch64-linux-tdep.c
5517         (aarch64_linux_core_read_description): Likewise.
5518         (aarch64_linux_get_hwcap): New function.
5519         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5520         (aarch64_linux_get_hwcap): New declaration.
5521
5522 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5523             Jiong Wang  <jiong.wang@arm.com>
5524
5525         * aarch64-linux-nat.c
5526         (aarch64_linux_nat_target::read_description): Add pauth param.
5527         * aarch64-linux-tdep.c
5528         (aarch64_linux_core_read_description): Likewise.
5529         * aarch64-tdep.c (struct target_desc): Add in pauth.
5530         (aarch64_read_description): Add pauth param.
5531         (aarch64_gdbarch_init): Likewise.
5532         * aarch64-tdep.h (aarch64_read_description): Likewise.
5533         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5534         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5535         * features/Makefile: Add new files.
5536         * features/aarch64-pauth.c: New file.
5537         * features/aarch64-pauth.xml: New file.
5538
5539 2019-03-20  Tom Tromey  <tromey@adacore.com>
5540
5541         * infrun.c (handle_inferior_event): Rename from
5542         handle_inferior_event_1.  Create a scoped_value_mark.
5543         (handle_inferior_event): Remove.
5544
5545 2019-03-19  Tom Tromey  <tromey@adacore.com>
5546
5547         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5548         * infrun.h (print_stop_event): Add "displays" parameter.
5549         * infrun.c (print_stop_event): Add "displays" parameter.
5550
5551 2019-03-19  Pedro Alves  <palves@redhat.com>
5552
5553         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5554         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5555         to -1.  Fix TABs vs spaces.
5556         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5557         * tui/tui-out.h (tui_ui_out) Add intro comments.
5558         <m_line, m_start_of_line>: In-class initialize, and add describing
5559         comment.
5560
5561 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5562
5563         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5564         variable names.
5565         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5566
5567 2019-03-18  Pedro Alves  <palves@redhat.com>
5568             Eli Zaretskii <eliz@gnu.org>
5569
5570         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5571         m_line and m_start_of_line.
5572
5573 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5574
5575         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5576         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5577         it returns a newline.  This fixes a regression in TU mode, whereby
5578         the next line is output on the same screen line as the user input.
5579
5580 2019-03-18  Tom Tromey  <tromey@adacore.com>
5581
5582         * minsyms.c (minimal_symbol_reader::install): Remove call to
5583         obstack_blank.
5584
5585 2019-03-18  Pedro Alves  <palves@redhat.com>
5586
5587         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5588         New globals.
5589         (apply_style): New, factored out from ...
5590         (apply_ansi_escape): ... this.  Handle reverse video mode.
5591         (tui_set_reverse_mode): New function.
5592         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5593         * tui/tui-winsource.c (tui_show_source_line): Use
5594         tui_set_reverse_mode instead of setting A_STANDOUT.
5595         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5596         New setter methods.
5597
5598 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5599
5600         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5601         Handle tabs.
5602
5603 2019-03-18  Tom Tromey  <tromey@adacore.com>
5604
5605         * ada-lang.c (empty_array): Add "high" parameter.
5606         (ada_evaluate_subexp): Update.
5607
5608 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5609
5610         * unittests/string_view-selftests.c: Define
5611         _initialize_string_view_selftests unconditionally.
5612
5613 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5614
5615         PR gdb/24350
5616         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5617
5618 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5619
5620         PR gdb/24351
5621         * windows-nat.c (display_selector): Fix format specifiers.
5622
5623 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5624
5625         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5626         tui_refill_source_window instead of tui_refresh_win, to update the
5627         current execution line.  This fixes redisplay of the current line
5628         when stepping through the code with "next" or "step".
5629
5630 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5631
5632         * source-cache.c (source_cache::get_source_lines): Call
5633         find_source_lines to initialize s->nlines.  This fixes vertical
5634         scrolling of TUI source window when the DOWN arrow is pressed.
5635
5636 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5637
5638         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5639         linux-thread-db.c (_initialize_thread_db): Likewise.
5640
5641 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5642
5643         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5644         wclrtoeol in tui_show_source_line".  This reverts changes made in
5645         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5646
5647 2019-03-15  Tom Tromey  <tom@tromey.com>
5648
5649         * symtab.h (struct minimal_symbol): Derive from
5650         general_symbol_info.
5651         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5652         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5653         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5654         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5655         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5656         (MSYMBOL_SEARCH_NAME): Update.
5657         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5658         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5659         * minsyms.c (minimal_symbol_reader::record_full): Update.
5660
5661 2019-03-15  Tom Tromey  <tom@tromey.com>
5662
5663         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5664
5665 2019-03-15  Tom Tromey  <tom@tromey.com>
5666
5667         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5668         unique_xmalloc_ptr.
5669         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5670         Update.
5671         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5672         (build_minimal_symbol_hash_tables)
5673         (minimal_symbol_reader::install): Update.
5674
5675 2019-03-15  Tom Tromey  <tom@tromey.com>
5676
5677         * symtab.c (create_demangled_names_hash): Update.
5678         (symbol_set_names): Update.
5679         * objfiles.h (struct objfile_per_bfd_storage)
5680         <demangled_names_hash>: Now an htab_up.
5681         * objfiles.c (objfile_per_bfd_storage): Simplify.
5682
5683 2019-03-15  Tom Tromey  <tom@tromey.com>
5684
5685         * objfiles.h (struct objfile_per_bfd_storage): Declare
5686         destructor.
5687         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5688         New.
5689         (get_objfile_bfd_data): Use new.  Don't initialize
5690         language_of_main.
5691         (free_objfile_per_bfd_storage): Remove.
5692         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5693
5694 2019-03-15  Tom Tromey  <tom@tromey.com>
5695
5696         * symfile.c (reread_symbols): Update.
5697         * objfiles.c (objfile::objfile): Update.
5698         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5699         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5700         comment.
5701         (minimal_symbol_reader::install): Update.
5702         (terminate_minimal_symbol_table): Remove.
5703         * jit.c (jit_object_close_impl): Update.
5704
5705 2019-03-15  Tom Tromey  <tom@tromey.com>
5706
5707         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5708         initializations.
5709
5710 2019-03-15  Tom Tromey  <tom@tromey.com>
5711
5712         * objfiles.h (struct objfile_per_bfd_storage)
5713         <demangled_hash_languages>: Now a bitset.
5714         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5715         (lookup_minimal_symbol): Update.
5716
5717 2019-03-15  Tom Tromey  <tom@tromey.com>
5718
5719         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5720         Don't return the symbol.
5721         * coffread.c (record_minimal_symbol): Use record_full.
5722
5723 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5724
5725         The MS-Windows port of ncurses fails to switch to a color pair if
5726         one or both of the colors are the implicit default colors.  This
5727         change records the default colors when TUI is initialized, and
5728         then specifies them explicitly when a color pair uses the default
5729         colors.  This allows color styling in TUI mode on MS-Windows.
5730
5731         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5732         ncurses_norm_attr.
5733         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5734         colors in ncurses_norm_attr.
5735         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5736         "none", replace it with the default color recorded in
5737         ncurses_norm_attr.
5738
5739 2019-03-14  Tom Tromey  <tromey@adacore.com>
5740
5741         * source-cache.h (class source_cache) <get_source_lines>: Return
5742         std::string.
5743         * source-cache.c (source_cache::extract_lines): Handle case where
5744         first_pos==npos.  Return std::string.
5745         (source_cache::get_source_lines): Update.
5746
5747 2019-03-14  Tom Tromey  <tromey@adacore.com>
5748
5749         * NEWS: Add item for "style sources" commands.
5750         * source-cache.c (source_cache::get_source_lines): Check
5751         source_styling.
5752         * cli/cli-style.c (source_styling): New global.
5753         (_initialize_cli_style): Add "style sources" commands.
5754         (show_style_sources): New function.
5755         * cli/cli-style.h (source_styling): Declare.
5756
5757 2019-03-14  Pedro Alves  <palves@redhat.com>
5758             Tom Tromey  <tromey@adacore.com>
5759
5760         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5761         * tui/tui-winsource.c (tui_refill_source_window): New function,
5762         from...
5763         (tui_horizontal_source_scroll): ... here.  Move some logic.
5764         * cli/cli-style.c (set_style_enabled): Notify new observable.
5765         * tui/tui-hooks.c (tui_redisplay_source): New function.
5766         (tui_attach_detach_observers): Attach or detach
5767         tui_redisplay_source.
5768         * observable.h (source_styling_changed): New observable.
5769         * observable.c: Define source_styling_changed observable.
5770
5771 2019-03-13  Tom Tromey  <tromey@adacore.com>
5772
5773         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5774         (i386_gnu_nat_target::store_registers): Update.
5775         * target-debug.h (target_debug_print_std_string): New macro.
5776         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5777         * windows-tdep.c (display_one_tib): Update.
5778         * tui/tui-stack.c (tui_make_status_line): Update.
5779         * top.c (print_inferior_quit_action): Update.
5780         * thread.c (thr_try_catch_cmd): Update.
5781         (add_thread_with_info): Update.
5782         (thread_target_id_str): Update.
5783         (thr_try_catch_cmd): Update.
5784         (thread_command): Update.
5785         (thread_find_command): Update.
5786         * record-btrace.c (record_btrace_target::info_record)
5787         (record_btrace_resume_thread, record_btrace_target::resume)
5788         (record_btrace_cancel_resume, record_btrace_step_thread)
5789         (record_btrace_target::wait, record_btrace_target::wait)
5790         (record_btrace_target::wait, record_btrace_target::stop): Update.
5791         * progspace.c (print_program_space): Update.
5792         * process-stratum-target.c
5793         (process_stratum_target::thread_address_space): Update.
5794         * linux-fork.c (linux_fork_mourn_inferior)
5795         (detach_checkpoint_command, info_checkpoints_command)
5796         (linux_fork_context): Update.
5797         (linux_fork_detach): Update.
5798         (class scoped_switch_fork_info): Update.
5799         (delete_checkpoint_command): Update.
5800         * infrun.c (follow_fork_inferior): Update.
5801         (follow_fork_inferior): Update.
5802         (proceed_after_vfork_done): Update.
5803         (handle_vfork_child_exec_or_exit): Update.
5804         (follow_exec): Update.
5805         (displaced_step_prepare_throw): Update.
5806         (displaced_step_restore): Update.
5807         (start_step_over): Update.
5808         (resume_1): Update.
5809         (clear_proceed_status_thread): Update.
5810         (proceed): Update.
5811         (print_target_wait_results): Update.
5812         (do_target_wait): Update.
5813         (context_switch): Update.
5814         (stop_all_threads): Update.
5815         (restart_threads): Update.
5816         (finish_step_over): Update.
5817         (handle_signal_stop): Update.
5818         (switch_back_to_stepped_thread): Update.
5819         (keep_going_pass_signal): Update.
5820         (print_exited_reason): Update.
5821         (normal_stop): Update.
5822         * inferior.c (inferior_pid_to_str): Change return type.
5823         (print_selected_inferior): Update.
5824         (add_inferior): Update.
5825         (detach_inferior): Update.
5826         * dummy-frame.c (fprint_dummy_frames): Update.
5827         * dcache.c (dcache_info_1): Update.
5828         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5829         (btrace_fetch, btrace_clear): Update.
5830         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5831         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5832         type.
5833         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5834         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5835         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5836         * gdbarch.c, gdbarch.h: Rebuild.
5837         * gdbarch.sh (core_pid_to_str): Change return type.
5838         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5839         return type.
5840         (windows_nat_target::pid_to_str): Change return type.
5841         (windows_delete_thread): Update.
5842         (windows_nat_target::attach): Update.
5843         (windows_nat_target::files_info): Update.
5844         * target-delegates.c: Rebuild.
5845         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5846         return type.
5847         (sol_thread_target::pid_to_str): Change return type.
5848         * remote.c (class remote_target) <pid_to_str>: Change return
5849         type.
5850         (remote_target::pid_to_str): Change return type.
5851         (extended_remote_target::attach, remote_target::remote_stop_ns)
5852         (remote_target::remote_notif_remove_queued_reply)
5853         (remote_target::push_stop_reply, remote_target::disable_btrace):
5854         Update.
5855         (extended_remote_target::attach): Update.
5856         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5857         type.
5858         (gdbsim_target::pid_to_str): Change return type.
5859         * ravenscar-thread.c (struct ravenscar_thread_target)
5860         <pid_to_str>: Change return type.
5861         (ravenscar_thread_target::pid_to_str): Change return type.
5862         * procfs.c (class procfs_target) <pid_to_str>: Change return
5863         type.
5864         (procfs_target::pid_to_str): Change return type.
5865         (procfs_target::attach): Update.
5866         (procfs_target::detach): Update.
5867         (procfs_target::fetch_registers): Update.
5868         (procfs_target::store_registers): Update.
5869         (procfs_target::wait): Update.
5870         (procfs_target::files_info): Update.
5871         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5872         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5873         return type.
5874         (nto_procfs_target::pid_to_str): Change return type.
5875         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5876         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5877         return type.
5878         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5879         (exit_lwp): Update.
5880         (attach_proc_task_lwp_callback, get_detach_signal)
5881         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5882         (linux_nat_target::resume, wait_lwp, stop_callback)
5883         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5884         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5885         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5886         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5887         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5888         type.
5889         (inf_ptrace_target::attach): Update.
5890         (inf_ptrace_target::files_info): Update.
5891         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5892         type.
5893         (go32_nat_target::pid_to_str): Change return type.
5894         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5895         (gnu_nat_target::wait): Update.
5896         (gnu_nat_target::wait): Update.
5897         (gnu_nat_target::resume): Update.
5898         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5899         (fbsd_nat_target::wait): Update.
5900         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5901         type.
5902         (darwin_nat_target::attach): Update.
5903         * corelow.c (class core_target) <pid_to_str>: Change return type.
5904         (core_target::pid_to_str): Change return type.
5905         * target.c (normal_pid_to_str): Change return type.
5906         (default_pid_to_str): Likewise.
5907         (target_pid_to_str): Change return type.
5908         (target_translate_tls_address): Update.
5909         (target_announce_detach): Update.
5910         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5911         return type.
5912         (bsd_uthread_target::pid_to_str): Change return type.
5913         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5914         type.
5915         (bsd_kvm_target::pid_to_str): Change return type.
5916         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5917         return type.
5918         (aix_thread_target::pid_to_str): Change return type.
5919         * target.h (struct target_ops) <pid_to_str>: Change return type.
5920         (target_pid_to_str, normal_pid_to_str): Likewise.
5921         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5922         type.
5923         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5924         type.
5925         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5926         return type.
5927         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5928         type.
5929         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5930         type.
5931         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5932         return type.
5933
5934 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5935
5936         * NEWS: Mention that the new default MI version is 3.  Mention
5937         changes to the output of commands and events that deal with
5938         multi-location breakpoints.
5939         * breakpoint.c: Include "mi/mi-out.h".
5940         (print_one_breakpoint): Change output syntax if using MI version
5941         >= 3.
5942         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5943         New.
5944         (mi_multi_location_breakpoint_output_fixed): New.
5945         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5946         (mi_cmd_fix_multi_location_breakpoint_output): New.
5947         (mi_multi_location_breakpoint_output_fixed): New.
5948         * mi/mi-cmds.c (mi_cmds): Register command
5949         -fix-multi-location-breakpoint-output.
5950         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5951         interpreter "mi".
5952
5953 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5954
5955         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5956         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5957         instantiate mi_ui_out based on interpreter name.
5958         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5959         * mi/mi-main.c (mi_load_progress): Likewise.
5960
5961 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5962
5963         * NEWS: Combine separate "New targets" sections for 8.3.
5964
5965 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5966
5967         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5968         (ppcfbsd_init_abi): Install gdbarch
5969         "fetch_tls_load_module_address" and "get_thread_local_address"
5970         methods.
5971
5972 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5973
5974         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5975         (riscv_fbsd_init_abi): Install gdbarch
5976         "fetch_tls_load_module_address" and "get_thread_local_address"
5977         methods.
5978
5979 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5980
5981         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5982         (i386fbsd_init_abi): Install gdbarch
5983         "fetch_tls_load_module_address" and "get_thread_local_address"
5984         methods.
5985
5986 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5987
5988         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5989         (amd64fbsd_init_abi): Install gdbarch
5990         "fetch_tls_load_module_address" and "get_thread_local_address"
5991         methods.
5992
5993 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5994
5995         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5996         (struct fbsd_pspace_data): New type.
5997         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5998         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5999         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6000         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6001         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6002
6003 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6004
6005         * gdbtypes.c (lookup_struct_elt): New function.
6006         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6007         * gdbtypes.h (struct struct_elt): New type.
6008         (lookup_struct_elt): New prototype.
6009
6010 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6011
6012         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6013         remove disabled code block.
6014
6015 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6016
6017         * gdbarch.sh (get_thread_local_address): New method.
6018         * gdbarch.h, gdbarch.c: Regenerate.
6019         * target.c (target_translate_tls_address): Use
6020         gdbarch_get_thread_local_address if present instead of
6021         target::get_thread_local_address.
6022
6023 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6024
6025         * target.h (target::get_thread_local_address): Update comment.
6026
6027 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6028
6029         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6030         objfile->separate_debug_objfile_backlink if not NULL.
6031
6032 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6033
6034         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6035         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6036         (amd64bsd_store_inferior_registers): Likewise.
6037         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6038         Enable segment base registers.
6039         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6040         PT_GETFSBASE and PT_GETGSBASE.
6041         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6042         PT_SETGSBASE.
6043         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6044         segment base registers.
6045         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6046
6047 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6048
6049         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6050         Update calls to i386_target_description to add 'segments'
6051         parameter.
6052         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6053         add segment base registers.
6054         * arch/i386.c (i386_create_target_description): Add 'segments'
6055         parameter to enable segment base registers.
6056         * arch/i386.h (i386_create_target_description): Likewise.
6057         * features/i386/32bit-segments.xml: New file.
6058         * features/i386/32bit-segments.c: Generate.
6059         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6060         call to i386_target_description to add 'segments' parameter.
6061         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6062         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6063         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6064         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6065         if feature is present.
6066         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6067         Add 'segments' parameter to call to i386_target_description.
6068         (i386_target_description): Add 'segments' parameter to enable
6069         segment base registers.
6070         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6071         to call to i386_target_description.
6072         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6073         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6074         Define I386_NUM_REGS.
6075         (i386_target_description): Add 'segments' parameter to enable
6076         segment base registers.
6077
6078 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6079
6080         PR/24325
6081         * source-cache.c: #undef open and close, to avoid unresolved
6082         externals during linking.
6083
6084 2019-03-12  Tom Tromey  <tromey@adacore.com>
6085
6086         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6087         const.  Add initializers.
6088         (_initialize_remote): Don't initialize ptid globals.
6089
6090 2019-03-12  Pedro Alves  <palves@redhat.com>
6091
6092         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6093
6094 2019-03-12  Pedro Alves  <palves@redhat.com>
6095
6096         * cp-name-parser.y (main): Remove unused 'len' variable.
6097
6098 2019-03-12  Tom Tromey  <tromey@adacore.com>
6099
6100         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6101         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6102
6103 2019-03-12  Tom Tromey  <tromey@adacore.com>
6104
6105         * linux-nat.c (iterate_over_lwps): Update.
6106         (stop_callback): Remove parameter.
6107         (stop_wait_callback, detach_callback, resume_set_callback)
6108         (select_singlestep_lwp_callback, set_ignore_sigint)
6109         (status_callback, resumed_callback, resume_clear_callback)
6110         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6111         data parameter.
6112         (linux_nat_target::detach, linux_nat_target::resume)
6113         (linux_stop_and_wait_all_lwps, select_event_lwp)
6114         (linux_nat_filter_event, linux_nat_wait_1)
6115         (linux_nat_target::kill, linux_nat_target::stop)
6116         (linux_nat_target::stop): Update.
6117         (linux_nat_resume_callback): Change type.
6118         (resume_stopped_resumed_lwps, count_events_callback)
6119         (select_event_lwp_callback): Likewise.
6120         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6121         * arm-linux-nat.c (struct update_registers_data): Remove.
6122         (update_registers_callback): Change type.
6123         (arm_linux_insert_hw_breakpoint1): Update.
6124         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6125         parameter.
6126         (x86_linux_dr_set_addr): Update.
6127         (x86_linux_dr_set_control): Update.
6128         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6129         (iterate_over_lwps): Use gdb::function_view.
6130         * nat/aarch64-linux-hw-point.c (struct
6131         aarch64_dr_update_callback_param): Remove.
6132         (debug_reg_change_callback): Change type.
6133         (aarch64_notify_debug_reg_change): Update.
6134         * s390-linux-nat.c (s390_refresh_per_info): Update.
6135
6136 2019-03-11  Tom Tromey  <tromey@adacore.com>
6137
6138         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6139         redundant assignment to "this_cu".
6140
6141 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6142
6143         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6144
6145 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6146
6147         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6148         from...
6149         (rank_one_type): ... this.
6150
6151 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6152
6153         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6154         from...
6155         (rank_one_type): ... this.
6156
6157 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6158
6159         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6160         from...
6161         (rank_one_type): ... this.
6162
6163 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6164
6165         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6166         from...
6167         (rank_one_type): ... this.
6168
6169 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6170
6171         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6172         from...
6173         (rank_one_type): ... this.
6174
6175 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6176
6177         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6178         from...
6179         (rank_one_type): ... this.
6180
6181 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6182
6183         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6184         from...
6185         (rank_one_type): ... this.
6186
6187 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6188
6189         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6190         from...
6191         (rank_one_type): ... this.
6192
6193 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6194
6195         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6196         from...
6197         (rank_one_type): ... this.
6198
6199 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6200
6201         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6202         from...
6203         (rank_one_type): ... this.
6204
6205 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6206
6207         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6208         from...
6209         (rank_one_type): ... this.
6210
6211 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6212
6213         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6214         from...
6215         (rank_one_type): ... this.
6216
6217 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6218
6219         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6220         inferior-events' shows the example events.
6221
6222 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6223
6224         Support styling on native MS-Windows console
6225
6226         PR/24315
6227         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6228         on MS-Windows if $TERM is not defined.
6229
6230         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6231
6232         * posix-hdep.c (gdb_console_fputs):
6233         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6234         functions.
6235         * ui-file.h (gdb_console_fputs): Add prototype.
6236
6237         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6238         back to fputs only if the former returns zero.
6239
6240 2019-03-07  Tom Tromey  <tom@tromey.com>
6241
6242         * symmisc.c (print_symbol_bcache_statistics): Update.
6243         (print_objfile_statistics): Update.
6244         * symfile.c (allocate_symtab): Update.
6245         * stabsread.c: Don't include bcache.h.
6246         * psymtab.h (struct psymbol_bcache): Don't declare.
6247         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6248         (psymbol_bcache_init, psymbol_bcache_free)
6249         (psymbol_bcache_get_bcache): Don't declare.
6250         * psymtab.c (struct psymbol_bcache): Remove.
6251         (psymtab_storage::psymtab_storage): Update.
6252         (psymtab_storage::~psymtab_storage): Update.
6253         (psymbol_bcache_init, psymbol_bcache_free)
6254         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6255         (add_psymbol_to_bcache): Update.
6256         (allocate_psymtab): Update.
6257         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6258         macro_cache>: No longer pointers.
6259         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6260         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6261         * macrotab.c (macro_bcache): Update.
6262         * macroexp.c: Don't include bcache.h.
6263         * gdbtypes.c (check_types_worklist): Update.
6264         (types_deeply_equal): Remove TRY/CATCH.  Update.
6265         * elfread.c (elf_symtab_read): Update.
6266         * dwarf2read.c: Don't include bcache.h.
6267         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6268         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6269         (print_bcache_statistics, bcache_memory_used): Don't declare.
6270         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6271         methods.  Rename all data members.
6272         * bcache.c (struct bcache): Move to bcache.h.
6273         (bcache::expand_hash_table): Rename from expand_hash_table.
6274         (bcache): Remove.
6275         (bcache::insert): Rename from bcache_full.
6276         (bcache::compare): Rename from bcache_compare.
6277         (bcache_xmalloc): Remove.
6278         (bcache::~bcache): Rename from bcache_xfree.
6279         (bcache::print_statistics): Rename from print_bcache_statistics.
6280         (bcache::memory_used): Rename from bcache_memory_used.
6281
6282 2019-03-07  Pedro Alves  <palves@redhat.com>
6283
6284         * infrun.c (normal_stop): Also check for
6285         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6286
6287 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6288
6289         * f-lang.c (value_from_host_double): Moved to...
6290         * value.c (value_from_host_double): ...here.
6291         * value.h (value_from_host_double): Declare.
6292         * guile/scm-math.c (vlscm_convert_typed_number): Use
6293         value_from_host_double.
6294         (vlscm_convert_number): Likewise.
6295         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6296         * python/py-value.c (convert_value_from_python): Likewise.
6297
6298 2019-03-06  Tom Tromey  <tom@tromey.com>
6299
6300         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6301
6302 2019-03-06  Tom Tromey  <tom@tromey.com>
6303
6304         * utils.h (free_current_contents): Don't declare.
6305         * utils.c (free_current_contents): Remove.
6306
6307 2019-03-06  Tom Tromey  <tom@tromey.com>
6308
6309         * top.c (quit_force): Update.
6310         * main.c (captured_command_loop): Update.
6311         * common/new-op.c (operator new): Update.
6312         * common/common-exceptions.c (struct catcher)
6313         <save_cleanup_chain>: Remove member.
6314         (exceptions_state_mc_init): Update.
6315         (exception_try_scope_entry): Return nullptr.
6316         (exception_try_scope_exit, exception_rethrow)
6317         (throw_exception_sjlj, throw_exception_cxx): Update.
6318         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6319         (all_cleanups, do_cleanups, discard_cleanups)
6320         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6321         (restore_cleanups, restore_final_cleanups): Don't declare.
6322         (do_final_cleanups): Remove parameter.
6323         * common/cleanups.c (cleanup_chain, make_cleanup)
6324         (make_cleanup_dtor, all_cleanups, do_cleanups)
6325         (discard_my_cleanups, discard_cleanups)
6326         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6327         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6328         (null_cleanup): Remove.
6329         (do_final_cleanups): Remove parameter.
6330
6331 2019-03-06  Tom Tromey  <tom@tromey.com>
6332
6333         * remote.c (remote_target::remote_parse_stop_reply): Use
6334         unique_xmalloc_ptr.
6335
6336 2019-03-06  Tom Tromey  <tom@tromey.com>
6337
6338         * stabsread.c (struct stabs_field_info): Rename from field_info.
6339         <list, fnlist>: Add initializers.
6340         <obstack>: New member.
6341         (read_member_functions, read_struct_fields, read_baseclasses):
6342         Allocate on obstack.  Don't use cleanups.
6343         (read_one_struct_field, read_member_functions, read_struct_fields)
6344         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6345         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6346         (read_struct_type): Update.
6347
6348 2019-03-06  Tom Tromey  <tom@tromey.com>
6349
6350         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6351         * common/filestuff.h (make_cleanup_close): Don't declare.
6352         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6353         Remove.
6354
6355 2019-03-06  Tom Tromey  <tom@tromey.com>
6356
6357         * solib-aix.c: Use make_scope_exit.
6358
6359 2019-03-06  Tom Tromey  <tom@tromey.com>
6360
6361         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6362         Use make_scope_exit.
6363
6364 2019-03-06  Tom Tromey  <tom@tromey.com>
6365
6366         * solib-svr4.c (disable_probes_interface): Remove parameter.
6367         (svr4_handle_solib_event): Use make_scope_exit.
6368
6369 2019-03-06  Tom Tromey  <tom@tromey.com>
6370
6371         * remote.c (struct stop_reply_deleter): Remove.
6372         (stop_reply_up): Update.
6373         (struct stop_reply): Derive from notif_event.  Don't typedef.
6374         <regcache>: Now a std::vector.
6375         (stop_reply_xfree): Remove.
6376         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6377         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6378         (remote_target::discard_pending_stop_replies): Use delete.
6379         (remote_target::remote_parse_stop_reply): Update.
6380         (remote_target::process_stop_reply): Update.
6381         * remote-notif.h (struct notif_event): Add virtual destructor.
6382         Remove "dtr" member.
6383         (struct notif_client) <alloc_event>: Return a unique_ptr.
6384         (notif_event_xfree): Don't declare.
6385         (notif_event_up): New typedef.
6386         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6387         (notif_event_xfree, do_notif_event_xfree): Remove.
6388         (remote_notif_state_xfree): Update.
6389
6390 2019-03-06  Tom Tromey  <tom@tromey.com>
6391
6392         * infrun.c (displaced_step_clear_cleanup): Now a
6393         forward_scope_exit type.
6394         (displaced_step_prepare_throw): Update.
6395         (displaced_step_fixup): Update.
6396
6397 2019-03-06  Tom Tromey  <tom@tromey.com>
6398
6399         * inferior.h (class inferior): Update comment.
6400         * gdbthread.h (class thread_info): Update comment.
6401
6402 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6403             Tom Tromey  <tom@tromey.com>
6404
6405         * stabsread.h (struct stab_section_list): Remove.
6406         (coffstab_build_psymtabs): Update.
6407         * dbxread.c (symbuf_sections): Now a std::vector.
6408         (sect_idx): New global.
6409         (fill_symbuf): Update.
6410         (coffstab_build_psymtabs): Change type of stabsects parameter.
6411         Update.
6412         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6413         std::vector.
6414         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6415         (coff_locate_sections): Update.
6416         (coff_symfile_read): Remove cleanups.  Update.
6417         (init_stringtab): Add storage parameter.
6418         (free_stringtab, free_stringtab_cleanup): Remove.
6419         (init_lineno): Add storage parameter.
6420         (free_linetab, free_linetab_cleanup): Remove.
6421
6422 2019-03-06  Pedro Alves  <palves@redhat.com>
6423
6424         * linux-fork.c (fork_info::clobber_regs): Delete.
6425         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6426         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6427         comment.  Adjust.
6428         (scoped_switch_fork_info::scoped_switch_fork_info)
6429         (checkpoint_command, linux_fork_context): Adjust
6430         fork_save_infrun_state calls.
6431
6432 2019-03-06  Pedro Alves  <palves@redhat.com>
6433
6434         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6435         (inf_has_multiple_threads): Return 'bool' and rewrite using
6436         inferior_info::threads().
6437
6438 2019-03-06  Pedro Alves  <palves@redhat.com>
6439
6440         * linux-fork.c: Include <list>.
6441         (fork_list): Now a std::list instance.
6442         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6443         (forks_exist_p, find_last_fork): Adjust.
6444         (new_fork): Delete.
6445         (one_fork_p): New.
6446         (add_fork): Adjust.
6447         (free_fork): Delete, folded into fork_info::~fork_info().
6448         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6449         Adjust.
6450         (init_fork_list): Delete.
6451         (linux_fork_killall, linux_fork_mourn_inferior)
6452         (linux_fork_detach, info_checkpoints_command): Adjust.
6453         (_initialize_linux_fork): No longer call init_fork_list.
6454
6455 2019-03-06  Pedro Alves  <palves@redhat.com>
6456
6457         * linux-fork.c (new_fork): New, split out of ...
6458         (add_fork): ... this.  Return void.  Move "first fork" special
6459         case from here, to ...
6460         (checkpoint_command): ... here.
6461         * linux-linux.h (add_fork): Return void.
6462
6463 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6464
6465         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6466
6467 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6468             Chris January  <chris.january@arm.com>
6469             David Lecomber  <david.lecomber@arm.com>
6470
6471         * f-exp.y: New token, UNOP_INTRINSIC.
6472         (exp): New pattern using UNOP_INTRINSIC token.
6473         (f77_keywords): Add 'abs' keyword.
6474         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6475         (value_from_host_double): New function.
6476         (evaluate_subexp_f): Support UNOP_ABS.
6477
6478 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6479
6480         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6481         types.
6482
6483 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6484
6485         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6486         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6487         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6488
6489 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6490
6491         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6492
6493 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6494             Chris January  <chris.january@arm.com>
6495
6496         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6497         * f-exp.y: Define 'KIND' token.
6498         (exp): New pattern for KIND expressions.
6499         (ptype): Handle types with a kind extension.
6500         (direct_abs_decl): Extend to spot kind extensions.
6501         (f77_keywords): Add 'kind' to the list.
6502         (push_kind_type): New function.
6503         (convert_to_kind_type): New function.
6504         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6505         * parse.c (operator_length_standard): Likewise.
6506         * parser-defs.h (enum type_pieces): Add tp_kind.
6507         * std-operator.def: Add UNOP_KIND.
6508
6509 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6510
6511         * f-exp.y (f_parse): Set yydebug.
6512
6513 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6514
6515         * f-lang.c (evaluate_subexp_f): New function.
6516         (exp_descriptor_f): New global.
6517         (f_language_defn): Use exp_descriptor_f instead of
6518         exp_descriptor_standard.
6519
6520 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6521
6522         * f-exp.y (struct token): Add comments.
6523         (dot_ops): Remove uppercase versions and the end marker.
6524         (f77_keywords): Likewise.
6525         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6526         entries in the dot_ops array are case insensitive, and use
6527         strncasecmp to compare strings.  Also some whitespace cleanup in
6528         this area.  Similar for the f77_keywords array, except entries in
6529         this list might be case sensitive.
6530
6531 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6532
6533         * f-exp.y (struct f77_boolean_val): Add comments.
6534         (boolean_values): Remove uppercase versions, and end marker.
6535         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6536         and use strncasecmp to achieve case insensitivity.  Additionally,
6537         perform whitespace cleanup around this code.
6538
6539 2019-03-06  Tom Tromey  <tromey@adacore.com>
6540
6541         * remote-sim.c (gdbsim_target_open): Use result of
6542         gdb_argv::release.
6543
6544 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6545         Dirk Schubert  <dirk.schubert@arm.com>
6546         Chris January  <chris.january@arm.com>
6547
6548         * eval.c (evaluate_subexp_standard): Call Fortran argument
6549         wrapping logic.
6550         * f-lang.c (struct value): A value which can be passed into a
6551         Fortran function call.
6552         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6553         where appropriate.
6554         (struct type): Value ready for a Fortran function call.
6555         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6556         is needed.
6557         * f-lang.h (fortran_argument_convert): Declaration.
6558         (fortran_preserve_arg_pointer): Declaration.
6559         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6560
6561 2019-03-05  Tom Tromey  <tromey@adacore.com>
6562
6563         * python/py-prettyprint.c (print_string_repr): Remove #if.
6564         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6565
6566 2019-03-05  Tom Tromey  <tromey@adacore.com>
6567
6568         * target.c (the_dummy_target): Move later.  Change type to
6569         "dummy_target".
6570         (initialize_targets): Don't initialize the_dummy_target.
6571
6572 2019-03-05  Tom Tromey  <tromey@adacore.com>
6573
6574         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6575         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6576
6577 2019-03-05  Tom Tromey  <tromey@adacore.com>
6578
6579         * windows-nat.c (windows_nat_target::attach)
6580         (windows_nat_target::detach): Don't call gdb_flush.
6581         * valprint.c (generic_val_print, val_print, val_print_string):
6582         Don't call gdb_flush.
6583         * utils.c (defaulted_query): Don't call gdb_flush.
6584         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6585         * target.c (target_announce_detach): Don't call gdb_flush.
6586         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6587         * remote.c (extended_remote_target::attach): Don't call
6588         gdb_flush.
6589         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6590         * printcmd.c (do_examine): Don't call gdb_flush.
6591         (info_display_command): Don't call gdb_flush.
6592         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6593         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6594         * memattr.c (info_mem_command): Don't call gdb_flush.
6595         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6596         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6597         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6598         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6599         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6600         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6601         (gnu_nat_target::detach): Don't call gdb_flush.
6602         * f-valprint.c (f_val_print): Don't call gdb_flush.
6603         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6604         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6605         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6606         gdb_flush.
6607         * c-valprint.c (c_val_print): Don't call gdb_flush.
6608         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6609
6610 2019-03-05  Tom Tromey  <tromey@adacore.com>
6611
6612         * varobj.c (update_dynamic_varobj_children): Update.
6613         (install_default_visualizer): Use reset, not release.
6614         * value.c (set_internalvar): Update.
6615         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6616         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6617         ATTRIBUTE_UNUSED_RESULT.
6618
6619 2019-03-05  Tom Tromey  <tromey@adacore.com>
6620
6621         * remote.c (class scoped_remote_fd) <release>: Add
6622         ATTRIBUTE_UNUSED_RESULT.
6623
6624 2019-03-05  Tom Tromey  <tromey@adacore.com>
6625
6626         * macroexp.c (struct macro_buffer) <release>: Add
6627         ATTRIBUTE_UNUSED_RESULT.
6628
6629 2019-03-05  Tom Tromey  <tromey@adacore.com>
6630
6631         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6632         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6633         ATTRIBUTE_UNUSED_RESULT.
6634
6635 2019-03-05  Tom Tromey  <tromey@adacore.com>
6636
6637         * common/scoped_fd.h (class scoped_fd) <release>: Add
6638         ATTRIBUTE_UNUSED_RESULT.
6639
6640 2019-03-05  Tom Tromey  <tromey@adacore.com>
6641
6642         * parser-defs.h (struct parser_state) <release>: Add
6643         ATTRIBUTE_UNUSED_RESULT.
6644
6645 2019-03-05  Tom Tromey  <tromey@adacore.com>
6646
6647         * utils.h (class gdb_argv) <release>: Add
6648         ATTRIBUTE_UNUSED_RESULT.
6649         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6650
6651 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6652
6653         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6654         for-loop range, to avoid compiler warnings.
6655
6656         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6657         avoid compiler warnings about unused variables.
6658
6659         * NEWS: Mention end of support for native debugging on MS-Windows
6660         before XP.
6661
6662         PR gdb/24292
6663         * common/netstuff.c:
6664         * gdbserver/gdbreplay.c
6665         * gdbserver/remote-utils.c:
6666         * ser-tcp.c:
6667         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6668         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6669         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6670         'getaddrinfo' and 'freeaddrinfo' were not available before
6671         Windows XP, and mingw.org's MinGW headers by default define
6672         _WIN32_WINNT to 0x500.
6673
6674 2019-03-01  Gary Benson <gbenson@redhat.com>
6675
6676         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6677
6678 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6679             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6680
6681         PR gdb/8527
6682         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6683         set_sigint_trap, clear_sigint_trap.
6684
6685 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6686
6687         * target.c (target_detach): Clear the regcache and the
6688         frame cache.
6689
6690 2019-02-27  Pedro Alves  <palves@redhat.com>
6691
6692         * utils.c (set_screen_size): When we cap the height/width sizes,
6693         tweak the corresponding command variable to show "unlimited":
6694
6695 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6696             Pedro Alves  <palves@redhat.com>
6697
6698         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6699         before calling rl_set_screen_size.
6700
6701 2019-02-27  Tom Tromey  <tromey@adacore.com>
6702
6703         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6704         define.
6705         * python/py-value.c: Remove Python 2.4 workaround.
6706         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6707         workaround.
6708         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6709         Python 2.4 workaround.
6710         * python/python-internal.h: Remove Python 2.4 comment.
6711         (Py_ssize_t): Don't define.
6712         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6713         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6714         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6715         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6716         * python/python.c (do_start_initialization): Remove Python 2.4
6717         workaround.
6718         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6719         (print_children): Remove Python 2.4 workaround.
6720         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6721         workaround.
6722         (CHARBUFFERPROC_NAME): Remove.
6723         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6724         Python 2.4 workaround.
6725
6726 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6727
6728         * NEWS: Note minimum Python version.
6729
6730 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6731
6732         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6733         code from these functions.  Remove corresponding ifdefs.  Use
6734         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6735         Remove gotos and target of gotos.
6736         (infpy_search_memory): Likewise.
6737
6738 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6739
6740         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6741         (hppa_gdbarch_init): Don't register deleted functions with
6742         gdbarch.
6743
6744 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6745
6746         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6747         (h8300_unwind_sp): Delete.
6748         (h8300_dummy_id): Delete.
6749         (h8300_gdbarch_init): Don't register deleted functions with
6750         gdbarch.
6751
6752 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6753
6754         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6755         (ft32_unwind_pc): Delete.
6756         (ft32_unwind_sp): Delete.
6757         (ft32_gdbarch_init): Don't register deleted functions with
6758         gdbarch.
6759
6760 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6761
6762         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6763         (frv_unwind_pc): Delete.
6764         (frv_unwind_sp): Delete.
6765         (frv_gdbarch_init): Don't register deleted functions with
6766         gdbarch.
6767
6768 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6769
6770         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6771         (riscv_unwind_pc): Delete.
6772         (riscv_unwind_sp): Delete.
6773         (riscv_gdbarch_init): Don't register deleted functions with
6774         gdbarch.
6775
6776 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6777
6778         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6779         (csky_unwind_pc): Delete.
6780         (csky_unwind_sp): Delete.
6781         (csky_gdbarch_init): Don't register deleted functions with
6782         gdbarch.
6783
6784 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6785
6786         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6787         (cris_unwind_pc): Delete.
6788         (cris_unwind_sp): Delete.
6789         (cris_gdbarch_init): Don't register deleted functions with
6790         gdbarch.
6791
6792 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6793
6794         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6795         (bfin_unwind_pc): Delete.
6796         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6797
6798 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6799
6800         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6801         (arm_unwind_pc): Delete.
6802         (arm_unwind_sp): Delete.
6803         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6804
6805 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6806
6807         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6808         (arc_unwind_pc): Delete.
6809         (arc_unwind_sp): Delete.
6810         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6811
6812 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6813
6814         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6815         (alpha_unwind_pc): Delete.
6816         (alpha_gdbarch_init): Don't register deleted functions with
6817         gdbarch.
6818
6819 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6820
6821         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6822         (aarch64_unwind_pc): Delete.
6823         (aarch64_unwind_sp): Delete.
6824         (aarch64_gdbarch_init): Don't register deleted functions with
6825         gdbarch.
6826
6827 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6828
6829         * gdbtypes.c (type_align): Don't consider static members when
6830         computing structure alignment.
6831
6832 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6833
6834         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6835         return 0 for other types.
6836         * arch-utils.c (default_type_align): Always return 0.
6837         * gdbarch.h: Regenerate.
6838         * gdbarch.sh (type_align): Extend comment.
6839         * gdbtypes.c (type_align): Add additional comments, always call
6840         gdbarch_type_align before applying the default rules.
6841         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6842         generic code will then apply a suitable default.
6843         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6844         types, return 0 for other types.
6845
6846 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6847
6848         * NEWS: Create a new section for the next release branch.
6849         Rename the section of the current branch, now that it has
6850         been cut.
6851
6852 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6853
6854         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6855         * version.in: Bump version to 8.3.50.DATE-git.
6856
6857 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6858
6859         * aix-thread.c (ptid_cmp): Remove unused variable.
6860         (get_signaled_thread): Likewise.
6861         (store_regs_user_thread): Likewise.
6862         (store_regs_kernel_thread): Likewise.
6863         (fetch_regs_kernel_thread): Remove shadowed variable.
6864
6865 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6866
6867         * features/riscv/32bit-cpu.xml: Add register numbers.
6868         * features/riscv/32bit-fpu.c: Regenerate.
6869         * features/riscv/32bit-fpu.xml: Add register numbers.
6870         * features/riscv/64bit-cpu.xml: Add register numbers.
6871         * features/riscv/64bit-fpu.c: Regenerate.
6872         * features/riscv/64bit-fpu.xml: Add register numbers.
6873
6874 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6875
6876         * NEWS: Mention two argument form of gdb.Value constructor.
6877         * python/py-value.c (convert_buffer_and_type_to_value): New
6878         function.
6879         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6880         Add support for handling an optional second argument.  Call
6881         convert_buffer_and_type_to_value as appropriate.
6882         * python/python-internal.h (Py_buffer_deleter): New struct.
6883         (Py_buffer_up): New typedef.
6884
6885 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6886
6887         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6888         instead of releasing ownership.
6889
6890 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6891
6892         * dwarf2read.c (open_and_init_dwp_file): Call
6893         elf_numsections instead of bfd_count_sections to initialize
6894         dwp_file->num_sections.
6895
6896 2019-02-25  Tom Tromey  <tromey@adacore.com>
6897
6898         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6899
6900 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6901
6902         * gcore.in: Add '--readnever' option when invoking GDB.
6903
6904 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6905
6906         * MAINTAINERS: Update my email address.
6907
6908 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6909
6910         * build-id.c (build_id_to_debug_bfd_1): New function.
6911         (build_id_to_debug_bfd): Look for separate debug file in
6912         sysroot.
6913
6914 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6915
6916         * gdbarch.sh: Update the copyright year range that is placed into
6917         generated files.
6918
6919 2019-02-22  Keith Seitz  <keiths@redhat.com>
6920
6921         PR symtab/23853
6922         * linespec.c (create_sals_line_offset): Search for the default
6923         symtab's filename instead of its fullname.
6924
6925 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6926
6927         * NEWS: Update style defaults.
6928
6929 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6930
6931         * main.c (captured_main_1): Disable styling in batch mode.
6932
6933 2019-02-20  Tom Tromey  <tom@tromey.com>
6934
6935         * symtab.c (symtab_symbol_info): Fix typos.
6936
6937 2019-02-20  Tom Tromey  <tromey@adacore.com>
6938
6939         * findcmd.c (_initialize_mem_search): Use upper case for
6940         metasyntactic variables.
6941
6942 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6943
6944         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6945         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6946
6947 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6948
6949         * top.h (source_file_name): Change to std::string.
6950         * top.c (source_file_name): Likewise.
6951         (command_line_input): Adjust.
6952         * cli/cli-script.c (script_from_file): Adjust.
6953
6954 2019-02-19  Tom Tromey  <tromey@adacore.com>
6955
6956         * ravenscar-thread.c
6957         (ravenscar_thread_target::update_thread_list): Don't call
6958         ada_build_task_list.
6959         * ada-lang.h (ada_build_task_list): Don't declare.
6960         * ada-tasks.c (struct ada_tasks_inferior_data)
6961         <task_list_valid_p>: Now bool.
6962         (read_known_tasks, ada_task_list_changed)
6963         (ada_tasks_invalidate_inferior_data): Update.
6964         (read_known_tasks_array): Return bool.
6965         (read_known_tasks_list): Likewise.
6966         (read_known_tasks): Return void.
6967         (ada_build_task_list): Now static.
6968
6969 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6970
6971         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6972         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6973
6974 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6975
6976         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6977         variant for ada_tasks_pspace_data_handle and
6978         ada_tasks_inferior_data_handle.
6979         (ada_tasks_pspace_data_cleanup): New function.
6980         (ada_tasks_inferior_data_cleanup): New function.
6981
6982 2019-02-17  Tom Tromey  <tom@tromey.com>
6983
6984         * macrotab.h (macro_source_fullname): Return a std::string.
6985         * macrotab.c (macro_include, check_for_redefinition)
6986         (macro_undef, macro_lookup_definition, foreach_macro)
6987         (foreach_macro_in_scope): Update.
6988         (macro_source_fullname): Return a std::string.
6989         * macrocmd.c (show_pp_source_pos): Update.
6990
6991 2019-02-17  Tom Tromey  <tom@tromey.com>
6992
6993         * macrocmd.c (show_pp_source_pos): Style the file names.
6994
6995 2019-02-17  Tom Tromey  <tom@tromey.com>
6996
6997         PR tui/24197:
6998         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6999
7000 2019-02-17  Tom Tromey  <tom@tromey.com>
7001
7002         * ada-lang.c (user_select_syms): Use filtered printing.
7003         * utils.c (wrap_style): New global.
7004         (desired_style): Remove.
7005         (emit_style_escape): Add stream parameter.
7006         (set_output_style, reset_terminal_style, prompt_for_continue):
7007         Update.
7008         (flush_wrap_buffer): Only flush gdb_stdout.
7009         (wrap_here): Set wrap_style.
7010         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7011         treat escape sequences as a character.  Change when wrap buffer is
7012         flushed.
7013         (fputs_styled): Do not set the output style when the default is
7014         requested.
7015         * ui-style.h (struct ui_file_style) <is_default>: New method.
7016         * source.c (print_source_lines_base): Emit escape sequences in one
7017         piece.
7018
7019 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7020
7021         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7022         integers and enumeration types.
7023
7024 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7025
7026         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7027         instead of lookup_symbol_in_language
7028         (do_exact_match): New function.
7029         (ada_get_symbol_name_matcher): Return do_exact_match when
7030         doing a verbatim match.
7031
7032 2019-02-15  Tom Tromey  <tromey@adacore.com>
7033
7034         * ravenscar-thread.c (ravenscar_thread_target::resume)
7035         (ravenscar_thread_target::wait): Special case wildcard requests.
7036
7037 2019-02-15  Tom Tromey  <tromey@adacore.com>
7038
7039         * ravenscar-thread.c (base_ptid): Remove.
7040         (struct ravenscar_thread_target) <close>: New method.
7041         <m_base_ptid>: New member.
7042         <update_inferior_ptid, active_task, task_is_currently_active,
7043         runtime_initialized>: Declare methods.
7044         <ravenscar_thread_target>: Add constructor.
7045         (ravenscar_thread_target::task_is_currently_active)
7046         (ravenscar_thread_target::update_inferior_ptid)
7047         (ravenscar_runtime_initialized): Rename.  Now methods.
7048         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7049         (ravenscar_thread_target::update_thread_list): Update.
7050         (ravenscar_thread_target::active_task): Now method.
7051         (ravenscar_thread_target::store_registers)
7052         (ravenscar_thread_target::prepare_to_store)
7053         (ravenscar_thread_target::prepare_to_store)
7054         (ravenscar_thread_target::mourn_inferior): Update.
7055         (ravenscar_inferior_created): Use "new" to create target.
7056         (ravenscar_thread_target::get_ada_task_ptid): Update.
7057         (_initialize_ravenscar): Don't initialize base_ptid.
7058         (ravenscar_ops): Remove global.
7059
7060 2019-02-15  Tom Tromey  <tromey@adacore.com>
7061
7062         * target.h (push_target): Declare new overload.
7063         * target.c (push_target): New overload, taking an rvalue reference.
7064         * remote.c (remote_target::open_1): Use push_target overload.
7065         * corelow.c (core_target_open): Use push_target overload.
7066
7067 2019-02-15  Tom Tromey  <tromey@adacore.com>
7068
7069         * ravenscar-thread.c (is_ravenscar_task)
7070         (ravenscar_task_is_currently_active): Return bool.
7071         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7072         (_initialize_ravenscar): Remove "(void)".
7073         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7074         Return bool.
7075
7076 2019-02-15  Tom Tromey  <tromey@adacore.com>
7077
7078         * ravenscar-thread.c (ravenscar_runtime_initializer)
7079         (has_ravenscar_runtime, get_running_thread_id)
7080         (ravenscar_thread_target::resume): Fix indentation.
7081
7082 2019-02-15  Tom Tromey  <tromey@adacore.com>
7083
7084         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7085         from ravenscar_arch_ops.
7086         (sparc_ravenscar_ops::fetch_registers)
7087         (sparc_ravenscar_ops::store_registers): Now methods.
7088         (sparc_ravenscar_prepare_to_store): Remove.
7089         (sparc_ravenscar_ops): Redefine.
7090         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7091         methods and destructor.  Remove members.
7092         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7093         (ravenscar_thread_target::store_registers)
7094         (ravenscar_thread_target::prepare_to_store): Update.
7095         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7096         Remove.
7097         (struct ppc_ravenscar_powerpc_ops): Derive from
7098         ravenscar_arch_ops.
7099         (ppc_ravenscar_powerpc_ops::fetch_registers)
7100         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7101         (ppc_ravenscar_powerpc_ops): Redefine.
7102         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7103         (ppc_ravenscar_e500_ops::fetch_registers)
7104         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7105         (ppc_ravenscar_e500_ops): Redefine.
7106         * aarch64-ravenscar-thread.c
7107         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7108         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7109         (aarch64_ravenscar_fetch_registers)
7110         (aarch64_ravenscar_store_registers): Now methods.
7111         (aarch64_ravenscar_ops): Redefine.
7112
7113 2019-02-15  Tom Tromey  <tromey@adacore.com>
7114
7115         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7116         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7117         (ravenscar_thread_target::stopped_by_watchpoint)
7118         (ravenscar_thread_target::stopped_data_address)
7119         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7120
7121 2019-02-15  Tom Tromey  <tromey@adacore.com>
7122
7123         * ravenscar-thread.c: Fix some typos.
7124
7125 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7126             Tom Tromey  <tromey@adacore.com>
7127
7128         * ada-lang.c (ada_exception_sal): Change addr_string to a
7129         std::string.
7130         (create_ada_exception_catchpoint): Update.
7131
7132 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7133             Tom Tromey  <tromey@adacore.com>
7134
7135         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7136         (bp_location_ops): Remove.
7137         (base_breakpoint_allocate_location): Update.
7138         (free_bp_location): Update.
7139         * ada-lang.c (class ada_catchpoint_location)
7140         <ada_catchpoint_location>: Remove ops parameter.
7141         (ada_catchpoint_location_dtor): Remove.
7142         (ada_catchpoint_location_ops): Remove.
7143         (allocate_location_exception): Update.
7144         * breakpoint.h (struct bp_location_ops): Remove.
7145         (class bp_location) <bp_location>: Remove bp_location_ops
7146         parameter.
7147         <~bp_location>: Add destructor.
7148         <ops>: Remove.
7149
7150 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7151             Pedro Alves  <palves@redhat.com>
7152
7153         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7154         'PATH_MAX'.
7155
7156 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7157             Samuel Thibault  <samuel.thibault@gnu.org>
7158             Thomas Schwinge  <thomas@codesourcery.com>
7159
7160         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7161         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7162
7163 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7164
7165         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7166         (check_empty): Use "const char *".
7167
7168         * gnu-nat.c (gnu_nat_target::detach): Instead of
7169         'detach_inferior (pid)' call
7170         'detach_inferior (find_inferior_pid (pid))'.
7171
7172         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7173         'nat/fork-inferior.o'.
7174         * gnu-nat.c: #include "nat/fork-inferior.h".
7175
7176         * gnu-nat.c (gnu_nat_target::detach): Instead of
7177         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7178         * gnu-nat.h: #include "inf-child.h".
7179         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7180         'i386_gnu_nat_target::fetch_registers'.
7181         (gnu_store_registers): Rename/move to
7182         'i386_gnu_nat_target::store_registers'.
7183
7184         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7185         * gnu-nat.h (mach_thread_info): New function.
7186         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7187
7188         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7189
7190 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7191
7192         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7193
7194 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7195
7196         * windows-nat.c (windows_add_thread): Add new parameter
7197         "main_thread_p" with default value set to false.  Update
7198         function documentation as well as all callers.
7199         (windows_delete_thread): Likewise.
7200         (fake_create_process): Update call to windows_add_thread.
7201         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7202         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7203         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7204         call to windows_delete_thread.
7205
7206 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7207
7208         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7209
7210 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7211
7212         * symfile.c (find_separate_debug_file): Use canonical path of
7213         sysroot with child_path instead of gdb_sysroot if it is valid.
7214
7215 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7216
7217         * symfile.c (find_separate_debug_file): Use child_path to
7218         determine if an object file is under a sysroot.
7219
7220 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7221
7222         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7223         unittests/child-path-selftests.c.
7224         * common/pathstuff.c (child_path): New function.
7225         * common/pathstuff.h (child_path): New prototype.
7226         * unittests/child-path-selftests.c: New file.
7227
7228 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7229
7230         * symfile.c (find_separate_debug_file): Look for separate debug
7231         files in debug directories under the sysroot.
7232
7233 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7234
7235         * symtab.h (struct minimal_symbol data_p): New const method.
7236         (struct minimal_symbol text_p): Likewise.
7237         * symtab.c (output_source_filename): Use file name style
7238         to print file name.
7239         (print_symbol_info): Likewise.
7240         (print_msymbol_info): Use address style to print addresses.
7241         Use function name style to print executable text symbols.
7242         (expand_symtab_containing_pc): Use data_p.
7243         (find_pc_sect_compunit_symtab): Likewise.
7244
7245 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7246
7247         * breakpoint.c (describe_other_breakpoints): Use address style
7248         to print addresses.
7249         (say_where): Likewise.
7250
7251 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7252
7253         * ada-typeprint.c (print_func_type): Print function name
7254         style to print function name.
7255         * c-typeprint.c (c_print_type_1): Likewise.
7256
7257 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7258
7259         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7260         for execve.
7261
7262 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7263
7264         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7265         type_stack.
7266
7267 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7268
7269         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7270         TYPE_CODE_REF types.
7271
7272 2019-02-08  Jim Wilson  <jimw@sifive.com>
7273
7274         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7275         (riscv_linux_fregset): New.
7276         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7277
7278 2019-02-07  Tom Tromey  <tom@tromey.com>
7279
7280         * thread.c (thread_cancel_execution_command): Update.
7281         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7282         methods.
7283         (struct thread_fsm_ops): Remove.
7284         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7285         (thread_fsm_should_stop, thread_fsm_return_value)
7286         (thread_fsm_set_finished, thread_fsm_finished_p)
7287         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7288         Don't declare.
7289         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7290         * infrun.c (clear_proceed_status_thread)
7291         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7292         (print_stop_event): Update.
7293         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7294         Add constructor.
7295         (step_command_fsm_ops): Remove.
7296         (new_step_command_fsm): Remove.
7297         (step_1): Update.
7298         (step_command_fsm::should_stop): Rename from
7299         step_command_fsm_should_stop.
7300         (step_command_fsm::clean_up): Rename from
7301         step_command_fsm_clean_up.
7302         (step_command_fsm::do_async_reply_reason): Rename from
7303         step_command_fsm_async_reply_reason.
7304         (struct until_next_fsm): Inherit from thread_fsm.  Add
7305         constructor.
7306         (until_next_fsm_ops): Remove.
7307         (new_until_next_fsm): Remove.
7308         (until_next_fsm::should_stop): Rename from
7309         until_next_fsm_should_stop.
7310         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7311         (until_next_fsm::do_async_reply_reason): Rename from
7312         until_next_fsm_async_reply_reason.
7313         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7314         constructor.  Change type of breakpoint.
7315         (finish_command_fsm_ops): Remove.
7316         (new_finish_command_fsm): Remove.
7317         (finish_command_fsm::should_stop): Rename from
7318         finish_command_fsm_should_stop.
7319         (finish_command_fsm::clean_up): Rename from
7320         finish_command_fsm_clean_up.
7321         (finish_command_fsm::return_value): Rename from
7322         finish_command_fsm_return_value.
7323         (finish_command_fsm::do_async_reply_reason): Rename from
7324         finish_command_fsm_async_reply_reason.
7325         (finish_command): Update.
7326         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7327         Add constructor.
7328         (call_thread_fsm_ops): Remove.
7329         (call_thread_fsm::call_thread_fsm): Rename from
7330         new_call_thread_fsm.
7331         (call_thread_fsm::should_stop): Rename from
7332         call_thread_fsm_should_stop.
7333         (call_thread_fsm::should_notify_stop): Rename from
7334         call_thread_fsm_should_notify_stop.
7335         (run_inferior_call, call_function_by_hand_dummy): Update.
7336         * cli/cli-interp.c (should_print_stop_to_console): Update.
7337         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7338         Add constructor.  Change type of location_breakpoint,
7339         caller_breakpoint.
7340         (until_break_fsm_ops): Remove.
7341         (new_until_break_fsm): Remove.
7342         (until_break_fsm::should_stop): Rename from
7343         until_break_fsm_should_stop.
7344         (until_break_fsm::clean_up): Rename from
7345         until_break_fsm_clean_up.
7346         (until_break_fsm::do_async_reply_reason): Rename from
7347         until_break_fsm_async_reply_reason.
7348         (until_break_command): Update.
7349         * thread-fsm.c: Remove.
7350         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7351
7352 2019-02-07  Tom Tromey  <tom@tromey.com>
7353
7354         * yy-remap.h: Add include guard.
7355         * xtensa-tdep.h: Add include guard.
7356         * xcoffread.h: Rename include guard.
7357         * varobj-iter.h: Add include guard.
7358         * tui/tui.h: Rename include guard.
7359         * tui/tui-winsource.h: Rename include guard.
7360         * tui/tui-wingeneral.h: Rename include guard.
7361         * tui/tui-windata.h: Rename include guard.
7362         * tui/tui-win.h: Rename include guard.
7363         * tui/tui-stack.h: Rename include guard.
7364         * tui/tui-source.h: Rename include guard.
7365         * tui/tui-regs.h: Rename include guard.
7366         * tui/tui-out.h: Rename include guard.
7367         * tui/tui-layout.h: Rename include guard.
7368         * tui/tui-io.h: Rename include guard.
7369         * tui/tui-hooks.h: Rename include guard.
7370         * tui/tui-file.h: Rename include guard.
7371         * tui/tui-disasm.h: Rename include guard.
7372         * tui/tui-data.h: Rename include guard.
7373         * tui/tui-command.h: Rename include guard.
7374         * tic6x-tdep.h: Add include guard.
7375         * target/waitstatus.h: Rename include guard.
7376         * target/wait.h: Rename include guard.
7377         * target/target.h: Rename include guard.
7378         * target/resume.h: Rename include guard.
7379         * target-float.h: Rename include guard.
7380         * stabsread.h: Add include guard.
7381         * rs6000-tdep.h: Add include guard.
7382         * riscv-fbsd-tdep.h: Add include guard.
7383         * regformats/regdef.h: Rename include guard.
7384         * record.h: Rename include guard.
7385         * python/python.h: Rename include guard.
7386         * python/python-internal.h: Rename include guard.
7387         * python/py-stopevent.h: Rename include guard.
7388         * python/py-ref.h: Rename include guard.
7389         * python/py-record.h: Rename include guard.
7390         * python/py-record-full.h: Rename include guard.
7391         * python/py-record-btrace.h: Rename include guard.
7392         * python/py-instruction.h: Rename include guard.
7393         * python/py-events.h: Rename include guard.
7394         * python/py-event.h: Rename include guard.
7395         * procfs.h: Add include guard.
7396         * proc-utils.h: Add include guard.
7397         * p-lang.h: Add include guard.
7398         * or1k-tdep.h: Rename include guard.
7399         * observable.h: Rename include guard.
7400         * nto-tdep.h: Rename include guard.
7401         * nat/x86-linux.h: Rename include guard.
7402         * nat/x86-linux-dregs.h: Rename include guard.
7403         * nat/x86-gcc-cpuid.h: Add include guard.
7404         * nat/x86-dregs.h: Rename include guard.
7405         * nat/x86-cpuid.h: Rename include guard.
7406         * nat/ppc-linux.h: Rename include guard.
7407         * nat/mips-linux-watch.h: Rename include guard.
7408         * nat/linux-waitpid.h: Rename include guard.
7409         * nat/linux-ptrace.h: Rename include guard.
7410         * nat/linux-procfs.h: Rename include guard.
7411         * nat/linux-osdata.h: Rename include guard.
7412         * nat/linux-nat.h: Rename include guard.
7413         * nat/linux-namespaces.h: Rename include guard.
7414         * nat/linux-btrace.h: Rename include guard.
7415         * nat/glibc_thread_db.h: Rename include guard.
7416         * nat/gdb_thread_db.h: Rename include guard.
7417         * nat/gdb_ptrace.h: Rename include guard.
7418         * nat/fork-inferior.h: Rename include guard.
7419         * nat/amd64-linux-siginfo.h: Rename include guard.
7420         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7421         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7422         * nat/aarch64-linux.h: Rename include guard.
7423         * nat/aarch64-linux-hw-point.h: Rename include guard.
7424         * mn10300-tdep.h: Add include guard.
7425         * mips-linux-tdep.h: Add include guard.
7426         * mi/mi-parse.h: Rename include guard.
7427         * mi/mi-out.h: Rename include guard.
7428         * mi/mi-main.h: Rename include guard.
7429         * mi/mi-interp.h: Rename include guard.
7430         * mi/mi-getopt.h: Rename include guard.
7431         * mi/mi-console.h: Rename include guard.
7432         * mi/mi-common.h: Rename include guard.
7433         * mi/mi-cmds.h: Rename include guard.
7434         * mi/mi-cmd-break.h: Rename include guard.
7435         * m2-lang.h: Add include guard.
7436         * location.h: Rename include guard.
7437         * linux-record.h: Rename include guard.
7438         * linux-nat.h: Add include guard.
7439         * linux-fork.h: Add include guard.
7440         * i386-darwin-tdep.h: Rename include guard.
7441         * hppa-linux-offsets.h: Add include guard.
7442         * guile/guile.h: Rename include guard.
7443         * guile/guile-internal.h: Rename include guard.
7444         * gnu-nat.h: Rename include guard.
7445         * gdb-stabs.h: Rename include guard.
7446         * frv-tdep.h: Add include guard.
7447         * f-lang.h: Add include guard.
7448         * event-loop.h: Add include guard.
7449         * darwin-nat.h: Rename include guard.
7450         * cp-abi.h: Rename include guard.
7451         * config/sparc/nm-sol2.h: Rename include guard.
7452         * config/nm-nto.h: Rename include guard.
7453         * config/nm-linux.h: Add include guard.
7454         * config/i386/nm-i386gnu.h: Rename include guard.
7455         * config/djgpp/nl_types.h: Rename include guard.
7456         * config/djgpp/langinfo.h: Rename include guard.
7457         * compile/gcc-cp-plugin.h: Add include guard.
7458         * compile/gcc-c-plugin.h: Add include guard.
7459         * compile/compile.h: Rename include guard.
7460         * compile/compile-object-run.h: Rename include guard.
7461         * compile/compile-object-load.h: Rename include guard.
7462         * compile/compile-internal.h: Rename include guard.
7463         * compile/compile-cplus.h: Rename include guard.
7464         * compile/compile-c.h: Rename include guard.
7465         * common/xml-utils.h: Rename include guard.
7466         * common/x86-xstate.h: Rename include guard.
7467         * common/version.h: Rename include guard.
7468         * common/vec.h: Rename include guard.
7469         * common/tdesc.h: Rename include guard.
7470         * common/selftest.h: Rename include guard.
7471         * common/scoped_restore.h: Rename include guard.
7472         * common/scoped_mmap.h: Rename include guard.
7473         * common/scoped_fd.h: Rename include guard.
7474         * common/safe-iterator.h: Rename include guard.
7475         * common/run-time-clock.h: Rename include guard.
7476         * common/refcounted-object.h: Rename include guard.
7477         * common/queue.h: Rename include guard.
7478         * common/ptid.h: Rename include guard.
7479         * common/print-utils.h: Rename include guard.
7480         * common/preprocessor.h: Rename include guard.
7481         * common/pathstuff.h: Rename include guard.
7482         * common/observable.h: Rename include guard.
7483         * common/netstuff.h: Rename include guard.
7484         * common/job-control.h: Rename include guard.
7485         * common/host-defs.h: Rename include guard.
7486         * common/gdb_wait.h: Rename include guard.
7487         * common/gdb_vecs.h: Rename include guard.
7488         * common/gdb_unlinker.h: Rename include guard.
7489         * common/gdb_unique_ptr.h: Rename include guard.
7490         * common/gdb_tilde_expand.h: Rename include guard.
7491         * common/gdb_sys_time.h: Rename include guard.
7492         * common/gdb_string_view.h: Rename include guard.
7493         * common/gdb_splay_tree.h: Rename include guard.
7494         * common/gdb_setjmp.h: Rename include guard.
7495         * common/gdb_ref_ptr.h: Rename include guard.
7496         * common/gdb_optional.h: Rename include guard.
7497         * common/gdb_locale.h: Rename include guard.
7498         * common/gdb_assert.h: Rename include guard.
7499         * common/filtered-iterator.h: Rename include guard.
7500         * common/filestuff.h: Rename include guard.
7501         * common/fileio.h: Rename include guard.
7502         * common/environ.h: Rename include guard.
7503         * common/common-utils.h: Rename include guard.
7504         * common/common-types.h: Rename include guard.
7505         * common/common-regcache.h: Rename include guard.
7506         * common/common-inferior.h: Rename include guard.
7507         * common/common-gdbthread.h: Rename include guard.
7508         * common/common-exceptions.h: Rename include guard.
7509         * common/common-defs.h: Rename include guard.
7510         * common/common-debug.h: Rename include guard.
7511         * common/cleanups.h: Rename include guard.
7512         * common/buffer.h: Rename include guard.
7513         * common/btrace-common.h: Rename include guard.
7514         * common/break-common.h: Rename include guard.
7515         * cli/cli-utils.h: Rename include guard.
7516         * cli/cli-style.h: Rename include guard.
7517         * cli/cli-setshow.h: Rename include guard.
7518         * cli/cli-script.h: Rename include guard.
7519         * cli/cli-interp.h: Rename include guard.
7520         * cli/cli-decode.h: Rename include guard.
7521         * cli/cli-cmds.h: Rename include guard.
7522         * charset-list.h: Add include guard.
7523         * buildsym-legacy.h: Rename include guard.
7524         * bfin-tdep.h: Add include guard.
7525         * ax.h: Rename include guard.
7526         * arm-linux-tdep.h: Add include guard.
7527         * arm-fbsd-tdep.h: Add include guard.
7528         * arch/xtensa.h: Rename include guard.
7529         * arch/tic6x.h: Add include guard.
7530         * arch/i386.h: Add include guard.
7531         * arch/arm.h: Rename include guard.
7532         * arch/arm-linux.h: Rename include guard.
7533         * arch/arm-get-next-pcs.h: Rename include guard.
7534         * arch/amd64.h: Add include guard.
7535         * arch/aarch64-insn.h: Rename include guard.
7536         * arch-utils.h: Rename include guard.
7537         * annotate.h: Add include guard.
7538         * amd64-darwin-tdep.h: Rename include guard.
7539         * aarch64-linux-tdep.h: Add include guard.
7540         * aarch64-fbsd-tdep.h: Add include guard.
7541         * aarch32-linux-nat.h: Add include guard.
7542
7543 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7544
7545         * macrotab.c (macro_define_internal): New function that
7546         factorizes macro_define_object_internal and macro_define_function
7547         code.
7548         (macro_define_object_internal): Use macro_define_internal.
7549         (macro_define_function): Likewise.
7550
7551 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7552
7553         * macrocmd.c (extract_identifier): Return
7554         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7555         callers.
7556
7557 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7558
7559         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7560
7561 2019-02-05  Tom Tromey  <tom@tromey.com>
7562
7563         * target.c (target_stack::unpush): Move assertion earlier.
7564
7565 2019-01-30  Tom Tromey  <tom@tromey.com>
7566
7567         PR python/23615:
7568         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7569         (gdbpy_parse_and_eval): Likewise.
7570         * python/python-internal.h (gdbpy_allow_threads): New class.
7571
7572 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7573
7574         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7575         (aarch64_fbsd_fpregmap): Move earlier.
7576         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7577         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7578         instead of individual calls to trad_frame_set_reg_addr.
7579         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7580         earlier.
7581         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7582         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7583         instead of individual calls to trad_frame_set_reg_addr.
7584
7585 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7586
7587         * CONTRIBUTE: Replace contribution list with wiki link.
7588
7589 2019-01-25  Tom Tromey  <tom@tromey.com>
7590
7591         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7592
7593 2019-01-25  Tom Tromey  <tom@tromey.com>
7594
7595         * xtensa-linux-nat.c: Fix common/ includes.
7596         * xml-support.h: Fix common/ includes.
7597         * xml-support.c: Fix common/ includes.
7598         * x86-linux-nat.c: Fix common/ includes.
7599         * windows-nat.c: Fix common/ includes.
7600         * varobj.h: Fix common/ includes.
7601         * varobj.c: Fix common/ includes.
7602         * value.c: Fix common/ includes.
7603         * valops.c: Fix common/ includes.
7604         * utils.c: Fix common/ includes.
7605         * unittests/xml-utils-selftests.c: Fix common/ includes.
7606         * unittests/utils-selftests.c: Fix common/ includes.
7607         * unittests/unpack-selftests.c: Fix common/ includes.
7608         * unittests/tracepoint-selftests.c: Fix common/ includes.
7609         * unittests/style-selftests.c: Fix common/ includes.
7610         * unittests/string_view-selftests.c: Fix common/ includes.
7611         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7612         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7613         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7614         * unittests/rsp-low-selftests.c: Fix common/ includes.
7615         * unittests/parse-connection-spec-selftests.c: Fix common/
7616         includes.
7617         * unittests/optional-selftests.c: Fix common/ includes.
7618         * unittests/offset-type-selftests.c: Fix common/ includes.
7619         * unittests/observable-selftests.c: Fix common/ includes.
7620         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7621         * unittests/memrange-selftests.c: Fix common/ includes.
7622         * unittests/memory-map-selftests.c: Fix common/ includes.
7623         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7624         * unittests/function-view-selftests.c: Fix common/ includes.
7625         * unittests/environ-selftests.c: Fix common/ includes.
7626         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7627         * unittests/common-utils-selftests.c: Fix common/ includes.
7628         * unittests/cli-utils-selftests.c: Fix common/ includes.
7629         * unittests/array-view-selftests.c: Fix common/ includes.
7630         * ui-file.c: Fix common/ includes.
7631         * tui/tui-io.c: Fix common/ includes.
7632         * tracepoint.h: Fix common/ includes.
7633         * tracepoint.c: Fix common/ includes.
7634         * tracefile-tfile.c: Fix common/ includes.
7635         * top.h: Fix common/ includes.
7636         * top.c: Fix common/ includes.
7637         * thread.c: Fix common/ includes.
7638         * target/waitstatus.h: Fix common/ includes.
7639         * target/waitstatus.c: Fix common/ includes.
7640         * target.h: Fix common/ includes.
7641         * target.c: Fix common/ includes.
7642         * target-memory.c: Fix common/ includes.
7643         * target-descriptions.c: Fix common/ includes.
7644         * symtab.h: Fix common/ includes.
7645         * symfile.c: Fix common/ includes.
7646         * stap-probe.c: Fix common/ includes.
7647         * spu-linux-nat.c: Fix common/ includes.
7648         * sparc-nat.c: Fix common/ includes.
7649         * source.c: Fix common/ includes.
7650         * solib.c: Fix common/ includes.
7651         * solib-target.c: Fix common/ includes.
7652         * ser-unix.c: Fix common/ includes.
7653         * ser-tcp.c: Fix common/ includes.
7654         * ser-pipe.c: Fix common/ includes.
7655         * ser-base.c: Fix common/ includes.
7656         * selftest-arch.c: Fix common/ includes.
7657         * s12z-tdep.c: Fix common/ includes.
7658         * rust-exp.y: Fix common/ includes.
7659         * rs6000-aix-tdep.c: Fix common/ includes.
7660         * riscv-tdep.c: Fix common/ includes.
7661         * remote.c: Fix common/ includes.
7662         * remote-notif.h: Fix common/ includes.
7663         * remote-fileio.h: Fix common/ includes.
7664         * remote-fileio.c: Fix common/ includes.
7665         * regcache.h: Fix common/ includes.
7666         * regcache.c: Fix common/ includes.
7667         * record-btrace.c: Fix common/ includes.
7668         * python/python.c: Fix common/ includes.
7669         * python/py-type.c: Fix common/ includes.
7670         * python/py-inferior.c: Fix common/ includes.
7671         * progspace.h: Fix common/ includes.
7672         * producer.c: Fix common/ includes.
7673         * procfs.c: Fix common/ includes.
7674         * proc-api.c: Fix common/ includes.
7675         * printcmd.c: Fix common/ includes.
7676         * ppc-linux-nat.c: Fix common/ includes.
7677         * parser-defs.h: Fix common/ includes.
7678         * osdata.c: Fix common/ includes.
7679         * obsd-nat.c: Fix common/ includes.
7680         * nat/x86-linux.c: Fix common/ includes.
7681         * nat/x86-linux-dregs.c: Fix common/ includes.
7682         * nat/x86-dregs.h: Fix common/ includes.
7683         * nat/x86-dregs.c: Fix common/ includes.
7684         * nat/ppc-linux.c: Fix common/ includes.
7685         * nat/mips-linux-watch.h: Fix common/ includes.
7686         * nat/mips-linux-watch.c: Fix common/ includes.
7687         * nat/linux-waitpid.c: Fix common/ includes.
7688         * nat/linux-ptrace.h: Fix common/ includes.
7689         * nat/linux-ptrace.c: Fix common/ includes.
7690         * nat/linux-procfs.c: Fix common/ includes.
7691         * nat/linux-personality.c: Fix common/ includes.
7692         * nat/linux-osdata.c: Fix common/ includes.
7693         * nat/linux-namespaces.c: Fix common/ includes.
7694         * nat/linux-btrace.h: Fix common/ includes.
7695         * nat/linux-btrace.c: Fix common/ includes.
7696         * nat/fork-inferior.c: Fix common/ includes.
7697         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7698         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7699         * nat/aarch64-linux.c: Fix common/ includes.
7700         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7701         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7702         * namespace.h: Fix common/ includes.
7703         * mips-linux-tdep.c: Fix common/ includes.
7704         * minsyms.c: Fix common/ includes.
7705         * mi/mi-parse.h: Fix common/ includes.
7706         * mi/mi-main.c: Fix common/ includes.
7707         * mi/mi-cmd-env.c: Fix common/ includes.
7708         * memrange.h: Fix common/ includes.
7709         * memattr.c: Fix common/ includes.
7710         * maint.h: Fix common/ includes.
7711         * maint.c: Fix common/ includes.
7712         * main.c: Fix common/ includes.
7713         * machoread.c: Fix common/ includes.
7714         * location.c: Fix common/ includes.
7715         * linux-thread-db.c: Fix common/ includes.
7716         * linux-nat.c: Fix common/ includes.
7717         * linux-fork.c: Fix common/ includes.
7718         * inline-frame.c: Fix common/ includes.
7719         * infrun.c: Fix common/ includes.
7720         * inflow.c: Fix common/ includes.
7721         * inferior.h: Fix common/ includes.
7722         * inferior.c: Fix common/ includes.
7723         * infcmd.c: Fix common/ includes.
7724         * inf-ptrace.c: Fix common/ includes.
7725         * inf-child.c: Fix common/ includes.
7726         * ia64-linux-nat.c: Fix common/ includes.
7727         * i387-tdep.c: Fix common/ includes.
7728         * i386-tdep.c: Fix common/ includes.
7729         * i386-linux-tdep.c: Fix common/ includes.
7730         * i386-linux-nat.c: Fix common/ includes.
7731         * i386-go32-tdep.c: Fix common/ includes.
7732         * i386-fbsd-tdep.c: Fix common/ includes.
7733         * i386-fbsd-nat.c: Fix common/ includes.
7734         * guile/scm-type.c: Fix common/ includes.
7735         * guile/guile.c: Fix common/ includes.
7736         * go32-nat.c: Fix common/ includes.
7737         * gnu-nat.c: Fix common/ includes.
7738         * gdbthread.h: Fix common/ includes.
7739         * gdbarch-selftests.c: Fix common/ includes.
7740         * gdb_usleep.c: Fix common/ includes.
7741         * gdb_select.h: Fix common/ includes.
7742         * gdb_bfd.c: Fix common/ includes.
7743         * gcore.c: Fix common/ includes.
7744         * fork-child.c: Fix common/ includes.
7745         * findvar.c: Fix common/ includes.
7746         * fbsd-nat.c: Fix common/ includes.
7747         * event-top.c: Fix common/ includes.
7748         * event-loop.c: Fix common/ includes.
7749         * dwarf2read.c: Fix common/ includes.
7750         * dwarf2loc.c: Fix common/ includes.
7751         * dwarf2-frame.c: Fix common/ includes.
7752         * dwarf-index-cache.c: Fix common/ includes.
7753         * dtrace-probe.c: Fix common/ includes.
7754         * disasm-selftests.c: Fix common/ includes.
7755         * defs.h: Fix common/ includes.
7756         * csky-tdep.c: Fix common/ includes.
7757         * cp-valprint.c: Fix common/ includes.
7758         * cp-support.h: Fix common/ includes.
7759         * cp-support.c: Fix common/ includes.
7760         * corelow.c: Fix common/ includes.
7761         * completer.h: Fix common/ includes.
7762         * completer.c: Fix common/ includes.
7763         * compile/compile.c: Fix common/ includes.
7764         * compile/compile-loc2c.c: Fix common/ includes.
7765         * compile/compile-cplus-types.c: Fix common/ includes.
7766         * compile/compile-cplus-symbols.c: Fix common/ includes.
7767         * command.h: Fix common/ includes.
7768         * cli/cli-dump.c: Fix common/ includes.
7769         * cli/cli-cmds.c: Fix common/ includes.
7770         * charset.c: Fix common/ includes.
7771         * build-id.c: Fix common/ includes.
7772         * btrace.h: Fix common/ includes.
7773         * btrace.c: Fix common/ includes.
7774         * breakpoint.h: Fix common/ includes.
7775         * breakpoint.c: Fix common/ includes.
7776         * ax.h: 
7777         (enum agent_op): Fix common/ includes.
7778         * ax-general.c (struct aop_map): Fix common/ includes.
7779         * ax-gdb.c: Fix common/ includes.
7780         * auxv.c: Fix common/ includes.
7781         * auto-load.c: Fix common/ includes.
7782         * arm-tdep.c: Fix common/ includes.
7783         * arch/riscv.c: Fix common/ includes.
7784         * arch/ppc-linux-common.c: Fix common/ includes.
7785         * arch/i386.c: Fix common/ includes.
7786         * arch/arm.c: Fix common/ includes.
7787         * arch/arm-linux.c: Fix common/ includes.
7788         * arch/arm-get-next-pcs.c: Fix common/ includes.
7789         * arch/amd64.c: Fix common/ includes.
7790         * arch/aarch64.c: Fix common/ includes.
7791         * arch/aarch64-insn.c: Fix common/ includes.
7792         * arch-utils.c: Fix common/ includes.
7793         * amd64-windows-tdep.c: Fix common/ includes.
7794         * amd64-tdep.c: Fix common/ includes.
7795         * amd64-sol2-tdep.c: Fix common/ includes.
7796         * amd64-obsd-tdep.c: Fix common/ includes.
7797         * amd64-nbsd-tdep.c: Fix common/ includes.
7798         * amd64-linux-tdep.c: Fix common/ includes.
7799         * amd64-linux-nat.c: Fix common/ includes.
7800         * amd64-fbsd-tdep.c: Fix common/ includes.
7801         * amd64-fbsd-nat.c: Fix common/ includes.
7802         * amd64-dicos-tdep.c: Fix common/ includes.
7803         * amd64-darwin-tdep.c: Fix common/ includes.
7804         * agent.c: Fix common/ includes.
7805         * ada-lang.h: Fix common/ includes.
7806         * ada-lang.c: Fix common/ includes.
7807         * aarch64-tdep.c: Fix common/ includes.
7808
7809 2019-01-25  Tom Tromey  <tom@tromey.com>
7810
7811         * common/create-version.sh: Use common/version.h.
7812
7813 2019-01-24  Pedro Alves  <palves@redhat.com>
7814
7815         * infrun.c (signal_stop, signal_print, signal_program)
7816         (signal_catch, signal_pass): Now arrays instead of pointers.
7817         (update_signals_program_target, do_target_resume)
7818         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7819         * linux-nat.c (linux_nat_target::pass_signals)
7820         (linux_nat_target::create_inferior, linux_nat_target::attach):
7821         Adjust.
7822         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7823         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7824         * procfs.c (procfs_target::pass_signals): Adjust.
7825         * record-full.c (record_full_target::resume): Adjust.
7826         * remote.c (remote_target::pass_signals)
7827         (remote_target::program_signals): Adjust.
7828         * target-debug.h (target_debug_print_signals): Now takes a
7829         gdb::array_view as parameter.  Adjust.
7830         * target.h (target_ops) <pass_signals, program_signals>: Replace
7831         pointer and length parameters with gdb::array_view.
7832         (target_pass_signals, target_program_signals): Likewise.
7833         * target-delegates.c: Regenerate.
7834
7835 2019-01-24  Pedro Alves  <palves@redhat.com>
7836
7837         * common/forward-scope-exit.h
7838         (forward_scope_exit::forward_scope_exit): Pass arguments to
7839         m_bind_function directly, instead of creating a std::bind and
7840         copying that.
7841
7842 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7843
7844         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7845         for static members.
7846         (pass_in_v_vfp_candidate): Likewise.
7847
7848 2019-01-23  Tom Tromey  <tom@tromey.com>
7849             Pedro Alves  <palves@redhat.com>
7850
7851         * regcache.c (class regcache_invalidator): Remove.
7852         (regcache::raw_write): Use make_scope_exit.
7853
7854 2019-01-23  Tom Tromey  <tom@tromey.com>
7855
7856         * ui-out.h (class ui_out_emit_type): Update comment.
7857
7858 2019-01-23  Tom Tromey  <tom@tromey.com>
7859
7860         * infrun.c (fetch_inferior_event): Update comment.
7861
7862 2019-01-23  Tom Tromey  <tom@tromey.com>
7863             Pedro Alves  <palves@redhat.com>
7864
7865         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7866         parameter.
7867         (fetch_inferior_event): Use SCOPE_EXIT.
7868
7869
7870 2019-01-23  Tom Tromey  <tom@tromey.com>
7871             Pedro Alves  <palves@redhat.com>
7872
7873         * infrun.c (disable_thread_events): Delete.
7874         (stop_all_threads): Use SCOPE_EXIT.
7875
7876 2019-01-23  Tom Tromey  <tom@tromey.com>
7877             Pedro Alves  <palves@redhat.com>
7878
7879         * symfile.c: Include forward-scope-exit.h.
7880         (clear_symtab_users_cleanup): Replace forward declaration with
7881         a FORWARD_SCOPE_EXIT.
7882         (syms_from_objfile_1): Use the forward_scope_exit and
7883         gdb::optional instead of cleanup_function.
7884         (reread_symbols): Use the forward_scope_exit instead of
7885         cleanup_function.
7886         (clear_symtab_users_cleanup): Remove function.
7887
7888 2019-01-23  Tom Tromey  <tom@tromey.com>
7889             Pedro Alves  <palves@redhat.com>
7890
7891         * linux-nat.c: Include scope-exit.h.
7892         (cleanup_target_stop): Remove.
7893         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7894         SCOPE_EXIT.
7895
7896 2019-01-23  Tom Tromey  <tom@tromey.com>
7897             Pedro Alves  <palves@redhat.com>
7898
7899         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7900         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7901
7902 2019-01-23  Tom Tromey  <tom@tromey.com>
7903             Andrew Burgess  <andrew.burgess@embecosm.com>
7904             Pedro Alves  <palves@redhat.com>
7905
7906         * infrun.c (fetch_inferior_event): Use scope_exit.
7907         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7908         * top.c (execute_command): Use scope_exit.
7909         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7910         * utils.c (do_bpstat_clear_actions_cleanup)
7911         (make_bpstat_clear_actions_cleanup): Remove.
7912
7913 2019-01-23  Tom Tromey  <tom@tromey.com>
7914             Pedro Alves  <palves@redhat.com>
7915
7916         * infrun.c: Include "common/scope-exit.h"
7917         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7918         (wait_for_inferior): Use SCOPE_EXIT.
7919         (fetch_inferior_event): Use scope_exit.
7920
7921 2019-01-23  Tom Tromey  <tom@tromey.com>
7922             Pedro Alves  <palves@redhat.com>
7923
7924         * breakpoint.c (create_breakpoint): Remove cleanup.
7925
7926 2019-01-23  Tom Tromey  <tom@tromey.com>
7927             Andrew Burgess  <andrew.burgess@embecosm.com>
7928             Pedro Alves  <palves@redhat.com>
7929
7930 2019-01-23  Pedro Alves  <palves@redhat.com>
7931
7932         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7933
7934 2019-01-23  Pedro Alves  <palves@redhat.com>
7935             Andrew Burgess  <andrew.burgess@embecosm.com>
7936
7937         * gdbthread.h: Include "common/forward-scope-exit.h".
7938         (scoped_finish_thread_state): Redefine custom class in terms of
7939         forward_scope_exit.
7940
7941 2019-01-23  Pedro Alves  <palves@redhat.com>
7942             Andrew Burgess  <andrew.burgess@embecosm.com>
7943
7944         * common/forward-scope-exit.h: New file.
7945
7946 2019-01-23  Pedro Alves  <palves@redhat.com>
7947             Andrew Burgess  <andrew.burgess@embecosm.com>
7948             Tom Tromey  <tom@tromey.com>
7949
7950         * common/scope-exit.h: New file.
7951
7952 2019-01-23  Pedro Alves  <palves@redhat.com>
7953
7954         * common/preprocessor.h (ESC): Rename to ...
7955         (ESC_PARENS): ... this.
7956         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7957         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7958
7959 2019-01-23  Tom Tromey  <tom@tromey.com>
7960
7961         * language.h (class scoped_switch_to_sym_language_if_auto):
7962         Initialize m_lang in both cases.
7963
7964 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7965
7966         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7967         with XCNEW.
7968
7969 2019-01-22  Tom Tromey  <tom@tromey.com>
7970
7971         * corelow.c: Do not include sys/file.h.
7972
7973 2019-01-22  Tom Tromey  <tom@tromey.com>
7974
7975         * tui/tui-wingeneral.h: Include gdb_curses.h.
7976
7977 2019-01-22  Tom Tromey  <tom@tromey.com>
7978
7979         * source-cache.h (class source_cache) <get_source_lines,
7980         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7981
7982 2019-01-22  Tom Tromey  <tom@tromey.com>
7983
7984         * remote-fileio.h (struct remote_target): Declare.
7985
7986 2019-01-22  Tom Tromey  <tom@tromey.com>
7987
7988         * python/py-arch.c: Do not include py-ref.h.
7989         * python/py-bpevent.c: Do not include py-ref.h.
7990         * python/py-cmd.c: Do not include py-ref.h.
7991         * python/py-continueevent.c: Do not include py-ref.h.
7992         * python/py-event.h: Do not include py-ref.h.
7993         * python/py-evtregistry.c: Do not include py-ref.h.
7994         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7995         * python/py-frame.c: Do not include py-ref.h.
7996         * python/py-framefilter.c: Do not include py-ref.h.
7997         * python/py-function.c: Do not include py-ref.h.
7998         * python/py-infevents.c: Do not include py-ref.h.
7999         * python/py-linetable.c: Do not include py-ref.h.
8000         * python/py-objfile.c: Do not include py-ref.h.
8001         * python/py-param.c: Do not include py-ref.h.
8002         * python/py-prettyprint.c: Do not include py-ref.h.
8003         * python/py-progspace.c: Do not include py-ref.h.
8004         * python/py-symbol.c: Do not include py-ref.h.
8005         * python/py-symtab.c: Do not include py-ref.h.
8006         * python/py-type.c: Do not include py-ref.h.
8007         * python/py-unwind.c: Do not include py-ref.h.
8008         * python/py-utils.c: Do not include py-ref.h.
8009         * python/py-value.c: Do not include py-ref.h.
8010         * python/py-varobj.c: Do not include py-ref.h.
8011         * python/py-xmethods.c: Do not include py-ref.h.
8012         * python/python.c: Do not include py-ref.h.
8013         * varobj.c: Do not include py-ref.h.
8014
8015 2019-01-22  Tom Tromey  <tom@tromey.com>
8016
8017         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8018         keyword for bcache.
8019
8020 2019-01-22  Tom Tromey  <tom@tromey.com>
8021
8022         * compile/compile-cplus-types.c: Remove a comment by #include.
8023
8024 2019-01-22  Tom Tromey  <tom@tromey.com>
8025
8026         * compile/gcc-c-plugin.h: Include compile-internal.h.
8027
8028 2019-01-22  Tom Tromey  <tom@tromey.com>
8029
8030         * stabsread.c (EXTERN): Do not define.
8031         (symnum, next_symbol_text_func, processing_gcc_compilation)
8032         (within_function, global_sym_chain, global_stabs)
8033         (previous_stab_code, this_object_header_files)
8034         (n_this_object_header_files)
8035         (n_allocated_this_object_header_files): Define.
8036         * stabsread.h (EXTERN): Never define.  Use "extern".
8037
8038 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8039
8040         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8041         history_value.
8042
8043 2019-01-21  Tom Tromey  <tom@tromey.com>
8044
8045         * ui-out.c: Fix includes.
8046         * tui/tui-source.c: Fix includes.
8047         * target.c: Fix includes.
8048         * remote.c: Fix includes.
8049         * regcache.c: Fix includes.
8050         * python/py-block.c: Fix includes.
8051         * printcmd.c: Fix includes.
8052         * or1k-tdep.c: Fix includes.
8053         * mi/mi-main.c: Fix includes.
8054         * m32r-tdep.c: Fix includes.
8055         * csky-tdep.c: Fix includes.
8056         * compile/compile-cplus-types.c: Fix includes.
8057         * cli/cli-interp.c: Fix includes.
8058
8059 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8060
8061         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8062         for padding.
8063
8064 2019-01-16  Tom Tromey  <tom@tromey.com>
8065
8066         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8067         earlier.
8068         (struct objfile) <msymbols_range>: Move from top level.
8069         <msymbols>: New method.
8070         (class objfile_msymbols): Remove.
8071         * symtab.c (default_collect_symbol_completion_matches_break_on):
8072         Update.
8073         * symmisc.c (dump_msymbols): Update.
8074         * stabsread.c (scan_file_globals): Update.
8075         * objc-lang.c (info_selectors_command, info_classes_command)
8076         (find_methods): Update.
8077         * minsyms.c (find_solib_trampoline_target): Update.
8078         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8079         * coffread.c (coff_symfile_read): Update.
8080         * ada-lang.c (ada_lookup_simple_minsym)
8081         (ada_collect_symbol_completion_matches): Update.
8082
8083 2019-01-16  Tom Tromey  <tom@tromey.com>
8084
8085         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8086         type.  Remove no-argument constructor.
8087         <iterator::operator++>: Simplify.
8088         <begin>: Update.
8089         <end>: Use minimal_symbol_count.
8090
8091 2019-01-16  Tom Tromey  <tom@tromey.com>
8092
8093         * objfiles.h (struct objfile) <psymtabs>: New method.
8094         (class objfile_psymtabs): Remove.
8095         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8096         typedef.
8097         <range>: New method.
8098         (require_partial_symbols): Change return type.
8099         * psymtab.c (require_partial_symbols)
8100         (psym_expand_symtabs_matching): Update.
8101         * mdebugread.c (parse_partial_symbols): Update.
8102         * dbxread.c (dbx_end_psymtab): Update.
8103
8104 2019-01-15  Tom Tromey  <tom@tromey.com>
8105
8106         * symtab.c (lookup_objfile_from_block)
8107         (lookup_symbol_in_objfile_symtabs)
8108         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8109         (find_line_symtab, info_sources_command)
8110         (default_collect_symbol_completion_matches_break_on)
8111         (make_source_files_completion_list): Update.
8112         * symmisc.c (print_objfile_statistics, dump_objfile)
8113         (maintenance_print_symbols, maintenance_info_symtabs)
8114         (maintenance_check_symtabs, maintenance_info_line_tables):
8115         Update.
8116         * source.c (select_source_symtab)
8117         (forget_cached_source_info_for_objfile): Update.
8118         * objfiles.h (class objfile_compunits): Remove.
8119         (struct objfile) <compunits_range>: New typedef.
8120         (compunits): New method.
8121         * objfiles.c (objfile_relocate1): Update.
8122         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8123         * maint.c (count_symtabs_and_blocks): Update.
8124         * linespec.c (iterate_over_all_matching_symtabs): Update.
8125         * cp-support.c (add_symbol_overload_list_qualified): Update.
8126         * coffread.c (coff_symtab_read): Update.
8127         * ada-lang.c (add_nonlocal_symbols)
8128         (ada_collect_symbol_completion_matches)
8129         (ada_add_global_exceptions): Update.
8130
8131 2019-01-15  Tom Tromey  <tom@tromey.com>
8132
8133         * progspace.h (program_space) <objfiles_safe_range>: New
8134         typedef.
8135         <objfiles_safe>: New method.
8136         * objfiles.h (class all_objfiles_safe): Remove.
8137         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8138         * jit.c (jit_inferior_exit_hook): Update.
8139
8140 2019-01-17  Tom Tromey  <tom@tromey.com>
8141
8142         * progspace.h (program_space) <objfiles_range>: New typedef.
8143         <objfiles>: New method.
8144         <objfiles_head>: Rename from objfiles.
8145         (object_files): Update.
8146         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8147         * guile/scm-pretty-print.c
8148         (ppscm_find_pretty_printer_from_objfiles): Update.
8149         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8150         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8151         Update.
8152         * python/py-progspace.c (pspy_get_objfiles): Update.
8153         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8154         Update.
8155         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8156         (objfpy_lookup_objfile_by_build_id): Update.
8157         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8158         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8159         Update.
8160         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8161         (expand_symtab_containing_pc, lookup_objfile_from_block)
8162         (lookup_static_symbol, basic_lookup_transparent_type)
8163         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8164         (find_line_symtab, info_sources_command)
8165         (default_collect_symbol_completion_matches_break_on)
8166         (make_source_files_completion_list, find_main_name): Update.
8167         * symmisc.c (print_symbol_bcache_statistics)
8168         (print_objfile_statistics, maintenance_print_symbols)
8169         (maintenance_print_msymbols, maintenance_print_objfiles)
8170         (maintenance_info_symtabs, maintenance_check_symtabs)
8171         (maintenance_expand_symtabs, maintenance_info_line_tables):
8172         Update.
8173         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8174         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8175         (map_overlay_command, unmap_overlay_command)
8176         (simple_overlay_update, expand_symtabs_matching)
8177         (map_symbol_filenames): Update.
8178         * symfile-debug.c (set_debug_symfile): Update.
8179         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8180         Update.
8181         * source.c (select_source_symtab, forget_cached_source_info):
8182         Update.
8183         * solib.c (solib_read_symbols): Update.
8184         * solib-spu.c (append_ocl_sos): Update.
8185         * psymtab.c (maintenance_print_psymbols)
8186         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8187         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8188         * printcmd.c (info_symbol_command): Update.
8189         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8190         Update.
8191         * objfiles.h (class all_objfiles): Remove.
8192         * objfiles.c (have_partial_symbols, have_full_symbols)
8193         (have_minimal_symbols, qsort_cmp, update_section_map)
8194         (shared_objfile_contains_address_p)
8195         (default_iterate_over_objfiles_in_search_order): Update.
8196         * objc-lang.c (info_selectors_command, info_classes_command)
8197         (find_methods): Update.
8198         * minsyms.c (find_solib_trampoline_target): Update.
8199         * maint.c (maintenance_info_sections)
8200         (maintenance_translate_address, count_symtabs_and_blocks):
8201         Update.
8202         * main.c (captured_main_1): Update.
8203         * linux-thread-db.c (try_thread_db_load_from_pdir)
8204         (has_libpthread): Update.
8205         * linespec.c (iterate_over_all_matching_symtabs)
8206         (search_minsyms_for_name): Update.
8207         * jit.c (jit_find_objf_with_entry_addr): Update.
8208         * hppa-tdep.c (find_unwind_entry)
8209         (hppa_lookup_stub_minimal_symbol): Update.
8210         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8211         Update.
8212         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8213         (elf_gnu_ifunc_resolve_by_got): Update.
8214         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8215         * dwarf-index-write.c (save_gdb_index_command): Update.
8216         * cp-support.c (add_symbol_overload_list_qualified): Update.
8217         * breakpoint.c (create_overlay_event_breakpoint)
8218         (create_longjmp_master_breakpoint)
8219         (create_std_terminate_master_breakpoint)
8220         (create_exception_master_breakpoint): Update.
8221         * blockframe.c (find_pc_partial_function): Update.
8222         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8223         (ada_collect_symbol_completion_matches)
8224         (ada_add_global_exceptions): Update.
8225
8226 2019-01-17  Tom Tromey  <tom@tromey.com>
8227
8228         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8229         declare VEC.
8230         (solib_target_parse_libraries): Change return type.
8231         (library_list_start_segment, library_list_start_section)
8232         (library_list_end_library, library_list_start_library); Update.
8233         (solib_target_free_library_list): Remove.
8234         (solib_target_parse_libraries): Remove cleanup.  Change return
8235         type.
8236         (solib_target_current_sos): Update.
8237
8238 2019-01-17  Tom Tromey  <tromey@bapiya>
8239
8240         * valprint.c: Replace "the the" with "the".
8241         * symtab.c: Replace "the the" with "the".
8242         * solib.c: Replace "the the" with "the".
8243         * solib-dsbt.c: Replace "the the" with "the".
8244         * linespec.c: Replace "the the" with "the".
8245         * dwarf2loc.h: Replace "the the" with "the".
8246         * amd64-windows-tdep.c: Replace "the the" with "the".
8247         * aarch64-tdep.c: Replace "the the" with "the".
8248
8249 2019-01-16  Keith Seitz  <keiths@redhat.com>
8250
8251         PR gdb/23773
8252         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8253         <builder>: Rename to ..
8254         <m_builder>: ... this and make private.
8255         (dwarf2_cu::get_builder): New method.  Change all users of
8256         `builder' to use this method.
8257         (dwarf2_start_symtab): Move to ...
8258         (dwarf2_cu::start_symtab): ... here.  Update all callers
8259         (setup_type_unit_groups): Move to ...
8260         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8261         callers.
8262         (dwarf2_cu::reset_builder): New method.
8263         (process_full_compunit, process_full_type_unit): Use
8264         dwarf2_cu::reset_builder.
8265         (follow_die_offset): Record the ancestor CU if it is different
8266         from the followed DIE's CU.
8267         (follow_die_sig_1): Likewise.
8268
8269 2019-01-15  Tom Tromey  <tom@tromey.com>
8270
8271         * remote.c (class remote_state) <buf>: Now a char_vector.
8272         <buf_size>: Remove.
8273         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8274         parameter.
8275         (remote_target::getpkt_or_notif_sane_1)
8276         (remote_target::getpkt_sane)
8277         (remote_target::getpkt_or_notif_sane): Likewise.
8278         (class remote_target) <putpkt>: New overload.
8279         (remote_target::read_frame): Change type of "buf_p".  Remove
8280         sizeof_p parameter.
8281         (packet_ok): New overload.
8282         (packet_check_result): New overload.
8283         Update all uses.
8284
8285 2019-01-14  Tom Tromey  <tom@tromey.com>
8286
8287         * remote-notif.c (handle_notification, remote_notif_ack)
8288         (remote_notif_parse): Make "buf" const.
8289         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8290         const.
8291         (remote_notif_parse, remote_notif_ack, handle_notification):
8292         Likewise.
8293         * remote.c (remote_notif_stop_parse): Make "buf" const.
8294         (remote_target::remote_parse_stop_reply): Make "buf" const.
8295         (remote_notif_stop_ack): Make "buf" const.
8296
8297 2019-01-14  Tom Tromey  <tom@tromey.com>
8298
8299         * remote.c (remote_console_output): Make parameter const.
8300
8301 2019-01-14  Tom Tromey  <tom@tromey.com>
8302
8303         * target-debug.h (target_debug_print_signals): Constify.
8304         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8305         * procfs.c (procfs_target::pass_signals): Update.
8306         * linux-nat.c (linux_nat_target::pass_signals): Update.
8307         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8308         * target-delegates.c: Rebuild.
8309         * remote.c (remote_target::program_signals): Update.
8310         (remote_target::pass_signals): Update.
8311         * target.c (target_pass_signals): Constify argument.
8312         (target_program_signals): Likewise.
8313         * target.h (struct target_ops) <pass_signals, program_signals>:
8314         Constify argument.
8315         (target_pass_signals, target_program_signals): Constify argument.
8316
8317 2019-01-14  Tom Tromey  <tom@tromey.com>
8318
8319         PR tui/28819:
8320         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8321
8322 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8323
8324         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8325         field.
8326         * rs6000-tdep.c: Include reggroups.h.
8327         (IS_V_ALIAS_PSEUDOREG): Define.
8328         (rs6000_register_name): Return names for the "vX" aliases.
8329         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8330         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8331         aliases.  Call default_register_reggroup_p for all other
8332         pseudo-registers.
8333         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8334         New functions.
8335         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8336         Handle "vX" aliases.
8337         (v_alias_pseudo_register_collect): New function.
8338         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8339         (rs6000_gdbarch_init): Initialize "vX" aliases as
8340         pseudo-registers.  Restore registration of
8341         rs6000_pseudo_register_reggroup_p with
8342         set_tdesc_pseudo_register_reggroup_p.
8343
8344 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8345
8346         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8347         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8348         set_gdbarch_num_pseudo_regs.
8349
8350 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8351
8352         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8353         Remove arg prefixname, add do_set and do_show.
8354         Add member functions set_list and show_list.
8355         * cli/cli-style.c (class cli_style_option): Update accordingly.
8356         (style_set_list): Move to file scope.
8357         (style_show_list): Likewise.
8358         (set_style): Call help_list.
8359         (show_style): Call cmd_show_list.
8360         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8361         Update to use the new macro.
8362
8363 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8364
8365         * ada-lang.c (_initialize_ada_language): Expand the help text
8366         for the "catch exception" command.
8367
8368 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8369
8370         * symtab.c (matching_obj_sections): Initialize obj,
8371         declare it closer to its usage.
8372
8373 2019-01-10  Tom Tromey  <tom@tromey.com>
8374
8375         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8376         (basic_inf_threads_range): Remove.
8377         (inf_threads_range, inf_non_exited_threads_range)
8378         (safe_inf_threads_range): Use next_adapter.
8379
8380 2019-01-10  Keith Seitz  <keiths@redhat.com>
8381
8382         PR gdb/23712
8383         PR symtab/23010
8384         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8385         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8386
8387 2019-01-10  Keith Seitz  <keiths@redhat.com>
8388
8389         PR gdb/23712
8390         PR symtab/23010
8391         * dictionary.c (pending_to_vector): Remove.
8392         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8393         Remove _1 suffix, replacing functions of the same name.  Update
8394         all callers.
8395         (dict_create_hashed, dict_create_hashed_expandable)
8396         (dict_create_linear, dict_create_linear_expandable, dict_free)
8397         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8398         Make functions static.
8399
8400 2019-01-10  Keith Seitz  <keiths@redhat.com>
8401
8402         PR gdb/23712
8403         PR symtab/23010
8404         * dictionary.h (struct dictionary): Replace declaration with
8405         multidictionary.
8406         (dict_create_hashed, dict_create_hashed_expandable)
8407         (dict_create_linear, dict_create_linear_expandable)
8408         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8409         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8410         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8411         taking multidictionary argument.
8412         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8413         * block.h (struct block) <dict>: Change to multidictionary
8414         and rename `multidict'.
8415         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8416         symmisc.c: Update all dictionary references to multidictionary.
8417
8418 2019-01-10  Keith Seitz  <keiths@redhat.com>
8419
8420         PR gdb/23712
8421         PR symtab/23010
8422         * dictionary.c: Include unordered_map.
8423         (pending_to_vector): New function.
8424         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8425         Rewrite the non-"_1" functions to take vector instead
8426         of linked list.
8427         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8428         "new" _1 versions of the same name.
8429         (multidictionary): Define.
8430         (std::hash<enum language): New definition.
8431         (collate_pending_symbols_by_language, mdict_create_hashed)
8432         (mdict_create_hashed_expandable, mdict_create_linear)
8433         (mdict_create_linear_expandable, mdict_free)
8434         (find_language_dictionary, create_new_language_dictionary)
8435         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8436         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8437         (mdict_size, mdict_empty): New functions.
8438         * dictionary.h (mdict_iterator): Define.
8439
8440 2019-01-10  Pedro Alves  <palves@redhat.com>
8441
8442         * breakpoint.c (read_uploaded_action)
8443         (create_tracepoint_from_upload): Adjust to use
8444         gdb::unique_xmalloc_ptr.
8445         * ctf.c (ctf_write_uploaded_tp):
8446         (SET_ARRAY_FIELD): Use emplace_back.
8447         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8448         * tracefile-tfile.c (tfile_write_uploaded_tp):
8449         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8450         gdb::unique_xmalloc_ptr.
8451         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8452         at_string, cond_string, cmd_strings>: Replace char pointers
8453         with gdb::unique_xmalloc_ptr.
8454
8455 2019-01-10  Pedro Alves  <palves@redhat.com>
8456
8457         * solib-target.c (library_list_start_library): Don't xstrdup name.
8458
8459 2019-01-10  Pedro Alves  <palves@redhat.com>
8460
8461         * mdebugread.c (parse_partial_symbols): Use
8462         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8463
8464 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8465
8466         * linux-fork.c (scoped_switch_fork_info)
8467         <~scoped_switch_fork_info>: Fix incorrect variable name.
8468
8469 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8470
8471         * linux-fork.c (scoped_switch_fork_info)
8472         <scoped_switch_fork_info>: Make explicit.
8473         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8474
8475 2019-01-10  Tom Tromey  <tom@tromey.com>
8476
8477         * objfiles.h (objfile::reset_psymtabs): Update.
8478         * objfiles.c (objfile::objfile): Update.
8479         * psymtab.h (psymtab_storage::obstack): Update.
8480         (psymtab_storage::m_obstack): Use gdb::optional.
8481         (class psymtab_storage): Update comment.  Remove objfile
8482         parameter.
8483         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8484
8485 2019-01-10  Tom Tromey  <tom@tromey.com>
8486
8487         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8488         <free_psymtabs>: Now private.
8489         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8490         (allocate_psymtab): Use new method.
8491
8492 2019-01-10  Tom Tromey  <tom@tromey.com>
8493
8494         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8495         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8496         * mdebugread.c (parse_partial_symbols): Use
8497         allocate_dependencies.
8498         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8499         allocate_dependencies.
8500         (process_psymtab_comp_unit_reader)
8501         (build_type_psymtab_dependencies): Likewise.
8502         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8503
8504 2019-01-10  Tom Tromey  <tom@tromey.com>
8505
8506         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8507         PSYMBOL_SET_LANGUAGE.
8508         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8509
8510 2019-01-10  Tom Tromey  <tom@tromey.com>
8511
8512         * psymtab.h (psymtab_storage::obstack): New method.
8513         <m_obstack>: Rename from obstack; now private.
8514         * psymtab.c (psymtab_storage): Update.
8515         * dwarf2read.c (create_addrmap_from_index)
8516         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8517         Update.
8518
8519 2019-01-10  Tom Tromey  <tom@tromey.com>
8520
8521         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8522         * objfiles.h (objfile::reset_psymtabs): New method.
8523
8524 2019-01-10  Tom Tromey  <tom@tromey.com>
8525
8526         * symmisc.c (print_symbol_bcache_statistics): Update.
8527         (print_objfile_statistics): Update.
8528         * symfile.c (reread_symbols): Update.
8529         * psymtab.h (class psymtab_storage): New.
8530         * psymtab.c (psymtab_storage): New constructor.
8531         (~psymtab_storage): New destructor.
8532         (require_partial_symbols): Update.
8533         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8534         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8535         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8536         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8537         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8538         (start_psymtab_common, end_psymtab_common)
8539         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8540         (allocate_psymtab): Update.
8541         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8542         Update.
8543         (dump_psymtab_addrmap, maintenance_print_psymbols)
8544         (maintenance_check_psymtabs): Update.
8545         (class objfile_psymtabs): Move to objfiles.h.
8546         * psympriv.h (discard_psymtab): Now inline.
8547         (psymtab_discarder::psymtab_discarder): Update.
8548         (psymtab_discarder::~psymtab_discarder): Update.
8549         (ALL_OBJFILE_PSYMTABS): Rewrite.
8550         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8551         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8552         Remove fields.
8553         <partial_symtabs>: New field.
8554         (class objfile_psymtabs): Move from psymtab.h.  Update.
8555         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8556         psymbol_cache.
8557         (objfile::~objfile): Don't destroy psymbol_cache.
8558         * mdebugread.c (parse_partial_symbols): Update.
8559         * dwarf2read.c (create_addrmap_from_index)
8560         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8561         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8562         (add_partial_subprogram, dwarf2_ranges_read): Update.
8563         * dwarf-index-write.c (write_address_map)
8564         (write_one_signatured_type, recursively_write_psymbols)
8565         (class debug_names, class debug_names, write_psymtabs_to_index):
8566         Update.
8567
8568 2019-01-10  Tom Tromey  <tom@tromey.com>
8569
8570         * symtab.h (SYMBOL_SET_NAMES): Update.
8571         (symbol_set_names): Update.
8572         (MSYMBOL_SET_NAMES): Update.
8573         * symtab.c (symbol_set_names): Change argument to be an
8574         objfile_per_bfd_storage.
8575         * psymtab.c (add_psymbol_to_bcache): Update.
8576         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8577
8578 2019-01-10  Tom Tromey  <tom@tromey.com>
8579
8580         * symtab.c (create_demangled_names_hash): Change argument to be an
8581         objfile_per_bfd_storage.
8582         (symbol_set_names): Update.
8583
8584 2019-01-10  Tom Tromey  <tom@tromey.com>
8585
8586         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8587         init_psymbol_list.
8588         * psymtab.c (init_psymbol_list): Do nothing if already called.
8589         * psympriv.h (init_psymbol_list): Add comment.
8590         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8591         init_psymbol_list.
8592         * dbxread.c (dbx_symfile_read): Unconditionally call
8593         init_psymbol_list.
8594
8595 2019-01-10  Tom Tromey  <tom@tromey.com>
8596
8597         * xcoffread.c (scan_xcoff_symtab): Update.
8598         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8599         "where".
8600         * mdebugread.c (parse_partial_symbols)
8601         (handle_psymbol_enumerators): Update.
8602         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8603         * dbxread.c (read_dbx_symtab): Update.
8604         * psympriv.h (psymbol_placement): New enum.
8605         (add_psymbol_to_list): Update.
8606
8607 2019-01-10  Tom Tromey  <tom@tromey.com>
8608
8609         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8610         static_psymbols parameters.
8611         (scan_xcoff_symtab): Update.
8612         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8613         static_psymbols parameters.
8614         * psympriv.h (start_psymtab_common): Update.
8615         * mdebugread.c (parse_partial_symbols): Update.
8616         * dwarf2read.c (create_partial_symtab): Update.
8617         * dbxread.c (read_dbx_symtab): Update.
8618         (start_psymtab): Remove global_psymbols and static_psymbols
8619         parameters.
8620
8621 2019-01-10  Tom Tromey  <tom@tromey.com>
8622
8623         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8624         * psymtab.c (allocate_psymtab): Add comment.
8625         * psympriv.h (allocate_psymtab): Add comment.
8626         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8627         initializations.
8628         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8629
8630 2019-01-10  Tom Tromey  <tom@tromey.com>
8631
8632         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8633         Don't declare.
8634         * mipsread.c: Include mdebugread.h.
8635         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8636         Declare.
8637         * elfread.c: Include mdebugread.h.
8638
8639 2019-01-09  Tom Tromey  <tom@tromey.com>
8640
8641         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8642         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8643         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8644         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8645         (psym_lookup_symbol, psym_find_last_source_symtab)
8646         (psym_forget_cached_source_info, psym_print_stats)
8647         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8648         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8649         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8650         (psym_find_compunit_symtab_by_address)
8651         (maintenance_print_psymbols, maintenance_info_psymtabs)
8652         (maintenance_check_psymtabs): Use ranged for.
8653         * psymtab.h (class objfile_psymtabs): New.
8654         (require_partial_symbols): Return objfile_psymtabs.
8655         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8656
8657 2019-01-09  Tom Tromey  <tom@tromey.com>
8658
8659         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8660         (find_pc_mapped_section, list_overlays_command)
8661         (map_overlay_command, unmap_overlay_command)
8662         (simple_overlay_update): Use all_objfiles.
8663         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8664         * printcmd.c (info_symbol_command): Use all_objfiles.
8665         * objfiles.h (ALL_OBJSECTIONS): Remove.
8666         * maint.c (maintenance_translate_address): Use all_objfiles.
8667         * gcore.c (gcore_create_callback): Use all_objfiles.
8668         (objfile_find_memory_regions): Likewise.
8669
8670 2019-01-09  Tom Tromey  <tom@tromey.com>
8671
8672         * symtab.c (find_line_symtab, info_sources_command)
8673         (make_source_files_completion_list): Use objfile_compunits.
8674         * source.c (select_source_symtab): Use objfile_compunits.
8675         * objfiles.h (struct objfile): Update comment.
8676         (ALL_OBJFILES): Remove.
8677         (ALL_FILETABS): Remove.
8678         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8679         objfile_compunits.
8680
8681 2019-01-09  Tom Tromey  <tom@tromey.com>
8682
8683         * symmisc.c (print_objfile_statistics, dump_objfile)
8684         (maintenance_print_symbols): Use compunit_filetabs.
8685         * source.c (forget_cached_source_info_for_objfile): Use
8686         compunit_filetabs.
8687         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8688         (ALL_FILETABS): Use compunit_filetabs.
8689         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8690         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8691
8692 2019-01-09  Tom Tromey  <tom@tromey.com>
8693
8694         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8695         (compunit_filetabs): New.
8696         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8697         compunit_filetabs.
8698         (info_sources_command, make_source_files_completion_list): Remove
8699         declaration.
8700         * symmisc.c (print_objfile_statistics, dump_objfile)
8701         (maintenance_print_symbols): Remove declaration.
8702         (maintenance_info_symtabs): Use compunit_filetabs.
8703         (maintenance_info_line_tables): Likewise.
8704         * source.c (select_source_symtab): Change local variable name.
8705         (forget_cached_source_info_for_objfile): Remove declaration.
8706         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8707         * objfiles.c (objfile_relocate1): Remove declaration.
8708         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8709         declaration.
8710         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8711         * coffread.c (coff_symtab_read): Remove declaration.
8712         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8713         compunit_filetabs.
8714
8715 2019-01-09  Tom Tromey  <tom@tromey.com>
8716
8717         * symtab.c (lookup_objfile_from_block)
8718         (find_pc_sect_compunit_symtab, search_symbols)
8719         (default_collect_symbol_completion_matches_break_on): Use
8720         objfile_compunits.
8721         * objfiles.h (ALL_COMPUNITS): Remove.
8722         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8723         * cp-support.c (add_symbol_overload_list_qualified): Use
8724         objfile_compunits.
8725         * ada-lang.c (ada_collect_symbol_completion_matches)
8726         (ada_add_global_exceptions): Use objfile_compunits.
8727
8728 2019-01-09  Tom Tromey  <tom@tromey.com>
8729
8730         * source.c (select_source_symtab)
8731         (forget_cached_source_info_for_objfile): Remove declaration.
8732         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8733         declaration.
8734         * maint.c (count_symtabs_and_blocks): Remove declaration.
8735         * cp-support.c (add_symbol_overload_list_qualified): Remove
8736         declaration.
8737         * coffread.c (coff_symtab_read): Remove declaration.
8738         * symtab.c (lookup_symbol_in_objfile_symtabs)
8739         (basic_lookup_transparent_type_1): Use objfile_compunits.
8740         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8741         (info_sources_command, search_symbols)
8742         (default_collect_symbol_completion_matches_break_on)
8743         (make_source_files_completion_list): Remove declaration.
8744         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8745         (ada_collect_symbol_completion_matches)
8746         (ada_add_global_exceptions): Remove declaration.
8747         * linespec.c (iterate_over_all_matching_symtabs): Use
8748         objfile_compunits.
8749         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8750         (class objfile_compunits): New.
8751         (ALL_COMPUNITS): Use objfile_compunits.
8752         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8753         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8754         objfile_compunits.
8755         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8756
8757 2019-01-09  Tom Tromey  <tom@tromey.com>
8758
8759         * symtab.c (search_symbols)
8760         (default_collect_symbol_completion_matches_break_on): Use
8761         objfile_msymbols.
8762         * ada-lang.c (ada_lookup_simple_minsym)
8763         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8764         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8765         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8766         objfile_msymbols.
8767         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8768         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8769         * objc-lang.c (find_methods): Use objfile_msymbols.
8770         (info_selectors_command, info_classes_command): Likewise.
8771         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8772         * objfiles.h (class objfile_msymbols): New.
8773         (ALL_OBJFILE_MSYMBOLS): Remove.
8774         (ALL_MSYMBOLS): Remove.
8775
8776 2019-01-09  Tom Tromey  <tom@tromey.com>
8777
8778         * common/next-iterator.h (next_adapter): Add Iterator template
8779         parameter.
8780         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8781         (class all_objfiles_safe): New.
8782         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8783         * objfiles.c (put_objfile_before): Update comment.
8784         (add_separate_debug_objfile): Likewise.
8785         (free_all_objfiles): Use all_objfiles_safe.
8786         (objfile_purge_solibs): Likewise.
8787
8788 2019-01-09  Tom Tromey  <tom@tromey.com>
8789
8790         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8791         (expand_symtab_containing_pc, lookup_static_symbol)
8792         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8793         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8794         all_objfiles.
8795         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8796         * breakpoint.c (create_overlay_event_breakpoint)
8797         (create_longjmp_master_breakpoint)
8798         (create_std_terminate_master_breakpoint)
8799         (create_exception_master_breakpoint): Use all_objfiles.
8800         * linux-thread-db.c (try_thread_db_load_from_pdir)
8801         (has_libpthread): Use all_objfiles.
8802         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8803         * linespec.c (iterate_over_all_matching_symtabs)
8804         (search_minsyms_for_name): Use all_objfiles.
8805         * maint.c (maintenance_info_sections): Use all_objfiles.
8806         * main.c (captured_main_1): Use all_objfiles.
8807         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8808         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8809         * guile/scm-pretty-print.c
8810         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8811         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8812         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8813         (maintenance_print_msymbols): Use all_objfiles.
8814         * source.c (select_source_symtab): Use all_objfiles.
8815         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8816         * symfile.c (remove_symbol_file_command)
8817         (expand_symtabs_matching, map_symbol_filenames): Use
8818         all_objfiles.
8819         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8820         all_objfiles.
8821         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8822         * objc-lang.c (find_methods): Use all_objfiles.
8823         * objfiles.c (have_partial_symbols, have_full_symbols)
8824         (have_minimal_symbols, qsort_cmp)
8825         (default_iterate_over_objfiles_in_search_order): Use
8826         all_objfiles.
8827         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8828         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8829         (maintenance_check_psymtabs): Use all_objfiles.
8830         (ALL_PSYMTABS): Remove.
8831         * compile/compile-object-run.c (do_module_cleanup): Use
8832         all_objfiles.
8833         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8834         * cp-support.c (add_symbol_overload_list_qualified): Use
8835         all_objfiles.
8836         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8837         Use all_objfiles.
8838         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8839         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8840         all_objfiles.
8841         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8842         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8843         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8844         Uses all_objfiles.
8845         * solib.c (solib_read_symbols): Use all_objfiles
8846
8847 2019-01-09  Tom Tromey  <tom@tromey.com>
8848
8849         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8850         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8851         all_objfiles.
8852         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8853         * symmisc.c (print_symbol_bcache_statistics)
8854         (print_objfile_statistics, maintenance_print_objfiles)
8855         (maintenance_info_symtabs, maintenance_check_symtabs)
8856         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8857         all_objfiles.
8858         * source.c (forget_cached_source_info): Use all_objfiles.
8859         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8860         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8861         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8862         * objfiles.c (update_section_map): Use all_objfiles.
8863         (shared_objfile_contains_address_p): Likewise.
8864         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8865         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8866
8867 2019-01-09  Tom Tromey  <tom@tromey.com>
8868
8869         * common/next-iterator.h: New file.
8870         * objfiles.h (class all_objfiles): New.
8871         (struct objfile_iterator): New.
8872
8873 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8874
8875         * NEWS: Move the description of the changed "frame", "select-frame",
8876          and "info frame" commands to the Changed commands section.
8877
8878 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8879
8880         * gdbtypes.c (check_stub_method_group): Remove handling of old
8881         mangling schemes.
8882         * linespec.c (find_methods): Likewise.
8883         * stabsread.c (read_member_functions): Likewise.
8884         * valops.c (search_struct_method): Likewise.
8885         (value_struct_elt_for_reference): Likewise.
8886         * NEWS: Mention this change.
8887
8888 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8889
8890         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8891         print_source_lines.
8892         * source.c (print_source_lines_base): Update line number check.
8893         (print_source_lines): New function.
8894         (source_lines_range::source_lines_range): New function.
8895         * source.h (class source_lines_range): New class.
8896         (print_source_lines): New declaration.
8897
8898 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8899
8900         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8901
8902 2019-01-08  Tom Tromey  <tom@tromey.com>
8903             Simon Marchi  <simon.marchi@ericsson.com>
8904
8905         PR gdb/24060
8906         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8907         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8908         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8909         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8910         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8911         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8912
8913 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8914
8915         * source.c (select_source_symtab): Move header comment to
8916         declaration in source.h.
8917         (forget_cached_source_info_for_objfile): Likewise.
8918         (forget_cached_source_info): Likewise.
8919         (identify_source_line): Likewise.
8920         * source.h (identify_source_line): Move declaration from symtab.h
8921         and add comment from source.c
8922         (print_source_lines): Likewise.
8923         (forget_cached_source_info_for_objfile): Likewise.
8924         (forget_cached_source_info): Likewise.
8925         (select_source_symtab): Likewise.
8926         (enum print_source_lines_flag): Move definition from symtab.h.
8927         * symtab.h (identify_source_line): Move declaration to source.h.
8928         (print_source_lines): Likewise.
8929         (forget_cached_source_info_for_objfile): Likewise.
8930         (forget_cached_source_info): Likewise.
8931         (select_source_symtab): Likewise.
8932         (enum print_source_lines_flag): Move definition to source.h.
8933         * tui/tui-hooks.c: Add 'source.h' include.
8934
8935 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8936
8937         * source.c (print_source_lines_base): Handle requests to print
8938         reverse line number sequences, and guard against empty lines
8939         string.
8940
8941 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8942
8943         * source.c (print_source_lines_base): Fix skip of '\r' if next
8944         character is '\n'.
8945
8946 2019-01-06  Tom Tromey  <tom@tromey.com>
8947
8948         * c-exp.y (struct c_parse_state) <macro_original_text,
8949         expansion_obstack>: New member.
8950         (macro_original_text, expansion_obstack): Remove globals.
8951         (scan_macro_expansion, scanning_macro_expansion)
8952         (finished_macro_expansion): Update.
8953         (scan_macro_cleanup): Remove.
8954         (yylex, c_parse): Update.
8955
8956 2019-01-06  Tom Tromey  <tom@tromey.com>
8957
8958         * c-exp.y (struct c_parse_state) <strings>: New member.
8959         (operator_stoken): Update.
8960
8961 2019-01-06  Tom Tromey  <tom@tromey.com>
8962
8963         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8964         (union type_stack_elt) <typelist_val>: Now a pointer to
8965         std::vector.
8966         (type_stack_cleanup): Don't declare.
8967         (push_typelist): Update.
8968         * parse.c (pop_typelist): Return a std::vector.
8969         (push_typelist): Take a std::vector.
8970         (follow_types): Update.  Do not free args.
8971         (type_stack_cleanup): Remove.
8972         * c-exp.y (struct c_parse_state): New.
8973         (cpstate): New global.
8974         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8975         (nonempty_typelist): Update.
8976         (func_mod): Create a new vector.
8977         (c_parse): Create a c_parse_state.
8978         (check_parameter_typelist): Do not delete params.
8979         (function_method): Update.  Do not delete type_list.
8980
8981 2019-01-06  Tom Tromey  <tom@tromey.com>
8982
8983         PR gdb/28155:
8984         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8985         check_typedef.
8986         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8987         (print_return_value): Likewise.
8988
8989 2019-01-05  Tom Tromey  <tom@tromey.com>
8990
8991         * contrib/cleanup_check.py: Remove.
8992         * contrib/gcc-with-excheck: Remove.
8993         * contrib/exsummary.py: Remove.
8994         * contrib/excheck.py: Remove.
8995
8996 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8997
8998         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8999         NULL. Initialize tpprev to NULL instead of assigning it
9000         to NULL on the next statement.
9001         * windows-nat.c (windows_delete_thread): Remove check for
9002         main_thread_id before printing thread exit notifications.
9003         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9004         Remove thread ID check against main_thread_id.
9005         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9006         windows_delete_thread.
9007         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9008
9009 2019-01-04  Tom Tromey  <tom@tromey.com>
9010
9011         * compile/compile.c (_initialize_compile): Use upper case for
9012         metasyntactic variables.
9013         * symmisc.c (_initialize_symmisc): Use upper case for
9014         metasyntactic variables.
9015         * psymtab.c (_initialize_psymtab): Use upper case for
9016         metasyntactic variables.
9017         * demangle.c (demangle_command): Use upper case for metasyntactic
9018         variables.
9019         (_initialize_demangler): Likewise.
9020         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9021         variables.
9022
9023 2019-01-03  Tom Tromey  <tom@tromey.com>
9024
9025         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9026
9027 2019-01-03  Tom Tromey  <tom@tromey.com>
9028
9029         * python/py-symtab.c (salpy_str): Update.
9030         (struct salpy_sal_object) <symtab>: Now a PyObject.
9031         (salpy_dealloc): Update.
9032         (del_objfile_sal): Use gdbpy_ref.
9033
9034 2019-01-03  Tom Tromey  <tom@tromey.com>
9035
9036         * python/py-type.c (convert_field): Use new_reference.  Return
9037         gdbpy_ref.
9038         (make_fielditem): Return gdbpy_ref.
9039         (typy_fields): Update.
9040         (typy_getitem): Update.
9041         (field_name): Return gdbpy_ref.  Use new_reference.
9042         (typy_iterator_iternext): Update.
9043
9044 2019-01-03  Tom Tromey  <tom@tromey.com>
9045
9046         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9047
9048 2019-01-03  Tom Tromey  <tom@tromey.com>
9049
9050         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9051         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9052         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9053         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9054         (pspy_set_type_printers): Likewise.
9055         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9056         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9057         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9058         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9059         (objfpy_set_type_printers): Likewise.
9060
9061 2019-01-03  Tom Tromey  <tom@tromey.com>
9062
9063         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9064         (gdbpy_print_stack): Use gdbpy_err_fetch.
9065         * python/python-internal.h (class gdbpy_err_fetch): New class.
9066         (class gdbpy_enter) <m_error_type, m_error_value,
9067         m_error_traceback>: Remove.
9068         <m_error>: New member.
9069         (gdbpy_exception_to_string): Don't declare.
9070         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9071         * python/py-value.c (convert_value_from_python): Use
9072         gdbpy_err_fetch.
9073         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9074         gdbpy_exception_to_string.
9075         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9076         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9077         gdbpy_err_fetch.
9078
9079 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9080
9081         * linux-nat.c (delete_lwp_cleanup): Delete.
9082         (struct lwp_deleter): New struct.
9083         (lwp_info_up): New typedef.
9084         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9085         lwp_info_up.
9086
9087 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9088
9089         * linux-fork.c (class scoped_switch_fork_info): New class.
9090         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9091
9092 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9093
9094         * valops.c (find_overload_match): Remove use of null_cleanup, and
9095         calls to do_cleanups.
9096
9097 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9098
9099         * compile/compile-cplus-types.c
9100         (compile_cplus_instance::decl_name): Handle changes to
9101         cp_func_name.
9102         * cp-support.c (cp_func_name): Update header comment, update
9103         return type.
9104         * cp-support.h (cp_func_name): Update return type in declaration.
9105         * valops.c (find_overload_match): Move temp_func local to top
9106         level of function and change its type.  Use temp_func to hold and
9107         delete temporary string obtained from cp_func_name.
9108
9109 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9110
9111         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9112         gdb::char_vector, remove cleanup, and update uses of `msg`.
9113
9114 2019-01-03  Jim Wilson  <jimw@sifive.com>
9115
9116         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9117
9118 2019-01-02  Tom Tromey  <tom@tromey.com>
9119
9120         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9121         (tdesc_parse_xml): Remove cleanups.
9122         * target-descriptions.h (make_cleanup_free_target_description):
9123         Don't declare.
9124         (target_desc_deleter): New struct.
9125         (target_desc_up): New typedef.
9126         * target-descriptions.c (target_desc_deleter::operator()): Rename
9127         from free_target_description.
9128         (make_cleanup_free_target_description): Remove.
9129
9130 2019-01-02  Tom Tromey  <tom@tromey.com>
9131
9132         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9133         constructor, destructor.
9134         (linespec_parser): Remove typedef.
9135         (~linespec_parser): Rename from linespec_parser_delete.
9136         (linespec_lex_to_end, linespec_complete_label)
9137         (linespec_complete): Update.
9138         (decode_line_full): Remove cleanups.
9139         (decode_line_1): Update.
9140
9141 2019-01-02  Tom Tromey  <tom@tromey.com>
9142
9143         * python/python-internal.h (inferior_to_inferior_object): Change
9144         return type.
9145         * python/py-exitedevent.c (create_exited_event_object): Update.
9146         * python/py-inferior.c (inferior_to_inferior_object): Return
9147         gdbpy_ref.
9148         (python_new_inferior, python_inferior_deleted)
9149         (thread_to_thread_object, delete_thread_object)
9150         (build_inferior_list, gdbpy_selected_inferior): Update.
9151         * python/py-infthread.c (create_thread_object): Update.  Also fail
9152         if inferior_to_inferior_object fails.
9153
9154 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9155
9156         * inferior.h (class inferior) <displaced_step_state>: New field.
9157         * infrun.h (struct displaced_step_state): Move here from
9158         infrun.c.  Initialize fields, add constructor.
9159         <inf>: Remove field.
9160         <reset>: New method.
9161         * infrun.c (struct displaced_step_inferior_state): Move to
9162         infrun.h.
9163         (displaced_step_inferior_states): Remove.
9164         (get_displaced_stepping_state): Adust.
9165         (displaced_step_in_progress_any_inferior): Adjust.
9166         (displaced_step_in_progress_thread): Adjust.
9167         (displaced_step_in_progress): Adjust.
9168         (add_displaced_stepping_state): Remove.
9169         (get_displaced_step_closure_by_addr): Adjust.
9170         (remove_displaced_stepping_state): Remove.
9171         (infrun_inferior_exit): Call displaced_step_state.reset.
9172         (use_displaced_stepping): Don't check for NULL.
9173         (displaced_step_prepare_throw): Call
9174         get_displaced_stepping_state.
9175         (displaced_step_fixup): Don't check for NULL.
9176         (prepare_for_detach): Don't check for NULL.
9177
9178 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9179
9180         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9181          in case of call that did not complete.
9182
9183 2019-01-02  Andrey Utkin  <autkin@undo.io>
9184
9185         * symfile.c (find_separate_debug_file): Fix search of debug files for
9186         remote debuggee.
9187
9188 2019-01-02  Tom Tromey  <tom@tromey.com>
9189
9190         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9191         indentation.
9192         * python/py-frame.c (frapy_older): Remove cast.
9193         (frapy_newer): Likewise.
9194         * python/py-breakpoint.c (local_setattro): Remove cast.
9195         * python/py-arch.c (archpy_name): Remove local variable.
9196         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9197
9198 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9199
9200         * unittests/basic_string_view/element_access/char/empty.cc:
9201         Fix year range in copyright header.
9202
9203 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9204
9205         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9206         Delete.
9207         <operator==>: Update with for removed field.
9208         <hash>: Likewise.
9209         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9210         <isa_features>: ...this.
9211         <abi_features>: New field.
9212         (riscv_isa_flen): Update comment.
9213         (riscv_abi_xlen): New declaration.
9214         (riscv_abi_flen): New declaration.
9215         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9216         isa_features.
9217         (riscv_abi_xlen): New function.
9218         (riscv_isa_flen): Update to get answer from isa_features.
9219         (riscv_abi_flen): New function.
9220         (riscv_has_fp_abi): Update to get answer from abi_features.
9221         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9222         xlen and flen.
9223         (riscv_call_info) <xlen, flen>: Update comment.
9224         (riscv_call_arg_struct): Remove invalid assertions
9225         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9226         is removed.
9227         (riscv_gdbarch_init): Gather isa features and abi features
9228         separately, ensure both match on the gdbarch when reusing an old
9229         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9230         a target with 64-bit float hardware.
9231
9232 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9233
9234         * source.c (search_command_helper): Stop reverse search
9235         when line 1 has been searched.
9236
9237 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9238
9239         * record-full.c (record_full_base_target::close): Rewrite
9240         record_full_core_buf_list free logic.
9241
9242 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9243
9244         * break-catch-syscall.c (print_one_catch_syscall): xfree
9245         the last text.
9246
9247 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9248
9249         * top.c (print_gdb_version): Update Copyright year in version
9250         message.
9251
9252 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9253
9254         Update copyright year range in all GDB files.
9255
9256 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9257
9258         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9259
9260 For older changes see ChangeLog-2018.
9261 \f
9262 Local Variables:
9263 mode: change-log
9264 left-margin: 8
9265 fill-column: 74
9266 version-control: never
9267 coding: utf-8
9268 End:
9269