gdb/ChangeLog

   1 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * cli/cli-utils.c (extract_info_print_args): Delete.
   4         (extract_arg_maybe_quoted): Delete.
   5         (info_print_options_defs): New variable.
   6         (make_info_print_options_def_group): New function.
   7         (extract_info_print_options): Define new function.
   8         * cli/cli-utils.h (extract_info_print_args): Delete.
   9         (struct info_print_options): New structure.
  10         (extract_info_print_options): Declare new function.
  11         * stack.c (info_locals_command): Update to use new
  12         extract_info_print_options, also add a header comment.
  13         (info_args_command): Likewise.
  14         * symtab.c (info_variables_command): Likewise.
  15         (info_functions_command): Likewise.
  16
  17 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  18
  19         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
  20         to extract string arguments.
  21         * common/common-utils.c (extract_string_maybe_quoted): New function.
  22         * common/common-utils.h (extract_string_maybe_quoted): Declare.
  23
  24 2019-07-11  Tom Tromey  <tromey@adacore.com>
  25
  26         * main.c (get_init_files): Use GDBINIT, not gdbinit.
  27         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
  28         * top.h (gdbinit): Don't declare.
  29         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
  30         into...
  31         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
  32         * top.c (gdb_init): Don't call init_cli_cmds.
  33         (gdbinit): Remove.
  34         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
  35
  36 2019-07-11  Tom Tromey  <tromey@adacore.com>
  37
  38         * python/py-inferior.c (add_thread_object): Don't use thread_obj
  39         after it has been moved.
  40
  41 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  42
  43         * valops.c (value_must_coerce_to_target): Change return type to
  44         bool.
  45         * value.h (value_must_coerce_to_target): Likewise.
  46
  47 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
  48
  49         * breakpoint.c (is_hardware_watchpoint): Remove
  50         forward-declaration.
  51         (is_masked_watchpoint): Change return type to bool.
  52         (is_tracepoint): Likewise.
  53         (is_breakpoint): Likewise.
  54         (is_hardware_watchpoint): Likewise.
  55         (is_watchpoint): Likewise.
  56         (is_no_memory_software_watchpoint): Likewise.
  57         (is_catchpoint): Likewise.
  58         (breakpoint_1): Make FILTER parameter's return type bool.
  59         is_masked_watchpoint): Change return type to bool.
  60         (save_breakpoints): Make FILTER parameter's return type bool.
  61         * breakpoint.h (is_breakpoint): Change return type to bool.
  62         (is_watchpoint): Likewise.
  63         (is_catchpoint): Likewise.
  64         (is_tracepoint): Likewise.
  65
  66 2019-07-10  Tom Tromey  <tom@tromey.com>
  67
  68         * defs.h: Don't include gdbarch.h.
  69         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
  70         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
  71         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
  72         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
  73         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
  74         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
  75         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
  76         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
  77         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
  78         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
  79         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
  80         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
  81         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
  82         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
  83         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
  84         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
  85         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
  86         record-btrace.c, record.h, regcache-dump.c, regcache.h,
  87         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
  88         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
  89         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
  90         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
  91         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
  92         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
  93         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
  94         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
  95         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
  96
  97 2019-07-10  Tom Tromey  <tromey@adacore.com>
  98
  99         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 100         * breakpoint.c (init_ada_exception_breakpoint): Register as
 101         bp_catchpoint.
 102         (print_one_breakpoint_location, print_one_breakpoint): Use
 103         is_ada_exception_catchpoint.
 104         * ada-lang.c (class ada_catchpoint_location): Pass
 105         bp_loc_software_breakpoint to bp_location constructor.
 106         (is_ada_exception_catchpoint): New function.
 107
 108 2019-07-10  Tom Tromey  <tromey@adacore.com>
 109
 110         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 111         VEC.
 112         (struct arm_exidx_entry): New method operator<.
 113         (struct arm_exidx_data) <section_maps>: Change type.
 114         (arm_exidx_data_free): Remove.
 115         (arm_exidx_data_key): Change type.  Move lower.
 116         (arm_exidx_new_objfile): Update.
 117         (arm_compare_exidx_entries): Remove.
 118         (arm_find_exidx_entry, _initialize_arm_tdep)
 119
 120 2019-07-10  Tom Tromey  <tromey@adacore.com>
 121
 122         * solib-spu.c (ocl_program_data_key): Change type.
 123         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 124         Update.
 125
 126 2019-07-10  Tom Tromey  <tromey@adacore.com>
 127
 128         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 129         (struct solib_aix_inferior_data) <library_list>: Change type.
 130         (solib_aix_inferior_data_handle): Change type.
 131         (get_solib_aix_inferior_data): Update.
 132         (solib_aix_free_library_list): Remove.
 133         (library_list_start_library): Update.
 134         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 135         return type.
 136         (solib_aix_get_library_list)
 137         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 138         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 139
 140 2019-07-10  Tom Tromey  <tromey@adacore.com>
 141
 142         * solib-dsbt.c (struct dsbt_info): Add initializers.
 143         (solib_dsbt_pspace_data): Change type.
 144         (dsbt_pspace_data_cleanup): Remove.
 145         (get_dsbt_info, _initialize_dsbt_solib): Update.
 146
 147 2019-07-10  Tom Tromey  <tromey@adacore.com>
 148
 149         * spu-tdep.c (spu_overlay_data): Change type.
 150         (spu_get_overlay_table, spu_overlay_new_objfile)
 151         (_initialize_spu_tdep): Update.
 152
 153 2019-07-10  Tom Tromey  <tromey@adacore.com>
 154
 155         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 156         destructor.
 157         (dbx_objfile_data_key): Change type and declare later.
 158         (DBX_SYMFILE_INFO): Rewrite.
 159         * dbxread.c (dbx_objfile_data_key): Change type.
 160         (dbx_symfile_init): Update.
 161         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 162         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 163         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 164
 165 2019-07-10  Tom Tromey  <tromey@adacore.com>
 166
 167         * jit.c (jit_program_space_key): Change type.  Move lower.
 168         (get_jit_program_space_data): Update.
 169         (jit_program_space_data_cleanup): Remove.
 170         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 171         Update.
 172         (struct jit_program_space_data): Add initializers.
 173
 174 2019-07-10  Tom Tromey  <tromey@adacore.com>
 175
 176         * solib-darwin.c (struct darwin_info): Add initializers.
 177         (solib_darwin_pspace_data): Change type.
 178         (darwin_pspace_data_cleanup): Remove.
 179         (get_darwin_info, _initialize_darwin_solib): Update.
 180
 181 2019-07-10  Tom Tromey  <tromey@adacore.com>
 182
 183         * remote-sim.c (struct sim_inferior_data): Add initializers,
 184         constructor, and destructor.
 185         (sim_inferior_data_key): Change type.  Move lower.
 186         (check_for_duplicate_sim_descriptor): Update.
 187         (get_sim_inferior_data): Use new.  Update.
 188         (~sim_inferior_data_cleanup): Rename from
 189         sim_inferior_data_cleanup.  Simplify.
 190         (gdbsim_close_inferior, simulator_command)
 191         (sim_command_completer, _initialize_remote_sim): Update.
 192         (next_pid, INITIAL_PID): Move earlier.
 193
 194 2019-07-10  Tom Tromey  <tromey@adacore.com>
 195
 196         * python/python-internal.h (create_thread_object): Return
 197         gdbpy_ref.
 198         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 199         * python/py-inferior.c (struct threadlist_entry): Add
 200         constructor.
 201         <thread_obj>: Now a gdbpy_ref.
 202         (thread_to_thread_object): Update.
 203         (add_thread_object): Use new.
 204         (delete_thread_object): Use delete.
 205         (infpy_threads): Update.
 206         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 207         GIL.
 208
 209 2019-07-10  Tom Tromey  <tromey@adacore.com>
 210
 211         * valops.c (value_cast): Specialize error message for Ada.
 212
 213 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 214
 215         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 216
 217 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 218
 219         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 220         bpstat_should_step): Return bool, adjust comments.
 221         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 222         bpstat_should_step): Likewise.
 223
 224 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 225
 226         * features/Makefile: Use feature target descriptions for Arm.
 227         * features/arm/arm-core.c: Generate new file.
 228         * features/arm/arm-fpa.c: Likewise.
 229         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 230         * features/arm/arm-m-profile.c: Likewise.
 231         * features/arm/arm-vfpv2.c: Likewise.
 232         * features/arm/arm-vfpv3.c: Likewise.
 233         * features/arm/xscale-iwmmxt.c: Likewise.
 234         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 235
 236 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 237
 238         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 239         ptrace earlier.
 240
 241 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 242
 243         * features/aarch64-pauth.c: Regenerate.
 244
 245 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 246
 247         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 248         bool.
 249         (bpstat_what): Use false instead of 0.
 250
 251 2019-07-09  Pedro Alves  <palves@redhat.com>
 252
 253         * break-catch-throw.c (is_exception_catchpoint): New.
 254         * breakpoint.c (print_one_breakpoint_location): New parameter
 255         'raw_loc'.  Handle it.  Use
 256         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 257         looking at the breakpoint's type.
 258         (print_one_breakpoint): If handling "maint info breakpoints", also
 259         print locations of exception catchpoints.
 260         * breakpoint.h (is_exception_catchpoint): Declare.
 261
 262 2019-07-09  Pedro Alves  <palves@redhat.com>
 263
 264         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 265         "addr" field.
 266         (allocate_location_exception_catchpoint): New.
 267         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 268         (initialize_throw_catchpoint_ops): Install
 269         allocate_location_exception_catchpoint as allocate_location
 270         method.
 271         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 272         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 273         bp_loc_other.
 274         (breakpoint_address_is_meaningful): Delete.
 275         (bl_address_is_meaningful): New.
 276         (breakpoint_locations_match): Adjust comment.
 277         (bp_location_from_bp_type): New, factored out of...
 278         (bp_location::bp_location(breakpoint *)): ... this.
 279         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 280         factored out of...
 281         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 282         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 283         breakpoint_address_is_meaningful.
 284         (bp_locations_compare): Adjust comment.
 285         (update_global_location_list): Use bl_address_is_meaningful
 286         instead of breakpoint_address_is_meaningful.
 287         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 288         explicit.
 289         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 290         * python/py-breakpoint.c (bppy_get_location): No longer check
 291         whether location is null.
 292
 293 2019-07-09  Pedro Alves  <palves@redhat.com>
 294
 295         PR c++/15468
 296         * breakpoint.c (print_one_breakpoint_location): Remove
 297         single-location assert.
 298
 299 2019-07-09  Tom Tromey  <tom@tromey.com>
 300
 301         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 302         * configure: Rebuild.
 303         * configure.ac: Change common to gdbsupport.
 304         * gdbsupport: Rename from common.
 305         * acinclude.m4: Change common to gdbsupport.
 306         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 307         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 308         gdbsupport.
 309         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 310         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 311         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 312         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 313         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 314         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 315         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 316         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 317         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 318         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 319         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 320         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 321         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 322         coff-pe-read.c, command.h, compile/compile-c-support.c,
 323         compile/compile-c.h, compile/compile-cplus-symbols.c,
 324         compile/compile-cplus-types.c, compile/compile-cplus.h,
 325         compile/compile-loc2c.c, compile/compile.c, completer.c,
 326         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 327         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 328         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 329         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 330         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 331         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 332         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 333         features/aarch64-core.c, features/aarch64-fpu.c,
 334         features/aarch64-pauth.c, features/aarch64-sve.c,
 335         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 336         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 337         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 338         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 339         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 340         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 341         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 342         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 343         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 344         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 345         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 346         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 347         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 348         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 349         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 350         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 351         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 352         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 353         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 354         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 355         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 356         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 357         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 358         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 359         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 360         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 361         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 362         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 363         minsyms.c, mips-linux-tdep.c, namespace.h,
 364         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 365         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 366         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 367         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 368         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 369         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 370         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 371         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 372         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 373         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 374         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 375         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 376         procfs.c, producer.c, progspace.h, psymtab.h,
 377         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 378         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 379         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 380         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 381         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 382         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 383         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 384         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 385         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 386         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 387         target-memory.c, target.c, target.h, target/waitstatus.c,
 388         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 389         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 390         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 391         unittests/array-view-selftests.c,
 392         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 393         unittests/common-utils-selftests.c,
 394         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 395         unittests/format_pieces-selftests.c,
 396         unittests/function-view-selftests.c,
 397         unittests/lookup_name_info-selftests.c,
 398         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 399         unittests/mkdir-recursive-selftests.c,
 400         unittests/observable-selftests.c,
 401         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 402         unittests/parse-connection-spec-selftests.c,
 403         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 404         unittests/scoped_fd-selftests.c,
 405         unittests/scoped_mmap-selftests.c,
 406         unittests/scoped_restore-selftests.c,
 407         unittests/string_view-selftests.c, unittests/style-selftests.c,
 408         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 409         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 410         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 411         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 412         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 413         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 414
 415 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 416
 417         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 418         bool value.
 419         (decode_digits_ordinary): Set explicit_line field in sal.
 420         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 421         symtab_and_line that was set on an explicit line number in
 422         assembler code.  Do always update the recorded symtab and line if
 423         we do skip the prologue.
 424
 425 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 426
 427         * breakpoint.c (set_breakpoint_location_function): Remove
 428         explicit_loc parameter.
 429         (momentary_breakpoint_from_master): Update call to
 430         set_breakpoint_location_function.
 431         (add_location_to_breakpoint): Likewise.
 432
 433 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 434
 435         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 436         required features based on default bfd type when no specific bfd
 437         is present.
 438
 439 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 440
 441         * NEWS: Mention that GDB printf and eval commands can now print
 442         C-style and Ada-style convenience var strings without
 443         calling the inferior.
 444         * printcmd.c (printf_c_string): Locally print GDB internal var
 445         instead of transiting via the inferior.
 446         (printf_wide_c_string): Likewise.
 447
 448 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 449
 450         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 451
 452 2019-07-04  Tom Tromey  <tom@tromey.com>
 453
 454         PR tui/24724:
 455         * tui/tui-winsource.c (tui_clear_source_content): Update.
 456         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 457         (tui_update_breakpoint_info): Update.
 458         (tui_set_exec_info_content): Update.
 459         * tui/tui-source.c (tui_set_source_content_nil): Update.
 460         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 461         has_break.
 462         * tui/tui-data.h (enum tui_bp_flag): New.
 463         (tui_bp_flags): New enum flags type.
 464         (struct tui_source_element) <break_mode>: Change type.  Rename
 465         from has_break.
 466         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 467         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 468         constants.
 469         * tui/tui-winsource.h: Fix comment.
 470
 471 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 472
 473         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 474         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 475         (store_fpregs_to_thread)
 476         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 477         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 478         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 479         (IWMMXT_REGS_SIZE): Add define.
 480         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 481         (fetch_vfp_regs, store_vfp_regs)
 482         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 483         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 484
 485 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 486
 487         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 488         defines.
 489         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 490         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 491         (ARM_INT_REGISTER_SIZE): ...to this.
 492         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 493         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 494         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 495         (arm_linux_collect_gregset, supply_nwfpe_register)
 496         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 497         defines.
 498         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 499         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 500         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 501         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 502         (arm_return_in_memory, arm_store_return_value)
 503         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 504         (arm_record_ld_st_multiple): Likewise.
 505         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 506         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 507
 508 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 509
 510         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 511         AARCH64_DISPLACED_MODIFIED_INSNS.
 512         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 513         (aarch64_displaced_step_copy_insn): Likewise.
 514         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 515         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 516         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 517         ARM_DISPLACED_MODIFIED_INSNS.
 518         * arm-tdep.c (arm_gdbarch_init): Likewise.
 519         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 520         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 521         (struct arm_displaced_step_closure): Use
 522         ARM_DISPLACED_MODIFIED_INSNS.
 523
 524 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 525
 526         * features/Makefile: Remove unused xml files.
 527         * features/aarch64.xml: Remove.
 528         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 529         * features/i386/amd64-avx-avx512.xml: Remove.
 530         * features/i386/amd64-avx-linux.xml: Remove.
 531         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 532         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 533         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 534         * features/i386/amd64-avx-mpx.xml: Remove.
 535         * features/i386/amd64-avx.xml: Remove.
 536         * features/i386/amd64-linux.xml: Remove.
 537         * features/i386/amd64-mpx-linux.xml: Remove.
 538         * features/i386/amd64-mpx.xml: Remove.
 539         * features/i386/amd64.xml: Remove.
 540         * features/i386/i386-avx-avx512-linux.xml: Remove.
 541         * features/i386/i386-avx-avx512.xml: Remove.
 542         * features/i386/i386-avx-linux.xml: Remove.
 543         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 544         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 545         * features/i386/i386-avx-mpx-linux.xml: Remove.
 546         * features/i386/i386-avx-mpx.xml: Remove.
 547         * features/i386/i386-avx.xml: Remove.
 548         * features/i386/i386-linux.xml: Remove.
 549         * features/i386/i386-mmx-linux.xml: Remove.
 550         * features/i386/i386-mmx.xml: Remove.
 551         * features/i386/i386-mpx-linux.xml: Remove.
 552         * features/i386/i386-mpx.xml: Remove.
 553         * features/i386/i386.xml: Remove.
 554         * features/i386/x32-avx-avx512-linux.xml: Remove.
 555         * features/i386/x32-avx-linux.xml: Remove.
 556         * features/i386/x32-linux.xml: Remove.
 557
 558 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 559
 560         * regformats/aarch64.dat: Remove.
 561         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 562         * regformats/i386/amd64-avx-linux.dat: Remove.
 563         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 564         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 565         * regformats/i386/amd64-linux.dat: Remove.
 566         * regformats/i386/amd64-mpx-linux.dat: Remove.
 567         * regformats/i386/amd64.dat: Remove.
 568         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 569         * regformats/i386/i386-avx-linux.dat: Remove.
 570         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 571         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 572         * regformats/i386/i386-linux.dat: Remove.
 573         * regformats/i386/i386-mmx-linux.dat: Remove.
 574         * regformats/i386/i386-mpx-linux.dat: Remove.
 575         * regformats/i386/i386.dat: Remove.
 576         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 577         * regformats/i386/x32-avx-linux.dat: Remove.
 578         * regformats/i386/x32-linux.dat: Remove.
 579
 580 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 581
 582         * aarch64-tdep.c: Remove xml self tests.
 583         * amd64-linux-tdep.c: Likewise.
 584         * amd64-tdep.c: Likewise.
 585         * i386-linux-tdep.c: Likewise.
 586         * i386-tdep.c: Likewise.
 587
 588 2019-07-03  Pedro Alves  <palves@redhat.com>
 589
 590         PR cli/24732
 591         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 592         (pipe_cmd_option_defs): New.
 593         (make_pipe_cmd_options_def_group): New.
 594         (pipe_command): Use gdb::option::process_options.
 595         (pipe_command_completer): New function.
 596         (_initialize_cli_cmds): Install completer for "pipe" command.
 597
 598 2019-07-03  Pedro Alves  <palves@redhat.com>
 599
 600         * cli/cli-option.c (union option_value) <string>: New field.
 601         (struct option_def_and_value): Add ctor, move ctor, dtor and
 602         use DISABLE_COPY_AND_ASSIGN.
 603         (option_def_and_value::clear_value): New.
 604         (parse_option, save_option_value_in_ctx, get_val_type_str)
 605         (add_setshow_cmds_for_options): Handle var_string.
 606         * cli-option.h (union option_def::var_address) <string>: New
 607         field.
 608         (struct string_option_def): New.
 609         * maint-test-options.c (struct test_options_opts): Add default
 610         ctor and use DISABLE_COPY_AND_ASSIGN.
 611         <string_opt>: New field.
 612         (test_options_opts::~test_options_opts): New.
 613         (test_options_opts::dump): Also dump "-string".
 614         (test_options_option_defs): Install "string.
 615
 616 2019-07-03  Pedro Alves  <palves@redhat.com>
 617
 618         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 619         option_value with a null enumeration.
 620         (complete_options): Save the option values in the context.
 621         (save_option_value_in_ctx): New, factored out from ...
 622         (process_options): ... here.
 623         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 624         of the function.
 625         * maint-test-options.c (test_options_opts::dump): New, factored
 626         out from ...
 627         (maintenance_test_options_command_mode): ... here.
 628         (maintenance_test_options_command_completion_result): Delete.
 629         (maintenance_test_options_command_completion_text): Update
 630         comment.
 631         (maintenance_show_test_options_completion_result): Change
 632         prototype.  Just print
 633         maintenance_test_options_command_completion_text.
 634         (save_completion_result): New.
 635         (maintenance_test_options_completer_mode): Pass options context to
 636         complete_options, and then save a dump.
 637         (_initialize_maint_test_options): Use add_cmd to install "maint
 638         show test-options-completion-result".
 639
 640 2019-07-03  Pedro Alves  <palves@redhat.com>
 641
 642         * NEWS (New commands): Mention "with" and "maint with".
 643         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 644         (with_command, with_command_completer): New.
 645         (pipe_command): Adjust to new repeat_previous
 646         interface.
 647         (_initialize_cli_cmds): Install the "with" command and its "w"
 648         alias.
 649         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 650         declarations.
 651         * cli/cli-setshow.c (parse_cli_var_uinteger)
 652         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 653         argument strings for all var_types.
 654         (get_setshow_command_value_string): New, factored out from ...
 655         (do_show_command): ... this.
 656         * cli/cli-setshow.h: Include <string>.
 657         (get_setshow_command_value_string): Declare.
 658         * command.h (repeat_previous): Now returns const char *.  Adjust
 659         comment.
 660         * maint.c: Include "cli/cli-cmds.h".
 661         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 662         (_initialize_maint_cmds): Register the "maintenance with" command.
 663         * top.c (repeat_previous): Move bits from pipe_command here:
 664         Return the saved command line, if any; error out if there's no
 665         command to relaunch.
 666
 667 2019-07-03  Pedro Alves  <palves@redhat.com>
 668
 669         * NEWS (New commands): Mention "maint set/show test-settings"
 670         instead of "maint test-settings".
 671         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 672         (maintenance_test_settings_set_list): Rename to ...
 673         (maintenance_set_test_settings_list): ... this.
 674         (maintenance_test_settings_show_list): Rename to  ...
 675         (maintenance_show_test_settings_list): ... this.
 676         (maintenance_test_settings_cmd): Delete.
 677         (maintenance_test_settings_set_cmd): ...
 678         (maintenance_set_test_settings_cmd): ... this.
 679         (maintenance_test_settings_show_cmd): ...
 680         (maintenance_show_test_settings_cmd): ... this.
 681         (maintenance_test_settings_show_value_cmd):
 682         (maintenance_show_test_settings_value_cmd): ... this.
 683         (_initialize_maint_test_settings): No longer install the "maint
 684         test-settings" prefix command.  Rename "maint test-settings set"
 685         to "maint set test-settings", and "maint test-settings show" to
 686         "maint show test-settings".  Adjust all subcommands.
 687
 688 2019-07-03  Pedro Alves  <palves@redhat.com>
 689
 690         * maint-test-settings.c: Fix file's intro comment.  Replace all
 691         references to "test-options" with references to "test-settings",
 692         in comments.
 693
 694 2019-07-03  Pedro Alves  <palves@redhat.com>
 695
 696         * maint-test-settings.c (maintenance_test_settings_xxx)
 697         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 698         New.
 699         (maintenance_test_settings_enums): Use them.
 700         (maintenance_test_settings_enum): Default to
 701         maintenance_test_settings_xxx.
 702         (_initialize_maint_test_settings): Initialize
 703         MAINTENANCE_TEST_SETTINGS_FILENAME.
 704
 705 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 706
 707         * breakpoint.h (remove_breakpoints_inf): Change return type to
 708         void, move function documentation here.
 709         * breakpoint.c (remove_breakpoints_inf): Change return type to
 710         void, move function documentation to header.
 711
 712 2019-07-02  Pedro Alves  <palves@redhat.com>
 713
 714         * NEWS (Completion improvements): Mention "info threads".
 715         * thread.c (struct info_threads_opts, info_threads_option_defs)
 716         (make_info_threads_options_def_group): New.
 717         (info_threads_command): Use gdb::option::process_options.
 718         (info_threads_command_completer): New.
 719         (_initialize_thread): Use gdb::option::build_help to build the
 720         help text for "info threads".
 721
 722 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 723
 724         * defs.h (generic_load): Move from here...
 725         * symfile.h (generic_load): ... to here.  Rename name parameter
 726         to args.
 727         * symfile.c (generic_load): Add comment.
 728
 729 2019-07-01  Tom Tromey  <tromey@adacore.com>
 730
 731         * dwarf2read.c
 732         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 733         declaration of without_params.  Fix formatting.
 734
 735 2019-07-01  Tom Tromey  <tromey@adacore.com>
 736
 737         * ada-exp.y (find_primitive_type): Update.
 738         * ada-lang.h (ada_lookup_symbol): Update.
 739         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 740         parameter.
 741         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 742
 743 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 744
 745         PR breakpoints/24541
 746         * gdbarch.c: Regenerate.
 747         * gdbarch.h: Regenerate.
 748         * gdbarch.sh: Add 'stap_adjust_register'.
 749         * i386-tdep.c: Include '<unordered_set>'.
 750         (i386_stap_adjust_register): New function.
 751         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 752         * stap-probe.c (stap_parse_register_operand): Call
 753         'gdbarch_stap_adjust_register'.
 754
 755 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 756
 757         PR python/24742
 758         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 759         * python/python.c (do_start_initialization): Use 'xmalloc'
 760         instead of 'PyMem_Malloc'.
 761
 762 2019-06-28  Tom Tromey  <tromey@adacore.com>
 763
 764         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 765         for Ada.
 766
 767 2019-06-27  Tom Tromey  <tromey@adacore.com>
 768
 769         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 770         objfile_key.
 771         (arm_find_mapping_symbol, arm_record_special_symbol)
 772         (_initialize_arm_tdep): Update.
 773         (arm_objfile_data_free): Remove.
 774
 775 2019-06-27  Tom Tromey  <tromey@adacore.com>
 776
 777         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 778         to cp_print_static_field.
 779
 780 2019-06-26  Tom Tromey  <tromey@adacore.com>
 781
 782         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 783         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 784         declare.
 785
 786 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 787
 788         * features/aarch64-core.c (create_feature_aarch64_core):
 789         Regenerate.
 790         * features/aarch64-core.xml: Add cpsr flags.
 791
 792 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 793
 794         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 795         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 796
 797 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 798
 799         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 800         field.
 801         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 802         use.
 803         (arm_record_special_symbol): Don't insert new symbol in sorted
 804         position, push it at the end.
 805
 806 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 807
 808         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 809         (arm_mapping_symbol_s): Remove.
 810         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 811         (arm_mapping_symbol_vec): New typedef.
 812         (struct arm_per_objfile): Add constructor.
 813         <section_maps>: Change type to
 814         std::unique_ptr<arm_mapping_symbol_vec[]>.
 815         (arm_compare_mapping_symbols): Remove.
 816         (arm_find_mapping_symbol): Adjust to section_maps type change.
 817         (arm_objfile_data_free): Call delete on arm_per_objfile.
 818         (arm_record_special_symbol): Adjust to section_maps type change.
 819         Allocate arm_per_objfile with new.
 820
 821 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 822
 823         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 824         with the command prefix.
 825
 826 2019-06-25  Tom Tromey  <tom@tromey.com>
 827
 828         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 829         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 830
 831 2019-06-25  Tom Tromey  <tom@tromey.com>
 832
 833         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 834         type.
 835         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 836         protected.
 837
 838 2019-06-25  Tom Tromey  <tom@tromey.com>
 839
 840         * tui/tui-winsource.c
 841         (tui_source_window_base::set_is_exec_point_at): Add check against
 842         LOA_ADDRESS.
 843
 844 2019-06-25  Tom Tromey  <tom@tromey.com>
 845
 846         * tui/tui-source.c (tui_set_source_content): Don't check before
 847         xfree.
 848         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 849
 850 2019-06-25  Tom Tromey  <tom@tromey.com>
 851
 852         * tui/tui-winsource.h (tui_update_source_window_as_is)
 853         (tui_alloc_source_buffer, tui_line_is_displayed)
 854         (tui_addr_is_displayed): Change type of win_info.
 855         * tui/tui-winsource.c (tui_update_source_window_as_is)
 856         (tui_clear_source_content, tui_show_source_line)
 857         (tui_show_source_content, tui_source_window_base::refill)
 858         (tui_source_window_base::set_is_exec_point_at)
 859         (tui_source_window_base::set_is_exec_point_at)
 860         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 861         (tui_alloc_source_buffer, tui_line_is_displayed)
 862         (tui_addr_is_displayed): Change type of win_info.  Update.
 863         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 864         (tui_source_window_base::do_make_visible_with_new_height):
 865         Update.
 866         * tui/tui-source.c (tui_set_source_content)
 867         (tui_set_source_content_nil)
 868         (tui_source_window::do_scroll_vertical): Update.
 869         * tui/tui-layout.c (show_layout): Update.
 870         * tui/tui-disasm.c (tui_set_disassem_content)
 871         (tui_disasm_window::do_scroll_vertical): Update.
 872         * tui/tui-data.h (tui_win_content): Remove.
 873         (struct tui_gen_win_info) <content, content_size>: Remove.
 874         (struct tui_source_element): Add initializers and destructor.
 875         (union tui_which_element, struct tui_win_element): Remove.
 876         (struct tui_source_window_base) <content>: New field.
 877         (struct tui_data_window): Remove destructor.
 878         (tui_alloc_content, tui_free_win_content)
 879         (tui_free_all_source_wins_content): Don't declare.
 880         * tui/tui-data.c (tui_initialize_static_data): Update.
 881         (init_content_element, tui_alloc_content): Remove.
 882         (~tui_gen_win_info): Update.
 883         (~tui_data_window, tui_free_all_source_wins_content)
 884         (tui_free_win_content, free_content, free_content_elements):
 885         Remove.
 886
 887 2019-06-25  Tom Tromey  <tom@tromey.com>
 888
 889         * tui/tui-winsource.h (tui_clear_source_content)
 890         (tui_erase_source_content, tui_show_source_content): Change type
 891         of win_info.
 892         * tui/tui-winsource.c (tui_clear_source_content)
 893         (tui_erase_source_content, tui_show_source_content): Change type
 894         of win_info.
 895         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 896         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 897         win_info.
 898         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 899         win_info.
 900         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 901
 902 2019-06-25  Tom Tromey  <tom@tromey.com>
 903
 904         * tui/tui-winsource.c (tui_clear_source_content)
 905         (tui_source_window_base::set_is_exec_point_at): Update.
 906         * tui/tui-source.c (tui_set_source_content_nil): Update.
 907         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 908         a bool.
 909         * tui/tui-data.c (init_content_element): Update.
 910
 911 2019-06-25  Tom Tromey  <tom@tromey.com>
 912
 913         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 914         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 915         * tui/tui-layout.c (init_and_make_win): Update.
 916         * tui/tui.h (enum tui_win_type): Update.
 917         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 918         tui_win_is_auxillary.
 919         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 920         tui_win_is_auxillary.
 921
 922 2019-06-25  Tom Tromey  <tom@tromey.com>
 923
 924         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 925         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 926         (tui_delete_data_content_windows, tui_display_all_data)
 927         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 928         Update.
 929         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 930         * tui/tui-regs.c (tui_last_regs_line_no)
 931         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 932         (tui_show_registers): Update.
 933         (tui_show_register_group): Return void.  Update.
 934         (tui_display_registers_from, tui_display_reg_element_at_line)
 935         (tui_display_registers_from_line, tui_check_register_values):
 936         Update.
 937         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 938         member.
 939         (struct tui_data_window) <regs_content>: Now a std::vector.
 940         <regs_content_count>: Remove.
 941         (tui_add_content_elements, tui_free_data_content): Don't declare.
 942         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 943         (init_content_element): Remove DATA_WIN case.  Add assert.
 944         (tui_add_content_elements): Remove.
 945         (tui_data_window): Update.
 946         (tui_free_data_content): Remove.
 947         (free_content_elements): Remove DATA_WIN case.
 948
 949 2019-06-25  Tom Tromey  <tom@tromey.com>
 950
 951         * tui/tui-data.c (tui_data_item_window): Update.
 952         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 953         * tui/tui-windata.c (tui_display_all_data)
 954         (tui_display_data_from_line): Update.
 955         (tui_check_data_values): Remove.
 956         * tui/tui-regs.c (tui_show_register_group)
 957         (tui_display_reg_element_at_line): Update.
 958         * tui/tui-hooks.c (tui_register_changed)
 959         (tui_refresh_frame_and_register_information): Call
 960         tui_check_register_values.
 961         * tui/tui-data.h (struct tui_data_window) <data_content,
 962         data_content_count, data_type>: Remove.
 963         (enum tui_data_type): Remove.
 964
 965         * tui/tui-data.c (tui_data_window::clear_detail)
 966         (~tui_data_window): Update.
 967
 968 2019-06-25  Tom Tromey  <tom@tromey.com>
 969
 970         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 971         declare.
 972         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 973         Rename from tui_first_data_item_displayed.  Update.
 974         (tui_data_window::refresh_all)
 975         (tui_data_window::do_scroll_vertical): Update.
 976         * tui/tui-data.h (struct tui_data_window)
 977         <first_data_item_displayed>: Declare new method.
 978
 979 2019-06-25  Tom Tromey  <tom@tromey.com>
 980
 981         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 982         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 983         contents...
 984         (tui_initialize_static_data): ...here.
 985
 986 2019-06-25  Tom Tromey  <tom@tromey.com>
 987
 988         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 989         (tui_display_registers_from, tui_check_register_values): Update.
 990         (tui_display_register): Remove win_info parameter; update.
 991         (tui_get_register): Change type of parameters.
 992         * tui/tui-data.h (struct tui_data_element): Remove.
 993         (union tui_which_element) <data>: Remove.
 994         <data_window>: Change type.
 995         (struct tui_data_item_window): New.
 996         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 997         case.  Add assert.
 998         (~tui_data_item_window): New destructor.
 999         (free_content_elements): Remove DATA_ITEM_WIN case.
1000
1001 2019-06-25  Tom Tromey  <tom@tromey.com>
1002
1003         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1004         Remove.
1005
1006 2019-06-25  Tom Tromey  <tom@tromey.com>
1007
1008         * tui/tui-data.h (struct tui_command_element): Remove.
1009         (union tui_which_element) <command>: Remove.
1010         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1011         assert.
1012         (free_content_elements): Remove CMD_WIN case.
1013
1014 2019-06-25  Tom Tromey  <tom@tromey.com>
1015
1016         * tui/tui-layout.c (tui_set_layout): Update.
1017         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1018         * tui/tui-data.c (layout_def): Update.
1019
1020 2019-06-25  Tom Tromey  <tom@tromey.com>
1021
1022         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1023         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1024         (tui_source_window_base::set_new_height): Update.
1025         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1026         Update.
1027         (tui_set_locator_fullname, tui_set_locator_info)
1028         (tui_show_frame_info): Update.
1029         * tui/tui-source.c (tui_set_source_content)
1030         (tui_source_is_displayed): Update.
1031         * tui/tui-layout.c (show_source_disasm_command, show_data)
1032         (show_source_or_disasm_and_command): Update.
1033         * tui/tui-disasm.c (tui_set_disassem_content)
1034         (tui_get_begin_asm_address): Update.
1035         * tui/tui-data.h (struct tui_locator_element): Remove.
1036         (union tui_which_element) <locator>: Remove.
1037         (struct tui_locator_window): New.
1038         (tui_locator_win_info_ptr): Change return type.
1039         * tui/tui-data.c (_locator): Change type.
1040         (tui_locator_win_info_ptr): Change return type.
1041         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1042         (tui_alloc_content): Add assert.
1043
1044 2019-06-25  Tom Tromey  <tom@tromey.com>
1045
1046         * tui/tui-winsource.c
1047         (tui_exec_info_window::maybe_allocate_content): New method.
1048         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1049         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1050         (make_source_or_disasm_window): Add cast.
1051         * tui/tui-data.h (union tui_which_element) <simple_string>:
1052         Remove.
1053         (struct tui_source_info): New.
1054         (struct tui_source_window_base) <execution_info>: Change type.
1055         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1056         case, and add assert.
1057         (tui_alloc_content): Add assert.
1058
1059 2019-06-25  Tom Tromey  <tom@tromey.com>
1060
1061         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1062         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1063         * tui/tui-data.c (tui_alloc_win_info): Remove.
1064
1065 2019-06-25  Tom Tromey  <tom@tromey.com>
1066
1067         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1068         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1069         can_highlight.
1070
1071 2019-06-25  Tom Tromey  <tom@tromey.com>
1072
1073         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1074         make_visible_with_new_height method.
1075         (tui_win_info::make_visible_with_new_height): New method.
1076         (tui_source_window_base::do_make_visible_with_new_height)
1077         (tui_data_window::do_make_visible_with_new_height)
1078         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1079         (make_visible_with_new_height): Remove.
1080         (tui_resize_all, tui_adjust_win_heights): Use
1081         make_visible_with_new_height method.
1082         * tui/tui-data.h (struct tui_win_info)
1083         <do_make_visible_with_new_height, make_visible_with_new_height>:
1084         New methods.
1085         (struct tui_source_window_base, struct tui_data_window)
1086         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1087         methods.
1088
1089 2019-06-25  Tom Tromey  <tom@tromey.com>
1090
1091         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1092         method.
1093         (update_tab_width): Call update_tab_width method.
1094         * tui/tui-data.h (struct tui_win_info)
1095         (struct tui_source_window_base) <update_tab_width>: New methods.
1096
1097 2019-06-25  Tom Tromey  <tom@tromey.com>
1098
1099         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1100         parameter.
1101         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1102         parameter.
1103         (tui_gen_win_info::make_visible): Update.
1104         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1105         parameter.
1106         * tui/tui-data.h (enum tui_box): New enum.
1107         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1108
1109 2019-06-25  Tom Tromey  <tom@tromey.com>
1110
1111         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1112         init_and_make_win for EXEC_INFO_WIN.
1113         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1114         longer inline.
1115         (struct tui_win_info) <~tui_win_info>: Inline.
1116         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1117         Don't declare.
1118         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1119         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1120         Remove.
1121         (tui_initialize_static_data): Update.
1122         (~tui_gen_win_info): Handle more cleanup here.
1123         (~tui_source_window_base): Delete "execution_info".
1124         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1125
1126 2019-06-25  Tom Tromey  <tom@tromey.com>
1127
1128         * tui/tui-layout.c (make_command_window): Don't set
1129         can_highlight.
1130         (show_source_disasm_command): Call the reset method.
1131         (show_data): Don't set can_highlight.  Call the reset method.
1132         (tui_gen_win_info::reset): Rename from init_gen_win_info
1133         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1134         (show_source_or_disasm_and_command): Call the reset method.
1135         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1136         (struct tui_cmd_window): Set can_highlight.
1137
1138 2019-06-25  Tom Tromey  <tom@tromey.com>
1139
1140         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1141         from make_visible.
1142         (tui_make_visible, tui_make_invisible): Rewrite.
1143         (tui_win_info::make_visible): Remove.
1144         (tui_source_window_base::make_visible): Update.
1145         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1146         method.  Moved from...
1147         (struct tui_win_info) <make_visible>: ...here.
1148
1149 2019-06-25  Tom Tromey  <tom@tromey.com>
1150
1151         * tui/tui-winsource.c
1152         (tui_source_window_base::do_scroll_horizontal): Remove direction
1153         parameter.
1154         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1155         direction parameter.
1156         * tui/tui-win.c (tui_win_info::forward_scroll)
1157         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1158         (tui_win_info::right_scroll): Update.
1159         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1160         direction parameter.
1161         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1162         direction parameter.
1163         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1164         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1165         Remove direction parameter.
1166         (struct tui_source_window_base, struct tui_source_window)
1167         (struct tui_disasm_window, struct tui_data_window)
1168         (struct tui_cmd_window): Update.
1169
1170 2019-06-25  Tom Tromey  <tom@tromey.com>
1171
1172         * tui/tui-winsource.h (tui_set_exec_info_content)
1173         (tui_show_exec_info_content, tui_erase_exec_info_content)
1174         (tui_clear_exec_info_content, tui_update_exec_info): Change
1175         argument to tui_source_window_base.
1176         * tui/tui-winsource.c (tui_set_exec_info_content)
1177         (tui_show_exec_info_content, tui_erase_exec_info_content)
1178         (tui_clear_exec_info_content, tui_update_exec_info): Change
1179         argument to tui_source_window_base.
1180
1181 2019-06-25  Tom Tromey  <tom@tromey.com>
1182
1183         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1184         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1185
1186 2019-06-25  Tom Tromey  <tom@tromey.com>
1187
1188         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1189         check.
1190
1191 2019-06-25  Tom Tromey  <tom@tromey.com>
1192
1193         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1194         type to void.
1195         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1196         type to void.
1197         * tui/tui-source.c (tui_set_source_content): Update.
1198         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1199
1200 2019-06-25  Tom Tromey  <tom@tromey.com>
1201
1202         * tui/tui-win.c (window_name_completer, tui_set_focus)
1203         (tui_all_windows_info): Use name method.
1204         * tui/tui-data.h (struct tui_gen_win_info)
1205         (struct tui_source_window, struct tui_disasm_window)
1206         (struct tui_data_window, struct tui_cmd_window) <name>: New
1207         method.
1208         (tui_win_name): Don't declare.
1209         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1210         (tui_win_name): Remove.
1211
1212 2019-06-25  Tom Tromey  <tom@tromey.com>
1213
1214         * tui/tui-winsource.h (tui_update_source_window)
1215         (tui_update_source_window_as_is): Change parameter type.
1216         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1217         to be a tui_source_window_base.
1218         (tui_update_source_window_as_is): Likewise.
1219         * tui/tui-win.c (make_visible_with_new_height): Update.
1220
1221 2019-06-25  Tom Tromey  <tom@tromey.com>
1222
1223         * tui/tui-winsource.c (tui_erase_source_content)
1224         (tui_show_source_content, tui_show_exec_info_content)
1225         (tui_erase_exec_info_content): Use refresh_window method.
1226         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1227         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1228         from tui_refresh_win.
1229         (tui_data_window::refresh_window): New method.
1230         (tui_win_info::refresh, tui_source_window_base::refresh)
1231         (tui_refresh_all): Use refresh_window method.
1232         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1233         method.
1234         * tui/tui-regs.c (tui_display_register): Call refresh_window
1235         method.
1236         * tui/tui-layout.c (show_source_disasm_command)
1237         (show_source_or_disasm_and_command): Call refresh_window method.
1238         * tui/tui-data.h (struct tui_gen_win_info)
1239         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1240         New method.
1241
1242 2019-06-25  Tom Tromey  <tom@tromey.com>
1243
1244         * tui/tui.c (tui_rl_other_window, tui_enable)
1245         (tui_is_window_visible, tui_get_command_dimension): Update.
1246         * tui/tui-winsource.c (tui_update_source_window_as_is)
1247         (tui_clear_source_content, tui_erase_source_content)
1248         (tui_show_source_line, tui_source_window_base::refill)
1249         (tui_source_window_base::do_scroll_horizontal)
1250         (tui_source_window_base::set_is_exec_point_at)
1251         (tui_update_breakpoint_info, tui_set_exec_info_content)
1252         (tui_alloc_source_buffer, tui_line_is_displayed)
1253         (tui_addr_is_displayed): Update.
1254         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1255         (tui_check_and_display_highlight_if_needed)
1256         (tui_win_info::make_visible, tui_win_info::refresh)
1257         (tui_refresh_all): Update.
1258         * tui/tui-windata.c (tui_first_data_item_displayed)
1259         (tui_delete_data_content_windows, tui_erase_data_content)
1260         (tui_display_all_data, tui_data_window::refresh_all)
1261         (tui_check_data_values): Update.
1262         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1263         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1264         (tui_win_info::backward_scroll, tui_refresh_all_win)
1265         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1266         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1267         (tui_source_window_base::set_new_height)
1268         (tui_data_window::set_new_height)
1269         (make_invisible_and_set_new_height)
1270         (make_visible_with_new_height, new_height_ok)
1271         (parse_scrolling_args): Update.
1272         * tui/tui-stack.c (tui_show_frame_info): Update.
1273         * tui/tui-source.c (tui_set_source_content)
1274         (tui_set_source_content_nil, tui_source_is_displayed)
1275         (tui_source_window::do_scroll_vertical): Update.
1276         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1277         (tui_display_registers_from, tui_display_reg_element_at_line)
1278         (tui_check_register_values, tui_reg_command): Update.
1279         * tui/tui-layout.c (tui_default_win_height)
1280         (show_source_disasm_command, show_data, init_and_make_win)
1281         (show_source_or_disasm_and_command): Update.
1282         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1283         (tui_redisplay_readline, tui_mld_flush)
1284         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1285         (tui_getc): Update.
1286         * tui/tui-disasm.c (tui_set_disassem_content)
1287         (tui_disasm_window::do_scroll_vertical): Update.
1288         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1289         Now virtual.
1290         (struct tui_win_info): Derive from tui_gen_win_info.
1291         <~tui_win_info>: Mark as override.
1292         <generic>: Remove member.
1293         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1294         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1295         (~tui_data_window, ~tui_win_info)
1296         (tui_free_all_source_wins_content): Update.
1297         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1298
1299 2019-06-25  Tom Tromey  <tom@tromey.com>
1300
1301         * tui/tui-layout.c (init_and_make_win): Use new.
1302         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1303         destructor, initializers.
1304         (tui_alloc_generic_win_info): Don't declare.
1305         * tui/tui-data.c (_locator): Add argument to constructor.
1306         (source_win, disasm_win): New globals.
1307         (exec_info): Remove.
1308         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1309         Update.
1310         (tui_alloc_generic_win_info): Remove.
1311         (init_content_element): Use new.
1312         (tui_win_info::tui_win_info): Update.
1313         (free_content_elements) <case DATA_WIN>: Use delete.
1314
1315 2019-06-25  Tom Tromey  <tom@tromey.com>
1316
1317         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1318         * tui/tui-windata.c (tui_first_data_item_displayed)
1319         (tui_delete_data_content_windows): Update.
1320         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1321         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1322         (tui_display_registers_from, tui_check_register_values): Update.
1323         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1324         pointer.
1325         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1326         window.
1327         (tui_free_data_content): Update.
1328         (free_content_elements) <case DATA_WIN>: Free the window.
1329
1330 2019-06-25  Tom Tromey  <tom@tromey.com>
1331
1332         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1333         Update.
1334         * tui/tui-layout.c (make_command_window)
1335         (show_source_disasm_command, show_data, init_and_make_win)
1336         (show_source_or_disasm_and_command): Update.
1337         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1338         method.
1339         <can_highight, is_highlighted>: Now bool.
1340         (tui_set_win_highlight): Don't declare.
1341         * tui/tui-data.c (tui_set_win_highlight): Remove.
1342
1343 2019-06-25  Tom Tromey  <tom@tromey.com>
1344
1345         * tui/tui-wingeneral.c (make_visible): Remove check of window
1346         type.
1347
1348 2019-06-25  Tom Tromey  <tom@tromey.com>
1349
1350         * tui/tui-win.c (tui_win_info::max_height)
1351         (tui_cmd_window::max_height): New methods.
1352         (new_height_ok): Call max_height.
1353         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1354         <max_height>: New method.
1355
1356 2019-06-25  Tom Tromey  <tom@tromey.com>
1357
1358         * tui/tui-win.c (tui_source_window_base::set_new_height)
1359         (tui_data_window::set_new_height): New methods.
1360         (make_invisible_and_set_new_height): Call set_new_height method.
1361         * tui/tui-data.h (struct tui_win_info)
1362         (struct tui_source_window_base, struct tui_data_window)
1363         <set_new_height>: New method.
1364
1365 2019-06-25  Tom Tromey  <tom@tromey.com>
1366
1367         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1368         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1369         tui_refresh_data_win.
1370         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1371         method.
1372         (tui_refresh_all_win): Call the refresh_all method.
1373         (tui_set_focus): Likewise.
1374         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1375         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1376         Likewise.
1377
1378 2019-06-25  Tom Tromey  <tom@tromey.com>
1379
1380         * tui/tui-winsource.h (tui_refill_source_window)
1381         (tui_set_is_exec_point_at): Don't declare.
1382         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1383         (tui_source_window_base::refill): Rename from
1384         tui_refill_source_window.
1385         (tui_source_window_base::do_scroll_horizontal): Update.
1386         (tui_source_window_base::set_is_exec_point_at): Rename from
1387         tui_set_is_exec_point_at.
1388         (tui_update_all_breakpoint_info): Update.
1389         * tui/tui-stack.c (tui_show_frame_info): Update.
1390         * tui/tui-layout.c (show_data): Add cast.
1391         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1392         * tui/tui-data.h (struct tui_source_window_base) <refill,
1393         set_is_exec_point_at>: New methods.
1394         (tui_source_windows, tui_add_to_source_windows): Update types.
1395         (tui_add_to_source_windows): Remove redundant declaration.
1396         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1397         (tui_source_windows): Change return type.
1398         (tui_clear_source_windows_detail): Update.
1399         (tui_add_to_source_windows): Change type of parameter.
1400         (tui_free_all_source_wins_content): Update.
1401
1402 2019-06-25  Tom Tromey  <tom@tromey.com>
1403
1404         * tui/tui-wingeneral.c (tui_win_info::refresh)
1405         (tui_source_window_base::refresh): New methods.
1406         (tui_refresh_all): Call the refresh method.
1407         * tui/tui-data.h (struct tui_win_info)
1408         (struct tui_source_window_base) <refresh>: New method.
1409
1410 2019-06-25  Tom Tromey  <tom@tromey.com>
1411
1412         * tui/tui.h (tui_is_window_visible): Return bool.
1413         * tui/tui.c (tui_is_window_visible): Return bool.
1414         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1415         (tui_make_visible, tui_make_invisible)
1416         (tui_win_info::make_visible)
1417         (tui_source_window_base::make_visible, make_all_visible)
1418         (tui_make_all_visible, tui_make_all_invisible): Update.
1419         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1420         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1421         bool.
1422         (struct tui_win_info, struct tui_source_window_base)
1423         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1424         * tui/tui-data.c (tui_init_generic_part): Update.
1425
1426 2019-06-25  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1429         (tui_source_window_base::make_visible): New methods.
1430         (make_all_visible): Make method call.
1431         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1432         (struct tui_source_window_base, struct tui_cmd_window): Override
1433         make_visible.
1434         (tui_win_is_source_type): Don't declare.
1435         * tui/tui-data.c (tui_win_is_source_type): Remove.
1436
1437 2019-06-25  Tom Tromey  <tom@tromey.com>
1438
1439         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1440         NULL check.
1441
1442 2019-06-25  Tom Tromey  <tom@tromey.com>
1443
1444         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1445         Inline constructor.  Add initializers for members.
1446         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1447         constructors; now inline in class.
1448
1449 2019-06-25  Tom Tromey  <tom@tromey.com>
1450
1451         * tui/tui-regs.c (tui_show_registers): Update.
1452         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1453         bool.
1454         * tui/tui-data.c (tui_data_window::clear_detail)
1455         (tui_data_window): Update.
1456
1457 2019-06-25  Tom Tromey  <tom@tromey.com>
1458
1459         * tui/tui-windata.c (tui_display_all_data)
1460         (tui_display_data_from_line, tui_display_data_from)
1461         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1462         Update.
1463         * tui/tui-regs.c (tui_last_regs_line_no)
1464         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1465         (tui_show_registers, tui_show_register_group)
1466         (tui_display_registers_from, tui_display_reg_element_at_line)
1467         (tui_display_registers_from_line, tui_check_register_values)
1468         (tui_reg_next, tui_reg_prev): Update.
1469         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1470         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1471         tui_data_window.
1472         (struct tui_win_info) <detail>: Remove.  Add new fields from
1473         tui_data_info.
1474         (TUI_DATA_WIN): Add cast.
1475         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1476         (~tui_data_window): Simplify.
1477
1478 2019-06-25  Tom Tromey  <tom@tromey.com>
1479
1480         * tui/tui-layout.c (show_source_disasm_command)
1481         (show_source_or_disasm_and_command): Update.
1482         * tui/tui-io.c (update_cmdwin_start_line)
1483         (tui_redisplay_readline): Update.
1484         * tui/tui-data.h (struct tui_command_info): Remove.
1485         (struct tui_win_info) <detail>: Remove command_info member.
1486         (struct tui_data_window) <start_line>: New member, from
1487         tui_command_info.
1488         (TUI_CMD_WIN): Add casts.
1489
1490 2019-06-25  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui-winsource.c (tui_update_source_window)
1493         (tui_refill_source_window)
1494         (tui_source_window_base::do_scroll_horizontal)
1495         (tui_update_breakpoint_info, tui_set_exec_info_content)
1496         (tui_show_exec_info_content, tui_erase_exec_info_content)
1497         (tui_clear_exec_info_content): Update.
1498         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1499         Update.
1500         * tui/tui-win.c (make_invisible_and_set_new_height)
1501         (make_visible_with_new_height): Update.
1502         * tui/tui-source.c (tui_set_source_content)
1503         (tui_show_symtab_source): Update.
1504         * tui/tui-layout.c (extract_display_start_addr)
1505         (show_source_disasm_command, show_data)
1506         (make_source_or_disasm_window)
1507         (show_source_or_disasm_and_command): Update.
1508         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1509         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1510         "gdbarch".
1511         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1512         to tui_source_window_base.
1513         (struct tui_win_info) <detail>: Remove source_info member.
1514         (struct tui_source_window_base) <has_locator>: Inline.
1515         Move contents from tui_source_info; rename has_locator member to
1516         m_has_locator.
1517         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1518         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1519         header file.
1520         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1521         Simplify.
1522         (tui_free_all_source_wins_content): Cast to
1523         tui_source_window_base.
1524
1525 2019-06-25  Tom Tromey  <tom@tromey.com>
1526
1527         * tui/tui-win.c (make_invisible_and_set_new_height)
1528         (make_visible_with_new_height): Call has_locator method.
1529         * tui/tui-layout.c (show_source_disasm_command, show_data)
1530         (show_source_or_disasm_and_command): Update for bool change.
1531         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1532         (tui_win_info) <has_locator>: New method.
1533         (struct tui_source_window_base) <has_locator>: New method.
1534         (tui_win_has_locator): Don't declare.
1535         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1536         from tui_win_has_locator.
1537         (tui_source_window_base): Use false, not FALSE.
1538
1539 2019-06-25  Tom Tromey  <tom@tromey.com>
1540
1541         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1542         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1543         clear_detail method directly.
1544         (tui_clear_win_detail): Remove.
1545
1546 2019-06-25  Tom Tromey  <tom@tromey.com>
1547
1548         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1549         "this", not TUI_DISASM_WIN.
1550
1551 2019-06-25  Tom Tromey  <tom@tromey.com>
1552
1553         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1554         declare.
1555         * tui/tui-winsource.c
1556         (tui_source_window_base::do_scroll_horizontal): Rename from
1557         tui_horizontal_source_scroll.
1558         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1559         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1560         from tui_vertical_data_scroll.
1561         * tui/tui-win.h (tui_scroll): Don't declare.
1562         * tui/tui-win.c (tui_win_info::forward_scroll)
1563         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1564         (tui_win_info::right_scroll): Rename and update.
1565         (tui_scroll_forward_command, tui_scroll_backward_command)
1566         (tui_scroll_left_command, tui_scroll_right_command): Update.
1567         (tui_scroll): Remove.
1568         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1569         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1570         from tui_vertical_source_scroll.
1571         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1572         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1573         from tui_vertical_disassem_scroll.
1574         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1575         do_scroll_horizontal>: New methods.
1576         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1577         Likewise.
1578         (struct tui_source_window_base): Add do_scroll_horizontal.
1579         (struct tui_source_window, struct tui_disasm_window): Add
1580         do_scroll_vertical.
1581         (struct tui_data_window, struct tui_cmd_window): Add
1582         do_scroll_horizontal and do_scroll_vertical.
1583         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1584
1585 2019-06-25  Tom Tromey  <tom@tromey.com>
1586
1587         * tui/tui-data.h (struct tui_source_window_base): New struct.
1588         (struct tui_source_window): Derive from tui_source_window_base.
1589         (struct tui_disasm_window): New struct.
1590         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1591         from tui_source_window::clear_detail.
1592         (tui_source_window_base): Rename from tui_source_window.
1593         (~tui_source_window_base): Rename from ~tui_source_window.
1594         (tui_alloc_win_info): Create a tui_disasm_window.
1595
1596 2019-06-25  Tom Tromey  <tom@tromey.com>
1597
1598         * tui/tui-data.h (struct tui_source_window)
1599         (struct tui_data_window): Declare destructors.
1600         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1601         destructors.
1602         (tui_win_info): Simplify.
1603
1604 2019-06-25  Tom Tromey  <tom@tromey.com>
1605
1606         * tui/tui-winsource.c (tui_display_main)
1607         (tui_update_source_windows_with_addr)
1608         (tui_update_all_breakpoint_info): Update.
1609         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1610         (new_height_ok, parse_scrolling_args): Update.
1611         * tui/tui-stack.c (tui_show_frame_info): Update.
1612         * tui/tui-data.h (struct tui_list): Remove.
1613         (tui_source_windows): Return a reference to a std::vector.
1614         * tui/tui-data.c (source_windows): Now a std::vector.
1615         (tui_source_windows): Change return type.
1616         (tui_clear_source_windows): Rewrite.
1617         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1618         (tui_free_all_source_wins_content): Rewrite.
1619
1620 2019-06-25  Tom Tromey  <tom@tromey.com>
1621
1622         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1623         (struct tui_data_window, struct tui_cmd_window): Declare
1624         clear_detail method.
1625         * tui/tui-data.c (tui_source_window::clear_detail)
1626         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1627         methods.
1628         (tui_clear_win_detail): Simplify.
1629
1630 2019-06-25  Tom Tromey  <tom@tromey.com>
1631
1632         * tui/tui-layout.c (make_source_window, make_disasm_window)
1633         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1634         Return the new window.
1635         (show_source_disasm_command, show_data)
1636         (show_source_or_disasm_and_command): Update.
1637
1638 2019-06-25  Tom Tromey  <tom@tromey.com>
1639
1640         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1641         parameter.  Return the new window.
1642         (show_source_disasm_command): Update and remove NULL check.
1643         (show_source_or_disasm_and_command): Update.
1644
1645 2019-06-25  Tom Tromey  <tom@tromey.com>
1646
1647         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1648
1649 2019-06-25  Tom Tromey  <tom@tromey.com>
1650
1651         * tui/tui-data.h (struct tui_win_info): Make constructor
1652         protected.  Make destructor virtual.  Add initializers.
1653         (tui_source_window, tui_data_window, tui_cmd_window): New
1654         classes.
1655         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1656         constructor.  Add "type" parameter.
1657         (tui_source_window, tui_data_window, tui_cmd_window): New
1658         constructors.
1659         (tui_alloc_win_info): Instantiate the appropriate subclass.
1660
1661 2019-06-25  Tom Tromey  <tom@tromey.com>
1662
1663         * tui/tui-win.c (tui_resize_all): Use delete.
1664         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1665         destructor.
1666         (tui_free_window): Don't declare.
1667         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1668         Update.
1669
1670 2019-06-25  Tom Tromey  <tom@tromey.com>
1671
1672         * tui/tui-data.h (struct tui_win_info): Add constructor.
1673         * tui/tui-data.c (tui_alloc_win_info): Use new.
1674         (tui_free_window): Use delete.
1675
1676 2019-06-22  Tom Tromey  <tom@tromey.com>
1677
1678         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1679         declare.
1680         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1681
1682 2019-06-22  Tom Tromey  <tom@tromey.com>
1683
1684         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1685         declare.
1686         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1687
1688 2019-06-22  Tom de Vries  <tdevries@suse.de>
1689
1690         * dwarf2read.c (create_addrmap_from_aranges)
1691         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1692         instead of '%zu'.
1693
1694 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1695
1696         * dwarf2read.h (dwarf2_section_info_def): Remove.
1697         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1698         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1699         std::vector<dwarf2_section_info>.
1700         (struct dwo_file) <~dwo_file>: Remove.
1701         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1702         types field.
1703         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1704         (dwarf2_read_debug_names): Likewise.
1705         (create_debug_types_hash_table): Change parameter type to
1706         array_view, adjust code accordingly.
1707         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1708         (partial_die_info::fixup): Likewise.
1709         (determine_prefix): Likewise.
1710         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1711
1712 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1713
1714         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1715         gdb_bfd_ref_ptr.
1716         <~dwo_file>: Remove call to gdb_bfd_unref.
1717         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1718         gdb_bfd_ref_ptr::get.
1719
1720 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1721
1722         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1723         type to htab_up.
1724         * dwarf2read.c (struct dwo_file): Initialize fields.
1725         <~dwo_file>: New.
1726         (free_dwo_file): Remove, move content to ~dwo_file.
1727         (struct dwo_file_deleter): Remove.
1728         (dwo_file_up>: Remove custom deleter.
1729         (free_dwo_files): Remove.
1730         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1731         dwo_files.
1732         (process_skeletonless_type_units): Call unique_ptr::get.
1733         (allocate_dwo_file_hash_table): Add deleter to created hash
1734         table.  Change return type to htab_up.
1735         (lookup_dwo_file_slot): Don't memset dwo_file, call
1736         unique_ptr::get.
1737         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1738         (create_dwo_unit_in_dwp_v2): Likewise.
1739         (open_and_init_dwo_file): Likewise.
1740         (free_dwo_file_from_slot): Remove.
1741
1742 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1743
1744         * dwarf2read.h (struct dwarf2_section_info) <readin,
1745         is_virtual>: Change type to bool.
1746         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1747         true instead of 1.
1748
1749 2019-06-19  Tom Tromey  <tom@tromey.com>
1750
1751         * tui/tui-data.h (tui_init_content_element): Don't declare.
1752
1753 2019-06-19  Tom Tromey  <tom@tromey.com>
1754
1755         * tui/tui-data.h (tui_init_win_info): Don't declare.
1756
1757 2019-06-19  Tom de Vries  <tdevries@suse.de>
1758
1759         * dwarf2read.h (abstract_to_concrete): Change type to
1760         std::unordered_map<sect_offset, std::vector<sect_offset>,
1761         gdb::hash_enum<sect_offset>>.
1762
1763 2019-06-19  Tom Tromey  <tromey@adacore.com>
1764
1765         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1766         EVAL_AVOID_SIDE_EFFECTS specially.
1767
1768 2019-06-19  Tom Tromey  <tromey@adacore.com>
1769
1770         * source-cache.c (highlighter): New global.
1771         (source_cache::get_source_lines): Create a highlighter on demand.
1772
1773 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1774
1775         * defs.h (deprecated_interactive_hook): Delete declaration.
1776         * interps.c (clear_interpreter_hooks): Remove use of
1777         deprecated_interactive_hook.
1778         * top.c (deprecated_interactive_hook): Delete definition.
1779         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1780
1781 2019-06-18  Tom de Vries  <tdevries@suse.de>
1782
1783         PR gdb/24515
1784         * dwarf2read.h (abstract_to_concrete): Change type from
1785         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1786         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1787         * dwarf2read.c (read_variable): Update.
1788         (dwarf2_fetch_die_loc_sect_off): Update.
1789
1790 2019-06-17  Tom de Vries  <tdevries@suse.de>
1791
1792         PR gdb/24617
1793         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1794         accessing parent[parent_len - 1].
1795
1796 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1797
1798         PR gdb/24364
1799         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1800         call dtrace_process_dof with NULL dof.
1801
1802 2019-06-16  Tom de Vries  <tdevries@suse.de>
1803
1804         PR gdb/24445
1805         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1806
1807 2019-06-16  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1810         (make_all_visible): Use address of member.
1811
1812 2019-06-16  Tom Tromey  <tom@tromey.com>
1813
1814         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1815         (tui_free_window, free_content, free_content_elements): Remove
1816         unnecessary cast.
1817         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1818         cast.
1819         * tui/tui-regs.c (tui_show_register_group)
1820         (tui_display_registers_from, tui_display_reg_element_at_line):
1821         Remove unnecessary cast.
1822
1823 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1824
1825         * linux-nat.c (normal_mask): Delete.
1826         (_initialize_linux_nat): Don't initialise normal_mask.
1827
1828 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1829
1830         PR gdb/24445
1831         * dwarf-index-write.h (write_psymtabs_to_index): Add
1832         dwz_basename parameter.
1833         * dwarf-index-write.c (write_gdbindex): Move file writing to
1834         write_gdbindex_1.  Change return type void.
1835         (assert_file_size): Move up, remove filename parameter.
1836         (write_gdbindex_1): New function.
1837         (write_debug_names): Change return type to void, call
1838         assert_file_size.
1839         (struct index_wip_file): New struct.
1840         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1841         file logic to index_wip_file.  Write index for dwz file if
1842         needed.
1843         (save_gdb_index_command): Pass basename of dwz file, if present.
1844         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1845         build-id of dwz file, if present.
1846         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1847         (dwarf2_get_dwz_file): Likewise.
1848         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1849         (dwarf2_get_dwz_file): Likewise.
1850
1851 2019-06-16  Tom Tromey  <tom@tromey.com>
1852
1853         * coffread.c (process_coff_symbol): Use xstrdup.
1854         * value.c (create_internalvar): Use xstrdup.
1855
1856 2019-06-16  Tom Tromey  <tom@tromey.com>
1857
1858         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1859         * breakpoint.c (stopin_command, stopat_command)
1860         (until_break_command, decode_location_default): Remove unnecessary
1861         cast.
1862         * utils.c (subset_compare): Remove unnecessary cast.
1863         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1864         cast.
1865         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1866         cast.
1867         * infcmd.c (path_command): Remove unnecessary cast.
1868         * coffread.c (decode_type): Remove unnecessary cast.
1869         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1870         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1871         * tui/tui-stack.c (tui_show_locator_content)
1872         (tui_show_frame_info): Remove unnecessary cast.
1873         * tui/tui-win.c (tui_scroll_forward_command)
1874         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1875         (parse_scrolling_args): Remove unnecessary cast.
1876         * tui/tui-data.c (init_win_info, tui_del_window)
1877         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1878         (free_content_elements): Remove unnecessary cast.
1879         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1880         unnecessary cast.
1881         * tui/tui-source.c (tui_set_source_content)
1882         (tui_vertical_source_scroll): Remove unnecessary cast.
1883         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1884         cast.
1885         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1886         * tui/tui-regs.c (tui_display_registers_from)
1887         (tui_display_register): Remove unnecessary cast.
1888         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1889         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1890         (make_visible): Remove unnecessary cast.
1891         * tui/tui-winsource.c (tui_erase_source_content)
1892         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1893         unnecessary cast.
1894         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1895         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1896         * stabsread.c (read_type, read_array_type, read_range_type):
1897         Remove unnecessary cast.
1898         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1899         (parse_symbol, parse_type, upgrade_type, parse_external)
1900         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1901         unnecessary cast.
1902         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1903
1904 2019-06-16  Tom Tromey  <tom@tromey.com>
1905
1906         * tui/tui-data.c (tui_alloc_generic_win_info)
1907         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1908         checks.
1909
1910 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1911             Andrew Burgess  <andrew.burgess@embecosm.com>
1912
1913         * f-typeprint.c (f_print_type): Don't return early for not
1914         associated or not allocated types.
1915         (f_type_print_varspec_suffix): Add print_rank parameter and print
1916         ranks of array types in case they dangling.
1917         (f_type_print_base): Add print_rank parameter.
1918
1919 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1920
1921         * NEWS: Mention new MI commands.
1922         * break-catch-throw.c (enum exception_event_kind): Move to
1923         breakpoint.h.
1924         (print_mention_exception_catchpoint): Output text as a single
1925         message.
1926         (catch_exception_command_1): Rename to...
1927         (catch_exception_event): ...this, make non-static, update header
1928         command, and change some parameter types.
1929         (catch_catch_command): Update for changes to
1930         catch_exception_command_1.
1931         (catch_throw_command): Likewise.
1932         (catch_rethrow_command): Likewise.
1933         * breakpoint.c (enum exception_event_kind): Delete.
1934         * breakpoint.h (enum exception_event_kind): Moved here from
1935         break-catch-throw.c.
1936         (catch_exception_event): Declare.
1937         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1938         (mi_cmd_catch_throw): New function.
1939         (mi_cmd_catch_rethrow): New function.
1940         (mi_cmd_catch_catch): New function.
1941         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1942         'catch-catch' entries.
1943         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1944         (mi_cmd_catch_rethrow): Declare.
1945         (mi_cmd_catch_catch): Declare.
1946
1947 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1948
1949         * annotate.c (annotate_source_line): Change return type to void,
1950         update implementation to match.
1951         * annotate.h (annotate_source_line): Change return type to void,
1952         update header comment.
1953         * stack.c (print_frame_info): Don't change what frame information
1954         is printed based on whether annotations are on or not.
1955
1956 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1957
1958         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1959         (annotate_source): Make static.
1960         (annotate_source_line): Moved from source.c and renamed from
1961         identify_source_line.  Update the return type.
1962         * annotate.h (annotate_source): Delete declaration.
1963         (annotate_source_line): Declaration moved from source.h, and
1964         renamed from identify_source_line.  Return type updated.
1965         * source.c (identify_source_line): Moved to annotate.c and renamed
1966         to annotate_source_line.
1967         (info_line_command): Remove check of annotation_level.
1968         * source.h (identify_source_line): Move declaration to annotate.h
1969         and rename to annotate_source_line.
1970         * stack.c: Add 'annotate.h' include.
1971         (print_frame_info): Remove check of annotation_level before
1972         calling annotate_source_line.
1973
1974 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1975
1976         * source-cache.c (source_cache::get_plain_source_lines): Use
1977         open_source_file_with_line_charpos instead of just
1978         open_source_file, remove call to find_source_lines.
1979         (source_cache::get_source_lines): Likewise.
1980         * source.c (find_source_lines): Make static.
1981         (get_filename_and_charpos): Renamed into...
1982         (open_source_file_with_line_charpos): ..this along with changes to
1983         return a scoped_fd, and some other minor clean ups.
1984         (identify_source_line): Use open_source_file_with_line_charpos.
1985         (search_command_helper): Use open_source_file_with_line_charpos
1986         instead of just open_source_file, remove call to
1987         find_source_lines.
1988         * source.h (open_source_file_with_line_charpos): Declare new
1989         function.
1990         (find_source_lines): Delete declaration.
1991
1992 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1993
1994         * source.c (get_filename_and_charpos): Remove fullname
1995         parameter.
1996         (identify_source_line): Update call to get_filename_and_charpos.
1997
1998 2019-06-14  Tom Tromey  <tromey@adacore.com>
1999
2000         PR gdb/24502:
2001         * ui-style.h (skip_ansi_escape): Update comment.
2002         * ui-file.h (class no_terminal_escape_file): New class.
2003         * ui-file.c (no_terminal_escape_file::write)
2004         (no_terminal_escape_file::puts): New methods.
2005         * cli/cli-logging.c (handle_redirections): Use
2006         no_terminal_escape_file.
2007
2008 2019-06-14  Tom Tromey  <tromey@adacore.com>
2009
2010         * NEWS: Move convenience variable news above Python news.
2011
2012 2019-06-14  Tom Tromey  <tom@tromey.com>
2013
2014         * gnulib: Move directory to top-level.
2015         * configure.ac: Don't configure gnulib.
2016         * configure: Rebuild.
2017         * common/common-defs.h: Use new path to gnulib.
2018         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2019         (GNULIB_H): Remove.
2020         (INCGNU): Look in new gnulib location.
2021         (HFILES_NO_SRCDIR): Remove gnulib files.
2022         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2023         (generated_files): Remove GNULIB_H.
2024         ($(LIBGNU), all-lib): Remove targets.
2025         (distclean): Don't mention GNULIB_BUILDDIR.
2026         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2027
2028 2019-06-14  Tom Tromey  <tromey@adacore.com>
2029
2030         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2031         Warn if symbol file does not provide any symbols.
2032
2033 2019-06-14  Tom Tromey  <tromey@adacore.com>
2034
2035         * source.c (find_and_open_source): Respect basenames_may_differ.
2036
2037 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2038
2039         * annotate.c (annotate_breakpoints_invalid): Make use of
2040         scoped_restore_terminal_state.
2041         (annotate_frames_invalid): Likewise.
2042
2043 2019-06-14  Tom Tromey  <tromey@adacore.com>
2044
2045         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2046         allow assignment to an internalvar.
2047
2048 2019-06-14  Tom Tromey  <tromey@adacore.com>
2049
2050         * ada-lex.l: Allow "_" in attribute names.
2051
2052 2019-06-14  Tom Tromey  <tromey@adacore.com>
2053
2054         PR gdb/24653:
2055         * regcache.c (registers_changed): Don't call alloca.
2056         * top.c (execute_command): Don't call alloca.
2057
2058 2019-06-13  Pedro Alves  <palves@redhat.com>
2059
2060         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2061         'expression'.  When parsing an expression, error out if there's
2062         junk after "unlimited".
2063         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2064         (do_set_command): Adjust calls to is_unlimited_literal.
2065
2066 2019-06-13  Pedro Alves  <palves@redhat.com>
2067
2068         * compile/compile.c (make_compile_options_def_group): Add braces
2069         around array_view initializer.
2070         * thread.c (make_thread_apply_all_options_def_group)
2071         (make_thread_apply_all_options_def_group): Likewise.
2072
2073 2019-06-13  Pedro Alves  <palves@redhat.com>
2074
2075         * NEWS (New commands): Mention "maint test-options
2076         require-delimiter", "maint test-options unknown-is-error", "maint
2077         test-options unknown-is-operand" and "maint show
2078         test-options-completion-result".
2079         (New command options, command completion): New section.
2080         (Completion improvements): New section.
2081         Mention that you can abbreviate "unlimited".
2082
2083 2019-06-13  Pedro Alves  <palves@redhat.com>
2084
2085         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2086         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2087         * unittests/cli-utils-selftests.c (test_parse_flags)
2088         (test_parse_flags_qcs): Delete.
2089         (test_cli_utils): Don't call deleted functions.
2090
2091 2019-06-13  Pedro Alves  <palves@redhat.com>
2092
2093         * thread.c: Include "cli/cli-option.h".
2094         (tp_array_compar_ascending): Global.
2095         (tp_array_compar): Delete function.
2096         (tp_array_compar_ascending, tp_array_compar_descending): New
2097         functions.
2098         (ascending_option_def, qcs_flag_option_def)
2099         (thr_qcs_flags_option_defs)
2100         (make_thread_apply_all_options_def_group)
2101         (make_thread_apply_options_def_group): New.
2102         (thread_apply_all_command): Use gdb::option::process_options.
2103         (thread_apply_command_completer)
2104         (thread_apply_all_command_completer): New.
2105         (thread_apply_command): Use gdb::option::process_options.
2106         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2107         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2108         to generate help text of "thread apply".  Adjust "taas"'s help.
2109         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2110         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2111
2112 2019-06-13  Pedro Alves  <palves@redhat.com>
2113
2114         * thread.c (thread_apply_command): Check for invalid TID with
2115         isdigit instead of !isalpha.
2116
2117 2019-06-13  Pedro Alves  <palves@redhat.com>
2118
2119         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2120         (validate_flags_qcs): New.
2121         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2122         (validate_flags_qcs): Declare.
2123         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2124         (make_frame_apply_options_def_group): New.
2125         (frame_apply_command_count): Process options with
2126         gdb::option::process_options.
2127         (frame_apply_completer): New.
2128         (frame_apply_level_completer, frame_apply_all_completer)
2129         (frame_apply_completer): New.
2130         (_initialize_stack): Update help of "frame apply", "frame apply
2131         level", "frame apply all" and "faas" to mention supported options
2132         and install command completers.
2133         * stack.h (frame_apply_all_completer): Declare.
2134         * thread.c: Include "stack.h".
2135         (tfaas_command): Add "--".
2136         (_initialize_thread): Update help "tfaas" to mention supported
2137         options and install command completer.
2138
2139 2019-06-13  Pedro Alves  <palves@redhat.com>
2140
2141         * completer.c (complete_nested_command_line): New.
2142         (gdb_completion_word_break_characters_throw): Add assertion.
2143         * completer.h (complete_nested_command_line): Declare.
2144
2145 2019-06-13  Pedro Alves  <palves@redhat.com>
2146
2147         * stack.c (parse_backtrace_qualifiers): New.
2148         (backtrace_command): Use it.
2149         (backtrace_command_completer): Complete on qualifiers.
2150
2151 2019-06-13  Pedro Alves  <palves@redhat.com>
2152
2153         * frame.c: Include "cli/cli-option.h.
2154         (user_set_backtrace_options): New.
2155         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2156         Delete.
2157         (get_prev_frame): Adjust.
2158         (boolean_option_def, uinteger_option_def)
2159         (set_backtrace_option_defs): New.
2160         (_initialize_frame): Adjust and use
2161         gdb::option::add_setshow_cmds_for_options to install "set
2162         backtrace past-main" and "set backtrace past-entry".
2163         * frame.h: Include "cli/cli-option.h".
2164         (struct frame_print_options): Forward declare.
2165         (print_frame_arguments_all, print_frame_arguments_scalars)
2166         (print_frame_arguments_none): Declare.
2167         (print_entry_values): Delete declaration.
2168         (struct frame_print_options, user_frame_print_options): New.
2169         (struct set_backtrace_options): New.
2170         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2171         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2172         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2173         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2174         (list_args_or_locals): Add frame_print_options parameter.
2175         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2176         * python/py-framefilter.c (enumerate_args): Pass down
2177         USER_FRAME_PRINT_OPTIONS.
2178         * stack.c: Include "cli/cli-option.h".
2179         (print_frame_arguments_all, print_frame_arguments_scalars)
2180         (print_frame_arguments_none): Declare.
2181         (print_raw_frame_arguments, print_entry_values): Delete.
2182         (user_frame_print_options): New.
2183         (boolean_option_def, enum_option_def, frame_print_option_defs):
2184         New.
2185         (struct backtrace_cmd_options): New.
2186         (bt_flag_option_def): New.
2187         (backtrace_command_option_defs): New.
2188         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2189         (print_frame_arg, read_frame_arg, print_frame_args)
2190         (print_frame_info, print_frame): Add frame_print_options parameter
2191         and use it.
2192         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2193         (backtrace_command_1): Add frame_print_options and
2194         backtrace_cmd_options parameters and use them.
2195         (make_backtrace_options_def_group): New.
2196         (backtrace_command): Process command options with
2197         gdb::option::process_options.
2198         (backtrace_command_completer): New.
2199         (_initialize_stack): Extend "backtrace"'s help to mention
2200         supported options.  Install completer for "backtrace".
2201         Install some settings commands with add_setshow_cmds_for_options.
2202
2203 2019-06-13  Pedro Alves  <palves@redhat.com>
2204
2205         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2206         and that "set/show print raw frame-arguments" are now deprecated.
2207
2208         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2209         command.
2210         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2211         * stack.c (_initialize_stack): Install "set/show print
2212         raw-frame-arguments", and deprecate "set/show print raw
2213         frame-arguments".
2214         * valprint.c (_initialize_valprint): Deprecate "set/show print
2215         raw".
2216
2217 2019-06-13  Pedro Alves  <palves@redhat.com>
2218
2219         * compile/compile.c (struct compile_options): New.
2220         (compile_flag_option_def, compile_command_option_defs)
2221         (make_compile_options_def_group): New.
2222         (compile_file_command): Handle options with
2223         gdb::option::process_options.
2224         (compile_file_command_completer): New function.
2225         (compile_code_command): Handle options with
2226         gdb::option::process_options.
2227         (compile_code_command_completer): New function.
2228         (_initialize_compiler): Install completers for "compile code" and
2229         "compile file".  Mention available options in "compile code" and
2230         "compile code"'s help.
2231         * completer.c (advance_to_completion_word): New, factored out from
2232         ...
2233         (advance_to_expression_complete_word_point): ... this.
2234         (advance_to_filename_complete_word_point): New.
2235         * completer.h (advance_to_filename_complete_word_point): New
2236         declaration.
2237
2238 2019-06-13  Pedro Alves  <palves@redhat.com>
2239
2240         * compile/compile.c: Include "cli/cli-option.h".
2241         (compile_print_value): Scope data pointer is now a
2242         value_print_options pointer; adjust.
2243         (compile_print_command): Process options.  Scope data pointer is
2244         now a value_print_options pointer; adjust.
2245         (_initialize_compile): Update "compile print"'s help to include
2246         supported options.  Install a completer for "compile print".
2247         * cp-valprint.c (show_vtblprint, show_objectprint)
2248         (show_static_field_print): Delete.
2249         (_initialize_cp_valprint): Don't install "set print
2250         static-members", "set print vtbl", "set print object" here.
2251         * printcmd.c: Include "cli/cli-option.h" and
2252         "common/gdb_optional.h".
2253         (print_command_parse_format): Rework to fill in a
2254         value_print_options instead of a format_data.
2255         (print_value): Change parameter type from format_data pointer to
2256         value_print_options reference.  Adjust.
2257         (print_command_1): Process options.  Adjust to pass down a
2258         value_print_options.
2259         (print_command_completer): New.
2260         (_initialize_printcmd): Install print_command_completer as
2261         handle_brkchars completer for the "print" command.  Update
2262         "print"'s help to include supported options.
2263         * valprint.c: Include "cli/cli-option.h".
2264         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2265         here from cp-valprint.c.
2266         (boolean_option_def, uinteger_option_def)
2267         (value_print_option_defs, make_value_print_options_def_group):
2268         New.  Use gdb::option::add_setshow_cmds_for_options to install
2269         "set print elements", "set print null-stop", "set print repeats",
2270         "set print pretty", "set print union", "set print array", "set
2271         print address", "set print symbol", "set print array-indexes".
2272         * valprint.h: Include <string> and "cli/cli-option.h".
2273         (make_value_print_options_def_group): Declare.
2274         (print_value): Change parameter type from format_data pointer to
2275         value_print_options reference.
2276         (print_command_completer): Declare.
2277
2278 2019-06-13  Pedro Alves  <palves@redhat.com>
2279
2280         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2281         (COMMON_SFILES): Add maint-test-settings.c.
2282         * cli/cli-decode.c (boolean_enums): New global, factored out from
2283         ...
2284         (add_setshow_boolean_cmd): ... here.
2285         * cli/cli-decode.h (boolean_enums): Declare.
2286         * cli/cli-option.c: New file.
2287         * cli/cli-option.h: New file.
2288         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2289         factored out from ...
2290         (parse_cli_boolean_value(const char *)): ... this.
2291         (is_unlimited_literal): Change parameter type to pointer to
2292         pointer.  Adjust and advance ARG pointer.
2293         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2294         (parse_cli_var_enum): New, factored out from ...
2295         (do_set_command): ... this.  Adjust.
2296         * cli/cli-setshow.h (parse_cli_boolean_value)
2297         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2298         (parse_cli_var_enum): Declare.
2299         * cli/cli-utils.c: Include "cli/cli-option.h".
2300         (get_ulongest): New.
2301         * cli/cli-utils.h (get_ulongest): Declare.
2302         (check_for_argument): New overloads.
2303         * maint-test-options.c: New file.
2304
2305 2019-06-13  Pedro Alves  <palves@redhat.com>
2306
2307         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2308         parse a range if "-" is at the end of the string.
2309
2310 2019-06-13  Pedro Alves  <palves@redhat.com>
2311
2312         * cli/cli-setshow.c (parse_auto_binary_operation)
2313         (parse_cli_boolean_value): Don't allow "o".
2314
2315 2019-06-13  Pedro Alves  <palves@redhat.com>
2316
2317         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2318         * NEWS: Mention maint test-settings KIND.
2319         * maint-test-settings.c: New file.
2320
2321 2019-06-13  Pedro Alves  <palves@redhat.com>
2322
2323         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2324         completer.
2325         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2326         "set" completers.
2327
2328 2019-06-13  Pedro Alves  <palves@redhat.com>
2329
2330         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2331         after item.
2332
2333 2019-06-13  Pedro Alves  <palves@redhat.com>
2334
2335         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2336
2337 2019-06-13  Pedro Alves <palves@redhat.com>
2338
2339         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2340         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2341         call.
2342         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2343         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2344         calls.
2345         (check_for_argument): Skip spaces after argument.
2346
2347 2019-06-13  Pedro Alves  <palves@redhat.com>
2348
2349         * thread.c (thread_apply_command): Adjust TID parsing.
2350         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2351         detected before end of string.
2352         (tid_is_in_list): Error out if LIST is invalid.
2353
2354 2019-06-13  Pedro Alves  <palves@redhat.com>
2355
2356         * completer.c (complete_line_internal_1): Rewind completion word
2357         point.
2358         (completion_tracker::advance_custom_word_point_by): Change
2359         parameter type to int.
2360         * completer.h (completion_tracker::advance_custom_word_point_by):
2361         Likewise.
2362
2363 2019-06-13  Pedro Alves  <palves@redhat.com>
2364
2365         * completer.c (advance_to_completion_word): Handle delimiters.
2366
2367 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2368
2369         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2370
2371 2019-06-11  Tom Tromey  <tom@tromey.com>
2372
2373         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2374         (xmalloc_failed): Move to alloc.c.
2375         * alloc.c: New file.
2376         * Makefile.in (COMMON_SFILES): Add alloc.c.
2377
2378 2019-06-11  Tom Tromey  <tom@tromey.com>
2379
2380         * nat/linux-waitpid.c: Don't include server.h.
2381         (linux_debug): Remove.
2382         (my_waitpid): Update.
2383
2384 2019-06-11  Tom Tromey  <tromey@adacore.com>
2385
2386         * infcall.c (_initialize_infcall): Remove trailing newline from
2387         help.
2388         * user-regs.c (_initialize_user_regs): Remove trailing newline
2389         from help.
2390         * typeprint.c (_initialize_typeprint): Remove trailing newline
2391         from help.
2392         * reverse.c (_initialize_reverse): Remove trailing newlines from
2393         help.
2394         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2395         from help.
2396         * language.c (add_set_language_command): Remove trailing newline
2397         from help.
2398         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2399         help.
2400         * disasm.c (_initialize_disasm): Remove trailing newline from
2401         help.
2402         * top.c (init_main): Remove trailing newline from help.
2403         * interps.c (_initialize_interpreter): Remove trailing newline
2404         from help.
2405         * btrace.c (_initialize_btrace): Remove trailing newlines from
2406         help.
2407         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2408         from help.
2409         * python/python.c (_initialize_python): Remove trailing newline
2410         from help.
2411         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2412         help.
2413         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2414         from help.  Reformat some text.
2415         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2416         from help.
2417         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2418         newline from help.
2419
2420 2019-06-11  Tom Tromey  <tromey@adacore.com>
2421
2422         * darwin-nat.c (darwin_decode_exception_message)
2423         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2424
2425 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2426
2427         * valops.c (value_slice): Check for not allocated or not
2428         associated values.
2429
2430 2019-06-10  Tom de Vries  <tdevries@suse.de>
2431
2432         PR gdb/24618
2433         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2434         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2435         invalid.
2436
2437 2019-06-10  Tom de Vries  <tdevries@suse.de>
2438
2439         PR gdb/24611
2440         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2441         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2442
2443 2019-06-10  Tom de Vries  <tdevries@suse.de>
2444
2445         PR symtab/24545
2446         * symtab.c (struct demangled_name_entry): Add language field.
2447         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2448         static minimal symbol".  Set and use language field.
2449
2450 2019-06-10  Tom Tromey  <tromey@adacore.com>
2451
2452         * ada-lang.c (_initialize_ada_language): Update help text.
2453
2454 2019-06-10  Tom Tromey  <tromey@adacore.com>
2455
2456         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2457         with a newline.
2458         * guile/guile.c (handle_boot_error): Don't end warning with a
2459         newline.
2460         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2461         warning with a newline.
2462         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2463         newline.
2464         (s12z_frame_cache): Likewise.
2465         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2466         a newline.
2467         * solib-svr4.c (disable_probes_interface): Don't end warning with
2468         a newline.
2469         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2470         newline.
2471         * python/python.c (do_finish_initialization): Don't end warning
2472         with a newline.
2473
2474 2019-06-10  Tom Tromey  <tom@tromey.com>
2475
2476         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2477         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2478         gdbpy_enter.
2479
2480 2019-06-10  Tom Tromey  <tromey@adacore.com>
2481
2482         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2483         data.
2484         (elf_new_init): Don't call stabsread_new_init.
2485         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2486         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2487         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2488
2489 2019-06-10  Tom de Vries  <tdevries@suse.de>
2490
2491         PR symtab/16264
2492         PR symtab/24517
2493         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2494
2495 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2496
2497         * source.c (find_and_open_source): Also rewrite relative file
2498         names.
2499
2500 2019-04-26  Amos Bird  <amosbird@gmail.com>
2501
2502         * annotate.c (annotate_thread_exited): Add "thread-exited"
2503         annotation.
2504
2505 2019-06-06  Tom Tromey  <tromey@adacore.com>
2506
2507         * maint.h (class scoped_command_stats): Use
2508         DISABLE_COPY_AND_ASSIGN.
2509         <print_time>: New method.
2510         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2511         print_time.
2512         (scoped_command_stats::print_time): New method.
2513
2514 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2515
2516         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2517         instructions of lengths 6 or 8 bytes.
2518
2519 2019-06-04  Pedro Alves  <palves@redhat.com>
2520
2521         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2522
2523         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2524         * breakpoint.c (condition_completer): Likewise.
2525         * cli/cli-dump.c (scan_expression): Likewise.
2526         * common/filestuff.c (mkdir_recursive): Likewise.
2527         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2528         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2529         (gdb_abspath): Likewise.
2530         * compile/compile-cplus-types.c
2531         (compile_cplus_instance::decl_name): Likewise.
2532         * completer.c (complete_explicit_location):
2533         (signal_completer, reg_or_group_completer_1): Likewise.
2534         * cp-support.c (cp_remove_params_if_any): Likewise.
2535         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2536         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2537         * infcmd.c (strip_bg_char): Likewise.
2538         * linespec.c (copy_token_string): Likewise.
2539         * mi/mi-main.c (output_cores): Likewise.
2540         * psymtab.c (psymtab_search_name):
2541         * symfile.c (test_set_ext_lang_command): Likewise.
2542         * target.c (target_fileio_read_stralloc): Likewise.
2543         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2544         * value.c (complete_internalvar): Likewise.
2545
2546 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2547
2548         Add objfile property to gdb.Type.
2549         * NEWS: Mention Python API addition.
2550         * python/py-type.c (typy_get_objfile): New method.
2551
2552 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2553
2554         * NEWS: Mention the new set|show style [title|highlight].
2555         Mention changes to "show style", "help" and "apropos".
2556
2557 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2558
2559         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2560         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2561         instead of print_help_for_command.
2562         (print_doc_of_command): New function.
2563         (help_list): Add 'apropos -v word' suggestion.
2564         (print_help_for_command): Style the command name using title style.
2565         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2566         (_initialize_cli_cmds): Describe -v in apropos_command help.
2567
2568 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2569
2570         * cli/cli-style.h (cli_style_option): Add name in constructor,
2571         add m_name class member, add constructor with intensity,
2572         add name class function.
2573         (cli_style_option::add_setshow_commands): Remove name argument.
2574         (highlight_style, title_style): New styles.
2575         * cli/cli-style.c (do_show): New function that shows a style
2576         characteristic styling the style name with itself.
2577         (set_style_name): New function.
2578         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2579         Update all callers according to the changes in cli/cli-style.h.
2580         * utils.h (fputs_highlighted): New function.
2581         * utils.c (fputs_highlighted): Likewise.
2582
2583 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2584
2585         * NEWS: Mention new pipe command and new convenience variables.
2586
2587 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2588
2589         * cli/cli-cmds.c (pipe_command): New function.
2590         (_initialize_cli_cmds): Call add_com for pipe_command.
2591         Define | as an alias for pipe.
2592         (exit_status_set_internal_vars): New function.
2593         (shell_escape): Call exit_status_set_internal_vars.
2594         cli/cli-decode.c (find_command_name_length): Recognize | as
2595         a single character command.
2596
2597 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2598
2599         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2600         top.c (execute_command_to_ui_file): New function, mostly a copy
2601         of execute_command_to_string.
2602         (execute_command_to_string): Implement by calling
2603         execute_command_to_ui_file.
2604
2605 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2606
2607         * top.h (saved_command_line): Remove declaration.
2608         * top.c (previous_saved_command_line, previous_repeat_arguments):
2609         New variables.
2610         (saved_command_line): Make static, define together with other
2611         'repeat variables'.
2612         (dont_repeat): Clear repeat_arguments.
2613         (repeat_previous, get_saved_command_line, save_command_line):
2614         New functions.
2615         (gdb_init): Initialize saved_command_line
2616         and previous_saved_command_line.
2617         * main.c (captured_main_1): Remove saved_command_line initialization.
2618         * event-top.c (handle_line_of_input): Update to use
2619         the new 'repeat' related functions instead of direct access to
2620         saved_command_line.
2621         * command.h (repeat_previous, get_saved_command_line,
2622         save_command_line): New declarations.
2623         (dont_repeat): Add comment.
2624
2625 2019-05-30  Tom Tromey  <tromey@adacore.com>
2626
2627         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2628         Fix comment.
2629         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2630
2631 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2632
2633         PR cli/24587
2634         * completer.c (complete): Initialize variable word.
2635
2636 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2637
2638         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2639         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2640         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2641         'body' is NULL to the outter 'if', protecting the '!is_define'
2642         situation as well.
2643
2644 2019-05-29  Tom Tromey  <tromey@adacore.com>
2645
2646         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2647         (dwarf_unknown): New function.
2648         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2649         (dwarf_type_encoding_name): Use dwarf_unknown.
2650
2651 2019-05-29  Tom Tromey  <tromey@adacore.com>
2652
2653         PR c++/20020:
2654         * cp-valprint.c (cp_print_value_fields): Call
2655         cp_print_static_field inside "try".
2656
2657 2019-05-29  Tom Tromey  <tromey@adacore.com>
2658
2659         * inflow.c (struct terminal_info): Add default operator=.
2660         * configure: Rebuild.
2661         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2662         -Wdeprecated-copy-dtor, -Wredundant-move.
2663
2664 2019-05-29  Tom Tromey  <tromey@adacore.com>
2665
2666         * NEWS: Add entry.
2667         * infcmd.c (print_return_value_1): Handle finish_print
2668         option.
2669         (show_print_finish): New function.
2670         (_initialize_infcmd): Add "set/show print finish" commands.
2671         * valprint.c (user_print_options): Initialize new member.
2672         * valprint.h (struct value_print_options) <finish_print>: New
2673         member.
2674
2675 2019-05-28  Tom Tromey  <tromey@adacore.com>
2676
2677         * ada-lang.c (ada_remove_Xbn_suffix)
2678         (find_old_style_renaming_symbol)
2679         (parse_old_style_renaming): Remove.
2680         (ada_find_renaming_symbol): Don't call
2681         find_old_style_renaming_symbol.
2682         (ada_is_renaming_symbol): Rename from
2683         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2684         bool.  Now static.
2685         (ada_read_var_value): Update and simplify.
2686         * ada-exp.y (write_var_or_type): Remove old code.
2687
2688 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2689
2690         * event-top.c: Remove include comment.
2691         * inflow.c (class scoped_ignore_sigttou): Move from here...
2692         * inflow.h (class scoped_ignore_sigttou): ...to here.
2693         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2694         * top.c:  Remove include comment.
2695
2696 2019-05-27  Tom Tromey  <tom@tromey.com>
2697
2698         * NEWS: Fix typo.
2699
2700 2019-05-22  Tom Tromey  <tromey@adacore.com>
2701
2702         * target.c (target_follow_exec): Constify parameter.
2703         * target-delegates.c: Rebuild.
2704         * remote.c (remote_target::follow_exec): Constify parameter.
2705         * infrun.c (follow_exec): Constify parameter.
2706         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2707         (target_follow_exec): Likewise.
2708
2709 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2710
2711         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2712         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2713
2714 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2715
2716         * NEWS: Add debugredirect and testsuite sections.
2717
2718 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2719
2720         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2721         target descriptions using exclusively floating point register name
2722         aliases.
2723
2724 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2725
2726         PR gdb/18644:
2727         * f-lang.c (build_fortran_types): Handle the case where
2728         gdbarch_floatformat_for_type returns a nullptr.
2729
2730 2019-05-21  Tom de Vries  <tdevries@suse.de>
2731
2732         PR cli/24587
2733         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2734
2735 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2736
2737         PR gdb/18644:
2738         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2739         16-byte floats.
2740         * i386-tdep.c (i386_floatformat_for_type): Use
2741         floatformats_ia64_quad for the 16-byte floating point component
2742         within a fortran 32-byte complex number.
2743
2744 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2745
2746         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2747         delete default constructor.
2748         (find_partial_die): Update to return const struct.
2749         (partial_die_parent_scope): Move variable declaration into scope
2750         of its use and change its type to auto.
2751         (guess_partial_die_structure_name): Likewise.
2752         (partial_die_info::fixup): Likewise.
2753
2754 2019-05-17  Tom Tromey  <tromey@adacore.com>
2755
2756         * source.c (find_and_open_source): Remove cast.
2757
2758 2019-05-17  Tom Tromey  <tromey@adacore.com>
2759
2760         * annotate.c (annotate_source): Make "filename" const.
2761         * annotate.h (annotate_source): Use const.
2762
2763 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2764
2765         * disasm.c (set_disassembler_options): Send errors to stderr.
2766
2767 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2768
2769         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2770         (cli_interp_base::set_logging): Check debug_redirect.
2771         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2772         * cli/cli-logging.c (debug_redirect): Add static variable.
2773         (pop_output_files): Add default param.
2774         (handle_redirections): Print debug setting.
2775         (show_logging_command): Likewise.
2776         (_initialize_cli_logging): Add debugredirect command.
2777         * interps.c (current_interp_set_logging): Add debug_redirect
2778         parameter.
2779         * interps.h (set_logging): Add debug_redirect parameter.
2780         (current_interp_set_logging): Likewise.
2781         * mi/mi-common.h: Likewise.
2782         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2783
2784 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2785             Tom Tromey  <tromey@adacore.com>
2786
2787         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2788         directly.
2789         * cli/cli-interp.h (make_logging_output): Remove declaration.
2790         * cli/cli-logging.c (make_logging_output): Remove function.
2791         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2792         directly.
2793         * ui-file.c (tee_file::tee_file): Remove bools.
2794         (tee_file::~tee_file): Remove deletes.
2795         * ui-file.h (tee_file): Remove bools.
2796
2797 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2798
2799         * mi/mi-cmds.h (mi_cmd_complete): New function.
2800         * mi/mi-main.c (mi_cmd_complete): Likewise.
2801         * mi/mi-cmds.c: Define new MI command -complete.
2802         * NEWS: Mention new -complete command.
2803
2804 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2805
2806         * completer.h (complete): New function.
2807         * completer.c (complete): Likewise.
2808         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2809         function defined in completer.h.
2810
2811 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2812
2813         * MAINTAINERS (Write After Approval): Add myself.
2814
2815 2019-05-17  Tom de Vries  <tdevries@suse.de>
2816
2817         PR gdb/24094
2818         * dwarf2read.c (struct cu_partial_die_info): New struct.
2819         (find_partial_die): Return cu_partial_die_info.
2820         (partial_die_parent_scope, guess_partial_die_structure_name)
2821         (partial_die_info::fixup): Handle new return type of find_partial_die.
2822
2823 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2824
2825         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2826         "std::string", simplifying the algorithm.
2827
2828 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2829
2830         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2831         (stap_static_probe_ops::get_probes): Likewise.
2832
2833 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2834
2835         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2836         '-')" and "else if".
2837         (stap_parse_single_operand): Join checks for
2838         "gdbarch_stap_parse_special_token_p" and
2839         "gdbarch_stap_parse_special_token" in the same "if" statement.
2840         Invert check when verifying for operation on register
2841         displacement.
2842
2843 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2844
2845         * stap-probe.c (stap_get_opcode): Update comment.
2846         (stap_get_expected_argument_type): Likewise.
2847         (handle_stap_probe): Likewise.
2848
2849 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2850
2851         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2852         return type to 'bool'.  Adjust comment.  Use 'bool' when
2853         appropriate.
2854         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2855         * stap-probe.c (stap_parse_argument_1): Likewise.
2856         (stap_is_operator): Likewise.
2857         (stap_is_generic_prefix): Likewise.
2858         (stap_is_register_prefix): Likewise.
2859         (stap_is_register_indirection_prefix): Likewise.
2860         (stap_is_integer_prefix): Likewise.
2861         (stap_generic_check_suffix): Likewise.
2862         (stap_check_integer_suffix): Likewise.
2863         (stap_check_register_suffix): Likewise.
2864         (stap_check_register_indirection_suffix): Likewise.
2865         (stap_parse_register_operand): Likewise.
2866         (stap_parse_single_operand): Likewise.
2867         (stap_parse_argument_1): Likewise.
2868         (stap_probe::get_argument_count): Likewise.
2869         (stap_is_operator): Likewise.
2870
2871 2019-05-16  Tom Tromey  <tromey@adacore.com>
2872
2873         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2874         keyword to foreach.
2875
2876 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2877
2878         * linux-thread-db.c (try_thread_db_load_1): Change return type
2879         to bool.
2880         (try_thread_db_load): Likewise.
2881         (try_thread_db_load_from_pdir_1): Likewise.
2882         (try_thread_db_load_from_pdir): Likewise.
2883         (try_thread_db_load_from_sdir): Likewise.
2884         (try_thread_db_load_from_dir): Likewise.
2885         (thread_db_load_search): Likewise.
2886         (has_libpthread): Likewise.
2887         (thread_db_load): Likewise.
2888
2889 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2890
2891         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2892         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2893         NULL, and complain/return if that's the case.
2894
2895 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2896
2897         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2898         (advance, posn, abstract_read_memory): New functions.
2899         [struct mem_read_abstraction]: New struct.
2900         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2901
2902 2019-05-14  Tom Tromey  <tromey@adacore.com>
2903
2904         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2905         value is not lval_memory.
2906
2907 2019-05-14  Tom Tromey  <tromey@adacore.com>
2908
2909         * solib.c (info_sharedlibrary_command): Style the file name.
2910
2911 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2912
2913         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2914         (aarch64_vnv_type): Likewise.
2915         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2916         * common/tdesc.c: Likewise.
2917         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2918         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2919         * features/aarch64-fpu.xml: Add ieee half view.
2920         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2921         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2922         * gdbtypes.h (struct builtin_type): Likewise.
2923         (struct objfile_type): Likewise.
2924
2925 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2926
2927         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2928         typo.
2929         * location.h (string_to_event_location): Likewise.
2930
2931 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2932
2933         GDB 8.3 released.
2934
2935 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2936
2937         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2938         New variable declaration.
2939         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2940         New variable.
2941         (print_one_breakpoint): Use ui_out::test_flags and new global
2942         variable to compute use_fixed_output.
2943         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2944         Remove.
2945         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2946         (mi_multi_location_breakpoint_output_fixed): Remove.
2947         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2948         new variable.
2949         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2950         fix_multi_location_breakpoint_output flag if version >= 3.
2951         * ui-out.h (enum ui_out_flag)
2952         <fix_multi_location_breakpoint_output>: New enumerator.
2953
2954 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2955
2956         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2957
2958 2019-05-10  Tom Tromey  <tromey@adacore.com>
2959
2960         * ada-lang.c (catch_ada_completer): New function.
2961         (_initialize_ada_language): Use it.
2962
2963 2019-05-10  Tom Tromey  <tromey@adacore.com>
2964
2965         * thread.c (print_thread_info): Make "requested_threads" const.
2966         * gdbthread.h (print_thread_info): Make "requested_threads"
2967         const.
2968         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2969         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2970
2971 2019-05-08  Tom Tromey  <tom@tromey.com>
2972
2973         * gdbtypes.c (objfile_type_data): Change type.
2974         (objfile_type, _initialize_gdbtypes): Update.
2975
2976 2019-05-08  Tom Tromey  <tom@tromey.com>
2977
2978         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2979         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2980         (_initialize_dwarf2_frame): Update.
2981
2982 2019-05-08  Tom Tromey  <tom@tromey.com>
2983
2984         * objc-lang.c (objc_objfile_data): Change type.
2985         (find_methods): Update.
2986         (_initialize_objc_lang): Remove.
2987
2988 2019-05-08  Tom Tromey  <tom@tromey.com>
2989
2990         * stabsread.c (rs6000_builtin_type_data): Change type.
2991         (rs6000_builtin_type, _initialize_stabsread): Update.
2992
2993 2019-05-08  Tom Tromey  <tom@tromey.com>
2994
2995         * mips-tdep.c (mips_pdr_data): Remove.
2996         (_initialize_mips_tdep): Update.
2997
2998 2019-05-08  Tom Tromey  <tom@tromey.com>
2999
3000         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3001         (hppa_init_objfile_priv_data, read_unwind_info)
3002         (find_unwind_entry, _initialize_hppa_tdep): Update.
3003
3004 2019-05-08  Tom Tromey  <tom@tromey.com>
3005
3006         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3007         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3008         on obstack.
3009         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3010
3011 2019-05-08  Tom Tromey  <tom@tromey.com>
3012
3013         * mdebugread.c (basic_type_data): Change type.
3014         (basic_type, _initialize_mdebugread): Update.
3015
3016 2019-05-08  Tom Tromey  <tom@tromey.com>
3017
3018         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3019
3020 2019-05-08  Tom Tromey  <tom@tromey.com>
3021
3022         * nto-tdep.c (nto_inferior_data_reg): Change type.
3023         (nto_inferior_data): Update.
3024         (nto_inferior_data_cleanup, nto_new_inferior_data)
3025         (_initialize_nto_tdep): Remove.
3026         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3027
3028 2019-05-08  Tom Tromey  <tom@tromey.com>
3029
3030         * ada-lang.c (struct ada_inferior_data): Add initializers.
3031         (ada_inferior_data): Change type.
3032         (ada_inferior_data_cleanup): Remove.
3033         (get_ada_inferior_data, ada_inferior_exit)
3034         (struct ada_pspace_data): Add initializers, destructor.
3035         (ada_pspace_data_handle): Change type.
3036         (get_ada_pspace_data): Update.
3037         (ada_pspace_data_cleanup): Remove.
3038
3039 2019-05-08  Tom Tromey  <tom@tromey.com>
3040
3041         * coffread.c (struct coff_symfile_info): Add initializers.
3042         (coff_objfile_data_key): Move lower.  Change type.
3043         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3044         Update.
3045         (coff_free_info): Remove.
3046
3047 2019-05-08  Tom Tromey  <tom@tromey.com>
3048
3049         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3050         (fbsd_pspace_data_handle): Move lower.  Change type.
3051         (get_fbsd_pspace_data): Update.
3052         (fbsd_pspace_data_cleanup): Remove.
3053         (_initialize_fbsd_tdep): Update.
3054
3055 2019-05-08  Tom Tromey  <tom@tromey.com>
3056
3057         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3058         (get_ada_tasks_pspace_data): Update.
3059         (ada_tasks_pspace_data_cleanup): Remove.
3060         (_initialize_tasks): Update.
3061         (ada_tasks_inferior_data_handle): Change type.
3062         (get_ada_tasks_inferior_data): Update.
3063         (ada_tasks_inferior_data_cleanup): Remove.
3064         (struct ada_tasks_pspace_data): Add initializers.
3065
3066 2019-05-08  Tom Tromey  <tom@tromey.com>
3067
3068         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3069         * symfile-debug.c (debug_sym_get_probes): Change type.
3070         * stap-probe.c (handle_stap_probe):
3071         (stap_static_probe_ops::get_probes): Change type.
3072         * probe.h (class static_probe_ops) <get_probes>: Change type.
3073         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3074         (parse_probes_in_pspace): Update.
3075         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3076         Update.
3077         (any_static_probe_ops::get_probes): Change type.
3078         * elfread.c (elfread_data): New typedef.
3079         (probe_key): Change type.
3080         (elf_get_probes): Likewise.  Update.
3081         (probe_key_free): Remove.
3082         (_initialize_elfread): Update.
3083         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3084         Change type.
3085         (dtrace_process_dof_probe, dtrace_process_dof)
3086         (dtrace_static_probe_ops::get_probe): Change type.
3087
3088 2019-05-08  Tom Tromey  <tom@tromey.com>
3089
3090         * xcoffread.c (struct xcoff_symfile_info): Rename from
3091         coff_symfile_info.  Add initializers.
3092         (xcoff_objfile_data_key): Move lower.  Change type.
3093         (XCOFF_DATA): Rewrite.
3094         (xcoff_free_info): Remove.
3095         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3096         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3097         (xcoff_initial_scan): Update.
3098
3099 2019-05-08  Tom Tromey  <tom@tromey.com>
3100
3101         * solib-svr4.c (struct svr4_info): Add initializers and
3102         destructor.
3103         <probes_table>: Now an htab_up.
3104         (solib_svr4_pspace_data): Change type.
3105         (free_probes_table): Simplify.
3106         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3107         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3108         (probes_table_remove_objfile_probes, register_solib_event_probe)
3109         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3110         (_initialize_svr4_solib): Update.
3111
3112 2019-05-08  Tom Tromey  <tom@tromey.com>
3113
3114         * remote.c (remote_pspace_data): Change type.
3115         (remote_pspace_data_cleanup): Remove.
3116         (get_remote_exec_file, set_pspace_remote_exec_file)
3117         (_initialize_remote): Update.
3118
3119 2019-05-08  Tom Tromey  <tom@tromey.com>
3120
3121         * breakpoint.c (breakpoint_objfile_key): Change type.
3122         (get_breakpoint_objfile_data): Update.
3123         (free_breakpoint_objfile_data): Remove.
3124         (_initialize_breakpoint): Update.
3125
3126 2019-05-08  Tom Tromey  <tom@tromey.com>
3127
3128         * linux-tdep.c (struct linux_info): Add initializers.
3129         (linux_inferior_data): Move.  Change type.
3130         (invalidate_linux_cache_inf): Update.
3131         (linux_inferior_data_cleanup): Remove.
3132         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3133
3134 2019-05-08  Tom Tromey  <tom@tromey.com>
3135
3136         * auxv.c (auxv_inferior_data): Move.  Change type.
3137         (auxv_inferior_data_cleanup): Remove.
3138         (invalidate_auxv_cache_inf): Rewrite.
3139         (get_auxv_inferior_data, _initialize_auxv): Update.
3140
3141 2019-05-08  Tom Tromey  <tom@tromey.com>
3142
3143         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3144         (symfile_debug_objfile_data_key): Change type.
3145         (symfile_debug_installed, debug_qf_has_symbols)
3146         (debug_qf_find_last_source_symtab)
3147         (debug_qf_forget_cached_source_info)
3148         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3149         (debug_qf_print_stats, debug_qf_dump)
3150         (debug_qf_expand_symtabs_for_function)
3151         (debug_qf_expand_all_symtabs)
3152         (debug_qf_expand_symtabs_with_fullname)
3153         (debug_qf_map_matching_symbols)
3154         (debug_qf_expand_symtabs_matching)
3155         (debug_qf_find_pc_sect_compunit_symtab)
3156         (debug_qf_map_symbol_filenames)
3157         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3158         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3159         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3160         (debug_sym_read_linetable, debug_sym_relocate): Update.
3161         (symfile_debug_free_objfile): Remove.
3162         (install_symfile_debug_logging, _initialize_symfile_debug):
3163         Update.
3164
3165 2019-05-08  Tom Tromey  <tom@tromey.com>
3166
3167         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3168         allocate_on_obstack.
3169         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3170         (get_dwarf2_per_objfile): Update.
3171         (set_dwarf2_per_objfile): Remove.
3172         (dwarf2_has_info, dwarf2_get_section_info): Update.
3173         (dwarf2_free_objfile): Remove.
3174         (_initialize_dwarf2_read): Update.
3175
3176 2019-05-08  Tom Tromey  <tom@tromey.com>
3177
3178         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3179         initializers.
3180         <unsupported_script_warning_printed,
3181         script_not_found_warning_printed>: Now bool.
3182         (auto_load_pspace_data): Change type.
3183         (~auto_load_pspace_info): Rename from
3184         auto_load_pspace_data_cleanup.
3185         (get_auto_load_pspace_data, init_loaded_scripts_info)
3186         (clear_section_scripts, maybe_print_unsupported_script_warning)
3187         (maybe_print_script_not_found_warning, _initialize_auto_load):
3188         Update.
3189
3190 2019-05-08  Tom Tromey  <tom@tromey.com>
3191
3192         * objfiles.c (objfile_pspace_info): Add destructor and
3193         initializers.
3194         (objfiles_pspace_data): Change type.
3195         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3196         (get_objfile_pspace_data): Update.
3197         (objfiles_bfd_data): Change type.
3198         (get_objfile_bfd_data): Update.
3199         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3200
3201 2019-05-08  Tom Tromey  <tom@tromey.com>
3202
3203         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3204         Change type.
3205         (get_catch_syscall_inferior_data): Update.
3206         (catch_syscall_inferior_data_cleanup): Remove.
3207         (_initialize_break_catch_syscall): Update.
3208
3209 2019-05-08  Tom Tromey  <tom@tromey.com>
3210
3211         * inflow.c (struct terminal_info): Add destructor and
3212         initializers.
3213         (inflow_inferior_data): Change type.
3214         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3215         (get_inflow_inferior_data, inflow_inferior_exit)
3216         (swap_terminal_info, _initialize_inflow): Update.
3217
3218 2019-05-08  Tom Tromey  <tom@tromey.com>
3219
3220         * target-dcache.c (target_dcache_cleanup): Remove.
3221         (target_dcache_aspace_key): Change type.
3222         (target_dcache_init_p, target_dcache_invalidate)
3223         (target_dcache_get, target_dcache_get_or_init)
3224         (_initialize_target_dcache): Update.
3225         * dcache.h (struct dcache_deleter): New.
3226
3227 2019-05-08  Tom Tromey  <tom@tromey.com>
3228
3229         * symtab.c (struct symbol_cache): Add destructor and
3230         initializers.
3231         (symbol_cache_key): Move.  Change type.
3232         (make_symbol_cache, free_symbol_cache): Remove.
3233         (get_symbol_cache): Update.
3234         (symbol_cache_cleanup): Remove.
3235         (ALL_PSPACES, symbol_cache_flush)
3236         (maintenance_print_symbol_cache)
3237         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3238         Update.
3239
3240 2019-05-08  Tom Tromey  <tom@tromey.com>
3241
3242         * symtab.c (struct main_info): Add destructor and initializers.
3243         (main_progspace_key): Move.  Change type.
3244         (get_main_info): Update.
3245         (main_info_cleanup): Remove.
3246         (_initialize_symtab): Update.
3247
3248 2019-05-08  Tom Tromey  <tom@tromey.com>
3249
3250         * registry.h (DECLARE_REGISTRY): Define the _key class.
3251
3252 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3253
3254         * NEWS: Merge two 'New commands' sections.
3255
3256 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3257
3258         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3259         parameter and use Ada language definition instead.
3260         (ada_val_print_ptr): Remove unused language parameter.
3261         (ada_val_print_num): Remove language parameter and use Ada language
3262         definition instead.
3263         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3264         parameter.
3265         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3266         parameter and use Ada language definition instead.
3267         (ada_val_print_1): Update all ada_val_print_xxx calls.
3268         Remove language parameter.
3269         (ada_val_print): Update ada_val_print_1 call.
3270
3271 2019-05-08  Tom Tromey  <tromey@adacore.com>
3272
3273         * remote.c (remote_hw_watchpoint_limit)
3274         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3275         Now static.
3276
3277 2019-05-08  Tom Tromey  <tromey@adacore.com>
3278
3279         * maint.c (_initialize_maint_cmds): Move initialization code to
3280         remote.c.
3281         (watchdog, show_watchdog): Move to remote.c.
3282         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3283         "watchdog" static.
3284         (_initialize_remote): Move initialization code from maint.c.
3285         * defs.h (watchdog): Don't declare.
3286
3287 2019-05-08  Tom Tromey  <tromey@adacore.com>
3288
3289         * tui/tui-interp.c: Include main.h.
3290         * interps.c: Include main.h.
3291         * main.h (interpreter_p): Declare.
3292         * defs.h (interpreter_p): Don't declare.
3293
3294 2019-05-08  Tom Tromey  <tromey@adacore.com>
3295
3296         * dwarf2loc.c: Include dwarf2read.h.
3297         * defs.h (read_unsigned_leb128): Don't declare.
3298         * dwarf2read.h (read_unsigned_leb128): Declare.
3299
3300 2019-05-08  Tom Tromey  <tromey@adacore.com>
3301
3302         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3303         method.
3304
3305 2019-05-08  Tom Tromey  <tromey@adacore.com>
3306
3307         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3308         when no wrap column is set.
3309
3310 2019-05-08  Tom Tromey  <tromey@adacore.com>
3311
3312         * c-lang.c (c_get_string): Handle non-C-style arrays.
3313
3314 2019-05-08  Tom Tromey  <tromey@adacore.com>
3315
3316         * typeprint.c (print_offset_data::update): Print the bit offset,
3317         not the number of bits remaining.
3318
3319 2019-05-08  Tom Tromey  <tromey@adacore.com>
3320
3321         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3322         padding at end of comment.
3323
3324 2019-05-08  Tom Tromey  <tromey@adacore.com>
3325
3326         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3327         Compare main types.
3328
3329 2019-05-06  Tom Tromey  <tom@tromey.com>
3330
3331         * common/scoped_mmap.c: Include common-defs.h.
3332         * common/scoped_mmap.h: Don't include config.h.
3333
3334 2019-05-04  Tom Tromey  <tom@tromey.com>
3335
3336         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3337         (struct aarch64_call_info): Add initializers.
3338         <si>: Now a std::vector.
3339         (pass_on_stack, aarch64_push_dummy_call): Update.
3340
3341 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3342             Tom Tromey  <tom@tromey.com>
3343
3344         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3345         (ppc_threads): Now a std::vector.  Now static.
3346         (hwdebug_find_thread_points_by_tid)
3347         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3348         Update.
3349
3350 2019-05-04  Tom Tromey  <tom@tromey.com>
3351
3352         * arc-tdep.c (arc_tdesc_init): Return bool.
3353
3354 2019-05-04  Tom Tromey  <tom@tromey.com>
3355
3356         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3357         Use gdb_assert_not_reached.
3358
3359 2019-05-04  Tom Tromey  <tom@tromey.com>
3360
3361         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3362         "false".
3363
3364 2019-05-04  Tom Tromey  <tom@tromey.com>
3365
3366         * arc-tdep.c (arc_tdesc_init): Use bool.
3367
3368 2019-05-04  Tom Tromey  <tom@tromey.com>
3369
3370         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3371
3372 2019-05-04  Tom Tromey  <tom@tromey.com>
3373
3374         * cli/cli-cmds.c (valid_command_p): Return bool.
3375
3376 2019-05-04  Tom Tromey  <tom@tromey.com>
3377
3378         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3379         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3380
3381 2019-05-04  Raul Tambre  <raul@tambre.ee>
3382
3383         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3384         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3385         operator for comparison.
3386
3387 2019-05-04  Tom Tromey  <tom@tromey.com>
3388
3389         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3390         (lookup_partial_symbol, print_partial_symbols)
3391         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3392         (psymbol_compare): Update.
3393         (add_psymbol_to_bcache): Clear the entire psymbol.
3394         (maintenance_check_psymtabs): Update.
3395         * psympriv.h (struct partial_symbol): Don't derive from
3396         general_symbol_info.
3397         <obj_section, unrelocated_address, address,
3398         set_unrelocated_address>: Update.
3399         <ginfo>: New member.
3400         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3401         (debug_names::write_psymbols): Update.
3402
3403 2019-05-04  Tom de Vries  <tdevries@suse.de>
3404
3405         * contrib/cc-with-tweaks.sh: Support -n arg.
3406
3407 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3408
3409         * corelow.c (core_target::detach): Ensure frame cache and
3410         register caches are cleared.
3411         inferior.c (exit_inferior_1): Likewise.
3412
3413 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3414             Tom Tromey  <tom@tromey.com>
3415
3416         * dictionary.c (collate_pending_symbols_by_language): Remove
3417         "struct" from foreach.
3418         * symtab.c (lookup_global_symbol_from_objfile)
3419         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3420         foreach.
3421         * ser-tcp.c (net_open): Remove "struct" from foreach.
3422         * objfiles.c (objfile_relocate, objfile_rebase)
3423         (objfile_has_symbols): Remove "struct" from foreach.
3424         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3425         from foreach.
3426         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3427         foreach.
3428         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3429         "struct" from foreach.
3430         * ada-lang.c (create_excep_cond_exprs)
3431         (ada_exception_catchpoint_cond_string): Remove "struct" from
3432         foreach.
3433
3434 2019-05-03  Tom Tromey  <tromey@adacore.com>
3435
3436         * ada-exp.y (convert_char_literal): Check suffix of each
3437         enumerator.
3438
3439 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3440
3441         PR ada/21406:
3442         * ada-exp.y (yywrap): Don't define.
3443         * ada-lex.l (%option): Add noyywrap
3444         (yywrap): Remove.
3445
3446 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3447
3448         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3449         _WIN32_WINNT to the XP level, unless already defined to a higher
3450         level.
3451
3452         * unittests/parse-connection-spec-selftests.c:
3453         * ser-tcp.c:
3454         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3455         override.
3456
3457         * symfile.c (find_separate_debug_file): Remove colon from the
3458         drive spec of DOS/Windows file names of the target, so that the
3459         file name produced from DEBUGDIR and the target's directory will
3460         be valid on DOS/Windows systems.
3461
3462 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3463
3464         * rust-lang.c (val_print_struct): Handle printing structures
3465         containing strings.
3466
3467 2019-05-02  Tom Tromey  <tromey@adacore.com>
3468
3469         * valarith.c (_initialize_valarith): Remove.
3470
3471 2019-05-01  Tom Tromey  <tromey@adacore.com>
3472
3473         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3474         bitfields.
3475
3476 2019-05-01  Tom Tromey  <tromey@adacore.com>
3477
3478         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3479         for big-endian copies.
3480
3481 2019-04-30  Ali Tamur  <tamur@google.com>
3482         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3483         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3484         (read_3_bytes): New function.
3485
3486 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3487
3488         * windows-nat.c (main_thread_id): Delete.
3489         (handle_output_debug_string): Replace main_thread_id by
3490         current_event.dwThreadId.
3491         (fake_create_process): Likewise.
3492         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3493         Do not set main_thread_id.
3494         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3495         current_event.dwThreadId.
3496         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3497
3498 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3499
3500         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3501         Use current_event.dwThreadId instead of main_thread_id.
3502
3503 2019-04-30  Tom Tromey  <tromey@adacore.com>
3504
3505         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3506         (create_excep_cond_exprs): Iterate over program spaces.
3507         (ada_exception_catchpoint_cond_string): Examine all minimal
3508         symbols for exception types.
3509
3510 2019-04-30  Tom Tromey  <tromey@adacore.com>
3511
3512         PR c++/24470:
3513         * dwarf2read.c (process_structure_scope): Handle case where type
3514         has template parameters but no symbol was created.
3515
3516 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3517             Chris January  <chris.january@arm.com>
3518
3519         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3520         qualifier.
3521         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3522
3523 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3524
3525         * f-typeprint.c (f_print_type): Update rules for printing
3526         whitespace.
3527         (f_type_print_varspec_suffix): Likewise.
3528
3529 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3530             Chris January  <chris.january@arm.com>
3531
3532         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3533         function arguments.
3534
3535 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3536
3537         * f-lang.c (build_fortran_types): Change name of void type to
3538         lower case.
3539         * f-typeprint.c (f_type_print_base): Print the name of the void
3540         type, rather than a fixed string.
3541         * f-valprint.c (f_decorations): Use lower case void string.
3542
3543 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3544             Chris January  <chris.january@arm.com>
3545
3546         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3547         types for Fortran.
3548
3549 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3550             Chris January  <chris.january@arm.com>
3551             David Lecomber  <david.lecomber@arm.com>
3552
3553         * f-exp.y (BINOP_INTRINSIC): New token.
3554         (exp): New parser rule handling BINOP_INTRINSIC.
3555         (f77_keywords): Add new builtin procedures.
3556         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3557         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3558         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3559         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3560         (print_unop_subexp_f): New function.
3561         (print_binop_subexp_f): New function.
3562         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3563         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3564         (dump_subexp_body_f): Likewise.
3565         (operator_check_f): Likewise.
3566         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3567         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3568
3569 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3570
3571         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3572         UNOP_KIND.
3573         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3574         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3575         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3576         (operator_length_f): New fuction.
3577         (print_subexp_f): New function.
3578         (op_name_f): New function.
3579         (dump_subexp_body_f): New function.
3580         (operator_check_f): New function.
3581         (exp_descriptor_f): Replace standard expression handling functions
3582         with new functions.
3583         * gdb/fortran-operator.def: New file.
3584         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3585         * gdb/std-operator.def: Remove UNOP_KIND.
3586
3587 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3588
3589         * std-operator.def: Remove unbalanced, stray double quote
3590         character.
3591
3592 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3593             Chris January  <chris.january@arm.com>
3594             Daniel Everett  <daniel.everett@arm.com>
3595             Nick Forrington  <nick.forrington@arm.com>
3596             Richard Bunt  <richard.bunt@arm.com>
3597
3598         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3599         of depth when printing anonymous structs or unions.
3600         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3601         Don't print either the top-level value, or the children if the
3602         max-depth is exceeded.
3603         (ppscm_print_children): When printing the key of a map, allow one
3604         extra level of depth.
3605         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3606         print either the top-level value, or the children if the max-depth
3607         is exceeded.
3608         (print_children): When printing the key of a map, allow one extra
3609         level of depth.
3610         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3611         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3612         (user_print_options): Initialise max_depth field.
3613         (val_print_scalar_or_string_type_p): New function.
3614         (val_print): Check to see if the max depth has been reached.
3615         (val_print_check_max_depth): Define new function.
3616         (show_print_max_depth): New function.
3617         (_initialize_valprint): Add 'print max-depth' option.
3618         * valprint.h (struct value_print_options) <max_depth>: New field.
3619         (val_print_check_max_depth): Declare new function.
3620         * NEWS: Document new feature.
3621
3622 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3623
3624         * ada-lang.c (ada_language_defn): Initialise new field.
3625         * c-lang.c (c_is_string_type_p): New function.
3626         (c_language_defn): Initialise new field.
3627         (cplus_language_defn): Initialise new field.
3628         (asm_language_defn): Initialise new field.
3629         (minimal_language_defn): Initialise new field.
3630         * c-lang.h (c_is_string_type_p): Declare new function.
3631         * d-lang.c (d_language_defn): Initialise new field.
3632         * f-lang.c (f_is_string_type_p): New function.
3633         (f_language_defn): Initialise new field.
3634         * go-lang.c (go_is_string_type_p): New function.
3635         (go_language_defn): Initialise new field.
3636         * language.c (default_is_string_type_p): New function.
3637         (unknown_language_defn): Initialise new field.
3638         (auto_language_defn): Initialise new field.
3639         * language.h (struct language_defn) <la_is_string_type_p>: New
3640         member variable.
3641         (default_is_string_type_p): Declare new function.
3642         * m2-lang.c (m2_language_defn): Initialise new field.
3643         * objc-lang.c (objc_language_defn): Initialise new field.
3644         * opencl-lang.c (opencl_language_defn): Initialise new field.
3645         * p-lang.c (pascal_is_string_type_p): New function.
3646         (pascal_language_defn): Initialise new field.
3647         * rust-lang.c (rust_is_string_type_p): New function.
3648         (rust_language_defn): Initialise new field.
3649
3650 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3651
3652         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3653         New field.
3654         * ada-lang.c (ada_language_defn): Initialise new field.
3655         * c-lang.c (c_language_defn): Likewise.
3656         (cplus_language_defn): Likewise.
3657         (asm_language_defn): Likewise.
3658         (minimal_language_defn): Likewise.
3659         * d-lang.c (d_language_defn): Likewise.
3660         * f-lang.c (f_language_defn): Likewise.
3661         * go-lang.c (go_language_defn): Likewise.
3662         * language.c (unknown_language_defn): Likewise.
3663         (auto_language_defn): Likewise.
3664         * m2-lang.c (m2_language_defn): Likewise.
3665         * objc-lang.c (objc_language_defn): Likewise.
3666         * opencl-lang.c (opencl_language_defn): Likewise.
3667         * p-lang.c (pascal_language_defn): Likewise.
3668         * rust-lang.c (rust_language_defn): Likewise.
3669
3670 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3671
3672         * ada-lang.c (ada_is_character_type): Change return type to bool.
3673         (ada_is_string_type): Likewise.
3674         * ada-lang.h (ada_is_character_type): Update declaration
3675         (ada_is_string_type): Likewise.
3676
3677 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3678
3679         Support style in 'frame|thread apply'
3680
3681         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3682         * record.c (record_start, record_stop): Update callers of
3683         execute_command_to_string with false.
3684         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3685         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3686         methods.
3687         (class string_file): New constructor with term_out parameter.
3688         Override methods term_out and can_emit_style_escape.  New member
3689         term_out.
3690         (class stdio_file): Override can_emit_style_escape.
3691         (class tee_file): Override term_out and can_emit_style_escape.
3692         * utils.h (can_emit_style_escape): Remove.
3693         * utils.c (can_emit_style_escape): Likewise.
3694         Update all callers of can_emit_style_escape (SOMESTREAM) to
3695         SOMESTREAM->can_emit_style_escape.
3696         * source-cache.c (source_cache::get_source_lines): Likewise.
3697         * stack.c (frame_apply_command_count): Call execute_command_to_string
3698         passing the term_out characteristic of the current gdb_stdout.
3699         * thread.c (thr_try_catch_cmd): Likewise.
3700         * top.c (execute_command_to_string): pass term_out parameter
3701         to construct the string_file for the command output.
3702         * ui-file.c (term_cli_styling): New function (most code moved
3703         from utils.c can_emit_style_escape).
3704         (string_file::string_file, string_file::can_emit_style_escape,
3705         stdio_file::can_emit_style_escape, tee_file::term_out,
3706         tee_file::can_emit_style_escape): New functions.
3707
3708 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3709
3710         * NEWS: Mention the new set|show may-call-functions.
3711         * infcall.c (may_call_functions_p): New variable.
3712         (show_may_call_functions_p): New function.
3713         (call_function_by_hand_dummy): Throws an error if not
3714         may-call-functions.
3715         (_initialize_infcall): Call add_setshow_boolean_cmd for
3716         may-call-functions.
3717
3718 2019-04-25  Keith Seitz  <keiths@redhat.com>
3719
3720         PR c++/24367
3721         * cp-support.c (inspect_type): Don't attempt substitutions
3722         of symbol with the same name.
3723
3724 2019-04-25  Tom Tromey  <tromey@adacore.com>
3725
3726         PR gdb/24475:
3727         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3728         static.
3729
3730 2019-04-25  Tom Tromey  <tromey@adacore.com>
3731
3732         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3733         rvalue reference.
3734         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3735         (gdb_xml_parser::parse): Use std::move.
3736         * python/python-internal.h (gdbpy_convert_exception): Take a const
3737         reference.
3738         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3739         std::move.
3740         * python/py-utils.c (gdbpy_convert_exception): Take a const
3741         reference.
3742         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3743         Use std::move.
3744         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3745         Use std::move.
3746         * mi/mi-main.c (mi_print_exception): Take a const reference.
3747         * main.c (handle_command_errors): Take a const reference.
3748         * linespec.c (parse_linespec): Use std::move.
3749         * infcall.c (run_inferior_call): Use std::move.
3750         (call_function_by_hand_dummy): Use std::move.
3751         * exec.c (try_open_exec_file): Use std::move.
3752         * exceptions.h (exception_print, exception_fprintf)
3753         (exception_print_same): Update.
3754         * exceptions.c (print_exception, exception_print)
3755         (exception_fprintf, exception_print_same): Change parameters to
3756         const reference.
3757         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3758         * common/new-op.c: Use std::move.
3759         * common/common-exceptions.h (struct gdb_exception): Add move
3760         constructor.
3761         (struct gdb_exception_error, struct gdb_exception_quit, struct
3762         gdb_quit_bad_alloc): Change constructor to move constructor.
3763         (throw_exception): Change parameter to rvalue reference.
3764         * common/common-exceptions.c (throw_exception): Take rvalue
3765         reference.
3766         * cli/cli-interp.c (safe_execute_command): Use std::move.
3767         * breakpoint.c (insert_bp_location, location_to_sals): Use
3768         std::move.
3769
3770 2019-04-25  Tom Tromey  <tromey@adacore.com>
3771
3772         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3773         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3774         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3775         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3776         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3777         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3778         guile/scm-value.c: Use unpack.
3779         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3780         gdbscm_gdb_exception.
3781         (gdbscm_throw_gdb_exception): Likewise.
3782         (struct gdbscm_gdb_exception): New.
3783         (unpack): New function.
3784         (gdbscm_wrap): Use unpack.
3785
3786 2019-04-25  Tom Tromey  <tromey@adacore.com>
3787
3788         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3789         (gdb_rl_callback_handler): Use std::move.
3790         * common/common-exceptions.h (struct gdb_exception): Add move
3791         assignment operator.
3792         (throw_exception_sjlj): Change "exception" to const reference.
3793         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3794         (throw_exception_sjlj): Change "exception" to const reference.
3795
3796 2019-04-25  Tom Tromey  <tromey@adacore.com>
3797
3798         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3799         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3800         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3801         Update.
3802         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3803         Update.
3804         * mi/mi-interp.c (mi_interp::exec): Update.
3805         * linespec.c (parse_linespec): Update.
3806         * infcall.c (run_inferior_call): Update.
3807         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3808         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3809         (gdbscm_lookup_global_symbol): Update.
3810         * guile/scm-param.c (gdbscm_parameter_value): Update.
3811         * guile/scm-frame.c (gdbscm_frame_read_register)
3812         (gdbscm_frame_read_var): Update.
3813         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3814         * exec.c (try_open_exec_file): Update.
3815         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3816         (gdb_rl_callback_handler): Update.
3817         * common/common-exceptions.h (exception_none): Don't declare.
3818         * common/common-exceptions.c (exception_none): Don't define.
3819         (struct catcher) <exception>: Update.
3820         * cli/cli-interp.c (safe_execute_command): Update.
3821         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3822
3823 2019-04-25  Ali Tamur  <tamur@google.com>
3824
3825         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3826         (read_attribute_value): Likewise.
3827         (dwarf2_read_addr_index): Update comment.
3828         (read_str_index): Add DW_FORM_strx.
3829         (dwarf2_string_attr): Likewise.
3830         (dwarf2_const_value_attr): Likewise.
3831         (dump_die_shallow): Likewise.
3832         (dwarf2_fetch_constant_bytes): Likewise.
3833         (skip_form_bytes): Likewise.
3834         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3835
3836 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3837
3838         PR corefiles/11608
3839         PR corefiles/18187
3840         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3841         OFFSET.  Verify if current mapping contains an ELF header.
3842         (linux_find_memory_regions_full): Adjust call to
3843         dump_mapping_p.
3844
3845 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3846             Kang Li <kanglictf@gmail.com>
3847
3848         PR gdb/21600
3849
3850         * dwarf2-frame.c (read_initial_length): Be consistent about using
3851         unsigned representation of length.
3852         (decode_frame_entry_1): Likewise.  Check for wraparound of
3853         end pointer as well as buffer overflow.
3854
3855 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3856
3857         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3858         "vq".
3859
3860 2019-04-24  Tom Tromey  <tromey@adacore.com>
3861
3862         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3863
3864 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3865
3866         * s12z-tdep.c (s12z_unwind_pc): Delete.
3867         (s12z_unwind_sp): Delete.
3868         (s12z_gdbarch_init): Don't register deleted functions with
3869         gdbarch.
3870
3871 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3872
3873         * rl78-tdep.c (rl78_unwind_sp): Delete.
3874         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3875
3876 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3877
3878         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3879         (xstormy16_unwind_pc): Delete.
3880         (xstormy16_dummy_id): Delete.
3881         (xstormy16_gdbarch_init): Don't register deleted functions with
3882         gdbarch.
3883
3884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3885
3886         * vax-tdep.c (vax_unwind_pc): Delete.
3887         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3888
3889 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3890
3891         * v850-tdep.c (v850_unwind_sp): Delete.
3892         (v850_unwind_pc): Delete.
3893         (v850_dummy_id): Delete.
3894         (v850_gdbarch_init): Don't register deleted functions with
3895         gdbarch.
3896
3897 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3898
3899         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3900         (tilegx_unwind_pc): Delete.
3901         (tilegx_unwind_dummy_id): Delete.
3902         (tilegx_gdbarch_init): Don't register deleted functions with
3903         gdbarch.
3904
3905 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3906
3907         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3908         (tic6x_dummy_id): Delete.
3909         (tic6x_gdbarch_init): Don't register deleted functions with
3910         gdbarch.
3911
3912 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3913
3914         * sparc-tdep.c (sparc_unwind_pc): Delete.
3915         (sparc32_gdbarch_init): Don't register deleted function with
3916         gdbarch.
3917
3918 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3919
3920         * sh-tdep.c (sh_unwind_sp): Delete.
3921         (sh_unwind_pc): Delete.
3922         (sh_dummy_id): Delete.
3923         (sh_gdbarch_init): Don't register deleted functions with
3924         gdbarch.
3925
3926 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3927
3928         * score-tdep.c (score_unwind_sp): Delete.
3929         (score_unwind_pc): Delete.
3930         (score_dummy_id): Delete.
3931         (score_gdbarch_init): Don't register deleted functions with
3932         gdbarch.
3933
3934 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3935
3936         * rx-tdep.c (rx_unwind_pc): Delete.
3937         (rx_unwind_sp): Delete.
3938         (rx_dummy_id): Delete.
3939         (rx_gdbarch_init): Don't register deleted functions with
3940         gdbarch.  Update comment.
3941
3942 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3943
3944         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3945         (rs6000_dummy_id): Delete.
3946         (rs6000_gdbarch_init): Don't register deleted functions with
3947         gdbarch.
3948
3949 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3950
3951         * or1k-tdep.c (or1k_dummy_id): Delete.
3952         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3953
3954 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3955
3956         * nios2-tdep.c (nios2_dummy_id): Delete.
3957         (nios2_unwind_sp): Delete.
3958         (nios2_gdbarch_init): Don't register deleted functions with
3959         gdbarch.
3960
3961 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3962
3963         * nds32-tdep.c (nds32_dummy_id): Delete.
3964         (nds32_unwind_pc): Delete.
3965         (nds32_unwind_sp): Delete.
3966         (nds32_gdbarch_init): Don't register deleted functions with
3967         gdbarch.
3968
3969 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3970
3971         * msp430-tdep.c (msp430_unwind_pc): Delete.
3972         (msp430_unwind_sp): Delete.
3973         (msp430_dummy_id): Delete.
3974         (msp430_gdbarch_init): Don't register deleted functions with
3975         gdbarch.
3976
3977 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3978
3979         * moxie-tdep.c (moxie_unwind_sp): Delete.
3980         (moxie_unwind_pc): Delete.
3981         (moxie_dummy_id): Delete.
3982         (moxie_gdbarch_init): Don't register deleted functions with
3983         gdbarch.
3984
3985 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3986
3987         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3988         (mn10300_unwind_pc): Delete.
3989         (mn10300_unwind_sp): Delete.
3990         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3991         mn10300_unwind_sp.
3992         (mn10300_frame_unwind_init): Don't register deleted functions with
3993         gdbarch.
3994
3995 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3996
3997         * mep-tdep.c (mep_unwind_pc): Delete.
3998         (mep_unwind_sp): Delete.
3999         (mep_dummy_id): Delete.
4000         (mep_gdbarch_init): Don't register deleted functions with
4001         gdbarch.
4002
4003 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4004
4005         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4006         (m68hc11_unwind_sp): Delete.
4007         (m68hc11_gdbarch_init): Don't register deleted functions with
4008         gdbarch.
4009
4010 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4011
4012         * m32r-tdep.c (m32r_unwind_sp): Delete.
4013         (m32r_unwind_pc): Delete.
4014         (m32r_dummy_id): Delete.
4015         (m32r_gdbarch_init): Don't register deleted functions with
4016         gdbarch.
4017
4018 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4019
4020         * m32c-tdep.c (m32c_unwind_pc): Delete.
4021         (m32c_unwind_sp): Delete.
4022         (m32c_dummy_id): Delete.
4023         (m32c_gdbarch_init): Don't register deleted functions with
4024         gdbarch.
4025
4026 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4027
4028         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4029         (lm32_unwind_pc): Delete.
4030         (lm32_dummy_id): Delete.
4031         (lm32_gdbarch_init): Don't register deleted functions with
4032         gdbarch.
4033
4034 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4035
4036         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4037         (iq2000_unwind_pc): Delete.
4038         (iq2000_dummy_id): Delete.
4039         (iq2000_gdbarch_init): Don't register deleted functions with
4040         gdbarch.
4041
4042 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4043
4044         * nds32-tdep.c (nds32_type_align): Delete.
4045         (nds32_push_dummy_call): Use type_align instead.
4046
4047 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4048
4049         * arm-tdep.c (arm_type_align): Only handle vector override case.
4050         (arm_push_dummy_call): Use type_align.
4051         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4052
4053 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4054
4055         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4056         case.
4057         (pass_on_stack): Use type_align.
4058         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4059         function.
4060
4061 2019-04-23  Tom Tromey  <tromey@adacore.com>
4062
4063         * dwarf2read.c (line_header::file_name_at): Remove unused
4064         overload.
4065
4066 2019-04-23  Tom de Vries  <tdevries@suse.de>
4067
4068         PR gdb/24438
4069         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4070         invocation.
4071
4072
4073 2019-03-27  Ali Tamur  <tamur@google.com>
4074
4075         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4076         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4077         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4078         (dwarf_expr_context::get_addr_index): Likewise
4079         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4080         (symbol_needs_eval_context::get_addr_index): Likewise
4081         (disassemble_dwarf_expression): Add DW_OP_addrx
4082         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4083         (read_cutu_die_from_dwo): Update comment
4084         (skip_one_die): Add DW_FORM_addrx
4085         (read_attribute_value): Likewise
4086         (var_decode_location): Add DW_OP_addrx
4087         (dwarf2_const_value_attr): Add DW_FORM_addrx
4088         (dump_die_shallow): Likewise
4089         (dwarf2_fetch_constant_bytes): Likewise
4090         (decode_locdesc): Add DW_OP_addrx
4091         (skip_form_bytes): Add DW_FORM_addrx
4092
4093 2019-04-22  Ali Tamur  <tamur@google.com>
4094
4095         * MAINTAINERS (Write After Approval): Add self.
4096
4097 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4098
4099         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4100         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4101         (open_symbol_file_object): Likewise.
4102         (svr4_default_sos): Add info parameter.
4103         (svr4_read_so_list): Likewise.
4104         (svr4_current_sos_direct): Adjust functions calls to pass down
4105         info.
4106         (svr4_current_sos_1): Add info parameter.
4107         (svr4_current_sos): Call get_svr4_info, pass info down to
4108         svr4_current_sos_1.
4109         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4110         get_svr4_info.
4111         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4112         get_svr4_info.
4113         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4114         to get_svr4_info.
4115         (probes_table_remove_objfile_probes): Likewise.
4116         (register_solib_event_probe): Add info parameter.
4117         (solist_update_incremental): Pass info parameter down to
4118         svr4_read_so_list.
4119         (disable_probes_interface): Add info parameter.
4120         (svr4_handle_solib_event): Pass current_program_space to
4121         get_svr4_info.  Adjust disable_probes_interface cleanup.
4122         (svr4_create_probe_breakpoints): Add info parameter, pass it
4123         down to register_solib_event_probe.
4124         (svr4_create_solib_event_breakpoints): Add info parameter,
4125         pass it down to svr4_create_probe_breakpoints.
4126         (enable_break): Pass info down to
4127         svr4_create_solib_event_breakpoints.
4128         (svr4_solib_create_inferior_hook): Pass current_program_space to
4129         get_svr4_info.
4130         (svr4_clear_solib): Likewise.
4131
4132 2019-04-22  Pedro Alves  <palves@redhat.com>
4133
4134         * solib-svr4.c (svr4_free_objfile_observer): New.
4135         (probe_and_action::objfile): New field.
4136         (probes_table_htab_remove_objfile_probes)
4137         (probes_table_remove_objfile_probes): New functions.
4138         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4139         in the new probe_and_action.  Don't store the probe in 'lookup'.
4140         (svr4_create_probe_breakpoints): Pass objfile to
4141         register_solib_event_probe.
4142         (_initialize_svr4_solib): Register a free_objfile observer.
4143
4144 2019-04-19  Tom Tromey  <tom@tromey.com>
4145
4146         * common/queue.h: Remove.
4147
4148 2019-04-19  Tom Tromey  <tom@tromey.com>
4149
4150         * event-loop.c: Don't include "common/queue.h".
4151
4152 2019-04-19  Tom Tromey  <tom@tromey.com>
4153
4154         * remote.c (remote_target): Use delete.
4155         * remote-notif.h: Include <list>, not "common/queue.h".
4156         (notif_client_p): Remove typedef.
4157         (remote_notif_state): Add constructor, destructor, initializer.
4158         <notif_queue>: Now a std::list.
4159         (remote_notif_state_xfree): Don't declare.
4160         * remote-notif.c (remote_notif_process, handle_notification)
4161         (remote_notif_state_allocate): Update.
4162         (~remote_notif_state): Rename from remote_notif_state_xfree.
4163
4164 2019-04-19  Tom Tromey  <tom@tromey.com>
4165
4166         * symfile.c (reread_symbols): Update.
4167         * objfiles.c (objfile_register_static_link)
4168         (objfile_lookup_static_link): Update
4169         (~objfile) Don't delete static_links.
4170         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4171
4172 2019-04-19  Tom Tromey  <tom@tromey.com>
4173
4174         * type-stack.h (struct type_stack) <insert>: Constify string.
4175         * type-stack.c (type_stack::insert): Constify string.
4176         * gdbtypes.h (lookup_template_type): Update.
4177         (address_space_name_to_int): Update.
4178         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4179         const.
4180         (lookup_template_type): Make name const.
4181         * c-exp.y: Update rules.
4182         (lex_one_token, classify_name, classify_inner_name)
4183         (c_print_token): Update.
4184         * p-exp.y: Update rules.
4185         (yylex): Update.
4186         * f-exp.y: Update rules.
4187         (yylex): Update.
4188         * d-exp.y: Update rules.
4189         (lex_one_token, classify_name, classify_inner_name): Update.
4190         * parse.c (write_dollar_variable, copy_name): Return std::string.
4191         * parser-defs.h (copy_name): Change return type.
4192         * m2-exp.y: Update rules.
4193         (yylex): Update.
4194         * go-exp.y (lex_one_token): Update.
4195         Update rules.
4196         (classify_unsafe_function, classify_packaged_name)
4197         (classify_name, yylex): Update.
4198
4199 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4200
4201         * configure.ac: add --enable-source-highlight switch.
4202         * configure: Regenerate.
4203         * top.c (print_gdb_version): plumb --enable-source-highlight
4204         status to "show configuration".
4205
4206 2019-04-19  Tom Tromey  <tromey@adacore.com>
4207
4208         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4209         Check ADA_TYPE_P.
4210         (empty_record, ada_template_to_fixed_record_type_1)
4211         (template_to_static_fixed_type)
4212         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4213         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4214         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4215         macros.
4216
4217 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4218
4219         PR symtab/24423:
4220         * source.c (print_source_lines_base): Advance "iter" when a
4221         control character is seen.
4222
4223 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4224
4225         * inferior.h (struct infcall_suspend_state_deleter):
4226         Catch exception in destructor to avoid crash.
4227
4228 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4229
4230         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4231         close to the add_com "shell".
4232
4233 2019-04-18  Tom Tromey  <tromey@adacore.com>
4234
4235         * process-stratum-target.h (class process_stratum_target)
4236         <stratum>: Add "final".
4237
4238 2019-04-17  Tom Tromey  <tromey@adacore.com>
4239
4240         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4241         against nullptr before use.
4242
4243 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4244
4245         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4246
4247 2019-04-17  Jim Wilson  <jimw@sifive.com>
4248             Andrew Burgess  <andrew.burgess@embecosm.com>
4249
4250         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4251         code read might fail, assume 4-byte breakpoint in that case.
4252
4253 2019-04-15  Leszek Swirski  <leszeks@google.com>
4254
4255         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4256         rather than a hand-rolled POD check when checking for forced MEMORY
4257         classification.
4258
4259 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4260
4261         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4262         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4263         function.
4264         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4265         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4266         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4267         declaration.
4268
4269 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4270
4271         * aarch64-linux-nat.c
4272         (aarch64_linux_nat_target::thread_architecture): Add override.
4273         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4274         each VQ.
4275
4276 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4277
4278         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4279
4280 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4281
4282         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4283         target types of size 96-bits, add some additional comments, and
4284         check that the builtin type we found was the correct size.
4285
4286 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4287
4288         * utils.c (prompt_for_continue): Don't restore the styling at the
4289         end, as applied_style has the wrong value.  This fixes styling in
4290         long lists of file names that are interrupted by the "Continue?"
4291         prompt.
4292
4293 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4294
4295         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4296         * c-lang.c (c_language_defn): Likewise.
4297         (cplus_language_defn): Likewise.
4298         (asm_language_defn): Likewise.
4299         (minimal_language_defn): Likewise.
4300         * d-lang.c (d_language_defn): Likewise.
4301         * f-lang.c (f_language_defn): Likewise.
4302         * go-lang.c (go_language_defn): Likewise.
4303         * language.c (unknown_language_defn): Likewise.
4304         (auto_language_defn): Likewise.
4305         * language.h (struct language_defn): Remove la_magic field.
4306         (LANG_MAGIC): Delete.
4307         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4308         * objc-lang.c (objc_language_defn): Likewise.
4309         * opencl-lang.c (opencl_language_defn): Likewise.
4310         * p-lang.c (pascal_language_defn): Likewise.
4311         * rust-lang.c (rust_language_defn): Likewise.
4312
4313 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4314
4315         * riscv-tdep.c (riscv_type_align): New function.
4316         (riscv_type_alignment): Delete.
4317         (riscv_arg_location): Use 'type_align'.
4318         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4319
4320 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4321
4322         * gdbtypes.c (type_align): A struct with no non-static fields also
4323         has alignment of 1.
4324
4325 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4326
4327         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4328         component to 0.
4329         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4330         member.
4331         (riscv_struct_info::analyse): New implementation using new
4332         analyse_inner member function.
4333         (riscv_struct_info::field_offset): New member function.
4334         (riscv_struct_info::m_offsets): New member variable.
4335         (riscv_struct_info::analyse_inner): New private member function,
4336         takes the old implementation of riscv_struct_info::analyse but
4337         extended to track field offsets.
4338         (riscv_call_arg_struct): Update the struct folding special cases
4339         to handle cases where empty C++ structs, which are non-zero
4340         length, are found.
4341         (riscv_arg_location): Initialise the length of each location, a
4342         non-zero length now indicates the location is in use.
4343         (riscv_push_dummy_call): Allow for the first location having a
4344         non-zero offset when setting up arguments.
4345         (riscv_return_value): Likewise, but for return values.
4346
4347 2019-04-11  Tom Tromey  <tromey@adacore.com>
4348
4349         * utils.c (internal_vproblem): Make "msg" const.
4350
4351 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4352
4353         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4354         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4355         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4356         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4357
4358 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4359
4360         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4361         function.
4362         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4363         of amd64_collect_native_gregset.
4364         (amd64_linux_nat_target::store_registers): Likewise.
4365
4366 2019-04-10  Tom Tromey  <tom@tromey.com>
4367
4368         * symtab.c (lookup_global_symbol_from_objfile)
4369         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4370         * objfiles.h (class separate_debug_iterator): New.
4371         (class separate_debug_range): New.
4372         (struct objfile) <separate_debug_objfiles>: New method.
4373         (objfile_separate_debug_iterate): Don't declare.
4374         * objfiles.c (separate_debug_iterator::operator++): Rename from
4375         objfile_separate_debug_iterate.
4376         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4377         iterator.
4378         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4379         iterator.
4380
4381 2019-04-10  Tom Tromey  <tom@tromey.com>
4382
4383         * symfile.c (reread_symbols): Remove old comment.
4384         * objfiles.c (free_all_objfiles): Fix a typo.
4385
4386 2019-04-10  Tom Tromey  <tom@tromey.com>
4387
4388         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4389         * minsyms.c (lookup_minimal_symbol): Use foreach.
4390         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4391         (lookup_minimal_symbol_solib_trampoline): Likewise.
4392         * symfile.c (reread_symbols): Use foreach.
4393
4394 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4395             Tom Tromey  <tromey@adacore.com>
4396
4397         PR rust/24414:
4398         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4399         (rust_lex_int_test): Change "value" to be LONGEST.
4400         (rust_lex_tests): Add test for long integer literal.
4401
4402 2019-04-09  Tom Tromey  <tromey@adacore.com>
4403
4404         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4405         to bool.
4406         (extended_remote_target::attach): Update.
4407         (remote_target::remote_notice_new_inferior): Update.
4408         (remote_target::add_current_inferior_and_thread): Update.
4409         * inferior.c (exit_inferior_1): Use "false".
4410         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4411
4412 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4413
4414         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4415         the "start" command.
4416
4417 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4418
4419         * python/py-inferior.c (infpy_thread_from_thread_handle):
4420         Adjust comments to reflect renaming of thread_from_thread_handle
4421         to thread_from_handle.  Adjust keywords.  Fix type error message.
4422         (inferior_object_methods): Add thread_from_handle.  Retain
4423         thread_from_thread_handle, but mark it as deprecated.
4424
4425 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4426
4427         * gdbthread.h (find_thread_by_handle): Revise declaration.
4428         * thread.c (find_thread_by_handle): Likewise.  Adjust
4429         implementation too.
4430         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4431         support for buffer objects as handles.
4432
4433 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4434
4435         * python/py-infthread.c (thpy_thread_handle): New function.
4436         (thread_object_methods): Register thpy_thread_handle.
4437
4438 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4439
4440         * gdbthread.h (thread_to_thread_handle): Declare.
4441         * thread.c (gdbtypes.h): Include.
4442         (thread_to_thread_handle): New function.
4443
4444         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4445         (target_thread_info_to_thread_handle): Declare.
4446         * target.c (target_thread_info_to_thread_handle): New function.
4447         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4448         * target-delegates.c: Regenerate.
4449
4450         * linux-thread-db.c (class thread_db_target): Add method
4451         thread_info_to_thread_handle.
4452         (thread_db_target::thread_info_to_thread_handle): Define.
4453         * remote.c (class remote_target): Add new method
4454         thread_info_to_thread_handle.
4455         (remote_target::thread_info_to_thread_handle): Define.
4456
4457 2019-04-08  Pedro Alves  <palves@redhat.com>
4458
4459         * common/common-exceptions.c (throw_exception): Don't create
4460         named object to throw; throw directly.
4461         (throw_it): Likewise.  Don't initialize gdb_exception::message
4462         here, with new; pass FMT and AP to the ctor instead.
4463         * common/common-exceptions.h: Include <string>.
4464         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4465         const char *, va_list)): New ctor.  Use std::make_shared.
4466         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4467         errors)): Delete.
4468         (gdb_exception_error::gdb_exception_error(enum errors, const char
4469         *, va_list)): New.
4470         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4471         Add assertion.
4472         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4473         errors)): Delete.
4474         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4475         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4476         Add assertion.
4477
4478 2019-04-08  Tom Tromey  <tom@tromey.com>
4479
4480         * valops.c (value_rtti_indirect_type): Replace throw_exception
4481         with throw.
4482         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4483         with throw.
4484         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4485         throw.
4486         * target.c (target_translate_tls_address): Replace throw_exception
4487         with throw.
4488         * stack.c (frame_apply_command_count): Replace throw_exception
4489         with throw.
4490         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4491         throw.
4492         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4493         with throw.
4494         * rs6000-tdep.c (rs6000_frame_cache)
4495         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4496         * remote.c: Replace throw_exception with throw.
4497         * record-full.c (record_full_message, record_full_wait_1)
4498         (record_full_restore): Replace throw_exception with throw.
4499         * record-btrace.c:
4500         (get_thread_current_frame_id, record_btrace_start_replaying)
4501         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4502         (cmd_record_btrace_start): Replace throw_exception with throw.
4503         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4504         throw.
4505         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4506         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4507         * linespec.c:
4508         (find_linespec_symbols): Replace throw_exception with throw.
4509         * infrun.c (displaced_step_prepare, resume): Replace
4510         throw_exception with throw.
4511         * infcmd.c (post_create_inferior): Replace throw_exception with
4512         throw.
4513         * inf-loop.c (inferior_event_handler): Replace throw_exception
4514         with throw.
4515         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4516         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4517         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4518         (get_prev_frame_always, get_frame_pc_if_available)
4519         (get_frame_address_in_block_if_available, get_frame_language):
4520         Replace throw_exception with throw.
4521         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4522         throw_exception with throw.
4523         * eval.c (fetch_subexp_value, evaluate_var_value)
4524         (evaluate_funcall, evaluate_subexp_standard): Replace
4525         throw_exception with throw.
4526         * dwarf2loc.c (call_site_find_chain)
4527         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4528         Replace throw_exception with throw.
4529         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4530         with throw.
4531         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4532         throw.
4533         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4534         * completer.c (complete_line_internal): Replace throw_exception
4535         with throw.
4536         * compile/compile-object-run.c (compile_object_run): Replace
4537         throw_exception with throw.
4538         * cli/cli-script.c (process_next_line): Replace throw_exception
4539         with throw.
4540         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4541         (btrace_enable, btrace_maint_update_pt_packets): Replace
4542         throw_exception with throw.
4543         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4544         throw_exception with throw.
4545         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4546         throw_exception with throw.
4547         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4548         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4549         * aarch64-tdep.c (aarch64_make_prologue_cache)
4550         (aarch64_make_stub_cache): Replace throw_exception with throw.
4551
4552 2019-04-08  Tom Tromey  <tom@tromey.com>
4553
4554         * common/common-exceptions.c (throw_exception): Rename from
4555         throw_exception_cxx.  Remove old copy.  Make argument const.
4556         (throw_it): Create and throw exception objects directly.
4557         * common/common-exceptions.h (throw_exception): Make argument
4558         const.
4559         (struct gdb_exception_error): Add constructor.
4560         (struct gdb_exception_quit): Add constructor.
4561
4562 2019-04-08  Tom Tromey  <tom@tromey.com>
4563
4564         * common/common-exceptions.h (exception_rethrow): Don't declare.
4565         (TRY_SJLJ): Update comment.
4566         (TRY, CATCH, END_CATCH): Remove.
4567         * common/common-exceptions.c (exception_rethrow): Remove.
4568
4569 2019-04-08  Tom Tromey  <tom@tromey.com>
4570
4571         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4572         Remove.
4573         (gdb_exception_error): Rename from
4574         gdb_exception_RETURN_MASK_ERROR.
4575         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4576         (gdb_quit_bad_alloc): Update.
4577         * aarch64-tdep.c: Update.
4578         * ada-lang.c: Update.
4579         * ada-typeprint.c: Update.
4580         * ada-valprint.c: Update.
4581         * amd64-tdep.c: Update.
4582         * arch-utils.c: Update.
4583         * break-catch-throw.c: Update.
4584         * breakpoint.c: Update.
4585         * btrace.c: Update.
4586         * c-varobj.c: Update.
4587         * cli/cli-cmds.c: Update.
4588         * cli/cli-interp.c: Update.
4589         * cli/cli-script.c: Update.
4590         * common/common-exceptions.c: Update.
4591         * common/new-op.c: Update.
4592         * common/selftest.c: Update.
4593         * compile/compile-c-symbols.c: Update.
4594         * compile/compile-cplus-symbols.c: Update.
4595         * compile/compile-object-load.c: Update.
4596         * compile/compile-object-run.c: Update.
4597         * completer.c: Update.
4598         * corelow.c: Update.
4599         * cp-abi.c: Update.
4600         * cp-support.c: Update.
4601         * cp-valprint.c: Update.
4602         * darwin-nat.c: Update.
4603         * disasm-selftests.c: Update.
4604         * dtrace-probe.c: Update.
4605         * dwarf-index-cache.c: Update.
4606         * dwarf-index-write.c: Update.
4607         * dwarf2-frame-tailcall.c: Update.
4608         * dwarf2-frame.c: Update.
4609         * dwarf2loc.c: Update.
4610         * dwarf2read.c: Update.
4611         * eval.c: Update.
4612         * event-loop.c: Update.
4613         * event-top.c: Update.
4614         * exec.c: Update.
4615         * f-valprint.c: Update.
4616         * fbsd-tdep.c: Update.
4617         * frame-unwind.c: Update.
4618         * frame.c: Update.
4619         * gdbtypes.c: Update.
4620         * gnu-v3-abi.c: Update.
4621         * guile/guile-internal.h: Update.
4622         * guile/scm-block.c: Update.
4623         * guile/scm-breakpoint.c: Update.
4624         * guile/scm-cmd.c: Update.
4625         * guile/scm-disasm.c: Update.
4626         * guile/scm-frame.c: Update.
4627         * guile/scm-lazy-string.c: Update.
4628         * guile/scm-math.c: Update.
4629         * guile/scm-param.c: Update.
4630         * guile/scm-ports.c: Update.
4631         * guile/scm-pretty-print.c: Update.
4632         * guile/scm-symbol.c: Update.
4633         * guile/scm-symtab.c: Update.
4634         * guile/scm-type.c: Update.
4635         * guile/scm-value.c: Update.
4636         * i386-linux-tdep.c: Update.
4637         * i386-tdep.c: Update.
4638         * inf-loop.c: Update.
4639         * infcall.c: Update.
4640         * infcmd.c: Update.
4641         * infrun.c: Update.
4642         * jit.c: Update.
4643         * language.c: Update.
4644         * linespec.c: Update.
4645         * linux-fork.c: Update.
4646         * linux-nat.c: Update.
4647         * linux-tdep.c: Update.
4648         * linux-thread-db.c: Update.
4649         * main.c: Update.
4650         * mi/mi-cmd-break.c: Update.
4651         * mi/mi-cmd-stack.c: Update.
4652         * mi/mi-interp.c: Update.
4653         * mi/mi-main.c: Update.
4654         * objc-lang.c: Update.
4655         * p-valprint.c: Update.
4656         * parse.c: Update.
4657         * ppc-linux-tdep.c: Update.
4658         * printcmd.c: Update.
4659         * python/py-arch.c: Update.
4660         * python/py-breakpoint.c: Update.
4661         * python/py-cmd.c: Update.
4662         * python/py-finishbreakpoint.c: Update.
4663         * python/py-frame.c: Update.
4664         * python/py-framefilter.c: Update.
4665         * python/py-gdb-readline.c: Update.
4666         * python/py-inferior.c: Update.
4667         * python/py-infthread.c: Update.
4668         * python/py-lazy-string.c: Update.
4669         * python/py-linetable.c: Update.
4670         * python/py-objfile.c: Update.
4671         * python/py-param.c: Update.
4672         * python/py-prettyprint.c: Update.
4673         * python/py-progspace.c: Update.
4674         * python/py-record-btrace.c: Update.
4675         * python/py-record.c: Update.
4676         * python/py-symbol.c: Update.
4677         * python/py-type.c: Update.
4678         * python/py-unwind.c: Update.
4679         * python/py-utils.c: Update.
4680         * python/py-value.c: Update.
4681         * python/python.c: Update.
4682         * record-btrace.c: Update.
4683         * record-full.c: Update.
4684         * remote-fileio.c: Update.
4685         * remote.c: Update.
4686         * riscv-tdep.c: Update.
4687         * rs6000-aix-tdep.c: Update.
4688         * rs6000-tdep.c: Update.
4689         * rust-exp.y: Update.
4690         * rust-lang.c: Update.
4691         * s390-tdep.c: Update.
4692         * selftest-arch.c: Update.
4693         * solib-dsbt.c: Update.
4694         * solib-frv.c: Update.
4695         * solib-spu.c: Update.
4696         * solib-svr4.c: Update.
4697         * solib.c: Update.
4698         * sparc64-linux-tdep.c: Update.
4699         * stack.c: Update.
4700         * symfile-mem.c: Update.
4701         * symmisc.c: Update.
4702         * target.c: Update.
4703         * thread.c: Update.
4704         * top.c: Update.
4705         * tracefile-tfile.c: Update.
4706         * tui/tui.c: Update.
4707         * typeprint.c: Update.
4708         * unittests/cli-utils-selftests.c: Update.
4709         * unittests/parse-connection-spec-selftests.c: Update.
4710         * valops.c: Update.
4711         * valprint.c: Update.
4712         * value.c: Update.
4713         * varobj.c: Update.
4714         * windows-nat.c: Update.
4715         * x86-linux-nat.c: Update.
4716         * xml-support.c: Update.
4717
4718 2019-04-08  Tom Tromey  <tom@tromey.com>
4719
4720         * xml-support.c: Use C++ exception handling.
4721         * x86-linux-nat.c: Use C++ exception handling.
4722         * windows-nat.c: Use C++ exception handling.
4723         * varobj.c: Use C++ exception handling.
4724         * value.c: Use C++ exception handling.
4725         * valprint.c: Use C++ exception handling.
4726         * valops.c: Use C++ exception handling.
4727         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4728         handling.
4729         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4730         * typeprint.c: Use C++ exception handling.
4731         * tui/tui.c: Use C++ exception handling.
4732         * tracefile-tfile.c: Use C++ exception handling.
4733         * top.c: Use C++ exception handling.
4734         * thread.c: Use C++ exception handling.
4735         * target.c: Use C++ exception handling.
4736         * symmisc.c: Use C++ exception handling.
4737         * symfile-mem.c: Use C++ exception handling.
4738         * stack.c: Use C++ exception handling.
4739         * sparc64-linux-tdep.c: Use C++ exception handling.
4740         * solib.c: Use C++ exception handling.
4741         * solib-svr4.c: Use C++ exception handling.
4742         * solib-spu.c: Use C++ exception handling.
4743         * solib-frv.c: Use C++ exception handling.
4744         * solib-dsbt.c: Use C++ exception handling.
4745         * selftest-arch.c: Use C++ exception handling.
4746         * s390-tdep.c: Use C++ exception handling.
4747         * rust-lang.c: Use C++ exception handling.
4748         * rust-exp.y: Use C++ exception handling.
4749         * rs6000-tdep.c: Use C++ exception handling.
4750         * rs6000-aix-tdep.c: Use C++ exception handling.
4751         * riscv-tdep.c: Use C++ exception handling.
4752         * remote.c: Use C++ exception handling.
4753         * remote-fileio.c: Use C++ exception handling.
4754         * record-full.c: Use C++ exception handling.
4755         * record-btrace.c: Use C++ exception handling.
4756         * python/python.c: Use C++ exception handling.
4757         * python/py-value.c: Use C++ exception handling.
4758         * python/py-utils.c: Use C++ exception handling.
4759         * python/py-unwind.c: Use C++ exception handling.
4760         * python/py-type.c: Use C++ exception handling.
4761         * python/py-symbol.c: Use C++ exception handling.
4762         * python/py-record.c: Use C++ exception handling.
4763         * python/py-record-btrace.c: Use C++ exception handling.
4764         * python/py-progspace.c: Use C++ exception handling.
4765         * python/py-prettyprint.c: Use C++ exception handling.
4766         * python/py-param.c: Use C++ exception handling.
4767         * python/py-objfile.c: Use C++ exception handling.
4768         * python/py-linetable.c: Use C++ exception handling.
4769         * python/py-lazy-string.c: Use C++ exception handling.
4770         * python/py-infthread.c: Use C++ exception handling.
4771         * python/py-inferior.c: Use C++ exception handling.
4772         * python/py-gdb-readline.c: Use C++ exception handling.
4773         * python/py-framefilter.c: Use C++ exception handling.
4774         * python/py-frame.c: Use C++ exception handling.
4775         * python/py-finishbreakpoint.c: Use C++ exception handling.
4776         * python/py-cmd.c: Use C++ exception handling.
4777         * python/py-breakpoint.c: Use C++ exception handling.
4778         * python/py-arch.c: Use C++ exception handling.
4779         * printcmd.c: Use C++ exception handling.
4780         * ppc-linux-tdep.c: Use C++ exception handling.
4781         * parse.c: Use C++ exception handling.
4782         * p-valprint.c: Use C++ exception handling.
4783         * objc-lang.c: Use C++ exception handling.
4784         * mi/mi-main.c: Use C++ exception handling.
4785         * mi/mi-interp.c: Use C++ exception handling.
4786         * mi/mi-cmd-stack.c: Use C++ exception handling.
4787         * mi/mi-cmd-break.c: Use C++ exception handling.
4788         * main.c: Use C++ exception handling.
4789         * linux-thread-db.c: Use C++ exception handling.
4790         * linux-tdep.c: Use C++ exception handling.
4791         * linux-nat.c: Use C++ exception handling.
4792         * linux-fork.c: Use C++ exception handling.
4793         * linespec.c: Use C++ exception handling.
4794         * language.c: Use C++ exception handling.
4795         * jit.c: Use C++ exception handling.
4796         * infrun.c: Use C++ exception handling.
4797         * infcmd.c: Use C++ exception handling.
4798         * infcall.c: Use C++ exception handling.
4799         * inf-loop.c: Use C++ exception handling.
4800         * i386-tdep.c: Use C++ exception handling.
4801         * i386-linux-tdep.c: Use C++ exception handling.
4802         * guile/scm-value.c: Use C++ exception handling.
4803         * guile/scm-type.c: Use C++ exception handling.
4804         * guile/scm-symtab.c: Use C++ exception handling.
4805         * guile/scm-symbol.c: Use C++ exception handling.
4806         * guile/scm-pretty-print.c: Use C++ exception handling.
4807         * guile/scm-ports.c: Use C++ exception handling.
4808         * guile/scm-param.c: Use C++ exception handling.
4809         * guile/scm-math.c: Use C++ exception handling.
4810         * guile/scm-lazy-string.c: Use C++ exception handling.
4811         * guile/scm-frame.c: Use C++ exception handling.
4812         * guile/scm-disasm.c: Use C++ exception handling.
4813         * guile/scm-cmd.c: Use C++ exception handling.
4814         * guile/scm-breakpoint.c: Use C++ exception handling.
4815         * guile/scm-block.c: Use C++ exception handling.
4816         * guile/guile-internal.h: Use C++ exception handling.
4817         * gnu-v3-abi.c: Use C++ exception handling.
4818         * gdbtypes.c: Use C++ exception handling.
4819         * frame.c: Use C++ exception handling.
4820         * frame-unwind.c: Use C++ exception handling.
4821         * fbsd-tdep.c: Use C++ exception handling.
4822         * f-valprint.c: Use C++ exception handling.
4823         * exec.c: Use C++ exception handling.
4824         * event-top.c: Use C++ exception handling.
4825         * event-loop.c: Use C++ exception handling.
4826         * eval.c: Use C++ exception handling.
4827         * dwarf2read.c: Use C++ exception handling.
4828         * dwarf2loc.c: Use C++ exception handling.
4829         * dwarf2-frame.c: Use C++ exception handling.
4830         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4831         * dwarf-index-write.c: Use C++ exception handling.
4832         * dwarf-index-cache.c: Use C++ exception handling.
4833         * dtrace-probe.c: Use C++ exception handling.
4834         * disasm-selftests.c: Use C++ exception handling.
4835         * darwin-nat.c: Use C++ exception handling.
4836         * cp-valprint.c: Use C++ exception handling.
4837         * cp-support.c: Use C++ exception handling.
4838         * cp-abi.c: Use C++ exception handling.
4839         * corelow.c: Use C++ exception handling.
4840         * completer.c: Use C++ exception handling.
4841         * compile/compile-object-run.c: Use C++ exception handling.
4842         * compile/compile-object-load.c: Use C++ exception handling.
4843         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4844         * compile/compile-c-symbols.c: Use C++ exception handling.
4845         * common/selftest.c: Use C++ exception handling.
4846         * common/new-op.c: Use C++ exception handling.
4847         * cli/cli-script.c: Use C++ exception handling.
4848         * cli/cli-interp.c: Use C++ exception handling.
4849         * cli/cli-cmds.c: Use C++ exception handling.
4850         * c-varobj.c: Use C++ exception handling.
4851         * btrace.c: Use C++ exception handling.
4852         * breakpoint.c: Use C++ exception handling.
4853         * break-catch-throw.c: Use C++ exception handling.
4854         * arch-utils.c: Use C++ exception handling.
4855         * amd64-tdep.c: Use C++ exception handling.
4856         * ada-valprint.c: Use C++ exception handling.
4857         * ada-typeprint.c: Use C++ exception handling.
4858         * ada-lang.c: Use C++ exception handling.
4859         * aarch64-tdep.c: Use C++ exception handling.
4860
4861 2019-04-08  Tom Tromey  <tom@tromey.com>
4862
4863         * xml-support.c (gdb_xml_parser::parse): Update.
4864         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4865         * value.c (show_convenience): Update.
4866         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4867         (test_parse_flags_qcs): Update.
4868         * thread.c (thr_try_catch_cmd): Update.
4869         * target.c (target_translate_tls_address): Update.
4870         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4871         (info_frame_command_core, frame_apply_command_count): Update.
4872         * rust-exp.y (rust_lex_exception_test): Update.
4873         * riscv-tdep.c (riscv_print_one_register_info): Update.
4874         * remote.c (remote_target::enable_btrace): Update.
4875         * record-btrace.c (record_btrace_enable_warn): Update.
4876         * python/py-utils.c (gdbpy_convert_exception): Update.
4877         * printcmd.c (do_one_display, print_variable_and_value): Update.
4878         * mi/mi-main.c (mi_print_exception): Update.
4879         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4880         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4881         * linux-nat.c (linux_nat_target::attach): Update.
4882         * linux-fork.c (class scoped_switch_fork_info): Update.
4883         * infrun.c (displaced_step_prepare): Update.
4884         * infcall.c (call_function_by_hand_dummy): Update.
4885         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4886         * gnu-v3-abi.c (print_one_vtable): Update.
4887         * frame.c (get_prev_frame_always): Update.
4888         * f-valprint.c (info_common_command_for_block): Update.
4889         * exec.c (try_open_exec_file): Update.
4890         * exceptions.c (print_exception, exception_print)
4891         (exception_fprintf, exception_print_same): Update.
4892         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4893         * dwarf-index-cache.c (index_cache::store)
4894         (index_cache::lookup_gdb_index): Update.
4895         * darwin-nat.c (maybe_cache_shell): Update.
4896         * cp-valprint.c (cp_print_value_fields): Update.
4897         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4898         (gcc_cplus_symbol_address): Update.
4899         * compile/compile-c-symbols.c (gcc_convert_symbol)
4900         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4901         * common/selftest.c: Update.
4902         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4903         a std::string.
4904         (exception_try_scope_entry, exception_try_scope_exit): Don't
4905         declare.
4906         (struct exception_try_scope): Remove.
4907         (TRY): Don't use exception_try_scope.
4908         (struct gdb_exception): Add constructor, operator=.
4909         <what>: New method.
4910         (struct gdb_exception_RETURN_MASK_ALL)
4911         (struct gdb_exception_RETURN_MASK_ERROR)
4912         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4913         (struct gdb_quit_bad_alloc): Update.
4914         * common/common-exceptions.c (exception_none): Change
4915         initializer.
4916         (struct catcher) <state, exception>: Initialize inline.
4917         <prev>: Remove member.
4918         (current_catcher): Remove.
4919         (catchers): New global.
4920         (exceptions_state_mc_init): Simplify.
4921         (catcher_pop): Remove.
4922         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4923         (try_scope_depth, exception_try_scope_entry)
4924         (exception_try_scope_exit): Remove.
4925         (throw_exception_sjlj): Update.
4926         (exception_messages, exception_messages_size): Remove.
4927         (throw_it): Simplify.
4928         (gdb_exception_sliced_copy): Remove.
4929         (throw_exception_cxx): Update.
4930         * cli/cli-script.c (script_from_file): Update.
4931         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4932         Update.
4933         * ada-valprint.c (ada_val_print): Update.
4934         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4935         (create_excep_cond_exprs): Update.
4936
4937 2019-04-08  Tom Tromey  <tom@tromey.com>
4938
4939         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4940         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4941         (TRY, CATCH, END_CATCH): Remove some definitions.
4942         * common/common-exceptions.c: Don't use GDB_XCPT.
4943         (catcher_list_size): Remove.
4944         (throw_exception, throw_it): Simplify.
4945
4946 2019-04-05  Tom Tromey  <tom@tromey.com>
4947
4948         Revert the header-sorting patch.
4949         * ft32-tdep.c: Revert.
4950         * frv-tdep.c: Revert.
4951         * frv-linux-tdep.c: Revert.
4952         * frame.c: Revert.
4953         * frame-unwind.c: Revert.
4954         * frame-base.c: Revert.
4955         * fork-child.c: Revert.
4956         * findvar.c: Revert.
4957         * findcmd.c: Revert.
4958         * filesystem.c: Revert.
4959         * filename-seen-cache.h: Revert.
4960         * filename-seen-cache.c: Revert.
4961         * fbsd-tdep.c: Revert.
4962         * fbsd-nat.h: Revert.
4963         * fbsd-nat.c: Revert.
4964         * f-valprint.c: Revert.
4965         * f-typeprint.c: Revert.
4966         * f-lang.c: Revert.
4967         * extension.h: Revert.
4968         * extension.c: Revert.
4969         * extension-priv.h: Revert.
4970         * expprint.c: Revert.
4971         * exec.h: Revert.
4972         * exec.c: Revert.
4973         * exceptions.c: Revert.
4974         * event-top.c: Revert.
4975         * event-loop.c: Revert.
4976         * eval.c: Revert.
4977         * elfread.c: Revert.
4978         * dwarf2read.h: Revert.
4979         * dwarf2read.c: Revert.
4980         * dwarf2loc.c: Revert.
4981         * dwarf2expr.h: Revert.
4982         * dwarf2expr.c: Revert.
4983         * dwarf2-frame.c: Revert.
4984         * dwarf2-frame-tailcall.c: Revert.
4985         * dwarf-index-write.h: Revert.
4986         * dwarf-index-write.c: Revert.
4987         * dwarf-index-common.c: Revert.
4988         * dwarf-index-cache.h: Revert.
4989         * dwarf-index-cache.c: Revert.
4990         * dummy-frame.c: Revert.
4991         * dtrace-probe.c: Revert.
4992         * disasm.h: Revert.
4993         * disasm.c: Revert.
4994         * disasm-selftests.c: Revert.
4995         * dictionary.c: Revert.
4996         * dicos-tdep.c: Revert.
4997         * demangle.c: Revert.
4998         * dcache.h: Revert.
4999         * dcache.c: Revert.
5000         * darwin-nat.h: Revert.
5001         * darwin-nat.c: Revert.
5002         * darwin-nat-info.c: Revert.
5003         * d-valprint.c: Revert.
5004         * d-namespace.c: Revert.
5005         * d-lang.c: Revert.
5006         * ctf.c: Revert.
5007         * csky-tdep.c: Revert.
5008         * csky-linux-tdep.c: Revert.
5009         * cris-tdep.c: Revert.
5010         * cris-linux-tdep.c: Revert.
5011         * cp-valprint.c: Revert.
5012         * cp-support.c: Revert.
5013         * cp-namespace.c: Revert.
5014         * cp-abi.c: Revert.
5015         * corelow.c: Revert.
5016         * corefile.c: Revert.
5017         * continuations.c: Revert.
5018         * completer.h: Revert.
5019         * completer.c: Revert.
5020         * complaints.c: Revert.
5021         * coffread.c: Revert.
5022         * coff-pe-read.c: Revert.
5023         * cli-out.h: Revert.
5024         * cli-out.c: Revert.
5025         * charset.c: Revert.
5026         * c-varobj.c: Revert.
5027         * c-valprint.c: Revert.
5028         * c-typeprint.c: Revert.
5029         * c-lang.c: Revert.
5030         * buildsym.c: Revert.
5031         * buildsym-legacy.c: Revert.
5032         * build-id.h: Revert.
5033         * build-id.c: Revert.
5034         * btrace.c: Revert.
5035         * bsd-uthread.c: Revert.
5036         * breakpoint.h: Revert.
5037         * breakpoint.c: Revert.
5038         * break-catch-throw.c: Revert.
5039         * break-catch-syscall.c: Revert.
5040         * break-catch-sig.c: Revert.
5041         * blockframe.c: Revert.
5042         * block.c: Revert.
5043         * bfin-tdep.c: Revert.
5044         * bfin-linux-tdep.c: Revert.
5045         * bfd-target.c: Revert.
5046         * bcache.c: Revert.
5047         * ax-general.c: Revert.
5048         * ax-gdb.h: Revert.
5049         * ax-gdb.c: Revert.
5050         * avr-tdep.c: Revert.
5051         * auxv.c: Revert.
5052         * auto-load.c: Revert.
5053         * arm-wince-tdep.c: Revert.
5054         * arm-tdep.c: Revert.
5055         * arm-symbian-tdep.c: Revert.
5056         * arm-pikeos-tdep.c: Revert.
5057         * arm-obsd-tdep.c: Revert.
5058         * arm-nbsd-tdep.c: Revert.
5059         * arm-nbsd-nat.c: Revert.
5060         * arm-linux-tdep.c: Revert.
5061         * arm-linux-nat.c: Revert.
5062         * arm-fbsd-tdep.c: Revert.
5063         * arm-fbsd-nat.c: Revert.
5064         * arm-bsd-tdep.c: Revert.
5065         * arch-utils.c: Revert.
5066         * arc-tdep.c: Revert.
5067         * arc-newlib-tdep.c: Revert.
5068         * annotate.h: Revert.
5069         * annotate.c: Revert.
5070         * amd64-windows-tdep.c: Revert.
5071         * amd64-windows-nat.c: Revert.
5072         * amd64-tdep.c: Revert.
5073         * amd64-sol2-tdep.c: Revert.
5074         * amd64-obsd-tdep.c: Revert.
5075         * amd64-obsd-nat.c: Revert.
5076         * amd64-nbsd-tdep.c: Revert.
5077         * amd64-nbsd-nat.c: Revert.
5078         * amd64-nat.c: Revert.
5079         * amd64-linux-tdep.c: Revert.
5080         * amd64-linux-nat.c: Revert.
5081         * amd64-fbsd-tdep.c: Revert.
5082         * amd64-fbsd-nat.c: Revert.
5083         * amd64-dicos-tdep.c: Revert.
5084         * amd64-darwin-tdep.c: Revert.
5085         * amd64-bsd-nat.c: Revert.
5086         * alpha-tdep.c: Revert.
5087         * alpha-obsd-tdep.c: Revert.
5088         * alpha-nbsd-tdep.c: Revert.
5089         * alpha-mdebug-tdep.c: Revert.
5090         * alpha-linux-tdep.c: Revert.
5091         * alpha-linux-nat.c: Revert.
5092         * alpha-bsd-tdep.c: Revert.
5093         * alpha-bsd-nat.c: Revert.
5094         * aix-thread.c: Revert.
5095         * agent.c: Revert.
5096         * addrmap.c: Revert.
5097         * ada-varobj.c: Revert.
5098         * ada-valprint.c: Revert.
5099         * ada-typeprint.c: Revert.
5100         * ada-tasks.c: Revert.
5101         * ada-lang.c: Revert.
5102         * aarch64-tdep.c: Revert.
5103         * aarch64-ravenscar-thread.c: Revert.
5104         * aarch64-newlib-tdep.c: Revert.
5105         * aarch64-linux-tdep.c: Revert.
5106         * aarch64-linux-nat.c: Revert.
5107         * aarch64-fbsd-tdep.c: Revert.
5108         * aarch64-fbsd-nat.c: Revert.
5109         * aarch32-linux-nat.c: Revert.
5110
5111 2019-04-05  Tom Tromey  <tom@tromey.com>
5112
5113         * ft32-tdep.c: Sort headers.
5114         * frv-tdep.c: Sort headers.
5115         * frv-linux-tdep.c: Sort headers.
5116         * frame.c: Sort headers.
5117         * frame-unwind.c: Sort headers.
5118         * frame-base.c: Sort headers.
5119         * fork-child.c: Sort headers.
5120         * findvar.c: Sort headers.
5121         * findcmd.c: Sort headers.
5122         * filesystem.c: Sort headers.
5123         * filename-seen-cache.h: Sort headers.
5124         * filename-seen-cache.c: Sort headers.
5125         * fbsd-tdep.c: Sort headers.
5126         * fbsd-nat.h: Sort headers.
5127         * fbsd-nat.c: Sort headers.
5128         * f-valprint.c: Sort headers.
5129         * f-typeprint.c: Sort headers.
5130         * f-lang.c: Sort headers.
5131         * extension.h: Sort headers.
5132         * extension.c: Sort headers.
5133         * extension-priv.h: Sort headers.
5134         * expprint.c: Sort headers.
5135         * exec.h: Sort headers.
5136         * exec.c: Sort headers.
5137         * exceptions.c: Sort headers.
5138         * event-top.c: Sort headers.
5139         * event-loop.c: Sort headers.
5140         * eval.c: Sort headers.
5141         * elfread.c: Sort headers.
5142         * dwarf2read.h: Sort headers.
5143         * dwarf2read.c: Sort headers.
5144         * dwarf2loc.c: Sort headers.
5145         * dwarf2expr.h: Sort headers.
5146         * dwarf2expr.c: Sort headers.
5147         * dwarf2-frame.c: Sort headers.
5148         * dwarf2-frame-tailcall.c: Sort headers.
5149         * dwarf-index-write.h: Sort headers.
5150         * dwarf-index-write.c: Sort headers.
5151         * dwarf-index-common.c: Sort headers.
5152         * dwarf-index-cache.h: Sort headers.
5153         * dwarf-index-cache.c: Sort headers.
5154         * dummy-frame.c: Sort headers.
5155         * dtrace-probe.c: Sort headers.
5156         * disasm.h: Sort headers.
5157         * disasm.c: Sort headers.
5158         * disasm-selftests.c: Sort headers.
5159         * dictionary.c: Sort headers.
5160         * dicos-tdep.c: Sort headers.
5161         * demangle.c: Sort headers.
5162         * dcache.h: Sort headers.
5163         * dcache.c: Sort headers.
5164         * darwin-nat.h: Sort headers.
5165         * darwin-nat.c: Sort headers.
5166         * darwin-nat-info.c: Sort headers.
5167         * d-valprint.c: Sort headers.
5168         * d-namespace.c: Sort headers.
5169         * d-lang.c: Sort headers.
5170         * ctf.c: Sort headers.
5171         * csky-tdep.c: Sort headers.
5172         * csky-linux-tdep.c: Sort headers.
5173         * cris-tdep.c: Sort headers.
5174         * cris-linux-tdep.c: Sort headers.
5175         * cp-valprint.c: Sort headers.
5176         * cp-support.c: Sort headers.
5177         * cp-namespace.c: Sort headers.
5178         * cp-abi.c: Sort headers.
5179         * corelow.c: Sort headers.
5180         * corefile.c: Sort headers.
5181         * continuations.c: Sort headers.
5182         * completer.h: Sort headers.
5183         * completer.c: Sort headers.
5184         * complaints.c: Sort headers.
5185         * coffread.c: Sort headers.
5186         * coff-pe-read.c: Sort headers.
5187         * cli-out.h: Sort headers.
5188         * cli-out.c: Sort headers.
5189         * charset.c: Sort headers.
5190         * c-varobj.c: Sort headers.
5191         * c-valprint.c: Sort headers.
5192         * c-typeprint.c: Sort headers.
5193         * c-lang.c: Sort headers.
5194         * buildsym.c: Sort headers.
5195         * buildsym-legacy.c: Sort headers.
5196         * build-id.h: Sort headers.
5197         * build-id.c: Sort headers.
5198         * btrace.c: Sort headers.
5199         * bsd-uthread.c: Sort headers.
5200         * breakpoint.h: Sort headers.
5201         * breakpoint.c: Sort headers.
5202         * break-catch-throw.c: Sort headers.
5203         * break-catch-syscall.c: Sort headers.
5204         * break-catch-sig.c: Sort headers.
5205         * blockframe.c: Sort headers.
5206         * block.c: Sort headers.
5207         * bfin-tdep.c: Sort headers.
5208         * bfin-linux-tdep.c: Sort headers.
5209         * bfd-target.c: Sort headers.
5210         * bcache.c: Sort headers.
5211         * ax-general.c: Sort headers.
5212         * ax-gdb.h: Sort headers.
5213         * ax-gdb.c: Sort headers.
5214         * avr-tdep.c: Sort headers.
5215         * auxv.c: Sort headers.
5216         * auto-load.c: Sort headers.
5217         * arm-wince-tdep.c: Sort headers.
5218         * arm-tdep.c: Sort headers.
5219         * arm-symbian-tdep.c: Sort headers.
5220         * arm-pikeos-tdep.c: Sort headers.
5221         * arm-obsd-tdep.c: Sort headers.
5222         * arm-nbsd-tdep.c: Sort headers.
5223         * arm-nbsd-nat.c: Sort headers.
5224         * arm-linux-tdep.c: Sort headers.
5225         * arm-linux-nat.c: Sort headers.
5226         * arm-fbsd-tdep.c: Sort headers.
5227         * arm-fbsd-nat.c: Sort headers.
5228         * arm-bsd-tdep.c: Sort headers.
5229         * arch-utils.c: Sort headers.
5230         * arc-tdep.c: Sort headers.
5231         * arc-newlib-tdep.c: Sort headers.
5232         * annotate.h: Sort headers.
5233         * annotate.c: Sort headers.
5234         * amd64-windows-tdep.c: Sort headers.
5235         * amd64-windows-nat.c: Sort headers.
5236         * amd64-tdep.c: Sort headers.
5237         * amd64-sol2-tdep.c: Sort headers.
5238         * amd64-obsd-tdep.c: Sort headers.
5239         * amd64-obsd-nat.c: Sort headers.
5240         * amd64-nbsd-tdep.c: Sort headers.
5241         * amd64-nbsd-nat.c: Sort headers.
5242         * amd64-nat.c: Sort headers.
5243         * amd64-linux-tdep.c: Sort headers.
5244         * amd64-linux-nat.c: Sort headers.
5245         * amd64-fbsd-tdep.c: Sort headers.
5246         * amd64-fbsd-nat.c: Sort headers.
5247         * amd64-dicos-tdep.c: Sort headers.
5248         * amd64-darwin-tdep.c: Sort headers.
5249         * amd64-bsd-nat.c: Sort headers.
5250         * alpha-tdep.c: Sort headers.
5251         * alpha-obsd-tdep.c: Sort headers.
5252         * alpha-nbsd-tdep.c: Sort headers.
5253         * alpha-mdebug-tdep.c: Sort headers.
5254         * alpha-linux-tdep.c: Sort headers.
5255         * alpha-linux-nat.c: Sort headers.
5256         * alpha-bsd-tdep.c: Sort headers.
5257         * alpha-bsd-nat.c: Sort headers.
5258         * aix-thread.c: Sort headers.
5259         * agent.c: Sort headers.
5260         * addrmap.c: Sort headers.
5261         * ada-varobj.c: Sort headers.
5262         * ada-valprint.c: Sort headers.
5263         * ada-typeprint.c: Sort headers.
5264         * ada-tasks.c: Sort headers.
5265         * ada-lang.c: Sort headers.
5266         * aarch64-tdep.c: Sort headers.
5267         * aarch64-ravenscar-thread.c: Sort headers.
5268         * aarch64-newlib-tdep.c: Sort headers.
5269         * aarch64-linux-tdep.c: Sort headers.
5270         * aarch64-linux-nat.c: Sort headers.
5271         * aarch64-fbsd-tdep.c: Sort headers.
5272         * aarch64-fbsd-nat.c: Sort headers.
5273         * aarch32-linux-nat.c: Sort headers.
5274
5275 2019-04-04  Tom Tromey  <tom@tromey.com>
5276
5277         * varobj.c (varobj_create): Update.
5278         * rust-exp.y (struct rust_parser) <update_innermost_block,
5279         lookup_symbol>: New methods.
5280         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5281         Rename.
5282         (rust_parser::rust_lookup_type)
5283         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5284         * printcmd.c (display_command, do_one_display): Update.
5285         * parser-defs.h (struct parser_state) <parser_state>: Add
5286         "tracker" parameter.
5287         (block_tracker): New member.
5288         (class innermost_block_tracker) <innermost_block_tracker>: Add
5289         "types" parameter.
5290         <reset>: Remove method.
5291         (innermost_block): Don't declare.
5292         (null_post_parser): Update.
5293         * parse.c (innermost_block): Remove global.
5294         (write_dollar_variable): Update.
5295         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5296         Remove "tracker_types" parameter.
5297         (parse_expression): Add "tracker" parameter.
5298         (parse_expression_for_completion): Update.
5299         (null_post_parser): Add "tracker" parameter.
5300         * p-exp.y: Update rules.
5301         * m2-exp.y: Update rules.
5302         * language.h (struct language_defn) <la_post_parser>: Add
5303         "tracker" parameter.
5304         * go-exp.y: Update rules.
5305         * f-exp.y: Update rules.
5306         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5307         parameter.
5308         * d-exp.y: Update rules.
5309         * c-exp.y: Update rules.
5310         * breakpoint.c (set_breakpoint_condition): Create an
5311         innermost_block_tracker.
5312         (watch_command_1): Likewise.
5313         * ada-lang.c (resolve): Add "tracker" parameter.
5314         (resolve_subexp): Likewise.
5315         * ada-exp.y (write_var_from_sym): Update.
5316
5317 2019-04-04  Tom Tromey  <tom@tromey.com>
5318
5319         * type-stack.h: New file.
5320         * type-stack.c: New file.
5321         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5322         type-stack.h.
5323         (insert_into_type_stack, insert_type, push_type, push_type_int)
5324         (insert_type_address_space, pop_type, pop_type_int)
5325         (pop_typelist, pop_type_stack, append_type_stack)
5326         (push_type_stack, get_type_stack, push_typelist)
5327         (follow_type_instance_flags, follow_types): Don't declare.
5328         * parse.c (type_stack): Remove global.
5329         (parse_exp_in_context): Update.
5330         (insert_into_type_stack, insert_type, push_type, push_type_int)
5331         (insert_type_address_space, pop_type, pop_type_int)
5332         (pop_typelist, pop_type_stack, append_type_stack)
5333         (push_type_stack, get_type_stack, push_typelist)
5334         (follow_type_instance_flags, follow_types): Remove (moved to
5335         type-stack.c).
5336         * f-exp.y (type_stack): New global.
5337         Update rules.
5338         (push_kind_type, f_parse): Update.
5339         * d-exp.y (type_stack): New global.
5340         Update rules.
5341         (d_parse): Update.
5342         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5343         Update rules.
5344         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5345         (HFILES_NO_SRCDIR): Add type-stack.h.
5346
5347 2019-04-04  Tom Tromey  <tom@tromey.com>
5348
5349         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5350         (rust_parser::convert_ast_to_expression, rust_parse)
5351         (rust_lex_test_completion, rust_lex_tests): Update.
5352         * parser-defs.h (struct expr_completion_state): New.
5353         (struct parser_state) <parser_state>: Add completion parameter.
5354         <mark_struct_expression, mark_completion_tag>: New methods.
5355         <parse_completion, m_completion_state>: New members.
5356         (prefixify_expression, null_post_parser): Update.
5357         (mark_struct_expression, mark_completion_tag): Don't declare.
5358         * parse.c (parse_completion, expout_last_struct)
5359         (expout_tag_completion_type, expout_completion_name): Remove
5360         globals.
5361         (parser_state::mark_struct_expression)
5362         (parser_state::mark_completion_tag): Now methods.
5363         (prefixify_expression): Add last_struct parameter.
5364         (prefixify_subexp): Likewise.
5365         (parse_exp_1): Update.
5366         (parse_exp_in_context): Add cstate parameter.  Update.
5367         (parse_expression_for_completion): Create an
5368         expr_completion_state.
5369         (null_post_parser): Add "completion" parameter.
5370         * p-exp.y: Update rules.
5371         (yylex): Update.
5372         * language.h (struct language_defn) <la_post_parser>: Add
5373         "completing" parameter.
5374         * go-exp.y: Update rules.
5375         (lex_one_token): Update.
5376         * expression.h (parse_completion): Don't declare.
5377         * d-exp.y: Update rules.
5378         (lex_one_token): Update rules.
5379         * c-exp.y: Update rules.
5380         (lex_one_token): Update.
5381         * ada-lang.c (resolve): Add "parse_completion" parameter.
5382         (resolve_subexp): Likewise.
5383         (ada_resolve_function): Likewise.
5384
5385 2019-04-04  Tom Tromey  <tom@tromey.com>
5386
5387         * parser-defs.h (struct parser_state) <start_arglist,
5388         end_arglist>: New methods.
5389         <arglist_len, m_funcall_chain>: New members.
5390         (arglist_len, start_arglist, end_arglist): Don't declare.
5391         * parse.c (arglist_len, funcall_chain): Remove global.
5392         (start_arglist, end_arglist): Remove functions.
5393         (parse_exp_in_context): Update.
5394         * p-exp.y: Update rules.
5395         * m2-exp.y: Update rules.
5396         * go-exp.y: Update rules.
5397         * f-exp.y: Update rules.
5398         * d-exp.y: Update rules.
5399         * c-exp.y: Update rules.
5400
5401 2019-04-04  Tom Tromey  <tom@tromey.com>
5402
5403         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5404         lex_operator, push_back>: New methods.
5405         Update all rules.
5406         (rust_parser::lex_hex, lex_escape): Rename and update.
5407         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5408         (rust_parser::lex_operator): Rename and update.
5409         (rust_parser::lex_number, rustyylex, rustyyerror)
5410         (rust_lex_test_init, rust_lex_test_sequence)
5411         (rust_lex_test_push_back, rust_lex_tests): Update.
5412         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5413         parameter.
5414         <lexptr, prev_lexptr>: New members.
5415         (lexptr, prev_lexptr): Don't declare.
5416         * parse.c (lexptr, prev_lexptr): Remove globals.
5417         (parse_exp_in_context): Update.
5418         * p-exp.y (yylex, yyerror): Update.
5419         * m2-exp.y (parse_number, yylex, yyerror): Update.
5420         * go-exp.y (lex_one_token, yyerror): Update.
5421         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5422         * d-exp.y (lex_one_token, yyerror): Update.
5423         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5424         (lex_one_token, yyerror): Update.
5425         * ada-lex.l (YY_INPUT): Update.
5426         (rewind_to_char): Update.
5427         * ada-exp.y (yyerror): Update.
5428
5429 2019-04-04  Tom Tromey  <tom@tromey.com>
5430
5431         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5432         * parser-defs.h (struct parser_state) <parser_state>: Add new
5433         parameter.
5434         <comma_terminates>: New member.
5435         (comma_terminates): Don't declare global.
5436         * parse.c (comma_terminates): Remove global.
5437         (parse_exp_in_context): Update.
5438         * p-exp.y (yylex): Update.
5439         * m2-exp.y (yylex): Update.
5440         * go-exp.y (lex_one_token): Update.
5441         * f-exp.y (yylex): Update.
5442         * d-exp.y (lex_one_token): Update.
5443         * c-exp.y (lex_one_token): Update.
5444         * ada-lex.l: Update.
5445
5446 2019-04-04  Tom Tromey  <tom@tromey.com>
5447
5448         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5449         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5450         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5451         * parser-defs.h (paren_depth): Don't declare.
5452         * parse.c (paren_depth): Remove global.
5453         (parse_exp_in_context): Update.
5454         * p-exp.y (paren_depth): New global.
5455         (pascal_parse): Initialize it.
5456         * m2-exp.y (paren_depth): New global.
5457         (m2_parse): Initialize it.
5458         * go-exp.y (paren_depth): New global.
5459         (go_parse): Initialize it.
5460         * f-exp.y (paren_depth): New global.
5461         (f_parse): Initialize it.
5462         * d-exp.y (paren_depth): New global.
5463         (d_parse): Initialize it.
5464         * c-exp.y (paren_depth): New global.
5465         (c_parse): Initialize it.
5466         * ada-lex.l (paren_depth): New global.
5467         (lexer_init): Initialize it.
5468
5469 2019-04-04  Tom Tromey  <tom@tromey.com>
5470
5471         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5472         (rust_parser::convert_ast_to_type)
5473         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5474         * parser-defs.h (struct parser_state) <parser_state>: Add
5475         parameters.  Initialize new members.
5476         <expression_context_block, expression_context_pc>: New members.
5477         * parse.c (expression_context_block, expression_context_pc):
5478         Remove globals.
5479         (parse_exp_in_context): Update.
5480         * p-exp.y: Update all rules.
5481         (yylex): Update.
5482         * m2-exp.y: Update all rules.
5483         (yylex): Update.
5484         * go-exp.y (yylex): Update.
5485         * f-exp.y (yylex): Update.
5486         * d-exp.y: Update all rules.
5487         (yylex): Update.
5488         * c-exp.y: Update all rules.
5489         (lex_one_token, classify_name, yylex, c_parse): Update.
5490         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5491
5492 2019-04-04  Tom Tromey  <tom@tromey.com>
5493
5494         * gdbarch.h, gdbarch.c: Rebuild.
5495         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5496         * stap-probe.h:
5497         (struct stap_parse_info): Replace "parser_state" with
5498         "expr_builder".
5499         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5500         (parser_state): New class.
5501         * parse.c (expr_builder): Rename.
5502         (expr_builder::release): Rename.
5503         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5504         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5505         (write_exp_elt_longcst, write_exp_elt_floatcst)
5506         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5507         (write_exp_string_vector, write_exp_bitstring)
5508         (write_exp_msymbol, mark_struct_expression)
5509         (write_dollar_variable)
5510         (insert_type_address_space, increase_expout_size): Replace
5511         "parser_state" with "expr_builder".
5512         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5513         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5514         "parser_state" with "expr_builder".
5515
5516 2019-04-04  Tom Tromey  <tom@tromey.com>
5517
5518         * rust-exp.y: Replace "parse_language" with method call.
5519         * p-exp.y:
5520         (yylex): Replace "parse_language" with method call.
5521         * m2-exp.y:
5522         (yylex): Replace "parse_language" with method call.
5523         * go-exp.y (classify_name): Replace "parse_language" with method
5524         call.
5525         * f-exp.y (yylex): Replace "parse_language" with method call.
5526         * d-exp.y (lex_one_token): Replace "parse_language" with method
5527         call.
5528         * c-exp.y:
5529         (lex_one_token, classify_name, yylex): Replace "parse_language"
5530         with method call.
5531         * ada-exp.y (find_primitive_type, type_char)
5532         (type_system_address): Replace "parse_language" with method call.
5533
5534 2019-04-04  Tom Tromey  <tom@tromey.com>
5535
5536         * rust-exp.y: Replace "parse_gdbarch" with method call.
5537         * parse.c (write_dollar_variable, insert_type_address_space):
5538         Replace "parse_gdbarch" with method call.
5539         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5540         call.
5541         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5542         call.
5543         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5544         "parse_gdbarch" with method call.
5545         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5546         with method call.
5547         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5548         "parse_gdbarch" with method call.
5549         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5550         "parse_gdbarch" with method call.
5551         * c-exp.y (parse_type, parse_number, classify_name): Replace
5552         "parse_gdbarch" with method call.
5553         * ada-lex.l: Replace "parse_gdbarch" with method call.
5554         * ada-exp.y (parse_type, find_primitive_type, type_char)
5555         (type_system_address): Replace "parse_gdbarch" with method call.
5556
5557 2019-04-04  Tom Tromey  <tom@tromey.com>
5558
5559         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5560         * stap-probe.c (stap_parse_argument): Update.
5561         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5562         initial_size parameter.
5563         * rust-exp.y (rust_lex_tests): Update.
5564         * parse.c (parser_state): Update.
5565         (parse_exp_in_context): Update.
5566         * parser-defs.h (struct parser_state) <parser_state>: Remove
5567         "initial_size" parameter.
5568
5569 2019-04-04  Tom Tromey  <tom@tromey.com>
5570
5571         * parser-defs.h (increase_expout_size): Don't declare.
5572         * parse.c (increase_expout_size): Now static.
5573
5574 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5575
5576         * gnu-nat.c (gnu_nat_target::wait): Fix
5577         target_waitstatus_to_string call.
5578
5579 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5580
5581         * eval.c (evaluate_subexp_standard): Handle internal functions
5582         during Fortran function call handling.
5583
5584 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5585
5586         * NEWS: Mention new internal functions.
5587         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5588         (read_base_type): Use dwarf2_init_complex_target_type.
5589         * value.c (creal_internal_fn): New function.
5590         (cimag_internal_fn): New function.
5591         (_initialize_values): Register new internal functions.
5592
5593 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5594
5595         * infrun.c (stop_all_threads): If debug_infrun, always
5596         trace the wait status after wait_one, using
5597         target_waitstatus_to_string and target_pid_to_str.
5598         (handle_inferior_event): Replace various trace of
5599         wait status kind by a single trace.
5600         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5601         wait status kind image by target_waitstatus_to_string.
5602         * target/waitstatus.c (target_waitstatus_to_string): Fix
5603         obsolete comment.
5604
5605 2019-04-01  Tom Tromey  <tromey@adacore.com>
5606
5607         PR symtab/23331:
5608         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5609
5610 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5611             Pedro Alves  <palves@redhat.com>
5612
5613         * top.c (quit_force): Call 'finalize_values'.
5614         * value.c (finalize_values): New function.
5615         * value.h (finalize_values): Declare.
5616
5617 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5618
5619         * NEWS: Announce $_gdb_major and $_gdb_minor.
5620
5621         * top.c (init_gdb_version_vars): New function.
5622         (gdb_init): Call init_gdb_version_vars.
5623
5624 2019-03-29  Tom Tromey  <tromey@adacore.com>
5625
5626         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5627         help text.  Remove dead code.
5628
5629 2019-03-29  Keith Seitz  <keiths@redhat.com>
5630
5631         From Siddhesh Poyarekar:
5632         * f-lang.h (f77_get_upperbound): Return LONGEST.
5633         (f77_get_lowerbound): Likewise.
5634         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5635         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5636         print them.
5637         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5638         plongest to format print it.
5639         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5640         (f77_get_upperbound): Likewise.
5641         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5642         LOWER_BOUND to LONGEST.
5643         (f77_create_arrayprint_offset_tbl): Likewise.
5644
5645 2019-03-29  Keith Seitz  <keiths@redhat.com>
5646
5647         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5648         %s/pulongest for TYPE_LENGTH instead of %d in format
5649         strings.
5650         * ada-typerint.c (ada_print_type): Likewise.
5651         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5652         * compile/compile-c-support.c (generate_register_struct): Likewise.
5653         * gdbtypes.c (recursive_dump_type): Likewise.
5654         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5655         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5656         instead of %d in format strings.
5657         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5658         to std::min to ULONGEST.
5659         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5660         instead of %d in format strings.
5661         * tracepoint.c (info_scope_command): Likewise.
5662         * typeprint.c (print_offset_data::update)
5663         (print_offset_data::finish): Likewise.
5664         * xtensa-tdep.c (xtensa_store_return_value)
5665         (xtensa_push_dummy_call): Likewise.
5666
5667 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5668
5669         * windows-nat.c (display_selector): Fixed format specifications
5670         for 64-bit Cygwin.
5671
5672 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5673
5674         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5675
5676 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5677
5678         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5679         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5680         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5681         (nios2_linux_init_abi): Install it.
5682
5683 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5684
5685         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5686
5687 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5688
5689         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5690
5691 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5692             Tom Tromey  <tromey@adacore.com>
5693
5694         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5695
5696 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5697
5698         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5699         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5700         method to compute the bounds of range types. Also print "[evaluated]"
5701         if the bounds' values come from a dynamic evaluation.
5702
5703 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5704
5705         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5706         whitespace when pretty printing is on.
5707
5708 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5709
5710         * ppc-linux-nat.c: Add include.
5711
5712 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5713
5714         * NEWS: Mention AArch64 Pointer Authentication.
5715
5716 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5717
5718         * arm-linux-nat.c: Add include.
5719
5720 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5721
5722         * source-cache.c (source_cache::get_source_lines): Re-read
5723         fullname after calling open_source_file.
5724
5725 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5726
5727         * NEWS: Mention TLS support for FreeBSD.
5728
5729 2019-03-25  Tom Tromey  <tromey@adacore.com>
5730
5731         * minsyms.c (BUNCH_SIZE): Update comment.
5732         (~minimal_symbol_reader): Remove old comment.
5733         (compact_minimal_symbols): Update comment.
5734         (minimal_symbol_reader::install): Remove old comment.  Update
5735         other comments.
5736
5737 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5738
5739         * s390-linux-nat.c: Add include.
5740
5741 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5742
5743         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5744         Call linux_get_hwcap.
5745         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5746         Likewise.
5747         (aarch64_linux_get_hwcap): Remove function.
5748         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5749         declaration.
5750         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5751         linux_get_hwcap.
5752         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5753         * linux-tdep.c (linux_get_hwcap): Add function.
5754         (linux_get_hwcap2): Likewise.
5755         * linux-tdep.h (linux_get_hwcap): Add declaration.
5756         (linux_get_hwcap2): Likewise.
5757         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5758         (ppc_linux_get_hwcap2): Likewise.
5759         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5760         linux_get_hwcap.
5761         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5762         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5763         (ppc_linux_nat_target::read_description): Likewise.
5764         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5765         * s390-linux-nat.c: Likewise.
5766         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5767
5768 2019-03-24  Tom Tromey  <tom@tromey.com>
5769
5770         * ada-lang.c (standard_lookup): Simplify initialization.
5771         (ada_lookup_symbol_nonlocal): Simplify return.
5772         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5773         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5774         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5775         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5776         initialization.
5777         * solib.c (solib_global_lookup): Simplify.
5778         * symtab.c (null_block_symbol): Remove.
5779         (symbol_cache_lookup): Simplify returns.
5780         (lookup_language_this): Simplify returns.
5781         (lookup_symbol_aux): Simplify return.
5782         (lookup_local_symbol): Simplify returns.
5783         (lookup_global_symbol_from_objfile): Simplify return.
5784         (lookup_symbol_in_objfile_symtabs)
5785         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5786         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5787         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5788         * cp-namespace.c (cp_lookup_bare_symbol)
5789         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5790         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5791         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5792         (cp_lookup_symbol_via_imports): Simplify initialization.
5793         (find_symbol_in_baseclass): Likewise.
5794         * symtab.h (null_block_symbol): Remove.
5795         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5796         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5797         (d_lookup_symbol_module): Likewise.
5798         (find_symbol_in_baseclass): Simplify initialization.
5799
5800 2019-03-24  Tom Tromey  <tom@tromey.com>
5801
5802         * expression.h: Don't include symtab.h.
5803         (struct block): Forward declare.
5804
5805 2019-03-24  Tom Tromey  <tom@tromey.com>
5806
5807         * c-exp.y (typebase): Remove casts.
5808         * gdbtypes.c (lookup_unsigned_typename, )
5809         (lookup_signed_typename): Remove cast.
5810         * eval.c (parse_to_comma_and_eval): Remove cast.
5811         * parse.c (write_dollar_variable): Remove cast.
5812         * block.h (struct block) <superblock>: Now const.
5813         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5814         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5815         (map_block): Make "block" const.
5816         * symfile.h (struct quick_symbol_functions)
5817         <map_matching_symbols>: Constify block argument to "callback".
5818         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5819         const.
5820         (find_pc_sect_compunit_symtab): Make "b" const.
5821         (find_symbol_at_address): Likewise.
5822         (search_symbols): Likewise.
5823         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5824         (dw2_debug_names_lookup_symbol): Likewise.
5825         (dw2_map_matching_symbols): Update.
5826         * p-valprint.c (pascal_val_print): Remove "block".
5827         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5828         (aux_add_nonlocal_symbols): Make "block" const.
5829         (resolve_subexp): Remove cast.
5830         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5831         const.
5832         (iterate_over_file_blocks): Likewise.
5833         * f-exp.y (%union) <bval>: Remove.
5834         * coffread.c (patch_opaque_types): Make "b" const.
5835         * spu-tdep.c (spu_catch_start): Make "block" const.
5836         * c-valprint.c (print_unpacked_pointer): Remove "block".
5837         * symmisc.c (dump_symtab_1): Make "b" const.
5838         (block_depth): Make "block" const.
5839         * d-exp.y (%union) <bval>: Remove.
5840         * cp-support.h (cp_lookup_rtti_type): Update.
5841         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5842         * psymtab.c (psym_lookup_symbol): Make "block" const.
5843         (maintenance_check_psymtabs): Make "b" const.
5844         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5845         (enumerate_locals, enumerate_args): Update.
5846         * python/py-symtab.c (stpy_global_block): Make "block" const.
5847         (stpy_static_block): Likewise.
5848         * inline-frame.c (block_starting_point_at): Make "new_block"
5849         const.
5850         * block.c (find_block_in_blockvector): Make return type const.
5851         (blockvector_for_pc_sect): Make "b" const.
5852         (find_block_in_blockvector): Make "b" const.
5853
5854 2019-03-23  Tom Tromey  <tom@tromey.com>
5855
5856         * varobj.c (varobj_create): Update.
5857         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5858         * printcmd.c (display_command, do_one_display): Don't reset
5859         innermost_block.
5860         * parser-defs.h (enum innermost_block_tracker_type): Move to
5861         expression.h.
5862         (innermost_block): Update comment.
5863         * parse.c (parse_exp_1): Add tracker_types parameter.
5864         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5865         tracker_types parameter.  Reset innermost_block.
5866         (parse_exp_in_context): Remove.
5867         (parse_expression_for_completion): Update.
5868         * objfiles.c (~objfile): Don't reset expression_context_block or
5869         innermost_block.
5870         * expression.h (enum innermost_block_tracker_type): Move from
5871         parser-defs.h.
5872         (parse_exp_1): Add tracker_types parameter.
5873         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5874         reset innermost_block.
5875
5876 2019-03-23  Tom Tromey  <tom@tromey.com>
5877
5878         * objfiles.h: Include bcache.h.
5879
5880 2019-03-23  Tom Tromey  <tom@tromey.com>
5881
5882         * linespec.c (get_current_search_block): Use
5883         scoped_restore_current_language.
5884         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5885
5886 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5887             Jiong Wang  <jiong.wang@arm.com>
5888
5889         * aarch64-linux-tdep.c
5890         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5891         section.
5892         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5893
5894 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5895             Jiong Wang  <jiong.wang@arm.com>
5896
5897         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5898         instructions.
5899         (aarch64_analyze_prologue_test): Add PACIASP test.
5900         (aarch64_prologue_prev_register): Unmask PC value.
5901
5902 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5903             Jiong Wang  <jiong.wang@arm.com>
5904
5905         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5906         (aarch64_dwarf2_prev_register): Unmask PC value.
5907         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5908         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5909         DW_CFA_AARCH64_negate_ra_state.
5910         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5911
5912 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5913             Jiong Wang  <jiong.wang@arm.com>
5914
5915         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5916         registers.
5917         (aarch64_pseudo_register_name): Likewise.
5918         (aarch64_pseudo_register_type): Likewise.
5919         (aarch64_pseudo_register_reggroup_p): Likewise.
5920         (aarch64_gdbarch_init): Add pauth registers.
5921         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5922         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5923         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5924         (struct gdbarch_tdep): Add regnum for ra_state.
5925
5926 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5927             Jiong Wang  <jiong.wang@arm.com>
5928
5929         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5930
5931 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5932             Jiong Wang  <jiong.wang@arm.com>
5933
5934         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5935         function.
5936         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5937         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5938         (aarch64_gdbarch_init): Add puth registers.
5939         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5940         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5941         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5942
5943 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5944             Jiong Wang  <jiong.wang@arm.com>
5945
5946         * aarch64-linux-nat.c
5947         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5948         * aarch64-linux-tdep.c
5949         (aarch64_linux_core_read_description): Likewise.
5950         (aarch64_linux_get_hwcap): New function.
5951         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5952         (aarch64_linux_get_hwcap): New declaration.
5953
5954 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5955             Jiong Wang  <jiong.wang@arm.com>
5956
5957         * aarch64-linux-nat.c
5958         (aarch64_linux_nat_target::read_description): Add pauth param.
5959         * aarch64-linux-tdep.c
5960         (aarch64_linux_core_read_description): Likewise.
5961         * aarch64-tdep.c (struct target_desc): Add in pauth.
5962         (aarch64_read_description): Add pauth param.
5963         (aarch64_gdbarch_init): Likewise.
5964         * aarch64-tdep.h (aarch64_read_description): Likewise.
5965         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5966         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5967         * features/Makefile: Add new files.
5968         * features/aarch64-pauth.c: New file.
5969         * features/aarch64-pauth.xml: New file.
5970
5971 2019-03-20  Tom Tromey  <tromey@adacore.com>
5972
5973         * infrun.c (handle_inferior_event): Rename from
5974         handle_inferior_event_1.  Create a scoped_value_mark.
5975         (handle_inferior_event): Remove.
5976
5977 2019-03-19  Tom Tromey  <tromey@adacore.com>
5978
5979         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5980         * infrun.h (print_stop_event): Add "displays" parameter.
5981         * infrun.c (print_stop_event): Add "displays" parameter.
5982
5983 2019-03-19  Pedro Alves  <palves@redhat.com>
5984
5985         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5986         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5987         to -1.  Fix TABs vs spaces.
5988         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5989         * tui/tui-out.h (tui_ui_out) Add intro comments.
5990         <m_line, m_start_of_line>: In-class initialize, and add describing
5991         comment.
5992
5993 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5994
5995         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5996         variable names.
5997         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5998
5999 2019-03-18  Pedro Alves  <palves@redhat.com>
6000             Eli Zaretskii <eliz@gnu.org>
6001
6002         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6003         m_line and m_start_of_line.
6004
6005 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6006
6007         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6008         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6009         it returns a newline.  This fixes a regression in TU mode, whereby
6010         the next line is output on the same screen line as the user input.
6011
6012 2019-03-18  Tom Tromey  <tromey@adacore.com>
6013
6014         * minsyms.c (minimal_symbol_reader::install): Remove call to
6015         obstack_blank.
6016
6017 2019-03-18  Pedro Alves  <palves@redhat.com>
6018
6019         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6020         New globals.
6021         (apply_style): New, factored out from ...
6022         (apply_ansi_escape): ... this.  Handle reverse video mode.
6023         (tui_set_reverse_mode): New function.
6024         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6025         * tui/tui-winsource.c (tui_show_source_line): Use
6026         tui_set_reverse_mode instead of setting A_STANDOUT.
6027         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6028         New setter methods.
6029
6030 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6031
6032         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6033         Handle tabs.
6034
6035 2019-03-18  Tom Tromey  <tromey@adacore.com>
6036
6037         * ada-lang.c (empty_array): Add "high" parameter.
6038         (ada_evaluate_subexp): Update.
6039
6040 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6041
6042         * unittests/string_view-selftests.c: Define
6043         _initialize_string_view_selftests unconditionally.
6044
6045 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6046
6047         PR gdb/24350
6048         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6049
6050 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6051
6052         PR gdb/24351
6053         * windows-nat.c (display_selector): Fix format specifiers.
6054
6055 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6056
6057         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6058         tui_refill_source_window instead of tui_refresh_win, to update the
6059         current execution line.  This fixes redisplay of the current line
6060         when stepping through the code with "next" or "step".
6061
6062 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6063
6064         * source-cache.c (source_cache::get_source_lines): Call
6065         find_source_lines to initialize s->nlines.  This fixes vertical
6066         scrolling of TUI source window when the DOWN arrow is pressed.
6067
6068 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6069
6070         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6071         linux-thread-db.c (_initialize_thread_db): Likewise.
6072
6073 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6074
6075         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6076         wclrtoeol in tui_show_source_line".  This reverts changes made in
6077         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6078
6079 2019-03-15  Tom Tromey  <tom@tromey.com>
6080
6081         * symtab.h (struct minimal_symbol): Derive from
6082         general_symbol_info.
6083         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6084         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6085         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6086         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6087         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6088         (MSYMBOL_SEARCH_NAME): Update.
6089         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6090         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6091         * minsyms.c (minimal_symbol_reader::record_full): Update.
6092
6093 2019-03-15  Tom Tromey  <tom@tromey.com>
6094
6095         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6096
6097 2019-03-15  Tom Tromey  <tom@tromey.com>
6098
6099         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6100         unique_xmalloc_ptr.
6101         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6102         Update.
6103         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6104         (build_minimal_symbol_hash_tables)
6105         (minimal_symbol_reader::install): Update.
6106
6107 2019-03-15  Tom Tromey  <tom@tromey.com>
6108
6109         * symtab.c (create_demangled_names_hash): Update.
6110         (symbol_set_names): Update.
6111         * objfiles.h (struct objfile_per_bfd_storage)
6112         <demangled_names_hash>: Now an htab_up.
6113         * objfiles.c (objfile_per_bfd_storage): Simplify.
6114
6115 2019-03-15  Tom Tromey  <tom@tromey.com>
6116
6117         * objfiles.h (struct objfile_per_bfd_storage): Declare
6118         destructor.
6119         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6120         New.
6121         (get_objfile_bfd_data): Use new.  Don't initialize
6122         language_of_main.
6123         (free_objfile_per_bfd_storage): Remove.
6124         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6125
6126 2019-03-15  Tom Tromey  <tom@tromey.com>
6127
6128         * symfile.c (reread_symbols): Update.
6129         * objfiles.c (objfile::objfile): Update.
6130         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6131         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6132         comment.
6133         (minimal_symbol_reader::install): Update.
6134         (terminate_minimal_symbol_table): Remove.
6135         * jit.c (jit_object_close_impl): Update.
6136
6137 2019-03-15  Tom Tromey  <tom@tromey.com>
6138
6139         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6140         initializations.
6141
6142 2019-03-15  Tom Tromey  <tom@tromey.com>
6143
6144         * objfiles.h (struct objfile_per_bfd_storage)
6145         <demangled_hash_languages>: Now a bitset.
6146         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6147         (lookup_minimal_symbol): Update.
6148
6149 2019-03-15  Tom Tromey  <tom@tromey.com>
6150
6151         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6152         Don't return the symbol.
6153         * coffread.c (record_minimal_symbol): Use record_full.
6154
6155 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6156
6157         The MS-Windows port of ncurses fails to switch to a color pair if
6158         one or both of the colors are the implicit default colors.  This
6159         change records the default colors when TUI is initialized, and
6160         then specifies them explicitly when a color pair uses the default
6161         colors.  This allows color styling in TUI mode on MS-Windows.
6162
6163         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6164         ncurses_norm_attr.
6165         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6166         colors in ncurses_norm_attr.
6167         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6168         "none", replace it with the default color recorded in
6169         ncurses_norm_attr.
6170
6171 2019-03-14  Tom Tromey  <tromey@adacore.com>
6172
6173         * source-cache.h (class source_cache) <get_source_lines>: Return
6174         std::string.
6175         * source-cache.c (source_cache::extract_lines): Handle case where
6176         first_pos==npos.  Return std::string.
6177         (source_cache::get_source_lines): Update.
6178
6179 2019-03-14  Tom Tromey  <tromey@adacore.com>
6180
6181         * NEWS: Add item for "style sources" commands.
6182         * source-cache.c (source_cache::get_source_lines): Check
6183         source_styling.
6184         * cli/cli-style.c (source_styling): New global.
6185         (_initialize_cli_style): Add "style sources" commands.
6186         (show_style_sources): New function.
6187         * cli/cli-style.h (source_styling): Declare.
6188
6189 2019-03-14  Pedro Alves  <palves@redhat.com>
6190             Tom Tromey  <tromey@adacore.com>
6191
6192         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6193         * tui/tui-winsource.c (tui_refill_source_window): New function,
6194         from...
6195         (tui_horizontal_source_scroll): ... here.  Move some logic.
6196         * cli/cli-style.c (set_style_enabled): Notify new observable.
6197         * tui/tui-hooks.c (tui_redisplay_source): New function.
6198         (tui_attach_detach_observers): Attach or detach
6199         tui_redisplay_source.
6200         * observable.h (source_styling_changed): New observable.
6201         * observable.c: Define source_styling_changed observable.
6202
6203 2019-03-13  Tom Tromey  <tromey@adacore.com>
6204
6205         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6206         (i386_gnu_nat_target::store_registers): Update.
6207         * target-debug.h (target_debug_print_std_string): New macro.
6208         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6209         * windows-tdep.c (display_one_tib): Update.
6210         * tui/tui-stack.c (tui_make_status_line): Update.
6211         * top.c (print_inferior_quit_action): Update.
6212         * thread.c (thr_try_catch_cmd): Update.
6213         (add_thread_with_info): Update.
6214         (thread_target_id_str): Update.
6215         (thr_try_catch_cmd): Update.
6216         (thread_command): Update.
6217         (thread_find_command): Update.
6218         * record-btrace.c (record_btrace_target::info_record)
6219         (record_btrace_resume_thread, record_btrace_target::resume)
6220         (record_btrace_cancel_resume, record_btrace_step_thread)
6221         (record_btrace_target::wait, record_btrace_target::wait)
6222         (record_btrace_target::wait, record_btrace_target::stop): Update.
6223         * progspace.c (print_program_space): Update.
6224         * process-stratum-target.c
6225         (process_stratum_target::thread_address_space): Update.
6226         * linux-fork.c (linux_fork_mourn_inferior)
6227         (detach_checkpoint_command, info_checkpoints_command)
6228         (linux_fork_context): Update.
6229         (linux_fork_detach): Update.
6230         (class scoped_switch_fork_info): Update.
6231         (delete_checkpoint_command): Update.
6232         * infrun.c (follow_fork_inferior): Update.
6233         (follow_fork_inferior): Update.
6234         (proceed_after_vfork_done): Update.
6235         (handle_vfork_child_exec_or_exit): Update.
6236         (follow_exec): Update.
6237         (displaced_step_prepare_throw): Update.
6238         (displaced_step_restore): Update.
6239         (start_step_over): Update.
6240         (resume_1): Update.
6241         (clear_proceed_status_thread): Update.
6242         (proceed): Update.
6243         (print_target_wait_results): Update.
6244         (do_target_wait): Update.
6245         (context_switch): Update.
6246         (stop_all_threads): Update.
6247         (restart_threads): Update.
6248         (finish_step_over): Update.
6249         (handle_signal_stop): Update.
6250         (switch_back_to_stepped_thread): Update.
6251         (keep_going_pass_signal): Update.
6252         (print_exited_reason): Update.
6253         (normal_stop): Update.
6254         * inferior.c (inferior_pid_to_str): Change return type.
6255         (print_selected_inferior): Update.
6256         (add_inferior): Update.
6257         (detach_inferior): Update.
6258         * dummy-frame.c (fprint_dummy_frames): Update.
6259         * dcache.c (dcache_info_1): Update.
6260         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6261         (btrace_fetch, btrace_clear): Update.
6262         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6263         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6264         type.
6265         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6266         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6267         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6268         * gdbarch.c, gdbarch.h: Rebuild.
6269         * gdbarch.sh (core_pid_to_str): Change return type.
6270         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6271         return type.
6272         (windows_nat_target::pid_to_str): Change return type.
6273         (windows_delete_thread): Update.
6274         (windows_nat_target::attach): Update.
6275         (windows_nat_target::files_info): Update.
6276         * target-delegates.c: Rebuild.
6277         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6278         return type.
6279         (sol_thread_target::pid_to_str): Change return type.
6280         * remote.c (class remote_target) <pid_to_str>: Change return
6281         type.
6282         (remote_target::pid_to_str): Change return type.
6283         (extended_remote_target::attach, remote_target::remote_stop_ns)
6284         (remote_target::remote_notif_remove_queued_reply)
6285         (remote_target::push_stop_reply, remote_target::disable_btrace):
6286         Update.
6287         (extended_remote_target::attach): Update.
6288         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6289         type.
6290         (gdbsim_target::pid_to_str): Change return type.
6291         * ravenscar-thread.c (struct ravenscar_thread_target)
6292         <pid_to_str>: Change return type.
6293         (ravenscar_thread_target::pid_to_str): Change return type.
6294         * procfs.c (class procfs_target) <pid_to_str>: Change return
6295         type.
6296         (procfs_target::pid_to_str): Change return type.
6297         (procfs_target::attach): Update.
6298         (procfs_target::detach): Update.
6299         (procfs_target::fetch_registers): Update.
6300         (procfs_target::store_registers): Update.
6301         (procfs_target::wait): Update.
6302         (procfs_target::files_info): Update.
6303         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6304         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6305         return type.
6306         (nto_procfs_target::pid_to_str): Change return type.
6307         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6308         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6309         return type.
6310         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6311         (exit_lwp): Update.
6312         (attach_proc_task_lwp_callback, get_detach_signal)
6313         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6314         (linux_nat_target::resume, wait_lwp, stop_callback)
6315         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6316         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6317         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6318         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6319         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6320         type.
6321         (inf_ptrace_target::attach): Update.
6322         (inf_ptrace_target::files_info): Update.
6323         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6324         type.
6325         (go32_nat_target::pid_to_str): Change return type.
6326         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6327         (gnu_nat_target::wait): Update.
6328         (gnu_nat_target::wait): Update.
6329         (gnu_nat_target::resume): Update.
6330         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6331         (fbsd_nat_target::wait): Update.
6332         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6333         type.
6334         (darwin_nat_target::attach): Update.
6335         * corelow.c (class core_target) <pid_to_str>: Change return type.
6336         (core_target::pid_to_str): Change return type.
6337         * target.c (normal_pid_to_str): Change return type.
6338         (default_pid_to_str): Likewise.
6339         (target_pid_to_str): Change return type.
6340         (target_translate_tls_address): Update.
6341         (target_announce_detach): Update.
6342         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6343         return type.
6344         (bsd_uthread_target::pid_to_str): Change return type.
6345         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6346         type.
6347         (bsd_kvm_target::pid_to_str): Change return type.
6348         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6349         return type.
6350         (aix_thread_target::pid_to_str): Change return type.
6351         * target.h (struct target_ops) <pid_to_str>: Change return type.
6352         (target_pid_to_str, normal_pid_to_str): Likewise.
6353         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6354         type.
6355         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6356         type.
6357         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6358         return type.
6359         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6360         type.
6361         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6362         type.
6363         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6364         return type.
6365
6366 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6367
6368         * NEWS: Mention that the new default MI version is 3.  Mention
6369         changes to the output of commands and events that deal with
6370         multi-location breakpoints.
6371         * breakpoint.c: Include "mi/mi-out.h".
6372         (print_one_breakpoint): Change output syntax if using MI version
6373         >= 3.
6374         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6375         New.
6376         (mi_multi_location_breakpoint_output_fixed): New.
6377         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6378         (mi_cmd_fix_multi_location_breakpoint_output): New.
6379         (mi_multi_location_breakpoint_output_fixed): New.
6380         * mi/mi-cmds.c (mi_cmds): Register command
6381         -fix-multi-location-breakpoint-output.
6382         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6383         interpreter "mi".
6384
6385 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6386
6387         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6388         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6389         instantiate mi_ui_out based on interpreter name.
6390         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6391         * mi/mi-main.c (mi_load_progress): Likewise.
6392
6393 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6394
6395         * NEWS: Combine separate "New targets" sections for 8.3.
6396
6397 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6398
6399         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6400         (ppcfbsd_init_abi): Install gdbarch
6401         "fetch_tls_load_module_address" and "get_thread_local_address"
6402         methods.
6403
6404 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6405
6406         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6407         (riscv_fbsd_init_abi): Install gdbarch
6408         "fetch_tls_load_module_address" and "get_thread_local_address"
6409         methods.
6410
6411 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6412
6413         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6414         (i386fbsd_init_abi): Install gdbarch
6415         "fetch_tls_load_module_address" and "get_thread_local_address"
6416         methods.
6417
6418 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6419
6420         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6421         (amd64fbsd_init_abi): Install gdbarch
6422         "fetch_tls_load_module_address" and "get_thread_local_address"
6423         methods.
6424
6425 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6426
6427         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6428         (struct fbsd_pspace_data): New type.
6429         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6430         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6431         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6432         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6433         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6434
6435 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6436
6437         * gdbtypes.c (lookup_struct_elt): New function.
6438         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6439         * gdbtypes.h (struct struct_elt): New type.
6440         (lookup_struct_elt): New prototype.
6441
6442 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6443
6444         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6445         remove disabled code block.
6446
6447 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6448
6449         * gdbarch.sh (get_thread_local_address): New method.
6450         * gdbarch.h, gdbarch.c: Regenerate.
6451         * target.c (target_translate_tls_address): Use
6452         gdbarch_get_thread_local_address if present instead of
6453         target::get_thread_local_address.
6454
6455 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6456
6457         * target.h (target::get_thread_local_address): Update comment.
6458
6459 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6460
6461         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6462         objfile->separate_debug_objfile_backlink if not NULL.
6463
6464 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6465
6466         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6467         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6468         (amd64bsd_store_inferior_registers): Likewise.
6469         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6470         Enable segment base registers.
6471         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6472         PT_GETFSBASE and PT_GETGSBASE.
6473         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6474         PT_SETGSBASE.
6475         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6476         segment base registers.
6477         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6478
6479 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6480
6481         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6482         Update calls to i386_target_description to add 'segments'
6483         parameter.
6484         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6485         add segment base registers.
6486         * arch/i386.c (i386_create_target_description): Add 'segments'
6487         parameter to enable segment base registers.
6488         * arch/i386.h (i386_create_target_description): Likewise.
6489         * features/i386/32bit-segments.xml: New file.
6490         * features/i386/32bit-segments.c: Generate.
6491         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6492         call to i386_target_description to add 'segments' parameter.
6493         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6494         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6495         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6496         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6497         if feature is present.
6498         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6499         Add 'segments' parameter to call to i386_target_description.
6500         (i386_target_description): Add 'segments' parameter to enable
6501         segment base registers.
6502         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6503         to call to i386_target_description.
6504         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6505         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6506         Define I386_NUM_REGS.
6507         (i386_target_description): Add 'segments' parameter to enable
6508         segment base registers.
6509
6510 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6511
6512         PR/24325
6513         * source-cache.c: #undef open and close, to avoid unresolved
6514         externals during linking.
6515
6516 2019-03-12  Tom Tromey  <tromey@adacore.com>
6517
6518         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6519         const.  Add initializers.
6520         (_initialize_remote): Don't initialize ptid globals.
6521
6522 2019-03-12  Pedro Alves  <palves@redhat.com>
6523
6524         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6525
6526 2019-03-12  Pedro Alves  <palves@redhat.com>
6527
6528         * cp-name-parser.y (main): Remove unused 'len' variable.
6529
6530 2019-03-12  Tom Tromey  <tromey@adacore.com>
6531
6532         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6533         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6534
6535 2019-03-12  Tom Tromey  <tromey@adacore.com>
6536
6537         * linux-nat.c (iterate_over_lwps): Update.
6538         (stop_callback): Remove parameter.
6539         (stop_wait_callback, detach_callback, resume_set_callback)
6540         (select_singlestep_lwp_callback, set_ignore_sigint)
6541         (status_callback, resumed_callback, resume_clear_callback)
6542         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6543         data parameter.
6544         (linux_nat_target::detach, linux_nat_target::resume)
6545         (linux_stop_and_wait_all_lwps, select_event_lwp)
6546         (linux_nat_filter_event, linux_nat_wait_1)
6547         (linux_nat_target::kill, linux_nat_target::stop)
6548         (linux_nat_target::stop): Update.
6549         (linux_nat_resume_callback): Change type.
6550         (resume_stopped_resumed_lwps, count_events_callback)
6551         (select_event_lwp_callback): Likewise.
6552         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6553         * arm-linux-nat.c (struct update_registers_data): Remove.
6554         (update_registers_callback): Change type.
6555         (arm_linux_insert_hw_breakpoint1): Update.
6556         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6557         parameter.
6558         (x86_linux_dr_set_addr): Update.
6559         (x86_linux_dr_set_control): Update.
6560         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6561         (iterate_over_lwps): Use gdb::function_view.
6562         * nat/aarch64-linux-hw-point.c (struct
6563         aarch64_dr_update_callback_param): Remove.
6564         (debug_reg_change_callback): Change type.
6565         (aarch64_notify_debug_reg_change): Update.
6566         * s390-linux-nat.c (s390_refresh_per_info): Update.
6567
6568 2019-03-11  Tom Tromey  <tromey@adacore.com>
6569
6570         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6571         redundant assignment to "this_cu".
6572
6573 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6574
6575         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6576
6577 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6578
6579         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6580         from...
6581         (rank_one_type): ... this.
6582
6583 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6584
6585         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6586         from...
6587         (rank_one_type): ... this.
6588
6589 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6590
6591         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6592         from...
6593         (rank_one_type): ... this.
6594
6595 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6596
6597         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6598         from...
6599         (rank_one_type): ... this.
6600
6601 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6602
6603         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6604         from...
6605         (rank_one_type): ... this.
6606
6607 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6608
6609         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6610         from...
6611         (rank_one_type): ... this.
6612
6613 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6614
6615         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6616         from...
6617         (rank_one_type): ... this.
6618
6619 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6620
6621         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6622         from...
6623         (rank_one_type): ... this.
6624
6625 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6626
6627         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6628         from...
6629         (rank_one_type): ... this.
6630
6631 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6632
6633         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6634         from...
6635         (rank_one_type): ... this.
6636
6637 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6638
6639         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6640         from...
6641         (rank_one_type): ... this.
6642
6643 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6644
6645         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6646         from...
6647         (rank_one_type): ... this.
6648
6649 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6650
6651         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6652         inferior-events' shows the example events.
6653
6654 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6655
6656         Support styling on native MS-Windows console
6657
6658         PR/24315
6659         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6660         on MS-Windows if $TERM is not defined.
6661
6662         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6663
6664         * posix-hdep.c (gdb_console_fputs):
6665         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6666         functions.
6667         * ui-file.h (gdb_console_fputs): Add prototype.
6668
6669         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6670         back to fputs only if the former returns zero.
6671
6672 2019-03-07  Tom Tromey  <tom@tromey.com>
6673
6674         * symmisc.c (print_symbol_bcache_statistics): Update.
6675         (print_objfile_statistics): Update.
6676         * symfile.c (allocate_symtab): Update.
6677         * stabsread.c: Don't include bcache.h.
6678         * psymtab.h (struct psymbol_bcache): Don't declare.
6679         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6680         (psymbol_bcache_init, psymbol_bcache_free)
6681         (psymbol_bcache_get_bcache): Don't declare.
6682         * psymtab.c (struct psymbol_bcache): Remove.
6683         (psymtab_storage::psymtab_storage): Update.
6684         (psymtab_storage::~psymtab_storage): Update.
6685         (psymbol_bcache_init, psymbol_bcache_free)
6686         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6687         (add_psymbol_to_bcache): Update.
6688         (allocate_psymtab): Update.
6689         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6690         macro_cache>: No longer pointers.
6691         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6692         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6693         * macrotab.c (macro_bcache): Update.
6694         * macroexp.c: Don't include bcache.h.
6695         * gdbtypes.c (check_types_worklist): Update.
6696         (types_deeply_equal): Remove TRY/CATCH.  Update.
6697         * elfread.c (elf_symtab_read): Update.
6698         * dwarf2read.c: Don't include bcache.h.
6699         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6700         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6701         (print_bcache_statistics, bcache_memory_used): Don't declare.
6702         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6703         methods.  Rename all data members.
6704         * bcache.c (struct bcache): Move to bcache.h.
6705         (bcache::expand_hash_table): Rename from expand_hash_table.
6706         (bcache): Remove.
6707         (bcache::insert): Rename from bcache_full.
6708         (bcache::compare): Rename from bcache_compare.
6709         (bcache_xmalloc): Remove.
6710         (bcache::~bcache): Rename from bcache_xfree.
6711         (bcache::print_statistics): Rename from print_bcache_statistics.
6712         (bcache::memory_used): Rename from bcache_memory_used.
6713
6714 2019-03-07  Pedro Alves  <palves@redhat.com>
6715
6716         * infrun.c (normal_stop): Also check for
6717         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6718
6719 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6720
6721         * f-lang.c (value_from_host_double): Moved to...
6722         * value.c (value_from_host_double): ...here.
6723         * value.h (value_from_host_double): Declare.
6724         * guile/scm-math.c (vlscm_convert_typed_number): Use
6725         value_from_host_double.
6726         (vlscm_convert_number): Likewise.
6727         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6728         * python/py-value.c (convert_value_from_python): Likewise.
6729
6730 2019-03-06  Tom Tromey  <tom@tromey.com>
6731
6732         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6733
6734 2019-03-06  Tom Tromey  <tom@tromey.com>
6735
6736         * utils.h (free_current_contents): Don't declare.
6737         * utils.c (free_current_contents): Remove.
6738
6739 2019-03-06  Tom Tromey  <tom@tromey.com>
6740
6741         * top.c (quit_force): Update.
6742         * main.c (captured_command_loop): Update.
6743         * common/new-op.c (operator new): Update.
6744         * common/common-exceptions.c (struct catcher)
6745         <save_cleanup_chain>: Remove member.
6746         (exceptions_state_mc_init): Update.
6747         (exception_try_scope_entry): Return nullptr.
6748         (exception_try_scope_exit, exception_rethrow)
6749         (throw_exception_sjlj, throw_exception_cxx): Update.
6750         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6751         (all_cleanups, do_cleanups, discard_cleanups)
6752         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6753         (restore_cleanups, restore_final_cleanups): Don't declare.
6754         (do_final_cleanups): Remove parameter.
6755         * common/cleanups.c (cleanup_chain, make_cleanup)
6756         (make_cleanup_dtor, all_cleanups, do_cleanups)
6757         (discard_my_cleanups, discard_cleanups)
6758         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6759         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6760         (null_cleanup): Remove.
6761         (do_final_cleanups): Remove parameter.
6762
6763 2019-03-06  Tom Tromey  <tom@tromey.com>
6764
6765         * remote.c (remote_target::remote_parse_stop_reply): Use
6766         unique_xmalloc_ptr.
6767
6768 2019-03-06  Tom Tromey  <tom@tromey.com>
6769
6770         * stabsread.c (struct stabs_field_info): Rename from field_info.
6771         <list, fnlist>: Add initializers.
6772         <obstack>: New member.
6773         (read_member_functions, read_struct_fields, read_baseclasses):
6774         Allocate on obstack.  Don't use cleanups.
6775         (read_one_struct_field, read_member_functions, read_struct_fields)
6776         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6777         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6778         (read_struct_type): Update.
6779
6780 2019-03-06  Tom Tromey  <tom@tromey.com>
6781
6782         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6783         * common/filestuff.h (make_cleanup_close): Don't declare.
6784         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6785         Remove.
6786
6787 2019-03-06  Tom Tromey  <tom@tromey.com>
6788
6789         * solib-aix.c: Use make_scope_exit.
6790
6791 2019-03-06  Tom Tromey  <tom@tromey.com>
6792
6793         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6794         Use make_scope_exit.
6795
6796 2019-03-06  Tom Tromey  <tom@tromey.com>
6797
6798         * solib-svr4.c (disable_probes_interface): Remove parameter.
6799         (svr4_handle_solib_event): Use make_scope_exit.
6800
6801 2019-03-06  Tom Tromey  <tom@tromey.com>
6802
6803         * remote.c (struct stop_reply_deleter): Remove.
6804         (stop_reply_up): Update.
6805         (struct stop_reply): Derive from notif_event.  Don't typedef.
6806         <regcache>: Now a std::vector.
6807         (stop_reply_xfree): Remove.
6808         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6809         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6810         (remote_target::discard_pending_stop_replies): Use delete.
6811         (remote_target::remote_parse_stop_reply): Update.
6812         (remote_target::process_stop_reply): Update.
6813         * remote-notif.h (struct notif_event): Add virtual destructor.
6814         Remove "dtr" member.
6815         (struct notif_client) <alloc_event>: Return a unique_ptr.
6816         (notif_event_xfree): Don't declare.
6817         (notif_event_up): New typedef.
6818         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6819         (notif_event_xfree, do_notif_event_xfree): Remove.
6820         (remote_notif_state_xfree): Update.
6821
6822 2019-03-06  Tom Tromey  <tom@tromey.com>
6823
6824         * infrun.c (displaced_step_clear_cleanup): Now a
6825         forward_scope_exit type.
6826         (displaced_step_prepare_throw): Update.
6827         (displaced_step_fixup): Update.
6828
6829 2019-03-06  Tom Tromey  <tom@tromey.com>
6830
6831         * inferior.h (class inferior): Update comment.
6832         * gdbthread.h (class thread_info): Update comment.
6833
6834 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6835             Tom Tromey  <tom@tromey.com>
6836
6837         * stabsread.h (struct stab_section_list): Remove.
6838         (coffstab_build_psymtabs): Update.
6839         * dbxread.c (symbuf_sections): Now a std::vector.
6840         (sect_idx): New global.
6841         (fill_symbuf): Update.
6842         (coffstab_build_psymtabs): Change type of stabsects parameter.
6843         Update.
6844         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6845         std::vector.
6846         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6847         (coff_locate_sections): Update.
6848         (coff_symfile_read): Remove cleanups.  Update.
6849         (init_stringtab): Add storage parameter.
6850         (free_stringtab, free_stringtab_cleanup): Remove.
6851         (init_lineno): Add storage parameter.
6852         (free_linetab, free_linetab_cleanup): Remove.
6853
6854 2019-03-06  Pedro Alves  <palves@redhat.com>
6855
6856         * linux-fork.c (fork_info::clobber_regs): Delete.
6857         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6858         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6859         comment.  Adjust.
6860         (scoped_switch_fork_info::scoped_switch_fork_info)
6861         (checkpoint_command, linux_fork_context): Adjust
6862         fork_save_infrun_state calls.
6863
6864 2019-03-06  Pedro Alves  <palves@redhat.com>
6865
6866         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6867         (inf_has_multiple_threads): Return 'bool' and rewrite using
6868         inferior_info::threads().
6869
6870 2019-03-06  Pedro Alves  <palves@redhat.com>
6871
6872         * linux-fork.c: Include <list>.
6873         (fork_list): Now a std::list instance.
6874         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6875         (forks_exist_p, find_last_fork): Adjust.
6876         (new_fork): Delete.
6877         (one_fork_p): New.
6878         (add_fork): Adjust.
6879         (free_fork): Delete, folded into fork_info::~fork_info().
6880         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6881         Adjust.
6882         (init_fork_list): Delete.
6883         (linux_fork_killall, linux_fork_mourn_inferior)
6884         (linux_fork_detach, info_checkpoints_command): Adjust.
6885         (_initialize_linux_fork): No longer call init_fork_list.
6886
6887 2019-03-06  Pedro Alves  <palves@redhat.com>
6888
6889         * linux-fork.c (new_fork): New, split out of ...
6890         (add_fork): ... this.  Return void.  Move "first fork" special
6891         case from here, to ...
6892         (checkpoint_command): ... here.
6893         * linux-linux.h (add_fork): Return void.
6894
6895 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6896
6897         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6898
6899 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6900             Chris January  <chris.january@arm.com>
6901             David Lecomber  <david.lecomber@arm.com>
6902
6903         * f-exp.y: New token, UNOP_INTRINSIC.
6904         (exp): New pattern using UNOP_INTRINSIC token.
6905         (f77_keywords): Add 'abs' keyword.
6906         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6907         (value_from_host_double): New function.
6908         (evaluate_subexp_f): Support UNOP_ABS.
6909
6910 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6911
6912         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6913         types.
6914
6915 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6916
6917         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6918         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6919         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6920
6921 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6922
6923         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6924
6925 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6926             Chris January  <chris.january@arm.com>
6927
6928         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6929         * f-exp.y: Define 'KIND' token.
6930         (exp): New pattern for KIND expressions.
6931         (ptype): Handle types with a kind extension.
6932         (direct_abs_decl): Extend to spot kind extensions.
6933         (f77_keywords): Add 'kind' to the list.
6934         (push_kind_type): New function.
6935         (convert_to_kind_type): New function.
6936         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6937         * parse.c (operator_length_standard): Likewise.
6938         * parser-defs.h (enum type_pieces): Add tp_kind.
6939         * std-operator.def: Add UNOP_KIND.
6940
6941 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6942
6943         * f-exp.y (f_parse): Set yydebug.
6944
6945 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6946
6947         * f-lang.c (evaluate_subexp_f): New function.
6948         (exp_descriptor_f): New global.
6949         (f_language_defn): Use exp_descriptor_f instead of
6950         exp_descriptor_standard.
6951
6952 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6953
6954         * f-exp.y (struct token): Add comments.
6955         (dot_ops): Remove uppercase versions and the end marker.
6956         (f77_keywords): Likewise.
6957         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6958         entries in the dot_ops array are case insensitive, and use
6959         strncasecmp to compare strings.  Also some whitespace cleanup in
6960         this area.  Similar for the f77_keywords array, except entries in
6961         this list might be case sensitive.
6962
6963 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6964
6965         * f-exp.y (struct f77_boolean_val): Add comments.
6966         (boolean_values): Remove uppercase versions, and end marker.
6967         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6968         and use strncasecmp to achieve case insensitivity.  Additionally,
6969         perform whitespace cleanup around this code.
6970
6971 2019-03-06  Tom Tromey  <tromey@adacore.com>
6972
6973         * remote-sim.c (gdbsim_target_open): Use result of
6974         gdb_argv::release.
6975
6976 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6977         Dirk Schubert  <dirk.schubert@arm.com>
6978         Chris January  <chris.january@arm.com>
6979
6980         * eval.c (evaluate_subexp_standard): Call Fortran argument
6981         wrapping logic.
6982         * f-lang.c (struct value): A value which can be passed into a
6983         Fortran function call.
6984         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6985         where appropriate.
6986         (struct type): Value ready for a Fortran function call.
6987         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6988         is needed.
6989         * f-lang.h (fortran_argument_convert): Declaration.
6990         (fortran_preserve_arg_pointer): Declaration.
6991         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6992
6993 2019-03-05  Tom Tromey  <tromey@adacore.com>
6994
6995         * python/py-prettyprint.c (print_string_repr): Remove #if.
6996         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6997
6998 2019-03-05  Tom Tromey  <tromey@adacore.com>
6999
7000         * target.c (the_dummy_target): Move later.  Change type to
7001         "dummy_target".
7002         (initialize_targets): Don't initialize the_dummy_target.
7003
7004 2019-03-05  Tom Tromey  <tromey@adacore.com>
7005
7006         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7007         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7008
7009 2019-03-05  Tom Tromey  <tromey@adacore.com>
7010
7011         * windows-nat.c (windows_nat_target::attach)
7012         (windows_nat_target::detach): Don't call gdb_flush.
7013         * valprint.c (generic_val_print, val_print, val_print_string):
7014         Don't call gdb_flush.
7015         * utils.c (defaulted_query): Don't call gdb_flush.
7016         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7017         * target.c (target_announce_detach): Don't call gdb_flush.
7018         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7019         * remote.c (extended_remote_target::attach): Don't call
7020         gdb_flush.
7021         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7022         * printcmd.c (do_examine): Don't call gdb_flush.
7023         (info_display_command): Don't call gdb_flush.
7024         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7025         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7026         * memattr.c (info_mem_command): Don't call gdb_flush.
7027         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7028         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7029         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7030         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7031         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7032         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7033         (gnu_nat_target::detach): Don't call gdb_flush.
7034         * f-valprint.c (f_val_print): Don't call gdb_flush.
7035         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7036         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7037         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7038         gdb_flush.
7039         * c-valprint.c (c_val_print): Don't call gdb_flush.
7040         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7041
7042 2019-03-05  Tom Tromey  <tromey@adacore.com>
7043
7044         * varobj.c (update_dynamic_varobj_children): Update.
7045         (install_default_visualizer): Use reset, not release.
7046         * value.c (set_internalvar): Update.
7047         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7048         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7049         ATTRIBUTE_UNUSED_RESULT.
7050
7051 2019-03-05  Tom Tromey  <tromey@adacore.com>
7052
7053         * remote.c (class scoped_remote_fd) <release>: Add
7054         ATTRIBUTE_UNUSED_RESULT.
7055
7056 2019-03-05  Tom Tromey  <tromey@adacore.com>
7057
7058         * macroexp.c (struct macro_buffer) <release>: Add
7059         ATTRIBUTE_UNUSED_RESULT.
7060
7061 2019-03-05  Tom Tromey  <tromey@adacore.com>
7062
7063         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7064         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7065         ATTRIBUTE_UNUSED_RESULT.
7066
7067 2019-03-05  Tom Tromey  <tromey@adacore.com>
7068
7069         * common/scoped_fd.h (class scoped_fd) <release>: Add
7070         ATTRIBUTE_UNUSED_RESULT.
7071
7072 2019-03-05  Tom Tromey  <tromey@adacore.com>
7073
7074         * parser-defs.h (struct parser_state) <release>: Add
7075         ATTRIBUTE_UNUSED_RESULT.
7076
7077 2019-03-05  Tom Tromey  <tromey@adacore.com>
7078
7079         * utils.h (class gdb_argv) <release>: Add
7080         ATTRIBUTE_UNUSED_RESULT.
7081         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7082
7083 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7084
7085         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7086         for-loop range, to avoid compiler warnings.
7087
7088         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7089         avoid compiler warnings about unused variables.
7090
7091         * NEWS: Mention end of support for native debugging on MS-Windows
7092         before XP.
7093
7094         PR gdb/24292
7095         * common/netstuff.c:
7096         * gdbserver/gdbreplay.c
7097         * gdbserver/remote-utils.c:
7098         * ser-tcp.c:
7099         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7100         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7101         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7102         'getaddrinfo' and 'freeaddrinfo' were not available before
7103         Windows XP, and mingw.org's MinGW headers by default define
7104         _WIN32_WINNT to 0x500.
7105
7106 2019-03-01  Gary Benson <gbenson@redhat.com>
7107
7108         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7109
7110 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7111             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7112
7113         PR gdb/8527
7114         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7115         set_sigint_trap, clear_sigint_trap.
7116
7117 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7118
7119         * target.c (target_detach): Clear the regcache and the
7120         frame cache.
7121
7122 2019-02-27  Pedro Alves  <palves@redhat.com>
7123
7124         * utils.c (set_screen_size): When we cap the height/width sizes,
7125         tweak the corresponding command variable to show "unlimited":
7126
7127 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7128             Pedro Alves  <palves@redhat.com>
7129
7130         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7131         before calling rl_set_screen_size.
7132
7133 2019-02-27  Tom Tromey  <tromey@adacore.com>
7134
7135         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7136         define.
7137         * python/py-value.c: Remove Python 2.4 workaround.
7138         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7139         workaround.
7140         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7141         Python 2.4 workaround.
7142         * python/python-internal.h: Remove Python 2.4 comment.
7143         (Py_ssize_t): Don't define.
7144         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7145         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7146         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7147         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7148         * python/python.c (do_start_initialization): Remove Python 2.4
7149         workaround.
7150         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7151         (print_children): Remove Python 2.4 workaround.
7152         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7153         workaround.
7154         (CHARBUFFERPROC_NAME): Remove.
7155         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7156         Python 2.4 workaround.
7157
7158 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7159
7160         * NEWS: Note minimum Python version.
7161
7162 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7163
7164         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7165         code from these functions.  Remove corresponding ifdefs.  Use
7166         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7167         Remove gotos and target of gotos.
7168         (infpy_search_memory): Likewise.
7169
7170 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7171
7172         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7173         (hppa_gdbarch_init): Don't register deleted functions with
7174         gdbarch.
7175
7176 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7177
7178         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7179         (h8300_unwind_sp): Delete.
7180         (h8300_dummy_id): Delete.
7181         (h8300_gdbarch_init): Don't register deleted functions with
7182         gdbarch.
7183
7184 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7185
7186         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7187         (ft32_unwind_pc): Delete.
7188         (ft32_unwind_sp): Delete.
7189         (ft32_gdbarch_init): Don't register deleted functions with
7190         gdbarch.
7191
7192 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7193
7194         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7195         (frv_unwind_pc): Delete.
7196         (frv_unwind_sp): Delete.
7197         (frv_gdbarch_init): Don't register deleted functions with
7198         gdbarch.
7199
7200 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7201
7202         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7203         (riscv_unwind_pc): Delete.
7204         (riscv_unwind_sp): Delete.
7205         (riscv_gdbarch_init): Don't register deleted functions with
7206         gdbarch.
7207
7208 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7209
7210         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7211         (csky_unwind_pc): Delete.
7212         (csky_unwind_sp): Delete.
7213         (csky_gdbarch_init): Don't register deleted functions with
7214         gdbarch.
7215
7216 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7217
7218         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7219         (cris_unwind_pc): Delete.
7220         (cris_unwind_sp): Delete.
7221         (cris_gdbarch_init): Don't register deleted functions with
7222         gdbarch.
7223
7224 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7225
7226         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7227         (bfin_unwind_pc): Delete.
7228         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7229
7230 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7231
7232         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7233         (arm_unwind_pc): Delete.
7234         (arm_unwind_sp): Delete.
7235         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7236
7237 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7238
7239         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7240         (arc_unwind_pc): Delete.
7241         (arc_unwind_sp): Delete.
7242         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7243
7244 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7245
7246         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7247         (alpha_unwind_pc): Delete.
7248         (alpha_gdbarch_init): Don't register deleted functions with
7249         gdbarch.
7250
7251 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7252
7253         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7254         (aarch64_unwind_pc): Delete.
7255         (aarch64_unwind_sp): Delete.
7256         (aarch64_gdbarch_init): Don't register deleted functions with
7257         gdbarch.
7258
7259 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7260
7261         * gdbtypes.c (type_align): Don't consider static members when
7262         computing structure alignment.
7263
7264 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7265
7266         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7267         return 0 for other types.
7268         * arch-utils.c (default_type_align): Always return 0.
7269         * gdbarch.h: Regenerate.
7270         * gdbarch.sh (type_align): Extend comment.
7271         * gdbtypes.c (type_align): Add additional comments, always call
7272         gdbarch_type_align before applying the default rules.
7273         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7274         generic code will then apply a suitable default.
7275         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7276         types, return 0 for other types.
7277
7278 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7279
7280         * NEWS: Create a new section for the next release branch.
7281         Rename the section of the current branch, now that it has
7282         been cut.
7283
7284 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7285
7286         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7287         * version.in: Bump version to 8.3.50.DATE-git.
7288
7289 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7290
7291         * aix-thread.c (ptid_cmp): Remove unused variable.
7292         (get_signaled_thread): Likewise.
7293         (store_regs_user_thread): Likewise.
7294         (store_regs_kernel_thread): Likewise.
7295         (fetch_regs_kernel_thread): Remove shadowed variable.
7296
7297 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7298
7299         * features/riscv/32bit-cpu.xml: Add register numbers.
7300         * features/riscv/32bit-fpu.c: Regenerate.
7301         * features/riscv/32bit-fpu.xml: Add register numbers.
7302         * features/riscv/64bit-cpu.xml: Add register numbers.
7303         * features/riscv/64bit-fpu.c: Regenerate.
7304         * features/riscv/64bit-fpu.xml: Add register numbers.
7305
7306 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7307
7308         * NEWS: Mention two argument form of gdb.Value constructor.
7309         * python/py-value.c (convert_buffer_and_type_to_value): New
7310         function.
7311         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7312         Add support for handling an optional second argument.  Call
7313         convert_buffer_and_type_to_value as appropriate.
7314         * python/python-internal.h (Py_buffer_deleter): New struct.
7315         (Py_buffer_up): New typedef.
7316
7317 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7318
7319         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7320         instead of releasing ownership.
7321
7322 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7323
7324         * dwarf2read.c (open_and_init_dwp_file): Call
7325         elf_numsections instead of bfd_count_sections to initialize
7326         dwp_file->num_sections.
7327
7328 2019-02-25  Tom Tromey  <tromey@adacore.com>
7329
7330         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7331
7332 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7333
7334         * gcore.in: Add '--readnever' option when invoking GDB.
7335
7336 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7337
7338         * MAINTAINERS: Update my email address.
7339
7340 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7341
7342         * build-id.c (build_id_to_debug_bfd_1): New function.
7343         (build_id_to_debug_bfd): Look for separate debug file in
7344         sysroot.
7345
7346 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7347
7348         * gdbarch.sh: Update the copyright year range that is placed into
7349         generated files.
7350
7351 2019-02-22  Keith Seitz  <keiths@redhat.com>
7352
7353         PR symtab/23853
7354         * linespec.c (create_sals_line_offset): Search for the default
7355         symtab's filename instead of its fullname.
7356
7357 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7358
7359         * NEWS: Update style defaults.
7360
7361 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7362
7363         * main.c (captured_main_1): Disable styling in batch mode.
7364
7365 2019-02-20  Tom Tromey  <tom@tromey.com>
7366
7367         * symtab.c (symtab_symbol_info): Fix typos.
7368
7369 2019-02-20  Tom Tromey  <tromey@adacore.com>
7370
7371         * findcmd.c (_initialize_mem_search): Use upper case for
7372         metasyntactic variables.
7373
7374 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7375
7376         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7377         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7378
7379 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7380
7381         * top.h (source_file_name): Change to std::string.
7382         * top.c (source_file_name): Likewise.
7383         (command_line_input): Adjust.
7384         * cli/cli-script.c (script_from_file): Adjust.
7385
7386 2019-02-19  Tom Tromey  <tromey@adacore.com>
7387
7388         * ravenscar-thread.c
7389         (ravenscar_thread_target::update_thread_list): Don't call
7390         ada_build_task_list.
7391         * ada-lang.h (ada_build_task_list): Don't declare.
7392         * ada-tasks.c (struct ada_tasks_inferior_data)
7393         <task_list_valid_p>: Now bool.
7394         (read_known_tasks, ada_task_list_changed)
7395         (ada_tasks_invalidate_inferior_data): Update.
7396         (read_known_tasks_array): Return bool.
7397         (read_known_tasks_list): Likewise.
7398         (read_known_tasks): Return void.
7399         (ada_build_task_list): Now static.
7400
7401 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7402
7403         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7404         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7405
7406 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7407
7408         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7409         variant for ada_tasks_pspace_data_handle and
7410         ada_tasks_inferior_data_handle.
7411         (ada_tasks_pspace_data_cleanup): New function.
7412         (ada_tasks_inferior_data_cleanup): New function.
7413
7414 2019-02-17  Tom Tromey  <tom@tromey.com>
7415
7416         * macrotab.h (macro_source_fullname): Return a std::string.
7417         * macrotab.c (macro_include, check_for_redefinition)
7418         (macro_undef, macro_lookup_definition, foreach_macro)
7419         (foreach_macro_in_scope): Update.
7420         (macro_source_fullname): Return a std::string.
7421         * macrocmd.c (show_pp_source_pos): Update.
7422
7423 2019-02-17  Tom Tromey  <tom@tromey.com>
7424
7425         * macrocmd.c (show_pp_source_pos): Style the file names.
7426
7427 2019-02-17  Tom Tromey  <tom@tromey.com>
7428
7429         PR tui/24197:
7430         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7431
7432 2019-02-17  Tom Tromey  <tom@tromey.com>
7433
7434         * ada-lang.c (user_select_syms): Use filtered printing.
7435         * utils.c (wrap_style): New global.
7436         (desired_style): Remove.
7437         (emit_style_escape): Add stream parameter.
7438         (set_output_style, reset_terminal_style, prompt_for_continue):
7439         Update.
7440         (flush_wrap_buffer): Only flush gdb_stdout.
7441         (wrap_here): Set wrap_style.
7442         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7443         treat escape sequences as a character.  Change when wrap buffer is
7444         flushed.
7445         (fputs_styled): Do not set the output style when the default is
7446         requested.
7447         * ui-style.h (struct ui_file_style) <is_default>: New method.
7448         * source.c (print_source_lines_base): Emit escape sequences in one
7449         piece.
7450
7451 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7452
7453         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7454         integers and enumeration types.
7455
7456 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7457
7458         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7459         instead of lookup_symbol_in_language
7460         (do_exact_match): New function.
7461         (ada_get_symbol_name_matcher): Return do_exact_match when
7462         doing a verbatim match.
7463
7464 2019-02-15  Tom Tromey  <tromey@adacore.com>
7465
7466         * ravenscar-thread.c (ravenscar_thread_target::resume)
7467         (ravenscar_thread_target::wait): Special case wildcard requests.
7468
7469 2019-02-15  Tom Tromey  <tromey@adacore.com>
7470
7471         * ravenscar-thread.c (base_ptid): Remove.
7472         (struct ravenscar_thread_target) <close>: New method.
7473         <m_base_ptid>: New member.
7474         <update_inferior_ptid, active_task, task_is_currently_active,
7475         runtime_initialized>: Declare methods.
7476         <ravenscar_thread_target>: Add constructor.
7477         (ravenscar_thread_target::task_is_currently_active)
7478         (ravenscar_thread_target::update_inferior_ptid)
7479         (ravenscar_runtime_initialized): Rename.  Now methods.
7480         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7481         (ravenscar_thread_target::update_thread_list): Update.
7482         (ravenscar_thread_target::active_task): Now method.
7483         (ravenscar_thread_target::store_registers)
7484         (ravenscar_thread_target::prepare_to_store)
7485         (ravenscar_thread_target::prepare_to_store)
7486         (ravenscar_thread_target::mourn_inferior): Update.
7487         (ravenscar_inferior_created): Use "new" to create target.
7488         (ravenscar_thread_target::get_ada_task_ptid): Update.
7489         (_initialize_ravenscar): Don't initialize base_ptid.
7490         (ravenscar_ops): Remove global.
7491
7492 2019-02-15  Tom Tromey  <tromey@adacore.com>
7493
7494         * target.h (push_target): Declare new overload.
7495         * target.c (push_target): New overload, taking an rvalue reference.
7496         * remote.c (remote_target::open_1): Use push_target overload.
7497         * corelow.c (core_target_open): Use push_target overload.
7498
7499 2019-02-15  Tom Tromey  <tromey@adacore.com>
7500
7501         * ravenscar-thread.c (is_ravenscar_task)
7502         (ravenscar_task_is_currently_active): Return bool.
7503         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7504         (_initialize_ravenscar): Remove "(void)".
7505         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7506         Return bool.
7507
7508 2019-02-15  Tom Tromey  <tromey@adacore.com>
7509
7510         * ravenscar-thread.c (ravenscar_runtime_initializer)
7511         (has_ravenscar_runtime, get_running_thread_id)
7512         (ravenscar_thread_target::resume): Fix indentation.
7513
7514 2019-02-15  Tom Tromey  <tromey@adacore.com>
7515
7516         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7517         from ravenscar_arch_ops.
7518         (sparc_ravenscar_ops::fetch_registers)
7519         (sparc_ravenscar_ops::store_registers): Now methods.
7520         (sparc_ravenscar_prepare_to_store): Remove.
7521         (sparc_ravenscar_ops): Redefine.
7522         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7523         methods and destructor.  Remove members.
7524         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7525         (ravenscar_thread_target::store_registers)
7526         (ravenscar_thread_target::prepare_to_store): Update.
7527         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7528         Remove.
7529         (struct ppc_ravenscar_powerpc_ops): Derive from
7530         ravenscar_arch_ops.
7531         (ppc_ravenscar_powerpc_ops::fetch_registers)
7532         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7533         (ppc_ravenscar_powerpc_ops): Redefine.
7534         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7535         (ppc_ravenscar_e500_ops::fetch_registers)
7536         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7537         (ppc_ravenscar_e500_ops): Redefine.
7538         * aarch64-ravenscar-thread.c
7539         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7540         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7541         (aarch64_ravenscar_fetch_registers)
7542         (aarch64_ravenscar_store_registers): Now methods.
7543         (aarch64_ravenscar_ops): Redefine.
7544
7545 2019-02-15  Tom Tromey  <tromey@adacore.com>
7546
7547         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7548         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7549         (ravenscar_thread_target::stopped_by_watchpoint)
7550         (ravenscar_thread_target::stopped_data_address)
7551         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7552
7553 2019-02-15  Tom Tromey  <tromey@adacore.com>
7554
7555         * ravenscar-thread.c: Fix some typos.
7556
7557 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7558             Tom Tromey  <tromey@adacore.com>
7559
7560         * ada-lang.c (ada_exception_sal): Change addr_string to a
7561         std::string.
7562         (create_ada_exception_catchpoint): Update.
7563
7564 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7565             Tom Tromey  <tromey@adacore.com>
7566
7567         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7568         (bp_location_ops): Remove.
7569         (base_breakpoint_allocate_location): Update.
7570         (free_bp_location): Update.
7571         * ada-lang.c (class ada_catchpoint_location)
7572         <ada_catchpoint_location>: Remove ops parameter.
7573         (ada_catchpoint_location_dtor): Remove.
7574         (ada_catchpoint_location_ops): Remove.
7575         (allocate_location_exception): Update.
7576         * breakpoint.h (struct bp_location_ops): Remove.
7577         (class bp_location) <bp_location>: Remove bp_location_ops
7578         parameter.
7579         <~bp_location>: Add destructor.
7580         <ops>: Remove.
7581
7582 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7583             Pedro Alves  <palves@redhat.com>
7584
7585         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7586         'PATH_MAX'.
7587
7588 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7589             Samuel Thibault  <samuel.thibault@gnu.org>
7590             Thomas Schwinge  <thomas@codesourcery.com>
7591
7592         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7593         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7594
7595 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7596
7597         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7598         (check_empty): Use "const char *".
7599
7600         * gnu-nat.c (gnu_nat_target::detach): Instead of
7601         'detach_inferior (pid)' call
7602         'detach_inferior (find_inferior_pid (pid))'.
7603
7604         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7605         'nat/fork-inferior.o'.
7606         * gnu-nat.c: #include "nat/fork-inferior.h".
7607
7608         * gnu-nat.c (gnu_nat_target::detach): Instead of
7609         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7610         * gnu-nat.h: #include "inf-child.h".
7611         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7612         'i386_gnu_nat_target::fetch_registers'.
7613         (gnu_store_registers): Rename/move to
7614         'i386_gnu_nat_target::store_registers'.
7615
7616         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7617         * gnu-nat.h (mach_thread_info): New function.
7618         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7619
7620         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7621
7622 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7623
7624         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7625
7626 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7627
7628         * windows-nat.c (windows_add_thread): Add new parameter
7629         "main_thread_p" with default value set to false.  Update
7630         function documentation as well as all callers.
7631         (windows_delete_thread): Likewise.
7632         (fake_create_process): Update call to windows_add_thread.
7633         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7634         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7635         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7636         call to windows_delete_thread.
7637
7638 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7639
7640         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7641
7642 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7643
7644         * symfile.c (find_separate_debug_file): Use canonical path of
7645         sysroot with child_path instead of gdb_sysroot if it is valid.
7646
7647 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7648
7649         * symfile.c (find_separate_debug_file): Use child_path to
7650         determine if an object file is under a sysroot.
7651
7652 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7653
7654         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7655         unittests/child-path-selftests.c.
7656         * common/pathstuff.c (child_path): New function.
7657         * common/pathstuff.h (child_path): New prototype.
7658         * unittests/child-path-selftests.c: New file.
7659
7660 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7661
7662         * symfile.c (find_separate_debug_file): Look for separate debug
7663         files in debug directories under the sysroot.
7664
7665 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7666
7667         * symtab.h (struct minimal_symbol data_p): New const method.
7668         (struct minimal_symbol text_p): Likewise.
7669         * symtab.c (output_source_filename): Use file name style
7670         to print file name.
7671         (print_symbol_info): Likewise.
7672         (print_msymbol_info): Use address style to print addresses.
7673         Use function name style to print executable text symbols.
7674         (expand_symtab_containing_pc): Use data_p.
7675         (find_pc_sect_compunit_symtab): Likewise.
7676
7677 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7678
7679         * breakpoint.c (describe_other_breakpoints): Use address style
7680         to print addresses.
7681         (say_where): Likewise.
7682
7683 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7684
7685         * ada-typeprint.c (print_func_type): Print function name
7686         style to print function name.
7687         * c-typeprint.c (c_print_type_1): Likewise.
7688
7689 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7690
7691         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7692         for execve.
7693
7694 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7695
7696         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7697         type_stack.
7698
7699 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7700
7701         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7702         TYPE_CODE_REF types.
7703
7704 2019-02-08  Jim Wilson  <jimw@sifive.com>
7705
7706         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7707         (riscv_linux_fregset): New.
7708         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7709
7710 2019-02-07  Tom Tromey  <tom@tromey.com>
7711
7712         * thread.c (thread_cancel_execution_command): Update.
7713         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7714         methods.
7715         (struct thread_fsm_ops): Remove.
7716         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7717         (thread_fsm_should_stop, thread_fsm_return_value)
7718         (thread_fsm_set_finished, thread_fsm_finished_p)
7719         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7720         Don't declare.
7721         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7722         * infrun.c (clear_proceed_status_thread)
7723         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7724         (print_stop_event): Update.
7725         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7726         Add constructor.
7727         (step_command_fsm_ops): Remove.
7728         (new_step_command_fsm): Remove.
7729         (step_1): Update.
7730         (step_command_fsm::should_stop): Rename from
7731         step_command_fsm_should_stop.
7732         (step_command_fsm::clean_up): Rename from
7733         step_command_fsm_clean_up.
7734         (step_command_fsm::do_async_reply_reason): Rename from
7735         step_command_fsm_async_reply_reason.
7736         (struct until_next_fsm): Inherit from thread_fsm.  Add
7737         constructor.
7738         (until_next_fsm_ops): Remove.
7739         (new_until_next_fsm): Remove.
7740         (until_next_fsm::should_stop): Rename from
7741         until_next_fsm_should_stop.
7742         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7743         (until_next_fsm::do_async_reply_reason): Rename from
7744         until_next_fsm_async_reply_reason.
7745         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7746         constructor.  Change type of breakpoint.
7747         (finish_command_fsm_ops): Remove.
7748         (new_finish_command_fsm): Remove.
7749         (finish_command_fsm::should_stop): Rename from
7750         finish_command_fsm_should_stop.
7751         (finish_command_fsm::clean_up): Rename from
7752         finish_command_fsm_clean_up.
7753         (finish_command_fsm::return_value): Rename from
7754         finish_command_fsm_return_value.
7755         (finish_command_fsm::do_async_reply_reason): Rename from
7756         finish_command_fsm_async_reply_reason.
7757         (finish_command): Update.
7758         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7759         Add constructor.
7760         (call_thread_fsm_ops): Remove.
7761         (call_thread_fsm::call_thread_fsm): Rename from
7762         new_call_thread_fsm.
7763         (call_thread_fsm::should_stop): Rename from
7764         call_thread_fsm_should_stop.
7765         (call_thread_fsm::should_notify_stop): Rename from
7766         call_thread_fsm_should_notify_stop.
7767         (run_inferior_call, call_function_by_hand_dummy): Update.
7768         * cli/cli-interp.c (should_print_stop_to_console): Update.
7769         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7770         Add constructor.  Change type of location_breakpoint,
7771         caller_breakpoint.
7772         (until_break_fsm_ops): Remove.
7773         (new_until_break_fsm): Remove.
7774         (until_break_fsm::should_stop): Rename from
7775         until_break_fsm_should_stop.
7776         (until_break_fsm::clean_up): Rename from
7777         until_break_fsm_clean_up.
7778         (until_break_fsm::do_async_reply_reason): Rename from
7779         until_break_fsm_async_reply_reason.
7780         (until_break_command): Update.
7781         * thread-fsm.c: Remove.
7782         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7783
7784 2019-02-07  Tom Tromey  <tom@tromey.com>
7785
7786         * yy-remap.h: Add include guard.
7787         * xtensa-tdep.h: Add include guard.
7788         * xcoffread.h: Rename include guard.
7789         * varobj-iter.h: Add include guard.
7790         * tui/tui.h: Rename include guard.
7791         * tui/tui-winsource.h: Rename include guard.
7792         * tui/tui-wingeneral.h: Rename include guard.
7793         * tui/tui-windata.h: Rename include guard.
7794         * tui/tui-win.h: Rename include guard.
7795         * tui/tui-stack.h: Rename include guard.
7796         * tui/tui-source.h: Rename include guard.
7797         * tui/tui-regs.h: Rename include guard.
7798         * tui/tui-out.h: Rename include guard.
7799         * tui/tui-layout.h: Rename include guard.
7800         * tui/tui-io.h: Rename include guard.
7801         * tui/tui-hooks.h: Rename include guard.
7802         * tui/tui-file.h: Rename include guard.
7803         * tui/tui-disasm.h: Rename include guard.
7804         * tui/tui-data.h: Rename include guard.
7805         * tui/tui-command.h: Rename include guard.
7806         * tic6x-tdep.h: Add include guard.
7807         * target/waitstatus.h: Rename include guard.
7808         * target/wait.h: Rename include guard.
7809         * target/target.h: Rename include guard.
7810         * target/resume.h: Rename include guard.
7811         * target-float.h: Rename include guard.
7812         * stabsread.h: Add include guard.
7813         * rs6000-tdep.h: Add include guard.
7814         * riscv-fbsd-tdep.h: Add include guard.
7815         * regformats/regdef.h: Rename include guard.
7816         * record.h: Rename include guard.
7817         * python/python.h: Rename include guard.
7818         * python/python-internal.h: Rename include guard.
7819         * python/py-stopevent.h: Rename include guard.
7820         * python/py-ref.h: Rename include guard.
7821         * python/py-record.h: Rename include guard.
7822         * python/py-record-full.h: Rename include guard.
7823         * python/py-record-btrace.h: Rename include guard.
7824         * python/py-instruction.h: Rename include guard.
7825         * python/py-events.h: Rename include guard.
7826         * python/py-event.h: Rename include guard.
7827         * procfs.h: Add include guard.
7828         * proc-utils.h: Add include guard.
7829         * p-lang.h: Add include guard.
7830         * or1k-tdep.h: Rename include guard.
7831         * observable.h: Rename include guard.
7832         * nto-tdep.h: Rename include guard.
7833         * nat/x86-linux.h: Rename include guard.
7834         * nat/x86-linux-dregs.h: Rename include guard.
7835         * nat/x86-gcc-cpuid.h: Add include guard.
7836         * nat/x86-dregs.h: Rename include guard.
7837         * nat/x86-cpuid.h: Rename include guard.
7838         * nat/ppc-linux.h: Rename include guard.
7839         * nat/mips-linux-watch.h: Rename include guard.
7840         * nat/linux-waitpid.h: Rename include guard.
7841         * nat/linux-ptrace.h: Rename include guard.
7842         * nat/linux-procfs.h: Rename include guard.
7843         * nat/linux-osdata.h: Rename include guard.
7844         * nat/linux-nat.h: Rename include guard.
7845         * nat/linux-namespaces.h: Rename include guard.
7846         * nat/linux-btrace.h: Rename include guard.
7847         * nat/glibc_thread_db.h: Rename include guard.
7848         * nat/gdb_thread_db.h: Rename include guard.
7849         * nat/gdb_ptrace.h: Rename include guard.
7850         * nat/fork-inferior.h: Rename include guard.
7851         * nat/amd64-linux-siginfo.h: Rename include guard.
7852         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7853         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7854         * nat/aarch64-linux.h: Rename include guard.
7855         * nat/aarch64-linux-hw-point.h: Rename include guard.
7856         * mn10300-tdep.h: Add include guard.
7857         * mips-linux-tdep.h: Add include guard.
7858         * mi/mi-parse.h: Rename include guard.
7859         * mi/mi-out.h: Rename include guard.
7860         * mi/mi-main.h: Rename include guard.
7861         * mi/mi-interp.h: Rename include guard.
7862         * mi/mi-getopt.h: Rename include guard.
7863         * mi/mi-console.h: Rename include guard.
7864         * mi/mi-common.h: Rename include guard.
7865         * mi/mi-cmds.h: Rename include guard.
7866         * mi/mi-cmd-break.h: Rename include guard.
7867         * m2-lang.h: Add include guard.
7868         * location.h: Rename include guard.
7869         * linux-record.h: Rename include guard.
7870         * linux-nat.h: Add include guard.
7871         * linux-fork.h: Add include guard.
7872         * i386-darwin-tdep.h: Rename include guard.
7873         * hppa-linux-offsets.h: Add include guard.
7874         * guile/guile.h: Rename include guard.
7875         * guile/guile-internal.h: Rename include guard.
7876         * gnu-nat.h: Rename include guard.
7877         * gdb-stabs.h: Rename include guard.
7878         * frv-tdep.h: Add include guard.
7879         * f-lang.h: Add include guard.
7880         * event-loop.h: Add include guard.
7881         * darwin-nat.h: Rename include guard.
7882         * cp-abi.h: Rename include guard.
7883         * config/sparc/nm-sol2.h: Rename include guard.
7884         * config/nm-nto.h: Rename include guard.
7885         * config/nm-linux.h: Add include guard.
7886         * config/i386/nm-i386gnu.h: Rename include guard.
7887         * config/djgpp/nl_types.h: Rename include guard.
7888         * config/djgpp/langinfo.h: Rename include guard.
7889         * compile/gcc-cp-plugin.h: Add include guard.
7890         * compile/gcc-c-plugin.h: Add include guard.
7891         * compile/compile.h: Rename include guard.
7892         * compile/compile-object-run.h: Rename include guard.
7893         * compile/compile-object-load.h: Rename include guard.
7894         * compile/compile-internal.h: Rename include guard.
7895         * compile/compile-cplus.h: Rename include guard.
7896         * compile/compile-c.h: Rename include guard.
7897         * common/xml-utils.h: Rename include guard.
7898         * common/x86-xstate.h: Rename include guard.
7899         * common/version.h: Rename include guard.
7900         * common/vec.h: Rename include guard.
7901         * common/tdesc.h: Rename include guard.
7902         * common/selftest.h: Rename include guard.
7903         * common/scoped_restore.h: Rename include guard.
7904         * common/scoped_mmap.h: Rename include guard.
7905         * common/scoped_fd.h: Rename include guard.
7906         * common/safe-iterator.h: Rename include guard.
7907         * common/run-time-clock.h: Rename include guard.
7908         * common/refcounted-object.h: Rename include guard.
7909         * common/queue.h: Rename include guard.
7910         * common/ptid.h: Rename include guard.
7911         * common/print-utils.h: Rename include guard.
7912         * common/preprocessor.h: Rename include guard.
7913         * common/pathstuff.h: Rename include guard.
7914         * common/observable.h: Rename include guard.
7915         * common/netstuff.h: Rename include guard.
7916         * common/job-control.h: Rename include guard.
7917         * common/host-defs.h: Rename include guard.
7918         * common/gdb_wait.h: Rename include guard.
7919         * common/gdb_vecs.h: Rename include guard.
7920         * common/gdb_unlinker.h: Rename include guard.
7921         * common/gdb_unique_ptr.h: Rename include guard.
7922         * common/gdb_tilde_expand.h: Rename include guard.
7923         * common/gdb_sys_time.h: Rename include guard.
7924         * common/gdb_string_view.h: Rename include guard.
7925         * common/gdb_splay_tree.h: Rename include guard.
7926         * common/gdb_setjmp.h: Rename include guard.
7927         * common/gdb_ref_ptr.h: Rename include guard.
7928         * common/gdb_optional.h: Rename include guard.
7929         * common/gdb_locale.h: Rename include guard.
7930         * common/gdb_assert.h: Rename include guard.
7931         * common/filtered-iterator.h: Rename include guard.
7932         * common/filestuff.h: Rename include guard.
7933         * common/fileio.h: Rename include guard.
7934         * common/environ.h: Rename include guard.
7935         * common/common-utils.h: Rename include guard.
7936         * common/common-types.h: Rename include guard.
7937         * common/common-regcache.h: Rename include guard.
7938         * common/common-inferior.h: Rename include guard.
7939         * common/common-gdbthread.h: Rename include guard.
7940         * common/common-exceptions.h: Rename include guard.
7941         * common/common-defs.h: Rename include guard.
7942         * common/common-debug.h: Rename include guard.
7943         * common/cleanups.h: Rename include guard.
7944         * common/buffer.h: Rename include guard.
7945         * common/btrace-common.h: Rename include guard.
7946         * common/break-common.h: Rename include guard.
7947         * cli/cli-utils.h: Rename include guard.
7948         * cli/cli-style.h: Rename include guard.
7949         * cli/cli-setshow.h: Rename include guard.
7950         * cli/cli-script.h: Rename include guard.
7951         * cli/cli-interp.h: Rename include guard.
7952         * cli/cli-decode.h: Rename include guard.
7953         * cli/cli-cmds.h: Rename include guard.
7954         * charset-list.h: Add include guard.
7955         * buildsym-legacy.h: Rename include guard.
7956         * bfin-tdep.h: Add include guard.
7957         * ax.h: Rename include guard.
7958         * arm-linux-tdep.h: Add include guard.
7959         * arm-fbsd-tdep.h: Add include guard.
7960         * arch/xtensa.h: Rename include guard.
7961         * arch/tic6x.h: Add include guard.
7962         * arch/i386.h: Add include guard.
7963         * arch/arm.h: Rename include guard.
7964         * arch/arm-linux.h: Rename include guard.
7965         * arch/arm-get-next-pcs.h: Rename include guard.
7966         * arch/amd64.h: Add include guard.
7967         * arch/aarch64-insn.h: Rename include guard.
7968         * arch-utils.h: Rename include guard.
7969         * annotate.h: Add include guard.
7970         * amd64-darwin-tdep.h: Rename include guard.
7971         * aarch64-linux-tdep.h: Add include guard.
7972         * aarch64-fbsd-tdep.h: Add include guard.
7973         * aarch32-linux-nat.h: Add include guard.
7974
7975 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7976
7977         * macrotab.c (macro_define_internal): New function that
7978         factorizes macro_define_object_internal and macro_define_function
7979         code.
7980         (macro_define_object_internal): Use macro_define_internal.
7981         (macro_define_function): Likewise.
7982
7983 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7984
7985         * macrocmd.c (extract_identifier): Return
7986         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7987         callers.
7988
7989 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7990
7991         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7992
7993 2019-02-05  Tom Tromey  <tom@tromey.com>
7994
7995         * target.c (target_stack::unpush): Move assertion earlier.
7996
7997 2019-01-30  Tom Tromey  <tom@tromey.com>
7998
7999         PR python/23615:
8000         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8001         (gdbpy_parse_and_eval): Likewise.
8002         * python/python-internal.h (gdbpy_allow_threads): New class.
8003
8004 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8005
8006         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8007         (aarch64_fbsd_fpregmap): Move earlier.
8008         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8009         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8010         instead of individual calls to trad_frame_set_reg_addr.
8011         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8012         earlier.
8013         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8014         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8015         instead of individual calls to trad_frame_set_reg_addr.
8016
8017 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8018
8019         * CONTRIBUTE: Replace contribution list with wiki link.
8020
8021 2019-01-25  Tom Tromey  <tom@tromey.com>
8022
8023         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8024
8025 2019-01-25  Tom Tromey  <tom@tromey.com>
8026
8027         * xtensa-linux-nat.c: Fix common/ includes.
8028         * xml-support.h: Fix common/ includes.
8029         * xml-support.c: Fix common/ includes.
8030         * x86-linux-nat.c: Fix common/ includes.
8031         * windows-nat.c: Fix common/ includes.
8032         * varobj.h: Fix common/ includes.
8033         * varobj.c: Fix common/ includes.
8034         * value.c: Fix common/ includes.
8035         * valops.c: Fix common/ includes.
8036         * utils.c: Fix common/ includes.
8037         * unittests/xml-utils-selftests.c: Fix common/ includes.
8038         * unittests/utils-selftests.c: Fix common/ includes.
8039         * unittests/unpack-selftests.c: Fix common/ includes.
8040         * unittests/tracepoint-selftests.c: Fix common/ includes.
8041         * unittests/style-selftests.c: Fix common/ includes.
8042         * unittests/string_view-selftests.c: Fix common/ includes.
8043         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8044         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8045         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8046         * unittests/rsp-low-selftests.c: Fix common/ includes.
8047         * unittests/parse-connection-spec-selftests.c: Fix common/
8048         includes.
8049         * unittests/optional-selftests.c: Fix common/ includes.
8050         * unittests/offset-type-selftests.c: Fix common/ includes.
8051         * unittests/observable-selftests.c: Fix common/ includes.
8052         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8053         * unittests/memrange-selftests.c: Fix common/ includes.
8054         * unittests/memory-map-selftests.c: Fix common/ includes.
8055         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8056         * unittests/function-view-selftests.c: Fix common/ includes.
8057         * unittests/environ-selftests.c: Fix common/ includes.
8058         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8059         * unittests/common-utils-selftests.c: Fix common/ includes.
8060         * unittests/cli-utils-selftests.c: Fix common/ includes.
8061         * unittests/array-view-selftests.c: Fix common/ includes.
8062         * ui-file.c: Fix common/ includes.
8063         * tui/tui-io.c: Fix common/ includes.
8064         * tracepoint.h: Fix common/ includes.
8065         * tracepoint.c: Fix common/ includes.
8066         * tracefile-tfile.c: Fix common/ includes.
8067         * top.h: Fix common/ includes.
8068         * top.c: Fix common/ includes.
8069         * thread.c: Fix common/ includes.
8070         * target/waitstatus.h: Fix common/ includes.
8071         * target/waitstatus.c: Fix common/ includes.
8072         * target.h: Fix common/ includes.
8073         * target.c: Fix common/ includes.
8074         * target-memory.c: Fix common/ includes.
8075         * target-descriptions.c: Fix common/ includes.
8076         * symtab.h: Fix common/ includes.
8077         * symfile.c: Fix common/ includes.
8078         * stap-probe.c: Fix common/ includes.
8079         * spu-linux-nat.c: Fix common/ includes.
8080         * sparc-nat.c: Fix common/ includes.
8081         * source.c: Fix common/ includes.
8082         * solib.c: Fix common/ includes.
8083         * solib-target.c: Fix common/ includes.
8084         * ser-unix.c: Fix common/ includes.
8085         * ser-tcp.c: Fix common/ includes.
8086         * ser-pipe.c: Fix common/ includes.
8087         * ser-base.c: Fix common/ includes.
8088         * selftest-arch.c: Fix common/ includes.
8089         * s12z-tdep.c: Fix common/ includes.
8090         * rust-exp.y: Fix common/ includes.
8091         * rs6000-aix-tdep.c: Fix common/ includes.
8092         * riscv-tdep.c: Fix common/ includes.
8093         * remote.c: Fix common/ includes.
8094         * remote-notif.h: Fix common/ includes.
8095         * remote-fileio.h: Fix common/ includes.
8096         * remote-fileio.c: Fix common/ includes.
8097         * regcache.h: Fix common/ includes.
8098         * regcache.c: Fix common/ includes.
8099         * record-btrace.c: Fix common/ includes.
8100         * python/python.c: Fix common/ includes.
8101         * python/py-type.c: Fix common/ includes.
8102         * python/py-inferior.c: Fix common/ includes.
8103         * progspace.h: Fix common/ includes.
8104         * producer.c: Fix common/ includes.
8105         * procfs.c: Fix common/ includes.
8106         * proc-api.c: Fix common/ includes.
8107         * printcmd.c: Fix common/ includes.
8108         * ppc-linux-nat.c: Fix common/ includes.
8109         * parser-defs.h: Fix common/ includes.
8110         * osdata.c: Fix common/ includes.
8111         * obsd-nat.c: Fix common/ includes.
8112         * nat/x86-linux.c: Fix common/ includes.
8113         * nat/x86-linux-dregs.c: Fix common/ includes.
8114         * nat/x86-dregs.h: Fix common/ includes.
8115         * nat/x86-dregs.c: Fix common/ includes.
8116         * nat/ppc-linux.c: Fix common/ includes.
8117         * nat/mips-linux-watch.h: Fix common/ includes.
8118         * nat/mips-linux-watch.c: Fix common/ includes.
8119         * nat/linux-waitpid.c: Fix common/ includes.
8120         * nat/linux-ptrace.h: Fix common/ includes.
8121         * nat/linux-ptrace.c: Fix common/ includes.
8122         * nat/linux-procfs.c: Fix common/ includes.
8123         * nat/linux-personality.c: Fix common/ includes.
8124         * nat/linux-osdata.c: Fix common/ includes.
8125         * nat/linux-namespaces.c: Fix common/ includes.
8126         * nat/linux-btrace.h: Fix common/ includes.
8127         * nat/linux-btrace.c: Fix common/ includes.
8128         * nat/fork-inferior.c: Fix common/ includes.
8129         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8130         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8131         * nat/aarch64-linux.c: Fix common/ includes.
8132         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8133         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8134         * namespace.h: Fix common/ includes.
8135         * mips-linux-tdep.c: Fix common/ includes.
8136         * minsyms.c: Fix common/ includes.
8137         * mi/mi-parse.h: Fix common/ includes.
8138         * mi/mi-main.c: Fix common/ includes.
8139         * mi/mi-cmd-env.c: Fix common/ includes.
8140         * memrange.h: Fix common/ includes.
8141         * memattr.c: Fix common/ includes.
8142         * maint.h: Fix common/ includes.
8143         * maint.c: Fix common/ includes.
8144         * main.c: Fix common/ includes.
8145         * machoread.c: Fix common/ includes.
8146         * location.c: Fix common/ includes.
8147         * linux-thread-db.c: Fix common/ includes.
8148         * linux-nat.c: Fix common/ includes.
8149         * linux-fork.c: Fix common/ includes.
8150         * inline-frame.c: Fix common/ includes.
8151         * infrun.c: Fix common/ includes.
8152         * inflow.c: Fix common/ includes.
8153         * inferior.h: Fix common/ includes.
8154         * inferior.c: Fix common/ includes.
8155         * infcmd.c: Fix common/ includes.
8156         * inf-ptrace.c: Fix common/ includes.
8157         * inf-child.c: Fix common/ includes.
8158         * ia64-linux-nat.c: Fix common/ includes.
8159         * i387-tdep.c: Fix common/ includes.
8160         * i386-tdep.c: Fix common/ includes.
8161         * i386-linux-tdep.c: Fix common/ includes.
8162         * i386-linux-nat.c: Fix common/ includes.
8163         * i386-go32-tdep.c: Fix common/ includes.
8164         * i386-fbsd-tdep.c: Fix common/ includes.
8165         * i386-fbsd-nat.c: Fix common/ includes.
8166         * guile/scm-type.c: Fix common/ includes.
8167         * guile/guile.c: Fix common/ includes.
8168         * go32-nat.c: Fix common/ includes.
8169         * gnu-nat.c: Fix common/ includes.
8170         * gdbthread.h: Fix common/ includes.
8171         * gdbarch-selftests.c: Fix common/ includes.
8172         * gdb_usleep.c: Fix common/ includes.
8173         * gdb_select.h: Fix common/ includes.
8174         * gdb_bfd.c: Fix common/ includes.
8175         * gcore.c: Fix common/ includes.
8176         * fork-child.c: Fix common/ includes.
8177         * findvar.c: Fix common/ includes.
8178         * fbsd-nat.c: Fix common/ includes.
8179         * event-top.c: Fix common/ includes.
8180         * event-loop.c: Fix common/ includes.
8181         * dwarf2read.c: Fix common/ includes.
8182         * dwarf2loc.c: Fix common/ includes.
8183         * dwarf2-frame.c: Fix common/ includes.
8184         * dwarf-index-cache.c: Fix common/ includes.
8185         * dtrace-probe.c: Fix common/ includes.
8186         * disasm-selftests.c: Fix common/ includes.
8187         * defs.h: Fix common/ includes.
8188         * csky-tdep.c: Fix common/ includes.
8189         * cp-valprint.c: Fix common/ includes.
8190         * cp-support.h: Fix common/ includes.
8191         * cp-support.c: Fix common/ includes.
8192         * corelow.c: Fix common/ includes.
8193         * completer.h: Fix common/ includes.
8194         * completer.c: Fix common/ includes.
8195         * compile/compile.c: Fix common/ includes.
8196         * compile/compile-loc2c.c: Fix common/ includes.
8197         * compile/compile-cplus-types.c: Fix common/ includes.
8198         * compile/compile-cplus-symbols.c: Fix common/ includes.
8199         * command.h: Fix common/ includes.
8200         * cli/cli-dump.c: Fix common/ includes.
8201         * cli/cli-cmds.c: Fix common/ includes.
8202         * charset.c: Fix common/ includes.
8203         * build-id.c: Fix common/ includes.
8204         * btrace.h: Fix common/ includes.
8205         * btrace.c: Fix common/ includes.
8206         * breakpoint.h: Fix common/ includes.
8207         * breakpoint.c: Fix common/ includes.
8208         * ax.h:
8209         (enum agent_op): Fix common/ includes.
8210         * ax-general.c (struct aop_map): Fix common/ includes.
8211         * ax-gdb.c: Fix common/ includes.
8212         * auxv.c: Fix common/ includes.
8213         * auto-load.c: Fix common/ includes.
8214         * arm-tdep.c: Fix common/ includes.
8215         * arch/riscv.c: Fix common/ includes.
8216         * arch/ppc-linux-common.c: Fix common/ includes.
8217         * arch/i386.c: Fix common/ includes.
8218         * arch/arm.c: Fix common/ includes.
8219         * arch/arm-linux.c: Fix common/ includes.
8220         * arch/arm-get-next-pcs.c: Fix common/ includes.
8221         * arch/amd64.c: Fix common/ includes.
8222         * arch/aarch64.c: Fix common/ includes.
8223         * arch/aarch64-insn.c: Fix common/ includes.
8224         * arch-utils.c: Fix common/ includes.
8225         * amd64-windows-tdep.c: Fix common/ includes.
8226         * amd64-tdep.c: Fix common/ includes.
8227         * amd64-sol2-tdep.c: Fix common/ includes.
8228         * amd64-obsd-tdep.c: Fix common/ includes.
8229         * amd64-nbsd-tdep.c: Fix common/ includes.
8230         * amd64-linux-tdep.c: Fix common/ includes.
8231         * amd64-linux-nat.c: Fix common/ includes.
8232         * amd64-fbsd-tdep.c: Fix common/ includes.
8233         * amd64-fbsd-nat.c: Fix common/ includes.
8234         * amd64-dicos-tdep.c: Fix common/ includes.
8235         * amd64-darwin-tdep.c: Fix common/ includes.
8236         * agent.c: Fix common/ includes.
8237         * ada-lang.h: Fix common/ includes.
8238         * ada-lang.c: Fix common/ includes.
8239         * aarch64-tdep.c: Fix common/ includes.
8240
8241 2019-01-25  Tom Tromey  <tom@tromey.com>
8242
8243         * common/create-version.sh: Use common/version.h.
8244
8245 2019-01-24  Pedro Alves  <palves@redhat.com>
8246
8247         * infrun.c (signal_stop, signal_print, signal_program)
8248         (signal_catch, signal_pass): Now arrays instead of pointers.
8249         (update_signals_program_target, do_target_resume)
8250         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8251         * linux-nat.c (linux_nat_target::pass_signals)
8252         (linux_nat_target::create_inferior, linux_nat_target::attach):
8253         Adjust.
8254         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8255         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8256         * procfs.c (procfs_target::pass_signals): Adjust.
8257         * record-full.c (record_full_target::resume): Adjust.
8258         * remote.c (remote_target::pass_signals)
8259         (remote_target::program_signals): Adjust.
8260         * target-debug.h (target_debug_print_signals): Now takes a
8261         gdb::array_view as parameter.  Adjust.
8262         * target.h (target_ops) <pass_signals, program_signals>: Replace
8263         pointer and length parameters with gdb::array_view.
8264         (target_pass_signals, target_program_signals): Likewise.
8265         * target-delegates.c: Regenerate.
8266
8267 2019-01-24  Pedro Alves  <palves@redhat.com>
8268
8269         * common/forward-scope-exit.h
8270         (forward_scope_exit::forward_scope_exit): Pass arguments to
8271         m_bind_function directly, instead of creating a std::bind and
8272         copying that.
8273
8274 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8275
8276         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8277         for static members.
8278         (pass_in_v_vfp_candidate): Likewise.
8279
8280 2019-01-23  Tom Tromey  <tom@tromey.com>
8281             Pedro Alves  <palves@redhat.com>
8282
8283         * regcache.c (class regcache_invalidator): Remove.
8284         (regcache::raw_write): Use make_scope_exit.
8285
8286 2019-01-23  Tom Tromey  <tom@tromey.com>
8287
8288         * ui-out.h (class ui_out_emit_type): Update comment.
8289
8290 2019-01-23  Tom Tromey  <tom@tromey.com>
8291
8292         * infrun.c (fetch_inferior_event): Update comment.
8293
8294 2019-01-23  Tom Tromey  <tom@tromey.com>
8295             Pedro Alves  <palves@redhat.com>
8296
8297         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8298         parameter.
8299         (fetch_inferior_event): Use SCOPE_EXIT.
8300
8301
8302 2019-01-23  Tom Tromey  <tom@tromey.com>
8303             Pedro Alves  <palves@redhat.com>
8304
8305         * infrun.c (disable_thread_events): Delete.
8306         (stop_all_threads): Use SCOPE_EXIT.
8307
8308 2019-01-23  Tom Tromey  <tom@tromey.com>
8309             Pedro Alves  <palves@redhat.com>
8310
8311         * symfile.c: Include forward-scope-exit.h.
8312         (clear_symtab_users_cleanup): Replace forward declaration with
8313         a FORWARD_SCOPE_EXIT.
8314         (syms_from_objfile_1): Use the forward_scope_exit and
8315         gdb::optional instead of cleanup_function.
8316         (reread_symbols): Use the forward_scope_exit instead of
8317         cleanup_function.
8318         (clear_symtab_users_cleanup): Remove function.
8319
8320 2019-01-23  Tom Tromey  <tom@tromey.com>
8321             Pedro Alves  <palves@redhat.com>
8322
8323         * linux-nat.c: Include scope-exit.h.
8324         (cleanup_target_stop): Remove.
8325         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8326         SCOPE_EXIT.
8327
8328 2019-01-23  Tom Tromey  <tom@tromey.com>
8329             Pedro Alves  <palves@redhat.com>
8330
8331         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8332         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8333
8334 2019-01-23  Tom Tromey  <tom@tromey.com>
8335             Andrew Burgess  <andrew.burgess@embecosm.com>
8336             Pedro Alves  <palves@redhat.com>
8337
8338         * infrun.c (fetch_inferior_event): Use scope_exit.
8339         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8340         * top.c (execute_command): Use scope_exit.
8341         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8342         * utils.c (do_bpstat_clear_actions_cleanup)
8343         (make_bpstat_clear_actions_cleanup): Remove.
8344
8345 2019-01-23  Tom Tromey  <tom@tromey.com>
8346             Pedro Alves  <palves@redhat.com>
8347
8348         * infrun.c: Include "common/scope-exit.h"
8349         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8350         (wait_for_inferior): Use SCOPE_EXIT.
8351         (fetch_inferior_event): Use scope_exit.
8352
8353 2019-01-23  Tom Tromey  <tom@tromey.com>
8354             Pedro Alves  <palves@redhat.com>
8355
8356         * breakpoint.c (create_breakpoint): Remove cleanup.
8357
8358 2019-01-23  Tom Tromey  <tom@tromey.com>
8359             Andrew Burgess  <andrew.burgess@embecosm.com>
8360             Pedro Alves  <palves@redhat.com>
8361
8362 2019-01-23  Pedro Alves  <palves@redhat.com>
8363
8364         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8365
8366 2019-01-23  Pedro Alves  <palves@redhat.com>
8367             Andrew Burgess  <andrew.burgess@embecosm.com>
8368
8369         * gdbthread.h: Include "common/forward-scope-exit.h".
8370         (scoped_finish_thread_state): Redefine custom class in terms of
8371         forward_scope_exit.
8372
8373 2019-01-23  Pedro Alves  <palves@redhat.com>
8374             Andrew Burgess  <andrew.burgess@embecosm.com>
8375
8376         * common/forward-scope-exit.h: New file.
8377
8378 2019-01-23  Pedro Alves  <palves@redhat.com>
8379             Andrew Burgess  <andrew.burgess@embecosm.com>
8380             Tom Tromey  <tom@tromey.com>
8381
8382         * common/scope-exit.h: New file.
8383
8384 2019-01-23  Pedro Alves  <palves@redhat.com>
8385
8386         * common/preprocessor.h (ESC): Rename to ...
8387         (ESC_PARENS): ... this.
8388         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8389         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8390
8391 2019-01-23  Tom Tromey  <tom@tromey.com>
8392
8393         * language.h (class scoped_switch_to_sym_language_if_auto):
8394         Initialize m_lang in both cases.
8395
8396 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8397
8398         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8399         with XCNEW.
8400
8401 2019-01-22  Tom Tromey  <tom@tromey.com>
8402
8403         * corelow.c: Do not include sys/file.h.
8404
8405 2019-01-22  Tom Tromey  <tom@tromey.com>
8406
8407         * tui/tui-wingeneral.h: Include gdb_curses.h.
8408
8409 2019-01-22  Tom Tromey  <tom@tromey.com>
8410
8411         * source-cache.h (class source_cache) <get_source_lines,
8412         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8413
8414 2019-01-22  Tom Tromey  <tom@tromey.com>
8415
8416         * remote-fileio.h (struct remote_target): Declare.
8417
8418 2019-01-22  Tom Tromey  <tom@tromey.com>
8419
8420         * python/py-arch.c: Do not include py-ref.h.
8421         * python/py-bpevent.c: Do not include py-ref.h.
8422         * python/py-cmd.c: Do not include py-ref.h.
8423         * python/py-continueevent.c: Do not include py-ref.h.
8424         * python/py-event.h: Do not include py-ref.h.
8425         * python/py-evtregistry.c: Do not include py-ref.h.
8426         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8427         * python/py-frame.c: Do not include py-ref.h.
8428         * python/py-framefilter.c: Do not include py-ref.h.
8429         * python/py-function.c: Do not include py-ref.h.
8430         * python/py-infevents.c: Do not include py-ref.h.
8431         * python/py-linetable.c: Do not include py-ref.h.
8432         * python/py-objfile.c: Do not include py-ref.h.
8433         * python/py-param.c: Do not include py-ref.h.
8434         * python/py-prettyprint.c: Do not include py-ref.h.
8435         * python/py-progspace.c: Do not include py-ref.h.
8436         * python/py-symbol.c: Do not include py-ref.h.
8437         * python/py-symtab.c: Do not include py-ref.h.
8438         * python/py-type.c: Do not include py-ref.h.
8439         * python/py-unwind.c: Do not include py-ref.h.
8440         * python/py-utils.c: Do not include py-ref.h.
8441         * python/py-value.c: Do not include py-ref.h.
8442         * python/py-varobj.c: Do not include py-ref.h.
8443         * python/py-xmethods.c: Do not include py-ref.h.
8444         * python/python.c: Do not include py-ref.h.
8445         * varobj.c: Do not include py-ref.h.
8446
8447 2019-01-22  Tom Tromey  <tom@tromey.com>
8448
8449         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8450         keyword for bcache.
8451
8452 2019-01-22  Tom Tromey  <tom@tromey.com>
8453
8454         * compile/compile-cplus-types.c: Remove a comment by #include.
8455
8456 2019-01-22  Tom Tromey  <tom@tromey.com>
8457
8458         * compile/gcc-c-plugin.h: Include compile-internal.h.
8459
8460 2019-01-22  Tom Tromey  <tom@tromey.com>
8461
8462         * stabsread.c (EXTERN): Do not define.
8463         (symnum, next_symbol_text_func, processing_gcc_compilation)
8464         (within_function, global_sym_chain, global_stabs)
8465         (previous_stab_code, this_object_header_files)
8466         (n_this_object_header_files)
8467         (n_allocated_this_object_header_files): Define.
8468         * stabsread.h (EXTERN): Never define.  Use "extern".
8469
8470 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8471
8472         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8473         history_value.
8474
8475 2019-01-21  Tom Tromey  <tom@tromey.com>
8476
8477         * ui-out.c: Fix includes.
8478         * tui/tui-source.c: Fix includes.
8479         * target.c: Fix includes.
8480         * remote.c: Fix includes.
8481         * regcache.c: Fix includes.
8482         * python/py-block.c: Fix includes.
8483         * printcmd.c: Fix includes.
8484         * or1k-tdep.c: Fix includes.
8485         * mi/mi-main.c: Fix includes.
8486         * m32r-tdep.c: Fix includes.
8487         * csky-tdep.c: Fix includes.
8488         * compile/compile-cplus-types.c: Fix includes.
8489         * cli/cli-interp.c: Fix includes.
8490
8491 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8492
8493         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8494         for padding.
8495
8496 2019-01-16  Tom Tromey  <tom@tromey.com>
8497
8498         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8499         earlier.
8500         (struct objfile) <msymbols_range>: Move from top level.
8501         <msymbols>: New method.
8502         (class objfile_msymbols): Remove.
8503         * symtab.c (default_collect_symbol_completion_matches_break_on):
8504         Update.
8505         * symmisc.c (dump_msymbols): Update.
8506         * stabsread.c (scan_file_globals): Update.
8507         * objc-lang.c (info_selectors_command, info_classes_command)
8508         (find_methods): Update.
8509         * minsyms.c (find_solib_trampoline_target): Update.
8510         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8511         * coffread.c (coff_symfile_read): Update.
8512         * ada-lang.c (ada_lookup_simple_minsym)
8513         (ada_collect_symbol_completion_matches): Update.
8514
8515 2019-01-16  Tom Tromey  <tom@tromey.com>
8516
8517         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8518         type.  Remove no-argument constructor.
8519         <iterator::operator++>: Simplify.
8520         <begin>: Update.
8521         <end>: Use minimal_symbol_count.
8522
8523 2019-01-16  Tom Tromey  <tom@tromey.com>
8524
8525         * objfiles.h (struct objfile) <psymtabs>: New method.
8526         (class objfile_psymtabs): Remove.
8527         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8528         typedef.
8529         <range>: New method.
8530         (require_partial_symbols): Change return type.
8531         * psymtab.c (require_partial_symbols)
8532         (psym_expand_symtabs_matching): Update.
8533         * mdebugread.c (parse_partial_symbols): Update.
8534         * dbxread.c (dbx_end_psymtab): Update.
8535
8536 2019-01-15  Tom Tromey  <tom@tromey.com>
8537
8538         * symtab.c (lookup_objfile_from_block)
8539         (lookup_symbol_in_objfile_symtabs)
8540         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8541         (find_line_symtab, info_sources_command)
8542         (default_collect_symbol_completion_matches_break_on)
8543         (make_source_files_completion_list): Update.
8544         * symmisc.c (print_objfile_statistics, dump_objfile)
8545         (maintenance_print_symbols, maintenance_info_symtabs)
8546         (maintenance_check_symtabs, maintenance_info_line_tables):
8547         Update.
8548         * source.c (select_source_symtab)
8549         (forget_cached_source_info_for_objfile): Update.
8550         * objfiles.h (class objfile_compunits): Remove.
8551         (struct objfile) <compunits_range>: New typedef.
8552         (compunits): New method.
8553         * objfiles.c (objfile_relocate1): Update.
8554         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8555         * maint.c (count_symtabs_and_blocks): Update.
8556         * linespec.c (iterate_over_all_matching_symtabs): Update.
8557         * cp-support.c (add_symbol_overload_list_qualified): Update.
8558         * coffread.c (coff_symtab_read): Update.
8559         * ada-lang.c (add_nonlocal_symbols)
8560         (ada_collect_symbol_completion_matches)
8561         (ada_add_global_exceptions): Update.
8562
8563 2019-01-15  Tom Tromey  <tom@tromey.com>
8564
8565         * progspace.h (program_space) <objfiles_safe_range>: New
8566         typedef.
8567         <objfiles_safe>: New method.
8568         * objfiles.h (class all_objfiles_safe): Remove.
8569         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8570         * jit.c (jit_inferior_exit_hook): Update.
8571
8572 2019-01-17  Tom Tromey  <tom@tromey.com>
8573
8574         * progspace.h (program_space) <objfiles_range>: New typedef.
8575         <objfiles>: New method.
8576         <objfiles_head>: Rename from objfiles.
8577         (object_files): Update.
8578         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8579         * guile/scm-pretty-print.c
8580         (ppscm_find_pretty_printer_from_objfiles): Update.
8581         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8582         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8583         Update.
8584         * python/py-progspace.c (pspy_get_objfiles): Update.
8585         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8586         Update.
8587         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8588         (objfpy_lookup_objfile_by_build_id): Update.
8589         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8590         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8591         Update.
8592         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8593         (expand_symtab_containing_pc, lookup_objfile_from_block)
8594         (lookup_static_symbol, basic_lookup_transparent_type)
8595         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8596         (find_line_symtab, info_sources_command)
8597         (default_collect_symbol_completion_matches_break_on)
8598         (make_source_files_completion_list, find_main_name): Update.
8599         * symmisc.c (print_symbol_bcache_statistics)
8600         (print_objfile_statistics, maintenance_print_symbols)
8601         (maintenance_print_msymbols, maintenance_print_objfiles)
8602         (maintenance_info_symtabs, maintenance_check_symtabs)
8603         (maintenance_expand_symtabs, maintenance_info_line_tables):
8604         Update.
8605         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8606         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8607         (map_overlay_command, unmap_overlay_command)
8608         (simple_overlay_update, expand_symtabs_matching)
8609         (map_symbol_filenames): Update.
8610         * symfile-debug.c (set_debug_symfile): Update.
8611         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8612         Update.
8613         * source.c (select_source_symtab, forget_cached_source_info):
8614         Update.
8615         * solib.c (solib_read_symbols): Update.
8616         * solib-spu.c (append_ocl_sos): Update.
8617         * psymtab.c (maintenance_print_psymbols)
8618         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8619         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8620         * printcmd.c (info_symbol_command): Update.
8621         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8622         Update.
8623         * objfiles.h (class all_objfiles): Remove.
8624         * objfiles.c (have_partial_symbols, have_full_symbols)
8625         (have_minimal_symbols, qsort_cmp, update_section_map)
8626         (shared_objfile_contains_address_p)
8627         (default_iterate_over_objfiles_in_search_order): Update.
8628         * objc-lang.c (info_selectors_command, info_classes_command)
8629         (find_methods): Update.
8630         * minsyms.c (find_solib_trampoline_target): Update.
8631         * maint.c (maintenance_info_sections)
8632         (maintenance_translate_address, count_symtabs_and_blocks):
8633         Update.
8634         * main.c (captured_main_1): Update.
8635         * linux-thread-db.c (try_thread_db_load_from_pdir)
8636         (has_libpthread): Update.
8637         * linespec.c (iterate_over_all_matching_symtabs)
8638         (search_minsyms_for_name): Update.
8639         * jit.c (jit_find_objf_with_entry_addr): Update.
8640         * hppa-tdep.c (find_unwind_entry)
8641         (hppa_lookup_stub_minimal_symbol): Update.
8642         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8643         Update.
8644         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8645         (elf_gnu_ifunc_resolve_by_got): Update.
8646         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8647         * dwarf-index-write.c (save_gdb_index_command): Update.
8648         * cp-support.c (add_symbol_overload_list_qualified): Update.
8649         * breakpoint.c (create_overlay_event_breakpoint)
8650         (create_longjmp_master_breakpoint)
8651         (create_std_terminate_master_breakpoint)
8652         (create_exception_master_breakpoint): Update.
8653         * blockframe.c (find_pc_partial_function): Update.
8654         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8655         (ada_collect_symbol_completion_matches)
8656         (ada_add_global_exceptions): Update.
8657
8658 2019-01-17  Tom Tromey  <tom@tromey.com>
8659
8660         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8661         declare VEC.
8662         (solib_target_parse_libraries): Change return type.
8663         (library_list_start_segment, library_list_start_section)
8664         (library_list_end_library, library_list_start_library); Update.
8665         (solib_target_free_library_list): Remove.
8666         (solib_target_parse_libraries): Remove cleanup.  Change return
8667         type.
8668         (solib_target_current_sos): Update.
8669
8670 2019-01-17  Tom Tromey  <tromey@bapiya>
8671
8672         * valprint.c: Replace "the the" with "the".
8673         * symtab.c: Replace "the the" with "the".
8674         * solib.c: Replace "the the" with "the".
8675         * solib-dsbt.c: Replace "the the" with "the".
8676         * linespec.c: Replace "the the" with "the".
8677         * dwarf2loc.h: Replace "the the" with "the".
8678         * amd64-windows-tdep.c: Replace "the the" with "the".
8679         * aarch64-tdep.c: Replace "the the" with "the".
8680
8681 2019-01-16  Keith Seitz  <keiths@redhat.com>
8682
8683         PR gdb/23773
8684         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8685         <builder>: Rename to ..
8686         <m_builder>: ... this and make private.
8687         (dwarf2_cu::get_builder): New method.  Change all users of
8688         `builder' to use this method.
8689         (dwarf2_start_symtab): Move to ...
8690         (dwarf2_cu::start_symtab): ... here.  Update all callers
8691         (setup_type_unit_groups): Move to ...
8692         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8693         callers.
8694         (dwarf2_cu::reset_builder): New method.
8695         (process_full_compunit, process_full_type_unit): Use
8696         dwarf2_cu::reset_builder.
8697         (follow_die_offset): Record the ancestor CU if it is different
8698         from the followed DIE's CU.
8699         (follow_die_sig_1): Likewise.
8700
8701 2019-01-15  Tom Tromey  <tom@tromey.com>
8702
8703         * remote.c (class remote_state) <buf>: Now a char_vector.
8704         <buf_size>: Remove.
8705         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8706         parameter.
8707         (remote_target::getpkt_or_notif_sane_1)
8708         (remote_target::getpkt_sane)
8709         (remote_target::getpkt_or_notif_sane): Likewise.
8710         (class remote_target) <putpkt>: New overload.
8711         (remote_target::read_frame): Change type of "buf_p".  Remove
8712         sizeof_p parameter.
8713         (packet_ok): New overload.
8714         (packet_check_result): New overload.
8715         Update all uses.
8716
8717 2019-01-14  Tom Tromey  <tom@tromey.com>
8718
8719         * remote-notif.c (handle_notification, remote_notif_ack)
8720         (remote_notif_parse): Make "buf" const.
8721         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8722         const.
8723         (remote_notif_parse, remote_notif_ack, handle_notification):
8724         Likewise.
8725         * remote.c (remote_notif_stop_parse): Make "buf" const.
8726         (remote_target::remote_parse_stop_reply): Make "buf" const.
8727         (remote_notif_stop_ack): Make "buf" const.
8728
8729 2019-01-14  Tom Tromey  <tom@tromey.com>
8730
8731         * remote.c (remote_console_output): Make parameter const.
8732
8733 2019-01-14  Tom Tromey  <tom@tromey.com>
8734
8735         * target-debug.h (target_debug_print_signals): Constify.
8736         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8737         * procfs.c (procfs_target::pass_signals): Update.
8738         * linux-nat.c (linux_nat_target::pass_signals): Update.
8739         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8740         * target-delegates.c: Rebuild.
8741         * remote.c (remote_target::program_signals): Update.
8742         (remote_target::pass_signals): Update.
8743         * target.c (target_pass_signals): Constify argument.
8744         (target_program_signals): Likewise.
8745         * target.h (struct target_ops) <pass_signals, program_signals>:
8746         Constify argument.
8747         (target_pass_signals, target_program_signals): Constify argument.
8748
8749 2019-01-14  Tom Tromey  <tom@tromey.com>
8750
8751         PR tui/28819:
8752         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8753
8754 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8755
8756         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8757         field.
8758         * rs6000-tdep.c: Include reggroups.h.
8759         (IS_V_ALIAS_PSEUDOREG): Define.
8760         (rs6000_register_name): Return names for the "vX" aliases.
8761         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8762         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8763         aliases.  Call default_register_reggroup_p for all other
8764         pseudo-registers.
8765         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8766         New functions.
8767         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8768         Handle "vX" aliases.
8769         (v_alias_pseudo_register_collect): New function.
8770         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8771         (rs6000_gdbarch_init): Initialize "vX" aliases as
8772         pseudo-registers.  Restore registration of
8773         rs6000_pseudo_register_reggroup_p with
8774         set_tdesc_pseudo_register_reggroup_p.
8775
8776 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8777
8778         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8779         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8780         set_gdbarch_num_pseudo_regs.
8781
8782 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8783
8784         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8785         Remove arg prefixname, add do_set and do_show.
8786         Add member functions set_list and show_list.
8787         * cli/cli-style.c (class cli_style_option): Update accordingly.
8788         (style_set_list): Move to file scope.
8789         (style_show_list): Likewise.
8790         (set_style): Call help_list.
8791         (show_style): Call cmd_show_list.
8792         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8793         Update to use the new macro.
8794
8795 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8796
8797         * ada-lang.c (_initialize_ada_language): Expand the help text
8798         for the "catch exception" command.
8799
8800 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8801
8802         * symtab.c (matching_obj_sections): Initialize obj,
8803         declare it closer to its usage.
8804
8805 2019-01-10  Tom Tromey  <tom@tromey.com>
8806
8807         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8808         (basic_inf_threads_range): Remove.
8809         (inf_threads_range, inf_non_exited_threads_range)
8810         (safe_inf_threads_range): Use next_adapter.
8811
8812 2019-01-10  Keith Seitz  <keiths@redhat.com>
8813
8814         PR gdb/23712
8815         PR symtab/23010
8816         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8817         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8818
8819 2019-01-10  Keith Seitz  <keiths@redhat.com>
8820
8821         PR gdb/23712
8822         PR symtab/23010
8823         * dictionary.c (pending_to_vector): Remove.
8824         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8825         Remove _1 suffix, replacing functions of the same name.  Update
8826         all callers.
8827         (dict_create_hashed, dict_create_hashed_expandable)
8828         (dict_create_linear, dict_create_linear_expandable, dict_free)
8829         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8830         Make functions static.
8831
8832 2019-01-10  Keith Seitz  <keiths@redhat.com>
8833
8834         PR gdb/23712
8835         PR symtab/23010
8836         * dictionary.h (struct dictionary): Replace declaration with
8837         multidictionary.
8838         (dict_create_hashed, dict_create_hashed_expandable)
8839         (dict_create_linear, dict_create_linear_expandable)
8840         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8841         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8842         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8843         taking multidictionary argument.
8844         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8845         * block.h (struct block) <dict>: Change to multidictionary
8846         and rename `multidict'.
8847         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8848         symmisc.c: Update all dictionary references to multidictionary.
8849
8850 2019-01-10  Keith Seitz  <keiths@redhat.com>
8851
8852         PR gdb/23712
8853         PR symtab/23010
8854         * dictionary.c: Include unordered_map.
8855         (pending_to_vector): New function.
8856         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8857         Rewrite the non-"_1" functions to take vector instead
8858         of linked list.
8859         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8860         "new" _1 versions of the same name.
8861         (multidictionary): Define.
8862         (std::hash<enum language): New definition.
8863         (collate_pending_symbols_by_language, mdict_create_hashed)
8864         (mdict_create_hashed_expandable, mdict_create_linear)
8865         (mdict_create_linear_expandable, mdict_free)
8866         (find_language_dictionary, create_new_language_dictionary)
8867         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8868         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8869         (mdict_size, mdict_empty): New functions.
8870         * dictionary.h (mdict_iterator): Define.
8871
8872 2019-01-10  Pedro Alves  <palves@redhat.com>
8873
8874         * breakpoint.c (read_uploaded_action)
8875         (create_tracepoint_from_upload): Adjust to use
8876         gdb::unique_xmalloc_ptr.
8877         * ctf.c (ctf_write_uploaded_tp):
8878         (SET_ARRAY_FIELD): Use emplace_back.
8879         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8880         * tracefile-tfile.c (tfile_write_uploaded_tp):
8881         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8882         gdb::unique_xmalloc_ptr.
8883         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8884         at_string, cond_string, cmd_strings>: Replace char pointers
8885         with gdb::unique_xmalloc_ptr.
8886
8887 2019-01-10  Pedro Alves  <palves@redhat.com>
8888
8889         * solib-target.c (library_list_start_library): Don't xstrdup name.
8890
8891 2019-01-10  Pedro Alves  <palves@redhat.com>
8892
8893         * mdebugread.c (parse_partial_symbols): Use
8894         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8895
8896 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8897
8898         * linux-fork.c (scoped_switch_fork_info)
8899         <~scoped_switch_fork_info>: Fix incorrect variable name.
8900
8901 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8902
8903         * linux-fork.c (scoped_switch_fork_info)
8904         <scoped_switch_fork_info>: Make explicit.
8905         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8906
8907 2019-01-10  Tom Tromey  <tom@tromey.com>
8908
8909         * objfiles.h (objfile::reset_psymtabs): Update.
8910         * objfiles.c (objfile::objfile): Update.
8911         * psymtab.h (psymtab_storage::obstack): Update.
8912         (psymtab_storage::m_obstack): Use gdb::optional.
8913         (class psymtab_storage): Update comment.  Remove objfile
8914         parameter.
8915         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8916
8917 2019-01-10  Tom Tromey  <tom@tromey.com>
8918
8919         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8920         <free_psymtabs>: Now private.
8921         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8922         (allocate_psymtab): Use new method.
8923
8924 2019-01-10  Tom Tromey  <tom@tromey.com>
8925
8926         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8927         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8928         * mdebugread.c (parse_partial_symbols): Use
8929         allocate_dependencies.
8930         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8931         allocate_dependencies.
8932         (process_psymtab_comp_unit_reader)
8933         (build_type_psymtab_dependencies): Likewise.
8934         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8935
8936 2019-01-10  Tom Tromey  <tom@tromey.com>
8937
8938         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8939         PSYMBOL_SET_LANGUAGE.
8940         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8941
8942 2019-01-10  Tom Tromey  <tom@tromey.com>
8943
8944         * psymtab.h (psymtab_storage::obstack): New method.
8945         <m_obstack>: Rename from obstack; now private.
8946         * psymtab.c (psymtab_storage): Update.
8947         * dwarf2read.c (create_addrmap_from_index)
8948         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8949         Update.
8950
8951 2019-01-10  Tom Tromey  <tom@tromey.com>
8952
8953         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8954         * objfiles.h (objfile::reset_psymtabs): New method.
8955
8956 2019-01-10  Tom Tromey  <tom@tromey.com>
8957
8958         * symmisc.c (print_symbol_bcache_statistics): Update.
8959         (print_objfile_statistics): Update.
8960         * symfile.c (reread_symbols): Update.
8961         * psymtab.h (class psymtab_storage): New.
8962         * psymtab.c (psymtab_storage): New constructor.
8963         (~psymtab_storage): New destructor.
8964         (require_partial_symbols): Update.
8965         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8966         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8967         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8968         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8969         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8970         (start_psymtab_common, end_psymtab_common)
8971         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8972         (allocate_psymtab): Update.
8973         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8974         Update.
8975         (dump_psymtab_addrmap, maintenance_print_psymbols)
8976         (maintenance_check_psymtabs): Update.
8977         (class objfile_psymtabs): Move to objfiles.h.
8978         * psympriv.h (discard_psymtab): Now inline.
8979         (psymtab_discarder::psymtab_discarder): Update.
8980         (psymtab_discarder::~psymtab_discarder): Update.
8981         (ALL_OBJFILE_PSYMTABS): Rewrite.
8982         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8983         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8984         Remove fields.
8985         <partial_symtabs>: New field.
8986         (class objfile_psymtabs): Move from psymtab.h.  Update.
8987         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8988         psymbol_cache.
8989         (objfile::~objfile): Don't destroy psymbol_cache.
8990         * mdebugread.c (parse_partial_symbols): Update.
8991         * dwarf2read.c (create_addrmap_from_index)
8992         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8993         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8994         (add_partial_subprogram, dwarf2_ranges_read): Update.
8995         * dwarf-index-write.c (write_address_map)
8996         (write_one_signatured_type, recursively_write_psymbols)
8997         (class debug_names, class debug_names, write_psymtabs_to_index):
8998         Update.
8999
9000 2019-01-10  Tom Tromey  <tom@tromey.com>
9001
9002         * symtab.h (SYMBOL_SET_NAMES): Update.
9003         (symbol_set_names): Update.
9004         (MSYMBOL_SET_NAMES): Update.
9005         * symtab.c (symbol_set_names): Change argument to be an
9006         objfile_per_bfd_storage.
9007         * psymtab.c (add_psymbol_to_bcache): Update.
9008         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9009
9010 2019-01-10  Tom Tromey  <tom@tromey.com>
9011
9012         * symtab.c (create_demangled_names_hash): Change argument to be an
9013         objfile_per_bfd_storage.
9014         (symbol_set_names): Update.
9015
9016 2019-01-10  Tom Tromey  <tom@tromey.com>
9017
9018         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9019         init_psymbol_list.
9020         * psymtab.c (init_psymbol_list): Do nothing if already called.
9021         * psympriv.h (init_psymbol_list): Add comment.
9022         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9023         init_psymbol_list.
9024         * dbxread.c (dbx_symfile_read): Unconditionally call
9025         init_psymbol_list.
9026
9027 2019-01-10  Tom Tromey  <tom@tromey.com>
9028
9029         * xcoffread.c (scan_xcoff_symtab): Update.
9030         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9031         "where".
9032         * mdebugread.c (parse_partial_symbols)
9033         (handle_psymbol_enumerators): Update.
9034         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9035         * dbxread.c (read_dbx_symtab): Update.
9036         * psympriv.h (psymbol_placement): New enum.
9037         (add_psymbol_to_list): Update.
9038
9039 2019-01-10  Tom Tromey  <tom@tromey.com>
9040
9041         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9042         static_psymbols parameters.
9043         (scan_xcoff_symtab): Update.
9044         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9045         static_psymbols parameters.
9046         * psympriv.h (start_psymtab_common): Update.
9047         * mdebugread.c (parse_partial_symbols): Update.
9048         * dwarf2read.c (create_partial_symtab): Update.
9049         * dbxread.c (read_dbx_symtab): Update.
9050         (start_psymtab): Remove global_psymbols and static_psymbols
9051         parameters.
9052
9053 2019-01-10  Tom Tromey  <tom@tromey.com>
9054
9055         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9056         * psymtab.c (allocate_psymtab): Add comment.
9057         * psympriv.h (allocate_psymtab): Add comment.
9058         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9059         initializations.
9060         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9061
9062 2019-01-10  Tom Tromey  <tom@tromey.com>
9063
9064         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9065         Don't declare.
9066         * mipsread.c: Include mdebugread.h.
9067         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9068         Declare.
9069         * elfread.c: Include mdebugread.h.
9070
9071 2019-01-09  Tom Tromey  <tom@tromey.com>
9072
9073         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9074         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9075         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9076         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9077         (psym_lookup_symbol, psym_find_last_source_symtab)
9078         (psym_forget_cached_source_info, psym_print_stats)
9079         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9080         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9081         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9082         (psym_find_compunit_symtab_by_address)
9083         (maintenance_print_psymbols, maintenance_info_psymtabs)
9084         (maintenance_check_psymtabs): Use ranged for.
9085         * psymtab.h (class objfile_psymtabs): New.
9086         (require_partial_symbols): Return objfile_psymtabs.
9087         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9088
9089 2019-01-09  Tom Tromey  <tom@tromey.com>
9090
9091         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9092         (find_pc_mapped_section, list_overlays_command)
9093         (map_overlay_command, unmap_overlay_command)
9094         (simple_overlay_update): Use all_objfiles.
9095         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9096         * printcmd.c (info_symbol_command): Use all_objfiles.
9097         * objfiles.h (ALL_OBJSECTIONS): Remove.
9098         * maint.c (maintenance_translate_address): Use all_objfiles.
9099         * gcore.c (gcore_create_callback): Use all_objfiles.
9100         (objfile_find_memory_regions): Likewise.
9101
9102 2019-01-09  Tom Tromey  <tom@tromey.com>
9103
9104         * symtab.c (find_line_symtab, info_sources_command)
9105         (make_source_files_completion_list): Use objfile_compunits.
9106         * source.c (select_source_symtab): Use objfile_compunits.
9107         * objfiles.h (struct objfile): Update comment.
9108         (ALL_OBJFILES): Remove.
9109         (ALL_FILETABS): Remove.
9110         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9111         objfile_compunits.
9112
9113 2019-01-09  Tom Tromey  <tom@tromey.com>
9114
9115         * symmisc.c (print_objfile_statistics, dump_objfile)
9116         (maintenance_print_symbols): Use compunit_filetabs.
9117         * source.c (forget_cached_source_info_for_objfile): Use
9118         compunit_filetabs.
9119         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9120         (ALL_FILETABS): Use compunit_filetabs.
9121         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9122         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9123
9124 2019-01-09  Tom Tromey  <tom@tromey.com>
9125
9126         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9127         (compunit_filetabs): New.
9128         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9129         compunit_filetabs.
9130         (info_sources_command, make_source_files_completion_list): Remove
9131         declaration.
9132         * symmisc.c (print_objfile_statistics, dump_objfile)
9133         (maintenance_print_symbols): Remove declaration.
9134         (maintenance_info_symtabs): Use compunit_filetabs.
9135         (maintenance_info_line_tables): Likewise.
9136         * source.c (select_source_symtab): Change local variable name.
9137         (forget_cached_source_info_for_objfile): Remove declaration.
9138         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9139         * objfiles.c (objfile_relocate1): Remove declaration.
9140         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9141         declaration.
9142         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9143         * coffread.c (coff_symtab_read): Remove declaration.
9144         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9145         compunit_filetabs.
9146
9147 2019-01-09  Tom Tromey  <tom@tromey.com>
9148
9149         * symtab.c (lookup_objfile_from_block)
9150         (find_pc_sect_compunit_symtab, search_symbols)
9151         (default_collect_symbol_completion_matches_break_on): Use
9152         objfile_compunits.
9153         * objfiles.h (ALL_COMPUNITS): Remove.
9154         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9155         * cp-support.c (add_symbol_overload_list_qualified): Use
9156         objfile_compunits.
9157         * ada-lang.c (ada_collect_symbol_completion_matches)
9158         (ada_add_global_exceptions): Use objfile_compunits.
9159
9160 2019-01-09  Tom Tromey  <tom@tromey.com>
9161
9162         * source.c (select_source_symtab)
9163         (forget_cached_source_info_for_objfile): Remove declaration.
9164         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9165         declaration.
9166         * maint.c (count_symtabs_and_blocks): Remove declaration.
9167         * cp-support.c (add_symbol_overload_list_qualified): Remove
9168         declaration.
9169         * coffread.c (coff_symtab_read): Remove declaration.
9170         * symtab.c (lookup_symbol_in_objfile_symtabs)
9171         (basic_lookup_transparent_type_1): Use objfile_compunits.
9172         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9173         (info_sources_command, search_symbols)
9174         (default_collect_symbol_completion_matches_break_on)
9175         (make_source_files_completion_list): Remove declaration.
9176         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9177         (ada_collect_symbol_completion_matches)
9178         (ada_add_global_exceptions): Remove declaration.
9179         * linespec.c (iterate_over_all_matching_symtabs): Use
9180         objfile_compunits.
9181         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9182         (class objfile_compunits): New.
9183         (ALL_COMPUNITS): Use objfile_compunits.
9184         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9185         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9186         objfile_compunits.
9187         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9188
9189 2019-01-09  Tom Tromey  <tom@tromey.com>
9190
9191         * symtab.c (search_symbols)
9192         (default_collect_symbol_completion_matches_break_on): Use
9193         objfile_msymbols.
9194         * ada-lang.c (ada_lookup_simple_minsym)
9195         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9196         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9197         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9198         objfile_msymbols.
9199         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9200         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9201         * objc-lang.c (find_methods): Use objfile_msymbols.
9202         (info_selectors_command, info_classes_command): Likewise.
9203         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9204         * objfiles.h (class objfile_msymbols): New.
9205         (ALL_OBJFILE_MSYMBOLS): Remove.
9206         (ALL_MSYMBOLS): Remove.
9207
9208 2019-01-09  Tom Tromey  <tom@tromey.com>
9209
9210         * common/next-iterator.h (next_adapter): Add Iterator template
9211         parameter.
9212         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9213         (class all_objfiles_safe): New.
9214         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9215         * objfiles.c (put_objfile_before): Update comment.
9216         (add_separate_debug_objfile): Likewise.
9217         (free_all_objfiles): Use all_objfiles_safe.
9218         (objfile_purge_solibs): Likewise.
9219
9220 2019-01-09  Tom Tromey  <tom@tromey.com>
9221
9222         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9223         (expand_symtab_containing_pc, lookup_static_symbol)
9224         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9225         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9226         all_objfiles.
9227         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9228         * breakpoint.c (create_overlay_event_breakpoint)
9229         (create_longjmp_master_breakpoint)
9230         (create_std_terminate_master_breakpoint)
9231         (create_exception_master_breakpoint): Use all_objfiles.
9232         * linux-thread-db.c (try_thread_db_load_from_pdir)
9233         (has_libpthread): Use all_objfiles.
9234         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9235         * linespec.c (iterate_over_all_matching_symtabs)
9236         (search_minsyms_for_name): Use all_objfiles.
9237         * maint.c (maintenance_info_sections): Use all_objfiles.
9238         * main.c (captured_main_1): Use all_objfiles.
9239         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9240         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9241         * guile/scm-pretty-print.c
9242         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9243         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9244         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9245         (maintenance_print_msymbols): Use all_objfiles.
9246         * source.c (select_source_symtab): Use all_objfiles.
9247         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9248         * symfile.c (remove_symbol_file_command)
9249         (expand_symtabs_matching, map_symbol_filenames): Use
9250         all_objfiles.
9251         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9252         all_objfiles.
9253         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9254         * objc-lang.c (find_methods): Use all_objfiles.
9255         * objfiles.c (have_partial_symbols, have_full_symbols)
9256         (have_minimal_symbols, qsort_cmp)
9257         (default_iterate_over_objfiles_in_search_order): Use
9258         all_objfiles.
9259         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9260         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9261         (maintenance_check_psymtabs): Use all_objfiles.
9262         (ALL_PSYMTABS): Remove.
9263         * compile/compile-object-run.c (do_module_cleanup): Use
9264         all_objfiles.
9265         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9266         * cp-support.c (add_symbol_overload_list_qualified): Use
9267         all_objfiles.
9268         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9269         Use all_objfiles.
9270         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9271         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9272         all_objfiles.
9273         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9274         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9275         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9276         Uses all_objfiles.
9277         * solib.c (solib_read_symbols): Use all_objfiles
9278
9279 2019-01-09  Tom Tromey  <tom@tromey.com>
9280
9281         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9282         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9283         all_objfiles.
9284         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9285         * symmisc.c (print_symbol_bcache_statistics)
9286         (print_objfile_statistics, maintenance_print_objfiles)
9287         (maintenance_info_symtabs, maintenance_check_symtabs)
9288         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9289         all_objfiles.
9290         * source.c (forget_cached_source_info): Use all_objfiles.
9291         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9292         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9293         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9294         * objfiles.c (update_section_map): Use all_objfiles.
9295         (shared_objfile_contains_address_p): Likewise.
9296         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9297         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9298
9299 2019-01-09  Tom Tromey  <tom@tromey.com>
9300
9301         * common/next-iterator.h: New file.
9302         * objfiles.h (class all_objfiles): New.
9303         (struct objfile_iterator): New.
9304
9305 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9306
9307         * NEWS: Move the description of the changed "frame", "select-frame",
9308          and "info frame" commands to the Changed commands section.
9309
9310 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9311
9312         * gdbtypes.c (check_stub_method_group): Remove handling of old
9313         mangling schemes.
9314         * linespec.c (find_methods): Likewise.
9315         * stabsread.c (read_member_functions): Likewise.
9316         * valops.c (search_struct_method): Likewise.
9317         (value_struct_elt_for_reference): Likewise.
9318         * NEWS: Mention this change.
9319
9320 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9321
9322         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9323         print_source_lines.
9324         * source.c (print_source_lines_base): Update line number check.
9325         (print_source_lines): New function.
9326         (source_lines_range::source_lines_range): New function.
9327         * source.h (class source_lines_range): New class.
9328         (print_source_lines): New declaration.
9329
9330 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9331
9332         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9333
9334 2019-01-08  Tom Tromey  <tom@tromey.com>
9335             Simon Marchi  <simon.marchi@ericsson.com>
9336
9337         PR gdb/24060
9338         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9339         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9340         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9341         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9342         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9343         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9344
9345 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9346
9347         * source.c (select_source_symtab): Move header comment to
9348         declaration in source.h.
9349         (forget_cached_source_info_for_objfile): Likewise.
9350         (forget_cached_source_info): Likewise.
9351         (identify_source_line): Likewise.
9352         * source.h (identify_source_line): Move declaration from symtab.h
9353         and add comment from source.c
9354         (print_source_lines): Likewise.
9355         (forget_cached_source_info_for_objfile): Likewise.
9356         (forget_cached_source_info): Likewise.
9357         (select_source_symtab): Likewise.
9358         (enum print_source_lines_flag): Move definition from symtab.h.
9359         * symtab.h (identify_source_line): Move declaration to source.h.
9360         (print_source_lines): Likewise.
9361         (forget_cached_source_info_for_objfile): Likewise.
9362         (forget_cached_source_info): Likewise.
9363         (select_source_symtab): Likewise.
9364         (enum print_source_lines_flag): Move definition to source.h.
9365         * tui/tui-hooks.c: Add 'source.h' include.
9366
9367 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9368
9369         * source.c (print_source_lines_base): Handle requests to print
9370         reverse line number sequences, and guard against empty lines
9371         string.
9372
9373 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9374
9375         * source.c (print_source_lines_base): Fix skip of '\r' if next
9376         character is '\n'.
9377
9378 2019-01-06  Tom Tromey  <tom@tromey.com>
9379
9380         * c-exp.y (struct c_parse_state) <macro_original_text,
9381         expansion_obstack>: New member.
9382         (macro_original_text, expansion_obstack): Remove globals.
9383         (scan_macro_expansion, scanning_macro_expansion)
9384         (finished_macro_expansion): Update.
9385         (scan_macro_cleanup): Remove.
9386         (yylex, c_parse): Update.
9387
9388 2019-01-06  Tom Tromey  <tom@tromey.com>
9389
9390         * c-exp.y (struct c_parse_state) <strings>: New member.
9391         (operator_stoken): Update.
9392
9393 2019-01-06  Tom Tromey  <tom@tromey.com>
9394
9395         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9396         (union type_stack_elt) <typelist_val>: Now a pointer to
9397         std::vector.
9398         (type_stack_cleanup): Don't declare.
9399         (push_typelist): Update.
9400         * parse.c (pop_typelist): Return a std::vector.
9401         (push_typelist): Take a std::vector.
9402         (follow_types): Update.  Do not free args.
9403         (type_stack_cleanup): Remove.
9404         * c-exp.y (struct c_parse_state): New.
9405         (cpstate): New global.
9406         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9407         (nonempty_typelist): Update.
9408         (func_mod): Create a new vector.
9409         (c_parse): Create a c_parse_state.
9410         (check_parameter_typelist): Do not delete params.
9411         (function_method): Update.  Do not delete type_list.
9412
9413 2019-01-06  Tom Tromey  <tom@tromey.com>
9414
9415         PR gdb/28155:
9416         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9417         check_typedef.
9418         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9419         (print_return_value): Likewise.
9420
9421 2019-01-05  Tom Tromey  <tom@tromey.com>
9422
9423         * contrib/cleanup_check.py: Remove.
9424         * contrib/gcc-with-excheck: Remove.
9425         * contrib/exsummary.py: Remove.
9426         * contrib/excheck.py: Remove.
9427
9428 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9429
9430         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9431         NULL. Initialize tpprev to NULL instead of assigning it
9432         to NULL on the next statement.
9433         * windows-nat.c (windows_delete_thread): Remove check for
9434         main_thread_id before printing thread exit notifications.
9435         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9436         Remove thread ID check against main_thread_id.
9437         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9438         windows_delete_thread.
9439         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9440
9441 2019-01-04  Tom Tromey  <tom@tromey.com>
9442
9443         * compile/compile.c (_initialize_compile): Use upper case for
9444         metasyntactic variables.
9445         * symmisc.c (_initialize_symmisc): Use upper case for
9446         metasyntactic variables.
9447         * psymtab.c (_initialize_psymtab): Use upper case for
9448         metasyntactic variables.
9449         * demangle.c (demangle_command): Use upper case for metasyntactic
9450         variables.
9451         (_initialize_demangler): Likewise.
9452         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9453         variables.
9454
9455 2019-01-03  Tom Tromey  <tom@tromey.com>
9456
9457         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9458
9459 2019-01-03  Tom Tromey  <tom@tromey.com>
9460
9461         * python/py-symtab.c (salpy_str): Update.
9462         (struct salpy_sal_object) <symtab>: Now a PyObject.
9463         (salpy_dealloc): Update.
9464         (del_objfile_sal): Use gdbpy_ref.
9465
9466 2019-01-03  Tom Tromey  <tom@tromey.com>
9467
9468         * python/py-type.c (convert_field): Use new_reference.  Return
9469         gdbpy_ref.
9470         (make_fielditem): Return gdbpy_ref.
9471         (typy_fields): Update.
9472         (typy_getitem): Update.
9473         (field_name): Return gdbpy_ref.  Use new_reference.
9474         (typy_iterator_iternext): Update.
9475
9476 2019-01-03  Tom Tromey  <tom@tromey.com>
9477
9478         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9479
9480 2019-01-03  Tom Tromey  <tom@tromey.com>
9481
9482         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9483         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9484         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9485         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9486         (pspy_set_type_printers): Likewise.
9487         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9488         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9489         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9490         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9491         (objfpy_set_type_printers): Likewise.
9492
9493 2019-01-03  Tom Tromey  <tom@tromey.com>
9494
9495         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9496         (gdbpy_print_stack): Use gdbpy_err_fetch.
9497         * python/python-internal.h (class gdbpy_err_fetch): New class.
9498         (class gdbpy_enter) <m_error_type, m_error_value,
9499         m_error_traceback>: Remove.
9500         <m_error>: New member.
9501         (gdbpy_exception_to_string): Don't declare.
9502         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9503         * python/py-value.c (convert_value_from_python): Use
9504         gdbpy_err_fetch.
9505         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9506         gdbpy_exception_to_string.
9507         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9508         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9509         gdbpy_err_fetch.
9510
9511 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9512
9513         * linux-nat.c (delete_lwp_cleanup): Delete.
9514         (struct lwp_deleter): New struct.
9515         (lwp_info_up): New typedef.
9516         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9517         lwp_info_up.
9518
9519 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9520
9521         * linux-fork.c (class scoped_switch_fork_info): New class.
9522         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9523
9524 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9525
9526         * valops.c (find_overload_match): Remove use of null_cleanup, and
9527         calls to do_cleanups.
9528
9529 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9530
9531         * compile/compile-cplus-types.c
9532         (compile_cplus_instance::decl_name): Handle changes to
9533         cp_func_name.
9534         * cp-support.c (cp_func_name): Update header comment, update
9535         return type.
9536         * cp-support.h (cp_func_name): Update return type in declaration.
9537         * valops.c (find_overload_match): Move temp_func local to top
9538         level of function and change its type.  Use temp_func to hold and
9539         delete temporary string obtained from cp_func_name.
9540
9541 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9542
9543         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9544         gdb::char_vector, remove cleanup, and update uses of `msg`.
9545
9546 2019-01-03  Jim Wilson  <jimw@sifive.com>
9547
9548         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9549
9550 2019-01-02  Tom Tromey  <tom@tromey.com>
9551
9552         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9553         (tdesc_parse_xml): Remove cleanups.
9554         * target-descriptions.h (make_cleanup_free_target_description):
9555         Don't declare.
9556         (target_desc_deleter): New struct.
9557         (target_desc_up): New typedef.
9558         * target-descriptions.c (target_desc_deleter::operator()): Rename
9559         from free_target_description.
9560         (make_cleanup_free_target_description): Remove.
9561
9562 2019-01-02  Tom Tromey  <tom@tromey.com>
9563
9564         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9565         constructor, destructor.
9566         (linespec_parser): Remove typedef.
9567         (~linespec_parser): Rename from linespec_parser_delete.
9568         (linespec_lex_to_end, linespec_complete_label)
9569         (linespec_complete): Update.
9570         (decode_line_full): Remove cleanups.
9571         (decode_line_1): Update.
9572
9573 2019-01-02  Tom Tromey  <tom@tromey.com>
9574
9575         * python/python-internal.h (inferior_to_inferior_object): Change
9576         return type.
9577         * python/py-exitedevent.c (create_exited_event_object): Update.
9578         * python/py-inferior.c (inferior_to_inferior_object): Return
9579         gdbpy_ref.
9580         (python_new_inferior, python_inferior_deleted)
9581         (thread_to_thread_object, delete_thread_object)
9582         (build_inferior_list, gdbpy_selected_inferior): Update.
9583         * python/py-infthread.c (create_thread_object): Update.  Also fail
9584         if inferior_to_inferior_object fails.
9585
9586 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9587
9588         * inferior.h (class inferior) <displaced_step_state>: New field.
9589         * infrun.h (struct displaced_step_state): Move here from
9590         infrun.c.  Initialize fields, add constructor.
9591         <inf>: Remove field.
9592         <reset>: New method.
9593         * infrun.c (struct displaced_step_inferior_state): Move to
9594         infrun.h.
9595         (displaced_step_inferior_states): Remove.
9596         (get_displaced_stepping_state): Adust.
9597         (displaced_step_in_progress_any_inferior): Adjust.
9598         (displaced_step_in_progress_thread): Adjust.
9599         (displaced_step_in_progress): Adjust.
9600         (add_displaced_stepping_state): Remove.
9601         (get_displaced_step_closure_by_addr): Adjust.
9602         (remove_displaced_stepping_state): Remove.
9603         (infrun_inferior_exit): Call displaced_step_state.reset.
9604         (use_displaced_stepping): Don't check for NULL.
9605         (displaced_step_prepare_throw): Call
9606         get_displaced_stepping_state.
9607         (displaced_step_fixup): Don't check for NULL.
9608         (prepare_for_detach): Don't check for NULL.
9609
9610 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9611
9612         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9613          in case of call that did not complete.
9614
9615 2019-01-02  Andrey Utkin  <autkin@undo.io>
9616
9617         * symfile.c (find_separate_debug_file): Fix search of debug files for
9618         remote debuggee.
9619
9620 2019-01-02  Tom Tromey  <tom@tromey.com>
9621
9622         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9623         indentation.
9624         * python/py-frame.c (frapy_older): Remove cast.
9625         (frapy_newer): Likewise.
9626         * python/py-breakpoint.c (local_setattro): Remove cast.
9627         * python/py-arch.c (archpy_name): Remove local variable.
9628         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9629
9630 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9631
9632         * unittests/basic_string_view/element_access/char/empty.cc:
9633         Fix year range in copyright header.
9634
9635 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9636
9637         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9638         Delete.
9639         <operator==>: Update with for removed field.
9640         <hash>: Likewise.
9641         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9642         <isa_features>: ...this.
9643         <abi_features>: New field.
9644         (riscv_isa_flen): Update comment.
9645         (riscv_abi_xlen): New declaration.
9646         (riscv_abi_flen): New declaration.
9647         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9648         isa_features.
9649         (riscv_abi_xlen): New function.
9650         (riscv_isa_flen): Update to get answer from isa_features.
9651         (riscv_abi_flen): New function.
9652         (riscv_has_fp_abi): Update to get answer from abi_features.
9653         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9654         xlen and flen.
9655         (riscv_call_info) <xlen, flen>: Update comment.
9656         (riscv_call_arg_struct): Remove invalid assertions
9657         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9658         is removed.
9659         (riscv_gdbarch_init): Gather isa features and abi features
9660         separately, ensure both match on the gdbarch when reusing an old
9661         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9662         a target with 64-bit float hardware.
9663
9664 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9665
9666         * source.c (search_command_helper): Stop reverse search
9667         when line 1 has been searched.
9668
9669 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9670
9671         * record-full.c (record_full_base_target::close): Rewrite
9672         record_full_core_buf_list free logic.
9673
9674 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9675
9676         * break-catch-syscall.c (print_one_catch_syscall): xfree
9677         the last text.
9678
9679 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9680
9681         * top.c (print_gdb_version): Update Copyright year in version
9682         message.
9683
9684 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9685
9686         Update copyright year range in all GDB files.
9687
9688 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9689
9690         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9691
9692 For older changes see ChangeLog-2018.
9693 \f
9694 Local Variables:
9695 mode: change-log
9696 left-margin: 8
9697 fill-column: 74
9698 version-control: never
9699 coding: utf-8
9700 End:
9701