gdb/ChangeLog

   1 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
   2
   3         * NEWS: Mention two argument form of gdb.Value constructor.
   4         * python/py-value.c (convert_buffer_and_type_to_value): New
   5         function.
   6         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
   7         Add support for handling an optional second argument.  Call
   8         convert_buffer_and_type_to_value as appropriate.
   9         * python/python-internal.h (Py_buffer_deleter): New struct.
  10         (Py_buffer_up): New typedef.
  11
  12 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
  13
  14         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
  15         instead of releasing ownership.
  16
  17 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
  18
  19         * dwarf2read.c (open_and_init_dwp_file): Call
  20         elf_numsections instead of bfd_count_sections to initialize
  21         dwp_file->num_sections.
  22
  23 2019-02-25  Tom Tromey  <tromey@adacore.com>
  24
  25         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
  26
  27 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
  28
  29         * gcore.in: Add '--readnever' option when invoking GDB.
  30
  31 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  32
  33         * MAINTAINERS: Update my email address.
  34
  35 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  36
  37         * build-id.c (build_id_to_debug_bfd_1): New function.
  38         (build_id_to_debug_bfd): Look for separate debug file in
  39         sysroot.
  40
  41 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  42
  43         * gdbarch.sh: Update the copyright year range that is placed into
  44         generated files.
  45
  46 2019-02-22  Keith Seitz  <keiths@redhat.com>
  47
  48         PR symtab/23853
  49         * linespec.c (create_sals_line_offset): Search for the default
  50         symtab's filename instead of its fullname.
  51
  52 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  53
  54         * NEWS: Update style defaults.
  55
  56 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  57
  58         * main.c (captured_main_1): Disable styling in batch mode.
  59
  60 2019-02-20  Tom Tromey  <tom@tromey.com>
  61
  62         * symtab.c (symtab_symbol_info): Fix typos.
  63
  64 2019-02-20  Tom Tromey  <tromey@adacore.com>
  65
  66         * findcmd.c (_initialize_mem_search): Use upper case for
  67         metasyntactic variables.
  68
  69 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
  70
  71         * aarch64-tdep.c (aarch64_add_reggroups): New function.
  72         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
  73
  74 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
  75
  76         * top.h (source_file_name): Change to std::string.
  77         * top.c (source_file_name): Likewise.
  78         (command_line_input): Adjust.
  79         * cli/cli-script.c (script_from_file): Adjust.
  80
  81 2019-02-19  Tom Tromey  <tromey@adacore.com>
  82
  83         * ravenscar-thread.c
  84         (ravenscar_thread_target::update_thread_list): Don't call
  85         ada_build_task_list.
  86         * ada-lang.h (ada_build_task_list): Don't declare.
  87         * ada-tasks.c (struct ada_tasks_inferior_data)
  88         <task_list_valid_p>: Now bool.
  89         (read_known_tasks, ada_task_list_changed)
  90         (ada_tasks_invalidate_inferior_data): Update.
  91         (read_known_tasks_array): Return bool.
  92         (read_known_tasks_list): Likewise.
  93         (read_known_tasks): Return void.
  94         (ada_build_task_list): Now static.
  95
  96 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  97
  98         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
  99         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 100
 101 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 102
 103         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 104         variant for ada_tasks_pspace_data_handle and
 105         ada_tasks_inferior_data_handle.
 106         (ada_tasks_pspace_data_cleanup): New function.
 107         (ada_tasks_inferior_data_cleanup): New function.
 108
 109 2019-02-17  Tom Tromey  <tom@tromey.com>
 110
 111         * macrotab.h (macro_source_fullname): Return a std::string.
 112         * macrotab.c (macro_include, check_for_redefinition)
 113         (macro_undef, macro_lookup_definition, foreach_macro)
 114         (foreach_macro_in_scope): Update.
 115         (macro_source_fullname): Return a std::string.
 116         * macrocmd.c (show_pp_source_pos): Update.
 117
 118 2019-02-17  Tom Tromey  <tom@tromey.com>
 119
 120         * macrocmd.c (show_pp_source_pos): Style the file names.
 121
 122 2019-02-17  Tom Tromey  <tom@tromey.com>
 123
 124         PR tui/24197:
 125         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 126
 127 2019-02-17  Tom Tromey  <tom@tromey.com>
 128
 129         * ada-lang.c (user_select_syms): Use filtered printing.
 130         * utils.c (wrap_style): New global.
 131         (desired_style): Remove.
 132         (emit_style_escape): Add stream parameter.
 133         (set_output_style, reset_terminal_style, prompt_for_continue):
 134         Update.
 135         (flush_wrap_buffer): Only flush gdb_stdout.
 136         (wrap_here): Set wrap_style.
 137         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 138         treat escape sequences as a character.  Change when wrap buffer is
 139         flushed.
 140         (fputs_styled): Do not set the output style when the default is
 141         requested.
 142         * ui-style.h (struct ui_file_style) <is_default>: New method.
 143         * source.c (print_source_lines_base): Emit escape sequences in one
 144         piece.
 145
 146 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 147
 148         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 149         integers and enumeration types.
 150
 151 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 152
 153         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 154         instead of lookup_symbol_in_language
 155         (do_exact_match): New function.
 156         (ada_get_symbol_name_matcher): Return do_exact_match when
 157         doing a verbatim match.
 158
 159 2019-02-15  Tom Tromey  <tromey@adacore.com>
 160
 161         * ravenscar-thread.c (ravenscar_thread_target::resume)
 162         (ravenscar_thread_target::wait): Special case wildcard requests.
 163
 164 2019-02-15  Tom Tromey  <tromey@adacore.com>
 165
 166         * ravenscar-thread.c (base_ptid): Remove.
 167         (struct ravenscar_thread_target) <close>: New method.
 168         <m_base_ptid>: New member.
 169         <update_inferior_ptid, active_task, task_is_currently_active,
 170         runtime_initialized>: Declare methods.
 171         <ravenscar_thread_target>: Add constructor.
 172         (ravenscar_thread_target::task_is_currently_active)
 173         (ravenscar_thread_target::update_inferior_ptid)
 174         (ravenscar_runtime_initialized): Rename.  Now methods.
 175         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 176         (ravenscar_thread_target::update_thread_list): Update.
 177         (ravenscar_thread_target::active_task): Now method.
 178         (ravenscar_thread_target::store_registers)
 179         (ravenscar_thread_target::prepare_to_store)
 180         (ravenscar_thread_target::prepare_to_store)
 181         (ravenscar_thread_target::mourn_inferior): Update.
 182         (ravenscar_inferior_created): Use "new" to create target.
 183         (ravenscar_thread_target::get_ada_task_ptid): Update.
 184         (_initialize_ravenscar): Don't initialize base_ptid.
 185         (ravenscar_ops): Remove global.
 186
 187 2019-02-15  Tom Tromey  <tromey@adacore.com>
 188
 189         * target.h (push_target): Declare new overload.
 190         * target.c (push_target): New overload, taking an rvalue reference.
 191         * remote.c (remote_target::open_1): Use push_target overload.
 192         * corelow.c (core_target_open): Use push_target overload.
 193
 194 2019-02-15  Tom Tromey  <tromey@adacore.com>
 195
 196         * ravenscar-thread.c (is_ravenscar_task)
 197         (ravenscar_task_is_currently_active): Return bool.
 198         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 199         (_initialize_ravenscar): Remove "(void)".
 200         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 201         Return bool.
 202
 203 2019-02-15  Tom Tromey  <tromey@adacore.com>
 204
 205         * ravenscar-thread.c (ravenscar_runtime_initializer)
 206         (has_ravenscar_runtime, get_running_thread_id)
 207         (ravenscar_thread_target::resume): Fix indentation.
 208
 209 2019-02-15  Tom Tromey  <tromey@adacore.com>
 210
 211         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 212         from ravenscar_arch_ops.
 213         (sparc_ravenscar_ops::fetch_registers)
 214         (sparc_ravenscar_ops::store_registers): Now methods.
 215         (sparc_ravenscar_prepare_to_store): Remove.
 216         (sparc_ravenscar_ops): Redefine.
 217         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 218         methods and destructor.  Remove members.
 219         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 220         (ravenscar_thread_target::store_registers)
 221         (ravenscar_thread_target::prepare_to_store): Update.
 222         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 223         Remove.
 224         (struct ppc_ravenscar_powerpc_ops): Derive from
 225         ravenscar_arch_ops.
 226         (ppc_ravenscar_powerpc_ops::fetch_registers)
 227         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 228         (ppc_ravenscar_powerpc_ops): Redefine.
 229         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 230         (ppc_ravenscar_e500_ops::fetch_registers)
 231         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 232         (ppc_ravenscar_e500_ops): Redefine.
 233         * aarch64-ravenscar-thread.c
 234         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 235         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 236         (aarch64_ravenscar_fetch_registers)
 237         (aarch64_ravenscar_store_registers): Now methods.
 238         (aarch64_ravenscar_ops): Redefine.
 239
 240 2019-02-15  Tom Tromey  <tromey@adacore.com>
 241
 242         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 243         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 244         (ravenscar_thread_target::stopped_by_watchpoint)
 245         (ravenscar_thread_target::stopped_data_address)
 246         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 247
 248 2019-02-15  Tom Tromey  <tromey@adacore.com>
 249
 250         * ravenscar-thread.c: Fix some typos.
 251
 252 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 253             Tom Tromey  <tromey@adacore.com>
 254
 255         * ada-lang.c (ada_exception_sal): Change addr_string to a
 256         std::string.
 257         (create_ada_exception_catchpoint): Update.
 258
 259 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 260             Tom Tromey  <tromey@adacore.com>
 261
 262         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 263         (bp_location_ops): Remove.
 264         (base_breakpoint_allocate_location): Update.
 265         (free_bp_location): Update.
 266         * ada-lang.c (class ada_catchpoint_location)
 267         <ada_catchpoint_location>: Remove ops parameter.
 268         (ada_catchpoint_location_dtor): Remove.
 269         (ada_catchpoint_location_ops): Remove.
 270         (allocate_location_exception): Update.
 271         * breakpoint.h (struct bp_location_ops): Remove.
 272         (class bp_location) <bp_location>: Remove bp_location_ops
 273         parameter.
 274         <~bp_location>: Add destructor.
 275         <ops>: Remove.
 276
 277 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 278             Pedro Alves  <palves@redhat.com>
 279
 280         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 281         'PATH_MAX'.
 282
 283 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 284             Samuel Thibault  <samuel.thibault@gnu.org>
 285             Thomas Schwinge  <thomas@codesourcery.com>
 286
 287         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 288         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 289
 290 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 291
 292         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 293         (check_empty): Use "const char *".
 294
 295         * gnu-nat.c (gnu_nat_target::detach): Instead of
 296         'detach_inferior (pid)' call
 297         'detach_inferior (find_inferior_pid (pid))'.
 298
 299         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 300         'nat/fork-inferior.o'.
 301         * gnu-nat.c: #include "nat/fork-inferior.h".
 302
 303         * gnu-nat.c (gnu_nat_target::detach): Instead of
 304         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 305         * gnu-nat.h: #include "inf-child.h".
 306         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 307         'i386_gnu_nat_target::fetch_registers'.
 308         (gnu_store_registers): Rename/move to
 309         'i386_gnu_nat_target::store_registers'.
 310
 311         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 312         * gnu-nat.h (mach_thread_info): New function.
 313         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 314
 315         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 316
 317 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 318
 319         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 320
 321 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 322
 323         * windows-nat.c (windows_add_thread): Add new parameter
 324         "main_thread_p" with default value set to false.  Update
 325         function documentation as well as all callers.
 326         (windows_delete_thread): Likewise.
 327         (fake_create_process): Update call to windows_add_thread.
 328         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 329         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 330         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 331         call to windows_delete_thread.
 332
 333 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 334
 335         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 336
 337 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 338
 339         * symfile.c (find_separate_debug_file): Use canonical path of
 340         sysroot with child_path instead of gdb_sysroot if it is valid.
 341
 342 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 343
 344         * symfile.c (find_separate_debug_file): Use child_path to
 345         determine if an object file is under a sysroot.
 346
 347 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 348
 349         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 350         unittests/child-path-selftests.c.
 351         * common/pathstuff.c (child_path): New function.
 352         * common/pathstuff.h (child_path): New prototype.
 353         * unittests/child-path-selftests.c: New file.
 354
 355 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 356
 357         * symfile.c (find_separate_debug_file): Look for separate debug
 358         files in debug directories under the sysroot.
 359
 360 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 361
 362         * symtab.h (struct minimal_symbol data_p): New const method.
 363         (struct minimal_symbol text_p): Likewise.
 364         * symtab.c (output_source_filename): Use file name style
 365         to print file name.
 366         (print_symbol_info): Likewise.
 367         (print_msymbol_info): Use address style to print addresses.
 368         Use function name style to print executable text symbols.
 369         (expand_symtab_containing_pc): Use data_p.
 370         (find_pc_sect_compunit_symtab): Likewise.
 371
 372 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 373
 374         * breakpoint.c (describe_other_breakpoints): Use address style
 375         to print addresses.
 376         (say_where): Likewise.
 377
 378 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 379
 380         * ada-typeprint.c (print_func_type): Print function name
 381         style to print function name.
 382         * c-typeprint.c (c_print_type_1): Likewise.
 383
 384 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 385
 386         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 387         for execve.
 388
 389 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 390
 391         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 392         type_stack.
 393
 394 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 395
 396         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 397         TYPE_CODE_REF types.
 398
 399 2019-02-08  Jim Wilson  <jimw@sifive.com>
 400
 401         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 402         (riscv_linux_fregset): New.
 403         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 404
 405 2019-02-07  Tom Tromey  <tom@tromey.com>
 406
 407         * thread.c (thread_cancel_execution_command): Update.
 408         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 409         methods.
 410         (struct thread_fsm_ops): Remove.
 411         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 412         (thread_fsm_should_stop, thread_fsm_return_value)
 413         (thread_fsm_set_finished, thread_fsm_finished_p)
 414         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 415         Don't declare.
 416         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 417         * infrun.c (clear_proceed_status_thread)
 418         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 419         (print_stop_event): Update.
 420         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 421         Add constructor.
 422         (step_command_fsm_ops): Remove.
 423         (new_step_command_fsm): Remove.
 424         (step_1): Update.
 425         (step_command_fsm::should_stop): Rename from
 426         step_command_fsm_should_stop.
 427         (step_command_fsm::clean_up): Rename from
 428         step_command_fsm_clean_up.
 429         (step_command_fsm::do_async_reply_reason): Rename from
 430         step_command_fsm_async_reply_reason.
 431         (struct until_next_fsm): Inherit from thread_fsm.  Add
 432         constructor.
 433         (until_next_fsm_ops): Remove.
 434         (new_until_next_fsm): Remove.
 435         (until_next_fsm::should_stop): Rename from
 436         until_next_fsm_should_stop.
 437         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 438         (until_next_fsm::do_async_reply_reason): Rename from
 439         until_next_fsm_async_reply_reason.
 440         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 441         constructor.  Change type of breakpoint.
 442         (finish_command_fsm_ops): Remove.
 443         (new_finish_command_fsm): Remove.
 444         (finish_command_fsm::should_stop): Rename from
 445         finish_command_fsm_should_stop.
 446         (finish_command_fsm::clean_up): Rename from
 447         finish_command_fsm_clean_up.
 448         (finish_command_fsm::return_value): Rename from
 449         finish_command_fsm_return_value.
 450         (finish_command_fsm::do_async_reply_reason): Rename from
 451         finish_command_fsm_async_reply_reason.
 452         (finish_command): Update.
 453         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 454         Add constructor.
 455         (call_thread_fsm_ops): Remove.
 456         (call_thread_fsm::call_thread_fsm): Rename from
 457         new_call_thread_fsm.
 458         (call_thread_fsm::should_stop): Rename from
 459         call_thread_fsm_should_stop.
 460         (call_thread_fsm::should_notify_stop): Rename from
 461         call_thread_fsm_should_notify_stop.
 462         (run_inferior_call, call_function_by_hand_dummy): Update.
 463         * cli/cli-interp.c (should_print_stop_to_console): Update.
 464         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 465         Add constructor.  Change type of location_breakpoint,
 466         caller_breakpoint.
 467         (until_break_fsm_ops): Remove.
 468         (new_until_break_fsm): Remove.
 469         (until_break_fsm::should_stop): Rename from
 470         until_break_fsm_should_stop.
 471         (until_break_fsm::clean_up): Rename from
 472         until_break_fsm_clean_up.
 473         (until_break_fsm::do_async_reply_reason): Rename from
 474         until_break_fsm_async_reply_reason.
 475         (until_break_command): Update.
 476         * thread-fsm.c: Remove.
 477         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 478
 479 2019-02-07  Tom Tromey  <tom@tromey.com>
 480
 481         * yy-remap.h: Add include guard.
 482         * xtensa-tdep.h: Add include guard.
 483         * xcoffread.h: Rename include guard.
 484         * varobj-iter.h: Add include guard.
 485         * tui/tui.h: Rename include guard.
 486         * tui/tui-winsource.h: Rename include guard.
 487         * tui/tui-wingeneral.h: Rename include guard.
 488         * tui/tui-windata.h: Rename include guard.
 489         * tui/tui-win.h: Rename include guard.
 490         * tui/tui-stack.h: Rename include guard.
 491         * tui/tui-source.h: Rename include guard.
 492         * tui/tui-regs.h: Rename include guard.
 493         * tui/tui-out.h: Rename include guard.
 494         * tui/tui-layout.h: Rename include guard.
 495         * tui/tui-io.h: Rename include guard.
 496         * tui/tui-hooks.h: Rename include guard.
 497         * tui/tui-file.h: Rename include guard.
 498         * tui/tui-disasm.h: Rename include guard.
 499         * tui/tui-data.h: Rename include guard.
 500         * tui/tui-command.h: Rename include guard.
 501         * tic6x-tdep.h: Add include guard.
 502         * target/waitstatus.h: Rename include guard.
 503         * target/wait.h: Rename include guard.
 504         * target/target.h: Rename include guard.
 505         * target/resume.h: Rename include guard.
 506         * target-float.h: Rename include guard.
 507         * stabsread.h: Add include guard.
 508         * rs6000-tdep.h: Add include guard.
 509         * riscv-fbsd-tdep.h: Add include guard.
 510         * regformats/regdef.h: Rename include guard.
 511         * record.h: Rename include guard.
 512         * python/python.h: Rename include guard.
 513         * python/python-internal.h: Rename include guard.
 514         * python/py-stopevent.h: Rename include guard.
 515         * python/py-ref.h: Rename include guard.
 516         * python/py-record.h: Rename include guard.
 517         * python/py-record-full.h: Rename include guard.
 518         * python/py-record-btrace.h: Rename include guard.
 519         * python/py-instruction.h: Rename include guard.
 520         * python/py-events.h: Rename include guard.
 521         * python/py-event.h: Rename include guard.
 522         * procfs.h: Add include guard.
 523         * proc-utils.h: Add include guard.
 524         * p-lang.h: Add include guard.
 525         * or1k-tdep.h: Rename include guard.
 526         * observable.h: Rename include guard.
 527         * nto-tdep.h: Rename include guard.
 528         * nat/x86-linux.h: Rename include guard.
 529         * nat/x86-linux-dregs.h: Rename include guard.
 530         * nat/x86-gcc-cpuid.h: Add include guard.
 531         * nat/x86-dregs.h: Rename include guard.
 532         * nat/x86-cpuid.h: Rename include guard.
 533         * nat/ppc-linux.h: Rename include guard.
 534         * nat/mips-linux-watch.h: Rename include guard.
 535         * nat/linux-waitpid.h: Rename include guard.
 536         * nat/linux-ptrace.h: Rename include guard.
 537         * nat/linux-procfs.h: Rename include guard.
 538         * nat/linux-osdata.h: Rename include guard.
 539         * nat/linux-nat.h: Rename include guard.
 540         * nat/linux-namespaces.h: Rename include guard.
 541         * nat/linux-btrace.h: Rename include guard.
 542         * nat/glibc_thread_db.h: Rename include guard.
 543         * nat/gdb_thread_db.h: Rename include guard.
 544         * nat/gdb_ptrace.h: Rename include guard.
 545         * nat/fork-inferior.h: Rename include guard.
 546         * nat/amd64-linux-siginfo.h: Rename include guard.
 547         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 548         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 549         * nat/aarch64-linux.h: Rename include guard.
 550         * nat/aarch64-linux-hw-point.h: Rename include guard.
 551         * mn10300-tdep.h: Add include guard.
 552         * mips-linux-tdep.h: Add include guard.
 553         * mi/mi-parse.h: Rename include guard.
 554         * mi/mi-out.h: Rename include guard.
 555         * mi/mi-main.h: Rename include guard.
 556         * mi/mi-interp.h: Rename include guard.
 557         * mi/mi-getopt.h: Rename include guard.
 558         * mi/mi-console.h: Rename include guard.
 559         * mi/mi-common.h: Rename include guard.
 560         * mi/mi-cmds.h: Rename include guard.
 561         * mi/mi-cmd-break.h: Rename include guard.
 562         * m2-lang.h: Add include guard.
 563         * location.h: Rename include guard.
 564         * linux-record.h: Rename include guard.
 565         * linux-nat.h: Add include guard.
 566         * linux-fork.h: Add include guard.
 567         * i386-darwin-tdep.h: Rename include guard.
 568         * hppa-linux-offsets.h: Add include guard.
 569         * guile/guile.h: Rename include guard.
 570         * guile/guile-internal.h: Rename include guard.
 571         * gnu-nat.h: Rename include guard.
 572         * gdb-stabs.h: Rename include guard.
 573         * frv-tdep.h: Add include guard.
 574         * f-lang.h: Add include guard.
 575         * event-loop.h: Add include guard.
 576         * darwin-nat.h: Rename include guard.
 577         * cp-abi.h: Rename include guard.
 578         * config/sparc/nm-sol2.h: Rename include guard.
 579         * config/nm-nto.h: Rename include guard.
 580         * config/nm-linux.h: Add include guard.
 581         * config/i386/nm-i386gnu.h: Rename include guard.
 582         * config/djgpp/nl_types.h: Rename include guard.
 583         * config/djgpp/langinfo.h: Rename include guard.
 584         * compile/gcc-cp-plugin.h: Add include guard.
 585         * compile/gcc-c-plugin.h: Add include guard.
 586         * compile/compile.h: Rename include guard.
 587         * compile/compile-object-run.h: Rename include guard.
 588         * compile/compile-object-load.h: Rename include guard.
 589         * compile/compile-internal.h: Rename include guard.
 590         * compile/compile-cplus.h: Rename include guard.
 591         * compile/compile-c.h: Rename include guard.
 592         * common/xml-utils.h: Rename include guard.
 593         * common/x86-xstate.h: Rename include guard.
 594         * common/version.h: Rename include guard.
 595         * common/vec.h: Rename include guard.
 596         * common/tdesc.h: Rename include guard.
 597         * common/selftest.h: Rename include guard.
 598         * common/scoped_restore.h: Rename include guard.
 599         * common/scoped_mmap.h: Rename include guard.
 600         * common/scoped_fd.h: Rename include guard.
 601         * common/safe-iterator.h: Rename include guard.
 602         * common/run-time-clock.h: Rename include guard.
 603         * common/refcounted-object.h: Rename include guard.
 604         * common/queue.h: Rename include guard.
 605         * common/ptid.h: Rename include guard.
 606         * common/print-utils.h: Rename include guard.
 607         * common/preprocessor.h: Rename include guard.
 608         * common/pathstuff.h: Rename include guard.
 609         * common/observable.h: Rename include guard.
 610         * common/netstuff.h: Rename include guard.
 611         * common/job-control.h: Rename include guard.
 612         * common/host-defs.h: Rename include guard.
 613         * common/gdb_wait.h: Rename include guard.
 614         * common/gdb_vecs.h: Rename include guard.
 615         * common/gdb_unlinker.h: Rename include guard.
 616         * common/gdb_unique_ptr.h: Rename include guard.
 617         * common/gdb_tilde_expand.h: Rename include guard.
 618         * common/gdb_sys_time.h: Rename include guard.
 619         * common/gdb_string_view.h: Rename include guard.
 620         * common/gdb_splay_tree.h: Rename include guard.
 621         * common/gdb_setjmp.h: Rename include guard.
 622         * common/gdb_ref_ptr.h: Rename include guard.
 623         * common/gdb_optional.h: Rename include guard.
 624         * common/gdb_locale.h: Rename include guard.
 625         * common/gdb_assert.h: Rename include guard.
 626         * common/filtered-iterator.h: Rename include guard.
 627         * common/filestuff.h: Rename include guard.
 628         * common/fileio.h: Rename include guard.
 629         * common/environ.h: Rename include guard.
 630         * common/common-utils.h: Rename include guard.
 631         * common/common-types.h: Rename include guard.
 632         * common/common-regcache.h: Rename include guard.
 633         * common/common-inferior.h: Rename include guard.
 634         * common/common-gdbthread.h: Rename include guard.
 635         * common/common-exceptions.h: Rename include guard.
 636         * common/common-defs.h: Rename include guard.
 637         * common/common-debug.h: Rename include guard.
 638         * common/cleanups.h: Rename include guard.
 639         * common/buffer.h: Rename include guard.
 640         * common/btrace-common.h: Rename include guard.
 641         * common/break-common.h: Rename include guard.
 642         * cli/cli-utils.h: Rename include guard.
 643         * cli/cli-style.h: Rename include guard.
 644         * cli/cli-setshow.h: Rename include guard.
 645         * cli/cli-script.h: Rename include guard.
 646         * cli/cli-interp.h: Rename include guard.
 647         * cli/cli-decode.h: Rename include guard.
 648         * cli/cli-cmds.h: Rename include guard.
 649         * charset-list.h: Add include guard.
 650         * buildsym-legacy.h: Rename include guard.
 651         * bfin-tdep.h: Add include guard.
 652         * ax.h: Rename include guard.
 653         * arm-linux-tdep.h: Add include guard.
 654         * arm-fbsd-tdep.h: Add include guard.
 655         * arch/xtensa.h: Rename include guard.
 656         * arch/tic6x.h: Add include guard.
 657         * arch/i386.h: Add include guard.
 658         * arch/arm.h: Rename include guard.
 659         * arch/arm-linux.h: Rename include guard.
 660         * arch/arm-get-next-pcs.h: Rename include guard.
 661         * arch/amd64.h: Add include guard.
 662         * arch/aarch64-insn.h: Rename include guard.
 663         * arch-utils.h: Rename include guard.
 664         * annotate.h: Add include guard.
 665         * amd64-darwin-tdep.h: Rename include guard.
 666         * aarch64-linux-tdep.h: Add include guard.
 667         * aarch64-fbsd-tdep.h: Add include guard.
 668         * aarch32-linux-nat.h: Add include guard.
 669
 670 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 671
 672         * macrotab.c (macro_define_internal): New function that
 673         factorizes macro_define_object_internal and macro_define_function
 674         code.
 675         (macro_define_object_internal): Use macro_define_internal.
 676         (macro_define_function): Likewise.
 677
 678 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 679
 680         * macrocmd.c (extract_identifier): Return
 681         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 682         callers.
 683
 684 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 685
 686         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 687
 688 2019-02-05  Tom Tromey  <tom@tromey.com>
 689
 690         * target.c (target_stack::unpush): Move assertion earlier.
 691
 692 2019-01-30  Tom Tromey  <tom@tromey.com>
 693
 694         PR python/23615:
 695         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 696         (gdbpy_parse_and_eval): Likewise.
 697         * python/python-internal.h (gdbpy_allow_threads): New class.
 698
 699 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 700
 701         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 702         (aarch64_fbsd_fpregmap): Move earlier.
 703         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 704         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 705         instead of individual calls to trad_frame_set_reg_addr.
 706         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 707         earlier.
 708         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 709         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 710         instead of individual calls to trad_frame_set_reg_addr.
 711
 712 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 713
 714         * CONTRIBUTE: Replace contribution list with wiki link.
 715
 716 2019-01-25  Tom Tromey  <tom@tromey.com>
 717
 718         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 719
 720 2019-01-25  Tom Tromey  <tom@tromey.com>
 721
 722         * xtensa-linux-nat.c: Fix common/ includes.
 723         * xml-support.h: Fix common/ includes.
 724         * xml-support.c: Fix common/ includes.
 725         * x86-linux-nat.c: Fix common/ includes.
 726         * windows-nat.c: Fix common/ includes.
 727         * varobj.h: Fix common/ includes.
 728         * varobj.c: Fix common/ includes.
 729         * value.c: Fix common/ includes.
 730         * valops.c: Fix common/ includes.
 731         * utils.c: Fix common/ includes.
 732         * unittests/xml-utils-selftests.c: Fix common/ includes.
 733         * unittests/utils-selftests.c: Fix common/ includes.
 734         * unittests/unpack-selftests.c: Fix common/ includes.
 735         * unittests/tracepoint-selftests.c: Fix common/ includes.
 736         * unittests/style-selftests.c: Fix common/ includes.
 737         * unittests/string_view-selftests.c: Fix common/ includes.
 738         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 739         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 740         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 741         * unittests/rsp-low-selftests.c: Fix common/ includes.
 742         * unittests/parse-connection-spec-selftests.c: Fix common/
 743         includes.
 744         * unittests/optional-selftests.c: Fix common/ includes.
 745         * unittests/offset-type-selftests.c: Fix common/ includes.
 746         * unittests/observable-selftests.c: Fix common/ includes.
 747         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 748         * unittests/memrange-selftests.c: Fix common/ includes.
 749         * unittests/memory-map-selftests.c: Fix common/ includes.
 750         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 751         * unittests/function-view-selftests.c: Fix common/ includes.
 752         * unittests/environ-selftests.c: Fix common/ includes.
 753         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 754         * unittests/common-utils-selftests.c: Fix common/ includes.
 755         * unittests/cli-utils-selftests.c: Fix common/ includes.
 756         * unittests/array-view-selftests.c: Fix common/ includes.
 757         * ui-file.c: Fix common/ includes.
 758         * tui/tui-io.c: Fix common/ includes.
 759         * tracepoint.h: Fix common/ includes.
 760         * tracepoint.c: Fix common/ includes.
 761         * tracefile-tfile.c: Fix common/ includes.
 762         * top.h: Fix common/ includes.
 763         * top.c: Fix common/ includes.
 764         * thread.c: Fix common/ includes.
 765         * target/waitstatus.h: Fix common/ includes.
 766         * target/waitstatus.c: Fix common/ includes.
 767         * target.h: Fix common/ includes.
 768         * target.c: Fix common/ includes.
 769         * target-memory.c: Fix common/ includes.
 770         * target-descriptions.c: Fix common/ includes.
 771         * symtab.h: Fix common/ includes.
 772         * symfile.c: Fix common/ includes.
 773         * stap-probe.c: Fix common/ includes.
 774         * spu-linux-nat.c: Fix common/ includes.
 775         * sparc-nat.c: Fix common/ includes.
 776         * source.c: Fix common/ includes.
 777         * solib.c: Fix common/ includes.
 778         * solib-target.c: Fix common/ includes.
 779         * ser-unix.c: Fix common/ includes.
 780         * ser-tcp.c: Fix common/ includes.
 781         * ser-pipe.c: Fix common/ includes.
 782         * ser-base.c: Fix common/ includes.
 783         * selftest-arch.c: Fix common/ includes.
 784         * s12z-tdep.c: Fix common/ includes.
 785         * rust-exp.y: Fix common/ includes.
 786         * rs6000-aix-tdep.c: Fix common/ includes.
 787         * riscv-tdep.c: Fix common/ includes.
 788         * remote.c: Fix common/ includes.
 789         * remote-notif.h: Fix common/ includes.
 790         * remote-fileio.h: Fix common/ includes.
 791         * remote-fileio.c: Fix common/ includes.
 792         * regcache.h: Fix common/ includes.
 793         * regcache.c: Fix common/ includes.
 794         * record-btrace.c: Fix common/ includes.
 795         * python/python.c: Fix common/ includes.
 796         * python/py-type.c: Fix common/ includes.
 797         * python/py-inferior.c: Fix common/ includes.
 798         * progspace.h: Fix common/ includes.
 799         * producer.c: Fix common/ includes.
 800         * procfs.c: Fix common/ includes.
 801         * proc-api.c: Fix common/ includes.
 802         * printcmd.c: Fix common/ includes.
 803         * ppc-linux-nat.c: Fix common/ includes.
 804         * parser-defs.h: Fix common/ includes.
 805         * osdata.c: Fix common/ includes.
 806         * obsd-nat.c: Fix common/ includes.
 807         * nat/x86-linux.c: Fix common/ includes.
 808         * nat/x86-linux-dregs.c: Fix common/ includes.
 809         * nat/x86-dregs.h: Fix common/ includes.
 810         * nat/x86-dregs.c: Fix common/ includes.
 811         * nat/ppc-linux.c: Fix common/ includes.
 812         * nat/mips-linux-watch.h: Fix common/ includes.
 813         * nat/mips-linux-watch.c: Fix common/ includes.
 814         * nat/linux-waitpid.c: Fix common/ includes.
 815         * nat/linux-ptrace.h: Fix common/ includes.
 816         * nat/linux-ptrace.c: Fix common/ includes.
 817         * nat/linux-procfs.c: Fix common/ includes.
 818         * nat/linux-personality.c: Fix common/ includes.
 819         * nat/linux-osdata.c: Fix common/ includes.
 820         * nat/linux-namespaces.c: Fix common/ includes.
 821         * nat/linux-btrace.h: Fix common/ includes.
 822         * nat/linux-btrace.c: Fix common/ includes.
 823         * nat/fork-inferior.c: Fix common/ includes.
 824         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 825         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 826         * nat/aarch64-linux.c: Fix common/ includes.
 827         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 828         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 829         * namespace.h: Fix common/ includes.
 830         * mips-linux-tdep.c: Fix common/ includes.
 831         * minsyms.c: Fix common/ includes.
 832         * mi/mi-parse.h: Fix common/ includes.
 833         * mi/mi-main.c: Fix common/ includes.
 834         * mi/mi-cmd-env.c: Fix common/ includes.
 835         * memrange.h: Fix common/ includes.
 836         * memattr.c: Fix common/ includes.
 837         * maint.h: Fix common/ includes.
 838         * maint.c: Fix common/ includes.
 839         * main.c: Fix common/ includes.
 840         * machoread.c: Fix common/ includes.
 841         * location.c: Fix common/ includes.
 842         * linux-thread-db.c: Fix common/ includes.
 843         * linux-nat.c: Fix common/ includes.
 844         * linux-fork.c: Fix common/ includes.
 845         * inline-frame.c: Fix common/ includes.
 846         * infrun.c: Fix common/ includes.
 847         * inflow.c: Fix common/ includes.
 848         * inferior.h: Fix common/ includes.
 849         * inferior.c: Fix common/ includes.
 850         * infcmd.c: Fix common/ includes.
 851         * inf-ptrace.c: Fix common/ includes.
 852         * inf-child.c: Fix common/ includes.
 853         * ia64-linux-nat.c: Fix common/ includes.
 854         * i387-tdep.c: Fix common/ includes.
 855         * i386-tdep.c: Fix common/ includes.
 856         * i386-linux-tdep.c: Fix common/ includes.
 857         * i386-linux-nat.c: Fix common/ includes.
 858         * i386-go32-tdep.c: Fix common/ includes.
 859         * i386-fbsd-tdep.c: Fix common/ includes.
 860         * i386-fbsd-nat.c: Fix common/ includes.
 861         * guile/scm-type.c: Fix common/ includes.
 862         * guile/guile.c: Fix common/ includes.
 863         * go32-nat.c: Fix common/ includes.
 864         * gnu-nat.c: Fix common/ includes.
 865         * gdbthread.h: Fix common/ includes.
 866         * gdbarch-selftests.c: Fix common/ includes.
 867         * gdb_usleep.c: Fix common/ includes.
 868         * gdb_select.h: Fix common/ includes.
 869         * gdb_bfd.c: Fix common/ includes.
 870         * gcore.c: Fix common/ includes.
 871         * fork-child.c: Fix common/ includes.
 872         * findvar.c: Fix common/ includes.
 873         * fbsd-nat.c: Fix common/ includes.
 874         * event-top.c: Fix common/ includes.
 875         * event-loop.c: Fix common/ includes.
 876         * dwarf2read.c: Fix common/ includes.
 877         * dwarf2loc.c: Fix common/ includes.
 878         * dwarf2-frame.c: Fix common/ includes.
 879         * dwarf-index-cache.c: Fix common/ includes.
 880         * dtrace-probe.c: Fix common/ includes.
 881         * disasm-selftests.c: Fix common/ includes.
 882         * defs.h: Fix common/ includes.
 883         * csky-tdep.c: Fix common/ includes.
 884         * cp-valprint.c: Fix common/ includes.
 885         * cp-support.h: Fix common/ includes.
 886         * cp-support.c: Fix common/ includes.
 887         * corelow.c: Fix common/ includes.
 888         * completer.h: Fix common/ includes.
 889         * completer.c: Fix common/ includes.
 890         * compile/compile.c: Fix common/ includes.
 891         * compile/compile-loc2c.c: Fix common/ includes.
 892         * compile/compile-cplus-types.c: Fix common/ includes.
 893         * compile/compile-cplus-symbols.c: Fix common/ includes.
 894         * command.h: Fix common/ includes.
 895         * cli/cli-dump.c: Fix common/ includes.
 896         * cli/cli-cmds.c: Fix common/ includes.
 897         * charset.c: Fix common/ includes.
 898         * build-id.c: Fix common/ includes.
 899         * btrace.h: Fix common/ includes.
 900         * btrace.c: Fix common/ includes.
 901         * breakpoint.h: Fix common/ includes.
 902         * breakpoint.c: Fix common/ includes.
 903         * ax.h:
 904         (enum agent_op): Fix common/ includes.
 905         * ax-general.c (struct aop_map): Fix common/ includes.
 906         * ax-gdb.c: Fix common/ includes.
 907         * auxv.c: Fix common/ includes.
 908         * auto-load.c: Fix common/ includes.
 909         * arm-tdep.c: Fix common/ includes.
 910         * arch/riscv.c: Fix common/ includes.
 911         * arch/ppc-linux-common.c: Fix common/ includes.
 912         * arch/i386.c: Fix common/ includes.
 913         * arch/arm.c: Fix common/ includes.
 914         * arch/arm-linux.c: Fix common/ includes.
 915         * arch/arm-get-next-pcs.c: Fix common/ includes.
 916         * arch/amd64.c: Fix common/ includes.
 917         * arch/aarch64.c: Fix common/ includes.
 918         * arch/aarch64-insn.c: Fix common/ includes.
 919         * arch-utils.c: Fix common/ includes.
 920         * amd64-windows-tdep.c: Fix common/ includes.
 921         * amd64-tdep.c: Fix common/ includes.
 922         * amd64-sol2-tdep.c: Fix common/ includes.
 923         * amd64-obsd-tdep.c: Fix common/ includes.
 924         * amd64-nbsd-tdep.c: Fix common/ includes.
 925         * amd64-linux-tdep.c: Fix common/ includes.
 926         * amd64-linux-nat.c: Fix common/ includes.
 927         * amd64-fbsd-tdep.c: Fix common/ includes.
 928         * amd64-fbsd-nat.c: Fix common/ includes.
 929         * amd64-dicos-tdep.c: Fix common/ includes.
 930         * amd64-darwin-tdep.c: Fix common/ includes.
 931         * agent.c: Fix common/ includes.
 932         * ada-lang.h: Fix common/ includes.
 933         * ada-lang.c: Fix common/ includes.
 934         * aarch64-tdep.c: Fix common/ includes.
 935
 936 2019-01-25  Tom Tromey  <tom@tromey.com>
 937
 938         * common/create-version.sh: Use common/version.h.
 939
 940 2019-01-24  Pedro Alves  <palves@redhat.com>
 941
 942         * infrun.c (signal_stop, signal_print, signal_program)
 943         (signal_catch, signal_pass): Now arrays instead of pointers.
 944         (update_signals_program_target, do_target_resume)
 945         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 946         * linux-nat.c (linux_nat_target::pass_signals)
 947         (linux_nat_target::create_inferior, linux_nat_target::attach):
 948         Adjust.
 949         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 950         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 951         * procfs.c (procfs_target::pass_signals): Adjust.
 952         * record-full.c (record_full_target::resume): Adjust.
 953         * remote.c (remote_target::pass_signals)
 954         (remote_target::program_signals): Adjust.
 955         * target-debug.h (target_debug_print_signals): Now takes a
 956         gdb::array_view as parameter.  Adjust.
 957         * target.h (target_ops) <pass_signals, program_signals>: Replace
 958         pointer and length parameters with gdb::array_view.
 959         (target_pass_signals, target_program_signals): Likewise.
 960         * target-delegates.c: Regenerate.
 961
 962 2019-01-24  Pedro Alves  <palves@redhat.com>
 963
 964         * common/forward-scope-exit.h
 965         (forward_scope_exit::forward_scope_exit): Pass arguments to
 966         m_bind_function directly, instead of creating a std::bind and
 967         copying that.
 968
 969 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 970
 971         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 972         for static members.
 973         (pass_in_v_vfp_candidate): Likewise.
 974
 975 2019-01-23  Tom Tromey  <tom@tromey.com>
 976             Pedro Alves  <palves@redhat.com>
 977
 978         * regcache.c (class regcache_invalidator): Remove.
 979         (regcache::raw_write): Use make_scope_exit.
 980
 981 2019-01-23  Tom Tromey  <tom@tromey.com>
 982
 983         * ui-out.h (class ui_out_emit_type): Update comment.
 984
 985 2019-01-23  Tom Tromey  <tom@tromey.com>
 986
 987         * infrun.c (fetch_inferior_event): Update comment.
 988
 989 2019-01-23  Tom Tromey  <tom@tromey.com>
 990             Pedro Alves  <palves@redhat.com>
 991
 992         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 993         parameter.
 994         (fetch_inferior_event): Use SCOPE_EXIT.
 995
 996
 997 2019-01-23  Tom Tromey  <tom@tromey.com>
 998             Pedro Alves  <palves@redhat.com>
 999
1000         * infrun.c (disable_thread_events): Delete.
1001         (stop_all_threads): Use SCOPE_EXIT.
1002
1003 2019-01-23  Tom Tromey  <tom@tromey.com>
1004             Pedro Alves  <palves@redhat.com>
1005
1006         * symfile.c: Include forward-scope-exit.h.
1007         (clear_symtab_users_cleanup): Replace forward declaration with
1008         a FORWARD_SCOPE_EXIT.
1009         (syms_from_objfile_1): Use the forward_scope_exit and
1010         gdb::optional instead of cleanup_function.
1011         (reread_symbols): Use the forward_scope_exit instead of
1012         cleanup_function.
1013         (clear_symtab_users_cleanup): Remove function.
1014
1015 2019-01-23  Tom Tromey  <tom@tromey.com>
1016             Pedro Alves  <palves@redhat.com>
1017
1018         * linux-nat.c: Include scope-exit.h.
1019         (cleanup_target_stop): Remove.
1020         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1021         SCOPE_EXIT.
1022
1023 2019-01-23  Tom Tromey  <tom@tromey.com>
1024             Pedro Alves  <palves@redhat.com>
1025
1026         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1027         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1028
1029 2019-01-23  Tom Tromey  <tom@tromey.com>
1030             Andrew Burgess  <andrew.burgess@embecosm.com>
1031             Pedro Alves  <palves@redhat.com>
1032
1033         * infrun.c (fetch_inferior_event): Use scope_exit.
1034         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1035         * top.c (execute_command): Use scope_exit.
1036         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1037         * utils.c (do_bpstat_clear_actions_cleanup)
1038         (make_bpstat_clear_actions_cleanup): Remove.
1039
1040 2019-01-23  Tom Tromey  <tom@tromey.com>
1041             Pedro Alves  <palves@redhat.com>
1042
1043         * infrun.c: Include "common/scope-exit.h"
1044         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1045         (wait_for_inferior): Use SCOPE_EXIT.
1046         (fetch_inferior_event): Use scope_exit.
1047
1048 2019-01-23  Tom Tromey  <tom@tromey.com>
1049             Pedro Alves  <palves@redhat.com>
1050
1051         * breakpoint.c (create_breakpoint): Remove cleanup.
1052
1053 2019-01-23  Tom Tromey  <tom@tromey.com>
1054             Andrew Burgess  <andrew.burgess@embecosm.com>
1055             Pedro Alves  <palves@redhat.com>
1056
1057 2019-01-23  Pedro Alves  <palves@redhat.com>
1058
1059         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1060
1061 2019-01-23  Pedro Alves  <palves@redhat.com>
1062             Andrew Burgess  <andrew.burgess@embecosm.com>
1063
1064         * gdbthread.h: Include "common/forward-scope-exit.h".
1065         (scoped_finish_thread_state): Redefine custom class in terms of
1066         forward_scope_exit.
1067
1068 2019-01-23  Pedro Alves  <palves@redhat.com>
1069             Andrew Burgess  <andrew.burgess@embecosm.com>
1070
1071         * common/forward-scope-exit.h: New file.
1072
1073 2019-01-23  Pedro Alves  <palves@redhat.com>
1074             Andrew Burgess  <andrew.burgess@embecosm.com>
1075             Tom Tromey  <tom@tromey.com>
1076
1077         * common/scope-exit.h: New file.
1078
1079 2019-01-23  Pedro Alves  <palves@redhat.com>
1080
1081         * common/preprocessor.h (ESC): Rename to ...
1082         (ESC_PARENS): ... this.
1083         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1084         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1085
1086 2019-01-23  Tom Tromey  <tom@tromey.com>
1087
1088         * language.h (class scoped_switch_to_sym_language_if_auto):
1089         Initialize m_lang in both cases.
1090
1091 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1092
1093         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1094         with XCNEW.
1095
1096 2019-01-22  Tom Tromey  <tom@tromey.com>
1097
1098         * corelow.c: Do not include sys/file.h.
1099
1100 2019-01-22  Tom Tromey  <tom@tromey.com>
1101
1102         * tui/tui-wingeneral.h: Include gdb_curses.h.
1103
1104 2019-01-22  Tom Tromey  <tom@tromey.com>
1105
1106         * source-cache.h (class source_cache) <get_source_lines,
1107         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1108
1109 2019-01-22  Tom Tromey  <tom@tromey.com>
1110
1111         * remote-fileio.h (struct remote_target): Declare.
1112
1113 2019-01-22  Tom Tromey  <tom@tromey.com>
1114
1115         * python/py-arch.c: Do not include py-ref.h.
1116         * python/py-bpevent.c: Do not include py-ref.h.
1117         * python/py-cmd.c: Do not include py-ref.h.
1118         * python/py-continueevent.c: Do not include py-ref.h.
1119         * python/py-event.h: Do not include py-ref.h.
1120         * python/py-evtregistry.c: Do not include py-ref.h.
1121         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1122         * python/py-frame.c: Do not include py-ref.h.
1123         * python/py-framefilter.c: Do not include py-ref.h.
1124         * python/py-function.c: Do not include py-ref.h.
1125         * python/py-infevents.c: Do not include py-ref.h.
1126         * python/py-linetable.c: Do not include py-ref.h.
1127         * python/py-objfile.c: Do not include py-ref.h.
1128         * python/py-param.c: Do not include py-ref.h.
1129         * python/py-prettyprint.c: Do not include py-ref.h.
1130         * python/py-progspace.c: Do not include py-ref.h.
1131         * python/py-symbol.c: Do not include py-ref.h.
1132         * python/py-symtab.c: Do not include py-ref.h.
1133         * python/py-type.c: Do not include py-ref.h.
1134         * python/py-unwind.c: Do not include py-ref.h.
1135         * python/py-utils.c: Do not include py-ref.h.
1136         * python/py-value.c: Do not include py-ref.h.
1137         * python/py-varobj.c: Do not include py-ref.h.
1138         * python/py-xmethods.c: Do not include py-ref.h.
1139         * python/python.c: Do not include py-ref.h.
1140         * varobj.c: Do not include py-ref.h.
1141
1142 2019-01-22  Tom Tromey  <tom@tromey.com>
1143
1144         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1145         keyword for bcache.
1146
1147 2019-01-22  Tom Tromey  <tom@tromey.com>
1148
1149         * compile/compile-cplus-types.c: Remove a comment by #include.
1150
1151 2019-01-22  Tom Tromey  <tom@tromey.com>
1152
1153         * compile/gcc-c-plugin.h: Include compile-internal.h.
1154
1155 2019-01-22  Tom Tromey  <tom@tromey.com>
1156
1157         * stabsread.c (EXTERN): Do not define.
1158         (symnum, next_symbol_text_func, processing_gcc_compilation)
1159         (within_function, global_sym_chain, global_stabs)
1160         (previous_stab_code, this_object_header_files)
1161         (n_this_object_header_files)
1162         (n_allocated_this_object_header_files): Define.
1163         * stabsread.h (EXTERN): Never define.  Use "extern".
1164
1165 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1166
1167         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1168         history_value.
1169
1170 2019-01-21  Tom Tromey  <tom@tromey.com>
1171
1172         * ui-out.c: Fix includes.
1173         * tui/tui-source.c: Fix includes.
1174         * target.c: Fix includes.
1175         * remote.c: Fix includes.
1176         * regcache.c: Fix includes.
1177         * python/py-block.c: Fix includes.
1178         * printcmd.c: Fix includes.
1179         * or1k-tdep.c: Fix includes.
1180         * mi/mi-main.c: Fix includes.
1181         * m32r-tdep.c: Fix includes.
1182         * csky-tdep.c: Fix includes.
1183         * compile/compile-cplus-types.c: Fix includes.
1184         * cli/cli-interp.c: Fix includes.
1185
1186 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1187
1188         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1189         for padding.
1190
1191 2019-01-16  Tom Tromey  <tom@tromey.com>
1192
1193         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1194         earlier.
1195         (struct objfile) <msymbols_range>: Move from top level.
1196         <msymbols>: New method.
1197         (class objfile_msymbols): Remove.
1198         * symtab.c (default_collect_symbol_completion_matches_break_on):
1199         Update.
1200         * symmisc.c (dump_msymbols): Update.
1201         * stabsread.c (scan_file_globals): Update.
1202         * objc-lang.c (info_selectors_command, info_classes_command)
1203         (find_methods): Update.
1204         * minsyms.c (find_solib_trampoline_target): Update.
1205         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1206         * coffread.c (coff_symfile_read): Update.
1207         * ada-lang.c (ada_lookup_simple_minsym)
1208         (ada_collect_symbol_completion_matches): Update.
1209
1210 2019-01-16  Tom Tromey  <tom@tromey.com>
1211
1212         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1213         type.  Remove no-argument constructor.
1214         <iterator::operator++>: Simplify.
1215         <begin>: Update.
1216         <end>: Use minimal_symbol_count.
1217
1218 2019-01-16  Tom Tromey  <tom@tromey.com>
1219
1220         * objfiles.h (struct objfile) <psymtabs>: New method.
1221         (class objfile_psymtabs): Remove.
1222         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1223         typedef.
1224         <range>: New method.
1225         (require_partial_symbols): Change return type.
1226         * psymtab.c (require_partial_symbols)
1227         (psym_expand_symtabs_matching): Update.
1228         * mdebugread.c (parse_partial_symbols): Update.
1229         * dbxread.c (dbx_end_psymtab): Update.
1230
1231 2019-01-15  Tom Tromey  <tom@tromey.com>
1232
1233         * symtab.c (lookup_objfile_from_block)
1234         (lookup_symbol_in_objfile_symtabs)
1235         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1236         (find_line_symtab, info_sources_command)
1237         (default_collect_symbol_completion_matches_break_on)
1238         (make_source_files_completion_list): Update.
1239         * symmisc.c (print_objfile_statistics, dump_objfile)
1240         (maintenance_print_symbols, maintenance_info_symtabs)
1241         (maintenance_check_symtabs, maintenance_info_line_tables):
1242         Update.
1243         * source.c (select_source_symtab)
1244         (forget_cached_source_info_for_objfile): Update.
1245         * objfiles.h (class objfile_compunits): Remove.
1246         (struct objfile) <compunits_range>: New typedef.
1247         (compunits): New method.
1248         * objfiles.c (objfile_relocate1): Update.
1249         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1250         * maint.c (count_symtabs_and_blocks): Update.
1251         * linespec.c (iterate_over_all_matching_symtabs): Update.
1252         * cp-support.c (add_symbol_overload_list_qualified): Update.
1253         * coffread.c (coff_symtab_read): Update.
1254         * ada-lang.c (add_nonlocal_symbols)
1255         (ada_collect_symbol_completion_matches)
1256         (ada_add_global_exceptions): Update.
1257
1258 2019-01-15  Tom Tromey  <tom@tromey.com>
1259
1260         * progspace.h (program_space) <objfiles_safe_range>: New
1261         typedef.
1262         <objfiles_safe>: New method.
1263         * objfiles.h (class all_objfiles_safe): Remove.
1264         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1265         * jit.c (jit_inferior_exit_hook): Update.
1266
1267 2019-01-17  Tom Tromey  <tom@tromey.com>
1268
1269         * progspace.h (program_space) <objfiles_range>: New typedef.
1270         <objfiles>: New method.
1271         <objfiles_head>: Rename from objfiles.
1272         (object_files): Update.
1273         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1274         * guile/scm-pretty-print.c
1275         (ppscm_find_pretty_printer_from_objfiles): Update.
1276         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1277         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1278         Update.
1279         * python/py-progspace.c (pspy_get_objfiles): Update.
1280         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1281         Update.
1282         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1283         (objfpy_lookup_objfile_by_build_id): Update.
1284         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1285         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1286         Update.
1287         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1288         (expand_symtab_containing_pc, lookup_objfile_from_block)
1289         (lookup_static_symbol, basic_lookup_transparent_type)
1290         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1291         (find_line_symtab, info_sources_command)
1292         (default_collect_symbol_completion_matches_break_on)
1293         (make_source_files_completion_list, find_main_name): Update.
1294         * symmisc.c (print_symbol_bcache_statistics)
1295         (print_objfile_statistics, maintenance_print_symbols)
1296         (maintenance_print_msymbols, maintenance_print_objfiles)
1297         (maintenance_info_symtabs, maintenance_check_symtabs)
1298         (maintenance_expand_symtabs, maintenance_info_line_tables):
1299         Update.
1300         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1301         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1302         (map_overlay_command, unmap_overlay_command)
1303         (simple_overlay_update, expand_symtabs_matching)
1304         (map_symbol_filenames): Update.
1305         * symfile-debug.c (set_debug_symfile): Update.
1306         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1307         Update.
1308         * source.c (select_source_symtab, forget_cached_source_info):
1309         Update.
1310         * solib.c (solib_read_symbols): Update.
1311         * solib-spu.c (append_ocl_sos): Update.
1312         * psymtab.c (maintenance_print_psymbols)
1313         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1314         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1315         * printcmd.c (info_symbol_command): Update.
1316         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1317         Update.
1318         * objfiles.h (class all_objfiles): Remove.
1319         * objfiles.c (have_partial_symbols, have_full_symbols)
1320         (have_minimal_symbols, qsort_cmp, update_section_map)
1321         (shared_objfile_contains_address_p)
1322         (default_iterate_over_objfiles_in_search_order): Update.
1323         * objc-lang.c (info_selectors_command, info_classes_command)
1324         (find_methods): Update.
1325         * minsyms.c (find_solib_trampoline_target): Update.
1326         * maint.c (maintenance_info_sections)
1327         (maintenance_translate_address, count_symtabs_and_blocks):
1328         Update.
1329         * main.c (captured_main_1): Update.
1330         * linux-thread-db.c (try_thread_db_load_from_pdir)
1331         (has_libpthread): Update.
1332         * linespec.c (iterate_over_all_matching_symtabs)
1333         (search_minsyms_for_name): Update.
1334         * jit.c (jit_find_objf_with_entry_addr): Update.
1335         * hppa-tdep.c (find_unwind_entry)
1336         (hppa_lookup_stub_minimal_symbol): Update.
1337         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1338         Update.
1339         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1340         (elf_gnu_ifunc_resolve_by_got): Update.
1341         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1342         * dwarf-index-write.c (save_gdb_index_command): Update.
1343         * cp-support.c (add_symbol_overload_list_qualified): Update.
1344         * breakpoint.c (create_overlay_event_breakpoint)
1345         (create_longjmp_master_breakpoint)
1346         (create_std_terminate_master_breakpoint)
1347         (create_exception_master_breakpoint): Update.
1348         * blockframe.c (find_pc_partial_function): Update.
1349         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1350         (ada_collect_symbol_completion_matches)
1351         (ada_add_global_exceptions): Update.
1352
1353 2019-01-17  Tom Tromey  <tom@tromey.com>
1354
1355         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1356         declare VEC.
1357         (solib_target_parse_libraries): Change return type.
1358         (library_list_start_segment, library_list_start_section)
1359         (library_list_end_library, library_list_start_library); Update.
1360         (solib_target_free_library_list): Remove.
1361         (solib_target_parse_libraries): Remove cleanup.  Change return
1362         type.
1363         (solib_target_current_sos): Update.
1364
1365 2019-01-17  Tom Tromey  <tromey@bapiya>
1366
1367         * valprint.c: Replace "the the" with "the".
1368         * symtab.c: Replace "the the" with "the".
1369         * solib.c: Replace "the the" with "the".
1370         * solib-dsbt.c: Replace "the the" with "the".
1371         * linespec.c: Replace "the the" with "the".
1372         * dwarf2loc.h: Replace "the the" with "the".
1373         * amd64-windows-tdep.c: Replace "the the" with "the".
1374         * aarch64-tdep.c: Replace "the the" with "the".
1375
1376 2019-01-16  Keith Seitz  <keiths@redhat.com>
1377
1378         PR gdb/23773
1379         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1380         <builder>: Rename to ..
1381         <m_builder>: ... this and make private.
1382         (dwarf2_cu::get_builder): New method.  Change all users of
1383         `builder' to use this method.
1384         (dwarf2_start_symtab): Move to ...
1385         (dwarf2_cu::start_symtab): ... here.  Update all callers
1386         (setup_type_unit_groups): Move to ...
1387         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1388         callers.
1389         (dwarf2_cu::reset_builder): New method.
1390         (process_full_compunit, process_full_type_unit): Use
1391         dwarf2_cu::reset_builder.
1392         (follow_die_offset): Record the ancestor CU if it is different
1393         from the followed DIE's CU.
1394         (follow_die_sig_1): Likewise.
1395
1396 2019-01-15  Tom Tromey  <tom@tromey.com>
1397
1398         * remote.c (class remote_state) <buf>: Now a char_vector.
1399         <buf_size>: Remove.
1400         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1401         parameter.
1402         (remote_target::getpkt_or_notif_sane_1)
1403         (remote_target::getpkt_sane)
1404         (remote_target::getpkt_or_notif_sane): Likewise.
1405         (class remote_target) <putpkt>: New overload.
1406         (remote_target::read_frame): Change type of "buf_p".  Remove
1407         sizeof_p parameter.
1408         (packet_ok): New overload.
1409         (packet_check_result): New overload.
1410         Update all uses.
1411
1412 2019-01-14  Tom Tromey  <tom@tromey.com>
1413
1414         * remote-notif.c (handle_notification, remote_notif_ack)
1415         (remote_notif_parse): Make "buf" const.
1416         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1417         const.
1418         (remote_notif_parse, remote_notif_ack, handle_notification):
1419         Likewise.
1420         * remote.c (remote_notif_stop_parse): Make "buf" const.
1421         (remote_target::remote_parse_stop_reply): Make "buf" const.
1422         (remote_notif_stop_ack): Make "buf" const.
1423
1424 2019-01-14  Tom Tromey  <tom@tromey.com>
1425
1426         * remote.c (remote_console_output): Make parameter const.
1427
1428 2019-01-14  Tom Tromey  <tom@tromey.com>
1429
1430         * target-debug.h (target_debug_print_signals): Constify.
1431         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1432         * procfs.c (procfs_target::pass_signals): Update.
1433         * linux-nat.c (linux_nat_target::pass_signals): Update.
1434         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1435         * target-delegates.c: Rebuild.
1436         * remote.c (remote_target::program_signals): Update.
1437         (remote_target::pass_signals): Update.
1438         * target.c (target_pass_signals): Constify argument.
1439         (target_program_signals): Likewise.
1440         * target.h (struct target_ops) <pass_signals, program_signals>:
1441         Constify argument.
1442         (target_pass_signals, target_program_signals): Constify argument.
1443
1444 2019-01-14  Tom Tromey  <tom@tromey.com>
1445
1446         PR tui/28819:
1447         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1448
1449 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1450
1451         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1452         field.
1453         * rs6000-tdep.c: Include reggroups.h.
1454         (IS_V_ALIAS_PSEUDOREG): Define.
1455         (rs6000_register_name): Return names for the "vX" aliases.
1456         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1457         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1458         aliases.  Call default_register_reggroup_p for all other
1459         pseudo-registers.
1460         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1461         New functions.
1462         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1463         Handle "vX" aliases.
1464         (v_alias_pseudo_register_collect): New function.
1465         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1466         (rs6000_gdbarch_init): Initialize "vX" aliases as
1467         pseudo-registers.  Restore registration of
1468         rs6000_pseudo_register_reggroup_p with
1469         set_tdesc_pseudo_register_reggroup_p.
1470
1471 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1472
1473         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1474         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1475         set_gdbarch_num_pseudo_regs.
1476
1477 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1478
1479         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1480         Remove arg prefixname, add do_set and do_show.
1481         Add member functions set_list and show_list.
1482         * cli/cli-style.c (class cli_style_option): Update accordingly.
1483         (style_set_list): Move to file scope.
1484         (style_show_list): Likewise.
1485         (set_style): Call help_list.
1486         (show_style): Call cmd_show_list.
1487         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1488         Update to use the new macro.
1489
1490 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1491
1492         * ada-lang.c (_initialize_ada_language): Expand the help text
1493         for the "catch exception" command.
1494
1495 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1496
1497         * symtab.c (matching_obj_sections): Initialize obj,
1498         declare it closer to its usage.
1499
1500 2019-01-10  Tom Tromey  <tom@tromey.com>
1501
1502         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1503         (basic_inf_threads_range): Remove.
1504         (inf_threads_range, inf_non_exited_threads_range)
1505         (safe_inf_threads_range): Use next_adapter.
1506
1507 2019-01-10  Keith Seitz  <keiths@redhat.com>
1508
1509         PR gdb/23712
1510         PR symtab/23010
1511         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1512         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1513
1514 2019-01-10  Keith Seitz  <keiths@redhat.com>
1515
1516         PR gdb/23712
1517         PR symtab/23010
1518         * dictionary.c (pending_to_vector): Remove.
1519         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1520         Remove _1 suffix, replacing functions of the same name.  Update
1521         all callers.
1522         (dict_create_hashed, dict_create_hashed_expandable)
1523         (dict_create_linear, dict_create_linear_expandable, dict_free)
1524         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1525         Make functions static.
1526
1527 2019-01-10  Keith Seitz  <keiths@redhat.com>
1528
1529         PR gdb/23712
1530         PR symtab/23010
1531         * dictionary.h (struct dictionary): Replace declaration with
1532         multidictionary.
1533         (dict_create_hashed, dict_create_hashed_expandable)
1534         (dict_create_linear, dict_create_linear_expandable)
1535         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1536         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1537         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1538         taking multidictionary argument.
1539         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1540         * block.h (struct block) <dict>: Change to multidictionary
1541         and rename `multidict'.
1542         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1543         symmisc.c: Update all dictionary references to multidictionary.
1544
1545 2019-01-10  Keith Seitz  <keiths@redhat.com>
1546
1547         PR gdb/23712
1548         PR symtab/23010
1549         * dictionary.c: Include unordered_map.
1550         (pending_to_vector): New function.
1551         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1552         Rewrite the non-"_1" functions to take vector instead
1553         of linked list.
1554         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1555         "new" _1 versions of the same name.
1556         (multidictionary): Define.
1557         (std::hash<enum language): New definition.
1558         (collate_pending_symbols_by_language, mdict_create_hashed)
1559         (mdict_create_hashed_expandable, mdict_create_linear)
1560         (mdict_create_linear_expandable, mdict_free)
1561         (find_language_dictionary, create_new_language_dictionary)
1562         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1563         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1564         (mdict_size, mdict_empty): New functions.
1565         * dictionary.h (mdict_iterator): Define.
1566
1567 2019-01-10  Pedro Alves  <palves@redhat.com>
1568
1569         * breakpoint.c (read_uploaded_action)
1570         (create_tracepoint_from_upload): Adjust to use
1571         gdb::unique_xmalloc_ptr.
1572         * ctf.c (ctf_write_uploaded_tp):
1573         (SET_ARRAY_FIELD): Use emplace_back.
1574         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1575         * tracefile-tfile.c (tfile_write_uploaded_tp):
1576         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1577         gdb::unique_xmalloc_ptr.
1578         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1579         at_string, cond_string, cmd_strings>: Replace char pointers
1580         with gdb::unique_xmalloc_ptr.
1581
1582 2019-01-10  Pedro Alves  <palves@redhat.com>
1583
1584         * solib-target.c (library_list_start_library): Don't xstrdup name.
1585
1586 2019-01-10  Pedro Alves  <palves@redhat.com>
1587
1588         * mdebugread.c (parse_partial_symbols): Use
1589         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1590
1591 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1592
1593         * linux-fork.c (scoped_switch_fork_info)
1594         <~scoped_switch_fork_info>: Fix incorrect variable name.
1595
1596 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1597
1598         * linux-fork.c (scoped_switch_fork_info)
1599         <scoped_switch_fork_info>: Make explicit.
1600         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1601
1602 2019-01-10  Tom Tromey  <tom@tromey.com>
1603
1604         * objfiles.h (objfile::reset_psymtabs): Update.
1605         * objfiles.c (objfile::objfile): Update.
1606         * psymtab.h (psymtab_storage::obstack): Update.
1607         (psymtab_storage::m_obstack): Use gdb::optional.
1608         (class psymtab_storage): Update comment.  Remove objfile
1609         parameter.
1610         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1611
1612 2019-01-10  Tom Tromey  <tom@tromey.com>
1613
1614         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1615         <free_psymtabs>: Now private.
1616         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1617         (allocate_psymtab): Use new method.
1618
1619 2019-01-10  Tom Tromey  <tom@tromey.com>
1620
1621         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1622         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1623         * mdebugread.c (parse_partial_symbols): Use
1624         allocate_dependencies.
1625         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1626         allocate_dependencies.
1627         (process_psymtab_comp_unit_reader)
1628         (build_type_psymtab_dependencies): Likewise.
1629         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1630
1631 2019-01-10  Tom Tromey  <tom@tromey.com>
1632
1633         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1634         PSYMBOL_SET_LANGUAGE.
1635         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1636
1637 2019-01-10  Tom Tromey  <tom@tromey.com>
1638
1639         * psymtab.h (psymtab_storage::obstack): New method.
1640         <m_obstack>: Rename from obstack; now private.
1641         * psymtab.c (psymtab_storage): Update.
1642         * dwarf2read.c (create_addrmap_from_index)
1643         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1644         Update.
1645
1646 2019-01-10  Tom Tromey  <tom@tromey.com>
1647
1648         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1649         * objfiles.h (objfile::reset_psymtabs): New method.
1650
1651 2019-01-10  Tom Tromey  <tom@tromey.com>
1652
1653         * symmisc.c (print_symbol_bcache_statistics): Update.
1654         (print_objfile_statistics): Update.
1655         * symfile.c (reread_symbols): Update.
1656         * psymtab.h (class psymtab_storage): New.
1657         * psymtab.c (psymtab_storage): New constructor.
1658         (~psymtab_storage): New destructor.
1659         (require_partial_symbols): Update.
1660         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1661         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1662         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1663         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1664         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1665         (start_psymtab_common, end_psymtab_common)
1666         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1667         (allocate_psymtab): Update.
1668         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1669         Update.
1670         (dump_psymtab_addrmap, maintenance_print_psymbols)
1671         (maintenance_check_psymtabs): Update.
1672         (class objfile_psymtabs): Move to objfiles.h.
1673         * psympriv.h (discard_psymtab): Now inline.
1674         (psymtab_discarder::psymtab_discarder): Update.
1675         (psymtab_discarder::~psymtab_discarder): Update.
1676         (ALL_OBJFILE_PSYMTABS): Rewrite.
1677         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1678         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1679         Remove fields.
1680         <partial_symtabs>: New field.
1681         (class objfile_psymtabs): Move from psymtab.h.  Update.
1682         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1683         psymbol_cache.
1684         (objfile::~objfile): Don't destroy psymbol_cache.
1685         * mdebugread.c (parse_partial_symbols): Update.
1686         * dwarf2read.c (create_addrmap_from_index)
1687         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1688         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1689         (add_partial_subprogram, dwarf2_ranges_read): Update.
1690         * dwarf-index-write.c (write_address_map)
1691         (write_one_signatured_type, recursively_write_psymbols)
1692         (class debug_names, class debug_names, write_psymtabs_to_index):
1693         Update.
1694
1695 2019-01-10  Tom Tromey  <tom@tromey.com>
1696
1697         * symtab.h (SYMBOL_SET_NAMES): Update.
1698         (symbol_set_names): Update.
1699         (MSYMBOL_SET_NAMES): Update.
1700         * symtab.c (symbol_set_names): Change argument to be an
1701         objfile_per_bfd_storage.
1702         * psymtab.c (add_psymbol_to_bcache): Update.
1703         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1704
1705 2019-01-10  Tom Tromey  <tom@tromey.com>
1706
1707         * symtab.c (create_demangled_names_hash): Change argument to be an
1708         objfile_per_bfd_storage.
1709         (symbol_set_names): Update.
1710
1711 2019-01-10  Tom Tromey  <tom@tromey.com>
1712
1713         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1714         init_psymbol_list.
1715         * psymtab.c (init_psymbol_list): Do nothing if already called.
1716         * psympriv.h (init_psymbol_list): Add comment.
1717         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1718         init_psymbol_list.
1719         * dbxread.c (dbx_symfile_read): Unconditionally call
1720         init_psymbol_list.
1721
1722 2019-01-10  Tom Tromey  <tom@tromey.com>
1723
1724         * xcoffread.c (scan_xcoff_symtab): Update.
1725         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1726         "where".
1727         * mdebugread.c (parse_partial_symbols)
1728         (handle_psymbol_enumerators): Update.
1729         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1730         * dbxread.c (read_dbx_symtab): Update.
1731         * psympriv.h (psymbol_placement): New enum.
1732         (add_psymbol_to_list): Update.
1733
1734 2019-01-10  Tom Tromey  <tom@tromey.com>
1735
1736         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1737         static_psymbols parameters.
1738         (scan_xcoff_symtab): Update.
1739         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1740         static_psymbols parameters.
1741         * psympriv.h (start_psymtab_common): Update.
1742         * mdebugread.c (parse_partial_symbols): Update.
1743         * dwarf2read.c (create_partial_symtab): Update.
1744         * dbxread.c (read_dbx_symtab): Update.
1745         (start_psymtab): Remove global_psymbols and static_psymbols
1746         parameters.
1747
1748 2019-01-10  Tom Tromey  <tom@tromey.com>
1749
1750         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1751         * psymtab.c (allocate_psymtab): Add comment.
1752         * psympriv.h (allocate_psymtab): Add comment.
1753         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1754         initializations.
1755         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1756
1757 2019-01-10  Tom Tromey  <tom@tromey.com>
1758
1759         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1760         Don't declare.
1761         * mipsread.c: Include mdebugread.h.
1762         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1763         Declare.
1764         * elfread.c: Include mdebugread.h.
1765
1766 2019-01-09  Tom Tromey  <tom@tromey.com>
1767
1768         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1769         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1770         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1771         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1772         (psym_lookup_symbol, psym_find_last_source_symtab)
1773         (psym_forget_cached_source_info, psym_print_stats)
1774         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1775         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1776         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1777         (psym_find_compunit_symtab_by_address)
1778         (maintenance_print_psymbols, maintenance_info_psymtabs)
1779         (maintenance_check_psymtabs): Use ranged for.
1780         * psymtab.h (class objfile_psymtabs): New.
1781         (require_partial_symbols): Return objfile_psymtabs.
1782         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1783
1784 2019-01-09  Tom Tromey  <tom@tromey.com>
1785
1786         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1787         (find_pc_mapped_section, list_overlays_command)
1788         (map_overlay_command, unmap_overlay_command)
1789         (simple_overlay_update): Use all_objfiles.
1790         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1791         * printcmd.c (info_symbol_command): Use all_objfiles.
1792         * objfiles.h (ALL_OBJSECTIONS): Remove.
1793         * maint.c (maintenance_translate_address): Use all_objfiles.
1794         * gcore.c (gcore_create_callback): Use all_objfiles.
1795         (objfile_find_memory_regions): Likewise.
1796
1797 2019-01-09  Tom Tromey  <tom@tromey.com>
1798
1799         * symtab.c (find_line_symtab, info_sources_command)
1800         (make_source_files_completion_list): Use objfile_compunits.
1801         * source.c (select_source_symtab): Use objfile_compunits.
1802         * objfiles.h (struct objfile): Update comment.
1803         (ALL_OBJFILES): Remove.
1804         (ALL_FILETABS): Remove.
1805         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1806         objfile_compunits.
1807
1808 2019-01-09  Tom Tromey  <tom@tromey.com>
1809
1810         * symmisc.c (print_objfile_statistics, dump_objfile)
1811         (maintenance_print_symbols): Use compunit_filetabs.
1812         * source.c (forget_cached_source_info_for_objfile): Use
1813         compunit_filetabs.
1814         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1815         (ALL_FILETABS): Use compunit_filetabs.
1816         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1817         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1818
1819 2019-01-09  Tom Tromey  <tom@tromey.com>
1820
1821         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1822         (compunit_filetabs): New.
1823         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1824         compunit_filetabs.
1825         (info_sources_command, make_source_files_completion_list): Remove
1826         declaration.
1827         * symmisc.c (print_objfile_statistics, dump_objfile)
1828         (maintenance_print_symbols): Remove declaration.
1829         (maintenance_info_symtabs): Use compunit_filetabs.
1830         (maintenance_info_line_tables): Likewise.
1831         * source.c (select_source_symtab): Change local variable name.
1832         (forget_cached_source_info_for_objfile): Remove declaration.
1833         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1834         * objfiles.c (objfile_relocate1): Remove declaration.
1835         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1836         declaration.
1837         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1838         * coffread.c (coff_symtab_read): Remove declaration.
1839         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1840         compunit_filetabs.
1841
1842 2019-01-09  Tom Tromey  <tom@tromey.com>
1843
1844         * symtab.c (lookup_objfile_from_block)
1845         (find_pc_sect_compunit_symtab, search_symbols)
1846         (default_collect_symbol_completion_matches_break_on): Use
1847         objfile_compunits.
1848         * objfiles.h (ALL_COMPUNITS): Remove.
1849         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1850         * cp-support.c (add_symbol_overload_list_qualified): Use
1851         objfile_compunits.
1852         * ada-lang.c (ada_collect_symbol_completion_matches)
1853         (ada_add_global_exceptions): Use objfile_compunits.
1854
1855 2019-01-09  Tom Tromey  <tom@tromey.com>
1856
1857         * source.c (select_source_symtab)
1858         (forget_cached_source_info_for_objfile): Remove declaration.
1859         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1860         declaration.
1861         * maint.c (count_symtabs_and_blocks): Remove declaration.
1862         * cp-support.c (add_symbol_overload_list_qualified): Remove
1863         declaration.
1864         * coffread.c (coff_symtab_read): Remove declaration.
1865         * symtab.c (lookup_symbol_in_objfile_symtabs)
1866         (basic_lookup_transparent_type_1): Use objfile_compunits.
1867         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1868         (info_sources_command, search_symbols)
1869         (default_collect_symbol_completion_matches_break_on)
1870         (make_source_files_completion_list): Remove declaration.
1871         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1872         (ada_collect_symbol_completion_matches)
1873         (ada_add_global_exceptions): Remove declaration.
1874         * linespec.c (iterate_over_all_matching_symtabs): Use
1875         objfile_compunits.
1876         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1877         (class objfile_compunits): New.
1878         (ALL_COMPUNITS): Use objfile_compunits.
1879         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1880         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1881         objfile_compunits.
1882         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1883
1884 2019-01-09  Tom Tromey  <tom@tromey.com>
1885
1886         * symtab.c (search_symbols)
1887         (default_collect_symbol_completion_matches_break_on): Use
1888         objfile_msymbols.
1889         * ada-lang.c (ada_lookup_simple_minsym)
1890         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1891         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1892         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1893         objfile_msymbols.
1894         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1895         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1896         * objc-lang.c (find_methods): Use objfile_msymbols.
1897         (info_selectors_command, info_classes_command): Likewise.
1898         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1899         * objfiles.h (class objfile_msymbols): New.
1900         (ALL_OBJFILE_MSYMBOLS): Remove.
1901         (ALL_MSYMBOLS): Remove.
1902
1903 2019-01-09  Tom Tromey  <tom@tromey.com>
1904
1905         * common/next-iterator.h (next_adapter): Add Iterator template
1906         parameter.
1907         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1908         (class all_objfiles_safe): New.
1909         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1910         * objfiles.c (put_objfile_before): Update comment.
1911         (add_separate_debug_objfile): Likewise.
1912         (free_all_objfiles): Use all_objfiles_safe.
1913         (objfile_purge_solibs): Likewise.
1914
1915 2019-01-09  Tom Tromey  <tom@tromey.com>
1916
1917         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1918         (expand_symtab_containing_pc, lookup_static_symbol)
1919         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1920         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1921         all_objfiles.
1922         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1923         * breakpoint.c (create_overlay_event_breakpoint)
1924         (create_longjmp_master_breakpoint)
1925         (create_std_terminate_master_breakpoint)
1926         (create_exception_master_breakpoint): Use all_objfiles.
1927         * linux-thread-db.c (try_thread_db_load_from_pdir)
1928         (has_libpthread): Use all_objfiles.
1929         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1930         * linespec.c (iterate_over_all_matching_symtabs)
1931         (search_minsyms_for_name): Use all_objfiles.
1932         * maint.c (maintenance_info_sections): Use all_objfiles.
1933         * main.c (captured_main_1): Use all_objfiles.
1934         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1935         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1936         * guile/scm-pretty-print.c
1937         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1938         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1939         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1940         (maintenance_print_msymbols): Use all_objfiles.
1941         * source.c (select_source_symtab): Use all_objfiles.
1942         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1943         * symfile.c (remove_symbol_file_command)
1944         (expand_symtabs_matching, map_symbol_filenames): Use
1945         all_objfiles.
1946         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1947         all_objfiles.
1948         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1949         * objc-lang.c (find_methods): Use all_objfiles.
1950         * objfiles.c (have_partial_symbols, have_full_symbols)
1951         (have_minimal_symbols, qsort_cmp)
1952         (default_iterate_over_objfiles_in_search_order): Use
1953         all_objfiles.
1954         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1955         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1956         (maintenance_check_psymtabs): Use all_objfiles.
1957         (ALL_PSYMTABS): Remove.
1958         * compile/compile-object-run.c (do_module_cleanup): Use
1959         all_objfiles.
1960         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1961         * cp-support.c (add_symbol_overload_list_qualified): Use
1962         all_objfiles.
1963         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1964         Use all_objfiles.
1965         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1966         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1967         all_objfiles.
1968         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1969         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1970         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1971         Uses all_objfiles.
1972         * solib.c (solib_read_symbols): Use all_objfiles
1973
1974 2019-01-09  Tom Tromey  <tom@tromey.com>
1975
1976         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1977         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1978         all_objfiles.
1979         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1980         * symmisc.c (print_symbol_bcache_statistics)
1981         (print_objfile_statistics, maintenance_print_objfiles)
1982         (maintenance_info_symtabs, maintenance_check_symtabs)
1983         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1984         all_objfiles.
1985         * source.c (forget_cached_source_info): Use all_objfiles.
1986         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1987         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1988         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1989         * objfiles.c (update_section_map): Use all_objfiles.
1990         (shared_objfile_contains_address_p): Likewise.
1991         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1992         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1993
1994 2019-01-09  Tom Tromey  <tom@tromey.com>
1995
1996         * common/next-iterator.h: New file.
1997         * objfiles.h (class all_objfiles): New.
1998         (struct objfile_iterator): New.
1999
2000 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2001
2002         * NEWS: Move the description of the changed "frame", "select-frame",
2003          and "info frame" commands to the Changed commands section.
2004
2005 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2006
2007         * gdbtypes.c (check_stub_method_group): Remove handling of old
2008         mangling schemes.
2009         * linespec.c (find_methods): Likewise.
2010         * stabsread.c (read_member_functions): Likewise.
2011         * valops.c (search_struct_method): Likewise.
2012         (value_struct_elt_for_reference): Likewise.
2013         * NEWS: Mention this change.
2014
2015 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2016
2017         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2018         print_source_lines.
2019         * source.c (print_source_lines_base): Update line number check.
2020         (print_source_lines): New function.
2021         (source_lines_range::source_lines_range): New function.
2022         * source.h (class source_lines_range): New class.
2023         (print_source_lines): New declaration.
2024
2025 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2026
2027         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2028
2029 2019-01-08  Tom Tromey  <tom@tromey.com>
2030             Simon Marchi  <simon.marchi@ericsson.com>
2031
2032         PR gdb/24060
2033         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2034         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2035         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2036         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2037         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2038         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2039
2040 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2041
2042         * source.c (select_source_symtab): Move header comment to
2043         declaration in source.h.
2044         (forget_cached_source_info_for_objfile): Likewise.
2045         (forget_cached_source_info): Likewise.
2046         (identify_source_line): Likewise.
2047         * source.h (identify_source_line): Move declaration from symtab.h
2048         and add comment from source.c
2049         (print_source_lines): Likewise.
2050         (forget_cached_source_info_for_objfile): Likewise.
2051         (forget_cached_source_info): Likewise.
2052         (select_source_symtab): Likewise.
2053         (enum print_source_lines_flag): Move definition from symtab.h.
2054         * symtab.h (identify_source_line): Move declaration to source.h.
2055         (print_source_lines): Likewise.
2056         (forget_cached_source_info_for_objfile): Likewise.
2057         (forget_cached_source_info): Likewise.
2058         (select_source_symtab): Likewise.
2059         (enum print_source_lines_flag): Move definition to source.h.
2060         * tui/tui-hooks.c: Add 'source.h' include.
2061
2062 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2063
2064         * source.c (print_source_lines_base): Handle requests to print
2065         reverse line number sequences, and guard against empty lines
2066         string.
2067
2068 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2069
2070         * source.c (print_source_lines_base): Fix skip of '\r' if next
2071         character is '\n'.
2072
2073 2019-01-06  Tom Tromey  <tom@tromey.com>
2074
2075         * c-exp.y (struct c_parse_state) <macro_original_text,
2076         expansion_obstack>: New member.
2077         (macro_original_text, expansion_obstack): Remove globals.
2078         (scan_macro_expansion, scanning_macro_expansion)
2079         (finished_macro_expansion): Update.
2080         (scan_macro_cleanup): Remove.
2081         (yylex, c_parse): Update.
2082
2083 2019-01-06  Tom Tromey  <tom@tromey.com>
2084
2085         * c-exp.y (struct c_parse_state) <strings>: New member.
2086         (operator_stoken): Update.
2087
2088 2019-01-06  Tom Tromey  <tom@tromey.com>
2089
2090         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2091         (union type_stack_elt) <typelist_val>: Now a pointer to
2092         std::vector.
2093         (type_stack_cleanup): Don't declare.
2094         (push_typelist): Update.
2095         * parse.c (pop_typelist): Return a std::vector.
2096         (push_typelist): Take a std::vector.
2097         (follow_types): Update.  Do not free args.
2098         (type_stack_cleanup): Remove.
2099         * c-exp.y (struct c_parse_state): New.
2100         (cpstate): New global.
2101         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2102         (nonempty_typelist): Update.
2103         (func_mod): Create a new vector.
2104         (c_parse): Create a c_parse_state.
2105         (check_parameter_typelist): Do not delete params.
2106         (function_method): Update.  Do not delete type_list.
2107
2108 2019-01-06  Tom Tromey  <tom@tromey.com>
2109
2110         PR gdb/28155:
2111         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2112         check_typedef.
2113         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2114         (print_return_value): Likewise.
2115
2116 2019-01-05  Tom Tromey  <tom@tromey.com>
2117
2118         * contrib/cleanup_check.py: Remove.
2119         * contrib/gcc-with-excheck: Remove.
2120         * contrib/exsummary.py: Remove.
2121         * contrib/excheck.py: Remove.
2122
2123 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2124
2125         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2126         NULL. Initialize tpprev to NULL instead of assigning it
2127         to NULL on the next statement.
2128         * windows-nat.c (windows_delete_thread): Remove check for
2129         main_thread_id before printing thread exit notifications.
2130         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2131         Remove thread ID check against main_thread_id.
2132         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2133         windows_delete_thread.
2134         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2135
2136 2019-01-04  Tom Tromey  <tom@tromey.com>
2137
2138         * compile/compile.c (_initialize_compile): Use upper case for
2139         metasyntactic variables.
2140         * symmisc.c (_initialize_symmisc): Use upper case for
2141         metasyntactic variables.
2142         * psymtab.c (_initialize_psymtab): Use upper case for
2143         metasyntactic variables.
2144         * demangle.c (demangle_command): Use upper case for metasyntactic
2145         variables.
2146         (_initialize_demangler): Likewise.
2147         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2148         variables.
2149
2150 2019-01-03  Tom Tromey  <tom@tromey.com>
2151
2152         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2153
2154 2019-01-03  Tom Tromey  <tom@tromey.com>
2155
2156         * python/py-symtab.c (salpy_str): Update.
2157         (struct salpy_sal_object) <symtab>: Now a PyObject.
2158         (salpy_dealloc): Update.
2159         (del_objfile_sal): Use gdbpy_ref.
2160
2161 2019-01-03  Tom Tromey  <tom@tromey.com>
2162
2163         * python/py-type.c (convert_field): Use new_reference.  Return
2164         gdbpy_ref.
2165         (make_fielditem): Return gdbpy_ref.
2166         (typy_fields): Update.
2167         (typy_getitem): Update.
2168         (field_name): Return gdbpy_ref.  Use new_reference.
2169         (typy_iterator_iternext): Update.
2170
2171 2019-01-03  Tom Tromey  <tom@tromey.com>
2172
2173         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2174
2175 2019-01-03  Tom Tromey  <tom@tromey.com>
2176
2177         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2178         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2179         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2180         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2181         (pspy_set_type_printers): Likewise.
2182         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2183         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2184         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2185         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2186         (objfpy_set_type_printers): Likewise.
2187
2188 2019-01-03  Tom Tromey  <tom@tromey.com>
2189
2190         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2191         (gdbpy_print_stack): Use gdbpy_err_fetch.
2192         * python/python-internal.h (class gdbpy_err_fetch): New class.
2193         (class gdbpy_enter) <m_error_type, m_error_value,
2194         m_error_traceback>: Remove.
2195         <m_error>: New member.
2196         (gdbpy_exception_to_string): Don't declare.
2197         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2198         * python/py-value.c (convert_value_from_python): Use
2199         gdbpy_err_fetch.
2200         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2201         gdbpy_exception_to_string.
2202         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2203         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2204         gdbpy_err_fetch.
2205
2206 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2207
2208         * linux-nat.c (delete_lwp_cleanup): Delete.
2209         (struct lwp_deleter): New struct.
2210         (lwp_info_up): New typedef.
2211         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2212         lwp_info_up.
2213
2214 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2215
2216         * linux-fork.c (class scoped_switch_fork_info): New class.
2217         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2218
2219 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2220
2221         * valops.c (find_overload_match): Remove use of null_cleanup, and
2222         calls to do_cleanups.
2223
2224 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2225
2226         * compile/compile-cplus-types.c
2227         (compile_cplus_instance::decl_name): Handle changes to
2228         cp_func_name.
2229         * cp-support.c (cp_func_name): Update header comment, update
2230         return type.
2231         * cp-support.h (cp_func_name): Update return type in declaration.
2232         * valops.c (find_overload_match): Move temp_func local to top
2233         level of function and change its type.  Use temp_func to hold and
2234         delete temporary string obtained from cp_func_name.
2235
2236 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2237
2238         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2239         gdb::char_vector, remove cleanup, and update uses of `msg`.
2240
2241 2019-01-03  Jim Wilson  <jimw@sifive.com>
2242
2243         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2244
2245 2019-01-02  Tom Tromey  <tom@tromey.com>
2246
2247         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2248         (tdesc_parse_xml): Remove cleanups.
2249         * target-descriptions.h (make_cleanup_free_target_description):
2250         Don't declare.
2251         (target_desc_deleter): New struct.
2252         (target_desc_up): New typedef.
2253         * target-descriptions.c (target_desc_deleter::operator()): Rename
2254         from free_target_description.
2255         (make_cleanup_free_target_description): Remove.
2256
2257 2019-01-02  Tom Tromey  <tom@tromey.com>
2258
2259         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2260         constructor, destructor.
2261         (linespec_parser): Remove typedef.
2262         (~linespec_parser): Rename from linespec_parser_delete.
2263         (linespec_lex_to_end, linespec_complete_label)
2264         (linespec_complete): Update.
2265         (decode_line_full): Remove cleanups.
2266         (decode_line_1): Update.
2267
2268 2019-01-02  Tom Tromey  <tom@tromey.com>
2269
2270         * python/python-internal.h (inferior_to_inferior_object): Change
2271         return type.
2272         * python/py-exitedevent.c (create_exited_event_object): Update.
2273         * python/py-inferior.c (inferior_to_inferior_object): Return
2274         gdbpy_ref.
2275         (python_new_inferior, python_inferior_deleted)
2276         (thread_to_thread_object, delete_thread_object)
2277         (build_inferior_list, gdbpy_selected_inferior): Update.
2278         * python/py-infthread.c (create_thread_object): Update.  Also fail
2279         if inferior_to_inferior_object fails.
2280
2281 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2282
2283         * inferior.h (class inferior) <displaced_step_state>: New field.
2284         * infrun.h (struct displaced_step_state): Move here from
2285         infrun.c.  Initialize fields, add constructor.
2286         <inf>: Remove field.
2287         <reset>: New method.
2288         * infrun.c (struct displaced_step_inferior_state): Move to
2289         infrun.h.
2290         (displaced_step_inferior_states): Remove.
2291         (get_displaced_stepping_state): Adust.
2292         (displaced_step_in_progress_any_inferior): Adjust.
2293         (displaced_step_in_progress_thread): Adjust.
2294         (displaced_step_in_progress): Adjust.
2295         (add_displaced_stepping_state): Remove.
2296         (get_displaced_step_closure_by_addr): Adjust.
2297         (remove_displaced_stepping_state): Remove.
2298         (infrun_inferior_exit): Call displaced_step_state.reset.
2299         (use_displaced_stepping): Don't check for NULL.
2300         (displaced_step_prepare_throw): Call
2301         get_displaced_stepping_state.
2302         (displaced_step_fixup): Don't check for NULL.
2303         (prepare_for_detach): Don't check for NULL.
2304
2305 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2306
2307         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2308          in case of call that did not complete.
2309
2310 2019-01-02  Andrey Utkin  <autkin@undo.io>
2311
2312         * symfile.c (find_separate_debug_file): Fix search of debug files for
2313         remote debuggee.
2314
2315 2019-01-02  Tom Tromey  <tom@tromey.com>
2316
2317         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2318         indentation.
2319         * python/py-frame.c (frapy_older): Remove cast.
2320         (frapy_newer): Likewise.
2321         * python/py-breakpoint.c (local_setattro): Remove cast.
2322         * python/py-arch.c (archpy_name): Remove local variable.
2323         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2324
2325 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2326
2327         * unittests/basic_string_view/element_access/char/empty.cc:
2328         Fix year range in copyright header.
2329
2330 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2331
2332         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2333         Delete.
2334         <operator==>: Update with for removed field.
2335         <hash>: Likewise.
2336         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2337         <isa_features>: ...this.
2338         <abi_features>: New field.
2339         (riscv_isa_flen): Update comment.
2340         (riscv_abi_xlen): New declaration.
2341         (riscv_abi_flen): New declaration.
2342         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2343         isa_features.
2344         (riscv_abi_xlen): New function.
2345         (riscv_isa_flen): Update to get answer from isa_features.
2346         (riscv_abi_flen): New function.
2347         (riscv_has_fp_abi): Update to get answer from abi_features.
2348         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2349         xlen and flen.
2350         (riscv_call_info) <xlen, flen>: Update comment.
2351         (riscv_call_arg_struct): Remove invalid assertions
2352         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2353         is removed.
2354         (riscv_gdbarch_init): Gather isa features and abi features
2355         separately, ensure both match on the gdbarch when reusing an old
2356         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2357         a target with 64-bit float hardware.
2358
2359 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2360
2361         * source.c (search_command_helper): Stop reverse search
2362         when line 1 has been searched.
2363
2364 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2365
2366         * record-full.c (record_full_base_target::close): Rewrite
2367         record_full_core_buf_list free logic.
2368
2369 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2370
2371         * break-catch-syscall.c (print_one_catch_syscall): xfree
2372         the last text.
2373
2374 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2375
2376         * top.c (print_gdb_version): Update Copyright year in version
2377         message.
2378
2379 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2380
2381         Update copyright year range in all GDB files.
2382
2383 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2384
2385         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2386
2387 For older changes see ChangeLog-2018.
2388 \f
2389 Local Variables:
2390 mode: change-log
2391 left-margin: 8
2392 fill-column: 74
2393 version-control: never
2394 coding: utf-8
2395 End:
2396