gdb/ChangeLog

   1 2019-01-23  Tom Tromey  <tom@tromey.com>
   2
   3         * language.h (class scoped_switch_to_sym_language_if_auto):
   4         Initialize m_lang in both cases.
   5
   6 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
   7
   8         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
   9         with XCNEW.
  10
  11 2019-01-22  Tom Tromey  <tom@tromey.com>
  12
  13         * corelow.c: Do not include sys/file.h.
  14
  15 2019-01-22  Tom Tromey  <tom@tromey.com>
  16
  17         * tui/tui-wingeneral.h: Include gdb_curses.h.
  18
  19 2019-01-22  Tom Tromey  <tom@tromey.com>
  20
  21         * source-cache.h (class source_cache) <get_source_lines,
  22         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
  23
  24 2019-01-22  Tom Tromey  <tom@tromey.com>
  25
  26         * remote-fileio.h (struct remote_target): Declare.
  27
  28 2019-01-22  Tom Tromey  <tom@tromey.com>
  29
  30         * python/py-arch.c: Do not include py-ref.h.
  31         * python/py-bpevent.c: Do not include py-ref.h.
  32         * python/py-cmd.c: Do not include py-ref.h.
  33         * python/py-continueevent.c: Do not include py-ref.h.
  34         * python/py-event.h: Do not include py-ref.h.
  35         * python/py-evtregistry.c: Do not include py-ref.h.
  36         * python/py-finishbreakpoint.c: Do not include py-ref.h.
  37         * python/py-frame.c: Do not include py-ref.h.
  38         * python/py-framefilter.c: Do not include py-ref.h.
  39         * python/py-function.c: Do not include py-ref.h.
  40         * python/py-infevents.c: Do not include py-ref.h.
  41         * python/py-linetable.c: Do not include py-ref.h.
  42         * python/py-objfile.c: Do not include py-ref.h.
  43         * python/py-param.c: Do not include py-ref.h.
  44         * python/py-prettyprint.c: Do not include py-ref.h.
  45         * python/py-progspace.c: Do not include py-ref.h.
  46         * python/py-symbol.c: Do not include py-ref.h.
  47         * python/py-symtab.c: Do not include py-ref.h.
  48         * python/py-type.c: Do not include py-ref.h.
  49         * python/py-unwind.c: Do not include py-ref.h.
  50         * python/py-utils.c: Do not include py-ref.h.
  51         * python/py-value.c: Do not include py-ref.h.
  52         * python/py-varobj.c: Do not include py-ref.h.
  53         * python/py-xmethods.c: Do not include py-ref.h.
  54         * python/python.c: Do not include py-ref.h.
  55         * varobj.c: Do not include py-ref.h.
  56
  57 2019-01-22  Tom Tromey  <tom@tromey.com>
  58
  59         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
  60         keyword for bcache.
  61
  62 2019-01-22  Tom Tromey  <tom@tromey.com>
  63
  64         * compile/compile-cplus-types.c: Remove a comment by #include.
  65
  66 2019-01-22  Tom Tromey  <tom@tromey.com>
  67
  68         * compile/gcc-c-plugin.h: Include compile-internal.h.
  69
  70 2019-01-22  Tom Tromey  <tom@tromey.com>
  71
  72         * stabsread.c (EXTERN): Do not define.
  73         (symnum, next_symbol_text_func, processing_gcc_compilation)
  74         (within_function, global_sym_chain, global_stabs)
  75         (previous_stab_code, this_object_header_files)
  76         (n_this_object_header_files)
  77         (n_allocated_this_object_header_files): Define.
  78         * stabsread.h (EXTERN): Never define.  Use "extern".
  79
  80 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  81
  82         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
  83         history_value.
  84
  85 2019-01-21  Tom Tromey  <tom@tromey.com>
  86
  87         * ui-out.c: Fix includes.
  88         * tui/tui-source.c: Fix includes.
  89         * target.c: Fix includes.
  90         * remote.c: Fix includes.
  91         * regcache.c: Fix includes.
  92         * python/py-block.c: Fix includes.
  93         * printcmd.c: Fix includes.
  94         * or1k-tdep.c: Fix includes.
  95         * mi/mi-main.c: Fix includes.
  96         * m32r-tdep.c: Fix includes.
  97         * csky-tdep.c: Fix includes.
  98         * compile/compile-cplus-types.c: Fix includes.
  99         * cli/cli-interp.c: Fix includes.
 100
 101 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 102
 103         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 104         for padding.
 105
 106 2019-01-16  Tom Tromey  <tom@tromey.com>
 107
 108         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 109         earlier.
 110         (struct objfile) <msymbols_range>: Move from top level.
 111         <msymbols>: New method.
 112         (class objfile_msymbols): Remove.
 113         * symtab.c (default_collect_symbol_completion_matches_break_on):
 114         Update.
 115         * symmisc.c (dump_msymbols): Update.
 116         * stabsread.c (scan_file_globals): Update.
 117         * objc-lang.c (info_selectors_command, info_classes_command)
 118         (find_methods): Update.
 119         * minsyms.c (find_solib_trampoline_target): Update.
 120         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 121         * coffread.c (coff_symfile_read): Update.
 122         * ada-lang.c (ada_lookup_simple_minsym)
 123         (ada_collect_symbol_completion_matches): Update.
 124
 125 2019-01-16  Tom Tromey  <tom@tromey.com>
 126
 127         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 128         type.  Remove no-argument constructor.
 129         <iterator::operator++>: Simplify.
 130         <begin>: Update.
 131         <end>: Use minimal_symbol_count.
 132
 133 2019-01-16  Tom Tromey  <tom@tromey.com>
 134
 135         * objfiles.h (struct objfile) <psymtabs>: New method.
 136         (class objfile_psymtabs): Remove.
 137         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 138         typedef.
 139         <range>: New method.
 140         (require_partial_symbols): Change return type.
 141         * psymtab.c (require_partial_symbols)
 142         (psym_expand_symtabs_matching): Update.
 143         * mdebugread.c (parse_partial_symbols): Update.
 144         * dbxread.c (dbx_end_psymtab): Update.
 145
 146 2019-01-15  Tom Tromey  <tom@tromey.com>
 147
 148         * symtab.c (lookup_objfile_from_block)
 149         (lookup_symbol_in_objfile_symtabs)
 150         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 151         (find_line_symtab, info_sources_command)
 152         (default_collect_symbol_completion_matches_break_on)
 153         (make_source_files_completion_list): Update.
 154         * symmisc.c (print_objfile_statistics, dump_objfile)
 155         (maintenance_print_symbols, maintenance_info_symtabs)
 156         (maintenance_check_symtabs, maintenance_info_line_tables):
 157         Update.
 158         * source.c (select_source_symtab)
 159         (forget_cached_source_info_for_objfile): Update.
 160         * objfiles.h (class objfile_compunits): Remove.
 161         (struct objfile) <compunits_range>: New typedef.
 162         (compunits): New method.
 163         * objfiles.c (objfile_relocate1): Update.
 164         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 165         * maint.c (count_symtabs_and_blocks): Update.
 166         * linespec.c (iterate_over_all_matching_symtabs): Update.
 167         * cp-support.c (add_symbol_overload_list_qualified): Update.
 168         * coffread.c (coff_symtab_read): Update.
 169         * ada-lang.c (add_nonlocal_symbols)
 170         (ada_collect_symbol_completion_matches)
 171         (ada_add_global_exceptions): Update.
 172
 173 2019-01-15  Tom Tromey  <tom@tromey.com>
 174
 175         * progspace.h (program_space) <objfiles_safe_range>: New
 176         typedef.
 177         <objfiles_safe>: New method.
 178         * objfiles.h (class all_objfiles_safe): Remove.
 179         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 180         * jit.c (jit_inferior_exit_hook): Update.
 181
 182 2019-01-17  Tom Tromey  <tom@tromey.com>
 183
 184         * progspace.h (program_space) <objfiles_range>: New typedef.
 185         <objfiles>: New method.
 186         <objfiles_head>: Rename from objfiles.
 187         (object_files): Update.
 188         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 189         * guile/scm-pretty-print.c
 190         (ppscm_find_pretty_printer_from_objfiles): Update.
 191         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 192         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 193         Update.
 194         * python/py-progspace.c (pspy_get_objfiles): Update.
 195         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 196         Update.
 197         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 198         (objfpy_lookup_objfile_by_build_id): Update.
 199         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 200         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 201         Update.
 202         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 203         (expand_symtab_containing_pc, lookup_objfile_from_block)
 204         (lookup_static_symbol, basic_lookup_transparent_type)
 205         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 206         (find_line_symtab, info_sources_command)
 207         (default_collect_symbol_completion_matches_break_on)
 208         (make_source_files_completion_list, find_main_name): Update.
 209         * symmisc.c (print_symbol_bcache_statistics)
 210         (print_objfile_statistics, maintenance_print_symbols)
 211         (maintenance_print_msymbols, maintenance_print_objfiles)
 212         (maintenance_info_symtabs, maintenance_check_symtabs)
 213         (maintenance_expand_symtabs, maintenance_info_line_tables):
 214         Update.
 215         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 216         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 217         (map_overlay_command, unmap_overlay_command)
 218         (simple_overlay_update, expand_symtabs_matching)
 219         (map_symbol_filenames): Update.
 220         * symfile-debug.c (set_debug_symfile): Update.
 221         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 222         Update.
 223         * source.c (select_source_symtab, forget_cached_source_info):
 224         Update.
 225         * solib.c (solib_read_symbols): Update.
 226         * solib-spu.c (append_ocl_sos): Update.
 227         * psymtab.c (maintenance_print_psymbols)
 228         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 229         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 230         * printcmd.c (info_symbol_command): Update.
 231         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 232         Update.
 233         * objfiles.h (class all_objfiles): Remove.
 234         * objfiles.c (have_partial_symbols, have_full_symbols)
 235         (have_minimal_symbols, qsort_cmp, update_section_map)
 236         (shared_objfile_contains_address_p)
 237         (default_iterate_over_objfiles_in_search_order): Update.
 238         * objc-lang.c (info_selectors_command, info_classes_command)
 239         (find_methods): Update.
 240         * minsyms.c (find_solib_trampoline_target): Update.
 241         * maint.c (maintenance_info_sections)
 242         (maintenance_translate_address, count_symtabs_and_blocks):
 243         Update.
 244         * main.c (captured_main_1): Update.
 245         * linux-thread-db.c (try_thread_db_load_from_pdir)
 246         (has_libpthread): Update.
 247         * linespec.c (iterate_over_all_matching_symtabs)
 248         (search_minsyms_for_name): Update.
 249         * jit.c (jit_find_objf_with_entry_addr): Update.
 250         * hppa-tdep.c (find_unwind_entry)
 251         (hppa_lookup_stub_minimal_symbol): Update.
 252         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 253         Update.
 254         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 255         (elf_gnu_ifunc_resolve_by_got): Update.
 256         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 257         * dwarf-index-write.c (save_gdb_index_command): Update.
 258         * cp-support.c (add_symbol_overload_list_qualified): Update.
 259         * breakpoint.c (create_overlay_event_breakpoint)
 260         (create_longjmp_master_breakpoint)
 261         (create_std_terminate_master_breakpoint)
 262         (create_exception_master_breakpoint): Update.
 263         * blockframe.c (find_pc_partial_function): Update.
 264         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 265         (ada_collect_symbol_completion_matches)
 266         (ada_add_global_exceptions): Update.
 267
 268 2019-01-17  Tom Tromey  <tom@tromey.com>
 269
 270         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 271         declare VEC.
 272         (solib_target_parse_libraries): Change return type.
 273         (library_list_start_segment, library_list_start_section)
 274         (library_list_end_library, library_list_start_library); Update.
 275         (solib_target_free_library_list): Remove.
 276         (solib_target_parse_libraries): Remove cleanup.  Change return
 277         type.
 278         (solib_target_current_sos): Update.
 279
 280 2019-01-17  Tom Tromey  <tromey@bapiya>
 281
 282         * valprint.c: Replace "the the" with "the".
 283         * symtab.c: Replace "the the" with "the".
 284         * solib.c: Replace "the the" with "the".
 285         * solib-dsbt.c: Replace "the the" with "the".
 286         * linespec.c: Replace "the the" with "the".
 287         * dwarf2loc.h: Replace "the the" with "the".
 288         * amd64-windows-tdep.c: Replace "the the" with "the".
 289         * aarch64-tdep.c: Replace "the the" with "the".
 290
 291 2019-01-16  Keith Seitz  <keiths@redhat.com>
 292
 293         PR gdb/23773
 294         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 295         <builder>: Rename to ..
 296         <m_builder>: ... this and make private.
 297         (dwarf2_cu::get_builder): New method.  Change all users of
 298         `builder' to use this method.
 299         (dwarf2_start_symtab): Move to ...
 300         (dwarf2_cu::start_symtab): ... here.  Update all callers
 301         (setup_type_unit_groups): Move to ...
 302         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 303         callers.
 304         (dwarf2_cu::reset_builder): New method.
 305         (process_full_compunit, process_full_type_unit): Use
 306         dwarf2_cu::reset_builder.
 307         (follow_die_offset): Record the ancestor CU if it is different
 308         from the followed DIE's CU.
 309         (follow_die_sig_1): Likewise.
 310
 311 2019-01-15  Tom Tromey  <tom@tromey.com>
 312
 313         * remote.c (class remote_state) <buf>: Now a char_vector.
 314         <buf_size>: Remove.
 315         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 316         parameter.
 317         (remote_target::getpkt_or_notif_sane_1)
 318         (remote_target::getpkt_sane)
 319         (remote_target::getpkt_or_notif_sane): Likewise.
 320         (class remote_target) <putpkt>: New overload.
 321         (remote_target::read_frame): Change type of "buf_p".  Remove
 322         sizeof_p parameter.
 323         (packet_ok): New overload.
 324         (packet_check_result): New overload.
 325         Update all uses.
 326
 327 2019-01-14  Tom Tromey  <tom@tromey.com>
 328
 329         * remote-notif.c (handle_notification, remote_notif_ack)
 330         (remote_notif_parse): Make "buf" const.
 331         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 332         const.
 333         (remote_notif_parse, remote_notif_ack, handle_notification):
 334         Likewise.
 335         * remote.c (remote_notif_stop_parse): Make "buf" const.
 336         (remote_target::remote_parse_stop_reply): Make "buf" const.
 337         (remote_notif_stop_ack): Make "buf" const.
 338
 339 2019-01-14  Tom Tromey  <tom@tromey.com>
 340
 341         * remote.c (remote_console_output): Make parameter const.
 342
 343 2019-01-14  Tom Tromey  <tom@tromey.com>
 344
 345         * target-debug.h (target_debug_print_signals): Constify.
 346         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 347         * procfs.c (procfs_target::pass_signals): Update.
 348         * linux-nat.c (linux_nat_target::pass_signals): Update.
 349         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 350         * target-delegates.c: Rebuild.
 351         * remote.c (remote_target::program_signals): Update.
 352         (remote_target::pass_signals): Update.
 353         * target.c (target_pass_signals): Constify argument.
 354         (target_program_signals): Likewise.
 355         * target.h (struct target_ops) <pass_signals, program_signals>:
 356         Constify argument.
 357         (target_pass_signals, target_program_signals): Constify argument.
 358
 359 2019-01-14  Tom Tromey  <tom@tromey.com>
 360
 361         PR tui/28819:
 362         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 363
 364 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 365
 366         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 367         field.
 368         * rs6000-tdep.c: Include reggroups.h.
 369         (IS_V_ALIAS_PSEUDOREG): Define.
 370         (rs6000_register_name): Return names for the "vX" aliases.
 371         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 372         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 373         aliases.  Call default_register_reggroup_p for all other
 374         pseudo-registers.
 375         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 376         New functions.
 377         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 378         Handle "vX" aliases.
 379         (v_alias_pseudo_register_collect): New function.
 380         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 381         (rs6000_gdbarch_init): Initialize "vX" aliases as
 382         pseudo-registers.  Restore registration of
 383         rs6000_pseudo_register_reggroup_p with
 384         set_tdesc_pseudo_register_reggroup_p.
 385
 386 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 387
 388         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 389         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 390         set_gdbarch_num_pseudo_regs.
 391
 392 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 393
 394         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 395         Remove arg prefixname, add do_set and do_show.
 396         Add member functions set_list and show_list.
 397         * cli/cli-style.c (class cli_style_option): Update accordingly.
 398         (style_set_list): Move to file scope.
 399         (style_show_list): Likewise.
 400         (set_style): Call help_list.
 401         (show_style): Call cmd_show_list.
 402         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 403         Update to use the new macro.
 404
 405 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 406
 407         * ada-lang.c (_initialize_ada_language): Expand the help text
 408         for the "catch exception" command.
 409
 410 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 411
 412         * symtab.c (matching_obj_sections): Initialize obj,
 413         declare it closer to its usage.
 414
 415 2019-01-10  Tom Tromey  <tom@tromey.com>
 416
 417         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 418         (basic_inf_threads_range): Remove.
 419         (inf_threads_range, inf_non_exited_threads_range)
 420         (safe_inf_threads_range): Use next_adapter.
 421
 422 2019-01-10  Keith Seitz  <keiths@redhat.com>
 423
 424         PR gdb/23712
 425         PR symtab/23010
 426         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 427         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 428
 429 2019-01-10  Keith Seitz  <keiths@redhat.com>
 430
 431         PR gdb/23712
 432         PR symtab/23010
 433         * dictionary.c (pending_to_vector): Remove.
 434         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 435         Remove _1 suffix, replacing functions of the same name.  Update
 436         all callers.
 437         (dict_create_hashed, dict_create_hashed_expandable)
 438         (dict_create_linear, dict_create_linear_expandable, dict_free)
 439         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 440         Make functions static.
 441
 442 2019-01-10  Keith Seitz  <keiths@redhat.com>
 443
 444         PR gdb/23712
 445         PR symtab/23010
 446         * dictionary.h (struct dictionary): Replace declaration with
 447         multidictionary.
 448         (dict_create_hashed, dict_create_hashed_expandable)
 449         (dict_create_linear, dict_create_linear_expandable)
 450         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 451         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 452         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 453         taking multidictionary argument.
 454         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 455         * block.h (struct block) <dict>: Change to multidictionary
 456         and rename `multidict'.
 457         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 458         symmisc.c: Update all dictionary references to multidictionary.
 459
 460 2019-01-10  Keith Seitz  <keiths@redhat.com>
 461
 462         PR gdb/23712
 463         PR symtab/23010
 464         * dictionary.c: Include unordered_map.
 465         (pending_to_vector): New function.
 466         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 467         Rewrite the non-"_1" functions to take vector instead
 468         of linked list.
 469         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 470         "new" _1 versions of the same name.
 471         (multidictionary): Define.
 472         (std::hash<enum language): New definition.
 473         (collate_pending_symbols_by_language, mdict_create_hashed)
 474         (mdict_create_hashed_expandable, mdict_create_linear)
 475         (mdict_create_linear_expandable, mdict_free)
 476         (find_language_dictionary, create_new_language_dictionary)
 477         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 478         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 479         (mdict_size, mdict_empty): New functions.
 480         * dictionary.h (mdict_iterator): Define.
 481
 482 2019-01-10  Pedro Alves  <palves@redhat.com>
 483
 484         * breakpoint.c (read_uploaded_action)
 485         (create_tracepoint_from_upload): Adjust to use
 486         gdb::unique_xmalloc_ptr.
 487         * ctf.c (ctf_write_uploaded_tp):
 488         (SET_ARRAY_FIELD): Use emplace_back.
 489         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 490         * tracefile-tfile.c (tfile_write_uploaded_tp):
 491         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 492         gdb::unique_xmalloc_ptr.
 493         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 494         at_string, cond_string, cmd_strings>: Replace char pointers
 495         with gdb::unique_xmalloc_ptr.
 496
 497 2019-01-10  Pedro Alves  <palves@redhat.com>
 498
 499         * solib-target.c (library_list_start_library): Don't xstrdup name.
 500
 501 2019-01-10  Pedro Alves  <palves@redhat.com>
 502
 503         * mdebugread.c (parse_partial_symbols): Use
 504         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 505
 506 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 507
 508         * linux-fork.c (scoped_switch_fork_info)
 509         <~scoped_switch_fork_info>: Fix incorrect variable name.
 510
 511 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 512
 513         * linux-fork.c (scoped_switch_fork_info)
 514         <scoped_switch_fork_info>: Make explicit.
 515         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 516
 517 2019-01-10  Tom Tromey  <tom@tromey.com>
 518
 519         * objfiles.h (objfile::reset_psymtabs): Update.
 520         * objfiles.c (objfile::objfile): Update.
 521         * psymtab.h (psymtab_storage::obstack): Update.
 522         (psymtab_storage::m_obstack): Use gdb::optional.
 523         (class psymtab_storage): Update comment.  Remove objfile
 524         parameter.
 525         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 526
 527 2019-01-10  Tom Tromey  <tom@tromey.com>
 528
 529         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 530         <free_psymtabs>: Now private.
 531         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 532         (allocate_psymtab): Use new method.
 533
 534 2019-01-10  Tom Tromey  <tom@tromey.com>
 535
 536         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 537         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 538         * mdebugread.c (parse_partial_symbols): Use
 539         allocate_dependencies.
 540         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 541         allocate_dependencies.
 542         (process_psymtab_comp_unit_reader)
 543         (build_type_psymtab_dependencies): Likewise.
 544         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 545
 546 2019-01-10  Tom Tromey  <tom@tromey.com>
 547
 548         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 549         PSYMBOL_SET_LANGUAGE.
 550         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 551
 552 2019-01-10  Tom Tromey  <tom@tromey.com>
 553
 554         * psymtab.h (psymtab_storage::obstack): New method.
 555         <m_obstack>: Rename from obstack; now private.
 556         * psymtab.c (psymtab_storage): Update.
 557         * dwarf2read.c (create_addrmap_from_index)
 558         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 559         Update.
 560
 561 2019-01-10  Tom Tromey  <tom@tromey.com>
 562
 563         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 564         * objfiles.h (objfile::reset_psymtabs): New method.
 565
 566 2019-01-10  Tom Tromey  <tom@tromey.com>
 567
 568         * symmisc.c (print_symbol_bcache_statistics): Update.
 569         (print_objfile_statistics): Update.
 570         * symfile.c (reread_symbols): Update.
 571         * psymtab.h (class psymtab_storage): New.
 572         * psymtab.c (psymtab_storage): New constructor.
 573         (~psymtab_storage): New destructor.
 574         (require_partial_symbols): Update.
 575         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 576         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 577         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 578         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 579         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 580         (start_psymtab_common, end_psymtab_common)
 581         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 582         (allocate_psymtab): Update.
 583         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 584         Update.
 585         (dump_psymtab_addrmap, maintenance_print_psymbols)
 586         (maintenance_check_psymtabs): Update.
 587         (class objfile_psymtabs): Move to objfiles.h.
 588         * psympriv.h (discard_psymtab): Now inline.
 589         (psymtab_discarder::psymtab_discarder): Update.
 590         (psymtab_discarder::~psymtab_discarder): Update.
 591         (ALL_OBJFILE_PSYMTABS): Rewrite.
 592         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 593         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 594         Remove fields.
 595         <partial_symtabs>: New field.
 596         (class objfile_psymtabs): Move from psymtab.h.  Update.
 597         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 598         psymbol_cache.
 599         (objfile::~objfile): Don't destroy psymbol_cache.
 600         * mdebugread.c (parse_partial_symbols): Update.
 601         * dwarf2read.c (create_addrmap_from_index)
 602         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 603         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 604         (add_partial_subprogram, dwarf2_ranges_read): Update.
 605         * dwarf-index-write.c (write_address_map)
 606         (write_one_signatured_type, recursively_write_psymbols)
 607         (class debug_names, class debug_names, write_psymtabs_to_index):
 608         Update.
 609
 610 2019-01-10  Tom Tromey  <tom@tromey.com>
 611
 612         * symtab.h (SYMBOL_SET_NAMES): Update.
 613         (symbol_set_names): Update.
 614         (MSYMBOL_SET_NAMES): Update.
 615         * symtab.c (symbol_set_names): Change argument to be an
 616         objfile_per_bfd_storage.
 617         * psymtab.c (add_psymbol_to_bcache): Update.
 618         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 619
 620 2019-01-10  Tom Tromey  <tom@tromey.com>
 621
 622         * symtab.c (create_demangled_names_hash): Change argument to be an
 623         objfile_per_bfd_storage.
 624         (symbol_set_names): Update.
 625
 626 2019-01-10  Tom Tromey  <tom@tromey.com>
 627
 628         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 629         init_psymbol_list.
 630         * psymtab.c (init_psymbol_list): Do nothing if already called.
 631         * psympriv.h (init_psymbol_list): Add comment.
 632         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 633         init_psymbol_list.
 634         * dbxread.c (dbx_symfile_read): Unconditionally call
 635         init_psymbol_list.
 636
 637 2019-01-10  Tom Tromey  <tom@tromey.com>
 638
 639         * xcoffread.c (scan_xcoff_symtab): Update.
 640         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 641         "where".
 642         * mdebugread.c (parse_partial_symbols)
 643         (handle_psymbol_enumerators): Update.
 644         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 645         * dbxread.c (read_dbx_symtab): Update.
 646         * psympriv.h (psymbol_placement): New enum.
 647         (add_psymbol_to_list): Update.
 648
 649 2019-01-10  Tom Tromey  <tom@tromey.com>
 650
 651         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 652         static_psymbols parameters.
 653         (scan_xcoff_symtab): Update.
 654         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 655         static_psymbols parameters.
 656         * psympriv.h (start_psymtab_common): Update.
 657         * mdebugread.c (parse_partial_symbols): Update.
 658         * dwarf2read.c (create_partial_symtab): Update.
 659         * dbxread.c (read_dbx_symtab): Update.
 660         (start_psymtab): Remove global_psymbols and static_psymbols
 661         parameters.
 662
 663 2019-01-10  Tom Tromey  <tom@tromey.com>
 664
 665         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 666         * psymtab.c (allocate_psymtab): Add comment.
 667         * psympriv.h (allocate_psymtab): Add comment.
 668         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 669         initializations.
 670         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 671
 672 2019-01-10  Tom Tromey  <tom@tromey.com>
 673
 674         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 675         Don't declare.
 676         * mipsread.c: Include mdebugread.h.
 677         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 678         Declare.
 679         * elfread.c: Include mdebugread.h.
 680
 681 2019-01-09  Tom Tromey  <tom@tromey.com>
 682
 683         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 684         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 685         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 686         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 687         (psym_lookup_symbol, psym_find_last_source_symtab)
 688         (psym_forget_cached_source_info, psym_print_stats)
 689         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 690         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 691         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 692         (psym_find_compunit_symtab_by_address)
 693         (maintenance_print_psymbols, maintenance_info_psymtabs)
 694         (maintenance_check_psymtabs): Use ranged for.
 695         * psymtab.h (class objfile_psymtabs): New.
 696         (require_partial_symbols): Return objfile_psymtabs.
 697         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 698
 699 2019-01-09  Tom Tromey  <tom@tromey.com>
 700
 701         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 702         (find_pc_mapped_section, list_overlays_command)
 703         (map_overlay_command, unmap_overlay_command)
 704         (simple_overlay_update): Use all_objfiles.
 705         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 706         * printcmd.c (info_symbol_command): Use all_objfiles.
 707         * objfiles.h (ALL_OBJSECTIONS): Remove.
 708         * maint.c (maintenance_translate_address): Use all_objfiles.
 709         * gcore.c (gcore_create_callback): Use all_objfiles.
 710         (objfile_find_memory_regions): Likewise.
 711
 712 2019-01-09  Tom Tromey  <tom@tromey.com>
 713
 714         * symtab.c (find_line_symtab, info_sources_command)
 715         (make_source_files_completion_list): Use objfile_compunits.
 716         * source.c (select_source_symtab): Use objfile_compunits.
 717         * objfiles.h (struct objfile): Update comment.
 718         (ALL_OBJFILES): Remove.
 719         (ALL_FILETABS): Remove.
 720         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 721         objfile_compunits.
 722
 723 2019-01-09  Tom Tromey  <tom@tromey.com>
 724
 725         * symmisc.c (print_objfile_statistics, dump_objfile)
 726         (maintenance_print_symbols): Use compunit_filetabs.
 727         * source.c (forget_cached_source_info_for_objfile): Use
 728         compunit_filetabs.
 729         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 730         (ALL_FILETABS): Use compunit_filetabs.
 731         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 732         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 733
 734 2019-01-09  Tom Tromey  <tom@tromey.com>
 735
 736         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 737         (compunit_filetabs): New.
 738         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 739         compunit_filetabs.
 740         (info_sources_command, make_source_files_completion_list): Remove
 741         declaration.
 742         * symmisc.c (print_objfile_statistics, dump_objfile)
 743         (maintenance_print_symbols): Remove declaration.
 744         (maintenance_info_symtabs): Use compunit_filetabs.
 745         (maintenance_info_line_tables): Likewise.
 746         * source.c (select_source_symtab): Change local variable name.
 747         (forget_cached_source_info_for_objfile): Remove declaration.
 748         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 749         * objfiles.c (objfile_relocate1): Remove declaration.
 750         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 751         declaration.
 752         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 753         * coffread.c (coff_symtab_read): Remove declaration.
 754         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 755         compunit_filetabs.
 756
 757 2019-01-09  Tom Tromey  <tom@tromey.com>
 758
 759         * symtab.c (lookup_objfile_from_block)
 760         (find_pc_sect_compunit_symtab, search_symbols)
 761         (default_collect_symbol_completion_matches_break_on): Use
 762         objfile_compunits.
 763         * objfiles.h (ALL_COMPUNITS): Remove.
 764         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 765         * cp-support.c (add_symbol_overload_list_qualified): Use
 766         objfile_compunits.
 767         * ada-lang.c (ada_collect_symbol_completion_matches)
 768         (ada_add_global_exceptions): Use objfile_compunits.
 769
 770 2019-01-09  Tom Tromey  <tom@tromey.com>
 771
 772         * source.c (select_source_symtab)
 773         (forget_cached_source_info_for_objfile): Remove declaration.
 774         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 775         declaration.
 776         * maint.c (count_symtabs_and_blocks): Remove declaration.
 777         * cp-support.c (add_symbol_overload_list_qualified): Remove
 778         declaration.
 779         * coffread.c (coff_symtab_read): Remove declaration.
 780         * symtab.c (lookup_symbol_in_objfile_symtabs)
 781         (basic_lookup_transparent_type_1): Use objfile_compunits.
 782         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 783         (info_sources_command, search_symbols)
 784         (default_collect_symbol_completion_matches_break_on)
 785         (make_source_files_completion_list): Remove declaration.
 786         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 787         (ada_collect_symbol_completion_matches)
 788         (ada_add_global_exceptions): Remove declaration.
 789         * linespec.c (iterate_over_all_matching_symtabs): Use
 790         objfile_compunits.
 791         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 792         (class objfile_compunits): New.
 793         (ALL_COMPUNITS): Use objfile_compunits.
 794         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 795         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 796         objfile_compunits.
 797         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 798
 799 2019-01-09  Tom Tromey  <tom@tromey.com>
 800
 801         * symtab.c (search_symbols)
 802         (default_collect_symbol_completion_matches_break_on): Use
 803         objfile_msymbols.
 804         * ada-lang.c (ada_lookup_simple_minsym)
 805         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 806         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 807         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 808         objfile_msymbols.
 809         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 810         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 811         * objc-lang.c (find_methods): Use objfile_msymbols.
 812         (info_selectors_command, info_classes_command): Likewise.
 813         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 814         * objfiles.h (class objfile_msymbols): New.
 815         (ALL_OBJFILE_MSYMBOLS): Remove.
 816         (ALL_MSYMBOLS): Remove.
 817
 818 2019-01-09  Tom Tromey  <tom@tromey.com>
 819
 820         * common/next-iterator.h (next_adapter): Add Iterator template
 821         parameter.
 822         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 823         (class all_objfiles_safe): New.
 824         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 825         * objfiles.c (put_objfile_before): Update comment.
 826         (add_separate_debug_objfile): Likewise.
 827         (free_all_objfiles): Use all_objfiles_safe.
 828         (objfile_purge_solibs): Likewise.
 829
 830 2019-01-09  Tom Tromey  <tom@tromey.com>
 831
 832         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 833         (expand_symtab_containing_pc, lookup_static_symbol)
 834         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 835         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 836         all_objfiles.
 837         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 838         * breakpoint.c (create_overlay_event_breakpoint)
 839         (create_longjmp_master_breakpoint)
 840         (create_std_terminate_master_breakpoint)
 841         (create_exception_master_breakpoint): Use all_objfiles.
 842         * linux-thread-db.c (try_thread_db_load_from_pdir)
 843         (has_libpthread): Use all_objfiles.
 844         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 845         * linespec.c (iterate_over_all_matching_symtabs)
 846         (search_minsyms_for_name): Use all_objfiles.
 847         * maint.c (maintenance_info_sections): Use all_objfiles.
 848         * main.c (captured_main_1): Use all_objfiles.
 849         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 850         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 851         * guile/scm-pretty-print.c
 852         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 853         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 854         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 855         (maintenance_print_msymbols): Use all_objfiles.
 856         * source.c (select_source_symtab): Use all_objfiles.
 857         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 858         * symfile.c (remove_symbol_file_command)
 859         (expand_symtabs_matching, map_symbol_filenames): Use
 860         all_objfiles.
 861         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 862         all_objfiles.
 863         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 864         * objc-lang.c (find_methods): Use all_objfiles.
 865         * objfiles.c (have_partial_symbols, have_full_symbols)
 866         (have_minimal_symbols, qsort_cmp)
 867         (default_iterate_over_objfiles_in_search_order): Use
 868         all_objfiles.
 869         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 870         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 871         (maintenance_check_psymtabs): Use all_objfiles.
 872         (ALL_PSYMTABS): Remove.
 873         * compile/compile-object-run.c (do_module_cleanup): Use
 874         all_objfiles.
 875         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 876         * cp-support.c (add_symbol_overload_list_qualified): Use
 877         all_objfiles.
 878         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 879         Use all_objfiles.
 880         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 881         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 882         all_objfiles.
 883         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 884         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 885         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 886         Uses all_objfiles.
 887         * solib.c (solib_read_symbols): Use all_objfiles
 888
 889 2019-01-09  Tom Tromey  <tom@tromey.com>
 890
 891         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 892         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 893         all_objfiles.
 894         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 895         * symmisc.c (print_symbol_bcache_statistics)
 896         (print_objfile_statistics, maintenance_print_objfiles)
 897         (maintenance_info_symtabs, maintenance_check_symtabs)
 898         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 899         all_objfiles.
 900         * source.c (forget_cached_source_info): Use all_objfiles.
 901         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 902         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 903         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 904         * objfiles.c (update_section_map): Use all_objfiles.
 905         (shared_objfile_contains_address_p): Likewise.
 906         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 907         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 908
 909 2019-01-09  Tom Tromey  <tom@tromey.com>
 910
 911         * common/next-iterator.h: New file.
 912         * objfiles.h (class all_objfiles): New.
 913         (struct objfile_iterator): New.
 914
 915 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 916
 917         * NEWS: Move the description of the changed "frame", "select-frame",
 918          and "info frame" commands to the Changed commands section.
 919
 920 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 921
 922         * gdbtypes.c (check_stub_method_group): Remove handling of old
 923         mangling schemes.
 924         * linespec.c (find_methods): Likewise.
 925         * stabsread.c (read_member_functions): Likewise.
 926         * valops.c (search_struct_method): Likewise.
 927         (value_struct_elt_for_reference): Likewise.
 928         * NEWS: Mention this change.
 929
 930 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 931
 932         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 933         print_source_lines.
 934         * source.c (print_source_lines_base): Update line number check.
 935         (print_source_lines): New function.
 936         (source_lines_range::source_lines_range): New function.
 937         * source.h (class source_lines_range): New class.
 938         (print_source_lines): New declaration.
 939
 940 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 941
 942         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 943
 944 2019-01-08  Tom Tromey  <tom@tromey.com>
 945             Simon Marchi  <simon.marchi@ericsson.com>
 946
 947         PR gdb/24060
 948         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 949         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 950         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 951         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 952         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 953         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 954
 955 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 956
 957         * source.c (select_source_symtab): Move header comment to
 958         declaration in source.h.
 959         (forget_cached_source_info_for_objfile): Likewise.
 960         (forget_cached_source_info): Likewise.
 961         (identify_source_line): Likewise.
 962         * source.h (identify_source_line): Move declaration from symtab.h
 963         and add comment from source.c
 964         (print_source_lines): Likewise.
 965         (forget_cached_source_info_for_objfile): Likewise.
 966         (forget_cached_source_info): Likewise.
 967         (select_source_symtab): Likewise.
 968         (enum print_source_lines_flag): Move definition from symtab.h.
 969         * symtab.h (identify_source_line): Move declaration to source.h.
 970         (print_source_lines): Likewise.
 971         (forget_cached_source_info_for_objfile): Likewise.
 972         (forget_cached_source_info): Likewise.
 973         (select_source_symtab): Likewise.
 974         (enum print_source_lines_flag): Move definition to source.h.
 975         * tui/tui-hooks.c: Add 'source.h' include.
 976
 977 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 978
 979         * source.c (print_source_lines_base): Handle requests to print
 980         reverse line number sequences, and guard against empty lines
 981         string.
 982
 983 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 984
 985         * source.c (print_source_lines_base): Fix skip of '\r' if next
 986         character is '\n'.
 987
 988 2019-01-06  Tom Tromey  <tom@tromey.com>
 989
 990         * c-exp.y (struct c_parse_state) <macro_original_text,
 991         expansion_obstack>: New member.
 992         (macro_original_text, expansion_obstack): Remove globals.
 993         (scan_macro_expansion, scanning_macro_expansion)
 994         (finished_macro_expansion): Update.
 995         (scan_macro_cleanup): Remove.
 996         (yylex, c_parse): Update.
 997
 998 2019-01-06  Tom Tromey  <tom@tromey.com>
 999
1000         * c-exp.y (struct c_parse_state) <strings>: New member.
1001         (operator_stoken): Update.
1002
1003 2019-01-06  Tom Tromey  <tom@tromey.com>
1004
1005         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1006         (union type_stack_elt) <typelist_val>: Now a pointer to
1007         std::vector.
1008         (type_stack_cleanup): Don't declare.
1009         (push_typelist): Update.
1010         * parse.c (pop_typelist): Return a std::vector.
1011         (push_typelist): Take a std::vector.
1012         (follow_types): Update.  Do not free args.
1013         (type_stack_cleanup): Remove.
1014         * c-exp.y (struct c_parse_state): New.
1015         (cpstate): New global.
1016         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1017         (nonempty_typelist): Update.
1018         (func_mod): Create a new vector.
1019         (c_parse): Create a c_parse_state.
1020         (check_parameter_typelist): Do not delete params.
1021         (function_method): Update.  Do not delete type_list.
1022
1023 2019-01-06  Tom Tromey  <tom@tromey.com>
1024
1025         PR gdb/28155:
1026         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1027         check_typedef.
1028         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1029         (print_return_value): Likewise.
1030
1031 2019-01-05  Tom Tromey  <tom@tromey.com>
1032
1033         * contrib/cleanup_check.py: Remove.
1034         * contrib/gcc-with-excheck: Remove.
1035         * contrib/exsummary.py: Remove.
1036         * contrib/excheck.py: Remove.
1037
1038 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1039
1040         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1041         NULL. Initialize tpprev to NULL instead of assigning it
1042         to NULL on the next statement.
1043         * windows-nat.c (windows_delete_thread): Remove check for
1044         main_thread_id before printing thread exit notifications.
1045         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1046         Remove thread ID check against main_thread_id.
1047         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1048         windows_delete_thread.
1049         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1050
1051 2019-01-04  Tom Tromey  <tom@tromey.com>
1052
1053         * compile/compile.c (_initialize_compile): Use upper case for
1054         metasyntactic variables.
1055         * symmisc.c (_initialize_symmisc): Use upper case for
1056         metasyntactic variables.
1057         * psymtab.c (_initialize_psymtab): Use upper case for
1058         metasyntactic variables.
1059         * demangle.c (demangle_command): Use upper case for metasyntactic
1060         variables.
1061         (_initialize_demangler): Likewise.
1062         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1063         variables.
1064
1065 2019-01-03  Tom Tromey  <tom@tromey.com>
1066
1067         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1068
1069 2019-01-03  Tom Tromey  <tom@tromey.com>
1070
1071         * python/py-symtab.c (salpy_str): Update.
1072         (struct salpy_sal_object) <symtab>: Now a PyObject.
1073         (salpy_dealloc): Update.
1074         (del_objfile_sal): Use gdbpy_ref.
1075
1076 2019-01-03  Tom Tromey  <tom@tromey.com>
1077
1078         * python/py-type.c (convert_field): Use new_reference.  Return
1079         gdbpy_ref.
1080         (make_fielditem): Return gdbpy_ref.
1081         (typy_fields): Update.
1082         (typy_getitem): Update.
1083         (field_name): Return gdbpy_ref.  Use new_reference.
1084         (typy_iterator_iternext): Update.
1085
1086 2019-01-03  Tom Tromey  <tom@tromey.com>
1087
1088         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1089
1090 2019-01-03  Tom Tromey  <tom@tromey.com>
1091
1092         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1093         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1094         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1095         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1096         (pspy_set_type_printers): Likewise.
1097         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1098         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1099         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1100         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1101         (objfpy_set_type_printers): Likewise.
1102
1103 2019-01-03  Tom Tromey  <tom@tromey.com>
1104
1105         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1106         (gdbpy_print_stack): Use gdbpy_err_fetch.
1107         * python/python-internal.h (class gdbpy_err_fetch): New class.
1108         (class gdbpy_enter) <m_error_type, m_error_value,
1109         m_error_traceback>: Remove.
1110         <m_error>: New member.
1111         (gdbpy_exception_to_string): Don't declare.
1112         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1113         * python/py-value.c (convert_value_from_python): Use
1114         gdbpy_err_fetch.
1115         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1116         gdbpy_exception_to_string.
1117         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1118         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1119         gdbpy_err_fetch.
1120
1121 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1122
1123         * linux-nat.c (delete_lwp_cleanup): Delete.
1124         (struct lwp_deleter): New struct.
1125         (lwp_info_up): New typedef.
1126         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1127         lwp_info_up.
1128
1129 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1130
1131         * linux-fork.c (class scoped_switch_fork_info): New class.
1132         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1133
1134 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1135
1136         * valops.c (find_overload_match): Remove use of null_cleanup, and
1137         calls to do_cleanups.
1138
1139 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1140
1141         * compile/compile-cplus-types.c
1142         (compile_cplus_instance::decl_name): Handle changes to
1143         cp_func_name.
1144         * cp-support.c (cp_func_name): Update header comment, update
1145         return type.
1146         * cp-support.h (cp_func_name): Update return type in declaration.
1147         * valops.c (find_overload_match): Move temp_func local to top
1148         level of function and change its type.  Use temp_func to hold and
1149         delete temporary string obtained from cp_func_name.
1150
1151 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1152
1153         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1154         gdb::char_vector, remove cleanup, and update uses of `msg`.
1155
1156 2019-01-03  Jim Wilson  <jimw@sifive.com>
1157
1158         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1159
1160 2019-01-02  Tom Tromey  <tom@tromey.com>
1161
1162         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1163         (tdesc_parse_xml): Remove cleanups.
1164         * target-descriptions.h (make_cleanup_free_target_description):
1165         Don't declare.
1166         (target_desc_deleter): New struct.
1167         (target_desc_up): New typedef.
1168         * target-descriptions.c (target_desc_deleter::operator()): Rename
1169         from free_target_description.
1170         (make_cleanup_free_target_description): Remove.
1171
1172 2019-01-02  Tom Tromey  <tom@tromey.com>
1173
1174         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1175         constructor, destructor.
1176         (linespec_parser): Remove typedef.
1177         (~linespec_parser): Rename from linespec_parser_delete.
1178         (linespec_lex_to_end, linespec_complete_label)
1179         (linespec_complete): Update.
1180         (decode_line_full): Remove cleanups.
1181         (decode_line_1): Update.
1182
1183 2019-01-02  Tom Tromey  <tom@tromey.com>
1184
1185         * python/python-internal.h (inferior_to_inferior_object): Change
1186         return type.
1187         * python/py-exitedevent.c (create_exited_event_object): Update.
1188         * python/py-inferior.c (inferior_to_inferior_object): Return
1189         gdbpy_ref.
1190         (python_new_inferior, python_inferior_deleted)
1191         (thread_to_thread_object, delete_thread_object)
1192         (build_inferior_list, gdbpy_selected_inferior): Update.
1193         * python/py-infthread.c (create_thread_object): Update.  Also fail
1194         if inferior_to_inferior_object fails.
1195
1196 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1197
1198         * inferior.h (class inferior) <displaced_step_state>: New field.
1199         * infrun.h (struct displaced_step_state): Move here from
1200         infrun.c.  Initialize fields, add constructor.
1201         <inf>: Remove field.
1202         <reset>: New method.
1203         * infrun.c (struct displaced_step_inferior_state): Move to
1204         infrun.h.
1205         (displaced_step_inferior_states): Remove.
1206         (get_displaced_stepping_state): Adust.
1207         (displaced_step_in_progress_any_inferior): Adjust.
1208         (displaced_step_in_progress_thread): Adjust.
1209         (displaced_step_in_progress): Adjust.
1210         (add_displaced_stepping_state): Remove.
1211         (get_displaced_step_closure_by_addr): Adjust.
1212         (remove_displaced_stepping_state): Remove.
1213         (infrun_inferior_exit): Call displaced_step_state.reset.
1214         (use_displaced_stepping): Don't check for NULL.
1215         (displaced_step_prepare_throw): Call
1216         get_displaced_stepping_state.
1217         (displaced_step_fixup): Don't check for NULL.
1218         (prepare_for_detach): Don't check for NULL.
1219
1220 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1221
1222         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1223          in case of call that did not complete.
1224
1225 2019-01-02  Andrey Utkin  <autkin@undo.io>
1226
1227         * symfile.c (find_separate_debug_file): Fix search of debug files for
1228         remote debuggee.
1229
1230 2019-01-02  Tom Tromey  <tom@tromey.com>
1231
1232         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1233         indentation.
1234         * python/py-frame.c (frapy_older): Remove cast.
1235         (frapy_newer): Likewise.
1236         * python/py-breakpoint.c (local_setattro): Remove cast.
1237         * python/py-arch.c (archpy_name): Remove local variable.
1238         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1239
1240 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1241
1242         * unittests/basic_string_view/element_access/char/empty.cc:
1243         Fix year range in copyright header.
1244
1245 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1246
1247         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1248         Delete.
1249         <operator==>: Update with for removed field.
1250         <hash>: Likewise.
1251         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1252         <isa_features>: ...this.
1253         <abi_features>: New field.
1254         (riscv_isa_flen): Update comment.
1255         (riscv_abi_xlen): New declaration.
1256         (riscv_abi_flen): New declaration.
1257         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1258         isa_features.
1259         (riscv_abi_xlen): New function.
1260         (riscv_isa_flen): Update to get answer from isa_features.
1261         (riscv_abi_flen): New function.
1262         (riscv_has_fp_abi): Update to get answer from abi_features.
1263         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1264         xlen and flen.
1265         (riscv_call_info) <xlen, flen>: Update comment.
1266         (riscv_call_arg_struct): Remove invalid assertions
1267         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1268         is removed.
1269         (riscv_gdbarch_init): Gather isa features and abi features
1270         separately, ensure both match on the gdbarch when reusing an old
1271         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1272         a target with 64-bit float hardware.
1273
1274 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1275
1276         * source.c (search_command_helper): Stop reverse search
1277         when line 1 has been searched.
1278
1279 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1280
1281         * record-full.c (record_full_base_target::close): Rewrite
1282         record_full_core_buf_list free logic.
1283
1284 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1285
1286         * break-catch-syscall.c (print_one_catch_syscall): xfree
1287         the last text.
1288
1289 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1290
1291         * top.c (print_gdb_version): Update Copyright year in version
1292         message.
1293
1294 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1295
1296         Update copyright year range in all GDB files.
1297
1298 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1299
1300         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1301
1302 For older changes see ChangeLog-2018.
1303 \f
1304 Local Variables:
1305 mode: change-log
1306 left-margin: 8
1307 fill-column: 74
1308 version-control: never
1309 coding: utf-8
1310 End:
1311