gdb/ChangeLog

   1 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * macrotab.c (macro_define_internal): New function that
   4         factorizes macro_define_object_internal and macro_define_function
   5         code.
   6         (macro_define_object_internal): Use macro_define_internal.
   7         (macro_define_function): Likewise.
   8
   9 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  10
  11         * macrocmd.c (extract_identifier): Return
  12         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
  13         callers.
  14
  15 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
  16
  17         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
  18
  19 2019-02-05  Tom Tromey  <tom@tromey.com>
  20
  21         * target.c (target_stack::unpush): Move assertion earlier.
  22
  23 2019-01-30  Tom Tromey  <tom@tromey.com>
  24
  25         PR python/23615:
  26         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
  27         (gdbpy_parse_and_eval): Likewise.
  28         * python/python-internal.h (gdbpy_allow_threads): New class.
  29
  30 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
  31
  32         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
  33         (aarch64_fbsd_fpregmap): Move earlier.
  34         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
  35         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
  36         instead of individual calls to trad_frame_set_reg_addr.
  37         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
  38         earlier.
  39         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
  40         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
  41         instead of individual calls to trad_frame_set_reg_addr.
  42
  43 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
  44
  45         * CONTRIBUTE: Replace contribution list with wiki link.
  46
  47 2019-01-25  Tom Tromey  <tom@tromey.com>
  48
  49         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
  50
  51 2019-01-25  Tom Tromey  <tom@tromey.com>
  52
  53         * xtensa-linux-nat.c: Fix common/ includes.
  54         * xml-support.h: Fix common/ includes.
  55         * xml-support.c: Fix common/ includes.
  56         * x86-linux-nat.c: Fix common/ includes.
  57         * windows-nat.c: Fix common/ includes.
  58         * varobj.h: Fix common/ includes.
  59         * varobj.c: Fix common/ includes.
  60         * value.c: Fix common/ includes.
  61         * valops.c: Fix common/ includes.
  62         * utils.c: Fix common/ includes.
  63         * unittests/xml-utils-selftests.c: Fix common/ includes.
  64         * unittests/utils-selftests.c: Fix common/ includes.
  65         * unittests/unpack-selftests.c: Fix common/ includes.
  66         * unittests/tracepoint-selftests.c: Fix common/ includes.
  67         * unittests/style-selftests.c: Fix common/ includes.
  68         * unittests/string_view-selftests.c: Fix common/ includes.
  69         * unittests/scoped_restore-selftests.c: Fix common/ includes.
  70         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
  71         * unittests/scoped_fd-selftests.c: Fix common/ includes.
  72         * unittests/rsp-low-selftests.c: Fix common/ includes.
  73         * unittests/parse-connection-spec-selftests.c: Fix common/
  74         includes.
  75         * unittests/optional-selftests.c: Fix common/ includes.
  76         * unittests/offset-type-selftests.c: Fix common/ includes.
  77         * unittests/observable-selftests.c: Fix common/ includes.
  78         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
  79         * unittests/memrange-selftests.c: Fix common/ includes.
  80         * unittests/memory-map-selftests.c: Fix common/ includes.
  81         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
  82         * unittests/function-view-selftests.c: Fix common/ includes.
  83         * unittests/environ-selftests.c: Fix common/ includes.
  84         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
  85         * unittests/common-utils-selftests.c: Fix common/ includes.
  86         * unittests/cli-utils-selftests.c: Fix common/ includes.
  87         * unittests/array-view-selftests.c: Fix common/ includes.
  88         * ui-file.c: Fix common/ includes.
  89         * tui/tui-io.c: Fix common/ includes.
  90         * tracepoint.h: Fix common/ includes.
  91         * tracepoint.c: Fix common/ includes.
  92         * tracefile-tfile.c: Fix common/ includes.
  93         * top.h: Fix common/ includes.
  94         * top.c: Fix common/ includes.
  95         * thread.c: Fix common/ includes.
  96         * target/waitstatus.h: Fix common/ includes.
  97         * target/waitstatus.c: Fix common/ includes.
  98         * target.h: Fix common/ includes.
  99         * target.c: Fix common/ includes.
 100         * target-memory.c: Fix common/ includes.
 101         * target-descriptions.c: Fix common/ includes.
 102         * symtab.h: Fix common/ includes.
 103         * symfile.c: Fix common/ includes.
 104         * stap-probe.c: Fix common/ includes.
 105         * spu-linux-nat.c: Fix common/ includes.
 106         * sparc-nat.c: Fix common/ includes.
 107         * source.c: Fix common/ includes.
 108         * solib.c: Fix common/ includes.
 109         * solib-target.c: Fix common/ includes.
 110         * ser-unix.c: Fix common/ includes.
 111         * ser-tcp.c: Fix common/ includes.
 112         * ser-pipe.c: Fix common/ includes.
 113         * ser-base.c: Fix common/ includes.
 114         * selftest-arch.c: Fix common/ includes.
 115         * s12z-tdep.c: Fix common/ includes.
 116         * rust-exp.y: Fix common/ includes.
 117         * rs6000-aix-tdep.c: Fix common/ includes.
 118         * riscv-tdep.c: Fix common/ includes.
 119         * remote.c: Fix common/ includes.
 120         * remote-notif.h: Fix common/ includes.
 121         * remote-fileio.h: Fix common/ includes.
 122         * remote-fileio.c: Fix common/ includes.
 123         * regcache.h: Fix common/ includes.
 124         * regcache.c: Fix common/ includes.
 125         * record-btrace.c: Fix common/ includes.
 126         * python/python.c: Fix common/ includes.
 127         * python/py-type.c: Fix common/ includes.
 128         * python/py-inferior.c: Fix common/ includes.
 129         * progspace.h: Fix common/ includes.
 130         * producer.c: Fix common/ includes.
 131         * procfs.c: Fix common/ includes.
 132         * proc-api.c: Fix common/ includes.
 133         * printcmd.c: Fix common/ includes.
 134         * ppc-linux-nat.c: Fix common/ includes.
 135         * parser-defs.h: Fix common/ includes.
 136         * osdata.c: Fix common/ includes.
 137         * obsd-nat.c: Fix common/ includes.
 138         * nat/x86-linux.c: Fix common/ includes.
 139         * nat/x86-linux-dregs.c: Fix common/ includes.
 140         * nat/x86-dregs.h: Fix common/ includes.
 141         * nat/x86-dregs.c: Fix common/ includes.
 142         * nat/ppc-linux.c: Fix common/ includes.
 143         * nat/mips-linux-watch.h: Fix common/ includes.
 144         * nat/mips-linux-watch.c: Fix common/ includes.
 145         * nat/linux-waitpid.c: Fix common/ includes.
 146         * nat/linux-ptrace.h: Fix common/ includes.
 147         * nat/linux-ptrace.c: Fix common/ includes.
 148         * nat/linux-procfs.c: Fix common/ includes.
 149         * nat/linux-personality.c: Fix common/ includes.
 150         * nat/linux-osdata.c: Fix common/ includes.
 151         * nat/linux-namespaces.c: Fix common/ includes.
 152         * nat/linux-btrace.h: Fix common/ includes.
 153         * nat/linux-btrace.c: Fix common/ includes.
 154         * nat/fork-inferior.c: Fix common/ includes.
 155         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 156         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 157         * nat/aarch64-linux.c: Fix common/ includes.
 158         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 159         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 160         * namespace.h: Fix common/ includes.
 161         * mips-linux-tdep.c: Fix common/ includes.
 162         * minsyms.c: Fix common/ includes.
 163         * mi/mi-parse.h: Fix common/ includes.
 164         * mi/mi-main.c: Fix common/ includes.
 165         * mi/mi-cmd-env.c: Fix common/ includes.
 166         * memrange.h: Fix common/ includes.
 167         * memattr.c: Fix common/ includes.
 168         * maint.h: Fix common/ includes.
 169         * maint.c: Fix common/ includes.
 170         * main.c: Fix common/ includes.
 171         * machoread.c: Fix common/ includes.
 172         * location.c: Fix common/ includes.
 173         * linux-thread-db.c: Fix common/ includes.
 174         * linux-nat.c: Fix common/ includes.
 175         * linux-fork.c: Fix common/ includes.
 176         * inline-frame.c: Fix common/ includes.
 177         * infrun.c: Fix common/ includes.
 178         * inflow.c: Fix common/ includes.
 179         * inferior.h: Fix common/ includes.
 180         * inferior.c: Fix common/ includes.
 181         * infcmd.c: Fix common/ includes.
 182         * inf-ptrace.c: Fix common/ includes.
 183         * inf-child.c: Fix common/ includes.
 184         * ia64-linux-nat.c: Fix common/ includes.
 185         * i387-tdep.c: Fix common/ includes.
 186         * i386-tdep.c: Fix common/ includes.
 187         * i386-linux-tdep.c: Fix common/ includes.
 188         * i386-linux-nat.c: Fix common/ includes.
 189         * i386-go32-tdep.c: Fix common/ includes.
 190         * i386-fbsd-tdep.c: Fix common/ includes.
 191         * i386-fbsd-nat.c: Fix common/ includes.
 192         * guile/scm-type.c: Fix common/ includes.
 193         * guile/guile.c: Fix common/ includes.
 194         * go32-nat.c: Fix common/ includes.
 195         * gnu-nat.c: Fix common/ includes.
 196         * gdbthread.h: Fix common/ includes.
 197         * gdbarch-selftests.c: Fix common/ includes.
 198         * gdb_usleep.c: Fix common/ includes.
 199         * gdb_select.h: Fix common/ includes.
 200         * gdb_bfd.c: Fix common/ includes.
 201         * gcore.c: Fix common/ includes.
 202         * fork-child.c: Fix common/ includes.
 203         * findvar.c: Fix common/ includes.
 204         * fbsd-nat.c: Fix common/ includes.
 205         * event-top.c: Fix common/ includes.
 206         * event-loop.c: Fix common/ includes.
 207         * dwarf2read.c: Fix common/ includes.
 208         * dwarf2loc.c: Fix common/ includes.
 209         * dwarf2-frame.c: Fix common/ includes.
 210         * dwarf-index-cache.c: Fix common/ includes.
 211         * dtrace-probe.c: Fix common/ includes.
 212         * disasm-selftests.c: Fix common/ includes.
 213         * defs.h: Fix common/ includes.
 214         * csky-tdep.c: Fix common/ includes.
 215         * cp-valprint.c: Fix common/ includes.
 216         * cp-support.h: Fix common/ includes.
 217         * cp-support.c: Fix common/ includes.
 218         * corelow.c: Fix common/ includes.
 219         * completer.h: Fix common/ includes.
 220         * completer.c: Fix common/ includes.
 221         * compile/compile.c: Fix common/ includes.
 222         * compile/compile-loc2c.c: Fix common/ includes.
 223         * compile/compile-cplus-types.c: Fix common/ includes.
 224         * compile/compile-cplus-symbols.c: Fix common/ includes.
 225         * command.h: Fix common/ includes.
 226         * cli/cli-dump.c: Fix common/ includes.
 227         * cli/cli-cmds.c: Fix common/ includes.
 228         * charset.c: Fix common/ includes.
 229         * build-id.c: Fix common/ includes.
 230         * btrace.h: Fix common/ includes.
 231         * btrace.c: Fix common/ includes.
 232         * breakpoint.h: Fix common/ includes.
 233         * breakpoint.c: Fix common/ includes.
 234         * ax.h:
 235         (enum agent_op): Fix common/ includes.
 236         * ax-general.c (struct aop_map): Fix common/ includes.
 237         * ax-gdb.c: Fix common/ includes.
 238         * auxv.c: Fix common/ includes.
 239         * auto-load.c: Fix common/ includes.
 240         * arm-tdep.c: Fix common/ includes.
 241         * arch/riscv.c: Fix common/ includes.
 242         * arch/ppc-linux-common.c: Fix common/ includes.
 243         * arch/i386.c: Fix common/ includes.
 244         * arch/arm.c: Fix common/ includes.
 245         * arch/arm-linux.c: Fix common/ includes.
 246         * arch/arm-get-next-pcs.c: Fix common/ includes.
 247         * arch/amd64.c: Fix common/ includes.
 248         * arch/aarch64.c: Fix common/ includes.
 249         * arch/aarch64-insn.c: Fix common/ includes.
 250         * arch-utils.c: Fix common/ includes.
 251         * amd64-windows-tdep.c: Fix common/ includes.
 252         * amd64-tdep.c: Fix common/ includes.
 253         * amd64-sol2-tdep.c: Fix common/ includes.
 254         * amd64-obsd-tdep.c: Fix common/ includes.
 255         * amd64-nbsd-tdep.c: Fix common/ includes.
 256         * amd64-linux-tdep.c: Fix common/ includes.
 257         * amd64-linux-nat.c: Fix common/ includes.
 258         * amd64-fbsd-tdep.c: Fix common/ includes.
 259         * amd64-fbsd-nat.c: Fix common/ includes.
 260         * amd64-dicos-tdep.c: Fix common/ includes.
 261         * amd64-darwin-tdep.c: Fix common/ includes.
 262         * agent.c: Fix common/ includes.
 263         * ada-lang.h: Fix common/ includes.
 264         * ada-lang.c: Fix common/ includes.
 265         * aarch64-tdep.c: Fix common/ includes.
 266
 267 2019-01-25  Tom Tromey  <tom@tromey.com>
 268
 269         * common/create-version.sh: Use common/version.h.
 270
 271 2019-01-24  Pedro Alves  <palves@redhat.com>
 272
 273         * infrun.c (signal_stop, signal_print, signal_program)
 274         (signal_catch, signal_pass): Now arrays instead of pointers.
 275         (update_signals_program_target, do_target_resume)
 276         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 277         * linux-nat.c (linux_nat_target::pass_signals)
 278         (linux_nat_target::create_inferior, linux_nat_target::attach):
 279         Adjust.
 280         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 281         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 282         * procfs.c (procfs_target::pass_signals): Adjust.
 283         * record-full.c (record_full_target::resume): Adjust.
 284         * remote.c (remote_target::pass_signals)
 285         (remote_target::program_signals): Adjust.
 286         * target-debug.h (target_debug_print_signals): Now takes a
 287         gdb::array_view as parameter.  Adjust.
 288         * target.h (target_ops) <pass_signals, program_signals>: Replace
 289         pointer and length parameters with gdb::array_view.
 290         (target_pass_signals, target_program_signals): Likewise.
 291         * target-delegates.c: Regenerate.
 292
 293 2019-01-24  Pedro Alves  <palves@redhat.com>
 294
 295         * common/forward-scope-exit.h
 296         (forward_scope_exit::forward_scope_exit): Pass arguments to
 297         m_bind_function directly, instead of creating a std::bind and
 298         copying that.
 299
 300 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 301
 302         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 303         for static members.
 304         (pass_in_v_vfp_candidate): Likewise.
 305
 306 2019-01-23  Tom Tromey  <tom@tromey.com>
 307             Pedro Alves  <palves@redhat.com>
 308
 309         * regcache.c (class regcache_invalidator): Remove.
 310         (regcache::raw_write): Use make_scope_exit.
 311
 312 2019-01-23  Tom Tromey  <tom@tromey.com>
 313
 314         * ui-out.h (class ui_out_emit_type): Update comment.
 315
 316 2019-01-23  Tom Tromey  <tom@tromey.com>
 317
 318         * infrun.c (fetch_inferior_event): Update comment.
 319
 320 2019-01-23  Tom Tromey  <tom@tromey.com>
 321             Pedro Alves  <palves@redhat.com>
 322
 323         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 324         parameter.
 325         (fetch_inferior_event): Use SCOPE_EXIT.
 326
 327
 328 2019-01-23  Tom Tromey  <tom@tromey.com>
 329             Pedro Alves  <palves@redhat.com>
 330
 331         * infrun.c (disable_thread_events): Delete.
 332         (stop_all_threads): Use SCOPE_EXIT.
 333
 334 2019-01-23  Tom Tromey  <tom@tromey.com>
 335             Pedro Alves  <palves@redhat.com>
 336
 337         * symfile.c: Include forward-scope-exit.h.
 338         (clear_symtab_users_cleanup): Replace forward declaration with
 339         a FORWARD_SCOPE_EXIT.
 340         (syms_from_objfile_1): Use the forward_scope_exit and
 341         gdb::optional instead of cleanup_function.
 342         (reread_symbols): Use the forward_scope_exit instead of
 343         cleanup_function.
 344         (clear_symtab_users_cleanup): Remove function.
 345
 346 2019-01-23  Tom Tromey  <tom@tromey.com>
 347             Pedro Alves  <palves@redhat.com>
 348
 349         * linux-nat.c: Include scope-exit.h.
 350         (cleanup_target_stop): Remove.
 351         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 352         SCOPE_EXIT.
 353
 354 2019-01-23  Tom Tromey  <tom@tromey.com>
 355             Pedro Alves  <palves@redhat.com>
 356
 357         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 358         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 359
 360 2019-01-23  Tom Tromey  <tom@tromey.com>
 361             Andrew Burgess  <andrew.burgess@embecosm.com>
 362             Pedro Alves  <palves@redhat.com>
 363
 364         * infrun.c (fetch_inferior_event): Use scope_exit.
 365         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 366         * top.c (execute_command): Use scope_exit.
 367         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 368         * utils.c (do_bpstat_clear_actions_cleanup)
 369         (make_bpstat_clear_actions_cleanup): Remove.
 370
 371 2019-01-23  Tom Tromey  <tom@tromey.com>
 372             Pedro Alves  <palves@redhat.com>
 373
 374         * infrun.c: Include "common/scope-exit.h"
 375         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 376         (wait_for_inferior): Use SCOPE_EXIT.
 377         (fetch_inferior_event): Use scope_exit.
 378
 379 2019-01-23  Tom Tromey  <tom@tromey.com>
 380             Pedro Alves  <palves@redhat.com>
 381
 382         * breakpoint.c (create_breakpoint): Remove cleanup.
 383
 384 2019-01-23  Tom Tromey  <tom@tromey.com>
 385             Andrew Burgess  <andrew.burgess@embecosm.com>
 386             Pedro Alves  <palves@redhat.com>
 387
 388 2019-01-23  Pedro Alves  <palves@redhat.com>
 389
 390         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 391
 392 2019-01-23  Pedro Alves  <palves@redhat.com>
 393             Andrew Burgess  <andrew.burgess@embecosm.com>
 394
 395         * gdbthread.h: Include "common/forward-scope-exit.h".
 396         (scoped_finish_thread_state): Redefine custom class in terms of
 397         forward_scope_exit.
 398
 399 2019-01-23  Pedro Alves  <palves@redhat.com>
 400             Andrew Burgess  <andrew.burgess@embecosm.com>
 401
 402         * common/forward-scope-exit.h: New file.
 403
 404 2019-01-23  Pedro Alves  <palves@redhat.com>
 405             Andrew Burgess  <andrew.burgess@embecosm.com>
 406             Tom Tromey  <tom@tromey.com>
 407
 408         * common/scope-exit.h: New file.
 409
 410 2019-01-23  Pedro Alves  <palves@redhat.com>
 411
 412         * common/preprocessor.h (ESC): Rename to ...
 413         (ESC_PARENS): ... this.
 414         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 415         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 416
 417 2019-01-23  Tom Tromey  <tom@tromey.com>
 418
 419         * language.h (class scoped_switch_to_sym_language_if_auto):
 420         Initialize m_lang in both cases.
 421
 422 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 423
 424         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 425         with XCNEW.
 426
 427 2019-01-22  Tom Tromey  <tom@tromey.com>
 428
 429         * corelow.c: Do not include sys/file.h.
 430
 431 2019-01-22  Tom Tromey  <tom@tromey.com>
 432
 433         * tui/tui-wingeneral.h: Include gdb_curses.h.
 434
 435 2019-01-22  Tom Tromey  <tom@tromey.com>
 436
 437         * source-cache.h (class source_cache) <get_source_lines,
 438         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 439
 440 2019-01-22  Tom Tromey  <tom@tromey.com>
 441
 442         * remote-fileio.h (struct remote_target): Declare.
 443
 444 2019-01-22  Tom Tromey  <tom@tromey.com>
 445
 446         * python/py-arch.c: Do not include py-ref.h.
 447         * python/py-bpevent.c: Do not include py-ref.h.
 448         * python/py-cmd.c: Do not include py-ref.h.
 449         * python/py-continueevent.c: Do not include py-ref.h.
 450         * python/py-event.h: Do not include py-ref.h.
 451         * python/py-evtregistry.c: Do not include py-ref.h.
 452         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 453         * python/py-frame.c: Do not include py-ref.h.
 454         * python/py-framefilter.c: Do not include py-ref.h.
 455         * python/py-function.c: Do not include py-ref.h.
 456         * python/py-infevents.c: Do not include py-ref.h.
 457         * python/py-linetable.c: Do not include py-ref.h.
 458         * python/py-objfile.c: Do not include py-ref.h.
 459         * python/py-param.c: Do not include py-ref.h.
 460         * python/py-prettyprint.c: Do not include py-ref.h.
 461         * python/py-progspace.c: Do not include py-ref.h.
 462         * python/py-symbol.c: Do not include py-ref.h.
 463         * python/py-symtab.c: Do not include py-ref.h.
 464         * python/py-type.c: Do not include py-ref.h.
 465         * python/py-unwind.c: Do not include py-ref.h.
 466         * python/py-utils.c: Do not include py-ref.h.
 467         * python/py-value.c: Do not include py-ref.h.
 468         * python/py-varobj.c: Do not include py-ref.h.
 469         * python/py-xmethods.c: Do not include py-ref.h.
 470         * python/python.c: Do not include py-ref.h.
 471         * varobj.c: Do not include py-ref.h.
 472
 473 2019-01-22  Tom Tromey  <tom@tromey.com>
 474
 475         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 476         keyword for bcache.
 477
 478 2019-01-22  Tom Tromey  <tom@tromey.com>
 479
 480         * compile/compile-cplus-types.c: Remove a comment by #include.
 481
 482 2019-01-22  Tom Tromey  <tom@tromey.com>
 483
 484         * compile/gcc-c-plugin.h: Include compile-internal.h.
 485
 486 2019-01-22  Tom Tromey  <tom@tromey.com>
 487
 488         * stabsread.c (EXTERN): Do not define.
 489         (symnum, next_symbol_text_func, processing_gcc_compilation)
 490         (within_function, global_sym_chain, global_stabs)
 491         (previous_stab_code, this_object_header_files)
 492         (n_this_object_header_files)
 493         (n_allocated_this_object_header_files): Define.
 494         * stabsread.h (EXTERN): Never define.  Use "extern".
 495
 496 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 497
 498         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 499         history_value.
 500
 501 2019-01-21  Tom Tromey  <tom@tromey.com>
 502
 503         * ui-out.c: Fix includes.
 504         * tui/tui-source.c: Fix includes.
 505         * target.c: Fix includes.
 506         * remote.c: Fix includes.
 507         * regcache.c: Fix includes.
 508         * python/py-block.c: Fix includes.
 509         * printcmd.c: Fix includes.
 510         * or1k-tdep.c: Fix includes.
 511         * mi/mi-main.c: Fix includes.
 512         * m32r-tdep.c: Fix includes.
 513         * csky-tdep.c: Fix includes.
 514         * compile/compile-cplus-types.c: Fix includes.
 515         * cli/cli-interp.c: Fix includes.
 516
 517 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 518
 519         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 520         for padding.
 521
 522 2019-01-16  Tom Tromey  <tom@tromey.com>
 523
 524         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 525         earlier.
 526         (struct objfile) <msymbols_range>: Move from top level.
 527         <msymbols>: New method.
 528         (class objfile_msymbols): Remove.
 529         * symtab.c (default_collect_symbol_completion_matches_break_on):
 530         Update.
 531         * symmisc.c (dump_msymbols): Update.
 532         * stabsread.c (scan_file_globals): Update.
 533         * objc-lang.c (info_selectors_command, info_classes_command)
 534         (find_methods): Update.
 535         * minsyms.c (find_solib_trampoline_target): Update.
 536         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 537         * coffread.c (coff_symfile_read): Update.
 538         * ada-lang.c (ada_lookup_simple_minsym)
 539         (ada_collect_symbol_completion_matches): Update.
 540
 541 2019-01-16  Tom Tromey  <tom@tromey.com>
 542
 543         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 544         type.  Remove no-argument constructor.
 545         <iterator::operator++>: Simplify.
 546         <begin>: Update.
 547         <end>: Use minimal_symbol_count.
 548
 549 2019-01-16  Tom Tromey  <tom@tromey.com>
 550
 551         * objfiles.h (struct objfile) <psymtabs>: New method.
 552         (class objfile_psymtabs): Remove.
 553         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 554         typedef.
 555         <range>: New method.
 556         (require_partial_symbols): Change return type.
 557         * psymtab.c (require_partial_symbols)
 558         (psym_expand_symtabs_matching): Update.
 559         * mdebugread.c (parse_partial_symbols): Update.
 560         * dbxread.c (dbx_end_psymtab): Update.
 561
 562 2019-01-15  Tom Tromey  <tom@tromey.com>
 563
 564         * symtab.c (lookup_objfile_from_block)
 565         (lookup_symbol_in_objfile_symtabs)
 566         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 567         (find_line_symtab, info_sources_command)
 568         (default_collect_symbol_completion_matches_break_on)
 569         (make_source_files_completion_list): Update.
 570         * symmisc.c (print_objfile_statistics, dump_objfile)
 571         (maintenance_print_symbols, maintenance_info_symtabs)
 572         (maintenance_check_symtabs, maintenance_info_line_tables):
 573         Update.
 574         * source.c (select_source_symtab)
 575         (forget_cached_source_info_for_objfile): Update.
 576         * objfiles.h (class objfile_compunits): Remove.
 577         (struct objfile) <compunits_range>: New typedef.
 578         (compunits): New method.
 579         * objfiles.c (objfile_relocate1): Update.
 580         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 581         * maint.c (count_symtabs_and_blocks): Update.
 582         * linespec.c (iterate_over_all_matching_symtabs): Update.
 583         * cp-support.c (add_symbol_overload_list_qualified): Update.
 584         * coffread.c (coff_symtab_read): Update.
 585         * ada-lang.c (add_nonlocal_symbols)
 586         (ada_collect_symbol_completion_matches)
 587         (ada_add_global_exceptions): Update.
 588
 589 2019-01-15  Tom Tromey  <tom@tromey.com>
 590
 591         * progspace.h (program_space) <objfiles_safe_range>: New
 592         typedef.
 593         <objfiles_safe>: New method.
 594         * objfiles.h (class all_objfiles_safe): Remove.
 595         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 596         * jit.c (jit_inferior_exit_hook): Update.
 597
 598 2019-01-17  Tom Tromey  <tom@tromey.com>
 599
 600         * progspace.h (program_space) <objfiles_range>: New typedef.
 601         <objfiles>: New method.
 602         <objfiles_head>: Rename from objfiles.
 603         (object_files): Update.
 604         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 605         * guile/scm-pretty-print.c
 606         (ppscm_find_pretty_printer_from_objfiles): Update.
 607         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 608         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 609         Update.
 610         * python/py-progspace.c (pspy_get_objfiles): Update.
 611         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 612         Update.
 613         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 614         (objfpy_lookup_objfile_by_build_id): Update.
 615         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 616         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 617         Update.
 618         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 619         (expand_symtab_containing_pc, lookup_objfile_from_block)
 620         (lookup_static_symbol, basic_lookup_transparent_type)
 621         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 622         (find_line_symtab, info_sources_command)
 623         (default_collect_symbol_completion_matches_break_on)
 624         (make_source_files_completion_list, find_main_name): Update.
 625         * symmisc.c (print_symbol_bcache_statistics)
 626         (print_objfile_statistics, maintenance_print_symbols)
 627         (maintenance_print_msymbols, maintenance_print_objfiles)
 628         (maintenance_info_symtabs, maintenance_check_symtabs)
 629         (maintenance_expand_symtabs, maintenance_info_line_tables):
 630         Update.
 631         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 632         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 633         (map_overlay_command, unmap_overlay_command)
 634         (simple_overlay_update, expand_symtabs_matching)
 635         (map_symbol_filenames): Update.
 636         * symfile-debug.c (set_debug_symfile): Update.
 637         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 638         Update.
 639         * source.c (select_source_symtab, forget_cached_source_info):
 640         Update.
 641         * solib.c (solib_read_symbols): Update.
 642         * solib-spu.c (append_ocl_sos): Update.
 643         * psymtab.c (maintenance_print_psymbols)
 644         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 645         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 646         * printcmd.c (info_symbol_command): Update.
 647         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 648         Update.
 649         * objfiles.h (class all_objfiles): Remove.
 650         * objfiles.c (have_partial_symbols, have_full_symbols)
 651         (have_minimal_symbols, qsort_cmp, update_section_map)
 652         (shared_objfile_contains_address_p)
 653         (default_iterate_over_objfiles_in_search_order): Update.
 654         * objc-lang.c (info_selectors_command, info_classes_command)
 655         (find_methods): Update.
 656         * minsyms.c (find_solib_trampoline_target): Update.
 657         * maint.c (maintenance_info_sections)
 658         (maintenance_translate_address, count_symtabs_and_blocks):
 659         Update.
 660         * main.c (captured_main_1): Update.
 661         * linux-thread-db.c (try_thread_db_load_from_pdir)
 662         (has_libpthread): Update.
 663         * linespec.c (iterate_over_all_matching_symtabs)
 664         (search_minsyms_for_name): Update.
 665         * jit.c (jit_find_objf_with_entry_addr): Update.
 666         * hppa-tdep.c (find_unwind_entry)
 667         (hppa_lookup_stub_minimal_symbol): Update.
 668         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 669         Update.
 670         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 671         (elf_gnu_ifunc_resolve_by_got): Update.
 672         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 673         * dwarf-index-write.c (save_gdb_index_command): Update.
 674         * cp-support.c (add_symbol_overload_list_qualified): Update.
 675         * breakpoint.c (create_overlay_event_breakpoint)
 676         (create_longjmp_master_breakpoint)
 677         (create_std_terminate_master_breakpoint)
 678         (create_exception_master_breakpoint): Update.
 679         * blockframe.c (find_pc_partial_function): Update.
 680         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 681         (ada_collect_symbol_completion_matches)
 682         (ada_add_global_exceptions): Update.
 683
 684 2019-01-17  Tom Tromey  <tom@tromey.com>
 685
 686         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 687         declare VEC.
 688         (solib_target_parse_libraries): Change return type.
 689         (library_list_start_segment, library_list_start_section)
 690         (library_list_end_library, library_list_start_library); Update.
 691         (solib_target_free_library_list): Remove.
 692         (solib_target_parse_libraries): Remove cleanup.  Change return
 693         type.
 694         (solib_target_current_sos): Update.
 695
 696 2019-01-17  Tom Tromey  <tromey@bapiya>
 697
 698         * valprint.c: Replace "the the" with "the".
 699         * symtab.c: Replace "the the" with "the".
 700         * solib.c: Replace "the the" with "the".
 701         * solib-dsbt.c: Replace "the the" with "the".
 702         * linespec.c: Replace "the the" with "the".
 703         * dwarf2loc.h: Replace "the the" with "the".
 704         * amd64-windows-tdep.c: Replace "the the" with "the".
 705         * aarch64-tdep.c: Replace "the the" with "the".
 706
 707 2019-01-16  Keith Seitz  <keiths@redhat.com>
 708
 709         PR gdb/23773
 710         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 711         <builder>: Rename to ..
 712         <m_builder>: ... this and make private.
 713         (dwarf2_cu::get_builder): New method.  Change all users of
 714         `builder' to use this method.
 715         (dwarf2_start_symtab): Move to ...
 716         (dwarf2_cu::start_symtab): ... here.  Update all callers
 717         (setup_type_unit_groups): Move to ...
 718         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 719         callers.
 720         (dwarf2_cu::reset_builder): New method.
 721         (process_full_compunit, process_full_type_unit): Use
 722         dwarf2_cu::reset_builder.
 723         (follow_die_offset): Record the ancestor CU if it is different
 724         from the followed DIE's CU.
 725         (follow_die_sig_1): Likewise.
 726
 727 2019-01-15  Tom Tromey  <tom@tromey.com>
 728
 729         * remote.c (class remote_state) <buf>: Now a char_vector.
 730         <buf_size>: Remove.
 731         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 732         parameter.
 733         (remote_target::getpkt_or_notif_sane_1)
 734         (remote_target::getpkt_sane)
 735         (remote_target::getpkt_or_notif_sane): Likewise.
 736         (class remote_target) <putpkt>: New overload.
 737         (remote_target::read_frame): Change type of "buf_p".  Remove
 738         sizeof_p parameter.
 739         (packet_ok): New overload.
 740         (packet_check_result): New overload.
 741         Update all uses.
 742
 743 2019-01-14  Tom Tromey  <tom@tromey.com>
 744
 745         * remote-notif.c (handle_notification, remote_notif_ack)
 746         (remote_notif_parse): Make "buf" const.
 747         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 748         const.
 749         (remote_notif_parse, remote_notif_ack, handle_notification):
 750         Likewise.
 751         * remote.c (remote_notif_stop_parse): Make "buf" const.
 752         (remote_target::remote_parse_stop_reply): Make "buf" const.
 753         (remote_notif_stop_ack): Make "buf" const.
 754
 755 2019-01-14  Tom Tromey  <tom@tromey.com>
 756
 757         * remote.c (remote_console_output): Make parameter const.
 758
 759 2019-01-14  Tom Tromey  <tom@tromey.com>
 760
 761         * target-debug.h (target_debug_print_signals): Constify.
 762         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 763         * procfs.c (procfs_target::pass_signals): Update.
 764         * linux-nat.c (linux_nat_target::pass_signals): Update.
 765         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 766         * target-delegates.c: Rebuild.
 767         * remote.c (remote_target::program_signals): Update.
 768         (remote_target::pass_signals): Update.
 769         * target.c (target_pass_signals): Constify argument.
 770         (target_program_signals): Likewise.
 771         * target.h (struct target_ops) <pass_signals, program_signals>:
 772         Constify argument.
 773         (target_pass_signals, target_program_signals): Constify argument.
 774
 775 2019-01-14  Tom Tromey  <tom@tromey.com>
 776
 777         PR tui/28819:
 778         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 779
 780 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 781
 782         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 783         field.
 784         * rs6000-tdep.c: Include reggroups.h.
 785         (IS_V_ALIAS_PSEUDOREG): Define.
 786         (rs6000_register_name): Return names for the "vX" aliases.
 787         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 788         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 789         aliases.  Call default_register_reggroup_p for all other
 790         pseudo-registers.
 791         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 792         New functions.
 793         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 794         Handle "vX" aliases.
 795         (v_alias_pseudo_register_collect): New function.
 796         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 797         (rs6000_gdbarch_init): Initialize "vX" aliases as
 798         pseudo-registers.  Restore registration of
 799         rs6000_pseudo_register_reggroup_p with
 800         set_tdesc_pseudo_register_reggroup_p.
 801
 802 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 803
 804         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 805         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 806         set_gdbarch_num_pseudo_regs.
 807
 808 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 809
 810         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 811         Remove arg prefixname, add do_set and do_show.
 812         Add member functions set_list and show_list.
 813         * cli/cli-style.c (class cli_style_option): Update accordingly.
 814         (style_set_list): Move to file scope.
 815         (style_show_list): Likewise.
 816         (set_style): Call help_list.
 817         (show_style): Call cmd_show_list.
 818         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 819         Update to use the new macro.
 820
 821 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 822
 823         * ada-lang.c (_initialize_ada_language): Expand the help text
 824         for the "catch exception" command.
 825
 826 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 827
 828         * symtab.c (matching_obj_sections): Initialize obj,
 829         declare it closer to its usage.
 830
 831 2019-01-10  Tom Tromey  <tom@tromey.com>
 832
 833         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 834         (basic_inf_threads_range): Remove.
 835         (inf_threads_range, inf_non_exited_threads_range)
 836         (safe_inf_threads_range): Use next_adapter.
 837
 838 2019-01-10  Keith Seitz  <keiths@redhat.com>
 839
 840         PR gdb/23712
 841         PR symtab/23010
 842         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 843         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 844
 845 2019-01-10  Keith Seitz  <keiths@redhat.com>
 846
 847         PR gdb/23712
 848         PR symtab/23010
 849         * dictionary.c (pending_to_vector): Remove.
 850         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 851         Remove _1 suffix, replacing functions of the same name.  Update
 852         all callers.
 853         (dict_create_hashed, dict_create_hashed_expandable)
 854         (dict_create_linear, dict_create_linear_expandable, dict_free)
 855         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 856         Make functions static.
 857
 858 2019-01-10  Keith Seitz  <keiths@redhat.com>
 859
 860         PR gdb/23712
 861         PR symtab/23010
 862         * dictionary.h (struct dictionary): Replace declaration with
 863         multidictionary.
 864         (dict_create_hashed, dict_create_hashed_expandable)
 865         (dict_create_linear, dict_create_linear_expandable)
 866         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 867         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 868         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 869         taking multidictionary argument.
 870         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 871         * block.h (struct block) <dict>: Change to multidictionary
 872         and rename `multidict'.
 873         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 874         symmisc.c: Update all dictionary references to multidictionary.
 875
 876 2019-01-10  Keith Seitz  <keiths@redhat.com>
 877
 878         PR gdb/23712
 879         PR symtab/23010
 880         * dictionary.c: Include unordered_map.
 881         (pending_to_vector): New function.
 882         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 883         Rewrite the non-"_1" functions to take vector instead
 884         of linked list.
 885         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 886         "new" _1 versions of the same name.
 887         (multidictionary): Define.
 888         (std::hash<enum language): New definition.
 889         (collate_pending_symbols_by_language, mdict_create_hashed)
 890         (mdict_create_hashed_expandable, mdict_create_linear)
 891         (mdict_create_linear_expandable, mdict_free)
 892         (find_language_dictionary, create_new_language_dictionary)
 893         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 894         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 895         (mdict_size, mdict_empty): New functions.
 896         * dictionary.h (mdict_iterator): Define.
 897
 898 2019-01-10  Pedro Alves  <palves@redhat.com>
 899
 900         * breakpoint.c (read_uploaded_action)
 901         (create_tracepoint_from_upload): Adjust to use
 902         gdb::unique_xmalloc_ptr.
 903         * ctf.c (ctf_write_uploaded_tp):
 904         (SET_ARRAY_FIELD): Use emplace_back.
 905         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 906         * tracefile-tfile.c (tfile_write_uploaded_tp):
 907         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 908         gdb::unique_xmalloc_ptr.
 909         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 910         at_string, cond_string, cmd_strings>: Replace char pointers
 911         with gdb::unique_xmalloc_ptr.
 912
 913 2019-01-10  Pedro Alves  <palves@redhat.com>
 914
 915         * solib-target.c (library_list_start_library): Don't xstrdup name.
 916
 917 2019-01-10  Pedro Alves  <palves@redhat.com>
 918
 919         * mdebugread.c (parse_partial_symbols): Use
 920         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 921
 922 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 923
 924         * linux-fork.c (scoped_switch_fork_info)
 925         <~scoped_switch_fork_info>: Fix incorrect variable name.
 926
 927 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 928
 929         * linux-fork.c (scoped_switch_fork_info)
 930         <scoped_switch_fork_info>: Make explicit.
 931         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 932
 933 2019-01-10  Tom Tromey  <tom@tromey.com>
 934
 935         * objfiles.h (objfile::reset_psymtabs): Update.
 936         * objfiles.c (objfile::objfile): Update.
 937         * psymtab.h (psymtab_storage::obstack): Update.
 938         (psymtab_storage::m_obstack): Use gdb::optional.
 939         (class psymtab_storage): Update comment.  Remove objfile
 940         parameter.
 941         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 942
 943 2019-01-10  Tom Tromey  <tom@tromey.com>
 944
 945         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 946         <free_psymtabs>: Now private.
 947         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 948         (allocate_psymtab): Use new method.
 949
 950 2019-01-10  Tom Tromey  <tom@tromey.com>
 951
 952         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 953         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 954         * mdebugread.c (parse_partial_symbols): Use
 955         allocate_dependencies.
 956         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 957         allocate_dependencies.
 958         (process_psymtab_comp_unit_reader)
 959         (build_type_psymtab_dependencies): Likewise.
 960         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 961
 962 2019-01-10  Tom Tromey  <tom@tromey.com>
 963
 964         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 965         PSYMBOL_SET_LANGUAGE.
 966         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 967
 968 2019-01-10  Tom Tromey  <tom@tromey.com>
 969
 970         * psymtab.h (psymtab_storage::obstack): New method.
 971         <m_obstack>: Rename from obstack; now private.
 972         * psymtab.c (psymtab_storage): Update.
 973         * dwarf2read.c (create_addrmap_from_index)
 974         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 975         Update.
 976
 977 2019-01-10  Tom Tromey  <tom@tromey.com>
 978
 979         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 980         * objfiles.h (objfile::reset_psymtabs): New method.
 981
 982 2019-01-10  Tom Tromey  <tom@tromey.com>
 983
 984         * symmisc.c (print_symbol_bcache_statistics): Update.
 985         (print_objfile_statistics): Update.
 986         * symfile.c (reread_symbols): Update.
 987         * psymtab.h (class psymtab_storage): New.
 988         * psymtab.c (psymtab_storage): New constructor.
 989         (~psymtab_storage): New destructor.
 990         (require_partial_symbols): Update.
 991         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 992         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 993         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 994         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 995         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 996         (start_psymtab_common, end_psymtab_common)
 997         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 998         (allocate_psymtab): Update.
 999         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1000         Update.
1001         (dump_psymtab_addrmap, maintenance_print_psymbols)
1002         (maintenance_check_psymtabs): Update.
1003         (class objfile_psymtabs): Move to objfiles.h.
1004         * psympriv.h (discard_psymtab): Now inline.
1005         (psymtab_discarder::psymtab_discarder): Update.
1006         (psymtab_discarder::~psymtab_discarder): Update.
1007         (ALL_OBJFILE_PSYMTABS): Rewrite.
1008         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1009         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1010         Remove fields.
1011         <partial_symtabs>: New field.
1012         (class objfile_psymtabs): Move from psymtab.h.  Update.
1013         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1014         psymbol_cache.
1015         (objfile::~objfile): Don't destroy psymbol_cache.
1016         * mdebugread.c (parse_partial_symbols): Update.
1017         * dwarf2read.c (create_addrmap_from_index)
1018         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1019         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1020         (add_partial_subprogram, dwarf2_ranges_read): Update.
1021         * dwarf-index-write.c (write_address_map)
1022         (write_one_signatured_type, recursively_write_psymbols)
1023         (class debug_names, class debug_names, write_psymtabs_to_index):
1024         Update.
1025
1026 2019-01-10  Tom Tromey  <tom@tromey.com>
1027
1028         * symtab.h (SYMBOL_SET_NAMES): Update.
1029         (symbol_set_names): Update.
1030         (MSYMBOL_SET_NAMES): Update.
1031         * symtab.c (symbol_set_names): Change argument to be an
1032         objfile_per_bfd_storage.
1033         * psymtab.c (add_psymbol_to_bcache): Update.
1034         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1035
1036 2019-01-10  Tom Tromey  <tom@tromey.com>
1037
1038         * symtab.c (create_demangled_names_hash): Change argument to be an
1039         objfile_per_bfd_storage.
1040         (symbol_set_names): Update.
1041
1042 2019-01-10  Tom Tromey  <tom@tromey.com>
1043
1044         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1045         init_psymbol_list.
1046         * psymtab.c (init_psymbol_list): Do nothing if already called.
1047         * psympriv.h (init_psymbol_list): Add comment.
1048         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1049         init_psymbol_list.
1050         * dbxread.c (dbx_symfile_read): Unconditionally call
1051         init_psymbol_list.
1052
1053 2019-01-10  Tom Tromey  <tom@tromey.com>
1054
1055         * xcoffread.c (scan_xcoff_symtab): Update.
1056         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1057         "where".
1058         * mdebugread.c (parse_partial_symbols)
1059         (handle_psymbol_enumerators): Update.
1060         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1061         * dbxread.c (read_dbx_symtab): Update.
1062         * psympriv.h (psymbol_placement): New enum.
1063         (add_psymbol_to_list): Update.
1064
1065 2019-01-10  Tom Tromey  <tom@tromey.com>
1066
1067         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1068         static_psymbols parameters.
1069         (scan_xcoff_symtab): Update.
1070         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1071         static_psymbols parameters.
1072         * psympriv.h (start_psymtab_common): Update.
1073         * mdebugread.c (parse_partial_symbols): Update.
1074         * dwarf2read.c (create_partial_symtab): Update.
1075         * dbxread.c (read_dbx_symtab): Update.
1076         (start_psymtab): Remove global_psymbols and static_psymbols
1077         parameters.
1078
1079 2019-01-10  Tom Tromey  <tom@tromey.com>
1080
1081         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1082         * psymtab.c (allocate_psymtab): Add comment.
1083         * psympriv.h (allocate_psymtab): Add comment.
1084         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1085         initializations.
1086         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1087
1088 2019-01-10  Tom Tromey  <tom@tromey.com>
1089
1090         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1091         Don't declare.
1092         * mipsread.c: Include mdebugread.h.
1093         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1094         Declare.
1095         * elfread.c: Include mdebugread.h.
1096
1097 2019-01-09  Tom Tromey  <tom@tromey.com>
1098
1099         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1100         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1101         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1102         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1103         (psym_lookup_symbol, psym_find_last_source_symtab)
1104         (psym_forget_cached_source_info, psym_print_stats)
1105         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1106         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1107         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1108         (psym_find_compunit_symtab_by_address)
1109         (maintenance_print_psymbols, maintenance_info_psymtabs)
1110         (maintenance_check_psymtabs): Use ranged for.
1111         * psymtab.h (class objfile_psymtabs): New.
1112         (require_partial_symbols): Return objfile_psymtabs.
1113         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1114
1115 2019-01-09  Tom Tromey  <tom@tromey.com>
1116
1117         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1118         (find_pc_mapped_section, list_overlays_command)
1119         (map_overlay_command, unmap_overlay_command)
1120         (simple_overlay_update): Use all_objfiles.
1121         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1122         * printcmd.c (info_symbol_command): Use all_objfiles.
1123         * objfiles.h (ALL_OBJSECTIONS): Remove.
1124         * maint.c (maintenance_translate_address): Use all_objfiles.
1125         * gcore.c (gcore_create_callback): Use all_objfiles.
1126         (objfile_find_memory_regions): Likewise.
1127
1128 2019-01-09  Tom Tromey  <tom@tromey.com>
1129
1130         * symtab.c (find_line_symtab, info_sources_command)
1131         (make_source_files_completion_list): Use objfile_compunits.
1132         * source.c (select_source_symtab): Use objfile_compunits.
1133         * objfiles.h (struct objfile): Update comment.
1134         (ALL_OBJFILES): Remove.
1135         (ALL_FILETABS): Remove.
1136         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1137         objfile_compunits.
1138
1139 2019-01-09  Tom Tromey  <tom@tromey.com>
1140
1141         * symmisc.c (print_objfile_statistics, dump_objfile)
1142         (maintenance_print_symbols): Use compunit_filetabs.
1143         * source.c (forget_cached_source_info_for_objfile): Use
1144         compunit_filetabs.
1145         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1146         (ALL_FILETABS): Use compunit_filetabs.
1147         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1148         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1149
1150 2019-01-09  Tom Tromey  <tom@tromey.com>
1151
1152         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1153         (compunit_filetabs): New.
1154         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1155         compunit_filetabs.
1156         (info_sources_command, make_source_files_completion_list): Remove
1157         declaration.
1158         * symmisc.c (print_objfile_statistics, dump_objfile)
1159         (maintenance_print_symbols): Remove declaration.
1160         (maintenance_info_symtabs): Use compunit_filetabs.
1161         (maintenance_info_line_tables): Likewise.
1162         * source.c (select_source_symtab): Change local variable name.
1163         (forget_cached_source_info_for_objfile): Remove declaration.
1164         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1165         * objfiles.c (objfile_relocate1): Remove declaration.
1166         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1167         declaration.
1168         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1169         * coffread.c (coff_symtab_read): Remove declaration.
1170         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1171         compunit_filetabs.
1172
1173 2019-01-09  Tom Tromey  <tom@tromey.com>
1174
1175         * symtab.c (lookup_objfile_from_block)
1176         (find_pc_sect_compunit_symtab, search_symbols)
1177         (default_collect_symbol_completion_matches_break_on): Use
1178         objfile_compunits.
1179         * objfiles.h (ALL_COMPUNITS): Remove.
1180         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1181         * cp-support.c (add_symbol_overload_list_qualified): Use
1182         objfile_compunits.
1183         * ada-lang.c (ada_collect_symbol_completion_matches)
1184         (ada_add_global_exceptions): Use objfile_compunits.
1185
1186 2019-01-09  Tom Tromey  <tom@tromey.com>
1187
1188         * source.c (select_source_symtab)
1189         (forget_cached_source_info_for_objfile): Remove declaration.
1190         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1191         declaration.
1192         * maint.c (count_symtabs_and_blocks): Remove declaration.
1193         * cp-support.c (add_symbol_overload_list_qualified): Remove
1194         declaration.
1195         * coffread.c (coff_symtab_read): Remove declaration.
1196         * symtab.c (lookup_symbol_in_objfile_symtabs)
1197         (basic_lookup_transparent_type_1): Use objfile_compunits.
1198         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1199         (info_sources_command, search_symbols)
1200         (default_collect_symbol_completion_matches_break_on)
1201         (make_source_files_completion_list): Remove declaration.
1202         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1203         (ada_collect_symbol_completion_matches)
1204         (ada_add_global_exceptions): Remove declaration.
1205         * linespec.c (iterate_over_all_matching_symtabs): Use
1206         objfile_compunits.
1207         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1208         (class objfile_compunits): New.
1209         (ALL_COMPUNITS): Use objfile_compunits.
1210         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1211         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1212         objfile_compunits.
1213         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1214
1215 2019-01-09  Tom Tromey  <tom@tromey.com>
1216
1217         * symtab.c (search_symbols)
1218         (default_collect_symbol_completion_matches_break_on): Use
1219         objfile_msymbols.
1220         * ada-lang.c (ada_lookup_simple_minsym)
1221         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1222         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1223         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1224         objfile_msymbols.
1225         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1226         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1227         * objc-lang.c (find_methods): Use objfile_msymbols.
1228         (info_selectors_command, info_classes_command): Likewise.
1229         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1230         * objfiles.h (class objfile_msymbols): New.
1231         (ALL_OBJFILE_MSYMBOLS): Remove.
1232         (ALL_MSYMBOLS): Remove.
1233
1234 2019-01-09  Tom Tromey  <tom@tromey.com>
1235
1236         * common/next-iterator.h (next_adapter): Add Iterator template
1237         parameter.
1238         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1239         (class all_objfiles_safe): New.
1240         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1241         * objfiles.c (put_objfile_before): Update comment.
1242         (add_separate_debug_objfile): Likewise.
1243         (free_all_objfiles): Use all_objfiles_safe.
1244         (objfile_purge_solibs): Likewise.
1245
1246 2019-01-09  Tom Tromey  <tom@tromey.com>
1247
1248         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1249         (expand_symtab_containing_pc, lookup_static_symbol)
1250         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1251         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1252         all_objfiles.
1253         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1254         * breakpoint.c (create_overlay_event_breakpoint)
1255         (create_longjmp_master_breakpoint)
1256         (create_std_terminate_master_breakpoint)
1257         (create_exception_master_breakpoint): Use all_objfiles.
1258         * linux-thread-db.c (try_thread_db_load_from_pdir)
1259         (has_libpthread): Use all_objfiles.
1260         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1261         * linespec.c (iterate_over_all_matching_symtabs)
1262         (search_minsyms_for_name): Use all_objfiles.
1263         * maint.c (maintenance_info_sections): Use all_objfiles.
1264         * main.c (captured_main_1): Use all_objfiles.
1265         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1266         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1267         * guile/scm-pretty-print.c
1268         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1269         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1270         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1271         (maintenance_print_msymbols): Use all_objfiles.
1272         * source.c (select_source_symtab): Use all_objfiles.
1273         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1274         * symfile.c (remove_symbol_file_command)
1275         (expand_symtabs_matching, map_symbol_filenames): Use
1276         all_objfiles.
1277         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1278         all_objfiles.
1279         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1280         * objc-lang.c (find_methods): Use all_objfiles.
1281         * objfiles.c (have_partial_symbols, have_full_symbols)
1282         (have_minimal_symbols, qsort_cmp)
1283         (default_iterate_over_objfiles_in_search_order): Use
1284         all_objfiles.
1285         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1286         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1287         (maintenance_check_psymtabs): Use all_objfiles.
1288         (ALL_PSYMTABS): Remove.
1289         * compile/compile-object-run.c (do_module_cleanup): Use
1290         all_objfiles.
1291         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1292         * cp-support.c (add_symbol_overload_list_qualified): Use
1293         all_objfiles.
1294         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1295         Use all_objfiles.
1296         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1297         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1298         all_objfiles.
1299         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1300         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1301         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1302         Uses all_objfiles.
1303         * solib.c (solib_read_symbols): Use all_objfiles
1304
1305 2019-01-09  Tom Tromey  <tom@tromey.com>
1306
1307         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1308         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1309         all_objfiles.
1310         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1311         * symmisc.c (print_symbol_bcache_statistics)
1312         (print_objfile_statistics, maintenance_print_objfiles)
1313         (maintenance_info_symtabs, maintenance_check_symtabs)
1314         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1315         all_objfiles.
1316         * source.c (forget_cached_source_info): Use all_objfiles.
1317         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1318         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1319         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1320         * objfiles.c (update_section_map): Use all_objfiles.
1321         (shared_objfile_contains_address_p): Likewise.
1322         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1323         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1324
1325 2019-01-09  Tom Tromey  <tom@tromey.com>
1326
1327         * common/next-iterator.h: New file.
1328         * objfiles.h (class all_objfiles): New.
1329         (struct objfile_iterator): New.
1330
1331 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1332
1333         * NEWS: Move the description of the changed "frame", "select-frame",
1334          and "info frame" commands to the Changed commands section.
1335
1336 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1337
1338         * gdbtypes.c (check_stub_method_group): Remove handling of old
1339         mangling schemes.
1340         * linespec.c (find_methods): Likewise.
1341         * stabsread.c (read_member_functions): Likewise.
1342         * valops.c (search_struct_method): Likewise.
1343         (value_struct_elt_for_reference): Likewise.
1344         * NEWS: Mention this change.
1345
1346 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1347
1348         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1349         print_source_lines.
1350         * source.c (print_source_lines_base): Update line number check.
1351         (print_source_lines): New function.
1352         (source_lines_range::source_lines_range): New function.
1353         * source.h (class source_lines_range): New class.
1354         (print_source_lines): New declaration.
1355
1356 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1357
1358         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1359
1360 2019-01-08  Tom Tromey  <tom@tromey.com>
1361             Simon Marchi  <simon.marchi@ericsson.com>
1362
1363         PR gdb/24060
1364         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1365         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1366         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1367         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1368         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1369         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1370
1371 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1372
1373         * source.c (select_source_symtab): Move header comment to
1374         declaration in source.h.
1375         (forget_cached_source_info_for_objfile): Likewise.
1376         (forget_cached_source_info): Likewise.
1377         (identify_source_line): Likewise.
1378         * source.h (identify_source_line): Move declaration from symtab.h
1379         and add comment from source.c
1380         (print_source_lines): Likewise.
1381         (forget_cached_source_info_for_objfile): Likewise.
1382         (forget_cached_source_info): Likewise.
1383         (select_source_symtab): Likewise.
1384         (enum print_source_lines_flag): Move definition from symtab.h.
1385         * symtab.h (identify_source_line): Move declaration to source.h.
1386         (print_source_lines): Likewise.
1387         (forget_cached_source_info_for_objfile): Likewise.
1388         (forget_cached_source_info): Likewise.
1389         (select_source_symtab): Likewise.
1390         (enum print_source_lines_flag): Move definition to source.h.
1391         * tui/tui-hooks.c: Add 'source.h' include.
1392
1393 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1394
1395         * source.c (print_source_lines_base): Handle requests to print
1396         reverse line number sequences, and guard against empty lines
1397         string.
1398
1399 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1400
1401         * source.c (print_source_lines_base): Fix skip of '\r' if next
1402         character is '\n'.
1403
1404 2019-01-06  Tom Tromey  <tom@tromey.com>
1405
1406         * c-exp.y (struct c_parse_state) <macro_original_text,
1407         expansion_obstack>: New member.
1408         (macro_original_text, expansion_obstack): Remove globals.
1409         (scan_macro_expansion, scanning_macro_expansion)
1410         (finished_macro_expansion): Update.
1411         (scan_macro_cleanup): Remove.
1412         (yylex, c_parse): Update.
1413
1414 2019-01-06  Tom Tromey  <tom@tromey.com>
1415
1416         * c-exp.y (struct c_parse_state) <strings>: New member.
1417         (operator_stoken): Update.
1418
1419 2019-01-06  Tom Tromey  <tom@tromey.com>
1420
1421         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1422         (union type_stack_elt) <typelist_val>: Now a pointer to
1423         std::vector.
1424         (type_stack_cleanup): Don't declare.
1425         (push_typelist): Update.
1426         * parse.c (pop_typelist): Return a std::vector.
1427         (push_typelist): Take a std::vector.
1428         (follow_types): Update.  Do not free args.
1429         (type_stack_cleanup): Remove.
1430         * c-exp.y (struct c_parse_state): New.
1431         (cpstate): New global.
1432         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1433         (nonempty_typelist): Update.
1434         (func_mod): Create a new vector.
1435         (c_parse): Create a c_parse_state.
1436         (check_parameter_typelist): Do not delete params.
1437         (function_method): Update.  Do not delete type_list.
1438
1439 2019-01-06  Tom Tromey  <tom@tromey.com>
1440
1441         PR gdb/28155:
1442         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1443         check_typedef.
1444         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1445         (print_return_value): Likewise.
1446
1447 2019-01-05  Tom Tromey  <tom@tromey.com>
1448
1449         * contrib/cleanup_check.py: Remove.
1450         * contrib/gcc-with-excheck: Remove.
1451         * contrib/exsummary.py: Remove.
1452         * contrib/excheck.py: Remove.
1453
1454 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1455
1456         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1457         NULL. Initialize tpprev to NULL instead of assigning it
1458         to NULL on the next statement.
1459         * windows-nat.c (windows_delete_thread): Remove check for
1460         main_thread_id before printing thread exit notifications.
1461         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1462         Remove thread ID check against main_thread_id.
1463         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1464         windows_delete_thread.
1465         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1466
1467 2019-01-04  Tom Tromey  <tom@tromey.com>
1468
1469         * compile/compile.c (_initialize_compile): Use upper case for
1470         metasyntactic variables.
1471         * symmisc.c (_initialize_symmisc): Use upper case for
1472         metasyntactic variables.
1473         * psymtab.c (_initialize_psymtab): Use upper case for
1474         metasyntactic variables.
1475         * demangle.c (demangle_command): Use upper case for metasyntactic
1476         variables.
1477         (_initialize_demangler): Likewise.
1478         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1479         variables.
1480
1481 2019-01-03  Tom Tromey  <tom@tromey.com>
1482
1483         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1484
1485 2019-01-03  Tom Tromey  <tom@tromey.com>
1486
1487         * python/py-symtab.c (salpy_str): Update.
1488         (struct salpy_sal_object) <symtab>: Now a PyObject.
1489         (salpy_dealloc): Update.
1490         (del_objfile_sal): Use gdbpy_ref.
1491
1492 2019-01-03  Tom Tromey  <tom@tromey.com>
1493
1494         * python/py-type.c (convert_field): Use new_reference.  Return
1495         gdbpy_ref.
1496         (make_fielditem): Return gdbpy_ref.
1497         (typy_fields): Update.
1498         (typy_getitem): Update.
1499         (field_name): Return gdbpy_ref.  Use new_reference.
1500         (typy_iterator_iternext): Update.
1501
1502 2019-01-03  Tom Tromey  <tom@tromey.com>
1503
1504         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1505
1506 2019-01-03  Tom Tromey  <tom@tromey.com>
1507
1508         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1509         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1510         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1511         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1512         (pspy_set_type_printers): Likewise.
1513         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1514         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1515         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1516         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1517         (objfpy_set_type_printers): Likewise.
1518
1519 2019-01-03  Tom Tromey  <tom@tromey.com>
1520
1521         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1522         (gdbpy_print_stack): Use gdbpy_err_fetch.
1523         * python/python-internal.h (class gdbpy_err_fetch): New class.
1524         (class gdbpy_enter) <m_error_type, m_error_value,
1525         m_error_traceback>: Remove.
1526         <m_error>: New member.
1527         (gdbpy_exception_to_string): Don't declare.
1528         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1529         * python/py-value.c (convert_value_from_python): Use
1530         gdbpy_err_fetch.
1531         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1532         gdbpy_exception_to_string.
1533         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1534         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1535         gdbpy_err_fetch.
1536
1537 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1538
1539         * linux-nat.c (delete_lwp_cleanup): Delete.
1540         (struct lwp_deleter): New struct.
1541         (lwp_info_up): New typedef.
1542         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1543         lwp_info_up.
1544
1545 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1546
1547         * linux-fork.c (class scoped_switch_fork_info): New class.
1548         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1549
1550 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1551
1552         * valops.c (find_overload_match): Remove use of null_cleanup, and
1553         calls to do_cleanups.
1554
1555 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1556
1557         * compile/compile-cplus-types.c
1558         (compile_cplus_instance::decl_name): Handle changes to
1559         cp_func_name.
1560         * cp-support.c (cp_func_name): Update header comment, update
1561         return type.
1562         * cp-support.h (cp_func_name): Update return type in declaration.
1563         * valops.c (find_overload_match): Move temp_func local to top
1564         level of function and change its type.  Use temp_func to hold and
1565         delete temporary string obtained from cp_func_name.
1566
1567 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1568
1569         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1570         gdb::char_vector, remove cleanup, and update uses of `msg`.
1571
1572 2019-01-03  Jim Wilson  <jimw@sifive.com>
1573
1574         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1575
1576 2019-01-02  Tom Tromey  <tom@tromey.com>
1577
1578         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1579         (tdesc_parse_xml): Remove cleanups.
1580         * target-descriptions.h (make_cleanup_free_target_description):
1581         Don't declare.
1582         (target_desc_deleter): New struct.
1583         (target_desc_up): New typedef.
1584         * target-descriptions.c (target_desc_deleter::operator()): Rename
1585         from free_target_description.
1586         (make_cleanup_free_target_description): Remove.
1587
1588 2019-01-02  Tom Tromey  <tom@tromey.com>
1589
1590         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1591         constructor, destructor.
1592         (linespec_parser): Remove typedef.
1593         (~linespec_parser): Rename from linespec_parser_delete.
1594         (linespec_lex_to_end, linespec_complete_label)
1595         (linespec_complete): Update.
1596         (decode_line_full): Remove cleanups.
1597         (decode_line_1): Update.
1598
1599 2019-01-02  Tom Tromey  <tom@tromey.com>
1600
1601         * python/python-internal.h (inferior_to_inferior_object): Change
1602         return type.
1603         * python/py-exitedevent.c (create_exited_event_object): Update.
1604         * python/py-inferior.c (inferior_to_inferior_object): Return
1605         gdbpy_ref.
1606         (python_new_inferior, python_inferior_deleted)
1607         (thread_to_thread_object, delete_thread_object)
1608         (build_inferior_list, gdbpy_selected_inferior): Update.
1609         * python/py-infthread.c (create_thread_object): Update.  Also fail
1610         if inferior_to_inferior_object fails.
1611
1612 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1613
1614         * inferior.h (class inferior) <displaced_step_state>: New field.
1615         * infrun.h (struct displaced_step_state): Move here from
1616         infrun.c.  Initialize fields, add constructor.
1617         <inf>: Remove field.
1618         <reset>: New method.
1619         * infrun.c (struct displaced_step_inferior_state): Move to
1620         infrun.h.
1621         (displaced_step_inferior_states): Remove.
1622         (get_displaced_stepping_state): Adust.
1623         (displaced_step_in_progress_any_inferior): Adjust.
1624         (displaced_step_in_progress_thread): Adjust.
1625         (displaced_step_in_progress): Adjust.
1626         (add_displaced_stepping_state): Remove.
1627         (get_displaced_step_closure_by_addr): Adjust.
1628         (remove_displaced_stepping_state): Remove.
1629         (infrun_inferior_exit): Call displaced_step_state.reset.
1630         (use_displaced_stepping): Don't check for NULL.
1631         (displaced_step_prepare_throw): Call
1632         get_displaced_stepping_state.
1633         (displaced_step_fixup): Don't check for NULL.
1634         (prepare_for_detach): Don't check for NULL.
1635
1636 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1637
1638         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1639          in case of call that did not complete.
1640
1641 2019-01-02  Andrey Utkin  <autkin@undo.io>
1642
1643         * symfile.c (find_separate_debug_file): Fix search of debug files for
1644         remote debuggee.
1645
1646 2019-01-02  Tom Tromey  <tom@tromey.com>
1647
1648         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1649         indentation.
1650         * python/py-frame.c (frapy_older): Remove cast.
1651         (frapy_newer): Likewise.
1652         * python/py-breakpoint.c (local_setattro): Remove cast.
1653         * python/py-arch.c (archpy_name): Remove local variable.
1654         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1655
1656 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1657
1658         * unittests/basic_string_view/element_access/char/empty.cc:
1659         Fix year range in copyright header.
1660
1661 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1662
1663         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1664         Delete.
1665         <operator==>: Update with for removed field.
1666         <hash>: Likewise.
1667         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1668         <isa_features>: ...this.
1669         <abi_features>: New field.
1670         (riscv_isa_flen): Update comment.
1671         (riscv_abi_xlen): New declaration.
1672         (riscv_abi_flen): New declaration.
1673         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1674         isa_features.
1675         (riscv_abi_xlen): New function.
1676         (riscv_isa_flen): Update to get answer from isa_features.
1677         (riscv_abi_flen): New function.
1678         (riscv_has_fp_abi): Update to get answer from abi_features.
1679         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1680         xlen and flen.
1681         (riscv_call_info) <xlen, flen>: Update comment.
1682         (riscv_call_arg_struct): Remove invalid assertions
1683         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1684         is removed.
1685         (riscv_gdbarch_init): Gather isa features and abi features
1686         separately, ensure both match on the gdbarch when reusing an old
1687         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1688         a target with 64-bit float hardware.
1689
1690 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1691
1692         * source.c (search_command_helper): Stop reverse search
1693         when line 1 has been searched.
1694
1695 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1696
1697         * record-full.c (record_full_base_target::close): Rewrite
1698         record_full_core_buf_list free logic.
1699
1700 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1701
1702         * break-catch-syscall.c (print_one_catch_syscall): xfree
1703         the last text.
1704
1705 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1706
1707         * top.c (print_gdb_version): Update Copyright year in version
1708         message.
1709
1710 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1711
1712         Update copyright year range in all GDB files.
1713
1714 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1715
1716         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1717
1718 For older changes see ChangeLog-2018.
1719 \f
1720 Local Variables:
1721 mode: change-log
1722 left-margin: 8
1723 fill-column: 74
1724 version-control: never
1725 coding: utf-8
1726 End:
1727