1 2019-03-12 John Baldwin <jhb@FreeBSD.org>
3 * NEWS: Combine separate "New targets" sections for 8.3.
5 2019-03-14 Eli Zaretskii <eliz@gnu.org>
7 The MS-Windows port of ncurses fails to switch to a color pair if
8 one or both of the colors are the implicit default colors. This
9 change records the default colors when TUI is initialized, and
10 then specifies them explicitly when a color pair uses the default
11 colors. This allows color styling in TUI mode on MS-Windows.
13 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
15 (tui_initialize_io) [__MINGW32__]: Record the default terminal
16 colors in ncurses_norm_attr.
17 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
18 "none", replace it with the default color recorded in
21 2019-03-14 Tom Tromey <tromey@adacore.com>
23 * source-cache.h (class source_cache) <get_source_lines>: Return
25 * source-cache.c (source_cache::extract_lines): Handle case where
26 first_pos==npos. Return std::string.
27 (source_cache::get_source_lines): Update.
29 2019-03-14 Tom Tromey <tromey@adacore.com>
31 * NEWS: Add item for "style sources" commands.
32 * source-cache.c (source_cache::get_source_lines): Check
34 * cli/cli-style.c (source_styling): New global.
35 (_initialize_cli_style): Add "style sources" commands.
36 (show_style_sources): New function.
37 * cli/cli-style.h (source_styling): Declare.
39 2019-03-14 Pedro Alves <palves@redhat.com>
40 Tom Tromey <tromey@adacore.com>
42 * tui/tui-winsource.h (tui_refill_source_window): Declare.
43 * tui/tui-winsource.c (tui_refill_source_window): New function,
45 (tui_horizontal_source_scroll): ... here. Move some logic.
46 * cli/cli-style.c (set_style_enabled): Notify new observable.
47 * tui/tui-hooks.c (tui_redisplay_source): New function.
48 (tui_attach_detach_observers): Attach or detach
50 * observable.h (source_styling_changed): New observable.
51 * observable.c: Define source_styling_changed observable.
53 2019-03-12 Eli Zaretskii <eliz@gnu.org>
56 * source-cache.c: #undef open and close, to avoid unresolved
57 externals during linking.
59 2019-03-08 Eli Zaretskii <eliz@gnu.org>
61 Support styling on native MS-Windows console
64 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
65 on MS-Windows if $TERM is not defined.
67 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
69 * posix-hdep.c (gdb_console_fputs):
70 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
72 * ui-file.h (gdb_console_fputs): Add prototype.
74 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
75 back to fputs only if the former returns zero.
77 2019-03-07 Brian Vandenberg <phantall@gmail.com>
78 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
81 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
82 set_sigint_trap, clear_sigint_trap.
84 2019-03-02 Eli Zaretskii <eliz@gnu.org>
86 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
87 for-loop range, to avoid compiler warnings.
89 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
90 avoid compiler warnings about unused variables.
92 2019-03-02 Eli Zaretskii <eliz@gnu.org>
94 * NEWS: Mention end of support for native debugging on MS-Windows
97 2019-03-02 Eli Zaretskii <eliz@gnu.org>
101 * gdbserver/gdbreplay.c
102 * gdbserver/remote-utils.c:
104 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
105 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
106 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
107 'getaddrinfo' and 'freeaddrinfo' were not available before
108 Windows XP, and mingw.org's MinGW headers by default define
109 _WIN32_WINNT to 0x500.
111 2019-02-27 Kevin Buettner <kevinb@redhat.com>
113 * NEWS: Note minimum Python version.
115 2019-02-27 Joel Brobecker <brobecker@adacore.com>
117 * version.in: Set GDB version number to 8.2.90.DATE-git.
119 2019-02-27 Joel Brobecker <brobecker@adacore.com>
123 2019-02-27 Joel Brobecker <brobecker@adacore.com>
125 * version.in: Set GDB version number to 8.2.90.
127 2019-02-27 Joel Brobecker <brobecker@adacore.com>
129 * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
131 2019-02-27 Joel Brobecker <brobecker@adacore.com>
133 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
134 * version.in: Bump version to 8.2.90.DATE-git.
136 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
138 * aix-thread.c (ptid_cmp): Remove unused variable.
139 (get_signaled_thread): Likewise.
140 (store_regs_user_thread): Likewise.
141 (store_regs_kernel_thread): Likewise.
142 (fetch_regs_kernel_thread): Remove shadowed variable.
144 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
146 * features/riscv/32bit-cpu.xml: Add register numbers.
147 * features/riscv/32bit-fpu.c: Regenerate.
148 * features/riscv/32bit-fpu.xml: Add register numbers.
149 * features/riscv/64bit-cpu.xml: Add register numbers.
150 * features/riscv/64bit-fpu.c: Regenerate.
151 * features/riscv/64bit-fpu.xml: Add register numbers.
153 2019-02-26 Kevin Buettner <kevinb@redhat.com>
155 * NEWS: Mention two argument form of gdb.Value constructor.
156 * python/py-value.c (convert_buffer_and_type_to_value): New
158 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
159 Add support for handling an optional second argument. Call
160 convert_buffer_and_type_to_value as appropriate.
161 * python/python-internal.h (Py_buffer_deleter): New struct.
162 (Py_buffer_up): New typedef.
164 2019-02-25 John Baldwin <jhb@FreeBSD.org>
166 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
167 instead of releasing ownership.
169 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
171 * dwarf2read.c (open_and_init_dwp_file): Call
172 elf_numsections instead of bfd_count_sections to initialize
173 dwp_file->num_sections.
175 2019-02-25 Tom Tromey <tromey@adacore.com>
177 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
179 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
181 * gcore.in: Add '--readnever' option when invoking GDB.
183 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
185 * MAINTAINERS: Update my email address.
187 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
189 * build-id.c (build_id_to_debug_bfd_1): New function.
190 (build_id_to_debug_bfd): Look for separate debug file in
193 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
195 * gdbarch.sh: Update the copyright year range that is placed into
198 2019-02-22 Keith Seitz <keiths@redhat.com>
201 * linespec.c (create_sals_line_offset): Search for the default
202 symtab's filename instead of its fullname.
204 2019-02-21 Alan Hayward <alan.hayward@arm.com>
206 * NEWS: Update style defaults.
208 2019-02-21 Alan Hayward <alan.hayward@arm.com>
210 * main.c (captured_main_1): Disable styling in batch mode.
212 2019-02-20 Tom Tromey <tom@tromey.com>
214 * symtab.c (symtab_symbol_info): Fix typos.
216 2019-02-20 Tom Tromey <tromey@adacore.com>
218 * findcmd.c (_initialize_mem_search): Use upper case for
219 metasyntactic variables.
221 2019-02-20 Alan Hayward <alan.hayward@arm.com>
223 * aarch64-tdep.c (aarch64_add_reggroups): New function.
224 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
226 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
228 * top.h (source_file_name): Change to std::string.
229 * top.c (source_file_name): Likewise.
230 (command_line_input): Adjust.
231 * cli/cli-script.c (script_from_file): Adjust.
233 2019-02-19 Tom Tromey <tromey@adacore.com>
236 (ravenscar_thread_target::update_thread_list): Don't call
238 * ada-lang.h (ada_build_task_list): Don't declare.
239 * ada-tasks.c (struct ada_tasks_inferior_data)
240 <task_list_valid_p>: Now bool.
241 (read_known_tasks, ada_task_list_changed)
242 (ada_tasks_invalidate_inferior_data): Update.
243 (read_known_tasks_array): Return bool.
244 (read_known_tasks_list): Likewise.
245 (read_known_tasks): Return void.
246 (ada_build_task_list): Now static.
248 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
250 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
251 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
253 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
255 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
256 variant for ada_tasks_pspace_data_handle and
257 ada_tasks_inferior_data_handle.
258 (ada_tasks_pspace_data_cleanup): New function.
259 (ada_tasks_inferior_data_cleanup): New function.
261 2019-02-17 Tom Tromey <tom@tromey.com>
263 * macrotab.h (macro_source_fullname): Return a std::string.
264 * macrotab.c (macro_include, check_for_redefinition)
265 (macro_undef, macro_lookup_definition, foreach_macro)
266 (foreach_macro_in_scope): Update.
267 (macro_source_fullname): Return a std::string.
268 * macrocmd.c (show_pp_source_pos): Update.
270 2019-02-17 Tom Tromey <tom@tromey.com>
272 * macrocmd.c (show_pp_source_pos): Style the file names.
274 2019-02-17 Tom Tromey <tom@tromey.com>
277 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
279 2019-02-17 Tom Tromey <tom@tromey.com>
281 * ada-lang.c (user_select_syms): Use filtered printing.
282 * utils.c (wrap_style): New global.
283 (desired_style): Remove.
284 (emit_style_escape): Add stream parameter.
285 (set_output_style, reset_terminal_style, prompt_for_continue):
287 (flush_wrap_buffer): Only flush gdb_stdout.
288 (wrap_here): Set wrap_style.
289 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
290 treat escape sequences as a character. Change when wrap buffer is
292 (fputs_styled): Do not set the output style when the default is
294 * ui-style.h (struct ui_file_style) <is_default>: New method.
295 * source.c (print_source_lines_base): Emit escape sequences in one
298 2019-02-17 Joel Brobecker <brobecker@adacore.com>
300 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
301 integers and enumeration types.
303 2019-02-17 Joel Brobecker <brobecker@adacore.com>
305 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
306 instead of lookup_symbol_in_language
307 (do_exact_match): New function.
308 (ada_get_symbol_name_matcher): Return do_exact_match when
309 doing a verbatim match.
311 2019-02-15 Tom Tromey <tromey@adacore.com>
313 * ravenscar-thread.c (ravenscar_thread_target::resume)
314 (ravenscar_thread_target::wait): Special case wildcard requests.
316 2019-02-15 Tom Tromey <tromey@adacore.com>
318 * ravenscar-thread.c (base_ptid): Remove.
319 (struct ravenscar_thread_target) <close>: New method.
320 <m_base_ptid>: New member.
321 <update_inferior_ptid, active_task, task_is_currently_active,
322 runtime_initialized>: Declare methods.
323 <ravenscar_thread_target>: Add constructor.
324 (ravenscar_thread_target::task_is_currently_active)
325 (ravenscar_thread_target::update_inferior_ptid)
326 (ravenscar_runtime_initialized): Rename. Now methods.
327 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
328 (ravenscar_thread_target::update_thread_list): Update.
329 (ravenscar_thread_target::active_task): Now method.
330 (ravenscar_thread_target::store_registers)
331 (ravenscar_thread_target::prepare_to_store)
332 (ravenscar_thread_target::prepare_to_store)
333 (ravenscar_thread_target::mourn_inferior): Update.
334 (ravenscar_inferior_created): Use "new" to create target.
335 (ravenscar_thread_target::get_ada_task_ptid): Update.
336 (_initialize_ravenscar): Don't initialize base_ptid.
337 (ravenscar_ops): Remove global.
339 2019-02-15 Tom Tromey <tromey@adacore.com>
341 * target.h (push_target): Declare new overload.
342 * target.c (push_target): New overload, taking an rvalue reference.
343 * remote.c (remote_target::open_1): Use push_target overload.
344 * corelow.c (core_target_open): Use push_target overload.
346 2019-02-15 Tom Tromey <tromey@adacore.com>
348 * ravenscar-thread.c (is_ravenscar_task)
349 (ravenscar_task_is_currently_active): Return bool.
350 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
351 (_initialize_ravenscar): Remove "(void)".
352 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
355 2019-02-15 Tom Tromey <tromey@adacore.com>
357 * ravenscar-thread.c (ravenscar_runtime_initializer)
358 (has_ravenscar_runtime, get_running_thread_id)
359 (ravenscar_thread_target::resume): Fix indentation.
361 2019-02-15 Tom Tromey <tromey@adacore.com>
363 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
364 from ravenscar_arch_ops.
365 (sparc_ravenscar_ops::fetch_registers)
366 (sparc_ravenscar_ops::store_registers): Now methods.
367 (sparc_ravenscar_prepare_to_store): Remove.
368 (sparc_ravenscar_ops): Redefine.
369 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
370 methods and destructor. Remove members.
371 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
372 (ravenscar_thread_target::store_registers)
373 (ravenscar_thread_target::prepare_to_store): Update.
374 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
376 (struct ppc_ravenscar_powerpc_ops): Derive from
378 (ppc_ravenscar_powerpc_ops::fetch_registers)
379 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
380 (ppc_ravenscar_powerpc_ops): Redefine.
381 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
382 (ppc_ravenscar_e500_ops::fetch_registers)
383 (ppc_ravenscar_e500_ops::store_registers): Now methods.
384 (ppc_ravenscar_e500_ops): Redefine.
385 * aarch64-ravenscar-thread.c
386 (aarch64_ravenscar_generic_prepare_to_store): Remove.
387 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
388 (aarch64_ravenscar_fetch_registers)
389 (aarch64_ravenscar_store_registers): Now methods.
390 (aarch64_ravenscar_ops): Redefine.
392 2019-02-15 Tom Tromey <tromey@adacore.com>
394 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
395 (ravenscar_thread_target::stopped_by_hw_breakpoint)
396 (ravenscar_thread_target::stopped_by_watchpoint)
397 (ravenscar_thread_target::stopped_data_address)
398 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
400 2019-02-15 Tom Tromey <tromey@adacore.com>
402 * ravenscar-thread.c: Fix some typos.
404 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
405 Tom Tromey <tromey@adacore.com>
407 * ada-lang.c (ada_exception_sal): Change addr_string to a
409 (create_ada_exception_catchpoint): Update.
411 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
412 Tom Tromey <tromey@adacore.com>
414 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
415 (bp_location_ops): Remove.
416 (base_breakpoint_allocate_location): Update.
417 (free_bp_location): Update.
418 * ada-lang.c (class ada_catchpoint_location)
419 <ada_catchpoint_location>: Remove ops parameter.
420 (ada_catchpoint_location_dtor): Remove.
421 (ada_catchpoint_location_ops): Remove.
422 (allocate_location_exception): Update.
423 * breakpoint.h (struct bp_location_ops): Remove.
424 (class bp_location) <bp_location>: Remove bp_location_ops
426 <~bp_location>: Add destructor.
429 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
430 Pedro Alves <palves@redhat.com>
432 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
435 2019-02-14 David Michael <fedora.dm0@gmail.com>
436 Samuel Thibault <samuel.thibault@gnu.org>
437 Thomas Schwinge <thomas@codesourcery.com>
439 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
440 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
442 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
444 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
445 (check_empty): Use "const char *".
447 * gnu-nat.c (gnu_nat_target::detach): Instead of
448 'detach_inferior (pid)' call
449 'detach_inferior (find_inferior_pid (pid))'.
451 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
452 'nat/fork-inferior.o'.
453 * gnu-nat.c: #include "nat/fork-inferior.h".
455 * gnu-nat.c (gnu_nat_target::detach): Instead of
456 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
457 * gnu-nat.h: #include "inf-child.h".
458 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
459 'i386_gnu_nat_target::fetch_registers'.
460 (gnu_store_registers): Rename/move to
461 'i386_gnu_nat_target::store_registers'.
463 * config/i386/nm-i386gnu.h: Don't "#include" any files.
464 * gnu-nat.h (mach_thread_info): New function.
465 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
467 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
469 2019-02-14 Frederic Konrad <konrad@adacore.com>
471 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
473 2019-02-14 Joel Brobecker <brobecker@adacore.com>
475 * windows-nat.c (windows_add_thread): Add new parameter
476 "main_thread_p" with default value set to false. Update
477 function documentation as well as all callers.
478 (windows_delete_thread): Likewise.
479 (fake_create_process): Update call to windows_add_thread.
480 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
481 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
482 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
483 call to windows_delete_thread.
485 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
487 * MAINTAINERS: Add Andrew Burgess as global maintainer.
489 2019-02-12 John Baldwin <jhb@FreeBSD.org>
491 * symfile.c (find_separate_debug_file): Use canonical path of
492 sysroot with child_path instead of gdb_sysroot if it is valid.
494 2019-02-12 John Baldwin <jhb@FreeBSD.org>
496 * symfile.c (find_separate_debug_file): Use child_path to
497 determine if an object file is under a sysroot.
499 2019-02-12 John Baldwin <jhb@FreeBSD.org>
501 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
502 unittests/child-path-selftests.c.
503 * common/pathstuff.c (child_path): New function.
504 * common/pathstuff.h (child_path): New prototype.
505 * unittests/child-path-selftests.c: New file.
507 2019-02-12 John Baldwin <jhb@FreeBSD.org>
509 * symfile.c (find_separate_debug_file): Look for separate debug
510 files in debug directories under the sysroot.
512 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
514 * symtab.h (struct minimal_symbol data_p): New const method.
515 (struct minimal_symbol text_p): Likewise.
516 * symtab.c (output_source_filename): Use file name style
518 (print_symbol_info): Likewise.
519 (print_msymbol_info): Use address style to print addresses.
520 Use function name style to print executable text symbols.
521 (expand_symtab_containing_pc): Use data_p.
522 (find_pc_sect_compunit_symtab): Likewise.
524 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
526 * breakpoint.c (describe_other_breakpoints): Use address style
528 (say_where): Likewise.
530 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
532 * ada-typeprint.c (print_func_type): Print function name
533 style to print function name.
534 * c-typeprint.c (c_print_type_1): Likewise.
536 2019-02-11 Alan Hayward <alan.hayward@arm.com>
538 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
541 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
543 * c-exp.y (direct_abs_decl): Use emplace_back to record the
546 2019-02-10 Joel Brobecker <brobecker@adacore.com>
548 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
551 2019-02-08 Jim Wilson <jimw@sifive.com>
553 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
554 (riscv_linux_fregset): New.
555 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
557 2019-02-07 Tom Tromey <tom@tromey.com>
559 * thread.c (thread_cancel_execution_command): Update.
560 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
562 (struct thread_fsm_ops): Remove.
563 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
564 (thread_fsm_should_stop, thread_fsm_return_value)
565 (thread_fsm_set_finished, thread_fsm_finished_p)
566 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
568 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
569 * infrun.c (clear_proceed_status_thread)
570 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
571 (print_stop_event): Update.
572 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
574 (step_command_fsm_ops): Remove.
575 (new_step_command_fsm): Remove.
577 (step_command_fsm::should_stop): Rename from
578 step_command_fsm_should_stop.
579 (step_command_fsm::clean_up): Rename from
580 step_command_fsm_clean_up.
581 (step_command_fsm::do_async_reply_reason): Rename from
582 step_command_fsm_async_reply_reason.
583 (struct until_next_fsm): Inherit from thread_fsm. Add
585 (until_next_fsm_ops): Remove.
586 (new_until_next_fsm): Remove.
587 (until_next_fsm::should_stop): Rename from
588 until_next_fsm_should_stop.
589 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
590 (until_next_fsm::do_async_reply_reason): Rename from
591 until_next_fsm_async_reply_reason.
592 (struct finish_command_fsm): Inherit from thread_fsm. Add
593 constructor. Change type of breakpoint.
594 (finish_command_fsm_ops): Remove.
595 (new_finish_command_fsm): Remove.
596 (finish_command_fsm::should_stop): Rename from
597 finish_command_fsm_should_stop.
598 (finish_command_fsm::clean_up): Rename from
599 finish_command_fsm_clean_up.
600 (finish_command_fsm::return_value): Rename from
601 finish_command_fsm_return_value.
602 (finish_command_fsm::do_async_reply_reason): Rename from
603 finish_command_fsm_async_reply_reason.
604 (finish_command): Update.
605 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
607 (call_thread_fsm_ops): Remove.
608 (call_thread_fsm::call_thread_fsm): Rename from
610 (call_thread_fsm::should_stop): Rename from
611 call_thread_fsm_should_stop.
612 (call_thread_fsm::should_notify_stop): Rename from
613 call_thread_fsm_should_notify_stop.
614 (run_inferior_call, call_function_by_hand_dummy): Update.
615 * cli/cli-interp.c (should_print_stop_to_console): Update.
616 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
617 Add constructor. Change type of location_breakpoint,
619 (until_break_fsm_ops): Remove.
620 (new_until_break_fsm): Remove.
621 (until_break_fsm::should_stop): Rename from
622 until_break_fsm_should_stop.
623 (until_break_fsm::clean_up): Rename from
624 until_break_fsm_clean_up.
625 (until_break_fsm::do_async_reply_reason): Rename from
626 until_break_fsm_async_reply_reason.
627 (until_break_command): Update.
628 * thread-fsm.c: Remove.
629 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
631 2019-02-07 Tom Tromey <tom@tromey.com>
633 * yy-remap.h: Add include guard.
634 * xtensa-tdep.h: Add include guard.
635 * xcoffread.h: Rename include guard.
636 * varobj-iter.h: Add include guard.
637 * tui/tui.h: Rename include guard.
638 * tui/tui-winsource.h: Rename include guard.
639 * tui/tui-wingeneral.h: Rename include guard.
640 * tui/tui-windata.h: Rename include guard.
641 * tui/tui-win.h: Rename include guard.
642 * tui/tui-stack.h: Rename include guard.
643 * tui/tui-source.h: Rename include guard.
644 * tui/tui-regs.h: Rename include guard.
645 * tui/tui-out.h: Rename include guard.
646 * tui/tui-layout.h: Rename include guard.
647 * tui/tui-io.h: Rename include guard.
648 * tui/tui-hooks.h: Rename include guard.
649 * tui/tui-file.h: Rename include guard.
650 * tui/tui-disasm.h: Rename include guard.
651 * tui/tui-data.h: Rename include guard.
652 * tui/tui-command.h: Rename include guard.
653 * tic6x-tdep.h: Add include guard.
654 * target/waitstatus.h: Rename include guard.
655 * target/wait.h: Rename include guard.
656 * target/target.h: Rename include guard.
657 * target/resume.h: Rename include guard.
658 * target-float.h: Rename include guard.
659 * stabsread.h: Add include guard.
660 * rs6000-tdep.h: Add include guard.
661 * riscv-fbsd-tdep.h: Add include guard.
662 * regformats/regdef.h: Rename include guard.
663 * record.h: Rename include guard.
664 * python/python.h: Rename include guard.
665 * python/python-internal.h: Rename include guard.
666 * python/py-stopevent.h: Rename include guard.
667 * python/py-ref.h: Rename include guard.
668 * python/py-record.h: Rename include guard.
669 * python/py-record-full.h: Rename include guard.
670 * python/py-record-btrace.h: Rename include guard.
671 * python/py-instruction.h: Rename include guard.
672 * python/py-events.h: Rename include guard.
673 * python/py-event.h: Rename include guard.
674 * procfs.h: Add include guard.
675 * proc-utils.h: Add include guard.
676 * p-lang.h: Add include guard.
677 * or1k-tdep.h: Rename include guard.
678 * observable.h: Rename include guard.
679 * nto-tdep.h: Rename include guard.
680 * nat/x86-linux.h: Rename include guard.
681 * nat/x86-linux-dregs.h: Rename include guard.
682 * nat/x86-gcc-cpuid.h: Add include guard.
683 * nat/x86-dregs.h: Rename include guard.
684 * nat/x86-cpuid.h: Rename include guard.
685 * nat/ppc-linux.h: Rename include guard.
686 * nat/mips-linux-watch.h: Rename include guard.
687 * nat/linux-waitpid.h: Rename include guard.
688 * nat/linux-ptrace.h: Rename include guard.
689 * nat/linux-procfs.h: Rename include guard.
690 * nat/linux-osdata.h: Rename include guard.
691 * nat/linux-nat.h: Rename include guard.
692 * nat/linux-namespaces.h: Rename include guard.
693 * nat/linux-btrace.h: Rename include guard.
694 * nat/glibc_thread_db.h: Rename include guard.
695 * nat/gdb_thread_db.h: Rename include guard.
696 * nat/gdb_ptrace.h: Rename include guard.
697 * nat/fork-inferior.h: Rename include guard.
698 * nat/amd64-linux-siginfo.h: Rename include guard.
699 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
700 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
701 * nat/aarch64-linux.h: Rename include guard.
702 * nat/aarch64-linux-hw-point.h: Rename include guard.
703 * mn10300-tdep.h: Add include guard.
704 * mips-linux-tdep.h: Add include guard.
705 * mi/mi-parse.h: Rename include guard.
706 * mi/mi-out.h: Rename include guard.
707 * mi/mi-main.h: Rename include guard.
708 * mi/mi-interp.h: Rename include guard.
709 * mi/mi-getopt.h: Rename include guard.
710 * mi/mi-console.h: Rename include guard.
711 * mi/mi-common.h: Rename include guard.
712 * mi/mi-cmds.h: Rename include guard.
713 * mi/mi-cmd-break.h: Rename include guard.
714 * m2-lang.h: Add include guard.
715 * location.h: Rename include guard.
716 * linux-record.h: Rename include guard.
717 * linux-nat.h: Add include guard.
718 * linux-fork.h: Add include guard.
719 * i386-darwin-tdep.h: Rename include guard.
720 * hppa-linux-offsets.h: Add include guard.
721 * guile/guile.h: Rename include guard.
722 * guile/guile-internal.h: Rename include guard.
723 * gnu-nat.h: Rename include guard.
724 * gdb-stabs.h: Rename include guard.
725 * frv-tdep.h: Add include guard.
726 * f-lang.h: Add include guard.
727 * event-loop.h: Add include guard.
728 * darwin-nat.h: Rename include guard.
729 * cp-abi.h: Rename include guard.
730 * config/sparc/nm-sol2.h: Rename include guard.
731 * config/nm-nto.h: Rename include guard.
732 * config/nm-linux.h: Add include guard.
733 * config/i386/nm-i386gnu.h: Rename include guard.
734 * config/djgpp/nl_types.h: Rename include guard.
735 * config/djgpp/langinfo.h: Rename include guard.
736 * compile/gcc-cp-plugin.h: Add include guard.
737 * compile/gcc-c-plugin.h: Add include guard.
738 * compile/compile.h: Rename include guard.
739 * compile/compile-object-run.h: Rename include guard.
740 * compile/compile-object-load.h: Rename include guard.
741 * compile/compile-internal.h: Rename include guard.
742 * compile/compile-cplus.h: Rename include guard.
743 * compile/compile-c.h: Rename include guard.
744 * common/xml-utils.h: Rename include guard.
745 * common/x86-xstate.h: Rename include guard.
746 * common/version.h: Rename include guard.
747 * common/vec.h: Rename include guard.
748 * common/tdesc.h: Rename include guard.
749 * common/selftest.h: Rename include guard.
750 * common/scoped_restore.h: Rename include guard.
751 * common/scoped_mmap.h: Rename include guard.
752 * common/scoped_fd.h: Rename include guard.
753 * common/safe-iterator.h: Rename include guard.
754 * common/run-time-clock.h: Rename include guard.
755 * common/refcounted-object.h: Rename include guard.
756 * common/queue.h: Rename include guard.
757 * common/ptid.h: Rename include guard.
758 * common/print-utils.h: Rename include guard.
759 * common/preprocessor.h: Rename include guard.
760 * common/pathstuff.h: Rename include guard.
761 * common/observable.h: Rename include guard.
762 * common/netstuff.h: Rename include guard.
763 * common/job-control.h: Rename include guard.
764 * common/host-defs.h: Rename include guard.
765 * common/gdb_wait.h: Rename include guard.
766 * common/gdb_vecs.h: Rename include guard.
767 * common/gdb_unlinker.h: Rename include guard.
768 * common/gdb_unique_ptr.h: Rename include guard.
769 * common/gdb_tilde_expand.h: Rename include guard.
770 * common/gdb_sys_time.h: Rename include guard.
771 * common/gdb_string_view.h: Rename include guard.
772 * common/gdb_splay_tree.h: Rename include guard.
773 * common/gdb_setjmp.h: Rename include guard.
774 * common/gdb_ref_ptr.h: Rename include guard.
775 * common/gdb_optional.h: Rename include guard.
776 * common/gdb_locale.h: Rename include guard.
777 * common/gdb_assert.h: Rename include guard.
778 * common/filtered-iterator.h: Rename include guard.
779 * common/filestuff.h: Rename include guard.
780 * common/fileio.h: Rename include guard.
781 * common/environ.h: Rename include guard.
782 * common/common-utils.h: Rename include guard.
783 * common/common-types.h: Rename include guard.
784 * common/common-regcache.h: Rename include guard.
785 * common/common-inferior.h: Rename include guard.
786 * common/common-gdbthread.h: Rename include guard.
787 * common/common-exceptions.h: Rename include guard.
788 * common/common-defs.h: Rename include guard.
789 * common/common-debug.h: Rename include guard.
790 * common/cleanups.h: Rename include guard.
791 * common/buffer.h: Rename include guard.
792 * common/btrace-common.h: Rename include guard.
793 * common/break-common.h: Rename include guard.
794 * cli/cli-utils.h: Rename include guard.
795 * cli/cli-style.h: Rename include guard.
796 * cli/cli-setshow.h: Rename include guard.
797 * cli/cli-script.h: Rename include guard.
798 * cli/cli-interp.h: Rename include guard.
799 * cli/cli-decode.h: Rename include guard.
800 * cli/cli-cmds.h: Rename include guard.
801 * charset-list.h: Add include guard.
802 * buildsym-legacy.h: Rename include guard.
803 * bfin-tdep.h: Add include guard.
804 * ax.h: Rename include guard.
805 * arm-linux-tdep.h: Add include guard.
806 * arm-fbsd-tdep.h: Add include guard.
807 * arch/xtensa.h: Rename include guard.
808 * arch/tic6x.h: Add include guard.
809 * arch/i386.h: Add include guard.
810 * arch/arm.h: Rename include guard.
811 * arch/arm-linux.h: Rename include guard.
812 * arch/arm-get-next-pcs.h: Rename include guard.
813 * arch/amd64.h: Add include guard.
814 * arch/aarch64-insn.h: Rename include guard.
815 * arch-utils.h: Rename include guard.
816 * annotate.h: Add include guard.
817 * amd64-darwin-tdep.h: Rename include guard.
818 * aarch64-linux-tdep.h: Add include guard.
819 * aarch64-fbsd-tdep.h: Add include guard.
820 * aarch32-linux-nat.h: Add include guard.
822 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
824 * macrotab.c (macro_define_internal): New function that
825 factorizes macro_define_object_internal and macro_define_function
827 (macro_define_object_internal): Use macro_define_internal.
828 (macro_define_function): Likewise.
830 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
832 * macrocmd.c (extract_identifier): Return
833 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
836 2019-02-06 John Baldwin <jhb@FreeBSD.org>
838 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
840 2019-02-05 Tom Tromey <tom@tromey.com>
842 * target.c (target_stack::unpush): Move assertion earlier.
844 2019-01-30 Tom Tromey <tom@tromey.com>
847 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
848 (gdbpy_parse_and_eval): Likewise.
849 * python/python-internal.h (gdbpy_allow_threads): New class.
851 2019-01-28 John Baldwin <jhb@FreeBSD.org>
853 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
854 (aarch64_fbsd_fpregmap): Move earlier.
855 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
856 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
857 instead of individual calls to trad_frame_set_reg_addr.
858 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
860 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
861 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
862 instead of individual calls to trad_frame_set_reg_addr.
864 2019-01-28 Alan Hayward <alan.hayward@arm.com>
866 * CONTRIBUTE: Replace contribution list with wiki link.
868 2019-01-25 Tom Tromey <tom@tromey.com>
870 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
872 2019-01-25 Tom Tromey <tom@tromey.com>
874 * xtensa-linux-nat.c: Fix common/ includes.
875 * xml-support.h: Fix common/ includes.
876 * xml-support.c: Fix common/ includes.
877 * x86-linux-nat.c: Fix common/ includes.
878 * windows-nat.c: Fix common/ includes.
879 * varobj.h: Fix common/ includes.
880 * varobj.c: Fix common/ includes.
881 * value.c: Fix common/ includes.
882 * valops.c: Fix common/ includes.
883 * utils.c: Fix common/ includes.
884 * unittests/xml-utils-selftests.c: Fix common/ includes.
885 * unittests/utils-selftests.c: Fix common/ includes.
886 * unittests/unpack-selftests.c: Fix common/ includes.
887 * unittests/tracepoint-selftests.c: Fix common/ includes.
888 * unittests/style-selftests.c: Fix common/ includes.
889 * unittests/string_view-selftests.c: Fix common/ includes.
890 * unittests/scoped_restore-selftests.c: Fix common/ includes.
891 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
892 * unittests/scoped_fd-selftests.c: Fix common/ includes.
893 * unittests/rsp-low-selftests.c: Fix common/ includes.
894 * unittests/parse-connection-spec-selftests.c: Fix common/
896 * unittests/optional-selftests.c: Fix common/ includes.
897 * unittests/offset-type-selftests.c: Fix common/ includes.
898 * unittests/observable-selftests.c: Fix common/ includes.
899 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
900 * unittests/memrange-selftests.c: Fix common/ includes.
901 * unittests/memory-map-selftests.c: Fix common/ includes.
902 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
903 * unittests/function-view-selftests.c: Fix common/ includes.
904 * unittests/environ-selftests.c: Fix common/ includes.
905 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
906 * unittests/common-utils-selftests.c: Fix common/ includes.
907 * unittests/cli-utils-selftests.c: Fix common/ includes.
908 * unittests/array-view-selftests.c: Fix common/ includes.
909 * ui-file.c: Fix common/ includes.
910 * tui/tui-io.c: Fix common/ includes.
911 * tracepoint.h: Fix common/ includes.
912 * tracepoint.c: Fix common/ includes.
913 * tracefile-tfile.c: Fix common/ includes.
914 * top.h: Fix common/ includes.
915 * top.c: Fix common/ includes.
916 * thread.c: Fix common/ includes.
917 * target/waitstatus.h: Fix common/ includes.
918 * target/waitstatus.c: Fix common/ includes.
919 * target.h: Fix common/ includes.
920 * target.c: Fix common/ includes.
921 * target-memory.c: Fix common/ includes.
922 * target-descriptions.c: Fix common/ includes.
923 * symtab.h: Fix common/ includes.
924 * symfile.c: Fix common/ includes.
925 * stap-probe.c: Fix common/ includes.
926 * spu-linux-nat.c: Fix common/ includes.
927 * sparc-nat.c: Fix common/ includes.
928 * source.c: Fix common/ includes.
929 * solib.c: Fix common/ includes.
930 * solib-target.c: Fix common/ includes.
931 * ser-unix.c: Fix common/ includes.
932 * ser-tcp.c: Fix common/ includes.
933 * ser-pipe.c: Fix common/ includes.
934 * ser-base.c: Fix common/ includes.
935 * selftest-arch.c: Fix common/ includes.
936 * s12z-tdep.c: Fix common/ includes.
937 * rust-exp.y: Fix common/ includes.
938 * rs6000-aix-tdep.c: Fix common/ includes.
939 * riscv-tdep.c: Fix common/ includes.
940 * remote.c: Fix common/ includes.
941 * remote-notif.h: Fix common/ includes.
942 * remote-fileio.h: Fix common/ includes.
943 * remote-fileio.c: Fix common/ includes.
944 * regcache.h: Fix common/ includes.
945 * regcache.c: Fix common/ includes.
946 * record-btrace.c: Fix common/ includes.
947 * python/python.c: Fix common/ includes.
948 * python/py-type.c: Fix common/ includes.
949 * python/py-inferior.c: Fix common/ includes.
950 * progspace.h: Fix common/ includes.
951 * producer.c: Fix common/ includes.
952 * procfs.c: Fix common/ includes.
953 * proc-api.c: Fix common/ includes.
954 * printcmd.c: Fix common/ includes.
955 * ppc-linux-nat.c: Fix common/ includes.
956 * parser-defs.h: Fix common/ includes.
957 * osdata.c: Fix common/ includes.
958 * obsd-nat.c: Fix common/ includes.
959 * nat/x86-linux.c: Fix common/ includes.
960 * nat/x86-linux-dregs.c: Fix common/ includes.
961 * nat/x86-dregs.h: Fix common/ includes.
962 * nat/x86-dregs.c: Fix common/ includes.
963 * nat/ppc-linux.c: Fix common/ includes.
964 * nat/mips-linux-watch.h: Fix common/ includes.
965 * nat/mips-linux-watch.c: Fix common/ includes.
966 * nat/linux-waitpid.c: Fix common/ includes.
967 * nat/linux-ptrace.h: Fix common/ includes.
968 * nat/linux-ptrace.c: Fix common/ includes.
969 * nat/linux-procfs.c: Fix common/ includes.
970 * nat/linux-personality.c: Fix common/ includes.
971 * nat/linux-osdata.c: Fix common/ includes.
972 * nat/linux-namespaces.c: Fix common/ includes.
973 * nat/linux-btrace.h: Fix common/ includes.
974 * nat/linux-btrace.c: Fix common/ includes.
975 * nat/fork-inferior.c: Fix common/ includes.
976 * nat/amd64-linux-siginfo.c: Fix common/ includes.
977 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
978 * nat/aarch64-linux.c: Fix common/ includes.
979 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
980 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
981 * namespace.h: Fix common/ includes.
982 * mips-linux-tdep.c: Fix common/ includes.
983 * minsyms.c: Fix common/ includes.
984 * mi/mi-parse.h: Fix common/ includes.
985 * mi/mi-main.c: Fix common/ includes.
986 * mi/mi-cmd-env.c: Fix common/ includes.
987 * memrange.h: Fix common/ includes.
988 * memattr.c: Fix common/ includes.
989 * maint.h: Fix common/ includes.
990 * maint.c: Fix common/ includes.
991 * main.c: Fix common/ includes.
992 * machoread.c: Fix common/ includes.
993 * location.c: Fix common/ includes.
994 * linux-thread-db.c: Fix common/ includes.
995 * linux-nat.c: Fix common/ includes.
996 * linux-fork.c: Fix common/ includes.
997 * inline-frame.c: Fix common/ includes.
998 * infrun.c: Fix common/ includes.
999 * inflow.c: Fix common/ includes.
1000 * inferior.h: Fix common/ includes.
1001 * inferior.c: Fix common/ includes.
1002 * infcmd.c: Fix common/ includes.
1003 * inf-ptrace.c: Fix common/ includes.
1004 * inf-child.c: Fix common/ includes.
1005 * ia64-linux-nat.c: Fix common/ includes.
1006 * i387-tdep.c: Fix common/ includes.
1007 * i386-tdep.c: Fix common/ includes.
1008 * i386-linux-tdep.c: Fix common/ includes.
1009 * i386-linux-nat.c: Fix common/ includes.
1010 * i386-go32-tdep.c: Fix common/ includes.
1011 * i386-fbsd-tdep.c: Fix common/ includes.
1012 * i386-fbsd-nat.c: Fix common/ includes.
1013 * guile/scm-type.c: Fix common/ includes.
1014 * guile/guile.c: Fix common/ includes.
1015 * go32-nat.c: Fix common/ includes.
1016 * gnu-nat.c: Fix common/ includes.
1017 * gdbthread.h: Fix common/ includes.
1018 * gdbarch-selftests.c: Fix common/ includes.
1019 * gdb_usleep.c: Fix common/ includes.
1020 * gdb_select.h: Fix common/ includes.
1021 * gdb_bfd.c: Fix common/ includes.
1022 * gcore.c: Fix common/ includes.
1023 * fork-child.c: Fix common/ includes.
1024 * findvar.c: Fix common/ includes.
1025 * fbsd-nat.c: Fix common/ includes.
1026 * event-top.c: Fix common/ includes.
1027 * event-loop.c: Fix common/ includes.
1028 * dwarf2read.c: Fix common/ includes.
1029 * dwarf2loc.c: Fix common/ includes.
1030 * dwarf2-frame.c: Fix common/ includes.
1031 * dwarf-index-cache.c: Fix common/ includes.
1032 * dtrace-probe.c: Fix common/ includes.
1033 * disasm-selftests.c: Fix common/ includes.
1034 * defs.h: Fix common/ includes.
1035 * csky-tdep.c: Fix common/ includes.
1036 * cp-valprint.c: Fix common/ includes.
1037 * cp-support.h: Fix common/ includes.
1038 * cp-support.c: Fix common/ includes.
1039 * corelow.c: Fix common/ includes.
1040 * completer.h: Fix common/ includes.
1041 * completer.c: Fix common/ includes.
1042 * compile/compile.c: Fix common/ includes.
1043 * compile/compile-loc2c.c: Fix common/ includes.
1044 * compile/compile-cplus-types.c: Fix common/ includes.
1045 * compile/compile-cplus-symbols.c: Fix common/ includes.
1046 * command.h: Fix common/ includes.
1047 * cli/cli-dump.c: Fix common/ includes.
1048 * cli/cli-cmds.c: Fix common/ includes.
1049 * charset.c: Fix common/ includes.
1050 * build-id.c: Fix common/ includes.
1051 * btrace.h: Fix common/ includes.
1052 * btrace.c: Fix common/ includes.
1053 * breakpoint.h: Fix common/ includes.
1054 * breakpoint.c: Fix common/ includes.
1056 (enum agent_op): Fix common/ includes.
1057 * ax-general.c (struct aop_map): Fix common/ includes.
1058 * ax-gdb.c: Fix common/ includes.
1059 * auxv.c: Fix common/ includes.
1060 * auto-load.c: Fix common/ includes.
1061 * arm-tdep.c: Fix common/ includes.
1062 * arch/riscv.c: Fix common/ includes.
1063 * arch/ppc-linux-common.c: Fix common/ includes.
1064 * arch/i386.c: Fix common/ includes.
1065 * arch/arm.c: Fix common/ includes.
1066 * arch/arm-linux.c: Fix common/ includes.
1067 * arch/arm-get-next-pcs.c: Fix common/ includes.
1068 * arch/amd64.c: Fix common/ includes.
1069 * arch/aarch64.c: Fix common/ includes.
1070 * arch/aarch64-insn.c: Fix common/ includes.
1071 * arch-utils.c: Fix common/ includes.
1072 * amd64-windows-tdep.c: Fix common/ includes.
1073 * amd64-tdep.c: Fix common/ includes.
1074 * amd64-sol2-tdep.c: Fix common/ includes.
1075 * amd64-obsd-tdep.c: Fix common/ includes.
1076 * amd64-nbsd-tdep.c: Fix common/ includes.
1077 * amd64-linux-tdep.c: Fix common/ includes.
1078 * amd64-linux-nat.c: Fix common/ includes.
1079 * amd64-fbsd-tdep.c: Fix common/ includes.
1080 * amd64-fbsd-nat.c: Fix common/ includes.
1081 * amd64-dicos-tdep.c: Fix common/ includes.
1082 * amd64-darwin-tdep.c: Fix common/ includes.
1083 * agent.c: Fix common/ includes.
1084 * ada-lang.h: Fix common/ includes.
1085 * ada-lang.c: Fix common/ includes.
1086 * aarch64-tdep.c: Fix common/ includes.
1088 2019-01-25 Tom Tromey <tom@tromey.com>
1090 * common/create-version.sh: Use common/version.h.
1092 2019-01-24 Pedro Alves <palves@redhat.com>
1094 * infrun.c (signal_stop, signal_print, signal_program)
1095 (signal_catch, signal_pass): Now arrays instead of pointers.
1096 (update_signals_program_target, do_target_resume)
1097 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1098 * linux-nat.c (linux_nat_target::pass_signals)
1099 (linux_nat_target::create_inferior, linux_nat_target::attach):
1101 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1102 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1103 * procfs.c (procfs_target::pass_signals): Adjust.
1104 * record-full.c (record_full_target::resume): Adjust.
1105 * remote.c (remote_target::pass_signals)
1106 (remote_target::program_signals): Adjust.
1107 * target-debug.h (target_debug_print_signals): Now takes a
1108 gdb::array_view as parameter. Adjust.
1109 * target.h (target_ops) <pass_signals, program_signals>: Replace
1110 pointer and length parameters with gdb::array_view.
1111 (target_pass_signals, target_program_signals): Likewise.
1112 * target-delegates.c: Regenerate.
1114 2019-01-24 Pedro Alves <palves@redhat.com>
1116 * common/forward-scope-exit.h
1117 (forward_scope_exit::forward_scope_exit): Pass arguments to
1118 m_bind_function directly, instead of creating a std::bind and
1121 2019-01-24 Alan Hayward <alan.hayward@arm.com>
1123 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1125 (pass_in_v_vfp_candidate): Likewise.
1127 2019-01-23 Tom Tromey <tom@tromey.com>
1128 Pedro Alves <palves@redhat.com>
1130 * regcache.c (class regcache_invalidator): Remove.
1131 (regcache::raw_write): Use make_scope_exit.
1133 2019-01-23 Tom Tromey <tom@tromey.com>
1135 * ui-out.h (class ui_out_emit_type): Update comment.
1137 2019-01-23 Tom Tromey <tom@tromey.com>
1139 * infrun.c (fetch_inferior_event): Update comment.
1141 2019-01-23 Tom Tromey <tom@tromey.com>
1142 Pedro Alves <palves@redhat.com>
1144 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1146 (fetch_inferior_event): Use SCOPE_EXIT.
1149 2019-01-23 Tom Tromey <tom@tromey.com>
1150 Pedro Alves <palves@redhat.com>
1152 * infrun.c (disable_thread_events): Delete.
1153 (stop_all_threads): Use SCOPE_EXIT.
1155 2019-01-23 Tom Tromey <tom@tromey.com>
1156 Pedro Alves <palves@redhat.com>
1158 * symfile.c: Include forward-scope-exit.h.
1159 (clear_symtab_users_cleanup): Replace forward declaration with
1160 a FORWARD_SCOPE_EXIT.
1161 (syms_from_objfile_1): Use the forward_scope_exit and
1162 gdb::optional instead of cleanup_function.
1163 (reread_symbols): Use the forward_scope_exit instead of
1165 (clear_symtab_users_cleanup): Remove function.
1167 2019-01-23 Tom Tromey <tom@tromey.com>
1168 Pedro Alves <palves@redhat.com>
1170 * linux-nat.c: Include scope-exit.h.
1171 (cleanup_target_stop): Remove.
1172 (linux_nat_target::static_tracepoint_markers_by_strid): Use
1175 2019-01-23 Tom Tromey <tom@tromey.com>
1176 Pedro Alves <palves@redhat.com>
1178 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1179 (call_function_by_hand_dummy): Use SCOPE_EXIT.
1181 2019-01-23 Tom Tromey <tom@tromey.com>
1182 Andrew Burgess <andrew.burgess@embecosm.com>
1183 Pedro Alves <palves@redhat.com>
1185 * infrun.c (fetch_inferior_event): Use scope_exit.
1186 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1187 * top.c (execute_command): Use scope_exit.
1188 * breakpoint.c (bpstat_do_actions): Use scope_exit.
1189 * utils.c (do_bpstat_clear_actions_cleanup)
1190 (make_bpstat_clear_actions_cleanup): Remove.
1192 2019-01-23 Tom Tromey <tom@tromey.com>
1193 Pedro Alves <palves@redhat.com>
1195 * infrun.c: Include "common/scope-exit.h"
1196 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1197 (wait_for_inferior): Use SCOPE_EXIT.
1198 (fetch_inferior_event): Use scope_exit.
1200 2019-01-23 Tom Tromey <tom@tromey.com>
1201 Pedro Alves <palves@redhat.com>
1203 * breakpoint.c (create_breakpoint): Remove cleanup.
1205 2019-01-23 Tom Tromey <tom@tromey.com>
1206 Andrew Burgess <andrew.burgess@embecosm.com>
1207 Pedro Alves <palves@redhat.com>
1209 2019-01-23 Pedro Alves <palves@redhat.com>
1211 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1213 2019-01-23 Pedro Alves <palves@redhat.com>
1214 Andrew Burgess <andrew.burgess@embecosm.com>
1216 * gdbthread.h: Include "common/forward-scope-exit.h".
1217 (scoped_finish_thread_state): Redefine custom class in terms of
1220 2019-01-23 Pedro Alves <palves@redhat.com>
1221 Andrew Burgess <andrew.burgess@embecosm.com>
1223 * common/forward-scope-exit.h: New file.
1225 2019-01-23 Pedro Alves <palves@redhat.com>
1226 Andrew Burgess <andrew.burgess@embecosm.com>
1227 Tom Tromey <tom@tromey.com>
1229 * common/scope-exit.h: New file.
1231 2019-01-23 Pedro Alves <palves@redhat.com>
1233 * common/preprocessor.h (ESC): Rename to ...
1234 (ESC_PARENS): ... this.
1235 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1236 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1238 2019-01-23 Tom Tromey <tom@tromey.com>
1240 * language.h (class scoped_switch_to_sym_language_if_auto):
1241 Initialize m_lang in both cases.
1243 2019-01-23 Alan Hayward <alan.hayward@arm.com>
1245 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1248 2019-01-22 Tom Tromey <tom@tromey.com>
1250 * corelow.c: Do not include sys/file.h.
1252 2019-01-22 Tom Tromey <tom@tromey.com>
1254 * tui/tui-wingeneral.h: Include gdb_curses.h.
1256 2019-01-22 Tom Tromey <tom@tromey.com>
1258 * source-cache.h (class source_cache) <get_source_lines,
1259 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1261 2019-01-22 Tom Tromey <tom@tromey.com>
1263 * remote-fileio.h (struct remote_target): Declare.
1265 2019-01-22 Tom Tromey <tom@tromey.com>
1267 * python/py-arch.c: Do not include py-ref.h.
1268 * python/py-bpevent.c: Do not include py-ref.h.
1269 * python/py-cmd.c: Do not include py-ref.h.
1270 * python/py-continueevent.c: Do not include py-ref.h.
1271 * python/py-event.h: Do not include py-ref.h.
1272 * python/py-evtregistry.c: Do not include py-ref.h.
1273 * python/py-finishbreakpoint.c: Do not include py-ref.h.
1274 * python/py-frame.c: Do not include py-ref.h.
1275 * python/py-framefilter.c: Do not include py-ref.h.
1276 * python/py-function.c: Do not include py-ref.h.
1277 * python/py-infevents.c: Do not include py-ref.h.
1278 * python/py-linetable.c: Do not include py-ref.h.
1279 * python/py-objfile.c: Do not include py-ref.h.
1280 * python/py-param.c: Do not include py-ref.h.
1281 * python/py-prettyprint.c: Do not include py-ref.h.
1282 * python/py-progspace.c: Do not include py-ref.h.
1283 * python/py-symbol.c: Do not include py-ref.h.
1284 * python/py-symtab.c: Do not include py-ref.h.
1285 * python/py-type.c: Do not include py-ref.h.
1286 * python/py-unwind.c: Do not include py-ref.h.
1287 * python/py-utils.c: Do not include py-ref.h.
1288 * python/py-value.c: Do not include py-ref.h.
1289 * python/py-varobj.c: Do not include py-ref.h.
1290 * python/py-xmethods.c: Do not include py-ref.h.
1291 * python/python.c: Do not include py-ref.h.
1292 * varobj.c: Do not include py-ref.h.
1294 2019-01-22 Tom Tromey <tom@tromey.com>
1296 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1299 2019-01-22 Tom Tromey <tom@tromey.com>
1301 * compile/compile-cplus-types.c: Remove a comment by #include.
1303 2019-01-22 Tom Tromey <tom@tromey.com>
1305 * compile/gcc-c-plugin.h: Include compile-internal.h.
1307 2019-01-22 Tom Tromey <tom@tromey.com>
1309 * stabsread.c (EXTERN): Do not define.
1310 (symnum, next_symbol_text_func, processing_gcc_compilation)
1311 (within_function, global_sym_chain, global_stabs)
1312 (previous_stab_code, this_object_header_files)
1313 (n_this_object_header_files)
1314 (n_allocated_this_object_header_files): Define.
1315 * stabsread.h (EXTERN): Never define. Use "extern".
1317 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1319 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1322 2019-01-21 Tom Tromey <tom@tromey.com>
1324 * ui-out.c: Fix includes.
1325 * tui/tui-source.c: Fix includes.
1326 * target.c: Fix includes.
1327 * remote.c: Fix includes.
1328 * regcache.c: Fix includes.
1329 * python/py-block.c: Fix includes.
1330 * printcmd.c: Fix includes.
1331 * or1k-tdep.c: Fix includes.
1332 * mi/mi-main.c: Fix includes.
1333 * m32r-tdep.c: Fix includes.
1334 * csky-tdep.c: Fix includes.
1335 * compile/compile-cplus-types.c: Fix includes.
1336 * cli/cli-interp.c: Fix includes.
1338 2019-01-21 Alan Hayward <alan.hayward@arm.com>
1340 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1343 2019-01-16 Tom Tromey <tom@tromey.com>
1345 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
1347 (struct objfile) <msymbols_range>: Move from top level.
1348 <msymbols>: New method.
1349 (class objfile_msymbols): Remove.
1350 * symtab.c (default_collect_symbol_completion_matches_break_on):
1352 * symmisc.c (dump_msymbols): Update.
1353 * stabsread.c (scan_file_globals): Update.
1354 * objc-lang.c (info_selectors_command, info_classes_command)
1355 (find_methods): Update.
1356 * minsyms.c (find_solib_trampoline_target): Update.
1357 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1358 * coffread.c (coff_symfile_read): Update.
1359 * ada-lang.c (ada_lookup_simple_minsym)
1360 (ada_collect_symbol_completion_matches): Update.
1362 2019-01-16 Tom Tromey <tom@tromey.com>
1364 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1365 type. Remove no-argument constructor.
1366 <iterator::operator++>: Simplify.
1368 <end>: Use minimal_symbol_count.
1370 2019-01-16 Tom Tromey <tom@tromey.com>
1372 * objfiles.h (struct objfile) <psymtabs>: New method.
1373 (class objfile_psymtabs): Remove.
1374 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1376 <range>: New method.
1377 (require_partial_symbols): Change return type.
1378 * psymtab.c (require_partial_symbols)
1379 (psym_expand_symtabs_matching): Update.
1380 * mdebugread.c (parse_partial_symbols): Update.
1381 * dbxread.c (dbx_end_psymtab): Update.
1383 2019-01-15 Tom Tromey <tom@tromey.com>
1385 * symtab.c (lookup_objfile_from_block)
1386 (lookup_symbol_in_objfile_symtabs)
1387 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1388 (find_line_symtab, info_sources_command)
1389 (default_collect_symbol_completion_matches_break_on)
1390 (make_source_files_completion_list): Update.
1391 * symmisc.c (print_objfile_statistics, dump_objfile)
1392 (maintenance_print_symbols, maintenance_info_symtabs)
1393 (maintenance_check_symtabs, maintenance_info_line_tables):
1395 * source.c (select_source_symtab)
1396 (forget_cached_source_info_for_objfile): Update.
1397 * objfiles.h (class objfile_compunits): Remove.
1398 (struct objfile) <compunits_range>: New typedef.
1399 (compunits): New method.
1400 * objfiles.c (objfile_relocate1): Update.
1401 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1402 * maint.c (count_symtabs_and_blocks): Update.
1403 * linespec.c (iterate_over_all_matching_symtabs): Update.
1404 * cp-support.c (add_symbol_overload_list_qualified): Update.
1405 * coffread.c (coff_symtab_read): Update.
1406 * ada-lang.c (add_nonlocal_symbols)
1407 (ada_collect_symbol_completion_matches)
1408 (ada_add_global_exceptions): Update.
1410 2019-01-15 Tom Tromey <tom@tromey.com>
1412 * progspace.h (program_space) <objfiles_safe_range>: New
1414 <objfiles_safe>: New method.
1415 * objfiles.h (class all_objfiles_safe): Remove.
1416 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1417 * jit.c (jit_inferior_exit_hook): Update.
1419 2019-01-17 Tom Tromey <tom@tromey.com>
1421 * progspace.h (program_space) <objfiles_range>: New typedef.
1422 <objfiles>: New method.
1423 <objfiles_head>: Rename from objfiles.
1424 (object_files): Update.
1425 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1426 * guile/scm-pretty-print.c
1427 (ppscm_find_pretty_printer_from_objfiles): Update.
1428 * guile/scm-objfile.c (gdbscm_objfiles): Update.
1429 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1431 * python/py-progspace.c (pspy_get_objfiles): Update.
1432 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1434 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1435 (objfpy_lookup_objfile_by_build_id): Update.
1436 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1437 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1439 * symtab.c (iterate_over_symtabs, matching_obj_sections)
1440 (expand_symtab_containing_pc, lookup_objfile_from_block)
1441 (lookup_static_symbol, basic_lookup_transparent_type)
1442 (find_pc_sect_compunit_symtab, find_symbol_at_address)
1443 (find_line_symtab, info_sources_command)
1444 (default_collect_symbol_completion_matches_break_on)
1445 (make_source_files_completion_list, find_main_name): Update.
1446 * symmisc.c (print_symbol_bcache_statistics)
1447 (print_objfile_statistics, maintenance_print_symbols)
1448 (maintenance_print_msymbols, maintenance_print_objfiles)
1449 (maintenance_info_symtabs, maintenance_check_symtabs)
1450 (maintenance_expand_symtabs, maintenance_info_line_tables):
1452 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1453 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1454 (map_overlay_command, unmap_overlay_command)
1455 (simple_overlay_update, expand_symtabs_matching)
1456 (map_symbol_filenames): Update.
1457 * symfile-debug.c (set_debug_symfile): Update.
1458 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1460 * source.c (select_source_symtab, forget_cached_source_info):
1462 * solib.c (solib_read_symbols): Update.
1463 * solib-spu.c (append_ocl_sos): Update.
1464 * psymtab.c (maintenance_print_psymbols)
1465 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1466 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1467 * printcmd.c (info_symbol_command): Update.
1468 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1470 * objfiles.h (class all_objfiles): Remove.
1471 * objfiles.c (have_partial_symbols, have_full_symbols)
1472 (have_minimal_symbols, qsort_cmp, update_section_map)
1473 (shared_objfile_contains_address_p)
1474 (default_iterate_over_objfiles_in_search_order): Update.
1475 * objc-lang.c (info_selectors_command, info_classes_command)
1476 (find_methods): Update.
1477 * minsyms.c (find_solib_trampoline_target): Update.
1478 * maint.c (maintenance_info_sections)
1479 (maintenance_translate_address, count_symtabs_and_blocks):
1481 * main.c (captured_main_1): Update.
1482 * linux-thread-db.c (try_thread_db_load_from_pdir)
1483 (has_libpthread): Update.
1484 * linespec.c (iterate_over_all_matching_symtabs)
1485 (search_minsyms_for_name): Update.
1486 * jit.c (jit_find_objf_with_entry_addr): Update.
1487 * hppa-tdep.c (find_unwind_entry)
1488 (hppa_lookup_stub_minimal_symbol): Update.
1489 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1491 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1492 (elf_gnu_ifunc_resolve_by_got): Update.
1493 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1494 * dwarf-index-write.c (save_gdb_index_command): Update.
1495 * cp-support.c (add_symbol_overload_list_qualified): Update.
1496 * breakpoint.c (create_overlay_event_breakpoint)
1497 (create_longjmp_master_breakpoint)
1498 (create_std_terminate_master_breakpoint)
1499 (create_exception_master_breakpoint): Update.
1500 * blockframe.c (find_pc_partial_function): Update.
1501 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1502 (ada_collect_symbol_completion_matches)
1503 (ada_add_global_exceptions): Update.
1505 2019-01-17 Tom Tromey <tom@tromey.com>
1507 * solib-target.c (lm_info_target_p): Remove typedef. Don't
1509 (solib_target_parse_libraries): Change return type.
1510 (library_list_start_segment, library_list_start_section)
1511 (library_list_end_library, library_list_start_library); Update.
1512 (solib_target_free_library_list): Remove.
1513 (solib_target_parse_libraries): Remove cleanup. Change return
1515 (solib_target_current_sos): Update.
1517 2019-01-17 Tom Tromey <tromey@bapiya>
1519 * valprint.c: Replace "the the" with "the".
1520 * symtab.c: Replace "the the" with "the".
1521 * solib.c: Replace "the the" with "the".
1522 * solib-dsbt.c: Replace "the the" with "the".
1523 * linespec.c: Replace "the the" with "the".
1524 * dwarf2loc.h: Replace "the the" with "the".
1525 * amd64-windows-tdep.c: Replace "the the" with "the".
1526 * aarch64-tdep.c: Replace "the the" with "the".
1528 2019-01-16 Keith Seitz <keiths@redhat.com>
1531 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1532 <builder>: Rename to ..
1533 <m_builder>: ... this and make private.
1534 (dwarf2_cu::get_builder): New method. Change all users of
1535 `builder' to use this method.
1536 (dwarf2_start_symtab): Move to ...
1537 (dwarf2_cu::start_symtab): ... here. Update all callers
1538 (setup_type_unit_groups): Move to ...
1539 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
1541 (dwarf2_cu::reset_builder): New method.
1542 (process_full_compunit, process_full_type_unit): Use
1543 dwarf2_cu::reset_builder.
1544 (follow_die_offset): Record the ancestor CU if it is different
1545 from the followed DIE's CU.
1546 (follow_die_sig_1): Likewise.
1548 2019-01-15 Tom Tromey <tom@tromey.com>
1550 * remote.c (class remote_state) <buf>: Now a char_vector.
1552 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
1554 (remote_target::getpkt_or_notif_sane_1)
1555 (remote_target::getpkt_sane)
1556 (remote_target::getpkt_or_notif_sane): Likewise.
1557 (class remote_target) <putpkt>: New overload.
1558 (remote_target::read_frame): Change type of "buf_p". Remove
1560 (packet_ok): New overload.
1561 (packet_check_result): New overload.
1564 2019-01-14 Tom Tromey <tom@tromey.com>
1566 * remote-notif.c (handle_notification, remote_notif_ack)
1567 (remote_notif_parse): Make "buf" const.
1568 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1570 (remote_notif_parse, remote_notif_ack, handle_notification):
1572 * remote.c (remote_notif_stop_parse): Make "buf" const.
1573 (remote_target::remote_parse_stop_reply): Make "buf" const.
1574 (remote_notif_stop_ack): Make "buf" const.
1576 2019-01-14 Tom Tromey <tom@tromey.com>
1578 * remote.c (remote_console_output): Make parameter const.
1580 2019-01-14 Tom Tromey <tom@tromey.com>
1582 * target-debug.h (target_debug_print_signals): Constify.
1583 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1584 * procfs.c (procfs_target::pass_signals): Update.
1585 * linux-nat.c (linux_nat_target::pass_signals): Update.
1586 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1587 * target-delegates.c: Rebuild.
1588 * remote.c (remote_target::program_signals): Update.
1589 (remote_target::pass_signals): Update.
1590 * target.c (target_pass_signals): Constify argument.
1591 (target_program_signals): Likewise.
1592 * target.h (struct target_ops) <pass_signals, program_signals>:
1594 (target_pass_signals, target_program_signals): Constify argument.
1596 2019-01-14 Tom Tromey <tom@tromey.com>
1599 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1601 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
1603 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1605 * rs6000-tdep.c: Include reggroups.h.
1606 (IS_V_ALIAS_PSEUDOREG): Define.
1607 (rs6000_register_name): Return names for the "vX" aliases.
1608 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1609 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
1610 aliases. Call default_register_reggroup_p for all other
1612 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1614 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1615 Handle "vX" aliases.
1616 (v_alias_pseudo_register_collect): New function.
1617 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1618 (rs6000_gdbarch_init): Initialize "vX" aliases as
1619 pseudo-registers. Restore registration of
1620 rs6000_pseudo_register_reggroup_p with
1621 set_tdesc_pseudo_register_reggroup_p.
1623 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
1625 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1626 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1627 set_gdbarch_num_pseudo_regs.
1629 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1631 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1632 Remove arg prefixname, add do_set and do_show.
1633 Add member functions set_list and show_list.
1634 * cli/cli-style.c (class cli_style_option): Update accordingly.
1635 (style_set_list): Move to file scope.
1636 (style_show_list): Likewise.
1637 (set_style): Call help_list.
1638 (show_style): Call cmd_show_list.
1639 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1640 Update to use the new macro.
1642 2019-10-12 Joel Brobecker <brobecker@adacore.com>
1644 * ada-lang.c (_initialize_ada_language): Expand the help text
1645 for the "catch exception" command.
1647 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1649 * symtab.c (matching_obj_sections): Initialize obj,
1650 declare it closer to its usage.
1652 2019-01-10 Tom Tromey <tom@tromey.com>
1654 * thread-iter.h (inf_threads_iterator): Use next_iterator.
1655 (basic_inf_threads_range): Remove.
1656 (inf_threads_range, inf_non_exited_threads_range)
1657 (safe_inf_threads_range): Use next_adapter.
1659 2019-01-10 Keith Seitz <keiths@redhat.com>
1663 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1664 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1666 2019-01-10 Keith Seitz <keiths@redhat.com>
1670 * dictionary.c (pending_to_vector): Remove.
1671 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1672 Remove _1 suffix, replacing functions of the same name. Update
1674 (dict_create_hashed, dict_create_hashed_expandable)
1675 (dict_create_linear, dict_create_linear_expandable, dict_free)
1676 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1677 Make functions static.
1679 2019-01-10 Keith Seitz <keiths@redhat.com>
1683 * dictionary.h (struct dictionary): Replace declaration with
1685 (dict_create_hashed, dict_create_hashed_expandable)
1686 (dict_create_linear, dict_create_linear_expandable)
1687 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1688 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1689 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1690 taking multidictionary argument.
1691 [ALL_DICT_SYMBOLS]: Update for multidictionary.
1692 * block.h (struct block) <dict>: Change to multidictionary
1693 and rename `multidict'.
1694 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1695 symmisc.c: Update all dictionary references to multidictionary.
1697 2019-01-10 Keith Seitz <keiths@redhat.com>
1701 * dictionary.c: Include unordered_map.
1702 (pending_to_vector): New function.
1703 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1704 Rewrite the non-"_1" functions to take vector instead
1706 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1707 "new" _1 versions of the same name.
1708 (multidictionary): Define.
1709 (std::hash<enum language): New definition.
1710 (collate_pending_symbols_by_language, mdict_create_hashed)
1711 (mdict_create_hashed_expandable, mdict_create_linear)
1712 (mdict_create_linear_expandable, mdict_free)
1713 (find_language_dictionary, create_new_language_dictionary)
1714 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1715 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1716 (mdict_size, mdict_empty): New functions.
1717 * dictionary.h (mdict_iterator): Define.
1719 2019-01-10 Pedro Alves <palves@redhat.com>
1721 * breakpoint.c (read_uploaded_action)
1722 (create_tracepoint_from_upload): Adjust to use
1723 gdb::unique_xmalloc_ptr.
1724 * ctf.c (ctf_write_uploaded_tp):
1725 (SET_ARRAY_FIELD): Use emplace_back.
1726 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1727 * tracefile-tfile.c (tfile_write_uploaded_tp):
1728 * tracepoint.c (parse_tracepoint_definition): Adjust to use
1729 gdb::unique_xmalloc_ptr.
1730 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1731 at_string, cond_string, cmd_strings>: Replace char pointers
1732 with gdb::unique_xmalloc_ptr.
1734 2019-01-10 Pedro Alves <palves@redhat.com>
1736 * solib-target.c (library_list_start_library): Don't xstrdup name.
1738 2019-01-10 Pedro Alves <palves@redhat.com>
1740 * mdebugread.c (parse_partial_symbols): Use
1741 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1743 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
1745 * linux-fork.c (scoped_switch_fork_info)
1746 <~scoped_switch_fork_info>: Fix incorrect variable name.
1748 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
1750 * linux-fork.c (scoped_switch_fork_info)
1751 <scoped_switch_fork_info>: Make explicit.
1752 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1754 2019-01-10 Tom Tromey <tom@tromey.com>
1756 * objfiles.h (objfile::reset_psymtabs): Update.
1757 * objfiles.c (objfile::objfile): Update.
1758 * psymtab.h (psymtab_storage::obstack): Update.
1759 (psymtab_storage::m_obstack): Use gdb::optional.
1760 (class psymtab_storage): Update comment. Remove objfile
1762 * psymtab.c (psymtab_storage::psymtab_storage): Update.
1764 2019-01-10 Tom Tromey <tom@tromey.com>
1766 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1767 <free_psymtabs>: Now private.
1768 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1769 (allocate_psymtab): Use new method.
1771 2019-01-10 Tom Tromey <tom@tromey.com>
1773 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1774 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1775 * mdebugread.c (parse_partial_symbols): Use
1776 allocate_dependencies.
1777 * dwarf2read.c (dwarf2_create_include_psymtab): Use
1778 allocate_dependencies.
1779 (process_psymtab_comp_unit_reader)
1780 (build_type_psymtab_dependencies): Likewise.
1781 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1783 2019-01-10 Tom Tromey <tom@tromey.com>
1785 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1786 PSYMBOL_SET_LANGUAGE.
1787 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1789 2019-01-10 Tom Tromey <tom@tromey.com>
1791 * psymtab.h (psymtab_storage::obstack): New method.
1792 <m_obstack>: Rename from obstack; now private.
1793 * psymtab.c (psymtab_storage): Update.
1794 * dwarf2read.c (create_addrmap_from_index)
1795 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1798 2019-01-10 Tom Tromey <tom@tromey.com>
1800 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1801 * objfiles.h (objfile::reset_psymtabs): New method.
1803 2019-01-10 Tom Tromey <tom@tromey.com>
1805 * symmisc.c (print_symbol_bcache_statistics): Update.
1806 (print_objfile_statistics): Update.
1807 * symfile.c (reread_symbols): Update.
1808 * psymtab.h (class psymtab_storage): New.
1809 * psymtab.c (psymtab_storage): New constructor.
1810 (~psymtab_storage): New destructor.
1811 (require_partial_symbols): Update.
1812 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1813 (find_pc_sect_psymtab, find_pc_sect_psymbol)
1814 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1815 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1816 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1817 (start_psymtab_common, end_psymtab_common)
1818 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1819 (allocate_psymtab): Update.
1820 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1822 (dump_psymtab_addrmap, maintenance_print_psymbols)
1823 (maintenance_check_psymtabs): Update.
1824 (class objfile_psymtabs): Move to objfiles.h.
1825 * psympriv.h (discard_psymtab): Now inline.
1826 (psymtab_discarder::psymtab_discarder): Update.
1827 (psymtab_discarder::~psymtab_discarder): Update.
1828 (ALL_OBJFILE_PSYMTABS): Rewrite.
1829 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1830 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1832 <partial_symtabs>: New field.
1833 (class objfile_psymtabs): Move from psymtab.h. Update.
1834 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1836 (objfile::~objfile): Don't destroy psymbol_cache.
1837 * mdebugread.c (parse_partial_symbols): Update.
1838 * dwarf2read.c (create_addrmap_from_index)
1839 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1840 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1841 (add_partial_subprogram, dwarf2_ranges_read): Update.
1842 * dwarf-index-write.c (write_address_map)
1843 (write_one_signatured_type, recursively_write_psymbols)
1844 (class debug_names, class debug_names, write_psymtabs_to_index):
1847 2019-01-10 Tom Tromey <tom@tromey.com>
1849 * symtab.h (SYMBOL_SET_NAMES): Update.
1850 (symbol_set_names): Update.
1851 (MSYMBOL_SET_NAMES): Update.
1852 * symtab.c (symbol_set_names): Change argument to be an
1853 objfile_per_bfd_storage.
1854 * psymtab.c (add_psymbol_to_bcache): Update.
1855 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1857 2019-01-10 Tom Tromey <tom@tromey.com>
1859 * symtab.c (create_demangled_names_hash): Change argument to be an
1860 objfile_per_bfd_storage.
1861 (symbol_set_names): Update.
1863 2019-01-10 Tom Tromey <tom@tromey.com>
1865 * xcoffread.c (xcoff_initial_scan): Unconditionally call
1867 * psymtab.c (init_psymbol_list): Do nothing if already called.
1868 * psympriv.h (init_psymbol_list): Add comment.
1869 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1871 * dbxread.c (dbx_symfile_read): Unconditionally call
1874 2019-01-10 Tom Tromey <tom@tromey.com>
1876 * xcoffread.c (scan_xcoff_symtab): Update.
1877 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1879 * mdebugread.c (parse_partial_symbols)
1880 (handle_psymbol_enumerators): Update.
1881 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1882 * dbxread.c (read_dbx_symtab): Update.
1883 * psympriv.h (psymbol_placement): New enum.
1884 (add_psymbol_to_list): Update.
1886 2019-01-10 Tom Tromey <tom@tromey.com>
1888 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1889 static_psymbols parameters.
1890 (scan_xcoff_symtab): Update.
1891 * psymtab.c (start_psymtab_common): Remove global_psymbols and
1892 static_psymbols parameters.
1893 * psympriv.h (start_psymtab_common): Update.
1894 * mdebugread.c (parse_partial_symbols): Update.
1895 * dwarf2read.c (create_partial_symtab): Update.
1896 * dbxread.c (read_dbx_symtab): Update.
1897 (start_psymtab): Remove global_psymbols and static_psymbols
1900 2019-01-10 Tom Tromey <tom@tromey.com>
1902 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1903 * psymtab.c (allocate_psymtab): Add comment.
1904 * psympriv.h (allocate_psymtab): Add comment.
1905 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1907 * dbxread.c (dbx_end_psymtab): Remove some initializations.
1909 2019-01-10 Tom Tromey <tom@tromey.com>
1911 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1913 * mipsread.c: Include mdebugread.h.
1914 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1916 * elfread.c: Include mdebugread.h.
1918 2019-01-09 Tom Tromey <tom@tromey.com>
1920 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1921 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1922 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1923 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1924 (psym_lookup_symbol, psym_find_last_source_symtab)
1925 (psym_forget_cached_source_info, psym_print_stats)
1926 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1927 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1928 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1929 (psym_find_compunit_symtab_by_address)
1930 (maintenance_print_psymbols, maintenance_info_psymtabs)
1931 (maintenance_check_psymtabs): Use ranged for.
1932 * psymtab.h (class objfile_psymtabs): New.
1933 (require_partial_symbols): Return objfile_psymtabs.
1934 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1936 2019-01-09 Tom Tromey <tom@tromey.com>
1938 * symfile.c (overlay_invalidate_all, find_pc_overlay)
1939 (find_pc_mapped_section, list_overlays_command)
1940 (map_overlay_command, unmap_overlay_command)
1941 (simple_overlay_update): Use all_objfiles.
1942 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1943 * printcmd.c (info_symbol_command): Use all_objfiles.
1944 * objfiles.h (ALL_OBJSECTIONS): Remove.
1945 * maint.c (maintenance_translate_address): Use all_objfiles.
1946 * gcore.c (gcore_create_callback): Use all_objfiles.
1947 (objfile_find_memory_regions): Likewise.
1949 2019-01-09 Tom Tromey <tom@tromey.com>
1951 * symtab.c (find_line_symtab, info_sources_command)
1952 (make_source_files_completion_list): Use objfile_compunits.
1953 * source.c (select_source_symtab): Use objfile_compunits.
1954 * objfiles.h (struct objfile): Update comment.
1955 (ALL_OBJFILES): Remove.
1956 (ALL_FILETABS): Remove.
1957 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1960 2019-01-09 Tom Tromey <tom@tromey.com>
1962 * symmisc.c (print_objfile_statistics, dump_objfile)
1963 (maintenance_print_symbols): Use compunit_filetabs.
1964 * source.c (forget_cached_source_info_for_objfile): Use
1966 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1967 (ALL_FILETABS): Use compunit_filetabs.
1968 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1969 * coffread.c (coff_symtab_read): Use compunit_filetabs.
1971 2019-01-09 Tom Tromey <tom@tromey.com>
1973 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1974 (compunit_filetabs): New.
1975 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1977 (info_sources_command, make_source_files_completion_list): Remove
1979 * symmisc.c (print_objfile_statistics, dump_objfile)
1980 (maintenance_print_symbols): Remove declaration.
1981 (maintenance_info_symtabs): Use compunit_filetabs.
1982 (maintenance_info_line_tables): Likewise.
1983 * source.c (select_source_symtab): Change local variable name.
1984 (forget_cached_source_info_for_objfile): Remove declaration.
1985 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1986 * objfiles.c (objfile_relocate1): Remove declaration.
1987 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1989 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1990 * coffread.c (coff_symtab_read): Remove declaration.
1991 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1994 2019-01-09 Tom Tromey <tom@tromey.com>
1996 * symtab.c (lookup_objfile_from_block)
1997 (find_pc_sect_compunit_symtab, search_symbols)
1998 (default_collect_symbol_completion_matches_break_on): Use
2000 * objfiles.h (ALL_COMPUNITS): Remove.
2001 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2002 * cp-support.c (add_symbol_overload_list_qualified): Use
2004 * ada-lang.c (ada_collect_symbol_completion_matches)
2005 (ada_add_global_exceptions): Use objfile_compunits.
2007 2019-01-09 Tom Tromey <tom@tromey.com>
2009 * source.c (select_source_symtab)
2010 (forget_cached_source_info_for_objfile): Remove declaration.
2011 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2013 * maint.c (count_symtabs_and_blocks): Remove declaration.
2014 * cp-support.c (add_symbol_overload_list_qualified): Remove
2016 * coffread.c (coff_symtab_read): Remove declaration.
2017 * symtab.c (lookup_symbol_in_objfile_symtabs)
2018 (basic_lookup_transparent_type_1): Use objfile_compunits.
2019 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2020 (info_sources_command, search_symbols)
2021 (default_collect_symbol_completion_matches_break_on)
2022 (make_source_files_completion_list): Remove declaration.
2023 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2024 (ada_collect_symbol_completion_matches)
2025 (ada_add_global_exceptions): Remove declaration.
2026 * linespec.c (iterate_over_all_matching_symtabs): Use
2028 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2029 (class objfile_compunits): New.
2030 (ALL_COMPUNITS): Use objfile_compunits.
2031 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2032 (maintenance_check_symtabs, maintenance_info_line_tables): Use
2034 * objfiles.c (objfile_relocate1): Use objfile_compunits.
2036 2019-01-09 Tom Tromey <tom@tromey.com>
2038 * symtab.c (search_symbols)
2039 (default_collect_symbol_completion_matches_break_on): Use
2041 * ada-lang.c (ada_lookup_simple_minsym)
2042 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2043 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2044 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2046 * coffread.c (coff_symfile_read): Use objfile_msymbols.
2047 * symmisc.c (dump_msymbols): Use objfile_msymbols.
2048 * objc-lang.c (find_methods): Use objfile_msymbols.
2049 (info_selectors_command, info_classes_command): Likewise.
2050 * stabsread.c (scan_file_globals): Use objfile_msymbols.
2051 * objfiles.h (class objfile_msymbols): New.
2052 (ALL_OBJFILE_MSYMBOLS): Remove.
2053 (ALL_MSYMBOLS): Remove.
2055 2019-01-09 Tom Tromey <tom@tromey.com>
2057 * common/next-iterator.h (next_adapter): Add Iterator template
2059 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2060 (class all_objfiles_safe): New.
2061 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2062 * objfiles.c (put_objfile_before): Update comment.
2063 (add_separate_debug_objfile): Likewise.
2064 (free_all_objfiles): Use all_objfiles_safe.
2065 (objfile_purge_solibs): Likewise.
2067 2019-01-09 Tom Tromey <tom@tromey.com>
2069 * symtab.c (iterate_over_symtabs, matching_obj_sections)
2070 (expand_symtab_containing_pc, lookup_static_symbol)
2071 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2072 (find_symbol_at_address, find_line_symtab, find_main_name): Use
2074 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2075 * breakpoint.c (create_overlay_event_breakpoint)
2076 (create_longjmp_master_breakpoint)
2077 (create_std_terminate_master_breakpoint)
2078 (create_exception_master_breakpoint): Use all_objfiles.
2079 * linux-thread-db.c (try_thread_db_load_from_pdir)
2080 (has_libpthread): Use all_objfiles.
2081 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2082 * linespec.c (iterate_over_all_matching_symtabs)
2083 (search_minsyms_for_name): Use all_objfiles.
2084 * maint.c (maintenance_info_sections): Use all_objfiles.
2085 * main.c (captured_main_1): Use all_objfiles.
2086 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2087 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2088 * guile/scm-pretty-print.c
2089 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2090 * solib-spu.c (append_ocl_sos): Use all_objfiles.
2091 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2092 (maintenance_print_msymbols): Use all_objfiles.
2093 * source.c (select_source_symtab): Use all_objfiles.
2094 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2095 * symfile.c (remove_symbol_file_command)
2096 (expand_symtabs_matching, map_symbol_filenames): Use
2098 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2100 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2101 * objc-lang.c (find_methods): Use all_objfiles.
2102 * objfiles.c (have_partial_symbols, have_full_symbols)
2103 (have_minimal_symbols, qsort_cmp)
2104 (default_iterate_over_objfiles_in_search_order): Use
2106 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2107 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2108 (maintenance_check_psymtabs): Use all_objfiles.
2109 (ALL_PSYMTABS): Remove.
2110 * compile/compile-object-run.c (do_module_cleanup): Use
2112 * blockframe.c (find_pc_partial_function): Use all_objfiles.
2113 * cp-support.c (add_symbol_overload_list_qualified): Use
2115 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2117 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2118 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2120 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2121 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2122 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2124 * solib.c (solib_read_symbols): Use all_objfiles
2126 2019-01-09 Tom Tromey <tom@tromey.com>
2128 * probe.c (parse_probes_in_pspace): Use all_objfiles.
2129 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2131 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2132 * symmisc.c (print_symbol_bcache_statistics)
2133 (print_objfile_statistics, maintenance_print_objfiles)
2134 (maintenance_info_symtabs, maintenance_check_symtabs)
2135 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2137 * source.c (forget_cached_source_info): Use all_objfiles.
2138 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2139 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2140 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2141 * objfiles.c (update_section_map): Use all_objfiles.
2142 (shared_objfile_contains_address_p): Likewise.
2143 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2144 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2146 2019-01-09 Tom Tromey <tom@tromey.com>
2148 * common/next-iterator.h: New file.
2149 * objfiles.h (class all_objfiles): New.
2150 (struct objfile_iterator): New.
2152 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2154 * NEWS: Move the description of the changed "frame", "select-frame",
2155 and "info frame" commands to the Changed commands section.
2157 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
2159 * gdbtypes.c (check_stub_method_group): Remove handling of old
2161 * linespec.c (find_methods): Likewise.
2162 * stabsread.c (read_member_functions): Likewise.
2163 * valops.c (search_struct_method): Likewise.
2164 (value_struct_elt_for_reference): Likewise.
2165 * NEWS: Mention this change.
2167 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
2169 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2171 * source.c (print_source_lines_base): Update line number check.
2172 (print_source_lines): New function.
2173 (source_lines_range::source_lines_range): New function.
2174 * source.h (class source_lines_range): New class.
2175 (print_source_lines): New declaration.
2177 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2179 * linespec.c (linespec_state_destructor): Free self->canonical_names.
2181 2019-01-08 Tom Tromey <tom@tromey.com>
2182 Simon Marchi <simon.marchi@ericsson.com>
2185 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2186 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2187 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2188 * f-exp.y (DOLLAR_VARIABLE): Likewise.
2189 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2190 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2192 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
2194 * source.c (select_source_symtab): Move header comment to
2195 declaration in source.h.
2196 (forget_cached_source_info_for_objfile): Likewise.
2197 (forget_cached_source_info): Likewise.
2198 (identify_source_line): Likewise.
2199 * source.h (identify_source_line): Move declaration from symtab.h
2200 and add comment from source.c
2201 (print_source_lines): Likewise.
2202 (forget_cached_source_info_for_objfile): Likewise.
2203 (forget_cached_source_info): Likewise.
2204 (select_source_symtab): Likewise.
2205 (enum print_source_lines_flag): Move definition from symtab.h.
2206 * symtab.h (identify_source_line): Move declaration to source.h.
2207 (print_source_lines): Likewise.
2208 (forget_cached_source_info_for_objfile): Likewise.
2209 (forget_cached_source_info): Likewise.
2210 (select_source_symtab): Likewise.
2211 (enum print_source_lines_flag): Move definition to source.h.
2212 * tui/tui-hooks.c: Add 'source.h' include.
2214 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
2216 * source.c (print_source_lines_base): Handle requests to print
2217 reverse line number sequences, and guard against empty lines
2220 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
2222 * source.c (print_source_lines_base): Fix skip of '\r' if next
2225 2019-01-06 Tom Tromey <tom@tromey.com>
2227 * c-exp.y (struct c_parse_state) <macro_original_text,
2228 expansion_obstack>: New member.
2229 (macro_original_text, expansion_obstack): Remove globals.
2230 (scan_macro_expansion, scanning_macro_expansion)
2231 (finished_macro_expansion): Update.
2232 (scan_macro_cleanup): Remove.
2233 (yylex, c_parse): Update.
2235 2019-01-06 Tom Tromey <tom@tromey.com>
2237 * c-exp.y (struct c_parse_state) <strings>: New member.
2238 (operator_stoken): Update.
2240 2019-01-06 Tom Tromey <tom@tromey.com>
2242 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
2243 (union type_stack_elt) <typelist_val>: Now a pointer to
2245 (type_stack_cleanup): Don't declare.
2246 (push_typelist): Update.
2247 * parse.c (pop_typelist): Return a std::vector.
2248 (push_typelist): Take a std::vector.
2249 (follow_types): Update. Do not free args.
2250 (type_stack_cleanup): Remove.
2251 * c-exp.y (struct c_parse_state): New.
2252 (cpstate): New global.
2253 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2254 (nonempty_typelist): Update.
2255 (func_mod): Create a new vector.
2256 (c_parse): Create a c_parse_state.
2257 (check_parameter_typelist): Do not delete params.
2258 (function_method): Update. Do not delete type_list.
2260 2019-01-06 Tom Tromey <tom@tromey.com>
2263 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2265 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2266 (print_return_value): Likewise.
2268 2019-01-05 Tom Tromey <tom@tromey.com>
2270 * contrib/cleanup_check.py: Remove.
2271 * contrib/gcc-with-excheck: Remove.
2272 * contrib/exsummary.py: Remove.
2273 * contrib/excheck.py: Remove.
2275 2019-01-05 Joel Brobecker <brobecker@adacore.com>
2277 * thread.c (delete_thread_1): Add gdb_assert that THR is not
2278 NULL. Initialize tpprev to NULL instead of assigning it
2279 to NULL on the next statement.
2280 * windows-nat.c (windows_delete_thread): Remove check for
2281 main_thread_id before printing thread exit notifications.
2282 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2283 Remove thread ID check against main_thread_id.
2284 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2285 windows_delete_thread.
2286 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2288 2019-01-04 Tom Tromey <tom@tromey.com>
2290 * compile/compile.c (_initialize_compile): Use upper case for
2291 metasyntactic variables.
2292 * symmisc.c (_initialize_symmisc): Use upper case for
2293 metasyntactic variables.
2294 * psymtab.c (_initialize_psymtab): Use upper case for
2295 metasyntactic variables.
2296 * demangle.c (demangle_command): Use upper case for metasyntactic
2298 (_initialize_demangler): Likewise.
2299 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2302 2019-01-03 Tom Tromey <tom@tromey.com>
2304 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2306 2019-01-03 Tom Tromey <tom@tromey.com>
2308 * python/py-symtab.c (salpy_str): Update.
2309 (struct salpy_sal_object) <symtab>: Now a PyObject.
2310 (salpy_dealloc): Update.
2311 (del_objfile_sal): Use gdbpy_ref.
2313 2019-01-03 Tom Tromey <tom@tromey.com>
2315 * python/py-type.c (convert_field): Use new_reference. Return
2317 (make_fielditem): Return gdbpy_ref.
2318 (typy_fields): Update.
2319 (typy_getitem): Update.
2320 (field_name): Return gdbpy_ref. Use new_reference.
2321 (typy_iterator_iternext): Update.
2323 2019-01-03 Tom Tromey <tom@tromey.com>
2325 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2327 2019-01-03 Tom Tromey <tom@tromey.com>
2329 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2330 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2331 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2332 (pspy_set_frame_filters, pspy_set_frame_unwinders)
2333 (pspy_set_type_printers): Likewise.
2334 * python/py-function.c (fnpy_init): Use gdbpy_ref.
2335 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2336 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2337 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2338 (objfpy_set_type_printers): Likewise.
2340 2019-01-03 Tom Tromey <tom@tromey.com>
2342 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2343 (gdbpy_print_stack): Use gdbpy_err_fetch.
2344 * python/python-internal.h (class gdbpy_err_fetch): New class.
2345 (class gdbpy_enter) <m_error_type, m_error_value,
2346 m_error_traceback>: Remove.
2347 <m_error>: New member.
2348 (gdbpy_exception_to_string): Don't declare.
2349 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2350 * python/py-value.c (convert_value_from_python): Use
2352 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2353 gdbpy_exception_to_string.
2354 (gdbpy_handle_exception): Use gdbpy_err_fetch.
2355 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2358 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
2360 * linux-nat.c (delete_lwp_cleanup): Delete.
2361 (struct lwp_deleter): New struct.
2362 (lwp_info_up): New typedef.
2363 (linux_nat_target::follow_fork): Delete cleanup, and make use of
2366 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
2368 * linux-fork.c (class scoped_switch_fork_info): New class.
2369 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2371 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
2373 * valops.c (find_overload_match): Remove use of null_cleanup, and
2374 calls to do_cleanups.
2376 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
2378 * compile/compile-cplus-types.c
2379 (compile_cplus_instance::decl_name): Handle changes to
2381 * cp-support.c (cp_func_name): Update header comment, update
2383 * cp-support.h (cp_func_name): Update return type in declaration.
2384 * valops.c (find_overload_match): Move temp_func local to top
2385 level of function and change its type. Use temp_func to hold and
2386 delete temporary string obtained from cp_func_name.
2388 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
2390 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2391 gdb::char_vector, remove cleanup, and update uses of `msg`.
2393 2019-01-03 Jim Wilson <jimw@sifive.com>
2395 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2397 2019-01-02 Tom Tromey <tom@tromey.com>
2399 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2400 (tdesc_parse_xml): Remove cleanups.
2401 * target-descriptions.h (make_cleanup_free_target_description):
2403 (target_desc_deleter): New struct.
2404 (target_desc_up): New typedef.
2405 * target-descriptions.c (target_desc_deleter::operator()): Rename
2406 from free_target_description.
2407 (make_cleanup_free_target_description): Remove.
2409 2019-01-02 Tom Tromey <tom@tromey.com>
2411 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
2412 constructor, destructor.
2413 (linespec_parser): Remove typedef.
2414 (~linespec_parser): Rename from linespec_parser_delete.
2415 (linespec_lex_to_end, linespec_complete_label)
2416 (linespec_complete): Update.
2417 (decode_line_full): Remove cleanups.
2418 (decode_line_1): Update.
2420 2019-01-02 Tom Tromey <tom@tromey.com>
2422 * python/python-internal.h (inferior_to_inferior_object): Change
2424 * python/py-exitedevent.c (create_exited_event_object): Update.
2425 * python/py-inferior.c (inferior_to_inferior_object): Return
2427 (python_new_inferior, python_inferior_deleted)
2428 (thread_to_thread_object, delete_thread_object)
2429 (build_inferior_list, gdbpy_selected_inferior): Update.
2430 * python/py-infthread.c (create_thread_object): Update. Also fail
2431 if inferior_to_inferior_object fails.
2433 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
2435 * inferior.h (class inferior) <displaced_step_state>: New field.
2436 * infrun.h (struct displaced_step_state): Move here from
2437 infrun.c. Initialize fields, add constructor.
2438 <inf>: Remove field.
2439 <reset>: New method.
2440 * infrun.c (struct displaced_step_inferior_state): Move to
2442 (displaced_step_inferior_states): Remove.
2443 (get_displaced_stepping_state): Adust.
2444 (displaced_step_in_progress_any_inferior): Adjust.
2445 (displaced_step_in_progress_thread): Adjust.
2446 (displaced_step_in_progress): Adjust.
2447 (add_displaced_stepping_state): Remove.
2448 (get_displaced_step_closure_by_addr): Adjust.
2449 (remove_displaced_stepping_state): Remove.
2450 (infrun_inferior_exit): Call displaced_step_state.reset.
2451 (use_displaced_stepping): Don't check for NULL.
2452 (displaced_step_prepare_throw): Call
2453 get_displaced_stepping_state.
2454 (displaced_step_fixup): Don't check for NULL.
2455 (prepare_for_detach): Don't check for NULL.
2457 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2459 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2460 in case of call that did not complete.
2462 2019-01-02 Andrey Utkin <autkin@undo.io>
2464 * symfile.c (find_separate_debug_file): Fix search of debug files for
2467 2019-01-02 Tom Tromey <tom@tromey.com>
2469 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2471 * python/py-frame.c (frapy_older): Remove cast.
2472 (frapy_newer): Likewise.
2473 * python/py-breakpoint.c (local_setattro): Remove cast.
2474 * python/py-arch.c (archpy_name): Remove local variable.
2475 * python/py-type.c (gdbpy_lookup_type): Remove cast.
2477 2019-01-02 Joel Brobecker <brobecker@adacore.com>
2479 * unittests/basic_string_view/element_access/char/empty.cc:
2480 Fix year range in copyright header.
2482 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
2484 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2486 <operator==>: Update with for removed field.
2488 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2489 <isa_features>: ...this.
2490 <abi_features>: New field.
2491 (riscv_isa_flen): Update comment.
2492 (riscv_abi_xlen): New declaration.
2493 (riscv_abi_flen): New declaration.
2494 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2496 (riscv_abi_xlen): New function.
2497 (riscv_isa_flen): Update to get answer from isa_features.
2498 (riscv_abi_flen): New function.
2499 (riscv_has_fp_abi): Update to get answer from abi_features.
2500 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2502 (riscv_call_info) <xlen, flen>: Update comment.
2503 (riscv_call_arg_struct): Remove invalid assertions
2504 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2506 (riscv_gdbarch_init): Gather isa features and abi features
2507 separately, ensure both match on the gdbarch when reusing an old
2508 gdbarch. Relax an error check to allow 32-bit abi float to run on
2509 a target with 64-bit float hardware.
2511 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2513 * source.c (search_command_helper): Stop reverse search
2514 when line 1 has been searched.
2516 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2518 * record-full.c (record_full_base_target::close): Rewrite
2519 record_full_core_buf_list free logic.
2521 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2523 * break-catch-syscall.c (print_one_catch_syscall): xfree
2526 2019-01-01 Joel Brobecker <brobecker@adacore.com>
2528 * top.c (print_gdb_version): Update Copyright year in version
2531 2019-01-01 Joel Brobecker <brobecker@adacore.com>
2533 Update copyright year range in all GDB files.
2535 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2537 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2539 For older changes see ChangeLog-2018.
2545 version-control: never