gdb/ChangeLog

   1 2019-07-30  Tom Tromey  <tromey@adacore.com>
   2
   3         * block.c (contained_in): Remove BLOCK_FUNCTION check.
   4
   5 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
   6
   7         * printcmd.c (print_address_symbolic): Print negative offsets.
   8         (build_address_symbolic): Force signed arithmetic when computing
   9         offset.
  10
  11 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
  12
  13         PR/24474: Add a function to lookup static variables.
  14         * NEWS: Mention this new function.
  15         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
  16         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
  17         * python/python.c (python_GdbMethods): Add new function.
  18
  19 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
  20
  21         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
  22         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
  23         (objfpy_lookup_static_symbol): New function.
  24         (objfile_object_methods): Add new functions.
  25
  26 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  27
  28         * NEWS: Mention 'set|show print frame-info'.  Mention new
  29         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
  30         backtrace argument.  Mention that python frame filtering code
  31         is now consistent with what 'backtrace' command prints.
  32
  33 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  34
  35         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
  36         comments.
  37         (print_frame_info_auto, print_frame_info_source_line,
  38         print_frame_info_location, print_frame_info_source_and_location,
  39         print_frame_info_location_and_address, print_frame_info_short_location):
  40         New declarations.
  41         (struct frame_print_options): New member print_frame_info.
  42         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
  43         * stack.h (get_user_print_what_frame_info): New declaration.
  44         (frame_show_address): New declaration.
  45         * stack.c (print_frame_arguments_choices): New value 'presence'.
  46         (print_frame_info_auto, print_frame_info_source_line,
  47         print_frame_info_location, print_frame_info_source_and_location,
  48         print_frame_info_location_and_address, print_frame_info_short_location,
  49         print_frame_info_choices, print_frame_info_print_what): New definitions.
  50         (print_frame_args): Only print dots for args if print frame-arguments
  51         is 'presence'.
  52         (frame_print_option_defs): New element for "frame-info".
  53         (get_user_print_what_frame_info): New function.
  54         (frame_show_address): Make non static.  Move comment to stack.h.
  55         (print_frame_info_to_print_what): New function.
  56         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
  57         to decide what to print.
  58         (backtrace_command_1): Handle the new print_frame_arguments_presence
  59         value.
  60         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
  61         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
  62         (py_print_frame): In non-mi mode, use LOCATION as default for
  63         print_what, similarly to frame information printed directly by
  64         backtrace command. Handle frame-info user option in non MI mode.
  65
  66 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  67
  68         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
  69         Add case for debugging 32-bit target on 64-bit host.  Revise
  70         comment.
  71
  72 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  73
  74         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
  75         instead of find_function_entry_range_from_pc.
  76
  77 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  78
  79         * stack.c (find_frame_funname): Remove code which preferred
  80         minsym over symtab sym in "certain pathological cases".
  81
  82         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
  83         parameter.  Change type of "do_demangle" to bool.
  84         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
  85         Pass suitable "prefer_sym_over_minsym" flag to
  86         build_address_symbolic().  Don't output "+" for negative offsets.
  87         * printcmd.c (print_address_symbolic): Update invocation of
  88         build_address_symbolic to include a "prefer_sym_over_minsym"
  89         flag.
  90         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
  91         Restrict cases in which use of minimal symbol is preferred to that
  92         of a found symbol.  Update comments.
  93
  94         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
  95         for entry pc when entry pc is out of range for that FDE.
  96
  97 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
  98
  99         PR gdb/24839:
 100         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 101         type.
 102
 103 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 104
 105         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 106         this function's Python signature.
 107
 108
 109 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 110
 111         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 112         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 113         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 114         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 115         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 116
 117
 118 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 119
 120         * h8300-tdep.c (h8300_register_name_common): New.
 121         h8300_register_name): Use h8300_register_name_common.
 122         (h8300s_register_name): Likewise.
 123         (h8300sx_register_name): Likewise.
 124         (h8300h_register_nam): New.
 125         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 126
 127
 128 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 129
 130         * arm-tdep.c (arm_skip_cmse_entry): New function.
 131         (arm_is_sgstubs_section): New function.
 132         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 133
 134 2019-07-22  Tom Tromey  <tom@tromey.com>
 135
 136         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 137         Don't self-assign.
 138
 139 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 140
 141         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 142         type_print.
 143
 144 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 145
 146         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 147         so that GDB doesn't match any msymbols when searching in the
 148         TYPES_DOMAIN.
 149         (print_symbol_info): Print using typedef_print or type_print based
 150         on the type of the symbol.  Add updated FIXME comment moved from...
 151         (_initialize_symtab): ... move and update FIXME comment to above.
 152
 153 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 154
 155         * NEWS: Mention adding -q option to "info types".
 156         * symtab.c (struct info_types_options): New struct.
 157         (info_types_options_defs): New variable.
 158         (make_info_types_options_def_group): New function.
 159         (info_types_command): Use gdb::option framework to parse options.
 160         (info_types_command_completer): New function.
 161         (_initialize_symtab): Extend the help text on "info types" and
 162         register command completer.
 163
 164 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 165
 166         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 167         (lookup_symbol_in_objfile): Change int to block_enum and add a
 168         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 169
 170 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 171
 172         * MAINTAINERS (Write After Approval): Add self.
 173
 174 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 175
 176         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 177         instruction to the dummy code region.
 178
 179 2019-07-19  Tom Tromey  <tromey@adacore.com>
 180
 181         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 182         (ARGSUSED, PARAMS, __func__): Remove rules.
 183
 184 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 185
 186         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 187         * features/arm/arm-with-iwmmxt.c: Remove.
 188         * features/arm/arm-with-iwmmxt.xml: Remove.
 189         * features/arm/arm-with-m-fpa-layout.c: Remove.
 190         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 191         * features/arm/arm-with-m-vfp-d16.c: Remove.
 192         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 193         * features/arm/arm-with-m.c: Remove.
 194         * features/arm/arm-with-m.xml: Remove.
 195         * features/arm/arm-with-neon.c: Remove.
 196         * features/arm/arm-with-neon.xml: Remove.
 197         * features/arm/arm-with-vfpv2.c: Remove.
 198         * features/arm/arm-with-vfpv2.xml: Remove.
 199         * features/arm/arm-with-vfpv3.c: Remove.
 200         * features/arm/arm-with-vfpv3.xml: Remove.
 201
 202 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 203
 204         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 205
 206 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 207
 208         * arch/aarch32.c (aarch32_create_target_description): Create
 209         target descriptions using features.
 210         * arch/arm.c (arm_create_target_description)
 211         (arm_create_mprofile_target_description): Likewise.
 212         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 213
 214 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 215
 216         * Makefile.in: Add new files.
 217         * aarch32-tdep.c: New file.
 218         * aarch32-tdep.h: New file.
 219         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 220         Call aarch32_read_description.
 221         * arch/aarch32.c: New file.
 222         * arch/aarch32.h: New file.
 223         * arch/arm.c (arm_create_target_description)
 224         (arm_create_mprofile_target_description): New function.
 225         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 226         (arm_create_target_description)
 227         (arm_create_mprofile_target_description): New declaration.
 228         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 229         read_description functions.
 230         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 231         Likewise.
 232         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 233         * arm-tdep.c (tdesc_arm_list): New variable.
 234         (arm_register_g_packet_guesses): Call create description functions.
 235         (arm_read_description) (arm_read_mprofile_description): New
 236         function.
 237         * arm-tdep.h (arm_read_description)
 238         (arm_read_mprofile_description): Add declaration.
 239         * configure.tgt: Add new files.
 240
 241 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 242
 243         * top.c (new_ui_command): Open specified terminal just once.
 244
 245 2019-07-18  Tom Tromey  <tromey@adacore.com>
 246
 247         * symtab.c (main_name): Constify return type.
 248         * symfile.c (set_initial_language): Update.
 249         * symtab.h (main_name): Constify return type.
 250
 251 2019-07-17  Tom Tromey  <tom@tromey.com>
 252
 253         * tui/tui-winsource.c (tui_update_source_window)
 254         (tui_update_source_window_as_is)
 255         (tui_update_source_windows_with_line): Remove return.
 256         * tui/tui-disasm.c (tui_show_disassem)
 257         (tui_show_disassem_and_update_source): Remove return.
 258         * tui/tui.c (tui_reset): Remove return.
 259         * tui/tui-wingeneral.c
 260         (tui_check_and_display_highlight_if_needed): Remove return.
 261
 262 2019-07-17  Tom Tromey  <tom@tromey.com>
 263
 264         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 265
 266 2019-07-17  Tom Tromey  <tom@tromey.com>
 267
 268         * tui/tui-winsource.h (struct tui_exec_info_window)
 269         (struct tui_source_window_base): Move from tui-data.h.
 270         * tui/tui-winsource.c: Move many method definitions from
 271         elsewhere.  Remove "structuring" comments.
 272         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 273         (tui_source_window_base::refresh_window): Move to
 274         tui-winsource.c.
 275         * tui/tui-win.c (tui_source_window_base::refresh_all)
 276         (tui_source_window_base::update_tab_width)
 277         (tui_source_window_base::set_new_height)
 278         (tui_source_window_base::do_make_visible_with_new_height): Move to
 279         tui-winsource.c.
 280         * tui/tui-source.h: Update.
 281         * tui/tui-source.c (tui_source_window_base::reset): Move to
 282         tui-winsource.c.
 283         * tui/tui-disasm.h: Update.
 284         * tui/tui-data.h (struct tui_exec_info_window): Move to
 285         tui-winsource.h.
 286         (struct tui_source_window_base): Likewise.
 287         * tui/tui-data.c (tui_source_window_base::clear_detail)
 288         (tui_source_window_base, ~tui_source_window_base): Move to
 289         tui-winsource.c.
 290
 291 2019-07-17  Tom Tromey  <tom@tromey.com>
 292
 293         * tui/tui-win.c (tui_resize_all)
 294         (tui_source_window_base::update_tab_width)
 295         (tui_adjust_win_heights): Update.
 296         (tui_win_info::make_invisible_and_set_new_height): Rename from
 297         make_invisible_and_set_new_height.
 298         * tui/tui-data.h (struct tui_win_info)
 299         <make_invisible_and_set_new_height>: New method.
 300
 301 2019-07-17  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui.c: Update.
 304         * tui/tui-source.h (struct tui_source_window): Move from
 305         tui-data.h.
 306         * tui/tui-layout.c: Update.
 307         * tui/tui-disasm.c: Update.
 308         * tui/tui-data.h (struct tui_source_window): Move to
 309         tui-source.h.
 310
 311 2019-07-17  Tom Tromey  <tom@tromey.com>
 312
 313         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 314         tui-data.h.
 315         * tui/tui-data.h (struct tui_disasm_window): Move to
 316         tui-disasm.h.
 317
 318 2019-07-17  Tom Tromey  <tom@tromey.com>
 319
 320         * tui/tui-regs.h (struct tui_data_item_window): Move from
 321         tui-data.h.
 322         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 323         * tui/tui-data.h (struct tui_data_item_window): Move to
 324         tui-regs.h.
 325         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 326
 327 2019-07-17  Tom Tromey  <tom@tromey.com>
 328
 329         * tui/tui.c: Update.
 330         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 331         (tui_cmd_window::max_height): Move to tui-command.c.
 332         * tui/tui-layout.c: Update.
 333         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 334         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 335         tui-command.c.
 336         * tui/tui-command.h (struct tui_cmd_window): Move from
 337         tui-data.h.
 338         * tui/tui-command.c: Remove "structuring" comments.
 339         (tui_cmd_window::clear_detail)
 340         (tui_cmd_window::do_make_visible_with_new_height)
 341         (tui_cmd_window::max_height): Move from elsewhere.
 342
 343 2019-07-17  Tom Tromey  <tom@tromey.com>
 344
 345         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 346         Now static.
 347         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 348         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 349
 350 2019-07-17  Tom Tromey  <tom@tromey.com>
 351
 352         * tui/tui.c: Update.
 353         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 354         tui-regs.c.
 355         * tui/tui-windata.h: Remove file.
 356         * tui/tui-windata.c: Remove file.
 357         * tui/tui-win.c (tui_data_window::set_new_height)
 358         (tui_data_window::do_make_visible_with_new_height): Move to
 359         tui-regs.c.
 360         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 361         * tui/tui-regs.c: Remove "structuring" comments.
 362         (tui_data_window::first_data_item_displayed)
 363         (tui_data_window::delete_data_content_windows)
 364         (tui_data_window::erase_data_content)
 365         (tui_data_window::display_all_data)
 366         (tui_data_window::refresh_all)
 367         (tui_data_window::do_scroll_vertical)
 368         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 369         (tui_data_window::do_make_visible_with_new_height)
 370         (tui_data_window::refresh_window): Move from elsewhere.
 371         (_initialize_tui_regs): Move to end of file.
 372         * tui/tui-layout.c: Update.
 373         * tui/tui-hooks.c: Update.
 374         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 375         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 376         tui-regs.c.
 377         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 378
 379 2019-07-17  Tom Tromey  <tom@tromey.com>
 380
 381         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 382         seen.
 383
 384 2019-07-17  Tom Tromey  <tom@tromey.com>
 385
 386         * tui/tui-win.c (tui_source_window_base::set_new_height)
 387         (tui_source_window_base::do_make_visible_with_new_height): Use
 388         m_has_locator field directly.
 389         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 390         method.
 391         (struct tui_source_window_base) <has_locator>: Likewise.
 392
 393 2019-07-17  Tom Tromey  <tom@tromey.com>
 394
 395         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 396         Don't declare.
 397         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 398         Remove.
 399         * tui/tui-win.c (tui_source_window_base::set_new_height)
 400         (tui_source_window_base::set_new_height)
 401         (make_invisible_and_set_new_height)
 402         (tui_source_window_base::do_make_visible_with_new_height)
 403         (tui_source_window_base::do_make_visible_with_new_height):
 404         Update.
 405         * tui/tui-layout.c (show_source_disasm_command, show_data)
 406         (show_source_or_disasm_and_command): Update.
 407         * tui/tui-layout.c (show_layout): Update.
 408
 409 2019-07-17  Tom Tromey  <tom@tromey.com>
 410
 411         * tui/tui-layout.c (make_data_window): Remove.
 412         (show_data): Unify creation and re-initialization cases.
 413
 414 2019-07-17  Tom Tromey  <tom@tromey.com>
 415
 416         * tui/tui-layout.c (make_source_window, make_disasm_window):
 417         Remove.
 418         (show_data): Unify creation and re-initialization cases.
 419
 420 2019-07-17  Tom Tromey  <tom@tromey.com>
 421
 422         * tui/tui-layout.c (make_command_window): Remove.
 423         (show_source_disasm_command, show_source_or_disasm_and_command):
 424         Unify creation and re-initialization cases.
 425
 426 2019-07-17  Tom Tromey  <tom@tromey.com>
 427
 428         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 429         creation and re-initialization cases.
 430
 431 2019-07-17  Tom Tromey  <tom@tromey.com>
 432
 433         * tui/tui-regs.c (tui_get_register): Return void.
 434
 435 2019-07-17  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 438         Simplify.
 439
 440 2019-07-17  Tom Tromey  <tom@tromey.com>
 441
 442         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 443         resetting.
 444
 445 2019-07-17  Tom Tromey  <tom@tromey.com>
 446
 447         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 448         * tui/tui-regs.c (tui_reg_layout): New function.
 449         (tui_show_registers, tui_reg_command): Use it.
 450         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 451         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 452         parameters.
 453         (tui_layout_command): Remove.
 454
 455 2019-07-17  Tom Tromey  <tom@tromey.com>
 456
 457         * tui/tui-layout.h (tui/tui-layout): Return void.
 458         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 459
 460 2019-07-17  Tom Tromey  <tom@tromey.com>
 461
 462         * tui/tui-layout.c (show_source_disasm_command, show_data):
 463         Update.
 464         (reset_locator): Remove.
 465         (show_source_or_disasm_and_command): Update.
 466
 467 2019-07-17  Tom Tromey  <tom@tromey.com>
 468
 469         * tui/tui-source.c (tui_source_window_base::reset): Remove
 470         win_type parameter.
 471         * tui/tui-layout.c (make_command_window, make_source_window)
 472         (make_disasm_window, make_data_window)
 473         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 474         (reset_locator, show_source_or_disasm_and_command): Update.
 475         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 476         win_type parameter.
 477         (struct tui_source_window_base) <reset>: Likewise.
 478
 479 2019-07-17  Tom Tromey  <tom@tromey.com>
 480
 481         * tui/tui-layout.c (show_source_disasm_command): Use
 482         reset_locator.
 483         (reset_locator): New function.
 484         (init_and_make_win): Remove.
 485         (show_source_or_disasm_and_command): Use reset_locator.
 486
 487 2019-07-17  Tom Tromey  <tom@tromey.com>
 488
 489         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 490         condition.
 491         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 492         Remove condition.
 493         * tui/tui-source.c (tui_source_window_base::reset): New method.
 494         * tui/tui-layout.c (make_command_window): Don't call
 495         init_and_make_win.
 496         (make_source_window, make_disasm_window): Don't call
 497         make_source_or_disasm_window.
 498         (make_data_window): Don't call init_and_make_win.  Change calling
 499         convention.
 500         (show_source_disasm_command, show_data): Simplify.
 501         (make_source_or_disasm_window): Remove.
 502         (show_source_or_disasm_and_command): Simplify.
 503         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 504         (struct tui_source_window_base) <reset>: Likewise.
 505         <execution_info>: Remove initializer.
 506         * tui/tui-data.c (tui_source_window_base): Initialize
 507         execution_info.
 508
 509 2019-07-17  Tom Tromey  <tom@tromey.com>
 510
 511         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 512         variable.
 513
 514 2019-07-17  Tom Tromey  <tom@tromey.com>
 515
 516         * tui/tui.c (tui_rl_other_window): Update.
 517         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 518         superclass method first.  Always iterate over regs_content.
 519         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 520         method.
 521         * tui/tui-win.c (tui_set_focus_command): Update.
 522
 523 2019-07-17  Tom Tromey  <tom@tromey.com>
 524
 525         * tui/tui-win.c (tui_set_focus_command): Rename from
 526         tui_set_focus.  Call tui_enable.
 527         (tui_set_focus_command): Remove.
 528
 529 2019-07-17  Tom Tromey  <tom@tromey.com>
 530
 531         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 532         refresh_window.
 533         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 534         touchwin.
 535         (tui_data_window::refresh_window): Call refresh_window on data
 536         items.  Always call superclass refresh_window.
 537         (tui_win_info::refresh): Remove.
 538         (tui_source_window_base::refresh_window): Update.
 539         (tui_refresh_all): Update.
 540         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 541         refresh_window.
 542         (show_source_or_disasm_and_command): Likewise.
 543         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 544         (struct tui_source_window_base) <refresh>: Likewise.
 545
 546 2019-07-17  Tom Tromey  <tom@tromey.com>
 547
 548         * tui/tui-winsource.c (tui_clear_source_content)
 549         (tui_show_source_content): Update.
 550         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 551         whether content is empty.
 552         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 553         Remove.
 554
 555 2019-07-17  Tom Tromey  <tom@tromey.com>
 556
 557         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 558         window's contents.
 559         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 560         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 561
 562 2019-07-17  Tom Tromey  <tom@tromey.com>
 563
 564         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 565         (struct tui_data_item_window): Update.
 566
 567 2019-07-17  Tom Tromey  <tom@tromey.com>
 568
 569         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 570         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 571         defines.
 572
 573 2019-07-17  Tom Tromey  <tom@tromey.com>
 574
 575         * tui/tui-winsource.h (tui_erase_source_content)
 576         (tui_clear_source_content): Remove "display_prompt" parameter.
 577         * tui/tui-winsource.c (tui_update_source_window_as_is)
 578         (tui_update_source_windows_with_addr): Update.
 579         (tui_clear_source_content): Remove "display_prompt" parameter.
 580         (tui_erase_source_content): Likewise.  Simplify.
 581         (tui_show_source_content): Update.
 582         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 583         * tui/tui-stack.c (tui_show_frame_info): Update.
 584         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 585         Remove defines.
 586
 587 2019-07-17  Tom Tromey  <tom@tromey.com>
 588
 589         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 590         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 591         parameter.
 592         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 593         parameter.
 594
 595 2019-07-17  Tom Tromey  <tom@tromey.com>
 596
 597         * tui/tui-winsource.c (tui_clear_source_content)
 598         (tui_show_source_content, tui_show_exec_info_content)
 599         (tui_clear_exec_info_content): Update.
 600         * tui/tui-stack.c (tui_show_locator_content): Update.
 601         (tui_show_frame_info): Update.
 602         * tui/tui-source.h (tui_source_window): Don't declare.
 603         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 604         from tui_source_is_displayed.
 605         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 606         Remove field.
 607         (struct tui_source_window_base) <content_in_use>: New field.  Now
 608         bool.
 609         (struct tui_source_window) <showing_source_p>: New method.
 610         (TUI_SRC_WIN): Change cast.
 611         * tui/tui-data.c (tui_initialize_static_data): Update.
 612
 613 2019-07-17  Tom Tromey  <tom@tromey.com>
 614
 615         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 616         location_matches_p.
 617         * tui/tui-source.c (tui_source_window::location_matches_p): New
 618         method.
 619         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 620         method.
 621         * tui/tui-data.h (struct tui_source_window_base)
 622         <location_matches_p>: New method.
 623         (struct tui_source_window, struct tui_disasm_window)
 624         <location_matches_p>: Likewise.
 625
 626 2019-07-17  Tom Tromey  <tom@tromey.com>
 627
 628         * tui/tui-win.c (tui_set_win_height_command): Rename from
 629         tui_set_win_height.
 630         (tui_set_win_height_command): Remove.
 631
 632 2019-07-17  Tom Tromey  <tom@tromey.com>
 633
 634         * tui/tui-source.c (tui_source_window): New constructor.  Add
 635         observer.
 636         (~tui_source_window): New destructor.
 637         (tui_source_window::style_changed): New method.
 638         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 639         (tui_attach_detach_observers): Update.
 640         * tui/tui-data.h (struct tui_source_window): Make constructor not
 641         inline.  Add destructor.
 642         (struct tui_source_window) <style_changed>: New method.
 643         <m_observable>: New member.
 644
 645 2019-07-17  Tom Tromey  <tom@tromey.com>
 646
 647         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 648         * tui/tui-win.c (tui_resize_all): Fix typo.
 649
 650 2019-07-17  Tom Tromey  <tom@tromey.com>
 651
 652         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 653         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 654         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 655         * tui/tui-win.c (window_name_completer): Use foreach.
 656         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 657         (update_tab_width): Likewise.
 658         * tui/tui-layout.c (show_layout): Update.
 659         * tui/tui-data.h (class tui_window_iterator): New.
 660         (struct all_tui_windows): New.
 661         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 662
 663 2019-07-17  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 666         parameter.  Don't reference globals.
 667         (tui_reg_command): Update.
 668
 669 2019-07-17  Tom Tromey  <tom@tromey.com>
 670
 671         * tui/tui-regs.c (tui_show_registers): Simplify.
 672
 673 2019-07-17  Tom Tromey  <tom@tromey.com>
 674
 675         * tui/tui-regs.c (tui_show_registers): Update.
 676         (tui_show_register_group): Add win_info parameter.
 677
 678 2019-07-17  Tom Tromey  <tom@tromey.com>
 679
 680         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 681         Rename from tui_display_reg_element_at_line.
 682         (tui_data_window::display_registers_from_line): Update.
 683         * tui/tui-data.h (struct tui_data_window)
 684         <display_reg_element_at_line>: New method.
 685
 686 2019-07-17  Tom Tromey  <tom@tromey.com>
 687
 688         * tui/tui-regs.h (tui_display_registers_from)
 689         (tui_display_registers_from_line): Don't declare.
 690         * tui/tui-windata.c (tui_data_window::display_all_data)
 691         (tui_data_window::refresh_all)
 692         (tui_data_window::do_scroll_vertical): Update.
 693         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 694         from tui_display_registers_from.
 695         (tui_display_reg_element_at_line): Update.
 696         (tui_data_window::display_registers_from_line): Rename from
 697         tui_display_registers_from_line.
 698         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 699         display_registers_from_line>: New methods.
 700
 701 2019-07-17  Tom Tromey  <tom@tromey.com>
 702
 703         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 704         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 705         from tui_erase_data_content.
 706         (tui_data_window::display_all_data)
 707         (tui_data_window::refresh_all)
 708         (tui_data_window::do_scroll_vertical): Update.
 709         * tui/tui-regs.c (tui_show_registers): Update.
 710         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 711         New method.
 712
 713 2019-07-17  Tom Tromey  <tom@tromey.com>
 714
 715         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 716         declare.
 717         * tui/tui-windata.c
 718         (tui_data_window::delete_data_content_windows): Rename from
 719         tui_delete_data_content_windows.
 720         (tui_data_window::display_all_data)
 721         (tui_data_window::do_scroll_vertical): Update.
 722         * tui/tui-data.h (struct tui_data_window)
 723         <delete_data_content_windows>: New method.
 724
 725 2019-07-17  Tom Tromey  <tom@tromey.com>
 726
 727         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 728         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 729
 730 2019-07-17  Tom Tromey  <tom@tromey.com>
 731
 732         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 733         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 734         from tui_display_all_data.
 735         * tui/tui-win.c
 736         (tui_data_window::do_make_visible_with_new_height): Update.
 737         * tui/tui-regs.c (tui_show_registers): Update.
 738         * tui/tui-layout.c (tui_set_layout): Update.
 739         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 740         method.
 741
 742 2019-07-17  Tom Tromey  <tom@tromey.com>
 743
 744         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 745         * tui/tui-windata.c (tui_display_data_from): Remove.
 746         (tui_data_window::refresh_all): Update.
 747
 748 2019-07-17  Tom Tromey  <tom@tromey.com>
 749
 750         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 751         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 752         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 753         tui_display_registers_from_line.
 754         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 755         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 756         "force_display" parameter.
 757
 758 2019-07-17  Tom Tromey  <tom@tromey.com>
 759
 760         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 761         declare.
 762         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 763         Rename from tui_first_reg_element_no_inline.
 764         (tui_display_reg_element_at_line)
 765         (tui_display_registers_from_line): Update.
 766         * tui/tui-data.h (struct tui_data_window)
 767         <first_reg_element_no_inline>: New method.
 768
 769 2019-07-17  Tom Tromey  <tom@tromey.com>
 770
 771         * tui/tui-windata.c (tui_display_data_from)
 772         (tui_data_window::do_scroll_vertical): Update.
 773         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 774         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 775         Rename from tui_line_from_reg_element_no.
 776         (tui_display_registers_from_line): Update.
 777         * tui/tui-data.h (struct tui_data_window)
 778         <line_from_reg_element_no>: New method.
 779
 780 2019-07-17  Tom Tromey  <tom@tromey.com>
 781
 782         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 783         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 784         tui_last_regs_line_no.
 785         (tui_display_reg_element_at_line)
 786         (tui_display_registers_from_line): Update.
 787         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 788         method.
 789
 790 2019-07-17  Tom Tromey  <tom@tromey.com>
 791
 792         PR tui/24722:
 793         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 794         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 795         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 796         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 797         (tui_update_breakpoint_info): Likewise.
 798         * tui/tui-hooks.c (tui_event_create_breakpoint)
 799         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 800         Update.
 801
 802 2019-07-17  Tom Tromey  <tom@tromey.com>
 803
 804         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 805
 806 2019-07-17  Tom Tromey  <tom@tromey.com>
 807
 808         * tui/tui-winsource.c (tui_update_source_window_as_is)
 809         (tui_update_source_windows_with_addr): Update.
 810         * tui/tui-source.h (tui_set_source_content)
 811         (tui_show_symtab_source): Add "win_info" parameter.
 812         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 813         parameter.
 814         (tui_show_symtab_source): Likewise.
 815
 816 2019-07-17  Tom Tromey  <tom@tromey.com>
 817
 818         * tui/tui-wingeneral.c
 819         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 820
 821 2019-07-17  Tom Tromey  <tom@tromey.com>
 822
 823         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 824         (struct tui_cmd_window) <can_scroll>: New method.
 825         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 826         method.
 827
 828 2019-07-17  Tom Tromey  <tromey@adacore.com>
 829
 830         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 831         do_field_signed>: Rename.  Change type of "value".
 832         * ui-out.c (ui_out::field_signed): Rename from field_int.
 833         Change type of "value".
 834         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 835         type of "value".
 836         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 837         do_field_int.  Change type of "value".
 838         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 839         do_field_int.  Change type of "value".
 840         * tracepoint.c (trace_status_mi, tfind_1)
 841         (print_one_static_tracepoint_marker): Update.
 842         * thread.c (print_thread_info_1, print_selected_thread_frame):
 843         Update.
 844         * stack.c (print_frame, print_frame_info): Update.
 845         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 846         Update.
 847         * source.c (print_source_lines_base): Update.
 848         * skip.c (info_skip_command): Update.
 849         * record-btrace.c (btrace_ui_out_decode_error)
 850         (btrace_call_history_src_line): Update.
 851         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 852         Update.
 853         * progspace.c (print_program_space): Update.
 854         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 855         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 856         do_field_int.  Change type of "value".
 857         * mi/mi-out.c (mi_ui_out::do_table_begin)
 858         (mi_ui_out::do_table_header): Update.
 859         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 860         type of "value".
 861         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 862         (mi_cmd_data_list_changed_registers, output_register)
 863         (mi_cmd_data_read_memory, mi_load_progress)
 864         (mi_cmd_trace_frame_collected): Update.
 865         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 866         Update.
 867         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 868         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 869         (mi_cmd_var_list_children, varobj_update_one): Update.
 870         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 871         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 872         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 873         * inferior.c (print_inferior): Update.
 874         * gdb_bfd.c (print_one_bfd): Update.
 875         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 876         Update.
 877         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 878         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 879         do_field_int.  Change type of "value".
 880         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 881         do_field_int.  Change type of "value".
 882         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 883         (print_one_breakpoint_location, print_it_catch_fork)
 884         (print_one_catch_fork, print_it_catch_vfork)
 885         (print_one_catch_vfork, print_it_catch_solib)
 886         (print_it_catch_exec, print_it_ranged_breakpoint)
 887         (print_mention_watchpoint, print_mention_masked_watchpoint)
 888         (bkpt_print_it, update_static_tracepoint): Update.
 889         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 890         * break-catch-syscall.c (print_it_catch_syscall): Update.
 891         * ada-tasks.c (print_ada_task_info): Update.
 892         * ada-lang.c (print_it_exception, print_mention_exception):
 893         Update.
 894
 895 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 896
 897         PR breakpoints/24541
 898         * gdbarch.c: Regenerate.
 899         * gdbarch.h: Regenerate.
 900         * gdbarch.sh: Adjust return type and parameter types for
 901         'stap_adjust_register'.
 902         (i386_stap_adjust_register): Adjust signature and return new
 903         register name.
 904         * stap-probe.c (stap_parse_register_operand): Adjust use of
 905         'gdbarch_stap_adjust_register'.
 906
 907 2019-07-17  Tom Tromey  <tromey@adacore.com>
 908
 909         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 910         declare VEC.
 911         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 912         std::vector.
 913         (struct s390_process_info): Add initializers.
 914         (s390_add_process): Use new.
 915         (s390_linux_nat_target::low_forget_process): Use delete.
 916         (s390_linux_nat_target::low_new_fork)
 917         (s390_linux_nat_target::stopped_by_watchpoint)
 918         (s390_linux_nat_target::low_prepare_to_resume)
 919         (s390_linux_nat_target::insert_watchpoint)
 920         (s390_linux_nat_target::insert_hw_breakpoint)
 921         (s390_linux_nat_target::remove_watchpoint)
 922         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 923
 924 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 925
 926         * aarch64-fbsd-nat.c: Include regcache.h.
 927         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 928         argument.
 929         (aarch64_fbsd_nat_target::fetch_registers)
 930         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 931         variable.
 932         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 933
 934 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 935
 936         * fbsd-nat.c: Include gdbarch.h.
 937
 938 2019-07-15  Tom Tromey  <tromey@adacore.com>
 939
 940         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 941
 942 2019-07-15  Tom Tromey  <tromey@adacore.com>
 943
 944         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 945         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 946         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 947         * cli-out.c (cli_ui_out::do_field_int): New method.
 948         * ui-out.c (ui_out::field_unsigned): New method.
 949         * symfile.c (generic_load): Use field_unsigned.
 950         (print_transfer_performance): Likewise.
 951         * record-btrace.c (ui_out_field_uint): Remove.
 952         (btrace_call_history_insn_range, btrace_call_history): Use
 953         field_unsigned.
 954         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 955         field_unsigned.
 956         * ui-out.h (class ui_out) <field_unsigned>: New method.
 957         <do_field_unsigned>: Likewise.
 958
 959 2019-07-15  Tom Tromey  <tromey@adacore.com>
 960
 961         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 962         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 963         * target.c (flash_erase_command): Use field_string.
 964         * infrun.c (print_signal_received_reason): Use field_string.
 965         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 966         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 967         field_string.
 968         * ada-tasks.c (print_ada_task_info): Use field_string.
 969
 970 2019-07-15  Tom Tromey  <tromey@adacore.com>
 971
 972         * target.c (flash_erase_command): Use field_core_addr.
 973         * symfile.c (generic_load): Use field_core_addr.
 974         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 975         Use field_core_addr.
 976         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 977         field_core_addr.
 978
 979 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 980
 981         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 982         value if its desired type is smaller than a CORE_ADDR and signed.
 983
 984 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 985
 986         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 987         of changes to field names, and use new is_reference field to
 988         decide if a property is a reference or not.
 989         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 990         field.
 991         (struct dwarf2_property_baton): Update header comment, rename
 992         'referenced_type' to 'property_type' and update comments.
 993         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 994         default property type, store in property baton, update to take
 995         accound of renamed field.
 996         (read_func_scope): Update call to attr_to_dynamic_prop.
 997         (read_array_type): Likewise.
 998         (dwarf2_per_cu_addr_sized_int_type): New function.
 999         (read_subrange_index_type): Move type finding code to
1000         dwarf2_per_cu_addr_sized_int_type.
1001         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1002         (dwarf2_per_cu_addr_type): New function.
1003         (set_die_type): Update calls to attr_to_dynamic_prop.
1004
1005 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1006
1007         * dwarf2read.c (read_subrange_index_type): New function.
1008         (read_subrange_type): Move code into new function and call it.
1009         * gdbtypes.c (create_range_type): Add some asserts.
1010
1011 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1012
1013         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1014         update return statements.
1015         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1016         declaration, and update comment to match.
1017         * gdbtypes.c (resolve_dynamic_array): Update call to
1018         dwarf2_evaluate_property to match new return type.
1019
1020 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1021
1022         * valarith.c (value_subscripted_rvalue): Change lowerbound
1023         parameter type from int to LONGEST.
1024         * value.h (value_subscripted_rvalue): Likewise in declaration.
1025
1026 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1027
1028         * cli/cli-utils.c (info_print_command_completer): New function.
1029         * cli/cli-utils.h: Add 'completer.h' include, and forward
1030         declaration for 'struct cmd_list_element'.
1031         (info_print_command_completer): Declare.
1032         * stack.c (_initialize_stack): Add completer for 'info locals' and
1033         'info args'.
1034         * symtab.c (_initialize_symtab): Add completer for 'info
1035         variables' and 'info functions'.
1036         * NEWS: Mention completion for additional info commands.
1037
1038 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1039
1040         * cli/cli-utils.c (extract_info_print_args): Delete.
1041         (extract_arg_maybe_quoted): Delete.
1042         (info_print_options_defs): New variable.
1043         (make_info_print_options_def_group): New function.
1044         (extract_info_print_options): Define new function.
1045         * cli/cli-utils.h (extract_info_print_args): Delete.
1046         (struct info_print_options): New structure.
1047         (extract_info_print_options): Declare new function.
1048         * stack.c (info_locals_command): Update to use new
1049         extract_info_print_options, also add a header comment.
1050         (info_args_command): Likewise.
1051         * symtab.c (info_variables_command): Likewise.
1052         (info_functions_command): Likewise.
1053
1054 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1055
1056         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1057         to extract string arguments.
1058         * common/common-utils.c (extract_string_maybe_quoted): New function.
1059         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1060
1061 2019-07-11  Tom Tromey  <tromey@adacore.com>
1062
1063         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1064         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1065         * top.h (gdbinit): Don't declare.
1066         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1067         into...
1068         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1069         * top.c (gdb_init): Don't call init_cli_cmds.
1070         (gdbinit): Remove.
1071         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1072
1073 2019-07-11  Tom Tromey  <tromey@adacore.com>
1074
1075         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1076         after it has been moved.
1077
1078 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1079
1080         * valops.c (value_must_coerce_to_target): Change return type to
1081         bool.
1082         * value.h (value_must_coerce_to_target): Likewise.
1083
1084 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1085
1086         * breakpoint.c (is_hardware_watchpoint): Remove
1087         forward-declaration.
1088         (is_masked_watchpoint): Change return type to bool.
1089         (is_tracepoint): Likewise.
1090         (is_breakpoint): Likewise.
1091         (is_hardware_watchpoint): Likewise.
1092         (is_watchpoint): Likewise.
1093         (is_no_memory_software_watchpoint): Likewise.
1094         (is_catchpoint): Likewise.
1095         (breakpoint_1): Make FILTER parameter's return type bool.
1096         is_masked_watchpoint): Change return type to bool.
1097         (save_breakpoints): Make FILTER parameter's return type bool.
1098         * breakpoint.h (is_breakpoint): Change return type to bool.
1099         (is_watchpoint): Likewise.
1100         (is_catchpoint): Likewise.
1101         (is_tracepoint): Likewise.
1102
1103 2019-07-10  Tom Tromey  <tom@tromey.com>
1104
1105         * defs.h: Don't include gdbarch.h.
1106         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1107         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1108         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1109         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1110         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1111         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1112         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1113         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1114         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1115         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1116         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1117         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1118         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1119         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1120         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1121         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1122         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1123         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1124         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1125         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1126         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1127         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1128         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1129         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1130         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1131         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1132         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1133
1134 2019-07-10  Tom Tromey  <tromey@adacore.com>
1135
1136         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1137         * breakpoint.c (init_ada_exception_breakpoint): Register as
1138         bp_catchpoint.
1139         (print_one_breakpoint_location, print_one_breakpoint): Use
1140         is_ada_exception_catchpoint.
1141         * ada-lang.c (class ada_catchpoint_location): Pass
1142         bp_loc_software_breakpoint to bp_location constructor.
1143         (is_ada_exception_catchpoint): New function.
1144
1145 2019-07-10  Tom Tromey  <tromey@adacore.com>
1146
1147         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1148         VEC.
1149         (struct arm_exidx_entry): New method operator<.
1150         (struct arm_exidx_data) <section_maps>: Change type.
1151         (arm_exidx_data_free): Remove.
1152         (arm_exidx_data_key): Change type.  Move lower.
1153         (arm_exidx_new_objfile): Update.
1154         (arm_compare_exidx_entries): Remove.
1155         (arm_find_exidx_entry, _initialize_arm_tdep)
1156
1157 2019-07-10  Tom Tromey  <tromey@adacore.com>
1158
1159         * solib-spu.c (ocl_program_data_key): Change type.
1160         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1161         Update.
1162
1163 2019-07-10  Tom Tromey  <tromey@adacore.com>
1164
1165         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1166         (struct solib_aix_inferior_data) <library_list>: Change type.
1167         (solib_aix_inferior_data_handle): Change type.
1168         (get_solib_aix_inferior_data): Update.
1169         (solib_aix_free_library_list): Remove.
1170         (library_list_start_library): Update.
1171         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1172         return type.
1173         (solib_aix_get_library_list)
1174         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1175         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1176
1177 2019-07-10  Tom Tromey  <tromey@adacore.com>
1178
1179         * solib-dsbt.c (struct dsbt_info): Add initializers.
1180         (solib_dsbt_pspace_data): Change type.
1181         (dsbt_pspace_data_cleanup): Remove.
1182         (get_dsbt_info, _initialize_dsbt_solib): Update.
1183
1184 2019-07-10  Tom Tromey  <tromey@adacore.com>
1185
1186         * spu-tdep.c (spu_overlay_data): Change type.
1187         (spu_get_overlay_table, spu_overlay_new_objfile)
1188         (_initialize_spu_tdep): Update.
1189
1190 2019-07-10  Tom Tromey  <tromey@adacore.com>
1191
1192         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1193         destructor.
1194         (dbx_objfile_data_key): Change type and declare later.
1195         (DBX_SYMFILE_INFO): Rewrite.
1196         * dbxread.c (dbx_objfile_data_key): Change type.
1197         (dbx_symfile_init): Update.
1198         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1199         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1200         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1201
1202 2019-07-10  Tom Tromey  <tromey@adacore.com>
1203
1204         * jit.c (jit_program_space_key): Change type.  Move lower.
1205         (get_jit_program_space_data): Update.
1206         (jit_program_space_data_cleanup): Remove.
1207         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1208         Update.
1209         (struct jit_program_space_data): Add initializers.
1210
1211 2019-07-10  Tom Tromey  <tromey@adacore.com>
1212
1213         * solib-darwin.c (struct darwin_info): Add initializers.
1214         (solib_darwin_pspace_data): Change type.
1215         (darwin_pspace_data_cleanup): Remove.
1216         (get_darwin_info, _initialize_darwin_solib): Update.
1217
1218 2019-07-10  Tom Tromey  <tromey@adacore.com>
1219
1220         * remote-sim.c (struct sim_inferior_data): Add initializers,
1221         constructor, and destructor.
1222         (sim_inferior_data_key): Change type.  Move lower.
1223         (check_for_duplicate_sim_descriptor): Update.
1224         (get_sim_inferior_data): Use new.  Update.
1225         (~sim_inferior_data_cleanup): Rename from
1226         sim_inferior_data_cleanup.  Simplify.
1227         (gdbsim_close_inferior, simulator_command)
1228         (sim_command_completer, _initialize_remote_sim): Update.
1229         (next_pid, INITIAL_PID): Move earlier.
1230
1231 2019-07-10  Tom Tromey  <tromey@adacore.com>
1232
1233         * python/python-internal.h (create_thread_object): Return
1234         gdbpy_ref.
1235         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1236         * python/py-inferior.c (struct threadlist_entry): Add
1237         constructor.
1238         <thread_obj>: Now a gdbpy_ref.
1239         (thread_to_thread_object): Update.
1240         (add_thread_object): Use new.
1241         (delete_thread_object): Use delete.
1242         (infpy_threads): Update.
1243         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1244         GIL.
1245
1246 2019-07-10  Tom Tromey  <tromey@adacore.com>
1247
1248         * valops.c (value_cast): Specialize error message for Ada.
1249
1250 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1251
1252         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1253
1254 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1255
1256         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1257         bpstat_should_step): Return bool, adjust comments.
1258         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1259         bpstat_should_step): Likewise.
1260
1261 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1262
1263         * features/Makefile: Use feature target descriptions for Arm.
1264         * features/arm/arm-core.c: Generate new file.
1265         * features/arm/arm-fpa.c: Likewise.
1266         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1267         * features/arm/arm-m-profile.c: Likewise.
1268         * features/arm/arm-vfpv2.c: Likewise.
1269         * features/arm/arm-vfpv3.c: Likewise.
1270         * features/arm/xscale-iwmmxt.c: Likewise.
1271         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1272
1273 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1274
1275         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1276         ptrace earlier.
1277
1278 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1279
1280         * features/aarch64-pauth.c: Regenerate.
1281
1282 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1283
1284         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1285         bool.
1286         (bpstat_what): Use false instead of 0.
1287
1288 2019-07-09  Pedro Alves  <palves@redhat.com>
1289
1290         * break-catch-throw.c (is_exception_catchpoint): New.
1291         * breakpoint.c (print_one_breakpoint_location): New parameter
1292         'raw_loc'.  Handle it.  Use
1293         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1294         looking at the breakpoint's type.
1295         (print_one_breakpoint): If handling "maint info breakpoints", also
1296         print locations of exception catchpoints.
1297         * breakpoint.h (is_exception_catchpoint): Declare.
1298
1299 2019-07-09  Pedro Alves  <palves@redhat.com>
1300
1301         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1302         "addr" field.
1303         (allocate_location_exception_catchpoint): New.
1304         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1305         (initialize_throw_catchpoint_ops): Install
1306         allocate_location_exception_catchpoint as allocate_location
1307         method.
1308         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1309         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1310         bp_loc_other.
1311         (breakpoint_address_is_meaningful): Delete.
1312         (bl_address_is_meaningful): New.
1313         (breakpoint_locations_match): Adjust comment.
1314         (bp_location_from_bp_type): New, factored out of...
1315         (bp_location::bp_location(breakpoint *)): ... this.
1316         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1317         factored out of...
1318         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1319         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1320         breakpoint_address_is_meaningful.
1321         (bp_locations_compare): Adjust comment.
1322         (update_global_location_list): Use bl_address_is_meaningful
1323         instead of breakpoint_address_is_meaningful.
1324         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1325         explicit.
1326         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1327         * python/py-breakpoint.c (bppy_get_location): No longer check
1328         whether location is null.
1329
1330 2019-07-09  Pedro Alves  <palves@redhat.com>
1331
1332         PR c++/15468
1333         * breakpoint.c (print_one_breakpoint_location): Remove
1334         single-location assert.
1335
1336 2019-07-09  Tom Tromey  <tom@tromey.com>
1337
1338         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1339         * configure: Rebuild.
1340         * configure.ac: Change common to gdbsupport.
1341         * gdbsupport: Rename from common.
1342         * acinclude.m4: Change common to gdbsupport.
1343         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1344         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1345         gdbsupport.
1346         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1347         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1348         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1349         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1350         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1351         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1352         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1353         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1354         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1355         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1356         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1357         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1358         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1359         coff-pe-read.c, command.h, compile/compile-c-support.c,
1360         compile/compile-c.h, compile/compile-cplus-symbols.c,
1361         compile/compile-cplus-types.c, compile/compile-cplus.h,
1362         compile/compile-loc2c.c, compile/compile.c, completer.c,
1363         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1364         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1365         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1366         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1367         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1368         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1369         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1370         features/aarch64-core.c, features/aarch64-fpu.c,
1371         features/aarch64-pauth.c, features/aarch64-sve.c,
1372         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1373         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1374         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1375         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1376         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1377         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1378         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1379         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1380         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1381         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1382         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1383         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1384         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1385         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1386         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1387         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1388         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1389         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1390         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1391         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1392         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1393         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1394         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1395         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1396         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1397         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1398         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1399         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1400         minsyms.c, mips-linux-tdep.c, namespace.h,
1401         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1402         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1403         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1404         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1405         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1406         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1407         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1408         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1409         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1410         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1411         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1412         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1413         procfs.c, producer.c, progspace.h, psymtab.h,
1414         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1415         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1416         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1417         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1418         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1419         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1420         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1421         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1422         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1423         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1424         target-memory.c, target.c, target.h, target/waitstatus.c,
1425         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1426         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1427         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1428         unittests/array-view-selftests.c,
1429         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1430         unittests/common-utils-selftests.c,
1431         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1432         unittests/format_pieces-selftests.c,
1433         unittests/function-view-selftests.c,
1434         unittests/lookup_name_info-selftests.c,
1435         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1436         unittests/mkdir-recursive-selftests.c,
1437         unittests/observable-selftests.c,
1438         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1439         unittests/parse-connection-spec-selftests.c,
1440         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1441         unittests/scoped_fd-selftests.c,
1442         unittests/scoped_mmap-selftests.c,
1443         unittests/scoped_restore-selftests.c,
1444         unittests/string_view-selftests.c, unittests/style-selftests.c,
1445         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1446         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1447         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1448         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1449         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1450         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1451
1452 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1453
1454         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1455         bool value.
1456         (decode_digits_ordinary): Set explicit_line field in sal.
1457         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1458         symtab_and_line that was set on an explicit line number in
1459         assembler code.  Do always update the recorded symtab and line if
1460         we do skip the prologue.
1461
1462 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1463
1464         * breakpoint.c (set_breakpoint_location_function): Remove
1465         explicit_loc parameter.
1466         (momentary_breakpoint_from_master): Update call to
1467         set_breakpoint_location_function.
1468         (add_location_to_breakpoint): Likewise.
1469
1470 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1471
1472         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1473         required features based on default bfd type when no specific bfd
1474         is present.
1475
1476 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1477
1478         * NEWS: Mention that GDB printf and eval commands can now print
1479         C-style and Ada-style convenience var strings without
1480         calling the inferior.
1481         * printcmd.c (printf_c_string): Locally print GDB internal var
1482         instead of transiting via the inferior.
1483         (printf_wide_c_string): Likewise.
1484
1485 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1486
1487         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1488
1489 2019-07-04  Tom Tromey  <tom@tromey.com>
1490
1491         PR tui/24724:
1492         * tui/tui-winsource.c (tui_clear_source_content): Update.
1493         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1494         (tui_update_breakpoint_info): Update.
1495         (tui_set_exec_info_content): Update.
1496         * tui/tui-source.c (tui_set_source_content_nil): Update.
1497         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1498         has_break.
1499         * tui/tui-data.h (enum tui_bp_flag): New.
1500         (tui_bp_flags): New enum flags type.
1501         (struct tui_source_element) <break_mode>: Change type.  Rename
1502         from has_break.
1503         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1504         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1505         constants.
1506         * tui/tui-winsource.h: Fix comment.
1507
1508 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1509
1510         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1511         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1512         (store_fpregs_to_thread)
1513         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1514         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1515         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1516         (IWMMXT_REGS_SIZE): Add define.
1517         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1518         (fetch_vfp_regs, store_vfp_regs)
1519         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1520         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1521
1522 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1523
1524         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1525         defines.
1526         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1527         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1528         (ARM_INT_REGISTER_SIZE): ...to this.
1529         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1530         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1531         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1532         (arm_linux_collect_gregset, supply_nwfpe_register)
1533         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1534         defines.
1535         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1536         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1537         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1538         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1539         (arm_return_in_memory, arm_store_return_value)
1540         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1541         (arm_record_ld_st_multiple): Likewise.
1542         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1543         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1544
1545 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1546
1547         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1548         AARCH64_DISPLACED_MODIFIED_INSNS.
1549         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1550         (aarch64_displaced_step_copy_insn): Likewise.
1551         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1552         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1553         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1554         ARM_DISPLACED_MODIFIED_INSNS.
1555         * arm-tdep.c (arm_gdbarch_init): Likewise.
1556         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1557         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1558         (struct arm_displaced_step_closure): Use
1559         ARM_DISPLACED_MODIFIED_INSNS.
1560
1561 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1562
1563         * features/Makefile: Remove unused xml files.
1564         * features/aarch64.xml: Remove.
1565         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1566         * features/i386/amd64-avx-avx512.xml: Remove.
1567         * features/i386/amd64-avx-linux.xml: Remove.
1568         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1569         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1570         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1571         * features/i386/amd64-avx-mpx.xml: Remove.
1572         * features/i386/amd64-avx.xml: Remove.
1573         * features/i386/amd64-linux.xml: Remove.
1574         * features/i386/amd64-mpx-linux.xml: Remove.
1575         * features/i386/amd64-mpx.xml: Remove.
1576         * features/i386/amd64.xml: Remove.
1577         * features/i386/i386-avx-avx512-linux.xml: Remove.
1578         * features/i386/i386-avx-avx512.xml: Remove.
1579         * features/i386/i386-avx-linux.xml: Remove.
1580         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1581         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1582         * features/i386/i386-avx-mpx-linux.xml: Remove.
1583         * features/i386/i386-avx-mpx.xml: Remove.
1584         * features/i386/i386-avx.xml: Remove.
1585         * features/i386/i386-linux.xml: Remove.
1586         * features/i386/i386-mmx-linux.xml: Remove.
1587         * features/i386/i386-mmx.xml: Remove.
1588         * features/i386/i386-mpx-linux.xml: Remove.
1589         * features/i386/i386-mpx.xml: Remove.
1590         * features/i386/i386.xml: Remove.
1591         * features/i386/x32-avx-avx512-linux.xml: Remove.
1592         * features/i386/x32-avx-linux.xml: Remove.
1593         * features/i386/x32-linux.xml: Remove.
1594
1595 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1596
1597         * regformats/aarch64.dat: Remove.
1598         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1599         * regformats/i386/amd64-avx-linux.dat: Remove.
1600         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1601         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1602         * regformats/i386/amd64-linux.dat: Remove.
1603         * regformats/i386/amd64-mpx-linux.dat: Remove.
1604         * regformats/i386/amd64.dat: Remove.
1605         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1606         * regformats/i386/i386-avx-linux.dat: Remove.
1607         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1608         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1609         * regformats/i386/i386-linux.dat: Remove.
1610         * regformats/i386/i386-mmx-linux.dat: Remove.
1611         * regformats/i386/i386-mpx-linux.dat: Remove.
1612         * regformats/i386/i386.dat: Remove.
1613         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1614         * regformats/i386/x32-avx-linux.dat: Remove.
1615         * regformats/i386/x32-linux.dat: Remove.
1616
1617 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1618
1619         * aarch64-tdep.c: Remove xml self tests.
1620         * amd64-linux-tdep.c: Likewise.
1621         * amd64-tdep.c: Likewise.
1622         * i386-linux-tdep.c: Likewise.
1623         * i386-tdep.c: Likewise.
1624
1625 2019-07-03  Pedro Alves  <palves@redhat.com>
1626
1627         PR cli/24732
1628         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1629         (pipe_cmd_option_defs): New.
1630         (make_pipe_cmd_options_def_group): New.
1631         (pipe_command): Use gdb::option::process_options.
1632         (pipe_command_completer): New function.
1633         (_initialize_cli_cmds): Install completer for "pipe" command.
1634
1635 2019-07-03  Pedro Alves  <palves@redhat.com>
1636
1637         * cli/cli-option.c (union option_value) <string>: New field.
1638         (struct option_def_and_value): Add ctor, move ctor, dtor and
1639         use DISABLE_COPY_AND_ASSIGN.
1640         (option_def_and_value::clear_value): New.
1641         (parse_option, save_option_value_in_ctx, get_val_type_str)
1642         (add_setshow_cmds_for_options): Handle var_string.
1643         * cli-option.h (union option_def::var_address) <string>: New
1644         field.
1645         (struct string_option_def): New.
1646         * maint-test-options.c (struct test_options_opts): Add default
1647         ctor and use DISABLE_COPY_AND_ASSIGN.
1648         <string_opt>: New field.
1649         (test_options_opts::~test_options_opts): New.
1650         (test_options_opts::dump): Also dump "-string".
1651         (test_options_option_defs): Install "string.
1652
1653 2019-07-03  Pedro Alves  <palves@redhat.com>
1654
1655         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1656         option_value with a null enumeration.
1657         (complete_options): Save the option values in the context.
1658         (save_option_value_in_ctx): New, factored out from ...
1659         (process_options): ... here.
1660         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1661         of the function.
1662         * maint-test-options.c (test_options_opts::dump): New, factored
1663         out from ...
1664         (maintenance_test_options_command_mode): ... here.
1665         (maintenance_test_options_command_completion_result): Delete.
1666         (maintenance_test_options_command_completion_text): Update
1667         comment.
1668         (maintenance_show_test_options_completion_result): Change
1669         prototype.  Just print
1670         maintenance_test_options_command_completion_text.
1671         (save_completion_result): New.
1672         (maintenance_test_options_completer_mode): Pass options context to
1673         complete_options, and then save a dump.
1674         (_initialize_maint_test_options): Use add_cmd to install "maint
1675         show test-options-completion-result".
1676
1677 2019-07-03  Pedro Alves  <palves@redhat.com>
1678
1679         * NEWS (New commands): Mention "with" and "maint with".
1680         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1681         (with_command, with_command_completer): New.
1682         (pipe_command): Adjust to new repeat_previous
1683         interface.
1684         (_initialize_cli_cmds): Install the "with" command and its "w"
1685         alias.
1686         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1687         declarations.
1688         * cli/cli-setshow.c (parse_cli_var_uinteger)
1689         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1690         argument strings for all var_types.
1691         (get_setshow_command_value_string): New, factored out from ...
1692         (do_show_command): ... this.
1693         * cli/cli-setshow.h: Include <string>.
1694         (get_setshow_command_value_string): Declare.
1695         * command.h (repeat_previous): Now returns const char *.  Adjust
1696         comment.
1697         * maint.c: Include "cli/cli-cmds.h".
1698         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1699         (_initialize_maint_cmds): Register the "maintenance with" command.
1700         * top.c (repeat_previous): Move bits from pipe_command here:
1701         Return the saved command line, if any; error out if there's no
1702         command to relaunch.
1703
1704 2019-07-03  Pedro Alves  <palves@redhat.com>
1705
1706         * NEWS (New commands): Mention "maint set/show test-settings"
1707         instead of "maint test-settings".
1708         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1709         (maintenance_test_settings_set_list): Rename to ...
1710         (maintenance_set_test_settings_list): ... this.
1711         (maintenance_test_settings_show_list): Rename to  ...
1712         (maintenance_show_test_settings_list): ... this.
1713         (maintenance_test_settings_cmd): Delete.
1714         (maintenance_test_settings_set_cmd): ...
1715         (maintenance_set_test_settings_cmd): ... this.
1716         (maintenance_test_settings_show_cmd): ...
1717         (maintenance_show_test_settings_cmd): ... this.
1718         (maintenance_test_settings_show_value_cmd):
1719         (maintenance_show_test_settings_value_cmd): ... this.
1720         (_initialize_maint_test_settings): No longer install the "maint
1721         test-settings" prefix command.  Rename "maint test-settings set"
1722         to "maint set test-settings", and "maint test-settings show" to
1723         "maint show test-settings".  Adjust all subcommands.
1724
1725 2019-07-03  Pedro Alves  <palves@redhat.com>
1726
1727         * maint-test-settings.c: Fix file's intro comment.  Replace all
1728         references to "test-options" with references to "test-settings",
1729         in comments.
1730
1731 2019-07-03  Pedro Alves  <palves@redhat.com>
1732
1733         * maint-test-settings.c (maintenance_test_settings_xxx)
1734         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1735         New.
1736         (maintenance_test_settings_enums): Use them.
1737         (maintenance_test_settings_enum): Default to
1738         maintenance_test_settings_xxx.
1739         (_initialize_maint_test_settings): Initialize
1740         MAINTENANCE_TEST_SETTINGS_FILENAME.
1741
1742 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1743
1744         * breakpoint.h (remove_breakpoints_inf): Change return type to
1745         void, move function documentation here.
1746         * breakpoint.c (remove_breakpoints_inf): Change return type to
1747         void, move function documentation to header.
1748
1749 2019-07-02  Pedro Alves  <palves@redhat.com>
1750
1751         * NEWS (Completion improvements): Mention "info threads".
1752         * thread.c (struct info_threads_opts, info_threads_option_defs)
1753         (make_info_threads_options_def_group): New.
1754         (info_threads_command): Use gdb::option::process_options.
1755         (info_threads_command_completer): New.
1756         (_initialize_thread): Use gdb::option::build_help to build the
1757         help text for "info threads".
1758
1759 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1760
1761         * defs.h (generic_load): Move from here...
1762         * symfile.h (generic_load): ... to here.  Rename name parameter
1763         to args.
1764         * symfile.c (generic_load): Add comment.
1765
1766 2019-07-01  Tom Tromey  <tromey@adacore.com>
1767
1768         * dwarf2read.c
1769         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1770         declaration of without_params.  Fix formatting.
1771
1772 2019-07-01  Tom Tromey  <tromey@adacore.com>
1773
1774         * ada-exp.y (find_primitive_type): Update.
1775         * ada-lang.h (ada_lookup_symbol): Update.
1776         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1777         parameter.
1778         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1779
1780 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1781
1782         PR breakpoints/24541
1783         * gdbarch.c: Regenerate.
1784         * gdbarch.h: Regenerate.
1785         * gdbarch.sh: Add 'stap_adjust_register'.
1786         * i386-tdep.c: Include '<unordered_set>'.
1787         (i386_stap_adjust_register): New function.
1788         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1789         * stap-probe.c (stap_parse_register_operand): Call
1790         'gdbarch_stap_adjust_register'.
1791
1792 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1793
1794         PR python/24742
1795         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1796         * python/python.c (do_start_initialization): Use 'xmalloc'
1797         instead of 'PyMem_Malloc'.
1798
1799 2019-06-28  Tom Tromey  <tromey@adacore.com>
1800
1801         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1802         for Ada.
1803
1804 2019-06-27  Tom Tromey  <tromey@adacore.com>
1805
1806         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1807         objfile_key.
1808         (arm_find_mapping_symbol, arm_record_special_symbol)
1809         (_initialize_arm_tdep): Update.
1810         (arm_objfile_data_free): Remove.
1811
1812 2019-06-27  Tom Tromey  <tromey@adacore.com>
1813
1814         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1815         to cp_print_static_field.
1816
1817 2019-06-26  Tom Tromey  <tromey@adacore.com>
1818
1819         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1820         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1821         declare.
1822
1823 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1824
1825         * features/aarch64-core.c (create_feature_aarch64_core):
1826         Regenerate.
1827         * features/aarch64-core.xml: Add cpsr flags.
1828
1829 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1830
1831         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1832         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1833
1834 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1835
1836         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1837         field.
1838         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1839         use.
1840         (arm_record_special_symbol): Don't insert new symbol in sorted
1841         position, push it at the end.
1842
1843 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1844
1845         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1846         (arm_mapping_symbol_s): Remove.
1847         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1848         (arm_mapping_symbol_vec): New typedef.
1849         (struct arm_per_objfile): Add constructor.
1850         <section_maps>: Change type to
1851         std::unique_ptr<arm_mapping_symbol_vec[]>.
1852         (arm_compare_mapping_symbols): Remove.
1853         (arm_find_mapping_symbol): Adjust to section_maps type change.
1854         (arm_objfile_data_free): Call delete on arm_per_objfile.
1855         (arm_record_special_symbol): Adjust to section_maps type change.
1856         Allocate arm_per_objfile with new.
1857
1858 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1859
1860         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1861         with the command prefix.
1862
1863 2019-06-25  Tom Tromey  <tom@tromey.com>
1864
1865         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1866         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1867
1868 2019-06-25  Tom Tromey  <tom@tromey.com>
1869
1870         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1871         type.
1872         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1873         protected.
1874
1875 2019-06-25  Tom Tromey  <tom@tromey.com>
1876
1877         * tui/tui-winsource.c
1878         (tui_source_window_base::set_is_exec_point_at): Add check against
1879         LOA_ADDRESS.
1880
1881 2019-06-25  Tom Tromey  <tom@tromey.com>
1882
1883         * tui/tui-source.c (tui_set_source_content): Don't check before
1884         xfree.
1885         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1886
1887 2019-06-25  Tom Tromey  <tom@tromey.com>
1888
1889         * tui/tui-winsource.h (tui_update_source_window_as_is)
1890         (tui_alloc_source_buffer, tui_line_is_displayed)
1891         (tui_addr_is_displayed): Change type of win_info.
1892         * tui/tui-winsource.c (tui_update_source_window_as_is)
1893         (tui_clear_source_content, tui_show_source_line)
1894         (tui_show_source_content, tui_source_window_base::refill)
1895         (tui_source_window_base::set_is_exec_point_at)
1896         (tui_source_window_base::set_is_exec_point_at)
1897         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1898         (tui_alloc_source_buffer, tui_line_is_displayed)
1899         (tui_addr_is_displayed): Change type of win_info.  Update.
1900         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1901         (tui_source_window_base::do_make_visible_with_new_height):
1902         Update.
1903         * tui/tui-source.c (tui_set_source_content)
1904         (tui_set_source_content_nil)
1905         (tui_source_window::do_scroll_vertical): Update.
1906         * tui/tui-layout.c (show_layout): Update.
1907         * tui/tui-disasm.c (tui_set_disassem_content)
1908         (tui_disasm_window::do_scroll_vertical): Update.
1909         * tui/tui-data.h (tui_win_content): Remove.
1910         (struct tui_gen_win_info) <content, content_size>: Remove.
1911         (struct tui_source_element): Add initializers and destructor.
1912         (union tui_which_element, struct tui_win_element): Remove.
1913         (struct tui_source_window_base) <content>: New field.
1914         (struct tui_data_window): Remove destructor.
1915         (tui_alloc_content, tui_free_win_content)
1916         (tui_free_all_source_wins_content): Don't declare.
1917         * tui/tui-data.c (tui_initialize_static_data): Update.
1918         (init_content_element, tui_alloc_content): Remove.
1919         (~tui_gen_win_info): Update.
1920         (~tui_data_window, tui_free_all_source_wins_content)
1921         (tui_free_win_content, free_content, free_content_elements):
1922         Remove.
1923
1924 2019-06-25  Tom Tromey  <tom@tromey.com>
1925
1926         * tui/tui-winsource.h (tui_clear_source_content)
1927         (tui_erase_source_content, tui_show_source_content): Change type
1928         of win_info.
1929         * tui/tui-winsource.c (tui_clear_source_content)
1930         (tui_erase_source_content, tui_show_source_content): Change type
1931         of win_info.
1932         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1933         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1934         win_info.
1935         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1936         win_info.
1937         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1938
1939 2019-06-25  Tom Tromey  <tom@tromey.com>
1940
1941         * tui/tui-winsource.c (tui_clear_source_content)
1942         (tui_source_window_base::set_is_exec_point_at): Update.
1943         * tui/tui-source.c (tui_set_source_content_nil): Update.
1944         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1945         a bool.
1946         * tui/tui-data.c (init_content_element): Update.
1947
1948 2019-06-25  Tom Tromey  <tom@tromey.com>
1949
1950         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1951         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1952         * tui/tui-layout.c (init_and_make_win): Update.
1953         * tui/tui.h (enum tui_win_type): Update.
1954         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1955         tui_win_is_auxillary.
1956         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1957         tui_win_is_auxillary.
1958
1959 2019-06-25  Tom Tromey  <tom@tromey.com>
1960
1961         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1962         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1963         (tui_delete_data_content_windows, tui_display_all_data)
1964         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1965         Update.
1966         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1967         * tui/tui-regs.c (tui_last_regs_line_no)
1968         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1969         (tui_show_registers): Update.
1970         (tui_show_register_group): Return void.  Update.
1971         (tui_display_registers_from, tui_display_reg_element_at_line)
1972         (tui_display_registers_from_line, tui_check_register_values):
1973         Update.
1974         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1975         member.
1976         (struct tui_data_window) <regs_content>: Now a std::vector.
1977         <regs_content_count>: Remove.
1978         (tui_add_content_elements, tui_free_data_content): Don't declare.
1979         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1980         (init_content_element): Remove DATA_WIN case.  Add assert.
1981         (tui_add_content_elements): Remove.
1982         (tui_data_window): Update.
1983         (tui_free_data_content): Remove.
1984         (free_content_elements): Remove DATA_WIN case.
1985
1986 2019-06-25  Tom Tromey  <tom@tromey.com>
1987
1988         * tui/tui-data.c (tui_data_item_window): Update.
1989         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1990         * tui/tui-windata.c (tui_display_all_data)
1991         (tui_display_data_from_line): Update.
1992         (tui_check_data_values): Remove.
1993         * tui/tui-regs.c (tui_show_register_group)
1994         (tui_display_reg_element_at_line): Update.
1995         * tui/tui-hooks.c (tui_register_changed)
1996         (tui_refresh_frame_and_register_information): Call
1997         tui_check_register_values.
1998         * tui/tui-data.h (struct tui_data_window) <data_content,
1999         data_content_count, data_type>: Remove.
2000         (enum tui_data_type): Remove.
2001
2002         * tui/tui-data.c (tui_data_window::clear_detail)
2003         (~tui_data_window): Update.
2004
2005 2019-06-25  Tom Tromey  <tom@tromey.com>
2006
2007         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2008         declare.
2009         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2010         Rename from tui_first_data_item_displayed.  Update.
2011         (tui_data_window::refresh_all)
2012         (tui_data_window::do_scroll_vertical): Update.
2013         * tui/tui-data.h (struct tui_data_window)
2014         <first_data_item_displayed>: Declare new method.
2015
2016 2019-06-25  Tom Tromey  <tom@tromey.com>
2017
2018         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2019         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2020         contents...
2021         (tui_initialize_static_data): ...here.
2022
2023 2019-06-25  Tom Tromey  <tom@tromey.com>
2024
2025         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2026         (tui_display_registers_from, tui_check_register_values): Update.
2027         (tui_display_register): Remove win_info parameter; update.
2028         (tui_get_register): Change type of parameters.
2029         * tui/tui-data.h (struct tui_data_element): Remove.
2030         (union tui_which_element) <data>: Remove.
2031         <data_window>: Change type.
2032         (struct tui_data_item_window): New.
2033         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2034         case.  Add assert.
2035         (~tui_data_item_window): New destructor.
2036         (free_content_elements): Remove DATA_ITEM_WIN case.
2037
2038 2019-06-25  Tom Tromey  <tom@tromey.com>
2039
2040         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2041         Remove.
2042
2043 2019-06-25  Tom Tromey  <tom@tromey.com>
2044
2045         * tui/tui-data.h (struct tui_command_element): Remove.
2046         (union tui_which_element) <command>: Remove.
2047         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2048         assert.
2049         (free_content_elements): Remove CMD_WIN case.
2050
2051 2019-06-25  Tom Tromey  <tom@tromey.com>
2052
2053         * tui/tui-layout.c (tui_set_layout): Update.
2054         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2055         * tui/tui-data.c (layout_def): Update.
2056
2057 2019-06-25  Tom Tromey  <tom@tromey.com>
2058
2059         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2060         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2061         (tui_source_window_base::set_new_height): Update.
2062         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2063         Update.
2064         (tui_set_locator_fullname, tui_set_locator_info)
2065         (tui_show_frame_info): Update.
2066         * tui/tui-source.c (tui_set_source_content)
2067         (tui_source_is_displayed): Update.
2068         * tui/tui-layout.c (show_source_disasm_command, show_data)
2069         (show_source_or_disasm_and_command): Update.
2070         * tui/tui-disasm.c (tui_set_disassem_content)
2071         (tui_get_begin_asm_address): Update.
2072         * tui/tui-data.h (struct tui_locator_element): Remove.
2073         (union tui_which_element) <locator>: Remove.
2074         (struct tui_locator_window): New.
2075         (tui_locator_win_info_ptr): Change return type.
2076         * tui/tui-data.c (_locator): Change type.
2077         (tui_locator_win_info_ptr): Change return type.
2078         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2079         (tui_alloc_content): Add assert.
2080
2081 2019-06-25  Tom Tromey  <tom@tromey.com>
2082
2083         * tui/tui-winsource.c
2084         (tui_exec_info_window::maybe_allocate_content): New method.
2085         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2086         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2087         (make_source_or_disasm_window): Add cast.
2088         * tui/tui-data.h (union tui_which_element) <simple_string>:
2089         Remove.
2090         (struct tui_source_info): New.
2091         (struct tui_source_window_base) <execution_info>: Change type.
2092         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2093         case, and add assert.
2094         (tui_alloc_content): Add assert.
2095
2096 2019-06-25  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2099         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2100         * tui/tui-data.c (tui_alloc_win_info): Remove.
2101
2102 2019-06-25  Tom Tromey  <tom@tromey.com>
2103
2104         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2105         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2106         can_highlight.
2107
2108 2019-06-25  Tom Tromey  <tom@tromey.com>
2109
2110         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2111         make_visible_with_new_height method.
2112         (tui_win_info::make_visible_with_new_height): New method.
2113         (tui_source_window_base::do_make_visible_with_new_height)
2114         (tui_data_window::do_make_visible_with_new_height)
2115         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2116         (make_visible_with_new_height): Remove.
2117         (tui_resize_all, tui_adjust_win_heights): Use
2118         make_visible_with_new_height method.
2119         * tui/tui-data.h (struct tui_win_info)
2120         <do_make_visible_with_new_height, make_visible_with_new_height>:
2121         New methods.
2122         (struct tui_source_window_base, struct tui_data_window)
2123         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2124         methods.
2125
2126 2019-06-25  Tom Tromey  <tom@tromey.com>
2127
2128         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2129         method.
2130         (update_tab_width): Call update_tab_width method.
2131         * tui/tui-data.h (struct tui_win_info)
2132         (struct tui_source_window_base) <update_tab_width>: New methods.
2133
2134 2019-06-25  Tom Tromey  <tom@tromey.com>
2135
2136         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2137         parameter.
2138         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2139         parameter.
2140         (tui_gen_win_info::make_visible): Update.
2141         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2142         parameter.
2143         * tui/tui-data.h (enum tui_box): New enum.
2144         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2145
2146 2019-06-25  Tom Tromey  <tom@tromey.com>
2147
2148         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2149         init_and_make_win for EXEC_INFO_WIN.
2150         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2151         longer inline.
2152         (struct tui_win_info) <~tui_win_info>: Inline.
2153         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2154         Don't declare.
2155         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2156         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2157         Remove.
2158         (tui_initialize_static_data): Update.
2159         (~tui_gen_win_info): Handle more cleanup here.
2160         (~tui_source_window_base): Delete "execution_info".
2161         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2162
2163 2019-06-25  Tom Tromey  <tom@tromey.com>
2164
2165         * tui/tui-layout.c (make_command_window): Don't set
2166         can_highlight.
2167         (show_source_disasm_command): Call the reset method.
2168         (show_data): Don't set can_highlight.  Call the reset method.
2169         (tui_gen_win_info::reset): Rename from init_gen_win_info
2170         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2171         (show_source_or_disasm_and_command): Call the reset method.
2172         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2173         (struct tui_cmd_window): Set can_highlight.
2174
2175 2019-06-25  Tom Tromey  <tom@tromey.com>
2176
2177         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2178         from make_visible.
2179         (tui_make_visible, tui_make_invisible): Rewrite.
2180         (tui_win_info::make_visible): Remove.
2181         (tui_source_window_base::make_visible): Update.
2182         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2183         method.  Moved from...
2184         (struct tui_win_info) <make_visible>: ...here.
2185
2186 2019-06-25  Tom Tromey  <tom@tromey.com>
2187
2188         * tui/tui-winsource.c
2189         (tui_source_window_base::do_scroll_horizontal): Remove direction
2190         parameter.
2191         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2192         direction parameter.
2193         * tui/tui-win.c (tui_win_info::forward_scroll)
2194         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2195         (tui_win_info::right_scroll): Update.
2196         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2197         direction parameter.
2198         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2199         direction parameter.
2200         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2201         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2202         Remove direction parameter.
2203         (struct tui_source_window_base, struct tui_source_window)
2204         (struct tui_disasm_window, struct tui_data_window)
2205         (struct tui_cmd_window): Update.
2206
2207 2019-06-25  Tom Tromey  <tom@tromey.com>
2208
2209         * tui/tui-winsource.h (tui_set_exec_info_content)
2210         (tui_show_exec_info_content, tui_erase_exec_info_content)
2211         (tui_clear_exec_info_content, tui_update_exec_info): Change
2212         argument to tui_source_window_base.
2213         * tui/tui-winsource.c (tui_set_exec_info_content)
2214         (tui_show_exec_info_content, tui_erase_exec_info_content)
2215         (tui_clear_exec_info_content, tui_update_exec_info): Change
2216         argument to tui_source_window_base.
2217
2218 2019-06-25  Tom Tromey  <tom@tromey.com>
2219
2220         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2221         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2222
2223 2019-06-25  Tom Tromey  <tom@tromey.com>
2224
2225         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2226         check.
2227
2228 2019-06-25  Tom Tromey  <tom@tromey.com>
2229
2230         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2231         type to void.
2232         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2233         type to void.
2234         * tui/tui-source.c (tui_set_source_content): Update.
2235         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2236
2237 2019-06-25  Tom Tromey  <tom@tromey.com>
2238
2239         * tui/tui-win.c (window_name_completer, tui_set_focus)
2240         (tui_all_windows_info): Use name method.
2241         * tui/tui-data.h (struct tui_gen_win_info)
2242         (struct tui_source_window, struct tui_disasm_window)
2243         (struct tui_data_window, struct tui_cmd_window) <name>: New
2244         method.
2245         (tui_win_name): Don't declare.
2246         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2247         (tui_win_name): Remove.
2248
2249 2019-06-25  Tom Tromey  <tom@tromey.com>
2250
2251         * tui/tui-winsource.h (tui_update_source_window)
2252         (tui_update_source_window_as_is): Change parameter type.
2253         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2254         to be a tui_source_window_base.
2255         (tui_update_source_window_as_is): Likewise.
2256         * tui/tui-win.c (make_visible_with_new_height): Update.
2257
2258 2019-06-25  Tom Tromey  <tom@tromey.com>
2259
2260         * tui/tui-winsource.c (tui_erase_source_content)
2261         (tui_show_source_content, tui_show_exec_info_content)
2262         (tui_erase_exec_info_content): Use refresh_window method.
2263         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2264         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2265         from tui_refresh_win.
2266         (tui_data_window::refresh_window): New method.
2267         (tui_win_info::refresh, tui_source_window_base::refresh)
2268         (tui_refresh_all): Use refresh_window method.
2269         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2270         method.
2271         * tui/tui-regs.c (tui_display_register): Call refresh_window
2272         method.
2273         * tui/tui-layout.c (show_source_disasm_command)
2274         (show_source_or_disasm_and_command): Call refresh_window method.
2275         * tui/tui-data.h (struct tui_gen_win_info)
2276         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2277         New method.
2278
2279 2019-06-25  Tom Tromey  <tom@tromey.com>
2280
2281         * tui/tui.c (tui_rl_other_window, tui_enable)
2282         (tui_is_window_visible, tui_get_command_dimension): Update.
2283         * tui/tui-winsource.c (tui_update_source_window_as_is)
2284         (tui_clear_source_content, tui_erase_source_content)
2285         (tui_show_source_line, tui_source_window_base::refill)
2286         (tui_source_window_base::do_scroll_horizontal)
2287         (tui_source_window_base::set_is_exec_point_at)
2288         (tui_update_breakpoint_info, tui_set_exec_info_content)
2289         (tui_alloc_source_buffer, tui_line_is_displayed)
2290         (tui_addr_is_displayed): Update.
2291         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2292         (tui_check_and_display_highlight_if_needed)
2293         (tui_win_info::make_visible, tui_win_info::refresh)
2294         (tui_refresh_all): Update.
2295         * tui/tui-windata.c (tui_first_data_item_displayed)
2296         (tui_delete_data_content_windows, tui_erase_data_content)
2297         (tui_display_all_data, tui_data_window::refresh_all)
2298         (tui_check_data_values): Update.
2299         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2300         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2301         (tui_win_info::backward_scroll, tui_refresh_all_win)
2302         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2303         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2304         (tui_source_window_base::set_new_height)
2305         (tui_data_window::set_new_height)
2306         (make_invisible_and_set_new_height)
2307         (make_visible_with_new_height, new_height_ok)
2308         (parse_scrolling_args): Update.
2309         * tui/tui-stack.c (tui_show_frame_info): Update.
2310         * tui/tui-source.c (tui_set_source_content)
2311         (tui_set_source_content_nil, tui_source_is_displayed)
2312         (tui_source_window::do_scroll_vertical): Update.
2313         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2314         (tui_display_registers_from, tui_display_reg_element_at_line)
2315         (tui_check_register_values, tui_reg_command): Update.
2316         * tui/tui-layout.c (tui_default_win_height)
2317         (show_source_disasm_command, show_data, init_and_make_win)
2318         (show_source_or_disasm_and_command): Update.
2319         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2320         (tui_redisplay_readline, tui_mld_flush)
2321         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2322         (tui_getc): Update.
2323         * tui/tui-disasm.c (tui_set_disassem_content)
2324         (tui_disasm_window::do_scroll_vertical): Update.
2325         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2326         Now virtual.
2327         (struct tui_win_info): Derive from tui_gen_win_info.
2328         <~tui_win_info>: Mark as override.
2329         <generic>: Remove member.
2330         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2331         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2332         (~tui_data_window, ~tui_win_info)
2333         (tui_free_all_source_wins_content): Update.
2334         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2335
2336 2019-06-25  Tom Tromey  <tom@tromey.com>
2337
2338         * tui/tui-layout.c (init_and_make_win): Use new.
2339         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2340         destructor, initializers.
2341         (tui_alloc_generic_win_info): Don't declare.
2342         * tui/tui-data.c (_locator): Add argument to constructor.
2343         (source_win, disasm_win): New globals.
2344         (exec_info): Remove.
2345         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2346         Update.
2347         (tui_alloc_generic_win_info): Remove.
2348         (init_content_element): Use new.
2349         (tui_win_info::tui_win_info): Update.
2350         (free_content_elements) <case DATA_WIN>: Use delete.
2351
2352 2019-06-25  Tom Tromey  <tom@tromey.com>
2353
2354         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2355         * tui/tui-windata.c (tui_first_data_item_displayed)
2356         (tui_delete_data_content_windows): Update.
2357         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2358         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2359         (tui_display_registers_from, tui_check_register_values): Update.
2360         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2361         pointer.
2362         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2363         window.
2364         (tui_free_data_content): Update.
2365         (free_content_elements) <case DATA_WIN>: Free the window.
2366
2367 2019-06-25  Tom Tromey  <tom@tromey.com>
2368
2369         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2370         Update.
2371         * tui/tui-layout.c (make_command_window)
2372         (show_source_disasm_command, show_data, init_and_make_win)
2373         (show_source_or_disasm_and_command): Update.
2374         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2375         method.
2376         <can_highight, is_highlighted>: Now bool.
2377         (tui_set_win_highlight): Don't declare.
2378         * tui/tui-data.c (tui_set_win_highlight): Remove.
2379
2380 2019-06-25  Tom Tromey  <tom@tromey.com>
2381
2382         * tui/tui-wingeneral.c (make_visible): Remove check of window
2383         type.
2384
2385 2019-06-25  Tom Tromey  <tom@tromey.com>
2386
2387         * tui/tui-win.c (tui_win_info::max_height)
2388         (tui_cmd_window::max_height): New methods.
2389         (new_height_ok): Call max_height.
2390         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2391         <max_height>: New method.
2392
2393 2019-06-25  Tom Tromey  <tom@tromey.com>
2394
2395         * tui/tui-win.c (tui_source_window_base::set_new_height)
2396         (tui_data_window::set_new_height): New methods.
2397         (make_invisible_and_set_new_height): Call set_new_height method.
2398         * tui/tui-data.h (struct tui_win_info)
2399         (struct tui_source_window_base, struct tui_data_window)
2400         <set_new_height>: New method.
2401
2402 2019-06-25  Tom Tromey  <tom@tromey.com>
2403
2404         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2405         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2406         tui_refresh_data_win.
2407         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2408         method.
2409         (tui_refresh_all_win): Call the refresh_all method.
2410         (tui_set_focus): Likewise.
2411         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2412         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2413         Likewise.
2414
2415 2019-06-25  Tom Tromey  <tom@tromey.com>
2416
2417         * tui/tui-winsource.h (tui_refill_source_window)
2418         (tui_set_is_exec_point_at): Don't declare.
2419         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2420         (tui_source_window_base::refill): Rename from
2421         tui_refill_source_window.
2422         (tui_source_window_base::do_scroll_horizontal): Update.
2423         (tui_source_window_base::set_is_exec_point_at): Rename from
2424         tui_set_is_exec_point_at.
2425         (tui_update_all_breakpoint_info): Update.
2426         * tui/tui-stack.c (tui_show_frame_info): Update.
2427         * tui/tui-layout.c (show_data): Add cast.
2428         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2429         * tui/tui-data.h (struct tui_source_window_base) <refill,
2430         set_is_exec_point_at>: New methods.
2431         (tui_source_windows, tui_add_to_source_windows): Update types.
2432         (tui_add_to_source_windows): Remove redundant declaration.
2433         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2434         (tui_source_windows): Change return type.
2435         (tui_clear_source_windows_detail): Update.
2436         (tui_add_to_source_windows): Change type of parameter.
2437         (tui_free_all_source_wins_content): Update.
2438
2439 2019-06-25  Tom Tromey  <tom@tromey.com>
2440
2441         * tui/tui-wingeneral.c (tui_win_info::refresh)
2442         (tui_source_window_base::refresh): New methods.
2443         (tui_refresh_all): Call the refresh method.
2444         * tui/tui-data.h (struct tui_win_info)
2445         (struct tui_source_window_base) <refresh>: New method.
2446
2447 2019-06-25  Tom Tromey  <tom@tromey.com>
2448
2449         * tui/tui.h (tui_is_window_visible): Return bool.
2450         * tui/tui.c (tui_is_window_visible): Return bool.
2451         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2452         (tui_make_visible, tui_make_invisible)
2453         (tui_win_info::make_visible)
2454         (tui_source_window_base::make_visible, make_all_visible)
2455         (tui_make_all_visible, tui_make_all_invisible): Update.
2456         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2457         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2458         bool.
2459         (struct tui_win_info, struct tui_source_window_base)
2460         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2461         * tui/tui-data.c (tui_init_generic_part): Update.
2462
2463 2019-06-25  Tom Tromey  <tom@tromey.com>
2464
2465         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2466         (tui_source_window_base::make_visible): New methods.
2467         (make_all_visible): Make method call.
2468         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2469         (struct tui_source_window_base, struct tui_cmd_window): Override
2470         make_visible.
2471         (tui_win_is_source_type): Don't declare.
2472         * tui/tui-data.c (tui_win_is_source_type): Remove.
2473
2474 2019-06-25  Tom Tromey  <tom@tromey.com>
2475
2476         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2477         NULL check.
2478
2479 2019-06-25  Tom Tromey  <tom@tromey.com>
2480
2481         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2482         Inline constructor.  Add initializers for members.
2483         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2484         constructors; now inline in class.
2485
2486 2019-06-25  Tom Tromey  <tom@tromey.com>
2487
2488         * tui/tui-regs.c (tui_show_registers): Update.
2489         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2490         bool.
2491         * tui/tui-data.c (tui_data_window::clear_detail)
2492         (tui_data_window): Update.
2493
2494 2019-06-25  Tom Tromey  <tom@tromey.com>
2495
2496         * tui/tui-windata.c (tui_display_all_data)
2497         (tui_display_data_from_line, tui_display_data_from)
2498         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2499         Update.
2500         * tui/tui-regs.c (tui_last_regs_line_no)
2501         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2502         (tui_show_registers, tui_show_register_group)
2503         (tui_display_registers_from, tui_display_reg_element_at_line)
2504         (tui_display_registers_from_line, tui_check_register_values)
2505         (tui_reg_next, tui_reg_prev): Update.
2506         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2507         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2508         tui_data_window.
2509         (struct tui_win_info) <detail>: Remove.  Add new fields from
2510         tui_data_info.
2511         (TUI_DATA_WIN): Add cast.
2512         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2513         (~tui_data_window): Simplify.
2514
2515 2019-06-25  Tom Tromey  <tom@tromey.com>
2516
2517         * tui/tui-layout.c (show_source_disasm_command)
2518         (show_source_or_disasm_and_command): Update.
2519         * tui/tui-io.c (update_cmdwin_start_line)
2520         (tui_redisplay_readline): Update.
2521         * tui/tui-data.h (struct tui_command_info): Remove.
2522         (struct tui_win_info) <detail>: Remove command_info member.
2523         (struct tui_data_window) <start_line>: New member, from
2524         tui_command_info.
2525         (TUI_CMD_WIN): Add casts.
2526
2527 2019-06-25  Tom Tromey  <tom@tromey.com>
2528
2529         * tui/tui-winsource.c (tui_update_source_window)
2530         (tui_refill_source_window)
2531         (tui_source_window_base::do_scroll_horizontal)
2532         (tui_update_breakpoint_info, tui_set_exec_info_content)
2533         (tui_show_exec_info_content, tui_erase_exec_info_content)
2534         (tui_clear_exec_info_content): Update.
2535         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2536         Update.
2537         * tui/tui-win.c (make_invisible_and_set_new_height)
2538         (make_visible_with_new_height): Update.
2539         * tui/tui-source.c (tui_set_source_content)
2540         (tui_show_symtab_source): Update.
2541         * tui/tui-layout.c (extract_display_start_addr)
2542         (show_source_disasm_command, show_data)
2543         (make_source_or_disasm_window)
2544         (show_source_or_disasm_and_command): Update.
2545         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2546         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2547         "gdbarch".
2548         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2549         to tui_source_window_base.
2550         (struct tui_win_info) <detail>: Remove source_info member.
2551         (struct tui_source_window_base) <has_locator>: Inline.
2552         Move contents from tui_source_info; rename has_locator member to
2553         m_has_locator.
2554         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2555         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2556         header file.
2557         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2558         Simplify.
2559         (tui_free_all_source_wins_content): Cast to
2560         tui_source_window_base.
2561
2562 2019-06-25  Tom Tromey  <tom@tromey.com>
2563
2564         * tui/tui-win.c (make_invisible_and_set_new_height)
2565         (make_visible_with_new_height): Call has_locator method.
2566         * tui/tui-layout.c (show_source_disasm_command, show_data)
2567         (show_source_or_disasm_and_command): Update for bool change.
2568         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2569         (tui_win_info) <has_locator>: New method.
2570         (struct tui_source_window_base) <has_locator>: New method.
2571         (tui_win_has_locator): Don't declare.
2572         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2573         from tui_win_has_locator.
2574         (tui_source_window_base): Use false, not FALSE.
2575
2576 2019-06-25  Tom Tromey  <tom@tromey.com>
2577
2578         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2579         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2580         clear_detail method directly.
2581         (tui_clear_win_detail): Remove.
2582
2583 2019-06-25  Tom Tromey  <tom@tromey.com>
2584
2585         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2586         "this", not TUI_DISASM_WIN.
2587
2588 2019-06-25  Tom Tromey  <tom@tromey.com>
2589
2590         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2591         declare.
2592         * tui/tui-winsource.c
2593         (tui_source_window_base::do_scroll_horizontal): Rename from
2594         tui_horizontal_source_scroll.
2595         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2596         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2597         from tui_vertical_data_scroll.
2598         * tui/tui-win.h (tui_scroll): Don't declare.
2599         * tui/tui-win.c (tui_win_info::forward_scroll)
2600         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2601         (tui_win_info::right_scroll): Rename and update.
2602         (tui_scroll_forward_command, tui_scroll_backward_command)
2603         (tui_scroll_left_command, tui_scroll_right_command): Update.
2604         (tui_scroll): Remove.
2605         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2606         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2607         from tui_vertical_source_scroll.
2608         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2609         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2610         from tui_vertical_disassem_scroll.
2611         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2612         do_scroll_horizontal>: New methods.
2613         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2614         Likewise.
2615         (struct tui_source_window_base): Add do_scroll_horizontal.
2616         (struct tui_source_window, struct tui_disasm_window): Add
2617         do_scroll_vertical.
2618         (struct tui_data_window, struct tui_cmd_window): Add
2619         do_scroll_horizontal and do_scroll_vertical.
2620         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2621
2622 2019-06-25  Tom Tromey  <tom@tromey.com>
2623
2624         * tui/tui-data.h (struct tui_source_window_base): New struct.
2625         (struct tui_source_window): Derive from tui_source_window_base.
2626         (struct tui_disasm_window): New struct.
2627         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2628         from tui_source_window::clear_detail.
2629         (tui_source_window_base): Rename from tui_source_window.
2630         (~tui_source_window_base): Rename from ~tui_source_window.
2631         (tui_alloc_win_info): Create a tui_disasm_window.
2632
2633 2019-06-25  Tom Tromey  <tom@tromey.com>
2634
2635         * tui/tui-data.h (struct tui_source_window)
2636         (struct tui_data_window): Declare destructors.
2637         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2638         destructors.
2639         (tui_win_info): Simplify.
2640
2641 2019-06-25  Tom Tromey  <tom@tromey.com>
2642
2643         * tui/tui-winsource.c (tui_display_main)
2644         (tui_update_source_windows_with_addr)
2645         (tui_update_all_breakpoint_info): Update.
2646         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2647         (new_height_ok, parse_scrolling_args): Update.
2648         * tui/tui-stack.c (tui_show_frame_info): Update.
2649         * tui/tui-data.h (struct tui_list): Remove.
2650         (tui_source_windows): Return a reference to a std::vector.
2651         * tui/tui-data.c (source_windows): Now a std::vector.
2652         (tui_source_windows): Change return type.
2653         (tui_clear_source_windows): Rewrite.
2654         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2655         (tui_free_all_source_wins_content): Rewrite.
2656
2657 2019-06-25  Tom Tromey  <tom@tromey.com>
2658
2659         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2660         (struct tui_data_window, struct tui_cmd_window): Declare
2661         clear_detail method.
2662         * tui/tui-data.c (tui_source_window::clear_detail)
2663         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2664         methods.
2665         (tui_clear_win_detail): Simplify.
2666
2667 2019-06-25  Tom Tromey  <tom@tromey.com>
2668
2669         * tui/tui-layout.c (make_source_window, make_disasm_window)
2670         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2671         Return the new window.
2672         (show_source_disasm_command, show_data)
2673         (show_source_or_disasm_and_command): Update.
2674
2675 2019-06-25  Tom Tromey  <tom@tromey.com>
2676
2677         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2678         parameter.  Return the new window.
2679         (show_source_disasm_command): Update and remove NULL check.
2680         (show_source_or_disasm_and_command): Update.
2681
2682 2019-06-25  Tom Tromey  <tom@tromey.com>
2683
2684         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2685
2686 2019-06-25  Tom Tromey  <tom@tromey.com>
2687
2688         * tui/tui-data.h (struct tui_win_info): Make constructor
2689         protected.  Make destructor virtual.  Add initializers.
2690         (tui_source_window, tui_data_window, tui_cmd_window): New
2691         classes.
2692         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2693         constructor.  Add "type" parameter.
2694         (tui_source_window, tui_data_window, tui_cmd_window): New
2695         constructors.
2696         (tui_alloc_win_info): Instantiate the appropriate subclass.
2697
2698 2019-06-25  Tom Tromey  <tom@tromey.com>
2699
2700         * tui/tui-win.c (tui_resize_all): Use delete.
2701         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2702         destructor.
2703         (tui_free_window): Don't declare.
2704         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2705         Update.
2706
2707 2019-06-25  Tom Tromey  <tom@tromey.com>
2708
2709         * tui/tui-data.h (struct tui_win_info): Add constructor.
2710         * tui/tui-data.c (tui_alloc_win_info): Use new.
2711         (tui_free_window): Use delete.
2712
2713 2019-06-22  Tom Tromey  <tom@tromey.com>
2714
2715         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2716         declare.
2717         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2718
2719 2019-06-22  Tom Tromey  <tom@tromey.com>
2720
2721         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2722         declare.
2723         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2724
2725 2019-06-22  Tom de Vries  <tdevries@suse.de>
2726
2727         * dwarf2read.c (create_addrmap_from_aranges)
2728         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2729         instead of '%zu'.
2730
2731 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2732
2733         * dwarf2read.h (dwarf2_section_info_def): Remove.
2734         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2735         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2736         std::vector<dwarf2_section_info>.
2737         (struct dwo_file) <~dwo_file>: Remove.
2738         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2739         types field.
2740         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2741         (dwarf2_read_debug_names): Likewise.
2742         (create_debug_types_hash_table): Change parameter type to
2743         array_view, adjust code accordingly.
2744         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2745         (partial_die_info::fixup): Likewise.
2746         (determine_prefix): Likewise.
2747         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2748
2749 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2750
2751         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2752         gdb_bfd_ref_ptr.
2753         <~dwo_file>: Remove call to gdb_bfd_unref.
2754         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2755         gdb_bfd_ref_ptr::get.
2756
2757 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2758
2759         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2760         type to htab_up.
2761         * dwarf2read.c (struct dwo_file): Initialize fields.
2762         <~dwo_file>: New.
2763         (free_dwo_file): Remove, move content to ~dwo_file.
2764         (struct dwo_file_deleter): Remove.
2765         (dwo_file_up>: Remove custom deleter.
2766         (free_dwo_files): Remove.
2767         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2768         dwo_files.
2769         (process_skeletonless_type_units): Call unique_ptr::get.
2770         (allocate_dwo_file_hash_table): Add deleter to created hash
2771         table.  Change return type to htab_up.
2772         (lookup_dwo_file_slot): Don't memset dwo_file, call
2773         unique_ptr::get.
2774         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2775         (create_dwo_unit_in_dwp_v2): Likewise.
2776         (open_and_init_dwo_file): Likewise.
2777         (free_dwo_file_from_slot): Remove.
2778
2779 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2780
2781         * dwarf2read.h (struct dwarf2_section_info) <readin,
2782         is_virtual>: Change type to bool.
2783         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2784         true instead of 1.
2785
2786 2019-06-19  Tom Tromey  <tom@tromey.com>
2787
2788         * tui/tui-data.h (tui_init_content_element): Don't declare.
2789
2790 2019-06-19  Tom Tromey  <tom@tromey.com>
2791
2792         * tui/tui-data.h (tui_init_win_info): Don't declare.
2793
2794 2019-06-19  Tom de Vries  <tdevries@suse.de>
2795
2796         * dwarf2read.h (abstract_to_concrete): Change type to
2797         std::unordered_map<sect_offset, std::vector<sect_offset>,
2798         gdb::hash_enum<sect_offset>>.
2799
2800 2019-06-19  Tom Tromey  <tromey@adacore.com>
2801
2802         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2803         EVAL_AVOID_SIDE_EFFECTS specially.
2804
2805 2019-06-19  Tom Tromey  <tromey@adacore.com>
2806
2807         * source-cache.c (highlighter): New global.
2808         (source_cache::get_source_lines): Create a highlighter on demand.
2809
2810 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2811
2812         * defs.h (deprecated_interactive_hook): Delete declaration.
2813         * interps.c (clear_interpreter_hooks): Remove use of
2814         deprecated_interactive_hook.
2815         * top.c (deprecated_interactive_hook): Delete definition.
2816         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2817
2818 2019-06-18  Tom de Vries  <tdevries@suse.de>
2819
2820         PR gdb/24515
2821         * dwarf2read.h (abstract_to_concrete): Change type from
2822         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2823         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2824         * dwarf2read.c (read_variable): Update.
2825         (dwarf2_fetch_die_loc_sect_off): Update.
2826
2827 2019-06-17  Tom de Vries  <tdevries@suse.de>
2828
2829         PR gdb/24617
2830         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2831         accessing parent[parent_len - 1].
2832
2833 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2834
2835         PR gdb/24364
2836         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2837         call dtrace_process_dof with NULL dof.
2838
2839 2019-06-16  Tom de Vries  <tdevries@suse.de>
2840
2841         PR gdb/24445
2842         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2843
2844 2019-06-16  Tom Tromey  <tom@tromey.com>
2845
2846         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2847         (make_all_visible): Use address of member.
2848
2849 2019-06-16  Tom Tromey  <tom@tromey.com>
2850
2851         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2852         (tui_free_window, free_content, free_content_elements): Remove
2853         unnecessary cast.
2854         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2855         cast.
2856         * tui/tui-regs.c (tui_show_register_group)
2857         (tui_display_registers_from, tui_display_reg_element_at_line):
2858         Remove unnecessary cast.
2859
2860 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2861
2862         * linux-nat.c (normal_mask): Delete.
2863         (_initialize_linux_nat): Don't initialise normal_mask.
2864
2865 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2866
2867         PR gdb/24445
2868         * dwarf-index-write.h (write_psymtabs_to_index): Add
2869         dwz_basename parameter.
2870         * dwarf-index-write.c (write_gdbindex): Move file writing to
2871         write_gdbindex_1.  Change return type void.
2872         (assert_file_size): Move up, remove filename parameter.
2873         (write_gdbindex_1): New function.
2874         (write_debug_names): Change return type to void, call
2875         assert_file_size.
2876         (struct index_wip_file): New struct.
2877         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2878         file logic to index_wip_file.  Write index for dwz file if
2879         needed.
2880         (save_gdb_index_command): Pass basename of dwz file, if present.
2881         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2882         build-id of dwz file, if present.
2883         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2884         (dwarf2_get_dwz_file): Likewise.
2885         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2886         (dwarf2_get_dwz_file): Likewise.
2887
2888 2019-06-16  Tom Tromey  <tom@tromey.com>
2889
2890         * coffread.c (process_coff_symbol): Use xstrdup.
2891         * value.c (create_internalvar): Use xstrdup.
2892
2893 2019-06-16  Tom Tromey  <tom@tromey.com>
2894
2895         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2896         * breakpoint.c (stopin_command, stopat_command)
2897         (until_break_command, decode_location_default): Remove unnecessary
2898         cast.
2899         * utils.c (subset_compare): Remove unnecessary cast.
2900         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2901         cast.
2902         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2903         cast.
2904         * infcmd.c (path_command): Remove unnecessary cast.
2905         * coffread.c (decode_type): Remove unnecessary cast.
2906         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2907         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2908         * tui/tui-stack.c (tui_show_locator_content)
2909         (tui_show_frame_info): Remove unnecessary cast.
2910         * tui/tui-win.c (tui_scroll_forward_command)
2911         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2912         (parse_scrolling_args): Remove unnecessary cast.
2913         * tui/tui-data.c (init_win_info, tui_del_window)
2914         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2915         (free_content_elements): Remove unnecessary cast.
2916         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2917         unnecessary cast.
2918         * tui/tui-source.c (tui_set_source_content)
2919         (tui_vertical_source_scroll): Remove unnecessary cast.
2920         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2921         cast.
2922         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2923         * tui/tui-regs.c (tui_display_registers_from)
2924         (tui_display_register): Remove unnecessary cast.
2925         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2926         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2927         (make_visible): Remove unnecessary cast.
2928         * tui/tui-winsource.c (tui_erase_source_content)
2929         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2930         unnecessary cast.
2931         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2932         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2933         * stabsread.c (read_type, read_array_type, read_range_type):
2934         Remove unnecessary cast.
2935         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2936         (parse_symbol, parse_type, upgrade_type, parse_external)
2937         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2938         unnecessary cast.
2939         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2940
2941 2019-06-16  Tom Tromey  <tom@tromey.com>
2942
2943         * tui/tui-data.c (tui_alloc_generic_win_info)
2944         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2945         checks.
2946
2947 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2948             Andrew Burgess  <andrew.burgess@embecosm.com>
2949
2950         * f-typeprint.c (f_print_type): Don't return early for not
2951         associated or not allocated types.
2952         (f_type_print_varspec_suffix): Add print_rank parameter and print
2953         ranks of array types in case they dangling.
2954         (f_type_print_base): Add print_rank parameter.
2955
2956 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2957
2958         * NEWS: Mention new MI commands.
2959         * break-catch-throw.c (enum exception_event_kind): Move to
2960         breakpoint.h.
2961         (print_mention_exception_catchpoint): Output text as a single
2962         message.
2963         (catch_exception_command_1): Rename to...
2964         (catch_exception_event): ...this, make non-static, update header
2965         command, and change some parameter types.
2966         (catch_catch_command): Update for changes to
2967         catch_exception_command_1.
2968         (catch_throw_command): Likewise.
2969         (catch_rethrow_command): Likewise.
2970         * breakpoint.c (enum exception_event_kind): Delete.
2971         * breakpoint.h (enum exception_event_kind): Moved here from
2972         break-catch-throw.c.
2973         (catch_exception_event): Declare.
2974         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2975         (mi_cmd_catch_throw): New function.
2976         (mi_cmd_catch_rethrow): New function.
2977         (mi_cmd_catch_catch): New function.
2978         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2979         'catch-catch' entries.
2980         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2981         (mi_cmd_catch_rethrow): Declare.
2982         (mi_cmd_catch_catch): Declare.
2983
2984 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2985
2986         * annotate.c (annotate_source_line): Change return type to void,
2987         update implementation to match.
2988         * annotate.h (annotate_source_line): Change return type to void,
2989         update header comment.
2990         * stack.c (print_frame_info): Don't change what frame information
2991         is printed based on whether annotations are on or not.
2992
2993 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2994
2995         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2996         (annotate_source): Make static.
2997         (annotate_source_line): Moved from source.c and renamed from
2998         identify_source_line.  Update the return type.
2999         * annotate.h (annotate_source): Delete declaration.
3000         (annotate_source_line): Declaration moved from source.h, and
3001         renamed from identify_source_line.  Return type updated.
3002         * source.c (identify_source_line): Moved to annotate.c and renamed
3003         to annotate_source_line.
3004         (info_line_command): Remove check of annotation_level.
3005         * source.h (identify_source_line): Move declaration to annotate.h
3006         and rename to annotate_source_line.
3007         * stack.c: Add 'annotate.h' include.
3008         (print_frame_info): Remove check of annotation_level before
3009         calling annotate_source_line.
3010
3011 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3012
3013         * source-cache.c (source_cache::get_plain_source_lines): Use
3014         open_source_file_with_line_charpos instead of just
3015         open_source_file, remove call to find_source_lines.
3016         (source_cache::get_source_lines): Likewise.
3017         * source.c (find_source_lines): Make static.
3018         (get_filename_and_charpos): Renamed into...
3019         (open_source_file_with_line_charpos): ..this along with changes to
3020         return a scoped_fd, and some other minor clean ups.
3021         (identify_source_line): Use open_source_file_with_line_charpos.
3022         (search_command_helper): Use open_source_file_with_line_charpos
3023         instead of just open_source_file, remove call to
3024         find_source_lines.
3025         * source.h (open_source_file_with_line_charpos): Declare new
3026         function.
3027         (find_source_lines): Delete declaration.
3028
3029 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3030
3031         * source.c (get_filename_and_charpos): Remove fullname
3032         parameter.
3033         (identify_source_line): Update call to get_filename_and_charpos.
3034
3035 2019-06-14  Tom Tromey  <tromey@adacore.com>
3036
3037         PR gdb/24502:
3038         * ui-style.h (skip_ansi_escape): Update comment.
3039         * ui-file.h (class no_terminal_escape_file): New class.
3040         * ui-file.c (no_terminal_escape_file::write)
3041         (no_terminal_escape_file::puts): New methods.
3042         * cli/cli-logging.c (handle_redirections): Use
3043         no_terminal_escape_file.
3044
3045 2019-06-14  Tom Tromey  <tromey@adacore.com>
3046
3047         * NEWS: Move convenience variable news above Python news.
3048
3049 2019-06-14  Tom Tromey  <tom@tromey.com>
3050
3051         * gnulib: Move directory to top-level.
3052         * configure.ac: Don't configure gnulib.
3053         * configure: Rebuild.
3054         * common/common-defs.h: Use new path to gnulib.
3055         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3056         (GNULIB_H): Remove.
3057         (INCGNU): Look in new gnulib location.
3058         (HFILES_NO_SRCDIR): Remove gnulib files.
3059         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3060         (generated_files): Remove GNULIB_H.
3061         ($(LIBGNU), all-lib): Remove targets.
3062         (distclean): Don't mention GNULIB_BUILDDIR.
3063         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3064
3065 2019-06-14  Tom Tromey  <tromey@adacore.com>
3066
3067         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3068         Warn if symbol file does not provide any symbols.
3069
3070 2019-06-14  Tom Tromey  <tromey@adacore.com>
3071
3072         * source.c (find_and_open_source): Respect basenames_may_differ.
3073
3074 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3075
3076         * annotate.c (annotate_breakpoints_invalid): Make use of
3077         scoped_restore_terminal_state.
3078         (annotate_frames_invalid): Likewise.
3079
3080 2019-06-14  Tom Tromey  <tromey@adacore.com>
3081
3082         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3083         allow assignment to an internalvar.
3084
3085 2019-06-14  Tom Tromey  <tromey@adacore.com>
3086
3087         * ada-lex.l: Allow "_" in attribute names.
3088
3089 2019-06-14  Tom Tromey  <tromey@adacore.com>
3090
3091         PR gdb/24653:
3092         * regcache.c (registers_changed): Don't call alloca.
3093         * top.c (execute_command): Don't call alloca.
3094
3095 2019-06-13  Pedro Alves  <palves@redhat.com>
3096
3097         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3098         'expression'.  When parsing an expression, error out if there's
3099         junk after "unlimited".
3100         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3101         (do_set_command): Adjust calls to is_unlimited_literal.
3102
3103 2019-06-13  Pedro Alves  <palves@redhat.com>
3104
3105         * compile/compile.c (make_compile_options_def_group): Add braces
3106         around array_view initializer.
3107         * thread.c (make_thread_apply_all_options_def_group)
3108         (make_thread_apply_all_options_def_group): Likewise.
3109
3110 2019-06-13  Pedro Alves  <palves@redhat.com>
3111
3112         * NEWS (New commands): Mention "maint test-options
3113         require-delimiter", "maint test-options unknown-is-error", "maint
3114         test-options unknown-is-operand" and "maint show
3115         test-options-completion-result".
3116         (New command options, command completion): New section.
3117         (Completion improvements): New section.
3118         Mention that you can abbreviate "unlimited".
3119
3120 2019-06-13  Pedro Alves  <palves@redhat.com>
3121
3122         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3123         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3124         * unittests/cli-utils-selftests.c (test_parse_flags)
3125         (test_parse_flags_qcs): Delete.
3126         (test_cli_utils): Don't call deleted functions.
3127
3128 2019-06-13  Pedro Alves  <palves@redhat.com>
3129
3130         * thread.c: Include "cli/cli-option.h".
3131         (tp_array_compar_ascending): Global.
3132         (tp_array_compar): Delete function.
3133         (tp_array_compar_ascending, tp_array_compar_descending): New
3134         functions.
3135         (ascending_option_def, qcs_flag_option_def)
3136         (thr_qcs_flags_option_defs)
3137         (make_thread_apply_all_options_def_group)
3138         (make_thread_apply_options_def_group): New.
3139         (thread_apply_all_command): Use gdb::option::process_options.
3140         (thread_apply_command_completer)
3141         (thread_apply_all_command_completer): New.
3142         (thread_apply_command): Use gdb::option::process_options.
3143         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3144         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3145         to generate help text of "thread apply".  Adjust "taas"'s help.
3146         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3147         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3148
3149 2019-06-13  Pedro Alves  <palves@redhat.com>
3150
3151         * thread.c (thread_apply_command): Check for invalid TID with
3152         isdigit instead of !isalpha.
3153
3154 2019-06-13  Pedro Alves  <palves@redhat.com>
3155
3156         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3157         (validate_flags_qcs): New.
3158         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3159         (validate_flags_qcs): Declare.
3160         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3161         (make_frame_apply_options_def_group): New.
3162         (frame_apply_command_count): Process options with
3163         gdb::option::process_options.
3164         (frame_apply_completer): New.
3165         (frame_apply_level_completer, frame_apply_all_completer)
3166         (frame_apply_completer): New.
3167         (_initialize_stack): Update help of "frame apply", "frame apply
3168         level", "frame apply all" and "faas" to mention supported options
3169         and install command completers.
3170         * stack.h (frame_apply_all_completer): Declare.
3171         * thread.c: Include "stack.h".
3172         (tfaas_command): Add "--".
3173         (_initialize_thread): Update help "tfaas" to mention supported
3174         options and install command completer.
3175
3176 2019-06-13  Pedro Alves  <palves@redhat.com>
3177
3178         * completer.c (complete_nested_command_line): New.
3179         (gdb_completion_word_break_characters_throw): Add assertion.
3180         * completer.h (complete_nested_command_line): Declare.
3181
3182 2019-06-13  Pedro Alves  <palves@redhat.com>
3183
3184         * stack.c (parse_backtrace_qualifiers): New.
3185         (backtrace_command): Use it.
3186         (backtrace_command_completer): Complete on qualifiers.
3187
3188 2019-06-13  Pedro Alves  <palves@redhat.com>
3189
3190         * frame.c: Include "cli/cli-option.h.
3191         (user_set_backtrace_options): New.
3192         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3193         Delete.
3194         (get_prev_frame): Adjust.
3195         (boolean_option_def, uinteger_option_def)
3196         (set_backtrace_option_defs): New.
3197         (_initialize_frame): Adjust and use
3198         gdb::option::add_setshow_cmds_for_options to install "set
3199         backtrace past-main" and "set backtrace past-entry".
3200         * frame.h: Include "cli/cli-option.h".
3201         (struct frame_print_options): Forward declare.
3202         (print_frame_arguments_all, print_frame_arguments_scalars)
3203         (print_frame_arguments_none): Declare.
3204         (print_entry_values): Delete declaration.
3205         (struct frame_print_options, user_frame_print_options): New.
3206         (struct set_backtrace_options): New.
3207         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3208         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3209         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3210         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3211         (list_args_or_locals): Add frame_print_options parameter.
3212         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3213         * python/py-framefilter.c (enumerate_args): Pass down
3214         USER_FRAME_PRINT_OPTIONS.
3215         * stack.c: Include "cli/cli-option.h".
3216         (print_frame_arguments_all, print_frame_arguments_scalars)
3217         (print_frame_arguments_none): Declare.
3218         (print_raw_frame_arguments, print_entry_values): Delete.
3219         (user_frame_print_options): New.
3220         (boolean_option_def, enum_option_def, frame_print_option_defs):
3221         New.
3222         (struct backtrace_cmd_options): New.
3223         (bt_flag_option_def): New.
3224         (backtrace_command_option_defs): New.
3225         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3226         (print_frame_arg, read_frame_arg, print_frame_args)
3227         (print_frame_info, print_frame): Add frame_print_options parameter
3228         and use it.
3229         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3230         (backtrace_command_1): Add frame_print_options and
3231         backtrace_cmd_options parameters and use them.
3232         (make_backtrace_options_def_group): New.
3233         (backtrace_command): Process command options with
3234         gdb::option::process_options.
3235         (backtrace_command_completer): New.
3236         (_initialize_stack): Extend "backtrace"'s help to mention
3237         supported options.  Install completer for "backtrace".
3238         Install some settings commands with add_setshow_cmds_for_options.
3239
3240 2019-06-13  Pedro Alves  <palves@redhat.com>
3241
3242         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3243         and that "set/show print raw frame-arguments" are now deprecated.
3244
3245         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3246         command.
3247         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3248         * stack.c (_initialize_stack): Install "set/show print
3249         raw-frame-arguments", and deprecate "set/show print raw
3250         frame-arguments".
3251         * valprint.c (_initialize_valprint): Deprecate "set/show print
3252         raw".
3253
3254 2019-06-13  Pedro Alves  <palves@redhat.com>
3255
3256         * compile/compile.c (struct compile_options): New.
3257         (compile_flag_option_def, compile_command_option_defs)
3258         (make_compile_options_def_group): New.
3259         (compile_file_command): Handle options with
3260         gdb::option::process_options.
3261         (compile_file_command_completer): New function.
3262         (compile_code_command): Handle options with
3263         gdb::option::process_options.
3264         (compile_code_command_completer): New function.
3265         (_initialize_compiler): Install completers for "compile code" and
3266         "compile file".  Mention available options in "compile code" and
3267         "compile code"'s help.
3268         * completer.c (advance_to_completion_word): New, factored out from
3269         ...
3270         (advance_to_expression_complete_word_point): ... this.
3271         (advance_to_filename_complete_word_point): New.
3272         * completer.h (advance_to_filename_complete_word_point): New
3273         declaration.
3274
3275 2019-06-13  Pedro Alves  <palves@redhat.com>
3276
3277         * compile/compile.c: Include "cli/cli-option.h".
3278         (compile_print_value): Scope data pointer is now a
3279         value_print_options pointer; adjust.
3280         (compile_print_command): Process options.  Scope data pointer is
3281         now a value_print_options pointer; adjust.
3282         (_initialize_compile): Update "compile print"'s help to include
3283         supported options.  Install a completer for "compile print".
3284         * cp-valprint.c (show_vtblprint, show_objectprint)
3285         (show_static_field_print): Delete.
3286         (_initialize_cp_valprint): Don't install "set print
3287         static-members", "set print vtbl", "set print object" here.
3288         * printcmd.c: Include "cli/cli-option.h" and
3289         "common/gdb_optional.h".
3290         (print_command_parse_format): Rework to fill in a
3291         value_print_options instead of a format_data.
3292         (print_value): Change parameter type from format_data pointer to
3293         value_print_options reference.  Adjust.
3294         (print_command_1): Process options.  Adjust to pass down a
3295         value_print_options.
3296         (print_command_completer): New.
3297         (_initialize_printcmd): Install print_command_completer as
3298         handle_brkchars completer for the "print" command.  Update
3299         "print"'s help to include supported options.
3300         * valprint.c: Include "cli/cli-option.h".
3301         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3302         here from cp-valprint.c.
3303         (boolean_option_def, uinteger_option_def)
3304         (value_print_option_defs, make_value_print_options_def_group):
3305         New.  Use gdb::option::add_setshow_cmds_for_options to install
3306         "set print elements", "set print null-stop", "set print repeats",
3307         "set print pretty", "set print union", "set print array", "set
3308         print address", "set print symbol", "set print array-indexes".
3309         * valprint.h: Include <string> and "cli/cli-option.h".
3310         (make_value_print_options_def_group): Declare.
3311         (print_value): Change parameter type from format_data pointer to
3312         value_print_options reference.
3313         (print_command_completer): Declare.
3314
3315 2019-06-13  Pedro Alves  <palves@redhat.com>
3316
3317         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3318         (COMMON_SFILES): Add maint-test-settings.c.
3319         * cli/cli-decode.c (boolean_enums): New global, factored out from
3320         ...
3321         (add_setshow_boolean_cmd): ... here.
3322         * cli/cli-decode.h (boolean_enums): Declare.
3323         * cli/cli-option.c: New file.
3324         * cli/cli-option.h: New file.
3325         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3326         factored out from ...
3327         (parse_cli_boolean_value(const char *)): ... this.
3328         (is_unlimited_literal): Change parameter type to pointer to
3329         pointer.  Adjust and advance ARG pointer.
3330         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3331         (parse_cli_var_enum): New, factored out from ...
3332         (do_set_command): ... this.  Adjust.
3333         * cli/cli-setshow.h (parse_cli_boolean_value)
3334         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3335         (parse_cli_var_enum): Declare.
3336         * cli/cli-utils.c: Include "cli/cli-option.h".
3337         (get_ulongest): New.
3338         * cli/cli-utils.h (get_ulongest): Declare.
3339         (check_for_argument): New overloads.
3340         * maint-test-options.c: New file.
3341
3342 2019-06-13  Pedro Alves  <palves@redhat.com>
3343
3344         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3345         parse a range if "-" is at the end of the string.
3346
3347 2019-06-13  Pedro Alves  <palves@redhat.com>
3348
3349         * cli/cli-setshow.c (parse_auto_binary_operation)
3350         (parse_cli_boolean_value): Don't allow "o".
3351
3352 2019-06-13  Pedro Alves  <palves@redhat.com>
3353
3354         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3355         * NEWS: Mention maint test-settings KIND.
3356         * maint-test-settings.c: New file.
3357
3358 2019-06-13  Pedro Alves  <palves@redhat.com>
3359
3360         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3361         completer.
3362         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3363         "set" completers.
3364
3365 2019-06-13  Pedro Alves  <palves@redhat.com>
3366
3367         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3368         after item.
3369
3370 2019-06-13  Pedro Alves  <palves@redhat.com>
3371
3372         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3373
3374 2019-06-13  Pedro Alves <palves@redhat.com>
3375
3376         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3377         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3378         call.
3379         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3380         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3381         calls.
3382         (check_for_argument): Skip spaces after argument.
3383
3384 2019-06-13  Pedro Alves  <palves@redhat.com>
3385
3386         * thread.c (thread_apply_command): Adjust TID parsing.
3387         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3388         detected before end of string.
3389         (tid_is_in_list): Error out if LIST is invalid.
3390
3391 2019-06-13  Pedro Alves  <palves@redhat.com>
3392
3393         * completer.c (complete_line_internal_1): Rewind completion word
3394         point.
3395         (completion_tracker::advance_custom_word_point_by): Change
3396         parameter type to int.
3397         * completer.h (completion_tracker::advance_custom_word_point_by):
3398         Likewise.
3399
3400 2019-06-13  Pedro Alves  <palves@redhat.com>
3401
3402         * completer.c (advance_to_completion_word): Handle delimiters.
3403
3404 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3405
3406         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3407
3408 2019-06-11  Tom Tromey  <tom@tromey.com>
3409
3410         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3411         (xmalloc_failed): Move to alloc.c.
3412         * alloc.c: New file.
3413         * Makefile.in (COMMON_SFILES): Add alloc.c.
3414
3415 2019-06-11  Tom Tromey  <tom@tromey.com>
3416
3417         * nat/linux-waitpid.c: Don't include server.h.
3418         (linux_debug): Remove.
3419         (my_waitpid): Update.
3420
3421 2019-06-11  Tom Tromey  <tromey@adacore.com>
3422
3423         * infcall.c (_initialize_infcall): Remove trailing newline from
3424         help.
3425         * user-regs.c (_initialize_user_regs): Remove trailing newline
3426         from help.
3427         * typeprint.c (_initialize_typeprint): Remove trailing newline
3428         from help.
3429         * reverse.c (_initialize_reverse): Remove trailing newlines from
3430         help.
3431         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3432         from help.
3433         * language.c (add_set_language_command): Remove trailing newline
3434         from help.
3435         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3436         help.
3437         * disasm.c (_initialize_disasm): Remove trailing newline from
3438         help.
3439         * top.c (init_main): Remove trailing newline from help.
3440         * interps.c (_initialize_interpreter): Remove trailing newline
3441         from help.
3442         * btrace.c (_initialize_btrace): Remove trailing newlines from
3443         help.
3444         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3445         from help.
3446         * python/python.c (_initialize_python): Remove trailing newline
3447         from help.
3448         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3449         help.
3450         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3451         from help.  Reformat some text.
3452         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3453         from help.
3454         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3455         newline from help.
3456
3457 2019-06-11  Tom Tromey  <tromey@adacore.com>
3458
3459         * darwin-nat.c (darwin_decode_exception_message)
3460         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3461
3462 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3463
3464         * valops.c (value_slice): Check for not allocated or not
3465         associated values.
3466
3467 2019-06-10  Tom de Vries  <tdevries@suse.de>
3468
3469         PR gdb/24618
3470         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3471         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3472         invalid.
3473
3474 2019-06-10  Tom de Vries  <tdevries@suse.de>
3475
3476         PR gdb/24611
3477         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3478         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3479
3480 2019-06-10  Tom de Vries  <tdevries@suse.de>
3481
3482         PR symtab/24545
3483         * symtab.c (struct demangled_name_entry): Add language field.
3484         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3485         static minimal symbol".  Set and use language field.
3486
3487 2019-06-10  Tom Tromey  <tromey@adacore.com>
3488
3489         * ada-lang.c (_initialize_ada_language): Update help text.
3490
3491 2019-06-10  Tom Tromey  <tromey@adacore.com>
3492
3493         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3494         with a newline.
3495         * guile/guile.c (handle_boot_error): Don't end warning with a
3496         newline.
3497         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3498         warning with a newline.
3499         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3500         newline.
3501         (s12z_frame_cache): Likewise.
3502         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3503         a newline.
3504         * solib-svr4.c (disable_probes_interface): Don't end warning with
3505         a newline.
3506         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3507         newline.
3508         * python/python.c (do_finish_initialization): Don't end warning
3509         with a newline.
3510
3511 2019-06-10  Tom Tromey  <tom@tromey.com>
3512
3513         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3514         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3515         gdbpy_enter.
3516
3517 2019-06-10  Tom Tromey  <tromey@adacore.com>
3518
3519         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3520         data.
3521         (elf_new_init): Don't call stabsread_new_init.
3522         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3523         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3524         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3525
3526 2019-06-10  Tom de Vries  <tdevries@suse.de>
3527
3528         PR symtab/16264
3529         PR symtab/24517
3530         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3531
3532 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3533
3534         * source.c (find_and_open_source): Also rewrite relative file
3535         names.
3536
3537 2019-04-26  Amos Bird  <amosbird@gmail.com>
3538
3539         * annotate.c (annotate_thread_exited): Add "thread-exited"
3540         annotation.
3541
3542 2019-06-06  Tom Tromey  <tromey@adacore.com>
3543
3544         * maint.h (class scoped_command_stats): Use
3545         DISABLE_COPY_AND_ASSIGN.
3546         <print_time>: New method.
3547         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3548         print_time.
3549         (scoped_command_stats::print_time): New method.
3550
3551 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3552
3553         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3554         instructions of lengths 6 or 8 bytes.
3555
3556 2019-06-04  Pedro Alves  <palves@redhat.com>
3557
3558         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3559
3560         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3561         * breakpoint.c (condition_completer): Likewise.
3562         * cli/cli-dump.c (scan_expression): Likewise.
3563         * common/filestuff.c (mkdir_recursive): Likewise.
3564         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3565         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3566         (gdb_abspath): Likewise.
3567         * compile/compile-cplus-types.c
3568         (compile_cplus_instance::decl_name): Likewise.
3569         * completer.c (complete_explicit_location):
3570         (signal_completer, reg_or_group_completer_1): Likewise.
3571         * cp-support.c (cp_remove_params_if_any): Likewise.
3572         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3573         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3574         * infcmd.c (strip_bg_char): Likewise.
3575         * linespec.c (copy_token_string): Likewise.
3576         * mi/mi-main.c (output_cores): Likewise.
3577         * psymtab.c (psymtab_search_name):
3578         * symfile.c (test_set_ext_lang_command): Likewise.
3579         * target.c (target_fileio_read_stralloc): Likewise.
3580         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3581         * value.c (complete_internalvar): Likewise.
3582
3583 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3584
3585         Add objfile property to gdb.Type.
3586         * NEWS: Mention Python API addition.
3587         * python/py-type.c (typy_get_objfile): New method.
3588
3589 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3590
3591         * NEWS: Mention the new set|show style [title|highlight].
3592         Mention changes to "show style", "help" and "apropos".
3593
3594 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3595
3596         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3597         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3598         instead of print_help_for_command.
3599         (print_doc_of_command): New function.
3600         (help_list): Add 'apropos -v word' suggestion.
3601         (print_help_for_command): Style the command name using title style.
3602         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3603         (_initialize_cli_cmds): Describe -v in apropos_command help.
3604
3605 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3606
3607         * cli/cli-style.h (cli_style_option): Add name in constructor,
3608         add m_name class member, add constructor with intensity,
3609         add name class function.
3610         (cli_style_option::add_setshow_commands): Remove name argument.
3611         (highlight_style, title_style): New styles.
3612         * cli/cli-style.c (do_show): New function that shows a style
3613         characteristic styling the style name with itself.
3614         (set_style_name): New function.
3615         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3616         Update all callers according to the changes in cli/cli-style.h.
3617         * utils.h (fputs_highlighted): New function.
3618         * utils.c (fputs_highlighted): Likewise.
3619
3620 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3621
3622         * NEWS: Mention new pipe command and new convenience variables.
3623
3624 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3625
3626         * cli/cli-cmds.c (pipe_command): New function.
3627         (_initialize_cli_cmds): Call add_com for pipe_command.
3628         Define | as an alias for pipe.
3629         (exit_status_set_internal_vars): New function.
3630         (shell_escape): Call exit_status_set_internal_vars.
3631         cli/cli-decode.c (find_command_name_length): Recognize | as
3632         a single character command.
3633
3634 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3635
3636         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3637         top.c (execute_command_to_ui_file): New function, mostly a copy
3638         of execute_command_to_string.
3639         (execute_command_to_string): Implement by calling
3640         execute_command_to_ui_file.
3641
3642 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3643
3644         * top.h (saved_command_line): Remove declaration.
3645         * top.c (previous_saved_command_line, previous_repeat_arguments):
3646         New variables.
3647         (saved_command_line): Make static, define together with other
3648         'repeat variables'.
3649         (dont_repeat): Clear repeat_arguments.
3650         (repeat_previous, get_saved_command_line, save_command_line):
3651         New functions.
3652         (gdb_init): Initialize saved_command_line
3653         and previous_saved_command_line.
3654         * main.c (captured_main_1): Remove saved_command_line initialization.
3655         * event-top.c (handle_line_of_input): Update to use
3656         the new 'repeat' related functions instead of direct access to
3657         saved_command_line.
3658         * command.h (repeat_previous, get_saved_command_line,
3659         save_command_line): New declarations.
3660         (dont_repeat): Add comment.
3661
3662 2019-05-30  Tom Tromey  <tromey@adacore.com>
3663
3664         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3665         Fix comment.
3666         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3667
3668 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3669
3670         PR cli/24587
3671         * completer.c (complete): Initialize variable word.
3672
3673 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3674
3675         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3676         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3677         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3678         'body' is NULL to the outter 'if', protecting the '!is_define'
3679         situation as well.
3680
3681 2019-05-29  Tom Tromey  <tromey@adacore.com>
3682
3683         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3684         (dwarf_unknown): New function.
3685         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3686         (dwarf_type_encoding_name): Use dwarf_unknown.
3687
3688 2019-05-29  Tom Tromey  <tromey@adacore.com>
3689
3690         PR c++/20020:
3691         * cp-valprint.c (cp_print_value_fields): Call
3692         cp_print_static_field inside "try".
3693
3694 2019-05-29  Tom Tromey  <tromey@adacore.com>
3695
3696         * inflow.c (struct terminal_info): Add default operator=.
3697         * configure: Rebuild.
3698         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3699         -Wdeprecated-copy-dtor, -Wredundant-move.
3700
3701 2019-05-29  Tom Tromey  <tromey@adacore.com>
3702
3703         * NEWS: Add entry.
3704         * infcmd.c (print_return_value_1): Handle finish_print
3705         option.
3706         (show_print_finish): New function.
3707         (_initialize_infcmd): Add "set/show print finish" commands.
3708         * valprint.c (user_print_options): Initialize new member.
3709         * valprint.h (struct value_print_options) <finish_print>: New
3710         member.
3711
3712 2019-05-28  Tom Tromey  <tromey@adacore.com>
3713
3714         * ada-lang.c (ada_remove_Xbn_suffix)
3715         (find_old_style_renaming_symbol)
3716         (parse_old_style_renaming): Remove.
3717         (ada_find_renaming_symbol): Don't call
3718         find_old_style_renaming_symbol.
3719         (ada_is_renaming_symbol): Rename from
3720         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3721         bool.  Now static.
3722         (ada_read_var_value): Update and simplify.
3723         * ada-exp.y (write_var_or_type): Remove old code.
3724
3725 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3726
3727         * event-top.c: Remove include comment.
3728         * inflow.c (class scoped_ignore_sigttou): Move from here...
3729         * inflow.h (class scoped_ignore_sigttou): ...to here.
3730         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3731         * top.c:  Remove include comment.
3732
3733 2019-05-27  Tom Tromey  <tom@tromey.com>
3734
3735         * NEWS: Fix typo.
3736
3737 2019-05-22  Tom Tromey  <tromey@adacore.com>
3738
3739         * target.c (target_follow_exec): Constify parameter.
3740         * target-delegates.c: Rebuild.
3741         * remote.c (remote_target::follow_exec): Constify parameter.
3742         * infrun.c (follow_exec): Constify parameter.
3743         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3744         (target_follow_exec): Likewise.
3745
3746 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3747
3748         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3749         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3750
3751 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3752
3753         * NEWS: Add debugredirect and testsuite sections.
3754
3755 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3756
3757         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3758         target descriptions using exclusively floating point register name
3759         aliases.
3760
3761 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3762
3763         PR gdb/18644:
3764         * f-lang.c (build_fortran_types): Handle the case where
3765         gdbarch_floatformat_for_type returns a nullptr.
3766
3767 2019-05-21  Tom de Vries  <tdevries@suse.de>
3768
3769         PR cli/24587
3770         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3771
3772 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3773
3774         PR gdb/18644:
3775         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3776         16-byte floats.
3777         * i386-tdep.c (i386_floatformat_for_type): Use
3778         floatformats_ia64_quad for the 16-byte floating point component
3779         within a fortran 32-byte complex number.
3780
3781 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3782
3783         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3784         delete default constructor.
3785         (find_partial_die): Update to return const struct.
3786         (partial_die_parent_scope): Move variable declaration into scope
3787         of its use and change its type to auto.
3788         (guess_partial_die_structure_name): Likewise.
3789         (partial_die_info::fixup): Likewise.
3790
3791 2019-05-17  Tom Tromey  <tromey@adacore.com>
3792
3793         * source.c (find_and_open_source): Remove cast.
3794
3795 2019-05-17  Tom Tromey  <tromey@adacore.com>
3796
3797         * annotate.c (annotate_source): Make "filename" const.
3798         * annotate.h (annotate_source): Use const.
3799
3800 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3801
3802         * disasm.c (set_disassembler_options): Send errors to stderr.
3803
3804 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3805
3806         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3807         (cli_interp_base::set_logging): Check debug_redirect.
3808         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3809         * cli/cli-logging.c (debug_redirect): Add static variable.
3810         (pop_output_files): Add default param.
3811         (handle_redirections): Print debug setting.
3812         (show_logging_command): Likewise.
3813         (_initialize_cli_logging): Add debugredirect command.
3814         * interps.c (current_interp_set_logging): Add debug_redirect
3815         parameter.
3816         * interps.h (set_logging): Add debug_redirect parameter.
3817         (current_interp_set_logging): Likewise.
3818         * mi/mi-common.h: Likewise.
3819         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3820
3821 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3822             Tom Tromey  <tromey@adacore.com>
3823
3824         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3825         directly.
3826         * cli/cli-interp.h (make_logging_output): Remove declaration.
3827         * cli/cli-logging.c (make_logging_output): Remove function.
3828         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3829         directly.
3830         * ui-file.c (tee_file::tee_file): Remove bools.
3831         (tee_file::~tee_file): Remove deletes.
3832         * ui-file.h (tee_file): Remove bools.
3833
3834 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3835
3836         * mi/mi-cmds.h (mi_cmd_complete): New function.
3837         * mi/mi-main.c (mi_cmd_complete): Likewise.
3838         * mi/mi-cmds.c: Define new MI command -complete.
3839         * NEWS: Mention new -complete command.
3840
3841 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3842
3843         * completer.h (complete): New function.
3844         * completer.c (complete): Likewise.
3845         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3846         function defined in completer.h.
3847
3848 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3849
3850         * MAINTAINERS (Write After Approval): Add myself.
3851
3852 2019-05-17  Tom de Vries  <tdevries@suse.de>
3853
3854         PR gdb/24094
3855         * dwarf2read.c (struct cu_partial_die_info): New struct.
3856         (find_partial_die): Return cu_partial_die_info.
3857         (partial_die_parent_scope, guess_partial_die_structure_name)
3858         (partial_die_info::fixup): Handle new return type of find_partial_die.
3859
3860 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3861
3862         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3863         "std::string", simplifying the algorithm.
3864
3865 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3866
3867         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3868         (stap_static_probe_ops::get_probes): Likewise.
3869
3870 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3871
3872         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3873         '-')" and "else if".
3874         (stap_parse_single_operand): Join checks for
3875         "gdbarch_stap_parse_special_token_p" and
3876         "gdbarch_stap_parse_special_token" in the same "if" statement.
3877         Invert check when verifying for operation on register
3878         displacement.
3879
3880 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3881
3882         * stap-probe.c (stap_get_opcode): Update comment.
3883         (stap_get_expected_argument_type): Likewise.
3884         (handle_stap_probe): Likewise.
3885
3886 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3887
3888         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3889         return type to 'bool'.  Adjust comment.  Use 'bool' when
3890         appropriate.
3891         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3892         * stap-probe.c (stap_parse_argument_1): Likewise.
3893         (stap_is_operator): Likewise.
3894         (stap_is_generic_prefix): Likewise.
3895         (stap_is_register_prefix): Likewise.
3896         (stap_is_register_indirection_prefix): Likewise.
3897         (stap_is_integer_prefix): Likewise.
3898         (stap_generic_check_suffix): Likewise.
3899         (stap_check_integer_suffix): Likewise.
3900         (stap_check_register_suffix): Likewise.
3901         (stap_check_register_indirection_suffix): Likewise.
3902         (stap_parse_register_operand): Likewise.
3903         (stap_parse_single_operand): Likewise.
3904         (stap_parse_argument_1): Likewise.
3905         (stap_probe::get_argument_count): Likewise.
3906         (stap_is_operator): Likewise.
3907
3908 2019-05-16  Tom Tromey  <tromey@adacore.com>
3909
3910         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3911         keyword to foreach.
3912
3913 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3914
3915         * linux-thread-db.c (try_thread_db_load_1): Change return type
3916         to bool.
3917         (try_thread_db_load): Likewise.
3918         (try_thread_db_load_from_pdir_1): Likewise.
3919         (try_thread_db_load_from_pdir): Likewise.
3920         (try_thread_db_load_from_sdir): Likewise.
3921         (try_thread_db_load_from_dir): Likewise.
3922         (thread_db_load_search): Likewise.
3923         (has_libpthread): Likewise.
3924         (thread_db_load): Likewise.
3925
3926 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3927
3928         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3929         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3930         NULL, and complain/return if that's the case.
3931
3932 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3933
3934         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3935         (advance, posn, abstract_read_memory): New functions.
3936         [struct mem_read_abstraction]: New struct.
3937         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3938
3939 2019-05-14  Tom Tromey  <tromey@adacore.com>
3940
3941         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3942         value is not lval_memory.
3943
3944 2019-05-14  Tom Tromey  <tromey@adacore.com>
3945
3946         * solib.c (info_sharedlibrary_command): Style the file name.
3947
3948 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3949
3950         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3951         (aarch64_vnv_type): Likewise.
3952         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3953         * common/tdesc.c: Likewise.
3954         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3955         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3956         * features/aarch64-fpu.xml: Add ieee half view.
3957         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3958         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3959         * gdbtypes.h (struct builtin_type): Likewise.
3960         (struct objfile_type): Likewise.
3961
3962 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3963
3964         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3965         typo.
3966         * location.h (string_to_event_location): Likewise.
3967
3968 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3969
3970         GDB 8.3 released.
3971
3972 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3973
3974         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3975         New variable declaration.
3976         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3977         New variable.
3978         (print_one_breakpoint): Use ui_out::test_flags and new global
3979         variable to compute use_fixed_output.
3980         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3981         Remove.
3982         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3983         (mi_multi_location_breakpoint_output_fixed): Remove.
3984         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3985         new variable.
3986         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3987         fix_multi_location_breakpoint_output flag if version >= 3.
3988         * ui-out.h (enum ui_out_flag)
3989         <fix_multi_location_breakpoint_output>: New enumerator.
3990
3991 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3992
3993         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3994
3995 2019-05-10  Tom Tromey  <tromey@adacore.com>
3996
3997         * ada-lang.c (catch_ada_completer): New function.
3998         (_initialize_ada_language): Use it.
3999
4000 2019-05-10  Tom Tromey  <tromey@adacore.com>
4001
4002         * thread.c (print_thread_info): Make "requested_threads" const.
4003         * gdbthread.h (print_thread_info): Make "requested_threads"
4004         const.
4005         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4006         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4007
4008 2019-05-08  Tom Tromey  <tom@tromey.com>
4009
4010         * gdbtypes.c (objfile_type_data): Change type.
4011         (objfile_type, _initialize_gdbtypes): Update.
4012
4013 2019-05-08  Tom Tromey  <tom@tromey.com>
4014
4015         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4016         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4017         (_initialize_dwarf2_frame): Update.
4018
4019 2019-05-08  Tom Tromey  <tom@tromey.com>
4020
4021         * objc-lang.c (objc_objfile_data): Change type.
4022         (find_methods): Update.
4023         (_initialize_objc_lang): Remove.
4024
4025 2019-05-08  Tom Tromey  <tom@tromey.com>
4026
4027         * stabsread.c (rs6000_builtin_type_data): Change type.
4028         (rs6000_builtin_type, _initialize_stabsread): Update.
4029
4030 2019-05-08  Tom Tromey  <tom@tromey.com>
4031
4032         * mips-tdep.c (mips_pdr_data): Remove.
4033         (_initialize_mips_tdep): Update.
4034
4035 2019-05-08  Tom Tromey  <tom@tromey.com>
4036
4037         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4038         (hppa_init_objfile_priv_data, read_unwind_info)
4039         (find_unwind_entry, _initialize_hppa_tdep): Update.
4040
4041 2019-05-08  Tom Tromey  <tom@tromey.com>
4042
4043         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4044         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4045         on obstack.
4046         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4047
4048 2019-05-08  Tom Tromey  <tom@tromey.com>
4049
4050         * mdebugread.c (basic_type_data): Change type.
4051         (basic_type, _initialize_mdebugread): Update.
4052
4053 2019-05-08  Tom Tromey  <tom@tromey.com>
4054
4055         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4056
4057 2019-05-08  Tom Tromey  <tom@tromey.com>
4058
4059         * nto-tdep.c (nto_inferior_data_reg): Change type.
4060         (nto_inferior_data): Update.
4061         (nto_inferior_data_cleanup, nto_new_inferior_data)
4062         (_initialize_nto_tdep): Remove.
4063         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4064
4065 2019-05-08  Tom Tromey  <tom@tromey.com>
4066
4067         * ada-lang.c (struct ada_inferior_data): Add initializers.
4068         (ada_inferior_data): Change type.
4069         (ada_inferior_data_cleanup): Remove.
4070         (get_ada_inferior_data, ada_inferior_exit)
4071         (struct ada_pspace_data): Add initializers, destructor.
4072         (ada_pspace_data_handle): Change type.
4073         (get_ada_pspace_data): Update.
4074         (ada_pspace_data_cleanup): Remove.
4075
4076 2019-05-08  Tom Tromey  <tom@tromey.com>
4077
4078         * coffread.c (struct coff_symfile_info): Add initializers.
4079         (coff_objfile_data_key): Move lower.  Change type.
4080         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4081         Update.
4082         (coff_free_info): Remove.
4083
4084 2019-05-08  Tom Tromey  <tom@tromey.com>
4085
4086         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4087         (fbsd_pspace_data_handle): Move lower.  Change type.
4088         (get_fbsd_pspace_data): Update.
4089         (fbsd_pspace_data_cleanup): Remove.
4090         (_initialize_fbsd_tdep): Update.
4091
4092 2019-05-08  Tom Tromey  <tom@tromey.com>
4093
4094         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4095         (get_ada_tasks_pspace_data): Update.
4096         (ada_tasks_pspace_data_cleanup): Remove.
4097         (_initialize_tasks): Update.
4098         (ada_tasks_inferior_data_handle): Change type.
4099         (get_ada_tasks_inferior_data): Update.
4100         (ada_tasks_inferior_data_cleanup): Remove.
4101         (struct ada_tasks_pspace_data): Add initializers.
4102
4103 2019-05-08  Tom Tromey  <tom@tromey.com>
4104
4105         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4106         * symfile-debug.c (debug_sym_get_probes): Change type.
4107         * stap-probe.c (handle_stap_probe):
4108         (stap_static_probe_ops::get_probes): Change type.
4109         * probe.h (class static_probe_ops) <get_probes>: Change type.
4110         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4111         (parse_probes_in_pspace): Update.
4112         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4113         Update.
4114         (any_static_probe_ops::get_probes): Change type.
4115         * elfread.c (elfread_data): New typedef.
4116         (probe_key): Change type.
4117         (elf_get_probes): Likewise.  Update.
4118         (probe_key_free): Remove.
4119         (_initialize_elfread): Update.
4120         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4121         Change type.
4122         (dtrace_process_dof_probe, dtrace_process_dof)
4123         (dtrace_static_probe_ops::get_probe): Change type.
4124
4125 2019-05-08  Tom Tromey  <tom@tromey.com>
4126
4127         * xcoffread.c (struct xcoff_symfile_info): Rename from
4128         coff_symfile_info.  Add initializers.
4129         (xcoff_objfile_data_key): Move lower.  Change type.
4130         (XCOFF_DATA): Rewrite.
4131         (xcoff_free_info): Remove.
4132         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4133         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4134         (xcoff_initial_scan): Update.
4135
4136 2019-05-08  Tom Tromey  <tom@tromey.com>
4137
4138         * solib-svr4.c (struct svr4_info): Add initializers and
4139         destructor.
4140         <probes_table>: Now an htab_up.
4141         (solib_svr4_pspace_data): Change type.
4142         (free_probes_table): Simplify.
4143         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4144         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4145         (probes_table_remove_objfile_probes, register_solib_event_probe)
4146         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4147         (_initialize_svr4_solib): Update.
4148
4149 2019-05-08  Tom Tromey  <tom@tromey.com>
4150
4151         * remote.c (remote_pspace_data): Change type.
4152         (remote_pspace_data_cleanup): Remove.
4153         (get_remote_exec_file, set_pspace_remote_exec_file)
4154         (_initialize_remote): Update.
4155
4156 2019-05-08  Tom Tromey  <tom@tromey.com>
4157
4158         * breakpoint.c (breakpoint_objfile_key): Change type.
4159         (get_breakpoint_objfile_data): Update.
4160         (free_breakpoint_objfile_data): Remove.
4161         (_initialize_breakpoint): Update.
4162
4163 2019-05-08  Tom Tromey  <tom@tromey.com>
4164
4165         * linux-tdep.c (struct linux_info): Add initializers.
4166         (linux_inferior_data): Move.  Change type.
4167         (invalidate_linux_cache_inf): Update.
4168         (linux_inferior_data_cleanup): Remove.
4169         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4170
4171 2019-05-08  Tom Tromey  <tom@tromey.com>
4172
4173         * auxv.c (auxv_inferior_data): Move.  Change type.
4174         (auxv_inferior_data_cleanup): Remove.
4175         (invalidate_auxv_cache_inf): Rewrite.
4176         (get_auxv_inferior_data, _initialize_auxv): Update.
4177
4178 2019-05-08  Tom Tromey  <tom@tromey.com>
4179
4180         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4181         (symfile_debug_objfile_data_key): Change type.
4182         (symfile_debug_installed, debug_qf_has_symbols)
4183         (debug_qf_find_last_source_symtab)
4184         (debug_qf_forget_cached_source_info)
4185         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4186         (debug_qf_print_stats, debug_qf_dump)
4187         (debug_qf_expand_symtabs_for_function)
4188         (debug_qf_expand_all_symtabs)
4189         (debug_qf_expand_symtabs_with_fullname)
4190         (debug_qf_map_matching_symbols)
4191         (debug_qf_expand_symtabs_matching)
4192         (debug_qf_find_pc_sect_compunit_symtab)
4193         (debug_qf_map_symbol_filenames)
4194         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4195         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4196         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4197         (debug_sym_read_linetable, debug_sym_relocate): Update.
4198         (symfile_debug_free_objfile): Remove.
4199         (install_symfile_debug_logging, _initialize_symfile_debug):
4200         Update.
4201
4202 2019-05-08  Tom Tromey  <tom@tromey.com>
4203
4204         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4205         allocate_on_obstack.
4206         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4207         (get_dwarf2_per_objfile): Update.
4208         (set_dwarf2_per_objfile): Remove.
4209         (dwarf2_has_info, dwarf2_get_section_info): Update.
4210         (dwarf2_free_objfile): Remove.
4211         (_initialize_dwarf2_read): Update.
4212
4213 2019-05-08  Tom Tromey  <tom@tromey.com>
4214
4215         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4216         initializers.
4217         <unsupported_script_warning_printed,
4218         script_not_found_warning_printed>: Now bool.
4219         (auto_load_pspace_data): Change type.
4220         (~auto_load_pspace_info): Rename from
4221         auto_load_pspace_data_cleanup.
4222         (get_auto_load_pspace_data, init_loaded_scripts_info)
4223         (clear_section_scripts, maybe_print_unsupported_script_warning)
4224         (maybe_print_script_not_found_warning, _initialize_auto_load):
4225         Update.
4226
4227 2019-05-08  Tom Tromey  <tom@tromey.com>
4228
4229         * objfiles.c (objfile_pspace_info): Add destructor and
4230         initializers.
4231         (objfiles_pspace_data): Change type.
4232         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4233         (get_objfile_pspace_data): Update.
4234         (objfiles_bfd_data): Change type.
4235         (get_objfile_bfd_data): Update.
4236         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4237
4238 2019-05-08  Tom Tromey  <tom@tromey.com>
4239
4240         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4241         Change type.
4242         (get_catch_syscall_inferior_data): Update.
4243         (catch_syscall_inferior_data_cleanup): Remove.
4244         (_initialize_break_catch_syscall): Update.
4245
4246 2019-05-08  Tom Tromey  <tom@tromey.com>
4247
4248         * inflow.c (struct terminal_info): Add destructor and
4249         initializers.
4250         (inflow_inferior_data): Change type.
4251         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4252         (get_inflow_inferior_data, inflow_inferior_exit)
4253         (swap_terminal_info, _initialize_inflow): Update.
4254
4255 2019-05-08  Tom Tromey  <tom@tromey.com>
4256
4257         * target-dcache.c (target_dcache_cleanup): Remove.
4258         (target_dcache_aspace_key): Change type.
4259         (target_dcache_init_p, target_dcache_invalidate)
4260         (target_dcache_get, target_dcache_get_or_init)
4261         (_initialize_target_dcache): Update.
4262         * dcache.h (struct dcache_deleter): New.
4263
4264 2019-05-08  Tom Tromey  <tom@tromey.com>
4265
4266         * symtab.c (struct symbol_cache): Add destructor and
4267         initializers.
4268         (symbol_cache_key): Move.  Change type.
4269         (make_symbol_cache, free_symbol_cache): Remove.
4270         (get_symbol_cache): Update.
4271         (symbol_cache_cleanup): Remove.
4272         (ALL_PSPACES, symbol_cache_flush)
4273         (maintenance_print_symbol_cache)
4274         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4275         Update.
4276
4277 2019-05-08  Tom Tromey  <tom@tromey.com>
4278
4279         * symtab.c (struct main_info): Add destructor and initializers.
4280         (main_progspace_key): Move.  Change type.
4281         (get_main_info): Update.
4282         (main_info_cleanup): Remove.
4283         (_initialize_symtab): Update.
4284
4285 2019-05-08  Tom Tromey  <tom@tromey.com>
4286
4287         * registry.h (DECLARE_REGISTRY): Define the _key class.
4288
4289 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4290
4291         * NEWS: Merge two 'New commands' sections.
4292
4293 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4294
4295         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4296         parameter and use Ada language definition instead.
4297         (ada_val_print_ptr): Remove unused language parameter.
4298         (ada_val_print_num): Remove language parameter and use Ada language
4299         definition instead.
4300         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4301         parameter.
4302         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4303         parameter and use Ada language definition instead.
4304         (ada_val_print_1): Update all ada_val_print_xxx calls.
4305         Remove language parameter.
4306         (ada_val_print): Update ada_val_print_1 call.
4307
4308 2019-05-08  Tom Tromey  <tromey@adacore.com>
4309
4310         * remote.c (remote_hw_watchpoint_limit)
4311         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4312         Now static.
4313
4314 2019-05-08  Tom Tromey  <tromey@adacore.com>
4315
4316         * maint.c (_initialize_maint_cmds): Move initialization code to
4317         remote.c.
4318         (watchdog, show_watchdog): Move to remote.c.
4319         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4320         "watchdog" static.
4321         (_initialize_remote): Move initialization code from maint.c.
4322         * defs.h (watchdog): Don't declare.
4323
4324 2019-05-08  Tom Tromey  <tromey@adacore.com>
4325
4326         * tui/tui-interp.c: Include main.h.
4327         * interps.c: Include main.h.
4328         * main.h (interpreter_p): Declare.
4329         * defs.h (interpreter_p): Don't declare.
4330
4331 2019-05-08  Tom Tromey  <tromey@adacore.com>
4332
4333         * dwarf2loc.c: Include dwarf2read.h.
4334         * defs.h (read_unsigned_leb128): Don't declare.
4335         * dwarf2read.h (read_unsigned_leb128): Declare.
4336
4337 2019-05-08  Tom Tromey  <tromey@adacore.com>
4338
4339         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4340         method.
4341
4342 2019-05-08  Tom Tromey  <tromey@adacore.com>
4343
4344         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4345         when no wrap column is set.
4346
4347 2019-05-08  Tom Tromey  <tromey@adacore.com>
4348
4349         * c-lang.c (c_get_string): Handle non-C-style arrays.
4350
4351 2019-05-08  Tom Tromey  <tromey@adacore.com>
4352
4353         * typeprint.c (print_offset_data::update): Print the bit offset,
4354         not the number of bits remaining.
4355
4356 2019-05-08  Tom Tromey  <tromey@adacore.com>
4357
4358         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4359         padding at end of comment.
4360
4361 2019-05-08  Tom Tromey  <tromey@adacore.com>
4362
4363         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4364         Compare main types.
4365
4366 2019-05-06  Tom Tromey  <tom@tromey.com>
4367
4368         * common/scoped_mmap.c: Include common-defs.h.
4369         * common/scoped_mmap.h: Don't include config.h.
4370
4371 2019-05-04  Tom Tromey  <tom@tromey.com>
4372
4373         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4374         (struct aarch64_call_info): Add initializers.
4375         <si>: Now a std::vector.
4376         (pass_on_stack, aarch64_push_dummy_call): Update.
4377
4378 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4379             Tom Tromey  <tom@tromey.com>
4380
4381         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4382         (ppc_threads): Now a std::vector.  Now static.
4383         (hwdebug_find_thread_points_by_tid)
4384         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4385         Update.
4386
4387 2019-05-04  Tom Tromey  <tom@tromey.com>
4388
4389         * arc-tdep.c (arc_tdesc_init): Return bool.
4390
4391 2019-05-04  Tom Tromey  <tom@tromey.com>
4392
4393         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4394         Use gdb_assert_not_reached.
4395
4396 2019-05-04  Tom Tromey  <tom@tromey.com>
4397
4398         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4399         "false".
4400
4401 2019-05-04  Tom Tromey  <tom@tromey.com>
4402
4403         * arc-tdep.c (arc_tdesc_init): Use bool.
4404
4405 2019-05-04  Tom Tromey  <tom@tromey.com>
4406
4407         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4408
4409 2019-05-04  Tom Tromey  <tom@tromey.com>
4410
4411         * cli/cli-cmds.c (valid_command_p): Return bool.
4412
4413 2019-05-04  Tom Tromey  <tom@tromey.com>
4414
4415         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4416         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4417
4418 2019-05-04  Raul Tambre  <raul@tambre.ee>
4419
4420         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4421         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4422         operator for comparison.
4423
4424 2019-05-04  Tom Tromey  <tom@tromey.com>
4425
4426         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4427         (lookup_partial_symbol, print_partial_symbols)
4428         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4429         (psymbol_compare): Update.
4430         (add_psymbol_to_bcache): Clear the entire psymbol.
4431         (maintenance_check_psymtabs): Update.
4432         * psympriv.h (struct partial_symbol): Don't derive from
4433         general_symbol_info.
4434         <obj_section, unrelocated_address, address,
4435         set_unrelocated_address>: Update.
4436         <ginfo>: New member.
4437         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4438         (debug_names::write_psymbols): Update.
4439
4440 2019-05-04  Tom de Vries  <tdevries@suse.de>
4441
4442         * contrib/cc-with-tweaks.sh: Support -n arg.
4443
4444 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4445
4446         * corelow.c (core_target::detach): Ensure frame cache and
4447         register caches are cleared.
4448         inferior.c (exit_inferior_1): Likewise.
4449
4450 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4451             Tom Tromey  <tom@tromey.com>
4452
4453         * dictionary.c (collate_pending_symbols_by_language): Remove
4454         "struct" from foreach.
4455         * symtab.c (lookup_global_symbol_from_objfile)
4456         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4457         foreach.
4458         * ser-tcp.c (net_open): Remove "struct" from foreach.
4459         * objfiles.c (objfile_relocate, objfile_rebase)
4460         (objfile_has_symbols): Remove "struct" from foreach.
4461         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4462         from foreach.
4463         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4464         foreach.
4465         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4466         "struct" from foreach.
4467         * ada-lang.c (create_excep_cond_exprs)
4468         (ada_exception_catchpoint_cond_string): Remove "struct" from
4469         foreach.
4470
4471 2019-05-03  Tom Tromey  <tromey@adacore.com>
4472
4473         * ada-exp.y (convert_char_literal): Check suffix of each
4474         enumerator.
4475
4476 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4477
4478         PR ada/21406:
4479         * ada-exp.y (yywrap): Don't define.
4480         * ada-lex.l (%option): Add noyywrap
4481         (yywrap): Remove.
4482
4483 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4484
4485         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4486         _WIN32_WINNT to the XP level, unless already defined to a higher
4487         level.
4488
4489         * unittests/parse-connection-spec-selftests.c:
4490         * ser-tcp.c:
4491         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4492         override.
4493
4494         * symfile.c (find_separate_debug_file): Remove colon from the
4495         drive spec of DOS/Windows file names of the target, so that the
4496         file name produced from DEBUGDIR and the target's directory will
4497         be valid on DOS/Windows systems.
4498
4499 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4500
4501         * rust-lang.c (val_print_struct): Handle printing structures
4502         containing strings.
4503
4504 2019-05-02  Tom Tromey  <tromey@adacore.com>
4505
4506         * valarith.c (_initialize_valarith): Remove.
4507
4508 2019-05-01  Tom Tromey  <tromey@adacore.com>
4509
4510         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4511         bitfields.
4512
4513 2019-05-01  Tom Tromey  <tromey@adacore.com>
4514
4515         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4516         for big-endian copies.
4517
4518 2019-04-30  Ali Tamur  <tamur@google.com>
4519         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4520         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4521         (read_3_bytes): New function.
4522
4523 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4524
4525         * windows-nat.c (main_thread_id): Delete.
4526         (handle_output_debug_string): Replace main_thread_id by
4527         current_event.dwThreadId.
4528         (fake_create_process): Likewise.
4529         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4530         Do not set main_thread_id.
4531         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4532         current_event.dwThreadId.
4533         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4534
4535 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4536
4537         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4538         Use current_event.dwThreadId instead of main_thread_id.
4539
4540 2019-04-30  Tom Tromey  <tromey@adacore.com>
4541
4542         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4543         (create_excep_cond_exprs): Iterate over program spaces.
4544         (ada_exception_catchpoint_cond_string): Examine all minimal
4545         symbols for exception types.
4546
4547 2019-04-30  Tom Tromey  <tromey@adacore.com>
4548
4549         PR c++/24470:
4550         * dwarf2read.c (process_structure_scope): Handle case where type
4551         has template parameters but no symbol was created.
4552
4553 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4554             Chris January  <chris.january@arm.com>
4555
4556         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4557         qualifier.
4558         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4559
4560 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4561
4562         * f-typeprint.c (f_print_type): Update rules for printing
4563         whitespace.
4564         (f_type_print_varspec_suffix): Likewise.
4565
4566 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4567             Chris January  <chris.january@arm.com>
4568
4569         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4570         function arguments.
4571
4572 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4573
4574         * f-lang.c (build_fortran_types): Change name of void type to
4575         lower case.
4576         * f-typeprint.c (f_type_print_base): Print the name of the void
4577         type, rather than a fixed string.
4578         * f-valprint.c (f_decorations): Use lower case void string.
4579
4580 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4581             Chris January  <chris.january@arm.com>
4582
4583         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4584         types for Fortran.
4585
4586 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4587             Chris January  <chris.january@arm.com>
4588             David Lecomber  <david.lecomber@arm.com>
4589
4590         * f-exp.y (BINOP_INTRINSIC): New token.
4591         (exp): New parser rule handling BINOP_INTRINSIC.
4592         (f77_keywords): Add new builtin procedures.
4593         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4594         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4595         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4596         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4597         (print_unop_subexp_f): New function.
4598         (print_binop_subexp_f): New function.
4599         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4600         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4601         (dump_subexp_body_f): Likewise.
4602         (operator_check_f): Likewise.
4603         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4604         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4605
4606 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4607
4608         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4609         UNOP_KIND.
4610         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4611         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4612         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4613         (operator_length_f): New fuction.
4614         (print_subexp_f): New function.
4615         (op_name_f): New function.
4616         (dump_subexp_body_f): New function.
4617         (operator_check_f): New function.
4618         (exp_descriptor_f): Replace standard expression handling functions
4619         with new functions.
4620         * gdb/fortran-operator.def: New file.
4621         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4622         * gdb/std-operator.def: Remove UNOP_KIND.
4623
4624 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4625
4626         * std-operator.def: Remove unbalanced, stray double quote
4627         character.
4628
4629 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4630             Chris January  <chris.january@arm.com>
4631             Daniel Everett  <daniel.everett@arm.com>
4632             Nick Forrington  <nick.forrington@arm.com>
4633             Richard Bunt  <richard.bunt@arm.com>
4634
4635         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4636         of depth when printing anonymous structs or unions.
4637         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4638         Don't print either the top-level value, or the children if the
4639         max-depth is exceeded.
4640         (ppscm_print_children): When printing the key of a map, allow one
4641         extra level of depth.
4642         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4643         print either the top-level value, or the children if the max-depth
4644         is exceeded.
4645         (print_children): When printing the key of a map, allow one extra
4646         level of depth.
4647         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4648         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4649         (user_print_options): Initialise max_depth field.
4650         (val_print_scalar_or_string_type_p): New function.
4651         (val_print): Check to see if the max depth has been reached.
4652         (val_print_check_max_depth): Define new function.
4653         (show_print_max_depth): New function.
4654         (_initialize_valprint): Add 'print max-depth' option.
4655         * valprint.h (struct value_print_options) <max_depth>: New field.
4656         (val_print_check_max_depth): Declare new function.
4657         * NEWS: Document new feature.
4658
4659 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4660
4661         * ada-lang.c (ada_language_defn): Initialise new field.
4662         * c-lang.c (c_is_string_type_p): New function.
4663         (c_language_defn): Initialise new field.
4664         (cplus_language_defn): Initialise new field.
4665         (asm_language_defn): Initialise new field.
4666         (minimal_language_defn): Initialise new field.
4667         * c-lang.h (c_is_string_type_p): Declare new function.
4668         * d-lang.c (d_language_defn): Initialise new field.
4669         * f-lang.c (f_is_string_type_p): New function.
4670         (f_language_defn): Initialise new field.
4671         * go-lang.c (go_is_string_type_p): New function.
4672         (go_language_defn): Initialise new field.
4673         * language.c (default_is_string_type_p): New function.
4674         (unknown_language_defn): Initialise new field.
4675         (auto_language_defn): Initialise new field.
4676         * language.h (struct language_defn) <la_is_string_type_p>: New
4677         member variable.
4678         (default_is_string_type_p): Declare new function.
4679         * m2-lang.c (m2_language_defn): Initialise new field.
4680         * objc-lang.c (objc_language_defn): Initialise new field.
4681         * opencl-lang.c (opencl_language_defn): Initialise new field.
4682         * p-lang.c (pascal_is_string_type_p): New function.
4683         (pascal_language_defn): Initialise new field.
4684         * rust-lang.c (rust_is_string_type_p): New function.
4685         (rust_language_defn): Initialise new field.
4686
4687 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4688
4689         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4690         New field.
4691         * ada-lang.c (ada_language_defn): Initialise new field.
4692         * c-lang.c (c_language_defn): Likewise.
4693         (cplus_language_defn): Likewise.
4694         (asm_language_defn): Likewise.
4695         (minimal_language_defn): Likewise.
4696         * d-lang.c (d_language_defn): Likewise.
4697         * f-lang.c (f_language_defn): Likewise.
4698         * go-lang.c (go_language_defn): Likewise.
4699         * language.c (unknown_language_defn): Likewise.
4700         (auto_language_defn): Likewise.
4701         * m2-lang.c (m2_language_defn): Likewise.
4702         * objc-lang.c (objc_language_defn): Likewise.
4703         * opencl-lang.c (opencl_language_defn): Likewise.
4704         * p-lang.c (pascal_language_defn): Likewise.
4705         * rust-lang.c (rust_language_defn): Likewise.
4706
4707 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4708
4709         * ada-lang.c (ada_is_character_type): Change return type to bool.
4710         (ada_is_string_type): Likewise.
4711         * ada-lang.h (ada_is_character_type): Update declaration
4712         (ada_is_string_type): Likewise.
4713
4714 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4715
4716         Support style in 'frame|thread apply'
4717
4718         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4719         * record.c (record_start, record_stop): Update callers of
4720         execute_command_to_string with false.
4721         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4722         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4723         methods.
4724         (class string_file): New constructor with term_out parameter.
4725         Override methods term_out and can_emit_style_escape.  New member
4726         term_out.
4727         (class stdio_file): Override can_emit_style_escape.
4728         (class tee_file): Override term_out and can_emit_style_escape.
4729         * utils.h (can_emit_style_escape): Remove.
4730         * utils.c (can_emit_style_escape): Likewise.
4731         Update all callers of can_emit_style_escape (SOMESTREAM) to
4732         SOMESTREAM->can_emit_style_escape.
4733         * source-cache.c (source_cache::get_source_lines): Likewise.
4734         * stack.c (frame_apply_command_count): Call execute_command_to_string
4735         passing the term_out characteristic of the current gdb_stdout.
4736         * thread.c (thr_try_catch_cmd): Likewise.
4737         * top.c (execute_command_to_string): pass term_out parameter
4738         to construct the string_file for the command output.
4739         * ui-file.c (term_cli_styling): New function (most code moved
4740         from utils.c can_emit_style_escape).
4741         (string_file::string_file, string_file::can_emit_style_escape,
4742         stdio_file::can_emit_style_escape, tee_file::term_out,
4743         tee_file::can_emit_style_escape): New functions.
4744
4745 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4746
4747         * NEWS: Mention the new set|show may-call-functions.
4748         * infcall.c (may_call_functions_p): New variable.
4749         (show_may_call_functions_p): New function.
4750         (call_function_by_hand_dummy): Throws an error if not
4751         may-call-functions.
4752         (_initialize_infcall): Call add_setshow_boolean_cmd for
4753         may-call-functions.
4754
4755 2019-04-25  Keith Seitz  <keiths@redhat.com>
4756
4757         PR c++/24367
4758         * cp-support.c (inspect_type): Don't attempt substitutions
4759         of symbol with the same name.
4760
4761 2019-04-25  Tom Tromey  <tromey@adacore.com>
4762
4763         PR gdb/24475:
4764         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4765         static.
4766
4767 2019-04-25  Tom Tromey  <tromey@adacore.com>
4768
4769         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4770         rvalue reference.
4771         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4772         (gdb_xml_parser::parse): Use std::move.
4773         * python/python-internal.h (gdbpy_convert_exception): Take a const
4774         reference.
4775         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4776         std::move.
4777         * python/py-utils.c (gdbpy_convert_exception): Take a const
4778         reference.
4779         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4780         Use std::move.
4781         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4782         Use std::move.
4783         * mi/mi-main.c (mi_print_exception): Take a const reference.
4784         * main.c (handle_command_errors): Take a const reference.
4785         * linespec.c (parse_linespec): Use std::move.
4786         * infcall.c (run_inferior_call): Use std::move.
4787         (call_function_by_hand_dummy): Use std::move.
4788         * exec.c (try_open_exec_file): Use std::move.
4789         * exceptions.h (exception_print, exception_fprintf)
4790         (exception_print_same): Update.
4791         * exceptions.c (print_exception, exception_print)
4792         (exception_fprintf, exception_print_same): Change parameters to
4793         const reference.
4794         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4795         * common/new-op.c: Use std::move.
4796         * common/common-exceptions.h (struct gdb_exception): Add move
4797         constructor.
4798         (struct gdb_exception_error, struct gdb_exception_quit, struct
4799         gdb_quit_bad_alloc): Change constructor to move constructor.
4800         (throw_exception): Change parameter to rvalue reference.
4801         * common/common-exceptions.c (throw_exception): Take rvalue
4802         reference.
4803         * cli/cli-interp.c (safe_execute_command): Use std::move.
4804         * breakpoint.c (insert_bp_location, location_to_sals): Use
4805         std::move.
4806
4807 2019-04-25  Tom Tromey  <tromey@adacore.com>
4808
4809         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4810         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4811         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4812         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4813         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4814         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4815         guile/scm-value.c: Use unpack.
4816         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4817         gdbscm_gdb_exception.
4818         (gdbscm_throw_gdb_exception): Likewise.
4819         (struct gdbscm_gdb_exception): New.
4820         (unpack): New function.
4821         (gdbscm_wrap): Use unpack.
4822
4823 2019-04-25  Tom Tromey  <tromey@adacore.com>
4824
4825         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4826         (gdb_rl_callback_handler): Use std::move.
4827         * common/common-exceptions.h (struct gdb_exception): Add move
4828         assignment operator.
4829         (throw_exception_sjlj): Change "exception" to const reference.
4830         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4831         (throw_exception_sjlj): Change "exception" to const reference.
4832
4833 2019-04-25  Tom Tromey  <tromey@adacore.com>
4834
4835         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4836         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4837         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4838         Update.
4839         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4840         Update.
4841         * mi/mi-interp.c (mi_interp::exec): Update.
4842         * linespec.c (parse_linespec): Update.
4843         * infcall.c (run_inferior_call): Update.
4844         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4845         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4846         (gdbscm_lookup_global_symbol): Update.
4847         * guile/scm-param.c (gdbscm_parameter_value): Update.
4848         * guile/scm-frame.c (gdbscm_frame_read_register)
4849         (gdbscm_frame_read_var): Update.
4850         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4851         * exec.c (try_open_exec_file): Update.
4852         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4853         (gdb_rl_callback_handler): Update.
4854         * common/common-exceptions.h (exception_none): Don't declare.
4855         * common/common-exceptions.c (exception_none): Don't define.
4856         (struct catcher) <exception>: Update.
4857         * cli/cli-interp.c (safe_execute_command): Update.
4858         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4859
4860 2019-04-25  Ali Tamur  <tamur@google.com>
4861
4862         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4863         (read_attribute_value): Likewise.
4864         (dwarf2_read_addr_index): Update comment.
4865         (read_str_index): Add DW_FORM_strx.
4866         (dwarf2_string_attr): Likewise.
4867         (dwarf2_const_value_attr): Likewise.
4868         (dump_die_shallow): Likewise.
4869         (dwarf2_fetch_constant_bytes): Likewise.
4870         (skip_form_bytes): Likewise.
4871         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4872
4873 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4874
4875         PR corefiles/11608
4876         PR corefiles/18187
4877         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4878         OFFSET.  Verify if current mapping contains an ELF header.
4879         (linux_find_memory_regions_full): Adjust call to
4880         dump_mapping_p.
4881
4882 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4883             Kang Li <kanglictf@gmail.com>
4884
4885         PR gdb/21600
4886
4887         * dwarf2-frame.c (read_initial_length): Be consistent about using
4888         unsigned representation of length.
4889         (decode_frame_entry_1): Likewise.  Check for wraparound of
4890         end pointer as well as buffer overflow.
4891
4892 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4893
4894         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4895         "vq".
4896
4897 2019-04-24  Tom Tromey  <tromey@adacore.com>
4898
4899         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4900
4901 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4902
4903         * s12z-tdep.c (s12z_unwind_pc): Delete.
4904         (s12z_unwind_sp): Delete.
4905         (s12z_gdbarch_init): Don't register deleted functions with
4906         gdbarch.
4907
4908 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4909
4910         * rl78-tdep.c (rl78_unwind_sp): Delete.
4911         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4912
4913 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4914
4915         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4916         (xstormy16_unwind_pc): Delete.
4917         (xstormy16_dummy_id): Delete.
4918         (xstormy16_gdbarch_init): Don't register deleted functions with
4919         gdbarch.
4920
4921 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4922
4923         * vax-tdep.c (vax_unwind_pc): Delete.
4924         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4925
4926 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4927
4928         * v850-tdep.c (v850_unwind_sp): Delete.
4929         (v850_unwind_pc): Delete.
4930         (v850_dummy_id): Delete.
4931         (v850_gdbarch_init): Don't register deleted functions with
4932         gdbarch.
4933
4934 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4935
4936         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4937         (tilegx_unwind_pc): Delete.
4938         (tilegx_unwind_dummy_id): Delete.
4939         (tilegx_gdbarch_init): Don't register deleted functions with
4940         gdbarch.
4941
4942 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4943
4944         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4945         (tic6x_dummy_id): Delete.
4946         (tic6x_gdbarch_init): Don't register deleted functions with
4947         gdbarch.
4948
4949 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4950
4951         * sparc-tdep.c (sparc_unwind_pc): Delete.
4952         (sparc32_gdbarch_init): Don't register deleted function with
4953         gdbarch.
4954
4955 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4956
4957         * sh-tdep.c (sh_unwind_sp): Delete.
4958         (sh_unwind_pc): Delete.
4959         (sh_dummy_id): Delete.
4960         (sh_gdbarch_init): Don't register deleted functions with
4961         gdbarch.
4962
4963 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4964
4965         * score-tdep.c (score_unwind_sp): Delete.
4966         (score_unwind_pc): Delete.
4967         (score_dummy_id): Delete.
4968         (score_gdbarch_init): Don't register deleted functions with
4969         gdbarch.
4970
4971 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4972
4973         * rx-tdep.c (rx_unwind_pc): Delete.
4974         (rx_unwind_sp): Delete.
4975         (rx_dummy_id): Delete.
4976         (rx_gdbarch_init): Don't register deleted functions with
4977         gdbarch.  Update comment.
4978
4979 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4980
4981         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4982         (rs6000_dummy_id): Delete.
4983         (rs6000_gdbarch_init): Don't register deleted functions with
4984         gdbarch.
4985
4986 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4987
4988         * or1k-tdep.c (or1k_dummy_id): Delete.
4989         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4990
4991 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4992
4993         * nios2-tdep.c (nios2_dummy_id): Delete.
4994         (nios2_unwind_sp): Delete.
4995         (nios2_gdbarch_init): Don't register deleted functions with
4996         gdbarch.
4997
4998 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4999
5000         * nds32-tdep.c (nds32_dummy_id): Delete.
5001         (nds32_unwind_pc): Delete.
5002         (nds32_unwind_sp): Delete.
5003         (nds32_gdbarch_init): Don't register deleted functions with
5004         gdbarch.
5005
5006 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5007
5008         * msp430-tdep.c (msp430_unwind_pc): Delete.
5009         (msp430_unwind_sp): Delete.
5010         (msp430_dummy_id): Delete.
5011         (msp430_gdbarch_init): Don't register deleted functions with
5012         gdbarch.
5013
5014 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5015
5016         * moxie-tdep.c (moxie_unwind_sp): Delete.
5017         (moxie_unwind_pc): Delete.
5018         (moxie_dummy_id): Delete.
5019         (moxie_gdbarch_init): Don't register deleted functions with
5020         gdbarch.
5021
5022 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5023
5024         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5025         (mn10300_unwind_pc): Delete.
5026         (mn10300_unwind_sp): Delete.
5027         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5028         mn10300_unwind_sp.
5029         (mn10300_frame_unwind_init): Don't register deleted functions with
5030         gdbarch.
5031
5032 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5033
5034         * mep-tdep.c (mep_unwind_pc): Delete.
5035         (mep_unwind_sp): Delete.
5036         (mep_dummy_id): Delete.
5037         (mep_gdbarch_init): Don't register deleted functions with
5038         gdbarch.
5039
5040 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5041
5042         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5043         (m68hc11_unwind_sp): Delete.
5044         (m68hc11_gdbarch_init): Don't register deleted functions with
5045         gdbarch.
5046
5047 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5048
5049         * m32r-tdep.c (m32r_unwind_sp): Delete.
5050         (m32r_unwind_pc): Delete.
5051         (m32r_dummy_id): Delete.
5052         (m32r_gdbarch_init): Don't register deleted functions with
5053         gdbarch.
5054
5055 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5056
5057         * m32c-tdep.c (m32c_unwind_pc): Delete.
5058         (m32c_unwind_sp): Delete.
5059         (m32c_dummy_id): Delete.
5060         (m32c_gdbarch_init): Don't register deleted functions with
5061         gdbarch.
5062
5063 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5064
5065         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5066         (lm32_unwind_pc): Delete.
5067         (lm32_dummy_id): Delete.
5068         (lm32_gdbarch_init): Don't register deleted functions with
5069         gdbarch.
5070
5071 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5072
5073         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5074         (iq2000_unwind_pc): Delete.
5075         (iq2000_dummy_id): Delete.
5076         (iq2000_gdbarch_init): Don't register deleted functions with
5077         gdbarch.
5078
5079 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5080
5081         * nds32-tdep.c (nds32_type_align): Delete.
5082         (nds32_push_dummy_call): Use type_align instead.
5083
5084 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5085
5086         * arm-tdep.c (arm_type_align): Only handle vector override case.
5087         (arm_push_dummy_call): Use type_align.
5088         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5089
5090 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5091
5092         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5093         case.
5094         (pass_on_stack): Use type_align.
5095         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5096         function.
5097
5098 2019-04-23  Tom Tromey  <tromey@adacore.com>
5099
5100         * dwarf2read.c (line_header::file_name_at): Remove unused
5101         overload.
5102
5103 2019-04-23  Tom de Vries  <tdevries@suse.de>
5104
5105         PR gdb/24438
5106         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5107         invocation.
5108
5109
5110 2019-03-27  Ali Tamur  <tamur@google.com>
5111
5112         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5113         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5114         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5115         (dwarf_expr_context::get_addr_index): Likewise
5116         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5117         (symbol_needs_eval_context::get_addr_index): Likewise
5118         (disassemble_dwarf_expression): Add DW_OP_addrx
5119         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5120         (read_cutu_die_from_dwo): Update comment
5121         (skip_one_die): Add DW_FORM_addrx
5122         (read_attribute_value): Likewise
5123         (var_decode_location): Add DW_OP_addrx
5124         (dwarf2_const_value_attr): Add DW_FORM_addrx
5125         (dump_die_shallow): Likewise
5126         (dwarf2_fetch_constant_bytes): Likewise
5127         (decode_locdesc): Add DW_OP_addrx
5128         (skip_form_bytes): Add DW_FORM_addrx
5129
5130 2019-04-22  Ali Tamur  <tamur@google.com>
5131
5132         * MAINTAINERS (Write After Approval): Add self.
5133
5134 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5135
5136         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5137         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5138         (open_symbol_file_object): Likewise.
5139         (svr4_default_sos): Add info parameter.
5140         (svr4_read_so_list): Likewise.
5141         (svr4_current_sos_direct): Adjust functions calls to pass down
5142         info.
5143         (svr4_current_sos_1): Add info parameter.
5144         (svr4_current_sos): Call get_svr4_info, pass info down to
5145         svr4_current_sos_1.
5146         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5147         get_svr4_info.
5148         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5149         get_svr4_info.
5150         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5151         to get_svr4_info.
5152         (probes_table_remove_objfile_probes): Likewise.
5153         (register_solib_event_probe): Add info parameter.
5154         (solist_update_incremental): Pass info parameter down to
5155         svr4_read_so_list.
5156         (disable_probes_interface): Add info parameter.
5157         (svr4_handle_solib_event): Pass current_program_space to
5158         get_svr4_info.  Adjust disable_probes_interface cleanup.
5159         (svr4_create_probe_breakpoints): Add info parameter, pass it
5160         down to register_solib_event_probe.
5161         (svr4_create_solib_event_breakpoints): Add info parameter,
5162         pass it down to svr4_create_probe_breakpoints.
5163         (enable_break): Pass info down to
5164         svr4_create_solib_event_breakpoints.
5165         (svr4_solib_create_inferior_hook): Pass current_program_space to
5166         get_svr4_info.
5167         (svr4_clear_solib): Likewise.
5168
5169 2019-04-22  Pedro Alves  <palves@redhat.com>
5170
5171         * solib-svr4.c (svr4_free_objfile_observer): New.
5172         (probe_and_action::objfile): New field.
5173         (probes_table_htab_remove_objfile_probes)
5174         (probes_table_remove_objfile_probes): New functions.
5175         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5176         in the new probe_and_action.  Don't store the probe in 'lookup'.
5177         (svr4_create_probe_breakpoints): Pass objfile to
5178         register_solib_event_probe.
5179         (_initialize_svr4_solib): Register a free_objfile observer.
5180
5181 2019-04-19  Tom Tromey  <tom@tromey.com>
5182
5183         * common/queue.h: Remove.
5184
5185 2019-04-19  Tom Tromey  <tom@tromey.com>
5186
5187         * event-loop.c: Don't include "common/queue.h".
5188
5189 2019-04-19  Tom Tromey  <tom@tromey.com>
5190
5191         * remote.c (remote_target): Use delete.
5192         * remote-notif.h: Include <list>, not "common/queue.h".
5193         (notif_client_p): Remove typedef.
5194         (remote_notif_state): Add constructor, destructor, initializer.
5195         <notif_queue>: Now a std::list.
5196         (remote_notif_state_xfree): Don't declare.
5197         * remote-notif.c (remote_notif_process, handle_notification)
5198         (remote_notif_state_allocate): Update.
5199         (~remote_notif_state): Rename from remote_notif_state_xfree.
5200
5201 2019-04-19  Tom Tromey  <tom@tromey.com>
5202
5203         * symfile.c (reread_symbols): Update.
5204         * objfiles.c (objfile_register_static_link)
5205         (objfile_lookup_static_link): Update
5206         (~objfile) Don't delete static_links.
5207         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5208
5209 2019-04-19  Tom Tromey  <tom@tromey.com>
5210
5211         * type-stack.h (struct type_stack) <insert>: Constify string.
5212         * type-stack.c (type_stack::insert): Constify string.
5213         * gdbtypes.h (lookup_template_type): Update.
5214         (address_space_name_to_int): Update.
5215         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5216         const.
5217         (lookup_template_type): Make name const.
5218         * c-exp.y: Update rules.
5219         (lex_one_token, classify_name, classify_inner_name)
5220         (c_print_token): Update.
5221         * p-exp.y: Update rules.
5222         (yylex): Update.
5223         * f-exp.y: Update rules.
5224         (yylex): Update.
5225         * d-exp.y: Update rules.
5226         (lex_one_token, classify_name, classify_inner_name): Update.
5227         * parse.c (write_dollar_variable, copy_name): Return std::string.
5228         * parser-defs.h (copy_name): Change return type.
5229         * m2-exp.y: Update rules.
5230         (yylex): Update.
5231         * go-exp.y (lex_one_token): Update.
5232         Update rules.
5233         (classify_unsafe_function, classify_packaged_name)
5234         (classify_name, yylex): Update.
5235
5236 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5237
5238         * configure.ac: add --enable-source-highlight switch.
5239         * configure: Regenerate.
5240         * top.c (print_gdb_version): plumb --enable-source-highlight
5241         status to "show configuration".
5242
5243 2019-04-19  Tom Tromey  <tromey@adacore.com>
5244
5245         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5246         Check ADA_TYPE_P.
5247         (empty_record, ada_template_to_fixed_record_type_1)
5248         (template_to_static_fixed_type)
5249         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5250         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5251         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5252         macros.
5253
5254 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5255
5256         PR symtab/24423:
5257         * source.c (print_source_lines_base): Advance "iter" when a
5258         control character is seen.
5259
5260 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5261
5262         * inferior.h (struct infcall_suspend_state_deleter):
5263         Catch exception in destructor to avoid crash.
5264
5265 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5266
5267         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5268         close to the add_com "shell".
5269
5270 2019-04-18  Tom Tromey  <tromey@adacore.com>
5271
5272         * process-stratum-target.h (class process_stratum_target)
5273         <stratum>: Add "final".
5274
5275 2019-04-17  Tom Tromey  <tromey@adacore.com>
5276
5277         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5278         against nullptr before use.
5279
5280 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5281
5282         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5283
5284 2019-04-17  Jim Wilson  <jimw@sifive.com>
5285             Andrew Burgess  <andrew.burgess@embecosm.com>
5286
5287         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5288         code read might fail, assume 4-byte breakpoint in that case.
5289
5290 2019-04-15  Leszek Swirski  <leszeks@google.com>
5291
5292         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5293         rather than a hand-rolled POD check when checking for forced MEMORY
5294         classification.
5295
5296 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5297
5298         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5299         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5300         function.
5301         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5302         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5303         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5304         declaration.
5305
5306 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5307
5308         * aarch64-linux-nat.c
5309         (aarch64_linux_nat_target::thread_architecture): Add override.
5310         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5311         each VQ.
5312
5313 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5314
5315         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5316
5317 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5318
5319         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5320         target types of size 96-bits, add some additional comments, and
5321         check that the builtin type we found was the correct size.
5322
5323 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5324
5325         * utils.c (prompt_for_continue): Don't restore the styling at the
5326         end, as applied_style has the wrong value.  This fixes styling in
5327         long lists of file names that are interrupted by the "Continue?"
5328         prompt.
5329
5330 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5331
5332         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5333         * c-lang.c (c_language_defn): Likewise.
5334         (cplus_language_defn): Likewise.
5335         (asm_language_defn): Likewise.
5336         (minimal_language_defn): Likewise.
5337         * d-lang.c (d_language_defn): Likewise.
5338         * f-lang.c (f_language_defn): Likewise.
5339         * go-lang.c (go_language_defn): Likewise.
5340         * language.c (unknown_language_defn): Likewise.
5341         (auto_language_defn): Likewise.
5342         * language.h (struct language_defn): Remove la_magic field.
5343         (LANG_MAGIC): Delete.
5344         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5345         * objc-lang.c (objc_language_defn): Likewise.
5346         * opencl-lang.c (opencl_language_defn): Likewise.
5347         * p-lang.c (pascal_language_defn): Likewise.
5348         * rust-lang.c (rust_language_defn): Likewise.
5349
5350 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5351
5352         * riscv-tdep.c (riscv_type_align): New function.
5353         (riscv_type_alignment): Delete.
5354         (riscv_arg_location): Use 'type_align'.
5355         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5356
5357 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5358
5359         * gdbtypes.c (type_align): A struct with no non-static fields also
5360         has alignment of 1.
5361
5362 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5363
5364         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5365         component to 0.
5366         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5367         member.
5368         (riscv_struct_info::analyse): New implementation using new
5369         analyse_inner member function.
5370         (riscv_struct_info::field_offset): New member function.
5371         (riscv_struct_info::m_offsets): New member variable.
5372         (riscv_struct_info::analyse_inner): New private member function,
5373         takes the old implementation of riscv_struct_info::analyse but
5374         extended to track field offsets.
5375         (riscv_call_arg_struct): Update the struct folding special cases
5376         to handle cases where empty C++ structs, which are non-zero
5377         length, are found.
5378         (riscv_arg_location): Initialise the length of each location, a
5379         non-zero length now indicates the location is in use.
5380         (riscv_push_dummy_call): Allow for the first location having a
5381         non-zero offset when setting up arguments.
5382         (riscv_return_value): Likewise, but for return values.
5383
5384 2019-04-11  Tom Tromey  <tromey@adacore.com>
5385
5386         * utils.c (internal_vproblem): Make "msg" const.
5387
5388 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5389
5390         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5391         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5392         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5393         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5394
5395 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5396
5397         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5398         function.
5399         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5400         of amd64_collect_native_gregset.
5401         (amd64_linux_nat_target::store_registers): Likewise.
5402
5403 2019-04-10  Tom Tromey  <tom@tromey.com>
5404
5405         * symtab.c (lookup_global_symbol_from_objfile)
5406         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5407         * objfiles.h (class separate_debug_iterator): New.
5408         (class separate_debug_range): New.
5409         (struct objfile) <separate_debug_objfiles>: New method.
5410         (objfile_separate_debug_iterate): Don't declare.
5411         * objfiles.c (separate_debug_iterator::operator++): Rename from
5412         objfile_separate_debug_iterate.
5413         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5414         iterator.
5415         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5416         iterator.
5417
5418 2019-04-10  Tom Tromey  <tom@tromey.com>
5419
5420         * symfile.c (reread_symbols): Remove old comment.
5421         * objfiles.c (free_all_objfiles): Fix a typo.
5422
5423 2019-04-10  Tom Tromey  <tom@tromey.com>
5424
5425         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5426         * minsyms.c (lookup_minimal_symbol): Use foreach.
5427         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5428         (lookup_minimal_symbol_solib_trampoline): Likewise.
5429         * symfile.c (reread_symbols): Use foreach.
5430
5431 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5432             Tom Tromey  <tromey@adacore.com>
5433
5434         PR rust/24414:
5435         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5436         (rust_lex_int_test): Change "value" to be LONGEST.
5437         (rust_lex_tests): Add test for long integer literal.
5438
5439 2019-04-09  Tom Tromey  <tromey@adacore.com>
5440
5441         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5442         to bool.
5443         (extended_remote_target::attach): Update.
5444         (remote_target::remote_notice_new_inferior): Update.
5445         (remote_target::add_current_inferior_and_thread): Update.
5446         * inferior.c (exit_inferior_1): Use "false".
5447         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5448
5449 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5450
5451         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5452         the "start" command.
5453
5454 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5455
5456         * python/py-inferior.c (infpy_thread_from_thread_handle):
5457         Adjust comments to reflect renaming of thread_from_thread_handle
5458         to thread_from_handle.  Adjust keywords.  Fix type error message.
5459         (inferior_object_methods): Add thread_from_handle.  Retain
5460         thread_from_thread_handle, but mark it as deprecated.
5461
5462 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5463
5464         * gdbthread.h (find_thread_by_handle): Revise declaration.
5465         * thread.c (find_thread_by_handle): Likewise.  Adjust
5466         implementation too.
5467         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5468         support for buffer objects as handles.
5469
5470 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5471
5472         * python/py-infthread.c (thpy_thread_handle): New function.
5473         (thread_object_methods): Register thpy_thread_handle.
5474
5475 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5476
5477         * gdbthread.h (thread_to_thread_handle): Declare.
5478         * thread.c (gdbtypes.h): Include.
5479         (thread_to_thread_handle): New function.
5480
5481         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5482         (target_thread_info_to_thread_handle): Declare.
5483         * target.c (target_thread_info_to_thread_handle): New function.
5484         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5485         * target-delegates.c: Regenerate.
5486
5487         * linux-thread-db.c (class thread_db_target): Add method
5488         thread_info_to_thread_handle.
5489         (thread_db_target::thread_info_to_thread_handle): Define.
5490         * remote.c (class remote_target): Add new method
5491         thread_info_to_thread_handle.
5492         (remote_target::thread_info_to_thread_handle): Define.
5493
5494 2019-04-08  Pedro Alves  <palves@redhat.com>
5495
5496         * common/common-exceptions.c (throw_exception): Don't create
5497         named object to throw; throw directly.
5498         (throw_it): Likewise.  Don't initialize gdb_exception::message
5499         here, with new; pass FMT and AP to the ctor instead.
5500         * common/common-exceptions.h: Include <string>.
5501         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5502         const char *, va_list)): New ctor.  Use std::make_shared.
5503         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5504         errors)): Delete.
5505         (gdb_exception_error::gdb_exception_error(enum errors, const char
5506         *, va_list)): New.
5507         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5508         Add assertion.
5509         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5510         errors)): Delete.
5511         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5512         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5513         Add assertion.
5514
5515 2019-04-08  Tom Tromey  <tom@tromey.com>
5516
5517         * valops.c (value_rtti_indirect_type): Replace throw_exception
5518         with throw.
5519         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5520         with throw.
5521         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5522         throw.
5523         * target.c (target_translate_tls_address): Replace throw_exception
5524         with throw.
5525         * stack.c (frame_apply_command_count): Replace throw_exception
5526         with throw.
5527         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5528         throw.
5529         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5530         with throw.
5531         * rs6000-tdep.c (rs6000_frame_cache)
5532         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5533         * remote.c: Replace throw_exception with throw.
5534         * record-full.c (record_full_message, record_full_wait_1)
5535         (record_full_restore): Replace throw_exception with throw.
5536         * record-btrace.c:
5537         (get_thread_current_frame_id, record_btrace_start_replaying)
5538         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5539         (cmd_record_btrace_start): Replace throw_exception with throw.
5540         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5541         throw.
5542         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5543         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5544         * linespec.c:
5545         (find_linespec_symbols): Replace throw_exception with throw.
5546         * infrun.c (displaced_step_prepare, resume): Replace
5547         throw_exception with throw.
5548         * infcmd.c (post_create_inferior): Replace throw_exception with
5549         throw.
5550         * inf-loop.c (inferior_event_handler): Replace throw_exception
5551         with throw.
5552         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5553         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5554         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5555         (get_prev_frame_always, get_frame_pc_if_available)
5556         (get_frame_address_in_block_if_available, get_frame_language):
5557         Replace throw_exception with throw.
5558         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5559         throw_exception with throw.
5560         * eval.c (fetch_subexp_value, evaluate_var_value)
5561         (evaluate_funcall, evaluate_subexp_standard): Replace
5562         throw_exception with throw.
5563         * dwarf2loc.c (call_site_find_chain)
5564         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5565         Replace throw_exception with throw.
5566         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5567         with throw.
5568         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5569         throw.
5570         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5571         * completer.c (complete_line_internal): Replace throw_exception
5572         with throw.
5573         * compile/compile-object-run.c (compile_object_run): Replace
5574         throw_exception with throw.
5575         * cli/cli-script.c (process_next_line): Replace throw_exception
5576         with throw.
5577         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5578         (btrace_enable, btrace_maint_update_pt_packets): Replace
5579         throw_exception with throw.
5580         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5581         throw_exception with throw.
5582         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5583         throw_exception with throw.
5584         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5585         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5586         * aarch64-tdep.c (aarch64_make_prologue_cache)
5587         (aarch64_make_stub_cache): Replace throw_exception with throw.
5588
5589 2019-04-08  Tom Tromey  <tom@tromey.com>
5590
5591         * common/common-exceptions.c (throw_exception): Rename from
5592         throw_exception_cxx.  Remove old copy.  Make argument const.
5593         (throw_it): Create and throw exception objects directly.
5594         * common/common-exceptions.h (throw_exception): Make argument
5595         const.
5596         (struct gdb_exception_error): Add constructor.
5597         (struct gdb_exception_quit): Add constructor.
5598
5599 2019-04-08  Tom Tromey  <tom@tromey.com>
5600
5601         * common/common-exceptions.h (exception_rethrow): Don't declare.
5602         (TRY_SJLJ): Update comment.
5603         (TRY, CATCH, END_CATCH): Remove.
5604         * common/common-exceptions.c (exception_rethrow): Remove.
5605
5606 2019-04-08  Tom Tromey  <tom@tromey.com>
5607
5608         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5609         Remove.
5610         (gdb_exception_error): Rename from
5611         gdb_exception_RETURN_MASK_ERROR.
5612         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5613         (gdb_quit_bad_alloc): Update.
5614         * aarch64-tdep.c: Update.
5615         * ada-lang.c: Update.
5616         * ada-typeprint.c: Update.
5617         * ada-valprint.c: Update.
5618         * amd64-tdep.c: Update.
5619         * arch-utils.c: Update.
5620         * break-catch-throw.c: Update.
5621         * breakpoint.c: Update.
5622         * btrace.c: Update.
5623         * c-varobj.c: Update.
5624         * cli/cli-cmds.c: Update.
5625         * cli/cli-interp.c: Update.
5626         * cli/cli-script.c: Update.
5627         * common/common-exceptions.c: Update.
5628         * common/new-op.c: Update.
5629         * common/selftest.c: Update.
5630         * compile/compile-c-symbols.c: Update.
5631         * compile/compile-cplus-symbols.c: Update.
5632         * compile/compile-object-load.c: Update.
5633         * compile/compile-object-run.c: Update.
5634         * completer.c: Update.
5635         * corelow.c: Update.
5636         * cp-abi.c: Update.
5637         * cp-support.c: Update.
5638         * cp-valprint.c: Update.
5639         * darwin-nat.c: Update.
5640         * disasm-selftests.c: Update.
5641         * dtrace-probe.c: Update.
5642         * dwarf-index-cache.c: Update.
5643         * dwarf-index-write.c: Update.
5644         * dwarf2-frame-tailcall.c: Update.
5645         * dwarf2-frame.c: Update.
5646         * dwarf2loc.c: Update.
5647         * dwarf2read.c: Update.
5648         * eval.c: Update.
5649         * event-loop.c: Update.
5650         * event-top.c: Update.
5651         * exec.c: Update.
5652         * f-valprint.c: Update.
5653         * fbsd-tdep.c: Update.
5654         * frame-unwind.c: Update.
5655         * frame.c: Update.
5656         * gdbtypes.c: Update.
5657         * gnu-v3-abi.c: Update.
5658         * guile/guile-internal.h: Update.
5659         * guile/scm-block.c: Update.
5660         * guile/scm-breakpoint.c: Update.
5661         * guile/scm-cmd.c: Update.
5662         * guile/scm-disasm.c: Update.
5663         * guile/scm-frame.c: Update.
5664         * guile/scm-lazy-string.c: Update.
5665         * guile/scm-math.c: Update.
5666         * guile/scm-param.c: Update.
5667         * guile/scm-ports.c: Update.
5668         * guile/scm-pretty-print.c: Update.
5669         * guile/scm-symbol.c: Update.
5670         * guile/scm-symtab.c: Update.
5671         * guile/scm-type.c: Update.
5672         * guile/scm-value.c: Update.
5673         * i386-linux-tdep.c: Update.
5674         * i386-tdep.c: Update.
5675         * inf-loop.c: Update.
5676         * infcall.c: Update.
5677         * infcmd.c: Update.
5678         * infrun.c: Update.
5679         * jit.c: Update.
5680         * language.c: Update.
5681         * linespec.c: Update.
5682         * linux-fork.c: Update.
5683         * linux-nat.c: Update.
5684         * linux-tdep.c: Update.
5685         * linux-thread-db.c: Update.
5686         * main.c: Update.
5687         * mi/mi-cmd-break.c: Update.
5688         * mi/mi-cmd-stack.c: Update.
5689         * mi/mi-interp.c: Update.
5690         * mi/mi-main.c: Update.
5691         * objc-lang.c: Update.
5692         * p-valprint.c: Update.
5693         * parse.c: Update.
5694         * ppc-linux-tdep.c: Update.
5695         * printcmd.c: Update.
5696         * python/py-arch.c: Update.
5697         * python/py-breakpoint.c: Update.
5698         * python/py-cmd.c: Update.
5699         * python/py-finishbreakpoint.c: Update.
5700         * python/py-frame.c: Update.
5701         * python/py-framefilter.c: Update.
5702         * python/py-gdb-readline.c: Update.
5703         * python/py-inferior.c: Update.
5704         * python/py-infthread.c: Update.
5705         * python/py-lazy-string.c: Update.
5706         * python/py-linetable.c: Update.
5707         * python/py-objfile.c: Update.
5708         * python/py-param.c: Update.
5709         * python/py-prettyprint.c: Update.
5710         * python/py-progspace.c: Update.
5711         * python/py-record-btrace.c: Update.
5712         * python/py-record.c: Update.
5713         * python/py-symbol.c: Update.
5714         * python/py-type.c: Update.
5715         * python/py-unwind.c: Update.
5716         * python/py-utils.c: Update.
5717         * python/py-value.c: Update.
5718         * python/python.c: Update.
5719         * record-btrace.c: Update.
5720         * record-full.c: Update.
5721         * remote-fileio.c: Update.
5722         * remote.c: Update.
5723         * riscv-tdep.c: Update.
5724         * rs6000-aix-tdep.c: Update.
5725         * rs6000-tdep.c: Update.
5726         * rust-exp.y: Update.
5727         * rust-lang.c: Update.
5728         * s390-tdep.c: Update.
5729         * selftest-arch.c: Update.
5730         * solib-dsbt.c: Update.
5731         * solib-frv.c: Update.
5732         * solib-spu.c: Update.
5733         * solib-svr4.c: Update.
5734         * solib.c: Update.
5735         * sparc64-linux-tdep.c: Update.
5736         * stack.c: Update.
5737         * symfile-mem.c: Update.
5738         * symmisc.c: Update.
5739         * target.c: Update.
5740         * thread.c: Update.
5741         * top.c: Update.
5742         * tracefile-tfile.c: Update.
5743         * tui/tui.c: Update.
5744         * typeprint.c: Update.
5745         * unittests/cli-utils-selftests.c: Update.
5746         * unittests/parse-connection-spec-selftests.c: Update.
5747         * valops.c: Update.
5748         * valprint.c: Update.
5749         * value.c: Update.
5750         * varobj.c: Update.
5751         * windows-nat.c: Update.
5752         * x86-linux-nat.c: Update.
5753         * xml-support.c: Update.
5754
5755 2019-04-08  Tom Tromey  <tom@tromey.com>
5756
5757         * xml-support.c: Use C++ exception handling.
5758         * x86-linux-nat.c: Use C++ exception handling.
5759         * windows-nat.c: Use C++ exception handling.
5760         * varobj.c: Use C++ exception handling.
5761         * value.c: Use C++ exception handling.
5762         * valprint.c: Use C++ exception handling.
5763         * valops.c: Use C++ exception handling.
5764         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5765         handling.
5766         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5767         * typeprint.c: Use C++ exception handling.
5768         * tui/tui.c: Use C++ exception handling.
5769         * tracefile-tfile.c: Use C++ exception handling.
5770         * top.c: Use C++ exception handling.
5771         * thread.c: Use C++ exception handling.
5772         * target.c: Use C++ exception handling.
5773         * symmisc.c: Use C++ exception handling.
5774         * symfile-mem.c: Use C++ exception handling.
5775         * stack.c: Use C++ exception handling.
5776         * sparc64-linux-tdep.c: Use C++ exception handling.
5777         * solib.c: Use C++ exception handling.
5778         * solib-svr4.c: Use C++ exception handling.
5779         * solib-spu.c: Use C++ exception handling.
5780         * solib-frv.c: Use C++ exception handling.
5781         * solib-dsbt.c: Use C++ exception handling.
5782         * selftest-arch.c: Use C++ exception handling.
5783         * s390-tdep.c: Use C++ exception handling.
5784         * rust-lang.c: Use C++ exception handling.
5785         * rust-exp.y: Use C++ exception handling.
5786         * rs6000-tdep.c: Use C++ exception handling.
5787         * rs6000-aix-tdep.c: Use C++ exception handling.
5788         * riscv-tdep.c: Use C++ exception handling.
5789         * remote.c: Use C++ exception handling.
5790         * remote-fileio.c: Use C++ exception handling.
5791         * record-full.c: Use C++ exception handling.
5792         * record-btrace.c: Use C++ exception handling.
5793         * python/python.c: Use C++ exception handling.
5794         * python/py-value.c: Use C++ exception handling.
5795         * python/py-utils.c: Use C++ exception handling.
5796         * python/py-unwind.c: Use C++ exception handling.
5797         * python/py-type.c: Use C++ exception handling.
5798         * python/py-symbol.c: Use C++ exception handling.
5799         * python/py-record.c: Use C++ exception handling.
5800         * python/py-record-btrace.c: Use C++ exception handling.
5801         * python/py-progspace.c: Use C++ exception handling.
5802         * python/py-prettyprint.c: Use C++ exception handling.
5803         * python/py-param.c: Use C++ exception handling.
5804         * python/py-objfile.c: Use C++ exception handling.
5805         * python/py-linetable.c: Use C++ exception handling.
5806         * python/py-lazy-string.c: Use C++ exception handling.
5807         * python/py-infthread.c: Use C++ exception handling.
5808         * python/py-inferior.c: Use C++ exception handling.
5809         * python/py-gdb-readline.c: Use C++ exception handling.
5810         * python/py-framefilter.c: Use C++ exception handling.
5811         * python/py-frame.c: Use C++ exception handling.
5812         * python/py-finishbreakpoint.c: Use C++ exception handling.
5813         * python/py-cmd.c: Use C++ exception handling.
5814         * python/py-breakpoint.c: Use C++ exception handling.
5815         * python/py-arch.c: Use C++ exception handling.
5816         * printcmd.c: Use C++ exception handling.
5817         * ppc-linux-tdep.c: Use C++ exception handling.
5818         * parse.c: Use C++ exception handling.
5819         * p-valprint.c: Use C++ exception handling.
5820         * objc-lang.c: Use C++ exception handling.
5821         * mi/mi-main.c: Use C++ exception handling.
5822         * mi/mi-interp.c: Use C++ exception handling.
5823         * mi/mi-cmd-stack.c: Use C++ exception handling.
5824         * mi/mi-cmd-break.c: Use C++ exception handling.
5825         * main.c: Use C++ exception handling.
5826         * linux-thread-db.c: Use C++ exception handling.
5827         * linux-tdep.c: Use C++ exception handling.
5828         * linux-nat.c: Use C++ exception handling.
5829         * linux-fork.c: Use C++ exception handling.
5830         * linespec.c: Use C++ exception handling.
5831         * language.c: Use C++ exception handling.
5832         * jit.c: Use C++ exception handling.
5833         * infrun.c: Use C++ exception handling.
5834         * infcmd.c: Use C++ exception handling.
5835         * infcall.c: Use C++ exception handling.
5836         * inf-loop.c: Use C++ exception handling.
5837         * i386-tdep.c: Use C++ exception handling.
5838         * i386-linux-tdep.c: Use C++ exception handling.
5839         * guile/scm-value.c: Use C++ exception handling.
5840         * guile/scm-type.c: Use C++ exception handling.
5841         * guile/scm-symtab.c: Use C++ exception handling.
5842         * guile/scm-symbol.c: Use C++ exception handling.
5843         * guile/scm-pretty-print.c: Use C++ exception handling.
5844         * guile/scm-ports.c: Use C++ exception handling.
5845         * guile/scm-param.c: Use C++ exception handling.
5846         * guile/scm-math.c: Use C++ exception handling.
5847         * guile/scm-lazy-string.c: Use C++ exception handling.
5848         * guile/scm-frame.c: Use C++ exception handling.
5849         * guile/scm-disasm.c: Use C++ exception handling.
5850         * guile/scm-cmd.c: Use C++ exception handling.
5851         * guile/scm-breakpoint.c: Use C++ exception handling.
5852         * guile/scm-block.c: Use C++ exception handling.
5853         * guile/guile-internal.h: Use C++ exception handling.
5854         * gnu-v3-abi.c: Use C++ exception handling.
5855         * gdbtypes.c: Use C++ exception handling.
5856         * frame.c: Use C++ exception handling.
5857         * frame-unwind.c: Use C++ exception handling.
5858         * fbsd-tdep.c: Use C++ exception handling.
5859         * f-valprint.c: Use C++ exception handling.
5860         * exec.c: Use C++ exception handling.
5861         * event-top.c: Use C++ exception handling.
5862         * event-loop.c: Use C++ exception handling.
5863         * eval.c: Use C++ exception handling.
5864         * dwarf2read.c: Use C++ exception handling.
5865         * dwarf2loc.c: Use C++ exception handling.
5866         * dwarf2-frame.c: Use C++ exception handling.
5867         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5868         * dwarf-index-write.c: Use C++ exception handling.
5869         * dwarf-index-cache.c: Use C++ exception handling.
5870         * dtrace-probe.c: Use C++ exception handling.
5871         * disasm-selftests.c: Use C++ exception handling.
5872         * darwin-nat.c: Use C++ exception handling.
5873         * cp-valprint.c: Use C++ exception handling.
5874         * cp-support.c: Use C++ exception handling.
5875         * cp-abi.c: Use C++ exception handling.
5876         * corelow.c: Use C++ exception handling.
5877         * completer.c: Use C++ exception handling.
5878         * compile/compile-object-run.c: Use C++ exception handling.
5879         * compile/compile-object-load.c: Use C++ exception handling.
5880         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5881         * compile/compile-c-symbols.c: Use C++ exception handling.
5882         * common/selftest.c: Use C++ exception handling.
5883         * common/new-op.c: Use C++ exception handling.
5884         * cli/cli-script.c: Use C++ exception handling.
5885         * cli/cli-interp.c: Use C++ exception handling.
5886         * cli/cli-cmds.c: Use C++ exception handling.
5887         * c-varobj.c: Use C++ exception handling.
5888         * btrace.c: Use C++ exception handling.
5889         * breakpoint.c: Use C++ exception handling.
5890         * break-catch-throw.c: Use C++ exception handling.
5891         * arch-utils.c: Use C++ exception handling.
5892         * amd64-tdep.c: Use C++ exception handling.
5893         * ada-valprint.c: Use C++ exception handling.
5894         * ada-typeprint.c: Use C++ exception handling.
5895         * ada-lang.c: Use C++ exception handling.
5896         * aarch64-tdep.c: Use C++ exception handling.
5897
5898 2019-04-08  Tom Tromey  <tom@tromey.com>
5899
5900         * xml-support.c (gdb_xml_parser::parse): Update.
5901         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5902         * value.c (show_convenience): Update.
5903         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5904         (test_parse_flags_qcs): Update.
5905         * thread.c (thr_try_catch_cmd): Update.
5906         * target.c (target_translate_tls_address): Update.
5907         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5908         (info_frame_command_core, frame_apply_command_count): Update.
5909         * rust-exp.y (rust_lex_exception_test): Update.
5910         * riscv-tdep.c (riscv_print_one_register_info): Update.
5911         * remote.c (remote_target::enable_btrace): Update.
5912         * record-btrace.c (record_btrace_enable_warn): Update.
5913         * python/py-utils.c (gdbpy_convert_exception): Update.
5914         * printcmd.c (do_one_display, print_variable_and_value): Update.
5915         * mi/mi-main.c (mi_print_exception): Update.
5916         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5917         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5918         * linux-nat.c (linux_nat_target::attach): Update.
5919         * linux-fork.c (class scoped_switch_fork_info): Update.
5920         * infrun.c (displaced_step_prepare): Update.
5921         * infcall.c (call_function_by_hand_dummy): Update.
5922         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5923         * gnu-v3-abi.c (print_one_vtable): Update.
5924         * frame.c (get_prev_frame_always): Update.
5925         * f-valprint.c (info_common_command_for_block): Update.
5926         * exec.c (try_open_exec_file): Update.
5927         * exceptions.c (print_exception, exception_print)
5928         (exception_fprintf, exception_print_same): Update.
5929         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5930         * dwarf-index-cache.c (index_cache::store)
5931         (index_cache::lookup_gdb_index): Update.
5932         * darwin-nat.c (maybe_cache_shell): Update.
5933         * cp-valprint.c (cp_print_value_fields): Update.
5934         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5935         (gcc_cplus_symbol_address): Update.
5936         * compile/compile-c-symbols.c (gcc_convert_symbol)
5937         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5938         * common/selftest.c: Update.
5939         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5940         a std::string.
5941         (exception_try_scope_entry, exception_try_scope_exit): Don't
5942         declare.
5943         (struct exception_try_scope): Remove.
5944         (TRY): Don't use exception_try_scope.
5945         (struct gdb_exception): Add constructor, operator=.
5946         <what>: New method.
5947         (struct gdb_exception_RETURN_MASK_ALL)
5948         (struct gdb_exception_RETURN_MASK_ERROR)
5949         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5950         (struct gdb_quit_bad_alloc): Update.
5951         * common/common-exceptions.c (exception_none): Change
5952         initializer.
5953         (struct catcher) <state, exception>: Initialize inline.
5954         <prev>: Remove member.
5955         (current_catcher): Remove.
5956         (catchers): New global.
5957         (exceptions_state_mc_init): Simplify.
5958         (catcher_pop): Remove.
5959         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5960         (try_scope_depth, exception_try_scope_entry)
5961         (exception_try_scope_exit): Remove.
5962         (throw_exception_sjlj): Update.
5963         (exception_messages, exception_messages_size): Remove.
5964         (throw_it): Simplify.
5965         (gdb_exception_sliced_copy): Remove.
5966         (throw_exception_cxx): Update.
5967         * cli/cli-script.c (script_from_file): Update.
5968         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5969         Update.
5970         * ada-valprint.c (ada_val_print): Update.
5971         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5972         (create_excep_cond_exprs): Update.
5973
5974 2019-04-08  Tom Tromey  <tom@tromey.com>
5975
5976         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5977         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5978         (TRY, CATCH, END_CATCH): Remove some definitions.
5979         * common/common-exceptions.c: Don't use GDB_XCPT.
5980         (catcher_list_size): Remove.
5981         (throw_exception, throw_it): Simplify.
5982
5983 2019-04-05  Tom Tromey  <tom@tromey.com>
5984
5985         Revert the header-sorting patch.
5986         * ft32-tdep.c: Revert.
5987         * frv-tdep.c: Revert.
5988         * frv-linux-tdep.c: Revert.
5989         * frame.c: Revert.
5990         * frame-unwind.c: Revert.
5991         * frame-base.c: Revert.
5992         * fork-child.c: Revert.
5993         * findvar.c: Revert.
5994         * findcmd.c: Revert.
5995         * filesystem.c: Revert.
5996         * filename-seen-cache.h: Revert.
5997         * filename-seen-cache.c: Revert.
5998         * fbsd-tdep.c: Revert.
5999         * fbsd-nat.h: Revert.
6000         * fbsd-nat.c: Revert.
6001         * f-valprint.c: Revert.
6002         * f-typeprint.c: Revert.
6003         * f-lang.c: Revert.
6004         * extension.h: Revert.
6005         * extension.c: Revert.
6006         * extension-priv.h: Revert.
6007         * expprint.c: Revert.
6008         * exec.h: Revert.
6009         * exec.c: Revert.
6010         * exceptions.c: Revert.
6011         * event-top.c: Revert.
6012         * event-loop.c: Revert.
6013         * eval.c: Revert.
6014         * elfread.c: Revert.
6015         * dwarf2read.h: Revert.
6016         * dwarf2read.c: Revert.
6017         * dwarf2loc.c: Revert.
6018         * dwarf2expr.h: Revert.
6019         * dwarf2expr.c: Revert.
6020         * dwarf2-frame.c: Revert.
6021         * dwarf2-frame-tailcall.c: Revert.
6022         * dwarf-index-write.h: Revert.
6023         * dwarf-index-write.c: Revert.
6024         * dwarf-index-common.c: Revert.
6025         * dwarf-index-cache.h: Revert.
6026         * dwarf-index-cache.c: Revert.
6027         * dummy-frame.c: Revert.
6028         * dtrace-probe.c: Revert.
6029         * disasm.h: Revert.
6030         * disasm.c: Revert.
6031         * disasm-selftests.c: Revert.
6032         * dictionary.c: Revert.
6033         * dicos-tdep.c: Revert.
6034         * demangle.c: Revert.
6035         * dcache.h: Revert.
6036         * dcache.c: Revert.
6037         * darwin-nat.h: Revert.
6038         * darwin-nat.c: Revert.
6039         * darwin-nat-info.c: Revert.
6040         * d-valprint.c: Revert.
6041         * d-namespace.c: Revert.
6042         * d-lang.c: Revert.
6043         * ctf.c: Revert.
6044         * csky-tdep.c: Revert.
6045         * csky-linux-tdep.c: Revert.
6046         * cris-tdep.c: Revert.
6047         * cris-linux-tdep.c: Revert.
6048         * cp-valprint.c: Revert.
6049         * cp-support.c: Revert.
6050         * cp-namespace.c: Revert.
6051         * cp-abi.c: Revert.
6052         * corelow.c: Revert.
6053         * corefile.c: Revert.
6054         * continuations.c: Revert.
6055         * completer.h: Revert.
6056         * completer.c: Revert.
6057         * complaints.c: Revert.
6058         * coffread.c: Revert.
6059         * coff-pe-read.c: Revert.
6060         * cli-out.h: Revert.
6061         * cli-out.c: Revert.
6062         * charset.c: Revert.
6063         * c-varobj.c: Revert.
6064         * c-valprint.c: Revert.
6065         * c-typeprint.c: Revert.
6066         * c-lang.c: Revert.
6067         * buildsym.c: Revert.
6068         * buildsym-legacy.c: Revert.
6069         * build-id.h: Revert.
6070         * build-id.c: Revert.
6071         * btrace.c: Revert.
6072         * bsd-uthread.c: Revert.
6073         * breakpoint.h: Revert.
6074         * breakpoint.c: Revert.
6075         * break-catch-throw.c: Revert.
6076         * break-catch-syscall.c: Revert.
6077         * break-catch-sig.c: Revert.
6078         * blockframe.c: Revert.
6079         * block.c: Revert.
6080         * bfin-tdep.c: Revert.
6081         * bfin-linux-tdep.c: Revert.
6082         * bfd-target.c: Revert.
6083         * bcache.c: Revert.
6084         * ax-general.c: Revert.
6085         * ax-gdb.h: Revert.
6086         * ax-gdb.c: Revert.
6087         * avr-tdep.c: Revert.
6088         * auxv.c: Revert.
6089         * auto-load.c: Revert.
6090         * arm-wince-tdep.c: Revert.
6091         * arm-tdep.c: Revert.
6092         * arm-symbian-tdep.c: Revert.
6093         * arm-pikeos-tdep.c: Revert.
6094         * arm-obsd-tdep.c: Revert.
6095         * arm-nbsd-tdep.c: Revert.
6096         * arm-nbsd-nat.c: Revert.
6097         * arm-linux-tdep.c: Revert.
6098         * arm-linux-nat.c: Revert.
6099         * arm-fbsd-tdep.c: Revert.
6100         * arm-fbsd-nat.c: Revert.
6101         * arm-bsd-tdep.c: Revert.
6102         * arch-utils.c: Revert.
6103         * arc-tdep.c: Revert.
6104         * arc-newlib-tdep.c: Revert.
6105         * annotate.h: Revert.
6106         * annotate.c: Revert.
6107         * amd64-windows-tdep.c: Revert.
6108         * amd64-windows-nat.c: Revert.
6109         * amd64-tdep.c: Revert.
6110         * amd64-sol2-tdep.c: Revert.
6111         * amd64-obsd-tdep.c: Revert.
6112         * amd64-obsd-nat.c: Revert.
6113         * amd64-nbsd-tdep.c: Revert.
6114         * amd64-nbsd-nat.c: Revert.
6115         * amd64-nat.c: Revert.
6116         * amd64-linux-tdep.c: Revert.
6117         * amd64-linux-nat.c: Revert.
6118         * amd64-fbsd-tdep.c: Revert.
6119         * amd64-fbsd-nat.c: Revert.
6120         * amd64-dicos-tdep.c: Revert.
6121         * amd64-darwin-tdep.c: Revert.
6122         * amd64-bsd-nat.c: Revert.
6123         * alpha-tdep.c: Revert.
6124         * alpha-obsd-tdep.c: Revert.
6125         * alpha-nbsd-tdep.c: Revert.
6126         * alpha-mdebug-tdep.c: Revert.
6127         * alpha-linux-tdep.c: Revert.
6128         * alpha-linux-nat.c: Revert.
6129         * alpha-bsd-tdep.c: Revert.
6130         * alpha-bsd-nat.c: Revert.
6131         * aix-thread.c: Revert.
6132         * agent.c: Revert.
6133         * addrmap.c: Revert.
6134         * ada-varobj.c: Revert.
6135         * ada-valprint.c: Revert.
6136         * ada-typeprint.c: Revert.
6137         * ada-tasks.c: Revert.
6138         * ada-lang.c: Revert.
6139         * aarch64-tdep.c: Revert.
6140         * aarch64-ravenscar-thread.c: Revert.
6141         * aarch64-newlib-tdep.c: Revert.
6142         * aarch64-linux-tdep.c: Revert.
6143         * aarch64-linux-nat.c: Revert.
6144         * aarch64-fbsd-tdep.c: Revert.
6145         * aarch64-fbsd-nat.c: Revert.
6146         * aarch32-linux-nat.c: Revert.
6147
6148 2019-04-05  Tom Tromey  <tom@tromey.com>
6149
6150         * ft32-tdep.c: Sort headers.
6151         * frv-tdep.c: Sort headers.
6152         * frv-linux-tdep.c: Sort headers.
6153         * frame.c: Sort headers.
6154         * frame-unwind.c: Sort headers.
6155         * frame-base.c: Sort headers.
6156         * fork-child.c: Sort headers.
6157         * findvar.c: Sort headers.
6158         * findcmd.c: Sort headers.
6159         * filesystem.c: Sort headers.
6160         * filename-seen-cache.h: Sort headers.
6161         * filename-seen-cache.c: Sort headers.
6162         * fbsd-tdep.c: Sort headers.
6163         * fbsd-nat.h: Sort headers.
6164         * fbsd-nat.c: Sort headers.
6165         * f-valprint.c: Sort headers.
6166         * f-typeprint.c: Sort headers.
6167         * f-lang.c: Sort headers.
6168         * extension.h: Sort headers.
6169         * extension.c: Sort headers.
6170         * extension-priv.h: Sort headers.
6171         * expprint.c: Sort headers.
6172         * exec.h: Sort headers.
6173         * exec.c: Sort headers.
6174         * exceptions.c: Sort headers.
6175         * event-top.c: Sort headers.
6176         * event-loop.c: Sort headers.
6177         * eval.c: Sort headers.
6178         * elfread.c: Sort headers.
6179         * dwarf2read.h: Sort headers.
6180         * dwarf2read.c: Sort headers.
6181         * dwarf2loc.c: Sort headers.
6182         * dwarf2expr.h: Sort headers.
6183         * dwarf2expr.c: Sort headers.
6184         * dwarf2-frame.c: Sort headers.
6185         * dwarf2-frame-tailcall.c: Sort headers.
6186         * dwarf-index-write.h: Sort headers.
6187         * dwarf-index-write.c: Sort headers.
6188         * dwarf-index-common.c: Sort headers.
6189         * dwarf-index-cache.h: Sort headers.
6190         * dwarf-index-cache.c: Sort headers.
6191         * dummy-frame.c: Sort headers.
6192         * dtrace-probe.c: Sort headers.
6193         * disasm.h: Sort headers.
6194         * disasm.c: Sort headers.
6195         * disasm-selftests.c: Sort headers.
6196         * dictionary.c: Sort headers.
6197         * dicos-tdep.c: Sort headers.
6198         * demangle.c: Sort headers.
6199         * dcache.h: Sort headers.
6200         * dcache.c: Sort headers.
6201         * darwin-nat.h: Sort headers.
6202         * darwin-nat.c: Sort headers.
6203         * darwin-nat-info.c: Sort headers.
6204         * d-valprint.c: Sort headers.
6205         * d-namespace.c: Sort headers.
6206         * d-lang.c: Sort headers.
6207         * ctf.c: Sort headers.
6208         * csky-tdep.c: Sort headers.
6209         * csky-linux-tdep.c: Sort headers.
6210         * cris-tdep.c: Sort headers.
6211         * cris-linux-tdep.c: Sort headers.
6212         * cp-valprint.c: Sort headers.
6213         * cp-support.c: Sort headers.
6214         * cp-namespace.c: Sort headers.
6215         * cp-abi.c: Sort headers.
6216         * corelow.c: Sort headers.
6217         * corefile.c: Sort headers.
6218         * continuations.c: Sort headers.
6219         * completer.h: Sort headers.
6220         * completer.c: Sort headers.
6221         * complaints.c: Sort headers.
6222         * coffread.c: Sort headers.
6223         * coff-pe-read.c: Sort headers.
6224         * cli-out.h: Sort headers.
6225         * cli-out.c: Sort headers.
6226         * charset.c: Sort headers.
6227         * c-varobj.c: Sort headers.
6228         * c-valprint.c: Sort headers.
6229         * c-typeprint.c: Sort headers.
6230         * c-lang.c: Sort headers.
6231         * buildsym.c: Sort headers.
6232         * buildsym-legacy.c: Sort headers.
6233         * build-id.h: Sort headers.
6234         * build-id.c: Sort headers.
6235         * btrace.c: Sort headers.
6236         * bsd-uthread.c: Sort headers.
6237         * breakpoint.h: Sort headers.
6238         * breakpoint.c: Sort headers.
6239         * break-catch-throw.c: Sort headers.
6240         * break-catch-syscall.c: Sort headers.
6241         * break-catch-sig.c: Sort headers.
6242         * blockframe.c: Sort headers.
6243         * block.c: Sort headers.
6244         * bfin-tdep.c: Sort headers.
6245         * bfin-linux-tdep.c: Sort headers.
6246         * bfd-target.c: Sort headers.
6247         * bcache.c: Sort headers.
6248         * ax-general.c: Sort headers.
6249         * ax-gdb.h: Sort headers.
6250         * ax-gdb.c: Sort headers.
6251         * avr-tdep.c: Sort headers.
6252         * auxv.c: Sort headers.
6253         * auto-load.c: Sort headers.
6254         * arm-wince-tdep.c: Sort headers.
6255         * arm-tdep.c: Sort headers.
6256         * arm-symbian-tdep.c: Sort headers.
6257         * arm-pikeos-tdep.c: Sort headers.
6258         * arm-obsd-tdep.c: Sort headers.
6259         * arm-nbsd-tdep.c: Sort headers.
6260         * arm-nbsd-nat.c: Sort headers.
6261         * arm-linux-tdep.c: Sort headers.
6262         * arm-linux-nat.c: Sort headers.
6263         * arm-fbsd-tdep.c: Sort headers.
6264         * arm-fbsd-nat.c: Sort headers.
6265         * arm-bsd-tdep.c: Sort headers.
6266         * arch-utils.c: Sort headers.
6267         * arc-tdep.c: Sort headers.
6268         * arc-newlib-tdep.c: Sort headers.
6269         * annotate.h: Sort headers.
6270         * annotate.c: Sort headers.
6271         * amd64-windows-tdep.c: Sort headers.
6272         * amd64-windows-nat.c: Sort headers.
6273         * amd64-tdep.c: Sort headers.
6274         * amd64-sol2-tdep.c: Sort headers.
6275         * amd64-obsd-tdep.c: Sort headers.
6276         * amd64-obsd-nat.c: Sort headers.
6277         * amd64-nbsd-tdep.c: Sort headers.
6278         * amd64-nbsd-nat.c: Sort headers.
6279         * amd64-nat.c: Sort headers.
6280         * amd64-linux-tdep.c: Sort headers.
6281         * amd64-linux-nat.c: Sort headers.
6282         * amd64-fbsd-tdep.c: Sort headers.
6283         * amd64-fbsd-nat.c: Sort headers.
6284         * amd64-dicos-tdep.c: Sort headers.
6285         * amd64-darwin-tdep.c: Sort headers.
6286         * amd64-bsd-nat.c: Sort headers.
6287         * alpha-tdep.c: Sort headers.
6288         * alpha-obsd-tdep.c: Sort headers.
6289         * alpha-nbsd-tdep.c: Sort headers.
6290         * alpha-mdebug-tdep.c: Sort headers.
6291         * alpha-linux-tdep.c: Sort headers.
6292         * alpha-linux-nat.c: Sort headers.
6293         * alpha-bsd-tdep.c: Sort headers.
6294         * alpha-bsd-nat.c: Sort headers.
6295         * aix-thread.c: Sort headers.
6296         * agent.c: Sort headers.
6297         * addrmap.c: Sort headers.
6298         * ada-varobj.c: Sort headers.
6299         * ada-valprint.c: Sort headers.
6300         * ada-typeprint.c: Sort headers.
6301         * ada-tasks.c: Sort headers.
6302         * ada-lang.c: Sort headers.
6303         * aarch64-tdep.c: Sort headers.
6304         * aarch64-ravenscar-thread.c: Sort headers.
6305         * aarch64-newlib-tdep.c: Sort headers.
6306         * aarch64-linux-tdep.c: Sort headers.
6307         * aarch64-linux-nat.c: Sort headers.
6308         * aarch64-fbsd-tdep.c: Sort headers.
6309         * aarch64-fbsd-nat.c: Sort headers.
6310         * aarch32-linux-nat.c: Sort headers.
6311
6312 2019-04-04  Tom Tromey  <tom@tromey.com>
6313
6314         * varobj.c (varobj_create): Update.
6315         * rust-exp.y (struct rust_parser) <update_innermost_block,
6316         lookup_symbol>: New methods.
6317         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6318         Rename.
6319         (rust_parser::rust_lookup_type)
6320         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6321         * printcmd.c (display_command, do_one_display): Update.
6322         * parser-defs.h (struct parser_state) <parser_state>: Add
6323         "tracker" parameter.
6324         (block_tracker): New member.
6325         (class innermost_block_tracker) <innermost_block_tracker>: Add
6326         "types" parameter.
6327         <reset>: Remove method.
6328         (innermost_block): Don't declare.
6329         (null_post_parser): Update.
6330         * parse.c (innermost_block): Remove global.
6331         (write_dollar_variable): Update.
6332         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6333         Remove "tracker_types" parameter.
6334         (parse_expression): Add "tracker" parameter.
6335         (parse_expression_for_completion): Update.
6336         (null_post_parser): Add "tracker" parameter.
6337         * p-exp.y: Update rules.
6338         * m2-exp.y: Update rules.
6339         * language.h (struct language_defn) <la_post_parser>: Add
6340         "tracker" parameter.
6341         * go-exp.y: Update rules.
6342         * f-exp.y: Update rules.
6343         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6344         parameter.
6345         * d-exp.y: Update rules.
6346         * c-exp.y: Update rules.
6347         * breakpoint.c (set_breakpoint_condition): Create an
6348         innermost_block_tracker.
6349         (watch_command_1): Likewise.
6350         * ada-lang.c (resolve): Add "tracker" parameter.
6351         (resolve_subexp): Likewise.
6352         * ada-exp.y (write_var_from_sym): Update.
6353
6354 2019-04-04  Tom Tromey  <tom@tromey.com>
6355
6356         * type-stack.h: New file.
6357         * type-stack.c: New file.
6358         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6359         type-stack.h.
6360         (insert_into_type_stack, insert_type, push_type, push_type_int)
6361         (insert_type_address_space, pop_type, pop_type_int)
6362         (pop_typelist, pop_type_stack, append_type_stack)
6363         (push_type_stack, get_type_stack, push_typelist)
6364         (follow_type_instance_flags, follow_types): Don't declare.
6365         * parse.c (type_stack): Remove global.
6366         (parse_exp_in_context): Update.
6367         (insert_into_type_stack, insert_type, push_type, push_type_int)
6368         (insert_type_address_space, pop_type, pop_type_int)
6369         (pop_typelist, pop_type_stack, append_type_stack)
6370         (push_type_stack, get_type_stack, push_typelist)
6371         (follow_type_instance_flags, follow_types): Remove (moved to
6372         type-stack.c).
6373         * f-exp.y (type_stack): New global.
6374         Update rules.
6375         (push_kind_type, f_parse): Update.
6376         * d-exp.y (type_stack): New global.
6377         Update rules.
6378         (d_parse): Update.
6379         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6380         Update rules.
6381         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6382         (HFILES_NO_SRCDIR): Add type-stack.h.
6383
6384 2019-04-04  Tom Tromey  <tom@tromey.com>
6385
6386         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6387         (rust_parser::convert_ast_to_expression, rust_parse)
6388         (rust_lex_test_completion, rust_lex_tests): Update.
6389         * parser-defs.h (struct expr_completion_state): New.
6390         (struct parser_state) <parser_state>: Add completion parameter.
6391         <mark_struct_expression, mark_completion_tag>: New methods.
6392         <parse_completion, m_completion_state>: New members.
6393         (prefixify_expression, null_post_parser): Update.
6394         (mark_struct_expression, mark_completion_tag): Don't declare.
6395         * parse.c (parse_completion, expout_last_struct)
6396         (expout_tag_completion_type, expout_completion_name): Remove
6397         globals.
6398         (parser_state::mark_struct_expression)
6399         (parser_state::mark_completion_tag): Now methods.
6400         (prefixify_expression): Add last_struct parameter.
6401         (prefixify_subexp): Likewise.
6402         (parse_exp_1): Update.
6403         (parse_exp_in_context): Add cstate parameter.  Update.
6404         (parse_expression_for_completion): Create an
6405         expr_completion_state.
6406         (null_post_parser): Add "completion" parameter.
6407         * p-exp.y: Update rules.
6408         (yylex): Update.
6409         * language.h (struct language_defn) <la_post_parser>: Add
6410         "completing" parameter.
6411         * go-exp.y: Update rules.
6412         (lex_one_token): Update.
6413         * expression.h (parse_completion): Don't declare.
6414         * d-exp.y: Update rules.
6415         (lex_one_token): Update rules.
6416         * c-exp.y: Update rules.
6417         (lex_one_token): Update.
6418         * ada-lang.c (resolve): Add "parse_completion" parameter.
6419         (resolve_subexp): Likewise.
6420         (ada_resolve_function): Likewise.
6421
6422 2019-04-04  Tom Tromey  <tom@tromey.com>
6423
6424         * parser-defs.h (struct parser_state) <start_arglist,
6425         end_arglist>: New methods.
6426         <arglist_len, m_funcall_chain>: New members.
6427         (arglist_len, start_arglist, end_arglist): Don't declare.
6428         * parse.c (arglist_len, funcall_chain): Remove global.
6429         (start_arglist, end_arglist): Remove functions.
6430         (parse_exp_in_context): Update.
6431         * p-exp.y: Update rules.
6432         * m2-exp.y: Update rules.
6433         * go-exp.y: Update rules.
6434         * f-exp.y: Update rules.
6435         * d-exp.y: Update rules.
6436         * c-exp.y: Update rules.
6437
6438 2019-04-04  Tom Tromey  <tom@tromey.com>
6439
6440         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6441         lex_operator, push_back>: New methods.
6442         Update all rules.
6443         (rust_parser::lex_hex, lex_escape): Rename and update.
6444         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6445         (rust_parser::lex_operator): Rename and update.
6446         (rust_parser::lex_number, rustyylex, rustyyerror)
6447         (rust_lex_test_init, rust_lex_test_sequence)
6448         (rust_lex_test_push_back, rust_lex_tests): Update.
6449         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6450         parameter.
6451         <lexptr, prev_lexptr>: New members.
6452         (lexptr, prev_lexptr): Don't declare.
6453         * parse.c (lexptr, prev_lexptr): Remove globals.
6454         (parse_exp_in_context): Update.
6455         * p-exp.y (yylex, yyerror): Update.
6456         * m2-exp.y (parse_number, yylex, yyerror): Update.
6457         * go-exp.y (lex_one_token, yyerror): Update.
6458         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6459         * d-exp.y (lex_one_token, yyerror): Update.
6460         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6461         (lex_one_token, yyerror): Update.
6462         * ada-lex.l (YY_INPUT): Update.
6463         (rewind_to_char): Update.
6464         * ada-exp.y (yyerror): Update.
6465
6466 2019-04-04  Tom Tromey  <tom@tromey.com>
6467
6468         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6469         * parser-defs.h (struct parser_state) <parser_state>: Add new
6470         parameter.
6471         <comma_terminates>: New member.
6472         (comma_terminates): Don't declare global.
6473         * parse.c (comma_terminates): Remove global.
6474         (parse_exp_in_context): Update.
6475         * p-exp.y (yylex): Update.
6476         * m2-exp.y (yylex): Update.
6477         * go-exp.y (lex_one_token): Update.
6478         * f-exp.y (yylex): Update.
6479         * d-exp.y (lex_one_token): Update.
6480         * c-exp.y (lex_one_token): Update.
6481         * ada-lex.l: Update.
6482
6483 2019-04-04  Tom Tromey  <tom@tromey.com>
6484
6485         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6486         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6487         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6488         * parser-defs.h (paren_depth): Don't declare.
6489         * parse.c (paren_depth): Remove global.
6490         (parse_exp_in_context): Update.
6491         * p-exp.y (paren_depth): New global.
6492         (pascal_parse): Initialize it.
6493         * m2-exp.y (paren_depth): New global.
6494         (m2_parse): Initialize it.
6495         * go-exp.y (paren_depth): New global.
6496         (go_parse): Initialize it.
6497         * f-exp.y (paren_depth): New global.
6498         (f_parse): Initialize it.
6499         * d-exp.y (paren_depth): New global.
6500         (d_parse): Initialize it.
6501         * c-exp.y (paren_depth): New global.
6502         (c_parse): Initialize it.
6503         * ada-lex.l (paren_depth): New global.
6504         (lexer_init): Initialize it.
6505
6506 2019-04-04  Tom Tromey  <tom@tromey.com>
6507
6508         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6509         (rust_parser::convert_ast_to_type)
6510         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6511         * parser-defs.h (struct parser_state) <parser_state>: Add
6512         parameters.  Initialize new members.
6513         <expression_context_block, expression_context_pc>: New members.
6514         * parse.c (expression_context_block, expression_context_pc):
6515         Remove globals.
6516         (parse_exp_in_context): Update.
6517         * p-exp.y: Update all rules.
6518         (yylex): Update.
6519         * m2-exp.y: Update all rules.
6520         (yylex): Update.
6521         * go-exp.y (yylex): Update.
6522         * f-exp.y (yylex): Update.
6523         * d-exp.y: Update all rules.
6524         (yylex): Update.
6525         * c-exp.y: Update all rules.
6526         (lex_one_token, classify_name, yylex, c_parse): Update.
6527         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6528
6529 2019-04-04  Tom Tromey  <tom@tromey.com>
6530
6531         * gdbarch.h, gdbarch.c: Rebuild.
6532         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6533         * stap-probe.h:
6534         (struct stap_parse_info): Replace "parser_state" with
6535         "expr_builder".
6536         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6537         (parser_state): New class.
6538         * parse.c (expr_builder): Rename.
6539         (expr_builder::release): Rename.
6540         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6541         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6542         (write_exp_elt_longcst, write_exp_elt_floatcst)
6543         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6544         (write_exp_string_vector, write_exp_bitstring)
6545         (write_exp_msymbol, mark_struct_expression)
6546         (write_dollar_variable)
6547         (insert_type_address_space, increase_expout_size): Replace
6548         "parser_state" with "expr_builder".
6549         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6550         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6551         "parser_state" with "expr_builder".
6552
6553 2019-04-04  Tom Tromey  <tom@tromey.com>
6554
6555         * rust-exp.y: Replace "parse_language" with method call.
6556         * p-exp.y:
6557         (yylex): Replace "parse_language" with method call.
6558         * m2-exp.y:
6559         (yylex): Replace "parse_language" with method call.
6560         * go-exp.y (classify_name): Replace "parse_language" with method
6561         call.
6562         * f-exp.y (yylex): Replace "parse_language" with method call.
6563         * d-exp.y (lex_one_token): Replace "parse_language" with method
6564         call.
6565         * c-exp.y:
6566         (lex_one_token, classify_name, yylex): Replace "parse_language"
6567         with method call.
6568         * ada-exp.y (find_primitive_type, type_char)
6569         (type_system_address): Replace "parse_language" with method call.
6570
6571 2019-04-04  Tom Tromey  <tom@tromey.com>
6572
6573         * rust-exp.y: Replace "parse_gdbarch" with method call.
6574         * parse.c (write_dollar_variable, insert_type_address_space):
6575         Replace "parse_gdbarch" with method call.
6576         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6577         call.
6578         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6579         call.
6580         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6581         "parse_gdbarch" with method call.
6582         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6583         with method call.
6584         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6585         "parse_gdbarch" with method call.
6586         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6587         "parse_gdbarch" with method call.
6588         * c-exp.y (parse_type, parse_number, classify_name): Replace
6589         "parse_gdbarch" with method call.
6590         * ada-lex.l: Replace "parse_gdbarch" with method call.
6591         * ada-exp.y (parse_type, find_primitive_type, type_char)
6592         (type_system_address): Replace "parse_gdbarch" with method call.
6593
6594 2019-04-04  Tom Tromey  <tom@tromey.com>
6595
6596         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6597         * stap-probe.c (stap_parse_argument): Update.
6598         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6599         initial_size parameter.
6600         * rust-exp.y (rust_lex_tests): Update.
6601         * parse.c (parser_state): Update.
6602         (parse_exp_in_context): Update.
6603         * parser-defs.h (struct parser_state) <parser_state>: Remove
6604         "initial_size" parameter.
6605
6606 2019-04-04  Tom Tromey  <tom@tromey.com>
6607
6608         * parser-defs.h (increase_expout_size): Don't declare.
6609         * parse.c (increase_expout_size): Now static.
6610
6611 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6612
6613         * gnu-nat.c (gnu_nat_target::wait): Fix
6614         target_waitstatus_to_string call.
6615
6616 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6617
6618         * eval.c (evaluate_subexp_standard): Handle internal functions
6619         during Fortran function call handling.
6620
6621 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6622
6623         * NEWS: Mention new internal functions.
6624         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6625         (read_base_type): Use dwarf2_init_complex_target_type.
6626         * value.c (creal_internal_fn): New function.
6627         (cimag_internal_fn): New function.
6628         (_initialize_values): Register new internal functions.
6629
6630 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6631
6632         * infrun.c (stop_all_threads): If debug_infrun, always
6633         trace the wait status after wait_one, using
6634         target_waitstatus_to_string and target_pid_to_str.
6635         (handle_inferior_event): Replace various trace of
6636         wait status kind by a single trace.
6637         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6638         wait status kind image by target_waitstatus_to_string.
6639         * target/waitstatus.c (target_waitstatus_to_string): Fix
6640         obsolete comment.
6641
6642 2019-04-01  Tom Tromey  <tromey@adacore.com>
6643
6644         PR symtab/23331:
6645         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6646
6647 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6648             Pedro Alves  <palves@redhat.com>
6649
6650         * top.c (quit_force): Call 'finalize_values'.
6651         * value.c (finalize_values): New function.
6652         * value.h (finalize_values): Declare.
6653
6654 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6655
6656         * NEWS: Announce $_gdb_major and $_gdb_minor.
6657
6658         * top.c (init_gdb_version_vars): New function.
6659         (gdb_init): Call init_gdb_version_vars.
6660
6661 2019-03-29  Tom Tromey  <tromey@adacore.com>
6662
6663         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6664         help text.  Remove dead code.
6665
6666 2019-03-29  Keith Seitz  <keiths@redhat.com>
6667
6668         From Siddhesh Poyarekar:
6669         * f-lang.h (f77_get_upperbound): Return LONGEST.
6670         (f77_get_lowerbound): Likewise.
6671         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6672         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6673         print them.
6674         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6675         plongest to format print it.
6676         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6677         (f77_get_upperbound): Likewise.
6678         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6679         LOWER_BOUND to LONGEST.
6680         (f77_create_arrayprint_offset_tbl): Likewise.
6681
6682 2019-03-29  Keith Seitz  <keiths@redhat.com>
6683
6684         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6685         %s/pulongest for TYPE_LENGTH instead of %d in format
6686         strings.
6687         * ada-typerint.c (ada_print_type): Likewise.
6688         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6689         * compile/compile-c-support.c (generate_register_struct): Likewise.
6690         * gdbtypes.c (recursive_dump_type): Likewise.
6691         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6692         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6693         instead of %d in format strings.
6694         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6695         to std::min to ULONGEST.
6696         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6697         instead of %d in format strings.
6698         * tracepoint.c (info_scope_command): Likewise.
6699         * typeprint.c (print_offset_data::update)
6700         (print_offset_data::finish): Likewise.
6701         * xtensa-tdep.c (xtensa_store_return_value)
6702         (xtensa_push_dummy_call): Likewise.
6703
6704 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6705
6706         * windows-nat.c (display_selector): Fixed format specifications
6707         for 64-bit Cygwin.
6708
6709 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6710
6711         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6712
6713 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6714
6715         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6716         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6717         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6718         (nios2_linux_init_abi): Install it.
6719
6720 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6721
6722         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6723
6724 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6725
6726         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6727
6728 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6729             Tom Tromey  <tromey@adacore.com>
6730
6731         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6732
6733 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6734
6735         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6736         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6737         method to compute the bounds of range types. Also print "[evaluated]"
6738         if the bounds' values come from a dynamic evaluation.
6739
6740 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6741
6742         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6743         whitespace when pretty printing is on.
6744
6745 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6746
6747         * ppc-linux-nat.c: Add include.
6748
6749 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6750
6751         * NEWS: Mention AArch64 Pointer Authentication.
6752
6753 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6754
6755         * arm-linux-nat.c: Add include.
6756
6757 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6758
6759         * source-cache.c (source_cache::get_source_lines): Re-read
6760         fullname after calling open_source_file.
6761
6762 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6763
6764         * NEWS: Mention TLS support for FreeBSD.
6765
6766 2019-03-25  Tom Tromey  <tromey@adacore.com>
6767
6768         * minsyms.c (BUNCH_SIZE): Update comment.
6769         (~minimal_symbol_reader): Remove old comment.
6770         (compact_minimal_symbols): Update comment.
6771         (minimal_symbol_reader::install): Remove old comment.  Update
6772         other comments.
6773
6774 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6775
6776         * s390-linux-nat.c: Add include.
6777
6778 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6779
6780         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6781         Call linux_get_hwcap.
6782         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6783         Likewise.
6784         (aarch64_linux_get_hwcap): Remove function.
6785         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6786         declaration.
6787         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6788         linux_get_hwcap.
6789         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6790         * linux-tdep.c (linux_get_hwcap): Add function.
6791         (linux_get_hwcap2): Likewise.
6792         * linux-tdep.h (linux_get_hwcap): Add declaration.
6793         (linux_get_hwcap2): Likewise.
6794         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6795         (ppc_linux_get_hwcap2): Likewise.
6796         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6797         linux_get_hwcap.
6798         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6799         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6800         (ppc_linux_nat_target::read_description): Likewise.
6801         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6802         * s390-linux-nat.c: Likewise.
6803         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6804
6805 2019-03-24  Tom Tromey  <tom@tromey.com>
6806
6807         * ada-lang.c (standard_lookup): Simplify initialization.
6808         (ada_lookup_symbol_nonlocal): Simplify return.
6809         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6810         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6811         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6812         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6813         initialization.
6814         * solib.c (solib_global_lookup): Simplify.
6815         * symtab.c (null_block_symbol): Remove.
6816         (symbol_cache_lookup): Simplify returns.
6817         (lookup_language_this): Simplify returns.
6818         (lookup_symbol_aux): Simplify return.
6819         (lookup_local_symbol): Simplify returns.
6820         (lookup_global_symbol_from_objfile): Simplify return.
6821         (lookup_symbol_in_objfile_symtabs)
6822         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6823         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6824         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6825         * cp-namespace.c (cp_lookup_bare_symbol)
6826         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6827         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6828         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6829         (cp_lookup_symbol_via_imports): Simplify initialization.
6830         (find_symbol_in_baseclass): Likewise.
6831         * symtab.h (null_block_symbol): Remove.
6832         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6833         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6834         (d_lookup_symbol_module): Likewise.
6835         (find_symbol_in_baseclass): Simplify initialization.
6836
6837 2019-03-24  Tom Tromey  <tom@tromey.com>
6838
6839         * expression.h: Don't include symtab.h.
6840         (struct block): Forward declare.
6841
6842 2019-03-24  Tom Tromey  <tom@tromey.com>
6843
6844         * c-exp.y (typebase): Remove casts.
6845         * gdbtypes.c (lookup_unsigned_typename, )
6846         (lookup_signed_typename): Remove cast.
6847         * eval.c (parse_to_comma_and_eval): Remove cast.
6848         * parse.c (write_dollar_variable): Remove cast.
6849         * block.h (struct block) <superblock>: Now const.
6850         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6851         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6852         (map_block): Make "block" const.
6853         * symfile.h (struct quick_symbol_functions)
6854         <map_matching_symbols>: Constify block argument to "callback".
6855         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6856         const.
6857         (find_pc_sect_compunit_symtab): Make "b" const.
6858         (find_symbol_at_address): Likewise.
6859         (search_symbols): Likewise.
6860         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6861         (dw2_debug_names_lookup_symbol): Likewise.
6862         (dw2_map_matching_symbols): Update.
6863         * p-valprint.c (pascal_val_print): Remove "block".
6864         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6865         (aux_add_nonlocal_symbols): Make "block" const.
6866         (resolve_subexp): Remove cast.
6867         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6868         const.
6869         (iterate_over_file_blocks): Likewise.
6870         * f-exp.y (%union) <bval>: Remove.
6871         * coffread.c (patch_opaque_types): Make "b" const.
6872         * spu-tdep.c (spu_catch_start): Make "block" const.
6873         * c-valprint.c (print_unpacked_pointer): Remove "block".
6874         * symmisc.c (dump_symtab_1): Make "b" const.
6875         (block_depth): Make "block" const.
6876         * d-exp.y (%union) <bval>: Remove.
6877         * cp-support.h (cp_lookup_rtti_type): Update.
6878         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6879         * psymtab.c (psym_lookup_symbol): Make "block" const.
6880         (maintenance_check_psymtabs): Make "b" const.
6881         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6882         (enumerate_locals, enumerate_args): Update.
6883         * python/py-symtab.c (stpy_global_block): Make "block" const.
6884         (stpy_static_block): Likewise.
6885         * inline-frame.c (block_starting_point_at): Make "new_block"
6886         const.
6887         * block.c (find_block_in_blockvector): Make return type const.
6888         (blockvector_for_pc_sect): Make "b" const.
6889         (find_block_in_blockvector): Make "b" const.
6890
6891 2019-03-23  Tom Tromey  <tom@tromey.com>
6892
6893         * varobj.c (varobj_create): Update.
6894         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6895         * printcmd.c (display_command, do_one_display): Don't reset
6896         innermost_block.
6897         * parser-defs.h (enum innermost_block_tracker_type): Move to
6898         expression.h.
6899         (innermost_block): Update comment.
6900         * parse.c (parse_exp_1): Add tracker_types parameter.
6901         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6902         tracker_types parameter.  Reset innermost_block.
6903         (parse_exp_in_context): Remove.
6904         (parse_expression_for_completion): Update.
6905         * objfiles.c (~objfile): Don't reset expression_context_block or
6906         innermost_block.
6907         * expression.h (enum innermost_block_tracker_type): Move from
6908         parser-defs.h.
6909         (parse_exp_1): Add tracker_types parameter.
6910         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6911         reset innermost_block.
6912
6913 2019-03-23  Tom Tromey  <tom@tromey.com>
6914
6915         * objfiles.h: Include bcache.h.
6916
6917 2019-03-23  Tom Tromey  <tom@tromey.com>
6918
6919         * linespec.c (get_current_search_block): Use
6920         scoped_restore_current_language.
6921         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6922
6923 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6924             Jiong Wang  <jiong.wang@arm.com>
6925
6926         * aarch64-linux-tdep.c
6927         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6928         section.
6929         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6930
6931 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6932             Jiong Wang  <jiong.wang@arm.com>
6933
6934         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6935         instructions.
6936         (aarch64_analyze_prologue_test): Add PACIASP test.
6937         (aarch64_prologue_prev_register): Unmask PC value.
6938
6939 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6940             Jiong Wang  <jiong.wang@arm.com>
6941
6942         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6943         (aarch64_dwarf2_prev_register): Unmask PC value.
6944         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6945         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6946         DW_CFA_AARCH64_negate_ra_state.
6947         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6948
6949 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6950             Jiong Wang  <jiong.wang@arm.com>
6951
6952         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6953         registers.
6954         (aarch64_pseudo_register_name): Likewise.
6955         (aarch64_pseudo_register_type): Likewise.
6956         (aarch64_pseudo_register_reggroup_p): Likewise.
6957         (aarch64_gdbarch_init): Add pauth registers.
6958         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6959         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6960         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6961         (struct gdbarch_tdep): Add regnum for ra_state.
6962
6963 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6964             Jiong Wang  <jiong.wang@arm.com>
6965
6966         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6967
6968 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6969             Jiong Wang  <jiong.wang@arm.com>
6970
6971         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6972         function.
6973         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6974         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6975         (aarch64_gdbarch_init): Add puth registers.
6976         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6977         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6978         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6979
6980 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6981             Jiong Wang  <jiong.wang@arm.com>
6982
6983         * aarch64-linux-nat.c
6984         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6985         * aarch64-linux-tdep.c
6986         (aarch64_linux_core_read_description): Likewise.
6987         (aarch64_linux_get_hwcap): New function.
6988         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6989         (aarch64_linux_get_hwcap): New declaration.
6990
6991 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6992             Jiong Wang  <jiong.wang@arm.com>
6993
6994         * aarch64-linux-nat.c
6995         (aarch64_linux_nat_target::read_description): Add pauth param.
6996         * aarch64-linux-tdep.c
6997         (aarch64_linux_core_read_description): Likewise.
6998         * aarch64-tdep.c (struct target_desc): Add in pauth.
6999         (aarch64_read_description): Add pauth param.
7000         (aarch64_gdbarch_init): Likewise.
7001         * aarch64-tdep.h (aarch64_read_description): Likewise.
7002         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7003         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7004         * features/Makefile: Add new files.
7005         * features/aarch64-pauth.c: New file.
7006         * features/aarch64-pauth.xml: New file.
7007
7008 2019-03-20  Tom Tromey  <tromey@adacore.com>
7009
7010         * infrun.c (handle_inferior_event): Rename from
7011         handle_inferior_event_1.  Create a scoped_value_mark.
7012         (handle_inferior_event): Remove.
7013
7014 2019-03-19  Tom Tromey  <tromey@adacore.com>
7015
7016         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7017         * infrun.h (print_stop_event): Add "displays" parameter.
7018         * infrun.c (print_stop_event): Add "displays" parameter.
7019
7020 2019-03-19  Pedro Alves  <palves@redhat.com>
7021
7022         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7023         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7024         to -1.  Fix TABs vs spaces.
7025         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7026         * tui/tui-out.h (tui_ui_out) Add intro comments.
7027         <m_line, m_start_of_line>: In-class initialize, and add describing
7028         comment.
7029
7030 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7031
7032         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7033         variable names.
7034         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7035
7036 2019-03-18  Pedro Alves  <palves@redhat.com>
7037             Eli Zaretskii <eliz@gnu.org>
7038
7039         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7040         m_line and m_start_of_line.
7041
7042 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7043
7044         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7045         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7046         it returns a newline.  This fixes a regression in TU mode, whereby
7047         the next line is output on the same screen line as the user input.
7048
7049 2019-03-18  Tom Tromey  <tromey@adacore.com>
7050
7051         * minsyms.c (minimal_symbol_reader::install): Remove call to
7052         obstack_blank.
7053
7054 2019-03-18  Pedro Alves  <palves@redhat.com>
7055
7056         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7057         New globals.
7058         (apply_style): New, factored out from ...
7059         (apply_ansi_escape): ... this.  Handle reverse video mode.
7060         (tui_set_reverse_mode): New function.
7061         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7062         * tui/tui-winsource.c (tui_show_source_line): Use
7063         tui_set_reverse_mode instead of setting A_STANDOUT.
7064         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7065         New setter methods.
7066
7067 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7068
7069         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7070         Handle tabs.
7071
7072 2019-03-18  Tom Tromey  <tromey@adacore.com>
7073
7074         * ada-lang.c (empty_array): Add "high" parameter.
7075         (ada_evaluate_subexp): Update.
7076
7077 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7078
7079         * unittests/string_view-selftests.c: Define
7080         _initialize_string_view_selftests unconditionally.
7081
7082 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7083
7084         PR gdb/24350
7085         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7086
7087 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7088
7089         PR gdb/24351
7090         * windows-nat.c (display_selector): Fix format specifiers.
7091
7092 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7093
7094         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7095         tui_refill_source_window instead of tui_refresh_win, to update the
7096         current execution line.  This fixes redisplay of the current line
7097         when stepping through the code with "next" or "step".
7098
7099 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7100
7101         * source-cache.c (source_cache::get_source_lines): Call
7102         find_source_lines to initialize s->nlines.  This fixes vertical
7103         scrolling of TUI source window when the DOWN arrow is pressed.
7104
7105 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7106
7107         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7108         linux-thread-db.c (_initialize_thread_db): Likewise.
7109
7110 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7111
7112         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7113         wclrtoeol in tui_show_source_line".  This reverts changes made in
7114         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7115
7116 2019-03-15  Tom Tromey  <tom@tromey.com>
7117
7118         * symtab.h (struct minimal_symbol): Derive from
7119         general_symbol_info.
7120         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7121         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7122         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7123         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7124         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7125         (MSYMBOL_SEARCH_NAME): Update.
7126         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7127         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7128         * minsyms.c (minimal_symbol_reader::record_full): Update.
7129
7130 2019-03-15  Tom Tromey  <tom@tromey.com>
7131
7132         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7133
7134 2019-03-15  Tom Tromey  <tom@tromey.com>
7135
7136         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7137         unique_xmalloc_ptr.
7138         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7139         Update.
7140         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7141         (build_minimal_symbol_hash_tables)
7142         (minimal_symbol_reader::install): Update.
7143
7144 2019-03-15  Tom Tromey  <tom@tromey.com>
7145
7146         * symtab.c (create_demangled_names_hash): Update.
7147         (symbol_set_names): Update.
7148         * objfiles.h (struct objfile_per_bfd_storage)
7149         <demangled_names_hash>: Now an htab_up.
7150         * objfiles.c (objfile_per_bfd_storage): Simplify.
7151
7152 2019-03-15  Tom Tromey  <tom@tromey.com>
7153
7154         * objfiles.h (struct objfile_per_bfd_storage): Declare
7155         destructor.
7156         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7157         New.
7158         (get_objfile_bfd_data): Use new.  Don't initialize
7159         language_of_main.
7160         (free_objfile_per_bfd_storage): Remove.
7161         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7162
7163 2019-03-15  Tom Tromey  <tom@tromey.com>
7164
7165         * symfile.c (reread_symbols): Update.
7166         * objfiles.c (objfile::objfile): Update.
7167         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7168         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7169         comment.
7170         (minimal_symbol_reader::install): Update.
7171         (terminate_minimal_symbol_table): Remove.
7172         * jit.c (jit_object_close_impl): Update.
7173
7174 2019-03-15  Tom Tromey  <tom@tromey.com>
7175
7176         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7177         initializations.
7178
7179 2019-03-15  Tom Tromey  <tom@tromey.com>
7180
7181         * objfiles.h (struct objfile_per_bfd_storage)
7182         <demangled_hash_languages>: Now a bitset.
7183         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7184         (lookup_minimal_symbol): Update.
7185
7186 2019-03-15  Tom Tromey  <tom@tromey.com>
7187
7188         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7189         Don't return the symbol.
7190         * coffread.c (record_minimal_symbol): Use record_full.
7191
7192 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7193
7194         The MS-Windows port of ncurses fails to switch to a color pair if
7195         one or both of the colors are the implicit default colors.  This
7196         change records the default colors when TUI is initialized, and
7197         then specifies them explicitly when a color pair uses the default
7198         colors.  This allows color styling in TUI mode on MS-Windows.
7199
7200         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7201         ncurses_norm_attr.
7202         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7203         colors in ncurses_norm_attr.
7204         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7205         "none", replace it with the default color recorded in
7206         ncurses_norm_attr.
7207
7208 2019-03-14  Tom Tromey  <tromey@adacore.com>
7209
7210         * source-cache.h (class source_cache) <get_source_lines>: Return
7211         std::string.
7212         * source-cache.c (source_cache::extract_lines): Handle case where
7213         first_pos==npos.  Return std::string.
7214         (source_cache::get_source_lines): Update.
7215
7216 2019-03-14  Tom Tromey  <tromey@adacore.com>
7217
7218         * NEWS: Add item for "style sources" commands.
7219         * source-cache.c (source_cache::get_source_lines): Check
7220         source_styling.
7221         * cli/cli-style.c (source_styling): New global.
7222         (_initialize_cli_style): Add "style sources" commands.
7223         (show_style_sources): New function.
7224         * cli/cli-style.h (source_styling): Declare.
7225
7226 2019-03-14  Pedro Alves  <palves@redhat.com>
7227             Tom Tromey  <tromey@adacore.com>
7228
7229         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7230         * tui/tui-winsource.c (tui_refill_source_window): New function,
7231         from...
7232         (tui_horizontal_source_scroll): ... here.  Move some logic.
7233         * cli/cli-style.c (set_style_enabled): Notify new observable.
7234         * tui/tui-hooks.c (tui_redisplay_source): New function.
7235         (tui_attach_detach_observers): Attach or detach
7236         tui_redisplay_source.
7237         * observable.h (source_styling_changed): New observable.
7238         * observable.c: Define source_styling_changed observable.
7239
7240 2019-03-13  Tom Tromey  <tromey@adacore.com>
7241
7242         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7243         (i386_gnu_nat_target::store_registers): Update.
7244         * target-debug.h (target_debug_print_std_string): New macro.
7245         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7246         * windows-tdep.c (display_one_tib): Update.
7247         * tui/tui-stack.c (tui_make_status_line): Update.
7248         * top.c (print_inferior_quit_action): Update.
7249         * thread.c (thr_try_catch_cmd): Update.
7250         (add_thread_with_info): Update.
7251         (thread_target_id_str): Update.
7252         (thr_try_catch_cmd): Update.
7253         (thread_command): Update.
7254         (thread_find_command): Update.
7255         * record-btrace.c (record_btrace_target::info_record)
7256         (record_btrace_resume_thread, record_btrace_target::resume)
7257         (record_btrace_cancel_resume, record_btrace_step_thread)
7258         (record_btrace_target::wait, record_btrace_target::wait)
7259         (record_btrace_target::wait, record_btrace_target::stop): Update.
7260         * progspace.c (print_program_space): Update.
7261         * process-stratum-target.c
7262         (process_stratum_target::thread_address_space): Update.
7263         * linux-fork.c (linux_fork_mourn_inferior)
7264         (detach_checkpoint_command, info_checkpoints_command)
7265         (linux_fork_context): Update.
7266         (linux_fork_detach): Update.
7267         (class scoped_switch_fork_info): Update.
7268         (delete_checkpoint_command): Update.
7269         * infrun.c (follow_fork_inferior): Update.
7270         (follow_fork_inferior): Update.
7271         (proceed_after_vfork_done): Update.
7272         (handle_vfork_child_exec_or_exit): Update.
7273         (follow_exec): Update.
7274         (displaced_step_prepare_throw): Update.
7275         (displaced_step_restore): Update.
7276         (start_step_over): Update.
7277         (resume_1): Update.
7278         (clear_proceed_status_thread): Update.
7279         (proceed): Update.
7280         (print_target_wait_results): Update.
7281         (do_target_wait): Update.
7282         (context_switch): Update.
7283         (stop_all_threads): Update.
7284         (restart_threads): Update.
7285         (finish_step_over): Update.
7286         (handle_signal_stop): Update.
7287         (switch_back_to_stepped_thread): Update.
7288         (keep_going_pass_signal): Update.
7289         (print_exited_reason): Update.
7290         (normal_stop): Update.
7291         * inferior.c (inferior_pid_to_str): Change return type.
7292         (print_selected_inferior): Update.
7293         (add_inferior): Update.
7294         (detach_inferior): Update.
7295         * dummy-frame.c (fprint_dummy_frames): Update.
7296         * dcache.c (dcache_info_1): Update.
7297         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7298         (btrace_fetch, btrace_clear): Update.
7299         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7300         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7301         type.
7302         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7303         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7304         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7305         * gdbarch.c, gdbarch.h: Rebuild.
7306         * gdbarch.sh (core_pid_to_str): Change return type.
7307         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7308         return type.
7309         (windows_nat_target::pid_to_str): Change return type.
7310         (windows_delete_thread): Update.
7311         (windows_nat_target::attach): Update.
7312         (windows_nat_target::files_info): Update.
7313         * target-delegates.c: Rebuild.
7314         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7315         return type.
7316         (sol_thread_target::pid_to_str): Change return type.
7317         * remote.c (class remote_target) <pid_to_str>: Change return
7318         type.
7319         (remote_target::pid_to_str): Change return type.
7320         (extended_remote_target::attach, remote_target::remote_stop_ns)
7321         (remote_target::remote_notif_remove_queued_reply)
7322         (remote_target::push_stop_reply, remote_target::disable_btrace):
7323         Update.
7324         (extended_remote_target::attach): Update.
7325         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7326         type.
7327         (gdbsim_target::pid_to_str): Change return type.
7328         * ravenscar-thread.c (struct ravenscar_thread_target)
7329         <pid_to_str>: Change return type.
7330         (ravenscar_thread_target::pid_to_str): Change return type.
7331         * procfs.c (class procfs_target) <pid_to_str>: Change return
7332         type.
7333         (procfs_target::pid_to_str): Change return type.
7334         (procfs_target::attach): Update.
7335         (procfs_target::detach): Update.
7336         (procfs_target::fetch_registers): Update.
7337         (procfs_target::store_registers): Update.
7338         (procfs_target::wait): Update.
7339         (procfs_target::files_info): Update.
7340         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7341         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7342         return type.
7343         (nto_procfs_target::pid_to_str): Change return type.
7344         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7345         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7346         return type.
7347         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7348         (exit_lwp): Update.
7349         (attach_proc_task_lwp_callback, get_detach_signal)
7350         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7351         (linux_nat_target::resume, wait_lwp, stop_callback)
7352         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7353         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7354         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7355         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7356         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7357         type.
7358         (inf_ptrace_target::attach): Update.
7359         (inf_ptrace_target::files_info): Update.
7360         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7361         type.
7362         (go32_nat_target::pid_to_str): Change return type.
7363         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7364         (gnu_nat_target::wait): Update.
7365         (gnu_nat_target::wait): Update.
7366         (gnu_nat_target::resume): Update.
7367         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7368         (fbsd_nat_target::wait): Update.
7369         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7370         type.
7371         (darwin_nat_target::attach): Update.
7372         * corelow.c (class core_target) <pid_to_str>: Change return type.
7373         (core_target::pid_to_str): Change return type.
7374         * target.c (normal_pid_to_str): Change return type.
7375         (default_pid_to_str): Likewise.
7376         (target_pid_to_str): Change return type.
7377         (target_translate_tls_address): Update.
7378         (target_announce_detach): Update.
7379         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7380         return type.
7381         (bsd_uthread_target::pid_to_str): Change return type.
7382         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7383         type.
7384         (bsd_kvm_target::pid_to_str): Change return type.
7385         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7386         return type.
7387         (aix_thread_target::pid_to_str): Change return type.
7388         * target.h (struct target_ops) <pid_to_str>: Change return type.
7389         (target_pid_to_str, normal_pid_to_str): Likewise.
7390         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7391         type.
7392         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7393         type.
7394         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7395         return type.
7396         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7397         type.
7398         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7399         type.
7400         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7401         return type.
7402
7403 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7404
7405         * NEWS: Mention that the new default MI version is 3.  Mention
7406         changes to the output of commands and events that deal with
7407         multi-location breakpoints.
7408         * breakpoint.c: Include "mi/mi-out.h".
7409         (print_one_breakpoint): Change output syntax if using MI version
7410         >= 3.
7411         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7412         New.
7413         (mi_multi_location_breakpoint_output_fixed): New.
7414         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7415         (mi_cmd_fix_multi_location_breakpoint_output): New.
7416         (mi_multi_location_breakpoint_output_fixed): New.
7417         * mi/mi-cmds.c (mi_cmds): Register command
7418         -fix-multi-location-breakpoint-output.
7419         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7420         interpreter "mi".
7421
7422 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7423
7424         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7425         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7426         instantiate mi_ui_out based on interpreter name.
7427         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7428         * mi/mi-main.c (mi_load_progress): Likewise.
7429
7430 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7431
7432         * NEWS: Combine separate "New targets" sections for 8.3.
7433
7434 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7435
7436         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7437         (ppcfbsd_init_abi): Install gdbarch
7438         "fetch_tls_load_module_address" and "get_thread_local_address"
7439         methods.
7440
7441 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7442
7443         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7444         (riscv_fbsd_init_abi): Install gdbarch
7445         "fetch_tls_load_module_address" and "get_thread_local_address"
7446         methods.
7447
7448 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7449
7450         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7451         (i386fbsd_init_abi): Install gdbarch
7452         "fetch_tls_load_module_address" and "get_thread_local_address"
7453         methods.
7454
7455 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7456
7457         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7458         (amd64fbsd_init_abi): Install gdbarch
7459         "fetch_tls_load_module_address" and "get_thread_local_address"
7460         methods.
7461
7462 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7463
7464         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7465         (struct fbsd_pspace_data): New type.
7466         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7467         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7468         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7469         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7470         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7471
7472 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7473
7474         * gdbtypes.c (lookup_struct_elt): New function.
7475         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7476         * gdbtypes.h (struct struct_elt): New type.
7477         (lookup_struct_elt): New prototype.
7478
7479 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7480
7481         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7482         remove disabled code block.
7483
7484 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7485
7486         * gdbarch.sh (get_thread_local_address): New method.
7487         * gdbarch.h, gdbarch.c: Regenerate.
7488         * target.c (target_translate_tls_address): Use
7489         gdbarch_get_thread_local_address if present instead of
7490         target::get_thread_local_address.
7491
7492 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7493
7494         * target.h (target::get_thread_local_address): Update comment.
7495
7496 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7497
7498         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7499         objfile->separate_debug_objfile_backlink if not NULL.
7500
7501 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7502
7503         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7504         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7505         (amd64bsd_store_inferior_registers): Likewise.
7506         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7507         Enable segment base registers.
7508         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7509         PT_GETFSBASE and PT_GETGSBASE.
7510         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7511         PT_SETGSBASE.
7512         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7513         segment base registers.
7514         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7515
7516 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7517
7518         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7519         Update calls to i386_target_description to add 'segments'
7520         parameter.
7521         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7522         add segment base registers.
7523         * arch/i386.c (i386_create_target_description): Add 'segments'
7524         parameter to enable segment base registers.
7525         * arch/i386.h (i386_create_target_description): Likewise.
7526         * features/i386/32bit-segments.xml: New file.
7527         * features/i386/32bit-segments.c: Generate.
7528         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7529         call to i386_target_description to add 'segments' parameter.
7530         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7531         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7532         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7533         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7534         if feature is present.
7535         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7536         Add 'segments' parameter to call to i386_target_description.
7537         (i386_target_description): Add 'segments' parameter to enable
7538         segment base registers.
7539         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7540         to call to i386_target_description.
7541         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7542         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7543         Define I386_NUM_REGS.
7544         (i386_target_description): Add 'segments' parameter to enable
7545         segment base registers.
7546
7547 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7548
7549         PR/24325
7550         * source-cache.c: #undef open and close, to avoid unresolved
7551         externals during linking.
7552
7553 2019-03-12  Tom Tromey  <tromey@adacore.com>
7554
7555         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7556         const.  Add initializers.
7557         (_initialize_remote): Don't initialize ptid globals.
7558
7559 2019-03-12  Pedro Alves  <palves@redhat.com>
7560
7561         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7562
7563 2019-03-12  Pedro Alves  <palves@redhat.com>
7564
7565         * cp-name-parser.y (main): Remove unused 'len' variable.
7566
7567 2019-03-12  Tom Tromey  <tromey@adacore.com>
7568
7569         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7570         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7571
7572 2019-03-12  Tom Tromey  <tromey@adacore.com>
7573
7574         * linux-nat.c (iterate_over_lwps): Update.
7575         (stop_callback): Remove parameter.
7576         (stop_wait_callback, detach_callback, resume_set_callback)
7577         (select_singlestep_lwp_callback, set_ignore_sigint)
7578         (status_callback, resumed_callback, resume_clear_callback)
7579         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7580         data parameter.
7581         (linux_nat_target::detach, linux_nat_target::resume)
7582         (linux_stop_and_wait_all_lwps, select_event_lwp)
7583         (linux_nat_filter_event, linux_nat_wait_1)
7584         (linux_nat_target::kill, linux_nat_target::stop)
7585         (linux_nat_target::stop): Update.
7586         (linux_nat_resume_callback): Change type.
7587         (resume_stopped_resumed_lwps, count_events_callback)
7588         (select_event_lwp_callback): Likewise.
7589         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7590         * arm-linux-nat.c (struct update_registers_data): Remove.
7591         (update_registers_callback): Change type.
7592         (arm_linux_insert_hw_breakpoint1): Update.
7593         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7594         parameter.
7595         (x86_linux_dr_set_addr): Update.
7596         (x86_linux_dr_set_control): Update.
7597         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7598         (iterate_over_lwps): Use gdb::function_view.
7599         * nat/aarch64-linux-hw-point.c (struct
7600         aarch64_dr_update_callback_param): Remove.
7601         (debug_reg_change_callback): Change type.
7602         (aarch64_notify_debug_reg_change): Update.
7603         * s390-linux-nat.c (s390_refresh_per_info): Update.
7604
7605 2019-03-11  Tom Tromey  <tromey@adacore.com>
7606
7607         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7608         redundant assignment to "this_cu".
7609
7610 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7611
7612         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7613
7614 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7615
7616         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7617         from...
7618         (rank_one_type): ... this.
7619
7620 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7621
7622         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7623         from...
7624         (rank_one_type): ... this.
7625
7626 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7627
7628         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7629         from...
7630         (rank_one_type): ... this.
7631
7632 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7633
7634         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7635         from...
7636         (rank_one_type): ... this.
7637
7638 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7639
7640         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7641         from...
7642         (rank_one_type): ... this.
7643
7644 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7645
7646         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7647         from...
7648         (rank_one_type): ... this.
7649
7650 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7651
7652         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7653         from...
7654         (rank_one_type): ... this.
7655
7656 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7657
7658         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7659         from...
7660         (rank_one_type): ... this.
7661
7662 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7663
7664         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7665         from...
7666         (rank_one_type): ... this.
7667
7668 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7669
7670         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7671         from...
7672         (rank_one_type): ... this.
7673
7674 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7675
7676         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7677         from...
7678         (rank_one_type): ... this.
7679
7680 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7681
7682         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7683         from...
7684         (rank_one_type): ... this.
7685
7686 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7687
7688         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7689         inferior-events' shows the example events.
7690
7691 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7692
7693         Support styling on native MS-Windows console
7694
7695         PR/24315
7696         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7697         on MS-Windows if $TERM is not defined.
7698
7699         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7700
7701         * posix-hdep.c (gdb_console_fputs):
7702         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7703         functions.
7704         * ui-file.h (gdb_console_fputs): Add prototype.
7705
7706         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7707         back to fputs only if the former returns zero.
7708
7709 2019-03-07  Tom Tromey  <tom@tromey.com>
7710
7711         * symmisc.c (print_symbol_bcache_statistics): Update.
7712         (print_objfile_statistics): Update.
7713         * symfile.c (allocate_symtab): Update.
7714         * stabsread.c: Don't include bcache.h.
7715         * psymtab.h (struct psymbol_bcache): Don't declare.
7716         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7717         (psymbol_bcache_init, psymbol_bcache_free)
7718         (psymbol_bcache_get_bcache): Don't declare.
7719         * psymtab.c (struct psymbol_bcache): Remove.
7720         (psymtab_storage::psymtab_storage): Update.
7721         (psymtab_storage::~psymtab_storage): Update.
7722         (psymbol_bcache_init, psymbol_bcache_free)
7723         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7724         (add_psymbol_to_bcache): Update.
7725         (allocate_psymtab): Update.
7726         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7727         macro_cache>: No longer pointers.
7728         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7729         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7730         * macrotab.c (macro_bcache): Update.
7731         * macroexp.c: Don't include bcache.h.
7732         * gdbtypes.c (check_types_worklist): Update.
7733         (types_deeply_equal): Remove TRY/CATCH.  Update.
7734         * elfread.c (elf_symtab_read): Update.
7735         * dwarf2read.c: Don't include bcache.h.
7736         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7737         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7738         (print_bcache_statistics, bcache_memory_used): Don't declare.
7739         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7740         methods.  Rename all data members.
7741         * bcache.c (struct bcache): Move to bcache.h.
7742         (bcache::expand_hash_table): Rename from expand_hash_table.
7743         (bcache): Remove.
7744         (bcache::insert): Rename from bcache_full.
7745         (bcache::compare): Rename from bcache_compare.
7746         (bcache_xmalloc): Remove.
7747         (bcache::~bcache): Rename from bcache_xfree.
7748         (bcache::print_statistics): Rename from print_bcache_statistics.
7749         (bcache::memory_used): Rename from bcache_memory_used.
7750
7751 2019-03-07  Pedro Alves  <palves@redhat.com>
7752
7753         * infrun.c (normal_stop): Also check for
7754         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7755
7756 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7757
7758         * f-lang.c (value_from_host_double): Moved to...
7759         * value.c (value_from_host_double): ...here.
7760         * value.h (value_from_host_double): Declare.
7761         * guile/scm-math.c (vlscm_convert_typed_number): Use
7762         value_from_host_double.
7763         (vlscm_convert_number): Likewise.
7764         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7765         * python/py-value.c (convert_value_from_python): Likewise.
7766
7767 2019-03-06  Tom Tromey  <tom@tromey.com>
7768
7769         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7770
7771 2019-03-06  Tom Tromey  <tom@tromey.com>
7772
7773         * utils.h (free_current_contents): Don't declare.
7774         * utils.c (free_current_contents): Remove.
7775
7776 2019-03-06  Tom Tromey  <tom@tromey.com>
7777
7778         * top.c (quit_force): Update.
7779         * main.c (captured_command_loop): Update.
7780         * common/new-op.c (operator new): Update.
7781         * common/common-exceptions.c (struct catcher)
7782         <save_cleanup_chain>: Remove member.
7783         (exceptions_state_mc_init): Update.
7784         (exception_try_scope_entry): Return nullptr.
7785         (exception_try_scope_exit, exception_rethrow)
7786         (throw_exception_sjlj, throw_exception_cxx): Update.
7787         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7788         (all_cleanups, do_cleanups, discard_cleanups)
7789         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7790         (restore_cleanups, restore_final_cleanups): Don't declare.
7791         (do_final_cleanups): Remove parameter.
7792         * common/cleanups.c (cleanup_chain, make_cleanup)
7793         (make_cleanup_dtor, all_cleanups, do_cleanups)
7794         (discard_my_cleanups, discard_cleanups)
7795         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7796         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7797         (null_cleanup): Remove.
7798         (do_final_cleanups): Remove parameter.
7799
7800 2019-03-06  Tom Tromey  <tom@tromey.com>
7801
7802         * remote.c (remote_target::remote_parse_stop_reply): Use
7803         unique_xmalloc_ptr.
7804
7805 2019-03-06  Tom Tromey  <tom@tromey.com>
7806
7807         * stabsread.c (struct stabs_field_info): Rename from field_info.
7808         <list, fnlist>: Add initializers.
7809         <obstack>: New member.
7810         (read_member_functions, read_struct_fields, read_baseclasses):
7811         Allocate on obstack.  Don't use cleanups.
7812         (read_one_struct_field, read_member_functions, read_struct_fields)
7813         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7814         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7815         (read_struct_type): Update.
7816
7817 2019-03-06  Tom Tromey  <tom@tromey.com>
7818
7819         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7820         * common/filestuff.h (make_cleanup_close): Don't declare.
7821         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7822         Remove.
7823
7824 2019-03-06  Tom Tromey  <tom@tromey.com>
7825
7826         * solib-aix.c: Use make_scope_exit.
7827
7828 2019-03-06  Tom Tromey  <tom@tromey.com>
7829
7830         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7831         Use make_scope_exit.
7832
7833 2019-03-06  Tom Tromey  <tom@tromey.com>
7834
7835         * solib-svr4.c (disable_probes_interface): Remove parameter.
7836         (svr4_handle_solib_event): Use make_scope_exit.
7837
7838 2019-03-06  Tom Tromey  <tom@tromey.com>
7839
7840         * remote.c (struct stop_reply_deleter): Remove.
7841         (stop_reply_up): Update.
7842         (struct stop_reply): Derive from notif_event.  Don't typedef.
7843         <regcache>: Now a std::vector.
7844         (stop_reply_xfree): Remove.
7845         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7846         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7847         (remote_target::discard_pending_stop_replies): Use delete.
7848         (remote_target::remote_parse_stop_reply): Update.
7849         (remote_target::process_stop_reply): Update.
7850         * remote-notif.h (struct notif_event): Add virtual destructor.
7851         Remove "dtr" member.
7852         (struct notif_client) <alloc_event>: Return a unique_ptr.
7853         (notif_event_xfree): Don't declare.
7854         (notif_event_up): New typedef.
7855         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7856         (notif_event_xfree, do_notif_event_xfree): Remove.
7857         (remote_notif_state_xfree): Update.
7858
7859 2019-03-06  Tom Tromey  <tom@tromey.com>
7860
7861         * infrun.c (displaced_step_clear_cleanup): Now a
7862         forward_scope_exit type.
7863         (displaced_step_prepare_throw): Update.
7864         (displaced_step_fixup): Update.
7865
7866 2019-03-06  Tom Tromey  <tom@tromey.com>
7867
7868         * inferior.h (class inferior): Update comment.
7869         * gdbthread.h (class thread_info): Update comment.
7870
7871 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7872             Tom Tromey  <tom@tromey.com>
7873
7874         * stabsread.h (struct stab_section_list): Remove.
7875         (coffstab_build_psymtabs): Update.
7876         * dbxread.c (symbuf_sections): Now a std::vector.
7877         (sect_idx): New global.
7878         (fill_symbuf): Update.
7879         (coffstab_build_psymtabs): Change type of stabsects parameter.
7880         Update.
7881         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7882         std::vector.
7883         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7884         (coff_locate_sections): Update.
7885         (coff_symfile_read): Remove cleanups.  Update.
7886         (init_stringtab): Add storage parameter.
7887         (free_stringtab, free_stringtab_cleanup): Remove.
7888         (init_lineno): Add storage parameter.
7889         (free_linetab, free_linetab_cleanup): Remove.
7890
7891 2019-03-06  Pedro Alves  <palves@redhat.com>
7892
7893         * linux-fork.c (fork_info::clobber_regs): Delete.
7894         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7895         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7896         comment.  Adjust.
7897         (scoped_switch_fork_info::scoped_switch_fork_info)
7898         (checkpoint_command, linux_fork_context): Adjust
7899         fork_save_infrun_state calls.
7900
7901 2019-03-06  Pedro Alves  <palves@redhat.com>
7902
7903         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7904         (inf_has_multiple_threads): Return 'bool' and rewrite using
7905         inferior_info::threads().
7906
7907 2019-03-06  Pedro Alves  <palves@redhat.com>
7908
7909         * linux-fork.c: Include <list>.
7910         (fork_list): Now a std::list instance.
7911         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7912         (forks_exist_p, find_last_fork): Adjust.
7913         (new_fork): Delete.
7914         (one_fork_p): New.
7915         (add_fork): Adjust.
7916         (free_fork): Delete, folded into fork_info::~fork_info().
7917         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7918         Adjust.
7919         (init_fork_list): Delete.
7920         (linux_fork_killall, linux_fork_mourn_inferior)
7921         (linux_fork_detach, info_checkpoints_command): Adjust.
7922         (_initialize_linux_fork): No longer call init_fork_list.
7923
7924 2019-03-06  Pedro Alves  <palves@redhat.com>
7925
7926         * linux-fork.c (new_fork): New, split out of ...
7927         (add_fork): ... this.  Return void.  Move "first fork" special
7928         case from here, to ...
7929         (checkpoint_command): ... here.
7930         * linux-linux.h (add_fork): Return void.
7931
7932 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7933
7934         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7935
7936 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7937             Chris January  <chris.january@arm.com>
7938             David Lecomber  <david.lecomber@arm.com>
7939
7940         * f-exp.y: New token, UNOP_INTRINSIC.
7941         (exp): New pattern using UNOP_INTRINSIC token.
7942         (f77_keywords): Add 'abs' keyword.
7943         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7944         (value_from_host_double): New function.
7945         (evaluate_subexp_f): Support UNOP_ABS.
7946
7947 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7948
7949         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7950         types.
7951
7952 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7953
7954         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7955         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7956         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7957
7958 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7959
7960         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7961
7962 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7963             Chris January  <chris.january@arm.com>
7964
7965         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7966         * f-exp.y: Define 'KIND' token.
7967         (exp): New pattern for KIND expressions.
7968         (ptype): Handle types with a kind extension.
7969         (direct_abs_decl): Extend to spot kind extensions.
7970         (f77_keywords): Add 'kind' to the list.
7971         (push_kind_type): New function.
7972         (convert_to_kind_type): New function.
7973         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7974         * parse.c (operator_length_standard): Likewise.
7975         * parser-defs.h (enum type_pieces): Add tp_kind.
7976         * std-operator.def: Add UNOP_KIND.
7977
7978 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7979
7980         * f-exp.y (f_parse): Set yydebug.
7981
7982 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7983
7984         * f-lang.c (evaluate_subexp_f): New function.
7985         (exp_descriptor_f): New global.
7986         (f_language_defn): Use exp_descriptor_f instead of
7987         exp_descriptor_standard.
7988
7989 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7990
7991         * f-exp.y (struct token): Add comments.
7992         (dot_ops): Remove uppercase versions and the end marker.
7993         (f77_keywords): Likewise.
7994         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7995         entries in the dot_ops array are case insensitive, and use
7996         strncasecmp to compare strings.  Also some whitespace cleanup in
7997         this area.  Similar for the f77_keywords array, except entries in
7998         this list might be case sensitive.
7999
8000 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8001
8002         * f-exp.y (struct f77_boolean_val): Add comments.
8003         (boolean_values): Remove uppercase versions, and end marker.
8004         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8005         and use strncasecmp to achieve case insensitivity.  Additionally,
8006         perform whitespace cleanup around this code.
8007
8008 2019-03-06  Tom Tromey  <tromey@adacore.com>
8009
8010         * remote-sim.c (gdbsim_target_open): Use result of
8011         gdb_argv::release.
8012
8013 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8014         Dirk Schubert  <dirk.schubert@arm.com>
8015         Chris January  <chris.january@arm.com>
8016
8017         * eval.c (evaluate_subexp_standard): Call Fortran argument
8018         wrapping logic.
8019         * f-lang.c (struct value): A value which can be passed into a
8020         Fortran function call.
8021         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8022         where appropriate.
8023         (struct type): Value ready for a Fortran function call.
8024         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8025         is needed.
8026         * f-lang.h (fortran_argument_convert): Declaration.
8027         (fortran_preserve_arg_pointer): Declaration.
8028         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8029
8030 2019-03-05  Tom Tromey  <tromey@adacore.com>
8031
8032         * python/py-prettyprint.c (print_string_repr): Remove #if.
8033         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8034
8035 2019-03-05  Tom Tromey  <tromey@adacore.com>
8036
8037         * target.c (the_dummy_target): Move later.  Change type to
8038         "dummy_target".
8039         (initialize_targets): Don't initialize the_dummy_target.
8040
8041 2019-03-05  Tom Tromey  <tromey@adacore.com>
8042
8043         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8044         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8045
8046 2019-03-05  Tom Tromey  <tromey@adacore.com>
8047
8048         * windows-nat.c (windows_nat_target::attach)
8049         (windows_nat_target::detach): Don't call gdb_flush.
8050         * valprint.c (generic_val_print, val_print, val_print_string):
8051         Don't call gdb_flush.
8052         * utils.c (defaulted_query): Don't call gdb_flush.
8053         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8054         * target.c (target_announce_detach): Don't call gdb_flush.
8055         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8056         * remote.c (extended_remote_target::attach): Don't call
8057         gdb_flush.
8058         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8059         * printcmd.c (do_examine): Don't call gdb_flush.
8060         (info_display_command): Don't call gdb_flush.
8061         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8062         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8063         * memattr.c (info_mem_command): Don't call gdb_flush.
8064         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8065         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8066         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8067         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8068         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8069         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8070         (gnu_nat_target::detach): Don't call gdb_flush.
8071         * f-valprint.c (f_val_print): Don't call gdb_flush.
8072         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8073         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8074         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8075         gdb_flush.
8076         * c-valprint.c (c_val_print): Don't call gdb_flush.
8077         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8078
8079 2019-03-05  Tom Tromey  <tromey@adacore.com>
8080
8081         * varobj.c (update_dynamic_varobj_children): Update.
8082         (install_default_visualizer): Use reset, not release.
8083         * value.c (set_internalvar): Update.
8084         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8085         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8086         ATTRIBUTE_UNUSED_RESULT.
8087
8088 2019-03-05  Tom Tromey  <tromey@adacore.com>
8089
8090         * remote.c (class scoped_remote_fd) <release>: Add
8091         ATTRIBUTE_UNUSED_RESULT.
8092
8093 2019-03-05  Tom Tromey  <tromey@adacore.com>
8094
8095         * macroexp.c (struct macro_buffer) <release>: Add
8096         ATTRIBUTE_UNUSED_RESULT.
8097
8098 2019-03-05  Tom Tromey  <tromey@adacore.com>
8099
8100         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8101         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8102         ATTRIBUTE_UNUSED_RESULT.
8103
8104 2019-03-05  Tom Tromey  <tromey@adacore.com>
8105
8106         * common/scoped_fd.h (class scoped_fd) <release>: Add
8107         ATTRIBUTE_UNUSED_RESULT.
8108
8109 2019-03-05  Tom Tromey  <tromey@adacore.com>
8110
8111         * parser-defs.h (struct parser_state) <release>: Add
8112         ATTRIBUTE_UNUSED_RESULT.
8113
8114 2019-03-05  Tom Tromey  <tromey@adacore.com>
8115
8116         * utils.h (class gdb_argv) <release>: Add
8117         ATTRIBUTE_UNUSED_RESULT.
8118         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8119
8120 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8121
8122         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8123         for-loop range, to avoid compiler warnings.
8124
8125         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8126         avoid compiler warnings about unused variables.
8127
8128         * NEWS: Mention end of support for native debugging on MS-Windows
8129         before XP.
8130
8131         PR gdb/24292
8132         * common/netstuff.c:
8133         * gdbserver/gdbreplay.c
8134         * gdbserver/remote-utils.c:
8135         * ser-tcp.c:
8136         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8137         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8138         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8139         'getaddrinfo' and 'freeaddrinfo' were not available before
8140         Windows XP, and mingw.org's MinGW headers by default define
8141         _WIN32_WINNT to 0x500.
8142
8143 2019-03-01  Gary Benson <gbenson@redhat.com>
8144
8145         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8146
8147 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8148             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8149
8150         PR gdb/8527
8151         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8152         set_sigint_trap, clear_sigint_trap.
8153
8154 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8155
8156         * target.c (target_detach): Clear the regcache and the
8157         frame cache.
8158
8159 2019-02-27  Pedro Alves  <palves@redhat.com>
8160
8161         * utils.c (set_screen_size): When we cap the height/width sizes,
8162         tweak the corresponding command variable to show "unlimited":
8163
8164 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8165             Pedro Alves  <palves@redhat.com>
8166
8167         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8168         before calling rl_set_screen_size.
8169
8170 2019-02-27  Tom Tromey  <tromey@adacore.com>
8171
8172         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8173         define.
8174         * python/py-value.c: Remove Python 2.4 workaround.
8175         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8176         workaround.
8177         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8178         Python 2.4 workaround.
8179         * python/python-internal.h: Remove Python 2.4 comment.
8180         (Py_ssize_t): Don't define.
8181         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8182         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8183         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8184         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8185         * python/python.c (do_start_initialization): Remove Python 2.4
8186         workaround.
8187         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8188         (print_children): Remove Python 2.4 workaround.
8189         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8190         workaround.
8191         (CHARBUFFERPROC_NAME): Remove.
8192         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8193         Python 2.4 workaround.
8194
8195 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8196
8197         * NEWS: Note minimum Python version.
8198
8199 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8200
8201         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8202         code from these functions.  Remove corresponding ifdefs.  Use
8203         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8204         Remove gotos and target of gotos.
8205         (infpy_search_memory): Likewise.
8206
8207 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8208
8209         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8210         (hppa_gdbarch_init): Don't register deleted functions with
8211         gdbarch.
8212
8213 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8214
8215         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8216         (h8300_unwind_sp): Delete.
8217         (h8300_dummy_id): Delete.
8218         (h8300_gdbarch_init): Don't register deleted functions with
8219         gdbarch.
8220
8221 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8222
8223         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8224         (ft32_unwind_pc): Delete.
8225         (ft32_unwind_sp): Delete.
8226         (ft32_gdbarch_init): Don't register deleted functions with
8227         gdbarch.
8228
8229 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8230
8231         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8232         (frv_unwind_pc): Delete.
8233         (frv_unwind_sp): Delete.
8234         (frv_gdbarch_init): Don't register deleted functions with
8235         gdbarch.
8236
8237 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8238
8239         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8240         (riscv_unwind_pc): Delete.
8241         (riscv_unwind_sp): Delete.
8242         (riscv_gdbarch_init): Don't register deleted functions with
8243         gdbarch.
8244
8245 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8246
8247         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8248         (csky_unwind_pc): Delete.
8249         (csky_unwind_sp): Delete.
8250         (csky_gdbarch_init): Don't register deleted functions with
8251         gdbarch.
8252
8253 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8254
8255         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8256         (cris_unwind_pc): Delete.
8257         (cris_unwind_sp): Delete.
8258         (cris_gdbarch_init): Don't register deleted functions with
8259         gdbarch.
8260
8261 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8262
8263         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8264         (bfin_unwind_pc): Delete.
8265         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8266
8267 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8268
8269         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8270         (arm_unwind_pc): Delete.
8271         (arm_unwind_sp): Delete.
8272         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8273
8274 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8275
8276         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8277         (arc_unwind_pc): Delete.
8278         (arc_unwind_sp): Delete.
8279         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8280
8281 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8282
8283         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8284         (alpha_unwind_pc): Delete.
8285         (alpha_gdbarch_init): Don't register deleted functions with
8286         gdbarch.
8287
8288 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8289
8290         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8291         (aarch64_unwind_pc): Delete.
8292         (aarch64_unwind_sp): Delete.
8293         (aarch64_gdbarch_init): Don't register deleted functions with
8294         gdbarch.
8295
8296 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8297
8298         * gdbtypes.c (type_align): Don't consider static members when
8299         computing structure alignment.
8300
8301 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8302
8303         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8304         return 0 for other types.
8305         * arch-utils.c (default_type_align): Always return 0.
8306         * gdbarch.h: Regenerate.
8307         * gdbarch.sh (type_align): Extend comment.
8308         * gdbtypes.c (type_align): Add additional comments, always call
8309         gdbarch_type_align before applying the default rules.
8310         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8311         generic code will then apply a suitable default.
8312         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8313         types, return 0 for other types.
8314
8315 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8316
8317         * NEWS: Create a new section for the next release branch.
8318         Rename the section of the current branch, now that it has
8319         been cut.
8320
8321 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8322
8323         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8324         * version.in: Bump version to 8.3.50.DATE-git.
8325
8326 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8327
8328         * aix-thread.c (ptid_cmp): Remove unused variable.
8329         (get_signaled_thread): Likewise.
8330         (store_regs_user_thread): Likewise.
8331         (store_regs_kernel_thread): Likewise.
8332         (fetch_regs_kernel_thread): Remove shadowed variable.
8333
8334 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8335
8336         * features/riscv/32bit-cpu.xml: Add register numbers.
8337         * features/riscv/32bit-fpu.c: Regenerate.
8338         * features/riscv/32bit-fpu.xml: Add register numbers.
8339         * features/riscv/64bit-cpu.xml: Add register numbers.
8340         * features/riscv/64bit-fpu.c: Regenerate.
8341         * features/riscv/64bit-fpu.xml: Add register numbers.
8342
8343 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8344
8345         * NEWS: Mention two argument form of gdb.Value constructor.
8346         * python/py-value.c (convert_buffer_and_type_to_value): New
8347         function.
8348         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8349         Add support for handling an optional second argument.  Call
8350         convert_buffer_and_type_to_value as appropriate.
8351         * python/python-internal.h (Py_buffer_deleter): New struct.
8352         (Py_buffer_up): New typedef.
8353
8354 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8355
8356         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8357         instead of releasing ownership.
8358
8359 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8360
8361         * dwarf2read.c (open_and_init_dwp_file): Call
8362         elf_numsections instead of bfd_count_sections to initialize
8363         dwp_file->num_sections.
8364
8365 2019-02-25  Tom Tromey  <tromey@adacore.com>
8366
8367         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8368
8369 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8370
8371         * gcore.in: Add '--readnever' option when invoking GDB.
8372
8373 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8374
8375         * MAINTAINERS: Update my email address.
8376
8377 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8378
8379         * build-id.c (build_id_to_debug_bfd_1): New function.
8380         (build_id_to_debug_bfd): Look for separate debug file in
8381         sysroot.
8382
8383 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8384
8385         * gdbarch.sh: Update the copyright year range that is placed into
8386         generated files.
8387
8388 2019-02-22  Keith Seitz  <keiths@redhat.com>
8389
8390         PR symtab/23853
8391         * linespec.c (create_sals_line_offset): Search for the default
8392         symtab's filename instead of its fullname.
8393
8394 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8395
8396         * NEWS: Update style defaults.
8397
8398 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8399
8400         * main.c (captured_main_1): Disable styling in batch mode.
8401
8402 2019-02-20  Tom Tromey  <tom@tromey.com>
8403
8404         * symtab.c (symtab_symbol_info): Fix typos.
8405
8406 2019-02-20  Tom Tromey  <tromey@adacore.com>
8407
8408         * findcmd.c (_initialize_mem_search): Use upper case for
8409         metasyntactic variables.
8410
8411 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8412
8413         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8414         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8415
8416 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8417
8418         * top.h (source_file_name): Change to std::string.
8419         * top.c (source_file_name): Likewise.
8420         (command_line_input): Adjust.
8421         * cli/cli-script.c (script_from_file): Adjust.
8422
8423 2019-02-19  Tom Tromey  <tromey@adacore.com>
8424
8425         * ravenscar-thread.c
8426         (ravenscar_thread_target::update_thread_list): Don't call
8427         ada_build_task_list.
8428         * ada-lang.h (ada_build_task_list): Don't declare.
8429         * ada-tasks.c (struct ada_tasks_inferior_data)
8430         <task_list_valid_p>: Now bool.
8431         (read_known_tasks, ada_task_list_changed)
8432         (ada_tasks_invalidate_inferior_data): Update.
8433         (read_known_tasks_array): Return bool.
8434         (read_known_tasks_list): Likewise.
8435         (read_known_tasks): Return void.
8436         (ada_build_task_list): Now static.
8437
8438 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8439
8440         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8441         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8442
8443 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8444
8445         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8446         variant for ada_tasks_pspace_data_handle and
8447         ada_tasks_inferior_data_handle.
8448         (ada_tasks_pspace_data_cleanup): New function.
8449         (ada_tasks_inferior_data_cleanup): New function.
8450
8451 2019-02-17  Tom Tromey  <tom@tromey.com>
8452
8453         * macrotab.h (macro_source_fullname): Return a std::string.
8454         * macrotab.c (macro_include, check_for_redefinition)
8455         (macro_undef, macro_lookup_definition, foreach_macro)
8456         (foreach_macro_in_scope): Update.
8457         (macro_source_fullname): Return a std::string.
8458         * macrocmd.c (show_pp_source_pos): Update.
8459
8460 2019-02-17  Tom Tromey  <tom@tromey.com>
8461
8462         * macrocmd.c (show_pp_source_pos): Style the file names.
8463
8464 2019-02-17  Tom Tromey  <tom@tromey.com>
8465
8466         PR tui/24197:
8467         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8468
8469 2019-02-17  Tom Tromey  <tom@tromey.com>
8470
8471         * ada-lang.c (user_select_syms): Use filtered printing.
8472         * utils.c (wrap_style): New global.
8473         (desired_style): Remove.
8474         (emit_style_escape): Add stream parameter.
8475         (set_output_style, reset_terminal_style, prompt_for_continue):
8476         Update.
8477         (flush_wrap_buffer): Only flush gdb_stdout.
8478         (wrap_here): Set wrap_style.
8479         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8480         treat escape sequences as a character.  Change when wrap buffer is
8481         flushed.
8482         (fputs_styled): Do not set the output style when the default is
8483         requested.
8484         * ui-style.h (struct ui_file_style) <is_default>: New method.
8485         * source.c (print_source_lines_base): Emit escape sequences in one
8486         piece.
8487
8488 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8489
8490         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8491         integers and enumeration types.
8492
8493 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8494
8495         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8496         instead of lookup_symbol_in_language
8497         (do_exact_match): New function.
8498         (ada_get_symbol_name_matcher): Return do_exact_match when
8499         doing a verbatim match.
8500
8501 2019-02-15  Tom Tromey  <tromey@adacore.com>
8502
8503         * ravenscar-thread.c (ravenscar_thread_target::resume)
8504         (ravenscar_thread_target::wait): Special case wildcard requests.
8505
8506 2019-02-15  Tom Tromey  <tromey@adacore.com>
8507
8508         * ravenscar-thread.c (base_ptid): Remove.
8509         (struct ravenscar_thread_target) <close>: New method.
8510         <m_base_ptid>: New member.
8511         <update_inferior_ptid, active_task, task_is_currently_active,
8512         runtime_initialized>: Declare methods.
8513         <ravenscar_thread_target>: Add constructor.
8514         (ravenscar_thread_target::task_is_currently_active)
8515         (ravenscar_thread_target::update_inferior_ptid)
8516         (ravenscar_runtime_initialized): Rename.  Now methods.
8517         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8518         (ravenscar_thread_target::update_thread_list): Update.
8519         (ravenscar_thread_target::active_task): Now method.
8520         (ravenscar_thread_target::store_registers)
8521         (ravenscar_thread_target::prepare_to_store)
8522         (ravenscar_thread_target::prepare_to_store)
8523         (ravenscar_thread_target::mourn_inferior): Update.
8524         (ravenscar_inferior_created): Use "new" to create target.
8525         (ravenscar_thread_target::get_ada_task_ptid): Update.
8526         (_initialize_ravenscar): Don't initialize base_ptid.
8527         (ravenscar_ops): Remove global.
8528
8529 2019-02-15  Tom Tromey  <tromey@adacore.com>
8530
8531         * target.h (push_target): Declare new overload.
8532         * target.c (push_target): New overload, taking an rvalue reference.
8533         * remote.c (remote_target::open_1): Use push_target overload.
8534         * corelow.c (core_target_open): Use push_target overload.
8535
8536 2019-02-15  Tom Tromey  <tromey@adacore.com>
8537
8538         * ravenscar-thread.c (is_ravenscar_task)
8539         (ravenscar_task_is_currently_active): Return bool.
8540         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8541         (_initialize_ravenscar): Remove "(void)".
8542         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8543         Return bool.
8544
8545 2019-02-15  Tom Tromey  <tromey@adacore.com>
8546
8547         * ravenscar-thread.c (ravenscar_runtime_initializer)
8548         (has_ravenscar_runtime, get_running_thread_id)
8549         (ravenscar_thread_target::resume): Fix indentation.
8550
8551 2019-02-15  Tom Tromey  <tromey@adacore.com>
8552
8553         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8554         from ravenscar_arch_ops.
8555         (sparc_ravenscar_ops::fetch_registers)
8556         (sparc_ravenscar_ops::store_registers): Now methods.
8557         (sparc_ravenscar_prepare_to_store): Remove.
8558         (sparc_ravenscar_ops): Redefine.
8559         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8560         methods and destructor.  Remove members.
8561         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8562         (ravenscar_thread_target::store_registers)
8563         (ravenscar_thread_target::prepare_to_store): Update.
8564         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8565         Remove.
8566         (struct ppc_ravenscar_powerpc_ops): Derive from
8567         ravenscar_arch_ops.
8568         (ppc_ravenscar_powerpc_ops::fetch_registers)
8569         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8570         (ppc_ravenscar_powerpc_ops): Redefine.
8571         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8572         (ppc_ravenscar_e500_ops::fetch_registers)
8573         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8574         (ppc_ravenscar_e500_ops): Redefine.
8575         * aarch64-ravenscar-thread.c
8576         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8577         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8578         (aarch64_ravenscar_fetch_registers)
8579         (aarch64_ravenscar_store_registers): Now methods.
8580         (aarch64_ravenscar_ops): Redefine.
8581
8582 2019-02-15  Tom Tromey  <tromey@adacore.com>
8583
8584         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8585         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8586         (ravenscar_thread_target::stopped_by_watchpoint)
8587         (ravenscar_thread_target::stopped_data_address)
8588         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8589
8590 2019-02-15  Tom Tromey  <tromey@adacore.com>
8591
8592         * ravenscar-thread.c: Fix some typos.
8593
8594 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8595             Tom Tromey  <tromey@adacore.com>
8596
8597         * ada-lang.c (ada_exception_sal): Change addr_string to a
8598         std::string.
8599         (create_ada_exception_catchpoint): Update.
8600
8601 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8602             Tom Tromey  <tromey@adacore.com>
8603
8604         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8605         (bp_location_ops): Remove.
8606         (base_breakpoint_allocate_location): Update.
8607         (free_bp_location): Update.
8608         * ada-lang.c (class ada_catchpoint_location)
8609         <ada_catchpoint_location>: Remove ops parameter.
8610         (ada_catchpoint_location_dtor): Remove.
8611         (ada_catchpoint_location_ops): Remove.
8612         (allocate_location_exception): Update.
8613         * breakpoint.h (struct bp_location_ops): Remove.
8614         (class bp_location) <bp_location>: Remove bp_location_ops
8615         parameter.
8616         <~bp_location>: Add destructor.
8617         <ops>: Remove.
8618
8619 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8620             Pedro Alves  <palves@redhat.com>
8621
8622         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8623         'PATH_MAX'.
8624
8625 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8626             Samuel Thibault  <samuel.thibault@gnu.org>
8627             Thomas Schwinge  <thomas@codesourcery.com>
8628
8629         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8630         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8631
8632 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8633
8634         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8635         (check_empty): Use "const char *".
8636
8637         * gnu-nat.c (gnu_nat_target::detach): Instead of
8638         'detach_inferior (pid)' call
8639         'detach_inferior (find_inferior_pid (pid))'.
8640
8641         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8642         'nat/fork-inferior.o'.
8643         * gnu-nat.c: #include "nat/fork-inferior.h".
8644
8645         * gnu-nat.c (gnu_nat_target::detach): Instead of
8646         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8647         * gnu-nat.h: #include "inf-child.h".
8648         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8649         'i386_gnu_nat_target::fetch_registers'.
8650         (gnu_store_registers): Rename/move to
8651         'i386_gnu_nat_target::store_registers'.
8652
8653         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8654         * gnu-nat.h (mach_thread_info): New function.
8655         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8656
8657         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8658
8659 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8660
8661         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8662
8663 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8664
8665         * windows-nat.c (windows_add_thread): Add new parameter
8666         "main_thread_p" with default value set to false.  Update
8667         function documentation as well as all callers.
8668         (windows_delete_thread): Likewise.
8669         (fake_create_process): Update call to windows_add_thread.
8670         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8671         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8672         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8673         call to windows_delete_thread.
8674
8675 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8676
8677         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8678
8679 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8680
8681         * symfile.c (find_separate_debug_file): Use canonical path of
8682         sysroot with child_path instead of gdb_sysroot if it is valid.
8683
8684 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8685
8686         * symfile.c (find_separate_debug_file): Use child_path to
8687         determine if an object file is under a sysroot.
8688
8689 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8690
8691         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8692         unittests/child-path-selftests.c.
8693         * common/pathstuff.c (child_path): New function.
8694         * common/pathstuff.h (child_path): New prototype.
8695         * unittests/child-path-selftests.c: New file.
8696
8697 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8698
8699         * symfile.c (find_separate_debug_file): Look for separate debug
8700         files in debug directories under the sysroot.
8701
8702 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8703
8704         * symtab.h (struct minimal_symbol data_p): New const method.
8705         (struct minimal_symbol text_p): Likewise.
8706         * symtab.c (output_source_filename): Use file name style
8707         to print file name.
8708         (print_symbol_info): Likewise.
8709         (print_msymbol_info): Use address style to print addresses.
8710         Use function name style to print executable text symbols.
8711         (expand_symtab_containing_pc): Use data_p.
8712         (find_pc_sect_compunit_symtab): Likewise.
8713
8714 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8715
8716         * breakpoint.c (describe_other_breakpoints): Use address style
8717         to print addresses.
8718         (say_where): Likewise.
8719
8720 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8721
8722         * ada-typeprint.c (print_func_type): Print function name
8723         style to print function name.
8724         * c-typeprint.c (c_print_type_1): Likewise.
8725
8726 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8727
8728         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8729         for execve.
8730
8731 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8732
8733         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8734         type_stack.
8735
8736 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8737
8738         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8739         TYPE_CODE_REF types.
8740
8741 2019-02-08  Jim Wilson  <jimw@sifive.com>
8742
8743         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8744         (riscv_linux_fregset): New.
8745         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8746
8747 2019-02-07  Tom Tromey  <tom@tromey.com>
8748
8749         * thread.c (thread_cancel_execution_command): Update.
8750         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8751         methods.
8752         (struct thread_fsm_ops): Remove.
8753         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8754         (thread_fsm_should_stop, thread_fsm_return_value)
8755         (thread_fsm_set_finished, thread_fsm_finished_p)
8756         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8757         Don't declare.
8758         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8759         * infrun.c (clear_proceed_status_thread)
8760         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8761         (print_stop_event): Update.
8762         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8763         Add constructor.
8764         (step_command_fsm_ops): Remove.
8765         (new_step_command_fsm): Remove.
8766         (step_1): Update.
8767         (step_command_fsm::should_stop): Rename from
8768         step_command_fsm_should_stop.
8769         (step_command_fsm::clean_up): Rename from
8770         step_command_fsm_clean_up.
8771         (step_command_fsm::do_async_reply_reason): Rename from
8772         step_command_fsm_async_reply_reason.
8773         (struct until_next_fsm): Inherit from thread_fsm.  Add
8774         constructor.
8775         (until_next_fsm_ops): Remove.
8776         (new_until_next_fsm): Remove.
8777         (until_next_fsm::should_stop): Rename from
8778         until_next_fsm_should_stop.
8779         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8780         (until_next_fsm::do_async_reply_reason): Rename from
8781         until_next_fsm_async_reply_reason.
8782         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8783         constructor.  Change type of breakpoint.
8784         (finish_command_fsm_ops): Remove.
8785         (new_finish_command_fsm): Remove.
8786         (finish_command_fsm::should_stop): Rename from
8787         finish_command_fsm_should_stop.
8788         (finish_command_fsm::clean_up): Rename from
8789         finish_command_fsm_clean_up.
8790         (finish_command_fsm::return_value): Rename from
8791         finish_command_fsm_return_value.
8792         (finish_command_fsm::do_async_reply_reason): Rename from
8793         finish_command_fsm_async_reply_reason.
8794         (finish_command): Update.
8795         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8796         Add constructor.
8797         (call_thread_fsm_ops): Remove.
8798         (call_thread_fsm::call_thread_fsm): Rename from
8799         new_call_thread_fsm.
8800         (call_thread_fsm::should_stop): Rename from
8801         call_thread_fsm_should_stop.
8802         (call_thread_fsm::should_notify_stop): Rename from
8803         call_thread_fsm_should_notify_stop.
8804         (run_inferior_call, call_function_by_hand_dummy): Update.
8805         * cli/cli-interp.c (should_print_stop_to_console): Update.
8806         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8807         Add constructor.  Change type of location_breakpoint,
8808         caller_breakpoint.
8809         (until_break_fsm_ops): Remove.
8810         (new_until_break_fsm): Remove.
8811         (until_break_fsm::should_stop): Rename from
8812         until_break_fsm_should_stop.
8813         (until_break_fsm::clean_up): Rename from
8814         until_break_fsm_clean_up.
8815         (until_break_fsm::do_async_reply_reason): Rename from
8816         until_break_fsm_async_reply_reason.
8817         (until_break_command): Update.
8818         * thread-fsm.c: Remove.
8819         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8820
8821 2019-02-07  Tom Tromey  <tom@tromey.com>
8822
8823         * yy-remap.h: Add include guard.
8824         * xtensa-tdep.h: Add include guard.
8825         * xcoffread.h: Rename include guard.
8826         * varobj-iter.h: Add include guard.
8827         * tui/tui.h: Rename include guard.
8828         * tui/tui-winsource.h: Rename include guard.
8829         * tui/tui-wingeneral.h: Rename include guard.
8830         * tui/tui-windata.h: Rename include guard.
8831         * tui/tui-win.h: Rename include guard.
8832         * tui/tui-stack.h: Rename include guard.
8833         * tui/tui-source.h: Rename include guard.
8834         * tui/tui-regs.h: Rename include guard.
8835         * tui/tui-out.h: Rename include guard.
8836         * tui/tui-layout.h: Rename include guard.
8837         * tui/tui-io.h: Rename include guard.
8838         * tui/tui-hooks.h: Rename include guard.
8839         * tui/tui-file.h: Rename include guard.
8840         * tui/tui-disasm.h: Rename include guard.
8841         * tui/tui-data.h: Rename include guard.
8842         * tui/tui-command.h: Rename include guard.
8843         * tic6x-tdep.h: Add include guard.
8844         * target/waitstatus.h: Rename include guard.
8845         * target/wait.h: Rename include guard.
8846         * target/target.h: Rename include guard.
8847         * target/resume.h: Rename include guard.
8848         * target-float.h: Rename include guard.
8849         * stabsread.h: Add include guard.
8850         * rs6000-tdep.h: Add include guard.
8851         * riscv-fbsd-tdep.h: Add include guard.
8852         * regformats/regdef.h: Rename include guard.
8853         * record.h: Rename include guard.
8854         * python/python.h: Rename include guard.
8855         * python/python-internal.h: Rename include guard.
8856         * python/py-stopevent.h: Rename include guard.
8857         * python/py-ref.h: Rename include guard.
8858         * python/py-record.h: Rename include guard.
8859         * python/py-record-full.h: Rename include guard.
8860         * python/py-record-btrace.h: Rename include guard.
8861         * python/py-instruction.h: Rename include guard.
8862         * python/py-events.h: Rename include guard.
8863         * python/py-event.h: Rename include guard.
8864         * procfs.h: Add include guard.
8865         * proc-utils.h: Add include guard.
8866         * p-lang.h: Add include guard.
8867         * or1k-tdep.h: Rename include guard.
8868         * observable.h: Rename include guard.
8869         * nto-tdep.h: Rename include guard.
8870         * nat/x86-linux.h: Rename include guard.
8871         * nat/x86-linux-dregs.h: Rename include guard.
8872         * nat/x86-gcc-cpuid.h: Add include guard.
8873         * nat/x86-dregs.h: Rename include guard.
8874         * nat/x86-cpuid.h: Rename include guard.
8875         * nat/ppc-linux.h: Rename include guard.
8876         * nat/mips-linux-watch.h: Rename include guard.
8877         * nat/linux-waitpid.h: Rename include guard.
8878         * nat/linux-ptrace.h: Rename include guard.
8879         * nat/linux-procfs.h: Rename include guard.
8880         * nat/linux-osdata.h: Rename include guard.
8881         * nat/linux-nat.h: Rename include guard.
8882         * nat/linux-namespaces.h: Rename include guard.
8883         * nat/linux-btrace.h: Rename include guard.
8884         * nat/glibc_thread_db.h: Rename include guard.
8885         * nat/gdb_thread_db.h: Rename include guard.
8886         * nat/gdb_ptrace.h: Rename include guard.
8887         * nat/fork-inferior.h: Rename include guard.
8888         * nat/amd64-linux-siginfo.h: Rename include guard.
8889         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8890         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8891         * nat/aarch64-linux.h: Rename include guard.
8892         * nat/aarch64-linux-hw-point.h: Rename include guard.
8893         * mn10300-tdep.h: Add include guard.
8894         * mips-linux-tdep.h: Add include guard.
8895         * mi/mi-parse.h: Rename include guard.
8896         * mi/mi-out.h: Rename include guard.
8897         * mi/mi-main.h: Rename include guard.
8898         * mi/mi-interp.h: Rename include guard.
8899         * mi/mi-getopt.h: Rename include guard.
8900         * mi/mi-console.h: Rename include guard.
8901         * mi/mi-common.h: Rename include guard.
8902         * mi/mi-cmds.h: Rename include guard.
8903         * mi/mi-cmd-break.h: Rename include guard.
8904         * m2-lang.h: Add include guard.
8905         * location.h: Rename include guard.
8906         * linux-record.h: Rename include guard.
8907         * linux-nat.h: Add include guard.
8908         * linux-fork.h: Add include guard.
8909         * i386-darwin-tdep.h: Rename include guard.
8910         * hppa-linux-offsets.h: Add include guard.
8911         * guile/guile.h: Rename include guard.
8912         * guile/guile-internal.h: Rename include guard.
8913         * gnu-nat.h: Rename include guard.
8914         * gdb-stabs.h: Rename include guard.
8915         * frv-tdep.h: Add include guard.
8916         * f-lang.h: Add include guard.
8917         * event-loop.h: Add include guard.
8918         * darwin-nat.h: Rename include guard.
8919         * cp-abi.h: Rename include guard.
8920         * config/sparc/nm-sol2.h: Rename include guard.
8921         * config/nm-nto.h: Rename include guard.
8922         * config/nm-linux.h: Add include guard.
8923         * config/i386/nm-i386gnu.h: Rename include guard.
8924         * config/djgpp/nl_types.h: Rename include guard.
8925         * config/djgpp/langinfo.h: Rename include guard.
8926         * compile/gcc-cp-plugin.h: Add include guard.
8927         * compile/gcc-c-plugin.h: Add include guard.
8928         * compile/compile.h: Rename include guard.
8929         * compile/compile-object-run.h: Rename include guard.
8930         * compile/compile-object-load.h: Rename include guard.
8931         * compile/compile-internal.h: Rename include guard.
8932         * compile/compile-cplus.h: Rename include guard.
8933         * compile/compile-c.h: Rename include guard.
8934         * common/xml-utils.h: Rename include guard.
8935         * common/x86-xstate.h: Rename include guard.
8936         * common/version.h: Rename include guard.
8937         * common/vec.h: Rename include guard.
8938         * common/tdesc.h: Rename include guard.
8939         * common/selftest.h: Rename include guard.
8940         * common/scoped_restore.h: Rename include guard.
8941         * common/scoped_mmap.h: Rename include guard.
8942         * common/scoped_fd.h: Rename include guard.
8943         * common/safe-iterator.h: Rename include guard.
8944         * common/run-time-clock.h: Rename include guard.
8945         * common/refcounted-object.h: Rename include guard.
8946         * common/queue.h: Rename include guard.
8947         * common/ptid.h: Rename include guard.
8948         * common/print-utils.h: Rename include guard.
8949         * common/preprocessor.h: Rename include guard.
8950         * common/pathstuff.h: Rename include guard.
8951         * common/observable.h: Rename include guard.
8952         * common/netstuff.h: Rename include guard.
8953         * common/job-control.h: Rename include guard.
8954         * common/host-defs.h: Rename include guard.
8955         * common/gdb_wait.h: Rename include guard.
8956         * common/gdb_vecs.h: Rename include guard.
8957         * common/gdb_unlinker.h: Rename include guard.
8958         * common/gdb_unique_ptr.h: Rename include guard.
8959         * common/gdb_tilde_expand.h: Rename include guard.
8960         * common/gdb_sys_time.h: Rename include guard.
8961         * common/gdb_string_view.h: Rename include guard.
8962         * common/gdb_splay_tree.h: Rename include guard.
8963         * common/gdb_setjmp.h: Rename include guard.
8964         * common/gdb_ref_ptr.h: Rename include guard.
8965         * common/gdb_optional.h: Rename include guard.
8966         * common/gdb_locale.h: Rename include guard.
8967         * common/gdb_assert.h: Rename include guard.
8968         * common/filtered-iterator.h: Rename include guard.
8969         * common/filestuff.h: Rename include guard.
8970         * common/fileio.h: Rename include guard.
8971         * common/environ.h: Rename include guard.
8972         * common/common-utils.h: Rename include guard.
8973         * common/common-types.h: Rename include guard.
8974         * common/common-regcache.h: Rename include guard.
8975         * common/common-inferior.h: Rename include guard.
8976         * common/common-gdbthread.h: Rename include guard.
8977         * common/common-exceptions.h: Rename include guard.
8978         * common/common-defs.h: Rename include guard.
8979         * common/common-debug.h: Rename include guard.
8980         * common/cleanups.h: Rename include guard.
8981         * common/buffer.h: Rename include guard.
8982         * common/btrace-common.h: Rename include guard.
8983         * common/break-common.h: Rename include guard.
8984         * cli/cli-utils.h: Rename include guard.
8985         * cli/cli-style.h: Rename include guard.
8986         * cli/cli-setshow.h: Rename include guard.
8987         * cli/cli-script.h: Rename include guard.
8988         * cli/cli-interp.h: Rename include guard.
8989         * cli/cli-decode.h: Rename include guard.
8990         * cli/cli-cmds.h: Rename include guard.
8991         * charset-list.h: Add include guard.
8992         * buildsym-legacy.h: Rename include guard.
8993         * bfin-tdep.h: Add include guard.
8994         * ax.h: Rename include guard.
8995         * arm-linux-tdep.h: Add include guard.
8996         * arm-fbsd-tdep.h: Add include guard.
8997         * arch/xtensa.h: Rename include guard.
8998         * arch/tic6x.h: Add include guard.
8999         * arch/i386.h: Add include guard.
9000         * arch/arm.h: Rename include guard.
9001         * arch/arm-linux.h: Rename include guard.
9002         * arch/arm-get-next-pcs.h: Rename include guard.
9003         * arch/amd64.h: Add include guard.
9004         * arch/aarch64-insn.h: Rename include guard.
9005         * arch-utils.h: Rename include guard.
9006         * annotate.h: Add include guard.
9007         * amd64-darwin-tdep.h: Rename include guard.
9008         * aarch64-linux-tdep.h: Add include guard.
9009         * aarch64-fbsd-tdep.h: Add include guard.
9010         * aarch32-linux-nat.h: Add include guard.
9011
9012 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9013
9014         * macrotab.c (macro_define_internal): New function that
9015         factorizes macro_define_object_internal and macro_define_function
9016         code.
9017         (macro_define_object_internal): Use macro_define_internal.
9018         (macro_define_function): Likewise.
9019
9020 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9021
9022         * macrocmd.c (extract_identifier): Return
9023         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9024         callers.
9025
9026 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9027
9028         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9029
9030 2019-02-05  Tom Tromey  <tom@tromey.com>
9031
9032         * target.c (target_stack::unpush): Move assertion earlier.
9033
9034 2019-01-30  Tom Tromey  <tom@tromey.com>
9035
9036         PR python/23615:
9037         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9038         (gdbpy_parse_and_eval): Likewise.
9039         * python/python-internal.h (gdbpy_allow_threads): New class.
9040
9041 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9042
9043         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9044         (aarch64_fbsd_fpregmap): Move earlier.
9045         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9046         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9047         instead of individual calls to trad_frame_set_reg_addr.
9048         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9049         earlier.
9050         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9051         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9052         instead of individual calls to trad_frame_set_reg_addr.
9053
9054 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9055
9056         * CONTRIBUTE: Replace contribution list with wiki link.
9057
9058 2019-01-25  Tom Tromey  <tom@tromey.com>
9059
9060         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9061
9062 2019-01-25  Tom Tromey  <tom@tromey.com>
9063
9064         * xtensa-linux-nat.c: Fix common/ includes.
9065         * xml-support.h: Fix common/ includes.
9066         * xml-support.c: Fix common/ includes.
9067         * x86-linux-nat.c: Fix common/ includes.
9068         * windows-nat.c: Fix common/ includes.
9069         * varobj.h: Fix common/ includes.
9070         * varobj.c: Fix common/ includes.
9071         * value.c: Fix common/ includes.
9072         * valops.c: Fix common/ includes.
9073         * utils.c: Fix common/ includes.
9074         * unittests/xml-utils-selftests.c: Fix common/ includes.
9075         * unittests/utils-selftests.c: Fix common/ includes.
9076         * unittests/unpack-selftests.c: Fix common/ includes.
9077         * unittests/tracepoint-selftests.c: Fix common/ includes.
9078         * unittests/style-selftests.c: Fix common/ includes.
9079         * unittests/string_view-selftests.c: Fix common/ includes.
9080         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9081         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9082         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9083         * unittests/rsp-low-selftests.c: Fix common/ includes.
9084         * unittests/parse-connection-spec-selftests.c: Fix common/
9085         includes.
9086         * unittests/optional-selftests.c: Fix common/ includes.
9087         * unittests/offset-type-selftests.c: Fix common/ includes.
9088         * unittests/observable-selftests.c: Fix common/ includes.
9089         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9090         * unittests/memrange-selftests.c: Fix common/ includes.
9091         * unittests/memory-map-selftests.c: Fix common/ includes.
9092         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9093         * unittests/function-view-selftests.c: Fix common/ includes.
9094         * unittests/environ-selftests.c: Fix common/ includes.
9095         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9096         * unittests/common-utils-selftests.c: Fix common/ includes.
9097         * unittests/cli-utils-selftests.c: Fix common/ includes.
9098         * unittests/array-view-selftests.c: Fix common/ includes.
9099         * ui-file.c: Fix common/ includes.
9100         * tui/tui-io.c: Fix common/ includes.
9101         * tracepoint.h: Fix common/ includes.
9102         * tracepoint.c: Fix common/ includes.
9103         * tracefile-tfile.c: Fix common/ includes.
9104         * top.h: Fix common/ includes.
9105         * top.c: Fix common/ includes.
9106         * thread.c: Fix common/ includes.
9107         * target/waitstatus.h: Fix common/ includes.
9108         * target/waitstatus.c: Fix common/ includes.
9109         * target.h: Fix common/ includes.
9110         * target.c: Fix common/ includes.
9111         * target-memory.c: Fix common/ includes.
9112         * target-descriptions.c: Fix common/ includes.
9113         * symtab.h: Fix common/ includes.
9114         * symfile.c: Fix common/ includes.
9115         * stap-probe.c: Fix common/ includes.
9116         * spu-linux-nat.c: Fix common/ includes.
9117         * sparc-nat.c: Fix common/ includes.
9118         * source.c: Fix common/ includes.
9119         * solib.c: Fix common/ includes.
9120         * solib-target.c: Fix common/ includes.
9121         * ser-unix.c: Fix common/ includes.
9122         * ser-tcp.c: Fix common/ includes.
9123         * ser-pipe.c: Fix common/ includes.
9124         * ser-base.c: Fix common/ includes.
9125         * selftest-arch.c: Fix common/ includes.
9126         * s12z-tdep.c: Fix common/ includes.
9127         * rust-exp.y: Fix common/ includes.
9128         * rs6000-aix-tdep.c: Fix common/ includes.
9129         * riscv-tdep.c: Fix common/ includes.
9130         * remote.c: Fix common/ includes.
9131         * remote-notif.h: Fix common/ includes.
9132         * remote-fileio.h: Fix common/ includes.
9133         * remote-fileio.c: Fix common/ includes.
9134         * regcache.h: Fix common/ includes.
9135         * regcache.c: Fix common/ includes.
9136         * record-btrace.c: Fix common/ includes.
9137         * python/python.c: Fix common/ includes.
9138         * python/py-type.c: Fix common/ includes.
9139         * python/py-inferior.c: Fix common/ includes.
9140         * progspace.h: Fix common/ includes.
9141         * producer.c: Fix common/ includes.
9142         * procfs.c: Fix common/ includes.
9143         * proc-api.c: Fix common/ includes.
9144         * printcmd.c: Fix common/ includes.
9145         * ppc-linux-nat.c: Fix common/ includes.
9146         * parser-defs.h: Fix common/ includes.
9147         * osdata.c: Fix common/ includes.
9148         * obsd-nat.c: Fix common/ includes.
9149         * nat/x86-linux.c: Fix common/ includes.
9150         * nat/x86-linux-dregs.c: Fix common/ includes.
9151         * nat/x86-dregs.h: Fix common/ includes.
9152         * nat/x86-dregs.c: Fix common/ includes.
9153         * nat/ppc-linux.c: Fix common/ includes.
9154         * nat/mips-linux-watch.h: Fix common/ includes.
9155         * nat/mips-linux-watch.c: Fix common/ includes.
9156         * nat/linux-waitpid.c: Fix common/ includes.
9157         * nat/linux-ptrace.h: Fix common/ includes.
9158         * nat/linux-ptrace.c: Fix common/ includes.
9159         * nat/linux-procfs.c: Fix common/ includes.
9160         * nat/linux-personality.c: Fix common/ includes.
9161         * nat/linux-osdata.c: Fix common/ includes.
9162         * nat/linux-namespaces.c: Fix common/ includes.
9163         * nat/linux-btrace.h: Fix common/ includes.
9164         * nat/linux-btrace.c: Fix common/ includes.
9165         * nat/fork-inferior.c: Fix common/ includes.
9166         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9167         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9168         * nat/aarch64-linux.c: Fix common/ includes.
9169         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9170         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9171         * namespace.h: Fix common/ includes.
9172         * mips-linux-tdep.c: Fix common/ includes.
9173         * minsyms.c: Fix common/ includes.
9174         * mi/mi-parse.h: Fix common/ includes.
9175         * mi/mi-main.c: Fix common/ includes.
9176         * mi/mi-cmd-env.c: Fix common/ includes.
9177         * memrange.h: Fix common/ includes.
9178         * memattr.c: Fix common/ includes.
9179         * maint.h: Fix common/ includes.
9180         * maint.c: Fix common/ includes.
9181         * main.c: Fix common/ includes.
9182         * machoread.c: Fix common/ includes.
9183         * location.c: Fix common/ includes.
9184         * linux-thread-db.c: Fix common/ includes.
9185         * linux-nat.c: Fix common/ includes.
9186         * linux-fork.c: Fix common/ includes.
9187         * inline-frame.c: Fix common/ includes.
9188         * infrun.c: Fix common/ includes.
9189         * inflow.c: Fix common/ includes.
9190         * inferior.h: Fix common/ includes.
9191         * inferior.c: Fix common/ includes.
9192         * infcmd.c: Fix common/ includes.
9193         * inf-ptrace.c: Fix common/ includes.
9194         * inf-child.c: Fix common/ includes.
9195         * ia64-linux-nat.c: Fix common/ includes.
9196         * i387-tdep.c: Fix common/ includes.
9197         * i386-tdep.c: Fix common/ includes.
9198         * i386-linux-tdep.c: Fix common/ includes.
9199         * i386-linux-nat.c: Fix common/ includes.
9200         * i386-go32-tdep.c: Fix common/ includes.
9201         * i386-fbsd-tdep.c: Fix common/ includes.
9202         * i386-fbsd-nat.c: Fix common/ includes.
9203         * guile/scm-type.c: Fix common/ includes.
9204         * guile/guile.c: Fix common/ includes.
9205         * go32-nat.c: Fix common/ includes.
9206         * gnu-nat.c: Fix common/ includes.
9207         * gdbthread.h: Fix common/ includes.
9208         * gdbarch-selftests.c: Fix common/ includes.
9209         * gdb_usleep.c: Fix common/ includes.
9210         * gdb_select.h: Fix common/ includes.
9211         * gdb_bfd.c: Fix common/ includes.
9212         * gcore.c: Fix common/ includes.
9213         * fork-child.c: Fix common/ includes.
9214         * findvar.c: Fix common/ includes.
9215         * fbsd-nat.c: Fix common/ includes.
9216         * event-top.c: Fix common/ includes.
9217         * event-loop.c: Fix common/ includes.
9218         * dwarf2read.c: Fix common/ includes.
9219         * dwarf2loc.c: Fix common/ includes.
9220         * dwarf2-frame.c: Fix common/ includes.
9221         * dwarf-index-cache.c: Fix common/ includes.
9222         * dtrace-probe.c: Fix common/ includes.
9223         * disasm-selftests.c: Fix common/ includes.
9224         * defs.h: Fix common/ includes.
9225         * csky-tdep.c: Fix common/ includes.
9226         * cp-valprint.c: Fix common/ includes.
9227         * cp-support.h: Fix common/ includes.
9228         * cp-support.c: Fix common/ includes.
9229         * corelow.c: Fix common/ includes.
9230         * completer.h: Fix common/ includes.
9231         * completer.c: Fix common/ includes.
9232         * compile/compile.c: Fix common/ includes.
9233         * compile/compile-loc2c.c: Fix common/ includes.
9234         * compile/compile-cplus-types.c: Fix common/ includes.
9235         * compile/compile-cplus-symbols.c: Fix common/ includes.
9236         * command.h: Fix common/ includes.
9237         * cli/cli-dump.c: Fix common/ includes.
9238         * cli/cli-cmds.c: Fix common/ includes.
9239         * charset.c: Fix common/ includes.
9240         * build-id.c: Fix common/ includes.
9241         * btrace.h: Fix common/ includes.
9242         * btrace.c: Fix common/ includes.
9243         * breakpoint.h: Fix common/ includes.
9244         * breakpoint.c: Fix common/ includes.
9245         * ax.h:
9246         (enum agent_op): Fix common/ includes.
9247         * ax-general.c (struct aop_map): Fix common/ includes.
9248         * ax-gdb.c: Fix common/ includes.
9249         * auxv.c: Fix common/ includes.
9250         * auto-load.c: Fix common/ includes.
9251         * arm-tdep.c: Fix common/ includes.
9252         * arch/riscv.c: Fix common/ includes.
9253         * arch/ppc-linux-common.c: Fix common/ includes.
9254         * arch/i386.c: Fix common/ includes.
9255         * arch/arm.c: Fix common/ includes.
9256         * arch/arm-linux.c: Fix common/ includes.
9257         * arch/arm-get-next-pcs.c: Fix common/ includes.
9258         * arch/amd64.c: Fix common/ includes.
9259         * arch/aarch64.c: Fix common/ includes.
9260         * arch/aarch64-insn.c: Fix common/ includes.
9261         * arch-utils.c: Fix common/ includes.
9262         * amd64-windows-tdep.c: Fix common/ includes.
9263         * amd64-tdep.c: Fix common/ includes.
9264         * amd64-sol2-tdep.c: Fix common/ includes.
9265         * amd64-obsd-tdep.c: Fix common/ includes.
9266         * amd64-nbsd-tdep.c: Fix common/ includes.
9267         * amd64-linux-tdep.c: Fix common/ includes.
9268         * amd64-linux-nat.c: Fix common/ includes.
9269         * amd64-fbsd-tdep.c: Fix common/ includes.
9270         * amd64-fbsd-nat.c: Fix common/ includes.
9271         * amd64-dicos-tdep.c: Fix common/ includes.
9272         * amd64-darwin-tdep.c: Fix common/ includes.
9273         * agent.c: Fix common/ includes.
9274         * ada-lang.h: Fix common/ includes.
9275         * ada-lang.c: Fix common/ includes.
9276         * aarch64-tdep.c: Fix common/ includes.
9277
9278 2019-01-25  Tom Tromey  <tom@tromey.com>
9279
9280         * common/create-version.sh: Use common/version.h.
9281
9282 2019-01-24  Pedro Alves  <palves@redhat.com>
9283
9284         * infrun.c (signal_stop, signal_print, signal_program)
9285         (signal_catch, signal_pass): Now arrays instead of pointers.
9286         (update_signals_program_target, do_target_resume)
9287         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9288         * linux-nat.c (linux_nat_target::pass_signals)
9289         (linux_nat_target::create_inferior, linux_nat_target::attach):
9290         Adjust.
9291         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9292         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9293         * procfs.c (procfs_target::pass_signals): Adjust.
9294         * record-full.c (record_full_target::resume): Adjust.
9295         * remote.c (remote_target::pass_signals)
9296         (remote_target::program_signals): Adjust.
9297         * target-debug.h (target_debug_print_signals): Now takes a
9298         gdb::array_view as parameter.  Adjust.
9299         * target.h (target_ops) <pass_signals, program_signals>: Replace
9300         pointer and length parameters with gdb::array_view.
9301         (target_pass_signals, target_program_signals): Likewise.
9302         * target-delegates.c: Regenerate.
9303
9304 2019-01-24  Pedro Alves  <palves@redhat.com>
9305
9306         * common/forward-scope-exit.h
9307         (forward_scope_exit::forward_scope_exit): Pass arguments to
9308         m_bind_function directly, instead of creating a std::bind and
9309         copying that.
9310
9311 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9312
9313         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9314         for static members.
9315         (pass_in_v_vfp_candidate): Likewise.
9316
9317 2019-01-23  Tom Tromey  <tom@tromey.com>
9318             Pedro Alves  <palves@redhat.com>
9319
9320         * regcache.c (class regcache_invalidator): Remove.
9321         (regcache::raw_write): Use make_scope_exit.
9322
9323 2019-01-23  Tom Tromey  <tom@tromey.com>
9324
9325         * ui-out.h (class ui_out_emit_type): Update comment.
9326
9327 2019-01-23  Tom Tromey  <tom@tromey.com>
9328
9329         * infrun.c (fetch_inferior_event): Update comment.
9330
9331 2019-01-23  Tom Tromey  <tom@tromey.com>
9332             Pedro Alves  <palves@redhat.com>
9333
9334         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9335         parameter.
9336         (fetch_inferior_event): Use SCOPE_EXIT.
9337
9338
9339 2019-01-23  Tom Tromey  <tom@tromey.com>
9340             Pedro Alves  <palves@redhat.com>
9341
9342         * infrun.c (disable_thread_events): Delete.
9343         (stop_all_threads): Use SCOPE_EXIT.
9344
9345 2019-01-23  Tom Tromey  <tom@tromey.com>
9346             Pedro Alves  <palves@redhat.com>
9347
9348         * symfile.c: Include forward-scope-exit.h.
9349         (clear_symtab_users_cleanup): Replace forward declaration with
9350         a FORWARD_SCOPE_EXIT.
9351         (syms_from_objfile_1): Use the forward_scope_exit and
9352         gdb::optional instead of cleanup_function.
9353         (reread_symbols): Use the forward_scope_exit instead of
9354         cleanup_function.
9355         (clear_symtab_users_cleanup): Remove function.
9356
9357 2019-01-23  Tom Tromey  <tom@tromey.com>
9358             Pedro Alves  <palves@redhat.com>
9359
9360         * linux-nat.c: Include scope-exit.h.
9361         (cleanup_target_stop): Remove.
9362         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9363         SCOPE_EXIT.
9364
9365 2019-01-23  Tom Tromey  <tom@tromey.com>
9366             Pedro Alves  <palves@redhat.com>
9367
9368         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9369         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9370
9371 2019-01-23  Tom Tromey  <tom@tromey.com>
9372             Andrew Burgess  <andrew.burgess@embecosm.com>
9373             Pedro Alves  <palves@redhat.com>
9374
9375         * infrun.c (fetch_inferior_event): Use scope_exit.
9376         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9377         * top.c (execute_command): Use scope_exit.
9378         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9379         * utils.c (do_bpstat_clear_actions_cleanup)
9380         (make_bpstat_clear_actions_cleanup): Remove.
9381
9382 2019-01-23  Tom Tromey  <tom@tromey.com>
9383             Pedro Alves  <palves@redhat.com>
9384
9385         * infrun.c: Include "common/scope-exit.h"
9386         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9387         (wait_for_inferior): Use SCOPE_EXIT.
9388         (fetch_inferior_event): Use scope_exit.
9389
9390 2019-01-23  Tom Tromey  <tom@tromey.com>
9391             Pedro Alves  <palves@redhat.com>
9392
9393         * breakpoint.c (create_breakpoint): Remove cleanup.
9394
9395 2019-01-23  Tom Tromey  <tom@tromey.com>
9396             Andrew Burgess  <andrew.burgess@embecosm.com>
9397             Pedro Alves  <palves@redhat.com>
9398
9399 2019-01-23  Pedro Alves  <palves@redhat.com>
9400
9401         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9402
9403 2019-01-23  Pedro Alves  <palves@redhat.com>
9404             Andrew Burgess  <andrew.burgess@embecosm.com>
9405
9406         * gdbthread.h: Include "common/forward-scope-exit.h".
9407         (scoped_finish_thread_state): Redefine custom class in terms of
9408         forward_scope_exit.
9409
9410 2019-01-23  Pedro Alves  <palves@redhat.com>
9411             Andrew Burgess  <andrew.burgess@embecosm.com>
9412
9413         * common/forward-scope-exit.h: New file.
9414
9415 2019-01-23  Pedro Alves  <palves@redhat.com>
9416             Andrew Burgess  <andrew.burgess@embecosm.com>
9417             Tom Tromey  <tom@tromey.com>
9418
9419         * common/scope-exit.h: New file.
9420
9421 2019-01-23  Pedro Alves  <palves@redhat.com>
9422
9423         * common/preprocessor.h (ESC): Rename to ...
9424         (ESC_PARENS): ... this.
9425         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9426         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9427
9428 2019-01-23  Tom Tromey  <tom@tromey.com>
9429
9430         * language.h (class scoped_switch_to_sym_language_if_auto):
9431         Initialize m_lang in both cases.
9432
9433 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9434
9435         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9436         with XCNEW.
9437
9438 2019-01-22  Tom Tromey  <tom@tromey.com>
9439
9440         * corelow.c: Do not include sys/file.h.
9441
9442 2019-01-22  Tom Tromey  <tom@tromey.com>
9443
9444         * tui/tui-wingeneral.h: Include gdb_curses.h.
9445
9446 2019-01-22  Tom Tromey  <tom@tromey.com>
9447
9448         * source-cache.h (class source_cache) <get_source_lines,
9449         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9450
9451 2019-01-22  Tom Tromey  <tom@tromey.com>
9452
9453         * remote-fileio.h (struct remote_target): Declare.
9454
9455 2019-01-22  Tom Tromey  <tom@tromey.com>
9456
9457         * python/py-arch.c: Do not include py-ref.h.
9458         * python/py-bpevent.c: Do not include py-ref.h.
9459         * python/py-cmd.c: Do not include py-ref.h.
9460         * python/py-continueevent.c: Do not include py-ref.h.
9461         * python/py-event.h: Do not include py-ref.h.
9462         * python/py-evtregistry.c: Do not include py-ref.h.
9463         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9464         * python/py-frame.c: Do not include py-ref.h.
9465         * python/py-framefilter.c: Do not include py-ref.h.
9466         * python/py-function.c: Do not include py-ref.h.
9467         * python/py-infevents.c: Do not include py-ref.h.
9468         * python/py-linetable.c: Do not include py-ref.h.
9469         * python/py-objfile.c: Do not include py-ref.h.
9470         * python/py-param.c: Do not include py-ref.h.
9471         * python/py-prettyprint.c: Do not include py-ref.h.
9472         * python/py-progspace.c: Do not include py-ref.h.
9473         * python/py-symbol.c: Do not include py-ref.h.
9474         * python/py-symtab.c: Do not include py-ref.h.
9475         * python/py-type.c: Do not include py-ref.h.
9476         * python/py-unwind.c: Do not include py-ref.h.
9477         * python/py-utils.c: Do not include py-ref.h.
9478         * python/py-value.c: Do not include py-ref.h.
9479         * python/py-varobj.c: Do not include py-ref.h.
9480         * python/py-xmethods.c: Do not include py-ref.h.
9481         * python/python.c: Do not include py-ref.h.
9482         * varobj.c: Do not include py-ref.h.
9483
9484 2019-01-22  Tom Tromey  <tom@tromey.com>
9485
9486         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9487         keyword for bcache.
9488
9489 2019-01-22  Tom Tromey  <tom@tromey.com>
9490
9491         * compile/compile-cplus-types.c: Remove a comment by #include.
9492
9493 2019-01-22  Tom Tromey  <tom@tromey.com>
9494
9495         * compile/gcc-c-plugin.h: Include compile-internal.h.
9496
9497 2019-01-22  Tom Tromey  <tom@tromey.com>
9498
9499         * stabsread.c (EXTERN): Do not define.
9500         (symnum, next_symbol_text_func, processing_gcc_compilation)
9501         (within_function, global_sym_chain, global_stabs)
9502         (previous_stab_code, this_object_header_files)
9503         (n_this_object_header_files)
9504         (n_allocated_this_object_header_files): Define.
9505         * stabsread.h (EXTERN): Never define.  Use "extern".
9506
9507 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9508
9509         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9510         history_value.
9511
9512 2019-01-21  Tom Tromey  <tom@tromey.com>
9513
9514         * ui-out.c: Fix includes.
9515         * tui/tui-source.c: Fix includes.
9516         * target.c: Fix includes.
9517         * remote.c: Fix includes.
9518         * regcache.c: Fix includes.
9519         * python/py-block.c: Fix includes.
9520         * printcmd.c: Fix includes.
9521         * or1k-tdep.c: Fix includes.
9522         * mi/mi-main.c: Fix includes.
9523         * m32r-tdep.c: Fix includes.
9524         * csky-tdep.c: Fix includes.
9525         * compile/compile-cplus-types.c: Fix includes.
9526         * cli/cli-interp.c: Fix includes.
9527
9528 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9529
9530         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9531         for padding.
9532
9533 2019-01-16  Tom Tromey  <tom@tromey.com>
9534
9535         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9536         earlier.
9537         (struct objfile) <msymbols_range>: Move from top level.
9538         <msymbols>: New method.
9539         (class objfile_msymbols): Remove.
9540         * symtab.c (default_collect_symbol_completion_matches_break_on):
9541         Update.
9542         * symmisc.c (dump_msymbols): Update.
9543         * stabsread.c (scan_file_globals): Update.
9544         * objc-lang.c (info_selectors_command, info_classes_command)
9545         (find_methods): Update.
9546         * minsyms.c (find_solib_trampoline_target): Update.
9547         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9548         * coffread.c (coff_symfile_read): Update.
9549         * ada-lang.c (ada_lookup_simple_minsym)
9550         (ada_collect_symbol_completion_matches): Update.
9551
9552 2019-01-16  Tom Tromey  <tom@tromey.com>
9553
9554         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9555         type.  Remove no-argument constructor.
9556         <iterator::operator++>: Simplify.
9557         <begin>: Update.
9558         <end>: Use minimal_symbol_count.
9559
9560 2019-01-16  Tom Tromey  <tom@tromey.com>
9561
9562         * objfiles.h (struct objfile) <psymtabs>: New method.
9563         (class objfile_psymtabs): Remove.
9564         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9565         typedef.
9566         <range>: New method.
9567         (require_partial_symbols): Change return type.
9568         * psymtab.c (require_partial_symbols)
9569         (psym_expand_symtabs_matching): Update.
9570         * mdebugread.c (parse_partial_symbols): Update.
9571         * dbxread.c (dbx_end_psymtab): Update.
9572
9573 2019-01-15  Tom Tromey  <tom@tromey.com>
9574
9575         * symtab.c (lookup_objfile_from_block)
9576         (lookup_symbol_in_objfile_symtabs)
9577         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9578         (find_line_symtab, info_sources_command)
9579         (default_collect_symbol_completion_matches_break_on)
9580         (make_source_files_completion_list): Update.
9581         * symmisc.c (print_objfile_statistics, dump_objfile)
9582         (maintenance_print_symbols, maintenance_info_symtabs)
9583         (maintenance_check_symtabs, maintenance_info_line_tables):
9584         Update.
9585         * source.c (select_source_symtab)
9586         (forget_cached_source_info_for_objfile): Update.
9587         * objfiles.h (class objfile_compunits): Remove.
9588         (struct objfile) <compunits_range>: New typedef.
9589         (compunits): New method.
9590         * objfiles.c (objfile_relocate1): Update.
9591         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9592         * maint.c (count_symtabs_and_blocks): Update.
9593         * linespec.c (iterate_over_all_matching_symtabs): Update.
9594         * cp-support.c (add_symbol_overload_list_qualified): Update.
9595         * coffread.c (coff_symtab_read): Update.
9596         * ada-lang.c (add_nonlocal_symbols)
9597         (ada_collect_symbol_completion_matches)
9598         (ada_add_global_exceptions): Update.
9599
9600 2019-01-15  Tom Tromey  <tom@tromey.com>
9601
9602         * progspace.h (program_space) <objfiles_safe_range>: New
9603         typedef.
9604         <objfiles_safe>: New method.
9605         * objfiles.h (class all_objfiles_safe): Remove.
9606         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9607         * jit.c (jit_inferior_exit_hook): Update.
9608
9609 2019-01-17  Tom Tromey  <tom@tromey.com>
9610
9611         * progspace.h (program_space) <objfiles_range>: New typedef.
9612         <objfiles>: New method.
9613         <objfiles_head>: Rename from objfiles.
9614         (object_files): Update.
9615         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9616         * guile/scm-pretty-print.c
9617         (ppscm_find_pretty_printer_from_objfiles): Update.
9618         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9619         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9620         Update.
9621         * python/py-progspace.c (pspy_get_objfiles): Update.
9622         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9623         Update.
9624         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9625         (objfpy_lookup_objfile_by_build_id): Update.
9626         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9627         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9628         Update.
9629         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9630         (expand_symtab_containing_pc, lookup_objfile_from_block)
9631         (lookup_static_symbol, basic_lookup_transparent_type)
9632         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9633         (find_line_symtab, info_sources_command)
9634         (default_collect_symbol_completion_matches_break_on)
9635         (make_source_files_completion_list, find_main_name): Update.
9636         * symmisc.c (print_symbol_bcache_statistics)
9637         (print_objfile_statistics, maintenance_print_symbols)
9638         (maintenance_print_msymbols, maintenance_print_objfiles)
9639         (maintenance_info_symtabs, maintenance_check_symtabs)
9640         (maintenance_expand_symtabs, maintenance_info_line_tables):
9641         Update.
9642         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9643         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9644         (map_overlay_command, unmap_overlay_command)
9645         (simple_overlay_update, expand_symtabs_matching)
9646         (map_symbol_filenames): Update.
9647         * symfile-debug.c (set_debug_symfile): Update.
9648         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9649         Update.
9650         * source.c (select_source_symtab, forget_cached_source_info):
9651         Update.
9652         * solib.c (solib_read_symbols): Update.
9653         * solib-spu.c (append_ocl_sos): Update.
9654         * psymtab.c (maintenance_print_psymbols)
9655         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9656         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9657         * printcmd.c (info_symbol_command): Update.
9658         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9659         Update.
9660         * objfiles.h (class all_objfiles): Remove.
9661         * objfiles.c (have_partial_symbols, have_full_symbols)
9662         (have_minimal_symbols, qsort_cmp, update_section_map)
9663         (shared_objfile_contains_address_p)
9664         (default_iterate_over_objfiles_in_search_order): Update.
9665         * objc-lang.c (info_selectors_command, info_classes_command)
9666         (find_methods): Update.
9667         * minsyms.c (find_solib_trampoline_target): Update.
9668         * maint.c (maintenance_info_sections)
9669         (maintenance_translate_address, count_symtabs_and_blocks):
9670         Update.
9671         * main.c (captured_main_1): Update.
9672         * linux-thread-db.c (try_thread_db_load_from_pdir)
9673         (has_libpthread): Update.
9674         * linespec.c (iterate_over_all_matching_symtabs)
9675         (search_minsyms_for_name): Update.
9676         * jit.c (jit_find_objf_with_entry_addr): Update.
9677         * hppa-tdep.c (find_unwind_entry)
9678         (hppa_lookup_stub_minimal_symbol): Update.
9679         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9680         Update.
9681         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9682         (elf_gnu_ifunc_resolve_by_got): Update.
9683         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9684         * dwarf-index-write.c (save_gdb_index_command): Update.
9685         * cp-support.c (add_symbol_overload_list_qualified): Update.
9686         * breakpoint.c (create_overlay_event_breakpoint)
9687         (create_longjmp_master_breakpoint)
9688         (create_std_terminate_master_breakpoint)
9689         (create_exception_master_breakpoint): Update.
9690         * blockframe.c (find_pc_partial_function): Update.
9691         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9692         (ada_collect_symbol_completion_matches)
9693         (ada_add_global_exceptions): Update.
9694
9695 2019-01-17  Tom Tromey  <tom@tromey.com>
9696
9697         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9698         declare VEC.
9699         (solib_target_parse_libraries): Change return type.
9700         (library_list_start_segment, library_list_start_section)
9701         (library_list_end_library, library_list_start_library); Update.
9702         (solib_target_free_library_list): Remove.
9703         (solib_target_parse_libraries): Remove cleanup.  Change return
9704         type.
9705         (solib_target_current_sos): Update.
9706
9707 2019-01-17  Tom Tromey  <tromey@bapiya>
9708
9709         * valprint.c: Replace "the the" with "the".
9710         * symtab.c: Replace "the the" with "the".
9711         * solib.c: Replace "the the" with "the".
9712         * solib-dsbt.c: Replace "the the" with "the".
9713         * linespec.c: Replace "the the" with "the".
9714         * dwarf2loc.h: Replace "the the" with "the".
9715         * amd64-windows-tdep.c: Replace "the the" with "the".
9716         * aarch64-tdep.c: Replace "the the" with "the".
9717
9718 2019-01-16  Keith Seitz  <keiths@redhat.com>
9719
9720         PR gdb/23773
9721         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9722         <builder>: Rename to ..
9723         <m_builder>: ... this and make private.
9724         (dwarf2_cu::get_builder): New method.  Change all users of
9725         `builder' to use this method.
9726         (dwarf2_start_symtab): Move to ...
9727         (dwarf2_cu::start_symtab): ... here.  Update all callers
9728         (setup_type_unit_groups): Move to ...
9729         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9730         callers.
9731         (dwarf2_cu::reset_builder): New method.
9732         (process_full_compunit, process_full_type_unit): Use
9733         dwarf2_cu::reset_builder.
9734         (follow_die_offset): Record the ancestor CU if it is different
9735         from the followed DIE's CU.
9736         (follow_die_sig_1): Likewise.
9737
9738 2019-01-15  Tom Tromey  <tom@tromey.com>
9739
9740         * remote.c (class remote_state) <buf>: Now a char_vector.
9741         <buf_size>: Remove.
9742         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9743         parameter.
9744         (remote_target::getpkt_or_notif_sane_1)
9745         (remote_target::getpkt_sane)
9746         (remote_target::getpkt_or_notif_sane): Likewise.
9747         (class remote_target) <putpkt>: New overload.
9748         (remote_target::read_frame): Change type of "buf_p".  Remove
9749         sizeof_p parameter.
9750         (packet_ok): New overload.
9751         (packet_check_result): New overload.
9752         Update all uses.
9753
9754 2019-01-14  Tom Tromey  <tom@tromey.com>
9755
9756         * remote-notif.c (handle_notification, remote_notif_ack)
9757         (remote_notif_parse): Make "buf" const.
9758         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9759         const.
9760         (remote_notif_parse, remote_notif_ack, handle_notification):
9761         Likewise.
9762         * remote.c (remote_notif_stop_parse): Make "buf" const.
9763         (remote_target::remote_parse_stop_reply): Make "buf" const.
9764         (remote_notif_stop_ack): Make "buf" const.
9765
9766 2019-01-14  Tom Tromey  <tom@tromey.com>
9767
9768         * remote.c (remote_console_output): Make parameter const.
9769
9770 2019-01-14  Tom Tromey  <tom@tromey.com>
9771
9772         * target-debug.h (target_debug_print_signals): Constify.
9773         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9774         * procfs.c (procfs_target::pass_signals): Update.
9775         * linux-nat.c (linux_nat_target::pass_signals): Update.
9776         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9777         * target-delegates.c: Rebuild.
9778         * remote.c (remote_target::program_signals): Update.
9779         (remote_target::pass_signals): Update.
9780         * target.c (target_pass_signals): Constify argument.
9781         (target_program_signals): Likewise.
9782         * target.h (struct target_ops) <pass_signals, program_signals>:
9783         Constify argument.
9784         (target_pass_signals, target_program_signals): Constify argument.
9785
9786 2019-01-14  Tom Tromey  <tom@tromey.com>
9787
9788         PR tui/28819:
9789         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9790
9791 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9792
9793         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9794         field.
9795         * rs6000-tdep.c: Include reggroups.h.
9796         (IS_V_ALIAS_PSEUDOREG): Define.
9797         (rs6000_register_name): Return names for the "vX" aliases.
9798         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9799         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9800         aliases.  Call default_register_reggroup_p for all other
9801         pseudo-registers.
9802         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9803         New functions.
9804         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9805         Handle "vX" aliases.
9806         (v_alias_pseudo_register_collect): New function.
9807         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9808         (rs6000_gdbarch_init): Initialize "vX" aliases as
9809         pseudo-registers.  Restore registration of
9810         rs6000_pseudo_register_reggroup_p with
9811         set_tdesc_pseudo_register_reggroup_p.
9812
9813 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9814
9815         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9816         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9817         set_gdbarch_num_pseudo_regs.
9818
9819 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9820
9821         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9822         Remove arg prefixname, add do_set and do_show.
9823         Add member functions set_list and show_list.
9824         * cli/cli-style.c (class cli_style_option): Update accordingly.
9825         (style_set_list): Move to file scope.
9826         (style_show_list): Likewise.
9827         (set_style): Call help_list.
9828         (show_style): Call cmd_show_list.
9829         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9830         Update to use the new macro.
9831
9832 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9833
9834         * ada-lang.c (_initialize_ada_language): Expand the help text
9835         for the "catch exception" command.
9836
9837 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9838
9839         * symtab.c (matching_obj_sections): Initialize obj,
9840         declare it closer to its usage.
9841
9842 2019-01-10  Tom Tromey  <tom@tromey.com>
9843
9844         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9845         (basic_inf_threads_range): Remove.
9846         (inf_threads_range, inf_non_exited_threads_range)
9847         (safe_inf_threads_range): Use next_adapter.
9848
9849 2019-01-10  Keith Seitz  <keiths@redhat.com>
9850
9851         PR gdb/23712
9852         PR symtab/23010
9853         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9854         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9855
9856 2019-01-10  Keith Seitz  <keiths@redhat.com>
9857
9858         PR gdb/23712
9859         PR symtab/23010
9860         * dictionary.c (pending_to_vector): Remove.
9861         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9862         Remove _1 suffix, replacing functions of the same name.  Update
9863         all callers.
9864         (dict_create_hashed, dict_create_hashed_expandable)
9865         (dict_create_linear, dict_create_linear_expandable, dict_free)
9866         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9867         Make functions static.
9868
9869 2019-01-10  Keith Seitz  <keiths@redhat.com>
9870
9871         PR gdb/23712
9872         PR symtab/23010
9873         * dictionary.h (struct dictionary): Replace declaration with
9874         multidictionary.
9875         (dict_create_hashed, dict_create_hashed_expandable)
9876         (dict_create_linear, dict_create_linear_expandable)
9877         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9878         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9879         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9880         taking multidictionary argument.
9881         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9882         * block.h (struct block) <dict>: Change to multidictionary
9883         and rename `multidict'.
9884         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9885         symmisc.c: Update all dictionary references to multidictionary.
9886
9887 2019-01-10  Keith Seitz  <keiths@redhat.com>
9888
9889         PR gdb/23712
9890         PR symtab/23010
9891         * dictionary.c: Include unordered_map.
9892         (pending_to_vector): New function.
9893         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9894         Rewrite the non-"_1" functions to take vector instead
9895         of linked list.
9896         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9897         "new" _1 versions of the same name.
9898         (multidictionary): Define.
9899         (std::hash<enum language): New definition.
9900         (collate_pending_symbols_by_language, mdict_create_hashed)
9901         (mdict_create_hashed_expandable, mdict_create_linear)
9902         (mdict_create_linear_expandable, mdict_free)
9903         (find_language_dictionary, create_new_language_dictionary)
9904         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9905         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9906         (mdict_size, mdict_empty): New functions.
9907         * dictionary.h (mdict_iterator): Define.
9908
9909 2019-01-10  Pedro Alves  <palves@redhat.com>
9910
9911         * breakpoint.c (read_uploaded_action)
9912         (create_tracepoint_from_upload): Adjust to use
9913         gdb::unique_xmalloc_ptr.
9914         * ctf.c (ctf_write_uploaded_tp):
9915         (SET_ARRAY_FIELD): Use emplace_back.
9916         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9917         * tracefile-tfile.c (tfile_write_uploaded_tp):
9918         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9919         gdb::unique_xmalloc_ptr.
9920         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9921         at_string, cond_string, cmd_strings>: Replace char pointers
9922         with gdb::unique_xmalloc_ptr.
9923
9924 2019-01-10  Pedro Alves  <palves@redhat.com>
9925
9926         * solib-target.c (library_list_start_library): Don't xstrdup name.
9927
9928 2019-01-10  Pedro Alves  <palves@redhat.com>
9929
9930         * mdebugread.c (parse_partial_symbols): Use
9931         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9932
9933 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9934
9935         * linux-fork.c (scoped_switch_fork_info)
9936         <~scoped_switch_fork_info>: Fix incorrect variable name.
9937
9938 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9939
9940         * linux-fork.c (scoped_switch_fork_info)
9941         <scoped_switch_fork_info>: Make explicit.
9942         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9943
9944 2019-01-10  Tom Tromey  <tom@tromey.com>
9945
9946         * objfiles.h (objfile::reset_psymtabs): Update.
9947         * objfiles.c (objfile::objfile): Update.
9948         * psymtab.h (psymtab_storage::obstack): Update.
9949         (psymtab_storage::m_obstack): Use gdb::optional.
9950         (class psymtab_storage): Update comment.  Remove objfile
9951         parameter.
9952         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9953
9954 2019-01-10  Tom Tromey  <tom@tromey.com>
9955
9956         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9957         <free_psymtabs>: Now private.
9958         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9959         (allocate_psymtab): Use new method.
9960
9961 2019-01-10  Tom Tromey  <tom@tromey.com>
9962
9963         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9964         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9965         * mdebugread.c (parse_partial_symbols): Use
9966         allocate_dependencies.
9967         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9968         allocate_dependencies.
9969         (process_psymtab_comp_unit_reader)
9970         (build_type_psymtab_dependencies): Likewise.
9971         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9972
9973 2019-01-10  Tom Tromey  <tom@tromey.com>
9974
9975         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9976         PSYMBOL_SET_LANGUAGE.
9977         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9978
9979 2019-01-10  Tom Tromey  <tom@tromey.com>
9980
9981         * psymtab.h (psymtab_storage::obstack): New method.
9982         <m_obstack>: Rename from obstack; now private.
9983         * psymtab.c (psymtab_storage): Update.
9984         * dwarf2read.c (create_addrmap_from_index)
9985         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9986         Update.
9987
9988 2019-01-10  Tom Tromey  <tom@tromey.com>
9989
9990         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9991         * objfiles.h (objfile::reset_psymtabs): New method.
9992
9993 2019-01-10  Tom Tromey  <tom@tromey.com>
9994
9995         * symmisc.c (print_symbol_bcache_statistics): Update.
9996         (print_objfile_statistics): Update.
9997         * symfile.c (reread_symbols): Update.
9998         * psymtab.h (class psymtab_storage): New.
9999         * psymtab.c (psymtab_storage): New constructor.
10000         (~psymtab_storage): New destructor.
10001         (require_partial_symbols): Update.
10002         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10003         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10004         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10005         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10006         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10007         (start_psymtab_common, end_psymtab_common)
10008         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10009         (allocate_psymtab): Update.
10010         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10011         Update.
10012         (dump_psymtab_addrmap, maintenance_print_psymbols)
10013         (maintenance_check_psymtabs): Update.
10014         (class objfile_psymtabs): Move to objfiles.h.
10015         * psympriv.h (discard_psymtab): Now inline.
10016         (psymtab_discarder::psymtab_discarder): Update.
10017         (psymtab_discarder::~psymtab_discarder): Update.
10018         (ALL_OBJFILE_PSYMTABS): Rewrite.
10019         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10020         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10021         Remove fields.
10022         <partial_symtabs>: New field.
10023         (class objfile_psymtabs): Move from psymtab.h.  Update.
10024         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10025         psymbol_cache.
10026         (objfile::~objfile): Don't destroy psymbol_cache.
10027         * mdebugread.c (parse_partial_symbols): Update.
10028         * dwarf2read.c (create_addrmap_from_index)
10029         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10030         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10031         (add_partial_subprogram, dwarf2_ranges_read): Update.
10032         * dwarf-index-write.c (write_address_map)
10033         (write_one_signatured_type, recursively_write_psymbols)
10034         (class debug_names, class debug_names, write_psymtabs_to_index):
10035         Update.
10036
10037 2019-01-10  Tom Tromey  <tom@tromey.com>
10038
10039         * symtab.h (SYMBOL_SET_NAMES): Update.
10040         (symbol_set_names): Update.
10041         (MSYMBOL_SET_NAMES): Update.
10042         * symtab.c (symbol_set_names): Change argument to be an
10043         objfile_per_bfd_storage.
10044         * psymtab.c (add_psymbol_to_bcache): Update.
10045         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10046
10047 2019-01-10  Tom Tromey  <tom@tromey.com>
10048
10049         * symtab.c (create_demangled_names_hash): Change argument to be an
10050         objfile_per_bfd_storage.
10051         (symbol_set_names): Update.
10052
10053 2019-01-10  Tom Tromey  <tom@tromey.com>
10054
10055         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10056         init_psymbol_list.
10057         * psymtab.c (init_psymbol_list): Do nothing if already called.
10058         * psympriv.h (init_psymbol_list): Add comment.
10059         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10060         init_psymbol_list.
10061         * dbxread.c (dbx_symfile_read): Unconditionally call
10062         init_psymbol_list.
10063
10064 2019-01-10  Tom Tromey  <tom@tromey.com>
10065
10066         * xcoffread.c (scan_xcoff_symtab): Update.
10067         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10068         "where".
10069         * mdebugread.c (parse_partial_symbols)
10070         (handle_psymbol_enumerators): Update.
10071         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10072         * dbxread.c (read_dbx_symtab): Update.
10073         * psympriv.h (psymbol_placement): New enum.
10074         (add_psymbol_to_list): Update.
10075
10076 2019-01-10  Tom Tromey  <tom@tromey.com>
10077
10078         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10079         static_psymbols parameters.
10080         (scan_xcoff_symtab): Update.
10081         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10082         static_psymbols parameters.
10083         * psympriv.h (start_psymtab_common): Update.
10084         * mdebugread.c (parse_partial_symbols): Update.
10085         * dwarf2read.c (create_partial_symtab): Update.
10086         * dbxread.c (read_dbx_symtab): Update.
10087         (start_psymtab): Remove global_psymbols and static_psymbols
10088         parameters.
10089
10090 2019-01-10  Tom Tromey  <tom@tromey.com>
10091
10092         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10093         * psymtab.c (allocate_psymtab): Add comment.
10094         * psympriv.h (allocate_psymtab): Add comment.
10095         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10096         initializations.
10097         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10098
10099 2019-01-10  Tom Tromey  <tom@tromey.com>
10100
10101         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10102         Don't declare.
10103         * mipsread.c: Include mdebugread.h.
10104         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10105         Declare.
10106         * elfread.c: Include mdebugread.h.
10107
10108 2019-01-09  Tom Tromey  <tom@tromey.com>
10109
10110         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10111         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10112         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10113         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10114         (psym_lookup_symbol, psym_find_last_source_symtab)
10115         (psym_forget_cached_source_info, psym_print_stats)
10116         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10117         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10118         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10119         (psym_find_compunit_symtab_by_address)
10120         (maintenance_print_psymbols, maintenance_info_psymtabs)
10121         (maintenance_check_psymtabs): Use ranged for.
10122         * psymtab.h (class objfile_psymtabs): New.
10123         (require_partial_symbols): Return objfile_psymtabs.
10124         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10125
10126 2019-01-09  Tom Tromey  <tom@tromey.com>
10127
10128         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10129         (find_pc_mapped_section, list_overlays_command)
10130         (map_overlay_command, unmap_overlay_command)
10131         (simple_overlay_update): Use all_objfiles.
10132         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10133         * printcmd.c (info_symbol_command): Use all_objfiles.
10134         * objfiles.h (ALL_OBJSECTIONS): Remove.
10135         * maint.c (maintenance_translate_address): Use all_objfiles.
10136         * gcore.c (gcore_create_callback): Use all_objfiles.
10137         (objfile_find_memory_regions): Likewise.
10138
10139 2019-01-09  Tom Tromey  <tom@tromey.com>
10140
10141         * symtab.c (find_line_symtab, info_sources_command)
10142         (make_source_files_completion_list): Use objfile_compunits.
10143         * source.c (select_source_symtab): Use objfile_compunits.
10144         * objfiles.h (struct objfile): Update comment.
10145         (ALL_OBJFILES): Remove.
10146         (ALL_FILETABS): Remove.
10147         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10148         objfile_compunits.
10149
10150 2019-01-09  Tom Tromey  <tom@tromey.com>
10151
10152         * symmisc.c (print_objfile_statistics, dump_objfile)
10153         (maintenance_print_symbols): Use compunit_filetabs.
10154         * source.c (forget_cached_source_info_for_objfile): Use
10155         compunit_filetabs.
10156         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10157         (ALL_FILETABS): Use compunit_filetabs.
10158         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10159         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10160
10161 2019-01-09  Tom Tromey  <tom@tromey.com>
10162
10163         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10164         (compunit_filetabs): New.
10165         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10166         compunit_filetabs.
10167         (info_sources_command, make_source_files_completion_list): Remove
10168         declaration.
10169         * symmisc.c (print_objfile_statistics, dump_objfile)
10170         (maintenance_print_symbols): Remove declaration.
10171         (maintenance_info_symtabs): Use compunit_filetabs.
10172         (maintenance_info_line_tables): Likewise.
10173         * source.c (select_source_symtab): Change local variable name.
10174         (forget_cached_source_info_for_objfile): Remove declaration.
10175         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10176         * objfiles.c (objfile_relocate1): Remove declaration.
10177         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10178         declaration.
10179         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10180         * coffread.c (coff_symtab_read): Remove declaration.
10181         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10182         compunit_filetabs.
10183
10184 2019-01-09  Tom Tromey  <tom@tromey.com>
10185
10186         * symtab.c (lookup_objfile_from_block)
10187         (find_pc_sect_compunit_symtab, search_symbols)
10188         (default_collect_symbol_completion_matches_break_on): Use
10189         objfile_compunits.
10190         * objfiles.h (ALL_COMPUNITS): Remove.
10191         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10192         * cp-support.c (add_symbol_overload_list_qualified): Use
10193         objfile_compunits.
10194         * ada-lang.c (ada_collect_symbol_completion_matches)
10195         (ada_add_global_exceptions): Use objfile_compunits.
10196
10197 2019-01-09  Tom Tromey  <tom@tromey.com>
10198
10199         * source.c (select_source_symtab)
10200         (forget_cached_source_info_for_objfile): Remove declaration.
10201         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10202         declaration.
10203         * maint.c (count_symtabs_and_blocks): Remove declaration.
10204         * cp-support.c (add_symbol_overload_list_qualified): Remove
10205         declaration.
10206         * coffread.c (coff_symtab_read): Remove declaration.
10207         * symtab.c (lookup_symbol_in_objfile_symtabs)
10208         (basic_lookup_transparent_type_1): Use objfile_compunits.
10209         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10210         (info_sources_command, search_symbols)
10211         (default_collect_symbol_completion_matches_break_on)
10212         (make_source_files_completion_list): Remove declaration.
10213         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10214         (ada_collect_symbol_completion_matches)
10215         (ada_add_global_exceptions): Remove declaration.
10216         * linespec.c (iterate_over_all_matching_symtabs): Use
10217         objfile_compunits.
10218         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10219         (class objfile_compunits): New.
10220         (ALL_COMPUNITS): Use objfile_compunits.
10221         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10222         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10223         objfile_compunits.
10224         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10225
10226 2019-01-09  Tom Tromey  <tom@tromey.com>
10227
10228         * symtab.c (search_symbols)
10229         (default_collect_symbol_completion_matches_break_on): Use
10230         objfile_msymbols.
10231         * ada-lang.c (ada_lookup_simple_minsym)
10232         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10233         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10234         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10235         objfile_msymbols.
10236         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10237         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10238         * objc-lang.c (find_methods): Use objfile_msymbols.
10239         (info_selectors_command, info_classes_command): Likewise.
10240         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10241         * objfiles.h (class objfile_msymbols): New.
10242         (ALL_OBJFILE_MSYMBOLS): Remove.
10243         (ALL_MSYMBOLS): Remove.
10244
10245 2019-01-09  Tom Tromey  <tom@tromey.com>
10246
10247         * common/next-iterator.h (next_adapter): Add Iterator template
10248         parameter.
10249         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10250         (class all_objfiles_safe): New.
10251         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10252         * objfiles.c (put_objfile_before): Update comment.
10253         (add_separate_debug_objfile): Likewise.
10254         (free_all_objfiles): Use all_objfiles_safe.
10255         (objfile_purge_solibs): Likewise.
10256
10257 2019-01-09  Tom Tromey  <tom@tromey.com>
10258
10259         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10260         (expand_symtab_containing_pc, lookup_static_symbol)
10261         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10262         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10263         all_objfiles.
10264         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10265         * breakpoint.c (create_overlay_event_breakpoint)
10266         (create_longjmp_master_breakpoint)
10267         (create_std_terminate_master_breakpoint)
10268         (create_exception_master_breakpoint): Use all_objfiles.
10269         * linux-thread-db.c (try_thread_db_load_from_pdir)
10270         (has_libpthread): Use all_objfiles.
10271         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10272         * linespec.c (iterate_over_all_matching_symtabs)
10273         (search_minsyms_for_name): Use all_objfiles.
10274         * maint.c (maintenance_info_sections): Use all_objfiles.
10275         * main.c (captured_main_1): Use all_objfiles.
10276         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10277         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10278         * guile/scm-pretty-print.c
10279         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10280         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10281         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10282         (maintenance_print_msymbols): Use all_objfiles.
10283         * source.c (select_source_symtab): Use all_objfiles.
10284         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10285         * symfile.c (remove_symbol_file_command)
10286         (expand_symtabs_matching, map_symbol_filenames): Use
10287         all_objfiles.
10288         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10289         all_objfiles.
10290         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10291         * objc-lang.c (find_methods): Use all_objfiles.
10292         * objfiles.c (have_partial_symbols, have_full_symbols)
10293         (have_minimal_symbols, qsort_cmp)
10294         (default_iterate_over_objfiles_in_search_order): Use
10295         all_objfiles.
10296         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10297         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10298         (maintenance_check_psymtabs): Use all_objfiles.
10299         (ALL_PSYMTABS): Remove.
10300         * compile/compile-object-run.c (do_module_cleanup): Use
10301         all_objfiles.
10302         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10303         * cp-support.c (add_symbol_overload_list_qualified): Use
10304         all_objfiles.
10305         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10306         Use all_objfiles.
10307         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10308         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10309         all_objfiles.
10310         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10311         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10312         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10313         Uses all_objfiles.
10314         * solib.c (solib_read_symbols): Use all_objfiles
10315
10316 2019-01-09  Tom Tromey  <tom@tromey.com>
10317
10318         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10319         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10320         all_objfiles.
10321         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10322         * symmisc.c (print_symbol_bcache_statistics)
10323         (print_objfile_statistics, maintenance_print_objfiles)
10324         (maintenance_info_symtabs, maintenance_check_symtabs)
10325         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10326         all_objfiles.
10327         * source.c (forget_cached_source_info): Use all_objfiles.
10328         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10329         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10330         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10331         * objfiles.c (update_section_map): Use all_objfiles.
10332         (shared_objfile_contains_address_p): Likewise.
10333         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10334         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10335
10336 2019-01-09  Tom Tromey  <tom@tromey.com>
10337
10338         * common/next-iterator.h: New file.
10339         * objfiles.h (class all_objfiles): New.
10340         (struct objfile_iterator): New.
10341
10342 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10343
10344         * NEWS: Move the description of the changed "frame", "select-frame",
10345          and "info frame" commands to the Changed commands section.
10346
10347 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10348
10349         * gdbtypes.c (check_stub_method_group): Remove handling of old
10350         mangling schemes.
10351         * linespec.c (find_methods): Likewise.
10352         * stabsread.c (read_member_functions): Likewise.
10353         * valops.c (search_struct_method): Likewise.
10354         (value_struct_elt_for_reference): Likewise.
10355         * NEWS: Mention this change.
10356
10357 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10358
10359         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10360         print_source_lines.
10361         * source.c (print_source_lines_base): Update line number check.
10362         (print_source_lines): New function.
10363         (source_lines_range::source_lines_range): New function.
10364         * source.h (class source_lines_range): New class.
10365         (print_source_lines): New declaration.
10366
10367 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10368
10369         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10370
10371 2019-01-08  Tom Tromey  <tom@tromey.com>
10372             Simon Marchi  <simon.marchi@ericsson.com>
10373
10374         PR gdb/24060
10375         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10376         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10377         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10378         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10379         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10380         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10381
10382 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10383
10384         * source.c (select_source_symtab): Move header comment to
10385         declaration in source.h.
10386         (forget_cached_source_info_for_objfile): Likewise.
10387         (forget_cached_source_info): Likewise.
10388         (identify_source_line): Likewise.
10389         * source.h (identify_source_line): Move declaration from symtab.h
10390         and add comment from source.c
10391         (print_source_lines): Likewise.
10392         (forget_cached_source_info_for_objfile): Likewise.
10393         (forget_cached_source_info): Likewise.
10394         (select_source_symtab): Likewise.
10395         (enum print_source_lines_flag): Move definition from symtab.h.
10396         * symtab.h (identify_source_line): Move declaration to source.h.
10397         (print_source_lines): Likewise.
10398         (forget_cached_source_info_for_objfile): Likewise.
10399         (forget_cached_source_info): Likewise.
10400         (select_source_symtab): Likewise.
10401         (enum print_source_lines_flag): Move definition to source.h.
10402         * tui/tui-hooks.c: Add 'source.h' include.
10403
10404 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10405
10406         * source.c (print_source_lines_base): Handle requests to print
10407         reverse line number sequences, and guard against empty lines
10408         string.
10409
10410 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10411
10412         * source.c (print_source_lines_base): Fix skip of '\r' if next
10413         character is '\n'.
10414
10415 2019-01-06  Tom Tromey  <tom@tromey.com>
10416
10417         * c-exp.y (struct c_parse_state) <macro_original_text,
10418         expansion_obstack>: New member.
10419         (macro_original_text, expansion_obstack): Remove globals.
10420         (scan_macro_expansion, scanning_macro_expansion)
10421         (finished_macro_expansion): Update.
10422         (scan_macro_cleanup): Remove.
10423         (yylex, c_parse): Update.
10424
10425 2019-01-06  Tom Tromey  <tom@tromey.com>
10426
10427         * c-exp.y (struct c_parse_state) <strings>: New member.
10428         (operator_stoken): Update.
10429
10430 2019-01-06  Tom Tromey  <tom@tromey.com>
10431
10432         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10433         (union type_stack_elt) <typelist_val>: Now a pointer to
10434         std::vector.
10435         (type_stack_cleanup): Don't declare.
10436         (push_typelist): Update.
10437         * parse.c (pop_typelist): Return a std::vector.
10438         (push_typelist): Take a std::vector.
10439         (follow_types): Update.  Do not free args.
10440         (type_stack_cleanup): Remove.
10441         * c-exp.y (struct c_parse_state): New.
10442         (cpstate): New global.
10443         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10444         (nonempty_typelist): Update.
10445         (func_mod): Create a new vector.
10446         (c_parse): Create a c_parse_state.
10447         (check_parameter_typelist): Do not delete params.
10448         (function_method): Update.  Do not delete type_list.
10449
10450 2019-01-06  Tom Tromey  <tom@tromey.com>
10451
10452         PR gdb/28155:
10453         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10454         check_typedef.
10455         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10456         (print_return_value): Likewise.
10457
10458 2019-01-05  Tom Tromey  <tom@tromey.com>
10459
10460         * contrib/cleanup_check.py: Remove.
10461         * contrib/gcc-with-excheck: Remove.
10462         * contrib/exsummary.py: Remove.
10463         * contrib/excheck.py: Remove.
10464
10465 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10466
10467         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10468         NULL. Initialize tpprev to NULL instead of assigning it
10469         to NULL on the next statement.
10470         * windows-nat.c (windows_delete_thread): Remove check for
10471         main_thread_id before printing thread exit notifications.
10472         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10473         Remove thread ID check against main_thread_id.
10474         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10475         windows_delete_thread.
10476         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10477
10478 2019-01-04  Tom Tromey  <tom@tromey.com>
10479
10480         * compile/compile.c (_initialize_compile): Use upper case for
10481         metasyntactic variables.
10482         * symmisc.c (_initialize_symmisc): Use upper case for
10483         metasyntactic variables.
10484         * psymtab.c (_initialize_psymtab): Use upper case for
10485         metasyntactic variables.
10486         * demangle.c (demangle_command): Use upper case for metasyntactic
10487         variables.
10488         (_initialize_demangler): Likewise.
10489         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10490         variables.
10491
10492 2019-01-03  Tom Tromey  <tom@tromey.com>
10493
10494         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10495
10496 2019-01-03  Tom Tromey  <tom@tromey.com>
10497
10498         * python/py-symtab.c (salpy_str): Update.
10499         (struct salpy_sal_object) <symtab>: Now a PyObject.
10500         (salpy_dealloc): Update.
10501         (del_objfile_sal): Use gdbpy_ref.
10502
10503 2019-01-03  Tom Tromey  <tom@tromey.com>
10504
10505         * python/py-type.c (convert_field): Use new_reference.  Return
10506         gdbpy_ref.
10507         (make_fielditem): Return gdbpy_ref.
10508         (typy_fields): Update.
10509         (typy_getitem): Update.
10510         (field_name): Return gdbpy_ref.  Use new_reference.
10511         (typy_iterator_iternext): Update.
10512
10513 2019-01-03  Tom Tromey  <tom@tromey.com>
10514
10515         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10516
10517 2019-01-03  Tom Tromey  <tom@tromey.com>
10518
10519         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10520         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10521         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10522         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10523         (pspy_set_type_printers): Likewise.
10524         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10525         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10526         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10527         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10528         (objfpy_set_type_printers): Likewise.
10529
10530 2019-01-03  Tom Tromey  <tom@tromey.com>
10531
10532         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10533         (gdbpy_print_stack): Use gdbpy_err_fetch.
10534         * python/python-internal.h (class gdbpy_err_fetch): New class.
10535         (class gdbpy_enter) <m_error_type, m_error_value,
10536         m_error_traceback>: Remove.
10537         <m_error>: New member.
10538         (gdbpy_exception_to_string): Don't declare.
10539         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10540         * python/py-value.c (convert_value_from_python): Use
10541         gdbpy_err_fetch.
10542         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10543         gdbpy_exception_to_string.
10544         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10545         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10546         gdbpy_err_fetch.
10547
10548 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10549
10550         * linux-nat.c (delete_lwp_cleanup): Delete.
10551         (struct lwp_deleter): New struct.
10552         (lwp_info_up): New typedef.
10553         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10554         lwp_info_up.
10555
10556 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10557
10558         * linux-fork.c (class scoped_switch_fork_info): New class.
10559         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10560
10561 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10562
10563         * valops.c (find_overload_match): Remove use of null_cleanup, and
10564         calls to do_cleanups.
10565
10566 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10567
10568         * compile/compile-cplus-types.c
10569         (compile_cplus_instance::decl_name): Handle changes to
10570         cp_func_name.
10571         * cp-support.c (cp_func_name): Update header comment, update
10572         return type.
10573         * cp-support.h (cp_func_name): Update return type in declaration.
10574         * valops.c (find_overload_match): Move temp_func local to top
10575         level of function and change its type.  Use temp_func to hold and
10576         delete temporary string obtained from cp_func_name.
10577
10578 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10579
10580         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10581         gdb::char_vector, remove cleanup, and update uses of `msg`.
10582
10583 2019-01-03  Jim Wilson  <jimw@sifive.com>
10584
10585         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10586
10587 2019-01-02  Tom Tromey  <tom@tromey.com>
10588
10589         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10590         (tdesc_parse_xml): Remove cleanups.
10591         * target-descriptions.h (make_cleanup_free_target_description):
10592         Don't declare.
10593         (target_desc_deleter): New struct.
10594         (target_desc_up): New typedef.
10595         * target-descriptions.c (target_desc_deleter::operator()): Rename
10596         from free_target_description.
10597         (make_cleanup_free_target_description): Remove.
10598
10599 2019-01-02  Tom Tromey  <tom@tromey.com>
10600
10601         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10602         constructor, destructor.
10603         (linespec_parser): Remove typedef.
10604         (~linespec_parser): Rename from linespec_parser_delete.
10605         (linespec_lex_to_end, linespec_complete_label)
10606         (linespec_complete): Update.
10607         (decode_line_full): Remove cleanups.
10608         (decode_line_1): Update.
10609
10610 2019-01-02  Tom Tromey  <tom@tromey.com>
10611
10612         * python/python-internal.h (inferior_to_inferior_object): Change
10613         return type.
10614         * python/py-exitedevent.c (create_exited_event_object): Update.
10615         * python/py-inferior.c (inferior_to_inferior_object): Return
10616         gdbpy_ref.
10617         (python_new_inferior, python_inferior_deleted)
10618         (thread_to_thread_object, delete_thread_object)
10619         (build_inferior_list, gdbpy_selected_inferior): Update.
10620         * python/py-infthread.c (create_thread_object): Update.  Also fail
10621         if inferior_to_inferior_object fails.
10622
10623 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10624
10625         * inferior.h (class inferior) <displaced_step_state>: New field.
10626         * infrun.h (struct displaced_step_state): Move here from
10627         infrun.c.  Initialize fields, add constructor.
10628         <inf>: Remove field.
10629         <reset>: New method.
10630         * infrun.c (struct displaced_step_inferior_state): Move to
10631         infrun.h.
10632         (displaced_step_inferior_states): Remove.
10633         (get_displaced_stepping_state): Adust.
10634         (displaced_step_in_progress_any_inferior): Adjust.
10635         (displaced_step_in_progress_thread): Adjust.
10636         (displaced_step_in_progress): Adjust.
10637         (add_displaced_stepping_state): Remove.
10638         (get_displaced_step_closure_by_addr): Adjust.
10639         (remove_displaced_stepping_state): Remove.
10640         (infrun_inferior_exit): Call displaced_step_state.reset.
10641         (use_displaced_stepping): Don't check for NULL.
10642         (displaced_step_prepare_throw): Call
10643         get_displaced_stepping_state.
10644         (displaced_step_fixup): Don't check for NULL.
10645         (prepare_for_detach): Don't check for NULL.
10646
10647 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10648
10649         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10650          in case of call that did not complete.
10651
10652 2019-01-02  Andrey Utkin  <autkin@undo.io>
10653
10654         * symfile.c (find_separate_debug_file): Fix search of debug files for
10655         remote debuggee.
10656
10657 2019-01-02  Tom Tromey  <tom@tromey.com>
10658
10659         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10660         indentation.
10661         * python/py-frame.c (frapy_older): Remove cast.
10662         (frapy_newer): Likewise.
10663         * python/py-breakpoint.c (local_setattro): Remove cast.
10664         * python/py-arch.c (archpy_name): Remove local variable.
10665         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10666
10667 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10668
10669         * unittests/basic_string_view/element_access/char/empty.cc:
10670         Fix year range in copyright header.
10671
10672 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10673
10674         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10675         Delete.
10676         <operator==>: Update with for removed field.
10677         <hash>: Likewise.
10678         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10679         <isa_features>: ...this.
10680         <abi_features>: New field.
10681         (riscv_isa_flen): Update comment.
10682         (riscv_abi_xlen): New declaration.
10683         (riscv_abi_flen): New declaration.
10684         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10685         isa_features.
10686         (riscv_abi_xlen): New function.
10687         (riscv_isa_flen): Update to get answer from isa_features.
10688         (riscv_abi_flen): New function.
10689         (riscv_has_fp_abi): Update to get answer from abi_features.
10690         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10691         xlen and flen.
10692         (riscv_call_info) <xlen, flen>: Update comment.
10693         (riscv_call_arg_struct): Remove invalid assertions
10694         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10695         is removed.
10696         (riscv_gdbarch_init): Gather isa features and abi features
10697         separately, ensure both match on the gdbarch when reusing an old
10698         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10699         a target with 64-bit float hardware.
10700
10701 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10702
10703         * source.c (search_command_helper): Stop reverse search
10704         when line 1 has been searched.
10705
10706 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10707
10708         * record-full.c (record_full_base_target::close): Rewrite
10709         record_full_core_buf_list free logic.
10710
10711 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10712
10713         * break-catch-syscall.c (print_one_catch_syscall): xfree
10714         the last text.
10715
10716 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10717
10718         * top.c (print_gdb_version): Update Copyright year in version
10719         message.
10720
10721 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10722
10723         Update copyright year range in all GDB files.
10724
10725 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10726
10727         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10728
10729 For older changes see ChangeLog-2018.
10730 \f
10731 Local Variables:
10732 mode: change-log
10733 left-margin: 8
10734 fill-column: 74
10735 version-control: never
10736 coding: utf-8
10737 End:
10738