gdb/ChangeLog

   1 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * features/aarch64-core.c (create_feature_aarch64_core):
   4         Regenerate.
   5         * features/aarch64-core.xml: Add cpsr flags.
   6
   7 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
   8
   9         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
  10         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
  11
  12 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
  13
  14         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
  15         field.
  16         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
  17         use.
  18         (arm_record_special_symbol): Don't insert new symbol in sorted
  19         position, push it at the end.
  20
  21 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
  22
  23         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
  24         (arm_mapping_symbol_s): Remove.
  25         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
  26         (arm_mapping_symbol_vec): New typedef.
  27         (struct arm_per_objfile): Add constructor.
  28         <section_maps>: Change type to
  29         std::unique_ptr<arm_mapping_symbol_vec[]>.
  30         (arm_compare_mapping_symbols): Remove.
  31         (arm_find_mapping_symbol): Adjust to section_maps type change.
  32         (arm_objfile_data_free): Call delete on arm_per_objfile.
  33         (arm_record_special_symbol): Adjust to section_maps type change.
  34         Allocate arm_per_objfile with new.
  35
  36 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  37
  38         * cli/cli-cmds.c (alias_command): Compare the alias prefix
  39         with the command prefix.
  40
  41 2019-06-25  Tom Tromey  <tom@tromey.com>
  42
  43         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
  44         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
  45
  46 2019-06-25  Tom Tromey  <tom@tromey.com>
  47
  48         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
  49         type.
  50         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
  51         protected.
  52
  53 2019-06-25  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui-winsource.c
  56         (tui_source_window_base::set_is_exec_point_at): Add check against
  57         LOA_ADDRESS.
  58
  59 2019-06-25  Tom Tromey  <tom@tromey.com>
  60
  61         * tui/tui-source.c (tui_set_source_content): Don't check before
  62         xfree.
  63         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
  64
  65 2019-06-25  Tom Tromey  <tom@tromey.com>
  66
  67         * tui/tui-winsource.h (tui_update_source_window_as_is)
  68         (tui_alloc_source_buffer, tui_line_is_displayed)
  69         (tui_addr_is_displayed): Change type of win_info.
  70         * tui/tui-winsource.c (tui_update_source_window_as_is)
  71         (tui_clear_source_content, tui_show_source_line)
  72         (tui_show_source_content, tui_source_window_base::refill)
  73         (tui_source_window_base::set_is_exec_point_at)
  74         (tui_source_window_base::set_is_exec_point_at)
  75         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
  76         (tui_alloc_source_buffer, tui_line_is_displayed)
  77         (tui_addr_is_displayed): Change type of win_info.  Update.
  78         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
  79         (tui_source_window_base::do_make_visible_with_new_height):
  80         Update.
  81         * tui/tui-source.c (tui_set_source_content)
  82         (tui_set_source_content_nil)
  83         (tui_source_window::do_scroll_vertical): Update.
  84         * tui/tui-layout.c (show_layout): Update.
  85         * tui/tui-disasm.c (tui_set_disassem_content)
  86         (tui_disasm_window::do_scroll_vertical): Update.
  87         * tui/tui-data.h (tui_win_content): Remove.
  88         (struct tui_gen_win_info) <content, content_size>: Remove.
  89         (struct tui_source_element): Add initializers and destructor.
  90         (union tui_which_element, struct tui_win_element): Remove.
  91         (struct tui_source_window_base) <content>: New field.
  92         (struct tui_data_window): Remove destructor.
  93         (tui_alloc_content, tui_free_win_content)
  94         (tui_free_all_source_wins_content): Don't declare.
  95         * tui/tui-data.c (tui_initialize_static_data): Update.
  96         (init_content_element, tui_alloc_content): Remove.
  97         (~tui_gen_win_info): Update.
  98         (~tui_data_window, tui_free_all_source_wins_content)
  99         (tui_free_win_content, free_content, free_content_elements):
 100         Remove.
 101
 102 2019-06-25  Tom Tromey  <tom@tromey.com>
 103
 104         * tui/tui-winsource.h (tui_clear_source_content)
 105         (tui_erase_source_content, tui_show_source_content): Change type
 106         of win_info.
 107         * tui/tui-winsource.c (tui_clear_source_content)
 108         (tui_erase_source_content, tui_show_source_content): Change type
 109         of win_info.
 110         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 111         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 112         win_info.
 113         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 114         win_info.
 115         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 116
 117 2019-06-25  Tom Tromey  <tom@tromey.com>
 118
 119         * tui/tui-winsource.c (tui_clear_source_content)
 120         (tui_source_window_base::set_is_exec_point_at): Update.
 121         * tui/tui-source.c (tui_set_source_content_nil): Update.
 122         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 123         a bool.
 124         * tui/tui-data.c (init_content_element): Update.
 125
 126 2019-06-25  Tom Tromey  <tom@tromey.com>
 127
 128         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 129         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 130         * tui/tui-layout.c (init_and_make_win): Update.
 131         * tui/tui.h (enum tui_win_type): Update.
 132         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 133         tui_win_is_auxillary.
 134         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 135         tui_win_is_auxillary.
 136
 137 2019-06-25  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 140         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 141         (tui_delete_data_content_windows, tui_display_all_data)
 142         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 143         Update.
 144         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 145         * tui/tui-regs.c (tui_last_regs_line_no)
 146         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 147         (tui_show_registers): Update.
 148         (tui_show_register_group): Return void.  Update.
 149         (tui_display_registers_from, tui_display_reg_element_at_line)
 150         (tui_display_registers_from_line, tui_check_register_values):
 151         Update.
 152         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 153         member.
 154         (struct tui_data_window) <regs_content>: Now a std::vector.
 155         <regs_content_count>: Remove.
 156         (tui_add_content_elements, tui_free_data_content): Don't declare.
 157         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 158         (init_content_element): Remove DATA_WIN case.  Add assert.
 159         (tui_add_content_elements): Remove.
 160         (tui_data_window): Update.
 161         (tui_free_data_content): Remove.
 162         (free_content_elements): Remove DATA_WIN case.
 163
 164 2019-06-25  Tom Tromey  <tom@tromey.com>
 165
 166         * tui/tui-data.c (tui_data_item_window): Update.
 167         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 168         * tui/tui-windata.c (tui_display_all_data)
 169         (tui_display_data_from_line): Update.
 170         (tui_check_data_values): Remove.
 171         * tui/tui-regs.c (tui_show_register_group)
 172         (tui_display_reg_element_at_line): Update.
 173         * tui/tui-hooks.c (tui_register_changed)
 174         (tui_refresh_frame_and_register_information): Call
 175         tui_check_register_values.
 176         * tui/tui-data.h (struct tui_data_window) <data_content,
 177         data_content_count, data_type>: Remove.
 178         (enum tui_data_type): Remove.
 179
 180         * tui/tui-data.c (tui_data_window::clear_detail)
 181         (~tui_data_window): Update.
 182
 183 2019-06-25  Tom Tromey  <tom@tromey.com>
 184
 185         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 186         declare.
 187         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 188         Rename from tui_first_data_item_displayed.  Update.
 189         (tui_data_window::refresh_all)
 190         (tui_data_window::do_scroll_vertical): Update.
 191         * tui/tui-data.h (struct tui_data_window)
 192         <first_data_item_displayed>: Declare new method.
 193
 194 2019-06-25  Tom Tromey  <tom@tromey.com>
 195
 196         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 197         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 198         contents...
 199         (tui_initialize_static_data): ...here.
 200
 201 2019-06-25  Tom Tromey  <tom@tromey.com>
 202
 203         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 204         (tui_display_registers_from, tui_check_register_values): Update.
 205         (tui_display_register): Remove win_info parameter; update.
 206         (tui_get_register): Change type of parameters.
 207         * tui/tui-data.h (struct tui_data_element): Remove.
 208         (union tui_which_element) <data>: Remove.
 209         <data_window>: Change type.
 210         (struct tui_data_item_window): New.
 211         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 212         case.  Add assert.
 213         (~tui_data_item_window): New destructor.
 214         (free_content_elements): Remove DATA_ITEM_WIN case.
 215
 216 2019-06-25  Tom Tromey  <tom@tromey.com>
 217
 218         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 219         Remove.
 220
 221 2019-06-25  Tom Tromey  <tom@tromey.com>
 222
 223         * tui/tui-data.h (struct tui_command_element): Remove.
 224         (union tui_which_element) <command>: Remove.
 225         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 226         assert.
 227         (free_content_elements): Remove CMD_WIN case.
 228
 229 2019-06-25  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-layout.c (tui_set_layout): Update.
 232         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 233         * tui/tui-data.c (layout_def): Update.
 234
 235 2019-06-25  Tom Tromey  <tom@tromey.com>
 236
 237         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 238         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 239         (tui_source_window_base::set_new_height): Update.
 240         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 241         Update.
 242         (tui_set_locator_fullname, tui_set_locator_info)
 243         (tui_show_frame_info): Update.
 244         * tui/tui-source.c (tui_set_source_content)
 245         (tui_source_is_displayed): Update.
 246         * tui/tui-layout.c (show_source_disasm_command, show_data)
 247         (show_source_or_disasm_and_command): Update.
 248         * tui/tui-disasm.c (tui_set_disassem_content)
 249         (tui_get_begin_asm_address): Update.
 250         * tui/tui-data.h (struct tui_locator_element): Remove.
 251         (union tui_which_element) <locator>: Remove.
 252         (struct tui_locator_window): New.
 253         (tui_locator_win_info_ptr): Change return type.
 254         * tui/tui-data.c (_locator): Change type.
 255         (tui_locator_win_info_ptr): Change return type.
 256         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 257         (tui_alloc_content): Add assert.
 258
 259 2019-06-25  Tom Tromey  <tom@tromey.com>
 260
 261         * tui/tui-winsource.c
 262         (tui_exec_info_window::maybe_allocate_content): New method.
 263         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 264         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 265         (make_source_or_disasm_window): Add cast.
 266         * tui/tui-data.h (union tui_which_element) <simple_string>:
 267         Remove.
 268         (struct tui_source_info): New.
 269         (struct tui_source_window_base) <execution_info>: Change type.
 270         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 271         case, and add assert.
 272         (tui_alloc_content): Add assert.
 273
 274 2019-06-25  Tom Tromey  <tom@tromey.com>
 275
 276         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 277         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 278         * tui/tui-data.c (tui_alloc_win_info): Remove.
 279
 280 2019-06-25  Tom Tromey  <tom@tromey.com>
 281
 282         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 283         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 284         can_highlight.
 285
 286 2019-06-25  Tom Tromey  <tom@tromey.com>
 287
 288         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 289         make_visible_with_new_height method.
 290         (tui_win_info::make_visible_with_new_height): New method.
 291         (tui_source_window_base::do_make_visible_with_new_height)
 292         (tui_data_window::do_make_visible_with_new_height)
 293         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 294         (make_visible_with_new_height): Remove.
 295         (tui_resize_all, tui_adjust_win_heights): Use
 296         make_visible_with_new_height method.
 297         * tui/tui-data.h (struct tui_win_info)
 298         <do_make_visible_with_new_height, make_visible_with_new_height>:
 299         New methods.
 300         (struct tui_source_window_base, struct tui_data_window)
 301         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 302         methods.
 303
 304 2019-06-25  Tom Tromey  <tom@tromey.com>
 305
 306         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 307         method.
 308         (update_tab_width): Call update_tab_width method.
 309         * tui/tui-data.h (struct tui_win_info)
 310         (struct tui_source_window_base) <update_tab_width>: New methods.
 311
 312 2019-06-25  Tom Tromey  <tom@tromey.com>
 313
 314         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 315         parameter.
 316         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 317         parameter.
 318         (tui_gen_win_info::make_visible): Update.
 319         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 320         parameter.
 321         * tui/tui-data.h (enum tui_box): New enum.
 322         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 323
 324 2019-06-25  Tom Tromey  <tom@tromey.com>
 325
 326         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 327         init_and_make_win for EXEC_INFO_WIN.
 328         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 329         longer inline.
 330         (struct tui_win_info) <~tui_win_info>: Inline.
 331         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 332         Don't declare.
 333         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 334         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 335         Remove.
 336         (tui_initialize_static_data): Update.
 337         (~tui_gen_win_info): Handle more cleanup here.
 338         (~tui_source_window_base): Delete "execution_info".
 339         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 340
 341 2019-06-25  Tom Tromey  <tom@tromey.com>
 342
 343         * tui/tui-layout.c (make_command_window): Don't set
 344         can_highlight.
 345         (show_source_disasm_command): Call the reset method.
 346         (show_data): Don't set can_highlight.  Call the reset method.
 347         (tui_gen_win_info::reset): Rename from init_gen_win_info
 348         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 349         (show_source_or_disasm_and_command): Call the reset method.
 350         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 351         (struct tui_cmd_window): Set can_highlight.
 352
 353 2019-06-25  Tom Tromey  <tom@tromey.com>
 354
 355         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 356         from make_visible.
 357         (tui_make_visible, tui_make_invisible): Rewrite.
 358         (tui_win_info::make_visible): Remove.
 359         (tui_source_window_base::make_visible): Update.
 360         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 361         method.  Moved from...
 362         (struct tui_win_info) <make_visible>: ...here.
 363
 364 2019-06-25  Tom Tromey  <tom@tromey.com>
 365
 366         * tui/tui-winsource.c
 367         (tui_source_window_base::do_scroll_horizontal): Remove direction
 368         parameter.
 369         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 370         direction parameter.
 371         * tui/tui-win.c (tui_win_info::forward_scroll)
 372         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 373         (tui_win_info::right_scroll): Update.
 374         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 375         direction parameter.
 376         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 377         direction parameter.
 378         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 379         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 380         Remove direction parameter.
 381         (struct tui_source_window_base, struct tui_source_window)
 382         (struct tui_disasm_window, struct tui_data_window)
 383         (struct tui_cmd_window): Update.
 384
 385 2019-06-25  Tom Tromey  <tom@tromey.com>
 386
 387         * tui/tui-winsource.h (tui_set_exec_info_content)
 388         (tui_show_exec_info_content, tui_erase_exec_info_content)
 389         (tui_clear_exec_info_content, tui_update_exec_info): Change
 390         argument to tui_source_window_base.
 391         * tui/tui-winsource.c (tui_set_exec_info_content)
 392         (tui_show_exec_info_content, tui_erase_exec_info_content)
 393         (tui_clear_exec_info_content, tui_update_exec_info): Change
 394         argument to tui_source_window_base.
 395
 396 2019-06-25  Tom Tromey  <tom@tromey.com>
 397
 398         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 399         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 400
 401 2019-06-25  Tom Tromey  <tom@tromey.com>
 402
 403         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 404         check.
 405
 406 2019-06-25  Tom Tromey  <tom@tromey.com>
 407
 408         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 409         type to void.
 410         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 411         type to void.
 412         * tui/tui-source.c (tui_set_source_content): Update.
 413         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 414
 415 2019-06-25  Tom Tromey  <tom@tromey.com>
 416
 417         * tui/tui-win.c (window_name_completer, tui_set_focus)
 418         (tui_all_windows_info): Use name method.
 419         * tui/tui-data.h (struct tui_gen_win_info)
 420         (struct tui_source_window, struct tui_disasm_window)
 421         (struct tui_data_window, struct tui_cmd_window) <name>: New
 422         method.
 423         (tui_win_name): Don't declare.
 424         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 425         (tui_win_name): Remove.
 426
 427 2019-06-25  Tom Tromey  <tom@tromey.com>
 428
 429         * tui/tui-winsource.h (tui_update_source_window)
 430         (tui_update_source_window_as_is): Change parameter type.
 431         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 432         to be a tui_source_window_base.
 433         (tui_update_source_window_as_is): Likewise.
 434         * tui/tui-win.c (make_visible_with_new_height): Update.
 435
 436 2019-06-25  Tom Tromey  <tom@tromey.com>
 437
 438         * tui/tui-winsource.c (tui_erase_source_content)
 439         (tui_show_source_content, tui_show_exec_info_content)
 440         (tui_erase_exec_info_content): Use refresh_window method.
 441         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 442         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 443         from tui_refresh_win.
 444         (tui_data_window::refresh_window): New method.
 445         (tui_win_info::refresh, tui_source_window_base::refresh)
 446         (tui_refresh_all): Use refresh_window method.
 447         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 448         method.
 449         * tui/tui-regs.c (tui_display_register): Call refresh_window
 450         method.
 451         * tui/tui-layout.c (show_source_disasm_command)
 452         (show_source_or_disasm_and_command): Call refresh_window method.
 453         * tui/tui-data.h (struct tui_gen_win_info)
 454         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 455         New method.
 456
 457 2019-06-25  Tom Tromey  <tom@tromey.com>
 458
 459         * tui/tui.c (tui_rl_other_window, tui_enable)
 460         (tui_is_window_visible, tui_get_command_dimension): Update.
 461         * tui/tui-winsource.c (tui_update_source_window_as_is)
 462         (tui_clear_source_content, tui_erase_source_content)
 463         (tui_show_source_line, tui_source_window_base::refill)
 464         (tui_source_window_base::do_scroll_horizontal)
 465         (tui_source_window_base::set_is_exec_point_at)
 466         (tui_update_breakpoint_info, tui_set_exec_info_content)
 467         (tui_alloc_source_buffer, tui_line_is_displayed)
 468         (tui_addr_is_displayed): Update.
 469         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 470         (tui_check_and_display_highlight_if_needed)
 471         (tui_win_info::make_visible, tui_win_info::refresh)
 472         (tui_refresh_all): Update.
 473         * tui/tui-windata.c (tui_first_data_item_displayed)
 474         (tui_delete_data_content_windows, tui_erase_data_content)
 475         (tui_display_all_data, tui_data_window::refresh_all)
 476         (tui_check_data_values): Update.
 477         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 478         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 479         (tui_win_info::backward_scroll, tui_refresh_all_win)
 480         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 481         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 482         (tui_source_window_base::set_new_height)
 483         (tui_data_window::set_new_height)
 484         (make_invisible_and_set_new_height)
 485         (make_visible_with_new_height, new_height_ok)
 486         (parse_scrolling_args): Update.
 487         * tui/tui-stack.c (tui_show_frame_info): Update.
 488         * tui/tui-source.c (tui_set_source_content)
 489         (tui_set_source_content_nil, tui_source_is_displayed)
 490         (tui_source_window::do_scroll_vertical): Update.
 491         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 492         (tui_display_registers_from, tui_display_reg_element_at_line)
 493         (tui_check_register_values, tui_reg_command): Update.
 494         * tui/tui-layout.c (tui_default_win_height)
 495         (show_source_disasm_command, show_data, init_and_make_win)
 496         (show_source_or_disasm_and_command): Update.
 497         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 498         (tui_redisplay_readline, tui_mld_flush)
 499         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 500         (tui_getc): Update.
 501         * tui/tui-disasm.c (tui_set_disassem_content)
 502         (tui_disasm_window::do_scroll_vertical): Update.
 503         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 504         Now virtual.
 505         (struct tui_win_info): Derive from tui_gen_win_info.
 506         <~tui_win_info>: Mark as override.
 507         <generic>: Remove member.
 508         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 509         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 510         (~tui_data_window, ~tui_win_info)
 511         (tui_free_all_source_wins_content): Update.
 512         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 513
 514 2019-06-25  Tom Tromey  <tom@tromey.com>
 515
 516         * tui/tui-layout.c (init_and_make_win): Use new.
 517         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 518         destructor, initializers.
 519         (tui_alloc_generic_win_info): Don't declare.
 520         * tui/tui-data.c (_locator): Add argument to constructor.
 521         (source_win, disasm_win): New globals.
 522         (exec_info): Remove.
 523         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 524         Update.
 525         (tui_alloc_generic_win_info): Remove.
 526         (init_content_element): Use new.
 527         (tui_win_info::tui_win_info): Update.
 528         (free_content_elements) <case DATA_WIN>: Use delete.
 529
 530 2019-06-25  Tom Tromey  <tom@tromey.com>
 531
 532         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 533         * tui/tui-windata.c (tui_first_data_item_displayed)
 534         (tui_delete_data_content_windows): Update.
 535         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 536         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 537         (tui_display_registers_from, tui_check_register_values): Update.
 538         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 539         pointer.
 540         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 541         window.
 542         (tui_free_data_content): Update.
 543         (free_content_elements) <case DATA_WIN>: Free the window.
 544
 545 2019-06-25  Tom Tromey  <tom@tromey.com>
 546
 547         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 548         Update.
 549         * tui/tui-layout.c (make_command_window)
 550         (show_source_disasm_command, show_data, init_and_make_win)
 551         (show_source_or_disasm_and_command): Update.
 552         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 553         method.
 554         <can_highight, is_highlighted>: Now bool.
 555         (tui_set_win_highlight): Don't declare.
 556         * tui/tui-data.c (tui_set_win_highlight): Remove.
 557
 558 2019-06-25  Tom Tromey  <tom@tromey.com>
 559
 560         * tui/tui-wingeneral.c (make_visible): Remove check of window
 561         type.
 562
 563 2019-06-25  Tom Tromey  <tom@tromey.com>
 564
 565         * tui/tui-win.c (tui_win_info::max_height)
 566         (tui_cmd_window::max_height): New methods.
 567         (new_height_ok): Call max_height.
 568         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 569         <max_height>: New method.
 570
 571 2019-06-25  Tom Tromey  <tom@tromey.com>
 572
 573         * tui/tui-win.c (tui_source_window_base::set_new_height)
 574         (tui_data_window::set_new_height): New methods.
 575         (make_invisible_and_set_new_height): Call set_new_height method.
 576         * tui/tui-data.h (struct tui_win_info)
 577         (struct tui_source_window_base, struct tui_data_window)
 578         <set_new_height>: New method.
 579
 580 2019-06-25  Tom Tromey  <tom@tromey.com>
 581
 582         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 583         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 584         tui_refresh_data_win.
 585         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 586         method.
 587         (tui_refresh_all_win): Call the refresh_all method.
 588         (tui_set_focus): Likewise.
 589         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 590         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 591         Likewise.
 592
 593 2019-06-25  Tom Tromey  <tom@tromey.com>
 594
 595         * tui/tui-winsource.h (tui_refill_source_window)
 596         (tui_set_is_exec_point_at): Don't declare.
 597         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 598         (tui_source_window_base::refill): Rename from
 599         tui_refill_source_window.
 600         (tui_source_window_base::do_scroll_horizontal): Update.
 601         (tui_source_window_base::set_is_exec_point_at): Rename from
 602         tui_set_is_exec_point_at.
 603         (tui_update_all_breakpoint_info): Update.
 604         * tui/tui-stack.c (tui_show_frame_info): Update.
 605         * tui/tui-layout.c (show_data): Add cast.
 606         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 607         * tui/tui-data.h (struct tui_source_window_base) <refill,
 608         set_is_exec_point_at>: New methods.
 609         (tui_source_windows, tui_add_to_source_windows): Update types.
 610         (tui_add_to_source_windows): Remove redundant declaration.
 611         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 612         (tui_source_windows): Change return type.
 613         (tui_clear_source_windows_detail): Update.
 614         (tui_add_to_source_windows): Change type of parameter.
 615         (tui_free_all_source_wins_content): Update.
 616
 617 2019-06-25  Tom Tromey  <tom@tromey.com>
 618
 619         * tui/tui-wingeneral.c (tui_win_info::refresh)
 620         (tui_source_window_base::refresh): New methods.
 621         (tui_refresh_all): Call the refresh method.
 622         * tui/tui-data.h (struct tui_win_info)
 623         (struct tui_source_window_base) <refresh>: New method.
 624
 625 2019-06-25  Tom Tromey  <tom@tromey.com>
 626
 627         * tui/tui.h (tui_is_window_visible): Return bool.
 628         * tui/tui.c (tui_is_window_visible): Return bool.
 629         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 630         (tui_make_visible, tui_make_invisible)
 631         (tui_win_info::make_visible)
 632         (tui_source_window_base::make_visible, make_all_visible)
 633         (tui_make_all_visible, tui_make_all_invisible): Update.
 634         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 635         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 636         bool.
 637         (struct tui_win_info, struct tui_source_window_base)
 638         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 639         * tui/tui-data.c (tui_init_generic_part): Update.
 640
 641 2019-06-25  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 644         (tui_source_window_base::make_visible): New methods.
 645         (make_all_visible): Make method call.
 646         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 647         (struct tui_source_window_base, struct tui_cmd_window): Override
 648         make_visible.
 649         (tui_win_is_source_type): Don't declare.
 650         * tui/tui-data.c (tui_win_is_source_type): Remove.
 651
 652 2019-06-25  Tom Tromey  <tom@tromey.com>
 653
 654         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 655         NULL check.
 656
 657 2019-06-25  Tom Tromey  <tom@tromey.com>
 658
 659         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 660         Inline constructor.  Add initializers for members.
 661         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 662         constructors; now inline in class.
 663
 664 2019-06-25  Tom Tromey  <tom@tromey.com>
 665
 666         * tui/tui-regs.c (tui_show_registers): Update.
 667         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 668         bool.
 669         * tui/tui-data.c (tui_data_window::clear_detail)
 670         (tui_data_window): Update.
 671
 672 2019-06-25  Tom Tromey  <tom@tromey.com>
 673
 674         * tui/tui-windata.c (tui_display_all_data)
 675         (tui_display_data_from_line, tui_display_data_from)
 676         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 677         Update.
 678         * tui/tui-regs.c (tui_last_regs_line_no)
 679         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 680         (tui_show_registers, tui_show_register_group)
 681         (tui_display_registers_from, tui_display_reg_element_at_line)
 682         (tui_display_registers_from_line, tui_check_register_values)
 683         (tui_reg_next, tui_reg_prev): Update.
 684         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 685         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 686         tui_data_window.
 687         (struct tui_win_info) <detail>: Remove.  Add new fields from
 688         tui_data_info.
 689         (TUI_DATA_WIN): Add cast.
 690         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 691         (~tui_data_window): Simplify.
 692
 693 2019-06-25  Tom Tromey  <tom@tromey.com>
 694
 695         * tui/tui-layout.c (show_source_disasm_command)
 696         (show_source_or_disasm_and_command): Update.
 697         * tui/tui-io.c (update_cmdwin_start_line)
 698         (tui_redisplay_readline): Update.
 699         * tui/tui-data.h (struct tui_command_info): Remove.
 700         (struct tui_win_info) <detail>: Remove command_info member.
 701         (struct tui_data_window) <start_line>: New member, from
 702         tui_command_info.
 703         (TUI_CMD_WIN): Add casts.
 704
 705 2019-06-25  Tom Tromey  <tom@tromey.com>
 706
 707         * tui/tui-winsource.c (tui_update_source_window)
 708         (tui_refill_source_window)
 709         (tui_source_window_base::do_scroll_horizontal)
 710         (tui_update_breakpoint_info, tui_set_exec_info_content)
 711         (tui_show_exec_info_content, tui_erase_exec_info_content)
 712         (tui_clear_exec_info_content): Update.
 713         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 714         Update.
 715         * tui/tui-win.c (make_invisible_and_set_new_height)
 716         (make_visible_with_new_height): Update.
 717         * tui/tui-source.c (tui_set_source_content)
 718         (tui_show_symtab_source): Update.
 719         * tui/tui-layout.c (extract_display_start_addr)
 720         (show_source_disasm_command, show_data)
 721         (make_source_or_disasm_window)
 722         (show_source_or_disasm_and_command): Update.
 723         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 724         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 725         "gdbarch".
 726         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 727         to tui_source_window_base.
 728         (struct tui_win_info) <detail>: Remove source_info member.
 729         (struct tui_source_window_base) <has_locator>: Inline.
 730         Move contents from tui_source_info; rename has_locator member to
 731         m_has_locator.
 732         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 733         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 734         header file.
 735         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 736         Simplify.
 737         (tui_free_all_source_wins_content): Cast to
 738         tui_source_window_base.
 739
 740 2019-06-25  Tom Tromey  <tom@tromey.com>
 741
 742         * tui/tui-win.c (make_invisible_and_set_new_height)
 743         (make_visible_with_new_height): Call has_locator method.
 744         * tui/tui-layout.c (show_source_disasm_command, show_data)
 745         (show_source_or_disasm_and_command): Update for bool change.
 746         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 747         (tui_win_info) <has_locator>: New method.
 748         (struct tui_source_window_base) <has_locator>: New method.
 749         (tui_win_has_locator): Don't declare.
 750         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 751         from tui_win_has_locator.
 752         (tui_source_window_base): Use false, not FALSE.
 753
 754 2019-06-25  Tom Tromey  <tom@tromey.com>
 755
 756         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 757         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 758         clear_detail method directly.
 759         (tui_clear_win_detail): Remove.
 760
 761 2019-06-25  Tom Tromey  <tom@tromey.com>
 762
 763         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 764         "this", not TUI_DISASM_WIN.
 765
 766 2019-06-25  Tom Tromey  <tom@tromey.com>
 767
 768         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 769         declare.
 770         * tui/tui-winsource.c
 771         (tui_source_window_base::do_scroll_horizontal): Rename from
 772         tui_horizontal_source_scroll.
 773         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 774         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 775         from tui_vertical_data_scroll.
 776         * tui/tui-win.h (tui_scroll): Don't declare.
 777         * tui/tui-win.c (tui_win_info::forward_scroll)
 778         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 779         (tui_win_info::right_scroll): Rename and update.
 780         (tui_scroll_forward_command, tui_scroll_backward_command)
 781         (tui_scroll_left_command, tui_scroll_right_command): Update.
 782         (tui_scroll): Remove.
 783         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 784         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 785         from tui_vertical_source_scroll.
 786         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 787         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 788         from tui_vertical_disassem_scroll.
 789         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 790         do_scroll_horizontal>: New methods.
 791         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 792         Likewise.
 793         (struct tui_source_window_base): Add do_scroll_horizontal.
 794         (struct tui_source_window, struct tui_disasm_window): Add
 795         do_scroll_vertical.
 796         (struct tui_data_window, struct tui_cmd_window): Add
 797         do_scroll_horizontal and do_scroll_vertical.
 798         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 799
 800 2019-06-25  Tom Tromey  <tom@tromey.com>
 801
 802         * tui/tui-data.h (struct tui_source_window_base): New struct.
 803         (struct tui_source_window): Derive from tui_source_window_base.
 804         (struct tui_disasm_window): New struct.
 805         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 806         from tui_source_window::clear_detail.
 807         (tui_source_window_base): Rename from tui_source_window.
 808         (~tui_source_window_base): Rename from ~tui_source_window.
 809         (tui_alloc_win_info): Create a tui_disasm_window.
 810
 811 2019-06-25  Tom Tromey  <tom@tromey.com>
 812
 813         * tui/tui-data.h (struct tui_source_window)
 814         (struct tui_data_window): Declare destructors.
 815         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 816         destructors.
 817         (tui_win_info): Simplify.
 818
 819 2019-06-25  Tom Tromey  <tom@tromey.com>
 820
 821         * tui/tui-winsource.c (tui_display_main)
 822         (tui_update_source_windows_with_addr)
 823         (tui_update_all_breakpoint_info): Update.
 824         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 825         (new_height_ok, parse_scrolling_args): Update.
 826         * tui/tui-stack.c (tui_show_frame_info): Update.
 827         * tui/tui-data.h (struct tui_list): Remove.
 828         (tui_source_windows): Return a reference to a std::vector.
 829         * tui/tui-data.c (source_windows): Now a std::vector.
 830         (tui_source_windows): Change return type.
 831         (tui_clear_source_windows): Rewrite.
 832         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 833         (tui_free_all_source_wins_content): Rewrite.
 834
 835 2019-06-25  Tom Tromey  <tom@tromey.com>
 836
 837         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 838         (struct tui_data_window, struct tui_cmd_window): Declare
 839         clear_detail method.
 840         * tui/tui-data.c (tui_source_window::clear_detail)
 841         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 842         methods.
 843         (tui_clear_win_detail): Simplify.
 844
 845 2019-06-25  Tom Tromey  <tom@tromey.com>
 846
 847         * tui/tui-layout.c (make_source_window, make_disasm_window)
 848         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 849         Return the new window.
 850         (show_source_disasm_command, show_data)
 851         (show_source_or_disasm_and_command): Update.
 852
 853 2019-06-25  Tom Tromey  <tom@tromey.com>
 854
 855         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 856         parameter.  Return the new window.
 857         (show_source_disasm_command): Update and remove NULL check.
 858         (show_source_or_disasm_and_command): Update.
 859
 860 2019-06-25  Tom Tromey  <tom@tromey.com>
 861
 862         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 863
 864 2019-06-25  Tom Tromey  <tom@tromey.com>
 865
 866         * tui/tui-data.h (struct tui_win_info): Make constructor
 867         protected.  Make destructor virtual.  Add initializers.
 868         (tui_source_window, tui_data_window, tui_cmd_window): New
 869         classes.
 870         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 871         constructor.  Add "type" parameter.
 872         (tui_source_window, tui_data_window, tui_cmd_window): New
 873         constructors.
 874         (tui_alloc_win_info): Instantiate the appropriate subclass.
 875
 876 2019-06-25  Tom Tromey  <tom@tromey.com>
 877
 878         * tui/tui-win.c (tui_resize_all): Use delete.
 879         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 880         destructor.
 881         (tui_free_window): Don't declare.
 882         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 883         Update.
 884
 885 2019-06-25  Tom Tromey  <tom@tromey.com>
 886
 887         * tui/tui-data.h (struct tui_win_info): Add constructor.
 888         * tui/tui-data.c (tui_alloc_win_info): Use new.
 889         (tui_free_window): Use delete.
 890
 891 2019-06-22  Tom Tromey  <tom@tromey.com>
 892
 893         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 894         declare.
 895         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 896
 897 2019-06-22  Tom Tromey  <tom@tromey.com>
 898
 899         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 900         declare.
 901         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 902
 903 2019-06-22  Tom de Vries  <tdevries@suse.de>
 904
 905         * dwarf2read.c (create_addrmap_from_aranges)
 906         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 907         instead of '%zu'.
 908
 909 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 910
 911         * dwarf2read.h (dwarf2_section_info_def): Remove.
 912         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 913         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 914         std::vector<dwarf2_section_info>.
 915         (struct dwo_file) <~dwo_file>: Remove.
 916         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 917         types field.
 918         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 919         (dwarf2_read_debug_names): Likewise.
 920         (create_debug_types_hash_table): Change parameter type to
 921         array_view, adjust code accordingly.
 922         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 923         (partial_die_info::fixup): Likewise.
 924         (determine_prefix): Likewise.
 925         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 926
 927 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 928
 929         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 930         gdb_bfd_ref_ptr.
 931         <~dwo_file>: Remove call to gdb_bfd_unref.
 932         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 933         gdb_bfd_ref_ptr::get.
 934
 935 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 936
 937         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 938         type to htab_up.
 939         * dwarf2read.c (struct dwo_file): Initialize fields.
 940         <~dwo_file>: New.
 941         (free_dwo_file): Remove, move content to ~dwo_file.
 942         (struct dwo_file_deleter): Remove.
 943         (dwo_file_up>: Remove custom deleter.
 944         (free_dwo_files): Remove.
 945         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 946         dwo_files.
 947         (process_skeletonless_type_units): Call unique_ptr::get.
 948         (allocate_dwo_file_hash_table): Add deleter to created hash
 949         table.  Change return type to htab_up.
 950         (lookup_dwo_file_slot): Don't memset dwo_file, call
 951         unique_ptr::get.
 952         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 953         (create_dwo_unit_in_dwp_v2): Likewise.
 954         (open_and_init_dwo_file): Likewise.
 955         (free_dwo_file_from_slot): Remove.
 956
 957 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 958
 959         * dwarf2read.h (struct dwarf2_section_info) <readin,
 960         is_virtual>: Change type to bool.
 961         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 962         true instead of 1.
 963
 964 2019-06-19  Tom Tromey  <tom@tromey.com>
 965
 966         * tui/tui-data.h (tui_init_content_element): Don't declare.
 967
 968 2019-06-19  Tom Tromey  <tom@tromey.com>
 969
 970         * tui/tui-data.h (tui_init_win_info): Don't declare.
 971
 972 2019-06-19  Tom de Vries  <tdevries@suse.de>
 973
 974         * dwarf2read.h (abstract_to_concrete): Change type to
 975         std::unordered_map<sect_offset, std::vector<sect_offset>,
 976         gdb::hash_enum<sect_offset>>.
 977
 978 2019-06-19  Tom Tromey  <tromey@adacore.com>
 979
 980         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 981         EVAL_AVOID_SIDE_EFFECTS specially.
 982
 983 2019-06-19  Tom Tromey  <tromey@adacore.com>
 984
 985         * source-cache.c (highlighter): New global.
 986         (source_cache::get_source_lines): Create a highlighter on demand.
 987
 988 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 989
 990         * defs.h (deprecated_interactive_hook): Delete declaration.
 991         * interps.c (clear_interpreter_hooks): Remove use of
 992         deprecated_interactive_hook.
 993         * top.c (deprecated_interactive_hook): Delete definition.
 994         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 995
 996 2019-06-18  Tom de Vries  <tdevries@suse.de>
 997
 998         PR gdb/24515
 999         * dwarf2read.h (abstract_to_concrete): Change type from
1000         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1001         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1002         * dwarf2read.c (read_variable): Update.
1003         (dwarf2_fetch_die_loc_sect_off): Update.
1004
1005 2019-06-17  Tom de Vries  <tdevries@suse.de>
1006
1007         PR gdb/24617
1008         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1009         accessing parent[parent_len - 1].
1010
1011 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1012
1013         PR gdb/24364
1014         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1015         call dtrace_process_dof with NULL dof.
1016
1017 2019-06-16  Tom de Vries  <tdevries@suse.de>
1018
1019         PR gdb/24445
1020         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1021
1022 2019-06-16  Tom Tromey  <tom@tromey.com>
1023
1024         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1025         (make_all_visible): Use address of member.
1026
1027 2019-06-16  Tom Tromey  <tom@tromey.com>
1028
1029         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1030         (tui_free_window, free_content, free_content_elements): Remove
1031         unnecessary cast.
1032         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1033         cast.
1034         * tui/tui-regs.c (tui_show_register_group)
1035         (tui_display_registers_from, tui_display_reg_element_at_line):
1036         Remove unnecessary cast.
1037
1038 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1039
1040         * linux-nat.c (normal_mask): Delete.
1041         (_initialize_linux_nat): Don't initialise normal_mask.
1042
1043 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1044
1045         PR gdb/24445
1046         * dwarf-index-write.h (write_psymtabs_to_index): Add
1047         dwz_basename parameter.
1048         * dwarf-index-write.c (write_gdbindex): Move file writing to
1049         write_gdbindex_1.  Change return type void.
1050         (assert_file_size): Move up, remove filename parameter.
1051         (write_gdbindex_1): New function.
1052         (write_debug_names): Change return type to void, call
1053         assert_file_size.
1054         (struct index_wip_file): New struct.
1055         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1056         file logic to index_wip_file.  Write index for dwz file if
1057         needed.
1058         (save_gdb_index_command): Pass basename of dwz file, if present.
1059         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1060         build-id of dwz file, if present.
1061         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1062         (dwarf2_get_dwz_file): Likewise.
1063         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1064         (dwarf2_get_dwz_file): Likewise.
1065
1066 2019-06-16  Tom Tromey  <tom@tromey.com>
1067
1068         * coffread.c (process_coff_symbol): Use xstrdup.
1069         * value.c (create_internalvar): Use xstrdup.
1070
1071 2019-06-16  Tom Tromey  <tom@tromey.com>
1072
1073         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1074         * breakpoint.c (stopin_command, stopat_command)
1075         (until_break_command, decode_location_default): Remove unnecessary
1076         cast.
1077         * utils.c (subset_compare): Remove unnecessary cast.
1078         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1079         cast.
1080         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1081         cast.
1082         * infcmd.c (path_command): Remove unnecessary cast.
1083         * coffread.c (decode_type): Remove unnecessary cast.
1084         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1085         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1086         * tui/tui-stack.c (tui_show_locator_content)
1087         (tui_show_frame_info): Remove unnecessary cast.
1088         * tui/tui-win.c (tui_scroll_forward_command)
1089         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1090         (parse_scrolling_args): Remove unnecessary cast.
1091         * tui/tui-data.c (init_win_info, tui_del_window)
1092         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1093         (free_content_elements): Remove unnecessary cast.
1094         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1095         unnecessary cast.
1096         * tui/tui-source.c (tui_set_source_content)
1097         (tui_vertical_source_scroll): Remove unnecessary cast.
1098         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1099         cast.
1100         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1101         * tui/tui-regs.c (tui_display_registers_from)
1102         (tui_display_register): Remove unnecessary cast.
1103         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1104         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1105         (make_visible): Remove unnecessary cast.
1106         * tui/tui-winsource.c (tui_erase_source_content)
1107         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1108         unnecessary cast.
1109         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1110         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1111         * stabsread.c (read_type, read_array_type, read_range_type):
1112         Remove unnecessary cast.
1113         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1114         (parse_symbol, parse_type, upgrade_type, parse_external)
1115         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1116         unnecessary cast.
1117         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1118
1119 2019-06-16  Tom Tromey  <tom@tromey.com>
1120
1121         * tui/tui-data.c (tui_alloc_generic_win_info)
1122         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1123         checks.
1124
1125 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1126             Andrew Burgess  <andrew.burgess@embecosm.com>
1127
1128         * f-typeprint.c (f_print_type): Don't return early for not
1129         associated or not allocated types.
1130         (f_type_print_varspec_suffix): Add print_rank parameter and print
1131         ranks of array types in case they dangling.
1132         (f_type_print_base): Add print_rank parameter.
1133
1134 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1135
1136         * NEWS: Mention new MI commands.
1137         * break-catch-throw.c (enum exception_event_kind): Move to
1138         breakpoint.h.
1139         (print_mention_exception_catchpoint): Output text as a single
1140         message.
1141         (catch_exception_command_1): Rename to...
1142         (catch_exception_event): ...this, make non-static, update header
1143         command, and change some parameter types.
1144         (catch_catch_command): Update for changes to
1145         catch_exception_command_1.
1146         (catch_throw_command): Likewise.
1147         (catch_rethrow_command): Likewise.
1148         * breakpoint.c (enum exception_event_kind): Delete.
1149         * breakpoint.h (enum exception_event_kind): Moved here from
1150         break-catch-throw.c.
1151         (catch_exception_event): Declare.
1152         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1153         (mi_cmd_catch_throw): New function.
1154         (mi_cmd_catch_rethrow): New function.
1155         (mi_cmd_catch_catch): New function.
1156         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1157         'catch-catch' entries.
1158         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1159         (mi_cmd_catch_rethrow): Declare.
1160         (mi_cmd_catch_catch): Declare.
1161
1162 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1163
1164         * annotate.c (annotate_source_line): Change return type to void,
1165         update implementation to match.
1166         * annotate.h (annotate_source_line): Change return type to void,
1167         update header comment.
1168         * stack.c (print_frame_info): Don't change what frame information
1169         is printed based on whether annotations are on or not.
1170
1171 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1172
1173         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1174         (annotate_source): Make static.
1175         (annotate_source_line): Moved from source.c and renamed from
1176         identify_source_line.  Update the return type.
1177         * annotate.h (annotate_source): Delete declaration.
1178         (annotate_source_line): Declaration moved from source.h, and
1179         renamed from identify_source_line.  Return type updated.
1180         * source.c (identify_source_line): Moved to annotate.c and renamed
1181         to annotate_source_line.
1182         (info_line_command): Remove check of annotation_level.
1183         * source.h (identify_source_line): Move declaration to annotate.h
1184         and rename to annotate_source_line.
1185         * stack.c: Add 'annotate.h' include.
1186         (print_frame_info): Remove check of annotation_level before
1187         calling annotate_source_line.
1188
1189 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1190
1191         * source-cache.c (source_cache::get_plain_source_lines): Use
1192         open_source_file_with_line_charpos instead of just
1193         open_source_file, remove call to find_source_lines.
1194         (source_cache::get_source_lines): Likewise.
1195         * source.c (find_source_lines): Make static.
1196         (get_filename_and_charpos): Renamed into...
1197         (open_source_file_with_line_charpos): ..this along with changes to
1198         return a scoped_fd, and some other minor clean ups.
1199         (identify_source_line): Use open_source_file_with_line_charpos.
1200         (search_command_helper): Use open_source_file_with_line_charpos
1201         instead of just open_source_file, remove call to
1202         find_source_lines.
1203         * source.h (open_source_file_with_line_charpos): Declare new
1204         function.
1205         (find_source_lines): Delete declaration.
1206
1207 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1208
1209         * source.c (get_filename_and_charpos): Remove fullname
1210         parameter.
1211         (identify_source_line): Update call to get_filename_and_charpos.
1212
1213 2019-06-14  Tom Tromey  <tromey@adacore.com>
1214
1215         PR gdb/24502:
1216         * ui-style.h (skip_ansi_escape): Update comment.
1217         * ui-file.h (class no_terminal_escape_file): New class.
1218         * ui-file.c (no_terminal_escape_file::write)
1219         (no_terminal_escape_file::puts): New methods.
1220         * cli/cli-logging.c (handle_redirections): Use
1221         no_terminal_escape_file.
1222
1223 2019-06-14  Tom Tromey  <tromey@adacore.com>
1224
1225         * NEWS: Move convenience variable news above Python news.
1226
1227 2019-06-14  Tom Tromey  <tom@tromey.com>
1228
1229         * gnulib: Move directory to top-level.
1230         * configure.ac: Don't configure gnulib.
1231         * configure: Rebuild.
1232         * common/common-defs.h: Use new path to gnulib.
1233         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1234         (GNULIB_H): Remove.
1235         (INCGNU): Look in new gnulib location.
1236         (HFILES_NO_SRCDIR): Remove gnulib files.
1237         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1238         (generated_files): Remove GNULIB_H.
1239         ($(LIBGNU), all-lib): Remove targets.
1240         (distclean): Don't mention GNULIB_BUILDDIR.
1241         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1242
1243 2019-06-14  Tom Tromey  <tromey@adacore.com>
1244
1245         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1246         Warn if symbol file does not provide any symbols.
1247
1248 2019-06-14  Tom Tromey  <tromey@adacore.com>
1249
1250         * source.c (find_and_open_source): Respect basenames_may_differ.
1251
1252 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1253
1254         * annotate.c (annotate_breakpoints_invalid): Make use of
1255         scoped_restore_terminal_state.
1256         (annotate_frames_invalid): Likewise.
1257
1258 2019-06-14  Tom Tromey  <tromey@adacore.com>
1259
1260         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1261         allow assignment to an internalvar.
1262
1263 2019-06-14  Tom Tromey  <tromey@adacore.com>
1264
1265         * ada-lex.l: Allow "_" in attribute names.
1266
1267 2019-06-14  Tom Tromey  <tromey@adacore.com>
1268
1269         PR gdb/24653:
1270         * regcache.c (registers_changed): Don't call alloca.
1271         * top.c (execute_command): Don't call alloca.
1272
1273 2019-06-13  Pedro Alves  <palves@redhat.com>
1274
1275         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1276         'expression'.  When parsing an expression, error out if there's
1277         junk after "unlimited".
1278         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1279         (do_set_command): Adjust calls to is_unlimited_literal.
1280
1281 2019-06-13  Pedro Alves  <palves@redhat.com>
1282
1283         * compile/compile.c (make_compile_options_def_group): Add braces
1284         around array_view initializer.
1285         * thread.c (make_thread_apply_all_options_def_group)
1286         (make_thread_apply_all_options_def_group): Likewise.
1287
1288 2019-06-13  Pedro Alves  <palves@redhat.com>
1289
1290         * NEWS (New commands): Mention "maint test-options
1291         require-delimiter", "maint test-options unknown-is-error", "maint
1292         test-options unknown-is-operand" and "maint show
1293         test-options-completion-result".
1294         (New command options, command completion): New section.
1295         (Completion improvements): New section.
1296         Mention that you can abbreviate "unlimited".
1297
1298 2019-06-13  Pedro Alves  <palves@redhat.com>
1299
1300         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1301         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1302         * unittests/cli-utils-selftests.c (test_parse_flags)
1303         (test_parse_flags_qcs): Delete.
1304         (test_cli_utils): Don't call deleted functions.
1305
1306 2019-06-13  Pedro Alves  <palves@redhat.com>
1307
1308         * thread.c: Include "cli/cli-option.h".
1309         (tp_array_compar_ascending): Global.
1310         (tp_array_compar): Delete function.
1311         (tp_array_compar_ascending, tp_array_compar_descending): New
1312         functions.
1313         (ascending_option_def, qcs_flag_option_def)
1314         (thr_qcs_flags_option_defs)
1315         (make_thread_apply_all_options_def_group)
1316         (make_thread_apply_options_def_group): New.
1317         (thread_apply_all_command): Use gdb::option::process_options.
1318         (thread_apply_command_completer)
1319         (thread_apply_all_command_completer): New.
1320         (thread_apply_command): Use gdb::option::process_options.
1321         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1322         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1323         to generate help text of "thread apply".  Adjust "taas"'s help.
1324         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1325         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1326
1327 2019-06-13  Pedro Alves  <palves@redhat.com>
1328
1329         * thread.c (thread_apply_command): Check for invalid TID with
1330         isdigit instead of !isalpha.
1331
1332 2019-06-13  Pedro Alves  <palves@redhat.com>
1333
1334         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1335         (validate_flags_qcs): New.
1336         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1337         (validate_flags_qcs): Declare.
1338         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1339         (make_frame_apply_options_def_group): New.
1340         (frame_apply_command_count): Process options with
1341         gdb::option::process_options.
1342         (frame_apply_completer): New.
1343         (frame_apply_level_completer, frame_apply_all_completer)
1344         (frame_apply_completer): New.
1345         (_initialize_stack): Update help of "frame apply", "frame apply
1346         level", "frame apply all" and "faas" to mention supported options
1347         and install command completers.
1348         * stack.h (frame_apply_all_completer): Declare.
1349         * thread.c: Include "stack.h".
1350         (tfaas_command): Add "--".
1351         (_initialize_thread): Update help "tfaas" to mention supported
1352         options and install command completer.
1353
1354 2019-06-13  Pedro Alves  <palves@redhat.com>
1355
1356         * completer.c (complete_nested_command_line): New.
1357         (gdb_completion_word_break_characters_throw): Add assertion.
1358         * completer.h (complete_nested_command_line): Declare.
1359
1360 2019-06-13  Pedro Alves  <palves@redhat.com>
1361
1362         * stack.c (parse_backtrace_qualifiers): New.
1363         (backtrace_command): Use it.
1364         (backtrace_command_completer): Complete on qualifiers.
1365
1366 2019-06-13  Pedro Alves  <palves@redhat.com>
1367
1368         * frame.c: Include "cli/cli-option.h.
1369         (user_set_backtrace_options): New.
1370         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1371         Delete.
1372         (get_prev_frame): Adjust.
1373         (boolean_option_def, uinteger_option_def)
1374         (set_backtrace_option_defs): New.
1375         (_initialize_frame): Adjust and use
1376         gdb::option::add_setshow_cmds_for_options to install "set
1377         backtrace past-main" and "set backtrace past-entry".
1378         * frame.h: Include "cli/cli-option.h".
1379         (struct frame_print_options): Forward declare.
1380         (print_frame_arguments_all, print_frame_arguments_scalars)
1381         (print_frame_arguments_none): Declare.
1382         (print_entry_values): Delete declaration.
1383         (struct frame_print_options, user_frame_print_options): New.
1384         (struct set_backtrace_options): New.
1385         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1386         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1387         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1388         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1389         (list_args_or_locals): Add frame_print_options parameter.
1390         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1391         * python/py-framefilter.c (enumerate_args): Pass down
1392         USER_FRAME_PRINT_OPTIONS.
1393         * stack.c: Include "cli/cli-option.h".
1394         (print_frame_arguments_all, print_frame_arguments_scalars)
1395         (print_frame_arguments_none): Declare.
1396         (print_raw_frame_arguments, print_entry_values): Delete.
1397         (user_frame_print_options): New.
1398         (boolean_option_def, enum_option_def, frame_print_option_defs):
1399         New.
1400         (struct backtrace_cmd_options): New.
1401         (bt_flag_option_def): New.
1402         (backtrace_command_option_defs): New.
1403         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1404         (print_frame_arg, read_frame_arg, print_frame_args)
1405         (print_frame_info, print_frame): Add frame_print_options parameter
1406         and use it.
1407         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1408         (backtrace_command_1): Add frame_print_options and
1409         backtrace_cmd_options parameters and use them.
1410         (make_backtrace_options_def_group): New.
1411         (backtrace_command): Process command options with
1412         gdb::option::process_options.
1413         (backtrace_command_completer): New.
1414         (_initialize_stack): Extend "backtrace"'s help to mention
1415         supported options.  Install completer for "backtrace".
1416         Install some settings commands with add_setshow_cmds_for_options.
1417
1418 2019-06-13  Pedro Alves  <palves@redhat.com>
1419
1420         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1421         and that "set/show print raw frame-arguments" are now deprecated.
1422
1423         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1424         command.
1425         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1426         * stack.c (_initialize_stack): Install "set/show print
1427         raw-frame-arguments", and deprecate "set/show print raw
1428         frame-arguments".
1429         * valprint.c (_initialize_valprint): Deprecate "set/show print
1430         raw".
1431
1432 2019-06-13  Pedro Alves  <palves@redhat.com>
1433
1434         * compile/compile.c (struct compile_options): New.
1435         (compile_flag_option_def, compile_command_option_defs)
1436         (make_compile_options_def_group): New.
1437         (compile_file_command): Handle options with
1438         gdb::option::process_options.
1439         (compile_file_command_completer): New function.
1440         (compile_code_command): Handle options with
1441         gdb::option::process_options.
1442         (compile_code_command_completer): New function.
1443         (_initialize_compiler): Install completers for "compile code" and
1444         "compile file".  Mention available options in "compile code" and
1445         "compile code"'s help.
1446         * completer.c (advance_to_completion_word): New, factored out from
1447         ...
1448         (advance_to_expression_complete_word_point): ... this.
1449         (advance_to_filename_complete_word_point): New.
1450         * completer.h (advance_to_filename_complete_word_point): New
1451         declaration.
1452
1453 2019-06-13  Pedro Alves  <palves@redhat.com>
1454
1455         * compile/compile.c: Include "cli/cli-option.h".
1456         (compile_print_value): Scope data pointer is now a
1457         value_print_options pointer; adjust.
1458         (compile_print_command): Process options.  Scope data pointer is
1459         now a value_print_options pointer; adjust.
1460         (_initialize_compile): Update "compile print"'s help to include
1461         supported options.  Install a completer for "compile print".
1462         * cp-valprint.c (show_vtblprint, show_objectprint)
1463         (show_static_field_print): Delete.
1464         (_initialize_cp_valprint): Don't install "set print
1465         static-members", "set print vtbl", "set print object" here.
1466         * printcmd.c: Include "cli/cli-option.h" and
1467         "common/gdb_optional.h".
1468         (print_command_parse_format): Rework to fill in a
1469         value_print_options instead of a format_data.
1470         (print_value): Change parameter type from format_data pointer to
1471         value_print_options reference.  Adjust.
1472         (print_command_1): Process options.  Adjust to pass down a
1473         value_print_options.
1474         (print_command_completer): New.
1475         (_initialize_printcmd): Install print_command_completer as
1476         handle_brkchars completer for the "print" command.  Update
1477         "print"'s help to include supported options.
1478         * valprint.c: Include "cli/cli-option.h".
1479         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1480         here from cp-valprint.c.
1481         (boolean_option_def, uinteger_option_def)
1482         (value_print_option_defs, make_value_print_options_def_group):
1483         New.  Use gdb::option::add_setshow_cmds_for_options to install
1484         "set print elements", "set print null-stop", "set print repeats",
1485         "set print pretty", "set print union", "set print array", "set
1486         print address", "set print symbol", "set print array-indexes".
1487         * valprint.h: Include <string> and "cli/cli-option.h".
1488         (make_value_print_options_def_group): Declare.
1489         (print_value): Change parameter type from format_data pointer to
1490         value_print_options reference.
1491         (print_command_completer): Declare.
1492
1493 2019-06-13  Pedro Alves  <palves@redhat.com>
1494
1495         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1496         (COMMON_SFILES): Add maint-test-settings.c.
1497         * cli/cli-decode.c (boolean_enums): New global, factored out from
1498         ...
1499         (add_setshow_boolean_cmd): ... here.
1500         * cli/cli-decode.h (boolean_enums): Declare.
1501         * cli/cli-option.c: New file.
1502         * cli/cli-option.h: New file.
1503         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1504         factored out from ...
1505         (parse_cli_boolean_value(const char *)): ... this.
1506         (is_unlimited_literal): Change parameter type to pointer to
1507         pointer.  Adjust and advance ARG pointer.
1508         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1509         (parse_cli_var_enum): New, factored out from ...
1510         (do_set_command): ... this.  Adjust.
1511         * cli/cli-setshow.h (parse_cli_boolean_value)
1512         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1513         (parse_cli_var_enum): Declare.
1514         * cli/cli-utils.c: Include "cli/cli-option.h".
1515         (get_ulongest): New.
1516         * cli/cli-utils.h (get_ulongest): Declare.
1517         (check_for_argument): New overloads.
1518         * maint-test-options.c: New file.
1519
1520 2019-06-13  Pedro Alves  <palves@redhat.com>
1521
1522         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1523         parse a range if "-" is at the end of the string.
1524
1525 2019-06-13  Pedro Alves  <palves@redhat.com>
1526
1527         * cli/cli-setshow.c (parse_auto_binary_operation)
1528         (parse_cli_boolean_value): Don't allow "o".
1529
1530 2019-06-13  Pedro Alves  <palves@redhat.com>
1531
1532         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1533         * NEWS: Mention maint test-settings KIND.
1534         * maint-test-settings.c: New file.
1535
1536 2019-06-13  Pedro Alves  <palves@redhat.com>
1537
1538         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1539         completer.
1540         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1541         "set" completers.
1542
1543 2019-06-13  Pedro Alves  <palves@redhat.com>
1544
1545         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1546         after item.
1547
1548 2019-06-13  Pedro Alves  <palves@redhat.com>
1549
1550         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1551
1552 2019-06-13  Pedro Alves <palves@redhat.com>
1553
1554         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1555         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1556         call.
1557         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1558         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1559         calls.
1560         (check_for_argument): Skip spaces after argument.
1561
1562 2019-06-13  Pedro Alves  <palves@redhat.com>
1563
1564         * thread.c (thread_apply_command): Adjust TID parsing.
1565         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1566         detected before end of string.
1567         (tid_is_in_list): Error out if LIST is invalid.
1568
1569 2019-06-13  Pedro Alves  <palves@redhat.com>
1570
1571         * completer.c (complete_line_internal_1): Rewind completion word
1572         point.
1573         (completion_tracker::advance_custom_word_point_by): Change
1574         parameter type to int.
1575         * completer.h (completion_tracker::advance_custom_word_point_by):
1576         Likewise.
1577
1578 2019-06-13  Pedro Alves  <palves@redhat.com>
1579
1580         * completer.c (advance_to_completion_word): Handle delimiters.
1581
1582 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1583
1584         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1585
1586 2019-06-11  Tom Tromey  <tom@tromey.com>
1587
1588         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1589         (xmalloc_failed): Move to alloc.c.
1590         * alloc.c: New file.
1591         * Makefile.in (COMMON_SFILES): Add alloc.c.
1592
1593 2019-06-11  Tom Tromey  <tom@tromey.com>
1594
1595         * nat/linux-waitpid.c: Don't include server.h.
1596         (linux_debug): Remove.
1597         (my_waitpid): Update.
1598
1599 2019-06-11  Tom Tromey  <tromey@adacore.com>
1600
1601         * infcall.c (_initialize_infcall): Remove trailing newline from
1602         help.
1603         * user-regs.c (_initialize_user_regs): Remove trailing newline
1604         from help.
1605         * typeprint.c (_initialize_typeprint): Remove trailing newline
1606         from help.
1607         * reverse.c (_initialize_reverse): Remove trailing newlines from
1608         help.
1609         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1610         from help.
1611         * language.c (add_set_language_command): Remove trailing newline
1612         from help.
1613         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1614         help.
1615         * disasm.c (_initialize_disasm): Remove trailing newline from
1616         help.
1617         * top.c (init_main): Remove trailing newline from help.
1618         * interps.c (_initialize_interpreter): Remove trailing newline
1619         from help.
1620         * btrace.c (_initialize_btrace): Remove trailing newlines from
1621         help.
1622         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1623         from help.
1624         * python/python.c (_initialize_python): Remove trailing newline
1625         from help.
1626         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1627         help.
1628         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1629         from help.  Reformat some text.
1630         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1631         from help.
1632         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1633         newline from help.
1634
1635 2019-06-11  Tom Tromey  <tromey@adacore.com>
1636
1637         * darwin-nat.c (darwin_decode_exception_message)
1638         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1639
1640 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1641
1642         * valops.c (value_slice): Check for not allocated or not
1643         associated values.
1644
1645 2019-06-10  Tom de Vries  <tdevries@suse.de>
1646
1647         PR gdb/24618
1648         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1649         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1650         invalid.
1651
1652 2019-06-10  Tom de Vries  <tdevries@suse.de>
1653
1654         PR gdb/24611
1655         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1656         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1657
1658 2019-06-10  Tom de Vries  <tdevries@suse.de>
1659
1660         PR symtab/24545
1661         * symtab.c (struct demangled_name_entry): Add language field.
1662         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1663         static minimal symbol".  Set and use language field.
1664
1665 2019-06-10  Tom Tromey  <tromey@adacore.com>
1666
1667         * ada-lang.c (_initialize_ada_language): Update help text.
1668
1669 2019-06-10  Tom Tromey  <tromey@adacore.com>
1670
1671         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1672         with a newline.
1673         * guile/guile.c (handle_boot_error): Don't end warning with a
1674         newline.
1675         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1676         warning with a newline.
1677         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1678         newline.
1679         (s12z_frame_cache): Likewise.
1680         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1681         a newline.
1682         * solib-svr4.c (disable_probes_interface): Don't end warning with
1683         a newline.
1684         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1685         newline.
1686         * python/python.c (do_finish_initialization): Don't end warning
1687         with a newline.
1688
1689 2019-06-10  Tom Tromey  <tom@tromey.com>
1690
1691         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1692         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1693         gdbpy_enter.
1694
1695 2019-06-10  Tom Tromey  <tromey@adacore.com>
1696
1697         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1698         data.
1699         (elf_new_init): Don't call stabsread_new_init.
1700         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1701         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1702         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1703
1704 2019-06-10  Tom de Vries  <tdevries@suse.de>
1705
1706         PR symtab/16264
1707         PR symtab/24517
1708         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1709
1710 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1711
1712         * source.c (find_and_open_source): Also rewrite relative file
1713         names.
1714
1715 2019-04-26  Amos Bird  <amosbird@gmail.com>
1716
1717         * annotate.c (annotate_thread_exited): Add "thread-exited"
1718         annotation.
1719
1720 2019-06-06  Tom Tromey  <tromey@adacore.com>
1721
1722         * maint.h (class scoped_command_stats): Use
1723         DISABLE_COPY_AND_ASSIGN.
1724         <print_time>: New method.
1725         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1726         print_time.
1727         (scoped_command_stats::print_time): New method.
1728
1729 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1730
1731         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1732         instructions of lengths 6 or 8 bytes.
1733
1734 2019-06-04  Pedro Alves  <palves@redhat.com>
1735
1736         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1737
1738         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1739         * breakpoint.c (condition_completer): Likewise.
1740         * cli/cli-dump.c (scan_expression): Likewise.
1741         * common/filestuff.c (mkdir_recursive): Likewise.
1742         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1743         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1744         (gdb_abspath): Likewise.
1745         * compile/compile-cplus-types.c
1746         (compile_cplus_instance::decl_name): Likewise.
1747         * completer.c (complete_explicit_location):
1748         (signal_completer, reg_or_group_completer_1): Likewise.
1749         * cp-support.c (cp_remove_params_if_any): Likewise.
1750         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1751         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1752         * infcmd.c (strip_bg_char): Likewise.
1753         * linespec.c (copy_token_string): Likewise.
1754         * mi/mi-main.c (output_cores): Likewise.
1755         * psymtab.c (psymtab_search_name):
1756         * symfile.c (test_set_ext_lang_command): Likewise.
1757         * target.c (target_fileio_read_stralloc): Likewise.
1758         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1759         * value.c (complete_internalvar): Likewise.
1760
1761 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1762
1763         Add objfile property to gdb.Type.
1764         * NEWS: Mention Python API addition.
1765         * python/py-type.c (typy_get_objfile): New method.
1766
1767 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1768
1769         * NEWS: Mention the new set|show style [title|highlight].
1770         Mention changes to "show style", "help" and "apropos".
1771
1772 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1773
1774         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1775         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1776         instead of print_help_for_command.
1777         (print_doc_of_command): New function.
1778         (help_list): Add 'apropos -v word' suggestion.
1779         (print_help_for_command): Style the command name using title style.
1780         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1781         (_initialize_cli_cmds): Describe -v in apropos_command help.
1782
1783 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1784
1785         * cli/cli-style.h (cli_style_option): Add name in constructor,
1786         add m_name class member, add constructor with intensity,
1787         add name class function.
1788         (cli_style_option::add_setshow_commands): Remove name argument.
1789         (highlight_style, title_style): New styles.
1790         * cli/cli-style.c (do_show): New function that shows a style
1791         characteristic styling the style name with itself.
1792         (set_style_name): New function.
1793         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1794         Update all callers according to the changes in cli/cli-style.h.
1795         * utils.h (fputs_highlighted): New function.
1796         * utils.c (fputs_highlighted): Likewise.
1797
1798 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1799
1800         * NEWS: Mention new pipe command and new convenience variables.
1801
1802 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1803
1804         * cli/cli-cmds.c (pipe_command): New function.
1805         (_initialize_cli_cmds): Call add_com for pipe_command.
1806         Define | as an alias for pipe.
1807         (exit_status_set_internal_vars): New function.
1808         (shell_escape): Call exit_status_set_internal_vars.
1809         cli/cli-decode.c (find_command_name_length): Recognize | as
1810         a single character command.
1811
1812 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1813
1814         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1815         top.c (execute_command_to_ui_file): New function, mostly a copy
1816         of execute_command_to_string.
1817         (execute_command_to_string): Implement by calling
1818         execute_command_to_ui_file.
1819
1820 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1821
1822         * top.h (saved_command_line): Remove declaration.
1823         * top.c (previous_saved_command_line, previous_repeat_arguments):
1824         New variables.
1825         (saved_command_line): Make static, define together with other
1826         'repeat variables'.
1827         (dont_repeat): Clear repeat_arguments.
1828         (repeat_previous, get_saved_command_line, save_command_line):
1829         New functions.
1830         (gdb_init): Initialize saved_command_line
1831         and previous_saved_command_line.
1832         * main.c (captured_main_1): Remove saved_command_line initialization.
1833         * event-top.c (handle_line_of_input): Update to use
1834         the new 'repeat' related functions instead of direct access to
1835         saved_command_line.
1836         * command.h (repeat_previous, get_saved_command_line,
1837         save_command_line): New declarations.
1838         (dont_repeat): Add comment.
1839
1840 2019-05-30  Tom Tromey  <tromey@adacore.com>
1841
1842         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1843         Fix comment.
1844         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1845
1846 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1847
1848         PR cli/24587
1849         * completer.c (complete): Initialize variable word.
1850
1851 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1852
1853         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1854         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1855         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1856         'body' is NULL to the outter 'if', protecting the '!is_define'
1857         situation as well.
1858
1859 2019-05-29  Tom Tromey  <tromey@adacore.com>
1860
1861         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1862         (dwarf_unknown): New function.
1863         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1864         (dwarf_type_encoding_name): Use dwarf_unknown.
1865
1866 2019-05-29  Tom Tromey  <tromey@adacore.com>
1867
1868         PR c++/20020:
1869         * cp-valprint.c (cp_print_value_fields): Call
1870         cp_print_static_field inside "try".
1871
1872 2019-05-29  Tom Tromey  <tromey@adacore.com>
1873
1874         * inflow.c (struct terminal_info): Add default operator=.
1875         * configure: Rebuild.
1876         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1877         -Wdeprecated-copy-dtor, -Wredundant-move.
1878
1879 2019-05-29  Tom Tromey  <tromey@adacore.com>
1880
1881         * NEWS: Add entry.
1882         * infcmd.c (print_return_value_1): Handle finish_print
1883         option.
1884         (show_print_finish): New function.
1885         (_initialize_infcmd): Add "set/show print finish" commands.
1886         * valprint.c (user_print_options): Initialize new member.
1887         * valprint.h (struct value_print_options) <finish_print>: New
1888         member.
1889
1890 2019-05-28  Tom Tromey  <tromey@adacore.com>
1891
1892         * ada-lang.c (ada_remove_Xbn_suffix)
1893         (find_old_style_renaming_symbol)
1894         (parse_old_style_renaming): Remove.
1895         (ada_find_renaming_symbol): Don't call
1896         find_old_style_renaming_symbol.
1897         (ada_is_renaming_symbol): Rename from
1898         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1899         bool.  Now static.
1900         (ada_read_var_value): Update and simplify.
1901         * ada-exp.y (write_var_or_type): Remove old code.
1902
1903 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1904
1905         * event-top.c: Remove include comment.
1906         * inflow.c (class scoped_ignore_sigttou): Move from here...
1907         * inflow.h (class scoped_ignore_sigttou): ...to here.
1908         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1909         * top.c:  Remove include comment.
1910
1911 2019-05-27  Tom Tromey  <tom@tromey.com>
1912
1913         * NEWS: Fix typo.
1914
1915 2019-05-22  Tom Tromey  <tromey@adacore.com>
1916
1917         * target.c (target_follow_exec): Constify parameter.
1918         * target-delegates.c: Rebuild.
1919         * remote.c (remote_target::follow_exec): Constify parameter.
1920         * infrun.c (follow_exec): Constify parameter.
1921         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1922         (target_follow_exec): Likewise.
1923
1924 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1925
1926         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1927         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1928
1929 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1930
1931         * NEWS: Add debugredirect and testsuite sections.
1932
1933 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1934
1935         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1936         target descriptions using exclusively floating point register name
1937         aliases.
1938
1939 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1940
1941         PR gdb/18644:
1942         * f-lang.c (build_fortran_types): Handle the case where
1943         gdbarch_floatformat_for_type returns a nullptr.
1944
1945 2019-05-21  Tom de Vries  <tdevries@suse.de>
1946
1947         PR cli/24587
1948         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1949
1950 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1951
1952         PR gdb/18644:
1953         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1954         16-byte floats.
1955         * i386-tdep.c (i386_floatformat_for_type): Use
1956         floatformats_ia64_quad for the 16-byte floating point component
1957         within a fortran 32-byte complex number.
1958
1959 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1960
1961         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1962         delete default constructor.
1963         (find_partial_die): Update to return const struct.
1964         (partial_die_parent_scope): Move variable declaration into scope
1965         of its use and change its type to auto.
1966         (guess_partial_die_structure_name): Likewise.
1967         (partial_die_info::fixup): Likewise.
1968
1969 2019-05-17  Tom Tromey  <tromey@adacore.com>
1970
1971         * source.c (find_and_open_source): Remove cast.
1972
1973 2019-05-17  Tom Tromey  <tromey@adacore.com>
1974
1975         * annotate.c (annotate_source): Make "filename" const.
1976         * annotate.h (annotate_source): Use const.
1977
1978 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1979
1980         * disasm.c (set_disassembler_options): Send errors to stderr.
1981
1982 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1983
1984         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1985         (cli_interp_base::set_logging): Check debug_redirect.
1986         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1987         * cli/cli-logging.c (debug_redirect): Add static variable.
1988         (pop_output_files): Add default param.
1989         (handle_redirections): Print debug setting.
1990         (show_logging_command): Likewise.
1991         (_initialize_cli_logging): Add debugredirect command.
1992         * interps.c (current_interp_set_logging): Add debug_redirect
1993         parameter.
1994         * interps.h (set_logging): Add debug_redirect parameter.
1995         (current_interp_set_logging): Likewise.
1996         * mi/mi-common.h: Likewise.
1997         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1998
1999 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2000             Tom Tromey  <tromey@adacore.com>
2001
2002         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2003         directly.
2004         * cli/cli-interp.h (make_logging_output): Remove declaration.
2005         * cli/cli-logging.c (make_logging_output): Remove function.
2006         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2007         directly.
2008         * ui-file.c (tee_file::tee_file): Remove bools.
2009         (tee_file::~tee_file): Remove deletes.
2010         * ui-file.h (tee_file): Remove bools.
2011
2012 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2013
2014         * mi/mi-cmds.h (mi_cmd_complete): New function.
2015         * mi/mi-main.c (mi_cmd_complete): Likewise.
2016         * mi/mi-cmds.c: Define new MI command -complete.
2017         * NEWS: Mention new -complete command.
2018
2019 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2020
2021         * completer.h (complete): New function.
2022         * completer.c (complete): Likewise.
2023         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2024         function defined in completer.h.
2025
2026 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2027
2028         * MAINTAINERS (Write After Approval): Add myself.
2029
2030 2019-05-17  Tom de Vries  <tdevries@suse.de>
2031
2032         PR gdb/24094
2033         * dwarf2read.c (struct cu_partial_die_info): New struct.
2034         (find_partial_die): Return cu_partial_die_info.
2035         (partial_die_parent_scope, guess_partial_die_structure_name)
2036         (partial_die_info::fixup): Handle new return type of find_partial_die.
2037
2038 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2039
2040         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2041         "std::string", simplifying the algorithm.
2042
2043 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2044
2045         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2046         (stap_static_probe_ops::get_probes): Likewise.
2047
2048 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2049
2050         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2051         '-')" and "else if".
2052         (stap_parse_single_operand): Join checks for
2053         "gdbarch_stap_parse_special_token_p" and
2054         "gdbarch_stap_parse_special_token" in the same "if" statement.
2055         Invert check when verifying for operation on register
2056         displacement.
2057
2058 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2059
2060         * stap-probe.c (stap_get_opcode): Update comment.
2061         (stap_get_expected_argument_type): Likewise.
2062         (handle_stap_probe): Likewise.
2063
2064 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2065
2066         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2067         return type to 'bool'.  Adjust comment.  Use 'bool' when
2068         appropriate.
2069         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2070         * stap-probe.c (stap_parse_argument_1): Likewise.
2071         (stap_is_operator): Likewise.
2072         (stap_is_generic_prefix): Likewise.
2073         (stap_is_register_prefix): Likewise.
2074         (stap_is_register_indirection_prefix): Likewise.
2075         (stap_is_integer_prefix): Likewise.
2076         (stap_generic_check_suffix): Likewise.
2077         (stap_check_integer_suffix): Likewise.
2078         (stap_check_register_suffix): Likewise.
2079         (stap_check_register_indirection_suffix): Likewise.
2080         (stap_parse_register_operand): Likewise.
2081         (stap_parse_single_operand): Likewise.
2082         (stap_parse_argument_1): Likewise.
2083         (stap_probe::get_argument_count): Likewise.
2084         (stap_is_operator): Likewise.
2085
2086 2019-05-16  Tom Tromey  <tromey@adacore.com>
2087
2088         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2089         keyword to foreach.
2090
2091 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2092
2093         * linux-thread-db.c (try_thread_db_load_1): Change return type
2094         to bool.
2095         (try_thread_db_load): Likewise.
2096         (try_thread_db_load_from_pdir_1): Likewise.
2097         (try_thread_db_load_from_pdir): Likewise.
2098         (try_thread_db_load_from_sdir): Likewise.
2099         (try_thread_db_load_from_dir): Likewise.
2100         (thread_db_load_search): Likewise.
2101         (has_libpthread): Likewise.
2102         (thread_db_load): Likewise.
2103
2104 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2105
2106         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2107         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2108         NULL, and complain/return if that's the case.
2109
2110 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2111
2112         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2113         (advance, posn, abstract_read_memory): New functions.
2114         [struct mem_read_abstraction]: New struct.
2115         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2116
2117 2019-05-14  Tom Tromey  <tromey@adacore.com>
2118
2119         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2120         value is not lval_memory.
2121
2122 2019-05-14  Tom Tromey  <tromey@adacore.com>
2123
2124         * solib.c (info_sharedlibrary_command): Style the file name.
2125
2126 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2127
2128         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2129         (aarch64_vnv_type): Likewise.
2130         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2131         * common/tdesc.c: Likewise.
2132         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2133         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2134         * features/aarch64-fpu.xml: Add ieee half view.
2135         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2136         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2137         * gdbtypes.h (struct builtin_type): Likewise.
2138         (struct objfile_type): Likewise.
2139
2140 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2141
2142         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2143         typo.
2144         * location.h (string_to_event_location): Likewise.
2145
2146 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2147
2148         GDB 8.3 released.
2149
2150 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2151
2152         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2153         New variable declaration.
2154         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2155         New variable.
2156         (print_one_breakpoint): Use ui_out::test_flags and new global
2157         variable to compute use_fixed_output.
2158         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2159         Remove.
2160         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2161         (mi_multi_location_breakpoint_output_fixed): Remove.
2162         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2163         new variable.
2164         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2165         fix_multi_location_breakpoint_output flag if version >= 3.
2166         * ui-out.h (enum ui_out_flag)
2167         <fix_multi_location_breakpoint_output>: New enumerator.
2168
2169 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2170
2171         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2172
2173 2019-05-10  Tom Tromey  <tromey@adacore.com>
2174
2175         * ada-lang.c (catch_ada_completer): New function.
2176         (_initialize_ada_language): Use it.
2177
2178 2019-05-10  Tom Tromey  <tromey@adacore.com>
2179
2180         * thread.c (print_thread_info): Make "requested_threads" const.
2181         * gdbthread.h (print_thread_info): Make "requested_threads"
2182         const.
2183         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2184         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2185
2186 2019-05-08  Tom Tromey  <tom@tromey.com>
2187
2188         * gdbtypes.c (objfile_type_data): Change type.
2189         (objfile_type, _initialize_gdbtypes): Update.
2190
2191 2019-05-08  Tom Tromey  <tom@tromey.com>
2192
2193         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2194         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2195         (_initialize_dwarf2_frame): Update.
2196
2197 2019-05-08  Tom Tromey  <tom@tromey.com>
2198
2199         * objc-lang.c (objc_objfile_data): Change type.
2200         (find_methods): Update.
2201         (_initialize_objc_lang): Remove.
2202
2203 2019-05-08  Tom Tromey  <tom@tromey.com>
2204
2205         * stabsread.c (rs6000_builtin_type_data): Change type.
2206         (rs6000_builtin_type, _initialize_stabsread): Update.
2207
2208 2019-05-08  Tom Tromey  <tom@tromey.com>
2209
2210         * mips-tdep.c (mips_pdr_data): Remove.
2211         (_initialize_mips_tdep): Update.
2212
2213 2019-05-08  Tom Tromey  <tom@tromey.com>
2214
2215         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2216         (hppa_init_objfile_priv_data, read_unwind_info)
2217         (find_unwind_entry, _initialize_hppa_tdep): Update.
2218
2219 2019-05-08  Tom Tromey  <tom@tromey.com>
2220
2221         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2222         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2223         on obstack.
2224         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2225
2226 2019-05-08  Tom Tromey  <tom@tromey.com>
2227
2228         * mdebugread.c (basic_type_data): Change type.
2229         (basic_type, _initialize_mdebugread): Update.
2230
2231 2019-05-08  Tom Tromey  <tom@tromey.com>
2232
2233         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2234
2235 2019-05-08  Tom Tromey  <tom@tromey.com>
2236
2237         * nto-tdep.c (nto_inferior_data_reg): Change type.
2238         (nto_inferior_data): Update.
2239         (nto_inferior_data_cleanup, nto_new_inferior_data)
2240         (_initialize_nto_tdep): Remove.
2241         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2242
2243 2019-05-08  Tom Tromey  <tom@tromey.com>
2244
2245         * ada-lang.c (struct ada_inferior_data): Add initializers.
2246         (ada_inferior_data): Change type.
2247         (ada_inferior_data_cleanup): Remove.
2248         (get_ada_inferior_data, ada_inferior_exit)
2249         (struct ada_pspace_data): Add initializers, destructor.
2250         (ada_pspace_data_handle): Change type.
2251         (get_ada_pspace_data): Update.
2252         (ada_pspace_data_cleanup): Remove.
2253
2254 2019-05-08  Tom Tromey  <tom@tromey.com>
2255
2256         * coffread.c (struct coff_symfile_info): Add initializers.
2257         (coff_objfile_data_key): Move lower.  Change type.
2258         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2259         Update.
2260         (coff_free_info): Remove.
2261
2262 2019-05-08  Tom Tromey  <tom@tromey.com>
2263
2264         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2265         (fbsd_pspace_data_handle): Move lower.  Change type.
2266         (get_fbsd_pspace_data): Update.
2267         (fbsd_pspace_data_cleanup): Remove.
2268         (_initialize_fbsd_tdep): Update.
2269
2270 2019-05-08  Tom Tromey  <tom@tromey.com>
2271
2272         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2273         (get_ada_tasks_pspace_data): Update.
2274         (ada_tasks_pspace_data_cleanup): Remove.
2275         (_initialize_tasks): Update.
2276         (ada_tasks_inferior_data_handle): Change type.
2277         (get_ada_tasks_inferior_data): Update.
2278         (ada_tasks_inferior_data_cleanup): Remove.
2279         (struct ada_tasks_pspace_data): Add initializers.
2280
2281 2019-05-08  Tom Tromey  <tom@tromey.com>
2282
2283         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2284         * symfile-debug.c (debug_sym_get_probes): Change type.
2285         * stap-probe.c (handle_stap_probe):
2286         (stap_static_probe_ops::get_probes): Change type.
2287         * probe.h (class static_probe_ops) <get_probes>: Change type.
2288         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2289         (parse_probes_in_pspace): Update.
2290         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2291         Update.
2292         (any_static_probe_ops::get_probes): Change type.
2293         * elfread.c (elfread_data): New typedef.
2294         (probe_key): Change type.
2295         (elf_get_probes): Likewise.  Update.
2296         (probe_key_free): Remove.
2297         (_initialize_elfread): Update.
2298         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2299         Change type.
2300         (dtrace_process_dof_probe, dtrace_process_dof)
2301         (dtrace_static_probe_ops::get_probe): Change type.
2302
2303 2019-05-08  Tom Tromey  <tom@tromey.com>
2304
2305         * xcoffread.c (struct xcoff_symfile_info): Rename from
2306         coff_symfile_info.  Add initializers.
2307         (xcoff_objfile_data_key): Move lower.  Change type.
2308         (XCOFF_DATA): Rewrite.
2309         (xcoff_free_info): Remove.
2310         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2311         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2312         (xcoff_initial_scan): Update.
2313
2314 2019-05-08  Tom Tromey  <tom@tromey.com>
2315
2316         * solib-svr4.c (struct svr4_info): Add initializers and
2317         destructor.
2318         <probes_table>: Now an htab_up.
2319         (solib_svr4_pspace_data): Change type.
2320         (free_probes_table): Simplify.
2321         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2322         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2323         (probes_table_remove_objfile_probes, register_solib_event_probe)
2324         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2325         (_initialize_svr4_solib): Update.
2326
2327 2019-05-08  Tom Tromey  <tom@tromey.com>
2328
2329         * remote.c (remote_pspace_data): Change type.
2330         (remote_pspace_data_cleanup): Remove.
2331         (get_remote_exec_file, set_pspace_remote_exec_file)
2332         (_initialize_remote): Update.
2333
2334 2019-05-08  Tom Tromey  <tom@tromey.com>
2335
2336         * breakpoint.c (breakpoint_objfile_key): Change type.
2337         (get_breakpoint_objfile_data): Update.
2338         (free_breakpoint_objfile_data): Remove.
2339         (_initialize_breakpoint): Update.
2340
2341 2019-05-08  Tom Tromey  <tom@tromey.com>
2342
2343         * linux-tdep.c (struct linux_info): Add initializers.
2344         (linux_inferior_data): Move.  Change type.
2345         (invalidate_linux_cache_inf): Update.
2346         (linux_inferior_data_cleanup): Remove.
2347         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2348
2349 2019-05-08  Tom Tromey  <tom@tromey.com>
2350
2351         * auxv.c (auxv_inferior_data): Move.  Change type.
2352         (auxv_inferior_data_cleanup): Remove.
2353         (invalidate_auxv_cache_inf): Rewrite.
2354         (get_auxv_inferior_data, _initialize_auxv): Update.
2355
2356 2019-05-08  Tom Tromey  <tom@tromey.com>
2357
2358         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2359         (symfile_debug_objfile_data_key): Change type.
2360         (symfile_debug_installed, debug_qf_has_symbols)
2361         (debug_qf_find_last_source_symtab)
2362         (debug_qf_forget_cached_source_info)
2363         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2364         (debug_qf_print_stats, debug_qf_dump)
2365         (debug_qf_expand_symtabs_for_function)
2366         (debug_qf_expand_all_symtabs)
2367         (debug_qf_expand_symtabs_with_fullname)
2368         (debug_qf_map_matching_symbols)
2369         (debug_qf_expand_symtabs_matching)
2370         (debug_qf_find_pc_sect_compunit_symtab)
2371         (debug_qf_map_symbol_filenames)
2372         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2373         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2374         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2375         (debug_sym_read_linetable, debug_sym_relocate): Update.
2376         (symfile_debug_free_objfile): Remove.
2377         (install_symfile_debug_logging, _initialize_symfile_debug):
2378         Update.
2379
2380 2019-05-08  Tom Tromey  <tom@tromey.com>
2381
2382         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2383         allocate_on_obstack.
2384         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2385         (get_dwarf2_per_objfile): Update.
2386         (set_dwarf2_per_objfile): Remove.
2387         (dwarf2_has_info, dwarf2_get_section_info): Update.
2388         (dwarf2_free_objfile): Remove.
2389         (_initialize_dwarf2_read): Update.
2390
2391 2019-05-08  Tom Tromey  <tom@tromey.com>
2392
2393         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2394         initializers.
2395         <unsupported_script_warning_printed,
2396         script_not_found_warning_printed>: Now bool.
2397         (auto_load_pspace_data): Change type.
2398         (~auto_load_pspace_info): Rename from
2399         auto_load_pspace_data_cleanup.
2400         (get_auto_load_pspace_data, init_loaded_scripts_info)
2401         (clear_section_scripts, maybe_print_unsupported_script_warning)
2402         (maybe_print_script_not_found_warning, _initialize_auto_load):
2403         Update.
2404
2405 2019-05-08  Tom Tromey  <tom@tromey.com>
2406
2407         * objfiles.c (objfile_pspace_info): Add destructor and
2408         initializers.
2409         (objfiles_pspace_data): Change type.
2410         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2411         (get_objfile_pspace_data): Update.
2412         (objfiles_bfd_data): Change type.
2413         (get_objfile_bfd_data): Update.
2414         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2415
2416 2019-05-08  Tom Tromey  <tom@tromey.com>
2417
2418         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2419         Change type.
2420         (get_catch_syscall_inferior_data): Update.
2421         (catch_syscall_inferior_data_cleanup): Remove.
2422         (_initialize_break_catch_syscall): Update.
2423
2424 2019-05-08  Tom Tromey  <tom@tromey.com>
2425
2426         * inflow.c (struct terminal_info): Add destructor and
2427         initializers.
2428         (inflow_inferior_data): Change type.
2429         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2430         (get_inflow_inferior_data, inflow_inferior_exit)
2431         (swap_terminal_info, _initialize_inflow): Update.
2432
2433 2019-05-08  Tom Tromey  <tom@tromey.com>
2434
2435         * target-dcache.c (target_dcache_cleanup): Remove.
2436         (target_dcache_aspace_key): Change type.
2437         (target_dcache_init_p, target_dcache_invalidate)
2438         (target_dcache_get, target_dcache_get_or_init)
2439         (_initialize_target_dcache): Update.
2440         * dcache.h (struct dcache_deleter): New.
2441
2442 2019-05-08  Tom Tromey  <tom@tromey.com>
2443
2444         * symtab.c (struct symbol_cache): Add destructor and
2445         initializers.
2446         (symbol_cache_key): Move.  Change type.
2447         (make_symbol_cache, free_symbol_cache): Remove.
2448         (get_symbol_cache): Update.
2449         (symbol_cache_cleanup): Remove.
2450         (ALL_PSPACES, symbol_cache_flush)
2451         (maintenance_print_symbol_cache)
2452         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2453         Update.
2454
2455 2019-05-08  Tom Tromey  <tom@tromey.com>
2456
2457         * symtab.c (struct main_info): Add destructor and initializers.
2458         (main_progspace_key): Move.  Change type.
2459         (get_main_info): Update.
2460         (main_info_cleanup): Remove.
2461         (_initialize_symtab): Update.
2462
2463 2019-05-08  Tom Tromey  <tom@tromey.com>
2464
2465         * registry.h (DECLARE_REGISTRY): Define the _key class.
2466
2467 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2468
2469         * NEWS: Merge two 'New commands' sections.
2470
2471 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2472
2473         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2474         parameter and use Ada language definition instead.
2475         (ada_val_print_ptr): Remove unused language parameter.
2476         (ada_val_print_num): Remove language parameter and use Ada language
2477         definition instead.
2478         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2479         parameter.
2480         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2481         parameter and use Ada language definition instead.
2482         (ada_val_print_1): Update all ada_val_print_xxx calls.
2483         Remove language parameter.
2484         (ada_val_print): Update ada_val_print_1 call.
2485
2486 2019-05-08  Tom Tromey  <tromey@adacore.com>
2487
2488         * remote.c (remote_hw_watchpoint_limit)
2489         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2490         Now static.
2491
2492 2019-05-08  Tom Tromey  <tromey@adacore.com>
2493
2494         * maint.c (_initialize_maint_cmds): Move initialization code to
2495         remote.c.
2496         (watchdog, show_watchdog): Move to remote.c.
2497         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2498         "watchdog" static.
2499         (_initialize_remote): Move initialization code from maint.c.
2500         * defs.h (watchdog): Don't declare.
2501
2502 2019-05-08  Tom Tromey  <tromey@adacore.com>
2503
2504         * tui/tui-interp.c: Include main.h.
2505         * interps.c: Include main.h.
2506         * main.h (interpreter_p): Declare.
2507         * defs.h (interpreter_p): Don't declare.
2508
2509 2019-05-08  Tom Tromey  <tromey@adacore.com>
2510
2511         * dwarf2loc.c: Include dwarf2read.h.
2512         * defs.h (read_unsigned_leb128): Don't declare.
2513         * dwarf2read.h (read_unsigned_leb128): Declare.
2514
2515 2019-05-08  Tom Tromey  <tromey@adacore.com>
2516
2517         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2518         method.
2519
2520 2019-05-08  Tom Tromey  <tromey@adacore.com>
2521
2522         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2523         when no wrap column is set.
2524
2525 2019-05-08  Tom Tromey  <tromey@adacore.com>
2526
2527         * c-lang.c (c_get_string): Handle non-C-style arrays.
2528
2529 2019-05-08  Tom Tromey  <tromey@adacore.com>
2530
2531         * typeprint.c (print_offset_data::update): Print the bit offset,
2532         not the number of bits remaining.
2533
2534 2019-05-08  Tom Tromey  <tromey@adacore.com>
2535
2536         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2537         padding at end of comment.
2538
2539 2019-05-08  Tom Tromey  <tromey@adacore.com>
2540
2541         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2542         Compare main types.
2543
2544 2019-05-06  Tom Tromey  <tom@tromey.com>
2545
2546         * common/scoped_mmap.c: Include common-defs.h.
2547         * common/scoped_mmap.h: Don't include config.h.
2548
2549 2019-05-04  Tom Tromey  <tom@tromey.com>
2550
2551         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2552         (struct aarch64_call_info): Add initializers.
2553         <si>: Now a std::vector.
2554         (pass_on_stack, aarch64_push_dummy_call): Update.
2555
2556 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2557             Tom Tromey  <tom@tromey.com>
2558
2559         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2560         (ppc_threads): Now a std::vector.  Now static.
2561         (hwdebug_find_thread_points_by_tid)
2562         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2563         Update.
2564
2565 2019-05-04  Tom Tromey  <tom@tromey.com>
2566
2567         * arc-tdep.c (arc_tdesc_init): Return bool.
2568
2569 2019-05-04  Tom Tromey  <tom@tromey.com>
2570
2571         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2572         Use gdb_assert_not_reached.
2573
2574 2019-05-04  Tom Tromey  <tom@tromey.com>
2575
2576         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2577         "false".
2578
2579 2019-05-04  Tom Tromey  <tom@tromey.com>
2580
2581         * arc-tdep.c (arc_tdesc_init): Use bool.
2582
2583 2019-05-04  Tom Tromey  <tom@tromey.com>
2584
2585         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2586
2587 2019-05-04  Tom Tromey  <tom@tromey.com>
2588
2589         * cli/cli-cmds.c (valid_command_p): Return bool.
2590
2591 2019-05-04  Tom Tromey  <tom@tromey.com>
2592
2593         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2594         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2595
2596 2019-05-04  Raul Tambre  <raul@tambre.ee>
2597
2598         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2599         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2600         operator for comparison.
2601
2602 2019-05-04  Tom Tromey  <tom@tromey.com>
2603
2604         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2605         (lookup_partial_symbol, print_partial_symbols)
2606         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2607         (psymbol_compare): Update.
2608         (add_psymbol_to_bcache): Clear the entire psymbol.
2609         (maintenance_check_psymtabs): Update.
2610         * psympriv.h (struct partial_symbol): Don't derive from
2611         general_symbol_info.
2612         <obj_section, unrelocated_address, address,
2613         set_unrelocated_address>: Update.
2614         <ginfo>: New member.
2615         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2616         (debug_names::write_psymbols): Update.
2617
2618 2019-05-04  Tom de Vries  <tdevries@suse.de>
2619
2620         * contrib/cc-with-tweaks.sh: Support -n arg.
2621
2622 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2623
2624         * corelow.c (core_target::detach): Ensure frame cache and
2625         register caches are cleared.
2626         inferior.c (exit_inferior_1): Likewise.
2627
2628 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2629             Tom Tromey  <tom@tromey.com>
2630
2631         * dictionary.c (collate_pending_symbols_by_language): Remove
2632         "struct" from foreach.
2633         * symtab.c (lookup_global_symbol_from_objfile)
2634         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2635         foreach.
2636         * ser-tcp.c (net_open): Remove "struct" from foreach.
2637         * objfiles.c (objfile_relocate, objfile_rebase)
2638         (objfile_has_symbols): Remove "struct" from foreach.
2639         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2640         from foreach.
2641         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2642         foreach.
2643         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2644         "struct" from foreach.
2645         * ada-lang.c (create_excep_cond_exprs)
2646         (ada_exception_catchpoint_cond_string): Remove "struct" from
2647         foreach.
2648
2649 2019-05-03  Tom Tromey  <tromey@adacore.com>
2650
2651         * ada-exp.y (convert_char_literal): Check suffix of each
2652         enumerator.
2653
2654 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2655
2656         PR ada/21406:
2657         * ada-exp.y (yywrap): Don't define.
2658         * ada-lex.l (%option): Add noyywrap
2659         (yywrap): Remove.
2660
2661 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2662
2663         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2664         _WIN32_WINNT to the XP level, unless already defined to a higher
2665         level.
2666
2667         * unittests/parse-connection-spec-selftests.c:
2668         * ser-tcp.c:
2669         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2670         override.
2671
2672         * symfile.c (find_separate_debug_file): Remove colon from the
2673         drive spec of DOS/Windows file names of the target, so that the
2674         file name produced from DEBUGDIR and the target's directory will
2675         be valid on DOS/Windows systems.
2676
2677 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2678
2679         * rust-lang.c (val_print_struct): Handle printing structures
2680         containing strings.
2681
2682 2019-05-02  Tom Tromey  <tromey@adacore.com>
2683
2684         * valarith.c (_initialize_valarith): Remove.
2685
2686 2019-05-01  Tom Tromey  <tromey@adacore.com>
2687
2688         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2689         bitfields.
2690
2691 2019-05-01  Tom Tromey  <tromey@adacore.com>
2692
2693         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2694         for big-endian copies.
2695
2696 2019-04-30  Ali Tamur  <tamur@google.com>
2697         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2698         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2699         (read_3_bytes): New function.
2700
2701 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2702
2703         * windows-nat.c (main_thread_id): Delete.
2704         (handle_output_debug_string): Replace main_thread_id by
2705         current_event.dwThreadId.
2706         (fake_create_process): Likewise.
2707         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2708         Do not set main_thread_id.
2709         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2710         current_event.dwThreadId.
2711         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2712
2713 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2714
2715         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2716         Use current_event.dwThreadId instead of main_thread_id.
2717
2718 2019-04-30  Tom Tromey  <tromey@adacore.com>
2719
2720         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2721         (create_excep_cond_exprs): Iterate over program spaces.
2722         (ada_exception_catchpoint_cond_string): Examine all minimal
2723         symbols for exception types.
2724
2725 2019-04-30  Tom Tromey  <tromey@adacore.com>
2726
2727         PR c++/24470:
2728         * dwarf2read.c (process_structure_scope): Handle case where type
2729         has template parameters but no symbol was created.
2730
2731 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2732             Chris January  <chris.january@arm.com>
2733
2734         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2735         qualifier.
2736         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2737
2738 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2739
2740         * f-typeprint.c (f_print_type): Update rules for printing
2741         whitespace.
2742         (f_type_print_varspec_suffix): Likewise.
2743
2744 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2745             Chris January  <chris.january@arm.com>
2746
2747         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2748         function arguments.
2749
2750 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2751
2752         * f-lang.c (build_fortran_types): Change name of void type to
2753         lower case.
2754         * f-typeprint.c (f_type_print_base): Print the name of the void
2755         type, rather than a fixed string.
2756         * f-valprint.c (f_decorations): Use lower case void string.
2757
2758 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2759             Chris January  <chris.january@arm.com>
2760
2761         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2762         types for Fortran.
2763
2764 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2765             Chris January  <chris.january@arm.com>
2766             David Lecomber  <david.lecomber@arm.com>
2767
2768         * f-exp.y (BINOP_INTRINSIC): New token.
2769         (exp): New parser rule handling BINOP_INTRINSIC.
2770         (f77_keywords): Add new builtin procedures.
2771         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2772         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2773         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2774         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2775         (print_unop_subexp_f): New function.
2776         (print_binop_subexp_f): New function.
2777         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2778         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2779         (dump_subexp_body_f): Likewise.
2780         (operator_check_f): Likewise.
2781         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2782         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2783
2784 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2785
2786         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2787         UNOP_KIND.
2788         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2789         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2790         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2791         (operator_length_f): New fuction.
2792         (print_subexp_f): New function.
2793         (op_name_f): New function.
2794         (dump_subexp_body_f): New function.
2795         (operator_check_f): New function.
2796         (exp_descriptor_f): Replace standard expression handling functions
2797         with new functions.
2798         * gdb/fortran-operator.def: New file.
2799         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2800         * gdb/std-operator.def: Remove UNOP_KIND.
2801
2802 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2803
2804         * std-operator.def: Remove unbalanced, stray double quote
2805         character.
2806
2807 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2808             Chris January  <chris.january@arm.com>
2809             Daniel Everett  <daniel.everett@arm.com>
2810             Nick Forrington  <nick.forrington@arm.com>
2811             Richard Bunt  <richard.bunt@arm.com>
2812
2813         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2814         of depth when printing anonymous structs or unions.
2815         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2816         Don't print either the top-level value, or the children if the
2817         max-depth is exceeded.
2818         (ppscm_print_children): When printing the key of a map, allow one
2819         extra level of depth.
2820         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2821         print either the top-level value, or the children if the max-depth
2822         is exceeded.
2823         (print_children): When printing the key of a map, allow one extra
2824         level of depth.
2825         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2826         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2827         (user_print_options): Initialise max_depth field.
2828         (val_print_scalar_or_string_type_p): New function.
2829         (val_print): Check to see if the max depth has been reached.
2830         (val_print_check_max_depth): Define new function.
2831         (show_print_max_depth): New function.
2832         (_initialize_valprint): Add 'print max-depth' option.
2833         * valprint.h (struct value_print_options) <max_depth>: New field.
2834         (val_print_check_max_depth): Declare new function.
2835         * NEWS: Document new feature.
2836
2837 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2838
2839         * ada-lang.c (ada_language_defn): Initialise new field.
2840         * c-lang.c (c_is_string_type_p): New function.
2841         (c_language_defn): Initialise new field.
2842         (cplus_language_defn): Initialise new field.
2843         (asm_language_defn): Initialise new field.
2844         (minimal_language_defn): Initialise new field.
2845         * c-lang.h (c_is_string_type_p): Declare new function.
2846         * d-lang.c (d_language_defn): Initialise new field.
2847         * f-lang.c (f_is_string_type_p): New function.
2848         (f_language_defn): Initialise new field.
2849         * go-lang.c (go_is_string_type_p): New function.
2850         (go_language_defn): Initialise new field.
2851         * language.c (default_is_string_type_p): New function.
2852         (unknown_language_defn): Initialise new field.
2853         (auto_language_defn): Initialise new field.
2854         * language.h (struct language_defn) <la_is_string_type_p>: New
2855         member variable.
2856         (default_is_string_type_p): Declare new function.
2857         * m2-lang.c (m2_language_defn): Initialise new field.
2858         * objc-lang.c (objc_language_defn): Initialise new field.
2859         * opencl-lang.c (opencl_language_defn): Initialise new field.
2860         * p-lang.c (pascal_is_string_type_p): New function.
2861         (pascal_language_defn): Initialise new field.
2862         * rust-lang.c (rust_is_string_type_p): New function.
2863         (rust_language_defn): Initialise new field.
2864
2865 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2866
2867         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2868         New field.
2869         * ada-lang.c (ada_language_defn): Initialise new field.
2870         * c-lang.c (c_language_defn): Likewise.
2871         (cplus_language_defn): Likewise.
2872         (asm_language_defn): Likewise.
2873         (minimal_language_defn): Likewise.
2874         * d-lang.c (d_language_defn): Likewise.
2875         * f-lang.c (f_language_defn): Likewise.
2876         * go-lang.c (go_language_defn): Likewise.
2877         * language.c (unknown_language_defn): Likewise.
2878         (auto_language_defn): Likewise.
2879         * m2-lang.c (m2_language_defn): Likewise.
2880         * objc-lang.c (objc_language_defn): Likewise.
2881         * opencl-lang.c (opencl_language_defn): Likewise.
2882         * p-lang.c (pascal_language_defn): Likewise.
2883         * rust-lang.c (rust_language_defn): Likewise.
2884
2885 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2886
2887         * ada-lang.c (ada_is_character_type): Change return type to bool.
2888         (ada_is_string_type): Likewise.
2889         * ada-lang.h (ada_is_character_type): Update declaration
2890         (ada_is_string_type): Likewise.
2891
2892 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2893
2894         Support style in 'frame|thread apply'
2895
2896         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2897         * record.c (record_start, record_stop): Update callers of
2898         execute_command_to_string with false.
2899         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2900         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2901         methods.
2902         (class string_file): New constructor with term_out parameter.
2903         Override methods term_out and can_emit_style_escape.  New member
2904         term_out.
2905         (class stdio_file): Override can_emit_style_escape.
2906         (class tee_file): Override term_out and can_emit_style_escape.
2907         * utils.h (can_emit_style_escape): Remove.
2908         * utils.c (can_emit_style_escape): Likewise.
2909         Update all callers of can_emit_style_escape (SOMESTREAM) to
2910         SOMESTREAM->can_emit_style_escape.
2911         * source-cache.c (source_cache::get_source_lines): Likewise.
2912         * stack.c (frame_apply_command_count): Call execute_command_to_string
2913         passing the term_out characteristic of the current gdb_stdout.
2914         * thread.c (thr_try_catch_cmd): Likewise.
2915         * top.c (execute_command_to_string): pass term_out parameter
2916         to construct the string_file for the command output.
2917         * ui-file.c (term_cli_styling): New function (most code moved
2918         from utils.c can_emit_style_escape).
2919         (string_file::string_file, string_file::can_emit_style_escape,
2920         stdio_file::can_emit_style_escape, tee_file::term_out,
2921         tee_file::can_emit_style_escape): New functions.
2922
2923 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2924
2925         * NEWS: Mention the new set|show may-call-functions.
2926         * infcall.c (may_call_functions_p): New variable.
2927         (show_may_call_functions_p): New function.
2928         (call_function_by_hand_dummy): Throws an error if not
2929         may-call-functions.
2930         (_initialize_infcall): Call add_setshow_boolean_cmd for
2931         may-call-functions.
2932
2933 2019-04-25  Keith Seitz  <keiths@redhat.com>
2934
2935         PR c++/24367
2936         * cp-support.c (inspect_type): Don't attempt substitutions
2937         of symbol with the same name.
2938
2939 2019-04-25  Tom Tromey  <tromey@adacore.com>
2940
2941         PR gdb/24475:
2942         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2943         static.
2944
2945 2019-04-25  Tom Tromey  <tromey@adacore.com>
2946
2947         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2948         rvalue reference.
2949         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2950         (gdb_xml_parser::parse): Use std::move.
2951         * python/python-internal.h (gdbpy_convert_exception): Take a const
2952         reference.
2953         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2954         std::move.
2955         * python/py-utils.c (gdbpy_convert_exception): Take a const
2956         reference.
2957         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2958         Use std::move.
2959         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2960         Use std::move.
2961         * mi/mi-main.c (mi_print_exception): Take a const reference.
2962         * main.c (handle_command_errors): Take a const reference.
2963         * linespec.c (parse_linespec): Use std::move.
2964         * infcall.c (run_inferior_call): Use std::move.
2965         (call_function_by_hand_dummy): Use std::move.
2966         * exec.c (try_open_exec_file): Use std::move.
2967         * exceptions.h (exception_print, exception_fprintf)
2968         (exception_print_same): Update.
2969         * exceptions.c (print_exception, exception_print)
2970         (exception_fprintf, exception_print_same): Change parameters to
2971         const reference.
2972         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2973         * common/new-op.c: Use std::move.
2974         * common/common-exceptions.h (struct gdb_exception): Add move
2975         constructor.
2976         (struct gdb_exception_error, struct gdb_exception_quit, struct
2977         gdb_quit_bad_alloc): Change constructor to move constructor.
2978         (throw_exception): Change parameter to rvalue reference.
2979         * common/common-exceptions.c (throw_exception): Take rvalue
2980         reference.
2981         * cli/cli-interp.c (safe_execute_command): Use std::move.
2982         * breakpoint.c (insert_bp_location, location_to_sals): Use
2983         std::move.
2984
2985 2019-04-25  Tom Tromey  <tromey@adacore.com>
2986
2987         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2988         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2989         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2990         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2991         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2992         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2993         guile/scm-value.c: Use unpack.
2994         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2995         gdbscm_gdb_exception.
2996         (gdbscm_throw_gdb_exception): Likewise.
2997         (struct gdbscm_gdb_exception): New.
2998         (unpack): New function.
2999         (gdbscm_wrap): Use unpack.
3000
3001 2019-04-25  Tom Tromey  <tromey@adacore.com>
3002
3003         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3004         (gdb_rl_callback_handler): Use std::move.
3005         * common/common-exceptions.h (struct gdb_exception): Add move
3006         assignment operator.
3007         (throw_exception_sjlj): Change "exception" to const reference.
3008         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3009         (throw_exception_sjlj): Change "exception" to const reference.
3010
3011 2019-04-25  Tom Tromey  <tromey@adacore.com>
3012
3013         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3014         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3015         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3016         Update.
3017         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3018         Update.
3019         * mi/mi-interp.c (mi_interp::exec): Update.
3020         * linespec.c (parse_linespec): Update.
3021         * infcall.c (run_inferior_call): Update.
3022         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3023         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3024         (gdbscm_lookup_global_symbol): Update.
3025         * guile/scm-param.c (gdbscm_parameter_value): Update.
3026         * guile/scm-frame.c (gdbscm_frame_read_register)
3027         (gdbscm_frame_read_var): Update.
3028         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3029         * exec.c (try_open_exec_file): Update.
3030         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3031         (gdb_rl_callback_handler): Update.
3032         * common/common-exceptions.h (exception_none): Don't declare.
3033         * common/common-exceptions.c (exception_none): Don't define.
3034         (struct catcher) <exception>: Update.
3035         * cli/cli-interp.c (safe_execute_command): Update.
3036         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3037
3038 2019-04-25  Ali Tamur  <tamur@google.com>
3039
3040         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3041         (read_attribute_value): Likewise.
3042         (dwarf2_read_addr_index): Update comment.
3043         (read_str_index): Add DW_FORM_strx.
3044         (dwarf2_string_attr): Likewise.
3045         (dwarf2_const_value_attr): Likewise.
3046         (dump_die_shallow): Likewise.
3047         (dwarf2_fetch_constant_bytes): Likewise.
3048         (skip_form_bytes): Likewise.
3049         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3050
3051 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3052
3053         PR corefiles/11608
3054         PR corefiles/18187
3055         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3056         OFFSET.  Verify if current mapping contains an ELF header.
3057         (linux_find_memory_regions_full): Adjust call to
3058         dump_mapping_p.
3059
3060 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3061             Kang Li <kanglictf@gmail.com>
3062
3063         PR gdb/21600
3064
3065         * dwarf2-frame.c (read_initial_length): Be consistent about using
3066         unsigned representation of length.
3067         (decode_frame_entry_1): Likewise.  Check for wraparound of
3068         end pointer as well as buffer overflow.
3069
3070 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3071
3072         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3073         "vq".
3074
3075 2019-04-24  Tom Tromey  <tromey@adacore.com>
3076
3077         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3078
3079 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3080
3081         * s12z-tdep.c (s12z_unwind_pc): Delete.
3082         (s12z_unwind_sp): Delete.
3083         (s12z_gdbarch_init): Don't register deleted functions with
3084         gdbarch.
3085
3086 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3087
3088         * rl78-tdep.c (rl78_unwind_sp): Delete.
3089         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3090
3091 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3092
3093         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3094         (xstormy16_unwind_pc): Delete.
3095         (xstormy16_dummy_id): Delete.
3096         (xstormy16_gdbarch_init): Don't register deleted functions with
3097         gdbarch.
3098
3099 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3100
3101         * vax-tdep.c (vax_unwind_pc): Delete.
3102         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3103
3104 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3105
3106         * v850-tdep.c (v850_unwind_sp): Delete.
3107         (v850_unwind_pc): Delete.
3108         (v850_dummy_id): Delete.
3109         (v850_gdbarch_init): Don't register deleted functions with
3110         gdbarch.
3111
3112 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3113
3114         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3115         (tilegx_unwind_pc): Delete.
3116         (tilegx_unwind_dummy_id): Delete.
3117         (tilegx_gdbarch_init): Don't register deleted functions with
3118         gdbarch.
3119
3120 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3121
3122         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3123         (tic6x_dummy_id): Delete.
3124         (tic6x_gdbarch_init): Don't register deleted functions with
3125         gdbarch.
3126
3127 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3128
3129         * sparc-tdep.c (sparc_unwind_pc): Delete.
3130         (sparc32_gdbarch_init): Don't register deleted function with
3131         gdbarch.
3132
3133 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3134
3135         * sh-tdep.c (sh_unwind_sp): Delete.
3136         (sh_unwind_pc): Delete.
3137         (sh_dummy_id): Delete.
3138         (sh_gdbarch_init): Don't register deleted functions with
3139         gdbarch.
3140
3141 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3142
3143         * score-tdep.c (score_unwind_sp): Delete.
3144         (score_unwind_pc): Delete.
3145         (score_dummy_id): Delete.
3146         (score_gdbarch_init): Don't register deleted functions with
3147         gdbarch.
3148
3149 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3150
3151         * rx-tdep.c (rx_unwind_pc): Delete.
3152         (rx_unwind_sp): Delete.
3153         (rx_dummy_id): Delete.
3154         (rx_gdbarch_init): Don't register deleted functions with
3155         gdbarch.  Update comment.
3156
3157 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3158
3159         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3160         (rs6000_dummy_id): Delete.
3161         (rs6000_gdbarch_init): Don't register deleted functions with
3162         gdbarch.
3163
3164 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3165
3166         * or1k-tdep.c (or1k_dummy_id): Delete.
3167         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3168
3169 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3170
3171         * nios2-tdep.c (nios2_dummy_id): Delete.
3172         (nios2_unwind_sp): Delete.
3173         (nios2_gdbarch_init): Don't register deleted functions with
3174         gdbarch.
3175
3176 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3177
3178         * nds32-tdep.c (nds32_dummy_id): Delete.
3179         (nds32_unwind_pc): Delete.
3180         (nds32_unwind_sp): Delete.
3181         (nds32_gdbarch_init): Don't register deleted functions with
3182         gdbarch.
3183
3184 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3185
3186         * msp430-tdep.c (msp430_unwind_pc): Delete.
3187         (msp430_unwind_sp): Delete.
3188         (msp430_dummy_id): Delete.
3189         (msp430_gdbarch_init): Don't register deleted functions with
3190         gdbarch.
3191
3192 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3193
3194         * moxie-tdep.c (moxie_unwind_sp): Delete.
3195         (moxie_unwind_pc): Delete.
3196         (moxie_dummy_id): Delete.
3197         (moxie_gdbarch_init): Don't register deleted functions with
3198         gdbarch.
3199
3200 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3201
3202         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3203         (mn10300_unwind_pc): Delete.
3204         (mn10300_unwind_sp): Delete.
3205         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3206         mn10300_unwind_sp.
3207         (mn10300_frame_unwind_init): Don't register deleted functions with
3208         gdbarch.
3209
3210 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3211
3212         * mep-tdep.c (mep_unwind_pc): Delete.
3213         (mep_unwind_sp): Delete.
3214         (mep_dummy_id): Delete.
3215         (mep_gdbarch_init): Don't register deleted functions with
3216         gdbarch.
3217
3218 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3219
3220         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3221         (m68hc11_unwind_sp): Delete.
3222         (m68hc11_gdbarch_init): Don't register deleted functions with
3223         gdbarch.
3224
3225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3226
3227         * m32r-tdep.c (m32r_unwind_sp): Delete.
3228         (m32r_unwind_pc): Delete.
3229         (m32r_dummy_id): Delete.
3230         (m32r_gdbarch_init): Don't register deleted functions with
3231         gdbarch.
3232
3233 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3234
3235         * m32c-tdep.c (m32c_unwind_pc): Delete.
3236         (m32c_unwind_sp): Delete.
3237         (m32c_dummy_id): Delete.
3238         (m32c_gdbarch_init): Don't register deleted functions with
3239         gdbarch.
3240
3241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3242
3243         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3244         (lm32_unwind_pc): Delete.
3245         (lm32_dummy_id): Delete.
3246         (lm32_gdbarch_init): Don't register deleted functions with
3247         gdbarch.
3248
3249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3250
3251         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3252         (iq2000_unwind_pc): Delete.
3253         (iq2000_dummy_id): Delete.
3254         (iq2000_gdbarch_init): Don't register deleted functions with
3255         gdbarch.
3256
3257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3258
3259         * nds32-tdep.c (nds32_type_align): Delete.
3260         (nds32_push_dummy_call): Use type_align instead.
3261
3262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3263
3264         * arm-tdep.c (arm_type_align): Only handle vector override case.
3265         (arm_push_dummy_call): Use type_align.
3266         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3267
3268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3269
3270         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3271         case.
3272         (pass_on_stack): Use type_align.
3273         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3274         function.
3275
3276 2019-04-23  Tom Tromey  <tromey@adacore.com>
3277
3278         * dwarf2read.c (line_header::file_name_at): Remove unused
3279         overload.
3280
3281 2019-04-23  Tom de Vries  <tdevries@suse.de>
3282
3283         PR gdb/24438
3284         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3285         invocation.
3286
3287
3288 2019-03-27  Ali Tamur  <tamur@google.com>
3289
3290         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3291         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3292         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3293         (dwarf_expr_context::get_addr_index): Likewise
3294         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3295         (symbol_needs_eval_context::get_addr_index): Likewise
3296         (disassemble_dwarf_expression): Add DW_OP_addrx
3297         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3298         (read_cutu_die_from_dwo): Update comment
3299         (skip_one_die): Add DW_FORM_addrx
3300         (read_attribute_value): Likewise
3301         (var_decode_location): Add DW_OP_addrx
3302         (dwarf2_const_value_attr): Add DW_FORM_addrx
3303         (dump_die_shallow): Likewise
3304         (dwarf2_fetch_constant_bytes): Likewise
3305         (decode_locdesc): Add DW_OP_addrx
3306         (skip_form_bytes): Add DW_FORM_addrx
3307
3308 2019-04-22  Ali Tamur  <tamur@google.com>
3309
3310         * MAINTAINERS (Write After Approval): Add self.
3311
3312 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3313
3314         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3315         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3316         (open_symbol_file_object): Likewise.
3317         (svr4_default_sos): Add info parameter.
3318         (svr4_read_so_list): Likewise.
3319         (svr4_current_sos_direct): Adjust functions calls to pass down
3320         info.
3321         (svr4_current_sos_1): Add info parameter.
3322         (svr4_current_sos): Call get_svr4_info, pass info down to
3323         svr4_current_sos_1.
3324         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3325         get_svr4_info.
3326         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3327         get_svr4_info.
3328         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3329         to get_svr4_info.
3330         (probes_table_remove_objfile_probes): Likewise.
3331         (register_solib_event_probe): Add info parameter.
3332         (solist_update_incremental): Pass info parameter down to
3333         svr4_read_so_list.
3334         (disable_probes_interface): Add info parameter.
3335         (svr4_handle_solib_event): Pass current_program_space to
3336         get_svr4_info.  Adjust disable_probes_interface cleanup.
3337         (svr4_create_probe_breakpoints): Add info parameter, pass it
3338         down to register_solib_event_probe.
3339         (svr4_create_solib_event_breakpoints): Add info parameter,
3340         pass it down to svr4_create_probe_breakpoints.
3341         (enable_break): Pass info down to
3342         svr4_create_solib_event_breakpoints.
3343         (svr4_solib_create_inferior_hook): Pass current_program_space to
3344         get_svr4_info.
3345         (svr4_clear_solib): Likewise.
3346
3347 2019-04-22  Pedro Alves  <palves@redhat.com>
3348
3349         * solib-svr4.c (svr4_free_objfile_observer): New.
3350         (probe_and_action::objfile): New field.
3351         (probes_table_htab_remove_objfile_probes)
3352         (probes_table_remove_objfile_probes): New functions.
3353         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3354         in the new probe_and_action.  Don't store the probe in 'lookup'.
3355         (svr4_create_probe_breakpoints): Pass objfile to
3356         register_solib_event_probe.
3357         (_initialize_svr4_solib): Register a free_objfile observer.
3358
3359 2019-04-19  Tom Tromey  <tom@tromey.com>
3360
3361         * common/queue.h: Remove.
3362
3363 2019-04-19  Tom Tromey  <tom@tromey.com>
3364
3365         * event-loop.c: Don't include "common/queue.h".
3366
3367 2019-04-19  Tom Tromey  <tom@tromey.com>
3368
3369         * remote.c (remote_target): Use delete.
3370         * remote-notif.h: Include <list>, not "common/queue.h".
3371         (notif_client_p): Remove typedef.
3372         (remote_notif_state): Add constructor, destructor, initializer.
3373         <notif_queue>: Now a std::list.
3374         (remote_notif_state_xfree): Don't declare.
3375         * remote-notif.c (remote_notif_process, handle_notification)
3376         (remote_notif_state_allocate): Update.
3377         (~remote_notif_state): Rename from remote_notif_state_xfree.
3378
3379 2019-04-19  Tom Tromey  <tom@tromey.com>
3380
3381         * symfile.c (reread_symbols): Update.
3382         * objfiles.c (objfile_register_static_link)
3383         (objfile_lookup_static_link): Update
3384         (~objfile) Don't delete static_links.
3385         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3386
3387 2019-04-19  Tom Tromey  <tom@tromey.com>
3388
3389         * type-stack.h (struct type_stack) <insert>: Constify string.
3390         * type-stack.c (type_stack::insert): Constify string.
3391         * gdbtypes.h (lookup_template_type): Update.
3392         (address_space_name_to_int): Update.
3393         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3394         const.
3395         (lookup_template_type): Make name const.
3396         * c-exp.y: Update rules.
3397         (lex_one_token, classify_name, classify_inner_name)
3398         (c_print_token): Update.
3399         * p-exp.y: Update rules.
3400         (yylex): Update.
3401         * f-exp.y: Update rules.
3402         (yylex): Update.
3403         * d-exp.y: Update rules.
3404         (lex_one_token, classify_name, classify_inner_name): Update.
3405         * parse.c (write_dollar_variable, copy_name): Return std::string.
3406         * parser-defs.h (copy_name): Change return type.
3407         * m2-exp.y: Update rules.
3408         (yylex): Update.
3409         * go-exp.y (lex_one_token): Update.
3410         Update rules.
3411         (classify_unsafe_function, classify_packaged_name)
3412         (classify_name, yylex): Update.
3413
3414 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3415
3416         * configure.ac: add --enable-source-highlight switch.
3417         * configure: Regenerate.
3418         * top.c (print_gdb_version): plumb --enable-source-highlight
3419         status to "show configuration".
3420
3421 2019-04-19  Tom Tromey  <tromey@adacore.com>
3422
3423         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3424         Check ADA_TYPE_P.
3425         (empty_record, ada_template_to_fixed_record_type_1)
3426         (template_to_static_fixed_type)
3427         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3428         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3429         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3430         macros.
3431
3432 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3433
3434         PR symtab/24423:
3435         * source.c (print_source_lines_base): Advance "iter" when a
3436         control character is seen.
3437
3438 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3439
3440         * inferior.h (struct infcall_suspend_state_deleter):
3441         Catch exception in destructor to avoid crash.
3442
3443 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3444
3445         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3446         close to the add_com "shell".
3447
3448 2019-04-18  Tom Tromey  <tromey@adacore.com>
3449
3450         * process-stratum-target.h (class process_stratum_target)
3451         <stratum>: Add "final".
3452
3453 2019-04-17  Tom Tromey  <tromey@adacore.com>
3454
3455         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3456         against nullptr before use.
3457
3458 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3459
3460         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3461
3462 2019-04-17  Jim Wilson  <jimw@sifive.com>
3463             Andrew Burgess  <andrew.burgess@embecosm.com>
3464
3465         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3466         code read might fail, assume 4-byte breakpoint in that case.
3467
3468 2019-04-15  Leszek Swirski  <leszeks@google.com>
3469
3470         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3471         rather than a hand-rolled POD check when checking for forced MEMORY
3472         classification.
3473
3474 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3475
3476         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3477         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3478         function.
3479         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3480         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3481         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3482         declaration.
3483
3484 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3485
3486         * aarch64-linux-nat.c
3487         (aarch64_linux_nat_target::thread_architecture): Add override.
3488         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3489         each VQ.
3490
3491 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3492
3493         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3494
3495 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3496
3497         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3498         target types of size 96-bits, add some additional comments, and
3499         check that the builtin type we found was the correct size.
3500
3501 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3502
3503         * utils.c (prompt_for_continue): Don't restore the styling at the
3504         end, as applied_style has the wrong value.  This fixes styling in
3505         long lists of file names that are interrupted by the "Continue?"
3506         prompt.
3507
3508 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3509
3510         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3511         * c-lang.c (c_language_defn): Likewise.
3512         (cplus_language_defn): Likewise.
3513         (asm_language_defn): Likewise.
3514         (minimal_language_defn): Likewise.
3515         * d-lang.c (d_language_defn): Likewise.
3516         * f-lang.c (f_language_defn): Likewise.
3517         * go-lang.c (go_language_defn): Likewise.
3518         * language.c (unknown_language_defn): Likewise.
3519         (auto_language_defn): Likewise.
3520         * language.h (struct language_defn): Remove la_magic field.
3521         (LANG_MAGIC): Delete.
3522         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3523         * objc-lang.c (objc_language_defn): Likewise.
3524         * opencl-lang.c (opencl_language_defn): Likewise.
3525         * p-lang.c (pascal_language_defn): Likewise.
3526         * rust-lang.c (rust_language_defn): Likewise.
3527
3528 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3529
3530         * riscv-tdep.c (riscv_type_align): New function.
3531         (riscv_type_alignment): Delete.
3532         (riscv_arg_location): Use 'type_align'.
3533         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3534
3535 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3536
3537         * gdbtypes.c (type_align): A struct with no non-static fields also
3538         has alignment of 1.
3539
3540 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3541
3542         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3543         component to 0.
3544         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3545         member.
3546         (riscv_struct_info::analyse): New implementation using new
3547         analyse_inner member function.
3548         (riscv_struct_info::field_offset): New member function.
3549         (riscv_struct_info::m_offsets): New member variable.
3550         (riscv_struct_info::analyse_inner): New private member function,
3551         takes the old implementation of riscv_struct_info::analyse but
3552         extended to track field offsets.
3553         (riscv_call_arg_struct): Update the struct folding special cases
3554         to handle cases where empty C++ structs, which are non-zero
3555         length, are found.
3556         (riscv_arg_location): Initialise the length of each location, a
3557         non-zero length now indicates the location is in use.
3558         (riscv_push_dummy_call): Allow for the first location having a
3559         non-zero offset when setting up arguments.
3560         (riscv_return_value): Likewise, but for return values.
3561
3562 2019-04-11  Tom Tromey  <tromey@adacore.com>
3563
3564         * utils.c (internal_vproblem): Make "msg" const.
3565
3566 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3567
3568         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3569         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3570         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3571         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3572
3573 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3574
3575         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3576         function.
3577         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3578         of amd64_collect_native_gregset.
3579         (amd64_linux_nat_target::store_registers): Likewise.
3580
3581 2019-04-10  Tom Tromey  <tom@tromey.com>
3582
3583         * symtab.c (lookup_global_symbol_from_objfile)
3584         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3585         * objfiles.h (class separate_debug_iterator): New.
3586         (class separate_debug_range): New.
3587         (struct objfile) <separate_debug_objfiles>: New method.
3588         (objfile_separate_debug_iterate): Don't declare.
3589         * objfiles.c (separate_debug_iterator::operator++): Rename from
3590         objfile_separate_debug_iterate.
3591         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3592         iterator.
3593         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3594         iterator.
3595
3596 2019-04-10  Tom Tromey  <tom@tromey.com>
3597
3598         * symfile.c (reread_symbols): Remove old comment.
3599         * objfiles.c (free_all_objfiles): Fix a typo.
3600
3601 2019-04-10  Tom Tromey  <tom@tromey.com>
3602
3603         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3604         * minsyms.c (lookup_minimal_symbol): Use foreach.
3605         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3606         (lookup_minimal_symbol_solib_trampoline): Likewise.
3607         * symfile.c (reread_symbols): Use foreach.
3608
3609 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3610             Tom Tromey  <tromey@adacore.com>
3611
3612         PR rust/24414:
3613         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3614         (rust_lex_int_test): Change "value" to be LONGEST.
3615         (rust_lex_tests): Add test for long integer literal.
3616
3617 2019-04-09  Tom Tromey  <tromey@adacore.com>
3618
3619         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3620         to bool.
3621         (extended_remote_target::attach): Update.
3622         (remote_target::remote_notice_new_inferior): Update.
3623         (remote_target::add_current_inferior_and_thread): Update.
3624         * inferior.c (exit_inferior_1): Use "false".
3625         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3626
3627 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3628
3629         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3630         the "start" command.
3631
3632 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3633
3634         * python/py-inferior.c (infpy_thread_from_thread_handle):
3635         Adjust comments to reflect renaming of thread_from_thread_handle
3636         to thread_from_handle.  Adjust keywords.  Fix type error message.
3637         (inferior_object_methods): Add thread_from_handle.  Retain
3638         thread_from_thread_handle, but mark it as deprecated.
3639
3640 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3641
3642         * gdbthread.h (find_thread_by_handle): Revise declaration.
3643         * thread.c (find_thread_by_handle): Likewise.  Adjust
3644         implementation too.
3645         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3646         support for buffer objects as handles.
3647
3648 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3649
3650         * python/py-infthread.c (thpy_thread_handle): New function.
3651         (thread_object_methods): Register thpy_thread_handle.
3652
3653 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3654
3655         * gdbthread.h (thread_to_thread_handle): Declare.
3656         * thread.c (gdbtypes.h): Include.
3657         (thread_to_thread_handle): New function.
3658
3659         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3660         (target_thread_info_to_thread_handle): Declare.
3661         * target.c (target_thread_info_to_thread_handle): New function.
3662         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3663         * target-delegates.c: Regenerate.
3664
3665         * linux-thread-db.c (class thread_db_target): Add method
3666         thread_info_to_thread_handle.
3667         (thread_db_target::thread_info_to_thread_handle): Define.
3668         * remote.c (class remote_target): Add new method
3669         thread_info_to_thread_handle.
3670         (remote_target::thread_info_to_thread_handle): Define.
3671
3672 2019-04-08  Pedro Alves  <palves@redhat.com>
3673
3674         * common/common-exceptions.c (throw_exception): Don't create
3675         named object to throw; throw directly.
3676         (throw_it): Likewise.  Don't initialize gdb_exception::message
3677         here, with new; pass FMT and AP to the ctor instead.
3678         * common/common-exceptions.h: Include <string>.
3679         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3680         const char *, va_list)): New ctor.  Use std::make_shared.
3681         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3682         errors)): Delete.
3683         (gdb_exception_error::gdb_exception_error(enum errors, const char
3684         *, va_list)): New.
3685         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3686         Add assertion.
3687         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3688         errors)): Delete.
3689         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3690         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3691         Add assertion.
3692
3693 2019-04-08  Tom Tromey  <tom@tromey.com>
3694
3695         * valops.c (value_rtti_indirect_type): Replace throw_exception
3696         with throw.
3697         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3698         with throw.
3699         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3700         throw.
3701         * target.c (target_translate_tls_address): Replace throw_exception
3702         with throw.
3703         * stack.c (frame_apply_command_count): Replace throw_exception
3704         with throw.
3705         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3706         throw.
3707         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3708         with throw.
3709         * rs6000-tdep.c (rs6000_frame_cache)
3710         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3711         * remote.c: Replace throw_exception with throw.
3712         * record-full.c (record_full_message, record_full_wait_1)
3713         (record_full_restore): Replace throw_exception with throw.
3714         * record-btrace.c:
3715         (get_thread_current_frame_id, record_btrace_start_replaying)
3716         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3717         (cmd_record_btrace_start): Replace throw_exception with throw.
3718         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3719         throw.
3720         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3721         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3722         * linespec.c:
3723         (find_linespec_symbols): Replace throw_exception with throw.
3724         * infrun.c (displaced_step_prepare, resume): Replace
3725         throw_exception with throw.
3726         * infcmd.c (post_create_inferior): Replace throw_exception with
3727         throw.
3728         * inf-loop.c (inferior_event_handler): Replace throw_exception
3729         with throw.
3730         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3731         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3732         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3733         (get_prev_frame_always, get_frame_pc_if_available)
3734         (get_frame_address_in_block_if_available, get_frame_language):
3735         Replace throw_exception with throw.
3736         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3737         throw_exception with throw.
3738         * eval.c (fetch_subexp_value, evaluate_var_value)
3739         (evaluate_funcall, evaluate_subexp_standard): Replace
3740         throw_exception with throw.
3741         * dwarf2loc.c (call_site_find_chain)
3742         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3743         Replace throw_exception with throw.
3744         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3745         with throw.
3746         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3747         throw.
3748         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3749         * completer.c (complete_line_internal): Replace throw_exception
3750         with throw.
3751         * compile/compile-object-run.c (compile_object_run): Replace
3752         throw_exception with throw.
3753         * cli/cli-script.c (process_next_line): Replace throw_exception
3754         with throw.
3755         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3756         (btrace_enable, btrace_maint_update_pt_packets): Replace
3757         throw_exception with throw.
3758         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3759         throw_exception with throw.
3760         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3761         throw_exception with throw.
3762         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3763         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3764         * aarch64-tdep.c (aarch64_make_prologue_cache)
3765         (aarch64_make_stub_cache): Replace throw_exception with throw.
3766
3767 2019-04-08  Tom Tromey  <tom@tromey.com>
3768
3769         * common/common-exceptions.c (throw_exception): Rename from
3770         throw_exception_cxx.  Remove old copy.  Make argument const.
3771         (throw_it): Create and throw exception objects directly.
3772         * common/common-exceptions.h (throw_exception): Make argument
3773         const.
3774         (struct gdb_exception_error): Add constructor.
3775         (struct gdb_exception_quit): Add constructor.
3776
3777 2019-04-08  Tom Tromey  <tom@tromey.com>
3778
3779         * common/common-exceptions.h (exception_rethrow): Don't declare.
3780         (TRY_SJLJ): Update comment.
3781         (TRY, CATCH, END_CATCH): Remove.
3782         * common/common-exceptions.c (exception_rethrow): Remove.
3783
3784 2019-04-08  Tom Tromey  <tom@tromey.com>
3785
3786         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3787         Remove.
3788         (gdb_exception_error): Rename from
3789         gdb_exception_RETURN_MASK_ERROR.
3790         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3791         (gdb_quit_bad_alloc): Update.
3792         * aarch64-tdep.c: Update.
3793         * ada-lang.c: Update.
3794         * ada-typeprint.c: Update.
3795         * ada-valprint.c: Update.
3796         * amd64-tdep.c: Update.
3797         * arch-utils.c: Update.
3798         * break-catch-throw.c: Update.
3799         * breakpoint.c: Update.
3800         * btrace.c: Update.
3801         * c-varobj.c: Update.
3802         * cli/cli-cmds.c: Update.
3803         * cli/cli-interp.c: Update.
3804         * cli/cli-script.c: Update.
3805         * common/common-exceptions.c: Update.
3806         * common/new-op.c: Update.
3807         * common/selftest.c: Update.
3808         * compile/compile-c-symbols.c: Update.
3809         * compile/compile-cplus-symbols.c: Update.
3810         * compile/compile-object-load.c: Update.
3811         * compile/compile-object-run.c: Update.
3812         * completer.c: Update.
3813         * corelow.c: Update.
3814         * cp-abi.c: Update.
3815         * cp-support.c: Update.
3816         * cp-valprint.c: Update.
3817         * darwin-nat.c: Update.
3818         * disasm-selftests.c: Update.
3819         * dtrace-probe.c: Update.
3820         * dwarf-index-cache.c: Update.
3821         * dwarf-index-write.c: Update.
3822         * dwarf2-frame-tailcall.c: Update.
3823         * dwarf2-frame.c: Update.
3824         * dwarf2loc.c: Update.
3825         * dwarf2read.c: Update.
3826         * eval.c: Update.
3827         * event-loop.c: Update.
3828         * event-top.c: Update.
3829         * exec.c: Update.
3830         * f-valprint.c: Update.
3831         * fbsd-tdep.c: Update.
3832         * frame-unwind.c: Update.
3833         * frame.c: Update.
3834         * gdbtypes.c: Update.
3835         * gnu-v3-abi.c: Update.
3836         * guile/guile-internal.h: Update.
3837         * guile/scm-block.c: Update.
3838         * guile/scm-breakpoint.c: Update.
3839         * guile/scm-cmd.c: Update.
3840         * guile/scm-disasm.c: Update.
3841         * guile/scm-frame.c: Update.
3842         * guile/scm-lazy-string.c: Update.
3843         * guile/scm-math.c: Update.
3844         * guile/scm-param.c: Update.
3845         * guile/scm-ports.c: Update.
3846         * guile/scm-pretty-print.c: Update.
3847         * guile/scm-symbol.c: Update.
3848         * guile/scm-symtab.c: Update.
3849         * guile/scm-type.c: Update.
3850         * guile/scm-value.c: Update.
3851         * i386-linux-tdep.c: Update.
3852         * i386-tdep.c: Update.
3853         * inf-loop.c: Update.
3854         * infcall.c: Update.
3855         * infcmd.c: Update.
3856         * infrun.c: Update.
3857         * jit.c: Update.
3858         * language.c: Update.
3859         * linespec.c: Update.
3860         * linux-fork.c: Update.
3861         * linux-nat.c: Update.
3862         * linux-tdep.c: Update.
3863         * linux-thread-db.c: Update.
3864         * main.c: Update.
3865         * mi/mi-cmd-break.c: Update.
3866         * mi/mi-cmd-stack.c: Update.
3867         * mi/mi-interp.c: Update.
3868         * mi/mi-main.c: Update.
3869         * objc-lang.c: Update.
3870         * p-valprint.c: Update.
3871         * parse.c: Update.
3872         * ppc-linux-tdep.c: Update.
3873         * printcmd.c: Update.
3874         * python/py-arch.c: Update.
3875         * python/py-breakpoint.c: Update.
3876         * python/py-cmd.c: Update.
3877         * python/py-finishbreakpoint.c: Update.
3878         * python/py-frame.c: Update.
3879         * python/py-framefilter.c: Update.
3880         * python/py-gdb-readline.c: Update.
3881         * python/py-inferior.c: Update.
3882         * python/py-infthread.c: Update.
3883         * python/py-lazy-string.c: Update.
3884         * python/py-linetable.c: Update.
3885         * python/py-objfile.c: Update.
3886         * python/py-param.c: Update.
3887         * python/py-prettyprint.c: Update.
3888         * python/py-progspace.c: Update.
3889         * python/py-record-btrace.c: Update.
3890         * python/py-record.c: Update.
3891         * python/py-symbol.c: Update.
3892         * python/py-type.c: Update.
3893         * python/py-unwind.c: Update.
3894         * python/py-utils.c: Update.
3895         * python/py-value.c: Update.
3896         * python/python.c: Update.
3897         * record-btrace.c: Update.
3898         * record-full.c: Update.
3899         * remote-fileio.c: Update.
3900         * remote.c: Update.
3901         * riscv-tdep.c: Update.
3902         * rs6000-aix-tdep.c: Update.
3903         * rs6000-tdep.c: Update.
3904         * rust-exp.y: Update.
3905         * rust-lang.c: Update.
3906         * s390-tdep.c: Update.
3907         * selftest-arch.c: Update.
3908         * solib-dsbt.c: Update.
3909         * solib-frv.c: Update.
3910         * solib-spu.c: Update.
3911         * solib-svr4.c: Update.
3912         * solib.c: Update.
3913         * sparc64-linux-tdep.c: Update.
3914         * stack.c: Update.
3915         * symfile-mem.c: Update.
3916         * symmisc.c: Update.
3917         * target.c: Update.
3918         * thread.c: Update.
3919         * top.c: Update.
3920         * tracefile-tfile.c: Update.
3921         * tui/tui.c: Update.
3922         * typeprint.c: Update.
3923         * unittests/cli-utils-selftests.c: Update.
3924         * unittests/parse-connection-spec-selftests.c: Update.
3925         * valops.c: Update.
3926         * valprint.c: Update.
3927         * value.c: Update.
3928         * varobj.c: Update.
3929         * windows-nat.c: Update.
3930         * x86-linux-nat.c: Update.
3931         * xml-support.c: Update.
3932
3933 2019-04-08  Tom Tromey  <tom@tromey.com>
3934
3935         * xml-support.c: Use C++ exception handling.
3936         * x86-linux-nat.c: Use C++ exception handling.
3937         * windows-nat.c: Use C++ exception handling.
3938         * varobj.c: Use C++ exception handling.
3939         * value.c: Use C++ exception handling.
3940         * valprint.c: Use C++ exception handling.
3941         * valops.c: Use C++ exception handling.
3942         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3943         handling.
3944         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3945         * typeprint.c: Use C++ exception handling.
3946         * tui/tui.c: Use C++ exception handling.
3947         * tracefile-tfile.c: Use C++ exception handling.
3948         * top.c: Use C++ exception handling.
3949         * thread.c: Use C++ exception handling.
3950         * target.c: Use C++ exception handling.
3951         * symmisc.c: Use C++ exception handling.
3952         * symfile-mem.c: Use C++ exception handling.
3953         * stack.c: Use C++ exception handling.
3954         * sparc64-linux-tdep.c: Use C++ exception handling.
3955         * solib.c: Use C++ exception handling.
3956         * solib-svr4.c: Use C++ exception handling.
3957         * solib-spu.c: Use C++ exception handling.
3958         * solib-frv.c: Use C++ exception handling.
3959         * solib-dsbt.c: Use C++ exception handling.
3960         * selftest-arch.c: Use C++ exception handling.
3961         * s390-tdep.c: Use C++ exception handling.
3962         * rust-lang.c: Use C++ exception handling.
3963         * rust-exp.y: Use C++ exception handling.
3964         * rs6000-tdep.c: Use C++ exception handling.
3965         * rs6000-aix-tdep.c: Use C++ exception handling.
3966         * riscv-tdep.c: Use C++ exception handling.
3967         * remote.c: Use C++ exception handling.
3968         * remote-fileio.c: Use C++ exception handling.
3969         * record-full.c: Use C++ exception handling.
3970         * record-btrace.c: Use C++ exception handling.
3971         * python/python.c: Use C++ exception handling.
3972         * python/py-value.c: Use C++ exception handling.
3973         * python/py-utils.c: Use C++ exception handling.
3974         * python/py-unwind.c: Use C++ exception handling.
3975         * python/py-type.c: Use C++ exception handling.
3976         * python/py-symbol.c: Use C++ exception handling.
3977         * python/py-record.c: Use C++ exception handling.
3978         * python/py-record-btrace.c: Use C++ exception handling.
3979         * python/py-progspace.c: Use C++ exception handling.
3980         * python/py-prettyprint.c: Use C++ exception handling.
3981         * python/py-param.c: Use C++ exception handling.
3982         * python/py-objfile.c: Use C++ exception handling.
3983         * python/py-linetable.c: Use C++ exception handling.
3984         * python/py-lazy-string.c: Use C++ exception handling.
3985         * python/py-infthread.c: Use C++ exception handling.
3986         * python/py-inferior.c: Use C++ exception handling.
3987         * python/py-gdb-readline.c: Use C++ exception handling.
3988         * python/py-framefilter.c: Use C++ exception handling.
3989         * python/py-frame.c: Use C++ exception handling.
3990         * python/py-finishbreakpoint.c: Use C++ exception handling.
3991         * python/py-cmd.c: Use C++ exception handling.
3992         * python/py-breakpoint.c: Use C++ exception handling.
3993         * python/py-arch.c: Use C++ exception handling.
3994         * printcmd.c: Use C++ exception handling.
3995         * ppc-linux-tdep.c: Use C++ exception handling.
3996         * parse.c: Use C++ exception handling.
3997         * p-valprint.c: Use C++ exception handling.
3998         * objc-lang.c: Use C++ exception handling.
3999         * mi/mi-main.c: Use C++ exception handling.
4000         * mi/mi-interp.c: Use C++ exception handling.
4001         * mi/mi-cmd-stack.c: Use C++ exception handling.
4002         * mi/mi-cmd-break.c: Use C++ exception handling.
4003         * main.c: Use C++ exception handling.
4004         * linux-thread-db.c: Use C++ exception handling.
4005         * linux-tdep.c: Use C++ exception handling.
4006         * linux-nat.c: Use C++ exception handling.
4007         * linux-fork.c: Use C++ exception handling.
4008         * linespec.c: Use C++ exception handling.
4009         * language.c: Use C++ exception handling.
4010         * jit.c: Use C++ exception handling.
4011         * infrun.c: Use C++ exception handling.
4012         * infcmd.c: Use C++ exception handling.
4013         * infcall.c: Use C++ exception handling.
4014         * inf-loop.c: Use C++ exception handling.
4015         * i386-tdep.c: Use C++ exception handling.
4016         * i386-linux-tdep.c: Use C++ exception handling.
4017         * guile/scm-value.c: Use C++ exception handling.
4018         * guile/scm-type.c: Use C++ exception handling.
4019         * guile/scm-symtab.c: Use C++ exception handling.
4020         * guile/scm-symbol.c: Use C++ exception handling.
4021         * guile/scm-pretty-print.c: Use C++ exception handling.
4022         * guile/scm-ports.c: Use C++ exception handling.
4023         * guile/scm-param.c: Use C++ exception handling.
4024         * guile/scm-math.c: Use C++ exception handling.
4025         * guile/scm-lazy-string.c: Use C++ exception handling.
4026         * guile/scm-frame.c: Use C++ exception handling.
4027         * guile/scm-disasm.c: Use C++ exception handling.
4028         * guile/scm-cmd.c: Use C++ exception handling.
4029         * guile/scm-breakpoint.c: Use C++ exception handling.
4030         * guile/scm-block.c: Use C++ exception handling.
4031         * guile/guile-internal.h: Use C++ exception handling.
4032         * gnu-v3-abi.c: Use C++ exception handling.
4033         * gdbtypes.c: Use C++ exception handling.
4034         * frame.c: Use C++ exception handling.
4035         * frame-unwind.c: Use C++ exception handling.
4036         * fbsd-tdep.c: Use C++ exception handling.
4037         * f-valprint.c: Use C++ exception handling.
4038         * exec.c: Use C++ exception handling.
4039         * event-top.c: Use C++ exception handling.
4040         * event-loop.c: Use C++ exception handling.
4041         * eval.c: Use C++ exception handling.
4042         * dwarf2read.c: Use C++ exception handling.
4043         * dwarf2loc.c: Use C++ exception handling.
4044         * dwarf2-frame.c: Use C++ exception handling.
4045         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4046         * dwarf-index-write.c: Use C++ exception handling.
4047         * dwarf-index-cache.c: Use C++ exception handling.
4048         * dtrace-probe.c: Use C++ exception handling.
4049         * disasm-selftests.c: Use C++ exception handling.
4050         * darwin-nat.c: Use C++ exception handling.
4051         * cp-valprint.c: Use C++ exception handling.
4052         * cp-support.c: Use C++ exception handling.
4053         * cp-abi.c: Use C++ exception handling.
4054         * corelow.c: Use C++ exception handling.
4055         * completer.c: Use C++ exception handling.
4056         * compile/compile-object-run.c: Use C++ exception handling.
4057         * compile/compile-object-load.c: Use C++ exception handling.
4058         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4059         * compile/compile-c-symbols.c: Use C++ exception handling.
4060         * common/selftest.c: Use C++ exception handling.
4061         * common/new-op.c: Use C++ exception handling.
4062         * cli/cli-script.c: Use C++ exception handling.
4063         * cli/cli-interp.c: Use C++ exception handling.
4064         * cli/cli-cmds.c: Use C++ exception handling.
4065         * c-varobj.c: Use C++ exception handling.
4066         * btrace.c: Use C++ exception handling.
4067         * breakpoint.c: Use C++ exception handling.
4068         * break-catch-throw.c: Use C++ exception handling.
4069         * arch-utils.c: Use C++ exception handling.
4070         * amd64-tdep.c: Use C++ exception handling.
4071         * ada-valprint.c: Use C++ exception handling.
4072         * ada-typeprint.c: Use C++ exception handling.
4073         * ada-lang.c: Use C++ exception handling.
4074         * aarch64-tdep.c: Use C++ exception handling.
4075
4076 2019-04-08  Tom Tromey  <tom@tromey.com>
4077
4078         * xml-support.c (gdb_xml_parser::parse): Update.
4079         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4080         * value.c (show_convenience): Update.
4081         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4082         (test_parse_flags_qcs): Update.
4083         * thread.c (thr_try_catch_cmd): Update.
4084         * target.c (target_translate_tls_address): Update.
4085         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4086         (info_frame_command_core, frame_apply_command_count): Update.
4087         * rust-exp.y (rust_lex_exception_test): Update.
4088         * riscv-tdep.c (riscv_print_one_register_info): Update.
4089         * remote.c (remote_target::enable_btrace): Update.
4090         * record-btrace.c (record_btrace_enable_warn): Update.
4091         * python/py-utils.c (gdbpy_convert_exception): Update.
4092         * printcmd.c (do_one_display, print_variable_and_value): Update.
4093         * mi/mi-main.c (mi_print_exception): Update.
4094         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4095         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4096         * linux-nat.c (linux_nat_target::attach): Update.
4097         * linux-fork.c (class scoped_switch_fork_info): Update.
4098         * infrun.c (displaced_step_prepare): Update.
4099         * infcall.c (call_function_by_hand_dummy): Update.
4100         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4101         * gnu-v3-abi.c (print_one_vtable): Update.
4102         * frame.c (get_prev_frame_always): Update.
4103         * f-valprint.c (info_common_command_for_block): Update.
4104         * exec.c (try_open_exec_file): Update.
4105         * exceptions.c (print_exception, exception_print)
4106         (exception_fprintf, exception_print_same): Update.
4107         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4108         * dwarf-index-cache.c (index_cache::store)
4109         (index_cache::lookup_gdb_index): Update.
4110         * darwin-nat.c (maybe_cache_shell): Update.
4111         * cp-valprint.c (cp_print_value_fields): Update.
4112         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4113         (gcc_cplus_symbol_address): Update.
4114         * compile/compile-c-symbols.c (gcc_convert_symbol)
4115         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4116         * common/selftest.c: Update.
4117         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4118         a std::string.
4119         (exception_try_scope_entry, exception_try_scope_exit): Don't
4120         declare.
4121         (struct exception_try_scope): Remove.
4122         (TRY): Don't use exception_try_scope.
4123         (struct gdb_exception): Add constructor, operator=.
4124         <what>: New method.
4125         (struct gdb_exception_RETURN_MASK_ALL)
4126         (struct gdb_exception_RETURN_MASK_ERROR)
4127         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4128         (struct gdb_quit_bad_alloc): Update.
4129         * common/common-exceptions.c (exception_none): Change
4130         initializer.
4131         (struct catcher) <state, exception>: Initialize inline.
4132         <prev>: Remove member.
4133         (current_catcher): Remove.
4134         (catchers): New global.
4135         (exceptions_state_mc_init): Simplify.
4136         (catcher_pop): Remove.
4137         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4138         (try_scope_depth, exception_try_scope_entry)
4139         (exception_try_scope_exit): Remove.
4140         (throw_exception_sjlj): Update.
4141         (exception_messages, exception_messages_size): Remove.
4142         (throw_it): Simplify.
4143         (gdb_exception_sliced_copy): Remove.
4144         (throw_exception_cxx): Update.
4145         * cli/cli-script.c (script_from_file): Update.
4146         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4147         Update.
4148         * ada-valprint.c (ada_val_print): Update.
4149         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4150         (create_excep_cond_exprs): Update.
4151
4152 2019-04-08  Tom Tromey  <tom@tromey.com>
4153
4154         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4155         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4156         (TRY, CATCH, END_CATCH): Remove some definitions.
4157         * common/common-exceptions.c: Don't use GDB_XCPT.
4158         (catcher_list_size): Remove.
4159         (throw_exception, throw_it): Simplify.
4160
4161 2019-04-05  Tom Tromey  <tom@tromey.com>
4162
4163         Revert the header-sorting patch.
4164         * ft32-tdep.c: Revert.
4165         * frv-tdep.c: Revert.
4166         * frv-linux-tdep.c: Revert.
4167         * frame.c: Revert.
4168         * frame-unwind.c: Revert.
4169         * frame-base.c: Revert.
4170         * fork-child.c: Revert.
4171         * findvar.c: Revert.
4172         * findcmd.c: Revert.
4173         * filesystem.c: Revert.
4174         * filename-seen-cache.h: Revert.
4175         * filename-seen-cache.c: Revert.
4176         * fbsd-tdep.c: Revert.
4177         * fbsd-nat.h: Revert.
4178         * fbsd-nat.c: Revert.
4179         * f-valprint.c: Revert.
4180         * f-typeprint.c: Revert.
4181         * f-lang.c: Revert.
4182         * extension.h: Revert.
4183         * extension.c: Revert.
4184         * extension-priv.h: Revert.
4185         * expprint.c: Revert.
4186         * exec.h: Revert.
4187         * exec.c: Revert.
4188         * exceptions.c: Revert.
4189         * event-top.c: Revert.
4190         * event-loop.c: Revert.
4191         * eval.c: Revert.
4192         * elfread.c: Revert.
4193         * dwarf2read.h: Revert.
4194         * dwarf2read.c: Revert.
4195         * dwarf2loc.c: Revert.
4196         * dwarf2expr.h: Revert.
4197         * dwarf2expr.c: Revert.
4198         * dwarf2-frame.c: Revert.
4199         * dwarf2-frame-tailcall.c: Revert.
4200         * dwarf-index-write.h: Revert.
4201         * dwarf-index-write.c: Revert.
4202         * dwarf-index-common.c: Revert.
4203         * dwarf-index-cache.h: Revert.
4204         * dwarf-index-cache.c: Revert.
4205         * dummy-frame.c: Revert.
4206         * dtrace-probe.c: Revert.
4207         * disasm.h: Revert.
4208         * disasm.c: Revert.
4209         * disasm-selftests.c: Revert.
4210         * dictionary.c: Revert.
4211         * dicos-tdep.c: Revert.
4212         * demangle.c: Revert.
4213         * dcache.h: Revert.
4214         * dcache.c: Revert.
4215         * darwin-nat.h: Revert.
4216         * darwin-nat.c: Revert.
4217         * darwin-nat-info.c: Revert.
4218         * d-valprint.c: Revert.
4219         * d-namespace.c: Revert.
4220         * d-lang.c: Revert.
4221         * ctf.c: Revert.
4222         * csky-tdep.c: Revert.
4223         * csky-linux-tdep.c: Revert.
4224         * cris-tdep.c: Revert.
4225         * cris-linux-tdep.c: Revert.
4226         * cp-valprint.c: Revert.
4227         * cp-support.c: Revert.
4228         * cp-namespace.c: Revert.
4229         * cp-abi.c: Revert.
4230         * corelow.c: Revert.
4231         * corefile.c: Revert.
4232         * continuations.c: Revert.
4233         * completer.h: Revert.
4234         * completer.c: Revert.
4235         * complaints.c: Revert.
4236         * coffread.c: Revert.
4237         * coff-pe-read.c: Revert.
4238         * cli-out.h: Revert.
4239         * cli-out.c: Revert.
4240         * charset.c: Revert.
4241         * c-varobj.c: Revert.
4242         * c-valprint.c: Revert.
4243         * c-typeprint.c: Revert.
4244         * c-lang.c: Revert.
4245         * buildsym.c: Revert.
4246         * buildsym-legacy.c: Revert.
4247         * build-id.h: Revert.
4248         * build-id.c: Revert.
4249         * btrace.c: Revert.
4250         * bsd-uthread.c: Revert.
4251         * breakpoint.h: Revert.
4252         * breakpoint.c: Revert.
4253         * break-catch-throw.c: Revert.
4254         * break-catch-syscall.c: Revert.
4255         * break-catch-sig.c: Revert.
4256         * blockframe.c: Revert.
4257         * block.c: Revert.
4258         * bfin-tdep.c: Revert.
4259         * bfin-linux-tdep.c: Revert.
4260         * bfd-target.c: Revert.
4261         * bcache.c: Revert.
4262         * ax-general.c: Revert.
4263         * ax-gdb.h: Revert.
4264         * ax-gdb.c: Revert.
4265         * avr-tdep.c: Revert.
4266         * auxv.c: Revert.
4267         * auto-load.c: Revert.
4268         * arm-wince-tdep.c: Revert.
4269         * arm-tdep.c: Revert.
4270         * arm-symbian-tdep.c: Revert.
4271         * arm-pikeos-tdep.c: Revert.
4272         * arm-obsd-tdep.c: Revert.
4273         * arm-nbsd-tdep.c: Revert.
4274         * arm-nbsd-nat.c: Revert.
4275         * arm-linux-tdep.c: Revert.
4276         * arm-linux-nat.c: Revert.
4277         * arm-fbsd-tdep.c: Revert.
4278         * arm-fbsd-nat.c: Revert.
4279         * arm-bsd-tdep.c: Revert.
4280         * arch-utils.c: Revert.
4281         * arc-tdep.c: Revert.
4282         * arc-newlib-tdep.c: Revert.
4283         * annotate.h: Revert.
4284         * annotate.c: Revert.
4285         * amd64-windows-tdep.c: Revert.
4286         * amd64-windows-nat.c: Revert.
4287         * amd64-tdep.c: Revert.
4288         * amd64-sol2-tdep.c: Revert.
4289         * amd64-obsd-tdep.c: Revert.
4290         * amd64-obsd-nat.c: Revert.
4291         * amd64-nbsd-tdep.c: Revert.
4292         * amd64-nbsd-nat.c: Revert.
4293         * amd64-nat.c: Revert.
4294         * amd64-linux-tdep.c: Revert.
4295         * amd64-linux-nat.c: Revert.
4296         * amd64-fbsd-tdep.c: Revert.
4297         * amd64-fbsd-nat.c: Revert.
4298         * amd64-dicos-tdep.c: Revert.
4299         * amd64-darwin-tdep.c: Revert.
4300         * amd64-bsd-nat.c: Revert.
4301         * alpha-tdep.c: Revert.
4302         * alpha-obsd-tdep.c: Revert.
4303         * alpha-nbsd-tdep.c: Revert.
4304         * alpha-mdebug-tdep.c: Revert.
4305         * alpha-linux-tdep.c: Revert.
4306         * alpha-linux-nat.c: Revert.
4307         * alpha-bsd-tdep.c: Revert.
4308         * alpha-bsd-nat.c: Revert.
4309         * aix-thread.c: Revert.
4310         * agent.c: Revert.
4311         * addrmap.c: Revert.
4312         * ada-varobj.c: Revert.
4313         * ada-valprint.c: Revert.
4314         * ada-typeprint.c: Revert.
4315         * ada-tasks.c: Revert.
4316         * ada-lang.c: Revert.
4317         * aarch64-tdep.c: Revert.
4318         * aarch64-ravenscar-thread.c: Revert.
4319         * aarch64-newlib-tdep.c: Revert.
4320         * aarch64-linux-tdep.c: Revert.
4321         * aarch64-linux-nat.c: Revert.
4322         * aarch64-fbsd-tdep.c: Revert.
4323         * aarch64-fbsd-nat.c: Revert.
4324         * aarch32-linux-nat.c: Revert.
4325
4326 2019-04-05  Tom Tromey  <tom@tromey.com>
4327
4328         * ft32-tdep.c: Sort headers.
4329         * frv-tdep.c: Sort headers.
4330         * frv-linux-tdep.c: Sort headers.
4331         * frame.c: Sort headers.
4332         * frame-unwind.c: Sort headers.
4333         * frame-base.c: Sort headers.
4334         * fork-child.c: Sort headers.
4335         * findvar.c: Sort headers.
4336         * findcmd.c: Sort headers.
4337         * filesystem.c: Sort headers.
4338         * filename-seen-cache.h: Sort headers.
4339         * filename-seen-cache.c: Sort headers.
4340         * fbsd-tdep.c: Sort headers.
4341         * fbsd-nat.h: Sort headers.
4342         * fbsd-nat.c: Sort headers.
4343         * f-valprint.c: Sort headers.
4344         * f-typeprint.c: Sort headers.
4345         * f-lang.c: Sort headers.
4346         * extension.h: Sort headers.
4347         * extension.c: Sort headers.
4348         * extension-priv.h: Sort headers.
4349         * expprint.c: Sort headers.
4350         * exec.h: Sort headers.
4351         * exec.c: Sort headers.
4352         * exceptions.c: Sort headers.
4353         * event-top.c: Sort headers.
4354         * event-loop.c: Sort headers.
4355         * eval.c: Sort headers.
4356         * elfread.c: Sort headers.
4357         * dwarf2read.h: Sort headers.
4358         * dwarf2read.c: Sort headers.
4359         * dwarf2loc.c: Sort headers.
4360         * dwarf2expr.h: Sort headers.
4361         * dwarf2expr.c: Sort headers.
4362         * dwarf2-frame.c: Sort headers.
4363         * dwarf2-frame-tailcall.c: Sort headers.
4364         * dwarf-index-write.h: Sort headers.
4365         * dwarf-index-write.c: Sort headers.
4366         * dwarf-index-common.c: Sort headers.
4367         * dwarf-index-cache.h: Sort headers.
4368         * dwarf-index-cache.c: Sort headers.
4369         * dummy-frame.c: Sort headers.
4370         * dtrace-probe.c: Sort headers.
4371         * disasm.h: Sort headers.
4372         * disasm.c: Sort headers.
4373         * disasm-selftests.c: Sort headers.
4374         * dictionary.c: Sort headers.
4375         * dicos-tdep.c: Sort headers.
4376         * demangle.c: Sort headers.
4377         * dcache.h: Sort headers.
4378         * dcache.c: Sort headers.
4379         * darwin-nat.h: Sort headers.
4380         * darwin-nat.c: Sort headers.
4381         * darwin-nat-info.c: Sort headers.
4382         * d-valprint.c: Sort headers.
4383         * d-namespace.c: Sort headers.
4384         * d-lang.c: Sort headers.
4385         * ctf.c: Sort headers.
4386         * csky-tdep.c: Sort headers.
4387         * csky-linux-tdep.c: Sort headers.
4388         * cris-tdep.c: Sort headers.
4389         * cris-linux-tdep.c: Sort headers.
4390         * cp-valprint.c: Sort headers.
4391         * cp-support.c: Sort headers.
4392         * cp-namespace.c: Sort headers.
4393         * cp-abi.c: Sort headers.
4394         * corelow.c: Sort headers.
4395         * corefile.c: Sort headers.
4396         * continuations.c: Sort headers.
4397         * completer.h: Sort headers.
4398         * completer.c: Sort headers.
4399         * complaints.c: Sort headers.
4400         * coffread.c: Sort headers.
4401         * coff-pe-read.c: Sort headers.
4402         * cli-out.h: Sort headers.
4403         * cli-out.c: Sort headers.
4404         * charset.c: Sort headers.
4405         * c-varobj.c: Sort headers.
4406         * c-valprint.c: Sort headers.
4407         * c-typeprint.c: Sort headers.
4408         * c-lang.c: Sort headers.
4409         * buildsym.c: Sort headers.
4410         * buildsym-legacy.c: Sort headers.
4411         * build-id.h: Sort headers.
4412         * build-id.c: Sort headers.
4413         * btrace.c: Sort headers.
4414         * bsd-uthread.c: Sort headers.
4415         * breakpoint.h: Sort headers.
4416         * breakpoint.c: Sort headers.
4417         * break-catch-throw.c: Sort headers.
4418         * break-catch-syscall.c: Sort headers.
4419         * break-catch-sig.c: Sort headers.
4420         * blockframe.c: Sort headers.
4421         * block.c: Sort headers.
4422         * bfin-tdep.c: Sort headers.
4423         * bfin-linux-tdep.c: Sort headers.
4424         * bfd-target.c: Sort headers.
4425         * bcache.c: Sort headers.
4426         * ax-general.c: Sort headers.
4427         * ax-gdb.h: Sort headers.
4428         * ax-gdb.c: Sort headers.
4429         * avr-tdep.c: Sort headers.
4430         * auxv.c: Sort headers.
4431         * auto-load.c: Sort headers.
4432         * arm-wince-tdep.c: Sort headers.
4433         * arm-tdep.c: Sort headers.
4434         * arm-symbian-tdep.c: Sort headers.
4435         * arm-pikeos-tdep.c: Sort headers.
4436         * arm-obsd-tdep.c: Sort headers.
4437         * arm-nbsd-tdep.c: Sort headers.
4438         * arm-nbsd-nat.c: Sort headers.
4439         * arm-linux-tdep.c: Sort headers.
4440         * arm-linux-nat.c: Sort headers.
4441         * arm-fbsd-tdep.c: Sort headers.
4442         * arm-fbsd-nat.c: Sort headers.
4443         * arm-bsd-tdep.c: Sort headers.
4444         * arch-utils.c: Sort headers.
4445         * arc-tdep.c: Sort headers.
4446         * arc-newlib-tdep.c: Sort headers.
4447         * annotate.h: Sort headers.
4448         * annotate.c: Sort headers.
4449         * amd64-windows-tdep.c: Sort headers.
4450         * amd64-windows-nat.c: Sort headers.
4451         * amd64-tdep.c: Sort headers.
4452         * amd64-sol2-tdep.c: Sort headers.
4453         * amd64-obsd-tdep.c: Sort headers.
4454         * amd64-obsd-nat.c: Sort headers.
4455         * amd64-nbsd-tdep.c: Sort headers.
4456         * amd64-nbsd-nat.c: Sort headers.
4457         * amd64-nat.c: Sort headers.
4458         * amd64-linux-tdep.c: Sort headers.
4459         * amd64-linux-nat.c: Sort headers.
4460         * amd64-fbsd-tdep.c: Sort headers.
4461         * amd64-fbsd-nat.c: Sort headers.
4462         * amd64-dicos-tdep.c: Sort headers.
4463         * amd64-darwin-tdep.c: Sort headers.
4464         * amd64-bsd-nat.c: Sort headers.
4465         * alpha-tdep.c: Sort headers.
4466         * alpha-obsd-tdep.c: Sort headers.
4467         * alpha-nbsd-tdep.c: Sort headers.
4468         * alpha-mdebug-tdep.c: Sort headers.
4469         * alpha-linux-tdep.c: Sort headers.
4470         * alpha-linux-nat.c: Sort headers.
4471         * alpha-bsd-tdep.c: Sort headers.
4472         * alpha-bsd-nat.c: Sort headers.
4473         * aix-thread.c: Sort headers.
4474         * agent.c: Sort headers.
4475         * addrmap.c: Sort headers.
4476         * ada-varobj.c: Sort headers.
4477         * ada-valprint.c: Sort headers.
4478         * ada-typeprint.c: Sort headers.
4479         * ada-tasks.c: Sort headers.
4480         * ada-lang.c: Sort headers.
4481         * aarch64-tdep.c: Sort headers.
4482         * aarch64-ravenscar-thread.c: Sort headers.
4483         * aarch64-newlib-tdep.c: Sort headers.
4484         * aarch64-linux-tdep.c: Sort headers.
4485         * aarch64-linux-nat.c: Sort headers.
4486         * aarch64-fbsd-tdep.c: Sort headers.
4487         * aarch64-fbsd-nat.c: Sort headers.
4488         * aarch32-linux-nat.c: Sort headers.
4489
4490 2019-04-04  Tom Tromey  <tom@tromey.com>
4491
4492         * varobj.c (varobj_create): Update.
4493         * rust-exp.y (struct rust_parser) <update_innermost_block,
4494         lookup_symbol>: New methods.
4495         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4496         Rename.
4497         (rust_parser::rust_lookup_type)
4498         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4499         * printcmd.c (display_command, do_one_display): Update.
4500         * parser-defs.h (struct parser_state) <parser_state>: Add
4501         "tracker" parameter.
4502         (block_tracker): New member.
4503         (class innermost_block_tracker) <innermost_block_tracker>: Add
4504         "types" parameter.
4505         <reset>: Remove method.
4506         (innermost_block): Don't declare.
4507         (null_post_parser): Update.
4508         * parse.c (innermost_block): Remove global.
4509         (write_dollar_variable): Update.
4510         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4511         Remove "tracker_types" parameter.
4512         (parse_expression): Add "tracker" parameter.
4513         (parse_expression_for_completion): Update.
4514         (null_post_parser): Add "tracker" parameter.
4515         * p-exp.y: Update rules.
4516         * m2-exp.y: Update rules.
4517         * language.h (struct language_defn) <la_post_parser>: Add
4518         "tracker" parameter.
4519         * go-exp.y: Update rules.
4520         * f-exp.y: Update rules.
4521         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4522         parameter.
4523         * d-exp.y: Update rules.
4524         * c-exp.y: Update rules.
4525         * breakpoint.c (set_breakpoint_condition): Create an
4526         innermost_block_tracker.
4527         (watch_command_1): Likewise.
4528         * ada-lang.c (resolve): Add "tracker" parameter.
4529         (resolve_subexp): Likewise.
4530         * ada-exp.y (write_var_from_sym): Update.
4531
4532 2019-04-04  Tom Tromey  <tom@tromey.com>
4533
4534         * type-stack.h: New file.
4535         * type-stack.c: New file.
4536         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4537         type-stack.h.
4538         (insert_into_type_stack, insert_type, push_type, push_type_int)
4539         (insert_type_address_space, pop_type, pop_type_int)
4540         (pop_typelist, pop_type_stack, append_type_stack)
4541         (push_type_stack, get_type_stack, push_typelist)
4542         (follow_type_instance_flags, follow_types): Don't declare.
4543         * parse.c (type_stack): Remove global.
4544         (parse_exp_in_context): Update.
4545         (insert_into_type_stack, insert_type, push_type, push_type_int)
4546         (insert_type_address_space, pop_type, pop_type_int)
4547         (pop_typelist, pop_type_stack, append_type_stack)
4548         (push_type_stack, get_type_stack, push_typelist)
4549         (follow_type_instance_flags, follow_types): Remove (moved to
4550         type-stack.c).
4551         * f-exp.y (type_stack): New global.
4552         Update rules.
4553         (push_kind_type, f_parse): Update.
4554         * d-exp.y (type_stack): New global.
4555         Update rules.
4556         (d_parse): Update.
4557         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4558         Update rules.
4559         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4560         (HFILES_NO_SRCDIR): Add type-stack.h.
4561
4562 2019-04-04  Tom Tromey  <tom@tromey.com>
4563
4564         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4565         (rust_parser::convert_ast_to_expression, rust_parse)
4566         (rust_lex_test_completion, rust_lex_tests): Update.
4567         * parser-defs.h (struct expr_completion_state): New.
4568         (struct parser_state) <parser_state>: Add completion parameter.
4569         <mark_struct_expression, mark_completion_tag>: New methods.
4570         <parse_completion, m_completion_state>: New members.
4571         (prefixify_expression, null_post_parser): Update.
4572         (mark_struct_expression, mark_completion_tag): Don't declare.
4573         * parse.c (parse_completion, expout_last_struct)
4574         (expout_tag_completion_type, expout_completion_name): Remove
4575         globals.
4576         (parser_state::mark_struct_expression)
4577         (parser_state::mark_completion_tag): Now methods.
4578         (prefixify_expression): Add last_struct parameter.
4579         (prefixify_subexp): Likewise.
4580         (parse_exp_1): Update.
4581         (parse_exp_in_context): Add cstate parameter.  Update.
4582         (parse_expression_for_completion): Create an
4583         expr_completion_state.
4584         (null_post_parser): Add "completion" parameter.
4585         * p-exp.y: Update rules.
4586         (yylex): Update.
4587         * language.h (struct language_defn) <la_post_parser>: Add
4588         "completing" parameter.
4589         * go-exp.y: Update rules.
4590         (lex_one_token): Update.
4591         * expression.h (parse_completion): Don't declare.
4592         * d-exp.y: Update rules.
4593         (lex_one_token): Update rules.
4594         * c-exp.y: Update rules.
4595         (lex_one_token): Update.
4596         * ada-lang.c (resolve): Add "parse_completion" parameter.
4597         (resolve_subexp): Likewise.
4598         (ada_resolve_function): Likewise.
4599
4600 2019-04-04  Tom Tromey  <tom@tromey.com>
4601
4602         * parser-defs.h (struct parser_state) <start_arglist,
4603         end_arglist>: New methods.
4604         <arglist_len, m_funcall_chain>: New members.
4605         (arglist_len, start_arglist, end_arglist): Don't declare.
4606         * parse.c (arglist_len, funcall_chain): Remove global.
4607         (start_arglist, end_arglist): Remove functions.
4608         (parse_exp_in_context): Update.
4609         * p-exp.y: Update rules.
4610         * m2-exp.y: Update rules.
4611         * go-exp.y: Update rules.
4612         * f-exp.y: Update rules.
4613         * d-exp.y: Update rules.
4614         * c-exp.y: Update rules.
4615
4616 2019-04-04  Tom Tromey  <tom@tromey.com>
4617
4618         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4619         lex_operator, push_back>: New methods.
4620         Update all rules.
4621         (rust_parser::lex_hex, lex_escape): Rename and update.
4622         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4623         (rust_parser::lex_operator): Rename and update.
4624         (rust_parser::lex_number, rustyylex, rustyyerror)
4625         (rust_lex_test_init, rust_lex_test_sequence)
4626         (rust_lex_test_push_back, rust_lex_tests): Update.
4627         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4628         parameter.
4629         <lexptr, prev_lexptr>: New members.
4630         (lexptr, prev_lexptr): Don't declare.
4631         * parse.c (lexptr, prev_lexptr): Remove globals.
4632         (parse_exp_in_context): Update.
4633         * p-exp.y (yylex, yyerror): Update.
4634         * m2-exp.y (parse_number, yylex, yyerror): Update.
4635         * go-exp.y (lex_one_token, yyerror): Update.
4636         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4637         * d-exp.y (lex_one_token, yyerror): Update.
4638         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4639         (lex_one_token, yyerror): Update.
4640         * ada-lex.l (YY_INPUT): Update.
4641         (rewind_to_char): Update.
4642         * ada-exp.y (yyerror): Update.
4643
4644 2019-04-04  Tom Tromey  <tom@tromey.com>
4645
4646         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4647         * parser-defs.h (struct parser_state) <parser_state>: Add new
4648         parameter.
4649         <comma_terminates>: New member.
4650         (comma_terminates): Don't declare global.
4651         * parse.c (comma_terminates): Remove global.
4652         (parse_exp_in_context): Update.
4653         * p-exp.y (yylex): Update.
4654         * m2-exp.y (yylex): Update.
4655         * go-exp.y (lex_one_token): Update.
4656         * f-exp.y (yylex): Update.
4657         * d-exp.y (lex_one_token): Update.
4658         * c-exp.y (lex_one_token): Update.
4659         * ada-lex.l: Update.
4660
4661 2019-04-04  Tom Tromey  <tom@tromey.com>
4662
4663         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4664         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4665         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4666         * parser-defs.h (paren_depth): Don't declare.
4667         * parse.c (paren_depth): Remove global.
4668         (parse_exp_in_context): Update.
4669         * p-exp.y (paren_depth): New global.
4670         (pascal_parse): Initialize it.
4671         * m2-exp.y (paren_depth): New global.
4672         (m2_parse): Initialize it.
4673         * go-exp.y (paren_depth): New global.
4674         (go_parse): Initialize it.
4675         * f-exp.y (paren_depth): New global.
4676         (f_parse): Initialize it.
4677         * d-exp.y (paren_depth): New global.
4678         (d_parse): Initialize it.
4679         * c-exp.y (paren_depth): New global.
4680         (c_parse): Initialize it.
4681         * ada-lex.l (paren_depth): New global.
4682         (lexer_init): Initialize it.
4683
4684 2019-04-04  Tom Tromey  <tom@tromey.com>
4685
4686         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4687         (rust_parser::convert_ast_to_type)
4688         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4689         * parser-defs.h (struct parser_state) <parser_state>: Add
4690         parameters.  Initialize new members.
4691         <expression_context_block, expression_context_pc>: New members.
4692         * parse.c (expression_context_block, expression_context_pc):
4693         Remove globals.
4694         (parse_exp_in_context): Update.
4695         * p-exp.y: Update all rules.
4696         (yylex): Update.
4697         * m2-exp.y: Update all rules.
4698         (yylex): Update.
4699         * go-exp.y (yylex): Update.
4700         * f-exp.y (yylex): Update.
4701         * d-exp.y: Update all rules.
4702         (yylex): Update.
4703         * c-exp.y: Update all rules.
4704         (lex_one_token, classify_name, yylex, c_parse): Update.
4705         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4706
4707 2019-04-04  Tom Tromey  <tom@tromey.com>
4708
4709         * gdbarch.h, gdbarch.c: Rebuild.
4710         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4711         * stap-probe.h:
4712         (struct stap_parse_info): Replace "parser_state" with
4713         "expr_builder".
4714         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4715         (parser_state): New class.
4716         * parse.c (expr_builder): Rename.
4717         (expr_builder::release): Rename.
4718         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4719         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4720         (write_exp_elt_longcst, write_exp_elt_floatcst)
4721         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4722         (write_exp_string_vector, write_exp_bitstring)
4723         (write_exp_msymbol, mark_struct_expression)
4724         (write_dollar_variable)
4725         (insert_type_address_space, increase_expout_size): Replace
4726         "parser_state" with "expr_builder".
4727         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4728         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4729         "parser_state" with "expr_builder".
4730
4731 2019-04-04  Tom Tromey  <tom@tromey.com>
4732
4733         * rust-exp.y: Replace "parse_language" with method call.
4734         * p-exp.y:
4735         (yylex): Replace "parse_language" with method call.
4736         * m2-exp.y:
4737         (yylex): Replace "parse_language" with method call.
4738         * go-exp.y (classify_name): Replace "parse_language" with method
4739         call.
4740         * f-exp.y (yylex): Replace "parse_language" with method call.
4741         * d-exp.y (lex_one_token): Replace "parse_language" with method
4742         call.
4743         * c-exp.y:
4744         (lex_one_token, classify_name, yylex): Replace "parse_language"
4745         with method call.
4746         * ada-exp.y (find_primitive_type, type_char)
4747         (type_system_address): Replace "parse_language" with method call.
4748
4749 2019-04-04  Tom Tromey  <tom@tromey.com>
4750
4751         * rust-exp.y: Replace "parse_gdbarch" with method call.
4752         * parse.c (write_dollar_variable, insert_type_address_space):
4753         Replace "parse_gdbarch" with method call.
4754         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4755         call.
4756         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4757         call.
4758         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4759         "parse_gdbarch" with method call.
4760         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4761         with method call.
4762         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4763         "parse_gdbarch" with method call.
4764         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4765         "parse_gdbarch" with method call.
4766         * c-exp.y (parse_type, parse_number, classify_name): Replace
4767         "parse_gdbarch" with method call.
4768         * ada-lex.l: Replace "parse_gdbarch" with method call.
4769         * ada-exp.y (parse_type, find_primitive_type, type_char)
4770         (type_system_address): Replace "parse_gdbarch" with method call.
4771
4772 2019-04-04  Tom Tromey  <tom@tromey.com>
4773
4774         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4775         * stap-probe.c (stap_parse_argument): Update.
4776         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4777         initial_size parameter.
4778         * rust-exp.y (rust_lex_tests): Update.
4779         * parse.c (parser_state): Update.
4780         (parse_exp_in_context): Update.
4781         * parser-defs.h (struct parser_state) <parser_state>: Remove
4782         "initial_size" parameter.
4783
4784 2019-04-04  Tom Tromey  <tom@tromey.com>
4785
4786         * parser-defs.h (increase_expout_size): Don't declare.
4787         * parse.c (increase_expout_size): Now static.
4788
4789 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4790
4791         * gnu-nat.c (gnu_nat_target::wait): Fix
4792         target_waitstatus_to_string call.
4793
4794 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4795
4796         * eval.c (evaluate_subexp_standard): Handle internal functions
4797         during Fortran function call handling.
4798
4799 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4800
4801         * NEWS: Mention new internal functions.
4802         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4803         (read_base_type): Use dwarf2_init_complex_target_type.
4804         * value.c (creal_internal_fn): New function.
4805         (cimag_internal_fn): New function.
4806         (_initialize_values): Register new internal functions.
4807
4808 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4809
4810         * infrun.c (stop_all_threads): If debug_infrun, always
4811         trace the wait status after wait_one, using
4812         target_waitstatus_to_string and target_pid_to_str.
4813         (handle_inferior_event): Replace various trace of
4814         wait status kind by a single trace.
4815         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4816         wait status kind image by target_waitstatus_to_string.
4817         * target/waitstatus.c (target_waitstatus_to_string): Fix
4818         obsolete comment.
4819
4820 2019-04-01  Tom Tromey  <tromey@adacore.com>
4821
4822         PR symtab/23331:
4823         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4824
4825 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4826             Pedro Alves  <palves@redhat.com>
4827
4828         * top.c (quit_force): Call 'finalize_values'.
4829         * value.c (finalize_values): New function.
4830         * value.h (finalize_values): Declare.
4831
4832 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4833
4834         * NEWS: Announce $_gdb_major and $_gdb_minor.
4835
4836         * top.c (init_gdb_version_vars): New function.
4837         (gdb_init): Call init_gdb_version_vars.
4838
4839 2019-03-29  Tom Tromey  <tromey@adacore.com>
4840
4841         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4842         help text.  Remove dead code.
4843
4844 2019-03-29  Keith Seitz  <keiths@redhat.com>
4845
4846         From Siddhesh Poyarekar:
4847         * f-lang.h (f77_get_upperbound): Return LONGEST.
4848         (f77_get_lowerbound): Likewise.
4849         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4850         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4851         print them.
4852         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4853         plongest to format print it.
4854         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4855         (f77_get_upperbound): Likewise.
4856         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4857         LOWER_BOUND to LONGEST.
4858         (f77_create_arrayprint_offset_tbl): Likewise.
4859
4860 2019-03-29  Keith Seitz  <keiths@redhat.com>
4861
4862         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4863         %s/pulongest for TYPE_LENGTH instead of %d in format
4864         strings.
4865         * ada-typerint.c (ada_print_type): Likewise.
4866         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4867         * compile/compile-c-support.c (generate_register_struct): Likewise.
4868         * gdbtypes.c (recursive_dump_type): Likewise.
4869         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4870         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4871         instead of %d in format strings.
4872         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4873         to std::min to ULONGEST.
4874         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4875         instead of %d in format strings.
4876         * tracepoint.c (info_scope_command): Likewise.
4877         * typeprint.c (print_offset_data::update)
4878         (print_offset_data::finish): Likewise.
4879         * xtensa-tdep.c (xtensa_store_return_value)
4880         (xtensa_push_dummy_call): Likewise.
4881
4882 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4883
4884         * windows-nat.c (display_selector): Fixed format specifications
4885         for 64-bit Cygwin.
4886
4887 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4888
4889         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4890
4891 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4892
4893         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4894         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4895         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4896         (nios2_linux_init_abi): Install it.
4897
4898 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4899
4900         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4901
4902 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4903
4904         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4905
4906 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4907             Tom Tromey  <tromey@adacore.com>
4908
4909         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4910
4911 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4912
4913         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4914         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4915         method to compute the bounds of range types. Also print "[evaluated]"
4916         if the bounds' values come from a dynamic evaluation.
4917
4918 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4919
4920         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4921         whitespace when pretty printing is on.
4922
4923 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4924
4925         * ppc-linux-nat.c: Add include.
4926
4927 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4928
4929         * NEWS: Mention AArch64 Pointer Authentication.
4930
4931 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4932
4933         * arm-linux-nat.c: Add include.
4934
4935 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4936
4937         * source-cache.c (source_cache::get_source_lines): Re-read
4938         fullname after calling open_source_file.
4939
4940 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4941
4942         * NEWS: Mention TLS support for FreeBSD.
4943
4944 2019-03-25  Tom Tromey  <tromey@adacore.com>
4945
4946         * minsyms.c (BUNCH_SIZE): Update comment.
4947         (~minimal_symbol_reader): Remove old comment.
4948         (compact_minimal_symbols): Update comment.
4949         (minimal_symbol_reader::install): Remove old comment.  Update
4950         other comments.
4951
4952 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4953
4954         * s390-linux-nat.c: Add include.
4955
4956 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4957
4958         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4959         Call linux_get_hwcap.
4960         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4961         Likewise.
4962         (aarch64_linux_get_hwcap): Remove function.
4963         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4964         declaration.
4965         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4966         linux_get_hwcap.
4967         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4968         * linux-tdep.c (linux_get_hwcap): Add function.
4969         (linux_get_hwcap2): Likewise.
4970         * linux-tdep.h (linux_get_hwcap): Add declaration.
4971         (linux_get_hwcap2): Likewise.
4972         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4973         (ppc_linux_get_hwcap2): Likewise.
4974         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4975         linux_get_hwcap.
4976         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4977         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4978         (ppc_linux_nat_target::read_description): Likewise.
4979         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4980         * s390-linux-nat.c: Likewise.
4981         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4982
4983 2019-03-24  Tom Tromey  <tom@tromey.com>
4984
4985         * ada-lang.c (standard_lookup): Simplify initialization.
4986         (ada_lookup_symbol_nonlocal): Simplify return.
4987         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4988         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4989         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4990         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4991         initialization.
4992         * solib.c (solib_global_lookup): Simplify.
4993         * symtab.c (null_block_symbol): Remove.
4994         (symbol_cache_lookup): Simplify returns.
4995         (lookup_language_this): Simplify returns.
4996         (lookup_symbol_aux): Simplify return.
4997         (lookup_local_symbol): Simplify returns.
4998         (lookup_global_symbol_from_objfile): Simplify return.
4999         (lookup_symbol_in_objfile_symtabs)
5000         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5001         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5002         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5003         * cp-namespace.c (cp_lookup_bare_symbol)
5004         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5005         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5006         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5007         (cp_lookup_symbol_via_imports): Simplify initialization.
5008         (find_symbol_in_baseclass): Likewise.
5009         * symtab.h (null_block_symbol): Remove.
5010         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5011         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5012         (d_lookup_symbol_module): Likewise.
5013         (find_symbol_in_baseclass): Simplify initialization.
5014
5015 2019-03-24  Tom Tromey  <tom@tromey.com>
5016
5017         * expression.h: Don't include symtab.h.
5018         (struct block): Forward declare.
5019
5020 2019-03-24  Tom Tromey  <tom@tromey.com>
5021
5022         * c-exp.y (typebase): Remove casts.
5023         * gdbtypes.c (lookup_unsigned_typename, )
5024         (lookup_signed_typename): Remove cast.
5025         * eval.c (parse_to_comma_and_eval): Remove cast.
5026         * parse.c (write_dollar_variable): Remove cast.
5027         * block.h (struct block) <superblock>: Now const.
5028         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5029         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5030         (map_block): Make "block" const.
5031         * symfile.h (struct quick_symbol_functions)
5032         <map_matching_symbols>: Constify block argument to "callback".
5033         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5034         const.
5035         (find_pc_sect_compunit_symtab): Make "b" const.
5036         (find_symbol_at_address): Likewise.
5037         (search_symbols): Likewise.
5038         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5039         (dw2_debug_names_lookup_symbol): Likewise.
5040         (dw2_map_matching_symbols): Update.
5041         * p-valprint.c (pascal_val_print): Remove "block".
5042         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5043         (aux_add_nonlocal_symbols): Make "block" const.
5044         (resolve_subexp): Remove cast.
5045         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5046         const.
5047         (iterate_over_file_blocks): Likewise.
5048         * f-exp.y (%union) <bval>: Remove.
5049         * coffread.c (patch_opaque_types): Make "b" const.
5050         * spu-tdep.c (spu_catch_start): Make "block" const.
5051         * c-valprint.c (print_unpacked_pointer): Remove "block".
5052         * symmisc.c (dump_symtab_1): Make "b" const.
5053         (block_depth): Make "block" const.
5054         * d-exp.y (%union) <bval>: Remove.
5055         * cp-support.h (cp_lookup_rtti_type): Update.
5056         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5057         * psymtab.c (psym_lookup_symbol): Make "block" const.
5058         (maintenance_check_psymtabs): Make "b" const.
5059         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5060         (enumerate_locals, enumerate_args): Update.
5061         * python/py-symtab.c (stpy_global_block): Make "block" const.
5062         (stpy_static_block): Likewise.
5063         * inline-frame.c (block_starting_point_at): Make "new_block"
5064         const.
5065         * block.c (find_block_in_blockvector): Make return type const.
5066         (blockvector_for_pc_sect): Make "b" const.
5067         (find_block_in_blockvector): Make "b" const.
5068
5069 2019-03-23  Tom Tromey  <tom@tromey.com>
5070
5071         * varobj.c (varobj_create): Update.
5072         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5073         * printcmd.c (display_command, do_one_display): Don't reset
5074         innermost_block.
5075         * parser-defs.h (enum innermost_block_tracker_type): Move to
5076         expression.h.
5077         (innermost_block): Update comment.
5078         * parse.c (parse_exp_1): Add tracker_types parameter.
5079         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5080         tracker_types parameter.  Reset innermost_block.
5081         (parse_exp_in_context): Remove.
5082         (parse_expression_for_completion): Update.
5083         * objfiles.c (~objfile): Don't reset expression_context_block or
5084         innermost_block.
5085         * expression.h (enum innermost_block_tracker_type): Move from
5086         parser-defs.h.
5087         (parse_exp_1): Add tracker_types parameter.
5088         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5089         reset innermost_block.
5090
5091 2019-03-23  Tom Tromey  <tom@tromey.com>
5092
5093         * objfiles.h: Include bcache.h.
5094
5095 2019-03-23  Tom Tromey  <tom@tromey.com>
5096
5097         * linespec.c (get_current_search_block): Use
5098         scoped_restore_current_language.
5099         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5100
5101 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5102             Jiong Wang  <jiong.wang@arm.com>
5103
5104         * aarch64-linux-tdep.c
5105         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5106         section.
5107         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5108
5109 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5110             Jiong Wang  <jiong.wang@arm.com>
5111
5112         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5113         instructions.
5114         (aarch64_analyze_prologue_test): Add PACIASP test.
5115         (aarch64_prologue_prev_register): Unmask PC value.
5116
5117 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5118             Jiong Wang  <jiong.wang@arm.com>
5119
5120         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5121         (aarch64_dwarf2_prev_register): Unmask PC value.
5122         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5123         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5124         DW_CFA_AARCH64_negate_ra_state.
5125         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5126
5127 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5128             Jiong Wang  <jiong.wang@arm.com>
5129
5130         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5131         registers.
5132         (aarch64_pseudo_register_name): Likewise.
5133         (aarch64_pseudo_register_type): Likewise.
5134         (aarch64_pseudo_register_reggroup_p): Likewise.
5135         (aarch64_gdbarch_init): Add pauth registers.
5136         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5137         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5138         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5139         (struct gdbarch_tdep): Add regnum for ra_state.
5140
5141 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5142             Jiong Wang  <jiong.wang@arm.com>
5143
5144         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5145
5146 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5147             Jiong Wang  <jiong.wang@arm.com>
5148
5149         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5150         function.
5151         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5152         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5153         (aarch64_gdbarch_init): Add puth registers.
5154         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5155         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5156         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5157
5158 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5159             Jiong Wang  <jiong.wang@arm.com>
5160
5161         * aarch64-linux-nat.c
5162         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5163         * aarch64-linux-tdep.c
5164         (aarch64_linux_core_read_description): Likewise.
5165         (aarch64_linux_get_hwcap): New function.
5166         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5167         (aarch64_linux_get_hwcap): New declaration.
5168
5169 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5170             Jiong Wang  <jiong.wang@arm.com>
5171
5172         * aarch64-linux-nat.c
5173         (aarch64_linux_nat_target::read_description): Add pauth param.
5174         * aarch64-linux-tdep.c
5175         (aarch64_linux_core_read_description): Likewise.
5176         * aarch64-tdep.c (struct target_desc): Add in pauth.
5177         (aarch64_read_description): Add pauth param.
5178         (aarch64_gdbarch_init): Likewise.
5179         * aarch64-tdep.h (aarch64_read_description): Likewise.
5180         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5181         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5182         * features/Makefile: Add new files.
5183         * features/aarch64-pauth.c: New file.
5184         * features/aarch64-pauth.xml: New file.
5185
5186 2019-03-20  Tom Tromey  <tromey@adacore.com>
5187
5188         * infrun.c (handle_inferior_event): Rename from
5189         handle_inferior_event_1.  Create a scoped_value_mark.
5190         (handle_inferior_event): Remove.
5191
5192 2019-03-19  Tom Tromey  <tromey@adacore.com>
5193
5194         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5195         * infrun.h (print_stop_event): Add "displays" parameter.
5196         * infrun.c (print_stop_event): Add "displays" parameter.
5197
5198 2019-03-19  Pedro Alves  <palves@redhat.com>
5199
5200         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5201         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5202         to -1.  Fix TABs vs spaces.
5203         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5204         * tui/tui-out.h (tui_ui_out) Add intro comments.
5205         <m_line, m_start_of_line>: In-class initialize, and add describing
5206         comment.
5207
5208 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5209
5210         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5211         variable names.
5212         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5213
5214 2019-03-18  Pedro Alves  <palves@redhat.com>
5215             Eli Zaretskii <eliz@gnu.org>
5216
5217         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5218         m_line and m_start_of_line.
5219
5220 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5221
5222         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5223         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5224         it returns a newline.  This fixes a regression in TU mode, whereby
5225         the next line is output on the same screen line as the user input.
5226
5227 2019-03-18  Tom Tromey  <tromey@adacore.com>
5228
5229         * minsyms.c (minimal_symbol_reader::install): Remove call to
5230         obstack_blank.
5231
5232 2019-03-18  Pedro Alves  <palves@redhat.com>
5233
5234         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5235         New globals.
5236         (apply_style): New, factored out from ...
5237         (apply_ansi_escape): ... this.  Handle reverse video mode.
5238         (tui_set_reverse_mode): New function.
5239         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5240         * tui/tui-winsource.c (tui_show_source_line): Use
5241         tui_set_reverse_mode instead of setting A_STANDOUT.
5242         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5243         New setter methods.
5244
5245 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5246
5247         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5248         Handle tabs.
5249
5250 2019-03-18  Tom Tromey  <tromey@adacore.com>
5251
5252         * ada-lang.c (empty_array): Add "high" parameter.
5253         (ada_evaluate_subexp): Update.
5254
5255 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5256
5257         * unittests/string_view-selftests.c: Define
5258         _initialize_string_view_selftests unconditionally.
5259
5260 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5261
5262         PR gdb/24350
5263         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5264
5265 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5266
5267         PR gdb/24351
5268         * windows-nat.c (display_selector): Fix format specifiers.
5269
5270 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5271
5272         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5273         tui_refill_source_window instead of tui_refresh_win, to update the
5274         current execution line.  This fixes redisplay of the current line
5275         when stepping through the code with "next" or "step".
5276
5277 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5278
5279         * source-cache.c (source_cache::get_source_lines): Call
5280         find_source_lines to initialize s->nlines.  This fixes vertical
5281         scrolling of TUI source window when the DOWN arrow is pressed.
5282
5283 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5284
5285         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5286         linux-thread-db.c (_initialize_thread_db): Likewise.
5287
5288 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5289
5290         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5291         wclrtoeol in tui_show_source_line".  This reverts changes made in
5292         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5293
5294 2019-03-15  Tom Tromey  <tom@tromey.com>
5295
5296         * symtab.h (struct minimal_symbol): Derive from
5297         general_symbol_info.
5298         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5299         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5300         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5301         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5302         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5303         (MSYMBOL_SEARCH_NAME): Update.
5304         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5305         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5306         * minsyms.c (minimal_symbol_reader::record_full): Update.
5307
5308 2019-03-15  Tom Tromey  <tom@tromey.com>
5309
5310         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5311
5312 2019-03-15  Tom Tromey  <tom@tromey.com>
5313
5314         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5315         unique_xmalloc_ptr.
5316         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5317         Update.
5318         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5319         (build_minimal_symbol_hash_tables)
5320         (minimal_symbol_reader::install): Update.
5321
5322 2019-03-15  Tom Tromey  <tom@tromey.com>
5323
5324         * symtab.c (create_demangled_names_hash): Update.
5325         (symbol_set_names): Update.
5326         * objfiles.h (struct objfile_per_bfd_storage)
5327         <demangled_names_hash>: Now an htab_up.
5328         * objfiles.c (objfile_per_bfd_storage): Simplify.
5329
5330 2019-03-15  Tom Tromey  <tom@tromey.com>
5331
5332         * objfiles.h (struct objfile_per_bfd_storage): Declare
5333         destructor.
5334         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5335         New.
5336         (get_objfile_bfd_data): Use new.  Don't initialize
5337         language_of_main.
5338         (free_objfile_per_bfd_storage): Remove.
5339         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5340
5341 2019-03-15  Tom Tromey  <tom@tromey.com>
5342
5343         * symfile.c (reread_symbols): Update.
5344         * objfiles.c (objfile::objfile): Update.
5345         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5346         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5347         comment.
5348         (minimal_symbol_reader::install): Update.
5349         (terminate_minimal_symbol_table): Remove.
5350         * jit.c (jit_object_close_impl): Update.
5351
5352 2019-03-15  Tom Tromey  <tom@tromey.com>
5353
5354         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5355         initializations.
5356
5357 2019-03-15  Tom Tromey  <tom@tromey.com>
5358
5359         * objfiles.h (struct objfile_per_bfd_storage)
5360         <demangled_hash_languages>: Now a bitset.
5361         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5362         (lookup_minimal_symbol): Update.
5363
5364 2019-03-15  Tom Tromey  <tom@tromey.com>
5365
5366         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5367         Don't return the symbol.
5368         * coffread.c (record_minimal_symbol): Use record_full.
5369
5370 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5371
5372         The MS-Windows port of ncurses fails to switch to a color pair if
5373         one or both of the colors are the implicit default colors.  This
5374         change records the default colors when TUI is initialized, and
5375         then specifies them explicitly when a color pair uses the default
5376         colors.  This allows color styling in TUI mode on MS-Windows.
5377
5378         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5379         ncurses_norm_attr.
5380         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5381         colors in ncurses_norm_attr.
5382         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5383         "none", replace it with the default color recorded in
5384         ncurses_norm_attr.
5385
5386 2019-03-14  Tom Tromey  <tromey@adacore.com>
5387
5388         * source-cache.h (class source_cache) <get_source_lines>: Return
5389         std::string.
5390         * source-cache.c (source_cache::extract_lines): Handle case where
5391         first_pos==npos.  Return std::string.
5392         (source_cache::get_source_lines): Update.
5393
5394 2019-03-14  Tom Tromey  <tromey@adacore.com>
5395
5396         * NEWS: Add item for "style sources" commands.
5397         * source-cache.c (source_cache::get_source_lines): Check
5398         source_styling.
5399         * cli/cli-style.c (source_styling): New global.
5400         (_initialize_cli_style): Add "style sources" commands.
5401         (show_style_sources): New function.
5402         * cli/cli-style.h (source_styling): Declare.
5403
5404 2019-03-14  Pedro Alves  <palves@redhat.com>
5405             Tom Tromey  <tromey@adacore.com>
5406
5407         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5408         * tui/tui-winsource.c (tui_refill_source_window): New function,
5409         from...
5410         (tui_horizontal_source_scroll): ... here.  Move some logic.
5411         * cli/cli-style.c (set_style_enabled): Notify new observable.
5412         * tui/tui-hooks.c (tui_redisplay_source): New function.
5413         (tui_attach_detach_observers): Attach or detach
5414         tui_redisplay_source.
5415         * observable.h (source_styling_changed): New observable.
5416         * observable.c: Define source_styling_changed observable.
5417
5418 2019-03-13  Tom Tromey  <tromey@adacore.com>
5419
5420         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5421         (i386_gnu_nat_target::store_registers): Update.
5422         * target-debug.h (target_debug_print_std_string): New macro.
5423         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5424         * windows-tdep.c (display_one_tib): Update.
5425         * tui/tui-stack.c (tui_make_status_line): Update.
5426         * top.c (print_inferior_quit_action): Update.
5427         * thread.c (thr_try_catch_cmd): Update.
5428         (add_thread_with_info): Update.
5429         (thread_target_id_str): Update.
5430         (thr_try_catch_cmd): Update.
5431         (thread_command): Update.
5432         (thread_find_command): Update.
5433         * record-btrace.c (record_btrace_target::info_record)
5434         (record_btrace_resume_thread, record_btrace_target::resume)
5435         (record_btrace_cancel_resume, record_btrace_step_thread)
5436         (record_btrace_target::wait, record_btrace_target::wait)
5437         (record_btrace_target::wait, record_btrace_target::stop): Update.
5438         * progspace.c (print_program_space): Update.
5439         * process-stratum-target.c
5440         (process_stratum_target::thread_address_space): Update.
5441         * linux-fork.c (linux_fork_mourn_inferior)
5442         (detach_checkpoint_command, info_checkpoints_command)
5443         (linux_fork_context): Update.
5444         (linux_fork_detach): Update.
5445         (class scoped_switch_fork_info): Update.
5446         (delete_checkpoint_command): Update.
5447         * infrun.c (follow_fork_inferior): Update.
5448         (follow_fork_inferior): Update.
5449         (proceed_after_vfork_done): Update.
5450         (handle_vfork_child_exec_or_exit): Update.
5451         (follow_exec): Update.
5452         (displaced_step_prepare_throw): Update.
5453         (displaced_step_restore): Update.
5454         (start_step_over): Update.
5455         (resume_1): Update.
5456         (clear_proceed_status_thread): Update.
5457         (proceed): Update.
5458         (print_target_wait_results): Update.
5459         (do_target_wait): Update.
5460         (context_switch): Update.
5461         (stop_all_threads): Update.
5462         (restart_threads): Update.
5463         (finish_step_over): Update.
5464         (handle_signal_stop): Update.
5465         (switch_back_to_stepped_thread): Update.
5466         (keep_going_pass_signal): Update.
5467         (print_exited_reason): Update.
5468         (normal_stop): Update.
5469         * inferior.c (inferior_pid_to_str): Change return type.
5470         (print_selected_inferior): Update.
5471         (add_inferior): Update.
5472         (detach_inferior): Update.
5473         * dummy-frame.c (fprint_dummy_frames): Update.
5474         * dcache.c (dcache_info_1): Update.
5475         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5476         (btrace_fetch, btrace_clear): Update.
5477         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5478         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5479         type.
5480         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5481         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5482         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5483         * gdbarch.c, gdbarch.h: Rebuild.
5484         * gdbarch.sh (core_pid_to_str): Change return type.
5485         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5486         return type.
5487         (windows_nat_target::pid_to_str): Change return type.
5488         (windows_delete_thread): Update.
5489         (windows_nat_target::attach): Update.
5490         (windows_nat_target::files_info): Update.
5491         * target-delegates.c: Rebuild.
5492         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5493         return type.
5494         (sol_thread_target::pid_to_str): Change return type.
5495         * remote.c (class remote_target) <pid_to_str>: Change return
5496         type.
5497         (remote_target::pid_to_str): Change return type.
5498         (extended_remote_target::attach, remote_target::remote_stop_ns)
5499         (remote_target::remote_notif_remove_queued_reply)
5500         (remote_target::push_stop_reply, remote_target::disable_btrace):
5501         Update.
5502         (extended_remote_target::attach): Update.
5503         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5504         type.
5505         (gdbsim_target::pid_to_str): Change return type.
5506         * ravenscar-thread.c (struct ravenscar_thread_target)
5507         <pid_to_str>: Change return type.
5508         (ravenscar_thread_target::pid_to_str): Change return type.
5509         * procfs.c (class procfs_target) <pid_to_str>: Change return
5510         type.
5511         (procfs_target::pid_to_str): Change return type.
5512         (procfs_target::attach): Update.
5513         (procfs_target::detach): Update.
5514         (procfs_target::fetch_registers): Update.
5515         (procfs_target::store_registers): Update.
5516         (procfs_target::wait): Update.
5517         (procfs_target::files_info): Update.
5518         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5519         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5520         return type.
5521         (nto_procfs_target::pid_to_str): Change return type.
5522         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5523         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5524         return type.
5525         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5526         (exit_lwp): Update.
5527         (attach_proc_task_lwp_callback, get_detach_signal)
5528         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5529         (linux_nat_target::resume, wait_lwp, stop_callback)
5530         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5531         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5532         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5533         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5534         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5535         type.
5536         (inf_ptrace_target::attach): Update.
5537         (inf_ptrace_target::files_info): Update.
5538         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5539         type.
5540         (go32_nat_target::pid_to_str): Change return type.
5541         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5542         (gnu_nat_target::wait): Update.
5543         (gnu_nat_target::wait): Update.
5544         (gnu_nat_target::resume): Update.
5545         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5546         (fbsd_nat_target::wait): Update.
5547         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5548         type.
5549         (darwin_nat_target::attach): Update.
5550         * corelow.c (class core_target) <pid_to_str>: Change return type.
5551         (core_target::pid_to_str): Change return type.
5552         * target.c (normal_pid_to_str): Change return type.
5553         (default_pid_to_str): Likewise.
5554         (target_pid_to_str): Change return type.
5555         (target_translate_tls_address): Update.
5556         (target_announce_detach): Update.
5557         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5558         return type.
5559         (bsd_uthread_target::pid_to_str): Change return type.
5560         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5561         type.
5562         (bsd_kvm_target::pid_to_str): Change return type.
5563         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5564         return type.
5565         (aix_thread_target::pid_to_str): Change return type.
5566         * target.h (struct target_ops) <pid_to_str>: Change return type.
5567         (target_pid_to_str, normal_pid_to_str): Likewise.
5568         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5569         type.
5570         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5571         type.
5572         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5573         return type.
5574         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5575         type.
5576         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5577         type.
5578         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5579         return type.
5580
5581 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5582
5583         * NEWS: Mention that the new default MI version is 3.  Mention
5584         changes to the output of commands and events that deal with
5585         multi-location breakpoints.
5586         * breakpoint.c: Include "mi/mi-out.h".
5587         (print_one_breakpoint): Change output syntax if using MI version
5588         >= 3.
5589         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5590         New.
5591         (mi_multi_location_breakpoint_output_fixed): New.
5592         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5593         (mi_cmd_fix_multi_location_breakpoint_output): New.
5594         (mi_multi_location_breakpoint_output_fixed): New.
5595         * mi/mi-cmds.c (mi_cmds): Register command
5596         -fix-multi-location-breakpoint-output.
5597         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5598         interpreter "mi".
5599
5600 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5601
5602         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5603         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5604         instantiate mi_ui_out based on interpreter name.
5605         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5606         * mi/mi-main.c (mi_load_progress): Likewise.
5607
5608 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5609
5610         * NEWS: Combine separate "New targets" sections for 8.3.
5611
5612 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5613
5614         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5615         (ppcfbsd_init_abi): Install gdbarch
5616         "fetch_tls_load_module_address" and "get_thread_local_address"
5617         methods.
5618
5619 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5620
5621         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5622         (riscv_fbsd_init_abi): Install gdbarch
5623         "fetch_tls_load_module_address" and "get_thread_local_address"
5624         methods.
5625
5626 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5627
5628         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5629         (i386fbsd_init_abi): Install gdbarch
5630         "fetch_tls_load_module_address" and "get_thread_local_address"
5631         methods.
5632
5633 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5634
5635         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5636         (amd64fbsd_init_abi): Install gdbarch
5637         "fetch_tls_load_module_address" and "get_thread_local_address"
5638         methods.
5639
5640 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5641
5642         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5643         (struct fbsd_pspace_data): New type.
5644         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5645         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5646         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5647         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5648         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5649
5650 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5651
5652         * gdbtypes.c (lookup_struct_elt): New function.
5653         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5654         * gdbtypes.h (struct struct_elt): New type.
5655         (lookup_struct_elt): New prototype.
5656
5657 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5658
5659         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5660         remove disabled code block.
5661
5662 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5663
5664         * gdbarch.sh (get_thread_local_address): New method.
5665         * gdbarch.h, gdbarch.c: Regenerate.
5666         * target.c (target_translate_tls_address): Use
5667         gdbarch_get_thread_local_address if present instead of
5668         target::get_thread_local_address.
5669
5670 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5671
5672         * target.h (target::get_thread_local_address): Update comment.
5673
5674 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5675
5676         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5677         objfile->separate_debug_objfile_backlink if not NULL.
5678
5679 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5680
5681         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5682         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5683         (amd64bsd_store_inferior_registers): Likewise.
5684         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5685         Enable segment base registers.
5686         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5687         PT_GETFSBASE and PT_GETGSBASE.
5688         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5689         PT_SETGSBASE.
5690         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5691         segment base registers.
5692         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5693
5694 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5695
5696         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5697         Update calls to i386_target_description to add 'segments'
5698         parameter.
5699         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5700         add segment base registers.
5701         * arch/i386.c (i386_create_target_description): Add 'segments'
5702         parameter to enable segment base registers.
5703         * arch/i386.h (i386_create_target_description): Likewise.
5704         * features/i386/32bit-segments.xml: New file.
5705         * features/i386/32bit-segments.c: Generate.
5706         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5707         call to i386_target_description to add 'segments' parameter.
5708         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5709         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5710         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5711         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5712         if feature is present.
5713         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5714         Add 'segments' parameter to call to i386_target_description.
5715         (i386_target_description): Add 'segments' parameter to enable
5716         segment base registers.
5717         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5718         to call to i386_target_description.
5719         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5720         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5721         Define I386_NUM_REGS.
5722         (i386_target_description): Add 'segments' parameter to enable
5723         segment base registers.
5724
5725 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5726
5727         PR/24325
5728         * source-cache.c: #undef open and close, to avoid unresolved
5729         externals during linking.
5730
5731 2019-03-12  Tom Tromey  <tromey@adacore.com>
5732
5733         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5734         const.  Add initializers.
5735         (_initialize_remote): Don't initialize ptid globals.
5736
5737 2019-03-12  Pedro Alves  <palves@redhat.com>
5738
5739         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5740
5741 2019-03-12  Pedro Alves  <palves@redhat.com>
5742
5743         * cp-name-parser.y (main): Remove unused 'len' variable.
5744
5745 2019-03-12  Tom Tromey  <tromey@adacore.com>
5746
5747         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5748         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5749
5750 2019-03-12  Tom Tromey  <tromey@adacore.com>
5751
5752         * linux-nat.c (iterate_over_lwps): Update.
5753         (stop_callback): Remove parameter.
5754         (stop_wait_callback, detach_callback, resume_set_callback)
5755         (select_singlestep_lwp_callback, set_ignore_sigint)
5756         (status_callback, resumed_callback, resume_clear_callback)
5757         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5758         data parameter.
5759         (linux_nat_target::detach, linux_nat_target::resume)
5760         (linux_stop_and_wait_all_lwps, select_event_lwp)
5761         (linux_nat_filter_event, linux_nat_wait_1)
5762         (linux_nat_target::kill, linux_nat_target::stop)
5763         (linux_nat_target::stop): Update.
5764         (linux_nat_resume_callback): Change type.
5765         (resume_stopped_resumed_lwps, count_events_callback)
5766         (select_event_lwp_callback): Likewise.
5767         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5768         * arm-linux-nat.c (struct update_registers_data): Remove.
5769         (update_registers_callback): Change type.
5770         (arm_linux_insert_hw_breakpoint1): Update.
5771         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5772         parameter.
5773         (x86_linux_dr_set_addr): Update.
5774         (x86_linux_dr_set_control): Update.
5775         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5776         (iterate_over_lwps): Use gdb::function_view.
5777         * nat/aarch64-linux-hw-point.c (struct
5778         aarch64_dr_update_callback_param): Remove.
5779         (debug_reg_change_callback): Change type.
5780         (aarch64_notify_debug_reg_change): Update.
5781         * s390-linux-nat.c (s390_refresh_per_info): Update.
5782
5783 2019-03-11  Tom Tromey  <tromey@adacore.com>
5784
5785         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5786         redundant assignment to "this_cu".
5787
5788 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5789
5790         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5791
5792 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5793
5794         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5795         from...
5796         (rank_one_type): ... this.
5797
5798 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5799
5800         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5801         from...
5802         (rank_one_type): ... this.
5803
5804 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5805
5806         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5807         from...
5808         (rank_one_type): ... this.
5809
5810 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5811
5812         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5813         from...
5814         (rank_one_type): ... this.
5815
5816 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5817
5818         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5819         from...
5820         (rank_one_type): ... this.
5821
5822 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5823
5824         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5825         from...
5826         (rank_one_type): ... this.
5827
5828 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5829
5830         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5831         from...
5832         (rank_one_type): ... this.
5833
5834 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5835
5836         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5837         from...
5838         (rank_one_type): ... this.
5839
5840 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5841
5842         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5843         from...
5844         (rank_one_type): ... this.
5845
5846 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5847
5848         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5849         from...
5850         (rank_one_type): ... this.
5851
5852 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5853
5854         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5855         from...
5856         (rank_one_type): ... this.
5857
5858 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5859
5860         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5861         from...
5862         (rank_one_type): ... this.
5863
5864 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5865
5866         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5867         inferior-events' shows the example events.
5868
5869 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5870
5871         Support styling on native MS-Windows console
5872
5873         PR/24315
5874         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5875         on MS-Windows if $TERM is not defined.
5876
5877         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5878
5879         * posix-hdep.c (gdb_console_fputs):
5880         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5881         functions.
5882         * ui-file.h (gdb_console_fputs): Add prototype.
5883
5884         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5885         back to fputs only if the former returns zero.
5886
5887 2019-03-07  Tom Tromey  <tom@tromey.com>
5888
5889         * symmisc.c (print_symbol_bcache_statistics): Update.
5890         (print_objfile_statistics): Update.
5891         * symfile.c (allocate_symtab): Update.
5892         * stabsread.c: Don't include bcache.h.
5893         * psymtab.h (struct psymbol_bcache): Don't declare.
5894         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5895         (psymbol_bcache_init, psymbol_bcache_free)
5896         (psymbol_bcache_get_bcache): Don't declare.
5897         * psymtab.c (struct psymbol_bcache): Remove.
5898         (psymtab_storage::psymtab_storage): Update.
5899         (psymtab_storage::~psymtab_storage): Update.
5900         (psymbol_bcache_init, psymbol_bcache_free)
5901         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5902         (add_psymbol_to_bcache): Update.
5903         (allocate_psymtab): Update.
5904         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5905         macro_cache>: No longer pointers.
5906         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5907         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5908         * macrotab.c (macro_bcache): Update.
5909         * macroexp.c: Don't include bcache.h.
5910         * gdbtypes.c (check_types_worklist): Update.
5911         (types_deeply_equal): Remove TRY/CATCH.  Update.
5912         * elfread.c (elf_symtab_read): Update.
5913         * dwarf2read.c: Don't include bcache.h.
5914         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5915         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5916         (print_bcache_statistics, bcache_memory_used): Don't declare.
5917         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5918         methods.  Rename all data members.
5919         * bcache.c (struct bcache): Move to bcache.h.
5920         (bcache::expand_hash_table): Rename from expand_hash_table.
5921         (bcache): Remove.
5922         (bcache::insert): Rename from bcache_full.
5923         (bcache::compare): Rename from bcache_compare.
5924         (bcache_xmalloc): Remove.
5925         (bcache::~bcache): Rename from bcache_xfree.
5926         (bcache::print_statistics): Rename from print_bcache_statistics.
5927         (bcache::memory_used): Rename from bcache_memory_used.
5928
5929 2019-03-07  Pedro Alves  <palves@redhat.com>
5930
5931         * infrun.c (normal_stop): Also check for
5932         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5933
5934 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5935
5936         * f-lang.c (value_from_host_double): Moved to...
5937         * value.c (value_from_host_double): ...here.
5938         * value.h (value_from_host_double): Declare.
5939         * guile/scm-math.c (vlscm_convert_typed_number): Use
5940         value_from_host_double.
5941         (vlscm_convert_number): Likewise.
5942         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5943         * python/py-value.c (convert_value_from_python): Likewise.
5944
5945 2019-03-06  Tom Tromey  <tom@tromey.com>
5946
5947         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5948
5949 2019-03-06  Tom Tromey  <tom@tromey.com>
5950
5951         * utils.h (free_current_contents): Don't declare.
5952         * utils.c (free_current_contents): Remove.
5953
5954 2019-03-06  Tom Tromey  <tom@tromey.com>
5955
5956         * top.c (quit_force): Update.
5957         * main.c (captured_command_loop): Update.
5958         * common/new-op.c (operator new): Update.
5959         * common/common-exceptions.c (struct catcher)
5960         <save_cleanup_chain>: Remove member.
5961         (exceptions_state_mc_init): Update.
5962         (exception_try_scope_entry): Return nullptr.
5963         (exception_try_scope_exit, exception_rethrow)
5964         (throw_exception_sjlj, throw_exception_cxx): Update.
5965         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5966         (all_cleanups, do_cleanups, discard_cleanups)
5967         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5968         (restore_cleanups, restore_final_cleanups): Don't declare.
5969         (do_final_cleanups): Remove parameter.
5970         * common/cleanups.c (cleanup_chain, make_cleanup)
5971         (make_cleanup_dtor, all_cleanups, do_cleanups)
5972         (discard_my_cleanups, discard_cleanups)
5973         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5974         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5975         (null_cleanup): Remove.
5976         (do_final_cleanups): Remove parameter.
5977
5978 2019-03-06  Tom Tromey  <tom@tromey.com>
5979
5980         * remote.c (remote_target::remote_parse_stop_reply): Use
5981         unique_xmalloc_ptr.
5982
5983 2019-03-06  Tom Tromey  <tom@tromey.com>
5984
5985         * stabsread.c (struct stabs_field_info): Rename from field_info.
5986         <list, fnlist>: Add initializers.
5987         <obstack>: New member.
5988         (read_member_functions, read_struct_fields, read_baseclasses):
5989         Allocate on obstack.  Don't use cleanups.
5990         (read_one_struct_field, read_member_functions, read_struct_fields)
5991         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5992         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5993         (read_struct_type): Update.
5994
5995 2019-03-06  Tom Tromey  <tom@tromey.com>
5996
5997         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5998         * common/filestuff.h (make_cleanup_close): Don't declare.
5999         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6000         Remove.
6001
6002 2019-03-06  Tom Tromey  <tom@tromey.com>
6003
6004         * solib-aix.c: Use make_scope_exit.
6005
6006 2019-03-06  Tom Tromey  <tom@tromey.com>
6007
6008         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6009         Use make_scope_exit.
6010
6011 2019-03-06  Tom Tromey  <tom@tromey.com>
6012
6013         * solib-svr4.c (disable_probes_interface): Remove parameter.
6014         (svr4_handle_solib_event): Use make_scope_exit.
6015
6016 2019-03-06  Tom Tromey  <tom@tromey.com>
6017
6018         * remote.c (struct stop_reply_deleter): Remove.
6019         (stop_reply_up): Update.
6020         (struct stop_reply): Derive from notif_event.  Don't typedef.
6021         <regcache>: Now a std::vector.
6022         (stop_reply_xfree): Remove.
6023         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6024         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6025         (remote_target::discard_pending_stop_replies): Use delete.
6026         (remote_target::remote_parse_stop_reply): Update.
6027         (remote_target::process_stop_reply): Update.
6028         * remote-notif.h (struct notif_event): Add virtual destructor.
6029         Remove "dtr" member.
6030         (struct notif_client) <alloc_event>: Return a unique_ptr.
6031         (notif_event_xfree): Don't declare.
6032         (notif_event_up): New typedef.
6033         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6034         (notif_event_xfree, do_notif_event_xfree): Remove.
6035         (remote_notif_state_xfree): Update.
6036
6037 2019-03-06  Tom Tromey  <tom@tromey.com>
6038
6039         * infrun.c (displaced_step_clear_cleanup): Now a
6040         forward_scope_exit type.
6041         (displaced_step_prepare_throw): Update.
6042         (displaced_step_fixup): Update.
6043
6044 2019-03-06  Tom Tromey  <tom@tromey.com>
6045
6046         * inferior.h (class inferior): Update comment.
6047         * gdbthread.h (class thread_info): Update comment.
6048
6049 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6050             Tom Tromey  <tom@tromey.com>
6051
6052         * stabsread.h (struct stab_section_list): Remove.
6053         (coffstab_build_psymtabs): Update.
6054         * dbxread.c (symbuf_sections): Now a std::vector.
6055         (sect_idx): New global.
6056         (fill_symbuf): Update.
6057         (coffstab_build_psymtabs): Change type of stabsects parameter.
6058         Update.
6059         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6060         std::vector.
6061         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6062         (coff_locate_sections): Update.
6063         (coff_symfile_read): Remove cleanups.  Update.
6064         (init_stringtab): Add storage parameter.
6065         (free_stringtab, free_stringtab_cleanup): Remove.
6066         (init_lineno): Add storage parameter.
6067         (free_linetab, free_linetab_cleanup): Remove.
6068
6069 2019-03-06  Pedro Alves  <palves@redhat.com>
6070
6071         * linux-fork.c (fork_info::clobber_regs): Delete.
6072         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6073         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6074         comment.  Adjust.
6075         (scoped_switch_fork_info::scoped_switch_fork_info)
6076         (checkpoint_command, linux_fork_context): Adjust
6077         fork_save_infrun_state calls.
6078
6079 2019-03-06  Pedro Alves  <palves@redhat.com>
6080
6081         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6082         (inf_has_multiple_threads): Return 'bool' and rewrite using
6083         inferior_info::threads().
6084
6085 2019-03-06  Pedro Alves  <palves@redhat.com>
6086
6087         * linux-fork.c: Include <list>.
6088         (fork_list): Now a std::list instance.
6089         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6090         (forks_exist_p, find_last_fork): Adjust.
6091         (new_fork): Delete.
6092         (one_fork_p): New.
6093         (add_fork): Adjust.
6094         (free_fork): Delete, folded into fork_info::~fork_info().
6095         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6096         Adjust.
6097         (init_fork_list): Delete.
6098         (linux_fork_killall, linux_fork_mourn_inferior)
6099         (linux_fork_detach, info_checkpoints_command): Adjust.
6100         (_initialize_linux_fork): No longer call init_fork_list.
6101
6102 2019-03-06  Pedro Alves  <palves@redhat.com>
6103
6104         * linux-fork.c (new_fork): New, split out of ...
6105         (add_fork): ... this.  Return void.  Move "first fork" special
6106         case from here, to ...
6107         (checkpoint_command): ... here.
6108         * linux-linux.h (add_fork): Return void.
6109
6110 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6111
6112         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6113
6114 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6115             Chris January  <chris.january@arm.com>
6116             David Lecomber  <david.lecomber@arm.com>
6117
6118         * f-exp.y: New token, UNOP_INTRINSIC.
6119         (exp): New pattern using UNOP_INTRINSIC token.
6120         (f77_keywords): Add 'abs' keyword.
6121         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6122         (value_from_host_double): New function.
6123         (evaluate_subexp_f): Support UNOP_ABS.
6124
6125 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6126
6127         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6128         types.
6129
6130 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6131
6132         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6133         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6134         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6135
6136 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6137
6138         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6139
6140 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6141             Chris January  <chris.january@arm.com>
6142
6143         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6144         * f-exp.y: Define 'KIND' token.
6145         (exp): New pattern for KIND expressions.
6146         (ptype): Handle types with a kind extension.
6147         (direct_abs_decl): Extend to spot kind extensions.
6148         (f77_keywords): Add 'kind' to the list.
6149         (push_kind_type): New function.
6150         (convert_to_kind_type): New function.
6151         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6152         * parse.c (operator_length_standard): Likewise.
6153         * parser-defs.h (enum type_pieces): Add tp_kind.
6154         * std-operator.def: Add UNOP_KIND.
6155
6156 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6157
6158         * f-exp.y (f_parse): Set yydebug.
6159
6160 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6161
6162         * f-lang.c (evaluate_subexp_f): New function.
6163         (exp_descriptor_f): New global.
6164         (f_language_defn): Use exp_descriptor_f instead of
6165         exp_descriptor_standard.
6166
6167 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6168
6169         * f-exp.y (struct token): Add comments.
6170         (dot_ops): Remove uppercase versions and the end marker.
6171         (f77_keywords): Likewise.
6172         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6173         entries in the dot_ops array are case insensitive, and use
6174         strncasecmp to compare strings.  Also some whitespace cleanup in
6175         this area.  Similar for the f77_keywords array, except entries in
6176         this list might be case sensitive.
6177
6178 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6179
6180         * f-exp.y (struct f77_boolean_val): Add comments.
6181         (boolean_values): Remove uppercase versions, and end marker.
6182         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6183         and use strncasecmp to achieve case insensitivity.  Additionally,
6184         perform whitespace cleanup around this code.
6185
6186 2019-03-06  Tom Tromey  <tromey@adacore.com>
6187
6188         * remote-sim.c (gdbsim_target_open): Use result of
6189         gdb_argv::release.
6190
6191 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6192         Dirk Schubert  <dirk.schubert@arm.com>
6193         Chris January  <chris.january@arm.com>
6194
6195         * eval.c (evaluate_subexp_standard): Call Fortran argument
6196         wrapping logic.
6197         * f-lang.c (struct value): A value which can be passed into a
6198         Fortran function call.
6199         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6200         where appropriate.
6201         (struct type): Value ready for a Fortran function call.
6202         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6203         is needed.
6204         * f-lang.h (fortran_argument_convert): Declaration.
6205         (fortran_preserve_arg_pointer): Declaration.
6206         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6207
6208 2019-03-05  Tom Tromey  <tromey@adacore.com>
6209
6210         * python/py-prettyprint.c (print_string_repr): Remove #if.
6211         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6212
6213 2019-03-05  Tom Tromey  <tromey@adacore.com>
6214
6215         * target.c (the_dummy_target): Move later.  Change type to
6216         "dummy_target".
6217         (initialize_targets): Don't initialize the_dummy_target.
6218
6219 2019-03-05  Tom Tromey  <tromey@adacore.com>
6220
6221         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6222         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6223
6224 2019-03-05  Tom Tromey  <tromey@adacore.com>
6225
6226         * windows-nat.c (windows_nat_target::attach)
6227         (windows_nat_target::detach): Don't call gdb_flush.
6228         * valprint.c (generic_val_print, val_print, val_print_string):
6229         Don't call gdb_flush.
6230         * utils.c (defaulted_query): Don't call gdb_flush.
6231         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6232         * target.c (target_announce_detach): Don't call gdb_flush.
6233         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6234         * remote.c (extended_remote_target::attach): Don't call
6235         gdb_flush.
6236         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6237         * printcmd.c (do_examine): Don't call gdb_flush.
6238         (info_display_command): Don't call gdb_flush.
6239         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6240         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6241         * memattr.c (info_mem_command): Don't call gdb_flush.
6242         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6243         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6244         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6245         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6246         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6247         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6248         (gnu_nat_target::detach): Don't call gdb_flush.
6249         * f-valprint.c (f_val_print): Don't call gdb_flush.
6250         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6251         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6252         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6253         gdb_flush.
6254         * c-valprint.c (c_val_print): Don't call gdb_flush.
6255         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6256
6257 2019-03-05  Tom Tromey  <tromey@adacore.com>
6258
6259         * varobj.c (update_dynamic_varobj_children): Update.
6260         (install_default_visualizer): Use reset, not release.
6261         * value.c (set_internalvar): Update.
6262         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6263         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6264         ATTRIBUTE_UNUSED_RESULT.
6265
6266 2019-03-05  Tom Tromey  <tromey@adacore.com>
6267
6268         * remote.c (class scoped_remote_fd) <release>: Add
6269         ATTRIBUTE_UNUSED_RESULT.
6270
6271 2019-03-05  Tom Tromey  <tromey@adacore.com>
6272
6273         * macroexp.c (struct macro_buffer) <release>: Add
6274         ATTRIBUTE_UNUSED_RESULT.
6275
6276 2019-03-05  Tom Tromey  <tromey@adacore.com>
6277
6278         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6279         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6280         ATTRIBUTE_UNUSED_RESULT.
6281
6282 2019-03-05  Tom Tromey  <tromey@adacore.com>
6283
6284         * common/scoped_fd.h (class scoped_fd) <release>: Add
6285         ATTRIBUTE_UNUSED_RESULT.
6286
6287 2019-03-05  Tom Tromey  <tromey@adacore.com>
6288
6289         * parser-defs.h (struct parser_state) <release>: Add
6290         ATTRIBUTE_UNUSED_RESULT.
6291
6292 2019-03-05  Tom Tromey  <tromey@adacore.com>
6293
6294         * utils.h (class gdb_argv) <release>: Add
6295         ATTRIBUTE_UNUSED_RESULT.
6296         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6297
6298 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6299
6300         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6301         for-loop range, to avoid compiler warnings.
6302
6303         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6304         avoid compiler warnings about unused variables.
6305
6306         * NEWS: Mention end of support for native debugging on MS-Windows
6307         before XP.
6308
6309         PR gdb/24292
6310         * common/netstuff.c:
6311         * gdbserver/gdbreplay.c
6312         * gdbserver/remote-utils.c:
6313         * ser-tcp.c:
6314         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6315         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6316         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6317         'getaddrinfo' and 'freeaddrinfo' were not available before
6318         Windows XP, and mingw.org's MinGW headers by default define
6319         _WIN32_WINNT to 0x500.
6320
6321 2019-03-01  Gary Benson <gbenson@redhat.com>
6322
6323         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6324
6325 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6326             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6327
6328         PR gdb/8527
6329         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6330         set_sigint_trap, clear_sigint_trap.
6331
6332 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6333
6334         * target.c (target_detach): Clear the regcache and the
6335         frame cache.
6336
6337 2019-02-27  Pedro Alves  <palves@redhat.com>
6338
6339         * utils.c (set_screen_size): When we cap the height/width sizes,
6340         tweak the corresponding command variable to show "unlimited":
6341
6342 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6343             Pedro Alves  <palves@redhat.com>
6344
6345         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6346         before calling rl_set_screen_size.
6347
6348 2019-02-27  Tom Tromey  <tromey@adacore.com>
6349
6350         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6351         define.
6352         * python/py-value.c: Remove Python 2.4 workaround.
6353         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6354         workaround.
6355         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6356         Python 2.4 workaround.
6357         * python/python-internal.h: Remove Python 2.4 comment.
6358         (Py_ssize_t): Don't define.
6359         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6360         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6361         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6362         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6363         * python/python.c (do_start_initialization): Remove Python 2.4
6364         workaround.
6365         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6366         (print_children): Remove Python 2.4 workaround.
6367         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6368         workaround.
6369         (CHARBUFFERPROC_NAME): Remove.
6370         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6371         Python 2.4 workaround.
6372
6373 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6374
6375         * NEWS: Note minimum Python version.
6376
6377 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6378
6379         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6380         code from these functions.  Remove corresponding ifdefs.  Use
6381         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6382         Remove gotos and target of gotos.
6383         (infpy_search_memory): Likewise.
6384
6385 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6386
6387         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6388         (hppa_gdbarch_init): Don't register deleted functions with
6389         gdbarch.
6390
6391 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6392
6393         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6394         (h8300_unwind_sp): Delete.
6395         (h8300_dummy_id): Delete.
6396         (h8300_gdbarch_init): Don't register deleted functions with
6397         gdbarch.
6398
6399 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6400
6401         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6402         (ft32_unwind_pc): Delete.
6403         (ft32_unwind_sp): Delete.
6404         (ft32_gdbarch_init): Don't register deleted functions with
6405         gdbarch.
6406
6407 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6408
6409         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6410         (frv_unwind_pc): Delete.
6411         (frv_unwind_sp): Delete.
6412         (frv_gdbarch_init): Don't register deleted functions with
6413         gdbarch.
6414
6415 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6416
6417         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6418         (riscv_unwind_pc): Delete.
6419         (riscv_unwind_sp): Delete.
6420         (riscv_gdbarch_init): Don't register deleted functions with
6421         gdbarch.
6422
6423 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6424
6425         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6426         (csky_unwind_pc): Delete.
6427         (csky_unwind_sp): Delete.
6428         (csky_gdbarch_init): Don't register deleted functions with
6429         gdbarch.
6430
6431 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6432
6433         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6434         (cris_unwind_pc): Delete.
6435         (cris_unwind_sp): Delete.
6436         (cris_gdbarch_init): Don't register deleted functions with
6437         gdbarch.
6438
6439 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6440
6441         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6442         (bfin_unwind_pc): Delete.
6443         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6444
6445 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6446
6447         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6448         (arm_unwind_pc): Delete.
6449         (arm_unwind_sp): Delete.
6450         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6451
6452 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6453
6454         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6455         (arc_unwind_pc): Delete.
6456         (arc_unwind_sp): Delete.
6457         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6458
6459 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6460
6461         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6462         (alpha_unwind_pc): Delete.
6463         (alpha_gdbarch_init): Don't register deleted functions with
6464         gdbarch.
6465
6466 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6467
6468         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6469         (aarch64_unwind_pc): Delete.
6470         (aarch64_unwind_sp): Delete.
6471         (aarch64_gdbarch_init): Don't register deleted functions with
6472         gdbarch.
6473
6474 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6475
6476         * gdbtypes.c (type_align): Don't consider static members when
6477         computing structure alignment.
6478
6479 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6480
6481         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6482         return 0 for other types.
6483         * arch-utils.c (default_type_align): Always return 0.
6484         * gdbarch.h: Regenerate.
6485         * gdbarch.sh (type_align): Extend comment.
6486         * gdbtypes.c (type_align): Add additional comments, always call
6487         gdbarch_type_align before applying the default rules.
6488         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6489         generic code will then apply a suitable default.
6490         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6491         types, return 0 for other types.
6492
6493 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6494
6495         * NEWS: Create a new section for the next release branch.
6496         Rename the section of the current branch, now that it has
6497         been cut.
6498
6499 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6500
6501         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6502         * version.in: Bump version to 8.3.50.DATE-git.
6503
6504 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6505
6506         * aix-thread.c (ptid_cmp): Remove unused variable.
6507         (get_signaled_thread): Likewise.
6508         (store_regs_user_thread): Likewise.
6509         (store_regs_kernel_thread): Likewise.
6510         (fetch_regs_kernel_thread): Remove shadowed variable.
6511
6512 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6513
6514         * features/riscv/32bit-cpu.xml: Add register numbers.
6515         * features/riscv/32bit-fpu.c: Regenerate.
6516         * features/riscv/32bit-fpu.xml: Add register numbers.
6517         * features/riscv/64bit-cpu.xml: Add register numbers.
6518         * features/riscv/64bit-fpu.c: Regenerate.
6519         * features/riscv/64bit-fpu.xml: Add register numbers.
6520
6521 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6522
6523         * NEWS: Mention two argument form of gdb.Value constructor.
6524         * python/py-value.c (convert_buffer_and_type_to_value): New
6525         function.
6526         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6527         Add support for handling an optional second argument.  Call
6528         convert_buffer_and_type_to_value as appropriate.
6529         * python/python-internal.h (Py_buffer_deleter): New struct.
6530         (Py_buffer_up): New typedef.
6531
6532 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6533
6534         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6535         instead of releasing ownership.
6536
6537 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6538
6539         * dwarf2read.c (open_and_init_dwp_file): Call
6540         elf_numsections instead of bfd_count_sections to initialize
6541         dwp_file->num_sections.
6542
6543 2019-02-25  Tom Tromey  <tromey@adacore.com>
6544
6545         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6546
6547 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6548
6549         * gcore.in: Add '--readnever' option when invoking GDB.
6550
6551 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6552
6553         * MAINTAINERS: Update my email address.
6554
6555 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6556
6557         * build-id.c (build_id_to_debug_bfd_1): New function.
6558         (build_id_to_debug_bfd): Look for separate debug file in
6559         sysroot.
6560
6561 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6562
6563         * gdbarch.sh: Update the copyright year range that is placed into
6564         generated files.
6565
6566 2019-02-22  Keith Seitz  <keiths@redhat.com>
6567
6568         PR symtab/23853
6569         * linespec.c (create_sals_line_offset): Search for the default
6570         symtab's filename instead of its fullname.
6571
6572 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6573
6574         * NEWS: Update style defaults.
6575
6576 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6577
6578         * main.c (captured_main_1): Disable styling in batch mode.
6579
6580 2019-02-20  Tom Tromey  <tom@tromey.com>
6581
6582         * symtab.c (symtab_symbol_info): Fix typos.
6583
6584 2019-02-20  Tom Tromey  <tromey@adacore.com>
6585
6586         * findcmd.c (_initialize_mem_search): Use upper case for
6587         metasyntactic variables.
6588
6589 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6590
6591         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6592         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6593
6594 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6595
6596         * top.h (source_file_name): Change to std::string.
6597         * top.c (source_file_name): Likewise.
6598         (command_line_input): Adjust.
6599         * cli/cli-script.c (script_from_file): Adjust.
6600
6601 2019-02-19  Tom Tromey  <tromey@adacore.com>
6602
6603         * ravenscar-thread.c
6604         (ravenscar_thread_target::update_thread_list): Don't call
6605         ada_build_task_list.
6606         * ada-lang.h (ada_build_task_list): Don't declare.
6607         * ada-tasks.c (struct ada_tasks_inferior_data)
6608         <task_list_valid_p>: Now bool.
6609         (read_known_tasks, ada_task_list_changed)
6610         (ada_tasks_invalidate_inferior_data): Update.
6611         (read_known_tasks_array): Return bool.
6612         (read_known_tasks_list): Likewise.
6613         (read_known_tasks): Return void.
6614         (ada_build_task_list): Now static.
6615
6616 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6617
6618         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6619         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6620
6621 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6622
6623         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6624         variant for ada_tasks_pspace_data_handle and
6625         ada_tasks_inferior_data_handle.
6626         (ada_tasks_pspace_data_cleanup): New function.
6627         (ada_tasks_inferior_data_cleanup): New function.
6628
6629 2019-02-17  Tom Tromey  <tom@tromey.com>
6630
6631         * macrotab.h (macro_source_fullname): Return a std::string.
6632         * macrotab.c (macro_include, check_for_redefinition)
6633         (macro_undef, macro_lookup_definition, foreach_macro)
6634         (foreach_macro_in_scope): Update.
6635         (macro_source_fullname): Return a std::string.
6636         * macrocmd.c (show_pp_source_pos): Update.
6637
6638 2019-02-17  Tom Tromey  <tom@tromey.com>
6639
6640         * macrocmd.c (show_pp_source_pos): Style the file names.
6641
6642 2019-02-17  Tom Tromey  <tom@tromey.com>
6643
6644         PR tui/24197:
6645         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6646
6647 2019-02-17  Tom Tromey  <tom@tromey.com>
6648
6649         * ada-lang.c (user_select_syms): Use filtered printing.
6650         * utils.c (wrap_style): New global.
6651         (desired_style): Remove.
6652         (emit_style_escape): Add stream parameter.
6653         (set_output_style, reset_terminal_style, prompt_for_continue):
6654         Update.
6655         (flush_wrap_buffer): Only flush gdb_stdout.
6656         (wrap_here): Set wrap_style.
6657         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6658         treat escape sequences as a character.  Change when wrap buffer is
6659         flushed.
6660         (fputs_styled): Do not set the output style when the default is
6661         requested.
6662         * ui-style.h (struct ui_file_style) <is_default>: New method.
6663         * source.c (print_source_lines_base): Emit escape sequences in one
6664         piece.
6665
6666 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6667
6668         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6669         integers and enumeration types.
6670
6671 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6672
6673         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6674         instead of lookup_symbol_in_language
6675         (do_exact_match): New function.
6676         (ada_get_symbol_name_matcher): Return do_exact_match when
6677         doing a verbatim match.
6678
6679 2019-02-15  Tom Tromey  <tromey@adacore.com>
6680
6681         * ravenscar-thread.c (ravenscar_thread_target::resume)
6682         (ravenscar_thread_target::wait): Special case wildcard requests.
6683
6684 2019-02-15  Tom Tromey  <tromey@adacore.com>
6685
6686         * ravenscar-thread.c (base_ptid): Remove.
6687         (struct ravenscar_thread_target) <close>: New method.
6688         <m_base_ptid>: New member.
6689         <update_inferior_ptid, active_task, task_is_currently_active,
6690         runtime_initialized>: Declare methods.
6691         <ravenscar_thread_target>: Add constructor.
6692         (ravenscar_thread_target::task_is_currently_active)
6693         (ravenscar_thread_target::update_inferior_ptid)
6694         (ravenscar_runtime_initialized): Rename.  Now methods.
6695         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6696         (ravenscar_thread_target::update_thread_list): Update.
6697         (ravenscar_thread_target::active_task): Now method.
6698         (ravenscar_thread_target::store_registers)
6699         (ravenscar_thread_target::prepare_to_store)
6700         (ravenscar_thread_target::prepare_to_store)
6701         (ravenscar_thread_target::mourn_inferior): Update.
6702         (ravenscar_inferior_created): Use "new" to create target.
6703         (ravenscar_thread_target::get_ada_task_ptid): Update.
6704         (_initialize_ravenscar): Don't initialize base_ptid.
6705         (ravenscar_ops): Remove global.
6706
6707 2019-02-15  Tom Tromey  <tromey@adacore.com>
6708
6709         * target.h (push_target): Declare new overload.
6710         * target.c (push_target): New overload, taking an rvalue reference.
6711         * remote.c (remote_target::open_1): Use push_target overload.
6712         * corelow.c (core_target_open): Use push_target overload.
6713
6714 2019-02-15  Tom Tromey  <tromey@adacore.com>
6715
6716         * ravenscar-thread.c (is_ravenscar_task)
6717         (ravenscar_task_is_currently_active): Return bool.
6718         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6719         (_initialize_ravenscar): Remove "(void)".
6720         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6721         Return bool.
6722
6723 2019-02-15  Tom Tromey  <tromey@adacore.com>
6724
6725         * ravenscar-thread.c (ravenscar_runtime_initializer)
6726         (has_ravenscar_runtime, get_running_thread_id)
6727         (ravenscar_thread_target::resume): Fix indentation.
6728
6729 2019-02-15  Tom Tromey  <tromey@adacore.com>
6730
6731         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6732         from ravenscar_arch_ops.
6733         (sparc_ravenscar_ops::fetch_registers)
6734         (sparc_ravenscar_ops::store_registers): Now methods.
6735         (sparc_ravenscar_prepare_to_store): Remove.
6736         (sparc_ravenscar_ops): Redefine.
6737         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6738         methods and destructor.  Remove members.
6739         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6740         (ravenscar_thread_target::store_registers)
6741         (ravenscar_thread_target::prepare_to_store): Update.
6742         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6743         Remove.
6744         (struct ppc_ravenscar_powerpc_ops): Derive from
6745         ravenscar_arch_ops.
6746         (ppc_ravenscar_powerpc_ops::fetch_registers)
6747         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6748         (ppc_ravenscar_powerpc_ops): Redefine.
6749         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6750         (ppc_ravenscar_e500_ops::fetch_registers)
6751         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6752         (ppc_ravenscar_e500_ops): Redefine.
6753         * aarch64-ravenscar-thread.c
6754         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6755         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6756         (aarch64_ravenscar_fetch_registers)
6757         (aarch64_ravenscar_store_registers): Now methods.
6758         (aarch64_ravenscar_ops): Redefine.
6759
6760 2019-02-15  Tom Tromey  <tromey@adacore.com>
6761
6762         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6763         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6764         (ravenscar_thread_target::stopped_by_watchpoint)
6765         (ravenscar_thread_target::stopped_data_address)
6766         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6767
6768 2019-02-15  Tom Tromey  <tromey@adacore.com>
6769
6770         * ravenscar-thread.c: Fix some typos.
6771
6772 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6773             Tom Tromey  <tromey@adacore.com>
6774
6775         * ada-lang.c (ada_exception_sal): Change addr_string to a
6776         std::string.
6777         (create_ada_exception_catchpoint): Update.
6778
6779 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6780             Tom Tromey  <tromey@adacore.com>
6781
6782         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6783         (bp_location_ops): Remove.
6784         (base_breakpoint_allocate_location): Update.
6785         (free_bp_location): Update.
6786         * ada-lang.c (class ada_catchpoint_location)
6787         <ada_catchpoint_location>: Remove ops parameter.
6788         (ada_catchpoint_location_dtor): Remove.
6789         (ada_catchpoint_location_ops): Remove.
6790         (allocate_location_exception): Update.
6791         * breakpoint.h (struct bp_location_ops): Remove.
6792         (class bp_location) <bp_location>: Remove bp_location_ops
6793         parameter.
6794         <~bp_location>: Add destructor.
6795         <ops>: Remove.
6796
6797 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6798             Pedro Alves  <palves@redhat.com>
6799
6800         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6801         'PATH_MAX'.
6802
6803 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6804             Samuel Thibault  <samuel.thibault@gnu.org>
6805             Thomas Schwinge  <thomas@codesourcery.com>
6806
6807         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6808         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6809
6810 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6811
6812         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6813         (check_empty): Use "const char *".
6814
6815         * gnu-nat.c (gnu_nat_target::detach): Instead of
6816         'detach_inferior (pid)' call
6817         'detach_inferior (find_inferior_pid (pid))'.
6818
6819         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6820         'nat/fork-inferior.o'.
6821         * gnu-nat.c: #include "nat/fork-inferior.h".
6822
6823         * gnu-nat.c (gnu_nat_target::detach): Instead of
6824         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6825         * gnu-nat.h: #include "inf-child.h".
6826         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6827         'i386_gnu_nat_target::fetch_registers'.
6828         (gnu_store_registers): Rename/move to
6829         'i386_gnu_nat_target::store_registers'.
6830
6831         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6832         * gnu-nat.h (mach_thread_info): New function.
6833         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6834
6835         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6836
6837 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6838
6839         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6840
6841 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6842
6843         * windows-nat.c (windows_add_thread): Add new parameter
6844         "main_thread_p" with default value set to false.  Update
6845         function documentation as well as all callers.
6846         (windows_delete_thread): Likewise.
6847         (fake_create_process): Update call to windows_add_thread.
6848         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6849         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6850         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6851         call to windows_delete_thread.
6852
6853 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6854
6855         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6856
6857 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6858
6859         * symfile.c (find_separate_debug_file): Use canonical path of
6860         sysroot with child_path instead of gdb_sysroot if it is valid.
6861
6862 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6863
6864         * symfile.c (find_separate_debug_file): Use child_path to
6865         determine if an object file is under a sysroot.
6866
6867 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6868
6869         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6870         unittests/child-path-selftests.c.
6871         * common/pathstuff.c (child_path): New function.
6872         * common/pathstuff.h (child_path): New prototype.
6873         * unittests/child-path-selftests.c: New file.
6874
6875 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6876
6877         * symfile.c (find_separate_debug_file): Look for separate debug
6878         files in debug directories under the sysroot.
6879
6880 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6881
6882         * symtab.h (struct minimal_symbol data_p): New const method.
6883         (struct minimal_symbol text_p): Likewise.
6884         * symtab.c (output_source_filename): Use file name style
6885         to print file name.
6886         (print_symbol_info): Likewise.
6887         (print_msymbol_info): Use address style to print addresses.
6888         Use function name style to print executable text symbols.
6889         (expand_symtab_containing_pc): Use data_p.
6890         (find_pc_sect_compunit_symtab): Likewise.
6891
6892 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6893
6894         * breakpoint.c (describe_other_breakpoints): Use address style
6895         to print addresses.
6896         (say_where): Likewise.
6897
6898 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6899
6900         * ada-typeprint.c (print_func_type): Print function name
6901         style to print function name.
6902         * c-typeprint.c (c_print_type_1): Likewise.
6903
6904 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6905
6906         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6907         for execve.
6908
6909 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6910
6911         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6912         type_stack.
6913
6914 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6915
6916         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6917         TYPE_CODE_REF types.
6918
6919 2019-02-08  Jim Wilson  <jimw@sifive.com>
6920
6921         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6922         (riscv_linux_fregset): New.
6923         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6924
6925 2019-02-07  Tom Tromey  <tom@tromey.com>
6926
6927         * thread.c (thread_cancel_execution_command): Update.
6928         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6929         methods.
6930         (struct thread_fsm_ops): Remove.
6931         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6932         (thread_fsm_should_stop, thread_fsm_return_value)
6933         (thread_fsm_set_finished, thread_fsm_finished_p)
6934         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6935         Don't declare.
6936         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6937         * infrun.c (clear_proceed_status_thread)
6938         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6939         (print_stop_event): Update.
6940         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6941         Add constructor.
6942         (step_command_fsm_ops): Remove.
6943         (new_step_command_fsm): Remove.
6944         (step_1): Update.
6945         (step_command_fsm::should_stop): Rename from
6946         step_command_fsm_should_stop.
6947         (step_command_fsm::clean_up): Rename from
6948         step_command_fsm_clean_up.
6949         (step_command_fsm::do_async_reply_reason): Rename from
6950         step_command_fsm_async_reply_reason.
6951         (struct until_next_fsm): Inherit from thread_fsm.  Add
6952         constructor.
6953         (until_next_fsm_ops): Remove.
6954         (new_until_next_fsm): Remove.
6955         (until_next_fsm::should_stop): Rename from
6956         until_next_fsm_should_stop.
6957         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6958         (until_next_fsm::do_async_reply_reason): Rename from
6959         until_next_fsm_async_reply_reason.
6960         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6961         constructor.  Change type of breakpoint.
6962         (finish_command_fsm_ops): Remove.
6963         (new_finish_command_fsm): Remove.
6964         (finish_command_fsm::should_stop): Rename from
6965         finish_command_fsm_should_stop.
6966         (finish_command_fsm::clean_up): Rename from
6967         finish_command_fsm_clean_up.
6968         (finish_command_fsm::return_value): Rename from
6969         finish_command_fsm_return_value.
6970         (finish_command_fsm::do_async_reply_reason): Rename from
6971         finish_command_fsm_async_reply_reason.
6972         (finish_command): Update.
6973         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6974         Add constructor.
6975         (call_thread_fsm_ops): Remove.
6976         (call_thread_fsm::call_thread_fsm): Rename from
6977         new_call_thread_fsm.
6978         (call_thread_fsm::should_stop): Rename from
6979         call_thread_fsm_should_stop.
6980         (call_thread_fsm::should_notify_stop): Rename from
6981         call_thread_fsm_should_notify_stop.
6982         (run_inferior_call, call_function_by_hand_dummy): Update.
6983         * cli/cli-interp.c (should_print_stop_to_console): Update.
6984         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6985         Add constructor.  Change type of location_breakpoint,
6986         caller_breakpoint.
6987         (until_break_fsm_ops): Remove.
6988         (new_until_break_fsm): Remove.
6989         (until_break_fsm::should_stop): Rename from
6990         until_break_fsm_should_stop.
6991         (until_break_fsm::clean_up): Rename from
6992         until_break_fsm_clean_up.
6993         (until_break_fsm::do_async_reply_reason): Rename from
6994         until_break_fsm_async_reply_reason.
6995         (until_break_command): Update.
6996         * thread-fsm.c: Remove.
6997         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6998
6999 2019-02-07  Tom Tromey  <tom@tromey.com>
7000
7001         * yy-remap.h: Add include guard.
7002         * xtensa-tdep.h: Add include guard.
7003         * xcoffread.h: Rename include guard.
7004         * varobj-iter.h: Add include guard.
7005         * tui/tui.h: Rename include guard.
7006         * tui/tui-winsource.h: Rename include guard.
7007         * tui/tui-wingeneral.h: Rename include guard.
7008         * tui/tui-windata.h: Rename include guard.
7009         * tui/tui-win.h: Rename include guard.
7010         * tui/tui-stack.h: Rename include guard.
7011         * tui/tui-source.h: Rename include guard.
7012         * tui/tui-regs.h: Rename include guard.
7013         * tui/tui-out.h: Rename include guard.
7014         * tui/tui-layout.h: Rename include guard.
7015         * tui/tui-io.h: Rename include guard.
7016         * tui/tui-hooks.h: Rename include guard.
7017         * tui/tui-file.h: Rename include guard.
7018         * tui/tui-disasm.h: Rename include guard.
7019         * tui/tui-data.h: Rename include guard.
7020         * tui/tui-command.h: Rename include guard.
7021         * tic6x-tdep.h: Add include guard.
7022         * target/waitstatus.h: Rename include guard.
7023         * target/wait.h: Rename include guard.
7024         * target/target.h: Rename include guard.
7025         * target/resume.h: Rename include guard.
7026         * target-float.h: Rename include guard.
7027         * stabsread.h: Add include guard.
7028         * rs6000-tdep.h: Add include guard.
7029         * riscv-fbsd-tdep.h: Add include guard.
7030         * regformats/regdef.h: Rename include guard.
7031         * record.h: Rename include guard.
7032         * python/python.h: Rename include guard.
7033         * python/python-internal.h: Rename include guard.
7034         * python/py-stopevent.h: Rename include guard.
7035         * python/py-ref.h: Rename include guard.
7036         * python/py-record.h: Rename include guard.
7037         * python/py-record-full.h: Rename include guard.
7038         * python/py-record-btrace.h: Rename include guard.
7039         * python/py-instruction.h: Rename include guard.
7040         * python/py-events.h: Rename include guard.
7041         * python/py-event.h: Rename include guard.
7042         * procfs.h: Add include guard.
7043         * proc-utils.h: Add include guard.
7044         * p-lang.h: Add include guard.
7045         * or1k-tdep.h: Rename include guard.
7046         * observable.h: Rename include guard.
7047         * nto-tdep.h: Rename include guard.
7048         * nat/x86-linux.h: Rename include guard.
7049         * nat/x86-linux-dregs.h: Rename include guard.
7050         * nat/x86-gcc-cpuid.h: Add include guard.
7051         * nat/x86-dregs.h: Rename include guard.
7052         * nat/x86-cpuid.h: Rename include guard.
7053         * nat/ppc-linux.h: Rename include guard.
7054         * nat/mips-linux-watch.h: Rename include guard.
7055         * nat/linux-waitpid.h: Rename include guard.
7056         * nat/linux-ptrace.h: Rename include guard.
7057         * nat/linux-procfs.h: Rename include guard.
7058         * nat/linux-osdata.h: Rename include guard.
7059         * nat/linux-nat.h: Rename include guard.
7060         * nat/linux-namespaces.h: Rename include guard.
7061         * nat/linux-btrace.h: Rename include guard.
7062         * nat/glibc_thread_db.h: Rename include guard.
7063         * nat/gdb_thread_db.h: Rename include guard.
7064         * nat/gdb_ptrace.h: Rename include guard.
7065         * nat/fork-inferior.h: Rename include guard.
7066         * nat/amd64-linux-siginfo.h: Rename include guard.
7067         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7068         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7069         * nat/aarch64-linux.h: Rename include guard.
7070         * nat/aarch64-linux-hw-point.h: Rename include guard.
7071         * mn10300-tdep.h: Add include guard.
7072         * mips-linux-tdep.h: Add include guard.
7073         * mi/mi-parse.h: Rename include guard.
7074         * mi/mi-out.h: Rename include guard.
7075         * mi/mi-main.h: Rename include guard.
7076         * mi/mi-interp.h: Rename include guard.
7077         * mi/mi-getopt.h: Rename include guard.
7078         * mi/mi-console.h: Rename include guard.
7079         * mi/mi-common.h: Rename include guard.
7080         * mi/mi-cmds.h: Rename include guard.
7081         * mi/mi-cmd-break.h: Rename include guard.
7082         * m2-lang.h: Add include guard.
7083         * location.h: Rename include guard.
7084         * linux-record.h: Rename include guard.
7085         * linux-nat.h: Add include guard.
7086         * linux-fork.h: Add include guard.
7087         * i386-darwin-tdep.h: Rename include guard.
7088         * hppa-linux-offsets.h: Add include guard.
7089         * guile/guile.h: Rename include guard.
7090         * guile/guile-internal.h: Rename include guard.
7091         * gnu-nat.h: Rename include guard.
7092         * gdb-stabs.h: Rename include guard.
7093         * frv-tdep.h: Add include guard.
7094         * f-lang.h: Add include guard.
7095         * event-loop.h: Add include guard.
7096         * darwin-nat.h: Rename include guard.
7097         * cp-abi.h: Rename include guard.
7098         * config/sparc/nm-sol2.h: Rename include guard.
7099         * config/nm-nto.h: Rename include guard.
7100         * config/nm-linux.h: Add include guard.
7101         * config/i386/nm-i386gnu.h: Rename include guard.
7102         * config/djgpp/nl_types.h: Rename include guard.
7103         * config/djgpp/langinfo.h: Rename include guard.
7104         * compile/gcc-cp-plugin.h: Add include guard.
7105         * compile/gcc-c-plugin.h: Add include guard.
7106         * compile/compile.h: Rename include guard.
7107         * compile/compile-object-run.h: Rename include guard.
7108         * compile/compile-object-load.h: Rename include guard.
7109         * compile/compile-internal.h: Rename include guard.
7110         * compile/compile-cplus.h: Rename include guard.
7111         * compile/compile-c.h: Rename include guard.
7112         * common/xml-utils.h: Rename include guard.
7113         * common/x86-xstate.h: Rename include guard.
7114         * common/version.h: Rename include guard.
7115         * common/vec.h: Rename include guard.
7116         * common/tdesc.h: Rename include guard.
7117         * common/selftest.h: Rename include guard.
7118         * common/scoped_restore.h: Rename include guard.
7119         * common/scoped_mmap.h: Rename include guard.
7120         * common/scoped_fd.h: Rename include guard.
7121         * common/safe-iterator.h: Rename include guard.
7122         * common/run-time-clock.h: Rename include guard.
7123         * common/refcounted-object.h: Rename include guard.
7124         * common/queue.h: Rename include guard.
7125         * common/ptid.h: Rename include guard.
7126         * common/print-utils.h: Rename include guard.
7127         * common/preprocessor.h: Rename include guard.
7128         * common/pathstuff.h: Rename include guard.
7129         * common/observable.h: Rename include guard.
7130         * common/netstuff.h: Rename include guard.
7131         * common/job-control.h: Rename include guard.
7132         * common/host-defs.h: Rename include guard.
7133         * common/gdb_wait.h: Rename include guard.
7134         * common/gdb_vecs.h: Rename include guard.
7135         * common/gdb_unlinker.h: Rename include guard.
7136         * common/gdb_unique_ptr.h: Rename include guard.
7137         * common/gdb_tilde_expand.h: Rename include guard.
7138         * common/gdb_sys_time.h: Rename include guard.
7139         * common/gdb_string_view.h: Rename include guard.
7140         * common/gdb_splay_tree.h: Rename include guard.
7141         * common/gdb_setjmp.h: Rename include guard.
7142         * common/gdb_ref_ptr.h: Rename include guard.
7143         * common/gdb_optional.h: Rename include guard.
7144         * common/gdb_locale.h: Rename include guard.
7145         * common/gdb_assert.h: Rename include guard.
7146         * common/filtered-iterator.h: Rename include guard.
7147         * common/filestuff.h: Rename include guard.
7148         * common/fileio.h: Rename include guard.
7149         * common/environ.h: Rename include guard.
7150         * common/common-utils.h: Rename include guard.
7151         * common/common-types.h: Rename include guard.
7152         * common/common-regcache.h: Rename include guard.
7153         * common/common-inferior.h: Rename include guard.
7154         * common/common-gdbthread.h: Rename include guard.
7155         * common/common-exceptions.h: Rename include guard.
7156         * common/common-defs.h: Rename include guard.
7157         * common/common-debug.h: Rename include guard.
7158         * common/cleanups.h: Rename include guard.
7159         * common/buffer.h: Rename include guard.
7160         * common/btrace-common.h: Rename include guard.
7161         * common/break-common.h: Rename include guard.
7162         * cli/cli-utils.h: Rename include guard.
7163         * cli/cli-style.h: Rename include guard.
7164         * cli/cli-setshow.h: Rename include guard.
7165         * cli/cli-script.h: Rename include guard.
7166         * cli/cli-interp.h: Rename include guard.
7167         * cli/cli-decode.h: Rename include guard.
7168         * cli/cli-cmds.h: Rename include guard.
7169         * charset-list.h: Add include guard.
7170         * buildsym-legacy.h: Rename include guard.
7171         * bfin-tdep.h: Add include guard.
7172         * ax.h: Rename include guard.
7173         * arm-linux-tdep.h: Add include guard.
7174         * arm-fbsd-tdep.h: Add include guard.
7175         * arch/xtensa.h: Rename include guard.
7176         * arch/tic6x.h: Add include guard.
7177         * arch/i386.h: Add include guard.
7178         * arch/arm.h: Rename include guard.
7179         * arch/arm-linux.h: Rename include guard.
7180         * arch/arm-get-next-pcs.h: Rename include guard.
7181         * arch/amd64.h: Add include guard.
7182         * arch/aarch64-insn.h: Rename include guard.
7183         * arch-utils.h: Rename include guard.
7184         * annotate.h: Add include guard.
7185         * amd64-darwin-tdep.h: Rename include guard.
7186         * aarch64-linux-tdep.h: Add include guard.
7187         * aarch64-fbsd-tdep.h: Add include guard.
7188         * aarch32-linux-nat.h: Add include guard.
7189
7190 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7191
7192         * macrotab.c (macro_define_internal): New function that
7193         factorizes macro_define_object_internal and macro_define_function
7194         code.
7195         (macro_define_object_internal): Use macro_define_internal.
7196         (macro_define_function): Likewise.
7197
7198 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7199
7200         * macrocmd.c (extract_identifier): Return
7201         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7202         callers.
7203
7204 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7205
7206         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7207
7208 2019-02-05  Tom Tromey  <tom@tromey.com>
7209
7210         * target.c (target_stack::unpush): Move assertion earlier.
7211
7212 2019-01-30  Tom Tromey  <tom@tromey.com>
7213
7214         PR python/23615:
7215         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7216         (gdbpy_parse_and_eval): Likewise.
7217         * python/python-internal.h (gdbpy_allow_threads): New class.
7218
7219 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7220
7221         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7222         (aarch64_fbsd_fpregmap): Move earlier.
7223         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7224         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7225         instead of individual calls to trad_frame_set_reg_addr.
7226         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7227         earlier.
7228         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7229         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7230         instead of individual calls to trad_frame_set_reg_addr.
7231
7232 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7233
7234         * CONTRIBUTE: Replace contribution list with wiki link.
7235
7236 2019-01-25  Tom Tromey  <tom@tromey.com>
7237
7238         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7239
7240 2019-01-25  Tom Tromey  <tom@tromey.com>
7241
7242         * xtensa-linux-nat.c: Fix common/ includes.
7243         * xml-support.h: Fix common/ includes.
7244         * xml-support.c: Fix common/ includes.
7245         * x86-linux-nat.c: Fix common/ includes.
7246         * windows-nat.c: Fix common/ includes.
7247         * varobj.h: Fix common/ includes.
7248         * varobj.c: Fix common/ includes.
7249         * value.c: Fix common/ includes.
7250         * valops.c: Fix common/ includes.
7251         * utils.c: Fix common/ includes.
7252         * unittests/xml-utils-selftests.c: Fix common/ includes.
7253         * unittests/utils-selftests.c: Fix common/ includes.
7254         * unittests/unpack-selftests.c: Fix common/ includes.
7255         * unittests/tracepoint-selftests.c: Fix common/ includes.
7256         * unittests/style-selftests.c: Fix common/ includes.
7257         * unittests/string_view-selftests.c: Fix common/ includes.
7258         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7259         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7260         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7261         * unittests/rsp-low-selftests.c: Fix common/ includes.
7262         * unittests/parse-connection-spec-selftests.c: Fix common/
7263         includes.
7264         * unittests/optional-selftests.c: Fix common/ includes.
7265         * unittests/offset-type-selftests.c: Fix common/ includes.
7266         * unittests/observable-selftests.c: Fix common/ includes.
7267         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7268         * unittests/memrange-selftests.c: Fix common/ includes.
7269         * unittests/memory-map-selftests.c: Fix common/ includes.
7270         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7271         * unittests/function-view-selftests.c: Fix common/ includes.
7272         * unittests/environ-selftests.c: Fix common/ includes.
7273         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7274         * unittests/common-utils-selftests.c: Fix common/ includes.
7275         * unittests/cli-utils-selftests.c: Fix common/ includes.
7276         * unittests/array-view-selftests.c: Fix common/ includes.
7277         * ui-file.c: Fix common/ includes.
7278         * tui/tui-io.c: Fix common/ includes.
7279         * tracepoint.h: Fix common/ includes.
7280         * tracepoint.c: Fix common/ includes.
7281         * tracefile-tfile.c: Fix common/ includes.
7282         * top.h: Fix common/ includes.
7283         * top.c: Fix common/ includes.
7284         * thread.c: Fix common/ includes.
7285         * target/waitstatus.h: Fix common/ includes.
7286         * target/waitstatus.c: Fix common/ includes.
7287         * target.h: Fix common/ includes.
7288         * target.c: Fix common/ includes.
7289         * target-memory.c: Fix common/ includes.
7290         * target-descriptions.c: Fix common/ includes.
7291         * symtab.h: Fix common/ includes.
7292         * symfile.c: Fix common/ includes.
7293         * stap-probe.c: Fix common/ includes.
7294         * spu-linux-nat.c: Fix common/ includes.
7295         * sparc-nat.c: Fix common/ includes.
7296         * source.c: Fix common/ includes.
7297         * solib.c: Fix common/ includes.
7298         * solib-target.c: Fix common/ includes.
7299         * ser-unix.c: Fix common/ includes.
7300         * ser-tcp.c: Fix common/ includes.
7301         * ser-pipe.c: Fix common/ includes.
7302         * ser-base.c: Fix common/ includes.
7303         * selftest-arch.c: Fix common/ includes.
7304         * s12z-tdep.c: Fix common/ includes.
7305         * rust-exp.y: Fix common/ includes.
7306         * rs6000-aix-tdep.c: Fix common/ includes.
7307         * riscv-tdep.c: Fix common/ includes.
7308         * remote.c: Fix common/ includes.
7309         * remote-notif.h: Fix common/ includes.
7310         * remote-fileio.h: Fix common/ includes.
7311         * remote-fileio.c: Fix common/ includes.
7312         * regcache.h: Fix common/ includes.
7313         * regcache.c: Fix common/ includes.
7314         * record-btrace.c: Fix common/ includes.
7315         * python/python.c: Fix common/ includes.
7316         * python/py-type.c: Fix common/ includes.
7317         * python/py-inferior.c: Fix common/ includes.
7318         * progspace.h: Fix common/ includes.
7319         * producer.c: Fix common/ includes.
7320         * procfs.c: Fix common/ includes.
7321         * proc-api.c: Fix common/ includes.
7322         * printcmd.c: Fix common/ includes.
7323         * ppc-linux-nat.c: Fix common/ includes.
7324         * parser-defs.h: Fix common/ includes.
7325         * osdata.c: Fix common/ includes.
7326         * obsd-nat.c: Fix common/ includes.
7327         * nat/x86-linux.c: Fix common/ includes.
7328         * nat/x86-linux-dregs.c: Fix common/ includes.
7329         * nat/x86-dregs.h: Fix common/ includes.
7330         * nat/x86-dregs.c: Fix common/ includes.
7331         * nat/ppc-linux.c: Fix common/ includes.
7332         * nat/mips-linux-watch.h: Fix common/ includes.
7333         * nat/mips-linux-watch.c: Fix common/ includes.
7334         * nat/linux-waitpid.c: Fix common/ includes.
7335         * nat/linux-ptrace.h: Fix common/ includes.
7336         * nat/linux-ptrace.c: Fix common/ includes.
7337         * nat/linux-procfs.c: Fix common/ includes.
7338         * nat/linux-personality.c: Fix common/ includes.
7339         * nat/linux-osdata.c: Fix common/ includes.
7340         * nat/linux-namespaces.c: Fix common/ includes.
7341         * nat/linux-btrace.h: Fix common/ includes.
7342         * nat/linux-btrace.c: Fix common/ includes.
7343         * nat/fork-inferior.c: Fix common/ includes.
7344         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7345         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7346         * nat/aarch64-linux.c: Fix common/ includes.
7347         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7348         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7349         * namespace.h: Fix common/ includes.
7350         * mips-linux-tdep.c: Fix common/ includes.
7351         * minsyms.c: Fix common/ includes.
7352         * mi/mi-parse.h: Fix common/ includes.
7353         * mi/mi-main.c: Fix common/ includes.
7354         * mi/mi-cmd-env.c: Fix common/ includes.
7355         * memrange.h: Fix common/ includes.
7356         * memattr.c: Fix common/ includes.
7357         * maint.h: Fix common/ includes.
7358         * maint.c: Fix common/ includes.
7359         * main.c: Fix common/ includes.
7360         * machoread.c: Fix common/ includes.
7361         * location.c: Fix common/ includes.
7362         * linux-thread-db.c: Fix common/ includes.
7363         * linux-nat.c: Fix common/ includes.
7364         * linux-fork.c: Fix common/ includes.
7365         * inline-frame.c: Fix common/ includes.
7366         * infrun.c: Fix common/ includes.
7367         * inflow.c: Fix common/ includes.
7368         * inferior.h: Fix common/ includes.
7369         * inferior.c: Fix common/ includes.
7370         * infcmd.c: Fix common/ includes.
7371         * inf-ptrace.c: Fix common/ includes.
7372         * inf-child.c: Fix common/ includes.
7373         * ia64-linux-nat.c: Fix common/ includes.
7374         * i387-tdep.c: Fix common/ includes.
7375         * i386-tdep.c: Fix common/ includes.
7376         * i386-linux-tdep.c: Fix common/ includes.
7377         * i386-linux-nat.c: Fix common/ includes.
7378         * i386-go32-tdep.c: Fix common/ includes.
7379         * i386-fbsd-tdep.c: Fix common/ includes.
7380         * i386-fbsd-nat.c: Fix common/ includes.
7381         * guile/scm-type.c: Fix common/ includes.
7382         * guile/guile.c: Fix common/ includes.
7383         * go32-nat.c: Fix common/ includes.
7384         * gnu-nat.c: Fix common/ includes.
7385         * gdbthread.h: Fix common/ includes.
7386         * gdbarch-selftests.c: Fix common/ includes.
7387         * gdb_usleep.c: Fix common/ includes.
7388         * gdb_select.h: Fix common/ includes.
7389         * gdb_bfd.c: Fix common/ includes.
7390         * gcore.c: Fix common/ includes.
7391         * fork-child.c: Fix common/ includes.
7392         * findvar.c: Fix common/ includes.
7393         * fbsd-nat.c: Fix common/ includes.
7394         * event-top.c: Fix common/ includes.
7395         * event-loop.c: Fix common/ includes.
7396         * dwarf2read.c: Fix common/ includes.
7397         * dwarf2loc.c: Fix common/ includes.
7398         * dwarf2-frame.c: Fix common/ includes.
7399         * dwarf-index-cache.c: Fix common/ includes.
7400         * dtrace-probe.c: Fix common/ includes.
7401         * disasm-selftests.c: Fix common/ includes.
7402         * defs.h: Fix common/ includes.
7403         * csky-tdep.c: Fix common/ includes.
7404         * cp-valprint.c: Fix common/ includes.
7405         * cp-support.h: Fix common/ includes.
7406         * cp-support.c: Fix common/ includes.
7407         * corelow.c: Fix common/ includes.
7408         * completer.h: Fix common/ includes.
7409         * completer.c: Fix common/ includes.
7410         * compile/compile.c: Fix common/ includes.
7411         * compile/compile-loc2c.c: Fix common/ includes.
7412         * compile/compile-cplus-types.c: Fix common/ includes.
7413         * compile/compile-cplus-symbols.c: Fix common/ includes.
7414         * command.h: Fix common/ includes.
7415         * cli/cli-dump.c: Fix common/ includes.
7416         * cli/cli-cmds.c: Fix common/ includes.
7417         * charset.c: Fix common/ includes.
7418         * build-id.c: Fix common/ includes.
7419         * btrace.h: Fix common/ includes.
7420         * btrace.c: Fix common/ includes.
7421         * breakpoint.h: Fix common/ includes.
7422         * breakpoint.c: Fix common/ includes.
7423         * ax.h:
7424         (enum agent_op): Fix common/ includes.
7425         * ax-general.c (struct aop_map): Fix common/ includes.
7426         * ax-gdb.c: Fix common/ includes.
7427         * auxv.c: Fix common/ includes.
7428         * auto-load.c: Fix common/ includes.
7429         * arm-tdep.c: Fix common/ includes.
7430         * arch/riscv.c: Fix common/ includes.
7431         * arch/ppc-linux-common.c: Fix common/ includes.
7432         * arch/i386.c: Fix common/ includes.
7433         * arch/arm.c: Fix common/ includes.
7434         * arch/arm-linux.c: Fix common/ includes.
7435         * arch/arm-get-next-pcs.c: Fix common/ includes.
7436         * arch/amd64.c: Fix common/ includes.
7437         * arch/aarch64.c: Fix common/ includes.
7438         * arch/aarch64-insn.c: Fix common/ includes.
7439         * arch-utils.c: Fix common/ includes.
7440         * amd64-windows-tdep.c: Fix common/ includes.
7441         * amd64-tdep.c: Fix common/ includes.
7442         * amd64-sol2-tdep.c: Fix common/ includes.
7443         * amd64-obsd-tdep.c: Fix common/ includes.
7444         * amd64-nbsd-tdep.c: Fix common/ includes.
7445         * amd64-linux-tdep.c: Fix common/ includes.
7446         * amd64-linux-nat.c: Fix common/ includes.
7447         * amd64-fbsd-tdep.c: Fix common/ includes.
7448         * amd64-fbsd-nat.c: Fix common/ includes.
7449         * amd64-dicos-tdep.c: Fix common/ includes.
7450         * amd64-darwin-tdep.c: Fix common/ includes.
7451         * agent.c: Fix common/ includes.
7452         * ada-lang.h: Fix common/ includes.
7453         * ada-lang.c: Fix common/ includes.
7454         * aarch64-tdep.c: Fix common/ includes.
7455
7456 2019-01-25  Tom Tromey  <tom@tromey.com>
7457
7458         * common/create-version.sh: Use common/version.h.
7459
7460 2019-01-24  Pedro Alves  <palves@redhat.com>
7461
7462         * infrun.c (signal_stop, signal_print, signal_program)
7463         (signal_catch, signal_pass): Now arrays instead of pointers.
7464         (update_signals_program_target, do_target_resume)
7465         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7466         * linux-nat.c (linux_nat_target::pass_signals)
7467         (linux_nat_target::create_inferior, linux_nat_target::attach):
7468         Adjust.
7469         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7470         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7471         * procfs.c (procfs_target::pass_signals): Adjust.
7472         * record-full.c (record_full_target::resume): Adjust.
7473         * remote.c (remote_target::pass_signals)
7474         (remote_target::program_signals): Adjust.
7475         * target-debug.h (target_debug_print_signals): Now takes a
7476         gdb::array_view as parameter.  Adjust.
7477         * target.h (target_ops) <pass_signals, program_signals>: Replace
7478         pointer and length parameters with gdb::array_view.
7479         (target_pass_signals, target_program_signals): Likewise.
7480         * target-delegates.c: Regenerate.
7481
7482 2019-01-24  Pedro Alves  <palves@redhat.com>
7483
7484         * common/forward-scope-exit.h
7485         (forward_scope_exit::forward_scope_exit): Pass arguments to
7486         m_bind_function directly, instead of creating a std::bind and
7487         copying that.
7488
7489 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7490
7491         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7492         for static members.
7493         (pass_in_v_vfp_candidate): Likewise.
7494
7495 2019-01-23  Tom Tromey  <tom@tromey.com>
7496             Pedro Alves  <palves@redhat.com>
7497
7498         * regcache.c (class regcache_invalidator): Remove.
7499         (regcache::raw_write): Use make_scope_exit.
7500
7501 2019-01-23  Tom Tromey  <tom@tromey.com>
7502
7503         * ui-out.h (class ui_out_emit_type): Update comment.
7504
7505 2019-01-23  Tom Tromey  <tom@tromey.com>
7506
7507         * infrun.c (fetch_inferior_event): Update comment.
7508
7509 2019-01-23  Tom Tromey  <tom@tromey.com>
7510             Pedro Alves  <palves@redhat.com>
7511
7512         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7513         parameter.
7514         (fetch_inferior_event): Use SCOPE_EXIT.
7515
7516
7517 2019-01-23  Tom Tromey  <tom@tromey.com>
7518             Pedro Alves  <palves@redhat.com>
7519
7520         * infrun.c (disable_thread_events): Delete.
7521         (stop_all_threads): Use SCOPE_EXIT.
7522
7523 2019-01-23  Tom Tromey  <tom@tromey.com>
7524             Pedro Alves  <palves@redhat.com>
7525
7526         * symfile.c: Include forward-scope-exit.h.
7527         (clear_symtab_users_cleanup): Replace forward declaration with
7528         a FORWARD_SCOPE_EXIT.
7529         (syms_from_objfile_1): Use the forward_scope_exit and
7530         gdb::optional instead of cleanup_function.
7531         (reread_symbols): Use the forward_scope_exit instead of
7532         cleanup_function.
7533         (clear_symtab_users_cleanup): Remove function.
7534
7535 2019-01-23  Tom Tromey  <tom@tromey.com>
7536             Pedro Alves  <palves@redhat.com>
7537
7538         * linux-nat.c: Include scope-exit.h.
7539         (cleanup_target_stop): Remove.
7540         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7541         SCOPE_EXIT.
7542
7543 2019-01-23  Tom Tromey  <tom@tromey.com>
7544             Pedro Alves  <palves@redhat.com>
7545
7546         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7547         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7548
7549 2019-01-23  Tom Tromey  <tom@tromey.com>
7550             Andrew Burgess  <andrew.burgess@embecosm.com>
7551             Pedro Alves  <palves@redhat.com>
7552
7553         * infrun.c (fetch_inferior_event): Use scope_exit.
7554         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7555         * top.c (execute_command): Use scope_exit.
7556         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7557         * utils.c (do_bpstat_clear_actions_cleanup)
7558         (make_bpstat_clear_actions_cleanup): Remove.
7559
7560 2019-01-23  Tom Tromey  <tom@tromey.com>
7561             Pedro Alves  <palves@redhat.com>
7562
7563         * infrun.c: Include "common/scope-exit.h"
7564         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7565         (wait_for_inferior): Use SCOPE_EXIT.
7566         (fetch_inferior_event): Use scope_exit.
7567
7568 2019-01-23  Tom Tromey  <tom@tromey.com>
7569             Pedro Alves  <palves@redhat.com>
7570
7571         * breakpoint.c (create_breakpoint): Remove cleanup.
7572
7573 2019-01-23  Tom Tromey  <tom@tromey.com>
7574             Andrew Burgess  <andrew.burgess@embecosm.com>
7575             Pedro Alves  <palves@redhat.com>
7576
7577 2019-01-23  Pedro Alves  <palves@redhat.com>
7578
7579         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7580
7581 2019-01-23  Pedro Alves  <palves@redhat.com>
7582             Andrew Burgess  <andrew.burgess@embecosm.com>
7583
7584         * gdbthread.h: Include "common/forward-scope-exit.h".
7585         (scoped_finish_thread_state): Redefine custom class in terms of
7586         forward_scope_exit.
7587
7588 2019-01-23  Pedro Alves  <palves@redhat.com>
7589             Andrew Burgess  <andrew.burgess@embecosm.com>
7590
7591         * common/forward-scope-exit.h: New file.
7592
7593 2019-01-23  Pedro Alves  <palves@redhat.com>
7594             Andrew Burgess  <andrew.burgess@embecosm.com>
7595             Tom Tromey  <tom@tromey.com>
7596
7597         * common/scope-exit.h: New file.
7598
7599 2019-01-23  Pedro Alves  <palves@redhat.com>
7600
7601         * common/preprocessor.h (ESC): Rename to ...
7602         (ESC_PARENS): ... this.
7603         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7604         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7605
7606 2019-01-23  Tom Tromey  <tom@tromey.com>
7607
7608         * language.h (class scoped_switch_to_sym_language_if_auto):
7609         Initialize m_lang in both cases.
7610
7611 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7612
7613         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7614         with XCNEW.
7615
7616 2019-01-22  Tom Tromey  <tom@tromey.com>
7617
7618         * corelow.c: Do not include sys/file.h.
7619
7620 2019-01-22  Tom Tromey  <tom@tromey.com>
7621
7622         * tui/tui-wingeneral.h: Include gdb_curses.h.
7623
7624 2019-01-22  Tom Tromey  <tom@tromey.com>
7625
7626         * source-cache.h (class source_cache) <get_source_lines,
7627         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7628
7629 2019-01-22  Tom Tromey  <tom@tromey.com>
7630
7631         * remote-fileio.h (struct remote_target): Declare.
7632
7633 2019-01-22  Tom Tromey  <tom@tromey.com>
7634
7635         * python/py-arch.c: Do not include py-ref.h.
7636         * python/py-bpevent.c: Do not include py-ref.h.
7637         * python/py-cmd.c: Do not include py-ref.h.
7638         * python/py-continueevent.c: Do not include py-ref.h.
7639         * python/py-event.h: Do not include py-ref.h.
7640         * python/py-evtregistry.c: Do not include py-ref.h.
7641         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7642         * python/py-frame.c: Do not include py-ref.h.
7643         * python/py-framefilter.c: Do not include py-ref.h.
7644         * python/py-function.c: Do not include py-ref.h.
7645         * python/py-infevents.c: Do not include py-ref.h.
7646         * python/py-linetable.c: Do not include py-ref.h.
7647         * python/py-objfile.c: Do not include py-ref.h.
7648         * python/py-param.c: Do not include py-ref.h.
7649         * python/py-prettyprint.c: Do not include py-ref.h.
7650         * python/py-progspace.c: Do not include py-ref.h.
7651         * python/py-symbol.c: Do not include py-ref.h.
7652         * python/py-symtab.c: Do not include py-ref.h.
7653         * python/py-type.c: Do not include py-ref.h.
7654         * python/py-unwind.c: Do not include py-ref.h.
7655         * python/py-utils.c: Do not include py-ref.h.
7656         * python/py-value.c: Do not include py-ref.h.
7657         * python/py-varobj.c: Do not include py-ref.h.
7658         * python/py-xmethods.c: Do not include py-ref.h.
7659         * python/python.c: Do not include py-ref.h.
7660         * varobj.c: Do not include py-ref.h.
7661
7662 2019-01-22  Tom Tromey  <tom@tromey.com>
7663
7664         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7665         keyword for bcache.
7666
7667 2019-01-22  Tom Tromey  <tom@tromey.com>
7668
7669         * compile/compile-cplus-types.c: Remove a comment by #include.
7670
7671 2019-01-22  Tom Tromey  <tom@tromey.com>
7672
7673         * compile/gcc-c-plugin.h: Include compile-internal.h.
7674
7675 2019-01-22  Tom Tromey  <tom@tromey.com>
7676
7677         * stabsread.c (EXTERN): Do not define.
7678         (symnum, next_symbol_text_func, processing_gcc_compilation)
7679         (within_function, global_sym_chain, global_stabs)
7680         (previous_stab_code, this_object_header_files)
7681         (n_this_object_header_files)
7682         (n_allocated_this_object_header_files): Define.
7683         * stabsread.h (EXTERN): Never define.  Use "extern".
7684
7685 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7686
7687         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7688         history_value.
7689
7690 2019-01-21  Tom Tromey  <tom@tromey.com>
7691
7692         * ui-out.c: Fix includes.
7693         * tui/tui-source.c: Fix includes.
7694         * target.c: Fix includes.
7695         * remote.c: Fix includes.
7696         * regcache.c: Fix includes.
7697         * python/py-block.c: Fix includes.
7698         * printcmd.c: Fix includes.
7699         * or1k-tdep.c: Fix includes.
7700         * mi/mi-main.c: Fix includes.
7701         * m32r-tdep.c: Fix includes.
7702         * csky-tdep.c: Fix includes.
7703         * compile/compile-cplus-types.c: Fix includes.
7704         * cli/cli-interp.c: Fix includes.
7705
7706 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7707
7708         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7709         for padding.
7710
7711 2019-01-16  Tom Tromey  <tom@tromey.com>
7712
7713         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7714         earlier.
7715         (struct objfile) <msymbols_range>: Move from top level.
7716         <msymbols>: New method.
7717         (class objfile_msymbols): Remove.
7718         * symtab.c (default_collect_symbol_completion_matches_break_on):
7719         Update.
7720         * symmisc.c (dump_msymbols): Update.
7721         * stabsread.c (scan_file_globals): Update.
7722         * objc-lang.c (info_selectors_command, info_classes_command)
7723         (find_methods): Update.
7724         * minsyms.c (find_solib_trampoline_target): Update.
7725         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7726         * coffread.c (coff_symfile_read): Update.
7727         * ada-lang.c (ada_lookup_simple_minsym)
7728         (ada_collect_symbol_completion_matches): Update.
7729
7730 2019-01-16  Tom Tromey  <tom@tromey.com>
7731
7732         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7733         type.  Remove no-argument constructor.
7734         <iterator::operator++>: Simplify.
7735         <begin>: Update.
7736         <end>: Use minimal_symbol_count.
7737
7738 2019-01-16  Tom Tromey  <tom@tromey.com>
7739
7740         * objfiles.h (struct objfile) <psymtabs>: New method.
7741         (class objfile_psymtabs): Remove.
7742         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7743         typedef.
7744         <range>: New method.
7745         (require_partial_symbols): Change return type.
7746         * psymtab.c (require_partial_symbols)
7747         (psym_expand_symtabs_matching): Update.
7748         * mdebugread.c (parse_partial_symbols): Update.
7749         * dbxread.c (dbx_end_psymtab): Update.
7750
7751 2019-01-15  Tom Tromey  <tom@tromey.com>
7752
7753         * symtab.c (lookup_objfile_from_block)
7754         (lookup_symbol_in_objfile_symtabs)
7755         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7756         (find_line_symtab, info_sources_command)
7757         (default_collect_symbol_completion_matches_break_on)
7758         (make_source_files_completion_list): Update.
7759         * symmisc.c (print_objfile_statistics, dump_objfile)
7760         (maintenance_print_symbols, maintenance_info_symtabs)
7761         (maintenance_check_symtabs, maintenance_info_line_tables):
7762         Update.
7763         * source.c (select_source_symtab)
7764         (forget_cached_source_info_for_objfile): Update.
7765         * objfiles.h (class objfile_compunits): Remove.
7766         (struct objfile) <compunits_range>: New typedef.
7767         (compunits): New method.
7768         * objfiles.c (objfile_relocate1): Update.
7769         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7770         * maint.c (count_symtabs_and_blocks): Update.
7771         * linespec.c (iterate_over_all_matching_symtabs): Update.
7772         * cp-support.c (add_symbol_overload_list_qualified): Update.
7773         * coffread.c (coff_symtab_read): Update.
7774         * ada-lang.c (add_nonlocal_symbols)
7775         (ada_collect_symbol_completion_matches)
7776         (ada_add_global_exceptions): Update.
7777
7778 2019-01-15  Tom Tromey  <tom@tromey.com>
7779
7780         * progspace.h (program_space) <objfiles_safe_range>: New
7781         typedef.
7782         <objfiles_safe>: New method.
7783         * objfiles.h (class all_objfiles_safe): Remove.
7784         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7785         * jit.c (jit_inferior_exit_hook): Update.
7786
7787 2019-01-17  Tom Tromey  <tom@tromey.com>
7788
7789         * progspace.h (program_space) <objfiles_range>: New typedef.
7790         <objfiles>: New method.
7791         <objfiles_head>: Rename from objfiles.
7792         (object_files): Update.
7793         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7794         * guile/scm-pretty-print.c
7795         (ppscm_find_pretty_printer_from_objfiles): Update.
7796         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7797         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7798         Update.
7799         * python/py-progspace.c (pspy_get_objfiles): Update.
7800         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7801         Update.
7802         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7803         (objfpy_lookup_objfile_by_build_id): Update.
7804         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7805         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7806         Update.
7807         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7808         (expand_symtab_containing_pc, lookup_objfile_from_block)
7809         (lookup_static_symbol, basic_lookup_transparent_type)
7810         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7811         (find_line_symtab, info_sources_command)
7812         (default_collect_symbol_completion_matches_break_on)
7813         (make_source_files_completion_list, find_main_name): Update.
7814         * symmisc.c (print_symbol_bcache_statistics)
7815         (print_objfile_statistics, maintenance_print_symbols)
7816         (maintenance_print_msymbols, maintenance_print_objfiles)
7817         (maintenance_info_symtabs, maintenance_check_symtabs)
7818         (maintenance_expand_symtabs, maintenance_info_line_tables):
7819         Update.
7820         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7821         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7822         (map_overlay_command, unmap_overlay_command)
7823         (simple_overlay_update, expand_symtabs_matching)
7824         (map_symbol_filenames): Update.
7825         * symfile-debug.c (set_debug_symfile): Update.
7826         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7827         Update.
7828         * source.c (select_source_symtab, forget_cached_source_info):
7829         Update.
7830         * solib.c (solib_read_symbols): Update.
7831         * solib-spu.c (append_ocl_sos): Update.
7832         * psymtab.c (maintenance_print_psymbols)
7833         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7834         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7835         * printcmd.c (info_symbol_command): Update.
7836         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7837         Update.
7838         * objfiles.h (class all_objfiles): Remove.
7839         * objfiles.c (have_partial_symbols, have_full_symbols)
7840         (have_minimal_symbols, qsort_cmp, update_section_map)
7841         (shared_objfile_contains_address_p)
7842         (default_iterate_over_objfiles_in_search_order): Update.
7843         * objc-lang.c (info_selectors_command, info_classes_command)
7844         (find_methods): Update.
7845         * minsyms.c (find_solib_trampoline_target): Update.
7846         * maint.c (maintenance_info_sections)
7847         (maintenance_translate_address, count_symtabs_and_blocks):
7848         Update.
7849         * main.c (captured_main_1): Update.
7850         * linux-thread-db.c (try_thread_db_load_from_pdir)
7851         (has_libpthread): Update.
7852         * linespec.c (iterate_over_all_matching_symtabs)
7853         (search_minsyms_for_name): Update.
7854         * jit.c (jit_find_objf_with_entry_addr): Update.
7855         * hppa-tdep.c (find_unwind_entry)
7856         (hppa_lookup_stub_minimal_symbol): Update.
7857         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7858         Update.
7859         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7860         (elf_gnu_ifunc_resolve_by_got): Update.
7861         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7862         * dwarf-index-write.c (save_gdb_index_command): Update.
7863         * cp-support.c (add_symbol_overload_list_qualified): Update.
7864         * breakpoint.c (create_overlay_event_breakpoint)
7865         (create_longjmp_master_breakpoint)
7866         (create_std_terminate_master_breakpoint)
7867         (create_exception_master_breakpoint): Update.
7868         * blockframe.c (find_pc_partial_function): Update.
7869         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7870         (ada_collect_symbol_completion_matches)
7871         (ada_add_global_exceptions): Update.
7872
7873 2019-01-17  Tom Tromey  <tom@tromey.com>
7874
7875         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7876         declare VEC.
7877         (solib_target_parse_libraries): Change return type.
7878         (library_list_start_segment, library_list_start_section)
7879         (library_list_end_library, library_list_start_library); Update.
7880         (solib_target_free_library_list): Remove.
7881         (solib_target_parse_libraries): Remove cleanup.  Change return
7882         type.
7883         (solib_target_current_sos): Update.
7884
7885 2019-01-17  Tom Tromey  <tromey@bapiya>
7886
7887         * valprint.c: Replace "the the" with "the".
7888         * symtab.c: Replace "the the" with "the".
7889         * solib.c: Replace "the the" with "the".
7890         * solib-dsbt.c: Replace "the the" with "the".
7891         * linespec.c: Replace "the the" with "the".
7892         * dwarf2loc.h: Replace "the the" with "the".
7893         * amd64-windows-tdep.c: Replace "the the" with "the".
7894         * aarch64-tdep.c: Replace "the the" with "the".
7895
7896 2019-01-16  Keith Seitz  <keiths@redhat.com>
7897
7898         PR gdb/23773
7899         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7900         <builder>: Rename to ..
7901         <m_builder>: ... this and make private.
7902         (dwarf2_cu::get_builder): New method.  Change all users of
7903         `builder' to use this method.
7904         (dwarf2_start_symtab): Move to ...
7905         (dwarf2_cu::start_symtab): ... here.  Update all callers
7906         (setup_type_unit_groups): Move to ...
7907         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7908         callers.
7909         (dwarf2_cu::reset_builder): New method.
7910         (process_full_compunit, process_full_type_unit): Use
7911         dwarf2_cu::reset_builder.
7912         (follow_die_offset): Record the ancestor CU if it is different
7913         from the followed DIE's CU.
7914         (follow_die_sig_1): Likewise.
7915
7916 2019-01-15  Tom Tromey  <tom@tromey.com>
7917
7918         * remote.c (class remote_state) <buf>: Now a char_vector.
7919         <buf_size>: Remove.
7920         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7921         parameter.
7922         (remote_target::getpkt_or_notif_sane_1)
7923         (remote_target::getpkt_sane)
7924         (remote_target::getpkt_or_notif_sane): Likewise.
7925         (class remote_target) <putpkt>: New overload.
7926         (remote_target::read_frame): Change type of "buf_p".  Remove
7927         sizeof_p parameter.
7928         (packet_ok): New overload.
7929         (packet_check_result): New overload.
7930         Update all uses.
7931
7932 2019-01-14  Tom Tromey  <tom@tromey.com>
7933
7934         * remote-notif.c (handle_notification, remote_notif_ack)
7935         (remote_notif_parse): Make "buf" const.
7936         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7937         const.
7938         (remote_notif_parse, remote_notif_ack, handle_notification):
7939         Likewise.
7940         * remote.c (remote_notif_stop_parse): Make "buf" const.
7941         (remote_target::remote_parse_stop_reply): Make "buf" const.
7942         (remote_notif_stop_ack): Make "buf" const.
7943
7944 2019-01-14  Tom Tromey  <tom@tromey.com>
7945
7946         * remote.c (remote_console_output): Make parameter const.
7947
7948 2019-01-14  Tom Tromey  <tom@tromey.com>
7949
7950         * target-debug.h (target_debug_print_signals): Constify.
7951         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7952         * procfs.c (procfs_target::pass_signals): Update.
7953         * linux-nat.c (linux_nat_target::pass_signals): Update.
7954         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7955         * target-delegates.c: Rebuild.
7956         * remote.c (remote_target::program_signals): Update.
7957         (remote_target::pass_signals): Update.
7958         * target.c (target_pass_signals): Constify argument.
7959         (target_program_signals): Likewise.
7960         * target.h (struct target_ops) <pass_signals, program_signals>:
7961         Constify argument.
7962         (target_pass_signals, target_program_signals): Constify argument.
7963
7964 2019-01-14  Tom Tromey  <tom@tromey.com>
7965
7966         PR tui/28819:
7967         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7968
7969 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7970
7971         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7972         field.
7973         * rs6000-tdep.c: Include reggroups.h.
7974         (IS_V_ALIAS_PSEUDOREG): Define.
7975         (rs6000_register_name): Return names for the "vX" aliases.
7976         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7977         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7978         aliases.  Call default_register_reggroup_p for all other
7979         pseudo-registers.
7980         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7981         New functions.
7982         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7983         Handle "vX" aliases.
7984         (v_alias_pseudo_register_collect): New function.
7985         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7986         (rs6000_gdbarch_init): Initialize "vX" aliases as
7987         pseudo-registers.  Restore registration of
7988         rs6000_pseudo_register_reggroup_p with
7989         set_tdesc_pseudo_register_reggroup_p.
7990
7991 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7992
7993         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7994         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7995         set_gdbarch_num_pseudo_regs.
7996
7997 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7998
7999         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8000         Remove arg prefixname, add do_set and do_show.
8001         Add member functions set_list and show_list.
8002         * cli/cli-style.c (class cli_style_option): Update accordingly.
8003         (style_set_list): Move to file scope.
8004         (style_show_list): Likewise.
8005         (set_style): Call help_list.
8006         (show_style): Call cmd_show_list.
8007         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8008         Update to use the new macro.
8009
8010 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8011
8012         * ada-lang.c (_initialize_ada_language): Expand the help text
8013         for the "catch exception" command.
8014
8015 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8016
8017         * symtab.c (matching_obj_sections): Initialize obj,
8018         declare it closer to its usage.
8019
8020 2019-01-10  Tom Tromey  <tom@tromey.com>
8021
8022         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8023         (basic_inf_threads_range): Remove.
8024         (inf_threads_range, inf_non_exited_threads_range)
8025         (safe_inf_threads_range): Use next_adapter.
8026
8027 2019-01-10  Keith Seitz  <keiths@redhat.com>
8028
8029         PR gdb/23712
8030         PR symtab/23010
8031         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8032         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8033
8034 2019-01-10  Keith Seitz  <keiths@redhat.com>
8035
8036         PR gdb/23712
8037         PR symtab/23010
8038         * dictionary.c (pending_to_vector): Remove.
8039         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8040         Remove _1 suffix, replacing functions of the same name.  Update
8041         all callers.
8042         (dict_create_hashed, dict_create_hashed_expandable)
8043         (dict_create_linear, dict_create_linear_expandable, dict_free)
8044         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8045         Make functions static.
8046
8047 2019-01-10  Keith Seitz  <keiths@redhat.com>
8048
8049         PR gdb/23712
8050         PR symtab/23010
8051         * dictionary.h (struct dictionary): Replace declaration with
8052         multidictionary.
8053         (dict_create_hashed, dict_create_hashed_expandable)
8054         (dict_create_linear, dict_create_linear_expandable)
8055         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8056         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8057         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8058         taking multidictionary argument.
8059         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8060         * block.h (struct block) <dict>: Change to multidictionary
8061         and rename `multidict'.
8062         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8063         symmisc.c: Update all dictionary references to multidictionary.
8064
8065 2019-01-10  Keith Seitz  <keiths@redhat.com>
8066
8067         PR gdb/23712
8068         PR symtab/23010
8069         * dictionary.c: Include unordered_map.
8070         (pending_to_vector): New function.
8071         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8072         Rewrite the non-"_1" functions to take vector instead
8073         of linked list.
8074         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8075         "new" _1 versions of the same name.
8076         (multidictionary): Define.
8077         (std::hash<enum language): New definition.
8078         (collate_pending_symbols_by_language, mdict_create_hashed)
8079         (mdict_create_hashed_expandable, mdict_create_linear)
8080         (mdict_create_linear_expandable, mdict_free)
8081         (find_language_dictionary, create_new_language_dictionary)
8082         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8083         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8084         (mdict_size, mdict_empty): New functions.
8085         * dictionary.h (mdict_iterator): Define.
8086
8087 2019-01-10  Pedro Alves  <palves@redhat.com>
8088
8089         * breakpoint.c (read_uploaded_action)
8090         (create_tracepoint_from_upload): Adjust to use
8091         gdb::unique_xmalloc_ptr.
8092         * ctf.c (ctf_write_uploaded_tp):
8093         (SET_ARRAY_FIELD): Use emplace_back.
8094         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8095         * tracefile-tfile.c (tfile_write_uploaded_tp):
8096         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8097         gdb::unique_xmalloc_ptr.
8098         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8099         at_string, cond_string, cmd_strings>: Replace char pointers
8100         with gdb::unique_xmalloc_ptr.
8101
8102 2019-01-10  Pedro Alves  <palves@redhat.com>
8103
8104         * solib-target.c (library_list_start_library): Don't xstrdup name.
8105
8106 2019-01-10  Pedro Alves  <palves@redhat.com>
8107
8108         * mdebugread.c (parse_partial_symbols): Use
8109         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8110
8111 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8112
8113         * linux-fork.c (scoped_switch_fork_info)
8114         <~scoped_switch_fork_info>: Fix incorrect variable name.
8115
8116 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8117
8118         * linux-fork.c (scoped_switch_fork_info)
8119         <scoped_switch_fork_info>: Make explicit.
8120         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8121
8122 2019-01-10  Tom Tromey  <tom@tromey.com>
8123
8124         * objfiles.h (objfile::reset_psymtabs): Update.
8125         * objfiles.c (objfile::objfile): Update.
8126         * psymtab.h (psymtab_storage::obstack): Update.
8127         (psymtab_storage::m_obstack): Use gdb::optional.
8128         (class psymtab_storage): Update comment.  Remove objfile
8129         parameter.
8130         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8131
8132 2019-01-10  Tom Tromey  <tom@tromey.com>
8133
8134         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8135         <free_psymtabs>: Now private.
8136         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8137         (allocate_psymtab): Use new method.
8138
8139 2019-01-10  Tom Tromey  <tom@tromey.com>
8140
8141         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8142         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8143         * mdebugread.c (parse_partial_symbols): Use
8144         allocate_dependencies.
8145         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8146         allocate_dependencies.
8147         (process_psymtab_comp_unit_reader)
8148         (build_type_psymtab_dependencies): Likewise.
8149         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8150
8151 2019-01-10  Tom Tromey  <tom@tromey.com>
8152
8153         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8154         PSYMBOL_SET_LANGUAGE.
8155         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8156
8157 2019-01-10  Tom Tromey  <tom@tromey.com>
8158
8159         * psymtab.h (psymtab_storage::obstack): New method.
8160         <m_obstack>: Rename from obstack; now private.
8161         * psymtab.c (psymtab_storage): Update.
8162         * dwarf2read.c (create_addrmap_from_index)
8163         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8164         Update.
8165
8166 2019-01-10  Tom Tromey  <tom@tromey.com>
8167
8168         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8169         * objfiles.h (objfile::reset_psymtabs): New method.
8170
8171 2019-01-10  Tom Tromey  <tom@tromey.com>
8172
8173         * symmisc.c (print_symbol_bcache_statistics): Update.
8174         (print_objfile_statistics): Update.
8175         * symfile.c (reread_symbols): Update.
8176         * psymtab.h (class psymtab_storage): New.
8177         * psymtab.c (psymtab_storage): New constructor.
8178         (~psymtab_storage): New destructor.
8179         (require_partial_symbols): Update.
8180         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8181         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8182         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8183         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8184         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8185         (start_psymtab_common, end_psymtab_common)
8186         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8187         (allocate_psymtab): Update.
8188         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8189         Update.
8190         (dump_psymtab_addrmap, maintenance_print_psymbols)
8191         (maintenance_check_psymtabs): Update.
8192         (class objfile_psymtabs): Move to objfiles.h.
8193         * psympriv.h (discard_psymtab): Now inline.
8194         (psymtab_discarder::psymtab_discarder): Update.
8195         (psymtab_discarder::~psymtab_discarder): Update.
8196         (ALL_OBJFILE_PSYMTABS): Rewrite.
8197         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8198         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8199         Remove fields.
8200         <partial_symtabs>: New field.
8201         (class objfile_psymtabs): Move from psymtab.h.  Update.
8202         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8203         psymbol_cache.
8204         (objfile::~objfile): Don't destroy psymbol_cache.
8205         * mdebugread.c (parse_partial_symbols): Update.
8206         * dwarf2read.c (create_addrmap_from_index)
8207         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8208         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8209         (add_partial_subprogram, dwarf2_ranges_read): Update.
8210         * dwarf-index-write.c (write_address_map)
8211         (write_one_signatured_type, recursively_write_psymbols)
8212         (class debug_names, class debug_names, write_psymtabs_to_index):
8213         Update.
8214
8215 2019-01-10  Tom Tromey  <tom@tromey.com>
8216
8217         * symtab.h (SYMBOL_SET_NAMES): Update.
8218         (symbol_set_names): Update.
8219         (MSYMBOL_SET_NAMES): Update.
8220         * symtab.c (symbol_set_names): Change argument to be an
8221         objfile_per_bfd_storage.
8222         * psymtab.c (add_psymbol_to_bcache): Update.
8223         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8224
8225 2019-01-10  Tom Tromey  <tom@tromey.com>
8226
8227         * symtab.c (create_demangled_names_hash): Change argument to be an
8228         objfile_per_bfd_storage.
8229         (symbol_set_names): Update.
8230
8231 2019-01-10  Tom Tromey  <tom@tromey.com>
8232
8233         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8234         init_psymbol_list.
8235         * psymtab.c (init_psymbol_list): Do nothing if already called.
8236         * psympriv.h (init_psymbol_list): Add comment.
8237         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8238         init_psymbol_list.
8239         * dbxread.c (dbx_symfile_read): Unconditionally call
8240         init_psymbol_list.
8241
8242 2019-01-10  Tom Tromey  <tom@tromey.com>
8243
8244         * xcoffread.c (scan_xcoff_symtab): Update.
8245         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8246         "where".
8247         * mdebugread.c (parse_partial_symbols)
8248         (handle_psymbol_enumerators): Update.
8249         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8250         * dbxread.c (read_dbx_symtab): Update.
8251         * psympriv.h (psymbol_placement): New enum.
8252         (add_psymbol_to_list): Update.
8253
8254 2019-01-10  Tom Tromey  <tom@tromey.com>
8255
8256         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8257         static_psymbols parameters.
8258         (scan_xcoff_symtab): Update.
8259         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8260         static_psymbols parameters.
8261         * psympriv.h (start_psymtab_common): Update.
8262         * mdebugread.c (parse_partial_symbols): Update.
8263         * dwarf2read.c (create_partial_symtab): Update.
8264         * dbxread.c (read_dbx_symtab): Update.
8265         (start_psymtab): Remove global_psymbols and static_psymbols
8266         parameters.
8267
8268 2019-01-10  Tom Tromey  <tom@tromey.com>
8269
8270         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8271         * psymtab.c (allocate_psymtab): Add comment.
8272         * psympriv.h (allocate_psymtab): Add comment.
8273         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8274         initializations.
8275         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8276
8277 2019-01-10  Tom Tromey  <tom@tromey.com>
8278
8279         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8280         Don't declare.
8281         * mipsread.c: Include mdebugread.h.
8282         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8283         Declare.
8284         * elfread.c: Include mdebugread.h.
8285
8286 2019-01-09  Tom Tromey  <tom@tromey.com>
8287
8288         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8289         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8290         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8291         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8292         (psym_lookup_symbol, psym_find_last_source_symtab)
8293         (psym_forget_cached_source_info, psym_print_stats)
8294         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8295         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8296         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8297         (psym_find_compunit_symtab_by_address)
8298         (maintenance_print_psymbols, maintenance_info_psymtabs)
8299         (maintenance_check_psymtabs): Use ranged for.
8300         * psymtab.h (class objfile_psymtabs): New.
8301         (require_partial_symbols): Return objfile_psymtabs.
8302         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8303
8304 2019-01-09  Tom Tromey  <tom@tromey.com>
8305
8306         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8307         (find_pc_mapped_section, list_overlays_command)
8308         (map_overlay_command, unmap_overlay_command)
8309         (simple_overlay_update): Use all_objfiles.
8310         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8311         * printcmd.c (info_symbol_command): Use all_objfiles.
8312         * objfiles.h (ALL_OBJSECTIONS): Remove.
8313         * maint.c (maintenance_translate_address): Use all_objfiles.
8314         * gcore.c (gcore_create_callback): Use all_objfiles.
8315         (objfile_find_memory_regions): Likewise.
8316
8317 2019-01-09  Tom Tromey  <tom@tromey.com>
8318
8319         * symtab.c (find_line_symtab, info_sources_command)
8320         (make_source_files_completion_list): Use objfile_compunits.
8321         * source.c (select_source_symtab): Use objfile_compunits.
8322         * objfiles.h (struct objfile): Update comment.
8323         (ALL_OBJFILES): Remove.
8324         (ALL_FILETABS): Remove.
8325         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8326         objfile_compunits.
8327
8328 2019-01-09  Tom Tromey  <tom@tromey.com>
8329
8330         * symmisc.c (print_objfile_statistics, dump_objfile)
8331         (maintenance_print_symbols): Use compunit_filetabs.
8332         * source.c (forget_cached_source_info_for_objfile): Use
8333         compunit_filetabs.
8334         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8335         (ALL_FILETABS): Use compunit_filetabs.
8336         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8337         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8338
8339 2019-01-09  Tom Tromey  <tom@tromey.com>
8340
8341         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8342         (compunit_filetabs): New.
8343         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8344         compunit_filetabs.
8345         (info_sources_command, make_source_files_completion_list): Remove
8346         declaration.
8347         * symmisc.c (print_objfile_statistics, dump_objfile)
8348         (maintenance_print_symbols): Remove declaration.
8349         (maintenance_info_symtabs): Use compunit_filetabs.
8350         (maintenance_info_line_tables): Likewise.
8351         * source.c (select_source_symtab): Change local variable name.
8352         (forget_cached_source_info_for_objfile): Remove declaration.
8353         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8354         * objfiles.c (objfile_relocate1): Remove declaration.
8355         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8356         declaration.
8357         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8358         * coffread.c (coff_symtab_read): Remove declaration.
8359         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8360         compunit_filetabs.
8361
8362 2019-01-09  Tom Tromey  <tom@tromey.com>
8363
8364         * symtab.c (lookup_objfile_from_block)
8365         (find_pc_sect_compunit_symtab, search_symbols)
8366         (default_collect_symbol_completion_matches_break_on): Use
8367         objfile_compunits.
8368         * objfiles.h (ALL_COMPUNITS): Remove.
8369         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8370         * cp-support.c (add_symbol_overload_list_qualified): Use
8371         objfile_compunits.
8372         * ada-lang.c (ada_collect_symbol_completion_matches)
8373         (ada_add_global_exceptions): Use objfile_compunits.
8374
8375 2019-01-09  Tom Tromey  <tom@tromey.com>
8376
8377         * source.c (select_source_symtab)
8378         (forget_cached_source_info_for_objfile): Remove declaration.
8379         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8380         declaration.
8381         * maint.c (count_symtabs_and_blocks): Remove declaration.
8382         * cp-support.c (add_symbol_overload_list_qualified): Remove
8383         declaration.
8384         * coffread.c (coff_symtab_read): Remove declaration.
8385         * symtab.c (lookup_symbol_in_objfile_symtabs)
8386         (basic_lookup_transparent_type_1): Use objfile_compunits.
8387         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8388         (info_sources_command, search_symbols)
8389         (default_collect_symbol_completion_matches_break_on)
8390         (make_source_files_completion_list): Remove declaration.
8391         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8392         (ada_collect_symbol_completion_matches)
8393         (ada_add_global_exceptions): Remove declaration.
8394         * linespec.c (iterate_over_all_matching_symtabs): Use
8395         objfile_compunits.
8396         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8397         (class objfile_compunits): New.
8398         (ALL_COMPUNITS): Use objfile_compunits.
8399         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8400         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8401         objfile_compunits.
8402         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8403
8404 2019-01-09  Tom Tromey  <tom@tromey.com>
8405
8406         * symtab.c (search_symbols)
8407         (default_collect_symbol_completion_matches_break_on): Use
8408         objfile_msymbols.
8409         * ada-lang.c (ada_lookup_simple_minsym)
8410         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8411         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8412         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8413         objfile_msymbols.
8414         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8415         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8416         * objc-lang.c (find_methods): Use objfile_msymbols.
8417         (info_selectors_command, info_classes_command): Likewise.
8418         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8419         * objfiles.h (class objfile_msymbols): New.
8420         (ALL_OBJFILE_MSYMBOLS): Remove.
8421         (ALL_MSYMBOLS): Remove.
8422
8423 2019-01-09  Tom Tromey  <tom@tromey.com>
8424
8425         * common/next-iterator.h (next_adapter): Add Iterator template
8426         parameter.
8427         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8428         (class all_objfiles_safe): New.
8429         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8430         * objfiles.c (put_objfile_before): Update comment.
8431         (add_separate_debug_objfile): Likewise.
8432         (free_all_objfiles): Use all_objfiles_safe.
8433         (objfile_purge_solibs): Likewise.
8434
8435 2019-01-09  Tom Tromey  <tom@tromey.com>
8436
8437         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8438         (expand_symtab_containing_pc, lookup_static_symbol)
8439         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8440         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8441         all_objfiles.
8442         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8443         * breakpoint.c (create_overlay_event_breakpoint)
8444         (create_longjmp_master_breakpoint)
8445         (create_std_terminate_master_breakpoint)
8446         (create_exception_master_breakpoint): Use all_objfiles.
8447         * linux-thread-db.c (try_thread_db_load_from_pdir)
8448         (has_libpthread): Use all_objfiles.
8449         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8450         * linespec.c (iterate_over_all_matching_symtabs)
8451         (search_minsyms_for_name): Use all_objfiles.
8452         * maint.c (maintenance_info_sections): Use all_objfiles.
8453         * main.c (captured_main_1): Use all_objfiles.
8454         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8455         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8456         * guile/scm-pretty-print.c
8457         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8458         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8459         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8460         (maintenance_print_msymbols): Use all_objfiles.
8461         * source.c (select_source_symtab): Use all_objfiles.
8462         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8463         * symfile.c (remove_symbol_file_command)
8464         (expand_symtabs_matching, map_symbol_filenames): Use
8465         all_objfiles.
8466         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8467         all_objfiles.
8468         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8469         * objc-lang.c (find_methods): Use all_objfiles.
8470         * objfiles.c (have_partial_symbols, have_full_symbols)
8471         (have_minimal_symbols, qsort_cmp)
8472         (default_iterate_over_objfiles_in_search_order): Use
8473         all_objfiles.
8474         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8475         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8476         (maintenance_check_psymtabs): Use all_objfiles.
8477         (ALL_PSYMTABS): Remove.
8478         * compile/compile-object-run.c (do_module_cleanup): Use
8479         all_objfiles.
8480         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8481         * cp-support.c (add_symbol_overload_list_qualified): Use
8482         all_objfiles.
8483         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8484         Use all_objfiles.
8485         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8486         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8487         all_objfiles.
8488         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8489         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8490         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8491         Uses all_objfiles.
8492         * solib.c (solib_read_symbols): Use all_objfiles
8493
8494 2019-01-09  Tom Tromey  <tom@tromey.com>
8495
8496         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8497         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8498         all_objfiles.
8499         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8500         * symmisc.c (print_symbol_bcache_statistics)
8501         (print_objfile_statistics, maintenance_print_objfiles)
8502         (maintenance_info_symtabs, maintenance_check_symtabs)
8503         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8504         all_objfiles.
8505         * source.c (forget_cached_source_info): Use all_objfiles.
8506         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8507         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8508         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8509         * objfiles.c (update_section_map): Use all_objfiles.
8510         (shared_objfile_contains_address_p): Likewise.
8511         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8512         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8513
8514 2019-01-09  Tom Tromey  <tom@tromey.com>
8515
8516         * common/next-iterator.h: New file.
8517         * objfiles.h (class all_objfiles): New.
8518         (struct objfile_iterator): New.
8519
8520 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8521
8522         * NEWS: Move the description of the changed "frame", "select-frame",
8523          and "info frame" commands to the Changed commands section.
8524
8525 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8526
8527         * gdbtypes.c (check_stub_method_group): Remove handling of old
8528         mangling schemes.
8529         * linespec.c (find_methods): Likewise.
8530         * stabsread.c (read_member_functions): Likewise.
8531         * valops.c (search_struct_method): Likewise.
8532         (value_struct_elt_for_reference): Likewise.
8533         * NEWS: Mention this change.
8534
8535 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8536
8537         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8538         print_source_lines.
8539         * source.c (print_source_lines_base): Update line number check.
8540         (print_source_lines): New function.
8541         (source_lines_range::source_lines_range): New function.
8542         * source.h (class source_lines_range): New class.
8543         (print_source_lines): New declaration.
8544
8545 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8546
8547         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8548
8549 2019-01-08  Tom Tromey  <tom@tromey.com>
8550             Simon Marchi  <simon.marchi@ericsson.com>
8551
8552         PR gdb/24060
8553         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8554         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8555         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8556         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8557         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8558         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8559
8560 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8561
8562         * source.c (select_source_symtab): Move header comment to
8563         declaration in source.h.
8564         (forget_cached_source_info_for_objfile): Likewise.
8565         (forget_cached_source_info): Likewise.
8566         (identify_source_line): Likewise.
8567         * source.h (identify_source_line): Move declaration from symtab.h
8568         and add comment from source.c
8569         (print_source_lines): Likewise.
8570         (forget_cached_source_info_for_objfile): Likewise.
8571         (forget_cached_source_info): Likewise.
8572         (select_source_symtab): Likewise.
8573         (enum print_source_lines_flag): Move definition from symtab.h.
8574         * symtab.h (identify_source_line): Move declaration to source.h.
8575         (print_source_lines): Likewise.
8576         (forget_cached_source_info_for_objfile): Likewise.
8577         (forget_cached_source_info): Likewise.
8578         (select_source_symtab): Likewise.
8579         (enum print_source_lines_flag): Move definition to source.h.
8580         * tui/tui-hooks.c: Add 'source.h' include.
8581
8582 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8583
8584         * source.c (print_source_lines_base): Handle requests to print
8585         reverse line number sequences, and guard against empty lines
8586         string.
8587
8588 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8589
8590         * source.c (print_source_lines_base): Fix skip of '\r' if next
8591         character is '\n'.
8592
8593 2019-01-06  Tom Tromey  <tom@tromey.com>
8594
8595         * c-exp.y (struct c_parse_state) <macro_original_text,
8596         expansion_obstack>: New member.
8597         (macro_original_text, expansion_obstack): Remove globals.
8598         (scan_macro_expansion, scanning_macro_expansion)
8599         (finished_macro_expansion): Update.
8600         (scan_macro_cleanup): Remove.
8601         (yylex, c_parse): Update.
8602
8603 2019-01-06  Tom Tromey  <tom@tromey.com>
8604
8605         * c-exp.y (struct c_parse_state) <strings>: New member.
8606         (operator_stoken): Update.
8607
8608 2019-01-06  Tom Tromey  <tom@tromey.com>
8609
8610         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8611         (union type_stack_elt) <typelist_val>: Now a pointer to
8612         std::vector.
8613         (type_stack_cleanup): Don't declare.
8614         (push_typelist): Update.
8615         * parse.c (pop_typelist): Return a std::vector.
8616         (push_typelist): Take a std::vector.
8617         (follow_types): Update.  Do not free args.
8618         (type_stack_cleanup): Remove.
8619         * c-exp.y (struct c_parse_state): New.
8620         (cpstate): New global.
8621         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8622         (nonempty_typelist): Update.
8623         (func_mod): Create a new vector.
8624         (c_parse): Create a c_parse_state.
8625         (check_parameter_typelist): Do not delete params.
8626         (function_method): Update.  Do not delete type_list.
8627
8628 2019-01-06  Tom Tromey  <tom@tromey.com>
8629
8630         PR gdb/28155:
8631         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8632         check_typedef.
8633         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8634         (print_return_value): Likewise.
8635
8636 2019-01-05  Tom Tromey  <tom@tromey.com>
8637
8638         * contrib/cleanup_check.py: Remove.
8639         * contrib/gcc-with-excheck: Remove.
8640         * contrib/exsummary.py: Remove.
8641         * contrib/excheck.py: Remove.
8642
8643 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8644
8645         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8646         NULL. Initialize tpprev to NULL instead of assigning it
8647         to NULL on the next statement.
8648         * windows-nat.c (windows_delete_thread): Remove check for
8649         main_thread_id before printing thread exit notifications.
8650         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8651         Remove thread ID check against main_thread_id.
8652         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8653         windows_delete_thread.
8654         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8655
8656 2019-01-04  Tom Tromey  <tom@tromey.com>
8657
8658         * compile/compile.c (_initialize_compile): Use upper case for
8659         metasyntactic variables.
8660         * symmisc.c (_initialize_symmisc): Use upper case for
8661         metasyntactic variables.
8662         * psymtab.c (_initialize_psymtab): Use upper case for
8663         metasyntactic variables.
8664         * demangle.c (demangle_command): Use upper case for metasyntactic
8665         variables.
8666         (_initialize_demangler): Likewise.
8667         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8668         variables.
8669
8670 2019-01-03  Tom Tromey  <tom@tromey.com>
8671
8672         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8673
8674 2019-01-03  Tom Tromey  <tom@tromey.com>
8675
8676         * python/py-symtab.c (salpy_str): Update.
8677         (struct salpy_sal_object) <symtab>: Now a PyObject.
8678         (salpy_dealloc): Update.
8679         (del_objfile_sal): Use gdbpy_ref.
8680
8681 2019-01-03  Tom Tromey  <tom@tromey.com>
8682
8683         * python/py-type.c (convert_field): Use new_reference.  Return
8684         gdbpy_ref.
8685         (make_fielditem): Return gdbpy_ref.
8686         (typy_fields): Update.
8687         (typy_getitem): Update.
8688         (field_name): Return gdbpy_ref.  Use new_reference.
8689         (typy_iterator_iternext): Update.
8690
8691 2019-01-03  Tom Tromey  <tom@tromey.com>
8692
8693         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8694
8695 2019-01-03  Tom Tromey  <tom@tromey.com>
8696
8697         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8698         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8699         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8700         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8701         (pspy_set_type_printers): Likewise.
8702         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8703         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8704         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8705         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8706         (objfpy_set_type_printers): Likewise.
8707
8708 2019-01-03  Tom Tromey  <tom@tromey.com>
8709
8710         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8711         (gdbpy_print_stack): Use gdbpy_err_fetch.
8712         * python/python-internal.h (class gdbpy_err_fetch): New class.
8713         (class gdbpy_enter) <m_error_type, m_error_value,
8714         m_error_traceback>: Remove.
8715         <m_error>: New member.
8716         (gdbpy_exception_to_string): Don't declare.
8717         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8718         * python/py-value.c (convert_value_from_python): Use
8719         gdbpy_err_fetch.
8720         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8721         gdbpy_exception_to_string.
8722         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8723         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8724         gdbpy_err_fetch.
8725
8726 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8727
8728         * linux-nat.c (delete_lwp_cleanup): Delete.
8729         (struct lwp_deleter): New struct.
8730         (lwp_info_up): New typedef.
8731         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8732         lwp_info_up.
8733
8734 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8735
8736         * linux-fork.c (class scoped_switch_fork_info): New class.
8737         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8738
8739 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8740
8741         * valops.c (find_overload_match): Remove use of null_cleanup, and
8742         calls to do_cleanups.
8743
8744 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8745
8746         * compile/compile-cplus-types.c
8747         (compile_cplus_instance::decl_name): Handle changes to
8748         cp_func_name.
8749         * cp-support.c (cp_func_name): Update header comment, update
8750         return type.
8751         * cp-support.h (cp_func_name): Update return type in declaration.
8752         * valops.c (find_overload_match): Move temp_func local to top
8753         level of function and change its type.  Use temp_func to hold and
8754         delete temporary string obtained from cp_func_name.
8755
8756 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8757
8758         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8759         gdb::char_vector, remove cleanup, and update uses of `msg`.
8760
8761 2019-01-03  Jim Wilson  <jimw@sifive.com>
8762
8763         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8764
8765 2019-01-02  Tom Tromey  <tom@tromey.com>
8766
8767         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8768         (tdesc_parse_xml): Remove cleanups.
8769         * target-descriptions.h (make_cleanup_free_target_description):
8770         Don't declare.
8771         (target_desc_deleter): New struct.
8772         (target_desc_up): New typedef.
8773         * target-descriptions.c (target_desc_deleter::operator()): Rename
8774         from free_target_description.
8775         (make_cleanup_free_target_description): Remove.
8776
8777 2019-01-02  Tom Tromey  <tom@tromey.com>
8778
8779         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8780         constructor, destructor.
8781         (linespec_parser): Remove typedef.
8782         (~linespec_parser): Rename from linespec_parser_delete.
8783         (linespec_lex_to_end, linespec_complete_label)
8784         (linespec_complete): Update.
8785         (decode_line_full): Remove cleanups.
8786         (decode_line_1): Update.
8787
8788 2019-01-02  Tom Tromey  <tom@tromey.com>
8789
8790         * python/python-internal.h (inferior_to_inferior_object): Change
8791         return type.
8792         * python/py-exitedevent.c (create_exited_event_object): Update.
8793         * python/py-inferior.c (inferior_to_inferior_object): Return
8794         gdbpy_ref.
8795         (python_new_inferior, python_inferior_deleted)
8796         (thread_to_thread_object, delete_thread_object)
8797         (build_inferior_list, gdbpy_selected_inferior): Update.
8798         * python/py-infthread.c (create_thread_object): Update.  Also fail
8799         if inferior_to_inferior_object fails.
8800
8801 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8802
8803         * inferior.h (class inferior) <displaced_step_state>: New field.
8804         * infrun.h (struct displaced_step_state): Move here from
8805         infrun.c.  Initialize fields, add constructor.
8806         <inf>: Remove field.
8807         <reset>: New method.
8808         * infrun.c (struct displaced_step_inferior_state): Move to
8809         infrun.h.
8810         (displaced_step_inferior_states): Remove.
8811         (get_displaced_stepping_state): Adust.
8812         (displaced_step_in_progress_any_inferior): Adjust.
8813         (displaced_step_in_progress_thread): Adjust.
8814         (displaced_step_in_progress): Adjust.
8815         (add_displaced_stepping_state): Remove.
8816         (get_displaced_step_closure_by_addr): Adjust.
8817         (remove_displaced_stepping_state): Remove.
8818         (infrun_inferior_exit): Call displaced_step_state.reset.
8819         (use_displaced_stepping): Don't check for NULL.
8820         (displaced_step_prepare_throw): Call
8821         get_displaced_stepping_state.
8822         (displaced_step_fixup): Don't check for NULL.
8823         (prepare_for_detach): Don't check for NULL.
8824
8825 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8826
8827         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8828          in case of call that did not complete.
8829
8830 2019-01-02  Andrey Utkin  <autkin@undo.io>
8831
8832         * symfile.c (find_separate_debug_file): Fix search of debug files for
8833         remote debuggee.
8834
8835 2019-01-02  Tom Tromey  <tom@tromey.com>
8836
8837         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8838         indentation.
8839         * python/py-frame.c (frapy_older): Remove cast.
8840         (frapy_newer): Likewise.
8841         * python/py-breakpoint.c (local_setattro): Remove cast.
8842         * python/py-arch.c (archpy_name): Remove local variable.
8843         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8844
8845 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8846
8847         * unittests/basic_string_view/element_access/char/empty.cc:
8848         Fix year range in copyright header.
8849
8850 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8851
8852         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8853         Delete.
8854         <operator==>: Update with for removed field.
8855         <hash>: Likewise.
8856         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8857         <isa_features>: ...this.
8858         <abi_features>: New field.
8859         (riscv_isa_flen): Update comment.
8860         (riscv_abi_xlen): New declaration.
8861         (riscv_abi_flen): New declaration.
8862         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8863         isa_features.
8864         (riscv_abi_xlen): New function.
8865         (riscv_isa_flen): Update to get answer from isa_features.
8866         (riscv_abi_flen): New function.
8867         (riscv_has_fp_abi): Update to get answer from abi_features.
8868         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8869         xlen and flen.
8870         (riscv_call_info) <xlen, flen>: Update comment.
8871         (riscv_call_arg_struct): Remove invalid assertions
8872         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8873         is removed.
8874         (riscv_gdbarch_init): Gather isa features and abi features
8875         separately, ensure both match on the gdbarch when reusing an old
8876         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8877         a target with 64-bit float hardware.
8878
8879 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8880
8881         * source.c (search_command_helper): Stop reverse search
8882         when line 1 has been searched.
8883
8884 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8885
8886         * record-full.c (record_full_base_target::close): Rewrite
8887         record_full_core_buf_list free logic.
8888
8889 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8890
8891         * break-catch-syscall.c (print_one_catch_syscall): xfree
8892         the last text.
8893
8894 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8895
8896         * top.c (print_gdb_version): Update Copyright year in version
8897         message.
8898
8899 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8900
8901         Update copyright year range in all GDB files.
8902
8903 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8904
8905         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8906
8907 For older changes see ChangeLog-2018.
8908 \f
8909 Local Variables:
8910 mode: change-log
8911 left-margin: 8
8912 fill-column: 74
8913 version-control: never
8914 coding: utf-8
8915 End:
8916