gdb/ChangeLog

   1 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * NEWS: Mention adding -q option to "info types".
   4         * symtab.c (struct info_types_options): New struct.
   5         (info_types_options_defs): New variable.
   6         (make_info_types_options_def_group): New function.
   7         (info_types_command): Use gdb::option framework to parse options.
   8         (info_types_command_completer): New function.
   9         (_initialize_symtab): Extend the help text on "info types" and
  10         register command completer.
  11
  12 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
  13
  14         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
  15         (lookup_symbol_in_objfile): Change int to block_enum and add a
  16         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
  17
  18 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
  19
  20         * MAINTAINERS (Write After Approval): Add self.
  21
  22 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
  23
  24         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
  25         instruction to the dummy code region.
  26
  27 2019-07-19  Tom Tromey  <tromey@adacore.com>
  28
  29         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
  30         (ARGSUSED, PARAMS, __func__): Remove rules.
  31
  32 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  33
  34         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
  35         * features/arm/arm-with-iwmmxt.c: Remove.
  36         * features/arm/arm-with-iwmmxt.xml: Remove.
  37         * features/arm/arm-with-m-fpa-layout.c: Remove.
  38         * features/arm/arm-with-m-fpa-layout.xml: Remove.
  39         * features/arm/arm-with-m-vfp-d16.c: Remove.
  40         * features/arm/arm-with-m-vfp-d16.xml: Remove.
  41         * features/arm/arm-with-m.c: Remove.
  42         * features/arm/arm-with-m.xml: Remove.
  43         * features/arm/arm-with-neon.c: Remove.
  44         * features/arm/arm-with-neon.xml: Remove.
  45         * features/arm/arm-with-vfpv2.c: Remove.
  46         * features/arm/arm-with-vfpv2.xml: Remove.
  47         * features/arm/arm-with-vfpv3.c: Remove.
  48         * features/arm/arm-with-vfpv3.xml: Remove.
  49
  50 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  51
  52         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
  53
  54 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  55
  56         * arch/aarch32.c (aarch32_create_target_description): Create
  57         target descriptions using features.
  58         * arch/arm.c (arm_create_target_description)
  59         (arm_create_mprofile_target_description): Likewise.
  60         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
  61
  62 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  63
  64         * Makefile.in: Add new files.
  65         * aarch32-tdep.c: New file.
  66         * aarch32-tdep.h: New file.
  67         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  68         Call aarch32_read_description.
  69         * arch/aarch32.c: New file.
  70         * arch/aarch32.h: New file.
  71         * arch/arm.c (arm_create_target_description)
  72         (arm_create_mprofile_target_description): New function.
  73         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
  74         (arm_create_target_description)
  75         (arm_create_mprofile_target_description): New declaration.
  76         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
  77         read_description functions.
  78         * arm-linux-nat.c (arm_linux_nat_target::read_description):
  79         Likewise.
  80         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  81         * arm-tdep.c (tdesc_arm_list): New variable.
  82         (arm_register_g_packet_guesses): Call create description functions.
  83         (arm_read_description) (arm_read_mprofile_description): New
  84         function.
  85         * arm-tdep.h (arm_read_description)
  86         (arm_read_mprofile_description): Add declaration.
  87         * configure.tgt: Add new files.
  88
  89 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
  90
  91         * top.c (new_ui_command): Open specified terminal just once.
  92
  93 2019-07-18  Tom Tromey  <tromey@adacore.com>
  94
  95         * symtab.c (main_name): Constify return type.
  96         * symfile.c (set_initial_language): Update.
  97         * symtab.h (main_name): Constify return type.
  98
  99 2019-07-17  Tom Tromey  <tom@tromey.com>
 100
 101         * tui/tui-winsource.c (tui_update_source_window)
 102         (tui_update_source_window_as_is)
 103         (tui_update_source_windows_with_line): Remove return.
 104         * tui/tui-disasm.c (tui_show_disassem)
 105         (tui_show_disassem_and_update_source): Remove return.
 106         * tui/tui.c (tui_reset): Remove return.
 107         * tui/tui-wingeneral.c
 108         (tui_check_and_display_highlight_if_needed): Remove return.
 109
 110 2019-07-17  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 113
 114 2019-07-17  Tom Tromey  <tom@tromey.com>
 115
 116         * tui/tui-winsource.h (struct tui_exec_info_window)
 117         (struct tui_source_window_base): Move from tui-data.h.
 118         * tui/tui-winsource.c: Move many method definitions from
 119         elsewhere.  Remove "structuring" comments.
 120         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 121         (tui_source_window_base::refresh_window): Move to
 122         tui-winsource.c.
 123         * tui/tui-win.c (tui_source_window_base::refresh_all)
 124         (tui_source_window_base::update_tab_width)
 125         (tui_source_window_base::set_new_height)
 126         (tui_source_window_base::do_make_visible_with_new_height): Move to
 127         tui-winsource.c.
 128         * tui/tui-source.h: Update.
 129         * tui/tui-source.c (tui_source_window_base::reset): Move to
 130         tui-winsource.c.
 131         * tui/tui-disasm.h: Update.
 132         * tui/tui-data.h (struct tui_exec_info_window): Move to
 133         tui-winsource.h.
 134         (struct tui_source_window_base): Likewise.
 135         * tui/tui-data.c (tui_source_window_base::clear_detail)
 136         (tui_source_window_base, ~tui_source_window_base): Move to
 137         tui-winsource.c.
 138
 139 2019-07-17  Tom Tromey  <tom@tromey.com>
 140
 141         * tui/tui-win.c (tui_resize_all)
 142         (tui_source_window_base::update_tab_width)
 143         (tui_adjust_win_heights): Update.
 144         (tui_win_info::make_invisible_and_set_new_height): Rename from
 145         make_invisible_and_set_new_height.
 146         * tui/tui-data.h (struct tui_win_info)
 147         <make_invisible_and_set_new_height>: New method.
 148
 149 2019-07-17  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui.c: Update.
 152         * tui/tui-source.h (struct tui_source_window): Move from
 153         tui-data.h.
 154         * tui/tui-layout.c: Update.
 155         * tui/tui-disasm.c: Update.
 156         * tui/tui-data.h (struct tui_source_window): Move to
 157         tui-source.h.
 158
 159 2019-07-17  Tom Tromey  <tom@tromey.com>
 160
 161         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 162         tui-data.h.
 163         * tui/tui-data.h (struct tui_disasm_window): Move to
 164         tui-disasm.h.
 165
 166 2019-07-17  Tom Tromey  <tom@tromey.com>
 167
 168         * tui/tui-regs.h (struct tui_data_item_window): Move from
 169         tui-data.h.
 170         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 171         * tui/tui-data.h (struct tui_data_item_window): Move to
 172         tui-regs.h.
 173         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 174
 175 2019-07-17  Tom Tromey  <tom@tromey.com>
 176
 177         * tui/tui.c: Update.
 178         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 179         (tui_cmd_window::max_height): Move to tui-command.c.
 180         * tui/tui-layout.c: Update.
 181         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 182         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 183         tui-command.c.
 184         * tui/tui-command.h (struct tui_cmd_window): Move from
 185         tui-data.h.
 186         * tui/tui-command.c: Remove "structuring" comments.
 187         (tui_cmd_window::clear_detail)
 188         (tui_cmd_window::do_make_visible_with_new_height)
 189         (tui_cmd_window::max_height): Move from elsewhere.
 190
 191 2019-07-17  Tom Tromey  <tom@tromey.com>
 192
 193         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 194         Now static.
 195         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 196         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 197
 198 2019-07-17  Tom Tromey  <tom@tromey.com>
 199
 200         * tui/tui.c: Update.
 201         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 202         tui-regs.c.
 203         * tui/tui-windata.h: Remove file.
 204         * tui/tui-windata.c: Remove file.
 205         * tui/tui-win.c (tui_data_window::set_new_height)
 206         (tui_data_window::do_make_visible_with_new_height): Move to
 207         tui-regs.c.
 208         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 209         * tui/tui-regs.c: Remove "structuring" comments.
 210         (tui_data_window::first_data_item_displayed)
 211         (tui_data_window::delete_data_content_windows)
 212         (tui_data_window::erase_data_content)
 213         (tui_data_window::display_all_data)
 214         (tui_data_window::refresh_all)
 215         (tui_data_window::do_scroll_vertical)
 216         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 217         (tui_data_window::do_make_visible_with_new_height)
 218         (tui_data_window::refresh_window): Move from elsewhere.
 219         (_initialize_tui_regs): Move to end of file.
 220         * tui/tui-layout.c: Update.
 221         * tui/tui-hooks.c: Update.
 222         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 223         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 224         tui-regs.c.
 225         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 226
 227 2019-07-17  Tom Tromey  <tom@tromey.com>
 228
 229         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 230         seen.
 231
 232 2019-07-17  Tom Tromey  <tom@tromey.com>
 233
 234         * tui/tui-win.c (tui_source_window_base::set_new_height)
 235         (tui_source_window_base::do_make_visible_with_new_height): Use
 236         m_has_locator field directly.
 237         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 238         method.
 239         (struct tui_source_window_base) <has_locator>: Likewise.
 240
 241 2019-07-17  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 244         Don't declare.
 245         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 246         Remove.
 247         * tui/tui-win.c (tui_source_window_base::set_new_height)
 248         (tui_source_window_base::set_new_height)
 249         (make_invisible_and_set_new_height)
 250         (tui_source_window_base::do_make_visible_with_new_height)
 251         (tui_source_window_base::do_make_visible_with_new_height):
 252         Update.
 253         * tui/tui-layout.c (show_source_disasm_command, show_data)
 254         (show_source_or_disasm_and_command): Update.
 255         * tui/tui-layout.c (show_layout): Update.
 256
 257 2019-07-17  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui-layout.c (make_data_window): Remove.
 260         (show_data): Unify creation and re-initialization cases.
 261
 262 2019-07-17  Tom Tromey  <tom@tromey.com>
 263
 264         * tui/tui-layout.c (make_source_window, make_disasm_window):
 265         Remove.
 266         (show_data): Unify creation and re-initialization cases.
 267
 268 2019-07-17  Tom Tromey  <tom@tromey.com>
 269
 270         * tui/tui-layout.c (make_command_window): Remove.
 271         (show_source_disasm_command, show_source_or_disasm_and_command):
 272         Unify creation and re-initialization cases.
 273
 274 2019-07-17  Tom Tromey  <tom@tromey.com>
 275
 276         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 277         creation and re-initialization cases.
 278
 279 2019-07-17  Tom Tromey  <tom@tromey.com>
 280
 281         * tui/tui-regs.c (tui_get_register): Return void.
 282
 283 2019-07-17  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 286         Simplify.
 287
 288 2019-07-17  Tom Tromey  <tom@tromey.com>
 289
 290         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 291         resetting.
 292
 293 2019-07-17  Tom Tromey  <tom@tromey.com>
 294
 295         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 296         * tui/tui-regs.c (tui_reg_layout): New function.
 297         (tui_show_registers, tui_reg_command): Use it.
 298         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 299         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 300         parameters.
 301         (tui_layout_command): Remove.
 302
 303 2019-07-17  Tom Tromey  <tom@tromey.com>
 304
 305         * tui/tui-layout.h (tui/tui-layout): Return void.
 306         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 307
 308 2019-07-17  Tom Tromey  <tom@tromey.com>
 309
 310         * tui/tui-layout.c (show_source_disasm_command, show_data):
 311         Update.
 312         (reset_locator): Remove.
 313         (show_source_or_disasm_and_command): Update.
 314
 315 2019-07-17  Tom Tromey  <tom@tromey.com>
 316
 317         * tui/tui-source.c (tui_source_window_base::reset): Remove
 318         win_type parameter.
 319         * tui/tui-layout.c (make_command_window, make_source_window)
 320         (make_disasm_window, make_data_window)
 321         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 322         (reset_locator, show_source_or_disasm_and_command): Update.
 323         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 324         win_type parameter.
 325         (struct tui_source_window_base) <reset>: Likewise.
 326
 327 2019-07-17  Tom Tromey  <tom@tromey.com>
 328
 329         * tui/tui-layout.c (show_source_disasm_command): Use
 330         reset_locator.
 331         (reset_locator): New function.
 332         (init_and_make_win): Remove.
 333         (show_source_or_disasm_and_command): Use reset_locator.
 334
 335 2019-07-17  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 338         condition.
 339         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 340         Remove condition.
 341         * tui/tui-source.c (tui_source_window_base::reset): New method.
 342         * tui/tui-layout.c (make_command_window): Don't call
 343         init_and_make_win.
 344         (make_source_window, make_disasm_window): Don't call
 345         make_source_or_disasm_window.
 346         (make_data_window): Don't call init_and_make_win.  Change calling
 347         convention.
 348         (show_source_disasm_command, show_data): Simplify.
 349         (make_source_or_disasm_window): Remove.
 350         (show_source_or_disasm_and_command): Simplify.
 351         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 352         (struct tui_source_window_base) <reset>: Likewise.
 353         <execution_info>: Remove initializer.
 354         * tui/tui-data.c (tui_source_window_base): Initialize
 355         execution_info.
 356
 357 2019-07-17  Tom Tromey  <tom@tromey.com>
 358
 359         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 360         variable.
 361
 362 2019-07-17  Tom Tromey  <tom@tromey.com>
 363
 364         * tui/tui.c (tui_rl_other_window): Update.
 365         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 366         superclass method first.  Always iterate over regs_content.
 367         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 368         method.
 369         * tui/tui-win.c (tui_set_focus_command): Update.
 370
 371 2019-07-17  Tom Tromey  <tom@tromey.com>
 372
 373         * tui/tui-win.c (tui_set_focus_command): Rename from
 374         tui_set_focus.  Call tui_enable.
 375         (tui_set_focus_command): Remove.
 376
 377 2019-07-17  Tom Tromey  <tom@tromey.com>
 378
 379         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 380         refresh_window.
 381         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 382         touchwin.
 383         (tui_data_window::refresh_window): Call refresh_window on data
 384         items.  Always call superclass refresh_window.
 385         (tui_win_info::refresh): Remove.
 386         (tui_source_window_base::refresh_window): Update.
 387         (tui_refresh_all): Update.
 388         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 389         refresh_window.
 390         (show_source_or_disasm_and_command): Likewise.
 391         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 392         (struct tui_source_window_base) <refresh>: Likewise.
 393
 394 2019-07-17  Tom Tromey  <tom@tromey.com>
 395
 396         * tui/tui-winsource.c (tui_clear_source_content)
 397         (tui_show_source_content): Update.
 398         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 399         whether content is empty.
 400         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 401         Remove.
 402
 403 2019-07-17  Tom Tromey  <tom@tromey.com>
 404
 405         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 406         window's contents.
 407         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 408         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 409
 410 2019-07-17  Tom Tromey  <tom@tromey.com>
 411
 412         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 413         (struct tui_data_item_window): Update.
 414
 415 2019-07-17  Tom Tromey  <tom@tromey.com>
 416
 417         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 418         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 419         defines.
 420
 421 2019-07-17  Tom Tromey  <tom@tromey.com>
 422
 423         * tui/tui-winsource.h (tui_erase_source_content)
 424         (tui_clear_source_content): Remove "display_prompt" parameter.
 425         * tui/tui-winsource.c (tui_update_source_window_as_is)
 426         (tui_update_source_windows_with_addr): Update.
 427         (tui_clear_source_content): Remove "display_prompt" parameter.
 428         (tui_erase_source_content): Likewise.  Simplify.
 429         (tui_show_source_content): Update.
 430         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 431         * tui/tui-stack.c (tui_show_frame_info): Update.
 432         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 433         Remove defines.
 434
 435 2019-07-17  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 438         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 439         parameter.
 440         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 441         parameter.
 442
 443 2019-07-17  Tom Tromey  <tom@tromey.com>
 444
 445         * tui/tui-winsource.c (tui_clear_source_content)
 446         (tui_show_source_content, tui_show_exec_info_content)
 447         (tui_clear_exec_info_content): Update.
 448         * tui/tui-stack.c (tui_show_locator_content): Update.
 449         (tui_show_frame_info): Update.
 450         * tui/tui-source.h (tui_source_window): Don't declare.
 451         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 452         from tui_source_is_displayed.
 453         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 454         Remove field.
 455         (struct tui_source_window_base) <content_in_use>: New field.  Now
 456         bool.
 457         (struct tui_source_window) <showing_source_p>: New method.
 458         (TUI_SRC_WIN): Change cast.
 459         * tui/tui-data.c (tui_initialize_static_data): Update.
 460
 461 2019-07-17  Tom Tromey  <tom@tromey.com>
 462
 463         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 464         location_matches_p.
 465         * tui/tui-source.c (tui_source_window::location_matches_p): New
 466         method.
 467         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 468         method.
 469         * tui/tui-data.h (struct tui_source_window_base)
 470         <location_matches_p>: New method.
 471         (struct tui_source_window, struct tui_disasm_window)
 472         <location_matches_p>: Likewise.
 473
 474 2019-07-17  Tom Tromey  <tom@tromey.com>
 475
 476         * tui/tui-win.c (tui_set_win_height_command): Rename from
 477         tui_set_win_height.
 478         (tui_set_win_height_command): Remove.
 479
 480 2019-07-17  Tom Tromey  <tom@tromey.com>
 481
 482         * tui/tui-source.c (tui_source_window): New constructor.  Add
 483         observer.
 484         (~tui_source_window): New destructor.
 485         (tui_source_window::style_changed): New method.
 486         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 487         (tui_attach_detach_observers): Update.
 488         * tui/tui-data.h (struct tui_source_window): Make constructor not
 489         inline.  Add destructor.
 490         (struct tui_source_window) <style_changed>: New method.
 491         <m_observable>: New member.
 492
 493 2019-07-17  Tom Tromey  <tom@tromey.com>
 494
 495         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 496         * tui/tui-win.c (tui_resize_all): Fix typo.
 497
 498 2019-07-17  Tom Tromey  <tom@tromey.com>
 499
 500         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 501         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 502         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 503         * tui/tui-win.c (window_name_completer): Use foreach.
 504         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 505         (update_tab_width): Likewise.
 506         * tui/tui-layout.c (show_layout): Update.
 507         * tui/tui-data.h (class tui_window_iterator): New.
 508         (struct all_tui_windows): New.
 509         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 510
 511 2019-07-17  Tom Tromey  <tom@tromey.com>
 512
 513         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 514         parameter.  Don't reference globals.
 515         (tui_reg_command): Update.
 516
 517 2019-07-17  Tom Tromey  <tom@tromey.com>
 518
 519         * tui/tui-regs.c (tui_show_registers): Simplify.
 520
 521 2019-07-17  Tom Tromey  <tom@tromey.com>
 522
 523         * tui/tui-regs.c (tui_show_registers): Update.
 524         (tui_show_register_group): Add win_info parameter.
 525
 526 2019-07-17  Tom Tromey  <tom@tromey.com>
 527
 528         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 529         Rename from tui_display_reg_element_at_line.
 530         (tui_data_window::display_registers_from_line): Update.
 531         * tui/tui-data.h (struct tui_data_window)
 532         <display_reg_element_at_line>: New method.
 533
 534 2019-07-17  Tom Tromey  <tom@tromey.com>
 535
 536         * tui/tui-regs.h (tui_display_registers_from)
 537         (tui_display_registers_from_line): Don't declare.
 538         * tui/tui-windata.c (tui_data_window::display_all_data)
 539         (tui_data_window::refresh_all)
 540         (tui_data_window::do_scroll_vertical): Update.
 541         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 542         from tui_display_registers_from.
 543         (tui_display_reg_element_at_line): Update.
 544         (tui_data_window::display_registers_from_line): Rename from
 545         tui_display_registers_from_line.
 546         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 547         display_registers_from_line>: New methods.
 548
 549 2019-07-17  Tom Tromey  <tom@tromey.com>
 550
 551         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 552         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 553         from tui_erase_data_content.
 554         (tui_data_window::display_all_data)
 555         (tui_data_window::refresh_all)
 556         (tui_data_window::do_scroll_vertical): Update.
 557         * tui/tui-regs.c (tui_show_registers): Update.
 558         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 559         New method.
 560
 561 2019-07-17  Tom Tromey  <tom@tromey.com>
 562
 563         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 564         declare.
 565         * tui/tui-windata.c
 566         (tui_data_window::delete_data_content_windows): Rename from
 567         tui_delete_data_content_windows.
 568         (tui_data_window::display_all_data)
 569         (tui_data_window::do_scroll_vertical): Update.
 570         * tui/tui-data.h (struct tui_data_window)
 571         <delete_data_content_windows>: New method.
 572
 573 2019-07-17  Tom Tromey  <tom@tromey.com>
 574
 575         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 576         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 577
 578 2019-07-17  Tom Tromey  <tom@tromey.com>
 579
 580         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 581         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 582         from tui_display_all_data.
 583         * tui/tui-win.c
 584         (tui_data_window::do_make_visible_with_new_height): Update.
 585         * tui/tui-regs.c (tui_show_registers): Update.
 586         * tui/tui-layout.c (tui_set_layout): Update.
 587         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 588         method.
 589
 590 2019-07-17  Tom Tromey  <tom@tromey.com>
 591
 592         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 593         * tui/tui-windata.c (tui_display_data_from): Remove.
 594         (tui_data_window::refresh_all): Update.
 595
 596 2019-07-17  Tom Tromey  <tom@tromey.com>
 597
 598         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 599         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 600         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 601         tui_display_registers_from_line.
 602         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 603         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 604         "force_display" parameter.
 605
 606 2019-07-17  Tom Tromey  <tom@tromey.com>
 607
 608         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 609         declare.
 610         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 611         Rename from tui_first_reg_element_no_inline.
 612         (tui_display_reg_element_at_line)
 613         (tui_display_registers_from_line): Update.
 614         * tui/tui-data.h (struct tui_data_window)
 615         <first_reg_element_no_inline>: New method.
 616
 617 2019-07-17  Tom Tromey  <tom@tromey.com>
 618
 619         * tui/tui-windata.c (tui_display_data_from)
 620         (tui_data_window::do_scroll_vertical): Update.
 621         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 622         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 623         Rename from tui_line_from_reg_element_no.
 624         (tui_display_registers_from_line): Update.
 625         * tui/tui-data.h (struct tui_data_window)
 626         <line_from_reg_element_no>: New method.
 627
 628 2019-07-17  Tom Tromey  <tom@tromey.com>
 629
 630         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 631         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 632         tui_last_regs_line_no.
 633         (tui_display_reg_element_at_line)
 634         (tui_display_registers_from_line): Update.
 635         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 636         method.
 637
 638 2019-07-17  Tom Tromey  <tom@tromey.com>
 639
 640         PR tui/24722:
 641         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 642         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 643         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 644         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 645         (tui_update_breakpoint_info): Likewise.
 646         * tui/tui-hooks.c (tui_event_create_breakpoint)
 647         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 648         Update.
 649
 650 2019-07-17  Tom Tromey  <tom@tromey.com>
 651
 652         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 653
 654 2019-07-17  Tom Tromey  <tom@tromey.com>
 655
 656         * tui/tui-winsource.c (tui_update_source_window_as_is)
 657         (tui_update_source_windows_with_addr): Update.
 658         * tui/tui-source.h (tui_set_source_content)
 659         (tui_show_symtab_source): Add "win_info" parameter.
 660         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 661         parameter.
 662         (tui_show_symtab_source): Likewise.
 663
 664 2019-07-17  Tom Tromey  <tom@tromey.com>
 665
 666         * tui/tui-wingeneral.c
 667         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 668
 669 2019-07-17  Tom Tromey  <tom@tromey.com>
 670
 671         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 672         (struct tui_cmd_window) <can_scroll>: New method.
 673         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 674         method.
 675
 676 2019-07-17  Tom Tromey  <tromey@adacore.com>
 677
 678         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 679         do_field_signed>: Rename.  Change type of "value".
 680         * ui-out.c (ui_out::field_signed): Rename from field_int.
 681         Change type of "value".
 682         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 683         type of "value".
 684         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 685         do_field_int.  Change type of "value".
 686         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 687         do_field_int.  Change type of "value".
 688         * tracepoint.c (trace_status_mi, tfind_1)
 689         (print_one_static_tracepoint_marker): Update.
 690         * thread.c (print_thread_info_1, print_selected_thread_frame):
 691         Update.
 692         * stack.c (print_frame, print_frame_info): Update.
 693         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 694         Update.
 695         * source.c (print_source_lines_base): Update.
 696         * skip.c (info_skip_command): Update.
 697         * record-btrace.c (btrace_ui_out_decode_error)
 698         (btrace_call_history_src_line): Update.
 699         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 700         Update.
 701         * progspace.c (print_program_space): Update.
 702         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 703         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 704         do_field_int.  Change type of "value".
 705         * mi/mi-out.c (mi_ui_out::do_table_begin)
 706         (mi_ui_out::do_table_header): Update.
 707         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 708         type of "value".
 709         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 710         (mi_cmd_data_list_changed_registers, output_register)
 711         (mi_cmd_data_read_memory, mi_load_progress)
 712         (mi_cmd_trace_frame_collected): Update.
 713         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 714         Update.
 715         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 716         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 717         (mi_cmd_var_list_children, varobj_update_one): Update.
 718         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 719         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 720         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 721         * inferior.c (print_inferior): Update.
 722         * gdb_bfd.c (print_one_bfd): Update.
 723         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 724         Update.
 725         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 726         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 727         do_field_int.  Change type of "value".
 728         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 729         do_field_int.  Change type of "value".
 730         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 731         (print_one_breakpoint_location, print_it_catch_fork)
 732         (print_one_catch_fork, print_it_catch_vfork)
 733         (print_one_catch_vfork, print_it_catch_solib)
 734         (print_it_catch_exec, print_it_ranged_breakpoint)
 735         (print_mention_watchpoint, print_mention_masked_watchpoint)
 736         (bkpt_print_it, update_static_tracepoint): Update.
 737         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 738         * break-catch-syscall.c (print_it_catch_syscall): Update.
 739         * ada-tasks.c (print_ada_task_info): Update.
 740         * ada-lang.c (print_it_exception, print_mention_exception):
 741         Update.
 742
 743 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 744
 745         PR breakpoints/24541
 746         * gdbarch.c: Regenerate.
 747         * gdbarch.h: Regenerate.
 748         * gdbarch.sh: Adjust return type and parameter types for
 749         'stap_adjust_register'.
 750         (i386_stap_adjust_register): Adjust signature and return new
 751         register name.
 752         * stap-probe.c (stap_parse_register_operand): Adjust use of
 753         'gdbarch_stap_adjust_register'.
 754
 755 2019-07-17  Tom Tromey  <tromey@adacore.com>
 756
 757         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 758         declare VEC.
 759         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 760         std::vector.
 761         (struct s390_process_info): Add initializers.
 762         (s390_add_process): Use new.
 763         (s390_linux_nat_target::low_forget_process): Use delete.
 764         (s390_linux_nat_target::low_new_fork)
 765         (s390_linux_nat_target::stopped_by_watchpoint)
 766         (s390_linux_nat_target::low_prepare_to_resume)
 767         (s390_linux_nat_target::insert_watchpoint)
 768         (s390_linux_nat_target::insert_hw_breakpoint)
 769         (s390_linux_nat_target::remove_watchpoint)
 770         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 771
 772 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 773
 774         * aarch64-fbsd-nat.c: Include regcache.h.
 775         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 776         argument.
 777         (aarch64_fbsd_nat_target::fetch_registers)
 778         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 779         variable.
 780         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 781
 782 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 783
 784         * fbsd-nat.c: Include gdbarch.h.
 785
 786 2019-07-15  Tom Tromey  <tromey@adacore.com>
 787
 788         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 789
 790 2019-07-15  Tom Tromey  <tromey@adacore.com>
 791
 792         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 793         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 794         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 795         * cli-out.c (cli_ui_out::do_field_int): New method.
 796         * ui-out.c (ui_out::field_unsigned): New method.
 797         * symfile.c (generic_load): Use field_unsigned.
 798         (print_transfer_performance): Likewise.
 799         * record-btrace.c (ui_out_field_uint): Remove.
 800         (btrace_call_history_insn_range, btrace_call_history): Use
 801         field_unsigned.
 802         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 803         field_unsigned.
 804         * ui-out.h (class ui_out) <field_unsigned>: New method.
 805         <do_field_unsigned>: Likewise.
 806
 807 2019-07-15  Tom Tromey  <tromey@adacore.com>
 808
 809         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 810         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 811         * target.c (flash_erase_command): Use field_string.
 812         * infrun.c (print_signal_received_reason): Use field_string.
 813         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 814         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 815         field_string.
 816         * ada-tasks.c (print_ada_task_info): Use field_string.
 817
 818 2019-07-15  Tom Tromey  <tromey@adacore.com>
 819
 820         * target.c (flash_erase_command): Use field_core_addr.
 821         * symfile.c (generic_load): Use field_core_addr.
 822         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 823         Use field_core_addr.
 824         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 825         field_core_addr.
 826
 827 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 828
 829         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 830         value if its desired type is smaller than a CORE_ADDR and signed.
 831
 832 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 833
 834         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 835         of changes to field names, and use new is_reference field to
 836         decide if a property is a reference or not.
 837         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 838         field.
 839         (struct dwarf2_property_baton): Update header comment, rename
 840         'referenced_type' to 'property_type' and update comments.
 841         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 842         default property type, store in property baton, update to take
 843         accound of renamed field.
 844         (read_func_scope): Update call to attr_to_dynamic_prop.
 845         (read_array_type): Likewise.
 846         (dwarf2_per_cu_addr_sized_int_type): New function.
 847         (read_subrange_index_type): Move type finding code to
 848         dwarf2_per_cu_addr_sized_int_type.
 849         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 850         (dwarf2_per_cu_addr_type): New function.
 851         (set_die_type): Update calls to attr_to_dynamic_prop.
 852
 853 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 854
 855         * dwarf2read.c (read_subrange_index_type): New function.
 856         (read_subrange_type): Move code into new function and call it.
 857         * gdbtypes.c (create_range_type): Add some asserts.
 858
 859 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 860
 861         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 862         update return statements.
 863         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 864         declaration, and update comment to match.
 865         * gdbtypes.c (resolve_dynamic_array): Update call to
 866         dwarf2_evaluate_property to match new return type.
 867
 868 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 869
 870         * valarith.c (value_subscripted_rvalue): Change lowerbound
 871         parameter type from int to LONGEST.
 872         * value.h (value_subscripted_rvalue): Likewise in declaration.
 873
 874 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 875
 876         * cli/cli-utils.c (info_print_command_completer): New function.
 877         * cli/cli-utils.h: Add 'completer.h' include, and forward
 878         declaration for 'struct cmd_list_element'.
 879         (info_print_command_completer): Declare.
 880         * stack.c (_initialize_stack): Add completer for 'info locals' and
 881         'info args'.
 882         * symtab.c (_initialize_symtab): Add completer for 'info
 883         variables' and 'info functions'.
 884         * NEWS: Mention completion for additional info commands.
 885
 886 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 887
 888         * cli/cli-utils.c (extract_info_print_args): Delete.
 889         (extract_arg_maybe_quoted): Delete.
 890         (info_print_options_defs): New variable.
 891         (make_info_print_options_def_group): New function.
 892         (extract_info_print_options): Define new function.
 893         * cli/cli-utils.h (extract_info_print_args): Delete.
 894         (struct info_print_options): New structure.
 895         (extract_info_print_options): Declare new function.
 896         * stack.c (info_locals_command): Update to use new
 897         extract_info_print_options, also add a header comment.
 898         (info_args_command): Likewise.
 899         * symtab.c (info_variables_command): Likewise.
 900         (info_functions_command): Likewise.
 901
 902 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 903
 904         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 905         to extract string arguments.
 906         * common/common-utils.c (extract_string_maybe_quoted): New function.
 907         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 908
 909 2019-07-11  Tom Tromey  <tromey@adacore.com>
 910
 911         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 912         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 913         * top.h (gdbinit): Don't declare.
 914         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 915         into...
 916         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 917         * top.c (gdb_init): Don't call init_cli_cmds.
 918         (gdbinit): Remove.
 919         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 920
 921 2019-07-11  Tom Tromey  <tromey@adacore.com>
 922
 923         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 924         after it has been moved.
 925
 926 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 927
 928         * valops.c (value_must_coerce_to_target): Change return type to
 929         bool.
 930         * value.h (value_must_coerce_to_target): Likewise.
 931
 932 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 933
 934         * breakpoint.c (is_hardware_watchpoint): Remove
 935         forward-declaration.
 936         (is_masked_watchpoint): Change return type to bool.
 937         (is_tracepoint): Likewise.
 938         (is_breakpoint): Likewise.
 939         (is_hardware_watchpoint): Likewise.
 940         (is_watchpoint): Likewise.
 941         (is_no_memory_software_watchpoint): Likewise.
 942         (is_catchpoint): Likewise.
 943         (breakpoint_1): Make FILTER parameter's return type bool.
 944         is_masked_watchpoint): Change return type to bool.
 945         (save_breakpoints): Make FILTER parameter's return type bool.
 946         * breakpoint.h (is_breakpoint): Change return type to bool.
 947         (is_watchpoint): Likewise.
 948         (is_catchpoint): Likewise.
 949         (is_tracepoint): Likewise.
 950
 951 2019-07-10  Tom Tromey  <tom@tromey.com>
 952
 953         * defs.h: Don't include gdbarch.h.
 954         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 955         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 956         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 957         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 958         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 959         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 960         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 961         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 962         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 963         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 964         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 965         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 966         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 967         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 968         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 969         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 970         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 971         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 972         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 973         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 974         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 975         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 976         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 977         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 978         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 979         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 980         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 981
 982 2019-07-10  Tom Tromey  <tromey@adacore.com>
 983
 984         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 985         * breakpoint.c (init_ada_exception_breakpoint): Register as
 986         bp_catchpoint.
 987         (print_one_breakpoint_location, print_one_breakpoint): Use
 988         is_ada_exception_catchpoint.
 989         * ada-lang.c (class ada_catchpoint_location): Pass
 990         bp_loc_software_breakpoint to bp_location constructor.
 991         (is_ada_exception_catchpoint): New function.
 992
 993 2019-07-10  Tom Tromey  <tromey@adacore.com>
 994
 995         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 996         VEC.
 997         (struct arm_exidx_entry): New method operator<.
 998         (struct arm_exidx_data) <section_maps>: Change type.
 999         (arm_exidx_data_free): Remove.
1000         (arm_exidx_data_key): Change type.  Move lower.
1001         (arm_exidx_new_objfile): Update.
1002         (arm_compare_exidx_entries): Remove.
1003         (arm_find_exidx_entry, _initialize_arm_tdep)
1004
1005 2019-07-10  Tom Tromey  <tromey@adacore.com>
1006
1007         * solib-spu.c (ocl_program_data_key): Change type.
1008         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1009         Update.
1010
1011 2019-07-10  Tom Tromey  <tromey@adacore.com>
1012
1013         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1014         (struct solib_aix_inferior_data) <library_list>: Change type.
1015         (solib_aix_inferior_data_handle): Change type.
1016         (get_solib_aix_inferior_data): Update.
1017         (solib_aix_free_library_list): Remove.
1018         (library_list_start_library): Update.
1019         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1020         return type.
1021         (solib_aix_get_library_list)
1022         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1023         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1024
1025 2019-07-10  Tom Tromey  <tromey@adacore.com>
1026
1027         * solib-dsbt.c (struct dsbt_info): Add initializers.
1028         (solib_dsbt_pspace_data): Change type.
1029         (dsbt_pspace_data_cleanup): Remove.
1030         (get_dsbt_info, _initialize_dsbt_solib): Update.
1031
1032 2019-07-10  Tom Tromey  <tromey@adacore.com>
1033
1034         * spu-tdep.c (spu_overlay_data): Change type.
1035         (spu_get_overlay_table, spu_overlay_new_objfile)
1036         (_initialize_spu_tdep): Update.
1037
1038 2019-07-10  Tom Tromey  <tromey@adacore.com>
1039
1040         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1041         destructor.
1042         (dbx_objfile_data_key): Change type and declare later.
1043         (DBX_SYMFILE_INFO): Rewrite.
1044         * dbxread.c (dbx_objfile_data_key): Change type.
1045         (dbx_symfile_init): Update.
1046         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1047         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1048         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1049
1050 2019-07-10  Tom Tromey  <tromey@adacore.com>
1051
1052         * jit.c (jit_program_space_key): Change type.  Move lower.
1053         (get_jit_program_space_data): Update.
1054         (jit_program_space_data_cleanup): Remove.
1055         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1056         Update.
1057         (struct jit_program_space_data): Add initializers.
1058
1059 2019-07-10  Tom Tromey  <tromey@adacore.com>
1060
1061         * solib-darwin.c (struct darwin_info): Add initializers.
1062         (solib_darwin_pspace_data): Change type.
1063         (darwin_pspace_data_cleanup): Remove.
1064         (get_darwin_info, _initialize_darwin_solib): Update.
1065
1066 2019-07-10  Tom Tromey  <tromey@adacore.com>
1067
1068         * remote-sim.c (struct sim_inferior_data): Add initializers,
1069         constructor, and destructor.
1070         (sim_inferior_data_key): Change type.  Move lower.
1071         (check_for_duplicate_sim_descriptor): Update.
1072         (get_sim_inferior_data): Use new.  Update.
1073         (~sim_inferior_data_cleanup): Rename from
1074         sim_inferior_data_cleanup.  Simplify.
1075         (gdbsim_close_inferior, simulator_command)
1076         (sim_command_completer, _initialize_remote_sim): Update.
1077         (next_pid, INITIAL_PID): Move earlier.
1078
1079 2019-07-10  Tom Tromey  <tromey@adacore.com>
1080
1081         * python/python-internal.h (create_thread_object): Return
1082         gdbpy_ref.
1083         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1084         * python/py-inferior.c (struct threadlist_entry): Add
1085         constructor.
1086         <thread_obj>: Now a gdbpy_ref.
1087         (thread_to_thread_object): Update.
1088         (add_thread_object): Use new.
1089         (delete_thread_object): Use delete.
1090         (infpy_threads): Update.
1091         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1092         GIL.
1093
1094 2019-07-10  Tom Tromey  <tromey@adacore.com>
1095
1096         * valops.c (value_cast): Specialize error message for Ada.
1097
1098 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1099
1100         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1101
1102 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1103
1104         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1105         bpstat_should_step): Return bool, adjust comments.
1106         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1107         bpstat_should_step): Likewise.
1108
1109 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1110
1111         * features/Makefile: Use feature target descriptions for Arm.
1112         * features/arm/arm-core.c: Generate new file.
1113         * features/arm/arm-fpa.c: Likewise.
1114         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1115         * features/arm/arm-m-profile.c: Likewise.
1116         * features/arm/arm-vfpv2.c: Likewise.
1117         * features/arm/arm-vfpv3.c: Likewise.
1118         * features/arm/xscale-iwmmxt.c: Likewise.
1119         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1120
1121 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1122
1123         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1124         ptrace earlier.
1125
1126 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1127
1128         * features/aarch64-pauth.c: Regenerate.
1129
1130 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1131
1132         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1133         bool.
1134         (bpstat_what): Use false instead of 0.
1135
1136 2019-07-09  Pedro Alves  <palves@redhat.com>
1137
1138         * break-catch-throw.c (is_exception_catchpoint): New.
1139         * breakpoint.c (print_one_breakpoint_location): New parameter
1140         'raw_loc'.  Handle it.  Use
1141         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1142         looking at the breakpoint's type.
1143         (print_one_breakpoint): If handling "maint info breakpoints", also
1144         print locations of exception catchpoints.
1145         * breakpoint.h (is_exception_catchpoint): Declare.
1146
1147 2019-07-09  Pedro Alves  <palves@redhat.com>
1148
1149         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1150         "addr" field.
1151         (allocate_location_exception_catchpoint): New.
1152         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1153         (initialize_throw_catchpoint_ops): Install
1154         allocate_location_exception_catchpoint as allocate_location
1155         method.
1156         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1157         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1158         bp_loc_other.
1159         (breakpoint_address_is_meaningful): Delete.
1160         (bl_address_is_meaningful): New.
1161         (breakpoint_locations_match): Adjust comment.
1162         (bp_location_from_bp_type): New, factored out of...
1163         (bp_location::bp_location(breakpoint *)): ... this.
1164         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1165         factored out of...
1166         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1167         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1168         breakpoint_address_is_meaningful.
1169         (bp_locations_compare): Adjust comment.
1170         (update_global_location_list): Use bl_address_is_meaningful
1171         instead of breakpoint_address_is_meaningful.
1172         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1173         explicit.
1174         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1175         * python/py-breakpoint.c (bppy_get_location): No longer check
1176         whether location is null.
1177
1178 2019-07-09  Pedro Alves  <palves@redhat.com>
1179
1180         PR c++/15468
1181         * breakpoint.c (print_one_breakpoint_location): Remove
1182         single-location assert.
1183
1184 2019-07-09  Tom Tromey  <tom@tromey.com>
1185
1186         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1187         * configure: Rebuild.
1188         * configure.ac: Change common to gdbsupport.
1189         * gdbsupport: Rename from common.
1190         * acinclude.m4: Change common to gdbsupport.
1191         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1192         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1193         gdbsupport.
1194         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1195         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1196         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1197         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1198         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1199         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1200         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1201         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1202         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1203         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1204         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1205         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1206         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1207         coff-pe-read.c, command.h, compile/compile-c-support.c,
1208         compile/compile-c.h, compile/compile-cplus-symbols.c,
1209         compile/compile-cplus-types.c, compile/compile-cplus.h,
1210         compile/compile-loc2c.c, compile/compile.c, completer.c,
1211         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1212         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1213         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1214         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1215         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1216         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1217         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1218         features/aarch64-core.c, features/aarch64-fpu.c,
1219         features/aarch64-pauth.c, features/aarch64-sve.c,
1220         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1221         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1222         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1223         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1224         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1225         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1226         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1227         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1228         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1229         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1230         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1231         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1232         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1233         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1234         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1235         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1236         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1237         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1238         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1239         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1240         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1241         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1242         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1243         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1244         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1245         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1246         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1247         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1248         minsyms.c, mips-linux-tdep.c, namespace.h,
1249         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1250         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1251         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1252         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1253         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1254         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1255         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1256         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1257         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1258         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1259         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1260         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1261         procfs.c, producer.c, progspace.h, psymtab.h,
1262         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1263         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1264         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1265         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1266         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1267         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1268         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1269         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1270         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1271         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1272         target-memory.c, target.c, target.h, target/waitstatus.c,
1273         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1274         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1275         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1276         unittests/array-view-selftests.c,
1277         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1278         unittests/common-utils-selftests.c,
1279         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1280         unittests/format_pieces-selftests.c,
1281         unittests/function-view-selftests.c,
1282         unittests/lookup_name_info-selftests.c,
1283         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1284         unittests/mkdir-recursive-selftests.c,
1285         unittests/observable-selftests.c,
1286         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1287         unittests/parse-connection-spec-selftests.c,
1288         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1289         unittests/scoped_fd-selftests.c,
1290         unittests/scoped_mmap-selftests.c,
1291         unittests/scoped_restore-selftests.c,
1292         unittests/string_view-selftests.c, unittests/style-selftests.c,
1293         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1294         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1295         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1296         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1297         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1298         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1299
1300 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1301
1302         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1303         bool value.
1304         (decode_digits_ordinary): Set explicit_line field in sal.
1305         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1306         symtab_and_line that was set on an explicit line number in
1307         assembler code.  Do always update the recorded symtab and line if
1308         we do skip the prologue.
1309
1310 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1311
1312         * breakpoint.c (set_breakpoint_location_function): Remove
1313         explicit_loc parameter.
1314         (momentary_breakpoint_from_master): Update call to
1315         set_breakpoint_location_function.
1316         (add_location_to_breakpoint): Likewise.
1317
1318 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1319
1320         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1321         required features based on default bfd type when no specific bfd
1322         is present.
1323
1324 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1325
1326         * NEWS: Mention that GDB printf and eval commands can now print
1327         C-style and Ada-style convenience var strings without
1328         calling the inferior.
1329         * printcmd.c (printf_c_string): Locally print GDB internal var
1330         instead of transiting via the inferior.
1331         (printf_wide_c_string): Likewise.
1332
1333 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1334
1335         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1336
1337 2019-07-04  Tom Tromey  <tom@tromey.com>
1338
1339         PR tui/24724:
1340         * tui/tui-winsource.c (tui_clear_source_content): Update.
1341         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1342         (tui_update_breakpoint_info): Update.
1343         (tui_set_exec_info_content): Update.
1344         * tui/tui-source.c (tui_set_source_content_nil): Update.
1345         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1346         has_break.
1347         * tui/tui-data.h (enum tui_bp_flag): New.
1348         (tui_bp_flags): New enum flags type.
1349         (struct tui_source_element) <break_mode>: Change type.  Rename
1350         from has_break.
1351         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1352         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1353         constants.
1354         * tui/tui-winsource.h: Fix comment.
1355
1356 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1357
1358         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1359         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1360         (store_fpregs_to_thread)
1361         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1362         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1363         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1364         (IWMMXT_REGS_SIZE): Add define.
1365         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1366         (fetch_vfp_regs, store_vfp_regs)
1367         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1368         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1369
1370 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1371
1372         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1373         defines.
1374         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1375         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1376         (ARM_INT_REGISTER_SIZE): ...to this.
1377         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1378         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1379         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1380         (arm_linux_collect_gregset, supply_nwfpe_register)
1381         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1382         defines.
1383         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1384         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1385         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1386         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1387         (arm_return_in_memory, arm_store_return_value)
1388         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1389         (arm_record_ld_st_multiple): Likewise.
1390         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1391         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1392
1393 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1394
1395         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1396         AARCH64_DISPLACED_MODIFIED_INSNS.
1397         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1398         (aarch64_displaced_step_copy_insn): Likewise.
1399         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1400         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1401         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1402         ARM_DISPLACED_MODIFIED_INSNS.
1403         * arm-tdep.c (arm_gdbarch_init): Likewise.
1404         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1405         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1406         (struct arm_displaced_step_closure): Use
1407         ARM_DISPLACED_MODIFIED_INSNS.
1408
1409 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1410
1411         * features/Makefile: Remove unused xml files.
1412         * features/aarch64.xml: Remove.
1413         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1414         * features/i386/amd64-avx-avx512.xml: Remove.
1415         * features/i386/amd64-avx-linux.xml: Remove.
1416         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1417         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1418         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1419         * features/i386/amd64-avx-mpx.xml: Remove.
1420         * features/i386/amd64-avx.xml: Remove.
1421         * features/i386/amd64-linux.xml: Remove.
1422         * features/i386/amd64-mpx-linux.xml: Remove.
1423         * features/i386/amd64-mpx.xml: Remove.
1424         * features/i386/amd64.xml: Remove.
1425         * features/i386/i386-avx-avx512-linux.xml: Remove.
1426         * features/i386/i386-avx-avx512.xml: Remove.
1427         * features/i386/i386-avx-linux.xml: Remove.
1428         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1429         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1430         * features/i386/i386-avx-mpx-linux.xml: Remove.
1431         * features/i386/i386-avx-mpx.xml: Remove.
1432         * features/i386/i386-avx.xml: Remove.
1433         * features/i386/i386-linux.xml: Remove.
1434         * features/i386/i386-mmx-linux.xml: Remove.
1435         * features/i386/i386-mmx.xml: Remove.
1436         * features/i386/i386-mpx-linux.xml: Remove.
1437         * features/i386/i386-mpx.xml: Remove.
1438         * features/i386/i386.xml: Remove.
1439         * features/i386/x32-avx-avx512-linux.xml: Remove.
1440         * features/i386/x32-avx-linux.xml: Remove.
1441         * features/i386/x32-linux.xml: Remove.
1442
1443 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1444
1445         * regformats/aarch64.dat: Remove.
1446         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1447         * regformats/i386/amd64-avx-linux.dat: Remove.
1448         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1449         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1450         * regformats/i386/amd64-linux.dat: Remove.
1451         * regformats/i386/amd64-mpx-linux.dat: Remove.
1452         * regformats/i386/amd64.dat: Remove.
1453         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1454         * regformats/i386/i386-avx-linux.dat: Remove.
1455         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1456         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1457         * regformats/i386/i386-linux.dat: Remove.
1458         * regformats/i386/i386-mmx-linux.dat: Remove.
1459         * regformats/i386/i386-mpx-linux.dat: Remove.
1460         * regformats/i386/i386.dat: Remove.
1461         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1462         * regformats/i386/x32-avx-linux.dat: Remove.
1463         * regformats/i386/x32-linux.dat: Remove.
1464
1465 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1466
1467         * aarch64-tdep.c: Remove xml self tests.
1468         * amd64-linux-tdep.c: Likewise.
1469         * amd64-tdep.c: Likewise.
1470         * i386-linux-tdep.c: Likewise.
1471         * i386-tdep.c: Likewise.
1472
1473 2019-07-03  Pedro Alves  <palves@redhat.com>
1474
1475         PR cli/24732
1476         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1477         (pipe_cmd_option_defs): New.
1478         (make_pipe_cmd_options_def_group): New.
1479         (pipe_command): Use gdb::option::process_options.
1480         (pipe_command_completer): New function.
1481         (_initialize_cli_cmds): Install completer for "pipe" command.
1482
1483 2019-07-03  Pedro Alves  <palves@redhat.com>
1484
1485         * cli/cli-option.c (union option_value) <string>: New field.
1486         (struct option_def_and_value): Add ctor, move ctor, dtor and
1487         use DISABLE_COPY_AND_ASSIGN.
1488         (option_def_and_value::clear_value): New.
1489         (parse_option, save_option_value_in_ctx, get_val_type_str)
1490         (add_setshow_cmds_for_options): Handle var_string.
1491         * cli-option.h (union option_def::var_address) <string>: New
1492         field.
1493         (struct string_option_def): New.
1494         * maint-test-options.c (struct test_options_opts): Add default
1495         ctor and use DISABLE_COPY_AND_ASSIGN.
1496         <string_opt>: New field.
1497         (test_options_opts::~test_options_opts): New.
1498         (test_options_opts::dump): Also dump "-string".
1499         (test_options_option_defs): Install "string.
1500
1501 2019-07-03  Pedro Alves  <palves@redhat.com>
1502
1503         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1504         option_value with a null enumeration.
1505         (complete_options): Save the option values in the context.
1506         (save_option_value_in_ctx): New, factored out from ...
1507         (process_options): ... here.
1508         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1509         of the function.
1510         * maint-test-options.c (test_options_opts::dump): New, factored
1511         out from ...
1512         (maintenance_test_options_command_mode): ... here.
1513         (maintenance_test_options_command_completion_result): Delete.
1514         (maintenance_test_options_command_completion_text): Update
1515         comment.
1516         (maintenance_show_test_options_completion_result): Change
1517         prototype.  Just print
1518         maintenance_test_options_command_completion_text.
1519         (save_completion_result): New.
1520         (maintenance_test_options_completer_mode): Pass options context to
1521         complete_options, and then save a dump.
1522         (_initialize_maint_test_options): Use add_cmd to install "maint
1523         show test-options-completion-result".
1524
1525 2019-07-03  Pedro Alves  <palves@redhat.com>
1526
1527         * NEWS (New commands): Mention "with" and "maint with".
1528         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1529         (with_command, with_command_completer): New.
1530         (pipe_command): Adjust to new repeat_previous
1531         interface.
1532         (_initialize_cli_cmds): Install the "with" command and its "w"
1533         alias.
1534         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1535         declarations.
1536         * cli/cli-setshow.c (parse_cli_var_uinteger)
1537         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1538         argument strings for all var_types.
1539         (get_setshow_command_value_string): New, factored out from ...
1540         (do_show_command): ... this.
1541         * cli/cli-setshow.h: Include <string>.
1542         (get_setshow_command_value_string): Declare.
1543         * command.h (repeat_previous): Now returns const char *.  Adjust
1544         comment.
1545         * maint.c: Include "cli/cli-cmds.h".
1546         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1547         (_initialize_maint_cmds): Register the "maintenance with" command.
1548         * top.c (repeat_previous): Move bits from pipe_command here:
1549         Return the saved command line, if any; error out if there's no
1550         command to relaunch.
1551
1552 2019-07-03  Pedro Alves  <palves@redhat.com>
1553
1554         * NEWS (New commands): Mention "maint set/show test-settings"
1555         instead of "maint test-settings".
1556         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1557         (maintenance_test_settings_set_list): Rename to ...
1558         (maintenance_set_test_settings_list): ... this.
1559         (maintenance_test_settings_show_list): Rename to  ...
1560         (maintenance_show_test_settings_list): ... this.
1561         (maintenance_test_settings_cmd): Delete.
1562         (maintenance_test_settings_set_cmd): ...
1563         (maintenance_set_test_settings_cmd): ... this.
1564         (maintenance_test_settings_show_cmd): ...
1565         (maintenance_show_test_settings_cmd): ... this.
1566         (maintenance_test_settings_show_value_cmd):
1567         (maintenance_show_test_settings_value_cmd): ... this.
1568         (_initialize_maint_test_settings): No longer install the "maint
1569         test-settings" prefix command.  Rename "maint test-settings set"
1570         to "maint set test-settings", and "maint test-settings show" to
1571         "maint show test-settings".  Adjust all subcommands.
1572
1573 2019-07-03  Pedro Alves  <palves@redhat.com>
1574
1575         * maint-test-settings.c: Fix file's intro comment.  Replace all
1576         references to "test-options" with references to "test-settings",
1577         in comments.
1578
1579 2019-07-03  Pedro Alves  <palves@redhat.com>
1580
1581         * maint-test-settings.c (maintenance_test_settings_xxx)
1582         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1583         New.
1584         (maintenance_test_settings_enums): Use them.
1585         (maintenance_test_settings_enum): Default to
1586         maintenance_test_settings_xxx.
1587         (_initialize_maint_test_settings): Initialize
1588         MAINTENANCE_TEST_SETTINGS_FILENAME.
1589
1590 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1591
1592         * breakpoint.h (remove_breakpoints_inf): Change return type to
1593         void, move function documentation here.
1594         * breakpoint.c (remove_breakpoints_inf): Change return type to
1595         void, move function documentation to header.
1596
1597 2019-07-02  Pedro Alves  <palves@redhat.com>
1598
1599         * NEWS (Completion improvements): Mention "info threads".
1600         * thread.c (struct info_threads_opts, info_threads_option_defs)
1601         (make_info_threads_options_def_group): New.
1602         (info_threads_command): Use gdb::option::process_options.
1603         (info_threads_command_completer): New.
1604         (_initialize_thread): Use gdb::option::build_help to build the
1605         help text for "info threads".
1606
1607 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1608
1609         * defs.h (generic_load): Move from here...
1610         * symfile.h (generic_load): ... to here.  Rename name parameter
1611         to args.
1612         * symfile.c (generic_load): Add comment.
1613
1614 2019-07-01  Tom Tromey  <tromey@adacore.com>
1615
1616         * dwarf2read.c
1617         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1618         declaration of without_params.  Fix formatting.
1619
1620 2019-07-01  Tom Tromey  <tromey@adacore.com>
1621
1622         * ada-exp.y (find_primitive_type): Update.
1623         * ada-lang.h (ada_lookup_symbol): Update.
1624         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1625         parameter.
1626         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1627
1628 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1629
1630         PR breakpoints/24541
1631         * gdbarch.c: Regenerate.
1632         * gdbarch.h: Regenerate.
1633         * gdbarch.sh: Add 'stap_adjust_register'.
1634         * i386-tdep.c: Include '<unordered_set>'.
1635         (i386_stap_adjust_register): New function.
1636         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1637         * stap-probe.c (stap_parse_register_operand): Call
1638         'gdbarch_stap_adjust_register'.
1639
1640 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1641
1642         PR python/24742
1643         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1644         * python/python.c (do_start_initialization): Use 'xmalloc'
1645         instead of 'PyMem_Malloc'.
1646
1647 2019-06-28  Tom Tromey  <tromey@adacore.com>
1648
1649         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1650         for Ada.
1651
1652 2019-06-27  Tom Tromey  <tromey@adacore.com>
1653
1654         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1655         objfile_key.
1656         (arm_find_mapping_symbol, arm_record_special_symbol)
1657         (_initialize_arm_tdep): Update.
1658         (arm_objfile_data_free): Remove.
1659
1660 2019-06-27  Tom Tromey  <tromey@adacore.com>
1661
1662         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1663         to cp_print_static_field.
1664
1665 2019-06-26  Tom Tromey  <tromey@adacore.com>
1666
1667         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1668         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1669         declare.
1670
1671 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1672
1673         * features/aarch64-core.c (create_feature_aarch64_core):
1674         Regenerate.
1675         * features/aarch64-core.xml: Add cpsr flags.
1676
1677 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1678
1679         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1680         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1681
1682 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1683
1684         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1685         field.
1686         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1687         use.
1688         (arm_record_special_symbol): Don't insert new symbol in sorted
1689         position, push it at the end.
1690
1691 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1692
1693         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1694         (arm_mapping_symbol_s): Remove.
1695         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1696         (arm_mapping_symbol_vec): New typedef.
1697         (struct arm_per_objfile): Add constructor.
1698         <section_maps>: Change type to
1699         std::unique_ptr<arm_mapping_symbol_vec[]>.
1700         (arm_compare_mapping_symbols): Remove.
1701         (arm_find_mapping_symbol): Adjust to section_maps type change.
1702         (arm_objfile_data_free): Call delete on arm_per_objfile.
1703         (arm_record_special_symbol): Adjust to section_maps type change.
1704         Allocate arm_per_objfile with new.
1705
1706 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1707
1708         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1709         with the command prefix.
1710
1711 2019-06-25  Tom Tromey  <tom@tromey.com>
1712
1713         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1714         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1715
1716 2019-06-25  Tom Tromey  <tom@tromey.com>
1717
1718         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1719         type.
1720         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1721         protected.
1722
1723 2019-06-25  Tom Tromey  <tom@tromey.com>
1724
1725         * tui/tui-winsource.c
1726         (tui_source_window_base::set_is_exec_point_at): Add check against
1727         LOA_ADDRESS.
1728
1729 2019-06-25  Tom Tromey  <tom@tromey.com>
1730
1731         * tui/tui-source.c (tui_set_source_content): Don't check before
1732         xfree.
1733         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1734
1735 2019-06-25  Tom Tromey  <tom@tromey.com>
1736
1737         * tui/tui-winsource.h (tui_update_source_window_as_is)
1738         (tui_alloc_source_buffer, tui_line_is_displayed)
1739         (tui_addr_is_displayed): Change type of win_info.
1740         * tui/tui-winsource.c (tui_update_source_window_as_is)
1741         (tui_clear_source_content, tui_show_source_line)
1742         (tui_show_source_content, tui_source_window_base::refill)
1743         (tui_source_window_base::set_is_exec_point_at)
1744         (tui_source_window_base::set_is_exec_point_at)
1745         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1746         (tui_alloc_source_buffer, tui_line_is_displayed)
1747         (tui_addr_is_displayed): Change type of win_info.  Update.
1748         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1749         (tui_source_window_base::do_make_visible_with_new_height):
1750         Update.
1751         * tui/tui-source.c (tui_set_source_content)
1752         (tui_set_source_content_nil)
1753         (tui_source_window::do_scroll_vertical): Update.
1754         * tui/tui-layout.c (show_layout): Update.
1755         * tui/tui-disasm.c (tui_set_disassem_content)
1756         (tui_disasm_window::do_scroll_vertical): Update.
1757         * tui/tui-data.h (tui_win_content): Remove.
1758         (struct tui_gen_win_info) <content, content_size>: Remove.
1759         (struct tui_source_element): Add initializers and destructor.
1760         (union tui_which_element, struct tui_win_element): Remove.
1761         (struct tui_source_window_base) <content>: New field.
1762         (struct tui_data_window): Remove destructor.
1763         (tui_alloc_content, tui_free_win_content)
1764         (tui_free_all_source_wins_content): Don't declare.
1765         * tui/tui-data.c (tui_initialize_static_data): Update.
1766         (init_content_element, tui_alloc_content): Remove.
1767         (~tui_gen_win_info): Update.
1768         (~tui_data_window, tui_free_all_source_wins_content)
1769         (tui_free_win_content, free_content, free_content_elements):
1770         Remove.
1771
1772 2019-06-25  Tom Tromey  <tom@tromey.com>
1773
1774         * tui/tui-winsource.h (tui_clear_source_content)
1775         (tui_erase_source_content, tui_show_source_content): Change type
1776         of win_info.
1777         * tui/tui-winsource.c (tui_clear_source_content)
1778         (tui_erase_source_content, tui_show_source_content): Change type
1779         of win_info.
1780         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1781         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1782         win_info.
1783         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1784         win_info.
1785         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1786
1787 2019-06-25  Tom Tromey  <tom@tromey.com>
1788
1789         * tui/tui-winsource.c (tui_clear_source_content)
1790         (tui_source_window_base::set_is_exec_point_at): Update.
1791         * tui/tui-source.c (tui_set_source_content_nil): Update.
1792         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1793         a bool.
1794         * tui/tui-data.c (init_content_element): Update.
1795
1796 2019-06-25  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1799         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1800         * tui/tui-layout.c (init_and_make_win): Update.
1801         * tui/tui.h (enum tui_win_type): Update.
1802         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1803         tui_win_is_auxillary.
1804         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1805         tui_win_is_auxillary.
1806
1807 2019-06-25  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1810         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1811         (tui_delete_data_content_windows, tui_display_all_data)
1812         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1813         Update.
1814         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1815         * tui/tui-regs.c (tui_last_regs_line_no)
1816         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1817         (tui_show_registers): Update.
1818         (tui_show_register_group): Return void.  Update.
1819         (tui_display_registers_from, tui_display_reg_element_at_line)
1820         (tui_display_registers_from_line, tui_check_register_values):
1821         Update.
1822         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1823         member.
1824         (struct tui_data_window) <regs_content>: Now a std::vector.
1825         <regs_content_count>: Remove.
1826         (tui_add_content_elements, tui_free_data_content): Don't declare.
1827         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1828         (init_content_element): Remove DATA_WIN case.  Add assert.
1829         (tui_add_content_elements): Remove.
1830         (tui_data_window): Update.
1831         (tui_free_data_content): Remove.
1832         (free_content_elements): Remove DATA_WIN case.
1833
1834 2019-06-25  Tom Tromey  <tom@tromey.com>
1835
1836         * tui/tui-data.c (tui_data_item_window): Update.
1837         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1838         * tui/tui-windata.c (tui_display_all_data)
1839         (tui_display_data_from_line): Update.
1840         (tui_check_data_values): Remove.
1841         * tui/tui-regs.c (tui_show_register_group)
1842         (tui_display_reg_element_at_line): Update.
1843         * tui/tui-hooks.c (tui_register_changed)
1844         (tui_refresh_frame_and_register_information): Call
1845         tui_check_register_values.
1846         * tui/tui-data.h (struct tui_data_window) <data_content,
1847         data_content_count, data_type>: Remove.
1848         (enum tui_data_type): Remove.
1849
1850         * tui/tui-data.c (tui_data_window::clear_detail)
1851         (~tui_data_window): Update.
1852
1853 2019-06-25  Tom Tromey  <tom@tromey.com>
1854
1855         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1856         declare.
1857         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1858         Rename from tui_first_data_item_displayed.  Update.
1859         (tui_data_window::refresh_all)
1860         (tui_data_window::do_scroll_vertical): Update.
1861         * tui/tui-data.h (struct tui_data_window)
1862         <first_data_item_displayed>: Declare new method.
1863
1864 2019-06-25  Tom Tromey  <tom@tromey.com>
1865
1866         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1867         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1868         contents...
1869         (tui_initialize_static_data): ...here.
1870
1871 2019-06-25  Tom Tromey  <tom@tromey.com>
1872
1873         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1874         (tui_display_registers_from, tui_check_register_values): Update.
1875         (tui_display_register): Remove win_info parameter; update.
1876         (tui_get_register): Change type of parameters.
1877         * tui/tui-data.h (struct tui_data_element): Remove.
1878         (union tui_which_element) <data>: Remove.
1879         <data_window>: Change type.
1880         (struct tui_data_item_window): New.
1881         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1882         case.  Add assert.
1883         (~tui_data_item_window): New destructor.
1884         (free_content_elements): Remove DATA_ITEM_WIN case.
1885
1886 2019-06-25  Tom Tromey  <tom@tromey.com>
1887
1888         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1889         Remove.
1890
1891 2019-06-25  Tom Tromey  <tom@tromey.com>
1892
1893         * tui/tui-data.h (struct tui_command_element): Remove.
1894         (union tui_which_element) <command>: Remove.
1895         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1896         assert.
1897         (free_content_elements): Remove CMD_WIN case.
1898
1899 2019-06-25  Tom Tromey  <tom@tromey.com>
1900
1901         * tui/tui-layout.c (tui_set_layout): Update.
1902         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1903         * tui/tui-data.c (layout_def): Update.
1904
1905 2019-06-25  Tom Tromey  <tom@tromey.com>
1906
1907         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1908         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1909         (tui_source_window_base::set_new_height): Update.
1910         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1911         Update.
1912         (tui_set_locator_fullname, tui_set_locator_info)
1913         (tui_show_frame_info): Update.
1914         * tui/tui-source.c (tui_set_source_content)
1915         (tui_source_is_displayed): Update.
1916         * tui/tui-layout.c (show_source_disasm_command, show_data)
1917         (show_source_or_disasm_and_command): Update.
1918         * tui/tui-disasm.c (tui_set_disassem_content)
1919         (tui_get_begin_asm_address): Update.
1920         * tui/tui-data.h (struct tui_locator_element): Remove.
1921         (union tui_which_element) <locator>: Remove.
1922         (struct tui_locator_window): New.
1923         (tui_locator_win_info_ptr): Change return type.
1924         * tui/tui-data.c (_locator): Change type.
1925         (tui_locator_win_info_ptr): Change return type.
1926         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1927         (tui_alloc_content): Add assert.
1928
1929 2019-06-25  Tom Tromey  <tom@tromey.com>
1930
1931         * tui/tui-winsource.c
1932         (tui_exec_info_window::maybe_allocate_content): New method.
1933         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1934         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1935         (make_source_or_disasm_window): Add cast.
1936         * tui/tui-data.h (union tui_which_element) <simple_string>:
1937         Remove.
1938         (struct tui_source_info): New.
1939         (struct tui_source_window_base) <execution_info>: Change type.
1940         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1941         case, and add assert.
1942         (tui_alloc_content): Add assert.
1943
1944 2019-06-25  Tom Tromey  <tom@tromey.com>
1945
1946         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1947         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1948         * tui/tui-data.c (tui_alloc_win_info): Remove.
1949
1950 2019-06-25  Tom Tromey  <tom@tromey.com>
1951
1952         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1953         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1954         can_highlight.
1955
1956 2019-06-25  Tom Tromey  <tom@tromey.com>
1957
1958         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1959         make_visible_with_new_height method.
1960         (tui_win_info::make_visible_with_new_height): New method.
1961         (tui_source_window_base::do_make_visible_with_new_height)
1962         (tui_data_window::do_make_visible_with_new_height)
1963         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1964         (make_visible_with_new_height): Remove.
1965         (tui_resize_all, tui_adjust_win_heights): Use
1966         make_visible_with_new_height method.
1967         * tui/tui-data.h (struct tui_win_info)
1968         <do_make_visible_with_new_height, make_visible_with_new_height>:
1969         New methods.
1970         (struct tui_source_window_base, struct tui_data_window)
1971         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1972         methods.
1973
1974 2019-06-25  Tom Tromey  <tom@tromey.com>
1975
1976         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1977         method.
1978         (update_tab_width): Call update_tab_width method.
1979         * tui/tui-data.h (struct tui_win_info)
1980         (struct tui_source_window_base) <update_tab_width>: New methods.
1981
1982 2019-06-25  Tom Tromey  <tom@tromey.com>
1983
1984         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1985         parameter.
1986         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1987         parameter.
1988         (tui_gen_win_info::make_visible): Update.
1989         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1990         parameter.
1991         * tui/tui-data.h (enum tui_box): New enum.
1992         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1993
1994 2019-06-25  Tom Tromey  <tom@tromey.com>
1995
1996         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1997         init_and_make_win for EXEC_INFO_WIN.
1998         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1999         longer inline.
2000         (struct tui_win_info) <~tui_win_info>: Inline.
2001         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2002         Don't declare.
2003         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2004         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2005         Remove.
2006         (tui_initialize_static_data): Update.
2007         (~tui_gen_win_info): Handle more cleanup here.
2008         (~tui_source_window_base): Delete "execution_info".
2009         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2010
2011 2019-06-25  Tom Tromey  <tom@tromey.com>
2012
2013         * tui/tui-layout.c (make_command_window): Don't set
2014         can_highlight.
2015         (show_source_disasm_command): Call the reset method.
2016         (show_data): Don't set can_highlight.  Call the reset method.
2017         (tui_gen_win_info::reset): Rename from init_gen_win_info
2018         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2019         (show_source_or_disasm_and_command): Call the reset method.
2020         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2021         (struct tui_cmd_window): Set can_highlight.
2022
2023 2019-06-25  Tom Tromey  <tom@tromey.com>
2024
2025         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2026         from make_visible.
2027         (tui_make_visible, tui_make_invisible): Rewrite.
2028         (tui_win_info::make_visible): Remove.
2029         (tui_source_window_base::make_visible): Update.
2030         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2031         method.  Moved from...
2032         (struct tui_win_info) <make_visible>: ...here.
2033
2034 2019-06-25  Tom Tromey  <tom@tromey.com>
2035
2036         * tui/tui-winsource.c
2037         (tui_source_window_base::do_scroll_horizontal): Remove direction
2038         parameter.
2039         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2040         direction parameter.
2041         * tui/tui-win.c (tui_win_info::forward_scroll)
2042         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2043         (tui_win_info::right_scroll): Update.
2044         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2045         direction parameter.
2046         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2047         direction parameter.
2048         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2049         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2050         Remove direction parameter.
2051         (struct tui_source_window_base, struct tui_source_window)
2052         (struct tui_disasm_window, struct tui_data_window)
2053         (struct tui_cmd_window): Update.
2054
2055 2019-06-25  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-winsource.h (tui_set_exec_info_content)
2058         (tui_show_exec_info_content, tui_erase_exec_info_content)
2059         (tui_clear_exec_info_content, tui_update_exec_info): Change
2060         argument to tui_source_window_base.
2061         * tui/tui-winsource.c (tui_set_exec_info_content)
2062         (tui_show_exec_info_content, tui_erase_exec_info_content)
2063         (tui_clear_exec_info_content, tui_update_exec_info): Change
2064         argument to tui_source_window_base.
2065
2066 2019-06-25  Tom Tromey  <tom@tromey.com>
2067
2068         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2069         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2070
2071 2019-06-25  Tom Tromey  <tom@tromey.com>
2072
2073         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2074         check.
2075
2076 2019-06-25  Tom Tromey  <tom@tromey.com>
2077
2078         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2079         type to void.
2080         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2081         type to void.
2082         * tui/tui-source.c (tui_set_source_content): Update.
2083         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2084
2085 2019-06-25  Tom Tromey  <tom@tromey.com>
2086
2087         * tui/tui-win.c (window_name_completer, tui_set_focus)
2088         (tui_all_windows_info): Use name method.
2089         * tui/tui-data.h (struct tui_gen_win_info)
2090         (struct tui_source_window, struct tui_disasm_window)
2091         (struct tui_data_window, struct tui_cmd_window) <name>: New
2092         method.
2093         (tui_win_name): Don't declare.
2094         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2095         (tui_win_name): Remove.
2096
2097 2019-06-25  Tom Tromey  <tom@tromey.com>
2098
2099         * tui/tui-winsource.h (tui_update_source_window)
2100         (tui_update_source_window_as_is): Change parameter type.
2101         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2102         to be a tui_source_window_base.
2103         (tui_update_source_window_as_is): Likewise.
2104         * tui/tui-win.c (make_visible_with_new_height): Update.
2105
2106 2019-06-25  Tom Tromey  <tom@tromey.com>
2107
2108         * tui/tui-winsource.c (tui_erase_source_content)
2109         (tui_show_source_content, tui_show_exec_info_content)
2110         (tui_erase_exec_info_content): Use refresh_window method.
2111         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2112         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2113         from tui_refresh_win.
2114         (tui_data_window::refresh_window): New method.
2115         (tui_win_info::refresh, tui_source_window_base::refresh)
2116         (tui_refresh_all): Use refresh_window method.
2117         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2118         method.
2119         * tui/tui-regs.c (tui_display_register): Call refresh_window
2120         method.
2121         * tui/tui-layout.c (show_source_disasm_command)
2122         (show_source_or_disasm_and_command): Call refresh_window method.
2123         * tui/tui-data.h (struct tui_gen_win_info)
2124         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2125         New method.
2126
2127 2019-06-25  Tom Tromey  <tom@tromey.com>
2128
2129         * tui/tui.c (tui_rl_other_window, tui_enable)
2130         (tui_is_window_visible, tui_get_command_dimension): Update.
2131         * tui/tui-winsource.c (tui_update_source_window_as_is)
2132         (tui_clear_source_content, tui_erase_source_content)
2133         (tui_show_source_line, tui_source_window_base::refill)
2134         (tui_source_window_base::do_scroll_horizontal)
2135         (tui_source_window_base::set_is_exec_point_at)
2136         (tui_update_breakpoint_info, tui_set_exec_info_content)
2137         (tui_alloc_source_buffer, tui_line_is_displayed)
2138         (tui_addr_is_displayed): Update.
2139         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2140         (tui_check_and_display_highlight_if_needed)
2141         (tui_win_info::make_visible, tui_win_info::refresh)
2142         (tui_refresh_all): Update.
2143         * tui/tui-windata.c (tui_first_data_item_displayed)
2144         (tui_delete_data_content_windows, tui_erase_data_content)
2145         (tui_display_all_data, tui_data_window::refresh_all)
2146         (tui_check_data_values): Update.
2147         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2148         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2149         (tui_win_info::backward_scroll, tui_refresh_all_win)
2150         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2151         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2152         (tui_source_window_base::set_new_height)
2153         (tui_data_window::set_new_height)
2154         (make_invisible_and_set_new_height)
2155         (make_visible_with_new_height, new_height_ok)
2156         (parse_scrolling_args): Update.
2157         * tui/tui-stack.c (tui_show_frame_info): Update.
2158         * tui/tui-source.c (tui_set_source_content)
2159         (tui_set_source_content_nil, tui_source_is_displayed)
2160         (tui_source_window::do_scroll_vertical): Update.
2161         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2162         (tui_display_registers_from, tui_display_reg_element_at_line)
2163         (tui_check_register_values, tui_reg_command): Update.
2164         * tui/tui-layout.c (tui_default_win_height)
2165         (show_source_disasm_command, show_data, init_and_make_win)
2166         (show_source_or_disasm_and_command): Update.
2167         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2168         (tui_redisplay_readline, tui_mld_flush)
2169         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2170         (tui_getc): Update.
2171         * tui/tui-disasm.c (tui_set_disassem_content)
2172         (tui_disasm_window::do_scroll_vertical): Update.
2173         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2174         Now virtual.
2175         (struct tui_win_info): Derive from tui_gen_win_info.
2176         <~tui_win_info>: Mark as override.
2177         <generic>: Remove member.
2178         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2179         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2180         (~tui_data_window, ~tui_win_info)
2181         (tui_free_all_source_wins_content): Update.
2182         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2183
2184 2019-06-25  Tom Tromey  <tom@tromey.com>
2185
2186         * tui/tui-layout.c (init_and_make_win): Use new.
2187         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2188         destructor, initializers.
2189         (tui_alloc_generic_win_info): Don't declare.
2190         * tui/tui-data.c (_locator): Add argument to constructor.
2191         (source_win, disasm_win): New globals.
2192         (exec_info): Remove.
2193         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2194         Update.
2195         (tui_alloc_generic_win_info): Remove.
2196         (init_content_element): Use new.
2197         (tui_win_info::tui_win_info): Update.
2198         (free_content_elements) <case DATA_WIN>: Use delete.
2199
2200 2019-06-25  Tom Tromey  <tom@tromey.com>
2201
2202         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2203         * tui/tui-windata.c (tui_first_data_item_displayed)
2204         (tui_delete_data_content_windows): Update.
2205         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2206         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2207         (tui_display_registers_from, tui_check_register_values): Update.
2208         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2209         pointer.
2210         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2211         window.
2212         (tui_free_data_content): Update.
2213         (free_content_elements) <case DATA_WIN>: Free the window.
2214
2215 2019-06-25  Tom Tromey  <tom@tromey.com>
2216
2217         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2218         Update.
2219         * tui/tui-layout.c (make_command_window)
2220         (show_source_disasm_command, show_data, init_and_make_win)
2221         (show_source_or_disasm_and_command): Update.
2222         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2223         method.
2224         <can_highight, is_highlighted>: Now bool.
2225         (tui_set_win_highlight): Don't declare.
2226         * tui/tui-data.c (tui_set_win_highlight): Remove.
2227
2228 2019-06-25  Tom Tromey  <tom@tromey.com>
2229
2230         * tui/tui-wingeneral.c (make_visible): Remove check of window
2231         type.
2232
2233 2019-06-25  Tom Tromey  <tom@tromey.com>
2234
2235         * tui/tui-win.c (tui_win_info::max_height)
2236         (tui_cmd_window::max_height): New methods.
2237         (new_height_ok): Call max_height.
2238         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2239         <max_height>: New method.
2240
2241 2019-06-25  Tom Tromey  <tom@tromey.com>
2242
2243         * tui/tui-win.c (tui_source_window_base::set_new_height)
2244         (tui_data_window::set_new_height): New methods.
2245         (make_invisible_and_set_new_height): Call set_new_height method.
2246         * tui/tui-data.h (struct tui_win_info)
2247         (struct tui_source_window_base, struct tui_data_window)
2248         <set_new_height>: New method.
2249
2250 2019-06-25  Tom Tromey  <tom@tromey.com>
2251
2252         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2253         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2254         tui_refresh_data_win.
2255         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2256         method.
2257         (tui_refresh_all_win): Call the refresh_all method.
2258         (tui_set_focus): Likewise.
2259         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2260         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2261         Likewise.
2262
2263 2019-06-25  Tom Tromey  <tom@tromey.com>
2264
2265         * tui/tui-winsource.h (tui_refill_source_window)
2266         (tui_set_is_exec_point_at): Don't declare.
2267         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2268         (tui_source_window_base::refill): Rename from
2269         tui_refill_source_window.
2270         (tui_source_window_base::do_scroll_horizontal): Update.
2271         (tui_source_window_base::set_is_exec_point_at): Rename from
2272         tui_set_is_exec_point_at.
2273         (tui_update_all_breakpoint_info): Update.
2274         * tui/tui-stack.c (tui_show_frame_info): Update.
2275         * tui/tui-layout.c (show_data): Add cast.
2276         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2277         * tui/tui-data.h (struct tui_source_window_base) <refill,
2278         set_is_exec_point_at>: New methods.
2279         (tui_source_windows, tui_add_to_source_windows): Update types.
2280         (tui_add_to_source_windows): Remove redundant declaration.
2281         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2282         (tui_source_windows): Change return type.
2283         (tui_clear_source_windows_detail): Update.
2284         (tui_add_to_source_windows): Change type of parameter.
2285         (tui_free_all_source_wins_content): Update.
2286
2287 2019-06-25  Tom Tromey  <tom@tromey.com>
2288
2289         * tui/tui-wingeneral.c (tui_win_info::refresh)
2290         (tui_source_window_base::refresh): New methods.
2291         (tui_refresh_all): Call the refresh method.
2292         * tui/tui-data.h (struct tui_win_info)
2293         (struct tui_source_window_base) <refresh>: New method.
2294
2295 2019-06-25  Tom Tromey  <tom@tromey.com>
2296
2297         * tui/tui.h (tui_is_window_visible): Return bool.
2298         * tui/tui.c (tui_is_window_visible): Return bool.
2299         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2300         (tui_make_visible, tui_make_invisible)
2301         (tui_win_info::make_visible)
2302         (tui_source_window_base::make_visible, make_all_visible)
2303         (tui_make_all_visible, tui_make_all_invisible): Update.
2304         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2305         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2306         bool.
2307         (struct tui_win_info, struct tui_source_window_base)
2308         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2309         * tui/tui-data.c (tui_init_generic_part): Update.
2310
2311 2019-06-25  Tom Tromey  <tom@tromey.com>
2312
2313         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2314         (tui_source_window_base::make_visible): New methods.
2315         (make_all_visible): Make method call.
2316         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2317         (struct tui_source_window_base, struct tui_cmd_window): Override
2318         make_visible.
2319         (tui_win_is_source_type): Don't declare.
2320         * tui/tui-data.c (tui_win_is_source_type): Remove.
2321
2322 2019-06-25  Tom Tromey  <tom@tromey.com>
2323
2324         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2325         NULL check.
2326
2327 2019-06-25  Tom Tromey  <tom@tromey.com>
2328
2329         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2330         Inline constructor.  Add initializers for members.
2331         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2332         constructors; now inline in class.
2333
2334 2019-06-25  Tom Tromey  <tom@tromey.com>
2335
2336         * tui/tui-regs.c (tui_show_registers): Update.
2337         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2338         bool.
2339         * tui/tui-data.c (tui_data_window::clear_detail)
2340         (tui_data_window): Update.
2341
2342 2019-06-25  Tom Tromey  <tom@tromey.com>
2343
2344         * tui/tui-windata.c (tui_display_all_data)
2345         (tui_display_data_from_line, tui_display_data_from)
2346         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2347         Update.
2348         * tui/tui-regs.c (tui_last_regs_line_no)
2349         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2350         (tui_show_registers, tui_show_register_group)
2351         (tui_display_registers_from, tui_display_reg_element_at_line)
2352         (tui_display_registers_from_line, tui_check_register_values)
2353         (tui_reg_next, tui_reg_prev): Update.
2354         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2355         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2356         tui_data_window.
2357         (struct tui_win_info) <detail>: Remove.  Add new fields from
2358         tui_data_info.
2359         (TUI_DATA_WIN): Add cast.
2360         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2361         (~tui_data_window): Simplify.
2362
2363 2019-06-25  Tom Tromey  <tom@tromey.com>
2364
2365         * tui/tui-layout.c (show_source_disasm_command)
2366         (show_source_or_disasm_and_command): Update.
2367         * tui/tui-io.c (update_cmdwin_start_line)
2368         (tui_redisplay_readline): Update.
2369         * tui/tui-data.h (struct tui_command_info): Remove.
2370         (struct tui_win_info) <detail>: Remove command_info member.
2371         (struct tui_data_window) <start_line>: New member, from
2372         tui_command_info.
2373         (TUI_CMD_WIN): Add casts.
2374
2375 2019-06-25  Tom Tromey  <tom@tromey.com>
2376
2377         * tui/tui-winsource.c (tui_update_source_window)
2378         (tui_refill_source_window)
2379         (tui_source_window_base::do_scroll_horizontal)
2380         (tui_update_breakpoint_info, tui_set_exec_info_content)
2381         (tui_show_exec_info_content, tui_erase_exec_info_content)
2382         (tui_clear_exec_info_content): Update.
2383         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2384         Update.
2385         * tui/tui-win.c (make_invisible_and_set_new_height)
2386         (make_visible_with_new_height): Update.
2387         * tui/tui-source.c (tui_set_source_content)
2388         (tui_show_symtab_source): Update.
2389         * tui/tui-layout.c (extract_display_start_addr)
2390         (show_source_disasm_command, show_data)
2391         (make_source_or_disasm_window)
2392         (show_source_or_disasm_and_command): Update.
2393         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2394         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2395         "gdbarch".
2396         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2397         to tui_source_window_base.
2398         (struct tui_win_info) <detail>: Remove source_info member.
2399         (struct tui_source_window_base) <has_locator>: Inline.
2400         Move contents from tui_source_info; rename has_locator member to
2401         m_has_locator.
2402         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2403         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2404         header file.
2405         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2406         Simplify.
2407         (tui_free_all_source_wins_content): Cast to
2408         tui_source_window_base.
2409
2410 2019-06-25  Tom Tromey  <tom@tromey.com>
2411
2412         * tui/tui-win.c (make_invisible_and_set_new_height)
2413         (make_visible_with_new_height): Call has_locator method.
2414         * tui/tui-layout.c (show_source_disasm_command, show_data)
2415         (show_source_or_disasm_and_command): Update for bool change.
2416         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2417         (tui_win_info) <has_locator>: New method.
2418         (struct tui_source_window_base) <has_locator>: New method.
2419         (tui_win_has_locator): Don't declare.
2420         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2421         from tui_win_has_locator.
2422         (tui_source_window_base): Use false, not FALSE.
2423
2424 2019-06-25  Tom Tromey  <tom@tromey.com>
2425
2426         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2427         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2428         clear_detail method directly.
2429         (tui_clear_win_detail): Remove.
2430
2431 2019-06-25  Tom Tromey  <tom@tromey.com>
2432
2433         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2434         "this", not TUI_DISASM_WIN.
2435
2436 2019-06-25  Tom Tromey  <tom@tromey.com>
2437
2438         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2439         declare.
2440         * tui/tui-winsource.c
2441         (tui_source_window_base::do_scroll_horizontal): Rename from
2442         tui_horizontal_source_scroll.
2443         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2444         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2445         from tui_vertical_data_scroll.
2446         * tui/tui-win.h (tui_scroll): Don't declare.
2447         * tui/tui-win.c (tui_win_info::forward_scroll)
2448         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2449         (tui_win_info::right_scroll): Rename and update.
2450         (tui_scroll_forward_command, tui_scroll_backward_command)
2451         (tui_scroll_left_command, tui_scroll_right_command): Update.
2452         (tui_scroll): Remove.
2453         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2454         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2455         from tui_vertical_source_scroll.
2456         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2457         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2458         from tui_vertical_disassem_scroll.
2459         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2460         do_scroll_horizontal>: New methods.
2461         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2462         Likewise.
2463         (struct tui_source_window_base): Add do_scroll_horizontal.
2464         (struct tui_source_window, struct tui_disasm_window): Add
2465         do_scroll_vertical.
2466         (struct tui_data_window, struct tui_cmd_window): Add
2467         do_scroll_horizontal and do_scroll_vertical.
2468         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2469
2470 2019-06-25  Tom Tromey  <tom@tromey.com>
2471
2472         * tui/tui-data.h (struct tui_source_window_base): New struct.
2473         (struct tui_source_window): Derive from tui_source_window_base.
2474         (struct tui_disasm_window): New struct.
2475         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2476         from tui_source_window::clear_detail.
2477         (tui_source_window_base): Rename from tui_source_window.
2478         (~tui_source_window_base): Rename from ~tui_source_window.
2479         (tui_alloc_win_info): Create a tui_disasm_window.
2480
2481 2019-06-25  Tom Tromey  <tom@tromey.com>
2482
2483         * tui/tui-data.h (struct tui_source_window)
2484         (struct tui_data_window): Declare destructors.
2485         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2486         destructors.
2487         (tui_win_info): Simplify.
2488
2489 2019-06-25  Tom Tromey  <tom@tromey.com>
2490
2491         * tui/tui-winsource.c (tui_display_main)
2492         (tui_update_source_windows_with_addr)
2493         (tui_update_all_breakpoint_info): Update.
2494         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2495         (new_height_ok, parse_scrolling_args): Update.
2496         * tui/tui-stack.c (tui_show_frame_info): Update.
2497         * tui/tui-data.h (struct tui_list): Remove.
2498         (tui_source_windows): Return a reference to a std::vector.
2499         * tui/tui-data.c (source_windows): Now a std::vector.
2500         (tui_source_windows): Change return type.
2501         (tui_clear_source_windows): Rewrite.
2502         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2503         (tui_free_all_source_wins_content): Rewrite.
2504
2505 2019-06-25  Tom Tromey  <tom@tromey.com>
2506
2507         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2508         (struct tui_data_window, struct tui_cmd_window): Declare
2509         clear_detail method.
2510         * tui/tui-data.c (tui_source_window::clear_detail)
2511         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2512         methods.
2513         (tui_clear_win_detail): Simplify.
2514
2515 2019-06-25  Tom Tromey  <tom@tromey.com>
2516
2517         * tui/tui-layout.c (make_source_window, make_disasm_window)
2518         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2519         Return the new window.
2520         (show_source_disasm_command, show_data)
2521         (show_source_or_disasm_and_command): Update.
2522
2523 2019-06-25  Tom Tromey  <tom@tromey.com>
2524
2525         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2526         parameter.  Return the new window.
2527         (show_source_disasm_command): Update and remove NULL check.
2528         (show_source_or_disasm_and_command): Update.
2529
2530 2019-06-25  Tom Tromey  <tom@tromey.com>
2531
2532         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2533
2534 2019-06-25  Tom Tromey  <tom@tromey.com>
2535
2536         * tui/tui-data.h (struct tui_win_info): Make constructor
2537         protected.  Make destructor virtual.  Add initializers.
2538         (tui_source_window, tui_data_window, tui_cmd_window): New
2539         classes.
2540         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2541         constructor.  Add "type" parameter.
2542         (tui_source_window, tui_data_window, tui_cmd_window): New
2543         constructors.
2544         (tui_alloc_win_info): Instantiate the appropriate subclass.
2545
2546 2019-06-25  Tom Tromey  <tom@tromey.com>
2547
2548         * tui/tui-win.c (tui_resize_all): Use delete.
2549         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2550         destructor.
2551         (tui_free_window): Don't declare.
2552         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2553         Update.
2554
2555 2019-06-25  Tom Tromey  <tom@tromey.com>
2556
2557         * tui/tui-data.h (struct tui_win_info): Add constructor.
2558         * tui/tui-data.c (tui_alloc_win_info): Use new.
2559         (tui_free_window): Use delete.
2560
2561 2019-06-22  Tom Tromey  <tom@tromey.com>
2562
2563         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2564         declare.
2565         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2566
2567 2019-06-22  Tom Tromey  <tom@tromey.com>
2568
2569         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2570         declare.
2571         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2572
2573 2019-06-22  Tom de Vries  <tdevries@suse.de>
2574
2575         * dwarf2read.c (create_addrmap_from_aranges)
2576         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2577         instead of '%zu'.
2578
2579 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2580
2581         * dwarf2read.h (dwarf2_section_info_def): Remove.
2582         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2583         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2584         std::vector<dwarf2_section_info>.
2585         (struct dwo_file) <~dwo_file>: Remove.
2586         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2587         types field.
2588         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2589         (dwarf2_read_debug_names): Likewise.
2590         (create_debug_types_hash_table): Change parameter type to
2591         array_view, adjust code accordingly.
2592         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2593         (partial_die_info::fixup): Likewise.
2594         (determine_prefix): Likewise.
2595         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2596
2597 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2598
2599         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2600         gdb_bfd_ref_ptr.
2601         <~dwo_file>: Remove call to gdb_bfd_unref.
2602         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2603         gdb_bfd_ref_ptr::get.
2604
2605 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2606
2607         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2608         type to htab_up.
2609         * dwarf2read.c (struct dwo_file): Initialize fields.
2610         <~dwo_file>: New.
2611         (free_dwo_file): Remove, move content to ~dwo_file.
2612         (struct dwo_file_deleter): Remove.
2613         (dwo_file_up>: Remove custom deleter.
2614         (free_dwo_files): Remove.
2615         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2616         dwo_files.
2617         (process_skeletonless_type_units): Call unique_ptr::get.
2618         (allocate_dwo_file_hash_table): Add deleter to created hash
2619         table.  Change return type to htab_up.
2620         (lookup_dwo_file_slot): Don't memset dwo_file, call
2621         unique_ptr::get.
2622         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2623         (create_dwo_unit_in_dwp_v2): Likewise.
2624         (open_and_init_dwo_file): Likewise.
2625         (free_dwo_file_from_slot): Remove.
2626
2627 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2628
2629         * dwarf2read.h (struct dwarf2_section_info) <readin,
2630         is_virtual>: Change type to bool.
2631         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2632         true instead of 1.
2633
2634 2019-06-19  Tom Tromey  <tom@tromey.com>
2635
2636         * tui/tui-data.h (tui_init_content_element): Don't declare.
2637
2638 2019-06-19  Tom Tromey  <tom@tromey.com>
2639
2640         * tui/tui-data.h (tui_init_win_info): Don't declare.
2641
2642 2019-06-19  Tom de Vries  <tdevries@suse.de>
2643
2644         * dwarf2read.h (abstract_to_concrete): Change type to
2645         std::unordered_map<sect_offset, std::vector<sect_offset>,
2646         gdb::hash_enum<sect_offset>>.
2647
2648 2019-06-19  Tom Tromey  <tromey@adacore.com>
2649
2650         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2651         EVAL_AVOID_SIDE_EFFECTS specially.
2652
2653 2019-06-19  Tom Tromey  <tromey@adacore.com>
2654
2655         * source-cache.c (highlighter): New global.
2656         (source_cache::get_source_lines): Create a highlighter on demand.
2657
2658 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2659
2660         * defs.h (deprecated_interactive_hook): Delete declaration.
2661         * interps.c (clear_interpreter_hooks): Remove use of
2662         deprecated_interactive_hook.
2663         * top.c (deprecated_interactive_hook): Delete definition.
2664         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2665
2666 2019-06-18  Tom de Vries  <tdevries@suse.de>
2667
2668         PR gdb/24515
2669         * dwarf2read.h (abstract_to_concrete): Change type from
2670         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2671         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2672         * dwarf2read.c (read_variable): Update.
2673         (dwarf2_fetch_die_loc_sect_off): Update.
2674
2675 2019-06-17  Tom de Vries  <tdevries@suse.de>
2676
2677         PR gdb/24617
2678         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2679         accessing parent[parent_len - 1].
2680
2681 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2682
2683         PR gdb/24364
2684         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2685         call dtrace_process_dof with NULL dof.
2686
2687 2019-06-16  Tom de Vries  <tdevries@suse.de>
2688
2689         PR gdb/24445
2690         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2691
2692 2019-06-16  Tom Tromey  <tom@tromey.com>
2693
2694         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2695         (make_all_visible): Use address of member.
2696
2697 2019-06-16  Tom Tromey  <tom@tromey.com>
2698
2699         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2700         (tui_free_window, free_content, free_content_elements): Remove
2701         unnecessary cast.
2702         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2703         cast.
2704         * tui/tui-regs.c (tui_show_register_group)
2705         (tui_display_registers_from, tui_display_reg_element_at_line):
2706         Remove unnecessary cast.
2707
2708 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2709
2710         * linux-nat.c (normal_mask): Delete.
2711         (_initialize_linux_nat): Don't initialise normal_mask.
2712
2713 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2714
2715         PR gdb/24445
2716         * dwarf-index-write.h (write_psymtabs_to_index): Add
2717         dwz_basename parameter.
2718         * dwarf-index-write.c (write_gdbindex): Move file writing to
2719         write_gdbindex_1.  Change return type void.
2720         (assert_file_size): Move up, remove filename parameter.
2721         (write_gdbindex_1): New function.
2722         (write_debug_names): Change return type to void, call
2723         assert_file_size.
2724         (struct index_wip_file): New struct.
2725         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2726         file logic to index_wip_file.  Write index for dwz file if
2727         needed.
2728         (save_gdb_index_command): Pass basename of dwz file, if present.
2729         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2730         build-id of dwz file, if present.
2731         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2732         (dwarf2_get_dwz_file): Likewise.
2733         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2734         (dwarf2_get_dwz_file): Likewise.
2735
2736 2019-06-16  Tom Tromey  <tom@tromey.com>
2737
2738         * coffread.c (process_coff_symbol): Use xstrdup.
2739         * value.c (create_internalvar): Use xstrdup.
2740
2741 2019-06-16  Tom Tromey  <tom@tromey.com>
2742
2743         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2744         * breakpoint.c (stopin_command, stopat_command)
2745         (until_break_command, decode_location_default): Remove unnecessary
2746         cast.
2747         * utils.c (subset_compare): Remove unnecessary cast.
2748         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2749         cast.
2750         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2751         cast.
2752         * infcmd.c (path_command): Remove unnecessary cast.
2753         * coffread.c (decode_type): Remove unnecessary cast.
2754         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2755         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2756         * tui/tui-stack.c (tui_show_locator_content)
2757         (tui_show_frame_info): Remove unnecessary cast.
2758         * tui/tui-win.c (tui_scroll_forward_command)
2759         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2760         (parse_scrolling_args): Remove unnecessary cast.
2761         * tui/tui-data.c (init_win_info, tui_del_window)
2762         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2763         (free_content_elements): Remove unnecessary cast.
2764         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2765         unnecessary cast.
2766         * tui/tui-source.c (tui_set_source_content)
2767         (tui_vertical_source_scroll): Remove unnecessary cast.
2768         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2769         cast.
2770         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2771         * tui/tui-regs.c (tui_display_registers_from)
2772         (tui_display_register): Remove unnecessary cast.
2773         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2774         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2775         (make_visible): Remove unnecessary cast.
2776         * tui/tui-winsource.c (tui_erase_source_content)
2777         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2778         unnecessary cast.
2779         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2780         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2781         * stabsread.c (read_type, read_array_type, read_range_type):
2782         Remove unnecessary cast.
2783         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2784         (parse_symbol, parse_type, upgrade_type, parse_external)
2785         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2786         unnecessary cast.
2787         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2788
2789 2019-06-16  Tom Tromey  <tom@tromey.com>
2790
2791         * tui/tui-data.c (tui_alloc_generic_win_info)
2792         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2793         checks.
2794
2795 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2796             Andrew Burgess  <andrew.burgess@embecosm.com>
2797
2798         * f-typeprint.c (f_print_type): Don't return early for not
2799         associated or not allocated types.
2800         (f_type_print_varspec_suffix): Add print_rank parameter and print
2801         ranks of array types in case they dangling.
2802         (f_type_print_base): Add print_rank parameter.
2803
2804 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2805
2806         * NEWS: Mention new MI commands.
2807         * break-catch-throw.c (enum exception_event_kind): Move to
2808         breakpoint.h.
2809         (print_mention_exception_catchpoint): Output text as a single
2810         message.
2811         (catch_exception_command_1): Rename to...
2812         (catch_exception_event): ...this, make non-static, update header
2813         command, and change some parameter types.
2814         (catch_catch_command): Update for changes to
2815         catch_exception_command_1.
2816         (catch_throw_command): Likewise.
2817         (catch_rethrow_command): Likewise.
2818         * breakpoint.c (enum exception_event_kind): Delete.
2819         * breakpoint.h (enum exception_event_kind): Moved here from
2820         break-catch-throw.c.
2821         (catch_exception_event): Declare.
2822         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2823         (mi_cmd_catch_throw): New function.
2824         (mi_cmd_catch_rethrow): New function.
2825         (mi_cmd_catch_catch): New function.
2826         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2827         'catch-catch' entries.
2828         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2829         (mi_cmd_catch_rethrow): Declare.
2830         (mi_cmd_catch_catch): Declare.
2831
2832 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2833
2834         * annotate.c (annotate_source_line): Change return type to void,
2835         update implementation to match.
2836         * annotate.h (annotate_source_line): Change return type to void,
2837         update header comment.
2838         * stack.c (print_frame_info): Don't change what frame information
2839         is printed based on whether annotations are on or not.
2840
2841 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2842
2843         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2844         (annotate_source): Make static.
2845         (annotate_source_line): Moved from source.c and renamed from
2846         identify_source_line.  Update the return type.
2847         * annotate.h (annotate_source): Delete declaration.
2848         (annotate_source_line): Declaration moved from source.h, and
2849         renamed from identify_source_line.  Return type updated.
2850         * source.c (identify_source_line): Moved to annotate.c and renamed
2851         to annotate_source_line.
2852         (info_line_command): Remove check of annotation_level.
2853         * source.h (identify_source_line): Move declaration to annotate.h
2854         and rename to annotate_source_line.
2855         * stack.c: Add 'annotate.h' include.
2856         (print_frame_info): Remove check of annotation_level before
2857         calling annotate_source_line.
2858
2859 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2860
2861         * source-cache.c (source_cache::get_plain_source_lines): Use
2862         open_source_file_with_line_charpos instead of just
2863         open_source_file, remove call to find_source_lines.
2864         (source_cache::get_source_lines): Likewise.
2865         * source.c (find_source_lines): Make static.
2866         (get_filename_and_charpos): Renamed into...
2867         (open_source_file_with_line_charpos): ..this along with changes to
2868         return a scoped_fd, and some other minor clean ups.
2869         (identify_source_line): Use open_source_file_with_line_charpos.
2870         (search_command_helper): Use open_source_file_with_line_charpos
2871         instead of just open_source_file, remove call to
2872         find_source_lines.
2873         * source.h (open_source_file_with_line_charpos): Declare new
2874         function.
2875         (find_source_lines): Delete declaration.
2876
2877 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2878
2879         * source.c (get_filename_and_charpos): Remove fullname
2880         parameter.
2881         (identify_source_line): Update call to get_filename_and_charpos.
2882
2883 2019-06-14  Tom Tromey  <tromey@adacore.com>
2884
2885         PR gdb/24502:
2886         * ui-style.h (skip_ansi_escape): Update comment.
2887         * ui-file.h (class no_terminal_escape_file): New class.
2888         * ui-file.c (no_terminal_escape_file::write)
2889         (no_terminal_escape_file::puts): New methods.
2890         * cli/cli-logging.c (handle_redirections): Use
2891         no_terminal_escape_file.
2892
2893 2019-06-14  Tom Tromey  <tromey@adacore.com>
2894
2895         * NEWS: Move convenience variable news above Python news.
2896
2897 2019-06-14  Tom Tromey  <tom@tromey.com>
2898
2899         * gnulib: Move directory to top-level.
2900         * configure.ac: Don't configure gnulib.
2901         * configure: Rebuild.
2902         * common/common-defs.h: Use new path to gnulib.
2903         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2904         (GNULIB_H): Remove.
2905         (INCGNU): Look in new gnulib location.
2906         (HFILES_NO_SRCDIR): Remove gnulib files.
2907         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2908         (generated_files): Remove GNULIB_H.
2909         ($(LIBGNU), all-lib): Remove targets.
2910         (distclean): Don't mention GNULIB_BUILDDIR.
2911         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2912
2913 2019-06-14  Tom Tromey  <tromey@adacore.com>
2914
2915         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2916         Warn if symbol file does not provide any symbols.
2917
2918 2019-06-14  Tom Tromey  <tromey@adacore.com>
2919
2920         * source.c (find_and_open_source): Respect basenames_may_differ.
2921
2922 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2923
2924         * annotate.c (annotate_breakpoints_invalid): Make use of
2925         scoped_restore_terminal_state.
2926         (annotate_frames_invalid): Likewise.
2927
2928 2019-06-14  Tom Tromey  <tromey@adacore.com>
2929
2930         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2931         allow assignment to an internalvar.
2932
2933 2019-06-14  Tom Tromey  <tromey@adacore.com>
2934
2935         * ada-lex.l: Allow "_" in attribute names.
2936
2937 2019-06-14  Tom Tromey  <tromey@adacore.com>
2938
2939         PR gdb/24653:
2940         * regcache.c (registers_changed): Don't call alloca.
2941         * top.c (execute_command): Don't call alloca.
2942
2943 2019-06-13  Pedro Alves  <palves@redhat.com>
2944
2945         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2946         'expression'.  When parsing an expression, error out if there's
2947         junk after "unlimited".
2948         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2949         (do_set_command): Adjust calls to is_unlimited_literal.
2950
2951 2019-06-13  Pedro Alves  <palves@redhat.com>
2952
2953         * compile/compile.c (make_compile_options_def_group): Add braces
2954         around array_view initializer.
2955         * thread.c (make_thread_apply_all_options_def_group)
2956         (make_thread_apply_all_options_def_group): Likewise.
2957
2958 2019-06-13  Pedro Alves  <palves@redhat.com>
2959
2960         * NEWS (New commands): Mention "maint test-options
2961         require-delimiter", "maint test-options unknown-is-error", "maint
2962         test-options unknown-is-operand" and "maint show
2963         test-options-completion-result".
2964         (New command options, command completion): New section.
2965         (Completion improvements): New section.
2966         Mention that you can abbreviate "unlimited".
2967
2968 2019-06-13  Pedro Alves  <palves@redhat.com>
2969
2970         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2971         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2972         * unittests/cli-utils-selftests.c (test_parse_flags)
2973         (test_parse_flags_qcs): Delete.
2974         (test_cli_utils): Don't call deleted functions.
2975
2976 2019-06-13  Pedro Alves  <palves@redhat.com>
2977
2978         * thread.c: Include "cli/cli-option.h".
2979         (tp_array_compar_ascending): Global.
2980         (tp_array_compar): Delete function.
2981         (tp_array_compar_ascending, tp_array_compar_descending): New
2982         functions.
2983         (ascending_option_def, qcs_flag_option_def)
2984         (thr_qcs_flags_option_defs)
2985         (make_thread_apply_all_options_def_group)
2986         (make_thread_apply_options_def_group): New.
2987         (thread_apply_all_command): Use gdb::option::process_options.
2988         (thread_apply_command_completer)
2989         (thread_apply_all_command_completer): New.
2990         (thread_apply_command): Use gdb::option::process_options.
2991         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2992         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2993         to generate help text of "thread apply".  Adjust "taas"'s help.
2994         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2995         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2996
2997 2019-06-13  Pedro Alves  <palves@redhat.com>
2998
2999         * thread.c (thread_apply_command): Check for invalid TID with
3000         isdigit instead of !isalpha.
3001
3002 2019-06-13  Pedro Alves  <palves@redhat.com>
3003
3004         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3005         (validate_flags_qcs): New.
3006         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3007         (validate_flags_qcs): Declare.
3008         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3009         (make_frame_apply_options_def_group): New.
3010         (frame_apply_command_count): Process options with
3011         gdb::option::process_options.
3012         (frame_apply_completer): New.
3013         (frame_apply_level_completer, frame_apply_all_completer)
3014         (frame_apply_completer): New.
3015         (_initialize_stack): Update help of "frame apply", "frame apply
3016         level", "frame apply all" and "faas" to mention supported options
3017         and install command completers.
3018         * stack.h (frame_apply_all_completer): Declare.
3019         * thread.c: Include "stack.h".
3020         (tfaas_command): Add "--".
3021         (_initialize_thread): Update help "tfaas" to mention supported
3022         options and install command completer.
3023
3024 2019-06-13  Pedro Alves  <palves@redhat.com>
3025
3026         * completer.c (complete_nested_command_line): New.
3027         (gdb_completion_word_break_characters_throw): Add assertion.
3028         * completer.h (complete_nested_command_line): Declare.
3029
3030 2019-06-13  Pedro Alves  <palves@redhat.com>
3031
3032         * stack.c (parse_backtrace_qualifiers): New.
3033         (backtrace_command): Use it.
3034         (backtrace_command_completer): Complete on qualifiers.
3035
3036 2019-06-13  Pedro Alves  <palves@redhat.com>
3037
3038         * frame.c: Include "cli/cli-option.h.
3039         (user_set_backtrace_options): New.
3040         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3041         Delete.
3042         (get_prev_frame): Adjust.
3043         (boolean_option_def, uinteger_option_def)
3044         (set_backtrace_option_defs): New.
3045         (_initialize_frame): Adjust and use
3046         gdb::option::add_setshow_cmds_for_options to install "set
3047         backtrace past-main" and "set backtrace past-entry".
3048         * frame.h: Include "cli/cli-option.h".
3049         (struct frame_print_options): Forward declare.
3050         (print_frame_arguments_all, print_frame_arguments_scalars)
3051         (print_frame_arguments_none): Declare.
3052         (print_entry_values): Delete declaration.
3053         (struct frame_print_options, user_frame_print_options): New.
3054         (struct set_backtrace_options): New.
3055         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3056         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3057         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3058         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3059         (list_args_or_locals): Add frame_print_options parameter.
3060         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3061         * python/py-framefilter.c (enumerate_args): Pass down
3062         USER_FRAME_PRINT_OPTIONS.
3063         * stack.c: Include "cli/cli-option.h".
3064         (print_frame_arguments_all, print_frame_arguments_scalars)
3065         (print_frame_arguments_none): Declare.
3066         (print_raw_frame_arguments, print_entry_values): Delete.
3067         (user_frame_print_options): New.
3068         (boolean_option_def, enum_option_def, frame_print_option_defs):
3069         New.
3070         (struct backtrace_cmd_options): New.
3071         (bt_flag_option_def): New.
3072         (backtrace_command_option_defs): New.
3073         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3074         (print_frame_arg, read_frame_arg, print_frame_args)
3075         (print_frame_info, print_frame): Add frame_print_options parameter
3076         and use it.
3077         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3078         (backtrace_command_1): Add frame_print_options and
3079         backtrace_cmd_options parameters and use them.
3080         (make_backtrace_options_def_group): New.
3081         (backtrace_command): Process command options with
3082         gdb::option::process_options.
3083         (backtrace_command_completer): New.
3084         (_initialize_stack): Extend "backtrace"'s help to mention
3085         supported options.  Install completer for "backtrace".
3086         Install some settings commands with add_setshow_cmds_for_options.
3087
3088 2019-06-13  Pedro Alves  <palves@redhat.com>
3089
3090         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3091         and that "set/show print raw frame-arguments" are now deprecated.
3092
3093         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3094         command.
3095         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3096         * stack.c (_initialize_stack): Install "set/show print
3097         raw-frame-arguments", and deprecate "set/show print raw
3098         frame-arguments".
3099         * valprint.c (_initialize_valprint): Deprecate "set/show print
3100         raw".
3101
3102 2019-06-13  Pedro Alves  <palves@redhat.com>
3103
3104         * compile/compile.c (struct compile_options): New.
3105         (compile_flag_option_def, compile_command_option_defs)
3106         (make_compile_options_def_group): New.
3107         (compile_file_command): Handle options with
3108         gdb::option::process_options.
3109         (compile_file_command_completer): New function.
3110         (compile_code_command): Handle options with
3111         gdb::option::process_options.
3112         (compile_code_command_completer): New function.
3113         (_initialize_compiler): Install completers for "compile code" and
3114         "compile file".  Mention available options in "compile code" and
3115         "compile code"'s help.
3116         * completer.c (advance_to_completion_word): New, factored out from
3117         ...
3118         (advance_to_expression_complete_word_point): ... this.
3119         (advance_to_filename_complete_word_point): New.
3120         * completer.h (advance_to_filename_complete_word_point): New
3121         declaration.
3122
3123 2019-06-13  Pedro Alves  <palves@redhat.com>
3124
3125         * compile/compile.c: Include "cli/cli-option.h".
3126         (compile_print_value): Scope data pointer is now a
3127         value_print_options pointer; adjust.
3128         (compile_print_command): Process options.  Scope data pointer is
3129         now a value_print_options pointer; adjust.
3130         (_initialize_compile): Update "compile print"'s help to include
3131         supported options.  Install a completer for "compile print".
3132         * cp-valprint.c (show_vtblprint, show_objectprint)
3133         (show_static_field_print): Delete.
3134         (_initialize_cp_valprint): Don't install "set print
3135         static-members", "set print vtbl", "set print object" here.
3136         * printcmd.c: Include "cli/cli-option.h" and
3137         "common/gdb_optional.h".
3138         (print_command_parse_format): Rework to fill in a
3139         value_print_options instead of a format_data.
3140         (print_value): Change parameter type from format_data pointer to
3141         value_print_options reference.  Adjust.
3142         (print_command_1): Process options.  Adjust to pass down a
3143         value_print_options.
3144         (print_command_completer): New.
3145         (_initialize_printcmd): Install print_command_completer as
3146         handle_brkchars completer for the "print" command.  Update
3147         "print"'s help to include supported options.
3148         * valprint.c: Include "cli/cli-option.h".
3149         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3150         here from cp-valprint.c.
3151         (boolean_option_def, uinteger_option_def)
3152         (value_print_option_defs, make_value_print_options_def_group):
3153         New.  Use gdb::option::add_setshow_cmds_for_options to install
3154         "set print elements", "set print null-stop", "set print repeats",
3155         "set print pretty", "set print union", "set print array", "set
3156         print address", "set print symbol", "set print array-indexes".
3157         * valprint.h: Include <string> and "cli/cli-option.h".
3158         (make_value_print_options_def_group): Declare.
3159         (print_value): Change parameter type from format_data pointer to
3160         value_print_options reference.
3161         (print_command_completer): Declare.
3162
3163 2019-06-13  Pedro Alves  <palves@redhat.com>
3164
3165         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3166         (COMMON_SFILES): Add maint-test-settings.c.
3167         * cli/cli-decode.c (boolean_enums): New global, factored out from
3168         ...
3169         (add_setshow_boolean_cmd): ... here.
3170         * cli/cli-decode.h (boolean_enums): Declare.
3171         * cli/cli-option.c: New file.
3172         * cli/cli-option.h: New file.
3173         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3174         factored out from ...
3175         (parse_cli_boolean_value(const char *)): ... this.
3176         (is_unlimited_literal): Change parameter type to pointer to
3177         pointer.  Adjust and advance ARG pointer.
3178         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3179         (parse_cli_var_enum): New, factored out from ...
3180         (do_set_command): ... this.  Adjust.
3181         * cli/cli-setshow.h (parse_cli_boolean_value)
3182         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3183         (parse_cli_var_enum): Declare.
3184         * cli/cli-utils.c: Include "cli/cli-option.h".
3185         (get_ulongest): New.
3186         * cli/cli-utils.h (get_ulongest): Declare.
3187         (check_for_argument): New overloads.
3188         * maint-test-options.c: New file.
3189
3190 2019-06-13  Pedro Alves  <palves@redhat.com>
3191
3192         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3193         parse a range if "-" is at the end of the string.
3194
3195 2019-06-13  Pedro Alves  <palves@redhat.com>
3196
3197         * cli/cli-setshow.c (parse_auto_binary_operation)
3198         (parse_cli_boolean_value): Don't allow "o".
3199
3200 2019-06-13  Pedro Alves  <palves@redhat.com>
3201
3202         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3203         * NEWS: Mention maint test-settings KIND.
3204         * maint-test-settings.c: New file.
3205
3206 2019-06-13  Pedro Alves  <palves@redhat.com>
3207
3208         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3209         completer.
3210         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3211         "set" completers.
3212
3213 2019-06-13  Pedro Alves  <palves@redhat.com>
3214
3215         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3216         after item.
3217
3218 2019-06-13  Pedro Alves  <palves@redhat.com>
3219
3220         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3221
3222 2019-06-13  Pedro Alves <palves@redhat.com>
3223
3224         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3225         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3226         call.
3227         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3228         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3229         calls.
3230         (check_for_argument): Skip spaces after argument.
3231
3232 2019-06-13  Pedro Alves  <palves@redhat.com>
3233
3234         * thread.c (thread_apply_command): Adjust TID parsing.
3235         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3236         detected before end of string.
3237         (tid_is_in_list): Error out if LIST is invalid.
3238
3239 2019-06-13  Pedro Alves  <palves@redhat.com>
3240
3241         * completer.c (complete_line_internal_1): Rewind completion word
3242         point.
3243         (completion_tracker::advance_custom_word_point_by): Change
3244         parameter type to int.
3245         * completer.h (completion_tracker::advance_custom_word_point_by):
3246         Likewise.
3247
3248 2019-06-13  Pedro Alves  <palves@redhat.com>
3249
3250         * completer.c (advance_to_completion_word): Handle delimiters.
3251
3252 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3253
3254         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3255
3256 2019-06-11  Tom Tromey  <tom@tromey.com>
3257
3258         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3259         (xmalloc_failed): Move to alloc.c.
3260         * alloc.c: New file.
3261         * Makefile.in (COMMON_SFILES): Add alloc.c.
3262
3263 2019-06-11  Tom Tromey  <tom@tromey.com>
3264
3265         * nat/linux-waitpid.c: Don't include server.h.
3266         (linux_debug): Remove.
3267         (my_waitpid): Update.
3268
3269 2019-06-11  Tom Tromey  <tromey@adacore.com>
3270
3271         * infcall.c (_initialize_infcall): Remove trailing newline from
3272         help.
3273         * user-regs.c (_initialize_user_regs): Remove trailing newline
3274         from help.
3275         * typeprint.c (_initialize_typeprint): Remove trailing newline
3276         from help.
3277         * reverse.c (_initialize_reverse): Remove trailing newlines from
3278         help.
3279         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3280         from help.
3281         * language.c (add_set_language_command): Remove trailing newline
3282         from help.
3283         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3284         help.
3285         * disasm.c (_initialize_disasm): Remove trailing newline from
3286         help.
3287         * top.c (init_main): Remove trailing newline from help.
3288         * interps.c (_initialize_interpreter): Remove trailing newline
3289         from help.
3290         * btrace.c (_initialize_btrace): Remove trailing newlines from
3291         help.
3292         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3293         from help.
3294         * python/python.c (_initialize_python): Remove trailing newline
3295         from help.
3296         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3297         help.
3298         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3299         from help.  Reformat some text.
3300         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3301         from help.
3302         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3303         newline from help.
3304
3305 2019-06-11  Tom Tromey  <tromey@adacore.com>
3306
3307         * darwin-nat.c (darwin_decode_exception_message)
3308         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3309
3310 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3311
3312         * valops.c (value_slice): Check for not allocated or not
3313         associated values.
3314
3315 2019-06-10  Tom de Vries  <tdevries@suse.de>
3316
3317         PR gdb/24618
3318         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3319         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3320         invalid.
3321
3322 2019-06-10  Tom de Vries  <tdevries@suse.de>
3323
3324         PR gdb/24611
3325         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3326         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3327
3328 2019-06-10  Tom de Vries  <tdevries@suse.de>
3329
3330         PR symtab/24545
3331         * symtab.c (struct demangled_name_entry): Add language field.
3332         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3333         static minimal symbol".  Set and use language field.
3334
3335 2019-06-10  Tom Tromey  <tromey@adacore.com>
3336
3337         * ada-lang.c (_initialize_ada_language): Update help text.
3338
3339 2019-06-10  Tom Tromey  <tromey@adacore.com>
3340
3341         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3342         with a newline.
3343         * guile/guile.c (handle_boot_error): Don't end warning with a
3344         newline.
3345         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3346         warning with a newline.
3347         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3348         newline.
3349         (s12z_frame_cache): Likewise.
3350         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3351         a newline.
3352         * solib-svr4.c (disable_probes_interface): Don't end warning with
3353         a newline.
3354         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3355         newline.
3356         * python/python.c (do_finish_initialization): Don't end warning
3357         with a newline.
3358
3359 2019-06-10  Tom Tromey  <tom@tromey.com>
3360
3361         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3362         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3363         gdbpy_enter.
3364
3365 2019-06-10  Tom Tromey  <tromey@adacore.com>
3366
3367         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3368         data.
3369         (elf_new_init): Don't call stabsread_new_init.
3370         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3371         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3372         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3373
3374 2019-06-10  Tom de Vries  <tdevries@suse.de>
3375
3376         PR symtab/16264
3377         PR symtab/24517
3378         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3379
3380 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3381
3382         * source.c (find_and_open_source): Also rewrite relative file
3383         names.
3384
3385 2019-04-26  Amos Bird  <amosbird@gmail.com>
3386
3387         * annotate.c (annotate_thread_exited): Add "thread-exited"
3388         annotation.
3389
3390 2019-06-06  Tom Tromey  <tromey@adacore.com>
3391
3392         * maint.h (class scoped_command_stats): Use
3393         DISABLE_COPY_AND_ASSIGN.
3394         <print_time>: New method.
3395         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3396         print_time.
3397         (scoped_command_stats::print_time): New method.
3398
3399 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3400
3401         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3402         instructions of lengths 6 or 8 bytes.
3403
3404 2019-06-04  Pedro Alves  <palves@redhat.com>
3405
3406         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3407
3408         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3409         * breakpoint.c (condition_completer): Likewise.
3410         * cli/cli-dump.c (scan_expression): Likewise.
3411         * common/filestuff.c (mkdir_recursive): Likewise.
3412         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3413         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3414         (gdb_abspath): Likewise.
3415         * compile/compile-cplus-types.c
3416         (compile_cplus_instance::decl_name): Likewise.
3417         * completer.c (complete_explicit_location):
3418         (signal_completer, reg_or_group_completer_1): Likewise.
3419         * cp-support.c (cp_remove_params_if_any): Likewise.
3420         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3421         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3422         * infcmd.c (strip_bg_char): Likewise.
3423         * linespec.c (copy_token_string): Likewise.
3424         * mi/mi-main.c (output_cores): Likewise.
3425         * psymtab.c (psymtab_search_name):
3426         * symfile.c (test_set_ext_lang_command): Likewise.
3427         * target.c (target_fileio_read_stralloc): Likewise.
3428         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3429         * value.c (complete_internalvar): Likewise.
3430
3431 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3432
3433         Add objfile property to gdb.Type.
3434         * NEWS: Mention Python API addition.
3435         * python/py-type.c (typy_get_objfile): New method.
3436
3437 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3438
3439         * NEWS: Mention the new set|show style [title|highlight].
3440         Mention changes to "show style", "help" and "apropos".
3441
3442 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3443
3444         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3445         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3446         instead of print_help_for_command.
3447         (print_doc_of_command): New function.
3448         (help_list): Add 'apropos -v word' suggestion.
3449         (print_help_for_command): Style the command name using title style.
3450         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3451         (_initialize_cli_cmds): Describe -v in apropos_command help.
3452
3453 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3454
3455         * cli/cli-style.h (cli_style_option): Add name in constructor,
3456         add m_name class member, add constructor with intensity,
3457         add name class function.
3458         (cli_style_option::add_setshow_commands): Remove name argument.
3459         (highlight_style, title_style): New styles.
3460         * cli/cli-style.c (do_show): New function that shows a style
3461         characteristic styling the style name with itself.
3462         (set_style_name): New function.
3463         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3464         Update all callers according to the changes in cli/cli-style.h.
3465         * utils.h (fputs_highlighted): New function.
3466         * utils.c (fputs_highlighted): Likewise.
3467
3468 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3469
3470         * NEWS: Mention new pipe command and new convenience variables.
3471
3472 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3473
3474         * cli/cli-cmds.c (pipe_command): New function.
3475         (_initialize_cli_cmds): Call add_com for pipe_command.
3476         Define | as an alias for pipe.
3477         (exit_status_set_internal_vars): New function.
3478         (shell_escape): Call exit_status_set_internal_vars.
3479         cli/cli-decode.c (find_command_name_length): Recognize | as
3480         a single character command.
3481
3482 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3483
3484         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3485         top.c (execute_command_to_ui_file): New function, mostly a copy
3486         of execute_command_to_string.
3487         (execute_command_to_string): Implement by calling
3488         execute_command_to_ui_file.
3489
3490 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3491
3492         * top.h (saved_command_line): Remove declaration.
3493         * top.c (previous_saved_command_line, previous_repeat_arguments):
3494         New variables.
3495         (saved_command_line): Make static, define together with other
3496         'repeat variables'.
3497         (dont_repeat): Clear repeat_arguments.
3498         (repeat_previous, get_saved_command_line, save_command_line):
3499         New functions.
3500         (gdb_init): Initialize saved_command_line
3501         and previous_saved_command_line.
3502         * main.c (captured_main_1): Remove saved_command_line initialization.
3503         * event-top.c (handle_line_of_input): Update to use
3504         the new 'repeat' related functions instead of direct access to
3505         saved_command_line.
3506         * command.h (repeat_previous, get_saved_command_line,
3507         save_command_line): New declarations.
3508         (dont_repeat): Add comment.
3509
3510 2019-05-30  Tom Tromey  <tromey@adacore.com>
3511
3512         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3513         Fix comment.
3514         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3515
3516 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3517
3518         PR cli/24587
3519         * completer.c (complete): Initialize variable word.
3520
3521 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3522
3523         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3524         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3525         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3526         'body' is NULL to the outter 'if', protecting the '!is_define'
3527         situation as well.
3528
3529 2019-05-29  Tom Tromey  <tromey@adacore.com>
3530
3531         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3532         (dwarf_unknown): New function.
3533         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3534         (dwarf_type_encoding_name): Use dwarf_unknown.
3535
3536 2019-05-29  Tom Tromey  <tromey@adacore.com>
3537
3538         PR c++/20020:
3539         * cp-valprint.c (cp_print_value_fields): Call
3540         cp_print_static_field inside "try".
3541
3542 2019-05-29  Tom Tromey  <tromey@adacore.com>
3543
3544         * inflow.c (struct terminal_info): Add default operator=.
3545         * configure: Rebuild.
3546         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3547         -Wdeprecated-copy-dtor, -Wredundant-move.
3548
3549 2019-05-29  Tom Tromey  <tromey@adacore.com>
3550
3551         * NEWS: Add entry.
3552         * infcmd.c (print_return_value_1): Handle finish_print
3553         option.
3554         (show_print_finish): New function.
3555         (_initialize_infcmd): Add "set/show print finish" commands.
3556         * valprint.c (user_print_options): Initialize new member.
3557         * valprint.h (struct value_print_options) <finish_print>: New
3558         member.
3559
3560 2019-05-28  Tom Tromey  <tromey@adacore.com>
3561
3562         * ada-lang.c (ada_remove_Xbn_suffix)
3563         (find_old_style_renaming_symbol)
3564         (parse_old_style_renaming): Remove.
3565         (ada_find_renaming_symbol): Don't call
3566         find_old_style_renaming_symbol.
3567         (ada_is_renaming_symbol): Rename from
3568         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3569         bool.  Now static.
3570         (ada_read_var_value): Update and simplify.
3571         * ada-exp.y (write_var_or_type): Remove old code.
3572
3573 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3574
3575         * event-top.c: Remove include comment.
3576         * inflow.c (class scoped_ignore_sigttou): Move from here...
3577         * inflow.h (class scoped_ignore_sigttou): ...to here.
3578         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3579         * top.c:  Remove include comment.
3580
3581 2019-05-27  Tom Tromey  <tom@tromey.com>
3582
3583         * NEWS: Fix typo.
3584
3585 2019-05-22  Tom Tromey  <tromey@adacore.com>
3586
3587         * target.c (target_follow_exec): Constify parameter.
3588         * target-delegates.c: Rebuild.
3589         * remote.c (remote_target::follow_exec): Constify parameter.
3590         * infrun.c (follow_exec): Constify parameter.
3591         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3592         (target_follow_exec): Likewise.
3593
3594 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3595
3596         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3597         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3598
3599 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3600
3601         * NEWS: Add debugredirect and testsuite sections.
3602
3603 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3604
3605         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3606         target descriptions using exclusively floating point register name
3607         aliases.
3608
3609 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3610
3611         PR gdb/18644:
3612         * f-lang.c (build_fortran_types): Handle the case where
3613         gdbarch_floatformat_for_type returns a nullptr.
3614
3615 2019-05-21  Tom de Vries  <tdevries@suse.de>
3616
3617         PR cli/24587
3618         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3619
3620 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3621
3622         PR gdb/18644:
3623         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3624         16-byte floats.
3625         * i386-tdep.c (i386_floatformat_for_type): Use
3626         floatformats_ia64_quad for the 16-byte floating point component
3627         within a fortran 32-byte complex number.
3628
3629 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3630
3631         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3632         delete default constructor.
3633         (find_partial_die): Update to return const struct.
3634         (partial_die_parent_scope): Move variable declaration into scope
3635         of its use and change its type to auto.
3636         (guess_partial_die_structure_name): Likewise.
3637         (partial_die_info::fixup): Likewise.
3638
3639 2019-05-17  Tom Tromey  <tromey@adacore.com>
3640
3641         * source.c (find_and_open_source): Remove cast.
3642
3643 2019-05-17  Tom Tromey  <tromey@adacore.com>
3644
3645         * annotate.c (annotate_source): Make "filename" const.
3646         * annotate.h (annotate_source): Use const.
3647
3648 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3649
3650         * disasm.c (set_disassembler_options): Send errors to stderr.
3651
3652 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3653
3654         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3655         (cli_interp_base::set_logging): Check debug_redirect.
3656         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3657         * cli/cli-logging.c (debug_redirect): Add static variable.
3658         (pop_output_files): Add default param.
3659         (handle_redirections): Print debug setting.
3660         (show_logging_command): Likewise.
3661         (_initialize_cli_logging): Add debugredirect command.
3662         * interps.c (current_interp_set_logging): Add debug_redirect
3663         parameter.
3664         * interps.h (set_logging): Add debug_redirect parameter.
3665         (current_interp_set_logging): Likewise.
3666         * mi/mi-common.h: Likewise.
3667         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3668
3669 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3670             Tom Tromey  <tromey@adacore.com>
3671
3672         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3673         directly.
3674         * cli/cli-interp.h (make_logging_output): Remove declaration.
3675         * cli/cli-logging.c (make_logging_output): Remove function.
3676         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3677         directly.
3678         * ui-file.c (tee_file::tee_file): Remove bools.
3679         (tee_file::~tee_file): Remove deletes.
3680         * ui-file.h (tee_file): Remove bools.
3681
3682 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3683
3684         * mi/mi-cmds.h (mi_cmd_complete): New function.
3685         * mi/mi-main.c (mi_cmd_complete): Likewise.
3686         * mi/mi-cmds.c: Define new MI command -complete.
3687         * NEWS: Mention new -complete command.
3688
3689 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3690
3691         * completer.h (complete): New function.
3692         * completer.c (complete): Likewise.
3693         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3694         function defined in completer.h.
3695
3696 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3697
3698         * MAINTAINERS (Write After Approval): Add myself.
3699
3700 2019-05-17  Tom de Vries  <tdevries@suse.de>
3701
3702         PR gdb/24094
3703         * dwarf2read.c (struct cu_partial_die_info): New struct.
3704         (find_partial_die): Return cu_partial_die_info.
3705         (partial_die_parent_scope, guess_partial_die_structure_name)
3706         (partial_die_info::fixup): Handle new return type of find_partial_die.
3707
3708 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3709
3710         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3711         "std::string", simplifying the algorithm.
3712
3713 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3714
3715         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3716         (stap_static_probe_ops::get_probes): Likewise.
3717
3718 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3719
3720         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3721         '-')" and "else if".
3722         (stap_parse_single_operand): Join checks for
3723         "gdbarch_stap_parse_special_token_p" and
3724         "gdbarch_stap_parse_special_token" in the same "if" statement.
3725         Invert check when verifying for operation on register
3726         displacement.
3727
3728 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3729
3730         * stap-probe.c (stap_get_opcode): Update comment.
3731         (stap_get_expected_argument_type): Likewise.
3732         (handle_stap_probe): Likewise.
3733
3734 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3735
3736         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3737         return type to 'bool'.  Adjust comment.  Use 'bool' when
3738         appropriate.
3739         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3740         * stap-probe.c (stap_parse_argument_1): Likewise.
3741         (stap_is_operator): Likewise.
3742         (stap_is_generic_prefix): Likewise.
3743         (stap_is_register_prefix): Likewise.
3744         (stap_is_register_indirection_prefix): Likewise.
3745         (stap_is_integer_prefix): Likewise.
3746         (stap_generic_check_suffix): Likewise.
3747         (stap_check_integer_suffix): Likewise.
3748         (stap_check_register_suffix): Likewise.
3749         (stap_check_register_indirection_suffix): Likewise.
3750         (stap_parse_register_operand): Likewise.
3751         (stap_parse_single_operand): Likewise.
3752         (stap_parse_argument_1): Likewise.
3753         (stap_probe::get_argument_count): Likewise.
3754         (stap_is_operator): Likewise.
3755
3756 2019-05-16  Tom Tromey  <tromey@adacore.com>
3757
3758         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3759         keyword to foreach.
3760
3761 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3762
3763         * linux-thread-db.c (try_thread_db_load_1): Change return type
3764         to bool.
3765         (try_thread_db_load): Likewise.
3766         (try_thread_db_load_from_pdir_1): Likewise.
3767         (try_thread_db_load_from_pdir): Likewise.
3768         (try_thread_db_load_from_sdir): Likewise.
3769         (try_thread_db_load_from_dir): Likewise.
3770         (thread_db_load_search): Likewise.
3771         (has_libpthread): Likewise.
3772         (thread_db_load): Likewise.
3773
3774 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3775
3776         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3777         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3778         NULL, and complain/return if that's the case.
3779
3780 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3781
3782         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3783         (advance, posn, abstract_read_memory): New functions.
3784         [struct mem_read_abstraction]: New struct.
3785         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3786
3787 2019-05-14  Tom Tromey  <tromey@adacore.com>
3788
3789         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3790         value is not lval_memory.
3791
3792 2019-05-14  Tom Tromey  <tromey@adacore.com>
3793
3794         * solib.c (info_sharedlibrary_command): Style the file name.
3795
3796 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3797
3798         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3799         (aarch64_vnv_type): Likewise.
3800         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3801         * common/tdesc.c: Likewise.
3802         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3803         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3804         * features/aarch64-fpu.xml: Add ieee half view.
3805         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3806         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3807         * gdbtypes.h (struct builtin_type): Likewise.
3808         (struct objfile_type): Likewise.
3809
3810 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3811
3812         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3813         typo.
3814         * location.h (string_to_event_location): Likewise.
3815
3816 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3817
3818         GDB 8.3 released.
3819
3820 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3821
3822         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3823         New variable declaration.
3824         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3825         New variable.
3826         (print_one_breakpoint): Use ui_out::test_flags and new global
3827         variable to compute use_fixed_output.
3828         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3829         Remove.
3830         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3831         (mi_multi_location_breakpoint_output_fixed): Remove.
3832         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3833         new variable.
3834         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3835         fix_multi_location_breakpoint_output flag if version >= 3.
3836         * ui-out.h (enum ui_out_flag)
3837         <fix_multi_location_breakpoint_output>: New enumerator.
3838
3839 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3840
3841         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3842
3843 2019-05-10  Tom Tromey  <tromey@adacore.com>
3844
3845         * ada-lang.c (catch_ada_completer): New function.
3846         (_initialize_ada_language): Use it.
3847
3848 2019-05-10  Tom Tromey  <tromey@adacore.com>
3849
3850         * thread.c (print_thread_info): Make "requested_threads" const.
3851         * gdbthread.h (print_thread_info): Make "requested_threads"
3852         const.
3853         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3854         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3855
3856 2019-05-08  Tom Tromey  <tom@tromey.com>
3857
3858         * gdbtypes.c (objfile_type_data): Change type.
3859         (objfile_type, _initialize_gdbtypes): Update.
3860
3861 2019-05-08  Tom Tromey  <tom@tromey.com>
3862
3863         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3864         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3865         (_initialize_dwarf2_frame): Update.
3866
3867 2019-05-08  Tom Tromey  <tom@tromey.com>
3868
3869         * objc-lang.c (objc_objfile_data): Change type.
3870         (find_methods): Update.
3871         (_initialize_objc_lang): Remove.
3872
3873 2019-05-08  Tom Tromey  <tom@tromey.com>
3874
3875         * stabsread.c (rs6000_builtin_type_data): Change type.
3876         (rs6000_builtin_type, _initialize_stabsread): Update.
3877
3878 2019-05-08  Tom Tromey  <tom@tromey.com>
3879
3880         * mips-tdep.c (mips_pdr_data): Remove.
3881         (_initialize_mips_tdep): Update.
3882
3883 2019-05-08  Tom Tromey  <tom@tromey.com>
3884
3885         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3886         (hppa_init_objfile_priv_data, read_unwind_info)
3887         (find_unwind_entry, _initialize_hppa_tdep): Update.
3888
3889 2019-05-08  Tom Tromey  <tom@tromey.com>
3890
3891         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3892         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3893         on obstack.
3894         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3895
3896 2019-05-08  Tom Tromey  <tom@tromey.com>
3897
3898         * mdebugread.c (basic_type_data): Change type.
3899         (basic_type, _initialize_mdebugread): Update.
3900
3901 2019-05-08  Tom Tromey  <tom@tromey.com>
3902
3903         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3904
3905 2019-05-08  Tom Tromey  <tom@tromey.com>
3906
3907         * nto-tdep.c (nto_inferior_data_reg): Change type.
3908         (nto_inferior_data): Update.
3909         (nto_inferior_data_cleanup, nto_new_inferior_data)
3910         (_initialize_nto_tdep): Remove.
3911         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3912
3913 2019-05-08  Tom Tromey  <tom@tromey.com>
3914
3915         * ada-lang.c (struct ada_inferior_data): Add initializers.
3916         (ada_inferior_data): Change type.
3917         (ada_inferior_data_cleanup): Remove.
3918         (get_ada_inferior_data, ada_inferior_exit)
3919         (struct ada_pspace_data): Add initializers, destructor.
3920         (ada_pspace_data_handle): Change type.
3921         (get_ada_pspace_data): Update.
3922         (ada_pspace_data_cleanup): Remove.
3923
3924 2019-05-08  Tom Tromey  <tom@tromey.com>
3925
3926         * coffread.c (struct coff_symfile_info): Add initializers.
3927         (coff_objfile_data_key): Move lower.  Change type.
3928         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3929         Update.
3930         (coff_free_info): Remove.
3931
3932 2019-05-08  Tom Tromey  <tom@tromey.com>
3933
3934         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3935         (fbsd_pspace_data_handle): Move lower.  Change type.
3936         (get_fbsd_pspace_data): Update.
3937         (fbsd_pspace_data_cleanup): Remove.
3938         (_initialize_fbsd_tdep): Update.
3939
3940 2019-05-08  Tom Tromey  <tom@tromey.com>
3941
3942         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3943         (get_ada_tasks_pspace_data): Update.
3944         (ada_tasks_pspace_data_cleanup): Remove.
3945         (_initialize_tasks): Update.
3946         (ada_tasks_inferior_data_handle): Change type.
3947         (get_ada_tasks_inferior_data): Update.
3948         (ada_tasks_inferior_data_cleanup): Remove.
3949         (struct ada_tasks_pspace_data): Add initializers.
3950
3951 2019-05-08  Tom Tromey  <tom@tromey.com>
3952
3953         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3954         * symfile-debug.c (debug_sym_get_probes): Change type.
3955         * stap-probe.c (handle_stap_probe):
3956         (stap_static_probe_ops::get_probes): Change type.
3957         * probe.h (class static_probe_ops) <get_probes>: Change type.
3958         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3959         (parse_probes_in_pspace): Update.
3960         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3961         Update.
3962         (any_static_probe_ops::get_probes): Change type.
3963         * elfread.c (elfread_data): New typedef.
3964         (probe_key): Change type.
3965         (elf_get_probes): Likewise.  Update.
3966         (probe_key_free): Remove.
3967         (_initialize_elfread): Update.
3968         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3969         Change type.
3970         (dtrace_process_dof_probe, dtrace_process_dof)
3971         (dtrace_static_probe_ops::get_probe): Change type.
3972
3973 2019-05-08  Tom Tromey  <tom@tromey.com>
3974
3975         * xcoffread.c (struct xcoff_symfile_info): Rename from
3976         coff_symfile_info.  Add initializers.
3977         (xcoff_objfile_data_key): Move lower.  Change type.
3978         (XCOFF_DATA): Rewrite.
3979         (xcoff_free_info): Remove.
3980         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3981         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3982         (xcoff_initial_scan): Update.
3983
3984 2019-05-08  Tom Tromey  <tom@tromey.com>
3985
3986         * solib-svr4.c (struct svr4_info): Add initializers and
3987         destructor.
3988         <probes_table>: Now an htab_up.
3989         (solib_svr4_pspace_data): Change type.
3990         (free_probes_table): Simplify.
3991         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3992         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3993         (probes_table_remove_objfile_probes, register_solib_event_probe)
3994         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3995         (_initialize_svr4_solib): Update.
3996
3997 2019-05-08  Tom Tromey  <tom@tromey.com>
3998
3999         * remote.c (remote_pspace_data): Change type.
4000         (remote_pspace_data_cleanup): Remove.
4001         (get_remote_exec_file, set_pspace_remote_exec_file)
4002         (_initialize_remote): Update.
4003
4004 2019-05-08  Tom Tromey  <tom@tromey.com>
4005
4006         * breakpoint.c (breakpoint_objfile_key): Change type.
4007         (get_breakpoint_objfile_data): Update.
4008         (free_breakpoint_objfile_data): Remove.
4009         (_initialize_breakpoint): Update.
4010
4011 2019-05-08  Tom Tromey  <tom@tromey.com>
4012
4013         * linux-tdep.c (struct linux_info): Add initializers.
4014         (linux_inferior_data): Move.  Change type.
4015         (invalidate_linux_cache_inf): Update.
4016         (linux_inferior_data_cleanup): Remove.
4017         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4018
4019 2019-05-08  Tom Tromey  <tom@tromey.com>
4020
4021         * auxv.c (auxv_inferior_data): Move.  Change type.
4022         (auxv_inferior_data_cleanup): Remove.
4023         (invalidate_auxv_cache_inf): Rewrite.
4024         (get_auxv_inferior_data, _initialize_auxv): Update.
4025
4026 2019-05-08  Tom Tromey  <tom@tromey.com>
4027
4028         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4029         (symfile_debug_objfile_data_key): Change type.
4030         (symfile_debug_installed, debug_qf_has_symbols)
4031         (debug_qf_find_last_source_symtab)
4032         (debug_qf_forget_cached_source_info)
4033         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4034         (debug_qf_print_stats, debug_qf_dump)
4035         (debug_qf_expand_symtabs_for_function)
4036         (debug_qf_expand_all_symtabs)
4037         (debug_qf_expand_symtabs_with_fullname)
4038         (debug_qf_map_matching_symbols)
4039         (debug_qf_expand_symtabs_matching)
4040         (debug_qf_find_pc_sect_compunit_symtab)
4041         (debug_qf_map_symbol_filenames)
4042         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4043         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4044         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4045         (debug_sym_read_linetable, debug_sym_relocate): Update.
4046         (symfile_debug_free_objfile): Remove.
4047         (install_symfile_debug_logging, _initialize_symfile_debug):
4048         Update.
4049
4050 2019-05-08  Tom Tromey  <tom@tromey.com>
4051
4052         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4053         allocate_on_obstack.
4054         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4055         (get_dwarf2_per_objfile): Update.
4056         (set_dwarf2_per_objfile): Remove.
4057         (dwarf2_has_info, dwarf2_get_section_info): Update.
4058         (dwarf2_free_objfile): Remove.
4059         (_initialize_dwarf2_read): Update.
4060
4061 2019-05-08  Tom Tromey  <tom@tromey.com>
4062
4063         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4064         initializers.
4065         <unsupported_script_warning_printed,
4066         script_not_found_warning_printed>: Now bool.
4067         (auto_load_pspace_data): Change type.
4068         (~auto_load_pspace_info): Rename from
4069         auto_load_pspace_data_cleanup.
4070         (get_auto_load_pspace_data, init_loaded_scripts_info)
4071         (clear_section_scripts, maybe_print_unsupported_script_warning)
4072         (maybe_print_script_not_found_warning, _initialize_auto_load):
4073         Update.
4074
4075 2019-05-08  Tom Tromey  <tom@tromey.com>
4076
4077         * objfiles.c (objfile_pspace_info): Add destructor and
4078         initializers.
4079         (objfiles_pspace_data): Change type.
4080         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4081         (get_objfile_pspace_data): Update.
4082         (objfiles_bfd_data): Change type.
4083         (get_objfile_bfd_data): Update.
4084         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4085
4086 2019-05-08  Tom Tromey  <tom@tromey.com>
4087
4088         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4089         Change type.
4090         (get_catch_syscall_inferior_data): Update.
4091         (catch_syscall_inferior_data_cleanup): Remove.
4092         (_initialize_break_catch_syscall): Update.
4093
4094 2019-05-08  Tom Tromey  <tom@tromey.com>
4095
4096         * inflow.c (struct terminal_info): Add destructor and
4097         initializers.
4098         (inflow_inferior_data): Change type.
4099         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4100         (get_inflow_inferior_data, inflow_inferior_exit)
4101         (swap_terminal_info, _initialize_inflow): Update.
4102
4103 2019-05-08  Tom Tromey  <tom@tromey.com>
4104
4105         * target-dcache.c (target_dcache_cleanup): Remove.
4106         (target_dcache_aspace_key): Change type.
4107         (target_dcache_init_p, target_dcache_invalidate)
4108         (target_dcache_get, target_dcache_get_or_init)
4109         (_initialize_target_dcache): Update.
4110         * dcache.h (struct dcache_deleter): New.
4111
4112 2019-05-08  Tom Tromey  <tom@tromey.com>
4113
4114         * symtab.c (struct symbol_cache): Add destructor and
4115         initializers.
4116         (symbol_cache_key): Move.  Change type.
4117         (make_symbol_cache, free_symbol_cache): Remove.
4118         (get_symbol_cache): Update.
4119         (symbol_cache_cleanup): Remove.
4120         (ALL_PSPACES, symbol_cache_flush)
4121         (maintenance_print_symbol_cache)
4122         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4123         Update.
4124
4125 2019-05-08  Tom Tromey  <tom@tromey.com>
4126
4127         * symtab.c (struct main_info): Add destructor and initializers.
4128         (main_progspace_key): Move.  Change type.
4129         (get_main_info): Update.
4130         (main_info_cleanup): Remove.
4131         (_initialize_symtab): Update.
4132
4133 2019-05-08  Tom Tromey  <tom@tromey.com>
4134
4135         * registry.h (DECLARE_REGISTRY): Define the _key class.
4136
4137 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4138
4139         * NEWS: Merge two 'New commands' sections.
4140
4141 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4142
4143         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4144         parameter and use Ada language definition instead.
4145         (ada_val_print_ptr): Remove unused language parameter.
4146         (ada_val_print_num): Remove language parameter and use Ada language
4147         definition instead.
4148         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4149         parameter.
4150         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4151         parameter and use Ada language definition instead.
4152         (ada_val_print_1): Update all ada_val_print_xxx calls.
4153         Remove language parameter.
4154         (ada_val_print): Update ada_val_print_1 call.
4155
4156 2019-05-08  Tom Tromey  <tromey@adacore.com>
4157
4158         * remote.c (remote_hw_watchpoint_limit)
4159         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4160         Now static.
4161
4162 2019-05-08  Tom Tromey  <tromey@adacore.com>
4163
4164         * maint.c (_initialize_maint_cmds): Move initialization code to
4165         remote.c.
4166         (watchdog, show_watchdog): Move to remote.c.
4167         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4168         "watchdog" static.
4169         (_initialize_remote): Move initialization code from maint.c.
4170         * defs.h (watchdog): Don't declare.
4171
4172 2019-05-08  Tom Tromey  <tromey@adacore.com>
4173
4174         * tui/tui-interp.c: Include main.h.
4175         * interps.c: Include main.h.
4176         * main.h (interpreter_p): Declare.
4177         * defs.h (interpreter_p): Don't declare.
4178
4179 2019-05-08  Tom Tromey  <tromey@adacore.com>
4180
4181         * dwarf2loc.c: Include dwarf2read.h.
4182         * defs.h (read_unsigned_leb128): Don't declare.
4183         * dwarf2read.h (read_unsigned_leb128): Declare.
4184
4185 2019-05-08  Tom Tromey  <tromey@adacore.com>
4186
4187         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4188         method.
4189
4190 2019-05-08  Tom Tromey  <tromey@adacore.com>
4191
4192         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4193         when no wrap column is set.
4194
4195 2019-05-08  Tom Tromey  <tromey@adacore.com>
4196
4197         * c-lang.c (c_get_string): Handle non-C-style arrays.
4198
4199 2019-05-08  Tom Tromey  <tromey@adacore.com>
4200
4201         * typeprint.c (print_offset_data::update): Print the bit offset,
4202         not the number of bits remaining.
4203
4204 2019-05-08  Tom Tromey  <tromey@adacore.com>
4205
4206         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4207         padding at end of comment.
4208
4209 2019-05-08  Tom Tromey  <tromey@adacore.com>
4210
4211         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4212         Compare main types.
4213
4214 2019-05-06  Tom Tromey  <tom@tromey.com>
4215
4216         * common/scoped_mmap.c: Include common-defs.h.
4217         * common/scoped_mmap.h: Don't include config.h.
4218
4219 2019-05-04  Tom Tromey  <tom@tromey.com>
4220
4221         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4222         (struct aarch64_call_info): Add initializers.
4223         <si>: Now a std::vector.
4224         (pass_on_stack, aarch64_push_dummy_call): Update.
4225
4226 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4227             Tom Tromey  <tom@tromey.com>
4228
4229         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4230         (ppc_threads): Now a std::vector.  Now static.
4231         (hwdebug_find_thread_points_by_tid)
4232         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4233         Update.
4234
4235 2019-05-04  Tom Tromey  <tom@tromey.com>
4236
4237         * arc-tdep.c (arc_tdesc_init): Return bool.
4238
4239 2019-05-04  Tom Tromey  <tom@tromey.com>
4240
4241         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4242         Use gdb_assert_not_reached.
4243
4244 2019-05-04  Tom Tromey  <tom@tromey.com>
4245
4246         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4247         "false".
4248
4249 2019-05-04  Tom Tromey  <tom@tromey.com>
4250
4251         * arc-tdep.c (arc_tdesc_init): Use bool.
4252
4253 2019-05-04  Tom Tromey  <tom@tromey.com>
4254
4255         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4256
4257 2019-05-04  Tom Tromey  <tom@tromey.com>
4258
4259         * cli/cli-cmds.c (valid_command_p): Return bool.
4260
4261 2019-05-04  Tom Tromey  <tom@tromey.com>
4262
4263         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4264         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4265
4266 2019-05-04  Raul Tambre  <raul@tambre.ee>
4267
4268         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4269         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4270         operator for comparison.
4271
4272 2019-05-04  Tom Tromey  <tom@tromey.com>
4273
4274         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4275         (lookup_partial_symbol, print_partial_symbols)
4276         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4277         (psymbol_compare): Update.
4278         (add_psymbol_to_bcache): Clear the entire psymbol.
4279         (maintenance_check_psymtabs): Update.
4280         * psympriv.h (struct partial_symbol): Don't derive from
4281         general_symbol_info.
4282         <obj_section, unrelocated_address, address,
4283         set_unrelocated_address>: Update.
4284         <ginfo>: New member.
4285         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4286         (debug_names::write_psymbols): Update.
4287
4288 2019-05-04  Tom de Vries  <tdevries@suse.de>
4289
4290         * contrib/cc-with-tweaks.sh: Support -n arg.
4291
4292 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4293
4294         * corelow.c (core_target::detach): Ensure frame cache and
4295         register caches are cleared.
4296         inferior.c (exit_inferior_1): Likewise.
4297
4298 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4299             Tom Tromey  <tom@tromey.com>
4300
4301         * dictionary.c (collate_pending_symbols_by_language): Remove
4302         "struct" from foreach.
4303         * symtab.c (lookup_global_symbol_from_objfile)
4304         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4305         foreach.
4306         * ser-tcp.c (net_open): Remove "struct" from foreach.
4307         * objfiles.c (objfile_relocate, objfile_rebase)
4308         (objfile_has_symbols): Remove "struct" from foreach.
4309         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4310         from foreach.
4311         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4312         foreach.
4313         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4314         "struct" from foreach.
4315         * ada-lang.c (create_excep_cond_exprs)
4316         (ada_exception_catchpoint_cond_string): Remove "struct" from
4317         foreach.
4318
4319 2019-05-03  Tom Tromey  <tromey@adacore.com>
4320
4321         * ada-exp.y (convert_char_literal): Check suffix of each
4322         enumerator.
4323
4324 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4325
4326         PR ada/21406:
4327         * ada-exp.y (yywrap): Don't define.
4328         * ada-lex.l (%option): Add noyywrap
4329         (yywrap): Remove.
4330
4331 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4332
4333         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4334         _WIN32_WINNT to the XP level, unless already defined to a higher
4335         level.
4336
4337         * unittests/parse-connection-spec-selftests.c:
4338         * ser-tcp.c:
4339         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4340         override.
4341
4342         * symfile.c (find_separate_debug_file): Remove colon from the
4343         drive spec of DOS/Windows file names of the target, so that the
4344         file name produced from DEBUGDIR and the target's directory will
4345         be valid on DOS/Windows systems.
4346
4347 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4348
4349         * rust-lang.c (val_print_struct): Handle printing structures
4350         containing strings.
4351
4352 2019-05-02  Tom Tromey  <tromey@adacore.com>
4353
4354         * valarith.c (_initialize_valarith): Remove.
4355
4356 2019-05-01  Tom Tromey  <tromey@adacore.com>
4357
4358         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4359         bitfields.
4360
4361 2019-05-01  Tom Tromey  <tromey@adacore.com>
4362
4363         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4364         for big-endian copies.
4365
4366 2019-04-30  Ali Tamur  <tamur@google.com>
4367         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4368         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4369         (read_3_bytes): New function.
4370
4371 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4372
4373         * windows-nat.c (main_thread_id): Delete.
4374         (handle_output_debug_string): Replace main_thread_id by
4375         current_event.dwThreadId.
4376         (fake_create_process): Likewise.
4377         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4378         Do not set main_thread_id.
4379         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4380         current_event.dwThreadId.
4381         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4382
4383 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4384
4385         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4386         Use current_event.dwThreadId instead of main_thread_id.
4387
4388 2019-04-30  Tom Tromey  <tromey@adacore.com>
4389
4390         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4391         (create_excep_cond_exprs): Iterate over program spaces.
4392         (ada_exception_catchpoint_cond_string): Examine all minimal
4393         symbols for exception types.
4394
4395 2019-04-30  Tom Tromey  <tromey@adacore.com>
4396
4397         PR c++/24470:
4398         * dwarf2read.c (process_structure_scope): Handle case where type
4399         has template parameters but no symbol was created.
4400
4401 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4402             Chris January  <chris.january@arm.com>
4403
4404         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4405         qualifier.
4406         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4407
4408 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4409
4410         * f-typeprint.c (f_print_type): Update rules for printing
4411         whitespace.
4412         (f_type_print_varspec_suffix): Likewise.
4413
4414 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4415             Chris January  <chris.january@arm.com>
4416
4417         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4418         function arguments.
4419
4420 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4421
4422         * f-lang.c (build_fortran_types): Change name of void type to
4423         lower case.
4424         * f-typeprint.c (f_type_print_base): Print the name of the void
4425         type, rather than a fixed string.
4426         * f-valprint.c (f_decorations): Use lower case void string.
4427
4428 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4429             Chris January  <chris.january@arm.com>
4430
4431         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4432         types for Fortran.
4433
4434 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4435             Chris January  <chris.january@arm.com>
4436             David Lecomber  <david.lecomber@arm.com>
4437
4438         * f-exp.y (BINOP_INTRINSIC): New token.
4439         (exp): New parser rule handling BINOP_INTRINSIC.
4440         (f77_keywords): Add new builtin procedures.
4441         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4442         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4443         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4444         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4445         (print_unop_subexp_f): New function.
4446         (print_binop_subexp_f): New function.
4447         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4448         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4449         (dump_subexp_body_f): Likewise.
4450         (operator_check_f): Likewise.
4451         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4452         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4453
4454 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4455
4456         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4457         UNOP_KIND.
4458         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4459         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4460         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4461         (operator_length_f): New fuction.
4462         (print_subexp_f): New function.
4463         (op_name_f): New function.
4464         (dump_subexp_body_f): New function.
4465         (operator_check_f): New function.
4466         (exp_descriptor_f): Replace standard expression handling functions
4467         with new functions.
4468         * gdb/fortran-operator.def: New file.
4469         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4470         * gdb/std-operator.def: Remove UNOP_KIND.
4471
4472 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4473
4474         * std-operator.def: Remove unbalanced, stray double quote
4475         character.
4476
4477 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4478             Chris January  <chris.january@arm.com>
4479             Daniel Everett  <daniel.everett@arm.com>
4480             Nick Forrington  <nick.forrington@arm.com>
4481             Richard Bunt  <richard.bunt@arm.com>
4482
4483         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4484         of depth when printing anonymous structs or unions.
4485         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4486         Don't print either the top-level value, or the children if the
4487         max-depth is exceeded.
4488         (ppscm_print_children): When printing the key of a map, allow one
4489         extra level of depth.
4490         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4491         print either the top-level value, or the children if the max-depth
4492         is exceeded.
4493         (print_children): When printing the key of a map, allow one extra
4494         level of depth.
4495         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4496         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4497         (user_print_options): Initialise max_depth field.
4498         (val_print_scalar_or_string_type_p): New function.
4499         (val_print): Check to see if the max depth has been reached.
4500         (val_print_check_max_depth): Define new function.
4501         (show_print_max_depth): New function.
4502         (_initialize_valprint): Add 'print max-depth' option.
4503         * valprint.h (struct value_print_options) <max_depth>: New field.
4504         (val_print_check_max_depth): Declare new function.
4505         * NEWS: Document new feature.
4506
4507 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4508
4509         * ada-lang.c (ada_language_defn): Initialise new field.
4510         * c-lang.c (c_is_string_type_p): New function.
4511         (c_language_defn): Initialise new field.
4512         (cplus_language_defn): Initialise new field.
4513         (asm_language_defn): Initialise new field.
4514         (minimal_language_defn): Initialise new field.
4515         * c-lang.h (c_is_string_type_p): Declare new function.
4516         * d-lang.c (d_language_defn): Initialise new field.
4517         * f-lang.c (f_is_string_type_p): New function.
4518         (f_language_defn): Initialise new field.
4519         * go-lang.c (go_is_string_type_p): New function.
4520         (go_language_defn): Initialise new field.
4521         * language.c (default_is_string_type_p): New function.
4522         (unknown_language_defn): Initialise new field.
4523         (auto_language_defn): Initialise new field.
4524         * language.h (struct language_defn) <la_is_string_type_p>: New
4525         member variable.
4526         (default_is_string_type_p): Declare new function.
4527         * m2-lang.c (m2_language_defn): Initialise new field.
4528         * objc-lang.c (objc_language_defn): Initialise new field.
4529         * opencl-lang.c (opencl_language_defn): Initialise new field.
4530         * p-lang.c (pascal_is_string_type_p): New function.
4531         (pascal_language_defn): Initialise new field.
4532         * rust-lang.c (rust_is_string_type_p): New function.
4533         (rust_language_defn): Initialise new field.
4534
4535 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4536
4537         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4538         New field.
4539         * ada-lang.c (ada_language_defn): Initialise new field.
4540         * c-lang.c (c_language_defn): Likewise.
4541         (cplus_language_defn): Likewise.
4542         (asm_language_defn): Likewise.
4543         (minimal_language_defn): Likewise.
4544         * d-lang.c (d_language_defn): Likewise.
4545         * f-lang.c (f_language_defn): Likewise.
4546         * go-lang.c (go_language_defn): Likewise.
4547         * language.c (unknown_language_defn): Likewise.
4548         (auto_language_defn): Likewise.
4549         * m2-lang.c (m2_language_defn): Likewise.
4550         * objc-lang.c (objc_language_defn): Likewise.
4551         * opencl-lang.c (opencl_language_defn): Likewise.
4552         * p-lang.c (pascal_language_defn): Likewise.
4553         * rust-lang.c (rust_language_defn): Likewise.
4554
4555 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4556
4557         * ada-lang.c (ada_is_character_type): Change return type to bool.
4558         (ada_is_string_type): Likewise.
4559         * ada-lang.h (ada_is_character_type): Update declaration
4560         (ada_is_string_type): Likewise.
4561
4562 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4563
4564         Support style in 'frame|thread apply'
4565
4566         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4567         * record.c (record_start, record_stop): Update callers of
4568         execute_command_to_string with false.
4569         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4570         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4571         methods.
4572         (class string_file): New constructor with term_out parameter.
4573         Override methods term_out and can_emit_style_escape.  New member
4574         term_out.
4575         (class stdio_file): Override can_emit_style_escape.
4576         (class tee_file): Override term_out and can_emit_style_escape.
4577         * utils.h (can_emit_style_escape): Remove.
4578         * utils.c (can_emit_style_escape): Likewise.
4579         Update all callers of can_emit_style_escape (SOMESTREAM) to
4580         SOMESTREAM->can_emit_style_escape.
4581         * source-cache.c (source_cache::get_source_lines): Likewise.
4582         * stack.c (frame_apply_command_count): Call execute_command_to_string
4583         passing the term_out characteristic of the current gdb_stdout.
4584         * thread.c (thr_try_catch_cmd): Likewise.
4585         * top.c (execute_command_to_string): pass term_out parameter
4586         to construct the string_file for the command output.
4587         * ui-file.c (term_cli_styling): New function (most code moved
4588         from utils.c can_emit_style_escape).
4589         (string_file::string_file, string_file::can_emit_style_escape,
4590         stdio_file::can_emit_style_escape, tee_file::term_out,
4591         tee_file::can_emit_style_escape): New functions.
4592
4593 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4594
4595         * NEWS: Mention the new set|show may-call-functions.
4596         * infcall.c (may_call_functions_p): New variable.
4597         (show_may_call_functions_p): New function.
4598         (call_function_by_hand_dummy): Throws an error if not
4599         may-call-functions.
4600         (_initialize_infcall): Call add_setshow_boolean_cmd for
4601         may-call-functions.
4602
4603 2019-04-25  Keith Seitz  <keiths@redhat.com>
4604
4605         PR c++/24367
4606         * cp-support.c (inspect_type): Don't attempt substitutions
4607         of symbol with the same name.
4608
4609 2019-04-25  Tom Tromey  <tromey@adacore.com>
4610
4611         PR gdb/24475:
4612         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4613         static.
4614
4615 2019-04-25  Tom Tromey  <tromey@adacore.com>
4616
4617         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4618         rvalue reference.
4619         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4620         (gdb_xml_parser::parse): Use std::move.
4621         * python/python-internal.h (gdbpy_convert_exception): Take a const
4622         reference.
4623         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4624         std::move.
4625         * python/py-utils.c (gdbpy_convert_exception): Take a const
4626         reference.
4627         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4628         Use std::move.
4629         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4630         Use std::move.
4631         * mi/mi-main.c (mi_print_exception): Take a const reference.
4632         * main.c (handle_command_errors): Take a const reference.
4633         * linespec.c (parse_linespec): Use std::move.
4634         * infcall.c (run_inferior_call): Use std::move.
4635         (call_function_by_hand_dummy): Use std::move.
4636         * exec.c (try_open_exec_file): Use std::move.
4637         * exceptions.h (exception_print, exception_fprintf)
4638         (exception_print_same): Update.
4639         * exceptions.c (print_exception, exception_print)
4640         (exception_fprintf, exception_print_same): Change parameters to
4641         const reference.
4642         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4643         * common/new-op.c: Use std::move.
4644         * common/common-exceptions.h (struct gdb_exception): Add move
4645         constructor.
4646         (struct gdb_exception_error, struct gdb_exception_quit, struct
4647         gdb_quit_bad_alloc): Change constructor to move constructor.
4648         (throw_exception): Change parameter to rvalue reference.
4649         * common/common-exceptions.c (throw_exception): Take rvalue
4650         reference.
4651         * cli/cli-interp.c (safe_execute_command): Use std::move.
4652         * breakpoint.c (insert_bp_location, location_to_sals): Use
4653         std::move.
4654
4655 2019-04-25  Tom Tromey  <tromey@adacore.com>
4656
4657         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4658         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4659         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4660         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4661         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4662         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4663         guile/scm-value.c: Use unpack.
4664         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4665         gdbscm_gdb_exception.
4666         (gdbscm_throw_gdb_exception): Likewise.
4667         (struct gdbscm_gdb_exception): New.
4668         (unpack): New function.
4669         (gdbscm_wrap): Use unpack.
4670
4671 2019-04-25  Tom Tromey  <tromey@adacore.com>
4672
4673         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4674         (gdb_rl_callback_handler): Use std::move.
4675         * common/common-exceptions.h (struct gdb_exception): Add move
4676         assignment operator.
4677         (throw_exception_sjlj): Change "exception" to const reference.
4678         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4679         (throw_exception_sjlj): Change "exception" to const reference.
4680
4681 2019-04-25  Tom Tromey  <tromey@adacore.com>
4682
4683         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4684         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4685         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4686         Update.
4687         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4688         Update.
4689         * mi/mi-interp.c (mi_interp::exec): Update.
4690         * linespec.c (parse_linespec): Update.
4691         * infcall.c (run_inferior_call): Update.
4692         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4693         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4694         (gdbscm_lookup_global_symbol): Update.
4695         * guile/scm-param.c (gdbscm_parameter_value): Update.
4696         * guile/scm-frame.c (gdbscm_frame_read_register)
4697         (gdbscm_frame_read_var): Update.
4698         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4699         * exec.c (try_open_exec_file): Update.
4700         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4701         (gdb_rl_callback_handler): Update.
4702         * common/common-exceptions.h (exception_none): Don't declare.
4703         * common/common-exceptions.c (exception_none): Don't define.
4704         (struct catcher) <exception>: Update.
4705         * cli/cli-interp.c (safe_execute_command): Update.
4706         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4707
4708 2019-04-25  Ali Tamur  <tamur@google.com>
4709
4710         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4711         (read_attribute_value): Likewise.
4712         (dwarf2_read_addr_index): Update comment.
4713         (read_str_index): Add DW_FORM_strx.
4714         (dwarf2_string_attr): Likewise.
4715         (dwarf2_const_value_attr): Likewise.
4716         (dump_die_shallow): Likewise.
4717         (dwarf2_fetch_constant_bytes): Likewise.
4718         (skip_form_bytes): Likewise.
4719         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4720
4721 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4722
4723         PR corefiles/11608
4724         PR corefiles/18187
4725         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4726         OFFSET.  Verify if current mapping contains an ELF header.
4727         (linux_find_memory_regions_full): Adjust call to
4728         dump_mapping_p.
4729
4730 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4731             Kang Li <kanglictf@gmail.com>
4732
4733         PR gdb/21600
4734
4735         * dwarf2-frame.c (read_initial_length): Be consistent about using
4736         unsigned representation of length.
4737         (decode_frame_entry_1): Likewise.  Check for wraparound of
4738         end pointer as well as buffer overflow.
4739
4740 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4741
4742         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4743         "vq".
4744
4745 2019-04-24  Tom Tromey  <tromey@adacore.com>
4746
4747         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4748
4749 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4750
4751         * s12z-tdep.c (s12z_unwind_pc): Delete.
4752         (s12z_unwind_sp): Delete.
4753         (s12z_gdbarch_init): Don't register deleted functions with
4754         gdbarch.
4755
4756 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4757
4758         * rl78-tdep.c (rl78_unwind_sp): Delete.
4759         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4760
4761 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4762
4763         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4764         (xstormy16_unwind_pc): Delete.
4765         (xstormy16_dummy_id): Delete.
4766         (xstormy16_gdbarch_init): Don't register deleted functions with
4767         gdbarch.
4768
4769 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4770
4771         * vax-tdep.c (vax_unwind_pc): Delete.
4772         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4773
4774 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4775
4776         * v850-tdep.c (v850_unwind_sp): Delete.
4777         (v850_unwind_pc): Delete.
4778         (v850_dummy_id): Delete.
4779         (v850_gdbarch_init): Don't register deleted functions with
4780         gdbarch.
4781
4782 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4783
4784         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4785         (tilegx_unwind_pc): Delete.
4786         (tilegx_unwind_dummy_id): Delete.
4787         (tilegx_gdbarch_init): Don't register deleted functions with
4788         gdbarch.
4789
4790 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4791
4792         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4793         (tic6x_dummy_id): Delete.
4794         (tic6x_gdbarch_init): Don't register deleted functions with
4795         gdbarch.
4796
4797 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4798
4799         * sparc-tdep.c (sparc_unwind_pc): Delete.
4800         (sparc32_gdbarch_init): Don't register deleted function with
4801         gdbarch.
4802
4803 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4804
4805         * sh-tdep.c (sh_unwind_sp): Delete.
4806         (sh_unwind_pc): Delete.
4807         (sh_dummy_id): Delete.
4808         (sh_gdbarch_init): Don't register deleted functions with
4809         gdbarch.
4810
4811 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4812
4813         * score-tdep.c (score_unwind_sp): Delete.
4814         (score_unwind_pc): Delete.
4815         (score_dummy_id): Delete.
4816         (score_gdbarch_init): Don't register deleted functions with
4817         gdbarch.
4818
4819 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4820
4821         * rx-tdep.c (rx_unwind_pc): Delete.
4822         (rx_unwind_sp): Delete.
4823         (rx_dummy_id): Delete.
4824         (rx_gdbarch_init): Don't register deleted functions with
4825         gdbarch.  Update comment.
4826
4827 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4828
4829         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4830         (rs6000_dummy_id): Delete.
4831         (rs6000_gdbarch_init): Don't register deleted functions with
4832         gdbarch.
4833
4834 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4835
4836         * or1k-tdep.c (or1k_dummy_id): Delete.
4837         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4838
4839 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4840
4841         * nios2-tdep.c (nios2_dummy_id): Delete.
4842         (nios2_unwind_sp): Delete.
4843         (nios2_gdbarch_init): Don't register deleted functions with
4844         gdbarch.
4845
4846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4847
4848         * nds32-tdep.c (nds32_dummy_id): Delete.
4849         (nds32_unwind_pc): Delete.
4850         (nds32_unwind_sp): Delete.
4851         (nds32_gdbarch_init): Don't register deleted functions with
4852         gdbarch.
4853
4854 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4855
4856         * msp430-tdep.c (msp430_unwind_pc): Delete.
4857         (msp430_unwind_sp): Delete.
4858         (msp430_dummy_id): Delete.
4859         (msp430_gdbarch_init): Don't register deleted functions with
4860         gdbarch.
4861
4862 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4863
4864         * moxie-tdep.c (moxie_unwind_sp): Delete.
4865         (moxie_unwind_pc): Delete.
4866         (moxie_dummy_id): Delete.
4867         (moxie_gdbarch_init): Don't register deleted functions with
4868         gdbarch.
4869
4870 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4871
4872         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4873         (mn10300_unwind_pc): Delete.
4874         (mn10300_unwind_sp): Delete.
4875         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4876         mn10300_unwind_sp.
4877         (mn10300_frame_unwind_init): Don't register deleted functions with
4878         gdbarch.
4879
4880 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4881
4882         * mep-tdep.c (mep_unwind_pc): Delete.
4883         (mep_unwind_sp): Delete.
4884         (mep_dummy_id): Delete.
4885         (mep_gdbarch_init): Don't register deleted functions with
4886         gdbarch.
4887
4888 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4889
4890         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4891         (m68hc11_unwind_sp): Delete.
4892         (m68hc11_gdbarch_init): Don't register deleted functions with
4893         gdbarch.
4894
4895 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4896
4897         * m32r-tdep.c (m32r_unwind_sp): Delete.
4898         (m32r_unwind_pc): Delete.
4899         (m32r_dummy_id): Delete.
4900         (m32r_gdbarch_init): Don't register deleted functions with
4901         gdbarch.
4902
4903 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4904
4905         * m32c-tdep.c (m32c_unwind_pc): Delete.
4906         (m32c_unwind_sp): Delete.
4907         (m32c_dummy_id): Delete.
4908         (m32c_gdbarch_init): Don't register deleted functions with
4909         gdbarch.
4910
4911 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4912
4913         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4914         (lm32_unwind_pc): Delete.
4915         (lm32_dummy_id): Delete.
4916         (lm32_gdbarch_init): Don't register deleted functions with
4917         gdbarch.
4918
4919 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4920
4921         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4922         (iq2000_unwind_pc): Delete.
4923         (iq2000_dummy_id): Delete.
4924         (iq2000_gdbarch_init): Don't register deleted functions with
4925         gdbarch.
4926
4927 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4928
4929         * nds32-tdep.c (nds32_type_align): Delete.
4930         (nds32_push_dummy_call): Use type_align instead.
4931
4932 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4933
4934         * arm-tdep.c (arm_type_align): Only handle vector override case.
4935         (arm_push_dummy_call): Use type_align.
4936         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4937
4938 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4939
4940         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4941         case.
4942         (pass_on_stack): Use type_align.
4943         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4944         function.
4945
4946 2019-04-23  Tom Tromey  <tromey@adacore.com>
4947
4948         * dwarf2read.c (line_header::file_name_at): Remove unused
4949         overload.
4950
4951 2019-04-23  Tom de Vries  <tdevries@suse.de>
4952
4953         PR gdb/24438
4954         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4955         invocation.
4956
4957
4958 2019-03-27  Ali Tamur  <tamur@google.com>
4959
4960         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4961         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4962         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4963         (dwarf_expr_context::get_addr_index): Likewise
4964         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4965         (symbol_needs_eval_context::get_addr_index): Likewise
4966         (disassemble_dwarf_expression): Add DW_OP_addrx
4967         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4968         (read_cutu_die_from_dwo): Update comment
4969         (skip_one_die): Add DW_FORM_addrx
4970         (read_attribute_value): Likewise
4971         (var_decode_location): Add DW_OP_addrx
4972         (dwarf2_const_value_attr): Add DW_FORM_addrx
4973         (dump_die_shallow): Likewise
4974         (dwarf2_fetch_constant_bytes): Likewise
4975         (decode_locdesc): Add DW_OP_addrx
4976         (skip_form_bytes): Add DW_FORM_addrx
4977
4978 2019-04-22  Ali Tamur  <tamur@google.com>
4979
4980         * MAINTAINERS (Write After Approval): Add self.
4981
4982 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4983
4984         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4985         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4986         (open_symbol_file_object): Likewise.
4987         (svr4_default_sos): Add info parameter.
4988         (svr4_read_so_list): Likewise.
4989         (svr4_current_sos_direct): Adjust functions calls to pass down
4990         info.
4991         (svr4_current_sos_1): Add info parameter.
4992         (svr4_current_sos): Call get_svr4_info, pass info down to
4993         svr4_current_sos_1.
4994         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4995         get_svr4_info.
4996         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4997         get_svr4_info.
4998         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4999         to get_svr4_info.
5000         (probes_table_remove_objfile_probes): Likewise.
5001         (register_solib_event_probe): Add info parameter.
5002         (solist_update_incremental): Pass info parameter down to
5003         svr4_read_so_list.
5004         (disable_probes_interface): Add info parameter.
5005         (svr4_handle_solib_event): Pass current_program_space to
5006         get_svr4_info.  Adjust disable_probes_interface cleanup.
5007         (svr4_create_probe_breakpoints): Add info parameter, pass it
5008         down to register_solib_event_probe.
5009         (svr4_create_solib_event_breakpoints): Add info parameter,
5010         pass it down to svr4_create_probe_breakpoints.
5011         (enable_break): Pass info down to
5012         svr4_create_solib_event_breakpoints.
5013         (svr4_solib_create_inferior_hook): Pass current_program_space to
5014         get_svr4_info.
5015         (svr4_clear_solib): Likewise.
5016
5017 2019-04-22  Pedro Alves  <palves@redhat.com>
5018
5019         * solib-svr4.c (svr4_free_objfile_observer): New.
5020         (probe_and_action::objfile): New field.
5021         (probes_table_htab_remove_objfile_probes)
5022         (probes_table_remove_objfile_probes): New functions.
5023         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5024         in the new probe_and_action.  Don't store the probe in 'lookup'.
5025         (svr4_create_probe_breakpoints): Pass objfile to
5026         register_solib_event_probe.
5027         (_initialize_svr4_solib): Register a free_objfile observer.
5028
5029 2019-04-19  Tom Tromey  <tom@tromey.com>
5030
5031         * common/queue.h: Remove.
5032
5033 2019-04-19  Tom Tromey  <tom@tromey.com>
5034
5035         * event-loop.c: Don't include "common/queue.h".
5036
5037 2019-04-19  Tom Tromey  <tom@tromey.com>
5038
5039         * remote.c (remote_target): Use delete.
5040         * remote-notif.h: Include <list>, not "common/queue.h".
5041         (notif_client_p): Remove typedef.
5042         (remote_notif_state): Add constructor, destructor, initializer.
5043         <notif_queue>: Now a std::list.
5044         (remote_notif_state_xfree): Don't declare.
5045         * remote-notif.c (remote_notif_process, handle_notification)
5046         (remote_notif_state_allocate): Update.
5047         (~remote_notif_state): Rename from remote_notif_state_xfree.
5048
5049 2019-04-19  Tom Tromey  <tom@tromey.com>
5050
5051         * symfile.c (reread_symbols): Update.
5052         * objfiles.c (objfile_register_static_link)
5053         (objfile_lookup_static_link): Update
5054         (~objfile) Don't delete static_links.
5055         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5056
5057 2019-04-19  Tom Tromey  <tom@tromey.com>
5058
5059         * type-stack.h (struct type_stack) <insert>: Constify string.
5060         * type-stack.c (type_stack::insert): Constify string.
5061         * gdbtypes.h (lookup_template_type): Update.
5062         (address_space_name_to_int): Update.
5063         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5064         const.
5065         (lookup_template_type): Make name const.
5066         * c-exp.y: Update rules.
5067         (lex_one_token, classify_name, classify_inner_name)
5068         (c_print_token): Update.
5069         * p-exp.y: Update rules.
5070         (yylex): Update.
5071         * f-exp.y: Update rules.
5072         (yylex): Update.
5073         * d-exp.y: Update rules.
5074         (lex_one_token, classify_name, classify_inner_name): Update.
5075         * parse.c (write_dollar_variable, copy_name): Return std::string.
5076         * parser-defs.h (copy_name): Change return type.
5077         * m2-exp.y: Update rules.
5078         (yylex): Update.
5079         * go-exp.y (lex_one_token): Update.
5080         Update rules.
5081         (classify_unsafe_function, classify_packaged_name)
5082         (classify_name, yylex): Update.
5083
5084 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5085
5086         * configure.ac: add --enable-source-highlight switch.
5087         * configure: Regenerate.
5088         * top.c (print_gdb_version): plumb --enable-source-highlight
5089         status to "show configuration".
5090
5091 2019-04-19  Tom Tromey  <tromey@adacore.com>
5092
5093         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5094         Check ADA_TYPE_P.
5095         (empty_record, ada_template_to_fixed_record_type_1)
5096         (template_to_static_fixed_type)
5097         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5098         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5099         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5100         macros.
5101
5102 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5103
5104         PR symtab/24423:
5105         * source.c (print_source_lines_base): Advance "iter" when a
5106         control character is seen.
5107
5108 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5109
5110         * inferior.h (struct infcall_suspend_state_deleter):
5111         Catch exception in destructor to avoid crash.
5112
5113 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5114
5115         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5116         close to the add_com "shell".
5117
5118 2019-04-18  Tom Tromey  <tromey@adacore.com>
5119
5120         * process-stratum-target.h (class process_stratum_target)
5121         <stratum>: Add "final".
5122
5123 2019-04-17  Tom Tromey  <tromey@adacore.com>
5124
5125         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5126         against nullptr before use.
5127
5128 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5129
5130         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5131
5132 2019-04-17  Jim Wilson  <jimw@sifive.com>
5133             Andrew Burgess  <andrew.burgess@embecosm.com>
5134
5135         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5136         code read might fail, assume 4-byte breakpoint in that case.
5137
5138 2019-04-15  Leszek Swirski  <leszeks@google.com>
5139
5140         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5141         rather than a hand-rolled POD check when checking for forced MEMORY
5142         classification.
5143
5144 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5145
5146         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5147         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5148         function.
5149         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5150         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5151         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5152         declaration.
5153
5154 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5155
5156         * aarch64-linux-nat.c
5157         (aarch64_linux_nat_target::thread_architecture): Add override.
5158         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5159         each VQ.
5160
5161 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5162
5163         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5164
5165 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5166
5167         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5168         target types of size 96-bits, add some additional comments, and
5169         check that the builtin type we found was the correct size.
5170
5171 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5172
5173         * utils.c (prompt_for_continue): Don't restore the styling at the
5174         end, as applied_style has the wrong value.  This fixes styling in
5175         long lists of file names that are interrupted by the "Continue?"
5176         prompt.
5177
5178 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5179
5180         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5181         * c-lang.c (c_language_defn): Likewise.
5182         (cplus_language_defn): Likewise.
5183         (asm_language_defn): Likewise.
5184         (minimal_language_defn): Likewise.
5185         * d-lang.c (d_language_defn): Likewise.
5186         * f-lang.c (f_language_defn): Likewise.
5187         * go-lang.c (go_language_defn): Likewise.
5188         * language.c (unknown_language_defn): Likewise.
5189         (auto_language_defn): Likewise.
5190         * language.h (struct language_defn): Remove la_magic field.
5191         (LANG_MAGIC): Delete.
5192         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5193         * objc-lang.c (objc_language_defn): Likewise.
5194         * opencl-lang.c (opencl_language_defn): Likewise.
5195         * p-lang.c (pascal_language_defn): Likewise.
5196         * rust-lang.c (rust_language_defn): Likewise.
5197
5198 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5199
5200         * riscv-tdep.c (riscv_type_align): New function.
5201         (riscv_type_alignment): Delete.
5202         (riscv_arg_location): Use 'type_align'.
5203         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5204
5205 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5206
5207         * gdbtypes.c (type_align): A struct with no non-static fields also
5208         has alignment of 1.
5209
5210 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5211
5212         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5213         component to 0.
5214         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5215         member.
5216         (riscv_struct_info::analyse): New implementation using new
5217         analyse_inner member function.
5218         (riscv_struct_info::field_offset): New member function.
5219         (riscv_struct_info::m_offsets): New member variable.
5220         (riscv_struct_info::analyse_inner): New private member function,
5221         takes the old implementation of riscv_struct_info::analyse but
5222         extended to track field offsets.
5223         (riscv_call_arg_struct): Update the struct folding special cases
5224         to handle cases where empty C++ structs, which are non-zero
5225         length, are found.
5226         (riscv_arg_location): Initialise the length of each location, a
5227         non-zero length now indicates the location is in use.
5228         (riscv_push_dummy_call): Allow for the first location having a
5229         non-zero offset when setting up arguments.
5230         (riscv_return_value): Likewise, but for return values.
5231
5232 2019-04-11  Tom Tromey  <tromey@adacore.com>
5233
5234         * utils.c (internal_vproblem): Make "msg" const.
5235
5236 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5237
5238         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5239         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5240         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5241         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5242
5243 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5244
5245         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5246         function.
5247         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5248         of amd64_collect_native_gregset.
5249         (amd64_linux_nat_target::store_registers): Likewise.
5250
5251 2019-04-10  Tom Tromey  <tom@tromey.com>
5252
5253         * symtab.c (lookup_global_symbol_from_objfile)
5254         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5255         * objfiles.h (class separate_debug_iterator): New.
5256         (class separate_debug_range): New.
5257         (struct objfile) <separate_debug_objfiles>: New method.
5258         (objfile_separate_debug_iterate): Don't declare.
5259         * objfiles.c (separate_debug_iterator::operator++): Rename from
5260         objfile_separate_debug_iterate.
5261         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5262         iterator.
5263         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5264         iterator.
5265
5266 2019-04-10  Tom Tromey  <tom@tromey.com>
5267
5268         * symfile.c (reread_symbols): Remove old comment.
5269         * objfiles.c (free_all_objfiles): Fix a typo.
5270
5271 2019-04-10  Tom Tromey  <tom@tromey.com>
5272
5273         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5274         * minsyms.c (lookup_minimal_symbol): Use foreach.
5275         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5276         (lookup_minimal_symbol_solib_trampoline): Likewise.
5277         * symfile.c (reread_symbols): Use foreach.
5278
5279 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5280             Tom Tromey  <tromey@adacore.com>
5281
5282         PR rust/24414:
5283         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5284         (rust_lex_int_test): Change "value" to be LONGEST.
5285         (rust_lex_tests): Add test for long integer literal.
5286
5287 2019-04-09  Tom Tromey  <tromey@adacore.com>
5288
5289         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5290         to bool.
5291         (extended_remote_target::attach): Update.
5292         (remote_target::remote_notice_new_inferior): Update.
5293         (remote_target::add_current_inferior_and_thread): Update.
5294         * inferior.c (exit_inferior_1): Use "false".
5295         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5296
5297 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5298
5299         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5300         the "start" command.
5301
5302 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5303
5304         * python/py-inferior.c (infpy_thread_from_thread_handle):
5305         Adjust comments to reflect renaming of thread_from_thread_handle
5306         to thread_from_handle.  Adjust keywords.  Fix type error message.
5307         (inferior_object_methods): Add thread_from_handle.  Retain
5308         thread_from_thread_handle, but mark it as deprecated.
5309
5310 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5311
5312         * gdbthread.h (find_thread_by_handle): Revise declaration.
5313         * thread.c (find_thread_by_handle): Likewise.  Adjust
5314         implementation too.
5315         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5316         support for buffer objects as handles.
5317
5318 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5319
5320         * python/py-infthread.c (thpy_thread_handle): New function.
5321         (thread_object_methods): Register thpy_thread_handle.
5322
5323 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5324
5325         * gdbthread.h (thread_to_thread_handle): Declare.
5326         * thread.c (gdbtypes.h): Include.
5327         (thread_to_thread_handle): New function.
5328
5329         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5330         (target_thread_info_to_thread_handle): Declare.
5331         * target.c (target_thread_info_to_thread_handle): New function.
5332         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5333         * target-delegates.c: Regenerate.
5334
5335         * linux-thread-db.c (class thread_db_target): Add method
5336         thread_info_to_thread_handle.
5337         (thread_db_target::thread_info_to_thread_handle): Define.
5338         * remote.c (class remote_target): Add new method
5339         thread_info_to_thread_handle.
5340         (remote_target::thread_info_to_thread_handle): Define.
5341
5342 2019-04-08  Pedro Alves  <palves@redhat.com>
5343
5344         * common/common-exceptions.c (throw_exception): Don't create
5345         named object to throw; throw directly.
5346         (throw_it): Likewise.  Don't initialize gdb_exception::message
5347         here, with new; pass FMT and AP to the ctor instead.
5348         * common/common-exceptions.h: Include <string>.
5349         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5350         const char *, va_list)): New ctor.  Use std::make_shared.
5351         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5352         errors)): Delete.
5353         (gdb_exception_error::gdb_exception_error(enum errors, const char
5354         *, va_list)): New.
5355         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5356         Add assertion.
5357         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5358         errors)): Delete.
5359         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5360         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5361         Add assertion.
5362
5363 2019-04-08  Tom Tromey  <tom@tromey.com>
5364
5365         * valops.c (value_rtti_indirect_type): Replace throw_exception
5366         with throw.
5367         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5368         with throw.
5369         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5370         throw.
5371         * target.c (target_translate_tls_address): Replace throw_exception
5372         with throw.
5373         * stack.c (frame_apply_command_count): Replace throw_exception
5374         with throw.
5375         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5376         throw.
5377         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5378         with throw.
5379         * rs6000-tdep.c (rs6000_frame_cache)
5380         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5381         * remote.c: Replace throw_exception with throw.
5382         * record-full.c (record_full_message, record_full_wait_1)
5383         (record_full_restore): Replace throw_exception with throw.
5384         * record-btrace.c:
5385         (get_thread_current_frame_id, record_btrace_start_replaying)
5386         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5387         (cmd_record_btrace_start): Replace throw_exception with throw.
5388         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5389         throw.
5390         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5391         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5392         * linespec.c:
5393         (find_linespec_symbols): Replace throw_exception with throw.
5394         * infrun.c (displaced_step_prepare, resume): Replace
5395         throw_exception with throw.
5396         * infcmd.c (post_create_inferior): Replace throw_exception with
5397         throw.
5398         * inf-loop.c (inferior_event_handler): Replace throw_exception
5399         with throw.
5400         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5401         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5402         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5403         (get_prev_frame_always, get_frame_pc_if_available)
5404         (get_frame_address_in_block_if_available, get_frame_language):
5405         Replace throw_exception with throw.
5406         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5407         throw_exception with throw.
5408         * eval.c (fetch_subexp_value, evaluate_var_value)
5409         (evaluate_funcall, evaluate_subexp_standard): Replace
5410         throw_exception with throw.
5411         * dwarf2loc.c (call_site_find_chain)
5412         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5413         Replace throw_exception with throw.
5414         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5415         with throw.
5416         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5417         throw.
5418         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5419         * completer.c (complete_line_internal): Replace throw_exception
5420         with throw.
5421         * compile/compile-object-run.c (compile_object_run): Replace
5422         throw_exception with throw.
5423         * cli/cli-script.c (process_next_line): Replace throw_exception
5424         with throw.
5425         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5426         (btrace_enable, btrace_maint_update_pt_packets): Replace
5427         throw_exception with throw.
5428         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5429         throw_exception with throw.
5430         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5431         throw_exception with throw.
5432         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5433         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5434         * aarch64-tdep.c (aarch64_make_prologue_cache)
5435         (aarch64_make_stub_cache): Replace throw_exception with throw.
5436
5437 2019-04-08  Tom Tromey  <tom@tromey.com>
5438
5439         * common/common-exceptions.c (throw_exception): Rename from
5440         throw_exception_cxx.  Remove old copy.  Make argument const.
5441         (throw_it): Create and throw exception objects directly.
5442         * common/common-exceptions.h (throw_exception): Make argument
5443         const.
5444         (struct gdb_exception_error): Add constructor.
5445         (struct gdb_exception_quit): Add constructor.
5446
5447 2019-04-08  Tom Tromey  <tom@tromey.com>
5448
5449         * common/common-exceptions.h (exception_rethrow): Don't declare.
5450         (TRY_SJLJ): Update comment.
5451         (TRY, CATCH, END_CATCH): Remove.
5452         * common/common-exceptions.c (exception_rethrow): Remove.
5453
5454 2019-04-08  Tom Tromey  <tom@tromey.com>
5455
5456         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5457         Remove.
5458         (gdb_exception_error): Rename from
5459         gdb_exception_RETURN_MASK_ERROR.
5460         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5461         (gdb_quit_bad_alloc): Update.
5462         * aarch64-tdep.c: Update.
5463         * ada-lang.c: Update.
5464         * ada-typeprint.c: Update.
5465         * ada-valprint.c: Update.
5466         * amd64-tdep.c: Update.
5467         * arch-utils.c: Update.
5468         * break-catch-throw.c: Update.
5469         * breakpoint.c: Update.
5470         * btrace.c: Update.
5471         * c-varobj.c: Update.
5472         * cli/cli-cmds.c: Update.
5473         * cli/cli-interp.c: Update.
5474         * cli/cli-script.c: Update.
5475         * common/common-exceptions.c: Update.
5476         * common/new-op.c: Update.
5477         * common/selftest.c: Update.
5478         * compile/compile-c-symbols.c: Update.
5479         * compile/compile-cplus-symbols.c: Update.
5480         * compile/compile-object-load.c: Update.
5481         * compile/compile-object-run.c: Update.
5482         * completer.c: Update.
5483         * corelow.c: Update.
5484         * cp-abi.c: Update.
5485         * cp-support.c: Update.
5486         * cp-valprint.c: Update.
5487         * darwin-nat.c: Update.
5488         * disasm-selftests.c: Update.
5489         * dtrace-probe.c: Update.
5490         * dwarf-index-cache.c: Update.
5491         * dwarf-index-write.c: Update.
5492         * dwarf2-frame-tailcall.c: Update.
5493         * dwarf2-frame.c: Update.
5494         * dwarf2loc.c: Update.
5495         * dwarf2read.c: Update.
5496         * eval.c: Update.
5497         * event-loop.c: Update.
5498         * event-top.c: Update.
5499         * exec.c: Update.
5500         * f-valprint.c: Update.
5501         * fbsd-tdep.c: Update.
5502         * frame-unwind.c: Update.
5503         * frame.c: Update.
5504         * gdbtypes.c: Update.
5505         * gnu-v3-abi.c: Update.
5506         * guile/guile-internal.h: Update.
5507         * guile/scm-block.c: Update.
5508         * guile/scm-breakpoint.c: Update.
5509         * guile/scm-cmd.c: Update.
5510         * guile/scm-disasm.c: Update.
5511         * guile/scm-frame.c: Update.
5512         * guile/scm-lazy-string.c: Update.
5513         * guile/scm-math.c: Update.
5514         * guile/scm-param.c: Update.
5515         * guile/scm-ports.c: Update.
5516         * guile/scm-pretty-print.c: Update.
5517         * guile/scm-symbol.c: Update.
5518         * guile/scm-symtab.c: Update.
5519         * guile/scm-type.c: Update.
5520         * guile/scm-value.c: Update.
5521         * i386-linux-tdep.c: Update.
5522         * i386-tdep.c: Update.
5523         * inf-loop.c: Update.
5524         * infcall.c: Update.
5525         * infcmd.c: Update.
5526         * infrun.c: Update.
5527         * jit.c: Update.
5528         * language.c: Update.
5529         * linespec.c: Update.
5530         * linux-fork.c: Update.
5531         * linux-nat.c: Update.
5532         * linux-tdep.c: Update.
5533         * linux-thread-db.c: Update.
5534         * main.c: Update.
5535         * mi/mi-cmd-break.c: Update.
5536         * mi/mi-cmd-stack.c: Update.
5537         * mi/mi-interp.c: Update.
5538         * mi/mi-main.c: Update.
5539         * objc-lang.c: Update.
5540         * p-valprint.c: Update.
5541         * parse.c: Update.
5542         * ppc-linux-tdep.c: Update.
5543         * printcmd.c: Update.
5544         * python/py-arch.c: Update.
5545         * python/py-breakpoint.c: Update.
5546         * python/py-cmd.c: Update.
5547         * python/py-finishbreakpoint.c: Update.
5548         * python/py-frame.c: Update.
5549         * python/py-framefilter.c: Update.
5550         * python/py-gdb-readline.c: Update.
5551         * python/py-inferior.c: Update.
5552         * python/py-infthread.c: Update.
5553         * python/py-lazy-string.c: Update.
5554         * python/py-linetable.c: Update.
5555         * python/py-objfile.c: Update.
5556         * python/py-param.c: Update.
5557         * python/py-prettyprint.c: Update.
5558         * python/py-progspace.c: Update.
5559         * python/py-record-btrace.c: Update.
5560         * python/py-record.c: Update.
5561         * python/py-symbol.c: Update.
5562         * python/py-type.c: Update.
5563         * python/py-unwind.c: Update.
5564         * python/py-utils.c: Update.
5565         * python/py-value.c: Update.
5566         * python/python.c: Update.
5567         * record-btrace.c: Update.
5568         * record-full.c: Update.
5569         * remote-fileio.c: Update.
5570         * remote.c: Update.
5571         * riscv-tdep.c: Update.
5572         * rs6000-aix-tdep.c: Update.
5573         * rs6000-tdep.c: Update.
5574         * rust-exp.y: Update.
5575         * rust-lang.c: Update.
5576         * s390-tdep.c: Update.
5577         * selftest-arch.c: Update.
5578         * solib-dsbt.c: Update.
5579         * solib-frv.c: Update.
5580         * solib-spu.c: Update.
5581         * solib-svr4.c: Update.
5582         * solib.c: Update.
5583         * sparc64-linux-tdep.c: Update.
5584         * stack.c: Update.
5585         * symfile-mem.c: Update.
5586         * symmisc.c: Update.
5587         * target.c: Update.
5588         * thread.c: Update.
5589         * top.c: Update.
5590         * tracefile-tfile.c: Update.
5591         * tui/tui.c: Update.
5592         * typeprint.c: Update.
5593         * unittests/cli-utils-selftests.c: Update.
5594         * unittests/parse-connection-spec-selftests.c: Update.
5595         * valops.c: Update.
5596         * valprint.c: Update.
5597         * value.c: Update.
5598         * varobj.c: Update.
5599         * windows-nat.c: Update.
5600         * x86-linux-nat.c: Update.
5601         * xml-support.c: Update.
5602
5603 2019-04-08  Tom Tromey  <tom@tromey.com>
5604
5605         * xml-support.c: Use C++ exception handling.
5606         * x86-linux-nat.c: Use C++ exception handling.
5607         * windows-nat.c: Use C++ exception handling.
5608         * varobj.c: Use C++ exception handling.
5609         * value.c: Use C++ exception handling.
5610         * valprint.c: Use C++ exception handling.
5611         * valops.c: Use C++ exception handling.
5612         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5613         handling.
5614         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5615         * typeprint.c: Use C++ exception handling.
5616         * tui/tui.c: Use C++ exception handling.
5617         * tracefile-tfile.c: Use C++ exception handling.
5618         * top.c: Use C++ exception handling.
5619         * thread.c: Use C++ exception handling.
5620         * target.c: Use C++ exception handling.
5621         * symmisc.c: Use C++ exception handling.
5622         * symfile-mem.c: Use C++ exception handling.
5623         * stack.c: Use C++ exception handling.
5624         * sparc64-linux-tdep.c: Use C++ exception handling.
5625         * solib.c: Use C++ exception handling.
5626         * solib-svr4.c: Use C++ exception handling.
5627         * solib-spu.c: Use C++ exception handling.
5628         * solib-frv.c: Use C++ exception handling.
5629         * solib-dsbt.c: Use C++ exception handling.
5630         * selftest-arch.c: Use C++ exception handling.
5631         * s390-tdep.c: Use C++ exception handling.
5632         * rust-lang.c: Use C++ exception handling.
5633         * rust-exp.y: Use C++ exception handling.
5634         * rs6000-tdep.c: Use C++ exception handling.
5635         * rs6000-aix-tdep.c: Use C++ exception handling.
5636         * riscv-tdep.c: Use C++ exception handling.
5637         * remote.c: Use C++ exception handling.
5638         * remote-fileio.c: Use C++ exception handling.
5639         * record-full.c: Use C++ exception handling.
5640         * record-btrace.c: Use C++ exception handling.
5641         * python/python.c: Use C++ exception handling.
5642         * python/py-value.c: Use C++ exception handling.
5643         * python/py-utils.c: Use C++ exception handling.
5644         * python/py-unwind.c: Use C++ exception handling.
5645         * python/py-type.c: Use C++ exception handling.
5646         * python/py-symbol.c: Use C++ exception handling.
5647         * python/py-record.c: Use C++ exception handling.
5648         * python/py-record-btrace.c: Use C++ exception handling.
5649         * python/py-progspace.c: Use C++ exception handling.
5650         * python/py-prettyprint.c: Use C++ exception handling.
5651         * python/py-param.c: Use C++ exception handling.
5652         * python/py-objfile.c: Use C++ exception handling.
5653         * python/py-linetable.c: Use C++ exception handling.
5654         * python/py-lazy-string.c: Use C++ exception handling.
5655         * python/py-infthread.c: Use C++ exception handling.
5656         * python/py-inferior.c: Use C++ exception handling.
5657         * python/py-gdb-readline.c: Use C++ exception handling.
5658         * python/py-framefilter.c: Use C++ exception handling.
5659         * python/py-frame.c: Use C++ exception handling.
5660         * python/py-finishbreakpoint.c: Use C++ exception handling.
5661         * python/py-cmd.c: Use C++ exception handling.
5662         * python/py-breakpoint.c: Use C++ exception handling.
5663         * python/py-arch.c: Use C++ exception handling.
5664         * printcmd.c: Use C++ exception handling.
5665         * ppc-linux-tdep.c: Use C++ exception handling.
5666         * parse.c: Use C++ exception handling.
5667         * p-valprint.c: Use C++ exception handling.
5668         * objc-lang.c: Use C++ exception handling.
5669         * mi/mi-main.c: Use C++ exception handling.
5670         * mi/mi-interp.c: Use C++ exception handling.
5671         * mi/mi-cmd-stack.c: Use C++ exception handling.
5672         * mi/mi-cmd-break.c: Use C++ exception handling.
5673         * main.c: Use C++ exception handling.
5674         * linux-thread-db.c: Use C++ exception handling.
5675         * linux-tdep.c: Use C++ exception handling.
5676         * linux-nat.c: Use C++ exception handling.
5677         * linux-fork.c: Use C++ exception handling.
5678         * linespec.c: Use C++ exception handling.
5679         * language.c: Use C++ exception handling.
5680         * jit.c: Use C++ exception handling.
5681         * infrun.c: Use C++ exception handling.
5682         * infcmd.c: Use C++ exception handling.
5683         * infcall.c: Use C++ exception handling.
5684         * inf-loop.c: Use C++ exception handling.
5685         * i386-tdep.c: Use C++ exception handling.
5686         * i386-linux-tdep.c: Use C++ exception handling.
5687         * guile/scm-value.c: Use C++ exception handling.
5688         * guile/scm-type.c: Use C++ exception handling.
5689         * guile/scm-symtab.c: Use C++ exception handling.
5690         * guile/scm-symbol.c: Use C++ exception handling.
5691         * guile/scm-pretty-print.c: Use C++ exception handling.
5692         * guile/scm-ports.c: Use C++ exception handling.
5693         * guile/scm-param.c: Use C++ exception handling.
5694         * guile/scm-math.c: Use C++ exception handling.
5695         * guile/scm-lazy-string.c: Use C++ exception handling.
5696         * guile/scm-frame.c: Use C++ exception handling.
5697         * guile/scm-disasm.c: Use C++ exception handling.
5698         * guile/scm-cmd.c: Use C++ exception handling.
5699         * guile/scm-breakpoint.c: Use C++ exception handling.
5700         * guile/scm-block.c: Use C++ exception handling.
5701         * guile/guile-internal.h: Use C++ exception handling.
5702         * gnu-v3-abi.c: Use C++ exception handling.
5703         * gdbtypes.c: Use C++ exception handling.
5704         * frame.c: Use C++ exception handling.
5705         * frame-unwind.c: Use C++ exception handling.
5706         * fbsd-tdep.c: Use C++ exception handling.
5707         * f-valprint.c: Use C++ exception handling.
5708         * exec.c: Use C++ exception handling.
5709         * event-top.c: Use C++ exception handling.
5710         * event-loop.c: Use C++ exception handling.
5711         * eval.c: Use C++ exception handling.
5712         * dwarf2read.c: Use C++ exception handling.
5713         * dwarf2loc.c: Use C++ exception handling.
5714         * dwarf2-frame.c: Use C++ exception handling.
5715         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5716         * dwarf-index-write.c: Use C++ exception handling.
5717         * dwarf-index-cache.c: Use C++ exception handling.
5718         * dtrace-probe.c: Use C++ exception handling.
5719         * disasm-selftests.c: Use C++ exception handling.
5720         * darwin-nat.c: Use C++ exception handling.
5721         * cp-valprint.c: Use C++ exception handling.
5722         * cp-support.c: Use C++ exception handling.
5723         * cp-abi.c: Use C++ exception handling.
5724         * corelow.c: Use C++ exception handling.
5725         * completer.c: Use C++ exception handling.
5726         * compile/compile-object-run.c: Use C++ exception handling.
5727         * compile/compile-object-load.c: Use C++ exception handling.
5728         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5729         * compile/compile-c-symbols.c: Use C++ exception handling.
5730         * common/selftest.c: Use C++ exception handling.
5731         * common/new-op.c: Use C++ exception handling.
5732         * cli/cli-script.c: Use C++ exception handling.
5733         * cli/cli-interp.c: Use C++ exception handling.
5734         * cli/cli-cmds.c: Use C++ exception handling.
5735         * c-varobj.c: Use C++ exception handling.
5736         * btrace.c: Use C++ exception handling.
5737         * breakpoint.c: Use C++ exception handling.
5738         * break-catch-throw.c: Use C++ exception handling.
5739         * arch-utils.c: Use C++ exception handling.
5740         * amd64-tdep.c: Use C++ exception handling.
5741         * ada-valprint.c: Use C++ exception handling.
5742         * ada-typeprint.c: Use C++ exception handling.
5743         * ada-lang.c: Use C++ exception handling.
5744         * aarch64-tdep.c: Use C++ exception handling.
5745
5746 2019-04-08  Tom Tromey  <tom@tromey.com>
5747
5748         * xml-support.c (gdb_xml_parser::parse): Update.
5749         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5750         * value.c (show_convenience): Update.
5751         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5752         (test_parse_flags_qcs): Update.
5753         * thread.c (thr_try_catch_cmd): Update.
5754         * target.c (target_translate_tls_address): Update.
5755         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5756         (info_frame_command_core, frame_apply_command_count): Update.
5757         * rust-exp.y (rust_lex_exception_test): Update.
5758         * riscv-tdep.c (riscv_print_one_register_info): Update.
5759         * remote.c (remote_target::enable_btrace): Update.
5760         * record-btrace.c (record_btrace_enable_warn): Update.
5761         * python/py-utils.c (gdbpy_convert_exception): Update.
5762         * printcmd.c (do_one_display, print_variable_and_value): Update.
5763         * mi/mi-main.c (mi_print_exception): Update.
5764         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5765         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5766         * linux-nat.c (linux_nat_target::attach): Update.
5767         * linux-fork.c (class scoped_switch_fork_info): Update.
5768         * infrun.c (displaced_step_prepare): Update.
5769         * infcall.c (call_function_by_hand_dummy): Update.
5770         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5771         * gnu-v3-abi.c (print_one_vtable): Update.
5772         * frame.c (get_prev_frame_always): Update.
5773         * f-valprint.c (info_common_command_for_block): Update.
5774         * exec.c (try_open_exec_file): Update.
5775         * exceptions.c (print_exception, exception_print)
5776         (exception_fprintf, exception_print_same): Update.
5777         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5778         * dwarf-index-cache.c (index_cache::store)
5779         (index_cache::lookup_gdb_index): Update.
5780         * darwin-nat.c (maybe_cache_shell): Update.
5781         * cp-valprint.c (cp_print_value_fields): Update.
5782         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5783         (gcc_cplus_symbol_address): Update.
5784         * compile/compile-c-symbols.c (gcc_convert_symbol)
5785         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5786         * common/selftest.c: Update.
5787         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5788         a std::string.
5789         (exception_try_scope_entry, exception_try_scope_exit): Don't
5790         declare.
5791         (struct exception_try_scope): Remove.
5792         (TRY): Don't use exception_try_scope.
5793         (struct gdb_exception): Add constructor, operator=.
5794         <what>: New method.
5795         (struct gdb_exception_RETURN_MASK_ALL)
5796         (struct gdb_exception_RETURN_MASK_ERROR)
5797         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5798         (struct gdb_quit_bad_alloc): Update.
5799         * common/common-exceptions.c (exception_none): Change
5800         initializer.
5801         (struct catcher) <state, exception>: Initialize inline.
5802         <prev>: Remove member.
5803         (current_catcher): Remove.
5804         (catchers): New global.
5805         (exceptions_state_mc_init): Simplify.
5806         (catcher_pop): Remove.
5807         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5808         (try_scope_depth, exception_try_scope_entry)
5809         (exception_try_scope_exit): Remove.
5810         (throw_exception_sjlj): Update.
5811         (exception_messages, exception_messages_size): Remove.
5812         (throw_it): Simplify.
5813         (gdb_exception_sliced_copy): Remove.
5814         (throw_exception_cxx): Update.
5815         * cli/cli-script.c (script_from_file): Update.
5816         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5817         Update.
5818         * ada-valprint.c (ada_val_print): Update.
5819         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5820         (create_excep_cond_exprs): Update.
5821
5822 2019-04-08  Tom Tromey  <tom@tromey.com>
5823
5824         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5825         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5826         (TRY, CATCH, END_CATCH): Remove some definitions.
5827         * common/common-exceptions.c: Don't use GDB_XCPT.
5828         (catcher_list_size): Remove.
5829         (throw_exception, throw_it): Simplify.
5830
5831 2019-04-05  Tom Tromey  <tom@tromey.com>
5832
5833         Revert the header-sorting patch.
5834         * ft32-tdep.c: Revert.
5835         * frv-tdep.c: Revert.
5836         * frv-linux-tdep.c: Revert.
5837         * frame.c: Revert.
5838         * frame-unwind.c: Revert.
5839         * frame-base.c: Revert.
5840         * fork-child.c: Revert.
5841         * findvar.c: Revert.
5842         * findcmd.c: Revert.
5843         * filesystem.c: Revert.
5844         * filename-seen-cache.h: Revert.
5845         * filename-seen-cache.c: Revert.
5846         * fbsd-tdep.c: Revert.
5847         * fbsd-nat.h: Revert.
5848         * fbsd-nat.c: Revert.
5849         * f-valprint.c: Revert.
5850         * f-typeprint.c: Revert.
5851         * f-lang.c: Revert.
5852         * extension.h: Revert.
5853         * extension.c: Revert.
5854         * extension-priv.h: Revert.
5855         * expprint.c: Revert.
5856         * exec.h: Revert.
5857         * exec.c: Revert.
5858         * exceptions.c: Revert.
5859         * event-top.c: Revert.
5860         * event-loop.c: Revert.
5861         * eval.c: Revert.
5862         * elfread.c: Revert.
5863         * dwarf2read.h: Revert.
5864         * dwarf2read.c: Revert.
5865         * dwarf2loc.c: Revert.
5866         * dwarf2expr.h: Revert.
5867         * dwarf2expr.c: Revert.
5868         * dwarf2-frame.c: Revert.
5869         * dwarf2-frame-tailcall.c: Revert.
5870         * dwarf-index-write.h: Revert.
5871         * dwarf-index-write.c: Revert.
5872         * dwarf-index-common.c: Revert.
5873         * dwarf-index-cache.h: Revert.
5874         * dwarf-index-cache.c: Revert.
5875         * dummy-frame.c: Revert.
5876         * dtrace-probe.c: Revert.
5877         * disasm.h: Revert.
5878         * disasm.c: Revert.
5879         * disasm-selftests.c: Revert.
5880         * dictionary.c: Revert.
5881         * dicos-tdep.c: Revert.
5882         * demangle.c: Revert.
5883         * dcache.h: Revert.
5884         * dcache.c: Revert.
5885         * darwin-nat.h: Revert.
5886         * darwin-nat.c: Revert.
5887         * darwin-nat-info.c: Revert.
5888         * d-valprint.c: Revert.
5889         * d-namespace.c: Revert.
5890         * d-lang.c: Revert.
5891         * ctf.c: Revert.
5892         * csky-tdep.c: Revert.
5893         * csky-linux-tdep.c: Revert.
5894         * cris-tdep.c: Revert.
5895         * cris-linux-tdep.c: Revert.
5896         * cp-valprint.c: Revert.
5897         * cp-support.c: Revert.
5898         * cp-namespace.c: Revert.
5899         * cp-abi.c: Revert.
5900         * corelow.c: Revert.
5901         * corefile.c: Revert.
5902         * continuations.c: Revert.
5903         * completer.h: Revert.
5904         * completer.c: Revert.
5905         * complaints.c: Revert.
5906         * coffread.c: Revert.
5907         * coff-pe-read.c: Revert.
5908         * cli-out.h: Revert.
5909         * cli-out.c: Revert.
5910         * charset.c: Revert.
5911         * c-varobj.c: Revert.
5912         * c-valprint.c: Revert.
5913         * c-typeprint.c: Revert.
5914         * c-lang.c: Revert.
5915         * buildsym.c: Revert.
5916         * buildsym-legacy.c: Revert.
5917         * build-id.h: Revert.
5918         * build-id.c: Revert.
5919         * btrace.c: Revert.
5920         * bsd-uthread.c: Revert.
5921         * breakpoint.h: Revert.
5922         * breakpoint.c: Revert.
5923         * break-catch-throw.c: Revert.
5924         * break-catch-syscall.c: Revert.
5925         * break-catch-sig.c: Revert.
5926         * blockframe.c: Revert.
5927         * block.c: Revert.
5928         * bfin-tdep.c: Revert.
5929         * bfin-linux-tdep.c: Revert.
5930         * bfd-target.c: Revert.
5931         * bcache.c: Revert.
5932         * ax-general.c: Revert.
5933         * ax-gdb.h: Revert.
5934         * ax-gdb.c: Revert.
5935         * avr-tdep.c: Revert.
5936         * auxv.c: Revert.
5937         * auto-load.c: Revert.
5938         * arm-wince-tdep.c: Revert.
5939         * arm-tdep.c: Revert.
5940         * arm-symbian-tdep.c: Revert.
5941         * arm-pikeos-tdep.c: Revert.
5942         * arm-obsd-tdep.c: Revert.
5943         * arm-nbsd-tdep.c: Revert.
5944         * arm-nbsd-nat.c: Revert.
5945         * arm-linux-tdep.c: Revert.
5946         * arm-linux-nat.c: Revert.
5947         * arm-fbsd-tdep.c: Revert.
5948         * arm-fbsd-nat.c: Revert.
5949         * arm-bsd-tdep.c: Revert.
5950         * arch-utils.c: Revert.
5951         * arc-tdep.c: Revert.
5952         * arc-newlib-tdep.c: Revert.
5953         * annotate.h: Revert.
5954         * annotate.c: Revert.
5955         * amd64-windows-tdep.c: Revert.
5956         * amd64-windows-nat.c: Revert.
5957         * amd64-tdep.c: Revert.
5958         * amd64-sol2-tdep.c: Revert.
5959         * amd64-obsd-tdep.c: Revert.
5960         * amd64-obsd-nat.c: Revert.
5961         * amd64-nbsd-tdep.c: Revert.
5962         * amd64-nbsd-nat.c: Revert.
5963         * amd64-nat.c: Revert.
5964         * amd64-linux-tdep.c: Revert.
5965         * amd64-linux-nat.c: Revert.
5966         * amd64-fbsd-tdep.c: Revert.
5967         * amd64-fbsd-nat.c: Revert.
5968         * amd64-dicos-tdep.c: Revert.
5969         * amd64-darwin-tdep.c: Revert.
5970         * amd64-bsd-nat.c: Revert.
5971         * alpha-tdep.c: Revert.
5972         * alpha-obsd-tdep.c: Revert.
5973         * alpha-nbsd-tdep.c: Revert.
5974         * alpha-mdebug-tdep.c: Revert.
5975         * alpha-linux-tdep.c: Revert.
5976         * alpha-linux-nat.c: Revert.
5977         * alpha-bsd-tdep.c: Revert.
5978         * alpha-bsd-nat.c: Revert.
5979         * aix-thread.c: Revert.
5980         * agent.c: Revert.
5981         * addrmap.c: Revert.
5982         * ada-varobj.c: Revert.
5983         * ada-valprint.c: Revert.
5984         * ada-typeprint.c: Revert.
5985         * ada-tasks.c: Revert.
5986         * ada-lang.c: Revert.
5987         * aarch64-tdep.c: Revert.
5988         * aarch64-ravenscar-thread.c: Revert.
5989         * aarch64-newlib-tdep.c: Revert.
5990         * aarch64-linux-tdep.c: Revert.
5991         * aarch64-linux-nat.c: Revert.
5992         * aarch64-fbsd-tdep.c: Revert.
5993         * aarch64-fbsd-nat.c: Revert.
5994         * aarch32-linux-nat.c: Revert.
5995
5996 2019-04-05  Tom Tromey  <tom@tromey.com>
5997
5998         * ft32-tdep.c: Sort headers.
5999         * frv-tdep.c: Sort headers.
6000         * frv-linux-tdep.c: Sort headers.
6001         * frame.c: Sort headers.
6002         * frame-unwind.c: Sort headers.
6003         * frame-base.c: Sort headers.
6004         * fork-child.c: Sort headers.
6005         * findvar.c: Sort headers.
6006         * findcmd.c: Sort headers.
6007         * filesystem.c: Sort headers.
6008         * filename-seen-cache.h: Sort headers.
6009         * filename-seen-cache.c: Sort headers.
6010         * fbsd-tdep.c: Sort headers.
6011         * fbsd-nat.h: Sort headers.
6012         * fbsd-nat.c: Sort headers.
6013         * f-valprint.c: Sort headers.
6014         * f-typeprint.c: Sort headers.
6015         * f-lang.c: Sort headers.
6016         * extension.h: Sort headers.
6017         * extension.c: Sort headers.
6018         * extension-priv.h: Sort headers.
6019         * expprint.c: Sort headers.
6020         * exec.h: Sort headers.
6021         * exec.c: Sort headers.
6022         * exceptions.c: Sort headers.
6023         * event-top.c: Sort headers.
6024         * event-loop.c: Sort headers.
6025         * eval.c: Sort headers.
6026         * elfread.c: Sort headers.
6027         * dwarf2read.h: Sort headers.
6028         * dwarf2read.c: Sort headers.
6029         * dwarf2loc.c: Sort headers.
6030         * dwarf2expr.h: Sort headers.
6031         * dwarf2expr.c: Sort headers.
6032         * dwarf2-frame.c: Sort headers.
6033         * dwarf2-frame-tailcall.c: Sort headers.
6034         * dwarf-index-write.h: Sort headers.
6035         * dwarf-index-write.c: Sort headers.
6036         * dwarf-index-common.c: Sort headers.
6037         * dwarf-index-cache.h: Sort headers.
6038         * dwarf-index-cache.c: Sort headers.
6039         * dummy-frame.c: Sort headers.
6040         * dtrace-probe.c: Sort headers.
6041         * disasm.h: Sort headers.
6042         * disasm.c: Sort headers.
6043         * disasm-selftests.c: Sort headers.
6044         * dictionary.c: Sort headers.
6045         * dicos-tdep.c: Sort headers.
6046         * demangle.c: Sort headers.
6047         * dcache.h: Sort headers.
6048         * dcache.c: Sort headers.
6049         * darwin-nat.h: Sort headers.
6050         * darwin-nat.c: Sort headers.
6051         * darwin-nat-info.c: Sort headers.
6052         * d-valprint.c: Sort headers.
6053         * d-namespace.c: Sort headers.
6054         * d-lang.c: Sort headers.
6055         * ctf.c: Sort headers.
6056         * csky-tdep.c: Sort headers.
6057         * csky-linux-tdep.c: Sort headers.
6058         * cris-tdep.c: Sort headers.
6059         * cris-linux-tdep.c: Sort headers.
6060         * cp-valprint.c: Sort headers.
6061         * cp-support.c: Sort headers.
6062         * cp-namespace.c: Sort headers.
6063         * cp-abi.c: Sort headers.
6064         * corelow.c: Sort headers.
6065         * corefile.c: Sort headers.
6066         * continuations.c: Sort headers.
6067         * completer.h: Sort headers.
6068         * completer.c: Sort headers.
6069         * complaints.c: Sort headers.
6070         * coffread.c: Sort headers.
6071         * coff-pe-read.c: Sort headers.
6072         * cli-out.h: Sort headers.
6073         * cli-out.c: Sort headers.
6074         * charset.c: Sort headers.
6075         * c-varobj.c: Sort headers.
6076         * c-valprint.c: Sort headers.
6077         * c-typeprint.c: Sort headers.
6078         * c-lang.c: Sort headers.
6079         * buildsym.c: Sort headers.
6080         * buildsym-legacy.c: Sort headers.
6081         * build-id.h: Sort headers.
6082         * build-id.c: Sort headers.
6083         * btrace.c: Sort headers.
6084         * bsd-uthread.c: Sort headers.
6085         * breakpoint.h: Sort headers.
6086         * breakpoint.c: Sort headers.
6087         * break-catch-throw.c: Sort headers.
6088         * break-catch-syscall.c: Sort headers.
6089         * break-catch-sig.c: Sort headers.
6090         * blockframe.c: Sort headers.
6091         * block.c: Sort headers.
6092         * bfin-tdep.c: Sort headers.
6093         * bfin-linux-tdep.c: Sort headers.
6094         * bfd-target.c: Sort headers.
6095         * bcache.c: Sort headers.
6096         * ax-general.c: Sort headers.
6097         * ax-gdb.h: Sort headers.
6098         * ax-gdb.c: Sort headers.
6099         * avr-tdep.c: Sort headers.
6100         * auxv.c: Sort headers.
6101         * auto-load.c: Sort headers.
6102         * arm-wince-tdep.c: Sort headers.
6103         * arm-tdep.c: Sort headers.
6104         * arm-symbian-tdep.c: Sort headers.
6105         * arm-pikeos-tdep.c: Sort headers.
6106         * arm-obsd-tdep.c: Sort headers.
6107         * arm-nbsd-tdep.c: Sort headers.
6108         * arm-nbsd-nat.c: Sort headers.
6109         * arm-linux-tdep.c: Sort headers.
6110         * arm-linux-nat.c: Sort headers.
6111         * arm-fbsd-tdep.c: Sort headers.
6112         * arm-fbsd-nat.c: Sort headers.
6113         * arm-bsd-tdep.c: Sort headers.
6114         * arch-utils.c: Sort headers.
6115         * arc-tdep.c: Sort headers.
6116         * arc-newlib-tdep.c: Sort headers.
6117         * annotate.h: Sort headers.
6118         * annotate.c: Sort headers.
6119         * amd64-windows-tdep.c: Sort headers.
6120         * amd64-windows-nat.c: Sort headers.
6121         * amd64-tdep.c: Sort headers.
6122         * amd64-sol2-tdep.c: Sort headers.
6123         * amd64-obsd-tdep.c: Sort headers.
6124         * amd64-obsd-nat.c: Sort headers.
6125         * amd64-nbsd-tdep.c: Sort headers.
6126         * amd64-nbsd-nat.c: Sort headers.
6127         * amd64-nat.c: Sort headers.
6128         * amd64-linux-tdep.c: Sort headers.
6129         * amd64-linux-nat.c: Sort headers.
6130         * amd64-fbsd-tdep.c: Sort headers.
6131         * amd64-fbsd-nat.c: Sort headers.
6132         * amd64-dicos-tdep.c: Sort headers.
6133         * amd64-darwin-tdep.c: Sort headers.
6134         * amd64-bsd-nat.c: Sort headers.
6135         * alpha-tdep.c: Sort headers.
6136         * alpha-obsd-tdep.c: Sort headers.
6137         * alpha-nbsd-tdep.c: Sort headers.
6138         * alpha-mdebug-tdep.c: Sort headers.
6139         * alpha-linux-tdep.c: Sort headers.
6140         * alpha-linux-nat.c: Sort headers.
6141         * alpha-bsd-tdep.c: Sort headers.
6142         * alpha-bsd-nat.c: Sort headers.
6143         * aix-thread.c: Sort headers.
6144         * agent.c: Sort headers.
6145         * addrmap.c: Sort headers.
6146         * ada-varobj.c: Sort headers.
6147         * ada-valprint.c: Sort headers.
6148         * ada-typeprint.c: Sort headers.
6149         * ada-tasks.c: Sort headers.
6150         * ada-lang.c: Sort headers.
6151         * aarch64-tdep.c: Sort headers.
6152         * aarch64-ravenscar-thread.c: Sort headers.
6153         * aarch64-newlib-tdep.c: Sort headers.
6154         * aarch64-linux-tdep.c: Sort headers.
6155         * aarch64-linux-nat.c: Sort headers.
6156         * aarch64-fbsd-tdep.c: Sort headers.
6157         * aarch64-fbsd-nat.c: Sort headers.
6158         * aarch32-linux-nat.c: Sort headers.
6159
6160 2019-04-04  Tom Tromey  <tom@tromey.com>
6161
6162         * varobj.c (varobj_create): Update.
6163         * rust-exp.y (struct rust_parser) <update_innermost_block,
6164         lookup_symbol>: New methods.
6165         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6166         Rename.
6167         (rust_parser::rust_lookup_type)
6168         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6169         * printcmd.c (display_command, do_one_display): Update.
6170         * parser-defs.h (struct parser_state) <parser_state>: Add
6171         "tracker" parameter.
6172         (block_tracker): New member.
6173         (class innermost_block_tracker) <innermost_block_tracker>: Add
6174         "types" parameter.
6175         <reset>: Remove method.
6176         (innermost_block): Don't declare.
6177         (null_post_parser): Update.
6178         * parse.c (innermost_block): Remove global.
6179         (write_dollar_variable): Update.
6180         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6181         Remove "tracker_types" parameter.
6182         (parse_expression): Add "tracker" parameter.
6183         (parse_expression_for_completion): Update.
6184         (null_post_parser): Add "tracker" parameter.
6185         * p-exp.y: Update rules.
6186         * m2-exp.y: Update rules.
6187         * language.h (struct language_defn) <la_post_parser>: Add
6188         "tracker" parameter.
6189         * go-exp.y: Update rules.
6190         * f-exp.y: Update rules.
6191         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6192         parameter.
6193         * d-exp.y: Update rules.
6194         * c-exp.y: Update rules.
6195         * breakpoint.c (set_breakpoint_condition): Create an
6196         innermost_block_tracker.
6197         (watch_command_1): Likewise.
6198         * ada-lang.c (resolve): Add "tracker" parameter.
6199         (resolve_subexp): Likewise.
6200         * ada-exp.y (write_var_from_sym): Update.
6201
6202 2019-04-04  Tom Tromey  <tom@tromey.com>
6203
6204         * type-stack.h: New file.
6205         * type-stack.c: New file.
6206         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6207         type-stack.h.
6208         (insert_into_type_stack, insert_type, push_type, push_type_int)
6209         (insert_type_address_space, pop_type, pop_type_int)
6210         (pop_typelist, pop_type_stack, append_type_stack)
6211         (push_type_stack, get_type_stack, push_typelist)
6212         (follow_type_instance_flags, follow_types): Don't declare.
6213         * parse.c (type_stack): Remove global.
6214         (parse_exp_in_context): Update.
6215         (insert_into_type_stack, insert_type, push_type, push_type_int)
6216         (insert_type_address_space, pop_type, pop_type_int)
6217         (pop_typelist, pop_type_stack, append_type_stack)
6218         (push_type_stack, get_type_stack, push_typelist)
6219         (follow_type_instance_flags, follow_types): Remove (moved to
6220         type-stack.c).
6221         * f-exp.y (type_stack): New global.
6222         Update rules.
6223         (push_kind_type, f_parse): Update.
6224         * d-exp.y (type_stack): New global.
6225         Update rules.
6226         (d_parse): Update.
6227         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6228         Update rules.
6229         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6230         (HFILES_NO_SRCDIR): Add type-stack.h.
6231
6232 2019-04-04  Tom Tromey  <tom@tromey.com>
6233
6234         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6235         (rust_parser::convert_ast_to_expression, rust_parse)
6236         (rust_lex_test_completion, rust_lex_tests): Update.
6237         * parser-defs.h (struct expr_completion_state): New.
6238         (struct parser_state) <parser_state>: Add completion parameter.
6239         <mark_struct_expression, mark_completion_tag>: New methods.
6240         <parse_completion, m_completion_state>: New members.
6241         (prefixify_expression, null_post_parser): Update.
6242         (mark_struct_expression, mark_completion_tag): Don't declare.
6243         * parse.c (parse_completion, expout_last_struct)
6244         (expout_tag_completion_type, expout_completion_name): Remove
6245         globals.
6246         (parser_state::mark_struct_expression)
6247         (parser_state::mark_completion_tag): Now methods.
6248         (prefixify_expression): Add last_struct parameter.
6249         (prefixify_subexp): Likewise.
6250         (parse_exp_1): Update.
6251         (parse_exp_in_context): Add cstate parameter.  Update.
6252         (parse_expression_for_completion): Create an
6253         expr_completion_state.
6254         (null_post_parser): Add "completion" parameter.
6255         * p-exp.y: Update rules.
6256         (yylex): Update.
6257         * language.h (struct language_defn) <la_post_parser>: Add
6258         "completing" parameter.
6259         * go-exp.y: Update rules.
6260         (lex_one_token): Update.
6261         * expression.h (parse_completion): Don't declare.
6262         * d-exp.y: Update rules.
6263         (lex_one_token): Update rules.
6264         * c-exp.y: Update rules.
6265         (lex_one_token): Update.
6266         * ada-lang.c (resolve): Add "parse_completion" parameter.
6267         (resolve_subexp): Likewise.
6268         (ada_resolve_function): Likewise.
6269
6270 2019-04-04  Tom Tromey  <tom@tromey.com>
6271
6272         * parser-defs.h (struct parser_state) <start_arglist,
6273         end_arglist>: New methods.
6274         <arglist_len, m_funcall_chain>: New members.
6275         (arglist_len, start_arglist, end_arglist): Don't declare.
6276         * parse.c (arglist_len, funcall_chain): Remove global.
6277         (start_arglist, end_arglist): Remove functions.
6278         (parse_exp_in_context): Update.
6279         * p-exp.y: Update rules.
6280         * m2-exp.y: Update rules.
6281         * go-exp.y: Update rules.
6282         * f-exp.y: Update rules.
6283         * d-exp.y: Update rules.
6284         * c-exp.y: Update rules.
6285
6286 2019-04-04  Tom Tromey  <tom@tromey.com>
6287
6288         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6289         lex_operator, push_back>: New methods.
6290         Update all rules.
6291         (rust_parser::lex_hex, lex_escape): Rename and update.
6292         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6293         (rust_parser::lex_operator): Rename and update.
6294         (rust_parser::lex_number, rustyylex, rustyyerror)
6295         (rust_lex_test_init, rust_lex_test_sequence)
6296         (rust_lex_test_push_back, rust_lex_tests): Update.
6297         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6298         parameter.
6299         <lexptr, prev_lexptr>: New members.
6300         (lexptr, prev_lexptr): Don't declare.
6301         * parse.c (lexptr, prev_lexptr): Remove globals.
6302         (parse_exp_in_context): Update.
6303         * p-exp.y (yylex, yyerror): Update.
6304         * m2-exp.y (parse_number, yylex, yyerror): Update.
6305         * go-exp.y (lex_one_token, yyerror): Update.
6306         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6307         * d-exp.y (lex_one_token, yyerror): Update.
6308         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6309         (lex_one_token, yyerror): Update.
6310         * ada-lex.l (YY_INPUT): Update.
6311         (rewind_to_char): Update.
6312         * ada-exp.y (yyerror): Update.
6313
6314 2019-04-04  Tom Tromey  <tom@tromey.com>
6315
6316         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6317         * parser-defs.h (struct parser_state) <parser_state>: Add new
6318         parameter.
6319         <comma_terminates>: New member.
6320         (comma_terminates): Don't declare global.
6321         * parse.c (comma_terminates): Remove global.
6322         (parse_exp_in_context): Update.
6323         * p-exp.y (yylex): Update.
6324         * m2-exp.y (yylex): Update.
6325         * go-exp.y (lex_one_token): Update.
6326         * f-exp.y (yylex): Update.
6327         * d-exp.y (lex_one_token): Update.
6328         * c-exp.y (lex_one_token): Update.
6329         * ada-lex.l: Update.
6330
6331 2019-04-04  Tom Tromey  <tom@tromey.com>
6332
6333         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6334         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6335         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6336         * parser-defs.h (paren_depth): Don't declare.
6337         * parse.c (paren_depth): Remove global.
6338         (parse_exp_in_context): Update.
6339         * p-exp.y (paren_depth): New global.
6340         (pascal_parse): Initialize it.
6341         * m2-exp.y (paren_depth): New global.
6342         (m2_parse): Initialize it.
6343         * go-exp.y (paren_depth): New global.
6344         (go_parse): Initialize it.
6345         * f-exp.y (paren_depth): New global.
6346         (f_parse): Initialize it.
6347         * d-exp.y (paren_depth): New global.
6348         (d_parse): Initialize it.
6349         * c-exp.y (paren_depth): New global.
6350         (c_parse): Initialize it.
6351         * ada-lex.l (paren_depth): New global.
6352         (lexer_init): Initialize it.
6353
6354 2019-04-04  Tom Tromey  <tom@tromey.com>
6355
6356         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6357         (rust_parser::convert_ast_to_type)
6358         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6359         * parser-defs.h (struct parser_state) <parser_state>: Add
6360         parameters.  Initialize new members.
6361         <expression_context_block, expression_context_pc>: New members.
6362         * parse.c (expression_context_block, expression_context_pc):
6363         Remove globals.
6364         (parse_exp_in_context): Update.
6365         * p-exp.y: Update all rules.
6366         (yylex): Update.
6367         * m2-exp.y: Update all rules.
6368         (yylex): Update.
6369         * go-exp.y (yylex): Update.
6370         * f-exp.y (yylex): Update.
6371         * d-exp.y: Update all rules.
6372         (yylex): Update.
6373         * c-exp.y: Update all rules.
6374         (lex_one_token, classify_name, yylex, c_parse): Update.
6375         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6376
6377 2019-04-04  Tom Tromey  <tom@tromey.com>
6378
6379         * gdbarch.h, gdbarch.c: Rebuild.
6380         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6381         * stap-probe.h:
6382         (struct stap_parse_info): Replace "parser_state" with
6383         "expr_builder".
6384         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6385         (parser_state): New class.
6386         * parse.c (expr_builder): Rename.
6387         (expr_builder::release): Rename.
6388         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6389         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6390         (write_exp_elt_longcst, write_exp_elt_floatcst)
6391         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6392         (write_exp_string_vector, write_exp_bitstring)
6393         (write_exp_msymbol, mark_struct_expression)
6394         (write_dollar_variable)
6395         (insert_type_address_space, increase_expout_size): Replace
6396         "parser_state" with "expr_builder".
6397         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6398         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6399         "parser_state" with "expr_builder".
6400
6401 2019-04-04  Tom Tromey  <tom@tromey.com>
6402
6403         * rust-exp.y: Replace "parse_language" with method call.
6404         * p-exp.y:
6405         (yylex): Replace "parse_language" with method call.
6406         * m2-exp.y:
6407         (yylex): Replace "parse_language" with method call.
6408         * go-exp.y (classify_name): Replace "parse_language" with method
6409         call.
6410         * f-exp.y (yylex): Replace "parse_language" with method call.
6411         * d-exp.y (lex_one_token): Replace "parse_language" with method
6412         call.
6413         * c-exp.y:
6414         (lex_one_token, classify_name, yylex): Replace "parse_language"
6415         with method call.
6416         * ada-exp.y (find_primitive_type, type_char)
6417         (type_system_address): Replace "parse_language" with method call.
6418
6419 2019-04-04  Tom Tromey  <tom@tromey.com>
6420
6421         * rust-exp.y: Replace "parse_gdbarch" with method call.
6422         * parse.c (write_dollar_variable, insert_type_address_space):
6423         Replace "parse_gdbarch" with method call.
6424         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6425         call.
6426         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6427         call.
6428         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6429         "parse_gdbarch" with method call.
6430         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6431         with method call.
6432         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6433         "parse_gdbarch" with method call.
6434         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6435         "parse_gdbarch" with method call.
6436         * c-exp.y (parse_type, parse_number, classify_name): Replace
6437         "parse_gdbarch" with method call.
6438         * ada-lex.l: Replace "parse_gdbarch" with method call.
6439         * ada-exp.y (parse_type, find_primitive_type, type_char)
6440         (type_system_address): Replace "parse_gdbarch" with method call.
6441
6442 2019-04-04  Tom Tromey  <tom@tromey.com>
6443
6444         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6445         * stap-probe.c (stap_parse_argument): Update.
6446         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6447         initial_size parameter.
6448         * rust-exp.y (rust_lex_tests): Update.
6449         * parse.c (parser_state): Update.
6450         (parse_exp_in_context): Update.
6451         * parser-defs.h (struct parser_state) <parser_state>: Remove
6452         "initial_size" parameter.
6453
6454 2019-04-04  Tom Tromey  <tom@tromey.com>
6455
6456         * parser-defs.h (increase_expout_size): Don't declare.
6457         * parse.c (increase_expout_size): Now static.
6458
6459 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6460
6461         * gnu-nat.c (gnu_nat_target::wait): Fix
6462         target_waitstatus_to_string call.
6463
6464 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6465
6466         * eval.c (evaluate_subexp_standard): Handle internal functions
6467         during Fortran function call handling.
6468
6469 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6470
6471         * NEWS: Mention new internal functions.
6472         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6473         (read_base_type): Use dwarf2_init_complex_target_type.
6474         * value.c (creal_internal_fn): New function.
6475         (cimag_internal_fn): New function.
6476         (_initialize_values): Register new internal functions.
6477
6478 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6479
6480         * infrun.c (stop_all_threads): If debug_infrun, always
6481         trace the wait status after wait_one, using
6482         target_waitstatus_to_string and target_pid_to_str.
6483         (handle_inferior_event): Replace various trace of
6484         wait status kind by a single trace.
6485         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6486         wait status kind image by target_waitstatus_to_string.
6487         * target/waitstatus.c (target_waitstatus_to_string): Fix
6488         obsolete comment.
6489
6490 2019-04-01  Tom Tromey  <tromey@adacore.com>
6491
6492         PR symtab/23331:
6493         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6494
6495 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6496             Pedro Alves  <palves@redhat.com>
6497
6498         * top.c (quit_force): Call 'finalize_values'.
6499         * value.c (finalize_values): New function.
6500         * value.h (finalize_values): Declare.
6501
6502 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6503
6504         * NEWS: Announce $_gdb_major and $_gdb_minor.
6505
6506         * top.c (init_gdb_version_vars): New function.
6507         (gdb_init): Call init_gdb_version_vars.
6508
6509 2019-03-29  Tom Tromey  <tromey@adacore.com>
6510
6511         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6512         help text.  Remove dead code.
6513
6514 2019-03-29  Keith Seitz  <keiths@redhat.com>
6515
6516         From Siddhesh Poyarekar:
6517         * f-lang.h (f77_get_upperbound): Return LONGEST.
6518         (f77_get_lowerbound): Likewise.
6519         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6520         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6521         print them.
6522         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6523         plongest to format print it.
6524         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6525         (f77_get_upperbound): Likewise.
6526         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6527         LOWER_BOUND to LONGEST.
6528         (f77_create_arrayprint_offset_tbl): Likewise.
6529
6530 2019-03-29  Keith Seitz  <keiths@redhat.com>
6531
6532         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6533         %s/pulongest for TYPE_LENGTH instead of %d in format
6534         strings.
6535         * ada-typerint.c (ada_print_type): Likewise.
6536         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6537         * compile/compile-c-support.c (generate_register_struct): Likewise.
6538         * gdbtypes.c (recursive_dump_type): Likewise.
6539         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6540         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6541         instead of %d in format strings.
6542         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6543         to std::min to ULONGEST.
6544         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6545         instead of %d in format strings.
6546         * tracepoint.c (info_scope_command): Likewise.
6547         * typeprint.c (print_offset_data::update)
6548         (print_offset_data::finish): Likewise.
6549         * xtensa-tdep.c (xtensa_store_return_value)
6550         (xtensa_push_dummy_call): Likewise.
6551
6552 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6553
6554         * windows-nat.c (display_selector): Fixed format specifications
6555         for 64-bit Cygwin.
6556
6557 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6558
6559         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6560
6561 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6562
6563         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6564         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6565         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6566         (nios2_linux_init_abi): Install it.
6567
6568 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6569
6570         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6571
6572 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6573
6574         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6575
6576 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6577             Tom Tromey  <tromey@adacore.com>
6578
6579         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6580
6581 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6582
6583         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6584         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6585         method to compute the bounds of range types. Also print "[evaluated]"
6586         if the bounds' values come from a dynamic evaluation.
6587
6588 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6589
6590         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6591         whitespace when pretty printing is on.
6592
6593 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6594
6595         * ppc-linux-nat.c: Add include.
6596
6597 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6598
6599         * NEWS: Mention AArch64 Pointer Authentication.
6600
6601 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6602
6603         * arm-linux-nat.c: Add include.
6604
6605 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6606
6607         * source-cache.c (source_cache::get_source_lines): Re-read
6608         fullname after calling open_source_file.
6609
6610 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6611
6612         * NEWS: Mention TLS support for FreeBSD.
6613
6614 2019-03-25  Tom Tromey  <tromey@adacore.com>
6615
6616         * minsyms.c (BUNCH_SIZE): Update comment.
6617         (~minimal_symbol_reader): Remove old comment.
6618         (compact_minimal_symbols): Update comment.
6619         (minimal_symbol_reader::install): Remove old comment.  Update
6620         other comments.
6621
6622 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6623
6624         * s390-linux-nat.c: Add include.
6625
6626 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6627
6628         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6629         Call linux_get_hwcap.
6630         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6631         Likewise.
6632         (aarch64_linux_get_hwcap): Remove function.
6633         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6634         declaration.
6635         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6636         linux_get_hwcap.
6637         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6638         * linux-tdep.c (linux_get_hwcap): Add function.
6639         (linux_get_hwcap2): Likewise.
6640         * linux-tdep.h (linux_get_hwcap): Add declaration.
6641         (linux_get_hwcap2): Likewise.
6642         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6643         (ppc_linux_get_hwcap2): Likewise.
6644         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6645         linux_get_hwcap.
6646         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6647         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6648         (ppc_linux_nat_target::read_description): Likewise.
6649         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6650         * s390-linux-nat.c: Likewise.
6651         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6652
6653 2019-03-24  Tom Tromey  <tom@tromey.com>
6654
6655         * ada-lang.c (standard_lookup): Simplify initialization.
6656         (ada_lookup_symbol_nonlocal): Simplify return.
6657         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6658         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6659         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6660         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6661         initialization.
6662         * solib.c (solib_global_lookup): Simplify.
6663         * symtab.c (null_block_symbol): Remove.
6664         (symbol_cache_lookup): Simplify returns.
6665         (lookup_language_this): Simplify returns.
6666         (lookup_symbol_aux): Simplify return.
6667         (lookup_local_symbol): Simplify returns.
6668         (lookup_global_symbol_from_objfile): Simplify return.
6669         (lookup_symbol_in_objfile_symtabs)
6670         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6671         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6672         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6673         * cp-namespace.c (cp_lookup_bare_symbol)
6674         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6675         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6676         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6677         (cp_lookup_symbol_via_imports): Simplify initialization.
6678         (find_symbol_in_baseclass): Likewise.
6679         * symtab.h (null_block_symbol): Remove.
6680         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6681         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6682         (d_lookup_symbol_module): Likewise.
6683         (find_symbol_in_baseclass): Simplify initialization.
6684
6685 2019-03-24  Tom Tromey  <tom@tromey.com>
6686
6687         * expression.h: Don't include symtab.h.
6688         (struct block): Forward declare.
6689
6690 2019-03-24  Tom Tromey  <tom@tromey.com>
6691
6692         * c-exp.y (typebase): Remove casts.
6693         * gdbtypes.c (lookup_unsigned_typename, )
6694         (lookup_signed_typename): Remove cast.
6695         * eval.c (parse_to_comma_and_eval): Remove cast.
6696         * parse.c (write_dollar_variable): Remove cast.
6697         * block.h (struct block) <superblock>: Now const.
6698         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6699         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6700         (map_block): Make "block" const.
6701         * symfile.h (struct quick_symbol_functions)
6702         <map_matching_symbols>: Constify block argument to "callback".
6703         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6704         const.
6705         (find_pc_sect_compunit_symtab): Make "b" const.
6706         (find_symbol_at_address): Likewise.
6707         (search_symbols): Likewise.
6708         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6709         (dw2_debug_names_lookup_symbol): Likewise.
6710         (dw2_map_matching_symbols): Update.
6711         * p-valprint.c (pascal_val_print): Remove "block".
6712         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6713         (aux_add_nonlocal_symbols): Make "block" const.
6714         (resolve_subexp): Remove cast.
6715         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6716         const.
6717         (iterate_over_file_blocks): Likewise.
6718         * f-exp.y (%union) <bval>: Remove.
6719         * coffread.c (patch_opaque_types): Make "b" const.
6720         * spu-tdep.c (spu_catch_start): Make "block" const.
6721         * c-valprint.c (print_unpacked_pointer): Remove "block".
6722         * symmisc.c (dump_symtab_1): Make "b" const.
6723         (block_depth): Make "block" const.
6724         * d-exp.y (%union) <bval>: Remove.
6725         * cp-support.h (cp_lookup_rtti_type): Update.
6726         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6727         * psymtab.c (psym_lookup_symbol): Make "block" const.
6728         (maintenance_check_psymtabs): Make "b" const.
6729         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6730         (enumerate_locals, enumerate_args): Update.
6731         * python/py-symtab.c (stpy_global_block): Make "block" const.
6732         (stpy_static_block): Likewise.
6733         * inline-frame.c (block_starting_point_at): Make "new_block"
6734         const.
6735         * block.c (find_block_in_blockvector): Make return type const.
6736         (blockvector_for_pc_sect): Make "b" const.
6737         (find_block_in_blockvector): Make "b" const.
6738
6739 2019-03-23  Tom Tromey  <tom@tromey.com>
6740
6741         * varobj.c (varobj_create): Update.
6742         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6743         * printcmd.c (display_command, do_one_display): Don't reset
6744         innermost_block.
6745         * parser-defs.h (enum innermost_block_tracker_type): Move to
6746         expression.h.
6747         (innermost_block): Update comment.
6748         * parse.c (parse_exp_1): Add tracker_types parameter.
6749         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6750         tracker_types parameter.  Reset innermost_block.
6751         (parse_exp_in_context): Remove.
6752         (parse_expression_for_completion): Update.
6753         * objfiles.c (~objfile): Don't reset expression_context_block or
6754         innermost_block.
6755         * expression.h (enum innermost_block_tracker_type): Move from
6756         parser-defs.h.
6757         (parse_exp_1): Add tracker_types parameter.
6758         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6759         reset innermost_block.
6760
6761 2019-03-23  Tom Tromey  <tom@tromey.com>
6762
6763         * objfiles.h: Include bcache.h.
6764
6765 2019-03-23  Tom Tromey  <tom@tromey.com>
6766
6767         * linespec.c (get_current_search_block): Use
6768         scoped_restore_current_language.
6769         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6770
6771 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6772             Jiong Wang  <jiong.wang@arm.com>
6773
6774         * aarch64-linux-tdep.c
6775         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6776         section.
6777         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6778
6779 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6780             Jiong Wang  <jiong.wang@arm.com>
6781
6782         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6783         instructions.
6784         (aarch64_analyze_prologue_test): Add PACIASP test.
6785         (aarch64_prologue_prev_register): Unmask PC value.
6786
6787 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6788             Jiong Wang  <jiong.wang@arm.com>
6789
6790         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6791         (aarch64_dwarf2_prev_register): Unmask PC value.
6792         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6793         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6794         DW_CFA_AARCH64_negate_ra_state.
6795         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6796
6797 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6798             Jiong Wang  <jiong.wang@arm.com>
6799
6800         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6801         registers.
6802         (aarch64_pseudo_register_name): Likewise.
6803         (aarch64_pseudo_register_type): Likewise.
6804         (aarch64_pseudo_register_reggroup_p): Likewise.
6805         (aarch64_gdbarch_init): Add pauth registers.
6806         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6807         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6808         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6809         (struct gdbarch_tdep): Add regnum for ra_state.
6810
6811 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6812             Jiong Wang  <jiong.wang@arm.com>
6813
6814         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6815
6816 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6817             Jiong Wang  <jiong.wang@arm.com>
6818
6819         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6820         function.
6821         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6822         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6823         (aarch64_gdbarch_init): Add puth registers.
6824         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6825         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6826         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6827
6828 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6829             Jiong Wang  <jiong.wang@arm.com>
6830
6831         * aarch64-linux-nat.c
6832         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6833         * aarch64-linux-tdep.c
6834         (aarch64_linux_core_read_description): Likewise.
6835         (aarch64_linux_get_hwcap): New function.
6836         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6837         (aarch64_linux_get_hwcap): New declaration.
6838
6839 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6840             Jiong Wang  <jiong.wang@arm.com>
6841
6842         * aarch64-linux-nat.c
6843         (aarch64_linux_nat_target::read_description): Add pauth param.
6844         * aarch64-linux-tdep.c
6845         (aarch64_linux_core_read_description): Likewise.
6846         * aarch64-tdep.c (struct target_desc): Add in pauth.
6847         (aarch64_read_description): Add pauth param.
6848         (aarch64_gdbarch_init): Likewise.
6849         * aarch64-tdep.h (aarch64_read_description): Likewise.
6850         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6851         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6852         * features/Makefile: Add new files.
6853         * features/aarch64-pauth.c: New file.
6854         * features/aarch64-pauth.xml: New file.
6855
6856 2019-03-20  Tom Tromey  <tromey@adacore.com>
6857
6858         * infrun.c (handle_inferior_event): Rename from
6859         handle_inferior_event_1.  Create a scoped_value_mark.
6860         (handle_inferior_event): Remove.
6861
6862 2019-03-19  Tom Tromey  <tromey@adacore.com>
6863
6864         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6865         * infrun.h (print_stop_event): Add "displays" parameter.
6866         * infrun.c (print_stop_event): Add "displays" parameter.
6867
6868 2019-03-19  Pedro Alves  <palves@redhat.com>
6869
6870         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6871         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6872         to -1.  Fix TABs vs spaces.
6873         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6874         * tui/tui-out.h (tui_ui_out) Add intro comments.
6875         <m_line, m_start_of_line>: In-class initialize, and add describing
6876         comment.
6877
6878 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6879
6880         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6881         variable names.
6882         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6883
6884 2019-03-18  Pedro Alves  <palves@redhat.com>
6885             Eli Zaretskii <eliz@gnu.org>
6886
6887         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6888         m_line and m_start_of_line.
6889
6890 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6891
6892         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6893         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6894         it returns a newline.  This fixes a regression in TU mode, whereby
6895         the next line is output on the same screen line as the user input.
6896
6897 2019-03-18  Tom Tromey  <tromey@adacore.com>
6898
6899         * minsyms.c (minimal_symbol_reader::install): Remove call to
6900         obstack_blank.
6901
6902 2019-03-18  Pedro Alves  <palves@redhat.com>
6903
6904         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6905         New globals.
6906         (apply_style): New, factored out from ...
6907         (apply_ansi_escape): ... this.  Handle reverse video mode.
6908         (tui_set_reverse_mode): New function.
6909         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6910         * tui/tui-winsource.c (tui_show_source_line): Use
6911         tui_set_reverse_mode instead of setting A_STANDOUT.
6912         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6913         New setter methods.
6914
6915 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6916
6917         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6918         Handle tabs.
6919
6920 2019-03-18  Tom Tromey  <tromey@adacore.com>
6921
6922         * ada-lang.c (empty_array): Add "high" parameter.
6923         (ada_evaluate_subexp): Update.
6924
6925 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6926
6927         * unittests/string_view-selftests.c: Define
6928         _initialize_string_view_selftests unconditionally.
6929
6930 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6931
6932         PR gdb/24350
6933         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6934
6935 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6936
6937         PR gdb/24351
6938         * windows-nat.c (display_selector): Fix format specifiers.
6939
6940 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6941
6942         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6943         tui_refill_source_window instead of tui_refresh_win, to update the
6944         current execution line.  This fixes redisplay of the current line
6945         when stepping through the code with "next" or "step".
6946
6947 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6948
6949         * source-cache.c (source_cache::get_source_lines): Call
6950         find_source_lines to initialize s->nlines.  This fixes vertical
6951         scrolling of TUI source window when the DOWN arrow is pressed.
6952
6953 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6954
6955         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6956         linux-thread-db.c (_initialize_thread_db): Likewise.
6957
6958 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6959
6960         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6961         wclrtoeol in tui_show_source_line".  This reverts changes made in
6962         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6963
6964 2019-03-15  Tom Tromey  <tom@tromey.com>
6965
6966         * symtab.h (struct minimal_symbol): Derive from
6967         general_symbol_info.
6968         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6969         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6970         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6971         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6972         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6973         (MSYMBOL_SEARCH_NAME): Update.
6974         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6975         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6976         * minsyms.c (minimal_symbol_reader::record_full): Update.
6977
6978 2019-03-15  Tom Tromey  <tom@tromey.com>
6979
6980         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6981
6982 2019-03-15  Tom Tromey  <tom@tromey.com>
6983
6984         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6985         unique_xmalloc_ptr.
6986         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6987         Update.
6988         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6989         (build_minimal_symbol_hash_tables)
6990         (minimal_symbol_reader::install): Update.
6991
6992 2019-03-15  Tom Tromey  <tom@tromey.com>
6993
6994         * symtab.c (create_demangled_names_hash): Update.
6995         (symbol_set_names): Update.
6996         * objfiles.h (struct objfile_per_bfd_storage)
6997         <demangled_names_hash>: Now an htab_up.
6998         * objfiles.c (objfile_per_bfd_storage): Simplify.
6999
7000 2019-03-15  Tom Tromey  <tom@tromey.com>
7001
7002         * objfiles.h (struct objfile_per_bfd_storage): Declare
7003         destructor.
7004         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7005         New.
7006         (get_objfile_bfd_data): Use new.  Don't initialize
7007         language_of_main.
7008         (free_objfile_per_bfd_storage): Remove.
7009         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7010
7011 2019-03-15  Tom Tromey  <tom@tromey.com>
7012
7013         * symfile.c (reread_symbols): Update.
7014         * objfiles.c (objfile::objfile): Update.
7015         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7016         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7017         comment.
7018         (minimal_symbol_reader::install): Update.
7019         (terminate_minimal_symbol_table): Remove.
7020         * jit.c (jit_object_close_impl): Update.
7021
7022 2019-03-15  Tom Tromey  <tom@tromey.com>
7023
7024         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7025         initializations.
7026
7027 2019-03-15  Tom Tromey  <tom@tromey.com>
7028
7029         * objfiles.h (struct objfile_per_bfd_storage)
7030         <demangled_hash_languages>: Now a bitset.
7031         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7032         (lookup_minimal_symbol): Update.
7033
7034 2019-03-15  Tom Tromey  <tom@tromey.com>
7035
7036         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7037         Don't return the symbol.
7038         * coffread.c (record_minimal_symbol): Use record_full.
7039
7040 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7041
7042         The MS-Windows port of ncurses fails to switch to a color pair if
7043         one or both of the colors are the implicit default colors.  This
7044         change records the default colors when TUI is initialized, and
7045         then specifies them explicitly when a color pair uses the default
7046         colors.  This allows color styling in TUI mode on MS-Windows.
7047
7048         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7049         ncurses_norm_attr.
7050         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7051         colors in ncurses_norm_attr.
7052         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7053         "none", replace it with the default color recorded in
7054         ncurses_norm_attr.
7055
7056 2019-03-14  Tom Tromey  <tromey@adacore.com>
7057
7058         * source-cache.h (class source_cache) <get_source_lines>: Return
7059         std::string.
7060         * source-cache.c (source_cache::extract_lines): Handle case where
7061         first_pos==npos.  Return std::string.
7062         (source_cache::get_source_lines): Update.
7063
7064 2019-03-14  Tom Tromey  <tromey@adacore.com>
7065
7066         * NEWS: Add item for "style sources" commands.
7067         * source-cache.c (source_cache::get_source_lines): Check
7068         source_styling.
7069         * cli/cli-style.c (source_styling): New global.
7070         (_initialize_cli_style): Add "style sources" commands.
7071         (show_style_sources): New function.
7072         * cli/cli-style.h (source_styling): Declare.
7073
7074 2019-03-14  Pedro Alves  <palves@redhat.com>
7075             Tom Tromey  <tromey@adacore.com>
7076
7077         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7078         * tui/tui-winsource.c (tui_refill_source_window): New function,
7079         from...
7080         (tui_horizontal_source_scroll): ... here.  Move some logic.
7081         * cli/cli-style.c (set_style_enabled): Notify new observable.
7082         * tui/tui-hooks.c (tui_redisplay_source): New function.
7083         (tui_attach_detach_observers): Attach or detach
7084         tui_redisplay_source.
7085         * observable.h (source_styling_changed): New observable.
7086         * observable.c: Define source_styling_changed observable.
7087
7088 2019-03-13  Tom Tromey  <tromey@adacore.com>
7089
7090         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7091         (i386_gnu_nat_target::store_registers): Update.
7092         * target-debug.h (target_debug_print_std_string): New macro.
7093         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7094         * windows-tdep.c (display_one_tib): Update.
7095         * tui/tui-stack.c (tui_make_status_line): Update.
7096         * top.c (print_inferior_quit_action): Update.
7097         * thread.c (thr_try_catch_cmd): Update.
7098         (add_thread_with_info): Update.
7099         (thread_target_id_str): Update.
7100         (thr_try_catch_cmd): Update.
7101         (thread_command): Update.
7102         (thread_find_command): Update.
7103         * record-btrace.c (record_btrace_target::info_record)
7104         (record_btrace_resume_thread, record_btrace_target::resume)
7105         (record_btrace_cancel_resume, record_btrace_step_thread)
7106         (record_btrace_target::wait, record_btrace_target::wait)
7107         (record_btrace_target::wait, record_btrace_target::stop): Update.
7108         * progspace.c (print_program_space): Update.
7109         * process-stratum-target.c
7110         (process_stratum_target::thread_address_space): Update.
7111         * linux-fork.c (linux_fork_mourn_inferior)
7112         (detach_checkpoint_command, info_checkpoints_command)
7113         (linux_fork_context): Update.
7114         (linux_fork_detach): Update.
7115         (class scoped_switch_fork_info): Update.
7116         (delete_checkpoint_command): Update.
7117         * infrun.c (follow_fork_inferior): Update.
7118         (follow_fork_inferior): Update.
7119         (proceed_after_vfork_done): Update.
7120         (handle_vfork_child_exec_or_exit): Update.
7121         (follow_exec): Update.
7122         (displaced_step_prepare_throw): Update.
7123         (displaced_step_restore): Update.
7124         (start_step_over): Update.
7125         (resume_1): Update.
7126         (clear_proceed_status_thread): Update.
7127         (proceed): Update.
7128         (print_target_wait_results): Update.
7129         (do_target_wait): Update.
7130         (context_switch): Update.
7131         (stop_all_threads): Update.
7132         (restart_threads): Update.
7133         (finish_step_over): Update.
7134         (handle_signal_stop): Update.
7135         (switch_back_to_stepped_thread): Update.
7136         (keep_going_pass_signal): Update.
7137         (print_exited_reason): Update.
7138         (normal_stop): Update.
7139         * inferior.c (inferior_pid_to_str): Change return type.
7140         (print_selected_inferior): Update.
7141         (add_inferior): Update.
7142         (detach_inferior): Update.
7143         * dummy-frame.c (fprint_dummy_frames): Update.
7144         * dcache.c (dcache_info_1): Update.
7145         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7146         (btrace_fetch, btrace_clear): Update.
7147         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7148         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7149         type.
7150         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7151         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7152         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7153         * gdbarch.c, gdbarch.h: Rebuild.
7154         * gdbarch.sh (core_pid_to_str): Change return type.
7155         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7156         return type.
7157         (windows_nat_target::pid_to_str): Change return type.
7158         (windows_delete_thread): Update.
7159         (windows_nat_target::attach): Update.
7160         (windows_nat_target::files_info): Update.
7161         * target-delegates.c: Rebuild.
7162         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7163         return type.
7164         (sol_thread_target::pid_to_str): Change return type.
7165         * remote.c (class remote_target) <pid_to_str>: Change return
7166         type.
7167         (remote_target::pid_to_str): Change return type.
7168         (extended_remote_target::attach, remote_target::remote_stop_ns)
7169         (remote_target::remote_notif_remove_queued_reply)
7170         (remote_target::push_stop_reply, remote_target::disable_btrace):
7171         Update.
7172         (extended_remote_target::attach): Update.
7173         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7174         type.
7175         (gdbsim_target::pid_to_str): Change return type.
7176         * ravenscar-thread.c (struct ravenscar_thread_target)
7177         <pid_to_str>: Change return type.
7178         (ravenscar_thread_target::pid_to_str): Change return type.
7179         * procfs.c (class procfs_target) <pid_to_str>: Change return
7180         type.
7181         (procfs_target::pid_to_str): Change return type.
7182         (procfs_target::attach): Update.
7183         (procfs_target::detach): Update.
7184         (procfs_target::fetch_registers): Update.
7185         (procfs_target::store_registers): Update.
7186         (procfs_target::wait): Update.
7187         (procfs_target::files_info): Update.
7188         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7189         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7190         return type.
7191         (nto_procfs_target::pid_to_str): Change return type.
7192         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7193         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7194         return type.
7195         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7196         (exit_lwp): Update.
7197         (attach_proc_task_lwp_callback, get_detach_signal)
7198         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7199         (linux_nat_target::resume, wait_lwp, stop_callback)
7200         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7201         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7202         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7203         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7204         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7205         type.
7206         (inf_ptrace_target::attach): Update.
7207         (inf_ptrace_target::files_info): Update.
7208         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7209         type.
7210         (go32_nat_target::pid_to_str): Change return type.
7211         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7212         (gnu_nat_target::wait): Update.
7213         (gnu_nat_target::wait): Update.
7214         (gnu_nat_target::resume): Update.
7215         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7216         (fbsd_nat_target::wait): Update.
7217         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7218         type.
7219         (darwin_nat_target::attach): Update.
7220         * corelow.c (class core_target) <pid_to_str>: Change return type.
7221         (core_target::pid_to_str): Change return type.
7222         * target.c (normal_pid_to_str): Change return type.
7223         (default_pid_to_str): Likewise.
7224         (target_pid_to_str): Change return type.
7225         (target_translate_tls_address): Update.
7226         (target_announce_detach): Update.
7227         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7228         return type.
7229         (bsd_uthread_target::pid_to_str): Change return type.
7230         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7231         type.
7232         (bsd_kvm_target::pid_to_str): Change return type.
7233         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7234         return type.
7235         (aix_thread_target::pid_to_str): Change return type.
7236         * target.h (struct target_ops) <pid_to_str>: Change return type.
7237         (target_pid_to_str, normal_pid_to_str): Likewise.
7238         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7239         type.
7240         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7241         type.
7242         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7243         return type.
7244         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7245         type.
7246         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7247         type.
7248         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7249         return type.
7250
7251 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7252
7253         * NEWS: Mention that the new default MI version is 3.  Mention
7254         changes to the output of commands and events that deal with
7255         multi-location breakpoints.
7256         * breakpoint.c: Include "mi/mi-out.h".
7257         (print_one_breakpoint): Change output syntax if using MI version
7258         >= 3.
7259         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7260         New.
7261         (mi_multi_location_breakpoint_output_fixed): New.
7262         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7263         (mi_cmd_fix_multi_location_breakpoint_output): New.
7264         (mi_multi_location_breakpoint_output_fixed): New.
7265         * mi/mi-cmds.c (mi_cmds): Register command
7266         -fix-multi-location-breakpoint-output.
7267         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7268         interpreter "mi".
7269
7270 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7271
7272         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7273         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7274         instantiate mi_ui_out based on interpreter name.
7275         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7276         * mi/mi-main.c (mi_load_progress): Likewise.
7277
7278 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7279
7280         * NEWS: Combine separate "New targets" sections for 8.3.
7281
7282 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7283
7284         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7285         (ppcfbsd_init_abi): Install gdbarch
7286         "fetch_tls_load_module_address" and "get_thread_local_address"
7287         methods.
7288
7289 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7290
7291         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7292         (riscv_fbsd_init_abi): Install gdbarch
7293         "fetch_tls_load_module_address" and "get_thread_local_address"
7294         methods.
7295
7296 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7297
7298         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7299         (i386fbsd_init_abi): Install gdbarch
7300         "fetch_tls_load_module_address" and "get_thread_local_address"
7301         methods.
7302
7303 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7304
7305         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7306         (amd64fbsd_init_abi): Install gdbarch
7307         "fetch_tls_load_module_address" and "get_thread_local_address"
7308         methods.
7309
7310 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7311
7312         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7313         (struct fbsd_pspace_data): New type.
7314         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7315         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7316         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7317         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7318         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7319
7320 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7321
7322         * gdbtypes.c (lookup_struct_elt): New function.
7323         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7324         * gdbtypes.h (struct struct_elt): New type.
7325         (lookup_struct_elt): New prototype.
7326
7327 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7328
7329         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7330         remove disabled code block.
7331
7332 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7333
7334         * gdbarch.sh (get_thread_local_address): New method.
7335         * gdbarch.h, gdbarch.c: Regenerate.
7336         * target.c (target_translate_tls_address): Use
7337         gdbarch_get_thread_local_address if present instead of
7338         target::get_thread_local_address.
7339
7340 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7341
7342         * target.h (target::get_thread_local_address): Update comment.
7343
7344 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7345
7346         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7347         objfile->separate_debug_objfile_backlink if not NULL.
7348
7349 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7350
7351         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7352         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7353         (amd64bsd_store_inferior_registers): Likewise.
7354         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7355         Enable segment base registers.
7356         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7357         PT_GETFSBASE and PT_GETGSBASE.
7358         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7359         PT_SETGSBASE.
7360         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7361         segment base registers.
7362         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7363
7364 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7365
7366         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7367         Update calls to i386_target_description to add 'segments'
7368         parameter.
7369         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7370         add segment base registers.
7371         * arch/i386.c (i386_create_target_description): Add 'segments'
7372         parameter to enable segment base registers.
7373         * arch/i386.h (i386_create_target_description): Likewise.
7374         * features/i386/32bit-segments.xml: New file.
7375         * features/i386/32bit-segments.c: Generate.
7376         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7377         call to i386_target_description to add 'segments' parameter.
7378         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7379         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7380         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7381         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7382         if feature is present.
7383         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7384         Add 'segments' parameter to call to i386_target_description.
7385         (i386_target_description): Add 'segments' parameter to enable
7386         segment base registers.
7387         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7388         to call to i386_target_description.
7389         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7390         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7391         Define I386_NUM_REGS.
7392         (i386_target_description): Add 'segments' parameter to enable
7393         segment base registers.
7394
7395 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7396
7397         PR/24325
7398         * source-cache.c: #undef open and close, to avoid unresolved
7399         externals during linking.
7400
7401 2019-03-12  Tom Tromey  <tromey@adacore.com>
7402
7403         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7404         const.  Add initializers.
7405         (_initialize_remote): Don't initialize ptid globals.
7406
7407 2019-03-12  Pedro Alves  <palves@redhat.com>
7408
7409         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7410
7411 2019-03-12  Pedro Alves  <palves@redhat.com>
7412
7413         * cp-name-parser.y (main): Remove unused 'len' variable.
7414
7415 2019-03-12  Tom Tromey  <tromey@adacore.com>
7416
7417         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7418         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7419
7420 2019-03-12  Tom Tromey  <tromey@adacore.com>
7421
7422         * linux-nat.c (iterate_over_lwps): Update.
7423         (stop_callback): Remove parameter.
7424         (stop_wait_callback, detach_callback, resume_set_callback)
7425         (select_singlestep_lwp_callback, set_ignore_sigint)
7426         (status_callback, resumed_callback, resume_clear_callback)
7427         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7428         data parameter.
7429         (linux_nat_target::detach, linux_nat_target::resume)
7430         (linux_stop_and_wait_all_lwps, select_event_lwp)
7431         (linux_nat_filter_event, linux_nat_wait_1)
7432         (linux_nat_target::kill, linux_nat_target::stop)
7433         (linux_nat_target::stop): Update.
7434         (linux_nat_resume_callback): Change type.
7435         (resume_stopped_resumed_lwps, count_events_callback)
7436         (select_event_lwp_callback): Likewise.
7437         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7438         * arm-linux-nat.c (struct update_registers_data): Remove.
7439         (update_registers_callback): Change type.
7440         (arm_linux_insert_hw_breakpoint1): Update.
7441         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7442         parameter.
7443         (x86_linux_dr_set_addr): Update.
7444         (x86_linux_dr_set_control): Update.
7445         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7446         (iterate_over_lwps): Use gdb::function_view.
7447         * nat/aarch64-linux-hw-point.c (struct
7448         aarch64_dr_update_callback_param): Remove.
7449         (debug_reg_change_callback): Change type.
7450         (aarch64_notify_debug_reg_change): Update.
7451         * s390-linux-nat.c (s390_refresh_per_info): Update.
7452
7453 2019-03-11  Tom Tromey  <tromey@adacore.com>
7454
7455         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7456         redundant assignment to "this_cu".
7457
7458 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7459
7460         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7461
7462 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7463
7464         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7465         from...
7466         (rank_one_type): ... this.
7467
7468 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7469
7470         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7471         from...
7472         (rank_one_type): ... this.
7473
7474 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7475
7476         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7477         from...
7478         (rank_one_type): ... this.
7479
7480 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7481
7482         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7483         from...
7484         (rank_one_type): ... this.
7485
7486 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7487
7488         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7489         from...
7490         (rank_one_type): ... this.
7491
7492 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7493
7494         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7495         from...
7496         (rank_one_type): ... this.
7497
7498 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7499
7500         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7501         from...
7502         (rank_one_type): ... this.
7503
7504 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7505
7506         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7507         from...
7508         (rank_one_type): ... this.
7509
7510 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7511
7512         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7513         from...
7514         (rank_one_type): ... this.
7515
7516 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7517
7518         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7519         from...
7520         (rank_one_type): ... this.
7521
7522 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7523
7524         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7525         from...
7526         (rank_one_type): ... this.
7527
7528 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7529
7530         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7531         from...
7532         (rank_one_type): ... this.
7533
7534 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7535
7536         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7537         inferior-events' shows the example events.
7538
7539 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7540
7541         Support styling on native MS-Windows console
7542
7543         PR/24315
7544         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7545         on MS-Windows if $TERM is not defined.
7546
7547         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7548
7549         * posix-hdep.c (gdb_console_fputs):
7550         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7551         functions.
7552         * ui-file.h (gdb_console_fputs): Add prototype.
7553
7554         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7555         back to fputs only if the former returns zero.
7556
7557 2019-03-07  Tom Tromey  <tom@tromey.com>
7558
7559         * symmisc.c (print_symbol_bcache_statistics): Update.
7560         (print_objfile_statistics): Update.
7561         * symfile.c (allocate_symtab): Update.
7562         * stabsread.c: Don't include bcache.h.
7563         * psymtab.h (struct psymbol_bcache): Don't declare.
7564         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7565         (psymbol_bcache_init, psymbol_bcache_free)
7566         (psymbol_bcache_get_bcache): Don't declare.
7567         * psymtab.c (struct psymbol_bcache): Remove.
7568         (psymtab_storage::psymtab_storage): Update.
7569         (psymtab_storage::~psymtab_storage): Update.
7570         (psymbol_bcache_init, psymbol_bcache_free)
7571         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7572         (add_psymbol_to_bcache): Update.
7573         (allocate_psymtab): Update.
7574         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7575         macro_cache>: No longer pointers.
7576         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7577         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7578         * macrotab.c (macro_bcache): Update.
7579         * macroexp.c: Don't include bcache.h.
7580         * gdbtypes.c (check_types_worklist): Update.
7581         (types_deeply_equal): Remove TRY/CATCH.  Update.
7582         * elfread.c (elf_symtab_read): Update.
7583         * dwarf2read.c: Don't include bcache.h.
7584         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7585         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7586         (print_bcache_statistics, bcache_memory_used): Don't declare.
7587         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7588         methods.  Rename all data members.
7589         * bcache.c (struct bcache): Move to bcache.h.
7590         (bcache::expand_hash_table): Rename from expand_hash_table.
7591         (bcache): Remove.
7592         (bcache::insert): Rename from bcache_full.
7593         (bcache::compare): Rename from bcache_compare.
7594         (bcache_xmalloc): Remove.
7595         (bcache::~bcache): Rename from bcache_xfree.
7596         (bcache::print_statistics): Rename from print_bcache_statistics.
7597         (bcache::memory_used): Rename from bcache_memory_used.
7598
7599 2019-03-07  Pedro Alves  <palves@redhat.com>
7600
7601         * infrun.c (normal_stop): Also check for
7602         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7603
7604 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7605
7606         * f-lang.c (value_from_host_double): Moved to...
7607         * value.c (value_from_host_double): ...here.
7608         * value.h (value_from_host_double): Declare.
7609         * guile/scm-math.c (vlscm_convert_typed_number): Use
7610         value_from_host_double.
7611         (vlscm_convert_number): Likewise.
7612         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7613         * python/py-value.c (convert_value_from_python): Likewise.
7614
7615 2019-03-06  Tom Tromey  <tom@tromey.com>
7616
7617         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7618
7619 2019-03-06  Tom Tromey  <tom@tromey.com>
7620
7621         * utils.h (free_current_contents): Don't declare.
7622         * utils.c (free_current_contents): Remove.
7623
7624 2019-03-06  Tom Tromey  <tom@tromey.com>
7625
7626         * top.c (quit_force): Update.
7627         * main.c (captured_command_loop): Update.
7628         * common/new-op.c (operator new): Update.
7629         * common/common-exceptions.c (struct catcher)
7630         <save_cleanup_chain>: Remove member.
7631         (exceptions_state_mc_init): Update.
7632         (exception_try_scope_entry): Return nullptr.
7633         (exception_try_scope_exit, exception_rethrow)
7634         (throw_exception_sjlj, throw_exception_cxx): Update.
7635         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7636         (all_cleanups, do_cleanups, discard_cleanups)
7637         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7638         (restore_cleanups, restore_final_cleanups): Don't declare.
7639         (do_final_cleanups): Remove parameter.
7640         * common/cleanups.c (cleanup_chain, make_cleanup)
7641         (make_cleanup_dtor, all_cleanups, do_cleanups)
7642         (discard_my_cleanups, discard_cleanups)
7643         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7644         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7645         (null_cleanup): Remove.
7646         (do_final_cleanups): Remove parameter.
7647
7648 2019-03-06  Tom Tromey  <tom@tromey.com>
7649
7650         * remote.c (remote_target::remote_parse_stop_reply): Use
7651         unique_xmalloc_ptr.
7652
7653 2019-03-06  Tom Tromey  <tom@tromey.com>
7654
7655         * stabsread.c (struct stabs_field_info): Rename from field_info.
7656         <list, fnlist>: Add initializers.
7657         <obstack>: New member.
7658         (read_member_functions, read_struct_fields, read_baseclasses):
7659         Allocate on obstack.  Don't use cleanups.
7660         (read_one_struct_field, read_member_functions, read_struct_fields)
7661         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7662         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7663         (read_struct_type): Update.
7664
7665 2019-03-06  Tom Tromey  <tom@tromey.com>
7666
7667         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7668         * common/filestuff.h (make_cleanup_close): Don't declare.
7669         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7670         Remove.
7671
7672 2019-03-06  Tom Tromey  <tom@tromey.com>
7673
7674         * solib-aix.c: Use make_scope_exit.
7675
7676 2019-03-06  Tom Tromey  <tom@tromey.com>
7677
7678         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7679         Use make_scope_exit.
7680
7681 2019-03-06  Tom Tromey  <tom@tromey.com>
7682
7683         * solib-svr4.c (disable_probes_interface): Remove parameter.
7684         (svr4_handle_solib_event): Use make_scope_exit.
7685
7686 2019-03-06  Tom Tromey  <tom@tromey.com>
7687
7688         * remote.c (struct stop_reply_deleter): Remove.
7689         (stop_reply_up): Update.
7690         (struct stop_reply): Derive from notif_event.  Don't typedef.
7691         <regcache>: Now a std::vector.
7692         (stop_reply_xfree): Remove.
7693         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7694         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7695         (remote_target::discard_pending_stop_replies): Use delete.
7696         (remote_target::remote_parse_stop_reply): Update.
7697         (remote_target::process_stop_reply): Update.
7698         * remote-notif.h (struct notif_event): Add virtual destructor.
7699         Remove "dtr" member.
7700         (struct notif_client) <alloc_event>: Return a unique_ptr.
7701         (notif_event_xfree): Don't declare.
7702         (notif_event_up): New typedef.
7703         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7704         (notif_event_xfree, do_notif_event_xfree): Remove.
7705         (remote_notif_state_xfree): Update.
7706
7707 2019-03-06  Tom Tromey  <tom@tromey.com>
7708
7709         * infrun.c (displaced_step_clear_cleanup): Now a
7710         forward_scope_exit type.
7711         (displaced_step_prepare_throw): Update.
7712         (displaced_step_fixup): Update.
7713
7714 2019-03-06  Tom Tromey  <tom@tromey.com>
7715
7716         * inferior.h (class inferior): Update comment.
7717         * gdbthread.h (class thread_info): Update comment.
7718
7719 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7720             Tom Tromey  <tom@tromey.com>
7721
7722         * stabsread.h (struct stab_section_list): Remove.
7723         (coffstab_build_psymtabs): Update.
7724         * dbxread.c (symbuf_sections): Now a std::vector.
7725         (sect_idx): New global.
7726         (fill_symbuf): Update.
7727         (coffstab_build_psymtabs): Change type of stabsects parameter.
7728         Update.
7729         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7730         std::vector.
7731         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7732         (coff_locate_sections): Update.
7733         (coff_symfile_read): Remove cleanups.  Update.
7734         (init_stringtab): Add storage parameter.
7735         (free_stringtab, free_stringtab_cleanup): Remove.
7736         (init_lineno): Add storage parameter.
7737         (free_linetab, free_linetab_cleanup): Remove.
7738
7739 2019-03-06  Pedro Alves  <palves@redhat.com>
7740
7741         * linux-fork.c (fork_info::clobber_regs): Delete.
7742         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7743         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7744         comment.  Adjust.
7745         (scoped_switch_fork_info::scoped_switch_fork_info)
7746         (checkpoint_command, linux_fork_context): Adjust
7747         fork_save_infrun_state calls.
7748
7749 2019-03-06  Pedro Alves  <palves@redhat.com>
7750
7751         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7752         (inf_has_multiple_threads): Return 'bool' and rewrite using
7753         inferior_info::threads().
7754
7755 2019-03-06  Pedro Alves  <palves@redhat.com>
7756
7757         * linux-fork.c: Include <list>.
7758         (fork_list): Now a std::list instance.
7759         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7760         (forks_exist_p, find_last_fork): Adjust.
7761         (new_fork): Delete.
7762         (one_fork_p): New.
7763         (add_fork): Adjust.
7764         (free_fork): Delete, folded into fork_info::~fork_info().
7765         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7766         Adjust.
7767         (init_fork_list): Delete.
7768         (linux_fork_killall, linux_fork_mourn_inferior)
7769         (linux_fork_detach, info_checkpoints_command): Adjust.
7770         (_initialize_linux_fork): No longer call init_fork_list.
7771
7772 2019-03-06  Pedro Alves  <palves@redhat.com>
7773
7774         * linux-fork.c (new_fork): New, split out of ...
7775         (add_fork): ... this.  Return void.  Move "first fork" special
7776         case from here, to ...
7777         (checkpoint_command): ... here.
7778         * linux-linux.h (add_fork): Return void.
7779
7780 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7781
7782         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7783
7784 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7785             Chris January  <chris.january@arm.com>
7786             David Lecomber  <david.lecomber@arm.com>
7787
7788         * f-exp.y: New token, UNOP_INTRINSIC.
7789         (exp): New pattern using UNOP_INTRINSIC token.
7790         (f77_keywords): Add 'abs' keyword.
7791         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7792         (value_from_host_double): New function.
7793         (evaluate_subexp_f): Support UNOP_ABS.
7794
7795 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7796
7797         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7798         types.
7799
7800 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7801
7802         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7803         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7804         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7805
7806 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7807
7808         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7809
7810 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7811             Chris January  <chris.january@arm.com>
7812
7813         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7814         * f-exp.y: Define 'KIND' token.
7815         (exp): New pattern for KIND expressions.
7816         (ptype): Handle types with a kind extension.
7817         (direct_abs_decl): Extend to spot kind extensions.
7818         (f77_keywords): Add 'kind' to the list.
7819         (push_kind_type): New function.
7820         (convert_to_kind_type): New function.
7821         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7822         * parse.c (operator_length_standard): Likewise.
7823         * parser-defs.h (enum type_pieces): Add tp_kind.
7824         * std-operator.def: Add UNOP_KIND.
7825
7826 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7827
7828         * f-exp.y (f_parse): Set yydebug.
7829
7830 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7831
7832         * f-lang.c (evaluate_subexp_f): New function.
7833         (exp_descriptor_f): New global.
7834         (f_language_defn): Use exp_descriptor_f instead of
7835         exp_descriptor_standard.
7836
7837 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7838
7839         * f-exp.y (struct token): Add comments.
7840         (dot_ops): Remove uppercase versions and the end marker.
7841         (f77_keywords): Likewise.
7842         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7843         entries in the dot_ops array are case insensitive, and use
7844         strncasecmp to compare strings.  Also some whitespace cleanup in
7845         this area.  Similar for the f77_keywords array, except entries in
7846         this list might be case sensitive.
7847
7848 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7849
7850         * f-exp.y (struct f77_boolean_val): Add comments.
7851         (boolean_values): Remove uppercase versions, and end marker.
7852         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7853         and use strncasecmp to achieve case insensitivity.  Additionally,
7854         perform whitespace cleanup around this code.
7855
7856 2019-03-06  Tom Tromey  <tromey@adacore.com>
7857
7858         * remote-sim.c (gdbsim_target_open): Use result of
7859         gdb_argv::release.
7860
7861 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7862         Dirk Schubert  <dirk.schubert@arm.com>
7863         Chris January  <chris.january@arm.com>
7864
7865         * eval.c (evaluate_subexp_standard): Call Fortran argument
7866         wrapping logic.
7867         * f-lang.c (struct value): A value which can be passed into a
7868         Fortran function call.
7869         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7870         where appropriate.
7871         (struct type): Value ready for a Fortran function call.
7872         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7873         is needed.
7874         * f-lang.h (fortran_argument_convert): Declaration.
7875         (fortran_preserve_arg_pointer): Declaration.
7876         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7877
7878 2019-03-05  Tom Tromey  <tromey@adacore.com>
7879
7880         * python/py-prettyprint.c (print_string_repr): Remove #if.
7881         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7882
7883 2019-03-05  Tom Tromey  <tromey@adacore.com>
7884
7885         * target.c (the_dummy_target): Move later.  Change type to
7886         "dummy_target".
7887         (initialize_targets): Don't initialize the_dummy_target.
7888
7889 2019-03-05  Tom Tromey  <tromey@adacore.com>
7890
7891         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7892         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7893
7894 2019-03-05  Tom Tromey  <tromey@adacore.com>
7895
7896         * windows-nat.c (windows_nat_target::attach)
7897         (windows_nat_target::detach): Don't call gdb_flush.
7898         * valprint.c (generic_val_print, val_print, val_print_string):
7899         Don't call gdb_flush.
7900         * utils.c (defaulted_query): Don't call gdb_flush.
7901         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7902         * target.c (target_announce_detach): Don't call gdb_flush.
7903         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7904         * remote.c (extended_remote_target::attach): Don't call
7905         gdb_flush.
7906         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7907         * printcmd.c (do_examine): Don't call gdb_flush.
7908         (info_display_command): Don't call gdb_flush.
7909         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7910         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7911         * memattr.c (info_mem_command): Don't call gdb_flush.
7912         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7913         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7914         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7915         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7916         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7917         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7918         (gnu_nat_target::detach): Don't call gdb_flush.
7919         * f-valprint.c (f_val_print): Don't call gdb_flush.
7920         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7921         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7922         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7923         gdb_flush.
7924         * c-valprint.c (c_val_print): Don't call gdb_flush.
7925         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7926
7927 2019-03-05  Tom Tromey  <tromey@adacore.com>
7928
7929         * varobj.c (update_dynamic_varobj_children): Update.
7930         (install_default_visualizer): Use reset, not release.
7931         * value.c (set_internalvar): Update.
7932         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7933         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7934         ATTRIBUTE_UNUSED_RESULT.
7935
7936 2019-03-05  Tom Tromey  <tromey@adacore.com>
7937
7938         * remote.c (class scoped_remote_fd) <release>: Add
7939         ATTRIBUTE_UNUSED_RESULT.
7940
7941 2019-03-05  Tom Tromey  <tromey@adacore.com>
7942
7943         * macroexp.c (struct macro_buffer) <release>: Add
7944         ATTRIBUTE_UNUSED_RESULT.
7945
7946 2019-03-05  Tom Tromey  <tromey@adacore.com>
7947
7948         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7949         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7950         ATTRIBUTE_UNUSED_RESULT.
7951
7952 2019-03-05  Tom Tromey  <tromey@adacore.com>
7953
7954         * common/scoped_fd.h (class scoped_fd) <release>: Add
7955         ATTRIBUTE_UNUSED_RESULT.
7956
7957 2019-03-05  Tom Tromey  <tromey@adacore.com>
7958
7959         * parser-defs.h (struct parser_state) <release>: Add
7960         ATTRIBUTE_UNUSED_RESULT.
7961
7962 2019-03-05  Tom Tromey  <tromey@adacore.com>
7963
7964         * utils.h (class gdb_argv) <release>: Add
7965         ATTRIBUTE_UNUSED_RESULT.
7966         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7967
7968 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7969
7970         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7971         for-loop range, to avoid compiler warnings.
7972
7973         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7974         avoid compiler warnings about unused variables.
7975
7976         * NEWS: Mention end of support for native debugging on MS-Windows
7977         before XP.
7978
7979         PR gdb/24292
7980         * common/netstuff.c:
7981         * gdbserver/gdbreplay.c
7982         * gdbserver/remote-utils.c:
7983         * ser-tcp.c:
7984         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7985         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7986         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7987         'getaddrinfo' and 'freeaddrinfo' were not available before
7988         Windows XP, and mingw.org's MinGW headers by default define
7989         _WIN32_WINNT to 0x500.
7990
7991 2019-03-01  Gary Benson <gbenson@redhat.com>
7992
7993         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7994
7995 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7996             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7997
7998         PR gdb/8527
7999         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8000         set_sigint_trap, clear_sigint_trap.
8001
8002 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8003
8004         * target.c (target_detach): Clear the regcache and the
8005         frame cache.
8006
8007 2019-02-27  Pedro Alves  <palves@redhat.com>
8008
8009         * utils.c (set_screen_size): When we cap the height/width sizes,
8010         tweak the corresponding command variable to show "unlimited":
8011
8012 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8013             Pedro Alves  <palves@redhat.com>
8014
8015         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8016         before calling rl_set_screen_size.
8017
8018 2019-02-27  Tom Tromey  <tromey@adacore.com>
8019
8020         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8021         define.
8022         * python/py-value.c: Remove Python 2.4 workaround.
8023         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8024         workaround.
8025         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8026         Python 2.4 workaround.
8027         * python/python-internal.h: Remove Python 2.4 comment.
8028         (Py_ssize_t): Don't define.
8029         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8030         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8031         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8032         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8033         * python/python.c (do_start_initialization): Remove Python 2.4
8034         workaround.
8035         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8036         (print_children): Remove Python 2.4 workaround.
8037         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8038         workaround.
8039         (CHARBUFFERPROC_NAME): Remove.
8040         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8041         Python 2.4 workaround.
8042
8043 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8044
8045         * NEWS: Note minimum Python version.
8046
8047 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8048
8049         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8050         code from these functions.  Remove corresponding ifdefs.  Use
8051         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8052         Remove gotos and target of gotos.
8053         (infpy_search_memory): Likewise.
8054
8055 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8056
8057         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8058         (hppa_gdbarch_init): Don't register deleted functions with
8059         gdbarch.
8060
8061 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8062
8063         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8064         (h8300_unwind_sp): Delete.
8065         (h8300_dummy_id): Delete.
8066         (h8300_gdbarch_init): Don't register deleted functions with
8067         gdbarch.
8068
8069 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8070
8071         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8072         (ft32_unwind_pc): Delete.
8073         (ft32_unwind_sp): Delete.
8074         (ft32_gdbarch_init): Don't register deleted functions with
8075         gdbarch.
8076
8077 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8078
8079         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8080         (frv_unwind_pc): Delete.
8081         (frv_unwind_sp): Delete.
8082         (frv_gdbarch_init): Don't register deleted functions with
8083         gdbarch.
8084
8085 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8086
8087         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8088         (riscv_unwind_pc): Delete.
8089         (riscv_unwind_sp): Delete.
8090         (riscv_gdbarch_init): Don't register deleted functions with
8091         gdbarch.
8092
8093 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8094
8095         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8096         (csky_unwind_pc): Delete.
8097         (csky_unwind_sp): Delete.
8098         (csky_gdbarch_init): Don't register deleted functions with
8099         gdbarch.
8100
8101 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8102
8103         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8104         (cris_unwind_pc): Delete.
8105         (cris_unwind_sp): Delete.
8106         (cris_gdbarch_init): Don't register deleted functions with
8107         gdbarch.
8108
8109 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8110
8111         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8112         (bfin_unwind_pc): Delete.
8113         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8114
8115 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8116
8117         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8118         (arm_unwind_pc): Delete.
8119         (arm_unwind_sp): Delete.
8120         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8121
8122 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8123
8124         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8125         (arc_unwind_pc): Delete.
8126         (arc_unwind_sp): Delete.
8127         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8128
8129 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8130
8131         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8132         (alpha_unwind_pc): Delete.
8133         (alpha_gdbarch_init): Don't register deleted functions with
8134         gdbarch.
8135
8136 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8137
8138         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8139         (aarch64_unwind_pc): Delete.
8140         (aarch64_unwind_sp): Delete.
8141         (aarch64_gdbarch_init): Don't register deleted functions with
8142         gdbarch.
8143
8144 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8145
8146         * gdbtypes.c (type_align): Don't consider static members when
8147         computing structure alignment.
8148
8149 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8150
8151         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8152         return 0 for other types.
8153         * arch-utils.c (default_type_align): Always return 0.
8154         * gdbarch.h: Regenerate.
8155         * gdbarch.sh (type_align): Extend comment.
8156         * gdbtypes.c (type_align): Add additional comments, always call
8157         gdbarch_type_align before applying the default rules.
8158         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8159         generic code will then apply a suitable default.
8160         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8161         types, return 0 for other types.
8162
8163 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8164
8165         * NEWS: Create a new section for the next release branch.
8166         Rename the section of the current branch, now that it has
8167         been cut.
8168
8169 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8170
8171         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8172         * version.in: Bump version to 8.3.50.DATE-git.
8173
8174 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8175
8176         * aix-thread.c (ptid_cmp): Remove unused variable.
8177         (get_signaled_thread): Likewise.
8178         (store_regs_user_thread): Likewise.
8179         (store_regs_kernel_thread): Likewise.
8180         (fetch_regs_kernel_thread): Remove shadowed variable.
8181
8182 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8183
8184         * features/riscv/32bit-cpu.xml: Add register numbers.
8185         * features/riscv/32bit-fpu.c: Regenerate.
8186         * features/riscv/32bit-fpu.xml: Add register numbers.
8187         * features/riscv/64bit-cpu.xml: Add register numbers.
8188         * features/riscv/64bit-fpu.c: Regenerate.
8189         * features/riscv/64bit-fpu.xml: Add register numbers.
8190
8191 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8192
8193         * NEWS: Mention two argument form of gdb.Value constructor.
8194         * python/py-value.c (convert_buffer_and_type_to_value): New
8195         function.
8196         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8197         Add support for handling an optional second argument.  Call
8198         convert_buffer_and_type_to_value as appropriate.
8199         * python/python-internal.h (Py_buffer_deleter): New struct.
8200         (Py_buffer_up): New typedef.
8201
8202 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8203
8204         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8205         instead of releasing ownership.
8206
8207 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8208
8209         * dwarf2read.c (open_and_init_dwp_file): Call
8210         elf_numsections instead of bfd_count_sections to initialize
8211         dwp_file->num_sections.
8212
8213 2019-02-25  Tom Tromey  <tromey@adacore.com>
8214
8215         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8216
8217 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8218
8219         * gcore.in: Add '--readnever' option when invoking GDB.
8220
8221 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8222
8223         * MAINTAINERS: Update my email address.
8224
8225 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8226
8227         * build-id.c (build_id_to_debug_bfd_1): New function.
8228         (build_id_to_debug_bfd): Look for separate debug file in
8229         sysroot.
8230
8231 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8232
8233         * gdbarch.sh: Update the copyright year range that is placed into
8234         generated files.
8235
8236 2019-02-22  Keith Seitz  <keiths@redhat.com>
8237
8238         PR symtab/23853
8239         * linespec.c (create_sals_line_offset): Search for the default
8240         symtab's filename instead of its fullname.
8241
8242 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8243
8244         * NEWS: Update style defaults.
8245
8246 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8247
8248         * main.c (captured_main_1): Disable styling in batch mode.
8249
8250 2019-02-20  Tom Tromey  <tom@tromey.com>
8251
8252         * symtab.c (symtab_symbol_info): Fix typos.
8253
8254 2019-02-20  Tom Tromey  <tromey@adacore.com>
8255
8256         * findcmd.c (_initialize_mem_search): Use upper case for
8257         metasyntactic variables.
8258
8259 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8260
8261         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8262         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8263
8264 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8265
8266         * top.h (source_file_name): Change to std::string.
8267         * top.c (source_file_name): Likewise.
8268         (command_line_input): Adjust.
8269         * cli/cli-script.c (script_from_file): Adjust.
8270
8271 2019-02-19  Tom Tromey  <tromey@adacore.com>
8272
8273         * ravenscar-thread.c
8274         (ravenscar_thread_target::update_thread_list): Don't call
8275         ada_build_task_list.
8276         * ada-lang.h (ada_build_task_list): Don't declare.
8277         * ada-tasks.c (struct ada_tasks_inferior_data)
8278         <task_list_valid_p>: Now bool.
8279         (read_known_tasks, ada_task_list_changed)
8280         (ada_tasks_invalidate_inferior_data): Update.
8281         (read_known_tasks_array): Return bool.
8282         (read_known_tasks_list): Likewise.
8283         (read_known_tasks): Return void.
8284         (ada_build_task_list): Now static.
8285
8286 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8287
8288         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8289         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8290
8291 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8292
8293         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8294         variant for ada_tasks_pspace_data_handle and
8295         ada_tasks_inferior_data_handle.
8296         (ada_tasks_pspace_data_cleanup): New function.
8297         (ada_tasks_inferior_data_cleanup): New function.
8298
8299 2019-02-17  Tom Tromey  <tom@tromey.com>
8300
8301         * macrotab.h (macro_source_fullname): Return a std::string.
8302         * macrotab.c (macro_include, check_for_redefinition)
8303         (macro_undef, macro_lookup_definition, foreach_macro)
8304         (foreach_macro_in_scope): Update.
8305         (macro_source_fullname): Return a std::string.
8306         * macrocmd.c (show_pp_source_pos): Update.
8307
8308 2019-02-17  Tom Tromey  <tom@tromey.com>
8309
8310         * macrocmd.c (show_pp_source_pos): Style the file names.
8311
8312 2019-02-17  Tom Tromey  <tom@tromey.com>
8313
8314         PR tui/24197:
8315         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8316
8317 2019-02-17  Tom Tromey  <tom@tromey.com>
8318
8319         * ada-lang.c (user_select_syms): Use filtered printing.
8320         * utils.c (wrap_style): New global.
8321         (desired_style): Remove.
8322         (emit_style_escape): Add stream parameter.
8323         (set_output_style, reset_terminal_style, prompt_for_continue):
8324         Update.
8325         (flush_wrap_buffer): Only flush gdb_stdout.
8326         (wrap_here): Set wrap_style.
8327         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8328         treat escape sequences as a character.  Change when wrap buffer is
8329         flushed.
8330         (fputs_styled): Do not set the output style when the default is
8331         requested.
8332         * ui-style.h (struct ui_file_style) <is_default>: New method.
8333         * source.c (print_source_lines_base): Emit escape sequences in one
8334         piece.
8335
8336 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8337
8338         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8339         integers and enumeration types.
8340
8341 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8342
8343         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8344         instead of lookup_symbol_in_language
8345         (do_exact_match): New function.
8346         (ada_get_symbol_name_matcher): Return do_exact_match when
8347         doing a verbatim match.
8348
8349 2019-02-15  Tom Tromey  <tromey@adacore.com>
8350
8351         * ravenscar-thread.c (ravenscar_thread_target::resume)
8352         (ravenscar_thread_target::wait): Special case wildcard requests.
8353
8354 2019-02-15  Tom Tromey  <tromey@adacore.com>
8355
8356         * ravenscar-thread.c (base_ptid): Remove.
8357         (struct ravenscar_thread_target) <close>: New method.
8358         <m_base_ptid>: New member.
8359         <update_inferior_ptid, active_task, task_is_currently_active,
8360         runtime_initialized>: Declare methods.
8361         <ravenscar_thread_target>: Add constructor.
8362         (ravenscar_thread_target::task_is_currently_active)
8363         (ravenscar_thread_target::update_inferior_ptid)
8364         (ravenscar_runtime_initialized): Rename.  Now methods.
8365         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8366         (ravenscar_thread_target::update_thread_list): Update.
8367         (ravenscar_thread_target::active_task): Now method.
8368         (ravenscar_thread_target::store_registers)
8369         (ravenscar_thread_target::prepare_to_store)
8370         (ravenscar_thread_target::prepare_to_store)
8371         (ravenscar_thread_target::mourn_inferior): Update.
8372         (ravenscar_inferior_created): Use "new" to create target.
8373         (ravenscar_thread_target::get_ada_task_ptid): Update.
8374         (_initialize_ravenscar): Don't initialize base_ptid.
8375         (ravenscar_ops): Remove global.
8376
8377 2019-02-15  Tom Tromey  <tromey@adacore.com>
8378
8379         * target.h (push_target): Declare new overload.
8380         * target.c (push_target): New overload, taking an rvalue reference.
8381         * remote.c (remote_target::open_1): Use push_target overload.
8382         * corelow.c (core_target_open): Use push_target overload.
8383
8384 2019-02-15  Tom Tromey  <tromey@adacore.com>
8385
8386         * ravenscar-thread.c (is_ravenscar_task)
8387         (ravenscar_task_is_currently_active): Return bool.
8388         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8389         (_initialize_ravenscar): Remove "(void)".
8390         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8391         Return bool.
8392
8393 2019-02-15  Tom Tromey  <tromey@adacore.com>
8394
8395         * ravenscar-thread.c (ravenscar_runtime_initializer)
8396         (has_ravenscar_runtime, get_running_thread_id)
8397         (ravenscar_thread_target::resume): Fix indentation.
8398
8399 2019-02-15  Tom Tromey  <tromey@adacore.com>
8400
8401         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8402         from ravenscar_arch_ops.
8403         (sparc_ravenscar_ops::fetch_registers)
8404         (sparc_ravenscar_ops::store_registers): Now methods.
8405         (sparc_ravenscar_prepare_to_store): Remove.
8406         (sparc_ravenscar_ops): Redefine.
8407         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8408         methods and destructor.  Remove members.
8409         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8410         (ravenscar_thread_target::store_registers)
8411         (ravenscar_thread_target::prepare_to_store): Update.
8412         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8413         Remove.
8414         (struct ppc_ravenscar_powerpc_ops): Derive from
8415         ravenscar_arch_ops.
8416         (ppc_ravenscar_powerpc_ops::fetch_registers)
8417         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8418         (ppc_ravenscar_powerpc_ops): Redefine.
8419         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8420         (ppc_ravenscar_e500_ops::fetch_registers)
8421         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8422         (ppc_ravenscar_e500_ops): Redefine.
8423         * aarch64-ravenscar-thread.c
8424         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8425         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8426         (aarch64_ravenscar_fetch_registers)
8427         (aarch64_ravenscar_store_registers): Now methods.
8428         (aarch64_ravenscar_ops): Redefine.
8429
8430 2019-02-15  Tom Tromey  <tromey@adacore.com>
8431
8432         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8433         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8434         (ravenscar_thread_target::stopped_by_watchpoint)
8435         (ravenscar_thread_target::stopped_data_address)
8436         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8437
8438 2019-02-15  Tom Tromey  <tromey@adacore.com>
8439
8440         * ravenscar-thread.c: Fix some typos.
8441
8442 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8443             Tom Tromey  <tromey@adacore.com>
8444
8445         * ada-lang.c (ada_exception_sal): Change addr_string to a
8446         std::string.
8447         (create_ada_exception_catchpoint): Update.
8448
8449 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8450             Tom Tromey  <tromey@adacore.com>
8451
8452         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8453         (bp_location_ops): Remove.
8454         (base_breakpoint_allocate_location): Update.
8455         (free_bp_location): Update.
8456         * ada-lang.c (class ada_catchpoint_location)
8457         <ada_catchpoint_location>: Remove ops parameter.
8458         (ada_catchpoint_location_dtor): Remove.
8459         (ada_catchpoint_location_ops): Remove.
8460         (allocate_location_exception): Update.
8461         * breakpoint.h (struct bp_location_ops): Remove.
8462         (class bp_location) <bp_location>: Remove bp_location_ops
8463         parameter.
8464         <~bp_location>: Add destructor.
8465         <ops>: Remove.
8466
8467 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8468             Pedro Alves  <palves@redhat.com>
8469
8470         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8471         'PATH_MAX'.
8472
8473 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8474             Samuel Thibault  <samuel.thibault@gnu.org>
8475             Thomas Schwinge  <thomas@codesourcery.com>
8476
8477         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8478         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8479
8480 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8481
8482         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8483         (check_empty): Use "const char *".
8484
8485         * gnu-nat.c (gnu_nat_target::detach): Instead of
8486         'detach_inferior (pid)' call
8487         'detach_inferior (find_inferior_pid (pid))'.
8488
8489         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8490         'nat/fork-inferior.o'.
8491         * gnu-nat.c: #include "nat/fork-inferior.h".
8492
8493         * gnu-nat.c (gnu_nat_target::detach): Instead of
8494         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8495         * gnu-nat.h: #include "inf-child.h".
8496         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8497         'i386_gnu_nat_target::fetch_registers'.
8498         (gnu_store_registers): Rename/move to
8499         'i386_gnu_nat_target::store_registers'.
8500
8501         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8502         * gnu-nat.h (mach_thread_info): New function.
8503         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8504
8505         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8506
8507 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8508
8509         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8510
8511 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8512
8513         * windows-nat.c (windows_add_thread): Add new parameter
8514         "main_thread_p" with default value set to false.  Update
8515         function documentation as well as all callers.
8516         (windows_delete_thread): Likewise.
8517         (fake_create_process): Update call to windows_add_thread.
8518         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8519         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8520         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8521         call to windows_delete_thread.
8522
8523 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8524
8525         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8526
8527 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8528
8529         * symfile.c (find_separate_debug_file): Use canonical path of
8530         sysroot with child_path instead of gdb_sysroot if it is valid.
8531
8532 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8533
8534         * symfile.c (find_separate_debug_file): Use child_path to
8535         determine if an object file is under a sysroot.
8536
8537 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8538
8539         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8540         unittests/child-path-selftests.c.
8541         * common/pathstuff.c (child_path): New function.
8542         * common/pathstuff.h (child_path): New prototype.
8543         * unittests/child-path-selftests.c: New file.
8544
8545 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8546
8547         * symfile.c (find_separate_debug_file): Look for separate debug
8548         files in debug directories under the sysroot.
8549
8550 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8551
8552         * symtab.h (struct minimal_symbol data_p): New const method.
8553         (struct minimal_symbol text_p): Likewise.
8554         * symtab.c (output_source_filename): Use file name style
8555         to print file name.
8556         (print_symbol_info): Likewise.
8557         (print_msymbol_info): Use address style to print addresses.
8558         Use function name style to print executable text symbols.
8559         (expand_symtab_containing_pc): Use data_p.
8560         (find_pc_sect_compunit_symtab): Likewise.
8561
8562 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8563
8564         * breakpoint.c (describe_other_breakpoints): Use address style
8565         to print addresses.
8566         (say_where): Likewise.
8567
8568 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8569
8570         * ada-typeprint.c (print_func_type): Print function name
8571         style to print function name.
8572         * c-typeprint.c (c_print_type_1): Likewise.
8573
8574 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8575
8576         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8577         for execve.
8578
8579 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8580
8581         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8582         type_stack.
8583
8584 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8585
8586         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8587         TYPE_CODE_REF types.
8588
8589 2019-02-08  Jim Wilson  <jimw@sifive.com>
8590
8591         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8592         (riscv_linux_fregset): New.
8593         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8594
8595 2019-02-07  Tom Tromey  <tom@tromey.com>
8596
8597         * thread.c (thread_cancel_execution_command): Update.
8598         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8599         methods.
8600         (struct thread_fsm_ops): Remove.
8601         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8602         (thread_fsm_should_stop, thread_fsm_return_value)
8603         (thread_fsm_set_finished, thread_fsm_finished_p)
8604         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8605         Don't declare.
8606         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8607         * infrun.c (clear_proceed_status_thread)
8608         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8609         (print_stop_event): Update.
8610         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8611         Add constructor.
8612         (step_command_fsm_ops): Remove.
8613         (new_step_command_fsm): Remove.
8614         (step_1): Update.
8615         (step_command_fsm::should_stop): Rename from
8616         step_command_fsm_should_stop.
8617         (step_command_fsm::clean_up): Rename from
8618         step_command_fsm_clean_up.
8619         (step_command_fsm::do_async_reply_reason): Rename from
8620         step_command_fsm_async_reply_reason.
8621         (struct until_next_fsm): Inherit from thread_fsm.  Add
8622         constructor.
8623         (until_next_fsm_ops): Remove.
8624         (new_until_next_fsm): Remove.
8625         (until_next_fsm::should_stop): Rename from
8626         until_next_fsm_should_stop.
8627         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8628         (until_next_fsm::do_async_reply_reason): Rename from
8629         until_next_fsm_async_reply_reason.
8630         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8631         constructor.  Change type of breakpoint.
8632         (finish_command_fsm_ops): Remove.
8633         (new_finish_command_fsm): Remove.
8634         (finish_command_fsm::should_stop): Rename from
8635         finish_command_fsm_should_stop.
8636         (finish_command_fsm::clean_up): Rename from
8637         finish_command_fsm_clean_up.
8638         (finish_command_fsm::return_value): Rename from
8639         finish_command_fsm_return_value.
8640         (finish_command_fsm::do_async_reply_reason): Rename from
8641         finish_command_fsm_async_reply_reason.
8642         (finish_command): Update.
8643         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8644         Add constructor.
8645         (call_thread_fsm_ops): Remove.
8646         (call_thread_fsm::call_thread_fsm): Rename from
8647         new_call_thread_fsm.
8648         (call_thread_fsm::should_stop): Rename from
8649         call_thread_fsm_should_stop.
8650         (call_thread_fsm::should_notify_stop): Rename from
8651         call_thread_fsm_should_notify_stop.
8652         (run_inferior_call, call_function_by_hand_dummy): Update.
8653         * cli/cli-interp.c (should_print_stop_to_console): Update.
8654         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8655         Add constructor.  Change type of location_breakpoint,
8656         caller_breakpoint.
8657         (until_break_fsm_ops): Remove.
8658         (new_until_break_fsm): Remove.
8659         (until_break_fsm::should_stop): Rename from
8660         until_break_fsm_should_stop.
8661         (until_break_fsm::clean_up): Rename from
8662         until_break_fsm_clean_up.
8663         (until_break_fsm::do_async_reply_reason): Rename from
8664         until_break_fsm_async_reply_reason.
8665         (until_break_command): Update.
8666         * thread-fsm.c: Remove.
8667         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8668
8669 2019-02-07  Tom Tromey  <tom@tromey.com>
8670
8671         * yy-remap.h: Add include guard.
8672         * xtensa-tdep.h: Add include guard.
8673         * xcoffread.h: Rename include guard.
8674         * varobj-iter.h: Add include guard.
8675         * tui/tui.h: Rename include guard.
8676         * tui/tui-winsource.h: Rename include guard.
8677         * tui/tui-wingeneral.h: Rename include guard.
8678         * tui/tui-windata.h: Rename include guard.
8679         * tui/tui-win.h: Rename include guard.
8680         * tui/tui-stack.h: Rename include guard.
8681         * tui/tui-source.h: Rename include guard.
8682         * tui/tui-regs.h: Rename include guard.
8683         * tui/tui-out.h: Rename include guard.
8684         * tui/tui-layout.h: Rename include guard.
8685         * tui/tui-io.h: Rename include guard.
8686         * tui/tui-hooks.h: Rename include guard.
8687         * tui/tui-file.h: Rename include guard.
8688         * tui/tui-disasm.h: Rename include guard.
8689         * tui/tui-data.h: Rename include guard.
8690         * tui/tui-command.h: Rename include guard.
8691         * tic6x-tdep.h: Add include guard.
8692         * target/waitstatus.h: Rename include guard.
8693         * target/wait.h: Rename include guard.
8694         * target/target.h: Rename include guard.
8695         * target/resume.h: Rename include guard.
8696         * target-float.h: Rename include guard.
8697         * stabsread.h: Add include guard.
8698         * rs6000-tdep.h: Add include guard.
8699         * riscv-fbsd-tdep.h: Add include guard.
8700         * regformats/regdef.h: Rename include guard.
8701         * record.h: Rename include guard.
8702         * python/python.h: Rename include guard.
8703         * python/python-internal.h: Rename include guard.
8704         * python/py-stopevent.h: Rename include guard.
8705         * python/py-ref.h: Rename include guard.
8706         * python/py-record.h: Rename include guard.
8707         * python/py-record-full.h: Rename include guard.
8708         * python/py-record-btrace.h: Rename include guard.
8709         * python/py-instruction.h: Rename include guard.
8710         * python/py-events.h: Rename include guard.
8711         * python/py-event.h: Rename include guard.
8712         * procfs.h: Add include guard.
8713         * proc-utils.h: Add include guard.
8714         * p-lang.h: Add include guard.
8715         * or1k-tdep.h: Rename include guard.
8716         * observable.h: Rename include guard.
8717         * nto-tdep.h: Rename include guard.
8718         * nat/x86-linux.h: Rename include guard.
8719         * nat/x86-linux-dregs.h: Rename include guard.
8720         * nat/x86-gcc-cpuid.h: Add include guard.
8721         * nat/x86-dregs.h: Rename include guard.
8722         * nat/x86-cpuid.h: Rename include guard.
8723         * nat/ppc-linux.h: Rename include guard.
8724         * nat/mips-linux-watch.h: Rename include guard.
8725         * nat/linux-waitpid.h: Rename include guard.
8726         * nat/linux-ptrace.h: Rename include guard.
8727         * nat/linux-procfs.h: Rename include guard.
8728         * nat/linux-osdata.h: Rename include guard.
8729         * nat/linux-nat.h: Rename include guard.
8730         * nat/linux-namespaces.h: Rename include guard.
8731         * nat/linux-btrace.h: Rename include guard.
8732         * nat/glibc_thread_db.h: Rename include guard.
8733         * nat/gdb_thread_db.h: Rename include guard.
8734         * nat/gdb_ptrace.h: Rename include guard.
8735         * nat/fork-inferior.h: Rename include guard.
8736         * nat/amd64-linux-siginfo.h: Rename include guard.
8737         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8738         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8739         * nat/aarch64-linux.h: Rename include guard.
8740         * nat/aarch64-linux-hw-point.h: Rename include guard.
8741         * mn10300-tdep.h: Add include guard.
8742         * mips-linux-tdep.h: Add include guard.
8743         * mi/mi-parse.h: Rename include guard.
8744         * mi/mi-out.h: Rename include guard.
8745         * mi/mi-main.h: Rename include guard.
8746         * mi/mi-interp.h: Rename include guard.
8747         * mi/mi-getopt.h: Rename include guard.
8748         * mi/mi-console.h: Rename include guard.
8749         * mi/mi-common.h: Rename include guard.
8750         * mi/mi-cmds.h: Rename include guard.
8751         * mi/mi-cmd-break.h: Rename include guard.
8752         * m2-lang.h: Add include guard.
8753         * location.h: Rename include guard.
8754         * linux-record.h: Rename include guard.
8755         * linux-nat.h: Add include guard.
8756         * linux-fork.h: Add include guard.
8757         * i386-darwin-tdep.h: Rename include guard.
8758         * hppa-linux-offsets.h: Add include guard.
8759         * guile/guile.h: Rename include guard.
8760         * guile/guile-internal.h: Rename include guard.
8761         * gnu-nat.h: Rename include guard.
8762         * gdb-stabs.h: Rename include guard.
8763         * frv-tdep.h: Add include guard.
8764         * f-lang.h: Add include guard.
8765         * event-loop.h: Add include guard.
8766         * darwin-nat.h: Rename include guard.
8767         * cp-abi.h: Rename include guard.
8768         * config/sparc/nm-sol2.h: Rename include guard.
8769         * config/nm-nto.h: Rename include guard.
8770         * config/nm-linux.h: Add include guard.
8771         * config/i386/nm-i386gnu.h: Rename include guard.
8772         * config/djgpp/nl_types.h: Rename include guard.
8773         * config/djgpp/langinfo.h: Rename include guard.
8774         * compile/gcc-cp-plugin.h: Add include guard.
8775         * compile/gcc-c-plugin.h: Add include guard.
8776         * compile/compile.h: Rename include guard.
8777         * compile/compile-object-run.h: Rename include guard.
8778         * compile/compile-object-load.h: Rename include guard.
8779         * compile/compile-internal.h: Rename include guard.
8780         * compile/compile-cplus.h: Rename include guard.
8781         * compile/compile-c.h: Rename include guard.
8782         * common/xml-utils.h: Rename include guard.
8783         * common/x86-xstate.h: Rename include guard.
8784         * common/version.h: Rename include guard.
8785         * common/vec.h: Rename include guard.
8786         * common/tdesc.h: Rename include guard.
8787         * common/selftest.h: Rename include guard.
8788         * common/scoped_restore.h: Rename include guard.
8789         * common/scoped_mmap.h: Rename include guard.
8790         * common/scoped_fd.h: Rename include guard.
8791         * common/safe-iterator.h: Rename include guard.
8792         * common/run-time-clock.h: Rename include guard.
8793         * common/refcounted-object.h: Rename include guard.
8794         * common/queue.h: Rename include guard.
8795         * common/ptid.h: Rename include guard.
8796         * common/print-utils.h: Rename include guard.
8797         * common/preprocessor.h: Rename include guard.
8798         * common/pathstuff.h: Rename include guard.
8799         * common/observable.h: Rename include guard.
8800         * common/netstuff.h: Rename include guard.
8801         * common/job-control.h: Rename include guard.
8802         * common/host-defs.h: Rename include guard.
8803         * common/gdb_wait.h: Rename include guard.
8804         * common/gdb_vecs.h: Rename include guard.
8805         * common/gdb_unlinker.h: Rename include guard.
8806         * common/gdb_unique_ptr.h: Rename include guard.
8807         * common/gdb_tilde_expand.h: Rename include guard.
8808         * common/gdb_sys_time.h: Rename include guard.
8809         * common/gdb_string_view.h: Rename include guard.
8810         * common/gdb_splay_tree.h: Rename include guard.
8811         * common/gdb_setjmp.h: Rename include guard.
8812         * common/gdb_ref_ptr.h: Rename include guard.
8813         * common/gdb_optional.h: Rename include guard.
8814         * common/gdb_locale.h: Rename include guard.
8815         * common/gdb_assert.h: Rename include guard.
8816         * common/filtered-iterator.h: Rename include guard.
8817         * common/filestuff.h: Rename include guard.
8818         * common/fileio.h: Rename include guard.
8819         * common/environ.h: Rename include guard.
8820         * common/common-utils.h: Rename include guard.
8821         * common/common-types.h: Rename include guard.
8822         * common/common-regcache.h: Rename include guard.
8823         * common/common-inferior.h: Rename include guard.
8824         * common/common-gdbthread.h: Rename include guard.
8825         * common/common-exceptions.h: Rename include guard.
8826         * common/common-defs.h: Rename include guard.
8827         * common/common-debug.h: Rename include guard.
8828         * common/cleanups.h: Rename include guard.
8829         * common/buffer.h: Rename include guard.
8830         * common/btrace-common.h: Rename include guard.
8831         * common/break-common.h: Rename include guard.
8832         * cli/cli-utils.h: Rename include guard.
8833         * cli/cli-style.h: Rename include guard.
8834         * cli/cli-setshow.h: Rename include guard.
8835         * cli/cli-script.h: Rename include guard.
8836         * cli/cli-interp.h: Rename include guard.
8837         * cli/cli-decode.h: Rename include guard.
8838         * cli/cli-cmds.h: Rename include guard.
8839         * charset-list.h: Add include guard.
8840         * buildsym-legacy.h: Rename include guard.
8841         * bfin-tdep.h: Add include guard.
8842         * ax.h: Rename include guard.
8843         * arm-linux-tdep.h: Add include guard.
8844         * arm-fbsd-tdep.h: Add include guard.
8845         * arch/xtensa.h: Rename include guard.
8846         * arch/tic6x.h: Add include guard.
8847         * arch/i386.h: Add include guard.
8848         * arch/arm.h: Rename include guard.
8849         * arch/arm-linux.h: Rename include guard.
8850         * arch/arm-get-next-pcs.h: Rename include guard.
8851         * arch/amd64.h: Add include guard.
8852         * arch/aarch64-insn.h: Rename include guard.
8853         * arch-utils.h: Rename include guard.
8854         * annotate.h: Add include guard.
8855         * amd64-darwin-tdep.h: Rename include guard.
8856         * aarch64-linux-tdep.h: Add include guard.
8857         * aarch64-fbsd-tdep.h: Add include guard.
8858         * aarch32-linux-nat.h: Add include guard.
8859
8860 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8861
8862         * macrotab.c (macro_define_internal): New function that
8863         factorizes macro_define_object_internal and macro_define_function
8864         code.
8865         (macro_define_object_internal): Use macro_define_internal.
8866         (macro_define_function): Likewise.
8867
8868 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8869
8870         * macrocmd.c (extract_identifier): Return
8871         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8872         callers.
8873
8874 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8875
8876         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8877
8878 2019-02-05  Tom Tromey  <tom@tromey.com>
8879
8880         * target.c (target_stack::unpush): Move assertion earlier.
8881
8882 2019-01-30  Tom Tromey  <tom@tromey.com>
8883
8884         PR python/23615:
8885         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8886         (gdbpy_parse_and_eval): Likewise.
8887         * python/python-internal.h (gdbpy_allow_threads): New class.
8888
8889 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8890
8891         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8892         (aarch64_fbsd_fpregmap): Move earlier.
8893         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8894         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8895         instead of individual calls to trad_frame_set_reg_addr.
8896         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8897         earlier.
8898         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8899         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8900         instead of individual calls to trad_frame_set_reg_addr.
8901
8902 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8903
8904         * CONTRIBUTE: Replace contribution list with wiki link.
8905
8906 2019-01-25  Tom Tromey  <tom@tromey.com>
8907
8908         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8909
8910 2019-01-25  Tom Tromey  <tom@tromey.com>
8911
8912         * xtensa-linux-nat.c: Fix common/ includes.
8913         * xml-support.h: Fix common/ includes.
8914         * xml-support.c: Fix common/ includes.
8915         * x86-linux-nat.c: Fix common/ includes.
8916         * windows-nat.c: Fix common/ includes.
8917         * varobj.h: Fix common/ includes.
8918         * varobj.c: Fix common/ includes.
8919         * value.c: Fix common/ includes.
8920         * valops.c: Fix common/ includes.
8921         * utils.c: Fix common/ includes.
8922         * unittests/xml-utils-selftests.c: Fix common/ includes.
8923         * unittests/utils-selftests.c: Fix common/ includes.
8924         * unittests/unpack-selftests.c: Fix common/ includes.
8925         * unittests/tracepoint-selftests.c: Fix common/ includes.
8926         * unittests/style-selftests.c: Fix common/ includes.
8927         * unittests/string_view-selftests.c: Fix common/ includes.
8928         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8929         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8930         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8931         * unittests/rsp-low-selftests.c: Fix common/ includes.
8932         * unittests/parse-connection-spec-selftests.c: Fix common/
8933         includes.
8934         * unittests/optional-selftests.c: Fix common/ includes.
8935         * unittests/offset-type-selftests.c: Fix common/ includes.
8936         * unittests/observable-selftests.c: Fix common/ includes.
8937         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8938         * unittests/memrange-selftests.c: Fix common/ includes.
8939         * unittests/memory-map-selftests.c: Fix common/ includes.
8940         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8941         * unittests/function-view-selftests.c: Fix common/ includes.
8942         * unittests/environ-selftests.c: Fix common/ includes.
8943         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8944         * unittests/common-utils-selftests.c: Fix common/ includes.
8945         * unittests/cli-utils-selftests.c: Fix common/ includes.
8946         * unittests/array-view-selftests.c: Fix common/ includes.
8947         * ui-file.c: Fix common/ includes.
8948         * tui/tui-io.c: Fix common/ includes.
8949         * tracepoint.h: Fix common/ includes.
8950         * tracepoint.c: Fix common/ includes.
8951         * tracefile-tfile.c: Fix common/ includes.
8952         * top.h: Fix common/ includes.
8953         * top.c: Fix common/ includes.
8954         * thread.c: Fix common/ includes.
8955         * target/waitstatus.h: Fix common/ includes.
8956         * target/waitstatus.c: Fix common/ includes.
8957         * target.h: Fix common/ includes.
8958         * target.c: Fix common/ includes.
8959         * target-memory.c: Fix common/ includes.
8960         * target-descriptions.c: Fix common/ includes.
8961         * symtab.h: Fix common/ includes.
8962         * symfile.c: Fix common/ includes.
8963         * stap-probe.c: Fix common/ includes.
8964         * spu-linux-nat.c: Fix common/ includes.
8965         * sparc-nat.c: Fix common/ includes.
8966         * source.c: Fix common/ includes.
8967         * solib.c: Fix common/ includes.
8968         * solib-target.c: Fix common/ includes.
8969         * ser-unix.c: Fix common/ includes.
8970         * ser-tcp.c: Fix common/ includes.
8971         * ser-pipe.c: Fix common/ includes.
8972         * ser-base.c: Fix common/ includes.
8973         * selftest-arch.c: Fix common/ includes.
8974         * s12z-tdep.c: Fix common/ includes.
8975         * rust-exp.y: Fix common/ includes.
8976         * rs6000-aix-tdep.c: Fix common/ includes.
8977         * riscv-tdep.c: Fix common/ includes.
8978         * remote.c: Fix common/ includes.
8979         * remote-notif.h: Fix common/ includes.
8980         * remote-fileio.h: Fix common/ includes.
8981         * remote-fileio.c: Fix common/ includes.
8982         * regcache.h: Fix common/ includes.
8983         * regcache.c: Fix common/ includes.
8984         * record-btrace.c: Fix common/ includes.
8985         * python/python.c: Fix common/ includes.
8986         * python/py-type.c: Fix common/ includes.
8987         * python/py-inferior.c: Fix common/ includes.
8988         * progspace.h: Fix common/ includes.
8989         * producer.c: Fix common/ includes.
8990         * procfs.c: Fix common/ includes.
8991         * proc-api.c: Fix common/ includes.
8992         * printcmd.c: Fix common/ includes.
8993         * ppc-linux-nat.c: Fix common/ includes.
8994         * parser-defs.h: Fix common/ includes.
8995         * osdata.c: Fix common/ includes.
8996         * obsd-nat.c: Fix common/ includes.
8997         * nat/x86-linux.c: Fix common/ includes.
8998         * nat/x86-linux-dregs.c: Fix common/ includes.
8999         * nat/x86-dregs.h: Fix common/ includes.
9000         * nat/x86-dregs.c: Fix common/ includes.
9001         * nat/ppc-linux.c: Fix common/ includes.
9002         * nat/mips-linux-watch.h: Fix common/ includes.
9003         * nat/mips-linux-watch.c: Fix common/ includes.
9004         * nat/linux-waitpid.c: Fix common/ includes.
9005         * nat/linux-ptrace.h: Fix common/ includes.
9006         * nat/linux-ptrace.c: Fix common/ includes.
9007         * nat/linux-procfs.c: Fix common/ includes.
9008         * nat/linux-personality.c: Fix common/ includes.
9009         * nat/linux-osdata.c: Fix common/ includes.
9010         * nat/linux-namespaces.c: Fix common/ includes.
9011         * nat/linux-btrace.h: Fix common/ includes.
9012         * nat/linux-btrace.c: Fix common/ includes.
9013         * nat/fork-inferior.c: Fix common/ includes.
9014         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9015         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9016         * nat/aarch64-linux.c: Fix common/ includes.
9017         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9018         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9019         * namespace.h: Fix common/ includes.
9020         * mips-linux-tdep.c: Fix common/ includes.
9021         * minsyms.c: Fix common/ includes.
9022         * mi/mi-parse.h: Fix common/ includes.
9023         * mi/mi-main.c: Fix common/ includes.
9024         * mi/mi-cmd-env.c: Fix common/ includes.
9025         * memrange.h: Fix common/ includes.
9026         * memattr.c: Fix common/ includes.
9027         * maint.h: Fix common/ includes.
9028         * maint.c: Fix common/ includes.
9029         * main.c: Fix common/ includes.
9030         * machoread.c: Fix common/ includes.
9031         * location.c: Fix common/ includes.
9032         * linux-thread-db.c: Fix common/ includes.
9033         * linux-nat.c: Fix common/ includes.
9034         * linux-fork.c: Fix common/ includes.
9035         * inline-frame.c: Fix common/ includes.
9036         * infrun.c: Fix common/ includes.
9037         * inflow.c: Fix common/ includes.
9038         * inferior.h: Fix common/ includes.
9039         * inferior.c: Fix common/ includes.
9040         * infcmd.c: Fix common/ includes.
9041         * inf-ptrace.c: Fix common/ includes.
9042         * inf-child.c: Fix common/ includes.
9043         * ia64-linux-nat.c: Fix common/ includes.
9044         * i387-tdep.c: Fix common/ includes.
9045         * i386-tdep.c: Fix common/ includes.
9046         * i386-linux-tdep.c: Fix common/ includes.
9047         * i386-linux-nat.c: Fix common/ includes.
9048         * i386-go32-tdep.c: Fix common/ includes.
9049         * i386-fbsd-tdep.c: Fix common/ includes.
9050         * i386-fbsd-nat.c: Fix common/ includes.
9051         * guile/scm-type.c: Fix common/ includes.
9052         * guile/guile.c: Fix common/ includes.
9053         * go32-nat.c: Fix common/ includes.
9054         * gnu-nat.c: Fix common/ includes.
9055         * gdbthread.h: Fix common/ includes.
9056         * gdbarch-selftests.c: Fix common/ includes.
9057         * gdb_usleep.c: Fix common/ includes.
9058         * gdb_select.h: Fix common/ includes.
9059         * gdb_bfd.c: Fix common/ includes.
9060         * gcore.c: Fix common/ includes.
9061         * fork-child.c: Fix common/ includes.
9062         * findvar.c: Fix common/ includes.
9063         * fbsd-nat.c: Fix common/ includes.
9064         * event-top.c: Fix common/ includes.
9065         * event-loop.c: Fix common/ includes.
9066         * dwarf2read.c: Fix common/ includes.
9067         * dwarf2loc.c: Fix common/ includes.
9068         * dwarf2-frame.c: Fix common/ includes.
9069         * dwarf-index-cache.c: Fix common/ includes.
9070         * dtrace-probe.c: Fix common/ includes.
9071         * disasm-selftests.c: Fix common/ includes.
9072         * defs.h: Fix common/ includes.
9073         * csky-tdep.c: Fix common/ includes.
9074         * cp-valprint.c: Fix common/ includes.
9075         * cp-support.h: Fix common/ includes.
9076         * cp-support.c: Fix common/ includes.
9077         * corelow.c: Fix common/ includes.
9078         * completer.h: Fix common/ includes.
9079         * completer.c: Fix common/ includes.
9080         * compile/compile.c: Fix common/ includes.
9081         * compile/compile-loc2c.c: Fix common/ includes.
9082         * compile/compile-cplus-types.c: Fix common/ includes.
9083         * compile/compile-cplus-symbols.c: Fix common/ includes.
9084         * command.h: Fix common/ includes.
9085         * cli/cli-dump.c: Fix common/ includes.
9086         * cli/cli-cmds.c: Fix common/ includes.
9087         * charset.c: Fix common/ includes.
9088         * build-id.c: Fix common/ includes.
9089         * btrace.h: Fix common/ includes.
9090         * btrace.c: Fix common/ includes.
9091         * breakpoint.h: Fix common/ includes.
9092         * breakpoint.c: Fix common/ includes.
9093         * ax.h:
9094         (enum agent_op): Fix common/ includes.
9095         * ax-general.c (struct aop_map): Fix common/ includes.
9096         * ax-gdb.c: Fix common/ includes.
9097         * auxv.c: Fix common/ includes.
9098         * auto-load.c: Fix common/ includes.
9099         * arm-tdep.c: Fix common/ includes.
9100         * arch/riscv.c: Fix common/ includes.
9101         * arch/ppc-linux-common.c: Fix common/ includes.
9102         * arch/i386.c: Fix common/ includes.
9103         * arch/arm.c: Fix common/ includes.
9104         * arch/arm-linux.c: Fix common/ includes.
9105         * arch/arm-get-next-pcs.c: Fix common/ includes.
9106         * arch/amd64.c: Fix common/ includes.
9107         * arch/aarch64.c: Fix common/ includes.
9108         * arch/aarch64-insn.c: Fix common/ includes.
9109         * arch-utils.c: Fix common/ includes.
9110         * amd64-windows-tdep.c: Fix common/ includes.
9111         * amd64-tdep.c: Fix common/ includes.
9112         * amd64-sol2-tdep.c: Fix common/ includes.
9113         * amd64-obsd-tdep.c: Fix common/ includes.
9114         * amd64-nbsd-tdep.c: Fix common/ includes.
9115         * amd64-linux-tdep.c: Fix common/ includes.
9116         * amd64-linux-nat.c: Fix common/ includes.
9117         * amd64-fbsd-tdep.c: Fix common/ includes.
9118         * amd64-fbsd-nat.c: Fix common/ includes.
9119         * amd64-dicos-tdep.c: Fix common/ includes.
9120         * amd64-darwin-tdep.c: Fix common/ includes.
9121         * agent.c: Fix common/ includes.
9122         * ada-lang.h: Fix common/ includes.
9123         * ada-lang.c: Fix common/ includes.
9124         * aarch64-tdep.c: Fix common/ includes.
9125
9126 2019-01-25  Tom Tromey  <tom@tromey.com>
9127
9128         * common/create-version.sh: Use common/version.h.
9129
9130 2019-01-24  Pedro Alves  <palves@redhat.com>
9131
9132         * infrun.c (signal_stop, signal_print, signal_program)
9133         (signal_catch, signal_pass): Now arrays instead of pointers.
9134         (update_signals_program_target, do_target_resume)
9135         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9136         * linux-nat.c (linux_nat_target::pass_signals)
9137         (linux_nat_target::create_inferior, linux_nat_target::attach):
9138         Adjust.
9139         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9140         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9141         * procfs.c (procfs_target::pass_signals): Adjust.
9142         * record-full.c (record_full_target::resume): Adjust.
9143         * remote.c (remote_target::pass_signals)
9144         (remote_target::program_signals): Adjust.
9145         * target-debug.h (target_debug_print_signals): Now takes a
9146         gdb::array_view as parameter.  Adjust.
9147         * target.h (target_ops) <pass_signals, program_signals>: Replace
9148         pointer and length parameters with gdb::array_view.
9149         (target_pass_signals, target_program_signals): Likewise.
9150         * target-delegates.c: Regenerate.
9151
9152 2019-01-24  Pedro Alves  <palves@redhat.com>
9153
9154         * common/forward-scope-exit.h
9155         (forward_scope_exit::forward_scope_exit): Pass arguments to
9156         m_bind_function directly, instead of creating a std::bind and
9157         copying that.
9158
9159 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9160
9161         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9162         for static members.
9163         (pass_in_v_vfp_candidate): Likewise.
9164
9165 2019-01-23  Tom Tromey  <tom@tromey.com>
9166             Pedro Alves  <palves@redhat.com>
9167
9168         * regcache.c (class regcache_invalidator): Remove.
9169         (regcache::raw_write): Use make_scope_exit.
9170
9171 2019-01-23  Tom Tromey  <tom@tromey.com>
9172
9173         * ui-out.h (class ui_out_emit_type): Update comment.
9174
9175 2019-01-23  Tom Tromey  <tom@tromey.com>
9176
9177         * infrun.c (fetch_inferior_event): Update comment.
9178
9179 2019-01-23  Tom Tromey  <tom@tromey.com>
9180             Pedro Alves  <palves@redhat.com>
9181
9182         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9183         parameter.
9184         (fetch_inferior_event): Use SCOPE_EXIT.
9185
9186
9187 2019-01-23  Tom Tromey  <tom@tromey.com>
9188             Pedro Alves  <palves@redhat.com>
9189
9190         * infrun.c (disable_thread_events): Delete.
9191         (stop_all_threads): Use SCOPE_EXIT.
9192
9193 2019-01-23  Tom Tromey  <tom@tromey.com>
9194             Pedro Alves  <palves@redhat.com>
9195
9196         * symfile.c: Include forward-scope-exit.h.
9197         (clear_symtab_users_cleanup): Replace forward declaration with
9198         a FORWARD_SCOPE_EXIT.
9199         (syms_from_objfile_1): Use the forward_scope_exit and
9200         gdb::optional instead of cleanup_function.
9201         (reread_symbols): Use the forward_scope_exit instead of
9202         cleanup_function.
9203         (clear_symtab_users_cleanup): Remove function.
9204
9205 2019-01-23  Tom Tromey  <tom@tromey.com>
9206             Pedro Alves  <palves@redhat.com>
9207
9208         * linux-nat.c: Include scope-exit.h.
9209         (cleanup_target_stop): Remove.
9210         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9211         SCOPE_EXIT.
9212
9213 2019-01-23  Tom Tromey  <tom@tromey.com>
9214             Pedro Alves  <palves@redhat.com>
9215
9216         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9217         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9218
9219 2019-01-23  Tom Tromey  <tom@tromey.com>
9220             Andrew Burgess  <andrew.burgess@embecosm.com>
9221             Pedro Alves  <palves@redhat.com>
9222
9223         * infrun.c (fetch_inferior_event): Use scope_exit.
9224         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9225         * top.c (execute_command): Use scope_exit.
9226         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9227         * utils.c (do_bpstat_clear_actions_cleanup)
9228         (make_bpstat_clear_actions_cleanup): Remove.
9229
9230 2019-01-23  Tom Tromey  <tom@tromey.com>
9231             Pedro Alves  <palves@redhat.com>
9232
9233         * infrun.c: Include "common/scope-exit.h"
9234         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9235         (wait_for_inferior): Use SCOPE_EXIT.
9236         (fetch_inferior_event): Use scope_exit.
9237
9238 2019-01-23  Tom Tromey  <tom@tromey.com>
9239             Pedro Alves  <palves@redhat.com>
9240
9241         * breakpoint.c (create_breakpoint): Remove cleanup.
9242
9243 2019-01-23  Tom Tromey  <tom@tromey.com>
9244             Andrew Burgess  <andrew.burgess@embecosm.com>
9245             Pedro Alves  <palves@redhat.com>
9246
9247 2019-01-23  Pedro Alves  <palves@redhat.com>
9248
9249         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9250
9251 2019-01-23  Pedro Alves  <palves@redhat.com>
9252             Andrew Burgess  <andrew.burgess@embecosm.com>
9253
9254         * gdbthread.h: Include "common/forward-scope-exit.h".
9255         (scoped_finish_thread_state): Redefine custom class in terms of
9256         forward_scope_exit.
9257
9258 2019-01-23  Pedro Alves  <palves@redhat.com>
9259             Andrew Burgess  <andrew.burgess@embecosm.com>
9260
9261         * common/forward-scope-exit.h: New file.
9262
9263 2019-01-23  Pedro Alves  <palves@redhat.com>
9264             Andrew Burgess  <andrew.burgess@embecosm.com>
9265             Tom Tromey  <tom@tromey.com>
9266
9267         * common/scope-exit.h: New file.
9268
9269 2019-01-23  Pedro Alves  <palves@redhat.com>
9270
9271         * common/preprocessor.h (ESC): Rename to ...
9272         (ESC_PARENS): ... this.
9273         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9274         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9275
9276 2019-01-23  Tom Tromey  <tom@tromey.com>
9277
9278         * language.h (class scoped_switch_to_sym_language_if_auto):
9279         Initialize m_lang in both cases.
9280
9281 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9282
9283         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9284         with XCNEW.
9285
9286 2019-01-22  Tom Tromey  <tom@tromey.com>
9287
9288         * corelow.c: Do not include sys/file.h.
9289
9290 2019-01-22  Tom Tromey  <tom@tromey.com>
9291
9292         * tui/tui-wingeneral.h: Include gdb_curses.h.
9293
9294 2019-01-22  Tom Tromey  <tom@tromey.com>
9295
9296         * source-cache.h (class source_cache) <get_source_lines,
9297         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9298
9299 2019-01-22  Tom Tromey  <tom@tromey.com>
9300
9301         * remote-fileio.h (struct remote_target): Declare.
9302
9303 2019-01-22  Tom Tromey  <tom@tromey.com>
9304
9305         * python/py-arch.c: Do not include py-ref.h.
9306         * python/py-bpevent.c: Do not include py-ref.h.
9307         * python/py-cmd.c: Do not include py-ref.h.
9308         * python/py-continueevent.c: Do not include py-ref.h.
9309         * python/py-event.h: Do not include py-ref.h.
9310         * python/py-evtregistry.c: Do not include py-ref.h.
9311         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9312         * python/py-frame.c: Do not include py-ref.h.
9313         * python/py-framefilter.c: Do not include py-ref.h.
9314         * python/py-function.c: Do not include py-ref.h.
9315         * python/py-infevents.c: Do not include py-ref.h.
9316         * python/py-linetable.c: Do not include py-ref.h.
9317         * python/py-objfile.c: Do not include py-ref.h.
9318         * python/py-param.c: Do not include py-ref.h.
9319         * python/py-prettyprint.c: Do not include py-ref.h.
9320         * python/py-progspace.c: Do not include py-ref.h.
9321         * python/py-symbol.c: Do not include py-ref.h.
9322         * python/py-symtab.c: Do not include py-ref.h.
9323         * python/py-type.c: Do not include py-ref.h.
9324         * python/py-unwind.c: Do not include py-ref.h.
9325         * python/py-utils.c: Do not include py-ref.h.
9326         * python/py-value.c: Do not include py-ref.h.
9327         * python/py-varobj.c: Do not include py-ref.h.
9328         * python/py-xmethods.c: Do not include py-ref.h.
9329         * python/python.c: Do not include py-ref.h.
9330         * varobj.c: Do not include py-ref.h.
9331
9332 2019-01-22  Tom Tromey  <tom@tromey.com>
9333
9334         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9335         keyword for bcache.
9336
9337 2019-01-22  Tom Tromey  <tom@tromey.com>
9338
9339         * compile/compile-cplus-types.c: Remove a comment by #include.
9340
9341 2019-01-22  Tom Tromey  <tom@tromey.com>
9342
9343         * compile/gcc-c-plugin.h: Include compile-internal.h.
9344
9345 2019-01-22  Tom Tromey  <tom@tromey.com>
9346
9347         * stabsread.c (EXTERN): Do not define.
9348         (symnum, next_symbol_text_func, processing_gcc_compilation)
9349         (within_function, global_sym_chain, global_stabs)
9350         (previous_stab_code, this_object_header_files)
9351         (n_this_object_header_files)
9352         (n_allocated_this_object_header_files): Define.
9353         * stabsread.h (EXTERN): Never define.  Use "extern".
9354
9355 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9356
9357         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9358         history_value.
9359
9360 2019-01-21  Tom Tromey  <tom@tromey.com>
9361
9362         * ui-out.c: Fix includes.
9363         * tui/tui-source.c: Fix includes.
9364         * target.c: Fix includes.
9365         * remote.c: Fix includes.
9366         * regcache.c: Fix includes.
9367         * python/py-block.c: Fix includes.
9368         * printcmd.c: Fix includes.
9369         * or1k-tdep.c: Fix includes.
9370         * mi/mi-main.c: Fix includes.
9371         * m32r-tdep.c: Fix includes.
9372         * csky-tdep.c: Fix includes.
9373         * compile/compile-cplus-types.c: Fix includes.
9374         * cli/cli-interp.c: Fix includes.
9375
9376 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9377
9378         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9379         for padding.
9380
9381 2019-01-16  Tom Tromey  <tom@tromey.com>
9382
9383         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9384         earlier.
9385         (struct objfile) <msymbols_range>: Move from top level.
9386         <msymbols>: New method.
9387         (class objfile_msymbols): Remove.
9388         * symtab.c (default_collect_symbol_completion_matches_break_on):
9389         Update.
9390         * symmisc.c (dump_msymbols): Update.
9391         * stabsread.c (scan_file_globals): Update.
9392         * objc-lang.c (info_selectors_command, info_classes_command)
9393         (find_methods): Update.
9394         * minsyms.c (find_solib_trampoline_target): Update.
9395         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9396         * coffread.c (coff_symfile_read): Update.
9397         * ada-lang.c (ada_lookup_simple_minsym)
9398         (ada_collect_symbol_completion_matches): Update.
9399
9400 2019-01-16  Tom Tromey  <tom@tromey.com>
9401
9402         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9403         type.  Remove no-argument constructor.
9404         <iterator::operator++>: Simplify.
9405         <begin>: Update.
9406         <end>: Use minimal_symbol_count.
9407
9408 2019-01-16  Tom Tromey  <tom@tromey.com>
9409
9410         * objfiles.h (struct objfile) <psymtabs>: New method.
9411         (class objfile_psymtabs): Remove.
9412         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9413         typedef.
9414         <range>: New method.
9415         (require_partial_symbols): Change return type.
9416         * psymtab.c (require_partial_symbols)
9417         (psym_expand_symtabs_matching): Update.
9418         * mdebugread.c (parse_partial_symbols): Update.
9419         * dbxread.c (dbx_end_psymtab): Update.
9420
9421 2019-01-15  Tom Tromey  <tom@tromey.com>
9422
9423         * symtab.c (lookup_objfile_from_block)
9424         (lookup_symbol_in_objfile_symtabs)
9425         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9426         (find_line_symtab, info_sources_command)
9427         (default_collect_symbol_completion_matches_break_on)
9428         (make_source_files_completion_list): Update.
9429         * symmisc.c (print_objfile_statistics, dump_objfile)
9430         (maintenance_print_symbols, maintenance_info_symtabs)
9431         (maintenance_check_symtabs, maintenance_info_line_tables):
9432         Update.
9433         * source.c (select_source_symtab)
9434         (forget_cached_source_info_for_objfile): Update.
9435         * objfiles.h (class objfile_compunits): Remove.
9436         (struct objfile) <compunits_range>: New typedef.
9437         (compunits): New method.
9438         * objfiles.c (objfile_relocate1): Update.
9439         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9440         * maint.c (count_symtabs_and_blocks): Update.
9441         * linespec.c (iterate_over_all_matching_symtabs): Update.
9442         * cp-support.c (add_symbol_overload_list_qualified): Update.
9443         * coffread.c (coff_symtab_read): Update.
9444         * ada-lang.c (add_nonlocal_symbols)
9445         (ada_collect_symbol_completion_matches)
9446         (ada_add_global_exceptions): Update.
9447
9448 2019-01-15  Tom Tromey  <tom@tromey.com>
9449
9450         * progspace.h (program_space) <objfiles_safe_range>: New
9451         typedef.
9452         <objfiles_safe>: New method.
9453         * objfiles.h (class all_objfiles_safe): Remove.
9454         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9455         * jit.c (jit_inferior_exit_hook): Update.
9456
9457 2019-01-17  Tom Tromey  <tom@tromey.com>
9458
9459         * progspace.h (program_space) <objfiles_range>: New typedef.
9460         <objfiles>: New method.
9461         <objfiles_head>: Rename from objfiles.
9462         (object_files): Update.
9463         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9464         * guile/scm-pretty-print.c
9465         (ppscm_find_pretty_printer_from_objfiles): Update.
9466         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9467         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9468         Update.
9469         * python/py-progspace.c (pspy_get_objfiles): Update.
9470         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9471         Update.
9472         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9473         (objfpy_lookup_objfile_by_build_id): Update.
9474         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9475         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9476         Update.
9477         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9478         (expand_symtab_containing_pc, lookup_objfile_from_block)
9479         (lookup_static_symbol, basic_lookup_transparent_type)
9480         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9481         (find_line_symtab, info_sources_command)
9482         (default_collect_symbol_completion_matches_break_on)
9483         (make_source_files_completion_list, find_main_name): Update.
9484         * symmisc.c (print_symbol_bcache_statistics)
9485         (print_objfile_statistics, maintenance_print_symbols)
9486         (maintenance_print_msymbols, maintenance_print_objfiles)
9487         (maintenance_info_symtabs, maintenance_check_symtabs)
9488         (maintenance_expand_symtabs, maintenance_info_line_tables):
9489         Update.
9490         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9491         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9492         (map_overlay_command, unmap_overlay_command)
9493         (simple_overlay_update, expand_symtabs_matching)
9494         (map_symbol_filenames): Update.
9495         * symfile-debug.c (set_debug_symfile): Update.
9496         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9497         Update.
9498         * source.c (select_source_symtab, forget_cached_source_info):
9499         Update.
9500         * solib.c (solib_read_symbols): Update.
9501         * solib-spu.c (append_ocl_sos): Update.
9502         * psymtab.c (maintenance_print_psymbols)
9503         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9504         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9505         * printcmd.c (info_symbol_command): Update.
9506         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9507         Update.
9508         * objfiles.h (class all_objfiles): Remove.
9509         * objfiles.c (have_partial_symbols, have_full_symbols)
9510         (have_minimal_symbols, qsort_cmp, update_section_map)
9511         (shared_objfile_contains_address_p)
9512         (default_iterate_over_objfiles_in_search_order): Update.
9513         * objc-lang.c (info_selectors_command, info_classes_command)
9514         (find_methods): Update.
9515         * minsyms.c (find_solib_trampoline_target): Update.
9516         * maint.c (maintenance_info_sections)
9517         (maintenance_translate_address, count_symtabs_and_blocks):
9518         Update.
9519         * main.c (captured_main_1): Update.
9520         * linux-thread-db.c (try_thread_db_load_from_pdir)
9521         (has_libpthread): Update.
9522         * linespec.c (iterate_over_all_matching_symtabs)
9523         (search_minsyms_for_name): Update.
9524         * jit.c (jit_find_objf_with_entry_addr): Update.
9525         * hppa-tdep.c (find_unwind_entry)
9526         (hppa_lookup_stub_minimal_symbol): Update.
9527         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9528         Update.
9529         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9530         (elf_gnu_ifunc_resolve_by_got): Update.
9531         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9532         * dwarf-index-write.c (save_gdb_index_command): Update.
9533         * cp-support.c (add_symbol_overload_list_qualified): Update.
9534         * breakpoint.c (create_overlay_event_breakpoint)
9535         (create_longjmp_master_breakpoint)
9536         (create_std_terminate_master_breakpoint)
9537         (create_exception_master_breakpoint): Update.
9538         * blockframe.c (find_pc_partial_function): Update.
9539         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9540         (ada_collect_symbol_completion_matches)
9541         (ada_add_global_exceptions): Update.
9542
9543 2019-01-17  Tom Tromey  <tom@tromey.com>
9544
9545         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9546         declare VEC.
9547         (solib_target_parse_libraries): Change return type.
9548         (library_list_start_segment, library_list_start_section)
9549         (library_list_end_library, library_list_start_library); Update.
9550         (solib_target_free_library_list): Remove.
9551         (solib_target_parse_libraries): Remove cleanup.  Change return
9552         type.
9553         (solib_target_current_sos): Update.
9554
9555 2019-01-17  Tom Tromey  <tromey@bapiya>
9556
9557         * valprint.c: Replace "the the" with "the".
9558         * symtab.c: Replace "the the" with "the".
9559         * solib.c: Replace "the the" with "the".
9560         * solib-dsbt.c: Replace "the the" with "the".
9561         * linespec.c: Replace "the the" with "the".
9562         * dwarf2loc.h: Replace "the the" with "the".
9563         * amd64-windows-tdep.c: Replace "the the" with "the".
9564         * aarch64-tdep.c: Replace "the the" with "the".
9565
9566 2019-01-16  Keith Seitz  <keiths@redhat.com>
9567
9568         PR gdb/23773
9569         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9570         <builder>: Rename to ..
9571         <m_builder>: ... this and make private.
9572         (dwarf2_cu::get_builder): New method.  Change all users of
9573         `builder' to use this method.
9574         (dwarf2_start_symtab): Move to ...
9575         (dwarf2_cu::start_symtab): ... here.  Update all callers
9576         (setup_type_unit_groups): Move to ...
9577         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9578         callers.
9579         (dwarf2_cu::reset_builder): New method.
9580         (process_full_compunit, process_full_type_unit): Use
9581         dwarf2_cu::reset_builder.
9582         (follow_die_offset): Record the ancestor CU if it is different
9583         from the followed DIE's CU.
9584         (follow_die_sig_1): Likewise.
9585
9586 2019-01-15  Tom Tromey  <tom@tromey.com>
9587
9588         * remote.c (class remote_state) <buf>: Now a char_vector.
9589         <buf_size>: Remove.
9590         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9591         parameter.
9592         (remote_target::getpkt_or_notif_sane_1)
9593         (remote_target::getpkt_sane)
9594         (remote_target::getpkt_or_notif_sane): Likewise.
9595         (class remote_target) <putpkt>: New overload.
9596         (remote_target::read_frame): Change type of "buf_p".  Remove
9597         sizeof_p parameter.
9598         (packet_ok): New overload.
9599         (packet_check_result): New overload.
9600         Update all uses.
9601
9602 2019-01-14  Tom Tromey  <tom@tromey.com>
9603
9604         * remote-notif.c (handle_notification, remote_notif_ack)
9605         (remote_notif_parse): Make "buf" const.
9606         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9607         const.
9608         (remote_notif_parse, remote_notif_ack, handle_notification):
9609         Likewise.
9610         * remote.c (remote_notif_stop_parse): Make "buf" const.
9611         (remote_target::remote_parse_stop_reply): Make "buf" const.
9612         (remote_notif_stop_ack): Make "buf" const.
9613
9614 2019-01-14  Tom Tromey  <tom@tromey.com>
9615
9616         * remote.c (remote_console_output): Make parameter const.
9617
9618 2019-01-14  Tom Tromey  <tom@tromey.com>
9619
9620         * target-debug.h (target_debug_print_signals): Constify.
9621         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9622         * procfs.c (procfs_target::pass_signals): Update.
9623         * linux-nat.c (linux_nat_target::pass_signals): Update.
9624         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9625         * target-delegates.c: Rebuild.
9626         * remote.c (remote_target::program_signals): Update.
9627         (remote_target::pass_signals): Update.
9628         * target.c (target_pass_signals): Constify argument.
9629         (target_program_signals): Likewise.
9630         * target.h (struct target_ops) <pass_signals, program_signals>:
9631         Constify argument.
9632         (target_pass_signals, target_program_signals): Constify argument.
9633
9634 2019-01-14  Tom Tromey  <tom@tromey.com>
9635
9636         PR tui/28819:
9637         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9638
9639 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9640
9641         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9642         field.
9643         * rs6000-tdep.c: Include reggroups.h.
9644         (IS_V_ALIAS_PSEUDOREG): Define.
9645         (rs6000_register_name): Return names for the "vX" aliases.
9646         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9647         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9648         aliases.  Call default_register_reggroup_p for all other
9649         pseudo-registers.
9650         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9651         New functions.
9652         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9653         Handle "vX" aliases.
9654         (v_alias_pseudo_register_collect): New function.
9655         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9656         (rs6000_gdbarch_init): Initialize "vX" aliases as
9657         pseudo-registers.  Restore registration of
9658         rs6000_pseudo_register_reggroup_p with
9659         set_tdesc_pseudo_register_reggroup_p.
9660
9661 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9662
9663         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9664         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9665         set_gdbarch_num_pseudo_regs.
9666
9667 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9668
9669         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9670         Remove arg prefixname, add do_set and do_show.
9671         Add member functions set_list and show_list.
9672         * cli/cli-style.c (class cli_style_option): Update accordingly.
9673         (style_set_list): Move to file scope.
9674         (style_show_list): Likewise.
9675         (set_style): Call help_list.
9676         (show_style): Call cmd_show_list.
9677         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9678         Update to use the new macro.
9679
9680 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9681
9682         * ada-lang.c (_initialize_ada_language): Expand the help text
9683         for the "catch exception" command.
9684
9685 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9686
9687         * symtab.c (matching_obj_sections): Initialize obj,
9688         declare it closer to its usage.
9689
9690 2019-01-10  Tom Tromey  <tom@tromey.com>
9691
9692         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9693         (basic_inf_threads_range): Remove.
9694         (inf_threads_range, inf_non_exited_threads_range)
9695         (safe_inf_threads_range): Use next_adapter.
9696
9697 2019-01-10  Keith Seitz  <keiths@redhat.com>
9698
9699         PR gdb/23712
9700         PR symtab/23010
9701         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9702         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9703
9704 2019-01-10  Keith Seitz  <keiths@redhat.com>
9705
9706         PR gdb/23712
9707         PR symtab/23010
9708         * dictionary.c (pending_to_vector): Remove.
9709         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9710         Remove _1 suffix, replacing functions of the same name.  Update
9711         all callers.
9712         (dict_create_hashed, dict_create_hashed_expandable)
9713         (dict_create_linear, dict_create_linear_expandable, dict_free)
9714         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9715         Make functions static.
9716
9717 2019-01-10  Keith Seitz  <keiths@redhat.com>
9718
9719         PR gdb/23712
9720         PR symtab/23010
9721         * dictionary.h (struct dictionary): Replace declaration with
9722         multidictionary.
9723         (dict_create_hashed, dict_create_hashed_expandable)
9724         (dict_create_linear, dict_create_linear_expandable)
9725         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9726         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9727         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9728         taking multidictionary argument.
9729         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9730         * block.h (struct block) <dict>: Change to multidictionary
9731         and rename `multidict'.
9732         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9733         symmisc.c: Update all dictionary references to multidictionary.
9734
9735 2019-01-10  Keith Seitz  <keiths@redhat.com>
9736
9737         PR gdb/23712
9738         PR symtab/23010
9739         * dictionary.c: Include unordered_map.
9740         (pending_to_vector): New function.
9741         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9742         Rewrite the non-"_1" functions to take vector instead
9743         of linked list.
9744         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9745         "new" _1 versions of the same name.
9746         (multidictionary): Define.
9747         (std::hash<enum language): New definition.
9748         (collate_pending_symbols_by_language, mdict_create_hashed)
9749         (mdict_create_hashed_expandable, mdict_create_linear)
9750         (mdict_create_linear_expandable, mdict_free)
9751         (find_language_dictionary, create_new_language_dictionary)
9752         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9753         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9754         (mdict_size, mdict_empty): New functions.
9755         * dictionary.h (mdict_iterator): Define.
9756
9757 2019-01-10  Pedro Alves  <palves@redhat.com>
9758
9759         * breakpoint.c (read_uploaded_action)
9760         (create_tracepoint_from_upload): Adjust to use
9761         gdb::unique_xmalloc_ptr.
9762         * ctf.c (ctf_write_uploaded_tp):
9763         (SET_ARRAY_FIELD): Use emplace_back.
9764         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9765         * tracefile-tfile.c (tfile_write_uploaded_tp):
9766         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9767         gdb::unique_xmalloc_ptr.
9768         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9769         at_string, cond_string, cmd_strings>: Replace char pointers
9770         with gdb::unique_xmalloc_ptr.
9771
9772 2019-01-10  Pedro Alves  <palves@redhat.com>
9773
9774         * solib-target.c (library_list_start_library): Don't xstrdup name.
9775
9776 2019-01-10  Pedro Alves  <palves@redhat.com>
9777
9778         * mdebugread.c (parse_partial_symbols): Use
9779         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9780
9781 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9782
9783         * linux-fork.c (scoped_switch_fork_info)
9784         <~scoped_switch_fork_info>: Fix incorrect variable name.
9785
9786 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9787
9788         * linux-fork.c (scoped_switch_fork_info)
9789         <scoped_switch_fork_info>: Make explicit.
9790         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9791
9792 2019-01-10  Tom Tromey  <tom@tromey.com>
9793
9794         * objfiles.h (objfile::reset_psymtabs): Update.
9795         * objfiles.c (objfile::objfile): Update.
9796         * psymtab.h (psymtab_storage::obstack): Update.
9797         (psymtab_storage::m_obstack): Use gdb::optional.
9798         (class psymtab_storage): Update comment.  Remove objfile
9799         parameter.
9800         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9801
9802 2019-01-10  Tom Tromey  <tom@tromey.com>
9803
9804         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9805         <free_psymtabs>: Now private.
9806         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9807         (allocate_psymtab): Use new method.
9808
9809 2019-01-10  Tom Tromey  <tom@tromey.com>
9810
9811         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9812         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9813         * mdebugread.c (parse_partial_symbols): Use
9814         allocate_dependencies.
9815         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9816         allocate_dependencies.
9817         (process_psymtab_comp_unit_reader)
9818         (build_type_psymtab_dependencies): Likewise.
9819         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9820
9821 2019-01-10  Tom Tromey  <tom@tromey.com>
9822
9823         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9824         PSYMBOL_SET_LANGUAGE.
9825         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9826
9827 2019-01-10  Tom Tromey  <tom@tromey.com>
9828
9829         * psymtab.h (psymtab_storage::obstack): New method.
9830         <m_obstack>: Rename from obstack; now private.
9831         * psymtab.c (psymtab_storage): Update.
9832         * dwarf2read.c (create_addrmap_from_index)
9833         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9834         Update.
9835
9836 2019-01-10  Tom Tromey  <tom@tromey.com>
9837
9838         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9839         * objfiles.h (objfile::reset_psymtabs): New method.
9840
9841 2019-01-10  Tom Tromey  <tom@tromey.com>
9842
9843         * symmisc.c (print_symbol_bcache_statistics): Update.
9844         (print_objfile_statistics): Update.
9845         * symfile.c (reread_symbols): Update.
9846         * psymtab.h (class psymtab_storage): New.
9847         * psymtab.c (psymtab_storage): New constructor.
9848         (~psymtab_storage): New destructor.
9849         (require_partial_symbols): Update.
9850         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9851         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9852         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9853         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9854         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9855         (start_psymtab_common, end_psymtab_common)
9856         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9857         (allocate_psymtab): Update.
9858         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9859         Update.
9860         (dump_psymtab_addrmap, maintenance_print_psymbols)
9861         (maintenance_check_psymtabs): Update.
9862         (class objfile_psymtabs): Move to objfiles.h.
9863         * psympriv.h (discard_psymtab): Now inline.
9864         (psymtab_discarder::psymtab_discarder): Update.
9865         (psymtab_discarder::~psymtab_discarder): Update.
9866         (ALL_OBJFILE_PSYMTABS): Rewrite.
9867         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9868         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9869         Remove fields.
9870         <partial_symtabs>: New field.
9871         (class objfile_psymtabs): Move from psymtab.h.  Update.
9872         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9873         psymbol_cache.
9874         (objfile::~objfile): Don't destroy psymbol_cache.
9875         * mdebugread.c (parse_partial_symbols): Update.
9876         * dwarf2read.c (create_addrmap_from_index)
9877         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9878         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9879         (add_partial_subprogram, dwarf2_ranges_read): Update.
9880         * dwarf-index-write.c (write_address_map)
9881         (write_one_signatured_type, recursively_write_psymbols)
9882         (class debug_names, class debug_names, write_psymtabs_to_index):
9883         Update.
9884
9885 2019-01-10  Tom Tromey  <tom@tromey.com>
9886
9887         * symtab.h (SYMBOL_SET_NAMES): Update.
9888         (symbol_set_names): Update.
9889         (MSYMBOL_SET_NAMES): Update.
9890         * symtab.c (symbol_set_names): Change argument to be an
9891         objfile_per_bfd_storage.
9892         * psymtab.c (add_psymbol_to_bcache): Update.
9893         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9894
9895 2019-01-10  Tom Tromey  <tom@tromey.com>
9896
9897         * symtab.c (create_demangled_names_hash): Change argument to be an
9898         objfile_per_bfd_storage.
9899         (symbol_set_names): Update.
9900
9901 2019-01-10  Tom Tromey  <tom@tromey.com>
9902
9903         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9904         init_psymbol_list.
9905         * psymtab.c (init_psymbol_list): Do nothing if already called.
9906         * psympriv.h (init_psymbol_list): Add comment.
9907         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9908         init_psymbol_list.
9909         * dbxread.c (dbx_symfile_read): Unconditionally call
9910         init_psymbol_list.
9911
9912 2019-01-10  Tom Tromey  <tom@tromey.com>
9913
9914         * xcoffread.c (scan_xcoff_symtab): Update.
9915         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9916         "where".
9917         * mdebugread.c (parse_partial_symbols)
9918         (handle_psymbol_enumerators): Update.
9919         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9920         * dbxread.c (read_dbx_symtab): Update.
9921         * psympriv.h (psymbol_placement): New enum.
9922         (add_psymbol_to_list): Update.
9923
9924 2019-01-10  Tom Tromey  <tom@tromey.com>
9925
9926         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9927         static_psymbols parameters.
9928         (scan_xcoff_symtab): Update.
9929         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9930         static_psymbols parameters.
9931         * psympriv.h (start_psymtab_common): Update.
9932         * mdebugread.c (parse_partial_symbols): Update.
9933         * dwarf2read.c (create_partial_symtab): Update.
9934         * dbxread.c (read_dbx_symtab): Update.
9935         (start_psymtab): Remove global_psymbols and static_psymbols
9936         parameters.
9937
9938 2019-01-10  Tom Tromey  <tom@tromey.com>
9939
9940         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9941         * psymtab.c (allocate_psymtab): Add comment.
9942         * psympriv.h (allocate_psymtab): Add comment.
9943         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9944         initializations.
9945         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9946
9947 2019-01-10  Tom Tromey  <tom@tromey.com>
9948
9949         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9950         Don't declare.
9951         * mipsread.c: Include mdebugread.h.
9952         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9953         Declare.
9954         * elfread.c: Include mdebugread.h.
9955
9956 2019-01-09  Tom Tromey  <tom@tromey.com>
9957
9958         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9959         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9960         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9961         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9962         (psym_lookup_symbol, psym_find_last_source_symtab)
9963         (psym_forget_cached_source_info, psym_print_stats)
9964         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9965         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9966         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9967         (psym_find_compunit_symtab_by_address)
9968         (maintenance_print_psymbols, maintenance_info_psymtabs)
9969         (maintenance_check_psymtabs): Use ranged for.
9970         * psymtab.h (class objfile_psymtabs): New.
9971         (require_partial_symbols): Return objfile_psymtabs.
9972         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9973
9974 2019-01-09  Tom Tromey  <tom@tromey.com>
9975
9976         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9977         (find_pc_mapped_section, list_overlays_command)
9978         (map_overlay_command, unmap_overlay_command)
9979         (simple_overlay_update): Use all_objfiles.
9980         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9981         * printcmd.c (info_symbol_command): Use all_objfiles.
9982         * objfiles.h (ALL_OBJSECTIONS): Remove.
9983         * maint.c (maintenance_translate_address): Use all_objfiles.
9984         * gcore.c (gcore_create_callback): Use all_objfiles.
9985         (objfile_find_memory_regions): Likewise.
9986
9987 2019-01-09  Tom Tromey  <tom@tromey.com>
9988
9989         * symtab.c (find_line_symtab, info_sources_command)
9990         (make_source_files_completion_list): Use objfile_compunits.
9991         * source.c (select_source_symtab): Use objfile_compunits.
9992         * objfiles.h (struct objfile): Update comment.
9993         (ALL_OBJFILES): Remove.
9994         (ALL_FILETABS): Remove.
9995         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9996         objfile_compunits.
9997
9998 2019-01-09  Tom Tromey  <tom@tromey.com>
9999
10000         * symmisc.c (print_objfile_statistics, dump_objfile)
10001         (maintenance_print_symbols): Use compunit_filetabs.
10002         * source.c (forget_cached_source_info_for_objfile): Use
10003         compunit_filetabs.
10004         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10005         (ALL_FILETABS): Use compunit_filetabs.
10006         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10007         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10008
10009 2019-01-09  Tom Tromey  <tom@tromey.com>
10010
10011         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10012         (compunit_filetabs): New.
10013         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10014         compunit_filetabs.
10015         (info_sources_command, make_source_files_completion_list): Remove
10016         declaration.
10017         * symmisc.c (print_objfile_statistics, dump_objfile)
10018         (maintenance_print_symbols): Remove declaration.
10019         (maintenance_info_symtabs): Use compunit_filetabs.
10020         (maintenance_info_line_tables): Likewise.
10021         * source.c (select_source_symtab): Change local variable name.
10022         (forget_cached_source_info_for_objfile): Remove declaration.
10023         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10024         * objfiles.c (objfile_relocate1): Remove declaration.
10025         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10026         declaration.
10027         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10028         * coffread.c (coff_symtab_read): Remove declaration.
10029         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10030         compunit_filetabs.
10031
10032 2019-01-09  Tom Tromey  <tom@tromey.com>
10033
10034         * symtab.c (lookup_objfile_from_block)
10035         (find_pc_sect_compunit_symtab, search_symbols)
10036         (default_collect_symbol_completion_matches_break_on): Use
10037         objfile_compunits.
10038         * objfiles.h (ALL_COMPUNITS): Remove.
10039         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10040         * cp-support.c (add_symbol_overload_list_qualified): Use
10041         objfile_compunits.
10042         * ada-lang.c (ada_collect_symbol_completion_matches)
10043         (ada_add_global_exceptions): Use objfile_compunits.
10044
10045 2019-01-09  Tom Tromey  <tom@tromey.com>
10046
10047         * source.c (select_source_symtab)
10048         (forget_cached_source_info_for_objfile): Remove declaration.
10049         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10050         declaration.
10051         * maint.c (count_symtabs_and_blocks): Remove declaration.
10052         * cp-support.c (add_symbol_overload_list_qualified): Remove
10053         declaration.
10054         * coffread.c (coff_symtab_read): Remove declaration.
10055         * symtab.c (lookup_symbol_in_objfile_symtabs)
10056         (basic_lookup_transparent_type_1): Use objfile_compunits.
10057         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10058         (info_sources_command, search_symbols)
10059         (default_collect_symbol_completion_matches_break_on)
10060         (make_source_files_completion_list): Remove declaration.
10061         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10062         (ada_collect_symbol_completion_matches)
10063         (ada_add_global_exceptions): Remove declaration.
10064         * linespec.c (iterate_over_all_matching_symtabs): Use
10065         objfile_compunits.
10066         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10067         (class objfile_compunits): New.
10068         (ALL_COMPUNITS): Use objfile_compunits.
10069         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10070         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10071         objfile_compunits.
10072         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10073
10074 2019-01-09  Tom Tromey  <tom@tromey.com>
10075
10076         * symtab.c (search_symbols)
10077         (default_collect_symbol_completion_matches_break_on): Use
10078         objfile_msymbols.
10079         * ada-lang.c (ada_lookup_simple_minsym)
10080         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10081         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10082         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10083         objfile_msymbols.
10084         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10085         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10086         * objc-lang.c (find_methods): Use objfile_msymbols.
10087         (info_selectors_command, info_classes_command): Likewise.
10088         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10089         * objfiles.h (class objfile_msymbols): New.
10090         (ALL_OBJFILE_MSYMBOLS): Remove.
10091         (ALL_MSYMBOLS): Remove.
10092
10093 2019-01-09  Tom Tromey  <tom@tromey.com>
10094
10095         * common/next-iterator.h (next_adapter): Add Iterator template
10096         parameter.
10097         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10098         (class all_objfiles_safe): New.
10099         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10100         * objfiles.c (put_objfile_before): Update comment.
10101         (add_separate_debug_objfile): Likewise.
10102         (free_all_objfiles): Use all_objfiles_safe.
10103         (objfile_purge_solibs): Likewise.
10104
10105 2019-01-09  Tom Tromey  <tom@tromey.com>
10106
10107         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10108         (expand_symtab_containing_pc, lookup_static_symbol)
10109         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10110         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10111         all_objfiles.
10112         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10113         * breakpoint.c (create_overlay_event_breakpoint)
10114         (create_longjmp_master_breakpoint)
10115         (create_std_terminate_master_breakpoint)
10116         (create_exception_master_breakpoint): Use all_objfiles.
10117         * linux-thread-db.c (try_thread_db_load_from_pdir)
10118         (has_libpthread): Use all_objfiles.
10119         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10120         * linespec.c (iterate_over_all_matching_symtabs)
10121         (search_minsyms_for_name): Use all_objfiles.
10122         * maint.c (maintenance_info_sections): Use all_objfiles.
10123         * main.c (captured_main_1): Use all_objfiles.
10124         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10125         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10126         * guile/scm-pretty-print.c
10127         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10128         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10129         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10130         (maintenance_print_msymbols): Use all_objfiles.
10131         * source.c (select_source_symtab): Use all_objfiles.
10132         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10133         * symfile.c (remove_symbol_file_command)
10134         (expand_symtabs_matching, map_symbol_filenames): Use
10135         all_objfiles.
10136         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10137         all_objfiles.
10138         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10139         * objc-lang.c (find_methods): Use all_objfiles.
10140         * objfiles.c (have_partial_symbols, have_full_symbols)
10141         (have_minimal_symbols, qsort_cmp)
10142         (default_iterate_over_objfiles_in_search_order): Use
10143         all_objfiles.
10144         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10145         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10146         (maintenance_check_psymtabs): Use all_objfiles.
10147         (ALL_PSYMTABS): Remove.
10148         * compile/compile-object-run.c (do_module_cleanup): Use
10149         all_objfiles.
10150         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10151         * cp-support.c (add_symbol_overload_list_qualified): Use
10152         all_objfiles.
10153         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10154         Use all_objfiles.
10155         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10156         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10157         all_objfiles.
10158         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10159         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10160         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10161         Uses all_objfiles.
10162         * solib.c (solib_read_symbols): Use all_objfiles
10163
10164 2019-01-09  Tom Tromey  <tom@tromey.com>
10165
10166         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10167         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10168         all_objfiles.
10169         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10170         * symmisc.c (print_symbol_bcache_statistics)
10171         (print_objfile_statistics, maintenance_print_objfiles)
10172         (maintenance_info_symtabs, maintenance_check_symtabs)
10173         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10174         all_objfiles.
10175         * source.c (forget_cached_source_info): Use all_objfiles.
10176         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10177         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10178         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10179         * objfiles.c (update_section_map): Use all_objfiles.
10180         (shared_objfile_contains_address_p): Likewise.
10181         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10182         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10183
10184 2019-01-09  Tom Tromey  <tom@tromey.com>
10185
10186         * common/next-iterator.h: New file.
10187         * objfiles.h (class all_objfiles): New.
10188         (struct objfile_iterator): New.
10189
10190 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10191
10192         * NEWS: Move the description of the changed "frame", "select-frame",
10193          and "info frame" commands to the Changed commands section.
10194
10195 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10196
10197         * gdbtypes.c (check_stub_method_group): Remove handling of old
10198         mangling schemes.
10199         * linespec.c (find_methods): Likewise.
10200         * stabsread.c (read_member_functions): Likewise.
10201         * valops.c (search_struct_method): Likewise.
10202         (value_struct_elt_for_reference): Likewise.
10203         * NEWS: Mention this change.
10204
10205 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10206
10207         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10208         print_source_lines.
10209         * source.c (print_source_lines_base): Update line number check.
10210         (print_source_lines): New function.
10211         (source_lines_range::source_lines_range): New function.
10212         * source.h (class source_lines_range): New class.
10213         (print_source_lines): New declaration.
10214
10215 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10216
10217         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10218
10219 2019-01-08  Tom Tromey  <tom@tromey.com>
10220             Simon Marchi  <simon.marchi@ericsson.com>
10221
10222         PR gdb/24060
10223         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10224         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10225         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10226         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10227         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10228         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10229
10230 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10231
10232         * source.c (select_source_symtab): Move header comment to
10233         declaration in source.h.
10234         (forget_cached_source_info_for_objfile): Likewise.
10235         (forget_cached_source_info): Likewise.
10236         (identify_source_line): Likewise.
10237         * source.h (identify_source_line): Move declaration from symtab.h
10238         and add comment from source.c
10239         (print_source_lines): Likewise.
10240         (forget_cached_source_info_for_objfile): Likewise.
10241         (forget_cached_source_info): Likewise.
10242         (select_source_symtab): Likewise.
10243         (enum print_source_lines_flag): Move definition from symtab.h.
10244         * symtab.h (identify_source_line): Move declaration to source.h.
10245         (print_source_lines): Likewise.
10246         (forget_cached_source_info_for_objfile): Likewise.
10247         (forget_cached_source_info): Likewise.
10248         (select_source_symtab): Likewise.
10249         (enum print_source_lines_flag): Move definition to source.h.
10250         * tui/tui-hooks.c: Add 'source.h' include.
10251
10252 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10253
10254         * source.c (print_source_lines_base): Handle requests to print
10255         reverse line number sequences, and guard against empty lines
10256         string.
10257
10258 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10259
10260         * source.c (print_source_lines_base): Fix skip of '\r' if next
10261         character is '\n'.
10262
10263 2019-01-06  Tom Tromey  <tom@tromey.com>
10264
10265         * c-exp.y (struct c_parse_state) <macro_original_text,
10266         expansion_obstack>: New member.
10267         (macro_original_text, expansion_obstack): Remove globals.
10268         (scan_macro_expansion, scanning_macro_expansion)
10269         (finished_macro_expansion): Update.
10270         (scan_macro_cleanup): Remove.
10271         (yylex, c_parse): Update.
10272
10273 2019-01-06  Tom Tromey  <tom@tromey.com>
10274
10275         * c-exp.y (struct c_parse_state) <strings>: New member.
10276         (operator_stoken): Update.
10277
10278 2019-01-06  Tom Tromey  <tom@tromey.com>
10279
10280         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10281         (union type_stack_elt) <typelist_val>: Now a pointer to
10282         std::vector.
10283         (type_stack_cleanup): Don't declare.
10284         (push_typelist): Update.
10285         * parse.c (pop_typelist): Return a std::vector.
10286         (push_typelist): Take a std::vector.
10287         (follow_types): Update.  Do not free args.
10288         (type_stack_cleanup): Remove.
10289         * c-exp.y (struct c_parse_state): New.
10290         (cpstate): New global.
10291         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10292         (nonempty_typelist): Update.
10293         (func_mod): Create a new vector.
10294         (c_parse): Create a c_parse_state.
10295         (check_parameter_typelist): Do not delete params.
10296         (function_method): Update.  Do not delete type_list.
10297
10298 2019-01-06  Tom Tromey  <tom@tromey.com>
10299
10300         PR gdb/28155:
10301         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10302         check_typedef.
10303         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10304         (print_return_value): Likewise.
10305
10306 2019-01-05  Tom Tromey  <tom@tromey.com>
10307
10308         * contrib/cleanup_check.py: Remove.
10309         * contrib/gcc-with-excheck: Remove.
10310         * contrib/exsummary.py: Remove.
10311         * contrib/excheck.py: Remove.
10312
10313 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10314
10315         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10316         NULL. Initialize tpprev to NULL instead of assigning it
10317         to NULL on the next statement.
10318         * windows-nat.c (windows_delete_thread): Remove check for
10319         main_thread_id before printing thread exit notifications.
10320         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10321         Remove thread ID check against main_thread_id.
10322         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10323         windows_delete_thread.
10324         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10325
10326 2019-01-04  Tom Tromey  <tom@tromey.com>
10327
10328         * compile/compile.c (_initialize_compile): Use upper case for
10329         metasyntactic variables.
10330         * symmisc.c (_initialize_symmisc): Use upper case for
10331         metasyntactic variables.
10332         * psymtab.c (_initialize_psymtab): Use upper case for
10333         metasyntactic variables.
10334         * demangle.c (demangle_command): Use upper case for metasyntactic
10335         variables.
10336         (_initialize_demangler): Likewise.
10337         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10338         variables.
10339
10340 2019-01-03  Tom Tromey  <tom@tromey.com>
10341
10342         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10343
10344 2019-01-03  Tom Tromey  <tom@tromey.com>
10345
10346         * python/py-symtab.c (salpy_str): Update.
10347         (struct salpy_sal_object) <symtab>: Now a PyObject.
10348         (salpy_dealloc): Update.
10349         (del_objfile_sal): Use gdbpy_ref.
10350
10351 2019-01-03  Tom Tromey  <tom@tromey.com>
10352
10353         * python/py-type.c (convert_field): Use new_reference.  Return
10354         gdbpy_ref.
10355         (make_fielditem): Return gdbpy_ref.
10356         (typy_fields): Update.
10357         (typy_getitem): Update.
10358         (field_name): Return gdbpy_ref.  Use new_reference.
10359         (typy_iterator_iternext): Update.
10360
10361 2019-01-03  Tom Tromey  <tom@tromey.com>
10362
10363         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10364
10365 2019-01-03  Tom Tromey  <tom@tromey.com>
10366
10367         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10368         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10369         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10370         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10371         (pspy_set_type_printers): Likewise.
10372         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10373         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10374         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10375         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10376         (objfpy_set_type_printers): Likewise.
10377
10378 2019-01-03  Tom Tromey  <tom@tromey.com>
10379
10380         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10381         (gdbpy_print_stack): Use gdbpy_err_fetch.
10382         * python/python-internal.h (class gdbpy_err_fetch): New class.
10383         (class gdbpy_enter) <m_error_type, m_error_value,
10384         m_error_traceback>: Remove.
10385         <m_error>: New member.
10386         (gdbpy_exception_to_string): Don't declare.
10387         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10388         * python/py-value.c (convert_value_from_python): Use
10389         gdbpy_err_fetch.
10390         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10391         gdbpy_exception_to_string.
10392         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10393         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10394         gdbpy_err_fetch.
10395
10396 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10397
10398         * linux-nat.c (delete_lwp_cleanup): Delete.
10399         (struct lwp_deleter): New struct.
10400         (lwp_info_up): New typedef.
10401         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10402         lwp_info_up.
10403
10404 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10405
10406         * linux-fork.c (class scoped_switch_fork_info): New class.
10407         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10408
10409 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10410
10411         * valops.c (find_overload_match): Remove use of null_cleanup, and
10412         calls to do_cleanups.
10413
10414 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10415
10416         * compile/compile-cplus-types.c
10417         (compile_cplus_instance::decl_name): Handle changes to
10418         cp_func_name.
10419         * cp-support.c (cp_func_name): Update header comment, update
10420         return type.
10421         * cp-support.h (cp_func_name): Update return type in declaration.
10422         * valops.c (find_overload_match): Move temp_func local to top
10423         level of function and change its type.  Use temp_func to hold and
10424         delete temporary string obtained from cp_func_name.
10425
10426 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10427
10428         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10429         gdb::char_vector, remove cleanup, and update uses of `msg`.
10430
10431 2019-01-03  Jim Wilson  <jimw@sifive.com>
10432
10433         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10434
10435 2019-01-02  Tom Tromey  <tom@tromey.com>
10436
10437         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10438         (tdesc_parse_xml): Remove cleanups.
10439         * target-descriptions.h (make_cleanup_free_target_description):
10440         Don't declare.
10441         (target_desc_deleter): New struct.
10442         (target_desc_up): New typedef.
10443         * target-descriptions.c (target_desc_deleter::operator()): Rename
10444         from free_target_description.
10445         (make_cleanup_free_target_description): Remove.
10446
10447 2019-01-02  Tom Tromey  <tom@tromey.com>
10448
10449         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10450         constructor, destructor.
10451         (linespec_parser): Remove typedef.
10452         (~linespec_parser): Rename from linespec_parser_delete.
10453         (linespec_lex_to_end, linespec_complete_label)
10454         (linespec_complete): Update.
10455         (decode_line_full): Remove cleanups.
10456         (decode_line_1): Update.
10457
10458 2019-01-02  Tom Tromey  <tom@tromey.com>
10459
10460         * python/python-internal.h (inferior_to_inferior_object): Change
10461         return type.
10462         * python/py-exitedevent.c (create_exited_event_object): Update.
10463         * python/py-inferior.c (inferior_to_inferior_object): Return
10464         gdbpy_ref.
10465         (python_new_inferior, python_inferior_deleted)
10466         (thread_to_thread_object, delete_thread_object)
10467         (build_inferior_list, gdbpy_selected_inferior): Update.
10468         * python/py-infthread.c (create_thread_object): Update.  Also fail
10469         if inferior_to_inferior_object fails.
10470
10471 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10472
10473         * inferior.h (class inferior) <displaced_step_state>: New field.
10474         * infrun.h (struct displaced_step_state): Move here from
10475         infrun.c.  Initialize fields, add constructor.
10476         <inf>: Remove field.
10477         <reset>: New method.
10478         * infrun.c (struct displaced_step_inferior_state): Move to
10479         infrun.h.
10480         (displaced_step_inferior_states): Remove.
10481         (get_displaced_stepping_state): Adust.
10482         (displaced_step_in_progress_any_inferior): Adjust.
10483         (displaced_step_in_progress_thread): Adjust.
10484         (displaced_step_in_progress): Adjust.
10485         (add_displaced_stepping_state): Remove.
10486         (get_displaced_step_closure_by_addr): Adjust.
10487         (remove_displaced_stepping_state): Remove.
10488         (infrun_inferior_exit): Call displaced_step_state.reset.
10489         (use_displaced_stepping): Don't check for NULL.
10490         (displaced_step_prepare_throw): Call
10491         get_displaced_stepping_state.
10492         (displaced_step_fixup): Don't check for NULL.
10493         (prepare_for_detach): Don't check for NULL.
10494
10495 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10496
10497         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10498          in case of call that did not complete.
10499
10500 2019-01-02  Andrey Utkin  <autkin@undo.io>
10501
10502         * symfile.c (find_separate_debug_file): Fix search of debug files for
10503         remote debuggee.
10504
10505 2019-01-02  Tom Tromey  <tom@tromey.com>
10506
10507         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10508         indentation.
10509         * python/py-frame.c (frapy_older): Remove cast.
10510         (frapy_newer): Likewise.
10511         * python/py-breakpoint.c (local_setattro): Remove cast.
10512         * python/py-arch.c (archpy_name): Remove local variable.
10513         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10514
10515 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10516
10517         * unittests/basic_string_view/element_access/char/empty.cc:
10518         Fix year range in copyright header.
10519
10520 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10521
10522         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10523         Delete.
10524         <operator==>: Update with for removed field.
10525         <hash>: Likewise.
10526         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10527         <isa_features>: ...this.
10528         <abi_features>: New field.
10529         (riscv_isa_flen): Update comment.
10530         (riscv_abi_xlen): New declaration.
10531         (riscv_abi_flen): New declaration.
10532         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10533         isa_features.
10534         (riscv_abi_xlen): New function.
10535         (riscv_isa_flen): Update to get answer from isa_features.
10536         (riscv_abi_flen): New function.
10537         (riscv_has_fp_abi): Update to get answer from abi_features.
10538         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10539         xlen and flen.
10540         (riscv_call_info) <xlen, flen>: Update comment.
10541         (riscv_call_arg_struct): Remove invalid assertions
10542         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10543         is removed.
10544         (riscv_gdbarch_init): Gather isa features and abi features
10545         separately, ensure both match on the gdbarch when reusing an old
10546         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10547         a target with 64-bit float hardware.
10548
10549 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10550
10551         * source.c (search_command_helper): Stop reverse search
10552         when line 1 has been searched.
10553
10554 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10555
10556         * record-full.c (record_full_base_target::close): Rewrite
10557         record_full_core_buf_list free logic.
10558
10559 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10560
10561         * break-catch-syscall.c (print_one_catch_syscall): xfree
10562         the last text.
10563
10564 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10565
10566         * top.c (print_gdb_version): Update Copyright year in version
10567         message.
10568
10569 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10570
10571         Update copyright year range in all GDB files.
10572
10573 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10574
10575         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10576
10577 For older changes see ChangeLog-2018.
10578 \f
10579 Local Variables:
10580 mode: change-log
10581 left-margin: 8
10582 fill-column: 74
10583 version-control: never
10584 coding: utf-8
10585 End:
10586