gdb/ChangeLog

   1 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
   4         type_print.
   5
   6 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
   7
   8         * symtab.c (search_symbols): Adjust msymbol matching type arrays
   9         so that GDB doesn't match any msymbols when searching in the
  10         TYPES_DOMAIN.
  11         (print_symbol_info): Print using typedef_print or type_print based
  12         on the type of the symbol.  Add updated FIXME comment moved from...
  13         (_initialize_symtab): ... move and update FIXME comment to above.
  14
  15 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  16
  17         * NEWS: Mention adding -q option to "info types".
  18         * symtab.c (struct info_types_options): New struct.
  19         (info_types_options_defs): New variable.
  20         (make_info_types_options_def_group): New function.
  21         (info_types_command): Use gdb::option framework to parse options.
  22         (info_types_command_completer): New function.
  23         (_initialize_symtab): Extend the help text on "info types" and
  24         register command completer.
  25
  26 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
  27
  28         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
  29         (lookup_symbol_in_objfile): Change int to block_enum and add a
  30         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
  31
  32 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
  33
  34         * MAINTAINERS (Write After Approval): Add self.
  35
  36 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
  37
  38         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
  39         instruction to the dummy code region.
  40
  41 2019-07-19  Tom Tromey  <tromey@adacore.com>
  42
  43         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
  44         (ARGSUSED, PARAMS, __func__): Remove rules.
  45
  46 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  47
  48         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
  49         * features/arm/arm-with-iwmmxt.c: Remove.
  50         * features/arm/arm-with-iwmmxt.xml: Remove.
  51         * features/arm/arm-with-m-fpa-layout.c: Remove.
  52         * features/arm/arm-with-m-fpa-layout.xml: Remove.
  53         * features/arm/arm-with-m-vfp-d16.c: Remove.
  54         * features/arm/arm-with-m-vfp-d16.xml: Remove.
  55         * features/arm/arm-with-m.c: Remove.
  56         * features/arm/arm-with-m.xml: Remove.
  57         * features/arm/arm-with-neon.c: Remove.
  58         * features/arm/arm-with-neon.xml: Remove.
  59         * features/arm/arm-with-vfpv2.c: Remove.
  60         * features/arm/arm-with-vfpv2.xml: Remove.
  61         * features/arm/arm-with-vfpv3.c: Remove.
  62         * features/arm/arm-with-vfpv3.xml: Remove.
  63
  64 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  65
  66         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
  67
  68 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  69
  70         * arch/aarch32.c (aarch32_create_target_description): Create
  71         target descriptions using features.
  72         * arch/arm.c (arm_create_target_description)
  73         (arm_create_mprofile_target_description): Likewise.
  74         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
  75
  76 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  77
  78         * Makefile.in: Add new files.
  79         * aarch32-tdep.c: New file.
  80         * aarch32-tdep.h: New file.
  81         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  82         Call aarch32_read_description.
  83         * arch/aarch32.c: New file.
  84         * arch/aarch32.h: New file.
  85         * arch/arm.c (arm_create_target_description)
  86         (arm_create_mprofile_target_description): New function.
  87         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
  88         (arm_create_target_description)
  89         (arm_create_mprofile_target_description): New declaration.
  90         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
  91         read_description functions.
  92         * arm-linux-nat.c (arm_linux_nat_target::read_description):
  93         Likewise.
  94         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  95         * arm-tdep.c (tdesc_arm_list): New variable.
  96         (arm_register_g_packet_guesses): Call create description functions.
  97         (arm_read_description) (arm_read_mprofile_description): New
  98         function.
  99         * arm-tdep.h (arm_read_description)
 100         (arm_read_mprofile_description): Add declaration.
 101         * configure.tgt: Add new files.
 102
 103 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 104
 105         * top.c (new_ui_command): Open specified terminal just once.
 106
 107 2019-07-18  Tom Tromey  <tromey@adacore.com>
 108
 109         * symtab.c (main_name): Constify return type.
 110         * symfile.c (set_initial_language): Update.
 111         * symtab.h (main_name): Constify return type.
 112
 113 2019-07-17  Tom Tromey  <tom@tromey.com>
 114
 115         * tui/tui-winsource.c (tui_update_source_window)
 116         (tui_update_source_window_as_is)
 117         (tui_update_source_windows_with_line): Remove return.
 118         * tui/tui-disasm.c (tui_show_disassem)
 119         (tui_show_disassem_and_update_source): Remove return.
 120         * tui/tui.c (tui_reset): Remove return.
 121         * tui/tui-wingeneral.c
 122         (tui_check_and_display_highlight_if_needed): Remove return.
 123
 124 2019-07-17  Tom Tromey  <tom@tromey.com>
 125
 126         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 127
 128 2019-07-17  Tom Tromey  <tom@tromey.com>
 129
 130         * tui/tui-winsource.h (struct tui_exec_info_window)
 131         (struct tui_source_window_base): Move from tui-data.h.
 132         * tui/tui-winsource.c: Move many method definitions from
 133         elsewhere.  Remove "structuring" comments.
 134         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 135         (tui_source_window_base::refresh_window): Move to
 136         tui-winsource.c.
 137         * tui/tui-win.c (tui_source_window_base::refresh_all)
 138         (tui_source_window_base::update_tab_width)
 139         (tui_source_window_base::set_new_height)
 140         (tui_source_window_base::do_make_visible_with_new_height): Move to
 141         tui-winsource.c.
 142         * tui/tui-source.h: Update.
 143         * tui/tui-source.c (tui_source_window_base::reset): Move to
 144         tui-winsource.c.
 145         * tui/tui-disasm.h: Update.
 146         * tui/tui-data.h (struct tui_exec_info_window): Move to
 147         tui-winsource.h.
 148         (struct tui_source_window_base): Likewise.
 149         * tui/tui-data.c (tui_source_window_base::clear_detail)
 150         (tui_source_window_base, ~tui_source_window_base): Move to
 151         tui-winsource.c.
 152
 153 2019-07-17  Tom Tromey  <tom@tromey.com>
 154
 155         * tui/tui-win.c (tui_resize_all)
 156         (tui_source_window_base::update_tab_width)
 157         (tui_adjust_win_heights): Update.
 158         (tui_win_info::make_invisible_and_set_new_height): Rename from
 159         make_invisible_and_set_new_height.
 160         * tui/tui-data.h (struct tui_win_info)
 161         <make_invisible_and_set_new_height>: New method.
 162
 163 2019-07-17  Tom Tromey  <tom@tromey.com>
 164
 165         * tui/tui.c: Update.
 166         * tui/tui-source.h (struct tui_source_window): Move from
 167         tui-data.h.
 168         * tui/tui-layout.c: Update.
 169         * tui/tui-disasm.c: Update.
 170         * tui/tui-data.h (struct tui_source_window): Move to
 171         tui-source.h.
 172
 173 2019-07-17  Tom Tromey  <tom@tromey.com>
 174
 175         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 176         tui-data.h.
 177         * tui/tui-data.h (struct tui_disasm_window): Move to
 178         tui-disasm.h.
 179
 180 2019-07-17  Tom Tromey  <tom@tromey.com>
 181
 182         * tui/tui-regs.h (struct tui_data_item_window): Move from
 183         tui-data.h.
 184         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 185         * tui/tui-data.h (struct tui_data_item_window): Move to
 186         tui-regs.h.
 187         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 188
 189 2019-07-17  Tom Tromey  <tom@tromey.com>
 190
 191         * tui/tui.c: Update.
 192         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 193         (tui_cmd_window::max_height): Move to tui-command.c.
 194         * tui/tui-layout.c: Update.
 195         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 196         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 197         tui-command.c.
 198         * tui/tui-command.h (struct tui_cmd_window): Move from
 199         tui-data.h.
 200         * tui/tui-command.c: Remove "structuring" comments.
 201         (tui_cmd_window::clear_detail)
 202         (tui_cmd_window::do_make_visible_with_new_height)
 203         (tui_cmd_window::max_height): Move from elsewhere.
 204
 205 2019-07-17  Tom Tromey  <tom@tromey.com>
 206
 207         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 208         Now static.
 209         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 210         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 211
 212 2019-07-17  Tom Tromey  <tom@tromey.com>
 213
 214         * tui/tui.c: Update.
 215         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 216         tui-regs.c.
 217         * tui/tui-windata.h: Remove file.
 218         * tui/tui-windata.c: Remove file.
 219         * tui/tui-win.c (tui_data_window::set_new_height)
 220         (tui_data_window::do_make_visible_with_new_height): Move to
 221         tui-regs.c.
 222         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 223         * tui/tui-regs.c: Remove "structuring" comments.
 224         (tui_data_window::first_data_item_displayed)
 225         (tui_data_window::delete_data_content_windows)
 226         (tui_data_window::erase_data_content)
 227         (tui_data_window::display_all_data)
 228         (tui_data_window::refresh_all)
 229         (tui_data_window::do_scroll_vertical)
 230         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 231         (tui_data_window::do_make_visible_with_new_height)
 232         (tui_data_window::refresh_window): Move from elsewhere.
 233         (_initialize_tui_regs): Move to end of file.
 234         * tui/tui-layout.c: Update.
 235         * tui/tui-hooks.c: Update.
 236         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 237         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 238         tui-regs.c.
 239         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 240
 241 2019-07-17  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 244         seen.
 245
 246 2019-07-17  Tom Tromey  <tom@tromey.com>
 247
 248         * tui/tui-win.c (tui_source_window_base::set_new_height)
 249         (tui_source_window_base::do_make_visible_with_new_height): Use
 250         m_has_locator field directly.
 251         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 252         method.
 253         (struct tui_source_window_base) <has_locator>: Likewise.
 254
 255 2019-07-17  Tom Tromey  <tom@tromey.com>
 256
 257         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 258         Don't declare.
 259         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 260         Remove.
 261         * tui/tui-win.c (tui_source_window_base::set_new_height)
 262         (tui_source_window_base::set_new_height)
 263         (make_invisible_and_set_new_height)
 264         (tui_source_window_base::do_make_visible_with_new_height)
 265         (tui_source_window_base::do_make_visible_with_new_height):
 266         Update.
 267         * tui/tui-layout.c (show_source_disasm_command, show_data)
 268         (show_source_or_disasm_and_command): Update.
 269         * tui/tui-layout.c (show_layout): Update.
 270
 271 2019-07-17  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-layout.c (make_data_window): Remove.
 274         (show_data): Unify creation and re-initialization cases.
 275
 276 2019-07-17  Tom Tromey  <tom@tromey.com>
 277
 278         * tui/tui-layout.c (make_source_window, make_disasm_window):
 279         Remove.
 280         (show_data): Unify creation and re-initialization cases.
 281
 282 2019-07-17  Tom Tromey  <tom@tromey.com>
 283
 284         * tui/tui-layout.c (make_command_window): Remove.
 285         (show_source_disasm_command, show_source_or_disasm_and_command):
 286         Unify creation and re-initialization cases.
 287
 288 2019-07-17  Tom Tromey  <tom@tromey.com>
 289
 290         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 291         creation and re-initialization cases.
 292
 293 2019-07-17  Tom Tromey  <tom@tromey.com>
 294
 295         * tui/tui-regs.c (tui_get_register): Return void.
 296
 297 2019-07-17  Tom Tromey  <tom@tromey.com>
 298
 299         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 300         Simplify.
 301
 302 2019-07-17  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 305         resetting.
 306
 307 2019-07-17  Tom Tromey  <tom@tromey.com>
 308
 309         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 310         * tui/tui-regs.c (tui_reg_layout): New function.
 311         (tui_show_registers, tui_reg_command): Use it.
 312         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 313         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 314         parameters.
 315         (tui_layout_command): Remove.
 316
 317 2019-07-17  Tom Tromey  <tom@tromey.com>
 318
 319         * tui/tui-layout.h (tui/tui-layout): Return void.
 320         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 321
 322 2019-07-17  Tom Tromey  <tom@tromey.com>
 323
 324         * tui/tui-layout.c (show_source_disasm_command, show_data):
 325         Update.
 326         (reset_locator): Remove.
 327         (show_source_or_disasm_and_command): Update.
 328
 329 2019-07-17  Tom Tromey  <tom@tromey.com>
 330
 331         * tui/tui-source.c (tui_source_window_base::reset): Remove
 332         win_type parameter.
 333         * tui/tui-layout.c (make_command_window, make_source_window)
 334         (make_disasm_window, make_data_window)
 335         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 336         (reset_locator, show_source_or_disasm_and_command): Update.
 337         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 338         win_type parameter.
 339         (struct tui_source_window_base) <reset>: Likewise.
 340
 341 2019-07-17  Tom Tromey  <tom@tromey.com>
 342
 343         * tui/tui-layout.c (show_source_disasm_command): Use
 344         reset_locator.
 345         (reset_locator): New function.
 346         (init_and_make_win): Remove.
 347         (show_source_or_disasm_and_command): Use reset_locator.
 348
 349 2019-07-17  Tom Tromey  <tom@tromey.com>
 350
 351         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 352         condition.
 353         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 354         Remove condition.
 355         * tui/tui-source.c (tui_source_window_base::reset): New method.
 356         * tui/tui-layout.c (make_command_window): Don't call
 357         init_and_make_win.
 358         (make_source_window, make_disasm_window): Don't call
 359         make_source_or_disasm_window.
 360         (make_data_window): Don't call init_and_make_win.  Change calling
 361         convention.
 362         (show_source_disasm_command, show_data): Simplify.
 363         (make_source_or_disasm_window): Remove.
 364         (show_source_or_disasm_and_command): Simplify.
 365         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 366         (struct tui_source_window_base) <reset>: Likewise.
 367         <execution_info>: Remove initializer.
 368         * tui/tui-data.c (tui_source_window_base): Initialize
 369         execution_info.
 370
 371 2019-07-17  Tom Tromey  <tom@tromey.com>
 372
 373         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 374         variable.
 375
 376 2019-07-17  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui.c (tui_rl_other_window): Update.
 379         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 380         superclass method first.  Always iterate over regs_content.
 381         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 382         method.
 383         * tui/tui-win.c (tui_set_focus_command): Update.
 384
 385 2019-07-17  Tom Tromey  <tom@tromey.com>
 386
 387         * tui/tui-win.c (tui_set_focus_command): Rename from
 388         tui_set_focus.  Call tui_enable.
 389         (tui_set_focus_command): Remove.
 390
 391 2019-07-17  Tom Tromey  <tom@tromey.com>
 392
 393         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 394         refresh_window.
 395         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 396         touchwin.
 397         (tui_data_window::refresh_window): Call refresh_window on data
 398         items.  Always call superclass refresh_window.
 399         (tui_win_info::refresh): Remove.
 400         (tui_source_window_base::refresh_window): Update.
 401         (tui_refresh_all): Update.
 402         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 403         refresh_window.
 404         (show_source_or_disasm_and_command): Likewise.
 405         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 406         (struct tui_source_window_base) <refresh>: Likewise.
 407
 408 2019-07-17  Tom Tromey  <tom@tromey.com>
 409
 410         * tui/tui-winsource.c (tui_clear_source_content)
 411         (tui_show_source_content): Update.
 412         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 413         whether content is empty.
 414         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 415         Remove.
 416
 417 2019-07-17  Tom Tromey  <tom@tromey.com>
 418
 419         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 420         window's contents.
 421         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 422         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 423
 424 2019-07-17  Tom Tromey  <tom@tromey.com>
 425
 426         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 427         (struct tui_data_item_window): Update.
 428
 429 2019-07-17  Tom Tromey  <tom@tromey.com>
 430
 431         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 432         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 433         defines.
 434
 435 2019-07-17  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui-winsource.h (tui_erase_source_content)
 438         (tui_clear_source_content): Remove "display_prompt" parameter.
 439         * tui/tui-winsource.c (tui_update_source_window_as_is)
 440         (tui_update_source_windows_with_addr): Update.
 441         (tui_clear_source_content): Remove "display_prompt" parameter.
 442         (tui_erase_source_content): Likewise.  Simplify.
 443         (tui_show_source_content): Update.
 444         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 445         * tui/tui-stack.c (tui_show_frame_info): Update.
 446         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 447         Remove defines.
 448
 449 2019-07-17  Tom Tromey  <tom@tromey.com>
 450
 451         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 452         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 453         parameter.
 454         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 455         parameter.
 456
 457 2019-07-17  Tom Tromey  <tom@tromey.com>
 458
 459         * tui/tui-winsource.c (tui_clear_source_content)
 460         (tui_show_source_content, tui_show_exec_info_content)
 461         (tui_clear_exec_info_content): Update.
 462         * tui/tui-stack.c (tui_show_locator_content): Update.
 463         (tui_show_frame_info): Update.
 464         * tui/tui-source.h (tui_source_window): Don't declare.
 465         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 466         from tui_source_is_displayed.
 467         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 468         Remove field.
 469         (struct tui_source_window_base) <content_in_use>: New field.  Now
 470         bool.
 471         (struct tui_source_window) <showing_source_p>: New method.
 472         (TUI_SRC_WIN): Change cast.
 473         * tui/tui-data.c (tui_initialize_static_data): Update.
 474
 475 2019-07-17  Tom Tromey  <tom@tromey.com>
 476
 477         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 478         location_matches_p.
 479         * tui/tui-source.c (tui_source_window::location_matches_p): New
 480         method.
 481         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 482         method.
 483         * tui/tui-data.h (struct tui_source_window_base)
 484         <location_matches_p>: New method.
 485         (struct tui_source_window, struct tui_disasm_window)
 486         <location_matches_p>: Likewise.
 487
 488 2019-07-17  Tom Tromey  <tom@tromey.com>
 489
 490         * tui/tui-win.c (tui_set_win_height_command): Rename from
 491         tui_set_win_height.
 492         (tui_set_win_height_command): Remove.
 493
 494 2019-07-17  Tom Tromey  <tom@tromey.com>
 495
 496         * tui/tui-source.c (tui_source_window): New constructor.  Add
 497         observer.
 498         (~tui_source_window): New destructor.
 499         (tui_source_window::style_changed): New method.
 500         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 501         (tui_attach_detach_observers): Update.
 502         * tui/tui-data.h (struct tui_source_window): Make constructor not
 503         inline.  Add destructor.
 504         (struct tui_source_window) <style_changed>: New method.
 505         <m_observable>: New member.
 506
 507 2019-07-17  Tom Tromey  <tom@tromey.com>
 508
 509         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 510         * tui/tui-win.c (tui_resize_all): Fix typo.
 511
 512 2019-07-17  Tom Tromey  <tom@tromey.com>
 513
 514         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 515         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 516         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 517         * tui/tui-win.c (window_name_completer): Use foreach.
 518         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 519         (update_tab_width): Likewise.
 520         * tui/tui-layout.c (show_layout): Update.
 521         * tui/tui-data.h (class tui_window_iterator): New.
 522         (struct all_tui_windows): New.
 523         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 524
 525 2019-07-17  Tom Tromey  <tom@tromey.com>
 526
 527         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 528         parameter.  Don't reference globals.
 529         (tui_reg_command): Update.
 530
 531 2019-07-17  Tom Tromey  <tom@tromey.com>
 532
 533         * tui/tui-regs.c (tui_show_registers): Simplify.
 534
 535 2019-07-17  Tom Tromey  <tom@tromey.com>
 536
 537         * tui/tui-regs.c (tui_show_registers): Update.
 538         (tui_show_register_group): Add win_info parameter.
 539
 540 2019-07-17  Tom Tromey  <tom@tromey.com>
 541
 542         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 543         Rename from tui_display_reg_element_at_line.
 544         (tui_data_window::display_registers_from_line): Update.
 545         * tui/tui-data.h (struct tui_data_window)
 546         <display_reg_element_at_line>: New method.
 547
 548 2019-07-17  Tom Tromey  <tom@tromey.com>
 549
 550         * tui/tui-regs.h (tui_display_registers_from)
 551         (tui_display_registers_from_line): Don't declare.
 552         * tui/tui-windata.c (tui_data_window::display_all_data)
 553         (tui_data_window::refresh_all)
 554         (tui_data_window::do_scroll_vertical): Update.
 555         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 556         from tui_display_registers_from.
 557         (tui_display_reg_element_at_line): Update.
 558         (tui_data_window::display_registers_from_line): Rename from
 559         tui_display_registers_from_line.
 560         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 561         display_registers_from_line>: New methods.
 562
 563 2019-07-17  Tom Tromey  <tom@tromey.com>
 564
 565         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 566         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 567         from tui_erase_data_content.
 568         (tui_data_window::display_all_data)
 569         (tui_data_window::refresh_all)
 570         (tui_data_window::do_scroll_vertical): Update.
 571         * tui/tui-regs.c (tui_show_registers): Update.
 572         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 573         New method.
 574
 575 2019-07-17  Tom Tromey  <tom@tromey.com>
 576
 577         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 578         declare.
 579         * tui/tui-windata.c
 580         (tui_data_window::delete_data_content_windows): Rename from
 581         tui_delete_data_content_windows.
 582         (tui_data_window::display_all_data)
 583         (tui_data_window::do_scroll_vertical): Update.
 584         * tui/tui-data.h (struct tui_data_window)
 585         <delete_data_content_windows>: New method.
 586
 587 2019-07-17  Tom Tromey  <tom@tromey.com>
 588
 589         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 590         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 591
 592 2019-07-17  Tom Tromey  <tom@tromey.com>
 593
 594         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 595         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 596         from tui_display_all_data.
 597         * tui/tui-win.c
 598         (tui_data_window::do_make_visible_with_new_height): Update.
 599         * tui/tui-regs.c (tui_show_registers): Update.
 600         * tui/tui-layout.c (tui_set_layout): Update.
 601         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 602         method.
 603
 604 2019-07-17  Tom Tromey  <tom@tromey.com>
 605
 606         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 607         * tui/tui-windata.c (tui_display_data_from): Remove.
 608         (tui_data_window::refresh_all): Update.
 609
 610 2019-07-17  Tom Tromey  <tom@tromey.com>
 611
 612         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 613         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 614         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 615         tui_display_registers_from_line.
 616         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 617         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 618         "force_display" parameter.
 619
 620 2019-07-17  Tom Tromey  <tom@tromey.com>
 621
 622         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 623         declare.
 624         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 625         Rename from tui_first_reg_element_no_inline.
 626         (tui_display_reg_element_at_line)
 627         (tui_display_registers_from_line): Update.
 628         * tui/tui-data.h (struct tui_data_window)
 629         <first_reg_element_no_inline>: New method.
 630
 631 2019-07-17  Tom Tromey  <tom@tromey.com>
 632
 633         * tui/tui-windata.c (tui_display_data_from)
 634         (tui_data_window::do_scroll_vertical): Update.
 635         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 636         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 637         Rename from tui_line_from_reg_element_no.
 638         (tui_display_registers_from_line): Update.
 639         * tui/tui-data.h (struct tui_data_window)
 640         <line_from_reg_element_no>: New method.
 641
 642 2019-07-17  Tom Tromey  <tom@tromey.com>
 643
 644         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 645         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 646         tui_last_regs_line_no.
 647         (tui_display_reg_element_at_line)
 648         (tui_display_registers_from_line): Update.
 649         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 650         method.
 651
 652 2019-07-17  Tom Tromey  <tom@tromey.com>
 653
 654         PR tui/24722:
 655         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 656         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 657         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 658         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 659         (tui_update_breakpoint_info): Likewise.
 660         * tui/tui-hooks.c (tui_event_create_breakpoint)
 661         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 662         Update.
 663
 664 2019-07-17  Tom Tromey  <tom@tromey.com>
 665
 666         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 667
 668 2019-07-17  Tom Tromey  <tom@tromey.com>
 669
 670         * tui/tui-winsource.c (tui_update_source_window_as_is)
 671         (tui_update_source_windows_with_addr): Update.
 672         * tui/tui-source.h (tui_set_source_content)
 673         (tui_show_symtab_source): Add "win_info" parameter.
 674         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 675         parameter.
 676         (tui_show_symtab_source): Likewise.
 677
 678 2019-07-17  Tom Tromey  <tom@tromey.com>
 679
 680         * tui/tui-wingeneral.c
 681         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 682
 683 2019-07-17  Tom Tromey  <tom@tromey.com>
 684
 685         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 686         (struct tui_cmd_window) <can_scroll>: New method.
 687         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 688         method.
 689
 690 2019-07-17  Tom Tromey  <tromey@adacore.com>
 691
 692         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 693         do_field_signed>: Rename.  Change type of "value".
 694         * ui-out.c (ui_out::field_signed): Rename from field_int.
 695         Change type of "value".
 696         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 697         type of "value".
 698         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 699         do_field_int.  Change type of "value".
 700         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 701         do_field_int.  Change type of "value".
 702         * tracepoint.c (trace_status_mi, tfind_1)
 703         (print_one_static_tracepoint_marker): Update.
 704         * thread.c (print_thread_info_1, print_selected_thread_frame):
 705         Update.
 706         * stack.c (print_frame, print_frame_info): Update.
 707         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 708         Update.
 709         * source.c (print_source_lines_base): Update.
 710         * skip.c (info_skip_command): Update.
 711         * record-btrace.c (btrace_ui_out_decode_error)
 712         (btrace_call_history_src_line): Update.
 713         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 714         Update.
 715         * progspace.c (print_program_space): Update.
 716         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 717         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 718         do_field_int.  Change type of "value".
 719         * mi/mi-out.c (mi_ui_out::do_table_begin)
 720         (mi_ui_out::do_table_header): Update.
 721         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 722         type of "value".
 723         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 724         (mi_cmd_data_list_changed_registers, output_register)
 725         (mi_cmd_data_read_memory, mi_load_progress)
 726         (mi_cmd_trace_frame_collected): Update.
 727         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 728         Update.
 729         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 730         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 731         (mi_cmd_var_list_children, varobj_update_one): Update.
 732         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 733         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 734         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 735         * inferior.c (print_inferior): Update.
 736         * gdb_bfd.c (print_one_bfd): Update.
 737         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 738         Update.
 739         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 740         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 741         do_field_int.  Change type of "value".
 742         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 743         do_field_int.  Change type of "value".
 744         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 745         (print_one_breakpoint_location, print_it_catch_fork)
 746         (print_one_catch_fork, print_it_catch_vfork)
 747         (print_one_catch_vfork, print_it_catch_solib)
 748         (print_it_catch_exec, print_it_ranged_breakpoint)
 749         (print_mention_watchpoint, print_mention_masked_watchpoint)
 750         (bkpt_print_it, update_static_tracepoint): Update.
 751         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 752         * break-catch-syscall.c (print_it_catch_syscall): Update.
 753         * ada-tasks.c (print_ada_task_info): Update.
 754         * ada-lang.c (print_it_exception, print_mention_exception):
 755         Update.
 756
 757 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 758
 759         PR breakpoints/24541
 760         * gdbarch.c: Regenerate.
 761         * gdbarch.h: Regenerate.
 762         * gdbarch.sh: Adjust return type and parameter types for
 763         'stap_adjust_register'.
 764         (i386_stap_adjust_register): Adjust signature and return new
 765         register name.
 766         * stap-probe.c (stap_parse_register_operand): Adjust use of
 767         'gdbarch_stap_adjust_register'.
 768
 769 2019-07-17  Tom Tromey  <tromey@adacore.com>
 770
 771         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 772         declare VEC.
 773         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 774         std::vector.
 775         (struct s390_process_info): Add initializers.
 776         (s390_add_process): Use new.
 777         (s390_linux_nat_target::low_forget_process): Use delete.
 778         (s390_linux_nat_target::low_new_fork)
 779         (s390_linux_nat_target::stopped_by_watchpoint)
 780         (s390_linux_nat_target::low_prepare_to_resume)
 781         (s390_linux_nat_target::insert_watchpoint)
 782         (s390_linux_nat_target::insert_hw_breakpoint)
 783         (s390_linux_nat_target::remove_watchpoint)
 784         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 785
 786 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 787
 788         * aarch64-fbsd-nat.c: Include regcache.h.
 789         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 790         argument.
 791         (aarch64_fbsd_nat_target::fetch_registers)
 792         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 793         variable.
 794         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 795
 796 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 797
 798         * fbsd-nat.c: Include gdbarch.h.
 799
 800 2019-07-15  Tom Tromey  <tromey@adacore.com>
 801
 802         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 803
 804 2019-07-15  Tom Tromey  <tromey@adacore.com>
 805
 806         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 807         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 808         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 809         * cli-out.c (cli_ui_out::do_field_int): New method.
 810         * ui-out.c (ui_out::field_unsigned): New method.
 811         * symfile.c (generic_load): Use field_unsigned.
 812         (print_transfer_performance): Likewise.
 813         * record-btrace.c (ui_out_field_uint): Remove.
 814         (btrace_call_history_insn_range, btrace_call_history): Use
 815         field_unsigned.
 816         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 817         field_unsigned.
 818         * ui-out.h (class ui_out) <field_unsigned>: New method.
 819         <do_field_unsigned>: Likewise.
 820
 821 2019-07-15  Tom Tromey  <tromey@adacore.com>
 822
 823         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 824         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 825         * target.c (flash_erase_command): Use field_string.
 826         * infrun.c (print_signal_received_reason): Use field_string.
 827         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 828         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 829         field_string.
 830         * ada-tasks.c (print_ada_task_info): Use field_string.
 831
 832 2019-07-15  Tom Tromey  <tromey@adacore.com>
 833
 834         * target.c (flash_erase_command): Use field_core_addr.
 835         * symfile.c (generic_load): Use field_core_addr.
 836         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 837         Use field_core_addr.
 838         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 839         field_core_addr.
 840
 841 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 842
 843         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 844         value if its desired type is smaller than a CORE_ADDR and signed.
 845
 846 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 847
 848         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 849         of changes to field names, and use new is_reference field to
 850         decide if a property is a reference or not.
 851         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 852         field.
 853         (struct dwarf2_property_baton): Update header comment, rename
 854         'referenced_type' to 'property_type' and update comments.
 855         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 856         default property type, store in property baton, update to take
 857         accound of renamed field.
 858         (read_func_scope): Update call to attr_to_dynamic_prop.
 859         (read_array_type): Likewise.
 860         (dwarf2_per_cu_addr_sized_int_type): New function.
 861         (read_subrange_index_type): Move type finding code to
 862         dwarf2_per_cu_addr_sized_int_type.
 863         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 864         (dwarf2_per_cu_addr_type): New function.
 865         (set_die_type): Update calls to attr_to_dynamic_prop.
 866
 867 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 868
 869         * dwarf2read.c (read_subrange_index_type): New function.
 870         (read_subrange_type): Move code into new function and call it.
 871         * gdbtypes.c (create_range_type): Add some asserts.
 872
 873 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 874
 875         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 876         update return statements.
 877         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 878         declaration, and update comment to match.
 879         * gdbtypes.c (resolve_dynamic_array): Update call to
 880         dwarf2_evaluate_property to match new return type.
 881
 882 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 883
 884         * valarith.c (value_subscripted_rvalue): Change lowerbound
 885         parameter type from int to LONGEST.
 886         * value.h (value_subscripted_rvalue): Likewise in declaration.
 887
 888 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 889
 890         * cli/cli-utils.c (info_print_command_completer): New function.
 891         * cli/cli-utils.h: Add 'completer.h' include, and forward
 892         declaration for 'struct cmd_list_element'.
 893         (info_print_command_completer): Declare.
 894         * stack.c (_initialize_stack): Add completer for 'info locals' and
 895         'info args'.
 896         * symtab.c (_initialize_symtab): Add completer for 'info
 897         variables' and 'info functions'.
 898         * NEWS: Mention completion for additional info commands.
 899
 900 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 901
 902         * cli/cli-utils.c (extract_info_print_args): Delete.
 903         (extract_arg_maybe_quoted): Delete.
 904         (info_print_options_defs): New variable.
 905         (make_info_print_options_def_group): New function.
 906         (extract_info_print_options): Define new function.
 907         * cli/cli-utils.h (extract_info_print_args): Delete.
 908         (struct info_print_options): New structure.
 909         (extract_info_print_options): Declare new function.
 910         * stack.c (info_locals_command): Update to use new
 911         extract_info_print_options, also add a header comment.
 912         (info_args_command): Likewise.
 913         * symtab.c (info_variables_command): Likewise.
 914         (info_functions_command): Likewise.
 915
 916 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 917
 918         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 919         to extract string arguments.
 920         * common/common-utils.c (extract_string_maybe_quoted): New function.
 921         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 922
 923 2019-07-11  Tom Tromey  <tromey@adacore.com>
 924
 925         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 926         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 927         * top.h (gdbinit): Don't declare.
 928         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 929         into...
 930         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 931         * top.c (gdb_init): Don't call init_cli_cmds.
 932         (gdbinit): Remove.
 933         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 934
 935 2019-07-11  Tom Tromey  <tromey@adacore.com>
 936
 937         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 938         after it has been moved.
 939
 940 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 941
 942         * valops.c (value_must_coerce_to_target): Change return type to
 943         bool.
 944         * value.h (value_must_coerce_to_target): Likewise.
 945
 946 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 947
 948         * breakpoint.c (is_hardware_watchpoint): Remove
 949         forward-declaration.
 950         (is_masked_watchpoint): Change return type to bool.
 951         (is_tracepoint): Likewise.
 952         (is_breakpoint): Likewise.
 953         (is_hardware_watchpoint): Likewise.
 954         (is_watchpoint): Likewise.
 955         (is_no_memory_software_watchpoint): Likewise.
 956         (is_catchpoint): Likewise.
 957         (breakpoint_1): Make FILTER parameter's return type bool.
 958         is_masked_watchpoint): Change return type to bool.
 959         (save_breakpoints): Make FILTER parameter's return type bool.
 960         * breakpoint.h (is_breakpoint): Change return type to bool.
 961         (is_watchpoint): Likewise.
 962         (is_catchpoint): Likewise.
 963         (is_tracepoint): Likewise.
 964
 965 2019-07-10  Tom Tromey  <tom@tromey.com>
 966
 967         * defs.h: Don't include gdbarch.h.
 968         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 969         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 970         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 971         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 972         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 973         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 974         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 975         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 976         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 977         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 978         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 979         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 980         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 981         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 982         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 983         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 984         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 985         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 986         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 987         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 988         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 989         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 990         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 991         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 992         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 993         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 994         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 995
 996 2019-07-10  Tom Tromey  <tromey@adacore.com>
 997
 998         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 999         * breakpoint.c (init_ada_exception_breakpoint): Register as
1000         bp_catchpoint.
1001         (print_one_breakpoint_location, print_one_breakpoint): Use
1002         is_ada_exception_catchpoint.
1003         * ada-lang.c (class ada_catchpoint_location): Pass
1004         bp_loc_software_breakpoint to bp_location constructor.
1005         (is_ada_exception_catchpoint): New function.
1006
1007 2019-07-10  Tom Tromey  <tromey@adacore.com>
1008
1009         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1010         VEC.
1011         (struct arm_exidx_entry): New method operator<.
1012         (struct arm_exidx_data) <section_maps>: Change type.
1013         (arm_exidx_data_free): Remove.
1014         (arm_exidx_data_key): Change type.  Move lower.
1015         (arm_exidx_new_objfile): Update.
1016         (arm_compare_exidx_entries): Remove.
1017         (arm_find_exidx_entry, _initialize_arm_tdep)
1018
1019 2019-07-10  Tom Tromey  <tromey@adacore.com>
1020
1021         * solib-spu.c (ocl_program_data_key): Change type.
1022         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1023         Update.
1024
1025 2019-07-10  Tom Tromey  <tromey@adacore.com>
1026
1027         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1028         (struct solib_aix_inferior_data) <library_list>: Change type.
1029         (solib_aix_inferior_data_handle): Change type.
1030         (get_solib_aix_inferior_data): Update.
1031         (solib_aix_free_library_list): Remove.
1032         (library_list_start_library): Update.
1033         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1034         return type.
1035         (solib_aix_get_library_list)
1036         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1037         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1038
1039 2019-07-10  Tom Tromey  <tromey@adacore.com>
1040
1041         * solib-dsbt.c (struct dsbt_info): Add initializers.
1042         (solib_dsbt_pspace_data): Change type.
1043         (dsbt_pspace_data_cleanup): Remove.
1044         (get_dsbt_info, _initialize_dsbt_solib): Update.
1045
1046 2019-07-10  Tom Tromey  <tromey@adacore.com>
1047
1048         * spu-tdep.c (spu_overlay_data): Change type.
1049         (spu_get_overlay_table, spu_overlay_new_objfile)
1050         (_initialize_spu_tdep): Update.
1051
1052 2019-07-10  Tom Tromey  <tromey@adacore.com>
1053
1054         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1055         destructor.
1056         (dbx_objfile_data_key): Change type and declare later.
1057         (DBX_SYMFILE_INFO): Rewrite.
1058         * dbxread.c (dbx_objfile_data_key): Change type.
1059         (dbx_symfile_init): Update.
1060         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1061         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1062         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1063
1064 2019-07-10  Tom Tromey  <tromey@adacore.com>
1065
1066         * jit.c (jit_program_space_key): Change type.  Move lower.
1067         (get_jit_program_space_data): Update.
1068         (jit_program_space_data_cleanup): Remove.
1069         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1070         Update.
1071         (struct jit_program_space_data): Add initializers.
1072
1073 2019-07-10  Tom Tromey  <tromey@adacore.com>
1074
1075         * solib-darwin.c (struct darwin_info): Add initializers.
1076         (solib_darwin_pspace_data): Change type.
1077         (darwin_pspace_data_cleanup): Remove.
1078         (get_darwin_info, _initialize_darwin_solib): Update.
1079
1080 2019-07-10  Tom Tromey  <tromey@adacore.com>
1081
1082         * remote-sim.c (struct sim_inferior_data): Add initializers,
1083         constructor, and destructor.
1084         (sim_inferior_data_key): Change type.  Move lower.
1085         (check_for_duplicate_sim_descriptor): Update.
1086         (get_sim_inferior_data): Use new.  Update.
1087         (~sim_inferior_data_cleanup): Rename from
1088         sim_inferior_data_cleanup.  Simplify.
1089         (gdbsim_close_inferior, simulator_command)
1090         (sim_command_completer, _initialize_remote_sim): Update.
1091         (next_pid, INITIAL_PID): Move earlier.
1092
1093 2019-07-10  Tom Tromey  <tromey@adacore.com>
1094
1095         * python/python-internal.h (create_thread_object): Return
1096         gdbpy_ref.
1097         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1098         * python/py-inferior.c (struct threadlist_entry): Add
1099         constructor.
1100         <thread_obj>: Now a gdbpy_ref.
1101         (thread_to_thread_object): Update.
1102         (add_thread_object): Use new.
1103         (delete_thread_object): Use delete.
1104         (infpy_threads): Update.
1105         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1106         GIL.
1107
1108 2019-07-10  Tom Tromey  <tromey@adacore.com>
1109
1110         * valops.c (value_cast): Specialize error message for Ada.
1111
1112 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1113
1114         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1115
1116 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1117
1118         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1119         bpstat_should_step): Return bool, adjust comments.
1120         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1121         bpstat_should_step): Likewise.
1122
1123 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1124
1125         * features/Makefile: Use feature target descriptions for Arm.
1126         * features/arm/arm-core.c: Generate new file.
1127         * features/arm/arm-fpa.c: Likewise.
1128         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1129         * features/arm/arm-m-profile.c: Likewise.
1130         * features/arm/arm-vfpv2.c: Likewise.
1131         * features/arm/arm-vfpv3.c: Likewise.
1132         * features/arm/xscale-iwmmxt.c: Likewise.
1133         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1134
1135 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1136
1137         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1138         ptrace earlier.
1139
1140 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1141
1142         * features/aarch64-pauth.c: Regenerate.
1143
1144 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1145
1146         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1147         bool.
1148         (bpstat_what): Use false instead of 0.
1149
1150 2019-07-09  Pedro Alves  <palves@redhat.com>
1151
1152         * break-catch-throw.c (is_exception_catchpoint): New.
1153         * breakpoint.c (print_one_breakpoint_location): New parameter
1154         'raw_loc'.  Handle it.  Use
1155         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1156         looking at the breakpoint's type.
1157         (print_one_breakpoint): If handling "maint info breakpoints", also
1158         print locations of exception catchpoints.
1159         * breakpoint.h (is_exception_catchpoint): Declare.
1160
1161 2019-07-09  Pedro Alves  <palves@redhat.com>
1162
1163         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1164         "addr" field.
1165         (allocate_location_exception_catchpoint): New.
1166         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1167         (initialize_throw_catchpoint_ops): Install
1168         allocate_location_exception_catchpoint as allocate_location
1169         method.
1170         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1171         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1172         bp_loc_other.
1173         (breakpoint_address_is_meaningful): Delete.
1174         (bl_address_is_meaningful): New.
1175         (breakpoint_locations_match): Adjust comment.
1176         (bp_location_from_bp_type): New, factored out of...
1177         (bp_location::bp_location(breakpoint *)): ... this.
1178         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1179         factored out of...
1180         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1181         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1182         breakpoint_address_is_meaningful.
1183         (bp_locations_compare): Adjust comment.
1184         (update_global_location_list): Use bl_address_is_meaningful
1185         instead of breakpoint_address_is_meaningful.
1186         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1187         explicit.
1188         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1189         * python/py-breakpoint.c (bppy_get_location): No longer check
1190         whether location is null.
1191
1192 2019-07-09  Pedro Alves  <palves@redhat.com>
1193
1194         PR c++/15468
1195         * breakpoint.c (print_one_breakpoint_location): Remove
1196         single-location assert.
1197
1198 2019-07-09  Tom Tromey  <tom@tromey.com>
1199
1200         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1201         * configure: Rebuild.
1202         * configure.ac: Change common to gdbsupport.
1203         * gdbsupport: Rename from common.
1204         * acinclude.m4: Change common to gdbsupport.
1205         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1206         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1207         gdbsupport.
1208         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1209         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1210         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1211         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1212         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1213         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1214         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1215         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1216         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1217         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1218         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1219         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1220         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1221         coff-pe-read.c, command.h, compile/compile-c-support.c,
1222         compile/compile-c.h, compile/compile-cplus-symbols.c,
1223         compile/compile-cplus-types.c, compile/compile-cplus.h,
1224         compile/compile-loc2c.c, compile/compile.c, completer.c,
1225         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1226         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1227         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1228         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1229         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1230         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1231         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1232         features/aarch64-core.c, features/aarch64-fpu.c,
1233         features/aarch64-pauth.c, features/aarch64-sve.c,
1234         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1235         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1236         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1237         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1238         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1239         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1240         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1241         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1242         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1243         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1244         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1245         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1246         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1247         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1248         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1249         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1250         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1251         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1252         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1253         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1254         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1255         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1256         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1257         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1258         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1259         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1260         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1261         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1262         minsyms.c, mips-linux-tdep.c, namespace.h,
1263         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1264         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1265         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1266         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1267         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1268         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1269         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1270         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1271         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1272         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1273         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1274         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1275         procfs.c, producer.c, progspace.h, psymtab.h,
1276         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1277         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1278         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1279         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1280         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1281         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1282         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1283         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1284         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1285         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1286         target-memory.c, target.c, target.h, target/waitstatus.c,
1287         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1288         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1289         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1290         unittests/array-view-selftests.c,
1291         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1292         unittests/common-utils-selftests.c,
1293         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1294         unittests/format_pieces-selftests.c,
1295         unittests/function-view-selftests.c,
1296         unittests/lookup_name_info-selftests.c,
1297         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1298         unittests/mkdir-recursive-selftests.c,
1299         unittests/observable-selftests.c,
1300         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1301         unittests/parse-connection-spec-selftests.c,
1302         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1303         unittests/scoped_fd-selftests.c,
1304         unittests/scoped_mmap-selftests.c,
1305         unittests/scoped_restore-selftests.c,
1306         unittests/string_view-selftests.c, unittests/style-selftests.c,
1307         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1308         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1309         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1310         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1311         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1312         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1313
1314 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1315
1316         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1317         bool value.
1318         (decode_digits_ordinary): Set explicit_line field in sal.
1319         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1320         symtab_and_line that was set on an explicit line number in
1321         assembler code.  Do always update the recorded symtab and line if
1322         we do skip the prologue.
1323
1324 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1325
1326         * breakpoint.c (set_breakpoint_location_function): Remove
1327         explicit_loc parameter.
1328         (momentary_breakpoint_from_master): Update call to
1329         set_breakpoint_location_function.
1330         (add_location_to_breakpoint): Likewise.
1331
1332 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1333
1334         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1335         required features based on default bfd type when no specific bfd
1336         is present.
1337
1338 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1339
1340         * NEWS: Mention that GDB printf and eval commands can now print
1341         C-style and Ada-style convenience var strings without
1342         calling the inferior.
1343         * printcmd.c (printf_c_string): Locally print GDB internal var
1344         instead of transiting via the inferior.
1345         (printf_wide_c_string): Likewise.
1346
1347 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1348
1349         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1350
1351 2019-07-04  Tom Tromey  <tom@tromey.com>
1352
1353         PR tui/24724:
1354         * tui/tui-winsource.c (tui_clear_source_content): Update.
1355         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1356         (tui_update_breakpoint_info): Update.
1357         (tui_set_exec_info_content): Update.
1358         * tui/tui-source.c (tui_set_source_content_nil): Update.
1359         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1360         has_break.
1361         * tui/tui-data.h (enum tui_bp_flag): New.
1362         (tui_bp_flags): New enum flags type.
1363         (struct tui_source_element) <break_mode>: Change type.  Rename
1364         from has_break.
1365         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1366         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1367         constants.
1368         * tui/tui-winsource.h: Fix comment.
1369
1370 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1371
1372         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1373         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1374         (store_fpregs_to_thread)
1375         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1376         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1377         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1378         (IWMMXT_REGS_SIZE): Add define.
1379         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1380         (fetch_vfp_regs, store_vfp_regs)
1381         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1382         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1383
1384 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1385
1386         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1387         defines.
1388         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1389         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1390         (ARM_INT_REGISTER_SIZE): ...to this.
1391         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1392         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1393         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1394         (arm_linux_collect_gregset, supply_nwfpe_register)
1395         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1396         defines.
1397         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1398         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1399         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1400         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1401         (arm_return_in_memory, arm_store_return_value)
1402         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1403         (arm_record_ld_st_multiple): Likewise.
1404         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1405         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1406
1407 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1408
1409         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1410         AARCH64_DISPLACED_MODIFIED_INSNS.
1411         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1412         (aarch64_displaced_step_copy_insn): Likewise.
1413         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1414         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1415         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1416         ARM_DISPLACED_MODIFIED_INSNS.
1417         * arm-tdep.c (arm_gdbarch_init): Likewise.
1418         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1419         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1420         (struct arm_displaced_step_closure): Use
1421         ARM_DISPLACED_MODIFIED_INSNS.
1422
1423 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1424
1425         * features/Makefile: Remove unused xml files.
1426         * features/aarch64.xml: Remove.
1427         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1428         * features/i386/amd64-avx-avx512.xml: Remove.
1429         * features/i386/amd64-avx-linux.xml: Remove.
1430         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1431         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1432         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1433         * features/i386/amd64-avx-mpx.xml: Remove.
1434         * features/i386/amd64-avx.xml: Remove.
1435         * features/i386/amd64-linux.xml: Remove.
1436         * features/i386/amd64-mpx-linux.xml: Remove.
1437         * features/i386/amd64-mpx.xml: Remove.
1438         * features/i386/amd64.xml: Remove.
1439         * features/i386/i386-avx-avx512-linux.xml: Remove.
1440         * features/i386/i386-avx-avx512.xml: Remove.
1441         * features/i386/i386-avx-linux.xml: Remove.
1442         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1443         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1444         * features/i386/i386-avx-mpx-linux.xml: Remove.
1445         * features/i386/i386-avx-mpx.xml: Remove.
1446         * features/i386/i386-avx.xml: Remove.
1447         * features/i386/i386-linux.xml: Remove.
1448         * features/i386/i386-mmx-linux.xml: Remove.
1449         * features/i386/i386-mmx.xml: Remove.
1450         * features/i386/i386-mpx-linux.xml: Remove.
1451         * features/i386/i386-mpx.xml: Remove.
1452         * features/i386/i386.xml: Remove.
1453         * features/i386/x32-avx-avx512-linux.xml: Remove.
1454         * features/i386/x32-avx-linux.xml: Remove.
1455         * features/i386/x32-linux.xml: Remove.
1456
1457 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1458
1459         * regformats/aarch64.dat: Remove.
1460         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1461         * regformats/i386/amd64-avx-linux.dat: Remove.
1462         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1463         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1464         * regformats/i386/amd64-linux.dat: Remove.
1465         * regformats/i386/amd64-mpx-linux.dat: Remove.
1466         * regformats/i386/amd64.dat: Remove.
1467         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1468         * regformats/i386/i386-avx-linux.dat: Remove.
1469         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1470         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1471         * regformats/i386/i386-linux.dat: Remove.
1472         * regformats/i386/i386-mmx-linux.dat: Remove.
1473         * regformats/i386/i386-mpx-linux.dat: Remove.
1474         * regformats/i386/i386.dat: Remove.
1475         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1476         * regformats/i386/x32-avx-linux.dat: Remove.
1477         * regformats/i386/x32-linux.dat: Remove.
1478
1479 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1480
1481         * aarch64-tdep.c: Remove xml self tests.
1482         * amd64-linux-tdep.c: Likewise.
1483         * amd64-tdep.c: Likewise.
1484         * i386-linux-tdep.c: Likewise.
1485         * i386-tdep.c: Likewise.
1486
1487 2019-07-03  Pedro Alves  <palves@redhat.com>
1488
1489         PR cli/24732
1490         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1491         (pipe_cmd_option_defs): New.
1492         (make_pipe_cmd_options_def_group): New.
1493         (pipe_command): Use gdb::option::process_options.
1494         (pipe_command_completer): New function.
1495         (_initialize_cli_cmds): Install completer for "pipe" command.
1496
1497 2019-07-03  Pedro Alves  <palves@redhat.com>
1498
1499         * cli/cli-option.c (union option_value) <string>: New field.
1500         (struct option_def_and_value): Add ctor, move ctor, dtor and
1501         use DISABLE_COPY_AND_ASSIGN.
1502         (option_def_and_value::clear_value): New.
1503         (parse_option, save_option_value_in_ctx, get_val_type_str)
1504         (add_setshow_cmds_for_options): Handle var_string.
1505         * cli-option.h (union option_def::var_address) <string>: New
1506         field.
1507         (struct string_option_def): New.
1508         * maint-test-options.c (struct test_options_opts): Add default
1509         ctor and use DISABLE_COPY_AND_ASSIGN.
1510         <string_opt>: New field.
1511         (test_options_opts::~test_options_opts): New.
1512         (test_options_opts::dump): Also dump "-string".
1513         (test_options_option_defs): Install "string.
1514
1515 2019-07-03  Pedro Alves  <palves@redhat.com>
1516
1517         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1518         option_value with a null enumeration.
1519         (complete_options): Save the option values in the context.
1520         (save_option_value_in_ctx): New, factored out from ...
1521         (process_options): ... here.
1522         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1523         of the function.
1524         * maint-test-options.c (test_options_opts::dump): New, factored
1525         out from ...
1526         (maintenance_test_options_command_mode): ... here.
1527         (maintenance_test_options_command_completion_result): Delete.
1528         (maintenance_test_options_command_completion_text): Update
1529         comment.
1530         (maintenance_show_test_options_completion_result): Change
1531         prototype.  Just print
1532         maintenance_test_options_command_completion_text.
1533         (save_completion_result): New.
1534         (maintenance_test_options_completer_mode): Pass options context to
1535         complete_options, and then save a dump.
1536         (_initialize_maint_test_options): Use add_cmd to install "maint
1537         show test-options-completion-result".
1538
1539 2019-07-03  Pedro Alves  <palves@redhat.com>
1540
1541         * NEWS (New commands): Mention "with" and "maint with".
1542         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1543         (with_command, with_command_completer): New.
1544         (pipe_command): Adjust to new repeat_previous
1545         interface.
1546         (_initialize_cli_cmds): Install the "with" command and its "w"
1547         alias.
1548         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1549         declarations.
1550         * cli/cli-setshow.c (parse_cli_var_uinteger)
1551         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1552         argument strings for all var_types.
1553         (get_setshow_command_value_string): New, factored out from ...
1554         (do_show_command): ... this.
1555         * cli/cli-setshow.h: Include <string>.
1556         (get_setshow_command_value_string): Declare.
1557         * command.h (repeat_previous): Now returns const char *.  Adjust
1558         comment.
1559         * maint.c: Include "cli/cli-cmds.h".
1560         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1561         (_initialize_maint_cmds): Register the "maintenance with" command.
1562         * top.c (repeat_previous): Move bits from pipe_command here:
1563         Return the saved command line, if any; error out if there's no
1564         command to relaunch.
1565
1566 2019-07-03  Pedro Alves  <palves@redhat.com>
1567
1568         * NEWS (New commands): Mention "maint set/show test-settings"
1569         instead of "maint test-settings".
1570         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1571         (maintenance_test_settings_set_list): Rename to ...
1572         (maintenance_set_test_settings_list): ... this.
1573         (maintenance_test_settings_show_list): Rename to  ...
1574         (maintenance_show_test_settings_list): ... this.
1575         (maintenance_test_settings_cmd): Delete.
1576         (maintenance_test_settings_set_cmd): ...
1577         (maintenance_set_test_settings_cmd): ... this.
1578         (maintenance_test_settings_show_cmd): ...
1579         (maintenance_show_test_settings_cmd): ... this.
1580         (maintenance_test_settings_show_value_cmd):
1581         (maintenance_show_test_settings_value_cmd): ... this.
1582         (_initialize_maint_test_settings): No longer install the "maint
1583         test-settings" prefix command.  Rename "maint test-settings set"
1584         to "maint set test-settings", and "maint test-settings show" to
1585         "maint show test-settings".  Adjust all subcommands.
1586
1587 2019-07-03  Pedro Alves  <palves@redhat.com>
1588
1589         * maint-test-settings.c: Fix file's intro comment.  Replace all
1590         references to "test-options" with references to "test-settings",
1591         in comments.
1592
1593 2019-07-03  Pedro Alves  <palves@redhat.com>
1594
1595         * maint-test-settings.c (maintenance_test_settings_xxx)
1596         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1597         New.
1598         (maintenance_test_settings_enums): Use them.
1599         (maintenance_test_settings_enum): Default to
1600         maintenance_test_settings_xxx.
1601         (_initialize_maint_test_settings): Initialize
1602         MAINTENANCE_TEST_SETTINGS_FILENAME.
1603
1604 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1605
1606         * breakpoint.h (remove_breakpoints_inf): Change return type to
1607         void, move function documentation here.
1608         * breakpoint.c (remove_breakpoints_inf): Change return type to
1609         void, move function documentation to header.
1610
1611 2019-07-02  Pedro Alves  <palves@redhat.com>
1612
1613         * NEWS (Completion improvements): Mention "info threads".
1614         * thread.c (struct info_threads_opts, info_threads_option_defs)
1615         (make_info_threads_options_def_group): New.
1616         (info_threads_command): Use gdb::option::process_options.
1617         (info_threads_command_completer): New.
1618         (_initialize_thread): Use gdb::option::build_help to build the
1619         help text for "info threads".
1620
1621 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1622
1623         * defs.h (generic_load): Move from here...
1624         * symfile.h (generic_load): ... to here.  Rename name parameter
1625         to args.
1626         * symfile.c (generic_load): Add comment.
1627
1628 2019-07-01  Tom Tromey  <tromey@adacore.com>
1629
1630         * dwarf2read.c
1631         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1632         declaration of without_params.  Fix formatting.
1633
1634 2019-07-01  Tom Tromey  <tromey@adacore.com>
1635
1636         * ada-exp.y (find_primitive_type): Update.
1637         * ada-lang.h (ada_lookup_symbol): Update.
1638         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1639         parameter.
1640         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1641
1642 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1643
1644         PR breakpoints/24541
1645         * gdbarch.c: Regenerate.
1646         * gdbarch.h: Regenerate.
1647         * gdbarch.sh: Add 'stap_adjust_register'.
1648         * i386-tdep.c: Include '<unordered_set>'.
1649         (i386_stap_adjust_register): New function.
1650         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1651         * stap-probe.c (stap_parse_register_operand): Call
1652         'gdbarch_stap_adjust_register'.
1653
1654 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1655
1656         PR python/24742
1657         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1658         * python/python.c (do_start_initialization): Use 'xmalloc'
1659         instead of 'PyMem_Malloc'.
1660
1661 2019-06-28  Tom Tromey  <tromey@adacore.com>
1662
1663         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1664         for Ada.
1665
1666 2019-06-27  Tom Tromey  <tromey@adacore.com>
1667
1668         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1669         objfile_key.
1670         (arm_find_mapping_symbol, arm_record_special_symbol)
1671         (_initialize_arm_tdep): Update.
1672         (arm_objfile_data_free): Remove.
1673
1674 2019-06-27  Tom Tromey  <tromey@adacore.com>
1675
1676         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1677         to cp_print_static_field.
1678
1679 2019-06-26  Tom Tromey  <tromey@adacore.com>
1680
1681         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1682         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1683         declare.
1684
1685 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1686
1687         * features/aarch64-core.c (create_feature_aarch64_core):
1688         Regenerate.
1689         * features/aarch64-core.xml: Add cpsr flags.
1690
1691 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1692
1693         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1694         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1695
1696 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1697
1698         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1699         field.
1700         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1701         use.
1702         (arm_record_special_symbol): Don't insert new symbol in sorted
1703         position, push it at the end.
1704
1705 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1706
1707         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1708         (arm_mapping_symbol_s): Remove.
1709         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1710         (arm_mapping_symbol_vec): New typedef.
1711         (struct arm_per_objfile): Add constructor.
1712         <section_maps>: Change type to
1713         std::unique_ptr<arm_mapping_symbol_vec[]>.
1714         (arm_compare_mapping_symbols): Remove.
1715         (arm_find_mapping_symbol): Adjust to section_maps type change.
1716         (arm_objfile_data_free): Call delete on arm_per_objfile.
1717         (arm_record_special_symbol): Adjust to section_maps type change.
1718         Allocate arm_per_objfile with new.
1719
1720 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1721
1722         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1723         with the command prefix.
1724
1725 2019-06-25  Tom Tromey  <tom@tromey.com>
1726
1727         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1728         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1729
1730 2019-06-25  Tom Tromey  <tom@tromey.com>
1731
1732         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1733         type.
1734         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1735         protected.
1736
1737 2019-06-25  Tom Tromey  <tom@tromey.com>
1738
1739         * tui/tui-winsource.c
1740         (tui_source_window_base::set_is_exec_point_at): Add check against
1741         LOA_ADDRESS.
1742
1743 2019-06-25  Tom Tromey  <tom@tromey.com>
1744
1745         * tui/tui-source.c (tui_set_source_content): Don't check before
1746         xfree.
1747         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1748
1749 2019-06-25  Tom Tromey  <tom@tromey.com>
1750
1751         * tui/tui-winsource.h (tui_update_source_window_as_is)
1752         (tui_alloc_source_buffer, tui_line_is_displayed)
1753         (tui_addr_is_displayed): Change type of win_info.
1754         * tui/tui-winsource.c (tui_update_source_window_as_is)
1755         (tui_clear_source_content, tui_show_source_line)
1756         (tui_show_source_content, tui_source_window_base::refill)
1757         (tui_source_window_base::set_is_exec_point_at)
1758         (tui_source_window_base::set_is_exec_point_at)
1759         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1760         (tui_alloc_source_buffer, tui_line_is_displayed)
1761         (tui_addr_is_displayed): Change type of win_info.  Update.
1762         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1763         (tui_source_window_base::do_make_visible_with_new_height):
1764         Update.
1765         * tui/tui-source.c (tui_set_source_content)
1766         (tui_set_source_content_nil)
1767         (tui_source_window::do_scroll_vertical): Update.
1768         * tui/tui-layout.c (show_layout): Update.
1769         * tui/tui-disasm.c (tui_set_disassem_content)
1770         (tui_disasm_window::do_scroll_vertical): Update.
1771         * tui/tui-data.h (tui_win_content): Remove.
1772         (struct tui_gen_win_info) <content, content_size>: Remove.
1773         (struct tui_source_element): Add initializers and destructor.
1774         (union tui_which_element, struct tui_win_element): Remove.
1775         (struct tui_source_window_base) <content>: New field.
1776         (struct tui_data_window): Remove destructor.
1777         (tui_alloc_content, tui_free_win_content)
1778         (tui_free_all_source_wins_content): Don't declare.
1779         * tui/tui-data.c (tui_initialize_static_data): Update.
1780         (init_content_element, tui_alloc_content): Remove.
1781         (~tui_gen_win_info): Update.
1782         (~tui_data_window, tui_free_all_source_wins_content)
1783         (tui_free_win_content, free_content, free_content_elements):
1784         Remove.
1785
1786 2019-06-25  Tom Tromey  <tom@tromey.com>
1787
1788         * tui/tui-winsource.h (tui_clear_source_content)
1789         (tui_erase_source_content, tui_show_source_content): Change type
1790         of win_info.
1791         * tui/tui-winsource.c (tui_clear_source_content)
1792         (tui_erase_source_content, tui_show_source_content): Change type
1793         of win_info.
1794         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1795         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1796         win_info.
1797         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1798         win_info.
1799         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1800
1801 2019-06-25  Tom Tromey  <tom@tromey.com>
1802
1803         * tui/tui-winsource.c (tui_clear_source_content)
1804         (tui_source_window_base::set_is_exec_point_at): Update.
1805         * tui/tui-source.c (tui_set_source_content_nil): Update.
1806         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1807         a bool.
1808         * tui/tui-data.c (init_content_element): Update.
1809
1810 2019-06-25  Tom Tromey  <tom@tromey.com>
1811
1812         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1813         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1814         * tui/tui-layout.c (init_and_make_win): Update.
1815         * tui/tui.h (enum tui_win_type): Update.
1816         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1817         tui_win_is_auxillary.
1818         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1819         tui_win_is_auxillary.
1820
1821 2019-06-25  Tom Tromey  <tom@tromey.com>
1822
1823         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1824         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1825         (tui_delete_data_content_windows, tui_display_all_data)
1826         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1827         Update.
1828         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1829         * tui/tui-regs.c (tui_last_regs_line_no)
1830         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1831         (tui_show_registers): Update.
1832         (tui_show_register_group): Return void.  Update.
1833         (tui_display_registers_from, tui_display_reg_element_at_line)
1834         (tui_display_registers_from_line, tui_check_register_values):
1835         Update.
1836         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1837         member.
1838         (struct tui_data_window) <regs_content>: Now a std::vector.
1839         <regs_content_count>: Remove.
1840         (tui_add_content_elements, tui_free_data_content): Don't declare.
1841         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1842         (init_content_element): Remove DATA_WIN case.  Add assert.
1843         (tui_add_content_elements): Remove.
1844         (tui_data_window): Update.
1845         (tui_free_data_content): Remove.
1846         (free_content_elements): Remove DATA_WIN case.
1847
1848 2019-06-25  Tom Tromey  <tom@tromey.com>
1849
1850         * tui/tui-data.c (tui_data_item_window): Update.
1851         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1852         * tui/tui-windata.c (tui_display_all_data)
1853         (tui_display_data_from_line): Update.
1854         (tui_check_data_values): Remove.
1855         * tui/tui-regs.c (tui_show_register_group)
1856         (tui_display_reg_element_at_line): Update.
1857         * tui/tui-hooks.c (tui_register_changed)
1858         (tui_refresh_frame_and_register_information): Call
1859         tui_check_register_values.
1860         * tui/tui-data.h (struct tui_data_window) <data_content,
1861         data_content_count, data_type>: Remove.
1862         (enum tui_data_type): Remove.
1863
1864         * tui/tui-data.c (tui_data_window::clear_detail)
1865         (~tui_data_window): Update.
1866
1867 2019-06-25  Tom Tromey  <tom@tromey.com>
1868
1869         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1870         declare.
1871         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1872         Rename from tui_first_data_item_displayed.  Update.
1873         (tui_data_window::refresh_all)
1874         (tui_data_window::do_scroll_vertical): Update.
1875         * tui/tui-data.h (struct tui_data_window)
1876         <first_data_item_displayed>: Declare new method.
1877
1878 2019-06-25  Tom Tromey  <tom@tromey.com>
1879
1880         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1881         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1882         contents...
1883         (tui_initialize_static_data): ...here.
1884
1885 2019-06-25  Tom Tromey  <tom@tromey.com>
1886
1887         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1888         (tui_display_registers_from, tui_check_register_values): Update.
1889         (tui_display_register): Remove win_info parameter; update.
1890         (tui_get_register): Change type of parameters.
1891         * tui/tui-data.h (struct tui_data_element): Remove.
1892         (union tui_which_element) <data>: Remove.
1893         <data_window>: Change type.
1894         (struct tui_data_item_window): New.
1895         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1896         case.  Add assert.
1897         (~tui_data_item_window): New destructor.
1898         (free_content_elements): Remove DATA_ITEM_WIN case.
1899
1900 2019-06-25  Tom Tromey  <tom@tromey.com>
1901
1902         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1903         Remove.
1904
1905 2019-06-25  Tom Tromey  <tom@tromey.com>
1906
1907         * tui/tui-data.h (struct tui_command_element): Remove.
1908         (union tui_which_element) <command>: Remove.
1909         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1910         assert.
1911         (free_content_elements): Remove CMD_WIN case.
1912
1913 2019-06-25  Tom Tromey  <tom@tromey.com>
1914
1915         * tui/tui-layout.c (tui_set_layout): Update.
1916         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1917         * tui/tui-data.c (layout_def): Update.
1918
1919 2019-06-25  Tom Tromey  <tom@tromey.com>
1920
1921         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1922         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1923         (tui_source_window_base::set_new_height): Update.
1924         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1925         Update.
1926         (tui_set_locator_fullname, tui_set_locator_info)
1927         (tui_show_frame_info): Update.
1928         * tui/tui-source.c (tui_set_source_content)
1929         (tui_source_is_displayed): Update.
1930         * tui/tui-layout.c (show_source_disasm_command, show_data)
1931         (show_source_or_disasm_and_command): Update.
1932         * tui/tui-disasm.c (tui_set_disassem_content)
1933         (tui_get_begin_asm_address): Update.
1934         * tui/tui-data.h (struct tui_locator_element): Remove.
1935         (union tui_which_element) <locator>: Remove.
1936         (struct tui_locator_window): New.
1937         (tui_locator_win_info_ptr): Change return type.
1938         * tui/tui-data.c (_locator): Change type.
1939         (tui_locator_win_info_ptr): Change return type.
1940         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1941         (tui_alloc_content): Add assert.
1942
1943 2019-06-25  Tom Tromey  <tom@tromey.com>
1944
1945         * tui/tui-winsource.c
1946         (tui_exec_info_window::maybe_allocate_content): New method.
1947         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1948         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1949         (make_source_or_disasm_window): Add cast.
1950         * tui/tui-data.h (union tui_which_element) <simple_string>:
1951         Remove.
1952         (struct tui_source_info): New.
1953         (struct tui_source_window_base) <execution_info>: Change type.
1954         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1955         case, and add assert.
1956         (tui_alloc_content): Add assert.
1957
1958 2019-06-25  Tom Tromey  <tom@tromey.com>
1959
1960         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1961         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1962         * tui/tui-data.c (tui_alloc_win_info): Remove.
1963
1964 2019-06-25  Tom Tromey  <tom@tromey.com>
1965
1966         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1967         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1968         can_highlight.
1969
1970 2019-06-25  Tom Tromey  <tom@tromey.com>
1971
1972         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1973         make_visible_with_new_height method.
1974         (tui_win_info::make_visible_with_new_height): New method.
1975         (tui_source_window_base::do_make_visible_with_new_height)
1976         (tui_data_window::do_make_visible_with_new_height)
1977         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1978         (make_visible_with_new_height): Remove.
1979         (tui_resize_all, tui_adjust_win_heights): Use
1980         make_visible_with_new_height method.
1981         * tui/tui-data.h (struct tui_win_info)
1982         <do_make_visible_with_new_height, make_visible_with_new_height>:
1983         New methods.
1984         (struct tui_source_window_base, struct tui_data_window)
1985         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1986         methods.
1987
1988 2019-06-25  Tom Tromey  <tom@tromey.com>
1989
1990         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1991         method.
1992         (update_tab_width): Call update_tab_width method.
1993         * tui/tui-data.h (struct tui_win_info)
1994         (struct tui_source_window_base) <update_tab_width>: New methods.
1995
1996 2019-06-25  Tom Tromey  <tom@tromey.com>
1997
1998         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1999         parameter.
2000         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2001         parameter.
2002         (tui_gen_win_info::make_visible): Update.
2003         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2004         parameter.
2005         * tui/tui-data.h (enum tui_box): New enum.
2006         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2007
2008 2019-06-25  Tom Tromey  <tom@tromey.com>
2009
2010         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2011         init_and_make_win for EXEC_INFO_WIN.
2012         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2013         longer inline.
2014         (struct tui_win_info) <~tui_win_info>: Inline.
2015         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2016         Don't declare.
2017         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2018         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2019         Remove.
2020         (tui_initialize_static_data): Update.
2021         (~tui_gen_win_info): Handle more cleanup here.
2022         (~tui_source_window_base): Delete "execution_info".
2023         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2024
2025 2019-06-25  Tom Tromey  <tom@tromey.com>
2026
2027         * tui/tui-layout.c (make_command_window): Don't set
2028         can_highlight.
2029         (show_source_disasm_command): Call the reset method.
2030         (show_data): Don't set can_highlight.  Call the reset method.
2031         (tui_gen_win_info::reset): Rename from init_gen_win_info
2032         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2033         (show_source_or_disasm_and_command): Call the reset method.
2034         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2035         (struct tui_cmd_window): Set can_highlight.
2036
2037 2019-06-25  Tom Tromey  <tom@tromey.com>
2038
2039         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2040         from make_visible.
2041         (tui_make_visible, tui_make_invisible): Rewrite.
2042         (tui_win_info::make_visible): Remove.
2043         (tui_source_window_base::make_visible): Update.
2044         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2045         method.  Moved from...
2046         (struct tui_win_info) <make_visible>: ...here.
2047
2048 2019-06-25  Tom Tromey  <tom@tromey.com>
2049
2050         * tui/tui-winsource.c
2051         (tui_source_window_base::do_scroll_horizontal): Remove direction
2052         parameter.
2053         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2054         direction parameter.
2055         * tui/tui-win.c (tui_win_info::forward_scroll)
2056         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2057         (tui_win_info::right_scroll): Update.
2058         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2059         direction parameter.
2060         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2061         direction parameter.
2062         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2063         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2064         Remove direction parameter.
2065         (struct tui_source_window_base, struct tui_source_window)
2066         (struct tui_disasm_window, struct tui_data_window)
2067         (struct tui_cmd_window): Update.
2068
2069 2019-06-25  Tom Tromey  <tom@tromey.com>
2070
2071         * tui/tui-winsource.h (tui_set_exec_info_content)
2072         (tui_show_exec_info_content, tui_erase_exec_info_content)
2073         (tui_clear_exec_info_content, tui_update_exec_info): Change
2074         argument to tui_source_window_base.
2075         * tui/tui-winsource.c (tui_set_exec_info_content)
2076         (tui_show_exec_info_content, tui_erase_exec_info_content)
2077         (tui_clear_exec_info_content, tui_update_exec_info): Change
2078         argument to tui_source_window_base.
2079
2080 2019-06-25  Tom Tromey  <tom@tromey.com>
2081
2082         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2083         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2084
2085 2019-06-25  Tom Tromey  <tom@tromey.com>
2086
2087         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2088         check.
2089
2090 2019-06-25  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2093         type to void.
2094         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2095         type to void.
2096         * tui/tui-source.c (tui_set_source_content): Update.
2097         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2098
2099 2019-06-25  Tom Tromey  <tom@tromey.com>
2100
2101         * tui/tui-win.c (window_name_completer, tui_set_focus)
2102         (tui_all_windows_info): Use name method.
2103         * tui/tui-data.h (struct tui_gen_win_info)
2104         (struct tui_source_window, struct tui_disasm_window)
2105         (struct tui_data_window, struct tui_cmd_window) <name>: New
2106         method.
2107         (tui_win_name): Don't declare.
2108         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2109         (tui_win_name): Remove.
2110
2111 2019-06-25  Tom Tromey  <tom@tromey.com>
2112
2113         * tui/tui-winsource.h (tui_update_source_window)
2114         (tui_update_source_window_as_is): Change parameter type.
2115         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2116         to be a tui_source_window_base.
2117         (tui_update_source_window_as_is): Likewise.
2118         * tui/tui-win.c (make_visible_with_new_height): Update.
2119
2120 2019-06-25  Tom Tromey  <tom@tromey.com>
2121
2122         * tui/tui-winsource.c (tui_erase_source_content)
2123         (tui_show_source_content, tui_show_exec_info_content)
2124         (tui_erase_exec_info_content): Use refresh_window method.
2125         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2126         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2127         from tui_refresh_win.
2128         (tui_data_window::refresh_window): New method.
2129         (tui_win_info::refresh, tui_source_window_base::refresh)
2130         (tui_refresh_all): Use refresh_window method.
2131         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2132         method.
2133         * tui/tui-regs.c (tui_display_register): Call refresh_window
2134         method.
2135         * tui/tui-layout.c (show_source_disasm_command)
2136         (show_source_or_disasm_and_command): Call refresh_window method.
2137         * tui/tui-data.h (struct tui_gen_win_info)
2138         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2139         New method.
2140
2141 2019-06-25  Tom Tromey  <tom@tromey.com>
2142
2143         * tui/tui.c (tui_rl_other_window, tui_enable)
2144         (tui_is_window_visible, tui_get_command_dimension): Update.
2145         * tui/tui-winsource.c (tui_update_source_window_as_is)
2146         (tui_clear_source_content, tui_erase_source_content)
2147         (tui_show_source_line, tui_source_window_base::refill)
2148         (tui_source_window_base::do_scroll_horizontal)
2149         (tui_source_window_base::set_is_exec_point_at)
2150         (tui_update_breakpoint_info, tui_set_exec_info_content)
2151         (tui_alloc_source_buffer, tui_line_is_displayed)
2152         (tui_addr_is_displayed): Update.
2153         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2154         (tui_check_and_display_highlight_if_needed)
2155         (tui_win_info::make_visible, tui_win_info::refresh)
2156         (tui_refresh_all): Update.
2157         * tui/tui-windata.c (tui_first_data_item_displayed)
2158         (tui_delete_data_content_windows, tui_erase_data_content)
2159         (tui_display_all_data, tui_data_window::refresh_all)
2160         (tui_check_data_values): Update.
2161         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2162         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2163         (tui_win_info::backward_scroll, tui_refresh_all_win)
2164         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2165         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2166         (tui_source_window_base::set_new_height)
2167         (tui_data_window::set_new_height)
2168         (make_invisible_and_set_new_height)
2169         (make_visible_with_new_height, new_height_ok)
2170         (parse_scrolling_args): Update.
2171         * tui/tui-stack.c (tui_show_frame_info): Update.
2172         * tui/tui-source.c (tui_set_source_content)
2173         (tui_set_source_content_nil, tui_source_is_displayed)
2174         (tui_source_window::do_scroll_vertical): Update.
2175         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2176         (tui_display_registers_from, tui_display_reg_element_at_line)
2177         (tui_check_register_values, tui_reg_command): Update.
2178         * tui/tui-layout.c (tui_default_win_height)
2179         (show_source_disasm_command, show_data, init_and_make_win)
2180         (show_source_or_disasm_and_command): Update.
2181         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2182         (tui_redisplay_readline, tui_mld_flush)
2183         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2184         (tui_getc): Update.
2185         * tui/tui-disasm.c (tui_set_disassem_content)
2186         (tui_disasm_window::do_scroll_vertical): Update.
2187         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2188         Now virtual.
2189         (struct tui_win_info): Derive from tui_gen_win_info.
2190         <~tui_win_info>: Mark as override.
2191         <generic>: Remove member.
2192         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2193         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2194         (~tui_data_window, ~tui_win_info)
2195         (tui_free_all_source_wins_content): Update.
2196         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2197
2198 2019-06-25  Tom Tromey  <tom@tromey.com>
2199
2200         * tui/tui-layout.c (init_and_make_win): Use new.
2201         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2202         destructor, initializers.
2203         (tui_alloc_generic_win_info): Don't declare.
2204         * tui/tui-data.c (_locator): Add argument to constructor.
2205         (source_win, disasm_win): New globals.
2206         (exec_info): Remove.
2207         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2208         Update.
2209         (tui_alloc_generic_win_info): Remove.
2210         (init_content_element): Use new.
2211         (tui_win_info::tui_win_info): Update.
2212         (free_content_elements) <case DATA_WIN>: Use delete.
2213
2214 2019-06-25  Tom Tromey  <tom@tromey.com>
2215
2216         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2217         * tui/tui-windata.c (tui_first_data_item_displayed)
2218         (tui_delete_data_content_windows): Update.
2219         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2220         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2221         (tui_display_registers_from, tui_check_register_values): Update.
2222         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2223         pointer.
2224         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2225         window.
2226         (tui_free_data_content): Update.
2227         (free_content_elements) <case DATA_WIN>: Free the window.
2228
2229 2019-06-25  Tom Tromey  <tom@tromey.com>
2230
2231         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2232         Update.
2233         * tui/tui-layout.c (make_command_window)
2234         (show_source_disasm_command, show_data, init_and_make_win)
2235         (show_source_or_disasm_and_command): Update.
2236         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2237         method.
2238         <can_highight, is_highlighted>: Now bool.
2239         (tui_set_win_highlight): Don't declare.
2240         * tui/tui-data.c (tui_set_win_highlight): Remove.
2241
2242 2019-06-25  Tom Tromey  <tom@tromey.com>
2243
2244         * tui/tui-wingeneral.c (make_visible): Remove check of window
2245         type.
2246
2247 2019-06-25  Tom Tromey  <tom@tromey.com>
2248
2249         * tui/tui-win.c (tui_win_info::max_height)
2250         (tui_cmd_window::max_height): New methods.
2251         (new_height_ok): Call max_height.
2252         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2253         <max_height>: New method.
2254
2255 2019-06-25  Tom Tromey  <tom@tromey.com>
2256
2257         * tui/tui-win.c (tui_source_window_base::set_new_height)
2258         (tui_data_window::set_new_height): New methods.
2259         (make_invisible_and_set_new_height): Call set_new_height method.
2260         * tui/tui-data.h (struct tui_win_info)
2261         (struct tui_source_window_base, struct tui_data_window)
2262         <set_new_height>: New method.
2263
2264 2019-06-25  Tom Tromey  <tom@tromey.com>
2265
2266         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2267         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2268         tui_refresh_data_win.
2269         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2270         method.
2271         (tui_refresh_all_win): Call the refresh_all method.
2272         (tui_set_focus): Likewise.
2273         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2274         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2275         Likewise.
2276
2277 2019-06-25  Tom Tromey  <tom@tromey.com>
2278
2279         * tui/tui-winsource.h (tui_refill_source_window)
2280         (tui_set_is_exec_point_at): Don't declare.
2281         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2282         (tui_source_window_base::refill): Rename from
2283         tui_refill_source_window.
2284         (tui_source_window_base::do_scroll_horizontal): Update.
2285         (tui_source_window_base::set_is_exec_point_at): Rename from
2286         tui_set_is_exec_point_at.
2287         (tui_update_all_breakpoint_info): Update.
2288         * tui/tui-stack.c (tui_show_frame_info): Update.
2289         * tui/tui-layout.c (show_data): Add cast.
2290         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2291         * tui/tui-data.h (struct tui_source_window_base) <refill,
2292         set_is_exec_point_at>: New methods.
2293         (tui_source_windows, tui_add_to_source_windows): Update types.
2294         (tui_add_to_source_windows): Remove redundant declaration.
2295         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2296         (tui_source_windows): Change return type.
2297         (tui_clear_source_windows_detail): Update.
2298         (tui_add_to_source_windows): Change type of parameter.
2299         (tui_free_all_source_wins_content): Update.
2300
2301 2019-06-25  Tom Tromey  <tom@tromey.com>
2302
2303         * tui/tui-wingeneral.c (tui_win_info::refresh)
2304         (tui_source_window_base::refresh): New methods.
2305         (tui_refresh_all): Call the refresh method.
2306         * tui/tui-data.h (struct tui_win_info)
2307         (struct tui_source_window_base) <refresh>: New method.
2308
2309 2019-06-25  Tom Tromey  <tom@tromey.com>
2310
2311         * tui/tui.h (tui_is_window_visible): Return bool.
2312         * tui/tui.c (tui_is_window_visible): Return bool.
2313         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2314         (tui_make_visible, tui_make_invisible)
2315         (tui_win_info::make_visible)
2316         (tui_source_window_base::make_visible, make_all_visible)
2317         (tui_make_all_visible, tui_make_all_invisible): Update.
2318         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2319         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2320         bool.
2321         (struct tui_win_info, struct tui_source_window_base)
2322         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2323         * tui/tui-data.c (tui_init_generic_part): Update.
2324
2325 2019-06-25  Tom Tromey  <tom@tromey.com>
2326
2327         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2328         (tui_source_window_base::make_visible): New methods.
2329         (make_all_visible): Make method call.
2330         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2331         (struct tui_source_window_base, struct tui_cmd_window): Override
2332         make_visible.
2333         (tui_win_is_source_type): Don't declare.
2334         * tui/tui-data.c (tui_win_is_source_type): Remove.
2335
2336 2019-06-25  Tom Tromey  <tom@tromey.com>
2337
2338         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2339         NULL check.
2340
2341 2019-06-25  Tom Tromey  <tom@tromey.com>
2342
2343         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2344         Inline constructor.  Add initializers for members.
2345         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2346         constructors; now inline in class.
2347
2348 2019-06-25  Tom Tromey  <tom@tromey.com>
2349
2350         * tui/tui-regs.c (tui_show_registers): Update.
2351         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2352         bool.
2353         * tui/tui-data.c (tui_data_window::clear_detail)
2354         (tui_data_window): Update.
2355
2356 2019-06-25  Tom Tromey  <tom@tromey.com>
2357
2358         * tui/tui-windata.c (tui_display_all_data)
2359         (tui_display_data_from_line, tui_display_data_from)
2360         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2361         Update.
2362         * tui/tui-regs.c (tui_last_regs_line_no)
2363         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2364         (tui_show_registers, tui_show_register_group)
2365         (tui_display_registers_from, tui_display_reg_element_at_line)
2366         (tui_display_registers_from_line, tui_check_register_values)
2367         (tui_reg_next, tui_reg_prev): Update.
2368         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2369         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2370         tui_data_window.
2371         (struct tui_win_info) <detail>: Remove.  Add new fields from
2372         tui_data_info.
2373         (TUI_DATA_WIN): Add cast.
2374         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2375         (~tui_data_window): Simplify.
2376
2377 2019-06-25  Tom Tromey  <tom@tromey.com>
2378
2379         * tui/tui-layout.c (show_source_disasm_command)
2380         (show_source_or_disasm_and_command): Update.
2381         * tui/tui-io.c (update_cmdwin_start_line)
2382         (tui_redisplay_readline): Update.
2383         * tui/tui-data.h (struct tui_command_info): Remove.
2384         (struct tui_win_info) <detail>: Remove command_info member.
2385         (struct tui_data_window) <start_line>: New member, from
2386         tui_command_info.
2387         (TUI_CMD_WIN): Add casts.
2388
2389 2019-06-25  Tom Tromey  <tom@tromey.com>
2390
2391         * tui/tui-winsource.c (tui_update_source_window)
2392         (tui_refill_source_window)
2393         (tui_source_window_base::do_scroll_horizontal)
2394         (tui_update_breakpoint_info, tui_set_exec_info_content)
2395         (tui_show_exec_info_content, tui_erase_exec_info_content)
2396         (tui_clear_exec_info_content): Update.
2397         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2398         Update.
2399         * tui/tui-win.c (make_invisible_and_set_new_height)
2400         (make_visible_with_new_height): Update.
2401         * tui/tui-source.c (tui_set_source_content)
2402         (tui_show_symtab_source): Update.
2403         * tui/tui-layout.c (extract_display_start_addr)
2404         (show_source_disasm_command, show_data)
2405         (make_source_or_disasm_window)
2406         (show_source_or_disasm_and_command): Update.
2407         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2408         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2409         "gdbarch".
2410         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2411         to tui_source_window_base.
2412         (struct tui_win_info) <detail>: Remove source_info member.
2413         (struct tui_source_window_base) <has_locator>: Inline.
2414         Move contents from tui_source_info; rename has_locator member to
2415         m_has_locator.
2416         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2417         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2418         header file.
2419         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2420         Simplify.
2421         (tui_free_all_source_wins_content): Cast to
2422         tui_source_window_base.
2423
2424 2019-06-25  Tom Tromey  <tom@tromey.com>
2425
2426         * tui/tui-win.c (make_invisible_and_set_new_height)
2427         (make_visible_with_new_height): Call has_locator method.
2428         * tui/tui-layout.c (show_source_disasm_command, show_data)
2429         (show_source_or_disasm_and_command): Update for bool change.
2430         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2431         (tui_win_info) <has_locator>: New method.
2432         (struct tui_source_window_base) <has_locator>: New method.
2433         (tui_win_has_locator): Don't declare.
2434         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2435         from tui_win_has_locator.
2436         (tui_source_window_base): Use false, not FALSE.
2437
2438 2019-06-25  Tom Tromey  <tom@tromey.com>
2439
2440         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2441         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2442         clear_detail method directly.
2443         (tui_clear_win_detail): Remove.
2444
2445 2019-06-25  Tom Tromey  <tom@tromey.com>
2446
2447         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2448         "this", not TUI_DISASM_WIN.
2449
2450 2019-06-25  Tom Tromey  <tom@tromey.com>
2451
2452         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2453         declare.
2454         * tui/tui-winsource.c
2455         (tui_source_window_base::do_scroll_horizontal): Rename from
2456         tui_horizontal_source_scroll.
2457         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2458         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2459         from tui_vertical_data_scroll.
2460         * tui/tui-win.h (tui_scroll): Don't declare.
2461         * tui/tui-win.c (tui_win_info::forward_scroll)
2462         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2463         (tui_win_info::right_scroll): Rename and update.
2464         (tui_scroll_forward_command, tui_scroll_backward_command)
2465         (tui_scroll_left_command, tui_scroll_right_command): Update.
2466         (tui_scroll): Remove.
2467         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2468         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2469         from tui_vertical_source_scroll.
2470         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2471         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2472         from tui_vertical_disassem_scroll.
2473         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2474         do_scroll_horizontal>: New methods.
2475         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2476         Likewise.
2477         (struct tui_source_window_base): Add do_scroll_horizontal.
2478         (struct tui_source_window, struct tui_disasm_window): Add
2479         do_scroll_vertical.
2480         (struct tui_data_window, struct tui_cmd_window): Add
2481         do_scroll_horizontal and do_scroll_vertical.
2482         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2483
2484 2019-06-25  Tom Tromey  <tom@tromey.com>
2485
2486         * tui/tui-data.h (struct tui_source_window_base): New struct.
2487         (struct tui_source_window): Derive from tui_source_window_base.
2488         (struct tui_disasm_window): New struct.
2489         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2490         from tui_source_window::clear_detail.
2491         (tui_source_window_base): Rename from tui_source_window.
2492         (~tui_source_window_base): Rename from ~tui_source_window.
2493         (tui_alloc_win_info): Create a tui_disasm_window.
2494
2495 2019-06-25  Tom Tromey  <tom@tromey.com>
2496
2497         * tui/tui-data.h (struct tui_source_window)
2498         (struct tui_data_window): Declare destructors.
2499         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2500         destructors.
2501         (tui_win_info): Simplify.
2502
2503 2019-06-25  Tom Tromey  <tom@tromey.com>
2504
2505         * tui/tui-winsource.c (tui_display_main)
2506         (tui_update_source_windows_with_addr)
2507         (tui_update_all_breakpoint_info): Update.
2508         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2509         (new_height_ok, parse_scrolling_args): Update.
2510         * tui/tui-stack.c (tui_show_frame_info): Update.
2511         * tui/tui-data.h (struct tui_list): Remove.
2512         (tui_source_windows): Return a reference to a std::vector.
2513         * tui/tui-data.c (source_windows): Now a std::vector.
2514         (tui_source_windows): Change return type.
2515         (tui_clear_source_windows): Rewrite.
2516         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2517         (tui_free_all_source_wins_content): Rewrite.
2518
2519 2019-06-25  Tom Tromey  <tom@tromey.com>
2520
2521         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2522         (struct tui_data_window, struct tui_cmd_window): Declare
2523         clear_detail method.
2524         * tui/tui-data.c (tui_source_window::clear_detail)
2525         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2526         methods.
2527         (tui_clear_win_detail): Simplify.
2528
2529 2019-06-25  Tom Tromey  <tom@tromey.com>
2530
2531         * tui/tui-layout.c (make_source_window, make_disasm_window)
2532         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2533         Return the new window.
2534         (show_source_disasm_command, show_data)
2535         (show_source_or_disasm_and_command): Update.
2536
2537 2019-06-25  Tom Tromey  <tom@tromey.com>
2538
2539         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2540         parameter.  Return the new window.
2541         (show_source_disasm_command): Update and remove NULL check.
2542         (show_source_or_disasm_and_command): Update.
2543
2544 2019-06-25  Tom Tromey  <tom@tromey.com>
2545
2546         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2547
2548 2019-06-25  Tom Tromey  <tom@tromey.com>
2549
2550         * tui/tui-data.h (struct tui_win_info): Make constructor
2551         protected.  Make destructor virtual.  Add initializers.
2552         (tui_source_window, tui_data_window, tui_cmd_window): New
2553         classes.
2554         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2555         constructor.  Add "type" parameter.
2556         (tui_source_window, tui_data_window, tui_cmd_window): New
2557         constructors.
2558         (tui_alloc_win_info): Instantiate the appropriate subclass.
2559
2560 2019-06-25  Tom Tromey  <tom@tromey.com>
2561
2562         * tui/tui-win.c (tui_resize_all): Use delete.
2563         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2564         destructor.
2565         (tui_free_window): Don't declare.
2566         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2567         Update.
2568
2569 2019-06-25  Tom Tromey  <tom@tromey.com>
2570
2571         * tui/tui-data.h (struct tui_win_info): Add constructor.
2572         * tui/tui-data.c (tui_alloc_win_info): Use new.
2573         (tui_free_window): Use delete.
2574
2575 2019-06-22  Tom Tromey  <tom@tromey.com>
2576
2577         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2578         declare.
2579         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2580
2581 2019-06-22  Tom Tromey  <tom@tromey.com>
2582
2583         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2584         declare.
2585         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2586
2587 2019-06-22  Tom de Vries  <tdevries@suse.de>
2588
2589         * dwarf2read.c (create_addrmap_from_aranges)
2590         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2591         instead of '%zu'.
2592
2593 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2594
2595         * dwarf2read.h (dwarf2_section_info_def): Remove.
2596         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2597         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2598         std::vector<dwarf2_section_info>.
2599         (struct dwo_file) <~dwo_file>: Remove.
2600         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2601         types field.
2602         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2603         (dwarf2_read_debug_names): Likewise.
2604         (create_debug_types_hash_table): Change parameter type to
2605         array_view, adjust code accordingly.
2606         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2607         (partial_die_info::fixup): Likewise.
2608         (determine_prefix): Likewise.
2609         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2610
2611 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2612
2613         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2614         gdb_bfd_ref_ptr.
2615         <~dwo_file>: Remove call to gdb_bfd_unref.
2616         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2617         gdb_bfd_ref_ptr::get.
2618
2619 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2620
2621         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2622         type to htab_up.
2623         * dwarf2read.c (struct dwo_file): Initialize fields.
2624         <~dwo_file>: New.
2625         (free_dwo_file): Remove, move content to ~dwo_file.
2626         (struct dwo_file_deleter): Remove.
2627         (dwo_file_up>: Remove custom deleter.
2628         (free_dwo_files): Remove.
2629         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2630         dwo_files.
2631         (process_skeletonless_type_units): Call unique_ptr::get.
2632         (allocate_dwo_file_hash_table): Add deleter to created hash
2633         table.  Change return type to htab_up.
2634         (lookup_dwo_file_slot): Don't memset dwo_file, call
2635         unique_ptr::get.
2636         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2637         (create_dwo_unit_in_dwp_v2): Likewise.
2638         (open_and_init_dwo_file): Likewise.
2639         (free_dwo_file_from_slot): Remove.
2640
2641 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2642
2643         * dwarf2read.h (struct dwarf2_section_info) <readin,
2644         is_virtual>: Change type to bool.
2645         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2646         true instead of 1.
2647
2648 2019-06-19  Tom Tromey  <tom@tromey.com>
2649
2650         * tui/tui-data.h (tui_init_content_element): Don't declare.
2651
2652 2019-06-19  Tom Tromey  <tom@tromey.com>
2653
2654         * tui/tui-data.h (tui_init_win_info): Don't declare.
2655
2656 2019-06-19  Tom de Vries  <tdevries@suse.de>
2657
2658         * dwarf2read.h (abstract_to_concrete): Change type to
2659         std::unordered_map<sect_offset, std::vector<sect_offset>,
2660         gdb::hash_enum<sect_offset>>.
2661
2662 2019-06-19  Tom Tromey  <tromey@adacore.com>
2663
2664         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2665         EVAL_AVOID_SIDE_EFFECTS specially.
2666
2667 2019-06-19  Tom Tromey  <tromey@adacore.com>
2668
2669         * source-cache.c (highlighter): New global.
2670         (source_cache::get_source_lines): Create a highlighter on demand.
2671
2672 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2673
2674         * defs.h (deprecated_interactive_hook): Delete declaration.
2675         * interps.c (clear_interpreter_hooks): Remove use of
2676         deprecated_interactive_hook.
2677         * top.c (deprecated_interactive_hook): Delete definition.
2678         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2679
2680 2019-06-18  Tom de Vries  <tdevries@suse.de>
2681
2682         PR gdb/24515
2683         * dwarf2read.h (abstract_to_concrete): Change type from
2684         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2685         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2686         * dwarf2read.c (read_variable): Update.
2687         (dwarf2_fetch_die_loc_sect_off): Update.
2688
2689 2019-06-17  Tom de Vries  <tdevries@suse.de>
2690
2691         PR gdb/24617
2692         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2693         accessing parent[parent_len - 1].
2694
2695 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2696
2697         PR gdb/24364
2698         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2699         call dtrace_process_dof with NULL dof.
2700
2701 2019-06-16  Tom de Vries  <tdevries@suse.de>
2702
2703         PR gdb/24445
2704         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2705
2706 2019-06-16  Tom Tromey  <tom@tromey.com>
2707
2708         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2709         (make_all_visible): Use address of member.
2710
2711 2019-06-16  Tom Tromey  <tom@tromey.com>
2712
2713         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2714         (tui_free_window, free_content, free_content_elements): Remove
2715         unnecessary cast.
2716         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2717         cast.
2718         * tui/tui-regs.c (tui_show_register_group)
2719         (tui_display_registers_from, tui_display_reg_element_at_line):
2720         Remove unnecessary cast.
2721
2722 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2723
2724         * linux-nat.c (normal_mask): Delete.
2725         (_initialize_linux_nat): Don't initialise normal_mask.
2726
2727 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2728
2729         PR gdb/24445
2730         * dwarf-index-write.h (write_psymtabs_to_index): Add
2731         dwz_basename parameter.
2732         * dwarf-index-write.c (write_gdbindex): Move file writing to
2733         write_gdbindex_1.  Change return type void.
2734         (assert_file_size): Move up, remove filename parameter.
2735         (write_gdbindex_1): New function.
2736         (write_debug_names): Change return type to void, call
2737         assert_file_size.
2738         (struct index_wip_file): New struct.
2739         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2740         file logic to index_wip_file.  Write index for dwz file if
2741         needed.
2742         (save_gdb_index_command): Pass basename of dwz file, if present.
2743         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2744         build-id of dwz file, if present.
2745         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2746         (dwarf2_get_dwz_file): Likewise.
2747         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2748         (dwarf2_get_dwz_file): Likewise.
2749
2750 2019-06-16  Tom Tromey  <tom@tromey.com>
2751
2752         * coffread.c (process_coff_symbol): Use xstrdup.
2753         * value.c (create_internalvar): Use xstrdup.
2754
2755 2019-06-16  Tom Tromey  <tom@tromey.com>
2756
2757         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2758         * breakpoint.c (stopin_command, stopat_command)
2759         (until_break_command, decode_location_default): Remove unnecessary
2760         cast.
2761         * utils.c (subset_compare): Remove unnecessary cast.
2762         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2763         cast.
2764         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2765         cast.
2766         * infcmd.c (path_command): Remove unnecessary cast.
2767         * coffread.c (decode_type): Remove unnecessary cast.
2768         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2769         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2770         * tui/tui-stack.c (tui_show_locator_content)
2771         (tui_show_frame_info): Remove unnecessary cast.
2772         * tui/tui-win.c (tui_scroll_forward_command)
2773         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2774         (parse_scrolling_args): Remove unnecessary cast.
2775         * tui/tui-data.c (init_win_info, tui_del_window)
2776         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2777         (free_content_elements): Remove unnecessary cast.
2778         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2779         unnecessary cast.
2780         * tui/tui-source.c (tui_set_source_content)
2781         (tui_vertical_source_scroll): Remove unnecessary cast.
2782         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2783         cast.
2784         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2785         * tui/tui-regs.c (tui_display_registers_from)
2786         (tui_display_register): Remove unnecessary cast.
2787         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2788         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2789         (make_visible): Remove unnecessary cast.
2790         * tui/tui-winsource.c (tui_erase_source_content)
2791         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2792         unnecessary cast.
2793         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2794         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2795         * stabsread.c (read_type, read_array_type, read_range_type):
2796         Remove unnecessary cast.
2797         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2798         (parse_symbol, parse_type, upgrade_type, parse_external)
2799         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2800         unnecessary cast.
2801         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2802
2803 2019-06-16  Tom Tromey  <tom@tromey.com>
2804
2805         * tui/tui-data.c (tui_alloc_generic_win_info)
2806         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2807         checks.
2808
2809 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2810             Andrew Burgess  <andrew.burgess@embecosm.com>
2811
2812         * f-typeprint.c (f_print_type): Don't return early for not
2813         associated or not allocated types.
2814         (f_type_print_varspec_suffix): Add print_rank parameter and print
2815         ranks of array types in case they dangling.
2816         (f_type_print_base): Add print_rank parameter.
2817
2818 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2819
2820         * NEWS: Mention new MI commands.
2821         * break-catch-throw.c (enum exception_event_kind): Move to
2822         breakpoint.h.
2823         (print_mention_exception_catchpoint): Output text as a single
2824         message.
2825         (catch_exception_command_1): Rename to...
2826         (catch_exception_event): ...this, make non-static, update header
2827         command, and change some parameter types.
2828         (catch_catch_command): Update for changes to
2829         catch_exception_command_1.
2830         (catch_throw_command): Likewise.
2831         (catch_rethrow_command): Likewise.
2832         * breakpoint.c (enum exception_event_kind): Delete.
2833         * breakpoint.h (enum exception_event_kind): Moved here from
2834         break-catch-throw.c.
2835         (catch_exception_event): Declare.
2836         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2837         (mi_cmd_catch_throw): New function.
2838         (mi_cmd_catch_rethrow): New function.
2839         (mi_cmd_catch_catch): New function.
2840         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2841         'catch-catch' entries.
2842         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2843         (mi_cmd_catch_rethrow): Declare.
2844         (mi_cmd_catch_catch): Declare.
2845
2846 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2847
2848         * annotate.c (annotate_source_line): Change return type to void,
2849         update implementation to match.
2850         * annotate.h (annotate_source_line): Change return type to void,
2851         update header comment.
2852         * stack.c (print_frame_info): Don't change what frame information
2853         is printed based on whether annotations are on or not.
2854
2855 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2856
2857         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2858         (annotate_source): Make static.
2859         (annotate_source_line): Moved from source.c and renamed from
2860         identify_source_line.  Update the return type.
2861         * annotate.h (annotate_source): Delete declaration.
2862         (annotate_source_line): Declaration moved from source.h, and
2863         renamed from identify_source_line.  Return type updated.
2864         * source.c (identify_source_line): Moved to annotate.c and renamed
2865         to annotate_source_line.
2866         (info_line_command): Remove check of annotation_level.
2867         * source.h (identify_source_line): Move declaration to annotate.h
2868         and rename to annotate_source_line.
2869         * stack.c: Add 'annotate.h' include.
2870         (print_frame_info): Remove check of annotation_level before
2871         calling annotate_source_line.
2872
2873 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2874
2875         * source-cache.c (source_cache::get_plain_source_lines): Use
2876         open_source_file_with_line_charpos instead of just
2877         open_source_file, remove call to find_source_lines.
2878         (source_cache::get_source_lines): Likewise.
2879         * source.c (find_source_lines): Make static.
2880         (get_filename_and_charpos): Renamed into...
2881         (open_source_file_with_line_charpos): ..this along with changes to
2882         return a scoped_fd, and some other minor clean ups.
2883         (identify_source_line): Use open_source_file_with_line_charpos.
2884         (search_command_helper): Use open_source_file_with_line_charpos
2885         instead of just open_source_file, remove call to
2886         find_source_lines.
2887         * source.h (open_source_file_with_line_charpos): Declare new
2888         function.
2889         (find_source_lines): Delete declaration.
2890
2891 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2892
2893         * source.c (get_filename_and_charpos): Remove fullname
2894         parameter.
2895         (identify_source_line): Update call to get_filename_and_charpos.
2896
2897 2019-06-14  Tom Tromey  <tromey@adacore.com>
2898
2899         PR gdb/24502:
2900         * ui-style.h (skip_ansi_escape): Update comment.
2901         * ui-file.h (class no_terminal_escape_file): New class.
2902         * ui-file.c (no_terminal_escape_file::write)
2903         (no_terminal_escape_file::puts): New methods.
2904         * cli/cli-logging.c (handle_redirections): Use
2905         no_terminal_escape_file.
2906
2907 2019-06-14  Tom Tromey  <tromey@adacore.com>
2908
2909         * NEWS: Move convenience variable news above Python news.
2910
2911 2019-06-14  Tom Tromey  <tom@tromey.com>
2912
2913         * gnulib: Move directory to top-level.
2914         * configure.ac: Don't configure gnulib.
2915         * configure: Rebuild.
2916         * common/common-defs.h: Use new path to gnulib.
2917         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2918         (GNULIB_H): Remove.
2919         (INCGNU): Look in new gnulib location.
2920         (HFILES_NO_SRCDIR): Remove gnulib files.
2921         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2922         (generated_files): Remove GNULIB_H.
2923         ($(LIBGNU), all-lib): Remove targets.
2924         (distclean): Don't mention GNULIB_BUILDDIR.
2925         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2926
2927 2019-06-14  Tom Tromey  <tromey@adacore.com>
2928
2929         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2930         Warn if symbol file does not provide any symbols.
2931
2932 2019-06-14  Tom Tromey  <tromey@adacore.com>
2933
2934         * source.c (find_and_open_source): Respect basenames_may_differ.
2935
2936 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2937
2938         * annotate.c (annotate_breakpoints_invalid): Make use of
2939         scoped_restore_terminal_state.
2940         (annotate_frames_invalid): Likewise.
2941
2942 2019-06-14  Tom Tromey  <tromey@adacore.com>
2943
2944         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2945         allow assignment to an internalvar.
2946
2947 2019-06-14  Tom Tromey  <tromey@adacore.com>
2948
2949         * ada-lex.l: Allow "_" in attribute names.
2950
2951 2019-06-14  Tom Tromey  <tromey@adacore.com>
2952
2953         PR gdb/24653:
2954         * regcache.c (registers_changed): Don't call alloca.
2955         * top.c (execute_command): Don't call alloca.
2956
2957 2019-06-13  Pedro Alves  <palves@redhat.com>
2958
2959         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2960         'expression'.  When parsing an expression, error out if there's
2961         junk after "unlimited".
2962         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2963         (do_set_command): Adjust calls to is_unlimited_literal.
2964
2965 2019-06-13  Pedro Alves  <palves@redhat.com>
2966
2967         * compile/compile.c (make_compile_options_def_group): Add braces
2968         around array_view initializer.
2969         * thread.c (make_thread_apply_all_options_def_group)
2970         (make_thread_apply_all_options_def_group): Likewise.
2971
2972 2019-06-13  Pedro Alves  <palves@redhat.com>
2973
2974         * NEWS (New commands): Mention "maint test-options
2975         require-delimiter", "maint test-options unknown-is-error", "maint
2976         test-options unknown-is-operand" and "maint show
2977         test-options-completion-result".
2978         (New command options, command completion): New section.
2979         (Completion improvements): New section.
2980         Mention that you can abbreviate "unlimited".
2981
2982 2019-06-13  Pedro Alves  <palves@redhat.com>
2983
2984         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2985         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2986         * unittests/cli-utils-selftests.c (test_parse_flags)
2987         (test_parse_flags_qcs): Delete.
2988         (test_cli_utils): Don't call deleted functions.
2989
2990 2019-06-13  Pedro Alves  <palves@redhat.com>
2991
2992         * thread.c: Include "cli/cli-option.h".
2993         (tp_array_compar_ascending): Global.
2994         (tp_array_compar): Delete function.
2995         (tp_array_compar_ascending, tp_array_compar_descending): New
2996         functions.
2997         (ascending_option_def, qcs_flag_option_def)
2998         (thr_qcs_flags_option_defs)
2999         (make_thread_apply_all_options_def_group)
3000         (make_thread_apply_options_def_group): New.
3001         (thread_apply_all_command): Use gdb::option::process_options.
3002         (thread_apply_command_completer)
3003         (thread_apply_all_command_completer): New.
3004         (thread_apply_command): Use gdb::option::process_options.
3005         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3006         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3007         to generate help text of "thread apply".  Adjust "taas"'s help.
3008         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3009         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3010
3011 2019-06-13  Pedro Alves  <palves@redhat.com>
3012
3013         * thread.c (thread_apply_command): Check for invalid TID with
3014         isdigit instead of !isalpha.
3015
3016 2019-06-13  Pedro Alves  <palves@redhat.com>
3017
3018         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3019         (validate_flags_qcs): New.
3020         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3021         (validate_flags_qcs): Declare.
3022         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3023         (make_frame_apply_options_def_group): New.
3024         (frame_apply_command_count): Process options with
3025         gdb::option::process_options.
3026         (frame_apply_completer): New.
3027         (frame_apply_level_completer, frame_apply_all_completer)
3028         (frame_apply_completer): New.
3029         (_initialize_stack): Update help of "frame apply", "frame apply
3030         level", "frame apply all" and "faas" to mention supported options
3031         and install command completers.
3032         * stack.h (frame_apply_all_completer): Declare.
3033         * thread.c: Include "stack.h".
3034         (tfaas_command): Add "--".
3035         (_initialize_thread): Update help "tfaas" to mention supported
3036         options and install command completer.
3037
3038 2019-06-13  Pedro Alves  <palves@redhat.com>
3039
3040         * completer.c (complete_nested_command_line): New.
3041         (gdb_completion_word_break_characters_throw): Add assertion.
3042         * completer.h (complete_nested_command_line): Declare.
3043
3044 2019-06-13  Pedro Alves  <palves@redhat.com>
3045
3046         * stack.c (parse_backtrace_qualifiers): New.
3047         (backtrace_command): Use it.
3048         (backtrace_command_completer): Complete on qualifiers.
3049
3050 2019-06-13  Pedro Alves  <palves@redhat.com>
3051
3052         * frame.c: Include "cli/cli-option.h.
3053         (user_set_backtrace_options): New.
3054         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3055         Delete.
3056         (get_prev_frame): Adjust.
3057         (boolean_option_def, uinteger_option_def)
3058         (set_backtrace_option_defs): New.
3059         (_initialize_frame): Adjust and use
3060         gdb::option::add_setshow_cmds_for_options to install "set
3061         backtrace past-main" and "set backtrace past-entry".
3062         * frame.h: Include "cli/cli-option.h".
3063         (struct frame_print_options): Forward declare.
3064         (print_frame_arguments_all, print_frame_arguments_scalars)
3065         (print_frame_arguments_none): Declare.
3066         (print_entry_values): Delete declaration.
3067         (struct frame_print_options, user_frame_print_options): New.
3068         (struct set_backtrace_options): New.
3069         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3070         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3071         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3072         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3073         (list_args_or_locals): Add frame_print_options parameter.
3074         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3075         * python/py-framefilter.c (enumerate_args): Pass down
3076         USER_FRAME_PRINT_OPTIONS.
3077         * stack.c: Include "cli/cli-option.h".
3078         (print_frame_arguments_all, print_frame_arguments_scalars)
3079         (print_frame_arguments_none): Declare.
3080         (print_raw_frame_arguments, print_entry_values): Delete.
3081         (user_frame_print_options): New.
3082         (boolean_option_def, enum_option_def, frame_print_option_defs):
3083         New.
3084         (struct backtrace_cmd_options): New.
3085         (bt_flag_option_def): New.
3086         (backtrace_command_option_defs): New.
3087         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3088         (print_frame_arg, read_frame_arg, print_frame_args)
3089         (print_frame_info, print_frame): Add frame_print_options parameter
3090         and use it.
3091         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3092         (backtrace_command_1): Add frame_print_options and
3093         backtrace_cmd_options parameters and use them.
3094         (make_backtrace_options_def_group): New.
3095         (backtrace_command): Process command options with
3096         gdb::option::process_options.
3097         (backtrace_command_completer): New.
3098         (_initialize_stack): Extend "backtrace"'s help to mention
3099         supported options.  Install completer for "backtrace".
3100         Install some settings commands with add_setshow_cmds_for_options.
3101
3102 2019-06-13  Pedro Alves  <palves@redhat.com>
3103
3104         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3105         and that "set/show print raw frame-arguments" are now deprecated.
3106
3107         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3108         command.
3109         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3110         * stack.c (_initialize_stack): Install "set/show print
3111         raw-frame-arguments", and deprecate "set/show print raw
3112         frame-arguments".
3113         * valprint.c (_initialize_valprint): Deprecate "set/show print
3114         raw".
3115
3116 2019-06-13  Pedro Alves  <palves@redhat.com>
3117
3118         * compile/compile.c (struct compile_options): New.
3119         (compile_flag_option_def, compile_command_option_defs)
3120         (make_compile_options_def_group): New.
3121         (compile_file_command): Handle options with
3122         gdb::option::process_options.
3123         (compile_file_command_completer): New function.
3124         (compile_code_command): Handle options with
3125         gdb::option::process_options.
3126         (compile_code_command_completer): New function.
3127         (_initialize_compiler): Install completers for "compile code" and
3128         "compile file".  Mention available options in "compile code" and
3129         "compile code"'s help.
3130         * completer.c (advance_to_completion_word): New, factored out from
3131         ...
3132         (advance_to_expression_complete_word_point): ... this.
3133         (advance_to_filename_complete_word_point): New.
3134         * completer.h (advance_to_filename_complete_word_point): New
3135         declaration.
3136
3137 2019-06-13  Pedro Alves  <palves@redhat.com>
3138
3139         * compile/compile.c: Include "cli/cli-option.h".
3140         (compile_print_value): Scope data pointer is now a
3141         value_print_options pointer; adjust.
3142         (compile_print_command): Process options.  Scope data pointer is
3143         now a value_print_options pointer; adjust.
3144         (_initialize_compile): Update "compile print"'s help to include
3145         supported options.  Install a completer for "compile print".
3146         * cp-valprint.c (show_vtblprint, show_objectprint)
3147         (show_static_field_print): Delete.
3148         (_initialize_cp_valprint): Don't install "set print
3149         static-members", "set print vtbl", "set print object" here.
3150         * printcmd.c: Include "cli/cli-option.h" and
3151         "common/gdb_optional.h".
3152         (print_command_parse_format): Rework to fill in a
3153         value_print_options instead of a format_data.
3154         (print_value): Change parameter type from format_data pointer to
3155         value_print_options reference.  Adjust.
3156         (print_command_1): Process options.  Adjust to pass down a
3157         value_print_options.
3158         (print_command_completer): New.
3159         (_initialize_printcmd): Install print_command_completer as
3160         handle_brkchars completer for the "print" command.  Update
3161         "print"'s help to include supported options.
3162         * valprint.c: Include "cli/cli-option.h".
3163         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3164         here from cp-valprint.c.
3165         (boolean_option_def, uinteger_option_def)
3166         (value_print_option_defs, make_value_print_options_def_group):
3167         New.  Use gdb::option::add_setshow_cmds_for_options to install
3168         "set print elements", "set print null-stop", "set print repeats",
3169         "set print pretty", "set print union", "set print array", "set
3170         print address", "set print symbol", "set print array-indexes".
3171         * valprint.h: Include <string> and "cli/cli-option.h".
3172         (make_value_print_options_def_group): Declare.
3173         (print_value): Change parameter type from format_data pointer to
3174         value_print_options reference.
3175         (print_command_completer): Declare.
3176
3177 2019-06-13  Pedro Alves  <palves@redhat.com>
3178
3179         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3180         (COMMON_SFILES): Add maint-test-settings.c.
3181         * cli/cli-decode.c (boolean_enums): New global, factored out from
3182         ...
3183         (add_setshow_boolean_cmd): ... here.
3184         * cli/cli-decode.h (boolean_enums): Declare.
3185         * cli/cli-option.c: New file.
3186         * cli/cli-option.h: New file.
3187         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3188         factored out from ...
3189         (parse_cli_boolean_value(const char *)): ... this.
3190         (is_unlimited_literal): Change parameter type to pointer to
3191         pointer.  Adjust and advance ARG pointer.
3192         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3193         (parse_cli_var_enum): New, factored out from ...
3194         (do_set_command): ... this.  Adjust.
3195         * cli/cli-setshow.h (parse_cli_boolean_value)
3196         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3197         (parse_cli_var_enum): Declare.
3198         * cli/cli-utils.c: Include "cli/cli-option.h".
3199         (get_ulongest): New.
3200         * cli/cli-utils.h (get_ulongest): Declare.
3201         (check_for_argument): New overloads.
3202         * maint-test-options.c: New file.
3203
3204 2019-06-13  Pedro Alves  <palves@redhat.com>
3205
3206         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3207         parse a range if "-" is at the end of the string.
3208
3209 2019-06-13  Pedro Alves  <palves@redhat.com>
3210
3211         * cli/cli-setshow.c (parse_auto_binary_operation)
3212         (parse_cli_boolean_value): Don't allow "o".
3213
3214 2019-06-13  Pedro Alves  <palves@redhat.com>
3215
3216         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3217         * NEWS: Mention maint test-settings KIND.
3218         * maint-test-settings.c: New file.
3219
3220 2019-06-13  Pedro Alves  <palves@redhat.com>
3221
3222         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3223         completer.
3224         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3225         "set" completers.
3226
3227 2019-06-13  Pedro Alves  <palves@redhat.com>
3228
3229         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3230         after item.
3231
3232 2019-06-13  Pedro Alves  <palves@redhat.com>
3233
3234         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3235
3236 2019-06-13  Pedro Alves <palves@redhat.com>
3237
3238         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3239         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3240         call.
3241         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3242         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3243         calls.
3244         (check_for_argument): Skip spaces after argument.
3245
3246 2019-06-13  Pedro Alves  <palves@redhat.com>
3247
3248         * thread.c (thread_apply_command): Adjust TID parsing.
3249         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3250         detected before end of string.
3251         (tid_is_in_list): Error out if LIST is invalid.
3252
3253 2019-06-13  Pedro Alves  <palves@redhat.com>
3254
3255         * completer.c (complete_line_internal_1): Rewind completion word
3256         point.
3257         (completion_tracker::advance_custom_word_point_by): Change
3258         parameter type to int.
3259         * completer.h (completion_tracker::advance_custom_word_point_by):
3260         Likewise.
3261
3262 2019-06-13  Pedro Alves  <palves@redhat.com>
3263
3264         * completer.c (advance_to_completion_word): Handle delimiters.
3265
3266 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3267
3268         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3269
3270 2019-06-11  Tom Tromey  <tom@tromey.com>
3271
3272         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3273         (xmalloc_failed): Move to alloc.c.
3274         * alloc.c: New file.
3275         * Makefile.in (COMMON_SFILES): Add alloc.c.
3276
3277 2019-06-11  Tom Tromey  <tom@tromey.com>
3278
3279         * nat/linux-waitpid.c: Don't include server.h.
3280         (linux_debug): Remove.
3281         (my_waitpid): Update.
3282
3283 2019-06-11  Tom Tromey  <tromey@adacore.com>
3284
3285         * infcall.c (_initialize_infcall): Remove trailing newline from
3286         help.
3287         * user-regs.c (_initialize_user_regs): Remove trailing newline
3288         from help.
3289         * typeprint.c (_initialize_typeprint): Remove trailing newline
3290         from help.
3291         * reverse.c (_initialize_reverse): Remove trailing newlines from
3292         help.
3293         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3294         from help.
3295         * language.c (add_set_language_command): Remove trailing newline
3296         from help.
3297         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3298         help.
3299         * disasm.c (_initialize_disasm): Remove trailing newline from
3300         help.
3301         * top.c (init_main): Remove trailing newline from help.
3302         * interps.c (_initialize_interpreter): Remove trailing newline
3303         from help.
3304         * btrace.c (_initialize_btrace): Remove trailing newlines from
3305         help.
3306         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3307         from help.
3308         * python/python.c (_initialize_python): Remove trailing newline
3309         from help.
3310         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3311         help.
3312         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3313         from help.  Reformat some text.
3314         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3315         from help.
3316         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3317         newline from help.
3318
3319 2019-06-11  Tom Tromey  <tromey@adacore.com>
3320
3321         * darwin-nat.c (darwin_decode_exception_message)
3322         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3323
3324 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3325
3326         * valops.c (value_slice): Check for not allocated or not
3327         associated values.
3328
3329 2019-06-10  Tom de Vries  <tdevries@suse.de>
3330
3331         PR gdb/24618
3332         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3333         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3334         invalid.
3335
3336 2019-06-10  Tom de Vries  <tdevries@suse.de>
3337
3338         PR gdb/24611
3339         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3340         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3341
3342 2019-06-10  Tom de Vries  <tdevries@suse.de>
3343
3344         PR symtab/24545
3345         * symtab.c (struct demangled_name_entry): Add language field.
3346         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3347         static minimal symbol".  Set and use language field.
3348
3349 2019-06-10  Tom Tromey  <tromey@adacore.com>
3350
3351         * ada-lang.c (_initialize_ada_language): Update help text.
3352
3353 2019-06-10  Tom Tromey  <tromey@adacore.com>
3354
3355         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3356         with a newline.
3357         * guile/guile.c (handle_boot_error): Don't end warning with a
3358         newline.
3359         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3360         warning with a newline.
3361         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3362         newline.
3363         (s12z_frame_cache): Likewise.
3364         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3365         a newline.
3366         * solib-svr4.c (disable_probes_interface): Don't end warning with
3367         a newline.
3368         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3369         newline.
3370         * python/python.c (do_finish_initialization): Don't end warning
3371         with a newline.
3372
3373 2019-06-10  Tom Tromey  <tom@tromey.com>
3374
3375         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3376         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3377         gdbpy_enter.
3378
3379 2019-06-10  Tom Tromey  <tromey@adacore.com>
3380
3381         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3382         data.
3383         (elf_new_init): Don't call stabsread_new_init.
3384         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3385         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3386         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3387
3388 2019-06-10  Tom de Vries  <tdevries@suse.de>
3389
3390         PR symtab/16264
3391         PR symtab/24517
3392         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3393
3394 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3395
3396         * source.c (find_and_open_source): Also rewrite relative file
3397         names.
3398
3399 2019-04-26  Amos Bird  <amosbird@gmail.com>
3400
3401         * annotate.c (annotate_thread_exited): Add "thread-exited"
3402         annotation.
3403
3404 2019-06-06  Tom Tromey  <tromey@adacore.com>
3405
3406         * maint.h (class scoped_command_stats): Use
3407         DISABLE_COPY_AND_ASSIGN.
3408         <print_time>: New method.
3409         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3410         print_time.
3411         (scoped_command_stats::print_time): New method.
3412
3413 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3414
3415         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3416         instructions of lengths 6 or 8 bytes.
3417
3418 2019-06-04  Pedro Alves  <palves@redhat.com>
3419
3420         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3421
3422         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3423         * breakpoint.c (condition_completer): Likewise.
3424         * cli/cli-dump.c (scan_expression): Likewise.
3425         * common/filestuff.c (mkdir_recursive): Likewise.
3426         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3427         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3428         (gdb_abspath): Likewise.
3429         * compile/compile-cplus-types.c
3430         (compile_cplus_instance::decl_name): Likewise.
3431         * completer.c (complete_explicit_location):
3432         (signal_completer, reg_or_group_completer_1): Likewise.
3433         * cp-support.c (cp_remove_params_if_any): Likewise.
3434         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3435         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3436         * infcmd.c (strip_bg_char): Likewise.
3437         * linespec.c (copy_token_string): Likewise.
3438         * mi/mi-main.c (output_cores): Likewise.
3439         * psymtab.c (psymtab_search_name):
3440         * symfile.c (test_set_ext_lang_command): Likewise.
3441         * target.c (target_fileio_read_stralloc): Likewise.
3442         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3443         * value.c (complete_internalvar): Likewise.
3444
3445 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3446
3447         Add objfile property to gdb.Type.
3448         * NEWS: Mention Python API addition.
3449         * python/py-type.c (typy_get_objfile): New method.
3450
3451 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3452
3453         * NEWS: Mention the new set|show style [title|highlight].
3454         Mention changes to "show style", "help" and "apropos".
3455
3456 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3457
3458         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3459         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3460         instead of print_help_for_command.
3461         (print_doc_of_command): New function.
3462         (help_list): Add 'apropos -v word' suggestion.
3463         (print_help_for_command): Style the command name using title style.
3464         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3465         (_initialize_cli_cmds): Describe -v in apropos_command help.
3466
3467 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3468
3469         * cli/cli-style.h (cli_style_option): Add name in constructor,
3470         add m_name class member, add constructor with intensity,
3471         add name class function.
3472         (cli_style_option::add_setshow_commands): Remove name argument.
3473         (highlight_style, title_style): New styles.
3474         * cli/cli-style.c (do_show): New function that shows a style
3475         characteristic styling the style name with itself.
3476         (set_style_name): New function.
3477         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3478         Update all callers according to the changes in cli/cli-style.h.
3479         * utils.h (fputs_highlighted): New function.
3480         * utils.c (fputs_highlighted): Likewise.
3481
3482 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3483
3484         * NEWS: Mention new pipe command and new convenience variables.
3485
3486 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3487
3488         * cli/cli-cmds.c (pipe_command): New function.
3489         (_initialize_cli_cmds): Call add_com for pipe_command.
3490         Define | as an alias for pipe.
3491         (exit_status_set_internal_vars): New function.
3492         (shell_escape): Call exit_status_set_internal_vars.
3493         cli/cli-decode.c (find_command_name_length): Recognize | as
3494         a single character command.
3495
3496 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3497
3498         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3499         top.c (execute_command_to_ui_file): New function, mostly a copy
3500         of execute_command_to_string.
3501         (execute_command_to_string): Implement by calling
3502         execute_command_to_ui_file.
3503
3504 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3505
3506         * top.h (saved_command_line): Remove declaration.
3507         * top.c (previous_saved_command_line, previous_repeat_arguments):
3508         New variables.
3509         (saved_command_line): Make static, define together with other
3510         'repeat variables'.
3511         (dont_repeat): Clear repeat_arguments.
3512         (repeat_previous, get_saved_command_line, save_command_line):
3513         New functions.
3514         (gdb_init): Initialize saved_command_line
3515         and previous_saved_command_line.
3516         * main.c (captured_main_1): Remove saved_command_line initialization.
3517         * event-top.c (handle_line_of_input): Update to use
3518         the new 'repeat' related functions instead of direct access to
3519         saved_command_line.
3520         * command.h (repeat_previous, get_saved_command_line,
3521         save_command_line): New declarations.
3522         (dont_repeat): Add comment.
3523
3524 2019-05-30  Tom Tromey  <tromey@adacore.com>
3525
3526         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3527         Fix comment.
3528         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3529
3530 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3531
3532         PR cli/24587
3533         * completer.c (complete): Initialize variable word.
3534
3535 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3536
3537         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3538         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3539         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3540         'body' is NULL to the outter 'if', protecting the '!is_define'
3541         situation as well.
3542
3543 2019-05-29  Tom Tromey  <tromey@adacore.com>
3544
3545         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3546         (dwarf_unknown): New function.
3547         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3548         (dwarf_type_encoding_name): Use dwarf_unknown.
3549
3550 2019-05-29  Tom Tromey  <tromey@adacore.com>
3551
3552         PR c++/20020:
3553         * cp-valprint.c (cp_print_value_fields): Call
3554         cp_print_static_field inside "try".
3555
3556 2019-05-29  Tom Tromey  <tromey@adacore.com>
3557
3558         * inflow.c (struct terminal_info): Add default operator=.
3559         * configure: Rebuild.
3560         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3561         -Wdeprecated-copy-dtor, -Wredundant-move.
3562
3563 2019-05-29  Tom Tromey  <tromey@adacore.com>
3564
3565         * NEWS: Add entry.
3566         * infcmd.c (print_return_value_1): Handle finish_print
3567         option.
3568         (show_print_finish): New function.
3569         (_initialize_infcmd): Add "set/show print finish" commands.
3570         * valprint.c (user_print_options): Initialize new member.
3571         * valprint.h (struct value_print_options) <finish_print>: New
3572         member.
3573
3574 2019-05-28  Tom Tromey  <tromey@adacore.com>
3575
3576         * ada-lang.c (ada_remove_Xbn_suffix)
3577         (find_old_style_renaming_symbol)
3578         (parse_old_style_renaming): Remove.
3579         (ada_find_renaming_symbol): Don't call
3580         find_old_style_renaming_symbol.
3581         (ada_is_renaming_symbol): Rename from
3582         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3583         bool.  Now static.
3584         (ada_read_var_value): Update and simplify.
3585         * ada-exp.y (write_var_or_type): Remove old code.
3586
3587 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3588
3589         * event-top.c: Remove include comment.
3590         * inflow.c (class scoped_ignore_sigttou): Move from here...
3591         * inflow.h (class scoped_ignore_sigttou): ...to here.
3592         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3593         * top.c:  Remove include comment.
3594
3595 2019-05-27  Tom Tromey  <tom@tromey.com>
3596
3597         * NEWS: Fix typo.
3598
3599 2019-05-22  Tom Tromey  <tromey@adacore.com>
3600
3601         * target.c (target_follow_exec): Constify parameter.
3602         * target-delegates.c: Rebuild.
3603         * remote.c (remote_target::follow_exec): Constify parameter.
3604         * infrun.c (follow_exec): Constify parameter.
3605         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3606         (target_follow_exec): Likewise.
3607
3608 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3609
3610         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3611         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3612
3613 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3614
3615         * NEWS: Add debugredirect and testsuite sections.
3616
3617 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3618
3619         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3620         target descriptions using exclusively floating point register name
3621         aliases.
3622
3623 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3624
3625         PR gdb/18644:
3626         * f-lang.c (build_fortran_types): Handle the case where
3627         gdbarch_floatformat_for_type returns a nullptr.
3628
3629 2019-05-21  Tom de Vries  <tdevries@suse.de>
3630
3631         PR cli/24587
3632         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3633
3634 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3635
3636         PR gdb/18644:
3637         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3638         16-byte floats.
3639         * i386-tdep.c (i386_floatformat_for_type): Use
3640         floatformats_ia64_quad for the 16-byte floating point component
3641         within a fortran 32-byte complex number.
3642
3643 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3644
3645         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3646         delete default constructor.
3647         (find_partial_die): Update to return const struct.
3648         (partial_die_parent_scope): Move variable declaration into scope
3649         of its use and change its type to auto.
3650         (guess_partial_die_structure_name): Likewise.
3651         (partial_die_info::fixup): Likewise.
3652
3653 2019-05-17  Tom Tromey  <tromey@adacore.com>
3654
3655         * source.c (find_and_open_source): Remove cast.
3656
3657 2019-05-17  Tom Tromey  <tromey@adacore.com>
3658
3659         * annotate.c (annotate_source): Make "filename" const.
3660         * annotate.h (annotate_source): Use const.
3661
3662 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3663
3664         * disasm.c (set_disassembler_options): Send errors to stderr.
3665
3666 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3667
3668         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3669         (cli_interp_base::set_logging): Check debug_redirect.
3670         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3671         * cli/cli-logging.c (debug_redirect): Add static variable.
3672         (pop_output_files): Add default param.
3673         (handle_redirections): Print debug setting.
3674         (show_logging_command): Likewise.
3675         (_initialize_cli_logging): Add debugredirect command.
3676         * interps.c (current_interp_set_logging): Add debug_redirect
3677         parameter.
3678         * interps.h (set_logging): Add debug_redirect parameter.
3679         (current_interp_set_logging): Likewise.
3680         * mi/mi-common.h: Likewise.
3681         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3682
3683 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3684             Tom Tromey  <tromey@adacore.com>
3685
3686         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3687         directly.
3688         * cli/cli-interp.h (make_logging_output): Remove declaration.
3689         * cli/cli-logging.c (make_logging_output): Remove function.
3690         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3691         directly.
3692         * ui-file.c (tee_file::tee_file): Remove bools.
3693         (tee_file::~tee_file): Remove deletes.
3694         * ui-file.h (tee_file): Remove bools.
3695
3696 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3697
3698         * mi/mi-cmds.h (mi_cmd_complete): New function.
3699         * mi/mi-main.c (mi_cmd_complete): Likewise.
3700         * mi/mi-cmds.c: Define new MI command -complete.
3701         * NEWS: Mention new -complete command.
3702
3703 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3704
3705         * completer.h (complete): New function.
3706         * completer.c (complete): Likewise.
3707         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3708         function defined in completer.h.
3709
3710 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3711
3712         * MAINTAINERS (Write After Approval): Add myself.
3713
3714 2019-05-17  Tom de Vries  <tdevries@suse.de>
3715
3716         PR gdb/24094
3717         * dwarf2read.c (struct cu_partial_die_info): New struct.
3718         (find_partial_die): Return cu_partial_die_info.
3719         (partial_die_parent_scope, guess_partial_die_structure_name)
3720         (partial_die_info::fixup): Handle new return type of find_partial_die.
3721
3722 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3723
3724         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3725         "std::string", simplifying the algorithm.
3726
3727 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3728
3729         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3730         (stap_static_probe_ops::get_probes): Likewise.
3731
3732 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3733
3734         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3735         '-')" and "else if".
3736         (stap_parse_single_operand): Join checks for
3737         "gdbarch_stap_parse_special_token_p" and
3738         "gdbarch_stap_parse_special_token" in the same "if" statement.
3739         Invert check when verifying for operation on register
3740         displacement.
3741
3742 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3743
3744         * stap-probe.c (stap_get_opcode): Update comment.
3745         (stap_get_expected_argument_type): Likewise.
3746         (handle_stap_probe): Likewise.
3747
3748 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3749
3750         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3751         return type to 'bool'.  Adjust comment.  Use 'bool' when
3752         appropriate.
3753         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3754         * stap-probe.c (stap_parse_argument_1): Likewise.
3755         (stap_is_operator): Likewise.
3756         (stap_is_generic_prefix): Likewise.
3757         (stap_is_register_prefix): Likewise.
3758         (stap_is_register_indirection_prefix): Likewise.
3759         (stap_is_integer_prefix): Likewise.
3760         (stap_generic_check_suffix): Likewise.
3761         (stap_check_integer_suffix): Likewise.
3762         (stap_check_register_suffix): Likewise.
3763         (stap_check_register_indirection_suffix): Likewise.
3764         (stap_parse_register_operand): Likewise.
3765         (stap_parse_single_operand): Likewise.
3766         (stap_parse_argument_1): Likewise.
3767         (stap_probe::get_argument_count): Likewise.
3768         (stap_is_operator): Likewise.
3769
3770 2019-05-16  Tom Tromey  <tromey@adacore.com>
3771
3772         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3773         keyword to foreach.
3774
3775 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3776
3777         * linux-thread-db.c (try_thread_db_load_1): Change return type
3778         to bool.
3779         (try_thread_db_load): Likewise.
3780         (try_thread_db_load_from_pdir_1): Likewise.
3781         (try_thread_db_load_from_pdir): Likewise.
3782         (try_thread_db_load_from_sdir): Likewise.
3783         (try_thread_db_load_from_dir): Likewise.
3784         (thread_db_load_search): Likewise.
3785         (has_libpthread): Likewise.
3786         (thread_db_load): Likewise.
3787
3788 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3789
3790         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3791         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3792         NULL, and complain/return if that's the case.
3793
3794 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3795
3796         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3797         (advance, posn, abstract_read_memory): New functions.
3798         [struct mem_read_abstraction]: New struct.
3799         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3800
3801 2019-05-14  Tom Tromey  <tromey@adacore.com>
3802
3803         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3804         value is not lval_memory.
3805
3806 2019-05-14  Tom Tromey  <tromey@adacore.com>
3807
3808         * solib.c (info_sharedlibrary_command): Style the file name.
3809
3810 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3811
3812         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3813         (aarch64_vnv_type): Likewise.
3814         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3815         * common/tdesc.c: Likewise.
3816         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3817         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3818         * features/aarch64-fpu.xml: Add ieee half view.
3819         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3820         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3821         * gdbtypes.h (struct builtin_type): Likewise.
3822         (struct objfile_type): Likewise.
3823
3824 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3825
3826         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3827         typo.
3828         * location.h (string_to_event_location): Likewise.
3829
3830 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3831
3832         GDB 8.3 released.
3833
3834 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3835
3836         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3837         New variable declaration.
3838         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3839         New variable.
3840         (print_one_breakpoint): Use ui_out::test_flags and new global
3841         variable to compute use_fixed_output.
3842         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3843         Remove.
3844         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3845         (mi_multi_location_breakpoint_output_fixed): Remove.
3846         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3847         new variable.
3848         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3849         fix_multi_location_breakpoint_output flag if version >= 3.
3850         * ui-out.h (enum ui_out_flag)
3851         <fix_multi_location_breakpoint_output>: New enumerator.
3852
3853 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3854
3855         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3856
3857 2019-05-10  Tom Tromey  <tromey@adacore.com>
3858
3859         * ada-lang.c (catch_ada_completer): New function.
3860         (_initialize_ada_language): Use it.
3861
3862 2019-05-10  Tom Tromey  <tromey@adacore.com>
3863
3864         * thread.c (print_thread_info): Make "requested_threads" const.
3865         * gdbthread.h (print_thread_info): Make "requested_threads"
3866         const.
3867         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3868         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3869
3870 2019-05-08  Tom Tromey  <tom@tromey.com>
3871
3872         * gdbtypes.c (objfile_type_data): Change type.
3873         (objfile_type, _initialize_gdbtypes): Update.
3874
3875 2019-05-08  Tom Tromey  <tom@tromey.com>
3876
3877         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3878         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3879         (_initialize_dwarf2_frame): Update.
3880
3881 2019-05-08  Tom Tromey  <tom@tromey.com>
3882
3883         * objc-lang.c (objc_objfile_data): Change type.
3884         (find_methods): Update.
3885         (_initialize_objc_lang): Remove.
3886
3887 2019-05-08  Tom Tromey  <tom@tromey.com>
3888
3889         * stabsread.c (rs6000_builtin_type_data): Change type.
3890         (rs6000_builtin_type, _initialize_stabsread): Update.
3891
3892 2019-05-08  Tom Tromey  <tom@tromey.com>
3893
3894         * mips-tdep.c (mips_pdr_data): Remove.
3895         (_initialize_mips_tdep): Update.
3896
3897 2019-05-08  Tom Tromey  <tom@tromey.com>
3898
3899         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3900         (hppa_init_objfile_priv_data, read_unwind_info)
3901         (find_unwind_entry, _initialize_hppa_tdep): Update.
3902
3903 2019-05-08  Tom Tromey  <tom@tromey.com>
3904
3905         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3906         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3907         on obstack.
3908         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3909
3910 2019-05-08  Tom Tromey  <tom@tromey.com>
3911
3912         * mdebugread.c (basic_type_data): Change type.
3913         (basic_type, _initialize_mdebugread): Update.
3914
3915 2019-05-08  Tom Tromey  <tom@tromey.com>
3916
3917         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3918
3919 2019-05-08  Tom Tromey  <tom@tromey.com>
3920
3921         * nto-tdep.c (nto_inferior_data_reg): Change type.
3922         (nto_inferior_data): Update.
3923         (nto_inferior_data_cleanup, nto_new_inferior_data)
3924         (_initialize_nto_tdep): Remove.
3925         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3926
3927 2019-05-08  Tom Tromey  <tom@tromey.com>
3928
3929         * ada-lang.c (struct ada_inferior_data): Add initializers.
3930         (ada_inferior_data): Change type.
3931         (ada_inferior_data_cleanup): Remove.
3932         (get_ada_inferior_data, ada_inferior_exit)
3933         (struct ada_pspace_data): Add initializers, destructor.
3934         (ada_pspace_data_handle): Change type.
3935         (get_ada_pspace_data): Update.
3936         (ada_pspace_data_cleanup): Remove.
3937
3938 2019-05-08  Tom Tromey  <tom@tromey.com>
3939
3940         * coffread.c (struct coff_symfile_info): Add initializers.
3941         (coff_objfile_data_key): Move lower.  Change type.
3942         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3943         Update.
3944         (coff_free_info): Remove.
3945
3946 2019-05-08  Tom Tromey  <tom@tromey.com>
3947
3948         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3949         (fbsd_pspace_data_handle): Move lower.  Change type.
3950         (get_fbsd_pspace_data): Update.
3951         (fbsd_pspace_data_cleanup): Remove.
3952         (_initialize_fbsd_tdep): Update.
3953
3954 2019-05-08  Tom Tromey  <tom@tromey.com>
3955
3956         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3957         (get_ada_tasks_pspace_data): Update.
3958         (ada_tasks_pspace_data_cleanup): Remove.
3959         (_initialize_tasks): Update.
3960         (ada_tasks_inferior_data_handle): Change type.
3961         (get_ada_tasks_inferior_data): Update.
3962         (ada_tasks_inferior_data_cleanup): Remove.
3963         (struct ada_tasks_pspace_data): Add initializers.
3964
3965 2019-05-08  Tom Tromey  <tom@tromey.com>
3966
3967         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3968         * symfile-debug.c (debug_sym_get_probes): Change type.
3969         * stap-probe.c (handle_stap_probe):
3970         (stap_static_probe_ops::get_probes): Change type.
3971         * probe.h (class static_probe_ops) <get_probes>: Change type.
3972         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3973         (parse_probes_in_pspace): Update.
3974         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3975         Update.
3976         (any_static_probe_ops::get_probes): Change type.
3977         * elfread.c (elfread_data): New typedef.
3978         (probe_key): Change type.
3979         (elf_get_probes): Likewise.  Update.
3980         (probe_key_free): Remove.
3981         (_initialize_elfread): Update.
3982         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3983         Change type.
3984         (dtrace_process_dof_probe, dtrace_process_dof)
3985         (dtrace_static_probe_ops::get_probe): Change type.
3986
3987 2019-05-08  Tom Tromey  <tom@tromey.com>
3988
3989         * xcoffread.c (struct xcoff_symfile_info): Rename from
3990         coff_symfile_info.  Add initializers.
3991         (xcoff_objfile_data_key): Move lower.  Change type.
3992         (XCOFF_DATA): Rewrite.
3993         (xcoff_free_info): Remove.
3994         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3995         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3996         (xcoff_initial_scan): Update.
3997
3998 2019-05-08  Tom Tromey  <tom@tromey.com>
3999
4000         * solib-svr4.c (struct svr4_info): Add initializers and
4001         destructor.
4002         <probes_table>: Now an htab_up.
4003         (solib_svr4_pspace_data): Change type.
4004         (free_probes_table): Simplify.
4005         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4006         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4007         (probes_table_remove_objfile_probes, register_solib_event_probe)
4008         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4009         (_initialize_svr4_solib): Update.
4010
4011 2019-05-08  Tom Tromey  <tom@tromey.com>
4012
4013         * remote.c (remote_pspace_data): Change type.
4014         (remote_pspace_data_cleanup): Remove.
4015         (get_remote_exec_file, set_pspace_remote_exec_file)
4016         (_initialize_remote): Update.
4017
4018 2019-05-08  Tom Tromey  <tom@tromey.com>
4019
4020         * breakpoint.c (breakpoint_objfile_key): Change type.
4021         (get_breakpoint_objfile_data): Update.
4022         (free_breakpoint_objfile_data): Remove.
4023         (_initialize_breakpoint): Update.
4024
4025 2019-05-08  Tom Tromey  <tom@tromey.com>
4026
4027         * linux-tdep.c (struct linux_info): Add initializers.
4028         (linux_inferior_data): Move.  Change type.
4029         (invalidate_linux_cache_inf): Update.
4030         (linux_inferior_data_cleanup): Remove.
4031         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4032
4033 2019-05-08  Tom Tromey  <tom@tromey.com>
4034
4035         * auxv.c (auxv_inferior_data): Move.  Change type.
4036         (auxv_inferior_data_cleanup): Remove.
4037         (invalidate_auxv_cache_inf): Rewrite.
4038         (get_auxv_inferior_data, _initialize_auxv): Update.
4039
4040 2019-05-08  Tom Tromey  <tom@tromey.com>
4041
4042         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4043         (symfile_debug_objfile_data_key): Change type.
4044         (symfile_debug_installed, debug_qf_has_symbols)
4045         (debug_qf_find_last_source_symtab)
4046         (debug_qf_forget_cached_source_info)
4047         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4048         (debug_qf_print_stats, debug_qf_dump)
4049         (debug_qf_expand_symtabs_for_function)
4050         (debug_qf_expand_all_symtabs)
4051         (debug_qf_expand_symtabs_with_fullname)
4052         (debug_qf_map_matching_symbols)
4053         (debug_qf_expand_symtabs_matching)
4054         (debug_qf_find_pc_sect_compunit_symtab)
4055         (debug_qf_map_symbol_filenames)
4056         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4057         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4058         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4059         (debug_sym_read_linetable, debug_sym_relocate): Update.
4060         (symfile_debug_free_objfile): Remove.
4061         (install_symfile_debug_logging, _initialize_symfile_debug):
4062         Update.
4063
4064 2019-05-08  Tom Tromey  <tom@tromey.com>
4065
4066         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4067         allocate_on_obstack.
4068         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4069         (get_dwarf2_per_objfile): Update.
4070         (set_dwarf2_per_objfile): Remove.
4071         (dwarf2_has_info, dwarf2_get_section_info): Update.
4072         (dwarf2_free_objfile): Remove.
4073         (_initialize_dwarf2_read): Update.
4074
4075 2019-05-08  Tom Tromey  <tom@tromey.com>
4076
4077         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4078         initializers.
4079         <unsupported_script_warning_printed,
4080         script_not_found_warning_printed>: Now bool.
4081         (auto_load_pspace_data): Change type.
4082         (~auto_load_pspace_info): Rename from
4083         auto_load_pspace_data_cleanup.
4084         (get_auto_load_pspace_data, init_loaded_scripts_info)
4085         (clear_section_scripts, maybe_print_unsupported_script_warning)
4086         (maybe_print_script_not_found_warning, _initialize_auto_load):
4087         Update.
4088
4089 2019-05-08  Tom Tromey  <tom@tromey.com>
4090
4091         * objfiles.c (objfile_pspace_info): Add destructor and
4092         initializers.
4093         (objfiles_pspace_data): Change type.
4094         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4095         (get_objfile_pspace_data): Update.
4096         (objfiles_bfd_data): Change type.
4097         (get_objfile_bfd_data): Update.
4098         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4099
4100 2019-05-08  Tom Tromey  <tom@tromey.com>
4101
4102         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4103         Change type.
4104         (get_catch_syscall_inferior_data): Update.
4105         (catch_syscall_inferior_data_cleanup): Remove.
4106         (_initialize_break_catch_syscall): Update.
4107
4108 2019-05-08  Tom Tromey  <tom@tromey.com>
4109
4110         * inflow.c (struct terminal_info): Add destructor and
4111         initializers.
4112         (inflow_inferior_data): Change type.
4113         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4114         (get_inflow_inferior_data, inflow_inferior_exit)
4115         (swap_terminal_info, _initialize_inflow): Update.
4116
4117 2019-05-08  Tom Tromey  <tom@tromey.com>
4118
4119         * target-dcache.c (target_dcache_cleanup): Remove.
4120         (target_dcache_aspace_key): Change type.
4121         (target_dcache_init_p, target_dcache_invalidate)
4122         (target_dcache_get, target_dcache_get_or_init)
4123         (_initialize_target_dcache): Update.
4124         * dcache.h (struct dcache_deleter): New.
4125
4126 2019-05-08  Tom Tromey  <tom@tromey.com>
4127
4128         * symtab.c (struct symbol_cache): Add destructor and
4129         initializers.
4130         (symbol_cache_key): Move.  Change type.
4131         (make_symbol_cache, free_symbol_cache): Remove.
4132         (get_symbol_cache): Update.
4133         (symbol_cache_cleanup): Remove.
4134         (ALL_PSPACES, symbol_cache_flush)
4135         (maintenance_print_symbol_cache)
4136         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4137         Update.
4138
4139 2019-05-08  Tom Tromey  <tom@tromey.com>
4140
4141         * symtab.c (struct main_info): Add destructor and initializers.
4142         (main_progspace_key): Move.  Change type.
4143         (get_main_info): Update.
4144         (main_info_cleanup): Remove.
4145         (_initialize_symtab): Update.
4146
4147 2019-05-08  Tom Tromey  <tom@tromey.com>
4148
4149         * registry.h (DECLARE_REGISTRY): Define the _key class.
4150
4151 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4152
4153         * NEWS: Merge two 'New commands' sections.
4154
4155 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4156
4157         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4158         parameter and use Ada language definition instead.
4159         (ada_val_print_ptr): Remove unused language parameter.
4160         (ada_val_print_num): Remove language parameter and use Ada language
4161         definition instead.
4162         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4163         parameter.
4164         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4165         parameter and use Ada language definition instead.
4166         (ada_val_print_1): Update all ada_val_print_xxx calls.
4167         Remove language parameter.
4168         (ada_val_print): Update ada_val_print_1 call.
4169
4170 2019-05-08  Tom Tromey  <tromey@adacore.com>
4171
4172         * remote.c (remote_hw_watchpoint_limit)
4173         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4174         Now static.
4175
4176 2019-05-08  Tom Tromey  <tromey@adacore.com>
4177
4178         * maint.c (_initialize_maint_cmds): Move initialization code to
4179         remote.c.
4180         (watchdog, show_watchdog): Move to remote.c.
4181         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4182         "watchdog" static.
4183         (_initialize_remote): Move initialization code from maint.c.
4184         * defs.h (watchdog): Don't declare.
4185
4186 2019-05-08  Tom Tromey  <tromey@adacore.com>
4187
4188         * tui/tui-interp.c: Include main.h.
4189         * interps.c: Include main.h.
4190         * main.h (interpreter_p): Declare.
4191         * defs.h (interpreter_p): Don't declare.
4192
4193 2019-05-08  Tom Tromey  <tromey@adacore.com>
4194
4195         * dwarf2loc.c: Include dwarf2read.h.
4196         * defs.h (read_unsigned_leb128): Don't declare.
4197         * dwarf2read.h (read_unsigned_leb128): Declare.
4198
4199 2019-05-08  Tom Tromey  <tromey@adacore.com>
4200
4201         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4202         method.
4203
4204 2019-05-08  Tom Tromey  <tromey@adacore.com>
4205
4206         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4207         when no wrap column is set.
4208
4209 2019-05-08  Tom Tromey  <tromey@adacore.com>
4210
4211         * c-lang.c (c_get_string): Handle non-C-style arrays.
4212
4213 2019-05-08  Tom Tromey  <tromey@adacore.com>
4214
4215         * typeprint.c (print_offset_data::update): Print the bit offset,
4216         not the number of bits remaining.
4217
4218 2019-05-08  Tom Tromey  <tromey@adacore.com>
4219
4220         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4221         padding at end of comment.
4222
4223 2019-05-08  Tom Tromey  <tromey@adacore.com>
4224
4225         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4226         Compare main types.
4227
4228 2019-05-06  Tom Tromey  <tom@tromey.com>
4229
4230         * common/scoped_mmap.c: Include common-defs.h.
4231         * common/scoped_mmap.h: Don't include config.h.
4232
4233 2019-05-04  Tom Tromey  <tom@tromey.com>
4234
4235         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4236         (struct aarch64_call_info): Add initializers.
4237         <si>: Now a std::vector.
4238         (pass_on_stack, aarch64_push_dummy_call): Update.
4239
4240 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4241             Tom Tromey  <tom@tromey.com>
4242
4243         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4244         (ppc_threads): Now a std::vector.  Now static.
4245         (hwdebug_find_thread_points_by_tid)
4246         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4247         Update.
4248
4249 2019-05-04  Tom Tromey  <tom@tromey.com>
4250
4251         * arc-tdep.c (arc_tdesc_init): Return bool.
4252
4253 2019-05-04  Tom Tromey  <tom@tromey.com>
4254
4255         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4256         Use gdb_assert_not_reached.
4257
4258 2019-05-04  Tom Tromey  <tom@tromey.com>
4259
4260         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4261         "false".
4262
4263 2019-05-04  Tom Tromey  <tom@tromey.com>
4264
4265         * arc-tdep.c (arc_tdesc_init): Use bool.
4266
4267 2019-05-04  Tom Tromey  <tom@tromey.com>
4268
4269         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4270
4271 2019-05-04  Tom Tromey  <tom@tromey.com>
4272
4273         * cli/cli-cmds.c (valid_command_p): Return bool.
4274
4275 2019-05-04  Tom Tromey  <tom@tromey.com>
4276
4277         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4278         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4279
4280 2019-05-04  Raul Tambre  <raul@tambre.ee>
4281
4282         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4283         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4284         operator for comparison.
4285
4286 2019-05-04  Tom Tromey  <tom@tromey.com>
4287
4288         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4289         (lookup_partial_symbol, print_partial_symbols)
4290         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4291         (psymbol_compare): Update.
4292         (add_psymbol_to_bcache): Clear the entire psymbol.
4293         (maintenance_check_psymtabs): Update.
4294         * psympriv.h (struct partial_symbol): Don't derive from
4295         general_symbol_info.
4296         <obj_section, unrelocated_address, address,
4297         set_unrelocated_address>: Update.
4298         <ginfo>: New member.
4299         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4300         (debug_names::write_psymbols): Update.
4301
4302 2019-05-04  Tom de Vries  <tdevries@suse.de>
4303
4304         * contrib/cc-with-tweaks.sh: Support -n arg.
4305
4306 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4307
4308         * corelow.c (core_target::detach): Ensure frame cache and
4309         register caches are cleared.
4310         inferior.c (exit_inferior_1): Likewise.
4311
4312 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4313             Tom Tromey  <tom@tromey.com>
4314
4315         * dictionary.c (collate_pending_symbols_by_language): Remove
4316         "struct" from foreach.
4317         * symtab.c (lookup_global_symbol_from_objfile)
4318         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4319         foreach.
4320         * ser-tcp.c (net_open): Remove "struct" from foreach.
4321         * objfiles.c (objfile_relocate, objfile_rebase)
4322         (objfile_has_symbols): Remove "struct" from foreach.
4323         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4324         from foreach.
4325         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4326         foreach.
4327         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4328         "struct" from foreach.
4329         * ada-lang.c (create_excep_cond_exprs)
4330         (ada_exception_catchpoint_cond_string): Remove "struct" from
4331         foreach.
4332
4333 2019-05-03  Tom Tromey  <tromey@adacore.com>
4334
4335         * ada-exp.y (convert_char_literal): Check suffix of each
4336         enumerator.
4337
4338 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4339
4340         PR ada/21406:
4341         * ada-exp.y (yywrap): Don't define.
4342         * ada-lex.l (%option): Add noyywrap
4343         (yywrap): Remove.
4344
4345 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4346
4347         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4348         _WIN32_WINNT to the XP level, unless already defined to a higher
4349         level.
4350
4351         * unittests/parse-connection-spec-selftests.c:
4352         * ser-tcp.c:
4353         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4354         override.
4355
4356         * symfile.c (find_separate_debug_file): Remove colon from the
4357         drive spec of DOS/Windows file names of the target, so that the
4358         file name produced from DEBUGDIR and the target's directory will
4359         be valid on DOS/Windows systems.
4360
4361 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4362
4363         * rust-lang.c (val_print_struct): Handle printing structures
4364         containing strings.
4365
4366 2019-05-02  Tom Tromey  <tromey@adacore.com>
4367
4368         * valarith.c (_initialize_valarith): Remove.
4369
4370 2019-05-01  Tom Tromey  <tromey@adacore.com>
4371
4372         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4373         bitfields.
4374
4375 2019-05-01  Tom Tromey  <tromey@adacore.com>
4376
4377         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4378         for big-endian copies.
4379
4380 2019-04-30  Ali Tamur  <tamur@google.com>
4381         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4382         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4383         (read_3_bytes): New function.
4384
4385 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4386
4387         * windows-nat.c (main_thread_id): Delete.
4388         (handle_output_debug_string): Replace main_thread_id by
4389         current_event.dwThreadId.
4390         (fake_create_process): Likewise.
4391         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4392         Do not set main_thread_id.
4393         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4394         current_event.dwThreadId.
4395         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4396
4397 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4398
4399         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4400         Use current_event.dwThreadId instead of main_thread_id.
4401
4402 2019-04-30  Tom Tromey  <tromey@adacore.com>
4403
4404         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4405         (create_excep_cond_exprs): Iterate over program spaces.
4406         (ada_exception_catchpoint_cond_string): Examine all minimal
4407         symbols for exception types.
4408
4409 2019-04-30  Tom Tromey  <tromey@adacore.com>
4410
4411         PR c++/24470:
4412         * dwarf2read.c (process_structure_scope): Handle case where type
4413         has template parameters but no symbol was created.
4414
4415 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4416             Chris January  <chris.january@arm.com>
4417
4418         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4419         qualifier.
4420         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4421
4422 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4423
4424         * f-typeprint.c (f_print_type): Update rules for printing
4425         whitespace.
4426         (f_type_print_varspec_suffix): Likewise.
4427
4428 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4429             Chris January  <chris.january@arm.com>
4430
4431         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4432         function arguments.
4433
4434 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4435
4436         * f-lang.c (build_fortran_types): Change name of void type to
4437         lower case.
4438         * f-typeprint.c (f_type_print_base): Print the name of the void
4439         type, rather than a fixed string.
4440         * f-valprint.c (f_decorations): Use lower case void string.
4441
4442 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4443             Chris January  <chris.january@arm.com>
4444
4445         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4446         types for Fortran.
4447
4448 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4449             Chris January  <chris.january@arm.com>
4450             David Lecomber  <david.lecomber@arm.com>
4451
4452         * f-exp.y (BINOP_INTRINSIC): New token.
4453         (exp): New parser rule handling BINOP_INTRINSIC.
4454         (f77_keywords): Add new builtin procedures.
4455         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4456         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4457         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4458         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4459         (print_unop_subexp_f): New function.
4460         (print_binop_subexp_f): New function.
4461         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4462         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4463         (dump_subexp_body_f): Likewise.
4464         (operator_check_f): Likewise.
4465         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4466         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4467
4468 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4469
4470         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4471         UNOP_KIND.
4472         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4473         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4474         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4475         (operator_length_f): New fuction.
4476         (print_subexp_f): New function.
4477         (op_name_f): New function.
4478         (dump_subexp_body_f): New function.
4479         (operator_check_f): New function.
4480         (exp_descriptor_f): Replace standard expression handling functions
4481         with new functions.
4482         * gdb/fortran-operator.def: New file.
4483         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4484         * gdb/std-operator.def: Remove UNOP_KIND.
4485
4486 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4487
4488         * std-operator.def: Remove unbalanced, stray double quote
4489         character.
4490
4491 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4492             Chris January  <chris.january@arm.com>
4493             Daniel Everett  <daniel.everett@arm.com>
4494             Nick Forrington  <nick.forrington@arm.com>
4495             Richard Bunt  <richard.bunt@arm.com>
4496
4497         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4498         of depth when printing anonymous structs or unions.
4499         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4500         Don't print either the top-level value, or the children if the
4501         max-depth is exceeded.
4502         (ppscm_print_children): When printing the key of a map, allow one
4503         extra level of depth.
4504         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4505         print either the top-level value, or the children if the max-depth
4506         is exceeded.
4507         (print_children): When printing the key of a map, allow one extra
4508         level of depth.
4509         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4510         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4511         (user_print_options): Initialise max_depth field.
4512         (val_print_scalar_or_string_type_p): New function.
4513         (val_print): Check to see if the max depth has been reached.
4514         (val_print_check_max_depth): Define new function.
4515         (show_print_max_depth): New function.
4516         (_initialize_valprint): Add 'print max-depth' option.
4517         * valprint.h (struct value_print_options) <max_depth>: New field.
4518         (val_print_check_max_depth): Declare new function.
4519         * NEWS: Document new feature.
4520
4521 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4522
4523         * ada-lang.c (ada_language_defn): Initialise new field.
4524         * c-lang.c (c_is_string_type_p): New function.
4525         (c_language_defn): Initialise new field.
4526         (cplus_language_defn): Initialise new field.
4527         (asm_language_defn): Initialise new field.
4528         (minimal_language_defn): Initialise new field.
4529         * c-lang.h (c_is_string_type_p): Declare new function.
4530         * d-lang.c (d_language_defn): Initialise new field.
4531         * f-lang.c (f_is_string_type_p): New function.
4532         (f_language_defn): Initialise new field.
4533         * go-lang.c (go_is_string_type_p): New function.
4534         (go_language_defn): Initialise new field.
4535         * language.c (default_is_string_type_p): New function.
4536         (unknown_language_defn): Initialise new field.
4537         (auto_language_defn): Initialise new field.
4538         * language.h (struct language_defn) <la_is_string_type_p>: New
4539         member variable.
4540         (default_is_string_type_p): Declare new function.
4541         * m2-lang.c (m2_language_defn): Initialise new field.
4542         * objc-lang.c (objc_language_defn): Initialise new field.
4543         * opencl-lang.c (opencl_language_defn): Initialise new field.
4544         * p-lang.c (pascal_is_string_type_p): New function.
4545         (pascal_language_defn): Initialise new field.
4546         * rust-lang.c (rust_is_string_type_p): New function.
4547         (rust_language_defn): Initialise new field.
4548
4549 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4550
4551         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4552         New field.
4553         * ada-lang.c (ada_language_defn): Initialise new field.
4554         * c-lang.c (c_language_defn): Likewise.
4555         (cplus_language_defn): Likewise.
4556         (asm_language_defn): Likewise.
4557         (minimal_language_defn): Likewise.
4558         * d-lang.c (d_language_defn): Likewise.
4559         * f-lang.c (f_language_defn): Likewise.
4560         * go-lang.c (go_language_defn): Likewise.
4561         * language.c (unknown_language_defn): Likewise.
4562         (auto_language_defn): Likewise.
4563         * m2-lang.c (m2_language_defn): Likewise.
4564         * objc-lang.c (objc_language_defn): Likewise.
4565         * opencl-lang.c (opencl_language_defn): Likewise.
4566         * p-lang.c (pascal_language_defn): Likewise.
4567         * rust-lang.c (rust_language_defn): Likewise.
4568
4569 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4570
4571         * ada-lang.c (ada_is_character_type): Change return type to bool.
4572         (ada_is_string_type): Likewise.
4573         * ada-lang.h (ada_is_character_type): Update declaration
4574         (ada_is_string_type): Likewise.
4575
4576 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4577
4578         Support style in 'frame|thread apply'
4579
4580         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4581         * record.c (record_start, record_stop): Update callers of
4582         execute_command_to_string with false.
4583         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4584         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4585         methods.
4586         (class string_file): New constructor with term_out parameter.
4587         Override methods term_out and can_emit_style_escape.  New member
4588         term_out.
4589         (class stdio_file): Override can_emit_style_escape.
4590         (class tee_file): Override term_out and can_emit_style_escape.
4591         * utils.h (can_emit_style_escape): Remove.
4592         * utils.c (can_emit_style_escape): Likewise.
4593         Update all callers of can_emit_style_escape (SOMESTREAM) to
4594         SOMESTREAM->can_emit_style_escape.
4595         * source-cache.c (source_cache::get_source_lines): Likewise.
4596         * stack.c (frame_apply_command_count): Call execute_command_to_string
4597         passing the term_out characteristic of the current gdb_stdout.
4598         * thread.c (thr_try_catch_cmd): Likewise.
4599         * top.c (execute_command_to_string): pass term_out parameter
4600         to construct the string_file for the command output.
4601         * ui-file.c (term_cli_styling): New function (most code moved
4602         from utils.c can_emit_style_escape).
4603         (string_file::string_file, string_file::can_emit_style_escape,
4604         stdio_file::can_emit_style_escape, tee_file::term_out,
4605         tee_file::can_emit_style_escape): New functions.
4606
4607 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4608
4609         * NEWS: Mention the new set|show may-call-functions.
4610         * infcall.c (may_call_functions_p): New variable.
4611         (show_may_call_functions_p): New function.
4612         (call_function_by_hand_dummy): Throws an error if not
4613         may-call-functions.
4614         (_initialize_infcall): Call add_setshow_boolean_cmd for
4615         may-call-functions.
4616
4617 2019-04-25  Keith Seitz  <keiths@redhat.com>
4618
4619         PR c++/24367
4620         * cp-support.c (inspect_type): Don't attempt substitutions
4621         of symbol with the same name.
4622
4623 2019-04-25  Tom Tromey  <tromey@adacore.com>
4624
4625         PR gdb/24475:
4626         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4627         static.
4628
4629 2019-04-25  Tom Tromey  <tromey@adacore.com>
4630
4631         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4632         rvalue reference.
4633         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4634         (gdb_xml_parser::parse): Use std::move.
4635         * python/python-internal.h (gdbpy_convert_exception): Take a const
4636         reference.
4637         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4638         std::move.
4639         * python/py-utils.c (gdbpy_convert_exception): Take a const
4640         reference.
4641         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4642         Use std::move.
4643         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4644         Use std::move.
4645         * mi/mi-main.c (mi_print_exception): Take a const reference.
4646         * main.c (handle_command_errors): Take a const reference.
4647         * linespec.c (parse_linespec): Use std::move.
4648         * infcall.c (run_inferior_call): Use std::move.
4649         (call_function_by_hand_dummy): Use std::move.
4650         * exec.c (try_open_exec_file): Use std::move.
4651         * exceptions.h (exception_print, exception_fprintf)
4652         (exception_print_same): Update.
4653         * exceptions.c (print_exception, exception_print)
4654         (exception_fprintf, exception_print_same): Change parameters to
4655         const reference.
4656         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4657         * common/new-op.c: Use std::move.
4658         * common/common-exceptions.h (struct gdb_exception): Add move
4659         constructor.
4660         (struct gdb_exception_error, struct gdb_exception_quit, struct
4661         gdb_quit_bad_alloc): Change constructor to move constructor.
4662         (throw_exception): Change parameter to rvalue reference.
4663         * common/common-exceptions.c (throw_exception): Take rvalue
4664         reference.
4665         * cli/cli-interp.c (safe_execute_command): Use std::move.
4666         * breakpoint.c (insert_bp_location, location_to_sals): Use
4667         std::move.
4668
4669 2019-04-25  Tom Tromey  <tromey@adacore.com>
4670
4671         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4672         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4673         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4674         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4675         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4676         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4677         guile/scm-value.c: Use unpack.
4678         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4679         gdbscm_gdb_exception.
4680         (gdbscm_throw_gdb_exception): Likewise.
4681         (struct gdbscm_gdb_exception): New.
4682         (unpack): New function.
4683         (gdbscm_wrap): Use unpack.
4684
4685 2019-04-25  Tom Tromey  <tromey@adacore.com>
4686
4687         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4688         (gdb_rl_callback_handler): Use std::move.
4689         * common/common-exceptions.h (struct gdb_exception): Add move
4690         assignment operator.
4691         (throw_exception_sjlj): Change "exception" to const reference.
4692         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4693         (throw_exception_sjlj): Change "exception" to const reference.
4694
4695 2019-04-25  Tom Tromey  <tromey@adacore.com>
4696
4697         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4698         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4699         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4700         Update.
4701         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4702         Update.
4703         * mi/mi-interp.c (mi_interp::exec): Update.
4704         * linespec.c (parse_linespec): Update.
4705         * infcall.c (run_inferior_call): Update.
4706         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4707         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4708         (gdbscm_lookup_global_symbol): Update.
4709         * guile/scm-param.c (gdbscm_parameter_value): Update.
4710         * guile/scm-frame.c (gdbscm_frame_read_register)
4711         (gdbscm_frame_read_var): Update.
4712         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4713         * exec.c (try_open_exec_file): Update.
4714         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4715         (gdb_rl_callback_handler): Update.
4716         * common/common-exceptions.h (exception_none): Don't declare.
4717         * common/common-exceptions.c (exception_none): Don't define.
4718         (struct catcher) <exception>: Update.
4719         * cli/cli-interp.c (safe_execute_command): Update.
4720         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4721
4722 2019-04-25  Ali Tamur  <tamur@google.com>
4723
4724         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4725         (read_attribute_value): Likewise.
4726         (dwarf2_read_addr_index): Update comment.
4727         (read_str_index): Add DW_FORM_strx.
4728         (dwarf2_string_attr): Likewise.
4729         (dwarf2_const_value_attr): Likewise.
4730         (dump_die_shallow): Likewise.
4731         (dwarf2_fetch_constant_bytes): Likewise.
4732         (skip_form_bytes): Likewise.
4733         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4734
4735 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4736
4737         PR corefiles/11608
4738         PR corefiles/18187
4739         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4740         OFFSET.  Verify if current mapping contains an ELF header.
4741         (linux_find_memory_regions_full): Adjust call to
4742         dump_mapping_p.
4743
4744 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4745             Kang Li <kanglictf@gmail.com>
4746
4747         PR gdb/21600
4748
4749         * dwarf2-frame.c (read_initial_length): Be consistent about using
4750         unsigned representation of length.
4751         (decode_frame_entry_1): Likewise.  Check for wraparound of
4752         end pointer as well as buffer overflow.
4753
4754 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4755
4756         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4757         "vq".
4758
4759 2019-04-24  Tom Tromey  <tromey@adacore.com>
4760
4761         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4762
4763 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4764
4765         * s12z-tdep.c (s12z_unwind_pc): Delete.
4766         (s12z_unwind_sp): Delete.
4767         (s12z_gdbarch_init): Don't register deleted functions with
4768         gdbarch.
4769
4770 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4771
4772         * rl78-tdep.c (rl78_unwind_sp): Delete.
4773         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4774
4775 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4776
4777         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4778         (xstormy16_unwind_pc): Delete.
4779         (xstormy16_dummy_id): Delete.
4780         (xstormy16_gdbarch_init): Don't register deleted functions with
4781         gdbarch.
4782
4783 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4784
4785         * vax-tdep.c (vax_unwind_pc): Delete.
4786         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4787
4788 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4789
4790         * v850-tdep.c (v850_unwind_sp): Delete.
4791         (v850_unwind_pc): Delete.
4792         (v850_dummy_id): Delete.
4793         (v850_gdbarch_init): Don't register deleted functions with
4794         gdbarch.
4795
4796 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4797
4798         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4799         (tilegx_unwind_pc): Delete.
4800         (tilegx_unwind_dummy_id): Delete.
4801         (tilegx_gdbarch_init): Don't register deleted functions with
4802         gdbarch.
4803
4804 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4805
4806         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4807         (tic6x_dummy_id): Delete.
4808         (tic6x_gdbarch_init): Don't register deleted functions with
4809         gdbarch.
4810
4811 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4812
4813         * sparc-tdep.c (sparc_unwind_pc): Delete.
4814         (sparc32_gdbarch_init): Don't register deleted function with
4815         gdbarch.
4816
4817 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4818
4819         * sh-tdep.c (sh_unwind_sp): Delete.
4820         (sh_unwind_pc): Delete.
4821         (sh_dummy_id): Delete.
4822         (sh_gdbarch_init): Don't register deleted functions with
4823         gdbarch.
4824
4825 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4826
4827         * score-tdep.c (score_unwind_sp): Delete.
4828         (score_unwind_pc): Delete.
4829         (score_dummy_id): Delete.
4830         (score_gdbarch_init): Don't register deleted functions with
4831         gdbarch.
4832
4833 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4834
4835         * rx-tdep.c (rx_unwind_pc): Delete.
4836         (rx_unwind_sp): Delete.
4837         (rx_dummy_id): Delete.
4838         (rx_gdbarch_init): Don't register deleted functions with
4839         gdbarch.  Update comment.
4840
4841 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4842
4843         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4844         (rs6000_dummy_id): Delete.
4845         (rs6000_gdbarch_init): Don't register deleted functions with
4846         gdbarch.
4847
4848 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4849
4850         * or1k-tdep.c (or1k_dummy_id): Delete.
4851         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4852
4853 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4854
4855         * nios2-tdep.c (nios2_dummy_id): Delete.
4856         (nios2_unwind_sp): Delete.
4857         (nios2_gdbarch_init): Don't register deleted functions with
4858         gdbarch.
4859
4860 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4861
4862         * nds32-tdep.c (nds32_dummy_id): Delete.
4863         (nds32_unwind_pc): Delete.
4864         (nds32_unwind_sp): Delete.
4865         (nds32_gdbarch_init): Don't register deleted functions with
4866         gdbarch.
4867
4868 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4869
4870         * msp430-tdep.c (msp430_unwind_pc): Delete.
4871         (msp430_unwind_sp): Delete.
4872         (msp430_dummy_id): Delete.
4873         (msp430_gdbarch_init): Don't register deleted functions with
4874         gdbarch.
4875
4876 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4877
4878         * moxie-tdep.c (moxie_unwind_sp): Delete.
4879         (moxie_unwind_pc): Delete.
4880         (moxie_dummy_id): Delete.
4881         (moxie_gdbarch_init): Don't register deleted functions with
4882         gdbarch.
4883
4884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4885
4886         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4887         (mn10300_unwind_pc): Delete.
4888         (mn10300_unwind_sp): Delete.
4889         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4890         mn10300_unwind_sp.
4891         (mn10300_frame_unwind_init): Don't register deleted functions with
4892         gdbarch.
4893
4894 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4895
4896         * mep-tdep.c (mep_unwind_pc): Delete.
4897         (mep_unwind_sp): Delete.
4898         (mep_dummy_id): Delete.
4899         (mep_gdbarch_init): Don't register deleted functions with
4900         gdbarch.
4901
4902 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4903
4904         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4905         (m68hc11_unwind_sp): Delete.
4906         (m68hc11_gdbarch_init): Don't register deleted functions with
4907         gdbarch.
4908
4909 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4910
4911         * m32r-tdep.c (m32r_unwind_sp): Delete.
4912         (m32r_unwind_pc): Delete.
4913         (m32r_dummy_id): Delete.
4914         (m32r_gdbarch_init): Don't register deleted functions with
4915         gdbarch.
4916
4917 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4918
4919         * m32c-tdep.c (m32c_unwind_pc): Delete.
4920         (m32c_unwind_sp): Delete.
4921         (m32c_dummy_id): Delete.
4922         (m32c_gdbarch_init): Don't register deleted functions with
4923         gdbarch.
4924
4925 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4926
4927         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4928         (lm32_unwind_pc): Delete.
4929         (lm32_dummy_id): Delete.
4930         (lm32_gdbarch_init): Don't register deleted functions with
4931         gdbarch.
4932
4933 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4934
4935         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4936         (iq2000_unwind_pc): Delete.
4937         (iq2000_dummy_id): Delete.
4938         (iq2000_gdbarch_init): Don't register deleted functions with
4939         gdbarch.
4940
4941 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4942
4943         * nds32-tdep.c (nds32_type_align): Delete.
4944         (nds32_push_dummy_call): Use type_align instead.
4945
4946 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4947
4948         * arm-tdep.c (arm_type_align): Only handle vector override case.
4949         (arm_push_dummy_call): Use type_align.
4950         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4951
4952 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4953
4954         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4955         case.
4956         (pass_on_stack): Use type_align.
4957         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4958         function.
4959
4960 2019-04-23  Tom Tromey  <tromey@adacore.com>
4961
4962         * dwarf2read.c (line_header::file_name_at): Remove unused
4963         overload.
4964
4965 2019-04-23  Tom de Vries  <tdevries@suse.de>
4966
4967         PR gdb/24438
4968         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4969         invocation.
4970
4971
4972 2019-03-27  Ali Tamur  <tamur@google.com>
4973
4974         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4975         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4976         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4977         (dwarf_expr_context::get_addr_index): Likewise
4978         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4979         (symbol_needs_eval_context::get_addr_index): Likewise
4980         (disassemble_dwarf_expression): Add DW_OP_addrx
4981         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4982         (read_cutu_die_from_dwo): Update comment
4983         (skip_one_die): Add DW_FORM_addrx
4984         (read_attribute_value): Likewise
4985         (var_decode_location): Add DW_OP_addrx
4986         (dwarf2_const_value_attr): Add DW_FORM_addrx
4987         (dump_die_shallow): Likewise
4988         (dwarf2_fetch_constant_bytes): Likewise
4989         (decode_locdesc): Add DW_OP_addrx
4990         (skip_form_bytes): Add DW_FORM_addrx
4991
4992 2019-04-22  Ali Tamur  <tamur@google.com>
4993
4994         * MAINTAINERS (Write After Approval): Add self.
4995
4996 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4997
4998         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4999         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5000         (open_symbol_file_object): Likewise.
5001         (svr4_default_sos): Add info parameter.
5002         (svr4_read_so_list): Likewise.
5003         (svr4_current_sos_direct): Adjust functions calls to pass down
5004         info.
5005         (svr4_current_sos_1): Add info parameter.
5006         (svr4_current_sos): Call get_svr4_info, pass info down to
5007         svr4_current_sos_1.
5008         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5009         get_svr4_info.
5010         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5011         get_svr4_info.
5012         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5013         to get_svr4_info.
5014         (probes_table_remove_objfile_probes): Likewise.
5015         (register_solib_event_probe): Add info parameter.
5016         (solist_update_incremental): Pass info parameter down to
5017         svr4_read_so_list.
5018         (disable_probes_interface): Add info parameter.
5019         (svr4_handle_solib_event): Pass current_program_space to
5020         get_svr4_info.  Adjust disable_probes_interface cleanup.
5021         (svr4_create_probe_breakpoints): Add info parameter, pass it
5022         down to register_solib_event_probe.
5023         (svr4_create_solib_event_breakpoints): Add info parameter,
5024         pass it down to svr4_create_probe_breakpoints.
5025         (enable_break): Pass info down to
5026         svr4_create_solib_event_breakpoints.
5027         (svr4_solib_create_inferior_hook): Pass current_program_space to
5028         get_svr4_info.
5029         (svr4_clear_solib): Likewise.
5030
5031 2019-04-22  Pedro Alves  <palves@redhat.com>
5032
5033         * solib-svr4.c (svr4_free_objfile_observer): New.
5034         (probe_and_action::objfile): New field.
5035         (probes_table_htab_remove_objfile_probes)
5036         (probes_table_remove_objfile_probes): New functions.
5037         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5038         in the new probe_and_action.  Don't store the probe in 'lookup'.
5039         (svr4_create_probe_breakpoints): Pass objfile to
5040         register_solib_event_probe.
5041         (_initialize_svr4_solib): Register a free_objfile observer.
5042
5043 2019-04-19  Tom Tromey  <tom@tromey.com>
5044
5045         * common/queue.h: Remove.
5046
5047 2019-04-19  Tom Tromey  <tom@tromey.com>
5048
5049         * event-loop.c: Don't include "common/queue.h".
5050
5051 2019-04-19  Tom Tromey  <tom@tromey.com>
5052
5053         * remote.c (remote_target): Use delete.
5054         * remote-notif.h: Include <list>, not "common/queue.h".
5055         (notif_client_p): Remove typedef.
5056         (remote_notif_state): Add constructor, destructor, initializer.
5057         <notif_queue>: Now a std::list.
5058         (remote_notif_state_xfree): Don't declare.
5059         * remote-notif.c (remote_notif_process, handle_notification)
5060         (remote_notif_state_allocate): Update.
5061         (~remote_notif_state): Rename from remote_notif_state_xfree.
5062
5063 2019-04-19  Tom Tromey  <tom@tromey.com>
5064
5065         * symfile.c (reread_symbols): Update.
5066         * objfiles.c (objfile_register_static_link)
5067         (objfile_lookup_static_link): Update
5068         (~objfile) Don't delete static_links.
5069         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5070
5071 2019-04-19  Tom Tromey  <tom@tromey.com>
5072
5073         * type-stack.h (struct type_stack) <insert>: Constify string.
5074         * type-stack.c (type_stack::insert): Constify string.
5075         * gdbtypes.h (lookup_template_type): Update.
5076         (address_space_name_to_int): Update.
5077         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5078         const.
5079         (lookup_template_type): Make name const.
5080         * c-exp.y: Update rules.
5081         (lex_one_token, classify_name, classify_inner_name)
5082         (c_print_token): Update.
5083         * p-exp.y: Update rules.
5084         (yylex): Update.
5085         * f-exp.y: Update rules.
5086         (yylex): Update.
5087         * d-exp.y: Update rules.
5088         (lex_one_token, classify_name, classify_inner_name): Update.
5089         * parse.c (write_dollar_variable, copy_name): Return std::string.
5090         * parser-defs.h (copy_name): Change return type.
5091         * m2-exp.y: Update rules.
5092         (yylex): Update.
5093         * go-exp.y (lex_one_token): Update.
5094         Update rules.
5095         (classify_unsafe_function, classify_packaged_name)
5096         (classify_name, yylex): Update.
5097
5098 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5099
5100         * configure.ac: add --enable-source-highlight switch.
5101         * configure: Regenerate.
5102         * top.c (print_gdb_version): plumb --enable-source-highlight
5103         status to "show configuration".
5104
5105 2019-04-19  Tom Tromey  <tromey@adacore.com>
5106
5107         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5108         Check ADA_TYPE_P.
5109         (empty_record, ada_template_to_fixed_record_type_1)
5110         (template_to_static_fixed_type)
5111         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5112         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5113         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5114         macros.
5115
5116 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5117
5118         PR symtab/24423:
5119         * source.c (print_source_lines_base): Advance "iter" when a
5120         control character is seen.
5121
5122 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5123
5124         * inferior.h (struct infcall_suspend_state_deleter):
5125         Catch exception in destructor to avoid crash.
5126
5127 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5128
5129         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5130         close to the add_com "shell".
5131
5132 2019-04-18  Tom Tromey  <tromey@adacore.com>
5133
5134         * process-stratum-target.h (class process_stratum_target)
5135         <stratum>: Add "final".
5136
5137 2019-04-17  Tom Tromey  <tromey@adacore.com>
5138
5139         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5140         against nullptr before use.
5141
5142 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5143
5144         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5145
5146 2019-04-17  Jim Wilson  <jimw@sifive.com>
5147             Andrew Burgess  <andrew.burgess@embecosm.com>
5148
5149         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5150         code read might fail, assume 4-byte breakpoint in that case.
5151
5152 2019-04-15  Leszek Swirski  <leszeks@google.com>
5153
5154         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5155         rather than a hand-rolled POD check when checking for forced MEMORY
5156         classification.
5157
5158 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5159
5160         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5161         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5162         function.
5163         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5164         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5165         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5166         declaration.
5167
5168 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5169
5170         * aarch64-linux-nat.c
5171         (aarch64_linux_nat_target::thread_architecture): Add override.
5172         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5173         each VQ.
5174
5175 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5176
5177         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5178
5179 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5180
5181         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5182         target types of size 96-bits, add some additional comments, and
5183         check that the builtin type we found was the correct size.
5184
5185 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5186
5187         * utils.c (prompt_for_continue): Don't restore the styling at the
5188         end, as applied_style has the wrong value.  This fixes styling in
5189         long lists of file names that are interrupted by the "Continue?"
5190         prompt.
5191
5192 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5193
5194         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5195         * c-lang.c (c_language_defn): Likewise.
5196         (cplus_language_defn): Likewise.
5197         (asm_language_defn): Likewise.
5198         (minimal_language_defn): Likewise.
5199         * d-lang.c (d_language_defn): Likewise.
5200         * f-lang.c (f_language_defn): Likewise.
5201         * go-lang.c (go_language_defn): Likewise.
5202         * language.c (unknown_language_defn): Likewise.
5203         (auto_language_defn): Likewise.
5204         * language.h (struct language_defn): Remove la_magic field.
5205         (LANG_MAGIC): Delete.
5206         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5207         * objc-lang.c (objc_language_defn): Likewise.
5208         * opencl-lang.c (opencl_language_defn): Likewise.
5209         * p-lang.c (pascal_language_defn): Likewise.
5210         * rust-lang.c (rust_language_defn): Likewise.
5211
5212 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5213
5214         * riscv-tdep.c (riscv_type_align): New function.
5215         (riscv_type_alignment): Delete.
5216         (riscv_arg_location): Use 'type_align'.
5217         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5218
5219 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5220
5221         * gdbtypes.c (type_align): A struct with no non-static fields also
5222         has alignment of 1.
5223
5224 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5225
5226         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5227         component to 0.
5228         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5229         member.
5230         (riscv_struct_info::analyse): New implementation using new
5231         analyse_inner member function.
5232         (riscv_struct_info::field_offset): New member function.
5233         (riscv_struct_info::m_offsets): New member variable.
5234         (riscv_struct_info::analyse_inner): New private member function,
5235         takes the old implementation of riscv_struct_info::analyse but
5236         extended to track field offsets.
5237         (riscv_call_arg_struct): Update the struct folding special cases
5238         to handle cases where empty C++ structs, which are non-zero
5239         length, are found.
5240         (riscv_arg_location): Initialise the length of each location, a
5241         non-zero length now indicates the location is in use.
5242         (riscv_push_dummy_call): Allow for the first location having a
5243         non-zero offset when setting up arguments.
5244         (riscv_return_value): Likewise, but for return values.
5245
5246 2019-04-11  Tom Tromey  <tromey@adacore.com>
5247
5248         * utils.c (internal_vproblem): Make "msg" const.
5249
5250 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5251
5252         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5253         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5254         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5255         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5256
5257 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5258
5259         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5260         function.
5261         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5262         of amd64_collect_native_gregset.
5263         (amd64_linux_nat_target::store_registers): Likewise.
5264
5265 2019-04-10  Tom Tromey  <tom@tromey.com>
5266
5267         * symtab.c (lookup_global_symbol_from_objfile)
5268         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5269         * objfiles.h (class separate_debug_iterator): New.
5270         (class separate_debug_range): New.
5271         (struct objfile) <separate_debug_objfiles>: New method.
5272         (objfile_separate_debug_iterate): Don't declare.
5273         * objfiles.c (separate_debug_iterator::operator++): Rename from
5274         objfile_separate_debug_iterate.
5275         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5276         iterator.
5277         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5278         iterator.
5279
5280 2019-04-10  Tom Tromey  <tom@tromey.com>
5281
5282         * symfile.c (reread_symbols): Remove old comment.
5283         * objfiles.c (free_all_objfiles): Fix a typo.
5284
5285 2019-04-10  Tom Tromey  <tom@tromey.com>
5286
5287         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5288         * minsyms.c (lookup_minimal_symbol): Use foreach.
5289         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5290         (lookup_minimal_symbol_solib_trampoline): Likewise.
5291         * symfile.c (reread_symbols): Use foreach.
5292
5293 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5294             Tom Tromey  <tromey@adacore.com>
5295
5296         PR rust/24414:
5297         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5298         (rust_lex_int_test): Change "value" to be LONGEST.
5299         (rust_lex_tests): Add test for long integer literal.
5300
5301 2019-04-09  Tom Tromey  <tromey@adacore.com>
5302
5303         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5304         to bool.
5305         (extended_remote_target::attach): Update.
5306         (remote_target::remote_notice_new_inferior): Update.
5307         (remote_target::add_current_inferior_and_thread): Update.
5308         * inferior.c (exit_inferior_1): Use "false".
5309         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5310
5311 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5312
5313         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5314         the "start" command.
5315
5316 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5317
5318         * python/py-inferior.c (infpy_thread_from_thread_handle):
5319         Adjust comments to reflect renaming of thread_from_thread_handle
5320         to thread_from_handle.  Adjust keywords.  Fix type error message.
5321         (inferior_object_methods): Add thread_from_handle.  Retain
5322         thread_from_thread_handle, but mark it as deprecated.
5323
5324 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5325
5326         * gdbthread.h (find_thread_by_handle): Revise declaration.
5327         * thread.c (find_thread_by_handle): Likewise.  Adjust
5328         implementation too.
5329         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5330         support for buffer objects as handles.
5331
5332 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5333
5334         * python/py-infthread.c (thpy_thread_handle): New function.
5335         (thread_object_methods): Register thpy_thread_handle.
5336
5337 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5338
5339         * gdbthread.h (thread_to_thread_handle): Declare.
5340         * thread.c (gdbtypes.h): Include.
5341         (thread_to_thread_handle): New function.
5342
5343         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5344         (target_thread_info_to_thread_handle): Declare.
5345         * target.c (target_thread_info_to_thread_handle): New function.
5346         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5347         * target-delegates.c: Regenerate.
5348
5349         * linux-thread-db.c (class thread_db_target): Add method
5350         thread_info_to_thread_handle.
5351         (thread_db_target::thread_info_to_thread_handle): Define.
5352         * remote.c (class remote_target): Add new method
5353         thread_info_to_thread_handle.
5354         (remote_target::thread_info_to_thread_handle): Define.
5355
5356 2019-04-08  Pedro Alves  <palves@redhat.com>
5357
5358         * common/common-exceptions.c (throw_exception): Don't create
5359         named object to throw; throw directly.
5360         (throw_it): Likewise.  Don't initialize gdb_exception::message
5361         here, with new; pass FMT and AP to the ctor instead.
5362         * common/common-exceptions.h: Include <string>.
5363         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5364         const char *, va_list)): New ctor.  Use std::make_shared.
5365         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5366         errors)): Delete.
5367         (gdb_exception_error::gdb_exception_error(enum errors, const char
5368         *, va_list)): New.
5369         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5370         Add assertion.
5371         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5372         errors)): Delete.
5373         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5374         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5375         Add assertion.
5376
5377 2019-04-08  Tom Tromey  <tom@tromey.com>
5378
5379         * valops.c (value_rtti_indirect_type): Replace throw_exception
5380         with throw.
5381         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5382         with throw.
5383         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5384         throw.
5385         * target.c (target_translate_tls_address): Replace throw_exception
5386         with throw.
5387         * stack.c (frame_apply_command_count): Replace throw_exception
5388         with throw.
5389         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5390         throw.
5391         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5392         with throw.
5393         * rs6000-tdep.c (rs6000_frame_cache)
5394         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5395         * remote.c: Replace throw_exception with throw.
5396         * record-full.c (record_full_message, record_full_wait_1)
5397         (record_full_restore): Replace throw_exception with throw.
5398         * record-btrace.c:
5399         (get_thread_current_frame_id, record_btrace_start_replaying)
5400         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5401         (cmd_record_btrace_start): Replace throw_exception with throw.
5402         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5403         throw.
5404         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5405         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5406         * linespec.c:
5407         (find_linespec_symbols): Replace throw_exception with throw.
5408         * infrun.c (displaced_step_prepare, resume): Replace
5409         throw_exception with throw.
5410         * infcmd.c (post_create_inferior): Replace throw_exception with
5411         throw.
5412         * inf-loop.c (inferior_event_handler): Replace throw_exception
5413         with throw.
5414         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5415         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5416         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5417         (get_prev_frame_always, get_frame_pc_if_available)
5418         (get_frame_address_in_block_if_available, get_frame_language):
5419         Replace throw_exception with throw.
5420         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5421         throw_exception with throw.
5422         * eval.c (fetch_subexp_value, evaluate_var_value)
5423         (evaluate_funcall, evaluate_subexp_standard): Replace
5424         throw_exception with throw.
5425         * dwarf2loc.c (call_site_find_chain)
5426         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5427         Replace throw_exception with throw.
5428         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5429         with throw.
5430         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5431         throw.
5432         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5433         * completer.c (complete_line_internal): Replace throw_exception
5434         with throw.
5435         * compile/compile-object-run.c (compile_object_run): Replace
5436         throw_exception with throw.
5437         * cli/cli-script.c (process_next_line): Replace throw_exception
5438         with throw.
5439         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5440         (btrace_enable, btrace_maint_update_pt_packets): Replace
5441         throw_exception with throw.
5442         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5443         throw_exception with throw.
5444         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5445         throw_exception with throw.
5446         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5447         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5448         * aarch64-tdep.c (aarch64_make_prologue_cache)
5449         (aarch64_make_stub_cache): Replace throw_exception with throw.
5450
5451 2019-04-08  Tom Tromey  <tom@tromey.com>
5452
5453         * common/common-exceptions.c (throw_exception): Rename from
5454         throw_exception_cxx.  Remove old copy.  Make argument const.
5455         (throw_it): Create and throw exception objects directly.
5456         * common/common-exceptions.h (throw_exception): Make argument
5457         const.
5458         (struct gdb_exception_error): Add constructor.
5459         (struct gdb_exception_quit): Add constructor.
5460
5461 2019-04-08  Tom Tromey  <tom@tromey.com>
5462
5463         * common/common-exceptions.h (exception_rethrow): Don't declare.
5464         (TRY_SJLJ): Update comment.
5465         (TRY, CATCH, END_CATCH): Remove.
5466         * common/common-exceptions.c (exception_rethrow): Remove.
5467
5468 2019-04-08  Tom Tromey  <tom@tromey.com>
5469
5470         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5471         Remove.
5472         (gdb_exception_error): Rename from
5473         gdb_exception_RETURN_MASK_ERROR.
5474         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5475         (gdb_quit_bad_alloc): Update.
5476         * aarch64-tdep.c: Update.
5477         * ada-lang.c: Update.
5478         * ada-typeprint.c: Update.
5479         * ada-valprint.c: Update.
5480         * amd64-tdep.c: Update.
5481         * arch-utils.c: Update.
5482         * break-catch-throw.c: Update.
5483         * breakpoint.c: Update.
5484         * btrace.c: Update.
5485         * c-varobj.c: Update.
5486         * cli/cli-cmds.c: Update.
5487         * cli/cli-interp.c: Update.
5488         * cli/cli-script.c: Update.
5489         * common/common-exceptions.c: Update.
5490         * common/new-op.c: Update.
5491         * common/selftest.c: Update.
5492         * compile/compile-c-symbols.c: Update.
5493         * compile/compile-cplus-symbols.c: Update.
5494         * compile/compile-object-load.c: Update.
5495         * compile/compile-object-run.c: Update.
5496         * completer.c: Update.
5497         * corelow.c: Update.
5498         * cp-abi.c: Update.
5499         * cp-support.c: Update.
5500         * cp-valprint.c: Update.
5501         * darwin-nat.c: Update.
5502         * disasm-selftests.c: Update.
5503         * dtrace-probe.c: Update.
5504         * dwarf-index-cache.c: Update.
5505         * dwarf-index-write.c: Update.
5506         * dwarf2-frame-tailcall.c: Update.
5507         * dwarf2-frame.c: Update.
5508         * dwarf2loc.c: Update.
5509         * dwarf2read.c: Update.
5510         * eval.c: Update.
5511         * event-loop.c: Update.
5512         * event-top.c: Update.
5513         * exec.c: Update.
5514         * f-valprint.c: Update.
5515         * fbsd-tdep.c: Update.
5516         * frame-unwind.c: Update.
5517         * frame.c: Update.
5518         * gdbtypes.c: Update.
5519         * gnu-v3-abi.c: Update.
5520         * guile/guile-internal.h: Update.
5521         * guile/scm-block.c: Update.
5522         * guile/scm-breakpoint.c: Update.
5523         * guile/scm-cmd.c: Update.
5524         * guile/scm-disasm.c: Update.
5525         * guile/scm-frame.c: Update.
5526         * guile/scm-lazy-string.c: Update.
5527         * guile/scm-math.c: Update.
5528         * guile/scm-param.c: Update.
5529         * guile/scm-ports.c: Update.
5530         * guile/scm-pretty-print.c: Update.
5531         * guile/scm-symbol.c: Update.
5532         * guile/scm-symtab.c: Update.
5533         * guile/scm-type.c: Update.
5534         * guile/scm-value.c: Update.
5535         * i386-linux-tdep.c: Update.
5536         * i386-tdep.c: Update.
5537         * inf-loop.c: Update.
5538         * infcall.c: Update.
5539         * infcmd.c: Update.
5540         * infrun.c: Update.
5541         * jit.c: Update.
5542         * language.c: Update.
5543         * linespec.c: Update.
5544         * linux-fork.c: Update.
5545         * linux-nat.c: Update.
5546         * linux-tdep.c: Update.
5547         * linux-thread-db.c: Update.
5548         * main.c: Update.
5549         * mi/mi-cmd-break.c: Update.
5550         * mi/mi-cmd-stack.c: Update.
5551         * mi/mi-interp.c: Update.
5552         * mi/mi-main.c: Update.
5553         * objc-lang.c: Update.
5554         * p-valprint.c: Update.
5555         * parse.c: Update.
5556         * ppc-linux-tdep.c: Update.
5557         * printcmd.c: Update.
5558         * python/py-arch.c: Update.
5559         * python/py-breakpoint.c: Update.
5560         * python/py-cmd.c: Update.
5561         * python/py-finishbreakpoint.c: Update.
5562         * python/py-frame.c: Update.
5563         * python/py-framefilter.c: Update.
5564         * python/py-gdb-readline.c: Update.
5565         * python/py-inferior.c: Update.
5566         * python/py-infthread.c: Update.
5567         * python/py-lazy-string.c: Update.
5568         * python/py-linetable.c: Update.
5569         * python/py-objfile.c: Update.
5570         * python/py-param.c: Update.
5571         * python/py-prettyprint.c: Update.
5572         * python/py-progspace.c: Update.
5573         * python/py-record-btrace.c: Update.
5574         * python/py-record.c: Update.
5575         * python/py-symbol.c: Update.
5576         * python/py-type.c: Update.
5577         * python/py-unwind.c: Update.
5578         * python/py-utils.c: Update.
5579         * python/py-value.c: Update.
5580         * python/python.c: Update.
5581         * record-btrace.c: Update.
5582         * record-full.c: Update.
5583         * remote-fileio.c: Update.
5584         * remote.c: Update.
5585         * riscv-tdep.c: Update.
5586         * rs6000-aix-tdep.c: Update.
5587         * rs6000-tdep.c: Update.
5588         * rust-exp.y: Update.
5589         * rust-lang.c: Update.
5590         * s390-tdep.c: Update.
5591         * selftest-arch.c: Update.
5592         * solib-dsbt.c: Update.
5593         * solib-frv.c: Update.
5594         * solib-spu.c: Update.
5595         * solib-svr4.c: Update.
5596         * solib.c: Update.
5597         * sparc64-linux-tdep.c: Update.
5598         * stack.c: Update.
5599         * symfile-mem.c: Update.
5600         * symmisc.c: Update.
5601         * target.c: Update.
5602         * thread.c: Update.
5603         * top.c: Update.
5604         * tracefile-tfile.c: Update.
5605         * tui/tui.c: Update.
5606         * typeprint.c: Update.
5607         * unittests/cli-utils-selftests.c: Update.
5608         * unittests/parse-connection-spec-selftests.c: Update.
5609         * valops.c: Update.
5610         * valprint.c: Update.
5611         * value.c: Update.
5612         * varobj.c: Update.
5613         * windows-nat.c: Update.
5614         * x86-linux-nat.c: Update.
5615         * xml-support.c: Update.
5616
5617 2019-04-08  Tom Tromey  <tom@tromey.com>
5618
5619         * xml-support.c: Use C++ exception handling.
5620         * x86-linux-nat.c: Use C++ exception handling.
5621         * windows-nat.c: Use C++ exception handling.
5622         * varobj.c: Use C++ exception handling.
5623         * value.c: Use C++ exception handling.
5624         * valprint.c: Use C++ exception handling.
5625         * valops.c: Use C++ exception handling.
5626         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5627         handling.
5628         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5629         * typeprint.c: Use C++ exception handling.
5630         * tui/tui.c: Use C++ exception handling.
5631         * tracefile-tfile.c: Use C++ exception handling.
5632         * top.c: Use C++ exception handling.
5633         * thread.c: Use C++ exception handling.
5634         * target.c: Use C++ exception handling.
5635         * symmisc.c: Use C++ exception handling.
5636         * symfile-mem.c: Use C++ exception handling.
5637         * stack.c: Use C++ exception handling.
5638         * sparc64-linux-tdep.c: Use C++ exception handling.
5639         * solib.c: Use C++ exception handling.
5640         * solib-svr4.c: Use C++ exception handling.
5641         * solib-spu.c: Use C++ exception handling.
5642         * solib-frv.c: Use C++ exception handling.
5643         * solib-dsbt.c: Use C++ exception handling.
5644         * selftest-arch.c: Use C++ exception handling.
5645         * s390-tdep.c: Use C++ exception handling.
5646         * rust-lang.c: Use C++ exception handling.
5647         * rust-exp.y: Use C++ exception handling.
5648         * rs6000-tdep.c: Use C++ exception handling.
5649         * rs6000-aix-tdep.c: Use C++ exception handling.
5650         * riscv-tdep.c: Use C++ exception handling.
5651         * remote.c: Use C++ exception handling.
5652         * remote-fileio.c: Use C++ exception handling.
5653         * record-full.c: Use C++ exception handling.
5654         * record-btrace.c: Use C++ exception handling.
5655         * python/python.c: Use C++ exception handling.
5656         * python/py-value.c: Use C++ exception handling.
5657         * python/py-utils.c: Use C++ exception handling.
5658         * python/py-unwind.c: Use C++ exception handling.
5659         * python/py-type.c: Use C++ exception handling.
5660         * python/py-symbol.c: Use C++ exception handling.
5661         * python/py-record.c: Use C++ exception handling.
5662         * python/py-record-btrace.c: Use C++ exception handling.
5663         * python/py-progspace.c: Use C++ exception handling.
5664         * python/py-prettyprint.c: Use C++ exception handling.
5665         * python/py-param.c: Use C++ exception handling.
5666         * python/py-objfile.c: Use C++ exception handling.
5667         * python/py-linetable.c: Use C++ exception handling.
5668         * python/py-lazy-string.c: Use C++ exception handling.
5669         * python/py-infthread.c: Use C++ exception handling.
5670         * python/py-inferior.c: Use C++ exception handling.
5671         * python/py-gdb-readline.c: Use C++ exception handling.
5672         * python/py-framefilter.c: Use C++ exception handling.
5673         * python/py-frame.c: Use C++ exception handling.
5674         * python/py-finishbreakpoint.c: Use C++ exception handling.
5675         * python/py-cmd.c: Use C++ exception handling.
5676         * python/py-breakpoint.c: Use C++ exception handling.
5677         * python/py-arch.c: Use C++ exception handling.
5678         * printcmd.c: Use C++ exception handling.
5679         * ppc-linux-tdep.c: Use C++ exception handling.
5680         * parse.c: Use C++ exception handling.
5681         * p-valprint.c: Use C++ exception handling.
5682         * objc-lang.c: Use C++ exception handling.
5683         * mi/mi-main.c: Use C++ exception handling.
5684         * mi/mi-interp.c: Use C++ exception handling.
5685         * mi/mi-cmd-stack.c: Use C++ exception handling.
5686         * mi/mi-cmd-break.c: Use C++ exception handling.
5687         * main.c: Use C++ exception handling.
5688         * linux-thread-db.c: Use C++ exception handling.
5689         * linux-tdep.c: Use C++ exception handling.
5690         * linux-nat.c: Use C++ exception handling.
5691         * linux-fork.c: Use C++ exception handling.
5692         * linespec.c: Use C++ exception handling.
5693         * language.c: Use C++ exception handling.
5694         * jit.c: Use C++ exception handling.
5695         * infrun.c: Use C++ exception handling.
5696         * infcmd.c: Use C++ exception handling.
5697         * infcall.c: Use C++ exception handling.
5698         * inf-loop.c: Use C++ exception handling.
5699         * i386-tdep.c: Use C++ exception handling.
5700         * i386-linux-tdep.c: Use C++ exception handling.
5701         * guile/scm-value.c: Use C++ exception handling.
5702         * guile/scm-type.c: Use C++ exception handling.
5703         * guile/scm-symtab.c: Use C++ exception handling.
5704         * guile/scm-symbol.c: Use C++ exception handling.
5705         * guile/scm-pretty-print.c: Use C++ exception handling.
5706         * guile/scm-ports.c: Use C++ exception handling.
5707         * guile/scm-param.c: Use C++ exception handling.
5708         * guile/scm-math.c: Use C++ exception handling.
5709         * guile/scm-lazy-string.c: Use C++ exception handling.
5710         * guile/scm-frame.c: Use C++ exception handling.
5711         * guile/scm-disasm.c: Use C++ exception handling.
5712         * guile/scm-cmd.c: Use C++ exception handling.
5713         * guile/scm-breakpoint.c: Use C++ exception handling.
5714         * guile/scm-block.c: Use C++ exception handling.
5715         * guile/guile-internal.h: Use C++ exception handling.
5716         * gnu-v3-abi.c: Use C++ exception handling.
5717         * gdbtypes.c: Use C++ exception handling.
5718         * frame.c: Use C++ exception handling.
5719         * frame-unwind.c: Use C++ exception handling.
5720         * fbsd-tdep.c: Use C++ exception handling.
5721         * f-valprint.c: Use C++ exception handling.
5722         * exec.c: Use C++ exception handling.
5723         * event-top.c: Use C++ exception handling.
5724         * event-loop.c: Use C++ exception handling.
5725         * eval.c: Use C++ exception handling.
5726         * dwarf2read.c: Use C++ exception handling.
5727         * dwarf2loc.c: Use C++ exception handling.
5728         * dwarf2-frame.c: Use C++ exception handling.
5729         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5730         * dwarf-index-write.c: Use C++ exception handling.
5731         * dwarf-index-cache.c: Use C++ exception handling.
5732         * dtrace-probe.c: Use C++ exception handling.
5733         * disasm-selftests.c: Use C++ exception handling.
5734         * darwin-nat.c: Use C++ exception handling.
5735         * cp-valprint.c: Use C++ exception handling.
5736         * cp-support.c: Use C++ exception handling.
5737         * cp-abi.c: Use C++ exception handling.
5738         * corelow.c: Use C++ exception handling.
5739         * completer.c: Use C++ exception handling.
5740         * compile/compile-object-run.c: Use C++ exception handling.
5741         * compile/compile-object-load.c: Use C++ exception handling.
5742         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5743         * compile/compile-c-symbols.c: Use C++ exception handling.
5744         * common/selftest.c: Use C++ exception handling.
5745         * common/new-op.c: Use C++ exception handling.
5746         * cli/cli-script.c: Use C++ exception handling.
5747         * cli/cli-interp.c: Use C++ exception handling.
5748         * cli/cli-cmds.c: Use C++ exception handling.
5749         * c-varobj.c: Use C++ exception handling.
5750         * btrace.c: Use C++ exception handling.
5751         * breakpoint.c: Use C++ exception handling.
5752         * break-catch-throw.c: Use C++ exception handling.
5753         * arch-utils.c: Use C++ exception handling.
5754         * amd64-tdep.c: Use C++ exception handling.
5755         * ada-valprint.c: Use C++ exception handling.
5756         * ada-typeprint.c: Use C++ exception handling.
5757         * ada-lang.c: Use C++ exception handling.
5758         * aarch64-tdep.c: Use C++ exception handling.
5759
5760 2019-04-08  Tom Tromey  <tom@tromey.com>
5761
5762         * xml-support.c (gdb_xml_parser::parse): Update.
5763         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5764         * value.c (show_convenience): Update.
5765         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5766         (test_parse_flags_qcs): Update.
5767         * thread.c (thr_try_catch_cmd): Update.
5768         * target.c (target_translate_tls_address): Update.
5769         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5770         (info_frame_command_core, frame_apply_command_count): Update.
5771         * rust-exp.y (rust_lex_exception_test): Update.
5772         * riscv-tdep.c (riscv_print_one_register_info): Update.
5773         * remote.c (remote_target::enable_btrace): Update.
5774         * record-btrace.c (record_btrace_enable_warn): Update.
5775         * python/py-utils.c (gdbpy_convert_exception): Update.
5776         * printcmd.c (do_one_display, print_variable_and_value): Update.
5777         * mi/mi-main.c (mi_print_exception): Update.
5778         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5779         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5780         * linux-nat.c (linux_nat_target::attach): Update.
5781         * linux-fork.c (class scoped_switch_fork_info): Update.
5782         * infrun.c (displaced_step_prepare): Update.
5783         * infcall.c (call_function_by_hand_dummy): Update.
5784         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5785         * gnu-v3-abi.c (print_one_vtable): Update.
5786         * frame.c (get_prev_frame_always): Update.
5787         * f-valprint.c (info_common_command_for_block): Update.
5788         * exec.c (try_open_exec_file): Update.
5789         * exceptions.c (print_exception, exception_print)
5790         (exception_fprintf, exception_print_same): Update.
5791         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5792         * dwarf-index-cache.c (index_cache::store)
5793         (index_cache::lookup_gdb_index): Update.
5794         * darwin-nat.c (maybe_cache_shell): Update.
5795         * cp-valprint.c (cp_print_value_fields): Update.
5796         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5797         (gcc_cplus_symbol_address): Update.
5798         * compile/compile-c-symbols.c (gcc_convert_symbol)
5799         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5800         * common/selftest.c: Update.
5801         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5802         a std::string.
5803         (exception_try_scope_entry, exception_try_scope_exit): Don't
5804         declare.
5805         (struct exception_try_scope): Remove.
5806         (TRY): Don't use exception_try_scope.
5807         (struct gdb_exception): Add constructor, operator=.
5808         <what>: New method.
5809         (struct gdb_exception_RETURN_MASK_ALL)
5810         (struct gdb_exception_RETURN_MASK_ERROR)
5811         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5812         (struct gdb_quit_bad_alloc): Update.
5813         * common/common-exceptions.c (exception_none): Change
5814         initializer.
5815         (struct catcher) <state, exception>: Initialize inline.
5816         <prev>: Remove member.
5817         (current_catcher): Remove.
5818         (catchers): New global.
5819         (exceptions_state_mc_init): Simplify.
5820         (catcher_pop): Remove.
5821         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5822         (try_scope_depth, exception_try_scope_entry)
5823         (exception_try_scope_exit): Remove.
5824         (throw_exception_sjlj): Update.
5825         (exception_messages, exception_messages_size): Remove.
5826         (throw_it): Simplify.
5827         (gdb_exception_sliced_copy): Remove.
5828         (throw_exception_cxx): Update.
5829         * cli/cli-script.c (script_from_file): Update.
5830         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5831         Update.
5832         * ada-valprint.c (ada_val_print): Update.
5833         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5834         (create_excep_cond_exprs): Update.
5835
5836 2019-04-08  Tom Tromey  <tom@tromey.com>
5837
5838         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5839         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5840         (TRY, CATCH, END_CATCH): Remove some definitions.
5841         * common/common-exceptions.c: Don't use GDB_XCPT.
5842         (catcher_list_size): Remove.
5843         (throw_exception, throw_it): Simplify.
5844
5845 2019-04-05  Tom Tromey  <tom@tromey.com>
5846
5847         Revert the header-sorting patch.
5848         * ft32-tdep.c: Revert.
5849         * frv-tdep.c: Revert.
5850         * frv-linux-tdep.c: Revert.
5851         * frame.c: Revert.
5852         * frame-unwind.c: Revert.
5853         * frame-base.c: Revert.
5854         * fork-child.c: Revert.
5855         * findvar.c: Revert.
5856         * findcmd.c: Revert.
5857         * filesystem.c: Revert.
5858         * filename-seen-cache.h: Revert.
5859         * filename-seen-cache.c: Revert.
5860         * fbsd-tdep.c: Revert.
5861         * fbsd-nat.h: Revert.
5862         * fbsd-nat.c: Revert.
5863         * f-valprint.c: Revert.
5864         * f-typeprint.c: Revert.
5865         * f-lang.c: Revert.
5866         * extension.h: Revert.
5867         * extension.c: Revert.
5868         * extension-priv.h: Revert.
5869         * expprint.c: Revert.
5870         * exec.h: Revert.
5871         * exec.c: Revert.
5872         * exceptions.c: Revert.
5873         * event-top.c: Revert.
5874         * event-loop.c: Revert.
5875         * eval.c: Revert.
5876         * elfread.c: Revert.
5877         * dwarf2read.h: Revert.
5878         * dwarf2read.c: Revert.
5879         * dwarf2loc.c: Revert.
5880         * dwarf2expr.h: Revert.
5881         * dwarf2expr.c: Revert.
5882         * dwarf2-frame.c: Revert.
5883         * dwarf2-frame-tailcall.c: Revert.
5884         * dwarf-index-write.h: Revert.
5885         * dwarf-index-write.c: Revert.
5886         * dwarf-index-common.c: Revert.
5887         * dwarf-index-cache.h: Revert.
5888         * dwarf-index-cache.c: Revert.
5889         * dummy-frame.c: Revert.
5890         * dtrace-probe.c: Revert.
5891         * disasm.h: Revert.
5892         * disasm.c: Revert.
5893         * disasm-selftests.c: Revert.
5894         * dictionary.c: Revert.
5895         * dicos-tdep.c: Revert.
5896         * demangle.c: Revert.
5897         * dcache.h: Revert.
5898         * dcache.c: Revert.
5899         * darwin-nat.h: Revert.
5900         * darwin-nat.c: Revert.
5901         * darwin-nat-info.c: Revert.
5902         * d-valprint.c: Revert.
5903         * d-namespace.c: Revert.
5904         * d-lang.c: Revert.
5905         * ctf.c: Revert.
5906         * csky-tdep.c: Revert.
5907         * csky-linux-tdep.c: Revert.
5908         * cris-tdep.c: Revert.
5909         * cris-linux-tdep.c: Revert.
5910         * cp-valprint.c: Revert.
5911         * cp-support.c: Revert.
5912         * cp-namespace.c: Revert.
5913         * cp-abi.c: Revert.
5914         * corelow.c: Revert.
5915         * corefile.c: Revert.
5916         * continuations.c: Revert.
5917         * completer.h: Revert.
5918         * completer.c: Revert.
5919         * complaints.c: Revert.
5920         * coffread.c: Revert.
5921         * coff-pe-read.c: Revert.
5922         * cli-out.h: Revert.
5923         * cli-out.c: Revert.
5924         * charset.c: Revert.
5925         * c-varobj.c: Revert.
5926         * c-valprint.c: Revert.
5927         * c-typeprint.c: Revert.
5928         * c-lang.c: Revert.
5929         * buildsym.c: Revert.
5930         * buildsym-legacy.c: Revert.
5931         * build-id.h: Revert.
5932         * build-id.c: Revert.
5933         * btrace.c: Revert.
5934         * bsd-uthread.c: Revert.
5935         * breakpoint.h: Revert.
5936         * breakpoint.c: Revert.
5937         * break-catch-throw.c: Revert.
5938         * break-catch-syscall.c: Revert.
5939         * break-catch-sig.c: Revert.
5940         * blockframe.c: Revert.
5941         * block.c: Revert.
5942         * bfin-tdep.c: Revert.
5943         * bfin-linux-tdep.c: Revert.
5944         * bfd-target.c: Revert.
5945         * bcache.c: Revert.
5946         * ax-general.c: Revert.
5947         * ax-gdb.h: Revert.
5948         * ax-gdb.c: Revert.
5949         * avr-tdep.c: Revert.
5950         * auxv.c: Revert.
5951         * auto-load.c: Revert.
5952         * arm-wince-tdep.c: Revert.
5953         * arm-tdep.c: Revert.
5954         * arm-symbian-tdep.c: Revert.
5955         * arm-pikeos-tdep.c: Revert.
5956         * arm-obsd-tdep.c: Revert.
5957         * arm-nbsd-tdep.c: Revert.
5958         * arm-nbsd-nat.c: Revert.
5959         * arm-linux-tdep.c: Revert.
5960         * arm-linux-nat.c: Revert.
5961         * arm-fbsd-tdep.c: Revert.
5962         * arm-fbsd-nat.c: Revert.
5963         * arm-bsd-tdep.c: Revert.
5964         * arch-utils.c: Revert.
5965         * arc-tdep.c: Revert.
5966         * arc-newlib-tdep.c: Revert.
5967         * annotate.h: Revert.
5968         * annotate.c: Revert.
5969         * amd64-windows-tdep.c: Revert.
5970         * amd64-windows-nat.c: Revert.
5971         * amd64-tdep.c: Revert.
5972         * amd64-sol2-tdep.c: Revert.
5973         * amd64-obsd-tdep.c: Revert.
5974         * amd64-obsd-nat.c: Revert.
5975         * amd64-nbsd-tdep.c: Revert.
5976         * amd64-nbsd-nat.c: Revert.
5977         * amd64-nat.c: Revert.
5978         * amd64-linux-tdep.c: Revert.
5979         * amd64-linux-nat.c: Revert.
5980         * amd64-fbsd-tdep.c: Revert.
5981         * amd64-fbsd-nat.c: Revert.
5982         * amd64-dicos-tdep.c: Revert.
5983         * amd64-darwin-tdep.c: Revert.
5984         * amd64-bsd-nat.c: Revert.
5985         * alpha-tdep.c: Revert.
5986         * alpha-obsd-tdep.c: Revert.
5987         * alpha-nbsd-tdep.c: Revert.
5988         * alpha-mdebug-tdep.c: Revert.
5989         * alpha-linux-tdep.c: Revert.
5990         * alpha-linux-nat.c: Revert.
5991         * alpha-bsd-tdep.c: Revert.
5992         * alpha-bsd-nat.c: Revert.
5993         * aix-thread.c: Revert.
5994         * agent.c: Revert.
5995         * addrmap.c: Revert.
5996         * ada-varobj.c: Revert.
5997         * ada-valprint.c: Revert.
5998         * ada-typeprint.c: Revert.
5999         * ada-tasks.c: Revert.
6000         * ada-lang.c: Revert.
6001         * aarch64-tdep.c: Revert.
6002         * aarch64-ravenscar-thread.c: Revert.
6003         * aarch64-newlib-tdep.c: Revert.
6004         * aarch64-linux-tdep.c: Revert.
6005         * aarch64-linux-nat.c: Revert.
6006         * aarch64-fbsd-tdep.c: Revert.
6007         * aarch64-fbsd-nat.c: Revert.
6008         * aarch32-linux-nat.c: Revert.
6009
6010 2019-04-05  Tom Tromey  <tom@tromey.com>
6011
6012         * ft32-tdep.c: Sort headers.
6013         * frv-tdep.c: Sort headers.
6014         * frv-linux-tdep.c: Sort headers.
6015         * frame.c: Sort headers.
6016         * frame-unwind.c: Sort headers.
6017         * frame-base.c: Sort headers.
6018         * fork-child.c: Sort headers.
6019         * findvar.c: Sort headers.
6020         * findcmd.c: Sort headers.
6021         * filesystem.c: Sort headers.
6022         * filename-seen-cache.h: Sort headers.
6023         * filename-seen-cache.c: Sort headers.
6024         * fbsd-tdep.c: Sort headers.
6025         * fbsd-nat.h: Sort headers.
6026         * fbsd-nat.c: Sort headers.
6027         * f-valprint.c: Sort headers.
6028         * f-typeprint.c: Sort headers.
6029         * f-lang.c: Sort headers.
6030         * extension.h: Sort headers.
6031         * extension.c: Sort headers.
6032         * extension-priv.h: Sort headers.
6033         * expprint.c: Sort headers.
6034         * exec.h: Sort headers.
6035         * exec.c: Sort headers.
6036         * exceptions.c: Sort headers.
6037         * event-top.c: Sort headers.
6038         * event-loop.c: Sort headers.
6039         * eval.c: Sort headers.
6040         * elfread.c: Sort headers.
6041         * dwarf2read.h: Sort headers.
6042         * dwarf2read.c: Sort headers.
6043         * dwarf2loc.c: Sort headers.
6044         * dwarf2expr.h: Sort headers.
6045         * dwarf2expr.c: Sort headers.
6046         * dwarf2-frame.c: Sort headers.
6047         * dwarf2-frame-tailcall.c: Sort headers.
6048         * dwarf-index-write.h: Sort headers.
6049         * dwarf-index-write.c: Sort headers.
6050         * dwarf-index-common.c: Sort headers.
6051         * dwarf-index-cache.h: Sort headers.
6052         * dwarf-index-cache.c: Sort headers.
6053         * dummy-frame.c: Sort headers.
6054         * dtrace-probe.c: Sort headers.
6055         * disasm.h: Sort headers.
6056         * disasm.c: Sort headers.
6057         * disasm-selftests.c: Sort headers.
6058         * dictionary.c: Sort headers.
6059         * dicos-tdep.c: Sort headers.
6060         * demangle.c: Sort headers.
6061         * dcache.h: Sort headers.
6062         * dcache.c: Sort headers.
6063         * darwin-nat.h: Sort headers.
6064         * darwin-nat.c: Sort headers.
6065         * darwin-nat-info.c: Sort headers.
6066         * d-valprint.c: Sort headers.
6067         * d-namespace.c: Sort headers.
6068         * d-lang.c: Sort headers.
6069         * ctf.c: Sort headers.
6070         * csky-tdep.c: Sort headers.
6071         * csky-linux-tdep.c: Sort headers.
6072         * cris-tdep.c: Sort headers.
6073         * cris-linux-tdep.c: Sort headers.
6074         * cp-valprint.c: Sort headers.
6075         * cp-support.c: Sort headers.
6076         * cp-namespace.c: Sort headers.
6077         * cp-abi.c: Sort headers.
6078         * corelow.c: Sort headers.
6079         * corefile.c: Sort headers.
6080         * continuations.c: Sort headers.
6081         * completer.h: Sort headers.
6082         * completer.c: Sort headers.
6083         * complaints.c: Sort headers.
6084         * coffread.c: Sort headers.
6085         * coff-pe-read.c: Sort headers.
6086         * cli-out.h: Sort headers.
6087         * cli-out.c: Sort headers.
6088         * charset.c: Sort headers.
6089         * c-varobj.c: Sort headers.
6090         * c-valprint.c: Sort headers.
6091         * c-typeprint.c: Sort headers.
6092         * c-lang.c: Sort headers.
6093         * buildsym.c: Sort headers.
6094         * buildsym-legacy.c: Sort headers.
6095         * build-id.h: Sort headers.
6096         * build-id.c: Sort headers.
6097         * btrace.c: Sort headers.
6098         * bsd-uthread.c: Sort headers.
6099         * breakpoint.h: Sort headers.
6100         * breakpoint.c: Sort headers.
6101         * break-catch-throw.c: Sort headers.
6102         * break-catch-syscall.c: Sort headers.
6103         * break-catch-sig.c: Sort headers.
6104         * blockframe.c: Sort headers.
6105         * block.c: Sort headers.
6106         * bfin-tdep.c: Sort headers.
6107         * bfin-linux-tdep.c: Sort headers.
6108         * bfd-target.c: Sort headers.
6109         * bcache.c: Sort headers.
6110         * ax-general.c: Sort headers.
6111         * ax-gdb.h: Sort headers.
6112         * ax-gdb.c: Sort headers.
6113         * avr-tdep.c: Sort headers.
6114         * auxv.c: Sort headers.
6115         * auto-load.c: Sort headers.
6116         * arm-wince-tdep.c: Sort headers.
6117         * arm-tdep.c: Sort headers.
6118         * arm-symbian-tdep.c: Sort headers.
6119         * arm-pikeos-tdep.c: Sort headers.
6120         * arm-obsd-tdep.c: Sort headers.
6121         * arm-nbsd-tdep.c: Sort headers.
6122         * arm-nbsd-nat.c: Sort headers.
6123         * arm-linux-tdep.c: Sort headers.
6124         * arm-linux-nat.c: Sort headers.
6125         * arm-fbsd-tdep.c: Sort headers.
6126         * arm-fbsd-nat.c: Sort headers.
6127         * arm-bsd-tdep.c: Sort headers.
6128         * arch-utils.c: Sort headers.
6129         * arc-tdep.c: Sort headers.
6130         * arc-newlib-tdep.c: Sort headers.
6131         * annotate.h: Sort headers.
6132         * annotate.c: Sort headers.
6133         * amd64-windows-tdep.c: Sort headers.
6134         * amd64-windows-nat.c: Sort headers.
6135         * amd64-tdep.c: Sort headers.
6136         * amd64-sol2-tdep.c: Sort headers.
6137         * amd64-obsd-tdep.c: Sort headers.
6138         * amd64-obsd-nat.c: Sort headers.
6139         * amd64-nbsd-tdep.c: Sort headers.
6140         * amd64-nbsd-nat.c: Sort headers.
6141         * amd64-nat.c: Sort headers.
6142         * amd64-linux-tdep.c: Sort headers.
6143         * amd64-linux-nat.c: Sort headers.
6144         * amd64-fbsd-tdep.c: Sort headers.
6145         * amd64-fbsd-nat.c: Sort headers.
6146         * amd64-dicos-tdep.c: Sort headers.
6147         * amd64-darwin-tdep.c: Sort headers.
6148         * amd64-bsd-nat.c: Sort headers.
6149         * alpha-tdep.c: Sort headers.
6150         * alpha-obsd-tdep.c: Sort headers.
6151         * alpha-nbsd-tdep.c: Sort headers.
6152         * alpha-mdebug-tdep.c: Sort headers.
6153         * alpha-linux-tdep.c: Sort headers.
6154         * alpha-linux-nat.c: Sort headers.
6155         * alpha-bsd-tdep.c: Sort headers.
6156         * alpha-bsd-nat.c: Sort headers.
6157         * aix-thread.c: Sort headers.
6158         * agent.c: Sort headers.
6159         * addrmap.c: Sort headers.
6160         * ada-varobj.c: Sort headers.
6161         * ada-valprint.c: Sort headers.
6162         * ada-typeprint.c: Sort headers.
6163         * ada-tasks.c: Sort headers.
6164         * ada-lang.c: Sort headers.
6165         * aarch64-tdep.c: Sort headers.
6166         * aarch64-ravenscar-thread.c: Sort headers.
6167         * aarch64-newlib-tdep.c: Sort headers.
6168         * aarch64-linux-tdep.c: Sort headers.
6169         * aarch64-linux-nat.c: Sort headers.
6170         * aarch64-fbsd-tdep.c: Sort headers.
6171         * aarch64-fbsd-nat.c: Sort headers.
6172         * aarch32-linux-nat.c: Sort headers.
6173
6174 2019-04-04  Tom Tromey  <tom@tromey.com>
6175
6176         * varobj.c (varobj_create): Update.
6177         * rust-exp.y (struct rust_parser) <update_innermost_block,
6178         lookup_symbol>: New methods.
6179         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6180         Rename.
6181         (rust_parser::rust_lookup_type)
6182         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6183         * printcmd.c (display_command, do_one_display): Update.
6184         * parser-defs.h (struct parser_state) <parser_state>: Add
6185         "tracker" parameter.
6186         (block_tracker): New member.
6187         (class innermost_block_tracker) <innermost_block_tracker>: Add
6188         "types" parameter.
6189         <reset>: Remove method.
6190         (innermost_block): Don't declare.
6191         (null_post_parser): Update.
6192         * parse.c (innermost_block): Remove global.
6193         (write_dollar_variable): Update.
6194         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6195         Remove "tracker_types" parameter.
6196         (parse_expression): Add "tracker" parameter.
6197         (parse_expression_for_completion): Update.
6198         (null_post_parser): Add "tracker" parameter.
6199         * p-exp.y: Update rules.
6200         * m2-exp.y: Update rules.
6201         * language.h (struct language_defn) <la_post_parser>: Add
6202         "tracker" parameter.
6203         * go-exp.y: Update rules.
6204         * f-exp.y: Update rules.
6205         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6206         parameter.
6207         * d-exp.y: Update rules.
6208         * c-exp.y: Update rules.
6209         * breakpoint.c (set_breakpoint_condition): Create an
6210         innermost_block_tracker.
6211         (watch_command_1): Likewise.
6212         * ada-lang.c (resolve): Add "tracker" parameter.
6213         (resolve_subexp): Likewise.
6214         * ada-exp.y (write_var_from_sym): Update.
6215
6216 2019-04-04  Tom Tromey  <tom@tromey.com>
6217
6218         * type-stack.h: New file.
6219         * type-stack.c: New file.
6220         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6221         type-stack.h.
6222         (insert_into_type_stack, insert_type, push_type, push_type_int)
6223         (insert_type_address_space, pop_type, pop_type_int)
6224         (pop_typelist, pop_type_stack, append_type_stack)
6225         (push_type_stack, get_type_stack, push_typelist)
6226         (follow_type_instance_flags, follow_types): Don't declare.
6227         * parse.c (type_stack): Remove global.
6228         (parse_exp_in_context): Update.
6229         (insert_into_type_stack, insert_type, push_type, push_type_int)
6230         (insert_type_address_space, pop_type, pop_type_int)
6231         (pop_typelist, pop_type_stack, append_type_stack)
6232         (push_type_stack, get_type_stack, push_typelist)
6233         (follow_type_instance_flags, follow_types): Remove (moved to
6234         type-stack.c).
6235         * f-exp.y (type_stack): New global.
6236         Update rules.
6237         (push_kind_type, f_parse): Update.
6238         * d-exp.y (type_stack): New global.
6239         Update rules.
6240         (d_parse): Update.
6241         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6242         Update rules.
6243         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6244         (HFILES_NO_SRCDIR): Add type-stack.h.
6245
6246 2019-04-04  Tom Tromey  <tom@tromey.com>
6247
6248         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6249         (rust_parser::convert_ast_to_expression, rust_parse)
6250         (rust_lex_test_completion, rust_lex_tests): Update.
6251         * parser-defs.h (struct expr_completion_state): New.
6252         (struct parser_state) <parser_state>: Add completion parameter.
6253         <mark_struct_expression, mark_completion_tag>: New methods.
6254         <parse_completion, m_completion_state>: New members.
6255         (prefixify_expression, null_post_parser): Update.
6256         (mark_struct_expression, mark_completion_tag): Don't declare.
6257         * parse.c (parse_completion, expout_last_struct)
6258         (expout_tag_completion_type, expout_completion_name): Remove
6259         globals.
6260         (parser_state::mark_struct_expression)
6261         (parser_state::mark_completion_tag): Now methods.
6262         (prefixify_expression): Add last_struct parameter.
6263         (prefixify_subexp): Likewise.
6264         (parse_exp_1): Update.
6265         (parse_exp_in_context): Add cstate parameter.  Update.
6266         (parse_expression_for_completion): Create an
6267         expr_completion_state.
6268         (null_post_parser): Add "completion" parameter.
6269         * p-exp.y: Update rules.
6270         (yylex): Update.
6271         * language.h (struct language_defn) <la_post_parser>: Add
6272         "completing" parameter.
6273         * go-exp.y: Update rules.
6274         (lex_one_token): Update.
6275         * expression.h (parse_completion): Don't declare.
6276         * d-exp.y: Update rules.
6277         (lex_one_token): Update rules.
6278         * c-exp.y: Update rules.
6279         (lex_one_token): Update.
6280         * ada-lang.c (resolve): Add "parse_completion" parameter.
6281         (resolve_subexp): Likewise.
6282         (ada_resolve_function): Likewise.
6283
6284 2019-04-04  Tom Tromey  <tom@tromey.com>
6285
6286         * parser-defs.h (struct parser_state) <start_arglist,
6287         end_arglist>: New methods.
6288         <arglist_len, m_funcall_chain>: New members.
6289         (arglist_len, start_arglist, end_arglist): Don't declare.
6290         * parse.c (arglist_len, funcall_chain): Remove global.
6291         (start_arglist, end_arglist): Remove functions.
6292         (parse_exp_in_context): Update.
6293         * p-exp.y: Update rules.
6294         * m2-exp.y: Update rules.
6295         * go-exp.y: Update rules.
6296         * f-exp.y: Update rules.
6297         * d-exp.y: Update rules.
6298         * c-exp.y: Update rules.
6299
6300 2019-04-04  Tom Tromey  <tom@tromey.com>
6301
6302         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6303         lex_operator, push_back>: New methods.
6304         Update all rules.
6305         (rust_parser::lex_hex, lex_escape): Rename and update.
6306         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6307         (rust_parser::lex_operator): Rename and update.
6308         (rust_parser::lex_number, rustyylex, rustyyerror)
6309         (rust_lex_test_init, rust_lex_test_sequence)
6310         (rust_lex_test_push_back, rust_lex_tests): Update.
6311         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6312         parameter.
6313         <lexptr, prev_lexptr>: New members.
6314         (lexptr, prev_lexptr): Don't declare.
6315         * parse.c (lexptr, prev_lexptr): Remove globals.
6316         (parse_exp_in_context): Update.
6317         * p-exp.y (yylex, yyerror): Update.
6318         * m2-exp.y (parse_number, yylex, yyerror): Update.
6319         * go-exp.y (lex_one_token, yyerror): Update.
6320         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6321         * d-exp.y (lex_one_token, yyerror): Update.
6322         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6323         (lex_one_token, yyerror): Update.
6324         * ada-lex.l (YY_INPUT): Update.
6325         (rewind_to_char): Update.
6326         * ada-exp.y (yyerror): Update.
6327
6328 2019-04-04  Tom Tromey  <tom@tromey.com>
6329
6330         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6331         * parser-defs.h (struct parser_state) <parser_state>: Add new
6332         parameter.
6333         <comma_terminates>: New member.
6334         (comma_terminates): Don't declare global.
6335         * parse.c (comma_terminates): Remove global.
6336         (parse_exp_in_context): Update.
6337         * p-exp.y (yylex): Update.
6338         * m2-exp.y (yylex): Update.
6339         * go-exp.y (lex_one_token): Update.
6340         * f-exp.y (yylex): Update.
6341         * d-exp.y (lex_one_token): Update.
6342         * c-exp.y (lex_one_token): Update.
6343         * ada-lex.l: Update.
6344
6345 2019-04-04  Tom Tromey  <tom@tromey.com>
6346
6347         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6348         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6349         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6350         * parser-defs.h (paren_depth): Don't declare.
6351         * parse.c (paren_depth): Remove global.
6352         (parse_exp_in_context): Update.
6353         * p-exp.y (paren_depth): New global.
6354         (pascal_parse): Initialize it.
6355         * m2-exp.y (paren_depth): New global.
6356         (m2_parse): Initialize it.
6357         * go-exp.y (paren_depth): New global.
6358         (go_parse): Initialize it.
6359         * f-exp.y (paren_depth): New global.
6360         (f_parse): Initialize it.
6361         * d-exp.y (paren_depth): New global.
6362         (d_parse): Initialize it.
6363         * c-exp.y (paren_depth): New global.
6364         (c_parse): Initialize it.
6365         * ada-lex.l (paren_depth): New global.
6366         (lexer_init): Initialize it.
6367
6368 2019-04-04  Tom Tromey  <tom@tromey.com>
6369
6370         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6371         (rust_parser::convert_ast_to_type)
6372         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6373         * parser-defs.h (struct parser_state) <parser_state>: Add
6374         parameters.  Initialize new members.
6375         <expression_context_block, expression_context_pc>: New members.
6376         * parse.c (expression_context_block, expression_context_pc):
6377         Remove globals.
6378         (parse_exp_in_context): Update.
6379         * p-exp.y: Update all rules.
6380         (yylex): Update.
6381         * m2-exp.y: Update all rules.
6382         (yylex): Update.
6383         * go-exp.y (yylex): Update.
6384         * f-exp.y (yylex): Update.
6385         * d-exp.y: Update all rules.
6386         (yylex): Update.
6387         * c-exp.y: Update all rules.
6388         (lex_one_token, classify_name, yylex, c_parse): Update.
6389         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6390
6391 2019-04-04  Tom Tromey  <tom@tromey.com>
6392
6393         * gdbarch.h, gdbarch.c: Rebuild.
6394         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6395         * stap-probe.h:
6396         (struct stap_parse_info): Replace "parser_state" with
6397         "expr_builder".
6398         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6399         (parser_state): New class.
6400         * parse.c (expr_builder): Rename.
6401         (expr_builder::release): Rename.
6402         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6403         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6404         (write_exp_elt_longcst, write_exp_elt_floatcst)
6405         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6406         (write_exp_string_vector, write_exp_bitstring)
6407         (write_exp_msymbol, mark_struct_expression)
6408         (write_dollar_variable)
6409         (insert_type_address_space, increase_expout_size): Replace
6410         "parser_state" with "expr_builder".
6411         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6412         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6413         "parser_state" with "expr_builder".
6414
6415 2019-04-04  Tom Tromey  <tom@tromey.com>
6416
6417         * rust-exp.y: Replace "parse_language" with method call.
6418         * p-exp.y:
6419         (yylex): Replace "parse_language" with method call.
6420         * m2-exp.y:
6421         (yylex): Replace "parse_language" with method call.
6422         * go-exp.y (classify_name): Replace "parse_language" with method
6423         call.
6424         * f-exp.y (yylex): Replace "parse_language" with method call.
6425         * d-exp.y (lex_one_token): Replace "parse_language" with method
6426         call.
6427         * c-exp.y:
6428         (lex_one_token, classify_name, yylex): Replace "parse_language"
6429         with method call.
6430         * ada-exp.y (find_primitive_type, type_char)
6431         (type_system_address): Replace "parse_language" with method call.
6432
6433 2019-04-04  Tom Tromey  <tom@tromey.com>
6434
6435         * rust-exp.y: Replace "parse_gdbarch" with method call.
6436         * parse.c (write_dollar_variable, insert_type_address_space):
6437         Replace "parse_gdbarch" with method call.
6438         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6439         call.
6440         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6441         call.
6442         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6443         "parse_gdbarch" with method call.
6444         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6445         with method call.
6446         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6447         "parse_gdbarch" with method call.
6448         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6449         "parse_gdbarch" with method call.
6450         * c-exp.y (parse_type, parse_number, classify_name): Replace
6451         "parse_gdbarch" with method call.
6452         * ada-lex.l: Replace "parse_gdbarch" with method call.
6453         * ada-exp.y (parse_type, find_primitive_type, type_char)
6454         (type_system_address): Replace "parse_gdbarch" with method call.
6455
6456 2019-04-04  Tom Tromey  <tom@tromey.com>
6457
6458         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6459         * stap-probe.c (stap_parse_argument): Update.
6460         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6461         initial_size parameter.
6462         * rust-exp.y (rust_lex_tests): Update.
6463         * parse.c (parser_state): Update.
6464         (parse_exp_in_context): Update.
6465         * parser-defs.h (struct parser_state) <parser_state>: Remove
6466         "initial_size" parameter.
6467
6468 2019-04-04  Tom Tromey  <tom@tromey.com>
6469
6470         * parser-defs.h (increase_expout_size): Don't declare.
6471         * parse.c (increase_expout_size): Now static.
6472
6473 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6474
6475         * gnu-nat.c (gnu_nat_target::wait): Fix
6476         target_waitstatus_to_string call.
6477
6478 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6479
6480         * eval.c (evaluate_subexp_standard): Handle internal functions
6481         during Fortran function call handling.
6482
6483 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6484
6485         * NEWS: Mention new internal functions.
6486         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6487         (read_base_type): Use dwarf2_init_complex_target_type.
6488         * value.c (creal_internal_fn): New function.
6489         (cimag_internal_fn): New function.
6490         (_initialize_values): Register new internal functions.
6491
6492 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6493
6494         * infrun.c (stop_all_threads): If debug_infrun, always
6495         trace the wait status after wait_one, using
6496         target_waitstatus_to_string and target_pid_to_str.
6497         (handle_inferior_event): Replace various trace of
6498         wait status kind by a single trace.
6499         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6500         wait status kind image by target_waitstatus_to_string.
6501         * target/waitstatus.c (target_waitstatus_to_string): Fix
6502         obsolete comment.
6503
6504 2019-04-01  Tom Tromey  <tromey@adacore.com>
6505
6506         PR symtab/23331:
6507         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6508
6509 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6510             Pedro Alves  <palves@redhat.com>
6511
6512         * top.c (quit_force): Call 'finalize_values'.
6513         * value.c (finalize_values): New function.
6514         * value.h (finalize_values): Declare.
6515
6516 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6517
6518         * NEWS: Announce $_gdb_major and $_gdb_minor.
6519
6520         * top.c (init_gdb_version_vars): New function.
6521         (gdb_init): Call init_gdb_version_vars.
6522
6523 2019-03-29  Tom Tromey  <tromey@adacore.com>
6524
6525         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6526         help text.  Remove dead code.
6527
6528 2019-03-29  Keith Seitz  <keiths@redhat.com>
6529
6530         From Siddhesh Poyarekar:
6531         * f-lang.h (f77_get_upperbound): Return LONGEST.
6532         (f77_get_lowerbound): Likewise.
6533         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6534         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6535         print them.
6536         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6537         plongest to format print it.
6538         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6539         (f77_get_upperbound): Likewise.
6540         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6541         LOWER_BOUND to LONGEST.
6542         (f77_create_arrayprint_offset_tbl): Likewise.
6543
6544 2019-03-29  Keith Seitz  <keiths@redhat.com>
6545
6546         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6547         %s/pulongest for TYPE_LENGTH instead of %d in format
6548         strings.
6549         * ada-typerint.c (ada_print_type): Likewise.
6550         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6551         * compile/compile-c-support.c (generate_register_struct): Likewise.
6552         * gdbtypes.c (recursive_dump_type): Likewise.
6553         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6554         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6555         instead of %d in format strings.
6556         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6557         to std::min to ULONGEST.
6558         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6559         instead of %d in format strings.
6560         * tracepoint.c (info_scope_command): Likewise.
6561         * typeprint.c (print_offset_data::update)
6562         (print_offset_data::finish): Likewise.
6563         * xtensa-tdep.c (xtensa_store_return_value)
6564         (xtensa_push_dummy_call): Likewise.
6565
6566 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6567
6568         * windows-nat.c (display_selector): Fixed format specifications
6569         for 64-bit Cygwin.
6570
6571 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6572
6573         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6574
6575 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6576
6577         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6578         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6579         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6580         (nios2_linux_init_abi): Install it.
6581
6582 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6583
6584         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6585
6586 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6587
6588         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6589
6590 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6591             Tom Tromey  <tromey@adacore.com>
6592
6593         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6594
6595 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6596
6597         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6598         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6599         method to compute the bounds of range types. Also print "[evaluated]"
6600         if the bounds' values come from a dynamic evaluation.
6601
6602 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6603
6604         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6605         whitespace when pretty printing is on.
6606
6607 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6608
6609         * ppc-linux-nat.c: Add include.
6610
6611 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6612
6613         * NEWS: Mention AArch64 Pointer Authentication.
6614
6615 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6616
6617         * arm-linux-nat.c: Add include.
6618
6619 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6620
6621         * source-cache.c (source_cache::get_source_lines): Re-read
6622         fullname after calling open_source_file.
6623
6624 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6625
6626         * NEWS: Mention TLS support for FreeBSD.
6627
6628 2019-03-25  Tom Tromey  <tromey@adacore.com>
6629
6630         * minsyms.c (BUNCH_SIZE): Update comment.
6631         (~minimal_symbol_reader): Remove old comment.
6632         (compact_minimal_symbols): Update comment.
6633         (minimal_symbol_reader::install): Remove old comment.  Update
6634         other comments.
6635
6636 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6637
6638         * s390-linux-nat.c: Add include.
6639
6640 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6641
6642         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6643         Call linux_get_hwcap.
6644         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6645         Likewise.
6646         (aarch64_linux_get_hwcap): Remove function.
6647         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6648         declaration.
6649         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6650         linux_get_hwcap.
6651         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6652         * linux-tdep.c (linux_get_hwcap): Add function.
6653         (linux_get_hwcap2): Likewise.
6654         * linux-tdep.h (linux_get_hwcap): Add declaration.
6655         (linux_get_hwcap2): Likewise.
6656         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6657         (ppc_linux_get_hwcap2): Likewise.
6658         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6659         linux_get_hwcap.
6660         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6661         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6662         (ppc_linux_nat_target::read_description): Likewise.
6663         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6664         * s390-linux-nat.c: Likewise.
6665         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6666
6667 2019-03-24  Tom Tromey  <tom@tromey.com>
6668
6669         * ada-lang.c (standard_lookup): Simplify initialization.
6670         (ada_lookup_symbol_nonlocal): Simplify return.
6671         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6672         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6673         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6674         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6675         initialization.
6676         * solib.c (solib_global_lookup): Simplify.
6677         * symtab.c (null_block_symbol): Remove.
6678         (symbol_cache_lookup): Simplify returns.
6679         (lookup_language_this): Simplify returns.
6680         (lookup_symbol_aux): Simplify return.
6681         (lookup_local_symbol): Simplify returns.
6682         (lookup_global_symbol_from_objfile): Simplify return.
6683         (lookup_symbol_in_objfile_symtabs)
6684         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6685         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6686         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6687         * cp-namespace.c (cp_lookup_bare_symbol)
6688         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6689         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6690         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6691         (cp_lookup_symbol_via_imports): Simplify initialization.
6692         (find_symbol_in_baseclass): Likewise.
6693         * symtab.h (null_block_symbol): Remove.
6694         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6695         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6696         (d_lookup_symbol_module): Likewise.
6697         (find_symbol_in_baseclass): Simplify initialization.
6698
6699 2019-03-24  Tom Tromey  <tom@tromey.com>
6700
6701         * expression.h: Don't include symtab.h.
6702         (struct block): Forward declare.
6703
6704 2019-03-24  Tom Tromey  <tom@tromey.com>
6705
6706         * c-exp.y (typebase): Remove casts.
6707         * gdbtypes.c (lookup_unsigned_typename, )
6708         (lookup_signed_typename): Remove cast.
6709         * eval.c (parse_to_comma_and_eval): Remove cast.
6710         * parse.c (write_dollar_variable): Remove cast.
6711         * block.h (struct block) <superblock>: Now const.
6712         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6713         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6714         (map_block): Make "block" const.
6715         * symfile.h (struct quick_symbol_functions)
6716         <map_matching_symbols>: Constify block argument to "callback".
6717         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6718         const.
6719         (find_pc_sect_compunit_symtab): Make "b" const.
6720         (find_symbol_at_address): Likewise.
6721         (search_symbols): Likewise.
6722         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6723         (dw2_debug_names_lookup_symbol): Likewise.
6724         (dw2_map_matching_symbols): Update.
6725         * p-valprint.c (pascal_val_print): Remove "block".
6726         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6727         (aux_add_nonlocal_symbols): Make "block" const.
6728         (resolve_subexp): Remove cast.
6729         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6730         const.
6731         (iterate_over_file_blocks): Likewise.
6732         * f-exp.y (%union) <bval>: Remove.
6733         * coffread.c (patch_opaque_types): Make "b" const.
6734         * spu-tdep.c (spu_catch_start): Make "block" const.
6735         * c-valprint.c (print_unpacked_pointer): Remove "block".
6736         * symmisc.c (dump_symtab_1): Make "b" const.
6737         (block_depth): Make "block" const.
6738         * d-exp.y (%union) <bval>: Remove.
6739         * cp-support.h (cp_lookup_rtti_type): Update.
6740         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6741         * psymtab.c (psym_lookup_symbol): Make "block" const.
6742         (maintenance_check_psymtabs): Make "b" const.
6743         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6744         (enumerate_locals, enumerate_args): Update.
6745         * python/py-symtab.c (stpy_global_block): Make "block" const.
6746         (stpy_static_block): Likewise.
6747         * inline-frame.c (block_starting_point_at): Make "new_block"
6748         const.
6749         * block.c (find_block_in_blockvector): Make return type const.
6750         (blockvector_for_pc_sect): Make "b" const.
6751         (find_block_in_blockvector): Make "b" const.
6752
6753 2019-03-23  Tom Tromey  <tom@tromey.com>
6754
6755         * varobj.c (varobj_create): Update.
6756         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6757         * printcmd.c (display_command, do_one_display): Don't reset
6758         innermost_block.
6759         * parser-defs.h (enum innermost_block_tracker_type): Move to
6760         expression.h.
6761         (innermost_block): Update comment.
6762         * parse.c (parse_exp_1): Add tracker_types parameter.
6763         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6764         tracker_types parameter.  Reset innermost_block.
6765         (parse_exp_in_context): Remove.
6766         (parse_expression_for_completion): Update.
6767         * objfiles.c (~objfile): Don't reset expression_context_block or
6768         innermost_block.
6769         * expression.h (enum innermost_block_tracker_type): Move from
6770         parser-defs.h.
6771         (parse_exp_1): Add tracker_types parameter.
6772         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6773         reset innermost_block.
6774
6775 2019-03-23  Tom Tromey  <tom@tromey.com>
6776
6777         * objfiles.h: Include bcache.h.
6778
6779 2019-03-23  Tom Tromey  <tom@tromey.com>
6780
6781         * linespec.c (get_current_search_block): Use
6782         scoped_restore_current_language.
6783         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6784
6785 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6786             Jiong Wang  <jiong.wang@arm.com>
6787
6788         * aarch64-linux-tdep.c
6789         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6790         section.
6791         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6792
6793 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6794             Jiong Wang  <jiong.wang@arm.com>
6795
6796         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6797         instructions.
6798         (aarch64_analyze_prologue_test): Add PACIASP test.
6799         (aarch64_prologue_prev_register): Unmask PC value.
6800
6801 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6802             Jiong Wang  <jiong.wang@arm.com>
6803
6804         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6805         (aarch64_dwarf2_prev_register): Unmask PC value.
6806         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6807         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6808         DW_CFA_AARCH64_negate_ra_state.
6809         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6810
6811 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6812             Jiong Wang  <jiong.wang@arm.com>
6813
6814         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6815         registers.
6816         (aarch64_pseudo_register_name): Likewise.
6817         (aarch64_pseudo_register_type): Likewise.
6818         (aarch64_pseudo_register_reggroup_p): Likewise.
6819         (aarch64_gdbarch_init): Add pauth registers.
6820         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6821         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6822         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6823         (struct gdbarch_tdep): Add regnum for ra_state.
6824
6825 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6826             Jiong Wang  <jiong.wang@arm.com>
6827
6828         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6829
6830 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6831             Jiong Wang  <jiong.wang@arm.com>
6832
6833         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6834         function.
6835         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6836         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6837         (aarch64_gdbarch_init): Add puth registers.
6838         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6839         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6840         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6841
6842 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6843             Jiong Wang  <jiong.wang@arm.com>
6844
6845         * aarch64-linux-nat.c
6846         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6847         * aarch64-linux-tdep.c
6848         (aarch64_linux_core_read_description): Likewise.
6849         (aarch64_linux_get_hwcap): New function.
6850         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6851         (aarch64_linux_get_hwcap): New declaration.
6852
6853 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6854             Jiong Wang  <jiong.wang@arm.com>
6855
6856         * aarch64-linux-nat.c
6857         (aarch64_linux_nat_target::read_description): Add pauth param.
6858         * aarch64-linux-tdep.c
6859         (aarch64_linux_core_read_description): Likewise.
6860         * aarch64-tdep.c (struct target_desc): Add in pauth.
6861         (aarch64_read_description): Add pauth param.
6862         (aarch64_gdbarch_init): Likewise.
6863         * aarch64-tdep.h (aarch64_read_description): Likewise.
6864         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6865         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6866         * features/Makefile: Add new files.
6867         * features/aarch64-pauth.c: New file.
6868         * features/aarch64-pauth.xml: New file.
6869
6870 2019-03-20  Tom Tromey  <tromey@adacore.com>
6871
6872         * infrun.c (handle_inferior_event): Rename from
6873         handle_inferior_event_1.  Create a scoped_value_mark.
6874         (handle_inferior_event): Remove.
6875
6876 2019-03-19  Tom Tromey  <tromey@adacore.com>
6877
6878         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6879         * infrun.h (print_stop_event): Add "displays" parameter.
6880         * infrun.c (print_stop_event): Add "displays" parameter.
6881
6882 2019-03-19  Pedro Alves  <palves@redhat.com>
6883
6884         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6885         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6886         to -1.  Fix TABs vs spaces.
6887         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6888         * tui/tui-out.h (tui_ui_out) Add intro comments.
6889         <m_line, m_start_of_line>: In-class initialize, and add describing
6890         comment.
6891
6892 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6893
6894         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6895         variable names.
6896         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6897
6898 2019-03-18  Pedro Alves  <palves@redhat.com>
6899             Eli Zaretskii <eliz@gnu.org>
6900
6901         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6902         m_line and m_start_of_line.
6903
6904 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6905
6906         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6907         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6908         it returns a newline.  This fixes a regression in TU mode, whereby
6909         the next line is output on the same screen line as the user input.
6910
6911 2019-03-18  Tom Tromey  <tromey@adacore.com>
6912
6913         * minsyms.c (minimal_symbol_reader::install): Remove call to
6914         obstack_blank.
6915
6916 2019-03-18  Pedro Alves  <palves@redhat.com>
6917
6918         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6919         New globals.
6920         (apply_style): New, factored out from ...
6921         (apply_ansi_escape): ... this.  Handle reverse video mode.
6922         (tui_set_reverse_mode): New function.
6923         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6924         * tui/tui-winsource.c (tui_show_source_line): Use
6925         tui_set_reverse_mode instead of setting A_STANDOUT.
6926         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6927         New setter methods.
6928
6929 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6930
6931         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6932         Handle tabs.
6933
6934 2019-03-18  Tom Tromey  <tromey@adacore.com>
6935
6936         * ada-lang.c (empty_array): Add "high" parameter.
6937         (ada_evaluate_subexp): Update.
6938
6939 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6940
6941         * unittests/string_view-selftests.c: Define
6942         _initialize_string_view_selftests unconditionally.
6943
6944 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6945
6946         PR gdb/24350
6947         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6948
6949 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6950
6951         PR gdb/24351
6952         * windows-nat.c (display_selector): Fix format specifiers.
6953
6954 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6955
6956         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6957         tui_refill_source_window instead of tui_refresh_win, to update the
6958         current execution line.  This fixes redisplay of the current line
6959         when stepping through the code with "next" or "step".
6960
6961 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6962
6963         * source-cache.c (source_cache::get_source_lines): Call
6964         find_source_lines to initialize s->nlines.  This fixes vertical
6965         scrolling of TUI source window when the DOWN arrow is pressed.
6966
6967 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6968
6969         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6970         linux-thread-db.c (_initialize_thread_db): Likewise.
6971
6972 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6973
6974         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6975         wclrtoeol in tui_show_source_line".  This reverts changes made in
6976         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6977
6978 2019-03-15  Tom Tromey  <tom@tromey.com>
6979
6980         * symtab.h (struct minimal_symbol): Derive from
6981         general_symbol_info.
6982         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6983         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6984         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6985         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6986         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6987         (MSYMBOL_SEARCH_NAME): Update.
6988         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6989         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6990         * minsyms.c (minimal_symbol_reader::record_full): Update.
6991
6992 2019-03-15  Tom Tromey  <tom@tromey.com>
6993
6994         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6995
6996 2019-03-15  Tom Tromey  <tom@tromey.com>
6997
6998         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6999         unique_xmalloc_ptr.
7000         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7001         Update.
7002         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7003         (build_minimal_symbol_hash_tables)
7004         (minimal_symbol_reader::install): Update.
7005
7006 2019-03-15  Tom Tromey  <tom@tromey.com>
7007
7008         * symtab.c (create_demangled_names_hash): Update.
7009         (symbol_set_names): Update.
7010         * objfiles.h (struct objfile_per_bfd_storage)
7011         <demangled_names_hash>: Now an htab_up.
7012         * objfiles.c (objfile_per_bfd_storage): Simplify.
7013
7014 2019-03-15  Tom Tromey  <tom@tromey.com>
7015
7016         * objfiles.h (struct objfile_per_bfd_storage): Declare
7017         destructor.
7018         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7019         New.
7020         (get_objfile_bfd_data): Use new.  Don't initialize
7021         language_of_main.
7022         (free_objfile_per_bfd_storage): Remove.
7023         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7024
7025 2019-03-15  Tom Tromey  <tom@tromey.com>
7026
7027         * symfile.c (reread_symbols): Update.
7028         * objfiles.c (objfile::objfile): Update.
7029         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7030         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7031         comment.
7032         (minimal_symbol_reader::install): Update.
7033         (terminate_minimal_symbol_table): Remove.
7034         * jit.c (jit_object_close_impl): Update.
7035
7036 2019-03-15  Tom Tromey  <tom@tromey.com>
7037
7038         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7039         initializations.
7040
7041 2019-03-15  Tom Tromey  <tom@tromey.com>
7042
7043         * objfiles.h (struct objfile_per_bfd_storage)
7044         <demangled_hash_languages>: Now a bitset.
7045         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7046         (lookup_minimal_symbol): Update.
7047
7048 2019-03-15  Tom Tromey  <tom@tromey.com>
7049
7050         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7051         Don't return the symbol.
7052         * coffread.c (record_minimal_symbol): Use record_full.
7053
7054 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7055
7056         The MS-Windows port of ncurses fails to switch to a color pair if
7057         one or both of the colors are the implicit default colors.  This
7058         change records the default colors when TUI is initialized, and
7059         then specifies them explicitly when a color pair uses the default
7060         colors.  This allows color styling in TUI mode on MS-Windows.
7061
7062         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7063         ncurses_norm_attr.
7064         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7065         colors in ncurses_norm_attr.
7066         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7067         "none", replace it with the default color recorded in
7068         ncurses_norm_attr.
7069
7070 2019-03-14  Tom Tromey  <tromey@adacore.com>
7071
7072         * source-cache.h (class source_cache) <get_source_lines>: Return
7073         std::string.
7074         * source-cache.c (source_cache::extract_lines): Handle case where
7075         first_pos==npos.  Return std::string.
7076         (source_cache::get_source_lines): Update.
7077
7078 2019-03-14  Tom Tromey  <tromey@adacore.com>
7079
7080         * NEWS: Add item for "style sources" commands.
7081         * source-cache.c (source_cache::get_source_lines): Check
7082         source_styling.
7083         * cli/cli-style.c (source_styling): New global.
7084         (_initialize_cli_style): Add "style sources" commands.
7085         (show_style_sources): New function.
7086         * cli/cli-style.h (source_styling): Declare.
7087
7088 2019-03-14  Pedro Alves  <palves@redhat.com>
7089             Tom Tromey  <tromey@adacore.com>
7090
7091         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7092         * tui/tui-winsource.c (tui_refill_source_window): New function,
7093         from...
7094         (tui_horizontal_source_scroll): ... here.  Move some logic.
7095         * cli/cli-style.c (set_style_enabled): Notify new observable.
7096         * tui/tui-hooks.c (tui_redisplay_source): New function.
7097         (tui_attach_detach_observers): Attach or detach
7098         tui_redisplay_source.
7099         * observable.h (source_styling_changed): New observable.
7100         * observable.c: Define source_styling_changed observable.
7101
7102 2019-03-13  Tom Tromey  <tromey@adacore.com>
7103
7104         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7105         (i386_gnu_nat_target::store_registers): Update.
7106         * target-debug.h (target_debug_print_std_string): New macro.
7107         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7108         * windows-tdep.c (display_one_tib): Update.
7109         * tui/tui-stack.c (tui_make_status_line): Update.
7110         * top.c (print_inferior_quit_action): Update.
7111         * thread.c (thr_try_catch_cmd): Update.
7112         (add_thread_with_info): Update.
7113         (thread_target_id_str): Update.
7114         (thr_try_catch_cmd): Update.
7115         (thread_command): Update.
7116         (thread_find_command): Update.
7117         * record-btrace.c (record_btrace_target::info_record)
7118         (record_btrace_resume_thread, record_btrace_target::resume)
7119         (record_btrace_cancel_resume, record_btrace_step_thread)
7120         (record_btrace_target::wait, record_btrace_target::wait)
7121         (record_btrace_target::wait, record_btrace_target::stop): Update.
7122         * progspace.c (print_program_space): Update.
7123         * process-stratum-target.c
7124         (process_stratum_target::thread_address_space): Update.
7125         * linux-fork.c (linux_fork_mourn_inferior)
7126         (detach_checkpoint_command, info_checkpoints_command)
7127         (linux_fork_context): Update.
7128         (linux_fork_detach): Update.
7129         (class scoped_switch_fork_info): Update.
7130         (delete_checkpoint_command): Update.
7131         * infrun.c (follow_fork_inferior): Update.
7132         (follow_fork_inferior): Update.
7133         (proceed_after_vfork_done): Update.
7134         (handle_vfork_child_exec_or_exit): Update.
7135         (follow_exec): Update.
7136         (displaced_step_prepare_throw): Update.
7137         (displaced_step_restore): Update.
7138         (start_step_over): Update.
7139         (resume_1): Update.
7140         (clear_proceed_status_thread): Update.
7141         (proceed): Update.
7142         (print_target_wait_results): Update.
7143         (do_target_wait): Update.
7144         (context_switch): Update.
7145         (stop_all_threads): Update.
7146         (restart_threads): Update.
7147         (finish_step_over): Update.
7148         (handle_signal_stop): Update.
7149         (switch_back_to_stepped_thread): Update.
7150         (keep_going_pass_signal): Update.
7151         (print_exited_reason): Update.
7152         (normal_stop): Update.
7153         * inferior.c (inferior_pid_to_str): Change return type.
7154         (print_selected_inferior): Update.
7155         (add_inferior): Update.
7156         (detach_inferior): Update.
7157         * dummy-frame.c (fprint_dummy_frames): Update.
7158         * dcache.c (dcache_info_1): Update.
7159         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7160         (btrace_fetch, btrace_clear): Update.
7161         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7162         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7163         type.
7164         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7165         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7166         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7167         * gdbarch.c, gdbarch.h: Rebuild.
7168         * gdbarch.sh (core_pid_to_str): Change return type.
7169         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7170         return type.
7171         (windows_nat_target::pid_to_str): Change return type.
7172         (windows_delete_thread): Update.
7173         (windows_nat_target::attach): Update.
7174         (windows_nat_target::files_info): Update.
7175         * target-delegates.c: Rebuild.
7176         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7177         return type.
7178         (sol_thread_target::pid_to_str): Change return type.
7179         * remote.c (class remote_target) <pid_to_str>: Change return
7180         type.
7181         (remote_target::pid_to_str): Change return type.
7182         (extended_remote_target::attach, remote_target::remote_stop_ns)
7183         (remote_target::remote_notif_remove_queued_reply)
7184         (remote_target::push_stop_reply, remote_target::disable_btrace):
7185         Update.
7186         (extended_remote_target::attach): Update.
7187         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7188         type.
7189         (gdbsim_target::pid_to_str): Change return type.
7190         * ravenscar-thread.c (struct ravenscar_thread_target)
7191         <pid_to_str>: Change return type.
7192         (ravenscar_thread_target::pid_to_str): Change return type.
7193         * procfs.c (class procfs_target) <pid_to_str>: Change return
7194         type.
7195         (procfs_target::pid_to_str): Change return type.
7196         (procfs_target::attach): Update.
7197         (procfs_target::detach): Update.
7198         (procfs_target::fetch_registers): Update.
7199         (procfs_target::store_registers): Update.
7200         (procfs_target::wait): Update.
7201         (procfs_target::files_info): Update.
7202         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7203         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7204         return type.
7205         (nto_procfs_target::pid_to_str): Change return type.
7206         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7207         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7208         return type.
7209         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7210         (exit_lwp): Update.
7211         (attach_proc_task_lwp_callback, get_detach_signal)
7212         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7213         (linux_nat_target::resume, wait_lwp, stop_callback)
7214         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7215         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7216         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7217         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7218         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7219         type.
7220         (inf_ptrace_target::attach): Update.
7221         (inf_ptrace_target::files_info): Update.
7222         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7223         type.
7224         (go32_nat_target::pid_to_str): Change return type.
7225         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7226         (gnu_nat_target::wait): Update.
7227         (gnu_nat_target::wait): Update.
7228         (gnu_nat_target::resume): Update.
7229         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7230         (fbsd_nat_target::wait): Update.
7231         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7232         type.
7233         (darwin_nat_target::attach): Update.
7234         * corelow.c (class core_target) <pid_to_str>: Change return type.
7235         (core_target::pid_to_str): Change return type.
7236         * target.c (normal_pid_to_str): Change return type.
7237         (default_pid_to_str): Likewise.
7238         (target_pid_to_str): Change return type.
7239         (target_translate_tls_address): Update.
7240         (target_announce_detach): Update.
7241         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7242         return type.
7243         (bsd_uthread_target::pid_to_str): Change return type.
7244         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7245         type.
7246         (bsd_kvm_target::pid_to_str): Change return type.
7247         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7248         return type.
7249         (aix_thread_target::pid_to_str): Change return type.
7250         * target.h (struct target_ops) <pid_to_str>: Change return type.
7251         (target_pid_to_str, normal_pid_to_str): Likewise.
7252         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7253         type.
7254         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7255         type.
7256         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7257         return type.
7258         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7259         type.
7260         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7261         type.
7262         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7263         return type.
7264
7265 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7266
7267         * NEWS: Mention that the new default MI version is 3.  Mention
7268         changes to the output of commands and events that deal with
7269         multi-location breakpoints.
7270         * breakpoint.c: Include "mi/mi-out.h".
7271         (print_one_breakpoint): Change output syntax if using MI version
7272         >= 3.
7273         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7274         New.
7275         (mi_multi_location_breakpoint_output_fixed): New.
7276         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7277         (mi_cmd_fix_multi_location_breakpoint_output): New.
7278         (mi_multi_location_breakpoint_output_fixed): New.
7279         * mi/mi-cmds.c (mi_cmds): Register command
7280         -fix-multi-location-breakpoint-output.
7281         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7282         interpreter "mi".
7283
7284 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7285
7286         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7287         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7288         instantiate mi_ui_out based on interpreter name.
7289         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7290         * mi/mi-main.c (mi_load_progress): Likewise.
7291
7292 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7293
7294         * NEWS: Combine separate "New targets" sections for 8.3.
7295
7296 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7297
7298         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7299         (ppcfbsd_init_abi): Install gdbarch
7300         "fetch_tls_load_module_address" and "get_thread_local_address"
7301         methods.
7302
7303 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7304
7305         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7306         (riscv_fbsd_init_abi): Install gdbarch
7307         "fetch_tls_load_module_address" and "get_thread_local_address"
7308         methods.
7309
7310 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7311
7312         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7313         (i386fbsd_init_abi): Install gdbarch
7314         "fetch_tls_load_module_address" and "get_thread_local_address"
7315         methods.
7316
7317 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7318
7319         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7320         (amd64fbsd_init_abi): Install gdbarch
7321         "fetch_tls_load_module_address" and "get_thread_local_address"
7322         methods.
7323
7324 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7325
7326         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7327         (struct fbsd_pspace_data): New type.
7328         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7329         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7330         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7331         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7332         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7333
7334 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7335
7336         * gdbtypes.c (lookup_struct_elt): New function.
7337         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7338         * gdbtypes.h (struct struct_elt): New type.
7339         (lookup_struct_elt): New prototype.
7340
7341 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7342
7343         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7344         remove disabled code block.
7345
7346 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7347
7348         * gdbarch.sh (get_thread_local_address): New method.
7349         * gdbarch.h, gdbarch.c: Regenerate.
7350         * target.c (target_translate_tls_address): Use
7351         gdbarch_get_thread_local_address if present instead of
7352         target::get_thread_local_address.
7353
7354 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7355
7356         * target.h (target::get_thread_local_address): Update comment.
7357
7358 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7359
7360         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7361         objfile->separate_debug_objfile_backlink if not NULL.
7362
7363 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7364
7365         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7366         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7367         (amd64bsd_store_inferior_registers): Likewise.
7368         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7369         Enable segment base registers.
7370         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7371         PT_GETFSBASE and PT_GETGSBASE.
7372         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7373         PT_SETGSBASE.
7374         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7375         segment base registers.
7376         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7377
7378 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7379
7380         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7381         Update calls to i386_target_description to add 'segments'
7382         parameter.
7383         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7384         add segment base registers.
7385         * arch/i386.c (i386_create_target_description): Add 'segments'
7386         parameter to enable segment base registers.
7387         * arch/i386.h (i386_create_target_description): Likewise.
7388         * features/i386/32bit-segments.xml: New file.
7389         * features/i386/32bit-segments.c: Generate.
7390         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7391         call to i386_target_description to add 'segments' parameter.
7392         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7393         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7394         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7395         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7396         if feature is present.
7397         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7398         Add 'segments' parameter to call to i386_target_description.
7399         (i386_target_description): Add 'segments' parameter to enable
7400         segment base registers.
7401         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7402         to call to i386_target_description.
7403         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7404         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7405         Define I386_NUM_REGS.
7406         (i386_target_description): Add 'segments' parameter to enable
7407         segment base registers.
7408
7409 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7410
7411         PR/24325
7412         * source-cache.c: #undef open and close, to avoid unresolved
7413         externals during linking.
7414
7415 2019-03-12  Tom Tromey  <tromey@adacore.com>
7416
7417         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7418         const.  Add initializers.
7419         (_initialize_remote): Don't initialize ptid globals.
7420
7421 2019-03-12  Pedro Alves  <palves@redhat.com>
7422
7423         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7424
7425 2019-03-12  Pedro Alves  <palves@redhat.com>
7426
7427         * cp-name-parser.y (main): Remove unused 'len' variable.
7428
7429 2019-03-12  Tom Tromey  <tromey@adacore.com>
7430
7431         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7432         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7433
7434 2019-03-12  Tom Tromey  <tromey@adacore.com>
7435
7436         * linux-nat.c (iterate_over_lwps): Update.
7437         (stop_callback): Remove parameter.
7438         (stop_wait_callback, detach_callback, resume_set_callback)
7439         (select_singlestep_lwp_callback, set_ignore_sigint)
7440         (status_callback, resumed_callback, resume_clear_callback)
7441         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7442         data parameter.
7443         (linux_nat_target::detach, linux_nat_target::resume)
7444         (linux_stop_and_wait_all_lwps, select_event_lwp)
7445         (linux_nat_filter_event, linux_nat_wait_1)
7446         (linux_nat_target::kill, linux_nat_target::stop)
7447         (linux_nat_target::stop): Update.
7448         (linux_nat_resume_callback): Change type.
7449         (resume_stopped_resumed_lwps, count_events_callback)
7450         (select_event_lwp_callback): Likewise.
7451         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7452         * arm-linux-nat.c (struct update_registers_data): Remove.
7453         (update_registers_callback): Change type.
7454         (arm_linux_insert_hw_breakpoint1): Update.
7455         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7456         parameter.
7457         (x86_linux_dr_set_addr): Update.
7458         (x86_linux_dr_set_control): Update.
7459         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7460         (iterate_over_lwps): Use gdb::function_view.
7461         * nat/aarch64-linux-hw-point.c (struct
7462         aarch64_dr_update_callback_param): Remove.
7463         (debug_reg_change_callback): Change type.
7464         (aarch64_notify_debug_reg_change): Update.
7465         * s390-linux-nat.c (s390_refresh_per_info): Update.
7466
7467 2019-03-11  Tom Tromey  <tromey@adacore.com>
7468
7469         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7470         redundant assignment to "this_cu".
7471
7472 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7473
7474         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7475
7476 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7477
7478         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7479         from...
7480         (rank_one_type): ... this.
7481
7482 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7483
7484         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7485         from...
7486         (rank_one_type): ... this.
7487
7488 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7489
7490         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7491         from...
7492         (rank_one_type): ... this.
7493
7494 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7495
7496         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7497         from...
7498         (rank_one_type): ... this.
7499
7500 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7501
7502         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7503         from...
7504         (rank_one_type): ... this.
7505
7506 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7507
7508         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7509         from...
7510         (rank_one_type): ... this.
7511
7512 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7513
7514         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7515         from...
7516         (rank_one_type): ... this.
7517
7518 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7519
7520         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7521         from...
7522         (rank_one_type): ... this.
7523
7524 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7525
7526         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7527         from...
7528         (rank_one_type): ... this.
7529
7530 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7531
7532         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7533         from...
7534         (rank_one_type): ... this.
7535
7536 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7537
7538         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7539         from...
7540         (rank_one_type): ... this.
7541
7542 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7543
7544         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7545         from...
7546         (rank_one_type): ... this.
7547
7548 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7549
7550         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7551         inferior-events' shows the example events.
7552
7553 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7554
7555         Support styling on native MS-Windows console
7556
7557         PR/24315
7558         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7559         on MS-Windows if $TERM is not defined.
7560
7561         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7562
7563         * posix-hdep.c (gdb_console_fputs):
7564         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7565         functions.
7566         * ui-file.h (gdb_console_fputs): Add prototype.
7567
7568         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7569         back to fputs only if the former returns zero.
7570
7571 2019-03-07  Tom Tromey  <tom@tromey.com>
7572
7573         * symmisc.c (print_symbol_bcache_statistics): Update.
7574         (print_objfile_statistics): Update.
7575         * symfile.c (allocate_symtab): Update.
7576         * stabsread.c: Don't include bcache.h.
7577         * psymtab.h (struct psymbol_bcache): Don't declare.
7578         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7579         (psymbol_bcache_init, psymbol_bcache_free)
7580         (psymbol_bcache_get_bcache): Don't declare.
7581         * psymtab.c (struct psymbol_bcache): Remove.
7582         (psymtab_storage::psymtab_storage): Update.
7583         (psymtab_storage::~psymtab_storage): Update.
7584         (psymbol_bcache_init, psymbol_bcache_free)
7585         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7586         (add_psymbol_to_bcache): Update.
7587         (allocate_psymtab): Update.
7588         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7589         macro_cache>: No longer pointers.
7590         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7591         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7592         * macrotab.c (macro_bcache): Update.
7593         * macroexp.c: Don't include bcache.h.
7594         * gdbtypes.c (check_types_worklist): Update.
7595         (types_deeply_equal): Remove TRY/CATCH.  Update.
7596         * elfread.c (elf_symtab_read): Update.
7597         * dwarf2read.c: Don't include bcache.h.
7598         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7599         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7600         (print_bcache_statistics, bcache_memory_used): Don't declare.
7601         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7602         methods.  Rename all data members.
7603         * bcache.c (struct bcache): Move to bcache.h.
7604         (bcache::expand_hash_table): Rename from expand_hash_table.
7605         (bcache): Remove.
7606         (bcache::insert): Rename from bcache_full.
7607         (bcache::compare): Rename from bcache_compare.
7608         (bcache_xmalloc): Remove.
7609         (bcache::~bcache): Rename from bcache_xfree.
7610         (bcache::print_statistics): Rename from print_bcache_statistics.
7611         (bcache::memory_used): Rename from bcache_memory_used.
7612
7613 2019-03-07  Pedro Alves  <palves@redhat.com>
7614
7615         * infrun.c (normal_stop): Also check for
7616         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7617
7618 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7619
7620         * f-lang.c (value_from_host_double): Moved to...
7621         * value.c (value_from_host_double): ...here.
7622         * value.h (value_from_host_double): Declare.
7623         * guile/scm-math.c (vlscm_convert_typed_number): Use
7624         value_from_host_double.
7625         (vlscm_convert_number): Likewise.
7626         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7627         * python/py-value.c (convert_value_from_python): Likewise.
7628
7629 2019-03-06  Tom Tromey  <tom@tromey.com>
7630
7631         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7632
7633 2019-03-06  Tom Tromey  <tom@tromey.com>
7634
7635         * utils.h (free_current_contents): Don't declare.
7636         * utils.c (free_current_contents): Remove.
7637
7638 2019-03-06  Tom Tromey  <tom@tromey.com>
7639
7640         * top.c (quit_force): Update.
7641         * main.c (captured_command_loop): Update.
7642         * common/new-op.c (operator new): Update.
7643         * common/common-exceptions.c (struct catcher)
7644         <save_cleanup_chain>: Remove member.
7645         (exceptions_state_mc_init): Update.
7646         (exception_try_scope_entry): Return nullptr.
7647         (exception_try_scope_exit, exception_rethrow)
7648         (throw_exception_sjlj, throw_exception_cxx): Update.
7649         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7650         (all_cleanups, do_cleanups, discard_cleanups)
7651         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7652         (restore_cleanups, restore_final_cleanups): Don't declare.
7653         (do_final_cleanups): Remove parameter.
7654         * common/cleanups.c (cleanup_chain, make_cleanup)
7655         (make_cleanup_dtor, all_cleanups, do_cleanups)
7656         (discard_my_cleanups, discard_cleanups)
7657         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7658         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7659         (null_cleanup): Remove.
7660         (do_final_cleanups): Remove parameter.
7661
7662 2019-03-06  Tom Tromey  <tom@tromey.com>
7663
7664         * remote.c (remote_target::remote_parse_stop_reply): Use
7665         unique_xmalloc_ptr.
7666
7667 2019-03-06  Tom Tromey  <tom@tromey.com>
7668
7669         * stabsread.c (struct stabs_field_info): Rename from field_info.
7670         <list, fnlist>: Add initializers.
7671         <obstack>: New member.
7672         (read_member_functions, read_struct_fields, read_baseclasses):
7673         Allocate on obstack.  Don't use cleanups.
7674         (read_one_struct_field, read_member_functions, read_struct_fields)
7675         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7676         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7677         (read_struct_type): Update.
7678
7679 2019-03-06  Tom Tromey  <tom@tromey.com>
7680
7681         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7682         * common/filestuff.h (make_cleanup_close): Don't declare.
7683         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7684         Remove.
7685
7686 2019-03-06  Tom Tromey  <tom@tromey.com>
7687
7688         * solib-aix.c: Use make_scope_exit.
7689
7690 2019-03-06  Tom Tromey  <tom@tromey.com>
7691
7692         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7693         Use make_scope_exit.
7694
7695 2019-03-06  Tom Tromey  <tom@tromey.com>
7696
7697         * solib-svr4.c (disable_probes_interface): Remove parameter.
7698         (svr4_handle_solib_event): Use make_scope_exit.
7699
7700 2019-03-06  Tom Tromey  <tom@tromey.com>
7701
7702         * remote.c (struct stop_reply_deleter): Remove.
7703         (stop_reply_up): Update.
7704         (struct stop_reply): Derive from notif_event.  Don't typedef.
7705         <regcache>: Now a std::vector.
7706         (stop_reply_xfree): Remove.
7707         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7708         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7709         (remote_target::discard_pending_stop_replies): Use delete.
7710         (remote_target::remote_parse_stop_reply): Update.
7711         (remote_target::process_stop_reply): Update.
7712         * remote-notif.h (struct notif_event): Add virtual destructor.
7713         Remove "dtr" member.
7714         (struct notif_client) <alloc_event>: Return a unique_ptr.
7715         (notif_event_xfree): Don't declare.
7716         (notif_event_up): New typedef.
7717         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7718         (notif_event_xfree, do_notif_event_xfree): Remove.
7719         (remote_notif_state_xfree): Update.
7720
7721 2019-03-06  Tom Tromey  <tom@tromey.com>
7722
7723         * infrun.c (displaced_step_clear_cleanup): Now a
7724         forward_scope_exit type.
7725         (displaced_step_prepare_throw): Update.
7726         (displaced_step_fixup): Update.
7727
7728 2019-03-06  Tom Tromey  <tom@tromey.com>
7729
7730         * inferior.h (class inferior): Update comment.
7731         * gdbthread.h (class thread_info): Update comment.
7732
7733 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7734             Tom Tromey  <tom@tromey.com>
7735
7736         * stabsread.h (struct stab_section_list): Remove.
7737         (coffstab_build_psymtabs): Update.
7738         * dbxread.c (symbuf_sections): Now a std::vector.
7739         (sect_idx): New global.
7740         (fill_symbuf): Update.
7741         (coffstab_build_psymtabs): Change type of stabsects parameter.
7742         Update.
7743         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7744         std::vector.
7745         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7746         (coff_locate_sections): Update.
7747         (coff_symfile_read): Remove cleanups.  Update.
7748         (init_stringtab): Add storage parameter.
7749         (free_stringtab, free_stringtab_cleanup): Remove.
7750         (init_lineno): Add storage parameter.
7751         (free_linetab, free_linetab_cleanup): Remove.
7752
7753 2019-03-06  Pedro Alves  <palves@redhat.com>
7754
7755         * linux-fork.c (fork_info::clobber_regs): Delete.
7756         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7757         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7758         comment.  Adjust.
7759         (scoped_switch_fork_info::scoped_switch_fork_info)
7760         (checkpoint_command, linux_fork_context): Adjust
7761         fork_save_infrun_state calls.
7762
7763 2019-03-06  Pedro Alves  <palves@redhat.com>
7764
7765         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7766         (inf_has_multiple_threads): Return 'bool' and rewrite using
7767         inferior_info::threads().
7768
7769 2019-03-06  Pedro Alves  <palves@redhat.com>
7770
7771         * linux-fork.c: Include <list>.
7772         (fork_list): Now a std::list instance.
7773         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7774         (forks_exist_p, find_last_fork): Adjust.
7775         (new_fork): Delete.
7776         (one_fork_p): New.
7777         (add_fork): Adjust.
7778         (free_fork): Delete, folded into fork_info::~fork_info().
7779         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7780         Adjust.
7781         (init_fork_list): Delete.
7782         (linux_fork_killall, linux_fork_mourn_inferior)
7783         (linux_fork_detach, info_checkpoints_command): Adjust.
7784         (_initialize_linux_fork): No longer call init_fork_list.
7785
7786 2019-03-06  Pedro Alves  <palves@redhat.com>
7787
7788         * linux-fork.c (new_fork): New, split out of ...
7789         (add_fork): ... this.  Return void.  Move "first fork" special
7790         case from here, to ...
7791         (checkpoint_command): ... here.
7792         * linux-linux.h (add_fork): Return void.
7793
7794 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7795
7796         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7797
7798 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7799             Chris January  <chris.january@arm.com>
7800             David Lecomber  <david.lecomber@arm.com>
7801
7802         * f-exp.y: New token, UNOP_INTRINSIC.
7803         (exp): New pattern using UNOP_INTRINSIC token.
7804         (f77_keywords): Add 'abs' keyword.
7805         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7806         (value_from_host_double): New function.
7807         (evaluate_subexp_f): Support UNOP_ABS.
7808
7809 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7810
7811         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7812         types.
7813
7814 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7815
7816         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7817         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7818         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7819
7820 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7821
7822         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7823
7824 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7825             Chris January  <chris.january@arm.com>
7826
7827         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7828         * f-exp.y: Define 'KIND' token.
7829         (exp): New pattern for KIND expressions.
7830         (ptype): Handle types with a kind extension.
7831         (direct_abs_decl): Extend to spot kind extensions.
7832         (f77_keywords): Add 'kind' to the list.
7833         (push_kind_type): New function.
7834         (convert_to_kind_type): New function.
7835         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7836         * parse.c (operator_length_standard): Likewise.
7837         * parser-defs.h (enum type_pieces): Add tp_kind.
7838         * std-operator.def: Add UNOP_KIND.
7839
7840 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7841
7842         * f-exp.y (f_parse): Set yydebug.
7843
7844 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7845
7846         * f-lang.c (evaluate_subexp_f): New function.
7847         (exp_descriptor_f): New global.
7848         (f_language_defn): Use exp_descriptor_f instead of
7849         exp_descriptor_standard.
7850
7851 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7852
7853         * f-exp.y (struct token): Add comments.
7854         (dot_ops): Remove uppercase versions and the end marker.
7855         (f77_keywords): Likewise.
7856         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7857         entries in the dot_ops array are case insensitive, and use
7858         strncasecmp to compare strings.  Also some whitespace cleanup in
7859         this area.  Similar for the f77_keywords array, except entries in
7860         this list might be case sensitive.
7861
7862 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7863
7864         * f-exp.y (struct f77_boolean_val): Add comments.
7865         (boolean_values): Remove uppercase versions, and end marker.
7866         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7867         and use strncasecmp to achieve case insensitivity.  Additionally,
7868         perform whitespace cleanup around this code.
7869
7870 2019-03-06  Tom Tromey  <tromey@adacore.com>
7871
7872         * remote-sim.c (gdbsim_target_open): Use result of
7873         gdb_argv::release.
7874
7875 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7876         Dirk Schubert  <dirk.schubert@arm.com>
7877         Chris January  <chris.january@arm.com>
7878
7879         * eval.c (evaluate_subexp_standard): Call Fortran argument
7880         wrapping logic.
7881         * f-lang.c (struct value): A value which can be passed into a
7882         Fortran function call.
7883         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7884         where appropriate.
7885         (struct type): Value ready for a Fortran function call.
7886         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7887         is needed.
7888         * f-lang.h (fortran_argument_convert): Declaration.
7889         (fortran_preserve_arg_pointer): Declaration.
7890         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7891
7892 2019-03-05  Tom Tromey  <tromey@adacore.com>
7893
7894         * python/py-prettyprint.c (print_string_repr): Remove #if.
7895         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7896
7897 2019-03-05  Tom Tromey  <tromey@adacore.com>
7898
7899         * target.c (the_dummy_target): Move later.  Change type to
7900         "dummy_target".
7901         (initialize_targets): Don't initialize the_dummy_target.
7902
7903 2019-03-05  Tom Tromey  <tromey@adacore.com>
7904
7905         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7906         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7907
7908 2019-03-05  Tom Tromey  <tromey@adacore.com>
7909
7910         * windows-nat.c (windows_nat_target::attach)
7911         (windows_nat_target::detach): Don't call gdb_flush.
7912         * valprint.c (generic_val_print, val_print, val_print_string):
7913         Don't call gdb_flush.
7914         * utils.c (defaulted_query): Don't call gdb_flush.
7915         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7916         * target.c (target_announce_detach): Don't call gdb_flush.
7917         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7918         * remote.c (extended_remote_target::attach): Don't call
7919         gdb_flush.
7920         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7921         * printcmd.c (do_examine): Don't call gdb_flush.
7922         (info_display_command): Don't call gdb_flush.
7923         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7924         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7925         * memattr.c (info_mem_command): Don't call gdb_flush.
7926         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7927         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7928         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7929         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7930         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7931         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7932         (gnu_nat_target::detach): Don't call gdb_flush.
7933         * f-valprint.c (f_val_print): Don't call gdb_flush.
7934         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7935         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7936         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7937         gdb_flush.
7938         * c-valprint.c (c_val_print): Don't call gdb_flush.
7939         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7940
7941 2019-03-05  Tom Tromey  <tromey@adacore.com>
7942
7943         * varobj.c (update_dynamic_varobj_children): Update.
7944         (install_default_visualizer): Use reset, not release.
7945         * value.c (set_internalvar): Update.
7946         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7947         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7948         ATTRIBUTE_UNUSED_RESULT.
7949
7950 2019-03-05  Tom Tromey  <tromey@adacore.com>
7951
7952         * remote.c (class scoped_remote_fd) <release>: Add
7953         ATTRIBUTE_UNUSED_RESULT.
7954
7955 2019-03-05  Tom Tromey  <tromey@adacore.com>
7956
7957         * macroexp.c (struct macro_buffer) <release>: Add
7958         ATTRIBUTE_UNUSED_RESULT.
7959
7960 2019-03-05  Tom Tromey  <tromey@adacore.com>
7961
7962         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7963         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7964         ATTRIBUTE_UNUSED_RESULT.
7965
7966 2019-03-05  Tom Tromey  <tromey@adacore.com>
7967
7968         * common/scoped_fd.h (class scoped_fd) <release>: Add
7969         ATTRIBUTE_UNUSED_RESULT.
7970
7971 2019-03-05  Tom Tromey  <tromey@adacore.com>
7972
7973         * parser-defs.h (struct parser_state) <release>: Add
7974         ATTRIBUTE_UNUSED_RESULT.
7975
7976 2019-03-05  Tom Tromey  <tromey@adacore.com>
7977
7978         * utils.h (class gdb_argv) <release>: Add
7979         ATTRIBUTE_UNUSED_RESULT.
7980         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7981
7982 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7983
7984         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7985         for-loop range, to avoid compiler warnings.
7986
7987         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7988         avoid compiler warnings about unused variables.
7989
7990         * NEWS: Mention end of support for native debugging on MS-Windows
7991         before XP.
7992
7993         PR gdb/24292
7994         * common/netstuff.c:
7995         * gdbserver/gdbreplay.c
7996         * gdbserver/remote-utils.c:
7997         * ser-tcp.c:
7998         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7999         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8000         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8001         'getaddrinfo' and 'freeaddrinfo' were not available before
8002         Windows XP, and mingw.org's MinGW headers by default define
8003         _WIN32_WINNT to 0x500.
8004
8005 2019-03-01  Gary Benson <gbenson@redhat.com>
8006
8007         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8008
8009 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8010             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8011
8012         PR gdb/8527
8013         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8014         set_sigint_trap, clear_sigint_trap.
8015
8016 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8017
8018         * target.c (target_detach): Clear the regcache and the
8019         frame cache.
8020
8021 2019-02-27  Pedro Alves  <palves@redhat.com>
8022
8023         * utils.c (set_screen_size): When we cap the height/width sizes,
8024         tweak the corresponding command variable to show "unlimited":
8025
8026 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8027             Pedro Alves  <palves@redhat.com>
8028
8029         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8030         before calling rl_set_screen_size.
8031
8032 2019-02-27  Tom Tromey  <tromey@adacore.com>
8033
8034         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8035         define.
8036         * python/py-value.c: Remove Python 2.4 workaround.
8037         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8038         workaround.
8039         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8040         Python 2.4 workaround.
8041         * python/python-internal.h: Remove Python 2.4 comment.
8042         (Py_ssize_t): Don't define.
8043         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8044         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8045         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8046         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8047         * python/python.c (do_start_initialization): Remove Python 2.4
8048         workaround.
8049         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8050         (print_children): Remove Python 2.4 workaround.
8051         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8052         workaround.
8053         (CHARBUFFERPROC_NAME): Remove.
8054         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8055         Python 2.4 workaround.
8056
8057 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8058
8059         * NEWS: Note minimum Python version.
8060
8061 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8062
8063         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8064         code from these functions.  Remove corresponding ifdefs.  Use
8065         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8066         Remove gotos and target of gotos.
8067         (infpy_search_memory): Likewise.
8068
8069 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8070
8071         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8072         (hppa_gdbarch_init): Don't register deleted functions with
8073         gdbarch.
8074
8075 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8076
8077         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8078         (h8300_unwind_sp): Delete.
8079         (h8300_dummy_id): Delete.
8080         (h8300_gdbarch_init): Don't register deleted functions with
8081         gdbarch.
8082
8083 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8084
8085         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8086         (ft32_unwind_pc): Delete.
8087         (ft32_unwind_sp): Delete.
8088         (ft32_gdbarch_init): Don't register deleted functions with
8089         gdbarch.
8090
8091 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8092
8093         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8094         (frv_unwind_pc): Delete.
8095         (frv_unwind_sp): Delete.
8096         (frv_gdbarch_init): Don't register deleted functions with
8097         gdbarch.
8098
8099 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8100
8101         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8102         (riscv_unwind_pc): Delete.
8103         (riscv_unwind_sp): Delete.
8104         (riscv_gdbarch_init): Don't register deleted functions with
8105         gdbarch.
8106
8107 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8108
8109         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8110         (csky_unwind_pc): Delete.
8111         (csky_unwind_sp): Delete.
8112         (csky_gdbarch_init): Don't register deleted functions with
8113         gdbarch.
8114
8115 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8116
8117         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8118         (cris_unwind_pc): Delete.
8119         (cris_unwind_sp): Delete.
8120         (cris_gdbarch_init): Don't register deleted functions with
8121         gdbarch.
8122
8123 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8124
8125         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8126         (bfin_unwind_pc): Delete.
8127         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8128
8129 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8130
8131         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8132         (arm_unwind_pc): Delete.
8133         (arm_unwind_sp): Delete.
8134         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8135
8136 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8137
8138         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8139         (arc_unwind_pc): Delete.
8140         (arc_unwind_sp): Delete.
8141         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8142
8143 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8144
8145         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8146         (alpha_unwind_pc): Delete.
8147         (alpha_gdbarch_init): Don't register deleted functions with
8148         gdbarch.
8149
8150 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8151
8152         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8153         (aarch64_unwind_pc): Delete.
8154         (aarch64_unwind_sp): Delete.
8155         (aarch64_gdbarch_init): Don't register deleted functions with
8156         gdbarch.
8157
8158 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8159
8160         * gdbtypes.c (type_align): Don't consider static members when
8161         computing structure alignment.
8162
8163 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8164
8165         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8166         return 0 for other types.
8167         * arch-utils.c (default_type_align): Always return 0.
8168         * gdbarch.h: Regenerate.
8169         * gdbarch.sh (type_align): Extend comment.
8170         * gdbtypes.c (type_align): Add additional comments, always call
8171         gdbarch_type_align before applying the default rules.
8172         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8173         generic code will then apply a suitable default.
8174         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8175         types, return 0 for other types.
8176
8177 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8178
8179         * NEWS: Create a new section for the next release branch.
8180         Rename the section of the current branch, now that it has
8181         been cut.
8182
8183 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8184
8185         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8186         * version.in: Bump version to 8.3.50.DATE-git.
8187
8188 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8189
8190         * aix-thread.c (ptid_cmp): Remove unused variable.
8191         (get_signaled_thread): Likewise.
8192         (store_regs_user_thread): Likewise.
8193         (store_regs_kernel_thread): Likewise.
8194         (fetch_regs_kernel_thread): Remove shadowed variable.
8195
8196 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8197
8198         * features/riscv/32bit-cpu.xml: Add register numbers.
8199         * features/riscv/32bit-fpu.c: Regenerate.
8200         * features/riscv/32bit-fpu.xml: Add register numbers.
8201         * features/riscv/64bit-cpu.xml: Add register numbers.
8202         * features/riscv/64bit-fpu.c: Regenerate.
8203         * features/riscv/64bit-fpu.xml: Add register numbers.
8204
8205 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8206
8207         * NEWS: Mention two argument form of gdb.Value constructor.
8208         * python/py-value.c (convert_buffer_and_type_to_value): New
8209         function.
8210         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8211         Add support for handling an optional second argument.  Call
8212         convert_buffer_and_type_to_value as appropriate.
8213         * python/python-internal.h (Py_buffer_deleter): New struct.
8214         (Py_buffer_up): New typedef.
8215
8216 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8217
8218         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8219         instead of releasing ownership.
8220
8221 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8222
8223         * dwarf2read.c (open_and_init_dwp_file): Call
8224         elf_numsections instead of bfd_count_sections to initialize
8225         dwp_file->num_sections.
8226
8227 2019-02-25  Tom Tromey  <tromey@adacore.com>
8228
8229         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8230
8231 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8232
8233         * gcore.in: Add '--readnever' option when invoking GDB.
8234
8235 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8236
8237         * MAINTAINERS: Update my email address.
8238
8239 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8240
8241         * build-id.c (build_id_to_debug_bfd_1): New function.
8242         (build_id_to_debug_bfd): Look for separate debug file in
8243         sysroot.
8244
8245 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8246
8247         * gdbarch.sh: Update the copyright year range that is placed into
8248         generated files.
8249
8250 2019-02-22  Keith Seitz  <keiths@redhat.com>
8251
8252         PR symtab/23853
8253         * linespec.c (create_sals_line_offset): Search for the default
8254         symtab's filename instead of its fullname.
8255
8256 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8257
8258         * NEWS: Update style defaults.
8259
8260 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8261
8262         * main.c (captured_main_1): Disable styling in batch mode.
8263
8264 2019-02-20  Tom Tromey  <tom@tromey.com>
8265
8266         * symtab.c (symtab_symbol_info): Fix typos.
8267
8268 2019-02-20  Tom Tromey  <tromey@adacore.com>
8269
8270         * findcmd.c (_initialize_mem_search): Use upper case for
8271         metasyntactic variables.
8272
8273 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8274
8275         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8276         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8277
8278 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8279
8280         * top.h (source_file_name): Change to std::string.
8281         * top.c (source_file_name): Likewise.
8282         (command_line_input): Adjust.
8283         * cli/cli-script.c (script_from_file): Adjust.
8284
8285 2019-02-19  Tom Tromey  <tromey@adacore.com>
8286
8287         * ravenscar-thread.c
8288         (ravenscar_thread_target::update_thread_list): Don't call
8289         ada_build_task_list.
8290         * ada-lang.h (ada_build_task_list): Don't declare.
8291         * ada-tasks.c (struct ada_tasks_inferior_data)
8292         <task_list_valid_p>: Now bool.
8293         (read_known_tasks, ada_task_list_changed)
8294         (ada_tasks_invalidate_inferior_data): Update.
8295         (read_known_tasks_array): Return bool.
8296         (read_known_tasks_list): Likewise.
8297         (read_known_tasks): Return void.
8298         (ada_build_task_list): Now static.
8299
8300 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8301
8302         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8303         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8304
8305 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8306
8307         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8308         variant for ada_tasks_pspace_data_handle and
8309         ada_tasks_inferior_data_handle.
8310         (ada_tasks_pspace_data_cleanup): New function.
8311         (ada_tasks_inferior_data_cleanup): New function.
8312
8313 2019-02-17  Tom Tromey  <tom@tromey.com>
8314
8315         * macrotab.h (macro_source_fullname): Return a std::string.
8316         * macrotab.c (macro_include, check_for_redefinition)
8317         (macro_undef, macro_lookup_definition, foreach_macro)
8318         (foreach_macro_in_scope): Update.
8319         (macro_source_fullname): Return a std::string.
8320         * macrocmd.c (show_pp_source_pos): Update.
8321
8322 2019-02-17  Tom Tromey  <tom@tromey.com>
8323
8324         * macrocmd.c (show_pp_source_pos): Style the file names.
8325
8326 2019-02-17  Tom Tromey  <tom@tromey.com>
8327
8328         PR tui/24197:
8329         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8330
8331 2019-02-17  Tom Tromey  <tom@tromey.com>
8332
8333         * ada-lang.c (user_select_syms): Use filtered printing.
8334         * utils.c (wrap_style): New global.
8335         (desired_style): Remove.
8336         (emit_style_escape): Add stream parameter.
8337         (set_output_style, reset_terminal_style, prompt_for_continue):
8338         Update.
8339         (flush_wrap_buffer): Only flush gdb_stdout.
8340         (wrap_here): Set wrap_style.
8341         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8342         treat escape sequences as a character.  Change when wrap buffer is
8343         flushed.
8344         (fputs_styled): Do not set the output style when the default is
8345         requested.
8346         * ui-style.h (struct ui_file_style) <is_default>: New method.
8347         * source.c (print_source_lines_base): Emit escape sequences in one
8348         piece.
8349
8350 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8351
8352         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8353         integers and enumeration types.
8354
8355 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8356
8357         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8358         instead of lookup_symbol_in_language
8359         (do_exact_match): New function.
8360         (ada_get_symbol_name_matcher): Return do_exact_match when
8361         doing a verbatim match.
8362
8363 2019-02-15  Tom Tromey  <tromey@adacore.com>
8364
8365         * ravenscar-thread.c (ravenscar_thread_target::resume)
8366         (ravenscar_thread_target::wait): Special case wildcard requests.
8367
8368 2019-02-15  Tom Tromey  <tromey@adacore.com>
8369
8370         * ravenscar-thread.c (base_ptid): Remove.
8371         (struct ravenscar_thread_target) <close>: New method.
8372         <m_base_ptid>: New member.
8373         <update_inferior_ptid, active_task, task_is_currently_active,
8374         runtime_initialized>: Declare methods.
8375         <ravenscar_thread_target>: Add constructor.
8376         (ravenscar_thread_target::task_is_currently_active)
8377         (ravenscar_thread_target::update_inferior_ptid)
8378         (ravenscar_runtime_initialized): Rename.  Now methods.
8379         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8380         (ravenscar_thread_target::update_thread_list): Update.
8381         (ravenscar_thread_target::active_task): Now method.
8382         (ravenscar_thread_target::store_registers)
8383         (ravenscar_thread_target::prepare_to_store)
8384         (ravenscar_thread_target::prepare_to_store)
8385         (ravenscar_thread_target::mourn_inferior): Update.
8386         (ravenscar_inferior_created): Use "new" to create target.
8387         (ravenscar_thread_target::get_ada_task_ptid): Update.
8388         (_initialize_ravenscar): Don't initialize base_ptid.
8389         (ravenscar_ops): Remove global.
8390
8391 2019-02-15  Tom Tromey  <tromey@adacore.com>
8392
8393         * target.h (push_target): Declare new overload.
8394         * target.c (push_target): New overload, taking an rvalue reference.
8395         * remote.c (remote_target::open_1): Use push_target overload.
8396         * corelow.c (core_target_open): Use push_target overload.
8397
8398 2019-02-15  Tom Tromey  <tromey@adacore.com>
8399
8400         * ravenscar-thread.c (is_ravenscar_task)
8401         (ravenscar_task_is_currently_active): Return bool.
8402         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8403         (_initialize_ravenscar): Remove "(void)".
8404         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8405         Return bool.
8406
8407 2019-02-15  Tom Tromey  <tromey@adacore.com>
8408
8409         * ravenscar-thread.c (ravenscar_runtime_initializer)
8410         (has_ravenscar_runtime, get_running_thread_id)
8411         (ravenscar_thread_target::resume): Fix indentation.
8412
8413 2019-02-15  Tom Tromey  <tromey@adacore.com>
8414
8415         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8416         from ravenscar_arch_ops.
8417         (sparc_ravenscar_ops::fetch_registers)
8418         (sparc_ravenscar_ops::store_registers): Now methods.
8419         (sparc_ravenscar_prepare_to_store): Remove.
8420         (sparc_ravenscar_ops): Redefine.
8421         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8422         methods and destructor.  Remove members.
8423         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8424         (ravenscar_thread_target::store_registers)
8425         (ravenscar_thread_target::prepare_to_store): Update.
8426         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8427         Remove.
8428         (struct ppc_ravenscar_powerpc_ops): Derive from
8429         ravenscar_arch_ops.
8430         (ppc_ravenscar_powerpc_ops::fetch_registers)
8431         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8432         (ppc_ravenscar_powerpc_ops): Redefine.
8433         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8434         (ppc_ravenscar_e500_ops::fetch_registers)
8435         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8436         (ppc_ravenscar_e500_ops): Redefine.
8437         * aarch64-ravenscar-thread.c
8438         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8439         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8440         (aarch64_ravenscar_fetch_registers)
8441         (aarch64_ravenscar_store_registers): Now methods.
8442         (aarch64_ravenscar_ops): Redefine.
8443
8444 2019-02-15  Tom Tromey  <tromey@adacore.com>
8445
8446         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8447         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8448         (ravenscar_thread_target::stopped_by_watchpoint)
8449         (ravenscar_thread_target::stopped_data_address)
8450         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8451
8452 2019-02-15  Tom Tromey  <tromey@adacore.com>
8453
8454         * ravenscar-thread.c: Fix some typos.
8455
8456 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8457             Tom Tromey  <tromey@adacore.com>
8458
8459         * ada-lang.c (ada_exception_sal): Change addr_string to a
8460         std::string.
8461         (create_ada_exception_catchpoint): Update.
8462
8463 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8464             Tom Tromey  <tromey@adacore.com>
8465
8466         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8467         (bp_location_ops): Remove.
8468         (base_breakpoint_allocate_location): Update.
8469         (free_bp_location): Update.
8470         * ada-lang.c (class ada_catchpoint_location)
8471         <ada_catchpoint_location>: Remove ops parameter.
8472         (ada_catchpoint_location_dtor): Remove.
8473         (ada_catchpoint_location_ops): Remove.
8474         (allocate_location_exception): Update.
8475         * breakpoint.h (struct bp_location_ops): Remove.
8476         (class bp_location) <bp_location>: Remove bp_location_ops
8477         parameter.
8478         <~bp_location>: Add destructor.
8479         <ops>: Remove.
8480
8481 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8482             Pedro Alves  <palves@redhat.com>
8483
8484         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8485         'PATH_MAX'.
8486
8487 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8488             Samuel Thibault  <samuel.thibault@gnu.org>
8489             Thomas Schwinge  <thomas@codesourcery.com>
8490
8491         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8492         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8493
8494 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8495
8496         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8497         (check_empty): Use "const char *".
8498
8499         * gnu-nat.c (gnu_nat_target::detach): Instead of
8500         'detach_inferior (pid)' call
8501         'detach_inferior (find_inferior_pid (pid))'.
8502
8503         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8504         'nat/fork-inferior.o'.
8505         * gnu-nat.c: #include "nat/fork-inferior.h".
8506
8507         * gnu-nat.c (gnu_nat_target::detach): Instead of
8508         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8509         * gnu-nat.h: #include "inf-child.h".
8510         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8511         'i386_gnu_nat_target::fetch_registers'.
8512         (gnu_store_registers): Rename/move to
8513         'i386_gnu_nat_target::store_registers'.
8514
8515         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8516         * gnu-nat.h (mach_thread_info): New function.
8517         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8518
8519         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8520
8521 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8522
8523         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8524
8525 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8526
8527         * windows-nat.c (windows_add_thread): Add new parameter
8528         "main_thread_p" with default value set to false.  Update
8529         function documentation as well as all callers.
8530         (windows_delete_thread): Likewise.
8531         (fake_create_process): Update call to windows_add_thread.
8532         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8533         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8534         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8535         call to windows_delete_thread.
8536
8537 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8538
8539         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8540
8541 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8542
8543         * symfile.c (find_separate_debug_file): Use canonical path of
8544         sysroot with child_path instead of gdb_sysroot if it is valid.
8545
8546 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8547
8548         * symfile.c (find_separate_debug_file): Use child_path to
8549         determine if an object file is under a sysroot.
8550
8551 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8552
8553         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8554         unittests/child-path-selftests.c.
8555         * common/pathstuff.c (child_path): New function.
8556         * common/pathstuff.h (child_path): New prototype.
8557         * unittests/child-path-selftests.c: New file.
8558
8559 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8560
8561         * symfile.c (find_separate_debug_file): Look for separate debug
8562         files in debug directories under the sysroot.
8563
8564 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8565
8566         * symtab.h (struct minimal_symbol data_p): New const method.
8567         (struct minimal_symbol text_p): Likewise.
8568         * symtab.c (output_source_filename): Use file name style
8569         to print file name.
8570         (print_symbol_info): Likewise.
8571         (print_msymbol_info): Use address style to print addresses.
8572         Use function name style to print executable text symbols.
8573         (expand_symtab_containing_pc): Use data_p.
8574         (find_pc_sect_compunit_symtab): Likewise.
8575
8576 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8577
8578         * breakpoint.c (describe_other_breakpoints): Use address style
8579         to print addresses.
8580         (say_where): Likewise.
8581
8582 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8583
8584         * ada-typeprint.c (print_func_type): Print function name
8585         style to print function name.
8586         * c-typeprint.c (c_print_type_1): Likewise.
8587
8588 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8589
8590         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8591         for execve.
8592
8593 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8594
8595         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8596         type_stack.
8597
8598 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8599
8600         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8601         TYPE_CODE_REF types.
8602
8603 2019-02-08  Jim Wilson  <jimw@sifive.com>
8604
8605         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8606         (riscv_linux_fregset): New.
8607         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8608
8609 2019-02-07  Tom Tromey  <tom@tromey.com>
8610
8611         * thread.c (thread_cancel_execution_command): Update.
8612         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8613         methods.
8614         (struct thread_fsm_ops): Remove.
8615         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8616         (thread_fsm_should_stop, thread_fsm_return_value)
8617         (thread_fsm_set_finished, thread_fsm_finished_p)
8618         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8619         Don't declare.
8620         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8621         * infrun.c (clear_proceed_status_thread)
8622         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8623         (print_stop_event): Update.
8624         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8625         Add constructor.
8626         (step_command_fsm_ops): Remove.
8627         (new_step_command_fsm): Remove.
8628         (step_1): Update.
8629         (step_command_fsm::should_stop): Rename from
8630         step_command_fsm_should_stop.
8631         (step_command_fsm::clean_up): Rename from
8632         step_command_fsm_clean_up.
8633         (step_command_fsm::do_async_reply_reason): Rename from
8634         step_command_fsm_async_reply_reason.
8635         (struct until_next_fsm): Inherit from thread_fsm.  Add
8636         constructor.
8637         (until_next_fsm_ops): Remove.
8638         (new_until_next_fsm): Remove.
8639         (until_next_fsm::should_stop): Rename from
8640         until_next_fsm_should_stop.
8641         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8642         (until_next_fsm::do_async_reply_reason): Rename from
8643         until_next_fsm_async_reply_reason.
8644         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8645         constructor.  Change type of breakpoint.
8646         (finish_command_fsm_ops): Remove.
8647         (new_finish_command_fsm): Remove.
8648         (finish_command_fsm::should_stop): Rename from
8649         finish_command_fsm_should_stop.
8650         (finish_command_fsm::clean_up): Rename from
8651         finish_command_fsm_clean_up.
8652         (finish_command_fsm::return_value): Rename from
8653         finish_command_fsm_return_value.
8654         (finish_command_fsm::do_async_reply_reason): Rename from
8655         finish_command_fsm_async_reply_reason.
8656         (finish_command): Update.
8657         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8658         Add constructor.
8659         (call_thread_fsm_ops): Remove.
8660         (call_thread_fsm::call_thread_fsm): Rename from
8661         new_call_thread_fsm.
8662         (call_thread_fsm::should_stop): Rename from
8663         call_thread_fsm_should_stop.
8664         (call_thread_fsm::should_notify_stop): Rename from
8665         call_thread_fsm_should_notify_stop.
8666         (run_inferior_call, call_function_by_hand_dummy): Update.
8667         * cli/cli-interp.c (should_print_stop_to_console): Update.
8668         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8669         Add constructor.  Change type of location_breakpoint,
8670         caller_breakpoint.
8671         (until_break_fsm_ops): Remove.
8672         (new_until_break_fsm): Remove.
8673         (until_break_fsm::should_stop): Rename from
8674         until_break_fsm_should_stop.
8675         (until_break_fsm::clean_up): Rename from
8676         until_break_fsm_clean_up.
8677         (until_break_fsm::do_async_reply_reason): Rename from
8678         until_break_fsm_async_reply_reason.
8679         (until_break_command): Update.
8680         * thread-fsm.c: Remove.
8681         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8682
8683 2019-02-07  Tom Tromey  <tom@tromey.com>
8684
8685         * yy-remap.h: Add include guard.
8686         * xtensa-tdep.h: Add include guard.
8687         * xcoffread.h: Rename include guard.
8688         * varobj-iter.h: Add include guard.
8689         * tui/tui.h: Rename include guard.
8690         * tui/tui-winsource.h: Rename include guard.
8691         * tui/tui-wingeneral.h: Rename include guard.
8692         * tui/tui-windata.h: Rename include guard.
8693         * tui/tui-win.h: Rename include guard.
8694         * tui/tui-stack.h: Rename include guard.
8695         * tui/tui-source.h: Rename include guard.
8696         * tui/tui-regs.h: Rename include guard.
8697         * tui/tui-out.h: Rename include guard.
8698         * tui/tui-layout.h: Rename include guard.
8699         * tui/tui-io.h: Rename include guard.
8700         * tui/tui-hooks.h: Rename include guard.
8701         * tui/tui-file.h: Rename include guard.
8702         * tui/tui-disasm.h: Rename include guard.
8703         * tui/tui-data.h: Rename include guard.
8704         * tui/tui-command.h: Rename include guard.
8705         * tic6x-tdep.h: Add include guard.
8706         * target/waitstatus.h: Rename include guard.
8707         * target/wait.h: Rename include guard.
8708         * target/target.h: Rename include guard.
8709         * target/resume.h: Rename include guard.
8710         * target-float.h: Rename include guard.
8711         * stabsread.h: Add include guard.
8712         * rs6000-tdep.h: Add include guard.
8713         * riscv-fbsd-tdep.h: Add include guard.
8714         * regformats/regdef.h: Rename include guard.
8715         * record.h: Rename include guard.
8716         * python/python.h: Rename include guard.
8717         * python/python-internal.h: Rename include guard.
8718         * python/py-stopevent.h: Rename include guard.
8719         * python/py-ref.h: Rename include guard.
8720         * python/py-record.h: Rename include guard.
8721         * python/py-record-full.h: Rename include guard.
8722         * python/py-record-btrace.h: Rename include guard.
8723         * python/py-instruction.h: Rename include guard.
8724         * python/py-events.h: Rename include guard.
8725         * python/py-event.h: Rename include guard.
8726         * procfs.h: Add include guard.
8727         * proc-utils.h: Add include guard.
8728         * p-lang.h: Add include guard.
8729         * or1k-tdep.h: Rename include guard.
8730         * observable.h: Rename include guard.
8731         * nto-tdep.h: Rename include guard.
8732         * nat/x86-linux.h: Rename include guard.
8733         * nat/x86-linux-dregs.h: Rename include guard.
8734         * nat/x86-gcc-cpuid.h: Add include guard.
8735         * nat/x86-dregs.h: Rename include guard.
8736         * nat/x86-cpuid.h: Rename include guard.
8737         * nat/ppc-linux.h: Rename include guard.
8738         * nat/mips-linux-watch.h: Rename include guard.
8739         * nat/linux-waitpid.h: Rename include guard.
8740         * nat/linux-ptrace.h: Rename include guard.
8741         * nat/linux-procfs.h: Rename include guard.
8742         * nat/linux-osdata.h: Rename include guard.
8743         * nat/linux-nat.h: Rename include guard.
8744         * nat/linux-namespaces.h: Rename include guard.
8745         * nat/linux-btrace.h: Rename include guard.
8746         * nat/glibc_thread_db.h: Rename include guard.
8747         * nat/gdb_thread_db.h: Rename include guard.
8748         * nat/gdb_ptrace.h: Rename include guard.
8749         * nat/fork-inferior.h: Rename include guard.
8750         * nat/amd64-linux-siginfo.h: Rename include guard.
8751         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8752         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8753         * nat/aarch64-linux.h: Rename include guard.
8754         * nat/aarch64-linux-hw-point.h: Rename include guard.
8755         * mn10300-tdep.h: Add include guard.
8756         * mips-linux-tdep.h: Add include guard.
8757         * mi/mi-parse.h: Rename include guard.
8758         * mi/mi-out.h: Rename include guard.
8759         * mi/mi-main.h: Rename include guard.
8760         * mi/mi-interp.h: Rename include guard.
8761         * mi/mi-getopt.h: Rename include guard.
8762         * mi/mi-console.h: Rename include guard.
8763         * mi/mi-common.h: Rename include guard.
8764         * mi/mi-cmds.h: Rename include guard.
8765         * mi/mi-cmd-break.h: Rename include guard.
8766         * m2-lang.h: Add include guard.
8767         * location.h: Rename include guard.
8768         * linux-record.h: Rename include guard.
8769         * linux-nat.h: Add include guard.
8770         * linux-fork.h: Add include guard.
8771         * i386-darwin-tdep.h: Rename include guard.
8772         * hppa-linux-offsets.h: Add include guard.
8773         * guile/guile.h: Rename include guard.
8774         * guile/guile-internal.h: Rename include guard.
8775         * gnu-nat.h: Rename include guard.
8776         * gdb-stabs.h: Rename include guard.
8777         * frv-tdep.h: Add include guard.
8778         * f-lang.h: Add include guard.
8779         * event-loop.h: Add include guard.
8780         * darwin-nat.h: Rename include guard.
8781         * cp-abi.h: Rename include guard.
8782         * config/sparc/nm-sol2.h: Rename include guard.
8783         * config/nm-nto.h: Rename include guard.
8784         * config/nm-linux.h: Add include guard.
8785         * config/i386/nm-i386gnu.h: Rename include guard.
8786         * config/djgpp/nl_types.h: Rename include guard.
8787         * config/djgpp/langinfo.h: Rename include guard.
8788         * compile/gcc-cp-plugin.h: Add include guard.
8789         * compile/gcc-c-plugin.h: Add include guard.
8790         * compile/compile.h: Rename include guard.
8791         * compile/compile-object-run.h: Rename include guard.
8792         * compile/compile-object-load.h: Rename include guard.
8793         * compile/compile-internal.h: Rename include guard.
8794         * compile/compile-cplus.h: Rename include guard.
8795         * compile/compile-c.h: Rename include guard.
8796         * common/xml-utils.h: Rename include guard.
8797         * common/x86-xstate.h: Rename include guard.
8798         * common/version.h: Rename include guard.
8799         * common/vec.h: Rename include guard.
8800         * common/tdesc.h: Rename include guard.
8801         * common/selftest.h: Rename include guard.
8802         * common/scoped_restore.h: Rename include guard.
8803         * common/scoped_mmap.h: Rename include guard.
8804         * common/scoped_fd.h: Rename include guard.
8805         * common/safe-iterator.h: Rename include guard.
8806         * common/run-time-clock.h: Rename include guard.
8807         * common/refcounted-object.h: Rename include guard.
8808         * common/queue.h: Rename include guard.
8809         * common/ptid.h: Rename include guard.
8810         * common/print-utils.h: Rename include guard.
8811         * common/preprocessor.h: Rename include guard.
8812         * common/pathstuff.h: Rename include guard.
8813         * common/observable.h: Rename include guard.
8814         * common/netstuff.h: Rename include guard.
8815         * common/job-control.h: Rename include guard.
8816         * common/host-defs.h: Rename include guard.
8817         * common/gdb_wait.h: Rename include guard.
8818         * common/gdb_vecs.h: Rename include guard.
8819         * common/gdb_unlinker.h: Rename include guard.
8820         * common/gdb_unique_ptr.h: Rename include guard.
8821         * common/gdb_tilde_expand.h: Rename include guard.
8822         * common/gdb_sys_time.h: Rename include guard.
8823         * common/gdb_string_view.h: Rename include guard.
8824         * common/gdb_splay_tree.h: Rename include guard.
8825         * common/gdb_setjmp.h: Rename include guard.
8826         * common/gdb_ref_ptr.h: Rename include guard.
8827         * common/gdb_optional.h: Rename include guard.
8828         * common/gdb_locale.h: Rename include guard.
8829         * common/gdb_assert.h: Rename include guard.
8830         * common/filtered-iterator.h: Rename include guard.
8831         * common/filestuff.h: Rename include guard.
8832         * common/fileio.h: Rename include guard.
8833         * common/environ.h: Rename include guard.
8834         * common/common-utils.h: Rename include guard.
8835         * common/common-types.h: Rename include guard.
8836         * common/common-regcache.h: Rename include guard.
8837         * common/common-inferior.h: Rename include guard.
8838         * common/common-gdbthread.h: Rename include guard.
8839         * common/common-exceptions.h: Rename include guard.
8840         * common/common-defs.h: Rename include guard.
8841         * common/common-debug.h: Rename include guard.
8842         * common/cleanups.h: Rename include guard.
8843         * common/buffer.h: Rename include guard.
8844         * common/btrace-common.h: Rename include guard.
8845         * common/break-common.h: Rename include guard.
8846         * cli/cli-utils.h: Rename include guard.
8847         * cli/cli-style.h: Rename include guard.
8848         * cli/cli-setshow.h: Rename include guard.
8849         * cli/cli-script.h: Rename include guard.
8850         * cli/cli-interp.h: Rename include guard.
8851         * cli/cli-decode.h: Rename include guard.
8852         * cli/cli-cmds.h: Rename include guard.
8853         * charset-list.h: Add include guard.
8854         * buildsym-legacy.h: Rename include guard.
8855         * bfin-tdep.h: Add include guard.
8856         * ax.h: Rename include guard.
8857         * arm-linux-tdep.h: Add include guard.
8858         * arm-fbsd-tdep.h: Add include guard.
8859         * arch/xtensa.h: Rename include guard.
8860         * arch/tic6x.h: Add include guard.
8861         * arch/i386.h: Add include guard.
8862         * arch/arm.h: Rename include guard.
8863         * arch/arm-linux.h: Rename include guard.
8864         * arch/arm-get-next-pcs.h: Rename include guard.
8865         * arch/amd64.h: Add include guard.
8866         * arch/aarch64-insn.h: Rename include guard.
8867         * arch-utils.h: Rename include guard.
8868         * annotate.h: Add include guard.
8869         * amd64-darwin-tdep.h: Rename include guard.
8870         * aarch64-linux-tdep.h: Add include guard.
8871         * aarch64-fbsd-tdep.h: Add include guard.
8872         * aarch32-linux-nat.h: Add include guard.
8873
8874 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8875
8876         * macrotab.c (macro_define_internal): New function that
8877         factorizes macro_define_object_internal and macro_define_function
8878         code.
8879         (macro_define_object_internal): Use macro_define_internal.
8880         (macro_define_function): Likewise.
8881
8882 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8883
8884         * macrocmd.c (extract_identifier): Return
8885         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8886         callers.
8887
8888 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8889
8890         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8891
8892 2019-02-05  Tom Tromey  <tom@tromey.com>
8893
8894         * target.c (target_stack::unpush): Move assertion earlier.
8895
8896 2019-01-30  Tom Tromey  <tom@tromey.com>
8897
8898         PR python/23615:
8899         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8900         (gdbpy_parse_and_eval): Likewise.
8901         * python/python-internal.h (gdbpy_allow_threads): New class.
8902
8903 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8904
8905         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8906         (aarch64_fbsd_fpregmap): Move earlier.
8907         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8908         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8909         instead of individual calls to trad_frame_set_reg_addr.
8910         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8911         earlier.
8912         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8913         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8914         instead of individual calls to trad_frame_set_reg_addr.
8915
8916 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8917
8918         * CONTRIBUTE: Replace contribution list with wiki link.
8919
8920 2019-01-25  Tom Tromey  <tom@tromey.com>
8921
8922         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8923
8924 2019-01-25  Tom Tromey  <tom@tromey.com>
8925
8926         * xtensa-linux-nat.c: Fix common/ includes.
8927         * xml-support.h: Fix common/ includes.
8928         * xml-support.c: Fix common/ includes.
8929         * x86-linux-nat.c: Fix common/ includes.
8930         * windows-nat.c: Fix common/ includes.
8931         * varobj.h: Fix common/ includes.
8932         * varobj.c: Fix common/ includes.
8933         * value.c: Fix common/ includes.
8934         * valops.c: Fix common/ includes.
8935         * utils.c: Fix common/ includes.
8936         * unittests/xml-utils-selftests.c: Fix common/ includes.
8937         * unittests/utils-selftests.c: Fix common/ includes.
8938         * unittests/unpack-selftests.c: Fix common/ includes.
8939         * unittests/tracepoint-selftests.c: Fix common/ includes.
8940         * unittests/style-selftests.c: Fix common/ includes.
8941         * unittests/string_view-selftests.c: Fix common/ includes.
8942         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8943         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8944         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8945         * unittests/rsp-low-selftests.c: Fix common/ includes.
8946         * unittests/parse-connection-spec-selftests.c: Fix common/
8947         includes.
8948         * unittests/optional-selftests.c: Fix common/ includes.
8949         * unittests/offset-type-selftests.c: Fix common/ includes.
8950         * unittests/observable-selftests.c: Fix common/ includes.
8951         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8952         * unittests/memrange-selftests.c: Fix common/ includes.
8953         * unittests/memory-map-selftests.c: Fix common/ includes.
8954         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8955         * unittests/function-view-selftests.c: Fix common/ includes.
8956         * unittests/environ-selftests.c: Fix common/ includes.
8957         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8958         * unittests/common-utils-selftests.c: Fix common/ includes.
8959         * unittests/cli-utils-selftests.c: Fix common/ includes.
8960         * unittests/array-view-selftests.c: Fix common/ includes.
8961         * ui-file.c: Fix common/ includes.
8962         * tui/tui-io.c: Fix common/ includes.
8963         * tracepoint.h: Fix common/ includes.
8964         * tracepoint.c: Fix common/ includes.
8965         * tracefile-tfile.c: Fix common/ includes.
8966         * top.h: Fix common/ includes.
8967         * top.c: Fix common/ includes.
8968         * thread.c: Fix common/ includes.
8969         * target/waitstatus.h: Fix common/ includes.
8970         * target/waitstatus.c: Fix common/ includes.
8971         * target.h: Fix common/ includes.
8972         * target.c: Fix common/ includes.
8973         * target-memory.c: Fix common/ includes.
8974         * target-descriptions.c: Fix common/ includes.
8975         * symtab.h: Fix common/ includes.
8976         * symfile.c: Fix common/ includes.
8977         * stap-probe.c: Fix common/ includes.
8978         * spu-linux-nat.c: Fix common/ includes.
8979         * sparc-nat.c: Fix common/ includes.
8980         * source.c: Fix common/ includes.
8981         * solib.c: Fix common/ includes.
8982         * solib-target.c: Fix common/ includes.
8983         * ser-unix.c: Fix common/ includes.
8984         * ser-tcp.c: Fix common/ includes.
8985         * ser-pipe.c: Fix common/ includes.
8986         * ser-base.c: Fix common/ includes.
8987         * selftest-arch.c: Fix common/ includes.
8988         * s12z-tdep.c: Fix common/ includes.
8989         * rust-exp.y: Fix common/ includes.
8990         * rs6000-aix-tdep.c: Fix common/ includes.
8991         * riscv-tdep.c: Fix common/ includes.
8992         * remote.c: Fix common/ includes.
8993         * remote-notif.h: Fix common/ includes.
8994         * remote-fileio.h: Fix common/ includes.
8995         * remote-fileio.c: Fix common/ includes.
8996         * regcache.h: Fix common/ includes.
8997         * regcache.c: Fix common/ includes.
8998         * record-btrace.c: Fix common/ includes.
8999         * python/python.c: Fix common/ includes.
9000         * python/py-type.c: Fix common/ includes.
9001         * python/py-inferior.c: Fix common/ includes.
9002         * progspace.h: Fix common/ includes.
9003         * producer.c: Fix common/ includes.
9004         * procfs.c: Fix common/ includes.
9005         * proc-api.c: Fix common/ includes.
9006         * printcmd.c: Fix common/ includes.
9007         * ppc-linux-nat.c: Fix common/ includes.
9008         * parser-defs.h: Fix common/ includes.
9009         * osdata.c: Fix common/ includes.
9010         * obsd-nat.c: Fix common/ includes.
9011         * nat/x86-linux.c: Fix common/ includes.
9012         * nat/x86-linux-dregs.c: Fix common/ includes.
9013         * nat/x86-dregs.h: Fix common/ includes.
9014         * nat/x86-dregs.c: Fix common/ includes.
9015         * nat/ppc-linux.c: Fix common/ includes.
9016         * nat/mips-linux-watch.h: Fix common/ includes.
9017         * nat/mips-linux-watch.c: Fix common/ includes.
9018         * nat/linux-waitpid.c: Fix common/ includes.
9019         * nat/linux-ptrace.h: Fix common/ includes.
9020         * nat/linux-ptrace.c: Fix common/ includes.
9021         * nat/linux-procfs.c: Fix common/ includes.
9022         * nat/linux-personality.c: Fix common/ includes.
9023         * nat/linux-osdata.c: Fix common/ includes.
9024         * nat/linux-namespaces.c: Fix common/ includes.
9025         * nat/linux-btrace.h: Fix common/ includes.
9026         * nat/linux-btrace.c: Fix common/ includes.
9027         * nat/fork-inferior.c: Fix common/ includes.
9028         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9029         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9030         * nat/aarch64-linux.c: Fix common/ includes.
9031         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9032         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9033         * namespace.h: Fix common/ includes.
9034         * mips-linux-tdep.c: Fix common/ includes.
9035         * minsyms.c: Fix common/ includes.
9036         * mi/mi-parse.h: Fix common/ includes.
9037         * mi/mi-main.c: Fix common/ includes.
9038         * mi/mi-cmd-env.c: Fix common/ includes.
9039         * memrange.h: Fix common/ includes.
9040         * memattr.c: Fix common/ includes.
9041         * maint.h: Fix common/ includes.
9042         * maint.c: Fix common/ includes.
9043         * main.c: Fix common/ includes.
9044         * machoread.c: Fix common/ includes.
9045         * location.c: Fix common/ includes.
9046         * linux-thread-db.c: Fix common/ includes.
9047         * linux-nat.c: Fix common/ includes.
9048         * linux-fork.c: Fix common/ includes.
9049         * inline-frame.c: Fix common/ includes.
9050         * infrun.c: Fix common/ includes.
9051         * inflow.c: Fix common/ includes.
9052         * inferior.h: Fix common/ includes.
9053         * inferior.c: Fix common/ includes.
9054         * infcmd.c: Fix common/ includes.
9055         * inf-ptrace.c: Fix common/ includes.
9056         * inf-child.c: Fix common/ includes.
9057         * ia64-linux-nat.c: Fix common/ includes.
9058         * i387-tdep.c: Fix common/ includes.
9059         * i386-tdep.c: Fix common/ includes.
9060         * i386-linux-tdep.c: Fix common/ includes.
9061         * i386-linux-nat.c: Fix common/ includes.
9062         * i386-go32-tdep.c: Fix common/ includes.
9063         * i386-fbsd-tdep.c: Fix common/ includes.
9064         * i386-fbsd-nat.c: Fix common/ includes.
9065         * guile/scm-type.c: Fix common/ includes.
9066         * guile/guile.c: Fix common/ includes.
9067         * go32-nat.c: Fix common/ includes.
9068         * gnu-nat.c: Fix common/ includes.
9069         * gdbthread.h: Fix common/ includes.
9070         * gdbarch-selftests.c: Fix common/ includes.
9071         * gdb_usleep.c: Fix common/ includes.
9072         * gdb_select.h: Fix common/ includes.
9073         * gdb_bfd.c: Fix common/ includes.
9074         * gcore.c: Fix common/ includes.
9075         * fork-child.c: Fix common/ includes.
9076         * findvar.c: Fix common/ includes.
9077         * fbsd-nat.c: Fix common/ includes.
9078         * event-top.c: Fix common/ includes.
9079         * event-loop.c: Fix common/ includes.
9080         * dwarf2read.c: Fix common/ includes.
9081         * dwarf2loc.c: Fix common/ includes.
9082         * dwarf2-frame.c: Fix common/ includes.
9083         * dwarf-index-cache.c: Fix common/ includes.
9084         * dtrace-probe.c: Fix common/ includes.
9085         * disasm-selftests.c: Fix common/ includes.
9086         * defs.h: Fix common/ includes.
9087         * csky-tdep.c: Fix common/ includes.
9088         * cp-valprint.c: Fix common/ includes.
9089         * cp-support.h: Fix common/ includes.
9090         * cp-support.c: Fix common/ includes.
9091         * corelow.c: Fix common/ includes.
9092         * completer.h: Fix common/ includes.
9093         * completer.c: Fix common/ includes.
9094         * compile/compile.c: Fix common/ includes.
9095         * compile/compile-loc2c.c: Fix common/ includes.
9096         * compile/compile-cplus-types.c: Fix common/ includes.
9097         * compile/compile-cplus-symbols.c: Fix common/ includes.
9098         * command.h: Fix common/ includes.
9099         * cli/cli-dump.c: Fix common/ includes.
9100         * cli/cli-cmds.c: Fix common/ includes.
9101         * charset.c: Fix common/ includes.
9102         * build-id.c: Fix common/ includes.
9103         * btrace.h: Fix common/ includes.
9104         * btrace.c: Fix common/ includes.
9105         * breakpoint.h: Fix common/ includes.
9106         * breakpoint.c: Fix common/ includes.
9107         * ax.h:
9108         (enum agent_op): Fix common/ includes.
9109         * ax-general.c (struct aop_map): Fix common/ includes.
9110         * ax-gdb.c: Fix common/ includes.
9111         * auxv.c: Fix common/ includes.
9112         * auto-load.c: Fix common/ includes.
9113         * arm-tdep.c: Fix common/ includes.
9114         * arch/riscv.c: Fix common/ includes.
9115         * arch/ppc-linux-common.c: Fix common/ includes.
9116         * arch/i386.c: Fix common/ includes.
9117         * arch/arm.c: Fix common/ includes.
9118         * arch/arm-linux.c: Fix common/ includes.
9119         * arch/arm-get-next-pcs.c: Fix common/ includes.
9120         * arch/amd64.c: Fix common/ includes.
9121         * arch/aarch64.c: Fix common/ includes.
9122         * arch/aarch64-insn.c: Fix common/ includes.
9123         * arch-utils.c: Fix common/ includes.
9124         * amd64-windows-tdep.c: Fix common/ includes.
9125         * amd64-tdep.c: Fix common/ includes.
9126         * amd64-sol2-tdep.c: Fix common/ includes.
9127         * amd64-obsd-tdep.c: Fix common/ includes.
9128         * amd64-nbsd-tdep.c: Fix common/ includes.
9129         * amd64-linux-tdep.c: Fix common/ includes.
9130         * amd64-linux-nat.c: Fix common/ includes.
9131         * amd64-fbsd-tdep.c: Fix common/ includes.
9132         * amd64-fbsd-nat.c: Fix common/ includes.
9133         * amd64-dicos-tdep.c: Fix common/ includes.
9134         * amd64-darwin-tdep.c: Fix common/ includes.
9135         * agent.c: Fix common/ includes.
9136         * ada-lang.h: Fix common/ includes.
9137         * ada-lang.c: Fix common/ includes.
9138         * aarch64-tdep.c: Fix common/ includes.
9139
9140 2019-01-25  Tom Tromey  <tom@tromey.com>
9141
9142         * common/create-version.sh: Use common/version.h.
9143
9144 2019-01-24  Pedro Alves  <palves@redhat.com>
9145
9146         * infrun.c (signal_stop, signal_print, signal_program)
9147         (signal_catch, signal_pass): Now arrays instead of pointers.
9148         (update_signals_program_target, do_target_resume)
9149         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9150         * linux-nat.c (linux_nat_target::pass_signals)
9151         (linux_nat_target::create_inferior, linux_nat_target::attach):
9152         Adjust.
9153         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9154         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9155         * procfs.c (procfs_target::pass_signals): Adjust.
9156         * record-full.c (record_full_target::resume): Adjust.
9157         * remote.c (remote_target::pass_signals)
9158         (remote_target::program_signals): Adjust.
9159         * target-debug.h (target_debug_print_signals): Now takes a
9160         gdb::array_view as parameter.  Adjust.
9161         * target.h (target_ops) <pass_signals, program_signals>: Replace
9162         pointer and length parameters with gdb::array_view.
9163         (target_pass_signals, target_program_signals): Likewise.
9164         * target-delegates.c: Regenerate.
9165
9166 2019-01-24  Pedro Alves  <palves@redhat.com>
9167
9168         * common/forward-scope-exit.h
9169         (forward_scope_exit::forward_scope_exit): Pass arguments to
9170         m_bind_function directly, instead of creating a std::bind and
9171         copying that.
9172
9173 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9174
9175         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9176         for static members.
9177         (pass_in_v_vfp_candidate): Likewise.
9178
9179 2019-01-23  Tom Tromey  <tom@tromey.com>
9180             Pedro Alves  <palves@redhat.com>
9181
9182         * regcache.c (class regcache_invalidator): Remove.
9183         (regcache::raw_write): Use make_scope_exit.
9184
9185 2019-01-23  Tom Tromey  <tom@tromey.com>
9186
9187         * ui-out.h (class ui_out_emit_type): Update comment.
9188
9189 2019-01-23  Tom Tromey  <tom@tromey.com>
9190
9191         * infrun.c (fetch_inferior_event): Update comment.
9192
9193 2019-01-23  Tom Tromey  <tom@tromey.com>
9194             Pedro Alves  <palves@redhat.com>
9195
9196         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9197         parameter.
9198         (fetch_inferior_event): Use SCOPE_EXIT.
9199
9200
9201 2019-01-23  Tom Tromey  <tom@tromey.com>
9202             Pedro Alves  <palves@redhat.com>
9203
9204         * infrun.c (disable_thread_events): Delete.
9205         (stop_all_threads): Use SCOPE_EXIT.
9206
9207 2019-01-23  Tom Tromey  <tom@tromey.com>
9208             Pedro Alves  <palves@redhat.com>
9209
9210         * symfile.c: Include forward-scope-exit.h.
9211         (clear_symtab_users_cleanup): Replace forward declaration with
9212         a FORWARD_SCOPE_EXIT.
9213         (syms_from_objfile_1): Use the forward_scope_exit and
9214         gdb::optional instead of cleanup_function.
9215         (reread_symbols): Use the forward_scope_exit instead of
9216         cleanup_function.
9217         (clear_symtab_users_cleanup): Remove function.
9218
9219 2019-01-23  Tom Tromey  <tom@tromey.com>
9220             Pedro Alves  <palves@redhat.com>
9221
9222         * linux-nat.c: Include scope-exit.h.
9223         (cleanup_target_stop): Remove.
9224         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9225         SCOPE_EXIT.
9226
9227 2019-01-23  Tom Tromey  <tom@tromey.com>
9228             Pedro Alves  <palves@redhat.com>
9229
9230         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9231         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9232
9233 2019-01-23  Tom Tromey  <tom@tromey.com>
9234             Andrew Burgess  <andrew.burgess@embecosm.com>
9235             Pedro Alves  <palves@redhat.com>
9236
9237         * infrun.c (fetch_inferior_event): Use scope_exit.
9238         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9239         * top.c (execute_command): Use scope_exit.
9240         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9241         * utils.c (do_bpstat_clear_actions_cleanup)
9242         (make_bpstat_clear_actions_cleanup): Remove.
9243
9244 2019-01-23  Tom Tromey  <tom@tromey.com>
9245             Pedro Alves  <palves@redhat.com>
9246
9247         * infrun.c: Include "common/scope-exit.h"
9248         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9249         (wait_for_inferior): Use SCOPE_EXIT.
9250         (fetch_inferior_event): Use scope_exit.
9251
9252 2019-01-23  Tom Tromey  <tom@tromey.com>
9253             Pedro Alves  <palves@redhat.com>
9254
9255         * breakpoint.c (create_breakpoint): Remove cleanup.
9256
9257 2019-01-23  Tom Tromey  <tom@tromey.com>
9258             Andrew Burgess  <andrew.burgess@embecosm.com>
9259             Pedro Alves  <palves@redhat.com>
9260
9261 2019-01-23  Pedro Alves  <palves@redhat.com>
9262
9263         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9264
9265 2019-01-23  Pedro Alves  <palves@redhat.com>
9266             Andrew Burgess  <andrew.burgess@embecosm.com>
9267
9268         * gdbthread.h: Include "common/forward-scope-exit.h".
9269         (scoped_finish_thread_state): Redefine custom class in terms of
9270         forward_scope_exit.
9271
9272 2019-01-23  Pedro Alves  <palves@redhat.com>
9273             Andrew Burgess  <andrew.burgess@embecosm.com>
9274
9275         * common/forward-scope-exit.h: New file.
9276
9277 2019-01-23  Pedro Alves  <palves@redhat.com>
9278             Andrew Burgess  <andrew.burgess@embecosm.com>
9279             Tom Tromey  <tom@tromey.com>
9280
9281         * common/scope-exit.h: New file.
9282
9283 2019-01-23  Pedro Alves  <palves@redhat.com>
9284
9285         * common/preprocessor.h (ESC): Rename to ...
9286         (ESC_PARENS): ... this.
9287         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9288         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9289
9290 2019-01-23  Tom Tromey  <tom@tromey.com>
9291
9292         * language.h (class scoped_switch_to_sym_language_if_auto):
9293         Initialize m_lang in both cases.
9294
9295 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9296
9297         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9298         with XCNEW.
9299
9300 2019-01-22  Tom Tromey  <tom@tromey.com>
9301
9302         * corelow.c: Do not include sys/file.h.
9303
9304 2019-01-22  Tom Tromey  <tom@tromey.com>
9305
9306         * tui/tui-wingeneral.h: Include gdb_curses.h.
9307
9308 2019-01-22  Tom Tromey  <tom@tromey.com>
9309
9310         * source-cache.h (class source_cache) <get_source_lines,
9311         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9312
9313 2019-01-22  Tom Tromey  <tom@tromey.com>
9314
9315         * remote-fileio.h (struct remote_target): Declare.
9316
9317 2019-01-22  Tom Tromey  <tom@tromey.com>
9318
9319         * python/py-arch.c: Do not include py-ref.h.
9320         * python/py-bpevent.c: Do not include py-ref.h.
9321         * python/py-cmd.c: Do not include py-ref.h.
9322         * python/py-continueevent.c: Do not include py-ref.h.
9323         * python/py-event.h: Do not include py-ref.h.
9324         * python/py-evtregistry.c: Do not include py-ref.h.
9325         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9326         * python/py-frame.c: Do not include py-ref.h.
9327         * python/py-framefilter.c: Do not include py-ref.h.
9328         * python/py-function.c: Do not include py-ref.h.
9329         * python/py-infevents.c: Do not include py-ref.h.
9330         * python/py-linetable.c: Do not include py-ref.h.
9331         * python/py-objfile.c: Do not include py-ref.h.
9332         * python/py-param.c: Do not include py-ref.h.
9333         * python/py-prettyprint.c: Do not include py-ref.h.
9334         * python/py-progspace.c: Do not include py-ref.h.
9335         * python/py-symbol.c: Do not include py-ref.h.
9336         * python/py-symtab.c: Do not include py-ref.h.
9337         * python/py-type.c: Do not include py-ref.h.
9338         * python/py-unwind.c: Do not include py-ref.h.
9339         * python/py-utils.c: Do not include py-ref.h.
9340         * python/py-value.c: Do not include py-ref.h.
9341         * python/py-varobj.c: Do not include py-ref.h.
9342         * python/py-xmethods.c: Do not include py-ref.h.
9343         * python/python.c: Do not include py-ref.h.
9344         * varobj.c: Do not include py-ref.h.
9345
9346 2019-01-22  Tom Tromey  <tom@tromey.com>
9347
9348         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9349         keyword for bcache.
9350
9351 2019-01-22  Tom Tromey  <tom@tromey.com>
9352
9353         * compile/compile-cplus-types.c: Remove a comment by #include.
9354
9355 2019-01-22  Tom Tromey  <tom@tromey.com>
9356
9357         * compile/gcc-c-plugin.h: Include compile-internal.h.
9358
9359 2019-01-22  Tom Tromey  <tom@tromey.com>
9360
9361         * stabsread.c (EXTERN): Do not define.
9362         (symnum, next_symbol_text_func, processing_gcc_compilation)
9363         (within_function, global_sym_chain, global_stabs)
9364         (previous_stab_code, this_object_header_files)
9365         (n_this_object_header_files)
9366         (n_allocated_this_object_header_files): Define.
9367         * stabsread.h (EXTERN): Never define.  Use "extern".
9368
9369 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9370
9371         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9372         history_value.
9373
9374 2019-01-21  Tom Tromey  <tom@tromey.com>
9375
9376         * ui-out.c: Fix includes.
9377         * tui/tui-source.c: Fix includes.
9378         * target.c: Fix includes.
9379         * remote.c: Fix includes.
9380         * regcache.c: Fix includes.
9381         * python/py-block.c: Fix includes.
9382         * printcmd.c: Fix includes.
9383         * or1k-tdep.c: Fix includes.
9384         * mi/mi-main.c: Fix includes.
9385         * m32r-tdep.c: Fix includes.
9386         * csky-tdep.c: Fix includes.
9387         * compile/compile-cplus-types.c: Fix includes.
9388         * cli/cli-interp.c: Fix includes.
9389
9390 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9391
9392         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9393         for padding.
9394
9395 2019-01-16  Tom Tromey  <tom@tromey.com>
9396
9397         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9398         earlier.
9399         (struct objfile) <msymbols_range>: Move from top level.
9400         <msymbols>: New method.
9401         (class objfile_msymbols): Remove.
9402         * symtab.c (default_collect_symbol_completion_matches_break_on):
9403         Update.
9404         * symmisc.c (dump_msymbols): Update.
9405         * stabsread.c (scan_file_globals): Update.
9406         * objc-lang.c (info_selectors_command, info_classes_command)
9407         (find_methods): Update.
9408         * minsyms.c (find_solib_trampoline_target): Update.
9409         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9410         * coffread.c (coff_symfile_read): Update.
9411         * ada-lang.c (ada_lookup_simple_minsym)
9412         (ada_collect_symbol_completion_matches): Update.
9413
9414 2019-01-16  Tom Tromey  <tom@tromey.com>
9415
9416         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9417         type.  Remove no-argument constructor.
9418         <iterator::operator++>: Simplify.
9419         <begin>: Update.
9420         <end>: Use minimal_symbol_count.
9421
9422 2019-01-16  Tom Tromey  <tom@tromey.com>
9423
9424         * objfiles.h (struct objfile) <psymtabs>: New method.
9425         (class objfile_psymtabs): Remove.
9426         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9427         typedef.
9428         <range>: New method.
9429         (require_partial_symbols): Change return type.
9430         * psymtab.c (require_partial_symbols)
9431         (psym_expand_symtabs_matching): Update.
9432         * mdebugread.c (parse_partial_symbols): Update.
9433         * dbxread.c (dbx_end_psymtab): Update.
9434
9435 2019-01-15  Tom Tromey  <tom@tromey.com>
9436
9437         * symtab.c (lookup_objfile_from_block)
9438         (lookup_symbol_in_objfile_symtabs)
9439         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9440         (find_line_symtab, info_sources_command)
9441         (default_collect_symbol_completion_matches_break_on)
9442         (make_source_files_completion_list): Update.
9443         * symmisc.c (print_objfile_statistics, dump_objfile)
9444         (maintenance_print_symbols, maintenance_info_symtabs)
9445         (maintenance_check_symtabs, maintenance_info_line_tables):
9446         Update.
9447         * source.c (select_source_symtab)
9448         (forget_cached_source_info_for_objfile): Update.
9449         * objfiles.h (class objfile_compunits): Remove.
9450         (struct objfile) <compunits_range>: New typedef.
9451         (compunits): New method.
9452         * objfiles.c (objfile_relocate1): Update.
9453         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9454         * maint.c (count_symtabs_and_blocks): Update.
9455         * linespec.c (iterate_over_all_matching_symtabs): Update.
9456         * cp-support.c (add_symbol_overload_list_qualified): Update.
9457         * coffread.c (coff_symtab_read): Update.
9458         * ada-lang.c (add_nonlocal_symbols)
9459         (ada_collect_symbol_completion_matches)
9460         (ada_add_global_exceptions): Update.
9461
9462 2019-01-15  Tom Tromey  <tom@tromey.com>
9463
9464         * progspace.h (program_space) <objfiles_safe_range>: New
9465         typedef.
9466         <objfiles_safe>: New method.
9467         * objfiles.h (class all_objfiles_safe): Remove.
9468         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9469         * jit.c (jit_inferior_exit_hook): Update.
9470
9471 2019-01-17  Tom Tromey  <tom@tromey.com>
9472
9473         * progspace.h (program_space) <objfiles_range>: New typedef.
9474         <objfiles>: New method.
9475         <objfiles_head>: Rename from objfiles.
9476         (object_files): Update.
9477         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9478         * guile/scm-pretty-print.c
9479         (ppscm_find_pretty_printer_from_objfiles): Update.
9480         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9481         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9482         Update.
9483         * python/py-progspace.c (pspy_get_objfiles): Update.
9484         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9485         Update.
9486         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9487         (objfpy_lookup_objfile_by_build_id): Update.
9488         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9489         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9490         Update.
9491         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9492         (expand_symtab_containing_pc, lookup_objfile_from_block)
9493         (lookup_static_symbol, basic_lookup_transparent_type)
9494         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9495         (find_line_symtab, info_sources_command)
9496         (default_collect_symbol_completion_matches_break_on)
9497         (make_source_files_completion_list, find_main_name): Update.
9498         * symmisc.c (print_symbol_bcache_statistics)
9499         (print_objfile_statistics, maintenance_print_symbols)
9500         (maintenance_print_msymbols, maintenance_print_objfiles)
9501         (maintenance_info_symtabs, maintenance_check_symtabs)
9502         (maintenance_expand_symtabs, maintenance_info_line_tables):
9503         Update.
9504         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9505         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9506         (map_overlay_command, unmap_overlay_command)
9507         (simple_overlay_update, expand_symtabs_matching)
9508         (map_symbol_filenames): Update.
9509         * symfile-debug.c (set_debug_symfile): Update.
9510         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9511         Update.
9512         * source.c (select_source_symtab, forget_cached_source_info):
9513         Update.
9514         * solib.c (solib_read_symbols): Update.
9515         * solib-spu.c (append_ocl_sos): Update.
9516         * psymtab.c (maintenance_print_psymbols)
9517         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9518         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9519         * printcmd.c (info_symbol_command): Update.
9520         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9521         Update.
9522         * objfiles.h (class all_objfiles): Remove.
9523         * objfiles.c (have_partial_symbols, have_full_symbols)
9524         (have_minimal_symbols, qsort_cmp, update_section_map)
9525         (shared_objfile_contains_address_p)
9526         (default_iterate_over_objfiles_in_search_order): Update.
9527         * objc-lang.c (info_selectors_command, info_classes_command)
9528         (find_methods): Update.
9529         * minsyms.c (find_solib_trampoline_target): Update.
9530         * maint.c (maintenance_info_sections)
9531         (maintenance_translate_address, count_symtabs_and_blocks):
9532         Update.
9533         * main.c (captured_main_1): Update.
9534         * linux-thread-db.c (try_thread_db_load_from_pdir)
9535         (has_libpthread): Update.
9536         * linespec.c (iterate_over_all_matching_symtabs)
9537         (search_minsyms_for_name): Update.
9538         * jit.c (jit_find_objf_with_entry_addr): Update.
9539         * hppa-tdep.c (find_unwind_entry)
9540         (hppa_lookup_stub_minimal_symbol): Update.
9541         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9542         Update.
9543         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9544         (elf_gnu_ifunc_resolve_by_got): Update.
9545         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9546         * dwarf-index-write.c (save_gdb_index_command): Update.
9547         * cp-support.c (add_symbol_overload_list_qualified): Update.
9548         * breakpoint.c (create_overlay_event_breakpoint)
9549         (create_longjmp_master_breakpoint)
9550         (create_std_terminate_master_breakpoint)
9551         (create_exception_master_breakpoint): Update.
9552         * blockframe.c (find_pc_partial_function): Update.
9553         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9554         (ada_collect_symbol_completion_matches)
9555         (ada_add_global_exceptions): Update.
9556
9557 2019-01-17  Tom Tromey  <tom@tromey.com>
9558
9559         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9560         declare VEC.
9561         (solib_target_parse_libraries): Change return type.
9562         (library_list_start_segment, library_list_start_section)
9563         (library_list_end_library, library_list_start_library); Update.
9564         (solib_target_free_library_list): Remove.
9565         (solib_target_parse_libraries): Remove cleanup.  Change return
9566         type.
9567         (solib_target_current_sos): Update.
9568
9569 2019-01-17  Tom Tromey  <tromey@bapiya>
9570
9571         * valprint.c: Replace "the the" with "the".
9572         * symtab.c: Replace "the the" with "the".
9573         * solib.c: Replace "the the" with "the".
9574         * solib-dsbt.c: Replace "the the" with "the".
9575         * linespec.c: Replace "the the" with "the".
9576         * dwarf2loc.h: Replace "the the" with "the".
9577         * amd64-windows-tdep.c: Replace "the the" with "the".
9578         * aarch64-tdep.c: Replace "the the" with "the".
9579
9580 2019-01-16  Keith Seitz  <keiths@redhat.com>
9581
9582         PR gdb/23773
9583         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9584         <builder>: Rename to ..
9585         <m_builder>: ... this and make private.
9586         (dwarf2_cu::get_builder): New method.  Change all users of
9587         `builder' to use this method.
9588         (dwarf2_start_symtab): Move to ...
9589         (dwarf2_cu::start_symtab): ... here.  Update all callers
9590         (setup_type_unit_groups): Move to ...
9591         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9592         callers.
9593         (dwarf2_cu::reset_builder): New method.
9594         (process_full_compunit, process_full_type_unit): Use
9595         dwarf2_cu::reset_builder.
9596         (follow_die_offset): Record the ancestor CU if it is different
9597         from the followed DIE's CU.
9598         (follow_die_sig_1): Likewise.
9599
9600 2019-01-15  Tom Tromey  <tom@tromey.com>
9601
9602         * remote.c (class remote_state) <buf>: Now a char_vector.
9603         <buf_size>: Remove.
9604         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9605         parameter.
9606         (remote_target::getpkt_or_notif_sane_1)
9607         (remote_target::getpkt_sane)
9608         (remote_target::getpkt_or_notif_sane): Likewise.
9609         (class remote_target) <putpkt>: New overload.
9610         (remote_target::read_frame): Change type of "buf_p".  Remove
9611         sizeof_p parameter.
9612         (packet_ok): New overload.
9613         (packet_check_result): New overload.
9614         Update all uses.
9615
9616 2019-01-14  Tom Tromey  <tom@tromey.com>
9617
9618         * remote-notif.c (handle_notification, remote_notif_ack)
9619         (remote_notif_parse): Make "buf" const.
9620         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9621         const.
9622         (remote_notif_parse, remote_notif_ack, handle_notification):
9623         Likewise.
9624         * remote.c (remote_notif_stop_parse): Make "buf" const.
9625         (remote_target::remote_parse_stop_reply): Make "buf" const.
9626         (remote_notif_stop_ack): Make "buf" const.
9627
9628 2019-01-14  Tom Tromey  <tom@tromey.com>
9629
9630         * remote.c (remote_console_output): Make parameter const.
9631
9632 2019-01-14  Tom Tromey  <tom@tromey.com>
9633
9634         * target-debug.h (target_debug_print_signals): Constify.
9635         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9636         * procfs.c (procfs_target::pass_signals): Update.
9637         * linux-nat.c (linux_nat_target::pass_signals): Update.
9638         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9639         * target-delegates.c: Rebuild.
9640         * remote.c (remote_target::program_signals): Update.
9641         (remote_target::pass_signals): Update.
9642         * target.c (target_pass_signals): Constify argument.
9643         (target_program_signals): Likewise.
9644         * target.h (struct target_ops) <pass_signals, program_signals>:
9645         Constify argument.
9646         (target_pass_signals, target_program_signals): Constify argument.
9647
9648 2019-01-14  Tom Tromey  <tom@tromey.com>
9649
9650         PR tui/28819:
9651         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9652
9653 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9654
9655         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9656         field.
9657         * rs6000-tdep.c: Include reggroups.h.
9658         (IS_V_ALIAS_PSEUDOREG): Define.
9659         (rs6000_register_name): Return names for the "vX" aliases.
9660         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9661         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9662         aliases.  Call default_register_reggroup_p for all other
9663         pseudo-registers.
9664         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9665         New functions.
9666         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9667         Handle "vX" aliases.
9668         (v_alias_pseudo_register_collect): New function.
9669         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9670         (rs6000_gdbarch_init): Initialize "vX" aliases as
9671         pseudo-registers.  Restore registration of
9672         rs6000_pseudo_register_reggroup_p with
9673         set_tdesc_pseudo_register_reggroup_p.
9674
9675 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9676
9677         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9678         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9679         set_gdbarch_num_pseudo_regs.
9680
9681 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9682
9683         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9684         Remove arg prefixname, add do_set and do_show.
9685         Add member functions set_list and show_list.
9686         * cli/cli-style.c (class cli_style_option): Update accordingly.
9687         (style_set_list): Move to file scope.
9688         (style_show_list): Likewise.
9689         (set_style): Call help_list.
9690         (show_style): Call cmd_show_list.
9691         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9692         Update to use the new macro.
9693
9694 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9695
9696         * ada-lang.c (_initialize_ada_language): Expand the help text
9697         for the "catch exception" command.
9698
9699 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9700
9701         * symtab.c (matching_obj_sections): Initialize obj,
9702         declare it closer to its usage.
9703
9704 2019-01-10  Tom Tromey  <tom@tromey.com>
9705
9706         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9707         (basic_inf_threads_range): Remove.
9708         (inf_threads_range, inf_non_exited_threads_range)
9709         (safe_inf_threads_range): Use next_adapter.
9710
9711 2019-01-10  Keith Seitz  <keiths@redhat.com>
9712
9713         PR gdb/23712
9714         PR symtab/23010
9715         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9716         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9717
9718 2019-01-10  Keith Seitz  <keiths@redhat.com>
9719
9720         PR gdb/23712
9721         PR symtab/23010
9722         * dictionary.c (pending_to_vector): Remove.
9723         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9724         Remove _1 suffix, replacing functions of the same name.  Update
9725         all callers.
9726         (dict_create_hashed, dict_create_hashed_expandable)
9727         (dict_create_linear, dict_create_linear_expandable, dict_free)
9728         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9729         Make functions static.
9730
9731 2019-01-10  Keith Seitz  <keiths@redhat.com>
9732
9733         PR gdb/23712
9734         PR symtab/23010
9735         * dictionary.h (struct dictionary): Replace declaration with
9736         multidictionary.
9737         (dict_create_hashed, dict_create_hashed_expandable)
9738         (dict_create_linear, dict_create_linear_expandable)
9739         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9740         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9741         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9742         taking multidictionary argument.
9743         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9744         * block.h (struct block) <dict>: Change to multidictionary
9745         and rename `multidict'.
9746         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9747         symmisc.c: Update all dictionary references to multidictionary.
9748
9749 2019-01-10  Keith Seitz  <keiths@redhat.com>
9750
9751         PR gdb/23712
9752         PR symtab/23010
9753         * dictionary.c: Include unordered_map.
9754         (pending_to_vector): New function.
9755         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9756         Rewrite the non-"_1" functions to take vector instead
9757         of linked list.
9758         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9759         "new" _1 versions of the same name.
9760         (multidictionary): Define.
9761         (std::hash<enum language): New definition.
9762         (collate_pending_symbols_by_language, mdict_create_hashed)
9763         (mdict_create_hashed_expandable, mdict_create_linear)
9764         (mdict_create_linear_expandable, mdict_free)
9765         (find_language_dictionary, create_new_language_dictionary)
9766         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9767         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9768         (mdict_size, mdict_empty): New functions.
9769         * dictionary.h (mdict_iterator): Define.
9770
9771 2019-01-10  Pedro Alves  <palves@redhat.com>
9772
9773         * breakpoint.c (read_uploaded_action)
9774         (create_tracepoint_from_upload): Adjust to use
9775         gdb::unique_xmalloc_ptr.
9776         * ctf.c (ctf_write_uploaded_tp):
9777         (SET_ARRAY_FIELD): Use emplace_back.
9778         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9779         * tracefile-tfile.c (tfile_write_uploaded_tp):
9780         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9781         gdb::unique_xmalloc_ptr.
9782         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9783         at_string, cond_string, cmd_strings>: Replace char pointers
9784         with gdb::unique_xmalloc_ptr.
9785
9786 2019-01-10  Pedro Alves  <palves@redhat.com>
9787
9788         * solib-target.c (library_list_start_library): Don't xstrdup name.
9789
9790 2019-01-10  Pedro Alves  <palves@redhat.com>
9791
9792         * mdebugread.c (parse_partial_symbols): Use
9793         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9794
9795 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9796
9797         * linux-fork.c (scoped_switch_fork_info)
9798         <~scoped_switch_fork_info>: Fix incorrect variable name.
9799
9800 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9801
9802         * linux-fork.c (scoped_switch_fork_info)
9803         <scoped_switch_fork_info>: Make explicit.
9804         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9805
9806 2019-01-10  Tom Tromey  <tom@tromey.com>
9807
9808         * objfiles.h (objfile::reset_psymtabs): Update.
9809         * objfiles.c (objfile::objfile): Update.
9810         * psymtab.h (psymtab_storage::obstack): Update.
9811         (psymtab_storage::m_obstack): Use gdb::optional.
9812         (class psymtab_storage): Update comment.  Remove objfile
9813         parameter.
9814         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9815
9816 2019-01-10  Tom Tromey  <tom@tromey.com>
9817
9818         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9819         <free_psymtabs>: Now private.
9820         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9821         (allocate_psymtab): Use new method.
9822
9823 2019-01-10  Tom Tromey  <tom@tromey.com>
9824
9825         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9826         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9827         * mdebugread.c (parse_partial_symbols): Use
9828         allocate_dependencies.
9829         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9830         allocate_dependencies.
9831         (process_psymtab_comp_unit_reader)
9832         (build_type_psymtab_dependencies): Likewise.
9833         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9834
9835 2019-01-10  Tom Tromey  <tom@tromey.com>
9836
9837         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9838         PSYMBOL_SET_LANGUAGE.
9839         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9840
9841 2019-01-10  Tom Tromey  <tom@tromey.com>
9842
9843         * psymtab.h (psymtab_storage::obstack): New method.
9844         <m_obstack>: Rename from obstack; now private.
9845         * psymtab.c (psymtab_storage): Update.
9846         * dwarf2read.c (create_addrmap_from_index)
9847         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9848         Update.
9849
9850 2019-01-10  Tom Tromey  <tom@tromey.com>
9851
9852         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9853         * objfiles.h (objfile::reset_psymtabs): New method.
9854
9855 2019-01-10  Tom Tromey  <tom@tromey.com>
9856
9857         * symmisc.c (print_symbol_bcache_statistics): Update.
9858         (print_objfile_statistics): Update.
9859         * symfile.c (reread_symbols): Update.
9860         * psymtab.h (class psymtab_storage): New.
9861         * psymtab.c (psymtab_storage): New constructor.
9862         (~psymtab_storage): New destructor.
9863         (require_partial_symbols): Update.
9864         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9865         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9866         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9867         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9868         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9869         (start_psymtab_common, end_psymtab_common)
9870         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9871         (allocate_psymtab): Update.
9872         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9873         Update.
9874         (dump_psymtab_addrmap, maintenance_print_psymbols)
9875         (maintenance_check_psymtabs): Update.
9876         (class objfile_psymtabs): Move to objfiles.h.
9877         * psympriv.h (discard_psymtab): Now inline.
9878         (psymtab_discarder::psymtab_discarder): Update.
9879         (psymtab_discarder::~psymtab_discarder): Update.
9880         (ALL_OBJFILE_PSYMTABS): Rewrite.
9881         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9882         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9883         Remove fields.
9884         <partial_symtabs>: New field.
9885         (class objfile_psymtabs): Move from psymtab.h.  Update.
9886         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9887         psymbol_cache.
9888         (objfile::~objfile): Don't destroy psymbol_cache.
9889         * mdebugread.c (parse_partial_symbols): Update.
9890         * dwarf2read.c (create_addrmap_from_index)
9891         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9892         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9893         (add_partial_subprogram, dwarf2_ranges_read): Update.
9894         * dwarf-index-write.c (write_address_map)
9895         (write_one_signatured_type, recursively_write_psymbols)
9896         (class debug_names, class debug_names, write_psymtabs_to_index):
9897         Update.
9898
9899 2019-01-10  Tom Tromey  <tom@tromey.com>
9900
9901         * symtab.h (SYMBOL_SET_NAMES): Update.
9902         (symbol_set_names): Update.
9903         (MSYMBOL_SET_NAMES): Update.
9904         * symtab.c (symbol_set_names): Change argument to be an
9905         objfile_per_bfd_storage.
9906         * psymtab.c (add_psymbol_to_bcache): Update.
9907         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9908
9909 2019-01-10  Tom Tromey  <tom@tromey.com>
9910
9911         * symtab.c (create_demangled_names_hash): Change argument to be an
9912         objfile_per_bfd_storage.
9913         (symbol_set_names): Update.
9914
9915 2019-01-10  Tom Tromey  <tom@tromey.com>
9916
9917         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9918         init_psymbol_list.
9919         * psymtab.c (init_psymbol_list): Do nothing if already called.
9920         * psympriv.h (init_psymbol_list): Add comment.
9921         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9922         init_psymbol_list.
9923         * dbxread.c (dbx_symfile_read): Unconditionally call
9924         init_psymbol_list.
9925
9926 2019-01-10  Tom Tromey  <tom@tromey.com>
9927
9928         * xcoffread.c (scan_xcoff_symtab): Update.
9929         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9930         "where".
9931         * mdebugread.c (parse_partial_symbols)
9932         (handle_psymbol_enumerators): Update.
9933         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9934         * dbxread.c (read_dbx_symtab): Update.
9935         * psympriv.h (psymbol_placement): New enum.
9936         (add_psymbol_to_list): Update.
9937
9938 2019-01-10  Tom Tromey  <tom@tromey.com>
9939
9940         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9941         static_psymbols parameters.
9942         (scan_xcoff_symtab): Update.
9943         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9944         static_psymbols parameters.
9945         * psympriv.h (start_psymtab_common): Update.
9946         * mdebugread.c (parse_partial_symbols): Update.
9947         * dwarf2read.c (create_partial_symtab): Update.
9948         * dbxread.c (read_dbx_symtab): Update.
9949         (start_psymtab): Remove global_psymbols and static_psymbols
9950         parameters.
9951
9952 2019-01-10  Tom Tromey  <tom@tromey.com>
9953
9954         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9955         * psymtab.c (allocate_psymtab): Add comment.
9956         * psympriv.h (allocate_psymtab): Add comment.
9957         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9958         initializations.
9959         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9960
9961 2019-01-10  Tom Tromey  <tom@tromey.com>
9962
9963         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9964         Don't declare.
9965         * mipsread.c: Include mdebugread.h.
9966         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9967         Declare.
9968         * elfread.c: Include mdebugread.h.
9969
9970 2019-01-09  Tom Tromey  <tom@tromey.com>
9971
9972         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9973         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9974         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9975         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9976         (psym_lookup_symbol, psym_find_last_source_symtab)
9977         (psym_forget_cached_source_info, psym_print_stats)
9978         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9979         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9980         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9981         (psym_find_compunit_symtab_by_address)
9982         (maintenance_print_psymbols, maintenance_info_psymtabs)
9983         (maintenance_check_psymtabs): Use ranged for.
9984         * psymtab.h (class objfile_psymtabs): New.
9985         (require_partial_symbols): Return objfile_psymtabs.
9986         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9987
9988 2019-01-09  Tom Tromey  <tom@tromey.com>
9989
9990         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9991         (find_pc_mapped_section, list_overlays_command)
9992         (map_overlay_command, unmap_overlay_command)
9993         (simple_overlay_update): Use all_objfiles.
9994         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9995         * printcmd.c (info_symbol_command): Use all_objfiles.
9996         * objfiles.h (ALL_OBJSECTIONS): Remove.
9997         * maint.c (maintenance_translate_address): Use all_objfiles.
9998         * gcore.c (gcore_create_callback): Use all_objfiles.
9999         (objfile_find_memory_regions): Likewise.
10000
10001 2019-01-09  Tom Tromey  <tom@tromey.com>
10002
10003         * symtab.c (find_line_symtab, info_sources_command)
10004         (make_source_files_completion_list): Use objfile_compunits.
10005         * source.c (select_source_symtab): Use objfile_compunits.
10006         * objfiles.h (struct objfile): Update comment.
10007         (ALL_OBJFILES): Remove.
10008         (ALL_FILETABS): Remove.
10009         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10010         objfile_compunits.
10011
10012 2019-01-09  Tom Tromey  <tom@tromey.com>
10013
10014         * symmisc.c (print_objfile_statistics, dump_objfile)
10015         (maintenance_print_symbols): Use compunit_filetabs.
10016         * source.c (forget_cached_source_info_for_objfile): Use
10017         compunit_filetabs.
10018         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10019         (ALL_FILETABS): Use compunit_filetabs.
10020         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10021         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10022
10023 2019-01-09  Tom Tromey  <tom@tromey.com>
10024
10025         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10026         (compunit_filetabs): New.
10027         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10028         compunit_filetabs.
10029         (info_sources_command, make_source_files_completion_list): Remove
10030         declaration.
10031         * symmisc.c (print_objfile_statistics, dump_objfile)
10032         (maintenance_print_symbols): Remove declaration.
10033         (maintenance_info_symtabs): Use compunit_filetabs.
10034         (maintenance_info_line_tables): Likewise.
10035         * source.c (select_source_symtab): Change local variable name.
10036         (forget_cached_source_info_for_objfile): Remove declaration.
10037         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10038         * objfiles.c (objfile_relocate1): Remove declaration.
10039         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10040         declaration.
10041         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10042         * coffread.c (coff_symtab_read): Remove declaration.
10043         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10044         compunit_filetabs.
10045
10046 2019-01-09  Tom Tromey  <tom@tromey.com>
10047
10048         * symtab.c (lookup_objfile_from_block)
10049         (find_pc_sect_compunit_symtab, search_symbols)
10050         (default_collect_symbol_completion_matches_break_on): Use
10051         objfile_compunits.
10052         * objfiles.h (ALL_COMPUNITS): Remove.
10053         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10054         * cp-support.c (add_symbol_overload_list_qualified): Use
10055         objfile_compunits.
10056         * ada-lang.c (ada_collect_symbol_completion_matches)
10057         (ada_add_global_exceptions): Use objfile_compunits.
10058
10059 2019-01-09  Tom Tromey  <tom@tromey.com>
10060
10061         * source.c (select_source_symtab)
10062         (forget_cached_source_info_for_objfile): Remove declaration.
10063         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10064         declaration.
10065         * maint.c (count_symtabs_and_blocks): Remove declaration.
10066         * cp-support.c (add_symbol_overload_list_qualified): Remove
10067         declaration.
10068         * coffread.c (coff_symtab_read): Remove declaration.
10069         * symtab.c (lookup_symbol_in_objfile_symtabs)
10070         (basic_lookup_transparent_type_1): Use objfile_compunits.
10071         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10072         (info_sources_command, search_symbols)
10073         (default_collect_symbol_completion_matches_break_on)
10074         (make_source_files_completion_list): Remove declaration.
10075         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10076         (ada_collect_symbol_completion_matches)
10077         (ada_add_global_exceptions): Remove declaration.
10078         * linespec.c (iterate_over_all_matching_symtabs): Use
10079         objfile_compunits.
10080         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10081         (class objfile_compunits): New.
10082         (ALL_COMPUNITS): Use objfile_compunits.
10083         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10084         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10085         objfile_compunits.
10086         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10087
10088 2019-01-09  Tom Tromey  <tom@tromey.com>
10089
10090         * symtab.c (search_symbols)
10091         (default_collect_symbol_completion_matches_break_on): Use
10092         objfile_msymbols.
10093         * ada-lang.c (ada_lookup_simple_minsym)
10094         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10095         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10096         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10097         objfile_msymbols.
10098         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10099         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10100         * objc-lang.c (find_methods): Use objfile_msymbols.
10101         (info_selectors_command, info_classes_command): Likewise.
10102         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10103         * objfiles.h (class objfile_msymbols): New.
10104         (ALL_OBJFILE_MSYMBOLS): Remove.
10105         (ALL_MSYMBOLS): Remove.
10106
10107 2019-01-09  Tom Tromey  <tom@tromey.com>
10108
10109         * common/next-iterator.h (next_adapter): Add Iterator template
10110         parameter.
10111         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10112         (class all_objfiles_safe): New.
10113         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10114         * objfiles.c (put_objfile_before): Update comment.
10115         (add_separate_debug_objfile): Likewise.
10116         (free_all_objfiles): Use all_objfiles_safe.
10117         (objfile_purge_solibs): Likewise.
10118
10119 2019-01-09  Tom Tromey  <tom@tromey.com>
10120
10121         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10122         (expand_symtab_containing_pc, lookup_static_symbol)
10123         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10124         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10125         all_objfiles.
10126         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10127         * breakpoint.c (create_overlay_event_breakpoint)
10128         (create_longjmp_master_breakpoint)
10129         (create_std_terminate_master_breakpoint)
10130         (create_exception_master_breakpoint): Use all_objfiles.
10131         * linux-thread-db.c (try_thread_db_load_from_pdir)
10132         (has_libpthread): Use all_objfiles.
10133         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10134         * linespec.c (iterate_over_all_matching_symtabs)
10135         (search_minsyms_for_name): Use all_objfiles.
10136         * maint.c (maintenance_info_sections): Use all_objfiles.
10137         * main.c (captured_main_1): Use all_objfiles.
10138         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10139         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10140         * guile/scm-pretty-print.c
10141         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10142         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10143         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10144         (maintenance_print_msymbols): Use all_objfiles.
10145         * source.c (select_source_symtab): Use all_objfiles.
10146         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10147         * symfile.c (remove_symbol_file_command)
10148         (expand_symtabs_matching, map_symbol_filenames): Use
10149         all_objfiles.
10150         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10151         all_objfiles.
10152         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10153         * objc-lang.c (find_methods): Use all_objfiles.
10154         * objfiles.c (have_partial_symbols, have_full_symbols)
10155         (have_minimal_symbols, qsort_cmp)
10156         (default_iterate_over_objfiles_in_search_order): Use
10157         all_objfiles.
10158         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10159         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10160         (maintenance_check_psymtabs): Use all_objfiles.
10161         (ALL_PSYMTABS): Remove.
10162         * compile/compile-object-run.c (do_module_cleanup): Use
10163         all_objfiles.
10164         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10165         * cp-support.c (add_symbol_overload_list_qualified): Use
10166         all_objfiles.
10167         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10168         Use all_objfiles.
10169         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10170         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10171         all_objfiles.
10172         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10173         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10174         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10175         Uses all_objfiles.
10176         * solib.c (solib_read_symbols): Use all_objfiles
10177
10178 2019-01-09  Tom Tromey  <tom@tromey.com>
10179
10180         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10181         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10182         all_objfiles.
10183         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10184         * symmisc.c (print_symbol_bcache_statistics)
10185         (print_objfile_statistics, maintenance_print_objfiles)
10186         (maintenance_info_symtabs, maintenance_check_symtabs)
10187         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10188         all_objfiles.
10189         * source.c (forget_cached_source_info): Use all_objfiles.
10190         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10191         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10192         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10193         * objfiles.c (update_section_map): Use all_objfiles.
10194         (shared_objfile_contains_address_p): Likewise.
10195         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10196         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10197
10198 2019-01-09  Tom Tromey  <tom@tromey.com>
10199
10200         * common/next-iterator.h: New file.
10201         * objfiles.h (class all_objfiles): New.
10202         (struct objfile_iterator): New.
10203
10204 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10205
10206         * NEWS: Move the description of the changed "frame", "select-frame",
10207          and "info frame" commands to the Changed commands section.
10208
10209 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10210
10211         * gdbtypes.c (check_stub_method_group): Remove handling of old
10212         mangling schemes.
10213         * linespec.c (find_methods): Likewise.
10214         * stabsread.c (read_member_functions): Likewise.
10215         * valops.c (search_struct_method): Likewise.
10216         (value_struct_elt_for_reference): Likewise.
10217         * NEWS: Mention this change.
10218
10219 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10220
10221         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10222         print_source_lines.
10223         * source.c (print_source_lines_base): Update line number check.
10224         (print_source_lines): New function.
10225         (source_lines_range::source_lines_range): New function.
10226         * source.h (class source_lines_range): New class.
10227         (print_source_lines): New declaration.
10228
10229 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10230
10231         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10232
10233 2019-01-08  Tom Tromey  <tom@tromey.com>
10234             Simon Marchi  <simon.marchi@ericsson.com>
10235
10236         PR gdb/24060
10237         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10238         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10239         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10240         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10241         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10242         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10243
10244 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10245
10246         * source.c (select_source_symtab): Move header comment to
10247         declaration in source.h.
10248         (forget_cached_source_info_for_objfile): Likewise.
10249         (forget_cached_source_info): Likewise.
10250         (identify_source_line): Likewise.
10251         * source.h (identify_source_line): Move declaration from symtab.h
10252         and add comment from source.c
10253         (print_source_lines): Likewise.
10254         (forget_cached_source_info_for_objfile): Likewise.
10255         (forget_cached_source_info): Likewise.
10256         (select_source_symtab): Likewise.
10257         (enum print_source_lines_flag): Move definition from symtab.h.
10258         * symtab.h (identify_source_line): Move declaration to source.h.
10259         (print_source_lines): Likewise.
10260         (forget_cached_source_info_for_objfile): Likewise.
10261         (forget_cached_source_info): Likewise.
10262         (select_source_symtab): Likewise.
10263         (enum print_source_lines_flag): Move definition to source.h.
10264         * tui/tui-hooks.c: Add 'source.h' include.
10265
10266 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10267
10268         * source.c (print_source_lines_base): Handle requests to print
10269         reverse line number sequences, and guard against empty lines
10270         string.
10271
10272 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10273
10274         * source.c (print_source_lines_base): Fix skip of '\r' if next
10275         character is '\n'.
10276
10277 2019-01-06  Tom Tromey  <tom@tromey.com>
10278
10279         * c-exp.y (struct c_parse_state) <macro_original_text,
10280         expansion_obstack>: New member.
10281         (macro_original_text, expansion_obstack): Remove globals.
10282         (scan_macro_expansion, scanning_macro_expansion)
10283         (finished_macro_expansion): Update.
10284         (scan_macro_cleanup): Remove.
10285         (yylex, c_parse): Update.
10286
10287 2019-01-06  Tom Tromey  <tom@tromey.com>
10288
10289         * c-exp.y (struct c_parse_state) <strings>: New member.
10290         (operator_stoken): Update.
10291
10292 2019-01-06  Tom Tromey  <tom@tromey.com>
10293
10294         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10295         (union type_stack_elt) <typelist_val>: Now a pointer to
10296         std::vector.
10297         (type_stack_cleanup): Don't declare.
10298         (push_typelist): Update.
10299         * parse.c (pop_typelist): Return a std::vector.
10300         (push_typelist): Take a std::vector.
10301         (follow_types): Update.  Do not free args.
10302         (type_stack_cleanup): Remove.
10303         * c-exp.y (struct c_parse_state): New.
10304         (cpstate): New global.
10305         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10306         (nonempty_typelist): Update.
10307         (func_mod): Create a new vector.
10308         (c_parse): Create a c_parse_state.
10309         (check_parameter_typelist): Do not delete params.
10310         (function_method): Update.  Do not delete type_list.
10311
10312 2019-01-06  Tom Tromey  <tom@tromey.com>
10313
10314         PR gdb/28155:
10315         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10316         check_typedef.
10317         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10318         (print_return_value): Likewise.
10319
10320 2019-01-05  Tom Tromey  <tom@tromey.com>
10321
10322         * contrib/cleanup_check.py: Remove.
10323         * contrib/gcc-with-excheck: Remove.
10324         * contrib/exsummary.py: Remove.
10325         * contrib/excheck.py: Remove.
10326
10327 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10328
10329         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10330         NULL. Initialize tpprev to NULL instead of assigning it
10331         to NULL on the next statement.
10332         * windows-nat.c (windows_delete_thread): Remove check for
10333         main_thread_id before printing thread exit notifications.
10334         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10335         Remove thread ID check against main_thread_id.
10336         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10337         windows_delete_thread.
10338         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10339
10340 2019-01-04  Tom Tromey  <tom@tromey.com>
10341
10342         * compile/compile.c (_initialize_compile): Use upper case for
10343         metasyntactic variables.
10344         * symmisc.c (_initialize_symmisc): Use upper case for
10345         metasyntactic variables.
10346         * psymtab.c (_initialize_psymtab): Use upper case for
10347         metasyntactic variables.
10348         * demangle.c (demangle_command): Use upper case for metasyntactic
10349         variables.
10350         (_initialize_demangler): Likewise.
10351         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10352         variables.
10353
10354 2019-01-03  Tom Tromey  <tom@tromey.com>
10355
10356         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10357
10358 2019-01-03  Tom Tromey  <tom@tromey.com>
10359
10360         * python/py-symtab.c (salpy_str): Update.
10361         (struct salpy_sal_object) <symtab>: Now a PyObject.
10362         (salpy_dealloc): Update.
10363         (del_objfile_sal): Use gdbpy_ref.
10364
10365 2019-01-03  Tom Tromey  <tom@tromey.com>
10366
10367         * python/py-type.c (convert_field): Use new_reference.  Return
10368         gdbpy_ref.
10369         (make_fielditem): Return gdbpy_ref.
10370         (typy_fields): Update.
10371         (typy_getitem): Update.
10372         (field_name): Return gdbpy_ref.  Use new_reference.
10373         (typy_iterator_iternext): Update.
10374
10375 2019-01-03  Tom Tromey  <tom@tromey.com>
10376
10377         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10378
10379 2019-01-03  Tom Tromey  <tom@tromey.com>
10380
10381         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10382         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10383         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10384         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10385         (pspy_set_type_printers): Likewise.
10386         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10387         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10388         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10389         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10390         (objfpy_set_type_printers): Likewise.
10391
10392 2019-01-03  Tom Tromey  <tom@tromey.com>
10393
10394         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10395         (gdbpy_print_stack): Use gdbpy_err_fetch.
10396         * python/python-internal.h (class gdbpy_err_fetch): New class.
10397         (class gdbpy_enter) <m_error_type, m_error_value,
10398         m_error_traceback>: Remove.
10399         <m_error>: New member.
10400         (gdbpy_exception_to_string): Don't declare.
10401         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10402         * python/py-value.c (convert_value_from_python): Use
10403         gdbpy_err_fetch.
10404         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10405         gdbpy_exception_to_string.
10406         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10407         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10408         gdbpy_err_fetch.
10409
10410 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10411
10412         * linux-nat.c (delete_lwp_cleanup): Delete.
10413         (struct lwp_deleter): New struct.
10414         (lwp_info_up): New typedef.
10415         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10416         lwp_info_up.
10417
10418 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10419
10420         * linux-fork.c (class scoped_switch_fork_info): New class.
10421         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10422
10423 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10424
10425         * valops.c (find_overload_match): Remove use of null_cleanup, and
10426         calls to do_cleanups.
10427
10428 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10429
10430         * compile/compile-cplus-types.c
10431         (compile_cplus_instance::decl_name): Handle changes to
10432         cp_func_name.
10433         * cp-support.c (cp_func_name): Update header comment, update
10434         return type.
10435         * cp-support.h (cp_func_name): Update return type in declaration.
10436         * valops.c (find_overload_match): Move temp_func local to top
10437         level of function and change its type.  Use temp_func to hold and
10438         delete temporary string obtained from cp_func_name.
10439
10440 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10441
10442         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10443         gdb::char_vector, remove cleanup, and update uses of `msg`.
10444
10445 2019-01-03  Jim Wilson  <jimw@sifive.com>
10446
10447         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10448
10449 2019-01-02  Tom Tromey  <tom@tromey.com>
10450
10451         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10452         (tdesc_parse_xml): Remove cleanups.
10453         * target-descriptions.h (make_cleanup_free_target_description):
10454         Don't declare.
10455         (target_desc_deleter): New struct.
10456         (target_desc_up): New typedef.
10457         * target-descriptions.c (target_desc_deleter::operator()): Rename
10458         from free_target_description.
10459         (make_cleanup_free_target_description): Remove.
10460
10461 2019-01-02  Tom Tromey  <tom@tromey.com>
10462
10463         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10464         constructor, destructor.
10465         (linespec_parser): Remove typedef.
10466         (~linespec_parser): Rename from linespec_parser_delete.
10467         (linespec_lex_to_end, linespec_complete_label)
10468         (linespec_complete): Update.
10469         (decode_line_full): Remove cleanups.
10470         (decode_line_1): Update.
10471
10472 2019-01-02  Tom Tromey  <tom@tromey.com>
10473
10474         * python/python-internal.h (inferior_to_inferior_object): Change
10475         return type.
10476         * python/py-exitedevent.c (create_exited_event_object): Update.
10477         * python/py-inferior.c (inferior_to_inferior_object): Return
10478         gdbpy_ref.
10479         (python_new_inferior, python_inferior_deleted)
10480         (thread_to_thread_object, delete_thread_object)
10481         (build_inferior_list, gdbpy_selected_inferior): Update.
10482         * python/py-infthread.c (create_thread_object): Update.  Also fail
10483         if inferior_to_inferior_object fails.
10484
10485 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10486
10487         * inferior.h (class inferior) <displaced_step_state>: New field.
10488         * infrun.h (struct displaced_step_state): Move here from
10489         infrun.c.  Initialize fields, add constructor.
10490         <inf>: Remove field.
10491         <reset>: New method.
10492         * infrun.c (struct displaced_step_inferior_state): Move to
10493         infrun.h.
10494         (displaced_step_inferior_states): Remove.
10495         (get_displaced_stepping_state): Adust.
10496         (displaced_step_in_progress_any_inferior): Adjust.
10497         (displaced_step_in_progress_thread): Adjust.
10498         (displaced_step_in_progress): Adjust.
10499         (add_displaced_stepping_state): Remove.
10500         (get_displaced_step_closure_by_addr): Adjust.
10501         (remove_displaced_stepping_state): Remove.
10502         (infrun_inferior_exit): Call displaced_step_state.reset.
10503         (use_displaced_stepping): Don't check for NULL.
10504         (displaced_step_prepare_throw): Call
10505         get_displaced_stepping_state.
10506         (displaced_step_fixup): Don't check for NULL.
10507         (prepare_for_detach): Don't check for NULL.
10508
10509 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10510
10511         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10512          in case of call that did not complete.
10513
10514 2019-01-02  Andrey Utkin  <autkin@undo.io>
10515
10516         * symfile.c (find_separate_debug_file): Fix search of debug files for
10517         remote debuggee.
10518
10519 2019-01-02  Tom Tromey  <tom@tromey.com>
10520
10521         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10522         indentation.
10523         * python/py-frame.c (frapy_older): Remove cast.
10524         (frapy_newer): Likewise.
10525         * python/py-breakpoint.c (local_setattro): Remove cast.
10526         * python/py-arch.c (archpy_name): Remove local variable.
10527         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10528
10529 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10530
10531         * unittests/basic_string_view/element_access/char/empty.cc:
10532         Fix year range in copyright header.
10533
10534 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10535
10536         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10537         Delete.
10538         <operator==>: Update with for removed field.
10539         <hash>: Likewise.
10540         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10541         <isa_features>: ...this.
10542         <abi_features>: New field.
10543         (riscv_isa_flen): Update comment.
10544         (riscv_abi_xlen): New declaration.
10545         (riscv_abi_flen): New declaration.
10546         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10547         isa_features.
10548         (riscv_abi_xlen): New function.
10549         (riscv_isa_flen): Update to get answer from isa_features.
10550         (riscv_abi_flen): New function.
10551         (riscv_has_fp_abi): Update to get answer from abi_features.
10552         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10553         xlen and flen.
10554         (riscv_call_info) <xlen, flen>: Update comment.
10555         (riscv_call_arg_struct): Remove invalid assertions
10556         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10557         is removed.
10558         (riscv_gdbarch_init): Gather isa features and abi features
10559         separately, ensure both match on the gdbarch when reusing an old
10560         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10561         a target with 64-bit float hardware.
10562
10563 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10564
10565         * source.c (search_command_helper): Stop reverse search
10566         when line 1 has been searched.
10567
10568 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10569
10570         * record-full.c (record_full_base_target::close): Rewrite
10571         record_full_core_buf_list free logic.
10572
10573 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10574
10575         * break-catch-syscall.c (print_one_catch_syscall): xfree
10576         the last text.
10577
10578 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10579
10580         * top.c (print_gdb_version): Update Copyright year in version
10581         message.
10582
10583 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10584
10585         Update copyright year range in all GDB files.
10586
10587 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10588
10589         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10590
10591 For older changes see ChangeLog-2018.
10592 \f
10593 Local Variables:
10594 mode: change-log
10595 left-margin: 8
10596 fill-column: 74
10597 version-control: never
10598 coding: utf-8
10599 End:
10600