gdbserver: Ensure all debug output uses debug functions
[external/binutils.git] / gdb / ChangeLog
1 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2
3         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4
5 2019-04-17  Jim Wilson  <jimw@sifive.com>
6             Andrew Burgess  <andrew.burgess@embecosm.com>
7
8         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9         code read might fail, assume 4-byte breakpoint in that case.
10
11 2019-04-15  Leszek Swirski  <leszeks@google.com>
12
13         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
14         rather than a hand-rolled POD check when checking for forced MEMORY
15         classification.
16
17 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
18
19         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
20         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
21         function.
22         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
23         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
24         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
25         declaration.
26
27 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
28
29         * aarch64-linux-nat.c
30         (aarch64_linux_nat_target::thread_architecture): Add override.
31         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
32         each VQ.
33
34 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
35
36         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
37
38 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
39
40         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
41         target types of size 96-bits, add some additional comments, and
42         check that the builtin type we found was the correct size.
43
44 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
45
46         * utils.c (prompt_for_continue): Don't restore the styling at the
47         end, as applied_style has the wrong value.  This fixes styling in
48         long lists of file names that are interrupted by the "Continue?"
49         prompt.
50
51 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
52
53         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
54         * c-lang.c (c_language_defn): Likewise.
55         (cplus_language_defn): Likewise.
56         (asm_language_defn): Likewise.
57         (minimal_language_defn): Likewise.
58         * d-lang.c (d_language_defn): Likewise.
59         * f-lang.c (f_language_defn): Likewise.
60         * go-lang.c (go_language_defn): Likewise.
61         * language.c (unknown_language_defn): Likewise.
62         (auto_language_defn): Likewise.
63         * language.h (struct language_defn): Remove la_magic field.
64         (LANG_MAGIC): Delete.
65         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
66         * objc-lang.c (objc_language_defn): Likewise.
67         * opencl-lang.c (opencl_language_defn): Likewise.
68         * p-lang.c (pascal_language_defn): Likewise.
69         * rust-lang.c (rust_language_defn): Likewise.
70
71 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
72
73         * riscv-tdep.c (riscv_type_align): New function.
74         (riscv_type_alignment): Delete.
75         (riscv_arg_location): Use 'type_align'.
76         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
77
78 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
79
80         * gdbtypes.c (type_align): A struct with no non-static fields also
81         has alignment of 1.
82
83 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
84
85         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
86         component to 0.
87         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
88         member.
89         (riscv_struct_info::analyse): New implementation using new
90         analyse_inner member function.
91         (riscv_struct_info::field_offset): New member function.
92         (riscv_struct_info::m_offsets): New member variable.
93         (riscv_struct_info::analyse_inner): New private member function,
94         takes the old implementation of riscv_struct_info::analyse but
95         extended to track field offsets.
96         (riscv_call_arg_struct): Update the struct folding special cases
97         to handle cases where empty C++ structs, which are non-zero
98         length, are found.
99         (riscv_arg_location): Initialise the length of each location, a
100         non-zero length now indicates the location is in use.
101         (riscv_push_dummy_call): Allow for the first location having a
102         non-zero offset when setting up arguments.
103         (riscv_return_value): Likewise, but for return values.
104
105 2019-04-11  Tom Tromey  <tromey@adacore.com>
106
107         * utils.c (internal_vproblem): Make "msg" const.
108
109 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
110
111         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
112         * trad-frame.c (trad_frame_reset_saved_regs): New function.
113         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
114         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
115
116 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
117
118         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
119         function.
120         (fill_gregset): Call amd64_linux_collect_native_gregset instead
121         of amd64_collect_native_gregset.
122         (amd64_linux_nat_target::store_registers): Likewise.
123
124 2019-04-10  Tom Tromey  <tom@tromey.com>
125
126         * symtab.c (lookup_global_symbol_from_objfile)
127         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
128         * objfiles.h (class separate_debug_iterator): New.
129         (class separate_debug_range): New.
130         (struct objfile) <separate_debug_objfiles>: New method.
131         (objfile_separate_debug_iterate): Don't declare.
132         * objfiles.c (separate_debug_iterator::operator++): Rename from
133         objfile_separate_debug_iterate.
134         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
135         iterator.
136         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
137         iterator.
138
139 2019-04-10  Tom Tromey  <tom@tromey.com>
140
141         * symfile.c (reread_symbols): Remove old comment.
142         * objfiles.c (free_all_objfiles): Fix a typo.
143
144 2019-04-10  Tom Tromey  <tom@tromey.com>
145
146         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
147         * minsyms.c (lookup_minimal_symbol): Use foreach.
148         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
149         (lookup_minimal_symbol_solib_trampoline): Likewise.
150         * symfile.c (reread_symbols): Use foreach.
151
152 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
153             Tom Tromey  <tromey@adacore.com>
154
155         PR rust/24414:
156         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
157         (rust_lex_int_test): Change "value" to be LONGEST.
158         (rust_lex_tests): Add test for long integer literal.
159
160 2019-04-09  Tom Tromey  <tromey@adacore.com>
161
162         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
163         to bool.
164         (extended_remote_target::attach): Update.
165         (remote_target::remote_notice_new_inferior): Update.
166         (remote_target::add_current_inferior_and_thread): Update.
167         * inferior.c (exit_inferior_1): Use "false".
168         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
169
170 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
171
172         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
173         the "start" command.
174
175 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
176
177         * python/py-inferior.c (infpy_thread_from_thread_handle):
178         Adjust comments to reflect renaming of thread_from_thread_handle
179         to thread_from_handle.  Adjust keywords.  Fix type error message.
180         (inferior_object_methods): Add thread_from_handle.  Retain
181         thread_from_thread_handle, but mark it as deprecated.
182
183 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
184
185         * gdbthread.h (find_thread_by_handle): Revise declaration.
186         * thread.c (find_thread_by_handle): Likewise.  Adjust
187         implementation too.
188         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
189         support for buffer objects as handles.
190
191 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
192
193         * python/py-infthread.c (thpy_thread_handle): New function.
194         (thread_object_methods): Register thpy_thread_handle.
195
196 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
197
198         * gdbthread.h (thread_to_thread_handle): Declare.
199         * thread.c (gdbtypes.h): Include.
200         (thread_to_thread_handle): New function.
201
202         * target.h (struct target_ops): Add thread_info_to_thread_handle.
203         (target_thread_info_to_thread_handle): Declare.
204         * target.c (target_thread_info_to_thread_handle): New function.
205         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
206         * target-delegates.c: Regenerate.
207
208         * linux-thread-db.c (class thread_db_target): Add method
209         thread_info_to_thread_handle.
210         (thread_db_target::thread_info_to_thread_handle): Define.
211         * remote.c (class remote_target): Add new method
212         thread_info_to_thread_handle.
213         (remote_target::thread_info_to_thread_handle): Define.
214
215 2019-04-08  Pedro Alves  <palves@redhat.com>
216
217         * common/common-exceptions.c (throw_exception): Don't create
218         named object to throw; throw directly.
219         (throw_it): Likewise.  Don't initialize gdb_exception::message
220         here, with new; pass FMT and AP to the ctor instead.
221         * common/common-exceptions.h: Include <string>.
222         (gdb_exception::gdb_exception(enum return_reason, enum errors,
223         const char *, va_list)): New ctor.  Use std::make_shared.
224         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
225         errors)): Delete.
226         (gdb_exception_error::gdb_exception_error(enum errors, const char
227         *, va_list)): New.
228         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
229         Add assertion.
230         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
231         errors)): Delete.
232         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
233         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
234         Add assertion.
235
236 2019-04-08  Tom Tromey  <tom@tromey.com>
237
238         * valops.c (value_rtti_indirect_type): Replace throw_exception
239         with throw.
240         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
241         with throw.
242         * thread.c (thr_try_catch_cmd): Replace throw_exception with
243         throw.
244         * target.c (target_translate_tls_address): Replace throw_exception
245         with throw.
246         * stack.c (frame_apply_command_count): Replace throw_exception
247         with throw.
248         * solib-spu.c (append_ocl_sos): Replace throw_exception with
249         throw.
250         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
251         with throw.
252         * rs6000-tdep.c (rs6000_frame_cache)
253         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
254         * remote.c: Replace throw_exception with throw.
255         * record-full.c (record_full_message, record_full_wait_1)
256         (record_full_restore): Replace throw_exception with throw.
257         * record-btrace.c:
258         (get_thread_current_frame_id, record_btrace_start_replaying)
259         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
260         (cmd_record_btrace_start): Replace throw_exception with throw.
261         * parse.c (parse_exp_in_context_1): Replace throw_exception with
262         throw.
263         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
264         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
265         * linespec.c:
266         (find_linespec_symbols): Replace throw_exception with throw.
267         * infrun.c (displaced_step_prepare, resume): Replace
268         throw_exception with throw.
269         * infcmd.c (post_create_inferior): Replace throw_exception with
270         throw.
271         * inf-loop.c (inferior_event_handler): Replace throw_exception
272         with throw.
273         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
274         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
275         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
276         (get_prev_frame_always, get_frame_pc_if_available)
277         (get_frame_address_in_block_if_available, get_frame_language):
278         Replace throw_exception with throw.
279         * frame-unwind.c (frame_unwind_try_unwinder): Replace
280         throw_exception with throw.
281         * eval.c (fetch_subexp_value, evaluate_var_value)
282         (evaluate_funcall, evaluate_subexp_standard): Replace
283         throw_exception with throw.
284         * dwarf2loc.c (call_site_find_chain)
285         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
286         Replace throw_exception with throw.
287         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
288         with throw.
289         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
290         throw.
291         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
292         * completer.c (complete_line_internal): Replace throw_exception
293         with throw.
294         * compile/compile-object-run.c (compile_object_run): Replace
295         throw_exception with throw.
296         * cli/cli-script.c (process_next_line): Replace throw_exception
297         with throw.
298         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
299         (btrace_enable, btrace_maint_update_pt_packets): Replace
300         throw_exception with throw.
301         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
302         throw_exception with throw.
303         * break-catch-throw.c (re_set_exception_catchpoint): Replace
304         throw_exception with throw.
305         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
306         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
307         * aarch64-tdep.c (aarch64_make_prologue_cache)
308         (aarch64_make_stub_cache): Replace throw_exception with throw.
309
310 2019-04-08  Tom Tromey  <tom@tromey.com>
311
312         * common/common-exceptions.c (throw_exception): Rename from
313         throw_exception_cxx.  Remove old copy.  Make argument const.
314         (throw_it): Create and throw exception objects directly.
315         * common/common-exceptions.h (throw_exception): Make argument
316         const.
317         (struct gdb_exception_error): Add constructor.
318         (struct gdb_exception_quit): Add constructor.
319
320 2019-04-08  Tom Tromey  <tom@tromey.com>
321
322         * common/common-exceptions.h (exception_rethrow): Don't declare.
323         (TRY_SJLJ): Update comment.
324         (TRY, CATCH, END_CATCH): Remove.
325         * common/common-exceptions.c (exception_rethrow): Remove.
326
327 2019-04-08  Tom Tromey  <tom@tromey.com>
328
329         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
330         Remove.
331         (gdb_exception_error): Rename from
332         gdb_exception_RETURN_MASK_ERROR.
333         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
334         (gdb_quit_bad_alloc): Update.
335         * aarch64-tdep.c: Update.
336         * ada-lang.c: Update.
337         * ada-typeprint.c: Update.
338         * ada-valprint.c: Update.
339         * amd64-tdep.c: Update.
340         * arch-utils.c: Update.
341         * break-catch-throw.c: Update.
342         * breakpoint.c: Update.
343         * btrace.c: Update.
344         * c-varobj.c: Update.
345         * cli/cli-cmds.c: Update.
346         * cli/cli-interp.c: Update.
347         * cli/cli-script.c: Update.
348         * common/common-exceptions.c: Update.
349         * common/new-op.c: Update.
350         * common/selftest.c: Update.
351         * compile/compile-c-symbols.c: Update.
352         * compile/compile-cplus-symbols.c: Update.
353         * compile/compile-object-load.c: Update.
354         * compile/compile-object-run.c: Update.
355         * completer.c: Update.
356         * corelow.c: Update.
357         * cp-abi.c: Update.
358         * cp-support.c: Update.
359         * cp-valprint.c: Update.
360         * darwin-nat.c: Update.
361         * disasm-selftests.c: Update.
362         * dtrace-probe.c: Update.
363         * dwarf-index-cache.c: Update.
364         * dwarf-index-write.c: Update.
365         * dwarf2-frame-tailcall.c: Update.
366         * dwarf2-frame.c: Update.
367         * dwarf2loc.c: Update.
368         * dwarf2read.c: Update.
369         * eval.c: Update.
370         * event-loop.c: Update.
371         * event-top.c: Update.
372         * exec.c: Update.
373         * f-valprint.c: Update.
374         * fbsd-tdep.c: Update.
375         * frame-unwind.c: Update.
376         * frame.c: Update.
377         * gdbtypes.c: Update.
378         * gnu-v3-abi.c: Update.
379         * guile/guile-internal.h: Update.
380         * guile/scm-block.c: Update.
381         * guile/scm-breakpoint.c: Update.
382         * guile/scm-cmd.c: Update.
383         * guile/scm-disasm.c: Update.
384         * guile/scm-frame.c: Update.
385         * guile/scm-lazy-string.c: Update.
386         * guile/scm-math.c: Update.
387         * guile/scm-param.c: Update.
388         * guile/scm-ports.c: Update.
389         * guile/scm-pretty-print.c: Update.
390         * guile/scm-symbol.c: Update.
391         * guile/scm-symtab.c: Update.
392         * guile/scm-type.c: Update.
393         * guile/scm-value.c: Update.
394         * i386-linux-tdep.c: Update.
395         * i386-tdep.c: Update.
396         * inf-loop.c: Update.
397         * infcall.c: Update.
398         * infcmd.c: Update.
399         * infrun.c: Update.
400         * jit.c: Update.
401         * language.c: Update.
402         * linespec.c: Update.
403         * linux-fork.c: Update.
404         * linux-nat.c: Update.
405         * linux-tdep.c: Update.
406         * linux-thread-db.c: Update.
407         * main.c: Update.
408         * mi/mi-cmd-break.c: Update.
409         * mi/mi-cmd-stack.c: Update.
410         * mi/mi-interp.c: Update.
411         * mi/mi-main.c: Update.
412         * objc-lang.c: Update.
413         * p-valprint.c: Update.
414         * parse.c: Update.
415         * ppc-linux-tdep.c: Update.
416         * printcmd.c: Update.
417         * python/py-arch.c: Update.
418         * python/py-breakpoint.c: Update.
419         * python/py-cmd.c: Update.
420         * python/py-finishbreakpoint.c: Update.
421         * python/py-frame.c: Update.
422         * python/py-framefilter.c: Update.
423         * python/py-gdb-readline.c: Update.
424         * python/py-inferior.c: Update.
425         * python/py-infthread.c: Update.
426         * python/py-lazy-string.c: Update.
427         * python/py-linetable.c: Update.
428         * python/py-objfile.c: Update.
429         * python/py-param.c: Update.
430         * python/py-prettyprint.c: Update.
431         * python/py-progspace.c: Update.
432         * python/py-record-btrace.c: Update.
433         * python/py-record.c: Update.
434         * python/py-symbol.c: Update.
435         * python/py-type.c: Update.
436         * python/py-unwind.c: Update.
437         * python/py-utils.c: Update.
438         * python/py-value.c: Update.
439         * python/python.c: Update.
440         * record-btrace.c: Update.
441         * record-full.c: Update.
442         * remote-fileio.c: Update.
443         * remote.c: Update.
444         * riscv-tdep.c: Update.
445         * rs6000-aix-tdep.c: Update.
446         * rs6000-tdep.c: Update.
447         * rust-exp.y: Update.
448         * rust-lang.c: Update.
449         * s390-tdep.c: Update.
450         * selftest-arch.c: Update.
451         * solib-dsbt.c: Update.
452         * solib-frv.c: Update.
453         * solib-spu.c: Update.
454         * solib-svr4.c: Update.
455         * solib.c: Update.
456         * sparc64-linux-tdep.c: Update.
457         * stack.c: Update.
458         * symfile-mem.c: Update.
459         * symmisc.c: Update.
460         * target.c: Update.
461         * thread.c: Update.
462         * top.c: Update.
463         * tracefile-tfile.c: Update.
464         * tui/tui.c: Update.
465         * typeprint.c: Update.
466         * unittests/cli-utils-selftests.c: Update.
467         * unittests/parse-connection-spec-selftests.c: Update.
468         * valops.c: Update.
469         * valprint.c: Update.
470         * value.c: Update.
471         * varobj.c: Update.
472         * windows-nat.c: Update.
473         * x86-linux-nat.c: Update.
474         * xml-support.c: Update.
475
476 2019-04-08  Tom Tromey  <tom@tromey.com>
477
478         * xml-support.c: Use C++ exception handling.
479         * x86-linux-nat.c: Use C++ exception handling.
480         * windows-nat.c: Use C++ exception handling.
481         * varobj.c: Use C++ exception handling.
482         * value.c: Use C++ exception handling.
483         * valprint.c: Use C++ exception handling.
484         * valops.c: Use C++ exception handling.
485         * unittests/parse-connection-spec-selftests.c: Use C++ exception
486         handling.
487         * unittests/cli-utils-selftests.c: Use C++ exception handling.
488         * typeprint.c: Use C++ exception handling.
489         * tui/tui.c: Use C++ exception handling.
490         * tracefile-tfile.c: Use C++ exception handling.
491         * top.c: Use C++ exception handling.
492         * thread.c: Use C++ exception handling.
493         * target.c: Use C++ exception handling.
494         * symmisc.c: Use C++ exception handling.
495         * symfile-mem.c: Use C++ exception handling.
496         * stack.c: Use C++ exception handling.
497         * sparc64-linux-tdep.c: Use C++ exception handling.
498         * solib.c: Use C++ exception handling.
499         * solib-svr4.c: Use C++ exception handling.
500         * solib-spu.c: Use C++ exception handling.
501         * solib-frv.c: Use C++ exception handling.
502         * solib-dsbt.c: Use C++ exception handling.
503         * selftest-arch.c: Use C++ exception handling.
504         * s390-tdep.c: Use C++ exception handling.
505         * rust-lang.c: Use C++ exception handling.
506         * rust-exp.y: Use C++ exception handling.
507         * rs6000-tdep.c: Use C++ exception handling.
508         * rs6000-aix-tdep.c: Use C++ exception handling.
509         * riscv-tdep.c: Use C++ exception handling.
510         * remote.c: Use C++ exception handling.
511         * remote-fileio.c: Use C++ exception handling.
512         * record-full.c: Use C++ exception handling.
513         * record-btrace.c: Use C++ exception handling.
514         * python/python.c: Use C++ exception handling.
515         * python/py-value.c: Use C++ exception handling.
516         * python/py-utils.c: Use C++ exception handling.
517         * python/py-unwind.c: Use C++ exception handling.
518         * python/py-type.c: Use C++ exception handling.
519         * python/py-symbol.c: Use C++ exception handling.
520         * python/py-record.c: Use C++ exception handling.
521         * python/py-record-btrace.c: Use C++ exception handling.
522         * python/py-progspace.c: Use C++ exception handling.
523         * python/py-prettyprint.c: Use C++ exception handling.
524         * python/py-param.c: Use C++ exception handling.
525         * python/py-objfile.c: Use C++ exception handling.
526         * python/py-linetable.c: Use C++ exception handling.
527         * python/py-lazy-string.c: Use C++ exception handling.
528         * python/py-infthread.c: Use C++ exception handling.
529         * python/py-inferior.c: Use C++ exception handling.
530         * python/py-gdb-readline.c: Use C++ exception handling.
531         * python/py-framefilter.c: Use C++ exception handling.
532         * python/py-frame.c: Use C++ exception handling.
533         * python/py-finishbreakpoint.c: Use C++ exception handling.
534         * python/py-cmd.c: Use C++ exception handling.
535         * python/py-breakpoint.c: Use C++ exception handling.
536         * python/py-arch.c: Use C++ exception handling.
537         * printcmd.c: Use C++ exception handling.
538         * ppc-linux-tdep.c: Use C++ exception handling.
539         * parse.c: Use C++ exception handling.
540         * p-valprint.c: Use C++ exception handling.
541         * objc-lang.c: Use C++ exception handling.
542         * mi/mi-main.c: Use C++ exception handling.
543         * mi/mi-interp.c: Use C++ exception handling.
544         * mi/mi-cmd-stack.c: Use C++ exception handling.
545         * mi/mi-cmd-break.c: Use C++ exception handling.
546         * main.c: Use C++ exception handling.
547         * linux-thread-db.c: Use C++ exception handling.
548         * linux-tdep.c: Use C++ exception handling.
549         * linux-nat.c: Use C++ exception handling.
550         * linux-fork.c: Use C++ exception handling.
551         * linespec.c: Use C++ exception handling.
552         * language.c: Use C++ exception handling.
553         * jit.c: Use C++ exception handling.
554         * infrun.c: Use C++ exception handling.
555         * infcmd.c: Use C++ exception handling.
556         * infcall.c: Use C++ exception handling.
557         * inf-loop.c: Use C++ exception handling.
558         * i386-tdep.c: Use C++ exception handling.
559         * i386-linux-tdep.c: Use C++ exception handling.
560         * guile/scm-value.c: Use C++ exception handling.
561         * guile/scm-type.c: Use C++ exception handling.
562         * guile/scm-symtab.c: Use C++ exception handling.
563         * guile/scm-symbol.c: Use C++ exception handling.
564         * guile/scm-pretty-print.c: Use C++ exception handling.
565         * guile/scm-ports.c: Use C++ exception handling.
566         * guile/scm-param.c: Use C++ exception handling.
567         * guile/scm-math.c: Use C++ exception handling.
568         * guile/scm-lazy-string.c: Use C++ exception handling.
569         * guile/scm-frame.c: Use C++ exception handling.
570         * guile/scm-disasm.c: Use C++ exception handling.
571         * guile/scm-cmd.c: Use C++ exception handling.
572         * guile/scm-breakpoint.c: Use C++ exception handling.
573         * guile/scm-block.c: Use C++ exception handling.
574         * guile/guile-internal.h: Use C++ exception handling.
575         * gnu-v3-abi.c: Use C++ exception handling.
576         * gdbtypes.c: Use C++ exception handling.
577         * frame.c: Use C++ exception handling.
578         * frame-unwind.c: Use C++ exception handling.
579         * fbsd-tdep.c: Use C++ exception handling.
580         * f-valprint.c: Use C++ exception handling.
581         * exec.c: Use C++ exception handling.
582         * event-top.c: Use C++ exception handling.
583         * event-loop.c: Use C++ exception handling.
584         * eval.c: Use C++ exception handling.
585         * dwarf2read.c: Use C++ exception handling.
586         * dwarf2loc.c: Use C++ exception handling.
587         * dwarf2-frame.c: Use C++ exception handling.
588         * dwarf2-frame-tailcall.c: Use C++ exception handling.
589         * dwarf-index-write.c: Use C++ exception handling.
590         * dwarf-index-cache.c: Use C++ exception handling.
591         * dtrace-probe.c: Use C++ exception handling.
592         * disasm-selftests.c: Use C++ exception handling.
593         * darwin-nat.c: Use C++ exception handling.
594         * cp-valprint.c: Use C++ exception handling.
595         * cp-support.c: Use C++ exception handling.
596         * cp-abi.c: Use C++ exception handling.
597         * corelow.c: Use C++ exception handling.
598         * completer.c: Use C++ exception handling.
599         * compile/compile-object-run.c: Use C++ exception handling.
600         * compile/compile-object-load.c: Use C++ exception handling.
601         * compile/compile-cplus-symbols.c: Use C++ exception handling.
602         * compile/compile-c-symbols.c: Use C++ exception handling.
603         * common/selftest.c: Use C++ exception handling.
604         * common/new-op.c: Use C++ exception handling.
605         * cli/cli-script.c: Use C++ exception handling.
606         * cli/cli-interp.c: Use C++ exception handling.
607         * cli/cli-cmds.c: Use C++ exception handling.
608         * c-varobj.c: Use C++ exception handling.
609         * btrace.c: Use C++ exception handling.
610         * breakpoint.c: Use C++ exception handling.
611         * break-catch-throw.c: Use C++ exception handling.
612         * arch-utils.c: Use C++ exception handling.
613         * amd64-tdep.c: Use C++ exception handling.
614         * ada-valprint.c: Use C++ exception handling.
615         * ada-typeprint.c: Use C++ exception handling.
616         * ada-lang.c: Use C++ exception handling.
617         * aarch64-tdep.c: Use C++ exception handling.
618
619 2019-04-08  Tom Tromey  <tom@tromey.com>
620
621         * xml-support.c (gdb_xml_parser::parse): Update.
622         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
623         * value.c (show_convenience): Update.
624         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
625         (test_parse_flags_qcs): Update.
626         * thread.c (thr_try_catch_cmd): Update.
627         * target.c (target_translate_tls_address): Update.
628         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
629         (info_frame_command_core, frame_apply_command_count): Update.
630         * rust-exp.y (rust_lex_exception_test): Update.
631         * riscv-tdep.c (riscv_print_one_register_info): Update.
632         * remote.c (remote_target::enable_btrace): Update.
633         * record-btrace.c (record_btrace_enable_warn): Update.
634         * python/py-utils.c (gdbpy_convert_exception): Update.
635         * printcmd.c (do_one_display, print_variable_and_value): Update.
636         * mi/mi-main.c (mi_print_exception): Update.
637         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
638         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
639         * linux-nat.c (linux_nat_target::attach): Update.
640         * linux-fork.c (class scoped_switch_fork_info): Update.
641         * infrun.c (displaced_step_prepare): Update.
642         * infcall.c (call_function_by_hand_dummy): Update.
643         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
644         * gnu-v3-abi.c (print_one_vtable): Update.
645         * frame.c (get_prev_frame_always): Update.
646         * f-valprint.c (info_common_command_for_block): Update.
647         * exec.c (try_open_exec_file): Update.
648         * exceptions.c (print_exception, exception_print)
649         (exception_fprintf, exception_print_same): Update.
650         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
651         * dwarf-index-cache.c (index_cache::store)
652         (index_cache::lookup_gdb_index): Update.
653         * darwin-nat.c (maybe_cache_shell): Update.
654         * cp-valprint.c (cp_print_value_fields): Update.
655         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
656         (gcc_cplus_symbol_address): Update.
657         * compile/compile-c-symbols.c (gcc_convert_symbol)
658         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
659         * common/selftest.c: Update.
660         * common/common-exceptions.h (struct gdb_exception) <message>: Now
661         a std::string.
662         (exception_try_scope_entry, exception_try_scope_exit): Don't
663         declare.
664         (struct exception_try_scope): Remove.
665         (TRY): Don't use exception_try_scope.
666         (struct gdb_exception): Add constructor, operator=.
667         <what>: New method.
668         (struct gdb_exception_RETURN_MASK_ALL)
669         (struct gdb_exception_RETURN_MASK_ERROR)
670         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
671         (struct gdb_quit_bad_alloc): Update.
672         * common/common-exceptions.c (exception_none): Change
673         initializer.
674         (struct catcher) <state, exception>: Initialize inline.
675         <prev>: Remove member.
676         (current_catcher): Remove.
677         (catchers): New global.
678         (exceptions_state_mc_init): Simplify.
679         (catcher_pop): Remove.
680         (exceptions_state_mc, exceptions_state_mc_catch): Update.
681         (try_scope_depth, exception_try_scope_entry)
682         (exception_try_scope_exit): Remove.
683         (throw_exception_sjlj): Update.
684         (exception_messages, exception_messages_size): Remove.
685         (throw_it): Simplify.
686         (gdb_exception_sliced_copy): Remove.
687         (throw_exception_cxx): Update.
688         * cli/cli-script.c (script_from_file): Update.
689         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
690         Update.
691         * ada-valprint.c (ada_val_print): Update.
692         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
693         (create_excep_cond_exprs): Update.
694
695 2019-04-08  Tom Tromey  <tom@tromey.com>
696
697         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
698         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
699         (TRY, CATCH, END_CATCH): Remove some definitions.
700         * common/common-exceptions.c: Don't use GDB_XCPT.
701         (catcher_list_size): Remove.
702         (throw_exception, throw_it): Simplify.
703
704 2019-04-05  Tom Tromey  <tom@tromey.com>
705
706         Revert the header-sorting patch.
707         * ft32-tdep.c: Revert.
708         * frv-tdep.c: Revert.
709         * frv-linux-tdep.c: Revert.
710         * frame.c: Revert.
711         * frame-unwind.c: Revert.
712         * frame-base.c: Revert.
713         * fork-child.c: Revert.
714         * findvar.c: Revert.
715         * findcmd.c: Revert.
716         * filesystem.c: Revert.
717         * filename-seen-cache.h: Revert.
718         * filename-seen-cache.c: Revert.
719         * fbsd-tdep.c: Revert.
720         * fbsd-nat.h: Revert.
721         * fbsd-nat.c: Revert.
722         * f-valprint.c: Revert.
723         * f-typeprint.c: Revert.
724         * f-lang.c: Revert.
725         * extension.h: Revert.
726         * extension.c: Revert.
727         * extension-priv.h: Revert.
728         * expprint.c: Revert.
729         * exec.h: Revert.
730         * exec.c: Revert.
731         * exceptions.c: Revert.
732         * event-top.c: Revert.
733         * event-loop.c: Revert.
734         * eval.c: Revert.
735         * elfread.c: Revert.
736         * dwarf2read.h: Revert.
737         * dwarf2read.c: Revert.
738         * dwarf2loc.c: Revert.
739         * dwarf2expr.h: Revert.
740         * dwarf2expr.c: Revert.
741         * dwarf2-frame.c: Revert.
742         * dwarf2-frame-tailcall.c: Revert.
743         * dwarf-index-write.h: Revert.
744         * dwarf-index-write.c: Revert.
745         * dwarf-index-common.c: Revert.
746         * dwarf-index-cache.h: Revert.
747         * dwarf-index-cache.c: Revert.
748         * dummy-frame.c: Revert.
749         * dtrace-probe.c: Revert.
750         * disasm.h: Revert.
751         * disasm.c: Revert.
752         * disasm-selftests.c: Revert.
753         * dictionary.c: Revert.
754         * dicos-tdep.c: Revert.
755         * demangle.c: Revert.
756         * dcache.h: Revert.
757         * dcache.c: Revert.
758         * darwin-nat.h: Revert.
759         * darwin-nat.c: Revert.
760         * darwin-nat-info.c: Revert.
761         * d-valprint.c: Revert.
762         * d-namespace.c: Revert.
763         * d-lang.c: Revert.
764         * ctf.c: Revert.
765         * csky-tdep.c: Revert.
766         * csky-linux-tdep.c: Revert.
767         * cris-tdep.c: Revert.
768         * cris-linux-tdep.c: Revert.
769         * cp-valprint.c: Revert.
770         * cp-support.c: Revert.
771         * cp-namespace.c: Revert.
772         * cp-abi.c: Revert.
773         * corelow.c: Revert.
774         * corefile.c: Revert.
775         * continuations.c: Revert.
776         * completer.h: Revert.
777         * completer.c: Revert.
778         * complaints.c: Revert.
779         * coffread.c: Revert.
780         * coff-pe-read.c: Revert.
781         * cli-out.h: Revert.
782         * cli-out.c: Revert.
783         * charset.c: Revert.
784         * c-varobj.c: Revert.
785         * c-valprint.c: Revert.
786         * c-typeprint.c: Revert.
787         * c-lang.c: Revert.
788         * buildsym.c: Revert.
789         * buildsym-legacy.c: Revert.
790         * build-id.h: Revert.
791         * build-id.c: Revert.
792         * btrace.c: Revert.
793         * bsd-uthread.c: Revert.
794         * breakpoint.h: Revert.
795         * breakpoint.c: Revert.
796         * break-catch-throw.c: Revert.
797         * break-catch-syscall.c: Revert.
798         * break-catch-sig.c: Revert.
799         * blockframe.c: Revert.
800         * block.c: Revert.
801         * bfin-tdep.c: Revert.
802         * bfin-linux-tdep.c: Revert.
803         * bfd-target.c: Revert.
804         * bcache.c: Revert.
805         * ax-general.c: Revert.
806         * ax-gdb.h: Revert.
807         * ax-gdb.c: Revert.
808         * avr-tdep.c: Revert.
809         * auxv.c: Revert.
810         * auto-load.c: Revert.
811         * arm-wince-tdep.c: Revert.
812         * arm-tdep.c: Revert.
813         * arm-symbian-tdep.c: Revert.
814         * arm-pikeos-tdep.c: Revert.
815         * arm-obsd-tdep.c: Revert.
816         * arm-nbsd-tdep.c: Revert.
817         * arm-nbsd-nat.c: Revert.
818         * arm-linux-tdep.c: Revert.
819         * arm-linux-nat.c: Revert.
820         * arm-fbsd-tdep.c: Revert.
821         * arm-fbsd-nat.c: Revert.
822         * arm-bsd-tdep.c: Revert.
823         * arch-utils.c: Revert.
824         * arc-tdep.c: Revert.
825         * arc-newlib-tdep.c: Revert.
826         * annotate.h: Revert.
827         * annotate.c: Revert.
828         * amd64-windows-tdep.c: Revert.
829         * amd64-windows-nat.c: Revert.
830         * amd64-tdep.c: Revert.
831         * amd64-sol2-tdep.c: Revert.
832         * amd64-obsd-tdep.c: Revert.
833         * amd64-obsd-nat.c: Revert.
834         * amd64-nbsd-tdep.c: Revert.
835         * amd64-nbsd-nat.c: Revert.
836         * amd64-nat.c: Revert.
837         * amd64-linux-tdep.c: Revert.
838         * amd64-linux-nat.c: Revert.
839         * amd64-fbsd-tdep.c: Revert.
840         * amd64-fbsd-nat.c: Revert.
841         * amd64-dicos-tdep.c: Revert.
842         * amd64-darwin-tdep.c: Revert.
843         * amd64-bsd-nat.c: Revert.
844         * alpha-tdep.c: Revert.
845         * alpha-obsd-tdep.c: Revert.
846         * alpha-nbsd-tdep.c: Revert.
847         * alpha-mdebug-tdep.c: Revert.
848         * alpha-linux-tdep.c: Revert.
849         * alpha-linux-nat.c: Revert.
850         * alpha-bsd-tdep.c: Revert.
851         * alpha-bsd-nat.c: Revert.
852         * aix-thread.c: Revert.
853         * agent.c: Revert.
854         * addrmap.c: Revert.
855         * ada-varobj.c: Revert.
856         * ada-valprint.c: Revert.
857         * ada-typeprint.c: Revert.
858         * ada-tasks.c: Revert.
859         * ada-lang.c: Revert.
860         * aarch64-tdep.c: Revert.
861         * aarch64-ravenscar-thread.c: Revert.
862         * aarch64-newlib-tdep.c: Revert.
863         * aarch64-linux-tdep.c: Revert.
864         * aarch64-linux-nat.c: Revert.
865         * aarch64-fbsd-tdep.c: Revert.
866         * aarch64-fbsd-nat.c: Revert.
867         * aarch32-linux-nat.c: Revert.
868
869 2019-04-05  Tom Tromey  <tom@tromey.com>
870
871         * ft32-tdep.c: Sort headers.
872         * frv-tdep.c: Sort headers.
873         * frv-linux-tdep.c: Sort headers.
874         * frame.c: Sort headers.
875         * frame-unwind.c: Sort headers.
876         * frame-base.c: Sort headers.
877         * fork-child.c: Sort headers.
878         * findvar.c: Sort headers.
879         * findcmd.c: Sort headers.
880         * filesystem.c: Sort headers.
881         * filename-seen-cache.h: Sort headers.
882         * filename-seen-cache.c: Sort headers.
883         * fbsd-tdep.c: Sort headers.
884         * fbsd-nat.h: Sort headers.
885         * fbsd-nat.c: Sort headers.
886         * f-valprint.c: Sort headers.
887         * f-typeprint.c: Sort headers.
888         * f-lang.c: Sort headers.
889         * extension.h: Sort headers.
890         * extension.c: Sort headers.
891         * extension-priv.h: Sort headers.
892         * expprint.c: Sort headers.
893         * exec.h: Sort headers.
894         * exec.c: Sort headers.
895         * exceptions.c: Sort headers.
896         * event-top.c: Sort headers.
897         * event-loop.c: Sort headers.
898         * eval.c: Sort headers.
899         * elfread.c: Sort headers.
900         * dwarf2read.h: Sort headers.
901         * dwarf2read.c: Sort headers.
902         * dwarf2loc.c: Sort headers.
903         * dwarf2expr.h: Sort headers.
904         * dwarf2expr.c: Sort headers.
905         * dwarf2-frame.c: Sort headers.
906         * dwarf2-frame-tailcall.c: Sort headers.
907         * dwarf-index-write.h: Sort headers.
908         * dwarf-index-write.c: Sort headers.
909         * dwarf-index-common.c: Sort headers.
910         * dwarf-index-cache.h: Sort headers.
911         * dwarf-index-cache.c: Sort headers.
912         * dummy-frame.c: Sort headers.
913         * dtrace-probe.c: Sort headers.
914         * disasm.h: Sort headers.
915         * disasm.c: Sort headers.
916         * disasm-selftests.c: Sort headers.
917         * dictionary.c: Sort headers.
918         * dicos-tdep.c: Sort headers.
919         * demangle.c: Sort headers.
920         * dcache.h: Sort headers.
921         * dcache.c: Sort headers.
922         * darwin-nat.h: Sort headers.
923         * darwin-nat.c: Sort headers.
924         * darwin-nat-info.c: Sort headers.
925         * d-valprint.c: Sort headers.
926         * d-namespace.c: Sort headers.
927         * d-lang.c: Sort headers.
928         * ctf.c: Sort headers.
929         * csky-tdep.c: Sort headers.
930         * csky-linux-tdep.c: Sort headers.
931         * cris-tdep.c: Sort headers.
932         * cris-linux-tdep.c: Sort headers.
933         * cp-valprint.c: Sort headers.
934         * cp-support.c: Sort headers.
935         * cp-namespace.c: Sort headers.
936         * cp-abi.c: Sort headers.
937         * corelow.c: Sort headers.
938         * corefile.c: Sort headers.
939         * continuations.c: Sort headers.
940         * completer.h: Sort headers.
941         * completer.c: Sort headers.
942         * complaints.c: Sort headers.
943         * coffread.c: Sort headers.
944         * coff-pe-read.c: Sort headers.
945         * cli-out.h: Sort headers.
946         * cli-out.c: Sort headers.
947         * charset.c: Sort headers.
948         * c-varobj.c: Sort headers.
949         * c-valprint.c: Sort headers.
950         * c-typeprint.c: Sort headers.
951         * c-lang.c: Sort headers.
952         * buildsym.c: Sort headers.
953         * buildsym-legacy.c: Sort headers.
954         * build-id.h: Sort headers.
955         * build-id.c: Sort headers.
956         * btrace.c: Sort headers.
957         * bsd-uthread.c: Sort headers.
958         * breakpoint.h: Sort headers.
959         * breakpoint.c: Sort headers.
960         * break-catch-throw.c: Sort headers.
961         * break-catch-syscall.c: Sort headers.
962         * break-catch-sig.c: Sort headers.
963         * blockframe.c: Sort headers.
964         * block.c: Sort headers.
965         * bfin-tdep.c: Sort headers.
966         * bfin-linux-tdep.c: Sort headers.
967         * bfd-target.c: Sort headers.
968         * bcache.c: Sort headers.
969         * ax-general.c: Sort headers.
970         * ax-gdb.h: Sort headers.
971         * ax-gdb.c: Sort headers.
972         * avr-tdep.c: Sort headers.
973         * auxv.c: Sort headers.
974         * auto-load.c: Sort headers.
975         * arm-wince-tdep.c: Sort headers.
976         * arm-tdep.c: Sort headers.
977         * arm-symbian-tdep.c: Sort headers.
978         * arm-pikeos-tdep.c: Sort headers.
979         * arm-obsd-tdep.c: Sort headers.
980         * arm-nbsd-tdep.c: Sort headers.
981         * arm-nbsd-nat.c: Sort headers.
982         * arm-linux-tdep.c: Sort headers.
983         * arm-linux-nat.c: Sort headers.
984         * arm-fbsd-tdep.c: Sort headers.
985         * arm-fbsd-nat.c: Sort headers.
986         * arm-bsd-tdep.c: Sort headers.
987         * arch-utils.c: Sort headers.
988         * arc-tdep.c: Sort headers.
989         * arc-newlib-tdep.c: Sort headers.
990         * annotate.h: Sort headers.
991         * annotate.c: Sort headers.
992         * amd64-windows-tdep.c: Sort headers.
993         * amd64-windows-nat.c: Sort headers.
994         * amd64-tdep.c: Sort headers.
995         * amd64-sol2-tdep.c: Sort headers.
996         * amd64-obsd-tdep.c: Sort headers.
997         * amd64-obsd-nat.c: Sort headers.
998         * amd64-nbsd-tdep.c: Sort headers.
999         * amd64-nbsd-nat.c: Sort headers.
1000         * amd64-nat.c: Sort headers.
1001         * amd64-linux-tdep.c: Sort headers.
1002         * amd64-linux-nat.c: Sort headers.
1003         * amd64-fbsd-tdep.c: Sort headers.
1004         * amd64-fbsd-nat.c: Sort headers.
1005         * amd64-dicos-tdep.c: Sort headers.
1006         * amd64-darwin-tdep.c: Sort headers.
1007         * amd64-bsd-nat.c: Sort headers.
1008         * alpha-tdep.c: Sort headers.
1009         * alpha-obsd-tdep.c: Sort headers.
1010         * alpha-nbsd-tdep.c: Sort headers.
1011         * alpha-mdebug-tdep.c: Sort headers.
1012         * alpha-linux-tdep.c: Sort headers.
1013         * alpha-linux-nat.c: Sort headers.
1014         * alpha-bsd-tdep.c: Sort headers.
1015         * alpha-bsd-nat.c: Sort headers.
1016         * aix-thread.c: Sort headers.
1017         * agent.c: Sort headers.
1018         * addrmap.c: Sort headers.
1019         * ada-varobj.c: Sort headers.
1020         * ada-valprint.c: Sort headers.
1021         * ada-typeprint.c: Sort headers.
1022         * ada-tasks.c: Sort headers.
1023         * ada-lang.c: Sort headers.
1024         * aarch64-tdep.c: Sort headers.
1025         * aarch64-ravenscar-thread.c: Sort headers.
1026         * aarch64-newlib-tdep.c: Sort headers.
1027         * aarch64-linux-tdep.c: Sort headers.
1028         * aarch64-linux-nat.c: Sort headers.
1029         * aarch64-fbsd-tdep.c: Sort headers.
1030         * aarch64-fbsd-nat.c: Sort headers.
1031         * aarch32-linux-nat.c: Sort headers.
1032
1033 2019-04-04  Tom Tromey  <tom@tromey.com>
1034
1035         * varobj.c (varobj_create): Update.
1036         * rust-exp.y (struct rust_parser) <update_innermost_block,
1037         lookup_symbol>: New methods.
1038         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1039         Rename.
1040         (rust_parser::rust_lookup_type)
1041         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1042         * printcmd.c (display_command, do_one_display): Update.
1043         * parser-defs.h (struct parser_state) <parser_state>: Add
1044         "tracker" parameter.
1045         (block_tracker): New member.
1046         (class innermost_block_tracker) <innermost_block_tracker>: Add
1047         "types" parameter.
1048         <reset>: Remove method.
1049         (innermost_block): Don't declare.
1050         (null_post_parser): Update.
1051         * parse.c (innermost_block): Remove global.
1052         (write_dollar_variable): Update.
1053         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1054         Remove "tracker_types" parameter.
1055         (parse_expression): Add "tracker" parameter.
1056         (parse_expression_for_completion): Update.
1057         (null_post_parser): Add "tracker" parameter.
1058         * p-exp.y: Update rules.
1059         * m2-exp.y: Update rules.
1060         * language.h (struct language_defn) <la_post_parser>: Add
1061         "tracker" parameter.
1062         * go-exp.y: Update rules.
1063         * f-exp.y: Update rules.
1064         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1065         parameter.
1066         * d-exp.y: Update rules.
1067         * c-exp.y: Update rules.
1068         * breakpoint.c (set_breakpoint_condition): Create an
1069         innermost_block_tracker.
1070         (watch_command_1): Likewise.
1071         * ada-lang.c (resolve): Add "tracker" parameter.
1072         (resolve_subexp): Likewise.
1073         * ada-exp.y (write_var_from_sym): Update.
1074
1075 2019-04-04  Tom Tromey  <tom@tromey.com>
1076
1077         * type-stack.h: New file.
1078         * type-stack.c: New file.
1079         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1080         type-stack.h.
1081         (insert_into_type_stack, insert_type, push_type, push_type_int)
1082         (insert_type_address_space, pop_type, pop_type_int)
1083         (pop_typelist, pop_type_stack, append_type_stack)
1084         (push_type_stack, get_type_stack, push_typelist)
1085         (follow_type_instance_flags, follow_types): Don't declare.
1086         * parse.c (type_stack): Remove global.
1087         (parse_exp_in_context): Update.
1088         (insert_into_type_stack, insert_type, push_type, push_type_int)
1089         (insert_type_address_space, pop_type, pop_type_int)
1090         (pop_typelist, pop_type_stack, append_type_stack)
1091         (push_type_stack, get_type_stack, push_typelist)
1092         (follow_type_instance_flags, follow_types): Remove (moved to
1093         type-stack.c).
1094         * f-exp.y (type_stack): New global.
1095         Update rules.
1096         (push_kind_type, f_parse): Update.
1097         * d-exp.y (type_stack): New global.
1098         Update rules.
1099         (d_parse): Update.
1100         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1101         Update rules.
1102         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1103         (HFILES_NO_SRCDIR): Add type-stack.h.
1104
1105 2019-04-04  Tom Tromey  <tom@tromey.com>
1106
1107         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1108         (rust_parser::convert_ast_to_expression, rust_parse)
1109         (rust_lex_test_completion, rust_lex_tests): Update.
1110         * parser-defs.h (struct expr_completion_state): New.
1111         (struct parser_state) <parser_state>: Add completion parameter.
1112         <mark_struct_expression, mark_completion_tag>: New methods.
1113         <parse_completion, m_completion_state>: New members.
1114         (prefixify_expression, null_post_parser): Update.
1115         (mark_struct_expression, mark_completion_tag): Don't declare.
1116         * parse.c (parse_completion, expout_last_struct)
1117         (expout_tag_completion_type, expout_completion_name): Remove
1118         globals.
1119         (parser_state::mark_struct_expression)
1120         (parser_state::mark_completion_tag): Now methods.
1121         (prefixify_expression): Add last_struct parameter.
1122         (prefixify_subexp): Likewise.
1123         (parse_exp_1): Update.
1124         (parse_exp_in_context): Add cstate parameter.  Update.
1125         (parse_expression_for_completion): Create an
1126         expr_completion_state.
1127         (null_post_parser): Add "completion" parameter.
1128         * p-exp.y: Update rules.
1129         (yylex): Update.
1130         * language.h (struct language_defn) <la_post_parser>: Add
1131         "completing" parameter.
1132         * go-exp.y: Update rules.
1133         (lex_one_token): Update.
1134         * expression.h (parse_completion): Don't declare.
1135         * d-exp.y: Update rules.
1136         (lex_one_token): Update rules.
1137         * c-exp.y: Update rules.
1138         (lex_one_token): Update.
1139         * ada-lang.c (resolve): Add "parse_completion" parameter.
1140         (resolve_subexp): Likewise.
1141         (ada_resolve_function): Likewise.
1142
1143 2019-04-04  Tom Tromey  <tom@tromey.com>
1144
1145         * parser-defs.h (struct parser_state) <start_arglist,
1146         end_arglist>: New methods.
1147         <arglist_len, m_funcall_chain>: New members.
1148         (arglist_len, start_arglist, end_arglist): Don't declare.
1149         * parse.c (arglist_len, funcall_chain): Remove global.
1150         (start_arglist, end_arglist): Remove functions.
1151         (parse_exp_in_context): Update.
1152         * p-exp.y: Update rules.
1153         * m2-exp.y: Update rules.
1154         * go-exp.y: Update rules.
1155         * f-exp.y: Update rules.
1156         * d-exp.y: Update rules.
1157         * c-exp.y: Update rules.
1158
1159 2019-04-04  Tom Tromey  <tom@tromey.com>
1160
1161         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1162         lex_operator, push_back>: New methods.
1163         Update all rules.
1164         (rust_parser::lex_hex, lex_escape): Rename and update.
1165         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1166         (rust_parser::lex_operator): Rename and update.
1167         (rust_parser::lex_number, rustyylex, rustyyerror)
1168         (rust_lex_test_init, rust_lex_test_sequence)
1169         (rust_lex_test_push_back, rust_lex_tests): Update.
1170         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1171         parameter.
1172         <lexptr, prev_lexptr>: New members.
1173         (lexptr, prev_lexptr): Don't declare.
1174         * parse.c (lexptr, prev_lexptr): Remove globals.
1175         (parse_exp_in_context): Update.
1176         * p-exp.y (yylex, yyerror): Update.
1177         * m2-exp.y (parse_number, yylex, yyerror): Update.
1178         * go-exp.y (lex_one_token, yyerror): Update.
1179         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1180         * d-exp.y (lex_one_token, yyerror): Update.
1181         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1182         (lex_one_token, yyerror): Update.
1183         * ada-lex.l (YY_INPUT): Update.
1184         (rewind_to_char): Update.
1185         * ada-exp.y (yyerror): Update.
1186
1187 2019-04-04  Tom Tromey  <tom@tromey.com>
1188
1189         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1190         * parser-defs.h (struct parser_state) <parser_state>: Add new
1191         parameter.
1192         <comma_terminates>: New member.
1193         (comma_terminates): Don't declare global.
1194         * parse.c (comma_terminates): Remove global.
1195         (parse_exp_in_context): Update.
1196         * p-exp.y (yylex): Update.
1197         * m2-exp.y (yylex): Update.
1198         * go-exp.y (lex_one_token): Update.
1199         * f-exp.y (yylex): Update.
1200         * d-exp.y (lex_one_token): Update.
1201         * c-exp.y (lex_one_token): Update.
1202         * ada-lex.l: Update.
1203
1204 2019-04-04  Tom Tromey  <tom@tromey.com>
1205
1206         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1207         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1208         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1209         * parser-defs.h (paren_depth): Don't declare.
1210         * parse.c (paren_depth): Remove global.
1211         (parse_exp_in_context): Update.
1212         * p-exp.y (paren_depth): New global.
1213         (pascal_parse): Initialize it.
1214         * m2-exp.y (paren_depth): New global.
1215         (m2_parse): Initialize it.
1216         * go-exp.y (paren_depth): New global.
1217         (go_parse): Initialize it.
1218         * f-exp.y (paren_depth): New global.
1219         (f_parse): Initialize it.
1220         * d-exp.y (paren_depth): New global.
1221         (d_parse): Initialize it.
1222         * c-exp.y (paren_depth): New global.
1223         (c_parse): Initialize it.
1224         * ada-lex.l (paren_depth): New global.
1225         (lexer_init): Initialize it.
1226
1227 2019-04-04  Tom Tromey  <tom@tromey.com>
1228
1229         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1230         (rust_parser::convert_ast_to_type)
1231         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1232         * parser-defs.h (struct parser_state) <parser_state>: Add
1233         parameters.  Initialize new members.
1234         <expression_context_block, expression_context_pc>: New members.
1235         * parse.c (expression_context_block, expression_context_pc):
1236         Remove globals.
1237         (parse_exp_in_context): Update.
1238         * p-exp.y: Update all rules.
1239         (yylex): Update.
1240         * m2-exp.y: Update all rules.
1241         (yylex): Update.
1242         * go-exp.y (yylex): Update.
1243         * f-exp.y (yylex): Update.
1244         * d-exp.y: Update all rules.
1245         (yylex): Update.
1246         * c-exp.y: Update all rules.
1247         (lex_one_token, classify_name, yylex, c_parse): Update.
1248         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1249
1250 2019-04-04  Tom Tromey  <tom@tromey.com>
1251
1252         * gdbarch.h, gdbarch.c: Rebuild.
1253         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1254         * stap-probe.h: 
1255         (struct stap_parse_info): Replace "parser_state" with
1256         "expr_builder".
1257         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1258         (parser_state): New class.
1259         * parse.c (expr_builder): Rename.
1260         (expr_builder::release): Rename.
1261         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1262         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1263         (write_exp_elt_longcst, write_exp_elt_floatcst)
1264         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1265         (write_exp_string_vector, write_exp_bitstring)
1266         (write_exp_msymbol, mark_struct_expression)
1267         (write_dollar_variable)
1268         (insert_type_address_space, increase_expout_size): Replace
1269         "parser_state" with "expr_builder".
1270         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1271         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1272         "parser_state" with "expr_builder".
1273
1274 2019-04-04  Tom Tromey  <tom@tromey.com>
1275
1276         * rust-exp.y: Replace "parse_language" with method call.
1277         * p-exp.y: 
1278         (yylex): Replace "parse_language" with method call.
1279         * m2-exp.y: 
1280         (yylex): Replace "parse_language" with method call.
1281         * go-exp.y (classify_name): Replace "parse_language" with method
1282         call.
1283         * f-exp.y (yylex): Replace "parse_language" with method call.
1284         * d-exp.y (lex_one_token): Replace "parse_language" with method
1285         call.
1286         * c-exp.y: 
1287         (lex_one_token, classify_name, yylex): Replace "parse_language"
1288         with method call.
1289         * ada-exp.y (find_primitive_type, type_char)
1290         (type_system_address): Replace "parse_language" with method call.
1291
1292 2019-04-04  Tom Tromey  <tom@tromey.com>
1293
1294         * rust-exp.y: Replace "parse_gdbarch" with method call.
1295         * parse.c (write_dollar_variable, insert_type_address_space):
1296         Replace "parse_gdbarch" with method call.
1297         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1298         call.
1299         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1300         call.
1301         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1302         "parse_gdbarch" with method call.
1303         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1304         with method call.
1305         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1306         "parse_gdbarch" with method call.
1307         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1308         "parse_gdbarch" with method call.
1309         * c-exp.y (parse_type, parse_number, classify_name): Replace
1310         "parse_gdbarch" with method call.
1311         * ada-lex.l: Replace "parse_gdbarch" with method call.
1312         * ada-exp.y (parse_type, find_primitive_type, type_char)
1313         (type_system_address): Replace "parse_gdbarch" with method call.
1314
1315 2019-04-04  Tom Tromey  <tom@tromey.com>
1316
1317         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1318         * stap-probe.c (stap_parse_argument): Update.
1319         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1320         initial_size parameter.
1321         * rust-exp.y (rust_lex_tests): Update.
1322         * parse.c (parser_state): Update.
1323         (parse_exp_in_context): Update.
1324         * parser-defs.h (struct parser_state) <parser_state>: Remove
1325         "initial_size" parameter.
1326
1327 2019-04-04  Tom Tromey  <tom@tromey.com>
1328
1329         * parser-defs.h (increase_expout_size): Don't declare.
1330         * parse.c (increase_expout_size): Now static.
1331
1332 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1333
1334         * gnu-nat.c (gnu_nat_target::wait): Fix
1335         target_waitstatus_to_string call.
1336
1337 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1338
1339         * eval.c (evaluate_subexp_standard): Handle internal functions
1340         during Fortran function call handling.
1341
1342 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1343
1344         * NEWS: Mention new internal functions.
1345         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1346         (read_base_type): Use dwarf2_init_complex_target_type.
1347         * value.c (creal_internal_fn): New function.
1348         (cimag_internal_fn): New function.
1349         (_initialize_values): Register new internal functions.
1350
1351 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1352
1353         * infrun.c (stop_all_threads): If debug_infrun, always
1354         trace the wait status after wait_one, using
1355         target_waitstatus_to_string and target_pid_to_str.
1356         (handle_inferior_event): Replace various trace of
1357         wait status kind by a single trace.
1358         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1359         wait status kind image by target_waitstatus_to_string.
1360         * target/waitstatus.c (target_waitstatus_to_string): Fix
1361         obsolete comment.
1362
1363 2019-04-01  Tom Tromey  <tromey@adacore.com>
1364
1365         PR symtab/23331:
1366         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1367
1368 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1369             Pedro Alves  <palves@redhat.com>
1370
1371         * top.c (quit_force): Call 'finalize_values'.
1372         * value.c (finalize_values): New function.
1373         * value.h (finalize_values): Declare.
1374
1375 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1376
1377         * NEWS: Announce $_gdb_major and $_gdb_minor.
1378
1379         * top.c (init_gdb_version_vars): New function.
1380         (gdb_init): Call init_gdb_version_vars.
1381
1382 2019-03-29  Tom Tromey  <tromey@adacore.com>
1383
1384         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1385         help text.  Remove dead code.
1386
1387 2019-03-29  Keith Seitz  <keiths@redhat.com>
1388
1389         From Siddhesh Poyarekar:
1390         * f-lang.h (f77_get_upperbound): Return LONGEST.
1391         (f77_get_lowerbound): Likewise.
1392         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1393         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1394         print them.
1395         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1396         plongest to format print it.
1397         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1398         (f77_get_upperbound): Likewise.
1399         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1400         LOWER_BOUND to LONGEST.
1401         (f77_create_arrayprint_offset_tbl): Likewise.
1402
1403 2019-03-29  Keith Seitz  <keiths@redhat.com>
1404
1405         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1406         %s/pulongest for TYPE_LENGTH instead of %d in format
1407         strings.
1408         * ada-typerint.c (ada_print_type): Likewise.
1409         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1410         * compile/compile-c-support.c (generate_register_struct): Likewise.
1411         * gdbtypes.c (recursive_dump_type): Likewise.
1412         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1413         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1414         instead of %d in format strings.
1415         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1416         to std::min to ULONGEST.
1417         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1418         instead of %d in format strings.
1419         * tracepoint.c (info_scope_command): Likewise.
1420         * typeprint.c (print_offset_data::update)
1421         (print_offset_data::finish): Likewise.
1422         * xtensa-tdep.c (xtensa_store_return_value)
1423         (xtensa_push_dummy_call): Likewise.
1424
1425 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1426
1427         * windows-nat.c (display_selector): Fixed format specifications
1428         for 64-bit Cygwin.
1429
1430 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1431
1432         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1433
1434 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1435
1436         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1437         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1438         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1439         (nios2_linux_init_abi): Install it.
1440
1441 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1442
1443         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1444
1445 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1446
1447         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1448
1449 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1450             Tom Tromey  <tromey@adacore.com>
1451
1452         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1453
1454 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1455
1456         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1457         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1458         method to compute the bounds of range types. Also print "[evaluated]"
1459         if the bounds' values come from a dynamic evaluation.
1460
1461 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1462
1463         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1464         whitespace when pretty printing is on.
1465
1466 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1467
1468         * ppc-linux-nat.c: Add include.
1469
1470 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1471
1472         * NEWS: Mention AArch64 Pointer Authentication.
1473
1474 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1475
1476         * arm-linux-nat.c: Add include.
1477
1478 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1479
1480         * source-cache.c (source_cache::get_source_lines): Re-read
1481         fullname after calling open_source_file.
1482
1483 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1484
1485         * NEWS: Mention TLS support for FreeBSD.
1486
1487 2019-03-25  Tom Tromey  <tromey@adacore.com>
1488
1489         * minsyms.c (BUNCH_SIZE): Update comment.
1490         (~minimal_symbol_reader): Remove old comment.
1491         (compact_minimal_symbols): Update comment.
1492         (minimal_symbol_reader::install): Remove old comment.  Update
1493         other comments.
1494
1495 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1496
1497         * s390-linux-nat.c: Add include.
1498
1499 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1500
1501         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1502         Call linux_get_hwcap.
1503         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1504         Likewise.
1505         (aarch64_linux_get_hwcap): Remove function.
1506         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1507         declaration.
1508         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1509         linux_get_hwcap.
1510         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1511         * linux-tdep.c (linux_get_hwcap): Add function.
1512         (linux_get_hwcap2): Likewise.
1513         * linux-tdep.h (linux_get_hwcap): Add declaration.
1514         (linux_get_hwcap2): Likewise.
1515         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1516         (ppc_linux_get_hwcap2): Likewise.
1517         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1518         linux_get_hwcap.
1519         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1520         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1521         (ppc_linux_nat_target::read_description): Likewise.
1522         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1523         * s390-linux-nat.c: Likewise.
1524         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1525
1526 2019-03-24  Tom Tromey  <tom@tromey.com>
1527
1528         * ada-lang.c (standard_lookup): Simplify initialization.
1529         (ada_lookup_symbol_nonlocal): Simplify return.
1530         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1531         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1532         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1533         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1534         initialization.
1535         * solib.c (solib_global_lookup): Simplify.
1536         * symtab.c (null_block_symbol): Remove.
1537         (symbol_cache_lookup): Simplify returns.
1538         (lookup_language_this): Simplify returns.
1539         (lookup_symbol_aux): Simplify return.
1540         (lookup_local_symbol): Simplify returns.
1541         (lookup_global_symbol_from_objfile): Simplify return.
1542         (lookup_symbol_in_objfile_symtabs)
1543         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1544         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1545         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1546         * cp-namespace.c (cp_lookup_bare_symbol)
1547         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1548         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1549         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1550         (cp_lookup_symbol_via_imports): Simplify initialization.
1551         (find_symbol_in_baseclass): Likewise.
1552         * symtab.h (null_block_symbol): Remove.
1553         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1554         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1555         (d_lookup_symbol_module): Likewise.
1556         (find_symbol_in_baseclass): Simplify initialization.
1557
1558 2019-03-24  Tom Tromey  <tom@tromey.com>
1559
1560         * expression.h: Don't include symtab.h.
1561         (struct block): Forward declare.
1562
1563 2019-03-24  Tom Tromey  <tom@tromey.com>
1564
1565         * c-exp.y (typebase): Remove casts.
1566         * gdbtypes.c (lookup_unsigned_typename, )
1567         (lookup_signed_typename): Remove cast.
1568         * eval.c (parse_to_comma_and_eval): Remove cast.
1569         * parse.c (write_dollar_variable): Remove cast.
1570         * block.h (struct block) <superblock>: Now const.
1571         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1572         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1573         (map_block): Make "block" const.
1574         * symfile.h (struct quick_symbol_functions)
1575         <map_matching_symbols>: Constify block argument to "callback".
1576         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1577         const.
1578         (find_pc_sect_compunit_symtab): Make "b" const.
1579         (find_symbol_at_address): Likewise.
1580         (search_symbols): Likewise.
1581         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1582         (dw2_debug_names_lookup_symbol): Likewise.
1583         (dw2_map_matching_symbols): Update.
1584         * p-valprint.c (pascal_val_print): Remove "block".
1585         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1586         (aux_add_nonlocal_symbols): Make "block" const.
1587         (resolve_subexp): Remove cast.
1588         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1589         const.
1590         (iterate_over_file_blocks): Likewise.
1591         * f-exp.y (%union) <bval>: Remove.
1592         * coffread.c (patch_opaque_types): Make "b" const.
1593         * spu-tdep.c (spu_catch_start): Make "block" const.
1594         * c-valprint.c (print_unpacked_pointer): Remove "block".
1595         * symmisc.c (dump_symtab_1): Make "b" const.
1596         (block_depth): Make "block" const.
1597         * d-exp.y (%union) <bval>: Remove.
1598         * cp-support.h (cp_lookup_rtti_type): Update.
1599         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1600         * psymtab.c (psym_lookup_symbol): Make "block" const.
1601         (maintenance_check_psymtabs): Make "b" const.
1602         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1603         (enumerate_locals, enumerate_args): Update.
1604         * python/py-symtab.c (stpy_global_block): Make "block" const.
1605         (stpy_static_block): Likewise.
1606         * inline-frame.c (block_starting_point_at): Make "new_block"
1607         const.
1608         * block.c (find_block_in_blockvector): Make return type const.
1609         (blockvector_for_pc_sect): Make "b" const.
1610         (find_block_in_blockvector): Make "b" const.
1611
1612 2019-03-23  Tom Tromey  <tom@tromey.com>
1613
1614         * varobj.c (varobj_create): Update.
1615         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1616         * printcmd.c (display_command, do_one_display): Don't reset
1617         innermost_block.
1618         * parser-defs.h (enum innermost_block_tracker_type): Move to
1619         expression.h.
1620         (innermost_block): Update comment.
1621         * parse.c (parse_exp_1): Add tracker_types parameter.
1622         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1623         tracker_types parameter.  Reset innermost_block.
1624         (parse_exp_in_context): Remove.
1625         (parse_expression_for_completion): Update.
1626         * objfiles.c (~objfile): Don't reset expression_context_block or
1627         innermost_block.
1628         * expression.h (enum innermost_block_tracker_type): Move from
1629         parser-defs.h.
1630         (parse_exp_1): Add tracker_types parameter.
1631         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1632         reset innermost_block.
1633
1634 2019-03-23  Tom Tromey  <tom@tromey.com>
1635
1636         * objfiles.h: Include bcache.h.
1637
1638 2019-03-23  Tom Tromey  <tom@tromey.com>
1639
1640         * linespec.c (get_current_search_block): Use
1641         scoped_restore_current_language.
1642         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1643
1644 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1645             Jiong Wang  <jiong.wang@arm.com>
1646
1647         * aarch64-linux-tdep.c
1648         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1649         section.
1650         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1651
1652 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1653             Jiong Wang  <jiong.wang@arm.com>
1654
1655         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1656         instructions.
1657         (aarch64_analyze_prologue_test): Add PACIASP test.
1658         (aarch64_prologue_prev_register): Unmask PC value.
1659
1660 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1661             Jiong Wang  <jiong.wang@arm.com>
1662
1663         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1664         (aarch64_dwarf2_prev_register): Unmask PC value.
1665         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1666         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1667         DW_CFA_AARCH64_negate_ra_state.
1668         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1669
1670 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1671             Jiong Wang  <jiong.wang@arm.com>
1672
1673         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1674         registers.
1675         (aarch64_pseudo_register_name): Likewise.
1676         (aarch64_pseudo_register_type): Likewise.
1677         (aarch64_pseudo_register_reggroup_p): Likewise.
1678         (aarch64_gdbarch_init): Add pauth registers.
1679         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1680         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1681         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1682         (struct gdbarch_tdep): Add regnum for ra_state.
1683
1684 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1685             Jiong Wang  <jiong.wang@arm.com>
1686
1687         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1688
1689 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1690             Jiong Wang  <jiong.wang@arm.com>
1691
1692         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1693         function.
1694         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1695         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1696         (aarch64_gdbarch_init): Add puth registers.
1697         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1698         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1699         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1700
1701 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1702             Jiong Wang  <jiong.wang@arm.com>
1703
1704         * aarch64-linux-nat.c
1705         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1706         * aarch64-linux-tdep.c
1707         (aarch64_linux_core_read_description): Likewise.
1708         (aarch64_linux_get_hwcap): New function.
1709         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1710         (aarch64_linux_get_hwcap): New declaration.
1711
1712 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1713             Jiong Wang  <jiong.wang@arm.com>
1714
1715         * aarch64-linux-nat.c
1716         (aarch64_linux_nat_target::read_description): Add pauth param.
1717         * aarch64-linux-tdep.c
1718         (aarch64_linux_core_read_description): Likewise.
1719         * aarch64-tdep.c (struct target_desc): Add in pauth.
1720         (aarch64_read_description): Add pauth param.
1721         (aarch64_gdbarch_init): Likewise.
1722         * aarch64-tdep.h (aarch64_read_description): Likewise.
1723         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1724         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1725         * features/Makefile: Add new files.
1726         * features/aarch64-pauth.c: New file.
1727         * features/aarch64-pauth.xml: New file.
1728
1729 2019-03-20  Tom Tromey  <tromey@adacore.com>
1730
1731         * infrun.c (handle_inferior_event): Rename from
1732         handle_inferior_event_1.  Create a scoped_value_mark.
1733         (handle_inferior_event): Remove.
1734
1735 2019-03-19  Tom Tromey  <tromey@adacore.com>
1736
1737         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1738         * infrun.h (print_stop_event): Add "displays" parameter.
1739         * infrun.c (print_stop_event): Add "displays" parameter.
1740
1741 2019-03-19  Pedro Alves  <palves@redhat.com>
1742
1743         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1744         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1745         to -1.  Fix TABs vs spaces.
1746         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1747         * tui/tui-out.h (tui_ui_out) Add intro comments.
1748         <m_line, m_start_of_line>: In-class initialize, and add describing
1749         comment.
1750
1751 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1752
1753         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1754         variable names.
1755         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1756
1757 2019-03-18  Pedro Alves  <palves@redhat.com>
1758             Eli Zaretskii <eliz@gnu.org>
1759
1760         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1761         m_line and m_start_of_line.
1762
1763 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1764
1765         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1766         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1767         it returns a newline.  This fixes a regression in TU mode, whereby
1768         the next line is output on the same screen line as the user input.
1769
1770 2019-03-18  Tom Tromey  <tromey@adacore.com>
1771
1772         * minsyms.c (minimal_symbol_reader::install): Remove call to
1773         obstack_blank.
1774
1775 2019-03-18  Pedro Alves  <palves@redhat.com>
1776
1777         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1778         New globals.
1779         (apply_style): New, factored out from ...
1780         (apply_ansi_escape): ... this.  Handle reverse video mode.
1781         (tui_set_reverse_mode): New function.
1782         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1783         * tui/tui-winsource.c (tui_show_source_line): Use
1784         tui_set_reverse_mode instead of setting A_STANDOUT.
1785         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1786         New setter methods.
1787
1788 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1789
1790         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1791         Handle tabs.
1792
1793 2019-03-18  Tom Tromey  <tromey@adacore.com>
1794
1795         * ada-lang.c (empty_array): Add "high" parameter.
1796         (ada_evaluate_subexp): Update.
1797
1798 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1799
1800         * unittests/string_view-selftests.c: Define
1801         _initialize_string_view_selftests unconditionally.
1802
1803 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1804
1805         PR gdb/24350
1806         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1807
1808 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1809
1810         PR gdb/24351
1811         * windows-nat.c (display_selector): Fix format specifiers.
1812
1813 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1814
1815         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1816         tui_refill_source_window instead of tui_refresh_win, to update the
1817         current execution line.  This fixes redisplay of the current line
1818         when stepping through the code with "next" or "step".
1819
1820 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1821
1822         * source-cache.c (source_cache::get_source_lines): Call
1823         find_source_lines to initialize s->nlines.  This fixes vertical
1824         scrolling of TUI source window when the DOWN arrow is pressed.
1825
1826 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1827
1828         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1829         linux-thread-db.c (_initialize_thread_db): Likewise.
1830
1831 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1832
1833         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1834         wclrtoeol in tui_show_source_line".  This reverts changes made in
1835         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1836
1837 2019-03-15  Tom Tromey  <tom@tromey.com>
1838
1839         * symtab.h (struct minimal_symbol): Derive from
1840         general_symbol_info.
1841         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1842         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1843         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1844         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1845         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1846         (MSYMBOL_SEARCH_NAME): Update.
1847         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1848         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1849         * minsyms.c (minimal_symbol_reader::record_full): Update.
1850
1851 2019-03-15  Tom Tromey  <tom@tromey.com>
1852
1853         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1854
1855 2019-03-15  Tom Tromey  <tom@tromey.com>
1856
1857         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1858         unique_xmalloc_ptr.
1859         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1860         Update.
1861         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1862         (build_minimal_symbol_hash_tables)
1863         (minimal_symbol_reader::install): Update.
1864
1865 2019-03-15  Tom Tromey  <tom@tromey.com>
1866
1867         * symtab.c (create_demangled_names_hash): Update.
1868         (symbol_set_names): Update.
1869         * objfiles.h (struct objfile_per_bfd_storage)
1870         <demangled_names_hash>: Now an htab_up.
1871         * objfiles.c (objfile_per_bfd_storage): Simplify.
1872
1873 2019-03-15  Tom Tromey  <tom@tromey.com>
1874
1875         * objfiles.h (struct objfile_per_bfd_storage): Declare
1876         destructor.
1877         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1878         New.
1879         (get_objfile_bfd_data): Use new.  Don't initialize
1880         language_of_main.
1881         (free_objfile_per_bfd_storage): Remove.
1882         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1883
1884 2019-03-15  Tom Tromey  <tom@tromey.com>
1885
1886         * symfile.c (reread_symbols): Update.
1887         * objfiles.c (objfile::objfile): Update.
1888         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1889         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1890         comment.
1891         (minimal_symbol_reader::install): Update.
1892         (terminate_minimal_symbol_table): Remove.
1893         * jit.c (jit_object_close_impl): Update.
1894
1895 2019-03-15  Tom Tromey  <tom@tromey.com>
1896
1897         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1898         initializations.
1899
1900 2019-03-15  Tom Tromey  <tom@tromey.com>
1901
1902         * objfiles.h (struct objfile_per_bfd_storage)
1903         <demangled_hash_languages>: Now a bitset.
1904         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1905         (lookup_minimal_symbol): Update.
1906
1907 2019-03-15  Tom Tromey  <tom@tromey.com>
1908
1909         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1910         Don't return the symbol.
1911         * coffread.c (record_minimal_symbol): Use record_full.
1912
1913 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1914
1915         The MS-Windows port of ncurses fails to switch to a color pair if
1916         one or both of the colors are the implicit default colors.  This
1917         change records the default colors when TUI is initialized, and
1918         then specifies them explicitly when a color pair uses the default
1919         colors.  This allows color styling in TUI mode on MS-Windows.
1920
1921         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1922         ncurses_norm_attr.
1923         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1924         colors in ncurses_norm_attr.
1925         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1926         "none", replace it with the default color recorded in
1927         ncurses_norm_attr.
1928
1929 2019-03-14  Tom Tromey  <tromey@adacore.com>
1930
1931         * source-cache.h (class source_cache) <get_source_lines>: Return
1932         std::string.
1933         * source-cache.c (source_cache::extract_lines): Handle case where
1934         first_pos==npos.  Return std::string.
1935         (source_cache::get_source_lines): Update.
1936
1937 2019-03-14  Tom Tromey  <tromey@adacore.com>
1938
1939         * NEWS: Add item for "style sources" commands.
1940         * source-cache.c (source_cache::get_source_lines): Check
1941         source_styling.
1942         * cli/cli-style.c (source_styling): New global.
1943         (_initialize_cli_style): Add "style sources" commands.
1944         (show_style_sources): New function.
1945         * cli/cli-style.h (source_styling): Declare.
1946
1947 2019-03-14  Pedro Alves  <palves@redhat.com>
1948             Tom Tromey  <tromey@adacore.com>
1949
1950         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1951         * tui/tui-winsource.c (tui_refill_source_window): New function,
1952         from...
1953         (tui_horizontal_source_scroll): ... here.  Move some logic.
1954         * cli/cli-style.c (set_style_enabled): Notify new observable.
1955         * tui/tui-hooks.c (tui_redisplay_source): New function.
1956         (tui_attach_detach_observers): Attach or detach
1957         tui_redisplay_source.
1958         * observable.h (source_styling_changed): New observable.
1959         * observable.c: Define source_styling_changed observable.
1960
1961 2019-03-13  Tom Tromey  <tromey@adacore.com>
1962
1963         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1964         (i386_gnu_nat_target::store_registers): Update.
1965         * target-debug.h (target_debug_print_std_string): New macro.
1966         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1967         * windows-tdep.c (display_one_tib): Update.
1968         * tui/tui-stack.c (tui_make_status_line): Update.
1969         * top.c (print_inferior_quit_action): Update.
1970         * thread.c (thr_try_catch_cmd): Update.
1971         (add_thread_with_info): Update.
1972         (thread_target_id_str): Update.
1973         (thr_try_catch_cmd): Update.
1974         (thread_command): Update.
1975         (thread_find_command): Update.
1976         * record-btrace.c (record_btrace_target::info_record)
1977         (record_btrace_resume_thread, record_btrace_target::resume)
1978         (record_btrace_cancel_resume, record_btrace_step_thread)
1979         (record_btrace_target::wait, record_btrace_target::wait)
1980         (record_btrace_target::wait, record_btrace_target::stop): Update.
1981         * progspace.c (print_program_space): Update.
1982         * process-stratum-target.c
1983         (process_stratum_target::thread_address_space): Update.
1984         * linux-fork.c (linux_fork_mourn_inferior)
1985         (detach_checkpoint_command, info_checkpoints_command)
1986         (linux_fork_context): Update.
1987         (linux_fork_detach): Update.
1988         (class scoped_switch_fork_info): Update.
1989         (delete_checkpoint_command): Update.
1990         * infrun.c (follow_fork_inferior): Update.
1991         (follow_fork_inferior): Update.
1992         (proceed_after_vfork_done): Update.
1993         (handle_vfork_child_exec_or_exit): Update.
1994         (follow_exec): Update.
1995         (displaced_step_prepare_throw): Update.
1996         (displaced_step_restore): Update.
1997         (start_step_over): Update.
1998         (resume_1): Update.
1999         (clear_proceed_status_thread): Update.
2000         (proceed): Update.
2001         (print_target_wait_results): Update.
2002         (do_target_wait): Update.
2003         (context_switch): Update.
2004         (stop_all_threads): Update.
2005         (restart_threads): Update.
2006         (finish_step_over): Update.
2007         (handle_signal_stop): Update.
2008         (switch_back_to_stepped_thread): Update.
2009         (keep_going_pass_signal): Update.
2010         (print_exited_reason): Update.
2011         (normal_stop): Update.
2012         * inferior.c (inferior_pid_to_str): Change return type.
2013         (print_selected_inferior): Update.
2014         (add_inferior): Update.
2015         (detach_inferior): Update.
2016         * dummy-frame.c (fprint_dummy_frames): Update.
2017         * dcache.c (dcache_info_1): Update.
2018         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2019         (btrace_fetch, btrace_clear): Update.
2020         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2021         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2022         type.
2023         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2024         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2025         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2026         * gdbarch.c, gdbarch.h: Rebuild.
2027         * gdbarch.sh (core_pid_to_str): Change return type.
2028         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2029         return type.
2030         (windows_nat_target::pid_to_str): Change return type.
2031         (windows_delete_thread): Update.
2032         (windows_nat_target::attach): Update.
2033         (windows_nat_target::files_info): Update.
2034         * target-delegates.c: Rebuild.
2035         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2036         return type.
2037         (sol_thread_target::pid_to_str): Change return type.
2038         * remote.c (class remote_target) <pid_to_str>: Change return
2039         type.
2040         (remote_target::pid_to_str): Change return type.
2041         (extended_remote_target::attach, remote_target::remote_stop_ns)
2042         (remote_target::remote_notif_remove_queued_reply)
2043         (remote_target::push_stop_reply, remote_target::disable_btrace):
2044         Update.
2045         (extended_remote_target::attach): Update.
2046         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2047         type.
2048         (gdbsim_target::pid_to_str): Change return type.
2049         * ravenscar-thread.c (struct ravenscar_thread_target)
2050         <pid_to_str>: Change return type.
2051         (ravenscar_thread_target::pid_to_str): Change return type.
2052         * procfs.c (class procfs_target) <pid_to_str>: Change return
2053         type.
2054         (procfs_target::pid_to_str): Change return type.
2055         (procfs_target::attach): Update.
2056         (procfs_target::detach): Update.
2057         (procfs_target::fetch_registers): Update.
2058         (procfs_target::store_registers): Update.
2059         (procfs_target::wait): Update.
2060         (procfs_target::files_info): Update.
2061         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2062         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2063         return type.
2064         (nto_procfs_target::pid_to_str): Change return type.
2065         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2066         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2067         return type.
2068         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2069         (exit_lwp): Update.
2070         (attach_proc_task_lwp_callback, get_detach_signal)
2071         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2072         (linux_nat_target::resume, wait_lwp, stop_callback)
2073         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2074         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2075         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2076         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2077         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2078         type.
2079         (inf_ptrace_target::attach): Update.
2080         (inf_ptrace_target::files_info): Update.
2081         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2082         type.
2083         (go32_nat_target::pid_to_str): Change return type.
2084         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2085         (gnu_nat_target::wait): Update.
2086         (gnu_nat_target::wait): Update.
2087         (gnu_nat_target::resume): Update.
2088         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2089         (fbsd_nat_target::wait): Update.
2090         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2091         type.
2092         (darwin_nat_target::attach): Update.
2093         * corelow.c (class core_target) <pid_to_str>: Change return type.
2094         (core_target::pid_to_str): Change return type.
2095         * target.c (normal_pid_to_str): Change return type.
2096         (default_pid_to_str): Likewise.
2097         (target_pid_to_str): Change return type.
2098         (target_translate_tls_address): Update.
2099         (target_announce_detach): Update.
2100         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2101         return type.
2102         (bsd_uthread_target::pid_to_str): Change return type.
2103         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2104         type.
2105         (bsd_kvm_target::pid_to_str): Change return type.
2106         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2107         return type.
2108         (aix_thread_target::pid_to_str): Change return type.
2109         * target.h (struct target_ops) <pid_to_str>: Change return type.
2110         (target_pid_to_str, normal_pid_to_str): Likewise.
2111         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2112         type.
2113         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2114         type.
2115         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2116         return type.
2117         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2118         type.
2119         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2120         type.
2121         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2122         return type.
2123
2124 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2125
2126         * NEWS: Mention that the new default MI version is 3.  Mention
2127         changes to the output of commands and events that deal with
2128         multi-location breakpoints.
2129         * breakpoint.c: Include "mi/mi-out.h".
2130         (print_one_breakpoint): Change output syntax if using MI version
2131         >= 3.
2132         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2133         New.
2134         (mi_multi_location_breakpoint_output_fixed): New.
2135         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2136         (mi_cmd_fix_multi_location_breakpoint_output): New.
2137         (mi_multi_location_breakpoint_output_fixed): New.
2138         * mi/mi-cmds.c (mi_cmds): Register command
2139         -fix-multi-location-breakpoint-output.
2140         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2141         interpreter "mi".
2142
2143 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2144
2145         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2146         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2147         instantiate mi_ui_out based on interpreter name.
2148         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2149         * mi/mi-main.c (mi_load_progress): Likewise.
2150
2151 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2152
2153         * NEWS: Combine separate "New targets" sections for 8.3.
2154
2155 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2156
2157         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2158         (ppcfbsd_init_abi): Install gdbarch
2159         "fetch_tls_load_module_address" and "get_thread_local_address"
2160         methods.
2161
2162 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2163
2164         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2165         (riscv_fbsd_init_abi): Install gdbarch
2166         "fetch_tls_load_module_address" and "get_thread_local_address"
2167         methods.
2168
2169 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2170
2171         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2172         (i386fbsd_init_abi): Install gdbarch
2173         "fetch_tls_load_module_address" and "get_thread_local_address"
2174         methods.
2175
2176 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2177
2178         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2179         (amd64fbsd_init_abi): Install gdbarch
2180         "fetch_tls_load_module_address" and "get_thread_local_address"
2181         methods.
2182
2183 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2184
2185         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2186         (struct fbsd_pspace_data): New type.
2187         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2188         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2189         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2190         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2191         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2192
2193 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2194
2195         * gdbtypes.c (lookup_struct_elt): New function.
2196         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2197         * gdbtypes.h (struct struct_elt): New type.
2198         (lookup_struct_elt): New prototype.
2199
2200 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2201
2202         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2203         remove disabled code block.
2204
2205 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2206
2207         * gdbarch.sh (get_thread_local_address): New method.
2208         * gdbarch.h, gdbarch.c: Regenerate.
2209         * target.c (target_translate_tls_address): Use
2210         gdbarch_get_thread_local_address if present instead of
2211         target::get_thread_local_address.
2212
2213 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2214
2215         * target.h (target::get_thread_local_address): Update comment.
2216
2217 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2218
2219         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2220         objfile->separate_debug_objfile_backlink if not NULL.
2221
2222 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2223
2224         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2225         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2226         (amd64bsd_store_inferior_registers): Likewise.
2227         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2228         Enable segment base registers.
2229         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2230         PT_GETFSBASE and PT_GETGSBASE.
2231         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2232         PT_SETGSBASE.
2233         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2234         segment base registers.
2235         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2236
2237 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2238
2239         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2240         Update calls to i386_target_description to add 'segments'
2241         parameter.
2242         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2243         add segment base registers.
2244         * arch/i386.c (i386_create_target_description): Add 'segments'
2245         parameter to enable segment base registers.
2246         * arch/i386.h (i386_create_target_description): Likewise.
2247         * features/i386/32bit-segments.xml: New file.
2248         * features/i386/32bit-segments.c: Generate.
2249         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2250         call to i386_target_description to add 'segments' parameter.
2251         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2252         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2253         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2254         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2255         if feature is present.
2256         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2257         Add 'segments' parameter to call to i386_target_description.
2258         (i386_target_description): Add 'segments' parameter to enable
2259         segment base registers.
2260         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2261         to call to i386_target_description.
2262         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2263         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2264         Define I386_NUM_REGS.
2265         (i386_target_description): Add 'segments' parameter to enable
2266         segment base registers.
2267
2268 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2269
2270         PR/24325
2271         * source-cache.c: #undef open and close, to avoid unresolved
2272         externals during linking.
2273
2274 2019-03-12  Tom Tromey  <tromey@adacore.com>
2275
2276         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2277         const.  Add initializers.
2278         (_initialize_remote): Don't initialize ptid globals.
2279
2280 2019-03-12  Pedro Alves  <palves@redhat.com>
2281
2282         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2283
2284 2019-03-12  Pedro Alves  <palves@redhat.com>
2285
2286         * cp-name-parser.y (main): Remove unused 'len' variable.
2287
2288 2019-03-12  Tom Tromey  <tromey@adacore.com>
2289
2290         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2291         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2292
2293 2019-03-12  Tom Tromey  <tromey@adacore.com>
2294
2295         * linux-nat.c (iterate_over_lwps): Update.
2296         (stop_callback): Remove parameter.
2297         (stop_wait_callback, detach_callback, resume_set_callback)
2298         (select_singlestep_lwp_callback, set_ignore_sigint)
2299         (status_callback, resumed_callback, resume_clear_callback)
2300         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2301         data parameter.
2302         (linux_nat_target::detach, linux_nat_target::resume)
2303         (linux_stop_and_wait_all_lwps, select_event_lwp)
2304         (linux_nat_filter_event, linux_nat_wait_1)
2305         (linux_nat_target::kill, linux_nat_target::stop)
2306         (linux_nat_target::stop): Update.
2307         (linux_nat_resume_callback): Change type.
2308         (resume_stopped_resumed_lwps, count_events_callback)
2309         (select_event_lwp_callback): Likewise.
2310         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2311         * arm-linux-nat.c (struct update_registers_data): Remove.
2312         (update_registers_callback): Change type.
2313         (arm_linux_insert_hw_breakpoint1): Update.
2314         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2315         parameter.
2316         (x86_linux_dr_set_addr): Update.
2317         (x86_linux_dr_set_control): Update.
2318         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2319         (iterate_over_lwps): Use gdb::function_view.
2320         * nat/aarch64-linux-hw-point.c (struct
2321         aarch64_dr_update_callback_param): Remove.
2322         (debug_reg_change_callback): Change type.
2323         (aarch64_notify_debug_reg_change): Update.
2324         * s390-linux-nat.c (s390_refresh_per_info): Update.
2325
2326 2019-03-11  Tom Tromey  <tromey@adacore.com>
2327
2328         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2329         redundant assignment to "this_cu".
2330
2331 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2332
2333         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2334
2335 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2336
2337         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2338         from...
2339         (rank_one_type): ... this.
2340
2341 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2342
2343         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2344         from...
2345         (rank_one_type): ... this.
2346
2347 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2348
2349         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2350         from...
2351         (rank_one_type): ... this.
2352
2353 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2354
2355         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2356         from...
2357         (rank_one_type): ... this.
2358
2359 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2360
2361         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2362         from...
2363         (rank_one_type): ... this.
2364
2365 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2366
2367         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2368         from...
2369         (rank_one_type): ... this.
2370
2371 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2372
2373         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2374         from...
2375         (rank_one_type): ... this.
2376
2377 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2378
2379         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2380         from...
2381         (rank_one_type): ... this.
2382
2383 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2384
2385         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2386         from...
2387         (rank_one_type): ... this.
2388
2389 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2390
2391         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2392         from...
2393         (rank_one_type): ... this.
2394
2395 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2396
2397         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2398         from...
2399         (rank_one_type): ... this.
2400
2401 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2402
2403         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2404         from...
2405         (rank_one_type): ... this.
2406
2407 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2408
2409         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2410         inferior-events' shows the example events.
2411
2412 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2413
2414         Support styling on native MS-Windows console
2415
2416         PR/24315
2417         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2418         on MS-Windows if $TERM is not defined.
2419
2420         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2421
2422         * posix-hdep.c (gdb_console_fputs):
2423         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2424         functions.
2425         * ui-file.h (gdb_console_fputs): Add prototype.
2426
2427         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2428         back to fputs only if the former returns zero.
2429
2430 2019-03-07  Tom Tromey  <tom@tromey.com>
2431
2432         * symmisc.c (print_symbol_bcache_statistics): Update.
2433         (print_objfile_statistics): Update.
2434         * symfile.c (allocate_symtab): Update.
2435         * stabsread.c: Don't include bcache.h.
2436         * psymtab.h (struct psymbol_bcache): Don't declare.
2437         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2438         (psymbol_bcache_init, psymbol_bcache_free)
2439         (psymbol_bcache_get_bcache): Don't declare.
2440         * psymtab.c (struct psymbol_bcache): Remove.
2441         (psymtab_storage::psymtab_storage): Update.
2442         (psymtab_storage::~psymtab_storage): Update.
2443         (psymbol_bcache_init, psymbol_bcache_free)
2444         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2445         (add_psymbol_to_bcache): Update.
2446         (allocate_psymtab): Update.
2447         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2448         macro_cache>: No longer pointers.
2449         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2450         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2451         * macrotab.c (macro_bcache): Update.
2452         * macroexp.c: Don't include bcache.h.
2453         * gdbtypes.c (check_types_worklist): Update.
2454         (types_deeply_equal): Remove TRY/CATCH.  Update.
2455         * elfread.c (elf_symtab_read): Update.
2456         * dwarf2read.c: Don't include bcache.h.
2457         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2458         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2459         (print_bcache_statistics, bcache_memory_used): Don't declare.
2460         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2461         methods.  Rename all data members.
2462         * bcache.c (struct bcache): Move to bcache.h.
2463         (bcache::expand_hash_table): Rename from expand_hash_table.
2464         (bcache): Remove.
2465         (bcache::insert): Rename from bcache_full.
2466         (bcache::compare): Rename from bcache_compare.
2467         (bcache_xmalloc): Remove.
2468         (bcache::~bcache): Rename from bcache_xfree.
2469         (bcache::print_statistics): Rename from print_bcache_statistics.
2470         (bcache::memory_used): Rename from bcache_memory_used.
2471
2472 2019-03-07  Pedro Alves  <palves@redhat.com>
2473
2474         * infrun.c (normal_stop): Also check for
2475         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2476
2477 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2478
2479         * f-lang.c (value_from_host_double): Moved to...
2480         * value.c (value_from_host_double): ...here.
2481         * value.h (value_from_host_double): Declare.
2482         * guile/scm-math.c (vlscm_convert_typed_number): Use
2483         value_from_host_double.
2484         (vlscm_convert_number): Likewise.
2485         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2486         * python/py-value.c (convert_value_from_python): Likewise.
2487
2488 2019-03-06  Tom Tromey  <tom@tromey.com>
2489
2490         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2491
2492 2019-03-06  Tom Tromey  <tom@tromey.com>
2493
2494         * utils.h (free_current_contents): Don't declare.
2495         * utils.c (free_current_contents): Remove.
2496
2497 2019-03-06  Tom Tromey  <tom@tromey.com>
2498
2499         * top.c (quit_force): Update.
2500         * main.c (captured_command_loop): Update.
2501         * common/new-op.c (operator new): Update.
2502         * common/common-exceptions.c (struct catcher)
2503         <save_cleanup_chain>: Remove member.
2504         (exceptions_state_mc_init): Update.
2505         (exception_try_scope_entry): Return nullptr.
2506         (exception_try_scope_exit, exception_rethrow)
2507         (throw_exception_sjlj, throw_exception_cxx): Update.
2508         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2509         (all_cleanups, do_cleanups, discard_cleanups)
2510         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2511         (restore_cleanups, restore_final_cleanups): Don't declare.
2512         (do_final_cleanups): Remove parameter.
2513         * common/cleanups.c (cleanup_chain, make_cleanup)
2514         (make_cleanup_dtor, all_cleanups, do_cleanups)
2515         (discard_my_cleanups, discard_cleanups)
2516         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2517         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2518         (null_cleanup): Remove.
2519         (do_final_cleanups): Remove parameter.
2520
2521 2019-03-06  Tom Tromey  <tom@tromey.com>
2522
2523         * remote.c (remote_target::remote_parse_stop_reply): Use
2524         unique_xmalloc_ptr.
2525
2526 2019-03-06  Tom Tromey  <tom@tromey.com>
2527
2528         * stabsread.c (struct stabs_field_info): Rename from field_info.
2529         <list, fnlist>: Add initializers.
2530         <obstack>: New member.
2531         (read_member_functions, read_struct_fields, read_baseclasses):
2532         Allocate on obstack.  Don't use cleanups.
2533         (read_one_struct_field, read_member_functions, read_struct_fields)
2534         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2535         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2536         (read_struct_type): Update.
2537
2538 2019-03-06  Tom Tromey  <tom@tromey.com>
2539
2540         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2541         * common/filestuff.h (make_cleanup_close): Don't declare.
2542         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2543         Remove.
2544
2545 2019-03-06  Tom Tromey  <tom@tromey.com>
2546
2547         * solib-aix.c: Use make_scope_exit.
2548
2549 2019-03-06  Tom Tromey  <tom@tromey.com>
2550
2551         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2552         Use make_scope_exit.
2553
2554 2019-03-06  Tom Tromey  <tom@tromey.com>
2555
2556         * solib-svr4.c (disable_probes_interface): Remove parameter.
2557         (svr4_handle_solib_event): Use make_scope_exit.
2558
2559 2019-03-06  Tom Tromey  <tom@tromey.com>
2560
2561         * remote.c (struct stop_reply_deleter): Remove.
2562         (stop_reply_up): Update.
2563         (struct stop_reply): Derive from notif_event.  Don't typedef.
2564         <regcache>: Now a std::vector.
2565         (stop_reply_xfree): Remove.
2566         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2567         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2568         (remote_target::discard_pending_stop_replies): Use delete.
2569         (remote_target::remote_parse_stop_reply): Update.
2570         (remote_target::process_stop_reply): Update.
2571         * remote-notif.h (struct notif_event): Add virtual destructor.
2572         Remove "dtr" member.
2573         (struct notif_client) <alloc_event>: Return a unique_ptr.
2574         (notif_event_xfree): Don't declare.
2575         (notif_event_up): New typedef.
2576         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2577         (notif_event_xfree, do_notif_event_xfree): Remove.
2578         (remote_notif_state_xfree): Update.
2579
2580 2019-03-06  Tom Tromey  <tom@tromey.com>
2581
2582         * infrun.c (displaced_step_clear_cleanup): Now a
2583         forward_scope_exit type.
2584         (displaced_step_prepare_throw): Update.
2585         (displaced_step_fixup): Update.
2586
2587 2019-03-06  Tom Tromey  <tom@tromey.com>
2588
2589         * inferior.h (class inferior): Update comment.
2590         * gdbthread.h (class thread_info): Update comment.
2591
2592 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2593             Tom Tromey  <tom@tromey.com>
2594
2595         * stabsread.h (struct stab_section_list): Remove.
2596         (coffstab_build_psymtabs): Update.
2597         * dbxread.c (symbuf_sections): Now a std::vector.
2598         (sect_idx): New global.
2599         (fill_symbuf): Update.
2600         (coffstab_build_psymtabs): Change type of stabsects parameter.
2601         Update.
2602         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2603         std::vector.
2604         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2605         (coff_locate_sections): Update.
2606         (coff_symfile_read): Remove cleanups.  Update.
2607         (init_stringtab): Add storage parameter.
2608         (free_stringtab, free_stringtab_cleanup): Remove.
2609         (init_lineno): Add storage parameter.
2610         (free_linetab, free_linetab_cleanup): Remove.
2611
2612 2019-03-06  Pedro Alves  <palves@redhat.com>
2613
2614         * linux-fork.c (fork_info::clobber_regs): Delete.
2615         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2616         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2617         comment.  Adjust.
2618         (scoped_switch_fork_info::scoped_switch_fork_info)
2619         (checkpoint_command, linux_fork_context): Adjust
2620         fork_save_infrun_state calls.
2621
2622 2019-03-06  Pedro Alves  <palves@redhat.com>
2623
2624         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2625         (inf_has_multiple_threads): Return 'bool' and rewrite using
2626         inferior_info::threads().
2627
2628 2019-03-06  Pedro Alves  <palves@redhat.com>
2629
2630         * linux-fork.c: Include <list>.
2631         (fork_list): Now a std::list instance.
2632         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2633         (forks_exist_p, find_last_fork): Adjust.
2634         (new_fork): Delete.
2635         (one_fork_p): New.
2636         (add_fork): Adjust.
2637         (free_fork): Delete, folded into fork_info::~fork_info().
2638         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2639         Adjust.
2640         (init_fork_list): Delete.
2641         (linux_fork_killall, linux_fork_mourn_inferior)
2642         (linux_fork_detach, info_checkpoints_command): Adjust.
2643         (_initialize_linux_fork): No longer call init_fork_list.
2644
2645 2019-03-06  Pedro Alves  <palves@redhat.com>
2646
2647         * linux-fork.c (new_fork): New, split out of ...
2648         (add_fork): ... this.  Return void.  Move "first fork" special
2649         case from here, to ...
2650         (checkpoint_command): ... here.
2651         * linux-linux.h (add_fork): Return void.
2652
2653 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2654
2655         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2656
2657 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2658             Chris January  <chris.january@arm.com>
2659             David Lecomber  <david.lecomber@arm.com>
2660
2661         * f-exp.y: New token, UNOP_INTRINSIC.
2662         (exp): New pattern using UNOP_INTRINSIC token.
2663         (f77_keywords): Add 'abs' keyword.
2664         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2665         (value_from_host_double): New function.
2666         (evaluate_subexp_f): Support UNOP_ABS.
2667
2668 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2669
2670         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2671         types.
2672
2673 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2674
2675         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2676         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2677         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2678
2679 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2680
2681         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2682
2683 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2684             Chris January  <chris.january@arm.com>
2685
2686         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2687         * f-exp.y: Define 'KIND' token.
2688         (exp): New pattern for KIND expressions.
2689         (ptype): Handle types with a kind extension.
2690         (direct_abs_decl): Extend to spot kind extensions.
2691         (f77_keywords): Add 'kind' to the list.
2692         (push_kind_type): New function.
2693         (convert_to_kind_type): New function.
2694         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2695         * parse.c (operator_length_standard): Likewise.
2696         * parser-defs.h (enum type_pieces): Add tp_kind.
2697         * std-operator.def: Add UNOP_KIND.
2698
2699 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2700
2701         * f-exp.y (f_parse): Set yydebug.
2702
2703 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2704
2705         * f-lang.c (evaluate_subexp_f): New function.
2706         (exp_descriptor_f): New global.
2707         (f_language_defn): Use exp_descriptor_f instead of
2708         exp_descriptor_standard.
2709
2710 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2711
2712         * f-exp.y (struct token): Add comments.
2713         (dot_ops): Remove uppercase versions and the end marker.
2714         (f77_keywords): Likewise.
2715         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2716         entries in the dot_ops array are case insensitive, and use
2717         strncasecmp to compare strings.  Also some whitespace cleanup in
2718         this area.  Similar for the f77_keywords array, except entries in
2719         this list might be case sensitive.
2720
2721 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2722
2723         * f-exp.y (struct f77_boolean_val): Add comments.
2724         (boolean_values): Remove uppercase versions, and end marker.
2725         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2726         and use strncasecmp to achieve case insensitivity.  Additionally,
2727         perform whitespace cleanup around this code.
2728
2729 2019-03-06  Tom Tromey  <tromey@adacore.com>
2730
2731         * remote-sim.c (gdbsim_target_open): Use result of
2732         gdb_argv::release.
2733
2734 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2735         Dirk Schubert  <dirk.schubert@arm.com>
2736         Chris January  <chris.january@arm.com>
2737
2738         * eval.c (evaluate_subexp_standard): Call Fortran argument
2739         wrapping logic.
2740         * f-lang.c (struct value): A value which can be passed into a
2741         Fortran function call.
2742         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2743         where appropriate.
2744         (struct type): Value ready for a Fortran function call.
2745         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2746         is needed.
2747         * f-lang.h (fortran_argument_convert): Declaration.
2748         (fortran_preserve_arg_pointer): Declaration.
2749         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2750
2751 2019-03-05  Tom Tromey  <tromey@adacore.com>
2752
2753         * python/py-prettyprint.c (print_string_repr): Remove #if.
2754         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2755
2756 2019-03-05  Tom Tromey  <tromey@adacore.com>
2757
2758         * target.c (the_dummy_target): Move later.  Change type to
2759         "dummy_target".
2760         (initialize_targets): Don't initialize the_dummy_target.
2761
2762 2019-03-05  Tom Tromey  <tromey@adacore.com>
2763
2764         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2765         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2766
2767 2019-03-05  Tom Tromey  <tromey@adacore.com>
2768
2769         * windows-nat.c (windows_nat_target::attach)
2770         (windows_nat_target::detach): Don't call gdb_flush.
2771         * valprint.c (generic_val_print, val_print, val_print_string):
2772         Don't call gdb_flush.
2773         * utils.c (defaulted_query): Don't call gdb_flush.
2774         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2775         * target.c (target_announce_detach): Don't call gdb_flush.
2776         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2777         * remote.c (extended_remote_target::attach): Don't call
2778         gdb_flush.
2779         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2780         * printcmd.c (do_examine): Don't call gdb_flush.
2781         (info_display_command): Don't call gdb_flush.
2782         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2783         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2784         * memattr.c (info_mem_command): Don't call gdb_flush.
2785         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2786         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2787         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2788         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2789         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2790         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2791         (gnu_nat_target::detach): Don't call gdb_flush.
2792         * f-valprint.c (f_val_print): Don't call gdb_flush.
2793         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2794         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2795         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2796         gdb_flush.
2797         * c-valprint.c (c_val_print): Don't call gdb_flush.
2798         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2799
2800 2019-03-05  Tom Tromey  <tromey@adacore.com>
2801
2802         * varobj.c (update_dynamic_varobj_children): Update.
2803         (install_default_visualizer): Use reset, not release.
2804         * value.c (set_internalvar): Update.
2805         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2806         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2807         ATTRIBUTE_UNUSED_RESULT.
2808
2809 2019-03-05  Tom Tromey  <tromey@adacore.com>
2810
2811         * remote.c (class scoped_remote_fd) <release>: Add
2812         ATTRIBUTE_UNUSED_RESULT.
2813
2814 2019-03-05  Tom Tromey  <tromey@adacore.com>
2815
2816         * macroexp.c (struct macro_buffer) <release>: Add
2817         ATTRIBUTE_UNUSED_RESULT.
2818
2819 2019-03-05  Tom Tromey  <tromey@adacore.com>
2820
2821         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2822         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2823         ATTRIBUTE_UNUSED_RESULT.
2824
2825 2019-03-05  Tom Tromey  <tromey@adacore.com>
2826
2827         * common/scoped_fd.h (class scoped_fd) <release>: Add
2828         ATTRIBUTE_UNUSED_RESULT.
2829
2830 2019-03-05  Tom Tromey  <tromey@adacore.com>
2831
2832         * parser-defs.h (struct parser_state) <release>: Add
2833         ATTRIBUTE_UNUSED_RESULT.
2834
2835 2019-03-05  Tom Tromey  <tromey@adacore.com>
2836
2837         * utils.h (class gdb_argv) <release>: Add
2838         ATTRIBUTE_UNUSED_RESULT.
2839         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2840
2841 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2842
2843         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2844         for-loop range, to avoid compiler warnings.
2845
2846         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2847         avoid compiler warnings about unused variables.
2848
2849         * NEWS: Mention end of support for native debugging on MS-Windows
2850         before XP.
2851
2852         PR gdb/24292
2853         * common/netstuff.c:
2854         * gdbserver/gdbreplay.c
2855         * gdbserver/remote-utils.c:
2856         * ser-tcp.c:
2857         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2858         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2859         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2860         'getaddrinfo' and 'freeaddrinfo' were not available before
2861         Windows XP, and mingw.org's MinGW headers by default define
2862         _WIN32_WINNT to 0x500.
2863
2864 2019-03-01  Gary Benson <gbenson@redhat.com>
2865
2866         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2867
2868 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2869             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2870
2871         PR gdb/8527
2872         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2873         set_sigint_trap, clear_sigint_trap.
2874
2875 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2876
2877         * target.c (target_detach): Clear the regcache and the
2878         frame cache.
2879
2880 2019-02-27  Pedro Alves  <palves@redhat.com>
2881
2882         * utils.c (set_screen_size): When we cap the height/width sizes,
2883         tweak the corresponding command variable to show "unlimited":
2884
2885 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2886             Pedro Alves  <palves@redhat.com>
2887
2888         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2889         before calling rl_set_screen_size.
2890
2891 2019-02-27  Tom Tromey  <tromey@adacore.com>
2892
2893         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2894         define.
2895         * python/py-value.c: Remove Python 2.4 workaround.
2896         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2897         workaround.
2898         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2899         Python 2.4 workaround.
2900         * python/python-internal.h: Remove Python 2.4 comment.
2901         (Py_ssize_t): Don't define.
2902         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2903         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2904         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2905         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2906         * python/python.c (do_start_initialization): Remove Python 2.4
2907         workaround.
2908         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2909         (print_children): Remove Python 2.4 workaround.
2910         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2911         workaround.
2912         (CHARBUFFERPROC_NAME): Remove.
2913         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2914         Python 2.4 workaround.
2915
2916 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2917
2918         * NEWS: Note minimum Python version.
2919
2920 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2921
2922         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2923         code from these functions.  Remove corresponding ifdefs.  Use
2924         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2925         Remove gotos and target of gotos.
2926         (infpy_search_memory): Likewise.
2927
2928 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2929
2930         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2931         (hppa_gdbarch_init): Don't register deleted functions with
2932         gdbarch.
2933
2934 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2935
2936         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2937         (h8300_unwind_sp): Delete.
2938         (h8300_dummy_id): Delete.
2939         (h8300_gdbarch_init): Don't register deleted functions with
2940         gdbarch.
2941
2942 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2943
2944         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2945         (ft32_unwind_pc): Delete.
2946         (ft32_unwind_sp): Delete.
2947         (ft32_gdbarch_init): Don't register deleted functions with
2948         gdbarch.
2949
2950 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2951
2952         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2953         (frv_unwind_pc): Delete.
2954         (frv_unwind_sp): Delete.
2955         (frv_gdbarch_init): Don't register deleted functions with
2956         gdbarch.
2957
2958 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2959
2960         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2961         (riscv_unwind_pc): Delete.
2962         (riscv_unwind_sp): Delete.
2963         (riscv_gdbarch_init): Don't register deleted functions with
2964         gdbarch.
2965
2966 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2967
2968         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2969         (csky_unwind_pc): Delete.
2970         (csky_unwind_sp): Delete.
2971         (csky_gdbarch_init): Don't register deleted functions with
2972         gdbarch.
2973
2974 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2975
2976         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2977         (cris_unwind_pc): Delete.
2978         (cris_unwind_sp): Delete.
2979         (cris_gdbarch_init): Don't register deleted functions with
2980         gdbarch.
2981
2982 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2983
2984         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2985         (bfin_unwind_pc): Delete.
2986         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2987
2988 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2989
2990         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2991         (arm_unwind_pc): Delete.
2992         (arm_unwind_sp): Delete.
2993         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2994
2995 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2996
2997         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2998         (arc_unwind_pc): Delete.
2999         (arc_unwind_sp): Delete.
3000         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3001
3002 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3003
3004         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3005         (alpha_unwind_pc): Delete.
3006         (alpha_gdbarch_init): Don't register deleted functions with
3007         gdbarch.
3008
3009 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3010
3011         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3012         (aarch64_unwind_pc): Delete.
3013         (aarch64_unwind_sp): Delete.
3014         (aarch64_gdbarch_init): Don't register deleted functions with
3015         gdbarch.
3016
3017 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3018
3019         * gdbtypes.c (type_align): Don't consider static members when
3020         computing structure alignment.
3021
3022 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3023
3024         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3025         return 0 for other types.
3026         * arch-utils.c (default_type_align): Always return 0.
3027         * gdbarch.h: Regenerate.
3028         * gdbarch.sh (type_align): Extend comment.
3029         * gdbtypes.c (type_align): Add additional comments, always call
3030         gdbarch_type_align before applying the default rules.
3031         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3032         generic code will then apply a suitable default.
3033         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3034         types, return 0 for other types.
3035
3036 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3037
3038         * NEWS: Create a new section for the next release branch.
3039         Rename the section of the current branch, now that it has
3040         been cut.
3041
3042 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3043
3044         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3045         * version.in: Bump version to 8.3.50.DATE-git.
3046
3047 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3048
3049         * aix-thread.c (ptid_cmp): Remove unused variable.
3050         (get_signaled_thread): Likewise.
3051         (store_regs_user_thread): Likewise.
3052         (store_regs_kernel_thread): Likewise.
3053         (fetch_regs_kernel_thread): Remove shadowed variable.
3054
3055 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3056
3057         * features/riscv/32bit-cpu.xml: Add register numbers.
3058         * features/riscv/32bit-fpu.c: Regenerate.
3059         * features/riscv/32bit-fpu.xml: Add register numbers.
3060         * features/riscv/64bit-cpu.xml: Add register numbers.
3061         * features/riscv/64bit-fpu.c: Regenerate.
3062         * features/riscv/64bit-fpu.xml: Add register numbers.
3063
3064 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3065
3066         * NEWS: Mention two argument form of gdb.Value constructor.
3067         * python/py-value.c (convert_buffer_and_type_to_value): New
3068         function.
3069         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3070         Add support for handling an optional second argument.  Call
3071         convert_buffer_and_type_to_value as appropriate.
3072         * python/python-internal.h (Py_buffer_deleter): New struct.
3073         (Py_buffer_up): New typedef.
3074
3075 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3076
3077         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3078         instead of releasing ownership.
3079
3080 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3081
3082         * dwarf2read.c (open_and_init_dwp_file): Call
3083         elf_numsections instead of bfd_count_sections to initialize
3084         dwp_file->num_sections.
3085
3086 2019-02-25  Tom Tromey  <tromey@adacore.com>
3087
3088         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3089
3090 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3091
3092         * gcore.in: Add '--readnever' option when invoking GDB.
3093
3094 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3095
3096         * MAINTAINERS: Update my email address.
3097
3098 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3099
3100         * build-id.c (build_id_to_debug_bfd_1): New function.
3101         (build_id_to_debug_bfd): Look for separate debug file in
3102         sysroot.
3103
3104 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3105
3106         * gdbarch.sh: Update the copyright year range that is placed into
3107         generated files.
3108
3109 2019-02-22  Keith Seitz  <keiths@redhat.com>
3110
3111         PR symtab/23853
3112         * linespec.c (create_sals_line_offset): Search for the default
3113         symtab's filename instead of its fullname.
3114
3115 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3116
3117         * NEWS: Update style defaults.
3118
3119 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3120
3121         * main.c (captured_main_1): Disable styling in batch mode.
3122
3123 2019-02-20  Tom Tromey  <tom@tromey.com>
3124
3125         * symtab.c (symtab_symbol_info): Fix typos.
3126
3127 2019-02-20  Tom Tromey  <tromey@adacore.com>
3128
3129         * findcmd.c (_initialize_mem_search): Use upper case for
3130         metasyntactic variables.
3131
3132 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3133
3134         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3135         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3136
3137 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3138
3139         * top.h (source_file_name): Change to std::string.
3140         * top.c (source_file_name): Likewise.
3141         (command_line_input): Adjust.
3142         * cli/cli-script.c (script_from_file): Adjust.
3143
3144 2019-02-19  Tom Tromey  <tromey@adacore.com>
3145
3146         * ravenscar-thread.c
3147         (ravenscar_thread_target::update_thread_list): Don't call
3148         ada_build_task_list.
3149         * ada-lang.h (ada_build_task_list): Don't declare.
3150         * ada-tasks.c (struct ada_tasks_inferior_data)
3151         <task_list_valid_p>: Now bool.
3152         (read_known_tasks, ada_task_list_changed)
3153         (ada_tasks_invalidate_inferior_data): Update.
3154         (read_known_tasks_array): Return bool.
3155         (read_known_tasks_list): Likewise.
3156         (read_known_tasks): Return void.
3157         (ada_build_task_list): Now static.
3158
3159 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3160
3161         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3162         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3163
3164 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3165
3166         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3167         variant for ada_tasks_pspace_data_handle and
3168         ada_tasks_inferior_data_handle.
3169         (ada_tasks_pspace_data_cleanup): New function.
3170         (ada_tasks_inferior_data_cleanup): New function.
3171
3172 2019-02-17  Tom Tromey  <tom@tromey.com>
3173
3174         * macrotab.h (macro_source_fullname): Return a std::string.
3175         * macrotab.c (macro_include, check_for_redefinition)
3176         (macro_undef, macro_lookup_definition, foreach_macro)
3177         (foreach_macro_in_scope): Update.
3178         (macro_source_fullname): Return a std::string.
3179         * macrocmd.c (show_pp_source_pos): Update.
3180
3181 2019-02-17  Tom Tromey  <tom@tromey.com>
3182
3183         * macrocmd.c (show_pp_source_pos): Style the file names.
3184
3185 2019-02-17  Tom Tromey  <tom@tromey.com>
3186
3187         PR tui/24197:
3188         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3189
3190 2019-02-17  Tom Tromey  <tom@tromey.com>
3191
3192         * ada-lang.c (user_select_syms): Use filtered printing.
3193         * utils.c (wrap_style): New global.
3194         (desired_style): Remove.
3195         (emit_style_escape): Add stream parameter.
3196         (set_output_style, reset_terminal_style, prompt_for_continue):
3197         Update.
3198         (flush_wrap_buffer): Only flush gdb_stdout.
3199         (wrap_here): Set wrap_style.
3200         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3201         treat escape sequences as a character.  Change when wrap buffer is
3202         flushed.
3203         (fputs_styled): Do not set the output style when the default is
3204         requested.
3205         * ui-style.h (struct ui_file_style) <is_default>: New method.
3206         * source.c (print_source_lines_base): Emit escape sequences in one
3207         piece.
3208
3209 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3210
3211         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3212         integers and enumeration types.
3213
3214 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3215
3216         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3217         instead of lookup_symbol_in_language
3218         (do_exact_match): New function.
3219         (ada_get_symbol_name_matcher): Return do_exact_match when
3220         doing a verbatim match.
3221
3222 2019-02-15  Tom Tromey  <tromey@adacore.com>
3223
3224         * ravenscar-thread.c (ravenscar_thread_target::resume)
3225         (ravenscar_thread_target::wait): Special case wildcard requests.
3226
3227 2019-02-15  Tom Tromey  <tromey@adacore.com>
3228
3229         * ravenscar-thread.c (base_ptid): Remove.
3230         (struct ravenscar_thread_target) <close>: New method.
3231         <m_base_ptid>: New member.
3232         <update_inferior_ptid, active_task, task_is_currently_active,
3233         runtime_initialized>: Declare methods.
3234         <ravenscar_thread_target>: Add constructor.
3235         (ravenscar_thread_target::task_is_currently_active)
3236         (ravenscar_thread_target::update_inferior_ptid)
3237         (ravenscar_runtime_initialized): Rename.  Now methods.
3238         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3239         (ravenscar_thread_target::update_thread_list): Update.
3240         (ravenscar_thread_target::active_task): Now method.
3241         (ravenscar_thread_target::store_registers)
3242         (ravenscar_thread_target::prepare_to_store)
3243         (ravenscar_thread_target::prepare_to_store)
3244         (ravenscar_thread_target::mourn_inferior): Update.
3245         (ravenscar_inferior_created): Use "new" to create target.
3246         (ravenscar_thread_target::get_ada_task_ptid): Update.
3247         (_initialize_ravenscar): Don't initialize base_ptid.
3248         (ravenscar_ops): Remove global.
3249
3250 2019-02-15  Tom Tromey  <tromey@adacore.com>
3251
3252         * target.h (push_target): Declare new overload.
3253         * target.c (push_target): New overload, taking an rvalue reference.
3254         * remote.c (remote_target::open_1): Use push_target overload.
3255         * corelow.c (core_target_open): Use push_target overload.
3256
3257 2019-02-15  Tom Tromey  <tromey@adacore.com>
3258
3259         * ravenscar-thread.c (is_ravenscar_task)
3260         (ravenscar_task_is_currently_active): Return bool.
3261         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3262         (_initialize_ravenscar): Remove "(void)".
3263         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3264         Return bool.
3265
3266 2019-02-15  Tom Tromey  <tromey@adacore.com>
3267
3268         * ravenscar-thread.c (ravenscar_runtime_initializer)
3269         (has_ravenscar_runtime, get_running_thread_id)
3270         (ravenscar_thread_target::resume): Fix indentation.
3271
3272 2019-02-15  Tom Tromey  <tromey@adacore.com>
3273
3274         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3275         from ravenscar_arch_ops.
3276         (sparc_ravenscar_ops::fetch_registers)
3277         (sparc_ravenscar_ops::store_registers): Now methods.
3278         (sparc_ravenscar_prepare_to_store): Remove.
3279         (sparc_ravenscar_ops): Redefine.
3280         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3281         methods and destructor.  Remove members.
3282         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3283         (ravenscar_thread_target::store_registers)
3284         (ravenscar_thread_target::prepare_to_store): Update.
3285         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3286         Remove.
3287         (struct ppc_ravenscar_powerpc_ops): Derive from
3288         ravenscar_arch_ops.
3289         (ppc_ravenscar_powerpc_ops::fetch_registers)
3290         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3291         (ppc_ravenscar_powerpc_ops): Redefine.
3292         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3293         (ppc_ravenscar_e500_ops::fetch_registers)
3294         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3295         (ppc_ravenscar_e500_ops): Redefine.
3296         * aarch64-ravenscar-thread.c
3297         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3298         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3299         (aarch64_ravenscar_fetch_registers)
3300         (aarch64_ravenscar_store_registers): Now methods.
3301         (aarch64_ravenscar_ops): Redefine.
3302
3303 2019-02-15  Tom Tromey  <tromey@adacore.com>
3304
3305         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3306         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3307         (ravenscar_thread_target::stopped_by_watchpoint)
3308         (ravenscar_thread_target::stopped_data_address)
3309         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3310
3311 2019-02-15  Tom Tromey  <tromey@adacore.com>
3312
3313         * ravenscar-thread.c: Fix some typos.
3314
3315 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3316             Tom Tromey  <tromey@adacore.com>
3317
3318         * ada-lang.c (ada_exception_sal): Change addr_string to a
3319         std::string.
3320         (create_ada_exception_catchpoint): Update.
3321
3322 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3323             Tom Tromey  <tromey@adacore.com>
3324
3325         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3326         (bp_location_ops): Remove.
3327         (base_breakpoint_allocate_location): Update.
3328         (free_bp_location): Update.
3329         * ada-lang.c (class ada_catchpoint_location)
3330         <ada_catchpoint_location>: Remove ops parameter.
3331         (ada_catchpoint_location_dtor): Remove.
3332         (ada_catchpoint_location_ops): Remove.
3333         (allocate_location_exception): Update.
3334         * breakpoint.h (struct bp_location_ops): Remove.
3335         (class bp_location) <bp_location>: Remove bp_location_ops
3336         parameter.
3337         <~bp_location>: Add destructor.
3338         <ops>: Remove.
3339
3340 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3341             Pedro Alves  <palves@redhat.com>
3342
3343         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3344         'PATH_MAX'.
3345
3346 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3347             Samuel Thibault  <samuel.thibault@gnu.org>
3348             Thomas Schwinge  <thomas@codesourcery.com>
3349
3350         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3351         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3352
3353 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3354
3355         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3356         (check_empty): Use "const char *".
3357
3358         * gnu-nat.c (gnu_nat_target::detach): Instead of
3359         'detach_inferior (pid)' call
3360         'detach_inferior (find_inferior_pid (pid))'.
3361
3362         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3363         'nat/fork-inferior.o'.
3364         * gnu-nat.c: #include "nat/fork-inferior.h".
3365
3366         * gnu-nat.c (gnu_nat_target::detach): Instead of
3367         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3368         * gnu-nat.h: #include "inf-child.h".
3369         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3370         'i386_gnu_nat_target::fetch_registers'.
3371         (gnu_store_registers): Rename/move to
3372         'i386_gnu_nat_target::store_registers'.
3373
3374         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3375         * gnu-nat.h (mach_thread_info): New function.
3376         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3377
3378         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3379
3380 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3381
3382         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3383
3384 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3385
3386         * windows-nat.c (windows_add_thread): Add new parameter
3387         "main_thread_p" with default value set to false.  Update
3388         function documentation as well as all callers.
3389         (windows_delete_thread): Likewise.
3390         (fake_create_process): Update call to windows_add_thread.
3391         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3392         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3393         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3394         call to windows_delete_thread.
3395
3396 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3397
3398         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3399
3400 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3401
3402         * symfile.c (find_separate_debug_file): Use canonical path of
3403         sysroot with child_path instead of gdb_sysroot if it is valid.
3404
3405 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3406
3407         * symfile.c (find_separate_debug_file): Use child_path to
3408         determine if an object file is under a sysroot.
3409
3410 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3411
3412         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3413         unittests/child-path-selftests.c.
3414         * common/pathstuff.c (child_path): New function.
3415         * common/pathstuff.h (child_path): New prototype.
3416         * unittests/child-path-selftests.c: New file.
3417
3418 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3419
3420         * symfile.c (find_separate_debug_file): Look for separate debug
3421         files in debug directories under the sysroot.
3422
3423 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3424
3425         * symtab.h (struct minimal_symbol data_p): New const method.
3426         (struct minimal_symbol text_p): Likewise.
3427         * symtab.c (output_source_filename): Use file name style
3428         to print file name.
3429         (print_symbol_info): Likewise.
3430         (print_msymbol_info): Use address style to print addresses.
3431         Use function name style to print executable text symbols.
3432         (expand_symtab_containing_pc): Use data_p.
3433         (find_pc_sect_compunit_symtab): Likewise.
3434
3435 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3436
3437         * breakpoint.c (describe_other_breakpoints): Use address style
3438         to print addresses.
3439         (say_where): Likewise.
3440
3441 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3442
3443         * ada-typeprint.c (print_func_type): Print function name
3444         style to print function name.
3445         * c-typeprint.c (c_print_type_1): Likewise.
3446
3447 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3448
3449         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3450         for execve.
3451
3452 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3453
3454         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3455         type_stack.
3456
3457 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3458
3459         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3460         TYPE_CODE_REF types.
3461
3462 2019-02-08  Jim Wilson  <jimw@sifive.com>
3463
3464         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3465         (riscv_linux_fregset): New.
3466         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3467
3468 2019-02-07  Tom Tromey  <tom@tromey.com>
3469
3470         * thread.c (thread_cancel_execution_command): Update.
3471         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3472         methods.
3473         (struct thread_fsm_ops): Remove.
3474         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3475         (thread_fsm_should_stop, thread_fsm_return_value)
3476         (thread_fsm_set_finished, thread_fsm_finished_p)
3477         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3478         Don't declare.
3479         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3480         * infrun.c (clear_proceed_status_thread)
3481         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3482         (print_stop_event): Update.
3483         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3484         Add constructor.
3485         (step_command_fsm_ops): Remove.
3486         (new_step_command_fsm): Remove.
3487         (step_1): Update.
3488         (step_command_fsm::should_stop): Rename from
3489         step_command_fsm_should_stop.
3490         (step_command_fsm::clean_up): Rename from
3491         step_command_fsm_clean_up.
3492         (step_command_fsm::do_async_reply_reason): Rename from
3493         step_command_fsm_async_reply_reason.
3494         (struct until_next_fsm): Inherit from thread_fsm.  Add
3495         constructor.
3496         (until_next_fsm_ops): Remove.
3497         (new_until_next_fsm): Remove.
3498         (until_next_fsm::should_stop): Rename from
3499         until_next_fsm_should_stop.
3500         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3501         (until_next_fsm::do_async_reply_reason): Rename from
3502         until_next_fsm_async_reply_reason.
3503         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3504         constructor.  Change type of breakpoint.
3505         (finish_command_fsm_ops): Remove.
3506         (new_finish_command_fsm): Remove.
3507         (finish_command_fsm::should_stop): Rename from
3508         finish_command_fsm_should_stop.
3509         (finish_command_fsm::clean_up): Rename from
3510         finish_command_fsm_clean_up.
3511         (finish_command_fsm::return_value): Rename from
3512         finish_command_fsm_return_value.
3513         (finish_command_fsm::do_async_reply_reason): Rename from
3514         finish_command_fsm_async_reply_reason.
3515         (finish_command): Update.
3516         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3517         Add constructor.
3518         (call_thread_fsm_ops): Remove.
3519         (call_thread_fsm::call_thread_fsm): Rename from
3520         new_call_thread_fsm.
3521         (call_thread_fsm::should_stop): Rename from
3522         call_thread_fsm_should_stop.
3523         (call_thread_fsm::should_notify_stop): Rename from
3524         call_thread_fsm_should_notify_stop.
3525         (run_inferior_call, call_function_by_hand_dummy): Update.
3526         * cli/cli-interp.c (should_print_stop_to_console): Update.
3527         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3528         Add constructor.  Change type of location_breakpoint,
3529         caller_breakpoint.
3530         (until_break_fsm_ops): Remove.
3531         (new_until_break_fsm): Remove.
3532         (until_break_fsm::should_stop): Rename from
3533         until_break_fsm_should_stop.
3534         (until_break_fsm::clean_up): Rename from
3535         until_break_fsm_clean_up.
3536         (until_break_fsm::do_async_reply_reason): Rename from
3537         until_break_fsm_async_reply_reason.
3538         (until_break_command): Update.
3539         * thread-fsm.c: Remove.
3540         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3541
3542 2019-02-07  Tom Tromey  <tom@tromey.com>
3543
3544         * yy-remap.h: Add include guard.
3545         * xtensa-tdep.h: Add include guard.
3546         * xcoffread.h: Rename include guard.
3547         * varobj-iter.h: Add include guard.
3548         * tui/tui.h: Rename include guard.
3549         * tui/tui-winsource.h: Rename include guard.
3550         * tui/tui-wingeneral.h: Rename include guard.
3551         * tui/tui-windata.h: Rename include guard.
3552         * tui/tui-win.h: Rename include guard.
3553         * tui/tui-stack.h: Rename include guard.
3554         * tui/tui-source.h: Rename include guard.
3555         * tui/tui-regs.h: Rename include guard.
3556         * tui/tui-out.h: Rename include guard.
3557         * tui/tui-layout.h: Rename include guard.
3558         * tui/tui-io.h: Rename include guard.
3559         * tui/tui-hooks.h: Rename include guard.
3560         * tui/tui-file.h: Rename include guard.
3561         * tui/tui-disasm.h: Rename include guard.
3562         * tui/tui-data.h: Rename include guard.
3563         * tui/tui-command.h: Rename include guard.
3564         * tic6x-tdep.h: Add include guard.
3565         * target/waitstatus.h: Rename include guard.
3566         * target/wait.h: Rename include guard.
3567         * target/target.h: Rename include guard.
3568         * target/resume.h: Rename include guard.
3569         * target-float.h: Rename include guard.
3570         * stabsread.h: Add include guard.
3571         * rs6000-tdep.h: Add include guard.
3572         * riscv-fbsd-tdep.h: Add include guard.
3573         * regformats/regdef.h: Rename include guard.
3574         * record.h: Rename include guard.
3575         * python/python.h: Rename include guard.
3576         * python/python-internal.h: Rename include guard.
3577         * python/py-stopevent.h: Rename include guard.
3578         * python/py-ref.h: Rename include guard.
3579         * python/py-record.h: Rename include guard.
3580         * python/py-record-full.h: Rename include guard.
3581         * python/py-record-btrace.h: Rename include guard.
3582         * python/py-instruction.h: Rename include guard.
3583         * python/py-events.h: Rename include guard.
3584         * python/py-event.h: Rename include guard.
3585         * procfs.h: Add include guard.
3586         * proc-utils.h: Add include guard.
3587         * p-lang.h: Add include guard.
3588         * or1k-tdep.h: Rename include guard.
3589         * observable.h: Rename include guard.
3590         * nto-tdep.h: Rename include guard.
3591         * nat/x86-linux.h: Rename include guard.
3592         * nat/x86-linux-dregs.h: Rename include guard.
3593         * nat/x86-gcc-cpuid.h: Add include guard.
3594         * nat/x86-dregs.h: Rename include guard.
3595         * nat/x86-cpuid.h: Rename include guard.
3596         * nat/ppc-linux.h: Rename include guard.
3597         * nat/mips-linux-watch.h: Rename include guard.
3598         * nat/linux-waitpid.h: Rename include guard.
3599         * nat/linux-ptrace.h: Rename include guard.
3600         * nat/linux-procfs.h: Rename include guard.
3601         * nat/linux-osdata.h: Rename include guard.
3602         * nat/linux-nat.h: Rename include guard.
3603         * nat/linux-namespaces.h: Rename include guard.
3604         * nat/linux-btrace.h: Rename include guard.
3605         * nat/glibc_thread_db.h: Rename include guard.
3606         * nat/gdb_thread_db.h: Rename include guard.
3607         * nat/gdb_ptrace.h: Rename include guard.
3608         * nat/fork-inferior.h: Rename include guard.
3609         * nat/amd64-linux-siginfo.h: Rename include guard.
3610         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3611         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3612         * nat/aarch64-linux.h: Rename include guard.
3613         * nat/aarch64-linux-hw-point.h: Rename include guard.
3614         * mn10300-tdep.h: Add include guard.
3615         * mips-linux-tdep.h: Add include guard.
3616         * mi/mi-parse.h: Rename include guard.
3617         * mi/mi-out.h: Rename include guard.
3618         * mi/mi-main.h: Rename include guard.
3619         * mi/mi-interp.h: Rename include guard.
3620         * mi/mi-getopt.h: Rename include guard.
3621         * mi/mi-console.h: Rename include guard.
3622         * mi/mi-common.h: Rename include guard.
3623         * mi/mi-cmds.h: Rename include guard.
3624         * mi/mi-cmd-break.h: Rename include guard.
3625         * m2-lang.h: Add include guard.
3626         * location.h: Rename include guard.
3627         * linux-record.h: Rename include guard.
3628         * linux-nat.h: Add include guard.
3629         * linux-fork.h: Add include guard.
3630         * i386-darwin-tdep.h: Rename include guard.
3631         * hppa-linux-offsets.h: Add include guard.
3632         * guile/guile.h: Rename include guard.
3633         * guile/guile-internal.h: Rename include guard.
3634         * gnu-nat.h: Rename include guard.
3635         * gdb-stabs.h: Rename include guard.
3636         * frv-tdep.h: Add include guard.
3637         * f-lang.h: Add include guard.
3638         * event-loop.h: Add include guard.
3639         * darwin-nat.h: Rename include guard.
3640         * cp-abi.h: Rename include guard.
3641         * config/sparc/nm-sol2.h: Rename include guard.
3642         * config/nm-nto.h: Rename include guard.
3643         * config/nm-linux.h: Add include guard.
3644         * config/i386/nm-i386gnu.h: Rename include guard.
3645         * config/djgpp/nl_types.h: Rename include guard.
3646         * config/djgpp/langinfo.h: Rename include guard.
3647         * compile/gcc-cp-plugin.h: Add include guard.
3648         * compile/gcc-c-plugin.h: Add include guard.
3649         * compile/compile.h: Rename include guard.
3650         * compile/compile-object-run.h: Rename include guard.
3651         * compile/compile-object-load.h: Rename include guard.
3652         * compile/compile-internal.h: Rename include guard.
3653         * compile/compile-cplus.h: Rename include guard.
3654         * compile/compile-c.h: Rename include guard.
3655         * common/xml-utils.h: Rename include guard.
3656         * common/x86-xstate.h: Rename include guard.
3657         * common/version.h: Rename include guard.
3658         * common/vec.h: Rename include guard.
3659         * common/tdesc.h: Rename include guard.
3660         * common/selftest.h: Rename include guard.
3661         * common/scoped_restore.h: Rename include guard.
3662         * common/scoped_mmap.h: Rename include guard.
3663         * common/scoped_fd.h: Rename include guard.
3664         * common/safe-iterator.h: Rename include guard.
3665         * common/run-time-clock.h: Rename include guard.
3666         * common/refcounted-object.h: Rename include guard.
3667         * common/queue.h: Rename include guard.
3668         * common/ptid.h: Rename include guard.
3669         * common/print-utils.h: Rename include guard.
3670         * common/preprocessor.h: Rename include guard.
3671         * common/pathstuff.h: Rename include guard.
3672         * common/observable.h: Rename include guard.
3673         * common/netstuff.h: Rename include guard.
3674         * common/job-control.h: Rename include guard.
3675         * common/host-defs.h: Rename include guard.
3676         * common/gdb_wait.h: Rename include guard.
3677         * common/gdb_vecs.h: Rename include guard.
3678         * common/gdb_unlinker.h: Rename include guard.
3679         * common/gdb_unique_ptr.h: Rename include guard.
3680         * common/gdb_tilde_expand.h: Rename include guard.
3681         * common/gdb_sys_time.h: Rename include guard.
3682         * common/gdb_string_view.h: Rename include guard.
3683         * common/gdb_splay_tree.h: Rename include guard.
3684         * common/gdb_setjmp.h: Rename include guard.
3685         * common/gdb_ref_ptr.h: Rename include guard.
3686         * common/gdb_optional.h: Rename include guard.
3687         * common/gdb_locale.h: Rename include guard.
3688         * common/gdb_assert.h: Rename include guard.
3689         * common/filtered-iterator.h: Rename include guard.
3690         * common/filestuff.h: Rename include guard.
3691         * common/fileio.h: Rename include guard.
3692         * common/environ.h: Rename include guard.
3693         * common/common-utils.h: Rename include guard.
3694         * common/common-types.h: Rename include guard.
3695         * common/common-regcache.h: Rename include guard.
3696         * common/common-inferior.h: Rename include guard.
3697         * common/common-gdbthread.h: Rename include guard.
3698         * common/common-exceptions.h: Rename include guard.
3699         * common/common-defs.h: Rename include guard.
3700         * common/common-debug.h: Rename include guard.
3701         * common/cleanups.h: Rename include guard.
3702         * common/buffer.h: Rename include guard.
3703         * common/btrace-common.h: Rename include guard.
3704         * common/break-common.h: Rename include guard.
3705         * cli/cli-utils.h: Rename include guard.
3706         * cli/cli-style.h: Rename include guard.
3707         * cli/cli-setshow.h: Rename include guard.
3708         * cli/cli-script.h: Rename include guard.
3709         * cli/cli-interp.h: Rename include guard.
3710         * cli/cli-decode.h: Rename include guard.
3711         * cli/cli-cmds.h: Rename include guard.
3712         * charset-list.h: Add include guard.
3713         * buildsym-legacy.h: Rename include guard.
3714         * bfin-tdep.h: Add include guard.
3715         * ax.h: Rename include guard.
3716         * arm-linux-tdep.h: Add include guard.
3717         * arm-fbsd-tdep.h: Add include guard.
3718         * arch/xtensa.h: Rename include guard.
3719         * arch/tic6x.h: Add include guard.
3720         * arch/i386.h: Add include guard.
3721         * arch/arm.h: Rename include guard.
3722         * arch/arm-linux.h: Rename include guard.
3723         * arch/arm-get-next-pcs.h: Rename include guard.
3724         * arch/amd64.h: Add include guard.
3725         * arch/aarch64-insn.h: Rename include guard.
3726         * arch-utils.h: Rename include guard.
3727         * annotate.h: Add include guard.
3728         * amd64-darwin-tdep.h: Rename include guard.
3729         * aarch64-linux-tdep.h: Add include guard.
3730         * aarch64-fbsd-tdep.h: Add include guard.
3731         * aarch32-linux-nat.h: Add include guard.
3732
3733 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3734
3735         * macrotab.c (macro_define_internal): New function that
3736         factorizes macro_define_object_internal and macro_define_function
3737         code.
3738         (macro_define_object_internal): Use macro_define_internal.
3739         (macro_define_function): Likewise.
3740
3741 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3742
3743         * macrocmd.c (extract_identifier): Return
3744         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3745         callers.
3746
3747 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3748
3749         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3750
3751 2019-02-05  Tom Tromey  <tom@tromey.com>
3752
3753         * target.c (target_stack::unpush): Move assertion earlier.
3754
3755 2019-01-30  Tom Tromey  <tom@tromey.com>
3756
3757         PR python/23615:
3758         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3759         (gdbpy_parse_and_eval): Likewise.
3760         * python/python-internal.h (gdbpy_allow_threads): New class.
3761
3762 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3763
3764         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3765         (aarch64_fbsd_fpregmap): Move earlier.
3766         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3767         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3768         instead of individual calls to trad_frame_set_reg_addr.
3769         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3770         earlier.
3771         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3772         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3773         instead of individual calls to trad_frame_set_reg_addr.
3774
3775 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3776
3777         * CONTRIBUTE: Replace contribution list with wiki link.
3778
3779 2019-01-25  Tom Tromey  <tom@tromey.com>
3780
3781         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3782
3783 2019-01-25  Tom Tromey  <tom@tromey.com>
3784
3785         * xtensa-linux-nat.c: Fix common/ includes.
3786         * xml-support.h: Fix common/ includes.
3787         * xml-support.c: Fix common/ includes.
3788         * x86-linux-nat.c: Fix common/ includes.
3789         * windows-nat.c: Fix common/ includes.
3790         * varobj.h: Fix common/ includes.
3791         * varobj.c: Fix common/ includes.
3792         * value.c: Fix common/ includes.
3793         * valops.c: Fix common/ includes.
3794         * utils.c: Fix common/ includes.
3795         * unittests/xml-utils-selftests.c: Fix common/ includes.
3796         * unittests/utils-selftests.c: Fix common/ includes.
3797         * unittests/unpack-selftests.c: Fix common/ includes.
3798         * unittests/tracepoint-selftests.c: Fix common/ includes.
3799         * unittests/style-selftests.c: Fix common/ includes.
3800         * unittests/string_view-selftests.c: Fix common/ includes.
3801         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3802         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3803         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3804         * unittests/rsp-low-selftests.c: Fix common/ includes.
3805         * unittests/parse-connection-spec-selftests.c: Fix common/
3806         includes.
3807         * unittests/optional-selftests.c: Fix common/ includes.
3808         * unittests/offset-type-selftests.c: Fix common/ includes.
3809         * unittests/observable-selftests.c: Fix common/ includes.
3810         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3811         * unittests/memrange-selftests.c: Fix common/ includes.
3812         * unittests/memory-map-selftests.c: Fix common/ includes.
3813         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3814         * unittests/function-view-selftests.c: Fix common/ includes.
3815         * unittests/environ-selftests.c: Fix common/ includes.
3816         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3817         * unittests/common-utils-selftests.c: Fix common/ includes.
3818         * unittests/cli-utils-selftests.c: Fix common/ includes.
3819         * unittests/array-view-selftests.c: Fix common/ includes.
3820         * ui-file.c: Fix common/ includes.
3821         * tui/tui-io.c: Fix common/ includes.
3822         * tracepoint.h: Fix common/ includes.
3823         * tracepoint.c: Fix common/ includes.
3824         * tracefile-tfile.c: Fix common/ includes.
3825         * top.h: Fix common/ includes.
3826         * top.c: Fix common/ includes.
3827         * thread.c: Fix common/ includes.
3828         * target/waitstatus.h: Fix common/ includes.
3829         * target/waitstatus.c: Fix common/ includes.
3830         * target.h: Fix common/ includes.
3831         * target.c: Fix common/ includes.
3832         * target-memory.c: Fix common/ includes.
3833         * target-descriptions.c: Fix common/ includes.
3834         * symtab.h: Fix common/ includes.
3835         * symfile.c: Fix common/ includes.
3836         * stap-probe.c: Fix common/ includes.
3837         * spu-linux-nat.c: Fix common/ includes.
3838         * sparc-nat.c: Fix common/ includes.
3839         * source.c: Fix common/ includes.
3840         * solib.c: Fix common/ includes.
3841         * solib-target.c: Fix common/ includes.
3842         * ser-unix.c: Fix common/ includes.
3843         * ser-tcp.c: Fix common/ includes.
3844         * ser-pipe.c: Fix common/ includes.
3845         * ser-base.c: Fix common/ includes.
3846         * selftest-arch.c: Fix common/ includes.
3847         * s12z-tdep.c: Fix common/ includes.
3848         * rust-exp.y: Fix common/ includes.
3849         * rs6000-aix-tdep.c: Fix common/ includes.
3850         * riscv-tdep.c: Fix common/ includes.
3851         * remote.c: Fix common/ includes.
3852         * remote-notif.h: Fix common/ includes.
3853         * remote-fileio.h: Fix common/ includes.
3854         * remote-fileio.c: Fix common/ includes.
3855         * regcache.h: Fix common/ includes.
3856         * regcache.c: Fix common/ includes.
3857         * record-btrace.c: Fix common/ includes.
3858         * python/python.c: Fix common/ includes.
3859         * python/py-type.c: Fix common/ includes.
3860         * python/py-inferior.c: Fix common/ includes.
3861         * progspace.h: Fix common/ includes.
3862         * producer.c: Fix common/ includes.
3863         * procfs.c: Fix common/ includes.
3864         * proc-api.c: Fix common/ includes.
3865         * printcmd.c: Fix common/ includes.
3866         * ppc-linux-nat.c: Fix common/ includes.
3867         * parser-defs.h: Fix common/ includes.
3868         * osdata.c: Fix common/ includes.
3869         * obsd-nat.c: Fix common/ includes.
3870         * nat/x86-linux.c: Fix common/ includes.
3871         * nat/x86-linux-dregs.c: Fix common/ includes.
3872         * nat/x86-dregs.h: Fix common/ includes.
3873         * nat/x86-dregs.c: Fix common/ includes.
3874         * nat/ppc-linux.c: Fix common/ includes.
3875         * nat/mips-linux-watch.h: Fix common/ includes.
3876         * nat/mips-linux-watch.c: Fix common/ includes.
3877         * nat/linux-waitpid.c: Fix common/ includes.
3878         * nat/linux-ptrace.h: Fix common/ includes.
3879         * nat/linux-ptrace.c: Fix common/ includes.
3880         * nat/linux-procfs.c: Fix common/ includes.
3881         * nat/linux-personality.c: Fix common/ includes.
3882         * nat/linux-osdata.c: Fix common/ includes.
3883         * nat/linux-namespaces.c: Fix common/ includes.
3884         * nat/linux-btrace.h: Fix common/ includes.
3885         * nat/linux-btrace.c: Fix common/ includes.
3886         * nat/fork-inferior.c: Fix common/ includes.
3887         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3888         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3889         * nat/aarch64-linux.c: Fix common/ includes.
3890         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3891         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3892         * namespace.h: Fix common/ includes.
3893         * mips-linux-tdep.c: Fix common/ includes.
3894         * minsyms.c: Fix common/ includes.
3895         * mi/mi-parse.h: Fix common/ includes.
3896         * mi/mi-main.c: Fix common/ includes.
3897         * mi/mi-cmd-env.c: Fix common/ includes.
3898         * memrange.h: Fix common/ includes.
3899         * memattr.c: Fix common/ includes.
3900         * maint.h: Fix common/ includes.
3901         * maint.c: Fix common/ includes.
3902         * main.c: Fix common/ includes.
3903         * machoread.c: Fix common/ includes.
3904         * location.c: Fix common/ includes.
3905         * linux-thread-db.c: Fix common/ includes.
3906         * linux-nat.c: Fix common/ includes.
3907         * linux-fork.c: Fix common/ includes.
3908         * inline-frame.c: Fix common/ includes.
3909         * infrun.c: Fix common/ includes.
3910         * inflow.c: Fix common/ includes.
3911         * inferior.h: Fix common/ includes.
3912         * inferior.c: Fix common/ includes.
3913         * infcmd.c: Fix common/ includes.
3914         * inf-ptrace.c: Fix common/ includes.
3915         * inf-child.c: Fix common/ includes.
3916         * ia64-linux-nat.c: Fix common/ includes.
3917         * i387-tdep.c: Fix common/ includes.
3918         * i386-tdep.c: Fix common/ includes.
3919         * i386-linux-tdep.c: Fix common/ includes.
3920         * i386-linux-nat.c: Fix common/ includes.
3921         * i386-go32-tdep.c: Fix common/ includes.
3922         * i386-fbsd-tdep.c: Fix common/ includes.
3923         * i386-fbsd-nat.c: Fix common/ includes.
3924         * guile/scm-type.c: Fix common/ includes.
3925         * guile/guile.c: Fix common/ includes.
3926         * go32-nat.c: Fix common/ includes.
3927         * gnu-nat.c: Fix common/ includes.
3928         * gdbthread.h: Fix common/ includes.
3929         * gdbarch-selftests.c: Fix common/ includes.
3930         * gdb_usleep.c: Fix common/ includes.
3931         * gdb_select.h: Fix common/ includes.
3932         * gdb_bfd.c: Fix common/ includes.
3933         * gcore.c: Fix common/ includes.
3934         * fork-child.c: Fix common/ includes.
3935         * findvar.c: Fix common/ includes.
3936         * fbsd-nat.c: Fix common/ includes.
3937         * event-top.c: Fix common/ includes.
3938         * event-loop.c: Fix common/ includes.
3939         * dwarf2read.c: Fix common/ includes.
3940         * dwarf2loc.c: Fix common/ includes.
3941         * dwarf2-frame.c: Fix common/ includes.
3942         * dwarf-index-cache.c: Fix common/ includes.
3943         * dtrace-probe.c: Fix common/ includes.
3944         * disasm-selftests.c: Fix common/ includes.
3945         * defs.h: Fix common/ includes.
3946         * csky-tdep.c: Fix common/ includes.
3947         * cp-valprint.c: Fix common/ includes.
3948         * cp-support.h: Fix common/ includes.
3949         * cp-support.c: Fix common/ includes.
3950         * corelow.c: Fix common/ includes.
3951         * completer.h: Fix common/ includes.
3952         * completer.c: Fix common/ includes.
3953         * compile/compile.c: Fix common/ includes.
3954         * compile/compile-loc2c.c: Fix common/ includes.
3955         * compile/compile-cplus-types.c: Fix common/ includes.
3956         * compile/compile-cplus-symbols.c: Fix common/ includes.
3957         * command.h: Fix common/ includes.
3958         * cli/cli-dump.c: Fix common/ includes.
3959         * cli/cli-cmds.c: Fix common/ includes.
3960         * charset.c: Fix common/ includes.
3961         * build-id.c: Fix common/ includes.
3962         * btrace.h: Fix common/ includes.
3963         * btrace.c: Fix common/ includes.
3964         * breakpoint.h: Fix common/ includes.
3965         * breakpoint.c: Fix common/ includes.
3966         * ax.h: 
3967         (enum agent_op): Fix common/ includes.
3968         * ax-general.c (struct aop_map): Fix common/ includes.
3969         * ax-gdb.c: Fix common/ includes.
3970         * auxv.c: Fix common/ includes.
3971         * auto-load.c: Fix common/ includes.
3972         * arm-tdep.c: Fix common/ includes.
3973         * arch/riscv.c: Fix common/ includes.
3974         * arch/ppc-linux-common.c: Fix common/ includes.
3975         * arch/i386.c: Fix common/ includes.
3976         * arch/arm.c: Fix common/ includes.
3977         * arch/arm-linux.c: Fix common/ includes.
3978         * arch/arm-get-next-pcs.c: Fix common/ includes.
3979         * arch/amd64.c: Fix common/ includes.
3980         * arch/aarch64.c: Fix common/ includes.
3981         * arch/aarch64-insn.c: Fix common/ includes.
3982         * arch-utils.c: Fix common/ includes.
3983         * amd64-windows-tdep.c: Fix common/ includes.
3984         * amd64-tdep.c: Fix common/ includes.
3985         * amd64-sol2-tdep.c: Fix common/ includes.
3986         * amd64-obsd-tdep.c: Fix common/ includes.
3987         * amd64-nbsd-tdep.c: Fix common/ includes.
3988         * amd64-linux-tdep.c: Fix common/ includes.
3989         * amd64-linux-nat.c: Fix common/ includes.
3990         * amd64-fbsd-tdep.c: Fix common/ includes.
3991         * amd64-fbsd-nat.c: Fix common/ includes.
3992         * amd64-dicos-tdep.c: Fix common/ includes.
3993         * amd64-darwin-tdep.c: Fix common/ includes.
3994         * agent.c: Fix common/ includes.
3995         * ada-lang.h: Fix common/ includes.
3996         * ada-lang.c: Fix common/ includes.
3997         * aarch64-tdep.c: Fix common/ includes.
3998
3999 2019-01-25  Tom Tromey  <tom@tromey.com>
4000
4001         * common/create-version.sh: Use common/version.h.
4002
4003 2019-01-24  Pedro Alves  <palves@redhat.com>
4004
4005         * infrun.c (signal_stop, signal_print, signal_program)
4006         (signal_catch, signal_pass): Now arrays instead of pointers.
4007         (update_signals_program_target, do_target_resume)
4008         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4009         * linux-nat.c (linux_nat_target::pass_signals)
4010         (linux_nat_target::create_inferior, linux_nat_target::attach):
4011         Adjust.
4012         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4013         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4014         * procfs.c (procfs_target::pass_signals): Adjust.
4015         * record-full.c (record_full_target::resume): Adjust.
4016         * remote.c (remote_target::pass_signals)
4017         (remote_target::program_signals): Adjust.
4018         * target-debug.h (target_debug_print_signals): Now takes a
4019         gdb::array_view as parameter.  Adjust.
4020         * target.h (target_ops) <pass_signals, program_signals>: Replace
4021         pointer and length parameters with gdb::array_view.
4022         (target_pass_signals, target_program_signals): Likewise.
4023         * target-delegates.c: Regenerate.
4024
4025 2019-01-24  Pedro Alves  <palves@redhat.com>
4026
4027         * common/forward-scope-exit.h
4028         (forward_scope_exit::forward_scope_exit): Pass arguments to
4029         m_bind_function directly, instead of creating a std::bind and
4030         copying that.
4031
4032 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4033
4034         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4035         for static members.
4036         (pass_in_v_vfp_candidate): Likewise.
4037
4038 2019-01-23  Tom Tromey  <tom@tromey.com>
4039             Pedro Alves  <palves@redhat.com>
4040
4041         * regcache.c (class regcache_invalidator): Remove.
4042         (regcache::raw_write): Use make_scope_exit.
4043
4044 2019-01-23  Tom Tromey  <tom@tromey.com>
4045
4046         * ui-out.h (class ui_out_emit_type): Update comment.
4047
4048 2019-01-23  Tom Tromey  <tom@tromey.com>
4049
4050         * infrun.c (fetch_inferior_event): Update comment.
4051
4052 2019-01-23  Tom Tromey  <tom@tromey.com>
4053             Pedro Alves  <palves@redhat.com>
4054
4055         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4056         parameter.
4057         (fetch_inferior_event): Use SCOPE_EXIT.
4058
4059
4060 2019-01-23  Tom Tromey  <tom@tromey.com>
4061             Pedro Alves  <palves@redhat.com>
4062
4063         * infrun.c (disable_thread_events): Delete.
4064         (stop_all_threads): Use SCOPE_EXIT.
4065
4066 2019-01-23  Tom Tromey  <tom@tromey.com>
4067             Pedro Alves  <palves@redhat.com>
4068
4069         * symfile.c: Include forward-scope-exit.h.
4070         (clear_symtab_users_cleanup): Replace forward declaration with
4071         a FORWARD_SCOPE_EXIT.
4072         (syms_from_objfile_1): Use the forward_scope_exit and
4073         gdb::optional instead of cleanup_function.
4074         (reread_symbols): Use the forward_scope_exit instead of
4075         cleanup_function.
4076         (clear_symtab_users_cleanup): Remove function.
4077
4078 2019-01-23  Tom Tromey  <tom@tromey.com>
4079             Pedro Alves  <palves@redhat.com>
4080
4081         * linux-nat.c: Include scope-exit.h.
4082         (cleanup_target_stop): Remove.
4083         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4084         SCOPE_EXIT.
4085
4086 2019-01-23  Tom Tromey  <tom@tromey.com>
4087             Pedro Alves  <palves@redhat.com>
4088
4089         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4090         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4091
4092 2019-01-23  Tom Tromey  <tom@tromey.com>
4093             Andrew Burgess  <andrew.burgess@embecosm.com>
4094             Pedro Alves  <palves@redhat.com>
4095
4096         * infrun.c (fetch_inferior_event): Use scope_exit.
4097         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4098         * top.c (execute_command): Use scope_exit.
4099         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4100         * utils.c (do_bpstat_clear_actions_cleanup)
4101         (make_bpstat_clear_actions_cleanup): Remove.
4102
4103 2019-01-23  Tom Tromey  <tom@tromey.com>
4104             Pedro Alves  <palves@redhat.com>
4105
4106         * infrun.c: Include "common/scope-exit.h"
4107         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4108         (wait_for_inferior): Use SCOPE_EXIT.
4109         (fetch_inferior_event): Use scope_exit.
4110
4111 2019-01-23  Tom Tromey  <tom@tromey.com>
4112             Pedro Alves  <palves@redhat.com>
4113
4114         * breakpoint.c (create_breakpoint): Remove cleanup.
4115
4116 2019-01-23  Tom Tromey  <tom@tromey.com>
4117             Andrew Burgess  <andrew.burgess@embecosm.com>
4118             Pedro Alves  <palves@redhat.com>
4119
4120 2019-01-23  Pedro Alves  <palves@redhat.com>
4121
4122         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4123
4124 2019-01-23  Pedro Alves  <palves@redhat.com>
4125             Andrew Burgess  <andrew.burgess@embecosm.com>
4126
4127         * gdbthread.h: Include "common/forward-scope-exit.h".
4128         (scoped_finish_thread_state): Redefine custom class in terms of
4129         forward_scope_exit.
4130
4131 2019-01-23  Pedro Alves  <palves@redhat.com>
4132             Andrew Burgess  <andrew.burgess@embecosm.com>
4133
4134         * common/forward-scope-exit.h: New file.
4135
4136 2019-01-23  Pedro Alves  <palves@redhat.com>
4137             Andrew Burgess  <andrew.burgess@embecosm.com>
4138             Tom Tromey  <tom@tromey.com>
4139
4140         * common/scope-exit.h: New file.
4141
4142 2019-01-23  Pedro Alves  <palves@redhat.com>
4143
4144         * common/preprocessor.h (ESC): Rename to ...
4145         (ESC_PARENS): ... this.
4146         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4147         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4148
4149 2019-01-23  Tom Tromey  <tom@tromey.com>
4150
4151         * language.h (class scoped_switch_to_sym_language_if_auto):
4152         Initialize m_lang in both cases.
4153
4154 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4155
4156         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4157         with XCNEW.
4158
4159 2019-01-22  Tom Tromey  <tom@tromey.com>
4160
4161         * corelow.c: Do not include sys/file.h.
4162
4163 2019-01-22  Tom Tromey  <tom@tromey.com>
4164
4165         * tui/tui-wingeneral.h: Include gdb_curses.h.
4166
4167 2019-01-22  Tom Tromey  <tom@tromey.com>
4168
4169         * source-cache.h (class source_cache) <get_source_lines,
4170         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4171
4172 2019-01-22  Tom Tromey  <tom@tromey.com>
4173
4174         * remote-fileio.h (struct remote_target): Declare.
4175
4176 2019-01-22  Tom Tromey  <tom@tromey.com>
4177
4178         * python/py-arch.c: Do not include py-ref.h.
4179         * python/py-bpevent.c: Do not include py-ref.h.
4180         * python/py-cmd.c: Do not include py-ref.h.
4181         * python/py-continueevent.c: Do not include py-ref.h.
4182         * python/py-event.h: Do not include py-ref.h.
4183         * python/py-evtregistry.c: Do not include py-ref.h.
4184         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4185         * python/py-frame.c: Do not include py-ref.h.
4186         * python/py-framefilter.c: Do not include py-ref.h.
4187         * python/py-function.c: Do not include py-ref.h.
4188         * python/py-infevents.c: Do not include py-ref.h.
4189         * python/py-linetable.c: Do not include py-ref.h.
4190         * python/py-objfile.c: Do not include py-ref.h.
4191         * python/py-param.c: Do not include py-ref.h.
4192         * python/py-prettyprint.c: Do not include py-ref.h.
4193         * python/py-progspace.c: Do not include py-ref.h.
4194         * python/py-symbol.c: Do not include py-ref.h.
4195         * python/py-symtab.c: Do not include py-ref.h.
4196         * python/py-type.c: Do not include py-ref.h.
4197         * python/py-unwind.c: Do not include py-ref.h.
4198         * python/py-utils.c: Do not include py-ref.h.
4199         * python/py-value.c: Do not include py-ref.h.
4200         * python/py-varobj.c: Do not include py-ref.h.
4201         * python/py-xmethods.c: Do not include py-ref.h.
4202         * python/python.c: Do not include py-ref.h.
4203         * varobj.c: Do not include py-ref.h.
4204
4205 2019-01-22  Tom Tromey  <tom@tromey.com>
4206
4207         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4208         keyword for bcache.
4209
4210 2019-01-22  Tom Tromey  <tom@tromey.com>
4211
4212         * compile/compile-cplus-types.c: Remove a comment by #include.
4213
4214 2019-01-22  Tom Tromey  <tom@tromey.com>
4215
4216         * compile/gcc-c-plugin.h: Include compile-internal.h.
4217
4218 2019-01-22  Tom Tromey  <tom@tromey.com>
4219
4220         * stabsread.c (EXTERN): Do not define.
4221         (symnum, next_symbol_text_func, processing_gcc_compilation)
4222         (within_function, global_sym_chain, global_stabs)
4223         (previous_stab_code, this_object_header_files)
4224         (n_this_object_header_files)
4225         (n_allocated_this_object_header_files): Define.
4226         * stabsread.h (EXTERN): Never define.  Use "extern".
4227
4228 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4229
4230         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4231         history_value.
4232
4233 2019-01-21  Tom Tromey  <tom@tromey.com>
4234
4235         * ui-out.c: Fix includes.
4236         * tui/tui-source.c: Fix includes.
4237         * target.c: Fix includes.
4238         * remote.c: Fix includes.
4239         * regcache.c: Fix includes.
4240         * python/py-block.c: Fix includes.
4241         * printcmd.c: Fix includes.
4242         * or1k-tdep.c: Fix includes.
4243         * mi/mi-main.c: Fix includes.
4244         * m32r-tdep.c: Fix includes.
4245         * csky-tdep.c: Fix includes.
4246         * compile/compile-cplus-types.c: Fix includes.
4247         * cli/cli-interp.c: Fix includes.
4248
4249 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4250
4251         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4252         for padding.
4253
4254 2019-01-16  Tom Tromey  <tom@tromey.com>
4255
4256         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4257         earlier.
4258         (struct objfile) <msymbols_range>: Move from top level.
4259         <msymbols>: New method.
4260         (class objfile_msymbols): Remove.
4261         * symtab.c (default_collect_symbol_completion_matches_break_on):
4262         Update.
4263         * symmisc.c (dump_msymbols): Update.
4264         * stabsread.c (scan_file_globals): Update.
4265         * objc-lang.c (info_selectors_command, info_classes_command)
4266         (find_methods): Update.
4267         * minsyms.c (find_solib_trampoline_target): Update.
4268         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4269         * coffread.c (coff_symfile_read): Update.
4270         * ada-lang.c (ada_lookup_simple_minsym)
4271         (ada_collect_symbol_completion_matches): Update.
4272
4273 2019-01-16  Tom Tromey  <tom@tromey.com>
4274
4275         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4276         type.  Remove no-argument constructor.
4277         <iterator::operator++>: Simplify.
4278         <begin>: Update.
4279         <end>: Use minimal_symbol_count.
4280
4281 2019-01-16  Tom Tromey  <tom@tromey.com>
4282
4283         * objfiles.h (struct objfile) <psymtabs>: New method.
4284         (class objfile_psymtabs): Remove.
4285         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4286         typedef.
4287         <range>: New method.
4288         (require_partial_symbols): Change return type.
4289         * psymtab.c (require_partial_symbols)
4290         (psym_expand_symtabs_matching): Update.
4291         * mdebugread.c (parse_partial_symbols): Update.
4292         * dbxread.c (dbx_end_psymtab): Update.
4293
4294 2019-01-15  Tom Tromey  <tom@tromey.com>
4295
4296         * symtab.c (lookup_objfile_from_block)
4297         (lookup_symbol_in_objfile_symtabs)
4298         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4299         (find_line_symtab, info_sources_command)
4300         (default_collect_symbol_completion_matches_break_on)
4301         (make_source_files_completion_list): Update.
4302         * symmisc.c (print_objfile_statistics, dump_objfile)
4303         (maintenance_print_symbols, maintenance_info_symtabs)
4304         (maintenance_check_symtabs, maintenance_info_line_tables):
4305         Update.
4306         * source.c (select_source_symtab)
4307         (forget_cached_source_info_for_objfile): Update.
4308         * objfiles.h (class objfile_compunits): Remove.
4309         (struct objfile) <compunits_range>: New typedef.
4310         (compunits): New method.
4311         * objfiles.c (objfile_relocate1): Update.
4312         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4313         * maint.c (count_symtabs_and_blocks): Update.
4314         * linespec.c (iterate_over_all_matching_symtabs): Update.
4315         * cp-support.c (add_symbol_overload_list_qualified): Update.
4316         * coffread.c (coff_symtab_read): Update.
4317         * ada-lang.c (add_nonlocal_symbols)
4318         (ada_collect_symbol_completion_matches)
4319         (ada_add_global_exceptions): Update.
4320
4321 2019-01-15  Tom Tromey  <tom@tromey.com>
4322
4323         * progspace.h (program_space) <objfiles_safe_range>: New
4324         typedef.
4325         <objfiles_safe>: New method.
4326         * objfiles.h (class all_objfiles_safe): Remove.
4327         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4328         * jit.c (jit_inferior_exit_hook): Update.
4329
4330 2019-01-17  Tom Tromey  <tom@tromey.com>
4331
4332         * progspace.h (program_space) <objfiles_range>: New typedef.
4333         <objfiles>: New method.
4334         <objfiles_head>: Rename from objfiles.
4335         (object_files): Update.
4336         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4337         * guile/scm-pretty-print.c
4338         (ppscm_find_pretty_printer_from_objfiles): Update.
4339         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4340         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4341         Update.
4342         * python/py-progspace.c (pspy_get_objfiles): Update.
4343         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4344         Update.
4345         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4346         (objfpy_lookup_objfile_by_build_id): Update.
4347         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4348         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4349         Update.
4350         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4351         (expand_symtab_containing_pc, lookup_objfile_from_block)
4352         (lookup_static_symbol, basic_lookup_transparent_type)
4353         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4354         (find_line_symtab, info_sources_command)
4355         (default_collect_symbol_completion_matches_break_on)
4356         (make_source_files_completion_list, find_main_name): Update.
4357         * symmisc.c (print_symbol_bcache_statistics)
4358         (print_objfile_statistics, maintenance_print_symbols)
4359         (maintenance_print_msymbols, maintenance_print_objfiles)
4360         (maintenance_info_symtabs, maintenance_check_symtabs)
4361         (maintenance_expand_symtabs, maintenance_info_line_tables):
4362         Update.
4363         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4364         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4365         (map_overlay_command, unmap_overlay_command)
4366         (simple_overlay_update, expand_symtabs_matching)
4367         (map_symbol_filenames): Update.
4368         * symfile-debug.c (set_debug_symfile): Update.
4369         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4370         Update.
4371         * source.c (select_source_symtab, forget_cached_source_info):
4372         Update.
4373         * solib.c (solib_read_symbols): Update.
4374         * solib-spu.c (append_ocl_sos): Update.
4375         * psymtab.c (maintenance_print_psymbols)
4376         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4377         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4378         * printcmd.c (info_symbol_command): Update.
4379         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4380         Update.
4381         * objfiles.h (class all_objfiles): Remove.
4382         * objfiles.c (have_partial_symbols, have_full_symbols)
4383         (have_minimal_symbols, qsort_cmp, update_section_map)
4384         (shared_objfile_contains_address_p)
4385         (default_iterate_over_objfiles_in_search_order): Update.
4386         * objc-lang.c (info_selectors_command, info_classes_command)
4387         (find_methods): Update.
4388         * minsyms.c (find_solib_trampoline_target): Update.
4389         * maint.c (maintenance_info_sections)
4390         (maintenance_translate_address, count_symtabs_and_blocks):
4391         Update.
4392         * main.c (captured_main_1): Update.
4393         * linux-thread-db.c (try_thread_db_load_from_pdir)
4394         (has_libpthread): Update.
4395         * linespec.c (iterate_over_all_matching_symtabs)
4396         (search_minsyms_for_name): Update.
4397         * jit.c (jit_find_objf_with_entry_addr): Update.
4398         * hppa-tdep.c (find_unwind_entry)
4399         (hppa_lookup_stub_minimal_symbol): Update.
4400         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4401         Update.
4402         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4403         (elf_gnu_ifunc_resolve_by_got): Update.
4404         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4405         * dwarf-index-write.c (save_gdb_index_command): Update.
4406         * cp-support.c (add_symbol_overload_list_qualified): Update.
4407         * breakpoint.c (create_overlay_event_breakpoint)
4408         (create_longjmp_master_breakpoint)
4409         (create_std_terminate_master_breakpoint)
4410         (create_exception_master_breakpoint): Update.
4411         * blockframe.c (find_pc_partial_function): Update.
4412         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4413         (ada_collect_symbol_completion_matches)
4414         (ada_add_global_exceptions): Update.
4415
4416 2019-01-17  Tom Tromey  <tom@tromey.com>
4417
4418         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4419         declare VEC.
4420         (solib_target_parse_libraries): Change return type.
4421         (library_list_start_segment, library_list_start_section)
4422         (library_list_end_library, library_list_start_library); Update.
4423         (solib_target_free_library_list): Remove.
4424         (solib_target_parse_libraries): Remove cleanup.  Change return
4425         type.
4426         (solib_target_current_sos): Update.
4427
4428 2019-01-17  Tom Tromey  <tromey@bapiya>
4429
4430         * valprint.c: Replace "the the" with "the".
4431         * symtab.c: Replace "the the" with "the".
4432         * solib.c: Replace "the the" with "the".
4433         * solib-dsbt.c: Replace "the the" with "the".
4434         * linespec.c: Replace "the the" with "the".
4435         * dwarf2loc.h: Replace "the the" with "the".
4436         * amd64-windows-tdep.c: Replace "the the" with "the".
4437         * aarch64-tdep.c: Replace "the the" with "the".
4438
4439 2019-01-16  Keith Seitz  <keiths@redhat.com>
4440
4441         PR gdb/23773
4442         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4443         <builder>: Rename to ..
4444         <m_builder>: ... this and make private.
4445         (dwarf2_cu::get_builder): New method.  Change all users of
4446         `builder' to use this method.
4447         (dwarf2_start_symtab): Move to ...
4448         (dwarf2_cu::start_symtab): ... here.  Update all callers
4449         (setup_type_unit_groups): Move to ...
4450         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4451         callers.
4452         (dwarf2_cu::reset_builder): New method.
4453         (process_full_compunit, process_full_type_unit): Use
4454         dwarf2_cu::reset_builder.
4455         (follow_die_offset): Record the ancestor CU if it is different
4456         from the followed DIE's CU.
4457         (follow_die_sig_1): Likewise.
4458
4459 2019-01-15  Tom Tromey  <tom@tromey.com>
4460
4461         * remote.c (class remote_state) <buf>: Now a char_vector.
4462         <buf_size>: Remove.
4463         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4464         parameter.
4465         (remote_target::getpkt_or_notif_sane_1)
4466         (remote_target::getpkt_sane)
4467         (remote_target::getpkt_or_notif_sane): Likewise.
4468         (class remote_target) <putpkt>: New overload.
4469         (remote_target::read_frame): Change type of "buf_p".  Remove
4470         sizeof_p parameter.
4471         (packet_ok): New overload.
4472         (packet_check_result): New overload.
4473         Update all uses.
4474
4475 2019-01-14  Tom Tromey  <tom@tromey.com>
4476
4477         * remote-notif.c (handle_notification, remote_notif_ack)
4478         (remote_notif_parse): Make "buf" const.
4479         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4480         const.
4481         (remote_notif_parse, remote_notif_ack, handle_notification):
4482         Likewise.
4483         * remote.c (remote_notif_stop_parse): Make "buf" const.
4484         (remote_target::remote_parse_stop_reply): Make "buf" const.
4485         (remote_notif_stop_ack): Make "buf" const.
4486
4487 2019-01-14  Tom Tromey  <tom@tromey.com>
4488
4489         * remote.c (remote_console_output): Make parameter const.
4490
4491 2019-01-14  Tom Tromey  <tom@tromey.com>
4492
4493         * target-debug.h (target_debug_print_signals): Constify.
4494         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4495         * procfs.c (procfs_target::pass_signals): Update.
4496         * linux-nat.c (linux_nat_target::pass_signals): Update.
4497         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4498         * target-delegates.c: Rebuild.
4499         * remote.c (remote_target::program_signals): Update.
4500         (remote_target::pass_signals): Update.
4501         * target.c (target_pass_signals): Constify argument.
4502         (target_program_signals): Likewise.
4503         * target.h (struct target_ops) <pass_signals, program_signals>:
4504         Constify argument.
4505         (target_pass_signals, target_program_signals): Constify argument.
4506
4507 2019-01-14  Tom Tromey  <tom@tromey.com>
4508
4509         PR tui/28819:
4510         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4511
4512 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4513
4514         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4515         field.
4516         * rs6000-tdep.c: Include reggroups.h.
4517         (IS_V_ALIAS_PSEUDOREG): Define.
4518         (rs6000_register_name): Return names for the "vX" aliases.
4519         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4520         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4521         aliases.  Call default_register_reggroup_p for all other
4522         pseudo-registers.
4523         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4524         New functions.
4525         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4526         Handle "vX" aliases.
4527         (v_alias_pseudo_register_collect): New function.
4528         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4529         (rs6000_gdbarch_init): Initialize "vX" aliases as
4530         pseudo-registers.  Restore registration of
4531         rs6000_pseudo_register_reggroup_p with
4532         set_tdesc_pseudo_register_reggroup_p.
4533
4534 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4535
4536         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4537         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4538         set_gdbarch_num_pseudo_regs.
4539
4540 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4541
4542         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4543         Remove arg prefixname, add do_set and do_show.
4544         Add member functions set_list and show_list.
4545         * cli/cli-style.c (class cli_style_option): Update accordingly.
4546         (style_set_list): Move to file scope.
4547         (style_show_list): Likewise.
4548         (set_style): Call help_list.
4549         (show_style): Call cmd_show_list.
4550         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4551         Update to use the new macro.
4552
4553 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4554
4555         * ada-lang.c (_initialize_ada_language): Expand the help text
4556         for the "catch exception" command.
4557
4558 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4559
4560         * symtab.c (matching_obj_sections): Initialize obj,
4561         declare it closer to its usage.
4562
4563 2019-01-10  Tom Tromey  <tom@tromey.com>
4564
4565         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4566         (basic_inf_threads_range): Remove.
4567         (inf_threads_range, inf_non_exited_threads_range)
4568         (safe_inf_threads_range): Use next_adapter.
4569
4570 2019-01-10  Keith Seitz  <keiths@redhat.com>
4571
4572         PR gdb/23712
4573         PR symtab/23010
4574         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4575         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4576
4577 2019-01-10  Keith Seitz  <keiths@redhat.com>
4578
4579         PR gdb/23712
4580         PR symtab/23010
4581         * dictionary.c (pending_to_vector): Remove.
4582         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4583         Remove _1 suffix, replacing functions of the same name.  Update
4584         all callers.
4585         (dict_create_hashed, dict_create_hashed_expandable)
4586         (dict_create_linear, dict_create_linear_expandable, dict_free)
4587         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4588         Make functions static.
4589
4590 2019-01-10  Keith Seitz  <keiths@redhat.com>
4591
4592         PR gdb/23712
4593         PR symtab/23010
4594         * dictionary.h (struct dictionary): Replace declaration with
4595         multidictionary.
4596         (dict_create_hashed, dict_create_hashed_expandable)
4597         (dict_create_linear, dict_create_linear_expandable)
4598         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4599         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4600         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4601         taking multidictionary argument.
4602         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4603         * block.h (struct block) <dict>: Change to multidictionary
4604         and rename `multidict'.
4605         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4606         symmisc.c: Update all dictionary references to multidictionary.
4607
4608 2019-01-10  Keith Seitz  <keiths@redhat.com>
4609
4610         PR gdb/23712
4611         PR symtab/23010
4612         * dictionary.c: Include unordered_map.
4613         (pending_to_vector): New function.
4614         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4615         Rewrite the non-"_1" functions to take vector instead
4616         of linked list.
4617         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4618         "new" _1 versions of the same name.
4619         (multidictionary): Define.
4620         (std::hash<enum language): New definition.
4621         (collate_pending_symbols_by_language, mdict_create_hashed)
4622         (mdict_create_hashed_expandable, mdict_create_linear)
4623         (mdict_create_linear_expandable, mdict_free)
4624         (find_language_dictionary, create_new_language_dictionary)
4625         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4626         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4627         (mdict_size, mdict_empty): New functions.
4628         * dictionary.h (mdict_iterator): Define.
4629
4630 2019-01-10  Pedro Alves  <palves@redhat.com>
4631
4632         * breakpoint.c (read_uploaded_action)
4633         (create_tracepoint_from_upload): Adjust to use
4634         gdb::unique_xmalloc_ptr.
4635         * ctf.c (ctf_write_uploaded_tp):
4636         (SET_ARRAY_FIELD): Use emplace_back.
4637         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4638         * tracefile-tfile.c (tfile_write_uploaded_tp):
4639         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4640         gdb::unique_xmalloc_ptr.
4641         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4642         at_string, cond_string, cmd_strings>: Replace char pointers
4643         with gdb::unique_xmalloc_ptr.
4644
4645 2019-01-10  Pedro Alves  <palves@redhat.com>
4646
4647         * solib-target.c (library_list_start_library): Don't xstrdup name.
4648
4649 2019-01-10  Pedro Alves  <palves@redhat.com>
4650
4651         * mdebugread.c (parse_partial_symbols): Use
4652         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4653
4654 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4655
4656         * linux-fork.c (scoped_switch_fork_info)
4657         <~scoped_switch_fork_info>: Fix incorrect variable name.
4658
4659 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4660
4661         * linux-fork.c (scoped_switch_fork_info)
4662         <scoped_switch_fork_info>: Make explicit.
4663         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4664
4665 2019-01-10  Tom Tromey  <tom@tromey.com>
4666
4667         * objfiles.h (objfile::reset_psymtabs): Update.
4668         * objfiles.c (objfile::objfile): Update.
4669         * psymtab.h (psymtab_storage::obstack): Update.
4670         (psymtab_storage::m_obstack): Use gdb::optional.
4671         (class psymtab_storage): Update comment.  Remove objfile
4672         parameter.
4673         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4674
4675 2019-01-10  Tom Tromey  <tom@tromey.com>
4676
4677         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4678         <free_psymtabs>: Now private.
4679         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4680         (allocate_psymtab): Use new method.
4681
4682 2019-01-10  Tom Tromey  <tom@tromey.com>
4683
4684         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4685         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4686         * mdebugread.c (parse_partial_symbols): Use
4687         allocate_dependencies.
4688         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4689         allocate_dependencies.
4690         (process_psymtab_comp_unit_reader)
4691         (build_type_psymtab_dependencies): Likewise.
4692         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4693
4694 2019-01-10  Tom Tromey  <tom@tromey.com>
4695
4696         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4697         PSYMBOL_SET_LANGUAGE.
4698         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4699
4700 2019-01-10  Tom Tromey  <tom@tromey.com>
4701
4702         * psymtab.h (psymtab_storage::obstack): New method.
4703         <m_obstack>: Rename from obstack; now private.
4704         * psymtab.c (psymtab_storage): Update.
4705         * dwarf2read.c (create_addrmap_from_index)
4706         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4707         Update.
4708
4709 2019-01-10  Tom Tromey  <tom@tromey.com>
4710
4711         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4712         * objfiles.h (objfile::reset_psymtabs): New method.
4713
4714 2019-01-10  Tom Tromey  <tom@tromey.com>
4715
4716         * symmisc.c (print_symbol_bcache_statistics): Update.
4717         (print_objfile_statistics): Update.
4718         * symfile.c (reread_symbols): Update.
4719         * psymtab.h (class psymtab_storage): New.
4720         * psymtab.c (psymtab_storage): New constructor.
4721         (~psymtab_storage): New destructor.
4722         (require_partial_symbols): Update.
4723         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4724         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4725         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4726         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4727         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4728         (start_psymtab_common, end_psymtab_common)
4729         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4730         (allocate_psymtab): Update.
4731         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4732         Update.
4733         (dump_psymtab_addrmap, maintenance_print_psymbols)
4734         (maintenance_check_psymtabs): Update.
4735         (class objfile_psymtabs): Move to objfiles.h.
4736         * psympriv.h (discard_psymtab): Now inline.
4737         (psymtab_discarder::psymtab_discarder): Update.
4738         (psymtab_discarder::~psymtab_discarder): Update.
4739         (ALL_OBJFILE_PSYMTABS): Rewrite.
4740         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4741         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4742         Remove fields.
4743         <partial_symtabs>: New field.
4744         (class objfile_psymtabs): Move from psymtab.h.  Update.
4745         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4746         psymbol_cache.
4747         (objfile::~objfile): Don't destroy psymbol_cache.
4748         * mdebugread.c (parse_partial_symbols): Update.
4749         * dwarf2read.c (create_addrmap_from_index)
4750         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4751         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4752         (add_partial_subprogram, dwarf2_ranges_read): Update.
4753         * dwarf-index-write.c (write_address_map)
4754         (write_one_signatured_type, recursively_write_psymbols)
4755         (class debug_names, class debug_names, write_psymtabs_to_index):
4756         Update.
4757
4758 2019-01-10  Tom Tromey  <tom@tromey.com>
4759
4760         * symtab.h (SYMBOL_SET_NAMES): Update.
4761         (symbol_set_names): Update.
4762         (MSYMBOL_SET_NAMES): Update.
4763         * symtab.c (symbol_set_names): Change argument to be an
4764         objfile_per_bfd_storage.
4765         * psymtab.c (add_psymbol_to_bcache): Update.
4766         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4767
4768 2019-01-10  Tom Tromey  <tom@tromey.com>
4769
4770         * symtab.c (create_demangled_names_hash): Change argument to be an
4771         objfile_per_bfd_storage.
4772         (symbol_set_names): Update.
4773
4774 2019-01-10  Tom Tromey  <tom@tromey.com>
4775
4776         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4777         init_psymbol_list.
4778         * psymtab.c (init_psymbol_list): Do nothing if already called.
4779         * psympriv.h (init_psymbol_list): Add comment.
4780         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4781         init_psymbol_list.
4782         * dbxread.c (dbx_symfile_read): Unconditionally call
4783         init_psymbol_list.
4784
4785 2019-01-10  Tom Tromey  <tom@tromey.com>
4786
4787         * xcoffread.c (scan_xcoff_symtab): Update.
4788         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4789         "where".
4790         * mdebugread.c (parse_partial_symbols)
4791         (handle_psymbol_enumerators): Update.
4792         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4793         * dbxread.c (read_dbx_symtab): Update.
4794         * psympriv.h (psymbol_placement): New enum.
4795         (add_psymbol_to_list): Update.
4796
4797 2019-01-10  Tom Tromey  <tom@tromey.com>
4798
4799         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4800         static_psymbols parameters.
4801         (scan_xcoff_symtab): Update.
4802         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4803         static_psymbols parameters.
4804         * psympriv.h (start_psymtab_common): Update.
4805         * mdebugread.c (parse_partial_symbols): Update.
4806         * dwarf2read.c (create_partial_symtab): Update.
4807         * dbxread.c (read_dbx_symtab): Update.
4808         (start_psymtab): Remove global_psymbols and static_psymbols
4809         parameters.
4810
4811 2019-01-10  Tom Tromey  <tom@tromey.com>
4812
4813         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4814         * psymtab.c (allocate_psymtab): Add comment.
4815         * psympriv.h (allocate_psymtab): Add comment.
4816         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4817         initializations.
4818         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4819
4820 2019-01-10  Tom Tromey  <tom@tromey.com>
4821
4822         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4823         Don't declare.
4824         * mipsread.c: Include mdebugread.h.
4825         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4826         Declare.
4827         * elfread.c: Include mdebugread.h.
4828
4829 2019-01-09  Tom Tromey  <tom@tromey.com>
4830
4831         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4832         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4833         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4834         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4835         (psym_lookup_symbol, psym_find_last_source_symtab)
4836         (psym_forget_cached_source_info, psym_print_stats)
4837         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4838         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4839         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4840         (psym_find_compunit_symtab_by_address)
4841         (maintenance_print_psymbols, maintenance_info_psymtabs)
4842         (maintenance_check_psymtabs): Use ranged for.
4843         * psymtab.h (class objfile_psymtabs): New.
4844         (require_partial_symbols): Return objfile_psymtabs.
4845         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4846
4847 2019-01-09  Tom Tromey  <tom@tromey.com>
4848
4849         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4850         (find_pc_mapped_section, list_overlays_command)
4851         (map_overlay_command, unmap_overlay_command)
4852         (simple_overlay_update): Use all_objfiles.
4853         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4854         * printcmd.c (info_symbol_command): Use all_objfiles.
4855         * objfiles.h (ALL_OBJSECTIONS): Remove.
4856         * maint.c (maintenance_translate_address): Use all_objfiles.
4857         * gcore.c (gcore_create_callback): Use all_objfiles.
4858         (objfile_find_memory_regions): Likewise.
4859
4860 2019-01-09  Tom Tromey  <tom@tromey.com>
4861
4862         * symtab.c (find_line_symtab, info_sources_command)
4863         (make_source_files_completion_list): Use objfile_compunits.
4864         * source.c (select_source_symtab): Use objfile_compunits.
4865         * objfiles.h (struct objfile): Update comment.
4866         (ALL_OBJFILES): Remove.
4867         (ALL_FILETABS): Remove.
4868         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4869         objfile_compunits.
4870
4871 2019-01-09  Tom Tromey  <tom@tromey.com>
4872
4873         * symmisc.c (print_objfile_statistics, dump_objfile)
4874         (maintenance_print_symbols): Use compunit_filetabs.
4875         * source.c (forget_cached_source_info_for_objfile): Use
4876         compunit_filetabs.
4877         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4878         (ALL_FILETABS): Use compunit_filetabs.
4879         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4880         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4881
4882 2019-01-09  Tom Tromey  <tom@tromey.com>
4883
4884         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4885         (compunit_filetabs): New.
4886         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4887         compunit_filetabs.
4888         (info_sources_command, make_source_files_completion_list): Remove
4889         declaration.
4890         * symmisc.c (print_objfile_statistics, dump_objfile)
4891         (maintenance_print_symbols): Remove declaration.
4892         (maintenance_info_symtabs): Use compunit_filetabs.
4893         (maintenance_info_line_tables): Likewise.
4894         * source.c (select_source_symtab): Change local variable name.
4895         (forget_cached_source_info_for_objfile): Remove declaration.
4896         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4897         * objfiles.c (objfile_relocate1): Remove declaration.
4898         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4899         declaration.
4900         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4901         * coffread.c (coff_symtab_read): Remove declaration.
4902         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4903         compunit_filetabs.
4904
4905 2019-01-09  Tom Tromey  <tom@tromey.com>
4906
4907         * symtab.c (lookup_objfile_from_block)
4908         (find_pc_sect_compunit_symtab, search_symbols)
4909         (default_collect_symbol_completion_matches_break_on): Use
4910         objfile_compunits.
4911         * objfiles.h (ALL_COMPUNITS): Remove.
4912         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4913         * cp-support.c (add_symbol_overload_list_qualified): Use
4914         objfile_compunits.
4915         * ada-lang.c (ada_collect_symbol_completion_matches)
4916         (ada_add_global_exceptions): Use objfile_compunits.
4917
4918 2019-01-09  Tom Tromey  <tom@tromey.com>
4919
4920         * source.c (select_source_symtab)
4921         (forget_cached_source_info_for_objfile): Remove declaration.
4922         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4923         declaration.
4924         * maint.c (count_symtabs_and_blocks): Remove declaration.
4925         * cp-support.c (add_symbol_overload_list_qualified): Remove
4926         declaration.
4927         * coffread.c (coff_symtab_read): Remove declaration.
4928         * symtab.c (lookup_symbol_in_objfile_symtabs)
4929         (basic_lookup_transparent_type_1): Use objfile_compunits.
4930         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4931         (info_sources_command, search_symbols)
4932         (default_collect_symbol_completion_matches_break_on)
4933         (make_source_files_completion_list): Remove declaration.
4934         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4935         (ada_collect_symbol_completion_matches)
4936         (ada_add_global_exceptions): Remove declaration.
4937         * linespec.c (iterate_over_all_matching_symtabs): Use
4938         objfile_compunits.
4939         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4940         (class objfile_compunits): New.
4941         (ALL_COMPUNITS): Use objfile_compunits.
4942         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4943         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4944         objfile_compunits.
4945         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4946
4947 2019-01-09  Tom Tromey  <tom@tromey.com>
4948
4949         * symtab.c (search_symbols)
4950         (default_collect_symbol_completion_matches_break_on): Use
4951         objfile_msymbols.
4952         * ada-lang.c (ada_lookup_simple_minsym)
4953         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4954         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4955         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4956         objfile_msymbols.
4957         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4958         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4959         * objc-lang.c (find_methods): Use objfile_msymbols.
4960         (info_selectors_command, info_classes_command): Likewise.
4961         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4962         * objfiles.h (class objfile_msymbols): New.
4963         (ALL_OBJFILE_MSYMBOLS): Remove.
4964         (ALL_MSYMBOLS): Remove.
4965
4966 2019-01-09  Tom Tromey  <tom@tromey.com>
4967
4968         * common/next-iterator.h (next_adapter): Add Iterator template
4969         parameter.
4970         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4971         (class all_objfiles_safe): New.
4972         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4973         * objfiles.c (put_objfile_before): Update comment.
4974         (add_separate_debug_objfile): Likewise.
4975         (free_all_objfiles): Use all_objfiles_safe.
4976         (objfile_purge_solibs): Likewise.
4977
4978 2019-01-09  Tom Tromey  <tom@tromey.com>
4979
4980         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4981         (expand_symtab_containing_pc, lookup_static_symbol)
4982         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4983         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4984         all_objfiles.
4985         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4986         * breakpoint.c (create_overlay_event_breakpoint)
4987         (create_longjmp_master_breakpoint)
4988         (create_std_terminate_master_breakpoint)
4989         (create_exception_master_breakpoint): Use all_objfiles.
4990         * linux-thread-db.c (try_thread_db_load_from_pdir)
4991         (has_libpthread): Use all_objfiles.
4992         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4993         * linespec.c (iterate_over_all_matching_symtabs)
4994         (search_minsyms_for_name): Use all_objfiles.
4995         * maint.c (maintenance_info_sections): Use all_objfiles.
4996         * main.c (captured_main_1): Use all_objfiles.
4997         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4998         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4999         * guile/scm-pretty-print.c
5000         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5001         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5002         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5003         (maintenance_print_msymbols): Use all_objfiles.
5004         * source.c (select_source_symtab): Use all_objfiles.
5005         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5006         * symfile.c (remove_symbol_file_command)
5007         (expand_symtabs_matching, map_symbol_filenames): Use
5008         all_objfiles.
5009         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5010         all_objfiles.
5011         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5012         * objc-lang.c (find_methods): Use all_objfiles.
5013         * objfiles.c (have_partial_symbols, have_full_symbols)
5014         (have_minimal_symbols, qsort_cmp)
5015         (default_iterate_over_objfiles_in_search_order): Use
5016         all_objfiles.
5017         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5018         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5019         (maintenance_check_psymtabs): Use all_objfiles.
5020         (ALL_PSYMTABS): Remove.
5021         * compile/compile-object-run.c (do_module_cleanup): Use
5022         all_objfiles.
5023         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5024         * cp-support.c (add_symbol_overload_list_qualified): Use
5025         all_objfiles.
5026         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5027         Use all_objfiles.
5028         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5029         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5030         all_objfiles.
5031         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5032         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5033         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5034         Uses all_objfiles.
5035         * solib.c (solib_read_symbols): Use all_objfiles
5036
5037 2019-01-09  Tom Tromey  <tom@tromey.com>
5038
5039         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5040         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5041         all_objfiles.
5042         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5043         * symmisc.c (print_symbol_bcache_statistics)
5044         (print_objfile_statistics, maintenance_print_objfiles)
5045         (maintenance_info_symtabs, maintenance_check_symtabs)
5046         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5047         all_objfiles.
5048         * source.c (forget_cached_source_info): Use all_objfiles.
5049         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5050         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5051         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5052         * objfiles.c (update_section_map): Use all_objfiles.
5053         (shared_objfile_contains_address_p): Likewise.
5054         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5055         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5056
5057 2019-01-09  Tom Tromey  <tom@tromey.com>
5058
5059         * common/next-iterator.h: New file.
5060         * objfiles.h (class all_objfiles): New.
5061         (struct objfile_iterator): New.
5062
5063 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5064
5065         * NEWS: Move the description of the changed "frame", "select-frame",
5066          and "info frame" commands to the Changed commands section.
5067
5068 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5069
5070         * gdbtypes.c (check_stub_method_group): Remove handling of old
5071         mangling schemes.
5072         * linespec.c (find_methods): Likewise.
5073         * stabsread.c (read_member_functions): Likewise.
5074         * valops.c (search_struct_method): Likewise.
5075         (value_struct_elt_for_reference): Likewise.
5076         * NEWS: Mention this change.
5077
5078 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5079
5080         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5081         print_source_lines.
5082         * source.c (print_source_lines_base): Update line number check.
5083         (print_source_lines): New function.
5084         (source_lines_range::source_lines_range): New function.
5085         * source.h (class source_lines_range): New class.
5086         (print_source_lines): New declaration.
5087
5088 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5089
5090         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5091
5092 2019-01-08  Tom Tromey  <tom@tromey.com>
5093             Simon Marchi  <simon.marchi@ericsson.com>
5094
5095         PR gdb/24060
5096         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5097         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5098         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5099         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5100         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5101         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5102
5103 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5104
5105         * source.c (select_source_symtab): Move header comment to
5106         declaration in source.h.
5107         (forget_cached_source_info_for_objfile): Likewise.
5108         (forget_cached_source_info): Likewise.
5109         (identify_source_line): Likewise.
5110         * source.h (identify_source_line): Move declaration from symtab.h
5111         and add comment from source.c
5112         (print_source_lines): Likewise.
5113         (forget_cached_source_info_for_objfile): Likewise.
5114         (forget_cached_source_info): Likewise.
5115         (select_source_symtab): Likewise.
5116         (enum print_source_lines_flag): Move definition from symtab.h.
5117         * symtab.h (identify_source_line): Move declaration to source.h.
5118         (print_source_lines): Likewise.
5119         (forget_cached_source_info_for_objfile): Likewise.
5120         (forget_cached_source_info): Likewise.
5121         (select_source_symtab): Likewise.
5122         (enum print_source_lines_flag): Move definition to source.h.
5123         * tui/tui-hooks.c: Add 'source.h' include.
5124
5125 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5126
5127         * source.c (print_source_lines_base): Handle requests to print
5128         reverse line number sequences, and guard against empty lines
5129         string.
5130
5131 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5132
5133         * source.c (print_source_lines_base): Fix skip of '\r' if next
5134         character is '\n'.
5135
5136 2019-01-06  Tom Tromey  <tom@tromey.com>
5137
5138         * c-exp.y (struct c_parse_state) <macro_original_text,
5139         expansion_obstack>: New member.
5140         (macro_original_text, expansion_obstack): Remove globals.
5141         (scan_macro_expansion, scanning_macro_expansion)
5142         (finished_macro_expansion): Update.
5143         (scan_macro_cleanup): Remove.
5144         (yylex, c_parse): Update.
5145
5146 2019-01-06  Tom Tromey  <tom@tromey.com>
5147
5148         * c-exp.y (struct c_parse_state) <strings>: New member.
5149         (operator_stoken): Update.
5150
5151 2019-01-06  Tom Tromey  <tom@tromey.com>
5152
5153         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5154         (union type_stack_elt) <typelist_val>: Now a pointer to
5155         std::vector.
5156         (type_stack_cleanup): Don't declare.
5157         (push_typelist): Update.
5158         * parse.c (pop_typelist): Return a std::vector.
5159         (push_typelist): Take a std::vector.
5160         (follow_types): Update.  Do not free args.
5161         (type_stack_cleanup): Remove.
5162         * c-exp.y (struct c_parse_state): New.
5163         (cpstate): New global.
5164         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5165         (nonempty_typelist): Update.
5166         (func_mod): Create a new vector.
5167         (c_parse): Create a c_parse_state.
5168         (check_parameter_typelist): Do not delete params.
5169         (function_method): Update.  Do not delete type_list.
5170
5171 2019-01-06  Tom Tromey  <tom@tromey.com>
5172
5173         PR gdb/28155:
5174         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5175         check_typedef.
5176         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5177         (print_return_value): Likewise.
5178
5179 2019-01-05  Tom Tromey  <tom@tromey.com>
5180
5181         * contrib/cleanup_check.py: Remove.
5182         * contrib/gcc-with-excheck: Remove.
5183         * contrib/exsummary.py: Remove.
5184         * contrib/excheck.py: Remove.
5185
5186 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5187
5188         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5189         NULL. Initialize tpprev to NULL instead of assigning it
5190         to NULL on the next statement.
5191         * windows-nat.c (windows_delete_thread): Remove check for
5192         main_thread_id before printing thread exit notifications.
5193         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5194         Remove thread ID check against main_thread_id.
5195         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5196         windows_delete_thread.
5197         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5198
5199 2019-01-04  Tom Tromey  <tom@tromey.com>
5200
5201         * compile/compile.c (_initialize_compile): Use upper case for
5202         metasyntactic variables.
5203         * symmisc.c (_initialize_symmisc): Use upper case for
5204         metasyntactic variables.
5205         * psymtab.c (_initialize_psymtab): Use upper case for
5206         metasyntactic variables.
5207         * demangle.c (demangle_command): Use upper case for metasyntactic
5208         variables.
5209         (_initialize_demangler): Likewise.
5210         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5211         variables.
5212
5213 2019-01-03  Tom Tromey  <tom@tromey.com>
5214
5215         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5216
5217 2019-01-03  Tom Tromey  <tom@tromey.com>
5218
5219         * python/py-symtab.c (salpy_str): Update.
5220         (struct salpy_sal_object) <symtab>: Now a PyObject.
5221         (salpy_dealloc): Update.
5222         (del_objfile_sal): Use gdbpy_ref.
5223
5224 2019-01-03  Tom Tromey  <tom@tromey.com>
5225
5226         * python/py-type.c (convert_field): Use new_reference.  Return
5227         gdbpy_ref.
5228         (make_fielditem): Return gdbpy_ref.
5229         (typy_fields): Update.
5230         (typy_getitem): Update.
5231         (field_name): Return gdbpy_ref.  Use new_reference.
5232         (typy_iterator_iternext): Update.
5233
5234 2019-01-03  Tom Tromey  <tom@tromey.com>
5235
5236         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5237
5238 2019-01-03  Tom Tromey  <tom@tromey.com>
5239
5240         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5241         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5242         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5243         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5244         (pspy_set_type_printers): Likewise.
5245         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5246         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5247         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5248         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5249         (objfpy_set_type_printers): Likewise.
5250
5251 2019-01-03  Tom Tromey  <tom@tromey.com>
5252
5253         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5254         (gdbpy_print_stack): Use gdbpy_err_fetch.
5255         * python/python-internal.h (class gdbpy_err_fetch): New class.
5256         (class gdbpy_enter) <m_error_type, m_error_value,
5257         m_error_traceback>: Remove.
5258         <m_error>: New member.
5259         (gdbpy_exception_to_string): Don't declare.
5260         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5261         * python/py-value.c (convert_value_from_python): Use
5262         gdbpy_err_fetch.
5263         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5264         gdbpy_exception_to_string.
5265         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5266         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5267         gdbpy_err_fetch.
5268
5269 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5270
5271         * linux-nat.c (delete_lwp_cleanup): Delete.
5272         (struct lwp_deleter): New struct.
5273         (lwp_info_up): New typedef.
5274         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5275         lwp_info_up.
5276
5277 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5278
5279         * linux-fork.c (class scoped_switch_fork_info): New class.
5280         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5281
5282 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5283
5284         * valops.c (find_overload_match): Remove use of null_cleanup, and
5285         calls to do_cleanups.
5286
5287 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5288
5289         * compile/compile-cplus-types.c
5290         (compile_cplus_instance::decl_name): Handle changes to
5291         cp_func_name.
5292         * cp-support.c (cp_func_name): Update header comment, update
5293         return type.
5294         * cp-support.h (cp_func_name): Update return type in declaration.
5295         * valops.c (find_overload_match): Move temp_func local to top
5296         level of function and change its type.  Use temp_func to hold and
5297         delete temporary string obtained from cp_func_name.
5298
5299 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5300
5301         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5302         gdb::char_vector, remove cleanup, and update uses of `msg`.
5303
5304 2019-01-03  Jim Wilson  <jimw@sifive.com>
5305
5306         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5307
5308 2019-01-02  Tom Tromey  <tom@tromey.com>
5309
5310         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5311         (tdesc_parse_xml): Remove cleanups.
5312         * target-descriptions.h (make_cleanup_free_target_description):
5313         Don't declare.
5314         (target_desc_deleter): New struct.
5315         (target_desc_up): New typedef.
5316         * target-descriptions.c (target_desc_deleter::operator()): Rename
5317         from free_target_description.
5318         (make_cleanup_free_target_description): Remove.
5319
5320 2019-01-02  Tom Tromey  <tom@tromey.com>
5321
5322         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5323         constructor, destructor.
5324         (linespec_parser): Remove typedef.
5325         (~linespec_parser): Rename from linespec_parser_delete.
5326         (linespec_lex_to_end, linespec_complete_label)
5327         (linespec_complete): Update.
5328         (decode_line_full): Remove cleanups.
5329         (decode_line_1): Update.
5330
5331 2019-01-02  Tom Tromey  <tom@tromey.com>
5332
5333         * python/python-internal.h (inferior_to_inferior_object): Change
5334         return type.
5335         * python/py-exitedevent.c (create_exited_event_object): Update.
5336         * python/py-inferior.c (inferior_to_inferior_object): Return
5337         gdbpy_ref.
5338         (python_new_inferior, python_inferior_deleted)
5339         (thread_to_thread_object, delete_thread_object)
5340         (build_inferior_list, gdbpy_selected_inferior): Update.
5341         * python/py-infthread.c (create_thread_object): Update.  Also fail
5342         if inferior_to_inferior_object fails.
5343
5344 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5345
5346         * inferior.h (class inferior) <displaced_step_state>: New field.
5347         * infrun.h (struct displaced_step_state): Move here from
5348         infrun.c.  Initialize fields, add constructor.
5349         <inf>: Remove field.
5350         <reset>: New method.
5351         * infrun.c (struct displaced_step_inferior_state): Move to
5352         infrun.h.
5353         (displaced_step_inferior_states): Remove.
5354         (get_displaced_stepping_state): Adust.
5355         (displaced_step_in_progress_any_inferior): Adjust.
5356         (displaced_step_in_progress_thread): Adjust.
5357         (displaced_step_in_progress): Adjust.
5358         (add_displaced_stepping_state): Remove.
5359         (get_displaced_step_closure_by_addr): Adjust.
5360         (remove_displaced_stepping_state): Remove.
5361         (infrun_inferior_exit): Call displaced_step_state.reset.
5362         (use_displaced_stepping): Don't check for NULL.
5363         (displaced_step_prepare_throw): Call
5364         get_displaced_stepping_state.
5365         (displaced_step_fixup): Don't check for NULL.
5366         (prepare_for_detach): Don't check for NULL.
5367
5368 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5369
5370         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5371          in case of call that did not complete.
5372
5373 2019-01-02  Andrey Utkin  <autkin@undo.io>
5374
5375         * symfile.c (find_separate_debug_file): Fix search of debug files for
5376         remote debuggee.
5377
5378 2019-01-02  Tom Tromey  <tom@tromey.com>
5379
5380         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5381         indentation.
5382         * python/py-frame.c (frapy_older): Remove cast.
5383         (frapy_newer): Likewise.
5384         * python/py-breakpoint.c (local_setattro): Remove cast.
5385         * python/py-arch.c (archpy_name): Remove local variable.
5386         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5387
5388 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5389
5390         * unittests/basic_string_view/element_access/char/empty.cc:
5391         Fix year range in copyright header.
5392
5393 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5394
5395         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5396         Delete.
5397         <operator==>: Update with for removed field.
5398         <hash>: Likewise.
5399         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5400         <isa_features>: ...this.
5401         <abi_features>: New field.
5402         (riscv_isa_flen): Update comment.
5403         (riscv_abi_xlen): New declaration.
5404         (riscv_abi_flen): New declaration.
5405         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5406         isa_features.
5407         (riscv_abi_xlen): New function.
5408         (riscv_isa_flen): Update to get answer from isa_features.
5409         (riscv_abi_flen): New function.
5410         (riscv_has_fp_abi): Update to get answer from abi_features.
5411         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5412         xlen and flen.
5413         (riscv_call_info) <xlen, flen>: Update comment.
5414         (riscv_call_arg_struct): Remove invalid assertions
5415         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5416         is removed.
5417         (riscv_gdbarch_init): Gather isa features and abi features
5418         separately, ensure both match on the gdbarch when reusing an old
5419         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5420         a target with 64-bit float hardware.
5421
5422 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5423
5424         * source.c (search_command_helper): Stop reverse search
5425         when line 1 has been searched.
5426
5427 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5428
5429         * record-full.c (record_full_base_target::close): Rewrite
5430         record_full_core_buf_list free logic.
5431
5432 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5433
5434         * break-catch-syscall.c (print_one_catch_syscall): xfree
5435         the last text.
5436
5437 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5438
5439         * top.c (print_gdb_version): Update Copyright year in version
5440         message.
5441
5442 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5443
5444         Update copyright year range in all GDB files.
5445
5446 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5447
5448         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5449
5450 For older changes see ChangeLog-2018.
5451 \f
5452 Local Variables:
5453 mode: change-log
5454 left-margin: 8
5455 fill-column: 74
5456 version-control: never
5457 coding: utf-8
5458 End:
5459