gdb/ChangeLog

   1 2019-01-22  Tom Tromey  <tom@tromey.com>
   2
   3         * corelow.c: Do not include sys/file.h.
   4
   5 2019-01-22  Tom Tromey  <tom@tromey.com>
   6
   7         * tui/tui-wingeneral.h: Include gdb_curses.h.
   8
   9 2019-01-22  Tom Tromey  <tom@tromey.com>
  10
  11         * source-cache.h (class source_cache) <get_source_lines,
  12         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
  13
  14 2019-01-22  Tom Tromey  <tom@tromey.com>
  15
  16         * remote-fileio.h (struct remote_target): Declare.
  17
  18 2019-01-22  Tom Tromey  <tom@tromey.com>
  19
  20         * python/py-arch.c: Do not include py-ref.h.
  21         * python/py-bpevent.c: Do not include py-ref.h.
  22         * python/py-cmd.c: Do not include py-ref.h.
  23         * python/py-continueevent.c: Do not include py-ref.h.
  24         * python/py-event.h: Do not include py-ref.h.
  25         * python/py-evtregistry.c: Do not include py-ref.h.
  26         * python/py-finishbreakpoint.c: Do not include py-ref.h.
  27         * python/py-frame.c: Do not include py-ref.h.
  28         * python/py-framefilter.c: Do not include py-ref.h.
  29         * python/py-function.c: Do not include py-ref.h.
  30         * python/py-infevents.c: Do not include py-ref.h.
  31         * python/py-linetable.c: Do not include py-ref.h.
  32         * python/py-objfile.c: Do not include py-ref.h.
  33         * python/py-param.c: Do not include py-ref.h.
  34         * python/py-prettyprint.c: Do not include py-ref.h.
  35         * python/py-progspace.c: Do not include py-ref.h.
  36         * python/py-symbol.c: Do not include py-ref.h.
  37         * python/py-symtab.c: Do not include py-ref.h.
  38         * python/py-type.c: Do not include py-ref.h.
  39         * python/py-unwind.c: Do not include py-ref.h.
  40         * python/py-utils.c: Do not include py-ref.h.
  41         * python/py-value.c: Do not include py-ref.h.
  42         * python/py-varobj.c: Do not include py-ref.h.
  43         * python/py-xmethods.c: Do not include py-ref.h.
  44         * python/python.c: Do not include py-ref.h.
  45         * varobj.c: Do not include py-ref.h.
  46
  47 2019-01-22  Tom Tromey  <tom@tromey.com>
  48
  49         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
  50         keyword for bcache.
  51
  52 2019-01-22  Tom Tromey  <tom@tromey.com>
  53
  54         * compile/compile-cplus-types.c: Remove a comment by #include.
  55
  56 2019-01-22  Tom Tromey  <tom@tromey.com>
  57
  58         * compile/gcc-c-plugin.h: Include compile-internal.h.
  59
  60 2019-01-22  Tom Tromey  <tom@tromey.com>
  61
  62         * stabsread.c (EXTERN): Do not define.
  63         (symnum, next_symbol_text_func, processing_gcc_compilation)
  64         (within_function, global_sym_chain, global_stabs)
  65         (previous_stab_code, this_object_header_files)
  66         (n_this_object_header_files)
  67         (n_allocated_this_object_header_files): Define.
  68         * stabsread.h (EXTERN): Never define.  Use "extern".
  69
  70 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  71
  72         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
  73         history_value.
  74
  75 2019-01-21  Tom Tromey  <tom@tromey.com>
  76
  77         * ui-out.c: Fix includes.
  78         * tui/tui-source.c: Fix includes.
  79         * target.c: Fix includes.
  80         * remote.c: Fix includes.
  81         * regcache.c: Fix includes.
  82         * python/py-block.c: Fix includes.
  83         * printcmd.c: Fix includes.
  84         * or1k-tdep.c: Fix includes.
  85         * mi/mi-main.c: Fix includes.
  86         * m32r-tdep.c: Fix includes.
  87         * csky-tdep.c: Fix includes.
  88         * compile/compile-cplus-types.c: Fix includes.
  89         * cli/cli-interp.c: Fix includes.
  90
  91 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
  92
  93         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
  94         for padding.
  95
  96 2019-01-16  Tom Tromey  <tom@tromey.com>
  97
  98         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
  99         earlier.
 100         (struct objfile) <msymbols_range>: Move from top level.
 101         <msymbols>: New method.
 102         (class objfile_msymbols): Remove.
 103         * symtab.c (default_collect_symbol_completion_matches_break_on):
 104         Update.
 105         * symmisc.c (dump_msymbols): Update.
 106         * stabsread.c (scan_file_globals): Update.
 107         * objc-lang.c (info_selectors_command, info_classes_command)
 108         (find_methods): Update.
 109         * minsyms.c (find_solib_trampoline_target): Update.
 110         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 111         * coffread.c (coff_symfile_read): Update.
 112         * ada-lang.c (ada_lookup_simple_minsym)
 113         (ada_collect_symbol_completion_matches): Update.
 114
 115 2019-01-16  Tom Tromey  <tom@tromey.com>
 116
 117         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 118         type.  Remove no-argument constructor.
 119         <iterator::operator++>: Simplify.
 120         <begin>: Update.
 121         <end>: Use minimal_symbol_count.
 122
 123 2019-01-16  Tom Tromey  <tom@tromey.com>
 124
 125         * objfiles.h (struct objfile) <psymtabs>: New method.
 126         (class objfile_psymtabs): Remove.
 127         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 128         typedef.
 129         <range>: New method.
 130         (require_partial_symbols): Change return type.
 131         * psymtab.c (require_partial_symbols)
 132         (psym_expand_symtabs_matching): Update.
 133         * mdebugread.c (parse_partial_symbols): Update.
 134         * dbxread.c (dbx_end_psymtab): Update.
 135
 136 2019-01-15  Tom Tromey  <tom@tromey.com>
 137
 138         * symtab.c (lookup_objfile_from_block)
 139         (lookup_symbol_in_objfile_symtabs)
 140         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 141         (find_line_symtab, info_sources_command)
 142         (default_collect_symbol_completion_matches_break_on)
 143         (make_source_files_completion_list): Update.
 144         * symmisc.c (print_objfile_statistics, dump_objfile)
 145         (maintenance_print_symbols, maintenance_info_symtabs)
 146         (maintenance_check_symtabs, maintenance_info_line_tables):
 147         Update.
 148         * source.c (select_source_symtab)
 149         (forget_cached_source_info_for_objfile): Update.
 150         * objfiles.h (class objfile_compunits): Remove.
 151         (struct objfile) <compunits_range>: New typedef.
 152         (compunits): New method.
 153         * objfiles.c (objfile_relocate1): Update.
 154         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 155         * maint.c (count_symtabs_and_blocks): Update.
 156         * linespec.c (iterate_over_all_matching_symtabs): Update.
 157         * cp-support.c (add_symbol_overload_list_qualified): Update.
 158         * coffread.c (coff_symtab_read): Update.
 159         * ada-lang.c (add_nonlocal_symbols)
 160         (ada_collect_symbol_completion_matches)
 161         (ada_add_global_exceptions): Update.
 162
 163 2019-01-15  Tom Tromey  <tom@tromey.com>
 164
 165         * progspace.h (program_space) <objfiles_safe_range>: New
 166         typedef.
 167         <objfiles_safe>: New method.
 168         * objfiles.h (class all_objfiles_safe): Remove.
 169         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 170         * jit.c (jit_inferior_exit_hook): Update.
 171
 172 2019-01-17  Tom Tromey  <tom@tromey.com>
 173
 174         * progspace.h (program_space) <objfiles_range>: New typedef.
 175         <objfiles>: New method.
 176         <objfiles_head>: Rename from objfiles.
 177         (object_files): Update.
 178         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 179         * guile/scm-pretty-print.c
 180         (ppscm_find_pretty_printer_from_objfiles): Update.
 181         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 182         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 183         Update.
 184         * python/py-progspace.c (pspy_get_objfiles): Update.
 185         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 186         Update.
 187         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 188         (objfpy_lookup_objfile_by_build_id): Update.
 189         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 190         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 191         Update.
 192         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 193         (expand_symtab_containing_pc, lookup_objfile_from_block)
 194         (lookup_static_symbol, basic_lookup_transparent_type)
 195         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 196         (find_line_symtab, info_sources_command)
 197         (default_collect_symbol_completion_matches_break_on)
 198         (make_source_files_completion_list, find_main_name): Update.
 199         * symmisc.c (print_symbol_bcache_statistics)
 200         (print_objfile_statistics, maintenance_print_symbols)
 201         (maintenance_print_msymbols, maintenance_print_objfiles)
 202         (maintenance_info_symtabs, maintenance_check_symtabs)
 203         (maintenance_expand_symtabs, maintenance_info_line_tables):
 204         Update.
 205         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 206         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 207         (map_overlay_command, unmap_overlay_command)
 208         (simple_overlay_update, expand_symtabs_matching)
 209         (map_symbol_filenames): Update.
 210         * symfile-debug.c (set_debug_symfile): Update.
 211         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 212         Update.
 213         * source.c (select_source_symtab, forget_cached_source_info):
 214         Update.
 215         * solib.c (solib_read_symbols): Update.
 216         * solib-spu.c (append_ocl_sos): Update.
 217         * psymtab.c (maintenance_print_psymbols)
 218         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 219         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 220         * printcmd.c (info_symbol_command): Update.
 221         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 222         Update.
 223         * objfiles.h (class all_objfiles): Remove.
 224         * objfiles.c (have_partial_symbols, have_full_symbols)
 225         (have_minimal_symbols, qsort_cmp, update_section_map)
 226         (shared_objfile_contains_address_p)
 227         (default_iterate_over_objfiles_in_search_order): Update.
 228         * objc-lang.c (info_selectors_command, info_classes_command)
 229         (find_methods): Update.
 230         * minsyms.c (find_solib_trampoline_target): Update.
 231         * maint.c (maintenance_info_sections)
 232         (maintenance_translate_address, count_symtabs_and_blocks):
 233         Update.
 234         * main.c (captured_main_1): Update.
 235         * linux-thread-db.c (try_thread_db_load_from_pdir)
 236         (has_libpthread): Update.
 237         * linespec.c (iterate_over_all_matching_symtabs)
 238         (search_minsyms_for_name): Update.
 239         * jit.c (jit_find_objf_with_entry_addr): Update.
 240         * hppa-tdep.c (find_unwind_entry)
 241         (hppa_lookup_stub_minimal_symbol): Update.
 242         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 243         Update.
 244         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 245         (elf_gnu_ifunc_resolve_by_got): Update.
 246         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 247         * dwarf-index-write.c (save_gdb_index_command): Update.
 248         * cp-support.c (add_symbol_overload_list_qualified): Update.
 249         * breakpoint.c (create_overlay_event_breakpoint)
 250         (create_longjmp_master_breakpoint)
 251         (create_std_terminate_master_breakpoint)
 252         (create_exception_master_breakpoint): Update.
 253         * blockframe.c (find_pc_partial_function): Update.
 254         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 255         (ada_collect_symbol_completion_matches)
 256         (ada_add_global_exceptions): Update.
 257
 258 2019-01-17  Tom Tromey  <tom@tromey.com>
 259
 260         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 261         declare VEC.
 262         (solib_target_parse_libraries): Change return type.
 263         (library_list_start_segment, library_list_start_section)
 264         (library_list_end_library, library_list_start_library); Update.
 265         (solib_target_free_library_list): Remove.
 266         (solib_target_parse_libraries): Remove cleanup.  Change return
 267         type.
 268         (solib_target_current_sos): Update.
 269
 270 2019-01-17  Tom Tromey  <tromey@bapiya>
 271
 272         * valprint.c: Replace "the the" with "the".
 273         * symtab.c: Replace "the the" with "the".
 274         * solib.c: Replace "the the" with "the".
 275         * solib-dsbt.c: Replace "the the" with "the".
 276         * linespec.c: Replace "the the" with "the".
 277         * dwarf2loc.h: Replace "the the" with "the".
 278         * amd64-windows-tdep.c: Replace "the the" with "the".
 279         * aarch64-tdep.c: Replace "the the" with "the".
 280
 281 2019-01-16  Keith Seitz  <keiths@redhat.com>
 282
 283         PR gdb/23773
 284         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 285         <builder>: Rename to ..
 286         <m_builder>: ... this and make private.
 287         (dwarf2_cu::get_builder): New method.  Change all users of
 288         `builder' to use this method.
 289         (dwarf2_start_symtab): Move to ...
 290         (dwarf2_cu::start_symtab): ... here.  Update all callers
 291         (setup_type_unit_groups): Move to ...
 292         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 293         callers.
 294         (dwarf2_cu::reset_builder): New method.
 295         (process_full_compunit, process_full_type_unit): Use
 296         dwarf2_cu::reset_builder.
 297         (follow_die_offset): Record the ancestor CU if it is different
 298         from the followed DIE's CU.
 299         (follow_die_sig_1): Likewise.
 300
 301 2019-01-15  Tom Tromey  <tom@tromey.com>
 302
 303         * remote.c (class remote_state) <buf>: Now a char_vector.
 304         <buf_size>: Remove.
 305         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 306         parameter.
 307         (remote_target::getpkt_or_notif_sane_1)
 308         (remote_target::getpkt_sane)
 309         (remote_target::getpkt_or_notif_sane): Likewise.
 310         (class remote_target) <putpkt>: New overload.
 311         (remote_target::read_frame): Change type of "buf_p".  Remove
 312         sizeof_p parameter.
 313         (packet_ok): New overload.
 314         (packet_check_result): New overload.
 315         Update all uses.
 316
 317 2019-01-14  Tom Tromey  <tom@tromey.com>
 318
 319         * remote-notif.c (handle_notification, remote_notif_ack)
 320         (remote_notif_parse): Make "buf" const.
 321         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 322         const.
 323         (remote_notif_parse, remote_notif_ack, handle_notification):
 324         Likewise.
 325         * remote.c (remote_notif_stop_parse): Make "buf" const.
 326         (remote_target::remote_parse_stop_reply): Make "buf" const.
 327         (remote_notif_stop_ack): Make "buf" const.
 328
 329 2019-01-14  Tom Tromey  <tom@tromey.com>
 330
 331         * remote.c (remote_console_output): Make parameter const.
 332
 333 2019-01-14  Tom Tromey  <tom@tromey.com>
 334
 335         * target-debug.h (target_debug_print_signals): Constify.
 336         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 337         * procfs.c (procfs_target::pass_signals): Update.
 338         * linux-nat.c (linux_nat_target::pass_signals): Update.
 339         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 340         * target-delegates.c: Rebuild.
 341         * remote.c (remote_target::program_signals): Update.
 342         (remote_target::pass_signals): Update.
 343         * target.c (target_pass_signals): Constify argument.
 344         (target_program_signals): Likewise.
 345         * target.h (struct target_ops) <pass_signals, program_signals>:
 346         Constify argument.
 347         (target_pass_signals, target_program_signals): Constify argument.
 348
 349 2019-01-14  Tom Tromey  <tom@tromey.com>
 350
 351         PR tui/28819:
 352         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 353
 354 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 355
 356         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 357         field.
 358         * rs6000-tdep.c: Include reggroups.h.
 359         (IS_V_ALIAS_PSEUDOREG): Define.
 360         (rs6000_register_name): Return names for the "vX" aliases.
 361         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 362         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 363         aliases.  Call default_register_reggroup_p for all other
 364         pseudo-registers.
 365         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 366         New functions.
 367         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 368         Handle "vX" aliases.
 369         (v_alias_pseudo_register_collect): New function.
 370         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 371         (rs6000_gdbarch_init): Initialize "vX" aliases as
 372         pseudo-registers.  Restore registration of
 373         rs6000_pseudo_register_reggroup_p with
 374         set_tdesc_pseudo_register_reggroup_p.
 375
 376 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 377
 378         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 379         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 380         set_gdbarch_num_pseudo_regs.
 381
 382 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 383
 384         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 385         Remove arg prefixname, add do_set and do_show.
 386         Add member functions set_list and show_list.
 387         * cli/cli-style.c (class cli_style_option): Update accordingly.
 388         (style_set_list): Move to file scope.
 389         (style_show_list): Likewise.
 390         (set_style): Call help_list.
 391         (show_style): Call cmd_show_list.
 392         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 393         Update to use the new macro.
 394
 395 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 396
 397         * ada-lang.c (_initialize_ada_language): Expand the help text
 398         for the "catch exception" command.
 399
 400 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 401
 402         * symtab.c (matching_obj_sections): Initialize obj,
 403         declare it closer to its usage.
 404
 405 2019-01-10  Tom Tromey  <tom@tromey.com>
 406
 407         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 408         (basic_inf_threads_range): Remove.
 409         (inf_threads_range, inf_non_exited_threads_range)
 410         (safe_inf_threads_range): Use next_adapter.
 411
 412 2019-01-10  Keith Seitz  <keiths@redhat.com>
 413
 414         PR gdb/23712
 415         PR symtab/23010
 416         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 417         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 418
 419 2019-01-10  Keith Seitz  <keiths@redhat.com>
 420
 421         PR gdb/23712
 422         PR symtab/23010
 423         * dictionary.c (pending_to_vector): Remove.
 424         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 425         Remove _1 suffix, replacing functions of the same name.  Update
 426         all callers.
 427         (dict_create_hashed, dict_create_hashed_expandable)
 428         (dict_create_linear, dict_create_linear_expandable, dict_free)
 429         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 430         Make functions static.
 431
 432 2019-01-10  Keith Seitz  <keiths@redhat.com>
 433
 434         PR gdb/23712
 435         PR symtab/23010
 436         * dictionary.h (struct dictionary): Replace declaration with
 437         multidictionary.
 438         (dict_create_hashed, dict_create_hashed_expandable)
 439         (dict_create_linear, dict_create_linear_expandable)
 440         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 441         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 442         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 443         taking multidictionary argument.
 444         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 445         * block.h (struct block) <dict>: Change to multidictionary
 446         and rename `multidict'.
 447         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 448         symmisc.c: Update all dictionary references to multidictionary.
 449
 450 2019-01-10  Keith Seitz  <keiths@redhat.com>
 451
 452         PR gdb/23712
 453         PR symtab/23010
 454         * dictionary.c: Include unordered_map.
 455         (pending_to_vector): New function.
 456         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 457         Rewrite the non-"_1" functions to take vector instead
 458         of linked list.
 459         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 460         "new" _1 versions of the same name.
 461         (multidictionary): Define.
 462         (std::hash<enum language): New definition.
 463         (collate_pending_symbols_by_language, mdict_create_hashed)
 464         (mdict_create_hashed_expandable, mdict_create_linear)
 465         (mdict_create_linear_expandable, mdict_free)
 466         (find_language_dictionary, create_new_language_dictionary)
 467         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 468         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 469         (mdict_size, mdict_empty): New functions.
 470         * dictionary.h (mdict_iterator): Define.
 471
 472 2019-01-10  Pedro Alves  <palves@redhat.com>
 473
 474         * breakpoint.c (read_uploaded_action)
 475         (create_tracepoint_from_upload): Adjust to use
 476         gdb::unique_xmalloc_ptr.
 477         * ctf.c (ctf_write_uploaded_tp):
 478         (SET_ARRAY_FIELD): Use emplace_back.
 479         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 480         * tracefile-tfile.c (tfile_write_uploaded_tp):
 481         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 482         gdb::unique_xmalloc_ptr.
 483         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 484         at_string, cond_string, cmd_strings>: Replace char pointers
 485         with gdb::unique_xmalloc_ptr.
 486
 487 2019-01-10  Pedro Alves  <palves@redhat.com>
 488
 489         * solib-target.c (library_list_start_library): Don't xstrdup name.
 490
 491 2019-01-10  Pedro Alves  <palves@redhat.com>
 492
 493         * mdebugread.c (parse_partial_symbols): Use
 494         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 495
 496 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 497
 498         * linux-fork.c (scoped_switch_fork_info)
 499         <~scoped_switch_fork_info>: Fix incorrect variable name.
 500
 501 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 502
 503         * linux-fork.c (scoped_switch_fork_info)
 504         <scoped_switch_fork_info>: Make explicit.
 505         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 506
 507 2019-01-10  Tom Tromey  <tom@tromey.com>
 508
 509         * objfiles.h (objfile::reset_psymtabs): Update.
 510         * objfiles.c (objfile::objfile): Update.
 511         * psymtab.h (psymtab_storage::obstack): Update.
 512         (psymtab_storage::m_obstack): Use gdb::optional.
 513         (class psymtab_storage): Update comment.  Remove objfile
 514         parameter.
 515         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 516
 517 2019-01-10  Tom Tromey  <tom@tromey.com>
 518
 519         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 520         <free_psymtabs>: Now private.
 521         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 522         (allocate_psymtab): Use new method.
 523
 524 2019-01-10  Tom Tromey  <tom@tromey.com>
 525
 526         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 527         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 528         * mdebugread.c (parse_partial_symbols): Use
 529         allocate_dependencies.
 530         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 531         allocate_dependencies.
 532         (process_psymtab_comp_unit_reader)
 533         (build_type_psymtab_dependencies): Likewise.
 534         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 535
 536 2019-01-10  Tom Tromey  <tom@tromey.com>
 537
 538         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 539         PSYMBOL_SET_LANGUAGE.
 540         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 541
 542 2019-01-10  Tom Tromey  <tom@tromey.com>
 543
 544         * psymtab.h (psymtab_storage::obstack): New method.
 545         <m_obstack>: Rename from obstack; now private.
 546         * psymtab.c (psymtab_storage): Update.
 547         * dwarf2read.c (create_addrmap_from_index)
 548         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 549         Update.
 550
 551 2019-01-10  Tom Tromey  <tom@tromey.com>
 552
 553         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 554         * objfiles.h (objfile::reset_psymtabs): New method.
 555
 556 2019-01-10  Tom Tromey  <tom@tromey.com>
 557
 558         * symmisc.c (print_symbol_bcache_statistics): Update.
 559         (print_objfile_statistics): Update.
 560         * symfile.c (reread_symbols): Update.
 561         * psymtab.h (class psymtab_storage): New.
 562         * psymtab.c (psymtab_storage): New constructor.
 563         (~psymtab_storage): New destructor.
 564         (require_partial_symbols): Update.
 565         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 566         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 567         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 568         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 569         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 570         (start_psymtab_common, end_psymtab_common)
 571         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 572         (allocate_psymtab): Update.
 573         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 574         Update.
 575         (dump_psymtab_addrmap, maintenance_print_psymbols)
 576         (maintenance_check_psymtabs): Update.
 577         (class objfile_psymtabs): Move to objfiles.h.
 578         * psympriv.h (discard_psymtab): Now inline.
 579         (psymtab_discarder::psymtab_discarder): Update.
 580         (psymtab_discarder::~psymtab_discarder): Update.
 581         (ALL_OBJFILE_PSYMTABS): Rewrite.
 582         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 583         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 584         Remove fields.
 585         <partial_symtabs>: New field.
 586         (class objfile_psymtabs): Move from psymtab.h.  Update.
 587         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 588         psymbol_cache.
 589         (objfile::~objfile): Don't destroy psymbol_cache.
 590         * mdebugread.c (parse_partial_symbols): Update.
 591         * dwarf2read.c (create_addrmap_from_index)
 592         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 593         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 594         (add_partial_subprogram, dwarf2_ranges_read): Update.
 595         * dwarf-index-write.c (write_address_map)
 596         (write_one_signatured_type, recursively_write_psymbols)
 597         (class debug_names, class debug_names, write_psymtabs_to_index):
 598         Update.
 599
 600 2019-01-10  Tom Tromey  <tom@tromey.com>
 601
 602         * symtab.h (SYMBOL_SET_NAMES): Update.
 603         (symbol_set_names): Update.
 604         (MSYMBOL_SET_NAMES): Update.
 605         * symtab.c (symbol_set_names): Change argument to be an
 606         objfile_per_bfd_storage.
 607         * psymtab.c (add_psymbol_to_bcache): Update.
 608         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 609
 610 2019-01-10  Tom Tromey  <tom@tromey.com>
 611
 612         * symtab.c (create_demangled_names_hash): Change argument to be an
 613         objfile_per_bfd_storage.
 614         (symbol_set_names): Update.
 615
 616 2019-01-10  Tom Tromey  <tom@tromey.com>
 617
 618         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 619         init_psymbol_list.
 620         * psymtab.c (init_psymbol_list): Do nothing if already called.
 621         * psympriv.h (init_psymbol_list): Add comment.
 622         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 623         init_psymbol_list.
 624         * dbxread.c (dbx_symfile_read): Unconditionally call
 625         init_psymbol_list.
 626
 627 2019-01-10  Tom Tromey  <tom@tromey.com>
 628
 629         * xcoffread.c (scan_xcoff_symtab): Update.
 630         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 631         "where".
 632         * mdebugread.c (parse_partial_symbols)
 633         (handle_psymbol_enumerators): Update.
 634         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 635         * dbxread.c (read_dbx_symtab): Update.
 636         * psympriv.h (psymbol_placement): New enum.
 637         (add_psymbol_to_list): Update.
 638
 639 2019-01-10  Tom Tromey  <tom@tromey.com>
 640
 641         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 642         static_psymbols parameters.
 643         (scan_xcoff_symtab): Update.
 644         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 645         static_psymbols parameters.
 646         * psympriv.h (start_psymtab_common): Update.
 647         * mdebugread.c (parse_partial_symbols): Update.
 648         * dwarf2read.c (create_partial_symtab): Update.
 649         * dbxread.c (read_dbx_symtab): Update.
 650         (start_psymtab): Remove global_psymbols and static_psymbols
 651         parameters.
 652
 653 2019-01-10  Tom Tromey  <tom@tromey.com>
 654
 655         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 656         * psymtab.c (allocate_psymtab): Add comment.
 657         * psympriv.h (allocate_psymtab): Add comment.
 658         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 659         initializations.
 660         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 661
 662 2019-01-10  Tom Tromey  <tom@tromey.com>
 663
 664         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 665         Don't declare.
 666         * mipsread.c: Include mdebugread.h.
 667         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 668         Declare.
 669         * elfread.c: Include mdebugread.h.
 670
 671 2019-01-09  Tom Tromey  <tom@tromey.com>
 672
 673         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 674         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 675         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 676         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 677         (psym_lookup_symbol, psym_find_last_source_symtab)
 678         (psym_forget_cached_source_info, psym_print_stats)
 679         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 680         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 681         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 682         (psym_find_compunit_symtab_by_address)
 683         (maintenance_print_psymbols, maintenance_info_psymtabs)
 684         (maintenance_check_psymtabs): Use ranged for.
 685         * psymtab.h (class objfile_psymtabs): New.
 686         (require_partial_symbols): Return objfile_psymtabs.
 687         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 688
 689 2019-01-09  Tom Tromey  <tom@tromey.com>
 690
 691         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 692         (find_pc_mapped_section, list_overlays_command)
 693         (map_overlay_command, unmap_overlay_command)
 694         (simple_overlay_update): Use all_objfiles.
 695         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 696         * printcmd.c (info_symbol_command): Use all_objfiles.
 697         * objfiles.h (ALL_OBJSECTIONS): Remove.
 698         * maint.c (maintenance_translate_address): Use all_objfiles.
 699         * gcore.c (gcore_create_callback): Use all_objfiles.
 700         (objfile_find_memory_regions): Likewise.
 701
 702 2019-01-09  Tom Tromey  <tom@tromey.com>
 703
 704         * symtab.c (find_line_symtab, info_sources_command)
 705         (make_source_files_completion_list): Use objfile_compunits.
 706         * source.c (select_source_symtab): Use objfile_compunits.
 707         * objfiles.h (struct objfile): Update comment.
 708         (ALL_OBJFILES): Remove.
 709         (ALL_FILETABS): Remove.
 710         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 711         objfile_compunits.
 712
 713 2019-01-09  Tom Tromey  <tom@tromey.com>
 714
 715         * symmisc.c (print_objfile_statistics, dump_objfile)
 716         (maintenance_print_symbols): Use compunit_filetabs.
 717         * source.c (forget_cached_source_info_for_objfile): Use
 718         compunit_filetabs.
 719         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 720         (ALL_FILETABS): Use compunit_filetabs.
 721         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 722         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 723
 724 2019-01-09  Tom Tromey  <tom@tromey.com>
 725
 726         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 727         (compunit_filetabs): New.
 728         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 729         compunit_filetabs.
 730         (info_sources_command, make_source_files_completion_list): Remove
 731         declaration.
 732         * symmisc.c (print_objfile_statistics, dump_objfile)
 733         (maintenance_print_symbols): Remove declaration.
 734         (maintenance_info_symtabs): Use compunit_filetabs.
 735         (maintenance_info_line_tables): Likewise.
 736         * source.c (select_source_symtab): Change local variable name.
 737         (forget_cached_source_info_for_objfile): Remove declaration.
 738         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 739         * objfiles.c (objfile_relocate1): Remove declaration.
 740         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 741         declaration.
 742         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 743         * coffread.c (coff_symtab_read): Remove declaration.
 744         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 745         compunit_filetabs.
 746
 747 2019-01-09  Tom Tromey  <tom@tromey.com>
 748
 749         * symtab.c (lookup_objfile_from_block)
 750         (find_pc_sect_compunit_symtab, search_symbols)
 751         (default_collect_symbol_completion_matches_break_on): Use
 752         objfile_compunits.
 753         * objfiles.h (ALL_COMPUNITS): Remove.
 754         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 755         * cp-support.c (add_symbol_overload_list_qualified): Use
 756         objfile_compunits.
 757         * ada-lang.c (ada_collect_symbol_completion_matches)
 758         (ada_add_global_exceptions): Use objfile_compunits.
 759
 760 2019-01-09  Tom Tromey  <tom@tromey.com>
 761
 762         * source.c (select_source_symtab)
 763         (forget_cached_source_info_for_objfile): Remove declaration.
 764         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 765         declaration.
 766         * maint.c (count_symtabs_and_blocks): Remove declaration.
 767         * cp-support.c (add_symbol_overload_list_qualified): Remove
 768         declaration.
 769         * coffread.c (coff_symtab_read): Remove declaration.
 770         * symtab.c (lookup_symbol_in_objfile_symtabs)
 771         (basic_lookup_transparent_type_1): Use objfile_compunits.
 772         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 773         (info_sources_command, search_symbols)
 774         (default_collect_symbol_completion_matches_break_on)
 775         (make_source_files_completion_list): Remove declaration.
 776         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 777         (ada_collect_symbol_completion_matches)
 778         (ada_add_global_exceptions): Remove declaration.
 779         * linespec.c (iterate_over_all_matching_symtabs): Use
 780         objfile_compunits.
 781         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 782         (class objfile_compunits): New.
 783         (ALL_COMPUNITS): Use objfile_compunits.
 784         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 785         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 786         objfile_compunits.
 787         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 788
 789 2019-01-09  Tom Tromey  <tom@tromey.com>
 790
 791         * symtab.c (search_symbols)
 792         (default_collect_symbol_completion_matches_break_on): Use
 793         objfile_msymbols.
 794         * ada-lang.c (ada_lookup_simple_minsym)
 795         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 796         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 797         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 798         objfile_msymbols.
 799         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 800         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 801         * objc-lang.c (find_methods): Use objfile_msymbols.
 802         (info_selectors_command, info_classes_command): Likewise.
 803         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 804         * objfiles.h (class objfile_msymbols): New.
 805         (ALL_OBJFILE_MSYMBOLS): Remove.
 806         (ALL_MSYMBOLS): Remove.
 807
 808 2019-01-09  Tom Tromey  <tom@tromey.com>
 809
 810         * common/next-iterator.h (next_adapter): Add Iterator template
 811         parameter.
 812         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 813         (class all_objfiles_safe): New.
 814         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 815         * objfiles.c (put_objfile_before): Update comment.
 816         (add_separate_debug_objfile): Likewise.
 817         (free_all_objfiles): Use all_objfiles_safe.
 818         (objfile_purge_solibs): Likewise.
 819
 820 2019-01-09  Tom Tromey  <tom@tromey.com>
 821
 822         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 823         (expand_symtab_containing_pc, lookup_static_symbol)
 824         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 825         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 826         all_objfiles.
 827         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 828         * breakpoint.c (create_overlay_event_breakpoint)
 829         (create_longjmp_master_breakpoint)
 830         (create_std_terminate_master_breakpoint)
 831         (create_exception_master_breakpoint): Use all_objfiles.
 832         * linux-thread-db.c (try_thread_db_load_from_pdir)
 833         (has_libpthread): Use all_objfiles.
 834         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 835         * linespec.c (iterate_over_all_matching_symtabs)
 836         (search_minsyms_for_name): Use all_objfiles.
 837         * maint.c (maintenance_info_sections): Use all_objfiles.
 838         * main.c (captured_main_1): Use all_objfiles.
 839         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 840         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 841         * guile/scm-pretty-print.c
 842         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 843         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 844         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 845         (maintenance_print_msymbols): Use all_objfiles.
 846         * source.c (select_source_symtab): Use all_objfiles.
 847         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 848         * symfile.c (remove_symbol_file_command)
 849         (expand_symtabs_matching, map_symbol_filenames): Use
 850         all_objfiles.
 851         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 852         all_objfiles.
 853         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 854         * objc-lang.c (find_methods): Use all_objfiles.
 855         * objfiles.c (have_partial_symbols, have_full_symbols)
 856         (have_minimal_symbols, qsort_cmp)
 857         (default_iterate_over_objfiles_in_search_order): Use
 858         all_objfiles.
 859         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 860         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 861         (maintenance_check_psymtabs): Use all_objfiles.
 862         (ALL_PSYMTABS): Remove.
 863         * compile/compile-object-run.c (do_module_cleanup): Use
 864         all_objfiles.
 865         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 866         * cp-support.c (add_symbol_overload_list_qualified): Use
 867         all_objfiles.
 868         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 869         Use all_objfiles.
 870         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 871         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 872         all_objfiles.
 873         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 874         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 875         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 876         Uses all_objfiles.
 877         * solib.c (solib_read_symbols): Use all_objfiles
 878
 879 2019-01-09  Tom Tromey  <tom@tromey.com>
 880
 881         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 882         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 883         all_objfiles.
 884         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 885         * symmisc.c (print_symbol_bcache_statistics)
 886         (print_objfile_statistics, maintenance_print_objfiles)
 887         (maintenance_info_symtabs, maintenance_check_symtabs)
 888         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 889         all_objfiles.
 890         * source.c (forget_cached_source_info): Use all_objfiles.
 891         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 892         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 893         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 894         * objfiles.c (update_section_map): Use all_objfiles.
 895         (shared_objfile_contains_address_p): Likewise.
 896         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 897         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 898
 899 2019-01-09  Tom Tromey  <tom@tromey.com>
 900
 901         * common/next-iterator.h: New file.
 902         * objfiles.h (class all_objfiles): New.
 903         (struct objfile_iterator): New.
 904
 905 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 906
 907         * NEWS: Move the description of the changed "frame", "select-frame",
 908          and "info frame" commands to the Changed commands section.
 909
 910 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 911
 912         * gdbtypes.c (check_stub_method_group): Remove handling of old
 913         mangling schemes.
 914         * linespec.c (find_methods): Likewise.
 915         * stabsread.c (read_member_functions): Likewise.
 916         * valops.c (search_struct_method): Likewise.
 917         (value_struct_elt_for_reference): Likewise.
 918         * NEWS: Mention this change.
 919
 920 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 921
 922         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 923         print_source_lines.
 924         * source.c (print_source_lines_base): Update line number check.
 925         (print_source_lines): New function.
 926         (source_lines_range::source_lines_range): New function.
 927         * source.h (class source_lines_range): New class.
 928         (print_source_lines): New declaration.
 929
 930 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 931
 932         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 933
 934 2019-01-08  Tom Tromey  <tom@tromey.com>
 935             Simon Marchi  <simon.marchi@ericsson.com>
 936
 937         PR gdb/24060
 938         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 939         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 940         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 941         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 942         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 943         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 944
 945 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 946
 947         * source.c (select_source_symtab): Move header comment to
 948         declaration in source.h.
 949         (forget_cached_source_info_for_objfile): Likewise.
 950         (forget_cached_source_info): Likewise.
 951         (identify_source_line): Likewise.
 952         * source.h (identify_source_line): Move declaration from symtab.h
 953         and add comment from source.c
 954         (print_source_lines): Likewise.
 955         (forget_cached_source_info_for_objfile): Likewise.
 956         (forget_cached_source_info): Likewise.
 957         (select_source_symtab): Likewise.
 958         (enum print_source_lines_flag): Move definition from symtab.h.
 959         * symtab.h (identify_source_line): Move declaration to source.h.
 960         (print_source_lines): Likewise.
 961         (forget_cached_source_info_for_objfile): Likewise.
 962         (forget_cached_source_info): Likewise.
 963         (select_source_symtab): Likewise.
 964         (enum print_source_lines_flag): Move definition to source.h.
 965         * tui/tui-hooks.c: Add 'source.h' include.
 966
 967 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 968
 969         * source.c (print_source_lines_base): Handle requests to print
 970         reverse line number sequences, and guard against empty lines
 971         string.
 972
 973 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 974
 975         * source.c (print_source_lines_base): Fix skip of '\r' if next
 976         character is '\n'.
 977
 978 2019-01-06  Tom Tromey  <tom@tromey.com>
 979
 980         * c-exp.y (struct c_parse_state) <macro_original_text,
 981         expansion_obstack>: New member.
 982         (macro_original_text, expansion_obstack): Remove globals.
 983         (scan_macro_expansion, scanning_macro_expansion)
 984         (finished_macro_expansion): Update.
 985         (scan_macro_cleanup): Remove.
 986         (yylex, c_parse): Update.
 987
 988 2019-01-06  Tom Tromey  <tom@tromey.com>
 989
 990         * c-exp.y (struct c_parse_state) <strings>: New member.
 991         (operator_stoken): Update.
 992
 993 2019-01-06  Tom Tromey  <tom@tromey.com>
 994
 995         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 996         (union type_stack_elt) <typelist_val>: Now a pointer to
 997         std::vector.
 998         (type_stack_cleanup): Don't declare.
 999         (push_typelist): Update.
1000         * parse.c (pop_typelist): Return a std::vector.
1001         (push_typelist): Take a std::vector.
1002         (follow_types): Update.  Do not free args.
1003         (type_stack_cleanup): Remove.
1004         * c-exp.y (struct c_parse_state): New.
1005         (cpstate): New global.
1006         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1007         (nonempty_typelist): Update.
1008         (func_mod): Create a new vector.
1009         (c_parse): Create a c_parse_state.
1010         (check_parameter_typelist): Do not delete params.
1011         (function_method): Update.  Do not delete type_list.
1012
1013 2019-01-06  Tom Tromey  <tom@tromey.com>
1014
1015         PR gdb/28155:
1016         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1017         check_typedef.
1018         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1019         (print_return_value): Likewise.
1020
1021 2019-01-05  Tom Tromey  <tom@tromey.com>
1022
1023         * contrib/cleanup_check.py: Remove.
1024         * contrib/gcc-with-excheck: Remove.
1025         * contrib/exsummary.py: Remove.
1026         * contrib/excheck.py: Remove.
1027
1028 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1029
1030         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1031         NULL. Initialize tpprev to NULL instead of assigning it
1032         to NULL on the next statement.
1033         * windows-nat.c (windows_delete_thread): Remove check for
1034         main_thread_id before printing thread exit notifications.
1035         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1036         Remove thread ID check against main_thread_id.
1037         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1038         windows_delete_thread.
1039         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1040
1041 2019-01-04  Tom Tromey  <tom@tromey.com>
1042
1043         * compile/compile.c (_initialize_compile): Use upper case for
1044         metasyntactic variables.
1045         * symmisc.c (_initialize_symmisc): Use upper case for
1046         metasyntactic variables.
1047         * psymtab.c (_initialize_psymtab): Use upper case for
1048         metasyntactic variables.
1049         * demangle.c (demangle_command): Use upper case for metasyntactic
1050         variables.
1051         (_initialize_demangler): Likewise.
1052         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1053         variables.
1054
1055 2019-01-03  Tom Tromey  <tom@tromey.com>
1056
1057         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1058
1059 2019-01-03  Tom Tromey  <tom@tromey.com>
1060
1061         * python/py-symtab.c (salpy_str): Update.
1062         (struct salpy_sal_object) <symtab>: Now a PyObject.
1063         (salpy_dealloc): Update.
1064         (del_objfile_sal): Use gdbpy_ref.
1065
1066 2019-01-03  Tom Tromey  <tom@tromey.com>
1067
1068         * python/py-type.c (convert_field): Use new_reference.  Return
1069         gdbpy_ref.
1070         (make_fielditem): Return gdbpy_ref.
1071         (typy_fields): Update.
1072         (typy_getitem): Update.
1073         (field_name): Return gdbpy_ref.  Use new_reference.
1074         (typy_iterator_iternext): Update.
1075
1076 2019-01-03  Tom Tromey  <tom@tromey.com>
1077
1078         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1079
1080 2019-01-03  Tom Tromey  <tom@tromey.com>
1081
1082         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1083         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1084         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1085         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1086         (pspy_set_type_printers): Likewise.
1087         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1088         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1089         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1090         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1091         (objfpy_set_type_printers): Likewise.
1092
1093 2019-01-03  Tom Tromey  <tom@tromey.com>
1094
1095         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1096         (gdbpy_print_stack): Use gdbpy_err_fetch.
1097         * python/python-internal.h (class gdbpy_err_fetch): New class.
1098         (class gdbpy_enter) <m_error_type, m_error_value,
1099         m_error_traceback>: Remove.
1100         <m_error>: New member.
1101         (gdbpy_exception_to_string): Don't declare.
1102         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1103         * python/py-value.c (convert_value_from_python): Use
1104         gdbpy_err_fetch.
1105         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1106         gdbpy_exception_to_string.
1107         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1108         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1109         gdbpy_err_fetch.
1110
1111 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1112
1113         * linux-nat.c (delete_lwp_cleanup): Delete.
1114         (struct lwp_deleter): New struct.
1115         (lwp_info_up): New typedef.
1116         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1117         lwp_info_up.
1118
1119 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1120
1121         * linux-fork.c (class scoped_switch_fork_info): New class.
1122         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1123
1124 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1125
1126         * valops.c (find_overload_match): Remove use of null_cleanup, and
1127         calls to do_cleanups.
1128
1129 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1130
1131         * compile/compile-cplus-types.c
1132         (compile_cplus_instance::decl_name): Handle changes to
1133         cp_func_name.
1134         * cp-support.c (cp_func_name): Update header comment, update
1135         return type.
1136         * cp-support.h (cp_func_name): Update return type in declaration.
1137         * valops.c (find_overload_match): Move temp_func local to top
1138         level of function and change its type.  Use temp_func to hold and
1139         delete temporary string obtained from cp_func_name.
1140
1141 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1142
1143         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1144         gdb::char_vector, remove cleanup, and update uses of `msg`.
1145
1146 2019-01-03  Jim Wilson  <jimw@sifive.com>
1147
1148         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1149
1150 2019-01-02  Tom Tromey  <tom@tromey.com>
1151
1152         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1153         (tdesc_parse_xml): Remove cleanups.
1154         * target-descriptions.h (make_cleanup_free_target_description):
1155         Don't declare.
1156         (target_desc_deleter): New struct.
1157         (target_desc_up): New typedef.
1158         * target-descriptions.c (target_desc_deleter::operator()): Rename
1159         from free_target_description.
1160         (make_cleanup_free_target_description): Remove.
1161
1162 2019-01-02  Tom Tromey  <tom@tromey.com>
1163
1164         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1165         constructor, destructor.
1166         (linespec_parser): Remove typedef.
1167         (~linespec_parser): Rename from linespec_parser_delete.
1168         (linespec_lex_to_end, linespec_complete_label)
1169         (linespec_complete): Update.
1170         (decode_line_full): Remove cleanups.
1171         (decode_line_1): Update.
1172
1173 2019-01-02  Tom Tromey  <tom@tromey.com>
1174
1175         * python/python-internal.h (inferior_to_inferior_object): Change
1176         return type.
1177         * python/py-exitedevent.c (create_exited_event_object): Update.
1178         * python/py-inferior.c (inferior_to_inferior_object): Return
1179         gdbpy_ref.
1180         (python_new_inferior, python_inferior_deleted)
1181         (thread_to_thread_object, delete_thread_object)
1182         (build_inferior_list, gdbpy_selected_inferior): Update.
1183         * python/py-infthread.c (create_thread_object): Update.  Also fail
1184         if inferior_to_inferior_object fails.
1185
1186 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1187
1188         * inferior.h (class inferior) <displaced_step_state>: New field.
1189         * infrun.h (struct displaced_step_state): Move here from
1190         infrun.c.  Initialize fields, add constructor.
1191         <inf>: Remove field.
1192         <reset>: New method.
1193         * infrun.c (struct displaced_step_inferior_state): Move to
1194         infrun.h.
1195         (displaced_step_inferior_states): Remove.
1196         (get_displaced_stepping_state): Adust.
1197         (displaced_step_in_progress_any_inferior): Adjust.
1198         (displaced_step_in_progress_thread): Adjust.
1199         (displaced_step_in_progress): Adjust.
1200         (add_displaced_stepping_state): Remove.
1201         (get_displaced_step_closure_by_addr): Adjust.
1202         (remove_displaced_stepping_state): Remove.
1203         (infrun_inferior_exit): Call displaced_step_state.reset.
1204         (use_displaced_stepping): Don't check for NULL.
1205         (displaced_step_prepare_throw): Call
1206         get_displaced_stepping_state.
1207         (displaced_step_fixup): Don't check for NULL.
1208         (prepare_for_detach): Don't check for NULL.
1209
1210 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1211
1212         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1213          in case of call that did not complete.
1214
1215 2019-01-02  Andrey Utkin  <autkin@undo.io>
1216
1217         * symfile.c (find_separate_debug_file): Fix search of debug files for
1218         remote debuggee.
1219
1220 2019-01-02  Tom Tromey  <tom@tromey.com>
1221
1222         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1223         indentation.
1224         * python/py-frame.c (frapy_older): Remove cast.
1225         (frapy_newer): Likewise.
1226         * python/py-breakpoint.c (local_setattro): Remove cast.
1227         * python/py-arch.c (archpy_name): Remove local variable.
1228         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1229
1230 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1231
1232         * unittests/basic_string_view/element_access/char/empty.cc:
1233         Fix year range in copyright header.
1234
1235 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1236
1237         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1238         Delete.
1239         <operator==>: Update with for removed field.
1240         <hash>: Likewise.
1241         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1242         <isa_features>: ...this.
1243         <abi_features>: New field.
1244         (riscv_isa_flen): Update comment.
1245         (riscv_abi_xlen): New declaration.
1246         (riscv_abi_flen): New declaration.
1247         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1248         isa_features.
1249         (riscv_abi_xlen): New function.
1250         (riscv_isa_flen): Update to get answer from isa_features.
1251         (riscv_abi_flen): New function.
1252         (riscv_has_fp_abi): Update to get answer from abi_features.
1253         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1254         xlen and flen.
1255         (riscv_call_info) <xlen, flen>: Update comment.
1256         (riscv_call_arg_struct): Remove invalid assertions
1257         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1258         is removed.
1259         (riscv_gdbarch_init): Gather isa features and abi features
1260         separately, ensure both match on the gdbarch when reusing an old
1261         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1262         a target with 64-bit float hardware.
1263
1264 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1265
1266         * source.c (search_command_helper): Stop reverse search
1267         when line 1 has been searched.
1268
1269 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1270
1271         * record-full.c (record_full_base_target::close): Rewrite
1272         record_full_core_buf_list free logic.
1273
1274 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1275
1276         * break-catch-syscall.c (print_one_catch_syscall): xfree
1277         the last text.
1278
1279 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1280
1281         * top.c (print_gdb_version): Update Copyright year in version
1282         message.
1283
1284 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1285
1286         Update copyright year range in all GDB files.
1287
1288 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1289
1290         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1291
1292 For older changes see ChangeLog-2018.
1293 \f
1294 Local Variables:
1295 mode: change-log
1296 left-margin: 8
1297 fill-column: 74
1298 version-control: never
1299 coding: utf-8
1300 End:
1301