Rewrite TRY/CATCH
[external/binutils.git] / gdb / ChangeLog
1 2019-04-08  Tom Tromey  <tom@tromey.com>
2
3         * xml-support.c: Use C++ exception handling.
4         * x86-linux-nat.c: Use C++ exception handling.
5         * windows-nat.c: Use C++ exception handling.
6         * varobj.c: Use C++ exception handling.
7         * value.c: Use C++ exception handling.
8         * valprint.c: Use C++ exception handling.
9         * valops.c: Use C++ exception handling.
10         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11         handling.
12         * unittests/cli-utils-selftests.c: Use C++ exception handling.
13         * typeprint.c: Use C++ exception handling.
14         * tui/tui.c: Use C++ exception handling.
15         * tracefile-tfile.c: Use C++ exception handling.
16         * top.c: Use C++ exception handling.
17         * thread.c: Use C++ exception handling.
18         * target.c: Use C++ exception handling.
19         * symmisc.c: Use C++ exception handling.
20         * symfile-mem.c: Use C++ exception handling.
21         * stack.c: Use C++ exception handling.
22         * sparc64-linux-tdep.c: Use C++ exception handling.
23         * solib.c: Use C++ exception handling.
24         * solib-svr4.c: Use C++ exception handling.
25         * solib-spu.c: Use C++ exception handling.
26         * solib-frv.c: Use C++ exception handling.
27         * solib-dsbt.c: Use C++ exception handling.
28         * selftest-arch.c: Use C++ exception handling.
29         * s390-tdep.c: Use C++ exception handling.
30         * rust-lang.c: Use C++ exception handling.
31         * rust-exp.y: Use C++ exception handling.
32         * rs6000-tdep.c: Use C++ exception handling.
33         * rs6000-aix-tdep.c: Use C++ exception handling.
34         * riscv-tdep.c: Use C++ exception handling.
35         * remote.c: Use C++ exception handling.
36         * remote-fileio.c: Use C++ exception handling.
37         * record-full.c: Use C++ exception handling.
38         * record-btrace.c: Use C++ exception handling.
39         * python/python.c: Use C++ exception handling.
40         * python/py-value.c: Use C++ exception handling.
41         * python/py-utils.c: Use C++ exception handling.
42         * python/py-unwind.c: Use C++ exception handling.
43         * python/py-type.c: Use C++ exception handling.
44         * python/py-symbol.c: Use C++ exception handling.
45         * python/py-record.c: Use C++ exception handling.
46         * python/py-record-btrace.c: Use C++ exception handling.
47         * python/py-progspace.c: Use C++ exception handling.
48         * python/py-prettyprint.c: Use C++ exception handling.
49         * python/py-param.c: Use C++ exception handling.
50         * python/py-objfile.c: Use C++ exception handling.
51         * python/py-linetable.c: Use C++ exception handling.
52         * python/py-lazy-string.c: Use C++ exception handling.
53         * python/py-infthread.c: Use C++ exception handling.
54         * python/py-inferior.c: Use C++ exception handling.
55         * python/py-gdb-readline.c: Use C++ exception handling.
56         * python/py-framefilter.c: Use C++ exception handling.
57         * python/py-frame.c: Use C++ exception handling.
58         * python/py-finishbreakpoint.c: Use C++ exception handling.
59         * python/py-cmd.c: Use C++ exception handling.
60         * python/py-breakpoint.c: Use C++ exception handling.
61         * python/py-arch.c: Use C++ exception handling.
62         * printcmd.c: Use C++ exception handling.
63         * ppc-linux-tdep.c: Use C++ exception handling.
64         * parse.c: Use C++ exception handling.
65         * p-valprint.c: Use C++ exception handling.
66         * objc-lang.c: Use C++ exception handling.
67         * mi/mi-main.c: Use C++ exception handling.
68         * mi/mi-interp.c: Use C++ exception handling.
69         * mi/mi-cmd-stack.c: Use C++ exception handling.
70         * mi/mi-cmd-break.c: Use C++ exception handling.
71         * main.c: Use C++ exception handling.
72         * linux-thread-db.c: Use C++ exception handling.
73         * linux-tdep.c: Use C++ exception handling.
74         * linux-nat.c: Use C++ exception handling.
75         * linux-fork.c: Use C++ exception handling.
76         * linespec.c: Use C++ exception handling.
77         * language.c: Use C++ exception handling.
78         * jit.c: Use C++ exception handling.
79         * infrun.c: Use C++ exception handling.
80         * infcmd.c: Use C++ exception handling.
81         * infcall.c: Use C++ exception handling.
82         * inf-loop.c: Use C++ exception handling.
83         * i386-tdep.c: Use C++ exception handling.
84         * i386-linux-tdep.c: Use C++ exception handling.
85         * guile/scm-value.c: Use C++ exception handling.
86         * guile/scm-type.c: Use C++ exception handling.
87         * guile/scm-symtab.c: Use C++ exception handling.
88         * guile/scm-symbol.c: Use C++ exception handling.
89         * guile/scm-pretty-print.c: Use C++ exception handling.
90         * guile/scm-ports.c: Use C++ exception handling.
91         * guile/scm-param.c: Use C++ exception handling.
92         * guile/scm-math.c: Use C++ exception handling.
93         * guile/scm-lazy-string.c: Use C++ exception handling.
94         * guile/scm-frame.c: Use C++ exception handling.
95         * guile/scm-disasm.c: Use C++ exception handling.
96         * guile/scm-cmd.c: Use C++ exception handling.
97         * guile/scm-breakpoint.c: Use C++ exception handling.
98         * guile/scm-block.c: Use C++ exception handling.
99         * guile/guile-internal.h: Use C++ exception handling.
100         * gnu-v3-abi.c: Use C++ exception handling.
101         * gdbtypes.c: Use C++ exception handling.
102         * frame.c: Use C++ exception handling.
103         * frame-unwind.c: Use C++ exception handling.
104         * fbsd-tdep.c: Use C++ exception handling.
105         * f-valprint.c: Use C++ exception handling.
106         * exec.c: Use C++ exception handling.
107         * event-top.c: Use C++ exception handling.
108         * event-loop.c: Use C++ exception handling.
109         * eval.c: Use C++ exception handling.
110         * dwarf2read.c: Use C++ exception handling.
111         * dwarf2loc.c: Use C++ exception handling.
112         * dwarf2-frame.c: Use C++ exception handling.
113         * dwarf2-frame-tailcall.c: Use C++ exception handling.
114         * dwarf-index-write.c: Use C++ exception handling.
115         * dwarf-index-cache.c: Use C++ exception handling.
116         * dtrace-probe.c: Use C++ exception handling.
117         * disasm-selftests.c: Use C++ exception handling.
118         * darwin-nat.c: Use C++ exception handling.
119         * cp-valprint.c: Use C++ exception handling.
120         * cp-support.c: Use C++ exception handling.
121         * cp-abi.c: Use C++ exception handling.
122         * corelow.c: Use C++ exception handling.
123         * completer.c: Use C++ exception handling.
124         * compile/compile-object-run.c: Use C++ exception handling.
125         * compile/compile-object-load.c: Use C++ exception handling.
126         * compile/compile-cplus-symbols.c: Use C++ exception handling.
127         * compile/compile-c-symbols.c: Use C++ exception handling.
128         * common/selftest.c: Use C++ exception handling.
129         * common/new-op.c: Use C++ exception handling.
130         * cli/cli-script.c: Use C++ exception handling.
131         * cli/cli-interp.c: Use C++ exception handling.
132         * cli/cli-cmds.c: Use C++ exception handling.
133         * c-varobj.c: Use C++ exception handling.
134         * btrace.c: Use C++ exception handling.
135         * breakpoint.c: Use C++ exception handling.
136         * break-catch-throw.c: Use C++ exception handling.
137         * arch-utils.c: Use C++ exception handling.
138         * amd64-tdep.c: Use C++ exception handling.
139         * ada-valprint.c: Use C++ exception handling.
140         * ada-typeprint.c: Use C++ exception handling.
141         * ada-lang.c: Use C++ exception handling.
142         * aarch64-tdep.c: Use C++ exception handling.
143
144 2019-04-08  Tom Tromey  <tom@tromey.com>
145
146         * xml-support.c (gdb_xml_parser::parse): Update.
147         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
148         * value.c (show_convenience): Update.
149         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
150         (test_parse_flags_qcs): Update.
151         * thread.c (thr_try_catch_cmd): Update.
152         * target.c (target_translate_tls_address): Update.
153         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
154         (info_frame_command_core, frame_apply_command_count): Update.
155         * rust-exp.y (rust_lex_exception_test): Update.
156         * riscv-tdep.c (riscv_print_one_register_info): Update.
157         * remote.c (remote_target::enable_btrace): Update.
158         * record-btrace.c (record_btrace_enable_warn): Update.
159         * python/py-utils.c (gdbpy_convert_exception): Update.
160         * printcmd.c (do_one_display, print_variable_and_value): Update.
161         * mi/mi-main.c (mi_print_exception): Update.
162         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
163         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
164         * linux-nat.c (linux_nat_target::attach): Update.
165         * linux-fork.c (class scoped_switch_fork_info): Update.
166         * infrun.c (displaced_step_prepare): Update.
167         * infcall.c (call_function_by_hand_dummy): Update.
168         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
169         * gnu-v3-abi.c (print_one_vtable): Update.
170         * frame.c (get_prev_frame_always): Update.
171         * f-valprint.c (info_common_command_for_block): Update.
172         * exec.c (try_open_exec_file): Update.
173         * exceptions.c (print_exception, exception_print)
174         (exception_fprintf, exception_print_same): Update.
175         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
176         * dwarf-index-cache.c (index_cache::store)
177         (index_cache::lookup_gdb_index): Update.
178         * darwin-nat.c (maybe_cache_shell): Update.
179         * cp-valprint.c (cp_print_value_fields): Update.
180         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
181         (gcc_cplus_symbol_address): Update.
182         * compile/compile-c-symbols.c (gcc_convert_symbol)
183         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
184         * common/selftest.c: Update.
185         * common/common-exceptions.h (struct gdb_exception) <message>: Now
186         a std::string.
187         (exception_try_scope_entry, exception_try_scope_exit): Don't
188         declare.
189         (struct exception_try_scope): Remove.
190         (TRY): Don't use exception_try_scope.
191         (struct gdb_exception): Add constructor, operator=.
192         <what>: New method.
193         (struct gdb_exception_RETURN_MASK_ALL)
194         (struct gdb_exception_RETURN_MASK_ERROR)
195         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
196         (struct gdb_quit_bad_alloc): Update.
197         * common/common-exceptions.c (exception_none): Change
198         initializer.
199         (struct catcher) <state, exception>: Initialize inline.
200         <prev>: Remove member.
201         (current_catcher): Remove.
202         (catchers): New global.
203         (exceptions_state_mc_init): Simplify.
204         (catcher_pop): Remove.
205         (exceptions_state_mc, exceptions_state_mc_catch): Update.
206         (try_scope_depth, exception_try_scope_entry)
207         (exception_try_scope_exit): Remove.
208         (throw_exception_sjlj): Update.
209         (exception_messages, exception_messages_size): Remove.
210         (throw_it): Simplify.
211         (gdb_exception_sliced_copy): Remove.
212         (throw_exception_cxx): Update.
213         * cli/cli-script.c (script_from_file): Update.
214         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
215         Update.
216         * ada-valprint.c (ada_val_print): Update.
217         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
218         (create_excep_cond_exprs): Update.
219
220 2019-04-08  Tom Tromey  <tom@tromey.com>
221
222         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
223         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
224         (TRY, CATCH, END_CATCH): Remove some definitions.
225         * common/common-exceptions.c: Don't use GDB_XCPT.
226         (catcher_list_size): Remove.
227         (throw_exception, throw_it): Simplify.
228
229 2019-04-05  Tom Tromey  <tom@tromey.com>
230
231         Revert the header-sorting patch.
232         * ft32-tdep.c: Revert.
233         * frv-tdep.c: Revert.
234         * frv-linux-tdep.c: Revert.
235         * frame.c: Revert.
236         * frame-unwind.c: Revert.
237         * frame-base.c: Revert.
238         * fork-child.c: Revert.
239         * findvar.c: Revert.
240         * findcmd.c: Revert.
241         * filesystem.c: Revert.
242         * filename-seen-cache.h: Revert.
243         * filename-seen-cache.c: Revert.
244         * fbsd-tdep.c: Revert.
245         * fbsd-nat.h: Revert.
246         * fbsd-nat.c: Revert.
247         * f-valprint.c: Revert.
248         * f-typeprint.c: Revert.
249         * f-lang.c: Revert.
250         * extension.h: Revert.
251         * extension.c: Revert.
252         * extension-priv.h: Revert.
253         * expprint.c: Revert.
254         * exec.h: Revert.
255         * exec.c: Revert.
256         * exceptions.c: Revert.
257         * event-top.c: Revert.
258         * event-loop.c: Revert.
259         * eval.c: Revert.
260         * elfread.c: Revert.
261         * dwarf2read.h: Revert.
262         * dwarf2read.c: Revert.
263         * dwarf2loc.c: Revert.
264         * dwarf2expr.h: Revert.
265         * dwarf2expr.c: Revert.
266         * dwarf2-frame.c: Revert.
267         * dwarf2-frame-tailcall.c: Revert.
268         * dwarf-index-write.h: Revert.
269         * dwarf-index-write.c: Revert.
270         * dwarf-index-common.c: Revert.
271         * dwarf-index-cache.h: Revert.
272         * dwarf-index-cache.c: Revert.
273         * dummy-frame.c: Revert.
274         * dtrace-probe.c: Revert.
275         * disasm.h: Revert.
276         * disasm.c: Revert.
277         * disasm-selftests.c: Revert.
278         * dictionary.c: Revert.
279         * dicos-tdep.c: Revert.
280         * demangle.c: Revert.
281         * dcache.h: Revert.
282         * dcache.c: Revert.
283         * darwin-nat.h: Revert.
284         * darwin-nat.c: Revert.
285         * darwin-nat-info.c: Revert.
286         * d-valprint.c: Revert.
287         * d-namespace.c: Revert.
288         * d-lang.c: Revert.
289         * ctf.c: Revert.
290         * csky-tdep.c: Revert.
291         * csky-linux-tdep.c: Revert.
292         * cris-tdep.c: Revert.
293         * cris-linux-tdep.c: Revert.
294         * cp-valprint.c: Revert.
295         * cp-support.c: Revert.
296         * cp-namespace.c: Revert.
297         * cp-abi.c: Revert.
298         * corelow.c: Revert.
299         * corefile.c: Revert.
300         * continuations.c: Revert.
301         * completer.h: Revert.
302         * completer.c: Revert.
303         * complaints.c: Revert.
304         * coffread.c: Revert.
305         * coff-pe-read.c: Revert.
306         * cli-out.h: Revert.
307         * cli-out.c: Revert.
308         * charset.c: Revert.
309         * c-varobj.c: Revert.
310         * c-valprint.c: Revert.
311         * c-typeprint.c: Revert.
312         * c-lang.c: Revert.
313         * buildsym.c: Revert.
314         * buildsym-legacy.c: Revert.
315         * build-id.h: Revert.
316         * build-id.c: Revert.
317         * btrace.c: Revert.
318         * bsd-uthread.c: Revert.
319         * breakpoint.h: Revert.
320         * breakpoint.c: Revert.
321         * break-catch-throw.c: Revert.
322         * break-catch-syscall.c: Revert.
323         * break-catch-sig.c: Revert.
324         * blockframe.c: Revert.
325         * block.c: Revert.
326         * bfin-tdep.c: Revert.
327         * bfin-linux-tdep.c: Revert.
328         * bfd-target.c: Revert.
329         * bcache.c: Revert.
330         * ax-general.c: Revert.
331         * ax-gdb.h: Revert.
332         * ax-gdb.c: Revert.
333         * avr-tdep.c: Revert.
334         * auxv.c: Revert.
335         * auto-load.c: Revert.
336         * arm-wince-tdep.c: Revert.
337         * arm-tdep.c: Revert.
338         * arm-symbian-tdep.c: Revert.
339         * arm-pikeos-tdep.c: Revert.
340         * arm-obsd-tdep.c: Revert.
341         * arm-nbsd-tdep.c: Revert.
342         * arm-nbsd-nat.c: Revert.
343         * arm-linux-tdep.c: Revert.
344         * arm-linux-nat.c: Revert.
345         * arm-fbsd-tdep.c: Revert.
346         * arm-fbsd-nat.c: Revert.
347         * arm-bsd-tdep.c: Revert.
348         * arch-utils.c: Revert.
349         * arc-tdep.c: Revert.
350         * arc-newlib-tdep.c: Revert.
351         * annotate.h: Revert.
352         * annotate.c: Revert.
353         * amd64-windows-tdep.c: Revert.
354         * amd64-windows-nat.c: Revert.
355         * amd64-tdep.c: Revert.
356         * amd64-sol2-tdep.c: Revert.
357         * amd64-obsd-tdep.c: Revert.
358         * amd64-obsd-nat.c: Revert.
359         * amd64-nbsd-tdep.c: Revert.
360         * amd64-nbsd-nat.c: Revert.
361         * amd64-nat.c: Revert.
362         * amd64-linux-tdep.c: Revert.
363         * amd64-linux-nat.c: Revert.
364         * amd64-fbsd-tdep.c: Revert.
365         * amd64-fbsd-nat.c: Revert.
366         * amd64-dicos-tdep.c: Revert.
367         * amd64-darwin-tdep.c: Revert.
368         * amd64-bsd-nat.c: Revert.
369         * alpha-tdep.c: Revert.
370         * alpha-obsd-tdep.c: Revert.
371         * alpha-nbsd-tdep.c: Revert.
372         * alpha-mdebug-tdep.c: Revert.
373         * alpha-linux-tdep.c: Revert.
374         * alpha-linux-nat.c: Revert.
375         * alpha-bsd-tdep.c: Revert.
376         * alpha-bsd-nat.c: Revert.
377         * aix-thread.c: Revert.
378         * agent.c: Revert.
379         * addrmap.c: Revert.
380         * ada-varobj.c: Revert.
381         * ada-valprint.c: Revert.
382         * ada-typeprint.c: Revert.
383         * ada-tasks.c: Revert.
384         * ada-lang.c: Revert.
385         * aarch64-tdep.c: Revert.
386         * aarch64-ravenscar-thread.c: Revert.
387         * aarch64-newlib-tdep.c: Revert.
388         * aarch64-linux-tdep.c: Revert.
389         * aarch64-linux-nat.c: Revert.
390         * aarch64-fbsd-tdep.c: Revert.
391         * aarch64-fbsd-nat.c: Revert.
392         * aarch32-linux-nat.c: Revert.
393
394 2019-04-05  Tom Tromey  <tom@tromey.com>
395
396         * ft32-tdep.c: Sort headers.
397         * frv-tdep.c: Sort headers.
398         * frv-linux-tdep.c: Sort headers.
399         * frame.c: Sort headers.
400         * frame-unwind.c: Sort headers.
401         * frame-base.c: Sort headers.
402         * fork-child.c: Sort headers.
403         * findvar.c: Sort headers.
404         * findcmd.c: Sort headers.
405         * filesystem.c: Sort headers.
406         * filename-seen-cache.h: Sort headers.
407         * filename-seen-cache.c: Sort headers.
408         * fbsd-tdep.c: Sort headers.
409         * fbsd-nat.h: Sort headers.
410         * fbsd-nat.c: Sort headers.
411         * f-valprint.c: Sort headers.
412         * f-typeprint.c: Sort headers.
413         * f-lang.c: Sort headers.
414         * extension.h: Sort headers.
415         * extension.c: Sort headers.
416         * extension-priv.h: Sort headers.
417         * expprint.c: Sort headers.
418         * exec.h: Sort headers.
419         * exec.c: Sort headers.
420         * exceptions.c: Sort headers.
421         * event-top.c: Sort headers.
422         * event-loop.c: Sort headers.
423         * eval.c: Sort headers.
424         * elfread.c: Sort headers.
425         * dwarf2read.h: Sort headers.
426         * dwarf2read.c: Sort headers.
427         * dwarf2loc.c: Sort headers.
428         * dwarf2expr.h: Sort headers.
429         * dwarf2expr.c: Sort headers.
430         * dwarf2-frame.c: Sort headers.
431         * dwarf2-frame-tailcall.c: Sort headers.
432         * dwarf-index-write.h: Sort headers.
433         * dwarf-index-write.c: Sort headers.
434         * dwarf-index-common.c: Sort headers.
435         * dwarf-index-cache.h: Sort headers.
436         * dwarf-index-cache.c: Sort headers.
437         * dummy-frame.c: Sort headers.
438         * dtrace-probe.c: Sort headers.
439         * disasm.h: Sort headers.
440         * disasm.c: Sort headers.
441         * disasm-selftests.c: Sort headers.
442         * dictionary.c: Sort headers.
443         * dicos-tdep.c: Sort headers.
444         * demangle.c: Sort headers.
445         * dcache.h: Sort headers.
446         * dcache.c: Sort headers.
447         * darwin-nat.h: Sort headers.
448         * darwin-nat.c: Sort headers.
449         * darwin-nat-info.c: Sort headers.
450         * d-valprint.c: Sort headers.
451         * d-namespace.c: Sort headers.
452         * d-lang.c: Sort headers.
453         * ctf.c: Sort headers.
454         * csky-tdep.c: Sort headers.
455         * csky-linux-tdep.c: Sort headers.
456         * cris-tdep.c: Sort headers.
457         * cris-linux-tdep.c: Sort headers.
458         * cp-valprint.c: Sort headers.
459         * cp-support.c: Sort headers.
460         * cp-namespace.c: Sort headers.
461         * cp-abi.c: Sort headers.
462         * corelow.c: Sort headers.
463         * corefile.c: Sort headers.
464         * continuations.c: Sort headers.
465         * completer.h: Sort headers.
466         * completer.c: Sort headers.
467         * complaints.c: Sort headers.
468         * coffread.c: Sort headers.
469         * coff-pe-read.c: Sort headers.
470         * cli-out.h: Sort headers.
471         * cli-out.c: Sort headers.
472         * charset.c: Sort headers.
473         * c-varobj.c: Sort headers.
474         * c-valprint.c: Sort headers.
475         * c-typeprint.c: Sort headers.
476         * c-lang.c: Sort headers.
477         * buildsym.c: Sort headers.
478         * buildsym-legacy.c: Sort headers.
479         * build-id.h: Sort headers.
480         * build-id.c: Sort headers.
481         * btrace.c: Sort headers.
482         * bsd-uthread.c: Sort headers.
483         * breakpoint.h: Sort headers.
484         * breakpoint.c: Sort headers.
485         * break-catch-throw.c: Sort headers.
486         * break-catch-syscall.c: Sort headers.
487         * break-catch-sig.c: Sort headers.
488         * blockframe.c: Sort headers.
489         * block.c: Sort headers.
490         * bfin-tdep.c: Sort headers.
491         * bfin-linux-tdep.c: Sort headers.
492         * bfd-target.c: Sort headers.
493         * bcache.c: Sort headers.
494         * ax-general.c: Sort headers.
495         * ax-gdb.h: Sort headers.
496         * ax-gdb.c: Sort headers.
497         * avr-tdep.c: Sort headers.
498         * auxv.c: Sort headers.
499         * auto-load.c: Sort headers.
500         * arm-wince-tdep.c: Sort headers.
501         * arm-tdep.c: Sort headers.
502         * arm-symbian-tdep.c: Sort headers.
503         * arm-pikeos-tdep.c: Sort headers.
504         * arm-obsd-tdep.c: Sort headers.
505         * arm-nbsd-tdep.c: Sort headers.
506         * arm-nbsd-nat.c: Sort headers.
507         * arm-linux-tdep.c: Sort headers.
508         * arm-linux-nat.c: Sort headers.
509         * arm-fbsd-tdep.c: Sort headers.
510         * arm-fbsd-nat.c: Sort headers.
511         * arm-bsd-tdep.c: Sort headers.
512         * arch-utils.c: Sort headers.
513         * arc-tdep.c: Sort headers.
514         * arc-newlib-tdep.c: Sort headers.
515         * annotate.h: Sort headers.
516         * annotate.c: Sort headers.
517         * amd64-windows-tdep.c: Sort headers.
518         * amd64-windows-nat.c: Sort headers.
519         * amd64-tdep.c: Sort headers.
520         * amd64-sol2-tdep.c: Sort headers.
521         * amd64-obsd-tdep.c: Sort headers.
522         * amd64-obsd-nat.c: Sort headers.
523         * amd64-nbsd-tdep.c: Sort headers.
524         * amd64-nbsd-nat.c: Sort headers.
525         * amd64-nat.c: Sort headers.
526         * amd64-linux-tdep.c: Sort headers.
527         * amd64-linux-nat.c: Sort headers.
528         * amd64-fbsd-tdep.c: Sort headers.
529         * amd64-fbsd-nat.c: Sort headers.
530         * amd64-dicos-tdep.c: Sort headers.
531         * amd64-darwin-tdep.c: Sort headers.
532         * amd64-bsd-nat.c: Sort headers.
533         * alpha-tdep.c: Sort headers.
534         * alpha-obsd-tdep.c: Sort headers.
535         * alpha-nbsd-tdep.c: Sort headers.
536         * alpha-mdebug-tdep.c: Sort headers.
537         * alpha-linux-tdep.c: Sort headers.
538         * alpha-linux-nat.c: Sort headers.
539         * alpha-bsd-tdep.c: Sort headers.
540         * alpha-bsd-nat.c: Sort headers.
541         * aix-thread.c: Sort headers.
542         * agent.c: Sort headers.
543         * addrmap.c: Sort headers.
544         * ada-varobj.c: Sort headers.
545         * ada-valprint.c: Sort headers.
546         * ada-typeprint.c: Sort headers.
547         * ada-tasks.c: Sort headers.
548         * ada-lang.c: Sort headers.
549         * aarch64-tdep.c: Sort headers.
550         * aarch64-ravenscar-thread.c: Sort headers.
551         * aarch64-newlib-tdep.c: Sort headers.
552         * aarch64-linux-tdep.c: Sort headers.
553         * aarch64-linux-nat.c: Sort headers.
554         * aarch64-fbsd-tdep.c: Sort headers.
555         * aarch64-fbsd-nat.c: Sort headers.
556         * aarch32-linux-nat.c: Sort headers.
557
558 2019-04-04  Tom Tromey  <tom@tromey.com>
559
560         * varobj.c (varobj_create): Update.
561         * rust-exp.y (struct rust_parser) <update_innermost_block,
562         lookup_symbol>: New methods.
563         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
564         Rename.
565         (rust_parser::rust_lookup_type)
566         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
567         * printcmd.c (display_command, do_one_display): Update.
568         * parser-defs.h (struct parser_state) <parser_state>: Add
569         "tracker" parameter.
570         (block_tracker): New member.
571         (class innermost_block_tracker) <innermost_block_tracker>: Add
572         "types" parameter.
573         <reset>: Remove method.
574         (innermost_block): Don't declare.
575         (null_post_parser): Update.
576         * parse.c (innermost_block): Remove global.
577         (write_dollar_variable): Update.
578         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
579         Remove "tracker_types" parameter.
580         (parse_expression): Add "tracker" parameter.
581         (parse_expression_for_completion): Update.
582         (null_post_parser): Add "tracker" parameter.
583         * p-exp.y: Update rules.
584         * m2-exp.y: Update rules.
585         * language.h (struct language_defn) <la_post_parser>: Add
586         "tracker" parameter.
587         * go-exp.y: Update rules.
588         * f-exp.y: Update rules.
589         * expression.h (parse_expression, parse_exp_1): Add "tracker"
590         parameter.
591         * d-exp.y: Update rules.
592         * c-exp.y: Update rules.
593         * breakpoint.c (set_breakpoint_condition): Create an
594         innermost_block_tracker.
595         (watch_command_1): Likewise.
596         * ada-lang.c (resolve): Add "tracker" parameter.
597         (resolve_subexp): Likewise.
598         * ada-exp.y (write_var_from_sym): Update.
599
600 2019-04-04  Tom Tromey  <tom@tromey.com>
601
602         * type-stack.h: New file.
603         * type-stack.c: New file.
604         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
605         type-stack.h.
606         (insert_into_type_stack, insert_type, push_type, push_type_int)
607         (insert_type_address_space, pop_type, pop_type_int)
608         (pop_typelist, pop_type_stack, append_type_stack)
609         (push_type_stack, get_type_stack, push_typelist)
610         (follow_type_instance_flags, follow_types): Don't declare.
611         * parse.c (type_stack): Remove global.
612         (parse_exp_in_context): Update.
613         (insert_into_type_stack, insert_type, push_type, push_type_int)
614         (insert_type_address_space, pop_type, pop_type_int)
615         (pop_typelist, pop_type_stack, append_type_stack)
616         (push_type_stack, get_type_stack, push_typelist)
617         (follow_type_instance_flags, follow_types): Remove (moved to
618         type-stack.c).
619         * f-exp.y (type_stack): New global.
620         Update rules.
621         (push_kind_type, f_parse): Update.
622         * d-exp.y (type_stack): New global.
623         Update rules.
624         (d_parse): Update.
625         * c-exp.y (struct c_parse_state) <type_stack>: New member.
626         Update rules.
627         * Makefile.in (COMMON_SFILES): Add type-stack.c.
628         (HFILES_NO_SRCDIR): Add type-stack.h.
629
630 2019-04-04  Tom Tromey  <tom@tromey.com>
631
632         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
633         (rust_parser::convert_ast_to_expression, rust_parse)
634         (rust_lex_test_completion, rust_lex_tests): Update.
635         * parser-defs.h (struct expr_completion_state): New.
636         (struct parser_state) <parser_state>: Add completion parameter.
637         <mark_struct_expression, mark_completion_tag>: New methods.
638         <parse_completion, m_completion_state>: New members.
639         (prefixify_expression, null_post_parser): Update.
640         (mark_struct_expression, mark_completion_tag): Don't declare.
641         * parse.c (parse_completion, expout_last_struct)
642         (expout_tag_completion_type, expout_completion_name): Remove
643         globals.
644         (parser_state::mark_struct_expression)
645         (parser_state::mark_completion_tag): Now methods.
646         (prefixify_expression): Add last_struct parameter.
647         (prefixify_subexp): Likewise.
648         (parse_exp_1): Update.
649         (parse_exp_in_context): Add cstate parameter.  Update.
650         (parse_expression_for_completion): Create an
651         expr_completion_state.
652         (null_post_parser): Add "completion" parameter.
653         * p-exp.y: Update rules.
654         (yylex): Update.
655         * language.h (struct language_defn) <la_post_parser>: Add
656         "completing" parameter.
657         * go-exp.y: Update rules.
658         (lex_one_token): Update.
659         * expression.h (parse_completion): Don't declare.
660         * d-exp.y: Update rules.
661         (lex_one_token): Update rules.
662         * c-exp.y: Update rules.
663         (lex_one_token): Update.
664         * ada-lang.c (resolve): Add "parse_completion" parameter.
665         (resolve_subexp): Likewise.
666         (ada_resolve_function): Likewise.
667
668 2019-04-04  Tom Tromey  <tom@tromey.com>
669
670         * parser-defs.h (struct parser_state) <start_arglist,
671         end_arglist>: New methods.
672         <arglist_len, m_funcall_chain>: New members.
673         (arglist_len, start_arglist, end_arglist): Don't declare.
674         * parse.c (arglist_len, funcall_chain): Remove global.
675         (start_arglist, end_arglist): Remove functions.
676         (parse_exp_in_context): Update.
677         * p-exp.y: Update rules.
678         * m2-exp.y: Update rules.
679         * go-exp.y: Update rules.
680         * f-exp.y: Update rules.
681         * d-exp.y: Update rules.
682         * c-exp.y: Update rules.
683
684 2019-04-04  Tom Tromey  <tom@tromey.com>
685
686         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
687         lex_operator, push_back>: New methods.
688         Update all rules.
689         (rust_parser::lex_hex, lex_escape): Rename and update.
690         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
691         (rust_parser::lex_operator): Rename and update.
692         (rust_parser::lex_number, rustyylex, rustyyerror)
693         (rust_lex_test_init, rust_lex_test_sequence)
694         (rust_lex_test_push_back, rust_lex_tests): Update.
695         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
696         parameter.
697         <lexptr, prev_lexptr>: New members.
698         (lexptr, prev_lexptr): Don't declare.
699         * parse.c (lexptr, prev_lexptr): Remove globals.
700         (parse_exp_in_context): Update.
701         * p-exp.y (yylex, yyerror): Update.
702         * m2-exp.y (parse_number, yylex, yyerror): Update.
703         * go-exp.y (lex_one_token, yyerror): Update.
704         * f-exp.y (match_string_literal, yylex, yyerror): Update.
705         * d-exp.y (lex_one_token, yyerror): Update.
706         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
707         (lex_one_token, yyerror): Update.
708         * ada-lex.l (YY_INPUT): Update.
709         (rewind_to_char): Update.
710         * ada-exp.y (yyerror): Update.
711
712 2019-04-04  Tom Tromey  <tom@tromey.com>
713
714         * rust-exp.y (rustyylex, rust_lex_tests): Update.
715         * parser-defs.h (struct parser_state) <parser_state>: Add new
716         parameter.
717         <comma_terminates>: New member.
718         (comma_terminates): Don't declare global.
719         * parse.c (comma_terminates): Remove global.
720         (parse_exp_in_context): Update.
721         * p-exp.y (yylex): Update.
722         * m2-exp.y (yylex): Update.
723         * go-exp.y (lex_one_token): Update.
724         * f-exp.y (yylex): Update.
725         * d-exp.y (lex_one_token): Update.
726         * c-exp.y (lex_one_token): Update.
727         * ada-lex.l: Update.
728
729 2019-04-04  Tom Tromey  <tom@tromey.com>
730
731         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
732         (rustyylex, rust_lex_test_init, rust_lex_test_one)
733         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
734         * parser-defs.h (paren_depth): Don't declare.
735         * parse.c (paren_depth): Remove global.
736         (parse_exp_in_context): Update.
737         * p-exp.y (paren_depth): New global.
738         (pascal_parse): Initialize it.
739         * m2-exp.y (paren_depth): New global.
740         (m2_parse): Initialize it.
741         * go-exp.y (paren_depth): New global.
742         (go_parse): Initialize it.
743         * f-exp.y (paren_depth): New global.
744         (f_parse): Initialize it.
745         * d-exp.y (paren_depth): New global.
746         (d_parse): Initialize it.
747         * c-exp.y (paren_depth): New global.
748         (c_parse): Initialize it.
749         * ada-lex.l (paren_depth): New global.
750         (lexer_init): Initialize it.
751
752 2019-04-04  Tom Tromey  <tom@tromey.com>
753
754         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
755         (rust_parser::convert_ast_to_type)
756         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
757         * parser-defs.h (struct parser_state) <parser_state>: Add
758         parameters.  Initialize new members.
759         <expression_context_block, expression_context_pc>: New members.
760         * parse.c (expression_context_block, expression_context_pc):
761         Remove globals.
762         (parse_exp_in_context): Update.
763         * p-exp.y: Update all rules.
764         (yylex): Update.
765         * m2-exp.y: Update all rules.
766         (yylex): Update.
767         * go-exp.y (yylex): Update.
768         * f-exp.y (yylex): Update.
769         * d-exp.y: Update all rules.
770         (yylex): Update.
771         * c-exp.y: Update all rules.
772         (lex_one_token, classify_name, yylex, c_parse): Update.
773         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
774
775 2019-04-04  Tom Tromey  <tom@tromey.com>
776
777         * gdbarch.h, gdbarch.c: Rebuild.
778         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
779         * stap-probe.h: 
780         (struct stap_parse_info): Replace "parser_state" with
781         "expr_builder".
782         * parser-defs.h (struct expr_builder): Rename from "parser_state".
783         (parser_state): New class.
784         * parse.c (expr_builder): Rename.
785         (expr_builder::release): Rename.
786         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
787         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
788         (write_exp_elt_longcst, write_exp_elt_floatcst)
789         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
790         (write_exp_string_vector, write_exp_bitstring)
791         (write_exp_msymbol, mark_struct_expression)
792         (write_dollar_variable)
793         (insert_type_address_space, increase_expout_size): Replace
794         "parser_state" with "expr_builder".
795         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
796         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
797         "parser_state" with "expr_builder".
798
799 2019-04-04  Tom Tromey  <tom@tromey.com>
800
801         * rust-exp.y: Replace "parse_language" with method call.
802         * p-exp.y: 
803         (yylex): Replace "parse_language" with method call.
804         * m2-exp.y: 
805         (yylex): Replace "parse_language" with method call.
806         * go-exp.y (classify_name): Replace "parse_language" with method
807         call.
808         * f-exp.y (yylex): Replace "parse_language" with method call.
809         * d-exp.y (lex_one_token): Replace "parse_language" with method
810         call.
811         * c-exp.y: 
812         (lex_one_token, classify_name, yylex): Replace "parse_language"
813         with method call.
814         * ada-exp.y (find_primitive_type, type_char)
815         (type_system_address): Replace "parse_language" with method call.
816
817 2019-04-04  Tom Tromey  <tom@tromey.com>
818
819         * rust-exp.y: Replace "parse_gdbarch" with method call.
820         * parse.c (write_dollar_variable, insert_type_address_space):
821         Replace "parse_gdbarch" with method call.
822         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
823         call.
824         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
825         call.
826         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
827         "parse_gdbarch" with method call.
828         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
829         with method call.
830         * f-exp.y (parse_type, parse_f_type, yylex): Replace
831         "parse_gdbarch" with method call.
832         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
833         "parse_gdbarch" with method call.
834         * c-exp.y (parse_type, parse_number, classify_name): Replace
835         "parse_gdbarch" with method call.
836         * ada-lex.l: Replace "parse_gdbarch" with method call.
837         * ada-exp.y (parse_type, find_primitive_type, type_char)
838         (type_system_address): Replace "parse_gdbarch" with method call.
839
840 2019-04-04  Tom Tromey  <tom@tromey.com>
841
842         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
843         * stap-probe.c (stap_parse_argument): Update.
844         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
845         initial_size parameter.
846         * rust-exp.y (rust_lex_tests): Update.
847         * parse.c (parser_state): Update.
848         (parse_exp_in_context): Update.
849         * parser-defs.h (struct parser_state) <parser_state>: Remove
850         "initial_size" parameter.
851
852 2019-04-04  Tom Tromey  <tom@tromey.com>
853
854         * parser-defs.h (increase_expout_size): Don't declare.
855         * parse.c (increase_expout_size): Now static.
856
857 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
858
859         * gnu-nat.c (gnu_nat_target::wait): Fix
860         target_waitstatus_to_string call.
861
862 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
863
864         * eval.c (evaluate_subexp_standard): Handle internal functions
865         during Fortran function call handling.
866
867 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
868
869         * NEWS: Mention new internal functions.
870         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
871         (read_base_type): Use dwarf2_init_complex_target_type.
872         * value.c (creal_internal_fn): New function.
873         (cimag_internal_fn): New function.
874         (_initialize_values): Register new internal functions.
875
876 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
877
878         * infrun.c (stop_all_threads): If debug_infrun, always
879         trace the wait status after wait_one, using
880         target_waitstatus_to_string and target_pid_to_str.
881         (handle_inferior_event): Replace various trace of
882         wait status kind by a single trace.
883         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
884         wait status kind image by target_waitstatus_to_string.
885         * target/waitstatus.c (target_waitstatus_to_string): Fix
886         obsolete comment.
887
888 2019-04-01  Tom Tromey  <tromey@adacore.com>
889
890         PR symtab/23331:
891         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
892
893 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
894             Pedro Alves  <palves@redhat.com>
895
896         * top.c (quit_force): Call 'finalize_values'.
897         * value.c (finalize_values): New function.
898         * value.h (finalize_values): Declare.
899
900 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
901
902         * NEWS: Announce $_gdb_major and $_gdb_minor.
903
904         * top.c (init_gdb_version_vars): New function.
905         (gdb_init): Call init_gdb_version_vars.
906
907 2019-03-29  Tom Tromey  <tromey@adacore.com>
908
909         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
910         help text.  Remove dead code.
911
912 2019-03-29  Keith Seitz  <keiths@redhat.com>
913
914         From Siddhesh Poyarekar:
915         * f-lang.h (f77_get_upperbound): Return LONGEST.
916         (f77_get_lowerbound): Likewise.
917         * f-typeprint.c (f_type_print_varspec_suffix): Expand
918         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
919         print them.
920         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
921         plongest to format print it.
922         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
923         (f77_get_upperbound): Likewise.
924         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
925         LOWER_BOUND to LONGEST.
926         (f77_create_arrayprint_offset_tbl): Likewise.
927
928 2019-03-29  Keith Seitz  <keiths@redhat.com>
929
930         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
931         %s/pulongest for TYPE_LENGTH instead of %d in format
932         strings.
933         * ada-typerint.c (ada_print_type): Likewise.
934         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
935         * compile/compile-c-support.c (generate_register_struct): Likewise.
936         * gdbtypes.c (recursive_dump_type): Likewise.
937         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
938         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
939         instead of %d in format strings.
940         * riscv-tdep.c (riscv_type_alignment): Cast second argument
941         to std::min to ULONGEST.
942         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
943         instead of %d in format strings.
944         * tracepoint.c (info_scope_command): Likewise.
945         * typeprint.c (print_offset_data::update)
946         (print_offset_data::finish): Likewise.
947         * xtensa-tdep.c (xtensa_store_return_value)
948         (xtensa_push_dummy_call): Likewise.
949
950 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
951
952         * windows-nat.c (display_selector): Fixed format specifications
953         for 64-bit Cygwin.
954
955 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
956
957         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
958
959 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
960
961         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
962         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
963         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
964         (nios2_linux_init_abi): Install it.
965
966 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
967
968         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
969
970 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
971
972         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
973
974 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
975             Tom Tromey  <tromey@adacore.com>
976
977         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
978
979 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
980
981         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
982         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
983         method to compute the bounds of range types. Also print "[evaluated]"
984         if the bounds' values come from a dynamic evaluation.
985
986 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
987
988         * cp-valprint.c (cp_print_value_fields): Don't print trailing
989         whitespace when pretty printing is on.
990
991 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
992
993         * ppc-linux-nat.c: Add include.
994
995 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
996
997         * NEWS: Mention AArch64 Pointer Authentication.
998
999 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1000
1001         * arm-linux-nat.c: Add include.
1002
1003 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1004
1005         * source-cache.c (source_cache::get_source_lines): Re-read
1006         fullname after calling open_source_file.
1007
1008 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1009
1010         * NEWS: Mention TLS support for FreeBSD.
1011
1012 2019-03-25  Tom Tromey  <tromey@adacore.com>
1013
1014         * minsyms.c (BUNCH_SIZE): Update comment.
1015         (~minimal_symbol_reader): Remove old comment.
1016         (compact_minimal_symbols): Update comment.
1017         (minimal_symbol_reader::install): Remove old comment.  Update
1018         other comments.
1019
1020 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1021
1022         * s390-linux-nat.c: Add include.
1023
1024 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1025
1026         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1027         Call linux_get_hwcap.
1028         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1029         Likewise.
1030         (aarch64_linux_get_hwcap): Remove function.
1031         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1032         declaration.
1033         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1034         linux_get_hwcap.
1035         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1036         * linux-tdep.c (linux_get_hwcap): Add function.
1037         (linux_get_hwcap2): Likewise.
1038         * linux-tdep.h (linux_get_hwcap): Add declaration.
1039         (linux_get_hwcap2): Likewise.
1040         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1041         (ppc_linux_get_hwcap2): Likewise.
1042         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1043         linux_get_hwcap.
1044         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1045         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1046         (ppc_linux_nat_target::read_description): Likewise.
1047         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1048         * s390-linux-nat.c: Likewise.
1049         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1050
1051 2019-03-24  Tom Tromey  <tom@tromey.com>
1052
1053         * ada-lang.c (standard_lookup): Simplify initialization.
1054         (ada_lookup_symbol_nonlocal): Simplify return.
1055         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1056         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1057         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1058         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1059         initialization.
1060         * solib.c (solib_global_lookup): Simplify.
1061         * symtab.c (null_block_symbol): Remove.
1062         (symbol_cache_lookup): Simplify returns.
1063         (lookup_language_this): Simplify returns.
1064         (lookup_symbol_aux): Simplify return.
1065         (lookup_local_symbol): Simplify returns.
1066         (lookup_global_symbol_from_objfile): Simplify return.
1067         (lookup_symbol_in_objfile_symtabs)
1068         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1069         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1070         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1071         * cp-namespace.c (cp_lookup_bare_symbol)
1072         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1073         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1074         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1075         (cp_lookup_symbol_via_imports): Simplify initialization.
1076         (find_symbol_in_baseclass): Likewise.
1077         * symtab.h (null_block_symbol): Remove.
1078         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1079         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1080         (d_lookup_symbol_module): Likewise.
1081         (find_symbol_in_baseclass): Simplify initialization.
1082
1083 2019-03-24  Tom Tromey  <tom@tromey.com>
1084
1085         * expression.h: Don't include symtab.h.
1086         (struct block): Forward declare.
1087
1088 2019-03-24  Tom Tromey  <tom@tromey.com>
1089
1090         * c-exp.y (typebase): Remove casts.
1091         * gdbtypes.c (lookup_unsigned_typename, )
1092         (lookup_signed_typename): Remove cast.
1093         * eval.c (parse_to_comma_and_eval): Remove cast.
1094         * parse.c (write_dollar_variable): Remove cast.
1095         * block.h (struct block) <superblock>: Now const.
1096         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1097         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1098         (map_block): Make "block" const.
1099         * symfile.h (struct quick_symbol_functions)
1100         <map_matching_symbols>: Constify block argument to "callback".
1101         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1102         const.
1103         (find_pc_sect_compunit_symtab): Make "b" const.
1104         (find_symbol_at_address): Likewise.
1105         (search_symbols): Likewise.
1106         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1107         (dw2_debug_names_lookup_symbol): Likewise.
1108         (dw2_map_matching_symbols): Update.
1109         * p-valprint.c (pascal_val_print): Remove "block".
1110         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1111         (aux_add_nonlocal_symbols): Make "block" const.
1112         (resolve_subexp): Remove cast.
1113         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1114         const.
1115         (iterate_over_file_blocks): Likewise.
1116         * f-exp.y (%union) <bval>: Remove.
1117         * coffread.c (patch_opaque_types): Make "b" const.
1118         * spu-tdep.c (spu_catch_start): Make "block" const.
1119         * c-valprint.c (print_unpacked_pointer): Remove "block".
1120         * symmisc.c (dump_symtab_1): Make "b" const.
1121         (block_depth): Make "block" const.
1122         * d-exp.y (%union) <bval>: Remove.
1123         * cp-support.h (cp_lookup_rtti_type): Update.
1124         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1125         * psymtab.c (psym_lookup_symbol): Make "block" const.
1126         (maintenance_check_psymtabs): Make "b" const.
1127         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1128         (enumerate_locals, enumerate_args): Update.
1129         * python/py-symtab.c (stpy_global_block): Make "block" const.
1130         (stpy_static_block): Likewise.
1131         * inline-frame.c (block_starting_point_at): Make "new_block"
1132         const.
1133         * block.c (find_block_in_blockvector): Make return type const.
1134         (blockvector_for_pc_sect): Make "b" const.
1135         (find_block_in_blockvector): Make "b" const.
1136
1137 2019-03-23  Tom Tromey  <tom@tromey.com>
1138
1139         * varobj.c (varobj_create): Update.
1140         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1141         * printcmd.c (display_command, do_one_display): Don't reset
1142         innermost_block.
1143         * parser-defs.h (enum innermost_block_tracker_type): Move to
1144         expression.h.
1145         (innermost_block): Update comment.
1146         * parse.c (parse_exp_1): Add tracker_types parameter.
1147         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1148         tracker_types parameter.  Reset innermost_block.
1149         (parse_exp_in_context): Remove.
1150         (parse_expression_for_completion): Update.
1151         * objfiles.c (~objfile): Don't reset expression_context_block or
1152         innermost_block.
1153         * expression.h (enum innermost_block_tracker_type): Move from
1154         parser-defs.h.
1155         (parse_exp_1): Add tracker_types parameter.
1156         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1157         reset innermost_block.
1158
1159 2019-03-23  Tom Tromey  <tom@tromey.com>
1160
1161         * objfiles.h: Include bcache.h.
1162
1163 2019-03-23  Tom Tromey  <tom@tromey.com>
1164
1165         * linespec.c (get_current_search_block): Use
1166         scoped_restore_current_language.
1167         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1168
1169 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1170             Jiong Wang  <jiong.wang@arm.com>
1171
1172         * aarch64-linux-tdep.c
1173         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1174         section.
1175         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1176
1177 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1178             Jiong Wang  <jiong.wang@arm.com>
1179
1180         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1181         instructions.
1182         (aarch64_analyze_prologue_test): Add PACIASP test.
1183         (aarch64_prologue_prev_register): Unmask PC value.
1184
1185 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1186             Jiong Wang  <jiong.wang@arm.com>
1187
1188         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1189         (aarch64_dwarf2_prev_register): Unmask PC value.
1190         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1191         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1192         DW_CFA_AARCH64_negate_ra_state.
1193         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1194
1195 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1196             Jiong Wang  <jiong.wang@arm.com>
1197
1198         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1199         registers.
1200         (aarch64_pseudo_register_name): Likewise.
1201         (aarch64_pseudo_register_type): Likewise.
1202         (aarch64_pseudo_register_reggroup_p): Likewise.
1203         (aarch64_gdbarch_init): Add pauth registers.
1204         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1205         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1206         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1207         (struct gdbarch_tdep): Add regnum for ra_state.
1208
1209 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1210             Jiong Wang  <jiong.wang@arm.com>
1211
1212         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1213
1214 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1215             Jiong Wang  <jiong.wang@arm.com>
1216
1217         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1218         function.
1219         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1220         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1221         (aarch64_gdbarch_init): Add puth registers.
1222         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1223         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1224         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1225
1226 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1227             Jiong Wang  <jiong.wang@arm.com>
1228
1229         * aarch64-linux-nat.c
1230         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1231         * aarch64-linux-tdep.c
1232         (aarch64_linux_core_read_description): Likewise.
1233         (aarch64_linux_get_hwcap): New function.
1234         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1235         (aarch64_linux_get_hwcap): New declaration.
1236
1237 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1238             Jiong Wang  <jiong.wang@arm.com>
1239
1240         * aarch64-linux-nat.c
1241         (aarch64_linux_nat_target::read_description): Add pauth param.
1242         * aarch64-linux-tdep.c
1243         (aarch64_linux_core_read_description): Likewise.
1244         * aarch64-tdep.c (struct target_desc): Add in pauth.
1245         (aarch64_read_description): Add pauth param.
1246         (aarch64_gdbarch_init): Likewise.
1247         * aarch64-tdep.h (aarch64_read_description): Likewise.
1248         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1249         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1250         * features/Makefile: Add new files.
1251         * features/aarch64-pauth.c: New file.
1252         * features/aarch64-pauth.xml: New file.
1253
1254 2019-03-20  Tom Tromey  <tromey@adacore.com>
1255
1256         * infrun.c (handle_inferior_event): Rename from
1257         handle_inferior_event_1.  Create a scoped_value_mark.
1258         (handle_inferior_event): Remove.
1259
1260 2019-03-19  Tom Tromey  <tromey@adacore.com>
1261
1262         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1263         * infrun.h (print_stop_event): Add "displays" parameter.
1264         * infrun.c (print_stop_event): Add "displays" parameter.
1265
1266 2019-03-19  Pedro Alves  <palves@redhat.com>
1267
1268         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1269         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1270         to -1.  Fix TABs vs spaces.
1271         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1272         * tui/tui-out.h (tui_ui_out) Add intro comments.
1273         <m_line, m_start_of_line>: In-class initialize, and add describing
1274         comment.
1275
1276 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1277
1278         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1279         variable names.
1280         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1281
1282 2019-03-18  Pedro Alves  <palves@redhat.com>
1283             Eli Zaretskii <eliz@gnu.org>
1284
1285         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1286         m_line and m_start_of_line.
1287
1288 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1289
1290         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1291         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1292         it returns a newline.  This fixes a regression in TU mode, whereby
1293         the next line is output on the same screen line as the user input.
1294
1295 2019-03-18  Tom Tromey  <tromey@adacore.com>
1296
1297         * minsyms.c (minimal_symbol_reader::install): Remove call to
1298         obstack_blank.
1299
1300 2019-03-18  Pedro Alves  <palves@redhat.com>
1301
1302         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1303         New globals.
1304         (apply_style): New, factored out from ...
1305         (apply_ansi_escape): ... this.  Handle reverse video mode.
1306         (tui_set_reverse_mode): New function.
1307         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1308         * tui/tui-winsource.c (tui_show_source_line): Use
1309         tui_set_reverse_mode instead of setting A_STANDOUT.
1310         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1311         New setter methods.
1312
1313 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1314
1315         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1316         Handle tabs.
1317
1318 2019-03-18  Tom Tromey  <tromey@adacore.com>
1319
1320         * ada-lang.c (empty_array): Add "high" parameter.
1321         (ada_evaluate_subexp): Update.
1322
1323 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1324
1325         * unittests/string_view-selftests.c: Define
1326         _initialize_string_view_selftests unconditionally.
1327
1328 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1329
1330         PR gdb/24350
1331         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1332
1333 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1334
1335         PR gdb/24351
1336         * windows-nat.c (display_selector): Fix format specifiers.
1337
1338 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1339
1340         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1341         tui_refill_source_window instead of tui_refresh_win, to update the
1342         current execution line.  This fixes redisplay of the current line
1343         when stepping through the code with "next" or "step".
1344
1345 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1346
1347         * source-cache.c (source_cache::get_source_lines): Call
1348         find_source_lines to initialize s->nlines.  This fixes vertical
1349         scrolling of TUI source window when the DOWN arrow is pressed.
1350
1351 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1352
1353         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1354         linux-thread-db.c (_initialize_thread_db): Likewise.
1355
1356 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1357
1358         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1359         wclrtoeol in tui_show_source_line".  This reverts changes made in
1360         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1361
1362 2019-03-15  Tom Tromey  <tom@tromey.com>
1363
1364         * symtab.h (struct minimal_symbol): Derive from
1365         general_symbol_info.
1366         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1367         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1368         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1369         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1370         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1371         (MSYMBOL_SEARCH_NAME): Update.
1372         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1373         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1374         * minsyms.c (minimal_symbol_reader::record_full): Update.
1375
1376 2019-03-15  Tom Tromey  <tom@tromey.com>
1377
1378         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1379
1380 2019-03-15  Tom Tromey  <tom@tromey.com>
1381
1382         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1383         unique_xmalloc_ptr.
1384         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1385         Update.
1386         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1387         (build_minimal_symbol_hash_tables)
1388         (minimal_symbol_reader::install): Update.
1389
1390 2019-03-15  Tom Tromey  <tom@tromey.com>
1391
1392         * symtab.c (create_demangled_names_hash): Update.
1393         (symbol_set_names): Update.
1394         * objfiles.h (struct objfile_per_bfd_storage)
1395         <demangled_names_hash>: Now an htab_up.
1396         * objfiles.c (objfile_per_bfd_storage): Simplify.
1397
1398 2019-03-15  Tom Tromey  <tom@tromey.com>
1399
1400         * objfiles.h (struct objfile_per_bfd_storage): Declare
1401         destructor.
1402         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1403         New.
1404         (get_objfile_bfd_data): Use new.  Don't initialize
1405         language_of_main.
1406         (free_objfile_per_bfd_storage): Remove.
1407         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1408
1409 2019-03-15  Tom Tromey  <tom@tromey.com>
1410
1411         * symfile.c (reread_symbols): Update.
1412         * objfiles.c (objfile::objfile): Update.
1413         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1414         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1415         comment.
1416         (minimal_symbol_reader::install): Update.
1417         (terminate_minimal_symbol_table): Remove.
1418         * jit.c (jit_object_close_impl): Update.
1419
1420 2019-03-15  Tom Tromey  <tom@tromey.com>
1421
1422         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1423         initializations.
1424
1425 2019-03-15  Tom Tromey  <tom@tromey.com>
1426
1427         * objfiles.h (struct objfile_per_bfd_storage)
1428         <demangled_hash_languages>: Now a bitset.
1429         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1430         (lookup_minimal_symbol): Update.
1431
1432 2019-03-15  Tom Tromey  <tom@tromey.com>
1433
1434         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1435         Don't return the symbol.
1436         * coffread.c (record_minimal_symbol): Use record_full.
1437
1438 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1439
1440         The MS-Windows port of ncurses fails to switch to a color pair if
1441         one or both of the colors are the implicit default colors.  This
1442         change records the default colors when TUI is initialized, and
1443         then specifies them explicitly when a color pair uses the default
1444         colors.  This allows color styling in TUI mode on MS-Windows.
1445
1446         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1447         ncurses_norm_attr.
1448         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1449         colors in ncurses_norm_attr.
1450         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1451         "none", replace it with the default color recorded in
1452         ncurses_norm_attr.
1453
1454 2019-03-14  Tom Tromey  <tromey@adacore.com>
1455
1456         * source-cache.h (class source_cache) <get_source_lines>: Return
1457         std::string.
1458         * source-cache.c (source_cache::extract_lines): Handle case where
1459         first_pos==npos.  Return std::string.
1460         (source_cache::get_source_lines): Update.
1461
1462 2019-03-14  Tom Tromey  <tromey@adacore.com>
1463
1464         * NEWS: Add item for "style sources" commands.
1465         * source-cache.c (source_cache::get_source_lines): Check
1466         source_styling.
1467         * cli/cli-style.c (source_styling): New global.
1468         (_initialize_cli_style): Add "style sources" commands.
1469         (show_style_sources): New function.
1470         * cli/cli-style.h (source_styling): Declare.
1471
1472 2019-03-14  Pedro Alves  <palves@redhat.com>
1473             Tom Tromey  <tromey@adacore.com>
1474
1475         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1476         * tui/tui-winsource.c (tui_refill_source_window): New function,
1477         from...
1478         (tui_horizontal_source_scroll): ... here.  Move some logic.
1479         * cli/cli-style.c (set_style_enabled): Notify new observable.
1480         * tui/tui-hooks.c (tui_redisplay_source): New function.
1481         (tui_attach_detach_observers): Attach or detach
1482         tui_redisplay_source.
1483         * observable.h (source_styling_changed): New observable.
1484         * observable.c: Define source_styling_changed observable.
1485
1486 2019-03-13  Tom Tromey  <tromey@adacore.com>
1487
1488         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1489         (i386_gnu_nat_target::store_registers): Update.
1490         * target-debug.h (target_debug_print_std_string): New macro.
1491         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1492         * windows-tdep.c (display_one_tib): Update.
1493         * tui/tui-stack.c (tui_make_status_line): Update.
1494         * top.c (print_inferior_quit_action): Update.
1495         * thread.c (thr_try_catch_cmd): Update.
1496         (add_thread_with_info): Update.
1497         (thread_target_id_str): Update.
1498         (thr_try_catch_cmd): Update.
1499         (thread_command): Update.
1500         (thread_find_command): Update.
1501         * record-btrace.c (record_btrace_target::info_record)
1502         (record_btrace_resume_thread, record_btrace_target::resume)
1503         (record_btrace_cancel_resume, record_btrace_step_thread)
1504         (record_btrace_target::wait, record_btrace_target::wait)
1505         (record_btrace_target::wait, record_btrace_target::stop): Update.
1506         * progspace.c (print_program_space): Update.
1507         * process-stratum-target.c
1508         (process_stratum_target::thread_address_space): Update.
1509         * linux-fork.c (linux_fork_mourn_inferior)
1510         (detach_checkpoint_command, info_checkpoints_command)
1511         (linux_fork_context): Update.
1512         (linux_fork_detach): Update.
1513         (class scoped_switch_fork_info): Update.
1514         (delete_checkpoint_command): Update.
1515         * infrun.c (follow_fork_inferior): Update.
1516         (follow_fork_inferior): Update.
1517         (proceed_after_vfork_done): Update.
1518         (handle_vfork_child_exec_or_exit): Update.
1519         (follow_exec): Update.
1520         (displaced_step_prepare_throw): Update.
1521         (displaced_step_restore): Update.
1522         (start_step_over): Update.
1523         (resume_1): Update.
1524         (clear_proceed_status_thread): Update.
1525         (proceed): Update.
1526         (print_target_wait_results): Update.
1527         (do_target_wait): Update.
1528         (context_switch): Update.
1529         (stop_all_threads): Update.
1530         (restart_threads): Update.
1531         (finish_step_over): Update.
1532         (handle_signal_stop): Update.
1533         (switch_back_to_stepped_thread): Update.
1534         (keep_going_pass_signal): Update.
1535         (print_exited_reason): Update.
1536         (normal_stop): Update.
1537         * inferior.c (inferior_pid_to_str): Change return type.
1538         (print_selected_inferior): Update.
1539         (add_inferior): Update.
1540         (detach_inferior): Update.
1541         * dummy-frame.c (fprint_dummy_frames): Update.
1542         * dcache.c (dcache_info_1): Update.
1543         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
1544         (btrace_fetch, btrace_clear): Update.
1545         * linux-tdep.c (linux_core_pid_to_str): Change return type.
1546         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
1547         type.
1548         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
1549         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
1550         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
1551         * gdbarch.c, gdbarch.h: Rebuild.
1552         * gdbarch.sh (core_pid_to_str): Change return type.
1553         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
1554         return type.
1555         (windows_nat_target::pid_to_str): Change return type.
1556         (windows_delete_thread): Update.
1557         (windows_nat_target::attach): Update.
1558         (windows_nat_target::files_info): Update.
1559         * target-delegates.c: Rebuild.
1560         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
1561         return type.
1562         (sol_thread_target::pid_to_str): Change return type.
1563         * remote.c (class remote_target) <pid_to_str>: Change return
1564         type.
1565         (remote_target::pid_to_str): Change return type.
1566         (extended_remote_target::attach, remote_target::remote_stop_ns)
1567         (remote_target::remote_notif_remove_queued_reply)
1568         (remote_target::push_stop_reply, remote_target::disable_btrace):
1569         Update.
1570         (extended_remote_target::attach): Update.
1571         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
1572         type.
1573         (gdbsim_target::pid_to_str): Change return type.
1574         * ravenscar-thread.c (struct ravenscar_thread_target)
1575         <pid_to_str>: Change return type.
1576         (ravenscar_thread_target::pid_to_str): Change return type.
1577         * procfs.c (class procfs_target) <pid_to_str>: Change return
1578         type.
1579         (procfs_target::pid_to_str): Change return type.
1580         (procfs_target::attach): Update.
1581         (procfs_target::detach): Update.
1582         (procfs_target::fetch_registers): Update.
1583         (procfs_target::store_registers): Update.
1584         (procfs_target::wait): Update.
1585         (procfs_target::files_info): Update.
1586         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
1587         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
1588         return type.
1589         (nto_procfs_target::pid_to_str): Change return type.
1590         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
1591         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
1592         return type.
1593         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
1594         (exit_lwp): Update.
1595         (attach_proc_task_lwp_callback, get_detach_signal)
1596         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
1597         (linux_nat_target::resume, wait_lwp, stop_callback)
1598         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
1599         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
1600         (linux_nat_wait_1, resume_stopped_resumed_lwps)
1601         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
1602         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
1603         type.
1604         (inf_ptrace_target::attach): Update.
1605         (inf_ptrace_target::files_info): Update.
1606         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
1607         type.
1608         (go32_nat_target::pid_to_str): Change return type.
1609         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
1610         (gnu_nat_target::wait): Update.
1611         (gnu_nat_target::wait): Update.
1612         (gnu_nat_target::resume): Update.
1613         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
1614         (fbsd_nat_target::wait): Update.
1615         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
1616         type.
1617         (darwin_nat_target::attach): Update.
1618         * corelow.c (class core_target) <pid_to_str>: Change return type.
1619         (core_target::pid_to_str): Change return type.
1620         * target.c (normal_pid_to_str): Change return type.
1621         (default_pid_to_str): Likewise.
1622         (target_pid_to_str): Change return type.
1623         (target_translate_tls_address): Update.
1624         (target_announce_detach): Update.
1625         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
1626         return type.
1627         (bsd_uthread_target::pid_to_str): Change return type.
1628         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
1629         type.
1630         (bsd_kvm_target::pid_to_str): Change return type.
1631         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
1632         return type.
1633         (aix_thread_target::pid_to_str): Change return type.
1634         * target.h (struct target_ops) <pid_to_str>: Change return type.
1635         (target_pid_to_str, normal_pid_to_str): Likewise.
1636         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
1637         type.
1638         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
1639         type.
1640         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
1641         return type.
1642         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
1643         type.
1644         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
1645         type.
1646         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
1647         return type.
1648
1649 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
1650
1651         * NEWS: Mention that the new default MI version is 3.  Mention
1652         changes to the output of commands and events that deal with
1653         multi-location breakpoints.
1654         * breakpoint.c: Include "mi/mi-out.h".
1655         (print_one_breakpoint): Change output syntax if using MI version
1656         >= 3.
1657         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
1658         New.
1659         (mi_multi_location_breakpoint_output_fixed): New.
1660         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
1661         (mi_cmd_fix_multi_location_breakpoint_output): New.
1662         (mi_multi_location_breakpoint_output_fixed): New.
1663         * mi/mi-cmds.c (mi_cmds): Register command
1664         -fix-multi-location-breakpoint-output.
1665         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
1666         interpreter "mi".
1667
1668 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
1669
1670         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
1671         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
1672         instantiate mi_ui_out based on interpreter name.
1673         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
1674         * mi/mi-main.c (mi_load_progress): Likewise.
1675
1676 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1677
1678         * NEWS: Combine separate "New targets" sections for 8.3.
1679
1680 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1681
1682         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
1683         (ppcfbsd_init_abi): Install gdbarch
1684         "fetch_tls_load_module_address" and "get_thread_local_address"
1685         methods.
1686
1687 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1688
1689         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
1690         (riscv_fbsd_init_abi): Install gdbarch
1691         "fetch_tls_load_module_address" and "get_thread_local_address"
1692         methods.
1693
1694 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1695
1696         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
1697         (i386fbsd_init_abi): Install gdbarch
1698         "fetch_tls_load_module_address" and "get_thread_local_address"
1699         methods.
1700
1701 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1702
1703         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
1704         (amd64fbsd_init_abi): Install gdbarch
1705         "fetch_tls_load_module_address" and "get_thread_local_address"
1706         methods.
1707
1708 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1709
1710         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
1711         (struct fbsd_pspace_data): New type.
1712         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
1713         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
1714         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
1715         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
1716         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
1717
1718 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1719
1720         * gdbtypes.c (lookup_struct_elt): New function.
1721         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
1722         * gdbtypes.h (struct struct_elt): New type.
1723         (lookup_struct_elt): New prototype.
1724
1725 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1726
1727         * gdbtypes.c (lookup_struct_elt_type): Update comment and
1728         remove disabled code block.
1729
1730 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1731
1732         * gdbarch.sh (get_thread_local_address): New method.
1733         * gdbarch.h, gdbarch.c: Regenerate.
1734         * target.c (target_translate_tls_address): Use
1735         gdbarch_get_thread_local_address if present instead of
1736         target::get_thread_local_address.
1737
1738 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1739
1740         * target.h (target::get_thread_local_address): Update comment.
1741
1742 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1743
1744         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
1745         objfile->separate_debug_objfile_backlink if not NULL.
1746
1747 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1748
1749         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
1750         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
1751         (amd64bsd_store_inferior_registers): Likewise.
1752         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1753         Enable segment base registers.
1754         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
1755         PT_GETFSBASE and PT_GETGSBASE.
1756         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
1757         PT_SETGSBASE.
1758         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
1759         segment base registers.
1760         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1761
1762 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1763
1764         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1765         Update calls to i386_target_description to add 'segments'
1766         parameter.
1767         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
1768         add segment base registers.
1769         * arch/i386.c (i386_create_target_description): Add 'segments'
1770         parameter to enable segment base registers.
1771         * arch/i386.h (i386_create_target_description): Likewise.
1772         * features/i386/32bit-segments.xml: New file.
1773         * features/i386/32bit-segments.c: Generate.
1774         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
1775         call to i386_target_description to add 'segments' parameter.
1776         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1777         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
1778         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
1779         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
1780         if feature is present.
1781         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
1782         Add 'segments' parameter to call to i386_target_description.
1783         (i386_target_description): Add 'segments' parameter to enable
1784         segment base registers.
1785         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
1786         to call to i386_target_description.
1787         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
1788         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
1789         Define I386_NUM_REGS.
1790         (i386_target_description): Add 'segments' parameter to enable
1791         segment base registers.
1792
1793 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
1794
1795         PR/24325
1796         * source-cache.c: #undef open and close, to avoid unresolved
1797         externals during linking.
1798
1799 2019-03-12  Tom Tromey  <tromey@adacore.com>
1800
1801         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
1802         const.  Add initializers.
1803         (_initialize_remote): Don't initialize ptid globals.
1804
1805 2019-03-12  Pedro Alves  <palves@redhat.com>
1806
1807         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
1808
1809 2019-03-12  Pedro Alves  <palves@redhat.com>
1810
1811         * cp-name-parser.y (main): Remove unused 'len' variable.
1812
1813 2019-03-12  Tom Tromey  <tromey@adacore.com>
1814
1815         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
1816         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
1817
1818 2019-03-12  Tom Tromey  <tromey@adacore.com>
1819
1820         * linux-nat.c (iterate_over_lwps): Update.
1821         (stop_callback): Remove parameter.
1822         (stop_wait_callback, detach_callback, resume_set_callback)
1823         (select_singlestep_lwp_callback, set_ignore_sigint)
1824         (status_callback, resumed_callback, resume_clear_callback)
1825         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
1826         data parameter.
1827         (linux_nat_target::detach, linux_nat_target::resume)
1828         (linux_stop_and_wait_all_lwps, select_event_lwp)
1829         (linux_nat_filter_event, linux_nat_wait_1)
1830         (linux_nat_target::kill, linux_nat_target::stop)
1831         (linux_nat_target::stop): Update.
1832         (linux_nat_resume_callback): Change type.
1833         (resume_stopped_resumed_lwps, count_events_callback)
1834         (select_event_lwp_callback): Likewise.
1835         (linux_stop_lwp, linux_nat_stop_lwp): Update.
1836         * arm-linux-nat.c (struct update_registers_data): Remove.
1837         (update_registers_callback): Change type.
1838         (arm_linux_insert_hw_breakpoint1): Update.
1839         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
1840         parameter.
1841         (x86_linux_dr_set_addr): Update.
1842         (x86_linux_dr_set_control): Update.
1843         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
1844         (iterate_over_lwps): Use gdb::function_view.
1845         * nat/aarch64-linux-hw-point.c (struct
1846         aarch64_dr_update_callback_param): Remove.
1847         (debug_reg_change_callback): Change type.
1848         (aarch64_notify_debug_reg_change): Update.
1849         * s390-linux-nat.c (s390_refresh_per_info): Update.
1850
1851 2019-03-11  Tom Tromey  <tromey@adacore.com>
1852
1853         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
1854         redundant assignment to "this_cu".
1855
1856 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1857
1858         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
1859
1860 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1861
1862         * gdbtypes.c (rank_one_type_parm_set): New function extracted
1863         from...
1864         (rank_one_type): ... this.
1865
1866 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1867
1868         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
1869         from...
1870         (rank_one_type): ... this.
1871
1872 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1873
1874         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
1875         from...
1876         (rank_one_type): ... this.
1877
1878 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1879
1880         * gdbtypes.c (rank_one_type_parm_float): New function extracted
1881         from...
1882         (rank_one_type): ... this.
1883
1884 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1885
1886         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
1887         from...
1888         (rank_one_type): ... this.
1889
1890 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1891
1892         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1893         from...
1894         (rank_one_type): ... this.
1895
1896 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1897
1898         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1899         from...
1900         (rank_one_type): ... this.
1901
1902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1903
1904         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1905         from...
1906         (rank_one_type): ... this.
1907
1908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1909
1910         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1911         from...
1912         (rank_one_type): ... this.
1913
1914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1915
1916         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1917         from...
1918         (rank_one_type): ... this.
1919
1920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1921
1922         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1923         from...
1924         (rank_one_type): ... this.
1925
1926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1927
1928         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1929         from...
1930         (rank_one_type): ... this.
1931
1932 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1933
1934         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1935         inferior-events' shows the example events.
1936
1937 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1938
1939         Support styling on native MS-Windows console
1940
1941         PR/24315
1942         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1943         on MS-Windows if $TERM is not defined.
1944
1945         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1946
1947         * posix-hdep.c (gdb_console_fputs):
1948         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1949         functions.
1950         * ui-file.h (gdb_console_fputs): Add prototype.
1951
1952         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1953         back to fputs only if the former returns zero.
1954
1955 2019-03-07  Tom Tromey  <tom@tromey.com>
1956
1957         * symmisc.c (print_symbol_bcache_statistics): Update.
1958         (print_objfile_statistics): Update.
1959         * symfile.c (allocate_symtab): Update.
1960         * stabsread.c: Don't include bcache.h.
1961         * psymtab.h (struct psymbol_bcache): Don't declare.
1962         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1963         (psymbol_bcache_init, psymbol_bcache_free)
1964         (psymbol_bcache_get_bcache): Don't declare.
1965         * psymtab.c (struct psymbol_bcache): Remove.
1966         (psymtab_storage::psymtab_storage): Update.
1967         (psymtab_storage::~psymtab_storage): Update.
1968         (psymbol_bcache_init, psymbol_bcache_free)
1969         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1970         (add_psymbol_to_bcache): Update.
1971         (allocate_psymtab): Update.
1972         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1973         macro_cache>: No longer pointers.
1974         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1975         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1976         * macrotab.c (macro_bcache): Update.
1977         * macroexp.c: Don't include bcache.h.
1978         * gdbtypes.c (check_types_worklist): Update.
1979         (types_deeply_equal): Remove TRY/CATCH.  Update.
1980         * elfread.c (elf_symtab_read): Update.
1981         * dwarf2read.c: Don't include bcache.h.
1982         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1983         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1984         (print_bcache_statistics, bcache_memory_used): Don't declare.
1985         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1986         methods.  Rename all data members.
1987         * bcache.c (struct bcache): Move to bcache.h.
1988         (bcache::expand_hash_table): Rename from expand_hash_table.
1989         (bcache): Remove.
1990         (bcache::insert): Rename from bcache_full.
1991         (bcache::compare): Rename from bcache_compare.
1992         (bcache_xmalloc): Remove.
1993         (bcache::~bcache): Rename from bcache_xfree.
1994         (bcache::print_statistics): Rename from print_bcache_statistics.
1995         (bcache::memory_used): Rename from bcache_memory_used.
1996
1997 2019-03-07  Pedro Alves  <palves@redhat.com>
1998
1999         * infrun.c (normal_stop): Also check for
2000         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2001
2002 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2003
2004         * f-lang.c (value_from_host_double): Moved to...
2005         * value.c (value_from_host_double): ...here.
2006         * value.h (value_from_host_double): Declare.
2007         * guile/scm-math.c (vlscm_convert_typed_number): Use
2008         value_from_host_double.
2009         (vlscm_convert_number): Likewise.
2010         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2011         * python/py-value.c (convert_value_from_python): Likewise.
2012
2013 2019-03-06  Tom Tromey  <tom@tromey.com>
2014
2015         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2016
2017 2019-03-06  Tom Tromey  <tom@tromey.com>
2018
2019         * utils.h (free_current_contents): Don't declare.
2020         * utils.c (free_current_contents): Remove.
2021
2022 2019-03-06  Tom Tromey  <tom@tromey.com>
2023
2024         * top.c (quit_force): Update.
2025         * main.c (captured_command_loop): Update.
2026         * common/new-op.c (operator new): Update.
2027         * common/common-exceptions.c (struct catcher)
2028         <save_cleanup_chain>: Remove member.
2029         (exceptions_state_mc_init): Update.
2030         (exception_try_scope_entry): Return nullptr.
2031         (exception_try_scope_exit, exception_rethrow)
2032         (throw_exception_sjlj, throw_exception_cxx): Update.
2033         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2034         (all_cleanups, do_cleanups, discard_cleanups)
2035         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2036         (restore_cleanups, restore_final_cleanups): Don't declare.
2037         (do_final_cleanups): Remove parameter.
2038         * common/cleanups.c (cleanup_chain, make_cleanup)
2039         (make_cleanup_dtor, all_cleanups, do_cleanups)
2040         (discard_my_cleanups, discard_cleanups)
2041         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2042         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2043         (null_cleanup): Remove.
2044         (do_final_cleanups): Remove parameter.
2045
2046 2019-03-06  Tom Tromey  <tom@tromey.com>
2047
2048         * remote.c (remote_target::remote_parse_stop_reply): Use
2049         unique_xmalloc_ptr.
2050
2051 2019-03-06  Tom Tromey  <tom@tromey.com>
2052
2053         * stabsread.c (struct stabs_field_info): Rename from field_info.
2054         <list, fnlist>: Add initializers.
2055         <obstack>: New member.
2056         (read_member_functions, read_struct_fields, read_baseclasses):
2057         Allocate on obstack.  Don't use cleanups.
2058         (read_one_struct_field, read_member_functions, read_struct_fields)
2059         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2060         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2061         (read_struct_type): Update.
2062
2063 2019-03-06  Tom Tromey  <tom@tromey.com>
2064
2065         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2066         * common/filestuff.h (make_cleanup_close): Don't declare.
2067         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2068         Remove.
2069
2070 2019-03-06  Tom Tromey  <tom@tromey.com>
2071
2072         * solib-aix.c: Use make_scope_exit.
2073
2074 2019-03-06  Tom Tromey  <tom@tromey.com>
2075
2076         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2077         Use make_scope_exit.
2078
2079 2019-03-06  Tom Tromey  <tom@tromey.com>
2080
2081         * solib-svr4.c (disable_probes_interface): Remove parameter.
2082         (svr4_handle_solib_event): Use make_scope_exit.
2083
2084 2019-03-06  Tom Tromey  <tom@tromey.com>
2085
2086         * remote.c (struct stop_reply_deleter): Remove.
2087         (stop_reply_up): Update.
2088         (struct stop_reply): Derive from notif_event.  Don't typedef.
2089         <regcache>: Now a std::vector.
2090         (stop_reply_xfree): Remove.
2091         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2092         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2093         (remote_target::discard_pending_stop_replies): Use delete.
2094         (remote_target::remote_parse_stop_reply): Update.
2095         (remote_target::process_stop_reply): Update.
2096         * remote-notif.h (struct notif_event): Add virtual destructor.
2097         Remove "dtr" member.
2098         (struct notif_client) <alloc_event>: Return a unique_ptr.
2099         (notif_event_xfree): Don't declare.
2100         (notif_event_up): New typedef.
2101         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2102         (notif_event_xfree, do_notif_event_xfree): Remove.
2103         (remote_notif_state_xfree): Update.
2104
2105 2019-03-06  Tom Tromey  <tom@tromey.com>
2106
2107         * infrun.c (displaced_step_clear_cleanup): Now a
2108         forward_scope_exit type.
2109         (displaced_step_prepare_throw): Update.
2110         (displaced_step_fixup): Update.
2111
2112 2019-03-06  Tom Tromey  <tom@tromey.com>
2113
2114         * inferior.h (class inferior): Update comment.
2115         * gdbthread.h (class thread_info): Update comment.
2116
2117 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2118             Tom Tromey  <tom@tromey.com>
2119
2120         * stabsread.h (struct stab_section_list): Remove.
2121         (coffstab_build_psymtabs): Update.
2122         * dbxread.c (symbuf_sections): Now a std::vector.
2123         (sect_idx): New global.
2124         (fill_symbuf): Update.
2125         (coffstab_build_psymtabs): Change type of stabsects parameter.
2126         Update.
2127         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2128         std::vector.
2129         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2130         (coff_locate_sections): Update.
2131         (coff_symfile_read): Remove cleanups.  Update.
2132         (init_stringtab): Add storage parameter.
2133         (free_stringtab, free_stringtab_cleanup): Remove.
2134         (init_lineno): Add storage parameter.
2135         (free_linetab, free_linetab_cleanup): Remove.
2136
2137 2019-03-06  Pedro Alves  <palves@redhat.com>
2138
2139         * linux-fork.c (fork_info::clobber_regs): Delete.
2140         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2141         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2142         comment.  Adjust.
2143         (scoped_switch_fork_info::scoped_switch_fork_info)
2144         (checkpoint_command, linux_fork_context): Adjust
2145         fork_save_infrun_state calls.
2146
2147 2019-03-06  Pedro Alves  <palves@redhat.com>
2148
2149         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2150         (inf_has_multiple_threads): Return 'bool' and rewrite using
2151         inferior_info::threads().
2152
2153 2019-03-06  Pedro Alves  <palves@redhat.com>
2154
2155         * linux-fork.c: Include <list>.
2156         (fork_list): Now a std::list instance.
2157         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2158         (forks_exist_p, find_last_fork): Adjust.
2159         (new_fork): Delete.
2160         (one_fork_p): New.
2161         (add_fork): Adjust.
2162         (free_fork): Delete, folded into fork_info::~fork_info().
2163         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2164         Adjust.
2165         (init_fork_list): Delete.
2166         (linux_fork_killall, linux_fork_mourn_inferior)
2167         (linux_fork_detach, info_checkpoints_command): Adjust.
2168         (_initialize_linux_fork): No longer call init_fork_list.
2169
2170 2019-03-06  Pedro Alves  <palves@redhat.com>
2171
2172         * linux-fork.c (new_fork): New, split out of ...
2173         (add_fork): ... this.  Return void.  Move "first fork" special
2174         case from here, to ...
2175         (checkpoint_command): ... here.
2176         * linux-linux.h (add_fork): Return void.
2177
2178 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2179
2180         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2181
2182 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2183             Chris January  <chris.january@arm.com>
2184             David Lecomber  <david.lecomber@arm.com>
2185
2186         * f-exp.y: New token, UNOP_INTRINSIC.
2187         (exp): New pattern using UNOP_INTRINSIC token.
2188         (f77_keywords): Add 'abs' keyword.
2189         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2190         (value_from_host_double): New function.
2191         (evaluate_subexp_f): Support UNOP_ABS.
2192
2193 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2194
2195         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2196         types.
2197
2198 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2199
2200         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2201         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2202         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2203
2204 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2205
2206         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2207
2208 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2209             Chris January  <chris.january@arm.com>
2210
2211         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2212         * f-exp.y: Define 'KIND' token.
2213         (exp): New pattern for KIND expressions.
2214         (ptype): Handle types with a kind extension.
2215         (direct_abs_decl): Extend to spot kind extensions.
2216         (f77_keywords): Add 'kind' to the list.
2217         (push_kind_type): New function.
2218         (convert_to_kind_type): New function.
2219         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2220         * parse.c (operator_length_standard): Likewise.
2221         * parser-defs.h (enum type_pieces): Add tp_kind.
2222         * std-operator.def: Add UNOP_KIND.
2223
2224 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2225
2226         * f-exp.y (f_parse): Set yydebug.
2227
2228 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2229
2230         * f-lang.c (evaluate_subexp_f): New function.
2231         (exp_descriptor_f): New global.
2232         (f_language_defn): Use exp_descriptor_f instead of
2233         exp_descriptor_standard.
2234
2235 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2236
2237         * f-exp.y (struct token): Add comments.
2238         (dot_ops): Remove uppercase versions and the end marker.
2239         (f77_keywords): Likewise.
2240         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2241         entries in the dot_ops array are case insensitive, and use
2242         strncasecmp to compare strings.  Also some whitespace cleanup in
2243         this area.  Similar for the f77_keywords array, except entries in
2244         this list might be case sensitive.
2245
2246 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2247
2248         * f-exp.y (struct f77_boolean_val): Add comments.
2249         (boolean_values): Remove uppercase versions, and end marker.
2250         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2251         and use strncasecmp to achieve case insensitivity.  Additionally,
2252         perform whitespace cleanup around this code.
2253
2254 2019-03-06  Tom Tromey  <tromey@adacore.com>
2255
2256         * remote-sim.c (gdbsim_target_open): Use result of
2257         gdb_argv::release.
2258
2259 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2260         Dirk Schubert  <dirk.schubert@arm.com>
2261         Chris January  <chris.january@arm.com>
2262
2263         * eval.c (evaluate_subexp_standard): Call Fortran argument
2264         wrapping logic.
2265         * f-lang.c (struct value): A value which can be passed into a
2266         Fortran function call.
2267         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2268         where appropriate.
2269         (struct type): Value ready for a Fortran function call.
2270         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2271         is needed.
2272         * f-lang.h (fortran_argument_convert): Declaration.
2273         (fortran_preserve_arg_pointer): Declaration.
2274         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2275
2276 2019-03-05  Tom Tromey  <tromey@adacore.com>
2277
2278         * python/py-prettyprint.c (print_string_repr): Remove #if.
2279         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2280
2281 2019-03-05  Tom Tromey  <tromey@adacore.com>
2282
2283         * target.c (the_dummy_target): Move later.  Change type to
2284         "dummy_target".
2285         (initialize_targets): Don't initialize the_dummy_target.
2286
2287 2019-03-05  Tom Tromey  <tromey@adacore.com>
2288
2289         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2290         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2291
2292 2019-03-05  Tom Tromey  <tromey@adacore.com>
2293
2294         * windows-nat.c (windows_nat_target::attach)
2295         (windows_nat_target::detach): Don't call gdb_flush.
2296         * valprint.c (generic_val_print, val_print, val_print_string):
2297         Don't call gdb_flush.
2298         * utils.c (defaulted_query): Don't call gdb_flush.
2299         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2300         * target.c (target_announce_detach): Don't call gdb_flush.
2301         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2302         * remote.c (extended_remote_target::attach): Don't call
2303         gdb_flush.
2304         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2305         * printcmd.c (do_examine): Don't call gdb_flush.
2306         (info_display_command): Don't call gdb_flush.
2307         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2308         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2309         * memattr.c (info_mem_command): Don't call gdb_flush.
2310         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2311         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2312         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2313         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2314         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2315         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2316         (gnu_nat_target::detach): Don't call gdb_flush.
2317         * f-valprint.c (f_val_print): Don't call gdb_flush.
2318         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2319         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2320         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2321         gdb_flush.
2322         * c-valprint.c (c_val_print): Don't call gdb_flush.
2323         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2324
2325 2019-03-05  Tom Tromey  <tromey@adacore.com>
2326
2327         * varobj.c (update_dynamic_varobj_children): Update.
2328         (install_default_visualizer): Use reset, not release.
2329         * value.c (set_internalvar): Update.
2330         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2331         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2332         ATTRIBUTE_UNUSED_RESULT.
2333
2334 2019-03-05  Tom Tromey  <tromey@adacore.com>
2335
2336         * remote.c (class scoped_remote_fd) <release>: Add
2337         ATTRIBUTE_UNUSED_RESULT.
2338
2339 2019-03-05  Tom Tromey  <tromey@adacore.com>
2340
2341         * macroexp.c (struct macro_buffer) <release>: Add
2342         ATTRIBUTE_UNUSED_RESULT.
2343
2344 2019-03-05  Tom Tromey  <tromey@adacore.com>
2345
2346         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2347         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2348         ATTRIBUTE_UNUSED_RESULT.
2349
2350 2019-03-05  Tom Tromey  <tromey@adacore.com>
2351
2352         * common/scoped_fd.h (class scoped_fd) <release>: Add
2353         ATTRIBUTE_UNUSED_RESULT.
2354
2355 2019-03-05  Tom Tromey  <tromey@adacore.com>
2356
2357         * parser-defs.h (struct parser_state) <release>: Add
2358         ATTRIBUTE_UNUSED_RESULT.
2359
2360 2019-03-05  Tom Tromey  <tromey@adacore.com>
2361
2362         * utils.h (class gdb_argv) <release>: Add
2363         ATTRIBUTE_UNUSED_RESULT.
2364         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2365
2366 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2367
2368         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2369         for-loop range, to avoid compiler warnings.
2370
2371         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2372         avoid compiler warnings about unused variables.
2373
2374         * NEWS: Mention end of support for native debugging on MS-Windows
2375         before XP.
2376
2377         PR gdb/24292
2378         * common/netstuff.c:
2379         * gdbserver/gdbreplay.c
2380         * gdbserver/remote-utils.c:
2381         * ser-tcp.c:
2382         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2383         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2384         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2385         'getaddrinfo' and 'freeaddrinfo' were not available before
2386         Windows XP, and mingw.org's MinGW headers by default define
2387         _WIN32_WINNT to 0x500.
2388
2389 2019-03-01  Gary Benson <gbenson@redhat.com>
2390
2391         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2392
2393 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2394             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2395
2396         PR gdb/8527
2397         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2398         set_sigint_trap, clear_sigint_trap.
2399
2400 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2401
2402         * target.c (target_detach): Clear the regcache and the
2403         frame cache.
2404
2405 2019-02-27  Pedro Alves  <palves@redhat.com>
2406
2407         * utils.c (set_screen_size): When we cap the height/width sizes,
2408         tweak the corresponding command variable to show "unlimited":
2409
2410 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2411             Pedro Alves  <palves@redhat.com>
2412
2413         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2414         before calling rl_set_screen_size.
2415
2416 2019-02-27  Tom Tromey  <tromey@adacore.com>
2417
2418         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2419         define.
2420         * python/py-value.c: Remove Python 2.4 workaround.
2421         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2422         workaround.
2423         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2424         Python 2.4 workaround.
2425         * python/python-internal.h: Remove Python 2.4 comment.
2426         (Py_ssize_t): Don't define.
2427         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2428         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2429         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2430         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2431         * python/python.c (do_start_initialization): Remove Python 2.4
2432         workaround.
2433         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2434         (print_children): Remove Python 2.4 workaround.
2435         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2436         workaround.
2437         (CHARBUFFERPROC_NAME): Remove.
2438         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2439         Python 2.4 workaround.
2440
2441 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2442
2443         * NEWS: Note minimum Python version.
2444
2445 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2446
2447         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2448         code from these functions.  Remove corresponding ifdefs.  Use
2449         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2450         Remove gotos and target of gotos.
2451         (infpy_search_memory): Likewise.
2452
2453 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2454
2455         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2456         (hppa_gdbarch_init): Don't register deleted functions with
2457         gdbarch.
2458
2459 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2460
2461         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2462         (h8300_unwind_sp): Delete.
2463         (h8300_dummy_id): Delete.
2464         (h8300_gdbarch_init): Don't register deleted functions with
2465         gdbarch.
2466
2467 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2468
2469         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2470         (ft32_unwind_pc): Delete.
2471         (ft32_unwind_sp): Delete.
2472         (ft32_gdbarch_init): Don't register deleted functions with
2473         gdbarch.
2474
2475 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2476
2477         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2478         (frv_unwind_pc): Delete.
2479         (frv_unwind_sp): Delete.
2480         (frv_gdbarch_init): Don't register deleted functions with
2481         gdbarch.
2482
2483 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2484
2485         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2486         (riscv_unwind_pc): Delete.
2487         (riscv_unwind_sp): Delete.
2488         (riscv_gdbarch_init): Don't register deleted functions with
2489         gdbarch.
2490
2491 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2492
2493         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2494         (csky_unwind_pc): Delete.
2495         (csky_unwind_sp): Delete.
2496         (csky_gdbarch_init): Don't register deleted functions with
2497         gdbarch.
2498
2499 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2500
2501         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2502         (cris_unwind_pc): Delete.
2503         (cris_unwind_sp): Delete.
2504         (cris_gdbarch_init): Don't register deleted functions with
2505         gdbarch.
2506
2507 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2508
2509         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2510         (bfin_unwind_pc): Delete.
2511         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2512
2513 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2514
2515         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2516         (arm_unwind_pc): Delete.
2517         (arm_unwind_sp): Delete.
2518         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2519
2520 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2521
2522         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2523         (arc_unwind_pc): Delete.
2524         (arc_unwind_sp): Delete.
2525         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2526
2527 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2528
2529         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
2530         (alpha_unwind_pc): Delete.
2531         (alpha_gdbarch_init): Don't register deleted functions with
2532         gdbarch.
2533
2534 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2535
2536         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
2537         (aarch64_unwind_pc): Delete.
2538         (aarch64_unwind_sp): Delete.
2539         (aarch64_gdbarch_init): Don't register deleted functions with
2540         gdbarch.
2541
2542 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2543
2544         * gdbtypes.c (type_align): Don't consider static members when
2545         computing structure alignment.
2546
2547 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2548
2549         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
2550         return 0 for other types.
2551         * arch-utils.c (default_type_align): Always return 0.
2552         * gdbarch.h: Regenerate.
2553         * gdbarch.sh (type_align): Extend comment.
2554         * gdbtypes.c (type_align): Add additional comments, always call
2555         gdbarch_type_align before applying the default rules.
2556         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2557         generic code will then apply a suitable default.
2558         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
2559         types, return 0 for other types.
2560
2561 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2562
2563         * NEWS: Create a new section for the next release branch.
2564         Rename the section of the current branch, now that it has
2565         been cut.
2566
2567 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2568
2569         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
2570         * version.in: Bump version to 8.3.50.DATE-git.
2571
2572 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
2573
2574         * aix-thread.c (ptid_cmp): Remove unused variable.
2575         (get_signaled_thread): Likewise.
2576         (store_regs_user_thread): Likewise.
2577         (store_regs_kernel_thread): Likewise.
2578         (fetch_regs_kernel_thread): Remove shadowed variable.
2579
2580 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2581
2582         * features/riscv/32bit-cpu.xml: Add register numbers.
2583         * features/riscv/32bit-fpu.c: Regenerate.
2584         * features/riscv/32bit-fpu.xml: Add register numbers.
2585         * features/riscv/64bit-cpu.xml: Add register numbers.
2586         * features/riscv/64bit-fpu.c: Regenerate.
2587         * features/riscv/64bit-fpu.xml: Add register numbers.
2588
2589 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
2590
2591         * NEWS: Mention two argument form of gdb.Value constructor.
2592         * python/py-value.c (convert_buffer_and_type_to_value): New
2593         function.
2594         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
2595         Add support for handling an optional second argument.  Call
2596         convert_buffer_and_type_to_value as appropriate.
2597         * python/python-internal.h (Py_buffer_deleter): New struct.
2598         (Py_buffer_up): New typedef.
2599
2600 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
2601
2602         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
2603         instead of releasing ownership.
2604
2605 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
2606
2607         * dwarf2read.c (open_and_init_dwp_file): Call
2608         elf_numsections instead of bfd_count_sections to initialize
2609         dwp_file->num_sections.
2610
2611 2019-02-25  Tom Tromey  <tromey@adacore.com>
2612
2613         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
2614
2615 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2616
2617         * gcore.in: Add '--readnever' option when invoking GDB.
2618
2619 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2620
2621         * MAINTAINERS: Update my email address.
2622
2623 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2624
2625         * build-id.c (build_id_to_debug_bfd_1): New function.
2626         (build_id_to_debug_bfd): Look for separate debug file in
2627         sysroot.
2628
2629 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2630
2631         * gdbarch.sh: Update the copyright year range that is placed into
2632         generated files.
2633
2634 2019-02-22  Keith Seitz  <keiths@redhat.com>
2635
2636         PR symtab/23853
2637         * linespec.c (create_sals_line_offset): Search for the default
2638         symtab's filename instead of its fullname.
2639
2640 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2641
2642         * NEWS: Update style defaults.
2643
2644 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2645
2646         * main.c (captured_main_1): Disable styling in batch mode.
2647
2648 2019-02-20  Tom Tromey  <tom@tromey.com>
2649
2650         * symtab.c (symtab_symbol_info): Fix typos.
2651
2652 2019-02-20  Tom Tromey  <tromey@adacore.com>
2653
2654         * findcmd.c (_initialize_mem_search): Use upper case for
2655         metasyntactic variables.
2656
2657 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
2658
2659         * aarch64-tdep.c (aarch64_add_reggroups): New function.
2660         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
2661
2662 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
2663
2664         * top.h (source_file_name): Change to std::string.
2665         * top.c (source_file_name): Likewise.
2666         (command_line_input): Adjust.
2667         * cli/cli-script.c (script_from_file): Adjust.
2668
2669 2019-02-19  Tom Tromey  <tromey@adacore.com>
2670
2671         * ravenscar-thread.c
2672         (ravenscar_thread_target::update_thread_list): Don't call
2673         ada_build_task_list.
2674         * ada-lang.h (ada_build_task_list): Don't declare.
2675         * ada-tasks.c (struct ada_tasks_inferior_data)
2676         <task_list_valid_p>: Now bool.
2677         (read_known_tasks, ada_task_list_changed)
2678         (ada_tasks_invalidate_inferior_data): Update.
2679         (read_known_tasks_array): Return bool.
2680         (read_known_tasks_list): Likewise.
2681         (read_known_tasks): Return void.
2682         (ada_build_task_list): Now static.
2683
2684 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2685
2686         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
2687         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
2688
2689 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2690
2691         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
2692         variant for ada_tasks_pspace_data_handle and
2693         ada_tasks_inferior_data_handle.
2694         (ada_tasks_pspace_data_cleanup): New function.
2695         (ada_tasks_inferior_data_cleanup): New function.
2696
2697 2019-02-17  Tom Tromey  <tom@tromey.com>
2698
2699         * macrotab.h (macro_source_fullname): Return a std::string.
2700         * macrotab.c (macro_include, check_for_redefinition)
2701         (macro_undef, macro_lookup_definition, foreach_macro)
2702         (foreach_macro_in_scope): Update.
2703         (macro_source_fullname): Return a std::string.
2704         * macrocmd.c (show_pp_source_pos): Update.
2705
2706 2019-02-17  Tom Tromey  <tom@tromey.com>
2707
2708         * macrocmd.c (show_pp_source_pos): Style the file names.
2709
2710 2019-02-17  Tom Tromey  <tom@tromey.com>
2711
2712         PR tui/24197:
2713         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
2714
2715 2019-02-17  Tom Tromey  <tom@tromey.com>
2716
2717         * ada-lang.c (user_select_syms): Use filtered printing.
2718         * utils.c (wrap_style): New global.
2719         (desired_style): Remove.
2720         (emit_style_escape): Add stream parameter.
2721         (set_output_style, reset_terminal_style, prompt_for_continue):
2722         Update.
2723         (flush_wrap_buffer): Only flush gdb_stdout.
2724         (wrap_here): Set wrap_style.
2725         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
2726         treat escape sequences as a character.  Change when wrap buffer is
2727         flushed.
2728         (fputs_styled): Do not set the output style when the default is
2729         requested.
2730         * ui-style.h (struct ui_file_style) <is_default>: New method.
2731         * source.c (print_source_lines_base): Emit escape sequences in one
2732         piece.
2733
2734 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2735
2736         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
2737         integers and enumeration types.
2738
2739 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2740
2741         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
2742         instead of lookup_symbol_in_language
2743         (do_exact_match): New function.
2744         (ada_get_symbol_name_matcher): Return do_exact_match when
2745         doing a verbatim match.
2746
2747 2019-02-15  Tom Tromey  <tromey@adacore.com>
2748
2749         * ravenscar-thread.c (ravenscar_thread_target::resume)
2750         (ravenscar_thread_target::wait): Special case wildcard requests.
2751
2752 2019-02-15  Tom Tromey  <tromey@adacore.com>
2753
2754         * ravenscar-thread.c (base_ptid): Remove.
2755         (struct ravenscar_thread_target) <close>: New method.
2756         <m_base_ptid>: New member.
2757         <update_inferior_ptid, active_task, task_is_currently_active,
2758         runtime_initialized>: Declare methods.
2759         <ravenscar_thread_target>: Add constructor.
2760         (ravenscar_thread_target::task_is_currently_active)
2761         (ravenscar_thread_target::update_inferior_ptid)
2762         (ravenscar_runtime_initialized): Rename.  Now methods.
2763         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
2764         (ravenscar_thread_target::update_thread_list): Update.
2765         (ravenscar_thread_target::active_task): Now method.
2766         (ravenscar_thread_target::store_registers)
2767         (ravenscar_thread_target::prepare_to_store)
2768         (ravenscar_thread_target::prepare_to_store)
2769         (ravenscar_thread_target::mourn_inferior): Update.
2770         (ravenscar_inferior_created): Use "new" to create target.
2771         (ravenscar_thread_target::get_ada_task_ptid): Update.
2772         (_initialize_ravenscar): Don't initialize base_ptid.
2773         (ravenscar_ops): Remove global.
2774
2775 2019-02-15  Tom Tromey  <tromey@adacore.com>
2776
2777         * target.h (push_target): Declare new overload.
2778         * target.c (push_target): New overload, taking an rvalue reference.
2779         * remote.c (remote_target::open_1): Use push_target overload.
2780         * corelow.c (core_target_open): Use push_target overload.
2781
2782 2019-02-15  Tom Tromey  <tromey@adacore.com>
2783
2784         * ravenscar-thread.c (is_ravenscar_task)
2785         (ravenscar_task_is_currently_active): Return bool.
2786         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
2787         (_initialize_ravenscar): Remove "(void)".
2788         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
2789         Return bool.
2790
2791 2019-02-15  Tom Tromey  <tromey@adacore.com>
2792
2793         * ravenscar-thread.c (ravenscar_runtime_initializer)
2794         (has_ravenscar_runtime, get_running_thread_id)
2795         (ravenscar_thread_target::resume): Fix indentation.
2796
2797 2019-02-15  Tom Tromey  <tromey@adacore.com>
2798
2799         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
2800         from ravenscar_arch_ops.
2801         (sparc_ravenscar_ops::fetch_registers)
2802         (sparc_ravenscar_ops::store_registers): Now methods.
2803         (sparc_ravenscar_prepare_to_store): Remove.
2804         (sparc_ravenscar_ops): Redefine.
2805         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
2806         methods and destructor.  Remove members.
2807         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
2808         (ravenscar_thread_target::store_registers)
2809         (ravenscar_thread_target::prepare_to_store): Update.
2810         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
2811         Remove.
2812         (struct ppc_ravenscar_powerpc_ops): Derive from
2813         ravenscar_arch_ops.
2814         (ppc_ravenscar_powerpc_ops::fetch_registers)
2815         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
2816         (ppc_ravenscar_powerpc_ops): Redefine.
2817         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
2818         (ppc_ravenscar_e500_ops::fetch_registers)
2819         (ppc_ravenscar_e500_ops::store_registers): Now methods.
2820         (ppc_ravenscar_e500_ops): Redefine.
2821         * aarch64-ravenscar-thread.c
2822         (aarch64_ravenscar_generic_prepare_to_store): Remove.
2823         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
2824         (aarch64_ravenscar_fetch_registers)
2825         (aarch64_ravenscar_store_registers): Now methods.
2826         (aarch64_ravenscar_ops): Redefine.
2827
2828 2019-02-15  Tom Tromey  <tromey@adacore.com>
2829
2830         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
2831         (ravenscar_thread_target::stopped_by_hw_breakpoint)
2832         (ravenscar_thread_target::stopped_by_watchpoint)
2833         (ravenscar_thread_target::stopped_data_address)
2834         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
2835
2836 2019-02-15  Tom Tromey  <tromey@adacore.com>
2837
2838         * ravenscar-thread.c: Fix some typos.
2839
2840 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2841             Tom Tromey  <tromey@adacore.com>
2842
2843         * ada-lang.c (ada_exception_sal): Change addr_string to a
2844         std::string.
2845         (create_ada_exception_catchpoint): Update.
2846
2847 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2848             Tom Tromey  <tromey@adacore.com>
2849
2850         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
2851         (bp_location_ops): Remove.
2852         (base_breakpoint_allocate_location): Update.
2853         (free_bp_location): Update.
2854         * ada-lang.c (class ada_catchpoint_location)
2855         <ada_catchpoint_location>: Remove ops parameter.
2856         (ada_catchpoint_location_dtor): Remove.
2857         (ada_catchpoint_location_ops): Remove.
2858         (allocate_location_exception): Update.
2859         * breakpoint.h (struct bp_location_ops): Remove.
2860         (class bp_location) <bp_location>: Remove bp_location_ops
2861         parameter.
2862         <~bp_location>: Add destructor.
2863         <ops>: Remove.
2864
2865 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2866             Pedro Alves  <palves@redhat.com>
2867
2868         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
2869         'PATH_MAX'.
2870
2871 2019-02-14  David Michael  <fedora.dm0@gmail.com>
2872             Samuel Thibault  <samuel.thibault@gnu.org>
2873             Thomas Schwinge  <thomas@codesourcery.com>
2874
2875         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
2876         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
2877
2878 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2879
2880         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
2881         (check_empty): Use "const char *".
2882
2883         * gnu-nat.c (gnu_nat_target::detach): Instead of
2884         'detach_inferior (pid)' call
2885         'detach_inferior (find_inferior_pid (pid))'.
2886
2887         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
2888         'nat/fork-inferior.o'.
2889         * gnu-nat.c: #include "nat/fork-inferior.h".
2890
2891         * gnu-nat.c (gnu_nat_target::detach): Instead of
2892         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2893         * gnu-nat.h: #include "inf-child.h".
2894         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2895         'i386_gnu_nat_target::fetch_registers'.
2896         (gnu_store_registers): Rename/move to
2897         'i386_gnu_nat_target::store_registers'.
2898
2899         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2900         * gnu-nat.h (mach_thread_info): New function.
2901         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2902
2903         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2904
2905 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2906
2907         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2908
2909 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2910
2911         * windows-nat.c (windows_add_thread): Add new parameter
2912         "main_thread_p" with default value set to false.  Update
2913         function documentation as well as all callers.
2914         (windows_delete_thread): Likewise.
2915         (fake_create_process): Update call to windows_add_thread.
2916         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2917         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2918         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2919         call to windows_delete_thread.
2920
2921 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2922
2923         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2924
2925 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2926
2927         * symfile.c (find_separate_debug_file): Use canonical path of
2928         sysroot with child_path instead of gdb_sysroot if it is valid.
2929
2930 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2931
2932         * symfile.c (find_separate_debug_file): Use child_path to
2933         determine if an object file is under a sysroot.
2934
2935 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2936
2937         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2938         unittests/child-path-selftests.c.
2939         * common/pathstuff.c (child_path): New function.
2940         * common/pathstuff.h (child_path): New prototype.
2941         * unittests/child-path-selftests.c: New file.
2942
2943 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2944
2945         * symfile.c (find_separate_debug_file): Look for separate debug
2946         files in debug directories under the sysroot.
2947
2948 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2949
2950         * symtab.h (struct minimal_symbol data_p): New const method.
2951         (struct minimal_symbol text_p): Likewise.
2952         * symtab.c (output_source_filename): Use file name style
2953         to print file name.
2954         (print_symbol_info): Likewise.
2955         (print_msymbol_info): Use address style to print addresses.
2956         Use function name style to print executable text symbols.
2957         (expand_symtab_containing_pc): Use data_p.
2958         (find_pc_sect_compunit_symtab): Likewise.
2959
2960 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2961
2962         * breakpoint.c (describe_other_breakpoints): Use address style
2963         to print addresses.
2964         (say_where): Likewise.
2965
2966 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2967
2968         * ada-typeprint.c (print_func_type): Print function name
2969         style to print function name.
2970         * c-typeprint.c (c_print_type_1): Likewise.
2971
2972 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2973
2974         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2975         for execve.
2976
2977 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2978
2979         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2980         type_stack.
2981
2982 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2983
2984         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2985         TYPE_CODE_REF types.
2986
2987 2019-02-08  Jim Wilson  <jimw@sifive.com>
2988
2989         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2990         (riscv_linux_fregset): New.
2991         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2992
2993 2019-02-07  Tom Tromey  <tom@tromey.com>
2994
2995         * thread.c (thread_cancel_execution_command): Update.
2996         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2997         methods.
2998         (struct thread_fsm_ops): Remove.
2999         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3000         (thread_fsm_should_stop, thread_fsm_return_value)
3001         (thread_fsm_set_finished, thread_fsm_finished_p)
3002         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3003         Don't declare.
3004         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3005         * infrun.c (clear_proceed_status_thread)
3006         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3007         (print_stop_event): Update.
3008         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3009         Add constructor.
3010         (step_command_fsm_ops): Remove.
3011         (new_step_command_fsm): Remove.
3012         (step_1): Update.
3013         (step_command_fsm::should_stop): Rename from
3014         step_command_fsm_should_stop.
3015         (step_command_fsm::clean_up): Rename from
3016         step_command_fsm_clean_up.
3017         (step_command_fsm::do_async_reply_reason): Rename from
3018         step_command_fsm_async_reply_reason.
3019         (struct until_next_fsm): Inherit from thread_fsm.  Add
3020         constructor.
3021         (until_next_fsm_ops): Remove.
3022         (new_until_next_fsm): Remove.
3023         (until_next_fsm::should_stop): Rename from
3024         until_next_fsm_should_stop.
3025         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3026         (until_next_fsm::do_async_reply_reason): Rename from
3027         until_next_fsm_async_reply_reason.
3028         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3029         constructor.  Change type of breakpoint.
3030         (finish_command_fsm_ops): Remove.
3031         (new_finish_command_fsm): Remove.
3032         (finish_command_fsm::should_stop): Rename from
3033         finish_command_fsm_should_stop.
3034         (finish_command_fsm::clean_up): Rename from
3035         finish_command_fsm_clean_up.
3036         (finish_command_fsm::return_value): Rename from
3037         finish_command_fsm_return_value.
3038         (finish_command_fsm::do_async_reply_reason): Rename from
3039         finish_command_fsm_async_reply_reason.
3040         (finish_command): Update.
3041         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3042         Add constructor.
3043         (call_thread_fsm_ops): Remove.
3044         (call_thread_fsm::call_thread_fsm): Rename from
3045         new_call_thread_fsm.
3046         (call_thread_fsm::should_stop): Rename from
3047         call_thread_fsm_should_stop.
3048         (call_thread_fsm::should_notify_stop): Rename from
3049         call_thread_fsm_should_notify_stop.
3050         (run_inferior_call, call_function_by_hand_dummy): Update.
3051         * cli/cli-interp.c (should_print_stop_to_console): Update.
3052         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3053         Add constructor.  Change type of location_breakpoint,
3054         caller_breakpoint.
3055         (until_break_fsm_ops): Remove.
3056         (new_until_break_fsm): Remove.
3057         (until_break_fsm::should_stop): Rename from
3058         until_break_fsm_should_stop.
3059         (until_break_fsm::clean_up): Rename from
3060         until_break_fsm_clean_up.
3061         (until_break_fsm::do_async_reply_reason): Rename from
3062         until_break_fsm_async_reply_reason.
3063         (until_break_command): Update.
3064         * thread-fsm.c: Remove.
3065         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3066
3067 2019-02-07  Tom Tromey  <tom@tromey.com>
3068
3069         * yy-remap.h: Add include guard.
3070         * xtensa-tdep.h: Add include guard.
3071         * xcoffread.h: Rename include guard.
3072         * varobj-iter.h: Add include guard.
3073         * tui/tui.h: Rename include guard.
3074         * tui/tui-winsource.h: Rename include guard.
3075         * tui/tui-wingeneral.h: Rename include guard.
3076         * tui/tui-windata.h: Rename include guard.
3077         * tui/tui-win.h: Rename include guard.
3078         * tui/tui-stack.h: Rename include guard.
3079         * tui/tui-source.h: Rename include guard.
3080         * tui/tui-regs.h: Rename include guard.
3081         * tui/tui-out.h: Rename include guard.
3082         * tui/tui-layout.h: Rename include guard.
3083         * tui/tui-io.h: Rename include guard.
3084         * tui/tui-hooks.h: Rename include guard.
3085         * tui/tui-file.h: Rename include guard.
3086         * tui/tui-disasm.h: Rename include guard.
3087         * tui/tui-data.h: Rename include guard.
3088         * tui/tui-command.h: Rename include guard.
3089         * tic6x-tdep.h: Add include guard.
3090         * target/waitstatus.h: Rename include guard.
3091         * target/wait.h: Rename include guard.
3092         * target/target.h: Rename include guard.
3093         * target/resume.h: Rename include guard.
3094         * target-float.h: Rename include guard.
3095         * stabsread.h: Add include guard.
3096         * rs6000-tdep.h: Add include guard.
3097         * riscv-fbsd-tdep.h: Add include guard.
3098         * regformats/regdef.h: Rename include guard.
3099         * record.h: Rename include guard.
3100         * python/python.h: Rename include guard.
3101         * python/python-internal.h: Rename include guard.
3102         * python/py-stopevent.h: Rename include guard.
3103         * python/py-ref.h: Rename include guard.
3104         * python/py-record.h: Rename include guard.
3105         * python/py-record-full.h: Rename include guard.
3106         * python/py-record-btrace.h: Rename include guard.
3107         * python/py-instruction.h: Rename include guard.
3108         * python/py-events.h: Rename include guard.
3109         * python/py-event.h: Rename include guard.
3110         * procfs.h: Add include guard.
3111         * proc-utils.h: Add include guard.
3112         * p-lang.h: Add include guard.
3113         * or1k-tdep.h: Rename include guard.
3114         * observable.h: Rename include guard.
3115         * nto-tdep.h: Rename include guard.
3116         * nat/x86-linux.h: Rename include guard.
3117         * nat/x86-linux-dregs.h: Rename include guard.
3118         * nat/x86-gcc-cpuid.h: Add include guard.
3119         * nat/x86-dregs.h: Rename include guard.
3120         * nat/x86-cpuid.h: Rename include guard.
3121         * nat/ppc-linux.h: Rename include guard.
3122         * nat/mips-linux-watch.h: Rename include guard.
3123         * nat/linux-waitpid.h: Rename include guard.
3124         * nat/linux-ptrace.h: Rename include guard.
3125         * nat/linux-procfs.h: Rename include guard.
3126         * nat/linux-osdata.h: Rename include guard.
3127         * nat/linux-nat.h: Rename include guard.
3128         * nat/linux-namespaces.h: Rename include guard.
3129         * nat/linux-btrace.h: Rename include guard.
3130         * nat/glibc_thread_db.h: Rename include guard.
3131         * nat/gdb_thread_db.h: Rename include guard.
3132         * nat/gdb_ptrace.h: Rename include guard.
3133         * nat/fork-inferior.h: Rename include guard.
3134         * nat/amd64-linux-siginfo.h: Rename include guard.
3135         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3136         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3137         * nat/aarch64-linux.h: Rename include guard.
3138         * nat/aarch64-linux-hw-point.h: Rename include guard.
3139         * mn10300-tdep.h: Add include guard.
3140         * mips-linux-tdep.h: Add include guard.
3141         * mi/mi-parse.h: Rename include guard.
3142         * mi/mi-out.h: Rename include guard.
3143         * mi/mi-main.h: Rename include guard.
3144         * mi/mi-interp.h: Rename include guard.
3145         * mi/mi-getopt.h: Rename include guard.
3146         * mi/mi-console.h: Rename include guard.
3147         * mi/mi-common.h: Rename include guard.
3148         * mi/mi-cmds.h: Rename include guard.
3149         * mi/mi-cmd-break.h: Rename include guard.
3150         * m2-lang.h: Add include guard.
3151         * location.h: Rename include guard.
3152         * linux-record.h: Rename include guard.
3153         * linux-nat.h: Add include guard.
3154         * linux-fork.h: Add include guard.
3155         * i386-darwin-tdep.h: Rename include guard.
3156         * hppa-linux-offsets.h: Add include guard.
3157         * guile/guile.h: Rename include guard.
3158         * guile/guile-internal.h: Rename include guard.
3159         * gnu-nat.h: Rename include guard.
3160         * gdb-stabs.h: Rename include guard.
3161         * frv-tdep.h: Add include guard.
3162         * f-lang.h: Add include guard.
3163         * event-loop.h: Add include guard.
3164         * darwin-nat.h: Rename include guard.
3165         * cp-abi.h: Rename include guard.
3166         * config/sparc/nm-sol2.h: Rename include guard.
3167         * config/nm-nto.h: Rename include guard.
3168         * config/nm-linux.h: Add include guard.
3169         * config/i386/nm-i386gnu.h: Rename include guard.
3170         * config/djgpp/nl_types.h: Rename include guard.
3171         * config/djgpp/langinfo.h: Rename include guard.
3172         * compile/gcc-cp-plugin.h: Add include guard.
3173         * compile/gcc-c-plugin.h: Add include guard.
3174         * compile/compile.h: Rename include guard.
3175         * compile/compile-object-run.h: Rename include guard.
3176         * compile/compile-object-load.h: Rename include guard.
3177         * compile/compile-internal.h: Rename include guard.
3178         * compile/compile-cplus.h: Rename include guard.
3179         * compile/compile-c.h: Rename include guard.
3180         * common/xml-utils.h: Rename include guard.
3181         * common/x86-xstate.h: Rename include guard.
3182         * common/version.h: Rename include guard.
3183         * common/vec.h: Rename include guard.
3184         * common/tdesc.h: Rename include guard.
3185         * common/selftest.h: Rename include guard.
3186         * common/scoped_restore.h: Rename include guard.
3187         * common/scoped_mmap.h: Rename include guard.
3188         * common/scoped_fd.h: Rename include guard.
3189         * common/safe-iterator.h: Rename include guard.
3190         * common/run-time-clock.h: Rename include guard.
3191         * common/refcounted-object.h: Rename include guard.
3192         * common/queue.h: Rename include guard.
3193         * common/ptid.h: Rename include guard.
3194         * common/print-utils.h: Rename include guard.
3195         * common/preprocessor.h: Rename include guard.
3196         * common/pathstuff.h: Rename include guard.
3197         * common/observable.h: Rename include guard.
3198         * common/netstuff.h: Rename include guard.
3199         * common/job-control.h: Rename include guard.
3200         * common/host-defs.h: Rename include guard.
3201         * common/gdb_wait.h: Rename include guard.
3202         * common/gdb_vecs.h: Rename include guard.
3203         * common/gdb_unlinker.h: Rename include guard.
3204         * common/gdb_unique_ptr.h: Rename include guard.
3205         * common/gdb_tilde_expand.h: Rename include guard.
3206         * common/gdb_sys_time.h: Rename include guard.
3207         * common/gdb_string_view.h: Rename include guard.
3208         * common/gdb_splay_tree.h: Rename include guard.
3209         * common/gdb_setjmp.h: Rename include guard.
3210         * common/gdb_ref_ptr.h: Rename include guard.
3211         * common/gdb_optional.h: Rename include guard.
3212         * common/gdb_locale.h: Rename include guard.
3213         * common/gdb_assert.h: Rename include guard.
3214         * common/filtered-iterator.h: Rename include guard.
3215         * common/filestuff.h: Rename include guard.
3216         * common/fileio.h: Rename include guard.
3217         * common/environ.h: Rename include guard.
3218         * common/common-utils.h: Rename include guard.
3219         * common/common-types.h: Rename include guard.
3220         * common/common-regcache.h: Rename include guard.
3221         * common/common-inferior.h: Rename include guard.
3222         * common/common-gdbthread.h: Rename include guard.
3223         * common/common-exceptions.h: Rename include guard.
3224         * common/common-defs.h: Rename include guard.
3225         * common/common-debug.h: Rename include guard.
3226         * common/cleanups.h: Rename include guard.
3227         * common/buffer.h: Rename include guard.
3228         * common/btrace-common.h: Rename include guard.
3229         * common/break-common.h: Rename include guard.
3230         * cli/cli-utils.h: Rename include guard.
3231         * cli/cli-style.h: Rename include guard.
3232         * cli/cli-setshow.h: Rename include guard.
3233         * cli/cli-script.h: Rename include guard.
3234         * cli/cli-interp.h: Rename include guard.
3235         * cli/cli-decode.h: Rename include guard.
3236         * cli/cli-cmds.h: Rename include guard.
3237         * charset-list.h: Add include guard.
3238         * buildsym-legacy.h: Rename include guard.
3239         * bfin-tdep.h: Add include guard.
3240         * ax.h: Rename include guard.
3241         * arm-linux-tdep.h: Add include guard.
3242         * arm-fbsd-tdep.h: Add include guard.
3243         * arch/xtensa.h: Rename include guard.
3244         * arch/tic6x.h: Add include guard.
3245         * arch/i386.h: Add include guard.
3246         * arch/arm.h: Rename include guard.
3247         * arch/arm-linux.h: Rename include guard.
3248         * arch/arm-get-next-pcs.h: Rename include guard.
3249         * arch/amd64.h: Add include guard.
3250         * arch/aarch64-insn.h: Rename include guard.
3251         * arch-utils.h: Rename include guard.
3252         * annotate.h: Add include guard.
3253         * amd64-darwin-tdep.h: Rename include guard.
3254         * aarch64-linux-tdep.h: Add include guard.
3255         * aarch64-fbsd-tdep.h: Add include guard.
3256         * aarch32-linux-nat.h: Add include guard.
3257
3258 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3259
3260         * macrotab.c (macro_define_internal): New function that
3261         factorizes macro_define_object_internal and macro_define_function
3262         code.
3263         (macro_define_object_internal): Use macro_define_internal.
3264         (macro_define_function): Likewise.
3265
3266 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3267
3268         * macrocmd.c (extract_identifier): Return
3269         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3270         callers.
3271
3272 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3273
3274         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3275
3276 2019-02-05  Tom Tromey  <tom@tromey.com>
3277
3278         * target.c (target_stack::unpush): Move assertion earlier.
3279
3280 2019-01-30  Tom Tromey  <tom@tromey.com>
3281
3282         PR python/23615:
3283         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3284         (gdbpy_parse_and_eval): Likewise.
3285         * python/python-internal.h (gdbpy_allow_threads): New class.
3286
3287 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3288
3289         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3290         (aarch64_fbsd_fpregmap): Move earlier.
3291         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3292         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3293         instead of individual calls to trad_frame_set_reg_addr.
3294         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3295         earlier.
3296         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3297         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3298         instead of individual calls to trad_frame_set_reg_addr.
3299
3300 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3301
3302         * CONTRIBUTE: Replace contribution list with wiki link.
3303
3304 2019-01-25  Tom Tromey  <tom@tromey.com>
3305
3306         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3307
3308 2019-01-25  Tom Tromey  <tom@tromey.com>
3309
3310         * xtensa-linux-nat.c: Fix common/ includes.
3311         * xml-support.h: Fix common/ includes.
3312         * xml-support.c: Fix common/ includes.
3313         * x86-linux-nat.c: Fix common/ includes.
3314         * windows-nat.c: Fix common/ includes.
3315         * varobj.h: Fix common/ includes.
3316         * varobj.c: Fix common/ includes.
3317         * value.c: Fix common/ includes.
3318         * valops.c: Fix common/ includes.
3319         * utils.c: Fix common/ includes.
3320         * unittests/xml-utils-selftests.c: Fix common/ includes.
3321         * unittests/utils-selftests.c: Fix common/ includes.
3322         * unittests/unpack-selftests.c: Fix common/ includes.
3323         * unittests/tracepoint-selftests.c: Fix common/ includes.
3324         * unittests/style-selftests.c: Fix common/ includes.
3325         * unittests/string_view-selftests.c: Fix common/ includes.
3326         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3327         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3328         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3329         * unittests/rsp-low-selftests.c: Fix common/ includes.
3330         * unittests/parse-connection-spec-selftests.c: Fix common/
3331         includes.
3332         * unittests/optional-selftests.c: Fix common/ includes.
3333         * unittests/offset-type-selftests.c: Fix common/ includes.
3334         * unittests/observable-selftests.c: Fix common/ includes.
3335         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3336         * unittests/memrange-selftests.c: Fix common/ includes.
3337         * unittests/memory-map-selftests.c: Fix common/ includes.
3338         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3339         * unittests/function-view-selftests.c: Fix common/ includes.
3340         * unittests/environ-selftests.c: Fix common/ includes.
3341         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3342         * unittests/common-utils-selftests.c: Fix common/ includes.
3343         * unittests/cli-utils-selftests.c: Fix common/ includes.
3344         * unittests/array-view-selftests.c: Fix common/ includes.
3345         * ui-file.c: Fix common/ includes.
3346         * tui/tui-io.c: Fix common/ includes.
3347         * tracepoint.h: Fix common/ includes.
3348         * tracepoint.c: Fix common/ includes.
3349         * tracefile-tfile.c: Fix common/ includes.
3350         * top.h: Fix common/ includes.
3351         * top.c: Fix common/ includes.
3352         * thread.c: Fix common/ includes.
3353         * target/waitstatus.h: Fix common/ includes.
3354         * target/waitstatus.c: Fix common/ includes.
3355         * target.h: Fix common/ includes.
3356         * target.c: Fix common/ includes.
3357         * target-memory.c: Fix common/ includes.
3358         * target-descriptions.c: Fix common/ includes.
3359         * symtab.h: Fix common/ includes.
3360         * symfile.c: Fix common/ includes.
3361         * stap-probe.c: Fix common/ includes.
3362         * spu-linux-nat.c: Fix common/ includes.
3363         * sparc-nat.c: Fix common/ includes.
3364         * source.c: Fix common/ includes.
3365         * solib.c: Fix common/ includes.
3366         * solib-target.c: Fix common/ includes.
3367         * ser-unix.c: Fix common/ includes.
3368         * ser-tcp.c: Fix common/ includes.
3369         * ser-pipe.c: Fix common/ includes.
3370         * ser-base.c: Fix common/ includes.
3371         * selftest-arch.c: Fix common/ includes.
3372         * s12z-tdep.c: Fix common/ includes.
3373         * rust-exp.y: Fix common/ includes.
3374         * rs6000-aix-tdep.c: Fix common/ includes.
3375         * riscv-tdep.c: Fix common/ includes.
3376         * remote.c: Fix common/ includes.
3377         * remote-notif.h: Fix common/ includes.
3378         * remote-fileio.h: Fix common/ includes.
3379         * remote-fileio.c: Fix common/ includes.
3380         * regcache.h: Fix common/ includes.
3381         * regcache.c: Fix common/ includes.
3382         * record-btrace.c: Fix common/ includes.
3383         * python/python.c: Fix common/ includes.
3384         * python/py-type.c: Fix common/ includes.
3385         * python/py-inferior.c: Fix common/ includes.
3386         * progspace.h: Fix common/ includes.
3387         * producer.c: Fix common/ includes.
3388         * procfs.c: Fix common/ includes.
3389         * proc-api.c: Fix common/ includes.
3390         * printcmd.c: Fix common/ includes.
3391         * ppc-linux-nat.c: Fix common/ includes.
3392         * parser-defs.h: Fix common/ includes.
3393         * osdata.c: Fix common/ includes.
3394         * obsd-nat.c: Fix common/ includes.
3395         * nat/x86-linux.c: Fix common/ includes.
3396         * nat/x86-linux-dregs.c: Fix common/ includes.
3397         * nat/x86-dregs.h: Fix common/ includes.
3398         * nat/x86-dregs.c: Fix common/ includes.
3399         * nat/ppc-linux.c: Fix common/ includes.
3400         * nat/mips-linux-watch.h: Fix common/ includes.
3401         * nat/mips-linux-watch.c: Fix common/ includes.
3402         * nat/linux-waitpid.c: Fix common/ includes.
3403         * nat/linux-ptrace.h: Fix common/ includes.
3404         * nat/linux-ptrace.c: Fix common/ includes.
3405         * nat/linux-procfs.c: Fix common/ includes.
3406         * nat/linux-personality.c: Fix common/ includes.
3407         * nat/linux-osdata.c: Fix common/ includes.
3408         * nat/linux-namespaces.c: Fix common/ includes.
3409         * nat/linux-btrace.h: Fix common/ includes.
3410         * nat/linux-btrace.c: Fix common/ includes.
3411         * nat/fork-inferior.c: Fix common/ includes.
3412         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3413         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3414         * nat/aarch64-linux.c: Fix common/ includes.
3415         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3416         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3417         * namespace.h: Fix common/ includes.
3418         * mips-linux-tdep.c: Fix common/ includes.
3419         * minsyms.c: Fix common/ includes.
3420         * mi/mi-parse.h: Fix common/ includes.
3421         * mi/mi-main.c: Fix common/ includes.
3422         * mi/mi-cmd-env.c: Fix common/ includes.
3423         * memrange.h: Fix common/ includes.
3424         * memattr.c: Fix common/ includes.
3425         * maint.h: Fix common/ includes.
3426         * maint.c: Fix common/ includes.
3427         * main.c: Fix common/ includes.
3428         * machoread.c: Fix common/ includes.
3429         * location.c: Fix common/ includes.
3430         * linux-thread-db.c: Fix common/ includes.
3431         * linux-nat.c: Fix common/ includes.
3432         * linux-fork.c: Fix common/ includes.
3433         * inline-frame.c: Fix common/ includes.
3434         * infrun.c: Fix common/ includes.
3435         * inflow.c: Fix common/ includes.
3436         * inferior.h: Fix common/ includes.
3437         * inferior.c: Fix common/ includes.
3438         * infcmd.c: Fix common/ includes.
3439         * inf-ptrace.c: Fix common/ includes.
3440         * inf-child.c: Fix common/ includes.
3441         * ia64-linux-nat.c: Fix common/ includes.
3442         * i387-tdep.c: Fix common/ includes.
3443         * i386-tdep.c: Fix common/ includes.
3444         * i386-linux-tdep.c: Fix common/ includes.
3445         * i386-linux-nat.c: Fix common/ includes.
3446         * i386-go32-tdep.c: Fix common/ includes.
3447         * i386-fbsd-tdep.c: Fix common/ includes.
3448         * i386-fbsd-nat.c: Fix common/ includes.
3449         * guile/scm-type.c: Fix common/ includes.
3450         * guile/guile.c: Fix common/ includes.
3451         * go32-nat.c: Fix common/ includes.
3452         * gnu-nat.c: Fix common/ includes.
3453         * gdbthread.h: Fix common/ includes.
3454         * gdbarch-selftests.c: Fix common/ includes.
3455         * gdb_usleep.c: Fix common/ includes.
3456         * gdb_select.h: Fix common/ includes.
3457         * gdb_bfd.c: Fix common/ includes.
3458         * gcore.c: Fix common/ includes.
3459         * fork-child.c: Fix common/ includes.
3460         * findvar.c: Fix common/ includes.
3461         * fbsd-nat.c: Fix common/ includes.
3462         * event-top.c: Fix common/ includes.
3463         * event-loop.c: Fix common/ includes.
3464         * dwarf2read.c: Fix common/ includes.
3465         * dwarf2loc.c: Fix common/ includes.
3466         * dwarf2-frame.c: Fix common/ includes.
3467         * dwarf-index-cache.c: Fix common/ includes.
3468         * dtrace-probe.c: Fix common/ includes.
3469         * disasm-selftests.c: Fix common/ includes.
3470         * defs.h: Fix common/ includes.
3471         * csky-tdep.c: Fix common/ includes.
3472         * cp-valprint.c: Fix common/ includes.
3473         * cp-support.h: Fix common/ includes.
3474         * cp-support.c: Fix common/ includes.
3475         * corelow.c: Fix common/ includes.
3476         * completer.h: Fix common/ includes.
3477         * completer.c: Fix common/ includes.
3478         * compile/compile.c: Fix common/ includes.
3479         * compile/compile-loc2c.c: Fix common/ includes.
3480         * compile/compile-cplus-types.c: Fix common/ includes.
3481         * compile/compile-cplus-symbols.c: Fix common/ includes.
3482         * command.h: Fix common/ includes.
3483         * cli/cli-dump.c: Fix common/ includes.
3484         * cli/cli-cmds.c: Fix common/ includes.
3485         * charset.c: Fix common/ includes.
3486         * build-id.c: Fix common/ includes.
3487         * btrace.h: Fix common/ includes.
3488         * btrace.c: Fix common/ includes.
3489         * breakpoint.h: Fix common/ includes.
3490         * breakpoint.c: Fix common/ includes.
3491         * ax.h: 
3492         (enum agent_op): Fix common/ includes.
3493         * ax-general.c (struct aop_map): Fix common/ includes.
3494         * ax-gdb.c: Fix common/ includes.
3495         * auxv.c: Fix common/ includes.
3496         * auto-load.c: Fix common/ includes.
3497         * arm-tdep.c: Fix common/ includes.
3498         * arch/riscv.c: Fix common/ includes.
3499         * arch/ppc-linux-common.c: Fix common/ includes.
3500         * arch/i386.c: Fix common/ includes.
3501         * arch/arm.c: Fix common/ includes.
3502         * arch/arm-linux.c: Fix common/ includes.
3503         * arch/arm-get-next-pcs.c: Fix common/ includes.
3504         * arch/amd64.c: Fix common/ includes.
3505         * arch/aarch64.c: Fix common/ includes.
3506         * arch/aarch64-insn.c: Fix common/ includes.
3507         * arch-utils.c: Fix common/ includes.
3508         * amd64-windows-tdep.c: Fix common/ includes.
3509         * amd64-tdep.c: Fix common/ includes.
3510         * amd64-sol2-tdep.c: Fix common/ includes.
3511         * amd64-obsd-tdep.c: Fix common/ includes.
3512         * amd64-nbsd-tdep.c: Fix common/ includes.
3513         * amd64-linux-tdep.c: Fix common/ includes.
3514         * amd64-linux-nat.c: Fix common/ includes.
3515         * amd64-fbsd-tdep.c: Fix common/ includes.
3516         * amd64-fbsd-nat.c: Fix common/ includes.
3517         * amd64-dicos-tdep.c: Fix common/ includes.
3518         * amd64-darwin-tdep.c: Fix common/ includes.
3519         * agent.c: Fix common/ includes.
3520         * ada-lang.h: Fix common/ includes.
3521         * ada-lang.c: Fix common/ includes.
3522         * aarch64-tdep.c: Fix common/ includes.
3523
3524 2019-01-25  Tom Tromey  <tom@tromey.com>
3525
3526         * common/create-version.sh: Use common/version.h.
3527
3528 2019-01-24  Pedro Alves  <palves@redhat.com>
3529
3530         * infrun.c (signal_stop, signal_print, signal_program)
3531         (signal_catch, signal_pass): Now arrays instead of pointers.
3532         (update_signals_program_target, do_target_resume)
3533         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
3534         * linux-nat.c (linux_nat_target::pass_signals)
3535         (linux_nat_target::create_inferior, linux_nat_target::attach):
3536         Adjust.
3537         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
3538         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
3539         * procfs.c (procfs_target::pass_signals): Adjust.
3540         * record-full.c (record_full_target::resume): Adjust.
3541         * remote.c (remote_target::pass_signals)
3542         (remote_target::program_signals): Adjust.
3543         * target-debug.h (target_debug_print_signals): Now takes a
3544         gdb::array_view as parameter.  Adjust.
3545         * target.h (target_ops) <pass_signals, program_signals>: Replace
3546         pointer and length parameters with gdb::array_view.
3547         (target_pass_signals, target_program_signals): Likewise.
3548         * target-delegates.c: Regenerate.
3549
3550 2019-01-24  Pedro Alves  <palves@redhat.com>
3551
3552         * common/forward-scope-exit.h
3553         (forward_scope_exit::forward_scope_exit): Pass arguments to
3554         m_bind_function directly, instead of creating a std::bind and
3555         copying that.
3556
3557 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
3558
3559         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3560         for static members.
3561         (pass_in_v_vfp_candidate): Likewise.
3562
3563 2019-01-23  Tom Tromey  <tom@tromey.com>
3564             Pedro Alves  <palves@redhat.com>
3565
3566         * regcache.c (class regcache_invalidator): Remove.
3567         (regcache::raw_write): Use make_scope_exit.
3568
3569 2019-01-23  Tom Tromey  <tom@tromey.com>
3570
3571         * ui-out.h (class ui_out_emit_type): Update comment.
3572
3573 2019-01-23  Tom Tromey  <tom@tromey.com>
3574
3575         * infrun.c (fetch_inferior_event): Update comment.
3576
3577 2019-01-23  Tom Tromey  <tom@tromey.com>
3578             Pedro Alves  <palves@redhat.com>
3579
3580         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
3581         parameter.
3582         (fetch_inferior_event): Use SCOPE_EXIT.
3583
3584
3585 2019-01-23  Tom Tromey  <tom@tromey.com>
3586             Pedro Alves  <palves@redhat.com>
3587
3588         * infrun.c (disable_thread_events): Delete.
3589         (stop_all_threads): Use SCOPE_EXIT.
3590
3591 2019-01-23  Tom Tromey  <tom@tromey.com>
3592             Pedro Alves  <palves@redhat.com>
3593
3594         * symfile.c: Include forward-scope-exit.h.
3595         (clear_symtab_users_cleanup): Replace forward declaration with
3596         a FORWARD_SCOPE_EXIT.
3597         (syms_from_objfile_1): Use the forward_scope_exit and
3598         gdb::optional instead of cleanup_function.
3599         (reread_symbols): Use the forward_scope_exit instead of
3600         cleanup_function.
3601         (clear_symtab_users_cleanup): Remove function.
3602
3603 2019-01-23  Tom Tromey  <tom@tromey.com>
3604             Pedro Alves  <palves@redhat.com>
3605
3606         * linux-nat.c: Include scope-exit.h.
3607         (cleanup_target_stop): Remove.
3608         (linux_nat_target::static_tracepoint_markers_by_strid): Use
3609         SCOPE_EXIT.
3610
3611 2019-01-23  Tom Tromey  <tom@tromey.com>
3612             Pedro Alves  <palves@redhat.com>
3613
3614         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
3615         (call_function_by_hand_dummy): Use SCOPE_EXIT.
3616
3617 2019-01-23  Tom Tromey  <tom@tromey.com>
3618             Andrew Burgess  <andrew.burgess@embecosm.com>
3619             Pedro Alves  <palves@redhat.com>
3620
3621         * infrun.c (fetch_inferior_event): Use scope_exit.
3622         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
3623         * top.c (execute_command): Use scope_exit.
3624         * breakpoint.c (bpstat_do_actions): Use scope_exit.
3625         * utils.c (do_bpstat_clear_actions_cleanup)
3626         (make_bpstat_clear_actions_cleanup): Remove.
3627
3628 2019-01-23  Tom Tromey  <tom@tromey.com>
3629             Pedro Alves  <palves@redhat.com>
3630
3631         * infrun.c: Include "common/scope-exit.h"
3632         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
3633         (wait_for_inferior): Use SCOPE_EXIT.
3634         (fetch_inferior_event): Use scope_exit.
3635
3636 2019-01-23  Tom Tromey  <tom@tromey.com>
3637             Pedro Alves  <palves@redhat.com>
3638
3639         * breakpoint.c (create_breakpoint): Remove cleanup.
3640
3641 2019-01-23  Tom Tromey  <tom@tromey.com>
3642             Andrew Burgess  <andrew.burgess@embecosm.com>
3643             Pedro Alves  <palves@redhat.com>
3644
3645 2019-01-23  Pedro Alves  <palves@redhat.com>
3646
3647         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
3648
3649 2019-01-23  Pedro Alves  <palves@redhat.com>
3650             Andrew Burgess  <andrew.burgess@embecosm.com>
3651
3652         * gdbthread.h: Include "common/forward-scope-exit.h".
3653         (scoped_finish_thread_state): Redefine custom class in terms of
3654         forward_scope_exit.
3655
3656 2019-01-23  Pedro Alves  <palves@redhat.com>
3657             Andrew Burgess  <andrew.burgess@embecosm.com>
3658
3659         * common/forward-scope-exit.h: New file.
3660
3661 2019-01-23  Pedro Alves  <palves@redhat.com>
3662             Andrew Burgess  <andrew.burgess@embecosm.com>
3663             Tom Tromey  <tom@tromey.com>
3664
3665         * common/scope-exit.h: New file.
3666
3667 2019-01-23  Pedro Alves  <palves@redhat.com>
3668
3669         * common/preprocessor.h (ESC): Rename to ...
3670         (ESC_PARENS): ... this.
3671         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
3672         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
3673
3674 2019-01-23  Tom Tromey  <tom@tromey.com>
3675
3676         * language.h (class scoped_switch_to_sym_language_if_auto):
3677         Initialize m_lang in both cases.
3678
3679 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
3680
3681         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
3682         with XCNEW.
3683
3684 2019-01-22  Tom Tromey  <tom@tromey.com>
3685
3686         * corelow.c: Do not include sys/file.h.
3687
3688 2019-01-22  Tom Tromey  <tom@tromey.com>
3689
3690         * tui/tui-wingeneral.h: Include gdb_curses.h.
3691
3692 2019-01-22  Tom Tromey  <tom@tromey.com>
3693
3694         * source-cache.h (class source_cache) <get_source_lines,
3695         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
3696
3697 2019-01-22  Tom Tromey  <tom@tromey.com>
3698
3699         * remote-fileio.h (struct remote_target): Declare.
3700
3701 2019-01-22  Tom Tromey  <tom@tromey.com>
3702
3703         * python/py-arch.c: Do not include py-ref.h.
3704         * python/py-bpevent.c: Do not include py-ref.h.
3705         * python/py-cmd.c: Do not include py-ref.h.
3706         * python/py-continueevent.c: Do not include py-ref.h.
3707         * python/py-event.h: Do not include py-ref.h.
3708         * python/py-evtregistry.c: Do not include py-ref.h.
3709         * python/py-finishbreakpoint.c: Do not include py-ref.h.
3710         * python/py-frame.c: Do not include py-ref.h.
3711         * python/py-framefilter.c: Do not include py-ref.h.
3712         * python/py-function.c: Do not include py-ref.h.
3713         * python/py-infevents.c: Do not include py-ref.h.
3714         * python/py-linetable.c: Do not include py-ref.h.
3715         * python/py-objfile.c: Do not include py-ref.h.
3716         * python/py-param.c: Do not include py-ref.h.
3717         * python/py-prettyprint.c: Do not include py-ref.h.
3718         * python/py-progspace.c: Do not include py-ref.h.
3719         * python/py-symbol.c: Do not include py-ref.h.
3720         * python/py-symtab.c: Do not include py-ref.h.
3721         * python/py-type.c: Do not include py-ref.h.
3722         * python/py-unwind.c: Do not include py-ref.h.
3723         * python/py-utils.c: Do not include py-ref.h.
3724         * python/py-value.c: Do not include py-ref.h.
3725         * python/py-varobj.c: Do not include py-ref.h.
3726         * python/py-xmethods.c: Do not include py-ref.h.
3727         * python/python.c: Do not include py-ref.h.
3728         * varobj.c: Do not include py-ref.h.
3729
3730 2019-01-22  Tom Tromey  <tom@tromey.com>
3731
3732         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
3733         keyword for bcache.
3734
3735 2019-01-22  Tom Tromey  <tom@tromey.com>
3736
3737         * compile/compile-cplus-types.c: Remove a comment by #include.
3738
3739 2019-01-22  Tom Tromey  <tom@tromey.com>
3740
3741         * compile/gcc-c-plugin.h: Include compile-internal.h.
3742
3743 2019-01-22  Tom Tromey  <tom@tromey.com>
3744
3745         * stabsread.c (EXTERN): Do not define.
3746         (symnum, next_symbol_text_func, processing_gcc_compilation)
3747         (within_function, global_sym_chain, global_stabs)
3748         (previous_stab_code, this_object_header_files)
3749         (n_this_object_header_files)
3750         (n_allocated_this_object_header_files): Define.
3751         * stabsread.h (EXTERN): Never define.  Use "extern".
3752
3753 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3754
3755         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
3756         history_value.
3757
3758 2019-01-21  Tom Tromey  <tom@tromey.com>
3759
3760         * ui-out.c: Fix includes.
3761         * tui/tui-source.c: Fix includes.
3762         * target.c: Fix includes.
3763         * remote.c: Fix includes.
3764         * regcache.c: Fix includes.
3765         * python/py-block.c: Fix includes.
3766         * printcmd.c: Fix includes.
3767         * or1k-tdep.c: Fix includes.
3768         * mi/mi-main.c: Fix includes.
3769         * m32r-tdep.c: Fix includes.
3770         * csky-tdep.c: Fix includes.
3771         * compile/compile-cplus-types.c: Fix includes.
3772         * cli/cli-interp.c: Fix includes.
3773
3774 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
3775
3776         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3777         for padding.
3778
3779 2019-01-16  Tom Tromey  <tom@tromey.com>
3780
3781         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
3782         earlier.
3783         (struct objfile) <msymbols_range>: Move from top level.
3784         <msymbols>: New method.
3785         (class objfile_msymbols): Remove.
3786         * symtab.c (default_collect_symbol_completion_matches_break_on):
3787         Update.
3788         * symmisc.c (dump_msymbols): Update.
3789         * stabsread.c (scan_file_globals): Update.
3790         * objc-lang.c (info_selectors_command, info_classes_command)
3791         (find_methods): Update.
3792         * minsyms.c (find_solib_trampoline_target): Update.
3793         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
3794         * coffread.c (coff_symfile_read): Update.
3795         * ada-lang.c (ada_lookup_simple_minsym)
3796         (ada_collect_symbol_completion_matches): Update.
3797
3798 2019-01-16  Tom Tromey  <tom@tromey.com>
3799
3800         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
3801         type.  Remove no-argument constructor.
3802         <iterator::operator++>: Simplify.
3803         <begin>: Update.
3804         <end>: Use minimal_symbol_count.
3805
3806 2019-01-16  Tom Tromey  <tom@tromey.com>
3807
3808         * objfiles.h (struct objfile) <psymtabs>: New method.
3809         (class objfile_psymtabs): Remove.
3810         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
3811         typedef.
3812         <range>: New method.
3813         (require_partial_symbols): Change return type.
3814         * psymtab.c (require_partial_symbols)
3815         (psym_expand_symtabs_matching): Update.
3816         * mdebugread.c (parse_partial_symbols): Update.
3817         * dbxread.c (dbx_end_psymtab): Update.
3818
3819 2019-01-15  Tom Tromey  <tom@tromey.com>
3820
3821         * symtab.c (lookup_objfile_from_block)
3822         (lookup_symbol_in_objfile_symtabs)
3823         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
3824         (find_line_symtab, info_sources_command)
3825         (default_collect_symbol_completion_matches_break_on)
3826         (make_source_files_completion_list): Update.
3827         * symmisc.c (print_objfile_statistics, dump_objfile)
3828         (maintenance_print_symbols, maintenance_info_symtabs)
3829         (maintenance_check_symtabs, maintenance_info_line_tables):
3830         Update.
3831         * source.c (select_source_symtab)
3832         (forget_cached_source_info_for_objfile): Update.
3833         * objfiles.h (class objfile_compunits): Remove.
3834         (struct objfile) <compunits_range>: New typedef.
3835         (compunits): New method.
3836         * objfiles.c (objfile_relocate1): Update.
3837         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3838         * maint.c (count_symtabs_and_blocks): Update.
3839         * linespec.c (iterate_over_all_matching_symtabs): Update.
3840         * cp-support.c (add_symbol_overload_list_qualified): Update.
3841         * coffread.c (coff_symtab_read): Update.
3842         * ada-lang.c (add_nonlocal_symbols)
3843         (ada_collect_symbol_completion_matches)
3844         (ada_add_global_exceptions): Update.
3845
3846 2019-01-15  Tom Tromey  <tom@tromey.com>
3847
3848         * progspace.h (program_space) <objfiles_safe_range>: New
3849         typedef.
3850         <objfiles_safe>: New method.
3851         * objfiles.h (class all_objfiles_safe): Remove.
3852         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
3853         * jit.c (jit_inferior_exit_hook): Update.
3854
3855 2019-01-17  Tom Tromey  <tom@tromey.com>
3856
3857         * progspace.h (program_space) <objfiles_range>: New typedef.
3858         <objfiles>: New method.
3859         <objfiles_head>: Rename from objfiles.
3860         (object_files): Update.
3861         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
3862         * guile/scm-pretty-print.c
3863         (ppscm_find_pretty_printer_from_objfiles): Update.
3864         * guile/scm-objfile.c (gdbscm_objfiles): Update.
3865         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
3866         Update.
3867         * python/py-progspace.c (pspy_get_objfiles): Update.
3868         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3869         Update.
3870         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3871         (objfpy_lookup_objfile_by_build_id): Update.
3872         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3873         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3874         Update.
3875         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3876         (expand_symtab_containing_pc, lookup_objfile_from_block)
3877         (lookup_static_symbol, basic_lookup_transparent_type)
3878         (find_pc_sect_compunit_symtab, find_symbol_at_address)
3879         (find_line_symtab, info_sources_command)
3880         (default_collect_symbol_completion_matches_break_on)
3881         (make_source_files_completion_list, find_main_name): Update.
3882         * symmisc.c (print_symbol_bcache_statistics)
3883         (print_objfile_statistics, maintenance_print_symbols)
3884         (maintenance_print_msymbols, maintenance_print_objfiles)
3885         (maintenance_info_symtabs, maintenance_check_symtabs)
3886         (maintenance_expand_symtabs, maintenance_info_line_tables):
3887         Update.
3888         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
3889         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
3890         (map_overlay_command, unmap_overlay_command)
3891         (simple_overlay_update, expand_symtabs_matching)
3892         (map_symbol_filenames): Update.
3893         * symfile-debug.c (set_debug_symfile): Update.
3894         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3895         Update.
3896         * source.c (select_source_symtab, forget_cached_source_info):
3897         Update.
3898         * solib.c (solib_read_symbols): Update.
3899         * solib-spu.c (append_ocl_sos): Update.
3900         * psymtab.c (maintenance_print_psymbols)
3901         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3902         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3903         * printcmd.c (info_symbol_command): Update.
3904         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3905         Update.
3906         * objfiles.h (class all_objfiles): Remove.
3907         * objfiles.c (have_partial_symbols, have_full_symbols)
3908         (have_minimal_symbols, qsort_cmp, update_section_map)
3909         (shared_objfile_contains_address_p)
3910         (default_iterate_over_objfiles_in_search_order): Update.
3911         * objc-lang.c (info_selectors_command, info_classes_command)
3912         (find_methods): Update.
3913         * minsyms.c (find_solib_trampoline_target): Update.
3914         * maint.c (maintenance_info_sections)
3915         (maintenance_translate_address, count_symtabs_and_blocks):
3916         Update.
3917         * main.c (captured_main_1): Update.
3918         * linux-thread-db.c (try_thread_db_load_from_pdir)
3919         (has_libpthread): Update.
3920         * linespec.c (iterate_over_all_matching_symtabs)
3921         (search_minsyms_for_name): Update.
3922         * jit.c (jit_find_objf_with_entry_addr): Update.
3923         * hppa-tdep.c (find_unwind_entry)
3924         (hppa_lookup_stub_minimal_symbol): Update.
3925         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3926         Update.
3927         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3928         (elf_gnu_ifunc_resolve_by_got): Update.
3929         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3930         * dwarf-index-write.c (save_gdb_index_command): Update.
3931         * cp-support.c (add_symbol_overload_list_qualified): Update.
3932         * breakpoint.c (create_overlay_event_breakpoint)
3933         (create_longjmp_master_breakpoint)
3934         (create_std_terminate_master_breakpoint)
3935         (create_exception_master_breakpoint): Update.
3936         * blockframe.c (find_pc_partial_function): Update.
3937         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3938         (ada_collect_symbol_completion_matches)
3939         (ada_add_global_exceptions): Update.
3940
3941 2019-01-17  Tom Tromey  <tom@tromey.com>
3942
3943         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3944         declare VEC.
3945         (solib_target_parse_libraries): Change return type.
3946         (library_list_start_segment, library_list_start_section)
3947         (library_list_end_library, library_list_start_library); Update.
3948         (solib_target_free_library_list): Remove.
3949         (solib_target_parse_libraries): Remove cleanup.  Change return
3950         type.
3951         (solib_target_current_sos): Update.
3952
3953 2019-01-17  Tom Tromey  <tromey@bapiya>
3954
3955         * valprint.c: Replace "the the" with "the".
3956         * symtab.c: Replace "the the" with "the".
3957         * solib.c: Replace "the the" with "the".
3958         * solib-dsbt.c: Replace "the the" with "the".
3959         * linespec.c: Replace "the the" with "the".
3960         * dwarf2loc.h: Replace "the the" with "the".
3961         * amd64-windows-tdep.c: Replace "the the" with "the".
3962         * aarch64-tdep.c: Replace "the the" with "the".
3963
3964 2019-01-16  Keith Seitz  <keiths@redhat.com>
3965
3966         PR gdb/23773
3967         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3968         <builder>: Rename to ..
3969         <m_builder>: ... this and make private.
3970         (dwarf2_cu::get_builder): New method.  Change all users of
3971         `builder' to use this method.
3972         (dwarf2_start_symtab): Move to ...
3973         (dwarf2_cu::start_symtab): ... here.  Update all callers
3974         (setup_type_unit_groups): Move to ...
3975         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3976         callers.
3977         (dwarf2_cu::reset_builder): New method.
3978         (process_full_compunit, process_full_type_unit): Use
3979         dwarf2_cu::reset_builder.
3980         (follow_die_offset): Record the ancestor CU if it is different
3981         from the followed DIE's CU.
3982         (follow_die_sig_1): Likewise.
3983
3984 2019-01-15  Tom Tromey  <tom@tromey.com>
3985
3986         * remote.c (class remote_state) <buf>: Now a char_vector.
3987         <buf_size>: Remove.
3988         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3989         parameter.
3990         (remote_target::getpkt_or_notif_sane_1)
3991         (remote_target::getpkt_sane)
3992         (remote_target::getpkt_or_notif_sane): Likewise.
3993         (class remote_target) <putpkt>: New overload.
3994         (remote_target::read_frame): Change type of "buf_p".  Remove
3995         sizeof_p parameter.
3996         (packet_ok): New overload.
3997         (packet_check_result): New overload.
3998         Update all uses.
3999
4000 2019-01-14  Tom Tromey  <tom@tromey.com>
4001
4002         * remote-notif.c (handle_notification, remote_notif_ack)
4003         (remote_notif_parse): Make "buf" const.
4004         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4005         const.
4006         (remote_notif_parse, remote_notif_ack, handle_notification):
4007         Likewise.
4008         * remote.c (remote_notif_stop_parse): Make "buf" const.
4009         (remote_target::remote_parse_stop_reply): Make "buf" const.
4010         (remote_notif_stop_ack): Make "buf" const.
4011
4012 2019-01-14  Tom Tromey  <tom@tromey.com>
4013
4014         * remote.c (remote_console_output): Make parameter const.
4015
4016 2019-01-14  Tom Tromey  <tom@tromey.com>
4017
4018         * target-debug.h (target_debug_print_signals): Constify.
4019         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4020         * procfs.c (procfs_target::pass_signals): Update.
4021         * linux-nat.c (linux_nat_target::pass_signals): Update.
4022         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4023         * target-delegates.c: Rebuild.
4024         * remote.c (remote_target::program_signals): Update.
4025         (remote_target::pass_signals): Update.
4026         * target.c (target_pass_signals): Constify argument.
4027         (target_program_signals): Likewise.
4028         * target.h (struct target_ops) <pass_signals, program_signals>:
4029         Constify argument.
4030         (target_pass_signals, target_program_signals): Constify argument.
4031
4032 2019-01-14  Tom Tromey  <tom@tromey.com>
4033
4034         PR tui/28819:
4035         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4036
4037 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4038
4039         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4040         field.
4041         * rs6000-tdep.c: Include reggroups.h.
4042         (IS_V_ALIAS_PSEUDOREG): Define.
4043         (rs6000_register_name): Return names for the "vX" aliases.
4044         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4045         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4046         aliases.  Call default_register_reggroup_p for all other
4047         pseudo-registers.
4048         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4049         New functions.
4050         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4051         Handle "vX" aliases.
4052         (v_alias_pseudo_register_collect): New function.
4053         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4054         (rs6000_gdbarch_init): Initialize "vX" aliases as
4055         pseudo-registers.  Restore registration of
4056         rs6000_pseudo_register_reggroup_p with
4057         set_tdesc_pseudo_register_reggroup_p.
4058
4059 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4060
4061         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4062         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4063         set_gdbarch_num_pseudo_regs.
4064
4065 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4066
4067         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4068         Remove arg prefixname, add do_set and do_show.
4069         Add member functions set_list and show_list.
4070         * cli/cli-style.c (class cli_style_option): Update accordingly.
4071         (style_set_list): Move to file scope.
4072         (style_show_list): Likewise.
4073         (set_style): Call help_list.
4074         (show_style): Call cmd_show_list.
4075         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4076         Update to use the new macro.
4077
4078 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4079
4080         * ada-lang.c (_initialize_ada_language): Expand the help text
4081         for the "catch exception" command.
4082
4083 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4084
4085         * symtab.c (matching_obj_sections): Initialize obj,
4086         declare it closer to its usage.
4087
4088 2019-01-10  Tom Tromey  <tom@tromey.com>
4089
4090         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4091         (basic_inf_threads_range): Remove.
4092         (inf_threads_range, inf_non_exited_threads_range)
4093         (safe_inf_threads_range): Use next_adapter.
4094
4095 2019-01-10  Keith Seitz  <keiths@redhat.com>
4096
4097         PR gdb/23712
4098         PR symtab/23010
4099         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4100         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4101
4102 2019-01-10  Keith Seitz  <keiths@redhat.com>
4103
4104         PR gdb/23712
4105         PR symtab/23010
4106         * dictionary.c (pending_to_vector): Remove.
4107         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4108         Remove _1 suffix, replacing functions of the same name.  Update
4109         all callers.
4110         (dict_create_hashed, dict_create_hashed_expandable)
4111         (dict_create_linear, dict_create_linear_expandable, dict_free)
4112         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4113         Make functions static.
4114
4115 2019-01-10  Keith Seitz  <keiths@redhat.com>
4116
4117         PR gdb/23712
4118         PR symtab/23010
4119         * dictionary.h (struct dictionary): Replace declaration with
4120         multidictionary.
4121         (dict_create_hashed, dict_create_hashed_expandable)
4122         (dict_create_linear, dict_create_linear_expandable)
4123         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4124         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4125         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4126         taking multidictionary argument.
4127         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4128         * block.h (struct block) <dict>: Change to multidictionary
4129         and rename `multidict'.
4130         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4131         symmisc.c: Update all dictionary references to multidictionary.
4132
4133 2019-01-10  Keith Seitz  <keiths@redhat.com>
4134
4135         PR gdb/23712
4136         PR symtab/23010
4137         * dictionary.c: Include unordered_map.
4138         (pending_to_vector): New function.
4139         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4140         Rewrite the non-"_1" functions to take vector instead
4141         of linked list.
4142         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4143         "new" _1 versions of the same name.
4144         (multidictionary): Define.
4145         (std::hash<enum language): New definition.
4146         (collate_pending_symbols_by_language, mdict_create_hashed)
4147         (mdict_create_hashed_expandable, mdict_create_linear)
4148         (mdict_create_linear_expandable, mdict_free)
4149         (find_language_dictionary, create_new_language_dictionary)
4150         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4151         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4152         (mdict_size, mdict_empty): New functions.
4153         * dictionary.h (mdict_iterator): Define.
4154
4155 2019-01-10  Pedro Alves  <palves@redhat.com>
4156
4157         * breakpoint.c (read_uploaded_action)
4158         (create_tracepoint_from_upload): Adjust to use
4159         gdb::unique_xmalloc_ptr.
4160         * ctf.c (ctf_write_uploaded_tp):
4161         (SET_ARRAY_FIELD): Use emplace_back.
4162         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4163         * tracefile-tfile.c (tfile_write_uploaded_tp):
4164         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4165         gdb::unique_xmalloc_ptr.
4166         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4167         at_string, cond_string, cmd_strings>: Replace char pointers
4168         with gdb::unique_xmalloc_ptr.
4169
4170 2019-01-10  Pedro Alves  <palves@redhat.com>
4171
4172         * solib-target.c (library_list_start_library): Don't xstrdup name.
4173
4174 2019-01-10  Pedro Alves  <palves@redhat.com>
4175
4176         * mdebugread.c (parse_partial_symbols): Use
4177         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4178
4179 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4180
4181         * linux-fork.c (scoped_switch_fork_info)
4182         <~scoped_switch_fork_info>: Fix incorrect variable name.
4183
4184 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4185
4186         * linux-fork.c (scoped_switch_fork_info)
4187         <scoped_switch_fork_info>: Make explicit.
4188         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4189
4190 2019-01-10  Tom Tromey  <tom@tromey.com>
4191
4192         * objfiles.h (objfile::reset_psymtabs): Update.
4193         * objfiles.c (objfile::objfile): Update.
4194         * psymtab.h (psymtab_storage::obstack): Update.
4195         (psymtab_storage::m_obstack): Use gdb::optional.
4196         (class psymtab_storage): Update comment.  Remove objfile
4197         parameter.
4198         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4199
4200 2019-01-10  Tom Tromey  <tom@tromey.com>
4201
4202         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4203         <free_psymtabs>: Now private.
4204         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4205         (allocate_psymtab): Use new method.
4206
4207 2019-01-10  Tom Tromey  <tom@tromey.com>
4208
4209         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4210         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4211         * mdebugread.c (parse_partial_symbols): Use
4212         allocate_dependencies.
4213         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4214         allocate_dependencies.
4215         (process_psymtab_comp_unit_reader)
4216         (build_type_psymtab_dependencies): Likewise.
4217         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4218
4219 2019-01-10  Tom Tromey  <tom@tromey.com>
4220
4221         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4222         PSYMBOL_SET_LANGUAGE.
4223         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4224
4225 2019-01-10  Tom Tromey  <tom@tromey.com>
4226
4227         * psymtab.h (psymtab_storage::obstack): New method.
4228         <m_obstack>: Rename from obstack; now private.
4229         * psymtab.c (psymtab_storage): Update.
4230         * dwarf2read.c (create_addrmap_from_index)
4231         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4232         Update.
4233
4234 2019-01-10  Tom Tromey  <tom@tromey.com>
4235
4236         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4237         * objfiles.h (objfile::reset_psymtabs): New method.
4238
4239 2019-01-10  Tom Tromey  <tom@tromey.com>
4240
4241         * symmisc.c (print_symbol_bcache_statistics): Update.
4242         (print_objfile_statistics): Update.
4243         * symfile.c (reread_symbols): Update.
4244         * psymtab.h (class psymtab_storage): New.
4245         * psymtab.c (psymtab_storage): New constructor.
4246         (~psymtab_storage): New destructor.
4247         (require_partial_symbols): Update.
4248         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4249         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4250         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4251         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4252         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4253         (start_psymtab_common, end_psymtab_common)
4254         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4255         (allocate_psymtab): Update.
4256         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4257         Update.
4258         (dump_psymtab_addrmap, maintenance_print_psymbols)
4259         (maintenance_check_psymtabs): Update.
4260         (class objfile_psymtabs): Move to objfiles.h.
4261         * psympriv.h (discard_psymtab): Now inline.
4262         (psymtab_discarder::psymtab_discarder): Update.
4263         (psymtab_discarder::~psymtab_discarder): Update.
4264         (ALL_OBJFILE_PSYMTABS): Rewrite.
4265         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4266         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4267         Remove fields.
4268         <partial_symtabs>: New field.
4269         (class objfile_psymtabs): Move from psymtab.h.  Update.
4270         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4271         psymbol_cache.
4272         (objfile::~objfile): Don't destroy psymbol_cache.
4273         * mdebugread.c (parse_partial_symbols): Update.
4274         * dwarf2read.c (create_addrmap_from_index)
4275         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4276         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4277         (add_partial_subprogram, dwarf2_ranges_read): Update.
4278         * dwarf-index-write.c (write_address_map)
4279         (write_one_signatured_type, recursively_write_psymbols)
4280         (class debug_names, class debug_names, write_psymtabs_to_index):
4281         Update.
4282
4283 2019-01-10  Tom Tromey  <tom@tromey.com>
4284
4285         * symtab.h (SYMBOL_SET_NAMES): Update.
4286         (symbol_set_names): Update.
4287         (MSYMBOL_SET_NAMES): Update.
4288         * symtab.c (symbol_set_names): Change argument to be an
4289         objfile_per_bfd_storage.
4290         * psymtab.c (add_psymbol_to_bcache): Update.
4291         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4292
4293 2019-01-10  Tom Tromey  <tom@tromey.com>
4294
4295         * symtab.c (create_demangled_names_hash): Change argument to be an
4296         objfile_per_bfd_storage.
4297         (symbol_set_names): Update.
4298
4299 2019-01-10  Tom Tromey  <tom@tromey.com>
4300
4301         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4302         init_psymbol_list.
4303         * psymtab.c (init_psymbol_list): Do nothing if already called.
4304         * psympriv.h (init_psymbol_list): Add comment.
4305         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4306         init_psymbol_list.
4307         * dbxread.c (dbx_symfile_read): Unconditionally call
4308         init_psymbol_list.
4309
4310 2019-01-10  Tom Tromey  <tom@tromey.com>
4311
4312         * xcoffread.c (scan_xcoff_symtab): Update.
4313         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4314         "where".
4315         * mdebugread.c (parse_partial_symbols)
4316         (handle_psymbol_enumerators): Update.
4317         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4318         * dbxread.c (read_dbx_symtab): Update.
4319         * psympriv.h (psymbol_placement): New enum.
4320         (add_psymbol_to_list): Update.
4321
4322 2019-01-10  Tom Tromey  <tom@tromey.com>
4323
4324         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4325         static_psymbols parameters.
4326         (scan_xcoff_symtab): Update.
4327         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4328         static_psymbols parameters.
4329         * psympriv.h (start_psymtab_common): Update.
4330         * mdebugread.c (parse_partial_symbols): Update.
4331         * dwarf2read.c (create_partial_symtab): Update.
4332         * dbxread.c (read_dbx_symtab): Update.
4333         (start_psymtab): Remove global_psymbols and static_psymbols
4334         parameters.
4335
4336 2019-01-10  Tom Tromey  <tom@tromey.com>
4337
4338         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4339         * psymtab.c (allocate_psymtab): Add comment.
4340         * psympriv.h (allocate_psymtab): Add comment.
4341         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4342         initializations.
4343         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4344
4345 2019-01-10  Tom Tromey  <tom@tromey.com>
4346
4347         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4348         Don't declare.
4349         * mipsread.c: Include mdebugread.h.
4350         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4351         Declare.
4352         * elfread.c: Include mdebugread.h.
4353
4354 2019-01-09  Tom Tromey  <tom@tromey.com>
4355
4356         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4357         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4358         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4359         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4360         (psym_lookup_symbol, psym_find_last_source_symtab)
4361         (psym_forget_cached_source_info, psym_print_stats)
4362         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4363         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4364         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4365         (psym_find_compunit_symtab_by_address)
4366         (maintenance_print_psymbols, maintenance_info_psymtabs)
4367         (maintenance_check_psymtabs): Use ranged for.
4368         * psymtab.h (class objfile_psymtabs): New.
4369         (require_partial_symbols): Return objfile_psymtabs.
4370         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4371
4372 2019-01-09  Tom Tromey  <tom@tromey.com>
4373
4374         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4375         (find_pc_mapped_section, list_overlays_command)
4376         (map_overlay_command, unmap_overlay_command)
4377         (simple_overlay_update): Use all_objfiles.
4378         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4379         * printcmd.c (info_symbol_command): Use all_objfiles.
4380         * objfiles.h (ALL_OBJSECTIONS): Remove.
4381         * maint.c (maintenance_translate_address): Use all_objfiles.
4382         * gcore.c (gcore_create_callback): Use all_objfiles.
4383         (objfile_find_memory_regions): Likewise.
4384
4385 2019-01-09  Tom Tromey  <tom@tromey.com>
4386
4387         * symtab.c (find_line_symtab, info_sources_command)
4388         (make_source_files_completion_list): Use objfile_compunits.
4389         * source.c (select_source_symtab): Use objfile_compunits.
4390         * objfiles.h (struct objfile): Update comment.
4391         (ALL_OBJFILES): Remove.
4392         (ALL_FILETABS): Remove.
4393         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4394         objfile_compunits.
4395
4396 2019-01-09  Tom Tromey  <tom@tromey.com>
4397
4398         * symmisc.c (print_objfile_statistics, dump_objfile)
4399         (maintenance_print_symbols): Use compunit_filetabs.
4400         * source.c (forget_cached_source_info_for_objfile): Use
4401         compunit_filetabs.
4402         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4403         (ALL_FILETABS): Use compunit_filetabs.
4404         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4405         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4406
4407 2019-01-09  Tom Tromey  <tom@tromey.com>
4408
4409         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4410         (compunit_filetabs): New.
4411         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4412         compunit_filetabs.
4413         (info_sources_command, make_source_files_completion_list): Remove
4414         declaration.
4415         * symmisc.c (print_objfile_statistics, dump_objfile)
4416         (maintenance_print_symbols): Remove declaration.
4417         (maintenance_info_symtabs): Use compunit_filetabs.
4418         (maintenance_info_line_tables): Likewise.
4419         * source.c (select_source_symtab): Change local variable name.
4420         (forget_cached_source_info_for_objfile): Remove declaration.
4421         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4422         * objfiles.c (objfile_relocate1): Remove declaration.
4423         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4424         declaration.
4425         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4426         * coffread.c (coff_symtab_read): Remove declaration.
4427         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4428         compunit_filetabs.
4429
4430 2019-01-09  Tom Tromey  <tom@tromey.com>
4431
4432         * symtab.c (lookup_objfile_from_block)
4433         (find_pc_sect_compunit_symtab, search_symbols)
4434         (default_collect_symbol_completion_matches_break_on): Use
4435         objfile_compunits.
4436         * objfiles.h (ALL_COMPUNITS): Remove.
4437         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4438         * cp-support.c (add_symbol_overload_list_qualified): Use
4439         objfile_compunits.
4440         * ada-lang.c (ada_collect_symbol_completion_matches)
4441         (ada_add_global_exceptions): Use objfile_compunits.
4442
4443 2019-01-09  Tom Tromey  <tom@tromey.com>
4444
4445         * source.c (select_source_symtab)
4446         (forget_cached_source_info_for_objfile): Remove declaration.
4447         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4448         declaration.
4449         * maint.c (count_symtabs_and_blocks): Remove declaration.
4450         * cp-support.c (add_symbol_overload_list_qualified): Remove
4451         declaration.
4452         * coffread.c (coff_symtab_read): Remove declaration.
4453         * symtab.c (lookup_symbol_in_objfile_symtabs)
4454         (basic_lookup_transparent_type_1): Use objfile_compunits.
4455         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4456         (info_sources_command, search_symbols)
4457         (default_collect_symbol_completion_matches_break_on)
4458         (make_source_files_completion_list): Remove declaration.
4459         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4460         (ada_collect_symbol_completion_matches)
4461         (ada_add_global_exceptions): Remove declaration.
4462         * linespec.c (iterate_over_all_matching_symtabs): Use
4463         objfile_compunits.
4464         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4465         (class objfile_compunits): New.
4466         (ALL_COMPUNITS): Use objfile_compunits.
4467         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4468         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4469         objfile_compunits.
4470         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4471
4472 2019-01-09  Tom Tromey  <tom@tromey.com>
4473
4474         * symtab.c (search_symbols)
4475         (default_collect_symbol_completion_matches_break_on): Use
4476         objfile_msymbols.
4477         * ada-lang.c (ada_lookup_simple_minsym)
4478         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4479         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4480         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4481         objfile_msymbols.
4482         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4483         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4484         * objc-lang.c (find_methods): Use objfile_msymbols.
4485         (info_selectors_command, info_classes_command): Likewise.
4486         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4487         * objfiles.h (class objfile_msymbols): New.
4488         (ALL_OBJFILE_MSYMBOLS): Remove.
4489         (ALL_MSYMBOLS): Remove.
4490
4491 2019-01-09  Tom Tromey  <tom@tromey.com>
4492
4493         * common/next-iterator.h (next_adapter): Add Iterator template
4494         parameter.
4495         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4496         (class all_objfiles_safe): New.
4497         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4498         * objfiles.c (put_objfile_before): Update comment.
4499         (add_separate_debug_objfile): Likewise.
4500         (free_all_objfiles): Use all_objfiles_safe.
4501         (objfile_purge_solibs): Likewise.
4502
4503 2019-01-09  Tom Tromey  <tom@tromey.com>
4504
4505         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4506         (expand_symtab_containing_pc, lookup_static_symbol)
4507         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4508         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4509         all_objfiles.
4510         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4511         * breakpoint.c (create_overlay_event_breakpoint)
4512         (create_longjmp_master_breakpoint)
4513         (create_std_terminate_master_breakpoint)
4514         (create_exception_master_breakpoint): Use all_objfiles.
4515         * linux-thread-db.c (try_thread_db_load_from_pdir)
4516         (has_libpthread): Use all_objfiles.
4517         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4518         * linespec.c (iterate_over_all_matching_symtabs)
4519         (search_minsyms_for_name): Use all_objfiles.
4520         * maint.c (maintenance_info_sections): Use all_objfiles.
4521         * main.c (captured_main_1): Use all_objfiles.
4522         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4523         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4524         * guile/scm-pretty-print.c
4525         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4526         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4527         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4528         (maintenance_print_msymbols): Use all_objfiles.
4529         * source.c (select_source_symtab): Use all_objfiles.
4530         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
4531         * symfile.c (remove_symbol_file_command)
4532         (expand_symtabs_matching, map_symbol_filenames): Use
4533         all_objfiles.
4534         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
4535         all_objfiles.
4536         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
4537         * objc-lang.c (find_methods): Use all_objfiles.
4538         * objfiles.c (have_partial_symbols, have_full_symbols)
4539         (have_minimal_symbols, qsort_cmp)
4540         (default_iterate_over_objfiles_in_search_order): Use
4541         all_objfiles.
4542         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
4543         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
4544         (maintenance_check_psymtabs): Use all_objfiles.
4545         (ALL_PSYMTABS): Remove.
4546         * compile/compile-object-run.c (do_module_cleanup): Use
4547         all_objfiles.
4548         * blockframe.c (find_pc_partial_function): Use all_objfiles.
4549         * cp-support.c (add_symbol_overload_list_qualified): Use
4550         all_objfiles.
4551         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4552         Use all_objfiles.
4553         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
4554         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
4555         all_objfiles.
4556         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4557         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
4558         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4559         Uses all_objfiles.
4560         * solib.c (solib_read_symbols): Use all_objfiles
4561
4562 2019-01-09  Tom Tromey  <tom@tromey.com>
4563
4564         * probe.c (parse_probes_in_pspace): Use all_objfiles.
4565         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
4566         all_objfiles.
4567         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
4568         * symmisc.c (print_symbol_bcache_statistics)
4569         (print_objfile_statistics, maintenance_print_objfiles)
4570         (maintenance_info_symtabs, maintenance_check_symtabs)
4571         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
4572         all_objfiles.
4573         * source.c (forget_cached_source_info): Use all_objfiles.
4574         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
4575         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4576         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
4577         * objfiles.c (update_section_map): Use all_objfiles.
4578         (shared_objfile_contains_address_p): Likewise.
4579         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
4580         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
4581
4582 2019-01-09  Tom Tromey  <tom@tromey.com>
4583
4584         * common/next-iterator.h: New file.
4585         * objfiles.h (class all_objfiles): New.
4586         (struct objfile_iterator): New.
4587
4588 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4589
4590         * NEWS: Move the description of the changed "frame", "select-frame",
4591          and "info frame" commands to the Changed commands section.
4592
4593 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
4594
4595         * gdbtypes.c (check_stub_method_group): Remove handling of old
4596         mangling schemes.
4597         * linespec.c (find_methods): Likewise.
4598         * stabsread.c (read_member_functions): Likewise.
4599         * valops.c (search_struct_method): Likewise.
4600         (value_struct_elt_for_reference): Likewise.
4601         * NEWS: Mention this change.
4602
4603 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4604
4605         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
4606         print_source_lines.
4607         * source.c (print_source_lines_base): Update line number check.
4608         (print_source_lines): New function.
4609         (source_lines_range::source_lines_range): New function.
4610         * source.h (class source_lines_range): New class.
4611         (print_source_lines): New declaration.
4612
4613 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4614
4615         * linespec.c (linespec_state_destructor): Free self->canonical_names.
4616
4617 2019-01-08  Tom Tromey  <tom@tromey.com>
4618             Simon Marchi  <simon.marchi@ericsson.com>
4619
4620         PR gdb/24060
4621         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
4622         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
4623         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4624         * f-exp.y (DOLLAR_VARIABLE): Likewise.
4625         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
4626         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4627
4628 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4629
4630         * source.c (select_source_symtab): Move header comment to
4631         declaration in source.h.
4632         (forget_cached_source_info_for_objfile): Likewise.
4633         (forget_cached_source_info): Likewise.
4634         (identify_source_line): Likewise.
4635         * source.h (identify_source_line): Move declaration from symtab.h
4636         and add comment from source.c
4637         (print_source_lines): Likewise.
4638         (forget_cached_source_info_for_objfile): Likewise.
4639         (forget_cached_source_info): Likewise.
4640         (select_source_symtab): Likewise.
4641         (enum print_source_lines_flag): Move definition from symtab.h.
4642         * symtab.h (identify_source_line): Move declaration to source.h.
4643         (print_source_lines): Likewise.
4644         (forget_cached_source_info_for_objfile): Likewise.
4645         (forget_cached_source_info): Likewise.
4646         (select_source_symtab): Likewise.
4647         (enum print_source_lines_flag): Move definition to source.h.
4648         * tui/tui-hooks.c: Add 'source.h' include.
4649
4650 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4651
4652         * source.c (print_source_lines_base): Handle requests to print
4653         reverse line number sequences, and guard against empty lines
4654         string.
4655
4656 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4657
4658         * source.c (print_source_lines_base): Fix skip of '\r' if next
4659         character is '\n'.
4660
4661 2019-01-06  Tom Tromey  <tom@tromey.com>
4662
4663         * c-exp.y (struct c_parse_state) <macro_original_text,
4664         expansion_obstack>: New member.
4665         (macro_original_text, expansion_obstack): Remove globals.
4666         (scan_macro_expansion, scanning_macro_expansion)
4667         (finished_macro_expansion): Update.
4668         (scan_macro_cleanup): Remove.
4669         (yylex, c_parse): Update.
4670
4671 2019-01-06  Tom Tromey  <tom@tromey.com>
4672
4673         * c-exp.y (struct c_parse_state) <strings>: New member.
4674         (operator_stoken): Update.
4675
4676 2019-01-06  Tom Tromey  <tom@tromey.com>
4677
4678         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
4679         (union type_stack_elt) <typelist_val>: Now a pointer to
4680         std::vector.
4681         (type_stack_cleanup): Don't declare.
4682         (push_typelist): Update.
4683         * parse.c (pop_typelist): Return a std::vector.
4684         (push_typelist): Take a std::vector.
4685         (follow_types): Update.  Do not free args.
4686         (type_stack_cleanup): Remove.
4687         * c-exp.y (struct c_parse_state): New.
4688         (cpstate): New global.
4689         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
4690         (nonempty_typelist): Update.
4691         (func_mod): Create a new vector.
4692         (c_parse): Create a c_parse_state.
4693         (check_parameter_typelist): Do not delete params.
4694         (function_method): Update.  Do not delete type_list.
4695
4696 2019-01-06  Tom Tromey  <tom@tromey.com>
4697
4698         PR gdb/28155:
4699         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
4700         check_typedef.
4701         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
4702         (print_return_value): Likewise.
4703
4704 2019-01-05  Tom Tromey  <tom@tromey.com>
4705
4706         * contrib/cleanup_check.py: Remove.
4707         * contrib/gcc-with-excheck: Remove.
4708         * contrib/exsummary.py: Remove.
4709         * contrib/excheck.py: Remove.
4710
4711 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
4712
4713         * thread.c (delete_thread_1): Add gdb_assert that THR is not
4714         NULL. Initialize tpprev to NULL instead of assigning it
4715         to NULL on the next statement.
4716         * windows-nat.c (windows_delete_thread): Remove check for
4717         main_thread_id before printing thread exit notifications.
4718         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
4719         Remove thread ID check against main_thread_id.
4720         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
4721         windows_delete_thread.
4722         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
4723
4724 2019-01-04  Tom Tromey  <tom@tromey.com>
4725
4726         * compile/compile.c (_initialize_compile): Use upper case for
4727         metasyntactic variables.
4728         * symmisc.c (_initialize_symmisc): Use upper case for
4729         metasyntactic variables.
4730         * psymtab.c (_initialize_psymtab): Use upper case for
4731         metasyntactic variables.
4732         * demangle.c (demangle_command): Use upper case for metasyntactic
4733         variables.
4734         (_initialize_demangler): Likewise.
4735         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
4736         variables.
4737
4738 2019-01-03  Tom Tromey  <tom@tromey.com>
4739
4740         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
4741
4742 2019-01-03  Tom Tromey  <tom@tromey.com>
4743
4744         * python/py-symtab.c (salpy_str): Update.
4745         (struct salpy_sal_object) <symtab>: Now a PyObject.
4746         (salpy_dealloc): Update.
4747         (del_objfile_sal): Use gdbpy_ref.
4748
4749 2019-01-03  Tom Tromey  <tom@tromey.com>
4750
4751         * python/py-type.c (convert_field): Use new_reference.  Return
4752         gdbpy_ref.
4753         (make_fielditem): Return gdbpy_ref.
4754         (typy_fields): Update.
4755         (typy_getitem): Update.
4756         (field_name): Return gdbpy_ref.  Use new_reference.
4757         (typy_iterator_iternext): Update.
4758
4759 2019-01-03  Tom Tromey  <tom@tromey.com>
4760
4761         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
4762
4763 2019-01-03  Tom Tromey  <tom@tromey.com>
4764
4765         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
4766         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
4767         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
4768         (pspy_set_frame_filters, pspy_set_frame_unwinders)
4769         (pspy_set_type_printers): Likewise.
4770         * python/py-function.c (fnpy_init): Use gdbpy_ref.
4771         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
4772         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
4773         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
4774         (objfpy_set_type_printers): Likewise.
4775
4776 2019-01-03  Tom Tromey  <tom@tromey.com>
4777
4778         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
4779         (gdbpy_print_stack): Use gdbpy_err_fetch.
4780         * python/python-internal.h (class gdbpy_err_fetch): New class.
4781         (class gdbpy_enter) <m_error_type, m_error_value,
4782         m_error_traceback>: Remove.
4783         <m_error>: New member.
4784         (gdbpy_exception_to_string): Don't declare.
4785         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
4786         * python/py-value.c (convert_value_from_python): Use
4787         gdbpy_err_fetch.
4788         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
4789         gdbpy_exception_to_string.
4790         (gdbpy_handle_exception): Use gdbpy_err_fetch.
4791         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
4792         gdbpy_err_fetch.
4793
4794 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4795
4796         * linux-nat.c (delete_lwp_cleanup): Delete.
4797         (struct lwp_deleter): New struct.
4798         (lwp_info_up): New typedef.
4799         (linux_nat_target::follow_fork): Delete cleanup, and make use of
4800         lwp_info_up.
4801
4802 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4803
4804         * linux-fork.c (class scoped_switch_fork_info): New class.
4805         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
4806
4807 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4808
4809         * valops.c (find_overload_match): Remove use of null_cleanup, and
4810         calls to do_cleanups.
4811
4812 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4813
4814         * compile/compile-cplus-types.c
4815         (compile_cplus_instance::decl_name): Handle changes to
4816         cp_func_name.
4817         * cp-support.c (cp_func_name): Update header comment, update
4818         return type.
4819         * cp-support.h (cp_func_name): Update return type in declaration.
4820         * valops.c (find_overload_match): Move temp_func local to top
4821         level of function and change its type.  Use temp_func to hold and
4822         delete temporary string obtained from cp_func_name.
4823
4824 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4825
4826         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
4827         gdb::char_vector, remove cleanup, and update uses of `msg`.
4828
4829 2019-01-03  Jim Wilson  <jimw@sifive.com>
4830
4831         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
4832
4833 2019-01-02  Tom Tromey  <tom@tromey.com>
4834
4835         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
4836         (tdesc_parse_xml): Remove cleanups.
4837         * target-descriptions.h (make_cleanup_free_target_description):
4838         Don't declare.
4839         (target_desc_deleter): New struct.
4840         (target_desc_up): New typedef.
4841         * target-descriptions.c (target_desc_deleter::operator()): Rename
4842         from free_target_description.
4843         (make_cleanup_free_target_description): Remove.
4844
4845 2019-01-02  Tom Tromey  <tom@tromey.com>
4846
4847         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
4848         constructor, destructor.
4849         (linespec_parser): Remove typedef.
4850         (~linespec_parser): Rename from linespec_parser_delete.
4851         (linespec_lex_to_end, linespec_complete_label)
4852         (linespec_complete): Update.
4853         (decode_line_full): Remove cleanups.
4854         (decode_line_1): Update.
4855
4856 2019-01-02  Tom Tromey  <tom@tromey.com>
4857
4858         * python/python-internal.h (inferior_to_inferior_object): Change
4859         return type.
4860         * python/py-exitedevent.c (create_exited_event_object): Update.
4861         * python/py-inferior.c (inferior_to_inferior_object): Return
4862         gdbpy_ref.
4863         (python_new_inferior, python_inferior_deleted)
4864         (thread_to_thread_object, delete_thread_object)
4865         (build_inferior_list, gdbpy_selected_inferior): Update.
4866         * python/py-infthread.c (create_thread_object): Update.  Also fail
4867         if inferior_to_inferior_object fails.
4868
4869 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
4870
4871         * inferior.h (class inferior) <displaced_step_state>: New field.
4872         * infrun.h (struct displaced_step_state): Move here from
4873         infrun.c.  Initialize fields, add constructor.
4874         <inf>: Remove field.
4875         <reset>: New method.
4876         * infrun.c (struct displaced_step_inferior_state): Move to
4877         infrun.h.
4878         (displaced_step_inferior_states): Remove.
4879         (get_displaced_stepping_state): Adust.
4880         (displaced_step_in_progress_any_inferior): Adjust.
4881         (displaced_step_in_progress_thread): Adjust.
4882         (displaced_step_in_progress): Adjust.
4883         (add_displaced_stepping_state): Remove.
4884         (get_displaced_step_closure_by_addr): Adjust.
4885         (remove_displaced_stepping_state): Remove.
4886         (infrun_inferior_exit): Call displaced_step_state.reset.
4887         (use_displaced_stepping): Don't check for NULL.
4888         (displaced_step_prepare_throw): Call
4889         get_displaced_stepping_state.
4890         (displaced_step_fixup): Don't check for NULL.
4891         (prepare_for_detach): Don't check for NULL.
4892
4893 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4894
4895         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4896          in case of call that did not complete.
4897
4898 2019-01-02  Andrey Utkin  <autkin@undo.io>
4899
4900         * symfile.c (find_separate_debug_file): Fix search of debug files for
4901         remote debuggee.
4902
4903 2019-01-02  Tom Tromey  <tom@tromey.com>
4904
4905         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4906         indentation.
4907         * python/py-frame.c (frapy_older): Remove cast.
4908         (frapy_newer): Likewise.
4909         * python/py-breakpoint.c (local_setattro): Remove cast.
4910         * python/py-arch.c (archpy_name): Remove local variable.
4911         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4912
4913 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4914
4915         * unittests/basic_string_view/element_access/char/empty.cc:
4916         Fix year range in copyright header.
4917
4918 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4919
4920         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4921         Delete.
4922         <operator==>: Update with for removed field.
4923         <hash>: Likewise.
4924         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4925         <isa_features>: ...this.
4926         <abi_features>: New field.
4927         (riscv_isa_flen): Update comment.
4928         (riscv_abi_xlen): New declaration.
4929         (riscv_abi_flen): New declaration.
4930         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4931         isa_features.
4932         (riscv_abi_xlen): New function.
4933         (riscv_isa_flen): Update to get answer from isa_features.
4934         (riscv_abi_flen): New function.
4935         (riscv_has_fp_abi): Update to get answer from abi_features.
4936         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4937         xlen and flen.
4938         (riscv_call_info) <xlen, flen>: Update comment.
4939         (riscv_call_arg_struct): Remove invalid assertions
4940         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4941         is removed.
4942         (riscv_gdbarch_init): Gather isa features and abi features
4943         separately, ensure both match on the gdbarch when reusing an old
4944         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4945         a target with 64-bit float hardware.
4946
4947 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4948
4949         * source.c (search_command_helper): Stop reverse search
4950         when line 1 has been searched.
4951
4952 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4953
4954         * record-full.c (record_full_base_target::close): Rewrite
4955         record_full_core_buf_list free logic.
4956
4957 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4958
4959         * break-catch-syscall.c (print_one_catch_syscall): xfree
4960         the last text.
4961
4962 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4963
4964         * top.c (print_gdb_version): Update Copyright year in version
4965         message.
4966
4967 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4968
4969         Update copyright year range in all GDB files.
4970
4971 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4972
4973         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4974
4975 For older changes see ChangeLog-2018.
4976 \f
4977 Local Variables:
4978 mode: change-log
4979 left-margin: 8
4980 fill-column: 74
4981 version-control: never
4982 coding: utf-8
4983 End:
4984