gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.c (tui_clear_source_content)
   4         (tui_show_source_content, tui_show_exec_info_content)
   5         (tui_clear_exec_info_content): Update.
   6         * tui/tui-stack.c (tui_show_locator_content): Update.
   7         (tui_show_frame_info): Update.
   8         * tui/tui-source.h (tui_source_window): Don't declare.
   9         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
  10         from tui_source_is_displayed.
  11         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
  12         Remove field.
  13         (struct tui_source_window_base) <content_in_use>: New field.  Now
  14         bool.
  15         (struct tui_source_window) <showing_source_p>: New method.
  16         (TUI_SRC_WIN): Change cast.
  17         * tui/tui-data.c (tui_initialize_static_data): Update.
  18
  19 2019-07-17  Tom Tromey  <tom@tromey.com>
  20
  21         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
  22         location_matches_p.
  23         * tui/tui-source.c (tui_source_window::location_matches_p): New
  24         method.
  25         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
  26         method.
  27         * tui/tui-data.h (struct tui_source_window_base)
  28         <location_matches_p>: New method.
  29         (struct tui_source_window, struct tui_disasm_window)
  30         <location_matches_p>: Likewise.
  31
  32 2019-07-17  Tom Tromey  <tom@tromey.com>
  33
  34         * tui/tui-win.c (tui_set_win_height_command): Rename from
  35         tui_set_win_height.
  36         (tui_set_win_height_command): Remove.
  37
  38 2019-07-17  Tom Tromey  <tom@tromey.com>
  39
  40         * tui/tui-source.c (tui_source_window): New constructor.  Add
  41         observer.
  42         (~tui_source_window): New destructor.
  43         (tui_source_window::style_changed): New method.
  44         * tui/tui-hooks.c (tui_redisplay_source): Remove.
  45         (tui_attach_detach_observers): Update.
  46         * tui/tui-data.h (struct tui_source_window): Make constructor not
  47         inline.  Add destructor.
  48         (struct tui_source_window) <style_changed>: New method.
  49         <m_observable>: New member.
  50
  51 2019-07-17  Tom Tromey  <tom@tromey.com>
  52
  53         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
  54         * tui/tui-win.c (tui_resize_all): Fix typo.
  55
  56 2019-07-17  Tom Tromey  <tom@tromey.com>
  57
  58         * tui/tui-wingeneral.h (tui_refresh_all): Update.
  59         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
  60         (tui_refresh_all): Remove "list" parameter.  Use foreach.
  61         * tui/tui-win.c (window_name_completer): Use foreach.
  62         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
  63         (update_tab_width): Likewise.
  64         * tui/tui-layout.c (show_layout): Update.
  65         * tui/tui-data.h (class tui_window_iterator): New.
  66         (struct all_tui_windows): New.
  67         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
  68
  69 2019-07-17  Tom Tromey  <tom@tromey.com>
  70
  71         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
  72         parameter.  Don't reference globals.
  73         (tui_reg_command): Update.
  74
  75 2019-07-17  Tom Tromey  <tom@tromey.com>
  76
  77         * tui/tui-regs.c (tui_show_registers): Simplify.
  78
  79 2019-07-17  Tom Tromey  <tom@tromey.com>
  80
  81         * tui/tui-regs.c (tui_show_registers): Update.
  82         (tui_show_register_group): Add win_info parameter.
  83
  84 2019-07-17  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
  87         Rename from tui_display_reg_element_at_line.
  88         (tui_data_window::display_registers_from_line): Update.
  89         * tui/tui-data.h (struct tui_data_window)
  90         <display_reg_element_at_line>: New method.
  91
  92 2019-07-17  Tom Tromey  <tom@tromey.com>
  93
  94         * tui/tui-regs.h (tui_display_registers_from)
  95         (tui_display_registers_from_line): Don't declare.
  96         * tui/tui-windata.c (tui_data_window::display_all_data)
  97         (tui_data_window::refresh_all)
  98         (tui_data_window::do_scroll_vertical): Update.
  99         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 100         from tui_display_registers_from.
 101         (tui_display_reg_element_at_line): Update.
 102         (tui_data_window::display_registers_from_line): Rename from
 103         tui_display_registers_from_line.
 104         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 105         display_registers_from_line>: New methods.
 106
 107 2019-07-17  Tom Tromey  <tom@tromey.com>
 108
 109         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 110         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 111         from tui_erase_data_content.
 112         (tui_data_window::display_all_data)
 113         (tui_data_window::refresh_all)
 114         (tui_data_window::do_scroll_vertical): Update.
 115         * tui/tui-regs.c (tui_show_registers): Update.
 116         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 117         New method.
 118
 119 2019-07-17  Tom Tromey  <tom@tromey.com>
 120
 121         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 122         declare.
 123         * tui/tui-windata.c
 124         (tui_data_window::delete_data_content_windows): Rename from
 125         tui_delete_data_content_windows.
 126         (tui_data_window::display_all_data)
 127         (tui_data_window::do_scroll_vertical): Update.
 128         * tui/tui-data.h (struct tui_data_window)
 129         <delete_data_content_windows>: New method.
 130
 131 2019-07-17  Tom Tromey  <tom@tromey.com>
 132
 133         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 134         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 135
 136 2019-07-17  Tom Tromey  <tom@tromey.com>
 137
 138         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 139         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 140         from tui_display_all_data.
 141         * tui/tui-win.c
 142         (tui_data_window::do_make_visible_with_new_height): Update.
 143         * tui/tui-regs.c (tui_show_registers): Update.
 144         * tui/tui-layout.c (tui_set_layout): Update.
 145         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 146         method.
 147
 148 2019-07-17  Tom Tromey  <tom@tromey.com>
 149
 150         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 151         * tui/tui-windata.c (tui_display_data_from): Remove.
 152         (tui_data_window::refresh_all): Update.
 153
 154 2019-07-17  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 157         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 158         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 159         tui_display_registers_from_line.
 160         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 161         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 162         "force_display" parameter.
 163
 164 2019-07-17  Tom Tromey  <tom@tromey.com>
 165
 166         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 167         declare.
 168         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 169         Rename from tui_first_reg_element_no_inline.
 170         (tui_display_reg_element_at_line)
 171         (tui_display_registers_from_line): Update.
 172         * tui/tui-data.h (struct tui_data_window)
 173         <first_reg_element_no_inline>: New method.
 174
 175 2019-07-17  Tom Tromey  <tom@tromey.com>
 176
 177         * tui/tui-windata.c (tui_display_data_from)
 178         (tui_data_window::do_scroll_vertical): Update.
 179         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 180         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 181         Rename from tui_line_from_reg_element_no.
 182         (tui_display_registers_from_line): Update.
 183         * tui/tui-data.h (struct tui_data_window)
 184         <line_from_reg_element_no>: New method.
 185
 186 2019-07-17  Tom Tromey  <tom@tromey.com>
 187
 188         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 189         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 190         tui_last_regs_line_no.
 191         (tui_display_reg_element_at_line)
 192         (tui_display_registers_from_line): Update.
 193         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 194         method.
 195
 196 2019-07-17  Tom Tromey  <tom@tromey.com>
 197
 198         PR tui/24722:
 199         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 200         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 201         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 202         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 203         (tui_update_breakpoint_info): Likewise.
 204         * tui/tui-hooks.c (tui_event_create_breakpoint)
 205         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 206         Update.
 207
 208 2019-07-17  Tom Tromey  <tom@tromey.com>
 209
 210         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 211
 212 2019-07-17  Tom Tromey  <tom@tromey.com>
 213
 214         * tui/tui-winsource.c (tui_update_source_window_as_is)
 215         (tui_update_source_windows_with_addr): Update.
 216         * tui/tui-source.h (tui_set_source_content)
 217         (tui_show_symtab_source): Add "win_info" parameter.
 218         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 219         parameter.
 220         (tui_show_symtab_source): Likewise.
 221
 222 2019-07-17  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui-wingeneral.c
 225         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 226
 227 2019-07-17  Tom Tromey  <tom@tromey.com>
 228
 229         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 230         (struct tui_cmd_window) <can_scroll>: New method.
 231         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 232         method.
 233
 234 2019-07-17  Tom Tromey  <tromey@adacore.com>
 235
 236         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 237         do_field_signed>: Rename.  Change type of "value".
 238         * ui-out.c (ui_out::field_signed): Rename from field_int.
 239         Change type of "value".
 240         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 241         type of "value".
 242         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 243         do_field_int.  Change type of "value".
 244         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 245         do_field_int.  Change type of "value".
 246         * tracepoint.c (trace_status_mi, tfind_1)
 247         (print_one_static_tracepoint_marker): Update.
 248         * thread.c (print_thread_info_1, print_selected_thread_frame):
 249         Update.
 250         * stack.c (print_frame, print_frame_info): Update.
 251         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 252         Update.
 253         * source.c (print_source_lines_base): Update.
 254         * skip.c (info_skip_command): Update.
 255         * record-btrace.c (btrace_ui_out_decode_error)
 256         (btrace_call_history_src_line): Update.
 257         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 258         Update.
 259         * progspace.c (print_program_space): Update.
 260         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 261         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 262         do_field_int.  Change type of "value".
 263         * mi/mi-out.c (mi_ui_out::do_table_begin)
 264         (mi_ui_out::do_table_header): Update.
 265         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 266         type of "value".
 267         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 268         (mi_cmd_data_list_changed_registers, output_register)
 269         (mi_cmd_data_read_memory, mi_load_progress)
 270         (mi_cmd_trace_frame_collected): Update.
 271         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 272         Update.
 273         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 274         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 275         (mi_cmd_var_list_children, varobj_update_one): Update.
 276         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 277         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 278         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 279         * inferior.c (print_inferior): Update.
 280         * gdb_bfd.c (print_one_bfd): Update.
 281         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 282         Update.
 283         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 284         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 285         do_field_int.  Change type of "value".
 286         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 287         do_field_int.  Change type of "value".
 288         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 289         (print_one_breakpoint_location, print_it_catch_fork)
 290         (print_one_catch_fork, print_it_catch_vfork)
 291         (print_one_catch_vfork, print_it_catch_solib)
 292         (print_it_catch_exec, print_it_ranged_breakpoint)
 293         (print_mention_watchpoint, print_mention_masked_watchpoint)
 294         (bkpt_print_it, update_static_tracepoint): Update.
 295         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 296         * break-catch-syscall.c (print_it_catch_syscall): Update.
 297         * ada-tasks.c (print_ada_task_info): Update.
 298         * ada-lang.c (print_it_exception, print_mention_exception):
 299         Update.
 300
 301 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 302
 303         PR breakpoints/24541
 304         * gdbarch.c: Regenerate.
 305         * gdbarch.h: Regenerate.
 306         * gdbarch.sh: Adjust return type and parameter types for
 307         'stap_adjust_register'.
 308         (i386_stap_adjust_register): Adjust signature and return new
 309         register name.
 310         * stap-probe.c (stap_parse_register_operand): Adjust use of
 311         'gdbarch_stap_adjust_register'.
 312
 313 2019-07-17  Tom Tromey  <tromey@adacore.com>
 314
 315         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 316         declare VEC.
 317         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 318         std::vector.
 319         (struct s390_process_info): Add initializers.
 320         (s390_add_process): Use new.
 321         (s390_linux_nat_target::low_forget_process): Use delete.
 322         (s390_linux_nat_target::low_new_fork)
 323         (s390_linux_nat_target::stopped_by_watchpoint)
 324         (s390_linux_nat_target::low_prepare_to_resume)
 325         (s390_linux_nat_target::insert_watchpoint)
 326         (s390_linux_nat_target::insert_hw_breakpoint)
 327         (s390_linux_nat_target::remove_watchpoint)
 328         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 329
 330 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 331
 332         * aarch64-fbsd-nat.c: Include regcache.h.
 333         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 334         argument.
 335         (aarch64_fbsd_nat_target::fetch_registers)
 336         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 337         variable.
 338         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 339
 340 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 341
 342         * fbsd-nat.c: Include gdbarch.h.
 343
 344 2019-07-15  Tom Tromey  <tromey@adacore.com>
 345
 346         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 347
 348 2019-07-15  Tom Tromey  <tromey@adacore.com>
 349
 350         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 351         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 352         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 353         * cli-out.c (cli_ui_out::do_field_int): New method.
 354         * ui-out.c (ui_out::field_unsigned): New method.
 355         * symfile.c (generic_load): Use field_unsigned.
 356         (print_transfer_performance): Likewise.
 357         * record-btrace.c (ui_out_field_uint): Remove.
 358         (btrace_call_history_insn_range, btrace_call_history): Use
 359         field_unsigned.
 360         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 361         field_unsigned.
 362         * ui-out.h (class ui_out) <field_unsigned>: New method.
 363         <do_field_unsigned>: Likewise.
 364
 365 2019-07-15  Tom Tromey  <tromey@adacore.com>
 366
 367         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 368         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 369         * target.c (flash_erase_command): Use field_string.
 370         * infrun.c (print_signal_received_reason): Use field_string.
 371         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 372         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 373         field_string.
 374         * ada-tasks.c (print_ada_task_info): Use field_string.
 375
 376 2019-07-15  Tom Tromey  <tromey@adacore.com>
 377
 378         * target.c (flash_erase_command): Use field_core_addr.
 379         * symfile.c (generic_load): Use field_core_addr.
 380         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 381         Use field_core_addr.
 382         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 383         field_core_addr.
 384
 385 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 386
 387         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 388         value if its desired type is smaller than a CORE_ADDR and signed.
 389
 390 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 391
 392         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 393         of changes to field names, and use new is_reference field to
 394         decide if a property is a reference or not.
 395         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 396         field.
 397         (struct dwarf2_property_baton): Update header comment, rename
 398         'referenced_type' to 'property_type' and update comments.
 399         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 400         default property type, store in property baton, update to take
 401         accound of renamed field.
 402         (read_func_scope): Update call to attr_to_dynamic_prop.
 403         (read_array_type): Likewise.
 404         (dwarf2_per_cu_addr_sized_int_type): New function.
 405         (read_subrange_index_type): Move type finding code to
 406         dwarf2_per_cu_addr_sized_int_type.
 407         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 408         (dwarf2_per_cu_addr_type): New function.
 409         (set_die_type): Update calls to attr_to_dynamic_prop.
 410
 411 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 412
 413         * dwarf2read.c (read_subrange_index_type): New function.
 414         (read_subrange_type): Move code into new function and call it.
 415         * gdbtypes.c (create_range_type): Add some asserts.
 416
 417 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 418
 419         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 420         update return statements.
 421         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 422         declaration, and update comment to match.
 423         * gdbtypes.c (resolve_dynamic_array): Update call to
 424         dwarf2_evaluate_property to match new return type.
 425
 426 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 427
 428         * valarith.c (value_subscripted_rvalue): Change lowerbound
 429         parameter type from int to LONGEST.
 430         * value.h (value_subscripted_rvalue): Likewise in declaration.
 431
 432 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 433
 434         * cli/cli-utils.c (info_print_command_completer): New function.
 435         * cli/cli-utils.h: Add 'completer.h' include, and forward
 436         declaration for 'struct cmd_list_element'.
 437         (info_print_command_completer): Declare.
 438         * stack.c (_initialize_stack): Add completer for 'info locals' and
 439         'info args'.
 440         * symtab.c (_initialize_symtab): Add completer for 'info
 441         variables' and 'info functions'.
 442         * NEWS: Mention completion for additional info commands.
 443
 444 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 445
 446         * cli/cli-utils.c (extract_info_print_args): Delete.
 447         (extract_arg_maybe_quoted): Delete.
 448         (info_print_options_defs): New variable.
 449         (make_info_print_options_def_group): New function.
 450         (extract_info_print_options): Define new function.
 451         * cli/cli-utils.h (extract_info_print_args): Delete.
 452         (struct info_print_options): New structure.
 453         (extract_info_print_options): Declare new function.
 454         * stack.c (info_locals_command): Update to use new
 455         extract_info_print_options, also add a header comment.
 456         (info_args_command): Likewise.
 457         * symtab.c (info_variables_command): Likewise.
 458         (info_functions_command): Likewise.
 459
 460 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 461
 462         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 463         to extract string arguments.
 464         * common/common-utils.c (extract_string_maybe_quoted): New function.
 465         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 466
 467 2019-07-11  Tom Tromey  <tromey@adacore.com>
 468
 469         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 470         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 471         * top.h (gdbinit): Don't declare.
 472         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 473         into...
 474         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 475         * top.c (gdb_init): Don't call init_cli_cmds.
 476         (gdbinit): Remove.
 477         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 478
 479 2019-07-11  Tom Tromey  <tromey@adacore.com>
 480
 481         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 482         after it has been moved.
 483
 484 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 485
 486         * valops.c (value_must_coerce_to_target): Change return type to
 487         bool.
 488         * value.h (value_must_coerce_to_target): Likewise.
 489
 490 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 491
 492         * breakpoint.c (is_hardware_watchpoint): Remove
 493         forward-declaration.
 494         (is_masked_watchpoint): Change return type to bool.
 495         (is_tracepoint): Likewise.
 496         (is_breakpoint): Likewise.
 497         (is_hardware_watchpoint): Likewise.
 498         (is_watchpoint): Likewise.
 499         (is_no_memory_software_watchpoint): Likewise.
 500         (is_catchpoint): Likewise.
 501         (breakpoint_1): Make FILTER parameter's return type bool.
 502         is_masked_watchpoint): Change return type to bool.
 503         (save_breakpoints): Make FILTER parameter's return type bool.
 504         * breakpoint.h (is_breakpoint): Change return type to bool.
 505         (is_watchpoint): Likewise.
 506         (is_catchpoint): Likewise.
 507         (is_tracepoint): Likewise.
 508
 509 2019-07-10  Tom Tromey  <tom@tromey.com>
 510
 511         * defs.h: Don't include gdbarch.h.
 512         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 513         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 514         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 515         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 516         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 517         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 518         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 519         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 520         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 521         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 522         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 523         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 524         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 525         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 526         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 527         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 528         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 529         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 530         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 531         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 532         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 533         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 534         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 535         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 536         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 537         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 538         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 539
 540 2019-07-10  Tom Tromey  <tromey@adacore.com>
 541
 542         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 543         * breakpoint.c (init_ada_exception_breakpoint): Register as
 544         bp_catchpoint.
 545         (print_one_breakpoint_location, print_one_breakpoint): Use
 546         is_ada_exception_catchpoint.
 547         * ada-lang.c (class ada_catchpoint_location): Pass
 548         bp_loc_software_breakpoint to bp_location constructor.
 549         (is_ada_exception_catchpoint): New function.
 550
 551 2019-07-10  Tom Tromey  <tromey@adacore.com>
 552
 553         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 554         VEC.
 555         (struct arm_exidx_entry): New method operator<.
 556         (struct arm_exidx_data) <section_maps>: Change type.
 557         (arm_exidx_data_free): Remove.
 558         (arm_exidx_data_key): Change type.  Move lower.
 559         (arm_exidx_new_objfile): Update.
 560         (arm_compare_exidx_entries): Remove.
 561         (arm_find_exidx_entry, _initialize_arm_tdep)
 562
 563 2019-07-10  Tom Tromey  <tromey@adacore.com>
 564
 565         * solib-spu.c (ocl_program_data_key): Change type.
 566         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 567         Update.
 568
 569 2019-07-10  Tom Tromey  <tromey@adacore.com>
 570
 571         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 572         (struct solib_aix_inferior_data) <library_list>: Change type.
 573         (solib_aix_inferior_data_handle): Change type.
 574         (get_solib_aix_inferior_data): Update.
 575         (solib_aix_free_library_list): Remove.
 576         (library_list_start_library): Update.
 577         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 578         return type.
 579         (solib_aix_get_library_list)
 580         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 581         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 582
 583 2019-07-10  Tom Tromey  <tromey@adacore.com>
 584
 585         * solib-dsbt.c (struct dsbt_info): Add initializers.
 586         (solib_dsbt_pspace_data): Change type.
 587         (dsbt_pspace_data_cleanup): Remove.
 588         (get_dsbt_info, _initialize_dsbt_solib): Update.
 589
 590 2019-07-10  Tom Tromey  <tromey@adacore.com>
 591
 592         * spu-tdep.c (spu_overlay_data): Change type.
 593         (spu_get_overlay_table, spu_overlay_new_objfile)
 594         (_initialize_spu_tdep): Update.
 595
 596 2019-07-10  Tom Tromey  <tromey@adacore.com>
 597
 598         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 599         destructor.
 600         (dbx_objfile_data_key): Change type and declare later.
 601         (DBX_SYMFILE_INFO): Rewrite.
 602         * dbxread.c (dbx_objfile_data_key): Change type.
 603         (dbx_symfile_init): Update.
 604         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 605         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 606         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 607
 608 2019-07-10  Tom Tromey  <tromey@adacore.com>
 609
 610         * jit.c (jit_program_space_key): Change type.  Move lower.
 611         (get_jit_program_space_data): Update.
 612         (jit_program_space_data_cleanup): Remove.
 613         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 614         Update.
 615         (struct jit_program_space_data): Add initializers.
 616
 617 2019-07-10  Tom Tromey  <tromey@adacore.com>
 618
 619         * solib-darwin.c (struct darwin_info): Add initializers.
 620         (solib_darwin_pspace_data): Change type.
 621         (darwin_pspace_data_cleanup): Remove.
 622         (get_darwin_info, _initialize_darwin_solib): Update.
 623
 624 2019-07-10  Tom Tromey  <tromey@adacore.com>
 625
 626         * remote-sim.c (struct sim_inferior_data): Add initializers,
 627         constructor, and destructor.
 628         (sim_inferior_data_key): Change type.  Move lower.
 629         (check_for_duplicate_sim_descriptor): Update.
 630         (get_sim_inferior_data): Use new.  Update.
 631         (~sim_inferior_data_cleanup): Rename from
 632         sim_inferior_data_cleanup.  Simplify.
 633         (gdbsim_close_inferior, simulator_command)
 634         (sim_command_completer, _initialize_remote_sim): Update.
 635         (next_pid, INITIAL_PID): Move earlier.
 636
 637 2019-07-10  Tom Tromey  <tromey@adacore.com>
 638
 639         * python/python-internal.h (create_thread_object): Return
 640         gdbpy_ref.
 641         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 642         * python/py-inferior.c (struct threadlist_entry): Add
 643         constructor.
 644         <thread_obj>: Now a gdbpy_ref.
 645         (thread_to_thread_object): Update.
 646         (add_thread_object): Use new.
 647         (delete_thread_object): Use delete.
 648         (infpy_threads): Update.
 649         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 650         GIL.
 651
 652 2019-07-10  Tom Tromey  <tromey@adacore.com>
 653
 654         * valops.c (value_cast): Specialize error message for Ada.
 655
 656 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 657
 658         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 659
 660 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 661
 662         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 663         bpstat_should_step): Return bool, adjust comments.
 664         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 665         bpstat_should_step): Likewise.
 666
 667 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 668
 669         * features/Makefile: Use feature target descriptions for Arm.
 670         * features/arm/arm-core.c: Generate new file.
 671         * features/arm/arm-fpa.c: Likewise.
 672         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 673         * features/arm/arm-m-profile.c: Likewise.
 674         * features/arm/arm-vfpv2.c: Likewise.
 675         * features/arm/arm-vfpv3.c: Likewise.
 676         * features/arm/xscale-iwmmxt.c: Likewise.
 677         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 678
 679 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 680
 681         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 682         ptrace earlier.
 683
 684 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 685
 686         * features/aarch64-pauth.c: Regenerate.
 687
 688 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 689
 690         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 691         bool.
 692         (bpstat_what): Use false instead of 0.
 693
 694 2019-07-09  Pedro Alves  <palves@redhat.com>
 695
 696         * break-catch-throw.c (is_exception_catchpoint): New.
 697         * breakpoint.c (print_one_breakpoint_location): New parameter
 698         'raw_loc'.  Handle it.  Use
 699         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 700         looking at the breakpoint's type.
 701         (print_one_breakpoint): If handling "maint info breakpoints", also
 702         print locations of exception catchpoints.
 703         * breakpoint.h (is_exception_catchpoint): Declare.
 704
 705 2019-07-09  Pedro Alves  <palves@redhat.com>
 706
 707         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 708         "addr" field.
 709         (allocate_location_exception_catchpoint): New.
 710         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 711         (initialize_throw_catchpoint_ops): Install
 712         allocate_location_exception_catchpoint as allocate_location
 713         method.
 714         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 715         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 716         bp_loc_other.
 717         (breakpoint_address_is_meaningful): Delete.
 718         (bl_address_is_meaningful): New.
 719         (breakpoint_locations_match): Adjust comment.
 720         (bp_location_from_bp_type): New, factored out of...
 721         (bp_location::bp_location(breakpoint *)): ... this.
 722         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 723         factored out of...
 724         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 725         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 726         breakpoint_address_is_meaningful.
 727         (bp_locations_compare): Adjust comment.
 728         (update_global_location_list): Use bl_address_is_meaningful
 729         instead of breakpoint_address_is_meaningful.
 730         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 731         explicit.
 732         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 733         * python/py-breakpoint.c (bppy_get_location): No longer check
 734         whether location is null.
 735
 736 2019-07-09  Pedro Alves  <palves@redhat.com>
 737
 738         PR c++/15468
 739         * breakpoint.c (print_one_breakpoint_location): Remove
 740         single-location assert.
 741
 742 2019-07-09  Tom Tromey  <tom@tromey.com>
 743
 744         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 745         * configure: Rebuild.
 746         * configure.ac: Change common to gdbsupport.
 747         * gdbsupport: Rename from common.
 748         * acinclude.m4: Change common to gdbsupport.
 749         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 750         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 751         gdbsupport.
 752         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 753         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 754         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 755         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 756         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 757         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 758         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 759         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 760         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 761         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 762         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 763         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 764         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 765         coff-pe-read.c, command.h, compile/compile-c-support.c,
 766         compile/compile-c.h, compile/compile-cplus-symbols.c,
 767         compile/compile-cplus-types.c, compile/compile-cplus.h,
 768         compile/compile-loc2c.c, compile/compile.c, completer.c,
 769         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 770         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 771         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 772         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 773         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 774         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 775         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 776         features/aarch64-core.c, features/aarch64-fpu.c,
 777         features/aarch64-pauth.c, features/aarch64-sve.c,
 778         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 779         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 780         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 781         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 782         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 783         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 784         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 785         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 786         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 787         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 788         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 789         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 790         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 791         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 792         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 793         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 794         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 795         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 796         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 797         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 798         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 799         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 800         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 801         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 802         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 803         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 804         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 805         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 806         minsyms.c, mips-linux-tdep.c, namespace.h,
 807         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 808         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 809         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 810         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 811         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 812         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 813         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 814         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 815         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 816         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 817         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 818         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 819         procfs.c, producer.c, progspace.h, psymtab.h,
 820         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 821         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 822         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 823         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 824         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 825         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 826         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 827         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 828         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 829         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 830         target-memory.c, target.c, target.h, target/waitstatus.c,
 831         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 832         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 833         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 834         unittests/array-view-selftests.c,
 835         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 836         unittests/common-utils-selftests.c,
 837         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 838         unittests/format_pieces-selftests.c,
 839         unittests/function-view-selftests.c,
 840         unittests/lookup_name_info-selftests.c,
 841         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 842         unittests/mkdir-recursive-selftests.c,
 843         unittests/observable-selftests.c,
 844         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 845         unittests/parse-connection-spec-selftests.c,
 846         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 847         unittests/scoped_fd-selftests.c,
 848         unittests/scoped_mmap-selftests.c,
 849         unittests/scoped_restore-selftests.c,
 850         unittests/string_view-selftests.c, unittests/style-selftests.c,
 851         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 852         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 853         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 854         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 855         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 856         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 857
 858 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 859
 860         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 861         bool value.
 862         (decode_digits_ordinary): Set explicit_line field in sal.
 863         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 864         symtab_and_line that was set on an explicit line number in
 865         assembler code.  Do always update the recorded symtab and line if
 866         we do skip the prologue.
 867
 868 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 869
 870         * breakpoint.c (set_breakpoint_location_function): Remove
 871         explicit_loc parameter.
 872         (momentary_breakpoint_from_master): Update call to
 873         set_breakpoint_location_function.
 874         (add_location_to_breakpoint): Likewise.
 875
 876 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 877
 878         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 879         required features based on default bfd type when no specific bfd
 880         is present.
 881
 882 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 883
 884         * NEWS: Mention that GDB printf and eval commands can now print
 885         C-style and Ada-style convenience var strings without
 886         calling the inferior.
 887         * printcmd.c (printf_c_string): Locally print GDB internal var
 888         instead of transiting via the inferior.
 889         (printf_wide_c_string): Likewise.
 890
 891 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 892
 893         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 894
 895 2019-07-04  Tom Tromey  <tom@tromey.com>
 896
 897         PR tui/24724:
 898         * tui/tui-winsource.c (tui_clear_source_content): Update.
 899         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 900         (tui_update_breakpoint_info): Update.
 901         (tui_set_exec_info_content): Update.
 902         * tui/tui-source.c (tui_set_source_content_nil): Update.
 903         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 904         has_break.
 905         * tui/tui-data.h (enum tui_bp_flag): New.
 906         (tui_bp_flags): New enum flags type.
 907         (struct tui_source_element) <break_mode>: Change type.  Rename
 908         from has_break.
 909         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 910         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 911         constants.
 912         * tui/tui-winsource.h: Fix comment.
 913
 914 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 915
 916         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 917         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 918         (store_fpregs_to_thread)
 919         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 920         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 921         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 922         (IWMMXT_REGS_SIZE): Add define.
 923         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 924         (fetch_vfp_regs, store_vfp_regs)
 925         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 926         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 927
 928 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 929
 930         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 931         defines.
 932         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 933         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 934         (ARM_INT_REGISTER_SIZE): ...to this.
 935         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 936         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 937         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 938         (arm_linux_collect_gregset, supply_nwfpe_register)
 939         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 940         defines.
 941         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 942         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 943         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 944         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 945         (arm_return_in_memory, arm_store_return_value)
 946         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 947         (arm_record_ld_st_multiple): Likewise.
 948         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 949         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 950
 951 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 952
 953         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 954         AARCH64_DISPLACED_MODIFIED_INSNS.
 955         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 956         (aarch64_displaced_step_copy_insn): Likewise.
 957         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 958         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 959         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 960         ARM_DISPLACED_MODIFIED_INSNS.
 961         * arm-tdep.c (arm_gdbarch_init): Likewise.
 962         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 963         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 964         (struct arm_displaced_step_closure): Use
 965         ARM_DISPLACED_MODIFIED_INSNS.
 966
 967 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 968
 969         * features/Makefile: Remove unused xml files.
 970         * features/aarch64.xml: Remove.
 971         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 972         * features/i386/amd64-avx-avx512.xml: Remove.
 973         * features/i386/amd64-avx-linux.xml: Remove.
 974         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 975         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 976         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 977         * features/i386/amd64-avx-mpx.xml: Remove.
 978         * features/i386/amd64-avx.xml: Remove.
 979         * features/i386/amd64-linux.xml: Remove.
 980         * features/i386/amd64-mpx-linux.xml: Remove.
 981         * features/i386/amd64-mpx.xml: Remove.
 982         * features/i386/amd64.xml: Remove.
 983         * features/i386/i386-avx-avx512-linux.xml: Remove.
 984         * features/i386/i386-avx-avx512.xml: Remove.
 985         * features/i386/i386-avx-linux.xml: Remove.
 986         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 987         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 988         * features/i386/i386-avx-mpx-linux.xml: Remove.
 989         * features/i386/i386-avx-mpx.xml: Remove.
 990         * features/i386/i386-avx.xml: Remove.
 991         * features/i386/i386-linux.xml: Remove.
 992         * features/i386/i386-mmx-linux.xml: Remove.
 993         * features/i386/i386-mmx.xml: Remove.
 994         * features/i386/i386-mpx-linux.xml: Remove.
 995         * features/i386/i386-mpx.xml: Remove.
 996         * features/i386/i386.xml: Remove.
 997         * features/i386/x32-avx-avx512-linux.xml: Remove.
 998         * features/i386/x32-avx-linux.xml: Remove.
 999         * features/i386/x32-linux.xml: Remove.
1000
1001 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1002
1003         * regformats/aarch64.dat: Remove.
1004         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1005         * regformats/i386/amd64-avx-linux.dat: Remove.
1006         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1007         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1008         * regformats/i386/amd64-linux.dat: Remove.
1009         * regformats/i386/amd64-mpx-linux.dat: Remove.
1010         * regformats/i386/amd64.dat: Remove.
1011         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1012         * regformats/i386/i386-avx-linux.dat: Remove.
1013         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1014         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1015         * regformats/i386/i386-linux.dat: Remove.
1016         * regformats/i386/i386-mmx-linux.dat: Remove.
1017         * regformats/i386/i386-mpx-linux.dat: Remove.
1018         * regformats/i386/i386.dat: Remove.
1019         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1020         * regformats/i386/x32-avx-linux.dat: Remove.
1021         * regformats/i386/x32-linux.dat: Remove.
1022
1023 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1024
1025         * aarch64-tdep.c: Remove xml self tests.
1026         * amd64-linux-tdep.c: Likewise.
1027         * amd64-tdep.c: Likewise.
1028         * i386-linux-tdep.c: Likewise.
1029         * i386-tdep.c: Likewise.
1030
1031 2019-07-03  Pedro Alves  <palves@redhat.com>
1032
1033         PR cli/24732
1034         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1035         (pipe_cmd_option_defs): New.
1036         (make_pipe_cmd_options_def_group): New.
1037         (pipe_command): Use gdb::option::process_options.
1038         (pipe_command_completer): New function.
1039         (_initialize_cli_cmds): Install completer for "pipe" command.
1040
1041 2019-07-03  Pedro Alves  <palves@redhat.com>
1042
1043         * cli/cli-option.c (union option_value) <string>: New field.
1044         (struct option_def_and_value): Add ctor, move ctor, dtor and
1045         use DISABLE_COPY_AND_ASSIGN.
1046         (option_def_and_value::clear_value): New.
1047         (parse_option, save_option_value_in_ctx, get_val_type_str)
1048         (add_setshow_cmds_for_options): Handle var_string.
1049         * cli-option.h (union option_def::var_address) <string>: New
1050         field.
1051         (struct string_option_def): New.
1052         * maint-test-options.c (struct test_options_opts): Add default
1053         ctor and use DISABLE_COPY_AND_ASSIGN.
1054         <string_opt>: New field.
1055         (test_options_opts::~test_options_opts): New.
1056         (test_options_opts::dump): Also dump "-string".
1057         (test_options_option_defs): Install "string.
1058
1059 2019-07-03  Pedro Alves  <palves@redhat.com>
1060
1061         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1062         option_value with a null enumeration.
1063         (complete_options): Save the option values in the context.
1064         (save_option_value_in_ctx): New, factored out from ...
1065         (process_options): ... here.
1066         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1067         of the function.
1068         * maint-test-options.c (test_options_opts::dump): New, factored
1069         out from ...
1070         (maintenance_test_options_command_mode): ... here.
1071         (maintenance_test_options_command_completion_result): Delete.
1072         (maintenance_test_options_command_completion_text): Update
1073         comment.
1074         (maintenance_show_test_options_completion_result): Change
1075         prototype.  Just print
1076         maintenance_test_options_command_completion_text.
1077         (save_completion_result): New.
1078         (maintenance_test_options_completer_mode): Pass options context to
1079         complete_options, and then save a dump.
1080         (_initialize_maint_test_options): Use add_cmd to install "maint
1081         show test-options-completion-result".
1082
1083 2019-07-03  Pedro Alves  <palves@redhat.com>
1084
1085         * NEWS (New commands): Mention "with" and "maint with".
1086         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1087         (with_command, with_command_completer): New.
1088         (pipe_command): Adjust to new repeat_previous
1089         interface.
1090         (_initialize_cli_cmds): Install the "with" command and its "w"
1091         alias.
1092         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1093         declarations.
1094         * cli/cli-setshow.c (parse_cli_var_uinteger)
1095         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1096         argument strings for all var_types.
1097         (get_setshow_command_value_string): New, factored out from ...
1098         (do_show_command): ... this.
1099         * cli/cli-setshow.h: Include <string>.
1100         (get_setshow_command_value_string): Declare.
1101         * command.h (repeat_previous): Now returns const char *.  Adjust
1102         comment.
1103         * maint.c: Include "cli/cli-cmds.h".
1104         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1105         (_initialize_maint_cmds): Register the "maintenance with" command.
1106         * top.c (repeat_previous): Move bits from pipe_command here:
1107         Return the saved command line, if any; error out if there's no
1108         command to relaunch.
1109
1110 2019-07-03  Pedro Alves  <palves@redhat.com>
1111
1112         * NEWS (New commands): Mention "maint set/show test-settings"
1113         instead of "maint test-settings".
1114         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1115         (maintenance_test_settings_set_list): Rename to ...
1116         (maintenance_set_test_settings_list): ... this.
1117         (maintenance_test_settings_show_list): Rename to  ...
1118         (maintenance_show_test_settings_list): ... this.
1119         (maintenance_test_settings_cmd): Delete.
1120         (maintenance_test_settings_set_cmd): ...
1121         (maintenance_set_test_settings_cmd): ... this.
1122         (maintenance_test_settings_show_cmd): ...
1123         (maintenance_show_test_settings_cmd): ... this.
1124         (maintenance_test_settings_show_value_cmd):
1125         (maintenance_show_test_settings_value_cmd): ... this.
1126         (_initialize_maint_test_settings): No longer install the "maint
1127         test-settings" prefix command.  Rename "maint test-settings set"
1128         to "maint set test-settings", and "maint test-settings show" to
1129         "maint show test-settings".  Adjust all subcommands.
1130
1131 2019-07-03  Pedro Alves  <palves@redhat.com>
1132
1133         * maint-test-settings.c: Fix file's intro comment.  Replace all
1134         references to "test-options" with references to "test-settings",
1135         in comments.
1136
1137 2019-07-03  Pedro Alves  <palves@redhat.com>
1138
1139         * maint-test-settings.c (maintenance_test_settings_xxx)
1140         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1141         New.
1142         (maintenance_test_settings_enums): Use them.
1143         (maintenance_test_settings_enum): Default to
1144         maintenance_test_settings_xxx.
1145         (_initialize_maint_test_settings): Initialize
1146         MAINTENANCE_TEST_SETTINGS_FILENAME.
1147
1148 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1149
1150         * breakpoint.h (remove_breakpoints_inf): Change return type to
1151         void, move function documentation here.
1152         * breakpoint.c (remove_breakpoints_inf): Change return type to
1153         void, move function documentation to header.
1154
1155 2019-07-02  Pedro Alves  <palves@redhat.com>
1156
1157         * NEWS (Completion improvements): Mention "info threads".
1158         * thread.c (struct info_threads_opts, info_threads_option_defs)
1159         (make_info_threads_options_def_group): New.
1160         (info_threads_command): Use gdb::option::process_options.
1161         (info_threads_command_completer): New.
1162         (_initialize_thread): Use gdb::option::build_help to build the
1163         help text for "info threads".
1164
1165 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1166
1167         * defs.h (generic_load): Move from here...
1168         * symfile.h (generic_load): ... to here.  Rename name parameter
1169         to args.
1170         * symfile.c (generic_load): Add comment.
1171
1172 2019-07-01  Tom Tromey  <tromey@adacore.com>
1173
1174         * dwarf2read.c
1175         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1176         declaration of without_params.  Fix formatting.
1177
1178 2019-07-01  Tom Tromey  <tromey@adacore.com>
1179
1180         * ada-exp.y (find_primitive_type): Update.
1181         * ada-lang.h (ada_lookup_symbol): Update.
1182         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1183         parameter.
1184         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1185
1186 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1187
1188         PR breakpoints/24541
1189         * gdbarch.c: Regenerate.
1190         * gdbarch.h: Regenerate.
1191         * gdbarch.sh: Add 'stap_adjust_register'.
1192         * i386-tdep.c: Include '<unordered_set>'.
1193         (i386_stap_adjust_register): New function.
1194         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1195         * stap-probe.c (stap_parse_register_operand): Call
1196         'gdbarch_stap_adjust_register'.
1197
1198 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1199
1200         PR python/24742
1201         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1202         * python/python.c (do_start_initialization): Use 'xmalloc'
1203         instead of 'PyMem_Malloc'.
1204
1205 2019-06-28  Tom Tromey  <tromey@adacore.com>
1206
1207         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1208         for Ada.
1209
1210 2019-06-27  Tom Tromey  <tromey@adacore.com>
1211
1212         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1213         objfile_key.
1214         (arm_find_mapping_symbol, arm_record_special_symbol)
1215         (_initialize_arm_tdep): Update.
1216         (arm_objfile_data_free): Remove.
1217
1218 2019-06-27  Tom Tromey  <tromey@adacore.com>
1219
1220         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1221         to cp_print_static_field.
1222
1223 2019-06-26  Tom Tromey  <tromey@adacore.com>
1224
1225         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1226         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1227         declare.
1228
1229 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1230
1231         * features/aarch64-core.c (create_feature_aarch64_core):
1232         Regenerate.
1233         * features/aarch64-core.xml: Add cpsr flags.
1234
1235 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1236
1237         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1238         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1239
1240 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1241
1242         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1243         field.
1244         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1245         use.
1246         (arm_record_special_symbol): Don't insert new symbol in sorted
1247         position, push it at the end.
1248
1249 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1250
1251         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1252         (arm_mapping_symbol_s): Remove.
1253         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1254         (arm_mapping_symbol_vec): New typedef.
1255         (struct arm_per_objfile): Add constructor.
1256         <section_maps>: Change type to
1257         std::unique_ptr<arm_mapping_symbol_vec[]>.
1258         (arm_compare_mapping_symbols): Remove.
1259         (arm_find_mapping_symbol): Adjust to section_maps type change.
1260         (arm_objfile_data_free): Call delete on arm_per_objfile.
1261         (arm_record_special_symbol): Adjust to section_maps type change.
1262         Allocate arm_per_objfile with new.
1263
1264 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1265
1266         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1267         with the command prefix.
1268
1269 2019-06-25  Tom Tromey  <tom@tromey.com>
1270
1271         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1272         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1273
1274 2019-06-25  Tom Tromey  <tom@tromey.com>
1275
1276         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1277         type.
1278         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1279         protected.
1280
1281 2019-06-25  Tom Tromey  <tom@tromey.com>
1282
1283         * tui/tui-winsource.c
1284         (tui_source_window_base::set_is_exec_point_at): Add check against
1285         LOA_ADDRESS.
1286
1287 2019-06-25  Tom Tromey  <tom@tromey.com>
1288
1289         * tui/tui-source.c (tui_set_source_content): Don't check before
1290         xfree.
1291         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1292
1293 2019-06-25  Tom Tromey  <tom@tromey.com>
1294
1295         * tui/tui-winsource.h (tui_update_source_window_as_is)
1296         (tui_alloc_source_buffer, tui_line_is_displayed)
1297         (tui_addr_is_displayed): Change type of win_info.
1298         * tui/tui-winsource.c (tui_update_source_window_as_is)
1299         (tui_clear_source_content, tui_show_source_line)
1300         (tui_show_source_content, tui_source_window_base::refill)
1301         (tui_source_window_base::set_is_exec_point_at)
1302         (tui_source_window_base::set_is_exec_point_at)
1303         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1304         (tui_alloc_source_buffer, tui_line_is_displayed)
1305         (tui_addr_is_displayed): Change type of win_info.  Update.
1306         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1307         (tui_source_window_base::do_make_visible_with_new_height):
1308         Update.
1309         * tui/tui-source.c (tui_set_source_content)
1310         (tui_set_source_content_nil)
1311         (tui_source_window::do_scroll_vertical): Update.
1312         * tui/tui-layout.c (show_layout): Update.
1313         * tui/tui-disasm.c (tui_set_disassem_content)
1314         (tui_disasm_window::do_scroll_vertical): Update.
1315         * tui/tui-data.h (tui_win_content): Remove.
1316         (struct tui_gen_win_info) <content, content_size>: Remove.
1317         (struct tui_source_element): Add initializers and destructor.
1318         (union tui_which_element, struct tui_win_element): Remove.
1319         (struct tui_source_window_base) <content>: New field.
1320         (struct tui_data_window): Remove destructor.
1321         (tui_alloc_content, tui_free_win_content)
1322         (tui_free_all_source_wins_content): Don't declare.
1323         * tui/tui-data.c (tui_initialize_static_data): Update.
1324         (init_content_element, tui_alloc_content): Remove.
1325         (~tui_gen_win_info): Update.
1326         (~tui_data_window, tui_free_all_source_wins_content)
1327         (tui_free_win_content, free_content, free_content_elements):
1328         Remove.
1329
1330 2019-06-25  Tom Tromey  <tom@tromey.com>
1331
1332         * tui/tui-winsource.h (tui_clear_source_content)
1333         (tui_erase_source_content, tui_show_source_content): Change type
1334         of win_info.
1335         * tui/tui-winsource.c (tui_clear_source_content)
1336         (tui_erase_source_content, tui_show_source_content): Change type
1337         of win_info.
1338         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1339         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1340         win_info.
1341         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1342         win_info.
1343         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1344
1345 2019-06-25  Tom Tromey  <tom@tromey.com>
1346
1347         * tui/tui-winsource.c (tui_clear_source_content)
1348         (tui_source_window_base::set_is_exec_point_at): Update.
1349         * tui/tui-source.c (tui_set_source_content_nil): Update.
1350         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1351         a bool.
1352         * tui/tui-data.c (init_content_element): Update.
1353
1354 2019-06-25  Tom Tromey  <tom@tromey.com>
1355
1356         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1357         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1358         * tui/tui-layout.c (init_and_make_win): Update.
1359         * tui/tui.h (enum tui_win_type): Update.
1360         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1361         tui_win_is_auxillary.
1362         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1363         tui_win_is_auxillary.
1364
1365 2019-06-25  Tom Tromey  <tom@tromey.com>
1366
1367         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1368         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1369         (tui_delete_data_content_windows, tui_display_all_data)
1370         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1371         Update.
1372         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1373         * tui/tui-regs.c (tui_last_regs_line_no)
1374         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1375         (tui_show_registers): Update.
1376         (tui_show_register_group): Return void.  Update.
1377         (tui_display_registers_from, tui_display_reg_element_at_line)
1378         (tui_display_registers_from_line, tui_check_register_values):
1379         Update.
1380         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1381         member.
1382         (struct tui_data_window) <regs_content>: Now a std::vector.
1383         <regs_content_count>: Remove.
1384         (tui_add_content_elements, tui_free_data_content): Don't declare.
1385         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1386         (init_content_element): Remove DATA_WIN case.  Add assert.
1387         (tui_add_content_elements): Remove.
1388         (tui_data_window): Update.
1389         (tui_free_data_content): Remove.
1390         (free_content_elements): Remove DATA_WIN case.
1391
1392 2019-06-25  Tom Tromey  <tom@tromey.com>
1393
1394         * tui/tui-data.c (tui_data_item_window): Update.
1395         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1396         * tui/tui-windata.c (tui_display_all_data)
1397         (tui_display_data_from_line): Update.
1398         (tui_check_data_values): Remove.
1399         * tui/tui-regs.c (tui_show_register_group)
1400         (tui_display_reg_element_at_line): Update.
1401         * tui/tui-hooks.c (tui_register_changed)
1402         (tui_refresh_frame_and_register_information): Call
1403         tui_check_register_values.
1404         * tui/tui-data.h (struct tui_data_window) <data_content,
1405         data_content_count, data_type>: Remove.
1406         (enum tui_data_type): Remove.
1407
1408         * tui/tui-data.c (tui_data_window::clear_detail)
1409         (~tui_data_window): Update.
1410
1411 2019-06-25  Tom Tromey  <tom@tromey.com>
1412
1413         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1414         declare.
1415         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1416         Rename from tui_first_data_item_displayed.  Update.
1417         (tui_data_window::refresh_all)
1418         (tui_data_window::do_scroll_vertical): Update.
1419         * tui/tui-data.h (struct tui_data_window)
1420         <first_data_item_displayed>: Declare new method.
1421
1422 2019-06-25  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1425         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1426         contents...
1427         (tui_initialize_static_data): ...here.
1428
1429 2019-06-25  Tom Tromey  <tom@tromey.com>
1430
1431         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1432         (tui_display_registers_from, tui_check_register_values): Update.
1433         (tui_display_register): Remove win_info parameter; update.
1434         (tui_get_register): Change type of parameters.
1435         * tui/tui-data.h (struct tui_data_element): Remove.
1436         (union tui_which_element) <data>: Remove.
1437         <data_window>: Change type.
1438         (struct tui_data_item_window): New.
1439         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1440         case.  Add assert.
1441         (~tui_data_item_window): New destructor.
1442         (free_content_elements): Remove DATA_ITEM_WIN case.
1443
1444 2019-06-25  Tom Tromey  <tom@tromey.com>
1445
1446         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1447         Remove.
1448
1449 2019-06-25  Tom Tromey  <tom@tromey.com>
1450
1451         * tui/tui-data.h (struct tui_command_element): Remove.
1452         (union tui_which_element) <command>: Remove.
1453         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1454         assert.
1455         (free_content_elements): Remove CMD_WIN case.
1456
1457 2019-06-25  Tom Tromey  <tom@tromey.com>
1458
1459         * tui/tui-layout.c (tui_set_layout): Update.
1460         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1461         * tui/tui-data.c (layout_def): Update.
1462
1463 2019-06-25  Tom Tromey  <tom@tromey.com>
1464
1465         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1466         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1467         (tui_source_window_base::set_new_height): Update.
1468         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1469         Update.
1470         (tui_set_locator_fullname, tui_set_locator_info)
1471         (tui_show_frame_info): Update.
1472         * tui/tui-source.c (tui_set_source_content)
1473         (tui_source_is_displayed): Update.
1474         * tui/tui-layout.c (show_source_disasm_command, show_data)
1475         (show_source_or_disasm_and_command): Update.
1476         * tui/tui-disasm.c (tui_set_disassem_content)
1477         (tui_get_begin_asm_address): Update.
1478         * tui/tui-data.h (struct tui_locator_element): Remove.
1479         (union tui_which_element) <locator>: Remove.
1480         (struct tui_locator_window): New.
1481         (tui_locator_win_info_ptr): Change return type.
1482         * tui/tui-data.c (_locator): Change type.
1483         (tui_locator_win_info_ptr): Change return type.
1484         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1485         (tui_alloc_content): Add assert.
1486
1487 2019-06-25  Tom Tromey  <tom@tromey.com>
1488
1489         * tui/tui-winsource.c
1490         (tui_exec_info_window::maybe_allocate_content): New method.
1491         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1492         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1493         (make_source_or_disasm_window): Add cast.
1494         * tui/tui-data.h (union tui_which_element) <simple_string>:
1495         Remove.
1496         (struct tui_source_info): New.
1497         (struct tui_source_window_base) <execution_info>: Change type.
1498         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1499         case, and add assert.
1500         (tui_alloc_content): Add assert.
1501
1502 2019-06-25  Tom Tromey  <tom@tromey.com>
1503
1504         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1505         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1506         * tui/tui-data.c (tui_alloc_win_info): Remove.
1507
1508 2019-06-25  Tom Tromey  <tom@tromey.com>
1509
1510         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1511         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1512         can_highlight.
1513
1514 2019-06-25  Tom Tromey  <tom@tromey.com>
1515
1516         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1517         make_visible_with_new_height method.
1518         (tui_win_info::make_visible_with_new_height): New method.
1519         (tui_source_window_base::do_make_visible_with_new_height)
1520         (tui_data_window::do_make_visible_with_new_height)
1521         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1522         (make_visible_with_new_height): Remove.
1523         (tui_resize_all, tui_adjust_win_heights): Use
1524         make_visible_with_new_height method.
1525         * tui/tui-data.h (struct tui_win_info)
1526         <do_make_visible_with_new_height, make_visible_with_new_height>:
1527         New methods.
1528         (struct tui_source_window_base, struct tui_data_window)
1529         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1530         methods.
1531
1532 2019-06-25  Tom Tromey  <tom@tromey.com>
1533
1534         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1535         method.
1536         (update_tab_width): Call update_tab_width method.
1537         * tui/tui-data.h (struct tui_win_info)
1538         (struct tui_source_window_base) <update_tab_width>: New methods.
1539
1540 2019-06-25  Tom Tromey  <tom@tromey.com>
1541
1542         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1543         parameter.
1544         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1545         parameter.
1546         (tui_gen_win_info::make_visible): Update.
1547         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1548         parameter.
1549         * tui/tui-data.h (enum tui_box): New enum.
1550         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1551
1552 2019-06-25  Tom Tromey  <tom@tromey.com>
1553
1554         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1555         init_and_make_win for EXEC_INFO_WIN.
1556         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1557         longer inline.
1558         (struct tui_win_info) <~tui_win_info>: Inline.
1559         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1560         Don't declare.
1561         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1562         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1563         Remove.
1564         (tui_initialize_static_data): Update.
1565         (~tui_gen_win_info): Handle more cleanup here.
1566         (~tui_source_window_base): Delete "execution_info".
1567         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1568
1569 2019-06-25  Tom Tromey  <tom@tromey.com>
1570
1571         * tui/tui-layout.c (make_command_window): Don't set
1572         can_highlight.
1573         (show_source_disasm_command): Call the reset method.
1574         (show_data): Don't set can_highlight.  Call the reset method.
1575         (tui_gen_win_info::reset): Rename from init_gen_win_info
1576         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1577         (show_source_or_disasm_and_command): Call the reset method.
1578         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1579         (struct tui_cmd_window): Set can_highlight.
1580
1581 2019-06-25  Tom Tromey  <tom@tromey.com>
1582
1583         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1584         from make_visible.
1585         (tui_make_visible, tui_make_invisible): Rewrite.
1586         (tui_win_info::make_visible): Remove.
1587         (tui_source_window_base::make_visible): Update.
1588         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1589         method.  Moved from...
1590         (struct tui_win_info) <make_visible>: ...here.
1591
1592 2019-06-25  Tom Tromey  <tom@tromey.com>
1593
1594         * tui/tui-winsource.c
1595         (tui_source_window_base::do_scroll_horizontal): Remove direction
1596         parameter.
1597         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1598         direction parameter.
1599         * tui/tui-win.c (tui_win_info::forward_scroll)
1600         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1601         (tui_win_info::right_scroll): Update.
1602         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1603         direction parameter.
1604         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1605         direction parameter.
1606         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1607         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1608         Remove direction parameter.
1609         (struct tui_source_window_base, struct tui_source_window)
1610         (struct tui_disasm_window, struct tui_data_window)
1611         (struct tui_cmd_window): Update.
1612
1613 2019-06-25  Tom Tromey  <tom@tromey.com>
1614
1615         * tui/tui-winsource.h (tui_set_exec_info_content)
1616         (tui_show_exec_info_content, tui_erase_exec_info_content)
1617         (tui_clear_exec_info_content, tui_update_exec_info): Change
1618         argument to tui_source_window_base.
1619         * tui/tui-winsource.c (tui_set_exec_info_content)
1620         (tui_show_exec_info_content, tui_erase_exec_info_content)
1621         (tui_clear_exec_info_content, tui_update_exec_info): Change
1622         argument to tui_source_window_base.
1623
1624 2019-06-25  Tom Tromey  <tom@tromey.com>
1625
1626         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1627         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1628
1629 2019-06-25  Tom Tromey  <tom@tromey.com>
1630
1631         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1632         check.
1633
1634 2019-06-25  Tom Tromey  <tom@tromey.com>
1635
1636         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1637         type to void.
1638         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1639         type to void.
1640         * tui/tui-source.c (tui_set_source_content): Update.
1641         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1642
1643 2019-06-25  Tom Tromey  <tom@tromey.com>
1644
1645         * tui/tui-win.c (window_name_completer, tui_set_focus)
1646         (tui_all_windows_info): Use name method.
1647         * tui/tui-data.h (struct tui_gen_win_info)
1648         (struct tui_source_window, struct tui_disasm_window)
1649         (struct tui_data_window, struct tui_cmd_window) <name>: New
1650         method.
1651         (tui_win_name): Don't declare.
1652         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1653         (tui_win_name): Remove.
1654
1655 2019-06-25  Tom Tromey  <tom@tromey.com>
1656
1657         * tui/tui-winsource.h (tui_update_source_window)
1658         (tui_update_source_window_as_is): Change parameter type.
1659         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1660         to be a tui_source_window_base.
1661         (tui_update_source_window_as_is): Likewise.
1662         * tui/tui-win.c (make_visible_with_new_height): Update.
1663
1664 2019-06-25  Tom Tromey  <tom@tromey.com>
1665
1666         * tui/tui-winsource.c (tui_erase_source_content)
1667         (tui_show_source_content, tui_show_exec_info_content)
1668         (tui_erase_exec_info_content): Use refresh_window method.
1669         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1670         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1671         from tui_refresh_win.
1672         (tui_data_window::refresh_window): New method.
1673         (tui_win_info::refresh, tui_source_window_base::refresh)
1674         (tui_refresh_all): Use refresh_window method.
1675         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1676         method.
1677         * tui/tui-regs.c (tui_display_register): Call refresh_window
1678         method.
1679         * tui/tui-layout.c (show_source_disasm_command)
1680         (show_source_or_disasm_and_command): Call refresh_window method.
1681         * tui/tui-data.h (struct tui_gen_win_info)
1682         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1683         New method.
1684
1685 2019-06-25  Tom Tromey  <tom@tromey.com>
1686
1687         * tui/tui.c (tui_rl_other_window, tui_enable)
1688         (tui_is_window_visible, tui_get_command_dimension): Update.
1689         * tui/tui-winsource.c (tui_update_source_window_as_is)
1690         (tui_clear_source_content, tui_erase_source_content)
1691         (tui_show_source_line, tui_source_window_base::refill)
1692         (tui_source_window_base::do_scroll_horizontal)
1693         (tui_source_window_base::set_is_exec_point_at)
1694         (tui_update_breakpoint_info, tui_set_exec_info_content)
1695         (tui_alloc_source_buffer, tui_line_is_displayed)
1696         (tui_addr_is_displayed): Update.
1697         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1698         (tui_check_and_display_highlight_if_needed)
1699         (tui_win_info::make_visible, tui_win_info::refresh)
1700         (tui_refresh_all): Update.
1701         * tui/tui-windata.c (tui_first_data_item_displayed)
1702         (tui_delete_data_content_windows, tui_erase_data_content)
1703         (tui_display_all_data, tui_data_window::refresh_all)
1704         (tui_check_data_values): Update.
1705         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1706         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1707         (tui_win_info::backward_scroll, tui_refresh_all_win)
1708         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1709         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1710         (tui_source_window_base::set_new_height)
1711         (tui_data_window::set_new_height)
1712         (make_invisible_and_set_new_height)
1713         (make_visible_with_new_height, new_height_ok)
1714         (parse_scrolling_args): Update.
1715         * tui/tui-stack.c (tui_show_frame_info): Update.
1716         * tui/tui-source.c (tui_set_source_content)
1717         (tui_set_source_content_nil, tui_source_is_displayed)
1718         (tui_source_window::do_scroll_vertical): Update.
1719         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1720         (tui_display_registers_from, tui_display_reg_element_at_line)
1721         (tui_check_register_values, tui_reg_command): Update.
1722         * tui/tui-layout.c (tui_default_win_height)
1723         (show_source_disasm_command, show_data, init_and_make_win)
1724         (show_source_or_disasm_and_command): Update.
1725         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1726         (tui_redisplay_readline, tui_mld_flush)
1727         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1728         (tui_getc): Update.
1729         * tui/tui-disasm.c (tui_set_disassem_content)
1730         (tui_disasm_window::do_scroll_vertical): Update.
1731         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1732         Now virtual.
1733         (struct tui_win_info): Derive from tui_gen_win_info.
1734         <~tui_win_info>: Mark as override.
1735         <generic>: Remove member.
1736         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1737         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1738         (~tui_data_window, ~tui_win_info)
1739         (tui_free_all_source_wins_content): Update.
1740         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1741
1742 2019-06-25  Tom Tromey  <tom@tromey.com>
1743
1744         * tui/tui-layout.c (init_and_make_win): Use new.
1745         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1746         destructor, initializers.
1747         (tui_alloc_generic_win_info): Don't declare.
1748         * tui/tui-data.c (_locator): Add argument to constructor.
1749         (source_win, disasm_win): New globals.
1750         (exec_info): Remove.
1751         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1752         Update.
1753         (tui_alloc_generic_win_info): Remove.
1754         (init_content_element): Use new.
1755         (tui_win_info::tui_win_info): Update.
1756         (free_content_elements) <case DATA_WIN>: Use delete.
1757
1758 2019-06-25  Tom Tromey  <tom@tromey.com>
1759
1760         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1761         * tui/tui-windata.c (tui_first_data_item_displayed)
1762         (tui_delete_data_content_windows): Update.
1763         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1764         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1765         (tui_display_registers_from, tui_check_register_values): Update.
1766         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1767         pointer.
1768         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1769         window.
1770         (tui_free_data_content): Update.
1771         (free_content_elements) <case DATA_WIN>: Free the window.
1772
1773 2019-06-25  Tom Tromey  <tom@tromey.com>
1774
1775         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1776         Update.
1777         * tui/tui-layout.c (make_command_window)
1778         (show_source_disasm_command, show_data, init_and_make_win)
1779         (show_source_or_disasm_and_command): Update.
1780         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1781         method.
1782         <can_highight, is_highlighted>: Now bool.
1783         (tui_set_win_highlight): Don't declare.
1784         * tui/tui-data.c (tui_set_win_highlight): Remove.
1785
1786 2019-06-25  Tom Tromey  <tom@tromey.com>
1787
1788         * tui/tui-wingeneral.c (make_visible): Remove check of window
1789         type.
1790
1791 2019-06-25  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui-win.c (tui_win_info::max_height)
1794         (tui_cmd_window::max_height): New methods.
1795         (new_height_ok): Call max_height.
1796         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1797         <max_height>: New method.
1798
1799 2019-06-25  Tom Tromey  <tom@tromey.com>
1800
1801         * tui/tui-win.c (tui_source_window_base::set_new_height)
1802         (tui_data_window::set_new_height): New methods.
1803         (make_invisible_and_set_new_height): Call set_new_height method.
1804         * tui/tui-data.h (struct tui_win_info)
1805         (struct tui_source_window_base, struct tui_data_window)
1806         <set_new_height>: New method.
1807
1808 2019-06-25  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1811         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1812         tui_refresh_data_win.
1813         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1814         method.
1815         (tui_refresh_all_win): Call the refresh_all method.
1816         (tui_set_focus): Likewise.
1817         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1818         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1819         Likewise.
1820
1821 2019-06-25  Tom Tromey  <tom@tromey.com>
1822
1823         * tui/tui-winsource.h (tui_refill_source_window)
1824         (tui_set_is_exec_point_at): Don't declare.
1825         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1826         (tui_source_window_base::refill): Rename from
1827         tui_refill_source_window.
1828         (tui_source_window_base::do_scroll_horizontal): Update.
1829         (tui_source_window_base::set_is_exec_point_at): Rename from
1830         tui_set_is_exec_point_at.
1831         (tui_update_all_breakpoint_info): Update.
1832         * tui/tui-stack.c (tui_show_frame_info): Update.
1833         * tui/tui-layout.c (show_data): Add cast.
1834         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1835         * tui/tui-data.h (struct tui_source_window_base) <refill,
1836         set_is_exec_point_at>: New methods.
1837         (tui_source_windows, tui_add_to_source_windows): Update types.
1838         (tui_add_to_source_windows): Remove redundant declaration.
1839         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1840         (tui_source_windows): Change return type.
1841         (tui_clear_source_windows_detail): Update.
1842         (tui_add_to_source_windows): Change type of parameter.
1843         (tui_free_all_source_wins_content): Update.
1844
1845 2019-06-25  Tom Tromey  <tom@tromey.com>
1846
1847         * tui/tui-wingeneral.c (tui_win_info::refresh)
1848         (tui_source_window_base::refresh): New methods.
1849         (tui_refresh_all): Call the refresh method.
1850         * tui/tui-data.h (struct tui_win_info)
1851         (struct tui_source_window_base) <refresh>: New method.
1852
1853 2019-06-25  Tom Tromey  <tom@tromey.com>
1854
1855         * tui/tui.h (tui_is_window_visible): Return bool.
1856         * tui/tui.c (tui_is_window_visible): Return bool.
1857         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1858         (tui_make_visible, tui_make_invisible)
1859         (tui_win_info::make_visible)
1860         (tui_source_window_base::make_visible, make_all_visible)
1861         (tui_make_all_visible, tui_make_all_invisible): Update.
1862         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1863         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1864         bool.
1865         (struct tui_win_info, struct tui_source_window_base)
1866         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1867         * tui/tui-data.c (tui_init_generic_part): Update.
1868
1869 2019-06-25  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1872         (tui_source_window_base::make_visible): New methods.
1873         (make_all_visible): Make method call.
1874         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1875         (struct tui_source_window_base, struct tui_cmd_window): Override
1876         make_visible.
1877         (tui_win_is_source_type): Don't declare.
1878         * tui/tui-data.c (tui_win_is_source_type): Remove.
1879
1880 2019-06-25  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1883         NULL check.
1884
1885 2019-06-25  Tom Tromey  <tom@tromey.com>
1886
1887         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1888         Inline constructor.  Add initializers for members.
1889         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1890         constructors; now inline in class.
1891
1892 2019-06-25  Tom Tromey  <tom@tromey.com>
1893
1894         * tui/tui-regs.c (tui_show_registers): Update.
1895         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1896         bool.
1897         * tui/tui-data.c (tui_data_window::clear_detail)
1898         (tui_data_window): Update.
1899
1900 2019-06-25  Tom Tromey  <tom@tromey.com>
1901
1902         * tui/tui-windata.c (tui_display_all_data)
1903         (tui_display_data_from_line, tui_display_data_from)
1904         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1905         Update.
1906         * tui/tui-regs.c (tui_last_regs_line_no)
1907         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1908         (tui_show_registers, tui_show_register_group)
1909         (tui_display_registers_from, tui_display_reg_element_at_line)
1910         (tui_display_registers_from_line, tui_check_register_values)
1911         (tui_reg_next, tui_reg_prev): Update.
1912         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1913         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1914         tui_data_window.
1915         (struct tui_win_info) <detail>: Remove.  Add new fields from
1916         tui_data_info.
1917         (TUI_DATA_WIN): Add cast.
1918         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1919         (~tui_data_window): Simplify.
1920
1921 2019-06-25  Tom Tromey  <tom@tromey.com>
1922
1923         * tui/tui-layout.c (show_source_disasm_command)
1924         (show_source_or_disasm_and_command): Update.
1925         * tui/tui-io.c (update_cmdwin_start_line)
1926         (tui_redisplay_readline): Update.
1927         * tui/tui-data.h (struct tui_command_info): Remove.
1928         (struct tui_win_info) <detail>: Remove command_info member.
1929         (struct tui_data_window) <start_line>: New member, from
1930         tui_command_info.
1931         (TUI_CMD_WIN): Add casts.
1932
1933 2019-06-25  Tom Tromey  <tom@tromey.com>
1934
1935         * tui/tui-winsource.c (tui_update_source_window)
1936         (tui_refill_source_window)
1937         (tui_source_window_base::do_scroll_horizontal)
1938         (tui_update_breakpoint_info, tui_set_exec_info_content)
1939         (tui_show_exec_info_content, tui_erase_exec_info_content)
1940         (tui_clear_exec_info_content): Update.
1941         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1942         Update.
1943         * tui/tui-win.c (make_invisible_and_set_new_height)
1944         (make_visible_with_new_height): Update.
1945         * tui/tui-source.c (tui_set_source_content)
1946         (tui_show_symtab_source): Update.
1947         * tui/tui-layout.c (extract_display_start_addr)
1948         (show_source_disasm_command, show_data)
1949         (make_source_or_disasm_window)
1950         (show_source_or_disasm_and_command): Update.
1951         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1952         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1953         "gdbarch".
1954         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1955         to tui_source_window_base.
1956         (struct tui_win_info) <detail>: Remove source_info member.
1957         (struct tui_source_window_base) <has_locator>: Inline.
1958         Move contents from tui_source_info; rename has_locator member to
1959         m_has_locator.
1960         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1961         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1962         header file.
1963         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1964         Simplify.
1965         (tui_free_all_source_wins_content): Cast to
1966         tui_source_window_base.
1967
1968 2019-06-25  Tom Tromey  <tom@tromey.com>
1969
1970         * tui/tui-win.c (make_invisible_and_set_new_height)
1971         (make_visible_with_new_height): Call has_locator method.
1972         * tui/tui-layout.c (show_source_disasm_command, show_data)
1973         (show_source_or_disasm_and_command): Update for bool change.
1974         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1975         (tui_win_info) <has_locator>: New method.
1976         (struct tui_source_window_base) <has_locator>: New method.
1977         (tui_win_has_locator): Don't declare.
1978         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1979         from tui_win_has_locator.
1980         (tui_source_window_base): Use false, not FALSE.
1981
1982 2019-06-25  Tom Tromey  <tom@tromey.com>
1983
1984         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1985         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1986         clear_detail method directly.
1987         (tui_clear_win_detail): Remove.
1988
1989 2019-06-25  Tom Tromey  <tom@tromey.com>
1990
1991         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1992         "this", not TUI_DISASM_WIN.
1993
1994 2019-06-25  Tom Tromey  <tom@tromey.com>
1995
1996         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1997         declare.
1998         * tui/tui-winsource.c
1999         (tui_source_window_base::do_scroll_horizontal): Rename from
2000         tui_horizontal_source_scroll.
2001         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2002         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2003         from tui_vertical_data_scroll.
2004         * tui/tui-win.h (tui_scroll): Don't declare.
2005         * tui/tui-win.c (tui_win_info::forward_scroll)
2006         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2007         (tui_win_info::right_scroll): Rename and update.
2008         (tui_scroll_forward_command, tui_scroll_backward_command)
2009         (tui_scroll_left_command, tui_scroll_right_command): Update.
2010         (tui_scroll): Remove.
2011         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2012         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2013         from tui_vertical_source_scroll.
2014         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2015         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2016         from tui_vertical_disassem_scroll.
2017         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2018         do_scroll_horizontal>: New methods.
2019         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2020         Likewise.
2021         (struct tui_source_window_base): Add do_scroll_horizontal.
2022         (struct tui_source_window, struct tui_disasm_window): Add
2023         do_scroll_vertical.
2024         (struct tui_data_window, struct tui_cmd_window): Add
2025         do_scroll_horizontal and do_scroll_vertical.
2026         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2027
2028 2019-06-25  Tom Tromey  <tom@tromey.com>
2029
2030         * tui/tui-data.h (struct tui_source_window_base): New struct.
2031         (struct tui_source_window): Derive from tui_source_window_base.
2032         (struct tui_disasm_window): New struct.
2033         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2034         from tui_source_window::clear_detail.
2035         (tui_source_window_base): Rename from tui_source_window.
2036         (~tui_source_window_base): Rename from ~tui_source_window.
2037         (tui_alloc_win_info): Create a tui_disasm_window.
2038
2039 2019-06-25  Tom Tromey  <tom@tromey.com>
2040
2041         * tui/tui-data.h (struct tui_source_window)
2042         (struct tui_data_window): Declare destructors.
2043         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2044         destructors.
2045         (tui_win_info): Simplify.
2046
2047 2019-06-25  Tom Tromey  <tom@tromey.com>
2048
2049         * tui/tui-winsource.c (tui_display_main)
2050         (tui_update_source_windows_with_addr)
2051         (tui_update_all_breakpoint_info): Update.
2052         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2053         (new_height_ok, parse_scrolling_args): Update.
2054         * tui/tui-stack.c (tui_show_frame_info): Update.
2055         * tui/tui-data.h (struct tui_list): Remove.
2056         (tui_source_windows): Return a reference to a std::vector.
2057         * tui/tui-data.c (source_windows): Now a std::vector.
2058         (tui_source_windows): Change return type.
2059         (tui_clear_source_windows): Rewrite.
2060         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2061         (tui_free_all_source_wins_content): Rewrite.
2062
2063 2019-06-25  Tom Tromey  <tom@tromey.com>
2064
2065         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2066         (struct tui_data_window, struct tui_cmd_window): Declare
2067         clear_detail method.
2068         * tui/tui-data.c (tui_source_window::clear_detail)
2069         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2070         methods.
2071         (tui_clear_win_detail): Simplify.
2072
2073 2019-06-25  Tom Tromey  <tom@tromey.com>
2074
2075         * tui/tui-layout.c (make_source_window, make_disasm_window)
2076         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2077         Return the new window.
2078         (show_source_disasm_command, show_data)
2079         (show_source_or_disasm_and_command): Update.
2080
2081 2019-06-25  Tom Tromey  <tom@tromey.com>
2082
2083         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2084         parameter.  Return the new window.
2085         (show_source_disasm_command): Update and remove NULL check.
2086         (show_source_or_disasm_and_command): Update.
2087
2088 2019-06-25  Tom Tromey  <tom@tromey.com>
2089
2090         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2091
2092 2019-06-25  Tom Tromey  <tom@tromey.com>
2093
2094         * tui/tui-data.h (struct tui_win_info): Make constructor
2095         protected.  Make destructor virtual.  Add initializers.
2096         (tui_source_window, tui_data_window, tui_cmd_window): New
2097         classes.
2098         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2099         constructor.  Add "type" parameter.
2100         (tui_source_window, tui_data_window, tui_cmd_window): New
2101         constructors.
2102         (tui_alloc_win_info): Instantiate the appropriate subclass.
2103
2104 2019-06-25  Tom Tromey  <tom@tromey.com>
2105
2106         * tui/tui-win.c (tui_resize_all): Use delete.
2107         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2108         destructor.
2109         (tui_free_window): Don't declare.
2110         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2111         Update.
2112
2113 2019-06-25  Tom Tromey  <tom@tromey.com>
2114
2115         * tui/tui-data.h (struct tui_win_info): Add constructor.
2116         * tui/tui-data.c (tui_alloc_win_info): Use new.
2117         (tui_free_window): Use delete.
2118
2119 2019-06-22  Tom Tromey  <tom@tromey.com>
2120
2121         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2122         declare.
2123         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2124
2125 2019-06-22  Tom Tromey  <tom@tromey.com>
2126
2127         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2128         declare.
2129         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2130
2131 2019-06-22  Tom de Vries  <tdevries@suse.de>
2132
2133         * dwarf2read.c (create_addrmap_from_aranges)
2134         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2135         instead of '%zu'.
2136
2137 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2138
2139         * dwarf2read.h (dwarf2_section_info_def): Remove.
2140         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2141         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2142         std::vector<dwarf2_section_info>.
2143         (struct dwo_file) <~dwo_file>: Remove.
2144         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2145         types field.
2146         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2147         (dwarf2_read_debug_names): Likewise.
2148         (create_debug_types_hash_table): Change parameter type to
2149         array_view, adjust code accordingly.
2150         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2151         (partial_die_info::fixup): Likewise.
2152         (determine_prefix): Likewise.
2153         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2154
2155 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2156
2157         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2158         gdb_bfd_ref_ptr.
2159         <~dwo_file>: Remove call to gdb_bfd_unref.
2160         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2161         gdb_bfd_ref_ptr::get.
2162
2163 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2164
2165         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2166         type to htab_up.
2167         * dwarf2read.c (struct dwo_file): Initialize fields.
2168         <~dwo_file>: New.
2169         (free_dwo_file): Remove, move content to ~dwo_file.
2170         (struct dwo_file_deleter): Remove.
2171         (dwo_file_up>: Remove custom deleter.
2172         (free_dwo_files): Remove.
2173         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2174         dwo_files.
2175         (process_skeletonless_type_units): Call unique_ptr::get.
2176         (allocate_dwo_file_hash_table): Add deleter to created hash
2177         table.  Change return type to htab_up.
2178         (lookup_dwo_file_slot): Don't memset dwo_file, call
2179         unique_ptr::get.
2180         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2181         (create_dwo_unit_in_dwp_v2): Likewise.
2182         (open_and_init_dwo_file): Likewise.
2183         (free_dwo_file_from_slot): Remove.
2184
2185 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2186
2187         * dwarf2read.h (struct dwarf2_section_info) <readin,
2188         is_virtual>: Change type to bool.
2189         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2190         true instead of 1.
2191
2192 2019-06-19  Tom Tromey  <tom@tromey.com>
2193
2194         * tui/tui-data.h (tui_init_content_element): Don't declare.
2195
2196 2019-06-19  Tom Tromey  <tom@tromey.com>
2197
2198         * tui/tui-data.h (tui_init_win_info): Don't declare.
2199
2200 2019-06-19  Tom de Vries  <tdevries@suse.de>
2201
2202         * dwarf2read.h (abstract_to_concrete): Change type to
2203         std::unordered_map<sect_offset, std::vector<sect_offset>,
2204         gdb::hash_enum<sect_offset>>.
2205
2206 2019-06-19  Tom Tromey  <tromey@adacore.com>
2207
2208         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2209         EVAL_AVOID_SIDE_EFFECTS specially.
2210
2211 2019-06-19  Tom Tromey  <tromey@adacore.com>
2212
2213         * source-cache.c (highlighter): New global.
2214         (source_cache::get_source_lines): Create a highlighter on demand.
2215
2216 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2217
2218         * defs.h (deprecated_interactive_hook): Delete declaration.
2219         * interps.c (clear_interpreter_hooks): Remove use of
2220         deprecated_interactive_hook.
2221         * top.c (deprecated_interactive_hook): Delete definition.
2222         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2223
2224 2019-06-18  Tom de Vries  <tdevries@suse.de>
2225
2226         PR gdb/24515
2227         * dwarf2read.h (abstract_to_concrete): Change type from
2228         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2229         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2230         * dwarf2read.c (read_variable): Update.
2231         (dwarf2_fetch_die_loc_sect_off): Update.
2232
2233 2019-06-17  Tom de Vries  <tdevries@suse.de>
2234
2235         PR gdb/24617
2236         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2237         accessing parent[parent_len - 1].
2238
2239 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2240
2241         PR gdb/24364
2242         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2243         call dtrace_process_dof with NULL dof.
2244
2245 2019-06-16  Tom de Vries  <tdevries@suse.de>
2246
2247         PR gdb/24445
2248         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2249
2250 2019-06-16  Tom Tromey  <tom@tromey.com>
2251
2252         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2253         (make_all_visible): Use address of member.
2254
2255 2019-06-16  Tom Tromey  <tom@tromey.com>
2256
2257         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2258         (tui_free_window, free_content, free_content_elements): Remove
2259         unnecessary cast.
2260         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2261         cast.
2262         * tui/tui-regs.c (tui_show_register_group)
2263         (tui_display_registers_from, tui_display_reg_element_at_line):
2264         Remove unnecessary cast.
2265
2266 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2267
2268         * linux-nat.c (normal_mask): Delete.
2269         (_initialize_linux_nat): Don't initialise normal_mask.
2270
2271 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2272
2273         PR gdb/24445
2274         * dwarf-index-write.h (write_psymtabs_to_index): Add
2275         dwz_basename parameter.
2276         * dwarf-index-write.c (write_gdbindex): Move file writing to
2277         write_gdbindex_1.  Change return type void.
2278         (assert_file_size): Move up, remove filename parameter.
2279         (write_gdbindex_1): New function.
2280         (write_debug_names): Change return type to void, call
2281         assert_file_size.
2282         (struct index_wip_file): New struct.
2283         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2284         file logic to index_wip_file.  Write index for dwz file if
2285         needed.
2286         (save_gdb_index_command): Pass basename of dwz file, if present.
2287         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2288         build-id of dwz file, if present.
2289         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2290         (dwarf2_get_dwz_file): Likewise.
2291         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2292         (dwarf2_get_dwz_file): Likewise.
2293
2294 2019-06-16  Tom Tromey  <tom@tromey.com>
2295
2296         * coffread.c (process_coff_symbol): Use xstrdup.
2297         * value.c (create_internalvar): Use xstrdup.
2298
2299 2019-06-16  Tom Tromey  <tom@tromey.com>
2300
2301         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2302         * breakpoint.c (stopin_command, stopat_command)
2303         (until_break_command, decode_location_default): Remove unnecessary
2304         cast.
2305         * utils.c (subset_compare): Remove unnecessary cast.
2306         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2307         cast.
2308         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2309         cast.
2310         * infcmd.c (path_command): Remove unnecessary cast.
2311         * coffread.c (decode_type): Remove unnecessary cast.
2312         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2313         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2314         * tui/tui-stack.c (tui_show_locator_content)
2315         (tui_show_frame_info): Remove unnecessary cast.
2316         * tui/tui-win.c (tui_scroll_forward_command)
2317         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2318         (parse_scrolling_args): Remove unnecessary cast.
2319         * tui/tui-data.c (init_win_info, tui_del_window)
2320         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2321         (free_content_elements): Remove unnecessary cast.
2322         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2323         unnecessary cast.
2324         * tui/tui-source.c (tui_set_source_content)
2325         (tui_vertical_source_scroll): Remove unnecessary cast.
2326         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2327         cast.
2328         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2329         * tui/tui-regs.c (tui_display_registers_from)
2330         (tui_display_register): Remove unnecessary cast.
2331         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2332         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2333         (make_visible): Remove unnecessary cast.
2334         * tui/tui-winsource.c (tui_erase_source_content)
2335         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2336         unnecessary cast.
2337         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2338         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2339         * stabsread.c (read_type, read_array_type, read_range_type):
2340         Remove unnecessary cast.
2341         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2342         (parse_symbol, parse_type, upgrade_type, parse_external)
2343         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2344         unnecessary cast.
2345         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2346
2347 2019-06-16  Tom Tromey  <tom@tromey.com>
2348
2349         * tui/tui-data.c (tui_alloc_generic_win_info)
2350         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2351         checks.
2352
2353 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2354             Andrew Burgess  <andrew.burgess@embecosm.com>
2355
2356         * f-typeprint.c (f_print_type): Don't return early for not
2357         associated or not allocated types.
2358         (f_type_print_varspec_suffix): Add print_rank parameter and print
2359         ranks of array types in case they dangling.
2360         (f_type_print_base): Add print_rank parameter.
2361
2362 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2363
2364         * NEWS: Mention new MI commands.
2365         * break-catch-throw.c (enum exception_event_kind): Move to
2366         breakpoint.h.
2367         (print_mention_exception_catchpoint): Output text as a single
2368         message.
2369         (catch_exception_command_1): Rename to...
2370         (catch_exception_event): ...this, make non-static, update header
2371         command, and change some parameter types.
2372         (catch_catch_command): Update for changes to
2373         catch_exception_command_1.
2374         (catch_throw_command): Likewise.
2375         (catch_rethrow_command): Likewise.
2376         * breakpoint.c (enum exception_event_kind): Delete.
2377         * breakpoint.h (enum exception_event_kind): Moved here from
2378         break-catch-throw.c.
2379         (catch_exception_event): Declare.
2380         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2381         (mi_cmd_catch_throw): New function.
2382         (mi_cmd_catch_rethrow): New function.
2383         (mi_cmd_catch_catch): New function.
2384         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2385         'catch-catch' entries.
2386         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2387         (mi_cmd_catch_rethrow): Declare.
2388         (mi_cmd_catch_catch): Declare.
2389
2390 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2391
2392         * annotate.c (annotate_source_line): Change return type to void,
2393         update implementation to match.
2394         * annotate.h (annotate_source_line): Change return type to void,
2395         update header comment.
2396         * stack.c (print_frame_info): Don't change what frame information
2397         is printed based on whether annotations are on or not.
2398
2399 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2400
2401         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2402         (annotate_source): Make static.
2403         (annotate_source_line): Moved from source.c and renamed from
2404         identify_source_line.  Update the return type.
2405         * annotate.h (annotate_source): Delete declaration.
2406         (annotate_source_line): Declaration moved from source.h, and
2407         renamed from identify_source_line.  Return type updated.
2408         * source.c (identify_source_line): Moved to annotate.c and renamed
2409         to annotate_source_line.
2410         (info_line_command): Remove check of annotation_level.
2411         * source.h (identify_source_line): Move declaration to annotate.h
2412         and rename to annotate_source_line.
2413         * stack.c: Add 'annotate.h' include.
2414         (print_frame_info): Remove check of annotation_level before
2415         calling annotate_source_line.
2416
2417 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2418
2419         * source-cache.c (source_cache::get_plain_source_lines): Use
2420         open_source_file_with_line_charpos instead of just
2421         open_source_file, remove call to find_source_lines.
2422         (source_cache::get_source_lines): Likewise.
2423         * source.c (find_source_lines): Make static.
2424         (get_filename_and_charpos): Renamed into...
2425         (open_source_file_with_line_charpos): ..this along with changes to
2426         return a scoped_fd, and some other minor clean ups.
2427         (identify_source_line): Use open_source_file_with_line_charpos.
2428         (search_command_helper): Use open_source_file_with_line_charpos
2429         instead of just open_source_file, remove call to
2430         find_source_lines.
2431         * source.h (open_source_file_with_line_charpos): Declare new
2432         function.
2433         (find_source_lines): Delete declaration.
2434
2435 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2436
2437         * source.c (get_filename_and_charpos): Remove fullname
2438         parameter.
2439         (identify_source_line): Update call to get_filename_and_charpos.
2440
2441 2019-06-14  Tom Tromey  <tromey@adacore.com>
2442
2443         PR gdb/24502:
2444         * ui-style.h (skip_ansi_escape): Update comment.
2445         * ui-file.h (class no_terminal_escape_file): New class.
2446         * ui-file.c (no_terminal_escape_file::write)
2447         (no_terminal_escape_file::puts): New methods.
2448         * cli/cli-logging.c (handle_redirections): Use
2449         no_terminal_escape_file.
2450
2451 2019-06-14  Tom Tromey  <tromey@adacore.com>
2452
2453         * NEWS: Move convenience variable news above Python news.
2454
2455 2019-06-14  Tom Tromey  <tom@tromey.com>
2456
2457         * gnulib: Move directory to top-level.
2458         * configure.ac: Don't configure gnulib.
2459         * configure: Rebuild.
2460         * common/common-defs.h: Use new path to gnulib.
2461         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2462         (GNULIB_H): Remove.
2463         (INCGNU): Look in new gnulib location.
2464         (HFILES_NO_SRCDIR): Remove gnulib files.
2465         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2466         (generated_files): Remove GNULIB_H.
2467         ($(LIBGNU), all-lib): Remove targets.
2468         (distclean): Don't mention GNULIB_BUILDDIR.
2469         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2470
2471 2019-06-14  Tom Tromey  <tromey@adacore.com>
2472
2473         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2474         Warn if symbol file does not provide any symbols.
2475
2476 2019-06-14  Tom Tromey  <tromey@adacore.com>
2477
2478         * source.c (find_and_open_source): Respect basenames_may_differ.
2479
2480 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2481
2482         * annotate.c (annotate_breakpoints_invalid): Make use of
2483         scoped_restore_terminal_state.
2484         (annotate_frames_invalid): Likewise.
2485
2486 2019-06-14  Tom Tromey  <tromey@adacore.com>
2487
2488         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2489         allow assignment to an internalvar.
2490
2491 2019-06-14  Tom Tromey  <tromey@adacore.com>
2492
2493         * ada-lex.l: Allow "_" in attribute names.
2494
2495 2019-06-14  Tom Tromey  <tromey@adacore.com>
2496
2497         PR gdb/24653:
2498         * regcache.c (registers_changed): Don't call alloca.
2499         * top.c (execute_command): Don't call alloca.
2500
2501 2019-06-13  Pedro Alves  <palves@redhat.com>
2502
2503         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2504         'expression'.  When parsing an expression, error out if there's
2505         junk after "unlimited".
2506         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2507         (do_set_command): Adjust calls to is_unlimited_literal.
2508
2509 2019-06-13  Pedro Alves  <palves@redhat.com>
2510
2511         * compile/compile.c (make_compile_options_def_group): Add braces
2512         around array_view initializer.
2513         * thread.c (make_thread_apply_all_options_def_group)
2514         (make_thread_apply_all_options_def_group): Likewise.
2515
2516 2019-06-13  Pedro Alves  <palves@redhat.com>
2517
2518         * NEWS (New commands): Mention "maint test-options
2519         require-delimiter", "maint test-options unknown-is-error", "maint
2520         test-options unknown-is-operand" and "maint show
2521         test-options-completion-result".
2522         (New command options, command completion): New section.
2523         (Completion improvements): New section.
2524         Mention that you can abbreviate "unlimited".
2525
2526 2019-06-13  Pedro Alves  <palves@redhat.com>
2527
2528         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2529         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2530         * unittests/cli-utils-selftests.c (test_parse_flags)
2531         (test_parse_flags_qcs): Delete.
2532         (test_cli_utils): Don't call deleted functions.
2533
2534 2019-06-13  Pedro Alves  <palves@redhat.com>
2535
2536         * thread.c: Include "cli/cli-option.h".
2537         (tp_array_compar_ascending): Global.
2538         (tp_array_compar): Delete function.
2539         (tp_array_compar_ascending, tp_array_compar_descending): New
2540         functions.
2541         (ascending_option_def, qcs_flag_option_def)
2542         (thr_qcs_flags_option_defs)
2543         (make_thread_apply_all_options_def_group)
2544         (make_thread_apply_options_def_group): New.
2545         (thread_apply_all_command): Use gdb::option::process_options.
2546         (thread_apply_command_completer)
2547         (thread_apply_all_command_completer): New.
2548         (thread_apply_command): Use gdb::option::process_options.
2549         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2550         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2551         to generate help text of "thread apply".  Adjust "taas"'s help.
2552         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2553         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2554
2555 2019-06-13  Pedro Alves  <palves@redhat.com>
2556
2557         * thread.c (thread_apply_command): Check for invalid TID with
2558         isdigit instead of !isalpha.
2559
2560 2019-06-13  Pedro Alves  <palves@redhat.com>
2561
2562         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2563         (validate_flags_qcs): New.
2564         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2565         (validate_flags_qcs): Declare.
2566         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2567         (make_frame_apply_options_def_group): New.
2568         (frame_apply_command_count): Process options with
2569         gdb::option::process_options.
2570         (frame_apply_completer): New.
2571         (frame_apply_level_completer, frame_apply_all_completer)
2572         (frame_apply_completer): New.
2573         (_initialize_stack): Update help of "frame apply", "frame apply
2574         level", "frame apply all" and "faas" to mention supported options
2575         and install command completers.
2576         * stack.h (frame_apply_all_completer): Declare.
2577         * thread.c: Include "stack.h".
2578         (tfaas_command): Add "--".
2579         (_initialize_thread): Update help "tfaas" to mention supported
2580         options and install command completer.
2581
2582 2019-06-13  Pedro Alves  <palves@redhat.com>
2583
2584         * completer.c (complete_nested_command_line): New.
2585         (gdb_completion_word_break_characters_throw): Add assertion.
2586         * completer.h (complete_nested_command_line): Declare.
2587
2588 2019-06-13  Pedro Alves  <palves@redhat.com>
2589
2590         * stack.c (parse_backtrace_qualifiers): New.
2591         (backtrace_command): Use it.
2592         (backtrace_command_completer): Complete on qualifiers.
2593
2594 2019-06-13  Pedro Alves  <palves@redhat.com>
2595
2596         * frame.c: Include "cli/cli-option.h.
2597         (user_set_backtrace_options): New.
2598         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2599         Delete.
2600         (get_prev_frame): Adjust.
2601         (boolean_option_def, uinteger_option_def)
2602         (set_backtrace_option_defs): New.
2603         (_initialize_frame): Adjust and use
2604         gdb::option::add_setshow_cmds_for_options to install "set
2605         backtrace past-main" and "set backtrace past-entry".
2606         * frame.h: Include "cli/cli-option.h".
2607         (struct frame_print_options): Forward declare.
2608         (print_frame_arguments_all, print_frame_arguments_scalars)
2609         (print_frame_arguments_none): Declare.
2610         (print_entry_values): Delete declaration.
2611         (struct frame_print_options, user_frame_print_options): New.
2612         (struct set_backtrace_options): New.
2613         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2614         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2615         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2616         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2617         (list_args_or_locals): Add frame_print_options parameter.
2618         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2619         * python/py-framefilter.c (enumerate_args): Pass down
2620         USER_FRAME_PRINT_OPTIONS.
2621         * stack.c: Include "cli/cli-option.h".
2622         (print_frame_arguments_all, print_frame_arguments_scalars)
2623         (print_frame_arguments_none): Declare.
2624         (print_raw_frame_arguments, print_entry_values): Delete.
2625         (user_frame_print_options): New.
2626         (boolean_option_def, enum_option_def, frame_print_option_defs):
2627         New.
2628         (struct backtrace_cmd_options): New.
2629         (bt_flag_option_def): New.
2630         (backtrace_command_option_defs): New.
2631         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2632         (print_frame_arg, read_frame_arg, print_frame_args)
2633         (print_frame_info, print_frame): Add frame_print_options parameter
2634         and use it.
2635         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2636         (backtrace_command_1): Add frame_print_options and
2637         backtrace_cmd_options parameters and use them.
2638         (make_backtrace_options_def_group): New.
2639         (backtrace_command): Process command options with
2640         gdb::option::process_options.
2641         (backtrace_command_completer): New.
2642         (_initialize_stack): Extend "backtrace"'s help to mention
2643         supported options.  Install completer for "backtrace".
2644         Install some settings commands with add_setshow_cmds_for_options.
2645
2646 2019-06-13  Pedro Alves  <palves@redhat.com>
2647
2648         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2649         and that "set/show print raw frame-arguments" are now deprecated.
2650
2651         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2652         command.
2653         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2654         * stack.c (_initialize_stack): Install "set/show print
2655         raw-frame-arguments", and deprecate "set/show print raw
2656         frame-arguments".
2657         * valprint.c (_initialize_valprint): Deprecate "set/show print
2658         raw".
2659
2660 2019-06-13  Pedro Alves  <palves@redhat.com>
2661
2662         * compile/compile.c (struct compile_options): New.
2663         (compile_flag_option_def, compile_command_option_defs)
2664         (make_compile_options_def_group): New.
2665         (compile_file_command): Handle options with
2666         gdb::option::process_options.
2667         (compile_file_command_completer): New function.
2668         (compile_code_command): Handle options with
2669         gdb::option::process_options.
2670         (compile_code_command_completer): New function.
2671         (_initialize_compiler): Install completers for "compile code" and
2672         "compile file".  Mention available options in "compile code" and
2673         "compile code"'s help.
2674         * completer.c (advance_to_completion_word): New, factored out from
2675         ...
2676         (advance_to_expression_complete_word_point): ... this.
2677         (advance_to_filename_complete_word_point): New.
2678         * completer.h (advance_to_filename_complete_word_point): New
2679         declaration.
2680
2681 2019-06-13  Pedro Alves  <palves@redhat.com>
2682
2683         * compile/compile.c: Include "cli/cli-option.h".
2684         (compile_print_value): Scope data pointer is now a
2685         value_print_options pointer; adjust.
2686         (compile_print_command): Process options.  Scope data pointer is
2687         now a value_print_options pointer; adjust.
2688         (_initialize_compile): Update "compile print"'s help to include
2689         supported options.  Install a completer for "compile print".
2690         * cp-valprint.c (show_vtblprint, show_objectprint)
2691         (show_static_field_print): Delete.
2692         (_initialize_cp_valprint): Don't install "set print
2693         static-members", "set print vtbl", "set print object" here.
2694         * printcmd.c: Include "cli/cli-option.h" and
2695         "common/gdb_optional.h".
2696         (print_command_parse_format): Rework to fill in a
2697         value_print_options instead of a format_data.
2698         (print_value): Change parameter type from format_data pointer to
2699         value_print_options reference.  Adjust.
2700         (print_command_1): Process options.  Adjust to pass down a
2701         value_print_options.
2702         (print_command_completer): New.
2703         (_initialize_printcmd): Install print_command_completer as
2704         handle_brkchars completer for the "print" command.  Update
2705         "print"'s help to include supported options.
2706         * valprint.c: Include "cli/cli-option.h".
2707         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2708         here from cp-valprint.c.
2709         (boolean_option_def, uinteger_option_def)
2710         (value_print_option_defs, make_value_print_options_def_group):
2711         New.  Use gdb::option::add_setshow_cmds_for_options to install
2712         "set print elements", "set print null-stop", "set print repeats",
2713         "set print pretty", "set print union", "set print array", "set
2714         print address", "set print symbol", "set print array-indexes".
2715         * valprint.h: Include <string> and "cli/cli-option.h".
2716         (make_value_print_options_def_group): Declare.
2717         (print_value): Change parameter type from format_data pointer to
2718         value_print_options reference.
2719         (print_command_completer): Declare.
2720
2721 2019-06-13  Pedro Alves  <palves@redhat.com>
2722
2723         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2724         (COMMON_SFILES): Add maint-test-settings.c.
2725         * cli/cli-decode.c (boolean_enums): New global, factored out from
2726         ...
2727         (add_setshow_boolean_cmd): ... here.
2728         * cli/cli-decode.h (boolean_enums): Declare.
2729         * cli/cli-option.c: New file.
2730         * cli/cli-option.h: New file.
2731         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2732         factored out from ...
2733         (parse_cli_boolean_value(const char *)): ... this.
2734         (is_unlimited_literal): Change parameter type to pointer to
2735         pointer.  Adjust and advance ARG pointer.
2736         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2737         (parse_cli_var_enum): New, factored out from ...
2738         (do_set_command): ... this.  Adjust.
2739         * cli/cli-setshow.h (parse_cli_boolean_value)
2740         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2741         (parse_cli_var_enum): Declare.
2742         * cli/cli-utils.c: Include "cli/cli-option.h".
2743         (get_ulongest): New.
2744         * cli/cli-utils.h (get_ulongest): Declare.
2745         (check_for_argument): New overloads.
2746         * maint-test-options.c: New file.
2747
2748 2019-06-13  Pedro Alves  <palves@redhat.com>
2749
2750         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2751         parse a range if "-" is at the end of the string.
2752
2753 2019-06-13  Pedro Alves  <palves@redhat.com>
2754
2755         * cli/cli-setshow.c (parse_auto_binary_operation)
2756         (parse_cli_boolean_value): Don't allow "o".
2757
2758 2019-06-13  Pedro Alves  <palves@redhat.com>
2759
2760         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2761         * NEWS: Mention maint test-settings KIND.
2762         * maint-test-settings.c: New file.
2763
2764 2019-06-13  Pedro Alves  <palves@redhat.com>
2765
2766         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2767         completer.
2768         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2769         "set" completers.
2770
2771 2019-06-13  Pedro Alves  <palves@redhat.com>
2772
2773         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2774         after item.
2775
2776 2019-06-13  Pedro Alves  <palves@redhat.com>
2777
2778         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2779
2780 2019-06-13  Pedro Alves <palves@redhat.com>
2781
2782         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2783         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2784         call.
2785         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2786         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2787         calls.
2788         (check_for_argument): Skip spaces after argument.
2789
2790 2019-06-13  Pedro Alves  <palves@redhat.com>
2791
2792         * thread.c (thread_apply_command): Adjust TID parsing.
2793         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2794         detected before end of string.
2795         (tid_is_in_list): Error out if LIST is invalid.
2796
2797 2019-06-13  Pedro Alves  <palves@redhat.com>
2798
2799         * completer.c (complete_line_internal_1): Rewind completion word
2800         point.
2801         (completion_tracker::advance_custom_word_point_by): Change
2802         parameter type to int.
2803         * completer.h (completion_tracker::advance_custom_word_point_by):
2804         Likewise.
2805
2806 2019-06-13  Pedro Alves  <palves@redhat.com>
2807
2808         * completer.c (advance_to_completion_word): Handle delimiters.
2809
2810 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2811
2812         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2813
2814 2019-06-11  Tom Tromey  <tom@tromey.com>
2815
2816         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2817         (xmalloc_failed): Move to alloc.c.
2818         * alloc.c: New file.
2819         * Makefile.in (COMMON_SFILES): Add alloc.c.
2820
2821 2019-06-11  Tom Tromey  <tom@tromey.com>
2822
2823         * nat/linux-waitpid.c: Don't include server.h.
2824         (linux_debug): Remove.
2825         (my_waitpid): Update.
2826
2827 2019-06-11  Tom Tromey  <tromey@adacore.com>
2828
2829         * infcall.c (_initialize_infcall): Remove trailing newline from
2830         help.
2831         * user-regs.c (_initialize_user_regs): Remove trailing newline
2832         from help.
2833         * typeprint.c (_initialize_typeprint): Remove trailing newline
2834         from help.
2835         * reverse.c (_initialize_reverse): Remove trailing newlines from
2836         help.
2837         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2838         from help.
2839         * language.c (add_set_language_command): Remove trailing newline
2840         from help.
2841         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2842         help.
2843         * disasm.c (_initialize_disasm): Remove trailing newline from
2844         help.
2845         * top.c (init_main): Remove trailing newline from help.
2846         * interps.c (_initialize_interpreter): Remove trailing newline
2847         from help.
2848         * btrace.c (_initialize_btrace): Remove trailing newlines from
2849         help.
2850         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2851         from help.
2852         * python/python.c (_initialize_python): Remove trailing newline
2853         from help.
2854         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2855         help.
2856         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2857         from help.  Reformat some text.
2858         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2859         from help.
2860         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2861         newline from help.
2862
2863 2019-06-11  Tom Tromey  <tromey@adacore.com>
2864
2865         * darwin-nat.c (darwin_decode_exception_message)
2866         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2867
2868 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2869
2870         * valops.c (value_slice): Check for not allocated or not
2871         associated values.
2872
2873 2019-06-10  Tom de Vries  <tdevries@suse.de>
2874
2875         PR gdb/24618
2876         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2877         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2878         invalid.
2879
2880 2019-06-10  Tom de Vries  <tdevries@suse.de>
2881
2882         PR gdb/24611
2883         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2884         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2885
2886 2019-06-10  Tom de Vries  <tdevries@suse.de>
2887
2888         PR symtab/24545
2889         * symtab.c (struct demangled_name_entry): Add language field.
2890         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2891         static minimal symbol".  Set and use language field.
2892
2893 2019-06-10  Tom Tromey  <tromey@adacore.com>
2894
2895         * ada-lang.c (_initialize_ada_language): Update help text.
2896
2897 2019-06-10  Tom Tromey  <tromey@adacore.com>
2898
2899         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2900         with a newline.
2901         * guile/guile.c (handle_boot_error): Don't end warning with a
2902         newline.
2903         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2904         warning with a newline.
2905         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2906         newline.
2907         (s12z_frame_cache): Likewise.
2908         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2909         a newline.
2910         * solib-svr4.c (disable_probes_interface): Don't end warning with
2911         a newline.
2912         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2913         newline.
2914         * python/python.c (do_finish_initialization): Don't end warning
2915         with a newline.
2916
2917 2019-06-10  Tom Tromey  <tom@tromey.com>
2918
2919         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2920         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2921         gdbpy_enter.
2922
2923 2019-06-10  Tom Tromey  <tromey@adacore.com>
2924
2925         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2926         data.
2927         (elf_new_init): Don't call stabsread_new_init.
2928         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2929         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2930         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2931
2932 2019-06-10  Tom de Vries  <tdevries@suse.de>
2933
2934         PR symtab/16264
2935         PR symtab/24517
2936         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2937
2938 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2939
2940         * source.c (find_and_open_source): Also rewrite relative file
2941         names.
2942
2943 2019-04-26  Amos Bird  <amosbird@gmail.com>
2944
2945         * annotate.c (annotate_thread_exited): Add "thread-exited"
2946         annotation.
2947
2948 2019-06-06  Tom Tromey  <tromey@adacore.com>
2949
2950         * maint.h (class scoped_command_stats): Use
2951         DISABLE_COPY_AND_ASSIGN.
2952         <print_time>: New method.
2953         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2954         print_time.
2955         (scoped_command_stats::print_time): New method.
2956
2957 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2958
2959         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2960         instructions of lengths 6 or 8 bytes.
2961
2962 2019-06-04  Pedro Alves  <palves@redhat.com>
2963
2964         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2965
2966         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2967         * breakpoint.c (condition_completer): Likewise.
2968         * cli/cli-dump.c (scan_expression): Likewise.
2969         * common/filestuff.c (mkdir_recursive): Likewise.
2970         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2971         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2972         (gdb_abspath): Likewise.
2973         * compile/compile-cplus-types.c
2974         (compile_cplus_instance::decl_name): Likewise.
2975         * completer.c (complete_explicit_location):
2976         (signal_completer, reg_or_group_completer_1): Likewise.
2977         * cp-support.c (cp_remove_params_if_any): Likewise.
2978         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2979         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2980         * infcmd.c (strip_bg_char): Likewise.
2981         * linespec.c (copy_token_string): Likewise.
2982         * mi/mi-main.c (output_cores): Likewise.
2983         * psymtab.c (psymtab_search_name):
2984         * symfile.c (test_set_ext_lang_command): Likewise.
2985         * target.c (target_fileio_read_stralloc): Likewise.
2986         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2987         * value.c (complete_internalvar): Likewise.
2988
2989 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2990
2991         Add objfile property to gdb.Type.
2992         * NEWS: Mention Python API addition.
2993         * python/py-type.c (typy_get_objfile): New method.
2994
2995 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2996
2997         * NEWS: Mention the new set|show style [title|highlight].
2998         Mention changes to "show style", "help" and "apropos".
2999
3000 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3001
3002         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3003         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3004         instead of print_help_for_command.
3005         (print_doc_of_command): New function.
3006         (help_list): Add 'apropos -v word' suggestion.
3007         (print_help_for_command): Style the command name using title style.
3008         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3009         (_initialize_cli_cmds): Describe -v in apropos_command help.
3010
3011 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3012
3013         * cli/cli-style.h (cli_style_option): Add name in constructor,
3014         add m_name class member, add constructor with intensity,
3015         add name class function.
3016         (cli_style_option::add_setshow_commands): Remove name argument.
3017         (highlight_style, title_style): New styles.
3018         * cli/cli-style.c (do_show): New function that shows a style
3019         characteristic styling the style name with itself.
3020         (set_style_name): New function.
3021         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3022         Update all callers according to the changes in cli/cli-style.h.
3023         * utils.h (fputs_highlighted): New function.
3024         * utils.c (fputs_highlighted): Likewise.
3025
3026 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3027
3028         * NEWS: Mention new pipe command and new convenience variables.
3029
3030 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3031
3032         * cli/cli-cmds.c (pipe_command): New function.
3033         (_initialize_cli_cmds): Call add_com for pipe_command.
3034         Define | as an alias for pipe.
3035         (exit_status_set_internal_vars): New function.
3036         (shell_escape): Call exit_status_set_internal_vars.
3037         cli/cli-decode.c (find_command_name_length): Recognize | as
3038         a single character command.
3039
3040 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3041
3042         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3043         top.c (execute_command_to_ui_file): New function, mostly a copy
3044         of execute_command_to_string.
3045         (execute_command_to_string): Implement by calling
3046         execute_command_to_ui_file.
3047
3048 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3049
3050         * top.h (saved_command_line): Remove declaration.
3051         * top.c (previous_saved_command_line, previous_repeat_arguments):
3052         New variables.
3053         (saved_command_line): Make static, define together with other
3054         'repeat variables'.
3055         (dont_repeat): Clear repeat_arguments.
3056         (repeat_previous, get_saved_command_line, save_command_line):
3057         New functions.
3058         (gdb_init): Initialize saved_command_line
3059         and previous_saved_command_line.
3060         * main.c (captured_main_1): Remove saved_command_line initialization.
3061         * event-top.c (handle_line_of_input): Update to use
3062         the new 'repeat' related functions instead of direct access to
3063         saved_command_line.
3064         * command.h (repeat_previous, get_saved_command_line,
3065         save_command_line): New declarations.
3066         (dont_repeat): Add comment.
3067
3068 2019-05-30  Tom Tromey  <tromey@adacore.com>
3069
3070         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3071         Fix comment.
3072         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3073
3074 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3075
3076         PR cli/24587
3077         * completer.c (complete): Initialize variable word.
3078
3079 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3080
3081         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3082         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3083         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3084         'body' is NULL to the outter 'if', protecting the '!is_define'
3085         situation as well.
3086
3087 2019-05-29  Tom Tromey  <tromey@adacore.com>
3088
3089         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3090         (dwarf_unknown): New function.
3091         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3092         (dwarf_type_encoding_name): Use dwarf_unknown.
3093
3094 2019-05-29  Tom Tromey  <tromey@adacore.com>
3095
3096         PR c++/20020:
3097         * cp-valprint.c (cp_print_value_fields): Call
3098         cp_print_static_field inside "try".
3099
3100 2019-05-29  Tom Tromey  <tromey@adacore.com>
3101
3102         * inflow.c (struct terminal_info): Add default operator=.
3103         * configure: Rebuild.
3104         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3105         -Wdeprecated-copy-dtor, -Wredundant-move.
3106
3107 2019-05-29  Tom Tromey  <tromey@adacore.com>
3108
3109         * NEWS: Add entry.
3110         * infcmd.c (print_return_value_1): Handle finish_print
3111         option.
3112         (show_print_finish): New function.
3113         (_initialize_infcmd): Add "set/show print finish" commands.
3114         * valprint.c (user_print_options): Initialize new member.
3115         * valprint.h (struct value_print_options) <finish_print>: New
3116         member.
3117
3118 2019-05-28  Tom Tromey  <tromey@adacore.com>
3119
3120         * ada-lang.c (ada_remove_Xbn_suffix)
3121         (find_old_style_renaming_symbol)
3122         (parse_old_style_renaming): Remove.
3123         (ada_find_renaming_symbol): Don't call
3124         find_old_style_renaming_symbol.
3125         (ada_is_renaming_symbol): Rename from
3126         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3127         bool.  Now static.
3128         (ada_read_var_value): Update and simplify.
3129         * ada-exp.y (write_var_or_type): Remove old code.
3130
3131 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3132
3133         * event-top.c: Remove include comment.
3134         * inflow.c (class scoped_ignore_sigttou): Move from here...
3135         * inflow.h (class scoped_ignore_sigttou): ...to here.
3136         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3137         * top.c:  Remove include comment.
3138
3139 2019-05-27  Tom Tromey  <tom@tromey.com>
3140
3141         * NEWS: Fix typo.
3142
3143 2019-05-22  Tom Tromey  <tromey@adacore.com>
3144
3145         * target.c (target_follow_exec): Constify parameter.
3146         * target-delegates.c: Rebuild.
3147         * remote.c (remote_target::follow_exec): Constify parameter.
3148         * infrun.c (follow_exec): Constify parameter.
3149         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3150         (target_follow_exec): Likewise.
3151
3152 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3153
3154         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3155         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3156
3157 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3158
3159         * NEWS: Add debugredirect and testsuite sections.
3160
3161 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3162
3163         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3164         target descriptions using exclusively floating point register name
3165         aliases.
3166
3167 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3168
3169         PR gdb/18644:
3170         * f-lang.c (build_fortran_types): Handle the case where
3171         gdbarch_floatformat_for_type returns a nullptr.
3172
3173 2019-05-21  Tom de Vries  <tdevries@suse.de>
3174
3175         PR cli/24587
3176         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3177
3178 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3179
3180         PR gdb/18644:
3181         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3182         16-byte floats.
3183         * i386-tdep.c (i386_floatformat_for_type): Use
3184         floatformats_ia64_quad for the 16-byte floating point component
3185         within a fortran 32-byte complex number.
3186
3187 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3188
3189         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3190         delete default constructor.
3191         (find_partial_die): Update to return const struct.
3192         (partial_die_parent_scope): Move variable declaration into scope
3193         of its use and change its type to auto.
3194         (guess_partial_die_structure_name): Likewise.
3195         (partial_die_info::fixup): Likewise.
3196
3197 2019-05-17  Tom Tromey  <tromey@adacore.com>
3198
3199         * source.c (find_and_open_source): Remove cast.
3200
3201 2019-05-17  Tom Tromey  <tromey@adacore.com>
3202
3203         * annotate.c (annotate_source): Make "filename" const.
3204         * annotate.h (annotate_source): Use const.
3205
3206 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3207
3208         * disasm.c (set_disassembler_options): Send errors to stderr.
3209
3210 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3211
3212         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3213         (cli_interp_base::set_logging): Check debug_redirect.
3214         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3215         * cli/cli-logging.c (debug_redirect): Add static variable.
3216         (pop_output_files): Add default param.
3217         (handle_redirections): Print debug setting.
3218         (show_logging_command): Likewise.
3219         (_initialize_cli_logging): Add debugredirect command.
3220         * interps.c (current_interp_set_logging): Add debug_redirect
3221         parameter.
3222         * interps.h (set_logging): Add debug_redirect parameter.
3223         (current_interp_set_logging): Likewise.
3224         * mi/mi-common.h: Likewise.
3225         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3226
3227 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3228             Tom Tromey  <tromey@adacore.com>
3229
3230         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3231         directly.
3232         * cli/cli-interp.h (make_logging_output): Remove declaration.
3233         * cli/cli-logging.c (make_logging_output): Remove function.
3234         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3235         directly.
3236         * ui-file.c (tee_file::tee_file): Remove bools.
3237         (tee_file::~tee_file): Remove deletes.
3238         * ui-file.h (tee_file): Remove bools.
3239
3240 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3241
3242         * mi/mi-cmds.h (mi_cmd_complete): New function.
3243         * mi/mi-main.c (mi_cmd_complete): Likewise.
3244         * mi/mi-cmds.c: Define new MI command -complete.
3245         * NEWS: Mention new -complete command.
3246
3247 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3248
3249         * completer.h (complete): New function.
3250         * completer.c (complete): Likewise.
3251         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3252         function defined in completer.h.
3253
3254 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3255
3256         * MAINTAINERS (Write After Approval): Add myself.
3257
3258 2019-05-17  Tom de Vries  <tdevries@suse.de>
3259
3260         PR gdb/24094
3261         * dwarf2read.c (struct cu_partial_die_info): New struct.
3262         (find_partial_die): Return cu_partial_die_info.
3263         (partial_die_parent_scope, guess_partial_die_structure_name)
3264         (partial_die_info::fixup): Handle new return type of find_partial_die.
3265
3266 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3267
3268         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3269         "std::string", simplifying the algorithm.
3270
3271 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3272
3273         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3274         (stap_static_probe_ops::get_probes): Likewise.
3275
3276 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3277
3278         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3279         '-')" and "else if".
3280         (stap_parse_single_operand): Join checks for
3281         "gdbarch_stap_parse_special_token_p" and
3282         "gdbarch_stap_parse_special_token" in the same "if" statement.
3283         Invert check when verifying for operation on register
3284         displacement.
3285
3286 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3287
3288         * stap-probe.c (stap_get_opcode): Update comment.
3289         (stap_get_expected_argument_type): Likewise.
3290         (handle_stap_probe): Likewise.
3291
3292 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3293
3294         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3295         return type to 'bool'.  Adjust comment.  Use 'bool' when
3296         appropriate.
3297         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3298         * stap-probe.c (stap_parse_argument_1): Likewise.
3299         (stap_is_operator): Likewise.
3300         (stap_is_generic_prefix): Likewise.
3301         (stap_is_register_prefix): Likewise.
3302         (stap_is_register_indirection_prefix): Likewise.
3303         (stap_is_integer_prefix): Likewise.
3304         (stap_generic_check_suffix): Likewise.
3305         (stap_check_integer_suffix): Likewise.
3306         (stap_check_register_suffix): Likewise.
3307         (stap_check_register_indirection_suffix): Likewise.
3308         (stap_parse_register_operand): Likewise.
3309         (stap_parse_single_operand): Likewise.
3310         (stap_parse_argument_1): Likewise.
3311         (stap_probe::get_argument_count): Likewise.
3312         (stap_is_operator): Likewise.
3313
3314 2019-05-16  Tom Tromey  <tromey@adacore.com>
3315
3316         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3317         keyword to foreach.
3318
3319 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3320
3321         * linux-thread-db.c (try_thread_db_load_1): Change return type
3322         to bool.
3323         (try_thread_db_load): Likewise.
3324         (try_thread_db_load_from_pdir_1): Likewise.
3325         (try_thread_db_load_from_pdir): Likewise.
3326         (try_thread_db_load_from_sdir): Likewise.
3327         (try_thread_db_load_from_dir): Likewise.
3328         (thread_db_load_search): Likewise.
3329         (has_libpthread): Likewise.
3330         (thread_db_load): Likewise.
3331
3332 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3333
3334         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3335         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3336         NULL, and complain/return if that's the case.
3337
3338 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3339
3340         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3341         (advance, posn, abstract_read_memory): New functions.
3342         [struct mem_read_abstraction]: New struct.
3343         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3344
3345 2019-05-14  Tom Tromey  <tromey@adacore.com>
3346
3347         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3348         value is not lval_memory.
3349
3350 2019-05-14  Tom Tromey  <tromey@adacore.com>
3351
3352         * solib.c (info_sharedlibrary_command): Style the file name.
3353
3354 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3355
3356         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3357         (aarch64_vnv_type): Likewise.
3358         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3359         * common/tdesc.c: Likewise.
3360         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3361         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3362         * features/aarch64-fpu.xml: Add ieee half view.
3363         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3364         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3365         * gdbtypes.h (struct builtin_type): Likewise.
3366         (struct objfile_type): Likewise.
3367
3368 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3369
3370         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3371         typo.
3372         * location.h (string_to_event_location): Likewise.
3373
3374 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3375
3376         GDB 8.3 released.
3377
3378 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3379
3380         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3381         New variable declaration.
3382         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3383         New variable.
3384         (print_one_breakpoint): Use ui_out::test_flags and new global
3385         variable to compute use_fixed_output.
3386         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3387         Remove.
3388         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3389         (mi_multi_location_breakpoint_output_fixed): Remove.
3390         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3391         new variable.
3392         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3393         fix_multi_location_breakpoint_output flag if version >= 3.
3394         * ui-out.h (enum ui_out_flag)
3395         <fix_multi_location_breakpoint_output>: New enumerator.
3396
3397 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3398
3399         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3400
3401 2019-05-10  Tom Tromey  <tromey@adacore.com>
3402
3403         * ada-lang.c (catch_ada_completer): New function.
3404         (_initialize_ada_language): Use it.
3405
3406 2019-05-10  Tom Tromey  <tromey@adacore.com>
3407
3408         * thread.c (print_thread_info): Make "requested_threads" const.
3409         * gdbthread.h (print_thread_info): Make "requested_threads"
3410         const.
3411         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3412         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3413
3414 2019-05-08  Tom Tromey  <tom@tromey.com>
3415
3416         * gdbtypes.c (objfile_type_data): Change type.
3417         (objfile_type, _initialize_gdbtypes): Update.
3418
3419 2019-05-08  Tom Tromey  <tom@tromey.com>
3420
3421         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3422         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3423         (_initialize_dwarf2_frame): Update.
3424
3425 2019-05-08  Tom Tromey  <tom@tromey.com>
3426
3427         * objc-lang.c (objc_objfile_data): Change type.
3428         (find_methods): Update.
3429         (_initialize_objc_lang): Remove.
3430
3431 2019-05-08  Tom Tromey  <tom@tromey.com>
3432
3433         * stabsread.c (rs6000_builtin_type_data): Change type.
3434         (rs6000_builtin_type, _initialize_stabsread): Update.
3435
3436 2019-05-08  Tom Tromey  <tom@tromey.com>
3437
3438         * mips-tdep.c (mips_pdr_data): Remove.
3439         (_initialize_mips_tdep): Update.
3440
3441 2019-05-08  Tom Tromey  <tom@tromey.com>
3442
3443         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3444         (hppa_init_objfile_priv_data, read_unwind_info)
3445         (find_unwind_entry, _initialize_hppa_tdep): Update.
3446
3447 2019-05-08  Tom Tromey  <tom@tromey.com>
3448
3449         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3450         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3451         on obstack.
3452         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3453
3454 2019-05-08  Tom Tromey  <tom@tromey.com>
3455
3456         * mdebugread.c (basic_type_data): Change type.
3457         (basic_type, _initialize_mdebugread): Update.
3458
3459 2019-05-08  Tom Tromey  <tom@tromey.com>
3460
3461         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3462
3463 2019-05-08  Tom Tromey  <tom@tromey.com>
3464
3465         * nto-tdep.c (nto_inferior_data_reg): Change type.
3466         (nto_inferior_data): Update.
3467         (nto_inferior_data_cleanup, nto_new_inferior_data)
3468         (_initialize_nto_tdep): Remove.
3469         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3470
3471 2019-05-08  Tom Tromey  <tom@tromey.com>
3472
3473         * ada-lang.c (struct ada_inferior_data): Add initializers.
3474         (ada_inferior_data): Change type.
3475         (ada_inferior_data_cleanup): Remove.
3476         (get_ada_inferior_data, ada_inferior_exit)
3477         (struct ada_pspace_data): Add initializers, destructor.
3478         (ada_pspace_data_handle): Change type.
3479         (get_ada_pspace_data): Update.
3480         (ada_pspace_data_cleanup): Remove.
3481
3482 2019-05-08  Tom Tromey  <tom@tromey.com>
3483
3484         * coffread.c (struct coff_symfile_info): Add initializers.
3485         (coff_objfile_data_key): Move lower.  Change type.
3486         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3487         Update.
3488         (coff_free_info): Remove.
3489
3490 2019-05-08  Tom Tromey  <tom@tromey.com>
3491
3492         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3493         (fbsd_pspace_data_handle): Move lower.  Change type.
3494         (get_fbsd_pspace_data): Update.
3495         (fbsd_pspace_data_cleanup): Remove.
3496         (_initialize_fbsd_tdep): Update.
3497
3498 2019-05-08  Tom Tromey  <tom@tromey.com>
3499
3500         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3501         (get_ada_tasks_pspace_data): Update.
3502         (ada_tasks_pspace_data_cleanup): Remove.
3503         (_initialize_tasks): Update.
3504         (ada_tasks_inferior_data_handle): Change type.
3505         (get_ada_tasks_inferior_data): Update.
3506         (ada_tasks_inferior_data_cleanup): Remove.
3507         (struct ada_tasks_pspace_data): Add initializers.
3508
3509 2019-05-08  Tom Tromey  <tom@tromey.com>
3510
3511         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3512         * symfile-debug.c (debug_sym_get_probes): Change type.
3513         * stap-probe.c (handle_stap_probe):
3514         (stap_static_probe_ops::get_probes): Change type.
3515         * probe.h (class static_probe_ops) <get_probes>: Change type.
3516         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3517         (parse_probes_in_pspace): Update.
3518         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3519         Update.
3520         (any_static_probe_ops::get_probes): Change type.
3521         * elfread.c (elfread_data): New typedef.
3522         (probe_key): Change type.
3523         (elf_get_probes): Likewise.  Update.
3524         (probe_key_free): Remove.
3525         (_initialize_elfread): Update.
3526         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3527         Change type.
3528         (dtrace_process_dof_probe, dtrace_process_dof)
3529         (dtrace_static_probe_ops::get_probe): Change type.
3530
3531 2019-05-08  Tom Tromey  <tom@tromey.com>
3532
3533         * xcoffread.c (struct xcoff_symfile_info): Rename from
3534         coff_symfile_info.  Add initializers.
3535         (xcoff_objfile_data_key): Move lower.  Change type.
3536         (XCOFF_DATA): Rewrite.
3537         (xcoff_free_info): Remove.
3538         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3539         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3540         (xcoff_initial_scan): Update.
3541
3542 2019-05-08  Tom Tromey  <tom@tromey.com>
3543
3544         * solib-svr4.c (struct svr4_info): Add initializers and
3545         destructor.
3546         <probes_table>: Now an htab_up.
3547         (solib_svr4_pspace_data): Change type.
3548         (free_probes_table): Simplify.
3549         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3550         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3551         (probes_table_remove_objfile_probes, register_solib_event_probe)
3552         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3553         (_initialize_svr4_solib): Update.
3554
3555 2019-05-08  Tom Tromey  <tom@tromey.com>
3556
3557         * remote.c (remote_pspace_data): Change type.
3558         (remote_pspace_data_cleanup): Remove.
3559         (get_remote_exec_file, set_pspace_remote_exec_file)
3560         (_initialize_remote): Update.
3561
3562 2019-05-08  Tom Tromey  <tom@tromey.com>
3563
3564         * breakpoint.c (breakpoint_objfile_key): Change type.
3565         (get_breakpoint_objfile_data): Update.
3566         (free_breakpoint_objfile_data): Remove.
3567         (_initialize_breakpoint): Update.
3568
3569 2019-05-08  Tom Tromey  <tom@tromey.com>
3570
3571         * linux-tdep.c (struct linux_info): Add initializers.
3572         (linux_inferior_data): Move.  Change type.
3573         (invalidate_linux_cache_inf): Update.
3574         (linux_inferior_data_cleanup): Remove.
3575         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3576
3577 2019-05-08  Tom Tromey  <tom@tromey.com>
3578
3579         * auxv.c (auxv_inferior_data): Move.  Change type.
3580         (auxv_inferior_data_cleanup): Remove.
3581         (invalidate_auxv_cache_inf): Rewrite.
3582         (get_auxv_inferior_data, _initialize_auxv): Update.
3583
3584 2019-05-08  Tom Tromey  <tom@tromey.com>
3585
3586         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3587         (symfile_debug_objfile_data_key): Change type.
3588         (symfile_debug_installed, debug_qf_has_symbols)
3589         (debug_qf_find_last_source_symtab)
3590         (debug_qf_forget_cached_source_info)
3591         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3592         (debug_qf_print_stats, debug_qf_dump)
3593         (debug_qf_expand_symtabs_for_function)
3594         (debug_qf_expand_all_symtabs)
3595         (debug_qf_expand_symtabs_with_fullname)
3596         (debug_qf_map_matching_symbols)
3597         (debug_qf_expand_symtabs_matching)
3598         (debug_qf_find_pc_sect_compunit_symtab)
3599         (debug_qf_map_symbol_filenames)
3600         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3601         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3602         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3603         (debug_sym_read_linetable, debug_sym_relocate): Update.
3604         (symfile_debug_free_objfile): Remove.
3605         (install_symfile_debug_logging, _initialize_symfile_debug):
3606         Update.
3607
3608 2019-05-08  Tom Tromey  <tom@tromey.com>
3609
3610         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3611         allocate_on_obstack.
3612         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3613         (get_dwarf2_per_objfile): Update.
3614         (set_dwarf2_per_objfile): Remove.
3615         (dwarf2_has_info, dwarf2_get_section_info): Update.
3616         (dwarf2_free_objfile): Remove.
3617         (_initialize_dwarf2_read): Update.
3618
3619 2019-05-08  Tom Tromey  <tom@tromey.com>
3620
3621         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3622         initializers.
3623         <unsupported_script_warning_printed,
3624         script_not_found_warning_printed>: Now bool.
3625         (auto_load_pspace_data): Change type.
3626         (~auto_load_pspace_info): Rename from
3627         auto_load_pspace_data_cleanup.
3628         (get_auto_load_pspace_data, init_loaded_scripts_info)
3629         (clear_section_scripts, maybe_print_unsupported_script_warning)
3630         (maybe_print_script_not_found_warning, _initialize_auto_load):
3631         Update.
3632
3633 2019-05-08  Tom Tromey  <tom@tromey.com>
3634
3635         * objfiles.c (objfile_pspace_info): Add destructor and
3636         initializers.
3637         (objfiles_pspace_data): Change type.
3638         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3639         (get_objfile_pspace_data): Update.
3640         (objfiles_bfd_data): Change type.
3641         (get_objfile_bfd_data): Update.
3642         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3643
3644 2019-05-08  Tom Tromey  <tom@tromey.com>
3645
3646         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3647         Change type.
3648         (get_catch_syscall_inferior_data): Update.
3649         (catch_syscall_inferior_data_cleanup): Remove.
3650         (_initialize_break_catch_syscall): Update.
3651
3652 2019-05-08  Tom Tromey  <tom@tromey.com>
3653
3654         * inflow.c (struct terminal_info): Add destructor and
3655         initializers.
3656         (inflow_inferior_data): Change type.
3657         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3658         (get_inflow_inferior_data, inflow_inferior_exit)
3659         (swap_terminal_info, _initialize_inflow): Update.
3660
3661 2019-05-08  Tom Tromey  <tom@tromey.com>
3662
3663         * target-dcache.c (target_dcache_cleanup): Remove.
3664         (target_dcache_aspace_key): Change type.
3665         (target_dcache_init_p, target_dcache_invalidate)
3666         (target_dcache_get, target_dcache_get_or_init)
3667         (_initialize_target_dcache): Update.
3668         * dcache.h (struct dcache_deleter): New.
3669
3670 2019-05-08  Tom Tromey  <tom@tromey.com>
3671
3672         * symtab.c (struct symbol_cache): Add destructor and
3673         initializers.
3674         (symbol_cache_key): Move.  Change type.
3675         (make_symbol_cache, free_symbol_cache): Remove.
3676         (get_symbol_cache): Update.
3677         (symbol_cache_cleanup): Remove.
3678         (ALL_PSPACES, symbol_cache_flush)
3679         (maintenance_print_symbol_cache)
3680         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3681         Update.
3682
3683 2019-05-08  Tom Tromey  <tom@tromey.com>
3684
3685         * symtab.c (struct main_info): Add destructor and initializers.
3686         (main_progspace_key): Move.  Change type.
3687         (get_main_info): Update.
3688         (main_info_cleanup): Remove.
3689         (_initialize_symtab): Update.
3690
3691 2019-05-08  Tom Tromey  <tom@tromey.com>
3692
3693         * registry.h (DECLARE_REGISTRY): Define the _key class.
3694
3695 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3696
3697         * NEWS: Merge two 'New commands' sections.
3698
3699 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3700
3701         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3702         parameter and use Ada language definition instead.
3703         (ada_val_print_ptr): Remove unused language parameter.
3704         (ada_val_print_num): Remove language parameter and use Ada language
3705         definition instead.
3706         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3707         parameter.
3708         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3709         parameter and use Ada language definition instead.
3710         (ada_val_print_1): Update all ada_val_print_xxx calls.
3711         Remove language parameter.
3712         (ada_val_print): Update ada_val_print_1 call.
3713
3714 2019-05-08  Tom Tromey  <tromey@adacore.com>
3715
3716         * remote.c (remote_hw_watchpoint_limit)
3717         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3718         Now static.
3719
3720 2019-05-08  Tom Tromey  <tromey@adacore.com>
3721
3722         * maint.c (_initialize_maint_cmds): Move initialization code to
3723         remote.c.
3724         (watchdog, show_watchdog): Move to remote.c.
3725         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3726         "watchdog" static.
3727         (_initialize_remote): Move initialization code from maint.c.
3728         * defs.h (watchdog): Don't declare.
3729
3730 2019-05-08  Tom Tromey  <tromey@adacore.com>
3731
3732         * tui/tui-interp.c: Include main.h.
3733         * interps.c: Include main.h.
3734         * main.h (interpreter_p): Declare.
3735         * defs.h (interpreter_p): Don't declare.
3736
3737 2019-05-08  Tom Tromey  <tromey@adacore.com>
3738
3739         * dwarf2loc.c: Include dwarf2read.h.
3740         * defs.h (read_unsigned_leb128): Don't declare.
3741         * dwarf2read.h (read_unsigned_leb128): Declare.
3742
3743 2019-05-08  Tom Tromey  <tromey@adacore.com>
3744
3745         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3746         method.
3747
3748 2019-05-08  Tom Tromey  <tromey@adacore.com>
3749
3750         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3751         when no wrap column is set.
3752
3753 2019-05-08  Tom Tromey  <tromey@adacore.com>
3754
3755         * c-lang.c (c_get_string): Handle non-C-style arrays.
3756
3757 2019-05-08  Tom Tromey  <tromey@adacore.com>
3758
3759         * typeprint.c (print_offset_data::update): Print the bit offset,
3760         not the number of bits remaining.
3761
3762 2019-05-08  Tom Tromey  <tromey@adacore.com>
3763
3764         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3765         padding at end of comment.
3766
3767 2019-05-08  Tom Tromey  <tromey@adacore.com>
3768
3769         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3770         Compare main types.
3771
3772 2019-05-06  Tom Tromey  <tom@tromey.com>
3773
3774         * common/scoped_mmap.c: Include common-defs.h.
3775         * common/scoped_mmap.h: Don't include config.h.
3776
3777 2019-05-04  Tom Tromey  <tom@tromey.com>
3778
3779         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3780         (struct aarch64_call_info): Add initializers.
3781         <si>: Now a std::vector.
3782         (pass_on_stack, aarch64_push_dummy_call): Update.
3783
3784 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3785             Tom Tromey  <tom@tromey.com>
3786
3787         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3788         (ppc_threads): Now a std::vector.  Now static.
3789         (hwdebug_find_thread_points_by_tid)
3790         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3791         Update.
3792
3793 2019-05-04  Tom Tromey  <tom@tromey.com>
3794
3795         * arc-tdep.c (arc_tdesc_init): Return bool.
3796
3797 2019-05-04  Tom Tromey  <tom@tromey.com>
3798
3799         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3800         Use gdb_assert_not_reached.
3801
3802 2019-05-04  Tom Tromey  <tom@tromey.com>
3803
3804         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3805         "false".
3806
3807 2019-05-04  Tom Tromey  <tom@tromey.com>
3808
3809         * arc-tdep.c (arc_tdesc_init): Use bool.
3810
3811 2019-05-04  Tom Tromey  <tom@tromey.com>
3812
3813         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3814
3815 2019-05-04  Tom Tromey  <tom@tromey.com>
3816
3817         * cli/cli-cmds.c (valid_command_p): Return bool.
3818
3819 2019-05-04  Tom Tromey  <tom@tromey.com>
3820
3821         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3822         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3823
3824 2019-05-04  Raul Tambre  <raul@tambre.ee>
3825
3826         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3827         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3828         operator for comparison.
3829
3830 2019-05-04  Tom Tromey  <tom@tromey.com>
3831
3832         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3833         (lookup_partial_symbol, print_partial_symbols)
3834         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3835         (psymbol_compare): Update.
3836         (add_psymbol_to_bcache): Clear the entire psymbol.
3837         (maintenance_check_psymtabs): Update.
3838         * psympriv.h (struct partial_symbol): Don't derive from
3839         general_symbol_info.
3840         <obj_section, unrelocated_address, address,
3841         set_unrelocated_address>: Update.
3842         <ginfo>: New member.
3843         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3844         (debug_names::write_psymbols): Update.
3845
3846 2019-05-04  Tom de Vries  <tdevries@suse.de>
3847
3848         * contrib/cc-with-tweaks.sh: Support -n arg.
3849
3850 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3851
3852         * corelow.c (core_target::detach): Ensure frame cache and
3853         register caches are cleared.
3854         inferior.c (exit_inferior_1): Likewise.
3855
3856 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3857             Tom Tromey  <tom@tromey.com>
3858
3859         * dictionary.c (collate_pending_symbols_by_language): Remove
3860         "struct" from foreach.
3861         * symtab.c (lookup_global_symbol_from_objfile)
3862         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3863         foreach.
3864         * ser-tcp.c (net_open): Remove "struct" from foreach.
3865         * objfiles.c (objfile_relocate, objfile_rebase)
3866         (objfile_has_symbols): Remove "struct" from foreach.
3867         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3868         from foreach.
3869         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3870         foreach.
3871         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3872         "struct" from foreach.
3873         * ada-lang.c (create_excep_cond_exprs)
3874         (ada_exception_catchpoint_cond_string): Remove "struct" from
3875         foreach.
3876
3877 2019-05-03  Tom Tromey  <tromey@adacore.com>
3878
3879         * ada-exp.y (convert_char_literal): Check suffix of each
3880         enumerator.
3881
3882 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3883
3884         PR ada/21406:
3885         * ada-exp.y (yywrap): Don't define.
3886         * ada-lex.l (%option): Add noyywrap
3887         (yywrap): Remove.
3888
3889 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3890
3891         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3892         _WIN32_WINNT to the XP level, unless already defined to a higher
3893         level.
3894
3895         * unittests/parse-connection-spec-selftests.c:
3896         * ser-tcp.c:
3897         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3898         override.
3899
3900         * symfile.c (find_separate_debug_file): Remove colon from the
3901         drive spec of DOS/Windows file names of the target, so that the
3902         file name produced from DEBUGDIR and the target's directory will
3903         be valid on DOS/Windows systems.
3904
3905 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3906
3907         * rust-lang.c (val_print_struct): Handle printing structures
3908         containing strings.
3909
3910 2019-05-02  Tom Tromey  <tromey@adacore.com>
3911
3912         * valarith.c (_initialize_valarith): Remove.
3913
3914 2019-05-01  Tom Tromey  <tromey@adacore.com>
3915
3916         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3917         bitfields.
3918
3919 2019-05-01  Tom Tromey  <tromey@adacore.com>
3920
3921         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3922         for big-endian copies.
3923
3924 2019-04-30  Ali Tamur  <tamur@google.com>
3925         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3926         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3927         (read_3_bytes): New function.
3928
3929 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3930
3931         * windows-nat.c (main_thread_id): Delete.
3932         (handle_output_debug_string): Replace main_thread_id by
3933         current_event.dwThreadId.
3934         (fake_create_process): Likewise.
3935         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3936         Do not set main_thread_id.
3937         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3938         current_event.dwThreadId.
3939         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3940
3941 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3942
3943         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3944         Use current_event.dwThreadId instead of main_thread_id.
3945
3946 2019-04-30  Tom Tromey  <tromey@adacore.com>
3947
3948         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3949         (create_excep_cond_exprs): Iterate over program spaces.
3950         (ada_exception_catchpoint_cond_string): Examine all minimal
3951         symbols for exception types.
3952
3953 2019-04-30  Tom Tromey  <tromey@adacore.com>
3954
3955         PR c++/24470:
3956         * dwarf2read.c (process_structure_scope): Handle case where type
3957         has template parameters but no symbol was created.
3958
3959 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3960             Chris January  <chris.january@arm.com>
3961
3962         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3963         qualifier.
3964         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3965
3966 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3967
3968         * f-typeprint.c (f_print_type): Update rules for printing
3969         whitespace.
3970         (f_type_print_varspec_suffix): Likewise.
3971
3972 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3973             Chris January  <chris.january@arm.com>
3974
3975         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3976         function arguments.
3977
3978 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3979
3980         * f-lang.c (build_fortran_types): Change name of void type to
3981         lower case.
3982         * f-typeprint.c (f_type_print_base): Print the name of the void
3983         type, rather than a fixed string.
3984         * f-valprint.c (f_decorations): Use lower case void string.
3985
3986 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3987             Chris January  <chris.january@arm.com>
3988
3989         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3990         types for Fortran.
3991
3992 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3993             Chris January  <chris.january@arm.com>
3994             David Lecomber  <david.lecomber@arm.com>
3995
3996         * f-exp.y (BINOP_INTRINSIC): New token.
3997         (exp): New parser rule handling BINOP_INTRINSIC.
3998         (f77_keywords): Add new builtin procedures.
3999         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4000         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4001         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4002         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4003         (print_unop_subexp_f): New function.
4004         (print_binop_subexp_f): New function.
4005         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4006         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4007         (dump_subexp_body_f): Likewise.
4008         (operator_check_f): Likewise.
4009         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4010         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4011
4012 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4013
4014         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4015         UNOP_KIND.
4016         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4017         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4018         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4019         (operator_length_f): New fuction.
4020         (print_subexp_f): New function.
4021         (op_name_f): New function.
4022         (dump_subexp_body_f): New function.
4023         (operator_check_f): New function.
4024         (exp_descriptor_f): Replace standard expression handling functions
4025         with new functions.
4026         * gdb/fortran-operator.def: New file.
4027         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4028         * gdb/std-operator.def: Remove UNOP_KIND.
4029
4030 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4031
4032         * std-operator.def: Remove unbalanced, stray double quote
4033         character.
4034
4035 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4036             Chris January  <chris.january@arm.com>
4037             Daniel Everett  <daniel.everett@arm.com>
4038             Nick Forrington  <nick.forrington@arm.com>
4039             Richard Bunt  <richard.bunt@arm.com>
4040
4041         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4042         of depth when printing anonymous structs or unions.
4043         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4044         Don't print either the top-level value, or the children if the
4045         max-depth is exceeded.
4046         (ppscm_print_children): When printing the key of a map, allow one
4047         extra level of depth.
4048         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4049         print either the top-level value, or the children if the max-depth
4050         is exceeded.
4051         (print_children): When printing the key of a map, allow one extra
4052         level of depth.
4053         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4054         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4055         (user_print_options): Initialise max_depth field.
4056         (val_print_scalar_or_string_type_p): New function.
4057         (val_print): Check to see if the max depth has been reached.
4058         (val_print_check_max_depth): Define new function.
4059         (show_print_max_depth): New function.
4060         (_initialize_valprint): Add 'print max-depth' option.
4061         * valprint.h (struct value_print_options) <max_depth>: New field.
4062         (val_print_check_max_depth): Declare new function.
4063         * NEWS: Document new feature.
4064
4065 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4066
4067         * ada-lang.c (ada_language_defn): Initialise new field.
4068         * c-lang.c (c_is_string_type_p): New function.
4069         (c_language_defn): Initialise new field.
4070         (cplus_language_defn): Initialise new field.
4071         (asm_language_defn): Initialise new field.
4072         (minimal_language_defn): Initialise new field.
4073         * c-lang.h (c_is_string_type_p): Declare new function.
4074         * d-lang.c (d_language_defn): Initialise new field.
4075         * f-lang.c (f_is_string_type_p): New function.
4076         (f_language_defn): Initialise new field.
4077         * go-lang.c (go_is_string_type_p): New function.
4078         (go_language_defn): Initialise new field.
4079         * language.c (default_is_string_type_p): New function.
4080         (unknown_language_defn): Initialise new field.
4081         (auto_language_defn): Initialise new field.
4082         * language.h (struct language_defn) <la_is_string_type_p>: New
4083         member variable.
4084         (default_is_string_type_p): Declare new function.
4085         * m2-lang.c (m2_language_defn): Initialise new field.
4086         * objc-lang.c (objc_language_defn): Initialise new field.
4087         * opencl-lang.c (opencl_language_defn): Initialise new field.
4088         * p-lang.c (pascal_is_string_type_p): New function.
4089         (pascal_language_defn): Initialise new field.
4090         * rust-lang.c (rust_is_string_type_p): New function.
4091         (rust_language_defn): Initialise new field.
4092
4093 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4094
4095         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4096         New field.
4097         * ada-lang.c (ada_language_defn): Initialise new field.
4098         * c-lang.c (c_language_defn): Likewise.
4099         (cplus_language_defn): Likewise.
4100         (asm_language_defn): Likewise.
4101         (minimal_language_defn): Likewise.
4102         * d-lang.c (d_language_defn): Likewise.
4103         * f-lang.c (f_language_defn): Likewise.
4104         * go-lang.c (go_language_defn): Likewise.
4105         * language.c (unknown_language_defn): Likewise.
4106         (auto_language_defn): Likewise.
4107         * m2-lang.c (m2_language_defn): Likewise.
4108         * objc-lang.c (objc_language_defn): Likewise.
4109         * opencl-lang.c (opencl_language_defn): Likewise.
4110         * p-lang.c (pascal_language_defn): Likewise.
4111         * rust-lang.c (rust_language_defn): Likewise.
4112
4113 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4114
4115         * ada-lang.c (ada_is_character_type): Change return type to bool.
4116         (ada_is_string_type): Likewise.
4117         * ada-lang.h (ada_is_character_type): Update declaration
4118         (ada_is_string_type): Likewise.
4119
4120 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4121
4122         Support style in 'frame|thread apply'
4123
4124         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4125         * record.c (record_start, record_stop): Update callers of
4126         execute_command_to_string with false.
4127         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4128         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4129         methods.
4130         (class string_file): New constructor with term_out parameter.
4131         Override methods term_out and can_emit_style_escape.  New member
4132         term_out.
4133         (class stdio_file): Override can_emit_style_escape.
4134         (class tee_file): Override term_out and can_emit_style_escape.
4135         * utils.h (can_emit_style_escape): Remove.
4136         * utils.c (can_emit_style_escape): Likewise.
4137         Update all callers of can_emit_style_escape (SOMESTREAM) to
4138         SOMESTREAM->can_emit_style_escape.
4139         * source-cache.c (source_cache::get_source_lines): Likewise.
4140         * stack.c (frame_apply_command_count): Call execute_command_to_string
4141         passing the term_out characteristic of the current gdb_stdout.
4142         * thread.c (thr_try_catch_cmd): Likewise.
4143         * top.c (execute_command_to_string): pass term_out parameter
4144         to construct the string_file for the command output.
4145         * ui-file.c (term_cli_styling): New function (most code moved
4146         from utils.c can_emit_style_escape).
4147         (string_file::string_file, string_file::can_emit_style_escape,
4148         stdio_file::can_emit_style_escape, tee_file::term_out,
4149         tee_file::can_emit_style_escape): New functions.
4150
4151 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4152
4153         * NEWS: Mention the new set|show may-call-functions.
4154         * infcall.c (may_call_functions_p): New variable.
4155         (show_may_call_functions_p): New function.
4156         (call_function_by_hand_dummy): Throws an error if not
4157         may-call-functions.
4158         (_initialize_infcall): Call add_setshow_boolean_cmd for
4159         may-call-functions.
4160
4161 2019-04-25  Keith Seitz  <keiths@redhat.com>
4162
4163         PR c++/24367
4164         * cp-support.c (inspect_type): Don't attempt substitutions
4165         of symbol with the same name.
4166
4167 2019-04-25  Tom Tromey  <tromey@adacore.com>
4168
4169         PR gdb/24475:
4170         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4171         static.
4172
4173 2019-04-25  Tom Tromey  <tromey@adacore.com>
4174
4175         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4176         rvalue reference.
4177         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4178         (gdb_xml_parser::parse): Use std::move.
4179         * python/python-internal.h (gdbpy_convert_exception): Take a const
4180         reference.
4181         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4182         std::move.
4183         * python/py-utils.c (gdbpy_convert_exception): Take a const
4184         reference.
4185         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4186         Use std::move.
4187         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4188         Use std::move.
4189         * mi/mi-main.c (mi_print_exception): Take a const reference.
4190         * main.c (handle_command_errors): Take a const reference.
4191         * linespec.c (parse_linespec): Use std::move.
4192         * infcall.c (run_inferior_call): Use std::move.
4193         (call_function_by_hand_dummy): Use std::move.
4194         * exec.c (try_open_exec_file): Use std::move.
4195         * exceptions.h (exception_print, exception_fprintf)
4196         (exception_print_same): Update.
4197         * exceptions.c (print_exception, exception_print)
4198         (exception_fprintf, exception_print_same): Change parameters to
4199         const reference.
4200         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4201         * common/new-op.c: Use std::move.
4202         * common/common-exceptions.h (struct gdb_exception): Add move
4203         constructor.
4204         (struct gdb_exception_error, struct gdb_exception_quit, struct
4205         gdb_quit_bad_alloc): Change constructor to move constructor.
4206         (throw_exception): Change parameter to rvalue reference.
4207         * common/common-exceptions.c (throw_exception): Take rvalue
4208         reference.
4209         * cli/cli-interp.c (safe_execute_command): Use std::move.
4210         * breakpoint.c (insert_bp_location, location_to_sals): Use
4211         std::move.
4212
4213 2019-04-25  Tom Tromey  <tromey@adacore.com>
4214
4215         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4216         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4217         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4218         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4219         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4220         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4221         guile/scm-value.c: Use unpack.
4222         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4223         gdbscm_gdb_exception.
4224         (gdbscm_throw_gdb_exception): Likewise.
4225         (struct gdbscm_gdb_exception): New.
4226         (unpack): New function.
4227         (gdbscm_wrap): Use unpack.
4228
4229 2019-04-25  Tom Tromey  <tromey@adacore.com>
4230
4231         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4232         (gdb_rl_callback_handler): Use std::move.
4233         * common/common-exceptions.h (struct gdb_exception): Add move
4234         assignment operator.
4235         (throw_exception_sjlj): Change "exception" to const reference.
4236         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4237         (throw_exception_sjlj): Change "exception" to const reference.
4238
4239 2019-04-25  Tom Tromey  <tromey@adacore.com>
4240
4241         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4242         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4243         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4244         Update.
4245         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4246         Update.
4247         * mi/mi-interp.c (mi_interp::exec): Update.
4248         * linespec.c (parse_linespec): Update.
4249         * infcall.c (run_inferior_call): Update.
4250         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4251         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4252         (gdbscm_lookup_global_symbol): Update.
4253         * guile/scm-param.c (gdbscm_parameter_value): Update.
4254         * guile/scm-frame.c (gdbscm_frame_read_register)
4255         (gdbscm_frame_read_var): Update.
4256         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4257         * exec.c (try_open_exec_file): Update.
4258         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4259         (gdb_rl_callback_handler): Update.
4260         * common/common-exceptions.h (exception_none): Don't declare.
4261         * common/common-exceptions.c (exception_none): Don't define.
4262         (struct catcher) <exception>: Update.
4263         * cli/cli-interp.c (safe_execute_command): Update.
4264         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4265
4266 2019-04-25  Ali Tamur  <tamur@google.com>
4267
4268         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4269         (read_attribute_value): Likewise.
4270         (dwarf2_read_addr_index): Update comment.
4271         (read_str_index): Add DW_FORM_strx.
4272         (dwarf2_string_attr): Likewise.
4273         (dwarf2_const_value_attr): Likewise.
4274         (dump_die_shallow): Likewise.
4275         (dwarf2_fetch_constant_bytes): Likewise.
4276         (skip_form_bytes): Likewise.
4277         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4278
4279 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4280
4281         PR corefiles/11608
4282         PR corefiles/18187
4283         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4284         OFFSET.  Verify if current mapping contains an ELF header.
4285         (linux_find_memory_regions_full): Adjust call to
4286         dump_mapping_p.
4287
4288 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4289             Kang Li <kanglictf@gmail.com>
4290
4291         PR gdb/21600
4292
4293         * dwarf2-frame.c (read_initial_length): Be consistent about using
4294         unsigned representation of length.
4295         (decode_frame_entry_1): Likewise.  Check for wraparound of
4296         end pointer as well as buffer overflow.
4297
4298 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4299
4300         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4301         "vq".
4302
4303 2019-04-24  Tom Tromey  <tromey@adacore.com>
4304
4305         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4306
4307 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4308
4309         * s12z-tdep.c (s12z_unwind_pc): Delete.
4310         (s12z_unwind_sp): Delete.
4311         (s12z_gdbarch_init): Don't register deleted functions with
4312         gdbarch.
4313
4314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4315
4316         * rl78-tdep.c (rl78_unwind_sp): Delete.
4317         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4318
4319 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4320
4321         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4322         (xstormy16_unwind_pc): Delete.
4323         (xstormy16_dummy_id): Delete.
4324         (xstormy16_gdbarch_init): Don't register deleted functions with
4325         gdbarch.
4326
4327 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4328
4329         * vax-tdep.c (vax_unwind_pc): Delete.
4330         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4331
4332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4333
4334         * v850-tdep.c (v850_unwind_sp): Delete.
4335         (v850_unwind_pc): Delete.
4336         (v850_dummy_id): Delete.
4337         (v850_gdbarch_init): Don't register deleted functions with
4338         gdbarch.
4339
4340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4341
4342         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4343         (tilegx_unwind_pc): Delete.
4344         (tilegx_unwind_dummy_id): Delete.
4345         (tilegx_gdbarch_init): Don't register deleted functions with
4346         gdbarch.
4347
4348 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4349
4350         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4351         (tic6x_dummy_id): Delete.
4352         (tic6x_gdbarch_init): Don't register deleted functions with
4353         gdbarch.
4354
4355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4356
4357         * sparc-tdep.c (sparc_unwind_pc): Delete.
4358         (sparc32_gdbarch_init): Don't register deleted function with
4359         gdbarch.
4360
4361 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4362
4363         * sh-tdep.c (sh_unwind_sp): Delete.
4364         (sh_unwind_pc): Delete.
4365         (sh_dummy_id): Delete.
4366         (sh_gdbarch_init): Don't register deleted functions with
4367         gdbarch.
4368
4369 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4370
4371         * score-tdep.c (score_unwind_sp): Delete.
4372         (score_unwind_pc): Delete.
4373         (score_dummy_id): Delete.
4374         (score_gdbarch_init): Don't register deleted functions with
4375         gdbarch.
4376
4377 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4378
4379         * rx-tdep.c (rx_unwind_pc): Delete.
4380         (rx_unwind_sp): Delete.
4381         (rx_dummy_id): Delete.
4382         (rx_gdbarch_init): Don't register deleted functions with
4383         gdbarch.  Update comment.
4384
4385 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4386
4387         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4388         (rs6000_dummy_id): Delete.
4389         (rs6000_gdbarch_init): Don't register deleted functions with
4390         gdbarch.
4391
4392 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4393
4394         * or1k-tdep.c (or1k_dummy_id): Delete.
4395         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4396
4397 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4398
4399         * nios2-tdep.c (nios2_dummy_id): Delete.
4400         (nios2_unwind_sp): Delete.
4401         (nios2_gdbarch_init): Don't register deleted functions with
4402         gdbarch.
4403
4404 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4405
4406         * nds32-tdep.c (nds32_dummy_id): Delete.
4407         (nds32_unwind_pc): Delete.
4408         (nds32_unwind_sp): Delete.
4409         (nds32_gdbarch_init): Don't register deleted functions with
4410         gdbarch.
4411
4412 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4413
4414         * msp430-tdep.c (msp430_unwind_pc): Delete.
4415         (msp430_unwind_sp): Delete.
4416         (msp430_dummy_id): Delete.
4417         (msp430_gdbarch_init): Don't register deleted functions with
4418         gdbarch.
4419
4420 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4421
4422         * moxie-tdep.c (moxie_unwind_sp): Delete.
4423         (moxie_unwind_pc): Delete.
4424         (moxie_dummy_id): Delete.
4425         (moxie_gdbarch_init): Don't register deleted functions with
4426         gdbarch.
4427
4428 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4429
4430         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4431         (mn10300_unwind_pc): Delete.
4432         (mn10300_unwind_sp): Delete.
4433         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4434         mn10300_unwind_sp.
4435         (mn10300_frame_unwind_init): Don't register deleted functions with
4436         gdbarch.
4437
4438 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4439
4440         * mep-tdep.c (mep_unwind_pc): Delete.
4441         (mep_unwind_sp): Delete.
4442         (mep_dummy_id): Delete.
4443         (mep_gdbarch_init): Don't register deleted functions with
4444         gdbarch.
4445
4446 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4447
4448         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4449         (m68hc11_unwind_sp): Delete.
4450         (m68hc11_gdbarch_init): Don't register deleted functions with
4451         gdbarch.
4452
4453 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4454
4455         * m32r-tdep.c (m32r_unwind_sp): Delete.
4456         (m32r_unwind_pc): Delete.
4457         (m32r_dummy_id): Delete.
4458         (m32r_gdbarch_init): Don't register deleted functions with
4459         gdbarch.
4460
4461 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4462
4463         * m32c-tdep.c (m32c_unwind_pc): Delete.
4464         (m32c_unwind_sp): Delete.
4465         (m32c_dummy_id): Delete.
4466         (m32c_gdbarch_init): Don't register deleted functions with
4467         gdbarch.
4468
4469 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4470
4471         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4472         (lm32_unwind_pc): Delete.
4473         (lm32_dummy_id): Delete.
4474         (lm32_gdbarch_init): Don't register deleted functions with
4475         gdbarch.
4476
4477 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4478
4479         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4480         (iq2000_unwind_pc): Delete.
4481         (iq2000_dummy_id): Delete.
4482         (iq2000_gdbarch_init): Don't register deleted functions with
4483         gdbarch.
4484
4485 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4486
4487         * nds32-tdep.c (nds32_type_align): Delete.
4488         (nds32_push_dummy_call): Use type_align instead.
4489
4490 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4491
4492         * arm-tdep.c (arm_type_align): Only handle vector override case.
4493         (arm_push_dummy_call): Use type_align.
4494         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4495
4496 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4497
4498         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4499         case.
4500         (pass_on_stack): Use type_align.
4501         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4502         function.
4503
4504 2019-04-23  Tom Tromey  <tromey@adacore.com>
4505
4506         * dwarf2read.c (line_header::file_name_at): Remove unused
4507         overload.
4508
4509 2019-04-23  Tom de Vries  <tdevries@suse.de>
4510
4511         PR gdb/24438
4512         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4513         invocation.
4514
4515
4516 2019-03-27  Ali Tamur  <tamur@google.com>
4517
4518         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4519         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4520         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4521         (dwarf_expr_context::get_addr_index): Likewise
4522         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4523         (symbol_needs_eval_context::get_addr_index): Likewise
4524         (disassemble_dwarf_expression): Add DW_OP_addrx
4525         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4526         (read_cutu_die_from_dwo): Update comment
4527         (skip_one_die): Add DW_FORM_addrx
4528         (read_attribute_value): Likewise
4529         (var_decode_location): Add DW_OP_addrx
4530         (dwarf2_const_value_attr): Add DW_FORM_addrx
4531         (dump_die_shallow): Likewise
4532         (dwarf2_fetch_constant_bytes): Likewise
4533         (decode_locdesc): Add DW_OP_addrx
4534         (skip_form_bytes): Add DW_FORM_addrx
4535
4536 2019-04-22  Ali Tamur  <tamur@google.com>
4537
4538         * MAINTAINERS (Write After Approval): Add self.
4539
4540 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4541
4542         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4543         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4544         (open_symbol_file_object): Likewise.
4545         (svr4_default_sos): Add info parameter.
4546         (svr4_read_so_list): Likewise.
4547         (svr4_current_sos_direct): Adjust functions calls to pass down
4548         info.
4549         (svr4_current_sos_1): Add info parameter.
4550         (svr4_current_sos): Call get_svr4_info, pass info down to
4551         svr4_current_sos_1.
4552         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4553         get_svr4_info.
4554         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4555         get_svr4_info.
4556         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4557         to get_svr4_info.
4558         (probes_table_remove_objfile_probes): Likewise.
4559         (register_solib_event_probe): Add info parameter.
4560         (solist_update_incremental): Pass info parameter down to
4561         svr4_read_so_list.
4562         (disable_probes_interface): Add info parameter.
4563         (svr4_handle_solib_event): Pass current_program_space to
4564         get_svr4_info.  Adjust disable_probes_interface cleanup.
4565         (svr4_create_probe_breakpoints): Add info parameter, pass it
4566         down to register_solib_event_probe.
4567         (svr4_create_solib_event_breakpoints): Add info parameter,
4568         pass it down to svr4_create_probe_breakpoints.
4569         (enable_break): Pass info down to
4570         svr4_create_solib_event_breakpoints.
4571         (svr4_solib_create_inferior_hook): Pass current_program_space to
4572         get_svr4_info.
4573         (svr4_clear_solib): Likewise.
4574
4575 2019-04-22  Pedro Alves  <palves@redhat.com>
4576
4577         * solib-svr4.c (svr4_free_objfile_observer): New.
4578         (probe_and_action::objfile): New field.
4579         (probes_table_htab_remove_objfile_probes)
4580         (probes_table_remove_objfile_probes): New functions.
4581         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4582         in the new probe_and_action.  Don't store the probe in 'lookup'.
4583         (svr4_create_probe_breakpoints): Pass objfile to
4584         register_solib_event_probe.
4585         (_initialize_svr4_solib): Register a free_objfile observer.
4586
4587 2019-04-19  Tom Tromey  <tom@tromey.com>
4588
4589         * common/queue.h: Remove.
4590
4591 2019-04-19  Tom Tromey  <tom@tromey.com>
4592
4593         * event-loop.c: Don't include "common/queue.h".
4594
4595 2019-04-19  Tom Tromey  <tom@tromey.com>
4596
4597         * remote.c (remote_target): Use delete.
4598         * remote-notif.h: Include <list>, not "common/queue.h".
4599         (notif_client_p): Remove typedef.
4600         (remote_notif_state): Add constructor, destructor, initializer.
4601         <notif_queue>: Now a std::list.
4602         (remote_notif_state_xfree): Don't declare.
4603         * remote-notif.c (remote_notif_process, handle_notification)
4604         (remote_notif_state_allocate): Update.
4605         (~remote_notif_state): Rename from remote_notif_state_xfree.
4606
4607 2019-04-19  Tom Tromey  <tom@tromey.com>
4608
4609         * symfile.c (reread_symbols): Update.
4610         * objfiles.c (objfile_register_static_link)
4611         (objfile_lookup_static_link): Update
4612         (~objfile) Don't delete static_links.
4613         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4614
4615 2019-04-19  Tom Tromey  <tom@tromey.com>
4616
4617         * type-stack.h (struct type_stack) <insert>: Constify string.
4618         * type-stack.c (type_stack::insert): Constify string.
4619         * gdbtypes.h (lookup_template_type): Update.
4620         (address_space_name_to_int): Update.
4621         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4622         const.
4623         (lookup_template_type): Make name const.
4624         * c-exp.y: Update rules.
4625         (lex_one_token, classify_name, classify_inner_name)
4626         (c_print_token): Update.
4627         * p-exp.y: Update rules.
4628         (yylex): Update.
4629         * f-exp.y: Update rules.
4630         (yylex): Update.
4631         * d-exp.y: Update rules.
4632         (lex_one_token, classify_name, classify_inner_name): Update.
4633         * parse.c (write_dollar_variable, copy_name): Return std::string.
4634         * parser-defs.h (copy_name): Change return type.
4635         * m2-exp.y: Update rules.
4636         (yylex): Update.
4637         * go-exp.y (lex_one_token): Update.
4638         Update rules.
4639         (classify_unsafe_function, classify_packaged_name)
4640         (classify_name, yylex): Update.
4641
4642 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4643
4644         * configure.ac: add --enable-source-highlight switch.
4645         * configure: Regenerate.
4646         * top.c (print_gdb_version): plumb --enable-source-highlight
4647         status to "show configuration".
4648
4649 2019-04-19  Tom Tromey  <tromey@adacore.com>
4650
4651         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4652         Check ADA_TYPE_P.
4653         (empty_record, ada_template_to_fixed_record_type_1)
4654         (template_to_static_fixed_type)
4655         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4656         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4657         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4658         macros.
4659
4660 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4661
4662         PR symtab/24423:
4663         * source.c (print_source_lines_base): Advance "iter" when a
4664         control character is seen.
4665
4666 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4667
4668         * inferior.h (struct infcall_suspend_state_deleter):
4669         Catch exception in destructor to avoid crash.
4670
4671 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4672
4673         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4674         close to the add_com "shell".
4675
4676 2019-04-18  Tom Tromey  <tromey@adacore.com>
4677
4678         * process-stratum-target.h (class process_stratum_target)
4679         <stratum>: Add "final".
4680
4681 2019-04-17  Tom Tromey  <tromey@adacore.com>
4682
4683         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4684         against nullptr before use.
4685
4686 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4687
4688         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4689
4690 2019-04-17  Jim Wilson  <jimw@sifive.com>
4691             Andrew Burgess  <andrew.burgess@embecosm.com>
4692
4693         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4694         code read might fail, assume 4-byte breakpoint in that case.
4695
4696 2019-04-15  Leszek Swirski  <leszeks@google.com>
4697
4698         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4699         rather than a hand-rolled POD check when checking for forced MEMORY
4700         classification.
4701
4702 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4703
4704         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4705         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4706         function.
4707         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4708         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4709         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4710         declaration.
4711
4712 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4713
4714         * aarch64-linux-nat.c
4715         (aarch64_linux_nat_target::thread_architecture): Add override.
4716         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4717         each VQ.
4718
4719 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4720
4721         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4722
4723 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4724
4725         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4726         target types of size 96-bits, add some additional comments, and
4727         check that the builtin type we found was the correct size.
4728
4729 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4730
4731         * utils.c (prompt_for_continue): Don't restore the styling at the
4732         end, as applied_style has the wrong value.  This fixes styling in
4733         long lists of file names that are interrupted by the "Continue?"
4734         prompt.
4735
4736 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4737
4738         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4739         * c-lang.c (c_language_defn): Likewise.
4740         (cplus_language_defn): Likewise.
4741         (asm_language_defn): Likewise.
4742         (minimal_language_defn): Likewise.
4743         * d-lang.c (d_language_defn): Likewise.
4744         * f-lang.c (f_language_defn): Likewise.
4745         * go-lang.c (go_language_defn): Likewise.
4746         * language.c (unknown_language_defn): Likewise.
4747         (auto_language_defn): Likewise.
4748         * language.h (struct language_defn): Remove la_magic field.
4749         (LANG_MAGIC): Delete.
4750         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4751         * objc-lang.c (objc_language_defn): Likewise.
4752         * opencl-lang.c (opencl_language_defn): Likewise.
4753         * p-lang.c (pascal_language_defn): Likewise.
4754         * rust-lang.c (rust_language_defn): Likewise.
4755
4756 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4757
4758         * riscv-tdep.c (riscv_type_align): New function.
4759         (riscv_type_alignment): Delete.
4760         (riscv_arg_location): Use 'type_align'.
4761         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4762
4763 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4764
4765         * gdbtypes.c (type_align): A struct with no non-static fields also
4766         has alignment of 1.
4767
4768 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4769
4770         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4771         component to 0.
4772         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4773         member.
4774         (riscv_struct_info::analyse): New implementation using new
4775         analyse_inner member function.
4776         (riscv_struct_info::field_offset): New member function.
4777         (riscv_struct_info::m_offsets): New member variable.
4778         (riscv_struct_info::analyse_inner): New private member function,
4779         takes the old implementation of riscv_struct_info::analyse but
4780         extended to track field offsets.
4781         (riscv_call_arg_struct): Update the struct folding special cases
4782         to handle cases where empty C++ structs, which are non-zero
4783         length, are found.
4784         (riscv_arg_location): Initialise the length of each location, a
4785         non-zero length now indicates the location is in use.
4786         (riscv_push_dummy_call): Allow for the first location having a
4787         non-zero offset when setting up arguments.
4788         (riscv_return_value): Likewise, but for return values.
4789
4790 2019-04-11  Tom Tromey  <tromey@adacore.com>
4791
4792         * utils.c (internal_vproblem): Make "msg" const.
4793
4794 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4795
4796         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4797         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4798         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4799         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4800
4801 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4802
4803         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4804         function.
4805         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4806         of amd64_collect_native_gregset.
4807         (amd64_linux_nat_target::store_registers): Likewise.
4808
4809 2019-04-10  Tom Tromey  <tom@tromey.com>
4810
4811         * symtab.c (lookup_global_symbol_from_objfile)
4812         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4813         * objfiles.h (class separate_debug_iterator): New.
4814         (class separate_debug_range): New.
4815         (struct objfile) <separate_debug_objfiles>: New method.
4816         (objfile_separate_debug_iterate): Don't declare.
4817         * objfiles.c (separate_debug_iterator::operator++): Rename from
4818         objfile_separate_debug_iterate.
4819         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4820         iterator.
4821         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4822         iterator.
4823
4824 2019-04-10  Tom Tromey  <tom@tromey.com>
4825
4826         * symfile.c (reread_symbols): Remove old comment.
4827         * objfiles.c (free_all_objfiles): Fix a typo.
4828
4829 2019-04-10  Tom Tromey  <tom@tromey.com>
4830
4831         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4832         * minsyms.c (lookup_minimal_symbol): Use foreach.
4833         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4834         (lookup_minimal_symbol_solib_trampoline): Likewise.
4835         * symfile.c (reread_symbols): Use foreach.
4836
4837 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4838             Tom Tromey  <tromey@adacore.com>
4839
4840         PR rust/24414:
4841         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4842         (rust_lex_int_test): Change "value" to be LONGEST.
4843         (rust_lex_tests): Add test for long integer literal.
4844
4845 2019-04-09  Tom Tromey  <tromey@adacore.com>
4846
4847         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4848         to bool.
4849         (extended_remote_target::attach): Update.
4850         (remote_target::remote_notice_new_inferior): Update.
4851         (remote_target::add_current_inferior_and_thread): Update.
4852         * inferior.c (exit_inferior_1): Use "false".
4853         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4854
4855 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4856
4857         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4858         the "start" command.
4859
4860 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4861
4862         * python/py-inferior.c (infpy_thread_from_thread_handle):
4863         Adjust comments to reflect renaming of thread_from_thread_handle
4864         to thread_from_handle.  Adjust keywords.  Fix type error message.
4865         (inferior_object_methods): Add thread_from_handle.  Retain
4866         thread_from_thread_handle, but mark it as deprecated.
4867
4868 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4869
4870         * gdbthread.h (find_thread_by_handle): Revise declaration.
4871         * thread.c (find_thread_by_handle): Likewise.  Adjust
4872         implementation too.
4873         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4874         support for buffer objects as handles.
4875
4876 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4877
4878         * python/py-infthread.c (thpy_thread_handle): New function.
4879         (thread_object_methods): Register thpy_thread_handle.
4880
4881 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4882
4883         * gdbthread.h (thread_to_thread_handle): Declare.
4884         * thread.c (gdbtypes.h): Include.
4885         (thread_to_thread_handle): New function.
4886
4887         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4888         (target_thread_info_to_thread_handle): Declare.
4889         * target.c (target_thread_info_to_thread_handle): New function.
4890         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4891         * target-delegates.c: Regenerate.
4892
4893         * linux-thread-db.c (class thread_db_target): Add method
4894         thread_info_to_thread_handle.
4895         (thread_db_target::thread_info_to_thread_handle): Define.
4896         * remote.c (class remote_target): Add new method
4897         thread_info_to_thread_handle.
4898         (remote_target::thread_info_to_thread_handle): Define.
4899
4900 2019-04-08  Pedro Alves  <palves@redhat.com>
4901
4902         * common/common-exceptions.c (throw_exception): Don't create
4903         named object to throw; throw directly.
4904         (throw_it): Likewise.  Don't initialize gdb_exception::message
4905         here, with new; pass FMT and AP to the ctor instead.
4906         * common/common-exceptions.h: Include <string>.
4907         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4908         const char *, va_list)): New ctor.  Use std::make_shared.
4909         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4910         errors)): Delete.
4911         (gdb_exception_error::gdb_exception_error(enum errors, const char
4912         *, va_list)): New.
4913         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4914         Add assertion.
4915         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4916         errors)): Delete.
4917         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4918         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4919         Add assertion.
4920
4921 2019-04-08  Tom Tromey  <tom@tromey.com>
4922
4923         * valops.c (value_rtti_indirect_type): Replace throw_exception
4924         with throw.
4925         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4926         with throw.
4927         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4928         throw.
4929         * target.c (target_translate_tls_address): Replace throw_exception
4930         with throw.
4931         * stack.c (frame_apply_command_count): Replace throw_exception
4932         with throw.
4933         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4934         throw.
4935         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4936         with throw.
4937         * rs6000-tdep.c (rs6000_frame_cache)
4938         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4939         * remote.c: Replace throw_exception with throw.
4940         * record-full.c (record_full_message, record_full_wait_1)
4941         (record_full_restore): Replace throw_exception with throw.
4942         * record-btrace.c:
4943         (get_thread_current_frame_id, record_btrace_start_replaying)
4944         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4945         (cmd_record_btrace_start): Replace throw_exception with throw.
4946         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4947         throw.
4948         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4949         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4950         * linespec.c:
4951         (find_linespec_symbols): Replace throw_exception with throw.
4952         * infrun.c (displaced_step_prepare, resume): Replace
4953         throw_exception with throw.
4954         * infcmd.c (post_create_inferior): Replace throw_exception with
4955         throw.
4956         * inf-loop.c (inferior_event_handler): Replace throw_exception
4957         with throw.
4958         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4959         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4960         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4961         (get_prev_frame_always, get_frame_pc_if_available)
4962         (get_frame_address_in_block_if_available, get_frame_language):
4963         Replace throw_exception with throw.
4964         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4965         throw_exception with throw.
4966         * eval.c (fetch_subexp_value, evaluate_var_value)
4967         (evaluate_funcall, evaluate_subexp_standard): Replace
4968         throw_exception with throw.
4969         * dwarf2loc.c (call_site_find_chain)
4970         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4971         Replace throw_exception with throw.
4972         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4973         with throw.
4974         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4975         throw.
4976         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4977         * completer.c (complete_line_internal): Replace throw_exception
4978         with throw.
4979         * compile/compile-object-run.c (compile_object_run): Replace
4980         throw_exception with throw.
4981         * cli/cli-script.c (process_next_line): Replace throw_exception
4982         with throw.
4983         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4984         (btrace_enable, btrace_maint_update_pt_packets): Replace
4985         throw_exception with throw.
4986         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4987         throw_exception with throw.
4988         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4989         throw_exception with throw.
4990         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4991         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4992         * aarch64-tdep.c (aarch64_make_prologue_cache)
4993         (aarch64_make_stub_cache): Replace throw_exception with throw.
4994
4995 2019-04-08  Tom Tromey  <tom@tromey.com>
4996
4997         * common/common-exceptions.c (throw_exception): Rename from
4998         throw_exception_cxx.  Remove old copy.  Make argument const.
4999         (throw_it): Create and throw exception objects directly.
5000         * common/common-exceptions.h (throw_exception): Make argument
5001         const.
5002         (struct gdb_exception_error): Add constructor.
5003         (struct gdb_exception_quit): Add constructor.
5004
5005 2019-04-08  Tom Tromey  <tom@tromey.com>
5006
5007         * common/common-exceptions.h (exception_rethrow): Don't declare.
5008         (TRY_SJLJ): Update comment.
5009         (TRY, CATCH, END_CATCH): Remove.
5010         * common/common-exceptions.c (exception_rethrow): Remove.
5011
5012 2019-04-08  Tom Tromey  <tom@tromey.com>
5013
5014         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5015         Remove.
5016         (gdb_exception_error): Rename from
5017         gdb_exception_RETURN_MASK_ERROR.
5018         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5019         (gdb_quit_bad_alloc): Update.
5020         * aarch64-tdep.c: Update.
5021         * ada-lang.c: Update.
5022         * ada-typeprint.c: Update.
5023         * ada-valprint.c: Update.
5024         * amd64-tdep.c: Update.
5025         * arch-utils.c: Update.
5026         * break-catch-throw.c: Update.
5027         * breakpoint.c: Update.
5028         * btrace.c: Update.
5029         * c-varobj.c: Update.
5030         * cli/cli-cmds.c: Update.
5031         * cli/cli-interp.c: Update.
5032         * cli/cli-script.c: Update.
5033         * common/common-exceptions.c: Update.
5034         * common/new-op.c: Update.
5035         * common/selftest.c: Update.
5036         * compile/compile-c-symbols.c: Update.
5037         * compile/compile-cplus-symbols.c: Update.
5038         * compile/compile-object-load.c: Update.
5039         * compile/compile-object-run.c: Update.
5040         * completer.c: Update.
5041         * corelow.c: Update.
5042         * cp-abi.c: Update.
5043         * cp-support.c: Update.
5044         * cp-valprint.c: Update.
5045         * darwin-nat.c: Update.
5046         * disasm-selftests.c: Update.
5047         * dtrace-probe.c: Update.
5048         * dwarf-index-cache.c: Update.
5049         * dwarf-index-write.c: Update.
5050         * dwarf2-frame-tailcall.c: Update.
5051         * dwarf2-frame.c: Update.
5052         * dwarf2loc.c: Update.
5053         * dwarf2read.c: Update.
5054         * eval.c: Update.
5055         * event-loop.c: Update.
5056         * event-top.c: Update.
5057         * exec.c: Update.
5058         * f-valprint.c: Update.
5059         * fbsd-tdep.c: Update.
5060         * frame-unwind.c: Update.
5061         * frame.c: Update.
5062         * gdbtypes.c: Update.
5063         * gnu-v3-abi.c: Update.
5064         * guile/guile-internal.h: Update.
5065         * guile/scm-block.c: Update.
5066         * guile/scm-breakpoint.c: Update.
5067         * guile/scm-cmd.c: Update.
5068         * guile/scm-disasm.c: Update.
5069         * guile/scm-frame.c: Update.
5070         * guile/scm-lazy-string.c: Update.
5071         * guile/scm-math.c: Update.
5072         * guile/scm-param.c: Update.
5073         * guile/scm-ports.c: Update.
5074         * guile/scm-pretty-print.c: Update.
5075         * guile/scm-symbol.c: Update.
5076         * guile/scm-symtab.c: Update.
5077         * guile/scm-type.c: Update.
5078         * guile/scm-value.c: Update.
5079         * i386-linux-tdep.c: Update.
5080         * i386-tdep.c: Update.
5081         * inf-loop.c: Update.
5082         * infcall.c: Update.
5083         * infcmd.c: Update.
5084         * infrun.c: Update.
5085         * jit.c: Update.
5086         * language.c: Update.
5087         * linespec.c: Update.
5088         * linux-fork.c: Update.
5089         * linux-nat.c: Update.
5090         * linux-tdep.c: Update.
5091         * linux-thread-db.c: Update.
5092         * main.c: Update.
5093         * mi/mi-cmd-break.c: Update.
5094         * mi/mi-cmd-stack.c: Update.
5095         * mi/mi-interp.c: Update.
5096         * mi/mi-main.c: Update.
5097         * objc-lang.c: Update.
5098         * p-valprint.c: Update.
5099         * parse.c: Update.
5100         * ppc-linux-tdep.c: Update.
5101         * printcmd.c: Update.
5102         * python/py-arch.c: Update.
5103         * python/py-breakpoint.c: Update.
5104         * python/py-cmd.c: Update.
5105         * python/py-finishbreakpoint.c: Update.
5106         * python/py-frame.c: Update.
5107         * python/py-framefilter.c: Update.
5108         * python/py-gdb-readline.c: Update.
5109         * python/py-inferior.c: Update.
5110         * python/py-infthread.c: Update.
5111         * python/py-lazy-string.c: Update.
5112         * python/py-linetable.c: Update.
5113         * python/py-objfile.c: Update.
5114         * python/py-param.c: Update.
5115         * python/py-prettyprint.c: Update.
5116         * python/py-progspace.c: Update.
5117         * python/py-record-btrace.c: Update.
5118         * python/py-record.c: Update.
5119         * python/py-symbol.c: Update.
5120         * python/py-type.c: Update.
5121         * python/py-unwind.c: Update.
5122         * python/py-utils.c: Update.
5123         * python/py-value.c: Update.
5124         * python/python.c: Update.
5125         * record-btrace.c: Update.
5126         * record-full.c: Update.
5127         * remote-fileio.c: Update.
5128         * remote.c: Update.
5129         * riscv-tdep.c: Update.
5130         * rs6000-aix-tdep.c: Update.
5131         * rs6000-tdep.c: Update.
5132         * rust-exp.y: Update.
5133         * rust-lang.c: Update.
5134         * s390-tdep.c: Update.
5135         * selftest-arch.c: Update.
5136         * solib-dsbt.c: Update.
5137         * solib-frv.c: Update.
5138         * solib-spu.c: Update.
5139         * solib-svr4.c: Update.
5140         * solib.c: Update.
5141         * sparc64-linux-tdep.c: Update.
5142         * stack.c: Update.
5143         * symfile-mem.c: Update.
5144         * symmisc.c: Update.
5145         * target.c: Update.
5146         * thread.c: Update.
5147         * top.c: Update.
5148         * tracefile-tfile.c: Update.
5149         * tui/tui.c: Update.
5150         * typeprint.c: Update.
5151         * unittests/cli-utils-selftests.c: Update.
5152         * unittests/parse-connection-spec-selftests.c: Update.
5153         * valops.c: Update.
5154         * valprint.c: Update.
5155         * value.c: Update.
5156         * varobj.c: Update.
5157         * windows-nat.c: Update.
5158         * x86-linux-nat.c: Update.
5159         * xml-support.c: Update.
5160
5161 2019-04-08  Tom Tromey  <tom@tromey.com>
5162
5163         * xml-support.c: Use C++ exception handling.
5164         * x86-linux-nat.c: Use C++ exception handling.
5165         * windows-nat.c: Use C++ exception handling.
5166         * varobj.c: Use C++ exception handling.
5167         * value.c: Use C++ exception handling.
5168         * valprint.c: Use C++ exception handling.
5169         * valops.c: Use C++ exception handling.
5170         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5171         handling.
5172         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5173         * typeprint.c: Use C++ exception handling.
5174         * tui/tui.c: Use C++ exception handling.
5175         * tracefile-tfile.c: Use C++ exception handling.
5176         * top.c: Use C++ exception handling.
5177         * thread.c: Use C++ exception handling.
5178         * target.c: Use C++ exception handling.
5179         * symmisc.c: Use C++ exception handling.
5180         * symfile-mem.c: Use C++ exception handling.
5181         * stack.c: Use C++ exception handling.
5182         * sparc64-linux-tdep.c: Use C++ exception handling.
5183         * solib.c: Use C++ exception handling.
5184         * solib-svr4.c: Use C++ exception handling.
5185         * solib-spu.c: Use C++ exception handling.
5186         * solib-frv.c: Use C++ exception handling.
5187         * solib-dsbt.c: Use C++ exception handling.
5188         * selftest-arch.c: Use C++ exception handling.
5189         * s390-tdep.c: Use C++ exception handling.
5190         * rust-lang.c: Use C++ exception handling.
5191         * rust-exp.y: Use C++ exception handling.
5192         * rs6000-tdep.c: Use C++ exception handling.
5193         * rs6000-aix-tdep.c: Use C++ exception handling.
5194         * riscv-tdep.c: Use C++ exception handling.
5195         * remote.c: Use C++ exception handling.
5196         * remote-fileio.c: Use C++ exception handling.
5197         * record-full.c: Use C++ exception handling.
5198         * record-btrace.c: Use C++ exception handling.
5199         * python/python.c: Use C++ exception handling.
5200         * python/py-value.c: Use C++ exception handling.
5201         * python/py-utils.c: Use C++ exception handling.
5202         * python/py-unwind.c: Use C++ exception handling.
5203         * python/py-type.c: Use C++ exception handling.
5204         * python/py-symbol.c: Use C++ exception handling.
5205         * python/py-record.c: Use C++ exception handling.
5206         * python/py-record-btrace.c: Use C++ exception handling.
5207         * python/py-progspace.c: Use C++ exception handling.
5208         * python/py-prettyprint.c: Use C++ exception handling.
5209         * python/py-param.c: Use C++ exception handling.
5210         * python/py-objfile.c: Use C++ exception handling.
5211         * python/py-linetable.c: Use C++ exception handling.
5212         * python/py-lazy-string.c: Use C++ exception handling.
5213         * python/py-infthread.c: Use C++ exception handling.
5214         * python/py-inferior.c: Use C++ exception handling.
5215         * python/py-gdb-readline.c: Use C++ exception handling.
5216         * python/py-framefilter.c: Use C++ exception handling.
5217         * python/py-frame.c: Use C++ exception handling.
5218         * python/py-finishbreakpoint.c: Use C++ exception handling.
5219         * python/py-cmd.c: Use C++ exception handling.
5220         * python/py-breakpoint.c: Use C++ exception handling.
5221         * python/py-arch.c: Use C++ exception handling.
5222         * printcmd.c: Use C++ exception handling.
5223         * ppc-linux-tdep.c: Use C++ exception handling.
5224         * parse.c: Use C++ exception handling.
5225         * p-valprint.c: Use C++ exception handling.
5226         * objc-lang.c: Use C++ exception handling.
5227         * mi/mi-main.c: Use C++ exception handling.
5228         * mi/mi-interp.c: Use C++ exception handling.
5229         * mi/mi-cmd-stack.c: Use C++ exception handling.
5230         * mi/mi-cmd-break.c: Use C++ exception handling.
5231         * main.c: Use C++ exception handling.
5232         * linux-thread-db.c: Use C++ exception handling.
5233         * linux-tdep.c: Use C++ exception handling.
5234         * linux-nat.c: Use C++ exception handling.
5235         * linux-fork.c: Use C++ exception handling.
5236         * linespec.c: Use C++ exception handling.
5237         * language.c: Use C++ exception handling.
5238         * jit.c: Use C++ exception handling.
5239         * infrun.c: Use C++ exception handling.
5240         * infcmd.c: Use C++ exception handling.
5241         * infcall.c: Use C++ exception handling.
5242         * inf-loop.c: Use C++ exception handling.
5243         * i386-tdep.c: Use C++ exception handling.
5244         * i386-linux-tdep.c: Use C++ exception handling.
5245         * guile/scm-value.c: Use C++ exception handling.
5246         * guile/scm-type.c: Use C++ exception handling.
5247         * guile/scm-symtab.c: Use C++ exception handling.
5248         * guile/scm-symbol.c: Use C++ exception handling.
5249         * guile/scm-pretty-print.c: Use C++ exception handling.
5250         * guile/scm-ports.c: Use C++ exception handling.
5251         * guile/scm-param.c: Use C++ exception handling.
5252         * guile/scm-math.c: Use C++ exception handling.
5253         * guile/scm-lazy-string.c: Use C++ exception handling.
5254         * guile/scm-frame.c: Use C++ exception handling.
5255         * guile/scm-disasm.c: Use C++ exception handling.
5256         * guile/scm-cmd.c: Use C++ exception handling.
5257         * guile/scm-breakpoint.c: Use C++ exception handling.
5258         * guile/scm-block.c: Use C++ exception handling.
5259         * guile/guile-internal.h: Use C++ exception handling.
5260         * gnu-v3-abi.c: Use C++ exception handling.
5261         * gdbtypes.c: Use C++ exception handling.
5262         * frame.c: Use C++ exception handling.
5263         * frame-unwind.c: Use C++ exception handling.
5264         * fbsd-tdep.c: Use C++ exception handling.
5265         * f-valprint.c: Use C++ exception handling.
5266         * exec.c: Use C++ exception handling.
5267         * event-top.c: Use C++ exception handling.
5268         * event-loop.c: Use C++ exception handling.
5269         * eval.c: Use C++ exception handling.
5270         * dwarf2read.c: Use C++ exception handling.
5271         * dwarf2loc.c: Use C++ exception handling.
5272         * dwarf2-frame.c: Use C++ exception handling.
5273         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5274         * dwarf-index-write.c: Use C++ exception handling.
5275         * dwarf-index-cache.c: Use C++ exception handling.
5276         * dtrace-probe.c: Use C++ exception handling.
5277         * disasm-selftests.c: Use C++ exception handling.
5278         * darwin-nat.c: Use C++ exception handling.
5279         * cp-valprint.c: Use C++ exception handling.
5280         * cp-support.c: Use C++ exception handling.
5281         * cp-abi.c: Use C++ exception handling.
5282         * corelow.c: Use C++ exception handling.
5283         * completer.c: Use C++ exception handling.
5284         * compile/compile-object-run.c: Use C++ exception handling.
5285         * compile/compile-object-load.c: Use C++ exception handling.
5286         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5287         * compile/compile-c-symbols.c: Use C++ exception handling.
5288         * common/selftest.c: Use C++ exception handling.
5289         * common/new-op.c: Use C++ exception handling.
5290         * cli/cli-script.c: Use C++ exception handling.
5291         * cli/cli-interp.c: Use C++ exception handling.
5292         * cli/cli-cmds.c: Use C++ exception handling.
5293         * c-varobj.c: Use C++ exception handling.
5294         * btrace.c: Use C++ exception handling.
5295         * breakpoint.c: Use C++ exception handling.
5296         * break-catch-throw.c: Use C++ exception handling.
5297         * arch-utils.c: Use C++ exception handling.
5298         * amd64-tdep.c: Use C++ exception handling.
5299         * ada-valprint.c: Use C++ exception handling.
5300         * ada-typeprint.c: Use C++ exception handling.
5301         * ada-lang.c: Use C++ exception handling.
5302         * aarch64-tdep.c: Use C++ exception handling.
5303
5304 2019-04-08  Tom Tromey  <tom@tromey.com>
5305
5306         * xml-support.c (gdb_xml_parser::parse): Update.
5307         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5308         * value.c (show_convenience): Update.
5309         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5310         (test_parse_flags_qcs): Update.
5311         * thread.c (thr_try_catch_cmd): Update.
5312         * target.c (target_translate_tls_address): Update.
5313         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5314         (info_frame_command_core, frame_apply_command_count): Update.
5315         * rust-exp.y (rust_lex_exception_test): Update.
5316         * riscv-tdep.c (riscv_print_one_register_info): Update.
5317         * remote.c (remote_target::enable_btrace): Update.
5318         * record-btrace.c (record_btrace_enable_warn): Update.
5319         * python/py-utils.c (gdbpy_convert_exception): Update.
5320         * printcmd.c (do_one_display, print_variable_and_value): Update.
5321         * mi/mi-main.c (mi_print_exception): Update.
5322         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5323         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5324         * linux-nat.c (linux_nat_target::attach): Update.
5325         * linux-fork.c (class scoped_switch_fork_info): Update.
5326         * infrun.c (displaced_step_prepare): Update.
5327         * infcall.c (call_function_by_hand_dummy): Update.
5328         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5329         * gnu-v3-abi.c (print_one_vtable): Update.
5330         * frame.c (get_prev_frame_always): Update.
5331         * f-valprint.c (info_common_command_for_block): Update.
5332         * exec.c (try_open_exec_file): Update.
5333         * exceptions.c (print_exception, exception_print)
5334         (exception_fprintf, exception_print_same): Update.
5335         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5336         * dwarf-index-cache.c (index_cache::store)
5337         (index_cache::lookup_gdb_index): Update.
5338         * darwin-nat.c (maybe_cache_shell): Update.
5339         * cp-valprint.c (cp_print_value_fields): Update.
5340         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5341         (gcc_cplus_symbol_address): Update.
5342         * compile/compile-c-symbols.c (gcc_convert_symbol)
5343         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5344         * common/selftest.c: Update.
5345         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5346         a std::string.
5347         (exception_try_scope_entry, exception_try_scope_exit): Don't
5348         declare.
5349         (struct exception_try_scope): Remove.
5350         (TRY): Don't use exception_try_scope.
5351         (struct gdb_exception): Add constructor, operator=.
5352         <what>: New method.
5353         (struct gdb_exception_RETURN_MASK_ALL)
5354         (struct gdb_exception_RETURN_MASK_ERROR)
5355         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5356         (struct gdb_quit_bad_alloc): Update.
5357         * common/common-exceptions.c (exception_none): Change
5358         initializer.
5359         (struct catcher) <state, exception>: Initialize inline.
5360         <prev>: Remove member.
5361         (current_catcher): Remove.
5362         (catchers): New global.
5363         (exceptions_state_mc_init): Simplify.
5364         (catcher_pop): Remove.
5365         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5366         (try_scope_depth, exception_try_scope_entry)
5367         (exception_try_scope_exit): Remove.
5368         (throw_exception_sjlj): Update.
5369         (exception_messages, exception_messages_size): Remove.
5370         (throw_it): Simplify.
5371         (gdb_exception_sliced_copy): Remove.
5372         (throw_exception_cxx): Update.
5373         * cli/cli-script.c (script_from_file): Update.
5374         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5375         Update.
5376         * ada-valprint.c (ada_val_print): Update.
5377         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5378         (create_excep_cond_exprs): Update.
5379
5380 2019-04-08  Tom Tromey  <tom@tromey.com>
5381
5382         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5383         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5384         (TRY, CATCH, END_CATCH): Remove some definitions.
5385         * common/common-exceptions.c: Don't use GDB_XCPT.
5386         (catcher_list_size): Remove.
5387         (throw_exception, throw_it): Simplify.
5388
5389 2019-04-05  Tom Tromey  <tom@tromey.com>
5390
5391         Revert the header-sorting patch.
5392         * ft32-tdep.c: Revert.
5393         * frv-tdep.c: Revert.
5394         * frv-linux-tdep.c: Revert.
5395         * frame.c: Revert.
5396         * frame-unwind.c: Revert.
5397         * frame-base.c: Revert.
5398         * fork-child.c: Revert.
5399         * findvar.c: Revert.
5400         * findcmd.c: Revert.
5401         * filesystem.c: Revert.
5402         * filename-seen-cache.h: Revert.
5403         * filename-seen-cache.c: Revert.
5404         * fbsd-tdep.c: Revert.
5405         * fbsd-nat.h: Revert.
5406         * fbsd-nat.c: Revert.
5407         * f-valprint.c: Revert.
5408         * f-typeprint.c: Revert.
5409         * f-lang.c: Revert.
5410         * extension.h: Revert.
5411         * extension.c: Revert.
5412         * extension-priv.h: Revert.
5413         * expprint.c: Revert.
5414         * exec.h: Revert.
5415         * exec.c: Revert.
5416         * exceptions.c: Revert.
5417         * event-top.c: Revert.
5418         * event-loop.c: Revert.
5419         * eval.c: Revert.
5420         * elfread.c: Revert.
5421         * dwarf2read.h: Revert.
5422         * dwarf2read.c: Revert.
5423         * dwarf2loc.c: Revert.
5424         * dwarf2expr.h: Revert.
5425         * dwarf2expr.c: Revert.
5426         * dwarf2-frame.c: Revert.
5427         * dwarf2-frame-tailcall.c: Revert.
5428         * dwarf-index-write.h: Revert.
5429         * dwarf-index-write.c: Revert.
5430         * dwarf-index-common.c: Revert.
5431         * dwarf-index-cache.h: Revert.
5432         * dwarf-index-cache.c: Revert.
5433         * dummy-frame.c: Revert.
5434         * dtrace-probe.c: Revert.
5435         * disasm.h: Revert.
5436         * disasm.c: Revert.
5437         * disasm-selftests.c: Revert.
5438         * dictionary.c: Revert.
5439         * dicos-tdep.c: Revert.
5440         * demangle.c: Revert.
5441         * dcache.h: Revert.
5442         * dcache.c: Revert.
5443         * darwin-nat.h: Revert.
5444         * darwin-nat.c: Revert.
5445         * darwin-nat-info.c: Revert.
5446         * d-valprint.c: Revert.
5447         * d-namespace.c: Revert.
5448         * d-lang.c: Revert.
5449         * ctf.c: Revert.
5450         * csky-tdep.c: Revert.
5451         * csky-linux-tdep.c: Revert.
5452         * cris-tdep.c: Revert.
5453         * cris-linux-tdep.c: Revert.
5454         * cp-valprint.c: Revert.
5455         * cp-support.c: Revert.
5456         * cp-namespace.c: Revert.
5457         * cp-abi.c: Revert.
5458         * corelow.c: Revert.
5459         * corefile.c: Revert.
5460         * continuations.c: Revert.
5461         * completer.h: Revert.
5462         * completer.c: Revert.
5463         * complaints.c: Revert.
5464         * coffread.c: Revert.
5465         * coff-pe-read.c: Revert.
5466         * cli-out.h: Revert.
5467         * cli-out.c: Revert.
5468         * charset.c: Revert.
5469         * c-varobj.c: Revert.
5470         * c-valprint.c: Revert.
5471         * c-typeprint.c: Revert.
5472         * c-lang.c: Revert.
5473         * buildsym.c: Revert.
5474         * buildsym-legacy.c: Revert.
5475         * build-id.h: Revert.
5476         * build-id.c: Revert.
5477         * btrace.c: Revert.
5478         * bsd-uthread.c: Revert.
5479         * breakpoint.h: Revert.
5480         * breakpoint.c: Revert.
5481         * break-catch-throw.c: Revert.
5482         * break-catch-syscall.c: Revert.
5483         * break-catch-sig.c: Revert.
5484         * blockframe.c: Revert.
5485         * block.c: Revert.
5486         * bfin-tdep.c: Revert.
5487         * bfin-linux-tdep.c: Revert.
5488         * bfd-target.c: Revert.
5489         * bcache.c: Revert.
5490         * ax-general.c: Revert.
5491         * ax-gdb.h: Revert.
5492         * ax-gdb.c: Revert.
5493         * avr-tdep.c: Revert.
5494         * auxv.c: Revert.
5495         * auto-load.c: Revert.
5496         * arm-wince-tdep.c: Revert.
5497         * arm-tdep.c: Revert.
5498         * arm-symbian-tdep.c: Revert.
5499         * arm-pikeos-tdep.c: Revert.
5500         * arm-obsd-tdep.c: Revert.
5501         * arm-nbsd-tdep.c: Revert.
5502         * arm-nbsd-nat.c: Revert.
5503         * arm-linux-tdep.c: Revert.
5504         * arm-linux-nat.c: Revert.
5505         * arm-fbsd-tdep.c: Revert.
5506         * arm-fbsd-nat.c: Revert.
5507         * arm-bsd-tdep.c: Revert.
5508         * arch-utils.c: Revert.
5509         * arc-tdep.c: Revert.
5510         * arc-newlib-tdep.c: Revert.
5511         * annotate.h: Revert.
5512         * annotate.c: Revert.
5513         * amd64-windows-tdep.c: Revert.
5514         * amd64-windows-nat.c: Revert.
5515         * amd64-tdep.c: Revert.
5516         * amd64-sol2-tdep.c: Revert.
5517         * amd64-obsd-tdep.c: Revert.
5518         * amd64-obsd-nat.c: Revert.
5519         * amd64-nbsd-tdep.c: Revert.
5520         * amd64-nbsd-nat.c: Revert.
5521         * amd64-nat.c: Revert.
5522         * amd64-linux-tdep.c: Revert.
5523         * amd64-linux-nat.c: Revert.
5524         * amd64-fbsd-tdep.c: Revert.
5525         * amd64-fbsd-nat.c: Revert.
5526         * amd64-dicos-tdep.c: Revert.
5527         * amd64-darwin-tdep.c: Revert.
5528         * amd64-bsd-nat.c: Revert.
5529         * alpha-tdep.c: Revert.
5530         * alpha-obsd-tdep.c: Revert.
5531         * alpha-nbsd-tdep.c: Revert.
5532         * alpha-mdebug-tdep.c: Revert.
5533         * alpha-linux-tdep.c: Revert.
5534         * alpha-linux-nat.c: Revert.
5535         * alpha-bsd-tdep.c: Revert.
5536         * alpha-bsd-nat.c: Revert.
5537         * aix-thread.c: Revert.
5538         * agent.c: Revert.
5539         * addrmap.c: Revert.
5540         * ada-varobj.c: Revert.
5541         * ada-valprint.c: Revert.
5542         * ada-typeprint.c: Revert.
5543         * ada-tasks.c: Revert.
5544         * ada-lang.c: Revert.
5545         * aarch64-tdep.c: Revert.
5546         * aarch64-ravenscar-thread.c: Revert.
5547         * aarch64-newlib-tdep.c: Revert.
5548         * aarch64-linux-tdep.c: Revert.
5549         * aarch64-linux-nat.c: Revert.
5550         * aarch64-fbsd-tdep.c: Revert.
5551         * aarch64-fbsd-nat.c: Revert.
5552         * aarch32-linux-nat.c: Revert.
5553
5554 2019-04-05  Tom Tromey  <tom@tromey.com>
5555
5556         * ft32-tdep.c: Sort headers.
5557         * frv-tdep.c: Sort headers.
5558         * frv-linux-tdep.c: Sort headers.
5559         * frame.c: Sort headers.
5560         * frame-unwind.c: Sort headers.
5561         * frame-base.c: Sort headers.
5562         * fork-child.c: Sort headers.
5563         * findvar.c: Sort headers.
5564         * findcmd.c: Sort headers.
5565         * filesystem.c: Sort headers.
5566         * filename-seen-cache.h: Sort headers.
5567         * filename-seen-cache.c: Sort headers.
5568         * fbsd-tdep.c: Sort headers.
5569         * fbsd-nat.h: Sort headers.
5570         * fbsd-nat.c: Sort headers.
5571         * f-valprint.c: Sort headers.
5572         * f-typeprint.c: Sort headers.
5573         * f-lang.c: Sort headers.
5574         * extension.h: Sort headers.
5575         * extension.c: Sort headers.
5576         * extension-priv.h: Sort headers.
5577         * expprint.c: Sort headers.
5578         * exec.h: Sort headers.
5579         * exec.c: Sort headers.
5580         * exceptions.c: Sort headers.
5581         * event-top.c: Sort headers.
5582         * event-loop.c: Sort headers.
5583         * eval.c: Sort headers.
5584         * elfread.c: Sort headers.
5585         * dwarf2read.h: Sort headers.
5586         * dwarf2read.c: Sort headers.
5587         * dwarf2loc.c: Sort headers.
5588         * dwarf2expr.h: Sort headers.
5589         * dwarf2expr.c: Sort headers.
5590         * dwarf2-frame.c: Sort headers.
5591         * dwarf2-frame-tailcall.c: Sort headers.
5592         * dwarf-index-write.h: Sort headers.
5593         * dwarf-index-write.c: Sort headers.
5594         * dwarf-index-common.c: Sort headers.
5595         * dwarf-index-cache.h: Sort headers.
5596         * dwarf-index-cache.c: Sort headers.
5597         * dummy-frame.c: Sort headers.
5598         * dtrace-probe.c: Sort headers.
5599         * disasm.h: Sort headers.
5600         * disasm.c: Sort headers.
5601         * disasm-selftests.c: Sort headers.
5602         * dictionary.c: Sort headers.
5603         * dicos-tdep.c: Sort headers.
5604         * demangle.c: Sort headers.
5605         * dcache.h: Sort headers.
5606         * dcache.c: Sort headers.
5607         * darwin-nat.h: Sort headers.
5608         * darwin-nat.c: Sort headers.
5609         * darwin-nat-info.c: Sort headers.
5610         * d-valprint.c: Sort headers.
5611         * d-namespace.c: Sort headers.
5612         * d-lang.c: Sort headers.
5613         * ctf.c: Sort headers.
5614         * csky-tdep.c: Sort headers.
5615         * csky-linux-tdep.c: Sort headers.
5616         * cris-tdep.c: Sort headers.
5617         * cris-linux-tdep.c: Sort headers.
5618         * cp-valprint.c: Sort headers.
5619         * cp-support.c: Sort headers.
5620         * cp-namespace.c: Sort headers.
5621         * cp-abi.c: Sort headers.
5622         * corelow.c: Sort headers.
5623         * corefile.c: Sort headers.
5624         * continuations.c: Sort headers.
5625         * completer.h: Sort headers.
5626         * completer.c: Sort headers.
5627         * complaints.c: Sort headers.
5628         * coffread.c: Sort headers.
5629         * coff-pe-read.c: Sort headers.
5630         * cli-out.h: Sort headers.
5631         * cli-out.c: Sort headers.
5632         * charset.c: Sort headers.
5633         * c-varobj.c: Sort headers.
5634         * c-valprint.c: Sort headers.
5635         * c-typeprint.c: Sort headers.
5636         * c-lang.c: Sort headers.
5637         * buildsym.c: Sort headers.
5638         * buildsym-legacy.c: Sort headers.
5639         * build-id.h: Sort headers.
5640         * build-id.c: Sort headers.
5641         * btrace.c: Sort headers.
5642         * bsd-uthread.c: Sort headers.
5643         * breakpoint.h: Sort headers.
5644         * breakpoint.c: Sort headers.
5645         * break-catch-throw.c: Sort headers.
5646         * break-catch-syscall.c: Sort headers.
5647         * break-catch-sig.c: Sort headers.
5648         * blockframe.c: Sort headers.
5649         * block.c: Sort headers.
5650         * bfin-tdep.c: Sort headers.
5651         * bfin-linux-tdep.c: Sort headers.
5652         * bfd-target.c: Sort headers.
5653         * bcache.c: Sort headers.
5654         * ax-general.c: Sort headers.
5655         * ax-gdb.h: Sort headers.
5656         * ax-gdb.c: Sort headers.
5657         * avr-tdep.c: Sort headers.
5658         * auxv.c: Sort headers.
5659         * auto-load.c: Sort headers.
5660         * arm-wince-tdep.c: Sort headers.
5661         * arm-tdep.c: Sort headers.
5662         * arm-symbian-tdep.c: Sort headers.
5663         * arm-pikeos-tdep.c: Sort headers.
5664         * arm-obsd-tdep.c: Sort headers.
5665         * arm-nbsd-tdep.c: Sort headers.
5666         * arm-nbsd-nat.c: Sort headers.
5667         * arm-linux-tdep.c: Sort headers.
5668         * arm-linux-nat.c: Sort headers.
5669         * arm-fbsd-tdep.c: Sort headers.
5670         * arm-fbsd-nat.c: Sort headers.
5671         * arm-bsd-tdep.c: Sort headers.
5672         * arch-utils.c: Sort headers.
5673         * arc-tdep.c: Sort headers.
5674         * arc-newlib-tdep.c: Sort headers.
5675         * annotate.h: Sort headers.
5676         * annotate.c: Sort headers.
5677         * amd64-windows-tdep.c: Sort headers.
5678         * amd64-windows-nat.c: Sort headers.
5679         * amd64-tdep.c: Sort headers.
5680         * amd64-sol2-tdep.c: Sort headers.
5681         * amd64-obsd-tdep.c: Sort headers.
5682         * amd64-obsd-nat.c: Sort headers.
5683         * amd64-nbsd-tdep.c: Sort headers.
5684         * amd64-nbsd-nat.c: Sort headers.
5685         * amd64-nat.c: Sort headers.
5686         * amd64-linux-tdep.c: Sort headers.
5687         * amd64-linux-nat.c: Sort headers.
5688         * amd64-fbsd-tdep.c: Sort headers.
5689         * amd64-fbsd-nat.c: Sort headers.
5690         * amd64-dicos-tdep.c: Sort headers.
5691         * amd64-darwin-tdep.c: Sort headers.
5692         * amd64-bsd-nat.c: Sort headers.
5693         * alpha-tdep.c: Sort headers.
5694         * alpha-obsd-tdep.c: Sort headers.
5695         * alpha-nbsd-tdep.c: Sort headers.
5696         * alpha-mdebug-tdep.c: Sort headers.
5697         * alpha-linux-tdep.c: Sort headers.
5698         * alpha-linux-nat.c: Sort headers.
5699         * alpha-bsd-tdep.c: Sort headers.
5700         * alpha-bsd-nat.c: Sort headers.
5701         * aix-thread.c: Sort headers.
5702         * agent.c: Sort headers.
5703         * addrmap.c: Sort headers.
5704         * ada-varobj.c: Sort headers.
5705         * ada-valprint.c: Sort headers.
5706         * ada-typeprint.c: Sort headers.
5707         * ada-tasks.c: Sort headers.
5708         * ada-lang.c: Sort headers.
5709         * aarch64-tdep.c: Sort headers.
5710         * aarch64-ravenscar-thread.c: Sort headers.
5711         * aarch64-newlib-tdep.c: Sort headers.
5712         * aarch64-linux-tdep.c: Sort headers.
5713         * aarch64-linux-nat.c: Sort headers.
5714         * aarch64-fbsd-tdep.c: Sort headers.
5715         * aarch64-fbsd-nat.c: Sort headers.
5716         * aarch32-linux-nat.c: Sort headers.
5717
5718 2019-04-04  Tom Tromey  <tom@tromey.com>
5719
5720         * varobj.c (varobj_create): Update.
5721         * rust-exp.y (struct rust_parser) <update_innermost_block,
5722         lookup_symbol>: New methods.
5723         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5724         Rename.
5725         (rust_parser::rust_lookup_type)
5726         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5727         * printcmd.c (display_command, do_one_display): Update.
5728         * parser-defs.h (struct parser_state) <parser_state>: Add
5729         "tracker" parameter.
5730         (block_tracker): New member.
5731         (class innermost_block_tracker) <innermost_block_tracker>: Add
5732         "types" parameter.
5733         <reset>: Remove method.
5734         (innermost_block): Don't declare.
5735         (null_post_parser): Update.
5736         * parse.c (innermost_block): Remove global.
5737         (write_dollar_variable): Update.
5738         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5739         Remove "tracker_types" parameter.
5740         (parse_expression): Add "tracker" parameter.
5741         (parse_expression_for_completion): Update.
5742         (null_post_parser): Add "tracker" parameter.
5743         * p-exp.y: Update rules.
5744         * m2-exp.y: Update rules.
5745         * language.h (struct language_defn) <la_post_parser>: Add
5746         "tracker" parameter.
5747         * go-exp.y: Update rules.
5748         * f-exp.y: Update rules.
5749         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5750         parameter.
5751         * d-exp.y: Update rules.
5752         * c-exp.y: Update rules.
5753         * breakpoint.c (set_breakpoint_condition): Create an
5754         innermost_block_tracker.
5755         (watch_command_1): Likewise.
5756         * ada-lang.c (resolve): Add "tracker" parameter.
5757         (resolve_subexp): Likewise.
5758         * ada-exp.y (write_var_from_sym): Update.
5759
5760 2019-04-04  Tom Tromey  <tom@tromey.com>
5761
5762         * type-stack.h: New file.
5763         * type-stack.c: New file.
5764         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5765         type-stack.h.
5766         (insert_into_type_stack, insert_type, push_type, push_type_int)
5767         (insert_type_address_space, pop_type, pop_type_int)
5768         (pop_typelist, pop_type_stack, append_type_stack)
5769         (push_type_stack, get_type_stack, push_typelist)
5770         (follow_type_instance_flags, follow_types): Don't declare.
5771         * parse.c (type_stack): Remove global.
5772         (parse_exp_in_context): Update.
5773         (insert_into_type_stack, insert_type, push_type, push_type_int)
5774         (insert_type_address_space, pop_type, pop_type_int)
5775         (pop_typelist, pop_type_stack, append_type_stack)
5776         (push_type_stack, get_type_stack, push_typelist)
5777         (follow_type_instance_flags, follow_types): Remove (moved to
5778         type-stack.c).
5779         * f-exp.y (type_stack): New global.
5780         Update rules.
5781         (push_kind_type, f_parse): Update.
5782         * d-exp.y (type_stack): New global.
5783         Update rules.
5784         (d_parse): Update.
5785         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5786         Update rules.
5787         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5788         (HFILES_NO_SRCDIR): Add type-stack.h.
5789
5790 2019-04-04  Tom Tromey  <tom@tromey.com>
5791
5792         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5793         (rust_parser::convert_ast_to_expression, rust_parse)
5794         (rust_lex_test_completion, rust_lex_tests): Update.
5795         * parser-defs.h (struct expr_completion_state): New.
5796         (struct parser_state) <parser_state>: Add completion parameter.
5797         <mark_struct_expression, mark_completion_tag>: New methods.
5798         <parse_completion, m_completion_state>: New members.
5799         (prefixify_expression, null_post_parser): Update.
5800         (mark_struct_expression, mark_completion_tag): Don't declare.
5801         * parse.c (parse_completion, expout_last_struct)
5802         (expout_tag_completion_type, expout_completion_name): Remove
5803         globals.
5804         (parser_state::mark_struct_expression)
5805         (parser_state::mark_completion_tag): Now methods.
5806         (prefixify_expression): Add last_struct parameter.
5807         (prefixify_subexp): Likewise.
5808         (parse_exp_1): Update.
5809         (parse_exp_in_context): Add cstate parameter.  Update.
5810         (parse_expression_for_completion): Create an
5811         expr_completion_state.
5812         (null_post_parser): Add "completion" parameter.
5813         * p-exp.y: Update rules.
5814         (yylex): Update.
5815         * language.h (struct language_defn) <la_post_parser>: Add
5816         "completing" parameter.
5817         * go-exp.y: Update rules.
5818         (lex_one_token): Update.
5819         * expression.h (parse_completion): Don't declare.
5820         * d-exp.y: Update rules.
5821         (lex_one_token): Update rules.
5822         * c-exp.y: Update rules.
5823         (lex_one_token): Update.
5824         * ada-lang.c (resolve): Add "parse_completion" parameter.
5825         (resolve_subexp): Likewise.
5826         (ada_resolve_function): Likewise.
5827
5828 2019-04-04  Tom Tromey  <tom@tromey.com>
5829
5830         * parser-defs.h (struct parser_state) <start_arglist,
5831         end_arglist>: New methods.
5832         <arglist_len, m_funcall_chain>: New members.
5833         (arglist_len, start_arglist, end_arglist): Don't declare.
5834         * parse.c (arglist_len, funcall_chain): Remove global.
5835         (start_arglist, end_arglist): Remove functions.
5836         (parse_exp_in_context): Update.
5837         * p-exp.y: Update rules.
5838         * m2-exp.y: Update rules.
5839         * go-exp.y: Update rules.
5840         * f-exp.y: Update rules.
5841         * d-exp.y: Update rules.
5842         * c-exp.y: Update rules.
5843
5844 2019-04-04  Tom Tromey  <tom@tromey.com>
5845
5846         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5847         lex_operator, push_back>: New methods.
5848         Update all rules.
5849         (rust_parser::lex_hex, lex_escape): Rename and update.
5850         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5851         (rust_parser::lex_operator): Rename and update.
5852         (rust_parser::lex_number, rustyylex, rustyyerror)
5853         (rust_lex_test_init, rust_lex_test_sequence)
5854         (rust_lex_test_push_back, rust_lex_tests): Update.
5855         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5856         parameter.
5857         <lexptr, prev_lexptr>: New members.
5858         (lexptr, prev_lexptr): Don't declare.
5859         * parse.c (lexptr, prev_lexptr): Remove globals.
5860         (parse_exp_in_context): Update.
5861         * p-exp.y (yylex, yyerror): Update.
5862         * m2-exp.y (parse_number, yylex, yyerror): Update.
5863         * go-exp.y (lex_one_token, yyerror): Update.
5864         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5865         * d-exp.y (lex_one_token, yyerror): Update.
5866         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5867         (lex_one_token, yyerror): Update.
5868         * ada-lex.l (YY_INPUT): Update.
5869         (rewind_to_char): Update.
5870         * ada-exp.y (yyerror): Update.
5871
5872 2019-04-04  Tom Tromey  <tom@tromey.com>
5873
5874         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5875         * parser-defs.h (struct parser_state) <parser_state>: Add new
5876         parameter.
5877         <comma_terminates>: New member.
5878         (comma_terminates): Don't declare global.
5879         * parse.c (comma_terminates): Remove global.
5880         (parse_exp_in_context): Update.
5881         * p-exp.y (yylex): Update.
5882         * m2-exp.y (yylex): Update.
5883         * go-exp.y (lex_one_token): Update.
5884         * f-exp.y (yylex): Update.
5885         * d-exp.y (lex_one_token): Update.
5886         * c-exp.y (lex_one_token): Update.
5887         * ada-lex.l: Update.
5888
5889 2019-04-04  Tom Tromey  <tom@tromey.com>
5890
5891         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5892         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5893         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5894         * parser-defs.h (paren_depth): Don't declare.
5895         * parse.c (paren_depth): Remove global.
5896         (parse_exp_in_context): Update.
5897         * p-exp.y (paren_depth): New global.
5898         (pascal_parse): Initialize it.
5899         * m2-exp.y (paren_depth): New global.
5900         (m2_parse): Initialize it.
5901         * go-exp.y (paren_depth): New global.
5902         (go_parse): Initialize it.
5903         * f-exp.y (paren_depth): New global.
5904         (f_parse): Initialize it.
5905         * d-exp.y (paren_depth): New global.
5906         (d_parse): Initialize it.
5907         * c-exp.y (paren_depth): New global.
5908         (c_parse): Initialize it.
5909         * ada-lex.l (paren_depth): New global.
5910         (lexer_init): Initialize it.
5911
5912 2019-04-04  Tom Tromey  <tom@tromey.com>
5913
5914         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5915         (rust_parser::convert_ast_to_type)
5916         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5917         * parser-defs.h (struct parser_state) <parser_state>: Add
5918         parameters.  Initialize new members.
5919         <expression_context_block, expression_context_pc>: New members.
5920         * parse.c (expression_context_block, expression_context_pc):
5921         Remove globals.
5922         (parse_exp_in_context): Update.
5923         * p-exp.y: Update all rules.
5924         (yylex): Update.
5925         * m2-exp.y: Update all rules.
5926         (yylex): Update.
5927         * go-exp.y (yylex): Update.
5928         * f-exp.y (yylex): Update.
5929         * d-exp.y: Update all rules.
5930         (yylex): Update.
5931         * c-exp.y: Update all rules.
5932         (lex_one_token, classify_name, yylex, c_parse): Update.
5933         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5934
5935 2019-04-04  Tom Tromey  <tom@tromey.com>
5936
5937         * gdbarch.h, gdbarch.c: Rebuild.
5938         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5939         * stap-probe.h:
5940         (struct stap_parse_info): Replace "parser_state" with
5941         "expr_builder".
5942         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5943         (parser_state): New class.
5944         * parse.c (expr_builder): Rename.
5945         (expr_builder::release): Rename.
5946         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5947         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5948         (write_exp_elt_longcst, write_exp_elt_floatcst)
5949         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5950         (write_exp_string_vector, write_exp_bitstring)
5951         (write_exp_msymbol, mark_struct_expression)
5952         (write_dollar_variable)
5953         (insert_type_address_space, increase_expout_size): Replace
5954         "parser_state" with "expr_builder".
5955         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5956         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5957         "parser_state" with "expr_builder".
5958
5959 2019-04-04  Tom Tromey  <tom@tromey.com>
5960
5961         * rust-exp.y: Replace "parse_language" with method call.
5962         * p-exp.y:
5963         (yylex): Replace "parse_language" with method call.
5964         * m2-exp.y:
5965         (yylex): Replace "parse_language" with method call.
5966         * go-exp.y (classify_name): Replace "parse_language" with method
5967         call.
5968         * f-exp.y (yylex): Replace "parse_language" with method call.
5969         * d-exp.y (lex_one_token): Replace "parse_language" with method
5970         call.
5971         * c-exp.y:
5972         (lex_one_token, classify_name, yylex): Replace "parse_language"
5973         with method call.
5974         * ada-exp.y (find_primitive_type, type_char)
5975         (type_system_address): Replace "parse_language" with method call.
5976
5977 2019-04-04  Tom Tromey  <tom@tromey.com>
5978
5979         * rust-exp.y: Replace "parse_gdbarch" with method call.
5980         * parse.c (write_dollar_variable, insert_type_address_space):
5981         Replace "parse_gdbarch" with method call.
5982         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5983         call.
5984         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5985         call.
5986         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5987         "parse_gdbarch" with method call.
5988         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5989         with method call.
5990         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5991         "parse_gdbarch" with method call.
5992         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5993         "parse_gdbarch" with method call.
5994         * c-exp.y (parse_type, parse_number, classify_name): Replace
5995         "parse_gdbarch" with method call.
5996         * ada-lex.l: Replace "parse_gdbarch" with method call.
5997         * ada-exp.y (parse_type, find_primitive_type, type_char)
5998         (type_system_address): Replace "parse_gdbarch" with method call.
5999
6000 2019-04-04  Tom Tromey  <tom@tromey.com>
6001
6002         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6003         * stap-probe.c (stap_parse_argument): Update.
6004         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6005         initial_size parameter.
6006         * rust-exp.y (rust_lex_tests): Update.
6007         * parse.c (parser_state): Update.
6008         (parse_exp_in_context): Update.
6009         * parser-defs.h (struct parser_state) <parser_state>: Remove
6010         "initial_size" parameter.
6011
6012 2019-04-04  Tom Tromey  <tom@tromey.com>
6013
6014         * parser-defs.h (increase_expout_size): Don't declare.
6015         * parse.c (increase_expout_size): Now static.
6016
6017 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6018
6019         * gnu-nat.c (gnu_nat_target::wait): Fix
6020         target_waitstatus_to_string call.
6021
6022 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6023
6024         * eval.c (evaluate_subexp_standard): Handle internal functions
6025         during Fortran function call handling.
6026
6027 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6028
6029         * NEWS: Mention new internal functions.
6030         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6031         (read_base_type): Use dwarf2_init_complex_target_type.
6032         * value.c (creal_internal_fn): New function.
6033         (cimag_internal_fn): New function.
6034         (_initialize_values): Register new internal functions.
6035
6036 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6037
6038         * infrun.c (stop_all_threads): If debug_infrun, always
6039         trace the wait status after wait_one, using
6040         target_waitstatus_to_string and target_pid_to_str.
6041         (handle_inferior_event): Replace various trace of
6042         wait status kind by a single trace.
6043         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6044         wait status kind image by target_waitstatus_to_string.
6045         * target/waitstatus.c (target_waitstatus_to_string): Fix
6046         obsolete comment.
6047
6048 2019-04-01  Tom Tromey  <tromey@adacore.com>
6049
6050         PR symtab/23331:
6051         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6052
6053 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6054             Pedro Alves  <palves@redhat.com>
6055
6056         * top.c (quit_force): Call 'finalize_values'.
6057         * value.c (finalize_values): New function.
6058         * value.h (finalize_values): Declare.
6059
6060 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6061
6062         * NEWS: Announce $_gdb_major and $_gdb_minor.
6063
6064         * top.c (init_gdb_version_vars): New function.
6065         (gdb_init): Call init_gdb_version_vars.
6066
6067 2019-03-29  Tom Tromey  <tromey@adacore.com>
6068
6069         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6070         help text.  Remove dead code.
6071
6072 2019-03-29  Keith Seitz  <keiths@redhat.com>
6073
6074         From Siddhesh Poyarekar:
6075         * f-lang.h (f77_get_upperbound): Return LONGEST.
6076         (f77_get_lowerbound): Likewise.
6077         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6078         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6079         print them.
6080         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6081         plongest to format print it.
6082         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6083         (f77_get_upperbound): Likewise.
6084         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6085         LOWER_BOUND to LONGEST.
6086         (f77_create_arrayprint_offset_tbl): Likewise.
6087
6088 2019-03-29  Keith Seitz  <keiths@redhat.com>
6089
6090         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6091         %s/pulongest for TYPE_LENGTH instead of %d in format
6092         strings.
6093         * ada-typerint.c (ada_print_type): Likewise.
6094         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6095         * compile/compile-c-support.c (generate_register_struct): Likewise.
6096         * gdbtypes.c (recursive_dump_type): Likewise.
6097         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6098         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6099         instead of %d in format strings.
6100         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6101         to std::min to ULONGEST.
6102         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6103         instead of %d in format strings.
6104         * tracepoint.c (info_scope_command): Likewise.
6105         * typeprint.c (print_offset_data::update)
6106         (print_offset_data::finish): Likewise.
6107         * xtensa-tdep.c (xtensa_store_return_value)
6108         (xtensa_push_dummy_call): Likewise.
6109
6110 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6111
6112         * windows-nat.c (display_selector): Fixed format specifications
6113         for 64-bit Cygwin.
6114
6115 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6116
6117         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6118
6119 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6120
6121         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6122         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6123         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6124         (nios2_linux_init_abi): Install it.
6125
6126 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6127
6128         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6129
6130 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6131
6132         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6133
6134 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6135             Tom Tromey  <tromey@adacore.com>
6136
6137         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6138
6139 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6140
6141         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6142         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6143         method to compute the bounds of range types. Also print "[evaluated]"
6144         if the bounds' values come from a dynamic evaluation.
6145
6146 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6147
6148         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6149         whitespace when pretty printing is on.
6150
6151 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6152
6153         * ppc-linux-nat.c: Add include.
6154
6155 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6156
6157         * NEWS: Mention AArch64 Pointer Authentication.
6158
6159 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6160
6161         * arm-linux-nat.c: Add include.
6162
6163 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6164
6165         * source-cache.c (source_cache::get_source_lines): Re-read
6166         fullname after calling open_source_file.
6167
6168 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6169
6170         * NEWS: Mention TLS support for FreeBSD.
6171
6172 2019-03-25  Tom Tromey  <tromey@adacore.com>
6173
6174         * minsyms.c (BUNCH_SIZE): Update comment.
6175         (~minimal_symbol_reader): Remove old comment.
6176         (compact_minimal_symbols): Update comment.
6177         (minimal_symbol_reader::install): Remove old comment.  Update
6178         other comments.
6179
6180 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6181
6182         * s390-linux-nat.c: Add include.
6183
6184 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6185
6186         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6187         Call linux_get_hwcap.
6188         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6189         Likewise.
6190         (aarch64_linux_get_hwcap): Remove function.
6191         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6192         declaration.
6193         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6194         linux_get_hwcap.
6195         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6196         * linux-tdep.c (linux_get_hwcap): Add function.
6197         (linux_get_hwcap2): Likewise.
6198         * linux-tdep.h (linux_get_hwcap): Add declaration.
6199         (linux_get_hwcap2): Likewise.
6200         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6201         (ppc_linux_get_hwcap2): Likewise.
6202         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6203         linux_get_hwcap.
6204         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6205         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6206         (ppc_linux_nat_target::read_description): Likewise.
6207         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6208         * s390-linux-nat.c: Likewise.
6209         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6210
6211 2019-03-24  Tom Tromey  <tom@tromey.com>
6212
6213         * ada-lang.c (standard_lookup): Simplify initialization.
6214         (ada_lookup_symbol_nonlocal): Simplify return.
6215         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6216         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6217         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6218         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6219         initialization.
6220         * solib.c (solib_global_lookup): Simplify.
6221         * symtab.c (null_block_symbol): Remove.
6222         (symbol_cache_lookup): Simplify returns.
6223         (lookup_language_this): Simplify returns.
6224         (lookup_symbol_aux): Simplify return.
6225         (lookup_local_symbol): Simplify returns.
6226         (lookup_global_symbol_from_objfile): Simplify return.
6227         (lookup_symbol_in_objfile_symtabs)
6228         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6229         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6230         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6231         * cp-namespace.c (cp_lookup_bare_symbol)
6232         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6233         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6234         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6235         (cp_lookup_symbol_via_imports): Simplify initialization.
6236         (find_symbol_in_baseclass): Likewise.
6237         * symtab.h (null_block_symbol): Remove.
6238         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6239         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6240         (d_lookup_symbol_module): Likewise.
6241         (find_symbol_in_baseclass): Simplify initialization.
6242
6243 2019-03-24  Tom Tromey  <tom@tromey.com>
6244
6245         * expression.h: Don't include symtab.h.
6246         (struct block): Forward declare.
6247
6248 2019-03-24  Tom Tromey  <tom@tromey.com>
6249
6250         * c-exp.y (typebase): Remove casts.
6251         * gdbtypes.c (lookup_unsigned_typename, )
6252         (lookup_signed_typename): Remove cast.
6253         * eval.c (parse_to_comma_and_eval): Remove cast.
6254         * parse.c (write_dollar_variable): Remove cast.
6255         * block.h (struct block) <superblock>: Now const.
6256         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6257         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6258         (map_block): Make "block" const.
6259         * symfile.h (struct quick_symbol_functions)
6260         <map_matching_symbols>: Constify block argument to "callback".
6261         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6262         const.
6263         (find_pc_sect_compunit_symtab): Make "b" const.
6264         (find_symbol_at_address): Likewise.
6265         (search_symbols): Likewise.
6266         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6267         (dw2_debug_names_lookup_symbol): Likewise.
6268         (dw2_map_matching_symbols): Update.
6269         * p-valprint.c (pascal_val_print): Remove "block".
6270         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6271         (aux_add_nonlocal_symbols): Make "block" const.
6272         (resolve_subexp): Remove cast.
6273         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6274         const.
6275         (iterate_over_file_blocks): Likewise.
6276         * f-exp.y (%union) <bval>: Remove.
6277         * coffread.c (patch_opaque_types): Make "b" const.
6278         * spu-tdep.c (spu_catch_start): Make "block" const.
6279         * c-valprint.c (print_unpacked_pointer): Remove "block".
6280         * symmisc.c (dump_symtab_1): Make "b" const.
6281         (block_depth): Make "block" const.
6282         * d-exp.y (%union) <bval>: Remove.
6283         * cp-support.h (cp_lookup_rtti_type): Update.
6284         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6285         * psymtab.c (psym_lookup_symbol): Make "block" const.
6286         (maintenance_check_psymtabs): Make "b" const.
6287         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6288         (enumerate_locals, enumerate_args): Update.
6289         * python/py-symtab.c (stpy_global_block): Make "block" const.
6290         (stpy_static_block): Likewise.
6291         * inline-frame.c (block_starting_point_at): Make "new_block"
6292         const.
6293         * block.c (find_block_in_blockvector): Make return type const.
6294         (blockvector_for_pc_sect): Make "b" const.
6295         (find_block_in_blockvector): Make "b" const.
6296
6297 2019-03-23  Tom Tromey  <tom@tromey.com>
6298
6299         * varobj.c (varobj_create): Update.
6300         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6301         * printcmd.c (display_command, do_one_display): Don't reset
6302         innermost_block.
6303         * parser-defs.h (enum innermost_block_tracker_type): Move to
6304         expression.h.
6305         (innermost_block): Update comment.
6306         * parse.c (parse_exp_1): Add tracker_types parameter.
6307         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6308         tracker_types parameter.  Reset innermost_block.
6309         (parse_exp_in_context): Remove.
6310         (parse_expression_for_completion): Update.
6311         * objfiles.c (~objfile): Don't reset expression_context_block or
6312         innermost_block.
6313         * expression.h (enum innermost_block_tracker_type): Move from
6314         parser-defs.h.
6315         (parse_exp_1): Add tracker_types parameter.
6316         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6317         reset innermost_block.
6318
6319 2019-03-23  Tom Tromey  <tom@tromey.com>
6320
6321         * objfiles.h: Include bcache.h.
6322
6323 2019-03-23  Tom Tromey  <tom@tromey.com>
6324
6325         * linespec.c (get_current_search_block): Use
6326         scoped_restore_current_language.
6327         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6328
6329 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6330             Jiong Wang  <jiong.wang@arm.com>
6331
6332         * aarch64-linux-tdep.c
6333         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6334         section.
6335         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6336
6337 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6338             Jiong Wang  <jiong.wang@arm.com>
6339
6340         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6341         instructions.
6342         (aarch64_analyze_prologue_test): Add PACIASP test.
6343         (aarch64_prologue_prev_register): Unmask PC value.
6344
6345 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6346             Jiong Wang  <jiong.wang@arm.com>
6347
6348         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6349         (aarch64_dwarf2_prev_register): Unmask PC value.
6350         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6351         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6352         DW_CFA_AARCH64_negate_ra_state.
6353         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6354
6355 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6356             Jiong Wang  <jiong.wang@arm.com>
6357
6358         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6359         registers.
6360         (aarch64_pseudo_register_name): Likewise.
6361         (aarch64_pseudo_register_type): Likewise.
6362         (aarch64_pseudo_register_reggroup_p): Likewise.
6363         (aarch64_gdbarch_init): Add pauth registers.
6364         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6365         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6366         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6367         (struct gdbarch_tdep): Add regnum for ra_state.
6368
6369 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6370             Jiong Wang  <jiong.wang@arm.com>
6371
6372         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6373
6374 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6375             Jiong Wang  <jiong.wang@arm.com>
6376
6377         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6378         function.
6379         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6380         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6381         (aarch64_gdbarch_init): Add puth registers.
6382         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6383         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6384         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6385
6386 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6387             Jiong Wang  <jiong.wang@arm.com>
6388
6389         * aarch64-linux-nat.c
6390         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6391         * aarch64-linux-tdep.c
6392         (aarch64_linux_core_read_description): Likewise.
6393         (aarch64_linux_get_hwcap): New function.
6394         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6395         (aarch64_linux_get_hwcap): New declaration.
6396
6397 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6398             Jiong Wang  <jiong.wang@arm.com>
6399
6400         * aarch64-linux-nat.c
6401         (aarch64_linux_nat_target::read_description): Add pauth param.
6402         * aarch64-linux-tdep.c
6403         (aarch64_linux_core_read_description): Likewise.
6404         * aarch64-tdep.c (struct target_desc): Add in pauth.
6405         (aarch64_read_description): Add pauth param.
6406         (aarch64_gdbarch_init): Likewise.
6407         * aarch64-tdep.h (aarch64_read_description): Likewise.
6408         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6409         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6410         * features/Makefile: Add new files.
6411         * features/aarch64-pauth.c: New file.
6412         * features/aarch64-pauth.xml: New file.
6413
6414 2019-03-20  Tom Tromey  <tromey@adacore.com>
6415
6416         * infrun.c (handle_inferior_event): Rename from
6417         handle_inferior_event_1.  Create a scoped_value_mark.
6418         (handle_inferior_event): Remove.
6419
6420 2019-03-19  Tom Tromey  <tromey@adacore.com>
6421
6422         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6423         * infrun.h (print_stop_event): Add "displays" parameter.
6424         * infrun.c (print_stop_event): Add "displays" parameter.
6425
6426 2019-03-19  Pedro Alves  <palves@redhat.com>
6427
6428         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6429         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6430         to -1.  Fix TABs vs spaces.
6431         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6432         * tui/tui-out.h (tui_ui_out) Add intro comments.
6433         <m_line, m_start_of_line>: In-class initialize, and add describing
6434         comment.
6435
6436 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6437
6438         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6439         variable names.
6440         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6441
6442 2019-03-18  Pedro Alves  <palves@redhat.com>
6443             Eli Zaretskii <eliz@gnu.org>
6444
6445         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6446         m_line and m_start_of_line.
6447
6448 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6449
6450         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6451         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6452         it returns a newline.  This fixes a regression in TU mode, whereby
6453         the next line is output on the same screen line as the user input.
6454
6455 2019-03-18  Tom Tromey  <tromey@adacore.com>
6456
6457         * minsyms.c (minimal_symbol_reader::install): Remove call to
6458         obstack_blank.
6459
6460 2019-03-18  Pedro Alves  <palves@redhat.com>
6461
6462         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6463         New globals.
6464         (apply_style): New, factored out from ...
6465         (apply_ansi_escape): ... this.  Handle reverse video mode.
6466         (tui_set_reverse_mode): New function.
6467         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6468         * tui/tui-winsource.c (tui_show_source_line): Use
6469         tui_set_reverse_mode instead of setting A_STANDOUT.
6470         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6471         New setter methods.
6472
6473 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6474
6475         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6476         Handle tabs.
6477
6478 2019-03-18  Tom Tromey  <tromey@adacore.com>
6479
6480         * ada-lang.c (empty_array): Add "high" parameter.
6481         (ada_evaluate_subexp): Update.
6482
6483 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6484
6485         * unittests/string_view-selftests.c: Define
6486         _initialize_string_view_selftests unconditionally.
6487
6488 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6489
6490         PR gdb/24350
6491         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6492
6493 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6494
6495         PR gdb/24351
6496         * windows-nat.c (display_selector): Fix format specifiers.
6497
6498 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6499
6500         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6501         tui_refill_source_window instead of tui_refresh_win, to update the
6502         current execution line.  This fixes redisplay of the current line
6503         when stepping through the code with "next" or "step".
6504
6505 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6506
6507         * source-cache.c (source_cache::get_source_lines): Call
6508         find_source_lines to initialize s->nlines.  This fixes vertical
6509         scrolling of TUI source window when the DOWN arrow is pressed.
6510
6511 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6512
6513         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6514         linux-thread-db.c (_initialize_thread_db): Likewise.
6515
6516 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6517
6518         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6519         wclrtoeol in tui_show_source_line".  This reverts changes made in
6520         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6521
6522 2019-03-15  Tom Tromey  <tom@tromey.com>
6523
6524         * symtab.h (struct minimal_symbol): Derive from
6525         general_symbol_info.
6526         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6527         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6528         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6529         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6530         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6531         (MSYMBOL_SEARCH_NAME): Update.
6532         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6533         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6534         * minsyms.c (minimal_symbol_reader::record_full): Update.
6535
6536 2019-03-15  Tom Tromey  <tom@tromey.com>
6537
6538         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6539
6540 2019-03-15  Tom Tromey  <tom@tromey.com>
6541
6542         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6543         unique_xmalloc_ptr.
6544         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6545         Update.
6546         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6547         (build_minimal_symbol_hash_tables)
6548         (minimal_symbol_reader::install): Update.
6549
6550 2019-03-15  Tom Tromey  <tom@tromey.com>
6551
6552         * symtab.c (create_demangled_names_hash): Update.
6553         (symbol_set_names): Update.
6554         * objfiles.h (struct objfile_per_bfd_storage)
6555         <demangled_names_hash>: Now an htab_up.
6556         * objfiles.c (objfile_per_bfd_storage): Simplify.
6557
6558 2019-03-15  Tom Tromey  <tom@tromey.com>
6559
6560         * objfiles.h (struct objfile_per_bfd_storage): Declare
6561         destructor.
6562         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6563         New.
6564         (get_objfile_bfd_data): Use new.  Don't initialize
6565         language_of_main.
6566         (free_objfile_per_bfd_storage): Remove.
6567         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6568
6569 2019-03-15  Tom Tromey  <tom@tromey.com>
6570
6571         * symfile.c (reread_symbols): Update.
6572         * objfiles.c (objfile::objfile): Update.
6573         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6574         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6575         comment.
6576         (minimal_symbol_reader::install): Update.
6577         (terminate_minimal_symbol_table): Remove.
6578         * jit.c (jit_object_close_impl): Update.
6579
6580 2019-03-15  Tom Tromey  <tom@tromey.com>
6581
6582         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6583         initializations.
6584
6585 2019-03-15  Tom Tromey  <tom@tromey.com>
6586
6587         * objfiles.h (struct objfile_per_bfd_storage)
6588         <demangled_hash_languages>: Now a bitset.
6589         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6590         (lookup_minimal_symbol): Update.
6591
6592 2019-03-15  Tom Tromey  <tom@tromey.com>
6593
6594         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6595         Don't return the symbol.
6596         * coffread.c (record_minimal_symbol): Use record_full.
6597
6598 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6599
6600         The MS-Windows port of ncurses fails to switch to a color pair if
6601         one or both of the colors are the implicit default colors.  This
6602         change records the default colors when TUI is initialized, and
6603         then specifies them explicitly when a color pair uses the default
6604         colors.  This allows color styling in TUI mode on MS-Windows.
6605
6606         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6607         ncurses_norm_attr.
6608         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6609         colors in ncurses_norm_attr.
6610         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6611         "none", replace it with the default color recorded in
6612         ncurses_norm_attr.
6613
6614 2019-03-14  Tom Tromey  <tromey@adacore.com>
6615
6616         * source-cache.h (class source_cache) <get_source_lines>: Return
6617         std::string.
6618         * source-cache.c (source_cache::extract_lines): Handle case where
6619         first_pos==npos.  Return std::string.
6620         (source_cache::get_source_lines): Update.
6621
6622 2019-03-14  Tom Tromey  <tromey@adacore.com>
6623
6624         * NEWS: Add item for "style sources" commands.
6625         * source-cache.c (source_cache::get_source_lines): Check
6626         source_styling.
6627         * cli/cli-style.c (source_styling): New global.
6628         (_initialize_cli_style): Add "style sources" commands.
6629         (show_style_sources): New function.
6630         * cli/cli-style.h (source_styling): Declare.
6631
6632 2019-03-14  Pedro Alves  <palves@redhat.com>
6633             Tom Tromey  <tromey@adacore.com>
6634
6635         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6636         * tui/tui-winsource.c (tui_refill_source_window): New function,
6637         from...
6638         (tui_horizontal_source_scroll): ... here.  Move some logic.
6639         * cli/cli-style.c (set_style_enabled): Notify new observable.
6640         * tui/tui-hooks.c (tui_redisplay_source): New function.
6641         (tui_attach_detach_observers): Attach or detach
6642         tui_redisplay_source.
6643         * observable.h (source_styling_changed): New observable.
6644         * observable.c: Define source_styling_changed observable.
6645
6646 2019-03-13  Tom Tromey  <tromey@adacore.com>
6647
6648         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6649         (i386_gnu_nat_target::store_registers): Update.
6650         * target-debug.h (target_debug_print_std_string): New macro.
6651         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6652         * windows-tdep.c (display_one_tib): Update.
6653         * tui/tui-stack.c (tui_make_status_line): Update.
6654         * top.c (print_inferior_quit_action): Update.
6655         * thread.c (thr_try_catch_cmd): Update.
6656         (add_thread_with_info): Update.
6657         (thread_target_id_str): Update.
6658         (thr_try_catch_cmd): Update.
6659         (thread_command): Update.
6660         (thread_find_command): Update.
6661         * record-btrace.c (record_btrace_target::info_record)
6662         (record_btrace_resume_thread, record_btrace_target::resume)
6663         (record_btrace_cancel_resume, record_btrace_step_thread)
6664         (record_btrace_target::wait, record_btrace_target::wait)
6665         (record_btrace_target::wait, record_btrace_target::stop): Update.
6666         * progspace.c (print_program_space): Update.
6667         * process-stratum-target.c
6668         (process_stratum_target::thread_address_space): Update.
6669         * linux-fork.c (linux_fork_mourn_inferior)
6670         (detach_checkpoint_command, info_checkpoints_command)
6671         (linux_fork_context): Update.
6672         (linux_fork_detach): Update.
6673         (class scoped_switch_fork_info): Update.
6674         (delete_checkpoint_command): Update.
6675         * infrun.c (follow_fork_inferior): Update.
6676         (follow_fork_inferior): Update.
6677         (proceed_after_vfork_done): Update.
6678         (handle_vfork_child_exec_or_exit): Update.
6679         (follow_exec): Update.
6680         (displaced_step_prepare_throw): Update.
6681         (displaced_step_restore): Update.
6682         (start_step_over): Update.
6683         (resume_1): Update.
6684         (clear_proceed_status_thread): Update.
6685         (proceed): Update.
6686         (print_target_wait_results): Update.
6687         (do_target_wait): Update.
6688         (context_switch): Update.
6689         (stop_all_threads): Update.
6690         (restart_threads): Update.
6691         (finish_step_over): Update.
6692         (handle_signal_stop): Update.
6693         (switch_back_to_stepped_thread): Update.
6694         (keep_going_pass_signal): Update.
6695         (print_exited_reason): Update.
6696         (normal_stop): Update.
6697         * inferior.c (inferior_pid_to_str): Change return type.
6698         (print_selected_inferior): Update.
6699         (add_inferior): Update.
6700         (detach_inferior): Update.
6701         * dummy-frame.c (fprint_dummy_frames): Update.
6702         * dcache.c (dcache_info_1): Update.
6703         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6704         (btrace_fetch, btrace_clear): Update.
6705         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6706         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6707         type.
6708         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6709         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6710         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6711         * gdbarch.c, gdbarch.h: Rebuild.
6712         * gdbarch.sh (core_pid_to_str): Change return type.
6713         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6714         return type.
6715         (windows_nat_target::pid_to_str): Change return type.
6716         (windows_delete_thread): Update.
6717         (windows_nat_target::attach): Update.
6718         (windows_nat_target::files_info): Update.
6719         * target-delegates.c: Rebuild.
6720         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6721         return type.
6722         (sol_thread_target::pid_to_str): Change return type.
6723         * remote.c (class remote_target) <pid_to_str>: Change return
6724         type.
6725         (remote_target::pid_to_str): Change return type.
6726         (extended_remote_target::attach, remote_target::remote_stop_ns)
6727         (remote_target::remote_notif_remove_queued_reply)
6728         (remote_target::push_stop_reply, remote_target::disable_btrace):
6729         Update.
6730         (extended_remote_target::attach): Update.
6731         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6732         type.
6733         (gdbsim_target::pid_to_str): Change return type.
6734         * ravenscar-thread.c (struct ravenscar_thread_target)
6735         <pid_to_str>: Change return type.
6736         (ravenscar_thread_target::pid_to_str): Change return type.
6737         * procfs.c (class procfs_target) <pid_to_str>: Change return
6738         type.
6739         (procfs_target::pid_to_str): Change return type.
6740         (procfs_target::attach): Update.
6741         (procfs_target::detach): Update.
6742         (procfs_target::fetch_registers): Update.
6743         (procfs_target::store_registers): Update.
6744         (procfs_target::wait): Update.
6745         (procfs_target::files_info): Update.
6746         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6747         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6748         return type.
6749         (nto_procfs_target::pid_to_str): Change return type.
6750         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6751         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6752         return type.
6753         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6754         (exit_lwp): Update.
6755         (attach_proc_task_lwp_callback, get_detach_signal)
6756         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6757         (linux_nat_target::resume, wait_lwp, stop_callback)
6758         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6759         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6760         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6761         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6762         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6763         type.
6764         (inf_ptrace_target::attach): Update.
6765         (inf_ptrace_target::files_info): Update.
6766         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6767         type.
6768         (go32_nat_target::pid_to_str): Change return type.
6769         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6770         (gnu_nat_target::wait): Update.
6771         (gnu_nat_target::wait): Update.
6772         (gnu_nat_target::resume): Update.
6773         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6774         (fbsd_nat_target::wait): Update.
6775         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6776         type.
6777         (darwin_nat_target::attach): Update.
6778         * corelow.c (class core_target) <pid_to_str>: Change return type.
6779         (core_target::pid_to_str): Change return type.
6780         * target.c (normal_pid_to_str): Change return type.
6781         (default_pid_to_str): Likewise.
6782         (target_pid_to_str): Change return type.
6783         (target_translate_tls_address): Update.
6784         (target_announce_detach): Update.
6785         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6786         return type.
6787         (bsd_uthread_target::pid_to_str): Change return type.
6788         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6789         type.
6790         (bsd_kvm_target::pid_to_str): Change return type.
6791         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6792         return type.
6793         (aix_thread_target::pid_to_str): Change return type.
6794         * target.h (struct target_ops) <pid_to_str>: Change return type.
6795         (target_pid_to_str, normal_pid_to_str): Likewise.
6796         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6797         type.
6798         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6799         type.
6800         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6801         return type.
6802         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6803         type.
6804         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6805         type.
6806         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6807         return type.
6808
6809 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6810
6811         * NEWS: Mention that the new default MI version is 3.  Mention
6812         changes to the output of commands and events that deal with
6813         multi-location breakpoints.
6814         * breakpoint.c: Include "mi/mi-out.h".
6815         (print_one_breakpoint): Change output syntax if using MI version
6816         >= 3.
6817         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6818         New.
6819         (mi_multi_location_breakpoint_output_fixed): New.
6820         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6821         (mi_cmd_fix_multi_location_breakpoint_output): New.
6822         (mi_multi_location_breakpoint_output_fixed): New.
6823         * mi/mi-cmds.c (mi_cmds): Register command
6824         -fix-multi-location-breakpoint-output.
6825         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6826         interpreter "mi".
6827
6828 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6829
6830         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6831         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6832         instantiate mi_ui_out based on interpreter name.
6833         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6834         * mi/mi-main.c (mi_load_progress): Likewise.
6835
6836 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6837
6838         * NEWS: Combine separate "New targets" sections for 8.3.
6839
6840 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6841
6842         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6843         (ppcfbsd_init_abi): Install gdbarch
6844         "fetch_tls_load_module_address" and "get_thread_local_address"
6845         methods.
6846
6847 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6848
6849         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6850         (riscv_fbsd_init_abi): Install gdbarch
6851         "fetch_tls_load_module_address" and "get_thread_local_address"
6852         methods.
6853
6854 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6855
6856         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6857         (i386fbsd_init_abi): Install gdbarch
6858         "fetch_tls_load_module_address" and "get_thread_local_address"
6859         methods.
6860
6861 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6862
6863         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6864         (amd64fbsd_init_abi): Install gdbarch
6865         "fetch_tls_load_module_address" and "get_thread_local_address"
6866         methods.
6867
6868 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6869
6870         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6871         (struct fbsd_pspace_data): New type.
6872         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6873         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6874         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6875         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6876         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6877
6878 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6879
6880         * gdbtypes.c (lookup_struct_elt): New function.
6881         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6882         * gdbtypes.h (struct struct_elt): New type.
6883         (lookup_struct_elt): New prototype.
6884
6885 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6886
6887         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6888         remove disabled code block.
6889
6890 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6891
6892         * gdbarch.sh (get_thread_local_address): New method.
6893         * gdbarch.h, gdbarch.c: Regenerate.
6894         * target.c (target_translate_tls_address): Use
6895         gdbarch_get_thread_local_address if present instead of
6896         target::get_thread_local_address.
6897
6898 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6899
6900         * target.h (target::get_thread_local_address): Update comment.
6901
6902 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6903
6904         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6905         objfile->separate_debug_objfile_backlink if not NULL.
6906
6907 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6908
6909         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6910         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6911         (amd64bsd_store_inferior_registers): Likewise.
6912         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6913         Enable segment base registers.
6914         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6915         PT_GETFSBASE and PT_GETGSBASE.
6916         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6917         PT_SETGSBASE.
6918         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6919         segment base registers.
6920         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6921
6922 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6923
6924         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6925         Update calls to i386_target_description to add 'segments'
6926         parameter.
6927         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6928         add segment base registers.
6929         * arch/i386.c (i386_create_target_description): Add 'segments'
6930         parameter to enable segment base registers.
6931         * arch/i386.h (i386_create_target_description): Likewise.
6932         * features/i386/32bit-segments.xml: New file.
6933         * features/i386/32bit-segments.c: Generate.
6934         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6935         call to i386_target_description to add 'segments' parameter.
6936         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6937         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6938         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6939         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6940         if feature is present.
6941         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6942         Add 'segments' parameter to call to i386_target_description.
6943         (i386_target_description): Add 'segments' parameter to enable
6944         segment base registers.
6945         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6946         to call to i386_target_description.
6947         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6948         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6949         Define I386_NUM_REGS.
6950         (i386_target_description): Add 'segments' parameter to enable
6951         segment base registers.
6952
6953 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6954
6955         PR/24325
6956         * source-cache.c: #undef open and close, to avoid unresolved
6957         externals during linking.
6958
6959 2019-03-12  Tom Tromey  <tromey@adacore.com>
6960
6961         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6962         const.  Add initializers.
6963         (_initialize_remote): Don't initialize ptid globals.
6964
6965 2019-03-12  Pedro Alves  <palves@redhat.com>
6966
6967         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6968
6969 2019-03-12  Pedro Alves  <palves@redhat.com>
6970
6971         * cp-name-parser.y (main): Remove unused 'len' variable.
6972
6973 2019-03-12  Tom Tromey  <tromey@adacore.com>
6974
6975         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6976         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6977
6978 2019-03-12  Tom Tromey  <tromey@adacore.com>
6979
6980         * linux-nat.c (iterate_over_lwps): Update.
6981         (stop_callback): Remove parameter.
6982         (stop_wait_callback, detach_callback, resume_set_callback)
6983         (select_singlestep_lwp_callback, set_ignore_sigint)
6984         (status_callback, resumed_callback, resume_clear_callback)
6985         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6986         data parameter.
6987         (linux_nat_target::detach, linux_nat_target::resume)
6988         (linux_stop_and_wait_all_lwps, select_event_lwp)
6989         (linux_nat_filter_event, linux_nat_wait_1)
6990         (linux_nat_target::kill, linux_nat_target::stop)
6991         (linux_nat_target::stop): Update.
6992         (linux_nat_resume_callback): Change type.
6993         (resume_stopped_resumed_lwps, count_events_callback)
6994         (select_event_lwp_callback): Likewise.
6995         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6996         * arm-linux-nat.c (struct update_registers_data): Remove.
6997         (update_registers_callback): Change type.
6998         (arm_linux_insert_hw_breakpoint1): Update.
6999         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7000         parameter.
7001         (x86_linux_dr_set_addr): Update.
7002         (x86_linux_dr_set_control): Update.
7003         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7004         (iterate_over_lwps): Use gdb::function_view.
7005         * nat/aarch64-linux-hw-point.c (struct
7006         aarch64_dr_update_callback_param): Remove.
7007         (debug_reg_change_callback): Change type.
7008         (aarch64_notify_debug_reg_change): Update.
7009         * s390-linux-nat.c (s390_refresh_per_info): Update.
7010
7011 2019-03-11  Tom Tromey  <tromey@adacore.com>
7012
7013         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7014         redundant assignment to "this_cu".
7015
7016 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7017
7018         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7019
7020 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7021
7022         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7023         from...
7024         (rank_one_type): ... this.
7025
7026 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7027
7028         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7029         from...
7030         (rank_one_type): ... this.
7031
7032 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7033
7034         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7035         from...
7036         (rank_one_type): ... this.
7037
7038 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7039
7040         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7041         from...
7042         (rank_one_type): ... this.
7043
7044 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7045
7046         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7047         from...
7048         (rank_one_type): ... this.
7049
7050 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7051
7052         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7053         from...
7054         (rank_one_type): ... this.
7055
7056 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7057
7058         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7059         from...
7060         (rank_one_type): ... this.
7061
7062 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7063
7064         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7065         from...
7066         (rank_one_type): ... this.
7067
7068 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7069
7070         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7071         from...
7072         (rank_one_type): ... this.
7073
7074 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7075
7076         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7077         from...
7078         (rank_one_type): ... this.
7079
7080 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7081
7082         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7083         from...
7084         (rank_one_type): ... this.
7085
7086 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7087
7088         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7089         from...
7090         (rank_one_type): ... this.
7091
7092 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7093
7094         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7095         inferior-events' shows the example events.
7096
7097 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7098
7099         Support styling on native MS-Windows console
7100
7101         PR/24315
7102         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7103         on MS-Windows if $TERM is not defined.
7104
7105         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7106
7107         * posix-hdep.c (gdb_console_fputs):
7108         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7109         functions.
7110         * ui-file.h (gdb_console_fputs): Add prototype.
7111
7112         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7113         back to fputs only if the former returns zero.
7114
7115 2019-03-07  Tom Tromey  <tom@tromey.com>
7116
7117         * symmisc.c (print_symbol_bcache_statistics): Update.
7118         (print_objfile_statistics): Update.
7119         * symfile.c (allocate_symtab): Update.
7120         * stabsread.c: Don't include bcache.h.
7121         * psymtab.h (struct psymbol_bcache): Don't declare.
7122         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7123         (psymbol_bcache_init, psymbol_bcache_free)
7124         (psymbol_bcache_get_bcache): Don't declare.
7125         * psymtab.c (struct psymbol_bcache): Remove.
7126         (psymtab_storage::psymtab_storage): Update.
7127         (psymtab_storage::~psymtab_storage): Update.
7128         (psymbol_bcache_init, psymbol_bcache_free)
7129         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7130         (add_psymbol_to_bcache): Update.
7131         (allocate_psymtab): Update.
7132         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7133         macro_cache>: No longer pointers.
7134         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7135         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7136         * macrotab.c (macro_bcache): Update.
7137         * macroexp.c: Don't include bcache.h.
7138         * gdbtypes.c (check_types_worklist): Update.
7139         (types_deeply_equal): Remove TRY/CATCH.  Update.
7140         * elfread.c (elf_symtab_read): Update.
7141         * dwarf2read.c: Don't include bcache.h.
7142         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7143         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7144         (print_bcache_statistics, bcache_memory_used): Don't declare.
7145         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7146         methods.  Rename all data members.
7147         * bcache.c (struct bcache): Move to bcache.h.
7148         (bcache::expand_hash_table): Rename from expand_hash_table.
7149         (bcache): Remove.
7150         (bcache::insert): Rename from bcache_full.
7151         (bcache::compare): Rename from bcache_compare.
7152         (bcache_xmalloc): Remove.
7153         (bcache::~bcache): Rename from bcache_xfree.
7154         (bcache::print_statistics): Rename from print_bcache_statistics.
7155         (bcache::memory_used): Rename from bcache_memory_used.
7156
7157 2019-03-07  Pedro Alves  <palves@redhat.com>
7158
7159         * infrun.c (normal_stop): Also check for
7160         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7161
7162 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7163
7164         * f-lang.c (value_from_host_double): Moved to...
7165         * value.c (value_from_host_double): ...here.
7166         * value.h (value_from_host_double): Declare.
7167         * guile/scm-math.c (vlscm_convert_typed_number): Use
7168         value_from_host_double.
7169         (vlscm_convert_number): Likewise.
7170         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7171         * python/py-value.c (convert_value_from_python): Likewise.
7172
7173 2019-03-06  Tom Tromey  <tom@tromey.com>
7174
7175         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7176
7177 2019-03-06  Tom Tromey  <tom@tromey.com>
7178
7179         * utils.h (free_current_contents): Don't declare.
7180         * utils.c (free_current_contents): Remove.
7181
7182 2019-03-06  Tom Tromey  <tom@tromey.com>
7183
7184         * top.c (quit_force): Update.
7185         * main.c (captured_command_loop): Update.
7186         * common/new-op.c (operator new): Update.
7187         * common/common-exceptions.c (struct catcher)
7188         <save_cleanup_chain>: Remove member.
7189         (exceptions_state_mc_init): Update.
7190         (exception_try_scope_entry): Return nullptr.
7191         (exception_try_scope_exit, exception_rethrow)
7192         (throw_exception_sjlj, throw_exception_cxx): Update.
7193         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7194         (all_cleanups, do_cleanups, discard_cleanups)
7195         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7196         (restore_cleanups, restore_final_cleanups): Don't declare.
7197         (do_final_cleanups): Remove parameter.
7198         * common/cleanups.c (cleanup_chain, make_cleanup)
7199         (make_cleanup_dtor, all_cleanups, do_cleanups)
7200         (discard_my_cleanups, discard_cleanups)
7201         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7202         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7203         (null_cleanup): Remove.
7204         (do_final_cleanups): Remove parameter.
7205
7206 2019-03-06  Tom Tromey  <tom@tromey.com>
7207
7208         * remote.c (remote_target::remote_parse_stop_reply): Use
7209         unique_xmalloc_ptr.
7210
7211 2019-03-06  Tom Tromey  <tom@tromey.com>
7212
7213         * stabsread.c (struct stabs_field_info): Rename from field_info.
7214         <list, fnlist>: Add initializers.
7215         <obstack>: New member.
7216         (read_member_functions, read_struct_fields, read_baseclasses):
7217         Allocate on obstack.  Don't use cleanups.
7218         (read_one_struct_field, read_member_functions, read_struct_fields)
7219         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7220         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7221         (read_struct_type): Update.
7222
7223 2019-03-06  Tom Tromey  <tom@tromey.com>
7224
7225         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7226         * common/filestuff.h (make_cleanup_close): Don't declare.
7227         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7228         Remove.
7229
7230 2019-03-06  Tom Tromey  <tom@tromey.com>
7231
7232         * solib-aix.c: Use make_scope_exit.
7233
7234 2019-03-06  Tom Tromey  <tom@tromey.com>
7235
7236         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7237         Use make_scope_exit.
7238
7239 2019-03-06  Tom Tromey  <tom@tromey.com>
7240
7241         * solib-svr4.c (disable_probes_interface): Remove parameter.
7242         (svr4_handle_solib_event): Use make_scope_exit.
7243
7244 2019-03-06  Tom Tromey  <tom@tromey.com>
7245
7246         * remote.c (struct stop_reply_deleter): Remove.
7247         (stop_reply_up): Update.
7248         (struct stop_reply): Derive from notif_event.  Don't typedef.
7249         <regcache>: Now a std::vector.
7250         (stop_reply_xfree): Remove.
7251         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7252         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7253         (remote_target::discard_pending_stop_replies): Use delete.
7254         (remote_target::remote_parse_stop_reply): Update.
7255         (remote_target::process_stop_reply): Update.
7256         * remote-notif.h (struct notif_event): Add virtual destructor.
7257         Remove "dtr" member.
7258         (struct notif_client) <alloc_event>: Return a unique_ptr.
7259         (notif_event_xfree): Don't declare.
7260         (notif_event_up): New typedef.
7261         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7262         (notif_event_xfree, do_notif_event_xfree): Remove.
7263         (remote_notif_state_xfree): Update.
7264
7265 2019-03-06  Tom Tromey  <tom@tromey.com>
7266
7267         * infrun.c (displaced_step_clear_cleanup): Now a
7268         forward_scope_exit type.
7269         (displaced_step_prepare_throw): Update.
7270         (displaced_step_fixup): Update.
7271
7272 2019-03-06  Tom Tromey  <tom@tromey.com>
7273
7274         * inferior.h (class inferior): Update comment.
7275         * gdbthread.h (class thread_info): Update comment.
7276
7277 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7278             Tom Tromey  <tom@tromey.com>
7279
7280         * stabsread.h (struct stab_section_list): Remove.
7281         (coffstab_build_psymtabs): Update.
7282         * dbxread.c (symbuf_sections): Now a std::vector.
7283         (sect_idx): New global.
7284         (fill_symbuf): Update.
7285         (coffstab_build_psymtabs): Change type of stabsects parameter.
7286         Update.
7287         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7288         std::vector.
7289         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7290         (coff_locate_sections): Update.
7291         (coff_symfile_read): Remove cleanups.  Update.
7292         (init_stringtab): Add storage parameter.
7293         (free_stringtab, free_stringtab_cleanup): Remove.
7294         (init_lineno): Add storage parameter.
7295         (free_linetab, free_linetab_cleanup): Remove.
7296
7297 2019-03-06  Pedro Alves  <palves@redhat.com>
7298
7299         * linux-fork.c (fork_info::clobber_regs): Delete.
7300         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7301         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7302         comment.  Adjust.
7303         (scoped_switch_fork_info::scoped_switch_fork_info)
7304         (checkpoint_command, linux_fork_context): Adjust
7305         fork_save_infrun_state calls.
7306
7307 2019-03-06  Pedro Alves  <palves@redhat.com>
7308
7309         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7310         (inf_has_multiple_threads): Return 'bool' and rewrite using
7311         inferior_info::threads().
7312
7313 2019-03-06  Pedro Alves  <palves@redhat.com>
7314
7315         * linux-fork.c: Include <list>.
7316         (fork_list): Now a std::list instance.
7317         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7318         (forks_exist_p, find_last_fork): Adjust.
7319         (new_fork): Delete.
7320         (one_fork_p): New.
7321         (add_fork): Adjust.
7322         (free_fork): Delete, folded into fork_info::~fork_info().
7323         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7324         Adjust.
7325         (init_fork_list): Delete.
7326         (linux_fork_killall, linux_fork_mourn_inferior)
7327         (linux_fork_detach, info_checkpoints_command): Adjust.
7328         (_initialize_linux_fork): No longer call init_fork_list.
7329
7330 2019-03-06  Pedro Alves  <palves@redhat.com>
7331
7332         * linux-fork.c (new_fork): New, split out of ...
7333         (add_fork): ... this.  Return void.  Move "first fork" special
7334         case from here, to ...
7335         (checkpoint_command): ... here.
7336         * linux-linux.h (add_fork): Return void.
7337
7338 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7339
7340         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7341
7342 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7343             Chris January  <chris.january@arm.com>
7344             David Lecomber  <david.lecomber@arm.com>
7345
7346         * f-exp.y: New token, UNOP_INTRINSIC.
7347         (exp): New pattern using UNOP_INTRINSIC token.
7348         (f77_keywords): Add 'abs' keyword.
7349         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7350         (value_from_host_double): New function.
7351         (evaluate_subexp_f): Support UNOP_ABS.
7352
7353 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7354
7355         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7356         types.
7357
7358 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7359
7360         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7361         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7362         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7363
7364 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7365
7366         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7367
7368 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7369             Chris January  <chris.january@arm.com>
7370
7371         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7372         * f-exp.y: Define 'KIND' token.
7373         (exp): New pattern for KIND expressions.
7374         (ptype): Handle types with a kind extension.
7375         (direct_abs_decl): Extend to spot kind extensions.
7376         (f77_keywords): Add 'kind' to the list.
7377         (push_kind_type): New function.
7378         (convert_to_kind_type): New function.
7379         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7380         * parse.c (operator_length_standard): Likewise.
7381         * parser-defs.h (enum type_pieces): Add tp_kind.
7382         * std-operator.def: Add UNOP_KIND.
7383
7384 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7385
7386         * f-exp.y (f_parse): Set yydebug.
7387
7388 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7389
7390         * f-lang.c (evaluate_subexp_f): New function.
7391         (exp_descriptor_f): New global.
7392         (f_language_defn): Use exp_descriptor_f instead of
7393         exp_descriptor_standard.
7394
7395 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7396
7397         * f-exp.y (struct token): Add comments.
7398         (dot_ops): Remove uppercase versions and the end marker.
7399         (f77_keywords): Likewise.
7400         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7401         entries in the dot_ops array are case insensitive, and use
7402         strncasecmp to compare strings.  Also some whitespace cleanup in
7403         this area.  Similar for the f77_keywords array, except entries in
7404         this list might be case sensitive.
7405
7406 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7407
7408         * f-exp.y (struct f77_boolean_val): Add comments.
7409         (boolean_values): Remove uppercase versions, and end marker.
7410         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7411         and use strncasecmp to achieve case insensitivity.  Additionally,
7412         perform whitespace cleanup around this code.
7413
7414 2019-03-06  Tom Tromey  <tromey@adacore.com>
7415
7416         * remote-sim.c (gdbsim_target_open): Use result of
7417         gdb_argv::release.
7418
7419 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7420         Dirk Schubert  <dirk.schubert@arm.com>
7421         Chris January  <chris.january@arm.com>
7422
7423         * eval.c (evaluate_subexp_standard): Call Fortran argument
7424         wrapping logic.
7425         * f-lang.c (struct value): A value which can be passed into a
7426         Fortran function call.
7427         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7428         where appropriate.
7429         (struct type): Value ready for a Fortran function call.
7430         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7431         is needed.
7432         * f-lang.h (fortran_argument_convert): Declaration.
7433         (fortran_preserve_arg_pointer): Declaration.
7434         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7435
7436 2019-03-05  Tom Tromey  <tromey@adacore.com>
7437
7438         * python/py-prettyprint.c (print_string_repr): Remove #if.
7439         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7440
7441 2019-03-05  Tom Tromey  <tromey@adacore.com>
7442
7443         * target.c (the_dummy_target): Move later.  Change type to
7444         "dummy_target".
7445         (initialize_targets): Don't initialize the_dummy_target.
7446
7447 2019-03-05  Tom Tromey  <tromey@adacore.com>
7448
7449         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7450         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7451
7452 2019-03-05  Tom Tromey  <tromey@adacore.com>
7453
7454         * windows-nat.c (windows_nat_target::attach)
7455         (windows_nat_target::detach): Don't call gdb_flush.
7456         * valprint.c (generic_val_print, val_print, val_print_string):
7457         Don't call gdb_flush.
7458         * utils.c (defaulted_query): Don't call gdb_flush.
7459         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7460         * target.c (target_announce_detach): Don't call gdb_flush.
7461         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7462         * remote.c (extended_remote_target::attach): Don't call
7463         gdb_flush.
7464         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7465         * printcmd.c (do_examine): Don't call gdb_flush.
7466         (info_display_command): Don't call gdb_flush.
7467         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7468         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7469         * memattr.c (info_mem_command): Don't call gdb_flush.
7470         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7471         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7472         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7473         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7474         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7475         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7476         (gnu_nat_target::detach): Don't call gdb_flush.
7477         * f-valprint.c (f_val_print): Don't call gdb_flush.
7478         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7479         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7480         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7481         gdb_flush.
7482         * c-valprint.c (c_val_print): Don't call gdb_flush.
7483         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7484
7485 2019-03-05  Tom Tromey  <tromey@adacore.com>
7486
7487         * varobj.c (update_dynamic_varobj_children): Update.
7488         (install_default_visualizer): Use reset, not release.
7489         * value.c (set_internalvar): Update.
7490         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7491         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7492         ATTRIBUTE_UNUSED_RESULT.
7493
7494 2019-03-05  Tom Tromey  <tromey@adacore.com>
7495
7496         * remote.c (class scoped_remote_fd) <release>: Add
7497         ATTRIBUTE_UNUSED_RESULT.
7498
7499 2019-03-05  Tom Tromey  <tromey@adacore.com>
7500
7501         * macroexp.c (struct macro_buffer) <release>: Add
7502         ATTRIBUTE_UNUSED_RESULT.
7503
7504 2019-03-05  Tom Tromey  <tromey@adacore.com>
7505
7506         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7507         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7508         ATTRIBUTE_UNUSED_RESULT.
7509
7510 2019-03-05  Tom Tromey  <tromey@adacore.com>
7511
7512         * common/scoped_fd.h (class scoped_fd) <release>: Add
7513         ATTRIBUTE_UNUSED_RESULT.
7514
7515 2019-03-05  Tom Tromey  <tromey@adacore.com>
7516
7517         * parser-defs.h (struct parser_state) <release>: Add
7518         ATTRIBUTE_UNUSED_RESULT.
7519
7520 2019-03-05  Tom Tromey  <tromey@adacore.com>
7521
7522         * utils.h (class gdb_argv) <release>: Add
7523         ATTRIBUTE_UNUSED_RESULT.
7524         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7525
7526 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7527
7528         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7529         for-loop range, to avoid compiler warnings.
7530
7531         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7532         avoid compiler warnings about unused variables.
7533
7534         * NEWS: Mention end of support for native debugging on MS-Windows
7535         before XP.
7536
7537         PR gdb/24292
7538         * common/netstuff.c:
7539         * gdbserver/gdbreplay.c
7540         * gdbserver/remote-utils.c:
7541         * ser-tcp.c:
7542         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7543         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7544         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7545         'getaddrinfo' and 'freeaddrinfo' were not available before
7546         Windows XP, and mingw.org's MinGW headers by default define
7547         _WIN32_WINNT to 0x500.
7548
7549 2019-03-01  Gary Benson <gbenson@redhat.com>
7550
7551         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7552
7553 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7554             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7555
7556         PR gdb/8527
7557         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7558         set_sigint_trap, clear_sigint_trap.
7559
7560 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7561
7562         * target.c (target_detach): Clear the regcache and the
7563         frame cache.
7564
7565 2019-02-27  Pedro Alves  <palves@redhat.com>
7566
7567         * utils.c (set_screen_size): When we cap the height/width sizes,
7568         tweak the corresponding command variable to show "unlimited":
7569
7570 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7571             Pedro Alves  <palves@redhat.com>
7572
7573         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7574         before calling rl_set_screen_size.
7575
7576 2019-02-27  Tom Tromey  <tromey@adacore.com>
7577
7578         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7579         define.
7580         * python/py-value.c: Remove Python 2.4 workaround.
7581         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7582         workaround.
7583         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7584         Python 2.4 workaround.
7585         * python/python-internal.h: Remove Python 2.4 comment.
7586         (Py_ssize_t): Don't define.
7587         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7588         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7589         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7590         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7591         * python/python.c (do_start_initialization): Remove Python 2.4
7592         workaround.
7593         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7594         (print_children): Remove Python 2.4 workaround.
7595         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7596         workaround.
7597         (CHARBUFFERPROC_NAME): Remove.
7598         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7599         Python 2.4 workaround.
7600
7601 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7602
7603         * NEWS: Note minimum Python version.
7604
7605 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7606
7607         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7608         code from these functions.  Remove corresponding ifdefs.  Use
7609         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7610         Remove gotos and target of gotos.
7611         (infpy_search_memory): Likewise.
7612
7613 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7614
7615         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7616         (hppa_gdbarch_init): Don't register deleted functions with
7617         gdbarch.
7618
7619 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7620
7621         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7622         (h8300_unwind_sp): Delete.
7623         (h8300_dummy_id): Delete.
7624         (h8300_gdbarch_init): Don't register deleted functions with
7625         gdbarch.
7626
7627 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7628
7629         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7630         (ft32_unwind_pc): Delete.
7631         (ft32_unwind_sp): Delete.
7632         (ft32_gdbarch_init): Don't register deleted functions with
7633         gdbarch.
7634
7635 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7636
7637         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7638         (frv_unwind_pc): Delete.
7639         (frv_unwind_sp): Delete.
7640         (frv_gdbarch_init): Don't register deleted functions with
7641         gdbarch.
7642
7643 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7644
7645         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7646         (riscv_unwind_pc): Delete.
7647         (riscv_unwind_sp): Delete.
7648         (riscv_gdbarch_init): Don't register deleted functions with
7649         gdbarch.
7650
7651 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7652
7653         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7654         (csky_unwind_pc): Delete.
7655         (csky_unwind_sp): Delete.
7656         (csky_gdbarch_init): Don't register deleted functions with
7657         gdbarch.
7658
7659 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7660
7661         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7662         (cris_unwind_pc): Delete.
7663         (cris_unwind_sp): Delete.
7664         (cris_gdbarch_init): Don't register deleted functions with
7665         gdbarch.
7666
7667 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7668
7669         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7670         (bfin_unwind_pc): Delete.
7671         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7672
7673 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7674
7675         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7676         (arm_unwind_pc): Delete.
7677         (arm_unwind_sp): Delete.
7678         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7679
7680 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7681
7682         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7683         (arc_unwind_pc): Delete.
7684         (arc_unwind_sp): Delete.
7685         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7686
7687 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7688
7689         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7690         (alpha_unwind_pc): Delete.
7691         (alpha_gdbarch_init): Don't register deleted functions with
7692         gdbarch.
7693
7694 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7695
7696         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7697         (aarch64_unwind_pc): Delete.
7698         (aarch64_unwind_sp): Delete.
7699         (aarch64_gdbarch_init): Don't register deleted functions with
7700         gdbarch.
7701
7702 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7703
7704         * gdbtypes.c (type_align): Don't consider static members when
7705         computing structure alignment.
7706
7707 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7708
7709         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7710         return 0 for other types.
7711         * arch-utils.c (default_type_align): Always return 0.
7712         * gdbarch.h: Regenerate.
7713         * gdbarch.sh (type_align): Extend comment.
7714         * gdbtypes.c (type_align): Add additional comments, always call
7715         gdbarch_type_align before applying the default rules.
7716         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7717         generic code will then apply a suitable default.
7718         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7719         types, return 0 for other types.
7720
7721 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7722
7723         * NEWS: Create a new section for the next release branch.
7724         Rename the section of the current branch, now that it has
7725         been cut.
7726
7727 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7728
7729         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7730         * version.in: Bump version to 8.3.50.DATE-git.
7731
7732 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7733
7734         * aix-thread.c (ptid_cmp): Remove unused variable.
7735         (get_signaled_thread): Likewise.
7736         (store_regs_user_thread): Likewise.
7737         (store_regs_kernel_thread): Likewise.
7738         (fetch_regs_kernel_thread): Remove shadowed variable.
7739
7740 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7741
7742         * features/riscv/32bit-cpu.xml: Add register numbers.
7743         * features/riscv/32bit-fpu.c: Regenerate.
7744         * features/riscv/32bit-fpu.xml: Add register numbers.
7745         * features/riscv/64bit-cpu.xml: Add register numbers.
7746         * features/riscv/64bit-fpu.c: Regenerate.
7747         * features/riscv/64bit-fpu.xml: Add register numbers.
7748
7749 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7750
7751         * NEWS: Mention two argument form of gdb.Value constructor.
7752         * python/py-value.c (convert_buffer_and_type_to_value): New
7753         function.
7754         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7755         Add support for handling an optional second argument.  Call
7756         convert_buffer_and_type_to_value as appropriate.
7757         * python/python-internal.h (Py_buffer_deleter): New struct.
7758         (Py_buffer_up): New typedef.
7759
7760 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7761
7762         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7763         instead of releasing ownership.
7764
7765 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7766
7767         * dwarf2read.c (open_and_init_dwp_file): Call
7768         elf_numsections instead of bfd_count_sections to initialize
7769         dwp_file->num_sections.
7770
7771 2019-02-25  Tom Tromey  <tromey@adacore.com>
7772
7773         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7774
7775 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7776
7777         * gcore.in: Add '--readnever' option when invoking GDB.
7778
7779 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7780
7781         * MAINTAINERS: Update my email address.
7782
7783 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7784
7785         * build-id.c (build_id_to_debug_bfd_1): New function.
7786         (build_id_to_debug_bfd): Look for separate debug file in
7787         sysroot.
7788
7789 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7790
7791         * gdbarch.sh: Update the copyright year range that is placed into
7792         generated files.
7793
7794 2019-02-22  Keith Seitz  <keiths@redhat.com>
7795
7796         PR symtab/23853
7797         * linespec.c (create_sals_line_offset): Search for the default
7798         symtab's filename instead of its fullname.
7799
7800 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7801
7802         * NEWS: Update style defaults.
7803
7804 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7805
7806         * main.c (captured_main_1): Disable styling in batch mode.
7807
7808 2019-02-20  Tom Tromey  <tom@tromey.com>
7809
7810         * symtab.c (symtab_symbol_info): Fix typos.
7811
7812 2019-02-20  Tom Tromey  <tromey@adacore.com>
7813
7814         * findcmd.c (_initialize_mem_search): Use upper case for
7815         metasyntactic variables.
7816
7817 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7818
7819         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7820         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7821
7822 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7823
7824         * top.h (source_file_name): Change to std::string.
7825         * top.c (source_file_name): Likewise.
7826         (command_line_input): Adjust.
7827         * cli/cli-script.c (script_from_file): Adjust.
7828
7829 2019-02-19  Tom Tromey  <tromey@adacore.com>
7830
7831         * ravenscar-thread.c
7832         (ravenscar_thread_target::update_thread_list): Don't call
7833         ada_build_task_list.
7834         * ada-lang.h (ada_build_task_list): Don't declare.
7835         * ada-tasks.c (struct ada_tasks_inferior_data)
7836         <task_list_valid_p>: Now bool.
7837         (read_known_tasks, ada_task_list_changed)
7838         (ada_tasks_invalidate_inferior_data): Update.
7839         (read_known_tasks_array): Return bool.
7840         (read_known_tasks_list): Likewise.
7841         (read_known_tasks): Return void.
7842         (ada_build_task_list): Now static.
7843
7844 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7845
7846         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7847         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7848
7849 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7850
7851         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7852         variant for ada_tasks_pspace_data_handle and
7853         ada_tasks_inferior_data_handle.
7854         (ada_tasks_pspace_data_cleanup): New function.
7855         (ada_tasks_inferior_data_cleanup): New function.
7856
7857 2019-02-17  Tom Tromey  <tom@tromey.com>
7858
7859         * macrotab.h (macro_source_fullname): Return a std::string.
7860         * macrotab.c (macro_include, check_for_redefinition)
7861         (macro_undef, macro_lookup_definition, foreach_macro)
7862         (foreach_macro_in_scope): Update.
7863         (macro_source_fullname): Return a std::string.
7864         * macrocmd.c (show_pp_source_pos): Update.
7865
7866 2019-02-17  Tom Tromey  <tom@tromey.com>
7867
7868         * macrocmd.c (show_pp_source_pos): Style the file names.
7869
7870 2019-02-17  Tom Tromey  <tom@tromey.com>
7871
7872         PR tui/24197:
7873         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7874
7875 2019-02-17  Tom Tromey  <tom@tromey.com>
7876
7877         * ada-lang.c (user_select_syms): Use filtered printing.
7878         * utils.c (wrap_style): New global.
7879         (desired_style): Remove.
7880         (emit_style_escape): Add stream parameter.
7881         (set_output_style, reset_terminal_style, prompt_for_continue):
7882         Update.
7883         (flush_wrap_buffer): Only flush gdb_stdout.
7884         (wrap_here): Set wrap_style.
7885         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7886         treat escape sequences as a character.  Change when wrap buffer is
7887         flushed.
7888         (fputs_styled): Do not set the output style when the default is
7889         requested.
7890         * ui-style.h (struct ui_file_style) <is_default>: New method.
7891         * source.c (print_source_lines_base): Emit escape sequences in one
7892         piece.
7893
7894 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7895
7896         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7897         integers and enumeration types.
7898
7899 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7900
7901         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7902         instead of lookup_symbol_in_language
7903         (do_exact_match): New function.
7904         (ada_get_symbol_name_matcher): Return do_exact_match when
7905         doing a verbatim match.
7906
7907 2019-02-15  Tom Tromey  <tromey@adacore.com>
7908
7909         * ravenscar-thread.c (ravenscar_thread_target::resume)
7910         (ravenscar_thread_target::wait): Special case wildcard requests.
7911
7912 2019-02-15  Tom Tromey  <tromey@adacore.com>
7913
7914         * ravenscar-thread.c (base_ptid): Remove.
7915         (struct ravenscar_thread_target) <close>: New method.
7916         <m_base_ptid>: New member.
7917         <update_inferior_ptid, active_task, task_is_currently_active,
7918         runtime_initialized>: Declare methods.
7919         <ravenscar_thread_target>: Add constructor.
7920         (ravenscar_thread_target::task_is_currently_active)
7921         (ravenscar_thread_target::update_inferior_ptid)
7922         (ravenscar_runtime_initialized): Rename.  Now methods.
7923         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7924         (ravenscar_thread_target::update_thread_list): Update.
7925         (ravenscar_thread_target::active_task): Now method.
7926         (ravenscar_thread_target::store_registers)
7927         (ravenscar_thread_target::prepare_to_store)
7928         (ravenscar_thread_target::prepare_to_store)
7929         (ravenscar_thread_target::mourn_inferior): Update.
7930         (ravenscar_inferior_created): Use "new" to create target.
7931         (ravenscar_thread_target::get_ada_task_ptid): Update.
7932         (_initialize_ravenscar): Don't initialize base_ptid.
7933         (ravenscar_ops): Remove global.
7934
7935 2019-02-15  Tom Tromey  <tromey@adacore.com>
7936
7937         * target.h (push_target): Declare new overload.
7938         * target.c (push_target): New overload, taking an rvalue reference.
7939         * remote.c (remote_target::open_1): Use push_target overload.
7940         * corelow.c (core_target_open): Use push_target overload.
7941
7942 2019-02-15  Tom Tromey  <tromey@adacore.com>
7943
7944         * ravenscar-thread.c (is_ravenscar_task)
7945         (ravenscar_task_is_currently_active): Return bool.
7946         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7947         (_initialize_ravenscar): Remove "(void)".
7948         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7949         Return bool.
7950
7951 2019-02-15  Tom Tromey  <tromey@adacore.com>
7952
7953         * ravenscar-thread.c (ravenscar_runtime_initializer)
7954         (has_ravenscar_runtime, get_running_thread_id)
7955         (ravenscar_thread_target::resume): Fix indentation.
7956
7957 2019-02-15  Tom Tromey  <tromey@adacore.com>
7958
7959         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7960         from ravenscar_arch_ops.
7961         (sparc_ravenscar_ops::fetch_registers)
7962         (sparc_ravenscar_ops::store_registers): Now methods.
7963         (sparc_ravenscar_prepare_to_store): Remove.
7964         (sparc_ravenscar_ops): Redefine.
7965         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7966         methods and destructor.  Remove members.
7967         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7968         (ravenscar_thread_target::store_registers)
7969         (ravenscar_thread_target::prepare_to_store): Update.
7970         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7971         Remove.
7972         (struct ppc_ravenscar_powerpc_ops): Derive from
7973         ravenscar_arch_ops.
7974         (ppc_ravenscar_powerpc_ops::fetch_registers)
7975         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7976         (ppc_ravenscar_powerpc_ops): Redefine.
7977         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7978         (ppc_ravenscar_e500_ops::fetch_registers)
7979         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7980         (ppc_ravenscar_e500_ops): Redefine.
7981         * aarch64-ravenscar-thread.c
7982         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7983         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7984         (aarch64_ravenscar_fetch_registers)
7985         (aarch64_ravenscar_store_registers): Now methods.
7986         (aarch64_ravenscar_ops): Redefine.
7987
7988 2019-02-15  Tom Tromey  <tromey@adacore.com>
7989
7990         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7991         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7992         (ravenscar_thread_target::stopped_by_watchpoint)
7993         (ravenscar_thread_target::stopped_data_address)
7994         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7995
7996 2019-02-15  Tom Tromey  <tromey@adacore.com>
7997
7998         * ravenscar-thread.c: Fix some typos.
7999
8000 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8001             Tom Tromey  <tromey@adacore.com>
8002
8003         * ada-lang.c (ada_exception_sal): Change addr_string to a
8004         std::string.
8005         (create_ada_exception_catchpoint): Update.
8006
8007 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8008             Tom Tromey  <tromey@adacore.com>
8009
8010         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8011         (bp_location_ops): Remove.
8012         (base_breakpoint_allocate_location): Update.
8013         (free_bp_location): Update.
8014         * ada-lang.c (class ada_catchpoint_location)
8015         <ada_catchpoint_location>: Remove ops parameter.
8016         (ada_catchpoint_location_dtor): Remove.
8017         (ada_catchpoint_location_ops): Remove.
8018         (allocate_location_exception): Update.
8019         * breakpoint.h (struct bp_location_ops): Remove.
8020         (class bp_location) <bp_location>: Remove bp_location_ops
8021         parameter.
8022         <~bp_location>: Add destructor.
8023         <ops>: Remove.
8024
8025 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8026             Pedro Alves  <palves@redhat.com>
8027
8028         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8029         'PATH_MAX'.
8030
8031 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8032             Samuel Thibault  <samuel.thibault@gnu.org>
8033             Thomas Schwinge  <thomas@codesourcery.com>
8034
8035         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8036         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8037
8038 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8039
8040         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8041         (check_empty): Use "const char *".
8042
8043         * gnu-nat.c (gnu_nat_target::detach): Instead of
8044         'detach_inferior (pid)' call
8045         'detach_inferior (find_inferior_pid (pid))'.
8046
8047         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8048         'nat/fork-inferior.o'.
8049         * gnu-nat.c: #include "nat/fork-inferior.h".
8050
8051         * gnu-nat.c (gnu_nat_target::detach): Instead of
8052         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8053         * gnu-nat.h: #include "inf-child.h".
8054         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8055         'i386_gnu_nat_target::fetch_registers'.
8056         (gnu_store_registers): Rename/move to
8057         'i386_gnu_nat_target::store_registers'.
8058
8059         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8060         * gnu-nat.h (mach_thread_info): New function.
8061         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8062
8063         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8064
8065 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8066
8067         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8068
8069 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8070
8071         * windows-nat.c (windows_add_thread): Add new parameter
8072         "main_thread_p" with default value set to false.  Update
8073         function documentation as well as all callers.
8074         (windows_delete_thread): Likewise.
8075         (fake_create_process): Update call to windows_add_thread.
8076         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8077         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8078         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8079         call to windows_delete_thread.
8080
8081 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8082
8083         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8084
8085 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8086
8087         * symfile.c (find_separate_debug_file): Use canonical path of
8088         sysroot with child_path instead of gdb_sysroot if it is valid.
8089
8090 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8091
8092         * symfile.c (find_separate_debug_file): Use child_path to
8093         determine if an object file is under a sysroot.
8094
8095 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8096
8097         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8098         unittests/child-path-selftests.c.
8099         * common/pathstuff.c (child_path): New function.
8100         * common/pathstuff.h (child_path): New prototype.
8101         * unittests/child-path-selftests.c: New file.
8102
8103 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8104
8105         * symfile.c (find_separate_debug_file): Look for separate debug
8106         files in debug directories under the sysroot.
8107
8108 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8109
8110         * symtab.h (struct minimal_symbol data_p): New const method.
8111         (struct minimal_symbol text_p): Likewise.
8112         * symtab.c (output_source_filename): Use file name style
8113         to print file name.
8114         (print_symbol_info): Likewise.
8115         (print_msymbol_info): Use address style to print addresses.
8116         Use function name style to print executable text symbols.
8117         (expand_symtab_containing_pc): Use data_p.
8118         (find_pc_sect_compunit_symtab): Likewise.
8119
8120 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8121
8122         * breakpoint.c (describe_other_breakpoints): Use address style
8123         to print addresses.
8124         (say_where): Likewise.
8125
8126 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8127
8128         * ada-typeprint.c (print_func_type): Print function name
8129         style to print function name.
8130         * c-typeprint.c (c_print_type_1): Likewise.
8131
8132 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8133
8134         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8135         for execve.
8136
8137 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8138
8139         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8140         type_stack.
8141
8142 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8143
8144         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8145         TYPE_CODE_REF types.
8146
8147 2019-02-08  Jim Wilson  <jimw@sifive.com>
8148
8149         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8150         (riscv_linux_fregset): New.
8151         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8152
8153 2019-02-07  Tom Tromey  <tom@tromey.com>
8154
8155         * thread.c (thread_cancel_execution_command): Update.
8156         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8157         methods.
8158         (struct thread_fsm_ops): Remove.
8159         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8160         (thread_fsm_should_stop, thread_fsm_return_value)
8161         (thread_fsm_set_finished, thread_fsm_finished_p)
8162         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8163         Don't declare.
8164         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8165         * infrun.c (clear_proceed_status_thread)
8166         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8167         (print_stop_event): Update.
8168         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8169         Add constructor.
8170         (step_command_fsm_ops): Remove.
8171         (new_step_command_fsm): Remove.
8172         (step_1): Update.
8173         (step_command_fsm::should_stop): Rename from
8174         step_command_fsm_should_stop.
8175         (step_command_fsm::clean_up): Rename from
8176         step_command_fsm_clean_up.
8177         (step_command_fsm::do_async_reply_reason): Rename from
8178         step_command_fsm_async_reply_reason.
8179         (struct until_next_fsm): Inherit from thread_fsm.  Add
8180         constructor.
8181         (until_next_fsm_ops): Remove.
8182         (new_until_next_fsm): Remove.
8183         (until_next_fsm::should_stop): Rename from
8184         until_next_fsm_should_stop.
8185         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8186         (until_next_fsm::do_async_reply_reason): Rename from
8187         until_next_fsm_async_reply_reason.
8188         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8189         constructor.  Change type of breakpoint.
8190         (finish_command_fsm_ops): Remove.
8191         (new_finish_command_fsm): Remove.
8192         (finish_command_fsm::should_stop): Rename from
8193         finish_command_fsm_should_stop.
8194         (finish_command_fsm::clean_up): Rename from
8195         finish_command_fsm_clean_up.
8196         (finish_command_fsm::return_value): Rename from
8197         finish_command_fsm_return_value.
8198         (finish_command_fsm::do_async_reply_reason): Rename from
8199         finish_command_fsm_async_reply_reason.
8200         (finish_command): Update.
8201         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8202         Add constructor.
8203         (call_thread_fsm_ops): Remove.
8204         (call_thread_fsm::call_thread_fsm): Rename from
8205         new_call_thread_fsm.
8206         (call_thread_fsm::should_stop): Rename from
8207         call_thread_fsm_should_stop.
8208         (call_thread_fsm::should_notify_stop): Rename from
8209         call_thread_fsm_should_notify_stop.
8210         (run_inferior_call, call_function_by_hand_dummy): Update.
8211         * cli/cli-interp.c (should_print_stop_to_console): Update.
8212         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8213         Add constructor.  Change type of location_breakpoint,
8214         caller_breakpoint.
8215         (until_break_fsm_ops): Remove.
8216         (new_until_break_fsm): Remove.
8217         (until_break_fsm::should_stop): Rename from
8218         until_break_fsm_should_stop.
8219         (until_break_fsm::clean_up): Rename from
8220         until_break_fsm_clean_up.
8221         (until_break_fsm::do_async_reply_reason): Rename from
8222         until_break_fsm_async_reply_reason.
8223         (until_break_command): Update.
8224         * thread-fsm.c: Remove.
8225         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8226
8227 2019-02-07  Tom Tromey  <tom@tromey.com>
8228
8229         * yy-remap.h: Add include guard.
8230         * xtensa-tdep.h: Add include guard.
8231         * xcoffread.h: Rename include guard.
8232         * varobj-iter.h: Add include guard.
8233         * tui/tui.h: Rename include guard.
8234         * tui/tui-winsource.h: Rename include guard.
8235         * tui/tui-wingeneral.h: Rename include guard.
8236         * tui/tui-windata.h: Rename include guard.
8237         * tui/tui-win.h: Rename include guard.
8238         * tui/tui-stack.h: Rename include guard.
8239         * tui/tui-source.h: Rename include guard.
8240         * tui/tui-regs.h: Rename include guard.
8241         * tui/tui-out.h: Rename include guard.
8242         * tui/tui-layout.h: Rename include guard.
8243         * tui/tui-io.h: Rename include guard.
8244         * tui/tui-hooks.h: Rename include guard.
8245         * tui/tui-file.h: Rename include guard.
8246         * tui/tui-disasm.h: Rename include guard.
8247         * tui/tui-data.h: Rename include guard.
8248         * tui/tui-command.h: Rename include guard.
8249         * tic6x-tdep.h: Add include guard.
8250         * target/waitstatus.h: Rename include guard.
8251         * target/wait.h: Rename include guard.
8252         * target/target.h: Rename include guard.
8253         * target/resume.h: Rename include guard.
8254         * target-float.h: Rename include guard.
8255         * stabsread.h: Add include guard.
8256         * rs6000-tdep.h: Add include guard.
8257         * riscv-fbsd-tdep.h: Add include guard.
8258         * regformats/regdef.h: Rename include guard.
8259         * record.h: Rename include guard.
8260         * python/python.h: Rename include guard.
8261         * python/python-internal.h: Rename include guard.
8262         * python/py-stopevent.h: Rename include guard.
8263         * python/py-ref.h: Rename include guard.
8264         * python/py-record.h: Rename include guard.
8265         * python/py-record-full.h: Rename include guard.
8266         * python/py-record-btrace.h: Rename include guard.
8267         * python/py-instruction.h: Rename include guard.
8268         * python/py-events.h: Rename include guard.
8269         * python/py-event.h: Rename include guard.
8270         * procfs.h: Add include guard.
8271         * proc-utils.h: Add include guard.
8272         * p-lang.h: Add include guard.
8273         * or1k-tdep.h: Rename include guard.
8274         * observable.h: Rename include guard.
8275         * nto-tdep.h: Rename include guard.
8276         * nat/x86-linux.h: Rename include guard.
8277         * nat/x86-linux-dregs.h: Rename include guard.
8278         * nat/x86-gcc-cpuid.h: Add include guard.
8279         * nat/x86-dregs.h: Rename include guard.
8280         * nat/x86-cpuid.h: Rename include guard.
8281         * nat/ppc-linux.h: Rename include guard.
8282         * nat/mips-linux-watch.h: Rename include guard.
8283         * nat/linux-waitpid.h: Rename include guard.
8284         * nat/linux-ptrace.h: Rename include guard.
8285         * nat/linux-procfs.h: Rename include guard.
8286         * nat/linux-osdata.h: Rename include guard.
8287         * nat/linux-nat.h: Rename include guard.
8288         * nat/linux-namespaces.h: Rename include guard.
8289         * nat/linux-btrace.h: Rename include guard.
8290         * nat/glibc_thread_db.h: Rename include guard.
8291         * nat/gdb_thread_db.h: Rename include guard.
8292         * nat/gdb_ptrace.h: Rename include guard.
8293         * nat/fork-inferior.h: Rename include guard.
8294         * nat/amd64-linux-siginfo.h: Rename include guard.
8295         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8296         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8297         * nat/aarch64-linux.h: Rename include guard.
8298         * nat/aarch64-linux-hw-point.h: Rename include guard.
8299         * mn10300-tdep.h: Add include guard.
8300         * mips-linux-tdep.h: Add include guard.
8301         * mi/mi-parse.h: Rename include guard.
8302         * mi/mi-out.h: Rename include guard.
8303         * mi/mi-main.h: Rename include guard.
8304         * mi/mi-interp.h: Rename include guard.
8305         * mi/mi-getopt.h: Rename include guard.
8306         * mi/mi-console.h: Rename include guard.
8307         * mi/mi-common.h: Rename include guard.
8308         * mi/mi-cmds.h: Rename include guard.
8309         * mi/mi-cmd-break.h: Rename include guard.
8310         * m2-lang.h: Add include guard.
8311         * location.h: Rename include guard.
8312         * linux-record.h: Rename include guard.
8313         * linux-nat.h: Add include guard.
8314         * linux-fork.h: Add include guard.
8315         * i386-darwin-tdep.h: Rename include guard.
8316         * hppa-linux-offsets.h: Add include guard.
8317         * guile/guile.h: Rename include guard.
8318         * guile/guile-internal.h: Rename include guard.
8319         * gnu-nat.h: Rename include guard.
8320         * gdb-stabs.h: Rename include guard.
8321         * frv-tdep.h: Add include guard.
8322         * f-lang.h: Add include guard.
8323         * event-loop.h: Add include guard.
8324         * darwin-nat.h: Rename include guard.
8325         * cp-abi.h: Rename include guard.
8326         * config/sparc/nm-sol2.h: Rename include guard.
8327         * config/nm-nto.h: Rename include guard.
8328         * config/nm-linux.h: Add include guard.
8329         * config/i386/nm-i386gnu.h: Rename include guard.
8330         * config/djgpp/nl_types.h: Rename include guard.
8331         * config/djgpp/langinfo.h: Rename include guard.
8332         * compile/gcc-cp-plugin.h: Add include guard.
8333         * compile/gcc-c-plugin.h: Add include guard.
8334         * compile/compile.h: Rename include guard.
8335         * compile/compile-object-run.h: Rename include guard.
8336         * compile/compile-object-load.h: Rename include guard.
8337         * compile/compile-internal.h: Rename include guard.
8338         * compile/compile-cplus.h: Rename include guard.
8339         * compile/compile-c.h: Rename include guard.
8340         * common/xml-utils.h: Rename include guard.
8341         * common/x86-xstate.h: Rename include guard.
8342         * common/version.h: Rename include guard.
8343         * common/vec.h: Rename include guard.
8344         * common/tdesc.h: Rename include guard.
8345         * common/selftest.h: Rename include guard.
8346         * common/scoped_restore.h: Rename include guard.
8347         * common/scoped_mmap.h: Rename include guard.
8348         * common/scoped_fd.h: Rename include guard.
8349         * common/safe-iterator.h: Rename include guard.
8350         * common/run-time-clock.h: Rename include guard.
8351         * common/refcounted-object.h: Rename include guard.
8352         * common/queue.h: Rename include guard.
8353         * common/ptid.h: Rename include guard.
8354         * common/print-utils.h: Rename include guard.
8355         * common/preprocessor.h: Rename include guard.
8356         * common/pathstuff.h: Rename include guard.
8357         * common/observable.h: Rename include guard.
8358         * common/netstuff.h: Rename include guard.
8359         * common/job-control.h: Rename include guard.
8360         * common/host-defs.h: Rename include guard.
8361         * common/gdb_wait.h: Rename include guard.
8362         * common/gdb_vecs.h: Rename include guard.
8363         * common/gdb_unlinker.h: Rename include guard.
8364         * common/gdb_unique_ptr.h: Rename include guard.
8365         * common/gdb_tilde_expand.h: Rename include guard.
8366         * common/gdb_sys_time.h: Rename include guard.
8367         * common/gdb_string_view.h: Rename include guard.
8368         * common/gdb_splay_tree.h: Rename include guard.
8369         * common/gdb_setjmp.h: Rename include guard.
8370         * common/gdb_ref_ptr.h: Rename include guard.
8371         * common/gdb_optional.h: Rename include guard.
8372         * common/gdb_locale.h: Rename include guard.
8373         * common/gdb_assert.h: Rename include guard.
8374         * common/filtered-iterator.h: Rename include guard.
8375         * common/filestuff.h: Rename include guard.
8376         * common/fileio.h: Rename include guard.
8377         * common/environ.h: Rename include guard.
8378         * common/common-utils.h: Rename include guard.
8379         * common/common-types.h: Rename include guard.
8380         * common/common-regcache.h: Rename include guard.
8381         * common/common-inferior.h: Rename include guard.
8382         * common/common-gdbthread.h: Rename include guard.
8383         * common/common-exceptions.h: Rename include guard.
8384         * common/common-defs.h: Rename include guard.
8385         * common/common-debug.h: Rename include guard.
8386         * common/cleanups.h: Rename include guard.
8387         * common/buffer.h: Rename include guard.
8388         * common/btrace-common.h: Rename include guard.
8389         * common/break-common.h: Rename include guard.
8390         * cli/cli-utils.h: Rename include guard.
8391         * cli/cli-style.h: Rename include guard.
8392         * cli/cli-setshow.h: Rename include guard.
8393         * cli/cli-script.h: Rename include guard.
8394         * cli/cli-interp.h: Rename include guard.
8395         * cli/cli-decode.h: Rename include guard.
8396         * cli/cli-cmds.h: Rename include guard.
8397         * charset-list.h: Add include guard.
8398         * buildsym-legacy.h: Rename include guard.
8399         * bfin-tdep.h: Add include guard.
8400         * ax.h: Rename include guard.
8401         * arm-linux-tdep.h: Add include guard.
8402         * arm-fbsd-tdep.h: Add include guard.
8403         * arch/xtensa.h: Rename include guard.
8404         * arch/tic6x.h: Add include guard.
8405         * arch/i386.h: Add include guard.
8406         * arch/arm.h: Rename include guard.
8407         * arch/arm-linux.h: Rename include guard.
8408         * arch/arm-get-next-pcs.h: Rename include guard.
8409         * arch/amd64.h: Add include guard.
8410         * arch/aarch64-insn.h: Rename include guard.
8411         * arch-utils.h: Rename include guard.
8412         * annotate.h: Add include guard.
8413         * amd64-darwin-tdep.h: Rename include guard.
8414         * aarch64-linux-tdep.h: Add include guard.
8415         * aarch64-fbsd-tdep.h: Add include guard.
8416         * aarch32-linux-nat.h: Add include guard.
8417
8418 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8419
8420         * macrotab.c (macro_define_internal): New function that
8421         factorizes macro_define_object_internal and macro_define_function
8422         code.
8423         (macro_define_object_internal): Use macro_define_internal.
8424         (macro_define_function): Likewise.
8425
8426 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8427
8428         * macrocmd.c (extract_identifier): Return
8429         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8430         callers.
8431
8432 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8433
8434         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8435
8436 2019-02-05  Tom Tromey  <tom@tromey.com>
8437
8438         * target.c (target_stack::unpush): Move assertion earlier.
8439
8440 2019-01-30  Tom Tromey  <tom@tromey.com>
8441
8442         PR python/23615:
8443         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8444         (gdbpy_parse_and_eval): Likewise.
8445         * python/python-internal.h (gdbpy_allow_threads): New class.
8446
8447 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8448
8449         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8450         (aarch64_fbsd_fpregmap): Move earlier.
8451         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8452         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8453         instead of individual calls to trad_frame_set_reg_addr.
8454         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8455         earlier.
8456         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8457         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8458         instead of individual calls to trad_frame_set_reg_addr.
8459
8460 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8461
8462         * CONTRIBUTE: Replace contribution list with wiki link.
8463
8464 2019-01-25  Tom Tromey  <tom@tromey.com>
8465
8466         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8467
8468 2019-01-25  Tom Tromey  <tom@tromey.com>
8469
8470         * xtensa-linux-nat.c: Fix common/ includes.
8471         * xml-support.h: Fix common/ includes.
8472         * xml-support.c: Fix common/ includes.
8473         * x86-linux-nat.c: Fix common/ includes.
8474         * windows-nat.c: Fix common/ includes.
8475         * varobj.h: Fix common/ includes.
8476         * varobj.c: Fix common/ includes.
8477         * value.c: Fix common/ includes.
8478         * valops.c: Fix common/ includes.
8479         * utils.c: Fix common/ includes.
8480         * unittests/xml-utils-selftests.c: Fix common/ includes.
8481         * unittests/utils-selftests.c: Fix common/ includes.
8482         * unittests/unpack-selftests.c: Fix common/ includes.
8483         * unittests/tracepoint-selftests.c: Fix common/ includes.
8484         * unittests/style-selftests.c: Fix common/ includes.
8485         * unittests/string_view-selftests.c: Fix common/ includes.
8486         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8487         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8488         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8489         * unittests/rsp-low-selftests.c: Fix common/ includes.
8490         * unittests/parse-connection-spec-selftests.c: Fix common/
8491         includes.
8492         * unittests/optional-selftests.c: Fix common/ includes.
8493         * unittests/offset-type-selftests.c: Fix common/ includes.
8494         * unittests/observable-selftests.c: Fix common/ includes.
8495         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8496         * unittests/memrange-selftests.c: Fix common/ includes.
8497         * unittests/memory-map-selftests.c: Fix common/ includes.
8498         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8499         * unittests/function-view-selftests.c: Fix common/ includes.
8500         * unittests/environ-selftests.c: Fix common/ includes.
8501         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8502         * unittests/common-utils-selftests.c: Fix common/ includes.
8503         * unittests/cli-utils-selftests.c: Fix common/ includes.
8504         * unittests/array-view-selftests.c: Fix common/ includes.
8505         * ui-file.c: Fix common/ includes.
8506         * tui/tui-io.c: Fix common/ includes.
8507         * tracepoint.h: Fix common/ includes.
8508         * tracepoint.c: Fix common/ includes.
8509         * tracefile-tfile.c: Fix common/ includes.
8510         * top.h: Fix common/ includes.
8511         * top.c: Fix common/ includes.
8512         * thread.c: Fix common/ includes.
8513         * target/waitstatus.h: Fix common/ includes.
8514         * target/waitstatus.c: Fix common/ includes.
8515         * target.h: Fix common/ includes.
8516         * target.c: Fix common/ includes.
8517         * target-memory.c: Fix common/ includes.
8518         * target-descriptions.c: Fix common/ includes.
8519         * symtab.h: Fix common/ includes.
8520         * symfile.c: Fix common/ includes.
8521         * stap-probe.c: Fix common/ includes.
8522         * spu-linux-nat.c: Fix common/ includes.
8523         * sparc-nat.c: Fix common/ includes.
8524         * source.c: Fix common/ includes.
8525         * solib.c: Fix common/ includes.
8526         * solib-target.c: Fix common/ includes.
8527         * ser-unix.c: Fix common/ includes.
8528         * ser-tcp.c: Fix common/ includes.
8529         * ser-pipe.c: Fix common/ includes.
8530         * ser-base.c: Fix common/ includes.
8531         * selftest-arch.c: Fix common/ includes.
8532         * s12z-tdep.c: Fix common/ includes.
8533         * rust-exp.y: Fix common/ includes.
8534         * rs6000-aix-tdep.c: Fix common/ includes.
8535         * riscv-tdep.c: Fix common/ includes.
8536         * remote.c: Fix common/ includes.
8537         * remote-notif.h: Fix common/ includes.
8538         * remote-fileio.h: Fix common/ includes.
8539         * remote-fileio.c: Fix common/ includes.
8540         * regcache.h: Fix common/ includes.
8541         * regcache.c: Fix common/ includes.
8542         * record-btrace.c: Fix common/ includes.
8543         * python/python.c: Fix common/ includes.
8544         * python/py-type.c: Fix common/ includes.
8545         * python/py-inferior.c: Fix common/ includes.
8546         * progspace.h: Fix common/ includes.
8547         * producer.c: Fix common/ includes.
8548         * procfs.c: Fix common/ includes.
8549         * proc-api.c: Fix common/ includes.
8550         * printcmd.c: Fix common/ includes.
8551         * ppc-linux-nat.c: Fix common/ includes.
8552         * parser-defs.h: Fix common/ includes.
8553         * osdata.c: Fix common/ includes.
8554         * obsd-nat.c: Fix common/ includes.
8555         * nat/x86-linux.c: Fix common/ includes.
8556         * nat/x86-linux-dregs.c: Fix common/ includes.
8557         * nat/x86-dregs.h: Fix common/ includes.
8558         * nat/x86-dregs.c: Fix common/ includes.
8559         * nat/ppc-linux.c: Fix common/ includes.
8560         * nat/mips-linux-watch.h: Fix common/ includes.
8561         * nat/mips-linux-watch.c: Fix common/ includes.
8562         * nat/linux-waitpid.c: Fix common/ includes.
8563         * nat/linux-ptrace.h: Fix common/ includes.
8564         * nat/linux-ptrace.c: Fix common/ includes.
8565         * nat/linux-procfs.c: Fix common/ includes.
8566         * nat/linux-personality.c: Fix common/ includes.
8567         * nat/linux-osdata.c: Fix common/ includes.
8568         * nat/linux-namespaces.c: Fix common/ includes.
8569         * nat/linux-btrace.h: Fix common/ includes.
8570         * nat/linux-btrace.c: Fix common/ includes.
8571         * nat/fork-inferior.c: Fix common/ includes.
8572         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8573         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8574         * nat/aarch64-linux.c: Fix common/ includes.
8575         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8576         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8577         * namespace.h: Fix common/ includes.
8578         * mips-linux-tdep.c: Fix common/ includes.
8579         * minsyms.c: Fix common/ includes.
8580         * mi/mi-parse.h: Fix common/ includes.
8581         * mi/mi-main.c: Fix common/ includes.
8582         * mi/mi-cmd-env.c: Fix common/ includes.
8583         * memrange.h: Fix common/ includes.
8584         * memattr.c: Fix common/ includes.
8585         * maint.h: Fix common/ includes.
8586         * maint.c: Fix common/ includes.
8587         * main.c: Fix common/ includes.
8588         * machoread.c: Fix common/ includes.
8589         * location.c: Fix common/ includes.
8590         * linux-thread-db.c: Fix common/ includes.
8591         * linux-nat.c: Fix common/ includes.
8592         * linux-fork.c: Fix common/ includes.
8593         * inline-frame.c: Fix common/ includes.
8594         * infrun.c: Fix common/ includes.
8595         * inflow.c: Fix common/ includes.
8596         * inferior.h: Fix common/ includes.
8597         * inferior.c: Fix common/ includes.
8598         * infcmd.c: Fix common/ includes.
8599         * inf-ptrace.c: Fix common/ includes.
8600         * inf-child.c: Fix common/ includes.
8601         * ia64-linux-nat.c: Fix common/ includes.
8602         * i387-tdep.c: Fix common/ includes.
8603         * i386-tdep.c: Fix common/ includes.
8604         * i386-linux-tdep.c: Fix common/ includes.
8605         * i386-linux-nat.c: Fix common/ includes.
8606         * i386-go32-tdep.c: Fix common/ includes.
8607         * i386-fbsd-tdep.c: Fix common/ includes.
8608         * i386-fbsd-nat.c: Fix common/ includes.
8609         * guile/scm-type.c: Fix common/ includes.
8610         * guile/guile.c: Fix common/ includes.
8611         * go32-nat.c: Fix common/ includes.
8612         * gnu-nat.c: Fix common/ includes.
8613         * gdbthread.h: Fix common/ includes.
8614         * gdbarch-selftests.c: Fix common/ includes.
8615         * gdb_usleep.c: Fix common/ includes.
8616         * gdb_select.h: Fix common/ includes.
8617         * gdb_bfd.c: Fix common/ includes.
8618         * gcore.c: Fix common/ includes.
8619         * fork-child.c: Fix common/ includes.
8620         * findvar.c: Fix common/ includes.
8621         * fbsd-nat.c: Fix common/ includes.
8622         * event-top.c: Fix common/ includes.
8623         * event-loop.c: Fix common/ includes.
8624         * dwarf2read.c: Fix common/ includes.
8625         * dwarf2loc.c: Fix common/ includes.
8626         * dwarf2-frame.c: Fix common/ includes.
8627         * dwarf-index-cache.c: Fix common/ includes.
8628         * dtrace-probe.c: Fix common/ includes.
8629         * disasm-selftests.c: Fix common/ includes.
8630         * defs.h: Fix common/ includes.
8631         * csky-tdep.c: Fix common/ includes.
8632         * cp-valprint.c: Fix common/ includes.
8633         * cp-support.h: Fix common/ includes.
8634         * cp-support.c: Fix common/ includes.
8635         * corelow.c: Fix common/ includes.
8636         * completer.h: Fix common/ includes.
8637         * completer.c: Fix common/ includes.
8638         * compile/compile.c: Fix common/ includes.
8639         * compile/compile-loc2c.c: Fix common/ includes.
8640         * compile/compile-cplus-types.c: Fix common/ includes.
8641         * compile/compile-cplus-symbols.c: Fix common/ includes.
8642         * command.h: Fix common/ includes.
8643         * cli/cli-dump.c: Fix common/ includes.
8644         * cli/cli-cmds.c: Fix common/ includes.
8645         * charset.c: Fix common/ includes.
8646         * build-id.c: Fix common/ includes.
8647         * btrace.h: Fix common/ includes.
8648         * btrace.c: Fix common/ includes.
8649         * breakpoint.h: Fix common/ includes.
8650         * breakpoint.c: Fix common/ includes.
8651         * ax.h:
8652         (enum agent_op): Fix common/ includes.
8653         * ax-general.c (struct aop_map): Fix common/ includes.
8654         * ax-gdb.c: Fix common/ includes.
8655         * auxv.c: Fix common/ includes.
8656         * auto-load.c: Fix common/ includes.
8657         * arm-tdep.c: Fix common/ includes.
8658         * arch/riscv.c: Fix common/ includes.
8659         * arch/ppc-linux-common.c: Fix common/ includes.
8660         * arch/i386.c: Fix common/ includes.
8661         * arch/arm.c: Fix common/ includes.
8662         * arch/arm-linux.c: Fix common/ includes.
8663         * arch/arm-get-next-pcs.c: Fix common/ includes.
8664         * arch/amd64.c: Fix common/ includes.
8665         * arch/aarch64.c: Fix common/ includes.
8666         * arch/aarch64-insn.c: Fix common/ includes.
8667         * arch-utils.c: Fix common/ includes.
8668         * amd64-windows-tdep.c: Fix common/ includes.
8669         * amd64-tdep.c: Fix common/ includes.
8670         * amd64-sol2-tdep.c: Fix common/ includes.
8671         * amd64-obsd-tdep.c: Fix common/ includes.
8672         * amd64-nbsd-tdep.c: Fix common/ includes.
8673         * amd64-linux-tdep.c: Fix common/ includes.
8674         * amd64-linux-nat.c: Fix common/ includes.
8675         * amd64-fbsd-tdep.c: Fix common/ includes.
8676         * amd64-fbsd-nat.c: Fix common/ includes.
8677         * amd64-dicos-tdep.c: Fix common/ includes.
8678         * amd64-darwin-tdep.c: Fix common/ includes.
8679         * agent.c: Fix common/ includes.
8680         * ada-lang.h: Fix common/ includes.
8681         * ada-lang.c: Fix common/ includes.
8682         * aarch64-tdep.c: Fix common/ includes.
8683
8684 2019-01-25  Tom Tromey  <tom@tromey.com>
8685
8686         * common/create-version.sh: Use common/version.h.
8687
8688 2019-01-24  Pedro Alves  <palves@redhat.com>
8689
8690         * infrun.c (signal_stop, signal_print, signal_program)
8691         (signal_catch, signal_pass): Now arrays instead of pointers.
8692         (update_signals_program_target, do_target_resume)
8693         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8694         * linux-nat.c (linux_nat_target::pass_signals)
8695         (linux_nat_target::create_inferior, linux_nat_target::attach):
8696         Adjust.
8697         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8698         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8699         * procfs.c (procfs_target::pass_signals): Adjust.
8700         * record-full.c (record_full_target::resume): Adjust.
8701         * remote.c (remote_target::pass_signals)
8702         (remote_target::program_signals): Adjust.
8703         * target-debug.h (target_debug_print_signals): Now takes a
8704         gdb::array_view as parameter.  Adjust.
8705         * target.h (target_ops) <pass_signals, program_signals>: Replace
8706         pointer and length parameters with gdb::array_view.
8707         (target_pass_signals, target_program_signals): Likewise.
8708         * target-delegates.c: Regenerate.
8709
8710 2019-01-24  Pedro Alves  <palves@redhat.com>
8711
8712         * common/forward-scope-exit.h
8713         (forward_scope_exit::forward_scope_exit): Pass arguments to
8714         m_bind_function directly, instead of creating a std::bind and
8715         copying that.
8716
8717 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8718
8719         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8720         for static members.
8721         (pass_in_v_vfp_candidate): Likewise.
8722
8723 2019-01-23  Tom Tromey  <tom@tromey.com>
8724             Pedro Alves  <palves@redhat.com>
8725
8726         * regcache.c (class regcache_invalidator): Remove.
8727         (regcache::raw_write): Use make_scope_exit.
8728
8729 2019-01-23  Tom Tromey  <tom@tromey.com>
8730
8731         * ui-out.h (class ui_out_emit_type): Update comment.
8732
8733 2019-01-23  Tom Tromey  <tom@tromey.com>
8734
8735         * infrun.c (fetch_inferior_event): Update comment.
8736
8737 2019-01-23  Tom Tromey  <tom@tromey.com>
8738             Pedro Alves  <palves@redhat.com>
8739
8740         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8741         parameter.
8742         (fetch_inferior_event): Use SCOPE_EXIT.
8743
8744
8745 2019-01-23  Tom Tromey  <tom@tromey.com>
8746             Pedro Alves  <palves@redhat.com>
8747
8748         * infrun.c (disable_thread_events): Delete.
8749         (stop_all_threads): Use SCOPE_EXIT.
8750
8751 2019-01-23  Tom Tromey  <tom@tromey.com>
8752             Pedro Alves  <palves@redhat.com>
8753
8754         * symfile.c: Include forward-scope-exit.h.
8755         (clear_symtab_users_cleanup): Replace forward declaration with
8756         a FORWARD_SCOPE_EXIT.
8757         (syms_from_objfile_1): Use the forward_scope_exit and
8758         gdb::optional instead of cleanup_function.
8759         (reread_symbols): Use the forward_scope_exit instead of
8760         cleanup_function.
8761         (clear_symtab_users_cleanup): Remove function.
8762
8763 2019-01-23  Tom Tromey  <tom@tromey.com>
8764             Pedro Alves  <palves@redhat.com>
8765
8766         * linux-nat.c: Include scope-exit.h.
8767         (cleanup_target_stop): Remove.
8768         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8769         SCOPE_EXIT.
8770
8771 2019-01-23  Tom Tromey  <tom@tromey.com>
8772             Pedro Alves  <palves@redhat.com>
8773
8774         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8775         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8776
8777 2019-01-23  Tom Tromey  <tom@tromey.com>
8778             Andrew Burgess  <andrew.burgess@embecosm.com>
8779             Pedro Alves  <palves@redhat.com>
8780
8781         * infrun.c (fetch_inferior_event): Use scope_exit.
8782         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8783         * top.c (execute_command): Use scope_exit.
8784         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8785         * utils.c (do_bpstat_clear_actions_cleanup)
8786         (make_bpstat_clear_actions_cleanup): Remove.
8787
8788 2019-01-23  Tom Tromey  <tom@tromey.com>
8789             Pedro Alves  <palves@redhat.com>
8790
8791         * infrun.c: Include "common/scope-exit.h"
8792         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8793         (wait_for_inferior): Use SCOPE_EXIT.
8794         (fetch_inferior_event): Use scope_exit.
8795
8796 2019-01-23  Tom Tromey  <tom@tromey.com>
8797             Pedro Alves  <palves@redhat.com>
8798
8799         * breakpoint.c (create_breakpoint): Remove cleanup.
8800
8801 2019-01-23  Tom Tromey  <tom@tromey.com>
8802             Andrew Burgess  <andrew.burgess@embecosm.com>
8803             Pedro Alves  <palves@redhat.com>
8804
8805 2019-01-23  Pedro Alves  <palves@redhat.com>
8806
8807         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8808
8809 2019-01-23  Pedro Alves  <palves@redhat.com>
8810             Andrew Burgess  <andrew.burgess@embecosm.com>
8811
8812         * gdbthread.h: Include "common/forward-scope-exit.h".
8813         (scoped_finish_thread_state): Redefine custom class in terms of
8814         forward_scope_exit.
8815
8816 2019-01-23  Pedro Alves  <palves@redhat.com>
8817             Andrew Burgess  <andrew.burgess@embecosm.com>
8818
8819         * common/forward-scope-exit.h: New file.
8820
8821 2019-01-23  Pedro Alves  <palves@redhat.com>
8822             Andrew Burgess  <andrew.burgess@embecosm.com>
8823             Tom Tromey  <tom@tromey.com>
8824
8825         * common/scope-exit.h: New file.
8826
8827 2019-01-23  Pedro Alves  <palves@redhat.com>
8828
8829         * common/preprocessor.h (ESC): Rename to ...
8830         (ESC_PARENS): ... this.
8831         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8832         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8833
8834 2019-01-23  Tom Tromey  <tom@tromey.com>
8835
8836         * language.h (class scoped_switch_to_sym_language_if_auto):
8837         Initialize m_lang in both cases.
8838
8839 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8840
8841         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8842         with XCNEW.
8843
8844 2019-01-22  Tom Tromey  <tom@tromey.com>
8845
8846         * corelow.c: Do not include sys/file.h.
8847
8848 2019-01-22  Tom Tromey  <tom@tromey.com>
8849
8850         * tui/tui-wingeneral.h: Include gdb_curses.h.
8851
8852 2019-01-22  Tom Tromey  <tom@tromey.com>
8853
8854         * source-cache.h (class source_cache) <get_source_lines,
8855         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8856
8857 2019-01-22  Tom Tromey  <tom@tromey.com>
8858
8859         * remote-fileio.h (struct remote_target): Declare.
8860
8861 2019-01-22  Tom Tromey  <tom@tromey.com>
8862
8863         * python/py-arch.c: Do not include py-ref.h.
8864         * python/py-bpevent.c: Do not include py-ref.h.
8865         * python/py-cmd.c: Do not include py-ref.h.
8866         * python/py-continueevent.c: Do not include py-ref.h.
8867         * python/py-event.h: Do not include py-ref.h.
8868         * python/py-evtregistry.c: Do not include py-ref.h.
8869         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8870         * python/py-frame.c: Do not include py-ref.h.
8871         * python/py-framefilter.c: Do not include py-ref.h.
8872         * python/py-function.c: Do not include py-ref.h.
8873         * python/py-infevents.c: Do not include py-ref.h.
8874         * python/py-linetable.c: Do not include py-ref.h.
8875         * python/py-objfile.c: Do not include py-ref.h.
8876         * python/py-param.c: Do not include py-ref.h.
8877         * python/py-prettyprint.c: Do not include py-ref.h.
8878         * python/py-progspace.c: Do not include py-ref.h.
8879         * python/py-symbol.c: Do not include py-ref.h.
8880         * python/py-symtab.c: Do not include py-ref.h.
8881         * python/py-type.c: Do not include py-ref.h.
8882         * python/py-unwind.c: Do not include py-ref.h.
8883         * python/py-utils.c: Do not include py-ref.h.
8884         * python/py-value.c: Do not include py-ref.h.
8885         * python/py-varobj.c: Do not include py-ref.h.
8886         * python/py-xmethods.c: Do not include py-ref.h.
8887         * python/python.c: Do not include py-ref.h.
8888         * varobj.c: Do not include py-ref.h.
8889
8890 2019-01-22  Tom Tromey  <tom@tromey.com>
8891
8892         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8893         keyword for bcache.
8894
8895 2019-01-22  Tom Tromey  <tom@tromey.com>
8896
8897         * compile/compile-cplus-types.c: Remove a comment by #include.
8898
8899 2019-01-22  Tom Tromey  <tom@tromey.com>
8900
8901         * compile/gcc-c-plugin.h: Include compile-internal.h.
8902
8903 2019-01-22  Tom Tromey  <tom@tromey.com>
8904
8905         * stabsread.c (EXTERN): Do not define.
8906         (symnum, next_symbol_text_func, processing_gcc_compilation)
8907         (within_function, global_sym_chain, global_stabs)
8908         (previous_stab_code, this_object_header_files)
8909         (n_this_object_header_files)
8910         (n_allocated_this_object_header_files): Define.
8911         * stabsread.h (EXTERN): Never define.  Use "extern".
8912
8913 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8914
8915         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8916         history_value.
8917
8918 2019-01-21  Tom Tromey  <tom@tromey.com>
8919
8920         * ui-out.c: Fix includes.
8921         * tui/tui-source.c: Fix includes.
8922         * target.c: Fix includes.
8923         * remote.c: Fix includes.
8924         * regcache.c: Fix includes.
8925         * python/py-block.c: Fix includes.
8926         * printcmd.c: Fix includes.
8927         * or1k-tdep.c: Fix includes.
8928         * mi/mi-main.c: Fix includes.
8929         * m32r-tdep.c: Fix includes.
8930         * csky-tdep.c: Fix includes.
8931         * compile/compile-cplus-types.c: Fix includes.
8932         * cli/cli-interp.c: Fix includes.
8933
8934 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8935
8936         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8937         for padding.
8938
8939 2019-01-16  Tom Tromey  <tom@tromey.com>
8940
8941         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8942         earlier.
8943         (struct objfile) <msymbols_range>: Move from top level.
8944         <msymbols>: New method.
8945         (class objfile_msymbols): Remove.
8946         * symtab.c (default_collect_symbol_completion_matches_break_on):
8947         Update.
8948         * symmisc.c (dump_msymbols): Update.
8949         * stabsread.c (scan_file_globals): Update.
8950         * objc-lang.c (info_selectors_command, info_classes_command)
8951         (find_methods): Update.
8952         * minsyms.c (find_solib_trampoline_target): Update.
8953         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8954         * coffread.c (coff_symfile_read): Update.
8955         * ada-lang.c (ada_lookup_simple_minsym)
8956         (ada_collect_symbol_completion_matches): Update.
8957
8958 2019-01-16  Tom Tromey  <tom@tromey.com>
8959
8960         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8961         type.  Remove no-argument constructor.
8962         <iterator::operator++>: Simplify.
8963         <begin>: Update.
8964         <end>: Use minimal_symbol_count.
8965
8966 2019-01-16  Tom Tromey  <tom@tromey.com>
8967
8968         * objfiles.h (struct objfile) <psymtabs>: New method.
8969         (class objfile_psymtabs): Remove.
8970         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8971         typedef.
8972         <range>: New method.
8973         (require_partial_symbols): Change return type.
8974         * psymtab.c (require_partial_symbols)
8975         (psym_expand_symtabs_matching): Update.
8976         * mdebugread.c (parse_partial_symbols): Update.
8977         * dbxread.c (dbx_end_psymtab): Update.
8978
8979 2019-01-15  Tom Tromey  <tom@tromey.com>
8980
8981         * symtab.c (lookup_objfile_from_block)
8982         (lookup_symbol_in_objfile_symtabs)
8983         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8984         (find_line_symtab, info_sources_command)
8985         (default_collect_symbol_completion_matches_break_on)
8986         (make_source_files_completion_list): Update.
8987         * symmisc.c (print_objfile_statistics, dump_objfile)
8988         (maintenance_print_symbols, maintenance_info_symtabs)
8989         (maintenance_check_symtabs, maintenance_info_line_tables):
8990         Update.
8991         * source.c (select_source_symtab)
8992         (forget_cached_source_info_for_objfile): Update.
8993         * objfiles.h (class objfile_compunits): Remove.
8994         (struct objfile) <compunits_range>: New typedef.
8995         (compunits): New method.
8996         * objfiles.c (objfile_relocate1): Update.
8997         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8998         * maint.c (count_symtabs_and_blocks): Update.
8999         * linespec.c (iterate_over_all_matching_symtabs): Update.
9000         * cp-support.c (add_symbol_overload_list_qualified): Update.
9001         * coffread.c (coff_symtab_read): Update.
9002         * ada-lang.c (add_nonlocal_symbols)
9003         (ada_collect_symbol_completion_matches)
9004         (ada_add_global_exceptions): Update.
9005
9006 2019-01-15  Tom Tromey  <tom@tromey.com>
9007
9008         * progspace.h (program_space) <objfiles_safe_range>: New
9009         typedef.
9010         <objfiles_safe>: New method.
9011         * objfiles.h (class all_objfiles_safe): Remove.
9012         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9013         * jit.c (jit_inferior_exit_hook): Update.
9014
9015 2019-01-17  Tom Tromey  <tom@tromey.com>
9016
9017         * progspace.h (program_space) <objfiles_range>: New typedef.
9018         <objfiles>: New method.
9019         <objfiles_head>: Rename from objfiles.
9020         (object_files): Update.
9021         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9022         * guile/scm-pretty-print.c
9023         (ppscm_find_pretty_printer_from_objfiles): Update.
9024         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9025         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9026         Update.
9027         * python/py-progspace.c (pspy_get_objfiles): Update.
9028         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9029         Update.
9030         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9031         (objfpy_lookup_objfile_by_build_id): Update.
9032         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9033         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9034         Update.
9035         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9036         (expand_symtab_containing_pc, lookup_objfile_from_block)
9037         (lookup_static_symbol, basic_lookup_transparent_type)
9038         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9039         (find_line_symtab, info_sources_command)
9040         (default_collect_symbol_completion_matches_break_on)
9041         (make_source_files_completion_list, find_main_name): Update.
9042         * symmisc.c (print_symbol_bcache_statistics)
9043         (print_objfile_statistics, maintenance_print_symbols)
9044         (maintenance_print_msymbols, maintenance_print_objfiles)
9045         (maintenance_info_symtabs, maintenance_check_symtabs)
9046         (maintenance_expand_symtabs, maintenance_info_line_tables):
9047         Update.
9048         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9049         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9050         (map_overlay_command, unmap_overlay_command)
9051         (simple_overlay_update, expand_symtabs_matching)
9052         (map_symbol_filenames): Update.
9053         * symfile-debug.c (set_debug_symfile): Update.
9054         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9055         Update.
9056         * source.c (select_source_symtab, forget_cached_source_info):
9057         Update.
9058         * solib.c (solib_read_symbols): Update.
9059         * solib-spu.c (append_ocl_sos): Update.
9060         * psymtab.c (maintenance_print_psymbols)
9061         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9062         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9063         * printcmd.c (info_symbol_command): Update.
9064         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9065         Update.
9066         * objfiles.h (class all_objfiles): Remove.
9067         * objfiles.c (have_partial_symbols, have_full_symbols)
9068         (have_minimal_symbols, qsort_cmp, update_section_map)
9069         (shared_objfile_contains_address_p)
9070         (default_iterate_over_objfiles_in_search_order): Update.
9071         * objc-lang.c (info_selectors_command, info_classes_command)
9072         (find_methods): Update.
9073         * minsyms.c (find_solib_trampoline_target): Update.
9074         * maint.c (maintenance_info_sections)
9075         (maintenance_translate_address, count_symtabs_and_blocks):
9076         Update.
9077         * main.c (captured_main_1): Update.
9078         * linux-thread-db.c (try_thread_db_load_from_pdir)
9079         (has_libpthread): Update.
9080         * linespec.c (iterate_over_all_matching_symtabs)
9081         (search_minsyms_for_name): Update.
9082         * jit.c (jit_find_objf_with_entry_addr): Update.
9083         * hppa-tdep.c (find_unwind_entry)
9084         (hppa_lookup_stub_minimal_symbol): Update.
9085         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9086         Update.
9087         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9088         (elf_gnu_ifunc_resolve_by_got): Update.
9089         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9090         * dwarf-index-write.c (save_gdb_index_command): Update.
9091         * cp-support.c (add_symbol_overload_list_qualified): Update.
9092         * breakpoint.c (create_overlay_event_breakpoint)
9093         (create_longjmp_master_breakpoint)
9094         (create_std_terminate_master_breakpoint)
9095         (create_exception_master_breakpoint): Update.
9096         * blockframe.c (find_pc_partial_function): Update.
9097         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9098         (ada_collect_symbol_completion_matches)
9099         (ada_add_global_exceptions): Update.
9100
9101 2019-01-17  Tom Tromey  <tom@tromey.com>
9102
9103         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9104         declare VEC.
9105         (solib_target_parse_libraries): Change return type.
9106         (library_list_start_segment, library_list_start_section)
9107         (library_list_end_library, library_list_start_library); Update.
9108         (solib_target_free_library_list): Remove.
9109         (solib_target_parse_libraries): Remove cleanup.  Change return
9110         type.
9111         (solib_target_current_sos): Update.
9112
9113 2019-01-17  Tom Tromey  <tromey@bapiya>
9114
9115         * valprint.c: Replace "the the" with "the".
9116         * symtab.c: Replace "the the" with "the".
9117         * solib.c: Replace "the the" with "the".
9118         * solib-dsbt.c: Replace "the the" with "the".
9119         * linespec.c: Replace "the the" with "the".
9120         * dwarf2loc.h: Replace "the the" with "the".
9121         * amd64-windows-tdep.c: Replace "the the" with "the".
9122         * aarch64-tdep.c: Replace "the the" with "the".
9123
9124 2019-01-16  Keith Seitz  <keiths@redhat.com>
9125
9126         PR gdb/23773
9127         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9128         <builder>: Rename to ..
9129         <m_builder>: ... this and make private.
9130         (dwarf2_cu::get_builder): New method.  Change all users of
9131         `builder' to use this method.
9132         (dwarf2_start_symtab): Move to ...
9133         (dwarf2_cu::start_symtab): ... here.  Update all callers
9134         (setup_type_unit_groups): Move to ...
9135         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9136         callers.
9137         (dwarf2_cu::reset_builder): New method.
9138         (process_full_compunit, process_full_type_unit): Use
9139         dwarf2_cu::reset_builder.
9140         (follow_die_offset): Record the ancestor CU if it is different
9141         from the followed DIE's CU.
9142         (follow_die_sig_1): Likewise.
9143
9144 2019-01-15  Tom Tromey  <tom@tromey.com>
9145
9146         * remote.c (class remote_state) <buf>: Now a char_vector.
9147         <buf_size>: Remove.
9148         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9149         parameter.
9150         (remote_target::getpkt_or_notif_sane_1)
9151         (remote_target::getpkt_sane)
9152         (remote_target::getpkt_or_notif_sane): Likewise.
9153         (class remote_target) <putpkt>: New overload.
9154         (remote_target::read_frame): Change type of "buf_p".  Remove
9155         sizeof_p parameter.
9156         (packet_ok): New overload.
9157         (packet_check_result): New overload.
9158         Update all uses.
9159
9160 2019-01-14  Tom Tromey  <tom@tromey.com>
9161
9162         * remote-notif.c (handle_notification, remote_notif_ack)
9163         (remote_notif_parse): Make "buf" const.
9164         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9165         const.
9166         (remote_notif_parse, remote_notif_ack, handle_notification):
9167         Likewise.
9168         * remote.c (remote_notif_stop_parse): Make "buf" const.
9169         (remote_target::remote_parse_stop_reply): Make "buf" const.
9170         (remote_notif_stop_ack): Make "buf" const.
9171
9172 2019-01-14  Tom Tromey  <tom@tromey.com>
9173
9174         * remote.c (remote_console_output): Make parameter const.
9175
9176 2019-01-14  Tom Tromey  <tom@tromey.com>
9177
9178         * target-debug.h (target_debug_print_signals): Constify.
9179         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9180         * procfs.c (procfs_target::pass_signals): Update.
9181         * linux-nat.c (linux_nat_target::pass_signals): Update.
9182         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9183         * target-delegates.c: Rebuild.
9184         * remote.c (remote_target::program_signals): Update.
9185         (remote_target::pass_signals): Update.
9186         * target.c (target_pass_signals): Constify argument.
9187         (target_program_signals): Likewise.
9188         * target.h (struct target_ops) <pass_signals, program_signals>:
9189         Constify argument.
9190         (target_pass_signals, target_program_signals): Constify argument.
9191
9192 2019-01-14  Tom Tromey  <tom@tromey.com>
9193
9194         PR tui/28819:
9195         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9196
9197 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9198
9199         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9200         field.
9201         * rs6000-tdep.c: Include reggroups.h.
9202         (IS_V_ALIAS_PSEUDOREG): Define.
9203         (rs6000_register_name): Return names for the "vX" aliases.
9204         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9205         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9206         aliases.  Call default_register_reggroup_p for all other
9207         pseudo-registers.
9208         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9209         New functions.
9210         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9211         Handle "vX" aliases.
9212         (v_alias_pseudo_register_collect): New function.
9213         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9214         (rs6000_gdbarch_init): Initialize "vX" aliases as
9215         pseudo-registers.  Restore registration of
9216         rs6000_pseudo_register_reggroup_p with
9217         set_tdesc_pseudo_register_reggroup_p.
9218
9219 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9220
9221         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9222         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9223         set_gdbarch_num_pseudo_regs.
9224
9225 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9226
9227         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9228         Remove arg prefixname, add do_set and do_show.
9229         Add member functions set_list and show_list.
9230         * cli/cli-style.c (class cli_style_option): Update accordingly.
9231         (style_set_list): Move to file scope.
9232         (style_show_list): Likewise.
9233         (set_style): Call help_list.
9234         (show_style): Call cmd_show_list.
9235         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9236         Update to use the new macro.
9237
9238 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9239
9240         * ada-lang.c (_initialize_ada_language): Expand the help text
9241         for the "catch exception" command.
9242
9243 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9244
9245         * symtab.c (matching_obj_sections): Initialize obj,
9246         declare it closer to its usage.
9247
9248 2019-01-10  Tom Tromey  <tom@tromey.com>
9249
9250         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9251         (basic_inf_threads_range): Remove.
9252         (inf_threads_range, inf_non_exited_threads_range)
9253         (safe_inf_threads_range): Use next_adapter.
9254
9255 2019-01-10  Keith Seitz  <keiths@redhat.com>
9256
9257         PR gdb/23712
9258         PR symtab/23010
9259         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9260         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9261
9262 2019-01-10  Keith Seitz  <keiths@redhat.com>
9263
9264         PR gdb/23712
9265         PR symtab/23010
9266         * dictionary.c (pending_to_vector): Remove.
9267         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9268         Remove _1 suffix, replacing functions of the same name.  Update
9269         all callers.
9270         (dict_create_hashed, dict_create_hashed_expandable)
9271         (dict_create_linear, dict_create_linear_expandable, dict_free)
9272         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9273         Make functions static.
9274
9275 2019-01-10  Keith Seitz  <keiths@redhat.com>
9276
9277         PR gdb/23712
9278         PR symtab/23010
9279         * dictionary.h (struct dictionary): Replace declaration with
9280         multidictionary.
9281         (dict_create_hashed, dict_create_hashed_expandable)
9282         (dict_create_linear, dict_create_linear_expandable)
9283         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9284         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9285         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9286         taking multidictionary argument.
9287         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9288         * block.h (struct block) <dict>: Change to multidictionary
9289         and rename `multidict'.
9290         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9291         symmisc.c: Update all dictionary references to multidictionary.
9292
9293 2019-01-10  Keith Seitz  <keiths@redhat.com>
9294
9295         PR gdb/23712
9296         PR symtab/23010
9297         * dictionary.c: Include unordered_map.
9298         (pending_to_vector): New function.
9299         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9300         Rewrite the non-"_1" functions to take vector instead
9301         of linked list.
9302         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9303         "new" _1 versions of the same name.
9304         (multidictionary): Define.
9305         (std::hash<enum language): New definition.
9306         (collate_pending_symbols_by_language, mdict_create_hashed)
9307         (mdict_create_hashed_expandable, mdict_create_linear)
9308         (mdict_create_linear_expandable, mdict_free)
9309         (find_language_dictionary, create_new_language_dictionary)
9310         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9311         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9312         (mdict_size, mdict_empty): New functions.
9313         * dictionary.h (mdict_iterator): Define.
9314
9315 2019-01-10  Pedro Alves  <palves@redhat.com>
9316
9317         * breakpoint.c (read_uploaded_action)
9318         (create_tracepoint_from_upload): Adjust to use
9319         gdb::unique_xmalloc_ptr.
9320         * ctf.c (ctf_write_uploaded_tp):
9321         (SET_ARRAY_FIELD): Use emplace_back.
9322         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9323         * tracefile-tfile.c (tfile_write_uploaded_tp):
9324         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9325         gdb::unique_xmalloc_ptr.
9326         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9327         at_string, cond_string, cmd_strings>: Replace char pointers
9328         with gdb::unique_xmalloc_ptr.
9329
9330 2019-01-10  Pedro Alves  <palves@redhat.com>
9331
9332         * solib-target.c (library_list_start_library): Don't xstrdup name.
9333
9334 2019-01-10  Pedro Alves  <palves@redhat.com>
9335
9336         * mdebugread.c (parse_partial_symbols): Use
9337         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9338
9339 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9340
9341         * linux-fork.c (scoped_switch_fork_info)
9342         <~scoped_switch_fork_info>: Fix incorrect variable name.
9343
9344 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9345
9346         * linux-fork.c (scoped_switch_fork_info)
9347         <scoped_switch_fork_info>: Make explicit.
9348         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9349
9350 2019-01-10  Tom Tromey  <tom@tromey.com>
9351
9352         * objfiles.h (objfile::reset_psymtabs): Update.
9353         * objfiles.c (objfile::objfile): Update.
9354         * psymtab.h (psymtab_storage::obstack): Update.
9355         (psymtab_storage::m_obstack): Use gdb::optional.
9356         (class psymtab_storage): Update comment.  Remove objfile
9357         parameter.
9358         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9359
9360 2019-01-10  Tom Tromey  <tom@tromey.com>
9361
9362         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9363         <free_psymtabs>: Now private.
9364         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9365         (allocate_psymtab): Use new method.
9366
9367 2019-01-10  Tom Tromey  <tom@tromey.com>
9368
9369         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9370         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9371         * mdebugread.c (parse_partial_symbols): Use
9372         allocate_dependencies.
9373         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9374         allocate_dependencies.
9375         (process_psymtab_comp_unit_reader)
9376         (build_type_psymtab_dependencies): Likewise.
9377         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9378
9379 2019-01-10  Tom Tromey  <tom@tromey.com>
9380
9381         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9382         PSYMBOL_SET_LANGUAGE.
9383         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9384
9385 2019-01-10  Tom Tromey  <tom@tromey.com>
9386
9387         * psymtab.h (psymtab_storage::obstack): New method.
9388         <m_obstack>: Rename from obstack; now private.
9389         * psymtab.c (psymtab_storage): Update.
9390         * dwarf2read.c (create_addrmap_from_index)
9391         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9392         Update.
9393
9394 2019-01-10  Tom Tromey  <tom@tromey.com>
9395
9396         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9397         * objfiles.h (objfile::reset_psymtabs): New method.
9398
9399 2019-01-10  Tom Tromey  <tom@tromey.com>
9400
9401         * symmisc.c (print_symbol_bcache_statistics): Update.
9402         (print_objfile_statistics): Update.
9403         * symfile.c (reread_symbols): Update.
9404         * psymtab.h (class psymtab_storage): New.
9405         * psymtab.c (psymtab_storage): New constructor.
9406         (~psymtab_storage): New destructor.
9407         (require_partial_symbols): Update.
9408         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9409         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9410         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9411         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9412         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9413         (start_psymtab_common, end_psymtab_common)
9414         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9415         (allocate_psymtab): Update.
9416         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9417         Update.
9418         (dump_psymtab_addrmap, maintenance_print_psymbols)
9419         (maintenance_check_psymtabs): Update.
9420         (class objfile_psymtabs): Move to objfiles.h.
9421         * psympriv.h (discard_psymtab): Now inline.
9422         (psymtab_discarder::psymtab_discarder): Update.
9423         (psymtab_discarder::~psymtab_discarder): Update.
9424         (ALL_OBJFILE_PSYMTABS): Rewrite.
9425         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9426         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9427         Remove fields.
9428         <partial_symtabs>: New field.
9429         (class objfile_psymtabs): Move from psymtab.h.  Update.
9430         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9431         psymbol_cache.
9432         (objfile::~objfile): Don't destroy psymbol_cache.
9433         * mdebugread.c (parse_partial_symbols): Update.
9434         * dwarf2read.c (create_addrmap_from_index)
9435         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9436         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9437         (add_partial_subprogram, dwarf2_ranges_read): Update.
9438         * dwarf-index-write.c (write_address_map)
9439         (write_one_signatured_type, recursively_write_psymbols)
9440         (class debug_names, class debug_names, write_psymtabs_to_index):
9441         Update.
9442
9443 2019-01-10  Tom Tromey  <tom@tromey.com>
9444
9445         * symtab.h (SYMBOL_SET_NAMES): Update.
9446         (symbol_set_names): Update.
9447         (MSYMBOL_SET_NAMES): Update.
9448         * symtab.c (symbol_set_names): Change argument to be an
9449         objfile_per_bfd_storage.
9450         * psymtab.c (add_psymbol_to_bcache): Update.
9451         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9452
9453 2019-01-10  Tom Tromey  <tom@tromey.com>
9454
9455         * symtab.c (create_demangled_names_hash): Change argument to be an
9456         objfile_per_bfd_storage.
9457         (symbol_set_names): Update.
9458
9459 2019-01-10  Tom Tromey  <tom@tromey.com>
9460
9461         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9462         init_psymbol_list.
9463         * psymtab.c (init_psymbol_list): Do nothing if already called.
9464         * psympriv.h (init_psymbol_list): Add comment.
9465         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9466         init_psymbol_list.
9467         * dbxread.c (dbx_symfile_read): Unconditionally call
9468         init_psymbol_list.
9469
9470 2019-01-10  Tom Tromey  <tom@tromey.com>
9471
9472         * xcoffread.c (scan_xcoff_symtab): Update.
9473         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9474         "where".
9475         * mdebugread.c (parse_partial_symbols)
9476         (handle_psymbol_enumerators): Update.
9477         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9478         * dbxread.c (read_dbx_symtab): Update.
9479         * psympriv.h (psymbol_placement): New enum.
9480         (add_psymbol_to_list): Update.
9481
9482 2019-01-10  Tom Tromey  <tom@tromey.com>
9483
9484         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9485         static_psymbols parameters.
9486         (scan_xcoff_symtab): Update.
9487         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9488         static_psymbols parameters.
9489         * psympriv.h (start_psymtab_common): Update.
9490         * mdebugread.c (parse_partial_symbols): Update.
9491         * dwarf2read.c (create_partial_symtab): Update.
9492         * dbxread.c (read_dbx_symtab): Update.
9493         (start_psymtab): Remove global_psymbols and static_psymbols
9494         parameters.
9495
9496 2019-01-10  Tom Tromey  <tom@tromey.com>
9497
9498         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9499         * psymtab.c (allocate_psymtab): Add comment.
9500         * psympriv.h (allocate_psymtab): Add comment.
9501         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9502         initializations.
9503         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9504
9505 2019-01-10  Tom Tromey  <tom@tromey.com>
9506
9507         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9508         Don't declare.
9509         * mipsread.c: Include mdebugread.h.
9510         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9511         Declare.
9512         * elfread.c: Include mdebugread.h.
9513
9514 2019-01-09  Tom Tromey  <tom@tromey.com>
9515
9516         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9517         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9518         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9519         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9520         (psym_lookup_symbol, psym_find_last_source_symtab)
9521         (psym_forget_cached_source_info, psym_print_stats)
9522         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9523         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9524         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9525         (psym_find_compunit_symtab_by_address)
9526         (maintenance_print_psymbols, maintenance_info_psymtabs)
9527         (maintenance_check_psymtabs): Use ranged for.
9528         * psymtab.h (class objfile_psymtabs): New.
9529         (require_partial_symbols): Return objfile_psymtabs.
9530         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9531
9532 2019-01-09  Tom Tromey  <tom@tromey.com>
9533
9534         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9535         (find_pc_mapped_section, list_overlays_command)
9536         (map_overlay_command, unmap_overlay_command)
9537         (simple_overlay_update): Use all_objfiles.
9538         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9539         * printcmd.c (info_symbol_command): Use all_objfiles.
9540         * objfiles.h (ALL_OBJSECTIONS): Remove.
9541         * maint.c (maintenance_translate_address): Use all_objfiles.
9542         * gcore.c (gcore_create_callback): Use all_objfiles.
9543         (objfile_find_memory_regions): Likewise.
9544
9545 2019-01-09  Tom Tromey  <tom@tromey.com>
9546
9547         * symtab.c (find_line_symtab, info_sources_command)
9548         (make_source_files_completion_list): Use objfile_compunits.
9549         * source.c (select_source_symtab): Use objfile_compunits.
9550         * objfiles.h (struct objfile): Update comment.
9551         (ALL_OBJFILES): Remove.
9552         (ALL_FILETABS): Remove.
9553         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9554         objfile_compunits.
9555
9556 2019-01-09  Tom Tromey  <tom@tromey.com>
9557
9558         * symmisc.c (print_objfile_statistics, dump_objfile)
9559         (maintenance_print_symbols): Use compunit_filetabs.
9560         * source.c (forget_cached_source_info_for_objfile): Use
9561         compunit_filetabs.
9562         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9563         (ALL_FILETABS): Use compunit_filetabs.
9564         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9565         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9566
9567 2019-01-09  Tom Tromey  <tom@tromey.com>
9568
9569         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9570         (compunit_filetabs): New.
9571         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9572         compunit_filetabs.
9573         (info_sources_command, make_source_files_completion_list): Remove
9574         declaration.
9575         * symmisc.c (print_objfile_statistics, dump_objfile)
9576         (maintenance_print_symbols): Remove declaration.
9577         (maintenance_info_symtabs): Use compunit_filetabs.
9578         (maintenance_info_line_tables): Likewise.
9579         * source.c (select_source_symtab): Change local variable name.
9580         (forget_cached_source_info_for_objfile): Remove declaration.
9581         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9582         * objfiles.c (objfile_relocate1): Remove declaration.
9583         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9584         declaration.
9585         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9586         * coffread.c (coff_symtab_read): Remove declaration.
9587         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9588         compunit_filetabs.
9589
9590 2019-01-09  Tom Tromey  <tom@tromey.com>
9591
9592         * symtab.c (lookup_objfile_from_block)
9593         (find_pc_sect_compunit_symtab, search_symbols)
9594         (default_collect_symbol_completion_matches_break_on): Use
9595         objfile_compunits.
9596         * objfiles.h (ALL_COMPUNITS): Remove.
9597         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9598         * cp-support.c (add_symbol_overload_list_qualified): Use
9599         objfile_compunits.
9600         * ada-lang.c (ada_collect_symbol_completion_matches)
9601         (ada_add_global_exceptions): Use objfile_compunits.
9602
9603 2019-01-09  Tom Tromey  <tom@tromey.com>
9604
9605         * source.c (select_source_symtab)
9606         (forget_cached_source_info_for_objfile): Remove declaration.
9607         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9608         declaration.
9609         * maint.c (count_symtabs_and_blocks): Remove declaration.
9610         * cp-support.c (add_symbol_overload_list_qualified): Remove
9611         declaration.
9612         * coffread.c (coff_symtab_read): Remove declaration.
9613         * symtab.c (lookup_symbol_in_objfile_symtabs)
9614         (basic_lookup_transparent_type_1): Use objfile_compunits.
9615         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9616         (info_sources_command, search_symbols)
9617         (default_collect_symbol_completion_matches_break_on)
9618         (make_source_files_completion_list): Remove declaration.
9619         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9620         (ada_collect_symbol_completion_matches)
9621         (ada_add_global_exceptions): Remove declaration.
9622         * linespec.c (iterate_over_all_matching_symtabs): Use
9623         objfile_compunits.
9624         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9625         (class objfile_compunits): New.
9626         (ALL_COMPUNITS): Use objfile_compunits.
9627         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9628         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9629         objfile_compunits.
9630         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9631
9632 2019-01-09  Tom Tromey  <tom@tromey.com>
9633
9634         * symtab.c (search_symbols)
9635         (default_collect_symbol_completion_matches_break_on): Use
9636         objfile_msymbols.
9637         * ada-lang.c (ada_lookup_simple_minsym)
9638         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9639         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9640         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9641         objfile_msymbols.
9642         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9643         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9644         * objc-lang.c (find_methods): Use objfile_msymbols.
9645         (info_selectors_command, info_classes_command): Likewise.
9646         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9647         * objfiles.h (class objfile_msymbols): New.
9648         (ALL_OBJFILE_MSYMBOLS): Remove.
9649         (ALL_MSYMBOLS): Remove.
9650
9651 2019-01-09  Tom Tromey  <tom@tromey.com>
9652
9653         * common/next-iterator.h (next_adapter): Add Iterator template
9654         parameter.
9655         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9656         (class all_objfiles_safe): New.
9657         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9658         * objfiles.c (put_objfile_before): Update comment.
9659         (add_separate_debug_objfile): Likewise.
9660         (free_all_objfiles): Use all_objfiles_safe.
9661         (objfile_purge_solibs): Likewise.
9662
9663 2019-01-09  Tom Tromey  <tom@tromey.com>
9664
9665         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9666         (expand_symtab_containing_pc, lookup_static_symbol)
9667         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9668         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9669         all_objfiles.
9670         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9671         * breakpoint.c (create_overlay_event_breakpoint)
9672         (create_longjmp_master_breakpoint)
9673         (create_std_terminate_master_breakpoint)
9674         (create_exception_master_breakpoint): Use all_objfiles.
9675         * linux-thread-db.c (try_thread_db_load_from_pdir)
9676         (has_libpthread): Use all_objfiles.
9677         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9678         * linespec.c (iterate_over_all_matching_symtabs)
9679         (search_minsyms_for_name): Use all_objfiles.
9680         * maint.c (maintenance_info_sections): Use all_objfiles.
9681         * main.c (captured_main_1): Use all_objfiles.
9682         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9683         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9684         * guile/scm-pretty-print.c
9685         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9686         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9687         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9688         (maintenance_print_msymbols): Use all_objfiles.
9689         * source.c (select_source_symtab): Use all_objfiles.
9690         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9691         * symfile.c (remove_symbol_file_command)
9692         (expand_symtabs_matching, map_symbol_filenames): Use
9693         all_objfiles.
9694         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9695         all_objfiles.
9696         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9697         * objc-lang.c (find_methods): Use all_objfiles.
9698         * objfiles.c (have_partial_symbols, have_full_symbols)
9699         (have_minimal_symbols, qsort_cmp)
9700         (default_iterate_over_objfiles_in_search_order): Use
9701         all_objfiles.
9702         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9703         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9704         (maintenance_check_psymtabs): Use all_objfiles.
9705         (ALL_PSYMTABS): Remove.
9706         * compile/compile-object-run.c (do_module_cleanup): Use
9707         all_objfiles.
9708         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9709         * cp-support.c (add_symbol_overload_list_qualified): Use
9710         all_objfiles.
9711         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9712         Use all_objfiles.
9713         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9714         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9715         all_objfiles.
9716         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9717         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9718         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9719         Uses all_objfiles.
9720         * solib.c (solib_read_symbols): Use all_objfiles
9721
9722 2019-01-09  Tom Tromey  <tom@tromey.com>
9723
9724         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9725         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9726         all_objfiles.
9727         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9728         * symmisc.c (print_symbol_bcache_statistics)
9729         (print_objfile_statistics, maintenance_print_objfiles)
9730         (maintenance_info_symtabs, maintenance_check_symtabs)
9731         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9732         all_objfiles.
9733         * source.c (forget_cached_source_info): Use all_objfiles.
9734         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9735         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9736         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9737         * objfiles.c (update_section_map): Use all_objfiles.
9738         (shared_objfile_contains_address_p): Likewise.
9739         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9740         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9741
9742 2019-01-09  Tom Tromey  <tom@tromey.com>
9743
9744         * common/next-iterator.h: New file.
9745         * objfiles.h (class all_objfiles): New.
9746         (struct objfile_iterator): New.
9747
9748 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9749
9750         * NEWS: Move the description of the changed "frame", "select-frame",
9751          and "info frame" commands to the Changed commands section.
9752
9753 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9754
9755         * gdbtypes.c (check_stub_method_group): Remove handling of old
9756         mangling schemes.
9757         * linespec.c (find_methods): Likewise.
9758         * stabsread.c (read_member_functions): Likewise.
9759         * valops.c (search_struct_method): Likewise.
9760         (value_struct_elt_for_reference): Likewise.
9761         * NEWS: Mention this change.
9762
9763 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9764
9765         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9766         print_source_lines.
9767         * source.c (print_source_lines_base): Update line number check.
9768         (print_source_lines): New function.
9769         (source_lines_range::source_lines_range): New function.
9770         * source.h (class source_lines_range): New class.
9771         (print_source_lines): New declaration.
9772
9773 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9774
9775         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9776
9777 2019-01-08  Tom Tromey  <tom@tromey.com>
9778             Simon Marchi  <simon.marchi@ericsson.com>
9779
9780         PR gdb/24060
9781         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9782         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9783         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9784         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9785         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9786         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9787
9788 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9789
9790         * source.c (select_source_symtab): Move header comment to
9791         declaration in source.h.
9792         (forget_cached_source_info_for_objfile): Likewise.
9793         (forget_cached_source_info): Likewise.
9794         (identify_source_line): Likewise.
9795         * source.h (identify_source_line): Move declaration from symtab.h
9796         and add comment from source.c
9797         (print_source_lines): Likewise.
9798         (forget_cached_source_info_for_objfile): Likewise.
9799         (forget_cached_source_info): Likewise.
9800         (select_source_symtab): Likewise.
9801         (enum print_source_lines_flag): Move definition from symtab.h.
9802         * symtab.h (identify_source_line): Move declaration to source.h.
9803         (print_source_lines): Likewise.
9804         (forget_cached_source_info_for_objfile): Likewise.
9805         (forget_cached_source_info): Likewise.
9806         (select_source_symtab): Likewise.
9807         (enum print_source_lines_flag): Move definition to source.h.
9808         * tui/tui-hooks.c: Add 'source.h' include.
9809
9810 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9811
9812         * source.c (print_source_lines_base): Handle requests to print
9813         reverse line number sequences, and guard against empty lines
9814         string.
9815
9816 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9817
9818         * source.c (print_source_lines_base): Fix skip of '\r' if next
9819         character is '\n'.
9820
9821 2019-01-06  Tom Tromey  <tom@tromey.com>
9822
9823         * c-exp.y (struct c_parse_state) <macro_original_text,
9824         expansion_obstack>: New member.
9825         (macro_original_text, expansion_obstack): Remove globals.
9826         (scan_macro_expansion, scanning_macro_expansion)
9827         (finished_macro_expansion): Update.
9828         (scan_macro_cleanup): Remove.
9829         (yylex, c_parse): Update.
9830
9831 2019-01-06  Tom Tromey  <tom@tromey.com>
9832
9833         * c-exp.y (struct c_parse_state) <strings>: New member.
9834         (operator_stoken): Update.
9835
9836 2019-01-06  Tom Tromey  <tom@tromey.com>
9837
9838         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9839         (union type_stack_elt) <typelist_val>: Now a pointer to
9840         std::vector.
9841         (type_stack_cleanup): Don't declare.
9842         (push_typelist): Update.
9843         * parse.c (pop_typelist): Return a std::vector.
9844         (push_typelist): Take a std::vector.
9845         (follow_types): Update.  Do not free args.
9846         (type_stack_cleanup): Remove.
9847         * c-exp.y (struct c_parse_state): New.
9848         (cpstate): New global.
9849         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9850         (nonempty_typelist): Update.
9851         (func_mod): Create a new vector.
9852         (c_parse): Create a c_parse_state.
9853         (check_parameter_typelist): Do not delete params.
9854         (function_method): Update.  Do not delete type_list.
9855
9856 2019-01-06  Tom Tromey  <tom@tromey.com>
9857
9858         PR gdb/28155:
9859         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9860         check_typedef.
9861         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9862         (print_return_value): Likewise.
9863
9864 2019-01-05  Tom Tromey  <tom@tromey.com>
9865
9866         * contrib/cleanup_check.py: Remove.
9867         * contrib/gcc-with-excheck: Remove.
9868         * contrib/exsummary.py: Remove.
9869         * contrib/excheck.py: Remove.
9870
9871 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9872
9873         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9874         NULL. Initialize tpprev to NULL instead of assigning it
9875         to NULL on the next statement.
9876         * windows-nat.c (windows_delete_thread): Remove check for
9877         main_thread_id before printing thread exit notifications.
9878         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9879         Remove thread ID check against main_thread_id.
9880         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9881         windows_delete_thread.
9882         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9883
9884 2019-01-04  Tom Tromey  <tom@tromey.com>
9885
9886         * compile/compile.c (_initialize_compile): Use upper case for
9887         metasyntactic variables.
9888         * symmisc.c (_initialize_symmisc): Use upper case for
9889         metasyntactic variables.
9890         * psymtab.c (_initialize_psymtab): Use upper case for
9891         metasyntactic variables.
9892         * demangle.c (demangle_command): Use upper case for metasyntactic
9893         variables.
9894         (_initialize_demangler): Likewise.
9895         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9896         variables.
9897
9898 2019-01-03  Tom Tromey  <tom@tromey.com>
9899
9900         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9901
9902 2019-01-03  Tom Tromey  <tom@tromey.com>
9903
9904         * python/py-symtab.c (salpy_str): Update.
9905         (struct salpy_sal_object) <symtab>: Now a PyObject.
9906         (salpy_dealloc): Update.
9907         (del_objfile_sal): Use gdbpy_ref.
9908
9909 2019-01-03  Tom Tromey  <tom@tromey.com>
9910
9911         * python/py-type.c (convert_field): Use new_reference.  Return
9912         gdbpy_ref.
9913         (make_fielditem): Return gdbpy_ref.
9914         (typy_fields): Update.
9915         (typy_getitem): Update.
9916         (field_name): Return gdbpy_ref.  Use new_reference.
9917         (typy_iterator_iternext): Update.
9918
9919 2019-01-03  Tom Tromey  <tom@tromey.com>
9920
9921         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9922
9923 2019-01-03  Tom Tromey  <tom@tromey.com>
9924
9925         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9926         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9927         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9928         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9929         (pspy_set_type_printers): Likewise.
9930         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9931         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9932         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9933         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9934         (objfpy_set_type_printers): Likewise.
9935
9936 2019-01-03  Tom Tromey  <tom@tromey.com>
9937
9938         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9939         (gdbpy_print_stack): Use gdbpy_err_fetch.
9940         * python/python-internal.h (class gdbpy_err_fetch): New class.
9941         (class gdbpy_enter) <m_error_type, m_error_value,
9942         m_error_traceback>: Remove.
9943         <m_error>: New member.
9944         (gdbpy_exception_to_string): Don't declare.
9945         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9946         * python/py-value.c (convert_value_from_python): Use
9947         gdbpy_err_fetch.
9948         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9949         gdbpy_exception_to_string.
9950         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9951         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9952         gdbpy_err_fetch.
9953
9954 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9955
9956         * linux-nat.c (delete_lwp_cleanup): Delete.
9957         (struct lwp_deleter): New struct.
9958         (lwp_info_up): New typedef.
9959         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9960         lwp_info_up.
9961
9962 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9963
9964         * linux-fork.c (class scoped_switch_fork_info): New class.
9965         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9966
9967 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9968
9969         * valops.c (find_overload_match): Remove use of null_cleanup, and
9970         calls to do_cleanups.
9971
9972 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9973
9974         * compile/compile-cplus-types.c
9975         (compile_cplus_instance::decl_name): Handle changes to
9976         cp_func_name.
9977         * cp-support.c (cp_func_name): Update header comment, update
9978         return type.
9979         * cp-support.h (cp_func_name): Update return type in declaration.
9980         * valops.c (find_overload_match): Move temp_func local to top
9981         level of function and change its type.  Use temp_func to hold and
9982         delete temporary string obtained from cp_func_name.
9983
9984 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9985
9986         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9987         gdb::char_vector, remove cleanup, and update uses of `msg`.
9988
9989 2019-01-03  Jim Wilson  <jimw@sifive.com>
9990
9991         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9992
9993 2019-01-02  Tom Tromey  <tom@tromey.com>
9994
9995         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9996         (tdesc_parse_xml): Remove cleanups.
9997         * target-descriptions.h (make_cleanup_free_target_description):
9998         Don't declare.
9999         (target_desc_deleter): New struct.
10000         (target_desc_up): New typedef.
10001         * target-descriptions.c (target_desc_deleter::operator()): Rename
10002         from free_target_description.
10003         (make_cleanup_free_target_description): Remove.
10004
10005 2019-01-02  Tom Tromey  <tom@tromey.com>
10006
10007         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10008         constructor, destructor.
10009         (linespec_parser): Remove typedef.
10010         (~linespec_parser): Rename from linespec_parser_delete.
10011         (linespec_lex_to_end, linespec_complete_label)
10012         (linespec_complete): Update.
10013         (decode_line_full): Remove cleanups.
10014         (decode_line_1): Update.
10015
10016 2019-01-02  Tom Tromey  <tom@tromey.com>
10017
10018         * python/python-internal.h (inferior_to_inferior_object): Change
10019         return type.
10020         * python/py-exitedevent.c (create_exited_event_object): Update.
10021         * python/py-inferior.c (inferior_to_inferior_object): Return
10022         gdbpy_ref.
10023         (python_new_inferior, python_inferior_deleted)
10024         (thread_to_thread_object, delete_thread_object)
10025         (build_inferior_list, gdbpy_selected_inferior): Update.
10026         * python/py-infthread.c (create_thread_object): Update.  Also fail
10027         if inferior_to_inferior_object fails.
10028
10029 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10030
10031         * inferior.h (class inferior) <displaced_step_state>: New field.
10032         * infrun.h (struct displaced_step_state): Move here from
10033         infrun.c.  Initialize fields, add constructor.
10034         <inf>: Remove field.
10035         <reset>: New method.
10036         * infrun.c (struct displaced_step_inferior_state): Move to
10037         infrun.h.
10038         (displaced_step_inferior_states): Remove.
10039         (get_displaced_stepping_state): Adust.
10040         (displaced_step_in_progress_any_inferior): Adjust.
10041         (displaced_step_in_progress_thread): Adjust.
10042         (displaced_step_in_progress): Adjust.
10043         (add_displaced_stepping_state): Remove.
10044         (get_displaced_step_closure_by_addr): Adjust.
10045         (remove_displaced_stepping_state): Remove.
10046         (infrun_inferior_exit): Call displaced_step_state.reset.
10047         (use_displaced_stepping): Don't check for NULL.
10048         (displaced_step_prepare_throw): Call
10049         get_displaced_stepping_state.
10050         (displaced_step_fixup): Don't check for NULL.
10051         (prepare_for_detach): Don't check for NULL.
10052
10053 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10054
10055         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10056          in case of call that did not complete.
10057
10058 2019-01-02  Andrey Utkin  <autkin@undo.io>
10059
10060         * symfile.c (find_separate_debug_file): Fix search of debug files for
10061         remote debuggee.
10062
10063 2019-01-02  Tom Tromey  <tom@tromey.com>
10064
10065         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10066         indentation.
10067         * python/py-frame.c (frapy_older): Remove cast.
10068         (frapy_newer): Likewise.
10069         * python/py-breakpoint.c (local_setattro): Remove cast.
10070         * python/py-arch.c (archpy_name): Remove local variable.
10071         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10072
10073 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10074
10075         * unittests/basic_string_view/element_access/char/empty.cc:
10076         Fix year range in copyright header.
10077
10078 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10079
10080         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10081         Delete.
10082         <operator==>: Update with for removed field.
10083         <hash>: Likewise.
10084         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10085         <isa_features>: ...this.
10086         <abi_features>: New field.
10087         (riscv_isa_flen): Update comment.
10088         (riscv_abi_xlen): New declaration.
10089         (riscv_abi_flen): New declaration.
10090         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10091         isa_features.
10092         (riscv_abi_xlen): New function.
10093         (riscv_isa_flen): Update to get answer from isa_features.
10094         (riscv_abi_flen): New function.
10095         (riscv_has_fp_abi): Update to get answer from abi_features.
10096         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10097         xlen and flen.
10098         (riscv_call_info) <xlen, flen>: Update comment.
10099         (riscv_call_arg_struct): Remove invalid assertions
10100         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10101         is removed.
10102         (riscv_gdbarch_init): Gather isa features and abi features
10103         separately, ensure both match on the gdbarch when reusing an old
10104         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10105         a target with 64-bit float hardware.
10106
10107 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10108
10109         * source.c (search_command_helper): Stop reverse search
10110         when line 1 has been searched.
10111
10112 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10113
10114         * record-full.c (record_full_base_target::close): Rewrite
10115         record_full_core_buf_list free logic.
10116
10117 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10118
10119         * break-catch-syscall.c (print_one_catch_syscall): xfree
10120         the last text.
10121
10122 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10123
10124         * top.c (print_gdb_version): Update Copyright year in version
10125         message.
10126
10127 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10128
10129         Update copyright year range in all GDB files.
10130
10131 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10132
10133         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10134
10135 For older changes see ChangeLog-2018.
10136 \f
10137 Local Variables:
10138 mode: change-log
10139 left-margin: 8
10140 fill-column: 74
10141 version-control: never
10142 coding: utf-8
10143 End:
10144